Ability to override default isComponentOfType implementation

Fixes #1148
Let me know if any fixes required.

How do you use it? I see there is a variable defined on the global scope of the module but are you overriding through window? The usage should be defined as well. I don't like too much the function to depend on an external variable definition, maybe there is a way to achieve a similar behavior using something more explicit like env variables. This way you transform the source specifying wether you want to use the default checker when you run the transpiler.

Hey, the variable is defined not in global scope but in scope of the module is-component-of-type.js. The usage is pretty simple. In your root React file just import overrideComponentTypeChecker and pass there your checker function.  I don't see a way to change the default behaviour without changing an external value. Here's an example from my app with React-hot-loader:
import React from 'react'
import { render } from 'react-dom'
import { AppContainer } from 'react-hot-loader'
import { overrideComponentTypeChecker } from 'react-toolbox'
import store from 'redux/configureStore'
import Root from 'components/Root'

overrideComponentTypeChecker((classType, reactElement) => (
  reactElement && (
    reactElement.type === classType ||
    reactElement.type.name === classType.displayName
  )
))

const throwError = ({ error }) => { throw error }
render(
  <AppContainer errorReporter={throwError}>
    <Root store={store} />
  </AppContainer>,
  document.getElementById('root'),
)

if (module.hot) {
  module.hot.accept('components/Root', () => {
    System.import('components/Root').then(RootModule => {
      const UpdatedRoot = RootModule.default

      render(
        <AppContainer errorReporter={throwError}>
          <UpdatedRoot store={store} />
        </AppContainer>,
        document.getElementById('root'),
      )
    })
  })
}

Let me know what do you think. I didn't get an idea about env approach. How will you provide the checker function then?

No your right, I think it makes sense. Now that the example is documented in the same PR we can merge it. Looks good, thanks! :)

Such documentation should be in README.
Currently it can be just a link to this PR discussion to allow all users with

I suggest this change:
Usage with react-hot-loader v3
Since react-hot-loader v3 babel patch leads to issues with some components (see #1152, #1155) to allow hot reloading in dev mode you need to define your own type checker in your main entry point (see #1164 for details):
import "react-hot-loader/patch"
import React from 'react'
import { overrideComponentTypeChecker } from 'react-toolbox'

overrideComponentTypeChecker((classType, reactElement) => (
  reactElement && (
    reactElement.type === classType ||
    reactElement.type.name === classType.displayName
  )
))

Looks good! PR?

I was thinking about this addition. And here is my thoughts.

I don't like the idea to force usage of overrideComponentTypeChecker in main entry point.

Maybe we can just add this code ( ||  reactElement.type.name === classType.displayName) to the default type checker. Not sure if this can lead to issues.
Or maybe we can use a switch to detect react hot loader and use custom code. E.g.

export function defaultChecker (classType, reactElement) {
  if (typeof global.__REACT_HOT_LOADER__ !== 'undefined') { // or if (process.env.NODE_ENV !== 'production')
    return reactElement && (
      reactElement.type === classType ||
      reactElement.type.name === classType.displayName
    )
  } else {
    return reactElement && reactElement.type === classType
  }
}

If we cannot avoid focing users to add this extra code in main file (why?), maybe we can provide a ready method for not to write this copy-paste. Like overrideComponentTypeChecker(hotLoaderTypeChecker) or just setComponentTypeCheckerForHotLoader()

It shouldn't create any issues. Do you want to PR this fix? Makes total sense

It would be great to still have an ability to change defaultTypeChecker by hand or to switch it into displayName mode manually. I think there may be other cases except of React-hot-loader compat.

@javivelasco which version do you want as a PR?

Ok, my vision is as such:
import global from 'global'

let customChecker

export function overrideComponentTypeChecker (providedChecker) {
  customChecker = providedChecker
}

export function defaultChecker (classType, reactElement) {
  return reactElement && reactElement.type === classType
}

export function defaultCheckerWithDisplayNameCheck(classType, reactElement) {
    return reactElement && (
      reactElement.type === classType ||
      reactElement.type.name === classType.displayName
    )
}

export default function isComponentOfType (classType, reactElement) {
  if (customChecker) {
    return customChecker(classType, reactElement)
  } else if (typeof global.__REACT_HOT_LOADER__ !== 'undefined') {
   return defaultCheckerWithDisplayNameCheck(classType, reactElement)
  } else {
    return defaultChecker(classType, reactElement)
  }
}

please comment if you accept this (with an extra dep 'global') and if you accept code without semicolons  . I will provide a PR afterwards.

To me it looks ok and functional. But it needs to be adapted to the code style defined by eslint which basically it's airbnbs (with semicolons)

ok, I'll do that

Actually I'm not sure why shouldn't we just make the check in the same function.

please decide ;)
Not sure, but issues could raise out of minification (if comparing type.name would lead to false positives)
Related: hot-loader issue and react-devtools issue

I'm not sure about this anyway. I was trying the solution in a project with react-hot-loader and it didn't work nicely. Maybe we can just keep the ability to override the function so anybody can write its own.

Maybe point 2 from https://github.com/react-toolbox/react-toolbox/pull/1164#issuecomment-275062357 is what we need? E.g. overrideComponentTypeChecker(hotLoaderTypeChecker)


Add support for the cf.image field in fetch() properties

Per the definition in https://github.com/cloudflare/workerd/blob/4fb4dbd88d30ff293267680d85a31ddef94fd9b6/types/defines/cf.d.ts#L171-L295.
This is based on the existing https://github.com/cloudflare/workers-rs/pull/233 authored by @seeekr, with some improvements and the completion of the set of properties supported.

@zebp any chance this could be reviewed? 🙂
Seems like there generally is a lot of outstanding PRs open and ready to be reviewed. I wonder what the best process of getting one's PR reviewed and merged is here? I think it would make sense to perhaps document the process in the README or, otherwise, external contributors may get discouraged from getting involved, seeing their contributions not picked up for review long after submission? (General observation, nothing personal!)

Any updates? I really need this …
Thanks for doing this @jakubadamw!


Target rates not picking correct slots

Describe the bug
I have configured a target sensor for the Agile Outgoing tariff. I might be missing something so apologies in advance.
Set hours to 7, continuous and 12:00 to 19:00. The sensor will come on regardless if it is highest or lowest rate.
To be honest I was only testing this to see if it works with any tariff as the description says it will look for the lowest rate which doesn't work for export. For outgoing would need the highest rate. I have tried it with intermittent option with same results.
When I don't specify the time range it will just go off and never turns on.
To Reproduce
Create a target rate sensor for Agile Outgoing tariff.
Expected behavior
Sensor to come on when price of export is highest or close to highest. This of course if it is able to track highest prices too.
Home Assistant 2022.12.4
v5.1.0

Hello, sorry you're having issues.
As you've said you set the sensor to 7 hours between 12:00 and 19:00, it will just be on constanlty between 12:00 and 19:00.
If you set the hours to something like 1, then based on https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/issues/61 and continous to on, then it should come on for only 1 hour when it's the highest combined between 12:00 and 19:00. If intermittent was on, then it would come on the two 30 minute periods that are the highest between 12:00 and 19:00.
I think this is something I need to spend some time and update the docs with better explainations, but hope this explaination helps :)

Ok thanks for the explanation. And great work on this module. I have tested both cont and intermittent and it seems to work. However it is picking the lowest price.
What determines in the code to pick lowest or highest? Is it the is_export attribute?
Mine shows false on that one even though it is definitely an export tariff. Not sure why.

This is now working for me. The export attribute is now showing true and it is tracking highest prices.
Thanks for support.

The "export" part is determined by the meter you assign to the sensor. I'm limited in how these meters are displayed by Home Assistant, but will try and make this better. Did you do anything for the export attribute to start displaying?

That attribute is set by Octopus and the tarrif as you mentioned. Mine was not set to true because my export tariff had an issue and the team had to run something in the background to fix. After that it changed to true.
On the another note. The targets are working but it would be good if I could select rolling option but also select just one highest price in the time range. At the moment it will find the highest but then it will find another within the set time range and turn on again. This happens if I set 0.5h and let's say 6-10am. It will pick one at 6.30 and then another at 9 maybe. Tried both int and cont options.
So if I could tick another box saying only one half hour within the time range that would be good.

At the moment it will find the highest but then it will find another within the set time range and turn on again. This happens if I set 0.5h and let's say 6-10am. It will pick one at 6.30 and then another at 9 maybe

This is where you would uncheck Re-evaluate multiple times a day. With this unchecked, it will find the highest 0.5h slot between 6 and 10 and not come on any other time until the next day.


[REST] resources not reloaded from JMX console

this is not an issue. have to refresh changed Module, then reload Resource, and it works as expected.


Send to PostCSS plugins catalog

Amazing plugin! I will try to promote it in @postcss Twitter too.
Can you send it to https://www.postcss.parts/ ?

Thank you! Much appreciated
Yup, I can send it to postcss.parts sometime this week. Will keep this issue open until I do that

https://github.com/himynameisdave/postcss-plugins/pull/348


Update: Change licensing method to facilitate development

Please see common-samples/issues/2910 for the details. This PR aims to

Get rid of the "uncomment a line in AppDelegate" step for daily development or archive
Don't give fatalError if no API key or license key provided; instead make these keys optional

After these changes, the new behaviors...

No key provided: login required, license watermark exists after successful ArcGIS Identity login
API key provided: basemap can show, license watermark appear on the basemap
License key provided: login required, license watermark disappear
Both provided: normal as before, no watermark or login required

Looks good.
One other suggestion is to re-think the configure app secrets section in the doc.
For users who just want to run the samples, I think it's overkill to describe how to license the app. That's really not needed.
We should focus on getting them to configure an API key instead, that's what they will need to because most samples use developer basemaps. We can document that if they don't set the apiKey, they will be prompted to sign in with a named user to access the basemaps in the samples
We can either completely leave out the license steps, or describe them next as an optional step for folks who want to get rid of the watermark.


[turbopack] - PageNotFoundError

What version of Turborepo are you using?
Next V13.5.4
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Windows
Describe the Bug
when runnning next dev --turbo I get this error
⨯ PageNotFoundError: Cannot find module for page: route not found /
    at Object.ensurePage (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/lib/router-utils/setup-dev.js:825:27)
    at async Object.ensurePage (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/lib/router-server.js:87:24)
    at async DevServer.ensurePage (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/dev/next-dev-server.js:510:9)
    at async Object.ensure (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/dev/next-dev-server.js:163:17)
    at async DevRouteMatcherManager.matchAll (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/future/route-matcher-managers/dev-route-matcher-manager.js:94:13)
    at async DevRouteMatcherManager.match (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/future/route-matcher-managers/default-route-matcher-manager.js:159:26)
    at async DevServer.handleCatchallRenderRequest (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/next-server.js:567:27)
    at async DevServer.handleRequestImpl (/home/vincent/Warp/gold-frontend/node_modules/next/dist/server/base-server.js:728:17) {
  code: 'ENOENT'
}

Expected Behavior
it's  working without turbo. I was also able to reproduce under WSL with ubuntu 22.04.
To Reproduce
We're still using the pages directory. If I delete index.page.tsx at the root of the pages directory I don't get the error and I get the 404 page instead. If I go to any other page in my directory eg: login I get the same error.
I can give a slimmed down version of our app with only the pages directory if this helps
Reproduction Repo
No response

I have the same issue

Me too


fix(web): Migrate controller tests from S3 to SQL

Of course the S3-backed tests never actually ran
and the migration to SQL exposed a handful of
minor bugs/inconsistencies.

Some groovy reformatting apparently made it into this PR.
Let me know if it's grief worthy and I can artisanally back it out.


Error from global error handler TypeError: Cannot read properties of undefined (reading 'add')

Command
build, run, serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Getting this error in my app. And not able to fix it. Tried may ways from past 1 month. Please help.
Issue getting from<EMAIL_ADDRESS>Line number : 622 and 625.

Minimal Reproduction
When I go to this page I am getting the error :
https://app.lottosocial.com/mainTabs/tabs/syndicate
Vendor JS file : https://app.lottosocial.com/vendor.fabb00d05b4c73bf.js
Exception or Error
vendor.fabb00d05b4c73bf.js:1 Error from global error handler TypeError: Cannot read properties of undefined (reading 'add')
    at lt.value (vendor.fabb00d05b4c73bf.js:1:3156453)
    at ee.value (vendor.fabb00d05b4c73bf.js:1:3144328)
    at vendor.fabb00d05b4c73bf.js:1:2661404
    at Array.forEach (<anonymous>)
    at un.value (vendor.fabb00d05b4c73bf.js:1:2661367)
    at vendor.fabb00d05b4c73bf.js:1:2660728
    at l.value (vendor.fabb00d05b4c73bf.js:1:2829619)
    at un.value (vendor.fabb00d05b4c73bf.js:1:2660558)
    at un.value (vendor.fabb00d05b4c73bf.js:1:2660042)
    at Ri (vendor.fabb00d05b4c73bf.js:1:2721911)
    at Ji (vendor.fabb00d05b4c73bf.js:1:2721706)
    at Fi (vendor.fabb00d05b4c73bf.js:1:2721423)
    at zc (vendor.fabb00d05b4c73bf.js:1:2752414)
    at Gp (vendor.fabb00d05b4c73bf.js:1:2752688)
    at zc (vendor.fabb00d05b4c73bf.js:1:2752713)
    at Gp (vendor.fabb00d05b4c73bf.js:1:2752688)
    at zc (vendor.fabb00d05b4c73bf.js:1:2752713)
    at Gp (vendor.fabb00d05b4c73bf.js:1:2752688)
    at zc (vendor.fabb00d05b4c73bf.js:1:2752713)
    at Gp (vendor.fabb00d05b4c73bf.js:1:2752688)

Vendor file : https://app.lottosocial.com/vendor.fabb00d05b4c73bf.js

Your Environment
Angular CLI: 13.3.10
Node: 16.17.0
Package Manager: npm 8.19.2
OS: win32 x64

Angular: 13.3.12
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1303.10
@angular-devkit/build-angular   13.3.10
@angular-devkit/core            13.3.10
@angular-devkit/schematics      13.3.10
@angular/cdk                    13.3.9
@angular/cli                    13.3.10
@angular/fire                   7.5.0
@angular/flex-layout            11.0.0-beta.33
@angular/material               13.3.9
@angular/pwa                    0.803.29
@schematics/angular             13.3.10
rxjs                            6.6.7
typescript                      4.6.4

Anything else relevant?
No response

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.

This may be due to the usage of an unsupported browser.


'Query search for matches issue' with Trie data structure

Simply put, this Git source hasn't fixed the issue that could be described as:
With Bloodhound engine data to search for California, we type 'c' and retrieves the state with typeahead (54 states data). but typing 'l', 'i', 'for', 'li',... does not include California as a selective option or even nothing found. Try it here with all examples EXCEPT for the very first one.
Source: my post at Twitter Typeahead git (search_index.js)
If your version based off this stale version, please have a look at my raised concern:
https://github.com/twitter/typeahead.js/commit/7ed93f9#commitcomment-14598011
If the problem is on Trie data structure, could you change the [node data method] (https://github.com/twitter/typeahead.js/blob/7ed93f9759b0eacaaca8d3568ca8087a70d7091a/src/bloodhound/search_index.js#L55)  in search_index.js so as to fix it?

In a further research about trie data structure, I found this http://jsfiddle.net/4Yttq/ but don't fully understand it so as to fix the problem with matching of only first character in the combo typeahead-bloodhound.

Maybe, the solution is to twist it and apply the multi-way Tries

There do appear to be a few ternary trie javascript implementations - would you like to take a look and send a PR this way? It looks like the change wouldn't be overly complicated.

Problem is that I don't know anything about Trie data structure, and I couldn't implement it the right way because I m not good at writing JS library.


Delete a running pipeline build will not stop the build

rancher/rancher:v2.1.3
Steps to reproduce:

Trigger 3 builds
2 of them start running and 1 is in queuing state
Delete the 2 running builds instead of stop them

Results:
My third build is still in the queuing state. It looks like the removed builds are still running

LGTM


Understanding of some functions？

Hello
Thank you for your generous sharing!
When I was learning your code, I didn’t quite understand the meaning of these functions, such as createRotationMatix, projectOntoPlane.
Especially this process :
Mat3f m = Mat3f.createRotationMatrix( mChain.get(loop-1).getDirectionUV() )
Vec3f relativeHingeRotationAxis = m.times( thisBoneJoint.getHingeRotationAxis() ).normalise()
thisBoneOuterToInnerUV = thisBoneOuterToInnerUV.projectOntoPlane(relativeHingeRotationAxis);
Looking forward to your reply!
If you're busy, could you recommend me some papers to understand this process?
Thanks!

Hi! All the methods are documented, so you can either have a look at the javadoc documentation, or at the source code for any given method (also the lines of code you mention should be commented with regard to what they're doing, but perhaps you're kinda confused as to why they're doing it?). Anyways, I'll have a go at explaining...
If you point the first finger of your left hand at the screen (forward/Z-axis) with your thumb pointing upwards (up/Y-axis) (i.e. finger-gun!) then if you put your middle finger pointing to the right (right/X-axis) then that's basically a 3x3 'rotation matrix' - it contains the directions of the X/Y/Z axes. Each axis (i.e. finger) has a direction, and we can describe this direction as a set of three values which are just how much the finger/axis is pointing to the right, how much it's pointing up, and how much it's pointing forward.
For example the direction (1, 0, 0) would be "right" / positive-X-axis because it's fully to the right (X), nothing on Y, and nothing on Z.
However, this is just in the "global" / world coordinate system. If I'm doing my left-hand fingers-as-axes thing and I turn my body 90 degrees to the right then my fingers are still making the X/Y/Z axes... but these are now local / relative to me, rather than being the global / world directions. So this is kinda what's going on here:
1 - Generate a rotation matrix based on the direction of the "previous" (loop-1) bone in the IK chain
Mat3f m = Mat3f.createRotationMatrix( mChain.get(loop-1).getDirectionUV() )
The createRotationMatrix method creates a 3x3 matrix containing a set of orthogonal X/Y/Z axes (i.e. which way is right? (X), which way is up? (Y), and which way is forward? (Z)). Orthogonal just means that each axis is 90 degrees away from the other two axes [so "right" is 'up' rotated 90 degrees clockwise, and it's also 'forward' rotated 90 degrees clockwise]. So basically we're getting the coordinate system of that bone, i.e. which way us right/up/forward (X/Y/Z) for that bone. BTW, getDirectionUV gets the direction of the bone (i.e. the direction from the base of the bone to the tip of the bone as a unit-vector, that is, each value in the X/Y/Z triplet is in the range -1 to +1).
2 - Convert the hinge rotation axis into the coordinate system of the bone in the IK chain
Vec3f relativeHingeRotationAxis = m.times( thisBoneJoint.getHingeRotationAxis() ).normalise()
The hinge rotation axis is the direction about which the hinge rotates. For example, if you think of the door to your house - the hinge rotation axis would be the Y-axis so that the door can open and close about that axis. However, if you think of a "doggy-door" or cat-flap, then the hinge rotation axis would be the X-axis because they open by rotating from the bottom upwards.
When we specify a hinge rotation axis for a joint (which is at the start of the IK bone), we specify it in world-space because that's the only sensible option - but when we come to actually use the hinge rotation axis the bone has probably moved so we need to transform its hinge rotation axis from world-space into local-space (i.e. the coordinate system of the bone itself) - the way that we can do this is to multiply the hinge rotation axis by the rotation matrix of the bone, which we just calculated in step 1.
So what we're really doing is placing the hinge rotation axis of THIS bone into the coordinate system of the PREVIOUS bone in the chain (because in this part of the code we're working from the tip of the IK chain to the base of the chain during the "forward" pass).
The final .normalise() part just keeps all the values as unit-vectors (i.e. the value of each component (X/Y/Z) is confined to the range -1 to +1. This helps us to prevent weird math issues occuring when we actually go to do things with the direction later on!)
3 - Project this (outer) bone's direction onto the plane described by the hinge rotation axis we just calculated
thisBoneOuterToInnerUV = thisBoneOuterToInnerUV.projectOntoPlane(relativeHingeRotationAxis);
What we're doing in this part is getting the bone direction (well, technically the opposite direction to the bone because we're working from the outer joint to the inner joint, i.e. finger-tip to base-of-finger, but that doesn't matter right now) into the plane of the hinge rotation axis so we can restrict it to any clockwise/anti-clockwise limits (as specified by the bone's joint).
As we discussed above, hinges (i.e. doors, cat-flaps etc) have a hinge-rotation axis - this direction / axis is enough information for us to describe the plane (i.e. a flat surface) about which the rotation occurs. For example, the floor (or the ceiling, I guess - but then clockwise & anti-clockwise would go in the opposite directions!) is the plane of rotation for a standard door. Another way to think of it might be like putting a pencil pointing directly upwards on your desk - the plane about which you can rotate about the pencil describes the plane of your desk. If you put the pencil with its base against a wall pointing directly outwards, then the plane about the pencil's direction is the plane of the wall. So what we're doing here is projecting (i.e. converting) the direction of this bone so that it lies in the plane described by the hinge rotation axis.
Not sure if this is making sense - maybe think of it this way: If you have a pencil on your desk pointing up-right at 45 degrees, and you have a lamp directly to the left and above the pencil, then the shadow of the pencil on the desk is the direction of the pencil projected onto the plane of the desk. Now that the hinge rotation axis and the projected direction of the bone are both in the same plane, we can compare the bone's direction to any clockwise and anti-clockwise hinge rotation limits and move the bone direction back if it exceeds those limits, thus limiting how far any bone can rotate about its hinge rotation axis.
Hope this helps!

Thanks, I learned a lot from your reply!
But I have one last question, what's the meaning of BaseboneConstraintType(i.e. rotor)?
I know the Hinge joint, just like the normal manipulator joint, but what about the Rotor?  Does the Rotor equal to the twist joint?
Thanks!

No worries!
From: https://github.com/FedUni/caliko/blob/master/caliko/src/main/java/au/edu/federation/caliko/FabrikChain3D.java
public enum BaseboneConstraintType3D implements BaseboneConstraintType
{
	NONE,         // No constraint - basebone may rotate freely
	GLOBAL_ROTOR, // World-space rotor constraint
	LOCAL_ROTOR,  // Rotor constraint in the coordinate space of (i.e. relative to) the direction of the connected bone
	GLOBAL_HINGE, // World-space hinge constraint
	LOCAL_HINGE   // Hinge constraint in the coordinate space of (i.e. relative to) the direction of the connected bone
}

So, hinges are hinges like on a door etc. as we've discussed, and the hinge rotation axis can be specified in either local or global (i.e. "world-space") coordinates. Rotors aren't quite the twist, they're the angle relative to a given world-space direction (GLOBAL_ROTOR), or the angle relative to the direction of the connected bone (LOCAL_ROTOR).
If you take a look at the documentation at:
https://github.com/FedUni/caliko/blob/master/caliko-distribution/src/site/docs/caliko-user-guide.pdf
Then page 11 has details of joint types. If you then take a look at page 12 there's a GLOBAL_ROTOR constraint displayed as a red cone (top-left image, "Demo 3") - the bone cannot move outside of the angle described by the cone.
You can see the different joint types in action in the library demonstration video on youtube:
https://youtu.be/wEtp4P2ucYk?t=212
Hope this helps!

Thank u! It truely helps a lot!


Was CMake support removed?

Details

Read the Docs project URL: https://readthedocs.org/projects/python-xeddsa/
Build URL (if applicable): https://readthedocs.org/projects/python-xeddsa/builds/8307687/
Read the Docs username (if applicable): Syndace

Description
My project uses CMake to compile a library during the python package setup. Around four months ago it worked fine (for example this build succeeded), but now it seems like CMake is not installed or not available.

Hi! cmake was not available, I checked all the docker images.
The thing is that the package ref10 used to use make and gcc and now tries to use cmake and make.
From https://readthedocs.org/projects/python-xeddsa/builds/7632383/
Compiling the ref10 library...
Make sure "make" and "gcc" are installed and available.

and from https://readthedocs.org/projects/python-xeddsa/builds/8307687/
Attempting to compile the ref10 library...
The compilation requires CMake and the "make" tool.
The "cmake" and "make" commands are used.

I hope it helps.

Oh boy, and I even wrote that myself :D Well thank you, sorry for bothering

@Syndace Not a problem at all. :) Thank you.


Rewrite EC2 scripts (again) to remove CloudFormation

CloudFormation just isn't doing the job for us. Specifically, the major issues are:

We can't determine which availability zones in a region support subnets (see #1601)
Editing the template to remove resources when we're launching into an existing VPC is hacky and error-prone (see #1684)

We should just have the provision script use the AWS CLI to create each resource manually. We'll also need a cleanup script to destroy the cluster.

In practice, this hasn't really been an issue. The benefits of CloudFormation have outweighed the potential issues, and the workarounds (such as #1601) are clearly documented for users should they rn into issues.


REFRESH_GOLDEN broken in master

Some refactoring broke this functionality.

Looking into it. But it seems that no refactoring broke this, rather the introduced "HelmInject" tests do not take it into account at all :(

/assign @c0d1ngm0nk3y

@ymesika: GitHub didn't allow me to assign the following users: c0d1ngm0nk3y.
Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @c0d1ngm0nk3y

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Can this issue be closed?


latest Zanata translation changes in dashbuilder from 2017-01-24

@dgutierr can you ack this please once it is green

+1

jenkins retest this

there is a new PR #290 which has the same changes + more - so this can be closed


Add a pass to simplify single-character choices

I have a modified version of examples/xml.peggy in my project, and was trying to optimize it for speed. I found a few places where it could be rewritten to avoid backtracking, getting about a 20% win, but with some readability cost.
Then I noticed that there are a number of long lists of alternate character classes, and they end up being implemented very inefficiently; effectively it tries one regex after another in sequence.
I manually combined all the character classes for BaseChar into a single character class, and got a nearly 2x speed up.
So I've added a pass that does that automatically. The result is a more than 3x speedup parsing the xml files that I work with (which seem fairly typical).
The pass takes a rule like chars: "a" / "b" / [d-r] and turns it into chars: [abd-r]

I've put it under an option, mergeCharacterClasses because enabling it by default breaks a number of tests, which have specific expectations for error messages:
    Expected value to strictly be equal to:
      "Expected \"a\", \"b\", or \"c\" but \"d\" found."
    Received:
      "Expected [abc] but \"d\" found."

Since that test is specifically designed to ensure that an appropriate error message is output for choice nodes I didn't want to just change the expected output. But I'd be happy to change the grammar for such tests so that the choice nodes remain as choice nodes, and enable the optimization by default if that would be preferable.

I just realized I need to update lib/peggy.js and docs/js/examples.js now that this is done unconditionally. Should I do that now, or wait until you're happy with the state of the commit?

This looks good to me, I think.  @Mingun any other comments?

Except one needed addition:  a CHANGELOG entry, please.

Except one needed addition: a CHANGELOG entry, please

I put it in "minor" updates - let me know if if should be somewhere else...

Sorry for moving the goalposts, but once I thought of coverage on #427, there are a few lines that need to be hit on this one in lib/compiler/passes/merge-character-classes.js, unless they are particularly hard to reach.

I'm going off what I see in the coverage/lcov-report directory after having run npm run build.  That dir can sometimes be a little confusing because it doesn't get cleaned up every time, and the URLs change if you rerun with a subset of the tests.  Try deleting the directory, then navigating to the correct file from index.html when you run a different set of tests.
Here are the three lines that I currently see uncovered in the full test suite: 22, 67, 73.
I don't see breakpoints hit on any of those, but checked to make sure that I have everything set up right by having breakpoints fire on other lines in your file.

Also, I'm on the Discord channel if you want to try and figure this out in realtime.

I rewrote things a little:

some things that asClass was checking for were unnecessary because merge would have already handled them
preserve locations when merging nodes
only call cleanParts after merging all the alternates for efficiency

And then I updated the tests so that everything is covered.

@Mingun, one last thumbs-up, please?

@Mingun this one needs a final thumbs-up as well, please.

Anything else to do here?

@hildjj @Mingun ping again?


How to ask LLM generate ReAct format?

Did you use prompt like https://github.com/hwchase17/langchain/blob/bc2ed93b77cf9c40920ca5bf96968c90bb3e322e/langchain/agents/react/textworld_prompt.py#L4-L45  to ask GPT3 to generate result in ReAct format?
Or you just create many examples, and fine tune it, so it generate it? And this only works in your fine tuned model, and not working in GPT3-4?
I'd like to know if the method in langchain actually correct and works.

In the langchain example, they prepend the [EXAMPLES] which are examples of how to go about following the REact framework, this is basically few-shot learning based off prompt. This is purely prompt engineering and does not touch the weights of the model.
The method is correct.  You can also use the examples for fine-tuning the llms if you have the resources (data + compute) and want better results as shown by the author of the paper in a few different datasets challenges.

Thank you for the confirmation!
So in your paper, you are fine-tuning, which produces better output but needs a long period of data preparation.
I will use few-shot prompt engineering as a start, and collect data for fine-tuning.

I think the data collected for fine-tuning in this paper does not really require to take very long since the author just mention that they prompted the larger language models for the data, it is basically knowledge distillation.

hi @linonetwo , is there a followup question?

I was confused about why it could do this. But I read more materials these days and I know even OpenAI doesn't know why there is the emergence.


unzipping error when im bin\lime.py init

Downloading Closure Compiler:
515%
Unzipping...
Traceback (most recent call last):
File "C:\limejs\bin\lime.py", line 436, in
main()
File "C:\limejs\bin\lime.py", line 417, in main
checkDependencies()
File "C:\limejs\bin\lime.py", line 122, in checkDependencies
zippedFile = zipfile.ZipFile(zip_path)
File "C:\Python27\lib\zipfile.py", line 770, in init
self._RealGetContents()
File "C:\Python27\lib\zipfile.py", line 811, in _RealGetContents
raise BadZipfile, "File is not a zip file"
zipfile.BadZipfile: File is not a zip file

Hi rwsodinz, just submitted a pull request to fix this: #160.
I made a change to a few lines in the "lime.py" file to download the correct Closure Compiler.

I'm having this same issue now.


Fix hang in channel write

I found that still possibly hang with ch_sendraw on Windows. WriteFile return TRUE but no-writes.

I found that still possibly hang with ch_sendraw on Windows. WriteFile return TRUE but no-writes.

I see you are still making fixes.  Let me know when it's ready to include.
--
No man may purchase alcohol without written consent from his wife.
[real standing law in Pennsylvania, United States of America]
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Ready to merge. I wanted to make test pass, But test_restricted.vim seems to be wrong.

Codecov Report

Merging #3920 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3920      +/-   ##
==========================================
+ Coverage   78.84%   78.85%   +<.01%
==========================================
  Files         105      105
  Lines      142076   142076
==========================================
+ Hits       112024   112028       +4
+ Misses      30052    30048       -4

Impacted Files
Coverage Δ

src/channel.c
83.16% <ø> (+0.07%)
:arrow_up:

src/gui_beval.c
62% <0%> (-0.44%)
:arrow_down:

src/gui_gtk_x11.c
48.32% <0%> (-0.05%)
:arrow_down:

src/message.c
76.45% <0%> (-0.05%)
:arrow_down:

src/gui.c
58.05% <0%> (ø)
:arrow_up:

src/window.c
83.44% <0%> (+0.09%)
:arrow_up:

src/if_xcmdsrv.c
83.84% <0%> (+0.35%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c5632...f7472d5. Read the comment docs.

Now green.


Make minor adjustments to depth-metrics.h and a few dependencies to i…

…mprove modularity.

Thanks
please take a look on failed build in GHA.
D:\a\librealsense\librealsense\tools\depth-quality\depth-metrics.h(205,74): error C2065: 'M_PI': undeclared identifier (compiling source file D:\a\librealsense\librealsense\tools\depth-quality\rs-depth-quality.cpp) [C:\lrs_build\tools\depth-quality\rs-depth-quality.vcxproj]


sms.ibnux.net is down

Seems like sms.ibnux.net is down, still resolves to <IP_ADDRESS> but is not reachable.
Is Sms.ibnux.net Down?
Checking if sms.ibnux.net is down or it is just you...
It's not just you! sms.ibnux.net is down.

Cloudflare is not connected to my server in Indonesia Jakarta.
Now is connected again
I will create another server using cloudflare workers

Indeed, issue has been resolved


Side Panel: add action set control

What will this achieve?
This will really help to clean up the stories for the side panel. Similar to how the tearsheet has this, we need to add a storybook control that will allow you to toggle between different action variations.
How will success be measured?
When a custom control for this capability is added.


Fix multiple regressions

[x] Userspace backend completely broken
[ ] WireGuard tools not being installed properly (Potential Magisk upgrade regression?)

Test this at WireGuard-KT-71-307835b3552ceadb1a97341f1f8e3e647dfe78e5.apk.
This is an automatically posted message from Travis-CI

Test this at WireGuard-KT-71-5d1612867022332fd19ef8189f3601a46928282b.apk.
This is an automatically posted message from Travis-CI


The Link on Quick create: Enter new contacts fast is giving a 404

The Link on Quick create: Enter new contacts--fast! is giving a 404
Link :
https://docs.microsoft.com/en-us/dynamics365/basics/quick-create-enter-data-fast

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 832d1135-ada3-fa80-80ea-364ca35c724e
Version Independent ID: 4e5a692b-fd04-b662-79aa-52dce3a0ff15
Content: Create or edit leads (Dynamics 365 Sales)
Content Source: ce/sales-enterprise/create-edit-lead-sales.md
Service: dynamics-365-sales
GitHub Login: @shubhadaj
Microsoft Alias: shujoshi

@saviegas : Thank you for the feedback. The link is fixed and the updated content will be live in few hours.


Keyboard not acting right in ejected Andriod app

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Kind of
Environment
Environment:
OS:  Windows 10
Node:  8.4.0
npm:  4.2.0
Packages: (wanted => installed)
react-native: 0.52.0
react: 16.2.0
Target Platform: Andriod
Steps to Reproduce

Create some app with RN command line
Add text fields (3-4) in row
Eject it
Run with react-native run-andriod
Click on one
The keyboard opens

Expected Behavior
Without KeyboardAvoidingView the keyboard should flow over the input and layout. Before ejecting ir was fine.
Actual Behavior
It act's like with KeyboardAvoidingView
Reproducible Demo
Will add soon. But please, maybe someone can clarify right away.

Turns out in ejected app you should set in platform-wise. For Android android:screenOrientation="portrait" in AndroidManifest.xml


graphical issues with material_tester demo [intel, Linux]

Operating system or device - Godot version:
Arch Linux, Intel HD4000 (Mesa 17.1.4), Godot 3 master
Issue description:
I ran into a couple of graphical issues (glitches?) running the new material tester demo.
see the attached screenshot for details.

The grid-like artifacts all over the place (especially visible in the lower left part of the image)
I suspect this is either a driver issue or a quality setting of sorts?

The cheese example has this strange lighting effect on top, if you zoom in, select the Lobby as a background and move the camera a specific way so the window is behind the cheese.
This doesn't look realistic, since cheese should neither reflect so much light nor let it pass through the material so much.

I also have this issue.
Antergos x86_64 - Godot 3.0 master branch
(I'm probably using Intel/Mesa. I don't really know how to get hardware/driver info so I'll just spam command output in here. :P)
00:02.0 VGA compatible controller: Intel Corporation 4th Generation Core Processor Family Integrated Graphics Controller (rev 06)
...
01:00.0 3D controller: NVIDIA Corporation GF117M [GeForce 610M/710M/810M/820M / GT 620M/625M/630M/720M] (rev a1)

Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Intel Open Source Technology Center (0x8086)
    Device: Mesa DRI Intel(R) Haswell  (0x41e)
    Version: 17.1.4
    Accelerated: yes
    Video memory: 1536MB
    Unified memory: yes
    Preferred profile: core (0x1)
    Max core profile version: 4.5
    Max compat profile version: 3.0
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.1
...
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) Haswell
OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.1.4
...
OpenGL version string: 3.0 Mesa 17.1.4
...
OpenGL ES profile version string: OpenGL ES 3.1 Mesa 17.1.4

(I'm probably using Intel/Mesa. I don't really know how to get hardware/driver info so I'll just spam command output in here. :P)
00:02.0 VGA compatible controller: Intel Corporation 4th Generation Core Processor Family Integrated Graphics Controller (rev 06)
01:00.0 3D controller: NVIDIA Corporation GF117M [GeForce 610M/710M/810M/820M / GT 620M/625M/630M/720M] (rev a1)

You're indeed using Intel Haswell, though you do have a NVIDIA discrete GPU (Optimus) which you don't use. Check https://wiki.archlinux.org/index.php/NVIDIA_Optimus if you'd like to learn how to use it.

So I played around with the environment settings a bit and found out that the "grid effect" is caused by SSAO. Turning off SSAO completely or changing the bias settings to a higher value removes or reduces the effect. I suppose AO bias settings shouldn't really be gpu or driver specific?

So I played around with the environment settings a bit and found out that the "grid effect" is caused by SSAO. Turning off SSAO completely or changing the bias settings to a higher value removes or reduces the effect. I suppose AO bias settings shouldn't really be gpu or driver specific?

That part might be #8708.

Sounds like it's indeed a matter of the bias setting for the SSAO. However, Juan's default for this demo seemed to have worked for him (and others too) - so I guess this is still a gpu/driver specific issue.

So I've enabled secondary GPU and used both simultaneously.
Both have different issues.
Left: Nvidia/Nouveau (DRI_PRIME=1) | Right: Intel/Mesa

The issue on Nvidia/Nouveau won't happen until the scene is reloaded. The object will flash black then shadow artifacts appear.
The following screenshot is when the scene is not reloaded yet.

Have you tried the proprietary Nvidia driver yet? I think Nouveau also uses Mesa for its 3D rendering.

Using proprietary driver: Works perfectly. No any of the mentioned artifacts. Demo runs with higher framerate. ( Sorry, RMS :( )

For the SSAO issue, I think this is probably MESA's fault, we should probably report it
The cheese issue needs a bugfix, but i don't remember it being that bad, will have to check

I'll try to ask MESA devs for guidance on how we can debug that/report issues efficiently to them.

MSAA disabled
using nvidia and intel (screenshot is of both)
win10  nvidia 960m

and those box like shadow appears when i hit the screen margin of viewport

@gamergamesz Please open a new bug report, it might be a totally different issue (and it likely is, you are running on Windows 10 with the proprietary NVIDIA driver, this issue is about MESA on Linux).

ok

On 7c679dd83 with AMD Carrizo (R5) amdgpu, MESA 17.1.2, if I manage to pass the import (sometimes hangs the system, like Unreal when running) it looks really good but has the same cheesy problem as the OP.

Turning on ¨follow surface¨ ssurf scattering option makes the cheese looks like it should, could it be related?

@eon-s the bug with the cheese material is not related to SSAO, but to subsurface scattering (see #9530). This issue is not driver related. The problem with SSAO on MESA is the grid-like artifacts.

@vnen ah, okok, I was confused by the kaleidoscopic cheeses.
I don't see any SSAO artifact with that configuration then.

I saw a similar problem trying out Evee engine in the new Blender release. So I assume this is going to be quite a pain to resolve. xD

I am still out of Intel HD 4000 to test. Anyone else will have to fix the SSAO problem. The subsurf scattering problem i'm working on it

subsurf scatter issue is a duplicate of #9530

subsurf scatter issue is fixed, can't test SSAO

Arch Linux, HD4000 with Mesa 17.1.7
This is how the material tester demo looks on my system right now. Godot and the Demo are both on the latest version.  observations:

SSAO issue still present
the scene seems much too bright
there are no buttons to switch to the next material
performance seems much worse than I remember

I have the same issue on the same configuration.
I may investigate a little bit, but I'm not a shader expert.

With a SSAO-Bias setting of about 0.4 (from default 0.01) all of the artifacts are gone. However, there also doesn't seem to be any visible effect os SSAO being enabled

If apply the following patch, I've got no artifacts anymore:
-	float randomPatternRotationAngle = float((3 * ssC.x ^ ssC.y + ssC.x * ssC.y) * 10);
+	//float randomPatternRotationAngle = float((3 * ssC.x ^ ssC.y + ssC.x * ssC.y) * 10);
+	float randomPatternRotationAngle = 0.0;

need to investigate :)

@novemberist , could you check with the last master if the issue is still present ?

Already did. It's gone for me :) Good job! :+1:


Update default Cilium version to v1.13.1

Now that v1.13.1 is available, bumping this to the default version for the CLI to install.

Hi @gaffneyd4, thanks for the PR. It looks like the version was already bumped as part of https://github.com/cilium/cilium-cli/pull/1458 which was opened slightly earlier and now merged. That PR also bumped in the corresponding Helm charts for the newly released versions, which is required in order for installation to work correctly for these versions.


Unable to reach service backend running on remote node from host network

Bug report
Newly installed cluster with 1.8.0 and managed etcd fails to start new servers due to failed TLS client auth settings.
 When we run with hostService.enabled=true we can see the source IP to be the one from the cilium_host interface.
<IP_ADDRESS>.41980 > <IP_ADDRESS>.2379

with kube-proxy-replacement=disabled the packets were still from <IP_ADDRESS>.41980.
I had to delete Cilium's DS and delete cilium_host interface to see the packet coming from <IP_ADDRESS> which is the same behavior that happens when running with the options:
   --set global.kubeProxyReplacement=partial \
   --set global.hostServices.enabled=false \
   --set global.externalIPs.enabled=true \
   --set global.nodePort.enabled=true \
   --set global.hostPort.enabled=true \

This makes the packet to be dropped because the packets are being set to an interface that can't reach the backends running on the other node. Is likely the routing logic happens before the service translation occurs.

There have been many changes to the datapath since the issue was opened. Closing it. @aanm if you can reproduce it, please reopen it.


how to add graphql selectionSetList to Lambda Function Resolver via the amplify-cli

Note: If your question is regarding the AWS Amplify Console service, please log it in the
official AWS Amplify Console forum

Which Category is your question related to?
Lambda Functions
Amplify CLI Version
4.21.3
What AWS Services are you utilizing?
GraphQL (AppSync) with Cognito Auth
Lambda Function
Provide additional details e.g. code snippets
I would like to include selectionSetList and selectionSetGraphQL in the "Request Mapping Template" for my Lambda Resolver so that I can access details of the graphql query when handling the request in my Lambda Function.
I was able to do so manually in the AppSync console, like so:
## [Start] Invoke AWS Lambda data source: Sgo3testamplifyLambdaDataSource. **
{
  "version": "2018-05-29",
  "operation": "Invoke",
  "payload": {
      "typeName": "$ctx.stash.get("typeName")",
      "fieldName": "$ctx.stash.get("fieldName")",
      "arguments": $util.toJson($ctx.arguments),
      "selectionSetList": $util.toJson($ctx.info.selectionSetList),   <-- manually added
      "selectionSetGraphQL": $util.toJson($ctx.info.selectionSetGraphQL),   <-- manually added
     "identity": $util.toJson($ctx.identity),
      "source": $util.toJson($ctx.source),
      "request": $util.toJson($ctx.request),
      "prev": $util.toJson($ctx.prev)
  }
}
## [End] Invoke AWS Lambda data source: Sgo3testamplifyLambdaDataSource. **

This worked, and I was able to access these parameters in my lambda function. However, these changes didn't persist when I later updated the API and ran amplify push.
Is there a way for me to specify including the selectionSetList and selectionSetGraphQL fields somewhere in my local/amplify configuration so these fields will be added by the amplify-cli when I run amplify push?

Have you tried to use custom resolver for it.
https://docs.amplify.aws/cli/graphql-transformer/resolvers#add-a-custom-resolver-that-targets-an-aws-lambda-function

Hi @grez72 marking this as an enhancement as it seems like something we would consider adding to the default VTL resolver. But for now you can follow the link posted by @UnleashedMind on custom resolvers to solve your use case.

Any news on this enhancement?
I would like to use Amplify / Appsync as a proxy to internal GraphQL and REST microservices using a direct lambda resolver without needing to deal with custom VTL's.
Something like this https://aws.amazon.com/blogs/mobile/appsync-microservices/ but only using @function.

So I can't get the info object when using a lambda resolver with @function?

I ran into the same issues, and find out that you can customize pipelineFunctions instead of resolvers
This worked for me, create folder pipelineFunctions in /amplify/backend/api// and add req.vtl like
{   "version": "2018-05-29",   "operation": "Invoke",   "payload": {       "typeName": "$ctx.stash.get("typeName")",       "fieldName": "$ctx.stash.get("fieldName")",       "arguments": $util.toJson($ctx.arguments),       "identity": $util.toJson($ctx.identity),       "source": $util.toJson($ctx.source),       "request": $util.toJson($ctx.request),       "prev": $util.toJson($ctx.prev),       "selectionSetList": $util.toJson($ctx.info.selectionSetList),   } }
this file will be copied to build folder by Amplify.
*) You need to name the file in a way that Amplify can understand, some things like InvokeOrganizationHandlerLambdaDataSource.req.vtl or you can copy an original file from build folder.
As a result, I only need to fix one file for each lambda function instead of each query. In my case, one lambda function handles many queries, so a lot less vtl needs to customize.


Improve AST searching and symbol resolution primitives

There comments and the commit messages are written to stand on their own, so for context please look at those things. But for posterity, I will note that refactoring the onComplete logic is outside the scope of this patch set. That will come next.

Per offline chat with @jbeda we're going to go ahead and merge since Ruben signed off.


get data from outside alive possible?

I'm going to use javascript library to show data on front-end page.
and I want to get data from outside(google speadsheets or other services API).
inerval timing and cycic get & stored data from outside source...

I think it's a wrong place to ask this question. Builder's purpose is creating plugins and back-end user interfaces. What you are looking for is the front-end functionality. Please see the theming documentation.


628-add role of checkbox to panel items and label group

This closes issue: https://github.com/orgs/CodeForPhilly/projects/3?pane=issue&itemId=61905665&issue=CodeForPhilly|clean-and-green-philly|628
I checked this in Apple VO and it does seem to work. Would love another perspective and look though. I feel like we could use a more dynamic approach to the aria-label, maybe using aria-labeledby and targeting the h2, I struggled to get the correct h2, it would just target the first h2 on the page.

When calculating the accessible name of an element, the aria-labelledby will trump the contents in the button (see this screenshot from the accessibility tree, in terms of power it goes top to bottom. ). Maybe try aria-describedby instead and see how that sounds put together.
But if we can't pass an id to the H2 and target that, then I wouldn't worry about it too much. The checkbox is wordy, but it works.
@marvieqa this was your ticket, how do you think the filter sounds as a checkbox?

@Amberroseweeks let's submit PRs against main branch. Thanks!

@Amberroseweeks let's submit PRs against main branch. Thanks!

Thanks, will do in the future! :)

When calculating the accessible name of an element, the aria-labelledby will trump the contents in the button (see this screenshot from the accessibility tree, in terms of power it goes top to bottom. ). Maybe try aria-describedby instead and see how that sounds put together.
But if we can't pass an id to the H2 and target that, then I wouldn't worry about it too much. The checkbox is wordy, but it works.
@marvieqa this was your ticket, how do you think the filter sounds as a checkbox?

Okay thank you so much, I am going to give aria-describedby a shot!

Hi @Amberroseweeks, Vercel failed to deploy your latest code to its preview environment. Can you run lint in your local env and see if any error or warning appears? Thanks!

@Amberroseweeks Checking on this one too. It might be lint errors?

@Amberroseweeks Checking on this one too. It might be lint errors?

I believe so, I am just looking into how to resolve this. I had this issue back in March or April too.
I am also looking into how to connect aria-describedby to get the section header ID, for some reason it's not quite linking together, I wonder if it's a rendering issue

@Amberroseweeks can you try a rebase? I think @HeyZoos's recent PR cleared up some of our dependency issues on the FE. Might help here?

This issue was closed in a different pull request https://github.com/CodeForPhilly/clean-and-green-philly/pull/987


Category & ComparativeCategory Widgets: Add a skeleton for loading state

Description
Shortcut: https://app.shortcut.com/cartoteam/story/314283/new-loader-ui-for-widgets
[sc-314283]
Category and Comparative

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

20 of 20 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 72.148%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
2033

Relevant Lines:
2599

💛  - Coveralls


feat (Pages design): Workspace, Program, Auth pages

@brettstack @sanathkr can you please review and merge this p.r? 🙏

@brettstack @sanathkr can you please review and merge this p.r? 🙏

@brettstack Oh ya, regarding accessibility, had added the eslint rule through jsx-a11y library, I see some of the rules were disabled, will fix and push now. Will come back to accessibility with WAVE tool and fix other issues, for now will do the basic implementation like having the label etc that the library (jsx-a11y) requires.

@brettstack Oh ya, regarding accessibility, had added the eslint rule through jsx-a11y library, I see some of the rules were disabled, will fix and push now. Will come back to accessibility with WAVE tool and fix other issues, for now will do the basic implementation like having the label etc that the library (jsx-a11y) requires.

@brettstack done, fixed accessibility-related eslint issues. 🚀

@brettstack done, fixed accessibility-related eslint issues. 🚀

Well done! 🤜

Well done! 🤜

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[RFC] Add conditional-insert operator to pool/dict

While trying to reformat flowmap, I kept finding instances of:
for (auto item : source_pool)
    if (condition)
        dest_pool.insert(item);

This PR lets you now do:
dest_pool.insert_if(source_pool.begin(), source_pool.end(), [](/* ... */){ return condition; });

which I think is a bit terser. This could be further extended to:
dest_pool.insert_if(source_pool, [](/* ... */){ return condition; });

by internally calling begin/end, but I wanted to see if this appealed to others first.
Another candidate to add is possibly dict::insert_each or something like it for this pattern:
for (auto key : source)
    dest_dict[key].insert(item);

becoming:
dest_dict.insert_each(source.begin(), source.end(), item);

I wanted to see what others thought of this first though.

Seems like the consensus is it doesn't help readability for others.


11 implement job shop scheduling datastructure and hamiltonian encoding

closes #11

@svenpruefer as discussed i added some test cases here to check the jssp data structures, the hamiltonian encoder and the serialization. This branch is now definitely ready for your review (only some small changes to the random problem instance generation might still be incoming).


How to send Embed-Videos??

					$longVideo = "https://cdn.discordapp.com/attachments/758078168904237277/758348382828888104/github_-_Discord_2020-09-23_17-24-57.mp4";
					$shortVideo = "https://cdn.discordapp.com/attachments/758078168904237277/758348561364025394/Minecraft_2020-09-15_17-31-10.mp4";
					$embed = createEmbed(); //returns Embed
					$embed->type = Embed::TYPE_VIDEO;
					$embed->video = createVideo($shortVideo); //returns Video
					$embed->type = Embed::TYPE_IMAGE;
					$embed->color = 0x0000ff;

					$message->channel->sendEmbed($embed);

AFAIK, bots can't set type
For the embed object, you can set every field except type (it will be rich regardless of if you try to set it), provider, video, and any height, width, or proxy_url values for images.
Source: https://discord.com/developers/docs/resources/channel#create-message

try it, at my tests it doesn't work

send the video link into the channel


Default output to .mkv

New logic for determining output & ffmpeg sample output extension/container.

If -o is specified use the same extension.
If input is .mp4 use .mp4.
Otherwise use .mkv.

Resolves #72

Switched from preferring mp4 to mkv. See discussion in #72


[Client] MetaData doesn't work with List

public override void OnStart()
{
     var list = new List<string>()
     {
          "log1",
          "log2",
          "log3"
      };
      Alt.SetMetaData("testMeta", list);

      Alt.GetMetaData("testMeta", out List<string> result);
      Alt.LogError(result.First());
}

Now it's only possible to read any lists from MetaData as object[], the behavior is the same as in c# server module


Part of #23 - allow flagloader to set optional function to set flag usage

@fatih   This allow people to have function to set flag default Usage messages.  To write a test I had to save the temporary FlagSet that is created (as a private field in FlagLoader).  If you don't like this, we can either just delete the test (not great) or figure out another way to emit the usage and capture stdout/stderr  (really gross).
merge, comment or suggestions all welcome!
n

Thanks @client9, nice addition :+1:
I've made comments, once they are fixed this is good to go.

hello @fatih  good review.  I made all the changes requested.  Take a look!

LGTM.

Thanks @client9 for this addition, it'll make the flag loader more powerful. Much appreciated :)


Fixes for the Team Resource

Proposed fixes for #92:

Apply the team's name to the refreshed State during Read()
Use the Plan's team name and not the State's during Update()

Additional related Enhancement:

Force a resource replacement if the Team Name changes

Using the UI as a source of truth here (which might be mistaken, so let me know if it is), it's not intended/expected for a team's name to change once it's created. This seems supported by the original behavior of pulling the name from State during Updates. So if the expected way to rename a team is to delete and create a new one, this change is, to my knowledge, the "Terraform correct" way of expressing it.

Caveat
I don't have an effective way to test this at the moment and I don't have much functional experience with writing Terraform providers, so if something looks like a mistake, it probably is.

I think you need to remove this part

If you import the resource you will only have the team ID and the team name inside the state will be empty, so when you try to run the apply after importing the resource it will force the replace

Unless you update the import logic to include the name, similar to the following:
https://github.com/AzBuilder/terraform-provider-terrakube/blob/05331f30563adf61cf3939cc3114bb0b91ec7394/internal/provider/team_resource.go#L423

I think you need to remove this part

If you import the resource you will only have the team ID and the team name inside the state will be empty, so when you try to run the apply after importing the resource it will force the replace

If that's the case wouldn't all of the resource's attributes (minus the two being applied in the Import function) be proposed changes in a plan/apply after import? Or is there some scenario where it doesn't reconcile against the imported state in this case?

I think you need to remove this part

If you import the resource you will only have the team ID and the team name inside the state will be empty, so when you try to run the apply after importing the resource it will force the replace

If that's the case wouldn't all of the resource's attributes (minus the two being applied in the Import function) be proposed changes in a plan/apply after import? Or is there some scenario where it doesn't reconcile against the imported state in this case?

I guess you could import all the other attributes to the state but that will require more logic in the import function something similar to the read function to get all the permissions, that could be an option.

I must be just misunderstanding something then. Let me explain what I'm seeing on the end-user side of things and maybe we can figure out what I'm missing. Given the following code:
resource "terrakube_team" "example" {
  name            =<EMAIL_ADDRESS>  organization_id = terrakube_organization.example.id

  manage_state      = true
  manage_workspace  = true
  manage_module     = true
  manage_provider   = true
  manage_vcs        = true
  manage_template   = true
  manage_job        = true
  manage_collection = true
}

import {
  to = terrakube_team.example
  id = "org_id,team_id"
}

I had this plan output
  # terrakube_team.example will be updated in-place
  # (imported from "org_id,team_id")
  ~ resource "terrakube_team" "example" {
        id                = "team_id"
        manage_collection = true
        manage_job        = true
        manage_module     = true
        manage_provider   = true
        manage_state      = true
        manage_template   = true
        manage_vcs        = true
        manage_workspace  = true
      + name              =<EMAIL_ADDRESS>        organization_id   = "org_id"
    }

Now, my expectation is that https://github.com/AzBuilder/terraform-provider-terrakube/pull/93/commits/b842f392c01b77a4c108b8660f99f45d338579bf and/or https://github.com/AzBuilder/terraform-provider-terrakube/pull/93/commits/a4bc965419e67ec0238a01917324743fbbdb28db will resolve the problem of name being treated as a new/previously-unset attribute, which I would expect to create a plan output of
  # terrakube_example will be imported
  ~ resource "terrakube_team" "example" {
        id                = "team_id"
        manage_collection = true
        manage_job        = true
        manage_module     = true
        manage_provider   = true
        manage_state      = true
        manage_template   = true
        manage_vcs        = true
        manage_workspace  = true
        name              =<EMAIL_ADDRESS>        organization_id   = "org_id"
    }

What you appear to be suggesting is that with the inclusion of https://github.com/AzBuilder/terraform-provider-terrakube/pull/93/commits/9cc8a777c36592c77f320473851c4b6740acc3e7, I'll instead see a plan output suggesting that the team will need to be replaced, but I don't understand how that will be the case. If the name attribute is unchanged from state, which it would be if my original fixes were correct, then TF shouldn't see a need to replace the resource. If TF wasn't reading the resource's full attributes at some point between the import and the plan generation, then shouldn't it be proposing changes to the various manage_* attributes? They default to false, so being set to true, should constitute change, but their correct live state of true is being respected. Those attributes are also not manipulated in Import, which would suggest to me that Read() is being called between the import execution and the Plan generation.

It is working correctly I just tested it
user@pop-os:~/git/terraform-provider-terrakube/examples/full$ terraform apply

terrakube_team.team: Preparing import... [id=d9b58bd3-f3fc-4056-a026-1163297e80a8,5b89f40f-80d5-4267-a781-6367e04d5b5c]
terrakube_team.team: Refreshing state... [id=5b89f40f-80d5-4267-a781-6367e04d5b5c]

Terraform will perform the following actions:

  # terrakube_team.team will be imported
    resource "terrakube_team" "team" {
        id                = "5b89f40f-80d5-4267-a781-6367e04d5b5c"
        manage_collection = false
        manage_job        = false
        manage_module     = false
        manage_provider   = false
        manage_state      = false
        manage_template   = false
        manage_vcs        = false
        manage_workspace  = false
        name              = "TERRAKUBE_SUPER_ADMIN"
        organization_id   = "d9b58bd3-f3fc-4056-a026-1163297e80a8"
    }

Plan: 1 to import, 0 to add, 0 to change, 0 to destroy.
╷
│ Warning: WARNING
│
│   with provider["registry.terraform.io/alfespa17/terrakube"],
│   on main.tf line 9, in provider "terrakube":
│    9: provider "terrakube" {
│
│ In its current implementation, Terrakube creates one webhook for each instance of this resource and github has a default limitation of 20 webhooks per repository.
│
│ (and one more similar warning elsewhere)
╵

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

terrakube_team.team: Importing... [id=d9b58bd3-f3fc-4056-a026-1163297e80a8,5b89f40f-80d5-4267-a781-6367e04d5b5c]
terrakube_team.team: Import complete [id=d9b58bd3-f3fc-4056-a026-1163297e80a8,5b89f40f-80d5-4267-a781-6367e04d5b5c]

Apply complete! Resources: 1 imported, 0 added, 0 changed, 0 destroyed.

When I run the plan again it is showing
user@pop-os:~/git/terraform-provider-terrakube/examples/full$ terraform plan

terrakube_team.team: Refreshing state... [id=5b89f40f-80d5-4267-a781-6367e04d5b5c]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.
╷
│ Warning: WARNING
│
│   with provider["registry.terraform.io/alfespa17/terrakube"],
│   on main.tf line 9, in provider "terrakube":
│    9: provider "terrakube" {
│
│ In its current implementation, Terrakube creates one webhook for each instance of this resource and github has a default limitation of 20 webhooks per repository.
│
│ (and one more similar warning elsewhere)


API review changes.

This PR is to address comments not related to autogen for queue and file.
https://github.com/Azure/azure-sdk-for-java/issues/5676
https://github.com/Azure/azure-sdk-for-java/issues/5670

Just made a comment about one of the method signatures in files. (you could probably also do it in another PR if it's a change that needs to be done)

@gapra I have searched over the files. Make changes to non autogen code.


Some guidance on refresh flow

In first place, thanks so much for the huge effort on this boilerplate. It is one of the most complete one I have used.
I have been reading the code for the new refresh session workflow and did a couple of tests using the swagger documentation but I have been unable make it work.
It would be much appreciated to have some guidance about which parameters it should receive.
Thanks in advance

@totegsito thanks for your feedback!
I'm working on it 😉

@totegsito done 🥳


Visdom Always Offline

I cloned visdom, installed from source (using pip install -e .) and then also ran (python setup.py install) to finish the installation (visdom==<IP_ADDRESS>).  I started up the server (python -m visdom.server) and was able to bring up visdom in Chrome but it remains offline.
I can only click on the two dropdowns and when I click on "main", the following error prints out:
INFO:tornado.access:200 GET /env (::1) 22.98ms
INFO:tornado.access:200 GET /static/js/main.js?v=b65d2039276f4c6580171aca25bdd5e7 (::1) 3.40ms
INFO:tornado.access:200 GET /static/css/style.css?v=6c9680f97ddb1c54aee0576b12b8ce3b (::1) 1.66ms
INFO:tornado.access:200 GET /favicon.png (::1) 2.62ms
INFO:tornado.access:200 GET /env/socket (::1) 2.49ms
ERROR:tornado.application:Uncaught exception POST /env/env/main (::1)
HTTPServerRequest(protocol='http', host='localhost:8097', method='POST', uri='/env/env/main', version='HTTP/1.1', remote_ip='::1')
Traceback (most recent call last):
  File "../anaconda3/lib/python3.6/site-packages/tornado/web.py", line 1541, in _execute
    result = method(*self.path_args, **self.path_kwargs)
  File "../anaconda3/lib/python3.6/site-packages/visdom-<IP_ADDRESS>-py3.6.egg/visdom/server.py", line 718, in post
    load_env(self.state, args, self.subs[sid])
KeyError: None
ERROR:root:ERROR: 500: {'exc_info': (<class 'KeyError'>, KeyError(None,), <traceback object at 0x7f27ef1e5648>)}
ERROR:tornado.access:500 POST /env/env/main (::1) 2.50ms
INFO:tornado.access:304 GET /favicon.png (::1) 2.12ms
INFO:tornado.access:101 GET /vis_socket (::1) 0.49ms

The javascript console then has the following error:
WebSocket connection to 'ws://localhost:8097/env/socket' failed: Error during WebSocket handshake: Unexpected response code: 200 WrappedWebSocket@VM518:164

When I try to run the code example:
>>> import visdom
>>> import numpy as mp
>>> vis = visdom.Visdom()
>>> vis.text('Hello, world')
'window_36084c0e4eddf6'

The following is output but nothing shows up in visdom.
INFO:root:Opened visdom socket from ip: ::1
INFO:tornado.access:200 POST /events (::1) 0.85ms

The javascript console then has the following error:
Post http://localhost:9087/env/env/main 500 (Internal Sever Error)

send | @ | jquery.min.js?v=e071…4711cfc2ab99fe104:4
-- | -- | --
  | ajax | @ | jquery.min.js?v=e071…4711cfc2ab99fe104:4
  | r.(anonymous function) | @ | jquery.min.js?v=e071…4711cfc2ab99fe104:4
  | r.selectEnv | @ | main.js?v=b65d203927…580171aca25bdd5e7:1
  | r | @ | react-dom.min.js?v=8…04ed9a2dac56860e:14
  | a | @ | react-dom.min.js?v=8…04ed9a2dac56860e:12
  | s | @ | react-dom.min.js?v=8…04ed9a2dac56860e:12
  | f | @ | react-dom.min.js?v=8…04ed9a2dac56860e:12
  | m | @ | react-dom.min.js?v=8…04ed9a2dac56860e:12
  | r | @ | react-dom.min.js?v=8…04ed9a2dac56860e:15
  | processEventQueue | @ | react-dom.min.js?v=8…04ed9a2dac56860e:12
  | r | @ | react-dom.min.js?v=8…04ed9a2dac56860e:14
  | handleTopLevel | @ | react-dom.min.js?v=8…04ed9a2dac56860e:14
  | i | @ | react-dom.min.js?v=8…04ed9a2dac56860e:14
  | perform | @ | react-dom.min.js?v=8…04ed9a2dac56860e:15
  | batchedUpdates | @ | react-dom.min.js?v=8…04ed9a2dac56860e:14
  | i | @ | react-dom.min.js?v=8…04ed9a2dac56860e:14
  | dispatchEvent | @ | react-dom.min.js?v=8…04ed9a2dac56860e:14

Are there setup steps that I missed?

Hi @drothermel - have you used visdom at any point in the past? This behavior seems somewhat related to having existing env files from a previous build before we added some of the more recent features. Then again the fact that you were able to request the path /env/env/main is somewhat strange, let me investigate that.

ws://localhost:8097/env/socket isn't a real address on the visdom server, so I'm actually fairly certain that's the issue - are you just going to localhost:8097 and still getting those addresses?

Ahh, yup, thats the problem, I went to localhost:8097/env.  When I went to just localhost:8097 then it works as expected, thank you!

Yeah that's somewhat related to https://github.com/facebookresearch/visdom/issues/273, the feature used to work properly so the docs had prepopulated an empty env but I haven't had a chance to fix the env access by path yet. Thanks for noting it!

Hi, I have a similiar problem with you, but what I try to open is still localhost:8097. There always present an red 'offline' button on top right of the web page. And there is nothing wrong in the sever and also prints correct outputs in the command when I try to show something to localhost:8097.
The  localhost:8097 page have performed correctly before, but these days it began to go wrong and remains offline as shown in the following figure. I have no idea for what I have done to it. Is this because I have done some wrong operations I didn's know? And I am also very confused about the meaning of this 'offline'.

Looking forward to your reply. Thanks very much in advance!

Hi @fangxiaoke - I'll need to know more details about your server logs as well as those in your JavaScript console. Offline means that the client is unable to open a socket with the server, thus no information is being sent. Any number of network configuration problems can cause this issue.

This behavior is particularly strange, as the tornado server believes you are successfully opening up a socket, but the client doesn't agree. It's possible something is going on with the way the socket handler in the client is managing the url that you're visiting, which causes the error. I haven't tried to access via ssh tunnel personally so I'm just trying to think of what could be wrong.
"Offline" by the way means that the JavaScript client is unable to hold an open socket with the server. Generally it's assumed that this happens because the server has been shut down, but it's also possible that something is being configured improperly. Does visdom work for you in a scenario where you don't need to tunnel? (If you have such a scenario)

@JackUrb Because my server dosen't have a visual interface, I can only use a SSH tunnel to send the page info to my client and thus I can see the varitions in time.

Are you not able to access the server directly via ip, like x.x.x.x:8097? In this case you could run your visdom server on the server and access via ip without tunneling. Otherwise you'll have to add a log to https://github.com/facebookresearch/visdom/blob/master/js/main.js in the socket.onerror = socket.onclose = ... function block to log the argument passed to onerror so you can see what's going on. (You'll need to rebuild the JavaScript with npm install; npm run build, and then pip install -e .)

At this time, after I tried to access the server directly via ip, the page is also at the offline state as before.

@JackUrb - I'm still confused about my problem. Now I accessed the server directly via ip and it doesn't work. On the 8097 page, only two input boxes and the offline button are available and can be clicked while other items are invalid.
And when I click the offline button, terminal output the infomation as below.
INFO:tornado.access:101 GET /socket (<IP_ADDRESS>) 0.93ms
INFO:root:Opened new socket from ip: <IP_ADDRESS>
I have no idea why it cannot work properly as before.

I meet the same problem with fangxiaoke, I want to ask if there are some methods to solve it? I am a new user to visdom.


feat(Geosuggest): add onSuggestNoResults callback function

Description
Added a callback function when there are no suggestions, to allow developers to handle this case easily, and show some UI indication for example.
Checklist

[x] All tests passing
[x] Created tests which fail without the change (if possible)
[x] Extended the README / documentation, if necessary
[x] Commits and PR follow conventions

🏁    Thanks for the PR! Would you mind to add some tests? @Caerostris wrote a lot to cover most parts of the lib. He surely can assist.

Just did the adjustments + added a test to cover the addition

That’s great! Thank you!

Just noticed that the dist files had not been updated, neither in npm. isn't it an automatic process?

We need to make a release, then the dist and npm and everything will be updated automatically. We’re close to releasing.

👍

Just released in version 1.24.0.

Awesome!


.github/workflows: re-enable coverage in BPF tests

With the recent CoverBee version bump in commit a38fa327f99f ("vendor: Bumped CoverBee to v0.3.0 and cilium/ebpf to v0.10.0") we can enable coverage reporting for BPF tests again.
This reverts commit edd2abfbd588 (".github/workflows: disable coverage in BPF tests").
Fixes #22088

/cc @dylandreimerink
Looks like CoverBee is panic'ing in a different place now: https://github.com/cilium/cilium/actions/runs/3996735051/jobs/6857147501
panic: runtime error: index out of range [2667] with length 2667 [recovered]
111
	panic: runtime error: index out of range [2667] with length 2667
112

113
goroutine 7 [running]:
114
testing.tRunner.func1.2({0x1b4e1c0, 0xc00b73ab58})
115
	/opt/hostedtoolcache/go/1.19.5/x64/src/testing/testing.go:1396 +0x24e
116
testing.tRunner.func1()
117
	/opt/hostedtoolcache/go/1.19.5/x64/src/testing/testing.go:1399 +0x39f
118
panic({0x1b4e1c0, 0xc00b73ab58})
119
	/opt/hostedtoolcache/go/1.19.5/x64/src/runtime/panic.go:884 +0x212
120
github.com/cilium/coverbee.InstrumentCollection(0xc000c14750, {0x0, 0x0})
121
	/home/runner/work/cilium/cilium/vendor/github.com/cilium/coverbee/instrumentation.go:277 +0x25b4
122
github.com/cilium/coverbee.InstrumentAndLoadCollection(0x7efed9023fff?, {{{0x0, 0x0}, {0x0, 0x0, 0x0}}, {0x0, 0x4000000, 0x0, 0x0}, ...}, ...)
123
	/home/runner/work/cilium/cilium/vendor/github.com/cilium/coverbee/instrumentation.go:27 +0x46
124
github.com/cilium/cilium/test/bpf_tests.loadAndRunSpec(0xc0003eb040, {0x1f7d040?, 0xc0000bad00?}, {0x0, 0x0})
125
	/home/runner/work/cilium/cilium/test/bpf_tests/bpf_test.go:143 +0x225
126
github.com/cilium/cilium/test/bpf_tests.TestBPF(0xc0003eb040)
127
	/home/runner/work/cilium/cilium/test/bpf_tests/bpf_test.go:91 +0x73a
128
testing.tRunner(0xc0003eb040, 0x1d9ce58)
129
	/opt/hostedtoolcache/go/1.19.5/x64/src/testing/testing.go:1446 +0x10b
130
created by testing.(*T).Run
131
	/opt/hostedtoolcache/go/1.19.5/x64/src/testing/testing.go:1493 +0x35f
132
FAIL	github.com/cilium/cilium/test/bpf_tests	22.973s
133
FAIL

blocked on #24094

BPF tests passed with test commit and #24094 pulled in: https://github.com/cilium/cilium/actions/runs/4302018934
Removing test commit and marking as ready to review.

The related job is skipped in this PR (as there is no bpf change), however, I have verified locally, so it's safe to merge.
https://github.com/cilium/cilium/actions/runs/4304772254/jobs/7506267906

The related job is skipped in this PR (as there is no bpf change), however, I have verified locally, so it's safe to merge.
https://github.com/cilium/cilium/actions/runs/4304772254/jobs/7506267906

@sayboras FWIW this was also successfully run with a test commit that triggered the respective test, see https://github.com/cilium/cilium/pull/23291#issuecomment-1449701206

oops my bad :100:


chore: Update meltano cloud run

Closes: https://github.com/meltano/infra/issues/501

I'm not sure why the changes around the version attribute in the client are present here. I thought those were already upstream in the cloud branch.

Ah, it's because I had not yet merged this PR:

https://github.com/meltano/meltano/pull/7382


[FIXED] Cross-Origin Read Blocking made the badges unavailable on Github Readmes

The issue seems to be fixed (now) but I wanted to tell you that it happened yesterday, and I'm curious to know what caused it 👀
Screenshots : https://github.com/jazzypants1989/jessquery/issues/5

Oh, interesting 🤔

as both urls (yours and GitHub camo ones) displayed things, it may also be an issue on GitHub’s side 🤷♂
tho idk where to open an issue for this

Yeah, this seems like either a github issue or a Deno Deploy issue 🤷🏽


Fix incorrectly connected optimize_dialog/confirmed signal in AnimationTrackEditor

Currently confirming optimization dialog will not perform the optimization, but it will clean up the animation instead.

Thanks!

Cherry-picked for 3.2.4.


Relicense from GPLv3 to BSD 3-clause

After careful consideration based on community feedback and our experience with Enrich2, I would like to distribute CountESS under the permissive BSD 3-clause license rather than GPLv3.

I don't get why it's 0.0.1 now but 🤷♂! =D
Also, just fyi, my own personal preference these days is MPL, but that remains a bit of a non-starter with the SciPy community. Maybe one day.


feat(robot-server, app): add a new endpoint for fast-fetching all run commands

Overview
Robot server changes:
Adds a new endpoint- GET /runs/:run_id/commandsAsPreSerializedList to the run commands router. This endpoint returns a list of pre-serialized commands (that are valid json objects) of a finished run.
This endpoint is a much faster alternative to the GET /runs/:run_id/commands endpoint when fetching all commands of a completed run.
Also adds notification publishing when pre-serialized commands become available for a run.
App changes
closes RQA-2645 and RQA-2647
Test Plan

Run a large protocol (with ~10k steps) on a Flex and an OT-2
While the run is active, verify that hitting the new endpoint returns a 503 service unavailable response
Once the run is finished (whether after running successfully/ after failing/ after being canceled), verify that the new endpoint returns a list of stringified commands with total length of list equal to number of commands in the protocol.
Un-current the run and again verify the above response
Both the above two requests should take only a couple of seconds to get a response (as opposed to 30+ seconds)
Test that a notification gets sent when a run ends so that pre-serialized commands can be fetched

Changelog

added the new endpoint to runs/commands_router
added run commands fetching to run_store
added unit tests and integration tests
added a runs publish topic for pre-serialized commands
added notification publishing for pre-serialized commands availability after a run has been committed to the database. This happens in two places:

in RunController, after a run has finished running (either successfully ended, failed with error or stopped by the client)
in RunDataManager after a run has been un-currented.

Review requests

check the SQL request for correctness/ efficiency
test on a robot
test on a robot for endpoint behavior during transition states- when run data is being written to or modified/erased from the database
I have added the current command publisher to the 'unsubscribe' list once a run is cleaned up. Does this have any unexpected effect?

Risk assessment
New endpoint so impact on existing code is close to none.

@ncdiehl11 This is my bad for not telling you earlier (and it's also not a blocker) - on L43 of eslintrc.js, we actually have a lint rule to enforce using notification wrappers when they exist.
We should add the HTTP polling equivalent to the list to prevent devs from forgetting and using it by mistake.

@ncdiehl11 This is my bad for not telling you earlier (and it's also not a blocker) - on L43 of eslintrc.js, we actually have a lint rule to enforce using notification wrappers when they exist.
We should add the HTTP polling equivalent to the list to prevent devs from forgetting and using it by mistake.

[spoke in person] holding off on this in this PR as we are targeting release branch instead of edge where those eslint file rules were added @mjhuff


Add redis tester

A simple script that connects to Redis in a similar manner to our API server, which you can use to debug connections.

Oops, thank you!


Problem trying to use Shortcode in Laravel 5

Trying to use the shortcode package in an app I am working on but I am getting this error:
ErrorException in AliasLoader.php line 63:
Class 'Pingpong\Shortcode\Facades\Shortcode' not found
I do have the required provider and facade lines in the app.php file, so could it be that Shortcode is not ready for laravel 5?
thanks

I should mention I am using the 2.0.*@dev branch

Hi,
Use Pingpong\Shortcode\ShortcodeFacade class instead. I haven't updated the documentation.


Convert expires_at to integer before settings redis ttl

Great find!

Released as 0.1.3, if any of you can give me your Gemcutter emails, I'll add you as owners


SQLITE initial migration with preview / 3.1

With preview 3.1  - same with preview 3. Initial Lift up works, creates db, but throws error :
Error: Error in lift engine for rpc migrationProgress:
  thread 'main' panicked at 'Could not load migration from database. Migration name was:<PHONE_NUMBER>5100-init', src/libcore/option.rs:1034:5
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:197
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:211
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:474
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:381
   6: rust_begin_unwind
             at src/libstd/panicking.rs:308
   7: core::panicking::panic_fmt
             at src/libcore/panicking.rs:85
   8: core::option::expect_failed
             at src/libcore/option.rs:1034
   9: <migration_core::commands::migration_progress::MigrationProgressCommand as migration_core::commands::command::MigrationCommand>::execute
  10: <F as jsonrpc_core::calls::RpcMethodSimple>::call
  11: <F as jsonrpc_core::calls::RpcMethod<T>>::call
  12: <futures::future::lazy::Lazy<F,R> as futures::future::Future>::poll
  13: <futures::future::then::Then<A,B,F> as futures::future::Future>::poll
  14: <futures::future::map::Map<A,F> as futures::future::Future>::poll
  15: <futures::future::either::Either<A,B> as futures::future::Future>::poll
  16: futures::task_impl::std::set
  17: std::thread::local::LocalKey<T>::with
  18: futures::future::Future::wait
  19: jsonrpc_core::io::IoHandler<M>::handle_request_sync
  20: migration_core::rpc_api::RpcApi::handle
  21: migration_engine::main
  22: std::rt::lang_start::{{closure}}
  23: std::panicking::try::do_call
             at src/libstd/rt.rs:49
             at src/libstd/panicking.rs:293
  24: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:87
  25: std::rt::lang_start_internal
             at src/libstd/panicking.rs:272
             at src/libstd/panic.rs:388
             at src/libstd/rt.rs:48
  26: main
  27: __libc_start_main
  28: _start

Subsequent migration throws as well.

fixed by 3.2


HERE’S!!* WAY TO WATCH Aston Villa vs Brighton LiVe 𝐒𝐭𝐫𝐞𝐚𝐦𝐬 ON Premier League TV CHANNEL

About the match
Aston Villa is going head to head with Brighton & Hove Albion starting on 30 Dec 2024 at 19:45 UTC at Villa Park stadium, Birmingham city, England. The match is a part of the Premier League.
🔴WATCH📺📱👉 Aston Villa vs Brighton Live
🔴WATCH📺📱👉 Premier League 2024-25 Live
🔴WATCH📺📱👉 Aston Villa vs Brighton Live

Currently, Aston Villa rank 9th, while Brighton & Hove Albion hold 10th position. Looking to compare the best-rated player on both teams? Sofascore's rating system assigns each player a specific rating based on numerous data factors.
On Sofascore livescore you can find all previous Aston Villa vs Brighton & Hove Albion results sorted by their H2H matches. Sofascore also provides the best way to follow the live score of this game with various sports features. Therefore, you can:
Find out who scored in a live match
Get real-time information on which team is dominating the match using the Attack Momentum
Follow detailed statistics such as ball possession, shots, corner kicks, big chances created, cards, key passes, duels and more
Check all head to head matches – for instance, in the last season Aston Villa and Brighton & Hove Albion played 2 games against each other
Track all home and away games for each team in the Premier League
Check out how Sofascore community votes on which team is more likely to win this match.
All of these features can help you decide on Aston Villa vs. Brighton & Hove Albion game prediction. Even though Sofascore doesn't offer direct betting, it provides the best odds and shows you which sites offer live betting. Live U-TV odds are viewable on Sofascore's Football live score section.
Where to watch Aston Villa vs. Brighton & Hove Albion? Under TV Channels section you can find the list of all channels that broadcast Aston Villa – Brighton & Hove Albion live match. You can also live stream this match through our betting partners or click on any links on Sofascore for a legal live stream.
Event details:
NAME: Aston Villa - Brighton & Hove Albion
DATE: 30 Dec 2024
TIME: 19:45 UTC
VENUE: Villa Park, Birmingham, England
More details:
Aston Villa live score, schedule and results
Brighton & Hove Albion live score, schedule and results
Sofascore livescore is available as iPhone and iPad app, Android app on Google Play and Windows phone app. You can find us in all stores on different languages as "Sofascore".


Find1

Accourding to #17
e, I have to implement:
Fraction findFractionAdditionByUserId(String id);

Created class Searches and implemented function.
Then refactored because of smell codes


DotNext.Net.Cluster.Consensus.Raft: Seed members and joining members?

Is the DotNext.Net.Cluster.Consensus.Raft cluster capable of allowing non-specified members to join the cluster?
e.g. cluster boots with 3 seed nodes, then additional nodes join in against one of those, and the cluster become aware of the newly joined nodes?
Or is it purely capable of consensus between the pre-specified members?
In https://github.com/AsynkronIT/protoactor-dotnet , we have externalized all cluster management.
e.g. we use Consul or Kubernetes API to get the cluster topology.
I would very much like to give it a try to use dotNext Raft as an alternative cluster provider, as it wouldn't require users to have some specific infrastructure in place.

Hi @rogeralsing ,
Short answer is yes but it requires service discovery.
Long answer:
The current implementation need to know about the list of cluster members. It's needed for calculating quorum. Under the hood, the configuration of cluster members can be supplied via ASP.NET Core configuration infrastructure (in case of HTTP transport) or manually (in case of TCP/UDP transport). Configuration providers in ASP.NET Core can be extended. This gives a way to write custom provider and discover cluster nodes using 3rd-party mechanism such as Consul or Kubernetes. However, cluster members can be added and removed dynamically to live cluster. Raft implementation for ASP.NET Core (which is in DotNext.AspNetCore.Cluster library) tracks membership changes in the background using IOptionsMonitor. It's fully tested functionality. Moreover, there is a special interface for that: IExpandableCluster. If cluster engine implements it, the cluster can be re-configured dynamically. It's implemented for ASP.NET Core out-of-the-box but not for TCP/UDP transports.
Writing custom configuration providers for the purpose of service discovery may be challenging and redundant. Therefore, in version 3.1.0 (which is in development now) a new way of service discovery is introduced: IMemberDiscoveryService interface. It's much simpler than custom configuration provider. It allows to implement any custom discovery mechanism. Also I tried to write my own discovery mechanism for Kubernetes which is based on Service abstraction to verify the concept.
This interface is introduced because there are too many hosting infrastructures exist: Kubernetes, clouds, pure Docker, bare metal etc. As a result, I can't offer universal implementation. Instead, it's better to provide extensibility point to the developers.
In other words, service discovery is delegated to library consumers. From my point of view, it's not a goal of Raft implementation to provide built-in universal discovery mechanism. In case of bare metal deployment, some solutions such as Hazelcast IMDG use their own discovery mechanism based on UDP broadcast. .NET Framework has PRNP but it looks like dead (Windows-only, not ported to .NET Core). UDP broadcasting has many drawbacks and network engineers usually don't like this approach.
I think you're looking for some default service discovery mechanism. Raft is about building consistent and reliable clusters.


Migration work

Somebody flipped a switch and now I have to go through a PR to rapidly iterate on this migration effort.

Merging as I've gotten an exception for the global repo ruleset.


PhpStorm (10.0.1): CodeGlance 1.4.4 plugin "disappears" from installed plugins after restart

I open settings in PhpStorm, select Plugins
Browse repositories, search for CodeGlance
Click install
It asks to restart PhpStorm, I click ok
Plugin gone from installed Plugins list after restart

Not sure if this is CodeGlance or PhpStorm issue?

If you download http://public.vektah.net/codeglance/net/vektah/CodeGlance/1.4.4/CodeGlance-1.4.4.zip manually and "Install plugin from disk..."
Does that work?

Same applies to PhpStorm 9.0.2. Even worse is, after manually installing CodeGlance 1.4.3 the plugin is enabled in Plugins-Settings but does not show up in Editor-Window.

@Vektah
Hey,
Yes that did work. It also works on all files with this new version. Thanks!

@lahmann Update to 1.4.4

http://public.vektah.net/codeglance/net/vektah/CodeGlance/1.4.4/CodeGlance-1.4.4.zip
Does not work for me either - if I rename the zip to jar in order to let PhpStorm recognize the file, PhpStorm tells me "Fail to load plugin descriptor from file CodeGlance-1.4.4.jar", unzipping the archive does not help either.
@jisuo that's what I did - and CodeGlance disappeared from the plugins list as it did for you. Manual install does not work either.

@lahmann You can take the thermonuclear option:

Close phpstorm
Go to C:\Users<User>.IntelliJIdea15\config\plugins
delete all the CodeGlance things from here
download a fresh copy from the link above (it should be .zip)
reinstall

Ok, problem solved - after unzipping above provided zip-file manually into .WebIde90/config/plugins (and removing any CodeGlance files) and restarting PhpStorm CodeGlance works again.
Thanks for the quick help.

Apologies for the botched release, lets hope there are no other issues :)


Zulint cleanup

Just need to add --verbose option and then this should cover https://github.com/zulip/zulip/pull/12605#issuecomment-503264117.

@timabbott I might have diverted a little from the original plan. Let me know your thoughts on this.

I merged about half the commits, since those looks great.  I'm not sold on the -g=backend  styling; I think we should either prefer to spell it as --groups=backend or have the configuration support doing --backend; probably the former is better.  (I can't think of other command-line tools that recommend typing e.g. --g=foo,bar,quux, and it feels weird to me).

I love the visual look of the current --list feature!  I ended up just doing the remaining cleanups to merge this as the series of commits ending with 8fc7c89874773a4bca8d6a53ebef310cca798d4c.  Notes on the changes:

Rewrote all the descriptions both for accuracy and styling (using "Standard" for popular third-party linters to distinguish them from things we wrote)
Removed the -g= styling for groups from the documentation (possibly we should just make that option not work, too).

Some notes on follow-ups:

We should probably make a --list-groups option, because otherwise they're not discoverable.
I think we might want to play with the --verbose format a bit more; I kinda feel like it's not as readable as it could be.  Maybe something to post for feedback in #backend about.
I wonder if we could so something similar to b2b49089fd3ce75f73f911a9c16fc64dd4efdcba for the --force arguments for those tools as well; I was just thinking the description "Run tests despite possible problems." is pretty confusing for something that just ignores the provisioning status.

Other than that, we should probably move on to work on the README.md and/or copying this into the zulint repository so that we can put it in a GitHub-based pip line for python-zulip-api and zulip-terminal for testing.  (Feel free to just do that and push to the zulint GitHub repository; my plan is to rebuild that repository from the history of zulip.git, so the current thing is just a scratch repo for testing.  We should just make sure we don't blow away the example script in it before copying it somewhere more useful)

Thanks! I will look into them.