Access policy missing

An access policy is required before a Key Vault key can be created

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86b44bac-c760-a06d-e618-149f275e0d0e
Version Independent ID: bcaaf53e-87c1-59aa-c51b-d3359ebb9046
Content: Encrypt disks on a Windows VM in Azure
Content Source: articles/virtual-machines/windows/encrypt-disks.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for the feedback! We are currently investigating and will update you shortly.

@ericvanwijk technically correct. You need to have the correct permissions on the subscription to create Keyvaults in order for this to work. That being said, it is assumed you have the correct permissions as many people following the doc will have contributor access to the subscription or are the admins of the subscriptions.
We do already have a doc going on the role access and the levels needed for particular actions in azure
https://docs.microsoft.com/en-us/azure/role-based-access-control/role-assignments-portal
So from a doc perspective, I don't see anything that needs to be added to the doc. I will close but if you have further feedback let me know and we can continue the discussion.

I’m referring to access policy within KeyVault, not RBAC. The step that
creates the KeyVault also states you need the policy as an additional
stepp. In fact I’m the subscription owner, and it did fail for me.
Op ma 4 mrt. 2019 om 20:55 schreef Micah<EMAIL_ADDRESS>
@ericvanwijk https://github.com/ericvanwijk technically correct. You
need to have the correct permissions on the subscription to create
Keyvaults in order for this to work. That being said, it is assumed you
have the correct permissions as many people following the doc will have
contributor access to the subscription or are the admins of the
subscriptions.
We do already have a doc going on the role access and the levels needed
for particular actions in azure
https://docs.microsoft.com/en-us/azure/role-based-access-control/role-assignments-portal
So from a doc perspective, I don't see anything that needs to be added to
the doc. I will close but if you have further feedback let me know and we
can continue the discussion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/26097#issuecomment-469397852,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARjjx6na3zQgIKcUHbEWbV-Su7n_cA7iks5vTXougaJpZM4ba4UB
.

@ericvanwijk ah I see. That makes sense. Thanks for clarifying that. I tested this and I see what you mean.
@cynthn after this step
$keyVaultName = "myKeyVault$(Get-Random)"
New-AzKeyVault -Location $location `
    -ResourceGroupName $rgName `
    -VaultName $keyVaultName `
    -EnabledForDiskEncryption

The output shows

WARNING: Access policy is not set. No user or application have access permission to use this vault. This can happen if the vault was created by a service principal. Please use Set-AzKeyVaultAccessPolicy to set access policies.

So we do need to add a step to set that access policy

@MicahMcKittrick-MSFT weird... no idea why it worked for me, but I was also messing with policies for another article. Let me go through this with a "clean" subscription again and clarify\add a step as needed.
@ericvanwijk thanks for the feedback! It might take me a couple of days to be able to circle back around and check this on another subscription. Thanks :)

I had the same problem. For the azure account I used the default policies could not be set. Maybe I had multiple subscriptions, AAD or it was just the MSDN login that caused the problem. This code helped me to successfully set the policy and generate a key:
$Permissions2Keys                        = @('get', 'create', 'delete', 'list', 'update', 'import', 'backup', 'restore', 'recover')
$Permissions2Secrets                     = @('get', 'list', 'set', 'delete', 'backup', 'restore', 'recover')
$Permissions2Certificates                = @('get', 'delete', 'list', 'create', 'import', 'update', 'deleteissuers', 'getissuers', 'listissuers', 'managecontacts', 'manageissuers', 'setissuers', 'recover', 'backup', 'restore')
$Permissions2Storage = @('delete', 'deletesas', 'get', 'getsas', 'list', 'listsas', 'regeneratekey', 'set', 'setsas', 'update', 'recover', 'backup', 'restore')
Set-AzKeyVaultAccessPolicy -VaultName $keyVaultName -ResourceGroupName $Config.RG -UserPrincipalName ((Get-AzADUser | Out-GridView -PassThru).UserPrincipalName) `
    -PermissionsToKeys $Permissions2Keys `
    -PermissionsToSecrets $Permissions2Secrets `
    -PermissionsToCertificates $Permissions2Certificates `
    -PermissionsToStorage $Permissions2Storage

hth,
B

I would go with more "restrictive" key vault policy - we are using keys only, so we can set it like this:
$permkeys = @("create", "list", "get", "update", "delete")
Set-AzKeyVaultAccessPolicy -VaultName $keyVaultName -UserPrincipalName<EMAIL_ADDRESS>-PermissionsToKeys $permkeys -PassThru
Add-AzKeyVaultKey -VaultName $keyVaultName -Name $keyName -Destination "Software"

#please-close This article has been updated multiple times by the author since this Issue was created. I think this is covered now. If there are still issues, please reopen this and it should be assigned to the current author.


Quoted markdown formatted incorrectly

Quote all of the things
Soo.. the iPhone X looks pretty nice
Second Header
Ooh
Third Header
Even more ooh

List Item One
List Item Two

Numbered List
Second Item

[ ] Check List
[ ] Check List Two

http://example.com/
Formatted Link
#846 - Infer Link
❤ 💜 💙 💛 💚

Key
Value

1
some

2
hi

Bold Italics

2

3

5

8

13

As with the example text above, we can see that the app doesn't have full support for quoting in the same way that desktop does. This should probably be improved!

Just to note, this is a bit of an edge case and also extremely complicated.
Sent with GitHawk

So I'm wondering if there's a way we could have a MarkdownView which is itself a collection view that we can embed into a cell. This'll be helpful as rather than having to break markdown into multiple models then support all the different cells etc we can just have one view that handles it (likely it's own component with the MMMarkdown tweaks).
Furthermore this'd enable us to separate a comment based on quote indent. Rather than having to dynamically calculate the inset on the left based on level of quote, we simply just move the MarkdownView and let it recalculate what it needs to.
Pretty much immediately support nested quotes for every item, and the flexibility to easily add markdown anywhere in the app. (e.g. the single reason why I couldn't finish the projects stuff - because you wanted markdown support but it was way too complicated to add)

Ya go ahead and give it a shot. I’m weary of using web views in general because all sizing has to be done on main, so that could cripple scroll perf and cripple any optimization.
But if you can get it into good shape I’m def down to try it.
Sent with GitHawk


Allow 'custom' response on handle... calls

Sideloading is large component of ember-data via it's implementation of JSON API.
However, the handle calls seem to only be able to handle a single model at a time ( unless I'm mistaken).
I propose the ability to optionally pass in a hash instead to these functions that allows for definition by the user as a beginning road for support.
It also seems possible to pass in several factory guy model arrays or single models and to use inflection on the type to build the associated JSON response.
Custom reponse
var customResponse = {
  "user": build('user'),
  "groups": buildList('group')
};
handleQuery('user', {id: 'me', "include[]": ".groups"}, customResponse)

Pseudo code of naive future API definition
var groups = makeList('group')
var user  = make('user')
handleQuery('user', {id: 'me'}, user, groups)
//returns based on array or if factory guy model
//"user": { }
//"groups":[...]

handleQuery only handles records but ideally
Currently. I have to perform make calls first  - but this kind of defeats the usage of handle as they are already placed in the store. Want to rely on the XHR mocking/stubbing completely to use as close a model to the user's experience as I can.

what version of FactoryGuy are you on?  can you try upgrading to the very latest factoryguy 2.1.0 ?  It handles sideloading better than older versions, and probably does what you want already .. give it a try and let me know

Okay I'm trying out - it's available via usage of traits because of handle falling back to use build / buildList.
So far found it difficult to build specific scenarios using the handle without using make to explicitly build up the relationships I want

yes traits help out for building relationships, but handleQuery does not return json ( as you correctly point out )  I am not sure exactly why I did that .. but I am sure I will remember once I try and change it.
But you make a good point, that it would be nice to do
so something like:
var user = make('user')
handleQuery('user', {id: 'me'}).returnsModel([user]);
var user = make('user', 'with_groups')
handleQuery('user', {id: 'me', 'include[]': 'groups'}).returnsModels([user]);

handleQuery('user', {id: 'me'}).returnsJSON('user');
handleQuery('user', {id: 'me', 'include[]': 'groups'}).returnsJSON('user','with_groups');

would that work for your case?

Something along these lines would be what I'm looking for I believe. Maybe I'll close this issue for now.
I'm working with traits and seeing if they can resolve most of my issues. I have a feeling I won't be able to model everything through traits however. I'll have a look at how the sideloads are built up but still feel that I'll need
 returnsJSON({user: user.toJSON(), groups: [group.toJSON()]...
allowing for custom json responses still.

Also separately.
I feel like I'd still like a ember data model that has not been pushed into the store yet ( or uses a flag that makes in inactive ) if possible so mocked requests are truly
var adminGroup = make('group', {type: 'admin'}, {live: false});
var admin1 = make('user', groups: [group], {live: false});
var admin2 = make('user', groups: [group], {live: false});

Where live in this case would mean fully pushed into store.  Don't care about the syntax but just ability to differentiate between items pushed and those not - to be able to use handle

I think it's a legit case to want to to returnsJSON .. it's on my list of things to do ..
the {live: false} for a make seems alittle odd .. 'make' is for making stuff and pushing in the store.
'build'  will build json  for you ( which is what I think you want ) .. so do you mean build('user')
var group = build('group' )
var user = buildList('user',2, {group: group}); // can't do this now ( but I will try and do )  will have users and groups sideloaded
which is what I would use to do the returnsJSON({user: user})

can you do me a favour and make the specific use cases for me that you would like to see for (returnsModel and returnsJSON ) chained to handleQuery ( for now I will start with that on ) .. I put some examples a few comments ago, but I want you to verify and lay it out super clearly .. since I don't want to build something from my imagination of what you might need.

Will do. I do a lot of context switching at work - so these examples are coming slower. But I will put forth a use case that doesn't feel like it can be supported through the traits.
I do like the direction that build('group'), buildList that you put above, which I think should do it. But I think I'd rather still have interim objects, that I can call to JSON on eventually.
Just showing the following as an example of what would be nice in order to build up a set of relationships outside of the trait system. Not suggesting the toJSON API
  let group = build('group');
  let admin = build('user', 'admin', {group: group});
  let moderator =  build('user', 'moderator', {group: group});
  let modCanEdit = build('permission', 'edit', {user: moderator});
  let adminCanEdit = build('permission', 'edit', {user: admin});

  ...returnsJSON({group: group, users: [moderator, admin], permissions: [modCanEdit, adminCanEdit]})

The example above is simple ( and the permissions could be done using traits ) but I'm sure there are scenarios that can't be done with traits similar to the above and some where you would want to have this control outside of traits.

release 2.1.1  and 3 new methods to handleQuery which should allow you to do what you want
returnsJSON  .. json from buildList
returnsModels  .. array of models
returnsExistingIds .. array of ids of models that exist
check them out and let me know what you think .. or if you need more of something


V spec should be updated from Draft 0.7 to Frozen 1.0

From the v-spec 1.0:

This document is version 1.0 of the RISC-V vector extension for public review.

Note
This version 1.0 is considered frozen for public review as part of the RISC-V International ratification process. Version 1.0 is considered stable enough to begin developing toolchains, functional simulators, and implementations, including in upstream software projects, and is not expected to have incompatible changes except if serious issues are discovered during ratification. Once ratified, the spec will be given version 2.0.

Thanks for pointing this out.  But it's better than frozen; it's actually ratified!

Well, I'm not 100% sure, but it seems you were right: the spec seems to be ratified! From these posts:

RISC-V Announcement: RISC-V International Ratifies 15 New Specifications, Opening Up New Possibilities for RISC-V Designs
RISC-V Wiki: Recently Ratified Extensions

The riscv-v-spec repo would deserve a refresher in its description and README :)

src/v.tex in this repo, too! :)

Ah, nice.  Thanks.  I'll take care of all this.

Conclusion: what was ratified is the frozen 1.0 spec, plus the responses to the public review feedback.  The latter has only been incorporated in to the spec in draft form.  Obviously we need to get a new version of the spec out the door and bless that as the ratified version.  I'll wait to update this document until we get to that point.  But I will fix the other reference to 0.7 you pointed out.


EADDRINUSE with WebSockets on file change

Describe the bug
I'm trying to get WebSockets to work with SvelteKit. However, whenever I change the file the WebSocket server is created, the dev server crashes and says that the port is taken. So it appears like 2 servers are running at once at some point or the port remains open for some reason. I feel that this is not intended behaviour because if I restart the server the port is not taken anymore until I make a change in the file again.
Reproduction
Repository: https://github.com/Volper212/sveltekit-report
Steps:

git clone https://github.com/Volper212/sveltekit-report
cd sveltekit-report
npm i
npm run dev
Open http://localhost:3000 in the browser
Edit file src/routes/index.js in any way that causes a refresh (for example add a semicolon on line 2)

Logs
20:41:37 [vite] page reload src/routes/index.js
events.js:352
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE: address already in use :::8080
    at Server.setupListenHandle [as _listen2] (net.js:1320:16)
    at listenInCluster (net.js:1368:12)
    at Server.listen (net.js:1454:7)
    at new WebSocketServer (C:\Users\igor\sveltekit-report\node_modules\ws\lib\websocket-server.js:94:20)
    at eval (C:\Users\igor\sveltekit-report\src\routes\index.js:6:1)
    at async instantiateModule (C:\Users\igor\sveltekit-report\node_modules\vite\dist\node\chunks\dep-e0fe87f8.js:66544:9)
Emitted 'error' event on WebSocketServer instance at:
    at Server.emit (events.js:375:28)
    at Server.emit (domain.js:470:12)
    at emitErrorNT (net.js:1347:8)
    at processTicksAndRejections (internal/process/task_queues.js:82:21) {
  code: 'EADDRINUSE',
  errno: -4091,
  syscall: 'listen',
  address: '::',
  port: 8080
}

System Info
System:
    OS: Windows 10 10.0.19043
    CPU: (4) x64 Intel(R) Core(TM) i3-4005U CPU @ 1.70GHz
    Memory: 8.84 GB / 11.91 GB
  Binaries:
    Node: 14.17.3 - C:\Program Files\nodejs\node.EXE
    npm: 8.1.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (93.0.961.47)
    Internet Explorer: 11.0.19041.1202
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.3
    @sveltejs/kit: next => 1.0.0-next.199
    svelte: ^3.44.0 => 3.44.2

Severity
annoyance
Additional Information
No response

This is because of HMR in that endpoint that re-creates the websocket server whenever you update it. Ideally, you'd want to close and restart the server whenever you make updates. Try adding a HMR handler at the end of your file:
if (import.meta.hot) {
  import.meta.hot.dispose(() => {
    server.close() // or something similar
  ))
}

Check the spec for more info.

I updated the repo, but the server still crashes after a change in the file.

My bad. You'd need to have import.meta.hot.accept() as well to tell Vite that the file accepts HMR updates.
Something like this should work:
if (import.meta.hot) {
    import.meta.hot.accept();
    import.meta.hot.dispose(() => {
        server.close();
    });
}

Unfortunately it still crashes when I reload the browser after a change. Repo updated again.

Hmm. If so I might be out of ideas, but last I tried that code, it worked for me locally.

The underlying issue is https://github.com/vitejs/vite/issues/7887. It's possible to work around it, if you can hold your nose:
if (globalThis.__server) {
  globalThis.__server.close();
}

const server = new WebSocketServer({ port: 8080 });
globalThis.__server = server;

Obviously you can wrap the relevant bits in if (import.meta.env.DEV) etc so that it gets removed in production, if you want.

Yeah the Vite devs are on crack. Do not npm update if you are sensitive to flashing lights.


Add a license to the repository

Since I wish to add a simple license to the testclient, it would be awesome if a definite license could be added here.

Yes, please add a License to this. I am interested in using what you are making here for a SE chatbot that informs about github activity.
I personally like the Simplified BSD or MIT licenses.
Although I should note: I am not interested in making any money whatsoever from what you're doing here. But at the same time, I also don't want to be enforced my code under GPL - which I am enforced to do if your code is GPL.

@Zomis Please share your thoughs on ASL 2.0. Most importantly the following section taken from the license text:

4 Redistribution. You may reproduce and distribute copies of the Work or Derivative Works thereof in any medium, with or without modifications, and in Source or Object form, provided that You meet the following conditions:

a) You must give any other recipients of the Work or Derivative Works a copy of this License; and
b) You must cause any modified files to carry prominent notices stating that You changed the files; and
c) You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and
d) If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.

You may add Your own copyright statement to Your modifications and may provide additional or different license terms and conditions for use, reproduction, or distribution of Your modifications, or for any such Derivative Works as a whole, provided Your use, reproduction, and distribution of the Work otherwise complies with the conditions stated in this License.

To me this sounds like this would suit you better?

The Apache License is perfectly acceptable for me, yes!

Actually, I was going to use the MIT open source license, but eh.
@Vogel612: Do you prefer ASL (2.0)?

@Vincentyification both are fine by me. It'd be easier to use the ASL since you don't have to include a license header to every file (IIUC).


Fix missing required parameters for Password Grant flow

Added missing parameters client_secret and audience to the request for the Password Grant flow.

MD5: c4103f122d27677c9db144cae1394a66
NSP - Security Report
This is an automated security audit of this project. Please do not modify its contents
Vulnerabilities found: 2
Affected Modules: uglify-js, uglify-js
Summary:

Regular Expression Denial of Service
Incorrect Handling of Non-Boolean Comparisons During Minification

Detailed report
Regular Expression Denial of Service
Affected Module: uglify-js
Installed version: 2.2.5
Patched versions: >=2.6.0
Advisory: https://nodesecurity.io/advisories/48
Path<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>
Incorrect Handling of Non-Boolean Comparisons During Minification
Affected Module: uglify-js
Installed version: 2.2.5
Patched versions: >= 2.4.24
Advisory: https://nodesecurity.io/advisories/39
Path<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>


Duplicate CSS files being generated outside of assetsBuildDirectory in server directory

What version of Remix are you using?
1.6.6
Steps to Reproduce
Initially started from the Grunge stack starter before Remix-run was on version 1.6.5. After upgrading to 1.6.7,  I noticed there's duplicate CSS files being generated in both /public/build/_assets and in server/_assets, having the same hash in their filename. The ones in the server directory seem to be redundant.
I managed to narrow the bug down to version 1.6.6 as 1.6.5 did not have it, while 1.6.6 and 1.6.7 did have it.
https://github.com/remix-run/remix/compare/remix%401.6.5...remix%401.6.6
remix.config.js
/**
 * @type {import('@remix-run/dev').AppConfig}
 */
module.exports = {
  appDirectory: "app",
  cacheDirectory: "./node_modules/.cache/remix",
  assetsBuildDirectory: "public/build",
  publicPath: "/build/",
  serverBuildPath: "./server/index.js",
  ignoredRouteFiles: [".*", "**/*.css", "**/*.test.{js,jsx,ts,tsx}"],
  routes(defineRoutes) {
    return defineRoutes((route) => {
      if (process.env.NODE_ENV === "production") return;

      console.log("⚠  Test routes enabled.");
    });
  },
};

app/root.tsx
have a links function in root.tsx
import tailwindStylesheetUrl from "./styles/tailwind.css";

export const links: LinksFunction = () => {
  return [
    { rel: "stylesheet", href: tailwindStylesheetUrl },
    { rel: "icon", href: "/assets/favicon.ico" },
  ];
};

./styles/tailwind.css is generated using the tailwindcss -o ./app/styles/tailwind.css command, but should have nothing to do with this specific use case. Even though I'm not entirely sure at this point, that's why I'm including it nonetheless.
Run the remix dev command to see the files being generated.
Expected Behavior
The generated CSS files are only generated inside /public/build/_assets and not in server/_assets.
Actual Behavior
There's duplicate CSS files being generated in both /public/build/_assets and in server/_assets, having the same hash in their filename. The ones in the server directory seem to be redundant.

I haven't verified it, but this 1.6.6 commit certainly looks suspicious: https://github.com/remix-run/remix/commit/916caa6a25d5496de0c4de7331852bf279338017


add DeleteParams for delete_collection

We currently use ListParams but this is technically a bit wrong. See https://github.com/Arnavion/k8s-openapi/issues/46

I can tackle this if still needed

Yes please. If you can figure out what's actually inconsistent. It's been a while since I reported this :smile:
We currently have ListParams in the signature for delete_collection, but should probably have some sort of DeleteParams instead. Possibly with the preconditions that Arnavion talks about https://arnavion.github.io/k8s-openapi/v0.7.x/k8s_openapi/struct.DeleteOptional.html#structfield.preconditions

Fixed in 0.40.0.


Cleanup NetBeans license header for module team.commons

Review and cleanup the license header in team.commons
Oracle donated NetBeans to the Apache Software Foundation.
Your task now is to replace the old license header that has Oracle (and/or Sun Microsystems
and/or NetBeans) in it with the standard Apache Software Foundation license header.
For an empty file that supports headers you must add the Apache license header.
Note that you have to use the proper license header for Java, .properties or HTML files.
Look at the nearby files for templates and copy-paste the license header.
When done commit the changes with a commit message that starts with first line
"[NETBEANS-54] Module Review " and a message body describing your review.
See a longer explanation about what we are doing here: https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
Please announce in a comment when you have started work.
Files that need to be looked at in team.commons:
team.commons/src/org/netbeans/modules/team/commons/resources/package-info.java

Apache PR.


expression.start.inCall works but expression.inCall does not

Regarding our discussion about ensuring that .foo always works when .start.foo works, I am wondering whether this is a corner case or whether I'm just missing an import:
expression.start.inCall follows incoming argument edges to reach the call for an argument, however, expression.inCall seems to not work.

It's kind of an edge case... that being said it does occur a few times :)
Traversal[Expression].inCall is defined only for a Traversal: (https://github.com/ShiftLeftSecurity/codepropertygraph/blob/master/semanticcpg/src/main/scala/io/shiftleft/semanticcpg/language/types/expressions/generalizations/Expression.scala#L52-L53),
and we do not currently have an implicit that lifts a single node into a Traversal.
Maybe it's time to change that though - I'll give it a try and will see if there's any significant downsides.

fixed via https://github.com/ShiftLeftSecurity/codepropertygraph/pull/1007 and https://github.com/ShiftLeftSecurity/codescience/pull/4372


[BUG] Failed bootstrapping cluster with provisioningprebootstrap and ACE enabled

Rancher Server Setup

Rancher version: 2.9.3
Installation option (Docker install/Helm Chart): Helm

If Helm Chart, Kubernetes Cluster and version: RKE2 (v1.30.5+rke2r1)

Information about the Cluster

Kubernetes version: v1.30.5+rke2r1
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? vSphere

User Information

What is the role of the user logged in? Admin

If custom, define the set of permissions:

Describe the bug
Cluster stucks in Pending state when provisioningprebootstrap is enabled.
To Reproduce
Create a cluster using vSphere provider and rancher-vsphere cloud-provider. Use Cilium with kubeProxyReplacement set to true (and k8sServiceHost pointing to <IP_ADDRESS>).
Depending on the Authorized Endpoint enabled kube-api won't start
Result
When Authorized Endpoint is enabled, kube-api reports it can't find the file /var/lib/rancher/rke2/kube-api-authn-webhook.yaml. Verifying on the host I can conform this file is not there. Creating the file manually will continue booting the cluster, but eventually the cluster still gets stuck with pending pods resultin in the cluster 'Waiting for cluster pre-bootstrap to complete'.
Looking to the pods available it stats the following;

Inspecting the logs from some pods all report more or less the same error;

So my best guess is that this is caused by some combination using Cilium with kubeProxyReplacement enabled and the provisioningprebootstrap. Disabling the provisiongprebootstrap results in the cluster being provisioned without any problems.
Expected Result
The newly created cluster is provisioned.
SURE-9298

Ticket #47771 - Test Results - ✅

Scenario
Test Case
Result

1.
ACE test
PASS

2.
cilium kube-proxy-replacement test
PASS

3.
custom calico test
PASS

Pre-requisite steps:

Enable the prebootstrap feature flag

Verified with (HA Helm or Docker) on Rancher v2.10-212d8b6e92992235d791d8f2aaea8436ab4f6b77-head:
Scenario 1: ACE test
Permutations:

Cluster type: RKE1/RKE2/K3s
Calico/Cilium

Provision and a 3 node split roles cluster and ACE enabled
Wait for the cluster to come up
Verify that the cluster is in a stable state and all pods are active

Results: The cluster came up and all pods are in a stable state

Scenario 2: Cilium kube-proxy-replacement test

Provision an 3 node all roles RKE2 cluster with Cilium and kube-proxy-replacement enabled
Verify that the cluster comes up
Verify that all pods are in a stable state

Results: the cluster came up and all pods were in a stable state.

Scenario 3: Customized calico test

Provision a 3 node all roles RKE2 cluster with an altered Calico add-on config
Verify that the cluster comes up
Verify that all pods are in a stable state

Results: the cluster came up and all pods were in a stable state.


Split contact details and address into separate forms for only the applicant

What
Link to story
This first PR will separate only contact details and address into separate forms only for applicant.  There will be other PRs for respondents, other parties and check your answers to separate contact details and address details form.
For now, only C100 Application records with version greater than 3 will have the splitting of the contact details and address forms enabled. This will allow us to release this in a controlled way as we need to ensure backward compatibility with existing saved applications in the database.
For testing purposes, in local, an ENV variable named SPLIT_ADDRESS can be set (to any value) to enable the splitting of the applicant contact and address forms regardless of the version.
The address details form does not save anything at the moment, this will come as another PR at a later note.  Also the design of the address form isn't 100% on point.
Checklist
Before you ask people to review this PR:

[x] Tests and rubocop should be passing: bundle exec rake
[x] Github should not be reporting conflicts; you should have recently run git rebase master.
[x] There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
[x] The PR description should say what you changed and why, with a link to the story.
[x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

@zheileman

@zheileman  Update the pr as suggested above

address details form

contact details form


fix(events): get user events after login

I have just noticed that after sign out the profile and when trying to log in, the events does not load, just a white screen, this PR fixes it.

@lex111 I noticed this behavior a few other times today, without signing in or out from the app.
Definitely something to keep an eye on before release

@machour just after accepting this PR there will not be this error, because after login we do not have a user (auth user), we need to get it, and then it will come to the componentWillReceiveProps and it will load the events.


External Error: Could not load model file ../lib/models.sql

Please make sure your issue is not addressed in the FAQ.
Please include the following information:

[x]  The version of infer from infer --version.
Infer version v1.1.0--b4f935464b
Infer version v1.1.0 download form this site also has the error

[x]  Your operating system and version, for example "Debian 9", "MacOS High Sierra", whether you are using Docker, etc.
Ubuntu 20.04

[x]  Which command you ran, for example infer -- make.
infer -- javac Hello.java

[x]  The full output in a paste, for instance a gist.
External Error: Could not load model file /mnt/disk/jslave/../lib/models.sql
Error backtrace:
Raised by primitive operation at Stdlib.open_in_gen in file "stdlib.ml", line 405, characters 28-54
Called from Stdio__In_channel.create in file "src/in_channel.ml" (inlined), line 14, characters 2-35
Called from IBase__Utils.with_file_in in file "src/base/Utils.ml", line 224, characters 11-33
Called from IBase__Database.load_model_specs in file "src/base/Database.ml", line 121, characters 6-151
Re-raised at IBase__Die.raise_error.do_raise in file "src/base/Die.ml" (inlined), line 26, characters 8-56
Called from IBase__Logging.die.(fun) in file "src/base/Logging.ml", line 338, characters 6-39
Called from IBase__Database.load_model_specs in file "src/base/Database.ml", line 126, characters 6-88
Called from IBase__ResultsDir.prepare_logging_and_db in file "src/base/ResultsDir.ml" (inlined), line 110, characters 52-87
Called from IBase__ResultsDir.create_results_dir in file "src/base/ResultsDir.ml" (inlined), line 127, characters 2-27
Called from Dune__exe__Infer.setup in file "src/infer.ml", line 59, characters 6-38

[x]  If possible, a minimal example to reproduce your problem (for instance, some code where
infer reports incorrectly, together with the way you run infer to reproduce the incorrect
report).
https://fbinfer.com/docs/hello-world#hello-world-java

I also encountered the same issue. This is a permission issue and can be addressed by granting executable permissions to the models.sql file.

Same error. Is there WA?


Fix some Errors in lock script

I have fixed some incorrect options that are used in lock script. I changed the options by referring manpage and it works

You must be on an other version, the version i am using doesn't support your lock config.
my version: i3lock: version 2.12.c.5, so yeah i don't see myself merging this until there is a update.

also i guess as people from other distro's use my dotfiles as well i'll just make the updates.sh check your system


Issue 240

closes #240

Codecov Report

Merging #241 into master will decrease coverage by 17%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #241    +/-   ##
======================================
- Coverage      80%    63%   -16%
======================================
  Files          19     24     +5
  Lines        1591   2024   +433
======================================
+ Hits         1268   1270     +2
- Misses        208    639   +431
  Partials      115    115

Impacted Files
Coverage Δ

apigee-istio/apigee/edge_client.go
0% <0%> (ø)

apigee-istio/apigee/kvm.go
0% <0%> (ø)

apigee-istio/apigee/revision.go
0% <0%> (ø)

apigee-istio/apigee/timestamp.go
0% <0%> (ø)

apigee-istio/apigee/proxies_service.go
0% <0%> (ø)

adapter/product/manager.go
77% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1df10...29eb9ab. Read the comment docs.


Bugfix: incorrect calculation on IP packet header length

This change is to resolve this issue: the header option length in an IP packet
header is not counted.
There are at least 20 bytes in the IP packet header. Hence, if the IHL value is
less than 5, 5 is used to count IP header length, otherwise it should use the IHL
value directly.

I think the title should be "Bugfix: incorrect calculation on IP packet header length"

Could you merge https://github.com/antrea-io/libOpenflow/pull/39 first before this one so we can use the new tag?

LGTM

Could you merge #39 first before this one so we can use the new tag?

Done.


Support DNS based certificate challenge for vsphere

Duplicate of https://github.com/giantswarm/roadmap/issues/2335. Created by buggy GitHub UI.


Run cifar-10 residual net?

[25 17:32:54 28@cifar10.py:tensorpack] Found cifar10 data in /home/eli/Downloads/tensorpack-master/tensorpack/dataflow/dataset/cifar10_data.
[25 17:32:55 28@cifar10.py:tensorpack] Found cifar10 data in /home/eli/Downloads/tensorpack-master/tensorpack/dataflow/dataset/cifar10_data.
Traceback (most recent call last):
File "cifar10-resnet.py", line 196, in
QueueInputTrainer(config).train()
File "/home/eli/Downloads/tensorpack-master/tensorpack/train/trainer.py", line 185, in train
grads = self._single_tower_grad()
File "/home/eli/Downloads/tensorpack-master/tensorpack/train/trainer.py", line 134, in _single_tower_grad
cost_var = self.model.get_cost(model_inputs, is_training=True)
File "/home/eli/Downloads/tensorpack-master/tensorpack/models/model_desc.py", line 53, in get_cost
return self._get_cost(input_vars, is_training)
File "cifar10-resnet.py", line 83, in _get_cost
l = conv('conv0', image, 16, 1)
File "cifar10-resnet.py", line 52, in conv
W_init=tf.random_normal_initializer(stddev=np.sqrt(2.0/9/channel)))
File "", line 2, in Conv2D
TypeError: wrapper() takes exactly 1 argument (11 given)
[25 17:32:56 59@prefetch.py:tensorpack] Prefetch process exiting...
[25 17:32:56 63@prefetch.py:tensorpack] Prefetch process exited.

Sorry I introduced a bug yesterday. I'll work on a fix soon. For the moment you can checkout to fd21c3b1afa4b870bbd5f12c1f68e264aafe4c02 or before.
Also please use the command line argument to specify the gpu. e.g.:
./cifar10-resnet.py --gpu 0

Fixed in 13f76d5c3774d99e62

Many thanks.


[WIP] Explore failing tests

Codecov Report

Merging #18 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop     #18   +/-   ##
=======================================
  Coverage     79.6%   79.6%
=======================================
  Files            3       3
  Lines          152     152
  Branches        24      24
=======================================
  Hits           121     121
  Misses          30      30
  Partials         1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40e915...7b678bd. Read the comment docs.


Use TestSuiteTimeMachine gem

Context
Use TestSuiteTimeMachine gem
Changes proposed in this pull request
Remove the lib/ files for TestSuiteTimeMachine
Add 'test_suite_time_machine' to Gemfile
Guidance to review

Link to Trello card

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault

 Apply: Merge/Close the "Test Suite Time Machine" (TSTM) PR


Do not check ProcessState upon AllocationCommand exit

Pull Request Test Coverage Report for Build 1625

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
421 unchanged lines in 8 files lost coverage.
Overall coverage increased (+0.5%) to 22.999%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

executor/runtime/docker/docker.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

executor/runtime/docker/docker.go
7
2.21%

executor/runtime/types/types.go
15
30.68%

uploader/uploader.go
16
29.67%

uploader/s3.go
32
0.0%

executor/mock/jobrunner.go
36
0.0%

api/netflix/titus/titus_agent_api.pb.go
79
4.69%

api/netflix/titus/agent.pb.go
114
17.76%

api/netflix/titus/titus_base.pb.go
122
4.56%

Totals

Change from base Build 1611:
0.5%

Covered Lines:
2089

Relevant Lines:
9083

💛  - Coveralls


weird dashboard when I press back button

steps

go to https://www.freeflowpages.com/dashboard
press on sign in/up button
back to the dashboard page

Actual result

There is no headers nor sign in/up button and the content is weird.
Browser
chrome 73
OS
linux ubuntu 18.04

Can not reproduce
Fixed now


how to call rpc services in middlewares?

Use closure to wrap the rpc client, and generate the new middleware. For example, for MaxConns middleware, we pass the parameter N and generate the middleware.


Make kill, pause, and unpause parallel.

Operations like kill, pause, and unpause -- which can operation on one or
more containers -- can greatly benefit from parallizing its main job (eq kill).
In the case of pauseand unpause, an --all option as was added. pause --all will
pause all running containers.  And unpause --all will unpause all paused
containers.
Signed-off-by: baude<EMAIL_ADDRESS>

Do we have perf numbers on this? I have nothing really against it, but I feel like we're buying almost nothing here, there are not expensive operations.

yes it is faster

bot, retest this please

/approve

LGTM. @TomSweeneyRedHat @umohnani8 @rhatdan PTAL

/lgtm

/lgtm


Docker image should start testnet by default

Signed-off-by: Sean Young<EMAIL_ADDRESS>

The idea is that if you run docker run hyperledger/burrow:latest you get a development chain up and running for free. Nice and easy for newcomers.
Having said that I appreciate that changing entrypoint might break stuff.
So what's the idea of having burrow as the entrypoint? If run docker run hyperledger/burrow:latest, it shows me the --help output.

I get making it easier for new users, but we're gonna break all the production runtime configs that use this docker container with this change as is because properly configured runtime configs will have start or vent or a tool as the command. I would suggest that we just tweak what you have to:
ENTRYPOINT ["burrow"]
CMD ["start"]

That would get the same effect you mention but still allow things like docker run hyperledger/burrow vent and won't break folks' charts or other runtime artifacts.

Great idea, thanks @compleatang
It works fine.

Great! LGTM.


test_RW_no_version_bump: diagnosis of test failure

(See diff for comment)
This test is failing because after the upgrade to v3 format, there is no "store.pack" file (so we can't check the io version using the store.pack file). We should probably instead use the file manager to check the io version but: File_manager doesn't export a "get version" function; and at that point in the code we only have access to a value of type repo, and there is no obvious way to access the file manager at that point.
Does anyone have a suggestion about what to do here?

(See diff for comment)
This test is failing because after the upgrade to v3 format, there is no "store.pack" file (so we can't check the io version using the store.pack file). We should probably instead use the file manager to check the io version but: File_manager doesn't export a "get version" function; and at that point in the code we only have access to a value of type repo, and there is no obvious way to access the file manager at that point.
Does anyone have a suggestion about what to do here?

We should expose a version function. Opening a file will necessarily mutate it to V3, but we can check the version before and after opening it. (I'll have a go at it if that's ok with you).

Yes, please have a go! I will follow what you do.

Additional info: The previous test test_RO_no_version_bump fails because File_manager.open_ro config expects a control file, but v1 and v2 layouts don't have a control file.

I opened https://github.com/mirage/irmin/pull/1884 instead of pushing my commits here, hope its ok.

Ioana fixed elsewhere #1884


Update PGO helpers to mitigate Y2K22 bug

The PGO helpers NuGet had the Y2K22 bug. This receives and integrates the updated package in our project to restore NuGet functionality.
PR Checklist

[x] Closes #12261
[x] I work here
[x] If it builds it sits.

Validation Steps Performed

[x] Build new PGO instrument data with this pipeline update: https://dev.azure.com/microsoft/Dart/_build/results?buildId=44304850&view=results

@msftbot merge this in 1 minute


Get mesh with small aabb

Hi,Thanks for sharing the great work!
When I use neus-facto, I can get mesh with default parameters. There is a small object in the middle of the mesh, so I set aabb to [[-0.2,-0.2,-0.2], [0.2,0.2,0.2]], but I can’t get any mesh output, where is the parameter Having trouble setting it up?

Hi, you don't need to change aabb since it's used for training. You can add --bounding-box-min -0.2 -0.2 -0.2 --bounding-box-max 0.2 0.2 0.2 to the command when you run ns-extract-mesh.

I hope that model can pay attention to the small area, so that I can get a better mesh.

I see. You can also normalise the camera poses such that the object bbox becomes [-1, 1].

Thank you very much for your reply.
I've also tried to zoom in on the area of interest to [-1,1] or narrow down aabb, but I don't get mesh, which is confusing.
In my scene, there is an object in the middle and a background around it. It seems that aabb must include the background to get the mesh. But I want mlp to focus only on the objects in the middle, so I can get more details on output.

Hi, you need to use a background model in this case. You could try to add --pipeline.model.num-samples-outside 32 --pipeline.model.background-model grid to your command. Also using a larger MLPs (8 layer with 512 hidden dimensions) could help.

Thanks for the feedback. I will giving it a try. By the way, I wonder if there's a more straight-forward way of controlling the scope of the foreground MLP ?To be specific, I have a scene with a foreground and a background object. I would like the MLP to only learn the foreground object without the background. Could you kindly point me to which parameters may be used to achieve this foreground-only reconstruction ?

Thanks for your great work @niujinshuchong. I have a similar doubt. Can we subtract the background while keeping the foreground object?

@darui18 @MIMNSI If you have the foreground masks of the object, you could create images that all the backgrounds are replaced with white/black color and set the background color with --pipeline.model.background-color white/black accordingly.

Thanks for the quick reply! I tried it on different objects and it works great on some of them. However there are cases where segmentation masks fail to cover the entire object. In these cases the mesh constructed is incomplete. Sharing a few segmentation examples here to highlight the problem

To mitigate this, maybe a method other than segmentation masks can be used.

@MIMNSI The mask looks bad. Maybe you could try the model with background modeling --pipeline.model.num-samples-outside 32 --pipeline.model.background-model grid and tune the foreground mask loss weight with  --pipeline.model.fg-mask-loss-mult.


Output version in log when the daemon is starting

When running mesg-core logs, the version of the Core is not shown.
Because the Core is running in Docker and the CLI is a binary to install, the version of both could be different.
It will be nice to have the version in the logs of the Core when its starting:
Example:
Starting Core v1.0.0

How you plan to version two binaries in the same repo? What code changes make increment core/cli version? Shouldn't they have the same version (as they are in the same repo?). Check out the issues/265 branch for review


Use correct role to publish metrics

Use correct role to publish metrics
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #275 (fd6ae41) into main (5c3ad59) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #275   +/-   ##
=========================================
  Coverage     85.71%   85.71%
  Complexity       19       19
=========================================
  Files             3        3
  Lines            49       49
  Branches          5        5
=========================================
  Hits             42       42
  Misses            3        3
  Partials          4        4

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix Cody status on missing accesses token

Fixes https://github.com/sourcegraph/sourcegraph/issues/57373.
Demo
https://github.com/sourcegraph/jetbrains/assets/19799111/6764fb2e-8532-4397-8ff6-4164effce284
Test plan

Manual:

modify the code so that com.sourcegraph.cody.auth.AccountManagerBase#findCredentials returns null
runIde

spotless check has failed 😅


Yet another install problem on Windows

2017-08-11T19_27_20_806Z-debug.log.txt
Yesterday things would build...today they will not.
Attached is the log

Completely removed node_modules folder and updated node from 6.11.1 to 6.11.2 and now I get:
Error: 404 status code downloading 64-bit node.lib

I've tested with other npm modules for node-gyp and bson, phantomjs, and bufferutils all install fine so I don't think this is an issue with my gyp and build tools.
Here's the latest output after starting everything from scratch this evening...
C:\Users\Joe\Downloads\node-test\node_modules\sharp>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
The system cannot find the path specified.
gyp: Call to 'node -e "require('./binding').download_vips()"' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: 'gyp' failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\configure.js:336:16)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Windows_NT 10.0.15063
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Joe\Downloads\node-test\node_modules\sharp
gyp ERR! node -v v6.11.2
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: 'node-gyp rebuild'
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\Joe\AppData\Roaming\npm-cache\_logs\2017-08-12T01_31_45_710Z-debug.log
PS C:\Users\Joe\Downloads\node-test> npm i --save phantomjs
The system cannot find the path specified.
npm WARN deprecated<EMAIL_ADDRESS>Package renamed to phantomjs-prebuilt. Please update 'phantomjs' package references to 'phantomjs-prebuilt'
npm WARN deprecated<EMAIL_ADDRESS>ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN deprecated<EMAIL_ADDRESS>Use uuid module instead

><EMAIL_ADDRESS>install C:\Users\Joe\Downloads\node-test\node_modules\phantomjs
> node install.js

Considering PhantomJS found at C:\Program Files (x86)\PhantomJS\phantomjs.EXE
Found PhantomJS at C:\Program Files (x86)\PhantomJS\phantomjs.EXE ...verifying
Writing location.js file
PhantomJS is already installed on PATH at C:\Program Files (x86)\PhantomJS\phantomjs.EXE
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

I'm thinking the main culprit is:
gyp: Call to 'node -e "require('./binding').download_vips()"' returned exit status 1 while in binding.gyp. while trying to load binding.gyp gyp ERR! configure error

Hello, the The system cannot find the path specified. message just above the error you highlight hints that the location of node.exe might be missing from the PATH environment variable. Perhaps something went wrong during the upgrade?
The Error: 404 status code downloading 64-bit node.lib message usually suggests multiple conflicting copies of node-gyp.
bson and phantomjs do not use node-gyp and bufferutil provides pre-compiled binaries.
Does npm install bufferutil --build-from-source work?

Hi @lovell -
You are correct that npm install bufferutil --build-from-source  wouldn't work:
gyp: Call to 'node -e "require('nan')"' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\configure.js:336:16)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Windows_NT 10.0.15063
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Joe\Downloads\node-test\node_modules\bufferutil
gyp ERR! node -v v6.11.2
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `prebuild-install || node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\Joe\AppData\Roaming\npm-cache\_logs\2017-08-13T02_45_40_017Z-debug.log

The Path issue, I've had this computer up for years and have lost a drive and there's something that's sticking around that's tossing that message out. The system can find node and other related tools just fine but as you can see below kicks out that message on some tools but not others.
node -v: v6.11.2 (no path issue)
npm -v: 5.3.0 (and I get a system cannot find the path specified)
node-gyp -v: v3.6.2 (and I get a system cannot find the path specified)
So if the issue is with my installation of NPM, any suggestions on how do I go about fixing it?

Thanks for confirming. My best guess would be a stray, older version of npm and/or node-gyp that is causing a conflict. Perhaps remove everything that could be node/npm/node-gyp related from this machine and install it all afresh. Good luck!

@lovell - This is all FYI and for what it's worth (fwiw) so the path issue wasn't at all related to node or NPM or node-gyp. I completely removed all node traces from the computer and when nodejs was re-installed and npm -v ran again, the same path message was there. The issue was from this:
https://stackoverflow.com/questions/15485632/node-js-npm-error-message-system-cannot-find-the-path-specified
and once done fixed the path error message.
I've been developing on two machines, my desktop (old) and my Surface Laptop. Previously I could only install sharp on my laptop as my desktop never was able to install the package. The other day, "all of a sudden" sharp would no longer install on my laptop either. So this sent me into having to address what is really going on.  I'm still in the process of tracking things down but the root likely applies (on the desktop at least) to Visual Studio being previously installed on my machine prior to trying to install windows-build-tools as there's a known issue (https://github.com/felixrieseberg/windows-build-tools/issues/9).
As for why the laptop suddenly stopped being able to install is likely what you mentioned being that there are multiple npm / node-gyp versions installed. I've been working on getting the desktop up and running before I turn focus to the laptop.
Once I figure all this out I'd be happy to write up some notes for fellow window's users should they run into the heartache I've bumped into. I love sharp and the code you've graciously provided to the community beyond words, I only wished I could contribute but lack the skill.
I'll update this thread, unless you'd prefer me to not do so, once I have something to share.
Thank you again kindly!


fixes related to DEPAM-396

SonarQube analysis reported 8 issues

 8 major

Watch the comments in this conversation to review them.
4 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 Queries.java#L140: Define and throw a dedicated exception instead of using a generic one.
 Queries.java#L191: Define and throw a dedicated exception instead of using a generic one.
 QuotaLimitService.java#L102: Define and throw a dedicated exception instead of using a generic one.
 QuotaLimitService.java#L106: Define and throw a dedicated exception instead of using a generic one.


fix jsx text foreground in tomorrow-night theme

@aeschli
This PR fixes #147146
Before:

Now:

@aeschli

Thanks @tjx666 !


What is this for? Eagle?

Howdy, I'm trying to open your schematics in Eagle and it dies with the message:
Error:

line 1, column 1: Start tag expected.

Is this not an Eagle sch? If not, then what is this intended to be used with?
Thanks a lot for posting this, if I can get it work, it'll save me some time. :)

No, this is a KiCad project. I haven't done a new design in Eagle in years.

Is KiCad > Eagle for homebrew prototyping?

That's a complicated argument. Best to go read the many pro/con comparisons of Eagle/KiCad and decide which issues apply to you.

Yeah, fair enough. Thanks for pointing out KiCad exists. Toodles.


Can I define multiple URL to generate CSS?

Hi, as indicated in the title, can I define multiple URL to generate the critical css?
Thanks!
Manuel

Checkout some codes from here https://github.com/shrpne/penthouse-pages

Thanks!


Revert "[Revert] Disable Windows CI for now"

Reverts hermitcore/libhermit-rs#427

bors r+

bors retry


added table_of_contents field to language model

Short description

added table_of_contents field for language model/form
Proposed changes

To print a uniform "Table of contents" header for each available
language, a new field is inserted for the language model/form and
applied to the PDF export feature.
Resolved issues

Fixes: #550

Maybe it's necessary to adjust the src/cms/fixtures/test_data.json file as well, so that the new language field is proper initialized. But I'm not sure about this. I have already added the fields values manually to the database by using the language form.

Maybe it's necessary to adjust the src/cms/fixtures/test_data.json file as well, so that the new language field is proper initialized. But I'm not sure about this. I have already added the fields values manually to the database by using the language form.

sorry, my close was a mistake, I wanted to cancel my comment :sweat_smile:


ci/cd pipeline workshop : : inception

project initiation
Ref Materials:
https://docs.oracle.com/en/solutions/cicd-pipeline/index.html
https://blogs.oracle.com/developers/post/iac-in-the-cloud-integrating-terraform-and-resource-manager-into-your-cicd-pipeline-building-natively

complete


How to update documents/embeddings stored in a vector database using semantic memory?

I've had a look through and it's not clear what the intended workflow is for this scenario. Say I've ingested a number of documents, but one has been updated, how would I go about updating the memory?

hi @jcreek you should be able to achieve what you suggest simply by uploading with the same Document ID.  If you put multiple files under the same ID you will have to upload all of them, otherwise, those missing will be considered deletions. Typically you might want to have one-file-one-document-ID, to keep things simple.
One idea: if you don't want to persist document IDs, you can generate consistent one "hashing" the original file path+name (or URL), something like:  Document ID = SHA256(lowercase(full file path))


Support contract initializers

This pull request brings support for initializers (constructors) for contracts and structs, such as in:
contract A {
  var value: Int
  var address: Address
}

A :: caller <- (any) {
  public init(value: Int) {
    self.value = value
    self.address = caller
  }
}

Only simple types, such as Int and Address can be passed in initializers for now.
This resolves #169 and #175.

#175 should be resolved as part of this PR.

This PR resolves #175.

This PR should resolve #176.


Update BASE_VERSION to 1.17-2023-03-03T19-02-38

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio_release-1.17
2c7f8a4384e57867a11d480412a2b97adfe03f55
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster


Auto close tooltip added

Related Issue
The tooltip in the password generator had to be closed manually by clicking on the close button on top right corner.
Closes: #574
Describe the changes you've made
The tooltip in the password generator now closes automatically after 3 seconds.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots
Put any screenshot(s) of the project here.

@urvashi-code1255 @991rajat I have made the necessary changes. Kindly review it.

Congratulations of merging of your first PR. :tada:
Keep Contributing.

Thank you so much @991rajat 😊

@991rajat can you please add the labels as it will help in updating my score in GSSoC'21?


chore: move accordion to one level

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?

What changes did you make? (Give an overview)

for first level of accordion alone use accordion
for anything more than first level its a static open one

Related Issues
fixes https://github.com/eslint/code-explorer/issues/71
Is there anything you'd like reviewers to focus on?

N/A

I thought the change was only going to be for properties that contained a single item, but it looks like this change also applies to arrays, where I don't think we should make this change. In arrays, it's very helpful to be able to collapse items.

Also, for accordions that can't be collapsed, I think we should change the cursor back to an arrow. Right now I still see the finger, which makes it look like the headers are collapsible.

Makes sense. The working of this accordion is different from the ones with the + sign. I was on the idea of standardising both but seems like it won't work for array values. I might have to look for other way to solve this. Will take some time on this.


Image policy not selecting the latest prerelease version properly

We have configured the ECR repository to be the ImageRepository with ecr-auto-login enabled and image policy as below to select the latest pre-release versions. But the policy is not picking up the latest image pushed to the ECR
image-repository.yaml
apiVersion: image.toolkit.fluxcd.io/v1beta1
kind: ImageRepository
metadata:
  name: context-worker-dev
  namespace: pftp-da-team
spec:
  image:<PHONE_NUMBER>96.dkr.ecr.eu-central-1.amazonaws.com/ecs/pftp/da/dev/context-worker
  interval: 1m0s

image-policy.yaml
apiVersion: image.toolkit.fluxcd.io/v1beta1
kind: ImagePolicy
metadata:
  name: context-worker-dev
  namespace: pftp-da-team
spec:
  imageRepositoryRef:
    name: context-worker-dev
  policy:
    semver:
      range: ~3.3.x-0

Attached the list of images avaiable in ECR

Image Policy is picking the version<PHONE_NUMBER>96.dkr.ecr.eu-central-1.amazonaws.com/ecs/pftp/da/dev/context-worker:3.3.0-SNAPSHOT.feature.CS-9971-fix-sonar-issues.4 which is much older than other images
Same issue is caused with other image policies as well where latest images are not picked always, but sometime it picks the latest one

Hi, I think it's doing the right thing, comparing the pre-release values lexically in ASCII sort order as described in https://semver.org/. In this case, comparing the selected version with all the other tags that were created later in terms of date, the selected one seems to be the greatest in terms of semver pre-release comparison.
We use https://github.com/masterminds/semver library for comparing the versions.

I just did a web search and found this website that helps you compare semvers https://semvercompare.azurewebsites.net/ . It's not using the same semver library, but the results should be almost the same. You can use it to verify if ImagePolicy is selecting incorrect version.

Yes the image policy is properly selecting the version as per the semver comparison website. But since we want the policy to pick up the latest pre-release version pushed to the ECR. How can we tackle this?
There are no much examples on how to select the latest pre-release versions. So it would be helpful if you can provide some logic for this

There's a whole docs page about is https://fluxcd.io/docs/guides/sortable-image-tags/ :slightly_smiling_face:

We cant use both semver and numerical options together in the policy. If we dont specify semver range to pick the pre-release version then the filter will not pickup the pre-release versions
spec:
imageRepositoryRef:
name: archive-worker-dev
filterTags:
pattern: '^3.3.0.*(?P[0-9])$'
extract: '$ts'
policy:
# semver:
#   range: ^3.3.x-0
numerical:
order: asc

Hello @poojaac! Try something like this:
spec:
  imageRepositoryRef:
    name: archive-worker-dev
  filterTags:
    pattern: '^(?P<ver>3\.3\.[0-9]+).*\.(?P<inc>[0-9]+)$'
    extract: '$ver-$inc'
  policy:
    semver:
      range: ^3.3.x-0

This will extract the relevant version parts into a semver compatible format witha a sortable pre-release part.

Hi @relu Thanks for the hint. I am able to see image-policy picking the latest image by build time.
@darkowlzz I am seeing the weird issue where sometimes image-policy will not identify the latest image in the registry and after deleting the policy from the cluster and creating again, it would be able to identify and pickup the latest image. How could we address this issue since deleting the policy and recreating would not help us in automated process

ImagePolicy reevaluates the tags whenever ImageRepository updates. In order to debug this, you can check the status of ImageRepository if it has the latest tags. It'll only scan for new tags at the set spec.interval period. The ImageRepository status contains a count of the tags it found and scan time. You can use these information to check if ImageRepository has updated or not.
status:
  canonicalImageName: ghcr.io/stefanprodan/podinfo
  conditions:
  - lastTransitionTime: "2022-08-24T20:39:05Z"
    message: successful scan, found 34 tags
    reason: ReconciliationSucceeded
    status: "True"
    type: Ready
  lastScanResult:
    scanTime: "2022-08-24T20:39:05Z"
    tagCount: 34
  observedGeneration: 1

Or just use kubectl to get the precise information:
$ kubectl get imagerepositories.image.toolkit.fluxcd.io podinfo
NAME      LAST SCAN              TAGS
podinfo   2022-08-24T20:39:05Z   34

Flux CLI can also be useful:
$ flux get images repository podinfo
NAME    LAST SCAN                       SUSPENDED       READY   MESSAGE
podinfo 2022-08-25T02:11:06+05:30       False           True    successful scan, found 34 tags

Also, while debugging, instead of deleting and creating the ImagePolicy again, you can try manually triggering a reconciliation of ImageRepository that'll also trigger ImagePolicy to update by using the flux CLI reconcile command:
$ flux reconcile image repository podinfo
► annotating ImageRepository podinfo in default namespace
✔ ImageRepository annotated
◎ waiting for ImageRepository reconciliation
✔ scan fetched 34 tags

Thanks. I will try reconciling image repository if the image-policy is not picking the latest image next time and let you know if that helps.


Use current rate of testing as default for new tests

At present we used a fixed value (from the defaultscenario file) for the number of tests inputted by the user in the scenario panel.  For most countries this is badly wrong and produces misleading results. Aurelien proposes to use the average number of tests over last 7 days, which we have already calculated in the covidresults section. This would enormously improve the usability of the application

Done


Add proper Object function matches

This takes _.matches and turns it into a proper Object Function (takes the object as the first parameter). This should satisfy the performance problems seen in jashkenas/backbone#3487.
I think it’s pretty apparent we jumbled the arguments originally. See the need to special case Backbone.Model#matches instead of auto proxying like the other _ methods.
The legacy _.matches(obj) predicate matcher has been extracted into _.matcher. _.matches will return the predicate matcher if only one argument is provided. This legacy support should be removed in v2.0.

lodash has _.isMatch it'd be nice to align to that.

Sorry, I meant to link https://github.com/jashkenas/underscore/issues/1985 as well.
I overloaded _.matches because the current functionality isn't implied by the name (I think _.matcher fits it better). I'm not tied to it, and I think getting this (or _.isMatch) merged is more important than my dislike of the current name.

Very nice.
_.matches and _.matcher are nice names for it.

Way to be a team player.

_.matches already exists it seems odd to change the behavior now. And most methods in Underscore that return a boolean are prefixed with is.

Yeah, I agree with @jdalton I think it makes sense for this to be matches (old behaviour) and isMatch for bc

Way to be a team player.

Ya :(

_.matches already exists. It seems odd to change the behavior now.

But it would make the Backbone method ugly. Model#isMatch isn't as nice as Model#matches.

And most methods in Underscore that return a boolean are prefixed with is.

Could be aliased?

This will actually break some suggestions I've made on SO and the issues as matches is not gaurded.

We can add a guard here, and remove that with v2.0 as well.

I just really dislike having _.matches return a function... :smile:

I feel like that is more effort than its worth: I'd say just leave matches be

I just really dislike having _.matches return a function... :smile:

I've gotten used to it. It makes sense since it produces a function that checks if an object matches the source. This feel inconsistent since there's isEqual and not equals.

And again the overloading is gross, sometimes returning a function or a boolean is yuck, @michaelficarra is rolling over in his seat.

@megawac: how were you using _.matches as an iteratee? _.filter(arr, _.matches) doesn't make sense.
@jashkenas: Thoughts on overloading?

@jridgewell it was something like
var obj = {a: 1};
var hasMatch = _.chain([{b: 1}, 'a']).map(_.iteratee).any((matcher) => matcher(obj));

I don't recall exactly what the code was

_.matches was a crappy name for what it was doing — it shouldn't have been added with that name in the first place. Mea culpa.
_.matches(options, {async: true})    // => true

Reads nicely.
The overloading is certainly gross, but can be removed over time. Leaving the function named poorly would be worse in the long term.

@jashkenas I disagree, a poorly named function is much better than changing the contract. This will force some users using matches to update their code for no particularly good reason

_.matches was a crappy name for what it was doing

Naming is hard and it can be seen to work as both. _.isMatch better follows the naming conventions in Underscore.

_.matches(options, {async: true})    // => true

Reads nicely.

I'd argue that it doesn't read nicely as devs are used to it having completely different behavior.

Yea, returning a function or a boolean with an optional first argument, not second, is about an confusing as it gets. If we dislike the name _.matches then let's alias and deprecate it. I don't think a bad name is a good reason to add a breaking change with completely new functionality.

I don't think a bad name is a good reason to add a breaking change with completely new functionality.

I don't think any breaking change was introduced. @megawac mentioned guarded behavior but you would never use _.matcher as an iteratee, only it's returned method. I also searched his StackOverflow answers (sorry that's kind of stalker-y) and only found one answer pertaining to _.matches, but it isn't affected by this. And if this is the concern, we can add a guard flag until the legacy support is removed.
The optional first arg is clunky, but it'll go away in the next major (hopefully) release.

@jridgewell here's a (currently non working) example of something that would break with this

var isBobOrAlice = .partial(.anyPass, _.map([{name: 'Bob'}, {name: 'Alice'}], _.matches));
isBobOrAlice({name: 'Bob'})

https://github.com/jashkenas/underscore/issues/2008#issuecomment-70552484

Damn. I'll work a guard PR.

Yea, returning a function or a boolean with an optional first argument, not second, is about an confusing as it gets. If we dislike the name _.matches then let's alias and deprecate it. I don't think a bad name is a good reason to add a breaking change with completely new functionality.

:+1:
The current way this is being implemented wastes LOC for a name. Just implement _.isMatch instead :sleepy:

Alright then — isMatch, and matcher, with matches aliased and deprecated, and removed from the docs.
@jridgewell — you got this?

Yah, I'll get a new PR tonight.
Can we get a 2.0 milestone with _.isMatch aliased to _.matches (and possibly _.isEqual -> _.equals)?

Ah, I was thinking about sooner than that ;) I'll get it.
Re: 2.0 — nah. A little naming jiggery-pokery isn't a good enough reason to start rolling that ball down the hill.

Model#isMatch isn't as nice as Model#matches.

How about pick the grammatically correct isMatching?


Bug: Web - Invalid quick-start example

Hi there!
On the web, we have a great, simple example - which is helpful for newcomers to quickly understand the intention and the idea behind the library.
Unfortunately, it has a small bug :)
We call the log() method in mymodule.mjs but we haven't defined the method in main.mjs
Current:

Proposal:
Edit the main.mjs file

Finally, thank you for this wonderful library!

Hello,
Thanks for your contribution, we have updated the document (along with version 4 release)
Cheers


Misunderstanding of the project root dir with watch mode

The watch process makes errors if I change any source files. This problem is caused by https://github.com/falsandtru/typed-dom/commit/4ada82edeec55a656685e5f8fa659c115791aaf4 even though it doesn't have any changes of settings.
$ gulp watch
[11:03:49] Using gulpfile \typed-dom\gulpfile.js
[11:03:49] Starting 'clean'...
[11:03:49] Finished 'clean' after 26 ms
[11:03:49] Starting 'watch'...
[11:03:49] Starting 'ts:test'...
[11:03:50] Finished 'watch' after 802 ms
[11:03:55] Finished 'ts:test' after 5.81 s
[11:03:55] Starting 'ts:watch'...
[11:03:55] Finished 'ts:watch' after 53 ms
[11:03:55] Starting 'karma:watch'...
DEPRECATED: use your own version of lodash, this will go away in<EMAIL_ADDRESS>30 03 2017 11:03:57.702:WARN [karma]: No captured browser, open http://localhost:9876/
30 03 2017 11:03:57.736:INFO [karma]: Karma v1.4.0 server started at http://<IP_ADDRESS>:9876/
30 03 2017 11:03:57.743:INFO [launcher]: Launching browsers Chrome, Firefox, Edge with unlimited concurrency
30 03 2017 11:03:57.765:INFO [launcher]: Starting browser Chrome
30 03 2017 11:03:57.871:INFO [launcher]: Starting browser Firefox
30 03 2017 11:03:58.638:INFO [launcher]: Starting browser Edge
30 03 2017 11:04:01.489:INFO [Chrome 57.0.2987 (Windows 10 0.0.0)]: Connected on socket WTB5luC9n9WFi-QZAAAA with id 58834570
30 03 2017 11:04:05.442:INFO [Edge 14.14393.0 (Windows 10 0.0.0)]: Connected on socket ZBuB54aQc7i7vMt8AAAB with id 91095401
30 03 2017 11:04:10.519:INFO [Firefox 52.0.0 (Windows 10 0.0.0)]: Connected on socket OTSYOSA1SBh_Ln6PAAAC with id 59737409
..................
Firefox 52.0.0 (Windows 10 0.0.0): Executed 16 of 16 SUCCESS (0.846 secs / 0.701 secs)
...............
Chrome 57.0.2987 (Windows 10 0.0.0): Executed 16 of 16 SUCCESS (0.565 secs / 0.495 secs)
...............
Edge 14.14393.0 (Windows 10 0.0.0): Executed 16 of 16 SUCCESS (1.183 secs / 1.096 secs)
TOTAL: 48 SUCCESS
Error: Cannot find module './builder' from '\typed-dom\dist'
Error: Cannot find module '../../' from '\typed-dom\dist'
Error: Cannot find module './dom/html' from '\typed-dom\dist'
Error: Cannot find module './src/export' from '\typed-dom\dist'
Error: Cannot find module './builder' from '\typed-dom\dist'
Error: Cannot find module './src/export' from '\typed-dom\dist'
Error: Cannot find module './dom/html' from '\typed-dom\dist'
Error: Cannot find module '../../' from '\typed-dom\dist'

Expected behavior:
The root dir is typed-dom,
Actual behavior:
The root dir is typed-dom\dist,

Sorry, mistake.


feat: Create an ethers.js example project

Should use a bundler that hasn't been used yet. Maybe rollup?
Should use @evmts/ethers package
Should use the new CLI external generate functionality

Cli package config example can be found in https://github.com/evmts/evmts-monorepo/blob/main/examples/vite/src/wagmi/externalExample.tsx
The config to generate the contracts is in the tsconfig
Ethers.js package can be found in https://github.com/evmts/evmts-monorepo/tree/main/runtime/ethers . There is only a single method in it at this time to create the contract. Tests have usage examples
I was going to make a package that estimates gas of optimism to build this. One is written in viem here https://github.com/ethereum-optimism/optimism/tree/develop/packages/fee-estimation . I was going to do this because it tests lots of functionality.
A gotchya is if this were to be an npm package evmts doesn't yet have the ability to generate .d.ts files. EVMts has the ability to generate .d.ts files via code gen but we don't want to include this in the example as we do not want to encourage anybody to use this as of now.  So packaging this up as an npm package will have janky types which is ok for now. We can fix it soon.

Created an ethers svelte project


Users without Modify Settings permission cannot open character sheets

If a user without the Modify Settings permission (i.e. Player, Trusted Player) tries to open a charsheet, it won't open, and in the console there will be an error like: "TypeError: An error occurred while rendering PbtaActorSheet 96. game.pbta.sheetConfig.actorTypes is undefined"
This issue occurs only inconsistently - my players had access to their sheets last night, for example, and then nothing changed and they suddenly don't have access to the sheets today. But when it does occur, giving my players the Modify Settings permission (obviously quite undesirable!) is the only fix I can find.
I've tested this with no other modules enabled but Compendium Folders and libWrapper, and also without both of those enabled, and it still occurs.
From inspecting motw-for-pbta.mjs and config-sheet.mjs it kind of seems like adding a permissions check in the Hooks.once blocks might help?  It seems like it's tripping on the game.settings.set line (the player/trusted player wouldn't have permission to modify the indicated setting, presumably) and never getting to run configSheet() which is what sets game.pbta.sheetConfig.actorTypes. Of course, if the user needs Modify Settings to set game.pbta.sheetConfig also, then it seems like the code would need to temporarily elevate permissions to do that, if that's even possible. (I'm not a Foundry modder, just an occasional module tweaker.)
Or maybe there's a way game.pbta.sheetConfig can be set server-side instead?

Thank you very much for your report! I will look into it and try to find a solution.


Fix for invoke() when multiple classes have the same Thor namespace.

For for #246

Any chance this will ever be merged?

I haven't touched Ruby in years and years. I'll close this PR. If someone finds it useful please feel free to resubmit it with a test case (which was why it wasn't accepted in the first place).


Package Updates

Here's 6 months of updates… lint and prettier are happy now.

Why did we gain a top-level word-wrap dependency?

Because require('word-wrap') was failing.

Auto DevOps is broken on this project so I disabled GitLab CI for this project by deleting the push mirror over on gitlab.com.
We can explore a mixed DevOps approach some other time.

What is requiring that? My local greps say server/formats/fasta/build and server/formats/genbank-to-fasta, but those should both be covered by the word-wrap dependency inside of server/package.json

Ah, yes, that was the server tests broken because I didn't npm i in server.

Unsurprisingly, it still works:


Fix security schema figure and limit count

Changed the figure and description to match the expected result when adding the "/" path
Fixed the limit count in yaml example to correspond to the figure

This will get picked up on the next docs site deploy


Add namespace to referenced addressable before resolving destination

The resolver uses ref.namespace to lookup the destination
addressable.
ref.namespace for the deadLetterSink is not defaulted by the
webhook like for trigger.subscriber.ref, so we might receive a
destination with an empty string for
deadLetterSink.ref.namespace which leads to not finding the
referenced addressable service.
Fixes #1011

Proposed Changes

Add namespace to referenced addressable before resolving destination

Release Note

The fields `Broker.spec.delivery.deadLetterSink.ref.namespace` and `Trigger.spec.delivery.deadLetterSink.ref.namespace` are optional.
By default the controller uses the object namespace.

@pierDipi
Have you checked if the namespace is optional in the spec?
If so, is it documented that it defaults to parent object namespace?

The spec doesn't explicitly talk about this field being optional or the default value (I'll open an issue).
The namespace for a KReference is (implementation-wise) optional and we historically defaulted it to the object namespace, for example in Trigger subscriber [1] (there are many examples).
That is also the logically expected behavior of our users as you can see in the linked issue.
I opened an issue in eventing to add this behavior https://github.com/knative/eventing/issues/5747 (and a PR).

https://github.com/knative/eventing/blob/f031ba23b23d20ed8d13491000feb0abcf50d562/pkg/apis/eventing/v1/trigger_defaults.go#L40-L41

Regarding this PR, I'd keep, regardless of the outcome of https://github.com/knative/eventing/issues/5747, the logic of this PR to make sure we don't pass invalid data to the resolver that requires a namespace to be set.

No tests were recorded.  🤔 ❓ ❓
/retest

/retest

/retest

/cherry-pick release-0.25

/cherry-pick release-0.25

/cherry-pick release-0.24

/cherry-pick release-0.23


[ENHANCE]Course The Missing Semester Chinese subtitles video group added. The hope of end!

New video group (actually, only one person) working on Cninese ssubtitle occurred. And he promise that he will never give it up.

After four episodes of hope, we are once again in the light。

这条分支的历史看起来一团糟，等我新开一条


chore: Update reactor-netty-http dependency

/perf-test ref=rhito/feat-upload-run-artificats-to-s3

/ok-to-test sha=dd235f3


Changing the depth of PASST.

I want to change the depth of the transformer while finetuning the model. I am using the following command (inspired from ESC50) :
python3 ex_dcase.py with models.net.s_patchout_t=10 models.net.s_patchout_f=5  basedataset.fold=1 -p
I have already prepared the ex_dcase.py and dataset.py files for DCASE2020 dataset (inspired from ESC50 file provided by you). I have already been able to finetune the whole model once. Now I want to add a depth parameter to the commandline to run finetune script, so that I can control how many block I want to finetune on the architecture.
Currently I change the depth by changing the depth variable of the desired architecture here.
Suggest the required changes I need to make so that I can execute a command in the commandline and only finetune selective layers.

There are two options, you can either make a new function similar to passt_s_kd_p16_128_ap486 and make the depth a parameter to the function and add it as a parameter to get_model method. In that case, you can change it directly from the command line usind sacred syntax:
python ex_audioset.py with models.net.depth=x -p

However, if you are loading a pretrained model this may break the loading, since now the model now have different weights.
I recommend using lighten_model method (as used in passt-L) which will:

remove alternating layers after loading the pre-trained model (remove every n layer): if (cut_depth=-n) < 0.
remove the last n layers after loading the pre-trained model: if cut_depth=n > 0.

example:
python ex_audioset.py with models.net.depth=x models.net.cut_depth=-2 -p

will remove every other layer from the pre-trained model to reduce the depth


Add 'setItem' function

Using the controller ref, it is possible to set the selected item.

upgraded to 2.0.4, it complains the "setItem" function is not defined when i tried to call it.

could you please share the code?
Basically you should do
1 Get access to the ref
const dropdownController = useRef(null)

<AutocompleteDropdown
          controller={controller => {
            dropdownController.current = controller
          }}
/>

2 Call the method
<Button title="Toggle" onPress={() => dropdownController.current.setItem({id: "1", title: "test"})} />

Oh, you're right, it's just a ts interface omission. I'll fix it now.

Awesome!  I will grab latest and give it a swirl! Thank you!

Try 2.0.5

Hi again,  thank you for the prompt help. I downloaded 2.0.5 and got the same error ... I notice that "setInput" was added but not "setItem" , and setItem also takes one parameter.

damn. I'm sorry :) Now 2.0.6

:( I downlowned 2.0.6 and still got the same error ... I did a log for the controller, and I don't see setItem method... I am probably missing something ... I did a cache reset a few times, but no luck so far ....
        controller={(controller) => {
          console.log({controller});
          dropdownController.current = controller;
        }}

LOG  {"controller": {"clear": [Function clear], "close": [Function close], "open": [Function open], "setInputText": [Function setInputText], "toggle": [Function toggle]}}

can you go to node_modules/react-native-autocomplete-dropdown/package.json and make sure that "version": "2.0.6"?

It finally works 👍. Thank you so much for the prompt help today!
I turned off my emulator and ran "yarn start --reset-cache" one more time.


Doesn't find my Quest no matter what I do ...

So, I've sideloaded the APK to my Quest, version v2.4.0-alpha3, and I've run it. I've also installed the program on my PC, run it and installed the drivers. Additionally, the PC is ethernet-connected and the Quest is obviously WiFi connected. I've also double checked the ports in my firewall, both UDP and TCP for Private and Public are opened. Yet, it won't find my Quest, how can I troubleshoot this further?

Did you open 9943(not 9944) udp port for ALVR.exe?
Alpha version also need this port.

most routers have separate subnets for wifi and ethernet (after all, in most scenarios you don't want the wifi clients to be able to reach the wired clients for security reasons). your pc needs to be on the same subnet as the quest, meaning that you actually have to connect the pc over wifi as well. i had this exact same problem yesterday

@polygraphene Yes, I did that, sorry I forgot to mention it.

@fjleon1980 Alright, I'm not too experienced with networking, can I by any means change my router settings so my wifi and ethernet share subnet? Otherwise, I'll have to go shopping for a dongle!

Does the ping command succeed?
If you can use Wireshark, it will help debugging.
See: https://github.com/polygraphene/ALVR/issues/62#issuecomment-398347915

you will have to login to your router's web interface and see if you can change that. in mine (an old netgear) the feature to put wifi on a different subnet is called "wifi isolation" so i had to make sure it was disabled.
MAYBE you can get them to work in different subnets if you add a static route, but that would be somewhat hard for me to explain. try googling your router and see if someone had the same question

@fjleon1980 Thanks, will look into it!

@polygraphene Yes, ping succeeds!

if ping works i don't think you have to do anything networking wise

I managed to solve it, it works with a wifi dongle in my PC, but I also tried afterwards with the WiFi Isolation, and now it works with ethernet as well. Thanks for the help :)


Convert JavaScript code to TypeScript

All Pull Requests are welcome for this work, including JS-TS conversion of a single file or multiple files.

@qu8n, you want to configure typescript in your project, right?

@FaizanMuhammadSE Yes. This project is all in JS at the moment. The first step to converting JS code to TS would include the initial setup and configurations, such as installing TS and adding the config file tsconfig.json. Let me know if you have any other questions!


tooltip: Hide tooltip for touch events on touch-enabled devices.

Fixes #16674.
An another approach as mentioned in #16710
The commit hides the tooltip for touch events on touch enabled device. Touch events trigger both click and hover action, leaving the hover action sustained until next click. Hence it is better to hide the tooltip to avoid the clutter in UI.

Testing plan:
Tested locally
GIFs or screenshots:

@timabbott This is the approach discussed in #16710

LGTM! @timabbott will do a final review within a week or so, when he gets time.

@timabbott Updated !
Ps: #16554 is unreviewed from a long time !

@ligmitz thanks, the implementation now looks clean.  Can you explain what precisely this does for touch devices -- does it make all tooltips completely inaccessible, or are they still accessible via click and just won't stick around due to the hover behavior as well?  The commit message is ambiguous, and the use of !important makes me suspect the former.

I suspect that the visibility hidden will just hide the tooltip, but it will take up space. So touch actions will not take place although it is invisible. I think it will be better to not only hide it.

@timabbott said:

@ligmitz thanks, the implementation now looks clean. Can you explain what precisely this does for touch devices -- does it make all tooltips completely inaccessible, or are they still accessible via click and just won't stick around due to the hover behavior as well? The commit message is ambiguous, and the use of !important makes me suspect the former.

In devices where the navigation is based on screen-touch, the click and hover events are treated as one single event, i.e. there is no specific meaning of hover in such devices. Hence when I click on something that has a tool-tip, the tooltip remains suspended until the next click. The fix in the commit hides the tooltip altogether for such devices as discussed here. The !important is necessary as the default css for tooltips in bootstraps tooltip.css is visibility: visible.

I tweaked the comment to explain the context a bit more clearly (E.g. using the term "touchscreen devices") and merged this.  Thanks @ligmitz!
@amanagr I guess it's possible that we'll need to redo this in your TippyJS PR?


Wrong content-length when convert multipart $batch http request

Hi Colleagues,
We are planning upgrade CAP from 7.7.3 to 8.0.1. But we are facing a content-length issue. CAP introduce a new file multipartToJson.js to handle $batch request. We have created a CAP issue and CAP team already fixed it.
But we are still facing another content-length issue below.

Below is our $batch request from fronted side. You can see the content-length is 80.

Content-length is till 80 before the below coding from v2 proxy.

The below coding deleted the __metadata but didn't adjust the content-length

After the method convertRequestData, you can see the body is changed to {} but the content-length is still 80, It should be 2.

At last, empty body{} and content-length: 80 will be pass to CAP server and got the below error.

Thanks for reporting. Haven’t tested with CDS 8 yet, as it is in milestone, but I guess a fix can be done anyways. I will have a look.

Can you check release 1.12.12, that should solve your issue:
https://github.com/cap-js-community/odata-v2-adapter/releases/tag/v1.12.12
Thanks again for reporting this issue...


dts/arm/st: Fix OTG_FS endpoint number for STM32F4 SoCs

STM32F412/413/446/469 SoCs have 6 bidirectional endpoints
according to the reference manuals RM0402, RM0430,
RM0390 and RM0386.
Signed-off-by: Yannis Damigos<EMAIL_ADDRESS>

@aurel32 Could you also check it?

Codecov Report

Merging #8465 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8465   +/-   ##
=======================================
  Coverage   64.61%   64.61%
=======================================
  Files         421      421
  Lines       40296    40296
  Branches     6803     6803
=======================================
  Hits        26037    26037
  Misses      11126    11126
  Partials     3133     3133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bdb52f...6c086b4. Read the comment docs.

@ydamigos , you like to review but can't find bidirectional endpoints in RMxx
How do you identify bidir ep in RM?
(This is a bad start for a review, let's say I'll do a cross check)


[HUDI-1437] support more accurate spark JobGroup for better performan tracking

…ce tracking
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
some description in spark ui is not reality, Not good for performance tracking.
support more accuracy spark JobGroup for better performance tracking.
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #2322 (99aee36) into master (6cf25d5) will decrease coverage by 41.94%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #2322       +/-   ##
=============================================
- Coverage     52.35%   10.40%   -41.95%
+ Complexity     2631       48     -2583
=============================================
  Files           329       51      -278
  Lines         14808     1787    -13021
  Branches       1484      213     -1271
=============================================
- Hits           7752      186     -7566
+ Misses         6441     1588     -4853
+ Partials        615       13      -602

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudihadoopmr
?
?

huditimelineservice
?
?

hudiutilities
10.40% <ø> (-59.71%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Proposal for Consul v1 parameter names

With the release of Consul v1, a number of parameter names have been deprecated. See https://github.com/hashicorp/consul/blob/master/CHANGELOG.md, 1.0.0, Breaking Changes, "Deprecated Options Have Been Removed".
Most of the parameters have simplified equivalents in v1, so they can be mapped from v0.x to v1, but not from v1 to v0.x.
I propose adding the new parameters in addition to the deprecated parameters. If a user is installing v0.x and uses a new parameter, the run fails. If they are installing v1 and uses an old parameter, we map to the new parameter and write a warning in the log.
Any comments?

@gdavison This makes sense to me. In the long run, e.g. new major version, we'd want to remove the old parameters. But I would not suggest doing that for quite awhile.

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs