v1.1

I am planning to release v1.1 soon. The main feature of this release is the addition of a language server, which can communicate with klog (>=2.3). A working version has been available since May, but I did not feel comfortable releasing it until now.
There are some caveats still, to name a few:

LSP must be enabled in settings, and set the path for the klog executable
file must be saved for LSP to work (unsure why)
only tested on Windows so far

RC1: https://public.vladde.net/vscode-klog-1.1.0-rc.1.vsix
Installation: In VS Code, go the the "Extension" page, press the three dots in the top right of its panel, "Install from VSIX…"
@jotaen Would you mind testing the extension in VS Code and give it a spin? Also, which OS are you using?

Oh cool, I might play around with this and write a Sublime plugin based on it at some point… 👀
I’ll try the v1.1 out and take a look, probably on the weekend or so. Will let you know then!
I’m on macOS.

I’ve tested today and it generally seems to work fine 🎉  Cool that it works out-of-the-box and in addition to the syntax highlighting.
Strange that it doesn’t work for unsaved files – it’s the same for me. But I think it’s not a big deal. Question: Why did you make the default to be “on save” and not “on edit”? I personally would always use the latter.
One thought that I had was that now that there is both syntax highlighting and an LSP, the red highlighting for malformed entries can become inconsistent with what the LSP reports. Both below entries are malformed, both are underlined, but the first is white and the second is red.

I had troubles when testing bigger files. For a large file with a lot of errors, the extension just “capped” the errors at some point.

I believe that this might be due to the JSON being to large, I saw this when I opened the VSCode console:

After playing around further, I ended up with this at some point:

Then, the LSP stopped working altogether until I restarted VSCode and reduced the number of records. (I had like 100 with lots of syntax errors.)

Huh, just to quickly comment on the errors failing after a while; I cannot reproduce this error. I copied your snippet and pasted repeatedly (circa 440 lines), and I do not get the same result. It runs perfectly fine for me.

I need to look into this a bit more. Busy now, and will get back later this week. Thank you for your thoughts!

there is both syntax highlighting and an LSP

Ah! That is very true. I think the syntax highlighting should be removed, even if the user does not have the klog binary configured, because it is inconsistent with itself when; some errors are highlighted (asdf and Foo), but not others (h30m, 16:00-?????????, and asdf15:00-?)
Good catch!

Haha, awesome font 🤠

Inconsistent syntax highlighting fixed with #22

I had troubles when testing bigger files.

As I mentioned, I do not experience this on my Windows machine. I will see if I can get access to a Mac.

Question: Why did you make the default to be “on save” and not “on edit”? I personally would always use the latter.

It is of personal preference, as I usually get stressed out when I start writing down something and directly get notified that something is wrong. I remember I was contemplated when deciding which alternative to be the default. I left it at "On save" because it felt the least "intrusive". (relevant…)
If you have any arguments to change it, I will gladly listen.
re: @jotaen

I’ve tried again, but couldn’t reproduce the stackoverflow error in the console unfortunately
However, I consistently see that it stops reporting errors after the file reaches a certain size. The developer console stays empty.
https://user-images.githubusercontent.com/3618384/130189734-d8dc936c-66d5-4dcd-b76a-9b7c0b0f7e65.mov
That’s my config:
Version: 1.59.0
Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:14:40.191Z (2 wks ago)
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 19.6.0

It is of personal preference, as I usually get stressed out when I start writing down something and directly get notified that something is wrong.

Yeah, that’s a fair point, I actually don’t like that either. The downside with “on save” is that people might miss is, e.g. if they exit the editor, then it prompts “do you want to save before quitting?” and then they do “Yes”, then they won’t ever see the errors.
The only idea I can think of is to delay the errors for the current word. So if you type in something, it doesn’t show errors until you either input whitespace (which terminates the previous token), or it waits like 2 seconds or so. That’s probably a bit tricky to implement, though, so not sure it’s worth it right now.

Just wanted to briefly mention this, because I did now know this until today; when I was testing this again on my computer, I found out my VS Code capped out at exactly 500 error messages. I checked the JSON outputted by klog, and it indeed outputs all errors.
However, I honestly do not think that is an issue.

Looked a this briefly, and the JSON received caps out at 4096*2 characters. The problem lies in the extension, because running the equivalent klog json test.klg in the terminal gives the full, uncapped, output.

Released. Closing.


Unable to link an external library

Type of Issue

[x] Bug Report
[ ] Feature Request

Description
I would like to add 'ng-inline-svg' as dependency of my package. Here is my configuration :
\ node_modules
|
\ lib
|    |
|    \ package.json
|    \ public_api.ts
|    \ src
|        |
|        \ modules
\ src
|    |
|    \ app
|
\ ng-package.json
\ package.json

Here is my ng-package.json :
{
  "$schema": "./node_modules/ng-packagr/ng-package.schema.json",
  "src": "lib",
  "lib": {
    "entryFile": "public_api.ts",
    "externals": {
      "ng-inline-svg": "ng-inline-svg",
      "ng-inline-svg/index": "ng-inline-svg"
    }
  }
}

Here is my lib/package.json (the main package.json is the one for my demo app of my package)
{
  "name": "my-design",
  "version": "0.0.0",
  "license": "MIT",
  "private": false,
  "peerDependencies": {
    "@angular/core": "^4.1.3",
    "@angular/common": "^4.1.3",
    "ng-inline-svg": "^3.2.1"
  }
}

I can export correctly my package (npm run packagr works, and also npm pack), but if I try to use this package (my-design) in another app (Main_Project), I get this error :
ERROR in ./node_modules/my-design/my-design/my-design.es5.js
Module not found: Error: Can't resolve 'ng-inline-svg/index' in '/Users/pailloue/Sources/Main_Project/node_modules/my-design/my-design'

I tried to put the ng-package.json inside my lib directory, but I have the same result.
Version Information
ng-packagr: v1.3.0
node: v7.10.1
@angular: v4.1.3
rxjs: 5.4.2
zone.js: 0.8.14

Please update to angular 4.4.5 and see if the issue still exists. It might be related to this.

Should the error persist, see #101 - it seems like the same root cause where an /index is appended to the import paths during compilation with ngc.

Hi @epaillous,
I see you have added the second externals entry for the /index. I would need a repro (maybe a GitHub project) to look at it.
Can you check and tell whether upgrading to angular 4.4.5 solves the issue for you?


logger will always print time in microseconds

I added the elapsed time in µs, it will be easier to parse the log automatically

its an interesting point to normalize all request times to a single unit, but, visually its nicer to read the unit of time as us, ms, s. @mrcpvn is this for instrumentation..? perhaps you should check the elapsed time and have a middleware that emits the data? .. or, perhaps we should have a formatter for the Logger to make this configurable

The logger will print the time in us, ms, s but it will always report a us measure:
2016/06/14 16:44:58 [XXXXXXXX/i4yumvPyxk-000001] "GET http://<IP_ADDRESS>:9000/test HTTP/1.1" from <IP_ADDRESS>:53425 - 400 32B in 59.893µs (59.893µs)
A formatter for the logger would be a handy solution.


Possible fix for #652

This is the fix I am using to issue #652 .

Closing since Durandal has been superseded by Aurelia just shy of four years ago.


update hugo to 0.110.0

resolve https://github.com/kubesphere/dev-guide/issues/173

cc @rayzhou2017


fix(@schematics/angular): buildRelativePath handles files in root

Before, if one of the arguments was a file in root (eg "/module")
code would fail with: "" must be an absolute path.

More context:

run into this writing my own schematics for a project that doesn't follow standard angular directory structure (meaning, there isn't always app/ directory and we do have ts files in the same directory as angular.json file.

Ups, sorry, I forced pushed the wrong revision. @ukrukarg would you open the PR again?


Make session timeout configurable

Moved from https://github.com/osiam/auth-server/issues/7:
@tkrille wrote:

30 minutes is not enough for most of the use cases. Session timeout MUST be configurable.

@dacrome wrote:

This fruit hangs so low, you just need to grap it from the ground. With Spring Boot it's now configurable with server.session-timeout. The property just need to be documented and added to the example configuration file.

It's not as low hanging as assumed at first so we reschedule it for 3.1

I do not remember, what is the problem with the session configuration? I guess we need to persist the session data between restarts.

The problem is that, while we can easily configure this for standalone deployment, when running OSIAM in Tomcat, one must configure the Tomcat to change session timeouts. But there's also Spring Session, which seems to completely take care of the session management, when activated.
I think we should start with projecting the Spring Boot property server.session.timeout onto the osiam namespace, e.g. osiam.session.timeout and adding a very short explanation for Tomcat deployments to the documentation with links to the Tomcat docs. Before that, somebody should verify the stuff I wrote in the first paragraph :)

I did not test it, but I think you are right, the server.session.timeout is only working with the standalone configuration. Let's do it like you described.

I think this is obsolete since we want to persist the sessions with Spring Session (#293) and then we can or have to set the timeouts globally @wallner @tkrille

But we still have to make it configurable. Particularly, creating a new configuration property, e.g. osiam.session.timeout.

okay, but I think the config is an implicit task of the persist sessions feature.

I don't think so. After #305 is merged, we will just obtain the ability to store sessions in the database. That's the scope of the associated task, #293. We will again use the default value for session timeout, which is 30 Minutes.


Python 3 support

Would be nice to be able to use this in python 3.
(pythonclock.org :))

I do have it on my fork though it doesn't seem to work yet (the original didn't work with python 2 for me as well)
https://github.com/sils/twitterscraper
But this would remove support for python 2

Hi sils, These are some nice changes!  If you file a pull request I can merge it. I also found a way to make it work for both python 2.7 and 3 :)
By the way, why doesnt it work for 2 for you?

I made a PR, apparently there are conflicts, I don't have time right now to resolve this.
I just don't like working with python 2, I do everything with 3 nowadays, working with 2 is always cumbersome.

oh yeah I have no idea what went wrong with python 2 anymore but I didn't get this to work. I may try again in near future since alternative approaches seem to fail.

Sils, does your twitterscraper fork work on python 3 or still not? ("I do have it on my fork though it doesn't seem to work yet")

lasse@lsx1 ~/prog/twitterscraper (git)-[master] % python
Python 3.5.2 (default, Jun 28 2016, 08:46:01)
[GCC 6.1.1 20160602] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from twitterscraper import TwitterScraper
>>> topic = 'Trump'
>>> topics = ['Trump', 'Clinton'] #if there are more than one keywords, use an array.
>>> scraper1 = TwitterScraper.Scraper(topics)
>>> a = scraper1.scrape()
collecting inf number of Tweets on the topics: Trump%20Clinton
>>> print(a)
None

doesn't seem to work :/

But then again I think it did the same for me on python 2

Hi sils,
I see that youre assigning the class Scraper to the variable scraper1, which should work. But then youre assigning the execution of the scrape() method to another variable 'a'... and this will not work.
Try 'scraper1.scrape()' instead of 'a = scraper1.scrape()'.
If you want to save the results to a file you can give a filename as a parameter as indicated in one of the examples. ;)

assignment or not, the readme shows that it should print the resuls and it
doesn't, right?

The commands were taken straight from the readme, I just assigned and printed a to show that it returns a None explicitly.

Ah ah ah, found it, working on ti

So with https://github.com/taspinar/twitterscraper/pull/5 it seems to work until I get a 404 somewhere. But at least it starts scraping.

I'm leaving you this PR, I'm working on a partial rewrite, copying only some parts of your code. It'll be a bit cleaner but I won't implement other usecases than mine specifically. However those will be addable way easier. Interested in getting this as well?
Especially having a tweet class could simplify this by far I think:
class Tweet(namedtuple("Tweet", "user id timestamp fullname text")):
    @classmethod
    def from_soup(cls, tweet):
        return cls(
            user=tweet.find('span', 'username').text.encode(),
            id=tweet['data-item-id'],
            timestamp=tweet.find('a', 'tweet-timestamp')['title'],
            fullname=tweet.find('strong', 'fullname').text.encode(),
            text=tweet.find('p', 'tweet-text').text.encode()
            if tweet.find('p', 'tweet-text') else ""
        )

    @classmethod
    def from_html(cls, html):
        soup = BeautifulSoup(html, "lxml")
        tweets = soup.find_all('li', 'js-stream-item')
        if tweets:
            for tweet in tweets:
                yield cls.from_soup(tweet)

Here it comes: https://github.com/sils/twitterscraper/blob/sils/auth/scrape_from_author.py
It actually works, has no shared state anywhere and - I think - is way easier to understand. Currently all the code is just dumped in that file, I may write an argparser and a CLI for the API later. I think this is considerably better maintainable and extendable.

Hi Lasse,
This looks much better indeed! I actually have been thinking of getting rid of classes altogether, instead use an argument parser method which returns a dict. This would make it easier to implement multithreading/processing.

So IMO let's drop https://github.com/taspinar/twitterscraper/pull/5#pullrequestreview-8100629 and get  https://github.com/sils/twitterscraper/blob/sils/auth/scrape_from_author.py in, making a nice API that supports all sorts of queries and an argparser with a CLI interface?

FYI: I'll clean this up and make a CLI now. You will get a PR.

See #7 , that does the job for me I think. May add an option for pooling multiple keywords and splitting up date ranges.

Ill approve PR #7 (which is Python 3 compatible) and make it Python 2 and 3 compatible.


Handle test failures with no message

/cc @harvesthq/ep and @pusewicz @maria-faulisi @braddunbar who encountered these
In this build (and others) it seems like there's a new type of test failure that produce a junit file a bit different from what we've seen until now. The culprit is this error element that looks like:
<error type='OpenSSL::Cipher::CipherError' message="">

The code expected the message to always be present, it seems. I've made it fallback to use the type when there's no message. This repo is already a fork of the original plugin, because it didn't show things the way we liked (back in the day), I'm not planning to look much further than this :P

We have no CI for this repo, which is a bit funny. Locally they pass:
❯ ruby ruby/tests/annotate_test.rb
Run options: --seed 23438

# Running:

..

Finished in 0.285979s, 6.9935 runs/s, 13.9870 assertions/s.
2 runs, 4 assertions, 0 failures, 0 errors, 0 skips

Gonna go ahead and figure out how to release this


[TASK] Polling leaves is not needed on deposits

Is your feature request related to a problem? Please describe.
We are currently polling leaves when trying to make deposits. This is not necessary. Instead we just need to fill in the proof values with dummy inputs (dummy UTXO inputs, dummy merkle proofs and indices for those dummy inputs). Deposits shouldn't need to verify those values in the circuit.
Describe the solution you'd like
We should check the type of transaction being made. If it is a deposit, we shouldn't block the flow to poll leaves. Instead we should make the tx and poll leaves in parallel if anything.

Closed in #880


Completions where arity information is know don't show it in the client

When arity information for a function is known it is sent to the client as i.e. function-xyz/2.
But the /2 is stripped of on the client (Eglot) for some reason.

It seems that when InsertTextFormat 2 is used than label is shown as is.


Question: mdtraj has been undergoing development

Hi, I am using traj2nmr in a software project. I am now noticing that mdtraj has been undergoing recent development. Is the traj2nmr project tracking these changes? Does it have a test suite that can catch problems as they develop? Or is traj2nmr somehow using a locked version of mdtraj? The source code does not imply that to be true as far as I can tell.

Note that mdtraj has a ticket for removing python 2 compatibility.
https://github.com/mdtraj/mdtraj/issues/1787
And shiftx2 will probably always require python 2 support.
I'm not sure how this affects the traj2nmr project. Maybe you'll just need to lock the dependencies to a certain version of mdtraj (before the python 2 support is eliminated).

Hi Barry,
Regarding your first question, I have not incorporated any automated tests to catch issues when dependencies are updated. I have been meaning to write up GitHub Actions workflow running pytest and pylint, but have struggled to find the time. Since you are using traj2nmr as a dependency, I will see what I can do. In the meantime you may need to create your own fork with locked dependencies to avoid any nasty surprises. Note that nmrglue has also been updated recently and could cause problems.
I am not concerned about the Python2 issue with mdtraj. ShiftX2 is executed as a subprocess explicitly using Python 2.7 (shifts.py, line 142 and 147). The remainder of the code should run using Python 3. Both python2.7 and python3 will always need to be installed just for the sake of ShiftX2. It's a very hacky approach, but not much can be done about except hope for a ShiftX3.
Cheers,
D


_typecheck rule doesn't seem to run tsc

Hey, I've created a repro repo for this (which I hope is helpful), but in essence I have the following Bazel file:
load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
load("@aspect_rules_swc//swc:defs.bzl", "swc_transpiler")
load("@bazel_skylib//lib:partial.bzl", "partial")

ts_project(
    name = "src",
    srcs = [
        "src.ts",
    ],
    transpiler = partial.make(
        swc_transpiler,
    ),
    tsconfig = "//:tsconfig",
)

The contents of src.ts is minimal, but crucially it requires some types info from @types/long:
import * as Long from 'long';
console.log(Long);

export const foo = 1;

From the docs I understand that bazel build //src would run swc and therefore no type checking will be done, and that I can then run bazel build //src:src_typecheck to invoke tsc separately - love that feature! However, when I do that it doesn't throw, despite the fact that //:node_modules/@types/long isn't set as a dependency.
If I then remove the custom transpiler so that ts_project always uses tsc then it throws the expected error:
src/src.ts(1,23): error TS2307: Cannot find module 'long' or its corresponding type declarations.

If I then add the types as a dependency of the non-swc build, it will build:
ts_project(
    name = "src",
    srcs = [
        "src.ts",
    ],
    tsconfig = "//:tsconfig",
    deps = [
        "//:node_modules/@types/long"
    ]
)

So from that it looks like the _typecheck rule doesn't run tsc?

Update: looks to be because I don't have declaration = True in the attributes / root tsconfig.json. Wondering if it should either toggle it on for the _typecheck case or throw if it's set to False?

Yeah I would have expected an error if tsc was being run for no outputs, which is the case for transpiler-only and no declarations

Sort-of related other thing (just because I'm looking at this atm).
If I do a tsc build with the type deps in place with the above repo, then comment them out, the second build still works (I guess because the types are still available somehow?). If I bazel clean and try again it fails saying it can't find the types for long.

I think that's a separate issue and is probably a bug in the worker mode, could you file another for that?
For this issue, this is the code I'd expect to have prevented the bug:
https://github.com/aspect-build/rules_ts/blob/main/ts/private/ts_project.bzl#L129-L132
do you have a couple minutes to debug and see why you didn't get into that conditional?

Yes very happy to try and debug, but timezones being as they are I'm afk now. Will give it a whirl on Monday! ... And I'll file a bug for the other issue.

Okay, so a few things. Let's see.
The reason the clause you highlighted doesn't execute is because there is a dep: [<target //src:_validate_src_options>], which means the final condition of the if isn't satisfied. (For clarity, js_outs and typings_outputs are both empty, so they are both satisfy their conditions.)
The line below that checks for len(outputs) doesn't run the TS compiler, however, because outputs is empty. Even with declaration set to true in tsconfig.json I see the same values for js_outs, typings_outputs, and ctx.attr.deps unless I also set declaration to True in ts_project.
If I set declaration attribute to True in ts_project and have it set to true in tsconfig.json then it will run tsc in both the custom-transpiler case (bazel build //src:src_typecheck) and the no-custom-transpiler case.

Thanks - I don't think that and not ctx.attr.deps belongs on that condition. I did some digging and it was introduced back here https://github.com/bazelbuild/rules_nodejs/commit/96d37b6eb88ed72d40654fec5f1a9055ba5ee5e7 without an explanation of why.
Looks like the fix is just to restore that line.


Nested lines don't work in xbar

Example:
#!/bin/bash
echo "a"
echo "---"
echo "b"
echo "--c"
echo "-----"
echo "--d"

This shows nested line in BitBar but not xbar

@onaront thanks for reporting this - please try the latest release, I think I fixed it.

Looks fixed now, thanks.

Actually there's still a problem. Try this:
#!/bin/bash
echo "a"
echo "---"
echo "--c"
echo "-----"
echo "--d"
echo "---"
echo "f"

Last line does not show, but it shows as single dash in the sub menu.

Hey @onaront - please give the latest release a try.

Looks like it's working. Thanks!


add support for mjpg

this is in the example

You now have a decision to make, whether do merge this or #40 (this does re-compress the mjpeg when the device already supports it) :-)


Only load known_hosts if it exists or is requested

If ~/.ssh/known_hosts does not exist, Xenon will throw an Exception in its default settings. Updated the adaptor to only throw this exception if ~/.ssh/known_hosts was actually requested for by the user. Still keep the behaviour that Xenon loads the file if it exists.

Fixes #347.


Loose target and dont chase?

When a NPC dont see a target in his chase range, he dont chase him, that´s good. But when he saw a target one time, he doesnt loose the target after not seeing him. That is in most situations good. But we have some NPCs with bow who don´t should chase someone, which he cant see anymore. Is there an option? Before the update I could change the chaserange to a small and the attack range to a high value. So he shot to him, but didnt chase him. When I try this now, he doesn´t shoot, when the chaserange is small. It´s so difficult to explain :D What I actually want to ask is, if there is an option, that the Sentinel loose the target and don`t chase him, when he cant see him.

Just disable chasing for that NPC?

They are walking a path. When I disable chasing, they continue the walk while shooting. We want them staying or trying to come to the target few blocks. while shooting. But when they dont see the target, they shouldnt chase anymore.On an old sentinel version I put chaserange = 5 and attackrange = 20. So they shot 20 meters long, walked some meters on their wall or tower to get a better position, but when they couldnt see me anymore, they walked their path. I know its a special request, so if there is no solution, we will try to find a good alternative.

There's an option somewhere to set how long an NPC will continue focusing on a target when it's out of view...

Sounds good. Let me know when u found the option.
PS: Now our server contains several hundred Sentinel NPCs.  A big thank you from all users who use the server goes to you.

It's /sentinel targettime TIME... when I said "there's an option..." I was kinda hoping you would go look at the readme. Where it's conveniently listed .-.

Oh sorry. I did read it so often and I never saw it. Thanks.


Made the signature of INgModelController.$validators more precise

And corrected the return type of $asyncValidators.
Per the docs, IModelValidators should only accept two arguments instead of a var-arg. Also, the content type of the IPromise returned in IAsyncModelValidators should not be constrained.
Tests included.

@pocesar @rfranco could you review this PR?

that's correct, plus when you try to return a non-promise on an $asyncValidator, it throws.
viewValue is either NaN, undefined or a string, so assuming a string is fine (besides the NaN part, that's the initial state of all ngModels)
$asyncValidator doesn't care about the return value of the promise, it fails when it's rejected, so IPromise<any> is fine, since you can just resolve(false) and it just work. if the promise returns undefined, then the validator is put in a pending state (1.3+ only)

@pocesar thanks!
@billccn thanks mate! if you have other improvement, please send it again :wink:


Cluster Settings Doc Update

Re: Cluster Settings
The Description column on this page does not fit horizontally and there's no scroll in sight. Even if I maximize the window on my wide-ass monitor, I still can't see the whole things; it's quite hard to read.

@andreimatei take a look at the build output on #4644 and see if that makes it better.


Added: House-of-Gods Exploitation Technique

As discussed in #157 here is the PoC for House-of-Gods.
I decided to write the PoC for glibc-2.24 instead of glibc-2.26 because of the missing tcache functionality in 2.24. This way, we don't need to prefill the tcache and can focus solely on the core of this exploit.
I also had to adjust the glibc_run.sh script in order to search the old_list of glibc-all-in-one.

Thanks for the contribution and sorry for the months-long process.
The PR looks good to me.

...sorry for the months-long process.

No problem :) Thanks for merging.


It disables vscode elixir tools extension autocompletion

Hi @pantajoe first of all, thank you for such a neat tool. However i have just one problem, if i have it enabled at the same time I enable the elixirtools extesion for autocomplete purposes, now i cannot see my Elixir autocompletion suggestions. It is so frustrating that i cannot have the best of both worlds. Could you suggest a set of linters and formatters and language servers that best work with your extension with little to no conflict, or otherwise could you check on what is the bug creating this conflict with autocompletion.

Hi! Thanks for raising this issue.
That's very strange, I'm not a heavy Elixir user myself, so I'll have to look into this. Normally, of course, that shouldn't be the case 🤷🏽♂


Create 'CONTRIBUTING.md'

One example: https://github.com/atom/atom/blob/master/CONTRIBUTING.md
tl;dr: there are good issues to pick up labeled 'good first issue', issues on our critical path (ie, as part of our milestones) we want to do ourselves, until the project has stabilized.

Resolved in https://github.com/ZcashFoundation/zebra/pull/843


Connecting to cloud sql instance using workload identity federation credential config file

Question
👋🏼 Hey folks, I could not find a clear explanation for this issue, hence thought this might be the best place to get some clarity on the Cloud SQL proxy setup for Workload Identity Federation(WIF) with AWS.
I have some Kubernetes pods in my AWS project that would like to access my cloud sql instance in GCP. I am using cloud-sql-proxy: 2.3.0 as a sidecar container on my AWS pods. I followed the WIF docs  to set up a pool and provider, associated it with a service account that has Cloud SQL Client role assigned to it.
The WIF docs mention that the path to the WIF credential configuration file can be passed to the GOOGLE_APPLICATION_CREDENTIALS  environment variable. I have attached the WIF configuration file to the cloud-sql-proxy container and passed its path in the GOOGLE_APPLICATION_CREDENTIALS environment variable.
However, when I try to connect to a database, I run into the following error where the request to get the access token seems to be failing.
2023/06/21 12:14:25 Authorizing with Application Default Credentials
2023/06/21 12:14:25 [dev:us-east1:test] Listening on <IP_ADDRESS>:3306
2023/06/21 12:14:25 The proxy has started successfully and is ready for new connections!
2023/06/21 12:17:51 [dev:us-east1:test] accepted connection from <IP_ADDRESS>:39086
2023/06/21 12:17:51 [dev:us-east1:test] failed to connect to instance: failed to get instance: Refresh error: failed to get instance metadata (connection name = "dev:us-east1:test"): Get "https://sqladmin.googleapis.com/sql/v1beta4/projects/dev/instances/test/connectSettings?alt=json&prettyPrint=false": oauth2/google: unable to generate access token: Post "https://iamcredentials.googleapis.com/v1/projects/-/serviceAccounts/aws-test@dev.iam.gserviceaccount.com:generateAccessToken": oauth2/google: unable to retrieve AWS security credentials - error fetching credentials: forbidden by policy

Initially thought this might be due to a wrong WIF configuration or have to do with restriction on AWS, but I was able to spin up an alpine container in the same pod and generate the access token using the same WIF configuration following the REST API authentication steps in the WIF doc. When I started the cloud-sql-proxy with the generated access token, I was able to connect to the cloud-sql instance, this confirmed that the WIF configuration is correct.
So now I'm trying to understand if the cloud-sql-proxy supports WIF, and if this works with the configuration file path is passed to the GOOGLE_APPLICATION_CREDENTIALS environment variable?
Thanks
Code
No response
Additional Details
No response

Hi @v4runMurthy,
Yes, Proxy v2.3.0 does support workload identity federation. We have tested this successfully using all-GCP credentials and services. However, it should work with any supported workload identity configuration, including AWS.
Yes, the proxy does load the the application credentials configuration from the file specified in the GOOGLE_APPLICATION_CREDENTIALS environment variable.
Based on the error message, I suspect that the pod lacks permission to access an AWS metadata service due to some combination of kubernetes roles and AWS IAM policy. I found a similar error and solution from another person trying to set up workload identity on AWS EKS.  I suspect that this part of the error: error fetching credentials: forbidden by policy occurs under these circumstances:

The pod starts.
The proxy attempts to use the google oauth2 library to authenticate.
The google oauth2 library loads the configuration from the file path in GOOGLE_APPLICATION_CREDENTIALS env var.
The google oauth2 library recognizes that it is using AWS credentials and attempts to get a token from the AWS metadata service.
The AWS metadata service denies the request responding with the error response: 403: forbidden by policy

This is an interesting case. Let us know how you solve it.

@hessjcg thanks for confirming that the cloud-sql-proxy supports WIF with credentials from the path provided to GOOGLE_APPLICATION_CREDENTIALS environment variable. Your explanation for AWS metadata service not being accessible makes sense as I tried to change the IAM role on the pods and got a different AWS error.
I will check this out and post back what I find, after updating access to the AWS metadata service from the EKS pods

I'm going to close this but if you're still hitting Proxy-related problems, feel free to add more info here and we'll help out.


Feature - add support for Keycloak auth provider

Follows https://github.com/guardian/alerta/pull/348

Fixed by #74.


Improved JENKINS_HOME example

Reasons for making this change:
After years of use I've come up with some improvements to the JENKINS_HOME.gitignore example.

Major performance improvement: On very large Jenkins installations that have been running for more than one year, there tends to be many builds (hundreds of thousands of builds).  The builds directory of these jobs contain millions of files which would cause Git to hang for several minutes on simple commands like git status and longer for committing changes.  strace was used on Git to figure out the performance impact and this proposed change includes the optimization.  I also added a clear comment explaining the line's purpose.
There's an example for how to include Jenkins encryption keys, and there's a disclaimer informing the user why they shouldn't but still giving an example.
Comments have been reworded and slightly reformatted to be a little more clear.

Links to documentation supporting these rule changes:
No docs, this change comes from real world experience using the template as the original author across several companies.  I included a thorough commit message documenting reasoning for changes.

@shiftkey this pull requests builds on my original contribution #1763 as an enhancement.  It doesn't fundamentally change the configuration purpose.  It just includes some performance fixes and more commented out examples for people with varying needs.  i.e. those who do not care about the secrets being backed up with their configuration.  The default is still to be secure.


Fail early, in modern GENERIC builds, if certain required browser functionality is missing (issue 11762)

With two kind of builds now being produced, with/without translation/polyfills, it's unfortunately somewhat easy for users to accidentally pick the wrong one.
In the case where a user would attempt to use a modern build of PDF.js in an older browser, such as e.g. IE11, the failure would be immediate when the code is loaded (given the use of unsupported ECMAScript features).
However in some browsers/environments, in particular Node.js, a modern PDF.js build may load correctly and thus appear to function, only to fail for e.g. certain API calls. To hopefully lessen the support burden, and to try and improve things overall, this patch adds checks to ensure that a modern build of PDF.js cannot be used in browsers/environments which lack native support for critical functionality (such as e.g. ReadableStream). Hence we'll fail early, with an error message telling users to pick an ES5-compatible build instead.
To ensure that we actually test things better especially w.r.t. usage of the PDF.js library in Node.js environments, the gulp npm-test task as used by Node.js/Travis was changed (back) to test an ES5-compatible build.
(Since the bots still test the code as-is, without transpilation/polyfills, this shouldn't really be a problem as far as I can tell.)
As part of these changes there's now both gulp lib and gulp lib-es5 build targets, similar to e.g. the generic builds, which thanks to some re-factoring only required adding a small amount of code.
Please note: While it's probably too early to tell if this will be a widespread issue, it's possible that this is the sort of patch that may warrant being git cherry-picked onto the current beta version (v2.4.456).
Fixes #11762
Much smaller/easier diff with https://github.com/mozilla/pdf.js/pull/11771/files?w=1

/botio unittest

Looks like a good change to me; thanks! Note that the Travis CI build did run and pass, but for some reason it's not visible on GitHub.


Missing sharedKey when following documentation

In Step 3 of the Running the interactive shell section of Using Opaque SQL I get the following error when running edu.berkeley.cs.rise.opaque.Utils.initSQLContext(spark.sqlContext):
edu.berkeley.cs.rise.opaque.OpaqueException: Cannot begin attestation without sharedKey.
  at edu.berkeley.cs.rise.opaque.RA$.initRA(RA.scala:47)
  at edu.berkeley.cs.rise.opaque.RA$.attestEnclaves(RA.scala:110)
  at edu.berkeley.cs.rise.opaque.Utils$.initSQLContext(Utils.scala:316)
  ... 49 elided

This can be fixed by starting the shell with
spark-shell --jars ${OPAQUE_HOME}/target/scala-2.12/opaque_2.12-0.1.jar --conf spark.opaque.testing.enableSharedKey=true

instead of what's specified in the docs:
spark-shell --jars ${OPAQUE_HOME}/target/scala-2.12/opaque_2.12-0.1.jar

But I'm assuming that you don't want to include that configuration flag in this section since it shouldn't be used in production. Perhaps you could specify it's necessary for local testing or something? Or am I doing something wrong?

I think we need stronger documentation to make it explicitly clear that running anything that isn't the Listener class requires a trusted driver in which this flag is enabled (even Listener currently requires this, however). Basically, nothing but spark-submit --class edu.berkeley.cs.rise.opaque.rpc.Listener ... should be used in production in the future. @wzheng what do you think?

Yes, we should specify that we only work in the single party setting, and that the driver program must be put on the client side for production usage, and the testing key should not be used. For anything other than production, the testing key can be enabled. We should document this configuration here. I wonder if we want to also have a specific section on "Deploying in production"? Though we used to say that Opaque is experimental.

I like the "deploying in production" idea. I think we should also mention that attestation or log verification is not currently supported in there as well.

@ryanleh when you have time, can you please work on these amendments to the docs? You've been very thorough with finding gaps in them so far.


removed tasklist access for court admin

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PRL-918
Change description
DA factor
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing, will be merged as part of https://github.com/hmcts/prl-ccd-definitions/pull/247


Support yarn --pnp

With their new versions, yarn has now a option called "Plug'n'Play" (there isn't any official doc yet) which removes the node_modules/ folder
Do you have plan to support this new feature?

Yup. Something should be done.

@tunnckoCore can you be a little bit more specific. I still think there is nothing the ESLint extension needs to do.

Maybe. I don't know. Yea, maybe more correct would be eslint to support it.

This a problem with this extension and has nothing to do with eslint itself. Yarn PnP does not create /node_modules, but your extension tries to load it from there instead of asking yarn to resolve it.

I do ask yarn for the node modules path and then use require.resolve() to load it. There is no hardcoded knowledge of a node_modules folder in this extension.
Can anyone provided me with hints how that should work with yarn --pnp. To the documentation here it should work out of the box for require.resolve. https://yarnpkg.com/en/docs/pnp/getting-started

Setup to reproduce: https://github.com/Microsoft/vscode-eslint/issues/653#issuecomment-481629947

Seems like this has to be resolved upstream in microsoft/vscode-languageserver-node, since that is where Files.resolve comes from. I opened an issue there: microsoft/vscode-languageserver-node#496

See my comment here: https://github.com/microsoft/vscode-languageserver-node/issues/496#issuecomment-500744820

This issue can be closed.
It has been resolved at yarnpkg/berry#312

@Teoxoy cool to hear. I do have a question: how were you able to solve this in yarn without any changes to ESLint?

@vlasenko implemented it.
Yarn v2 has an optional package called @berry/pnpify which wraps typescript and now eslint. Installing pnpify and then adding this vscode setting "eslint.nodePath": "scripts/tssdk" makes eslint work in a pnp environment.

Very cool. Thanks for the clarification.

Some more info can be found here https://next.yarnpkg.com/advanced/pnpify#vscode-support


Export Filled anchor

This adds the missing export for the Filled anchor, so it's exported by default just as all other anchors.
Thus, the extra-import can be skipped in apps using this plugin and we avoid this warning:
import 'package:flutter_portal/flutter_portal.dart';
import 'package:flutter_portal/src/anchor.dart';  // <-- can be skipped

LGTM, thanks

https://github.com/fzyzcjy/flutter_portal/runs/6175976816?check_suite_focus=true
Well, CI fails. Could you please format it?

Codecov Report

Merging #74 (6becc9c) into master (db312ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   78.79%   78.79%
=======================================
  Files          10       10
  Lines         764      764
=======================================
  Hits          602      602
  Misses        162      162

Flag
Coverage Δ

main-tests
78.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db312ae...6becc9c. Read the comment docs.


SafeMap Len() is Linear Time Instead of Constant and ForEach() is Unsafe

While reading through the safemap package I noticed that Len() is being calculated with the sync.Map function s.data.Range(). It looks like this was previously constant time prior to this PR: https://github.com/anthdm/hollywood/pull/63/files because len() is constant for a traditional map.
It's worth noting that (sync.Map).Range() isn't safe since it's non blocking meaning (SafeMap[K,V]).ForEach() isn't either. Therefore it's not guaranteed to get an accurate length or an accurate slice of []*PID for children in actor.Context.
The (sync.Map).Range() function comments state:
// Range does not necessarily correspond to any consistent snapshot of the Map's  contents: no key will be visited more than once, but if the value for any key  is stored or deleted concurrently (including by f), Range may reflect any  mapping for that key from any point during the Range call. Range does not  block other methods on the receiver; even f itself may call any method on m.
So this would lead to a common concurrency bug: https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use.
Since safemap is used by children in actor.Context, if the number of children is sufficiently large, then calculating length will be slow and likely inaccurate if children are changing.
The performance gains of https://github.com/anthdm/hollywood/pull/63 traded off safety for speed. Depending on your thoughts, it might be worth rolling this back to have a lock in SafeMap.
Is the use case for children aligned with the optimization of sync.Map? It seems like it isn't. Note that according to the docs the sync.Map  "type is optimized for two common use cases: (1) when the entry for a given key is only ever written once but read many times, as in caches that only grow, or (2) when multiple goroutines read, write, and overwrite entries for disjoint sets of keys. In these two cases, use of a Map may significantly reduce lock contention compared to a Go map paired with a separate Mutex or RWMutex."

the change was mine and to be honest I did it only based on the benchmarks I did at the time, not really taking the safety and semantics into account. The case for reverting it is good.

@nrhvyc Thanks for your detailed write up. I think reverting is the right call.


fixed missing semicolons

Hello mithril community. I was looking at the code in file mithril.js and discovered there are bunch of missing semicolons (eslint used here). I thought it could help you to add them back.

Why?

There's an eslint config setting to allow for missing (optional) colons. You can set this per directory.


DTD version parsing fix

Introduced Standard Linting
Fixed a bug in multiPacket handling. Needs verification/discussion as it's kinda blindly implemented.

You are absolutely right. I have introduced som errors on my aggressive linting attempt.
Thank you for your time, too bad I was a waste. I have learned much about the protocol and have a better understanding now of what's going on.

Oooh, I see how I broke it...
The linter complained about un-used variabled, so I had removed the two lines reading through the version bytes.

Well, lesson learned. And after all I managed to patch my own bug....


University of West Attica

@ksidis I am sorry, the domain uniwa.gr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


ci(packages): enable greenkeeper

Description of change
Enable Greenkeeper.
Associated issue(s)
Closes #2
Acceptance criteria/task completion

[x] The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

:white_check_mark: Please review and check the appropriate items.

1. Code standards compliance

[x] ESLint passes.

2. Code quality

[x] The quality gateways pass with an "A" grade.

Measure
Scores

Complexity

Duplications

Issues

Maintainability

Reliability

Security

3. Test coverage

[ ] The source code is 100% covered with passing specs.

** These tasks are not required to open a PR, and may be addresses while the PR is open.**

I'm merging this into master despite test failures and insufficient coverage, in order to enable Greenkeeper.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Revise FluentMigrator migrations

Added AbpAuditLogs table as last.
Also, I should check and update migrations.

Cancelled since all implemented.


Apply pixel scaling

An attempt to fix scaling on retina displays

Hi! I found your commit and rewrote on top of "bcareil"'s fork. (There's so many forks! :-) )
There were some unused variables... ? It works well anyway!
https://github.com/ernstp/pobfrontend/commit/5fa9fb714bf29f38436dd0164227f8622a94925c


refactor: adjust server endpoint in hub kubeconfig template

What type of PR is this?
/kind refactor
What this PR does / why we need it:
Adjust server endpoint from karpor-server.karpor.svc to <IP_ADDRESS> in hub cluster kubeconfig template, becuase the k8s internal domain cannot be resolved in the local environment.
Which issue(s) this PR fixes:
Fixes #520

/lgtm


[analyzer_plugin] SourceEdit.applySequence is flawed

Simply:
if we want "aaabbbccc"fix to "123"
String code = "aaabbbccc";
code = SourceEdit.applySequence(code,[SourceEdit(0,3,"1",), SourceEdit(3,3,"2",),SourceEdit(6,3,"3",),]);
actually, after apply first edit, the offsets of follow edits are changed.

The documentation isn't clear enough, but the reason it specifies that the edits are applied in order is to let you know that the list is expected to be sorted with the largest offset first. We do specify the sorting requirement in the protocol spec (at least for the analysis server) so that clients will know to sort the edits before applying them. We just failed to make that clear in the docs for this utility method.
That method will also fail if the edit regions overlap, which probably also needs to be specified.


Question about the wording of "multiple Gigabit network adapters"?

From the document, it says:
Initial sizing
It can be difficult to accurately estimate the right size. We recommend that you start with a machine with at least 8 CPU cores, 8 GB of RAM, and multiple Gigabit network adapters. You can then measure a typical gateway workload by logging CPU and memory system counters.
Is it referring to multiple adapters for the gateway VM?
If it's YES, what's the suggestion on numbers and configurations?
thanks!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93be3185-bbc2-6e4a-0b3b-8c2d0482a148
Version Independent ID: e9c257ea-9a49-d954-5954-4d14442c49a5
Content: On-premises data gateway sizing - Power BI
Content Source: powerbi-docs/guidance/gateway-onprem-sizing.md
Service: powerbi
Sub-service: powerbi-gateways
GitHub Login: @peter-myers
Microsoft Alias: kfollis

Thanks for your comment, @rocdong. This issue has been assigned to the doc author for review.

Hi @rocdong - the answer is yes, but we cannot make a recommendation for the numbers, since it will be dependent on the set-up and load on the customers environment. I hope that helps.


Support cleanup during unwinding

Feature
Currently the generated unwinding information only restores registers. This issue proposes to make it possible to also run cleanup actions like running destructors during unwinding.
Benefit
This is necessary to support unwinding after a panic in rustc_codegen_cranelift.
Implementation
Add a new invoke terminator that is similar to the call instruction, but has an additional cleanup edge. This cleanup edge will be ignored when emitting actual machine instructions, but it will take part in the regalloc. Next add a way to mark a block as "landing pad". Only "landing pad" blocks can be used as cleanup edge of an invoke terminator. At the start of a "cleanup" block all values are stored either on stack or in any of the registers restored by the system unwinder. The "landing pad" block can also take several arguments. Those will be the values stored in the registers that are allowed for arguments to the landing pad received from the personality function. After codegen the location of every "landing pad" block will be stored in a variable. This will allow the embedder to generate the appropriate LSDA (language specific data area) to reference from the unwinding table.
Alternatives
It is basically impossible to implement cleanup during unwinding without Cranelift support.
References
The "Transferring Control to a Landing Pad" section of https://software.intel.com/sites/default/files/article/402129/mpx-linux64-abi.pdf

Original pdf no longer exists. See https://itanium-cxx-abi.github.io/cxx-abi/abi-eh.html instead.

Could this issue be solved independently using the aforementioned solution in the OP's comment or would #3427 be needed to be resolved first?

I'm working on this.

@bjorn3 Any PR or branch where it is possible to follow progress?

https://github.com/bjorn3/wasmtime/tree/bsc-unwinding-simple-invoke3 is the latest version I have. I will rebase it and work on upstreaming when I finish my thesis about it.


OIDC authentication - session not persists issue

I'm trying to implement Google OIDC authentication on an existing amundsen.
All the micro services (search, metadata, frontend) are deployed with helm on AWS EKS and, without authentication, it works.
But when I enable OIDC, as you'll see below, session information does not persist and frontend starts showing a "Something went wrong..." message.
Here's the related logs from frontend. (sensitive info replaced with arbitrary number of *'s + I put the 'test_data' in session for debugging purposes)
2021-08-13T17:23:20+09:00 /usr/local/lib/python3.7/site-packages/flask/json/__init__.py:179: DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead.
2021-08-13T17:23:20+09:00   rv = _json.dumps(obj, **kwargs)
2021-08-13T17:23:20+09:00 /usr/local/lib/python3.7/site-packages/flask/json/__init__.py:205: DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead.
2021-08-13T17:23:20+09:00   return _json.loads(s, **kwargs)
2021-08-13T17:23:20+09:00 2021-08-13T08:23:20+0000.168 [DEBUG] __init__._before_request:23 (11:MainThread) - Whitelisted Endpoint: status,healthcheck,health,logout
2021-08-13T17:23:20+09:00 2021-08-13T08:23:20+0000.169 [ERROR] models._fetch_token:88 (11:MainThread) - Calling _fetch_token(name=google)...
2021-08-13T17:23:20+09:00 2021-08-13T08:23:20+0000.169 [ERROR] models._fetch_token:92 (11:MainThread) - <SecureCookieSession {'test_data': 'test data', 'user': {'__id'<EMAIL_ADDRESS>'at_hash': '**************', 'aud': '***********************', 'azp': '*****************', 'display_name': '******************', 'email': '*****************', 'email_verified': True, 'exp':<PHONE_NUMBER>, 'family_name': '******', 'given_name': '***********', 'hd': '***************, 'iat':<PHONE_NUMBER>, 'iss': 'https://accounts.google.com', 'locale': 'en', 'name': '************', 'nonce': '*************', 'picture': '****************', 'profile_url': '', 'sub': '**********', 'user_id': '*****************'}}>
2021-08-13T17:23:32+09:00 /usr/local/lib/python3.7/site-packages/flask/json/__init__.py:179: DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead.
2021-08-13T17:23:32+09:00   rv = _json.dumps(obj, **kwargs)
2021-08-13T17:23:32+09:00 /usr/local/lib/python3.7/site-packages/flask/json/__init__.py:179: DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead.
2021-08-13T17:23:32+09:00   rv = _json.dumps(obj, **kwargs)
2021-08-13T17:23:32+09:00 /usr/local/lib/python3.7/site-packages/flask/json/__init__.py:179: DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead.
2021-08-13T17:23:32+09:00   rv = _json.dumps(obj, **kwargs)
2021-08-13T17:23:32+09:00 2021-08-13T08:23:32+0000.720 [DEBUG] __init__._before_request:23 (10:MainThread) - Whitelisted Endpoint: status,healthcheck,health,logout
2021-08-13T17:23:32+09:00 2021-08-13T08:23:32+0000.720 [ERROR] models._fetch_token:88 (10:MainThread) - Calling _fetch_token(name=google)...
2021-08-13T17:23:32+09:00 2021-08-13T08:23:32+0000.720 [ERROR] models._fetch_token:92 (10:MainThread) - <SecureCookieSession {'test_data': 'test data'}>
2021-08-13T17:23:32+09:00 2021-08-13T08:23:32+0000.721 [ERROR] models._fetch_token:100 (10:MainThread) - 'user'
2021-08-13T17:23:32+09:00 2021-08-13T08:23:32+0000.721 [ERROR] __init__._before_request:59 (10:MainThread) - User not logged in, redirecting to auth
2021-08-13T17:23:32+09:00 Traceback (most recent call last):
2021-08-13T17:23:32+09:00   File "/usr/local/lib/python3.7/site-packages/flaskoidc/models.py", line 94, in _fetch_token
2021-08-13T17:23:32+09:00     user_id=session["user"]["__id"],
2021-08-13T17:23:32+09:00   File "/usr/local/lib/python3.7/site-packages/flask/sessions.py", line 83, in __getitem__
2021-08-13T17:23:32+09:00     return super(SecureCookieSession, self).__getitem__(key)
2021-08-13T17:23:32+09:00 KeyError: 'user'

My suspicions are:

Google OIDC has different specs, for example, in my setup, OAuth2Token (flaskoidc) saves access token, refresh token and such, instead of name or user_id. So I tweaked the flaskoidc lib to authenticate the current session user using some google apis, but still the error persists.
Metadata also produces suspicious logs. Except the healthcheck signals, it always returns 302. Is it meant to work like this? I'm not sure.

Expected Behavior
meant to work out of the box?
Current Behavior
frontend shows 'something went wrong' messages after login when hooked with google oidc
Possible Solution

Steps to Reproduce

deploy amundsen using the helm chart in gith repo using frontend-oidc: 3.11.1, metadata-oidc: 3.5.0, search:2.5.1 with flask OIDC env variables for Google oidc

Any update on this issue?
i am facing the same issue

@shlsheth263 could you please share how you fix this issue?

@drodrigues3 https://www.stemma.ai/blog/how-to-setup-oidc-authentication-in-amundsen
Ive followed this.

I'm facing the exact same issue. I've tried solving that guide above, but did not solve it for me. @shlsheth263 anything in the guide you reckon was the key change or any other advice?

@miguelpromptly  for me worked after I did downgrade of the flaskoidc lib, now I'm using flaskoidc==0.2.3 and this is working well

@drodrigues3 were you able to retrieve user details from google oidc ?
i am getting following error:
ERROR:metadata_service.config:404 Client Error: Not Found for url: https://accounts.google.com/api/v1/users?q=<email_id>&limit=1
amundsenmetadata    | Traceback (most recent call last):
amundsenmetadata    |   File "/app/metadata_service/config.py", line 98, in get_user_details
amundsenmetadata    |     user_info = get_user_from_oidc(user_id=user_id)
amundsenmetadata    |   File "/app/metadata_service/config.py", line 54, in get_user_from_oidc
amundsenmetadata    |     response.raise_for_status()
amundsenmetadata    |   File "/usr/local/lib/python3.7/site-packages/requests/models.py", line 943, in raise_for_status
amundsenmetadata    |     raise HTTPError(http_error_msg, response=self)
amundsenmetadata    | requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://accounts.google.com/api/v1/users?q=<email_id>&limit=1

I'm having this same problem but with okta, someone managed to solve it?

@shlsheth263 I solved this issue by disabling Amundsen authentication and building a custom authentication layer in front of it & modifying Amundsen source to use it. Seems like many users heavily modify Amundsen due to issues like this one.

Hey @shlsheth263 , how did you overcome this? I would love any insight. facing exact same issue.

Any update in this issue, guys? I'm facing the exact same issue.

Any update?

I am getting similar issue so adding @verdan , if he can help here.

up

@verdan, I have notice that if I am running locally ( as http://localhost:5002 )  and integrating Okta then I am not getting session issue but if I integrate localhost and put ALB on top of and have ALB url register into Okta then session is getting lost.

Same conditions here @NiravLangaliya

@verdan

anyone?

i am getting the same but things are working! I use
flaskoids==1.0.4
on all services and i install that explicitly not through
pip3 install -e .[oidc]


Leaf Field Selections

http://facebook.github.io/graphql/draft/#sec-Leaf-Field-Selections

implemented with #221


Allow implementation selection via ENV var

As an author of a project depending on this library, I'd like to select underlying implementation by ENV variable regardless my computer setup to see possible differences in occurring issues. E.g.
$ DRAFTER=JS npm install

vs.
$ DRAFTER=CPP npm install

Note: Are there any existing workarounds how to force one version or another to test out stuff?

Yes, I originally considered adding an environment variable switch but I wanted to keep the code simple instead of adding potentially unnessecery features. But if there is demand it totally makes sense to add this.

Let's wait with this. In https://github.com/apiaryio/dredd/pull/573 I later realised the issues I have are due to https://github.com/apiaryio/dredd/issues/574 and not because of the protagonist/drafter change. Thus, my request for this feature lost its use case for now. The two libraries seem to behave in the same way.
I'll test against both for a while anyway as Dredd seems to be the first consumer ever, but I can achieve that by deleting protagonist folders. I probably won't keep the practice for long and will test only against drafter.js after some period.

Just found out another workaround how to force Drafter NPM to use Drafter.js: have a virtualenv where python means Python 3 :trollface:

@honzajavorek Is this still needed? You can use npm install --no-optional to disable Protagonist during installation.

That's exactly what I do


Add SeaBench dataset

Ready for another round of reviews 👍

Hi @shayne-longpre ! Just a quick ping if there are any other comments for this PR so we can merge


SlideMenu with UITabBarController : Strange behaviour

Hello @dekatotoro, @Pluto-Y ,
I have quite an issue while using the SlideMenuController with a mainViewController being an UITabBarController.
Here's my case :
I have a tab bar with two tabs and another VC
When I'm crawling in the tabs, everything is perfect, but when I show the other view controller that is not related to the tabs, when it's dismissed, the layout of my tabs are broken. The frames are a little too high and we can't see the label in the first tab anymore.

Here is the code : https://github.com/Nitner0C/slideMenuControllerTabs

@IBAction func changVC(sender: AnyObject) {
        if let button = sender as? UIButton {
            if button.tag < 2 {
                if slideMenuController()?.mainViewController != mainViewController {
                    slideMenuController()?.changeMainViewController(mainViewController, close: true)
                } else {
                    closeLeft()
                }
                if let mainViewController = mainViewController as? UITabBarController {
                    mainViewController.selectedIndex = button.tag
                }
            } else {
                if slideMenuController()?.mainViewController == otherVC {
                    closeLeft()
                } else {
                    slideMenuController()?.changeMainViewController(otherVC, close: true)
                }

            }
        }
    }

@Nitner0C I have the same issue can you help?


Implement post previews

Right now, all of the blog post previews are simply Lorem Ipsum placeholder text. What should be there is the first N words (or characters?) of the actual post.
This change will require:

Adding a "preview" column to the post table
Updating the sync_blogs task to fetch a preview from the page
Updating the index template to use the preview text present in each post

Might just grab the entire post since searching / tagging are planned features.


Fix installation instructions in README

Right now, instructions in README seem to be a bit inconsistent - code is checking for silk being added to INSTALLED_APPS setting, and the README says about adding silk.apps.SilkAppConfig there.

https://github.com/jazzband/django-silk/blob/master/silk/apps.py#L4 this should work right?

@auvipy according to docs this will be loaded automatically. It makes sense to use path to AppConfig class in INSTALLED_APPS only when there are more than one class in apps module.


Build requires tusb.h but does not exist.

It's an honor to be able to use your project.
I tried to proceed with the build myself, but it stopped due to the problem as shown in the below.
[ 20%] Built target pico-tflmicro
[ 20%] Building CXX object CMakeFiles/pico_micro_speech_analog.dir/src/main.cpp.obj
C:\pico\pico-wake-word\src\main.cpp:19:10: fatal error: tusb.h: No such file or directory
19 | #include "tusb.h"
|          ^~~~~~~~
compilation terminated.
NMAKE : fatal error U1077: 'C:\PROGRA~2\GNUARM~1\102020~1\bin\AR10B2~1.EXE' : '0x1' 반환 코드입니다.
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30037\bin\HostX64\x64\nmake.exe"' : '0x2' 반환 코드입니다.
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30037\bin\HostX64\x64\nmake.exe"' : '0x2' 반환 코드입니다.
Stop.

Hi @BoomTei,
This repository requires setting up the Pico SDK beforehand. I’ll update the README.md. But to fix your issue:
# download pico sdk
git clone https://github.com/raspberrypi/pico-sdk.git
cd pico-sdk
git submodule init
git submodule update
cd ../
export PICO_SDK_PATH=pico-sdk

# build micro speech
mkdir build
cd build
cmake ..
make

Hope this helps, let me know any more issues

Thanks to your help, the problem has been solved. But another problem has arisen.
[ 83%] Built target hello_pdm_microphone
Scanning dependencies of target usb_microphone
[ 83%] Building C object lib/pico-microphone/examples/usb_microphone/CMakeFiles/usb_microphone.dir/main.c.obj
In file included from C:\pico\pico-sdk\lib\tinyusb\src/tusb.h:80,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\usb_microphone.h:11,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\main.c:17:
C:\pico\pico-sdk\lib\tinyusb\src/class/audio/audio_device.h:40:2: error: #error You must tell the driver the length of the audio function descriptor including IAD descriptor
40 | #error You must tell the driver the length of the audio function descriptor including IAD descriptor
|  ^~~~~
In file included from C:\pico\pico-sdk\lib\tinyusb\src/tusb.h:80,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\usb_microphone.h:11,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\main.c:17:
C:\pico\pico-sdk\lib\tinyusb\src/class/audio/audio_device.h:55:2: error: #error You must tell the driver the number of Standard AS Interface Descriptors you have defined in the audio function descriptor!
55 | #error You must tell the driver the number of Standard AS Interface Descriptors you have defined in the audio function descriptor!
|  ^~~~~
C:\pico\pico-sdk\lib\tinyusb\src/class/audio/audio_device.h:70:2: error: #error You must define an audio class control request buffer size!
70 | #error You must define an audio class control request buffer size!
|  ^~~~~
NMAKE : fatal error U1077: 'C:\PROGRA~2\GNUARM~1\102020~1\bin\AR19DD~1.EXE' : '0x1' 반환 코드입니다.
I don't think the microphone is defined, so I'd appreciate it if you could tell me how to solve the problem.

Hi @BoomTei,
This repository requires setting up the Pico SDK beforehand. I’ll update the README.md. But to fix your issue:
# download pico sdk
git clone https://github.com/raspberrypi/pico-sdk.git
cd pico-sdk
git submodule init
git submodule update
cd ../
export PICO_SDK_PATH=pico-sdk

# build micro speech
mkdir build
cd build
cmake ..
make

Hope this helps, let me know any more issues

Thanks to your help, the problem has been solved. But another problem has arisen.
[ 83%] Built target hello_pdm_microphone
Scanning dependencies of target usb_microphone
[ 83%] Building C object lib/pico-microphone/examples/usb_microphone/CMakeFiles/usb_microphone.dir/main.c.obj
In file included from C:\pico\pico-sdk\lib\tinyusb\src/tusb.h:80,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\usb_microphone.h:11,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\main.c:17:
C:\pico\pico-sdk\lib\tinyusb\src/class/audio/audio_device.h:40:2: error: #error You must tell the driver the length of the audio function descriptor including IAD descriptor
40 | #error You must tell the driver the length of the audio function descriptor including IAD descriptor
| ^~~~~
In file included from C:\pico\pico-sdk\lib\tinyusb\src/tusb.h:80,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\usb_microphone.h:11,
from C:\pico\pico-wake-word\lib\pico-microphone\examples\usb_microphone\main.c:17:
C:\pico\pico-sdk\lib\tinyusb\src/class/audio/audio_device.h:55:2: error: #error You must tell the driver the number of Standard AS Interface Descriptors you have defined in the audio function descriptor!
55 | #error You must tell the driver the number of Standard AS Interface Descriptors you have defined in the audio function descriptor!
| ^~~~~
C:\pico\pico-sdk\lib\tinyusb\src/class/audio/audio_device.h:70:2: error: #error You must define an audio class control request buffer size!
70 | #error You must define an audio class control request buffer size!
| ^~~~~
NMAKE : fatal error U1077: 'C:\PROGRA2\GNUARM1\1020201\bin\AR19DD1.EXE' : '0x1' 반환 코드입니다.
I don't think the microphone is defined, so I'd appreciate it if you could tell me how to solve the problem.

Hi @BoomTei,
This repository requires setting up the Pico SDK beforehand. I’ll update the README.md. But to fix your issue:
# download pico sdk
git clone https://github.com/raspberrypi/pico-sdk.git
cd pico-sdk
git submodule init
git submodule update
cd ../
export PICO_SDK_PATH=pico-sdk

# build micro speech
mkdir build
cd build
cmake ..
make

Hope this helps, let me know any more issues

Hi @BoomTei, sorry the above command I sent was for an older version. I have just retested the steps from scratch and built the binary. Please use the following steps:
git clone https://github.com/henriwoodcock/pico-wake-word
git submodule init
cd lib/pico-sdk
git submodule init
cd ../../
mkdir build
cd build
cmake ..
make -j8

You will then find all the binary files inside the build directory.

Hi @henriwoodcock.
I analyzed again and found that the uf2 file was generated normally. The problem is expected to be with pico-microphone\examples\usb_microphone in lib. The CMakeList deletes the part of the add_subdirectory ("examples/usb_microphone") and thus compiles normally.
If you have time, could you check the appropriate part of the extract/usb_microphone? I think it's a problem caused by the microphone not being defaulted, but I don't know how to solve it.

No worries @BoomTei, you can find the pico-microphone repository here (where this error is coming from). @sandeepmistry may be able to help you over there.


MWPW-116861 - Fragment Unwrap

Unwrap a fragment if it is the only child of a paragraph tag.
Gracefully handles scenarios where fragments are placed in lists or have sibling content.

Previous selector hierarchy:
.section > .content > p > .fragment

After this change:
.section > div > .fragment

Resolves: MWPW-116861
Milo Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/rclayton/fragment-test?martech=off
After: https://fragment-unwrap-update--milo--adobecom.hlx.page/drafts/rclayton/fragment-test?martech=off

Bacom Test URLs:

Before: https://main--bacom--adobecom.hlx.page/customer-success-stories/princess-cruises-case-study?martech=off
After: https://main--bacom--adobecom.hlx.page/customer-success-stories/princess-cruises-case-study?martech=off&milolibs=unwrap-fragments

@So1ene I'd like to see what impact this has on Artist Hub.

@So1ene I'd like to see what impact this has on Artist Hub.

I checked with milo-libs=fragment-unwrap-update and everything looks good!


Create sample extension that contributes remote jupyter servers (as a form of documentation)

We have the ability for extensions to contribute remote jupyter servers to the Jupyter extension
we shoudl create a sample and document how this can be done
This way if someone wishes to connect to Jupyter running on some special remote environment they can contribute this via the above API (just as Azure AML & others)

FYI, it seems like the ms-ai-tools-test example extension might be relevant to this. I came across it a couple of months ago when looking to add the functionality mentioned in #11518, but I no longer had a Kerberos environment to test it in, so I never got to it.
Hope this helps and, in any case, thanks for opening this issue, @DonJayamanne!

https://github.com/microsoft/vscode-extension-samples/pull/913
https://github.com/microsoft/vscode-jupyter-hub


Correct packages support for .netcoreapp3.1

The latest extension packages are not compatible with .netcoreapp3.1 (there are warning during the build).
Fix it

Netcoreapp3.1 has reached its EOS: https://devblogs.microsoft.com/dotnet/net-core-3-1-will-reach-end-of-support-on-december-13-2022/
I guess it's better not to update it. Moreover, logging source generators don't work in netcoreapp3.1


🍒 Cherry pick PR #18173 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/18173 to staging 🍒

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.3.8-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.8-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Error while updating db

Platform: Mac OS Monterey V12.6
Command: casparser-isin --update
Error:
`Traceback (most recent call last):
File<EMAIL_ADDRESS>line 1346, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
File<EMAIL_ADDRESS>line 1257, in request
self._send_request(method, url, body, headers, encode_chunked)
File<EMAIL_ADDRESS>line 1303, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File<EMAIL_ADDRESS>line 1252, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File<EMAIL_ADDRESS>line 1012, in _send_output
self.send(msg)
File<EMAIL_ADDRESS>line 952, in send
self.connect()
File<EMAIL_ADDRESS>line 1426, in connect
self.sock = self._context.wrap_socket(self.sock,
File<EMAIL_ADDRESS>line 500, in wrap_socket
return self.sslsocket_class._create(
File<EMAIL_ADDRESS>line 1040, in _create
self.do_handshake()
File<EMAIL_ADDRESS>line 1309, in do_handshake
self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/casparser-isin", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.9/site-packages/casparser_isin/cli.py", line 123, in main
update_isin_db()
File "/usr/local/lib/python3.9/site-packages/casparser_isin/cli.py", line 92, in update_isin_db
remote_meta, local_meta = get_isin_db_details()
File "/usr/local/lib/python3.9/site-packages/casparser_isin/cli.py", line 54, in get_isin_db_details
with request.urlopen(build_request(META_URL)) as response:
File<EMAIL_ADDRESS>line 214, in urlopen
return opener.open(url, data, timeout)
File<EMAIL_ADDRESS>line 517, in open
response = self._open(req, data)
File<EMAIL_ADDRESS>line 534, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
File<EMAIL_ADDRESS>line 494, in _call_chain
result = func(*args)
File<EMAIL_ADDRESS>line 1389, in https_open
return self.do_open(http.client.HTTPSConnection, req,
File<EMAIL_ADDRESS>line 1349, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1129)>`

I'm unable to reproduce this in the same OS :(
The SSL certificate error should not happen, as the packages are entirely hosted in the cloud.
Can you please give it a try again?
❯ casparser-isin --update
2023-01-24 07:57:10,835 - INFO - Fetching remote isin db metadata
2023-01-24 07:57:11,284 - INFO - Local db version  : 2023.1.16
2023-01-24 07:57:11,285 - INFO - Remote db version : 2023.1.24
2023-01-24 07:57:11,285 - INFO - Fetching database version :: 2023.1.24
2023-01-24 07:57:15,309 - INFO - Updated casparser-isin database.

❯ casparser-isin --update
2023-01-24 07:57:20,398 - INFO - Fetching remote isin db metadata
2023-01-24 07:57:20,829 - INFO - Local db version  : 2023.1.24
2023-01-24 07:57:20,829 - INFO - Remote db version : 2023.1.24
2023-01-24 07:57:20,829 - INFO - casparser-isin database is already upto date

Not sure what is different on my setup. But having this error for this command. I am able to download the latest db via curl though.
Just to further inform my python version is Python 3.9.6 if that helps.

Figured a solution. Since I installed python via homebrew certificates are not installed.
Need to run the following script:
https://github.com/Unbabel/COMET/issues/29#issuecomment-945601519


Point v2.0-alpha at non-yanked release

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/bd10d5985abdcb8324a72f29b259f582e59c8566/

quoting @jseldess:

Ah nice. I can’t sign in on my phone but I think lgtm.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/db4d090d7bf252106bb2d59ce93670c5f80e1de8/

@jseldess do you know what's up with the test failure

External link https://binaries.cockroachdb.com/cockroach-v2.0-alpha.20180129.windows-6.2-amd64.zip failed: 404 No error

i.e. why isn't that file there?

I just opened a separate branch to resolve this, since some users are likely running into problems: https://github.com/cockroachdb/docs/pull/2558.


Stalled sync

Probably related to #1047
Syncing witti, eventually the initial sync stalled completely, no further progress, even with 4 peers
the last logs present:
2020-06-24 20:55:07  [CHAIN]            info: Epoch 29 is justified!
2020-06-24 20:55:07  [CHAIN]            info: Epoch 28 is finalized!
2020-06-24 20:55:07  [CHORES]           info: Started archiving states (finalized epoch #28)...
2020-06-24 20:55:07  [CHORES]           info: Archiving of finalized states completed (finalized epoch #28)
2020-06-24 20:55:07  [CHAIN]            info: Processed new chain head newChainHeadRoot=0x055ae68f7ff2da84ef8192fe2b587701fec57a3631878f6180df9fe55240d7a3, slot=962, epoch=30
2020-06-24 20:55:08  [CHAIN]            info: Processed new chain head newChainHeadRoot=0xcd1b6e12075a04b26ae1fa616642f5e61f23f079339f04d17ba894ac6eb2fdc6, slot=964, epoch=30
2020-06-24 20:55:08  [CHORES]           info: Started archiving 32 blocks from slot 864 to 895(finalized epoch #28)...
2020-06-24 20:55:08  [CHORES]           info: Archiving of 32 finalized blocks from slot 864 to 895 completed (finalized epoch #28)
2020-06-24 20:55:08  [CHAIN]            info: Processed new chain head newChainHeadRoot=0x9aaa2fe92de92cc55dfca434e21e0fc35b0dfc9e8fbf80b0e833704ab0f6779a, slot=968, epoch=30
2020-06-24 20:55:18  [NETWORK]         error: failed to send request bd3fc69fcad56f2e to peer 16Uiu2HAmBqaNcNitjW1kar4voXHhuHoJkfqr8yS4s1xCSqJVM3Vb Error: response timeout
Error: response timeout
    at nextAbortHandler (/home/cayman/Code/lodestar/node_modules/abortable-iterator/index.js:37:20)
    at AbortSignal.abortHandler (/home/cayman/Code/lodestar/node_modules/abortable-iterator/index.js:16:29)
    at AbortSignal.dispatchEvent (/home/cayman/Code/lodestar/node_modules/event-target-shim/dist/event-target-shim.js:818:35)
    at abortSignal (/home/cayman/Code/lodestar/node_modules/abort-controller/dist/abort-controller.js:52:12)
    at AbortController.abort (/home/cayman/Code/lodestar/node_modules/abort-controller/dist/abort-controller.js:91:9)
    at Timeout._onTimeout (/home/cayman/Code/lodestar/packages/lodestar/lib/network/util.js:115:55)
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
(node:416273) UnhandledPromiseRejectionWarning: TypeError: Cannot read property '0' of undefined
    at BeaconChain.<anonymous> (/home/cayman/Code/lodestar/packages/lodestar/lib/sync/sync.js:65:78)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:416273) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 5)
(node:416273) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
2020-06-24 20:59:22  [SYNC]             info: Received goodbye request from 16Uiu2HAkvDJV2wMEgLVEjuUdtjpg5ejreWxJNYZ7zEFJyRwGrnxW, reason=1
2020-06-24 21:01:24  [SYNC]             info: Received goodbye request from 16Uiu2HAmMz8b8cha8FLnCG6x6L5uU8YqfauLnUcnCCeNsLFEJVwY, reason=2
2020-06-24 21:01:24  [NETWORK]         error: failed to send request 1b5f6986603cca0a to peer 16Uiu2HAmMz8b8cha8FLnCG6x6L5uU8YqfauLnUcnCCeNsLFEJVwY Error: read ECONNRESET
Error: read ECONNRESET
    at TCP.onStreamRead (internal/stream_base_commons.js:201:27)
2020-06-24 21:25:17  [SYNC]             info: Received goodbye request from 16Uiu2HAkxM6gf6qNaVPPkREf1AyS8D7gAj75j4Cf5oy8Ch7FqzV5, reason=1

Resolved in #1130


Unable to enable plugin

Describe the bug
When trying to enable plugin, I get a popup with the following error:

Unable to load addon script from path: 'res://addons/yat/Plugin.cs'. This might be due to a code error in that script.
Disabling the addon at 'res://addons/yat/plugin.cfg' to prevent further errors.

Steps to reproduce

Import YAT via AssetLib
Try to enable plugin in Project Settings
An error is thrown

Expected behavior

Plugin should be enabled successfully

Additional information

Windows 11 23H2 (22631.3737)
Intel(R) Core(TM) i7-8809G CPU
YAT 1.31.1-beta
Godot v4.2.2.stable.mono.official [15073afe3]
dotnet:

> dotnet --list-sdks
8.0.303 [C:\Program Files\dotnet\sdk]
cuddles-skull\dkaszews@Cuddles-Skull:~
> dotnet --list-runtimes
Microsoft.AspNetCore.App 8.0.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 8.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 8.0.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Screenshots
No response
Additional context
No response

From the steps to reproduce, I see that you did not mention compiling the project. Did you follow instructions in the USAGE.md file? It's important to create a C# solution first, compile the project, and then you can activate the plugin.

By "compile", do you mean exporting the project as executable? Sorry but I am completely new to Godot.
I missed those instructions before, but they don't seem to help:

Create empty project
Add C# solution
Export project
Import YAT via AssetLib
Try to enable plugin in Project Settings
An error is thrown

I have noticed the following error in MSBuild tab:

CS0103: The name 'EditorInterface' does not exist in the current context C:\Users\dkaszews\code\Godot\First Game\addons\yat\src\update\UpdaterWindow.cs(108,9)

Alright, now I am a little lost. Can you watch this quick video and tell me if you do something differently, or the same and there are still errors?
By "compile" I mean using dotnet build or clicking the hammer icon in the editor in the upper right corner, but since you are getting an error with MSBuild, you did it.
At this point, the only thing I can think of is some bug in .csproj, or it's an old bug that hasn't gone away.
https://github.com/user-attachments/assets/63c104e3-f4a2-4d52-a759-8474d721eb0e

Thank you for the video, that cleared everything up!
There was something broken with my dotnet installation, as trying to follow those steps resulted in "Failed to create C# project" and "Unable to find .NET SDK". Reinstalling dotnet and rebooting system helped the issue.


can we add our custom captions in txt files

can we add our custom captions in txt files ?

supposedly, the captions are properly loaded, but once I start training I got this error:
Error
join() argument must be str, bytes, or os.PathLike object, not 'NoneType'
×
Info
Generated train script at train.bat
×
Error
cannot identify image file 'C:\pinokio\api\fluxgym.git\datasets\368e9aa8-71ab-4421-aabe-7fd5347ea46d\0 22.txt'

text files should just fill the captions, not be considered as images

it seems like the same thing here : https://github.com/cocktailpeanut/fluxgym/issues/30 where the guy says " When you load images + text captions the matching of captions to images is done properly but the script considers all files (images + text captions) as images and training fail when trying to resize a caption text file.... "

for me it means to drag&drop imgs only and then one by one ctrl+c ctrl+v captions from somewhere else...

can confirm this bug, the preparation phase recognized that we already have caption txt files for each image, but the training phase tried to run the txt files as images, hence the error. The training also mistakes as more photos, example we have 15 images+ captioning the training phase will take it like 30 photos

I made a workflow for ComfyUI, the training is abit faster (1it/s), and doesn't have any of the issues I had with FluxGym; (loads and reload the run if few seconds, properly loads .txt files, more parameters, stay in the ComfyUI environment) it's just better
https://civitai.com/models/743615/easy-lora-trainer


Importing Failed Read 192 but expected 152

level0.zip
Another report: Exporting everything and then opening it in Unity gives this:

Remove 'Managed' folder before using ripper


Update Check-O-Matic with cases to check for experimental toxicity data

Given that we are introducing new target annotation data, we can update the Check-O-Matic  rules to ensure that it checks if given targets have the correct experimental toxicity data.
To ensure proper coverage, the following scenarios should be tested:

A target with only ETOX data - one tissue (e.g. ENSG00000168065)
A target with only ETOX data - multiple tissues (e.g. ENSG00000108846)
A target with only TOX21 data (e.g. ENSG00000144891)
A target with both ETOX and TOX21 data (e.g. ENSG00000118777)
A target with multiple tissues tested in multiple TOX21 panels (e.g. ENSG00000091831)

Additional scenarios may need to be considered based on the curation work of @PruMM.

Issue closed as work completed as part of 20.04 release process


PDF support for the demo

How about putting the PDF part behind a feature flag? It is a bit fragile…

It's just the demo. Lots of things in the demo are fragile. I'm not worried about it :)

@bors-servo: r+

:pushpin: Commit dec6fa0 has been approved by pcwalton

:hourglass: Testing commit dec6fa05f0c6098448d98bedb6ee6b1913ecbd11 with merge 0bf0f58fa49e601f1bb626e7cfa4cd8fa6873baa...

:sunny: Test successful - checks-travis
Approved by: pcwalton
Pushing 0bf0f58fa49e601f1bb626e7cfa4cd8fa6873baa to master...


[Feature request] Make SVG arrowheads match the line color

Hello,
Fairly simple problem: when I generate an SVG image with a directed edge that is  some non-black color (e.g., red blue etc.), the arrow head that is generated seems to always be black.  I did not see an option to change this via API.
I manually modified the output files and added fill="context-stroke" to each marker and that resolved it, while also allowing for multiple edge colors in the output graph.  I hypothesize that it's as simple as modifying the static at this line to resolve this:
https://github.com/nadavrot/layout/blob/573248c3fc690650d83bd41fdb1a917676c6dae3/layout/src/backends/svg.rs#L19
Happy to submit a PR myself if it is that simple, but I wasn't sure if there are some non-obvious issues with those changes.

Hi @holtjma , thanks for reporting the issue. Please submit a PR. Make sure to run cargo fmt before sending the patch. Thank you.


fix(docs): correct minimum supported Python version

Description
Public documentation wrongly states supports Python >= 3.5 this project but it uses type annotation for variables (PEP 526) which is a backward incompatible language feature added in version 3.6.
Motivation and Context
As a final user, I got bitten by the misleading documentation. Tried to incorporate this driver to a project that uses Python 3.5.
Testing

Screenshots (if appropriate)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist

[ ] Local run of ./build.sh succeeds
[ ] Code changes have been run against the repository's pre-commit hooks
[ ] Commit messages follow Conventional Commit Specification
[x] I have read the README document
[ ] I have added tests to cover my changes
[ ] I have run all unit tests using pytest test/unit and they are passing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @ramiro-eb ,
Thank you for taking the time to open this pr and address the discrepancy in our docs. Apologies for the issues this caused on your end. I will chat with the Amazon Redshift driver team and review this pr in the coming week.


Force vertex shading in SpatialMaterial when used

Fixes: #33835
When using vertex lighting, roughness needs to be set in the vertex() function. When set in the SpatialMaterial it adds ROUGHNESS = roughness, but when set in the ProjectSettings, ROUGHNESS is never set. This PR adds an override into SpatialMaterial so ROUGHNESS is appropriately set whether vertex lighting is set in the material or in ProjectSettings.

@akien-mga this is good to merge for 3.x

Needs a rebase (style changes), then we should merge it indeed.

Thanks!


[BUG] <scripts. start.sh  in different JDK version ,parameter in JAVA_OPTS  is invalid >in macos jdk version is 11，start.sh do not work

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Expected Behavior

remove -XX:+UseFastAccessorMethods
./start.sh  do work .
Steps To Reproduce
No response
Environment
ShenYu version(s):2.4.1

Debug logs
No response
Anything else?
No response

can you fix it？

Edit start.sh, find the'UseFastAccessorMethods' parameter and remove it. It should be ready to start.

In the script, judge the JDK version and select the GC optimization parameters of the corresponding version.
it will be  better.

@IceFoxs  you can fix it

@IceFoxs you can fix it
I try fix it

@IceFoxs you can fix it
I already submit the pr ,you can check it.

done


⚠ T:Riza Roblox Proxy has degraded performance

In f753e48, T:Riza Roblox Proxy (https://rprxy.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 19169 ms

Resolved: T:Riza Roblox Proxy performance has improved in 778225b.


feat: Ape framework implementation

Index ape-config.yaml files for ape projects

Read from config:

solidity version
contracts directory
dependencies directory
remappings
dependencies

Installation of dependencies is checked and enforced before being operational

Dependency support:

through version
through branch name
local dependencies

Closes #391

@kanej marking this as WIP, as I noticed it needs some polishing. will get it ready for tomorrow

I added some more APE protocol tests, mainly to remind myself how our protocol tests work.

Codecov Report

:exclamation: No coverage uploaded for pull request base (development@9e1aa5e). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head c5bac6a differs from pull request most recent head e933241. Consider uploading reports for the commit e933241 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@              Coverage Diff               @@
##             development     #458   +/-   ##
==============================================
  Coverage               ?   53.50%
==============================================
  Files                  ?      187
  Lines                  ?     4792
  Branches               ?      790
==============================================
  Hits                   ?     2564
  Misses                 ?     1991
  Partials               ?      237

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat: prevent disabled user account from logging in

feat: prevent disabled user account from logging in

I am not able to write e2e tests for this since I need to wait for this feature first:
PATCH users/:id for both admin and self users.

The admin user can then enable the isAccountDisabled flag via API call.


Training problem

Thank you for your sharing.
I've been studying fdscs recently. I trained this network with psmnet, but the network can not converge well.
Loss will continue to decline, but 3-px error will remain unchanged when it drops to about 70.
Therefore, could you share your pretraining model or your modifications of training and verification.
Thank you again and look forward to your reply.

Thank you for following. I've emailed you.


e2e: Switch syncer and token-dependent tests to shared fixture

Switch to test-managed syncer to enable syncer-requiring tests to use shared fixture.

This should pass tests, but I still have to figure out why the syncer isn't working correctly against a logical cluster for the downstream target.


fix: increase gunicorn keep alive to 5

Description
Some requests of superset in the dashboard UI were failing with the following caddy log:
readfrom tcp <IP_ADDRESS>:60208-><IP_ADDRESS>:8088: write tcp <IP_ADDRESS>:60208-><IP_ADDRESS>:8088: use of closed network connection
Keep in mind that this happening on HTTP 2 with Caddy which is the default tutor configuration. After further research/testing the solution was to increase GUNICORN_KEEPALIVE from 2 to 5, which is an environment variable that the default Superset deployment script supports: https://github.com/apache/superset/blob/26df7b4ad5c6c48bd1cc4a015c80cea56cb4d493/docker/run-server.sh#L30
After this change, all requests are successful to the Superset API.

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Cannot convert dash symbol to float while extracting gpu-usage value from job dictionary

I have tried to use this tool on strand, but it doesn't work in my case. The package was installed from pip the way it is described in docs. In this particular case, I run job without any gpu being used for computations.  I suppose that sometimes gpu-usage could have symbols that cannot be converted to float. See the exception below:
zinchenk in ~ at strand-fe1 via 🅒 hpl-torch took 2.3s …
➜ slurm_job_monitor
Starting
Trial 1 / 10 failed. Retrying in 5 seconds.
Trial 2 / 10 failed. Retrying in 5 seconds.
Trial 3 / 10 failed. Retrying in 5 seconds.
Trial 4 / 10 failed. Retrying in 5 seconds.
Trial 5 / 10 failed. Retrying in 5 seconds.
Trial 6 / 10 failed. Retrying in 5 seconds.
Trial 7 / 10 failed. Retrying in 5 seconds.
Trial 8 / 10 failed. Retrying in 5 seconds.
Trial 9 / 10 failed. Retrying in 5 seconds.
Trial 10 / 10 failed. Retrying in 5 seconds.
Too many failed trials. Exiting.
Traceback (most recent call last):
  File "/gpfs/work/zinchenk/lib/miniconda3/envs/hpl-torch/bin/slurm_job_monitor", line 8, in <module>
    sys.exit(cli_entry())
  File "/gpfs/work/zinchenk/lib/miniconda3/envs/hpl-torch/lib/python3.9/site-packages/slurm_job_resource_monitor/job_monitor.py", line 491, in cli_entry
    raise exc
  File "/gpfs/work/zinchenk/lib/miniconda3/envs/hpl-torch/lib/python3.9/site-packages/slurm_job_resource_monitor/job_monitor.py", line 472, in cli_entry
    main(
  File "/gpfs/work/zinchenk/lib/miniconda3/envs/hpl-torch/lib/python3.9/site-packages/slurm_job_resource_monitor/job_monitor.py", line 437, in main
    all_jobs = dict_to_df(all_jobs)
  File "/gpfs/work/zinchenk/lib/miniconda3/envs/hpl-torch/lib/python3.9/site-packages/slurm_job_resource_monitor/job_monitor.py", line 352, in dict_to_df
    "gpu_usage": float(job_dict[node]["GPU usage"][pid][gpu_id]["sm"]),
ValueError: could not convert string to float: '-'

Could you try again with the new version?

I think this should be solved. If not, feel free to reopen the issue.


Possible to change colorFilters dynamically without reseting animation?

Description
blobColor below is a state variable that contains a color string that changes based on user input. However, everytime it changes, the lottie animation resets. Is there a way to dynamically change the lottie color without reseting the animation?
<LottieView         style={{ width: 300, height: 300, position: 'absolute' }}         source={blobLottie}         colorFilters={[             {               keypath: 'Blob 3',                color: blobColor ? blobColor : "#FF0000",             }           ]}         autoPlay={true}         loop={true}         ref={ref => (_lottieRef.current = ref)}     />

Interesting question. I haven't had the time to look too deep in the code for this particular use case, but I can tell that we are not resetting the view upon colorFilter application. My guess? Could be that React Native is destroying and rebuilding the Lottie view since the props have changed and that is causing it to reset. Can you try making the Lottie view animated (With Reanimated or the Animated API) and animate the change in color and report back? That might circumvent the rerender trigger.


Wrong instructions on messages screen if all teams deleted

Steps to reproduce.

Log in with no teams.
Notice the "Join a team" instructions in the messages screen
Add a new team
Notice the "Message your teammates" instructions on the messages screen.  The "New Message" button is now showing.
Delete your team
Notice the "Message your teammates" instructions and the "New Message" button are still displayed on the messages screen.

Expected behavior.
After deleting all teams, the "Join a team" instructions should return.

@jmargolisvt   I suspect this the same bug as #231