[chttp2] Fix tsan race

Noticed here: https://source.cloud.google.com/results/invocations/779f3614-42bd-44bb-a00d-ab56f9749095/targets/%2F%2Ftest%2Fcore%2Fend2end:h2_full_test@retry_cancel4@poller%3Depoll1@experiment%3Devent_engine_client/log
A race between starting reading and transport close.
Fix: move the closure setting inside the combiner, and check if the transport is closed at that time.

Re-running tests to check failure: https://source.cloud.google.com/results/invocations/ba186d91-31b6-4a49-a71f-a8f12b11840c/targets


GRPC support for GetByIndex

For my use case (in Haskell via Kepler), it would be useful to be able to get the nearest populated key/value for a given search key. This is possible in IAVL with Get returning the index of the next populated key, and then using GetByIndex, but the GRPC layer doesn't have this functionality. The Get method returns an error when the requested key is not found, and there is no GetByIndex method.
I think this could be relatively easily addressed by changing the behavior of the GRPC Get method to better match that of ImmutableTree.Get, and by adding a GRPC GetByIndex method which just directly maps to ImmutableTree.GetByIndex.

This sounds reasonable to me, feel like submitting a PR?

This sounds reasonable to me, feel like submitting a PR?

:+1: #355

:+1: #355

Closed with merge of #355


Add yaml for Kube Deployment

Part of https://github.ibm.com/CODAIT/Usability-Enhancement/issues/2

tested locally

also note that the json output is very unreadable in the swagger UI (a large amount of lines). Not sure if there's a way to address this.

Opened #3 to address the above issue


feat(tekton): tekton pipeline run list page

Tracks: https://github.com/janus-idp/backstage-plugins/issues/182
Screenshots:

TODO:

[x]  Add specs

The empty state should show "No PipelineRuns found"

I don't see the pointer cursor when hovered over the task status bar

The pipeline run status shows the reason, you might want to use the pipelineRunStatus util to show the proper status here

Nit: The Timestamp field's font size and color looks different from other fields.

Nit: The Timestamp field's font size and color looks different from other fields.

Have updated this

LGTM!

LGTM!

Task status is not updating
backstage

console

Also, the status column values have the status icon along with the text, and can we also show the PLR resource badge ?

verified it locally
https://user-images.githubusercontent.com/22490998/232119994-e1e2cc82-0a38-4128-829b-959951bd7a4d.mov
LGTM !


Some types of media file is saved as a 0 byte file.

My own Surface Pro 4 running windows 10

Run npm run doctor or wechaty run doctor(for docker user), paste output here

<EMAIL_ADDRESS>doctor C:\dev\wechaty
npm run check-node-version && ts-node bin/doctor

<EMAIL_ADDRESS>check-node-version C:\dev\wechaty
check-node-version --node ">= 6.9"

node: 6.10.2
npm: 4.6.1
yarn: 0.23.4
Wechaty Doctor

Wechaty version: 0.8.12
Windows_NT x64 version 10.0.15063 memory 8851/16310 MB
Docker: false
Node version: v6.10.2
Tcp IPC TEST: PASS
Chromedriver: Error: spawnSync chromedriver ENOENT

Expected behavior
I use wechat sending some files to the bot. I want my bot can save them on my hard disk.
Actual behavior
IMAGES and VOICES can be saved as a correct file that can open with other applications. But VIDEOS , MicroVIDEOS and other format files such as *.doc or *.pdf will be saved as a 0 byte file. Only a filename. Nothing in it.
All the code is simple and same: saveMediaFile(m)
Steps to reproduce the behavior (and fixes, if any)

Send a file to the bot. Maybe you should use wechat webapp of wechat Android APP.
Check the file saved on the hard disk.

Paste the full output logs here with WECHATY_LOG=silly set
Sorry I do not know how to  WECHATY_LOG=silly . I just use node .\dist\mybot.js to run my bot.

It's strange that your chromedriver can not be found by doctor: (perhaps there's bug under win32)

Chromedriver: Error: spawnSync chromedriver ENOENT

Get the debug output by run:

$ node_modules\.bin\cross-env WECHATY_LOG=silly node .\dist\mybot.js

I have installed a Chrome on my system.
IMAGE local filename: files/3729739627497591386.mp4
09:25:18 SILL MediaMessage ready()
09:25:18 SILL Message ready()
09:25:18 SILL Contact ready()
09:25:18 SILL Contact ready()
09:25:18 VERB PuppetWebBridge getMsgVideo(3729739627497591386)
09:25:18 VERB PuppetWebBridge proxyWechaty(getMsgVideo,<PHONE_NUMBER>497591386)
09:25:18 SILL PuppetWebBridge execute()
09:25:18 SILL PuppetWebBrowser Browser.execute("return typeof WechatyBro === "undefined"")
09:25:18 SILL StateSwitch Browser:target() - open
09:25:18 SILL StateSwitch Browser:current() - open
09:25:18 SILL PuppetWebBridge execute()
09:25:18 SILL PuppetWebBrowser Browser.execute(" const callback = arguments[arguments.length - 1] const isAsync = (typeof  ... ")
09:25:18 SILL StateSwitch Browser:target() - open
09:25:18 SILL StateSwitch Browser:current() - open
09:25:18 VERB PuppetWebBrowserCookie read()
09:25:18 SILL PuppetWebBrowserCookie read() webwx_auth_ticket,pgv_si,pgv_pvi,webwxuvid,last_wxuin,login_frequency,MM_WX_NOTIFY_STATE,MM_WX_SOUND_STATE,mm_lang,last_wxuin,login_frequency,wxloadtime,wxplugink
ey,wxuin,wxsid,webwx_data_ticket
09:25:27 SILL PuppetWebEvent onServerDing(heartbeat@browser)
09:25:27 SILL PuppetWebWatchdog onFeed: 60000, HEARTBEAT[heartbeat@browser]
09:25:27 SILL StateSwitch Puppet:target() - live
09:25:27 SILL StateSwitch Puppet:inprocess() false
09:25:27 SILL PuppetWebWatchdog clearWatchDogTimer() [46] seconds left
09:25:27 SILL PuppetWebWatchdog setWatchDogTimer(60000, HEARTBEAT:[heartbeat@browser])
09:25:27 SILL PuppetWebWatchdog monitorScan(HEARTBEAT)
09:25:27 SILL PuppetWebWatchdog autoSaveSession()
09:25:27 SILL PuppetWebWatchdog memoryCheck() free: 11540 MB, require: 4 MB
09:25:42 SILL PuppetWebEvent onServerDing(heartbeat@browser)
09:25:42 SILL PuppetWebWatchdog onFeed: 60000, HEARTBEAT[heartbeat@browser]
09:25:42 SILL StateSwitch Puppet:target() - live
09:25:42 SILL StateSwitch Puppet:inprocess() false
09:25:42 SILL PuppetWebWatchdog clearWatchDogTimer() [46] seconds left
09:25:42 SILL PuppetWebWatchdog setWatchDogTimer(60000, HEARTBEAT:[heartbeat@browser])
09:25:42 SILL PuppetWebWatchdog monitorScan(HEARTBEAT)
09:25:42 SILL PuppetWebWatchdog autoSaveSession()
09:25:42 SILL PuppetWebWatchdog memoryCheck() free: 11365 MB, require: 4 MB

Atfer I deployed wechaty on my centos, the problem is all the same : the saved mp4 file size is 0, while the mp3 file and jpg file are ok.

I have the same problem

@ChenJavascript Could you confirm there's always ok with your first login, and there's always fail after your second login?

@zixia I've tried many times.
I'm sure the second logon always fails,and save the 0kb after uploading the picture for second times.

I have same problem. Android videos/microcode all downloaded as 0 bytes. While iPhone iPod videos are ok.

Could you provide the details about the issue, for example:

which kind of the MsgType is the video that can not be downloaded? and
which kind of the MsgType is the video that will be download without the problem?

We need more information in details If we want this problem to be solved, thanks.

I think this problem is related to insane  censorship and bot-detection.
I solved the problem by moving server outside asia.

Great to hear that!
Could you please close this issue now?


dotnet new  console is not working

We have written the needed data into your c
Issue Type: Bug
I have installed .net and when I type "dotnet new console" at the terminal .net is not recognized even when I try to run my program nothig happen. I have done every thing step by step like in the Brackeys toturial. How can I fix this? Im in windows 10   64-bit.
VS Code version: Code 1.68.1 (30d9c6cd9483b2cc586687151bcbcd635f373630, 2022-06-14T12:48:58.283Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6100T CPU @ 3.20GHz (4 x 3192)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.86GB (0.56GB free)

Process Argv
--crash-reporter-id 34d44de8-1004-442b-b5ce-6c821317ee72

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

csharp
ms-
1.25.0

vscode-icons
vsc
11.12.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
vscscmwlcmt:30465135
cppdebug:30492333
vsclangdf:30486550
841h4636:30513380

lipboard because it was too large to send. Please paste.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.
Happy Coding!


Fix failing CLI params/config

Description of the bug
Need to update the params to reflect the correct CLI options/parameters and not the nf-core boilerplate defaults.
Command used and terminal output
No response
Relevant files
No response
System information
No response

Current working command with complete params:
nextflow main.nf --input /scicomp/home-pure/rtq0/Bio/hackathon/tautyping-nf/assets/samplesheet.csv --outdir /scicomp/home-pure/rtq0/Bio/hackathon/tmp --genome GRCh37 -profile conda --kraken2_db /scicomp/home-pure/rtq0/Bio/hackathon/tautyping-nf/assets/kraken --augustus_species galdieria --fasta


refactor(kafka-sink): change sequential await to group await when committing

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Change sequential await to group await when committing via coordinator.
The semantic is the same but more efficient, since whenever an error during delivery (the await on FutureRecord) happens, we'll rollback to the last checkpoint.
The current implementation simply appends event_key and event_value to the future_record_buffer, and try delivering (await) them all together when committing.
There is no intermediate state, and we can know immediately if the delivery succeeds or not when performing group commit.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

cc @wenym1  I've updated the version, and now the future_delivery_buffer stores DeliveryFuture instead of plain unsent data.
One thing to note is that now the max_limit is hard-coded to 10, b/c I examined SinkParam and somehow found it hard to add a new parameter from outside. Thus, this part may need future guidance.

cc @wenym1 @Little-Wallace.
New version updated.

Change Vec to VecDeque for better future handling in send_result.
Use try_join_all for KafkaSinkWriter::commit_inner and add meaningful comments.
Remove unnecessary logic and refactor some cases in send_result and only await front future in the current buffer queue when the buffer size exceeds the preset limit.

New version updated, I'm ready to merge if the overall picture looks good 🥳
cc @wenym1.

Strange error when building by buildkite. It's okay when building locally. Has the madism been changed 🤔?

Strange error when building by buildkite. It's okay when building locally with the latest version from main branch.
Has the madsim been changed 🤔?

Maybe the latest madsim use a different type to the official rdkafka. Actually we don't have to rewrite the whole result type. We only need to refer to the output type of the future. After changing the signature of may_future_result, it can compile in both cases.
fn map_future_result(
    delivery_future_result: <DeliveryFuture as Future>::Output,
) -> KafkaResult<()> {

Strange error when building by buildkite. It's okay when building locally with the latest version from main branch.
Has the madsim been changed 🤔?

@wangrunji0408 PTAL

Strange error when building by buildkite. It's okay when building locally with the latest version from main branch.
Has the madsim been changed 🤔?

Maybe the latest madsim use a different type to the official rdkafka. Actually we don't have to rewrite the whole result type. We only need to refer to the output type of the future. After changing the signature of may_future_result, it can compile in both cases.
fn map_future_result(
    delivery_future_result: <DeliveryFuture as Future>::Output,
) -> KafkaResult<()> {

Yes, I misused the tokio channel in madsim-rdkafka, which should be a futures channel. I'll fix that in the next version. The workaround mentioned above should also work.

cc @wenym1, I'm ready to merge if the current implementation looks good.

https://github.com/confluentinc/librdkafka/blob/49f180a36c247100dc246379ace84833b91f4038/CONFIGURATION.md?plain=1#L149
Based on the rdkafka documentation, the configs that can affect production batching is:

batch.num.messages. default = 10k
batch.size. default = 1MB
linger.ms. default = 5ms

This means producer will send a batch of producer records when one of the following condition is met:

There are 10k messages enqueued to send for a partition via producer.send
There are 1MB messages enqueued to send for a partition via producer.send
A message has been enqueued for more than 5ms before 1 and 2 are met via producer.send .

After an offline discussion with @wenym1, we think it is better to increase the max queue size introduced in this PR to 65536 to achieve better kafka producer batching.


Don’t emit file references that are already referenced via imports

Fixes:

Just an extra note that TS is adding:
/// <reference path="../../module/module.d.ts" />

even though there also exists a related type import, importing from the same file:
import type { ModuleOptions } from '../../module/module';

So in that case at least the reference looks redundant.

from https://github.com/microsoft/TypeScript/issues/56571#issuecomment-1830869896

@typescript-bot perf test this


Fix high cpu usage / hang when browser tab not active

When left inactive for a long period, a browser tab with running -web seems to hang.
Try:

deactivate queries when browser tab not active/visible
deactivate loops/watchers when browser tab not active/visible
(as a last resort) destruct component when tab is deactivated

It would be good practice to disable as much activity as possible when -web is not visible, so start by disabling graphql queries.

This can be done with two levels of granularity: intersection or visibility:
https://github.com/Akryum/vue-observe-visibility
https://developer.mozilla.org/en-US/docs/Web/API/Page_Visibility_API

Note from visibility api:

Tabs running code that's using real-time network connections (WebSockets and WebRTC) go unthrottled in order to avoid closing these connections timing out and getting unexpectedly closed.

Page visibility API is better supported at this time and simpler, even if less granular.  Probably a better fit for requirements.  Vue wrapper:
https://github.com/Yuliang-Lee/vue-visibility-change

Use visibility to disable all graphql queries when app not visible works very well, as it turns off all the event reactivity when not needed.
Also need to turn off deadapi detection when not visible.

Working well, closing for now, will revisit if further problems.


Replication Snapshot and compact

Codecov Report
Attention: Patch coverage is 10.28708% with 375 lines in your changes are missing coverage. Please review.

Project coverage is 57.69%. Comparing base (2c500c5) to head (a64d938).
 Consider uploading reports for the commit cfeb2fb to get more accurate results

Files
Patch %
Lines

src/lib/replication/repl_dev/raft_repl_dev.cpp
0.00%
224 Missing :warning:

...rc/lib/replication/repl_dev/raft_state_machine.cpp
0.00%
53 Missing :warning:

src/lib/replication/service/raft_repl_service.cpp
0.00%
38 Missing :warning:

.../lib/replication/log_store/home_raft_log_store.cpp
0.00%
24 Missing :warning:

src/lib/common/resource_mgr.cpp
62.85%
10 Missing and 3 partials :warning:

src/lib/replication/log_store/repl_log_store.cpp
0.00%
9 Missing :warning:

src/lib/replication/repl_dev/solo_repl_dev.cpp
0.00%
3 Missing :warning:

src/lib/replication/repl_dev/solo_repl_dev.h
0.00%
3 Missing :warning:

src/include/homestore/replication/repl_dev.h
0.00%
2 Missing :warning:

src/lib/replication/repl_dev/common.cpp
0.00%
2 Missing :warning:

... and 3 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   61.26%   57.69%   -3.58%
==========================================
  Files         135      107      -28
  Lines       14361     9551    -4810
  Branches     1727     1231     -496
==========================================
- Hits         8798     5510    -3288
+ Misses       4834     3505    -1329
+ Partials      729      536     -193

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Suggestion or bug report

Closes #50, #49 and #58
There is a weird bug when using fetch, but the reports is receveid.
Maybe its a best decision change the controlled fields values to an actual html form

What kind of bug?

What kind of bug?

CORS relative, Can not fetch the resource.
But the forms are sent. I suppose we are not using an official way to do it, so it's normal.

CORS relative, Can not fetch the network resource. But the forms are sent. I suppose we are not using an official way to do it, so it's normal.
You should test if this behavior is constant between firefox, chome and safari. Because it seems a bit weird that CORS blocks the request and it's being sent anyways.

If this applies to all platforms, I can live with it until we get our own solution for thins :thinking:

Good job! I tested both in firefox and in chromium and it seems to be working in both. Just a minor nitpick, I think the gap between the label and input looks a little bit small.

It's the same space as the home page between title and box. I decided no to change because of inconsistent

Good job! I tested both in firefox and in chromium and it seems to be working in both. Just a minor nitpick, I think the gap between the label and input looks a little bit small.

It's the same space as the home page between title and box. I decided no to change because of inconsistent

Alright, then I feel this can be safely merged.


Fix emission price reporting

Please confirm that this PR has done the following:

[x] Tests Added (by writing a tutorial)
[x] Documentation Added
[x] Description in RELEASE_NOTES.md Added

Description
This PR fixes an error in the computation of the auxiliary variable PRICE_EMISSION for cumulative emission constraints.

closed and reopened to run tests after merging #100

rebased after merging #100

seems to work now!


use wemake-python-styleguide

wemake-python-styleguide — wemake-python-styleguide 0.17.0 documentation

It is easy to maintain flake8 plugins with wemake-python-styleguide, which installs flake8 plugins and gives additional checks.
Problem:
wemake-python-styleguide requires flake8 5.0 instead of 6.0.
Some plugins required by wemake-python-styleguide require it.
On the other hand, pyproject-flake8 or flake8-pyproject, which can use options in pyproject.toml requires 6.0.
Once wemake-python-styleguide is updated to use 6.0,
replace all flake8 plugins to wemake-python-styleguide.

now pre-commit is managed by rcmdnk/pyproject-pre-commit: pre-commit settings for python project with pyproject.toml


Question: How to define conditionally required field

Please provide sample code to define the following (very basic) rules in Orchestra:

field 1 is required if and only if field 2 exists
field 1 and field 2 are mutually exclusive (either 1 or 2 is required, but not both).
Same as above 2 questions, but replace fields with component

Also nice to understand:

field 1 is required if field 2 exists
field 1 is required if field 2 is equal to "some text"
field 1 is required if field 2 and 3 exists
field 1 is required if field 2 exists and field 3 = "some text"

Many thanks

Sorry, is it possible you submitted this issue on the wrong repo? I do not understand the question and what it has to do with this repo.
Please close the issue if so.

I'm closing this now.


Removed TIM Support

Problem
Although the PPM currently supports processing TIMs, this isn't part of the data flow to RSUs and the SDX. Filtered TIMs are stored in a topic for potential future use. The only relevant filtering for TIMs is geofence-based. Additionally, there is no personally identifiable information to redact in TIMs. Therefore, support for processing TIMs should be removed.
Solution
All references to TIMs have been removed from the project.
Testing

The do_kafka_test.sh script has been verified to work with these changes.
The unit tests pass.
The program spins up correctly.

Dependent PR
The refactoring/remove-tim-references branch was created using docs/supported-message-types as a base, the PR for which should be merged first: https://github.com/CDOT-CV/jpo-cvdp/pull/44

I am having issues with the do_kafka_test.sh test script. Here is the output of the script:

I'm not running into that error on my machine. That's interesting.

These changes look good to me and unit tests pass! There is one lingering TIM reference in standalone.sh on line 6 but that was the only reference I could find.

Removed!


dep(derive): bumped syn to 2.0

Updated syn from 1.0 to 2.0.
Essentially only the attribute parsing was affected. I checked (hopefully) all cases of invalid user input to make sure the errors stay the same or are still appropriate.
The serde module was updated by copying from the serde repository again.
There was one TODO in the code regarding archive(repr(...)) which I kept in.

LGTM, sorry CI broke on this PR


removed warnings with 'unnecessary namespace' hints

As I explained in this issue, dva's warnings regarding action types with namespace are distracting and unnecessary to many devs.
While developing my console is overrun with hundreds of warnings after a few minutes!
I believe dva should not limit the developers' choices regarding action naming conventions.

Coverage decreased (-0.07%) to 95.045% when pulling 3d0d9d4146d8103727a29ed92874e81485597b55 on orzarchi:master into 4e76edd43628fa88654e6d7ee4a6f747c00f4c78 on dvajs:master.

Recommend using https://www.npmjs.com/package/babel-plugin-dev-expression to strip invariant and warning for production.


Forward slashes are ignored when specifying string pattern

🐛 Bug Report
It seems that in attempts to auto escape the regex for json compatibility the library strips out (or ignores) escaped /
To Reproduce
Steps to reproduce the behavior:
import S from 'fluent-json-schema';

const cronlike = S.string().pattern(
  /^((((\d+,)+\d+|(\d+(\/|-)\d+)|\d+|\*)\s?){5,6})$/,
);
console.log(cronlike.valueOf());

const cronlikeRegex = RegExp(
  /^((((\d+,)+\d+|(\d+(\/|-)\d+)|\d+|\*)\s?){5,6})$/,
);
console.log(cronlikeRegex);

Expected behavior
Forward slashes should also be escaped.
{
  '$schema': 'http://json-schema.org/draft-07/schema#',
  type: 'string',
  pattern: '^((((\\d+,)+\\d+|(\\d+(\\|-)\\d+)|\\d+|\\*)\\s?){5,6})$/'
}
/^((((\d+,)+\d+|(\d+(\/|-)\d+)|\d+|\*)\s?){5,6})$/

Your Environment

node version: v14.16.1
fluent-json-schema: 2.0.4
os: Mac

Thank you @svile to report this.
Would you like to open a PR to fix it?
You can add the test case here: https://github.com/fastify/fluent-json-schema/blob/master/src/StringSchema.test.js#L97

Actually, looks like I'll have some spare time today, so I'll take it.

I think the current behavior is correct. We should remove the starting forward slash and the ending forward slash when you are using pattern.
IETF Reference
JSON Schema


Is there a way to add the add reaction, remove, and then add reaction to bypass the snipe timer with the "new" bot?

                    await asyncio.sleep(1)
                    if message.reactions != [] and not message.reactions[0].custom_emoji:
                        emoji = message.reactions[0].emoji
                    await message.add_reaction(emoji)
                    await asyncio.sleep(1)
                    await message.remove_reaction(emoji,self.user)
                    await asyncio.sleep(claim_delay)
                    await message.add_reaction(emoji)

I had added that in the old version of the bot to get the bypass to toggle snipe, how would I do something like it now?

That is an python indent error find and fix the correct spacing

Yeah um, I've been trying for a while and just seem can't see it.

Why is time.sleep not indented ?

Why is time.sleep not indented ?

Oh wow. That's right, I thought I had to leave all the time.sleep in the same "indent" (don't know the actual term)

Why is time.sleep not indented ?

Oh wow. That's right, I thought I had to leave all the time.sleep in the same "indent" (don't know the actual term)

But It isn't claiming anymore now.

I only translated  the section of code you shown me
It will only claim if their is a reaction and is not a custom emoji because of the if statement

I only translated the section of code you shown me It will only claim if their is a reaction and is not a custom emoji because of the if statement

Yeah but at least before, even if I did "$im" it added a heart emoji.

Because there was an “else:” that allowed that logic to happen the code that there right now only has a if there is a reaction logic case

Because there was an “else:” that allowed that logic to happen the code that there right now only reacts if there is a reaction logic case

I don't know where it was then

If anything, can I do that again in this code? How?

in the legacy one "emoji" was set by the "if" statement
the new one the "if" does a similar check but instead adds the correct emoji while also running the add_reaction code so it can be added with a "elif" that allows messages without a reaction to also be reacted to

the "if" does a similar check but instead adds the correct emoji while also running

How could I add an elif so that I can check if it's working? I could maybe have one with elif to see if it is working and then just run the other one.

you could also add an else which doesnt require you to set up a check to add the reaction

you could also add an else which doesnt require you to set up a check to add the reaction

What do you mean?

so ur current changes only allow
message with reactions in messages to be reacted to
if "reactions" in bot.getMessage(channelid, messageid).json()[0] and bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]['id'] == None:
if you add an "else" statement then it will allow things that don't already have reactions added by mudae to be reacted to

so ur current changes only allow
message with reactions in messages to be reacted to
if "reactions" in bot.getMessage(channelid, messageid).json()[0] and bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]['id'] == None:
if you add an "else" statement then it will allow things that don't already have reactions added by mudae to be reacted to

Sure, how doul I do that? Or basically I would just like to have a way of knowing if the bot is working.

time.sleep(1)
if "reactions" in bot.getMessage(channelid, messageid).json()[0] and bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]['id'] == None:
bot.addReaction(channelid, messageid, bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]["name"])
time.sleep(1)
bot.removeReaction(channelid,messageid,bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]["name"])
time.sleep(1)
bot.addReaction(channelid, messageid, bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]["name"])
else:
same code as above minus if

time.sleep(1)
if "reactions" in bot.getMessage(channelid, messageid).json()[0] and bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]['id'] == None:
bot.addReaction(channelid, messageid, bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]["name"])
time.sleep(1)
bot.removeReaction(channelid,messageid,bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]["name"])
time.sleep(1)
bot.addReaction(channelid, messageid, bot.getMessage(channelid, messageid).json()[0]["reactions"][0]["emoji"]["name"])

Where would I add that?
it would be a way of checking if bot is working with "$im" right?

I did this but it doesn't try to claim "$im"

doesnt return a reaction because there is no reaction to return in the else case so change it to a reaction

reaction because there is no reaction to return in the else case so change it to a reaction

Where should I put the "❤"?

Like this ?

 , ❤ )

 , ❤ )

yeah i figured it by looking at the other sections, my bad.

its okay. glad I could help

its okay. glad I could help

Then this should be good and should also add reaction on things like "$im"?

No

No

Huh? so I add it in replacement of where it says "reactions"?

just this remove json to end

just this remove json to end

I did that

But now I'm getting this error:

)

)

? What does that mean?

)

What do you mean by that?

I did this and there were no errors but no reaction to "$im"

bot.addReaction(channelid,messageid, ❤ )

bot.addReaction(channelid,messageid, ❤ )

yeah but when i have it like that I get the syntax error

show code and the error

Code

Error

that error is because you didnt close your ( ) and that why u have and syntax error

that error is because you didnt close your ( ) and that why u have and syntax error

Exactly, that's why I added the ")" at the end, but even with that it wasn't reacting to "$im".
I didn't get that you meant that I had to remove the other ( ) as a whole. It's now working, thank you for your support and for being tolerant


whitelist preview url for cors

Add preview url that we're going to use for beta testing to the list of whitelisted urls so that CORS will work

After carefully reading every character, I have determined that this PR is good to go 💯


Driver error with ArcGIS datasource

With and without the import refactor flag, trying to upload an ArcGIS layer:
2015-06-17 09:59:32 UTC: Running on server que04.useb.cartodb.net with PID: 7355
2015-06-17 09:59:32 UTC: new_importer()
2015-06-17 09:59:32 UTC: Fetching datasource public_url metadata for item id ** URL **
2015-06-17 09:59:33 UTC: File will be downloaded from ** URL **
2015-06-17 09:59:33 UTC: Before importer run
2015-06-17 09:59:33 UTC: Starting import for /tmp/imports/20150617-7355-1kher6v/MapServer
2015-06-17 09:59:33 UTC: Unpacking /tmp/imports/20150617-7355-1kher6v/MapServer
2015-06-17 09:59:33 UTC: Filename: /tmp/imports/20150617-7355-sktxyv/mapserver Size (bytes): 7329
2015-06-17 09:59:33 UTC: Importing data from /tmp/imports/20150617-7355-sktxyv/mapserver
2015-06-17 09:59:33 UTC: File-based import load
2015-06-17 09:59:33 UTC: Detected encoding UTF-8
2015-06-17 09:59:33 UTC: Using database connection with {:adapter=>"postgres", :encoding=>"unicode", :host=>"<IP_ADDRESS>", :database=>"cartodb_user_fcac3f1d-3190-4f43-ab07-0038a81ec2fb_db", :username=>"postgres", :port=>5432, :connect_timeout=>2.5, :user=>"cartodb_user_fcac3f1d-3190-4f43-ab07-0038a81ec2fb"}
2015-06-17 09:59:33 UTC: ogr2ogr call:      OSM_USE_CUSTOM_INDEXING=NO PG_USE_COPY=YES PGCLIENTENCODING=UTF-8  /usr/bin/ogr2ogr -f PostgreSQL  PG:"host=<IP_ADDRESS> port=5432 user=cartodb_user_fcac3f1d-3190-4f43-ab07-0038a81ec2fb dbname=cartodb_user_fcac3f1d-3190-4f43-ab07-0038a81ec2fb_db password=4e6379115bdea0a19aebe90f6e5b8676c51a2296cartodb_user_fcac3f1d-3190-4f43-ab07-0038a81ec2fb" -t_srs EPSG:4326  -lco DIM=2 -lco PRECISION=NO /tmp/imports/20150617-7355-sktxyv/mapserver  -nln cdb_importer.importer_8d942bc614d711e5833d0e6e1df11cbf -nlt PROMOTE_TO_MULTI
2015-06-17 09:59:33 UTC: ogr2ogr output:    FAILURE:
Unable to open datasource `/tmp/imports/20150617-7355-sktxyv/mapserver' with the following drivers.

The URL(s) I'm using can be found at the data import 187ce4d4-4cf8-4b31-8909-8a6a0bdcbf1e.
I'm using the general URL as well as /0, /1... to try to access to the different layers. All options give me the same results.
cc @juanignaciosl
@Kartones

5664048

There are two things here:

When it works, the url contains probably an arcgis online, because the import fails with a missing fields (metadata) error, so cannot be imported.

From the editor view -> add layer everything works fine, so the issue is only from the dashboard, via the new dataset menu.

So... on to the error
Description
Upon importing an arcgis url (layer or full "map"), importer is taking it as if it were a public_url type of import, because the frontend is not sending datasource_name (= arcgis) and service_item_id (= the url we want to import), so the usual public url flow gets called and it fails.
How to reproduce
Just do an arcgis import with Chrome dev tools open. Check that the POST to import API is only carrying basic info:
content_guessing: true
create_vis: false
interval: 0
type_guessing: true
url: "xxx"

and missing datasource/connector specific fields mentioned above.
Expected result
Arcgis Import runs ok (if server is valid)
Actual result
It always fails and if you check import log it shows it is being downloaded as a public url:
2015-07-13 09:11:19 UTC: Fetching datasource public_url metadata for item id xxxxxx
2015-07-13 09:11:19 UTC: File will be downloaded from [...]

Notes

It actually gets more fun as the supplied url fails, so to reproduce locally, best option is to place a debugger at ruby code, at file services/datasources/lib/datasources/url/arcgis.rb, method def sanitize_id. Running locally if the debugger is hit it went through the correct flow, if editor shows the error it went through public url flow.
At staging or live is easier because just entering your username -> imports you can see the log and see which path it chose.

To test a successful import enqueing, use curl from a command line:

curl -v -H "Content-Type: application/json" -d '{"service_item_id": "ARCGIS_URL", "service_name": "arcgis"}' "http://YOUR_USERNAME.localhost.lan:3000/api/v1/imports?api_key=YOUR_API_KEY"

New dataset modal might also not replicate old behaviour of only allowing sync if user specifies a layer (trailing /0, /1, etc), but not if introduces a map (ends in a string, like /mymountains/MapServer)


BUG: Fix range-based setters in EchoVolumeRender interface

Resolves issue where depthRange and depthColoringRange properties in EchoVolumeRender public interface were not properly propagated to underlying shader.
Range values are currently set internally without referencing the public interface: https://github.com/SlicerHeart/SlicerHeart/blob/master/EchoVolumeRender/EchoVolumeRender.py#L57

cc @lassoan @jcfr

@lassoan @jcfr Ping for review

Thank you!


Create dev and prod environments

I have looked a bit into dev and prod environments variables, the prod is the official link one and the dev are ones that vercel users will be able to pull the environment variables to the local test folder. So I think to achieve the dev/test environment, the best approach would whitelist the "dev" branch you have created, so all the deployed versions of that branch would have access to all environments variables


ButtonGroup checkForOverflow causes component flickering

🐛 Bug Report
When using AlertDialog + ButtonGroup component, buttons within ButtonGroup are flickering (altering between horizontal and vertical orientation) when getting limited on space.
🤔 Expected Behavior
Buttons within ButtonGroup should be in either horizontal or vertical orientation -- when limited on space it switches to vertical orientation.
😯 Current Behavior
There is some window of browser dimension that it temporarily stops, but then resumes:
💁 Possible Solution
Investigate resize observer / overflow check in ButtonGroup: https://github.com/adobe/react-spectrum/blob/8c9d3bdc279568e76e406adc924607c04d796009/packages/%40react-spectrum/buttongroup/src/ButtonGroup.tsx#L43C1-L84
🔦 Context
Component is currently being used in unified checkout when a user chooses to switch countries when entering credit card payment information
💻 Code Sample
🌍 Your Environment

Software
Version(s)

react-spectrum

Browser

Operating System

🧢 Your Company/Team
Adobe Commerce
🕷 Tracking Issue (optional)

I noticed this happens in React 16 and 17, but not 18, so that may be indicative of something (i.e. automatic batching). Looks similar to some issues we had with a TagGroup container resizing. Maybe introducing flushSync could be a potential fix, but I forget if there were side effects with that.
https://github.com/adobe/react-spectrum/blob/8c9d3bdc279568e76e406adc924607c04d796009/packages/%40react-spectrum/buttongroup/src/ButtonGroup.tsx#L43-L84

I tried reproducing in sandbox, but was unable to recreate it -- which seems expected since the sandbox is in React 18

This issue can be replicated on the RSP docs website https://react-spectrum.adobe.com/react-spectrum/ButtonGroup.html. Use 150% zoom and resize the page until it occurs.
https://github.com/adobe/react-spectrum/assets/142634044/72b5fb22-591e-4245-8081-5874025cc95a


percona 5.7 is started using systemd

Seems like after installing percona 5.7 we miss a
RUN systemctl disable mysql

Otherwise the mysqld server is started using systemd all the time, not using the entrypoint

I'm not sure I'm understanding the issue entirely, can you elaborate on how you're starting the container and what's happening?
We don't run systemd in the image, so it shouldn't ever be launching anything, but besides that, our base image has policy-rc.d in place (https://github.com/docker/docker/blob/cccfe63e86f3842a2139d8b9c24bfab5be7639b8/contrib/mkimage/debootstrap#L38-L49), which is designed to prevent service startup in appropriately-behaved packages.

@tianon i think it was rather my fault and a wrong assumption on my side. I had a doubled mysqld process running, one "mysqld" and one "mysqld --no-networking".
My assumption was, that systemd started one of those, since running systemd status on mysqld ruturend "enabled". But it turned out to be not the reason.
The reason was, i used a docker-entrypoint.d/ script to populate the random-generate mysql password into consul, used exit 0 there. This, the way those script are exectured, actually exited the docker-entrypoint.sh instead of the "help script in .d" and that left over the mysql --no-networking process during docker-entrypoint.sh startup.
From my perspective, this issue can be closed

i guess i shall close this

Ah, thanks for explaining! :+1: (and glad you got it figured out)


Removing provisioner's dependency on csi types

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build 876429462

69 of 102 (67.65%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 36.933%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/azuredisk/fake_azuredisk_v2.go
4
11
36.36%

pkg/azuredisk/controllerserver_v2.go
65
91
71.43%

Totals

Change from base Build 875862923:
0.8%

Covered Lines:
1156

Relevant Lines:
3130

💛  - Coveralls

The e2e test appear to fail in AfterSuite due to an error unrelated to your changes. I noticed this last night in my PRs. It appears to be related to kubernetes-sigs/azuredisk-csi-driver#836 and requires K8s 1.18 or later to run. The azure-cluster-up.sh uses 1.17 by default. I'll update this today.
2021/05/26 14:10:54 ===================install Azure Disk CSI Driver deployment scripts test===================
use local deploy
Installing Azure Disk CSI driver, version: master ...
error: unable to recognize "./deploy/csi-azuredisk-driver.yaml": no matches for kind "CSIDriver" in version "storage.k8s.io/v1"

------------------------------
Failure [219.170 seconds]
[AfterSuite] AfterSuite
/home/runner/work/azuredisk-csi-driver/azuredisk-csi-driver/test/e2e/suite_test.go:124

  Unexpected error:
      <*exec.ExitError | 0xc000660080>: {
          ProcessState: {
              pid: 61739,
              status: 256,
              rusage: {
                  Utime: {Sec: 0, Usec: 316068},
                  Stime: {Sec: 0, Usec: 65236},
                  Maxrss: 120516,
                  Ixrss: 0,
                  Idrss: 0,
                  Isrss: 0,
                  Minflt: 3061,
                  Majflt: 0,
                  Nswap: 0,
                  Inblock: 16,
                  Oublock: 13312,
                  Msgsnd: 0,
                  Msgrcv: 0,
                  Nsignals: 0,
                  Nvcsw: 1922,
                  Nivcsw: 147,
              },
          },
          Stderr: nil,
      }
      exit status 1
  occurred

  /home/runner/work/azuredisk-csi-driver/azuredisk-csi-driver/test/e2e/suite_test.go:252
------------------------------

Failed to create JUnit directory: /workspace/_artifacts/junit_01.xml
	mkdir /workspace: permission deniedFailed to create JUnit report file: /workspace/_artifacts/junit_01.xml
	open /workspace/_artifacts/junit_01.xml: no such file or directory
Failed to generate JUnit report data:
	invalid argument
Ran 54 of 85 Specs in 7641.473 seconds
FAIL! -- 54 Passed | 0 Failed | 0 Pending | 31 Skipped
--- FAIL: TestE2E (7641.49s)
FAIL
FAIL	sigs.k8s.io/azuredisk-csi-driver/test/e2e	7641.541s
FAIL
make: *** [Makefile:344: e2e-test-v2] Error 1
Error: Process completed with exit code 2.


[#45] Fix: Remove all unnecessary app icons from the lib module

Resolves https://github.com/nimblehq/android-common-ktx/issues/45
What happened 👀

Update gitignore.
Remove all unnecessary app icons from the lib module.
Fix: deprecated actions/setup-ruby usage.

Insight 📝
The lib module MUST NOT provide app resources (icons) that can override the resources from the app module.
Proof Of Work 📹

@hoangnguyen92dn It happens on my local, too, but I did not push the fix for it. Let me push it.


[Error] Value cannot be null.

Error:
Value cannot be null.
Parameter name: text   at System.Windows.Documents.InlineCollection.AddText(String text, Boolean returnIndex)
   at BotwTrainer.MainWindow.LogError(Exception ex, String more)
   at BotwTrainer.MainWindow.ConnectClick(Object sender, RoutedEventArgs e)

Yeah sounds like it can't communicate with the Wii via the TCP connection :(

I've been getting this error too, but it seems to happen regardless of connection. Switching between networks didn't help. It's a shame because this had been working flawlessly before.

Yeah. I'm not sure what this is. I'm getting it, too. I wonder if it has anything to do with the resizeability of the window.

It can't read the coordinates from the wii. Its getting back the value of 0 for the pointer location which isn't a legitimate coordinate.

Try clicking the follow pointer button in jgecko u and testing both of these lines
[0x439BF780] + 0x140
[0x439BF794] + 0x140

Also, for those with the null pointer error. Are you certain that you are loading TCPGecko with the CodeHandler option (pressing X to load, NOT pressing A)? I've caught myself doing this once or twice over time as well, lol. This may not be the cause of the issue at all, but it's at least one more possibility we can cross off if that's not the issue.
Hope this helps!

I'm getting the same error and can use the other trainer just fine, so it's something only happening with this trainer :(

Please make sure you are using the files referenced in the readme. Specifically .net version and  the tcpgecko files that bully compiled


About jetty ssh

how disable jetty ssh ?

with this key, I still get: SSL_do_handshake() failed (SSL: error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol) while SSL handshaking to upstream (using nginx reverse proxy).
How do you turn it off? I just want an environment for testing without ssl...


require tcg/voyager problem

Laravel Version: 5.3.#

Description: Problem 1: - İntervention/image 2.3.8 requires ext-fileinfo -> the request PHP extension fileinfo is missing  from your system
İntervention/image 2.3.7...
İntervention/image 2.3.6...
...
..
.
İnstallation failed reverting ./composer.json to its original content.
How I can solve this problem ?
Steps To Reproduce:

You will have to add fileinfo PHP component to your PHP environment.
If your on a Windows machine you can open op your php.ini and locate ;extension=php_fileinfo.dll, then remove the starting ;.
After that save and restart PHP (and Apache if used)

Thanks its done.


Make email parsing more robust

CATEGORY
Choose one

[x] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Makes the email parsing for the dashboard / slice reports more robust.
TEST PLAN
unit tests
REVIEWERS

Codecov Report

Merging #9523 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9523   +/-   ##
=======================================
  Coverage   58.78%   58.78%
=======================================
  Files         390      390
  Lines       12386    12386
  Branches     3073     3073
=======================================
  Hits         7281     7281
  Misses       4921     4921
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29d0fd...f8e3fd5. Read the comment docs.

@villebro  - done


Trusted_email_for_signup

Issue_id: #3316
Note:  Add gssoc-ext with level3 and hacktober-accepted labels!, Please It's a request.
login.js:

Trusted mail services:
gmail.com , outlook.com , hotmail.com , yahoo.com , protonmail.com , icloud.com , tutanota.com
Changes Made:
Email Domain Validation:
Implemented a validation function that checks if the entered email belongs to an allowed domain (Gmail, Outlook, Yahoo).
If the email domain is invalid, an appropriate error message is displayed to the user.
UI Enhancements:
Error messages are now shown in real-time, providing immediate feedback to users on their input.

for that task even level 2 is more @smog-root

I know I'm asking a lot for it!
Even though thanks for adding level2!
@sailaja-adapa

welcome @smog-root


Improve code + Delete Fields tests

Removed code fragments from DG
Fixed initialisation of app with sample meeting data
Improved code quality
Added few tests for DeleteFieldCommand and DeleteFieldCommandParser
#138

Codecov Report

Merging #229 (b9ba0ff) into master (6886d5d) will increase coverage by 3.24%.
The diff coverage is 45.45%.

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
+ Coverage     53.16%   56.40%   +3.24%
- Complexity      656      683      +27
============================================
  Files           118      118
  Lines          2705     2709       +4
  Branches        322      318       -4
============================================
+ Hits           1438     1528      +90
+ Misses         1169     1074      -95
- Partials         98      107       +9

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <0.00%> (ø)

.../java/seedu/address/logic/commands/AddCommand.java
92.30% <ø> (ø)

...edu/address/logic/commands/DeleteFieldCommand.java
91.17% <ø> (+91.17%)
:arrow_up:

src/main/java/seedu/address/model/person/Id.java
80.00% <ø> (+13.33%)
:arrow_up:

.../java/seedu/address/model/util/SampleDataUtil.java
29.03% <ø> (ø)

...du/address/storage/meeting/JsonAdaptedMeeting.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/ResultDisplay.java
0.00% <0.00%> (ø)

...address/logic/parser/DeleteFieldCommandParser.java
63.23% <60.37%> (+63.23%)
:arrow_up:

.../java/seedu/address/storage/JsonAdaptedPerson.java
90.69% <66.66%> (ø)

...edu/address/model/person/EditPersonDescriptor.java
64.77% <100.00%> (+11.89%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6886d5d...b9ba0ff. Read the comment docs.


Line with label is not supported?

doc is here:
https://echarts.apache.org/en/option.html#series-line.label
can not add label for Line:
https://github.com/yuankunzhang/charming/blob/dbf7e05c58f5f6db0dbb0503cfcc665f8d041e34/examples/leptos-demo/src/main.rs#L20

Can we have a new release with this include?

This is published.


fix: remove the need for slabThicknessEnabled

Removes the need for slabThicknessEnabled
Simplifies the API for setSlabThickness
Fix bugs for volumeNewImageEventDispatcher
Fix a bug for Synchronizer that triggered source viewport event when it didn't belong to the synchronizer anymore
Fix RectangleROIStartEndThreshold tool various bugs with the new API

Nice fix. One comment you set the infrastructure in crosshair to set the slabthickness by volumeIDs, but then iin the petCt example you don't use it. You should exclude in the thirs row of viewport the pet volume.
i.e. now the example renders like:

but it should be  (i.e., no slab thickness for the pet):


Comments go away i PR description page when switching to another tab and back

Related: https://github.com/Microsoft/vscode-pull-request-github/issues/313
I just lost a comment, and then did it again immediately after 😢. I think webviews can save and restore state now?

Should be fixed in 0.0.19: https://github.com/Microsoft/vscode-pull-request-github/issues/329

@RMacfarlane could focus and scroll position also be restored?


Open up UDP traffic within AWS clusters (resolves #1818)

This allows real time logging to work.
(resolves #1818)

jenkins, test this please


BrokenPipeError when robot file is called by process library

Script BrokenPipeWorker.robot ...
*** Settings ***
Library    Browser

*** Test Cases ***
TC BrokenPipeWorker
    ${result}    Evaluate    1 * 1
    Log    \nMessage from TC BrokenPipeWorker, result is ${result}.    console=yes

... works fine when it is called on CLI by
robot -d tmp BrokenPipeWorker.robot
Console output:
==============================================================================
BrokenPipeWorker
==============================================================================
TC BrokenPipeWorker                                                   .
Message from TC BrokenPipeWorker, result is 1.
TC BrokenPipeWorker                                                   | PASS |
------------------------------------------------------------------------------
BrokenPipeWorker                                                      | PASS |
1 test, 1 passed, 0 failed
==============================================================================

However when it's called by another script BrokenPipeProcess.robot ...
*** Settings ***
Library    Process

*** Test Cases ***
TC BrokenPipeProcess
    Start Process   robot    -d    tmp    BrokenPipeWorker.robot

... the log of BrokenPipeWorker contains "BrokenPipeError: [Errno 32] Broken pipe".

The message does not occur either

by commenting the Log line in BrokenPipeWorker or
by commenting the line where the Browser lib is imported.

Tested with Browser Lib 12.3.0 but seems not to be solvable there.
I did not get such an issue before RF 5.0

Is this still a problem?


[tests] add traffic analysis for Cert_5_3_07_DuplicateAddress.py

Codecov Report

Merging #2298 into master will increase coverage by 2.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2298      +/-   ##
==========================================
+ Coverage   68.28%   70.37%   +2.09%
==========================================
  Files         197      184      -13
  Lines       24455    21637    -2818
  Branches     2817     2549     -268
==========================================
- Hits        16699    15228    -1471
+ Misses       6759     5492    -1267
+ Partials      997      917      -80

Impacted Files
Coverage Δ

src/core/api/netdata_api.cpp
26.31% <0%> (-52.64%)
:arrow_down:

src/core/api/icmp6_api.cpp
55.55% <0%> (-44.45%)
:arrow_down:

src/core/net/ip6.hpp
62.5% <0%> (-25%)
:arrow_down:

src/core/api/border_router_api.cpp
53.65% <0%> (-24.4%)
:arrow_down:

src/ncp/spinel_decoder.hpp
78.94% <0%> (-21.06%)
:arrow_down:

src/core/api/ip6_api.cpp
43.75% <0%> (-20.32%)
:arrow_down:

src/ncp/spinel_encoder.cpp
58.58% <0%> (-16.87%)
:arrow_down:

examples/platforms/posix/misc.c
0% <0%> (-15.39%)
:arrow_down:

src/core/api/thread_api.cpp
27.74% <0%> (-15.03%)
:arrow_down:

src/core/net/ip6.cpp
49.46% <0%> (-11.45%)
:arrow_down:

... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a30c7...ea27a96. Read the comment docs.

@librasungirl

@hjian2017, please resolve conflicts.


Update [Secrets Stored In Dockerfile] query for Dockerfile

Platform
Dockerfile
Description
False positives for environment variables

@jonny-wg2 thank you for your report. I think this query is doubled, so we will check as soon as possible.


abc buffering doesn't work with techmap cell

The OpenROAD ASIC flows (Openlane and OpenROAD-flow-scripts) use abc buffering to manage fan out (buffer -N X). While looking at some timing issues in https://github.com/The-OpenROAD-Project/OpenLane/issues/870 I noticed that abc buffering seems to ignore techmap -map YY cells. I'm not sure if it's a yosys or abc bug, or if we are driving yosys incorrectly.
Steps to reproduce the issue
The yosys script is:
yosys -import
set liberty_file trimmed.lib
read_liberty -lib $liberty_file
read_verilog -sv Microwatt_FP_DFFRFile.v
synth -top Microwatt_FP_DFFRFile
opt -purge

if { [info exists ::env(DO_TECHMAP)] && $::env(DO_TECHMAP) == 1 } {
    techmap -map mux2_map.v
}

dfflibmap -liberty $liberty_file
opt
abc -D 5000 \
    -liberty trimmed.lib \
    -constr regfile.constr \
    -dff \
    -script "+strash;ifraig;scorr;dc2;dretime;strash;&get,-n;&dch,-f;&nf,{D};&put;buffer,-N,5,-v"
setundef -zero
splitnets
opt_clean -purge
hilomap -singleton -hicell sky130_fd_sc_hd__conb_1 HI -locell sky130_fd_sc_hd__conb_1 LO
insbuf -buf sky130_fd_sc_hd__buf_4 A X
write_verilog -noattr -noexpr -nohex -nodec out.v

And the mu2_map.v is:
module \$_MUX_ (
    output Y,
    input A,
    input B,
    input S
    );
  sky130_fd_sc_hd__mux2_1 _TECHMAP_MUX (
      .X(Y),
      .A0(A),
      .A1(B),
      .S(S)
  );
endmodule

FYI while debugging this issue, I realised that we don't need to manually techmap the muxes at all and I'll remove that from Openlane. The issue remains for other techmap'ed cells.
If we enable manual techmap'ing of muxes then nets on the mux inputs have massive fan outs:
# yosys doit.tcl > /dev/null
# grep '\.' out.v| sort | uniq -c | sort -n|tail -5
      5     .S(_19223_),
      5     .S(_19224_),
      5     .S(_19225_),
      5     .S(_19226_),
   5120     .CLK(CLK),

# DO_TECHMAP=1 yosys doit.tcl > /dev/null
# grep '\.' out.v| sort | uniq -c | sort -n|tail -20
   1280     .S(R3[1]),
   2560     .S(R1[0]),
   2560     .S(R2[0]),
   2560     .S(R3[0]),
   5120     .CLK(CLK),

Complete testcase: abc-buffer-issue.tar.gz

I suspect the custom cells you're mapping cause Yosys to "hide" (turn into network primary inputs/outputs) the cells from ABC.
What you have here with your mapped cell is a "box" - a cell with logic that one can optionally look inside. ABC9 is box-aware, ABC is not. Yosys can't communicate to ABC "there's this logic in the path you should be aware of", so then ABC cannot distinguish between the inputs and outputs to that cell and, say, a wire going to a GPIO. Since the cell doesn't exist to ABC, it cannot buffer it.

@Ravenslofty Thanks. I tried a simple test to confirm:
module mux2(
    input  i0,
    input  i1,
    input  s0,
    output z
);
    assign z = (s0) ? i1 : i0;
endmodule

With a mux2_map.v:
module \$_MUX_ (
    output Y,
    input A,
    input B,
    input S
    );
  sky130_fd_sc_hd__mux2_1 _TECHMAP_MUX (
      .X(Y),
      .A0(A),
      .A1(B),
      .S(S)
  );
endmodule

yosys -import
set liberty_file trimmed.lib
read_liberty -lib $liberty_file
read_verilog -sv mux2.v
synth -top mux2
opt -purge

if { [info exists ::env(DO_TECHMAP)] && $::env(DO_TECHMAP) == 1 } {
    techmap -map mux2_map.v
}

dfflibmap -liberty $liberty_file
opt
abc -liberty trimmed.lib \
    -script "+strash;ifraig;scorr;dc2;dretime;strash;&get,-n;&dch,-f;&nf,{D};&put;buffer,-N,5,-v"

liberty file is from the tarball above. Looking at the input.blif we feed to abc, with the mux2 techmap disabled I see
.model netlist
.inputs ys__n0 ys__n1 ys__n2
.outputs ys__n3
# ys__n0     \i0
# ys__n1     \i1
# ys__n2     \s0
# ys__n3     \z
.names ys__n0 ys__n1 ys__n2 ys__n3
1-0 1
-11 1
.end

And with it disabled, it is completely missing:
.model netlist
.inputs dummy_input

.outputs
.end

Is there anything stopping us from using abc9? It looks it needs an option to pass liberty files to abc, but not sure if there is more work than that.

Answering my own question:
ERROR: ABC9 flow only supported for FPGA synthesis (using '-lut' option)

We've removed the manual mux mapping from Openlane, but this is still going to be an issue for things we have to tech map (eg full/half adders). I presume it is also an issue with modules that explicitly use standard cells. As such it would be good to fix.
@eddiehung Is there anything preventing us getting abc9 to work without LUTs? I have no idea if it is an enormous amount of work or not.

I'll be honest and say I don't know much about the ASIC side of ABC. What I can see is that you are using some abc9 functions in your script (specifically &nf) but you are entering from regular abc (non box aware flow) via BLIF. Having no familiarity with &nf I can't tell you if it is box aware (many &-prefix commands are not necessarily box aware) -- this would be a question for upstream I'm afraid.


boards: nrf54l15dk: Enable tests and samples for the L05 and L10

This is a follow-up to 21475774fc412fed7273408de65ee69bcdd1b84e, extending the number of tests and samples that use the new L05 and L10.
The reason this is marked as Trivial is that the overlays are almost identical to the existing L15 ones, so there really no logic added at all.

@carlescufi please rebase on top of https://github.com/zephyrproject-rtos/zephyr/pull/81465
so that I can run CI on it at HW.

@carlescufi please rebase on top of #81465 so that I can run CI on it at HW.

@nordic-piks done.


The text input doesn't display when creating one service

Storage Explorer Version: 1.27.0-dev
Build Number: 20221102.12
Branch: feature branch
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Monterey 12.6 (Apple M1 Pro)
Architecture: ia32/x64
How Found: From running test cases
Regression From: Previous release (1.26.1)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Right click Blob Containers node -> Click 'Create Blob Container'.
Check whether the text input displays.

Expected Experience
The text input displays.
Actual Experience
The text input doesn't display.

Verified this issue on the build 20221103.5. Fixed. So, we are going to close it.


Close modal on keydown instead of keyup (Escape key)

This is how I would expect it and how majority of apps implement it, also it will not look like it is frozen :)

https://github.com/VodkaBears/Remodal/releases/tag/1.0.2


fix(package.json): updated packages

updated packages

:tada: This PR is included in version 2.0.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixes only update v0.6

Hi! Thank you for helping out with Embedded Graphics development! Please:

[x] Check that you've added passing tests and documentation
[x] Add a simulator example(s) where applicable
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) and appropriate crate (embedded-graphics, simulator, tinytga, tinybmp) if your changes affect the public API
[x] Run rustfmt on the project
[x] Run ./build.sh (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
As suggested in https://github.com/jamwaffles/embedded-graphics/pull/324#issuecomment-614235889, this PR updates the v0.6 branch with some smaller fixes. It doesn't add any new features as attempted in #324 as that turned into a huge mess.
Closes #324

Well spotted. Names fixed in master, commit cherry-picked into this branch. Good for another go round :+1:


feat(gpus): add hotplug support of gpu devices

Signed-off-by: wanyaoqi<EMAIL_ADDRESS>What this PR does / why we need it:

Does this PR need to be backport to the previous release branch?:
NONE

If lspci can't find gpu device in guest linux, try rescan pci:
echo 1 > /sys/bus/pci/rescan


[Event Request] Codeunit 5988 "Serv-Document Mgt." - OnAfterWarrantyLedgerEntryModify

Describe the request
Please add event OnAfterWarrantyLedgerEntryModify in procedure PrepareShiptmentLine
local procedure PrepareShipmentLine(var PassedServLine: Record "Service Line"; passedWarrantyNo: Integer)
var
    WarrantyLedgerEntry: Record "Warranty Ledger Entry";
begin
...
    if Invoice and Ship then begin
          WarrantyLedgerEntry.Reset();
          WarrantyLedgerEntry.SetCurrentKey("Service Order No.", "Posting Date", "Document No.");
          WarrantyLedgerEntry.SetRange("Service Order No.", ServShptLine."Order No.");
          WarrantyLedgerEntry.SetRange("Document No.", ServShptLine."Document No.");
          WarrantyLedgerEntry.SetRange(Type, ServShptLine.Type);
          WarrantyLedgerEntry.SetRange("No.", ServShptLine."No.");
          WarrantyLedgerEntry.SetRange(Open, true);
          WarrantyLedgerEntry.ModifyAll(Open, false);
          OnAfterWarrantyLedgerEntryModify(ServShptLine);
    end;
end;

Event definition:
[IntegrationEvent(false, false)]
local procedure OnAfterWarrantyLedgerEntryModify(ServShptLine: Record "Service Shipment Line")
begin
end;

Additional context
We want to modify after the WarrantyLedgerEntry Table our own Ledger Entry Table
Internal work item: AB#554347

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 25639.


const used in strict mode

In the service worker installation the const keyword is used and is not transpiled before being inserted into the index.html on the build.
In iOS environments this throws an exception and blocks the rest of the script from executing.

This was fixed in https://github.com/vuejs-templates/pwa/pull/94


Add types for openid_connect

OpenID Connect Server & Client Library
refs: https://github.com/nov/openid_connect

/merge


Update DigestUtils.java

Coverage remained the same at 93.84% when pulling a91f812839a5810e58c5d5c65cdff6e351789fd8 on YYTVicky:patch-2 into 126f90424cc8f62d928686ec20c6c8bd944b527b on apache:master.

Hi,
Thank you for your feedback, we just want to highlight that hash algorithm like MD5, MD2 and SHA1 (refer the document here: https://www.securityfocus.com/bid/11849/discuss)have been proved been broken, we recommend you use SHA256 or SHA512 when to invoke Messagedigest.genInstance() function.
Hope to hear any feedback from you!
~

Closing, no further input from OP.


Warning dialog when closing the application.

This is just something been bugging me. If you have multiple tabs open in grabber or a download running, shouldn't it have the option to give you a warn that your about to close the application instead of instantly closing the moment you click on the 'close' button? This would be a nice addition to grabber.

Indeed, there could be a security popup to prevent cancelling downloads or closing multiple tabs.
I'll add it right away.


Update compose examples

I didn't notice the same change in the main branch :D
I had an outdated local main branch.
So closing this.


start a kickstarter

Enough people hate running a full slack client that we'll all throw money at you to make this one better. Seriously.

I appreciate the sentiment, however my intention for this project is not to make a feature complete alternative to the official slack client. It's cool that people want to use slack-term as an alternative, but I started this project because I wanted to send and receive message from the terminal to slack, at the time this is/was also possible using other alternatives: weechat or using similar programs to slack-term. I never set out to make a "better" slack-client.


Annotations: Schema type ignored on class but honoured for fields

Swagger-core version 2.1.1
The type of the schema is always set to 'object, regardless on what it is set to. But if used are a property of another schema, then it is correct.
For example,
The resource:
public class SomeResource{
    @GET
    @Path("variantsX/{variantLabel}")
    @Produces(APPLICATION_JSON)
    @Operation(summary = "Retrieve a single variant X",
            responses = {
                    @ApiResponse(responseCode = "200")
            })
    public Variant getVariantX(
            @PathParam("variantLabel")
            @Parameter(description = "Variant Label")
            final Variant.Label variantLabel) {
        Variant variant = null;
        return variant;
    }
}

Model (note having the label as an inner class or not makes no difference):
Note the 'type' of the schema on the inner class Label
public class VariantX  {
    @Schema(description = "Unique variant label", required = true)
    private VariantX.Label label;

    public Label getLabel() {
        return label;
    }

    @Schema(name = "VariantLabelX", type = "string", example = "variant_1",
            description = "The variant label XX")
    public static class Label implements Serializable {
        private String label;
    }
}

Produces and API spec of:
{
  "openapi" : "3.0.1",
  "paths" : {
    "/variantsX/{variantLabel}" : {
      "get" : {
        "summary" : "Retrieve a single variant X",
        "operationId" : "getVariantX",
        "parameters" : [ {
          "name" : "variantLabel",
          "in" : "path",
          "description" : "Variant Label",
          "required" : true,
          "schema" : {
            "$ref" : "#/components/schemas/VariantLabelX"
          }
        } ],
        "responses" : {
          "default" : {
            "description" : "default response",
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/VariantX"
                }
              }
            }
          }
        }
      }
    }
  },
  "components" : {
    "schemas" : {
      "VariantX" : {
        "required" : [ "label" ],
        "type" : "object",
        "properties" : {
          "label" : {
            "type" : "string",
            "description" : "The variant label XX",
            "example" : "variant_1"
          }
        }
      },
      "VariantLabelX" : {
        "type" : "object",
        "description" : "The variant label XX",
        "example" : "variant_1"
      }
    }
  }
}

Note the 'type' of the 'label property on schema VariantX. It is 'string'
But the 'type' of the schema VariantLabelX is 'object'
So this to me feels like there is a problem with the generation of the schema component, and that it does not use the specified type.
I have tried various different ways of referencing the label schema, but the only way I have found to correct specify the parameter to the resource, is to completely override the schema definition within the @parameter definition. So:
    .........
    public Variant getVariantX(
            @PathParam("variantLabel")
            @Parameter(schema = @Schema(name = "VariantLabelX", type = "string", example = "variant_1", description = "The variant label XX123"))
            final Variant.Label variantLabel) {
        Variant variant = null;
        return variant;
    }

Which produces:
"/v1/experiments/variantsX/{variantLabel}" : {
      "get" : {
        "summary" : "Retrieve a single variant X",
        "operationId" : "getVariantX",
        "parameters" : [ {
          "name" : "variantLabel",
          "in" : "path",
          "description" : "Variant Label",
          "required" : true,
          "schema" : {
            "type" : "string",
            "description" : "The variant label XX123",
            "example" : "variant_123"
          }
        } ],
        "responses" : {
          "default" : {
            "description" : "default response",
            "content" : {
              "application/json" : {
                "schema" : {
                  "$ref" : "#/components/schemas/VariantX"
                }
              }
            }
          }
        }
      }
    },

This is an acceptable work around, but considering that this and other types are used this way many many times, there is a lot of duplicate schema definitions.

I'm having the same issue, many resources have a @PathParam which should be treated as a string in the API, but I internally use a class for this.  Adding @Schema to that class gets ignored.  In the case of parameters, it looks like it is because skipOverride is always set to true, even if there is no @Schema annotation on the parameter:
https://github.com/swagger-api/swagger-core/blob/d5ca168b70b93bff34ee2d0bfcc383476b41944b/modules/swagger-core/src/main/java/io/swagger/v3/core/util/ParameterProcessor.java#L60


Remove sourcemap from webpack

Remove sourcemap from webpack

What is the reason behind removing it?

It can be quite unreliable, for example if one makes no changes to the codebase - the sourcemapurl changes which changes the git diff and is normally quite hard to revert.


Create debug image of operator

(While submitting an issue briefly describe the problem you are facing or a new feature you would want to see added)
What happens?
Using distroless means we cannot debug inside the image if something is going wrong.
...
What were you expecting to happen?
Ability to debug when necessary by deploying a debug version of the image with the tools necessary to debug and the operator binary running in debug mode.
...
Steps to reproduce:
N/A

...
...

Any errors, stacktrace, logs?
N/A
...
Environment:

Runtime version(Java, Go, Python, etc): N/A
Desktop OS/version: N/A

Additional comments:
N/A
...

We could use gcr.io/distroless/base:debug-nonrootfor the debug image.
gcr.io/distroless/static


fix: Prevent new tab opening on table row click

Overview
This PR when merged, will close newrelic#27, which describes an issue where when you click a URL in the top performance table a new tab to that URL would be opened up in the browser (instead of just opening up a modal for more details on that row). This behavior is fixed with this commit.
What's changed?

Fixed issue #27
Replaced the old platform table with the new version recently released.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Number Styles: e.g. proportional uppercase/lining

It would be great if you could define the style for the numbers in a text style or typography token. In Figma, this can be found in the text styles and details "Numbers".

Unfortunately Figma's Plugin API does not support this yet.

CLosing as this will be added as soon as we have a Figma API option for this and other typography properties


python312Packages.safety: 3.2.5 -> 3.2.6

Description of changes
Diff: https://github.com/pyupio/safety/compare/refs/tags/3.2.5...3.2.6
Changelog: https://github.com/pyupio/safety/blob/3.2.6/CHANGELOG.md

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 336632 run on x86_64-linux 1

10 packages built:

poetryPlugins.poetry-audit-plugin
poetryPlugins.poetry-audit-plugin.dist
python311Packages.safety
python311Packages.safety-schemas
python311Packages.safety-schemas.dist
python311Packages.safety.dist
safety-cli (python312Packages.safety)
python312Packages.safety-schemas
python312Packages.safety-schemas.dist
safety-cli.dist (python312Packages.safety.dist)


Node-RED packaging guidelines

Thanks for your interest in Node-RED
Have you read the packaging guidelines?
https://nodered.org/docs/creating-nodes/packaging

Note: Please do NOT add the node-red keyword until you are happy that the node is stable and working correctly, and documented sufficiently for others to be able to use it.

done


Update cloud-services-guestos-update-matrix.md

Hi @raiye, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Rashmi Iyer). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Handle errors

Issue opened with imdone.io from code comment on 9f751f1
TODO  Handle errors id:38

https://github.com/imdone/imdone-atom/blob/9f751f14f022fed15d90b360e4f50f43250dcb82/lib/views/product-selection-view.coffee#L71-L76

Issue closed with imdone.io by removing a comment.

https://github.com/imdone/imdone-atom/blob/75fb7b259089bcca763ede7cbb11e75763fae6a5/lib/views/product-selection-view.coffee#L71-L76


[Windows+MSYS2] doesn't have a git repository except it is a git repository.

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.77.3 (user setup)
Commit: 704ed70d4fd1c6bd6342c436f1ede30d1cff4710
Date: 2023-04-12T09:16:02.548Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: No

Steps to Reproduce:

Install MSYS2
Install git under MSYS2
Run code . --log trace in the git folder

2023-04-20 15:57:32.592 [info] Log level: Trace
2023-04-20 15:57:32.592 [info] Validating found git in: "C:\Program Files\Git\cmd\git.exe"
2023-04-20 15:57:32.592 [info] Validating found git in: "C:\Program Files (x86)\Git\cmd\git.exe"
2023-04-20 15:57:32.592 [info] Validating found git in: "C:\Program Files\Git\cmd\git.exe"
2023-04-20 15:57:32.592 [info] Validating found git in: "C:\Users\xiaoh\AppData\Local\Programs\Git\cmd\git.exe"
2023-04-20 15:57:32.592 [info] Validating found git in: "C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe"
2023-04-20 15:57:32.682 [info] Using git "2.40.0" from "C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe"
2023-04-20 15:57:32.683 [trace] [swf] Scan workspace folders: [d:\dev\icewhale\zima-client-backup]
2023-04-20 15:57:32.694 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2023-04-20 15:57:32.694 [trace] [svte] Open repository for editor resource d:\dev\icewhale\zima-client-backup\fsnotify_service.go
2023-04-20 15:57:32.694 [trace] [swsf] Scan workspace sub folders. autoRepositoryDetection=true
2023-04-20 15:57:32.694 [trace] [swsf] Workspace folder: d:\dev\icewhale\zima-client-backup
2023-04-20 15:57:32.695 [trace] Opening repository: d:\dev\icewhale\zima-client-backup
2023-04-20 15:57:32.697 [trace] [swsf] Workspace scan settings: repositoryScanMaxDepth=1; repositoryScanIgnoredFolders=[node_modules]; scanRepositories=[]
2023-04-20 15:57:32.697 [trace] [swsf] Workspace scan sub folders: [d:\dev\icewhale\zima-client-backup\.vscode, d:\dev\icewhale\zima-client-backup\api, d:\dev\icewhale\zima-client-backup\codegen, d:\dev\icewhale\zima-client-backup\internal]
2023-04-20 15:57:32.839 [info] > git rev-parse --show-toplevel [142ms]
2023-04-20 15:57:32.841 [trace] Repository root for path d:\dev\icewhale\zima-client-backup is: \d\dev\icewhale\zima-client-backup
2023-04-20 15:57:32.841 [trace] Opening repository for path='d:\dev\icewhale\zima-client-backup' failed; ex=spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:283:19)
	at onErrorNT (node:internal/child_process:478:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
2023-04-20 15:57:32.847 [trace] Opening repository: d:\dev\icewhale\zima-client-backup
2023-04-20 15:57:32.986 [info] > git rev-parse --show-toplevel [138ms]
2023-04-20 15:57:32.987 [trace] Repository root for path d:\dev\icewhale\zima-client-backup is: \d\dev\icewhale\zima-client-backup
2023-04-20 15:57:32.988 [trace] Opening repository for path='d:\dev\icewhale\zima-client-backup' failed; ex=spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:283:19)
	at onErrorNT (node:internal/child_process:478:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
2023-04-20 15:57:33.030 [trace] Opening repository: d:\dev\icewhale\zima-client-backup\.vscode
2023-04-20 15:57:33.218 [info] > git rev-parse --show-toplevel [189ms]
2023-04-20 15:57:33.220 [trace] Repository root for path d:\dev\icewhale\zima-client-backup\.vscode is: \d\dev\icewhale\zima-client-backup
2023-04-20 15:57:33.220 [trace] Opening repository for path='d:\dev\icewhale\zima-client-backup\.vscode' failed; ex=spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:283:19)
	at onErrorNT (node:internal/child_process:478:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
2023-04-20 15:57:33.237 [trace] Opening repository: d:\dev\icewhale\zima-client-backup\api
2023-04-20 15:57:33.328 [info] > git rev-parse --show-toplevel [91ms]
2023-04-20 15:57:33.330 [trace] Repository root for path d:\dev\icewhale\zima-client-backup\api is: \d\dev\icewhale\zima-client-backup
2023-04-20 15:57:33.330 [trace] Opening repository for path='d:\dev\icewhale\zima-client-backup\api' failed; ex=spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:283:19)
	at onErrorNT (node:internal/child_process:478:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
2023-04-20 15:57:33.337 [trace] Opening repository: d:\dev\icewhale\zima-client-backup\codegen
2023-04-20 15:57:33.511 [info] > git rev-parse --show-toplevel [175ms]
2023-04-20 15:57:33.513 [trace] Repository root for path d:\dev\icewhale\zima-client-backup\codegen is: \d\dev\icewhale\zima-client-backup
2023-04-20 15:57:33.513 [trace] Opening repository for path='d:\dev\icewhale\zima-client-backup\codegen' failed; ex=spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:283:19)
	at onErrorNT (node:internal/child_process:478:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
2023-04-20 15:57:33.526 [trace] Opening repository: d:\dev\icewhale\zima-client-backup\internal
2023-04-20 15:57:33.652 [info] > git rev-parse --show-toplevel [126ms]
2023-04-20 15:57:33.654 [trace] Repository root for path d:\dev\icewhale\zima-client-backup\internal is: \d\dev\icewhale\zima-client-backup
2023-04-20 15:57:33.655 [trace] Opening repository for path='d:\dev\icewhale\zima-client-backup\internal' failed; ex=spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Users\xiaoh\AppData\Local\msys2\usr\bin\git.exe ENOENT
	at ChildProcess._handle.onexit (node:internal/child_process:283:19)
	at onErrorNT (node:internal/child_process:478:16)
	at process.processTicksAndRejections (node:internal/process/task_queues:83:21)

Not exactly the same issue as https://github.com/microsoft/vscode/issues/173226

Probably a duplicate of #143165


Add a null checking to GDScript::_super_implicit_constructor

To prevent possible editor crashes - by pushing null checking error instead

Yeah, I did it to prevent crashes if, for example, https://github.com/godotengine/godot/pull/58393 is merged.


[Feature request] Specify a Jupyter server per notebook

Hi! As of today, when you open a Jupyter notebook you have the option to specify the URI of an existing server, which then asks you to reload vscode and all of the open notebooks are automatically opened on that server. Which means that if I have two servers (X,Y) and three notebooks (A,B,C), I can have something like:

Notebook A running on server X
Notebook B running on server X
Notebook C running on server X

And if I want to change the server URI to Y's, vscode reloads and I end up with:

Notebook A running on server Y
Notebook B running on server Y
Notebook C running on server Y

What I would like to request is the option to specify the URI per notebook, so that I can have something like:

Notebook A running on server X
Notebook B running on server Y
Notebook C running on server X as well

Hope this is clear! Thanks! :)

@rebornix Please feel free to transfer this issue for Jupyter repo.

@DonJayamanne sorry I opened the issue here. I was checking the "Working with Jupyter Notebooks in Visual Studio Code" docs and found a button that said "Request features" and ended up here. Thanks for pointing my request in the right direction!


Build hugging faces tutorial

I think its time we have a gradio app on hugging faces. Can we clone this app and edit from there?
https://huggingface.co/spaces/AndresHdzC/pytorch-wildlife
I think this is a 'good first issue', in the sense it won't take much DeepForest knowledge, but it will take some experience with hugging faces.
Steps

Clone https://huggingface.co/spaces/AndresHdzC/pytorch-wildlife/blob/main/app.py
Integrate the getting started tutorial for birds and tree models.
Show screenshots from local gradio app
Get clearance from @ethanwhite for huggingfaces space
Upload and test
Connected to model hosting issue #317 and GSOC conversation #628

Would we want to use predict_image or predict_tile? No way to know what size of images to upload, we will need some kind of instruction or logic to guess whether we need to cut images into pieces.

Anyone looking for a somewhat more complex issue that is still manageable without a deep understanding of the code base - this is a good one. Enjoy!

I have issued a Pull request for this issue. I have completed the first three steps. Can you please elaborate on the 5th step? Thanks!

@Om-Doiphode - can you send me your huggingface username so I can add you to our organization so you can upload this to the right place

@bw4sz is there cost associated with this?

@Om-Doiphode - can you send me your huggingface username so I can add you to our organization so you can upload this to the right place

Yeah sure. Following is my username: HawkeyeHS (https://huggingface.co/HawkeyeHS)

Hi @ethanwhite, I have accepted the invite to Hugging Face, how can I push the app to the Hugging Face spaces? Should I push it using my API key since in the organization's settings it says that the organization API tokens have been deprecated and to migrate the system to use User Access Tokens?

@Om-Doiphode - I've created a huggingface space for this. It's a git repo and there are instructions on the page for getting linked up to it so that you can push your draft app:
https://huggingface.co/spaces/weecology/deepforest-demo
If you already have a git history for this project that you'd like to keep let me know and I can walk you through how to connect your local repo to huggingface directly instead of following the instructions for cloning.

Hi @ethanwhite, thank you for creating the space. I have pushed my draft app on the space, please review it. Thanks!

Looks great to me! Can you add a mention of this to the docs?
@bw4sz - take a look when you get the chance and see what you think

Great start!

Let's increase the default thickness for predict birds, in predict_tile, thickness = 3? The predictions right now are hard to see, they are there if you squint. We might need some logic for the thickness. If the image is less than 1000 pixels, thickness is 1, over 1000 thickness = 2, more than 5000, thickness = 3?

we want to format the errors to show users how they can fix any test images. For example, right now it gives 'error'. it should return the error.

Looks great to me! Can you add a mention of this to the docs?
@bw4sz - take a look when you get the chance and see what you think

I have added the link to the app in the docs in the Getting Started and Prebuilt models sections.


[Question]: The chat response is slow，How can I improve the response speed

Describe your problem
The answers are slower compared to directly using models and other local knowledge base tools such as OpenWebUI, anythingLLM. How can I improve the response speed? Currently, the database file used is only 17k, and my local GPU is a 4070ti with 16G of VRAM.

Click this lamp which will show you how the time elapsed.

thankyou

Click this lamp which will show you how the time elapsed.

Are these normal times to consume

Click this lamp which will show you how the time elapsed.

Are these normal times to consume

How long？

Elapsed
Refine Question: 69.9 ms
Keywords: 0.0 ms
Retrieval: 2283.8 ms
LLM: 8232.2 ms

How long？

Elapsed
Refine Question: 69.9 ms
Keywords: 0.0 ms
Retrieval: 2283.8 ms
LLM: 8232.2 ms

How can I speed up the generation of responses?


chore(weave): Introduce history.count optimization

The first of it's kind: an op re-write optimization. Rewrites run.history.count to run.historyLineCount which is much faster since it is just a quick lookup for gorilla!

I commented on the other PR that is after this one, with comments for this PR.

Closing this as it is included in https://github.com/wandb/weave/pull/386


Install without starting service

I need to install the service without starting it in my testing environment. The "--manual" install argument does configure the startup mode as manual (I'm also using topshelf) but it still automatically starts the service after install. How can I prevent the service from starting after install?

any progress on this?
this appears to be other only service deploy that will work against a deployment group, I can't have it starting the service automatically though.

i've made the change in the script and published a private version to my org, but it's not showing up for some reason despite being allowed. any chance of a quick update please?

Open a pull request

This support has been added by @Girxffe, thank you!
Published to the marketplace this morning.


Implement V4::Capsules

Why?

SpaceX now has a v4 api and new capsules endpoints

Description

Added code to support two of the new endpoints

Get all capsules
Get a specific capsule by id

Notes
The README.md file was getting too long, so I created a docs folder and moved v3 and v4 documentation to their own markdown files

@rodolfobandeira It has been a while since I opened these PRs. Let me try to remember what my thought process was and address your feedback. I also am curious to know your thoughts on the idea mentioned here https://github.com/rodolfobandeira/spacex/issues/80#issuecomment-706762889

Thanks @invacuo
We'll need to update the CHANGELOG.md. I can help with that right after I merge this


[Bug] Cyclic dependency error occurs while creating Google sheet Datasource

Description
Release Frozen - It is observed that user is not able to create google sheet datasource - Cyclic dependency error occurs
Expected Result:
Cyclic dependency error should not occur while creating google sheet datasource
Steps to reproduce the behaviour:

Launch Appsmith app in the release frozen environment
Click on datasource
click create new and select - Google sheet
Click on save
Allow access to google account and observe

Videolink:
https://www.loom.com/share/2aa696071d8346dc9074815d7e21205e
Important Details

Version: [11.3]
OS: [e.g.MacOS]
Browser [chrome, safari]
Environment [release frozen]

@somangshu This happened because of issue #6375

@YogeshJayaseelan The original error occurred because no permissions were assigned while oAuth. Now as mentioned in #6375 it seems to be something connected to the API call itself. Shall check dig more there


azureml-dataprep-rslex doesn't support custom CA bundles

Package Name: azureml-dataprep-rslex
Package Version: 2.18.4
Operating System: macOS 13.4.1
Python Version: 3.10.10

Describe the bug
When using the azureml-fsspec package behind a proxy with TLS inspection I get the following error:
[PyDatastoreSource::list_directory] fails with error: ConnectionFailure { source: Some(ConnectionFailure { message: "Failed to connect to Azure Machine Learning services to  resolve Datastore.", source: Some(hyper::Error(Connect, Custom { kind: Other, error: Custom { kind: UnexpectedEof, error: "tls handshake eof" } })) }) }
To Reproduce
Steps to reproduce the behavior:

Use a HTTP proxy with TLS inspection (custom CA)
Add the CA to the system Keychain
Use the azureml-fsspec package

Expected behavior
The package should use the CA bundle available in the system Keychain, or provide a way to override the CA using the SSL_CERT_FILE environment variable for example.

Hi @tomasvanpottelbergh - Thanks for opening an issue! Tagging people who can take a look; we'll investigate asap!


Windows style WSL SO_REUSEADDR behaviour makes RPC over TCP unreliable

Your Windows build number:

Version 10.0.18346.1 (but all versions will be affected)

What you're doing and what's happening:

Using software that relies on Sun RPC communications over TCP, using clnttcp_create from libc.
If clnttcp_create is called without passing a pre-bound socket to use, it calls bindresvport to find an unused privileged (<1024) source port to use.
Sometimes bindresvport returns a port that then causes connect to fail with EADDRINUSE
This then causes clnttcp_create to fail, returning an error

What's wrong / what should be happening instead:

bindresvport relies on UNIX style behaviour when calling bind on a socket without SO_REUSEADDR set. That is for EADDRINUSE to occur if there is still a connection in state TIME_WAIT associated with that socket.
Because WSL follows the Windows IP stack behaviour, bind will succeed in the case of existing TIME_WAIT connections on a socket.
This results in a port being selected that can then cause connect to fail as above.
cygwin suffered the same issue, and it's version of clnttcp_create was patched to work around it. See http://cygwin.1069669.n5.nabble.com/Re-RPC-clnt-create-adress-already-in-use-td138927.html

I realise there are already open issues regarding WSL behaviour with SO_REUSEADDR set, (eg. #2915) but I don't see any for the difference without SO_REUSEADDR, hence adding this one. Hope that's the right thing to do.
(For now I'm working around this by LD_PRELOADing a wrapper for clnttcp_create which retries bindresvport to get another port in case of the connect error - this was somewhat simpler than the cygwin approach and 'works for me').

Hope that's the right thing to do.

Meh, can't exactly fault you for it. I strongly suspect (but can't prove) this will go chirping crickets without a repro test case with CLI steps, an strace(1) log, and the like per the template.
But consider: (a) the underlying SO_REUSEADDR divergence appears to be well understood, (b) #2915 exists, and, (c) #2915 went dark a year ago with the remarks: "We have talked to the Windows networking team that supports these options previously to see if we can reconcile the differences, but, given the legacy of these options, that has had been a difficult conversation"
Well, you be the judge. Either way, great Cygwin reference and hat-tip on your work around.

Yes, I can't imagine a simple solution here

The standard approach for such problems: A compatibility flag (in the Windows TCP/IP driver) on the socket. The flag would be set internally by WSL (using WSK and externally by Cygwin in inside its socket() wrapper. Such a flag would have no impact on existing winsock programs dating back to the beginning of time.
The flag wouldn't have a measurable performance impact on existing Winsock programs (it's a branch on a slow path). But yes, any programmer who is not thrilled with being assigned the task of having to implement the flag will surely raise performance concerns as an issue. Bonus points if the programmer not thrilled with the idea says "there may be unknown security concerns".
[Pro-tip: If you ever find yourself in the situation, go with unknown security concerns. Then you can study those concerns for an indefinite period, and hope they don't come back to ask again.

But at least it's captured and might save others some head scratching.

Yes and thanks again. I am just not sure there are two actionable here: this and #2915. Or put another way, I can't see #2915 being fixed, but not your framing of the problem.

Yes, I can't imagine a simple solution here

The standard approach for such problems: A compatibility flag (in the Windows TCP/IP driver) on the socket. The flag would be set internally by WSL using WSK and externally by Cygwin in inside its socket() wrapper. Such a flag would have no impact on existing winsock programs dating back to the beginning of time.

But at least it's captured and might save others some head scratching.

Yes and thanks again. I am just not sure there are two actionable here: this and #2915. Or put another way, I can't see #2915 being fixed, but not your framing of the problem.


[async] Refactor cfg

I think it may be quite cool enhancement to the async request setup. See more in the associated issue:

Resolves #2053

Ok, I've played a little bit with it, and it doesn't make sense to put this handler in our API. It's too inconsistent and should be probably just called by users in their specific use-cases. I've reverted the change, so there's still the improvement around the cfg we've spoked about on Discord.

I'll close the other one as not-planned, then merge this then.

Thanks 🙏