@SaebAmini: You can use System. Drawing on .NET Core. See System.Drawing.Common Scott Hanselmanns Blogpost: https://www.hanselman.com/blog/HowDoYouUseSystemDrawingInNETCore.aspx
Is there any feature that is missing for you on when running on .NET Core?

@TsengSR my specific scenario which made us target the .NET Framework was:

The need to use the Microsoft Solver Foundation package, only available in .NET Framework.
A barcode image generation package which used System.Drawing.
The need to use EF6.

This was about a year ago.

@SaebAmini: As it was mentioned earlier, EF6 support comes in .NET Core 3.0, System.Drawing is already there (and before that the CoreCompat package did existed and may have worked in your case) and for the Microsoft Solver Foundation Package, after running Portability API Analyzer:
See How to use Portability Analyzer
https://gist.github.com/TsengSR/f61c03c5f2d63dbe78d6b8c1eed08831 (download it and open the HTML, didn't find other place to put it in).
It shows 97.93% compatibility with .NET Core 2.0+Platform Extensions (which was released around a year ago) and it lists incompatible APIs, which are mostly related to System.Web which was deprecated and System.ServiceModel / System.Data.Linq.
Now, I didn't use this package before, and I'm not certain why a solver would need access to System.Web and HttpContext or the System.ServiceModel, but if you don't need any of theses (and you know your use case isn't calling this APIs), the chances are pretty high, that you could use it on .NET Core 2.0/2.1+Platform Extensions or on .NET Core 3.0, even if it doesn't specifically target the netstandard  or netcoreapp20 target moniker.
So technically the chances were good that you could have migrated your application to .NET Core 2.0+Platform Extensions a year ago, if EF Core 2.0 could have covered the needs of your applications need (of course that requires some migration work and updates to work with EF Core 2.0).
Yes, it takes a bit more work to analyze the libraries in question or the feature for the replacement framework (EF6 -> EF Core 2.0/2.1), but its far from impossible. I don't think people can or should expect to port all of their code 1:1 to ASP.NET Core w/o doing any changes at all (outside of ASP.NET Core itself).
Just wished it would be more obvious to have API compatibility displayed, like with a "badge" (.NET Core 3.0 compatible) and/or a detailed api compatibility report somewhere on the nuget page to make it more obvious than having to download the package and then run it through the package analyzer.

I think this announcement would have been better received if it emphasised how much more compatible .NET Core has become. There are two enabling factors needed move ASP.NET Core off .NET Framework:

Reducing the need for .NET Framework, making legacy deps available and improving interop and so on
Increasing the benefits of .NET Core, features and performance and reduced maintenance burden

Factor 2 looms large in the minds of people who have to actually build ASP.NET! However, there is little upside from a user’s point of view. People have a thing that works and their highest priority is that it should keep working. The good news is that in most cases, it will.

I agree with @gulbanana. .NET Core is now much more compatible with .NET Framework. In fact, I was able to launch pretty big .NET Framework apps just by renaming .exe to .dll and adding some missing .DLLs to the probing path.
The progress on dotnet command line tools is impressive. Especially the addition of .NET Core global tools. They make development a breeze.
AOT compilation with crossgen is great.
What is missing:

The current customer communication strategy is lacking. Customers have a big disappointment when they hear their favorite .NET platform is being fragmented by Microsoft. You should be more clear here. For example, it would be a much better approach to directly advertise the singular, highly-compatible, fast and future-proof .NET implementation to people. Like .NET Core, the future of .NET, going to solve most of your problems,  sky-rocket productivity, creativity, open new market niches etc
Even more compatibility strategies out of the box
Graphical user interface. I mean dotnet command line tools are great, but currently we have to use additional text editors and console to work on a almost every project in .NET SDK format. The Visual Studio UI is lacking in this regard. This puts big barriers to many people who have a habit to just point-and-click. This should be improved too

@TsengSR Thanks for your detailed response mate, great info! at the time using the barcode package wouldn't work as the project simply wouldn't compile complaining about different targets. Maybe I should give that another try. (unless you meant recompiling it ourselves and kinda inheriting it)
Not concerned about the effort really if that's reasonable. My main concern was being left high and dry with no option with EF being the main blocker and that seemingly is not going to happen. Great to see it's been well thought out. Although I agree with @gulbanana that these can be better advertised.

There are a lot of conflated issues here. My personal 2 cents is that leaving .NET Framework behind isn't such a big deal. What is concerning however is the total lack of any apparent support for standardization efforts (.NET Standard). Sure, you probably don't want to run ASP.NET Core on, say Unity today, but it isn't about today. It's about a year or two down the road, when another .NET runtime could come around, I would like to be able to say "Yeah, as soon as SuperNetRuntime supports .NET Standard 2.2 we can run ASP.NET Core 3 on it"...
Is there any chance to at least "gather" all the changes that were needed in .NET Core 3 for ASP.NET Core 3 and forward them to the .NET Standard working group as suggestions?

Hi, will packages published for .NetStandard 2.0 or .NetCore 2.0 continue to work with .NetCore 3.0. For eg: Oracle.ManagedDataAccess.Core target .NetCore 2.0
If there is backward compatibility, then moving to .NetCore 3.0 is suitable but if there is no support for older versions, then its really useless unless all play catch up.
.NetFramework has a history of compatibility even you can use .NetFramework 2.0 in latest versions so something need to be maintained for .NetCore also atleast 2.0 to 3.0 etc.
Thanks

Hi, will packages published for .NetStandard 2.0 or .NetCore 2.0 continue to work with .NetCore 3.0. For eg: Oracle.ManagedDataAccess.Core target .NetCore 2.0

Yes, .NET Core 3.0 maintains backwards compat so can use .NetStandard 1.x -> .NetStandard 2.0 and .NetCore 1.0 -> .NetCore 2.2 libraries

@benaadams then thats good. Also will .net framework dll will work if they don't use any missing api?
Thanks

Also will .net framework dll will work if they don't use any missing api?

Yes, though its safer to use a .NET Standard library as you know that will work.
Additionally using the Windows Compatibility Pack adds another 20,000 APIs on top of .NET Standard 2.0 to bring .NET Core closer to .NET Framework (which you can do with .NET Core 2.1); and .NET Core 3.0 is the most compatible yet with EF6 (cross-plat), and on Windows: WinForms, WPF, COM Interop etc

Hi folks,
In order to give customers a reasonable stepping stone on their path to migrating applications to ASP.NET Core on .NET Core, we are going to extend support and servicing for ASP.NET Core 2.1.x on .NET Framework to match the current support policy for the other package-based ASP.NET frameworks, e.g. MVC 5.x, Web API 2.x, SignalR 2.x. This effectively means the ASP.NET Core 2.1.x related packages (final detailed list TBD) will be supported indefinitely, beyond the 3 year LTS period for the .NET Core 2.1 train overall.

@DamianEdwards What is your recommendation for on-premise deployments in the context of @Edward84 's comments. Is the recommendation just to use ASP.NET MVC 5 ?

Excellent news. Thank you for listening to your customers.
It's going to take us a very long time to port our old MVC app over as we've been on MVC since CTP3 and have just about every extension point used. This covers our concerns.

@DamianEdwards That’s great news! Just wondering though, is this fixed to 2.1.x or will this be updated to 2.2.x if that ends up becoming a LTS release? There has been a lot of effort going into 2.2 and it isn’t even released yet. And since it continues with netstandard compatibility and runs fine on the full framework, it would be kind of a waste to skip this completely for the extended support.

@poke while I understand your concern, we have to draw a line somewhere, and in this case we think it's better to keep the version aligned with the LTS that preceeds it. This is the trade off customers must decide for themselves when choosing between and LTS or Current train. New features don't come to LTS as they are about stability. The feedback was for longer term support and we have a train for that already so this is an extension of the train. 2.2 will not become LTS.

@DamianEdwards Yeah, I understand that, thanks for your reply. I was just asking because the last comment on this was that it hasn’t been decided yet, so I just wanted to know if this extended support would carry forward iff 2.2 became LTS.
And I think it’s important enough to highlight this so that people will not upgrade their framework apps to 2.2 if they have to rely on this extended support. Otherwise they will have to downgrade again.

New features don't come to LTS as they are about stability.

That does not really match the previous LTS decisions though.

@poke

That does not really match the previous LTS decisions though.

This confused me. In what way? Are you referring to the fact that 1.1 was added to the 1.x LTS train? If so, that was an anomaly of our first release train that won't be repeated. Moving forward, our intent is to get more consistent with which releases become LTS vs. Current (i.e where do I get stability vs. features).

@DamianEdwards I was mostly referring to the fact that every release so far has been a large feature release, and each LTS decision was usually made in retrospect (at least publicly).

@poke OK. Well, so far we've had 4 releases (1.0, 1.1, 2.0, 2.1) with the 5th coming shortly (2.2). Of those, only 1.0 and 2.0 were initially intended to be LTS, but due to a number of factors (mostly related to us being really new at doing engineering this way 😉) we ended up with 1.0, 1.1 and 2.1 being the LTS trains. 2.0 and 2.2 are (were, will) Current releases. At this stage, 3.0 will almost certainly be Current also (causing 2.2 to enter the Current "grace" period of 3 months) before 3.1 becomes the 3.x train LTS. Our hope is after that, the pattern and cadence will be more consistent (we'd love that) but so far our crystal ball has failed us.

@DamianEdwards Thanks for the insights! 😄 (Btw. I wasn’t trying to argue about this, I was just curious ;) )

A bigger issue for us is new REST APIs hosted in-process by legacy applications that aren't likely to move off .NET Framework any time soon. At least we know not to progress beyond .NET Standard 2 supporting libraries and ASP.NET Core 2.1 now! It's good the LTS period will be extended

@lokitoth - that would be a good question for the https://github.com/dotnet/core folks because it's more general than just ASP.NET Core.

@lokitoth yes, that will be supported, see https://github.com/dotnet/coreclr/issues/18013

@danroth27 Could you tell me the impact of this issue for Client-Side-Blazor?

@Slkebe I don't expect any impact.
Am I missing something? Blazor has to keep targeting Microsoft.AspNetCore.* 2.1.X?

@Slkebe The client-side Blazor libraries only depend on components that will continue to target .NET Standard (like Microsoft.Extensions.* and friends). The server-side parts of Blazor that depend on ASP.NET Core will target .NET Core as described in this issue.

https://blogs.msdn.microsoft.com/dotnet/2018/11/05/announcing-net-standard-2-1/
What's the decision now? Target on .net standard 2.1 ?

@John0King There's no new decision.

This is bananas.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Add flex box class

Hello. This PR adds the FlexBox class based on the gist that you provided. I resolved several issues with preferred size and coordinate spaces. I also added documentation and modified the test to match the layout of the Playground utility.
Issues not resolved with this PR: config.setUseWebDefaults(true);  still gives unexpected results and I don't understand its necessity. I also aim to add some builder style functionality to nodes to make user code a little less verbose. That will be a separate PR.
What I need help with in this PR: I can't get GWT compatibility to work correctly. I'm not familiar with this layout of build.gradle and I usually don't have issues in my own projects. Will you be able to take a look at this?
Thank you so much!

Thank you Lyze! You're doing really great work here.


admin.auth().createCustomToken() is not correctly returning a rejected promise

Environment

Operating System version: OSX 10.13.4
Firebase SDK version<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Library version: Node v6.11.5 on Cloud Functions, v8.10.0 locally (happens on both)
Firebase Product: auth

Describe the problem
createCustomToken() correctly returns chained .then() resolved promises but not .catch() rejected errors. Nothing inside a .catch() block that immediately follows createCustomToken() fires at all - it's as if the promise just returns immediately without stopping (which no other Firebase promise that I've used so far has done).
This is frustrating for my use case because I'm trying to throw my own custom error/exception and not Firebase's.
Relevant Code:
const functions = require('firebase-functions');
const admin = require('firebase-admin');

admin.initializeApp(); // Must be initialized with credentials with a private_key in order to use createCustomToken

exports.notWorking = functions.https.onRequest((req, res) => {
  Promise.resolve() // This can be anything, for example admin.auth().getUserByEmail()
    .then(() => {
      return admin.auth().createCustomToken() // This is purposely left blank to simulate failure
        .then((customToken) => {
          res.status(201).json({
            name: 'Success',
            token: customToken,
          })
        })
        .catch((error) => {
          console.log('Never fires');
          throw new CustomException('My custom error message');
        })
    })
    .catch((error) => {
      console.error(`createCustomToken is immediately returning Firebase's error and not mine`);
      res.status(500).json(error);
    })
});

function CustomException(message) {
  this.name = 'CustomMessage';
  this.message = message;
}

Steps to reproduce:

Run the above code in Cloud Functions. Visit the endpoint directly. You should see the following JSON response:

{"code":"auth/argument-error","message":"First argument to createCustomToken() must be a non-empty string uid."}

Note also that Never fires never outputs into the server-side logs.

Replace .createCustomToken() in the code above with another admin function, such as .createUser() (params deliberately left blank to invoke an error), or even a generic Promise.reject(). You should now see the following JSON response:

{"name":"CustomMessage","message":"Custom error message"}

Note that Never fires is now being logged server-side, which means that the first/nested .catch() is now actually being respected.

I'm not an expert on promises or anything, so I'm not totally sure what the scenario for this is called (swallowed error?) - but it definitely doesn't seem like expected behavior for a promise to just ignore a .catch() block. I'd love for this to get fixed so I can handle .createCustomToken() with my own error messaging instead of having to use Firebase's.

This is debatable. For example our JS client SDKs with promise returning APIs also throw synchronous errors when provided with invalid arguments. We aim to fail fast when you provide invalid types for arguments. I know there are other APIs that intentionally do this. Here is an example with the importUsers API:
https://github.com/firebase/firebase-admin-node/blob/master/src/auth/auth-api-request.ts#L587

To add to what @bojeil-google mentioned, how certain types of errors are handled in JS is largely a matter of preference and style. The style the Admin SDK strives to adhere to is:

throw errors and fail fast in case of invalid arguments, and
reject a promise for other runtime errors (e.g. back-end server errors).

In that sense the createCustomToken() is implemented correctly. But I think the SDK is not consistent across all its APIs when it comes to the above conventions. As you have noticed the createUser() method rejects a promise for all types of errors. We should probably seek out such instances, and fix them to be consistent with the rest of the SDK.

Thanks, it's good to know that pattern - would be fantastic to have in the docs somewhere perhaps. Agreed that consistency is usually best above all, and appreciate that potentially being addressed down the road.
Apologies again if this stems from me not fully understanding how promises work, and thank you in advance for taking any time out of your day to clarify. My confusion is that:
createCustomToken()
  .catch(() => { console.log('Never fires') })

is not working, whereas
createCustomToken('userId', {})
  .then(() => { throw new Error('This gets caught') }
  .catch((error) => console.log('Fires', error))

does.
Either way, it sounds like the behavior is potentially solved by never chaining .catch()s onto Firebase promises and instead relying on returning the promise and letting a parent catch handle all errors from there. That makes my step-by-step logging a little less granular than I'd like, but I'll find a way to structure my code around it. Thanks!

Thanks, good to know. Excited for that PR, by the way! :) Thanks for implementing it!
I'll modify my project to accommodate existing behavior since it's intentional. Also since it's intentional, consider this issue closed as wontfix, I suppose. I'll dig a bit more into promises some other time and try to get to the bottom of why a thrown error would skip being caught.


[TASK] Update the best practice page to mention some broken kernels

Broken kernels are mentioned at https://longhorn.io/kb/troubleshooting-rwx-volume-fails-to-attached-caused-by-protocol-not-supported/

Test plan:
No test plan is needed for this ticket

Verification passed. The updated information can be found at https://longhorn.io/docs/1.7.0/best-practices/#operating-system.


Building static libbpfgo fails in Makefile running in v0.2.5: /usr/bin/ld cannot found lXX

Run command make -C selftest/perfbuffers or make selftest-static-run
Out Error
/usr/lib/golang/pkg/tool/linux_amd64/link: running clang failed: exit status 1
/usr/bin/ld: cannot found -lelf
/usr/bin/ld: cannot found -lz
/usr/bin/ld: cannot found -lelf
/usr/bin/ld: cannot found -lz
/usr/bin/ld: cannot found -lelf
/usr/bin/ld: cannot found -lz
/usr/bin/ld: cannot found -lc
clang-14: error: linker command failed with exit code 1 (use -v to see invocation)

Linux Version
Fedora release 36 (Thirty Six)
Linux fedora 5.17.5 #2 SMP PREEMPT Sun Sep 4 19:24:15 CST 2022 x86_64 x86_64 x86_64 GNU/Linux

Libbpf Version
Name         : libbpf
Epoch        : 2
Version      : 0.7.0
Release      : 3.fc36
Architecture : x86_64
Size         : 356 k
Source       : libbpf-0.7.0-3.fc36.src.rpm

Possible example on how to "solve" issues like this in Makefile: https://github.com/aquasecurity/tracee/blob/main/Makefile#L50

I have the same problem, have you solved it?
Architecture：ARM64
clang version：clang-12

@zbh255 @sunhaotian0122 In the meantime you can try: https://github.com/aquasecurity/libbpfgo#contributing

@zbh255 Would you mind trying against main? We've merged related fixes: https://github.com/aquasecurity/libbpfgo/pull/431


Move Talk creation into own controller

This PR moves creation of a talk into it's own controller.
This PR superseeds PR #186 and is Part 1 of at least 7

As this PR moves the talk creation code, can you also remove the old code at https://github.com/joindin/joindin-api/blob/master/src/controllers/EventsController.php#L149-L223 please.
Also, the result of PR shouldn't change functionality.

I'll split this one up into two:

Move stuff from EventsController to TalksController (including removal of old code) without changing functionality
Altering the functionality as it will be needed to comply with editing talks (Might also go into the PR that handles the editing.

As I'd like to include Lornas Removal of the handle-function I think it'S easier to do a new PR based on the current master instead of modifying this one which will become messy.


Drop support for Shoots with Kubernetes version == 1.24

How to categorize this PR?

/kind cleanup
What this PR does / why we need it:

Add unhealthyPodEvictionPolicy: AlwaysAllow to PDBs
Drop support for Shoots, Seeds and Gardens with Kubernetes version == 1.24.

Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/8921
Part of https://github.com/gardener/gardener/issues/8821
Special notes for your reviewer:
In draft until the gardener/gardener PR is merged and released.
Release note:

`extension-shoot-lakom-service` no longer supports Shoots with Кubernetes version == 1.24.

Drop support for Shoots, Seeds and Gardens with Kubernetes version == 1.24.

Actually, how is this achieved? I see no change that actually is doing it as the extension was not managing any special cases to k8s <= 1.24, also the version of the github.com/gardener/gardener is not updated, hence the kubernetes client still allows 1.24

Drop support for Shoots, Seeds and Gardens with Kubernetes version == 1.24.

Actually, how is this achieved? I see no change that actually is doing it as the extension was not managing any special cases to k8s <= 1.24, also the version of the github.com/gardener/gardener is not updated, hence the kubernetes client still allows 1.24

Rather than the g/g version vendored, I think what matters is the version in which the gardener-apiserver is running.
And yes, you are right about

as the extension was not managing any special cases to k8s <= 1.24.

I renamed the PR.


injected ref value is not reactive when updated inside setup of a child component

Version
3.0.0-rc.10
Reproduction link
https://codesandbox.io/s/admiring-snow-4u748?file=/src/Child.vue
Steps to reproduce
Open the reproduction link, in parent component setup we have:
 setup() {
    const msg = ref("initial");
    provide("CONTEXT", { msg });

    return {
      msg
    };
  }

and in a child component setup:
  setup() {
    const ctx = inject("CONTEXT");

    // not working (works when wrapped inside onBeforeMount)
    ctx.msg.value = "updated";
  }

What is expected?
the screen should show: "updated"
What is actually happening?
the screen shows "initial"

It works fine when wrapped inside a lifecycle hook:
onBeforeMount(() => {
    ctx.msg.value = "updated";
})

I'm not sure if it's a bug or intentional behavior, but I find it weird since the parent's setup function is executed before the child's.

i think the parent's setup function must be executed before the child's. So provide function can be executed before inject

The usage here is different from the document. 🧐

However, there are times where we need to update the data inside of the component where the data is injected. In this scenario, we recommend providing a method that is responsible for mutating the reactive property.

@Picknight
providing a method that updates the ref and calling it in the child's setup makes no difference.
https://codesandbox.io/s/elated-meadow-6r04w?file=/src/Child.vue

The deep reason is ac81dcf. @yyx990803 Maybe we should revert it ?

I see this issue is closed but I am not seeing any conclusion on this thread.

I'm trying to inject a Boolean value into all components (SFC), which provide/inject seems best suited for. I have Vue 3.1.2.
I tried calling:
const injectedRef = ref(getCurrentState())
app.provide('injectedName', injectedRef)

const injectedComputed = computed(() => injectedRef)
app.provide('injectedName', injectedComputed)

const injectedReactive = reactive({ injectedRef })
app.provide('injectedName', injectedReactive)

As you can see, only the last method worked, but that defeats the purpose of injecting a single true/false variable that can be used directly in components.
This was previously done with:
const reactiveProxy = Vue.observable({ state: getCurrentState() })

Vue.use({
  install (vueInstance) {
    Object.defineProperty(vueInstance.prototype, '$injectedName', {
      get: () => reactiveProxy.state
    })
  }
})


New package: GameSir.GameSirConnect version 1.1.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,
This package only shows a blank window - is this expected? Is specific hardware required?

Verify while here:

Hi @SpecterShell,
This package only shows a blank window - is this expected? Is specific hardware required?
Verify while here:
Edit: Can you add a PackageUrl?

The package works normally in my VM.

The PackageUrl is available in the zh-CN locale manifest.

Hey
On Thu, Oct 10, 2024 at 2:29 AM wingetbot @.***> wrote:

[image: Service Badge]  [image: Service Badge]
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hey
On Sat, Oct 12, 2024 at 5:18 AM ItzLevvie @.***> wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

The package works normally in my VM.

It's probably an issue with my VM.

The PackageUrl is available in the zh-CN locale manifest.

I missed it, thank you. A new version appears to be available: https://xjdl.bigeyes.com/gsw/download/GameSir-Connect-Setup-1.1.6.exe


Rails 3.0.11, ActiveAdmin 0.3.4 -- There is no active_admin.css file :(

Hi
I posted in this issue:
https://github.com/gregbell/active_admin/issues/203#issuecomment-3350932
And was told to open a new one because my issue is in my dev environment
I tried running the assets generator, and this happens:
➭ rails g active_admin:assets
identical  public/javascripts/active_admin.js
exist  public/images/active_admin
identical  public/images/active_admin/admin_notes_icon.png
identical  public/images/active_admin/datepicker/datepicker-header-bg.png
identical  public/images/active_admin/datepicker/datepicker-input-icon.png
identical  public/images/active_admin/datepicker/datepicker-next-link-icon.png
identical  public/images/active_admin/datepicker/datepicker-nipple.png
identical  public/images/active_admin/datepicker/datepicker-prev-link-icon.png
identical  public/images/active_admin/loading.gif
identical  public/images/active_admin/nested_menu_arrow.gif
identical  public/images/active_admin/nested_menu_arrow_dark.gif
identical  public/images/active_admin/orderable.png
Short of finding the compiled css and inserting it into my project manually, I'm not sure what I can do to alleviate this...

I just tried this in my gemfile and still no dice, there is no active_admin.css and when I go to /admin it's all "plain"
gem 'activeadmin', :git => 'git://github.com/gregbell/active_admin.git', :branch => 'master'

Also, here is my development.log
Started GET "/admin" for <IP_ADDRESS> at 2012-01-07 12:57:47 -0600
Processing by Admin::DashboardController#index as HTML
AdminUser Load (0.4ms)  SELECT admin_users.* FROM admin_users WHERE admin_users.id = 1 LIMIT 1
Rendered<EMAIL_ADDRESS>(6.6ms)
Completed 200 OK in 51ms (Views: 20.6ms | ActiveRecord: 0.4ms)
Started GET "/stylesheets/active_admin.css" for <IP_ADDRESS> at 2012-01-07 12:57:48 -0600
ActionController::RoutingError (No route matches "/stylesheets/active_admin.css"):
Rendered<EMAIL_ADDRESS>within rescues/layout (1.4ms)

I ran active_admin:install again with no luck:
➭ rails g active_admin:install
invoke  devise
generate    No need to install devise, already done.
invoke    active_record
create      db/migrate/20120107193941_add_devise_to_admin_users.rb
insert      app/models/admin_user.rb
route    devise_for :admin_users
gsub    app/models/admin_user.rb
gsub    config/routes.rb
insert    db/migrate/20120104044133_devise_create_admin_users.rb
conflict  config/initializers/active_admin.rb
Overwrite /Users/joemsak/code/[REDACTED]/config/initializers/active_admin.rb? (enter "h" for help) [Ynaqdh] Y
force  config/initializers/active_admin.rb
exist  app/admin
conflict  app/admin/dashboards.rb
Overwrite /Users/joemsak/code/[REDACTED]/app/admin/dashboards.rb? (enter "h" for help) [Ynaqdh] Y
force  app/admin/dashboards.rb
route  ActiveAdmin.routes(self)
generate  active_admin:assets
identical  public/javascripts/active_admin.js
exist  public/images/active_admin
identical  public/images/active_admin/admin_notes_icon.png
identical  public/images/active_admin/datepicker/datepicker-header-bg.png
identical  public/images/active_admin/datepicker/datepicker-input-icon.png
identical  public/images/active_admin/datepicker/datepicker-next-link-icon.png
identical  public/images/active_admin/datepicker/datepicker-nipple.png
identical  public/images/active_admin/datepicker/datepicker-prev-link-icon.png
identical  public/images/active_admin/loading.gif
identical  public/images/active_admin/nested_menu_arrow.gif
identical  public/images/active_admin/nested_menu_arrow_dark.gif
identical  public/images/active_admin/orderable.png
generate  jquery:install --ui
remove  public/javascripts/prototype.js
remove  public/javascripts/effects.js
remove  public/javascripts/dragdrop.js
remove  public/javascripts/controls.js
copying  jQuery (1.6.1)
identical  public/javascripts/jquery.js
identical  public/javascripts/jquery.min.js
copying  jQuery UI (1.8.12)
identical  public/javascripts/jquery-ui.js
identical  public/javascripts/jquery-ui.min.js
copying  jQuery UJS adapter (0e7426)
remove  public/javascripts/rails.js
identical  public/javascripts/jquery_ujs.js
rake  bourbon:install
identical  public/stylesheets/sass/_bourbon.scss
Another migration is already named create_admin_notes: /Users/joemsak/code/[REDACTED]/db/migrate/20120103224147_create_admin_notes.rb
{13:40}[1.9.2@[REDACTED]]~/code/[REDACTED]:master ✗ ➭

This is probably related https://github.com/gregbell/active_admin/issues/414

Closing because I fixed it: https://github.com/gregbell/active_admin/issues/414#issuecomment-3495792


Pyspark support

Hello there,
I'd like to use this module and I think I have it loaded correctly, although I'm not sure the correct usage in pyspark. This definitely does not work:
import gov.llnl.spark.hdf
df = sqlContext.read.hdf5("foo.h5", "/dataset")

Can you clarify whether this module should work in pyspark and what the python version of the basic sqlContext example would be?
Incidentally, I'm using Spark 1.6.2 on a Horton works HDP 2.5 stack.
Thanks!

I don't have a pyspark cluster on hand to test on, but try the following:
from pyspark.sql import SQLContext
sqlContext = SQLContext(sc)

df = sqlContext.read.format('gov.llnl.spark.hdf').option(dataset='/dataset').load('foo.h5')

@joshuata thanks!
A slight modification of your line seems to be the ticket:
df = sqlContext.read.format('gov.llnl.spark.hdf').option('dataset','/windspeed_100m').load("hdfs:///user/cphillip/wtk/2012-01.h5")

Experiencing the same issue - did this ever get resolved?

I do not have hardware to test this on as I am no longer at LLNL, so I can only make educated hypothesis.
The code currently calls the JHDF open function which is likely not HDFS aware. The load function would have to be modified to access the file using the HDFS java interface.


Upgrade spring boot to newer version

Investigate how far we can go with upgrading spring boot without significant effort. Currently we have a really old version. But first do https://github.com/SSHOC/sshoc-marketplace-backend/issues/417 because otherwise we wont be able to go beyond 2.4.

This is not blocked anymore.


Epic 7: Splitting views.py and miscellaneous improvements

[ ] Quality of life changes to recipes and foods: (Bryce Nov16) #176

[ ] Incorporate recipes into logs: (Athena Nov16) #177

[ ] Recipe allergy/diet additions: (Michael Nov16) #179

[ ] UI revisions/ and cropping (Jalen Nov16) #180

[x] Add pie-chart in nutrifact page to visualize nutrition fact (Tsion) (Nov 16) #157

[x] Splitting views.py into three manageable pieces (finish before Wednesday the 11th)

[ ] Help work on issues brought up in comments and finish adding all remaining foods to database. (John) #188

Nutrition Helper Priorities from other group:
Bugs:

[ ] Recipe creation page should only be accessible to logged in users
[ ] Empty recipe search should return no results
[ ] 1.00 g in recipe creator should be changed to 1 unit
[ ] Deleting recipe from recipe list gives a forbidden error

CSS:

[ ] Signup page error messages shouldn’t be hard-to-see left-aligned black text
[ ] Create recipe page affects navbar font (fixed)
[ ] Update recipe page affects search bar
[ ] Add empty space under page content so it doesn’t look too abrupt


[Android] External views are broken on master

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
External views seem broken on master since https://github.com/flutter/flutter/commit/777192651705e8d64947c7d2f4be2b249e1af2b3
Expected results
FloatingActionButton is visible above external views
Actual results
FloatingActionButton is cut off
Code sample
Code sample
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

class ScreenTest extends StatefulWidget {
  const ScreenTest({super.key});

  @override
  State<ScreenTest> createState() => _ScreenTestState();
}

class _ScreenTestState extends State<ScreenTest> {

  static const CameraPosition _kGooglePlex = CameraPosition(
    target: LatLng(37.42796133580664, -122.085749655962),
    zoom: 14.4746,
  );

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      floatingActionButton: FloatingActionButton(onPressed: () {

      },),
      body: CustomScrollView(
        slivers: [SliverList(delegate: SliverChildBuilderDelegate(
            (context, index) {
              if (index == 8) {
                return SizedBox(
                  height: 100,
                  child: GoogleMap(
                      initialCameraPosition: _kGooglePlex,
                      onMapCreated: (GoogleMapController controller) {
                        print("onMapCreated mapId: ${controller.mapId}");
                      }
                  ),
                );
              }
              return SizedBox(
                  height: 100,
                  child: Placeholder());
            }
        ))],
      ),
    );
  }
}

  google_maps_flutter: 2.3.1

Screenshots or Video

Screenshots / Video demonstration
Upload media [here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[!] Flutter (Channel master, 3.14.0-12.0.pre.75, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.14.0-12.0.pre.75 on channel master at /Users/xuantung/Desktop/Develop/flutter/master/flutter
    ! Warning: `flutter` on your path resolves to /Users/xuantung/Desktop/Develop/flutter/3.3.10/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/xuantung/Desktop/Develop/flutter/master/flutter. Consider adding /Users/xuantung/Desktop/Develop/flutter/master/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/xuantung/Desktop/Develop/flutter/3.3.10/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/xuantung/Desktop/Develop/flutter/master/flutter. Consider adding /Users/xuantung/Desktop/Develop/flutter/master/flutter/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e6c7b84920 (62 minutes ago), 2023-08-28 21:29:15 -0400
    • Engine revision 1e821961e9
    • Dart version 3.2.0 (build 3.2.0-117.0.dev)
    • DevTools version 2.26.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/xuantung/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

Thanks for the report @XuanTung95
I tried the code sample using latest master (3.14.0-12.0.pre.78) on Pixel emulator and observed that the FAB gets cut off while scrolling up or down through the views as shown below:
https://github.com/flutter/flutter/assets/67046386/cadbb6aa-a68d-441e-902e-0bf2ba7ec484
While running the same scenario on latest stable seems to be working fine as FAB is rendered correctly.
https://github.com/flutter/flutter/assets/67046386/0bfee7ae-b4e5-45f9-9419-73e987fe18e4

 master flutter doctor -v

[!] Flutter (Channel master, 3.14.0-12.0.pre.78, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.14.0-12.0.pre.78 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6dae269881 (36 minutes ago), 2023-08-29 00:22:24 -0400
    • Engine revision c7c61ff973
    • Dart version 3.2.0 (build 3.2.0-118.0.dev)
    • DevTools version 2.26.2
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

@darshankawar can you confirm that this is fixed after https://github.com/flutter/engine/pull/45085 landed in the framework? Anything at ToT after https://github.com/flutter/flutter/pull/133298 ?

Actually I'll just try to repro it, the code is simple

This still reproduces at ToT.

This was fixed by the revert, @flar tells me there's no intention of relanding that patch anytime soon.


Superlogin Token and Password not valid credentials for Bluemix Cloudant

Hi, as I am still new to this so the problem is probably something simple but I just can't figure it for the past 3 days now.
Im using Superlogin in Ionic 2 with pouchDB. The server is deployed on Heroku (the config variables is my Cloudant details).
The login works and the session appears on the Cloudant website, but the token and password created by Superlogin does not allow me to access the Cloudent database from within the app (the error is 403. I get the same error if I try it from Postman with this token and password).
This is the login function:
this.db = new PouchDB('halaal');

 login(){

    let headers = new Headers();
    headers.append('Content-Type', 'application/json');
    headers.append( "Authorization", "Bearer {token}:{password}");

    let credentials = {
      username: this.username,
      password: this.password
    };

    this.http.post('https://slogin.herokuapp.com/auth/login', JSON.stringify(credentials), {headers: headers})
      .subscribe(res => {
       this.db.sync( res.json().userDBs.halaal);
        }
      }, (err) => {
        console.log(err);
      });
  }

The server code:
var express = require('express');
var path = require('path');
var favicon = require('serve-favicon');
var logger = require('morgan');
var bodyParser = require('body-parser');
var http = require('http');
var app = express();
var cors = require('cors');
var SuperLogin = require('superlogin');
var superloginConfig = require('./superlogin.config.js');

app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: false }));
app.use(cors());
// Redirect to https except on localhost
app.use(httpsRedirect);

app.use(express.static(path.join(__dirname, '../client/www')));
app.use(logger('dev'));

app.use(function(req, res, next) {
    res.header("Access-Control-Allow-Origin", "*");
    res.header('Access-Control-Allow-Methods', 'DELETE, PUT');
    res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With, Content-Type, Accept");
    next();
});

// load SuperLogin routes
var superlogin = new SuperLogin(superloginConfig);
app.use('/auth', superlogin.router);
superlogin.addUserDB("bilal","queryout","shared");

app.use('*', function(req, res) {
  res.sendFile('index.html', {root: path.join(__dirname, '../client/www')});
});

module.exports = app;

The superlogin.config.js code
console.log(__dirname);
module.exports = {
  security: {
    maxFailedLogins: 3,
    lockoutTime: 600,
    tokenLife: 86400,
    loginOnRegistration: true,
    defaultRoles: ['user']
  },
  dbServer: {
    protocol: process.env.DB_HOST ? 'https://' : 'http://',
    host: process.env.DB_HOST || 'localhost:5984',
    user: process.env.DB_USER,
    password: process.env.DB_PASS,
    // automatically detect if the host is Cloudant
    cloudant: process.env.DB_HOST && process.env.DB_HOST.search(/\.cloudant\.com$/) > -1,
    userDB: 'sl-users',
    couchAuthDB: '_users'
  },
   userDBs: {
    defaultDBs: {
      shared: ['halaal','queryin']
    },
    model: {
      halaal: {
        permissions: ['_reader'],
        type: 'shared'
      },
      queryin: {
        permissions: ['_writer'],
        type: 'shared'
      },
      queryout: {
        permissions: ['_writer','_reader','_replicator'],
        type: 'shared'
      }
    }
  }
  }
};

This is really more a stackoverflow question than a concrete issue?
I would recommend comparing your code (and network traffic) with the superlogin-demo and/or the superlogin-client code.
I also think you could simplify your example, to make it an easier to understand. For example the config for social login providers and the custom Redis config.

Am not sure about this
headers.append( "Authorization", "Bearer {token}:{password}");
Where are you token and password getting their values from?

I dont think you should enable authorization for login since one of the reasons for login is to get authorization
You can check your server code and remove this part that requires authorization on login
"superlogin.requireAuth"
if you need to set authorization header in other part of your app, You can set authorization header like this
headers.append( "Authorization", Bearer ${details.token}:${details.password});
I am assuming the details object contain token and password field: the details might be a return value from register or login routes

Seems this was a Cloudant issue, the code I posted does work. I recreated the DBs on Cloudant and everything worked. Thanks so much


Switch to waitress?

This will solve the problem with gunicorn (but I think you don't need gunicorn to do manage.py runserver).

For now, let's do manage.py runserver.


[NEMO-421] Release v0.2

JIRA: NEMO-421: Release v0.2
Major changes:

Update the versions of components according to the release v0.2.

Minor changes to note:

N/A

Tests for the changes:

N/A

Other comments:

I'll open a release vote current version.  If it passed, I'll update the versions to 0.3-SNAPSHOT and merge this PR. Please do not merge any other PR before the vote. Thanks :)

Closes #421

The branch release-v0.2-rc2 diverged from our master. I'll reopen with rc3.


add appid= override to CLI tools

Folks like @joeyh are writing tools that run wormhole as a sub-process. These tools should use a different APPID than the normal text/file/directory-transfer feature that wormhole send provides, because there's no meaningful interoperability between a human running wormhole send MYFILE and a human running one of those other tools. Distinct APPID values will give them distinct wormhole-code namespaces, so they won't be contending for short channelids.
We need to add a CLI argument to let these subprocess-based applications override the default APPID. This means a new argument to wormhole.cli.cli.CommonArgs, and additional code in wormhole.cli.cmd_send.Sender (and cmd_receive.TwistedReceiver) to use it. Click, our argument-parser, makes it easy to use an environment variable too, which might be easier for some front-end tools.
The experimental wormhole ssh subcommand does this, but it creates the Wormhole object directly (via wormhole.xfer_util), rather than invoking wormhole send as a subprocess.

Working on this in the 113-appid-override branch. I think I'm going to omit the environment-variable option for now, since really you want this to fail hard if the wormhole executable you're running doesn't have this override feature. Adding --appid=FOO will throw an unknown-argument error in 0.8.2 or older, but merely setting WORMHOLE_APPID=FOO as an environment variable would just be silently ignored.


CLI uninstall instructions

Describe the bug
I installed Kubeshark using the curl method. I will have to reverse engineer the installation just to know what to delete. I would like this to be documented somewhere. I searched for it in this repository but I couldn't find it.
Desktop (please complete the following information):

OS: macOS

The shell script at https://kubeshark.co/install just downloads the correct binary from the latest release that matches your OS and CPU architecture and places at /usr/local/bin/kubeshark.
$ sh <(curl -Ls https://kubeshark.co/install)

🦈  Started to download Kubeshark
######################################################################################################################################################################################################################################################## 100.0%

⬇  Kubeshark is downloaded into /home/mertyildiran/Downloads/kubeshark
Do you want to install system-wide? Requires sudo 😇 (y/N)? y
[sudo] password for mertyildiran:
Kubeshark is installed into /usr/local/bin/kubeshark

✅ You can use the  ks  command now.

Please give us a star 🌟 on https://github.com/kubeshark/kubeshark if you ❤  Kubeshark!

As can be seen from the output of the shell script above, it's printing the installation path /usr/local/bin/kubeshark to inform the user. which kubeshark would also reveal this path. So, it does not require reverse engineering to understand the installation path.
If it's installed with sudo
sudo rm /usr/local/bin/kubeshark removes the kubeshark binary from that location and automatically from the $PATH
If it's installed without sudo
The kubeshark binary is placed into the current working directory and can be removed with rm ./kubeshark.


Update to SDK v2.0

Partially fixed in PR #23.  Some issues remain with the "enterprise" profile mvn -Penterprise clean package which I'm working through now.


Support of Schema properties in ts-to-core-types

Before anything: Great work! I'm using typeconv in some of my projects and I found it extremely useful.
However, AFAIU, the ts-to-core-types.ts module only supports a few schema properties when converting from jsDoc comment tags (e.g.  example, see, default).
It would be great if it can also support all of the properties defined in OpenAPI3 Schema Object.
Example:
interface WorkingPerson {
  /**
   * @format uuid
   */
  uuid: string;
  /**
   * @format int32
   * @maximum 70
   * @minimum 5
   * @deprecated true
   */
  age: number;
}

As an exercise, I altered this project allowing the use of unlimited "custom" jsDoc tags, however I stopped when I realized that the allowed properties are kind a hard coded in other projects too (i.e. core-types interface CoreTypeAnnotations).
So my question is: Is there a reason for this?

I'm not sure how other systems would treat unknown such tags, so I limited it to what is known (e.g. jsdoc: https://jsdoc.app/). If there's a standard out there for annotating schema constraints (format, maximum, etc as you described) in jsdoc, I'm happy to add it.
Your example, in typescript; it would be fine to create such an object with age = 80, no editor/linter/compiler would pick that up and complain that age is above maximum, since that tag is not standard but "made up".
@deprecated in your case, should probably not have a value true but (if anything) an explanation, see https://jsdoc.app/tags-deprecated.html
I'm not against this, will just need to consider if there is previous work around this topic to piggy-back on (aligning json schema constraints with jsdoc tags specifically).


TestReadRotatedLog fails on windows

Description
=== RUN   TestReadRotatedLog
    cri_logger_test.go:285: failed to rotate log "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\TestReadRotatedLog3469684812\\001\\logfile2318891333" to "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\TestReadRotatedLog3469684812\\001\\logfile2318891333.1620241016-014354", error: rename C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatedLog3469684812\001\logfile2318891333 C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatedLog3469684812\001\logfile2318891333.1620241016-014354: The process cannot access the file because it is being used by another process.
    testing.go:1232: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatedLog3469684812\001\logfile2318891333: The process cannot access the file because it is being used by another process.
--- FAIL: TestReadRotatedLog (2.05s)

Steps to reproduce the issue
Run unit tests for windows.
Describe the results you received and expected
This does not seem like a non-compatible test, but rather an actual issue?
I'll skip the test for the time being so that we can enable unit tests for windows, but this should be looked into?
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

it seems like the file is note closed here correctly

@fahedouch would you claim dibs on this?
Pretty sure a fix on this would significantly improve windows logs stability.


Can't set ShadowCredentials if the target already has one

The first run goes fine, then, re-running it, shows Insuffient Access.

Then, flushing it and rerunning, goes smooth again:

Is it possible to add a method to flush the attribute if not empty?
Cheers!

You can already flush the attribute easily with:
bloodyAD -d ace.local -c :administrator.pem --host dc.ace.local setShadowCredentials 'dc$' False

And if you want to remove a specific key:
bloodyAD -d ace.local -c :administrator.pem --host dc.ace.local setShadowCredentials 'dc$' False "" 0e23749e-ca12-b96c-197d-40c381c71852

Also I would be curious to have the output (in a text file) of:
bloodyAD -d ace.local -c :administrator.pem --host dc.ace.local getObjectAttributes 'dc$' nTSecurityDescriptor True

And the number of keys contained in the attribute:
bloodyAD -d ace.local -c :administrator.pem --host dc.ace.local getObjectAttributes 'dc$' msDS-KeyCredentialLink

Because right now, I don't see why you can't add a new key using the modify LDAP function and have to delete all the keys first using the modify LDAP function because it's using the same right. My guess is that you have too much keys registered or you can't have more than one key per user.

Oh, my bad for the dumb question and thanks a lot for the quick answer.
As for the settings, it's a newly built lab so everything is default and I've always assumed the max for each user is only one key, thus the need to flush it before creating a new one.

Not dumb at all, this issue will help me remember you can only have one key per user ;)
Moreover, I know that the command line of bloodyAD is not always as intuitive as I would like it to be. If you have some suggestions I'm more than open to hear them!

Probably adding few more examples in the readme will be enough, I guess.
I'm closing as solved, thank you!


Cupertino text fields don't display emoji keyboard

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Add the emoji keyboard in Android (Pixel 6 - Android 13)
Go to any app that includes text field widget provided in the code section (similar to https://gallery.flutter.dev/#/demo/text-field )
Go to the cupertino text field
Check that the emoji keyboard is not availble

Note: in iPhone it's working as expected
Expected results
The emoji keyboard should be available for Cupertino text field
Actual results
The emoji keyboard is not available for Cupertino text field
Code sample
Code sample
This is the widget I’m using in Flutter:
class MaterialTextFieldView extends StatelessWidget {
  const MaterialTextFieldView({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: const Text('Text fields'),
      ),
      body: const SingleChildScrollView(
        padding: EdgeInsets.symmetric(
          horizontal: 24,
          vertical: 16,
        ),
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            TextField(
              decoration: InputDecoration(
                labelText: 'Left to right',
              ),
            ),
            SizedBox(height: 48),
            TextField(
              decoration: InputDecoration(
                labelText: 'Right to left',
              ),
              textDirection: TextDirection.rtl,
            ),
            SizedBox(height: 48),
            TextField(
              maxLines: 2,
              decoration: InputDecoration(labelText: 'Max lines (2)'),
              textDirection: TextDirection.ltr,
            ),
            SizedBox(height: 48),
            PasswordTextField(),
            SizedBox(height: 48),
            PhoneNumberTextField(),
            SizedBox(height: 48),
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
Left to right cupertino text field:

Multiple lines cupertino text field (expected behavior)

Logs
Logs
Not applicable

Flutter Doctor output
Doctor output
[✓] Flutter (Channel master, 3.15.0-6.0.pre.41, on macOS 13.5 22G74
    darwin-arm64, locale en-US)
    • Flutter version 3.15.0-6.0.pre.41 on channel master at
      /Users/diegogawenda/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 76a938bfa6 (4 hours ago), 2023-09-22 11:23:14 -0700
    • Engine revision ef9ceed1af
    • Dart version 3.2.0 (build 3.2.0-190.0.dev)
    • DevTools version 2.28.0-dev.12

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/diegogawenda/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/diegogawenda/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/diegogawenda/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.72.0

[✓] Connected device (3 available)
    • Somnio’s iPhone (mobile) • 00008120-001168D83C87C01E • ios            •
      iOS 17.0.1 21A340
    • macOS (desktop)          • macos                     • darwin-arm64   •
      macOS 13.5 22G74 darwin-arm64
    • Chrome (web)             • chrome                    • web-javascript •
      Google Chrome 117.0.5938.92

[✓] Network resources
    • All expected network resources are available.

@gmackall I'm using the "emoji keyboard" that comes by default with Pixel 6 (Android 14). I didn't add any specific emoji keyboard besides that.

The emoji button on the keyboard has disappeared. He is investigating the reason. Does anyone have a solution for a similar problem?


Running Baselines on Windows

Hi
I cloned the repository on Windows (I had to remove Atari dependency from setup file).
Now when I try to run codes (DDPG, PPO), I get the following error:
Traceback (most recent call last):   File "main.py", line 10, in <module>     import baselines.ddpg.training as training   File "e:\baselines\baselines\ddpg\training.py", line 6, in < module>     from baselines.ddpg.ddpg import DDPG   File "e:\baselines\baselines\ddpg\ddpg.py", line 9, in <modu le>     from baselines.common.mpi_adam import MpiAdam   File "e:\baselines\baselines\common\mpi_adam.py", line 1, in  <module>     from mpi4py import MPI ImportError: DLL load failed: The specified module could not be found.
Any ideas how to solve this?

Never mind this link helped me:
https://bitbucket.org/mpi4py/mpi4py/issues/67/from-mpi4py-import-mpi-dont-work


{ARM} az deployment: Modify aux_subscription to be generic one in cross tenant case

Description

Modify aux_subscription to be generic one in cross tenant case.

Let’s use Azure CLI Tests with TTL = 2 Days(1c638cf4-608f-4ee6-b680-c329e824c3a8) for cross tenant cases from now on.
We will use this subscription for all cross tenant case, and it will help Feiyue’s live test go through all these cases.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

add to S172

/azp run


implement a flying-squid like project structure

one where we can create new features in a folder then they will be automatically grabbed and injected and where we can implement a basic plugin API

it's basically about having that https://github.com/PrismarineJS/flying-squid/blob/master/src/index.js#L35

done


Us050d change response status to no longer required

Simply had to add no longer required status to the status mapper and the allowed status changes
Works with PR in case service
rm-case-service
Trello
Confluence

Codecov Report

Merging #157 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   95.53%   95.63%   +0.09%
==========================================
  Files          35       35
  Lines        1680     1672       -8
==========================================
- Hits         1605     1599       -6
+ Misses         75       73       -2

Impacted Files
Coverage Δ

...ponse_operations_ui/controllers/case_controller.py
96.82% <ø> (ø)
:arrow_up:

response_operations_ui/common/mappers.py
100% <100%> (+8%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd5c5a...e618c5c. Read the comment docs.

 US050d: INT Manually change the response status for a given RU, Survey, CE to No Longer Required (L)


Potion bug

Potions are called: Water Bottles not the name of the potion

When does it happen for you? In survival? Creative?


API

Cool project!
Is it planned to have an API with which you can create Notes?

The backend, therefore the API, is only a store for encrypted messages. It has no notion of the actual crypto. going on. Basically it's a glorified string storage.
The encryption happens in the client itself, which would make the API kind of useless. There is a CLI client https://github.com/cupcakearmy/cryptgeon?tab=readme-ov-file#cli.


minimise contents of NPM package

PS: This branch should be refactor/ or chore/ as it's not a feature branch.

package.json definitely needs to be included in the NPM package

Removed package.json from npmignore.


API - to pull images from docker registry / kubernetes  in Rancher UI.

Hello,
I ma trying to find an API in github code for Rancher-Cattle.
I want the API logic where the images are pulled from the docker or kubernetes in rancher.
I want to know whether there are existing APIs which can just the pull images from one server host to other server. (From one account to rancher)?
Or is there any mediator which does the job.
Please provide me understandings where API is written for the pulling images from one account.
Authentication done to do so and login handling.
I am working on an application which demands me to pull images and push images from accounts like docker hub account.
So, I am searching for readymade APIs which does this job.
Please provide me the thread to do so.
Thank you.
Your help will be highly appreciated.

For Cattle I would say:
https://github.com/rancher/cattle/blob/060bd6b0104a21ea7221ea5ad17d5696fdb26a29/code/implementation/docker/compute/src/main/java/io/cattle/platform/docker/process/instance/DockerInstancePreCreate.java#L53 and https://github.com/rancher/cattle/blob/ccb4ee49ca93ac29cd26fc204fb9e113ed024c11/code/implementation/docker/storage/src/main/java/io/cattle/platform/docker/storage/dao/impl/DockerStorageDaoImpl.java#L30.
Hope this helps!


[Ubuntu] Increase Linux stack space to 16384KB

Description
Increases the Linux stack space from kernel default of 8192KB to 16384KB.

Related issue: #3257
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

@robburger , Thank you for contribution!


Zero-shot classification of ScanObjectNN

Thanks for your amazing work! I was trying to run zero-shot classification of ScanObjectNN using the pipeline you provided. However, I only got 29.78% accuracy for the OBJ_ONLY variation (50.09% reported in the paper) using the following script:
python main.py \
--trainer PointCLIPV2_ZS \
--dataset-config-file configs/datasets/scanobjectnn.yaml \
--config-file configs/trainers/PointCLIPV2_ZS/rn50.yaml \
--output-dir output/PointCLIPV2_ZS/rn50/scanobjectnn \
--no-train \
--zero-shot \
--test-file=data/scanobjectnn/main_split_nobg/test_objectdataset.h5  > obj_only_mainnobg.log

The test-file argument specifies which variation to use. Am I missing something here? Thank you!

Sorry for the late reply.
Actually, the main backbone we use is the vit_b16 visual encoder, which achieves a higher accuracy than rn50 backbone. So you can try change the config file to vit_b16.yaml.
And thanks for your attention.


Implement nats streaming

I also see there are other metrics like per channel, per subscription, storez etc. Do we need to collect them too?

I add metrics for per channels. route, connecton


Solo & clear solo function x32/m32

Is it possible to make an solo function , there is allready an select function, but I miss the solo (and function 2: clear solo)
thanx!

Looking into it, will need to test on the X32 at my church though

Available in the latest beta


Error "The provided signer is not required to sign this transaction." will be thrown due to bad equality check

From src/Transaction.ts
const maxSigners = transaction.message.header.numRequiredSignatures;
  const signerPublicKeys = transaction.message.accounts.slice(0, maxSigners);
  const signerIndex = signerPublicKeys.findIndex(
    (key) => key === signerPublicKey
  );

  if (signerIndex < 0) {
    throw new Error(
      'The provided signer is not required to sign this transaction.'
    );
  }

Taking a look at the findIndex, in my testing the signerPublicKeys consists of strings while the signerPublicKey is a publicKey object. Therefore when doing an equality check it will always return false, to fix this we need to add .toString() on the methods
const signerIndex = signerPublicKeys.findIndex(
    (key) => key.toString() === signerPublicKey.toString()
  );

Hi there, I'm confused about this issue. In Umi, PublicKeys are simple strings. Therefore this equality checks should always work. Are you perhaps feeding Umi with legacy web3.js PublicKey classes?

Oh, that could be the issue, didn't find a native key pair type

Is this what you are looking for?
https://github.com/metaplex-foundation/umi/blob/main/docs/publickeys-signers.md#keypairs

Oh, thanks


Block/unblock users name and description are ambiguous

The "Block/unblock users" section name and description are ambiguous. These imply blocking or unblocking user sign-in attempts in general. In reality, they only disable MFA per blocked user.
Proposed improvements are:
Step 1: Change the description from "A blocked user will not receive multifactor authentication requests. Authentication attempts for that user will be automatically denied. A user will remain blocked for 90 days from the time they are blocked." to "A blocked user will not receive multifactor authentication requests. The user will not be challenged with multifactor authentication for 90 days from the time they are blocked."
Step 2: Change the section name from "Block/unblock users" to "Disable/enable MFA for users". Change the description from "A blocked user will not receive multifactor authentication requests. The user will not be challenged with multifactor authentication for 90 days from the time they are blocked." to "An MFA disabled user will not receive multifactor authentication requests for 90 days."

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 84b26750-880c-8f14-1628-436293de915e
Version Independent ID: 518b727f-79e8-b5c2-bcb3-ff4de3444c6f
Content: Configure Microsoft Entra multifactor authentication - Microsoft Entra ID
Content Source: docs/identity/authentication/howto-mfa-mfasettings.md
Service: entra-id
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@Moodjbow
Thanks for your feedback! We will investigate and update as appropriate.

@Moodjbow
Thank you for bringing this to our attention.
I've delegated this to content author @Justinha, who will review it and offer their insightful opinions.

@Justinha
Could you please review add comments on this, update as appropriate.


Upgrade to JSCS 2.0

Upgrade to<EMAIL_ADDRESS>for JSCS 2.0 support
Fix test example code for require-space-after-keywords rule:

The new parser requires wrapping the example return statement in a
function.

Update the require-object-destructuring rule:

Remove the exception made to get and set as the
issue has been
resolved in the Esprima version that JSCS now uses.

Closes #49.

Remove the exception made to get and set as the issue has been resolved in the Esprima version that JSCS now uses.

Awesome! :tada:

Should be releasing 2.1.0 next week - also esnext now uses babel-jscs (babel) http://jscs.info/overview.html#esnext instead of esprima - if you still want esprima you can just remove the esnext option which would use esprima 2.5.0

@hzoo Thanks for the clarification!


19.1 Geo IP blocking

Is this supposed to work yet or is it still WIP? Had to 11.2 to 18.7.5_1 to restore Geo Blocking.

IPS or Alias?

Alias.. Strange things happen. For example Germany was missing from Europe for a while - most worrying, I did check that it hadn't moved continent but it was no-where to be found. I exited the Geo Aliases and came back to it and it had magically re-appeared. If I select everything, then a 'timed-out' error occurs. If I reverse the logic and set only countries I wish to allow and then that error no longer occurs but in either case no geo-blocking happens. Difficult to test this as obviously I need my live system to work correctly. I'm running up my test unit with 19.1 and the same config as my live unit, then I'll see if there is anything obvious.

I don't understand "11.2 to 18.7.5_1". 19.1 is 11.2 with 18.7.5_1. There should be no issue. Alias API is for 18.7.6 and I don't think the kernel on 11.2 has an issue either.

PS: @marjohn56 I tested your config against soon to be 18.7.6 and it works fine now so that's not it.

No, as I said, really really weird, and I had NOT been drinking. Note I switched to Dev and and then did a code core and upgrade, it's working fine for me when using the installation media you provided. Only when I did the code core and upgrade did I hit issues.


About freq_decompose

Hi，the paper provides a novel analysis of the low-pass filtering of Transformers self-attention matrix from the frequency domain and includes extensive visualization.I have some questions about freq_decompose.
featscale.py 42-45
def freq_decompose(self, x):
x_d = torch.mean(x, -2, keepdim=True) # [bs, 1, dim]
x_h = x - x_d # high freq [bs, len, dim]
return x_d, x_h
when decompose the self-attention matrix,I have not found any code about frequency domain transforming，such as torch.FFT or DFT matrix.The process of freq_decompose is still on image space but can realize the decompose of DC and high component,or I miss the code of the frequency domain transforming?
Thank you!

Hi,
Thanks for your interest. You are right. Although the freq_decompose function is implemented on the image space, it realizes Fourier domain operations. It is noteworthy that the DC component of signals is simply the mean of the whole signal. So you don't need to run Fourier transform to extract this information. Nevertheless, if you consider a more complicated Fourier analysis, you may need torch.FFT then.
Best,
Peihao


[CSL-215] Implement P2PKH addresses

@flyingleafe
Draft spec of them is decribed here: https://docs.google.com/document/d/1PKiRVYiJe8rKW78hUc59EFA9qWP2juPsGkXP2DJcjCg/edit#heading=h.nrpa0epx3rph
Basically, what should be done is:

alter Address datatype in such a way that instead of simply containing pubkey it contains hash of it; also, its Binary instance should automatically add version and crc32 to representation, and its Show and Buildable instances should encode/decode it to/from base58 while representing it.
store pubkey in TxIn rather than in TxOut
in order to simplify future introduction of P2SH addresses, generalize pubkey and signature in TxIn as Validator and Redeemer types.
change SlotLeaders from NonEmpty PublicKey to NonEmpty Address
alter procedure of checking if node is leader - node should calculate its own address to match it with leader address

However, there is the concern regarding participating of P2SH addresses in leader selection. It is described in the above document.
But anyway, it shouldn't anyhow interfere with current task.

@flyingleafe
I have increased the estimation because I realized what changing of verification procedure requires cascading changes in tests and etc. There's a plenty of code to rewrite.


What is the  property for FirstInteractive?

There is an example in the guide that shows we can add event listeners directly to the  element via properties:
<tableau-viz id="tableauViz"
      src="http://my-server/views/my-workbook/my-view"
      onMarksSelected="handleMarksSelection">
</tableau-viz>

Two questions:

Is this functionality working? I see no where in the source code where "onMarksSelected" exists, so that's why I ask.
What is (or will be) the equivalent of "FirstInteractive"?

Hi @kbrown-blend360
Thank you for opening this issue.

This functionality is not working today but should be available in the upcoming releases (v3.2 or v3.3)
Here an example for "FirstInteractive":

Is there a way with the "embedding api v3" to include FirstInteractive functions after the viz is initialized?  or do we have to wait until v3.2 or v3.3 comes out?   We are looking to use connected apps but without this functionality we can't proceed.

Hi @jontom33 - You can add event listeners such as FirstInteractive after initialization in v3.0: https://help.tableau.com/current/api/embedding_api/en-us/docs/embedding_api_event.html


last commit date not updating automatically

the last commit date should be updated after every S&R, however it's not getting updated.

The ProxyEventsService has an OnHgRequest method that's supposed to be doing this update when it sees an hg unbundle command go to hgweb. We'd need to check if it's actually running, and if so, if it's perhaps running too soon, before the hgweb container has actually finished processing the unbundle and created the new commit.


Add CheckboxButton component

Implement CheckboxButton component according to https://lightningdesignsystem.com/components/checkbox-button/

I am working on this and will soon update with the props proposal.

Is there anything you need from me for the props proposal?
I believe that it would be very close to the checkbox props, but feel free to make it a much smaller subset.


Idea: Refactor qiskit_to_tk and tk_to_qiskit

The qiskit_to_tk and tk_to_qiskit converters are a frequent source of bug reports and feature requests from users. I suspect for a significant number of people these converters are their first exposure to using pytket and related libraries.
The code for doing the conversion is old and has been patched together over time. Its now about 1000 lines of untidy python. I think it could make the code simpler and more maintainable if we rethink/refactor the converters perhaps splitting out some of the compilcated case handling into separate internal functions.
I think this would save us time in the long run when addressing bugs and feature requests from users. May also make it easier for new contributors to make PRs.
A couple of thoughts...

pytket and extensions now support python 3.10, 3.11 and 3.12. This could allow us to make use of structural pattern matching (introduced in 3.10) in the circuit parsers.
I think having circuit converters which handle higher level circuit boxes is valuable as it allows easier (and fairer) side by side benchmarking of pytket vs qiskit. Also it allows qiskit users to try out pytket with less hassle. One could of course trivially just convert a pytket circuit to a qiskit circuit by exporting to and from QASM but this translation would be very lossy and remove abstractions which can be useful for the compiler. Handling more ops also expands the range of circuits we can run on the idealised AerBackend simulator.

Closed this for now as I don't have any plans for imporving this code more in the immediate future beyond the changes in #382 and #391. However theres still a lot of untidy conversion code especially in the tk_to_qiskit direction.
Maybe worth coming back to this at some point.


implemented counting sort

#issue6
Fixes #6
Language: Java

Use .gitigonre to ignore .idea from the commit.


Incorrect sprite for bread when in microwave

Description
When placed in the microwave, bread uses the empty plate sprite, or the bread is missing.
Screenshots

Additional context
v0.1

The first question why you get bread and a plate not only plate

Not really a bug since it's how the menu is designed.
https://github.com/space-wizards/space-station-14/blob/1508efff5410aa187e00a960021930295fbd9f0e/Content.Client/Kitchen/UI/MicrowaveBoundUserInterface.cs#L123
It only takes a texture when the bread is a sprite with layers, the bread and the plate.

Not really a bug since it's how the menu is designed.

Its not rendering multilayer items when it should. Fits the definition of a bug in my book.
That being said, this should probably use the control we already have to render sprites of entities (p sure its being used in the characterwindow for example)

Yes, the issue here is that ItemList only accepts a texture. It has to be refactored to allow RSI layers.

i am pretty sure this is fixed


small change

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] The code follows the code style and conventions of this project.
[ ] The change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

Description of the change
Flyout closes when we click on the cancel button.
Boolean is removed from deviceTag and reconfigure.
Instead of 'int' made 'number'.
...
Motivation for the change

...

@swetha571,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Should log_prob_grad be recovering memory?

Summary:
For log_prob_grad should we be recovering memory both when the function exits and when the function leaves normally? Right now it's only recovering memory when there's an exception
Description:
This
template <bool propto, bool jacobian_adjust_transform, class M>
double log_prob_grad(const M& model, Eigen::VectorXd& params_r,
                     Eigen::VectorXd& gradient, std::ostream* msgs = 0) {
  using stan::math::var;
  using std::vector;

  Eigen::Matrix<var, Eigen::Dynamic, 1> ad_params_r(params_r.size());
  for (size_t i = 0; i < model.num_params_r(); ++i) {
    stan::math::var var_i(params_r[i]);
    ad_params_r[i] = var_i;
  }
  try {
    var adLogProb = model.template log_prob<propto, jacobian_adjust_transform>(
        ad_params_r, msgs);
    double val = adLogProb.val();
    stan::math::grad(adLogProb, ad_params_r, gradient);
    return val;
  } catch (std::exception& ex) {
    stan::math::recover_memory();
    throw;
  }
}

Should be
template <bool propto, bool jacobian_adjust_transform, class M>
double log_prob_grad(const M& model, Eigen::VectorXd& params_r,
                     Eigen::VectorXd& gradient, std::ostream* msgs = 0) {
  using stan::math::var;
  using std::vector;

  Eigen::Matrix<var, Eigen::Dynamic, 1> ad_params_r(params_r.size());
  for (size_t i = 0; i < model.num_params_r(); ++i) {
    stan::math::var var_i(params_r[i]);
    ad_params_r[i] = var_i;
  }
  try {
    var adLogProb = model.template log_prob<propto, jacobian_adjust_transform>(
        ad_params_r, msgs);
    double val = adLogProb.val();
    stan::math::grad(adLogProb, ad_params_r, gradient);
    return val;
  } catch (std::exception& ex) {
    stan::math::recover_memory();
    throw;
  }
  stan::math::recover_memory()
}

Current Version:
v2.23.0

Recovery of memory should be just before the return inside the try block. Even better would be to return Val after the try block to avoid try blocks being recursively being nested.

Yes!  Good catch.
The catch clause should also be just catch (...) to catch arbitrary exceptions.  We want to clean up memory no matter how we throw.

  B;
  throw ...;
}
B;

If we use the nested approach based on RAII, then we don't need to bother with the exception stuff any more. We should search the entire stan repo for this pattern and replace it with the nested_rev approach which takes care of all of this.

Is there noticeable overhead to having everything be nested? Or should we make a little class that handles the memory recovery for us like nested has?
Either way I'll submit a PR today to add recover memory here

I don’t think nested is an issue performance wise.

For now I just added the recover_memory but we can benchmark nested to make sure it's fine here

but we can benchmark nested to make sure it's fine here

Ooops, was that pull waiting on another test? It looked finished over there.


Dotenv.load/overload defaults to only .env

It seems that Dotenv.load and Dotenv.overload defaults to using just .env - I would expect it to use the same: .env -> .env.#{Rails.env} -> .env.local defaults
See these line
 def self.with(*filenames, &block)
    filenames << '.env' if filenames.empty?

I would want this to include .env.local and .env.#{Rails.env} - I know I can pass it, but I assume that is the default anyhow. I don't mind making the Pull Request if that is the desired behavior for the gem

Both .load and .overload only ready from .env by default. Here is the Rails integration that loads multiple files. If you need anything more than that, I would just recommend using dotenv and not dotenv-rails and loading things manually.

Sorry, here' is the rails configuration: https://github.com/bkeepers/dotenv/blob/master/lib/dotenv/rails.rb#L27-L31

How about just a mention of this in the README, it is very confusing.


Make it consistent

@ljharb you might be interested to know that this is the result of running all code inside our markdown through eslint (after disabling some rules that arguably don't really apply to code snippets)

so do we really want to fix these 6 semicolons but ignore the other +900 deviations from the style guide?

Let's fix one rule at a time, but yes, they should all be fixed.
It'd be great to add this check to the tests, so that incorrect code can be kept out of examples in the first place.

@ljharb its trivial to add this check, the problem is we can't add this check without first fixing all existing errors

If you can point me to a branch I can take a look at that.

here it is https://github.com/airbnb/enzyme/compare/eslint-markdown?expand=1
I've disabled some rules that arguably don't make too much sense for snippets (bringing the errors down to ~500)

one thing to bear in mind is that eslint-plugin-markdown does not support eslint --fix so any fixes will either be manual or require some custom code

Thanks, I'll do it manually this weekend; I can fix 500 eslint errors manually with my eyes closed :-p

eheh good luck :)


Fix clasp login error

This accidentally closes the server before the user can confirm the login.
Signed-off-by: campionfellin<EMAIL_ADDRESS>
[ ] npm run test succeeds.
[x] npm run lint succeeds.
[ ] Appropriate changes to README are included in PR.

Coverage increased (+0.01%) to 24.675% when pulling 9bf43591b47123ae154b1ba15d257a17ea9a2ab8 on login-quickfix into c8f85764649eed10a7b39c943b42f959820dd5a9 on master.


Unable to create an InstanceTemplate with the namePrefix property set

The following code block is provided in the InstanceTempate.ts file:
const instanceTemplate = new gcp.compute.InstanceTemplate("instanceTemplate", {
    // boot disk
    disks: [{
        sourceImage: "debian-cloud/debian-9",
    }],
    machineType: "n1-standard-1",
    namePrefix: "instance-template-",
    region: "us-central1",
});

but fails on creation with the following error:
Diagnostics:
  gcp:compute:InstanceTemplate (instanceTemplate):
    error: gcp:compute/instanceTemplate:InstanceTemplate resource 'instanceTemplate' has a problem: "name": conflicts with name_prefix

The Terraform documentation states that the name and name_prefix arguments are optional but it appears that the name argument is mandatory on the Pulumi side.

Seems to be a similar/related issue to https://github.com/pulumi/pulumi-aws/issues/143.

This was because name_prefix wasn't marked as conflicting with name.
https://github.com/terraform-providers/terraform-provider-google-beta/pull/1202

For what it's worth, name is marked as conflicting with name_prefix, which provides the same experience on the command line - consider changing your tool to understand that dependency in both directions.

Ok, this will be included in the v1.3.0 release that is pending :)

I just got this trying out pulumi, I am using this file straight from the documentation (with update to match the new syntax):
import * as gcp from "@pulumi/gcp";

const instanceTemplate = new gcp.compute.InstanceTemplate("instanceTemplate", {
    namePrefix: "instance-template-",
    machineType: "e2-medium",
    region: "us-central1",
    disks: [{}],
    networkInterfaces: [{}],
});
const instanceGroupManager = new gcp.compute.InstanceGroupManager("instanceGroupManager", {
    versions: [
      {
        name: "primary",
        instanceTemplate: instanceTemplate.id,
      }
    ],

    baseInstanceName: "instance-group-manager",
    zone: "us-central1-f",
    targetSize: 1,
});

and I get this:
Diagnostics:
  gcp:compute:InstanceTemplate (instanceTemplate):
    error: gcp:compute/instanceTemplate:InstanceTemplate resource 'instanceTemplate' has a problem: ConflictsWith: "name": conflicts with name_prefix. Examine values at 'InstanceTemplate.Name'.

I thought I was using an old version but I am using pulumi 3.9.1 and the latest pulumi-gcp package:
{
    "name": "test-project",
    "devDependencies": {
        "@types/node": "^10.0.0"
    },
    "dependencies": {
        "@pulumi/gcp": "^5.14.0",
        "@pulumi/pulumi": "^3.0.0"
    }
}


Unlimited number of objects per AD domain

Hello Folks,
I noted that below that Cloud sync does not have support for an 'Unlimited number of objects per AD domain' I cannot find what the limit currently but I'd recommend that it is added as a known limitation in this article.
https://docs.microsoft.com/en-us/azure/active-directory/cloud-sync/what-is-cloud-sync
Thank you for your help.
Br.
Joshua
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d513d77-4a6d-3032-bb45-4a813a1db4da
Version Independent ID: 47a2b665-91a4-1529-0304-7d20a07db409
Content: Prerequisites for Azure AD Connect cloud sync in Azure AD
Content Source: articles/active-directory/cloud-sync/how-to-prerequisites.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @JBines , Cloud sync supports 150,000 objects per AD domain per the following table:  https://docs.microsoft.com/en-us/azure/active-directory/cloud-sync/what-is-cloud-sync#comparison-between-azure-ad-connect-and-cloud-sync
Hope this helps,
James

Great 👍 thanks for the information I think I won't be the only one to find that useful ☺
B
J


Popover does not work with NG2 Dependency injection rules

Ionic version:  (check one with "x")
[ ] 1.x
[X ] 2.x
I'm submitting a ...  (check one with "x")
[X] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
I create a singleton service. This service correctly works as a singleton across all pages. When I use popover to open a page that this service is injected in the constructor a new instance of the service is created
Expected behavior:
The singleton service had to be present on the page that I open with popover
Steps to reproduce:

I created the starter tabs project: ionic start -v2 tabstest tabs
Create a TestService and add it to the providers of the app.component.ts
Inject that service in the constructor of two pages (home, about) (Just in the constructor no providers attr on these pages).
Open both pages and correctly see that the service in injected as a singleton
Now try to open the about page using PopOver component.
You can see now that a new instance of the TestService is created whenever the about is opened using PopOver.

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Your system information:

 ordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.18
Ionic App Lib Version: 2.1.9
Ionic App Scripts Version: 0.0.48
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.1
Xcode version: Not installed

to the providers of the app.component.ts

By that do you mean, you're injecting it into the app.module providers array?
If yes, than everything works as expect.
import { Component } from '@angular/core';
import { TestService } from '../../providers/test-service'
import {AboutPage} from '../about/about'
import { NavController } from 'ionic-angular';
@Component({
  selector: 'page-home',
  template: `
    <ion-content>
      <button ion-button (click)="change($event)">TEST</button>
    </ion-content>
  `
})
export class HomePage {
  constructor(
    public navCtrl: NavController,
    public ts: TestService
  ) {
  }

  change(e) {
    this.ts.showPopover(e, AboutPage)
  }
}

import { Injectable } from '@angular/core';
import { PopoverController } from 'ionic-angular'
@Injectable()
export class TestService {
  constructor(
    public popoverCtrl: PopoverController
  ) {}
  showPopover(event, comp) {
    let popover = this.popoverCtrl.create(comp);
    popover.present({
      ev: event
    });
  }
}

If you dont mean app.module, that is probably the issue.
All providers MUST be declared in app.module since Angular 2.0 final.

Mike I don't mean create a service which shows the popover. I meant a service that gets injected into the page that the popover opens.

Why dont you provide an example project so that we can understand a bit better

Sure. Here you go.
TabsTest

Open both pages and correctly see that the service in injected as a singleton. (Check console for random number generated)
Now try to open the about page using PopOver component.
You can see now that a new instance of the TestService is created whenever the about is opened using PopOver.

Thanks, alright, I can see and understand the issue. Thanks.

The issue is with DI itself.
You have TestService declared in a providers array in multiple places
https://github.com/pantonis/tabsTest/blob/master/src/app/app.component.ts#L10
https://github.com/pantonis/tabsTest/blob/master/src/pages/contact/contact.ts#L9
https://github.com/pantonis/tabsTest/blob/master/src/app/app.module.ts#L29
Each time it instantiates a new instance, so there is no singleton. Removing the unnecessary providers in app.component.ts and contact.ts, everything behaves as expected.


Fixes multiple issues with removeFetchCondition & removeDownloadCondition

Relevant issue: #377

Hey @venning, thanks so much for your detailed issue report and extensive PR! 🥇 It's great that you took the time to track down and fix the bug, and I think the changed behavior where both methods throw an error when no fetch/download condition is found makes perfect sense.
I made some minor changes by removing the REMOVED_CONDITION constant and by updating the JSDoc comments as you suggested. Other than that, I'll release a new version to npm with these changes ASAP!