Custom component validation

Versions:

VueJs: 2.5.0
Vee-Validate: 2.0.0-rc.19

Description:
I have forms components all over my application which emit on my Bus the "name" when the value is changed : Events.$emit(this.name, this.savedValue);
Then, on the parent component, I listen for the change (I couldn't use the v-model for some reasons at the time) like this:
Events.$on('myName', (value) => { 		        this.myData.name = value; 	        });
I would ideally like to add the validator on the parent level - ie. on my custom component:  - as they may change all over my app.
I can't make the listen work here. What would be the best way?
Any help would be appreciated.
Thanks.

I can't help much without an example, as there are multiple solutions. First you may need to tell your subcomponent to inherit the validator from their parent which should make it easier to validate them using the Inject API.
When they will receive the validator from their parent, meaning they have access to the same fields and errors
// your component ctor options.
export default {
  inject: ['$validator']
};

Now since your components have access to the parent validator object as their own, they can either register themselves as fields, or register some inputs inside them, depending on how your components look like.
export default {
  created () {
    // attach field
    this.$validator.attach({
      name: this.name, // or whatever the field name is
      rules: 'required',
      getter: () => {
        return this.myData.value; // or whatever the value path is.
      }
    });

    // add bus listener
    Events.$on('myName', (value) => {
      this.myData.name = value;
      this.$validator.validate(this.name).then(result => {
        // do stuff
      });
    });
  }
};

Again I might complicate things here, if you can provide a minimal example in a fiddle I would be happy to help more.

Hi,
thanks for your help here - really appreciated.
And I'd register in the parent component (I mean where I have my app-input) the inject: ['$validator'],  right ?
Regarding the second part of your comment, why can I use the v-validate inline in my app-input in the parent ?
Basically, my Vue files looks like:
The component containing the form:
`

        <app-form id="form-edit-carrier">

                <app-input v-validate:name="'required'" :value="carrier.name" type="text" label="Name" name="myName"></app-input>

        </app-form>

`
and the input component:
`

        <input class="form-control" :id="idComputed" :name="name" v-bind="attrs" v-model="bindValue" @input="emitValue()" ref="input">

`
thanks.

You can disregard the second part. I assumed you didn't want to use the v-validate directive.
You don't have to do any registration now, the directive will take care of these things. What inject does is to let the input component inherit the same validator as their parent, thats it. So if it validates itself the errors will appear in the parent component as well.
Now when the value changes by an external event, you can just call this.$validator.validate('fieldName') and errors will appear in the parent errors as well.

Hi, okay it worked.
I have an issue though - when the instance is mounted, even if there is already a value, the error is displayed "this field is required". So it doesn't take into account a pre-existing value.
Can you help?
thanks;

You can provide the value as the second parameter, since it doesn't detect it properly.
this.$validator.validate('fieldName', inputValue);

In the mounted/created instance?

Whenever the value changes, in your listener for example and if you are validating initially then in the created cycle listener as well.

The problem is that in the created hook, my component isn't fully mounted - so it throws an error, and in the mounted the value isn't passed.
Any other idea?

I am trying to use vee-validate with custom bootstrap input wrapper (https://bootstrap-vue.js.org/docs/components/form-input) and found that it's not fully integrated because it need to listen native events in order to get notified on blur (https://vuejs.org/v2/guide/components.html#Binding-Native-Events-to-Components).
My workaround is too call validation explicitly in submit handler:

<template>

{{ errors.first('email') }}

      Submit

</template>

Any suggestion how to fix it properly?

@rzaharenkov
If the component does not emit the blur event then you cannot validate it on blur unfortunately, if your solution works then stick with it. You might consider building your own components if you want to overcome the 3rd party components limitations.


always show markdown in blocks mode

Since the only way to reach that file is through Explorer, it always end up to JavaScript.

Not sure about this one, let me verify when I get in to work

I searched and I did not see it being used anywhere else.

Hmmm. It's used in docs.html, error.html, package.html, script.html, stream.html

Indeed, somehow search is now poping those up. It seems that the sidedocs does not have this "mainbody" id then.

I'm reporposing this for editing markdown.

It's by design that way. I'll keep digging why the docs.less ui.segment CSS is not being applied in this case.

Yep, you're right we need a mainbody in webapp/docs.html

(Made the change here)


Bugs found during linux boot so far

Here are some of the hardware bugs found so far in the Linux's booting process:

incorrect sstatus read mask
incorrect enable signal for issue posion register in calculator
not trapping on illegal CSR instructions like rdtime
flushing FE pipe on invalid itlb misses

Couldn't that lead to missing the redirect command?
On Tue, Aug 27, 2019, 5:13 PM Dan Petrisko<EMAIL_ADDRESS>wrote:

@dpetrisko commented on this pull request.
In bp_fe/src/v/bp_fe_pc_gen.v
https://github.com/black-parrot/pre-alpha-release/pull/243#discussion_r318346828
:

@@ -177,7 +177,7 @@ always_comb
// We can't fetch from wait state, only run and coming out of stall
// We want to wait until the FE queue is ready, but if we're going to flush anyway
//   we might as well start fetching
-assign pc_v_if1_n = ~is_wait & (cmd_nonattaboy_v || fe_queue_ready_i) & fetch_ready_i;
+assign pc_v_if1_n = ~is_wait & (cmd_nonattaboy_v || (fe_queue_ready_i & ~flush)) & fetch_ready_i;

Yep, you're right.
We probably shouldn't fetch if we get a cmd that changes the pc if
fe_queue_ready_i is low, though.
How about getting rid of this part of the comment:
, but if we're going to flush anyway, we might as well start fetching
and changing to:
assign pc_v_if1_n = ~is_wait & ~fe_queue_ready_i & (~flush ||
cmd_nonattaboy_v) & fetch_ready_i;
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/black-parrot/pre-alpha-release/pull/243?email_source=notifications&email_token=ALDCJNC2KQHAZLALD6NZ5BTQGW7LBA5CNFSM4IQRTO42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC4JXPY#discussion_r318346828,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALDCJNGO2M3WK56HEV5TXFTQGW7LBANCNFSM4IQRTO4Q
.


New onSearchOpen Callback

This PR adds a new onSearchOpen callback triggered when the search box is displayed and also closes https://github.com/gregnb/mui-datatables/issues/210
Example of how to use this callback:
    const options = {
      filter: true,
      filterType: 'dropdown',
      responsive: 'stacked',
      onSearchOpen: ()=>{
       // your code here will be run after the user opens the search box
      },
    };

    return (
      <MUIDataTable title={"ACME Employee list"} data={data} columns={columns} options={options} />
    );

@apercas I would like to see the onTableChange callback notified like we do in the other examples incase someone wants to use just that:
https://github.com/gregnb/mui-datatables/blob/master/src/MUIDataTable.js#L514
You'll have to pass the setTableAction to the toolbar

OK, I'll take a look into it later on.

Coverage decreased (-0.02%) to 78.493% when pulling f3723de3cb90426fe43cda1cb71f624c323c8452 on apercas:feature/new-onSearchOpen-callback into 2f0ce48e627dcdb6e92f3c43e2f30e86be60004f on gregnb:master.

Hi, sorry for the delay on this, updated.

Need the README updated

Sorry for the delay on this again, README updated.

Thanks for the PR!


Would it be possible you do two intervals of five?

If you can help thank you and it would be interesting...

What format must select if i want to use "Interleaved 2 of 5"?, or is not suported yet?
wikipedia

@hhfa1990 ITF


Notifications foreground and background

On the notifications table, the notification foreground is almost the same as the background making nigh impossible to read them without hovering. Shouldn't/couldn't the foreground be the same light grey as pull requests?

(also, thanks for the styles, really makes github easier on the eyes).

Here's an example of what I'm seeing

@jpmnteiro Thanks for your kinds words. v1.4.0 just released.
Please update and let me know whether the problem persist.

@cquanu I just updated now and unfortunately am still having this issue. My notifications list appears just as before.

Hi @zsck can you post the affected URL here? I'll take a look :+1:

Sure, it's just /notifications

Thanks. Is this better?

Yes I think that would be substantially easier to read. Thank you for tracking that down!

@cquanu is the fully white border between my two issues on your screenshot wanted? I find it too white!

As can be seen on the following screenshot. The white borders also happen around a comment you just posted on an issue:

@jpmnteiro Thanks for the screenshot. :+1:

Again, here:

@toogy Sure. I will get them fixed :)

@toogy A separate issue for these border color concerns is probably very much appropriate here.

@zsck i couldn't agree more!

Hi guys, feel free to push requests to the v1.5.0 branch. Many thanks. :smile:

@cquanu notifications for me are still shown with the foreground/background that was originally reported (using 1.4.0).

Fixed in Dev Branch

Verified, working on given dev branch (1.5.0)


Missing OpenAI models

Several useful OpenAI models are missing from the types. For example gpt-3.5-turbo-16k as well as the dated models.

Hey y'all, this is a real easy patch ~
Just add this block between the models listed in Master/types/ai-models.ts
'gpt-3.5-turbo-16k': {
id: 'gpt-3.5-turbo-16k',
maxLength: 48000,
tokenLimit: 16000,
requestLimit: 12000,
vendor: 'OpenAI',
},
The model will show up in the dropdown menu :)

@jorge-menjivar I think this issue can be closed

@sebiweise I would like to make it possible to have the option to see all models including the versioned ones, but most importantly models with dynamic names like fine-tuned models. Maybe as an advanced feature that is disabled by default. This would require some moderate changes to our models structure though, which is why I'm leaving for later.

You mean like a database table just for available models instead of the types integration?

Yeah something like that would do it. The other issue is getting the proper max token length for arbitrary models. I know ollama at least, doesn’t have a way to do this in their endpoints API so I will need to investigate and do a pr to them (I asked on discord, and no response so I’m assuming there is no way). If we were to do this, there would not be a need to implement new models manually anymore, unless something substantial is different about the model.

I just removed the PossibleAiModels types integration and returning every possible AiModel now, but I dont know how to get the correct information for maxLength, tokenLimit, requestLimit from the OpenAi API, any idea?
https://github.com/sebiweise/unSAGED/tree/feature/aimodel_vendor_update

We might need to wait for support for this to come from OpenAI or we might have to come up with a new solution to the problem. For OpenAI models we can parse the model id and assume their base model from it.
Fine-tuned models also include the name in the id. They are all named something like ft:gpt-3.5-turbo-0613:xxxxxxxxxxxx. Maybe letting the user manually set the max tokens per model in the UI could be another solution in the worst of cases.

@jorge-menjivar What do you think of a new service that will be hosted by me or us, that will have a database of every possible AI model and that will offer a submit form to let users post new found AI models and/or vendors that they found. Maybe we could create a cron job that will gather new known AI models from known vendors automatically. When the models are saved we can have something like a status "draft" so someone can complete the corresponding model settings.
And then we have an endpoint that will return the models including the settings and also offer some filters so we can decide which vendors or model types (text/image/...) I want to get via the API call.

I like this idea. So basically it's a community database/index for models?

Also check the pre-release app v0.1.1. I made it so that it detects all models and let's you put the correct token window size in the settings

Yes, so basically just the types we have now in a database that can be contributed to easily, I would create a new service for that so that we don´t have a problem with another endpoint that isn´t available in the desktop app.
I would just try to build a simple version to test, just a quick Nextjs application with Prisma and a free Planetscale database, Clerk auth for some admin pages and a public available submit form that will create models that will need to be check by a admin

@sebiweise Thats really awesome. If vercel gets too slow to handle this let me know. I have over a dozen dedicated servers that I can get you a VPS to run this on at no cost.

I'd be happy to add missing params if you need help

Thank you for your help. I think we can just try to use Vercel for now and we will just need to have a look on the insights/usage of the endpoint. I think the database will need an upgrade later on but we will see. The data will be cached so I think for now no problem.
I will finish the database scheme and the management dashboard tomorrow so I can invite you to be able to edit/add ai models.

@sebiweise Looking great! Do we need to keep the max length and request limit? I removed them from the desktop app because they seemed redundant. Max length is just a guess for most models, and request limit could be set to token_limit - 100.

Max length is used for the max length of input text so if you go over a certain number of characters while typing, it will show you a warning. This is of course a guess because we cannot compute ahead of time the number of tokens a certain number of characters will use. The rule of thumb for now for this value has been token_limit * 3 or something like that.
Request limit is the max number of tokens to send in the request, so if we use token_limit - 100 for its value, we guarantee that the model can return at least 100 tokens in the response.

Yes I think we will have to take a look if we can remove some of the params and the params are need or not. I just pushed a working example that uses the "AI-Services" to get the possible ai models and the correct params/limits.
#163
https://github.com/jorge-menjivar/unsaged/pull/163/files#diff-b2b8156aafdf2a2697ee5d5d733f9e17a1d4e89734f8b97ab410121180b3baf0


update template

Automatic update is failing: https://github.com/iterative/pytest-servers/actions/runs/8516096721

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.37%. Comparing base (2a117c6) to head (396716f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   84.15%   83.37%   -0.78%
==========================================
  Files          12       12
  Lines         385      385
  Branches       51       51
==========================================
- Hits          324      321       -3
- Misses         52       54       +2
- Partials        9       10       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@skshetry auto. update is failing bc of the same issue with workflow files

Thank you @dtrifiro.


vNext-CorrectionTool

Correction Tool for vNext using a slightly modified Tobias Heimann Correction Algorithm in order to try to do it quick in the browser on the CPU.
Using the stroke given, determine which action(s) to perfom:

Stroke starts and ends inside a segmentation: Behaves as an subtractive freehand scissors.
Stroke starts and ends outside a segmentation: Behaves as an additive freehand scissors.
Stroke out-in-out: Section is subtracted.
Stroke in-out-in: Section is added.

It could further be improved by multithreading operation chains with workers.

Going to pragmatically push this for now as its vNext, not master, and we want to get vNext going.
Anyone is of course still free to open/give me feedback.


Create dynamic events component

Must be able to pull in featured FLIPS dynamically and display them on the homepage.
See designs here: https://www.figma.com/proto/jxzg0xbPBLbWz2BFsFPPx1/Prototypes?node-id=1654%3A22500&scaling=min-zoom&page-id=1429%3A21963&starting-point-node-id=1654%3A22500

[ ] Currently open FLIPS (top3)
[ ] Reccomended FLIPS (top3)

The component should first be completed using mock data in Storybook, and then later added to the main page.
The component will be rendered and then will fetch content afterward.

[ ] Should show loading state while rendering
[ ] Dat should be fetched on mount as this will not be an SSR component

Some thought could be given after June 20th about how to add the data sources for these components to the cache/refresh "ingestion" pipeline.

@codingone21 Can we close this?


Allow to run prettier/custom formatter post-generate

What would be the optimal way to do this?

I'd say it's out of the scope of this package, but running prettier --write after prisma generate on the generated files works for me, though I generally don't consider it critical if generated files aren't formatted like the rest of the code.

As an avid user of prettier, I could definitely be convinced to include this feature. One thing that I'll note though is that the intention of this generator is that the generated code is not source controlled. Ideally this means the generated zod schemas shouldn't need to be included in your normal linting/formatting process.

I've ended up adding this script to my package.json:
"generate-schemas": "prisma generate && prettier --write ./prisma",

Awesome! Glad you found something that works for you. Perhaps I'll add something to the readme that indicates this can be done for people who really want their specific formatting on the generated files.


Basic documentation for Entities, Components and Systems

These are largely targeted at beginners, as Entity, Component and System are the most obvious terms to search when first getting introduced to Bevy.

I liked your changes a lot @Ratysz, and you're likely correct about tone, even if it's a bit drier than is perhaps ideal for certain audiences. We can save a more approachable tone for examples and the book.
Very good idea to include a link to the docs on how to order systems in the System docs.
I had expected rustfmt to trim the doc comments to the appropriate length automatically 😅

Looks good to me!

bors r+


[local_auth] Is there a support for fallback when a user provides incorrect Touch/Face ID ?

If the user tries to login via Touch/Face ID and gives too many incorrect attempts is there any way this condition is handled so that the user is presented with a appropriate dialogue ?

For iOS, I wonder the same. Is it possible to use the 4 character pin code of the phone's system if a user has too many incorrect Touch ID attempts?
If not, how can I prompt a self-made pin code widget instead of the native Touch ID? After those unsuccessful attempts, the user must lock the screen and unlock with the pin code because the biometric auth is temporarily disabled.

For iOS, there's an initial PR at https://github.com/flutter/plugins/pull/2616 (although per comments there, it will need adjusting)

Not sure if this is related ...
After several failed attempts on iOS, using fingerprint (I'm guessing face ID as well) and then failing the PIN prompt, the phone becomes disabled, the app remains open, and the availableBiometrics then returns and empty list.
Therefore it is difficult to know whats going on.


Grafana dashboard Error

After running KCG pipeline  Instant Traffic dashboard in grafana throws an error:
 There is no supertype for types UInt64, Int64 because some of them are signed integers and some are unsigned integers, but there is no signed integer type, that can exactly represent all required unsigned integer values. (NO_COMMON_TYPE) (version <IP_ADDRESS> (official build)

Hello @sci92bior,
Thank you for reporting
Could you provide more information? Which commit id and which panel of the dashboard?

commit 7624684 , all panels in dashboard Traffic (ClickHouse)

Was able to reproduce.
Should be fixed with #242, could you confirm?
Thank you!

Yes, it works. Thank You!


Add admin-ui to helm-charts

Description:
Need to add the current admin-ui to helm charts.

Added the PR to add admin-UI components to the helm. There is an issue with the token request when logging into the UI. From the current ongoing effort to remove the node server, this issue can be fixed.


px4_fmu-v2_multicopter has no tones

Describe the bug
The v1.9.0-rc1 build of px4_fmu-v2_multicopter does not generate any speaker tones.
To Reproduce
Install v1.9.0-rc1 and power it up. No tones are generated.
Expected behavior
Normal behavior is startup tone, initialization complete tone, and safety switch tones.
Additional context
Adding tone_alarm to the multicopter.cmake file corrects the problem. This problem probably exists int the fixedwing and rover targets as well, as they are lacking the tone_alarm in their .cmake files.

Thanks, for reporting. Fixed in https://github.com/PX4/Firmware/pull/12013


[Documentation/UX Update] index_pattern/s clarification

Hey All,
Putting this here as I am not sure if this should be classified as a bug as the documentation on it is not clear. For OpenSearch-Dashboards the documentation states, "to any new index whose name matches the regular expression logs-2020-01-*" implying that regular expressions can be used. This seems to be bad wording as the field only seems to support asterisks as wild cards. (also in Open Distro's documentation)
This is also confirmed on the page for creating index patterns which states Use an asterisk (*) to match multiple indices. Spaces and the characters \, /, ?, ", <, >, | are not allowed.
The documentation should reflect the hint above for this. Also, if this pattern is the same for ISM then it should be reflected in their documentation.

Thanks for opening! Yeah I agree the docs implies regex accepted. Moved to doc repo.

Updated with #394


Blockstore api

First REST function for the blockstore

This will be done using a Model instead of changing the NBitcoin.Block code


Update WiFi_Profile_Mailer_New.ino

The current code causes a Powershell error that causes 'temp.csv' to never get attached to the email.
This is because the first PS line saves temp.csv to the user's home directory, whereas the second PS line tries to attach temp.csv from the system32 folder. To fix this I changed the first line to instead save it to system32, which is the default path for an admin Powershell session.

Thank you @kylefmohr ! Forgive the delay in review, I'm merging the commit.


Feature/logs-view-enhancement: Added Paginaton and Filtering of fields

Description
As mentioned in #863

Implemented filtering of Fields in Logs-View
Added Pagination in Logs-View

raised against sprint3.so closing this one.


Make TopLevelEncoder implementation overridable

TopLevelEncoder implementation was added by #175. However, its method cannot be overridden. If it can be, we can use custom root key, root attributes, or header even when we use Combine-style like this:
final class MyEncoder: XMLEncoder {
    override func encode<T>(_ value: T) throws -> Data where T : Encodable {
        try self.encode(value, withRootKey: "foo", rootAttributes: nil, header: XMLHeader(version: 1.0, encoding: "UTF-8"))
    }
}

So, I proposed the solution.

@MaxDesiatov It seems that danger-lint has failed in XMLDecoder, but I didn't change XMLDecoder at all. Do you have any ideas?

No worries, that seems like a SwiftLint bug 🙂


Develop beta 43

Development progress tracker for Connector beta 43

hello! just wondering if the "Retain client-only particle registry entities during sync" which fixes some particles not working on servers also fixes the problem where the same happens with sounds with "Quality Sounds" not working on servers but working in singleplayer?


[#64] [Frontend] As a user I can create a newsletter

[#64]
What happened 👀

Implement UI for creating newsletter form
Add from validation UI
Implement toast

Insight 📝
To implement UI and validation there aren't any issues.
On the other side, when Implementing the toast to show the successfully create newsletter. There is a big issue with that. As we use action to submit the data to the database, because that action is a server function, so we can't call toast during the hydration.
To solve this, I pass the toast message and mode on the localStorage, then use useEffect to check whether there is any toast message or not when the page is mounted, if there is useEffect will call toast. Reference (* In the reference they are using Cookie instead of localStorage)
This also allows to call the toast when redirect to another page too. Overall, this requires more setup than normal React & NextJs, but I'm very happy with the end result.
Proof Of Work 📹
https://github.com/nimblehq/js-framework-benchmark/assets/59072804/fc35f990-4a7b-4b31-bf68-3ca7023522b2

It is good to be fast in integrating code review comments, so you need to take more time to think through the changes 🙈 One change might require further changes that you should think about. These should be the final changes 🙏

Yep, so next time I will slow things down a bit and think about the change in detail 🙏🏼.
For my personal, sometimes I also don't know which way will work best for us, I think this will take me some time to learn things from the higher level dev than me 😅.


Duplicate resources issue

When I'm trying to use images from mipmap folder, it's giving duplicate resources issue. I've created app launcher icon using Image Asset. We all know Compose only supports the resources like rasterized images (ex. PNG or JPG files) or VectorDrawable xml assets.
Anyone faced an issue like this ? I've solved this by creating a copy of image and put it in drawable folder.
So in JetPack Compose, there should not be multiple resources for different screens is it ?

Compose doesn't change the need to provide alternate resources for differnet screen densities. What error are you seeing. I'll close this issue and it's not an issue with the samples in this repo and better suited to StackOverflow.


Pulsar integration

Is your feature request related to a problem? Please describe.
We'd prefer to use our in-house messaging system so that we can have consistent observability. We use Pulsar. OPAL supports Kafka but not Pulsar.
Describe the solution you'd like
Allow us to use Pulsar with OPAL
Describe alternatives you've considered
can't think of one at the moment
Additional context
n.a.

Hi Dan, you can add support for Pulsar by opening a PR on the broadcaster repository and adding the interface implementation.

/bounty $400

@orweis  shouldn't this be on the https://github.com/permitio/broadcaster repo ?

Hey, @daveads, the code PR is indeed in the broadcaster repo.
We didn't want to start our bounties in multiple reports and preferred to manage them here. The OPAL PR that will be attached for this issue is the docs page for the Pulsar configuration.

Hey, @daveads, the code PR is indeed in the broadcaster repo. We didn't want to start our bounties in multiple reports and preferred to manage them here. The OPAL PR that will be attached for this issue is the docs page for the Pulsar configuration.

Okay

/attempt #583

@gemanor  summited a PR
https://github.com/permitio/broadcaster/pull/20

Thanks, @daveads!! LGTM.  Assigned @asafc as a reviewer there.
@daveads, please submit docs PR in OPAL, too. OPAL docs are just simple markdowns in the docs folder. You can run a search for Kafka and find where it is needed.

Thanks, @daveads!! LGTM. Assigned @asafc as a reviewer there. @daveads, please submit docs PR in OPAL, too. OPAL docs are just simple markdowns in the docs folder. You can run a search for Kafka and find where it is needed.

sure


bad error message when giving Cat strings

Cat gives a RecursionError when giving it a string.
Probably flatten (from _util.py) should have special casing for strings to fix this.
repro:
from nmigen import Cat
Cat("test")

I vaguely recall fixing something like that once--not sure what happened with that. In any case, yes, reasonable.

Thanks for the report!


Multiple device during Flutter Run leads to concatenated output

This has since been fixed by moving to using plenary


Stop unneeded Clones

Thanks to hxScout I noticed this was causing lots of GC

Notice any side effects or anything?
It looks pretty safe since it doesn't modify the transform coming in, if __transform is perfectly encapsulated here and Travis doesn't catch anything it's probably safe to merge.


Support Flow Enums

Babel added support for flow enums here: https://github.com/babel/babel/pull/10344
Currently trying to import an enum results in MyEnum not found in enum-module
They're currently experimental, but should be coming down the pipe. I think it would be pretty trivial to support these, basically add an EnumDeclaration everywhere there is currently a TSEnumDeclaration.
I tried working on a PR for this, but the problem is getting the tests running. EnumDeclaration was added in babel 7.7.0. I was trying to get @babel/eslint-parser going in all the flow-related tests while retaining babel-eslint in other tests, but I kept running into problems.

Flow Enums have shipped and at first usage import/named throws an error.
import { MyEnum } from 'enumModule'; // errors
MyEnum.A; // Ideal usage

import * as EnumModule from 'enumModule';
EnumModule.MyEnum.A; // Not so ideal but no errors this way

That’s expected, when the issue asking to support them remains open :-)

We have better testing around specific parsers now than we did back in May, so it may be easier to attempt a PR now.

@ljharb I've have a look into this one now and just working on getting tests to run and noticed that babel-core is version 6.26.3 but to support transpiling enums the docs need >=7.13.0. Any thoughts here?
Also side note I'll need to add a babel plugin to interact with the RuleTester would you expect that to be added here?

In that case we’ll need a bit of infra change to be able to test on both Babel 6 and babel 7.

Should v6 still be supported? It's years old at this point? Just wondering is all.
Also want to add that import/exports also has an issue when there is a module that contains only an enum type, it will throw saying No named exports found in module ...

Yes, we still support down to eslint 2. Age is irrelevant.
I’m in the process of updating this package to more easily test across multiple parsers, including Babel 7. I’ll comment here once that’s done.


How to load hub modules in java

As title. Is there a way to recreate the tensorflow graph in java for a hub module?

I am able to download one of the tensorflow hub module using "wget https://storage.googleapis.com/tfhub-modules/google/nnlm-en-dim128-with-normalization/1.tar.gz"
After extracting the module using tar -xzvf 1.tar.gz, I found that there are no tags for the module:
saved_model_cli show --dir . gives The given SavedModel contains the following tag-sets: with no tag-sets.
Without tags I am not able to load it using Java SavedModelBundle load API [public static SavedModelBundle load(String exportDir, String... tags)](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/java/src/main/java/org/tensorflow/SavedModelBundle.java#L94) as it explicitly expects tags.
Is it expected that there is no tags info for tensorflow hub modules?

Yes, the hub module cannot be directly loaded as a SavedModel and it has to be first exported as one. The issue I linked above shows how to do it. In short you declare in a clean graph a placeholder, then apply tensorflow hub module on the placeholder, then export the SavedModel using tf.saved_model.simple_save.

For other people's benefit — after scouring the internet, here's how I was able to do this:
# Run this via `python3`

import tensorflow as tf
import tensorflow_hub as hub

def save_module(url, save_path, input_type):
    with tf.Graph().as_default():
        module = hub.Module(url)
        model_input = tf.placeholder(input_type, name="input")
        model_output = tf.identity(module(model_input), name="output")
        with tf.Session() as session:
            session.run(tf.global_variables_initializer())
            tf.saved_model.simple_save(
                session,
                save_path,
                inputs={'input': model_input},
                outputs={'output': model_output},
                legacy_init_op=tf.initializers.tables_initializer(name='init_all_tables'))

# save_module("https://tfhub.dev/google/universal-sentence-encoder-large/3", "./saved-module", tf.string)

And then in Java:
import org.tensorflow.*

SavedModelBundle savedModelBundle = SavedModelBundle.load("./saved-module", "serve");

Graph graph = savedModelBundle.graph();

Tensor result =
  savedModelBundle
  .session()
  .runner()
  // Note that I implemented `convert1DArrayTo2DArray` in Clojure, so I didn't paste here
  .feed("input", convert1DArrayTo2DArray("Hello world!".getBytes("UTF-8")))
  .fetch("output")
  .run()
  .get(0);

@vbardiovskyg has the situation changed? Is it possible to load hub modules in Java using TensorFlow 2?

Hi @cowwoc, I don't think there has been any change in SavedModel's Java APIs recently.
You can load the hub modules as in the example above.
As for the new TF2.0 SavedModels that are also hosted on tfhub.dev, they will be loadable directly if they were exported with a serving signature.

code for TF 2 models (based on @alexandergunnarson solution):
import tensorflow.compat.v1 as tf
import tensorflow_hub as hub
tf.disable_v2_behavior()

def save_module(url, save_path, input_type):
    with tf.Graph().as_default():
        module = hub.KerasLayer(url)
        model_input = tf.placeholder(input_type, name="input")
        model_output = tf.identity(module(model_input), name="output")
        with tf.Session() as session:
            session.run(tf.global_variables_initializer())
            tf.saved_model.simple_save(
                session,
                save_path,
                inputs={'input': model_input},
                outputs={'output': model_output},
                legacy_init_op=tf.initializers.tables_initializer(name='init_all_tables'))

# save_module("https://tfhub.dev/google/universal-sentence-encoder-large/5", "models/tmp/universal-sentence-encoder", tf.string)

and in Java:
import org.tensorflow.SavedModelBundle;
import org.tensorflow.Tensor;
import java.nio.charset.StandardCharsets;
import java.io.UnsupportedEncodingException;

    float[][] embed(String[] values) throws UnsupportedEncodingException{

        byte[][] input = new byte[values.length][];
        for (int i = 0; i < values.length; i++) {
            String val = values[i];
            input[i] = val.getBytes(StandardCharsets.UTF_8);

        }

        Tensor t = Tensor.create(input);

        Tensor result =
                savedModelBundle
                        .session()
                        .runner()
                        .feed("input", t)
                        .fetch("output")
                        .run()
                        .get(0);

        float[][] output = new float[values.length][512];
        result.copyTo(output);

        return output;

    }

Is there a python code piece where we can save the hub module using TF2 (instead of disabling the TF1 behavior of using TF Session etc), and load it in JVM using TF2? Or it is necessary to stick to the TF1 paradigm? Thanks.

@samikrc You don't need to save the hub module using python and re-loading it using the JVM. You can load it directly from the JVM using SavedModelBundle.load(). See https://stackoverflow.com/a/61968561/14731

@cowwoc @haitong The same code is not working right now. Are there any changes that you have done?

Sorry, I migrated to pytorch so I have no idea :(

If someone still needs solution, here is an update.
Turns out it actually works out of the box, so it doesn't need to be saved in python. Just download model directly from the hub (i.e. https://tfhub.dev/google/universal-sentence-encoder/4)
In order to load model in java you would need to know input and output names. To get it you can run "saved_model_cli" utility available from python tensorflow installation (i.e. saved_model_cli show --dir <model_folder> --all). The output will be similar to following one:
signature_def['serving_default']:
  The given SavedModel SignatureDef contains the following input(s):
    inputs['inputs'] tensor_info:
        dtype: DT_STRING
        shape: unknown_rank
        name: serving_default_inputs:0
  The given SavedModel SignatureDef contains the following output(s):
    outputs['output_0'] tensor_info:
        dtype: DT_FLOAT
        shape: (-1, 512)
        name: StatefulPartitionedCall:0
  Method name is: tensorflow/serving/predict

Here input name is serving_default_inputs and output name is StatefulPartitionedCall
So now you can call the model in java as follow:
SaveModelBundle bundle = SaveModelBundle.load("<model_folder>", "serve")
String[] messages = [.....]
NdArray<String> ar = NdArrays.ofObjects(String.class, StdArrays.shapeOf(messages))
Tensor tensor = TString.tensorOf(ar)

TFloat32 result = bundle.runner().feed("serving_default_inputs", tensor).fetch("StatefulPartitionedCall").run().get(0)


Start in background on Windows

I try to run the server on background without locking my console. I use gitbash on windows.
In my package.json I have defined in scripts: { "web-server": "http-server -p 1011 test/appgen/run" }
I run: npm start web-server &
The & so it runs in background, else the server blocks the further commands from executing like my cucumber tests.  Even with & on end - The server starts but it blocks the console and I cannot start my cucmber tests.
Any idea how this can be achieved? Basically to have an option where it runs dormant and later on I can kill the process by PID when tests finish.
Can you help me with that, is this a bug in the app or?

I don't believe this is a bug in http-server, but I'll leave this open in case someone else has any help. Unfortunately I don't have much experience with Windows so I don't know any more than what you've already tried.
On the other hand, is it possible to side-step this problem and have your tests start http-server when they need it?

@ltoshev 我的解决方法是使用自定义脚本，比如 powershell 中有 Start-Job 指令可以使一个命令到后台运行。

但是这样就没有日志了，这是个问题，我也不清楚应该怎么解决... 如果你找到了更好的方法请告诉我，谢谢。


npm link with node v10.28 failed while v4.0.0 passed

A custom generator on my machine was not being recognised when I did npm link. I fixed it by upg. from  node v0.10.28 to v4.0.0
Could this be a yo doctor check?
Or at least could the error message mention upgrading node?
You don't seem to have a generator with the name my-generator installed.
You can see available generators with npm search yeoman-generator and then install them with npm install [name].

Thanks

It's already a Node Doctor check to make sure you're on Node.js 4 or above.

Hm, so it looks like yo doctor doesn't behave well with old version of node on my system. I'm unsure if this is 1. typical, 2. a concern. But I'll leave this here for documentary purposes.
$ yo --version && node --version
1.1.2
v0.10.28
$ yo yiang test
Error yiang test

You don't seem to have a generator with the name yiang installed.
You can see available generators with npm search yeoman-generator and then install them with npm install [name].
To see the 62 registered generators run yo with the `--help` option.

-----------------------------------------
Update available: 1.5.0 (current: 1.1.2)
Run npm update -g yo to update
-----------------------------------------
$ yo doctor
[Yeoman Doctor] Everything looks alright!

early:~ ashleycoleman$ nvm use 4
Now using node v4.0.0
early:~ ashleycoleman$ yo doctor

Yeoman Doctor
Running sanity checks on your system

✔ Global configuration file is valid
✖ Node.js version

Your Node.js version is outdated.
Upgrade to the latest version: https://nodejs.org

✔ No .bowerrc file in home directory
✔ No .yo-rc.json file in home directory
✔ npm version
✖ NODE_PATH matches the npm root
npm global root value is not in your NODE_PATH

[Info]
  NODE_PATH = /usr/local/share/npm/lib/node_modules/:/usr/local/lib/node_modules:/Users/ashleycoleman/.nvm/versions/v0.12.2/lib/node_modules:/Users/ashleycoleman/.nvm/versions/node/v0.12.7/lib/node_modules
  npm root  = /Users/ashleycoleman/.nvm/versions/node/v4.0.0/lib/node_modules

[Fix] Append the npm root value to your NODE_PATH variable
Add this line to your .bashrc
    export NODE_PATH=$NODE_PATH:/Users/ashleycoleman/.nvm/versions/node/v4.0.0/lib/node_modules
  Or run this command
    echo "export NODE_PATH=$NODE_PATH:/Users/ashleycoleman/.nvm/versions/node/v4.0.0/lib/node_modules" >> ~/.bashrc && source ~/.bashrc

Found potential issues on your machine :(
early:~ ashleycoleman$ yo yiang test

Welcome to the Yieldify yeoman generator!

@AshCoolman I feel the bug explanation is pretty explicit. You hard coded NODE_PATH, but nvm doesn't ever change NODE_PATH, so your configuration is wrong.
The fix in your case though would probably to delete the NODE_PATH entirely.

@SBoudrias NODE_PATH isn't the issue I'm highlighting - its actually that I did yo doctor with node v0.10.31 (or perhaps v0.10.28) and it told me [Yeoman Doctor] Everything looks alright!.
It was only when I upgraded to node 4 that yo doctor recognised the problems with my system.

@AshCoolman yes, your NODE_PATH is not broken if you run without nvm. So that's why it only appeared once you changed version.

Ah, I get it. Thanks for the insight.


#79 switch to dart saas

Signed-off-by: Nigel Jones<EMAIL_ADDRESS>
Switches from node-saas to regular saas (dart) 1.32.7 as per https://www.npmjs.com/package/sass

Fixes #79
Opening for comment and review. So far I've verified the basic UI starts up, but I am not familar enough with the saas usage to warrant this change is safe. Looking for input from the experts :-)

This is actually restoring the change already made in https://github.com/odpi/egeria/pull/3841
So with approval, and since we're redoing a prior fix I think we're good to merge


Not able to reference inputs from dependency file in dependency

Hello,
My dependency file looks as follows
inputs = {
  env_name = "int-14"
}

Part of my Terragrunt file:
include {
  path = find_in_parent_folders()
}

terraform {
  source = "git::ssh://alm.oraclecorp.com:2222/acs_terraform_26775/main-infrastructure.git//common_infrastructure/load_balancer?ref=master"
}

dependency "compute" {
  config_path = "../../redis/compute"
}

locals {
  env_deps    = read_terragrunt_config("../../env_common_deps.hcl")
}

inputs = {

  backend_sets             = {
    "bes-1-redis-${local.env_deps.inputs.env_name}" = {
      policy               = "ROUND_ROBIN"
      health_check_name    = "redis_tcp"
      enable_persistency   = true
      enable_ssl           = false

      cookie_name          = null
      disable_fallback     = null
      certificate_name     = null
      verify_depth         = null
      verify_peer_certificate = false

      backends             = {
        be1                = {
          ip               = "dependency.compute.outputs.instances.oasp-${local.env_deps.inputs.env_name}-redis-1"
          port             = 6379
          backup           = false
          drain            = false
          offline          = false
          weight           = 1
        },
        be2                = {
          ip               = dependency.compute.outputs.instances.oasp-int-14-redis-2
          port             = 6379
          backup           = false
          drain            = false
          offline          = false
          weight           = 1
        },
      }
    }
  }

}

As you can see, I have an input in my dependency file called env_name that I pass to all my terragrunt files.
In that particular Terragrunt file, I need to pass the IP address coming from an output like this
instances = {
  "oasp-int-14-redis-1" = "<IP_ADDRESS>"
  "oasp-int-14-redis-2" = "<IP_ADDRESS>"
}

So If I do this  ip = dependency.compute.outputs.instances.oasp-int-14-redis-2 it works fine. However, I need to find a way to dynamically pass the environment name without hardcoding it in all my Terragrunt files  so I tried this  ip  = "dependency.compute.outputs.instances.oasp-${local.env_deps.inputs.env_name}-redis-1" but that didn't work what I got as IP address was dependency.compute.outputs.instances.oasp-int-14-redis-1 instead of <IP_ADDRESS> I've been trying multiple combinations but haven't been able to figure that out.
Hope somebody knows the trick or workaround in case Terragrunt doesn't support it.
Thanks,
Carlos

I was able to fix it by using index syntax
dependency.compute.outputs.instances["oasp-${local.env_deps.inputs.env_name}-redis-1"]
Carlos


ETHRegisterControllerV2

New Features:

Referral for Reveal and Renew domains.
Batch Commit, Reveal, and Renew.
Payment in the commit stage with extra tips to attract the registrar Dapp to reveal the name(s), covering gas costs.

You can read more about all we did in this medium article
Since we changed a lot from the previous version, we created a V2 for the new files

ETHRegistrarControllerV2.sol
IETHRegistrarControllerV2.sol
TestEthRegistrarControllerV2.sol

These features will reward front-ends (registrar Dapps), increase domain registration, and enlarge the community, creating third-party services for the ENS ecosystem.
By implementing the referrer as an option in the register and renew functions, the protocol will provide commission when executing the service and share a fee previously settled by the DAO, with the referrer.
Front-end Dapps will be built to profit on the refer share. And furthermore can be done with the payment with commitment, which can incentivize a relation of trust between the final user and front-end Dapp, enabling names to be purchased with a better UX, by a single transaction.
To save even more in gas costs, the batch feature will vastly increase the intention of acquiring new names, since the gas cost will rapidly decay when purchasing more than 1 name.

Has this passed a DAO vote yet?
The last time these changes were mentioned on the forums I asked this and was told it would still require a DAO vote.
While the functionalities may have benefit for some.
Personally I cant see how referral fees help anyone but influencers with huge followings - It may even be used to scam said followers and exploit/game the referral system in other ways.
I think frontends are capable of setting their own "referral fees" much easier by just tacking it on to the msg.value based on their wants how we do at ens.vision - this allows a competitiveness among different frontend builds as well creating / finding a true market value of such "fees"
It feels like it's adding unnecessary complications to the core contracts which could be abstracted by third parties who are interested in these features them selves and gives third parties something to build.
For these reasons I think you should organize a proper DAO vote on the individual features / changes you want to make before attempting to merge to main.

Has this passed a DAO vote yet? The last time these changes were mentioned on the forums I asked this and was told it would still require a DAO vote.

https://www.ensgrants.xyz/rounds/1/proposals/16
Some other benefits are the gas savings in these new features as shown here

Outstanding work! I'll give this a more detailed review soon, but I had one initial thought about the tips/referral mechanism that bears thinking about. What if, instead of maintaining a mapping to individual commits for pre-payment, we keep a per-account balance that can be used both to fund registrations and for referral fees? A commit-with-fee can fund this account, and referral fees can be added to the users' balance, while a reveal consumes any balance in the user's account, sending the remainder back to them so they don't have to manage withdrawals.
This will require keeping a separate counter of accumulated fees that can be withdrawn to the DAO, but I think it should still work out lower gas-cost than sending the referrer their fee in each TX, and simplifies the UX and the code.

Has this passed a DAO vote yet? The last time these changes were mentioned on the forums I asked this and was told it would still require a DAO vote.

https://www.ensgrants.xyz/rounds/1/proposals/16
Some other benefits are the gas savings in these new features as shown here

This is not a DAO wide vote though?
This is a small grant. Which you were awarded to research and develop.
As far as I'm aware @Arachnid core contract / protocol changes still require an official DAO wide vote?
It almost seems like trying to side-step the DAO by attempting to merge this here without bringing it to the DAO forum and putting forward a full vote via snapshot etc.

Awesome stuff!
There are a few changes we made post audit, so this will need to be merged into your V2 code as well. One example is:
https://github.com/ensdomains/ens-contracts/blob/master/contracts/ethregistrar/ETHRegistrarController.sol#L308
Please have a look at the current .eth controller contract for other additional changes. I will also find some time to take a closer look

@Arachnid "What if, instead of maintaining a mapping to individual commits for pre-payment, we keep a per-account balance that can be used both to fund registrations and for referral fees?"
I agree. This is actually something I have disagreed on implementation with @Alextnetto. Initially we had agreed to have a general balance for everything: fees, referrals, tips, funds, etc, but in the end the team argued that it was actually more costly in terms of gas to save the new balance than just to send the ether directly. As they were optimizing for gas I let it pass, but I'm still curious about why that would be the case.

Outstanding work! I'll give this a more detailed review soon, but I had one initial thought about the tips/referral mechanism that bears thinking about. What if, instead of maintaining a mapping to individual commits for pre-payment, we keep a per-account balance that can be used both to fund registrations and for referral fees?

Here is why we send the ether directly

Here is why we send the ether directly

Did you test this in the case where the accounts already have balances? Setting a storage slot from zero to nonzero costs 20k gas, but changing its value if it's already nonzero costs only 5k.

Heyy friENS, what's missing for getting this for a voting on DAO, can I do something to help, review, modify?


Update nuget dependencies in csharp projects

Nuget dependencies updated (except Azure OpenAI as that requires some code changes, will be addressed in a separate PR.)

Resolves some critical vulnerabilities reported by Component Governance in Kusto packages
Resolves https://github.com/Azure/azure-functions-pyfx-planning/issues/400 and https://github.com/Azure/azure-functions-pyfx-planning/issues/522

Given the number of packages and dependencies we need to manage, I suggest we look into Central Package Management to simplify this process.


fleet: server monitor fails to shutdown process

After a short etcd blip, fleet has issues on its agent and engine, but the process remains up. This is affecting v0.13.0
The symptoms are as follows: the Monitor detects the server failed heartbeat, asks all components to shut down, but the shutdown of all components never completes. This means that most `components are dead, the server process is still up, but serves:
{"error":{"code":503,"message":"fleet server unable to communicate with etcd"}}
The full error log is here:
Dec 07 19:28:55 eu2-prod-core-hasu fleetd[3250]: ERROR engine.go:221: Engine leadership lost, renewal failed: client: etcd cluster is unavailable or misconfigured
Dec 07 19:28:56 eu2-prod-core-hasu fleetd[3250]: ERROR job.go:109: failed fetching all Units from etcd: client: etcd cluster is unavailable or misconfigured
Dec 07 19:28:56 eu2-prod-core-hasu fleetd[3250]: ERROR reconcile.go:120: Failed fetching Units from Registry: client: etcd cluster is unavailable or misconfigured
Dec 07 19:28:56 eu2-prod-core-hasu fleetd[3250]: ERROR reconcile.go:73: Unable to determine agent's desired state: client: etcd cluster is unavailable or misconfigured
Dec 07 19:28:59 eu2-prod-core-hasu fleetd[3250]: ERROR job.go:109: failed fetching all Units from etcd: client: etcd cluster is unavailable or misconfigured
Dec 07 19:28:59 eu2-prod-core-hasu fleetd[3250]: ERROR engine.go:236: Failed fetching Units from Registry: client: etcd cluster is unavailable or misconfigured
Dec 07 19:28:59 eu2-prod-core-hasu fleetd[3250]: ERROR reconciler.go:59: Failed getting current cluster state: client: etcd cluster is unavailable or misconfigured
Dec 07 19:28:59 eu2-prod-core-hasu fleetd[3250]: WARN engine.go:117: Engine completed reconciliation in 4.004575849s
Dec 07 19:29:01 eu2-prod-core-hasu fleetd[3250]: ERROR job.go:109: failed fetching all Units from etcd: client: etcd cluster is unavailable or misconfigured
Dec 07 19:29:01 eu2-prod-core-hasu fleetd[3250]: ERROR reconcile.go:120: Failed fetching Units from Registry: client: etcd cluster is unavailable or misconfigured
Dec 07 19:29:01 eu2-prod-core-hasu fleetd[3250]: ERROR reconcile.go:73: Unable to determine agent's desired state: client: etcd cluster is unavailable or misconfigured
Dec 07 19:29:02 eu2-prod-core-hasu fleetd[3250]: ERROR server.go:237: Server monitor triggered: Monitor timed out before successful heartbeat
Dec 07 19:29:03 eu2-prod-core-hasu fleetd[3250]: ERROR engine.go:221: Engine leadership lost, renewal failed: client: etcd cluster is unavailable or misconfigured
Dec 07 19:30:02 eu2-prod-core-hasu fleetd[3250]: ERROR server.go:248: Timed out waiting for server to shut down

The curious bit is this code:
https://github.com/coreos/fleet/blob/v0.13.0/server/server.go#L248
func (s *Server) Supervise() {
	sd, err := s.mon.Monitor(s.hrt, s.killc)
	if sd {
		log.Infof("Server monitor triggered: told to shut down")
	} else {
		log.Errorf("Server monitor triggered: %v", err)
	}
	close(s.stopc)
	done := make(chan struct{})
	go func() {
		s.wg.Wait()
		close(done)
	}()
	select {
	case <-done:
	case <-time.After(shutdownTimeout):
		log.Errorf("Timed out waiting for server to shut down")
		sd = true
	}
	if !sd {
		log.Infof("Restarting server")
		s.SetRestartServer(true)
		s.Run()
		s.SetRestartServer(false)
	}
}

I think that after Timed out waiting for server to shut down the server should just crash immediately.

Closed via https://github.com/coreos/fleet/pull/1717


ENHANCEMENT: Search bar can be on top for better user experience

Go to Website Repository
Scroll down
See that search bar is on bottom

Can I do this?

Close it.


Configurable parallel execution of rows [table driven execution]

My team is using table driven execution for nearly all of it's tests, but some of our tables have over 1000 rows, each taking up to 3 seconds to run. If it were possible to execute them in parallel (In cases where parallelization would matter) that would vastly speed up our specs.

When would we expect this feature?

This feature was available in Twist. We are moving from Twist to Gauge. We have around 100+ scenarios with 500+ data table rows which is impacting us badly in execution time as the specs are running in serial with 500+ rows.
It would be really helpful if this feature is avilable soon.


Add ability to use String and Char as pattern in StringScanner

Ruby since 2.6 added ability to use String as pattern for StringScanner. It is quite usable since it doesn't lead to regexp machinery.

@HertzDevil , String#byte_index(Char) is in #13819 . After it will be merged, I'll update this PR.
Also I added simpler Rabin-Karp for short needles at #13820

The merge conflicts should be resolved

@HertzDevil I've rebased branch.
Additionally, I've deduplicate match method abusing both String and Char have each_byte method.
It could be not fastest way, but it removes need for two methods.
I think, String#starts_with? could accept additional parameter: offset for char offset, and byteoffset for byteoffset. Latter could be used in StringScanner. Python's startswith has start and end options for a while.
But let this happen in other PR.

Please do not rebase. It erases the review history.

Please do not rebase. It erases the review history.

I think, Github is smart enough.
Current review remarks were about lines to remove, and lines were removed.

@HertzDevil have you remarks or suggestions to current PR commits?

No, seriously: Please do not force push. It makes the job for reviewers harder.
Please follow the contributor's guide and add new commits instead of overwriting old ones.

@straight-shoota , ok, I will not next time. I'm sorry for doing it this time. I doubt I could restore branch in previous state.

@HertzDevil , should I fix anything in this PR?


Added CC and BCC recipients

Our business has a requirement at times to include carbon copy (CC) and blind carbon copy (BCC) recipients to emails sent from our apps. This functionality appears to be missing so I've included these two optional properties in EmailData.

Closing this PR as the source repo has had no activity in quite a while.


"Less" mixin support

Hello,
I converted the SCSS source file to less and added the needed build stuff.
A lot of people uses "Less" so this can be quite useful.

Sorry I don’t think I want to include this additional dependency in the core library, especially since FG doesn’t use Less in our projects. I’d be happy to link to a fork in the readme though, if you want to maintain one! Let me know, thanks!


SQLite apply_driver_hacks breaking URI usage

I noticed that flask-sqlalchmy is injecting (the wrong) directory when run, it puts the file directory in instead of the current working directory, causing me to not get a valid database. This means, by the way, that assert file.exists() passes but then a nonexistent file is still opened. I finally figured that out, but in doing so, I decided I wanted to use a URI, as described here: https://docs.sqlalchemy.org/en/14/dialects/sqlite.html#uri-connections - and the injection system completely ruins URI's, by adding a path before the file:.
app.config["SQLALCHEMY_DATABASE_URI"] = f"sqlite:///file:db.sqlite3?mode=ro&uri=true"

produces
/absolute/file/path/to/source/folder/file:db.sqlite3?mode=ro&uri=true"

Which does create and open a file with that name (file:db.sqlite3?mode=ro&uri=true). If it had been absolute, then it would have both paths (/absolute/file/path/to/source/folder/file:/absolute/file/path/to/binary/folder/db.sqlite3?mode=ro&uri=true), which at least won't open because it's a non-existent folder.
This should either only act after the the file: prefix when making this absolute, or just leave it alone when it's a file: and not make it absolute, leaving that to the user. Given that SLQLite happy opens files that don't exist, it is really irritating to mess with this path IMO, but maybe there's a good reason (which is why I don't know which of the two options is the right one to take).
This code is in apply_driver_hacks.

Environment:

Python version: 3.10
Flask-SQLAlchemy version: 2.5.1
SQLAlchemy version: 1.4.32

I didn't realize file: was a thing. Makes sense to detect that as well and modify it.
Because the current working directory is not always obvious during deployment, Flask-SQLAlchemy makes relative SQLite paths relative to the project root (will change to the instance folder in 3.x). This way, the database ends up in a consistent place, either absolute to begin with or always relative to the project.


Documentation update, adding solutions of the problems to a serverless tutorial

Related #3124
Motivation and context

This PR adds information about solve possible problems in the serverless tutorial
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@TOsmanov , general comment is the following: need to unify the tutorial with its linux version as much as possible. I see only a couple of specific steps for windows.


Fix bash completion for docker swarm join --advertise-addr

This fixes a typo in an option name that causes false completion of docker swarm join --advertise-addr.
Please include in 1.12.1 as this is about a new feature from 1.12.0.

LGTM


"setUserPresence:online" didn't be called sometimes.

Your Rocket.Chat.Android version: latest-develop
onStart() in MainActivity call setUserOnlineIfServerAvailable().
But, this function do not work well when app start(after termination with back-key)
This problem is relative with push. Because server send push gcm if that method is not called.
It seems more appropriate to put  setUserOnlineIfServerAvailable()  func() in onHostnameUpdated().
Please feedback. thanks.

That makes sense. I have to change a couple of things in MainActivity. Let me add this to it.


[Document] write a section about how to use this library with Expo

Just a reminder, since many RN developers use CRNA or Expo, we should write a section to help them adapt this library.

Would love this, or just some pointers about how it could be achieved at a glance.
We're developing an app that requires NFC and wish to combine this with expo but there isn't much info available. Would you have to export using expo kit for example as I don't think you can edit info.Plist in expo without ejecting?

I'm currently stuck with Expo, any hints?

@C0deMunk33 it seems that your expo project isn't successfully ejected, so the native module (NativeNfcManager) is still undefined. Maybe you can try this guide:

https://docs.expo.io/versions/v31.0.0/expokit/eject.

@C0deMunk33 If you have any updates, please share with us!

@C0deMunk33 Thanks for the solid information!

close inactive issue

Do you still need a doc for this?

Yes, I believe it will still be helpful. It you can provide a PR, I will be happy to accept that. Thanks!

Seems like it wouldn't be THAT hard to build a unimodule, which I think is the "right way" in Expo-think. I spoke to Brent from Expo team today and he said something like this is on their list but way down in priority. Thoughts?

Hi @troelsh thanks for contacting with expo team. I think currently we still need to guide expo user to properly eject to use 3rd party native module like this.
About expo's unimodule, since most connectivity features such as NFC or BLE are hardware related, and not required by most apps, it's a natural approach to exclude them. Maybe they can do something like expo-connectivity-modules to include these native connectivity features, which might benefit app developers targeting IOT or custom hardware related stuff.

@whitedogg13  you mean @troutgirl right? :)

Ah, good point! I will make sure to emphasize ejecting properly and what
you can/can't do in managed vs Bare workflow.
On Sun, Nov 10, 2019 at 2:37 PM Troels<EMAIL_ADDRESS>wrote:

@whitedogg13 https://github.com/whitedogg13 you mean @troutgirl
https://github.com/troutgirl right? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/whitedogg13/react-native-nfc-manager/issues/95?email_source=notifications&email_token=AAA3DQEGLAEMXPDPQUE5BZ3QTCEJVA5CNFSM4FZNZKZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDVI2VI#issuecomment-552242517,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3DQCVE4J6ONHZTWWYUUDQTCEJVANCNFSM4FZNZKZA
.

Hi, any update on how to use react-native-nfc-manager libary with Expo?


Minor bug fixes

This PR fixes some minor code issues that I had noticed when cloning the repository.
Additionally, adding .idea to gitignore for those Rider users out there 😎

Thank you very much for your contribution. The one thing I am not sure of is asp-action vs asp-page. asp-action seems to work well. Is there a bug you noticed?

@apexdodge ah, my apologies, this is supposed to be asp-route not asp-page. I have updated the PR.
Using asp-route here follows in line with other references to named routes within the codebase. Alternatively, asp-controller="EmailTemplates" asp-action="Index" would be used instead, but asp-action="EmailTemplatesIndex" won't work here as there is no such controller action named the same.

@brendonofficial Thank you for your contribution! This will be released with v1.1.4.


LAMBDA expressions

---- MODULE Issue123 ----

Op(l(_), v) ==
	l(v)

VARIABLE x

Init ==
    x = FALSE

Next ==
    x' = Op(LAMBDA v: ~v, x)

Spec == Init /\ [][Next]_x

====

TypeError: Cannot read properties of undefined (reading 'val')
    at evalBoundOp (eval.js:1788:71)
    at evalExpr (eval.js:2070:16)
    at evalExpr (eval.js:2517:15)
    at eval.js:1187:31
    at lodash.min.js:98:241
    at lodash.min.js:54:66
    at ue (lodash.min.js:35:327)
    at Function.Kc [as mapValues] (lodash.min.js:98:213)
    at evalEq (eval.js:1184:30)
    at evalBoundInfix (eval.js:1338:16)

Explicitly defined op doesn't work either:
---- MODULE Issue123 ----
EXTENDS Naturals

Neg(v) ==
   v

Op(l(_), v) ==
	l(v)

VARIABLE x

Init ==
	x = FALSE

Next ==
    x' = Op(Neg, x)

Spec == Init /\ [][Next]_x

====

Note on lambdas from TLA+ guide:

Syntactically, a lambda expression consists of the keyword lambda followed
by a comma-separated list of identifiers, followed by “ : ”, followed by an
expression. A lambda expression can be used only as the argument of a
higher-order operator or to the right of a “←” in an instance statement.

Initial implementation in f04eceb and 57a231c.


Steps towards simplifying Map

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
860 unchanged lines in 40 files lost coverage.
Overall coverage remained the same at 91.558%

Files with Coverage Reduction
New Missed Lines
%

.nox/test-3-10/lib/python3.10/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-10/Lib/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-11/lib/python3.11/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-11/Lib/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-12/lib/python3.12/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-12/Lib/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-9/lib/python3.9/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-9/Lib/site-packages/cogent3/core/location.py
4
89.24%

.nox/test-3-10/lib/python3.10/site-packages/cogent3/core/annotation.py
5
96.38%

.nox/test-3-10/Lib/site-packages/cogent3/core/annotation.py
5
96.38%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
236537

Relevant Lines:
258346

💛  - Coveralls


VADR Annotation

Problem description
Version 1.6.3 of VADR was released recently, adding support for influenza annotation (similar to FLAN). You might be interested in using VADR to annotate the consensus sequences generated from this workflow.

Thanks @fanninpm for letting me know about VADR now supporting Influenza genome annotation.
It looks like the Bioconda package hasn't been updated in a while and v1.5.1 is the latest. I'll see if I can get it updated based on the changes in https://github.com/bioconda/bioconda-recipes/pull/44370

Just to follow up on this, I pulled the VADR singularity image from staphb, and running it as a post-processing step after nf-flu finishes.  So far it has been working well, and we are using it as part of our QC regime prior to uploading our data to GISAID.

@Codes1985 that's great to know! I wonder if staphb have a Conda channel since I don't seem to be getting anywhere with trying to update VADR in Bioconda. Bioconda MacOSX builds are the bane of my existence... I usually skip them for my own tools. I wonder if I can get away with adding an OSX skip in my PR.

VADR annotation has been added in #73 and version 3.4.0. Hopefully that helps with your downstream needs @fanninpm!


Notification API docs

Documentation for #514.
Pushing it as a draft PR in order to keep track of it. Feel free to close it if it's better to just open another PR when the interface for #514 is consolidated.

Failing test is unrelated to changes (mainnet neoscan timed out)

Finished writing the documentation, bef50e942a3d5e10499db775b6690394ac62a086 also fixes some of the example code provided in a page.


Fix indent

Tab and half-width spaces are mixed in indentation, so indentation will be shifted when copying from web page.

@changeworld @sharonlo101 - The commits in this PR were moved to the private repo (PR 64906) for validation and staging. We'll close this PR now.


lastIndexOf in sourcemap-register.js causes Github to flag Incorrect suffix check

I think this sourcemap-register.js file is an output of this module:
https://raw.githubusercontent.com/gradle/gradle-build-action/aeb3e0fcd750be80d74f07ee94363abdf2b51020/dist/post/sourcemap-register.js
which contains this:
var n=0;while(r.indexOf(e+"/")!==0){var t=e.lastIndexOf("/");
if(t<0){return r}e=e.slice(0,t);if(e.match(/^([^\/]+:\/)?\/*$/)){return r}++n}return Array(n+1).join("../")+r.substr(e.length+1)}r.relative=relative;var o=function(){var e=Object.create(null);return!("__proto__"in e)}();function identity(e){return e}function toSetString(e){if(isProtoString(e)){return"$"+e}return e}r.toSetString=o?identity:toSetString;function fromSetString(e){if(isProtoString(e)){return e.slice(1)}return e}r.fromSetString=o?identity:fromSetString;function isProtoString(e){if(!e){return false}var r=e.length;if(r<9){return false}if(e.charCodeAt(r-1)!==95||e.charCodeAt(r-2)!==95||e.charCodeAt(r-3)!==111||e.charCodeAt(r-4)!==116||e.charCodeAt(r-5)!==111||e.charCodeAt(r-6)!==114||e.charCodeAt(r-7)!==112||e.charCodeAt(r-8)!==95||e.charCodeAt(r-9)!==95){return false}for(var n=r-10;n>=0;n--){if(e.charCodeAt(n)!==36){return false}}return true}function compareByOriginalPositions(e,r,n){var t=strcmp(e.source,r.source);if(t!==0){return t}t=e.originalLine-r.originalLine;if(t!==0){return t}t=e.originalColumn-r.originalColumn;if(t!==0||n){return t}t=e.generatedColumn-r.generatedColumn;if(t!==0){return t}t=e.generatedLine-r.generatedLine;if(t!==0){return t}return strcmp(e.name,r.name)}r.compareByOriginalPositions=compareByOriginalPositions;function compareByGeneratedPositionsDeflated(e,r,n){var t=e.generatedLine-r.generatedLine;if(t!==0){return t}t=e.generatedColumn-r.generatedColumn;if(t!==0||n){return t}t=strcmp(e.source,r.source);if(t!==0){return t}t=e.originalLine-r.originalLine;if(t!==0){return t}t=e.originalColumn-r.originalColumn;if(t!==0){return t}return strcmp(e.name,r.name)}r.compareByGeneratedPositionsDeflated=compareByGeneratedPositionsDeflated;function strcmp(e,r){if(e===r){return 0}if(e===null){return 1}if(r===null){return-1}if(e>r){return 1}return-1}function compareByGeneratedPositionsInflated(e,r){var n=e.generatedLine-r.generatedLine;if(n!==0){return n}n=e.generatedColumn-r.generatedColumn;if(n!==0){return n}n=strcmp(e.source,r.source);if(n!==0){return n}n=e.originalLine-r.originalLine;if(n!==0){return n}n=e.originalColumn-r.originalColumn;if(n!==0){return n}return strcmp(e.name,r.name)}r.compareByGeneratedPositionsInflated=compareByGeneratedPositionsInflated;function parseSourceMapInput(e){return JSON.parse(e.replace(/^\)]}'[^\n]*\n/,""))}r.parseSourceMapInput=parseSourceMapInput;function computeSourceURL(e,r,n){r=r||"";if(e){if(e[e.length-1]!=="/"&&r[0]!=="/"){e+="/"}r=e+r}if(n){var t=urlParse(n);
if(!t){throw new Error("sourceMapURL could not be parsed")}if(t.path){var o=t.path.lastIndexOf("/");

Which causes Github advanced security to issue this "high" severity error:
https://codeql.github.com/codeql-query-help/javascript/js-incorrect-suffix-check/
Would be great if you can confirm if this is related to node-source-map-support
If it is related, can you add the suggested fix here: https://codeql.github.com/codeql-query-help/javascript/js-incorrect-suffix-check/
to avoid the error from GH advanced security. :)

Searching for lastIndexOf doesn't yield any matches in this repo:
https://github.com/evanw/node-source-map-support/search?q=lastIndexOf
Are you sure that the code is from this package, and could you point me to the code in question in that case? ☺

as far as I can tell... it was in a sourcemap-register.js  file which I think was generated by node-source-map-support  ?
I am not clear on where sourcemap-register.js is coming from or where the lastIndexOf in the file is coming from.
See
https://github.com/gradle/gradle-build-action/commit/74a56b60ceb3acdc5f4b78fe93546ebf3a42f79c#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R11
sourcemap-register.js was being generated by running this command:
ncc build src/main.ts --out dist/main --source-map && ncc build src/post.ts --out dist/post --source-map

adding --no-source-map-register got rid of the sourcemap-register.js file altogether.

The heuristic looks like it might apply to indexOf as well (though the example only mentions lastIndexOf).
It looks like it may be this block its complaining about:
https://github.com/evanw/node-source-map-support/blob/7b5b81eb14c9ee6c6537398262bf7dab8580621c/source-map-support.js#L334-L341
Copied from v8 almost 9 years ago 😅

I'm seeing the same issue specifically pointed at indexOf:

This suffix check is missing a length comparison to correctly handle indexOf returning -1.
The indexOf and lastIndexOf methods are sometimes used to check if a substring occurs at a certain position in a string. However, if the returned index is compared to an expression that might evaluate to -1, the check may pass in some cases where the substring was not found at all.

The flagged code is the minified version of what @calebboyd referenced above:


Fix csi500

Description

Motivation and Context

How Has This Been Tested?
<! ---  Put an x in all the boxes that apply: --->

[ ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[ ] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[ ] Add new feature
[ ] Update documentation

logure


Conditional test

Hello
I've quickly developed this feature to remove unnecessary predicate when All is selected in combobox and when nothing is enter in textbox.
I may extend it to additional variable type in the coming days.
To make this simple ( in term of implementation ) , i'm doing the check and query change before anything in the replace method.
Please note it's my first dev in typescript , so any remarks are more than welcome and also if you can give some guidance on how to add test on this.
For a full description of the macro, i've updated the doc under the template section

Hello @TH-HA! Thanks for the PR.  I'm now working on review and will try it out over the weekend.  If it looks good I'll merge or get back with feedback.

Hello @hodgesrm
Do you have any feedback on this PR ?
Thanks

Hi @TH-HA!  We've been working on this behind the scenes--I'm setting up a dev environment where I can reliably test changes against different versions so that we can merge without creating regressions. That's been a bit of a puzzle since we want to be able to merge quickly but manually testing things is quite slow.
Your code and documentation looks good at first glance but it's hard to visually identify regressions.  How did you validate this change and which version of Grafana did you use?  I'm currently working on validation against Grafana 6.1.6.  Can you add a sample dashboard that exercises this feature?  If I can load that I'll merge.
Thanks!

Hello @hodgesrm
to validate the regression , i ve built a few dashboard using it and then using the devtools of our favorite webbrowser ( firefox/chrome ) was the main source of information.
Then the generated sql was enough to help me validate that the macro is correctly removing the condition based on the filter selection.
I'm currently using grafana 6.1.4 , but i need to try it on a 5.X.
Do you have any pointer on how test are written in the plugin , i can add a few and also use the existing one to do non regression testing also on my side.
I'll add some example dashboard in the branch to show how it works ( I'll try to make those dashboard working on the CH system table , like this they won't require any specific schema - And also it can be the start of some usefull/fancy monitoring dashboard working out of the box with CH without any additional third party neither additional storage as you need to use prometheus ....).
I'll add them before the end of the week in the branch.
I 'll take the opportunity of this interaction to ask you some feedback on the naming :
today it's conditionalTest for the macro.
We can use something more explicit : conditionalSQL
We can also extend it to text box variables ( especially since the latest evolution of CH contain a lot of feature related to text analysis - multi search / fuzzysearch / ngram ) with some intelligence ( remove the predicate if the value is null or .* for regexp for instance ).
Regards

Hello, any progress on this issue? Really looking forward to use this feature, it's a real game-changer for some filter-heavy dashboards 👍

Hello @TH-HA!
We've made another look at this request and here are some notes before we can merge it:

It does have unrelated changes of namespace handling for imports. I believe it should not be a part of this pr.
It removes the identifier escaping logic which is crutial for the plugin. Could you please revert it back?

Thanks, Andrey

I'll update the code to include the escaping logic in the function. I hope to be able to submit it next week.
On the first part , can you be more specific ? i didn't change the namespace in import ( at least not on purpose ).
Regards

On the first part , can you be more specific ? i didn't change the namespace in import ( at least not on purpose ).

There was a piece of code that imported a cetain functions from 'lodash-es' lib:
import {each, isArray, isEmpty, isString, map} from 'lodash-es';
In your PR it has been changed to:
import _ from 'lodash';
So the function calls have been changed from i.e. isEmpty(somthing) to _.isEmpty(something). If you didn't do that on purpose perhaps your IDE did.

ok , i've changed everything as discussed. I 'll test tomorrow morning.
Regards

Hi @TH-HA,
All looks correct now! Thanks! We are going to merge it today. There is a small typo in documentation: $condionalTest instead of $conditionalTest. If it's not much trouble for you, could you please make a quick fix of it.

sorry for that , it's fixed


Updated README.md

Added terminology section inside README.md

How is it that after editing the README.md file our test are getting failed?

This text seems to be copied over from an older version https://docs.konghq.com/hub/kong-inc/proxy-cache/ — should we instead just add a link to the official documentation in the README, rather than duplicate it here?

This text seems to be copied over from an older version of https://docs.konghq.com/hub/kong-inc/proxy-cache/ — I think we should instead just add a link to the official documentation in the README, rather than duplicate it here. I'll go ahead and make the switch.


Option --create-groups should only factorize known attributes

I had a SVG with SMIL animation which I tried to optimize with scour (actually Inkscape but it turns out they use scour in backend. Ref: https://bugs.launchpad.net/inkscape/+bug/1638040).
Many <animate*> tags had a fill attribute with freeze value and scour therefore factorized them inside a single  group. The problem is that the SVG spec says nowhere that the value of fill on the parent node is used when it is absent. It only says that remove is the default value (cf. https://www.w3.org/TR/SVG11/single-page.html#animate-TimingAttributes). As a consequence the SVG animation ended broken since I was relying on pieces of animation getting frozen to their last frame.
The create-groups option should only create groups on attributes known to work with the parent's value.

P.S.: tested with scour 0.35.

Issue seems to have been discovered before:
https://github.com/scour-project/scour/blob/210c5f64abdf336e25c58ca927093b3aa94c0a0c/scour/scour.py#L1007


fix(54088): remove replit reference

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #54088

please remove the `Closes`` syntax, as closing the issue requires more than that


libcsp-1 backwards compatibility

Description
How can I achieve compatibility between a node A using libcsp-2.0 + csp_conf.version=1  and a node B that uses libcsp-1 ? I can't access the source code of node B so upgrading isn't possible.
csp_packet_t structure is inherently different between each version, the most prominent difference being the fixed big-endianness of the header of the newer versions. Is there an effort already done to create this compatibility?
Steps to Reproduce
Compile a CSP server and client from libcsp-2.0 and libcsp-1, communication will fail.
Environment Details
Provide information about your environment, including:

Build OS:  Ubuntu 24.04
Target OS: Ubunut 24.04
libcsp commit hash: f74ee417 vs. 7fba4018

Does #713 help?

Does #713 help?

I have been using csp_conf.version=1 - via the -v option referenced in the PR. However, this does not entirely work, as what I need is to use a "libcsp-2.0 node" (with -v1 option to set CSP version 1) and a "libcsp-1" node, i.e., a propietary software which source code / upgrade I can't access to.
My questions is: is there a test mode where I could set libcsp-2 to be compatible with libcsp-1 nodes? I.e., nodes that are compatible with the old, libcsp-1 csp_packet_t struct ? Or should I downgrade and just use libcsp-1 for all my nodes ?

We also have a Cubesat component runing CSPv1. And we have successfully communicating using develop branch of libcsp in CSP protocol v1.

Are you able to capture the packets using Wireshark? Does https://github.com/KantaTamura/CSP-dissector help?

We also have a Cubesat component runing CSPv1. And we have successfully communicating using develop branch of libcsp in CSP protocol v1.

Is that Cubesat component built using libcsp-1 library? Or is built against libcsp2.0, and using csp_conf = 1 ?

I’m not sure; it’s not disclosed. However, we bought it long before we tagged v2, so it must be running libcsp-v1.
I just checked out the libcsp-v1 tag and tested it against the develop branch with protocol v1—it seems to work fine. Have you tried this?

Ah, ZMQ....
Is your Node B using ZMQ? On Linux? Why can't you update it?

Is your Node B using ZMQ? On Linux? Why can't you update it?
Yes, it uses ZMQ proxy interface on Linux Ubuntu 24.04. I can't update it because I don't have access to the source code of that software.

Would you mind creating a PR for it?


AutoFormat doesn't separate statements out onto their own lines

Given input like:
public class D {public String foo() {String foo = "foo";foo = foo + foo;return foo;}}

I expect AutoFormat to produce output like:
public class D {

    public String foo() {
        String foo = "foo";
        foo = foo + foo;
        return foo;
    }
}

Instead its actual output is:
public class D {

    public String foo() {String foo = "foo"; foo = foo + foo;return foo;}}

Run AutoFormatTest.separatesStatementsWithEmptyFormatting() to reproduce this issue

Superseded by #117


build(header): Removing the line that replaces the header with nested…

… header
The nested header is only needed for other packages like Location and UIEditor

Hi Alexis,
did you test that it produces the correct binary name?
I know I added that line because the project name (Leanplum-SDK) and the library name (Leanplum) was different, that's what the comment said too...
We set the actual library name in the pod spec: https://github.com/Leanplum/Leanplum-iOS-SDK/blob/master/Leanplum-iOS-SDK-source.podspec#L33
Otherwise it would have produced a Leanplum-SDK.framework and the imports were broken...

I'm pretty sure we need to this commit to prevent us from manually changing the module map back to Leanplum.h

Oh wait it's other way around. we need this to make sure Leanplum.h will be there. I'm going to close this PR.


DTLS 1.3: Update protocol_version.pm

[x] tests are added or updated

This PR is waiting for the creator to make requested changes but it has not been updated for 30 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

This PR is waiting for the creator to make requested changes but it has not been updated for 61 days.  If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section).

The CI is relevant.

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

This pull request is ready to merge

IMO, at the end, when we're ready, we should squash all commits into a single one. So that in future if need arises to revert something, that really helps. Thanks!

@shahsb As the commits are fixup! commits they will be squashed automatically when merging.

Merged to the feature branch. Thank you for your contribution.


skip failing tests

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Any updates on this?

@h-vetinari apologies for breaking the build & for the delay (business travel).
it should be fixed finally; just the osx arm64 build somehow seems stuck.
would it be safe to merge this PR nevertheless, what do you think?

Ah, it did complete (after 4h). Merging

Cool, thanks for fixing this! :)


Denon HEOS: Status shows 128 kbps mp3

Home Assistant release with the issue:

0.92.1
Last working Home Assistant release (if known):
None (new feature)
Operating environment (Hass.io/Docker/Windows/etc.):

Docker on openSUSE Tumbleweed
Component/platform:

https://www.home-assistant.io/components/heos/
Description of problem:
The status of my media player just says "128kbps mp3
Picture:

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
N/A -- used discovery component to set up
Traceback (if applicable):
N/A
Additional information:
My receiver is currently off while this status shows. It has never played an MP3.
Logs with debug enabled look like this:
homeassistant_1  | 2019-04-30 20:46:08 INFO (MainThread) [homeassistant.components.media_player] Setting up media_player.heos
homeassistant_1  | 2019-04-30 20:51:40 DEBUG (MainThread) [homeassistant.components.discovery] Already discovered service heos {'host': '<IP_ADDRESS>', 'port': 60006, 'ssdp_description': 'http://<IP_ADDRESS>:60006/upnp/desc/aios_device/aios_device.xml', 'name': 'Denon AVR-S740H', 'model_name': 'Denon AVR-S740H', 'model_number': 'Aios 4.025', 'serial': 'AYV27180922846', 'manufacturer': 'Denon', 'udn': 'uuid:04394099-ab3d-11b6-0080-0005cdc743d6', 'upnp_device_type': 'urn:schemas-denon-com:device:AiosDevice:1'}.
homeassistant_1  | 2019-04-30 20:53:35 INFO (SyncWorker_3) [homeassistant.loader] Loaded heos from homeassistant.components.heos
homeassistant_1  | 2019-04-30 20:53:36 INFO (MainThread) [homeassistant.setup] Setting up heos
homeassistant_1  | 2019-04-30 20:53:36 INFO (MainThread) [homeassistant.setup] Setup of domain heos took 0.0 seconds.
homeassistant_1  | 2019-04-30 20:53:37 DEBUG (MainThread) [pyheos.connection] Executed command 'system/register_for_change_events': '{'command': 'system/register_for_change_events', 'result': 'success', 'message': 'sequence=0&enable=on'}'
homeassistant_1  | 2019-04-30 20:53:37 DEBUG (MainThread) [pyheos.connection] Connected to <IP_ADDRESS>
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'system/check_account': '{'command': 'system/check_account', 'result': 'success', 'message': 'signed_out'}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'player/get_players': '{'command': 'player/get_players', 'result': 'success', 'message': ''}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'player/get_play_state': '{'command': 'player/get_play_state', 'result': 'success', 'message': 'pid=1011161164&state=stop'}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'player/get_now_playing_media': '{'command': 'player/get_now_playing_media', 'result': 'success', 'message': 'sequence=4&pid=1011161164'}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'player/get_volume': '{'command': 'player/get_volume', 'result': 'success', 'message': 'pid=1011161164&level=26'}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'player/get_mute': '{'command': 'player/get_mute', 'result': 'success', 'message': 'pid=1011161164&state=off'}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'player/get_play_mode': '{'command': 'player/get_play_mode', 'result': 'success', 'message': 'pid=1011161164&repeat=off&shuffle=off'}'
homeassistant_1  | 2019-04-30 20:53:38 WARNING (MainThread) [homeassistant.components.heos] <IP_ADDRESS> is not logged in to your HEOS account and will be unable to retrieve your favorites
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'browse/browse': '{'command': 'browse/browse', 'result': 'success', 'message': 'sequence=8&sid=1027&returned=1&count=1'}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Command under process 'browse/browse': '{'heos': {'command': 'browse/browse', 'result': 'success', 'message': 'command under process&sequence=9&sid=1011161164'}}'
homeassistant_1  | 2019-04-30 20:53:38 DEBUG (MainThread) [pyheos.connection] Executed command 'browse/browse': '{'command': 'browse/browse', 'result': 'success', 'message': 'sequence=9&sid=1011161164&returned=2&count=2'}'
homeassistant_1  | 2019-04-30 20:53:40 INFO (MainThread) [homeassistant.components.media_player] Setting up media_player.heos
homeassistant_1  | 2019-04-30 20:53:52 DEBUG (MainThread) [pyheos.connection] Executed command 'system/heart_beat': '{'command': 'system/heart_beat', 'result': 'success', 'message': ''}'

That's what the device is reporting. HEOS is always on, even if the receiver amp is off.  You can try explicitly calling the media_player.media_stop command and will probably go to Idle.  Otherwise, there's nothing to fix here...

I started playback of a Netflix show via my Shield TV, the receiver is displaying DD+ Neural:X.
The status does not update. Even though it's "playing" an mp3 the entity reports idle.
Also, Is the input selection box supposed to only show Tuner and Phono?

Looking at the entity state:

This doesn't give me confidence the integration has successfully been set up. I have never, ever used this streaming service or anything of the like on this receiver. It was set up, calibrated and has only been used to play back content from the Shield TV and a Nintendo Switch.
Is it possible it's mapped to the wrong zone? I don't see anything about zones or anything like that.

HEOS is not the same thing as the receiver.  It's control of the "Online Music" input on an AVR.  Just like if you open the HEOS app, you'll see it reporting the same status you see in HA.
If you are looking to control the receiver itself, then checkout the denonavr or denon integrations.

Also, Is the input selection box supposed to only show Tuner and Phono?

It will show whatever HEOS reports is available.  What shows up in the HEOS app?

Oh, I see - I thought it was online crap plus receiver state. Sorry about that!


scriptcs extension not finding mono command

I'm running a mac with Catalina. I've installed scriptcs via brew and Mono from the publisher's site.
When I click the 'play' button for a .cs file I get the following error:
/usr/local/bin/scriptcs: line 2: mono: command not found
Mono is located here:
/Library/Frameworks/Mono.framework/Versions/Current/bin//mono
scriptcs is located here:
/usr/local/Cellar/scriptcs
Mono version: <IP_ADDRESS>
scriptcs version: 0.17.1

Does scriptcs work outside Code, e.g., in terminal app?

yes

plz help

This is likely an environment issue on your end. Things to explore:

Is mono on your $PATH? If not, where is it set up?
Try setting terminal.integrated.shellArgs.osx to ["-l"] and []


feat(Filters): static component implementation

This is unstable version of the component

I'll close this for now, will create another PR with approach that we discussed


Call hash -r whenever PATH is updated

Currently hash -r is only called in chruby_reset. If there is no current selected ruby, chruby will not call chruby_reset and modify PATH. This apparently causes inconsistency in Zsh.

Should be fixed now.


Theme for VB6 IDE

Hi,
I've created a new theme for VB6 IDE.
https://github.com/jecsatta/VB6

Hey @jecsatta,
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository
New repository

You can check the live page here:
https://draculatheme.com/visual-basic
Thanks for building this! 🎉


Add buttons to the issue reproduction templates

The old jfiddle template is using outdated API, such as toMaster. Also, there are warnings of starting audio contexts without user interaction. I fixed these in the new issue reproduction template.

Thank you!

Thank you!


Weird exception

I have just tried to run the example from this site in my asp.net application. Connections in task service are working:
using (TaskService ts = new TaskService())
            {
                // Create a new task definition and assign properties
                TaskDefinition td = ts.NewTask();
                td.RegistrationInfo.Description = "Does something";
                td.Principal.LogonType = TaskLogonType.InteractiveToken;

                // Add a trigger that will fire the task at this time every other day
                DailyTrigger dt = (DailyTrigger)td.Triggers.Add(new DailyTrigger { DaysInterval = 2 });
                dt.Repetition.Duration = TimeSpan.FromHours(4);
                dt.Repetition.Interval = TimeSpan.FromHours(1);

                // Add a trigger that will fire every week on Friday
                td.Triggers.Add(new WeeklyTrigger
                {
                    StartBoundary = DateTime.Today + TimeSpan.FromHours(2),
                    DaysOfWeek = DaysOfTheWeek.Friday
                });

                // Add an action that will launch Notepad whenever the trigger fires
                td.Actions.Add(new ExecAction("cmd.exe", "c:\\test.log", null));

                // Register the task in the root folder
                const string taskName = "Test";
                ts.RootFolder.RegisterTaskDefinition(taskName, td);
            }

And in the last row strange exception has appeared:
System.Runtime.InteropServices.COMException: (57,4):Task:
Please, help!
Originally posted: 2014-02-04T01:31:58

If you call
t.RegisterChanges();

instead of calling RegisterTaskDefnition on the last row, do you get the same error?
Originally posted: 2014-02-05T07:43:14

It appears there is no way to create scheduled tasks from asp.net application
Originally posted: 2014-02-11T01:13:01

There are a number of ways and a number of discussions in this forum that cover the topic. Please search and follow the answers there.
Originally posted: 2014-02-14T07:49:19


Set Up a Workflow With Extended Employee Onboarding

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-ibpm-employeeonboarding-3-workflow.html
Please specify the step you are referring to : Step 2: Import sample application
Change of screenshot
Expected:

Actual:

Regards,
Nidhi

All the screenshots are now updated to Business Application Studio so this comment stands invalid.
@thecodester - please close the issue