In Ubuntu 19.10, leaving VS code unused for some time like 10 -15 minutes, can make VS code unresponsive & can take 10 secs comeback to life.

Another problem:
pranav@Exam:~$ sudo apt update
Get:6 https://packages.microsoft.com/repos/vscode stable InRelease [3,959 B]
Get:8 https://packages.microsoft.com/repos/vscode stable/main amd64 Packages [156 kB]
Err:8 https://packages.microsoft.com/repos/vscode stable/main amd64 Packages
  File has unexpected size (156354 != 156065). Mirror sync in progress? [IP: <IP_ADDRESS> 443]
  Hashes of expected file:
   - Filesize:156065 [weak]
   - SHA512:12e6dffcd247d1ff067acfa61a3c4eb6078c326c2858feb4f6f141a1d809e22292a78282414a5c103038ea80bb63cd734c7516782c9809c341335083d4e7611b
   - SHA256:c850f35f1979831ac75641978c397e51519fa22313598ec12bde5f52277044c0
   - SHA1:1f65f4a7388c22bcf7b7f30fb7bc337c60d94b2e [weak]
   - MD5Sum:4153a12e4a5629bfb14ed98f4c8ac234 [weak]
  Release file created at: Thu, 12 Dec 2019 19:59:19 +0000
Hit:9 http://ppa.launchpad.net/umang/indicator-stickynotes/ubuntu eoan InRelease
Get:10 https://packages.microsoft.com/repos/vscode stable/main amd64 Contents (deb) [286 kB]
Err:10 https://packages.microsoft.com/repos/vscode stable/main amd64 Contents (deb)
Reading package lists... Done
E: Failed to fetch https://packages.microsoft.com/repos/vscode/dists/stable/main/binary-amd64/Packages.bz2  File has unexpected size (156354 != 156065). Mirror sync in progress? [IP: <IP_ADDRESS> 443]
   Hashes of expected file:
    - Filesize:156065 [weak]
    - SHA512:12e6dffcd247d1ff067acfa61a3c4eb6078c326c2858feb4f6f141a1d809e22292a78282414a5c103038ea80bb63cd734c7516782c9809c341335083d4e7611b
    - SHA256:c850f35f1979831ac75641978c397e51519fa22313598ec12bde5f52277044c0
    - SHA1:1f65f4a7388c22bcf7b7f30fb7bc337c60d94b2e [weak]
    - MD5Sum:4153a12e4a5629bfb14ed98f4c8ac234 [weak]
   Release file created at: Thu, 12 Dec 2019 19:59:19 +0000
E: Failed to fetch https://packages.microsoft.com/repos/vscode/dists/stable/main/Contents-amd64.gz
E: Some index files failed to download. They have been ignored, or old ones used instead.

Usually, this problem is fixed using a VPN, but this time it didn't.

@PranavBhattarai Please report one problem per issue, it greatly helps us in managing issues. What you report in the body of this issue has already been fixed. For VSCode being unresponsive, can you please go through our performance wiki and include more information based on this?


multi-wan gateway

Hello,
great app, i have a feature request.
i have multi WAN gateway in loadbalance group. so when the speedtest runs it goes through one of the gateway.
can there be a feature to print WAN IP in the result? so its easy to know which gateway was used for speedtest.
it can also be good option if there is dynamic IP too.
thanks

If you click on the 3 dots to the right of a record of the results table, you can click view and it will show you raw data of the test result. There's the externalip field.

oh i totally missed that, too much info tucked away. maybe toggle columns can have show external IP. but i can live with this.


SPF & DMARC Record DNSSEC always false?

🐛 Summary
I was taking trustymail for a first test-drive with some domains, I know have proper DNSSEC.
But all of them show SPF Record DNSSEC & DMARC Record DNSSEC as "False".
To reproduce
Steps to reproduce the behavior:

Open terminal
trustymail --debug techrecruitment.io
Check results.csv file

Expected behavior
This domain has all green checkmarks on https://dnssec-analyzer.verisignlabs.com/techrecruitment.io
I was expecting SPF & DMARC Record DNSSEC to show "true"
Maybe I'm misunderstanding something here, since there is not much detailed info about that check in the Readme.

I get TRUE for both the SPF Record DNSSEC and DMARC Record DNSSEC columns when I run the tool.  Do you get the same results if you run trustymail techrecruitment.io --debug --dns="<IP_ADDRESS>,<IP_ADDRESS>"?  (The --dns="<IP_ADDRESS>,<IP_ADDRESS>" forces the tool to use Google's DNS versus whatever is configured for your local machine.)

So I tried the following:
Control: trustymail techrecruitment.io --debug still FALSE
Setting the DNS to <IP_ADDRESS> in the Ubuntu network settings, also FALSE
Using the --dns="<IP_ADDRESS>,<IP_ADDRESS>" option, I get TRUE
Testing the ISP DNS resolver with dnssec-failed.org, didn't show the page, so I'm assuming it has DNSSEC enabled.
Does this mean, the DNS resolver from the ISP isn't passing down specific information?
Since I'm testing from a Cowork, is this maybe a firewall/internal hardware issue?

Does this mean, the DNS resolver from the ISP isn't passing down specific information?
Since I'm testing from a Cowork, is this maybe a firewall/internal hardware issue?

Since using --dns="<IP_ADDRESS>,<IP_ADDRESS>" worked I think you're indeed seeing an ISP or cowork internal networking issue.
I see that the TTLs for techrecruitment.io's DNS records are all set to 3600 (one hour).
You might try setting the DNS to <IP_ADDRESS> in the Ubuntu network settings, waiting a little over an hour, and then retrying.  Either way, I highly recommend specifying your DNS servers (via --dns="<IP_ADDRESS>,<IP_ADDRESS>", for example) to avoid surprises.
I'll go ahead and close this issue since I think we've determined that the problem is not with this repo, but if you add any comments here afterwards I'll still see them.


system db can not be seen through DBeaver Client with default user logged

all dbs can be seen through clickhouse-client in pod:

but i cannot see anything other than the default database when logging in to ClickHouse through the DBeaver client:

I don't know if that's a limitation

This is not clickhouse-operator limitation


Conformer indexing bug in RDFreeSASA.cpp?

Description:

RDKit Version: 2017.09.3
Platform: MacOS, python3.6

External/FreeSASA/RDFreeSASA.cpp has the following pre-condition:
PRECONDITION(confIdx < rdcast<int>(mol.getNumConformers()),
+               "Conformer index out of range");

However, I don't believe there is a requirement that conformer indexes be contiguous and therefore this condition doesn't make sense. For example, if a mol had 100 conformers, and then 95 of them were later dropped, mol might be left with 5 conformers having IDs [6,16,74,80,82]. In this case every one of the existing indexes is clearly > NumConformers, yet all are valid.

You're exactly correct. This is a bug (and something I should have caught during the code review).
Thanks for pointing it out.

Also something I should have caught when I wrote it!


One step missing in the UWP workaround

First of all, great project. Saves me a lot of time. Thanks.
The Newtonsoft.Json.dll directly under Assets/UnityPackages/JsonNet should have all platforms except WSAPlayer checked. Otherwise the example scripts you provided will not compile because there are 2 dlls linked.

I'm trying to get this working, but Unity just freezes whenever I try to run the scene in the editor. If I try to build it, it freezes after the progress bars go through.
I have to shoot the process..
Any idea how to fix it? (Unity 5.6.1f1)

I never tried it in the editor. I tested it directly on the HoloLens. I used Unity 5.5.1f1. Maybe, probably not, this makes a difference.

Found the problem: It looks like the Unity Editor had to be closed during unzipping of the workaround. At least I think that's what caused the problems.


Black BG

Describe your problem here.
every custom background i add don't work it just turns black
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
i added the custom BG

lua wasnt updated, most likely cause, for now stick to Half-Life 17 and other pure H-Script Mods


tanka: 0.14.0 -> 0.15.0

Motivation for this change
Updating Tanka to the latest release.
Also fixing the issue where tk --version would print dev instead of the version string.
This is fixed by adding the subPackage attribute and additional ldflags arguments to buildFlagsArray.
The ldflags arguments were copied from the Makefile in the Tanka repository.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.


Permission of the cache files in ~/.rocketeer

Hi,
today I have learned, that rocketeer is caching clear text passwords and passphrases in the cache files in ~/.rocketeer
It would be great if the access rights for this files would be mor restrictive, so only the user can read/write them.

This was an oversight in Rocketeer 2 but has been fixed during the credentials refactor in Rocketeer 3. It's unfortunately not possible to backport the new credentials system in 2.x without breaking changes but I'll push to get 3 out as fast as possible


Selectors and Nesting

You state under Selectors and Nesting that styles, should be "selectors" actually, shouldn't need to be nested more than three times, four at worst. But then your "bad" examples consist of three selectors, which actually follows the stated suggestion.
In fact, I would even say that your bad examples are actually consisting of two levels of nested selectors as the first shouldn't be counted since it isn't technically nested.
To follow the the example given, the suggestion would be selectors shouldn't be nested more than one level deep. I would suggest making it no more than two levels deep and update the example accordingly. For example, showing up to three total selectors as okay and four total selectors going too far.

I think I would second this, I can't recall working on a project where more than one level of nesting was needed (except in a couple special cases).


[PubgrubTests] Add AssertBindings, -Result

Should've been obvious before, makes for nicer resolution tests.

@swift-ci smoke test


docs(proxy): Include proxy auth information in wash

Feature or Problem
Add documentation on using wash behind a proxy.
Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

I think this would be better suited for the wash README, under crates/wash-cli, mostly because the information we keep in the top level README should follow the happy path and not have to serve as comprehensive docs. It is valuable information, so a documentation page that's easily searchable on https://wasmcloud.com would be awesome as well

I have moved the changes to wash cli.


Fix gestures after refactoring and supporting selection of multiple nodes

Current Issues:

[ ] The move gesture moves the node but it jumps back when released.
[ ] The scale gesture doesn't seem to work at first but then scales the node down or up very rapidly.
[ ] The gestures are only applied if they start within a node.

Desired Behavior:

Selected Nodes
Move
Rotate
Scale

Single
The node is moved when the gesture starts within it.
The node is rotated if it is selected (full-screen gesture) or the gesture starts within it.
The node is scaled if it is selected (full-screen gesture) or the gesture starts within it.

Multiple
The node is moved when the gesture starts within it. Other selected nodes aren't moved.
All selected nodes are rotated (full-screen gesture) or a new node is added to the selection and rotated together with other nodes if the gesture starts within it.
All selected nodes are scaled (full-screen gesture) or a new node is added to the selection and scaled together with other nodes if the gesture starts within it.

In all cases, if the node isn't selected and the gesture starts within it, the node is selected.
Should we support this behavior or require prior node selection by tapping on it?

Personally, I would prefer to see an "immediate gesture" model, where the loaded objects are directly interactable and transformable without prior selection. This is how it's done with iOS' RealityKit, and it feels very intuitive to just immediately drag or twist an object in place. Also, with multiple models, it helps to lessen confusion about which, if any, object is selected. This, of course, works best for either large models, or on tabletops, so perhaps (time and resources allowing) a mode selection feature could help developers tailor the interactions to their needs.

@m-paunovic-vegait This will be the case, just like with Realitykit.
The default behavior will be selectionMode=Single AND this mode will select the first (or latest?) added node.
We will soon change the selectionVisualizer so it will be more obvious that an added selectable is in selected/editing mode.


Disable tx-split of intra blocks in inter frames

Because it slow down encoder too much, 30% ~ 300%, for the given 1% coding gain.

Awcy -s 6 coming right soon!
Awcy -s 2 also coming!

Will this leave it enabled on speeds 0-1?

I suggest to add a speed setting as in https://github.com/xiph/rav1e/pull/2171, what do you think? Would it be worth it?

I thought of adding a speed setting as in #2171, what do you think? Would it be worth it?

Sure- pls go ahead!

Will this leave it enabled on speeds 0-1?

Oh, just noticed that there was another comment.


Breaking change of binary format, add tuple type

Currently tuple is serialized:

If all T is unmanaged, serialize as unamanged struct
If T has included reference type, serialize as object format(add object header)

Shouldn't we have a type that is serialized as a continuous value with no object header?

released in 1.3.0.


Support system tray without menu

Is your feature request related to a problem? Please describe.
I'd like to be able to click the system tray icon without a menu showing up, and be able to react to that.
Describe the solution you'd like
.system_tray(vec![]) could be used to show the system tray icon, and .on_system_tray_click(|app| {}) could be used to react to the click

It’s in the roadmap but we want to stabilize the tray api before.
It should be available within few weeks.


How about allowing single selection from children by configuring a flag in parent item?

Do you mean about using radio button instead of default checked button?

I have the same request. It's not about radio button, check button is fine. Now the selection model is 'multiple selection', we want to add a 'single selection' model which can select a single value from a tree view.

You can see my example 4 https://leovo2708.github.io/ngx-treeview/ & do the same.

You guys not have a proper documentation. Its very hard to find things out. :(


Update README.md

I appreciate GitHub putting protections in place to not commit straight to main from the web UI, but for a project that's owned and maintained by one person it's a little overkill.


[Monitoring V2, Backport 2.5] Prometheus -> Classic UI is not working (404 errors) -> proxyURL is added twice to the request URL

Backports https://github.com/rancher/rancher/issues/32884 back to 2.5

Tested on 2.5-head (0713103) with rancher-monitoring v2 chart version 100.0.0-up16.6.0

checked cluster, node grafana links and graphs -- pass
checked grafana dashboards -- pass
logged in to grafana -- pass
checked all targets in prometheus -- pass
checked all rules in prometheus -- pass
followed these instructions on deploying an ingress from monitoring -- pass

Errors in network tab: -- to be resolved in upstream https://github.com/prometheus/prometheus/issues/9130
Prometheus -> ClassicUI -> Configuration
404: https://URL/k8s/clusters/c-w2r48/api/v1/namespaces/cattle-monitoring-system/services/http:rancher-monitoring-prometheus:9090/proxy/static/js/config.js?v=db7f0bcec27bd8aeebad6b08ac849516efa9ae02
canceled: https://URL/k8s/clusters/c-w2r48/api/v1/namespaces/cattle-monitoring-system/services/http:rancher-monitoring-prometheus:9090/proxy/static/css/config.css?v=db7f0bcec27bd8aeebad6b08ac849516efa9ae02
Alerts from prometheus are sent and return URLs are valid


[Bug]: Price widget not updating

Describe the bug
On two devices, the price does not update, even after 3 min.
Tested with EUR and USD
Reproduce

Go to 'add widget'
Click on 'Bitcoin price'
See error

Screenshots / Recording
No response
Operating system
IoS, Graphene OS
Bitkit version
44
Log output
No response

It's updating now. Not sure if I should close this ticket. @Nuhvi could you have a look?

@JeanlChristophe I can not replicate neither on 45 Bitkit version (simulator), nor my Android version 43, nor on the playground

Thanks.

With v95 the price widget doesn't update even after 5min. Same for bitcoin Blocks after 20min.
The price is updated only after I force close the app. But the wodget isn't updated.
same for Pav @thisispav

Fixed


Establish a "connection string" concept for constructing Accumulo clients

See https://github.com/apache/accumulo/issues/747#issuecomment-436349942
The idea here is to establish a connection string concept, so one can easily create an Accumulo client object from just a connection string, and can easily specify a connection string in a configuration field.
In the referenced comment, I proposed something like the following URI:
accumulo://[user[:password]@]name?zkHosts=host1:port1,host2:port2,host3,host4:port4
Other optional parameters could be added to the URI to support setting the path to a keytab file, or other authentication token information.
The Accumulo.newClient() entry point could have a method called to(String connectionString), and we can document the connection string syntax fully in the Javadoc and on the website.
The client configuration file could have a connectionString property name. (maybe just connection?) Not sure the best name.

This could be implemented as an instance.uri property the accumulo-client.properties file:
## Instance properties
## -------------------

## Accumulo instance (accumulo://<instanceName>?zk=<zookeepers>)
## Other options:
##    zkt - ZooKeeper timeout (default: 30s)
instance.uri=accumulo://myinstance?zk=localhost:2181

I labeled this issue for 2.1.0 since I believe it is for future work and not going into 2.0.

Might not go in 2.1.0 either. Maybe best to leave it unlabeled for now?

I was thinking it would be nice to know what tickets have been "triaged" aka addressed with labeling and having unlabeled issues was the only way I could think to do this.
When we are looking to release 2.1 we could bump it to the next version, similar to how we did it in JIRA.

In JIRA, we typically set a version if somebody wanted intended it to be fixed for that version, and then we bumped only if we couldn't get to it by the time we were ready to release. For many other issues, more "wish list" type items, or items that weren't well defined, or any specific timeline affiliated with them, we never set a version at all. For some issues that were bumped frequently, we removed the version entirely.
So, it varied a lot. Either way works for me... I just don't want to keep bumping (relabeling) low priority items that we never end up getting to.

Closing this as won't fix for now. This doesn't look that useful right now. Perhaps it will be useful in future.


Peterson helidon grpc poc demo1

Description:

Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

@mattp-swirldslabs  are we safe to close this PR?


HTML instead of JS

JS may of course be used for augmenting the site with dynamic features, but it should not be necessary like today. It is preferable, for several reasons, if as much as possible is pure HTML and CSS.

I've been giving this some thoughts the last weeks. I deemed it more productive to just go with what I know from the beginning in order to create nice MVP and then rewrite parts of it later into something more sustainable over several years (this being one of them).
Two viable options are:

Scrap current UI, and write a static html generator which generates all html needed in order to view images (keeping some parts of the JS such as the lazy-loading of large lists etc)
Utilize server-side rendering in more parts. Requires some heavy refactoring and rewrite of UI infrastructure.

It's probably a good idea to start with seperate the backend and the frontend into two different entities, and then work on them individual entities.

The way to do it should be

We should aim for the basic web design principle of separating content, layout and functionality. As a user, when I visit the site, I expect an HTML document filled with content, be it galleries, images or a single image; a document which does not rely on anything more complex than HTML and CSS.
This is probably most easily obtained if the front-end is redesigned without any JS whatsoever. (It would probably be even better to start with building the markup even without CSS in mind.) Then we can add some extra goodies such as lazy-loading with JS, of course.

Basic web design was a viable development method years ago, and the web has evolved since then. If you'd like to get rid of Javascript frontend I suggest you create a branch and begin to work :) However, the current trend in web development - and has been for several years now -  is to use javascript to render the frontend in a more efficient way than to use hand-crafted html & css, especially when manipulating the DOM.
Redesigning the frontend without javascript is not currently possible, as we need to lazy-load images of big galleries - otherwise we'll simultaneously ask the clients browser to load several hundred images, and most likely crash the browser application.
The site is currently written in javascript (react more like) in order to serve a frontend. I would not regard the initial design choice as an issue, but it adds some limitations such as a need for javascript support (which drops support for old browsers that need polyfills). Any modern browser (except maybe IE/edge) have full support for rendering using javascript.
The reason I initially picked React was that it was something I was familiar with, as well as that it is easy to learn and wrap your head around - maintaining it is not hard. Same goes for picking NodeJS for the backend.
Why do you think we should aim for ''basic web design'' when todays technologies offer a much better and scalable alternative?

I absolutely understand where you're coming from. However, I don't agree on the impossibility of a frontend without JS; server-side pagination (is that the correct term?) has existed for many years, so lazy-loading should by no means be a requirement. (Take a look at SweClockers.com for an example of a site which works very well without JS.)
I also don't agree that "today's technologies" (i.e. a JS frontend, if I'm following you here) are strictly better than "basic web design" in every case. For sites which are not real-time interactive web apps, such as DFoto, I think one should always try to stick to static, semantic HTML as far as possible, and then use JS to augment the site, while keeping basic compatibility without JS. In addition to wider compatibility, my experience is that these sites simply work better on a UX level, expecially on slower devices and connections. I can't comment on scalability though.
Having said that, I'm still very impressed with the site as it is today, and I'm not by any means trying to depict a rewrite as being easily performed or necessary. I'm just sharing my opinion.

This is clearly not an issue. Closing.


[path_provider]A comment error in  path_provider/lib/path_provider.dart

Location:
https://github.com/flutter/plugins/blob/5bf7fb0360aa70571c46d5b0ac64949fc81a0dfd/packages/path_provider/path_provider/lib/path_provider.dart#L131
/// On Android, this uses the `getDataDirectory` API on the context. Consider
/// using [getExternalStorageDirectory] instead if data is intended to be visible
/// to the user.
///
/// Throws a `MissingPlatformDirectoryException` if the system is unable to
/// provide the directory.
Future<Directory> getApplicationDocumentsDirectory() async {
  final String? path = await _platform.getApplicationDocumentsPath();
  if (path == null) {
    throw MissingPlatformDirectoryException(
        'Unable to get application documents directory');
  }
  return Directory(path);
}

The getDataDirectory in the comment is inaccurate, the correct one should be getDir.

Documentation no longer talks about the implementation details which aren't controlled the plugin. I believe this issue can be closed.

https://github.com/flutter/packages/blob/c451af75a4a4b5d96a00acd169990a7b4dd8a965/packages/path_provider/path_provider/lib/path_provider.dart#L107


Mark CI job pods as NOT safe to evict for ClusterAutoscaler

We've recently made our ClusterAutoscaler more aggressive and it started to kill running CI Job Pods during cluster scale up/down events thinking that CI Job Pod will restart and finish on another Node which is not true.
Looking for ways to prevent this I've tried working with PodDisruptionBudget as per K8S docs https://kubernetes.io/docs/tasks/run-application/configure-pdb/, however K8S Jobs don't support PDB, so the only working way we've found is to set cluster-autoscaler.kubernetes.io/safe-to-evict: false annotation on K8S Job Pods.
With this annotation ClusterAutoscaler can still scale Nodes Up/Down but it will wait for CI Job Pods to safely finish before removing a Node instead of just killing the Pods as it wants disrupting the CI flow.

Thank you! I'll have a look after the weekend.


Incorrect parameter description for Windows.UI.Xaml.Data.CurrentChangingEventArgs constructor

The parameter description is inverse of the parameter name. The parameter name "isCancelable" would suggest that a value of true would enable cancellation. The description says

isCancelable:
true to disable the ability to cancel
Either the description is incorrect, or the parameter name is incorrect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5534b881-f5d9-0a86-0245-7991e87bb6ef
Version Independent ID: 9f493fb0-99bf-4e72-db3a-e173b860b242
Content: CurrentChangingEventArgs Constructor (Windows.UI.Xaml.Data) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Xaml.Data/CurrentChangingEventArgs.xml
Product: uwp
Technology: winui
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks for catching this error. The isCancelable parameter in the constructor should have the same description as the IsCancelable property. The documentation has been corrected.


Help with Dokku / Docker

My laravel app is in a docker container ( Dokku )... How do I use this library since it requires us to start the command from the project's root directory.
Help Please

Had to swith to using swoole http server. Although the Websocket setup and usgae is different from Laravel`s broadcast style. A Socket.IO implementation instead.


[core] Use of undeclared type variables

Hi, look at class com.bytedance.jedi.arch.JediViewModel$execute$7
    /* renamed from: com.bytedance.jedi.arch.JediViewModel$execute$7$1 */
    static final class C105071 extends kotlin.jvm.internal.Lambda implements kotlin.jvm.functions.Function1<S, S> {

type variable S is never declared, but used
APK: https://drive.google.com/file/d/1wrBR3UgxGNoIpSMmuyqEC1fXcgiFmJvq/view?usp=sharing

One more example not in kotlin sources is in class com.google.android.gms.internal.measurement.Qc
final class Qc implements java.util.Iterator<java.util.Map.Entry<K, V>> {

I believe Qc should be also a parametrized type?
APK: https://drive.google.com/file/d/1ICfL4A22K-KhVkw5RwvWdLJA8111iYvG/view?usp=sharing

@skylot
In this app https://drive.google.com/file/d/1qC3tlWs9AtPBpyS6iU9kcSphLryfJOxi/view
Class com.crashlytics.android.core.CrashlyticsBackgroundWorker$2
    public class CallableC10842 implements java.util.concurrent.Callable<T> {
        final /* synthetic */ java.util.concurrent.Callable val$callable;

        CallableC10842(java.util.concurrent.Callable callable) {
            this.val$callable = callable;
        }

        @Override // java.util.concurrent.Callable
        public T call() throws java.lang.Exception {
            try {
                return (T) this.val$callable.call();
            } catch (java.lang.Exception e) {
                io.fabric.sdk.android.Fabric.getLogger().mo826e("CrashlyticsCore", "Failed to execute task.", e);
                return null;
            }
        }
    }

type T is also undefined

Hm, @bagipro did you disable anonymous class inlining?
Because class from last case should be inlined in method with defined type variable:
    public <T> Future<T> submit(final Callable<T> callable) {
        try {
            return this.executorService.submit(new Callable<T>() { // from class: com.crashlytics.android.core.CrashlyticsBackgroundWorker.2
                @Override // java.util.concurrent.Callable
                public T call() throws Exception {
                    try {
                        return (T) callable.call();
                    } catch (Exception e) {
                        Fabric.getLogger().e(CrashlyticsCore.TAG, "Failed to execute task.", e);
                        return null;
                    }
                }
            });
        } catch (RejectedExecutionException unused) {
            Fabric.getLogger().d(CrashlyticsCore.TAG, "Executor is shut down because we're handling a fatal crash.");
            return null;
        }
    }

Anyway, I will make a fix to replace all unknown type variable with base type.

@skylot

did you disable anonymous class inlining?

Yeah, because AFAIK this feature isn't stable (I remember that sometimes jadx froze with that feature enabled)

And one more case in the same app in class org.bytedeco.javacpp.tools.IndexedSet:
class IndexedSet<E> extends java.util.LinkedHashMap<E, java.lang.Integer> implements java.lang.Iterable<E> {
    //...

    /* JADX DEBUG: Type inference failed for r0v1. Raw type applied. Possible types: java.util.Iterator<K>, java.util.Iterator<E> */
    @Override // java.lang.Iterable
    public java.util.Iterator<E> iterator() {
        return (java.util.Iterator<K>) keySet().iterator();
    }
}

type K is undefined

@skylot
Thanks for the fix! I will close this issue and open a new one if I discover a different case


The mixer doesn’t open on MuseScore

Describe the bug
It is not possible to open the mixer window in the latest version (4.4.2) of MuseScore in nixpkgs unstable. It seems to be some incompatibility with the Qt version.
Steps To Reproduce
Steps to reproduce the behavior:

Open MuseScore.
Create a new score.
Try clicking on the button “Mixer.”

Expected behavior
The Mixer should open normally.
Notify maintainers
@doronbehar @vandenoever
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.32-hardened1, NixOS, 24.05 (Uakari), 24.05.20241004.6e6b3dd`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - channels(root): `"nixos-24.05"`
 - channels(user): `""`
 - nixpkgs: `/nix/store/ymskzig3is4dpkj43sa4q17vcsq0bf5b-source`

Add a :+1: reaction to issues you find important.

https://github.com/musescore/MuseScore/issues/24885

More specifically, this is logged as https://github.com/musescore/MuseScore/issues/24866; there is no fix for that issue yet, while the 4.4.3 release is already imminent, so most likely the fix will go into 4.5.

It looks like this duplicates https://github.com/NixOS/nixpkgs/issues/343456

Thanks @cbjeukendrup for joining the discussion :). Indeed this is a duplicate and https://github.com/NixOS/nixpkgs/issues/343456 has a few more details there, so I'll close this.


When does a new version come out?

Hi,
Anyone know when will have a new release with the bugs fixed in the pull requests?
Thanks.

We are picking up few fix changes to make patch release as soon as possible, but we don't provide exact date when at this moment.


support passing --without-urls to poetry export

Is there an existing issue for this?

[X] I have searched existing issues, it hasn't been reported yet

Use case description
This is to bypass a bug in pip (https://github.com/pypa/pip/issues/11511) that causes this plugin to fail. While most users may not encounter this, it is a hindrance when using private pypi repos (e.g. nexus). There is an issue open to better work around this bug with poetry (https://github.com/python-poetry/poetry-plugin-export/issues/149)  but enabling the use of the existing --without-urls flag here may be a quicker path forward for the time being.
Proposed solution (optional)
Similar to the implementation of poetryWithGroups, allow this setting to be enabled.
custom:
  pythonRequirements:
    poetryWithoutUrls: true

Or, for future expandability, just allow passing any cli args to the export command.
custom:
  pythonRequirements:
    poetryExportArgs:
      - --without-urls
      - --only
      - main

Hello!
We are having a similar issue.
Instead of installing ALL groups we only want to install ONE group of our .toml requirements!
There should be a way to pass extra args to poetry. --only Flag in our case.
e.g. It makes absolutely no sense to install dev-dependencies

+1 !

+1!


Mobile support

Low priority, but mobile support would be a nice to have feature.

Did you try mobile screen? The layout is responsive to its basically usable on mobile.
do you have concrete improvements which are needed?

There is, they are under the policy panel, but yes the scrolling is a bit more difficult due to the additional scrolling behavior of the editor

I will work on this, maybe I let more space left and right. To have more space to scroll outside of the editor

I added more space on the right site, to have more space to scroll the screen (instead of the editor content). Does this help?

Helps quite a bit. Considering this issue resolved.


Add gtk+-3.0 to the list of packages to look for.

Syntastic couldn't find my local gtk3 pc file, so I just added it in the list of packages.

This has been discussed in the past, please see #1493 and #1617.  Sorry, but no.


Test file can't locate our babel-runtime if testcafe is not installed in the files node_modules lookup scope

I'm working on this


Type error in complied version of NList.hs

Description

The compiler produces a type error when compiling the following example program.
module NList where

data Partial a = Value a
               | Undefined

data NList a = Cons a (Partial (NList a))

toNList :: a -> [a] -> NList a
toNList val [] = Cons val Undefined
toNList val [x] = Cons x Undefined
toNList val (x:xs) = Cons x (Value (toNList val xs))

Steps to Reproduce

compile NList.hs with freec -o NList NList.hs
open created coq file in coqide
go through definitions with coq

Expected behavior
The created file should be free of type errors.
Actual behavior
When trying to add the function toNList_1 the following type error occurs:
In environment
Shape : Type
Pos : Shape -> Type
a_0 : Type
a19_0 : Free Shape Pos a_0
The term "Partial Shape Pos" has type "Type -> Type" which should be Set, Prop or Type.

Versions

freec --version: version <IP_ADDRESS>
ghc --version: version 8.6.5
cabal --version:  <IP_ADDRESS>
coqc --version:  8.11.0
OS: Ubuntu 19.10

Known workarounds
None

It seems that the pattern matching compiler does not work. I now removed pattern matching manually and it worked.
Up there i did it using the --transform pattern matching command.

It looks like there are actually two issues.
First, the compiler usually renames custom data types, constructors and functions such that they do not conflict with Coq keywords or definitions from our base library. It seems that Partial (which is the name of a type class provided by the base library for modelling partial functions) is not on the list of Identifiers that have to be renamed. This part of the issue should be straightforward to fix. Thus, I'm going to add the good first issue label.
However, your toNList function is not partial. Thus, it was confusing me at first, that the compiler adds the (P : Partial Shape Pos) constraint to toNList_1. Using the --dump-transformed-modules command line option, I could observe, that the pattern matching compiler produces the following output.
toNList :: a -> [a] -> NList a
toNList a0 a1
  = case a1 of
        [] -> Cons a0 Undefined
        a2 : a3 -> case a3 of
                       [] -> Cons a2 Undefined
                       a6 : a7 -> undefined
        a8 : a9 -> Cons a8 (Value (toNList a0 a9))

For some reason, (:) is matched twice. The partiality constraint is added due to the undefined in the second alternative. This is a bug of the pattern matching compiler and should be reported at the haskell-src-transformations repository.
Interestingly, the bug does not occur if the pattern in the second rule of toNList is rewritten as follows.
toNList :: a -> [a] -> NList a
toNList val [] = Cons val Undefined
toNList val (x:[]) = Cons x Undefined
toNList val (x:xs) = Cons x (Value (toNList val xs))

Unfortunatly, the pattern matching compiler performs an "optimization" that prevents both our termination checker and Coq's termination checker from recognizing that toNList decreases on xs. Thus, you'll have to use the manually transformed version of toNList for now.

I've now reported the bug that (:) is matched twice at https://github.com/FreeProving/haskell-src-transformations/issues/7.


Page stuck on "Done" with black screen and no console errors

This only happened once but it never progressed until I refreshed the page.

It happens to me when I open Streets GL, then I change tab on Google Chrome, and I get back to Streets GL after a while. Do you remember doing something similar?

I did switch tabs, yeah. Although, strangely, I couldn't reproduce it afterwards.

I have this (Vivaldi with chromium engine) where the progress bar just sits there, anywhere. When I then click the screen usually a green background appears first then the elements start building. Notably I'm impatient, so I do something else in another tab or app to then return to see if the initial loading or the Ctrl+F5 to refresh the screen data has finished. The updating continues in background, just not the tab map image when returning. Could be a browser performance thing to not do screen updating of tabs in the background.
What I discovered this morning is that Ctrl+F5 to reload is not needed. Simply dragging the image around a bit made added buildings appear like here the yellow orange house in the middle with the long industrial building, noting that windows=no is but for a few building types not working. Thou shalt have windows ;O)


Ford: Escape 2020 fingerprinting issue

Describe the bug
bad response from engine
[20035.035255] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x7f2231
[20035.057011] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x621e1c0517
[20035.075456] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x621e3c0000
[20035.096026] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x62f43c0779
[20035.125009] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x62f43356
[20035.137130] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x7f2231
[20035.145368] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x410b3c
[20035.165932] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x41049d
[20035.184374] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x41057d
[20035.205114] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x410c0d85
[20035.274251] fw_versions.py:309 - : iso-tp query bad response: (2016, None) - 0x410d00
Which car does this affect?
Ford Escape 2020
Provide a route where the issue occurs
fc5df38c8fcae904|2023-09-08--19-26-41
openpilot version
0.9.5
Additional info
No response

Make sure to request logs for at least one route.

This user's missing engine FW was added here: https://github.com/commaai/openpilot/pull/29372 which is not in release yet. Then around this time, they modified/re-flashed their engine with a custom tune which changes the reported FW. We have a PR that blocks these FW made here: https://github.com/commaai/openpilot/pull/29016. Similar case of this we blocked was here: https://github.com/commaai/openpilot/pull/28956


Enhancement Request: Custom Editors for Different File Types

Issue Description:
Hi there!
I'd like to propose a new feature to enhance our remote file access application. Currently, we have a single parameter, Editor path, which is applied for opening all file types. However, it would be great to add the capability to customize the editor (or viewer) for different file types.
What Would Change:
Introduce a new feature to allow users to set different editors for various file types. Now users can specify separate editor paths for text files, images, videos, and other file formats.
How it would work

Introduce a new parameter Image viewer path.
Introduce a new parameter Video viewer path.

Thanks!

Very nice suggestion! I'm not going to get time to implement this in the near future unfortunately, but here are some pointers if you want to take a go at making a pull request for this yourself:
This is the code that shows the text editor text field and label: https://github.com/allanrbo/filesremote/blob/389cd4d87ea996f42e8eca89db6352c0a58a2a1c/src/preferencespanel.cpp#L86-L98 . You could copy-paste this to make a new field for image and video viewer. Similarly a few other methods in this class would need updating to save/load from the config file.
This is the code that reads the editor path from the config and opens the editor: https://github.com/allanrbo/filesremote/blob/389cd4d87ea996f42e8eca89db6352c0a58a2a1c/src/filemanagerframe.cpp#L909-L919 . You could update this to check if the file ends with a known video or image file extension and launch the relevant program.


How to use "Fetch" in component that is called outside of load()

I have a component that queries something relative to a slug every so often, but "fetch" is only available to the server side via load(), and since components are run on server, then client, I need something universal. Checking for "browser" would not be applicable to my particular use case.
I can technically pass fetch as a prop to the component, but that just feels...wrong. Is there an alternative here?

fetch is asynchronous, and rendering a component on the server (once you have its props) is synchronous, so the only way to get data into the page during SSR is via load().
If it's code that's going to be running later on the browser, you can safely use a regular fetch there.
If there's some code that needs to run both during SSR and periodically later on, you can write it to accept fetch as an optional argument (and pass that from load()), which it will use instead of the browser's default fetch if the argument is passed.


px/tcp_drops pxl script broken due to missing tcp_drop kprobe

Running the px/tcp_drops pxl script results in the following errors:
$ kubectl -n pl logs vizier-pem-qrn9l

[ .. ]

stdin:26-28: WARNING: tcp_drop is not traceable (either non-existing, inlined, or marked as "notrace"); attaching to it will likely fail
I20230627 17:32:19.979256 1894345 stirling.cc:549] DynamicTraceConnector [DT_e2a6ba86-df73-4975-a291-fd8728296097] created in 5570.15 ms.
I20230627 17:32:19.979339 1894345 source_connector.cc:35] Initializing source connector: DT_e2a6ba86-df73-4975-a291-fd8728296097
cannot attach kprobe, probe entry may not exist
ERROR: Error attaching probe: 'kprobe:tcp_drop'
I20230627 17:32:20.119061 1894345 stirling.cc:566] Internal : Failed to run BPF code.
I20230627 17:32:22.009603 3168351 tracepoint_manager.cc:180] Tracepoint[e2a6ba86-df73-4975-a291-fd8728296097]::tcp_drop_tracer has transitioned PENDING_STATE -> FAILED_STATE

It appears that the tcp_drop function was removed in v5.19 kernel and that removal may have been backported to other v5.x releases. For these newer kernels there is a tracepoint available that should serve a similar purpose (tracepoint:skb:kfree_skb). BCC's tcpdrop tool uses this as a fallback if the kprobe doesn't exist, so we should implement a similar fallback mechanism.

This isn't quite complete yet so I'm reopening. We need to merge the remaining PRs (#1686, #1687 and #1688) in order to call this done.


Error page with a custom layout

I want to customize my error page layout. But since 404 is coming from foundation I have to customize both default and 404.
Ether:

Foundation should only ship default
OR
Child's default should override the foundation 404

Closing as repo is deprecated.


Cow: Watch aqglassshowerdoorsphoenix.com

Cow requests the watch of the watch_keyword aqglassshowerdoorsphoenix\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

aqglassshowerdoorsphoenix\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Description on agenda not viewable

The description for an agenda item is only visible for users with edit rights. It would be logical to make an agenda item clickable, and show the description then.

This a question of design. Do we want to give non-staff users access to the so called custom slides.
Attention: At the moment at the list of speakers view there is a dead button to the custom slide detail view (for non-staff users).

Fixed in current master with introducing new topic slides (which replaced old custom slides)


Add support for specifying options in a config file

This commit adds infrastructure to allow subcommands to read default
values from a config file stored in ~/.brkt/config. In order to use
the new infrastructure, subcommands must implement the setup_config()
method. In it, they should register any options they want to pull
from the config.
A new sub-command, "config", has been added to the cli. This lets
users list, set, get, and unset options in the config. It is
modeled after "kubectl config".
Finally, the first consumer of the config infrastructure is the
"encrypt-gce-image" sub-command. The "project", "network", and
"zone" options may be specified via the config.

Oh yeah, I just remembered that you'll need to add your new package to packages in setup.py.  Otherwise setuptools won't install it.

👍

I bet jjv will give you a big hug for this commit.


Bug report: Spinner is visible in update message

Priority
(Low) Something is a little off
Description
Spinner is printed in the notification to install a new update

Steps to reproduce
Let the update notification pop while spinner is enabled.the
Expected results
To see only the update notification without the spinner
Actual results
Spinner visisble
Diagnostics
No response
CLI for Microsoft 365 version
v7.5.0
nodejs version
v20.10.0
Operating system (environment)
Windows
Shell
PowerShell
cli doctor
No response
Additional Info
No response

Seems like this can be solved by changing the https://github.com/pnp/cli-microsoft365/blob/main/src/index.ts file to an async function which gets called at the end, awaiting both the import of the package notifier and the cli.execute statement. What do you think about that?

That will probably be the only way for the spinner not so show indeed.


Create Response Package and change redaction layers

As an IAO analyst

I want to be able to switch between the Redline and Response Package redaction layers

so that I can view or redact different layers

As an IAO analyst

I want to be able to create a Response Package layer

so that I can prepare the package to go to the applicant.

Assumptions & Scope
What are the assumptions for this story?
Analysts need to be able to view or edit different redaction layers.
The redline layer will be the default and will automatically be created when records are loaded into the Records Log.
Analysts will create a Response Package layer in the menu.
What is IN scope?
Creating a Records Package
Toggling between Redlines and Records Packages.
What is NOT in scope?
Saving the layers as PDFs are covered in, #3437, #3231. Stories need a rewrite.
Toggling between OIPIC, Open Info layers, Harms and Sign Off will be in a future story, #3735.
Acceptance Criteria
Scenario 1: Redaction Layer dropdown

GIVEN an IAO analyst is in a request, with records added
WHEN the analyst is in the Records Review app
THEN there will be a dropdown in the organize pane title Redaction Layer
https://jacklyn808742.invisionapp.com/console/Redaction-cla8feezv003o015h7op82c5c/cleg4xqe55wt3018ba31e3cvi/play

Scenario 2: Click Redaction Layer dropdown

GIVEN an IAO analyst is in the Records Review app
WHEN the analyst clicks the Redaction Layer dropdown
AND no Response Package has been previously created
THEN dropdown will open with these options in this order: Redline, Response Package
AND the Redline layer will have no (+) as the layer is created by default
AND the Response Package layer will have a (+) as the layer has not been created
https://jacklyn808742.invisionapp.com/console/Redaction-cla8feezv003o015h7op82c5c/cleg4xqe55wt3018ba31e3cvi/play

Scenario 3: Create Records Package

GIVEN an IAO analyst is in the Redaction Layer dropdown
AND the Response Package layer has not been previously created
WHEN the analyst clicks the (+) next to Response Package
THEN the Response Package layer will be created
AND the Response Package layer will have no (+) as the layer has now been created
AND the Response Package layer will now be shown and editable in the Records Review app

Scenario 4: Click active Records Package in Redaction Layer dropdown

GIVEN an IAO analyst has opened the Redaction Layer dropdown
AND the analyst is on the Redline layer
AND a Records Review Package has been created
WHEN the analyst clicks Records Package in the Redaction Layer dropdown
THEN the Records Package will be displayed in the Records Review app

Scenario 5: Click active Redline in Redaction Layer dropdown

GIVEN an IAO analyst has opened the Redaction Layer dropdown
AND the analyst is on the Response Package layer
WHEN the analyst clicks Redline in the Redaction Layer dropdown
THEN the Redline will be displayed in the Records Review app

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

@m-prodan, @JHarrietha-AOT
Please review this story AC.
@JHarrietha-AOT, could you clarify what the Harms and Ministry Sign Off layers are for in the design?
https://jacklyn808742.invisionapp.com/console/Redaction-cla8feezv003o015h7op82c5c/cleg4xqe55wt3018ba31e3cvi/play
Cc @liseandtea, @KyEggleston , @abin-aot

@lmullane @m-prodan @liseandtea @KyEggleston
Changes based off of conversation at release planning
https://jacklyn808742.invisionapp.com/overview/Redaction-cla8feezv003o015h7op82c5c/screens
Desired future state - for future ticket writing
https://jacklyn808742.invisionapp.com/overview/Redaction-cla8feezv003o015h7op82c5c/screens
Let me know if you have any additional changes or if there was anything I missed from our conversation earlier

@m-prodan and @liseandtea
Is there ever a scenario where an analyst will review and change the redactions in a Response Package? Or must they make the changes in the Redline first, and then create the Response Package?

@m-prodan @lmullane Yes, there are times when an analyst has to make changes to a response package once it has been closed. Usually, this is a breach situation. However, to make the changes, the request has to be re-opened in AXIS and the records moved from the "Request Folder" back to the "Review Log" in document management.

Need to figure out a way to break this up - per refinement, this is likely to be more than a 21, but less than a 40. Need to find the right way to split this story

Possible idea is to split this story up with one story being, create response package, and the second story being the switching between layers.

From what we can see - this story is likely currently being handled with the save response package story. Switching layers is already available.


End-to-end testing

Problem
Our current snapshot testing in packages/core only does so much. It does not:

always make sure that the generated code is even valid JS
that the generated components are valid in regard to the rules of their frameworks
that the generated components have the features they are meant to have (interactivity, state management, styling, lifecycle hooks logic, etc.)

Another big issue is that we do not have a good idea of what features are supported by which generators at any given point. We currently have about 12 generators, and they don't all support every single feature and edge case. It is unfeasible to manually gather that information and keep it up to date.
Ideal process
The ideal process I have in mind to accomplish this type of code coverage is to have an end-to-end testing pipeline like so:

write a Mitosis project containing many components in packages/testing
run it through the Mitosis CLI to generate a directory for each framework we support
render every generated version of every framework on some server (N servers for N frameworks)
For each framework, run the same integration test suite on each of its generated components in Storybook using a tool like Playwright https://storybook.js.org/addons/storybook-addon-playwright

To solve the issue of identifying feature support, we would then add some logic that performs all of these tests against every output, but allows for certain failures. We then need to generate a matrix of feature support (e.g. each row is a feature, each column is a framework) that gets printed in a markdown file in the repo (where this currently lives)
Example
So, if we have a clickable button, say packages/testing/src/button.lite.tsx.
1 - We would run mitosis build, and end up with:

packages/testing/output/vue/button.vue
packages/testing/output/svelte/button.svelte
packages/testing/output/react/button.tsx
packages/testing/output/solidjs/button.tsx
etc.

2- We would load all of those using parallel servers (each in its own Github Action)
3- We would then have a test, say packages/testing/playwright/tests/button.ts. This test would execute on each github action against a different server.
4- We would finally compile all of the results and generate a matrix based on what passed and what failed.
Initial implementation
The quickest way to get an MVP of this idea is:

Create a single, simple test (a div with text)
Output it to just 1 framework (React to start would be good)
import the generated components to a simple server that supports React
run a playwright test that checks that the div has the expected text
do all of the above in a Github Action task

Once that baseline is there, next steps are to:

add more frameworks support: Vue & Svelte
update testing to handle multiple framework tests in parallel

Once we have multiple frameworks, we can then start to generate a ton more tests, and increase framework support gradually!

@kylecordes I don't have much experience with Storybook, so you could be totally right here! Can you point to any well-known issues you're aware of, or have faced regarding this inconsistency? Are there certain outputs it struggles with more than others?
And yeah, my original vision included exactly what you described: a sveltekit server for svelte, a simple solidjs+vite template for solidjs, a nextjs server for React, nuxtjs for Vue (or whatever, I'm just listing the zero friction tools I know of). The bare-minimum, zero-config server for each tool and just import all of the generated code in one page or whatever.
Definitely open to doing that as well. Our hope was to leverage Storybook which would be great for its own non-testing reasons, but we can definitely get started with this parallelized approach first and get going. It'd be much faster to get the ball rolling, and if Storybook is useful, we can always migrate there and delete a bunch of server code :).
I will update the original ticket!

From discussions with @samijaber , here is some elaboration of goals for end to end testing. Two "axes".

A set of small programs which exercise each Mitosis feature. First exercising them in isolation, then in combination. Currently there is 1 such program, likely 10-20 will be needed. For each such program, have a Playwright test.
List of Mitosis targets. As I write this, 6 targets work.

For each combination of program/target, attempt:

Run Mitosis on the input, and get output without Mitosis erroring.
Build the output under the target framework, without erroring.
Execute the output, and verify it passes the Playwright test.

Output the results into a testing status table, which conveniently also serves as a feature support matrix.

Here are some of the obstacles to doing this today; I'm considering how many to work around, vs wait for, vs jump into the middle of Mitosis and fix.
All of these can be worked around... but that's not ideal because the workarounds are further from intended real Mitosis use.
#510 Currently, Mitosis fails if output for any target fails, I have an approach to work around this by running Mitosis separately for each target.
#509 Currently mitosis "build" doesn’t accept parameters; I can work around this by making the config file inspect process.argv.
#494 Currently Mitosis has an internal glob that expects source to under “src”, regardless of the config setting. I could work around this to have a set of test programs by running Mitosis from a different working directory for each.

Closed by https://github.com/BuilderIO/mitosis/pull/445 a while back! 🎉


room for improvement

Bug
I'm listing down a series of bugs, but not before I underline that this is a great initiative, not before I say thanks! and not before I tell you how I got here: I'm also in the business of cross-platform builds https://github.com/rokmoln/support-firecloud . My project is routinely running in the CI on push to master, PRs and sometimes cronjobs on many CI platforms, currently 10. And I try to test critical things. So I have no escape from getting it right. Some weeks ago I wanted to refactor my CI env vars and test them better, and since I don't suffer from the not-built-here syndrome, I first looked around for projects that already do this, thus your env-ci. After trying it out, I realized there's room for improvement and that there are critical things that stop me from using env-ci in my project. So instead I stick to my canonical vars, but I do use env-ci in my tests, to see if we go astray (you have more users etc, so I'd like to benefit from their input/prs).
FWIW you can see my "patches" to env-ci here https://github.com/rokmoln/support-firecloud/blob/master/bin/node-env-ci and you can see my generation of canonical vars here https://github.com/rokmoln/support-firecloud/tree/master/ci/env
Now here goes the constructive findings. First some big things:

[ ] clarify that support is ad-hoc. What I mean is **contributors added a bunch of services and their variables, but we didn't and don't actively test they they work or conform to our definitions
[ ] run cronjobs on CI platforms, at least on those that offer a free plan. This is the only way to make sure that this project is and stays relevant. I for one expected this when I saw the matrix of platforms/variables, and then was surprised that's not the case when I started using it in live environments.
[ ] consider switching the project to pure shell, and if needed to parse JSON (e.g. parse Github Action's event file) use TickTick (pure bash) or jq/python3/python2/node (as in create a shell script that can take a JSON path, and then tries to find any of those executables and proxy the JSON path to them). Node is not available everywhere, and that means that one has to install node very very early in the CI process, in order to make use of a canonical set of variables (in many cases you might want to install a specific version of node via nvm/etc but first you need to deal with the CI env vars; catch 22)

Fix the big things and the following small things become less relevant, because you'll be forced to fix them in order to get green runs:

[ ] clarify the variables, and add clear examples of what those variables should be like given a build for branch X or for PR Y. An example where it's not clear is prBranch: Git branch branch from which the Pull Request originated (only for builds triggered by a Pull Request) (sic, see typo). Is this refs/pull/X/merge or is this some-branch (as named by the PR author in their fork)? For github is the former, for appveyor is the latter.
[ ] clarify not just what they mean, but clarify their naming e.g. you use build and job which are almost on par semantically but what you mean is 1 job -> n builds i.e. 1 workflow/pipeline -> n jobs/builds/runs/task (I go with gitlab's choice 1 pipeline -> n jobs but I'm guessing you took Travis as the reference). Note that there could be distinctions to make whether we talk about design-time or run-time i.e. one job/task can have multiple builds/runs (think github matrix). This is not consistent across the current services. Note also that based on the definitions you choose, your can end up with env-ci's job = ci-platform's build and viceversa, but that's ok as long as env-ci is consistent across all CI platforms.
[ ] clarify what ids/slugs stand for. For some it's internal numbers, for some it's the "slug" to use in a url, etc e.g. job for github there's none, for circleci it's ${env.CIRCLE_BUILD_NUM}.${env.CIRCLE_NODE_INDEX} ?!

Bonne chance! 🙋♂

[ ] clarify that support is ad-hoc. What I mean is **contributors added a bunch of services and their variables, but we didn't and don't actively test they they work or conform to our definitions

I think that is implied given this is an independent open source project.

[ ] run cronjobs on CI platforms, at least on those that offer a free plan. This is the only way to make sure that this project is and stays relevant. I for one expected this when I saw the matrix of platforms/variables, and then was surprised that's not the case when I started using it in live environments.

This sounds like a maintenance nightmare. It's something that could be done as a for profit-service, but not as a small library. Given the wide usage of this package, problems with the supported CI providers pop up quickly and are simple to address.
This is a non issue.

[ ] consider switching the project to pure shell

No, sorry
For your remaining suggestions, it sounds mostly like improving to the docs. We'd appreciate separate pull requests so we can discuss each improvement in isolation.
There is nothing actionable in this issue so I'm going to close it, but feel free to comment if you have anything to follow up on


Migrate to JUnit 5

We're still using JUnit 4 everywhere, and we should at some point migrate to JUnit 5 which has been out for over a year now and appears to have a number of cool features that might be useful or instructive.
Not a huge priority, though, especially if no one has any particular ideas/plans for using the new JUnit 5 features.

Archiving this repo.


ConfigDataLoader logging

I was looking at an issue that a user reported, and while debugging it saw an interesting thing.
In KubernetesConfigDataLoader, if we added some logging, for example:
private final Log log;

	public KubernetesConfigDataLoader(DeferredLogFactory factory) {
		log = factory.getLog(getClass());
	}

	@Override
	public ConfigData load(ConfigDataLoaderContext context, KubernetesConfigDataResource resource)
			throws IOException, ConfigDataResourceNotFoundException {

		log.debug("Kicking off ConfigDataLoader processing");

                ....

DeferredLogFactory is injected and I do see the logs I generate. But then, this method calls:
propertySources.add(bootstrapContext.get(ConfigMapPropertySourceLocator.class).locate(env)); or ConfigMapPropertySourceLocator::locate and the logs there are not present. I've tried to play around with DeferredLog, but with no luck.
I also saw this issue, but again, did not either understand or did not implement correctly.
Any hints into the direction of how to log these would be lovely, if any is possible at all.
Without this, we are kind of blind what is going on

@philwebb do you have any insights?

The DeferredLogFactory instance passed to the KubernetesConfigDataLoader constructor should be transferred to a real logger once all environment processing has occurred.
The exact order should be:

EnvironmentPostProcessorApplicationListener is created to trigger Environment post-processing. It includes a DeferredLogs instance (which is a DeferredLogFactory) that gets past to post-processors.
The ConfigDataEnvironmentPostProcessor is one such post-processor. It will create ConfigDataLoader instances and should pass the same DeferredLogs instance along.
The loader can call DeferredLogFactory.getLog(...) to create a Log instance. Calls on the resulting logger are tracked but not actually logged at this point.
After all post-processing has finished, the EnvironmentPostProcessorApplicationListener.finish() method should be called.
This triggers DeferredLogs.switchOverAll() which should finally push the log messages to a correctly configured logger.

Adding a breakpoint to DeferredLogs.switchOverAll() would be a good place to start debugging why you're not actually seeing log messages.

thank you @philwebb , but it seems to me that we are talking about slightly different issues here.

I do see logs from KubernetesConfigDataLoader - no problem here.
The problem is that KubernetesConfigDataLoader::load internally calls ConfigMapPropertySourceLocator::locate and that one does some logging also. This logs is what I do not see, and that is the problem.

This is the chain that I was wondering if it's possible to make it work. I hope I make sense.

If I look at this class here, I notice :
@SuppressWarnings("FieldMayBeFinal") // allow setting via reflection.
private static Log logger = LogFactory.getLog(LeaseAwareVaultPropertySource.class);

and in this usage here
I notice that they override the loggers, otherwise no logging is going to work - just like in our case.
Ryan, it seems to me that we will need to do the same thing

If you agree with the above, I have a PR here for fixing it.

@wind57 have you tried passing the DeferredLogFactory to ConfigMapPropertySourceLocator?  Could we have a setter that if called overrides the default Logger?

we could, absolutely Ryan. But then there are many other classes that are called internally... which makes this setting impossible. We would hav to pass this logger everywhere.
I also agree that it's a bit hacky to do it with reflection, but if Vault does it...

either way, we need a solution here and fast (imho), because users using config-data are totally without logs, not being able to tell if anything is wrong at all.

although I gave up on this idea, I will expres it still: we can use ThreadLocal and set the logger into it and have a "proxy" that will check if the logger is present in ThreadLocal. The only reason I did not even try to implement something like this, is the fact that vault was using reflection and the be fair, I thought that this is OK and may be we want to be consistent. may be I was wrong.

we could, absolutely Ryan. But then there are many other classes that are called internally... which makes this setting impossible. We would have to pass this logger everywhere.

I dont think so, we leave the creation of the logger as is just not making it static then we add a setter and just call the setter in the config data case.

OK, so you are saying that ConfigMapPropertySourceLocator should have a setter where we can pass a different logger and override the existing one. So far, yes, it makes sense.
But ConfigMapPropertySourceLocator::locate calls internally KubernetesClientConfigMapPropertySourceLocator::getMapPropertySource that calls internally KubernetesClientUtils::getApplicationNamespace. How is the logger going to be passed down to KubernetesClientUtils? what am I missing?

Yeah, I guess we would end up passing the logger around.  But wouldn't that be the same problem with reflections where we would have to be calling all these classes and setting the logger in them?

imho, reflection is easier to manage, and no obscure code in the logic of how things are really done. There would be additions of public methods for those setters.
It's a lot easier to manage too, if u ask me.

@philwebb what do you think?  I like you don't think reflection is the right approach, but we can't be the only project (in fact Vault also is suffering from this) that would have the pass the Logger around in order to get things working.

We should replace the question label with a bug label

I was also wondering, considering the timelines for the next release (which I don't know what is), what if we have some solution in (even the reflection one), but keep this issue open in case we come up with something smarter? I feel weird for the fact that we made some good work on that config-data functionality and it's kind of useless in case things don't work :(

The release will happen either tomorrow or today.  I would rather not rush.  The feature still works, its just logging that is the problem so this is not a blocker IMO.  A service release will certainly be planned shortly after because as always we will have issues that come up.

I like you don't think reflection is the right approach, but we can't be the only project (in fact Vault also is suffering from this) that would have the pass the Logger around in order to get things working.

No, it's unfortunately a bit of a tricky issue and I don't really have a good suggestion. We have https://github.com/spring-projects/spring-boot/issues/28678 open in Spring Boot to look at it generally, but we're unlikely to get to it anytime soon.

seems to me like we won't have an option

Thanks @philwebb.
@wind57 lets tackle this after the new year.  I am on vacation beginning next week and wont be back till after the new year.  I will spend some time when I get back looking at the options.

of course! happy Holidays in such a case Ryan!

you too!

I have two proposals of implementations to may be solve this:
one here that uses the new feature of JDK : hidden classes.
another one here, that just uses reflection.

Thanks!

If they fix the issue, as @philwebb says there are no plans for this one in the near future. Personally, I see no problems with either hidden classes nor reflection, as long as we provide logging for the end-users.
To ease the transition in the future, I wanted to:

create a PR with tests that assert logging, so that we have tests and ensure the build fails if something is not OK
have a separate PR that drops this implementation (whatever we choose from the two), so that is eases our future Boot integration, when such is available.

I feel somehow awkward having even a band-aid, but then not providing it... just my 0.02$

@philwebb does this still seem like its going to happen in the near future?

I sound like a broken record here, still, what is a path forward here? If any. I am not trying to be pushy at all, it's just that this issue stays like a knot in my throat after all the pain I had to go with the user that reported it, nothing else :) thank you upfront.

@wind57 please keep bugging me, I need to get with @philwebb to have a quick discussion
I have a couple of other things on my plate at the moment but I will try to get to this soon.

@ryanjbaxter random 2 weeks reminder... :)

I have discussed this issue with a number of people on the team, ultimately everyone has come back to the point that the amount of code needed to fix the issue outweighs the issue itself.  We would be much more concerned if this caused the application to not work properly, but ultimately the app will work fine, we just might run into some trouble debugging things.
I think at this point we close this issue, as its something Spring Boot needs to address.
I also want to acknowledge your effort in trying to find a viable solution to the problem, that has not gone unnoticed 🙌

oh it was a fun issue digging in! I just feel already bad for whomever is going to triage an issue when it comes (like the one we had) and logs are mute :) but I can't disagree either... Closing.
I am also going to close the two PRs I had with proposals.
In the background I am still going to maintain one of them, in case a future issue comes in and I want to help

So there are log statements but the output is actually never logged due to https://github.com/spring-projects/spring-boot/issues/28678 right?
Is there any workaround to see the logoutput to find erros e.g. missing permissions for the service account to load a config map?


Improve UI of Windows by including https://github.com/ModernFlyouts-Community/ModernFlyouts

Description of the new feature / enhancement
Improve UI of Windows by including https://github.com/ModernFlyouts-Community/ModernFlyouts
Scenario when this would be used?
More beautiful styles when changing volume etc.
Improve UI of Windows by including https://github.com/ModernFlyouts-Community/ModernFlyouts
Supporting information
Improve UI of Windows by including https://github.com/ModernFlyouts-Community/ModernFlyouts

If you like their stuff, please use it.  Best place for this feedback would be Windows feedback hub.


Feedback on using elastix for deformable prostate registration

We are in the process of incorporating elastix into the SliceTracker extension in 3D Slicer that we use to support in-bore targeted prostate biopsy (see publications in the extension documentation for references etc).
The registration problem we need to solve is registration between T2-weighted high-resolution scan of the prostate obtained before the procedure (typically, with the use of endo-rectal coil), and the intra-procedural T2-weighted scan of somewhat lower in-plane resolution (no endo-rectal coil).
Until now, we used registration tools included in 3D Slicer in that extension (details in this publication), but we want the software to be modular so we can experiment with the registration strategies, and we also think elastix registration might be a better registration tool anyway.
To do registration with elastix, we use an application-specific initializer (rigid alignment of the centroids of the segmented masks of the prostate and rough grid search to improve the initial pose), passing the the moving image after applying the rigid transform to elastix, and using one of the default parameter files with minimum changes. You can see the discussion and specifics on how we initialize the parameters here:

https://github.com/SlicerProstate/SliceTracker/issues/334
https://github.com/SlicerProstate/SliceTracker/pull/341

Based on the initial testing on a couple of datasets, we are getting good results. We have a reasonable-sized dataset annotated with landmarks that we next planned to use to measure TRE and compare elastix registration with the approach we are using currently for a more principled comparison. Before we do that, we would like to check with the elastix experts on whether the parameterization we use requires any modifications. Would you mind taking a glance at the parameter files, and let us know if you have any recommendations?
To be clear, things seem to work, and we have no specific problem, but we would appreciate if the elastix experts could give us the "blessing", to make sure we use it in the most optimal way, before we do the quantitative evaluation of the registration accuracy.
cc: @che85

Sure I can take a look @fedorov, but can you link directly to the parameter files or just post them here? It is not clear to me where to obtain the parameter files in the two discussions you listed. Thanks!

@kaspermarstal thanks!
You can see the parameter files for rigid/affine/b-spline in this pull request:

rigid: https://github.com/SlicerProstate/SliceTracker/pull/341/files#diff-35c17ae0c6fc45f6280c8c6719d7c54b
affine: https://github.com/SlicerProstate/SliceTracker/pull/341/files#diff-04aa48b3655e2714bb803a80c1035da4
b-spline: https://github.com/SlicerProstate/SliceTracker/pull/341/files#diff-3aa4e49b9ded4e59482b10be9c35f37b

FixedImagePyramid should be FixedImageSmoothingPyramid for best results (unless memory is really and issue).
AutomaticTransformInitialization should be true for rigid and false for affine and bspline.
250 number of iterations is also on the low side. If speed is really an issue, 250 is fine, but if you can afford it use at least 512.
Depending on the problem you might want to use at least 3 resolutions. Some places you use 2 which is on the low side.
ImageSampler should be RandomSparseMask if users use masks. Otherwise it is fine.
If you use a BSplineInterplationOrder of 1 you might as well use LinearInterpolator which produces the same results but is faster.

Otherwise it looks good!

@kaspermarstal thank you for the feedback! Since my last update, we did more testing, and the elastix registration unfortunately does not always work. But I am sure we will figure it out with your help! @Kmacneil0102 is currently working to reproduce the issues on a public dataset, and we will update this thread as soon as we have results.
See my responses to your suggestions:

AutomaticTransformInitialization should be true for rigid and false for affine and bspline.

We use external application-specific initializer. The initializer we implemented takes the segmentation masks of the prostate in the two images, aligns their centroids, and then does sparse search to optimize the metric by rotating the images over small range (don't remember now in what plane!). This initializer has been working quite well, and I don't think default initializer could replace it. Unless you already have something similar in elastix?

Depending on the problem you might want to use at least 3 resolutions. Some places you use 2 which is on the low side.

We actually started with the default 3, but then reduced, since our region of interest is quite small (could be as small as 5-10% of the total image volume probably), and so there may not be enough data to subsample. Reducing resolutions helped somewhat with making the configuration more reliable.
We will update the rest of the parameters as you advised - it all makes sense to me!

OK great! One comment:

We use external application-specific initializer [...]

OK, then make sure to set AutomaticTransformInitialization to "false" for all parameter maps. It was true for the first one, which will discard your custom initialization.

@Kmacneil0102 can you please update the configuration as suggested above before running the experiments?

closing for now, you can reopen when needed.


Polish get kafka docker

I cleaned up get_kafka_docker to address a few problems:
It shouldn't need to have a GITHUB_TOKEN
It shouldn't request the releases list data when we already know the tag we want and can get just that release's datum.
It should just the release's url directly, instead of rebuilding that using the release's id and our other variables.
There should be a way to specify VERSION and ARCH at call-time.
Also I added some comments explaining what some of the more involved lines in this script do.

I know I'm a bit late to this party, but Travis is known to be finicky. Was this tested on Travis prior to merging, by any chance?

dl_kafka_docker downloads and runs this script from everywhere. (I have changes in the pipeline to update those scripts too)
Important:
The only reason this might explode is if ARCH or VERSION are set in the environment.
If we have an ARCH that means something different, I'm open to renaming it, but otherwise it would be beneficial to keep this consistent.
Should we change VERSION to be KAFKA_DOCKER_VERSION?
Why Polish? We're adding diversity, the next version is from Ecuador.

Another pile in after the fact:
They probably should both be KAFKA_DOCKER_*. I know I have seen people set ARCH in other contexts and it's usually not in the format used by go.

On it, will have changes prepared soon.


Reject embedded Tasks with APIVersion and/or Kind specified

Changes
fixes #4543
If custom tasks are enabled and either of PipelineTask.TaskSpec.APIVersion or PipelineTask.TaskSpec.Kind are specified, the PipelineTask will be treated as a custom task. This is still the case if an actual embedded Task is specified in PipelineTask.TaskSpec.TaskSpec, so we should be failing validation for those cases.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes
Fail PipelineTask validation if a normal, non-custom embedded task is specified along with `apiVersion` and/or `kind`

/assign @wlynch @vdemeester @lbernick @jerop

/retest

@lbernick Not sure about what to document in that regard - what this change is doing is making specifying apiVersion and/or kind and a populated pt.TaskSpec.TaskSpec invalid. So assuming this goes in, you won't be able to specify a Task's apiVersion in a PipelineTask at all.

@lbernick 👍 - in practice, that's obviously just clarifying what's always been the case, but still worth having. =)

/lgtm


Failed to evaluate with latest nixpkgs as this overrides callPackage

Because of this nixpkgs commit in php uses callPackage, and in your repo, here overrides callPackage with adding two arguments. This will make install-pear-nozlib-phar.nix in nixpkgs failed to evaluate as:
       error: function 'anonymous lambda' called with unexpected argument 'pkgs'

       at /nix/store/9pbyw6i1aksn6l5ymm3fxldpsjvkjg4g-source/pkgs/development/interpreters/php/install-pear-nozlib-phar.nix:1:1:

            1| {
             | ^
            2|   fetchurl

Hi!
Thanks for reporting this.
Going to provide a fix today.

Besides reverting my commit in nixpkgs, I have no clue on how to fix this in here.
@jtojnar any clue?

Probably https://github.com/fossar/nix-phps/blob/9804430b760dadd414cc7457fc24e2c71713c168/pkgs/phps.nix#L106

I don't understand :(

@jtojnar Do you have another hint so I can fix this?

Maybe check if cpArgs contains pkgs and only // it then?

I couldn't find a way to get it working. Should I revert what I did in nixpkgs ?

If you wish. To be honest, I still do not see the point of the change in the first place.

The ideas behind that commit were:

Easily override src, without using overrideAttrs
Let generic.nix build PHP from the official php-src git repository

I really wish to avoid reverting it because I still believe that change make sense.
If we revert that commit, we cannot build PHP from its sources(git), only from the distribution(php.net) and it would be really sad if we can't do that.

Well, I do not really mind overrideAttrs. But either way, the offending part of the commit is the pear thing, which is good idea IMO, and would cause issues even if we got rid of the phpSrc attribute.
The issue is really in nix-phps.
I would try something like
cpArgs
            // lib.filterAttrs (key: _v: builtins.hasAttr cpArgs key) {...}

I tried, without luck :(

Other option might be something like
(prev.callPackage cpFn cpArgs).override (prevArgs: lib.filterAttrs (key: _v: builtins.hasAttr (builtins.attrNames cpFn) prevArgs) {...})

Same issue as before:
callPackage =
        cpFn:
        cpArgs:

        (prev.callPackage cpFn cpArgs).override (prevArgs: prev.lib.filterAttrs (key: _v: builtins.hasAttr (builtins.attrNames cpFn) prevArgs) {
          pcre2 =
            if prev.lib.versionAtLeast args.version "7.3"
            then prev.pcre2
            else prev.pcre;

          # For passing pcre2 to stuff called with callPackage in php-packages.nix.
          pkgs =
            prev
            // (
              prev.lib.makeScope
                prev.newScope
                (self: {
                  pcre2 =
                    if prev.lib.versionAtLeast args.version "7.3"
                    then prev.pcre2
                    else prev.pcre;
                })
            );
        });

Error:
❯ nix build .#php80 -L
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'php-with-extensions-8.0.30'
         whose name attribute is located at /nix/store/mp4clz8rfv9vwl1n589kmkcp9k36ynkc-source/pkgs/stdenv/generic/make-derivation.nix:311:7

       … while evaluating attribute 'buildCommand' of derivation 'php-with-extensions-8.0.30'

         at /nix/store/mp4clz8rfv9vwl1n589kmkcp9k36ynkc-source/pkgs/build-support/trivial-builders/default.nix:87:14:

           86|       enableParallelBuilding = true;
           87|       inherit buildCommand name;
             |              ^
           88|       passAsFile = [ "buildCommand" ]

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: value is a path while a set was expected
~/C/f/nix-phps > master +5 -10 [!?] ✘


Hardcode color values since v23 of appcompat no longer has color names.

Verified that @doncung has signed the CLA. Thanks for the pull request!


Void linux dependency commands

Is your feature request related to a problem? Please describe.
No commands for void linux
Describe the solution you'd like
Adding the dependency install instructions like below.
xbps-install -S gpgme-devel libxcb-devel libgpg-error-devel gnupg

Awesome, thanks! 806c05d


Fix Kernel#sprintf %c to_int spec to test what it advertises

There is another spec that tests to_str already, just above this one.

Thank you.


Help wanted!

When I started this project, in close collaboration with @timholy, I had the opportunity to spend a lot of my coding time with Julia, as I was actively using it myself. For quite some time now, this is no longer the case, and Julia programming has been pushed back on my priority list to the place of "hobbies I can't quite find the time for".
This was fine as long as the packages I maintained were relatively stable, with little activity in issues and pull requests, but lately I've felt that there is more and more going on that I'm unable to keep up with. Thus, I feel I'm no longer doing as well as I'd like as a maintainer, and I think it's time to pass the baton to someone else.
I'm opening this issue as a call for a discussion on where this package should live. Would you like to assume ownership? Do you know of an organization that would?

Thanks for having the bravery to admit limits. I struggled with this for a long time with HDF5/JLD before finally deciding that I just couldn't do it anymore.
Out of curiosity, is your migration away from Julia a decision you came to on your own, or a product of circumstance?
As far as organizations go, perhaps JuliaMath?

It's mostly a matter of circumstances. When I discovered Julia, I was studying for a masters degree in engineering physics, and could choose whatever tools I liked. Julia was a fantastic choice (I'm sure I don't have to convince you about this :D) and I gladly spent the extra time needed to build stuff that didn't exist yet.
Instead of in physics, I ended up as a .NET programmer with no real use case for Julia at work (for now, at least), and with less spare time for hobby projects of this magnitude. And I've become more serious about learning F#, which is more relevant than Julia for work, but competes about the same parts of my spare time.
I'm actually hoping to move my career in a direction where Julia might be a valuable tool again, and in that case I'm expecting to return to being an active member of the community. However, since I have no idea how long that might take, if it ever happens, I think it makes sense to step down meanwhile.

Re: JuliaMath, what's the best way to contact them as an organization? Tag some of the members here? Send an email to somewhere? Post in a discourse group? (It shows that I've been out of the loop for a while...)

Seem OK to move this to JuliaMath? CCing the owners: @Aerlinger, @andreasnoack, @ararslan , @JeffBezanson, @jiahao, @mauro3, @simonbyrne, @StefanKarpinski, @stevengj, @tkelman, @ViralBShah.

Bummer!  And thanks for the cool package!
Moving this to JuliaMath would be fine (although not 100% fitting), but that would not really solve the maintainer problem...

@mauro3, do you know of a better org?

No.

@tlycken I can help maintain, if we can find one other person willing to sign on as a co-maintainer
Thanks for the work here!

While I can't say I can help maintain, we will do our best at Julia Computing to help with the maintenance load on this package. Let's get it to JuliaMath.

OK, what's the best approach? Either we can make @tlycken an owner of JuliaMath, or he can grant ownership privileges to someone who is an owner on JuliaMath. In addition to the CC list above, I'm an owner.

@timholy Best approach is for you to get the ownership of the package and then you can move it to JuliaMath.

You OK with that, @tlycken? Obviously you can keep yourself as an owner, too.

Another +1 for JuliaMath. It sounds like a good fit to me and I'd also be happy to help maintain the package.

Great! I'm now a member of the JuliaMath org.
However, if I transfer ownership of this package to the org, won't package installs etc break? What has to be updated in METADATA.jl? (Is there anyone here that wouldn't mind taking care of all that plumbing for me, once I transfer the repo?)

GitHub will forward it automatically, at least for a time. And I'll be happy to handle the changes elsewhere (it's basically updating the badges in the README, and the url in METADATA).

It's done!
I'll gladly remain a co-admin of this repository, so that, should I find time in the future, the hoops I need to jump to get back in are as few as possible. But now things like tagging releases, reviewing pull requests and activating tools like attobot won't require waiting for me anymore :)
Thank you, everyone, for being so helpful and supportive.

And you should double-check that all CI services are still / re - enabled

Great!
If you would like me to help maintain the package I will need access to it here in it's new home. Could someone with the right permissions please add me? Thanks!

I sent you an invite.

Great thanks!

Thanks @tlycken for making this awesome package, and thanks to all who've volunteered to continue maintenance so that the package can keep being awesome. And to the new JuliaMath members: welcome. 🙂


refactor: cache partition_schema in fn plan_files()

Which issue does this PR close?
Closes #361
Rationale for this change
This is a left-over part from #360
Tries to solve the unresolved issue of creating a new PartitionSchema in every iteration / or for each ManifestFile.
What changes are included in this PR?

refactor: add PartitionSchemaCache
refactor: clone only if cache miss

Are these changes tested?
Yes. Unit tests from before.

@sdd @liurenjie1024
PTAL, in regards to rust idiomatic code.
For example using &Arc to clone only if we have a cache miss.
I'm unsure about those parts - and tried not to overcomplicate things.

@sdd @liurenjie1024 PTAL


Update Iggy dependency and add basic auth to the client

Potentially resolves issue #2.
Changes:

updated the Iggy dependency to the latest version in the Cargo file
added a new method for user authentication using basic credentials
updated the example code to include the authentication step

Feedback and suggestions, especially regarding the idiomatic use of Rust, are greatly appreciated  :pray:

Nice! lets ship it!


[CBR-371] unit tests for listing addresses

Description
This PR adds tests for listing addresses:

the results are always deterministic (in the sense that doing the same request 2 times yields the same response)
paginating the results, yields no duplicate results.
paginating the results may bring them in a different order (e.g. requesting 10 + 10 results in two pages will bring the same results but in different order than if we requested 20 in one page).
The last point does not apply if there is a single account. In that case results are always in the same order.

UPDATE: a very small bug affected pagination when there are multiple accounts (see the diff in wallet-new/src/Cardano/Wallet/WalletLayer/Kernel/Addresses.hs). Now order is consistent always.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-371
Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[ ] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[ ] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[ ] I have read the style guide document, and my code follows the code style of this project.
[ ] If my code deals with exceptions, it follows the guidelines.
[ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

We discussed this with @kderme , and we agreed he will open a separate ticket for the cleanup as requested by my original review.

cleanup ticket at https://iohk.myjetbrains.com/youtrack/issue/CBR-435


Small bugs

Hi,
I've two small bugs:

First, when I re-source my vimrc, I've bracket appearing. I'd expect them to appear on startup or not at all. Maybe it is some kind of conflict with the nerdtree-git-plugin but I respected the order:

" here because of webdevicons
NeoBundle 'bling/vim-airline'

NeoBundle 'scrooloose/nerdtree'
NeoBundle 'Xuyuanp/nerdtree-git-plugin'
NeoBundle 'jistr/vim-nerdtree-tabs'

NeoBundle 'ryanoasis/vim-webdevicons'
"NeoBundle 'ryanoasis/nerd-filetype-glyphs-fonts-patcher'

I've a vim file by type of plugins and I moved vim-airline into the nerdtree.git as well as yours.
Here are some images: before: before and after: after

second bug is best shown:  bug2

Please let me know what information you need :)
Thanks

per bug 1 - I have confirmed it as well on my end. re-sourcing causes the brackets to appear
per bug 2 - Not quite sure I see what you think the bug is here? the misalignment due to having both this plugin and git-nerdtree-plugin ? Can you please elaborate?

About the second but I've no idea. Could it be that nerdtree-git-plugin uses too wide characters ?
Could it be some padding added by your plugin that should not be added because git-nerdtree-plugin display something itself ?

@daedric I dont think the second issue is a bug but it could be the default setting isn't good enough.
You can adjust the padding:
let g:WebDevIconsNerdTreeAfterGlyphPadding = ''

Let me know if that helps with the 2nd issue, I might need to look into the default setting for true mono fonts.
As for the 1st issue I am looking into it.

@daedric Okay I think I have something that will at least help.
Can you pull the latest and then add this to your vimrc (after any setting of syntax):
" after a re-source, fix syntax matching issues (concealing brackets):
if exists("webdevicons#refresh")
	call webdevicons#refresh()
endif

Still no luck ! I added your snippet at the end of my vimrc.
If it helps, I can create a tarball of my vim config so you can test if you're not able to reproduce the problem...

BTW, the padding stuff did not really improve. There is still some misalignment issue.

@daedric Yes if you could send me your vimrc I can try to see if it works for me.
The misalignment I think I will try to add a filler character if the node has a git related flag, hopefully not too hard to do.

@daedric For the misalignment how does this look to you:

Yep.
I prepare a tarball with my vim configuration (it is split in several files)

@daedric Okay let me know when and where to download it and I will test out the re-sourcing :+1:

http://daedric.fr/vimconf.tgz

@daedric Thanks I'll let you know!

@daedric can you try this at the bottom instead:
if exists("g:loaded_webdevicons")
	call webdevicons#refresh()
endif

Note: I did try to use your vimrc but I don't use neobundle and had some errors but I did see that the fix I gave you actually was not working for me as well but this version seems to work

You should maybe disable YouCompleteMe, it requires a CMake, a c++ compiler, and python development libraries.
I tried your new fix. It does not work for me :(
Thanks for trying !

I actually use YouCompleteMe
What if you call webdevicons#refresh() directly after re-sourcing?

No luck :(

Hmm that should at least do something. Does it open and close nerdtree if it is open (it should at least do that) ?
Do you have any errors in :messages after executing?
You are up to date with the lastest code in master?

@daedric I am considering closing this for now, I cannot replicate. I added some of the notes to the readme. We can open a new issue if it persists :smile:

no problem :) good luck !