imagemagick7: 7.0.8-2 -> 7.0.8-6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/imagemagick/versions.
meta.description for imagemagick7 is: '"A software suite to create, edit, compose, or convert bitmap images"'.

Checks done (click to expand)

built on NixOS
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/animate passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/compare passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/composite passed the binary check.
Warning: no invocation of /nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/conjure had a zero exit code or showed the expected version
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/convert passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/display passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/identify passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/import passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/magick-script passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/mogrify passed the binary check.
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/montage passed the binary check.
Warning: no invocation of /nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/stream had a zero exit code or showed the expected version
/nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6/bin/magick passed the binary check.
11 of 13 passed binary check by having a zero exit code.
0 of 13 passed binary check by having the new version present in output.
found 7.0.8-6 with grep in /nix/store/mny398c69fwzg6p6vvjyay6zzfgf260z-imagemagick-7.0.8-6
directory tree listing: https://gist.github.com/9d0a1f08073d0329d7b8c78948dacf2b
du listing: https://gist.github.com/7a02d4e51b6ec082ad14594bc94ae6cf

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 178b2ba17e4cebfacf296cc822800cdbeac4395d && nix-shell --pure -I nixpkgs=. -p imagemagick7

cc @the-kenny @wkennington for testing.

Success on x86_64-linux (full log)
Attempted: imagemagick7
Partial log (click to expand)
stripping (with command strip and flags -S) in /nix/store/vm696zhz7zx0r4q2cnq370nfiys91zyy-imagemagick-7.0.8-6-dev/lib  /nix/store/vm696zhz7zx0r4q2cnq370nfiys91zyy-imagemagick-7.0.8-6-dev/bin
patching script interpreter paths in /nix/store/vm696zhz7zx0r4q2cnq370nfiys91zyy-imagemagick-7.0.8-6-dev
/nix/store/vm696zhz7zx0r4q2cnq370nfiys91zyy-imagemagick-7.0.8-6-dev/bin/Magick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/vm696zhz7zx0r4q2cnq370nfiys91zyy-imagemagick-7.0.8-6-dev/bin/MagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/vm696zhz7zx0r4q2cnq370nfiys91zyy-imagemagick-7.0.8-6-dev/bin/MagickCore-config: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /tmp/nix-build-imagemagick-7.0.8-6.drv-0 in /nix/store/vm696zhz7zx0r4q2cnq370nfiys91zyy-imagemagick-7.0.8-6-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/hxlildsxxldiwqrmwxbdwd29wdjzk867-imagemagick-7.0.8-6-doc
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/hxlildsxxldiwqrmwxbdwd29wdjzk867-imagemagick-7.0.8-6-doc
checking for references to /tmp/nix-build-imagemagick-7.0.8-6.drv-0 in /nix/store/hxlildsxxldiwqrmwxbdwd29wdjzk867-imagemagick-7.0.8-6-doc...

Success on x86_64-darwin (full log)
Attempted: imagemagick7
Partial log (click to expand)
/nix/store/zvc6f6kzq6yxkimyhmfjd9fx5nprf6qg-imagemagick-7.0.8-6/lib/libMagickCore-7.Q16HDRI.6.dylib: fixing dylib
/nix/store/zvc6f6kzq6yxkimyhmfjd9fx5nprf6qg-imagemagick-7.0.8-6/lib/libMagickWand-7.Q16HDRI.6.dylib: fixing dylib
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/r04w8fpyvh8slsbacmg90f2gdnw31jk4-imagemagick-7.0.8-6-dev/lib  /nix/store/r04w8fpyvh8slsbacmg90f2gdnw31jk4-imagemagick-7.0.8-6-dev/bin
patching script interpreter paths in /nix/store/r04w8fpyvh8slsbacmg90f2gdnw31jk4-imagemagick-7.0.8-6-dev
/nix/store/r04w8fpyvh8slsbacmg90f2gdnw31jk4-imagemagick-7.0.8-6-dev/bin/Magick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/r04w8fpyvh8slsbacmg90f2gdnw31jk4-imagemagick-7.0.8-6-dev/bin/MagickCore-config: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
/nix/store/r04w8fpyvh8slsbacmg90f2gdnw31jk4-imagemagick-7.0.8-6-dev/bin/MagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/q2wqq1k20v8kc3vckapqf5nws30brnni-bash-4.4-p23/bin/sh"
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/409vx9ny102c7yn6fid3xv54yjaqx9fs-imagemagick-7.0.8-6-doc

Success on aarch64-linux (full log)
Attempted: imagemagick7
Partial log (click to expand)
patching script interpreter paths in /nix/store/24lvi2850i7shgy2gmmkv8lsv98fq8ik-imagemagick-7.0.8-6-dev
/nix/store/24lvi2850i7shgy2gmmkv8lsv98fq8ik-imagemagick-7.0.8-6-dev/bin/MagickWand-config: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/24lvi2850i7shgy2gmmkv8lsv98fq8ik-imagemagick-7.0.8-6-dev/bin/MagickCore-config: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/24lvi2850i7shgy2gmmkv8lsv98fq8ik-imagemagick-7.0.8-6-dev/bin/Magick++-config: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/24lvi2850i7shgy2gmmkv8lsv98fq8ik-imagemagick-7.0.8-6-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/p5xshf2449l6jv58kxj0zjsa9sdnjmk2-imagemagick-7.0.8-6-doc
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/p5xshf2449l6jv58kxj0zjsa9sdnjmk2-imagemagick-7.0.8-6-doc
checking for references to /build in /nix/store/p5xshf2449l6jv58kxj0zjsa9sdnjmk2-imagemagick-7.0.8-6-doc...
/nix/store/0cscwlv7smx49fyqgxl7zf10wgmvfr0k-imagemagick-7.0.8-6


Add codecov for test coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@139e770). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage        ?   91.66%
=======================================
  Files           ?        1
  Lines           ?       24
  Branches        ?        0
=======================================
  Hits            ?       22
  Misses          ?        2
  Partials        ?        0

Flag
Coverage Δ

unit
91.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139e770...c4636e6. Read the comment docs.


Add cli option for save-screenshot=false

Running tests that include taking screenshots repeatedly (e.g. during debugging) results in unnecessarily high numbers of screenshots. Commenting out multiple screenshots in various files is a tedious task that might be automated using a cli parameter to skip all screenshot calls.

https://github.com/js-soft/wdi5/pull/69

https://github.com/js-soft/wdi5/pull/69

solved in PR as commented

solved in PR as commented


Dev/layout

fixed various errors resulting from renaming
added clickhandlers instead of Link components
created a fixed 'whos here' list at the bottom of screen with avatars
various other minor styling 'tweaks'
not working quite as it should in < 768px breakpoints, need to spend more time working out what to do there.
Add any links to relevant Trello/Invision urls.
Done Checklist

[ ] Feature implemented or bug resolved as per the Trello card
[ ] All acceptance criteria are met
[ ] Tests have been added or updated
[ ] Views are responsive for mobile devices
[ ] Feature files have been written or updated
[ ] Changelog updated where appropriate

Clicking on avatar toggles a status update with sign out button:


Cilium client-go incompatible with ConsistentListFromCache Feature Gate in Kube 1.28

Is there an existing issue for this?

[x] I have searched the existing issues

Version
equal or higher than v1.15.7 and lower than v1.16.0
What happened?

Note: this is a minor bug because we have a workaround but I'm filing it to document it in case other people encounter similar issues

We enabled the ConsistentListFromCache alpha Feature Gate on our Kubernetes 1.28 clusters and noticed that Cilium 1.15 Agents started randomly crashing during the rollout. They eventually recover but the rollouts take a really long time to finish.
The agents look something like this after the rollout (note the restarts):
$ kubectl get pods
NAME                                           READY   STATUS    RESTARTS        AGE
cilium-agent-n46xh                             3/3     Running   0               169m
cilium-agent-ndgz2                             3/3     Running   8 (145m ago)    162m
cilium-agent-nql8x                             3/3     Running   0               36m
cilium-agent-nznx9                             3/3     Running   11 (97m ago)    119m
cilium-agent-p66gp                             3/3     Running   9 (61m ago)     79m
cilium-agent-pbdfm                             3/3     Running   2 (115m ago)    119m
cilium-agent-qdgb4                             3/3     Running   5 (47m ago)     59m
cilium-agent-qjt87                             3/3     Running   0               169m
cilium-agent-qvr52                             3/3     Running   0               72m
cilium-agent-rqvht                             3/3     Running   3 (40m ago)     47m
cilium-agent-s64nw                             3/3     Running   5 (47m ago)     58m
cilium-agent-sgzsk                             3/3     Running   4 (60m ago)     69m
cilium-agent-spsnh                             3/3     Running   0               121m
cilium-agent-swgsj                             3/3     Running   0               86m
cilium-agent-tcngn                             3/3     Running   5 (86m ago)     97m
[...]

When describing a random pod, we can see this on the main Agent container (note the surprising exit code 2):
    Last State:     Terminated
      Reason:       Error
      Exit Code:    2
      Started:      Wed, 23 Oct 2024 12:28:31 +0200
      Finished:     Wed, 23 Oct 2024 12:32:01 +0200
    Ready:          True
    Restart Count:  2

When looking at logs of containers which crashed, none of them log any explicit errors but they all finish with:
{"level":"info","msg":"Waiting for CiliumNode custom resource to become available...","subsys":"ipam","time":"2024-10-23T10:16:40.946284455Z"}

When we look at API server logs, we can see that there is a big spike in 504 "Gateway Timeout" errors during the rollout:

When we look at failing requests, they look like this:
{
  "http": {
    "method": "list",
    "status_category": "error",
    "status_code": 504,
    "url_details": {
      "path": "/apis/cilium.io/v2/ciliumnodes",
      "queryString": {
        "fieldSelector": "metadata.name%3Dip-xxx-xxx-xxx-xxx.ec2.internal",
        "limit": 500,
        "resourceVersion": 0
      }
    }
  }
}

Based on the logs and these requests, the problem is clearly coming from the ciliumNodeInformer defined here: https://github.com/cilium/cilium/blob/2fdab41a13d2a3f8abbbb4d3b4ba8cc1624c3935/pkg/ipam/crd.go#L108
The 500 limit seems to be coming from the default WatchListPageSize:
https://github.com/kubernetes/client-go/blob/62c5e9e7b4bd09d2b43dcad1464376322398e994/tools/cache/reflector.go#L90-L97
https://github.com/kubernetes/client-go/blob/62c5e9e7b4bd09d2b43dcad1464376322398e994/tools/pager/pager.go#L31
We also performed the same test with Kubernetes 1.31 and the problem was gone: there were no 504s during the rollout and Cilium Agents were no longer crashing. The ConsistentListFromCache feature has been promoted to beta in this Kubernetes version so looks like its behaviour has changed.
We haven't performed the test with 1.28 and the latest Cilium version which has this version of client-go:
https://github.com/cilium/cilium/blob/985d3d9fdf40fbdaa34a674ebac056bcdad2bc34/go.mod#L127
as compared with Cilium 1.15.10:
https://github.com/cilium/cilium/blob/2fdab41a13d2a3f8abbbb4d3b4ba8cc1624c3935/go.mod#L117
It would be interesting to see if all versions of client-go are affected.
To summarize, there seems to be a bad interaction between the ConsistentListFromCache feature pre-1.31 and client-go in Cilium which makes the Agents suddenly crash with exit code 2. I am not exactly sure whether this comes from client-go itself or the way it is used in Cilium.
How can we reproduce the issue?

Enable ConsistentListFromCache on a pre-1.31 Kubernetes cluster
Trigger a rollout of the Cilium Agent DaemonSet

Cilium Version
# cilium version
Client: 1.15.10 7aff1a4d87 2024-07-30T13:05:24+00:00 go version go1.22.8 linux/arm64
Daemon: 1.15.10 7aff1a4d87 2024-07-30T13:05:24+00:00 go version go1.22.8 linux/arm64

Kernel Version
# uname -a
Linux 6.8.0-1017-aws #18~22.04.1-Ubuntu SMP Thu Oct  3 20:15:06 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

Kubernetes Version
$ k version
Client Version: v1.30.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.14-dd.1

Regression
No response
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[x] I agree to follow this project's Code of Conduct

I would assume it's most likely a bug in k8s apiserver pre 1.31.
AFAIR there was no change in client-go in the context of ConsistentListFromCache


spirv-fuzz: Fix OutlineFunction in presence of unreachable blocks

This change prevents TransformationOutlineFunction from outlining a
region of blocks if some block in the region has an unreachable
predecessor. This avoids a bug whereby the region would be outlined,
and the unreachable predecessors would be left behind, referring to
blocks that are no longer in the function.
Fixes #4298.

Thanks for the comment. We don't need to adapt the fuzzer pass, indeed due to using "maybe".


Ion-refresher height stays rememberd when removed with ng-if

hey, i have 2 different div's with lists I show in one view, one div has an ion-refresher and the other div doesn't. when i visit the div which doesn't have the ion-refresher and pull down the list it seems like the space for the refresher remains, but i don't see the icon and it doesn't collapse.
Here you can see that when you visit the second tab you can still pull down as if there was an ion refresher http://codepen.io/sjerd/pen/MYeVZO

What is the current status of this issue? I am also running into this problem...

If you put a simple console.log in the $scope.doRefresh of the above codepen, you'll see that the actual refresher is still in place, as doRefresh is still getting called when ng-if evaluates to false. So it's not only a styling issue. The refresher still seems to be active.

In this case, it would be better to create two scroll view.
http://codepen.io/mhartington/pen/OVoVRW?editors=100

+1. ion-refresher is still active when ng-if is false, even if it's not visible. ng-hide/ng-show isn't workin, too.

@JLNNN @mhartington the same bug

I have a workaround @JLNNN @mhartington :
<ion-refresher
      ..
      ng-if="variable">
    </ion-refresher>

and add this on the function you change the  value:
    var scrollView = $ionicScrollDelegate.getScrollView();
    scrollView.__refreshHeight = null;
    scrollView.__refreshActivate = null;
    scrollView.__refreshDeactivate = null;
    scrollView.__refreshStart = null;
    scrollView.__refreshShow = null;
    scrollView.__refreshHide = null;
    scrollView.__refreshTail = null;
    scrollView.__refreshTailTime = null;
    scrollView.__minSpinTime = null;

but of course it will be better if we could add a method in ionic.view.scroll:
removePullToRefresh: function() {
    var scrollView = $ionicScrollDelegate.getScrollView();
    scrollView.__refreshHeight = null;
    scrollView.__refreshActivate = null;
    scrollView.__refreshDeactivate = null;
    scrollView.__refreshStart = null;
    scrollView.__refreshShow = null;
    scrollView.__refreshHide = null;
    scrollView.__refreshTail = null;
    scrollView.__refreshTailTime = null;
    scrollView.__minSpinTime = null;
}

@danicomas you workaround works just if I want remove the pull to refresh but what about if I just want disable temporary the pull to refresh?


Sonar gosec fix

Description of the change(s):

Fix a GoSec issue

Why do we need this PR:

Sonar A+ rating

Issue reference:

https://sonarcloud.io/project/issues?resolved=false&types=VULNERABILITY&id=open-cluster-management_hypershift-deployment-controller&open=AYCP4QlSr2ckpXrxl6Ux

Test API/Unit - Success
ok      github.com/stolostron/hypershift-deployment-controller/pkg/controllers  7.205s  coverage: 77.0% of statements
ok      github.com/stolostron/hypershift-deployment-controller/pkg/controllers/autoimport       0.047s  coverage: 61.5% of statements

/cc @stolostron/acm-hypershift

/lgtm


DOKS link is broken in podinfo-example/README.md

Should be: https://docs.digitalocean.com/products/kubernetes/getting-started/quickstart/
Currently is:
A [DOKS](https://docs.digitalocean.com/products/kubernetes/quickstart) cluster configured and running.

Noticed this took, in the doks-example, with https://docs.digitalocean.com/products/kubernetes/quickstart/ also 404.


find_pii_and_deidentify example fails

I'm trying to run the PII example here.
# for gpu
python /repos/NeMo-Curator/examples/find_pii_and_deidentify.py --device gpu

# for cpu
python /repos/NeMo-Curator/examples/find_pii_and_deidentify.py

On CPU, I get memory warnings and eventual worker deaths without producing output:
2024-05-28 14:41:18,511 - distributed.nanny - WARNING - Restarting worker                      [180/2695]

2024-05-28 14:41:19 INFO:Loaded recognizer: EmailRecognizer

2024-05-28 14:41:19 INFO:Loaded recognizer: PhoneRecognizer

2024-05-28 14:41:19 INFO:Loaded recognizer: SpacyRecognizer

2024-05-28 14:41:19 INFO:Loaded recognizer: UsSsnRecognizer

2024-05-28 14:41:19 INFO:Loaded recognizer: CreditCardRecognizer

2024-05-28 14:41:19 INFO:Loaded recognizer: IpRecognizer

2024-05-28 14:41:19 WARNING:model_to_presidio_entity_mapping is missing from configuration, using default

2024-05-28 14:41:19 WARNING:low_score_entity_names is missing from configuration, using default

2024-05-28 14:41:22,407 - distributed.worker.memory - WARNING - Unmanaged memory use is high. This may in

dicate a memory leak or the memory may not be released to the OS; see https://distributed.dask.org/en/lat

est/worker-memory.html#memory-not-released-back-to-the-os for more information. -- Unmanaged memory: 3.68

 GiB -- Worker memory limit: 5.25 GiB

2024-05-28 14:41:23,165 - distributed.worker.memory - WARNING - Worker is at 81% memory usage. Pausing wo

rker.  Process memory: 4.27 GiB -- Worker memory limit: 5.25 GiB

2024-05-28 14:41:24,134 - distributed.nanny.memory - WARNING - Worker tcp://<IP_ADDRESS>:33953 (pid=14243) e

xceeded 95% memory budget. Restarting...

2024-05-28 14:41:24,471 - distributed.scheduler - ERROR - Task ('getitem-modify_document-assign-64f0e480e

2b64dd94f34c05c2de0918e', 0) marked as failed because 4 workers died while trying to run it

2024-05-28 14:41:24,472 - distributed.scheduler - WARNING - Removing worker 'tcp://<IP_ADDRESS>:33953' cause

d the cluster to lose already computed task(s), which will be recomputed elsewhere: {('frompandas-f7a5910

31e0ada9d2c8cba1c8468dd66', 0)} (stimulus_id='handle-worker-cleanup-1716907284.4715889')

Traceback (most recent call last):

  File "/repos/NeMo-Curator/examples/find_pii_and_deidentify.py", line 52, in <module>

    console_script()

  File "/repos/NeMo-Curator/examples/find_pii_and_deidentify.py", line 48, in console_script

    modified_dataset.df.to_json("output_files/*.jsonl", lines=True, orient="records")

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/dask_expr/_collection.py", line 2380, in to_j

son

    return to_json(self, filename, *args, **kwargs)

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/dask/dataframe/io/json.py", line 96, in to_js

on

    return list(dask_compute(*parts, **compute_kwargs))

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/dask/base.py", line 661, in compute

    results = schedule(dsk, keys, **kwargs)

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/distributed/client.py", line 2232, in _gather

    raise exception.with_traceback(traceback)

distributed.scheduler.KilledWorker: Attempted to run task ('getitem-modify_document-assign-64f0e480e2b64d

d94f34c05c2de0918e', 0) on 4 different workers, but all those workers died while running it. The last wor

ker that attempt to run the task was tcp://<IP_ADDRESS>:33953. Inspecting worker logs is often a good next s

tep to diagnose what went wrong. For more information see https://distributed.dask.org/en/stable/killed.h

tml.

2024-05-28 14:41:24,778 - distributed.nanny - WARNING - Restarting worker

2024-05-28 14:41:24,959 - distributed.worker - ERROR - Failed to communicate with scheduler during heartb

eat.

There's a longer trace, but it's just more restarting workers before the cluster shuts down.
In GPU mode, it takes some time before failing with a pytorch error:
python examples/find_pii_and_deidentify.py --device gpu

Traceback (most recent call last):

  File "/repos/NeMo-Curator/examples/find_pii_and_deidentify.py", line 52, in <module>

    console_script()

  File "/repos/NeMo-Curator/examples/find_pii_and_deidentify.py", line 30, in console_script

    _ = get_client(**parse_client_args(arguments))

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/nemo_curator/utils/distributed_utils.py", line 150, in get_client

    return start_dask_gpu_local_cluster(

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/nemo_curator/utils/distributed_utils.py", line 75, in start_dask_gpu_local_cluster

    _set_torch_to_use_rmm()

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/nemo_curator/utils/distributed_utils.py", line 175, in _set_torch_to_use_rmm

    torch.cuda.memory.change_current_allocator(rmm_torch_allocator)

  File "/opt/conda/envs/rapids/lib/python3.10/site-packages/torch/cuda/memory.py", line 905, in change_current_allocator

    torch._C._cuda_changeCurrentAllocator(allocator.allocator())

AttributeError: module 'torch._C' has no attribute '_cuda_changeCurrentAllocator'

For the GPU case, the error seems to indicate that torch could not change the cuda allocator.
One of the reasons this can happen when only the CPU flavor of Torch is installed without GPU support.
Is it possible to check if the following command works in the environment:
import torch
torch.cuda.is_available()


Feature/terraform training

Feature/terraform training

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes

Phill Pafford seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.
Have you signed the CLA already but the status is still pending? Recheck it.


Change spilo docker image to demospilo

Image size is slightly more than 24MB, it doesn't contain wal-e and not suitable for production, but it is very good for demo purposes.

👍

:+1:

Coverage remained the same at 7.898% when pulling 7fe3c1ce5dedc620d441901bcd9d22fff7b53689 on feature/demospilo into eba23279c8bfce331c85fd5ca58df204568aceb6 on master.


Can't select the table's other metrics when explore the chart expect the count(*) metric

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.25.5

@GabeLoins

@zhangjian0111 we recently updated how the Metrics Control is used, refer to https://github.com/apache/incubator-superset/pull/4736 and https://github.com/apache/incubator-superset/pull/4663 for examples of how to add metrics.

@GabeLoins Good Idea.if it can suport both fetures is perfect.

@GabeLoins  we can't select the table's other metrics when explore the chart expect the count(*) metric like the picture in this issue. And selecting some metrics show errors about unhashable type: 'dict', such as Word Count with metrics SUM(num) show errors about unhashable type: 'dict'

I'm using superset 0.25.6
In table view, after you set your metric, the number can not be formatted as image. How can I fix this? I tried to change d3 format  on edit table but it doesn't work


Console warning for React.PropTypes no longer being supported

There is a console warning originating from "import Icon from 'react-native-vector-icons/FontAwesome';"
The console error says "Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)"
Some of the traceback is FontAwesome.js:6, create-icon-set.js:11, icon-button.js:8, ImageStylePropTypes.js:15

Make sure you're on the latest version.


Version bump of 3rd party Docker containers for Geneva

🚀 Feature Request
Relevant Package
Mostly a validation-only change.
Description
To limit technical debt and pick up bug fixes and security fixes, we should bump the versions of 3rd party containers in the EdgeX Dockerfile for Genvea release.
The list of affected images is:

consul
kong
portainer
postgres
redis
vault

Additionally, the Dockerfile for security-secretstore-setup hard-codes alpine:3.10 and should be changed to just alpine for consistency with the rest of the containers.

Need more testing to find the root cause/alternative solution.

Since none of the changes actually need to be made within the edgex-go repository, this more properly should be individual issues in each of the affected repositories (such as docker-edgex-mongo, docker-edgex-consul, developer-scripts, etc.).
Closing here and notifying @bnevis-i to create the necessary issues in the appropriate repositories.


Default user admin can't be login

Default user admin cant be login, because FE raise a verify failed error that's not email format when deploy on local.
The solution is to change the default admin user to email format.
mysql -u root -p -d xtreme1

update user set username =<EMAIL_ADDRESS>where username = 'admin';

Then login with email<EMAIL_ADDRESS>and password root@123.

Admin is only used to initialize data, only for internal use, you should register your own account to log in.


Why was css extension kept as URL? What if we wish to load CSS into the styles using loaders?

I am trying to use the config and extend by adding more loaders like this :
const config = require('./node_modules/@irbnb/nimbus/configs/webpack.js');

config.module.rules.push({
  test: /\.md$/i,
  use: 'raw-loader',
});

config.module.rules.push({
  test: /\.css$/i,
  use: ['style-loader', 'css-loader'],
});

module.exports = config;

While the raw loader works, and I don't get any errors for css loader, I always get my css load as an URL like below:
import css from './assets/news.css';

console.log(css) // data:text/css;base64,dmF...

I tried to fork and install that, but that was cumbersome.
I tried to copy paste the whole config to eject completely, but that was difficult to avoid a lot of goodness and additional install.

How do I go about this please?

@vaidsu Use unshift instead of push. Otherwise the CSS is loaded here instead: https://github.com/airbnb/nimbus/blob/master/packages/config-webpack/index.js#L108

Aaah interesting, didn't think of thatt. unshift is a tricky name to say first in list. Thanks @milesj 👍


[BugFix] Fix checkpoint failed bug when writing cluster

Fixes #https://starrocks.atlassian.net/browse/SR-18050
If there is a database named starrocks in the system, then upgrade to version 3.0, the checkpoint will fail with the following log
2023-05-29 15:20:19,471 ERROR (leaderCheckpointer|368) [Checkpoint.replayAndGenerateGlobalStateMgrImage():226] Exception when generate new image file
java.lang.NullPointerException: null
        at com.starrocks.cluster.Cluster.write(Cluster.java:185) ~[starrocks-fe.jar:?]
        at com.starrocks.server.LocalMetastore.saveCluster(LocalMetastore.java:4650) ~[starrocks-fe.jar:?]
        at com.starrocks.server.GlobalStateMgr.saveImage(GlobalStateMgr.java:1702) ~[starrocks-fe.jar:?]
        at com.starrocks.server.GlobalStateMgr.saveImage(GlobalStateMgr.java:1667) ~[starrocks-fe.jar:?]
        at com.starrocks.leader.Checkpoint.replayAndGenerateGlobalStateMgrImage(Checkpoint.java:217) ~[starrocks-fe.jar:?]
        at com.starrocks.leader.Checkpoint.runAfterCatalogReady(Checkpoint.java:106) ~[starrocks-fe.jar:?]
        at com.starrocks.common.util.LeaderDaemon.runOneCycle(LeaderDaemon.java:73) ~[starrocks-fe.jar:?]
        at com.starrocks.common.util.Daemon.run(Daemon.java:115) ~[starrocks-fe.jar:?]

if the dbNames contains starrocks, the dbNameToIDs will not contain the key of starrocks if starrocks is loaded from image, because dbNameToIDs is not persist to image, so we should check the existence of the key in dbNameToIDs before get it.
Since the cluster will be removed from 3.1 and the build-in db starrocks is added in 3.0, we only need to fix it on 3.0.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio backport branch-3.0


ToolbarItemDef tooltip not showing when in a groupItem

Describe the bug
We have a couple of UI providers that create group items with a few ToolbarItemDef inside.
Whenever the ToolbarItem is directly on the horizontal or vertical toolbar, we can mouse over to get the localized tooltip of the tool, but whenever those are under a group item, the tooltip never shows up.
We're using ToolbarItemUtilities.createGroupItem and ToolbarHelper.constructChildToolbarItems.
For what it's worth, manually assigning title="FOO" in any of those child ToolbarItem works just fine.
To Reproduce
Steps to reproduce the behavior:
Write a UI provider that adds a ToolbarItem directly in the horizontal/vertical toolbar, and have it return a group item with the same ToolbarItem as child.
Expected behavior
We should get tooltip whether we're in a group or not.
Desktop (please complete the applicable information):

OS: Windows 11
Browser Chrome
Version 119.0.6045.160 (Official Build) (64-bit) (cohort: Stable)
iTwin.js AppUI Version 4.6.2
iTwin.js Version 4.2.1

Thanks, we'll look into this!


Version parsed from https://.../2.1b.tar.gz should be 2.1b not 2.1

Currently the version parsing results in
https://github.com/biocore/sortmerna/archive/2.1b.tar.gz -> version 2.1
https://github.com/biocore/sortmerna/archive/foo-2.1b.tar.gz -> version 2.1b

Presumably they should both be parsed as 2.1b.

Unfortunately while they both perhaps should our versions code is such that it's pretty hard to make that change while guaranteeing that we're not going to break another version format 😭

This was more of a note to myself to fix this. I'm not expecting you to.

Ok, cool. Either way I'd love to see this stuff be more consistent but we'll probably need some sort of automated "test all of homebrew/core and make sure it stays the same" thing 😭


Enable library evolution

Hi,
This PR enables "Library Evolution" support
See https://swift.org/blog/abi-stability-and-more/
We (ZeroC)  are trying to enable this for zeroc-ice/ice but we are getting errors because PromiseKit doesn't enable it.
error: module 'PromiseKit' was not compiled with library evolution support; using it means binary compatibility for 'Ice' can't be guaranteed
import PromiseKit

It will be nice if this can be merge and get Library Evolution enabled for the next PromiseKit release.
I think this will also solve #1137
Cheers,
José

I don't think this should be enabled for PromiseKit, afaik BUILD_LIBRARY_FOR_DISTRIBUTION is not intended for libraries distributed via e.g. Cocoapods and embeded inside the app.
More about this in conversation from https://github.com/CocoaPods/CocoaPods/issues/9232#issuecomment-566713762
#1137 should be resolved by running carthage bootstrap, similar issue discussed here https://github.com/airbnb/lottie-ios/pull/1173#issuecomment-610511321

Hello @pepone
I think this pull request is a duplicate for #1117.

Hi @RomanPodymov
Thanks I miss that, I closing this


add missing CLI commands docs

@intoeetive not sure I follow what's going on with this PR?  Removing all of the individual pages for the different commands?

@TomJaeger it's moving content of those supertiny pages into bigger pages, grouped by what the command do. Like, we will have now single page for all commands related to add-on generation, single command to commands related to data synchronization etc


git.plugin.zsh interferes with Graphics Magick

One of the aliases in git.plugin.zsh, namely “gm” (git merge), interferes with “gm” (Graphics Magick) program. Perhaps it would be good to change the name of this alias?

This is not the first time it's mentioned. We are working on a safer aliasing system that accounts for such things. For the time being, you can delete the gm alias by appending unalias gm to your zshrc file.
Thank you for your understanding.

Related: #1432

Thank you for taking care of it!


Client Allocation Request for: ABC Inc.

Client Allocation Questions
Core Information

Name: ABC Inc.
Website / Social Media: https://foo.com, (@foo, Twitter)
Region: Oceania
DataCap Requested: 576 GiB
Addresses to be Notarized: f1495978707
Notary Requested: Simon

This user’s identity has been verified through filplus.storage


Fix the condition that use "instanceof"

I fixed bug. "instanceof" with left non-object operand is always false.

@ofk Thanks!


increase resource limits in k8s

Description of the Problem / Feature
have room to increase mem limits for k8s, enable prisma studio remote job
Explanation of the solution
edits to k8s config
Instructions on making this work
kubectl apply -f desci-server/kubernetes/TARGET.yaml

solved by https://github.com/desci-labs/nodes/pull/84 duplicate


debug mode works well, daemon mode gives ssl warning immediately

basic info:
sslsplit -V
SSLsplit 0.5.5 (built 2020-11-17)
Copyright (c) 2009-2019, Daniel Roethlisberger<EMAIL_ADDRESS>https://www.roe.ch/SSLsplit
Build info: V:FILE HDIFF:0 N:83c4edf
Features: -DHAVE_NETFILTER -DWITHOUT_MIRROR
NAT engines: netfilter* tproxy
netfilter: IP_TRANSPARENT IP6T_SO_ORIGINAL_DST
Local process info support: no
compiled against OpenSSL 1.1.1h  22 Sep 2020 (1010108f)
rtlinked against OpenSSL 1.1.1h  22 Sep 2020 (1010108f)
OpenSSL has support for TLS extensions
TLS Server Name Indication (SNI) supported
OpenSSL is thread-safe with THREADID
OpenSSL has engine support
Using SSL_MODE_RELEASE_BUFFERS
SSL/TLS protocol availability: tls10 tls11 tls12
SSL/TLS algorithm availability: !SHA0 RSA DSA ECDSA DH ECDH EC
OpenSSL option availability: SSL_OP_NO_COMPRESSION SSL_OP_NO_TICKET SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS SSL_OP_NO_SESSION_RESUMPTION_ON_RENEGOTIATION SSL_OP_TLS_ROLLBACK_BUG
compiled against libevent 2.1.11-stable
rtlinked against libevent 2.1.11-stable
1 CPU cores detected

uname
 Linux kernel 5.4.75 mips GNU/Linux

openssl version: 1.1.11h

libevent version: 2.1.11

Debug mode works as expected on the router, daemon mode always gave ssl-certificate warnings.

Afaik, there shouldn't be any such difference between debug and daemon modes. Can you enable the DEBUG_PROXY switch in GNUmakefile, recompile, try and see if it provides further info?


Update Set-CaseHoldPolicy.md

Related to PR
https://github.com/MicrosoftDocs/office-docs-powershell/pull/8794

Docs Build status updates of commit 1d047cb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-CaseHoldPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

Docs Build status updates of commit dbce155:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-CaseHoldPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 11f7302:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-CaseHoldPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


fix: e2e failed

Description
when run test:integration:clean, the directory is different from the env.COMPOSER_BOTS_FOLDER.
The new bot may have conflict when the name is the same.
Task Item
refs #1652
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Doc update (document update)

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have functionally tested my change

Screenshots
Please include screenshots or gifs if your PR include UX changes.

move this to #1529


Clean up the running console content

Fixes #972.

Beautiful! This is a huge improvement - merging...

Maybe I merged to fast... I see this on master now (OS X, Chrome)


NCEI Minimum Requirements

I've developed a list of the bare minimum requirements for NCEI to understand and archive a netCDF file. How should we proceed with implementing these requirements in this plugin?
The thought is, the compliance-checker would provide the robust analysis of the file and there would be some additional output that states if the file meets the NCEI bare minimum to archive. Of course, we always would like to have the most robust metadata as possible, so including the complete checker results would be important.
Let me know how we should proceed.

@mbiddle-nodc , we at IOOS have been working on a similar list for mapping ncSOS parameters on the NetCDF attributes. I believe that it actually may have a lot of similarities with your list. Have you published that list yet?


FileNotFound Error when starting an output split

After attempting to start an output split, I get a FileNotFound error, stating that the .jukit file cannot be found. The filepath of my document contains a space in a directory name and I noticed that an extra '\' is inserted in the filepath, so the path looks like /.../directory\\ name/.../.jukit.
This issue seems to be caused by the escape() function on line 259 of vim-jukit/autoload/jukit/splits.vim:
let pyfile_ws_sub = substitute(escape(expand('%:p'), ' \'), ' ', '<JUKIT_WS_PH>', 'g')

Removing the function solves the problem:
let pyfile_ws_sub = substitute(expand('%:p'), ' ', '<JUKIT_WS_PH>', 'g')

but I am not sure this is the right solution.
I am on macOS with nvim 0.8.1.

Thank you for pointing this out! This should now hopefully be fixed, please reinstall the plugin and try again


docs(weave): first draft of router chain implementation with weave

Description

adds router chain cookbook example to cookbooks

includes how to track results of prompt router chain
includes how to evaluate final outputs using weave

What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?
yarn start

thanks for the contribution!
Can you refactor to not subclass weave.Object. It's not something we really suggest users to do because it should just be a function or a weave.Model

This looks great, can you change model_output to be output (a recent API change), other than that, this is good to go

I have read the CLA Document and I hereby sign the CLA

recheck


Addition: R

Preliminary Steps
Please confirm you have...

[x] reviewed How Linguist Works,
[x] reviewed the Troubleshooting docs,
[x] considered implementing an override,
[x] verified an issue has not already been logged for your issue (linguist issues).

Problem Description
My repo denotes no R code though the bulk of the code is R (not RMarkdown or another non-covered language). I've verified that R is indeed supposedly covered by linguist according to the listed languages. If possible I'd love to have R functionality enabled here!
URL of the affected repository:
Last modified on:

Expected language:

Detected language:

Thanks for reporting the issue!
Could you please fill in the last 4 fields of the template?


Add an Image Cropper Extension to the Author Image

Or something else that makes it easier ;)

The models have changed in 4.0.0, for images we return the ImageCropperValue from umbraco which means you can do whatever you want with it.


build failure of tests/subsys/llext with fvp_baser_aemv8r_aarch32_smp

Describe the bug
Building the tests/subsys/llext  for the fvp_baser_aemv8r_aarch32_smp  target
 $ west build -p always -b fvp_baser_aemv8r_aarch32_smp tests/subsys/llext
fails with
$ZEPHYR_BASE/subsys/llext/llext.c: In function 'llext_link':
$ZEPHYR_BASE/subsys/llext/llext.c:784:25: warning: implicit declaration of function 'arch_dcache_flush_range'; did you mean 'arch_icache_flush_range'? [-Wimplicit-function-declaration]
  784 |                         arch_dcache_flush_range(ext->mem[i], ext->mem_size[i]);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~
      |                         arch_icache_flush_range

With that target, the #define CONFIG_CACHE_MANAGEMENT 1
This could be a regression coming from commit<PHONE_NUMBER>98d6b46cf3d510d0bda5c3dd2b51a8  of the PR https://github.com/zephyrproject-rtos/zephyr/pull/66144
Impact
CI failure
Environment (please complete the following information):

OS: (e.g. Linux, MacOS, Windows) ubuntu
Toolchain (e.g Zephyr SDK, ...)  SDK 0.16.3
Commit SHA b6d9ed095d7bc395be602072db2679d201735113

@pillo79 please take a look, might need some ifdefry or an empty default implementation for a weak symbol to deal with this.

Thanks for the heads-up! It was actually the opposite :sweat_smile:: I used an arch-specific function while there was a globally defined equivalent mandated by the Cache API.
The linked PR fixes this and automatically defines CACHE_MANAGEMENT when appropriate.


K8s 1.14 (and k8s 1.15) with calico network mode - Cluster is not able to recover successfully after restoring from backup.

Rancher server version - v2.2.5-14
Steps to reproduce the problem:
Create a K8s 1.15 cluster with Flannel network mode and following configurations:
1 control plane node
3 etcd nodes
3 workers
Wait for the cluster to get to active state.
Executetest_bkp_restore test -https://github.com/rancher/rancher/blob/master/tests/validation/tests/v3_api/test_bkp_restore.py
 1. Create workloads
 2. Perform Backup
 3.Create workload after backup
 4. Perform Restore

All control and etcd nodes gets to Unavailable state after cluster is restored with following error message:
Runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized --
Calico-node is not able to start on etcd and control nodes.

Recreating the calico-node pods should make the nodes go in Ready state. You can delete them manually in the UI or delete them all via the CLI:
kubectl -n kube-system delete pods -l k8s-app=calico-node

Possibly related: https://github.com/projectcalico/calico/issues/2370

Confirmed that following the steps - https://github.com/rancher/rancher/issues/21490#issuecomment-510979333 gets the clusters to good state.

verified with master-head - commit id: 0afa73cbd
Steps:

Create a K8s 1.15 cluster with Flannel network mode and following configurations:
1 control plane node
3 etcd nodes
3 workers
Wait for the cluster to get to active state.
Execute the below steps:

 1. Create workloads
 2. Perform Backup
 3.Create workload after backup
 4. Perform Restore

Cluster is seen in Active state.
All nodes are Active.


Neon Style

Just one bright colour over the dark background, nodes have no body visible.

Wow, there's a #402 with the same name, but a bit different idea


[#4558] Fixes that the Collector is not running

Fixes that the Collector is not running when the cluster setting is disabled.

Codecov Report

Merging #5961 into master will decrease coverage by 0.01%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##           master    #5961      +/-   ##
==========================================
- Coverage      41%   40.98%   -0.02%
==========================================
  Files        3007     3008       +1
  Lines       90531    90540       +9
  Branches    11855    11855
==========================================
- Hits        37120    37109      -11
- Misses      50187    50200      +13
- Partials     3224     3231       +7

Impacted Files
Coverage Δ

...lector/cluster/DisabledProfilerClusterManager.java
0% <0%> (ø)

...eiver/grpc/service/command/GrpcCommandService.java
54.8% <100%> (-0.44%)
:arrow_down:

.../cluster/ClusterPointStateChangedEventHandler.java
72% <100%> (ø)
:arrow_up:

...tor/receiver/thrift/tcp/AgentBaseDataReceiver.java
67.5% <100%> (ø)
:arrow_up:

...tor/cluster/zookeeper/ZookeeperClusterService.java
29.76% <33.33%> (+0.35%)
:arrow_up:

...ter/zookeeper/ZookeeperProfilerClusterManager.java
58.62% <77.77%> (-2.1%)
:arrow_down:

...collector/receiver/grpc/ShutdownEventListener.java
0% <0%> (-25%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ServerClosePacket.java
52% <0%> (-16%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...pc/server/LoggingServerMessageListenerFactory.java
90% <0%> (-10%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0b0a2...2464e7e. Read the comment docs.


UX(?) somehow suggests to users to duplicate nodes in ways

This is the second example I've seen of this, so I thought I'd better mention it.  I've no idea what buttons the mapper pressed to do it, though.
Problem is as described on this changeset: https://www.openstreetmap.org/changeset/52867263 .  It's a very new mapper.
Actual change is just 1 node delete from way http://osm.mapki.com/history/way.php?id=468933242 , but lots of others already there got added again (as per the history link).  I narrowed the problem down by looking at http://overpass-turbo.eu/s/sOJ and changing the time used.
Apologies in advance if I'm pointing the finger in an entirely wrong direction, just wanted to provide a "heads up".
EDIT:  Here's the other example:
http://overpass-turbo.eu/s/sOK
http://osm.mapki.com/history/way.php?id=326651822
http://www.openstreetmap.org/changeset/53274991

Thanks for reporting - we're tracking this on #4433
We think it's created by something the user does when they move the feature.


Wrong picture for explanation

On the  Grant front-end app access to back end title  , part 4
it is saying: In the Request API permissions page for the back-end app, select Delegated permissions and user_impersonation, then select Add permissions.
But the problem is that the UI is changed and now this Delegated permissions we can see on My APIs.
Please update the picture because it is different and it is not clear

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ff46628-b5dc-8b02-02b6-8f510d8059b0
Version Independent ID: 24d09b70-d144-d152-ac5a-c49219a5d8e8
Content: Tutorial: AuthN/AuthO end-to-end - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-auth-aad.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@Boshskoski Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.
@cephalin Can you please review this? CXP does not have the ability to edit screenshots for docs.

@Boshskoski the doc has been updated. Thanks. #please-close


Change minecraft logo to make look more like original

Icons Changed

Minecraft (com.mojang.minecraftpe)

The new design has user experience issues. Its making it hard to recognize as a minecraft icon.


Chem adjustments, pulped banana peels

About the PR
A few adjustments.

Tricord now only heals people with 50 or less damage, with this I'm probably happy with it until medical is way way way further along.
All reagent status effect removals are 3-4x as effective (they were extremely underwhelming before and barely noticeable). Synaptizine and meth seem really good now but they still stun long enough to get cuffed if you are getting baton spammed (mostly a huge asset against ranged stuns).
You can grind banana peels into pulped banana peels, an alternative anti-bleeding medicine. (It'd take like 12 banana peels to get the effects of 1 tranex max dose and clog your medicine metabolism so I'm not worried about it being too good)
Emergency medipens changed from 15 epinephrine to 12 epinephrine and 3u tranexamic acid.
Anti-poison medipens changes from 5 epinephrine, 5 inaprovaline, 5 ultravasculine to 10 ultravasculine, 5 epinephrine.

Screenshots

Banana peel pulping works
Changelog

:cl: Rane

add: A scene in a recent stage play where a clown tragically sacrifices his last banana peel to the grinder to save his mime friend from bleeding out has popularized the concept of using pulped banana peels to treat bleeding.
tweak: Tricordrazine no longer heals people with more than 50 damage.
tweak: All status effect removals from chemicals are 3-4 times as effective as they were before.
tweak: Epinephrine medipens changed from 15 epinephrine to 12 epinephrine and 3u tranexamic acid.
tweak: Anti-poison medipens changes from 5 epinephrine, 5 inaprovaline, 5 ultravasculine to 10 ultravasculine, 5 epinephrine.

if the EpiPen composition is getting changed it should probably be renamed to just "emergency medipen", otherwise I support these changes

Renamed


Minor text edits

Fixed a typo in line 7 - updated colour to color for consistency.

[ x] I have read freeCodeCamp's contribution guidelines.
[ x] My pull request has a descriptive title (not a vague title like Update index.md)
[ x] My pull request targets the master branch of freeCodeCamp.
[ x] None of my changes are plagiarized from another source without proper attribution.
[ x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM

Congrats @ayerest on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


[dotnetframework] fix eol and release dates for 3.5sp1

fix eol and release dates for 3.5sp1
add dotnetframework as alternate url

Source : https://docs.microsoft.com/en-us/lifecycle/products/microsoft-net-framework?branch=live


Drop sources not showing up correctly.

Since a few months sources are not showing up correctly, instead it shows "from something" on multiple occasions but not every time.
Some screenshots as proof:

Fixed


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1100

Questions ?
Please refer to the Backport tool documentation


January

https://www.january.com/

Fixed in https://github.com/jplock/awesome-fintech/commit/8abc238bbf2378cde9a322dc6ad164f0d5cbea70


Fix license in the header

This pull request fixes the license in the header to match the project license.

@cdimascio could you please have a look? Thank you!


pcsx2-bin: simplify updateScript

Description of changes

https://github.com/NixOS/nixpkgs/pull/326590#discussion_r1684708244

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks

Thanks for this 🙏🏻 bit of a busy week and didn't have much time to follow up on this

@pbsds Hi, I think we need to investigate on this change I bit - I noticed that since it was pushed r-ryantm has stopped publishing updates for the package?
https://r.ryantm.com/log/pcsx2-bin/

it could be slow, lets give it some more time to see, if it continues to not work i'm happy to merge a revert

@pbsds it ran in the end, but exits with an error: https://r.ryantm.com/log/pcsx2-bin/2024-08-04.log

that error is due to platforms = [ "x86_64-darwin" ]; while the r-ryantm bot being x86_64-linux. It's simply unable to build src which tries to use darwin bash and tools. The fix is to write a different updateScript much like what i did here: https://github.com/NixOS/nixpkgs/pull/331758/commits/886068298f6a318d8bdcc3707972f5b78c56b589
The trick is that it uses nix-prefetch-url rather than building src

@pbsds Cold you please revert the update script?
The old one should work, as it's inspired from the other one I wrote for miru: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/mi/miru/update.sh
Miru's one seems to work through r-ryantm:
#331935

The miru one looks good, since it uses nix-prefech-url :+1:
This one however did not, and rather used update-source-version to implicitly run nix-build . -A pcsx2-bin.src.
https://github.com/NixOS/nixpkgs/blob/50773c2ed163efdb46ecb7ac75d1c64d30351f5d/pkgs/by-name/pc/pcsx2-bin/update.sh#L8
Reverting this will not work, please submit a new update script


Not working in Firefox 20.0.1 and IE 10

In Firefox 20.0.1 the drawing is placed totally wrong and in IE 10 it is not possible to set document size.

Seems to work now


Question BETA or Stable

What will be the focus of this MOD/Community. Will you goal be to work with the stable or the Beta Branch or do you plan to release the community patch for both branches?

Currently it's working for both branches, and we will continue trying to keep it that way. If we would have to choose though, the stable branch makes the most sense.

I don't know about the other fixes but after they moved 1.1.0 to stable branch my steward fixes have stopped working (man at arms and bannerlord), i think there might be a need to check if this mod works with 1.1.0 stable


Extrinsics not latched

We are using /o3d3xx/camera/extrinsics and /o3d3xx/camera/unit_vectors for ray-tracing.
We noticed that the unit_vectors are published once (i.e. latched) but the extrinsics are published continuously.
We were wondering why this is happening. Is it possible that the extrinsincs change during operation / after camera (factory) calibration?

Additionally: could you please confirm that the rotation part of the extrinsics are already included in the unit_vectors, thereby we (@bibarz) can ignore those when converting depth to point-cloud?

The extrinsics could change, as the camera exposes a user-supplied extrinsic calibration via the XML-RPC interface. Technically the extrinsics could only be sent once, just like the rotated unit vectors, but at the time of implementation considering the extrinsics as an invariant on the schema seemed cheap given that it is only 6 floats. However, the unit vectors were considered expensive for obvious reasons.
Per your second comment, yes, the unit vectors are already rotated. You can see this validated via the unit test code for libo3d3xx (the underlying driver to this ros interface). This and this would probably be a helpful reference/validation.

I should note that there is a ROS/Python version for doing what you want to do implemented in the o3d3xx-ros unit test. That test code is here

Finally, I see no issue with latching the extrinsics. Even though we are streaming it continuously from the camera, there is no need to have continuous callbacks running in your ROS node -- you make a good point. If you want to submit a PR for that (against the HEAD) that would be appreciated. If not, we can leave this issue open and I'll get to doing that when I have the time.

OK, one last point we should consider here.... I now remember why we chose to stream the extrinsics constantly from the camera and also publish them continuously in ROS.
Basically, the libo3d3xx driver, at the time of image acquisition, transforms the delivered point cloud from the camera into a standard ROS coord frame (+x forward, +y left, +z up). If you make the assumption there is no user-supplied extrinsic calibration applied to the camera (i.e., the XML-RPC/JSON dump reports 0,0,0,0,0,0), you can get the first value of the extrinsics and use this as a reference (it will not be all zeros because this contains the transform from the imager chip to the camera glass). Then you can check each subsequent extrinsics message to make sure that it has not changed from the reference values (i.e., in a different thread, command-line tool, etc.). If they have changed, you really cannot trust any of the Cartesian data as (0,0,0,0,0,0) assumption made by the driver is violated and all bets are off.

According to this, the unit_vectors should be changed when/if the extrinsics change. ?

Thanks for resolving/answering our questions so quickly.
(The issue can be closed)

According to this, the unit_vectors should be changed when/if the extrinsics change. ?

Yes. But really, if the extrinsics change, it should be considered an error unless you really know what you are doing (it sounds like you do).

Thanks for resolving/answering our questions so quickly.
(The issue can be closed)

No problem. Good luck and have a nice weekend.


request: add trailing commas

Only thing in my pre-commit toolchain that Ruff hasn't replaced yet. Would love to see it, and thanks for all your work!
https://github.com/asottile/add-trailing-comma

There's also flake8-commas. It has these rules:

Code
message

C812
missing trailing comma

C813
missing trailing comma in Python 3

C814
missing trailing comma in Python 2

C815
missing trailing comma in Python 3.5+

C816
missing trailing comma in Python 3.6+

C818
trailing comma on bare tuple prohibited

C819
trailing comma prohibited

add-trailing-commas also has unhug-trailing-paren, unhug-leading-paren and avoids arbitrary indentation.
Which is not enforced by Ruff or Autopep8. Even Black only enforces it when magic commas are used:
# This is found acceptable by Ruff, Autopep8 and Black
print(1,
      2,
      3,
      4,
      5)

# This is what add-trailing-commas changes is to
print(
    1,
    2,
    3,
    4,
    5,
)

So Ruff hasn't yet completely replaced it for me, though I'd love to see it get there. Is this the right place or should I open a new issue?

@Avasam
https://github.com/asottile/add-trailing-comma, not \
https://github.com/asottile/add-trailing-commas


There's a description of the issue on stack overflow and a JSFiddle for the fix: https://stackoverflow.com/questions/57516373/image-stretching-in-flexbox-in-safari
I had a look at it, and I managed to fix it simply by adding align-items: flex-start; in _gallery.scss:
.gallery {

    .grid-item {

        align-items: flex-start;

    }

}

It doesn't seem to be any issue on the other browsers I tried.
I can send a pull-request if you prefer so
Thanks for your hard work 👍🏻

Thanks! It works


Can't install 'chwoerz.ts-worksheet' extension because it is not compatible with the current version of Visual Studio Code (version 1.84.2).

It's a message from vscode IDE. Is that any compatiable version of vs code can be used?

Hey, I will check if I can make the requirement lower 👍. Will message you as soon as it's done. :)

Version 0.8.8 is released and now supports 1.83  👍


fixed the time attack bug

Fixed the time attack bug in issue #405

Needs to be tested by someone else aswell.

Aside from the code formatting, LGTM 👍

Thanks for the PR, glad you found the formatting there haha. :)


Bring default Transformers back to the community version

After commit https://github.com/skidfuscatordev/skidfuscator-java-obfuscator/commit/4bb9d944c4b129f55f7f7f5e8d47425426c3f083, Skidfuscator couldn't intialize any transformers for community version. This PR brings them back.

/ping @terminalsin

Already fixed in 2.0.9


[epoxy] Add basic IDN support to conn. strings

Use Uri.DnsSafeHost, which can be configured at an application level
to return Punycode-encoded ACEs.
.NET 4.6 includes Uri.IdnHost, which is always Punycode-encoded if
needed, but Mono doesn't yet support that, so we can't use it.

Can you add a test? It'd help even if only to show what difference this makes.

Unfortunately, no, I haven't been able to figure out a way to add a test. Whether or not DnsSafeHost does Punycode encoding is an application-wide configuration setting, and we don't control the settings that our test runners use. Uri.IdnHost solves that, but Mono doesn't have Uri.IdnHost.
I've been able to test this manually by making the configuration changes, though.
This seems too small for an entire example.

Closing and re-opening to re-run CI.

Re-run CI.


refactor: rename react imports

#355  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite


Fix typos

Fix some of the "a ec key" occurrences. There are more places where "a EC*" is used. Shall those also be changed, or is there a rule where "a EC*" is correct?
Checklist

[ ] documentation is added or updated

Shall those also be changed, or is there a rule where "a EC*" is correct?

IMO these occurrences are also incorrect and should be fixed.

@mattcaswell Do you agree with CLA: trivial?

This pull request is ready to merge

Merged to master, thanks for the typo fixes.


qt5.mkDerivation: allow disabling hook insertion

Since we added wrapQTAppHooks to qt5.mkDerivation, it pollutes the closure of everything it touches even when package is not building with QT support.

Maybe instead of includeWrapQtAppsHook we could add an attribute that would disable Qt’s mkDerivation completely, turning it into stdenv.mkDerivation

Hmm, this is an interesting topic. When there's optional qt features I'd expect people to add wrapQtAppsHook manually and to not use qt5.mkDerivation.

Huh, this is only 100-500 rebuilds according to ofborg. Should we go to master?

There would be a merge conflict.

Ah, merging then.


Add mode to handle tar files as webdataset

Tell us more about this new feature.
Hey there,
I was studying Web Dataset internals and it stream tar sub files to the use code.
I was thinking it could be possible to have a mode where MountPoint S3 could list tar files on s3 and exposes them as un-tarred to the file system through the mount.
When reading a given file, it would read the entire tar locally. Obviously, the user would need to read files in the order of the tar files to gain maximum speed from this mode.
But this would provide a simple and very efficient way to stream data to the machine.
Best,
T.C

Hey, thanks for opening this feature request. It is really an interesting use case and we will be looking into it.
By the way, I think if your use cases are read-only. It might be worth trying S3 Object Lambda. With S3 Object Lambda you can replace LIST, GET, and HEAD requests of tar files with untarred contents. Then you can use the Object Lambda access point on mounting and it should work without having to make any changes in Mountpoint.

Hey @monthonk Do you have an example on how to do that ?

Sorry, I don't have any example in my hands. The S3 Object Lambda documentation might have some examples for you.
I don't know much about Web Dataset, but want to clarify something. Does it currently work with tar files in Mountpoint? I'm assuming that it works, but Web Dataset would sequentially read the entire tar file. What you want here is an optimization which let you know what to look at in the tar file and only download the part you want from the object. Is that correct?

Hey @monthonk. After checking AWS Lambda, this doesn't seem like a good option. I assume this would make it too slow to be usable.
I meant to have something built directly within the fuse mount.

We've looked into this a little, and while I think it would be pretty cool, it's not something we're currently planning on implementing for Mountpoint. It's worth noting that applications loading WebDataset-format objects (tar files) from a Mountpoint instance works today, including being able to seek through the tar file when needed to skip over files. What doesn't exist is the ability for Mountpoint to "mount" a tar file and present its contents as individual files.
Thanks for the feedback!


How do I use on-change?

My cropped photo works and is written to $scope.croppedPhoto.
I can do:
<img data-ng-src="{{ croppedPhoto }}"/>

Which works fine. But I need the final photo to sit in: $scope.newCard.photo
How can I update $scope.newCard.photo with $scope.croppedPhoto every time the cropped image changes?
I've tried: on-change="(dataURI)" and then added this function. But all I get in the console is undefined :
	$scope.changedCrop = function(data) {
		console.log(data);
	}

So I had to go with $dataURI and not dataURI :-)


Update codebase

Am I right in assuming this project does not support updating project files which would be a common reason to update the app?

Can you explain more please?

Do you want your clients to be able to install a Laravel project just like they do with WordPress or any other CMS?

When Wordpress updates it also updates it's codebase by downloading and extracting the new files from a .zip, and running database migrations.

Do you think this is possible with the laravel framework?

Anything is possible. You can simply run git pull and have it in sync with your repo.

The issue being the users who setup my codebase may not have ssh access to be able to run their own commands, which is why I'd use a library like this to begin with

You do not need ssh access. Many packages are out there for that use: https://github.com/codedge/laravel-selfupdater


Invalid Volume Specification Using Docker-Compose

As of version 0.3.4, docker-compose mounting fails when the container has a directory mount.

This is from Windows to Linux docker context.

Fixed in just-released stevedore-0.4.0. Note that it takes some time before release becomes available via Chocolatey/WinGet.

Problem still occurs if it is a file mount.

Hmm...

For me it is still invalid volume specification but maybe the directory being created is related so maybe solving that will also solve this.

Here is the compose entry for the container if it helps.

The volumes should be these. I forgot that I already edited it to figure out what was not working.

Right. Problematic syntax is ./<file>:/<file>.

I believe that single-file bind-mounts are fixed in Stevedore 0.4.1 (is being published currently).

I can confirm it works now with no modifications to our compose. 😊


IPv6 metallb config

Configure metallb for IPv6 - enable by setting NETWORK_ISOLATION_IPV6 to true.

recheck
Compute kernel panic:
[  578.548394] ---[ end Kernel panic - not syncing: Jitter RNG permanent health test failure ]---

recheck
[  521.064140] ---[ end Kernel panic - not syncing: Jitter RNG permanent health test failure ]---


(Closes #432) add RTD yaml file.

Fixes issues with RTD build of docs by adding a yaml config. file.

Wrong upstream!


Add locale field to JTCalendarAppearance

Hello,
Thanks for your great component, it's really handy! I use it in the project I'm currently working on and I've had a need to set up calendar locale in run-time manually with MCLocalization. For this, I have forked your repo and added a NSLocale *locale field to JTCalendarAppearance class. You might want to review changes and merge it if you think it could be of any use.

I just release a new version.
Check the example projet.
It's settings.calendar.locale.


Sync was turned off from another device prompt (when it wasn't)

testing https://github.com/microsoft/vscode/issues/93811
When signing out of an account that is currently being used to sync settings, I get this dialog:

If I let this dialog sit open for a minute or two without clicking on either button, I get this notification:

I didn't turn off sync from another device, and if I did wouldn't that mean I chose the "Turn off sync on all devices and clear the data from the cloud" option?  Or, is there some way for me to turn off syncing on another device?

Or, is there some way for me to turn off syncing on another device?

There is not. Will investigate what's happening here.

Trying on latest insiders I see same dialog on both instances

@RMacfarlane This dialog should not appear if user does not sign out manually.

There's another issue tracking the "turn off sync" dialog being shown here: https://github.com/microsoft/vscode/issues/94174
For the "Sync was turned off from another device" message, it looks like auto sync is stopped because there is no longer an auth token. @sandy081 should we distinguish this case and show a different notification?

Now, when you sign out of the account used for settings sync, a notification should be shown that settings sync has stopped.


ACTION_ROOT handling for HLS

This is meant as fix for #317

The ACTION_ROOT checks added to hardware/Makefile were omitted from the merge. Was this intentional?

Hi @kenhill,
yes, this was done intentionally. The check was a circumvention. Now it is possible to work with both versions for HLS actions. ACTION_ROOT may point to the vhdl link which is pointing to the directory containing only the generated vhdl sources, or ACTION_ROOT may point to the directory containing the HLS .cpp sources and the corresponding Makefile. This is possible since I added the deletion of the directories containing the additionally generated verilog and systemc files.
Pointing to the existing directory containing the .cpp sources and the Makefile is the way I'd like to go. Supporting the vhdl version is just for those who are used to that from the past. I'd like to remove that support at some point in time.


Implement the change residue index operation

Implement the chain residue index operation, including UI and undo/redo.

Initial implementation was completed, including simple "shift-residue index" dialog. Change residue index dialog would be required.

Initial implementation was completed, including simple "shift-residue index" dialog. Change residue index dialog would be required.

Change residue index/Renumber operations are implemented.


[Rector] Apply PHPUnitSetList::REMOVE_MOCKS

Apply PHPUnitSetList::REMOVE_MOCKS to remove unnecessary mock calls.
Checklist:

[x] Securely signed commits

All green 🎉

Is there documentation for the rule?

current documentation is list of rules, not by set yet https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md
The list of remove mock rules can be checked at https://github.com/rectorphp/rector-phpunit/blob/main/config/sets/remove-mocks.php

Thanks! I got the document structure.


Dracula theme with brown background

My system:

vim-bootstrap 2022-08-04 13:02:53
Operating system: Debian 11
Vim/Nvim version: VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Oct 01 2021 01:51:08)
Languages: Python, HTML

Description
Hi,
I downloaded my .vimrc on vim-bootstrap website with Dracula theme, for my surprise the background was brown after install the theme.

Search on internet I found way to correct this "problem".

Can you add this line of code on  new branch of vim-bootstrap.
let g:dracula_colorterm = 0
colorscheme dracula
Thanks

Can you send the patch?


Ignore changesets with no affected nodes within bbox

I'm submitting a feature request
Brief Description
When monitoring changes in a restricted area (i.e., one county), there comes up a lot of changesets with extremely large affected areas, where closest altered object can be hundreds of kilometer away from monitored area. This becomes SPAM that often leads to flagging good/bad without having knowledge about the areas actually affected.
What is the motivation / use case for this feature?
Less noise in my filters, less false possitives/negatives.

Hi @Skippern !
Thanks for your suggestion and thank you very much for being one of the most active OSMCha users!!!
Take a look on the BBox size bound field on the filters page. It allows you to filter changesets that have a bbox area lower than X times the area of your BBox or geometry filter. For example, if the geometry you defined in your filter has an area of 1 degree and you set the BBox size bound to 2, it will filter the changesets whose bbox area is lower than 2 degrees.
That is the solution we found to that problem, because we don't register all features geometries in our database.

The problem isn't the size of the BBOX, but rather that when selecting a BBOX for i.e. the state of Espírito Santo, I get filtered hits with no changed objects within the state of ES, or even none in Brazil, but stretching from Chile to Vietnam. I would like to ignore those changesets that have no edited objects  within ES even when their BBOX stretches multiple continents.

Yes, I know it. We can't do it because we don't store all features in our database (it would be much more complex and expensive to query changesets considering all its features). But if you set a BBOX size bound to a 3, for example, it will exclude those types of changesets from your filter. The bbox size bound is relative to the size of your geometry/bbox, so if you defined the geometry of ES in the filter, it will get only the changesets whose bbox is not bigger than 3x the area of ES.
Make some tests and you'll confirm that it helps a lot. :smiley:

Trying it out 👍

Nice, I was looking for a way to filter large area changesets too.

It might be unclear but AFAIK the BBox size bound filter is a customizable "huge bbox" flag. "Filter changesets smaller than X times your bbox" is a less clear way of saying "only show changesets X times bigger than your filter's bounding box" aka you choose whether you want to exclude city, state, country, or world-spanning changesets from your filter.
@willemarcel adjusting the wording of the GUI label might help here. I came searching around github for this feature because I didn't understand the "Filter changesets that have a bbox area lower than X times the area of your BBox" language. Osmcha seems to say "filter" as in "only include in results" but filter can also more commonly mean "exclude from results" as in "spam filter" or "filter out impurities." Maybe globally replacing the verb filter with "include/exclude" as appropriate will be more clear, and the noun filter (https://osmcha.org/filters*) can remain for the search functionality itself.

I came searching around github for this feature because I didn't understand the "Filter changesets that have a bbox area lower than X times the area of your BBox" language. [...] replacing the verb filter with "include/exclude" as appropriate will be more clear, and the noun filter (https://osmcha.org/filters*) can remain for the search functionality itself.

+1
The change https://github.com/mapbox/osmcha-frontend/issues/657 is probably visible as of today. Still, I did not understand from the GUI (label and pop up help text) and from documentation. I had to read several issues here to understand. For me, "filter" does not tell whether the desired stuff is what passes (think coffee filter) or what remains (think mature fish are catched in a net while baby fish pass). Both "exclude/include" as suggested above or "ignore changesets whose..." of https://github.com/mapbox/osmcha-frontend/issues/173#issuecomment-320647106 would be 100% clear to me. Text idea:

Exclude changesets whose area is lower than X times the area of your BBox or geometry filter. For example, if the geometry you defined in your filter has an area of 1 degree and you set the 'Changeset size bound' to 2, the changesets whose area is lower than 2 degrees will be ignored.

"Ignore changesets whose... "  text mentioned in https://github.com/osmus/osmcha-frontend/issues/173#issuecomment-320647106  is better.


Embedded web chat control using token failing

When using the embedded web chat control, using the token process (swapping the secret for a token), the web chat control is failing at various stages. The web chat control is instantiated as expected -- in that, if the token is missing, or not the correct token from the API call, the chat window does not display.
However, the control throws various errors, If I do not debug, or step through quickly, the initial error is a 500, message: "The requested resource does not support http method 'GET'."
https://webchat.botframework.com/api/conversations
If I debug and step through slowly, the first error is a 403, missing token or secret.
https://webchat.botframework.com/api/conversations/null/messages
In the debugger I can step through and see the conversastionId getting set, but it is missing in the call above.
After that, it continues to poll the url, this time with a conversationId, but still returns a 403, missing token or secret.
https://webchat.botframework.com/api/conversations/JLwZUHmHHEy/messages
The embedded web chat using the secret works as expected.

Missed the documentation update --changing to GET api/tokens. Working now.

I am having the same problem, if you could explain your solution or point me to the right section of the docs it would be really helpful.

Are you using your WebChat secret directly in the URL or are you exchanging the secret for a token?

I am using the secret directly

Two things to check.

Make sure the URL in your iframe is "...s=" instead of "...t="
Deauthorize and then generate a new secret for the web chat control for your bot. It's possible something has gone wrong with the secret.

Just did both of those. I'm getting this:
jquery.min.js:11 POST https://webchat.botframework.com/api/conversations/null/messages 403 (Forbidden)
The bot doesn't respond and a few minutes later it shows this:
jquery.min.js:11 GET https://webchat.botframework.com/api/conversations/Bv3bkhOgxas/messages?watermark=131101401454109138 403 (Forbidden)
sometimes accompanied by this:
jquery.min.js:11 POST https://webchat.botframework.com/api/conversations/Bv3bkhOgxas/messages 500 (Internal Server Error)
I assume the null in the first message is a clue. Any thoughts on what is going on?

I continued to have issues with the embedded webclient, so I switched to a server-side solution using the DirectLine package and I associated my bot with the DirectLine channel on the botframework page.
Here is a simplified version of the code I'm using:
[BotCodeDirectLine] is my Direcl Line channel secret.
[botText] is the text posted from a page
var creds = new DirectLineClientCredentials(BotCodeDirectLine);

var uri = new Uri("https://directline.botframework.com");
var directLineClient = new DirectLineClient(uri, creds);

var convs = new Conversations(directLineClient);

var conversation = await convs.NewConversationAsync();

var message = new Microsoft.Bot.Connector.DirectLine.Models.Message(conversationId: conversation.ConversationId, text: botText);

await convs.PostMessageAsync(conversation.ConversationId, message);

///This gets the response text
var messages = await convs.GetMessagesAsync(conversation.ConversationId);

var lastMessage = messages.Messages.Last();
var responseText = lastMessage.Text;

Thanks for the responses. Looks like I had multiple problems. I switched to Azure as there was an AWS issue. Now it works, unless I send it a message within the first 2 seconds of the iframe loading (which causes the same 403). I'll put a loading bar on the client to prevent that, not ideal but it'll do for now.

I'm getting this error jquery.min.js:11 POST https://webchat.botframework.com/api/conversations/2y7GauMpqTbAkgQ9nNaD29/messages 500 (Internal Server Error)

i am getting 200 response but still no message getting rendered on the chat console.
https://webchat.botframework.com/v3/conversations/7VYA39JMmRxAr2d8RUAZlT/activities


Named some item flags

See also: #25
Tested my changes before rebasing onto current trunk, because sometime after my last PR someone broke the entire items view feature..

That would be me!

Please fix.


React Native - auth and guest stacks

so on most of my react-native projects i use react-navigation and there is a need for 2 stacks that conditionally render based on the user being authenticated or not. the way i currently achieved this by doing:
const app = useSelector(() => ({
  initialized: store.app.initialized.get(),
  isInternetReachable: store.app.isInternetReachable.get(),
  isAuthenticated: store.isAuthenticated.get(),
}));

<NavigationContainer>
  <Stack.Navigator>
    {!app.initialized ? (
      <Stack.Screen
        name="Initial"
        component={InitialScreen}
      />
    ) : !app.isAuthenticated ? (
      <Stack.Screen
        name="SignIn"
        component={SignInScreen}
      />
    ) : (
      <>
        <Stack.Screen
          name="Home"
          component={HomeScreen}
        />
      </>
    )}
   </Stack.Navigator>
</NavigationContainer>

is there a better / recommended way of doing this?

Maybe you can utilize Show Component

Unfortunately React-Navigation throws errors if children of Stack.Navigator are not Stack.Screen, so we can't use any other components there. So you could do it this way or make the whole component an observer, and then you wouldn't need the useSelector.


Issue218 plasma2d extraction iter

Main changes:

Warnings when loading data from MultiIDSLoader fails for some data (in particular when using method to_Plasma2D()) is now just as informative but more concise and easier to read.
method MultiIDSLoader.to_Plasma2D() now more robust versus one-time-step-only data
Introduced the basics for handling of rectangular meshes (R, Z) for interpolation via Plasma2D (nearest interpolation only)
User has to define R and Z grid as '2dmeshR' and '2dmeshZ'

Issues:
Fixes, in devel, issue #218

Hello @Didou09! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tofu/data/_comp.py:

Line 454:31: E231 missing whitespace after ','

In the file tofu/data/_core.py:

Line 2374:28: E231 missing whitespace after ','
Line 2374:36: E231 missing whitespace after ','
Line 2374:44: E231 missing whitespace after ','
Line 2480:80: E501 line too long (81 > 79 characters)
Line 2506:80: E501 line too long (82 > 79 characters)
Line 2507:80: E501 line too long (86 > 79 characters)
Line 2508:80: E501 line too long (84 > 79 characters)
Line 2518:61: E228 missing whitespace around modulo operator
Line 2518:65: E231 missing whitespace after ','
Line 2520:65: E228 missing whitespace around modulo operator
Line 2520:80: E501 line too long (94 > 79 characters)
Line 2521:65: E228 missing whitespace around modulo operator
Line 2521:80: E501 line too long (95 > 79 characters)
Line 2522:72: E228 missing whitespace around modulo operator
Line 2522:80: E501 line too long (89 > 79 characters)
Line 2524:65: E228 missing whitespace around modulo operator
Line 2524:80: E501 line too long (94 > 79 characters)
Line 2525:65: E228 missing whitespace around modulo operator
Line 2525:80: E501 line too long (95 > 79 characters)
Line 2526:70: E228 missing whitespace around modulo operator
Line 2526:80: E501 line too long (87 > 79 characters)
Line 2531:43: E225 missing whitespace around operator
Line 2533:59: E231 missing whitespace after ','
Line 2535:74: E228 missing whitespace around modulo operator
Line 2535:78: E231 missing whitespace after ','
Line 2535:80: E501 line too long (81 > 79 characters)
Line 2536:68: E228 missing whitespace around modulo operator
Line 2540:25: E303 too many blank lines (2)
Line 2543:74: E231 missing whitespace after ','
Line 2549:78: E231 missing whitespace after ','
Line 2549:80: E501 line too long (80 > 79 characters)
Line 2551:80: E501 line too long (87 > 79 characters)
Line 2551:84: E231 missing whitespace after ','
Line 2552:80: E501 line too long (87 > 79 characters)
Line 2552:84: E231 missing whitespace after ','
Line 2553:80: E501 line too long (82 > 79 characters)
Line 2555:61: E231 missing whitespace after ','
Line 2560:80: E501 line too long (83 > 79 characters)
Line 3707:14: E111 indentation is not a multiple of four
Line 3707:14: E117 over-indented
Line 3725:17: E129 visually indented line with same indent as next logical line

In the file tofu/imas2tofu/_core.py:

Line 1915:65: E228 missing whitespace around modulo operator
Line 1915:70: E231 missing whitespace after ','
Line 2299:5: E301 expected 1 blank line, found 0
Line 2322:5: E303 too many blank lines (2)
Line 2589:80: E501 line too long (84 > 79 characters)
Line 2601:80: E501 line too long (80 > 79 characters)
Line 2663:80: E501 line too long (80 > 79 characters)
Line 2671:33: E228 missing whitespace around modulo operator
Line 2728:45: E231 missing whitespace after ':'
Line 2728:59: E231 missing whitespace after ':'
Line 2745:33: E231 missing whitespace after ','
Line 2745:42: E231 missing whitespace after ','
Line 2750:76: E228 missing whitespace around modulo operator
Line 2750:80: E501 line too long (85 > 79 characters)
Line 2751:67: E228 missing whitespace around modulo operator
Line 2752:65: E228 missing whitespace around modulo operator
Line 2752:80: E501 line too long (86 > 79 characters)
Line 2757:63: E231 missing whitespace after ','
Line 2757:75: E231 missing whitespace after ','
Line 2757:80: E501 line too long (88 > 79 characters)
Line 2758:45: E231 missing whitespace after ':'
Line 2758:61: E231 missing whitespace after ':'
Line 2758:77: E231 missing whitespace after ':'
Line 2758:80: E501 line too long (84 > 79 characters)
Line 2759:48: E231 missing whitespace after ':'
Line 2759:62: E231 missing whitespace after ':'
Line 2759:78: E231 missing whitespace after ':'
Line 2759:80: E501 line too long (87 > 79 characters)
Line 2760:47: E231 missing whitespace after ':'
Line 2760:62: E231 missing whitespace after ':'
Line 2761:46: E231 missing whitespace after ':'
Line 2761:63: E231 missing whitespace after ':'
Line 2761:77: E231 missing whitespace after ':'
Line 2761:80: E501 line too long (83 > 79 characters)
Line 2762:48: E231 missing whitespace after ':'
Line 2762:53: E231 missing whitespace after ','
Line 2762:62: E231 missing whitespace after ':'
Line 2762:79: E231 missing whitespace after ':'
Line 2762:80: E501 line too long (86 > 79 characters)
Line 3131:9: E303 too many blank lines (2)
Line 3207:74: E225 missing whitespace around operator

Ready for merging when reviewed @lasofivec :-)

Codecov Report

Merging #280 into devel will decrease coverage by 0.3%.
The diff coverage is 0.35%.

@@            Coverage Diff             @@
##            devel     #280      +/-   ##
==========================================
- Coverage   41.46%   41.16%   -0.31%
==========================================
  Files          79       79
  Lines       23228    23399     +171
==========================================
  Hits         9632     9632
- Misses      13596    13767     +171

Impacted Files
Coverage Δ

tofu/imas2tofu/_core.py
0.71% <0%> (-0.03%)
:arrow_down:

tofu/data/_comp.py
20.39% <0%> (ø)
:arrow_up:

tofu/data/_core.py
39.66% <0%> (-1.44%)
:arrow_down:

tofu/version.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a3af1...67489ea. Read the comment docs.


Spi Slave bad performances at 40Mhz (IDFGH-6899)

Environment

Development Kit:      [ESP32-S3-WROOM-1]

IDF version (run git describe --tags to find it):
// v3.2-dev-1148-g96cd3b75c

Build System:         [idf.py]

Compiler version : xtensa-esp32-elf-gcc (crosstool-NG esp-2021r2) 8.4.0

Operating System:     [Linux]

Using an IDE?: [No]

Power Supply:         [USB]

Problem Description
ESP32S3 Slave Spi performances issue
The SPI Slave is documented as capable to operate at 60Mhz
The CPU freq is set to 240 Mhz
I use it at 40Mhz, signals shown below (there are 24 squares, incoming data is 3 bytes long):

The issue is that I do not get as many packets as expected; using a counter and checking with
the time, my estimate is a rate of 47,9 kHz, less than a tenth of what is expected.
Is there a way to increase the slave Spi performances ?
Expected Behavior
The data should come at 500 kHz
Actual Behavior
Data comes at 47.9kHz

Hi @tbultel ,
Is the second row the CLK or data? Please provide all 4 wires so that we can see what's the response of ESP32-S3 SPI Slave.
And another question, what's the sample rate of your logic analyzer when capturing this?
Michael

Hi, The first line is CS, the second is CLK. Both are generated by the RMT.
The analyser is a Saleae Logic 9, I assume that the malformed square wave is due to its sampling limitations,
so just a display effect.
But since the Slave SPI interrupt is only triggered by CS change, a malformed CLK signal does not have
an impact on performances.
After longer analysis I conclude that the SPI Slave it missing polling routines that could let the user application
to get rid of internal message queues and huge interrupt latency.

Till now, Espressif's SPI Slave full duplex mode requires a out-of-band synchronization - only when the slave is ready to receive data, the master can start a transmission. You can see this in the example:
https://github.com/espressif/esp-idf/blob/master/examples%2Fperipherals%2Fspi_slave%2Fsender%2Fmain%2Fapp_main.c#L179
https://github.com/espressif/esp-idf/blob/master/examples%2Fperipherals%2Fspi_slave%2Freceiver%2Fmain%2Fapp_main.c#L72
The interval is determined by the SW - how long the driver requires to handle the previous data. The typical value is about 20~30us, but there's no guarantee for the time - this is why a reliable synchronization method is still needed.
For the half duplex mode, the non-DMA part can respond to master's requests quickly, but for the data transfer, SW response is still required. The main difference is that the synchronization can be done via SPI.

And btw, the 60MHz in the spec is not a clue for the interval of CS.

I was finally able to reach the performances I wanted, by locking interrupts and polling on the interrupt bit
in my RT task. Maybe such a mode should be available as a standard ?
The message queues overhead is far to big to fit the rate I wanted, because as the datagram shows it, I only
have 2 microseconds to get the data.


New Test cases Class for PasswordTextBox Component.

This PR adds new Test cases Class for PasswordTextBox Component.
ant tests Result for PasswordTextBoxTest.java

Thanks & Regards
Preet Vadaliya

@AppInventorWorkerBee ok to test


dev: investigate optimisations in if-else statements

We need to investigate what's the best pattern to use:
if x {}
if y {}

or
if x{}
else if y {}

you can post findings here @danilowhk

Closing as completed


[Bug][Spark-Translation] Fix a bug of Spark Translation when has a timestamp/date type filed in source

Purpose of this pull request

Check list

[x] Code changed are covered with tests, or it does not need tests for reason:
[x] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[x] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Hi, can you add e2e to test this case? Thanks.

Or modify e2e already existed.

Hi, can you add e2e to test this case? Thanks.

Hi, can you add e2e to test this case? Thanks.

This case I had help him to test in local env. The main problem is that when we invoke createDataFrame method manully spark will convert data timestamp to java.sql.Date java.sql.Timestamp. If user use transfrom-v2 in spark engine it will have some problems.

Or modify e2e already existed.

Hi, can you add e2e to test this case? Thanks.

ok


Decide which front-end framework to choose

For the front-end framework, we've decided to go with Nuxt.JS, as it build with Vue.js and it also uses a structure-based approach to routing instead of a separate file, like Angular. Me, @BenJStoffels and @JoshuaMoelans were in favor of this.
While Angular was a potential option and @Scryper has experience with it, we think that the large amount of file and structure might hinder the development experience, as we need to get familiar with it. While it's a good choice for a much larger project, for this POC, Nuxt.JS seems more suitable.
From this, @BenJStoffels will experiment with Nuxt.JS 3, which has a release candidate and is the next iteration of Nuxt.JS with TypeScript support out of the box. Hopefully, this hackathon gives us insight in if it's suitable to continue with. If not, we'll switch to the current 2.0 version and maybe add TypeScript support if it doesn't cause too many issues.


Fix miscellaneous typos

Apologies for the unsolicited PR. I mostly just wanted to see why tests were failing in the last commit, but the logs were expired.

Hi, no worries, Any help is welcome!

It looks like the linter-check job runs black, but style issues flagged by that step don't affect the job's status? I.e., it's passing now, but if I navigate to the Black Check step in the CI log there are a bunch of things black would change.

@tsalo: aren't you afraid that adding the word typo in the title of the PR may summon the codespell demon? (AKA @yarikoptic) 😜

oohhh good point! 😄 Plus this is mostly about getting the linter and tests passing at this point anyway

yay: all green !

Thank you for the clean up! I guess we have a good starting point to built upon :)

is that a flaky test ?

I can reliably get it locally.

weird: the fail happens on #7 on python 3.8 but not on #6 that does not run 3.8 but I get the fail locally with python 3.12...

OK my bad: when running locally in proper virtual environment (and not my usual conda 'ecosystem' - larger and meaner than an environment), everything is OK.
So I would try merging #6 to stop supporting py3.8 and get rid of the error.

Sounds good to me!

@tsalo: aren't you afraid that adding the word typo in the title of the PR may summon the codespell demon? (AKA @yarikoptic) 😜

https://github.com/paquiteau/patch-denoising/pull/12


German translation

Merry Christmas!

Gooooood I'll ask @teddyxlandlee for further infos about this translation, thank you for collaborating to Sweet Potato Mod!

Gooooood I'll ask @teddyxlandlee for further infos about this translation, thank you for collaborating to Sweet Potato Mod!