Fix constant initializers if the specified type is different

Closes #70861.
Closes #71255.
Closes #71635.

Notice this PR fixed it by disallowing using such expression on the analyser level, while mine (https://github.com/godotengine/godot/pull/70872) at the compilation stage. But your solution is cleaner and have a test...

Should we allow const A: int = 1.0? For function parameters, this is prohibited:
# Error: Type of default value for parameter "x" (float) is not compatible with parameter type (int).
func f(x: int = 1.0):
    pass

# Error: Type of default value for parameter "x" (int) is not compatible with parameter type (float).
func g(x: float = 1):
    pass

For variables, this already works correctly and makes sense.
: float = 1 shouldn't give an error anywhere I guess.

Should we allow const A: int = 1.0? For function parameters, this is prohibited:

I think this should not be allowed. That would then also matches with a lot of other languages.

Solution seems right.
Maybe ERR_FAIL  check for CallError is appropriate, at least for future proofing.

For function parameters, this is prohibited

Function parameters handling is lackluster compared to variables/constants. It does not seem like a deliberate choice but just historical oversight.
For assigning values to changeable assignables (variables/parameters) there is a use_conversion_assign. It is present on variable node and on assignment node (lacking again on parameter node), it is used when the type of the incoming thing is either a variant/untyped or a differently typed but convertable.
It was similar logic for constant, but it was neglecting the fact that there will be no future conversion assignment and that reduced value will be used as is.

const A: int = 1.0, I think this should not be allowed.

I think it makes sense to add at least a warning for cases like this when an initializer is a LiteralNode. (Easy to add it to unification PR as such warning applicable to all assignables, not only constants.)
But for cases such as var/const x = y (where y is a convertable but different type), I think there is not much sense in prohibiting it.

I believe it's okay to allow initializing with a different type if people need it, but there should be a warning because there's a good chance it's a mistake. Especially for the case of constants, since you only assign it once, doesn't make much sense to set a value of a different type.

More testing:
@tool
extends EditorScript

func f1(x: int = 1.0):
    return x

var t2 := 1.0
func f2(x: int = t2):
    return x

var t3 = 1.0
func f3(x: int = t3):
    return x

var t4 = "lalala"
func f4(x: int = t4):
    return x

func _run() -> void:
    print(typeof(f1())) # 2
    print(typeof(f2())) # 2
    print(typeof(f3())) # 3
    print(typeof(f4())) # 4

What you shown is lack of use_conversion_assign on parameter node.

What you shown is lack of use_conversion_assign on parameter node.

I think now the PR is ready for review.

Superseded by #71844.


Cherry pick request for Gradle change

Impact: Users aren't able to build for Android if they import plugins with transitive dependencies such as:

shared_preferences -> shared_preferences_web
location -> location_web
firebase_core -> firebase_core_web

Fix: https://github.com/flutter/flutter/pull/57907, which was checked in into master
cc @pcsosinski

I'm actually unable to repro this issue. I will reopen if something is clarified.

@blasten Please see my reply in my PR:
https://github.com/flutter/flutter/pull/57907#discussion_r436297250

@blasten I removed the CP label, please re-add if there's something we need for 1.17 here.


KAFKA-7440 Add leader epoch to fetch and list-offset request

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please

The failures are known flaky tests. I will go ahead and merge.


docs: fix typo

Fix typo in header file
It's about fixing typo to example code ml_train_datagen_cb of  nntrainer-api-common.h

Hi, @kim-com
Thank you for your contribution! 😀
NNTrainer requires a contributor to follow a specific coding convention with signing off. Please refer to this contribution guide [link]. For the details, please check the CI review.

Thank you for your contribution :)
Please check the commit body. You can amend the commit after adding the body message. Thank you.


Added new tests to verify negative results of clEnqueueSignalSemaphoresKHR

According to work plan from issue https://github.com/KhronosGroup/OpenCL-CTS/issues/1691

@shajder Can you fix conflicts on TOT?

@nikhiljnv that might be a bit difficult, I am on my vacation without mobica workstation... but I can make you a collaborator of my fork if you have time to solve those conflicts, otherwise I can do that right after I get back to work.

@shajder Can you fix conflicts on TOT?

@nikhiljnv conflicts solved.

Qualcomm is OK with this change

close/open to retrigger CI


Update jGRASP to 2.0.6_04

Nothing wrong with this one, but I merged the other as its more likely to be noticed, and we can re-test Actions against this if necessary.


Focusing of non-focusable element fixed

/cc @AlexanderMoskovkin @georgiy-abbasov @VasilyStrelyaev

invalid test markup


Embed ocaml-secondary-compiler

Dune currently does not support OCaml < 4.08 natively and requires ocaml-secondary-compiler to build.
Adding it directly in the base docker images would greatly simplify CI systems, as this sort of hack has to be installed in almost every CI systems out-there anyway (mirage-ci, ocaml-ci-scripts and opam-repo-ci currently has it). Not having it installed in the base image (be it in ocurrent/opam or in a custom base used by those CI systems) increases the compilation time quite significantly.
This also simplifies updating the requirements. Per one of the dune lead dev, dune only supports the latest 3 versions of the compiler natively. So updates will happen after each OCaml releases and having it in one place simplifies this update process.
The only two downsides I'm seeing from this is the increase in image size and having one more package installed by default that is thus not checked by CI systems if some packages somehow relies on it directly but forgot to list it in its dependencies.
In practice I don't know any packages that do that (even dune just relies on ocamlfind-secondary, not ocaml-secondary-compiler directly). As for the size issue this is a bit unfortunate to add ~285Mo but oh well.. :cry:

Do we need to put the whole secondary switch in the final image? Perhaps we could just copy the resulting dune binary in and somehow convince opam that it's installed?


2FA for live account

I would like to use this docker image with my IB live account, but the account is protected with 2FA, so it requires to use VNC to enter the code.
Is there a way to skip the 2FA code or to automate the process somehow?
Did anyone find a solution for it?

By any chance, do you not have IB app installed? It comes with its own 2FA method built into the app called IB Key.
Here's what the docs have on this (emphasis mine):

Secure, but quick and “no-hassle” login: When logging in to our Trading Platforms or Portal, enter your username and password.

Ideally, you should be able to complete 2FA whenever your gateway restarts by receiving a push notification on your phone and doing a fingerprint check
Here's how 2FA looks in the portal when IB Key is set up:


when speed knob is turned down the output value doesn't change

I was trying to get a real smooth slow lfo going but it doesn't seem to slow down enough.  It seems to just stop.  And then it gets worse over time.  It will stop at a higher and higher value.  Maybe related to that other issue https://github.com/naus3a/NauModular/issues/3

The speed knob/input is the increment on the value used to generate Perlin noise. This value at the moment is just growing, so yes, both issues might be solved by a circular value range.
The flatline you're getting should not happen in any case: maybe there's some explicit casting needed too.
Will look into it.

The lowest value for the speed know was simply too low; I adjusted it to something that still shows up in the scope.


Gradient for getindex

https://github.com/SomTambe/DiffImages.jl/blob/6937f982febbdd6dbe963cca562b50f66c45589b/src/geometry/adjoints.jl#L76
Notice that the output gradient does not depend on the δ, which does not seem correct.

Yeah you were correct, it's a mistake.
It should be in the format δ * gr .
But here, I had a doubt.
δ is in the form of NamedTuple(:r,:g,:b) when we give it an RGB image. how would the multiplication operation be defined in this case, if gr is a SVector consisting of 2 elements, each being RGB ?
I think since the gradients propagate channelwise, it will be channelwise multiplication of δ and gr elements.
What do you think @johnnychen94?

I would imagine you could construct an RGB from delta and use ColorVectorSpace to handle the multiplication.

Which is channelwise multiplication in this case, but may not be generically true, for colorspaces whose fields are not orthogonal. But that's just my guess.

Well I used hadamard ⊙ from CVS. I made these changes -
Zygote.@adjoint function ImageTransformations._getindex(A::AbstractExtrapolation, x)
    y = A(Tuple(x)...)
    function ∇(δ)
        gr = Interpolations.gradient(A, Tuple(x)...)
        if !(typeof(δ) <: Number)
            δ = eltype(gr)(δ...)
            gr = δ .⊙ gr
        else
            gr = δ .* gr
        end
        return (nothing, (gr,))
    end
    return (y, ∇)
end

There still seems to be some difference in the gradients -
julia> Zygote.gradient(h) do trfm
           y = warp(src3, trfm, 0.0)
           y = mseloss(y, tgt3)
           y
       end[1].H
3×3 Matrix{Float64}:
 35976.8        76976.4         701.519
     1.0566e5   61267.0        1342.3
    -1.17905e7     -1.46389e7    -1.42039e5

julia> grad(central_fdm(5,1),f,h)[1].H
3×3 SMatrix{3, 3, Float64, 9} with indices SOneTo(3)×SOneTo(3):
 50848.0         1.60798e5  701.662
     1.82618e5   1.16586e5  852.918
    -8.85505e6  -1.70292e7   -3.04226e5

f is the same function written in the Zygote.gradient part. mseloss is literally the L2 loss.

I experimented a bit more, and I got this -
julia> zygm = Zygote.gradient(h) do trfm
           y = warp(src3, trfm, 0.0)
           y = mseloss(y, tgt3)
           y
       end[1].H
3×3 Matrix{Float64}:
 35976.8        76976.4         701.519
     1.0566e5   61267.0        1342.3
    -1.17905e7     -1.46389e7    -1.42039e5

julia> fdm = grad(central_fdm(2,1),f,h)[1].H
3×3 SMatrix{3, 3, Float64, 9} with indices SOneTo(3)×SOneTo(3):
 35976.8        76976.4         701.519
     1.0566e5   61267.0        1342.3
    -1.17905e7     -1.46389e7    -1.42039e5

julia> zygm - fdm
3×3 SMatrix{3, 3, Float64, 9} with indices SOneTo(3)×SOneTo(3):
  0.0014415     0.00132396  -0.000471868
  0.000241908  -0.00309845   0.000104416
 -0.0023831    -0.0184508    0.00364473

The docs for FiniteDifferences here show that the first argument denotes the number of grid points, but I would like to read more about it.
Anyways, now the finite differences methods gradient is literally equal to the Zygote gradient.

Would you be able to say more about the experimentation?

Have we tried training with finite differences?

Would you be able to say more about the experimentation?

Nothing! I just changed from 5th order central method to 2nd order central method, and the gradients are equal now!

Another update:
central_fdm(5, 1; adapt=2, max_range=1e-4) also works pretty good, but still cannot beat central_fdm(2,1).

Since there will be a new alternative PR to #7 I'd suggest write new adjoints using ChainRulesCore and then test every rrule with https://github.com/JuliaDiff/ChainRulesTestUtils.jl

As a minimal example, we could have early identified this issue if we've checked this:
using ChainRules, ChainRulesTestUtils
using ImageTransformations, Interpolations

function ChainRules.rrule(::typeof(ImageTransformations._getindex), A::AbstractExtrapolation, x)
    y = A(Tuple(x)...)
    function ∇(δ)
        gr = Interpolations.gradient(A, Tuple(x)...)
        return (ChainRules.ZeroTangent(), (gr,))
    end
    return (y, ∇)
end

A = extrapolate(interpolate(Float64[1, 4, 2], BSpline(Linear())), 0.0)
rrule(ImageTransformations._getindex, A, 1.5)

test_rrule(ImageTransformations._getindex, A, 1.5) # this errors

Once again, it's a good practice to incrementally write tests for every piece of the entire pipeline.

This seems to be a nice way to go with testing. I shall convert the tests to these types which use test_rrule and update you with it.

Yeah I was getting similar errors -

Yeah I was getting similar errors, not sure how acceptable something like this is -
...
  Got exception outside of a @test
  InexactError: Int64(2.99)
...

Even in other cases -
  Got exception outside of a @test
  InexactError: Int64(186.99)

I already read the stacktraces. The problem is encountered in the FiniteDifferences.to_vec function, which does not work very well with Integers (and structs with them). Nevertheless, the issue for us had gotten resolved, since I wrote the tests myself instead of using ChainRulesTestUtils; there should be a look into why tests with Interpolations fail with CRTU, and how to resolve them, but I guess that is beyond the scope of what I am doing. I may pick that issue later on CRTU, and  provide a solution, but for now, we are sorted.
If you still want the stacktraces, please let me know, I shall be happy to provide them.


Make LDAP PM conditonal on property

While adding the cas-server-support-pm-ldap dependency is a required step to add LDAP PM support, it should not be enough and the cas.authn.pm.ldap.ldpUrl property (at least) should be defined.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Workspace promotion conflict resolution

What is the purpose of this pull request?
To add a --conflict flag on workspace promote command.
The flag must have one of three values:

master: preserves value from master when data has conflict. [default]
mine: overrides data from master with value from workspace when there is any conflict.
abort: aborts workspace promotion if any conflict exist.

What problem is this solving?
Default conflict handling strategy not being enough for end users - e.g. Motorola.
How should this be manually tested?
Just cause a conflict in a workspace and then try to promote it with the different flags.
Screenshots or example usage

Types of changes

[ ] Refactor (non-breaking change that only makes the code better)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Requires change to documentation, which has been updated accordingly.

Chores checklist

[x] Update CHANGELOG.md

CI has failed because I have not released the updated node-vtex-api.

I think this ci/prepack error will be fixed when you launch the new version of @vtex/api, he is necessary to update the plugin documentation automatically.

I think this ci/prepack error will be fixed when you launch the new version of @vtex/api, he is necessary to update the plugin documentation automatically.

If this was not the case, probably will need to update the @vtex/api version on toolbelt so then you can update inside cli-plugin-workspace

What I need to ask you to make different, as a designer:

Remove the time information that comes along the error message;
The "action" the message suggests is the first information the user wants to read so, we bring it to the first sentence and explain the context and why to do what we are suggesting after the action. It gives more context to the user decision flow;
The instructions are a little bit long but I'm happy we are prioritizing information insurance over simplicity for now (we may discover it is not the best furthermore, but for now sounds safe hahaha), to reduce the sensation of "too much to read", we should break the content with line dividers.

I assume that is not the ideal flow to me yet. In the ideal scenario, we identify the conflict, ask the user if she wants us to solve it OR if she wants to check it out by herself. If she says "yes" for the Toolbelt "auto-solving" we run a script that considers the app context and automatically sends a request to the workspace and it's all ready to be promoted.
As I understand maybe promote issues are not such a big deal right now, I'm just sharing how it could work to be more aligned with a more proactive Toolbelt :)
Check it out on Figma


Repair a corrupt xml.exe file

Software version
0.8.2
What are you trying to do?
install and have the led lights operational on the Bravo throttle quadrant
What's the problem?
honeycomb software not working and trying to install betterbravolights
What have you tried already?
all you tube suggestions, nothing works
Other information
I have attached my xml.exe and cant fix it or identify corruption. can you help fix it?   Thanks,  Tom
<?xml version="1.0" encoding="Windows-1252"?>
<SimBase.Document Type="Launch" version="1,0">
	<Descr>Launch</Descr>
	<Filename>exe.xml</Filename>
	<Disabled>False</Disabled>
	<Launch.ManualLoad>False</Launch.ManualLoad>
	<Launch.Addon>
		<Name>FenixA320</Name>
		<Disabled>False</Disabled>
		<Path>C:\Program Files\FenixSim A320\deps\FenixBootstrapper.exe</Path>
  <Launch.Addon>
    <Name>AFCBridge</Name>
    <Disabled>False</Disabled>
    <Path>C:\Users\purpl\AppData\Local\Packages\Microsoft.FlightSimulator_8wekyb3d8bbwe\LocalCache\Packages\community\AFC_Bridge\bin\AFC_Bridge.exe</Path>
   </Launch.Addon>
</SimBase.Document>

Hi @TParrine85champ.
There's a missing </Launch.Addon> at the end of the FenixA320 block. It amazes me how badly these tools mangle this simple XML file.
Here's a fixed version:
<?xml version="1.0" encoding="Windows-1252"?>
<SimBase.Document Type="Launch" version="1,0">
	<Descr>Launch</Descr>
	<Filename>exe.xml</Filename>
	<Disabled>False</Disabled>
	<Launch.ManualLoad>False</Launch.ManualLoad>
	<Launch.Addon>
		<Name>FenixA320</Name>
		<Disabled>False</Disabled>
		<Path>C:\Program Files\FenixSim A320\deps\FenixBootstrapper.exe</Path>
	</Launch.Addon>
  <Launch.Addon>
    <Name>AFCBridge</Name>
    <Disabled>False</Disabled>
    <Path>C:\Users\purpl\AppData\Local\Packages\Microsoft.FlightSimulator_8wekyb3d8bbwe\LocalCache\Packages\community\AFC_Bridge\bin\AFC_Bridge.exe</Path>
   </Launch.Addon>
</SimBase.Document>

Out of interest, did you install the Honeycomb drivers before the A320 addon or afterwards?  (I'm interested to know which one broke the file.)

This is now the second broken exe.xml file I've seen, with the Fenix A320 in it and exactly the same problem.
See also #53


Add "slime chunks" view option

I found it rather annoying to try and switch between MCEdit and an external slime chunk viewer, so I added a "Slime Chunk" view option which marks slime chunks with a green box.

does this still work?


fixed warning for aio and get call function tools for stream within t…

…he SDK
Description
Get rid of warning in aio AgentOperation.    TO do that, I copied the AgentsOperation from sync to async/aio and modify accordingly.
Call functions within SDK for streaming instead of asking developers to call in their code.   I will do this for non-streaming.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Give some time to review :)


Supporting round 2 development

Two small changes based on collaborators' needs -

allow exp-lookit-story-page (and exp-lookit-dialogue-page since it uses the same setup) to control formatting of parent text, in order to show more text if needed (for Lisa)
create a randomizer to randomly permute a set of frames (allowing stimuli to be presented in random order) (for Bria)

Tested locally to make sure the exp-lookit-story-page/dialogue-page changes don't introduce errors with existing definitions, and to make sure randomizer permute works and can be nested within random-parameter-set.

I can merge this today when it's ready if needed, but bear in mind it won't get much in the form of QA from our end due to the present time constraints. (we always try to warn you when that will be the case)
Were you and Sara able to work out a procedure for bug reporting while you're out?


Use Dtype instead of Packager

Type of Change

[x] Refactoring

Description
Uses Dtype instead of packager to keep the consistency with the Fedora section.
Changed Packager at the top of the RPM Fusion script to Dtype.
Might want to look into #258 before deciding on what to do with this PR, as that one uses Packager at the top of the added scripts.
look into #287 before deciding on what to do with both of these PRs

Conflicts with #287
Might conflict with #282
Closes #287

Testing
Works perfectly
Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] My changes generate no errors/warnings/merge conflicts.

I'm going to refactor this PR a bit.

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

Finished.

Closed because this will be a hassle to implement in the new scripts that will be getting added in the current PRs.


[Question] Why the link of LAION/CC/SBU BLIP-Caption Concept-balanced 558K Meta Data(meta.json) is empty?

Question
No response

I want to download the dataset, but the link is turn to https://github.com/haotian-liu/LLaVA/blob/main/docs/Data.md

It seems the link is not updated.
You can find the link in the huggingface, I used this link for downloading.
https://huggingface.co/datasets/liuhaotian/LLaVA-Pretrain/blob/main/blip_laion_cc_sbu_558k_meta.json


cannot select the database of notion

[validation_error] body failed validation. Fix one: body.parent.database_id should be a valid uuid, instead was "". body.parent.page_id should be defined, instead was undefined.
I've invite the integrations on the database page.

[validation_error] body failed validation. Fix one: body.parent.database_id should be a valid uuid, instead was "". body.parent.page_id should be defined, instead was undefined.
I've invite the integrations on the database page.

How did you solve it? THX!

[validation_error] body failed validation. Fix one: body.parent.database_id should be a valid uuid, instead was "". body.parent.page_id should be defined, instead was undefined.
I've invite the integrations on the database page.

How did you solve it? THX!

Hi, I just create the database page again exactly follwing the instructions.


[pulsar-admin] Add remove-subscription-types-enabled command for topic

Motivation
CLI bin/pulsar-admin topics supports set-subscription-types-enabled and get-subscription-types-enabled command, but lacks corresponding remove-subscription-types-enabled commands,  the purpose of this PR is to add this command for topic.
Documentation
Automatically generate doc through code

[x] doc

@merlimat @congbobo184 @gaoran10 PTAL

I am approving this patch.
thank you @yuruguo for checking about my comments.
I believe we have to follow up and fix potential local cache consistency problems.
would you like to follow up ?
cc @merlimat

Thanks for your guidance, I will create an issue to track this problem and try to submit a PR to solve it :)

@codelipenghui please merge if no other questions :)


Add AWS CLI to windows-latest

Tool information

Tool name: AWS CLI
Add or update? Add
Desired version: 2
Approximate size: 24 Mb
If this is an add request:

Brief description of tool: Command line interface tools for AWS
URL for tool's homepage: https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2-windows.html

Area for Triage:
Scripting and command line
Question, Bug, or Feature?:
Feature
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[x] Windows Server 2019

Can this tool be installed during the build?
No. It will need addition to the path.
Are you willing to submit a PR?
No

Hello!
This request is duplicate of #13 . AWS CLI was added to image recently. The new image will be deployed by the end of this week.


Navigation only works in the starting tmux pane.

OS: MacOS Ventura 12.1
Vim: NVIM v0.8.1
Tmux: 3.3a
I can only navigate between vim panes if it's open in the "original" tmux pane. If I split tmux vertically and open vim in the right pane (the created pane) then split vim vertically, I'm only able to navigate between vim and tmux. Hopefully, that makes sense.
Opening vim in the "original" tmux pane and splitting vim there is the only place I can navigate seamlessly.
I ran :TmuxNavigatorProcessList in the "original" pane and it would output:
Ss   /bin/zsh
S    /bin/zsh
S    /bin/zsh
S    /bin/zsh
S    /Users/milly/.cache/gitstatus/
Z    <defunct>
S+   nvim

Running the same command in a split pane of tmux then entering vim outputs:
Ss+ zsh (figterm)

I noticed the "(figterm)", would that maybe influence this problem? Since configuring iTerm with neovim via Josean's video, Fig doesn't work anymore so I figured I didn't need to uninstall it. Or I don't know if this is an unrelated issue.
Regardless, any help would be appreciated :) I'm all very new to this

The issue was with Fig. I uninstalled refreshed Tmux. Everything works fine now.

For anyone hitting this issue. You can get it working with fig by using an approach like: https://github.com/christoomey/vim-tmux-navigator/issues/295#issuecomment-1123455337


CTRL+R causes Refresh

In the EasyMark text editor it tells you to use CTRL or CMD + R to raise text as opposed to CTRL+L to lower. This causes the web browser to refresh the page. I would recommend moving it over one to CTRL+Y
website with common web browser hotkeys

CTRL+C for code needs to be changed as well

do you want to make a pr?


fix hardware switch bug

This is a funny bug.
It seems like the original author didn't expose this property (I think they just forgot). I updated the JS code here with the updated stackoverflow post where the patch originally came from.
https://stackoverflow.com/questions/56460362/how-to-force-wkwebview-to-ignore-hardware-silent-switch-on-ios
I will make a PR upstream as well 😆

Also verified that this works now

The new trick relies on .mute which miraculously works across all iOS versions including iOS14 (but only when accessing documentById directly not a var). No mediacenter when locking the screen neither. It took a lot of research, but we got it.

🙌🏻
Great find!


Ignore some kubeadm preflight checks when validating cluster requirements

What this PR does / why we need it:
Ignore some kubeadm preflight checks when validating cluster requirements to account for adding new static worker nodes. For more details about this, see #2802
Which issue(s) this PR fixes:
xref #2802
What type of PR is this?
/kind bug
/kind regression
Does this PR introduce a user-facing change? Then add your Release Note here:
Ignore some `kubeadm` preflight checks when validating cluster requirements to account for adding new static worker nodes

Documentation:
NONE

/assign @kron4eg @ahmedwaleedmalik

/retest

/approve
/lgtm


broadcast error- hq changed the header required for getting broadcast url

from past two days this script is not working. when I sniffed packet using packet capture, i found that hq has added ccountry parameter to headers and that could be the reason for the script to be not working. please add a fix to this

Same! Its not working for me either now. A fix will be highly appreciated!

I have had no problem connecting to today's game or yesterday's game.

ok i will try today, may be that the token or userid I am using got banned

@mashukmashum let me know!!

No response for 6 days, assuming solved. Check #113 if you are still having problems, your bearer token may have expired.


Forced/Required Response Feature

(This is a feature that we may not require at the moment as we run our own surveys. But we may need it once we start running other people's surveys) But:

Implement a feature where we can choose to either force a respondent to respond to a question or leave it as optional

Question on what the system should do if a respondent hasn't answered a 'forced response' question? Just prevent from submitting?

Required is already implemented for all questions by default as a server level setting.
What I think would be useful here is something like an optional column in CSVs called required that defaults to the server value when blank, but can take values of true or false to select if a field is required or not.

I think we would need to reconcile this with the overall required check that we already have in place. i.e. Do we want both overall and individual required variables? If not, how would we indicate survey-wide required characteristics (is it useful to have any disclaimer if no questions are required?). I've modified the code to include my interpretation of this, but let me know if it needs changes.

Can you summarize your policy?
I’d just assume required is on by default for everything and then some things are optional if there’s a column that expresses that.

On Dec 13, 2021, at 03:39, Karan Sampath @.***> wrote:

I think we would need to reconcile this with the overall required check that we already have in place. i.e. Do we want both overall and individual required variables? If not, how would we indicate survey-wide required characteristics (is it useful to have any disclaimer if no questions are required?). I've modified the code to include my interpretation of this, but let me know if it needs changes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes exactly, so each question is required unless specified (will take on that value in that case (i.e. either true or false)).


[Bug] Cloudflare not solving turnstile

I saw the update for the cloudflare turnstile https://github.com/NopeCHALLC/nopecha-extension/releases/tag/0.4.12 but it still doesn't seem to be working for me. (On the latest firefox version https://addons.mozilla.org/en-US/firefox/addon/noptcha/)
It just stays unchecked like this

Am I doing this wrong? The settings seems to be correct.

I have the same issue on chrome for Cloudflare turnstile from 7/11/2024

I have the same issue on chrome

I have the same issue on chrome

When will it be fixed? I tried to simulate a click through JS, but it didn't work, ChatGPT says that the code doesn't work because the iframe is loaded from another domain. Such as security, etc.
`function handleVerification() {
let iframe = document.querySelector('iframe[title*="Cloudflare"]');
if (iframe) {
setTimeout(() => {
document.body.appendChild(iframe);
let doc = iframe.contentWindow.document;
let checkbox = doc.querySelector('input[type="checkbox"]');
if (checkbox) {
checkbox.click();
setTimeout(() => {
}, 4000);
}
}, 3000);
} else {
}
setTimeout(() => {
    let confirmInput = document.querySelector('input[value*="Verify"]');
    if (confirmInput) {
        confirmInput.click();
        setTimeout(() => {
        }, 3000);
    }
}, 7000);

}
handleVerification();
`

If it was that simple, it'd be fixed already.


Add method to revert Loggable entity to previous version(s)

Do you think such a feature is reasonable?
I will add tests if I get a good-to-go so that I won't waste effort if the patch won't be accepted.

Hi, I think people can add similar behavior to their repositories. it already provides a method for reverting that is enough for general purpose, this is just for convenience, if we add a bunch of that kind of methods it will be confusing to find and understand generic ones

Thanks for the reply, I tend to agree, here's my reasoning for this change:
I expected the revert method to go to the previous version by default but it goes to the first one instead.  That is why I created this as a separate method.  I think it would be best to change the default to go -1 but that will break BC if someone relies on that (but I can't imagine who would ever want to revert to the first revision, that is very very unlikely).
Anyhow, we don't need to accept this if you think it will make the API less clear.  Feel free to close if this is the final decision.

@Fuco1 Thank you for the pull request, and apologies for it being ignored for a while.
I like this idea for the future. I agree that I would assume "revert" meant go back one version, not to the beginning (which might be "reset").
Going to close this specific PR, though, until we can get this library back on track and deal with some of the larger looming issues first.


User Research: Discovery & Guidance

Purpose

How do we help the library visitors with onboarding and make them better researchers?
How can we model the online experience based on the current library/research service we provide and make it better?
Validate any gap in our research insights for non-academics/self-developers

Key Research questions
TBD
Research Plan
Task 1 Observe & interview library visitors using our collections
Task 2 In-depth interview with visitors using research library materials
Task 3 Library desk observation (LED and RMR)
Task 4 Interview external research specialist
Task 5 Workshop with internal research specialist
Task 6 Understanding our collections
Deliverables

Build user profiles/update

Who are they? What’s their motivation? Why are they using Wellcome?
Current research experience and pain points
Their needs and opportunities?

Update user stories based on findings
Guidance Map

Tasks
Week of 3 June
Task 1

[ ] Interview non-researchers

Task 4

[x] Interview research specialist

Week of 20 May
Task 5

[ ] Document a journey map
[ ] Continue recruitment: writers/journalists, self-developers
[ ] Monitor survey feedback

Week of 13 May

[x] Continue recruitment
[x] Launch survey at RMR and LED

Week of 7 May
Task 1

[x] Summarise insights

Task 3

[x] Review library and collections enquiries and summarize (Amelia and Vicky)

Task 4

[x] Write interview script

Task 5

[x] Summarise insights (cont.)

Week of 23 & 29 April
Task 4

[x] Recruitment (cont.)

Task 1 & 2

[x] Work with Simon D to roll out a survey at LED and RMR desks (waiting for approval)
[x] Write script
[x] Observe researchers in Library

Task 3

[x] Meet with Amelia and Vicky to understand the workflow of collecting user enquiries and the type of questions they receive.

Week of 15 April
Task 5

[x] Plan a workshop
[x] Run workshop
[x] Summarise insights

Task 4

[x] Send out recruitment emails (Lyndsay)
[x] Meet with Angela to walk her through the project and get contacts for recruitment

Outputs

Revised profiles
Visual user journey map
Insights logged in Aurelius

Comms plan

[ ] Meet with content team to discuss research and implications for content development; kick off content audit
[ ] JPB to present to teams once all outputs are available


feat(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1342

Questions ?
Please refer to the Backport tool documentation


Change Heading

@Wes1eyCh0i  2 commits are showing up here. Do the following to see if it will fix it to be only 1 commit.
git fetch upstream
git rebase upstream/main
git push -f origin assignment-3-branch

Closing as the deadline has passed.


[Proposal] IsAscending and IsDescending

These functions can be expressed in terms of other MoreLinq extensions:
        public static bool IsAscending<T>(this IEnumerable<T> list) where T : IComparable<T>
            => list.IsAscending(Comparer<T>.Default);

        public static bool IsAscending<T>(this IEnumerable<T> list, IComparer<T> customComparer)
            => list.Pairwise((x, y) => customComparer.Compare(x, y)).All(x => x <= 0);

        public static bool IsDescending<T>(this IEnumerable<T> list) where T : IComparable<T>
            => list.IsDescending(Comparer<T>.Default);

        public static bool IsDescending<T>(this IEnumerable<T> list, IComparer<T> customComparer)
            => list.Pairwise((x, y) => customComparer.Compare(x, y)).All(x => x >= 0);

Mathematically there's a difference between 'ascending' and 'strictly ascending', where the latter is not allowed to have any equal pairs. So it's worth considering adding separate extension methods like 'IsStrictlyAscending'.
Example NUnit tests:
        [TestCase(new[] { 1, 1, 1, 1, 1, 1 }, ExpectedResult = true)]
        [TestCase(new[] { 1, 2, 3, 4, 5, 6 }, ExpectedResult = true)]
        [TestCase(new[] { 1, 2, 3, 3, 2, 1 }, ExpectedResult = false)]
        [TestCase(new[] { 'a', 'd', 'd', 'r' }, ExpectedResult = true)]
        [TestCase(new[] { 'u', 'r', 'r', 'n' }, ExpectedResult = false)]
        public bool IsAscending_ReturnsExpectedResult<T>(IEnumerable<T> list) where T : IComparable<T>
        {
            return list.IsAscending();
        }

This seems like a duplicate of #532 where we came to the conclusion that these are not worth the effort and confusion they may cause outside a specific application or context.
I am closing this on the same basis as #532 but happy to reconsider in a new light.


New sbt-based build

This switches over our entire build process to use sbt rather than Gradle. It also restructures the project to use the Scala.js directory structure and adds support for building the project to JavaScript.
Currently, the JavaScript built won't be useful, since we need to add Scala.js export annotations to the APIs we want to export to JS.
Also, coverage information is currently broken. This is due to an issue with Scoverage and Scala.js (scoverage/sbt-scoverage#111). Once this is fixed we should be able to collect coverage data again – I'd like to use codecov.io rather than Coveralls since it's easier to use and integrates with GitHub commit status really nicely.
I also still need to update some of our internal documentation to refer to the use of sbt rather than Gradle and explain how to use some of sbt's cooler features.

Commits d41e9ac39c2bf856f2080d08368a080c8ffe0351 and 90f5dae5ca67cb72b7706182cbf5007cf1c63b80 fix the coverage issue.

Note also that Codecov is going to say that the patch coverage of this PR is too low; that is actually because this pull-request re-adds our entire codebase (because I had to change the directory structure for Scala.js), and our overall coverage score is only 55%.


Porting from docdock to hugo-theme-learn

I have a site that's written and configure for the docdock theme, which I know is related rather closely to this theme. I'd like to switch over to this theme from it to try out some new features etc.
Suggestions on any high level approaches to take? In reading things I see a new "chapter" structure which isn't in docdock.

(Apologies if there's a better place for this.)
I was able to make some progress by upgrading my version of Hugo from 0.40 to 0.59. That got rid of the "function hugo not defined" error. Is there a minimum version number for Hugo that crept in along the way?

Unfortunately Hugo has a little bit of a track-record of introducing backwards breaking changes in new versions. Thus, depending on the current development state of your Hugo project, your project might not work with either the newest version of Hugo - or a version that is too old.
Also the author of this theme seems to have been inactive for a while now. May be she or he is on a hiatus currently.

Also the author of this theme seems to have been inactive for a while now. May they are on a hiatus currently.

I'm helping with maintenance but I've a habit of dropping by only every 2 or 3 months to blitz through the issues & merge requests and ship a release all in one go.
As for versions of hugo supported... I don't keep close enough track of changes (breaking or not) to be able to offer a guarantee of supported versions with the theme. The community that use this theme have been very good at sending MRs which address hugo deprecations and errors.
Generally speaking I would recommend using latest hugo at all times & ignore whatever your package manger is shipping you. Set up a test site where you can build against latest hugo and preview the changes before shipping your production site.
p.s. we do that on this repo with netlify, all MRs have a full copy of the examplesite rendered and pushed to a staging URL

Thanks for clarifying :). And I agree, that only ever the newest version should be considered.


About extracting pre relu features

https://github.com/clovaai/overhaul-distillation/blob/master/ImageNet/models/ResNet.py
def extract_feature(self, x, preReLU=False):
    x = self.conv1(x)
    x = self.bn1(x)
    x = self.relu(x)
    x = self.maxpool(x)

    feat1 = self.layer1(x)
    feat2 = self.layer2(feat1)
    feat3 = self.layer3(feat2)
    feat4 = self.layer4(feat3)

    x = self.avgpool(F.relu(feat4))
    x = x.view(x.size(0), -1)
    out = self.fc(x)

    if not preReLU:
        feat1 = F.relu(feat1)
        feat2 = F.relu(feat2)
        feat3 = F.relu(feat3)
        feat4 = F.relu(feat4)

    return [feat1, feat2, feat3, feat4], out

Hi!
I'm confused why when preReLU=True, your feat2 = self.layer2(feat1) as feat1 is pre-relu. I think it would make more sense to me if feat2 = self.layer2(F.relu(feat1))

I see. You removed relu function at each layer. So you actually changed the Resnet arch. Do I misunderstand something?

I see. You put relu to the first of each block.


CVE-2022-34903  in amazoncorretto:11-al2-jdk

Describe the bug
hey folks, I found in the latest version of amazoncorretto:11-al2-jdk CVE-2022-34903 (gnupg2 library).
To Reproduce
Trivy output

Version from instance:

Yum update

Best!

Please do not report potential vulerabilities as issues, and instead follow the instructions in the README. See also Why does security scanner show that a docker image has a CVE?, especially the second section below the separator.


Documentation for AdaptiveCard People Picker

This PR contains documentation for Adaptive Card People Picker

Docs Build status updates of commit 50fc539:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/task-modules-and-cards/cards/people-picker.md
:warning:Warning
View
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md

Line 29, Column 1: [Warning-duplicate-alt-text] Alt text 'People Picker Search' is duplicated. Within an article, alt text must be unique.
Line 34, Column 1: [Warning-multiple-h1s] Multiple H1s(H1 'Overview') are not allowed. You can only have one top-level heading.
Line 104, Column 1: [Warning-duplicate-alt-text] Alt text 'People Picker Search' is duplicated. Within an article, alt text must be unique.
Line 113, Column 1: [Warning-table-syntax-invalid] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit df49247:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0007511:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 8514bbd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/task-modules-and-cards/cards/people-picker.md
:warning:Warning
View
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md

Line 49, Column 1: [Warning-table-syntax-invalid] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c1a1491:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/task-modules-and-cards/cards/people-picker.md
:warning:Warning
View
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md

Line 49, Column 1: [Warning-table-syntax-invalid] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c7175e4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ebea9fa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0d5775a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a024ab8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5413389:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit bd14f97:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 4035ccc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit cdb843f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d08b3f2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7bc7268:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/task-modules-and-cards/cards/people-picker.md
:warning:Warning
View
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md

Line 154, Column 1: [Warning-file-not-found] Invalid file link: '../../assets/images/cards/mobilepp.gif'.
Line 160, Column 1: [Warning-file-not-found] Invalid file link: '../../assets/images/cards/desktoppp.gif'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2050593:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/desktoppp.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/mobilepp.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
96
5
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/people-picker.md
80
26
link
:white_check_mark:

msteams-platform/whats-new.md
86
33
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 493ecf2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
96
5
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/people-picker.md
80
26
link
:white_check_mark:

msteams-platform/whats-new.md
86
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 60860f3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/desktoppp.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/mobilepp.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
96
5
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/people-picker.md
80
26
link
:white_check_mark:

msteams-platform/whats-new.md
86
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 27da7a9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/task-modules-and-cards/cards/people-picker.md
:warning:Warning
View
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/desktoppp.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md

Line 154, Column 1: [Warning-file-not-found] Invalid file link: '../../assets/images/cards/mobilepp.gif'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/TOC.yml
96
5
link
:white_check_mark:

msteams-platform/task-modules-and-cards/cards/people-picker.md
80
26
link
:white_check_mark:

msteams-platform/whats-new.md
86
31
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1e7917c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/desktoppp.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/mobilepp.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/people-picker-mobile-experience.gif
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-base-card.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-card-search.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-name-selected.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/Cards/peoplepicker-org-search.png
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/people-picker.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PR #3515 content is taken in PR #3785. Hence closing this PR.


Add backend for HTTP servers

The MJML team has released a HTTP API for integration with non NodeJS
apps at https://mjml.io/api.
I've built a self hosted alternative which should be compatible with the
API the MJML team has built (without baked in auth).
https://github.com/danihodovic/mjml-http-server
It should work with both auth and non-auth, although I have not tested
the auth version since https://mjml.io/api is currently invite only.

Thank you, @danihodovic, looks good! I'll check it a bit later as I am very busy these weeks.

@liminspace any chance of a review for this?

Yes, it looks great. I'm too busy now, but I'm going to do it as soon as I have free time.

Any free time lately? :smiley:
It would be great to install the master release directly from pip than installing my own branch from git.
Considering that this feature is opt-in it won't break any existing setups unless someone explicitly decides to use the HTTP server option.

Hi @danihodovic , your server returns 413 error if I try to send a big query. In unit-tests I use request body with size 22000347 bytes to check that server works correctly. Please, fix your library and I will support it. As variant you can add option --maxbody to set any size in bytes.

@danihodovic also your server uses twice quoting of result if json {"mjml": "..."} is sent. I can't release supporting your library until it's fixed. more details here https://travis-ci.org/liminspace/django-mjml/builds/623212728

You seem to have mjml compilation problems as far as I can see: https://travis-ci.org/liminspace/django-mjml/jobs/623212729#L271

Also regarding your changes in https://github.com/liminspace/django-mjml/tree/httpserver:
I don't think the client app should have logic for proxying to multiple HTTP servers. Reverse proxies such as Nginx or Apache are best suited to do this, not the Django application.

@danihodovic note, that I tested everything by using MJML Public API and all tests works correctly. try to post json {"mjml": "some mjml with unicode"} and you get result with twice quoting value. that is a problem.
if you post just "mjml", it works correctly.
it returns correct value:
            response = requests.post(
                url=server_conf['URL'],
                auth=auth,
                data=force_bytes(mjml_code),
                timeout=25,
            )

it returns double quoting value:
            response = requests.post(
                url=server_conf['URL'],
                auth=auth,
                data=force_bytes(json.dumps({'mjml': mjml_code})),
                headers={'Content-Type': 'application/json'},
                timeout=25,
            )

I need to support second variant as it's described in public API which must be supported at first: https://mjml.io/api/documentation/
multiple HTTP-servers are ok, as there can be a lot of servers to render in parallel (in different processes). if you don't need it, just set single one, I hope it's not a problem for you :)

Seems like the public API has changed and a json document is now passed as the payload.
Both interfaces should be supported with https://github.com/danihodovic/mjml-server/pull/56/files

@danihodovic now it works very well, thanks! when are you going to release new version of mjml-http-server? I need it released to run tests on travis and update the documentation.

0.0.3 has been released https://www.npmjs.com/package/mjml-http-server

the backend for HTTP servers will be released under v 0.9.0


feat: enable prerelease detection in goreleaser

This makes GoReleaser automatically detect prereleases based on the Git version tag.

with want to enable semver tag sorting as well
https://goreleaser.com/customization/git/#semver-sorting


Any good open source LLMs for zep's summarization?

This is not a feature/bug, just a question, since there is no discussion board I'll leave it here.
I have multiple hugging face models hosted and running OpenAI compatible endpoints.
After hooking them up to Zep, they continue to work, however the results were kind of disappointing for the models I have tried. They get stuck in the whole Led Zeppelin part of the default prompt template, the intention extraction starts spinning up weird things and gets stuck up on Nike.
Has anyone used any huggingface LLMs for this with any degree of success? If so, please provide name and template you used if you changed the default template.
PS: It would be nice to be able to change intent prompt template in order to make it match the prompting style of selected model. (Someone has raised this already)

We're in the middle of a significant rewrite of Zep's LLM use, with far more flexibility around the use of different models. This will be released towards the end of the quarter.

any news on this?

bump...

We've made significant changes to Zep's operation in the last week. Facts are now Zep's primary memory artifact, and summaries are no longer generated similarly. You may use any model with an OpenAI-compatible API. However, we recommend using OpenAI, Anthropic, or larger Llama 3 models.


Project pages tidying

Closes https://github.com/alan-turing-institute/DS4S-project-management/issues/85

[x] Closes #504
[x] Closes #503
[x] Closes #505


Iterate CircleCI cache

Description
After merging https://github.com/dockstore/dockstore/pull/5176, we were running into GitHub API rate limiting more often in CircleCI. I looked at the tmp/dockstore-web-cache.misses.log of CircleCI jobs after the merge and it looked like all of the GitHub API calls were cache misses. I'm not really sure what invalidated the cache in the PR.
I iterated the CircleCI cache by creating a new environment variable, DOCKSTORE_CACHE_VERSION, and setting the value to 2 (CACHE_SEGMENTED_VERSION is using 1). I confirmed by running the CircleCI job again after iterating the cache and verified that the cache for GitHub API calls was working. There are still some GitHub cache misses, but I checked with CircleCI jobs prior to the merge and this behaviour is normal.
This PR updates the CircleCI config to use the new environment variable so develop CircleCI jobs use the new cache. I didn't want to iterate the value of CACHE_SEGMENTED_VERSION because it would affect CircleCI jobs on the hotfix branch.
Issue
SEAB-4766
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

I confirmed by running the CircleCI job again after iterating the cache and verified that the cache for GitHub API calls was working. There are still some GitHub cache misses, but I checked with CircleCI jobs prior to the merge and this behaviour is normal.

:+1:


Add sleep timer

A sleeptimer would be a nice feature like in tvs, so you dont sleep away peacefully while a space documentary and wake up with WW2 and gunfire

A sleep timer woult be really really nice.
A slightly more sophisticated idea: stop playing shortly after the current broadcast finished. "Zapp" know when the current broadcast finishes because it always knows about the current name of the running broadcast, so shortly afer that changes, it might stop playing.

A sleep timer woult be really really nice.
A slightly more sophisticated idea: stop playing shortly after the current broadcast finished. "Zapp" know when the current broadcast finishes because it always knows about the current name of the running broadcast, so shortly afer that changes, it might stop playing.

I like the mentioned idea but it would be a good first step to introduce a "basic" timer as a base while we can discuss further improvements afterwards

Thanks to @Bnyro I implemented a timer inspired by Antenna Pod. It will be available in the next release.

This feature has been added in 8.3.0


Create tab group for - Open all tabs

Opening all tabs should be configurable to be in a tab group.

Done, released in version 0.5.0.


specifying working directory for execute_process in doctest_discover_tests

Description
quoting from https://github.com/catchorg/Catch2/pull/2039 :

In a CMake project, when using catch_discover_tests(WORKING_DIRECTORY [...]) it usually means that the test binary needs resources that are relative to said working directory. This could lead to UB or a crash when running --list-test-names-only or --list-reporters on the produced test binary i.e when a .dll is not lazy loaded and not available in the current PATH.
This commit simply forwards the WORKING_DIRECTORY argument to the execute_process() calls.
This also remove the need of using CMake's own magic with CMAKE_MSVCIDE_RUN_PATH and the like...

GitHub Issues
See https://github.com/catchorg/Catch2/pull/2039

For anyone reading this, here is how I use it:
octest_discover_tests(tests_exe WORKING_DIRECTORY $<TARGET_FILE_DIR:my_lib>)
Note that I am using generator expressions but multi config builds
I struggled with this a bit when using Visual Studio, but I think the generator expression is the correct usage

For anyone reading this, here is how I use it:
doctest_discover_tests(tests_exe WORKING_DIRECTORY $<TARGET_FILE_DIR:my_lib>)

This only works if you have a single shared library dependency. This is still not sufficient if you have multiple shared library dependencies in various locations.
You'd need to pass a list of paths to add to PATH in the doctest script before execute_process().

For anyone reading this, here is how I use it:
doctest_discover_tests(tests_exe WORKING_DIRECTORY $<TARGET_FILE_DIR:my_lib>)

This only works if you have a single shared library dependency. This is still not sufficient if you have multiple shared library dependencies in various locations.
You'd need to pass a list of paths to add to PATH in the doctest script before execute_process().

Sure you are right
However my usecase is only an example, I can imagine it also to be useful for other cases to specify the working dir
BTW do you know how to set the PATH with CMake? Is there a native/good solution for this? I couldn't find it

https://cmake.org/cmake/help/latest/command/set.html#set-environment-variable

@philbucher FYI, I have implemented this in my fork of utest.h and you can see it in action here.
If you want to later also make a PR for this, then this might be a good start for that.


[PORT] Align Banner with Design

Align Banners and its usages with design https://www.figma.com/file/dUYfx3uDfibWXjClY5NxNb/Portfolio-Components?type=design&node-id=3135%3A52121&mode=design&t=ZYXLuEdjIC1IFCVR-1

PR Merged https://github.com/consensys-vertical-apps/metamask-portfolio/pull/531


Add Draft RFC extension validation logic to Cert class

Starting work to implement the draft RFC features. Adds new extensions and
validation logic to Cert class to check compliance with RFC sections
2.3.3 and 2.3.4. Adds various test cases and the script that generates the
test certs.

I signed it!
On 31 July 2015 at 10:42, googlebot<EMAIL_ADDRESS>wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).
[image: :memo:] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If you signed the CLA as a corporation, please let us know the
company's name.

—
Reply to this email directly or view it on GitHub
https://github.com/google/certificate-transparency/pull/859#issuecomment-126625562
.

For the CLA, the problem is that the commits have Martin2112<EMAIL_ADDRESS>as the author... You need to use an email registered with the CLA (and if you use an @google.com email, the bot will figure it out automatically, no need to sign the CLA).
It's possible to amend the commit authors, while they're still in review. :wink:

Can you let me know how to change the email address on this? I can't see
where to do this.
Thanks,
Martin
On 31 July 2015 at 11:49, Pierre Phaneuf<EMAIL_ADDRESS>wrote:

For the CLA, the problem is that the commits have Martin2112 <
<EMAIL_ADDRESS>as the author... You need to use an
email registered with the CLA (and if you use an @google.com email, the
bot will figure it out automatically, no need to sign the CLA).
It's possible to amend the commit authors, while they're still in review. [image:
:wink:]
—
Reply to this email directly or view it on GitHub
https://github.com/google/certificate-transparency/pull/859#issuecomment-126648242
.

git commit --amend --author=xxx maybe?
On Fri, 31 Jul 2015 at 12:50 Martin2112<EMAIL_ADDRESS>wrote:

Can you let me know how to change the email address on this? I can't see
where to do this.
Thanks,
Martin
On 31 July 2015 at 11:49, Pierre Phaneuf<EMAIL_ADDRESS>wrote:

For the CLA, the problem is that the commits have Martin2112 <
<EMAIL_ADDRESS>as the author... You need to use an
email registered with the CLA (and if you use an @google.com email, the
bot will figure it out automatically, no need to sign the CLA).
It's possible to amend the commit authors, while they're still in
review. [image:
:wink:]
—
Reply to this email directly or view it on GitHub
<
https://github.com/google/certificate-transparency/pull/859#issuecomment-126648242
.

—
Reply to this email directly or view it on GitHub
https://github.com/google/certificate-transparency/pull/859#issuecomment-126665474
.

Ran a bit of Stylerator (tm)... :smiley:
It was confused by the OpenSSL STACK_OF macro, didn't recognize it as a type, hehe!

I think I've addressed all the issues on this now.

Ooops.

There's been a number of surrounding fixes to the code this touches, in other pull requests... Once you've address this last round of comments, maybe it'd be good to rebase it on top of the latest upstream/master, to give it a refresh?

I've broken out another helper method to split up the biggest one. I prefer not to do much more of this as it involves passing various bits dug out of the certs in both directions and could get ugly. I think I've addressed the other issues. PTAL.

Perhaps a bit late, but I was kinda hoping we'd do future shell-type tests in Python, its a whole lot more readable than shell...

This just creates the certs that the C++ tests use, same for the followup
CMS tests. Most people won't need to run these scripts.
Martin
On 26 August 2015 at 12:17, Ben Laurie<EMAIL_ADDRESS>wrote:

Perhaps a bit late, but I was kinda hoping we'd do future shell-type tests
in Python, its a whole lot more readable than shell...
—
Reply to this email directly or view it on GitHub
https://github.com/google/certificate-transparency/pull/859#issuecomment-134951130
.


Local pull request success status testing

Docs Build status updates of commit 74889d4:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 74889d4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[Enhancement] Git sha in application

system(command = 'powershell "docker build  --build-arg GIT_SHA=$(git rev-parse HEAD) -t inbo/alienspecies ."')

@TheJenne18 Could you please implement this change? If already done, sth still goes wrong as the env variable GIT_SHA doesn't get through in the app.


Suggestions for improving azure-core CMake files

I've been testing storage sdk on different platforms (Windows, Linux, macOS) and build as both dynamic and static libraries. I found some build errors and I've fixed some of them or opened GitHub issues (#1230, #1233, #1234). I also found some imperfect usages of CMake commands in core sdk CMake files, which can be improved. So I'd like to give some suggestions here so that you guys can consider.

core-sdk doesn't depend on nlohmann_json library. This will cause extra, useless library to be installed when customers just want to use azure-storage-blobs package via vcpkg. Because only DataLake service and File service depends on json. So I suggest we move json related stuff to storage sdk CMake files.

libcurl linkage should be PUBLIC. However it's defined PRIVATE now.

https://github.com/Azure/azure-sdk-for-cpp/blob/606dd98ea246cfd5631225463d94ac94b1e4c2e4/sdk/core/azure-core/CMakeLists.txt#L126
as Rick has suggested in this issue https://github.com/Azure/azure-sdk-for-cpp/issues/70, customers are supposed to include curl/curl.h and call curl init functions. That's also what you guys are doing in test code (https://github.com/Azure/azure-sdk-for-cpp/blob/master/sdk/core/azure-core/test/ut/main.cpp).

Unnecessary target_include_directories call. https://github.com/Azure/azure-sdk-for-cpp/blob/606dd98ea246cfd5631225463d94ac94b1e4c2e4/sdk/core/azure-core/CMakeLists.txt#L121

target_link_libraries will automatically populate the include directories for us. So these target_include_directories calls are redundant in most cases. Here is a very good post elaborating how target_link_libraries works.

Nit. https://github.com/Azure/azure-sdk-for-cpp/blob/606dd98ea246cfd5631225463d94ac94b1e4c2e4/sdk/core/azure-core/CMakeLists.txt#L130

Maybe it's better if we just write target_link_libraries(azure-core PRIVATE winhttp)? I don't see the benefits of defining a variable that's only used once.

core-sdk doesn't depend on nlohmann_json library. This will cause extra, useless library to be installed when customers just want to use azure-storage-blobs package via vcpkg. Because only DataLake service and File service depends on json. So I suggest we move json related stuff to storage sdk CMake files.

Maybe, but I suspect most folks won't be installing or using core-sdk on its own. And today, only Datalake and fileservice use it, but in the future, other service SDKs would want to leverage a JSON library as well. Theoretically, we could defer the move down to core to that point, but it is helpful to establish where key components come from. JSON serialization and processing is a fundamental part of most Azure SDKs and all other languages either expose that through Azure Core or rely on the language/underlying framework to provide such a library. Azure core will likely continue to grow with components or features that are more commonly used across multiple services (at least two), which means it might pull in dependencies that not all services use. The goal is to minimize external dependences though.

Nit. https://github.com/Azure/azure-sdk-for-cpp/blob/606dd98ea246cfd5631225463d94ac94b1e4c2e4/sdk/core/azure-core/CMakeLists.txt#L130

Maybe it's better if we just write target_link_libraries(azure-core PRIVATE winhttp)? I don't see the benefits of defining a variable that's only used once.

That nit makes sense. Agreed.

core-sdk doesn't depend on nlohmann_json library. This will cause extra, useless library to be installed when customers just want to use azure-storage-blobs package via vcpkg. Because only DataLake service and File service depends on json. So I suggest we move json related stuff to storage sdk CMake files.

Maybe, but I suspect most folks won't be installing or using core-sdk on its own. And today, only Datalake and fileservice use it, but in the future, other service SDKs would want to leverage a JSON library as well. Theoretically, we could defer the move down to core to that point, but it is helpful to establish where key components come from. JSON serialization and processing is a fundamental part of most Azure SDKs and all other languages either expose that through Azure Core or rely on the language/underlying framework to provide such a library. Azure core will likely continue to grow with components or features that are more commonly used across multiple services (at least two), which means it might pull in dependencies that not all services use. The goal is to minimize external dependences though.

Sure

Nit. https://github.com/Azure/azure-sdk-for-cpp/blob/606dd98ea246cfd5631225463d94ac94b1e4c2e4/sdk/core/azure-core/CMakeLists.txt#L130

Maybe it's better if we just write target_link_libraries(azure-core PRIVATE winhttp)? I don't see the benefits of defining a variable that's only used once.

That nit makes sense. Agreed

https://github.com/Azure/azure-sdk-for-cpp/pull/1240

I agree with these changes, especially the visibility of the curl dependency. As it currently is, the generated target file for azure-core is not relocatable since the curl include directories found during build are used to populate the target. Using only the CMake targets (as PUBLIC) would prevent that issue as well.

I agree with these changes, especially the visibility of the curl dependency. As it currently is, the generated target file for azure-core is not relocatable since the curl include directories found during build are used to populate the target. Using only the CMake targets (as PUBLIC) would prevent that issue as well.

As it currently is, the generated target file for azure-core is not relocatable since the curl include directories found during build are used to populate the target.

@sjoubert - in what scenario would you want  to relocate the generated target file for azure-core?

Using only the CMake targets (as PUBLIC) would prevent that issue as well.

Does that apply to both flavors of building the SDK and the consuming library - static and dynamic?

in what scenario would you want to relocate the generated target file for azure-core?

C runtime will do run-time relocation when running a executable linked against dynamic library. I guess this is what this customer is referring to

Does that apply to both flavors of building the SDK and the consuming library - static and dynamic?

I guess dynamic only.

The library is built once ,somewhere in a temporary install path with its dependencies resolved in non standard paths as well. Then I distribute the built and packaged library elsewhere.

Since curl, in some sense (http stack is replaceable), is an optional dependency, and since the end customer has to include the curl header and call curl global init and cleanup in their application code directly, wouldn't it be better for the consuming application to explicitly link curl themselves rather than relying on an indirect linking via azure core as their dependency?
The scenario you brought up is interesting and I hadn't thought about this separation previously. I will have to understand the relocation aspect a bit better myself to realize the implication. Do you have some resources or clear steps I can look up to try it myself locally and observe the issue by fleshing out the "build in a non standard path" and "distribute elsewhere" steps?

(relocatable in the sense they don't depend on the location they were produced or on the location they are placed)

Right, that is important. Is it the consuming application being built once which is linking the SDK, or just the SDK? It would be helpful to me to understand the relationship between the consuming application and SDK/other library dependency, while building the different components.