Reolink does not display after upgrading to HA core 2021.3.1

Describe the bug
I upgraded from HA core 2021.2.3 to 2021.3.1 and now there is no image in the picture glance card in lovelace. There is a message where the image should be that states "Preview of the Front Door camera." When looking in configuration > integrations, the Reolink integration shows the camera as being unavailable.
To Reproduce
I restored a snapshot and went back to HA core 2021.2.3 and the image was there. Everything was working properly. I upgraded back to HA core 2021.3.1 and the camera did not work again.
Expected behavior
There should be an image of what the camera sees in the picture glance card.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:
HA is installed in VirtualBox on Windows 10
Please provide useful information about your environment, like:

Home Assistant version: 2021.3.1
Reolink camera model: RLC-420-5MP
Camera firmware number: v<IP_ADDRESS>8_19061408

Additional context
I have 2 error messages in my logs.
`Logger: homeassistant.config_entries
Source: helpers/network.py:124
First occurred: 3:39:00 PM (1 occurrences)
Last logged: 3:39:00 PM
Error setting up entry Front Door for reolink_dev
Traceback (most recent call last):
File "/config/custom_components/reolink_dev/init.py", line 72, in async_setup_entry
push = hass.data[DOMAIN][base.push_manager]
KeyError: 'push_manager-EC71DB57BF22'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 248, in async_setup
result = await component.async_setup_entry(hass, self)  # type: ignore
File "/config/custom_components/reolink_dev/init.py", line 75, in async_setup_entry
await push.subscribe(base.event_id)
File "/config/custom_components/reolink_dev/base.py", line 208, in subscribe
get_url(self._hass, prefer_external=False),
File "/usr/src/homeassistant/homeassistant/helpers/network.py", line 84, in get_url
request_host = _get_request_host()
File "/usr/src/homeassistant/homeassistant/helpers/network.py", line 124, in _get_request_host
raise NoURLAvailableError
homeassistant.helpers.network.NoURLAvailableError
`
and this one.
`Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/connection.py:84
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 3:39:15 PM (5 occurrences)
Last logged: 3:48:03 PM
[140340687682768] Received invalid command: camera/stream
[140340669782000] Received invalid command: camera/stream
[140340666917696] Received invalid command: camera/stream
`

I tried uninstalled/reinstalled but it did not work. After you install the repository in HACS and reboot, I get the following error message in the logs.
`Logger: homeassistant.loader
Source: loader.py:802
First occurred: 9:26:38 PM (1 occurrences)
Last logged: 9:26:38 PM
No 'version' key in the manifest file for custom integration 'reolink_dev'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'reolink_dev'`
Then when I install the Reolink integration and reboot, I get the same error message as above.

The underlying error is NoURLAvailableError which sounds like either the hostname/ip you are providing is incorrect or that your camera is not resolvable from Home Assistant. If you can get shell access to your HA install, can you ping the camera with the info you are providing the integration?
I ask because I have stepped from 2021.2.3 through to 2021.3.2 and my three cameras(511, 510, and 520) work fine in each one, but I have had problems in the past between versions with name resolution.

I have the same issue after upgrading from 2021.2.3 to 2021.3.2. After deleting the integration and installing again, no device and entities are created.

If I rollback to 2021.2.3 the integration works OK.

Can you do a terminal connection and ping the hostname/ip in both versions? The error reported is noURLAvailableError which means the URL that it is trying to connect to cannot resolve. This is usually a name resolution error, which, if you are using HASSOS or the containerized versions of HA, can change from version to version.
An additional thing to try is to add debugging. If you add/change in your configuration.yaml:
logger:
  logs:
    custom_components.reolink_dev: debug
    reolink: debug

then in your working version note what hostname/ip it reports talking to and then in 2021.3.2 see what it attempts to talk to.

I am able to ping the camera's IP (<IP_ADDRESS>) in both versions.
I set debug on both versions and restarted. I have attached both logs.
home-assistant-core-2021.3.1.log
home-assistant-core-2021.2.3.log

Ok, I dug into this further and I traced it to a particular point, but I cannot determine why it is failing, I also cannot reproduce this in my dev environment with the current 4.0dev or the 3.1 you are using. The failure is occurring in the get_url function provided by HA, and according to the dev docs, it means that the install cannot generate a url with the needed requirements (in this case, prefer_external is false).
I do see that the smartthings integration has a similar issue logged in the core github, with no resolution other than to roll back. I also found a issue/conversion about Google Nest having an issue when the site is behind a proxy, though this is for an older version, and the discussion was about the error message not the get_url method.
As to what could have changed between 2.x and 3.x that would cause get_url to not be able to generate a url on your setup, is unfortunately, beyond what I have experience with. The only other thing I can think of is, do you have anything in your config that limits/removes the internal url?

I just update to the latest core also, but my integration is still running fine. Please go to Settings->general->Internal url. What address is filled in?

Thank you both for your help with this. There is nothing listed in Configuration->general->Internal url in both versions.

There is nothing inside the my config that has to do with an internal url. Here is my config.
homeassistant:
  packages: !include_dir_named packages

# Configure a default setup of Home Assistant (frontend, api, etc)
default_config:

logger:
  logs:
    custom_components.reolink_dev: debug
    reolink: debug

frontend:
  themes: !include_dir_merge_named themes

# DuckDNS
http:
  ssl_certificate: /ssl/fullchain.pem
  ssl_key: /ssl/privkey.pem

# Text to speech
tts:
  - platform: google_translate

group: !include groups.yaml
automation: !include automations.yaml
script: !include scripts.yaml
scene: !include scenes.yaml
light: !include lights.yaml

switch:
  - platform: template
    switches:
      digital_f:
        friendly_name: "Digital F"
        value_template: "{{ is_state('switch.picture_frame', 'on') }}"
        turn_on:
          service: switch.turn_on
          target:
            entity_id: switch.frame
        turn_off:
          service: switch.turn_off
          target:
            entity_id: switch.frame

What happens if you disable the DuckDNS integration and comment out the http: section? I wonder if in 3.x it is forcing an external only url.

Yes, commenting out the http section and turning off DuckDNS did allow the camera to work in 2021.3.1. How do I get them both to work at the same time?

Eureka! I figured it out, or at least the cause...
Re-reading the docs for get url I noticed this line for the "default" behavior:

Get an internal URL set by the user, or if not available, try to detect one from the network interface (based on http settings).

and I saw that you had an http section, so I gen'd a cert and setup https and now I can reproduce the error, so I believe that in 3.0 they changed something that throws with this configuration. I don't know a fix for the http setup but a workaround would be to use a ssl/proxy addon so HA can be unencrypted on 8123 but provide SSL over another port, or at least externally to the host on 8123.

I found a couple of issues in core that could be related so I linked them, this way it may draw some attention to this issue and get it solved faster, but as of right now it looks like a HA bug and not anything that can be done on this end.

yeah this seems to be the same issue as mine under #47569.
I do have an internal http url setup, as well as an external one in the config.

I have faced this issue as well, and @xannor actualy point me to direction to resolve it.
The HA team depcate base_url in http component, and if you are using duckdns.org you have to change your configuration slighty to someting likt that:
configuration.yaml
homeassistant:
  customize: !include customize.yaml
  internal_url: http://internal_address:8123
  external_url: https://duck_dns_alias.duckdns.org

Installing the NGINX add-on did work. I am able to view the camera and access HA remotely. I tried as @pniewiadowski suggested but I must have not had something quite right.

@Amishman import thing I forgot to add is to remove/comment line with base_url in your configuration.yaml

@pniewiadowski Your solution worked for me. Thanks!
Added this to my configuration.yaml:
homeassistant:
customize: !include customize.yaml
internal_url: https://internal_address:8123
external_url: https://duck_dns_alias.duckdns.org

@pniewiadowski another vote that fixed my problem!


requirements for webinstall ubuntu 14.04 (grpahViz, cuDNN)

I have been working through a successful web-install on clean ubuntu 14.04
The requirements only stated to have driver 346 - so I haven't downloaded cuDNN or graphviz
When I attempt to visualize a network (visualize button ) when building a model

I return this error

Do i need to get graphviz and cuDNN on my own?
Thanks and my apologies if this is the wrong place for this question.  Great work

I am getting same warning.

Ah, it looks like we left out a line in the "one_time.sh" script. I'll make sure that's fixed for the next packaged version. Thanks for reporting it!
For now, if you want to use the visualization tool, you can manually run this command:
sudo apt-get install graphviz


Comparing LineSegment to a real number - Lecture 5 (The Triangle Class Implementation)

Hello there,
I believe there is a logical bug in the test cell of The Triangle class Implementation:

A closer look at the assertions hints that it was intended to check against the length of the line segment.
Best regards,
Simranjeet

Hi @esemsc-d888db94, thank you for your message. What is the value of t.edges() you compute?

Thank you for your response!
As was given in the specification, t.edges() returns a tuple containing the three LineSegments:

Hi @esemsc-d888db94, thank you for the clarification. I meant, what is the value you are calculating?
If you draw a triangle with those points, you will see that the edge lengths should be 1, 1, and sqrt(2). The tests are testing for that.

Hi @esemsc-d888db94, thank you for the clarification. I meant, what is the value you are calculating?
If you draw a triangle with those points, you will see that the edge lengths should be 1, 1, and sqrt(2). The tests are testing for that.

Hi @marijanbeg ,
The image I pasted above is indeed what I calculate.
t.edges()[0] is LineSegment(Point(x=0, y=0), Point(x=1, y=0))
and not any numeric value.
But now I see that it expects us to return the lengths of the LineSegments instead of the objects. From the instructions I was rather convinced that it was the latter.
I will change the code to return the lengths.
Thank you for the help!
Best,
Simranjeet

Thank you for the update. I will close the issue now.


Can't Build On OCaml 4.02.1

I am getting an error when building on OCaml 4.02.1:
*** omake: reading OMakefiles
--- Checking for ocamlfind... (found /root/.opam/4.02.1/bin/ocamlfind)
--- Checking for ocamlc.opt... (found /root/.opam/4.02.1/bin/ocamlc.opt)
--- Checking for ocamlopt.opt... (found /root/.opam/4.02.1/bin/ocamlopt.opt)
--- Checking whether ocamlc understands the "z" warnings... (yes)
*** omake: finished reading OMakefiles (0.06 sec)
--- Checking if ocamldep understands -modules... (yes)
- build . mq_rabbitmq.cmo
+ ocamlfind ocamlc -package lwt,lwt.unix,extlib,cryptokit,threads -g -thread -bin-annot -w +a-4-6-9-27..29-32..99 -warn-error +a-4-6-7-9-18-27..29-32..99 -g -dtypes -I . -c mq_rabbitmq.ml
File "mq_rabbitmq.ml", line 13, characters 12-25:
Warning 3: deprecated: String.create====                       ] 00047 / 00073
Use Bytes.create instead.
File "mq_rabbitmq.ml", line 25, characters 8-42:
Warning 3: deprecated: String.set
Use Bytes.set instead.
File "mq_rabbitmq.ml", line 1:
Error: Some fatal warnings were triggered (2 occurrences)
*** omake: 47/73 targets are up to date
*** omake: failed (1.08 sec, 13/13 scans, 6/11 rules, 32/121 digests)
*** omake: targets were not rebuilt because of errors:
   mq_rabbitmq.cmo
      depends on: mq_rabbitmq.ml

Please advise.

On Tue, Feb 17, 2015 at 01:39:10PM -0800, Fernando Ribeiro wrote:

I am getting an error when building on OCaml 4.02.1:
`*** omake: reading OMakefiles
--- Checking for ocamlfind... (found /root/.opam/4.02.1/bin/ocamlfind)
--- Checking for ocamlc.opt... (found /root/.opam/4.02.1/bin/ocamlc.opt)
--- Checking for ocamlopt.opt... (found /root/.opam/4.02.1/bin/ocamlopt.opt)
--- Checking whether ocamlc understands the "z" warnings... (yes)
*** omake: finished reading OMakefiles (0.06 sec)
--- Checking if ocamldep understands -modules... (yes)

build . mq_rabbitmq.cmo

ocamlfind ocamlc -package lwt,lwt.unix,extlib,cryptokit,threads -g -thread -bin-annot -w +a-4-6-9-27..29-32..99 -warn-error +a-4-6-7-9-18-27..29-32..99 -g -dtypes -I . -c mq_rabbitmq.ml
File "mq_rabbitmq.ml", line 13, characters 12-25:
Warning 3: deprecated: String.create====                       ] 00047 / 00073
Use Bytes.create instead.
File "mq_rabbitmq.ml", line 25, characters 8-42:
Warning 3: deprecated: String.set
Use Bytes.set instead.
File "mq_rabbitmq.ml", line 1:
Error: Some fatal warnings were triggered (2 occurrences)
*** omake: 47/73 targets are up to date
*** omake: failed (1.08 sec, 13/13 scans, 6/11 rules, 32/121 digests)
*** omake: targets were not rebuilt because of errors:
mq_rabbitmq.cmo
depends on: mq_rabbitmq.ml`

Please advise.

I cannot test it right now, but could you change line 8 in the OMakefile to
OCAMLFLAGS    = -g -thread -bin-annot -w +a-4-6-9-27..29-32..99 -warn-error +a-3-4-6-7-9-18-27..29-32..99
                                                                            =====

?
Will try to address this properly (i.e., by switching to Bytes) when I have
the time.
--
Mauricio Fern�ndez

That did the trick, thanks!


[Wallet] Don't ask to reverify if EOA or MTW is already verified

Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues

Fixes #[issue number here]

Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.

Superseded by #5889


fix: integration with Apache Beam 2.32, 2.33 reported in #1231

@AbhiPrasad I think failing tests are unrelated because they are failing on Sanic.
I believe this failing change is tracked here:
https://github.com/sanic-org/sanic/issues/2250

Yup unrelated test failures, we will merge regardless.

@AbhiPrasad I think failing tests are unrelated because they are failing on Sanic.
I believe this failing change is tracked here: sanic-org/sanic#2250

If the tests are failing on Sanic's behalf related to that issue, then I am assuming it must be installing latest version which requires this to be merged: https://github.com/getsentry/sentry-python/pull/1212


Bump-build

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11408861584.

Hi @corneliusroemer -- thank you for the cleanup.  Can you tell me a little about what the changes achieve?  Thanks!

This is just standard conda-forge build system updated. It's all automated, but I had to bump the build number so needed to make a PR from fork.

Close in favor of #307


Add .github workflows. Remove vendoring from test-runners

Added a .github/workflow to test against OSP Director Operator. This should prevent us committing broken stuff here.
This also updates most of the test runners to remove vendoring which caused failures with golang 1.18.

I run make golint with this change locally against the placement-operator and it works properly
/lgtm

All tests pass. Thanks guys. Going to merge it


Bump Antlr patch version

The previous patch version erroneously emitted a bunch of warnings about a version mismatch. Using this patch version fixes that.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 93.459%

Files with Coverage Reduction
New Missed Lines
%

modelica_builder/modelica_mos_file.py
7
89.16%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.03%

Covered Lines:
1886

Relevant Lines:
2018

💛  - Coveralls


Concatenating variables containing bytes should yield bytes

When joining bytes with ${x}${y} string is returned instead of bytes.
consider following test case:
*** Test Cases ***
Join bytes
    ${destination} =    Convert To Bytes    FF FF FF FF FF FF    hex
    ${source} =         Convert To Bytes    00 80 E1 00 00 00    hex
    ${data} =           Convert To Bytes    00 01 08 00 06 04 00 01     hex

    ${frame} =   Set Variable    ${destination}${source}${data}

currently results in ${frame} -> '\\xff\\xff\\xff\\xff\\xff\\xff\x00\\x80\\xe1\x00\x00\x00\x00\x01\x08\x00\x06\x04\x00\x01'
expected result is bytes

I agree ${x}${y} should yield bytes, not a string, if both variables are bytes. This makes working with bytes simpler and is also pretty easy to implement.
This is related to #5052 that reports a very strange string representation that bytes have. That strange representation is actually seen also in the description where some bytes in the example result are shown like \x00 and others like \\x80. I'll explain why in the aforementioned issue.

This change isn't backwards compatible, because the value keywords get if they are passed an argument like ${x}${y} and all variables contain bytes changes. I don't expect this to cause problems in practice because:

Such keywords anyway get bytes if variables are used on their own like ${x}. They should thus handle bytes just fine.
The current string representation you get is in practice unusable. See #5052 for more details.


Code 38: Each session should contain the same number of files with the same naming scheme.

When I run the BIDS validator on some data with multiple visits I get the following error:

3: Not all sessions contain the same corresponding files. Each session should contain the same number of > files with the same naming scheme. (code: 38)

This is then followed by many, many lines stating that a number of files should exist according to the validator, but don't. The problem I'm having is that in our study, for some visits/sessions some acquisitions are acquired that aren't acquired for other visits/sessions, so pretty much all of these hypothetical missing files are for acquisitions that wouldn't be taken in a given visit.  Is this something that BIDS mandates or is this more meant as a warning for studies where multiple sessions should have the same number/type of acquisitions?

It is true that most longitudinal studies have similar or the same set of scans for each session, but this test/warning was originally supposed to look at each session separately and find missing files across subjects (see #56). This was implemented in this PR #97, but maybe something got lost in translation. @rwblair could you have a look?

@jpellman Can you post some of the output that you're get so I can get an idea of the naming scheme?
I'll go over the session validator code this weekend to make sure it matches up with the original issue.

I think it actually does function as expected- sorry for the noise.
What I think threw me off is that files in the derivatives folder are displayed as though they were in the main folder, which caused me to think that other acquisitions that didn't belong in the non-derivatives session folder were being displayed as well.
For instance:

Not all sessions contain the same corresponding files. Each session should contain the same number of files with the same naming scheme.
Evidence: Subject: sub-M10957251; Missing file: /ses-DSA/func/sub-M10957251_ses-DSA_task-rest_acq-CAP_recording-despiked_physio.tsv.gz

Would actually be missing in /derivatives/sub-M10957251/ses-DSA/func/sub-M10957251_ses-DSA_task-rest_acq-CAP_recording-despiked_physio.tsv.gz rather than sub-M10957251/ses-DSA/func/sub-M10957251_ses-DSA_task-rest_acq-CAP_recording-despiked_physio.tsv.gz.

This does not look like desired behavior. Derivatives should be ignored.
On Mar 25, 2016 5:45 PM, "John Pellman"<EMAIL_ADDRESS>wrote:

I think it actually does function as expected- sorry for the noise.
What I think threw me off is that files in the derivatives folder are
displayed as though they were in the main folder, which caused me to think
that other acquisitions that didn't belong in the non-derivatives session
folder were being displayed as well.
For instance:
Not all sessions contain the same corresponding files. Each session should
contain the same number of files with the same naming scheme.
Evidence: Subject: sub-M10957251; Missing file:
/ses-DSA/func/sub-M10957251_ses-DSA_task-rest_acq-CAP_recording-despiked_physio.tsv.gz
Would actually be missing in
/derivatives/sub-M10957251/ses-DSA/func/sub-M10957251_ses-DSA_task-rest_acq-CAP_recording-despiked_physio.tsv.gz
rather than
sub-M10957251/ses-DSA/func/sub-M10957251_ses-DSA_task-rest_acq-CAP_recording-despiked_physio.tsv.gz
.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/INCF/bids-validator/issues/116#issuecomment-201621510


Fix/angle snapping fix

A nicer implementation of angle snapping

I think it's just "different bad" - if you'd tried to use the previous implementation in any depth you would have found other serious problems. I hadn't tried rotating at the poles however. I'll take a look.

I think it's just "different bad" - if you'd tried to use the previous implementation in any depth you would have found other serious problems. I hadn't tried rotating at the poles however. I'll take a look.

Actually - now I've tried it, I can confirm there's something weird going on aside from behaviour at the poles.
Investigating.

@moatdd - any thoughts?


[Bug]: Wrong flag path

What happened?
With theme-orange v3.2.3 on TI v3.7.6. This theme was installed via /admin/themes, search marketplace.
Flags are not displayed on checkout (for phone number).
Because the URL provided is not correct, error 404.
GET themes/tastyigniter-orange/assets/src/scss/images/intlTelInput/flags.png
But the correct address is : themes/tastyigniter-orange/assets/images/intlTelInput/flags.png
Not sure where the problem lies exactly, in this theme, or in TI engine.
Here this looks correct, but something messing it up.
On /checkout page, a CSS file is provided by the server, and it gives
.iti__flag {
  height: 15px;
  box-shadow: 0 0 1px 0 #888;
  background-image: url(../themes/tastyigniter-orange/assets/src/img/flags.png);
  background-repeat: no-repeat;
  background-color: #dbdbdb;
  background-position: 20px 0;
}
@media (-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi) {
  .iti__flag {
    background-image: url(../themes/tastyigniter-orange/assets/src/img/flags@2x.png);
  }
}
.iti__flag.iti__np {
  background-color: transparent;
}
.iti__flag {
  background-image: url("../themes/tastyigniter-orange/assets/src/scss/images/intlTelInput/flags.png");
}
@media (-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi) {
  .iti__flag {
    background-image: url("../themes/tastyigniter-orange/assets/src/scss/images/intlTelInput/flags@2x.png");
  }
}

The iti__flag class background-image is overridden (provided twice), providing 2 different URLs for flags. None of these URLs are correct, the correct one is /themes/tastyigniter-orange/assets/images/intlTelInput/flags.png
What did you expect to happen?
The browser should find the flag image, meaning the server provides the right URL.
Version
3.x
What browser are you seeing the problem on?
Firefox, Microsoft Edge
Relevant log output
No response

Some other details, those may be relevant.

TI was installed with composer/artisan (not by the wizard)
Server runs Nginx v1.22.1, PHP 8.2, MariaDB 10.11.6

That works well by using the wizard installer, i.e. the flag path is OK. So I guess this comes from the artisan script which doesn't generate the right CSS (call scss?).

OK so finally that looks like this is the GDPR banner feature that broke that thing. Once the GDPR banner is disabled, the flag disappear permanently (even if GDPR banner is re-activated).

Also changing a color in the theme edition (colors tab) triggers this issue. Many changes in the theme option look to break the flag path.


Update code as per ain's version 3 milestone update

What would you like to be added:
There are quite a lot of code changes on ain's version 3 milestone update. On jellyfish side, we need to update the code to
a) Fix failed tests
b) Add updatemasternode RPC and DFTX
c) Improve the tests accordingly
after connecting to the new code.
Why is this needed:
To comply with the new code on ain's side.

My strategy to fix this would be
-> Merge 1429 to main
-> Merge 1430 to main


Add data for focusin & focusout events

Fixes #2199
Testcase: http://output.jsbin.com/bimiso
IE<9 data from http://www.quirksmode.org/dom/events/blurfocus.html#t06

@Fyrd Data review seems completed?

Yup.


Positioning popovers relative to a virtual element (support right-click context menus)

Provide a general summary of the feature here
Hey folks, I wanted to gauge interest in having first class support in react-aria / react-aria-components for patterns like right click context menus.
Perhaps this should only be supported for menus, in that case it could perhaps be supported via a new trigger-type
<MenuTrigger trigger="contextmenu">

🤔 Expected Behavior?
The first child of MenuTrigger could be any element that receives a onContextMenu prop to trigger it's menu on 'contextmenu' events.
There is probably a way to describe this functionality more accurately in the lower layers of react-aria and react-stately but I'm fairly new to this library and not familiar enough with the architecture :smi
😯 Current Behavior
Currently right click menus can be implemented by replacing the trigger ref with a {getBoundingClientRect: () => DOMRect } type and continuously updating the position of that DOMRect based on the mouse click coordinates. See code sandbox below
💁 Possible Solution
I don't want to speculate too much on the details of how the API should be structured since I've not spent enough time thinking about it. But one way would be
<MenuTrigger trigger="contextmenu">
  {/* The component that gets onContextMenu handler.
        Does not need to be interactive. */}
  <Box />
  {/* The menu to pop up */}
  <MyMenu />
</MenuTrigger>

🔦 Context
The usecase is to implement UIs similar to the native MacOS context menus

or figmas context menus

See floating-ui docs about virtual elements https://floating-ui.com/docs/virtual-elements
💻 Examples
They can be implemented with some effort since react-aria is so incredibly flexible (love that).
See code sandbox
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

I don't think we have a big interest in supporting context menus. Mostly because they are only for mouse users and are frequently (not on purpose though) used without other input methods being considered.
It's a bit of a slippery slope argument though, so I won't say never. Only that it's not a priority.

That's fair. It's possible albeit a bit awkward to do context menus today. Feel free to close this issue 👍

FWIW, this could be made easier to do, but it is possible to implement today using the offset and crossOffset props props on Popover. Basically force the placement to always bottom left, and then adjust the offset relative to that.
https://stackblitz.com/edit/rac-context-menu?file=src%2FApp.tsx


Add support for Azure CDN

Pricing: https://azure.microsoft.com/en-us/pricing/details/cdn/
Terraform resources: azurerm_cdn_profile and azurerm_cdn_endpoint

Terraform resource azurerm_cdn_endpoint should have

A monthly_outbound_gb usage parameter displayed as Outbound data transfer (<type>, <tier>) with unit GB where type is determined by the azure_cdn_profile.sku (e.g. 'Standard Microsoft', 'Standard Akamai',...) and tier is the pricing tier (e.g. 'first 10 TB', 'next 40 TB', etc...).  When the usage key is not provided, all tiers should be displayed.  When it is provided, only the tiers with a charge should be displayed.
Rules engine rule (over 5) with the count determined by the total number of global_delivery_rule + delivery_rule blocks in the endpoint.
A monthly_rules_engine_requests usage parameter displayed as Rules engine requests unit 1M requests.  This should only appear if at least one global_delivery_rule or delivery_rule block has been defined.
When the endpoint has optimization_type == DynamicSiteAcceleration, monthly_outbound_gb should be used to diaply Acceleration outbound data transfer (<tier>) with unit GB  and tier is the pricing tier.  Again, when the usage key is not provided, all tiers should be displayed.  Otherwise, only the tiers with a charge should be displayed.

@alikhajeh1, Hey, I want to work on it!


retry mqtt stream test that fails a lot

this line times out 50% of the time in our CI runs - eg https://github.com/apache/incubator-pekko-connectors/actions/runs/5561095341/jobs/10158693141#step:5:674
see https://github.com/apache/incubator-pekko-connectors/issues/148

I am pretty sure have already increase the timeout for this test and it didn't appear to make an ultimate impact, I think the flakiness is elsewhere.

I think the test case is actually broken - that it's not a time out issue. With the eventually, the test is at least retried. That is not the ultimate solution but the problem is that until we fix this test, it is causing so many build failures - we need to either set the test to be ignored or retry the test with an eventually until someone has time to fix it altogether.

@nvollmar @mdedetrich @kerr - could we consider merging this as short term solution to all the broken builds?

@nvollmar @mdedetrich @kerr - could we consider merging this as short term solution to all the broken builds?

I didn't have a look at the PR because to me it seemed like it was overengineered and that maybe the best solution would be to use something like scalatest's https://www.scalatest.org/scaladoc/3.0.8/org/scalatest/Retries.html ?
If we are not solving the core issue behind way the test is flaky I have a preference for using techniques such as ScalaTest 'Retries`, or put differently I have an aversion to modifying a test a lot unless its actually solving the core problem.

I didn't have a look at the PR because to me it seemed like it was overengineered and that maybe the best solution would be to use something like scalatest's https://www.scalatest.org/scaladoc/3.0.8/org/scalatest/Retries.html ?
If we are not solving the core issue behind way the test is flaky I have a preference for using techniques such as ScalaTest Retries, or put differently I have an aversion to modifying a test a lot unless its actually solving the core problem.

The change here is not very big - the main cause of the diff is the eventually block indents the code inside the block

In cases where we anyway just retrigger the failed test runs it makes sense as long as there is an open issue and have a link to it to eventually address this. There is also a flaky test in the persistence cassandra project I've yet failed to find the root cause that it would make sense to apply this.


Rewrite readme in ngx-oauth2-access-token

https://github.com/mrpachara/ngx/pull/4#issuecomment-1563575462 when finish

Done https://github.com/mrpachara/ngx/pull/4/commits/9a302e9ccf38a99ad73539580f2ca858131789ed .


Flickering while loading lines

When used on a file with many lines there is flickering while the lines load until it is fully loaded

Thank you for the issue.
This issue requires environmental information.
Please tell me the OS and terminal emulator software.
I think that depending on the environment, the combination of tcell
and terminal emulator software may cause the entire page to be redisplayed
without being able to change just a part of it.

This occurs on a Windows 10 host + Ubuntu on WSL + Windows Terminal

Do you have access to a similar setup @noborus? Any more information you'd need?

Thank you for information.
I tried.
Flickering occurred in Windows Terminal v1.17.11461.0.
Flickering did not occur in Windows Terminal v1.18.2681.0.
Using the latest version seems to resolve it.
Support for devices that do not support some rewriting will be considered separately.
thank you very much.

Thanks @noborus!


Import galacticus subhalos example

Implements the following changes

Added example_notebooks/from_galacticus.ipynb
Added an id property to track galacticus subhalos

@cgannonucm could you please add test functions for the classes and methods you created? You can have a look at the test suites in pyHalo located in pyhalo/tests

@cgannonucm I think the tests are failing because the syntax you used to merge dictionaries isn't supported in python 3.8

@cgannonucm ok everything looks great! Do you need to make any changes to the example notebook so that it is compatible with the latest changes? If not, then I'll go ahead and merge this

The notebooks should be good to go! I would like to push one more commit, before we merge. I am going to add the parameter file used to generate the output file.

@dangilman Everything should be good to go after tests finish up.


Added prometheus integration

Added prometheus client
Added scheduler for compute current spool metrics and info
Default endpoint host:port/metrics/

Good idea!

You've updated all dependencies for the project, which could have unforeseen consequences, and is outside the scope of this PR. Please only add the prometheus dependencies and don't touch the others.
I think this should be an opt-in thing behind an environment variable, since not many people will use it and it would just sit every minute consuming resources for no reason.
It seems it only works if the path is /metrics/ but not for /metrics, think you could fix that?
Please install Black to format the files correctly.

Just chiming in that i'd highly appreciate this, as i use Prom/Grafana heavily to monitor my printers - and being able to integrate the filament usage would be awesome!

Remove this 2nd logger line, not useful.

Done

This will now only get run if automatic backups are enabled and the database is a sqlite one, which is irrelevant of metrics collection.

Run with SPOOLMAN_METRICS_ENABLED=TRUE env variable only

These two logger lines serve better as "debug" level and not info level.

Set debug level

Change this to async for session in get_db_session(): and you don't need to create your own get_session function.

Done

Must handle price potentially being None
Must handle row.vendor.name and row.weight potentially being None

Handles added, may be need moved to models, but i made it at metrics.py

Good idea!

You've updated all dependencies for the project, which could have unforeseen consequences, and is outside the scope of this PR. Please only add the prometheus dependencies and don't touch the others.
I think this should be an opt-in thing behind an environment variable, since not many people will use it and it would just sit every minute consuming resources for no reason.
It seems it only works if the path is /metrics/ but not for /metrics, think you could fix that?
Please install Black to format the files correctly.

I am used last pdm, and it change format of lockfile. Indicated pdm version at README.
Added SPOOLMAN_METRICS_ENABLED, default FALSE. But you can add some application metrics by functions, if needed.
Change url, with some WA.
Installed and formated.

PPS: Unfortunately i'm not true developer (python and other languages). Thanks for understanding.

Great updates! All items resolved. Thanks for the contribution :)


Update install-the-tools.md

Updated Vuforia Version information to latest version. It was outdated by far.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/install-the-tools.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks @rhawa!


Parameters throws null ref exception when trying to migrate AMS video that has a secondary audio in it

This is happening because in ShakaPackager.cs Ln 131 we have
var source = t.Parameters.SingleOrDefault(p => p.Name == TRANSCRIPT_SOURCE)?.Value ?? t.Source;
When trying to migrate a video from AMS to a storage account, if the video has a secondary audio in it, then there are tracks that are being sent to this line. 1 video track and 2 audio tracks. While the audio tracks have Parameters populated, the video track does not.
So, the solution should be to add null handling here, thus change
FROM : var source = t.Parameters.SingleOrDefault(p => p.Name == TRANSCRIPT_SOURCE)?.Value ?? t.Source;
TO: var source = t.Parameters**?**.SingleOrDefault(p => p.Name == TRANSCRIPT_SOURCE)?.Value ?? t.Source;
I tried to send a PR with this fix, but I keep getting a 403. Please advise.
Stack trace -
2023-11-15 14:29:05.598 -08:00 [INF] Begin migration of assets for account: ampinfrawestuscivideo
2023-11-15 14:29:11.714 -08:00 [INF] The total asset count of the media account is 0.
2023-11-15 14:29:19.417 -08:00 [INF] The total assets to handle in this run is 2.
2023-11-15 14:29:28.660 -08:00 [INF] Migrating asset: amp:AA1uLYK:1001:9b94d366-1c49-4a2f-86af-37bb3f385fe5 (container asset-7757f8d7-7671-40f9-9d72-89fe04c56d14) ...
2023-11-15 14:29:28.660 -08:00 [INF] Migrating asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 (container asset-a330595d-1ef7-4cf7-bfbf-6951f9ce49c0) ...
2023-11-15 14:29:29.651 -08:00 [INF] Asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 has 7 blobs and content: 27dcfdca-a90b-4c27-9481-b093352a.ism
2023-11-15 14:29:29.651 -08:00 [INF] Asset: amp:AA1uLYK:1001:9b94d366-1c49-4a2f-86af-37bb3f385fe5 has 1 blobs and content: 27dcfdca-a90b-4c27-9481-b093352a31e3.mp4
2023-11-15 14:29:32.534 -08:00 [INF] Asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 has 7 blobs and content: 27dcfdca-a90b-4c27-9481-b093352a_650.mp4
2023-11-15 14:29:32.636 -08:00 [INF] Asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 has 7 blobs and content: 27dcfdca-a90b-4c27-9481-b093352a_650_1.mpi
2023-11-15 14:29:32.735 -08:00 [INF] Asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 has 7 blobs and content: 27dcfdca-a90b-4c27-9481-b093352a_650_2.mpi
2023-11-15 14:29:32.829 -08:00 [INF] Asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 has 7 blobs and content: 27dcfdca-a90b-4c27-9481-b093352a_manifest.json
2023-11-15 14:29:32.902 -08:00 [INF] Streaming locator name and locator Id is: f5efa6d4-6efa-4eb7-ba65-dd3ba3da3810
2023-11-15 14:29:32.952 -08:00 [INF] Asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 has 7 blobs and content: e39e593a-0d00-8176-b850-f1ee83f44339_metadata.json
2023-11-15 14:29:33.075 -08:00 [INF] Asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 has 7 blobs and content: en-usa9f283b0-645e-48ab-a524-a40d6a79.mp4
2023-11-15 14:29:34.108 -08:00 [INF] Streaming locator name and locator Id is: fa548f04-0e41-40b0-ba3e-ff85ad683e8c
2023-11-15 14:29:40.622 -08:00 [WRN] No manifest (.ism file) found in container asset-7757f8d7-7671-40f9-9d72-89fe04c56d14
2023-11-15 14:29:46.436 -08:00 [VRB] Template ${ContainerName}/ expanded to f5efa6d4-6efa-4eb7-ba65-dd3ba3da3810/
2023-11-15 14:29:46.941 -08:00 [VRB] Unknown attribute in manifest title
2023-11-15 14:29:46.944 -08:00 [VRB] Found manifest 27dcfdca-a90b-4c27-9481-b093352a.ism of format mp4 in container asset-a330595d-1ef7-4cf7-bfbf-6951f9ce49c0
2023-11-15 14:29:48.624 -08:00 [VRB] Template ${ContainerName}/ expanded to fa548f04-0e41-40b0-ba3e-ff85ad683e8c/
2023-11-15 14:29:54.397 -08:00 [VRB] Template ${ContainerName}/ expanded to f5efa6d4-6efa-4eb7-ba65-dd3ba3da3810/
2023-11-15 14:29:54.398 -08:00 [VRB] Asset amp:AA1uLYK:1001:9b94d366-1c49-4a2f-86af-37bb3f385fe5 is in format: null.
2023-11-15 14:29:54.398 -08:00 [INF] The asset amp:AA1uLYK:1001:9b94d366-1c49-4a2f-86af-37bb3f385fe5 with format non_ism is not supported by transform PackageTransform in current version, try next transform...
2023-11-15 14:29:54.401 -08:00 [VRB] Template ${ContainerName}/ expanded to f5efa6d4-6efa-4eb7-ba65-dd3ba3da3810/
2023-11-15 14:29:54.401 -08:00 [VRB] Asset amp:AA1uLYK:1001:9b94d366-1c49-4a2f-86af-37bb3f385fe5 is in format: null.
2023-11-15 14:29:54.640 -08:00 [VRB] Uploading to /27dcfdca-a90b-4c27-9481-b093352a31e3.mp4 in container f5efa6d4-6efa-4eb7-ba65-dd3ba3da3810 of account: ampwusdevadp002...
2023-11-15 14:29:55.884 -08:00 [VRB] Template ${ContainerName}/ expanded to fa548f04-0e41-40b0-ba3e-ff85ad683e8c/
2023-11-15 14:29:55.884 -08:00 [VRB] Asset amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 is in format: mp4.
2023-11-15 14:30:00.851 -08:00 [VRB] Uploading to /27dcfdca-a90b-4c27-9481-b093352a_manifest.json in container fa548f04-0e41-40b0-ba3e-ff85ad683e8c of account: ampwusdevadp002...
2023-11-15 14:30:00.984 -08:00 [VRB] Uploading to /e39e593a-0d00-8176-b850-f1ee83f44339_metadata.json in container fa548f04-0e41-40b0-ba3e-ff85ad683e8c of account: ampwusdevadp002...
2023-11-15 14:30:01.004 -08:00 [DBG] Begin downloading 27dcfdca-a90b-4c27-9481-b093352a_650.mp4
2023-11-15 14:30:01.147 -08:00 [DBG] Begin downloading en-usa9f283b0-645e-48ab-a524-a40d6a79.mp4
2023-11-15 14:30:01.404 -08:00 [VRB] Uploaded 0 bytes to /27dcfdca-a90b-4c27-9481-b093352a31e3.mp4
2023-11-15 14:30:01.448 -08:00 [DBG] Finished download of en-usa9f283b0-645e-48ab-a524-a40d6a79.mp4
2023-11-15 14:30:02.141 -08:00 [DBG] Finished download of 27dcfdca-a90b-4c27-9481-b093352a_650.mp4
2023-11-15 14:30:02.460 -08:00 [VRB] The lease-detect blob for output path / under f5efa6d4-6efa-4eb7-ba65-dd3ba3da3810 is deleted.
2023-11-15 14:30:02.517 -08:00 [VRB] Starting static packaging for asset amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769...
2023-11-15 14:30:09.285 -08:00 [DBG] Migrated asset: amp:AA1uLYK:1001:9b94d366-1c49-4a2f-86af-37bb3f385fe5, container: f5efa6d4-6efa-4eb7-ba65-dd3ba3da3810, type: non_ism, status: "Completed"
2023-11-15 14:30:09.345 -08:00 [DBG] Asset Migration: 1/2 Assets
2023-11-15 14:30:09.363 -08:00 [ERR] Failed to migrate asset amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769 Error:System.ArgumentNullException: Value cannot be null. (Parameter 'source')
at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
at System.Linq.Enumerable.TryGetSingle[TSource](IEnumerable1 source, Func2 predicate, Boolean& found)
at System.Linq.Enumerable.SingleOrDefault[TSource](IEnumerable1 source, Func2 predicate)
at AMSMigrate.Transform.ShakaPackager.<>c__DisplayClass6_0.b__0(Track t, Int32 i) in C:\git\CMS.Service.Video.Processor\Src\azure-media-migration\migrationTool\transform\ShakaPackager.cs:line 131
at System.Linq.Enumerable.SelectIterator[TSource,TResult](IEnumerable1 source, Func3 selector)+MoveNext()
at System.Collections.Generic.List1..ctor(IEnumerable1 collection)
at AMSMigrate.Transform.ShakaPackager.GetArguments(IList1 inputs, IList1 outputs, IList1 manifests) in C:\git\CMS.Service.Video.Processor\Src\azure-media-migration\migrationTool\transform\ShakaPackager.cs:line 127    at AMSMigrate.Transform.ShakaPackager.RunAsync(String workingDirectory, String[] inputs, String[] outputs, String[] manifests, CancellationToken cancellationToken) in C:\git\CMS.Service.Video.Processor\Src\azure-media-migration\migrationTool\transform\ShakaPackager.cs:line 297    at AMSMigrate.Transform.PackageTransform.TransformAsync(AssetDetails details, ValueTuple2 outputPath, CancellationToken cancellationToken) in C:\git\CMS.Service.Video.Processor\Src\azure-media-migration\migrationTool\transform\PackageTransform.cs:line 161
2023-11-15 14:30:10.602 -08:00 [VRB] Uploaded 0 bytes to /27dcfdca-a90b-4c27-9481-b093352a_manifest.json
2023-11-15 14:30:10.603 -08:00 [VRB] Uploaded 1013 bytes to /27dcfdca-a90b-4c27-9481-b093352a_manifest.json
2023-11-15 14:30:12.655 -08:00 [VRB] Uploaded 0 bytes to /e39e593a-0d00-8176-b850-f1ee83f44339_metadata.json
2023-11-15 14:30:12.655 -08:00 [VRB] Uploaded 3698 bytes to /e39e593a-0d00-8176-b850-f1ee83f44339_metadata.json
2023-11-15 14:30:12.873 -08:00 [VRB] The lease-detect blob for output path / under fa548f04-0e41-40b0-ba3e-ff85ad683e8c is deleted.
2023-11-15 14:30:12.995 -08:00 [DBG] Migrated asset: amp:AA1uLYK:1004:1a5f125b-29e6-4c58-9e5f-622410714769, container: fa548f04-0e41-40b0-ba3e-ff85ad683e8c, type: mp4, status: "Failed"
2023-11-15 14:30:12.999 -08:00 [DBG] Asset Migration: 2/2 Assets
2023-11-15 14:30:13.002 -08:00 [INF] Finished migration of assets for account: ampinfrawestuscivideo. Time taken: "00:01:25.8490202"
2023-11-15 14:30:13.024 -08:00 [INF] See file C:\git\CMS.Service.Video.Processor\Src\azure-media-migration\migrationTool\bin\Debug\net6.0\MigrationLog_14_28_44.txt for detailed logs.

fixed by this commit
75b20dd When migrating a video with a secondary audio component in it, the video track has Parameters set to null. It was throwing an exception here<EMAIL_ADDRESS>


ServerDisconnectedError while invoking large contract

Describe the bug (observed vs expected behavior)
When we run scratch.py script attached to this issue which is executing a large kakarot contract devnet will fail with http.client_exceptions.ServerDisconnectedError: Server disconnected.
The problem will disappear when we use rust vm -e STARKNET_DEVNET_CAIRO_VM=rust.

[x] This issue is only present on Devnet and cannot be reproduced on alpha-goerli (check the box if true).

To Reproduce scenario 1
Steps to reproduce the behavior:

In one terminal run devnet as docker image docker run -p 5050:5050 ghcr.io/sayajin-labs/kakarot/devnet:latest
In second terminal install starknet-py = "0.14.0a0" and typeguard = "2.13.0" and run python ./scratch.py
scratch.zip
It should fail like this:

Devnet version

I am using Devnet version:
[x] This happens with a dockerized Devnet (check the box if true).
This does not appear on the following Devnet version:

System specifications

OS:
CPU:
Memory:
Python version:

What happens if you start devnet with an increased --timeout <SECONDS>? It defaults to 60 seconds.

To Reproduce scenario 2
Steps to reproduce the behavior after timeout increased:

Run docker container
1.1 Docker
Start docker:

sudo /etc/init.d/docker start
docker run -p 5050:5050 -e STARKNET_DEVNET_CAIRO_VM=rust ghcr.io/sayajin-labs/kakarot/devnet:latest

1.2 Just run devnet with state generated in docker as devnet.pkl file:
poetry run starknet-devnet --seed 0 --host "<IP_ADDRESS>" --port "5050" --load-path "devnet.pkl" --disable-rpc-request-validation --timeout "300"

There is multiple issues here

First and the most important one is this:

When devnet is lagging Metamask is trying to fetch future blocks (the same way it's fetching them in Ethereum), probably based on some past assumptions about how fast blocks are produced. It can lead to the situation that we have 20 block and metamask is trying to fetch block number 50.

In Metamast some transactions are marked as failed (which is correct behaviour) but some on them doesn't and metamask try to update them constantly (even when CI/CD kakarot setup changed) but I would say it's just metamask problem

Ok, I have some updates, I think that I know what is going on here:

The first problem is the integration problem. If you deploy contracts from remix using metamask (in my case it was 3 of them), they will be processed normally with accepted on l2 status but metamask will not detect that because of Remix<->metamask<->RPC<->starkscan integration problem and it will try to redeploy them so blockchain will grow. We can also see errors related to that like not existing transactions, and querying blocks that are not there when the blockchain was restarted without a load of the previous state. [We can't do anything about that, maybe it's an RPC issue.]
The second problem is that once you are in this state and contracts are redeployed constantly (in my case 3 of them) after a while (~ between block 15-25) the function apply_state_updates() in starknet code base is failing because of "Invalid transaction nonce." (which makes sense in this case!). Maybe we can fix that on a devnet level code base. After that failure https://devnet.starkscan.co/ will lose track even though you can use devnet after that. Just new blocks/transactions will not show in starkscan. Also, strange thing is that after a while apply_state_updates() function needs more time to process kakarot operations. In the beginning, it takes 50 seconds, and later 60s, 70s, 80s, 90s, 100s, etc but this operation should be linear in time, here maybe someone from starknet team should take a look. [In this problem, we will take action and see how to fix it.]

although I could reproduce the "Invalid transaction nonce." issue in the case of chainlink contracts there is no exponential memory leak over 1-2 hours that is happening with kakarot's contracts


Appender: fix appendValue for optional value types.

The resulting type of if(optional) |val| val else null expression is always ?T, meaning that the optional is never unwrapped, leading to infinite recursion.
Added a test for inserting optional types.

thanks and thanks for the test.


No API Key Question

Steve,  I have a question about an error that I get on a few sites about Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys"
So I generated a key for the website that I am working on but not really sure where to put it in the code so the error goes away.  Maybe I missed something in the documentations, or maybe it just isn't required.  Any help on this would be greatly appreciated.
Thanks.

@Tigerlady Add the api key here https://github.com/stevewithington/MuraLocations/blob/develop/scripts/inc.cfm#L13
&key="YOURAPIKEY"

I'm working on submitting a pr that will add a setting for the api key.
Google changed the api fairly recently that requires an api key in order to load/ init the map.
Once you add the key, the warning will go away.


Local preview server updated to support new structure

Summary
https://issues.newrelic.com/browse/NR-26664
Now serving all files.  GET request will now give paths to dashboards and alerts to appropriate new directories.  Removed the tests for validating paths because this is tested in the class.

I think you'll want to target the content-updates branch with this, that's probably why we're seeing conflicts

I think you'll want to set content-updates as the base branch with this, that's probably why we're seeing conflicts

Ahh I didn't know that existed, my mistake.  I pointed it to the new base, that seems to have resolved the open conflicts so I'll merge this


Remove left and bottom Margin for Niimbot B1

During some testing for the B1, I ran into the problem of having left and bottom margin in my resulting print (see the image below, the size of the PNG is set to 370px x 230px). Any ideas how I can get rid of it? Thanks in advance!

@TurboLuke I think the image should be 384px wide. I have a B21, and alignment isn't always perfect, especially when you load a new paper roll and print the first label. Maybe try printing two labels in a row, at least it should fix the bottom margin


[Bug] [reactive_flutter_typeahead] custom onSuggestionSelected does not update the text field

https://github.com/artflutter/reactive_forms_widgets/blob/e06fb616d487e46ae26b782caacf174a84d96989/packages/reactive_flutter_typeahead/lib/src/reactive_typeahead.dart#L151
in the above line defining onSuggestionSelected will not update the textfield.
              onSuggestionSelected: onSuggestionSelected ??
                  (value) {
                    controller.text = stringify(value);
                    field.didChange(value);
                  },

Ahh! That hurts.😂

I was having the same issue as @DattatreyaReddy where if I didn't select one of the suggestions but just typed in a new value it wasn't updating the field, and since the field was required, validation wasn't resolved..  I was also using the onSuggestionSelected to set some other fields based on the value selected. So, whilst this change fixes my first issue, how can I now tell if the value change is because of the selected suggestion or a new value?
I guess I go back in the form control and compare the value to the suggestions and see if there's a match, unless there is a better way?  Plus this will change on every character entered.. And will potentially match multiple values, so I guess it have to work with the case of single match. Hmmm..


feat: add evaluation info logs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

50 of 54 (92.59%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 84.219%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

opaevaluator.go
21
25
84.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1553

Relevant Lines:
1844

💛  - Coveralls


added nicmos unit conversion notebook

I added a notebook on programmatic wats to perform unit conversions as provided by http://www.stsci.edu/hst/nicmos/tools/conversion_form.html. I put this notebook in a new directory NICMOS, so that any future NICMOS notebooks can be added there as well.

Please do the following:

Remove ._nicmos_unit_conversion.ipynb from version control.
Add ._*.ipynb to the existing .gitignore file.
Squash your commits into one. This is necessary so that ._nicmos_unit_conversion.ipynb never existed in git history.

Thanks!

You might also want to consider adding a few more examples that are useful from the INS standpoint. The one I provided originally was a quick prototype.

@pllim can this be merged? seems like someone might want to use this according to the discussion on slack?

ugh, i did something wrong when trying to squash and now all these irrelevant commits are in here. how can i fix this?

Thanks, @shannnnnyyy !


made changes in the footer

Description
Added  a subscribe to news letter in the footer

This PR does the following:

Adds ...newsletting in the footer

closes #409
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[ x] I have performed a self-review of my code
[ x] I have commented my code, particularly in hard-to-understand areas
[x ] My changes generate no new warnings
[x ] I am working on this issue under GSSOC

@Satyam1923  can you please review the pull request


Syntax errors reported when multiple requires are declared at once

I'm getting a syntax error when I try and run browserify in a module which requires d3-geo-projection 0.2.13. The problem seems to be down to a line in its index.js.
var fs = require("fs"),
    path = require("path");

module.exports = new Function("d3", fs.readFileSync(path.join(__dirname, "d3.geo.projection.js"), "utf-8"));

If I replace the first two lines with
var fs = require("fs");
var path = require("path");

browserify runs without complaint.

It seems this is due to https://github.com/substack/brfs/issues/35 ? In that case, I'll take your word that it's fixed.

It happens without brfs, so I think another fix is needed.


upgraded shellingham requirement to v1.2.2

upgraded shellingham requirement to v1.2.2 and then invoked vendoring.update.
Vendoring.update brought in changes from several unexpected libraries:

 pipenv/vendor/requirementslib

pipenv/patched/crayons.py

pipenv/patched/piptools/utils.py

Two things concern me.
First, the license file  pipenv/vendor/requirementslib/_vendor/pipfile/LICENSE.APACHE was removed. There is still a LICENSE file which references either LICENSE.APACHE or LICENSE.BSD as being applicable.
It may have been an error for the vendoring process to remove the LICENSE.APAHCE file, but it also seems that a LICENSE.BSD file was missing.
Second, the requirements for shellingham were removed from crayons.
Is this requirement being removed from the pipenv project?
I still see a requirement in ./pipenv/shells.py.

flagging as do not merge until I get the patch in

I merged the crayons patch into your branch, thanks again

I just released 1.2.3 for Shellingham, will need to update that as well. So many bugs…


Feature/show more show less text

Motivation and context

Better UX some texts are way too long and should be partially hidden until user decides to view them full length.

Fixes: https://github.com/https://github.com/podkrepi-bg/frontend/issues/1091

Uses: https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-line-clamp and https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight

-Problem: To have the ability to truncate longer text and control how visible it should be by rows count anywhere in the app.
-How:

By creating a reusable component that accepts text and rows limit.
The component uses local state to handle visibility of the text. It uses WebkitLineClamp for smooth display of the text by rows and adding ellipsis at the last row.
It compares the current height of the text element with the scroll height (current height + the hidden text element height.
The component also listens for screen size changes in order to support responsive design.
The component can be used solo or could be nested inside other tags like paragraph for example and will still work as expected.

Screenshots:
| Before

| After              |
| ------------------- | ------------------ |
| [before screenshot] | [after screenshot] |
Testing

Testing by clicking the small text and expecting the text to expand or hide
Resizing the screen testing if the button hides if the text content is short and doesn't require truncating
Toggling different states of the text then resizing the screen;
Passing 0 rowsLimit or null as rowsLimit
Passing empty string as text
Changing the language
Refreshing the page
-Environments: Chrome , Safari , Firefox

New environment variables:

env var : env var details

New dependencies:

dependency : dependency details

New dev dependencies:

dependency : dependency details

Closing this PR as duplicate of https://github.com/podkrepi-bg/frontend/pull/1139
Thanks again for the effort!


add basic zsh completion for arguments

We should investigate auto generating this script based on the cli.Flags in https://github.com/wercker/stern/blob/master/cmd/cli.go#L39-L73

So you mean you'll implement a feature like "kubectl completion" in stern, right? That will be much better. I suppose it'll be able to get completion options for namespace, pod, container at runtime.

For the first iteration we could have a stern completion which basically emits the script that you provided. The only difference is that it will be auto generated by the flags. So any new flags would automatically be added to the script. A next iteration could included dynamic completion for namespaces, etc.


Pass empty string in Token.parse(), instead of name.

Resolves #101.

Current coverage is 98.91% (diff: 100%)

Merging #102 into master will decrease coverage by 0.09%

@@             master       #102   diff @@
==========================================
  Files            79         79
  Lines          1010       1010
  Methods           0          0
  Messages          0          0
  Branches        177        177
==========================================
- Hits           1000        999     -1
  Misses            1          1
- Partials          9         10     +1

Powered by Codecov. Last update b37b531...306040a


Today button doesn't fire onChangeDateTime

If you are on a different date and click the Today button to get back to today it doesn't fire the onChangeDateTime event.

Duplicate of #465.


UTD; NA; NATS; NDY

Discussion: These variations of NAs are still upsetting my OCD in the database. I think we need to decide what option from below is the best one.
Option 1: From an Analysis point of view all these fields still mean NA when doing comparative analysis. Therefore, should we revert all back to to NA, to avoid having multiple fields that may be unnecessary.
Option 2: All these 4 fields appear as NAs to standard users, but when COMPADRINOS log in they can now be seen as described above (NA; UTD; NATS; NDY). In this instance an NA could still mean multiple things. A compadrino still might not be sure if it was an NA because the compadrino completing that record didn't have the expertise to find the information they needed or simply because the information was not available or in some cases it is simply not applicable to that entry, for example, it is an animal with NA for growth type. Maybe to overcome this we simply need clearer definitions of these fields or more fields/options for compadrinos to cover all these basis.
Option 3: We leave it how it is, make sure our definitions for the fields we have are ship shape and let others figure it out for themselves when conducting analyses.
@sargentfrancesca how difficult will it be to manage option 2?
@simonrolph what are your views?

W/ regards to option 2, I'm not sure yet. In the case of serving all to the front end as NA, and the export, it just needs to be a function or method. It just feels a little messy and hacky, and generally with these things, it makes better sense to have a clearer definition. So if 1 and 3 fail, we can do 2?

Are we closer to deciding on this?

For the fields that we have completed, I am going to change all to NA. For the fields not yet complete, I am going to leave them as they are for now for clarity and once complete change all to NA (either through the CSV for now, or on the front-end once ready for Compadrinos to use)

For an update on this. Currently, those rows of data that have been released will only contain NA. Those rows of data from the descriptor file and unreleased (database_master_version-> "X") will contain NDY or NA or NATS
NDY - Not done yet
NATS - Not able to source

I believe this has been resolved with out NDY and NA traffic light system? :)


Fix warning on SectionList's tutorial

I wanted to fix issue #16231 - the warning is not displayed anymore:

Thanks for the fix!

@facebook-github-bot shipit


React version: Get Bootstrapped

Replace this version of the site with a simple react app to get started.

[x] - Get basic component structure set up
[x] - Utilize linting
[x] - Routing if needed
[x] - Find useful icon library

UI:

[x] - Pick a color scheme

README:

[x] - how to install

resolved in #6


Add parallel support to nightly spark standalone tests

Signed-off-by: Peixin Li<EMAIL_ADDRESS>fix #2802
To speed our nightly spark standalone integrations tests,
spark 3.0.x total time: ~3h 40m to ~1h 15m
spark 3.1.x total time: ~4h to ~1h 35m (include extra ParquetCachedBatchSerializer cache_test)
I am still doing more verification on other scenarios, submit first to collect feedbacks, thanks!
This requires to be enabled in nightly pipelines' Jenkinsfile separately

build

Looks OK to me other than we may want a followup to split some of these expensive test cases to make it easier for pytest to make better decisions about running them in parallel on its own.

Thanks! I filed an issue  https://github.com/NVIDIA/spark-rapids/issues/3279 to track the followup


Bulk Metadata Update - ms.topic updates.

Global effort to improve metadata quality across the Learn platform
These changes make reports cleaner, easier to use, more consistent, and more reflective of our current business. After you accept these changes and they're merged, they will be reflected in standard dashboards and reports maintained by C+E Skilling Business & Customer Success. You'll need to use new filter values in these reports, and you may need to update any custom dashboards or Kusto queries. If you have any questions, please contact Learn Platform Metadata (learn-metadata@microsoft.com).

Learn Build status updates of commit 6993550:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/articles/index.md
:white_check_mark:Succeeded
View

BingMaps/retired/bing-maps-on-azure-marketplace.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@eriklindeman @JuanPapas
This PR replaces 2 instances across 2 files. No other content was edited or added. If you have any questions, please contact Learn Platform Metadata (learn-metadata@microsoft.com).

Hi @eriklindeman @JuanPapas, please review and let us know if you would like any changes. Thanks!


Regression Tests

Added regression tests and changed some documentation.
Some doctests caused cargo test to fail, so I patched those as well.
Note:

Some regression tests are failing due to unimplemented primitives, I wanted to wait for a more 'on-topic' PR to fix those.

thanks for this🙂

Issue here


SAK-49149: Site Info > Manage Access > provide option to email maintainers when someone joins a joinable site

https://sakaiproject.atlassian.net/browse/SAK-49149
Supplemental to SAK-24423, this will provide a new option within “Manage Access” under the joinable site settings: email notifications when someone elects to join the site, which will be sent to all site maintainers.
NOTE: introduces a new sakai.property to enable/disable this feature globally: sitemanage.join.notification.enabled=[true/false] (defaults to false)

This code was written way back in 2012. It was originally contrib'd along with the other joinable site settings in SAK-24423, but the join notification email aspect was rejected at that time due to a cyclical dependency. Now that EmailTemplateService has been moved into kernel, we're able to stop sitting on this as a local modification.
Despite this code working well and not having issues in 10+ years, we have not gone back to refactor this code at all, and it could very well use some updating. However, we have not been given resources to update this code for contribution.
As for the new getUserSites method, I'm also assuming it's needed but I haven't looked into it further than porting the code. Unfortunately I'm still not able to put resources towards modifying this PR, but if someone wants to make edits, feel free to do so.
There also seems to be some support/interest in this feature on the JIRA ticket itself.


ISIS Base Adjacencies Test: Don't validate PSNP states

Stop validating the PSNP Processed and Received states since the PSNP exchange is not always guaranteed

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls


How to pick transform or translation options of NodeOptions?

This need isn't limited to a specific sim, and occurs often when designing Node subclass APIs.
I have a subclass of Node that I would like to configure via options.  I would like my subclass to expose only the Node options that are related to translation in its API.   For example, see GOControlPanel.js in geometric-optics. How can I accomplish this via PhET'S TS options pattern?
The options that related to translation are enumerated in mutate:
    // @ts-ignore
    assert && assert( _.filter( [ 'translation', 'x', 'left', 'right', 'centerX', 'centerTop', 'rightTop', 'leftCenter', 'center', 'rightCenter', 'leftBottom', 'centerBottom', 'rightBottom' ], key => options[ key ] !== undefined ).length <= 1,
      `More than one mutation on this Node set the x component, check ${Object.keys( options ).join( ',' )}` );

    // @ts-ignore
    assert && assert( _.filter( [ 'translation', 'y', 'top', 'bottom', 'centerY', 'centerTop', 'rightTop', 'leftCenter', 'center', 'rightCenter', 'leftBottom', 'centerBottom', 'rightBottom' ], key => options[ key ] !== undefined ).length <= 1,
      `More than one mutation on this Node set the y component, check ${Object.keys( options ).join( ',' )}` );

I think it's important that I avoid making copies of the arrays shown in mutate. And I don't want to specify only the NodeOptions that my sim is actually using, because that doesn't make for a good API (especially in common code), and is just avoiding the problem.
Ideally, I'd like to be able to define my subclass' options type something like:
import { Node, NodeTranslationOptions } from '../../../../scenery/js/imports.js';

type MyNodeOptions = {
  // ... options that are specific to MyNode
} & NodeTranslationOptions;

class MyNode extends Node {
  constructor( ..., options?: MyNodeOptions ) {
    ...
  }
}

Assigning to @jonathanolson since he's the primary author of Node.  And adding to Developer Meeting project board for general discussion.

If the array enumerated in mutate were publicly available, then perhaps I could figure out how to do something like Pick< NodeOptions, ... > to get the subset of NodeOptions that I need.

Maybe NodeOptions could be assembled as type NodeOptions = TranslationOptions & TransformOptions & InputOptions & etc so that clients can pick the subset they want?

For something like Node that has so many options, having categories as @samreid has proposed sounds really nice.

Another common needs is to omit all translation options.  This is typical for a Node that observes a positionProperty and handles its own translation.

@pixelzoom do you want to support a case where a client can specify the x and y translation, but not the scaling or rotation?

Yes, that's actually the case in Geometric Optics.  I want have UI components that I want to position using the translation options, but don't want to otherwise transform.  But being able to get the transform options would be better than having to settle for NodeOptions.

Raising priorty of this issue to high. It's been open for 4+ months.  I have 4 TODOs for this issue in Geometric Optics (see above commit) and I'd like to resolve them before 1.2 publication.  I'm also starting on MOTHA and Equality Explorer, and don't want to have to continue using this same workaround.
FYI, I'm currently working around this by picking the translation options that I'm actually using. For example:
// GOScreenView.ts

    const opticShapeRadioButtonGroup = new OpticShapeRadioButtonGroup( model.optic, {
      centerX: erodedLayoutBounds.centerX,
      top: erodedLayoutBounds.top,
      tandem: controlsTandem.createTandem( 'opticShapeRadioButtonGroup' )
    } );

// OpticShapeRadioButtonGroup.ts

type OpticShapeRadioButtonGroupOptions = SelfOptions &
  PickRequired<RectangularRadioButtonGroupOptions, 'tandem'> &
  PickOptional<RectangularRadioButtonGroupOptions, 'centerX' | 'top'>; //TODO https://github.com/phetsims/scenery/issues/1332

What I had in mind is something like:
export type NodeTranslationOptions = {
  translation: Vector2;
  // ... and all of the keys from REQUIRES_BOUNDS_OPTION_KEYS
};

export type NodeTransformOptions = {
  matrix: Matrix3;
  scale: number;
  rotation: number;
} & NodeTranslationOptions;

export type NodeOptions = {
  ...
} & NodeTransformOptions;

Also happy to skip NodeTransformOptions and simplify to this:
export type NodeTranslationOptions = {
  translation?: Vector2;
  x?: number;
  y?: number;
  leftTop?: Vector2;
  centerTop?: Vector2;
  rightTop?: Vector2;
  leftCenter?: Vector2;
  center?: Vector2;
  rightCenter?: Vector2;
  leftBottom?: Vector2;
  centerBottom?: Vector2;
  rightBottom?: Vector2;
  left?: number;
  right?: number;
  top?: number;
  bottom?: number;
  centerX?: number;
  centerY?: number;
};

export type NodeOptions = {
  ...
} & NodeTranslationOptions;

I'd also be OK with having just NodeTransformOptions:
export type NodeTransformOptions = {
  matrix?: Matrix3;
  rotation?: number;
  scale?: number | Vector2;
  translation?: Vector2;
  x?: number;
  y?: number;
  leftTop?: Vector2;
  centerTop?: Vector2;
  rightTop?: Vector2;
  leftCenter?: Vector2;
  center?: Vector2;
  rightCenter?: Vector2;
  leftBottom?: Vector2;
  centerBottom?: Vector2;
  rightBottom?: Vector2;
  left?: number;
  right?: number;
  top?: number;
  bottom?: number;
  centerX?: number;
  centerY?: number;
};

export type NodeOptions = {
  ...
} & NodeTransformOptions;

I guess we should also discuss whether this change would be OK:
type OpticShapeRadioButtonGroupOptions = SelfOptions &
  PickRequired<RectangularRadioButtonGroupOptions, 'tandem'> &
-  PickOptional<RectangularRadioButtonGroupOptions, 'centerX' | 'top'>;
+ NodeTransformOptions;

In this case, OpticShapeRadioButtonGroup extends RectangularRadioButtonGroup.  So using NodeTransformOptions is "reaching around" the class hierarchy.  Imo, this is a case where that's acceptable.

https://github.com/phetsims/scenery/issues/1332#issuecomment-1115159918 looks preferable to me, of the indicated options.  Would you like to commit that to scenery?

Will handle it now!

Implemented. I recall a benefit to also having bounds-based translation items separated out, so I did that also.
@pixelzoom thoughts?

Would we want to list the bound-less ones first (or list it separately)?  For instance, some clients may want to specify the x/y/translation without knowledge of the node's bounds.

That sounds like a question for @jonathanolson.

I haven't had a need to differentiate bounds-based translation options, but I don't see any harm in having them.
Other changes look good to me, and I'll start using NodeTranslationOptions in Geometric Optics.

5/5/2022 dev meeting notes:

add new types to import.ts
no need for list of bounds-less options, the same thing can be achieved using Omit.

Done, and used in geometric-optics. Closing.


fix(challenge): various grammar and formatting, .env node challenge

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #13161

Description

GitHub does not seem to be highlighting my changes very well, so reviewers, please read through both for details. I think this improves the flow of the challenge, though, and fixes the following:

various language and grammar issues
wrapped variable and code references in <code> tags
separated one long paragraph into 2 shorter ones to make it a bit less daunting
clarified challenge instructions
changed confusing wording in assertion error

@erictleung Changes are all set! Thanks for the review! Once this one and #13155 are both reviewed, #13164 could also use a review which also deals with these challenges.

@erictleung is this good now then? Looks like the "changes requested" is still present so wasn't sure if there was anything else

@no-stack-dub-sack sorry! I didn't get the time to pull this down locally to test. I've taken another look at it and found some other changes that might be made. Sorry for the delay.

@erictleung No worries! Just saw the 👍  and the 🎉  so wasn't sure... nice catches though, especially the quotes, left an explanation as to how and why that happened above in the (soon to be) outdated. Pushing the changes in a second!

@erictleung Whoops, missed that one, should be good now

@no-stack-dub-sack LGTM! 👍  Thanks for your PR and patience!


Create testing infrastructure for Atmo.

Create testing infrastructure for Atmo.
We want automated tests.
Unit tests exist for the coordinator and sequence runner but no integration tests.

Tests:
If any tests do not return 200s, fail the test (CoNNOR WILL SHOW ME)
/hello
Make a request to each of the handlpoints and check its results.
Sendpost request to /hello and should get "hello my fired" back.
/fetch:
Testing use of State- modifyurl function adds /suborbital and fetch test takes that url and makes a request to that url. Make request to /fetch and body of request will be HTTPS.github.com- modify url will ......... (14.29)
Strings.contains (bullion go func)
/set/key and /get/key Botha re testing cache.
pass variable into :key (like /set/name - Connor for example, and then /get as its the same to
first request should have 2000 response code and second has 200 and exact same value.
/file make a request to each file in Static directory (main.css, main.js, static.md) and should return contents of the files. Compare return values of each return request to ensure it matches.

= path, : = one element
like: /file/css/main.css

CHECK THE RUNNABLES FOR EACH HANDLER
/github: uses graphql function (LEAVE FOR NOW)- come back to because requires
Ignore: /user--> (requires db) and /stream --> (requires web socket).

//I think the easiest way would be to make a single Atmo method that does everything Start() does but instead looks something like func (a *Atmo) testStart() (*vk.Server, err), and then you can call that method from your atmo_test.go tests
//Create an Atmo object
// func New(opts ...options.Modifier) *Atmo {
// 	options.UseBundlePath(path),
// }
// Just call: New Method which creates a new atmo server and object
//and give it this option.
// UseBundlePath("./example-project/runnables.wasm.zip")
/*
Tests:
If any tests do not return 200s, fail the test (CoNNOR WILL SHOW ME)
RECREATE ALL TESTS IN GOLANG

/hello       ****** curl -d 'my friend' localhost:8080/hello *********
Make a request to each of the handlpoints and check its results.
Sendpost request to /hello and should get "hello my friend" back (if you send my friend in post).

/fetch: *******    curl -d 'https://github.com' localhost:8080/fetch | grep "atmo"    ********
Testing use of State- modifyurl function - adds /suborbital onto end of url and fetch test function takes that url and makes a request to that url.
Make request to /fetch and body of request will be HTTPS.github.com- modify url will change that to github.com/suborbital and fetchtest will make a request to github.com/suborbital and then it will downtload the html of our suborbital github page.
SO. POST REQUEST to /fetch
Body of post request should be HTTPS github.com
Response will be HTML, but search through the string to see if Vektor, Grav, and Atmo are there, that is the correct page.
The HTML will come back as a string.
Strings.contains() --> built in go function.  ......... (14.29)

/set/:key and /get/:key
^^ to test: first request should have 200 response code and second has 200 and exact same value. /set/name and /get/name Botha re testing cache. (won't return any data for SET)- for check: ONLY checking that status code =200)
pass variable into :key (like /set/name - Connor for example, and then /get as its the same to
/set/:key *********      curl -d 'nyah' localhost:8080/set/name ***************.  Does not return anything- on a 200 response it doesn't return any day (this POSt request does not return data). Just check that the status code is 200.
/get/:key *********      curl localhost:8080/get/name    *********** Should return name from above.

/file/*file - "testing fetching a file from the static directory" ****** curl localhost:8080/file/main.md ********* will return contents of main.md *****
RETURNS: [contents of main.md file] which is in this case: hello%
Or: [other file example]
curl localhost:8080/file/css/main.css
RETURNS:
.classname {
color: aliceblue;
}%
make a request to each file in Static directory (/css/main.css, /js/app/main.js, /main.md) and should return contents of the files.
Compare return values of each return request to ensure it matches the contents of the file that you are asking for. Can jsut copy contents of file and read test or READ file (more automated).

= entire path (like /file/{css/main.css}), : = one element (vs /file/{main.css}) _ you can only have one element at the latter
like: /file/css/main.css
You can peek at each runnable that each fo these is using just to see how the runnable is writtena nd what APIs its using for general knowledge about atmo.

/github: uses graphql function (LEAVE FOR NOW)- come back to because requires
Ignore: /user--> (requires db) and /stream --> (requires web socket).
*/
//curl -d 'my friend' localhost:8080/hello
//send post request to endpoint
//should return "hello my friend"
// 3 test important notes:
// Method has to start w Test405Request
// Param has to be (t *testing.T)
// file name has to be _test.go
// /hello       ****** curl -d 'my friend' localhost:8080/hello *********

DONT FORGET: AFTER WRITE A SCRIPT THAT RUNS ALL THE TESTS
MAYBE WE CAN SET THAT SCRIPT TO RUN EVERYTIME SOMETHING ELSE IS SET FOR ATMO- LIKE WHEN A RELEASE PR IS CREATED or something similar (will have kinks but just thinking this through).

@MacklinEngineering your tests are already being run, it's built into CI already :)
https://github.com/suborbital/atmo/runs/5029200425?check_suite_focus=true#step:5:17

Oh that is dope!! Wait, so CI will automatically run these tests on all atmo code that is pushed up?

@MacklinEngineering yep, that's what the C in CI stands for (continuous) 🙂
See the .github folder which describes the CI workflow, it runs go test -v ./..., which runs all tests in the project.


JobMsg is too generic, needs to have the binding uuid

While implementing the binding job, I found that I need to also pass the binding uuid instead of the instanceuuuid in the JobMsg. We used to have specific WorkMsgs which would've made this easier with a new BindingMsg.
Probably not work creating a bunch of msgs, need to enhance JobMsg to allow for additional data.

This is no longer an issue for me. Fixed current release.


Document CREATE TEMP TABLE...

I can not find any description on what a TEMP or TEMPORARY table is in CREATE TEMP TABLE... statements. Would be helpful with a brief description on this page https://duckdb.org/docs/sql/statements/create_table
One use case I have is that I consider it for "caching" aggregates:
create tmp as select user, count(*) v ... and then run queries like this select city, sum(v) v ... from tmp.
Is it materialised in memory? What if it does not fit in memory?
Is it removed automatically? When? How?
What is the intended use case for temporary tables?

The tables reside in memory, but I am not certain what happens if they exceed memory (@Mytherin or @hannes happen to know?) . I believe that they would use a temporary file if they exceeded memory?

If a temp_directory is specified chunks of the temporary table can indeed be off-loaded to disk as required. If not then an error will be thrown.

There are basically two styles of "temporary tables" out there: global and session scoped.
Global tables are permanent tables that have a globally defined schema, but the data is private to the session (e.g., Oracle. One nasty problem with them is that you can't use them for the kind of local analytics you are describing because the temporary table name is global. This is problematic for query generating systems (like Tableau, which is where I ran into this).
Fortunately, as a single user system, DuckDB supports session scoped temporary tables. Using them to cache expensive intermediate results such as rollups is a common use case, so go for it!


[Extensibility Enhancement] table 246 "Requisition Line" Getter for global var CurrentFieldNo

To be able to use the default OnValidateTrigger of table 246 "Requisition Line" we could need an getter function for the global varialbe CurrentFieldNo? Then we could avoid addtional events.
procedure GetGlobalCurrFieldNo() : Integer
begin
    exit(CurrentFieldNo);
end;

Update:
Other accepted solution: Move the variable CurrentFieldNo to the scope protected.
protected var
        CurrentFieldNo: Integer;

Can we simply move this variable to protected?

Would be okay for me, too. Didn't know what you prefer on such issues.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Fix Circular Dependency in Connection.h and BrilliantServer.h

For some reason, this doesn't create a compilation error for me but it should be addressed anyway

Fixed


Import additional secrets via file uri

Fixes #25034
marked as WIP as I have not tested this in the slightest

The error message in loadSecret could be updated together.

removed WIP as I've tested this now

It seems that the app.ini and cheatsheet.md should also get updates, the old INTERNAL_TOKEN_URI and SECRET_KEY_URI were documented.

ping~. does it need documentation?


bunde_dmg script fails to remove mounted volume when user installs built app

I'm using a blank issue since I feel like this is more of a dev QOL thing than a bug, but here's the steps to what I encountered:

Run yarn tauri build in a Tauri app. The app is built successfully.
Find the dmg and install the app (found in src-tauri/target/release/bundle/dmg). This only happens when installing the dmg, not when manually running the built app from the osx directory.
Run yarn tauri build again
Build fails with this error (verbose flags added):

RUST_BACKTRACE=1 yarn tauri build --verbose
yarn run v1.21.1
warning package.json: No license field
$ /Users/chandutennety/projects/personal/tauri-build-test/node_modules/.bin/tauri build --verbose
[tauri]: running build
 app:spawn Running "cargo tauri-bundler --features embedded-server --release --verbose" +0ms

   Compiling test v0.1.0 (/Users/chandutennety/projects/personal/tauri-build-test/src-tauri)
   Compiling tauri-api v0.7.4
   Compiling tauri v0.9.2
    Finished release [optimized] target(s) in 15.05s
    Bundling test_0.1.0_x64.app
    Bundling "/Users/chandutennety/projects/personal/tauri-build-test/src-tauri/target/release/bundle/dmg/test_0.1.0_x64.dmg"
info: running bundle_dmg.sh
Creating disk image...
created: /Users/chandutennety/projects/personal/tauri-build-test/src-tauri/target/release/bundle/osx/rw.test_0.1.0_x64.dmg
Mounting disk image...
Mount directory: /Volumes/test_0.1.0_x64
Device name:     /dev/disk3
making link to Applications dir
Copying volume icon file '../../../../icons/icon.icns'...
error: Shell Scripting Error:`error running bundle_dmg.sh`

 app:spawn Command "cargo" failed with exit code: 1 +0ms

 app:tauri (runner) ⚠  [FAIL] Cargo CLI has failed +0ms

 app:tauri Shutting down tauri process... +1ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

When I checked the /Volumes folder, it looked like this:
ls -al /Volumes/
total 0
drwxr-xr-x  29 root           wheel  928 Sep 12 23:46 .
drwxr-xr-x  23 root           wheel  736 Aug 28 14:43 ..
lrwxr-xr-x   1 root           wheel    1 Aug 28 16:35 Macintosh HD -> /
drwxr-xr-x@  3 root           wheel   96 Aug 28 14:45 Recovery
drwxr-xr-x@  6 chandutennety  staff  272 Sep 12 23:29 test_0.1.0_x64
drwxr-xr-x   4 chandutennety  staff  204 Sep 12 23:43 test_0.1.0_x64 1
drwxr-xr-x   4 chandutennety  staff  204 Sep 12 23:46 test_0.1.0_x64 2

So each volume Tauri was mounting was getting a new directory name, but the app I installed had the target name Tauri was trying to mount, so the bundle_dmg script was failing when trying to copy the icon.icns file there. Since the script was erroring, it wasn't cleaning up the volume it just created either. When I manually ejected those volumes, the next build succeeded.
What's interesting is that bundle_dmg seems to have a fix in place for this exact scenario here, but the if condition wasn't being satisfied for some reason. I tried adding echos around there, but the script is regenerated for every build so my statements were getting removed.
Huge thanks to @jbolda for talking me through this on the Discord channel, I'm opening this issue per their suggestion.

Can you confirm that this is still an issue? If so, please feel free to reopen and we will dive back into it.


Allow NIghtscout credentials to be updated within the app settings

Towards #35

awesome I added something similar for Push Notification azure setting. I can remove that and extend this...

@amazaheri yes, by conforming to the ServiceAuthentication protocol, you can get the UI nearly for free.


Extract TomlSource from staert.go

Extract TomlSource from staert.go
Be more clear and more easy to maintain.

Coverage increased (+0.05%) to 79.949% when pulling a5a401f8ebc750e3791d04fb67753f4667ca760f on ldez:refactor/extract-toml-source into 27a544d851fde11d935631c53505b9e5c1a90c50 on containous:master.

Coverage increased (+0.05%) to 79.949% when pulling a5a401f8ebc750e3791d04fb67753f4667ca760f on ldez:refactor/extract-toml-source into 27a544d851fde11d935631c53505b9e5c1a90c50 on containous:master.


A word wrap problem solved

The word warp problem is solved by using DP .
I know you do not assign me this problem but you do not replay me.
so I created a pull request of it.
you can merge it by your choice.

@Naman-12911 please assign this to me.

I already made a pull request. And  I am also a participant.sister.


Informative logging results to be available in app

##Motivation
There is currently no way as far as I know, to verify properly that the app is really sending and receiving tokens in all situations, e.g. when phone is on Battery Saver, Sleep mode etc.
Since the app was tested only on a small subset of devices in a small subset of use case, it's necessary to be able to verify by the interested public at large that the app is doing its job properly under all circumstances and report bugs when this is not the case.
##Suggestion
Please add a way to see communication logs under settings in some sort of way. For example, a time stamp every hour with summary info on how often beacons were sent and how often beacons were read (not how many were seen, just to check that it's running properly). In addition, it'd be good if the logs mentioned if connection to the server is working as expected.
I feel very unsure about whether the app is doing its job properly. In normal usage, many possible bugs are not visible at all. Since one doesn't expect to be positive or be in contact with other positive people.

Thanks @tkowark for discussing this.
One thing that might have got lost, if I'm not wrong you are in charge with the server of exposed keys. So you could provide information of how many exposed keys have been received. This of course doesn't really test core functionality.
That beacons are sent by the phone can be tested by other phones with apps such as this:
https://play.google.com/store/apps/details?id=com.davidgyoungtech.beaconscanner
So at least the sending part can be verified.

There are very many good points made in https://github.com/corona-warn-app/cwa-app-android/issues/518 which was canonicalised to this issue.
Anyone reading this discussion here should check out 518, too.

Interesting showcase: https://twitter.com/merlinchlosta/status/1273293511803244546 (sadly in German). I would really like to see a feature like this. For me, the live accumulated number of received beacons from other devices would be enough (to monitor the functionality). This should be possible even if the API does not support it (yet), just by monitoring Bluetooth directly.

Dear @corneliusroemer and all other contributors that proposed a similar idea,
thank you very much for your proposal.
To give the community a space for discussing new feature ideas or enhancements that might not be taken up immediately by the development teams, we created the cwa-wishlist repository.
This idea is one of these feature ideas or enhancements. Consequently, we will move this issue to this repository and allow the community and you to further refine it, discuss pros and cons, and evaluate alternatives.
The issue will not be closed in this repository to ensure long-term visibility. All issues in the cwa-wishlist repository will be discussed with our contracting entities.  As soon as we have any updates, we will let you know about the details.
Best regards,
TK
Corona-Warn-App Open Source Team


Use opt_secondValue in addBlock as expected

Resolves
Closes #1927.
Proposed Changes
Use the parameter opt_secondValue instead of opt_value where appropriate.
Reason for Changes
opt_secondValue[2] was not used at all in the code, which lead to behaviour seen in #1927.
Test Coverage
No tests were added, no existing tests were broken.

Looks good! Thank you!


feat: install and uninstall plugins to a scene with file upload and repo URL

Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo

#33


Bootstrap custom radio button and check box labels not classed

Current behavior
I am using custom_collection wrapper for radio_buttons but radio button radios are not displaying. This is because labels are not getting custom-control-label class but collection_radio_buttons instead.
So I wondered how simple_form-bootstrap repo implemented it and saw this css workaround.That was basically extending .collection_radio_buttons with .custom-control-label. After adding the stylesheet from the repo I had radio buttons but as square as in the image

Expected behavior
Custom radio buttons with no css hacks
Can Simple Form just add class to radio button label, I couldn't find out. Should we have any other css other than bootstrap like this for simple form to show properly?
P.S I think this is an issue, that's why didn't post it on stackoverflow

Hi @Abduvakilov, thanks for the issue.
Passing the custom-control-label class to the label, would solve the issue?
I'm not sure if it helps, but you can build this custom collection passing a block. See:
https://github.com/plataformatec/simple_form/blob/ccfb22910f454b8e0c9534e3babaaeae59abe83b/lib/simple_form/form_builder.rb#L367


Isolate jackson module used by tooling

Conflicts may happen if the test's classpath contains an older version of jackson.
Exception in thread "main" java.lang.NoSuchMethodError: com.fasterxml.jackson.databind.introspect.AnnotatedConstructor.getType()Lcom/fasterxml/jackson/databind/JavaType;

Fixed at 1945181edeee8bf9b0871286ef1e42b105b8242e