ValueError: offset must be non-negative and no greater than buffer length

Hi, I have a very large jsonl file which I have converted to the memory mapped indexed dataset using tools/megatron_dataset/preprocess_data.py script. The code ran successfully without any errors. However, when I try to find the number of tokens in the final data using the script tools/megatron_dataset/iterate_preprocessed_data.py I am getting the following error
2024-10-27 20:43:55,127 - [INFO    ] ▶ Load the _IndexReader from data/eng.idx
2024-10-27 20:43:55,161 - [INFO    ] ▶  Extract the sequence lengths
2024-10-27 20:43:55,161 - [INFO    ] ▶  Extract the sequence pointers
2024-10-27 20:43:55,162 - [INFO    ] ▶  Extract the document indices
2024-10-27 20:43:55,186 - [INFO    ] ▶ > total number of sequences: 34903181
2024-10-27 20:43:55,186 - [INFO    ] ▶ > total number of documents: 34903181
2024-10-27 20:43:55,187 - [INFO    ] ▶ number of documents in the dataset = 34903181
  3%|███▌                                                                                | 893319/34903181 [00:03<01:54, 295923.18it/s]
Traceback (most recent call last):
  File "~/dolomite-engine/tools/megatron_dataset/iterate_preprocessed_data.py", line 47, in <module>
    main()
  File "~/dolomite-engine/tools/megatron_dataset/iterate_preprocessed_data.py", line 40, in main
    for document in tqdm(dataset):
  File "/usr/shared/conda/dolomite/lib/python3.11/site-packages/tqdm/std.py", line 1181, in __iter__
    for obj in iterable:
  File "~/dolomite-engine/dolomite_engine/data/megatron/indexed_dataset.py", line 444, in __getitem__
    sequence = numpy.frombuffer(
               ^^^^^^^^^^^^^^^^^
ValueError: offset must be non-negative and no greater than buffer length<PHONE_NUMBER>96)

Can you list the commands you ran? Downloaded and processed the data, and got no errors.

Hi,
I've included for you the repo containing the scripts.
python extract_sangraha.py --output <path to output folder>

Once the dataset was downloaded I ran the preprocessing script as follows
python tools/megatron_dataset/preprocess_data.py --input <path to downloaded jsonl file> --tokenizer meta-llama/Meta-Llama-3.1-8B --append-eod --workers 8 --output-prefix <path to save the processed data> --chunk-size 10000

To validate the processing was done correctly, I am running the following script to get total number of tokens
python tools/megatron_dataset/iterate_preprocessed_data.py --path-prefix <path to save the processed data>

I think @shawntan has used the same scripts you shared with me.
Can you check @shawntan ?

Yup I did exactly this. No errors.
Relevant library versions:
open_clip_torch==2.26.1
pytorch-lightning==2.0.7
pytorch-triton==3.1.0+cf34004b8a
torch==2.6.0.dev20241014+cu124
torchaudio==2.5.0.dev20241014+cu124
torchdiffeq==0.2.4
torchmetrics==1.4.1
torchsde==0.2.6
torchvision==0.20.0.dev20241014+cu124
numpy==2.1.2

Thanks, changing the numpy version resolved the issue.


bump to version 03

I suggest merging this before Monday so that we can upload a new
version of the draft to the document tracker before the doc freeze for
IETF99.
If possible let's review/merge https://github.com/Matroska-Org/ebml-specification/pull/152 first.

I agree.


WIP: fix exec

This works perfectly fine now.

Thank you for the feedback. I'll fix the clippy lints on master, rebase this branch and probably merge soon.

Ran tests locally and everything seems fine. There is a problem with CI currently but I'll resolve it in the master branch after merge.


Implement Complete Method for External Tasks

External tasks should be completed using:
client.ExternalTasks["my_task"].Complete(...)


add deploy

deploy.prototxt added

Thanks for your contribution! We will run some tests and let you know if anything needs to be changed. :)

Couple of notes:

We use the default values of lr_mult and decay_mult during training, so there's no need to include them in the prototxt
If I'm not mistaken, bias_filler, lr_mult, etc are all used for weight initialization at the beginning of training, but they have no affect on inference. So, we can probably remove all of these things from deploy.prototxt if we want to keep it simple.

Good suggestions, I have updated the deploy file

Merged as https://github.com/DeepScale/SqueezeNet/commit/445b1d97f8cfd106727e658d17222b24cfddf17d


onDragStart is fired only for the first drag

onDragStart is fired when element is dragged the first and and won't fire again after element is stopped being dragged. Is that intentional?

that's right - onDragStart fires when the drag starts, onDragEnd fires when it ends, and onDrag fires on every step of the drag.

I mean it won't fire in the following case:
Start dragging    <-- Fired
...drag around...

Stop dragging

ah, that is a bug. looking at the code it's not immediately obvious why it's happening. feel free to submit a pr. otherwise i'll take a look later this week.


refactor: align arguments in json service

As suggested in MR #338. To be merged after #338...
Checklist

[ ] This PR makes changes to the public API
[ ] I have included links for closing relevant issue numbers

Thanks for reviewing, it is much better like this :-)


Incorrect behavior in some GROUP BY tests with NULL and MISSING values

          Some conformance tests in `partiql-tests` were ported with this incorrect behavior. Those tests will also need to be updated. Example test: https://github.com/partiql/partiql-tests/blob/main/partiql-tests-data/eval/query/group-by/group-by.ion#L1797-L1817. Similar tests use `GROUP BY p.supplierId_mixed`.

Originally posted by @alancai98 in https://github.com/partiql/partiql-lang-kotlin/issues/1014#issuecomment-1495256002

The issue goes further as GROUP BY with a group key that's just MISSING should result in a group key coerced to NULL rather than MISSING. There are additional tests that have this incorrect behavior.
See this partiql-spec issue for more: https://github.com/partiql/partiql-spec/issues/52


PDI-13367 - ETL Metada Injection does not actualize the Source Step in the Inject Metadata tab when renaming the cited step

@mattyb149 Please, look it.

@mattyb149 The fix was updated.

@mattyb149 @yuryilyukevich Looks like this change has caused an error in all spoon dialogs.  Open a step dialog in any transformation, then click ok.  You'll get an exception complaining about notify listeners.


React does not recognize the x...

Hello, great lib!
I'm getting this warning:
"Warning: React does not recognize the X prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase actiondelay instead. If you accidentally passed it from a parent component, remove it from the DOM element."
for:
actionDelay, destructiveCallbackDelay, fullSwipe, listType, scrollStartThreshold and swipeStartThreshold
Using React 18.2.0
I did not get these when using React 17.
Thanks in advance and keep up the good work!

@OzoBro How did you resolve this?


Add support for director/federation contact info as a configuration

Closes #983
@CannonLock this PR introduced a new object type parameter called Director.SupportContact. You may need to patch in additional UI form for this. Thanks!

@haoming29 Can this have multiple values?

@haoming29 Can this have multiple values? If we only want one contact we should not use the object field here and instead have string fields.

Good point. Yeah I think at the end of the day it's simply two string config params (just happen to have the shared parent node). I'll redo the params and I'll let you know when it's ready.

@CannonLock Just redid the config and we should be good with string values.


PDI-18996 resolution

This patch will resolve the connection leak problem with IBM MQ

:white_check_mark: Build finished in 44m 25s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 5002, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 45m 22s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 5002, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 45m 52s
Build command:
mvn clean verify -B -e -Daudit -amd

:ok_hand: All tests passed!
Tests run: 5002, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:x: Build failed in 3h 11m 2s
Build command:
mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!
Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message

:x: Build failed in 2h 31m 38s
Build command:
mvn clean verify -B -e -Daudit -amd

:exclamation: No tests found!
Errors:
Filtered log (click to expand)

script returned exit code 1

:information_source:  This is an automatic message

:x: Build failed in 5m 3s
Build command:
mvn clean verify -B -e -Daudit -amd -Djs.no.sandbox

:exclamation: No tests found!
:information_source:  This is an automatic message


Run some tests on GitHub Runners

Tests both against 5.0/edge and latest/edge. The network-ovn test was augmented with log grouping which should make it easier to deal with the very long log it generates.
The other tests will slowly grow the same logging niceties but it isn't worth holding off this PR.

The network-ovn test fails at:
  + lxc exec ovn2 --project=ovn2 -- ping -nc1 -4 -w5 <IP_ADDRESS>
  PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.

  --- <IP_ADDRESS> ping statistics ---
  5 packets transmitted, 0 received, 100% packet loss, time 4093ms

But I cannot reproduce locally so I don't want to hold off for this.

@simondeziel log grouping would be great for the lxd test suite too

I've been trying to find why VMs would fail to start from published image only to find that with lvm-thin (only!) we were running out of space:
   Retrieving image: Unpack: 99% (133.94MB/s)
  Error: Failed creating instance from image: Failed converting image to raw at "/dev/vmpool-lvm-thin-2282/images_700b8fbcbaf590b851697fdd2979d4e6328c260e012ed989a702c04e67d47719.block": Failed to run: nice -n19 qemu-img convert -f qcow2 -O raw -T none -t none -W /var/snap/lxd/common/lxd/images/lxd_image_unpack_2331596452/rootfs.img /dev/vmpool-lvm-thin-2282/images_700b8fbcbaf590b851697fdd2979d4e6328c260e012ed989a702c04e67d47719.block: exit status 1 (qemu-img: error while writing at byte<PHONE_NUMBER>: Input/output error
  Retrieving image: Unpack: 100% (134.03MB/s)
  qemu-img: error while writing at byte<PHONE_NUMBER>: Input/output error
  qemu-img: error while writing at byte<PHONE_NUMBER>: Input/output error
  qemu-img: error while writing at byte<PHONE_NUMBER>: Input/output error)
  + cleanup
  + set +e
  + echo ''
  + '[' 1 = 1 ']'
  + echo 'Test failed'
  + df -h

  Test failed
  Filesystem      Size  Used Avail Use% Mounted on
  /dev/root        73G   73G  295M 100% /
  tmpfs           7.9G  172K  7.9G   1% /dev/shm
  tmpfs           3.2G  1.2M  3.2G   1% /run
  tmpfs           5.0M     0  5.0M   0% /run/lock
  /dev/sdb15      105M  6.1M   99M   6% /boot/efi
  /dev/sda1        74G  4.1G   66G   6% /mnt
  tmpfs           1.6G   12K  1.6G   1% /run/user/1001
  + exit 1
  tmpfs           1.0M     0  1.0M   0% /var/snap/lxd/common/ns
  Error: Process completed with exit code 1.

The good thing is I improved the debugability of the script along the way...

@simondeziel let me know when ready for another review, ta

@tomponline things are as good as I can make them ATM so please take another look. The tests all finish in < 15 minutes except for tests/storage-vm which takes 1 hour and will get even longer when ceph is reintroduced. This is something I'll want to split into multiple VMs, probably one per driver but in a subsequent PR if you don't mind.

@tomponline I finally decided to split out the tests/storage-vm into multiple runners, one per driver.


Update rpc-providers.mdx

Liquify here, we've received the grant for running Stellar RPC public infra, would be great to add us to the partners page with links to endpoints available for community.
Info added accordingly to the table but feel free to format it in the better way or list below as public endpoints. Thank you.

Hey @ElliotFriend ! Thank you for confirming! I don't see the info on the main docs page: https://developers.stellar.org/docs/data/rpc/rpc-providers#ecosystem-providers
can you double check please?

Hi @Roman-Liquify! It can take several minutes for the content to show up after a merge. I see Liquify there now!

However, I am getting errors when clicking the links for Futurenet, Testnet, and Mainnet. Are there other links we can put there?

This is expected as RPC doesn't actually serve any response at it's root url in the same way that Horizon does. You'll probably notice the same issue for the SDF links in the below table. I sanity-checked the health endpoint for each of these and they do indeed work. For example:
$ ~  > curl -X POST 'https://stellar.liquify.com/api=41EEWAH79Y5OCGI7/testnet:443/' \
--header 'Content-Type: application/json' \
--data-raw '{
  "jsonrpc": "2.0",
  "id": 10235,
  "method": "getHealth"
}' | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   194  100   132  100    62    222    104 --:--:-- --:--:-- --:--:--   327
{
  "jsonrpc": "2.0",
  "id": 10235,
  "result": {
    "status": "healthy",
    "latestLedger": 492795,
    "oldestLedger": 475516,
    "ledgerRetentionWindow": 17280
  }
}

Correct. These are working public endpoints which require no platform login or any registration, so it's different to other providers on the list.
Ideally if you can list them similarly to SDF format, that would make more sense, I've just followed the current format.
Would it make sense to put them under SDF's?

Hi @mollykarcher , @ElliotFriend I don't see our endpoints on the page anymore, is there a better suggested format I can follow?

Fixed: https://github.com/stellar/stellar-docs/pull/822

@Roman-Liquify Hope you are well. I was wondering if you could whitelist lab.stellar.org.
We tried to input https://stellar-mainnet.liquify.com/api=41EEWAH79Y5OCGI7/mainnet in https://lab.stellar.org/ as a mainnet RPC but then saw that the requests are blocked by CORS. If you could whitelist the lab, it will make it much easier for developers to use your mainnet endpoint with Lab.

Thank you for your attention!

Hello @janewang , apologies for the delayed reply, we are currently resyncing the nodes and once added to the load balancer we'll fix the CORS issue. I'll update here once done


ServiceProvider::register() may pull app('log') from container before config('logging') has been loaded

Lumen specific
ServiceProvider::register() is calling app('log') to check if it should register as channel.  This, of course, has a side effect of instantiating the logging interface.  In Lumen, this could happen prior to $this->app->config('logging') resulting in an incorrect configuration of the logger.
Within the instanceof Lumen check, it seems like both 'sentry' and 'logging' configs should be loaded.

Interesting. However I do feel this is "correct" behaviour.
Lumen is a bit odd in that you can indeed register the service providers before loading your config but this seems incorrect since config might be used to register service providers (as in this case).
However this is also a bit of a chicken and egg problem we might not be able to fix. Because you can't add Sentry as a logging driver before it's registered and it needs to be registered before the logging service is booted. Also configure is always called before loading the LogManager (https://github.com/laravel/lumen-framework/blob/0f450f8d6ee47bdef6c88a2492883c6e48a33a95/src/Application.php#L451-L458) so this is only an issue when using your own config files.
My advice would be to always configure your config's before registering any service providers (always do you configuration here for example).

As general practice, we do -- but, of course, then we want Sentry registered before the config loaders just in case there is an issue in one of the configs, so we pull it ahead.  It was easy enough to repair by loading the logging config earlier as well, just a unexpected side effect.


Print a line per downloaded crate

This commit brings back the old one-line-per-crate output that Cargo's
had since the beginning of time but was removed in #6005. This was
requested on our users forum

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

r? @ehuss

I tried this locally and I am happy with the behavior. Thanks!

@bors r+

:pushpin: Commit ef7e98f545d192db69c946993c34c95521d9f0d4 has been approved by ehuss

:hourglass: Testing commit ef7e98f545d192db69c946993c34c95521d9f0d4 with merge a0e3077d745e0b5838da9b90cb92e99d4ad99656...

:sunny: Test successful - status-appveyor, status-travis
Approved by: ehuss
Pushing a0e3077d745e0b5838da9b90cb92e99d4ad99656 to master...


Add documentation for OCSF field mapping and correlation engine API

Description
Adds documentation for OCSF field mapping types, and adds APIs for correlation engine.
Issues Resolved
Fixes #4500
Checklist

[ ] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

the ocsf logs integration piece looks good but correlation engine api documentation is missing.

@sbcd90 @getsaurabh02 Yes, I could use some help with a few field/parameter descriptions. Those will be conspicuous with the "TBD" placeholder. The last thing I need is a screenshot that shows the log type selectors with VPC_Flow (or however that is labeled). Thanks for looking.

Merge conflicts from same edits on different branches.


Add GP3 As a Valid Volume Type

Describe the bug
The Linter does not recognize GP3 as a valid volume type.  "You must specify a valid value for VolumeType (gp3). Valid values are ["gp2", "io1", "io2", "sc1", "st1", "standard"]"
To Reproduce
Steps to reproduce the behavior:

Are you testing a QuickStart or Custom template? I am running a template with GP3 configured through taskcat

Attach or link a copy of the template if possible (remove any sensitive info)  You can use any template just change the volume type to GP3.

Provide the parameters that you passed. (remove any sensitive info) gp3 instead of gp2

How did you install taskcat? (docker or pip3) Taskcat is not the issue.  The linter needs gp3 added.

Are you using a profile, an instance role or  access keys to run taskcat?  N/A

Is your AWS environment configured via aws configure? Yes

Expected behavior
A clear and concise description of what you expected to happen.
It should accept GP3 as a valid volume type.
Screenshots
If applicable, add screenshots to help explain your problem.
Sample Error:
[ERROR  ] : Linting detected issues in: /home/girvenj/quickstart-microsoft-activedirectory/templates/ad-2.template
[ERROR  ] :     line 336 [3030] [Check if properties have a valid value] You must specify a valid value for VolumeType (gp3). Valid values
**Version (Please make sure you are running the latest version of taskcat)

Taskcat Version (ex: [2018.817.210357])

Note: Python Version (python3 required)
To find versions:
Via taskcat: taskcat -V
version 0.9.20
Via pip3: pip3 show taskcat
Name: taskcat
Version: 0.9.20
Summary: An OpenSource Cloudformation Deployment Framework
Home-page: https://aws-quickstart.github.io/taskcat/
Author: Tony Vattathil, Jay McConnell, Andrew Glenn, Santiago Cardenas, Shivansh Singh
Author-email<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>License: Apache License 2.0
Location: /home/girvenj/.local/lib/python3.8/site-packages
Requires: docker, PyYAML, jsonschema, botocore, cfn-lint, pip, reprint, mock, yattag, requests, boto3, dulwich, dataclasses-jsonschema, setuptools, tabulate, jinja2
Required-by:
Note: both version should match
To update taskcat run:
for docker : docker pull taskcat/taskcat
for pip3: pip3 install --upgrade taskcat
Additional context
Add any other context about the problem here.

We inherit the linting behavior from cfn-lint. I suspect that the underlying CloudFormation specfiles haven't been updated to reflect gp3 volume types.
As a courtesy, I've copied this over to https://github.com/aws-cloudformation/cfn-python-lint/issues/1829 for tracking

released in cfn-lint 0.43.0:
pip3 install cfn-lint --upgrade


open graph: Use uploaded realm icon for open graph images.

Testing Plan:
GIFs or Screenshots:

I'm not sure if we should just set OPEN_GRAPH_IMAGE instead of setting OPEN_GRAPH_IMAGE_USE_REALM_ICON and using the realm_icon from the context.

I think using OPEN_GRAPH_IMAGE is probably more robust/future-proof; also avoids duplicating code.

@timabbott I've updated this PR to use OPEN_GRAPH_IMAGE context variable.

@punchagan oh, what I'd had in mind is something more like this:
+{% if OPEN_GRAPH_IMAGE %}
+<meta name="twitter:image" content="{{ OPEN_GRAPH_IMAGE }}">
+{% else %}
 <meta name="twitter:image" content="{{ realm_uri }}/static/images/logo/zulip-icon-128x128.png">
+{% endif %}

and make the value of the URL be computed in Python code.

@timabbott updated this. Let me know if it needs any more changes. :)

Looks great, merged, thanks @punchagan!  @rishig FYI.


feat: improve integration testing of generated projects template

Make every test executable in single mode and diffrent envs

Works for now with eca61fa65657603e845edb60f853188ab0346f6a.
Consider only running integration tests on test env. This needs changes in melos scripts and integration_test of root package.


Update issue templates

Re-added Issue Checklist

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[ ] 1. Review all computer code.
[ ] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[ ] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[ ] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[ ] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[ ] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[ ] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[ ] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@alfoa Could you add the PR checklist? I did not find it in the PR.

@wangcj05 added

see issue #1067

Tests are green and checklist is ok. This PR can be merged.


Implement physics bodies known to Spaces

Right now, the relationship between Character and its Space is one-directional: the Character defines a camera-position which is, by its own efforts, affected by gravity and collision with the Space.
Instead, the Space should have Behaviors which are attached physics bodies and optionally linked to Characters. This will enable:

Space's block manipulations being affected by the presence of characters (as obstacles or otherwise).
Objects, like moving dropped items, which are purely subordinate to the Space.
Rendering characters that aren't the player (NPCs or multiplayer PCs).
Particle systems that collide with the world. (I'm thinking that dropped items and particle systems might be very closely related things.)

The reason that these should be space Behaviors and not their own kind of thing is because Behaviors should in general be able to “occupy” certain regions of space and influence what happens in them. (On the other hand, we could also have a world where a Space contains Bodys in the same way it contains Blocks, and the Bodys can have Behaviors themselves.)

Behaviors should in general be able to “occupy” certain regions of space and influence what happens in them.

This is now implemented; the "attachment" field stores a bounding box. No progress yet on making bodies into behaviors.


Regression in rendering, found in Go Package Store.

Continuing discussion from https://github.com/shurcooL/Go-Package-Store/pull/84#issuecomment-330689656. /cc @slimsag
Doing git bisect was quite hard, because most of the commits on master branch of vecty don't compile. That's because they were WIP commits as part of a larger branch/PR which got merged via merge commit strategy. Had it been squashed when merging, it'd be much faster and more reliable to find out the first bad commit.
Anyway, here's what I got:

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
e851c9bf88709d4ac28999e65248cd57207d09b0
b536fe5bdfd03ddb86eb2cc27ce2961756896612
fada4c185ccf6f05ec69cdaf476c9cf8a59503e9
a9db19f71680196e6ef49ffe77eda47c6258be28
f85cef70b337144785413ef528dc27080c6339ce
df133f3e38d8d450bd1567b4c77e65f8d9d1f09f
We cannot bisect more!

All those commits are a part of PR #130, so that's the PR that caused this regression.
I'll read more about the changes of that PR and see if maybe I need to change my code to work correctly.

@shurcooL can you provide steps to repro?

Go Package Store server is running at http://localhost:7043/updates.

Then open browser and visit http://localhost:7043/mock.html. Open dev console, do empty cache and hard reload.
Wait 15-20 seconds as the mock packages are served and displayed. Note when the "Checking for updates..." text disappears at the end, the list of displayed packages changes (first package gets duplicated, 4th one gets removed). It shouldn't.

Thank you, any way to build the frontend with sourcemaps so I can attach a debugger?

Sorry, unfortunately, I haven't yet added support for sourcemaps to gopherjs_http package.
You could use the gopherjs build to get them there, but that's gonna take some manual work.
Also, I want to note it's possible the issue is because I haven't added `vecty:"prop"` struct field tags anywhere.

Also, I want to note it's possible the issue is because I haven't added vecty:"prop" struct field tags anywhere.

I suspect that's the case: the Checking for updates... child gets mutated into the first Presentation, since that's now the first child for the next render and the child changes type, but the subsequent Presentations don't get updated, due to missing vecty:"prop".

I suspect just tagging the embedded *model.RepoPresentation would probably do the job, what's the trick to get the frontend to recompile?

Just reload in the browser. When you use the dev build tag, it always builds from source.
I'll give that a try, thanks!

Yeah, that seems to have worked. I've made this one line change:
// RepoPresentation is a component for presenting a repository update.
//
// TODO: Dedup with workspace.RepoPresentation. Maybe.
type RepoPresentation struct {
	vecty.Core
-	*model.RepoPresentation
+	*model.RepoPresentation `vecty:"prop"`
}

And the issue appears to be resolved.

This is unexpected to me because I thought #130 and the prop tag only mattered if I were using Restorer interface, which I wasn't. I'll have to spend some time to understand #130 better, and where else I might need to apply the prop tag.

Whilst the changes in #130 did remove Restorer, the impact was much more pronounced than that.  As a result, anywhere a Component is instantiated inside Component.Render(), with fields set from the parent, those fields need to be tagged with vecty:"prop".  The problems we were trying to solve are detailed in #115.
Primarily we aimed to allow components to persist state between renders, and to make component behaviour consistent between components that are declared inline during Component.Render(), and those that are supplied as references that persist across renders.  Now, component fields will persist across renders automatically, provided children are stable, with the caveat that parent-set fields need to be tagged.  We obviously haven't done much to communicate how these changes work, and how they're best exploited, however there are still changes to core functionality under way, so I expect some documentation to follow once things settle down a bit, and I expect that documentation will provide sufficient clarity.  If the approach we've taken here turns out to be troublesome for users to understand though, I suppose we may re-examine it.
I've taken a quick look at your GPS components, and they could be made significantly more efficient by avoiding shuffling elements around, and making use of vecty.List to segregate some children, I could perhaps take a pass over it at some point and include some notes, if you're interested in seeing what that would look like?

If you don't mind, I'm certainly open to considering improvement suggestions, thank you. I'll spend some time reading and learning more about #130, thanks for providing the information.
Also, I think we can close this PR since this appears to be invalid use of the new Vecty API in GPS rather than a bug in Vecty. Feel free to do that if you agree.

I have an itch that we may want to review the new API once it settles to confirm that we've arrived at the right conclusions, so I wouldn't mind keeping this open, but renaming it to reflect that task and serve as an exemplar.  Alternatively, maybe we just open a new issue and link to this one.  I'm not an org member though, so I can't manage issues - I'll leave it to @slimsag to make the call/changes.

(sorry for the delay, I've been quite busy at work)
Sorry about missing the prop needed for that component! Also, the lack of documentation / clarity around recent changes is one of the reasons why I sent a PR to all in-the-wild projects I am aware of using Vecty currently :) But also to ensure we didn't have any regressions, so I really appreciate you creating this issue and tracking down the cause!
I agree about using this issue to ensure we've arrived at the right API conclusions by confirming in a real-world app like Go-Package-Store so I'll change title to that. If you think it should be named/moved elsewhere just lmk :)

Following up on the vecty:"prop" change. I've applied it in shurcooL/Go-Package-Store#88. It helps fix the originally spotted rendering issue. However, it doesn't completely make the rendering correct, there is now a new rendering issue that appears. I've described it in full detail at https://github.com/shurcooL/Go-Package-Store/pull/88#issuecomment-335552858.

I'll be able to take a look at this Friday night or over the weekend, I think. My initial guess would be that you need to implement Keyer somewhere.

I thought Keyer is an optional enhancement for optimization, but it shouldn't be neccessary for correctness. Is that not the case?

That is correct @shurcooL.

@shurcooL pdf is completely correct, Keyer is only an optional enhancement for optimization. I was not thinking correctly when I suggested needing to implement Keyer -- apologies for misleading.


:bug: Update generic and golang dep provider deps

Needed for cachito to work properly

Please hold until CI is green


syz-verifier: fixes the crash of the app run w/o parameters

syz-verifier crashes when is executed w/o parameters.
This change fixes it and makes printUsage() a default behavior.

Please merge once the tests pass.


[Bug]: 404 error at URL: /txns/oES7Z_SjZkawiFqbMtpCr7krjAl8nGkDPN1kiETvLME

What happened?
A bug happened! I cashed out of my earnings 10 hours ago and when I looked it up on the explorer this showed up please help
URL
https://explorer.helium.com/txns/oES7Z_SjZkawiFqbMtpCr7krjAl8nGkDPN1kiETvLME
What browsers are you seeing the problem on?
Safari
Do you see the issue on Mobile or Desktop?
No response
Relevant log output
No response

works now, closing.


making collection of api

AsslamuAlikum
So i am making a collection of apis
in one api
i wanna ask if i can use your api as my endpoint which giving your api credits?
Am i allowed to do that?
https://api.islamiq.me
this is the api where it will be shown (the endpoints)
i would be happy and apprieciate if you allow me
Jazak Allah!

yes you can use

Also there is hadith-api, you can also add that in your api if you like

Jazak Allah Brother, May Allah bless you In-Sha-Allah, I will use both apis

ah sorry i was on other account

Jazak Allah Brother, May Allah bless you In-Sha-Allah, I will use both apis


Display roles in alphabetical order

So that it's quick to see who has which roles, when calling @PockyBot roleconfig get, roles should display in alphabetical order.

:tada: This issue has been resolved in version 1.17.0 :tada:
The release is available on:

v1.17.0
GitHub release

Your semantic-release bot :package::rocket:


Cell execution is faster in the background

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
Expected: Notebooks execute as fast (or faster) in the foreground as when looking at a another tab.
Experienced: Switching to another tab can speed up the execution of Python cells.
Steps to reproduce:

Create a new notebook.
Create a cell with a heavy computation, e.g.:

for i in range(10_000):
    [i**3.5 for i in range(10_000)]

Run it (took 15.1s on this laptop).
Run it again but immediately switch to another tab (e.g. by CTRL+N).
Wait for a bit and then check the time (took 9.5s on this laptop).

In this case I get only a ~30% time saving by switching to another tab, but anecdotally I've seen more than 50% (for some heavy seaborn plots).
VS Code Version
Version: 1.72.0 Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e Date: 2022-10-04T23:20:47.539Z Electron: 19.0.17 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: <IP_ADDRESS>-electron.0 OS: Linux x64 5.15.0-48-generic Sandboxed: No
Jupyter Extension Version
v2022.9.1002791758
Jupyter logs
No response
Coding Language and Runtime Version
Python v3.9.7
Language Extension Version (if applicable)
v2022.16.0
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
Local

For me, it takes about 10s whether in the foreground or background, pretty consistently after trying several times. With this code, I don't see how we could be affecting it because that time is just python running code. If you see a difference in something that is renderer heavy, esp that produces streaming text, that could actually make sense because when a tab is in the background, we might save time by not actually rendering the intermediate result. Are you sure you see a large difference reliably with that code above?

I tried the same on another computer, and didn't see any difference. So back on the original laptop I monitored active processes and found that two VS Code processes consumed CPU while rendering the "cell is executing" animation (which obviously wasn't showing when I switched to another tab). Curiously, disabling hardware acceleration in VS Code almost removed the overhead completely (I'm not sure why yet).
In summary: showing the "executing" animation had a much greater CPU overhead than I thought possible (on this not very impressive laptop). And, due to the improvement when disabling hardware acceleration, I think the issue is not with this extension.


Add killall command

Useless commits - R.I.P Fantasy's hand after all of the clicking he has to do.
Meh, I felt like adding this after the awareness thanks to @cowpits :)

@AlexHGaming What editor do you use? I use Notepad++, it adds tabs automatically.

@ZfsrGhS953 Visual Studio Code 2017

@ZfsrGhS953 but with this, it was the github editor, all it was, was just copy and paste out the code of VSC, then put it in the github, add the writeline & shit & done XD

what mess have I gotten myself into now?
thanks for the commit @AlexHGaming you rock and you helped me sort out the duh moment i had lol.

@cowpits haha no problem man remember you have my discord when you need me.

@AlexHGaming Instead of copying and pasting the code into github, use git.

🤔


net: ipv6: mcast_routing: hop limit handling

While forwarding a multicast packet decrement hop limit in a common net buffer. Also, packets with hop limit equal to 0 should not be forwarded.

Looks good, but the CI fails as hdr is a const pointer. I think it should be no harm to drop const in this case.

Or move it to the calling function? Which would make most sense?

ping @konradderda, do you have time to check what is going on with the tests as they are failing after the changes?


remove https from the heroku link for Census WDC

Hey @port80labs, I was testing your connector and I am having trouble getting it to run inside Tableau. When I try to run it (both the http and https version), I get the following error when the page loads: "ReferenceError: Can't find variable: _wdc file: undefined line: 1".  Nothing appears to happen once I hit Get Data either.  Are you seeing the same thing?
I know this was working previously for me when I checked it out a few weeks ago (awesome connector by the way!).

you are right.. let me see whats up. /ht

Any update on this, @port80labs ?

@port80labs I am closing this since we never received an update and we have a new process for submitting connectors to the community gallery now.  http://tableau.github.io/webdataconnector/docs/wdc_hosting_and_submissions


[WIP] A drop-in replacement for the D3 SVG axis

Fixes #466
This is a drop-in replacement for the D3 scale, with the aim of making it conform to the decorate pattern (which I think is quite central to d3fc). The implementation differs from the D3 equivalent in a few ways:

Uses SVG path for the ticks rather than line, this makes the code simpler by using a 'transpose' function that can transpose an SVG path supporting vertical / horizontal axes
D3 does not ship with CSS, as a result the axis implementation 'manually' positions / styles the labels. This implementation has CSS making the label positioning a bit simpler.

I've also pulled out a few scale related utility functions.
One thing I want to debate is the axis structure and the impact it has on CSS. Currently we rely on the axis being added within a g with a class of axis. This feels a bit fragile. There are two options:

The axis component adds a g with this class.
The tick containers have additional classes added that allow us unambiguously target them with selectors, perhaps having a class of axis tick orient-bottom.

I am not keen on (2) because it results in a lot of repeated information. My preference would be to pull the common information into a container g with a class of axis orient-bottom.
TODO (before merge)

[ ] Add documentation
[ ] Finalise the CSS

Anyhow, any feedback or comments relating the CSS / axis structure would be welcome.

I am not keen on (2) because it results in a lot of repeated information. My preference would be to pull the common information into a container g with a class of axis orient-bottom.

I'd rather avoid containers if they're not necessary, is there really that much duplication?

Looks good, I especially like the new fc.util.scale it's long overdue! I wonder if we need some examples of decoration to really prove it's usefulness though?

@chrisprice thanks for the review feedback, some very useful comments.
TODOs:

[ ] use fc.util.datajoin to create the domain path
[ ] try moving isVertical() into the helper functions to see if it results in simpler code
[ ] ensure orientation changes function properly
[ ] test and expose decorate
[ ] be self-consistent regarding ordinal axis identification

I wonder if we need some examples of decoration to really prove it's usefulness though?

I'm actually working on that right now on another branch. We've got a good 'quick start', and component documentation but nothing much in between.
I'm doing the following:

Moving the 'getting started' from the README.md into the site, this should make it less likely that this code will be out of synch again (as per #485)
Adding a page that describe decorate

Basically I think we need some documentation that sits in between the very high-level quick start and the much more detailed component docs.

@chrisprice - all updated and documentation added. Let me know if you spot anything else.


expand-response-params: explain what a "response file" is

Description of changes
I hadn't heard of this term before, so I assume other people might not have either.  This commit adds a comment to expand-response-params explaining what a "response file" is.
Most mentions of "response file" in Nixpkgs are near some kind of reference to this derivation, so anybody trying to figure out what

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

this is will encounter this comment pretty quickly.

https://github.com/NixOS/nixpkgs/pull/262675


Fix semantic releaase workflow

What kind of change does this PR introduce?
Bug fix for semantic release as it's currently borked.
What is the current behavior?
Python semantic release no longer has a master branch so the CI/CD breaks
What is the new behavior?
I've pointed to the main branch of python semantic release and CI/CD should be fixed now
Additional context
Add any other context or screenshots.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (64a8ab2) 84.70% compared to head (3a00104) 84.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   84.70%   84.70%
=======================================
  Files          12       12
  Lines         451      451
=======================================
  Hits          382      382
  Misses         69       69

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SubOmniglot dataset

In DataContainer.__init__, there are self.data_train, self.data_test, self.data_val defined. Each of the self.data_* is a list of SubOmniglot in which it also defines methods such as .train(), .eval(). However, I do not understand why SubOmniglot requires such methods. Are they ever used?
If I understood correctly, DataContainer handles which SubOmniglot datasets are going to be used as train / test / val tasks. Could a SubOmniglot be a part of data_train but at the same time satisfy self._train == False?
https://github.com/amzn/metalearn-leap/blob/1436ee3029bf5de7cd8e317b9bbf56ff02f46a6c/src/omniglot/data.py#L232-L247

DataContainer manages things on a task level (train, val, and test tasks),  SubOmniglot handles things on a data-point level.
More specifically, each task is a SubOmniglot instance, and each task has a train and eval set. For each task, we adapt task-learners on the task's train set and evaluate the adapted learner on the task's eval set: see here.
Consequently, a train task (aSubOmniglot instance) has both a train and eval data set, and likewise for val and test tasks.

Oh I see! Thanks for the clear explanation :)
Closing this one 👍


Type TabDirective is part of the declarations of 2 modules: StateModule and TownshipModule!

I am trying to implement TAB,Pagination like some functionality in your application is is working fine only for a single module. So can you help me how to inject these module globally so that the issue can be resolved.
@NgModule is new to me so i can't able to understand before i able to do with Rc-1,2 by injecting in every component is was working.Now if am injecting in every component i am facing this issue.
I have two Modules StateModule and TownshipModule
stateComponent.ts
import {Component, ViewEncapsulation,OnInit} from '@angular/core';
import {PaginatePipe, PaginationControlsCmp, PaginationService} from 'ng2-pagination';
import { StateService } from './state.service';
@Component({
selector: 'state',
encapsulation: ViewEncapsulation.None,
styles: [require('./state.scss')],
template: require('./state.html'),
directives:[PaginationControlsCmp],
pipes: [PaginatePipe],
providers: [StateService,PaginationService]
})
export class StateComponent implements OnInit{
public states:Object[] = [];
loading: boolean=false;
constructor(private _stateService: StateService) {
this.loading=true;
}
ngOnInit() {
this.getStates();
}
getStates() {
this._stateService.getStates().subscribe(
data => { this.states = data;
this.loading = false; },
err => { this.countries_error = true; }
);
}
}
Here I am trying to implement Pagination

As mentioned in the ng2-pagination's readme, you need to import Ng2PaginationModule and put it in the imports array of a module that will use pagination (in your case, you can include it in both StateModule and TownShipModule). Next, remove PaginationControlsCmp and PaginatePipe, as well as PaginationService.
The whole point of NgModules is to reduce the number of imports and declarations you need to have in your file. Here, you simply import the whole module and do not have to worry about including the component or pipe every time you want to use it.
If you have any further problems I am more than happy to help you.
I would recommend pasting your code around triple backtick (`) blocks, it makes it easier to read. Alternatively, you can use the Insert code button, located in the top bar of this editor.


Update os-rootfs 0.8.7

Update to os-rootfs v0.8.7 to have /sbin et al in user pirate's PATH.
Connects to #107

ping @DieterReuter

LGTM.


Update rpi.md

Does anyone have any suggestions for how to accomplish this?

Perhaps a reference to or copied text from "man 5 interfaces" on the Raspian Jessie? For example: "The manual page for the interfaces file explains the 'manual' option as follows:
This method may be used to define interfaces for which no configuration is done by default. Such interfaces can be configured  manually  by        means of up and down commands or /etc/network/if-*.d scripts.
and the 'dhcp':
This  method  may  be  used  to obtain an address via DHCP with any of the tools: dhclient, pump, udhcpc, dhcpcd. (They have been listed in        their order of precedence.) If you have a complicated DHCP setup you should note that some of these clients  use  their  own  configuration        files and do not obtain their configuration information via ifup.
For more information, see man 5 interfaces"
Or, more simply "For more information see man 5 interfaces".
There are many details that could be explained here about how the Linux networking scripts operate, but discretion should be used, as the purpose of the walkthrough is not a Linux class, but how to get openAPS working.

@vincepf sounds like a good solution to me, can you PR that in? (feel free to open a separate PR to target openaps:master, and when we merge can comment here to link to that as resolution)

Added PR #513 with changes per above.

Fixed with #513 I believe.  Please open a new PR if you have any other suggestions.


text-align-last.  See

text-align-last.  See: http://www.w3.org/TR/css3-text/#text-align-last

This issue was imported from Google Moderator
Moderator votes: +4
Issue added by Alan on 2012-08-16
To vote this issue up or down, simply include +1 or -1 in your comment.

Already added at http://caniuse.com/#feat=css-text-align-last


How change port from 3000?

how do I change the default port from 3000? also, If I'm serving this behind my webserver, do I need to configure my FQDN for reverse proxy?
I'm also not able to connect to the local service from another machine on my lan: <IP_ADDRESS>
 Not Found: /

Details
Chome Version 57.0.2987.133 (64-bit)

OS version: Windows 10

master 18a9f05 Merge pull request #628 from saulcosta18/patch-1

Steps to reproduce

Launch browser on LAN from remote machine:  http:<IP_ADDRESS>:3000
LOCALHOST:3000 works fine on the server where xterm.is running.
Firewall disabled.

Hi @seanvree, xterm.js is a front-end library so it has nothing to do with ports.
If you are talking about the demo though, just run the following command in your terminal and you should be ready to go:
PORT=11235 npm run dev

😄

thanks @parisk ,
I'm still a bit confused about the CMD tho.

are you sure the PORT attrib goes before NPM? when I run that command I get 'PORT' is not a recognized cmd?

C:\WINDOWS\system32>cd C:\xterm

C:\xterm>PORT=8200 npm run dev
'PORT' is not recognized as an internal or external command,
operable program or batch file.

C:\xterm>port
'port' is not recognized as an internal or external command,
operable program or batch file.

C:\xterm>nohup PORT=8200 npm run dev
nohup: ignoring input and appending output to 'nohup.out'
nohup: failed to run command 'PORT=8200': No such file or directory

C:\xterm>npm start PORT=8200

><EMAIL_ADDRESS>prestart C:\xterm
> npm run build

><EMAIL_ADDRESS>build C:\xterm
> gulp build

[09:26:31] Using gulpfile C:\xterm\gulpfile.js
[09:26:31] Starting 'tsc'...
[09:26:34] Finished 'tsc' after 3.21 s
[09:26:34] Starting 'browserify'...
[09:26:34] Finished 'browserify' after 231 ms
[09:26:34] Starting 'sorcery'...
[09:26:34] Finished 'sorcery' after 66 ms
[09:26:34] Starting 'build'...
[09:26:34] Finished 'build' after 41 μs

><EMAIL_ADDRESS>start C:\xterm
> node demo/app "PORT=8200"

App listening to http://<IP_ADDRESS>:3000

```

So what am I doing wrong?

I see. My instructions were for Unix-like systems like macOS and Linux.
Not sure how you can set environment variables on Windows tbh.


Option to delete profile picture and hero image and get the default token back instead

Both user avatars & group cover photos can now be deleted.


⚠ Secret Website 3 has degraded performance

In cead4dc, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2011 ms

Resolved: Secret Website 3 performance has improved in 20e0d88.


[libra framework] Update documentation of scripts

Fixes some TODO comments in the transaction scripts and adds a brief introduction to the transaction script overview documentation.
This PR is documentation only. The rendered updated overview document is here

Good question. The .abi files changed since they also include the doc comments for the scripts. The only implication of this would be that the comments in the various transaction builders would be updated when they're regenerated (you can see this here)

/land


chore(actions): update github actions to remove deprecated methods

Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>Why is this PR required? What issue does it fix?:
Github actions deprecated the set-env command. Instead of that environment files are the recommended option now.
What this PR does?:

use environment files in github actions instead of deprecated set-env command

Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
A minor change in how environment variables are set in github actions
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #507 (e382d71) into master (4119e95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   47.47%   47.47%
=======================================
  Files          73       73
  Lines        3311     3311
=======================================
  Hits         1572     1572
  Misses       1579     1579
  Partials      160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4119e95...e382d71. Read the comment docs.


add Rae-OA-Wechaty blog

Fixes # .
Make sure these boxes are checked before creating your pull request -- thank you!

[x] Add Blog Header, including title, author, date.
e.g.

---
 title: "'Score Your Face Photo' a ML&Wechaty practice"
 date: 2017-09-18 09:00 +0800
 author: huyingxi
 ---
 > Author: [@huyingxi](https://github.com/huyingxi/wechaty_selfie) enjoying ML&Wechaty at BUPT

[x] Keep all filenames & url as lowercase, and use - to connect words instead of space. e.g. 2017-10-06-wechat-pc-impactor instead of 2017-10-06-WeChat PC Impactor,
[x] Embed the photo & video before publishing, save all external file to the blog /download/2018 directory.
[x] Add <!--more--> section to just show the abstract in blog homepage.
[x] Add teaser image for the blog
[x] Add your self as an author to the author data file at https://github.com/wechaty/wechaty.github.io/blob/master/_data/authors.yml with your GitHub username. And please also remember to reference yourself with the Github username in your blog post, so that we can have nice author information besides your blog after we published it!

See more

sth may be wrong...

Sorry for mis push since the blog immigration.
Could you upload your local file to this PR again and then I will be able to review this again.
Sorry again for my mistake.

It looks good to me.
Please check this blog to see whether we could merge or not. @huan

finally.....

Congratulations! 🎉 🎉 🎉
You become a wechaty contributor successfully! 👏 👏 👏
Please:

[ ] Update your profile here: Contributor List, then other contributors will know you better!
[ ]  Join wechaty org by clicking https://github.com/wechaty
[ ]  Add my wechat: ruirui_0914 and send me this pr link. I will invite you into Wechaty Contributor Room


Give a higher "height" to the select[multiple] input in form.

When creating new resources and in the form we have select inputs like the ones below they both look the same way in the UI even the second has the option multiple: true enable.
f.input :company, as: :select, collection: Company.all

f.input :product_categories, as: :select, collection: ProductCategory.all, multiple: true

Actual behavior

For a better user experience when selecting multiple options from select elements, it should be possible to the user to see more than one option at a time. And, by giving a higher CSS height property value to select elements with multiple attribute, we solve the problem.

Expected behavior

Thanks !


Food use

🐛 Bug Report
Hello I notices after the food use update has rolled out. Whenever you use the “y” command to send your minion out on a new trip it doesn’t need any supplies. I don’t know if this is only the case for ironmen since my bot is an ironman.

food requirements were reverted, after feedback said it was too much, so its being rethought


PWA - iOS error when loading

Hello
I have been having trouble getting a PWA version (saved as an app) to work on an iOS iPhone.  It works pretty much everywhere else (ios when using the browser, android on the browser and as an app on a phone, desktop iOS, etc).
I have recreated the basic example:

code here
deployed it to netlify.

After you save the app to the home screen (through safari), the app asks for permission to access the camera, after I tap allow, it just stays on the loading screen forever.
When I try to debug it through safari web tools,  there are no errors in the console, but in the elements view it shows the "Failed to launch :( ... please try the following recommended browsers:" elements.
From looking at the other past issues on GitHub people seem to see that message when they're not using HTTPs, but this is deployed to netlify and thus I believe it should be secure?
Been banging my head on this for awhile and am not sure where to go next, appreciate any help.
Cheers

What do you mean "save the app to the home screen"

Sorry, should have updated this, I got it past this point, something was cached in safari that prevented this interaction for me.
There is one problem with A-Frame and working offline with Safari though.  It makes a call to check whether the src passed into the a-image element is actually an image.  Even if you have an image cached safari tries to make the call, which errors and stops the whole process.  I had to prevent this call that A-Frame does to make the cached images work offline.  Hopefully, this helps someone


Consolidate Test Cases to Reduce Resource Consumption

[ ] consolidate labels tests
[ ] consolidate taints tests

closing this; a review of our test cases actually reveals that we're being fairly frugal with instance counts and options consolidation.


Add local minima detection routine

It's quite possible we'll change the base map params in the future (different obstacle size, strenght... differnet goal strenght)
Add logic to detect and warn about local minima the robot coudl get stuck in.

One way to do this: write a unit test case that loops:
for all goals:
for a grid of X/Y start positions:
set pose = start poisition
while(pose not at goal):
pose = pathplanner.update(curPose)
if(too many steps):
Fail
Pass
This will be a long testcase, but it can exhaustively show that we can plan from any start spot to any goal without getting stuck.


Added missing FR translations for PhoneNumber validator

Any news ?

Thanks, @bfolliot! Merged to develop for release with 2.6.0.


Release v2.2.0

Codecov Report
Base: 81.81% // Head: 84.61% // Increases project coverage by +2.79% :tada:

Coverage data is based on head (99bb203) compared to base (8f144f8).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   81.81%   84.61%   +2.79%
==========================================
  Files           1        1
  Lines          11       13       +2
  Branches        1        1
==========================================
+ Hits            9       11       +2
  Misses          2        2

Impacted Files
Coverage Δ

src/common.ts
84.61% <100.00%> (+2.79%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


No longer Printing but saves image locally

Started yesterday so unsure if an update has been applied. Screenshot opens in new tab. I am able to do anything with it that I used to be able to do, but on clicking the print button...opens up print preview with just the header and footer information...everything else is blank,

No updates yesterday.


Roam list of recently visited repositories

This information is stored in global storage today--we could use the setKeysForSync API to sync this list across devices.

Enable settings sync in insiders.vscode.dev and VS Code Insiders desktop
"remoteHub.experimental.syncRecentList": true
Open Remote Repository
Recently opened repository lists should be identical

I've double checked:

the setting is turned on in both web and desktop
I've reloaded several times
I've manually triggered a sync in both web and desktop


Bug Report: lambda "is_item_forbidden" function is broken and always returns true

more info here:
https://github.com/JustNU/RE2R_AP_World/commit/99f23bf4cb0617c3749c8eb065f8941f7b740735
tldr, lambda functions are closure functions and it was always sending last possible location_data (aka it was always sending Victory location), and thus almost always returning true and making forbid_item array on location irrelevant

Awesome, thanks for identifying. Feel free to PR the fix!

I would've PRed it already, but my fork has WAY too many changes (im mostly working on it for fun too, so the quality of code... lacks in some aspects)

disregard above message, i forgot branches exist
https://github.com/FuzzyGamesOn/RE2R_AP_World/pull/18

All good. Thanks for contributing! :grin: Merged.
Good luck with your changes, and feel free to pop into the AP After Dark Discord to talk about any ideas you might have / be messing with for the RE2R rando in our channel: https://discord.gg/Sbhy4ykUKn

You're welcome :) (although the link seems to be dead/don't have permission to join, sadly...)


Fix https://github.com/mozilla/thimble.webmaker.org/issues/1137

We weren't including the document's doctype string in the rewritten HTML we used to generate the Blob URL for the preview iframe.  This caused the browser to switch to quirks mode, and make unexpected rendering choices vs. what happens on publish, where the doctype was being included.
This is another version of the bug we he once upon a time where we switched from innerHTML to outerHTML in order to get attributes on the <html> element.  The trick I've used to build the string back from document.doctype is going to work in any browser greater than IE9, so we're good.

nice! r+


Mount Options not being honored?

What happened:
I define mountOptions inside of a PV. When checking the subsequent mount within one of the k8s nodes it doesn’t honor those mount options.
What you expected to happen:
How to reproduce it:
Anything else we need to know?:
Environment:
K8S nodes inside of Hyper-V. Accessing SOFS storage on-prem.
PVC file:
kind: PersistentVolume
metadata:
  name: smb-flexvol-pv
spec:
  capacity:
    storage: 400Gi
  accessModes:
    - ReadWriteMany
  persistentVolumeReclaimPolicy: Retain
  claimRef:
    namespace: default
    name: smb-flexvol-pvc
  storageClassName: smb
  flexVolume:
    driver: "microsoft.com/smb"
    secretRef:
      name: smbcreds
    options:
      source: "//sofs.FQDN/VD-CIFS-01"
      mountOptions: "vers=3.0,dir_mode=0777,file_mode=0777"
---
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: smb-flexvol-pvc
spec:
  accessModes:
  - ReadWriteMany
  storageClassName: smb
  resources:
    requests:
      storage: 400Gi

Subsequent mount
root@k8s-3:~# mount |grep cifs
//sofs.ad.holthome.net/VD-CIFS-01 on /var/lib/kubelet/pods/4d0b2954-ab1b-11e9-b96c-00155d12a147/volumes/microsoft.com~smb/smb-flexvol-pv type cifs (rw,relatime,vers=default,cache=strict,username=k8s,domain=,uid=0,noforceuid,gid=0,noforcegid,addr=IPV6_ADDRESS,file_mode=0755,dir_mode=0755,soft,persistenthandles,nounix,serverino,mapposix,rsize=1048576,wsize=1048576,echo_interval=60,actimeo=1)

Kubectl Version:
ryan@Ryan-PC:~/src/k8s-gitops$ kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-20T04:52:26Z", GoVersion:"go1.12.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:02:58Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}

Nevermind.. mountOptions is case sensitive. Apologies!


Cell mode for easy code selection

I just learned about this fantastic package and I'm wondering if there are any plans to implement "cells" for easy code selection and evaluation.
Let me explain. By "cells" I refer to code blocks that can be delimited by lines holding a certain combination of characters (e.g. ## in Python). When the cursor is within a given cell, the user can use a keyboard shortcut to quickly select the code in the current cell and send it easily to the REPL.
Some additional context:

Cell mode in MATLAB
Cell mode in Python editors

Needless to say, jupyter notebooks are organized as collections of cells, although notebooks don't rely on lines with special characters to define them.
This is what cells may look like in raw source code:
%% This is the beginning of the 1st cell

a = 5;
print(a)

%% This is the end of the 1st cell and beginning of the 2nd cell

% This is just a comment
b = 6;
c = a + b
print(c)

%% This is the end of the 2nd cell

We're currently working on similar feature that is language agnostic. See #227 and #309

Thank you @n-riesco! It looks like https://github.com/nteract/hydrogen/pull/227 was already merged, does it mean that the feature I am asking about in this issue is ready?

We haven't published this feature yet. If you want to try it out, here are some instructions to install Hydrogen's development version.

I close this issue in favor of #317.


Suggestion: Default Video resolution to 1080p

Hi, when I run this simple script:
from manim import *

class Test1(Scene):
    def construct(self):
        dot = Dot().set_color(GREEN)
        self.add(dot)
        self.wait(1)

from pathlib import Path
if __name__ == "__main__":
    script = f"{Path(__file__).resolve()}"
    os.system(f"manim " + script)

I get a video resolution of 1440p60. Can we change the default video resolution to 1080p?
I think that the great majority of the users will have 1080p displays and with 1080p as default, video rendering is much faster.
Even one of the biggest youtube explanation channels (kurzgesagt) https://www.youtube.com/watch?v=ck4RGeoHFko
is still using 1080p, so I think it is reasonable to make this the default.
Lately, I saw a tv-documentation about the big tech companies, and they also test if all their new features look nice on cellphones/computers that are >8 years because only a small percentage of users have the newest technology.
With this said, maybe 1440p60 could be moved to a flag like -wqhd.

I agree, I think 1080p is fine for a default value. It will make the render faster when one forget to specify the resolution.

Fair. Also, I just realized that the default resolution is neither low, medium, high, or 4k. We should give it a name and a CLI flag.
Having said that, changing the default is as easy as changing the 89-91 of default.cfg.

Fair. Also, I just realized that the default resolution is neither low, medium, high, or 4k. We should give it a name and a CLI flag.

What do you mean ? Isn't 1080p high ?

Having said that, changing the default is as easy as changing the 89-91 of default.cfg.

So, sounds like an easy PR ;) Added label in consequence.

high is 1080, but the default is 1440, which is neither low, medium, high, or 4k


[Feature Request] Remove decimal.js

Is your feature request related to a problem? Please describe.
decimal.js adds an extra 31.9k of overhead to the bundle.
Its quite a heavy dependency considering that we're using  just a few methods from it, like isDecimal()
Describe the solution you'd like

Is it possible to just implement the features we need from decimal.js directly?
OR using lightweight options like decimal.js-light or big.js

Describe alternatives you've considered
I prefer removing the dependency altogether if possible.

Just piping in here as a co-champion of the decimal proposal to mention a third option that currently doesn't exist but may in the near-ish future: having decimal numbers available out-of-the-box in JS, so that, for many use cases, no library is needed at all. Any comments, concerns, or questions are welcome! Just file an issue in the proposal-decimal repo.

Is your feature request related to a problem? Please describe. decimal.js adds an extra 31.9k of overhead to the bundle.
Its quite a heavy dependency considering that we're using just a few methods from it, like isDecimal()
Describe the solution you'd like

Is it possible to just implement the features we need from decimal.js directly?
OR using lightweight options like decimal.js-light or big.js

Describe alternatives you've considered I prefer removing the dependency altogether if possible.

Hi @genu , thanks for filing this. Decimals are serialized as string over the wire and deserialized into Decimal of "decimal.js". I think it's good to preserve a decimal-like interface on the client side. If we completely get rid of the package, we'll need to implement such an interface.
I'm replacing it with "decimal.js-light" for now and it seems to work well (at the cost of not providing as many APIs). In the future if Decimal type becomes native, life will be much easier.

Fixed in 2.5.0


cassandra: incorrect workflow status in visibility keyspace

Describe the bug
Cadence server fails to update visibility tables with workflow completion info.
Even though, in cadence.executions, the workflow close_status is 1 (completed), the workflow still exists in cadence_visibility.open_executions.
This also means the workflow is listed on cadence listall --open command, but wf desc shows "CloseStatus": "COMPLETED".
Similarly, it is shown as open in the UI list, but as "Completed" when selecting it directly.
Such workflows stick around in these interfaces even past their retention period (3d).
To Reproduce
It is a recurring behaviour when either my cluster is under load (timeouts), or when I'm restarting/updating the workflow workers often, or perhaps a combination of the two.
I don't currently have an exact path to reproduce it.
Expected behavior
When a workflow completes normally, the expected behaviour is to also mark it closed in the visibility keyspace.
Additional context
This has been happening since I began with cadence v0.10.x and in current v0.13.x.
Perhaps visibility correctness needs additional checks and retries when the status sync fails.
I have only tried this on a 3 node cassandra cluster with about 1000 per min workflow churn.

Don't know if this history server log entry is related or not (v0.13.0):
{
  "level": "error",
  "ts": "2020-08-02T14:17:52.487Z",
  "msg": "Operation failed with internal error.",
  "service": "cadence-history",
  "error": "InternalServiceError{Message: DeleteWorkflowCurrentRow operation failed. Error: Operation timed out - received only 1 responses.}",
  "metric-scope": 9,
  "shard-id": 2,
  "logging-call-at": "persistenceMetricClients.go:556",
  "stacktrace": "github.com/uber/cadence/common/log/loggerimpl.(*loggerImpl).Error\n\t/cadence/common/log/loggerimpl/logger.go:134\ngithub.com/uber/cadence/common/persistence.(*workflowExecutionPersistenceClient).updateErrorMetric\n\t/cadence/common/persistence/persistenceMetricClients.go:556\ngithub.com/uber/cadence/common/persistence.(*workflowExecutionPersistenceClient).DeleteCurrentWorkflowExecution\n\t/cadence/common/persistence/persistenceMetricClients.go:313\ngithub.com/uber/cadence/service/history/task.(*timerTaskExecutorBase).deleteCurrentWorkflowExecution.func1\n\t/cadence/service/history/task/timer_task_executor_base.go:230\ngithub.com/uber/cadence/common/backoff.Retry\n\t/cadence/common/backoff/retry.go:99\ngithub.com/uber/cadence/service/history/task.(*timerTaskExecutorBase).deleteCurrentWorkflowExecution\n\t/cadence/service/history/task/timer_task_executor_base.go:236\ngithub.com/uber/cadence/service/history/task.(*timerTaskExecutorBase).deleteWorkflow\n\t/cadence/service/history/task/timer_task_executor_base.go:123\ngithub.com/uber/cadence/service/history/task.(*timerTaskExecutorBase).executeDeleteHistoryEventTask\n\t/cadence/service/history/task/timer_task_executor_base.go:114\ngithub.com/uber/cadence/service/history/task.(*timerActiveTaskExecutor).Execute\n\t/cadence/service/history/task/timer_active_task_executor.go:98\ngithub.com/uber/cadence/service/history.(*timerQueueActiveProcessorImpl).process\n\t/cadence/service/history/timerQueueActiveProcessor.go:262\ngithub.com/uber/cadence/service/history.(*taskProcessor).processTaskOnce\n\t/cadence/service/history/taskProcessor.go:253\ngithub.com/uber/cadence/service/history.(*taskProcessor).processTaskAndAck.func1\n\t/cadence/service/history/taskProcessor.go:206\ngithub.com/uber/cadence/common/backoff.Retry\n\t/cadence/common/backoff/retry.go:99\ngithub.com/uber/cadence/service/history.(*taskProcessor).processTaskAndAck\n\t/cadence/service/history/taskProcessor.go:233\ngithub.com/uber/cadence/service/history.(*taskProcessor).taskWorker\n\t/cadence/service/history/taskProcessor.go:156"
}

Post the 3d retention period, cadence took care of deleting them from cadence keyspace. However, I had to delete the "forgotten" rows from cadence_visibility.open_executions manually.

Could this have anything do with a botched canary deploy? Result of a non-deterministic version update?
Say there are 5 instances of workerv2 running (at workflow version 2). Then…
version := workflow.GetVersion(ctx, "test", workflow.DefaultVersion, 3)

// do A

if version == 3 {
    // do B
}

…when I deploy workersv3 "one by one" (rolling deploy), both workersv2 and workersv3 are going to be running at the same time.
Some workflows are probably going to get marked as version 3 via a workersv3 instance, go to sleep, and then get run through a workersv2 instance. Then probably go to sleep again and wake up as v3. Totally botched up.
Could such a non-deterministic update cause the original "incorrect workflow status in visibility store"?
Regardless, it's probably better to completely deploy if version == 3 { … } part before incrementing the workflow version. Version changes warrant a two step deploy. This needs to be documented.

Sorry for the late response. Is the issue resolved?
I am not sure if that's a bug. @vancexu are you aware of any similar issue?
Also, Workflow visibility shouldn't be related to versioning, or DeleteWorkflowCurrentRow timeouts.
But I saw some misbehavior in Cassandra when undering heavy load that it may lose some writes. There is a dynamic config the help throttling the requests to database so that it won't stress out Cassandra.


Rimworld Pack!

And also some art changes / wording updates

Looks good, I commented on the couple small things that could be cleaned up but I don't see any issues with the functionality for the cards themselves. I also checked out the PR locally and played around with the cards a bit, stacked Burning Passion up to some pretty high values but didn't try to achieve integer overflow.
I did not try to assess balance or anything since that's better done through playtesting.
Once you've made the small changes that I've suggested this should be ready to merge.

Oh and just to record it here to make sure Gk/I remember when we next look at this PR, the one thing we discussed that isn't in a comment in this PR was adding a pack preview image (but it's fine for the rest of the art to come later).
Should be a fun pack to try out.


require in suggestions LOL

i got bored and wanted to change the bukkit command system to brigadier's in 1.8 xD. Now i am facing the following problem:
if a literalargumenttype was registered with require in the dispatcher, it will still be displayed in suggestions if require is returning false 😒
if I have done something wrong, please tell me 😂.

https://github.com/Mojang/brigadier/blob/b92c420b2a292dd5c20f6adfafff5e21b9835c6d/src/main/java/com/mojang/brigadier/CommandDispatcher.java#L538-L544
there could be something like
            if (!node.canUse(context.getSource())) {
                futures[i++] = Suggestions.empty();
                continue;
            }


Support Godot 4.0

Is your feature request related to a problem? If so, please describe.
Soon Godot 4.0 will arrive, and a lot of users will use it, we need to support the Godot 4.0 as soon as possible.
What feature or improvement would you like to see?
Support Godot 4.0
Additional context
No response

Solved https://github.com/Poing-Studios/godot-admob-editor/releases/tag/godot4-v1.0.0


Fixed MLIR kernel count retrieval

This commit fixes the kernel count retrieval
to include perf_config used as part of the string
that is generated to pass to the Miir API.
Note this does not change the API per se but
includes extra information (additive) to passed
on to rocMLIR side.

This is my first PR for MIOpen and not familiar with the process.
Any pointers on the next stepas to incorporate these changes to MIOpen would be really appreciated.

Your changes looks good to me. I think one solver is missing from the list: src/solver/conv_mlir_igemm_wrw.cpp

@jerryyin ,
I could not find a call to MiirGetKernelCount there...
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/develop/src/solver/conv_mlir_igemm_wrw.cpp#L89-L119

I just rebased and pushed the branch as there were some CI failure that seemed unrelated.

@manupak Now that this is merged, could you file the follow-up PR to dial our tracking commit of MIOpen back to develop?

@jerryyin will do!


Wake screen and display timer

When timer has finished
For a few seconds every 5 min when in 25 min mode

Rewrite of this task pending resolution of https://github.com/WildlyMe/App/issues/2


using with askama compile time templates

rust-embed worked really well for me, but earlier I was using askama templates for serving HTML.
any examples on using rust embed with askama or any other compile time templates?
Maybe we can also include it in official examples!

Hmm... if askama is already compiled, why would you need rust embed to serve html in that case? You would just use rust-embed to serve static assets on a static path in the router and use askama compiled templates to handle the rest of the routes.

You would just use rust-embed to serve static assets on a static path in the router and use askama compiled templates to handle the rest of the routes.

This is what I'm doing by the way:
static routes: src/static_routes.rs
askama templates: src/views/
router: src/main.rs:172

that's fair. I will try this and let you know. closing for now.


Keeping multiple candidates while searching

Hi,
have you considered keeping multiple candidates from each layer while searching?
This code selects only one candidate from each layer before going to the next layer.
Does it make sense to keep more candidates, e.g. 2? Keeping 2 candidates instead of 1 might not cause a 100% slowdown, since the neighbors of the 2 candidates might have overlap and thus the number of distance calculations might go up by much less than 100%. E.g. with 60% overlap there will be only 40% more distance calculations.

Hi @lukipuki ,
Sometime ago I've implemented passing multiply neighbors in nmslib and saw a small (yet measurable) increase in speed/accuracy (as far as I remember ~5-10% max after parameter tuning). However, it was coded in a ugly way and introduced a new parameter (number of candidates passed), which was not clear how to set.
So, I decided not to remove this option.


Error handling old datetimes (ADA_LOVELACE_BIRTHDAY)

I'm receiving the following error. Qt is able to recover from this normally, however (as a side effect) this causes a hard crash in certain debugging modes.
 Traceback (most recent call last):
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\bluesky_live\event.py", line 514, in _invoke_callback
    cb(event)
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\bluesky_widgets\qt\_search_input.py", line 207, in on_since_model_changed
    qdatetime = as_qdatetime(event.date)
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\bluesky_widgets\qt\_search_input.py", line 22, in as_qdatetime
    int(secs_since_epoch(datetime) - datetime.utcoffset() / timedelta(seconds=1))
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\dateutil\tz\tz.py", line 222, in utcoffset
    if self._isdst(dt):
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\dateutil\tz\tz.py", line 291, in _isdst
    dstval = self._naive_is_dst(dt)
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\dateutil\tz\tz.py", line 260, in _naive_is_dst
    return time.localtime(timestamp + time.timezone).tm_isdst
 OSError: [Errno 22] Invalid argument

The above exception was the direct cause of the following exception:

 Traceback (most recent call last):
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\bluesky_widgets\qt\_search_input.py", line 253, in on_toggle_all
    self.model.since = ADA_LOVELACE_BIRTHDAY
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\bluesky_widgets\models\search.py", line 349, in since
    self.events.since(date=since)
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\bluesky_live\event.py", line 499, in __call__
    self._invoke_callback(cb, event)
   File "C:\Users\LBL\.virtualenvs\xi-cam\lib\site-packages\bluesky_live\event.py", line 522, in _invoke_callback
    raise CallbackException(message) from err
 bluesky_live.event.CallbackException: Encountered exception while processing Event <Event blocked=False handled=False native=None source=<SearchInput {}> sources=[<SearchInput {}>] type=since> from <SearchInput {}> with callback <bound method QtSearchInput.on_since_model_changed of <bluesky_widgets.qt._search_input.QtSearchInput object at 0x0000021EAC3B1670>>

I've confirmed that datetime.utcoffset() is failing because timestamp is a negative value. Is ADA_LOVELACE_BIRTHDAY too far back? Here is a glimpse at the contents of the datetime var:

@ihumphrey

Modifying this default minimum datetime to the lowest possible timestamp value datetime(1970, 1, 1, tzinfo=LOCAL_TIMEZONE) would fix this issue.

That's too bad, using ADA_LOVELACE_BIRTHDAY was a nice touch of @JulReinhardt's.
Is it generically the case that time.localtime(timestamp + time.timezone).tm_isdst just doesn't work on historical times, times before 1970?

I'm getting different behaviors on different environments. On 3.8, time.localtime(-1) breaks; on 3.9 it works.

Interesting. I guess our options are:

Find another API for this that is not broken in some versions of Python.
Give up and change the default date.

(2) would be unsatisfying but if no one finds time for (1) in the near future it’s fair to consider it.

@ronpandolfi I haven't had time to circle back to this yet. Do you have time to submit a PR? To put in writing what we agreed on the call, I'm fine with (2) for expedience but we should open a GitHub issue to track down the underlying problem. I suspect we are misusing an API. If times-before-1970 actually broke between Python releases I am sure it would be a Big Deal.
I had hoped to get to this myself, but it's not going to happen this week.

I have just seen this error for the first time use python 3.9.5, trying to run on Windows 10.
I am unable to start bluesky-widgets-demo because of it. I tried changing the default date to a time after the unix epoch so that it wasn't negative:
ADA_LOVELACE_BIRTHDAY = datetime(1970, 1, 2, tzinfo=LOCAL_TIMEZONE)
But then I get another error and still can't start the application:
QLayout: Attempting to add QLayout "" to QtSearchInput "", which already has a layout
c:\users\sissy_user\bluesky\bluesky-widgets\bluesky_widgets\models\search.py:128: PytzUsageWarning: The zone attribute is specific to pytz's interface; please migrate to a new time zone provider. For more details on how to do so, see https://pytz-deprecation-shim.readthedocs.io/en/latest/migration.html
  timezone = tzlocal.get_localzone().zone
Traceback (most recent call last):
  File "c:\users\sissy_user\bluesky\bluesky-widgets\bluesky_widgets\qt\threading.py", line 117, in run
    self.returned.emit(result)
  File "c:\users\sissy_user\bluesky\bluesky-widgets\bluesky_widgets\qt\threading.py", line 66, in __getattr__
    return getattr(self._signals, name)
RuntimeError: wrapped C/C++ object of type WorkerBaseSignals has been deleted

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\users\sissy_user\bluesky\bluesky-widgets\bluesky_widgets\qt\threading.py", line 119, in run
    self.errored.emit(exc)
  File "c:\users\sissy_user\bluesky\bluesky-widgets\bluesky_widgets\qt\threading.py", line 66, in __getattr__
    return getattr(self._signals, name)
RuntimeError: wrapped C/C++ object of type WorkerBaseSignals has been deleted

Is this a red herring? I am not really sure where to look the error message doesn't tell me much that I understand. @ronpandolfi in the original error report you mention that you only see this cause a crash in certain debugging modes. How do I find out what mode I am in?


Popover: flicker on presentation in Edge browser

Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[x ] 3.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Presenting a popover shows a short flicker in Edge browser. (creation of empty popover container is shortly visible)
Expected behavior:
Flicker should not be present.
Steps to reproduce:
Issue is directly visible in the online demos:
1.) Open Edge Browser
2.) Navigate to: https://ionicframework.com/docs/api/components/popover/PopoverController/
3.) Swap to "Windows"
4.) Click on three dots icon in top-right.. Watch out for the short flicker in the bottom right
Related code:
Missing CSS property.
Adding the following CSS Property fixes the issue:
.popover-content {
  opacity: inherit;
}

Thanks for opening an issue with us, we will look into this.


Authorizing a Saleforce Org

When trying to authorize an org, a localhost error is displayed. The org was authorized previously but the link used no longer exist. When trying to authorize the same org with a new link, the localhost error is shown. I'm not sure how to delete the original link from VScode to see if that would help.

@tfenster Is this from an extension? How are you authorizing an org?

Wrong person, probably intended for @tfranklin27


Fixes Selection of Sprites using AtlasTexture

Selection of Sprites that use AtlasTexture in the editor.
Bugsquad edit: Fixes #16261

Thanks for your contribution!

Cherry picked into 3.0.3


AVRO-4063: Call flush on the inner writer during Writer::flush

Overview
Fixes #10.
Description
This PR calls std::io::Write::flush on the inner writer of apache_avro::Writer at the end of apache_avro::Writer::flush. This ensures that the flush is propagated and the previously written bytes are fully sent.
This PR also includes a unit test that confirms Writer::flush now works as expected.

Thank you, @snowsignal !


Provide further coverage of style values using variables

Provide further coverage of style values using variables on https://github.com/x-team/auto-ui/tree/master/src/styles

PR submited on https://github.com/x-team/auto-ui/pull/67, please review when possible. Thanks!


Updating calendar, removing devdays and build

Docs Build status updates of commit b565ae2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/sf-academy-events.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.