Bug from #23592 - Type 'keyof U & K' does not satisfy the constraint 'string | number | symbol'

TypeScript Version:  2.9.0-dev.20180424
Search Terms:
keyof, intersection, conditional types
Code
type Example<T, U> = { [K in keyof T]: K extends keyof U ? UnexpectedError<K> : NoErrorHere<K> }

type UnexpectedError<T extends PropertyKey> = T
type NoErrorHere<T extends PropertyKey> = T

Expected behavior:
No errors.
Actual behavior:
Error on K in UnexpectedError<K> with message
Type 'keyof U & K' does not satisfy the constraint 'string | number | symbol'.
  Type 'keyof U & K' is not assignable to type 'symbol'.

Playground Link:
Link (no error in playground)
Related Issues:
#23592

The issue here is that we don't lift constraints over intersection types. Here's a simpler repro:
function foo<T extends string | number, U extends string | number>(x: T & U) {
    let y: string | number = x;  // Error, but shouldn't be
}

We need to lift the individual constraints of T and U such that the intersection type T & U appears to have the constraint string | number (formed by intersecting the individual constraints of T and U).

The reason this shows up with #23592 is that we now have union type constraints for keyof T.

@mhegazy Do you recall if we already have an issue for this?

@mhegazy Do you recall if we already have an issue for this?

do not think i have seen this one before.


Unable to plot Voronoi plot

Hi!
I am trying to run the example that you placed on the first page. But a got an error that is the same for other examples that I have found all over the internet. It will happen when I call plot_voronoi_polys_with_points_in_area(ax, area_shape, region_polys, coords, region_pts)  The error is as follows:
 { 	"name": "IndexError", 	"message": "too many indices for array: array is 0-dimensional, but 2 were indexed", }
For reproducing this error you should just run your example.

Thank you for your answer. I suppose I've found another way to do that.


Build and install Qt 5 and Qt 6 version in a single pass

Build and install Qt 5 and Qt 6 version in a single pass. It will help GNU/Linux package maintainers.
Now we need to perform two separate builds.

As a package maintainer, I'd prefer things to remain like they are.

Building both versions with a single pass would be more trouble than it's worth, to be honest, since you need to make sure everything happens twice, no files overlap and everything is properly isolated. At that point, it's easier to just have to build dirs and run cmake in both separately.
I'm not going to implement this, sorry.


Update fes.py (BUG!)

This is a one-line code change to mitigate a bug that results in histogramming exiting with a key error.  For some reason, histogram bins that actually ARE populated are not correctly being added to the histogram_data dictionary. When the free energy for that bin is meant to be pulled, that bin doesn't exist in the dictionary and the KeyError is thrown. This fix assigns a default value of -1 to the bin_label if the key isn't present nstead of throwing this exception, and thus can allow the user to bypass the troubled bin(s) and still get a free energy surface. This fix does not find the root cause of the issue. I would be happy to provide the example which resulted in me finding the bug, but would require transferring many files.

Can you give an example of this we can look at to figure out what happened?

There is now an example script in the examples subdirectory labeled pull_request_502. Thank you for your time.

While I appreciate the example here, this isn't helpful for debugging the problem as you've provided it.
What I need to work on this is a minimalist case where the bug is thrown. Minimal script, minimal input files, etc. Can you provide those as attached ZIP files to this issue rather than as commits to the repository please?
As it stands now, this PR will have to be closed and re-opened as a new one for a few reasons:

You've added ~500MB of files and over 1M lines of "code" which are just CSV files of data to the repo. If we merge this as it stands, it will make the repository huge to clone/copy and don't help other users of the codebase beyond this one bug (which we're trying to fix)
Even if you removed the files in a later commit, the way git works means the 500MB of files will stick around anytime you fetch/pull because git has to be able to go back to the point in time that this commit references, which means the 500MB of files. Its fixable, but its a huge pain and you're better off just starting clean.
The Python script you provided uses hard coded paths  to a file you didn't include (/projectnb/cui-buchem/rosadche/tanmoy_fes/dftb_fes_inv/fes_inv/nuc_after_pt_orig_external.dat), so I can't even work to debug this based on what you have and give a straightforward answer.

If you can give me a minimal script of something here which reproduces the error, preferably without all the extra files, I can debug this, but as it stands I can't advance this right now.
I am going to leave this PR open so it can continue to be discussed, but this PR itself will never be merged. Once we figure out the issue, we'll open a new PR with the fix in it and none of the other files.

Closing this as the discussion can continue in #511 and future follow up, especially since this PR cannot be merged as it stands. Feel free to contribute to the conversation there.


[5.7] Adds the missing parameters in the method call

It seems that app()->handle(...) is just a thin wrapper around app(HttpKernelContract::class)->handle(...);
but it throws away the last 2 accepted arguments and only uses the first one ($request).
So why it accepts them in the first place if it is intended to call the handle with only one parameter ?!
issue : https://github.com/laravel/framework/issues/26502

They serve no purpose for Laravel.


utils/auth: support registry URLs with protocol

Adds the option to pass --reqistry with http:// or https:// and still benefit from .docker/config.json credentials.
Either that or there could be validation that enforces the lack of protocol prefix.
Right now there's a corner case (I used latest Docker and AWS ECR) when the credentials in the file doesn't have the protocol and you pass a registry URL with the protocol - it gives up and falls back to no auth.
Before:
$ aws ecr get-login --region eu-west-1 --no-include-email | bash
$ reg --registry https://<redacted>.dkr.ecr.eu-west-1.amazonaws.com -d vulns --clair http://localhost:6060 <redacted>
2018/02/19 14:18:03 registry.ping url=https://<redacted>.dkr.ecr.eu-west-1.amazonaws.com/v2/
Get https://<redacted>.dkr.ecr.eu-west-1.amazonaws.com/v2/: http: non-successful response (status=401 body="Not Authorized\n")
...

After:
$ aws ecr get-login --region eu-west-1 --no-include-email | bash
$ ./reg --registry https://<redacted>.dkr.ecr.eu-west-1.amazonaws.com -d vulns --clair http://localhost:6060 <redacted>
2018/02/19 14:19:57 registry.ping url=https://<redacted>.dkr.ecr.eu-west-1.amazonaws.com/v2/
2018/02/19 14:19:58 registry.manifests uri=https://<redacted>.dkr.ecr.eu-west-1.amazonaws.com/v2/<redacted>/manifests/latest repository=<redacted> ref=latest
2018/02/19 14:19:58 registry.registry resp.Status=200 OK
...
2018/02/19 14:20:00 clair.clair resp.Status=200 OK
Found 0 vulnerabilities

I should write unit tests for that function some time there is so much string manipulation hahaha
Thanks!


mzmine 4.1.0 chromatogram resolving  No Response!!

Basic information

My operating system and version:window11
My mzmine version: mzmine 4.1.0

What happened

Please describe what happened and how it differs from what you expected to happen.
Please include all parameter values for the mzmine modules you used.
Please upload screenshots of any errors and your log/mzmine.log file.
Please upload a standalone mzmine project file (or a batch + raw files) that demonstrates the problem you are reporting. You can use Google Drive, Dropbox, or a similar repository to upload the project.
Issues opened without an example project are unlikely to be processed

When I ran the local minimum reoslver in the chromatogram resolving, there was no response after setting the parameters. The prompt in the lower left corner is always: Setting parameters for module Local minimun feature resolver. This situation has been going on for a week. Please help me solve it. I tried the latest version, too.
A screenshot is attached below.

Hi,
from the screenshot it looks like your license has expired. Please send an email to<EMAIL_ADDRESS>to clarify your status as an academic.
kind regards,
Ansgar


Optimize performance

A bottleneck seems to be the size calculation done with the hosting controller.

The issue I was facing had nothing to do with the control.


Improve route matching (raw) performance

Describe the feature
Hono uses a faster RegExpRouter instead of a Radix Tree based router such as Radix3 which H3 currently uses.
Additional information

[ ] Would you be willing to help implement this feature?

I appreciate your concern about performance and suggestions.
I invite you to check the radix3 benchmarks and see if the raw matcher responsiveness of 7M ops is less than of your real world usage expectations that might need an alternative method.
There is also an off-topic discussion in https://github.com/unjs/radix3/issues/58 which I will respond in the future.

Generally regarding performances please consider the main bottleneck in any real world server application is not the core or route matcher but user logic and the composition of utilities in which h3 tries to best at.
We can make small adjustments to radix3 to increase benchmark results for specific route conditions but it is just much lower priority comparing to priorities such as ecosystem compatibility.

Also made https://github.com/unjs/radix3/issues/85 as tracker let's move discussion there.
(if you still believe there are strong reasons h3 usage would significantly be different by opting to a different router, we can definitely come back to this 👍🏼 )

@redbar0n @pi0 you may see hono regex router being faster as the router doesn't parse the params into an object but instead keep it in an array which it can be obtained later by prototype pollution.(c.req.param)

But @medley/router algorithm is still the fastest as of rn


Improve context menu handling in resource-manager

The resource-manager context menus are currently driven by some convoluted logic to fire events from one so others can catch those events to close themselves. At the time, my attention was not totally focused on thinking we would have them in different contexts and this causes some odd behaviours in some sequence of clicks.
There is a super simple way though to make this both simple and more robust, when basically any click outside a context menu just closes it... The code would look something like this:
@Listen('mousedown', { target: 'document' })
  handleOutsideClick(event: MouseEvent) {
    const path = event.composedPath();
    if (!path.includes(this.el)) {
      this.closeDropdownMenu();
    }
  }

This is on my todo list


DNS resolution problems for service entries

Hi,
We have two ServiceEntres in same namespace for two deferent mongos.
Current  application connect to only main-mongodb-se. (main-db1-[1-3].c.internal-ai.internal )
see ServiceEntry configuration below
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: main-mongodb-se
spec:
  hosts:
    - main-db1-1.c.internal-ai.internal
    - main-db1-2.c.internal-ai.internal
    - main-db1-3.c.internal-ai.internal
  exportTo:
  - "."
  ports:
    - name: main-mongo-clients
      number: 27017
      protocol: TCP
  location: MESH_EXTERNAL
  resolution: NONE

---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: dcs-mongodb-se
spec:
  hosts:
    - dcsdb1-1.c.internal-ai.internal
  exportTo:
  - "."
  ports:
    - name: dcs-mongo-clients
      number: 27017
      protocol: TCP
  location: MESH_EXTERNAL
  resolution: NONE

When app connects to main-mongodb-se (main-db1-[1-3].c.internal-ai.internal) in Istio sidecar log we see that ist's connecting to dcsdb1-1.c.internal-ai.internal but in ip address we see address of main-db1-[1-3].c.internal-ai.internal.
See logs below
[2020-12-29T21:05:01.786Z] "- - -" 0 - "-" 2455 9183 571337 - "-" "-" "-" "-" "<IP_ADDRESS>:27017" outbound|27017||dcsdb1-1.c.internal-ai.internal <IP_ADDRESS>:39752 <IP_ADDRESS>:27017 <IP_ADDRESS>:39746 - -

[2020-12-29T21:17:23.741Z] "- - -" 0 - "-" 13980<PHONE_NUMBER>82 - "-" "-" "-" "-" "<IP_ADDRESS>:27017" outbound|27017||main-db1-1.c.internal-ai.internal <IP_ADDRESS>:45682 <IP_ADDRESS>:27017 <IP_ADDRESS>:45680 - -

W'd expect to see main-db1-[1-3].c.internal-ai.internal this hostnames only.
Problem above we see DNS name which we are not requesting however DNS is pointing to  main-db1-1.c.internal-ai.internal
Please advice.
[X ] Networking
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
1.8.1
How was Istio installed?
istioctl minimal profile
single net
single mesh
single cluster
Environment where the bug was observed (cloud vendor, OS, etc)
GKE

This is not possible, generic TCP does not have enough information to distinguish these two. https://preliminary.istio.io/latest/blog/2020/dns-proxy/#external-tcp-services-without-vips has a better explanation of this

Hi @howardjohn,
Thanks for reply
In other words if we are using TCP protocol in our ServiceEntry and resolution: NONE  (like yaml above that we have) it will create following listener
ADDRESS        PORT  MATCH                                         DESTINATION
<IP_ADDRESS>        27017 ALL                                           Cluster: outbound|27017||dcsdb1-1.c.internal-ai.internal

And if we create second ServiceEntry with different name it will create an other listener and we will have following listeners
ADDRESS        PORT  MATCH                                         DESTINATION
<IP_ADDRESS>        27017 ALL                                           Cluster: outbound|27017||dcsdb1-1.c.internal-ai.internal
<IP_ADDRESS>        27017 ALL                                           Cluster: outbound|27017||main-db1-1.c.internal-ai.internal

And traffic will go with first matching rule (dcsdb1-1.c.internal-ai.internal in our case)
But if i use resolution: DNS i will expect envoy to resolve hosts list to ips and populate addresses list
However it looks like there is no deference between resolution: NONE and resolution: DNS for TCP protocol ServiceEntry.
Is there any automated way for Envoy to resolve hosts list and populate addresses list so there will not be any yamls update when i point DNS to deferent ips. Then it will be able to differentiate ServiceEntry by automatic hostname to IP DNS resolution.
I will hate to update addresses list in yaml files for each TCP  ServiceEntry each time I change DNS
Please advice.

There is not, envoy does not currently support this. While it's likely technically possible to add there are some challenges. For example envoy and the application may get different dns responses (because dns server returns different things, or at the very least if the dns changes it would occur for some time period) which will lead to traffic breaking

For TCP protocol in ServiceEntry there is no deference between resolution: NONE and resolution: DNS ?

DNS: Client sends request (likely resolving its own DNS request, but could also send directly to an IP), Envoy ignores it and sends to IP based on its own DNS resolution
NONE: Client sends request (likely resolving its own DNS request, but could also send directly to an IP), Envoy sends to the IP the client sent

Thanks @howardjohn
Now i'm confused
in case of   resolution: DNS
Envoy ignores it and sends to IP based on its own DNS resolution DNS resolution based on host spec ?
I see this happening for HTTP protocol where Host header is set. In case of TCP, client will resolve DNS and try to connect IP directly. How ENVOY knows original DNS that my app was trying to connect and will resolve DNS to ip and send data to it ?
lets say i have
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: dcs-mongodb-se
spec:
  hosts:
    - dcsdb1-1.c.internal-ai.internal
  exportTo:
  - "."
  ports:
    - name: dcs-mongo-clients
      number: 27017
      protocol: TCP
  location: MESH_EXTERNAL
  resolution: NONE

or
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: dcs-mongodb-se
spec:
  hosts:
    - dcsdb1-1.c.internal-ai.internal
  exportTo:
  - "."
  ports:
    - name: dcs-mongo-clients
      number: 27017
      protocol: TCP
  location: MESH_EXTERNAL
  resolution: DNS

Is there any example that i can try and understand difference ?
As when i try   resolution: DNS|NONE i don't see any difference in istioctl proxy-config listeners
Thanks in advance.

As when i try resolution: DNS|NONE i don't see any difference in istioctl proxy-config listeners

The difference is in the cluster, not the listener


Add FUNiX Online University

Official website: https://funix.edu.vn/en/
Sample course that might take more than 1 year: https://funix.edu.vn/undergraduate/bachelor-software-engineer/
Official email domain(@funix.edu.vn): See the contact email at https://funix.edu.vn/about/contact

@tungph Pull request merged. Thank you!


Add mock email server for integration tests

Is your suggestion related to an experience ? Please describe.
Currently, there is no way to test the email sending flows with the integration test suit. This is a blocker to improve the automation test coverage.
Describe the improvement
Add a mock email server to the integration test suite. This allows us to configure a email server in the integration tests and test the email sending flows.
Additional context

Fixed by

https://github.com/wso2/carbon-platform-integration/pull/102
https://github.com/wso2/product-is/pull/21167

To use the mock email server,

Make sure below configuration is added to the deployment.toml file. If a new deployment.toml file is not added in the particular test case, this file is automatically available during the initial server startup.
[output_adapter.email]
from_address=<EMAIL_ADDRESS>username= "admin"
password= "admin"
hostname= "localhost"
port= 3025
enable_start_tls= true
enable_authentication= true

Delete all the emails in the server before the tests are started.
Utils.getMailServer().purgeEmailFromAllMailboxes();

To access the email message follow below steps
Utils.getMailServer().waitForIncomingEmail(10000, 1);
Message[] messages = Utils.getMailServer().getReceivedMessages();
String body = GreenMailUtil.getBody(messages[0]).replaceAll("=\r?\n", "");

More details can be extracted from https://github.com/wso2/product-is/pull/21167


Need pretrained model

Can you please share the pre-trained model weights

@loaysh2010 Sorry I took so long to respond. I somehow missed the notification.
The pretrained weight are at the root of the repo:
https://github.com/aakaashjois/goturn_pytorch/blob/master/weights.pkl
You can fetch it using git-lfs.


Add Railgun (Ethereum) Token

info.json removed

@mesquka Can you also throw up a issue request here: https://github.com/sushiswap/default-token-list/issues
And we can get it to show up on the UI after that.


Text rotation Issue

css is not working  , i am using transform: rotate(180deg) on text span , please advide.

Hi @Fahad-AQ, that could be an issue with html2canvas. Would you please try forking this jsFiddle to reproduce the problem? You can use it to test whether the problem is in html2canvas ("Generate canvas") or html2pdf ("Generate PDF"). Thanks!

Hi ekoopmans , kindly give me solution of page break issue ,

This is my javascript code.
function addScript(url) {
var script = document.createElement('script');
script.type = 'application/javascript';
script.src = url;
document.head.appendChild(script);

}
addScript('https://raw.githack.com/eKoopmans/html2pdf/master/dist/html2pdf.bundle.js');
var element = document.getElementById('paginations');
var opt = {
filename:     'abc.pdf'
};
  // New Promise-based usage:
  html2pdf().set(opt).from(element).save();

i've the same problem, i dont how i can resolve it


[flutter_tools] do not require a dependency on devtools server

Description
Re-arrange the implementation of the devtools launcher so that google3 is not required to depend on any devtools packages. Also renames the build_runner folders to isolated to better clarify their intention.

Not sure if this would have prevented the recent build breakage?

Landed the internal CL to exclude the isolated/ folder. @renyou can frob handle changes to the BUILD file, or will this PR necessarily break the roll?

G3 fix applied, waiting for results


abstract class

Hi,
class Predict
{
...
std::vector<std::unique_ptr>	m_postProcessingParams;
...
}
Where PostProcessingParams is an abstract class inherited by a bunch of other classes. m_postProcessParams are pointer to base class, and we are using polymorphism. What strategy do you recommend for handling that scenario.
Thanks.

I recommend to go for std::variant<all,your,types> then use std::visit and work with them rather than using virtual. If you really want to use virtual then you need to implement a save(..) load(..) virtual functions - the load function does the regular deserialization of a unique ptr of derived and the save just saves.

Thanks.


Stylelint: move reportInvalidScopeDisables and reportNeedlessDisables…

… to config
Description

Motivation & Context

Type of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[ ] I have read the contributing guidelines
[ ] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-{your_pr_number}--twbs-bootstrap.netlify.app/

Related issues

BTW I could use some help with replacing the deprecating rules in the new stylelint version https://github.com/twbs/stylelint-config-twbs-bootstrap/issues/188

I believe this is now ready. IMHO it's cleaner now.
The only issue I've been hitting is some caching issue when changing the config. But it's not something new IIRC.

OK, now I really think it's ready :) Let me know which approach you prefer. I feel the latter is cleaner since those rules affect our Sass files only and we reduce the overrides.


Request/discussion: HA sensor should show time, not relative time

Hi Mark,
I am living in France and my main bus-provider recently changed the RT from json to protobuf, requireing me to review other solutions as json I can handle.
I found zacs version which was a bit old and then your fork of it. I have a few questions to determine where I go
To begin with: your solution works fine, so thanks for that !

vehicle position url does not seem to be 'optional', i.e. if I leave it out then I get errors
how can I verify if my provider show lat/lon in the veh-position url? The log shows 'not defined' but not 100% sure this is correct as the source may be incorrect too. I decomposed the bin with 'transit_realtime.FeedMessage'  and could not find a thing so maybe this is indeed missing? EDIT: also checked with VehiclePosition
Personally I would prefer that the state shows datetime and not relative time, this would allow HA users to do whatever they want. i.e. by giving it s class 'timestamp' the entity card would show relative time by default. It is also more (lets call it) standard HA
EDIT: can there be a different interval? It now seems to poll a lot and I donot require this, usually only between 7:00 and 9:00 and 16:00-18:00. Trying to reduce unnecessary bandwidth usage. Polling between set-times can be done via automations but then the 'interval' for the main sensor has to be set to 'hours'
EDIT: how does this behave if I add multiple sensors, would it run per-sensor vs. the source gtfs url?
Are you planning to add this to HA as a core element or HACS? If not, why...just interested in your thinking?
Thanks
Arjan

Arjan, could you post some links to your bus provider RT data?

Hi, this is the only (!) link for this particular provider, with 'trip-update' at the end I guess this sort-off says it all
https://proxy.transport.data.gouv.fr/resource/region-sud-gtfs-rt-trip-update
The overall site
https://trouver.datasud.fr/dataset/lignes-des-reseaux-de-transport-zou-en-regionsud

Hi,
Apologies for the delayed response - it's hard to get to this stuff during the week.  In answer to your questions:

The vehicle update is meant to be option but this was inadvertently broken by a recent code update.  The bug has been fixed and included in the next release.  In the mean time you can use vehicle_position_url: '' to get around the problem.
I have looked at the data returned by your provided and I believe they are not provided vehicle position data.
I'm not sure what you mean by "relative time".  I guess this means you would prefer the sensor state to be set to the date/time the service is due rather than an integer container the number of minutes until it arrives.  I can kind of see the logic but I think that users find both values useful.  There is already an attribute called 'Due at' that shows the time due in 24-hour format.  Could you not be used to meet your needs?
I will consider your suggestion to throttle the request frequency based on the time of day.  But to be honest I don't see it as a high priority as I believe the bandwidth used by the integration is pretty small in the scheme of things (each update less that 1MB on average).  But if other see value in this then would be happy to re-assess.
If multiple services are defined then they will be updated by a single call to the transport provider for trip and vehicle position data.  Does this answer your question?
I think the integration as it is written has some limitations.  It would be much more useful if it combined the static scheduling information with the realtime data.  This would solve a number of issues raised here already.   I'm not sure of the process of how or why an integration becomes part of the HA core.  I guess it would need to be pretty popular for that to happen.  Regardless, the support would still come back to this forum so I don't see a lot of change.

Hope that helps.
Mark

Hi, thanks for the feedback and thinking.
My, and I guess most people's, challenge is the yaml stuff including digging into the gtfs data to understand which route etc. In that sense it would be good to have the static gtfs integrated and possibly select the stops from the GUI, this is a lot of work though and for me outside of the available dev competency (am not a dev). If you have any idea on how to GUI-select the stops/routes from the sqlite gtfs db then maybe I can look at that too.
Wrt to the state value, as you may see in my new version (link above), I already built-in the datetime instead of minutes, I prefer to have a datetime instead of a float/integer indicating minutes. A use case is the poor quality from my provider where I would like to see the actual time and not a calculation, to review if the data is correct,... of course one should normally not have to worry about the data quality but it is as it is with this one.
I also thought about my comment on the frequency and will probably build it in, the main reason: our bus's frquency is 30m or 1h and no point in collecting data every minute, the only trick I see is to find out when to trigger it. As it can not be too short to the actual departire time neither to far off.....the dev work is a small thing but possibly a waste of time in the end :)
Cheers
Arjan

Closing this issue, I have create a combined GTFS and GTFS-realtime thingy for HACS, based on GTFS-core and your integration. I will gradullay progress with getitng to what I (believe) want :)


As a system, I want to be able to access and use a reverse proxy for API calls to be relayed to POKT as RPCs.

core functionality API keys useless otherwise

[x] porters-xyz/product#14
[x] porters-xyz/gateway-demo#121
[ ] https://github.com/porters-xyz/gateway-demo/issues/94
[x] https://github.com/porters-xyz/gateway-demo/issues/152
[x] https://github.com/porters-xyz/gateway-demo/issues/150

Currently proxying to free gateway for demo and testing. We need an app stake to be able to be paired with actual RPC nodes.

need to formalize POKT node for the Gateway (strike a deal with Nodies)


Implement range iterators in OrderedHashMap, Use KeyValue in HashMap

Implements Range Iterators in OrderedHashMap following #50284.
Makes HashMap use KeyValue (like Map) and remove its internal Pair struct which seemed unnecessary.
Modifies List to work with KeyValue

I'm getting this error:
In file included from core/config/project_settings.h:36,
                 from core/config/project_settings.cpp:31:
./core/templates/ordered_hash_map.h: In instantiation of 'KeyValue<K, V>& OrderedHashMap<K, V, Hasher, Comparator, MIN_HASH_TABLE_POWER, RELATIONSHIP>::Iterator::operator*() const [with K = String; V = List<Ref<InputEvent> >; Hasher = HashMapHasherDefault; Comparator = HashMapComparatorDefault<String>; unsigned char MIN_HASH_TABLE_POWER = 3; unsigned char RELATIONSHIP = 8]':
core/config/project_settings.cpp:1056:59:   required from here
./core/templates/ordered_hash_map.h:198:23: error: binding reference of type 'KeyValue<String, List<Ref<InputEvent> > >&' to 'const KeyValue<String, List<Ref<InputEvent> > >' discards qualifiers
  198 |    return E.key_value();
      |                       ^

I feel like this should be using ConstIterator but is using Iterator instead and I don't know why.

I noticed KeyValue<> was added a while back for implementing range iterators....  I'm not sure why, because Pair<> is sufficient  and there really shouldn't be any difference in the template.

I think KeyValue<> should just be removed, and support Pair<> which is more aligned with standard c++.  If we want to do custom accessors, 'key' and 'value' we can just add those accessor to Pair<>?

If we want to do custom accessors, 'key' and 'value' we can just add those accessor to Pair<>?

This was the main reason I wanted to use KeyValue instead of Pair, also because it's what Map uses and I wanted it to be consistent with it. If I use Pair it works fine inside a List but I still get the same error about discarding qualifiers and I'm not sure what I'm doing wrong because the implementation is pretty much copied from map.h.

Agreed, I don't think this can be merged until there is a single copy for the key and value for this container implementation.  If the key/value is copied twice in this container, (into the hash_map and a list as well), this container will never be compatible with things like std::unique_ptr, and other structures that support ownership semantics, move semantics, etc.

Alright, so my quick take on this, would be (for ordered_hash_map impl):
Store KeyValue<K, V> in the internal hash_map.  This can be the single key (and value) copy.  (instead of storing InternalList::Element * in the  hash_map).
In this container there should exist one copy of KeyValue<K, V>.  That is already in HashMap::Element, so it makes sense to keep that there.
So for this implementation, instead have the list then store HashMap::Element *.
Now for the purposes of iteration, you can still easily iterate via the list structure.  But instead you will be iterating HashMap::Element * elements.  For iteration purposes, you have access to return KeyValue<K, V> & because these will be available in HashMap::Element *.

As an aside, it may be simpler to implement this container as a subclass of HashMap, instead of the composition of two other containers.  It looks like it's implemented that way in a few other languages, (LinkedHashMap for java, OrderedDict in python, etc).

If the list stores HashMap::Element * then the find and erase methods won't be O(1) because I have no direct access to the list element.

Ya I i think there are going to be limitations to implementing this as a composition of two containers.  And you are correct that deletion would be O(n).   Find should always be O(1) however as it should just use the hash map for lookups.
Actually I have used this before https://github.com/Tessil/ordered-map and it mentions that erase is O(n) as well when this author implemented this using a composition of two other containers too.
Anyways, this may be why an implementation that subclasses hashmap may be better than a composition.  You could just override insert delete, and maintain whatever other internal structures necessary for the ordered book-keeping.
There are also other in-efficiencies in this impl, considering memory operation overhead for this container is now double as there are now two internal node-bucket based containers to bookeep...
I'm not sure what the solution is other than accepting multiple key copies, (which I don't love as it can have side effects depending on what your keys are).  Accepting erase being O(n), and re-structuring the existing containers in the existing implementation.  Or redoing the container and building it out as a custom structure that doesn't have the existing structural limitations of the other two containers.

I'm sorry but I don't see how find can be O(1). I need the InternalList::Element to construct the OrderedHashMap::Element since it uses it for next and prev but the map can only give me the InternalMap::Element so I'd still need to get the InternalList::Element by finding the map element in the list and that is O(n).

Sorry I meant find in the context of looking of the hash map.  Lookup by key in the map would be O(1).  find in the context of a list lookup by value will be O(n), but I'm suggesting the only reason you would need to call find on the list is when you are removing something from the container.  I could be overlooking an implementation detail however.

I think ultimately if you implemented storage of a Pair<KeyValue<K,V>, List::Element*> in the base hash_map, you could achieve the correct implementation.  But this would have the downside of storing an unnecessary pointer in the case of non-ordered hash maps.    And the of course the alternative is to just do a completely custom implementation.
But at any rate, i'm open to any of the solutions, including perhaps the status quo of not supporting range iteration on this particular container at the current time.  I think they all have potential pros and cons, and the perfect solution may not be achievable considering re-implementation is a non-zero cost of somebody's time and effort.

Superseded by #60881


Bbaw egyptian

This is the "hieroglyph corpus" that I could unfortunately not contribute during the marathon. I re-extracted it again now, so that it is in the state as used in my paper (seee documentation). I hope it satiesfies your requirements and wish every scientist out their loads of fun deciphering a 5.000 years old language :-)

Hi @phiwi,
Thanks for contributing this nice dataset. If you have any blocking problem or question, do not hesitate to ask here. We are pleased to help you.
Could you please first synchronize with our master branch? From you branch bbaw_egyptian, type:
git fetch upstream master
git merge upstream/master

Thanks ! Can you check that you have black==21.4b0 and run make style again ? This should fix the "check_code_quality" CI issue

Reformatted with black.

Hi @phiwi, there are still some minor problems in relation with the tags you used in the dataset card (README.md).
Here you can find the output of the metadata validator:
WARNING:root:❌ Failed to validate 'datasets/bbaw_egyptian/README.md':
Could not validate the metada, found the following errors:
* field 'size_categories':
	['100K<n<1000K'] are not registered tags for 'size_categories', reference at https://github.com/huggingface/datasets/tree/master/src/datasets/utils/resources/size_categories.json
* field 'task_ids':
	['machine translation'] are not registered tags for 'task_ids', reference at https://github.com/huggingface/datasets/tree/master/src/datasets/utils/resources/tasks.json
* field 'languages':
	['eg'] are not registered tags for 'languages', reference at https://github.com/huggingface/datasets/tree/master/src/datasets/utils/resources/languages.json

@albertvillanova corrected :-)

Thanks, @phiwi. Now all tests should pass green.
However, I think there is still an issue with the language code:

the code for the Ancient Egyptian is not ar-EG
there is no ISO 639-1 code for the Ancient Egyptian
there is an ISO 639-2 code: egy; but this code will not pass the validation test because it is not in the list of valid codes

I am not sure what to do in this case... Maybe @lhoestq has an idea?

I have just checked that in the list of valid codes there are already ISO 639-2 codes. Therefore, I would suggest you to add it to the list:
"egy": "Egyptian (Ancient)",

Done.

Hope, everything is okay right now.


Issues with getting transactions

Hello! I'm having issues with getting the transactions into a dataframe. My login seems to work fine, but the below code indicates that the transactions aren't being interpreted as a CSV type file.
How do I fix this?

RuntimeError                              Traceback (most recent call last)
 in ()
4 # Get transactions
5
----> 6 mint_data=mint.get_transactions() # as pandas dataframe
7
8 budgets=mint.get_budgets()
C:\Users\schung013\AppData\Local\Continuum\Anaconda2\lib\site-packages\mintapi\api.pyc in get_transactions(self)
363         """
364         assert_pd()
--> 365         s = StringIO(self.get_transactions_csv())
366         s.seek(0)
367         df = pd.read_csv(s, parse_dates=['Date'])
C:\Users\schung013\AppData\Local\Continuum\Anaconda2\lib\site-packages\mintapi\api.pyc in get_transactions_csv(self, include_investment)
335             ('?accountId=0' if include_investment else ''),
336             headers=self.headers,
--> 337             expected_content_type='text/csv'
338             )
339         return result.content
C:\Users\schung013\AppData\Local\Continuum\Anaconda2\lib\site-packages\mintapi\api.pyc in request_and_check(self, url, method, expected_content_type, **kwargs)
104                 raise RuntimeError(
105                     'Error requesting %r, content type %r does not match %r' %
--> 106                     (url, content_type, expected_content_type))
107         return result
108
RuntimeError: Error requesting 'https://wwws.mint.com/transactionDownload.event', content type 'text/html; charset=UTF-8' does not match 'text/csv'

having the same issue. may be related to the login issue. what is the content of the return HTML?

content of the return html? It doesn't show anything. It just shows this error handling code.

I believe the get_transactions_csv call to mint expects a CSV formatted file as the return. Instead it's getting HTML. The HTML could be some sort of login or error message. That's why I believe it's related to the login failure issue. Capturing the content of the retuning HTML could give us a clue to what's happening and whether it's related.

This is the HTML that's returned:
``
${{PFMName}} | Access Denied

Perhaps you took a wrong turn?
Sorry about this! Here are a few things you can try:

Log in again
Go to your overview

``

My gut says this is related to the login issue.  My suggestion is to
help/wait for the login to be resolved, then revisit this if necessary.
On Fri, May 27, 2016 at 11:32 AM, lioro<EMAIL_ADDRESS>wrote:

This is the HTML that's returned:
``
${{PFMName}} | Access Denied
http://overview.event
Perhaps you took a wrong turn?
Sorry about this! Here are a few things you can try:

Log in again http:///login.event
Go to your overview http:///overview.event

``
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mrooney/mintapi/issues/74#issuecomment-222206976, or mute
the thread
https://github.com/notifications/unsubscribe/AHFvoBB-4kkvM40XcRqPSLfU-AxGExSfks5qFyqbgaJpZM4Iortw
.

Hello, yes this is most likely the login issue. Thanks folks! I'll close this now.

the return HTML definitely points to the login issue. Non of the other functions that retrieve mint data should work.


Using DeviceFileSource to play audio under windows, when the audio file is changed but the file name is not changed, the old audio is still played.

Checklist

[X] I read the troubleshooting guide before raising this issue
[X] I made sure that the issue I am raising doesn't already exist

Current bug behaviour
I am writing a recording application that uses audioplayers to play back the audio just recorded after the recording is done. This program works fine under macos, audioplayers plays the audio just recorded after each recording, but under windows, audioplayers seems to have a cache, although the file changes after each recording, audioplayers plays the first recording
Expected behaviour
I want to be able to play the latest recorded audio every time on windows as well as on macos
Steps to reproduce

Execute flutter run on the code sample
...
...

Code sample

Code sample
void main() {
}

Affected platforms
Windows
Platform details
No response
AudioPlayers Version
4.1.0
Build mode
No response
Audio Files/URLs/Sources
No response
Screenshots
No response
Logs

my relevant logs

Full Logs

my full logs or a link to a gist

Flutter doctor:
Output of: flutter doctor -v

Related issues / more information
No response
Working on PR
no way

You may have to clear the AudioCache:
AudioPlayer().audioCache.clear(fileName);

Hi @Gustl22,
Thanks for your reply. I have cleared the cache before playing the media, but whether I clear a single cache, or all of them, I still can't play the latest media. Here is my code：
await _audioPlayer.audioCache.clear(path);
      await _audioPlayer.audioCache.clearAll();
      await _audioPlayer.play(
        ap.DeviceFileSource(path),
      );

Okay seems to be a bug then, like the native windows player has it's own cache. You can also try to change the source twice, e.g. setting it to null and then to the source again.


[Feature]: Theme Footer Support link or html or component

What problem does this feature solve?

ICP Filing is supported
Friendship link jump
DIY Footer  component

What does the proposed API look like?
Footer 对象
{
 type: 'html' | 'render','string',
data: obj, // Determine by type Determines the final output object
}

Good advice! And the api would be designed to be more specific.


Sort extra files list

When I upload a cookbook with extra files Chef guard gives a list of the extra files. I would be nice if this list was sorted so it is easier to read and to find the offending files in the filesystem.
Here is an attempted upload of the Windows cookbook after I cloned the git repo.
c:\chef-repo>knife cookbook upload windows --freeze
Uploading windows        [1.39.0]
ERROR: Precondition Failed
Response:
=== Cookbook Compare errors found ===
Your upload contains more files than the source cookbook:
 - chefignore
 - Gemfile
 - .foodcritic
 - MAINTAINERS.md
 - MAINTAINERS.toml
 - Rakefile
 - LICENSE
 - .kitchen.yml
 - .rubocop.yml
 - TESTING.md
 - TODO.md
 - .kitchen.cloud.yml
 - CONTRIBUTING.md

Source: https://supermarket.chef.io/api/v1/cookbooks/windows/versions/1.39.0/download
=====================================

It would be better if the list was sorted
c:\chef-repo>knife cookbook upload windows --freeze
Uploading windows        [1.39.0]
ERROR: Precondition Failed
Response:
=== Cookbook Compare errors found ===
Your upload contains more files than the source cookbook:
 - .foodcritic
 - .kitchen.cloud.yml
 - .kitchen.yml
 - .rubocop.yml
 - chefignore
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - MAINTAINERS.md
 - MAINTAINERS.toml
 - Rakefile
 - TESTING.md
 - TODO.md

Source: https://supermarket.chef.io/api/v1/cookbooks/windows/versions/1.39.0/download
=====================================

Should be easy enough, will have a look at it...

Fixed by PR #108 which is released in v0.7.0


Changing between "find" and "replace" in regex mode corrupts state of find widget

VSCode Version: Code 1.14.2 (cb82febafda0c8c199b9201ad274e25d9a76874e, 2017-07-19T23:26:08.116Z)
OS Version: Linux x64 4.10.0-28-generic
Extensions:

Extension
Author (truncated)
Version

xml
Dot
1.9.2

EditorConfig
Edi
0.9.4

html-css-class-completion
Zig
1.8.0

path-intellisense
chr
1.4.2

vscode-svgviewer
css
1.4.2

vscode-eslint
dba
1.2.11

githistory
don
0.2.2

tslint
eg2
0.17.0

Angular2
joh
2.4.0

debugger-for-chrome
msj
3.1.7

vetur
oct
0.9.3

vscode-icons
rob
7.12.0

Steps to Reproduce:

CTRL+F to show find widget, set Regex mode
Type a simple regular expression that matches some text in your document.  Make some minor changes by typing part of the expression, deleting with backspace, maybe move around the text field with the arrow keys.
CTRL+Z / CTRL+Y several times to undo/redo typing the expression.  Redo until the expression is complete, and ensure that some text in your document matches and gets highlighted.
Once your expression matches something on the page, press CTRL+H.  The "Find" field should change from the expression you just typed to the literal value that was matched.  (This is unexpected behavior, IMHO, but isn't the worst part.)  Your focus should now be in the "Replace" box.
Tab or click back to the "Find" field.
  You should see several characters erased, then replaced with totally different characters as matched literal text is "un-done" and regular expression control characters are "re-done".

Expected behavior:
Ideally, CTRL+F / CTRL+H would only populate the "Find" box with the document selection when it's currently empty.  If you're going to insist on doing this, the undo/redo history should have one entry added at the end that consists of totally erasing the current contents and replacing them with the matched text, as though you had copied the text, selected the contents of the "Find" box, then pasted.

If you don't like the auto population of selection, you can disable it by setting editor.find.seedSearchStringFromSelection to false.
The undo/redo history issue is tracked in https://github.com/Microsoft/vscode/issues/27035

I don't want to turn seedSearchString off for most cases, I like that it populates the widget when it was not already open.  The problem is that you can't use "find" to find something then switch to "replace", at least in regex mode, because of the behavior I described in bullet 4 of the OP.  Should I file a separate suggestion to change the behavior to only "seed" when the widget is first opened?


[logs] add 2 headers containing timestamps in the logs HTTP requests

What does this PR do?

This PR adds 2 new new timestamps in milliseconds:

dd-message-timestamp: contains the max(IngestionTimestamp)
dd-current-timestamp: contains the timestamp of the HTTP request from the agent perspective

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[x] A release note has been added or the changelog/no-changelog label has been applied.
[x] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Create custom crossplane provider for requesting cluster-wide secrets from within an application chart

Use case: SMTP credentials
Template: https://github.com/crossplane/provider-template

Maybe even create special provider-mail for requesting mailboxes with SMTP, IMAP or LMTP credentials.


Added Color Property

Fixes #49
Describe the changes you have made in this PR -
I have Added Color Property to VariableLed, HexDisplay, SevenSegDisplay and SixteenSegDisplay.
Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage remained the same at 84.087% when pulling f7c4439e9a212f722fc0c49712d4fdb9effb061d on Shivansh2407:patch-41 into bc89cead0b643d42eb6c38010b69c2bee52b4fa1 on CircuitVerse:master.

Please review @satu0king 👍

@Shivansh2407  fix code climate issues

@yash15601 actually all the issues are related to code refactoring which is a task to be done during GSoC under Project 2. @satu0king please let me know your views on this 👍

@Shivansh2407 I think I might be missing something obvious here but the color does not change. Can you help me find the code responsible for redrawing the LED with changed color?

ummm...

update?

@Shivansh2407 , as others pointed out the colors don't actually change just be setting this.actualColor, you will need to make changes to the draw logic as well.

Sure, I am working on this and will come up with a fix soon.

Closing this PR as this is for old user interface. Thanks!


Edited partprobe command

There is no need to specify the partition number with the partprobe command. It already detects and updates all partitions on the disk.
Ran into issue while following the documentation where it would show:
azureuser@MC-Server:~$ sudo parted /dev/sdc --script mklabel gpt mkpart xfspart xfs 0% 100%
azureuser@MC-Server:~$ sudo partprobe /dev/sdc1
Error: Could not stat device /dev/sdc1 - No such file or directory.

@roygara
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

emailed author

emailed author

Sent Teams message to @roygara for follow-up 8/9

Response from author: all code changes have to go through the product team. It's blocked on their signoff.

#sign-off


Update MD file on new branch 2017-42-29_15-11-30

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: Added Fbclid config option

Summary

Adds the Fbclid configuration option
Closes https://github.com/amplitude/Amplitude-JavaScript/issues/225

Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:  No

@jarrenpatao How did you test your PR btw?

@jarrenpatao it looks like this is failing at the lint checks (@kelsonpw it's working super well!) - could you run yarn fix to make sure the code adhere's to the style format?

@haoliu-amp I did create-react-app and yarn link an updated version of a cloned repo (7.3.3)


Amended docstring to reflect the actual behaviour of Dataset.map

In MetPy/pull#2312, I noticed that the behavior of Dataset.map's kwarg keep_attrs was not in line with its docstring. This is because in xarray 0.16.2 (pydata/xarray#3595 & pydata/xarray#4195) this behavior was changed.
In short, keep_attrs=True now copies both, the Dataset's and the variables' attributes and adds them to the new objects - preventing any change to them by the mapped function. In contrast, keep_attrs= False discards the Dataset's attributes and does not touch the variables' attributes, enabling the mapped function to modify them.
Here, I propose an update to the keep_attrs docstring of Dataset.map which would more accurately reflect its current behavior. Please feel free to provide alternative formulations if you feel like this one misses the mark.

Looks like this depends on the applied function - can you give an example where it keeps the attrs?
import xarray as xr
import numpy as np
air = xr.tutorial.open_dataset("air_temperature")

assert air.air.attrs != {}
air.map(np.mean)
assert air.map(np.mean).air.attrs == {}

(maybe we should adapt the code instead of the docstring)

you can control the behavior using keep_attrs, either globally using set_options or by passing it to the call:
assert air.map(np.mean, keep_attrs=True).air.attrs != {}

so the docs change does make sense to me

@mathause You are right in the general case. The function we were working with copied the attributes, but the standard behavior is to not explicitly add the attributes in map for dataset and variables. I updated my proposed change.
However, they are also not explicitly deleted after applying func, so func is able to modify them. So i still feel writing `the new object will be returned without attributes.' is misleading
import xarray as xr
air = xr.tutorial.open_dataset("air_temperature")
def func(da):
    ret = da.copy(data=da.data)
    del ret.attrs['units']
    return ret

assert 'units' not in air.map(func, keep_attrs=False).air.attrs
assert air.map(func, keep_attrs=False).air.attrs != {}

I this change makes sense (although I never thought of a custom function copying the attrs).
Thanks for your contribution @lpilz and welcome to xarray!


Uploading and Analyzing Files

Use Streamlit file_uploader and analyze file formats such as pdf, word and excel.
You can use python modules like PyPDF2, python-docx and openpyxl and show a visual summary of the data contained.

Can I work on this ?

Sure!


[BUG] [Fabric] The coordinate of the last disconnect is not saved

Mod Loader

[x] Fabric
[ ] Forge

Versions

SimpleAuth 1.6.1
Fabric API 0.22.1+build409

Describe the bug
You connect in a place you disconnected several days ago but not last time
To Reproduce
Steps to reproduce the behavior:

Connect to the server
Disconnect in one place
Connect 3 minutes later
Connecting and disconnecting multiple times
Disconnect in a different place
Connect and see that you're in the 1st place

Expected behavior
Connecting in the place of your last disconnection
Additional context
This has happened to 2 players in my survival
The first one has passed 2 times, has a very bad pc so sometimes when entering the server it crashes constantly until it finally manages to get in and be online for a good while
The second has a very bad internet and there are times that it is only 20 or 30 minutes just disconnecting and reconnecting, sometimes it has good connection for a few hours
My theory is that when disconnected multiple times it is not saved well and that is why the location is used 1 or 2 days before (although 3 times was only 1 day)

So if I understood correctly;
player leaves on A and upon rejoining is teleported to B (spawn). After successful login, player is teleported to A again. However when they stop playing they are teleported to A again?

Humm, after lots of tries I cannot seem to be able to reproduce this. Even Alt+F4-ing the game during connection proccess it seems to be working normally ...

So if I understood correctly;
player leaves on A and upon rejoining is teleported to B (spawn). After successful login, player is teleported to A again. However when they stop playing (on C) they are teleported to A once more?

something like this, if it goes into the server and had disconnected into B, it connects to A, then if the player has bad connection is disconnected after moving a few blocks, then when connecting it is back in A, then it repeats this a few times until it has stable connection, when it has already been connecting several minutes and disconnects in C it does not happen again

More in context with what happened to the players of my survival:
The first player built his house, I put some logs, then he had to go (A), the next day he came and finished his house (B), the next day he connected where he had disconnected when he built the house (A), was inside logs and after loging he began to suffocate, after moving 2 or 3 blocks he left the connection (C) and when he returned he was back in the logs suffocating (A) , this is repeated a few times until it ends halfway through life with full netherite, when you get a stable connection and it doesn't last less than 2 minutes you end up decorating the inside of your home (D) and the next time you connect it's all right
The second player was looking for elitras in the end, disconnected in 2k (A), the next day he leaves as he had almost no food, then goes home (B), is a while disconnecting and connecting, that night when he has stable connection he will fight the dragon, dies, I do not know where he disconnected but I guess it was at home recovering his things (C) , the next day he comes and is in A

I think #34 could be related. What is described here and above is also what happens in #34:

Player connects at location A, leaves at location B
Player connects at location B, enters a wrong password and gets kicked
Player connects back again, this time at location A.

Sadly, I don't have access to a Fabric server anymore, because the one I was having the issues with closed shortly after I opened #34.
I think this command could be a way to test it easily, but I'm not sure.
public class FooCommand {
    public static void register(CommandDispatcher dispatcher) {
        dispatcher.register(CommandManager.literal("foo").executes(context -> {
            ServerPlayerEntity player = context.getSource().getPlayer();
            player.networkHandler.disconnect(new LiteralText("Foo command"));
            return 1;
        }));
    }
}

Humm, how to describe this ...
It's normal that players get TP-ed around if you use spawnOnJoin, it's not normal, however, that they are not TP-ed back when they enter right password.
I'll try to reproduce it with above command, but I doubt it works differently than normal wrong password disconnect ..?
You can also enable debugMode in config, to see what's happening behind the scenes.


refactor: clean up cascaded-selected example

Hello, this PR is composed by minor clean up in the cascaded-selected example. It:

removes the subscribes, OnDestroy and some unnecessary variables, css classes and inputs;
changes wrong variable names;
creates a model interface and use it instead of any.

Thank you @rafaelss95!


IPT fails to infer geographic scope metadata from source data

Melissa Liu reported issues with the functionality.

@mike-podolskiy90 is this a general IPT issue or specific to an output format (DwC-A + EML, Frictionless)?

@peterdesmet Not sure. Users complained last week that they have issues with the functionality. Need to figure it out
@ManonGros Would be nice to have the source data/mappings and logs. Could you help please?

I have asked @melissa0520, apparently, since then the dataset has been deleted but she might have more examples

@mike-podolskiy90 could you check that dataset? https://training-ipt-b.gbif.org/manage/resource?r=melissa-test I think you should have access to that IPT

@ManonGros Thanks Marie, looking into it

I encountered the same issue for all of the coverages (temporal, geographic and taxonomic) for a dataset that I just published. I made a copy to GBIF's test IPT so that you can have a look at: https://ipt.gbif.org/manage/resource.do?r=species-based-area-protection-in-antarctica
I hope that helps! Thank you for your hard work!

@mike-podolskiy90 Could you tell me whats cause this issue? Thanks!

@melissa0520 Technical issues, internal types mismatch


Where can I find the list of API?

Hello,
I came across your app while looking for Lift.do API to integrate with my app (using node js). Would you be able to share the list of available APIs of Lift.do? Thanks much.

Vu

@tcst ,
You can see the API calls that this gem is using by looking at this file:
https://github.com/jmaddi/liftapp-client/blob/master/lib/liftapp-client.rb
I notice thought, that lift.do has changed to coach.me so let me know if it doesn't work anymore.

@jmaddi Thanks much :)
I will try those. If it doesn't work, do you know how I can look for the updated version? I'm not sure if they plan to (officially) support it in the future.
Thanks,
Vu

Hi @tcst
It is actually quite easy now that they have a web interface. Log in to coach.me with Google Chrome, and open the web inspector at the network tab:

If you select XHR, you should be able to see all the requests the app is making.

Ah that's very smart. Thanks for the tip :+1:  :)


Can't navigate to dynamic pages using

Bug report
Describe the bug
Using @zeit/next-css 1.0.1 for importing CSS files, Links aren't working. Applies in all scenarios: dev, build-start and export.
To Reproduce

Clone and install repo: https://github.com/rasnick/dobuy
Uncomment "import './app.css'" on file /pages/_app.js
run dev, start or export

Expected behavior
Clicking the links should go to their respective dynamic pages.
System information

OS: Ubuntu 18.04.2
Browser (if applies): Firefox
Version of Next.js: 9.0.4
Version of @zeit/next-css: 1.0.1

Additional context
Importing an empty CSS file inside_app.js file is a workaround.
import React from 'react'
import App from 'next/app'

// comment this empty import and the issue is reproduced
import './app.css'

class MyApp extends App {

  render() {
    const { Component, pageProps } = this.props
    return <Component {...pageProps} />
  }
}

export default MyApp

Duplicate of https://github.com/zeit/next-plugins/issues/282


Zonic NFT Testnet Support

Describe the feature request
It would be great if Taiko has Zonic NFT testnet support so developer can test multiple NFT functions after deployment. Functions like minting, unrevealing, burning and whitelisting would be easy for developers to test.
Describe alternatives you've considered
Taiko can come up with its own Testnet NFT marketplace and that would be much better as Zonic is quite slow atm coz of multiple chain support.
Additional context
Additional context here.

Hi @sami1811 , thanks for the issue. Are you a developer/contributor for the Zonic marketplace? It would be nice to have Taiko testnet support in there!
If not, are you interested in trying to build the alternative you mention? I think that would indeed be great if you are up for it.

I'm a developer at beginner level and not yet a contributor but im willing to help always. I can share the idea with zonic team, still waiting for the response. We also need Taiko's own NFT marketplace as im learning frontend i can help with that too.

Hi @sami1811 , thanks for the issue. Are you a developer/contributor for the Zonic marketplace? It would be nice to have Taiko testnet support in there!
If not, are you interested in trying to build the alternative you mention? I think that would indeed be great if you are up for it.

Hi @sami1811 , thanks for the issue. Are you a developer/contributor for the Zonic marketplace? It would be nice to have Taiko testnet support in there!
If not, are you interested in trying to build the alternative you mention? I think that would indeed be great if you are up for it.

I'm a developer at beginner level and not yet a contributor but im willing to help always. I have shared the idea with zonic team, still waiting for the response. We also need Taiko's own NFT marketplace as im learning frontend i can help with that too.

Hi @sami1811 would you like to help to get Zonic to deploy their contracts on Taiko A3 testnet?

I think it's a good idea.

nice

Hi @sami1811 would you like to help to get Zonic to deploy their contracts on Taiko A3 testnet?

I contacted Zonic team they said the team hava listed Taiko and working on it.

Hi @sami1811 would you like to help to get Zonic to deploy their contracts on Taiko A3 testnet?

I contacted Zonic team they said the team hava listed Taiko and working on it.

thanks sami! can you please ask the Zonic team to open an issue here once it is integrated: https://github.com/taikoxyz/taiko-mono/issues/new?assignees=&labels=category.enhancement%2Cstatus.needs-triage&projects=&template=add_project.yml
they can also follow the integration guide here: https://taiko.xyz/docs/resources/integration-guide

@sami1811 Any updates on this?


Support metrics from the beginning

Currently once a user is essentially done with the tutorial and has a working playground, they are told that in order to support metrics they need to tear it down again and re-run the setup with a --with-metrics.
Either one of these alternatives would make for a smoother experience in my opinion:

Just enable it by default. IMO we need to do it like this unless there is a really good reason not to.
Mention the flag in the setup step already.

With the latest changes you can run "--with-metrics" and "--with-logging" without tearing down the existing environment.


Update envtest and unify integration tests running

All Submissions:

[x] Have you signed our CLA?
[ ] Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
[ ] Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@helderjs please open a ticket in jira describing the rationale of this contribution and set in the PR title.


Tweeter Integration Test

High Level Description
Put the tweeter demo into the dcos-integration-test package. It's branched off the currently-unmerged https://github.com/dcos/dcos/pull/1748. I just started this - probably won't even build at this point.
Related Issues
https://jira.mesosphere.com/browse/DCOS-17326
Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@margaret  - if you merge changes from master to this PR. The code-quality test (and perhaps other) could go green.


Sets/Maps/WeakSets/WeakMaps (collections) are not reactive.

Version
2.4.4
Reproduction link
https://jsfiddle.net/z93jk3py/
Steps to reproduce
Create computed value based on Set/Map/WeakSet/WeakMap. update collection, computed value not updated
What is expected?
Expect View to be updated on collection update
What is actually happening?
View not updated.

If not mistaken, development has been done to wrap Arrays methods (pop, push..). Should same be done for methods of aforementioned collections?

Most of those collections not being supported by all browsers we cannot support them yet. I thought this was discussed in another issue but I couldn't find it.
In any case, this is something that will be added to v3 when we drop support for older browsers (https://github.com/vuejs/vue/issues/5893#issuecomment-308925671)

Ah, found it: https://github.com/vuejs/vue/issues/1319#issuecomment-162742130 (thanks to https://github.com/vuejs/vue/issues/5241#issuecomment-288057627)
Just to be clear, it's something that we plan to add on v3 🙂


⚠ Bofrost.fr has degraded performance

In 5dc5972, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2077 ms

Resolved: Bofrost.fr performance has improved in f6b943c.


Alpha build with tools off will not run, missing .pck file.

Godot version:
3.2
OS/device including version:
Windows 10
Issue description:
Compiling Godot from source with: scons platform=windows tools=no target=release creates a dev build that works as expected.
However, changing the command to: scons platform=windows tools=no target=release creates an executable godot.windows.opt.64.exe that, upon running, returns the error message:  "Error: Could not load game data at path '.'. Is the .pck file missing?"
I've also been unable to find build tools for the dev version, I'm currently unable to export games. (I know I shouldn't be using an Alpha version for that purpose, but it would be nice to have the option)

You pasted the same command twice. I assume the first is with tools=yes?
What you describe is expected behaviour, tools=no are the export templates, so they need to be used together with a .pck file. They don't contain the Godot editor to run (which is what tools=yes enables).

If you are trying to build your own export templates, see https://docs.godotengine.org/en/3.1/development/compiling/compiling_for_windows.html#creating-windows-export-templates
You can also pick godot.windows.opt.64.exe as custom release package in your Windows export preset.

Thank you! You are correct about my typo. I now see that I've been misunderstanding what the tools flag does.


Support primary/backup connection pool load balancing strategy

It will be very useful if there was support for primary/secondary (failover) strategy, so that a primary endpoint (say first one added) was used all the time, and only during failures would the subsequent endpoints be used.
.withConnectionPoolLoadBalancingStrategy(LoadBalancingStrategy.ROUND_ROBIN)

Otherwise, to achieve this I think we will need to instantiate multiple clients with different endpoints (not using the batch module) and then have a layer of try/catch. I would like to avoid this and let the library do the failover on failures only. Something like:
.withConnectionPoolLoadBalancingStrategy(LoadBalancingStrategy.FAILOVER)

If that is not something that can be added, could you help me identify if there is any other way I can achieve that without try/catch layer?
Thanks

That is an interesting thought. The problem though is that Simple Java Mail has no way of knowing the severity of any specific failure. It could be a whole range of reasons why something failed (or maybe even partially failed?).
So currently the support for failures is limited to try...catch so any user can implement his strategy for handling this. In your case those could be to try a second (again possibly clustered) mailer with a different endpoint as you say.
If you have more insight as to possible failures or standards for recognising retryable cases, I'm all ears though. 👍

What if just allow the user to call "send" with a primary/backup (or failover flag)?  The library will handle all the connection pooling etc for all endpoints primary(s) and backup(s) endpoints, and the user will simply tell the library which one they want to use.
I agree with you though a user can simply just instantiate 2 MailerGroups, and use one or the other. The library supporting this is just a more out of the box experience, but since the try catch will still be handled by the user, its not as useful.
A user could also provide a failover policy of some sort (like a predicate of some sort), and the library would just delegate that unknown upstream while still providing the failover support.

Yes, there are quite a few ways to approach this. Current workaround / canonical approach is to implement the exceptionHandler of a sent email:
// for async emails (sync emails simple try...catch)
mailer.sendMail(email)
    .whenComplete((result, ex) -> { if (ex != null) sendUsingBackupMailer(email); });

Another approach could be to pass a failover handler, but the problem is determining the underlying cause (server issue vs issue with the email or connection setting on the client side). I would have to defer complete handling resulting not in a failover handler, but a generic exception handler. For this case I think the current implementation is the right abstraction level.
Another approach would be to auto retry n times with a new connection from the same pool each time, going to the same server.
Yet another approach would be an auto try another connection pool (cluster), guaranteeing a different Mailer instance and depending on the configuration guaranteeing a different server.
Of course these approaches could be layered too, performing graceful degradation of sorts.
Something to keep in mind here is that an exception does not automatically mean an email wasn't sent successfully. In theory an exception can occur after getting enough info to the server and depending on the server it could be an atomic or a partial success. Even if the session was a complete success, closing the connection could result in some exception for whatever reason. Automatically retrying in these cases is problematic obviously and I'm not aware of any ISO/RFC defaults of error codes marking these events.

This discussion has rested for some time now, I just reread everything. It's clear Simple Java Mail cannot take responsibility for automatic retries or fail-over strategy, simply because there's nothing to base this decision on. In fact it would be quite a feat if you manage to do this, because if you just catch all exceptions, assume the mail wasn't sent and retry on a backup server, you might end up sending duplicate mails. Unless you have comprehensive exception analyses.
I would be very interested in any such comprehensive exception analyses, but I as don't believe it exists out there, I'm going to go ahead and close this feature request. The example I gave is still the way to go, if you are ready to automate retries yourself (which I advice against, better to have a look at the log/exception first).


Failing helm.test for crds due to missing passworddepot sample within snapshot folder

Describe the bug
After the integration of passworddepot, I realised that the helm.test started to fail for crds_test.yaml.
To Reproduce
Steps to reproduce the behavior:
Update your local repository to the latest version
run make helm.test

Expected behavior
All tests passes.
Screenshots
➜  external-secrets git:(main) make helm.test
./hack/helm.generate.sh deploy/crds deploy/charts/external-secrets
21:29:24 [ OK ] Finished generating helm chart files

### Chart [ external-secrets ] deploy/charts/external-secrets/

 PASS  test cert controller deployment  deploy/charts/external-secrets/tests/cert_controller_test.yaml
 PASS  test controller deployment       deploy/charts/external-secrets/tests/controller_test.yaml
 FAIL  test crds        deploy/charts/external-secrets/tests/crds_test.yaml
        - should match snapshot of default values

                - asserts[0] `matchSnapshot` fail
                        Template:       external-secrets/templates/crds/secretstore.yaml
                        DocumentIndex:  0
                        Path:
                        Expected to match snapshot 1:
                                --- Expected
                                +++ Actual
                                @@ -909,2 +909,42 @@
                                                         - vault
                                +                      type: object
                                +                    passworddepot:
                                +                      description: Configures a store to sync secrets with a Password Depot instance.
                                +                      properties:
                                +                        auth:
                                +                          description: Auth configures how secret-manager authenticates with a Password Depot instance.
                                +                          properties:
                                +                            secretRef:
                                +                              properties:
                                +                                credentials:
                                +                                  description: Username / Password is used for authentication.
                                +                                  properties:
                                +                                    key:
                                +                                      description: |-
                                +                                        The key of the entry in the Secret resource's `data` field to be used. Some instances of this field may be
                                +                                        defaulted, in others it may be required.
                                +                                      type: string
                                +                                    name:
                                +                                      description: The name of the Secret resource being referred to.
                                +                                      type: string
                                +                                    namespace:
                                +                                      description: |-
                                +                                        Namespace of the resource being referred to. Ignored if referent is not cluster-scoped. cluster-scoped defaults
                                +                                        to the namespace of the referent.
                                +                                      type: string
                                +                                  type: object
                                +                              type: object
                                +                          required:
                                +                            - secretRef
                                +                          type: object
                                +                        database:
                                +                          description: Database to use as source
                                +                          type: string
                                +                        host:
                                +                          description: URL configures the Password Depot instance URL.
                                +                          type: string
                                +                      required:
                                +                        - auth
                                +                        - database
                                +                        - host
                                                       type: object
                                @@ -3005,2 +3045,42 @@
                                                       type: object
                                +                    passworddepot:
                                +                      description: Configures a store to sync secrets with a Password Depot instance.
                                +                      properties:
                                +                        auth:
                                +                          description: Auth configures how secret-manager authenticates with a Password Depot instance.
                                +                          properties:
                                +                            secretRef:
                                +                              properties:
                                +                                credentials:
                                +                                  description: Username / Password is used for authentication.
                                +                                  properties:
                                +                                    key:
                                +                                      description: |-
                                +                                        The key of the entry in the Secret resource's `data` field to be used. Some instances of this field may be
                                +                                        defaulted, in others it may be required.
                                +                                      type: string
                                +                                    name:
                                +                                      description: The name of the Secret resource being referred to.
                                +                                      type: string
                                +                                    namespace:
                                +                                      description: |-
                                +                                        Namespace of the resource being referred to. Ignored if referent is not cluster-scoped. cluster-scoped defaults
                                +                                        to the namespace of the referent.
                                +                                      type: string
                                +                                  type: object
                                +                              type: object
                                +                          required:
                                +                            - secretRef
                                +                          type: object
                                +                        database:
                                +                          description: Database to use as source
                                +                          type: string
                                +                        host:
                                +                          description: URL configures the Password Depot instance URL.
                                +                          type: string
                                +                      required:
                                +                        - auth
                                +                        - database
                                +                        - host
                                +                      type: object
                                                     pulumi:

 PASS  test service monitor     deploy/charts/external-secrets/tests/service_monitor_test.yaml
 PASS  test webhook deployment  deploy/charts/external-secrets/tests/webhook_test.yaml

Snapshot Summary: 1 snapshot failed in 1 test suite. Check changes and use `-u` to update snapshot.

As it's an easy "fix", I quickly created #3263


(1.12) Fix tests for schema 0.7.0

High-level description
This is a 1.12 backport of #4597.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4829 tox failure: test_config.test_validate_check_config

Related tickets (optional)
Other tickets related to this change:
N/A
Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: This updates a test to reflect a slight change in user-facing error messages.
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: This fixes a test.
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@meosphere-mergebot label ready for review

@mesosphere-mergebot label ready for review

@mesosphere-mergebot label ready for review

@mesosphere-mergebot merge-it


Provide class level coverage data via OpenCover module

Improve coverage for Clear-Content content command.
PS> $r1 = Get-CodeCoverage ..\..\Coverage.xml; $r2 = Get-CodeCoverage ..\..\ClearContent.xml
PS> Compare-CodeCoverage -Run1 $r1 -Run2 $r2 -class Microsoft.PowerShell.Commands.ClearContentCommand

ClassName                                         Sequence SequenceDelta Branch BranchDelta
---------                                         -------- ------------- ------ -----------
Microsoft.PowerShell.Commands.ClearContentCommand    89.47         31.58    100          20

You have infrastructure changes and new tests in the same commit - this should ideally be either 2 PRs or at least 2 commits.


[stable/pgadmin] Add persistent volume storage class custom definition

Signed-off-by: Alexander Kirillov<EMAIL_ADDRESS>
Is this a new chart
No
What this PR does / why we need it:
This PR adds ability to choose a custom storage class for PersistentVolumeClaim.
Which issue this PR fixes
None to my knowledge
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

/retest


.htm files not opened in LBRY browser

This should be trivial to fix. I've been using HTML files in LBRY for a while. With extension .html they are recognised. With extension .htm they are not. Example:
lbry://declaration_of_independence#b
I tried to find where to fix this in lbry-desktop and lbry-redux but I couldn't find it, sorry.

wow, someone opened my file! made a PR for this.


Add MSRV in the README.md

This adds an MSRV badge in the README.md similar to the regex project.
I got the MSRV from the CHANGELOG.md
Thanks!

Thanks!


Add Nix wrappers

Nix
close #3
close #4
close #5
close #14
close #16
Nix infrastructure.
stackage2nix
Directory contains ready-to-use stackage2nix wrapper with
--all-cabal-hashes and --lts-haskell flags set up. It also has all
required executables on PATH.
Install stackage2nix:
$ nix-env -i -f ./stackage2nix

$ stackage2nix
Missing: (--resolver ARG | STACK_YAML)

stackage
Directory contains derivation that creates Stackage LTS from lts argument.
Build lts-9.0:
$ nix-build --argstr lts lts-9.0 ./stackage

$ ls result
configuration-packages.nix  packages.nix

haskellPackages
Directory contains Stackage LTS packages generated by stackage2nix from this
project's stack.yaml.
lib.nix
Provides Nix expressions for hackage-db, all-cabal-hashes and lts-haskell
sources.

PR addresses usability issues. With Nix wrapper user is not required to set mandatory --all-cabal-hashes and --lts-haskell flags. Wrapper delegates maintenance of these service repositories to Nix.
cc @nc6


Bug: fix to not invoke transfer for call related opcodes (except CALL)

Related spec PR https://github.com/privacy-scaling-explorations/zkevm-specs/pull/335
Summary

Fix to not invoke transfer for call related opcodes (CALLCODE, DELEGATECALL and STATICCALL) expect CALL.
Fix to use current_call.value to setup next-call context for DELEGATECALL.
Add function call_context_as_word and fix current_value to Word type in circuit.

Moved to upstream https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/973


Watcher call twice on  each event.

I working on module that should sync in one local network devices and share data between them.
My problem is next:
After I register new device in network,  watcher start looking on network and waiting for some event. After device is UP, watcher found a bunch of devices in network and start send their info to my device twice. First two times I receive just undefined address of devices. After 15 - 20 seconds I finally got all information about devices and again twice.

Okay. Then I up new device in network and watcher triggered on it. And again I got information about device twice. Then I down device and watcher triggered on it again and on the first time I receive undefined and second one I again got this device as up device.
I try to up second device and again got data twice: first time is the new device data, and second is the old device that should be off.

Is it problem of zeroconf plugin?
Because my code doesn't have anything that can call watcher function twice.
`watchOld() {
        console.log("Watch!")
         this.zeroconf.watch(this.config.connection_type, this.config.domain, (result) => {
               const action = result.action;
               const service = result.service;
                if (action === 'added') {
                   const address = service.ipv4Addresses.length > 1
                    ? service.hostname.replace(/\.$/, '')
                    : service.ipv4Addresses[0];
                console.log("Zeroconf watch result : ", address)
                this.emit('serviceUp', [address], service.port);
            } else if (action === 'removed') {
                this.emit('serviceDown', id);
            }
        }, (err) => {
            throw err;
        });
}`

That's odd. I'll have a look.
if you're interested in ipv4 addresses only, you may be interested in these brand new options for Android:
var zeroconf = cordova.plugins.zeroconf;
zeroconf.registerAddressFamily = 'ipv4'; // or 'ipv6' ('any' by default)
zeroconf.watchAddressFamily = 'ipv4'; // or 'ipv6' ('any' by default)

Could you console.log the whole service object to see what's inside? thank you

Okay.
This is screenshot with services of registered object and watcher object.

So I added
zeroconf.registerAddressFamily = 'ipv4';
It help. I do not received any information with undefined address  after watch()  was called first time.
But I still have duplicating messages from watcher.

I tried to add new device again

And then remove it and got added device with undefined address

And again add another device

I will be glad if you find some solution, because this functionality is very important for me. Yours plugin is unique (any of other plugin can't work with iOS) and I glad that you still working on it.
Thank you!

Please try this branch cordova plugin add https://github.com/becvert/cordova-plugin-zeroconf#1.2.6-dev
You should now check if (action === 'resolved')
Tell us how it goes.

Thank you for answer.
That is great that we have now one more action. Yes, it help remove duplicate items, but sometimes.
I tried test it as much as possible and found next behaviors.
Sometimes on first start watching I have duplicates

After some time, I again got it. I do not off application between time on first screenshot and second.

Next flow will be with deleting.
I restart my application without any devices in network and then UP couples devices and again saw duplicates.

I tried to remove on of them

I start watching some interesting flow of watcher

So resolved action helps. But do not fix duplicating sometimes and not fix caching.
If you need, I can record video with flow of adding and removing devices in network.
Thanks for your help!

OK. I'm not sure I can do more than that.
I'm just passing on the results of the operations of the underlying libraries.
Duplicates could be explained by the following;

before downing your devices be sure to unregister. That may help.

I found that a service can be resolved multiple times,
for instance first time just the hostname is resolved then the ip adresses then again the ip addresses changes (see that with ipv6 with apple devices) then the txtRecord are resolved...

The mdns/bonjour protocols imply some latency and caching, it's not instantaneous. And maybe, but maybe I'm wrong, at interval it sends refresh on the network that trigger new resolve events.

I'd say at this stage you should handle duplicates at the application level. Figure out what you can do according to the added, resolved and removed actions.
Look into the code for improvements.
Learn how the the mdns/bonjour protocols work.
I can't spend much more time on this right now.
But thanks to you, I feel this plugin's been improved.
I'll do a new release sometime soon

@becvert Okay, I understand. Thank you for you help 👍


Adding Songs to playList takes time

The add function initially returns false, but after some time, the songs are successfully added to the playlist and I keep getting this error
Attempted to register account monitor for types client is not authorized to access: {(
"com.apple.account.iTunesStore"
)}

The error:
Attempted to register account monitor for types client is not authorized to access: {(
"com.apple.account.iTunesStore"
)}

Can be ignored as it is not relevant.
For the first part, it does take some time to add songs to the playlist, similar to how it takes some time to create a new playlist. I will look into it on how the success should wait and return true when the songs are added

Okay.Thanks


Flash and RAM size optimization

@pavel-kirienko For a communication library like UAVCAN I would have expected -Os as the default optimisation level - is there a particular reason its -O3? How can I change this to -Os for the PX4 build?

-Os used to break GDB, see https://github.com/UAVCAN/libuavcan/issues/33#issue-81527235. Also, last time we tried -Os there was no significant benefit in terms of footprint. @davids5
In this branch I'm currently working on a total refactoring of memory management in libuavcan; I expect it to bring a drastic improvement in both ROM and RAM. There's also one radical and questionable design decision that we're probably going to have to discuss a bit later.

How can I change this to -Os for the PX4 build?

In CMakeLists.txt of the uavcan module in PX4, after inclusion of the library:
target_compile_options(uavcan PRIVATE -Os)

This, however, requires CMake 2.8.12, which is relatively new but comes as default in e.g. Ubuntu 14.04. Another approach is to add a variable containing optimization level that the libuavcan subproject will be picking up.


README: add notes on crdb client requirement

The crdb client is required for running tests and setting up a local docker instance, add a note that helps new users.
cc: Mark Hahn

Codecov Report

Merging #175 (a912834) into main (f120866) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   72.44%   72.44%
=======================================
  Files          35       35
  Lines        3321     3321
=======================================
  Hits         2406     2406
  Misses        673      673
  Partials      242      242

Flag
Coverage Δ

unittests
72.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Extension Not Working At All

I just installed the extension for my vs code and it's not working at all, none of the settings i'm trying to apply are being applied, i even tried installing the vs code system setup but it's still not working at all

It's working now and i dont know why honestly maybe it's because i installed it after i installed vscode animations(that sounds daft i know but that's the only different thing i did), Thank you for the amazing extension btw


Minor bugfixes for precomf/packmp3/packjpg

Fixed init_comfort(): init JPG/MP3 suppression

Fixed memory leak and bad huffman table check in packMP3
https://github.com/packjpg/packMP3/commit/0c283d8e1caaef9347bfebe18a341a8df8ef6b24

packjpg: add extra range to 172 when (1024+6-1)/6 = 171.5
https://github.com/packjpg/packJPG/issues/4

add x64 to VS project with BIT64;COMFORT;

[ ] #57 Not fully tested: Update to liblzma xz-5.2.3 released on 2016-12-30.

The packjpg change succeeds in compressing the sample file from https://github.com/packjpg/packJPG/issues/4, but crashes on other
files, so I'll undo it for now. Two examples that lead to crashes:

SHA-1 checksums:
6ad0e405b4351e5446f86a131d58dabd24c15a4f
5f7134fef5c0684f87e961378d6836dc4057393b

Tested this a bit further, looks good, so I'll finally merge it.

MP3 memory leak fix confirmed - in my tests, about 30 KB per MP3 file were leaking in old version
updated liblzma works