Update Pagerduty SSO SAML Certificate

User Need
As an Engineer
I want to be able to access Pagerduty via SSO
so that I can use my MoJ identity to login rather than having a separate password.
Value
Continued provision of SSO enables users to login with MoJ identity.
Functional Requirements:
Pagerduty has SSO set up via the Ops Eng Auth0 tenant. There is a possibility that our users will not be able to log in to PagerDuty via SSO after Monday April 15th unless appropriate action is taken to update the SAML certificate.
Step 1. Verify is we are using the SAML metadata endpoint. If we are then no further action is required. Ticket can be closed.
Step 2. If we are not using SAML metadata endpoint then we will need to update the SMAL cert.
Instructions:

Action is required if your identity provider is configured with a static copy of PagerDuty's SAML signing certificate (also known as “pinning” the certificate). You will need to update those settings in your identity provider in advance of April 15th to make sure that your employees will continue to be able to login to PagerDuty via Single Sign On.
The new certificate can be downloaded from the following URLs:
End entity: https://www.pagerduty.com/assets/certs/saml_pagerduty_com.pem
End entity and intermediate CA certificate in one file: https://www.pagerduty.com/assets/certs/saml_pagerduty_com_end_entity.pem
For identification purposes:
The new certificate's serial number: 05b5c90562cfa1992582fba45f486890
The old certificate's serial number: 07F4795915DC53591A61AA4AD51095D8

Acceptance Criteria:

Confirm whether update is required and/or update certificate

Notes:
Link to email - https://groups.google.com/a/digital.justice.gov.uk/g/operations-engineering/c/0S7vi5WDHmk/m/mevTGsPLAQAJ

Verified that we are using the SAML metadata endpoint. No action required.


ci: podvm-mkosi: workflow not working correctly

In running the https://github.com/confidential-containers/cloud-api-adaptor/actions/workflows/podvm_mkosi_image.yaml
recently we are seeing a failure:
#2 [internal] load metadata for docker.io/library/fedora-binaries-builder-s390x:latest
#2 ERROR: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
------
 > [internal] load metadata for docker.io/library/fedora-binaries-builder-s390x:latest:
------

 1 warning found (use --debug to expand):
 - InvalidDefaultArgInFrom: Default value for ARG ${BUILDER_IMG} results in empty or invalid base image name (line 9)
Dockerfile.podvm_binaries.fedora:9
--------------------
   7 |     ARG BUILDER_IMG
   8 |
   9 | >>> FROM ${BUILDER_IMG} AS podvm_builder
  10 |
  11 |     ARG CLOUD_PROVIDER
--------------------
ERROR: failed to solve: fedora-binaries-builder-s390x: failed to resolve source metadata for docker.io/library/fedora-binaries-builder-s390x:latest: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

The fedora-binaries-builder-s390x image is built in the previous step, so I guess there is an issue with docker contexts or something where the image can't be found locally anymore, hence looking on docker hub?

cc @BbolroC @genjuro214

It looks like buildkit v0.15.0 that released two weeks ago added InvalidDefaultArgInFrom validation: https://github.com/moby/buildkit/releases/tag/v0.15.0, so that is probably the reason it is failing now?

@BbolroC - not urgent, but it would be interesting to check if the local image is present and if there are any more clue on the s390x runner - if that's possible?

Yes, the image is present:
$ docker images
REPOSITORY                      TAG               IMAGE ID       CREATED         SIZE
fedora-binaries-builder-s390x   latest            e5bd625a7aab   2 minutes ago   3.56GB
moby/buildkit                   buildx-stable-1   47bee0bebd30   13 days ago     214MB

I got the same CI failure on my runner. I will dig into it a little bit and raise a PR to resolve this. Thanks!

Thanks! @BbolroC CC @liudalibj


Added scriptedUpsert and detectNoop options to UpdateOperation

Description
Adds missing properties scriptedUpsert and detectNoop to UpdateOperation
This is the same as https://github.com/opensearch-project/opensearch-java/pull/748 and https://github.com/opensearch-project/opensearch-java/pull/750
*** Please backport to 2.8 ***
Issues Resolved
Fixes https://github.com/opensearch-project/opensearch-java/issues/744
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I tried to perform the same thing by cherry-picking fs-chris's changes onto mainline branch locally as in https://github.com/opensearch-project/opensearch-java/compare/main...zjianyu21:opensearch-java:issue-750
But I'm not familiar with Github operations which took me a while to commit to the branch above. It seems that this change just got merged in this morning.


[PRO] public subnets is not created

Using the following code, I expect to see 3 subnets create - a private with NAT, isolated, and a public.
const vpc = new ec2.Vpc(this, `${id}CoreVpc`, {
    maxAzs: 1,
    cidr: scope.node.tryGetContext('cidr') || process.env.VPC_CIDR || '<IP_ADDRESS>/16',
    natGateways: 1,
    vpcName: `${name}-vpc`,
    subnetConfiguration: [{
        name: `${stage}-private-subnet`,
        subnetType: ec2.SubnetType.PRIVATE_WITH_NAT,
        cidrMask: 24,
    }, {
        name: `${stage}-public-subnet`,
        subnetType: ec2.SubnetType.PUBLIC,
        cidrMask: 24,
        mapPublicIpOnLaunch: true,
    }, {
        name: `${stage}-isolated-subnet`,
        subnetType: ec2.SubnetType.PRIVATE_ISOLATED,
        cidrMask: 28,
    }],
});

Output:
VPC
{
            "CidrBlock": "<IP_ADDRESS>/16",
            "DhcpOptionsId": "dopt-7a8b9c2d",
            "State": "available",
            "VpcId": "vpc-912e4792",
            "OwnerId": "000000000000",
            "InstanceTenancy": "default",
            "Ipv6CidrBlockAssociationSet": [],
            "CidrBlockAssociationSet": [
                {
                    "AssociationId": "vpc-cidr-assoc-b57c5b2e",
                    "CidrBlock": "<IP_ADDRESS>/16",
                    "CidrBlockState": {
                        "State": "associated"
                    }
                }
            ],
            "IsDefault": false,
            "Tags": []
        }

Subnets
{
            "AvailabilityZone": "us-east-1a",
            "AvailabilityZoneId": "use1-az6",
            "AvailableIpAddressCount": 251,
            "CidrBlock": "<IP_ADDRESS>/24",
            "DefaultForAz": false,
            "MapPublicIpOnLaunch": false,
            "State": "available",
            "SubnetId": "subnet-043cbbc5",
            "VpcId": "vpc-912e4792",
            "OwnerId": "000000000000",
            "AssignIpv6AddressOnCreation": false,
            "Ipv6CidrBlockAssociationSet": [],
            "SubnetArn": "arn:aws:ec2:us-east-1:000000000000:subnet/subnet-043cbbc5"
        },
        {
            "AvailabilityZone": "us-east-1a",
            "AvailabilityZoneId": "use1-az6",
            "AvailableIpAddressCount": 250,
            "CidrBlock": "<IP_ADDRESS>/24",
            "DefaultForAz": false,
            "MapPublicIpOnLaunch": false,
            "State": "available",
            "SubnetId": "subnet-bb515ce0",
            "VpcId": "vpc-912e4792",
            "OwnerId": "000000000000",
            "AssignIpv6AddressOnCreation": false,
            "Ipv6CidrBlockAssociationSet": [],
            "SubnetArn": "arn:aws:ec2:us-east-1:000000000000:subnet/subnet-bb515ce0"
        },
        {
            "AvailabilityZone": "us-east-1a",
            "AvailabilityZoneId": "use1-az6",
            "AvailableIpAddressCount": 11,
            "CidrBlock": "<IP_ADDRESS>/28",
            "DefaultForAz": false,
            "MapPublicIpOnLaunch": false,
            "State": "available",
            "SubnetId": "subnet-d1c2ad16",
            "VpcId": "vpc-912e4792",
            "OwnerId": "000000000000",
            "AssignIpv6AddressOnCreation": false,
            "Ipv6CidrBlockAssociationSet": [],
            "SubnetArn": "arn:aws:ec2:us-east-1:000000000000:subnet/subnet-d1c2ad16"
        }

I would have expected subnet-bb515ce0 to have MapPublicIpOnLaunch set to true. I've tried various configurations to debug this (i.e. using the default configuration for vpcs by omitting the subnetConfiguration, only specifying the public configuration) without any luck.
There is a pre-existing default VPC, but I've verified that no configuration is shared:
{
            "CidrBlock": "<IP_ADDRESS>/16",
            "DhcpOptionsId": "dopt-7a8b9c2d",
            "State": "available",
            "VpcId": "vpc-2d9e57fd",
            "OwnerId": "000000000000",
            "InstanceTenancy": "default",
            "Ipv6CidrBlockAssociationSet": [],
            "CidrBlockAssociationSet": [
                {
                    "AssociationId": "vpc-cidr-assoc-7d41565d",
                    "CidrBlock": "<IP_ADDRESS>/16",
                    "CidrBlockState": {
                        "State": "associated"
                    }
                }
            ],
            "IsDefault": true,
            "Tags": []
        }

I've attached the output log from my locastack container.
Could this be something up with the cdklocal library or maybe something with localstack (or my configuration)?
localstack_output.txt

Any guidance on this?

Hi @whummer just confirmed that most of this appears to be fixed. I am able to use public and private subnets now, but isolated subnets are still missing from the returned VPC resource. Is that related to the original issue?

Hi! We just wanted to follow up on our last message to see whether your issue has been resolved. Were you able to get it working with the latest version of LocalStack? We would appreciate your feedback!

Closing the issue due to inactivity.


Trouble building after installing react-native-fbsdk-next in managed Expo workflow

Hey,
I was curious if anyone has seen this build error before (CocoaPods could not find compatible versions for pod "ExpoAdapterFBSDKNext")? I looked through the Troubleshooting section in the docs, but I'm running with a managed Expo workflow, so a lot of the fixes don't apply. Happy to provide more details on request, just wasn't quite sure where to start.
[INSTALL_PODS] /private/var/folders/vr/0_c1zf616_v1lp8wcbhj7nmc0000gn/T/eas-build-local-nodejs/2d693dfe-232f-405b-bb32-4a8cb7fd611a/build/node_modules/react-native-fbsdk-next/react-native-fbsdk-next.podspec:4: warning: already initialized constant Pod::FBSDKVersion
[INSTALL_PODS] /private/var/folders/vr/0_c1zf616_v1lp8wcbhj7nmc0000gn/T/eas-build-local-nodejs/2d693dfe-232f-405b-bb32-4a8cb7fd611a/build/node_modules/react-native-fbsdk-next/react-native-fbsdk-next.podspec:4: warning: previous definition of FBSDKVersion was here
[INSTALL_PODS] [!] CocoaPods could not find compatible versions for pod "ExpoAdapterFBSDKNext":
[INSTALL_PODS]   In Podfile:
[INSTALL_PODS]     ExpoAdapterFBSDKNext (from `../../node_modules/react-native-fbsdk-next/ios`)
[INSTALL_PODS]
[INSTALL_PODS] Specs satisfying the `ExpoAdapterFBSDKNext (from `../../node_modules/react-native-fbsdk-next/ios`)` dependency were found, but they required a higher minimum deployment target.

but they required a higher minimum deployment target

https://search.brave.com/search?q=but+they+required+a+higher+minimum+deployment+target+expo&source=desktop
So can you edit your Podfile and bump the target to match the new higher requirement that all the other Expo people asserted quite decisively needed to change in #346 / #352?
Or use Expo47 ?

Super appreciate the quick response @mikehardy! That did it :)

excellent, good luck on your project


Slow Queries Not Showing in Database Context

I can see that the collection is running and there are entries on the grid for the database at the server level, but if you click on the database and go to Slow Queries there is nothing populating.  I'm on the latest version.

Server Level:

Database Level:

Hi, it seems to be working for me.  Are there definitely slow queries associated with the selected database when you see it grouped by database at the server level?  Does the database have a strange name - containing a % character maybe?  The dynamic SQL generated to filter the DB name will either be:
AND D.name LIKE @DatabaseName

or
AND D.name = @DatabaseName

Depending if the DB name contains a % character.

Some info to assist troubleshooting:
This extended events session can be created to capture the queries ran by the DBA Dash GUI:
CREATE EVENT SESSION [DBADashGUI] ON SERVER
ADD EVENT sqlserver.rpc_completed(
    WHERE ([sqlserver].[client_app_name]=N'DBADashGUI')),
ADD EVENT sqlserver.sql_batch_completed(
    ACTION(sqlserver.client_app_name)
    WHERE ([sqlserver].[client_app_name]=N'DBADashGUI'))
WITH (MAX_MEMORY=4096 KB,EVENT_RETENTION_MODE=ALLOW_SINGLE_EVENT_LOSS,MAX_DISPATCH_LATENCY=30 SECONDS,MAX_EVENT_SIZE=0 KB,MEMORY_PARTITION_MODE=NONE,TRACK_CAUSALITY=OFF,STARTUP_STATE=OFF)

At the server level, DBA Dash will run a query similar to this- replacing the InstanceIDs and date parameters:
exec dbo.SlowQueriesSummary_Get @InstanceIDs=N'123',@FromDate='2022-12-15 13:38:18.127',@ToDate='2022-12-15 14:38:18.127',@GroupBy=N'DatabaseName',@Top=20

You can find the instance ID in the dbo.Instances table.
At the database level it will alter this query to pass in the @DatabaseName parameter - and change the group by.
exec dbo.SlowQueriesSummary_Get @InstanceIDs=N'169',@FromDate='2022-12-15 13:38:28.370',@ToDate='2022-12-15 14:38:28.370',@GroupBy=N'object_name',@DatabaseName=N'4Projects_3G_FT_Master',@Top=20

If You pass @Debug=1 it will print out the dynamic SQL that gets executed.
Hope this helps.  Let me know if you find anything.

This is what I see when I run the queries and even just look at the raw data:

This should be working for Azure DB.  The extended event captures the database_id.  This is associated with a database on import when the application runs SlowQueries_Upd.
FROM @SlowQueries SQ
LEFT JOIN dbo.Databases D ON D.database_id = SQ.database_id AND D.InstanceID = @InstanceID AND D.IsActive=1

If the databases collection isn't running or if it has issues this would explain why it's not working.  Try running this:
SELECT * FROM dbo.Databases WHERE InstanceID = 374

For Azure DB there will be a 1:1 mapping of databases to instances.  You should get a single row returned.  Check the IsActive column is 1 if you get a row back.  If you don't get a row, check that the Databases collection is enabled and check to error log to see if there are any issues for this collection.
Note: If you get the Databases collection working, it will only fix new stuff going forward.
Let me know what you find.

Yes, it is active in the Databases table.

That could suggest that the database_id captured by the extended event is different to the one captured in dbo.Databases for that instance.  Usually, queries are limited in Azure to span a single database.  Cross-database queries are possible though so maybe that's an explanation.  I don't think we should be seeing queries from a different DB in an elastic pool - I might be wrong though.

I'm running a mass update to apply the DatabaseID to any record with it NULL that has a concatenated ConnectionID, doing a join between Instances and Databases.  It seems to be working to get the data to show up in the GUI.  Once done I'll see if new entries are still getting a NULL value.  Is it possible anything changed after around 11/15 that could have been missed if we had Persist XE Sessions enabled on all of them (because we had to set the memory lower on them)?

I looked at the live data for the database in Azure and it is 42 (same in the extended events raw data), but in the dbo.Databases table in the DBADash database it shows as Database_Id = 5.  Not sure why that is, but I know that DB_ID() can change in Azure at any time because of the way they migrate databases between hardware.  We've had to deal with that and not use ID now, but name on the instance.

The DatabaseID issue doesn't seem to come up for the AzureDB instances I monitor.  Maybe this issue occurs as the result of elastic/cross database queries.
For AzureDB the app can probably just drop the @DatabaseName filter as there is a 1:1 mapping between InstanceID and DatabaseID anyway.

Or this suggests it's probably related to failover:
https://dba.stackexchange.com/questions/138809/database-id-for-our-database-in-sys-databases-does-not-match-that-of-db-id-o
https://social.technet.microsoft.com/Forums/en-US/20791489-fad8-4469-98f5-1749d9450949/database-id-gets-changed?forum=ssdsgetstarted

Included in 2.33.0 🎉


PlutoUI v0.7.22 breaks DataFrames.combine

Expected:

with PlutoUI v0.7.22:

using
PlutoUI v0.7.22
DataFrames v1.3.0

The notebook can be fixed by adding using DataFrames: combine, but maybe it'd be nice if it would work without?
Thanks for you awesome work :)

☹

Since this feature wasn't heavily advertised yet, I think it's fairly safe to remove the export and tag a release today. People should use it with PlutoUI.combine


timeout setting parameters via MAVProxy/Dronekit API

Hi,

I'm executing a test.py script which is an exercise using basics of dronekit/MAVProxy and Wx to make a GUI, as shown on the attached picture.
I systematically get an error message when trying to set a parameter (as shown on picture). I also get these same timeout errors when using the official examples .py scripts (like vehicle_state.py).
I do not get these problems when I run the "Param set FS_BATT_ENABLE 2" on the MAvproxy prompt.
Any idea what is the cause ?  (note : all other communications with Pixhawk seem to work, like changing or reading a vehicle mode or reading parameters is also fine)

apparently this is still an open bug, because eventhough "timeout" is displayed, the parameter is actually changed.
It is a false timeout message but what is really annoying is that this adds a delay of a few seconds for each parameter's write/set command !

Closing. This is a duplicate of #12.
The defect is a known issue that has been around for ages. We are expecting this to be fixed by DKPY 2.0 which brings a new architecture. This should be out in the "coming months". In the meantime all you can do is ignore the error.


Dsf nodes

Adding support for new DSFnode API call. General improvements to SDK in TrafficManager also included.

FWIW, the only disruptive change here is that DSF nodes are returned as Node Objects now. I've been thinking about this, and I might just make another getter that pulls nodes as node objects, and keep the old ones as returning zone, fqdn dict. Internally, nodes are held as Node Objects now, as opposed to Hashes.

Disruptive changes have modified, and a small bug I noticed with Circular Imports has been fixed.


Mysterious undefined events

Apparently from Twitter in my case, resulting in errors like this:
6 Oct 13:15:18 - error: Received a 404 when attempting to enrich search results from http://localhost:8042/Me/undefined/timeline/4e8e0539d34ee692d00141b7

Haven't seen any instances since Temas' commit. I believe this is fixed now.


In particular devices, entities created with RELATIVE_TO_GROUND don't show up correct.

Hi.
I came from this topic.
https://groups.google.com/forum/#!topic/cesium-dev/9IvH5wGY51s
I'm developing an Android App. And testing on few devices.
Two of my devices has problems.
HUAWEI MediaPad M5 (Android 9)
HUAWEI MediaPad T5 (Android 8)
When creating an entity, setting the heightReference to 'RELATIVE_TO_GROUND'.
The entity seems to be under the surface. And for some reason the normals looks flipped.
Please look at the screenshots I post at the other topic.
For me only the HUAWEIs have this issue. Especially, if someone has a HUAWEI please check this Sandcastle.
https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=Geometry Height Reference.html&label=Geometries

Here's the screenshot from the linked thread:

Clamping to ground doesn't work, but more bizarrely, the normals look reversed (but only when the entity's height reference is set to relative to ground or clamp to ground). Another broken Sandcastle is this one:
https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=Circles and Ellipses.html&label=Geometries
Where the cylinder shows up distorted:

This is how it's supposed to look:

This kind of reminds me of this distorted vertices bug in iOS: https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2FAnalyticalGraphicsInc%2Fcesium%2Fissues%2F7100&sa=D&sntz=1&usg=AFQjCNFyzwoOmfEtCBWnVpU8kYrC1y8E0w


PythonCall

Played around with the ast module to try and fix the problems of https://github.com/PumasAI/QuartoNotebookRunner.jl/pull/180, mainly that the "Python" code there actually had to be valid Julia syntax, too, and that it wouldn't work with multiple expressions or any more complex thing.
Python only allows eval to be called on certain expressions and we can use ast to analyze whether we got those. Otherwise we call exec. One more special case is assignments, where we first exec and then eval the variable out.
I got this working so far:
---
engine: julia
execute:
  error: true
---

```{julia}
using PythonCall
```

```{python}
a = 1 + 3
b = range(1, 10)
```

```{python}
a
```

```{python}
def myfunc(x):
    return x + 2

myfunc(b[0])
```

I played around with this a bit and I had to rebase this to main, to make it work on julia 1.11.
The simple example works where I am only calling the re library from python, but I am trying to load rasterio and there I get a strange error when I am running the notebook via QuartoNotebookRunner.
When I am importing rasterio via PythonCall from the REPL it works and it picks the right rasterio version that is installed via CondaPkg locally.
Do you have any pointers where the mismatch might happen?
This is the error I get:

Details
ERROR: Julia server returned error after receiving "run" command:
Failed to run notebook: /home/fcremer/Documents/NFDI4Earth/lhbarticles/Intro_Raster_Data_Analysis_ENG_subset.qmd
ERROR: EvaluationError: Encountered 1 error during evaluation

Error 1 of 1
@ /home/fcremer/Documents/NFDI4Earth/lhbarticles/Intro_Raster_Data_Analysis_ENG_subset.qmd:119
Python: ImportError: /home/fcremer/Documents/NFDI4Earth/lhbarticles/.CondaPkg/env/lib/python3.11/site-packages/rasterio/../../.././libspatialite.so.7: undefined symbol: xmlNanoHTTPCleanup, version LIBXML2_2.4.30
Stacktrace:
  [1] pythrow()
    @ PythonCall.Core ~/.julia/packages/PythonCall/Nr75f/src/Core/err.jl:92
  [2] errcheck
    @ ~/.julia/packages/PythonCall/Nr75f/src/Core/err.jl:10 [inlined]
  [3] pycallargs(f::Py, args::Py)
    @ PythonCall.Core ~/.julia/packages/PythonCall/Nr75f/src/Core/builtins.jl:220
  [4] pycall(::Py, ::String, ::Vararg{Any}; kwargs::@Kwargs{})
    @ PythonCall.Core ~/.julia/packages/PythonCall/Nr75f/src/Core/builtins.jl:243
  [5] pycall(::Py, ::String, ::Vararg{Any})
    @ PythonCall.Core ~/.julia/packages/PythonCall/Nr75f/src/Core/builtins.jl:233
  [6] (::Py)(::String, ::Vararg{Any}; kwargs::@Kwargs{})
    @ PythonCall.Core ~/.julia/packages/PythonCall/Nr75f/src/Core/Py.jl:357
  [7] pyexec
    @ ~/.julia/packages/PythonCall/Nr75f/src/Core/builtins.jl:1326 [inlined]
  [8] pyexec
    @ ~/.julia/packages/PythonCall/Nr75f/src/Core/builtins.jl:1331 [inlined]
  [9] pyexec(code::String, globals::Module)
    @ PythonCall.Core ~/.julia/packages/PythonCall/Nr75f/src/Core/builtins.jl:1331
 [10] top-level scope
    @ ~/Documents/NFDI4Earth/lhbarticles/Intro_Raster_Data_Analysis_ENG_subset.qmd:159

ERROR: Internal julia server error

Stack trace:
    at writeJuliaCommand (file:///opt/quarto/bin/quarto.js:41397:19)
    at eventLoopTick (ext:core/01_core.js:175:7)
    at async executeJulia (file:///opt/quarto/bin/quarto.js:41291:22)
    at async Object.execute (file:///opt/quarto/bin/quarto.js:41028:20)
    at async renderExecute (file:///opt/quarto/bin/quarto.js:85764:27)
    at async renderFileInternal (file:///opt/quarto/bin/quarto.js:85932:43)
    at async renderFiles (file:///opt/quarto/bin/quarto.js:85800:17)
    at async render (file:///opt/quarto/bin/quarto.js:90702:21)
    at async renderForPreview (file:///opt/quarto/bin/quarto.js:91729:26)
    at async render (file:///opt/quarto/bin/quarto.js:91612:29)

Ok, I found the mismatch. Since in my example I am also loading geo related Julia packages i ran into https://github.com/JuliaPy/PythonCall.jl/issues/397 and thereby I had a mismatch in the versions that are used from python and from Julia


Compatibility with 2018.1?

Hi, I'm wondering which commit is the latest to still work with Unity 2018.1.
I tried the most recent and it isn't working, even when importing the namespace and putting Naughty Attributes in my Assets root directory.
Any suggestions appreciated other than upgrading Unity. Thanks!

I found that this commit is the latest compatible:
https://github.com/dbrizov/NaughtyAttributes/tree/3793b854c04ea4cd05d563050ec989a8313e78da
Although I'm sure someone could implement features added after that point into this version.


[BugFix] Fix object column query stats cache throw semantic exception

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

@mergify backport branch-2.4

run starrocks_admit_test

run starrocks_fe_unittest


More informative error message on file does not exist

The following error was give when the input file was not found.
stack traceback:
	[C]: in function 'error'
	lib/image_loader.lua:136: in function 'load_float'
	waifu2x.lua:41: in function 'convert_image'
	waifu2x.lua:294: in function 'waifu2x'
	waifu2x.lua:299: in main chunk
	[C]: in function 'dofile'
	/root/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
	[C]: at 0x55f12faeb570

It should be easy to add an error message eg. "Input file not found" to indicate the error.

Doesn't show before stacktrace?
/home/nagadomi/torch/install/bin/luajit: lib/image_loader.lua:136: hoge.png: failed to load image
stack traceback:
	[C]: in function 'error'
	lib/image_loader.lua:136: in function 'load_float'
	waifu2x.lua:41: in function 'convert_image'
	waifu2x.lua:294: in function 'waifu2x'
	waifu2x.lua:299: in main chunk
	[C]: in function 'dofile'
	...domi/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
	[C]: at 0x55f42910c710

https://github.com/nagadomi/waifu2x/blob/7d156917ae1113ab847dab15c75db7642231e7fa/waifu2x.lua#L42-L44
It is my laziness to throw an exception as an error message, though.

I tested it again over ssh, it did show the error message. I was using google colab's console before, it does have a tendency to not show command outputs correctly.


Added Facade for easy Flagsmith access

How about adding a Facades to retrieve the Flagsmith instance?
use Clearlyip\LaravelFlagsmith\Facades\LaravelFlagsmith;

// retrieve FlagSmith instance and call directly its function
LaravelFlagsmith::getFeatureValue( 'feature1' );

This is great! any reason to not just call it "Flagsmith"?

This is a good Point, makes more sense to call it directly Flagsmith.
Something else that I was thinking about was your UserTrait, which makes totally sense as long as you have a User.
If you have a system where you start without users you would probably access Flagsmith with this new Facade:
use Clearlyip\LaravelFlagsmith\Facades\Flagsmith;

Flagsmith::getFeatureValue( 'feature1' );

Later in the project you will introduce the User and then you have to adjust all your Facade calls with the usertrait methods. So I was wondering if it would make sense to add a little more logic to the Facade so that it will send the logged in/passed user to the Flagsmith API based on the config.
This way the User Trait methods would be reduced into simple Facade calls:
public function getFeatures(): array {
  return Flagsmith::getFeatures( $this );
}

And the getFeatureIdentity functionality would be on the Facade instance.
This way you just use the Facade everywhere and you have additional helper methods on the UserTrait that will invoke properly the Facade.
Do you see what I mean? ;)
Do you think that makes sense? I can adjust the PR if you like...

This way the User Trait methods would be reduced into simple Facade calls:

The user trait calls need to not call Facades. The reasoning is when you call a user outside of being logged in and you want to access that user's flags.

See: https://github.com/clearlyip/laravel-flagsmith/pull/5


is there a way to add image or background image to a button

I tried to add a picture to the raised button but it doesn't work is there a solution for that ?

Download source code and make your own "MaterialDesignImageButton"
Or if you want to wait you can tell author to make one.
W dniu śr., 29 kwi 2015 o 15:06 akimu13<EMAIL_ADDRESS>napisał(a):

I tried to add a picture to the raised button but it doesn't work is there
a solution for that ?
—
Reply to this email directly or view it on GitHub
https://github.com/IgnaceMaes/MaterialSkin/issues/46.

There currently is no way of doing this in the official build, and I'm also not planning to support it as it isn't specified in Google's Material Design Principles.
As said by DarkKinightKirito, you could fork the project and make one yourself. I wouldn't be that difficult.

Hi,
I am currently new to User Control. I need to add icon to the button. Can you please help me out on how to achieve this?
Thanks


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_93id9z0o48/clone/recipe/meta.yaml:18: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_93id9z0o48/clone/recipe/meta.yaml:22: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_93id9z0o48/clone/recipe/meta.yaml:25: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_93id9z0o48/clone/recipe/meta.yaml:32: python_build_tool_in_run: The python build tool setuptools is in run depends
WARNING: /tmp/abs_93id9z0o48/clone/recipe/meta.yaml:55: missing_description: The recipe is missing a description
Errors were found


AI page rank repos

Taking the top p% of contributors by their PageRank score and identify which repos they also belong to.

@Prudhvivuda Is this based off of one of the WASM notebooks? if so can you link it?

@Prudhvivuda Is this based off of one of the WASM notebooks? if so can you link it?

sure. https://github.com/oss-aspen/Rappel/blob/main/notebooks/project_discovery/pagerank_top_repos/top_pagerank_common_repos.ipynb


"Requirements for continuous deployment" section is misleading

https://docs.microsoft.com/en-us/azure/azure-functions/functions-continuous-deployment
The given example:
FunctionApp
 | - host.json
 | - MyFirstFunction
 | | - function.json
 | | - ...
 | - MySecondFunction
 | | - function.json
 | | - ...
 | - SharedCode
 | - bin

actually refers to the expected output structure while it can make readers think they should make their source tree look like this, and function.json is not mentioned anywhere else in this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a34424e-6a23-5517-5755-c9282643876f
Version Independent ID: 1c375649-94d6-863a-203b-cb5ed5e4044e
Content: Continuous deployment for Azure Functions
Content Source: articles/azure-functions/functions-continuous-deployment.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@ms-zhouma This is the folder structure that Azure Functions expects and is required irrespective of the language used. How this folder structure can be achieved (or generated) is covered in the language specific developer guides, mentioned right after the folder structure.
Similarly, function.json would have already been written or generated depending on the language used by the time of deployment. This doc aims to showcase the different ways Azure Functions can be deployed in an automated fashion by leveraging the continuous deployment feature of Azure App Service.

@ms-zhouma Just following up here... Hope my previous comment clears things up.

@ms-zhouma Hope my previous comment clears things up.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


[$1000] Web - Connect Bank Account - Inconsistent behaviour in the same page where adding spaces before the 'Tax Number' behaves differently unlike the behaviour shown by the company website field.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome
Go to any workspace > Connect bank account manually> Fill all the details
Now in the company website field as well as in the tax number field , try to add multiple spaces before the text
Click on back button and again go the same page
See that the spaces have been removed from the company website's field but the spaces are not removed from the Tax number field.

Expected Result:
To maintain consistency between the fields, the spaces added before the tax number field should be removed
Actual Result:
In the same page , the spaces added before the company website field is removed , while the spaces added before the tax number field is not removed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/233436533-5c5a99e6-13d3-4f9b-b489-3763c6612c1f.mp4
https://user-images.githubusercontent.com/93399543/233436577-1e9bf9a4-ccbf-4f95-aeb9-f00bb587136c.mp4
Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681905290839009
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d5f5fca93a2703df
Upwork Job ID:<PHONE_NUMBER>630120960
Last Price Increase: 2023-04-24

Sorry for opening this bug. It should be on hold as per this slack comment. Will reopen if it is needed.

As per the slack conversation reopening the issue.

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Reproduced.

Job added to Upwork: https://www.upwork.com/jobs/~01d5f5fca93a2703df

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Triggered auto assignment to @pecanoro (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Please re-state the problem that we are trying to solve in this issue.
when user inputs the space in the textbox of Tax Number, app allows user to enter the spaces first.
What is the root cause of that problem?
TextBox has no already validations to add the space in the staring of any word.
What changes do you think we should make in order to solve the problem?
we should add a trim into the base component. it will reflect in every field that will not allow user to enter the space.
in src/components/TextInput/index.js
line no. 54 would look like
<TextInput {...props} value={props?.value?.trimStart()} innerRef={ref} />
it would not affect existing functionality, it will not allow user to add the space in the TextInput
What alternative solutions did you explore? (Optional)
we can user trim() function in the submit method of Form Component at line no 150. in src/pages/ReimbursementAccount/CompanyStep.js.
it will look companyTaxID: values.companyTaxID.replace(CONST.REGEX.NON_NUMERIC, '')?.trimStart(),

📣 @jaymangukiya0001! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

After testing this, I think we should trim all values, I don't see any purpose of leaving them untrimmed unless we are either using the composer or any other component that would make more sense, like a textarea type of component.

Yeah, let's trim the values after either moving forward or moving back and saving them as drafts, there is no need to trim them while typing.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

That will not always solve the problem. For example, the user can close the page but drafts are still saved.

Whenever we save the drafts 🤷♀ Or wouldn't that be doable?

@pecanoro @parasharrajat @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@parasharrajat bumping my last comment, do you think it is not possible?

I am also going to open a Slack discussion because I do not strongly agree with trimming the value because it is against the Form guidelines. It might be good to get a consensus on it.

@parasharrajat If we don't want to trim the form values, then I feel we should do nothing and keep it as it is since nothing is broken, it's just as form fields are supposed to work.

@parasharrajat - were there any next steps with the discussion?


Training on a custom dataset

I am trying to train on my own dataset in coco format, but I am not able to train successfully.
If you have any procedures for training on a custom dataset, I would appreciate it if you could share them with us.
Also, I would like to use the publicly available result-models as a pre-training model and retrain with a custom dataset.
Is it possible to re-train with a custom dataset?
Thank you,

Answered by email. Closed.

Hi @MemorySlices I was looking to do the same. Could you also send me an email too. Thank you

Hi,
Could you tell me about the problem you met in detail? I answered issue #11
according to the questions they mentioned in the email.
Best,
Yihan
kevkid @.***> 于2022年7月19日周二 23:10写道：

Hi @MemorySlices https://github.com/MemorySlices I was looking to do
the same. Could you also send me an email too. Thank you
—
Reply to this email directly, view it on GitHub
https://github.com/mit-han-lab/litepose/issues/11#issuecomment-1189175342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANUHL3S6EOSCPKVR73RL4I3VU3ANZANCNFSM526BDPYA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi,
You only need to remember to convert your dataset into COCO format. If you
still have other questions, please let me know.
Best,
Yihan
kevkid @.***> 于2022年7月21日周四 23:42写道：

Hi @MemorySlices https://github.com/MemorySlices I just wanted to know
if there was some sort of training manual, or anything specific I would
need to do to use my custom dataset. My dataset has extra points that I
would like to train this model on
—
Reply to this email directly, view it on GitHub
https://github.com/mit-han-lab/litepose/issues/11#issuecomment-1191646513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANUHL3TKDE266OVSS6Z3HDTVVFVU3ANCNFSM526BDPYA
.
You are receiving this because you were mentioned.

kevkid @.***> 于2022年7月21日周四 23:42写道：

Hi @MemorySlices https://github.com/MemorySlices I just wanted to know
if there was some sort of training manual, or anything specific I would
need to do to use my custom dataset. My dataset has extra points that I
would like to train this model on
—
Reply to this email directly, view it on GitHub
https://github.com/mit-han-lab/litepose/issues/11#issuecomment-1191646513,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANUHL3TKDE266OVSS6Z3HDTVVFVU3ANCNFSM526BDPYA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi again @MemorySlices, Thank you for the previous advice
I have another question, I would like to use the pretrained weights to initialize my model, then finetune on my custom dataset with more keypoints. I assume I would have to do the following:

Set the configuration for the architecture for example LitePose-Auto-XS such as path to dataset, and number of joints
load the pretrained architecture by dropping the checkpoint file into the checkpoint folder and enabling auto-resume
let torch figure out that there is some mismatched layers (since we want to finetune) at the end
run something like python dist_train.py --cfg experiments/crowd_pose/mobilenet/mobile.yaml --superconfig mobile_configs/search-XS.json --auto-resume

Hi,
Please *do not load the pretrained model head, just load the backbone *if
you want to train on your custom dataset. The difference number of labelled
keypoints between datasets may lead to several problems.
You also do not need to specify --auto-resume when you train your model.
Just change the pretrained-models configuration in the yaml files.
If you still have other questions, please let me know.
Best regards,
Yihan
kevkid @.***> 于2022年7月23日周六 07:31写道：

Hi again @MemorySlices https://github.com/MemorySlices, Thank you for
the previous advice
I have another question, I would like to use the pretrained weights to
initialize my model, then finetune on my custom dataset with more
keypoints. I assume I would have to do the following:

Set the configuration for the architecture for example
LitePose-Auto-XS such as path to dataset, and number of joints
load the pretrained architecture by dropping the checkpoint file
into the checkpoint folder and enabling auto-resume
let torch figure out that there is some mismatched layers (since we
want to finetune) at the end
run something like python dist_train.py --cfg
experiments/crowd_pose/mobilenet/mobile.yaml --superconfig
mobile_configs/search-XS.json --auto-resume

—
Reply to this email directly, view it on GitHub
https://github.com/mit-han-lab/litepose/issues/11#issuecomment-1193003987,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANUHL3X2JZ4ERWUFMU55MALVVMVORANCNFSM526BDPYA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @MemorySlices Thank you again! I got it training on windows + GPU. I have a few more questions that I encountered while training:

I noticed in the mobile.yml file (I modified mine) there is an auto_resume:true at the top but there is also a RESUME: False in the train section of the mobile.yml file. Do I need to set both to true?
Is there a batch size for training? or do I just set the IMAGES_PER_GPU flag under train to a different number?
The output of training looks like:

I assume the stuff after stage0 heatmaps: x.xxx is the heatmap loss? I assume we want that to go down? I am having a little trouble interpreting it
When you say to only load the backbone do you mean load everything except anything after and including: final_refined i.e.:

Hi kevkid,
Sorry for my late reply, I have been really busy these two days.
(1) I did not notice it before. I think keeping it as original is a good
choice.
(2) IMAGES_PER_GPU is the batch size per gpu.
(3) That's right.
(4) For example, if you want to train a model on your own dataset. And you
want to load our result model. You need to remove the head including
deconv/final_refined etc.
If you have questions, please let me know.
Best,
Yihan
kevkid @.***> 于2022年7月27日周三 08:30写道：

Hi @MemorySlices https://github.com/MemorySlices Thank you again! I got
it training on windows + GPU. I have a few more questions that I
encountered while training:

I noticed in the mobile.yml file (I modified mine) there is an
auto_resume:true at the top but there is also a RESUME: False in the
train section of the mobile.yml file. Do I need to set both to true?
Is there a batch size for training? or do I just set the
IMAGES_PER_GPU flag under train to a different number?
The output of training looks like:
[image: image]
https://user-images.githubusercontent.com/1369930/181132556-be6f5d98-b51e-4a8e-82fa-c922f8b56107.png
I assume the stuff after stage0 heatmaps: x.xxx is the heatmap loss? I
assume we want that to go down? I am having a little trouble interpreting it
When you say to only load the backbone do you mean load everything
except anything after and including: final_refined i.e.:

—
Reply to this email directly, view it on GitHub
https://github.com/mit-han-lab/litepose/issues/11#issuecomment-1196139497,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANUHL3RWZKAV3HP453XKOD3VWB7LRANCNFSM526BDPYA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Update README.md

Doc format matching Torch's standard
Add dependency installation instructions

thanks Alfredo.

Np. You know already I'm affected by OCD :wink:


feat: Use the crdb go client to handle retries for retryable errors

We have seen a few errors in production around ABORT_REASON_NEW_LEASE_PREVENTS_TXN. This is documented https://www.cockroachlabs.com/docs/stable/transaction-retry-error-reference.html#abort_reason_new_lease_prevents_txn and is something that should be handled by client-side retry handling. This switches our postgres client to the crdb client that implements the client side retry handling for us.

Codecov Report

Merging #29 (39a182f) into main (bff3e6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   73.08%   73.08%
=======================================
  Files          24       24
  Lines        1059     1059
=======================================
  Hits          774      774
  Misses        183      183
  Partials      102      102

Flag
Coverage Δ

unittests
73.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebce8cf...39a182f. Read the comment docs.


Allow https for IPInfo.io queries without an API key

It appears that at some point they changed the "TLS only for paying
customers" rule.
See: https://ipinfo.io/developers#https-ssl
"Our API is available over a secure HTTPS connection for all users, even
on the free plan."

Glad to hear this--thanks!


fix(initial commit): default to no GPG sign

Fixes #5818
If the git config option commit.gpgSign is set
to true, passes the flag --no-gpg-sign when
creating the initial commit, then warns user that
initial commit is not signed and instructs how
to sign the initial commit

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Underlying tools
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

Other information:
This PR will change vue create to never sign the initial commit. My personal opinion is that this is the preferred behavior, since I wouldn't want to default to signing a commit that I did not create. But another way to fix #5818 would be to continue to attempt GPG sign if commit.gpgSign = true in git config, and make warning say that commit failed due to missing username, email, or failure to sign commit. If you think it is better to continue signing and change the gitCommitFailed warning instead, I could create a PR for that instead :slightly_smiling_face:

I prefer to change the error message.
Because:

even after this PR, the error message is still inaccurate, as the commit may fail for other reasons such as wrong password
it's simpler to change the error message, thus more maintainable

I prefer to change the error message.

No problem :+1:
Would you prefer I open a new PR, or edit this PR?

I think either is fine.
The message looks good to me.

:+1:
Should I also add this to prevent GPG signing on testing/debugging?
 if (isTestOrDebug) {
   await run('git', ['config', 'user.name', 'test'])
   await run('git', ['config', 'user.email'<EMAIL_ADDRESS>+  await run('git', ['config', '--unset', 'commit.gpgSign'])
 }

Yeah, that would be nice.

 if (isTestOrDebug) {
   await run('git', ['config', 'user.name', 'test'])
   await run('git', ['config', 'user.email'<EMAIL_ADDRESS>+  await run('git', ['config', 'commit.gpgSign', 'false'])
 }

Did this instead because --unset fails if the config option was never set.

git config --get returns 1 if the config is not found. This is treated as error by execa. The execution should be wrapped in an exception handler.
�  Generating README.md...
 ERROR  Error: Command failed: git config --get commit.gpgSign

Error: Command failed: git config --get commit.gpgSign

    at makeError (C:\Lang\node\global\node_modules\@vue\cli\node_modules\execa\index.js:174:9)
    at C:\Lang\node\global\node_modules\@vue\cli\node_modules\execa\index.js:278:16
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async C:\Lang\node\global\node_modules\@vue\cli\lib\Creator.js:271:43
    at async Creator.create (C:\Lang\node\global\node_modules\@vue\cli\lib\Creator.js:270:17)
    at async create (C:\Lang\node\global\node_modules\@vue\cli\lib\create.js:72:3)

@char101 Thanks for the feedback! I'll fix this ASAP.

:fearful: I apologize for this! I didn't notice this behavior in my environment.


Errors revealed by h265 format test

On Windows this test works fine, but on Linux the tests starts getting payload lengths that make no sense. The same length is gotten for the whole duration of the test, but it is nowhere near the size it should be. The size seems to be a random number that is under 65000 and sometimes this is followed by a crash.

Test in question:
https://github.com/ultravideo/uvgRTP/blob/3a9e3b175774ed43a600ff178e11d875ad4513c0/test/test_4_formats.cpp#L67

Even the simply trying to print something in receiver_flow seems to fix the issue, making debugging difficult. The only guess I have is having more than one packet read from the socket at the same time.

This also replicated on Windows now and only on H265 tests. The latest changes have been to start code lookup, but I'm unsure if that is the cause. Unfortunately, I'm in a situation where I cannot dedicate much time to uvgRTP this spring.

This issue seems to be caused by aggregation packets. This may be the same issues as #117


Button: Add minor amendments to button config for click events & docs

Description
Small follow up for https://github.com/FlowFuse/node-red-dashboard/pull/1252 which adds an option for whether or not the click event is emitted, and ensures it's clear that the "topic" defined is always sent.
It also fixes a bug where the pointerup event was taking the pointerdown payloadType.

These changes then enable us to easily monitor how long a button is held down for, such as:
https://github.com/user-attachments/assets/e416a023-af9d-4ba9-9542-185a9cd10a6c

IMHO; this is confusing. Based on the operations we are now offering, I feel the arrangement of events would probably suit being something like:

or

or

Also, I see you have merged the original PR but as far as I can see, the OP did not address the lack of keyboard operation as raised in the comments: https://github.com/FlowFuse/node-red-dashboard/pull/1252#issuecomment-2361239656

Keyboard operations are not supported. i.e. tab onto the button so it is highlighted, press the space bar - the "down" event is not triggered. Releasing the space bar does not fire the "up" event either (the "click" event does trigger)

Also, I see you have merged the original PR but as far as I can see, the OP did not address the lack of keyboard operation as raised in the comments:

Not a blocker for why this shouldn't have been merged though. Raise a new issue please.

IMHO; this is confusing

Curious to know what is confusing about it? Given the layout we have, what are you expecting it to send vs. what it actually sends?
By having the "topic" option just as a standalone row, I'm not convinced it's clear to the user what is being done with that topic.
I did toy with the idea of a topic per button event, but we already have msg._event.type to differentiate the type, so didn't think it necessary.

IMHO; this is confusing

Curious to know what is confusing about it? Given the layout we have, what are you expecting it to send vs. what it actually sends?
By having the "topic" option just as a standalone row, I'm not convinced it's clear to the user what is being done with that topic.
I did toy with the idea of a topic per button event, but we already have msg._event.type to differentiate the type, so didn't think it necessary.

Looking closer, I think I missed a subtly - the payload field for the "click" event is hidden due to the click [x] being unticked.
I assumed there was a payload field below the topic field (cut short in the screenshot) because it was required for the "click through" support.  but on second thought, the "click through" doesnt use the entered payload right?

but on second thought, the "click through" doesn't use the entered payload right?

This is a good point... I think it does, as it's an "Emulate Click"? I'll need to check

but on second thought, the "click through" doesn't use the entered payload right?

This is a good point... I think it does, as it's an "Emulate Click"? I'll need to check

Any conclusion Joe?

but on second thought, the "click through" doesn't use the entered payload right?

This is a good point... I think it does, as it's an "Emulate Click"? I'll need to check

Any conclusion Joe?

I've checked and we are correct (unfortunately).  As of now (before this PR), the payload value set for "click" on the node edit form IS what is used for "emulate click". That means hiding it is not ideal I'm afraid.

Okay, I've moved the "Emulate Button Click" option to be nested in the optional button click section, so that yo can't get to the emulate, without also enabling the click event in the first place, which feels sensible.

Can confirm, when button emulated is enabled, but the enableClick is false, then emulated event will not happen.


Semantic similarity model issue

Using malaya: 4.8.0
It seems the semantic similarity function gives random similarity scores when comparing malay sentences,
Following short colab code you can try, when you keep running the "predict_proba" method between same sentences, you get each time a different similarity score,
https://colab.research.google.com/drive/10WgP-ftPGHTk_1Tf3Y9L0Sai8oIUPOMn#scrollTo=vgTYWt3636Bf

https://github.com/huseinzol05/malaya/issues/86, https://github.com/huseinzol05/malaya/issues/87


About customization

I am not able to give my own broker in app module
NgxMqttClientModule.withOptions({
host: '<IP_ADDRESS>',
protocol: 'ws',
port: 1883,
path: '/mqtt'
})
I,ve tried this but it shows
WebSocket connection to 'ws://<IP_ADDRESS>:1883/mqtt' failed: Error in connection establishment: net::ERR_CONNECTION_TIMED_OUT

Have you checked your mqtt is online and also to able to receive ws connection?

@wermerb Thank you for the quick reply.
My mqtt server isnt accepting 'ws' I think. So i tried to connect to it using 'mqtt' in MQTTBox chrome App and it worked.

I tried again with following configuration
NgxMqttClientModule.withOptions({
host: '<IP_ADDRESS>',
protocol: 'mqtt',
port: 1883,
path: '/mqtt'
})
I am not getting the console error . But i am unable to connect also.
The following is happening after I click on subscribe twice.Nothing happens when I click on send also.

Also is there a  timeout for the client ? If yes what is the duration ?

I don't what kind of broker are you using, but for example if you are using Mosquito you have to compile it to support mqtt over websocket. Probably this is why you received this error message: WebSocket connection to 'ws://<IP_ADDRESS>:1883/mqtt' failed: Error in connection establishment: net::ERR_CONNECTION_TIMED_OUT.
This guide helps you compile your own Mosquito which will support mqtt over websocket: Websockets and Mosquitto
Also this library is a wrapper for mqtt.js so here you can find the default settings: MQTT.js

@wermerb
Its working fine thanks.


Lack of verification of wp->w_buffer causes null pointer references in scroll_to_fraction()

To Reproduce
vim -u NONE -X -Z -e -s -S poc -c :qa!

Debug Info
Program received signal SIGSEGV, Segmentation fault.
[----------------------------------registers-----------------------------------]
RAX: 0x16
RBX: 0x92c020 --> 0x3f5
RCX: 0x0
RDX: 0x1
RSI: 0xb ('\x0b')
RDI: 0x92c020 --> 0x3f5
RBP: 0x16
RSP: 0x7fffffffabf0 --> 0x0
RIP: 0x5fd9bc (<scroll_to_fraction+60>: cmp    QWORD PTR [rcx],rax)
R8 : 0x933ea8 --> 0x0
R9 : 0x928400 --> 0xffffffffd91df280
R10: 0x933ea8 --> 0x0
R11: 0x18
R12: 0x8f21f0 --> 0xce00000000
R13: 0x0
R14: 0xb ('\x0b')
R15: 0x17
EFLAGS: 0x10246 (carry PARITY adjust ZERO sign trap INTERRUPT direction overflow)
[-------------------------------------code-------------------------------------]
   0x5fd9ab <scroll_to_fraction+43>:    cmp    QWORD PTR [rip+0x2e9f46],rbx        # 0x8e78f8 <curwin>
   0x5fd9b2 <scroll_to_fraction+50>:    jne    0x5fdc01 <scroll_to_fraction+641>
   0x5fd9b8 <scroll_to_fraction+56>:    mov    rcx,QWORD PTR [rbx+0x8]
=> 0x5fd9bc <scroll_to_fraction+60>:    cmp    QWORD PTR [rcx],rax
   0x5fd9bf <scroll_to_fraction+63>:    jg     0x5fd9cf <scroll_to_fraction+79>
   0x5fd9c1 <scroll_to_fraction+65>:    cmp    QWORD PTR [rbx+0x80],0x2
   0x5fd9c9 <scroll_to_fraction+73>:    jl     0x5fdc01 <scroll_to_fraction+641>
   0x5fd9cf <scroll_to_fraction+79>:    mov    DWORD PTR [rsp+0x14],r14d
[------------------------------------stack-------------------------------------]
0000| 0x7fffffffabf0 --> 0x0
0008| 0x7fffffffabf8 --> 0x40b990 (<buflist_setfpos+240>:       mov    DWORD PTR [rbx+0x28],0x1)
0016| 0x7fffffffac00 --> 0x1
0024| 0x7fffffffac08 --> 0x92c020 --> 0x3f5
0032| 0x7fffffffac10 --> 0x8f21f0 --> 0xce00000000
0040| 0x7fffffffac18 --> 0x0
0048| 0x7fffffffac20 --> 0xb ('\x0b')
0056| 0x7fffffffac28 --> 0x17
[------------------------------------------------------------------------------]
Legend: code, data, rodata, value
Stopped reason: SIGSEGV
0x00000000005fd9bc in scroll_to_fraction (wp=wp@entry=0x92c020, prev_height=prev_height@entry=0xb) at window.c:6199
6199            && (height < wp->w_buffer->b_ml.ml_line_count || wp->w_topline > 1))
gdb-peda$

#0  0x00000000005fd9bc in scroll_to_fraction (wp=wp@entry=0x92c020, prev_height=prev_height@entry=0xb) at window.c:6199
#1  0x00000000005f8ef4 in win_new_height (wp=0x92c020, height=0x16) at window.c:6182
#2  frame_new_height (topfrp=topfrp@entry=0x8f21f0, height=0x17, topfirst=<optimized out>, wfh=<optimized out>, wfh@entry=0x0) at window.c:3108
#3  0x00000000005fb2df in winframe_remove (win=win@entry=0x930870, dirp=dirp@entry=0x7fffffffacec, tp=tp@entry=0x0) at window.c:2880
#4  0x00000000005f6007 in win_free_mem (win=0x930870, dirp=0x7fffffffacec, tp=0x0) at window.c:2782
#5  win_close (win=win@entry=0x930870, free_buf=<optimized out>, free_buf@entry=0x0) at window.c:2605
#6  0x0000000000412f7d in ex_buffer_all (eap=<optimized out>) at buffer.c:5169
#7  0x00000000004684ba in do_one_cmd (cmdlinep=0x7fffffffadc8, flags=0x7, cstack=0x7fffffffafa8, fgetline=0x409430 <getnextac>, cookie=0x7fffffffb760) at ex_docmd.c:2588
#8  do_cmdline (cmdline=<optimized out>, cmdline@entry=0x0, fgetline=<optimized out>, cookie=<optimized out>, cookie@entry=0x7fffffffb760, flags=flags@entry=0x7) at ex_docmd.c:1003
#9  0x00000000004089d5 in apply_autocmds_group (event=event@entry=EVENT_SOURCEPOST, fname=0x908160 "/mnt/disk/out/vim_bak/vim-fuzzer-out/751bOY/crashes/id:000000,sig:11,src:017944+027523,op:splice,rep:4",
    fname@entry=0x903710 "/mnt/disk/out/vim_bak/vim-fuzzer-out/751bOY/crashes/id:000000,sig:11,src:017944+027523,op:splice,rep:4", fname_io=<optimized out>,
    fname_io@entry=0x903710 "/mnt/disk/out/vim_bak/vim-fuzzer-out/751bOY/crashes/id:000000,sig:11,src:017944+027523,op:splice,rep:4", force=<optimized out>, force@entry=0x0, group=group@entry=0xfffffffd,
    buf=<optimized out>, eap=0x0) at autocmd.c:2109
#10 0x0000000000409287 in apply_autocmds (event=9617440, event@entry=EVENT_SOURCEPOST, fname=0xb <error: Cannot access memory at address 0xb>,
    fname@entry=0x903710 "/mnt/disk/out/vim_bak/vim-fuzzer-out/751bOY/crashes/id:000000,sig:11,src:017944+027523,op:splice,rep:4", fname_io=0x1 <error: Cannot access memory at address 0x1>,
    fname_io@entry=0x903710 "/mnt/disk/out/vim_bak/vim-fuzzer-out/751bOY/crashes/id:000000,sig:11,src:017944+027523,op:splice,rep:4", force=force@entry=0x0, buf=0x928400) at autocmd.c:1621
#11 0x000000000056689b in do_source (fname=<optimized out>, fname@entry=0x8f7f13 "/mnt/disk/out/vim_bak/vim-fuzzer-out/751bOY/crashes/id:000000,sig:11,src:017944+027523,op:splice,rep:4",
    check_other=<optimized out>, check_other@entry=0x0, is_vimrc=is_vimrc@entry=0x0, ret_sid=<optimized out>, ret_sid@entry=0x0) at scriptfile.c:1477
#12 0x0000000000565df9 in cmd_source (fname=0x8f7f13 "/mnt/disk/out/vim_bak/vim-fuzzer-out/751bOY/crashes/id:000000,sig:11,src:017944+027523,op:splice,rep:4", eap=<optimized out>) at scriptfile.c:971
#13 0x00000000004684ba in do_one_cmd (cmdlinep=0x7fffffffb998, flags=0xb, cstack=0x7fffffffbb78, fgetline=0x0, cookie=0x0) at ex_docmd.c:2588
#14 do_cmdline (cmdline=<optimized out>, fgetline=<optimized out>, fgetline@entry=0x0, cookie=<optimized out>, cookie@entry=0x0, flags=flags@entry=0xb) at ex_docmd.c:1003
#15 0x0000000000468e1e in do_cmdline_cmd (cmd=0x92c020 "\365\003") at ex_docmd.c:592
#16 0x0000000000627a6d in exe_commands (parmp=<optimized out>) at main.c:3056
#17 vim_main2 () at main.c:760
#18 0x0000000000626bd2 in main (argc=<optimized out>, argc@entry=0xb, argv=<optimized out>, argv@entry=0x7fffffffe4b8) at main.c:412
#19 0x00007ffff72f7840 in __libc_start_main (main=0x6253a0 <main>, argc=0xb, argv=0x7fffffffe4b8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe4a8)
    at ../csu/libc-start.c:291
#20 0x0000000000404269 in _start ()

Environment (please complete the following information):

Vim version : commit 9567efa1b4a41baca9b2266f5903d5dda7ad1e88
OS: Ubuntu 16.04

Additional context
compile argument：
#!/bin/bash -eux
export CC="clang-11"
export CXX="clang-11++"
cd /src/vim/ && ./configure --with-features=huge --enable-gui=none && make

poc:
poc.gz
Credit: 1vanChen of NSFOCUS Security Team

I could reproduce the crash with vim-8.2.2353.
But it no longer happen after vim-8.2.2354.
To @yifengchen-cc : can you confirm that the issue can be closed?

I could reproduce the crash with vim-8.2.2353.
But it no longer happen after vim-8.2.2354.
To @yifengchen-cc : can you confirm that the issue can be closed?

I can not reproduce this crash  with commit 648ea76e1d8ca9a9788f88d0d96d0cf0653006bb . However，this poc will cause vim to hang, I haven’t figured it out yet.

I can not reproduce this crash  with commit 648ea76e1d8ca9a9788f88d0d96d0cf0653006bb . However，this poc will cause vim to hang, I haven’t figured it out yet.

@yifengchen-cc wrote:

However，this poc will cause vim to hang

I suspect that it's because autocommand like "au * * …" triggers
on every events, and the autocomand may trigger perhaps trigger
new events causing vim enter a endless loop of autocommands.
I don't think that there is any realistic use cases for using *
when adding an autocomand. * can make sense when
listing or removing autocommands, but not when adding
autocommands. So perhaps Vim should not allow it,
and give an error like "can't add autocmd with * event".  In fact,
reading :help :autocomd, the doc does clearly says what
is allowed for {event}. Perhaps I missed it. What I see is that
adding an autocmd accepts:

a single event as in :au BufNewFile * …
a list of events as in :au BufnewFile,BufRead * …
or all events as in :au * * … which I suggest to disallow.

@yifengchen-cc wrote:

However，this poc will cause vim to hang

I suspect that it's because autocommand like "au * * …" triggers
on every events, and the autocomand may trigger perhaps trigger
new events causing vim enter a endless loop of autocommands.
I don't think that there is any realistic use cases for using *
when adding an autocomand. * can make sense when
listing or removing autocommands, but not when adding
autocommands. So perhaps Vim should not allow it,
and give an error like "can't add autocmd with * event".  In fact,
reading :help :autocomd, the doc does clearly says what
is allowed for {event}. Perhaps I missed it. What I see is that
adding an autocmd accepts:

a single event as in :au BufNewFile * …
a list of events as in :au BufnewFile,BufRead * …
or all events as in :au * * … which I suggest to disallow.

I can not reproduce this crash  with commit
648ea76e1d8ca9a9788f88d0d96d0cf0653006bb . However，this poc will
cause vim to hang, I haven’t figured it out yet.

What I have seen during debugging is that the SafeStateAgain autocommand
causes a loop.  That is to be expected, once should not use :blast or
:ball in such an autocommand.  That's also why in the test I used a list
of specific autocommand events instead of "*", the test would otherwise
never pass.
After adding the test there was a failure on MS-Windows, but it appears
to be caused by the system() call, not the autocommands.  I have not
been able to figure out what happens, hopefully someone who has more
tools on MS-Windows can have a look: remove the check for win32 in
Test_autocmd_blast_badd()
--
Apathy Error: Don't bother striking any key.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I can not reproduce this crash  with commit
648ea76e1d8ca9a9788f88d0d96d0cf0653006bb . However，this poc will
cause vim to hang, I haven’t figured it out yet.

What I have seen during debugging is that the SafeStateAgain autocommand
causes a loop.  That is to be expected, once should not use :blast or
:ball in such an autocommand.  That's also why in the test I used a list
of specific autocommand events instead of "*", the test would otherwise
never pass.
After adding the test there was a failure on MS-Windows, but it appears
to be caused by the system() call, not the autocommands.  I have not
been able to figure out what happens, hopefully someone who has more
tools on MS-Windows can have a look: remove the check for win32 in
Test_autocmd_blast_badd()
--
Apathy Error: Don't bother striking any key.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

@brammool  that system() maybe similar situation like #7703.

@brammool  that system() maybe similar situation like #7703.

While using normally vim on Nixos Linux, I got a coredump in scroll_to_fraction(). I got gdb accept a nonstripped vim for that coredump.
I was repeating ^Wn to switch to next vim window. This was not obtained by fuzzing.
Here is the output of gdb:
[jidhub@ws-mol8:~]$ coredumpctl gdb
Hint: You are currently not seeing messages from other users and the system.
Users in groups 'adm', 'systemd-journal', 'wheel' can see all messages.
Pass -q to turn off this notice.
PID: 2317733 (vim)
UID: 1001 (jidhub)
GID: 100 (users)
Signal: 11 (SEGV)
Timestamp: Wed 2022-09-28 14:20:55 CEST (5h 3min ago)
Command Line: vim dell1600n-net-scan.pl
Executable: /nix/store/qar6c8n2m433iqgdlrbsffvav0ybbd3k-vim-9.0.0115/bin/vim
Control Group: /user.slice/user-1001.slice/session-2.scope
Unit: session-2.scope
Slice: user-1001.slice
Session: 2
Owner UID: 1001 (jidhub)
Boot ID: 94a48275ca194c819b204ebeb8bd6025
Machine ID: 9b329cece99740fd89b5d582340217e4
Hostname: ws-mol8
Storage: /var/lib/systemd/coredump/core.vim.1001.94a48275ca194c819b204ebeb8bd6025.2317733.1664367655000000.zst (present)
Disk Size: 712.3K
Message: Process 2317733 (vim) of user 1001 dumped core.
            Module linux-vdso.so.1 with build-id 34d8b9399a90195812011450a247bcf175030874
            Module ld-linux-x86-64.so.2 with build-id be40dff27d23280ccef152a0067e746b65ca65b4
            Module libc.so.6 with build-id b8955b167037e2b110df91adf633802aa3c6e711
            Module libncursesw.so.6 without build-id.
            Module libm.so.6 with build-id 49cf4fe091066a1d164ac7534f7e922c09408634
            Module vim without build-id.
            Stack trace of thread 2317733:
            #0  0x00007fc15bdde2c7 kill (libc.so.6 + 0x3d2c7)
            #1  0x000000000052f50b n/a (vim + 0x12f50b)
            #2  0x00007fc15bdde0e0 __restore_rt (libc.so.6 + 0x3d0e0)
            #3  0x00007fc15beefc89 __memset_avx2_unaligned_erms (libc.so.6 + 0x14ec89)
            #4  0x000000000057bd7a n/a (vim + 0x17bd7a)
            #5  0x0000000000583454 n/a (vim + 0x183454)
            #6  0x0000000000584635 n/a (vim + 0x184635)
            #7  0x0000000000584930 n/a (vim + 0x184930)
            #8  0x0000000000506636 n/a (vim + 0x106636)
            #9  0x000000000062c0ac n/a (vim + 0x22c0ac)
            #10 0x000000000062c3bd n/a (vim + 0x22c3bd)
            #11 0x000000000062ede2 n/a (vim + 0x22ede2)
            #12 0x000000000062ef8a n/a (vim + 0x22ef8a)
            #13 0x00000000006327a1 n/a (vim + 0x2327a1)
            #14 0x000000000050fd18 n/a (vim + 0x10fd18)
            #15 0x000000000065d0b6 n/a (vim + 0x25d0b6)
            #16 0x000000000065e1a7 n/a (vim + 0x25e1a7)
            #17 0x00007fc15bdca237 __libc_start_call_main (libc.so.6 + 0x29237)
            #18 0x00007fc15bdca2f5 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x292f5)
            #19 0x0000000000414f41 n/a (vim + 0x14f41)

            Stack trace of thread 2317734:
            #0  0x00007fc15bddeb3c __sigtimedwait (libc.so.6 + 0x3db3c)
            #1  0x00007fc15be31f9b timer_helper_thread (libc.so.6 + 0x90f9b)
            #2  0x00007fc15be26ff2 start_thread (libc.so.6 + 0x85ff2)
            #3  0x00007fc15bea9bfc __clone3 (libc.so.6 + 0x108bfc)
            ELF object binary architecture: AMD x86-64

GNU gdb (GDB) 12.1
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-unknown-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
https://www.gnu.org/software/gdb/bugs/.
Find the GDB manual and other documentation resources online at:
http://www.gnu.org/software/gdb/documentation/.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /nix/store/qar6c8n2m433iqgdlrbsffvav0ybbd3k-vim-9.0.0115/bin/vim...
warning: Can't open file /dbhpJ6z8 (deleted) during file-backed mapping note processing
[New LWP 2317733]
[New LWP 2317734]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/nix/store/lxpdbaazqd2s79jx6lngr8nak2rjdaq1-glibc-2.34-210/lib/libthread_db.so.1".
Core was generated by `vim dell1600n-net-scan.pl'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007fc15bdde2c7 in kill () at ../sysdeps/unix/syscall-template.S:120
120     ../sysdeps/unix/syscall-template.S: No such file or directory.
[Current thread is 1 (Thread 0x7fc15bd9fb80 (LWP 2317733))]
(gdb)
(gdb) bt
#0  0x00007fc15bdde2c7 in kill () at ../sysdeps/unix/syscall-template.S:120
#1  0x000000000052f50b in may_core_dump () at os_unix.c:3519
#2  may_core_dump () at os_unix.c:3514
#3  mch_exit (r=1) at os_unix.c:3485
#4
#5  __memset_avx2_unaligned_erms () at ../sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S:338
#6  0x000000000057bd7a in memset (__len=95, __ch=32, __dest=)
at /nix/store/k3d8wqlsnmm5270zd19cbs26g7wifxj6-glibc-2.34-210-dev/include/bits/string_fortified.h:59
#7  lineclear (off=off@entry=36531429, width=95, attr=attr@entry=0) at screen.c:3048
#8  0x0000000000583454 in screen_del_lines (force=, wp=0x2180260, clear_attr=0,
end=, line_count=15, row=, off=) at screen.c:4095
#9  screen_del_lines (off=, row=0, line_count=15, end=25, force=,
clear_attr=0, wp=0x2180260) at screen.c:3933
#10 0x0000000000584635 in win_do_lines (wp=wp@entry=0x2180260, row=row@entry=0,
line_count=line_count@entry=15, mayclear=mayclear@entry=0, del=del@entry=1,
clear_attr=clear_attr@entry=0) at screen.c:3631
#11 0x0000000000584930 in win_do_lines (clear_attr=0, del=1, mayclear=0, line_count=15, row=0,
wp=0x2180260) at screen.c:3578
#12 win_del_lines (wp=0x2180260, row=row@entry=0, line_count=15, invalid=invalid@entry=0,
mayclear=mayclear@entry=0, clear_attr=clear_attr@entry=0) at screen.c:3532
#13 0x0000000000506636 in curs_columns (may_scroll=may_scroll@entry=0) at move.c:1184
#14 0x000000000062c0ac in scroll_to_fraction (wp=0x2180260, prev_height=1) at window.c:6485
#15 0x000000000062c38f in win_new_height (wp=, height=)
at window.c:6370
#16 0x000000000062c3bd in frame_new_height (topfrp=topfrp@entry=0x22207e0, height=26,
topfirst=topfirst@entry=0, wfh=wfh@entry=0) at window.c:3273
#17 0x000000000062ede2 in frame_setheight (curfrp=, height=)
at window.c:5804
#18 0x000000000062ef8a in win_setheight_win (height=, height@entry=9999,
win=) at window.c:5661
--Type  for more, q to quit, c to continue without paging--
#19 0x000000000062f14f in win_setheight (height=height@entry=9999) at window.c:5638
#20 0x00000000006327a1 in do_window (nchar=95, Prenum=0, xchar=) at window.c:475
#21 0x000000000050fd18 in normal_cmd (oap=oap@entry=0x7ffee9fca6a0, toplevel=toplevel@entry=1)
at normal.c:939
#22 0x000000000065d0b6 in main_loop (cmdwin=cmdwin@entry=0, noexmode=noexmode@entry=0)
at main.c:1527
#23 0x000000000065e1a7 in vim_main2 () at main.c:885
#24 0x00007fc15bdca237 in __libc_start_call_main (main=main@entry=0x413340 ,
argc=argc@entry=2, argv=argv@entry=0x7ffee9fca958) at ../sysdeps/nptl/libc_start_call_main.h:58
#25 0x00007fc15bdca2f5 in __libc_start_main_impl (main=0x413340 , argc=2,
argv=0x7ffee9fca958, init=, fini=, rtld_fini=,
stack_end=0x7ffee9fca948) at ../csu/libc-start.c:392
#26 0x0000000000414f41 in _start () at ../sysdeps/x86_64/start.S:116
(gdb)
Please tell me if there is a special address to send coredump that contains personnal data. In above lines, I substituted my real username by jidhub.
Please tell me if there is something else I can type to the invite (gdb).
I can be reached as xdej on channel #vim on libera.

To @jidhub : could you try to try to reproduce with a asan build of Vim?
Maybe your ~/.vimrc & plugins make this reproducible.
You can build with asan by uncommenting this line in src/Makefile:
SANITIZER_CFLAGS = -g -O0  -fsanitize-recover=all -fsanitize=address -fsanitize=undefined -fno-omit-frame-pointer

If asan finds use of invalid memory, it will output information on stderr.
So you can use something like this vim 2> asan.log to capture asan logs.

While using normally vim on Nixos Linux, I got a coredump in
scroll_to_fraction(). I got gdb accept a nonstripped vim for that
coredump.
I was repeating ^Wn to switch to next vim window. This was not
obtained by fuzzing.
Here is the output of gdb:

[...]

Please tell me if there is a special address to send coredump that
contains personnal data. In above lines, I substituted my real
username by jidhub.
Please tell me if there is something else I can type to the invite (gdb).
I can be reached as xdej on channel #vim on libera.

A core dump is not useful.  I don't spot something in the gdb stack
trace that points to the cause of the problem.
Can you manage to write a script that reproduces this?  Since you caught
it in gdb suggests you know what you did before it happened.  Ideally we
can use that script to make a test case.  Then we can fix it.
--
hundred-and-one symptoms of being an internet addict:
216. Your pet rock leaves home.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Nope, gdb was attached after the fact.
I was not recording the hour long editing session with vim. But I can show you additionnal values of variables.


Fix Boolean (either, both) to be short circuiting

Quote from Ramda docs:

both: A function which calls the two provided functions and returns the && of the results. It returns the result of the first function if it is false-y and the result of the second function otherwise. Note that this is short-circuited, meaning that the second function will not be invoked if the first returns a false-y value.

either: A function wrapping calls to the two functions in an || operation, returning the result of the first function if it is truth-y and the result of the second function otherwise. Note that this is short-circuited, meaning that the second function will not be invoked if the first returns a truth-y value.

Not sure this is idiomatic fixing, open to suggestions.

This is a solid improvement, thank you! The only thing I think could be improved is to make note of this short-circuiting in the JSDoc for each function.

Updates:

point-free
mentioning short circuiting in docs
commits squashed

Great stuff, thank you!


Add more support for wrapped propTypes

Fixes #1266

Thanks!
I think it'd be better, rather than only adding this option to individual rules, to also add it to "settings" (like the React pragma).
Basically, individual rule settings would take precedence, and lacking that, the global settings would be used.

Ah, right after pushing this, I saw that you'd like to have it in settings and individual rule configuration. What case did you have in mind where it would be necessary to have the option to override it per-rule?

No use case specifically; just aiming for maximum configurability.
Let's keep it how you have it for now, and we can add the specific-rule settings later if needed.

This needs to be merged before the next release, so if I don't hear any objections by Monday, I'm going to merge it.

Pushed support for a couple more, I think that's all the major prop-type rules.

I wonder if, like Components.detect, we could make a PropTypes.detect function that would make this logic reusable?

I think that could be helpful, but maybe out of scope for this PR. There's a lot of logic around finding declared prop types that is duplicated across multiple rules.


Google maps and Places from cocoapods

i still cant add google maps and google places from cocoapods with the solution you provide
i got this error
"
target has frameworks with conflicting names: googlemapsbase.framework, googlemaps.framework, and googlemapscore.framework.
"
from where you get your version of Google maps and why it is different  from pods version ?

could you make your dependance like google places
https://github.com/CocoaPods/Specs/blob/d0ec5a65e80656c8d78e12ff19f251df879e0bc2/Specs/c/3/2/GooglePlaces/2.1.1/GooglePlaces.podspec.json

could you make your dependance like google places
https://github.com/CocoaPods/Specs/blob/d0ec5a65e80656c8d78e12ff19f251df879e0bc2/Specs/c/3/2/GooglePlaces/2.1.1/GooglePlaces.podspec.json

@embassem I may try to add the Google Maps SDKs as an explicit dependency of my Pod, but the last time I tried this I always got compile-time errors, and had to fall back to the current system with bundled SDKs.
I know it's far from perfect, but I still don't have any working workaround.

Hi again,
Just tried again and got this error from Cocoapods:

The 'Pods-PXGoogleDirectionsSample' target has transitive dependencies that include static binaries

This issue is a known limitation of Cocoapods tied to the fact that we're trying to mix static and dynamic frameworks. The Google Maps iOS SDK is currently provided as static frameworks. The issue is referenced here: https://github.com/CocoaPods/CocoaPods/issues/3267.
I'm afraid I don't have a way to fix this right now, at least until Google switches to dynamic frameworks...

Now linked to #28.


fix: do not restore bad state for top line when opening neotree

this is a follow up to #953, which was a fix for #781
This fixes the problem where if you open :Neotree current in a window that has a terminal that has a lot of lines, then the tree will be scrolled down as far as it can go. I didn't really trace the execution, I just moved the save and restore of the window top line within the same conditionals as the saving of the currently focused node. It make sense that whatever situation would prevent a save/restore of the current node would also apply to the window scroll position.
FYI: @ghostbuster91

Right, that totally makes sense :+1:


Unit without reference to the menu

In the current project, I get the following situation. Any block for which no references in the menu. And it turns out that when you scroll to this block incorrect items are marked on the menu. I would like to at this point, no item was not marked active.

Demo link please.

http://armature.yarkevich.ru/. For the first block of content is not a menu item. The project is under development. Please only look with chrome

So if I'm understanding you correctly:

There are blocks of content on your page.
One or more of those blocks is an independent section not linked to in the header navigation.
When someone scrolls into that block, you want no navigation element to active.

Is that correct? If so, Gumshoe does not support this. It is intended to hold the currently active navigation as active until another content section replaces it.

The work around for this is to put a hidden element in your navigation list that links to your first section

Now I did. But I do not like this method. It would be better if just cleaned activity class

I agree - that would be better. A hidden nav element is also potentially bad for accessibility. But stripping the active class if no content block is active adds quite a bit more complexity to an already complex script. Marking this won't fix. Sorry!

I initially thought that it would be bad for accessibility, but i simply have a link for "Home" which i hide with CSS, if screen readers hit it its still a working a link with the correct labels.
Similar to having a "Skip to content" link that only screen readers see, plus you could always add aria-hidden to it.


Unit tests don't catch my errors

This is my code

and this is my unit test

and the output

Am I doing it the wrong way?

I don't see any errors.

Thanks for your open source project

@erdnaxeli because it's encrypted, you have to read output with   encryption.

@GitCash send 250 bits to @Zydnar @erdnaxeli @Sclifftop
╰( ⁰ ਊ ⁰ )━☆ﾟ.*･｡ﾟ now you can tip others around GitHub weee

@Zydnar,@erdnaxeli,@Sclifftop

@Zydnar,@erdnaxeli,@Sclifftop

@Zydnar,@erdnaxeli,@Sclifftop


OBJ-242 chips client stub

Stubbed client and unit test. As the method is void there is not a lot to add.

There's a couple of Sonar issues to fix


question about rclc_executor_spin_period()

hey!I tried to use rclc_executor_spin_period() to generate a 10ms period spin,but it gives a error info,shows below:
.pio\libdeps\teensy35\micro_ros_arduino\src\mk64fx512\fpv4-sp-d16-hard\libmicroros.a(librclc-sleep.c.obj): In function `rclc_sleep_ms':
sleep.c:(.text.rclc_sleep_ms+0x8): undefined reference to `usleep'

help me plz!

Basically, you do not have any usleep function. Implement it and the linker will resolve the symbols against the library:
void
usleep(
  unsigned int us)
{
  delayMicroseconds(us);
}


Update the author of summary of S2E2

[x] Update the author of summary of S2E2
[x] delete duplicate word
[x] update cgpeter96-dunk-jpg file

@cgpeter96 should it be S03E02?

@cgpeter96 should it be S03E02?

yeap, I  made a mistake :cry:


feature(cli): add support for publishing from a subdirectory using publishConfig.directory

The PR resolves this issue: https://github.com/atlassian/changesets/issues/423
@Andarist

If a different location needs to be published, then changesets version should be executed in order to update the original package.json with the new version number, and commit it.

Is this any different from what we do now? I fail to see the difference.

In tools like lerna, it's possible to set publishConfig.directory and this tell the publish command that the actual directory is different.

Could you link to their docs about this feature? Are there any tools handling it in the same way?

@Andarist The difference is where do you run the  npm run publish.
Our setup has this after changesets version and yarn build:
packages/
  - a/
     - package.json
     - dist/
         - compiled.js
         - package.json
     - src/...

So there is a temporary package.json under dist, and this is the one we would like to publish, not the source one.
And here's a reference for that: https://www.npmjs.com/package/@lerna/publish#publishconfigdirectory

@Andarist resolved all comments :)

@Andarist The difference is where do you run the npm run publish.

Right, this matter for the publish alone though - it doesn't matter for the versioning step though. Maybe I've misunderstood your original comment somehow.


Docs for Reflex.Class

While reading the source I thought I could just as well add some docs so here they are. I might have missunderstood some parts so better read through it :) Because of lazyness I also put the removal of 'sequenceThese' in the same commit (tell me if I should remove this). This is exactly 'bisequenceA' from 'Bitraversable' which 'These' is an instance of.

sequenceThese should be deprecated rather than removed, but the rest looks good.  Thanks for putting all this effort into the docs!

Oh rebasing on develop and force pushing doesn't seem to have been such a good idea as I accidentally made the pr against master. Do you manage this when merging or should I make another pr against develop? I only changed the deprecation stuff.

I'll handle it in the merge.

Is there a particular reason to suggest bisequenceA instead of bisequence?  It looks like bisequence has a closer type signature to the original.

The reason is that bisequenceA is more general and at least with 7.10 always works where bisequence works due to AMP. And even before 7.10 there is a warning if your Monad is not an Applicative so this seems pretty save to me. If you disagree I can of course change it/you just change it when merging.

Merged; thanks!


[FIX] Build

[x] Fix an issue where index.js was being ignored by .gitignore which stops the package from being used properly when installed as a dependency to another project.
[x] Fix built folder not being created after npm install
[x] Fix bluebird error when building with npm install

It has it's downsides, cause I needed to move typescript to be a dependency, which will increase the size of the dependencies. The only way to avoid that would be commit the built/ directory to our repo, which is not ideal either.

I think the built might be okay, and can always be rebuilt

I think having it all built into a single file as the root index.js might work. Since right now to use it you have to compile it locally anyway so now you have installed typescript maybe you didn't want and still have the built locally.

Then we would be back at using Parcel. We can consider webpack I guess.


Performance issue in BIO_get_host_ip

The function BIO_get_host_ip performs poorly in the following environment
GNU C Library (GNU libc) stable release version 2.17
CentOS Linux release 7.3.1611
openssl version : 1.0.2
This function grabs a lock and then invokes gethostbyname. With multi-threaded application, the lock is a bottleneck and results in bad performance.
We can  use thread safe version gethostbyname_r instead of gethostbyname and eliminate the need for big lock in BIO_get_host_ip

It seems unlikely that this will get addressed.  This function is deprecated in 1.1.x and later and 1.0.2 is only getting bug fixes at this stage.

Would pull requests for it be accepted?

Pull requests are always welcome and will be evaluated on their merit.

Note that we need to retain the use of gethostbyname for those who don't have gethostbyname_r

Thanks for the inputs all.
Is there a compile time flag, which i could use to in order to call
gethostbyname_r ?
I think, it is safe to use gethostbyname_r for linux ?
Thanks
Mani
On Sun, Sep 16, 2018 at 3:49 PM Richard Levitte<EMAIL_ADDRESS>wrote:

Note that we need to retain the use of gethostbyname for those who don't
have gethostbyname_r
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/issues/7228#issuecomment-421847425,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACh8cxybDZOrdoMTH_W2K3YsNq3oGS3rks5ubtVigaJpZM4WqE19
.

You'll need to use the feature check macros.  man gethostbyname_r lists them.  On my machine:
   Feature Test Macro Requirements for glibc (see feature_test_macros(7)):

       gethostbyname2(), gethostent_r(), gethostbyaddr_r(), gethostbyname_r(),
       gethostbyname2_r():
           Since glibc 2.19:
               _DEFAULT_SOURCE
           Glibc versions up to and including 2.19:
               _BSD_SOURCE || _SVID_SOURCE

So you'll need something like:
#if defined(__GLIBC__)
# if defined(__GLIBC_PREREQ)
#  if __GLIBC_PREREQ(2, 19)
#   if defined(_DEFAULT_SOURCE)
#     define HAVE_GETHOSTBYNAME_R
#   endif
#  else
#   if defined(_BSD_SOURCE) || defined(_SVID_SOURCE)
#     define HAVE_GETHOSTBYNAME_R
#   endif
#  else
#   if defined(_BSD_SOURCE) || defined(_SVID_SOURCE)
#     define HAVE_GETHOSTBYNAME_R
#   endif
# endif
#endif

But I've probably made a mistake in there...

Hi All :
I have submitted a pull request for this change #7250.
Thanks
Mani


Events guide doesn't mention x-changed events.

The events guide doesn't talk about x-changed events even though it explains other globally available events (i.e. gestures). However, x-changed events are explained in the data binding guide, maybe we should add a short description and a link?

This issue was moved to Polymer/docs#1444


Add SwiftLint

We need to enforce clean code.
Add SwiftLint to automatically
check code style.

Run SwiftLint autocorrect and fix minor violations
Add .swiftlint.yml config
Add Xcode build phase to run linter on each build

@weby thanks! We need to not run linter on Linux https://docs.travis-ci.com/user/multi-os/

Changed travis config to only run SwiftLint on OSX.

@weby nice!


adding a new 'check_atp_ids_validity' to topic_entity_tag_utils.py and

updated "create_tag" function in topic_entity_tag_utils.py to call the new function to check ATP IDs' validity before adding the tag into the database.
updated the tag checking script to call the new check function
updated TET / reference unit tests to use mock_check_atp_ids_validity for the ID validity check.

@azurebrd Thanks!

@valearna Thanks!


Add example for nested columns with streaming

Request from community member for a streaming example with nested JSON, assuming support.
Per @gianm Usage with streaming would be similar to native batch: the dimensionsSpec and transformSpec work the same way

Relevant Slack thread (link good for 90 days): https://apachedruidworkspace.slack.com/archives/C0303FDCZEZ/p1664492820183909
Original question:

Looking forward to trying out nested columns Is this feature currently supported for streaming ingestion? It appears not since documentation calls out SQL based and batch ingestion methods but not streaming.

The response:

I believe it is supported for streaming ingestion, we just don't have an example
Usage with streaming would be similar to native batch: the dimensionsSpec and transformSpec work the same way

The doc in question is this page: https://druid.apache.org/docs/latest/querying/nested-columns.html

Thanks for the clarification, @gianm

Just tested it by using the kafka tutorial but replacing the wikipedia data with kttm nested data:
Steps:
Create the topic
./bin/kafka-topics.sh --create --topic kttm_nested --bootstrap-server localhost:9092
Get the nested data from kttm nested example:
curl https://static.imply.io/example-data/kttm-nested-v2/kttm-nested-v2-2019-08-25.json.gz -o kttm-nested-data.json.gz
gunzip -c kttm-nested-data.json.gz > kttm-nested-data.json

Publish to the topic:
export KAFKA_OPTS="-Dfile.encoding=UTF-8"
./bin/kafka-console-producer.sh --broker-list localhost:9092 --topic kttm_nested < kttm-nested-data.json

The UI for "Load Data" does not automatically recognize the nested JSON columns in the parsing step.
In the "Configure Schema" step, you can use "Add dimension", type the name and choose type "json".
The resulting Ingestion Spec:
  "type": "kafka",
  "spec": {
    "ioConfig": {
      "type": "kafka",
      "consumerProperties": {
        "bootstrap.servers": "localhost:9092"
      },
      "topic": "kttm_nested",
      "inputFormat": {
        "type": "json"
      },
      "useEarliestOffset": true
    },
    "tuningConfig": {
      "type": "kafka"
    },
    "dataSchema": {
      "dataSource": "kttm_nested",
      "timestampSpec": {
        "column": "timestamp",
        "format": "iso"
      },
      "dimensionsSpec": {
        "dimensions": [
          "session",
          "number",
          "client_ip",
          "language",
          "adblock_list",
          "app_version",
          "path",
          "loaded_image",
          "referrer",
          "referrer_host",
          "server_ip",
          "screen",
          "window",
          {
            "type": "long",
            "name": "session_length"
          },
          "timezone",
          "timezone_offset",
          {
            "type": "json",
            "name": "event"
          },
          {
            "type": "json",
            "name": "agent"
          },
          {
            "type": "json",
            "name": "geo_ip"
          }
        ]
      },
      "granularitySpec": {
        "queryGranularity": "none",
        "rollup": false,
        "segmentGranularity": "hour"
      }
    }
  }
}

@techdocsmith, This example works, but it requires the kafka setup steps to run, so I'm not sure if it fits in the nested columns docs page as is. Perhaps adjust the kafka tutorial so it uses this source instead? Let me know how else to help.

@sergioferragut , it could potentially go both places. on Nested columns to show it's possible & in the tutorial too. Thanks for sharing!


CVEs for golang 1.12.7

The version of golang used to compile certmanager containers is specified here:
https://github.com/jetstack/cert-manager/blob/master/WORKSPACE#L24
That version currently is 1.12.7
CVE-2019-9512 and CVE-2019-9514 have been identified against that version for net/url.
I see these reports with a breakdown of fixed golang versions:
https://security-tracker.debian.org/tracker/CVE-2019-9512
https://security-tracker.debian.org/tracker/CVE-2019-9514
I think the focus is on net/url package, and one of my colleagues thinks golang.org/x/net/http2 which I see in vendor.
thanks
-c
/kind bug

v0.10.1 is now out, so this can be closed 😄


refactor(ExecutorMapping): Bump defaults and improve wording

Love the project!  A few of my colleagues are using it already, and getting more comfortable with it.  Kudos!  👏🏻
When a user selects to add an executor, two of the technologies were slightly older versions. This PR bumps two of the executors to their latest defaults, with a goal to help ensure users creating a new pipeline are using the latest/greatest/patched. I can appreciate this project may not want to just continue to manage this long term, and the topic as a whole (pinning versions for stability vs. latest/stable for always patched) is complex.  Overtime, the project may want more automation around it, say collecting the latest/most recently published dynamically and presenting that, but for now just a small bump.
Also a small improvement in the wording of what an executor is, so it sort of fits in better with the other descriptions:

For automating this in the future, I believe we can use renovateapp. https://docs.renovatebot.com/configuration-options/#regexmanagers


highlight-deleted-and-added-files-in-diffs: Fix extra underline

Resolve #4871
Test URLs
4d7db
Screenshot
hover is now working as expected

Hi everyone, I would really appreciate if you please add the hacktoberfest and/or hacktoberfest-accepted labels to this PR.
I am not even sure if you can add label after closing the PR or no.