Bot stop working on a server

Bot stop working on a server started as php start_bot.php with no log information
Should I make some extra settings for my server?

How often? sometimes it stops pulling updates but there was always an error log like time out. Personally, I use webhook with ReactPHP and TDLight bot API server and seems no problem.

I think, it stops every three days (proximetly)

try this:
$config->setPollingRetry(10);
$config->setPollingTimeout(120);

If didn't help, try using TDLight Telegram Bot API or Telegram Bot API server itself:
$config->setApiTelegramUrl('http://<IP_ADDRESS>:8580'); // local bot API server port
This might be helpful as well:
[Unit]
Description=Telegram-bot-api server
Wants=network-online.target
After=network.target network-online.target
StartLimitIntervalSec=60
[Service]
Type=simple
Restart=always
RestartSec=1
User=bots
ExecStart=/usr/bin/telegram-bot-api --api-id=API_ID --api-hash=API_HASH --local --http-port=8580 --dir=/home/bots/telegram-bot-api --allow-users -v1

[Install]
WantedBy=multi-user.target

$config->setApiTelegramUrl('http://<IP_ADDRESS>:8580'); // local bot API server port

Tryed $config->setPollingRetry(10); $config->setPollingTimeout(120); - haven't helped. The bot have collupsed again after 3 days.
Try $config->setApiTelegramUrl('http://<IP_ADDRESS>:8580'); and get an error "Failed to call Telegram Bot Api, method: getWebhookInfo, params: [], reason: RuntimeException: Connection to tcp://<IP_ADDRESS>:8580 failed: Connection refused (ECONNREFUSED) in /vendor/react/socket/src/TcpConnector.php:140"

You should install it and set it on that specific port, follow this build instructions generator
If you don't get it read about it here : Using a Local Bot API Server) and here: Local Bot API Server Usage.

Thank you so much, and I really sorry: I use a virtual hosting for my projects, and, as it turned out, it is not permitted to use any kind of bots, so they just stoped it forced.
Thank you again for your help : )

You should install it and set it on that specific port, follow this build instructions generator
If you don't get it read about it here : Using a Local Bot API Server) and here: Local Bot API Server Usage.

Thank you so much, and I really sorry: I use a virtual hosting for my projects, and, as it turned out, it is not permitted to use any kind of bots, so they just stoped it forced.
Thank you again for your help : )


Frontend - Module Enablement

Feature or Bugfix

Feature: based on this PR #415

Detail

Enable/disable frontend modules by leveraging values defined in configs.json file

Relates

#410

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM!


Fix Lightning Orchestrator (remove -y from pip install)

Describe changes
I fixed the lightning orchestrator by removing the -y flag from the pip install commands as this flag doesn't exist and breaks the pipeline run.
Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@safoinme how did this ever work? :-O

This was changed and pushed in the last commit before merging


remove useless code in cors plugin

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c647ab3) 33.66% compared to head (89756fc) 34.05%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   33.66%   34.05%   +0.39%
==========================================
  Files          78       78
  Lines       11204    11204
==========================================
+ Hits         3772     3816      +44
+ Misses       7142     7096      -46
- Partials      290      292       +2

see 1 file with indirect coverage changes


Input characters are deleted during entry - Render Mode Server only

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
During text input, e.g. logging in, characters are deleted while validation is done.
Expected Behavior
Input should not be influenced.
Steps To Reproduce

Setup new Bit.Boilerplate::8.9.0
Host in Server Rendered Mode only (debug or forced server rendered in release)
Publish the host to IIS or make it available via tunnel (e.g. https devtunnel from Visual Studio)
Access host from windows-chrome
Open login page and start entering an Email-address
Characters are deleted
Note:
The behaviour is not visible by just debugging in devmode locally. It must be exposed as published on a real host or at least via a tunnel e.g. devtunnel while debugging in Visual Studio.

https://github.com/bitfoundation/bitplatform/assets/71921910/7e34a458-6c79-4c95-b180-467238693200
Exceptions (if any)
None.
.NET Version
8.0.301
Anything else?
No response

@techscx Thanks for contacting us.
We know about this issue. This problem is related to how BlazorServer works, and an issue already exists for it (https://github.com/bitfoundation/bitplatform/issues/7660).
We are already working on a PR (https://github.com/bitfoundation/bitplatform/pull/7804) to remedy this issue by providing a new feature for disabling Immediate feedback of the inputs to lessen the problem you've shown in this issue.

@techscx Thanks for contacting us. We know about this issue. This problem is related to how BlazorServer works, and an issue already exists for it (#7660). We are already working on a PR (#7804) to remedy this issue by providing a new feature for disabling Immediate feedback of the inputs to lessen the problem you've shown in this issue.

Oh, thank you for clarification.

@techscx
the new prerelease that resolves this issue is now available. you can now use the inputs without Immediate binding while typing so this problem should not be happening anymore.

Thank you!

@techscx the new prerelease that resolves this issue is now available. you can now use the inputs without Immediate binding while typing so this problem should not be happening anymore.


Add HostSNIRegexp

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
I'd like to have a HostSNIRegexp so that I can route all subdomains to a certain service, without referencing them all at once.
I.e. similar to the HostRegexp rule:
HostSNIRegexp(`example.com`, `{subdomain:[a-z]+}.example.com`, ...)

That would save time with static configs and a lot of subdomains.

related to  #6003

Any news about this one? On the related PR it was mentioned that a discussion should take place about the replacement of mux. Is it the right place?

I also don't understand if #6003 fixes/closes this.. ?

Ok, it seems this is still not implemented. #6003 was closed and not merged.

Hi !
I'm interested in this feature (using it and eventually contributing to).
How can we make this issue progress one step further ?
Has the new regex syntax mentioned in #7635 been implemented ?

As explained in # 6003, we think that the mux syntax for regex is not perfect. For a new regex matcher we think it's not a good idea to use the mux syntax, but if we introduce a new syntax, we need to handle it in both TCP and HTTP regex matches.

This is also relevant to me. I have a downstream cluster that handles all requests for a certain subdomain and I cannot know in advance what the domains will be. TLS Termination in traefik is not an option unfortunately.

I would be also glad about such a feature.
I am have some docker services on a different network. The docker host runs also a traefik instance. The traefik on the docker host routes all containers on common ports and does the detection of the services and ssl via labels.
The docker host forwads the traefik ports for web and websecure(ssl) over an ssh tunnel to another publicly accessible  gatway.
From there i would like to route all requests matching (e.g. "*.docker.myhost.com") to the tunnels.

Hello all.
I've faced the same problem, and managed to patch Traefik 2.5.4 to allow wildcards in TCP  rules. Now, I can write a rule like this one:

match: HostSNI(iam3-gw.soffid.com)||HostSNI(*.iam3-gw.soffid.com)

This is the first time I code in GO and I am not a Traefik expert, but as long as we have tested, it has worked fine.
Hope it helps you and can be merged in future versions.
0001-Allow-wildcards-in-HostSNI.patch.txt
.

any news on this?
this feature is exactly what we need currently.

@Links2004 we have this feature in our roadmap for the next minor version, Traefik 2.7, but right now we are blocked until #8182 is merged. Once that happens we can start implementing the HostSNI matcher with the new TCP muxer 🥳


[BUG] UCI BusinessProcessFlow BooleanItem SetValue fails

EasyRepro Version

[ ] Microsoft Dynamics 365 Online Version 8.2 (8.2.x) (DB 8.2.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0 (9.0.x) (DB 9.0.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0.2 (9.0.2) (DB 9.0.2) online
[x] Microsoft Dynamics 365 Online Version 9.1 (9.1.x) (DB 9.1.x) online

UCI or Classic Web

[x] UCI (XrmApp)
[ ] Classic Web (XrmBrowser)

Online or On Premise

[x] Online
[ ] On Premise

Browser

[x] Chrome
[ ] Firefox
[ ] IE
[ ] Edge

Describe the bug
Cannot update Two Option field on the Business Procees Flow of a Case.
The code fails and the error "System.ArgumentException: MoveToElement cannot move to a null element with no offset. Parameter name: toElement" is displayed.
Special formatting / display
Unknown
Code to reproduce
This is a custom Two Option field on our Case BPF.
This is the method we are using:
xrmApp.BusinessProcessFlow.SetValue(new BooleanItem { Name = "NAME_OF_FIELD", Value = true });
Expected behavior
Should be able to update the field
Screenshots

Additional context
This is the element from the Dev Tools:
No

@jtemple2 - If you have not, could you try testing this with the latest develop branch?
We're planning to push a new release very soon -- if you still have problems I may be able to try and get a change in if necessary.
Warm Regards,
Tyler

@jtemple2 - We moved ahead with merging to releases/v9.1 and publishing the <IP_ADDRESS>38 NuGet package. Please test accordingly and let us know if this problem persists.
Warm Regards,
Tyler

@TYLEROL
Thank you for your update.
I got the latest off releases/v9,1 and modified one of the sample tests to set the value for the field on the BPF I am trying to interact with.
The test is still throwing an error though this time it's "System.NullReferenceException: 'Object reference not set to an instance of an object.'"
I checked the AppElementReferences for the xpath:
{ "BPF_BooleanFieldContainer", ".//input[contains(@data-id, 'header_process_[NAME].fieldControl-checkbox-toggle')]" }
but that doesn't match the one for the field  I am trying to set.
I can be find the field with this xpath:
.//label[contains(@data-id, 'header_process_[NAME].fieldControl-checkbox-inner-first')]
Thank you for your help with this
Regards,
Jean


Add a tool to compare and get diff records for readonly store.

Add a tool ReadOnlyFileDiffer to compare between the two versions of readonly data and print the number of added, deleted, updated and same records.

Very cool, I'll review ASAP.

Yan, I left some comments, but the code quality is very good, loved it. It was easy to read and understand and very modular. They are all very minor comments.
Since this is all new code and does not touch any existing code path, there is no impact to the existing scenarios.

Very nice code! Left some minor comments.


What default parameters uses -pbkdf2?

Hi guys, I encrypted a file with this command:
openssl enc -aes-192-cbc -e -pbkdf2 -in <infile> -out <outfile> -pass pass: <password>
Now I'm trying to do decrypt it in c and to take advantage of pbkdf2 I'm using the function:
int PKCS5_PBKDF2_HMAC (const char * pass, int passlen,
                        const unsigned char * salt, int saltlen, int iter,
                        const EVP_MD * digest,
                        int keylen, unsigned char * out);

But the problem is: I know the parameters pass, passlen, keyless and *out...
How do I know what are the parameters for the salt, iter and digest that correspond to the command written above?

This was answered via you stackoverflow question (which I saw before this one!).
https://stackoverflow.com/questions/58823814/what-default-parameters-uses-openssl-pbkdf2
Closing.


raftstore: fix wrong last index

When applying two snapshot async at the same time, raft state machine may compute the wrong last index. So we need to abort applying old snapshot first.
close #1014

LGTM

PTAL @hhkbp2

LGTM

LGTM


[dv/top_earlgrey] Add rstmgr tests

Add full chip level tests for the rstmgr functionality.
Signed-off-by: Guillermo Maturana<EMAIL_ADDRESS>

Is there a check that rst_por_n is stretched inside the reset manager?

Sha-ron, there is a dedicated IP test for reset stretching: reset_stretcher in hw/ip/rstmgr/data/rstmgr_testplan.hjson.


Prevent simultaneous UA starts

Running into an issue where multiple calls to UA.start() before the UA has connected will result in multiple open web sockets. It's possible to prevent this in our implementation, but this seems like logic that belongs on the UA, and other SIPjs users may benefit from.

Thanks!
-Will


BUG use_only_x_path requires CMS user to re-authenticate on publish of page

This issue has been brought up a couple times and our implementations tend to utilize the use_only_x_path quite a bit and when a page is published it prompts the login overlay within the CMS.
We're reviewing how the code acts with use_only_x_path enabled from a session perspective, mainly surrounding the use of Directory::test() however we have not identified the core issue. Not implementing the `use_only_x_path config option results in normal CMS activity.

I came across this comment https://github.com/silverstripe/silverstripe-sharedraftcontent/pull/153#issuecomment-1050699391 when looking at an unrelated issue and thought it may have some insight into how the session could be invalidated causing the user to have to re-auth.

It would be nice to solve the issue with Director::test(), but in the meantime would it be feasible to replace the line
$output[] = Director::test($searchLink);
with a different method.
This module does things a little differently. Looks like it creates a separate session and just renders the page with $page->forTemplate()
https://github.com/wilr/silverstripe-algolia/blob/main/src/Service/AlgoliaPageCrawler.php


"catch-all" endpoint doesn't work with static_url_path="/"

Catch all endpoint for SPA from docs doesn't work with static_url_path="/" or static_url_path=""
Context
I'm using Flask to serve React SPA with client-side routing.
Flask worked perfectly, until I added images and decided to serve it from static/ folder.
Expected:
I can serve images from static/ folder.
I can reload a non-root page and Flask won't respond with 404 Not Found.
Current:
I can navigate to /path or /path1/path2 and etc. with no problems, but when I reload any non-root page the Flask gives me 404 Not Found and the catch-all route didn't trigger.
Example:
folder structure
.
├── __init__.py
└── main/
    ├── static/
    │   ├── image1.jpg
    │   ├── image2.jpg
    │   ├── index.html
    │   └── main.js
    ├── __init__.py
    └── routes.py

./__init__.py
def create_app(config_class=Config) -> Flask:
  app = Flask(__name__)
  from .main import bp as main_bp
  app.register_blueprint(main_bp)
  return app

./main/__init__.py
from flask import Blueprint

bp = Blueprint("main", __name__, static_folder="static", static_url_path="/")

from .main import routes

./main/routes.py
from .main import bp

@bp.route("/", defaults={"path": ""})
@bp.route("/<path:path>")
def catch_all(path):
    return bp.send_static_file("index.html")

Error message
<!doctype html>

<title>404 Not Found</title>

Not Found

The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.

Environment:

Python version: Python 3.9.2
Flask version: Flask 2.2.5

The static route is a catch-all path, it matches all paths below it. You need a prefix like /static to distinguish it if you have another top-level catch-all path.


Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] assigned appropriate label? (exclude from changelog with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Base: 64.50% // Head: 62.44% // Decreases project coverage by -2.05% :warning:

Coverage data is based on head (719c422) compared to base (fee1c95).
Patch coverage: 56.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
- Coverage   64.50%   62.44%   -2.06%
==========================================
  Files         843      822      -21
  Lines       17545    17234     -311
  Branches     1087     1077      -10
==========================================
- Hits        11317    10762     -555
- Misses       5780     6051     +271
+ Partials      448      421      -27

Impacted Files
Coverage Δ

...contractdefinition/SqlContractDefinitionStore.java
0.00% <0.00%> (ø)

...actdefinition/schema/BaseSqlDialectStatements.java
0.00% <0.00%> (ø)

...efinition/schema/ContractDefinitionStatements.java
0.00% <0.00%> (ø)

...ion/schema/postgres/ContractDefinitionMapping.java
0.00% <0.00%> (ø)

...r/contract/spi/types/offer/ContractDefinition.java
67.64% <50.00%> (-3.79%)
:arrow_down:

...ract/validation/ContractValidationServiceImpl.java
60.60% <57.14%> (-0.34%)
:arrow_down:

...nector/contract/spi/types/offer/ContractOffer.java
41.66% <66.66%> (+12.77%)
:arrow_up:

...iation/ConsumerContractNegotiationManagerImpl.java
87.44% <100.00%> (ø)

...iation/ProviderContractNegotiationManagerImpl.java
90.10% <100.00%> (-0.45%)
:arrow_down:

...definition/model/ContractDefinitionRequestDto.java
100.00% <100.00%> (ø)

... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Menu is rendered off screen if the element it's bound to is near bottom of the page

As per the title.
This at least happens when the element is near bottom of screen; I haven't tested when element is at very right of page too.
Happens with latest version of Chrome on Windows.

Can you work on a fix for this one?

Yeah I'll have a look at it.
On 20 Nov 2015 17:04, "Nicolás Escalante"<EMAIL_ADDRESS>wrote:

Can you work on a fix for this one?
—
Reply to this email directly or view it on GitHub
https://github.com/nescalante/knockout.contextmenu/issues/8#issuecomment-158461063
.


After CTRL+Scroll to zoom in and out a ton, the text gets garbled

From MSFT:21430356
After CTRL+Scroll to zoom in and out a ton, the text gets garbled
I scrolled with CTRL+Scroll to make it really small and really big and went back and forth. Then, I can scroll up and get garbled text that only extends a few characters but are truncated rather than wrapping.

Has anyone been working on this?
When I begin a new tab and then I change the size of the text using ctrl+scroll, I see some garbage text when I scroll up.

Nope, feel free to take a stab at it if you'd like. My guess is that we're not "reflowing" text that's outside of the viewport when we resize the buffer, we're merely truncating it to the new size of the buffer. There's almost certainly code in conhost's SCREEN_INFORMATION class that could help with this, though it'd have to be ported down a layer, to the TextBuffer class.

Alright, thanks for the suggestion. I will take a look at it.

window::verticalScroll is called in this function ^

Here is the definition of window::verticalScroll.
I think this is where the issue might be. But I am a little stuck here. Can someone help me out here?

This is the max I could get to zoom and render. I have a 1080p display this is too much!

@DHowett I am not complaining about my font being too big :D but saying it is not stopping! I do believe it should have a max limit, where scrolling won't have any effect. I could see the cursor growing and growing.

@dash-mode The function you're actually looking for is SCREEN_INFORMATION::ResizeWithReflow in screeninfo.cpp

I do believe it should have a max limit, where scrolling won't have any effect. I could see the cursor growing and growing.

I agree though probably not for exactly the same reason. I could see a potential crash occurring either with the tab, the Terminal, or potentially Windows itself (though I find that highly unlikely) or a crash in the GPU that causes a reset. It raises an availability concern and potentially other security concerns. Setting a max limit would be best but I think if it can fit on the screen, it should be permitted. I would execute some query logic based on device type to determine the visual range available for the screen.

Luckily I have found an issue representing my problems and then seeing it is already known for a half year. Aww.
Anyway, here is a visual I created to demonstrate. It is good to have anyway.


Scan - Selected category and tag do not show up in the row in Split action menu

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to workspace chat of a workspace that has Category and tag
Click + > Spit money > Scan
Upload a receipt and create a Scan request
Click on the split preview
Click Category and select a category
Click Tag and select a tag

Expected Result:
The selected category and tag will show up in the row
Actual Result:
The selected category and tag do not show up in the row
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/26308851-4b6f-468d-b4de-f2c676b3f292
View all open jobs on GitHub

@rezkiy37 @cubuspl42 @puneetlath We think this may be coming from: https://github.com/Expensify/App/pull/31647

Srikar has finals so I'm gonna take a look at this one.

Fix is on staging! Closing this out


A "Lite" version for faster client-side loading?

The WASM js bundle in loro-crdt is nearly 4 MB, which is too large for certain applications, especially mobile apps. Is it possible to create a "Lite" version of the wasm payload, perhaps a restricted subset of capabilities, in order to widen the acceptance parameters for a wider audience / subset of applications? Something under 1 MB seems more reasonable, and of course smaller is better.
(I love what you're doing with this project, thank you!)

Thanks! I’d like to have loro-lite as well. Meanwhile, the gzipped WASM is smaller than 1MB.


chore: devtools logs

Change Summary

Adds logs to the debugger to help devs that think logs will show up in browser

@davidfurlong is this ready to be merged?

yes


Test in Nvidia-Dynamic Scenes

Hi, Thanks for your wonderful work and the release of the codes! I have tried it in the Nvidia datasets in the monocular setting followed DynIBar. However, the results seem blurring and nosiy. Here is a sample image.

I am using the custom dataset to train the nivida dataset without any change. I am curious why the static backgroud is fuzzy, as your demos are pretty clear. Can you help me to find out the reason? Thanks very much!

Hi if the background is blurry I think the most likely reason is the camera parameters, as the background modeling is normal 3DGS. One way to verify this is to use the GT camera poses in the Nvidia datasets and see if the issue persists. Indeed we found our camera estimation to be one of the most limiting factors of the whole pipeline. We hope to improve the camera estimation for in-the-wild videos in the future.

One way to verify this is to use the GT camera poses in the Nvidia datasets and see if the issue persists.

Thanks for your great work!!!
But I have the same question. And I also found that the dynamic things(like the balloon) move unsmoothly.
https://github.com/user-attachments/assets/81b84453-1851-4f9c-9b53-44cf061e8b56
I tried simply to replace the traj_c2w in droid_recon/Balloon1.npy with the GT camera pose. But it seems a wrong attempt. Could you please explain the way to use the GT camera poses?

Hi if the background is blurry I think the most likely reason is the camera parameters, as the background modeling is normal 3DGS. One way to verify this is to use the GT camera poses in the Nvidia datasets and see if the issue persists. Indeed we found our camera estimation to be one of the most limiting factors of the whole pipeline. We hope to improve the camera estimation for in-the-wild videos in the future.

Thanks for your reply and sharing. It is really intutive!

Hello
Thank you very much @qianqianwang68 for your work. I was wondering what convention the camera parameters should be. I  ran Colmap on my custom dataset and plugged it into casual_dataset.py.
But it still gives blurry backgrounds, indeed as if the camera parameters are bad.
Thanks in advance.


chore: bdd-spring-1584872617 to 0.0.1

chore: Promote bdd-spring-1584872617 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


RLL Routine Rung Comment Generation

I have run into an issue when creating a new RLL Routine and adding a commented Rung.
In L5X output, the Comment element is added after the Text element. When importing into Studio 5000 (v33.11), it gives the following error:
Element <Comment> is in the wrong order.
If I manually swap the order in the L5X, everything imports correctly. Is there something I can do to re-order the way the rung tags are generated?

Hey,
No, I think this is bug. Thanks for reporting it. I will look to see if I can get it fixed here shortly.

Thank you sir!

Okay try upgrading to 0.19.6 and see if that fixes it. The Comment element should now always appear first before the Text element, regardless of when it is set. I added some tests to make sure.

Confirmed: running the same generation with version 0.19.6 has the Comment tag first, and was successfully imported into Studio 5000.
Thank you again!


Avoid dependence on the 'pathwatcher' package, in favor of using 'fs'

#28 requires Directory from atom instead of pathwatcher; might solve this


Unknown build error, 'An item with the same key has already been added.'

Sometimes when generating the project I get this error
Unknown build error, 'An item with the same key has already been added.'
This happens in DemoApplication or in DemoApp.Net5.0
if I Clean and Rebuild the solution and change the startup project it stops this error.
Do you know what this error is?
Thanks

These errors will be fixed with the next commit.
The next commit comes for the end of this week or next week.

Thanks
It's a great job.


Question: is react-redux compatible with the new redux v4.0.0

https://github.com/reactjs/react-redux/blob/master/package.json#L48

@timdorr thanks! I didn’t know how to check it, now I know :)


Minikin font loading causes jank in scrolling

Mirror issue for https://b.corp.google.com/issues/132954783. Conversation should occur there, please.

The upstream issue is marked fixed.


feat(Algebra): add two lemmas

Developed in conjunction with #19660, but found not to be needed.

Thanks!
bors merge


pyproj Transformer - order of inputs dependent on epsg

order of inputs in Transformer.transform appears to depend on the epsg provided.  Needs more testing.

Resolved with using the always_xy keyword argument.  See 8e68cb5d6455e602716d0bba5effba920219d45e


fix: use or operation in port validation method

I think there is a logic bug in the port validation, so create this pr, please check.

thank you very much!


Create test_in_docker.md

credit: Hugues de Valon

Thanks for recording this in documentation!!
I think ideally we want those kind of guides on the Parsec book. Part of this info is already in this section but I agree it is not self-sufficient and hard to find.
We need to think about a better strategy documentation on "how to get start" and refactor some of our pages in the book, possibly including the PR you sent.
For now I would say, let's wait but try to think about it when are to refactor our new starter documentation.

Hey @kevingzhang !
I just added a PR here with a basic "getting started" guide. Now it just uses the software Mbed Crypto provider but in the future it will also feature running inside a Docker container with all providers. There will also be examples in Rust and Go clients.
I am closing this PR for now as we will add the "getting started"/"quickstart" info in that part of the book!


Sonoma Web Apps support. Lit 3

Major release:

PWA Install dialog for Sonoma Safari (need to test first)
Upgrade to Lit v3
New translation strings AI translated (need to verify)
New Hide Screenshots property
iOS start_url hack

Calling everyone who contributed to features and translations. Can you verify your language strings?
And also, if someone have Sonoma device, can you check in Safari? I will do this soon but it's not very handy for me.
@ShoWerZen @dartess @Blankjr @s0xDk @jivanf @MertcanDinler @hoRacy @benfavre @Georgegipa

uk and ru looks fine.
will check Safari in Sonoma now...

Works like a charm in Sonoma/Safari! 🔥

I can't test on Sonoma, but es LGTM
Thank you for this release!

PL looks fine. Thank for your work!

DE string translations looking fine.  Appreciate your efforts!


fix: Added support for Array schema

Closes #1
This PR also addresses various other things within the project, like tests & ensuring that the typings are found correctly, as well as removing compiled files from the repo.

Are you meaning shrinkwrap vs package-lock? As far as I'm aware package-lock.json is essentially a new version of the shrinkwrap functionality, but is a bit easier to use as it just works with npm install without any hassle

btw, are you meaning to re-approve the PR so much? 😛

Ha, I was looking at the review functionality in GitHub. :P

Fair enough! lmk if you want me to change anything

Thank you for sorting that 🎉 currently underwater with a work project, but should be wrapped up on Thursday so will be able to take a look at & have a chat about some of the other issues 😄


Registering ProGet feeds fails

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
We've been using ProGet with no issues with PowerShellGet for years ...

$ServerDomain = "ProGet"
$FeedName  = "PowerShell"

Register-PSResourceRepository -Name $ServerDomain -Uri https://$ServerDomain/nuget/$FeedName -Trusted -Force
Install-PSResource $ModuleName -Repository $ServerDomain

Install-PSResource: Repository 'ProGet' is not a known repository type that is supported. Please file an issue for support at https://github.com/PowerShell/PSResourceGet/issues

Important:
I was able to get it to work by simply editing $Home\AppData\Local\PSResourceGet\PSResourceRepository.xml and replacing "unknown" with "v2" -- this is purely a bug in Register-PSResourceRepository which I don't understand.
Expected behavior
Register-PSResourceRepository should _just work_

Actual behavior
Register-PSResourceRepository put `APIVersion="unknown"` in the `PSResourceRepository.xml` file

Error details
Exception             :
    Type    : Microsoft.PowerShell.PSResourceGet.UtilClasses.ResourceNotFoundException
    Message : Package 'LDGit' could not be found in any registered repositories.
    HResult : -2146233088
TargetObject          : Microsoft.PowerShell.PSResourceGet.Cmdlets.FindHelper
CategoryInfo          : ObjectNotFound: (Microsoft.PowerShel….Cmdlets.FindHelper:FindHelper) [Find-PSResource], ResourceNotFoundException
FullyQualifiedErrorId : PackageNotFound,Microsoft.PowerShell.PSResourceGet.Cmdlets.FindPSResource
InvocationInfo        :
    MyCommand        : Find-PSResource
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : 19
    Line             : Find-PSResource LDGit -Verbose -Debug
    Statement        : Find-PSResource LDGit -Verbose -Debug
    PositionMessage  : At line:1 char:1
                       + Find-PSResource LDGit -Verbose -Debug
                       + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    InvocationName   : Find-PSResource
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo :

Environment data
ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Binary     0.9.0      rc1        Microsoft.PowerShell.PSResourceGet  {Find-PSResource, Get-InstalledPSResource, Get-PSResourceRepository, Get-PSScriptFileInfo…}

Name                           Value
----                           -----
PSVersion                      7.4.0-preview.5
PSEdition                      Core
GitCommitId                    7.4.0-preview.5
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

We discussed this and determined that setting the api version value to a best guess is better than setting it to unknown if we can't for certain determine the API version (this wasn't a problem in PowerShellGet since only v2 was supported), if it is a guessed api version rather than known, we may want to emit a warning so the user can use the Set-PSResourceRepository cmdlet to update the ApiVersion if they themselves know the api version of the feed they are using and the guess is incorrect
Better documentation on the ApiVersion should be coming shortly

Can the cmdlet be updated to auto discover which version is in use? Try v3 first and then fall back to v2 and if that doesn't work make the API version unknown.

Have the same issue with Proget feeds with an added nuance on the workaround.
If I manually edit $Home\AppData\Local\PSResourceGet\PSResourceRepository.xml the work around from "unknown" to "v2" it allows Find-PSResource to work however the Name property is blank which will result in an error on Install-PSResource.
Output
Output of Find-PSResource -Name Pester -Repository GalleryProxy as I can't upload an image from this machine:
Name Version Prerelease Repository   Description
---- ------- ---------- ----------   -----------
     5.5.0              GalleryProxy Pester provides a framework for running BDD style Tests to execute and validate PowerShell commands inside of PowerShell and offers a powerful set of Mocking Functions that allow tests to mimic and mock the functionality of any command insid…

Errors
Piping to Install-PSResource (Get-Error output):
Exception             :
    Type    : Microsoft.PowerShell.PSResourceGet.UtilClasses.ResourceNotFoundException
    Message : Package(s) '' could not be installed from repository 'GalleryProxy'.
    HResult : -2146233088
TargetObject          : Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallPSResource
CategoryInfo          : InvalidData: (Microsoft.PowerShel…s.InstallPSResource:InstallPSResource) [Install-PSResource], ResourceNotFoundException
FullyQualifiedErrorId : InstallPackageFailure,Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallPSResource
InvocationInfo        :
    MyCommand        : Install-PSResource
    ScriptLineNumber : 1
    OffsetInLine     : 59
    HistoryId        : 14
    Line             : Find-PSResource -Name Pester -Repository GalleryProxy | Install-PSResource
    PositionMessage  : At line:1 char:59
                       + … Resource -Name Pester -Repository GalleryProxy | Install-PSResource
                       +                                                      ~~~~~~~~~~~~~~~~~~
    InvocationName   : Install-PSResource
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo :

Running Install-PSResource directly (Get-Error output):
Exception             :
    Type       : System.NullReferenceException
    TargetSite :
        Name          : InstallVersion
        DeclaringType : Microsoft.PowerShell.PSResourceGet.Cmdlets.V2ServerAPICalls, Microsoft.PowerShell.PSResourceGet, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null
        MemberType    : Method
        Module        : Microsoft.PowerShell.PSResourceGet.dll
    Message    : Object reference not set to an instance of an object.
    Source     : Microsoft.PowerShell.PSResourceGet
    HResult    : -2147467261
    StackTrace :
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.V2ServerAPICalls.InstallVersion(String packageName, String version, ErrorRecord& errRecord)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.V2ServerAPICalls.InstallPackage(String packageName, String packageVersion, Boolean includePrerelease, ErrorRecord& errRecord)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper.BeginPackageInstall(VersionType searchVersionType, NuGetVersion specificVersion, VersionRange versionRange, String pkgNameToInstall, PSRepositoryInfo repository, ServerApiCall currentServer, ResponseUtil
currentResponseUtil, String tempInstallPath, Hashtable packagesHash, ErrorRecord& errRecord)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper.InstallPackages(String[] pkgNamesToInstall, PSRepositoryInfo repository, ServerApiCall currentServer, ResponseUtil currentResponseUtil, ScopeType scope, Boolean skipDependencyCheck, FindHelper findHelper)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper.ProcessRepositories(String[] repository, Boolean trustRepository, Boolean skipDependencyCheck, ScopeType scope)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallHelper.BeginInstallPackages(String[] names, VersionRange versionRange, NuGetVersion nugetVersion, VersionType versionType, String versionString, Boolean prerelease, String[] repository, Boolean acceptLicense, Boolean
quiet, Boolean reinstall, Boolean force, Boolean trustRepository, Boolean noClobber, Boolean asNupkg, Boolean includeXml, Boolean skipDependencyCheck, Boolean authenticodeCheck, Boolean savePkg, List`1 pathsToInstallPkg, Nullable`1 scope, String tmpPath, HashSet`1 pkgsInstalled)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallPSResource.ProcessInstallHelper(String[] pkgNames, String pkgVersion, Boolean pkgPrerelease, String[] pkgRepository, PSCredential pkgCredential, InstallPkgParams reqResourceParams)
   at Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallPSResource.ProcessRecord()
   at System.Management.Automation.CommandProcessor.ProcessRecord()
CategoryInfo          : NotSpecified: (:) [Install-PSResource], NullReferenceException
FullyQualifiedErrorId : System.NullReferenceException,Microsoft.PowerShell.PSResourceGet.Cmdlets.InstallPSResource
InvocationInfo        :
    MyCommand        : Install-PSResource
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : 12
    Line             : Install-PSResource -Name Pester -Repository GalleryProxy
    PositionMessage  : At line:1 char:1
                       + Install-PSResource -Name Pester -Repository GalleryProxy
                       + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    InvocationName   : Install-PSResource
    CommandOrigin    : Internal
ScriptStackTrace      : at <ScriptBlock>, <No file>: line 1

Environment
ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Binary     1.0.0                 Microsoft.PowerShell.PSResourceGet  {Find-PSResource, Get-InstalledPSResource, Get-PSResourceRepository, Get-PSScriptFileInfo…}

Name                           Value
----                           -----
PSVersion                      7.3.7
PSEdition                      Core
GitCommitId                    7.3.7
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

and
Name                           Value
----                           -----
PSVersion                      5.1.22621.1778
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.1778
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

It works if you update the uri to this:
Register-PSResourceRepository -Name ProGet -Uri https://$ServerDomain/nuget/$FeedName/v3/index.json -Trusted

@ajansveld I just tried to repro this on a connector based feed in ProGet (that proxies PSGallery) but any Find-PSResource/Install-PSResource return 404 when hitting ProGet's v3 URL.
Install-PSResource: 'Response status code does not indicate success: 404 (Not Found).' Request sent: 'https://my.proget.instance/nuget/GalleryProxy/v3/index.json'
Install-PSResource: Package(s) 'PSTcpIp' could not be installed from repository 'GalleryProxy'.

Current ProGet Version: Version 2023.24 (Build 3)
Beyond using that v3 URL did you need do anything else?

To be clear, the command always ran without errors, it just didn't put the right thing in $Home\AppData\Local\PSResourceGet\PSResourceRepository.xml

@ajansveld I just tried to repro this on a connector based feed in ProGet (that proxies PSGallery) but any Find-PSResource/Install-PSResource return 404 when hitting ProGet's v3 URL.
Beyond using that v3 URL did you need do anything else?

I don't think so, other than enabling JSON-LD (v3) api support for the endpoint of course.
Does this show your modules?
(Invoke-RestMethod https://my.proget.instance/nuget/GalleryProxy/v3/search).data

@ajansveld unfortunately I no longer work at the organization that had Proget and can't check this.

@Jaykul do you believe this is still an issue? I cannot repro the problem (as long as the correct uri is used).

We can't just use v3/index.json when PSResourceGet doesn't support dependencies on v3 feeds.
Other than that ... I've completely stopped using this module pending a release that actually works.


UNIT TESTS - components/DocWrapper/DocList

What
Create unit tests using Jest and React Testing Library.
Here are a couple examples of how unit tests should be created:

Unit tests for our A component
Unit tests for Icon component
Unit tests for Button component

General Acceptance Criteria for writing Unit tests

Should create a [nameOfComponent].test.tsx within the same directory of the component.
Should have tests that tests every prop of the component.
If there are any conditional logic within the component, there should be unit tests that accounts for each conditional branches.
npm run test should be passing.

Specific Acceptance Criteria

make sure you tests for each prop

closing this as fixed by #1401


Not working with commonmarker v0.22.0

By https://github.com/gjtorikian/commonmarker/pull/140 change, CommonMarker::Config::Parse, CommonMarker::Config::Render were removed.
They seem to change to CommonMarker::Config::OPTS.fetch(:parse), CommonMarker::Config::OPTS.fetch(:render) respectively.

Created 2 PR's.

https://github.com/clear-code/redmine_common_mark/pull/11

Restrict commonmarker version under 0.22.0.

https://github.com/clear-code/redmine_common_mark/pull/12

Use commonmarker version 0.22.0 or later, change to use CommonMarker::Config::OPTS.fetch(:parse), CommonMarker::Config::OPTS.fetch(:render).

The latter is based on the former.

Should be fixed by #12


Issue with projected band plotting

Hello
I'm trying to plot the band structure for my system. The overall band structure works fine but any projections yield the error:
P_Km = P_Km * band_weight_sets[ii][jj][ispin, :P_Km.shape[0]]
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
IndexError: index 1 is out of bounds for axis 0 with size 1"
Kindly help.

More details
unfold.py", line 712, in spectral_function_from_weight_sets
P_Km = P_Km * band_weight_sets[ii][jj][ispin, :P_Km.shape[0]]
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
IndexError: index 1 is out of bounds for axis 0 with size 1

Hi @khaledb9 thanks for reporting it - please provide more details. Is it a single calculation with projection? Please at least post the full trace back and the json and PROCAR if possible.
It looks like either the json file or the PROCAR have incorrect information.

@khaledb9 Can you please check if the updated code works for you now? Thanks

Hi
Sorry for the delayed response. The issue is solved and it was related to the handling of spin. Thanks !

Hello
The issue has been solved. However, only when using the --combined option to plot projections yields the error below:
line 336, in _plot_spectral_function_rgba
fig = axes[0].figure
AttributeError: 'numpy.ndarray' object has no attribute 'figure'

Hi @khaledb9, sorry for the delay in looking at this, our lead developer has recently started a new position so has been quite busy!
I've looked and found the issue that was causing this, and has now been fixed in e4e16514b25bbbde3b5a68bd02d0d142b3bf1cc9 and so if you update the code it should all work!
You can do this with:
git clone https://github.com/SMTG-Bham/easyunfold
cd easyunfold
pip install -e .

or if you've already cloned the repo before, can just go to the repo folder and do git pull && pip install -e ..
This will also be included in the next release of easyunfold on PyPI which should be quite soon!
Please let us know if this doesn't fix your issue! :smiley:

Hi @khaledb9! Just to mention, this fix has been included in the latest release of easyunfold (v0.3.2), and so can be installed with pip install --upgrade easyunfold


Generate test jobs at ci.adoptopenjdk.net with new naming scheme

Test jobs have been auto-generated at other projects/Jenkins servers (see https://github.com/AdoptOpenJDK/openjdk-tests/issues/890).  We will do similar at AdoptOpenJDK (taking on a new naming convention, to make more consistent across projects and make tooling like TRSS easier to write.
We want to create more types of nightly and weekly test jobs (as part of the AQA v1.0 deliverables in time for the July release).
This will need to be co-ordinated with a change in the build pipelines, which currently rely on the test job names to trigger launching.
In this issue, we will need to do the following:

generate the jobs

verify they run

change build pipelines to trigger newly generated jobs

delete old test jobs

Jobs generated:

special.functional for openj9,hotspot jdk8
sanity.perf, extended.perf for openj9,hotspot  jdk8,jdk11 x86-64_linux

Regenerated the above jobs without _Nightly suffix.

Once https://github.com/AdoptOpenJDK/openjdk-build/pull/1125 is merged, I will manually rename the top level external test job names to match with the new naming convention. For example, openjdk11_hs_externaltest_x86-64_linux will be renamed to Test_openjdk11_hs_sanity.external_x86-64_linux.
External test jobs cannot be auto-gened as they are the top-level test jobs and have special configuration.

External test jobs are renamed and top-level jobs configure are updated.
https://ci.adoptopenjdk.net/view/Test_external/

Deleted the jobs that were generated with the unneeded suffixes.  I believe this can be closed now.


Broken link to wikipedia page about uniform distribution

This link shows as broken in my jupyter notebook (version 5.7.0):
[uniform distribution](https://en.wikipedia.org/wiki/Uniform_distribution_(continuous%29)
However, the link displays fine in the online notebook viewer http://nbviewer.jupyter.org/.
Proposed fixed link:
[uniform distribution](https://en.wikipedia.org/wiki/Uniform_distribution_(continuous))
It also shows up broken when typed here:
original:
[uniform distribution](https://en.wikipedia.org/wiki/Uniform_distribution_(continuous))
fixed:
uniform distribution
Occurrences:
"A [uniform distribution](https://en.wikipedia.org/wiki/Uniform_distribution_(continuous%29) has the equal probability of picking any number from a set of numbers. We'll be picking from a continuous distribution, so the chance of picking the same number is low. We'll use NumPy's `np.random.uniform` function to pick random numbers from a uniform distribution.\n",

https://github.com/udacity/deep-learning-v2-pytorch/blob/139e8b9b5a88142108dd47c4e4d39c20816074e1/weight-initialization/weight_initialization_exercise.ipynb#L283
"A [uniform distribution](https://en.wikipedia.org/wiki/Uniform_distribution_(continuous%29) has the equal probability of picking any number from a set of numbers. We'll be picking from a continuous distribution, so the chance of picking the same number is low. We'll use NumPy's `np.random.uniform` function to pick random numbers from a uniform distribution.\n",

https://github.com/udacity/deep-learning-v2-pytorch/blob/139e8b9b5a88142108dd47c4e4d39c20816074e1/weight-initialization/weight_initialization_solution.ipynb#L313

Hello! Thank you for catching this, the link is now fixed and pointed to the general page on uniform distributions.


[BUG] Vulnerability through dependency in the SDK v3.4.0

In the dependency tree of azure-cosmos:3.4.0 is commons-beanutils:commons-beanutils:jar:1.9.2 (through commons-validator:commons-validator:jar:1.6).
commons-beanutils in version 1.9.2 has the following vulnerability:
https://nvd.nist.gov/vuln/detail/CVE-2019-10086
Could you update the dependency-tree such that the vulnerability is not part of it anymore?

Want to ping @joshfree on this in addition for Java vulnerability.

@kushagraThapar please check if its in common POM, if so transfer to the right owner.
Otherwise cosmos team needs to address it.

@f-paulus We are using latest version of commons-validator - which is 1.6.
Cosmosdb SDK doesn't use commons-beanutils.
We can work on excluding the dependency from our side, meanwhile we will suggest that you should exclude it on your end.

@kushagraThapar Thanks for excluding beanutils from commons-validator, I think it's the correct way to go here. Meanwhile, we can handle it on our side.

This has been fixed on all versions of SDK, closing it now.


Read-Only filesystem error on master, data and client nodes when setting any config value

If I set config: in values.yaml to anything other than {} then the nodes all fail to start, because it appears it is trying to write elasticsearch.yml to a read-only part of the filesystem.
OpenDistro for Elasticsearch Security Demo Installer
 ** Warning: Do not use on production or public reachable systems **
Basedir: /usr/share/elasticsearch
Elasticsearch install type: rpm/deb on CentOS Linux release 7.7.1908 (Core)
Elasticsearch config dir: /usr/share/elasticsearch/config
Elasticsearch config file: /usr/share/elasticsearch/config/elasticsearch.yml
Elasticsearch bin dir: /usr/share/elasticsearch/bin
Elasticsearch plugins dir: /usr/share/elasticsearch/plugins
Elasticsearch lib dir: /usr/share/elasticsearch/lib
Detected Elasticsearch Version: x-content-7.6.1
Detected Open Distro Security Version: <IP_ADDRESS>

tee: /usr/share/elasticsearch/config/elasticsearch.yml: Read-only file system

Hi @rrichardson  could you help to share your config values?

Hi,
Same error for me.
Reproduce it is easy: you only need to add any value on elasticsearch.config map.
I tried with different configurations, I even explicitly  set the writting mode to 644 but it's not working.
My Kubernetes version is v1.14.10-gke.36 (on GCP)

close the issue. feel free to reopen

The problem is, if following https://github.com/opendistro-for-elasticsearch/opendistro-build/tree/master/helm#notes-about-default-installation to use default open distro security demo configuration, the elastic config section in values.yaml won't work and so far I did not see a work around to address it before running helm install command

The problem is, if following https://github.com/opendistro-for-elasticsearch/opendistro-build/tree/master/helm#notes-about-default-installation to use default open distro security demo configuration, the elastic config section in values.yaml won't work and so far I did not see a work around to address it before running helm install command

I also hit this when trying to set elasticsearch.config.thread_pool.write.queue_size.
I was looking into the workaround by copying to an emptyDir volume should work. I was working to the steps to this. It requires setting up a volume with extraVolumes, mounting it with extraVolumeMounts, copying with extraInitContainers and then once the data is copied to the emptyDir volume we'd need to tell the chart to use that one. But that doesn't seem to be configurable. @weicongs-amazon could we reopen this?

I also hit this when trying to set elasticsearch.config.thread_pool.write.queue_size.
I was looking into the workaround by copying to an emptyDir volume should work. I was working to the steps to this. It requires setting up a volume with extraVolumes, mounting it with extraVolumeMounts, copying with extraInitContainers and then once the data is copied to the emptyDir volume we'd need to tell the chart to use that one. But that doesn't seem to be configurable. @weicongs-amazon could we reopen this?

@weicongs-amazon we are facing this problem as well, would it be possible to reopen this issue?

@weicongs-amazon we are facing this problem as well, would it be possible to reopen this issue?

We end up building customized docker image based on original open distro docker image and during build process we first copy in the customized elasticsearch.yml then run /usr/share/elasticsearch/plugins/opendistro_security/tools/install_demo_configuration.sh -y -i -s
at last. Full docker file as below (we also customized internal_user.yml to change default admin/admin credentials)
"
FROM amazon/opendistro-for-elasticsearch:1.9.0
COPY internal_users.yml /usr/share/elasticsearch/plugins/opendistro_security/securityconfig/
COPY elasticsearch.yml /usr/share/elasticsearch/config/
RUN /usr/share/elasticsearch/plugins/opendistro_security/tools/install_demo_configuration.sh -y -i -s
"

@chhaosh thanks a lot, your comment has been most helpful!
However, I had to omit this line to make it work:
RUN /usr/share/elasticsearch/plugins/opendistro_security/tools/install_demo_configuration.sh -y -i -s


Raise Http{Request,Response}BodyError when Content-Length doesn't match

Instead of InternalError, raise a more specific request or response body size error when the number of bytes written to the outgoing body doesn't match the expectation set by the Content-Length header.
This change does overload the meaning of the http-{request,response}-body-size errors, as they were previously defined as meaning specifically that the body was too large, while this PR uses them to mean that the body length didn't match the expected length.
Addresses https://github.com/WebAssembly/wasi-http/issues/83

We never documented what the option<u64> payload in those error variants means - I guess I expected it to mean the expected content-length (none given, or some set value) rather than the number of bytes provided for the body. I guess either way is OK, I have a slight preference for the expected value rather than the got value, but we need to document what it should mean in the wit.


Question about nms_iou_threshold

Hello! @traveller59 , thank you for your excellent work. I have a question about the nms_iou_threshold in the config file for car detection. In the config file , nms_iou_threshold is set to 0.01, but for pedestrian and other objects, it is larger (such as 0.4).I think it is too small as a nms threshold. Could you tell me why you set this value this small ? Thank you, I really appreciate the help.

because in 3D spaces, 2 vehicles can not be highly overlapped.


Update mouse custom effect to new API

The custom effect for the mouse has changed in the later versions of the SDK and is now using a grid like some of the other devices.
The changes includes an enum change to a format similar to that of the keyboard. We have to update the custom effect of the mouse to this new format.
As this is due for the 3.0 release, the old version of the effect should not be kept in Colore, even though the Chroma SDK keeps a backwards-compatible endpoint for it.
Keeping the old way around creates too much confusion, in my opinion, and the change won't be too drastic on Colore users as the public API will be very similar. Input and discussion is of course welcome.

Sounds good to me!
Sent from my iPhone

On 6 Nov 2015, at 19:32, Adam Hellberg<EMAIL_ADDRESS>wrote:
The custom effect for the mouse has changed in the later versions of the SDK and is now using a grid like some of the other devices.
The changes includes an enum change to a format similar to that of the keyboard. We have to update the custom effect of the mouse to this new format.
As this is due for the 3.0 release, the old version of the effect should not be kept in Colore, even though the Chroma SDK keeps a backwards-compatible endpoint for it.
Keeping the old way around creates too much confusion, in my opinion, and the change won't be too drastic on Colore users as the public API will be very similar. Input and discussion is of course welcome.
—
Reply to this email directly or view it on GitHub.

Implemented in #116


Snapshot TaskRun results in acceptance tests

Adds the ability to snapshot TaskRun results in acceptance tests and adds it to the current Task acceptance tests.
Ref. https://issues.redhat.com/browse/HACBS-2295

Will investigate and undraft when I figure out why we don't show warnings in a test that tests for warnings

Should be okay now, fixed the test cases with warnings


[BUG] Crashes when opening HEIC image

Problem
This app crashes when I open any HEIC format image downloaded from pap.er (which is a nice wallpaper app on macOS)
Reproduce steps

Install Equinox from app store;
Download a 5K wallpaper from pap.er (technically any wallpaper should be able to reproduce this, as long as it's HEIC image);
Select any type in Equinox, and choose the image file just downloaded, and it will just crash.

Environment
Macbook Pro 16-inch with M1 pro, 32GB memory
macOS Ventura 13.4.1

Hi, thanks for reporting! Could you share a file example?

I was testing it with some heic files before the latest version release, but not sure the format is fully supported.

Oh, i can download it from the site you mintioned, never mind 😁

Will be fixed in 3.0
https://github.com/rlxone/Equinox/pull/53


Error opening app after finished installation

Installed DevDocs-Setup-0.6.3.exe  on windows 10
After completing the installation got the following error when trying to run the app

After closing the error prompt and trying to click ok Finish again to run the app, the setup closes
Uninstalling and installing again gives another error

Weird, it actually works for me.

Worked after a new windows installation. Maybe some appdata/caching windows issue here.


Not sure what they want to do. IPVLAN or MACVLAN

Bug Report
https://github.com/cilium/cilium/pull/14436
this is based on IPVLAN. but from this repo, it's based on MACVLAN. not sure what they want to do.
Type: bug report
What happened
What you expected to happen
How to reproduce it (as minimally and precisely as possible)
Anything else we need to know?
Environment

hybridnet version:
OS (e.g. cat /etc/os-release):
Kernel (e.g. uname -a):
Kubernetes version:
Install tools:
Others:

Sorry I just don't understander your words, what do you mean exactly?

https://github.com/cilium/cilium/pull/14436 is for how to use terway(ipvlan) as first cni plugin and integrate cilium to leverage ebpf progs to support k8s svc and network policy functions.
IMO hybridnet is for different scenarios, by the way where is MACVLAN related info in hybridnet that I did not find.


Option to keep left/right join columns (or add _merge column) to merge() and concat()

Hello!
I just heard from a colleague that they're looking for the analogue of STATA's merge command (http://www.stata.com/help.cgi?merge) which generates a _merge column that includes a code which specifies in an outer join whether the row existed in the right table, the left table or both. I know you can hack your way around this by doing set operations on the join columns / indices or creating new columns, but there could be an argument for having this be included functionality if it could be done simultaneously during the merge or just for sheer convenience.
The use case specified was that after they merged, they were checking over the data to find inconsistencies and rows that should have been merged but somehow didn't.
Let me know if there would be any interest in this, and I could maybe have a first shot at implementing it.

Could I ask the logic of dropping the columns that were merged on? This caught me by surprise today. I hope you don't mind me asking on this closed issue since the merged issue is larger than this specific point.

@kobejohn not sure what you are asking about. can you show an example. I don't see anything being dropped.

Ok my apologies - I misinterpreted both my results and this thread. I'll delete the comment and then get more sleep.

np I think this issue was more about having an indicator where the merged column came FROM


Connect GCP BigQuery Datasource to my.optscale.com

I am new to Hystax Products and optscale and i am trying to connect my gcp account so i followed the documentation:
https://hystax.com/documentation/optscale/e2e_guides/e2e_gcp.html
And I got the error below
/restapi/v2/organizations/XXXX-XXXX-XXXX-XXXX/cloud_accounts: Cloud connection error: Invalid billing type. Expected billing type to be Standard.
The Bigquery Dataset is configured a long time ago, so is there something i missed here or it's just a temporary bug ?

Make sure you're targeting the Standard Billing Export on BigQuery not the Detailed Billing Export.

Yes it is the standard one.

Can you let us know what is the name of the table with billing export data?

Dataset: billing_export
Table name: gcp_billing_export_resource_v1_XXXXXXXXXX

Dataset: billing_export Table name: gcp_billing_export_resource_v1_XXXXXXXXXX

It is not standard billing data. Check my screenshot

Below without "resource" is the Standard
The one with "resource" is the Detailed

okay i'll redo the billing export and retry the connection, Thanks !


[Improvement]: Provide a way to override or set more native image options to build the Graalvm native image

Description
Currently when we use bal build --native or bal test --native, we have no way to set or override Graalvm native image options. Need a way to provide both the hosted and runtime options.
E.g. I should be able to pass the options -O0 --verbose --gc=epsilon -H:MaxDuplicationFactor=20.0 -R:-LIROptimization to the native image build. These should override the options which have been already set.
One possible way I can think for this is providing a CLI option which takes a filename which contains these native image options.
bal build --native --native-image-options=native-image.properties
or
bal test --native --native-image-options=native-image.properties
And the native-image.properties file would contain the following.
-O0
--verbose
--gc=epsilon
-H:MaxDuplicationFactor=20.0
-R:-LIROptimization

or
-O0 --verbose --gc=epsilon -H:MaxDuplicationFactor=20.0 -R:-LIROptimization

Describe your problem(s)
No response
Describe your solution(s)
No response
Related area
-> Other Area
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

As a workaround, we can do this:

Create a file named native-image.properties and add the addtional options as NativeImageArgs = <additional-arguments>
For example if you want to increase the memory and enable verbose option, add the following:NativeImageArgs = -J-Xmx14G --verbose

Before running the bal build --native command export the following to the terminal:export NATIVE_IMAGE_CONFIG_FILE=<absolute-path-of-native-image-properties>

Then run bal build --native


Bugfix/home page typo

git push origin bugfix/home-page-typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: purnajagarlamudi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Merged

Mergeing


inventory: Add dockerhost-osuosl-ubuntu2204-aarch64-1 to inventory.yml

[x] commit message has one of the standard prefixes
[ ] faq.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[x] VPC/QPC not applicable for this PR
[x] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref https://github.com/adoptium/infrastructure/issues/2991

Added to nagios : https://nagios.adoptopenjdk.net/nagios/cgi-bin/extinfo.cgi?type=1&host=dockerhost-osuosl-ubuntu2204-aarch64-1

And Wazuh (Linky..)


[CGD2D] [WocCatalog] Double text display in Text Display page

Expected (on develop):

On CGD2D:

This is know, and it is due to shadows now being supported. All of the APIs responsible fro this say "shadows ignored", but lo and behold, they are not ignored. This is operating as expected for the reference platform ca. 6.0-7.0.

Originally in #1830.


Use checked division kernel

Which issue does this PR close?

Closes #6791
Rationale for this change

The current behaviour is inconsistent, can lead to nulls in non-nullable columns, and is pretty surprising.
A future iteration of the upstream arithmetic kernels is also likely to make this the only option - https://github.com/apache/arrow-rs/issues/2647#issuecomment-1612146560
What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

cc @viirya

Hmm, it is inconsistent. We should fix it. But we will prefer default behavior is to get null instead of query error. That is story of Spark but I agree DataFusion doesn't necessarily to follow it at all.

... nulls in non-nullable columns, and is pretty surprising.

Is it an issue? In Spark, Divide expression output is nullable always. I think producing null from non-nullable input columns is totally fine if it follows the expression's output type definition.
So the issue is more about inconsistency.
Looks okay to me.


last code support iPhone 6/6+ ?

#162

I run cydia on my iphone 6+ once, after I can not restart it


feat: implement .values and .items for SharedMemoryDict

Fixes #15

Great @cassiobotaro thank you!
Could you please update the changelog with this change? (you can follow this pattern)

@drgarcia1986 done!


Make uninitialized non-nullable var a warning

If someone does something like this:
/** @type {number} */
var foo;

They now need to ensure their non-nullable type is defined. Does it make sense to force an initialization in this case?

I seem to see this pattern a lot:
class Example {
constructor() {
/** @type {number} /
this.foo;
}
init(/* number */ x) {
this.foo = x;
}
}
For whatever reason, you don't know what foo should be, at the moment when the object is instantiated, but once init is called, it never gets set back to undefined. It would be somewhat frustrating to have to write {number|undefined} for this.
But, all that is for properties not variables. For variables this probably does make sense.

Yeah, we can't warn about that. It's our only way of declaring properties/variables without initializing them. Java is the same way. Maybe we can be better about warning for use-uninitialized-variable, rather than warning on the definition.

Is there anything to do here?

Yes, I agree we should warn for use of variables that are, or might be, uninitialized, when undefined is not part of the type.


Environment names for complex types

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this feature/change is needed
[x] After submitting this, I commit to one of:

Look through open issues and helped at least one other person
Hit the "watch" button on this repo to receive notifications and I commit to help at least 2 people that ask questions in the future
Implement a Pull Request for a confirmed bug

Feature Request
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.7.3
            pydantic compiled: True
                 install path: /tmp/pydantic-compex-env-names/env/lib/python3.9/site-packages/pydantic
               python version: 3.9.1 (default, Dec 13 2020, 11:55:53)  [GCC 10.2.0]
                     platform: Linux-5.10.7-3-MANJARO-x86_64-with-glibc2.32
     optional deps. installed: []

from typing import Dict
from pydantic import BaseModel, BaseSettings, Field

class Backend(BaseModel):
    type: str = None
    dsn: str = None

class Settings(BaseSettings):
    backends: Dict[str, Backend] = Field(default_factory=dict)

In order to manage these settings via envvars, nested components could be separated with __, like this:
BACKENDS__DEFAULT__TYPE=postgresql
BACKENDS__DEFAULT__DSN=postgresql://localhost/db

In order to remove default backend, following envvar could be set:
BACKENDS__DEFAULT=

Or list of dict keys could be given like this:
BACKENDS=default,sqlite

This would remove all backends, except default and sqlite.
I found similar issue about adding custom value parsers, so this could be used for lists and also for overriding keys.

The issues https://github.com/samuelcolvin/pydantic/issues/2232#issuecomment-753553408 and https://github.com/samuelcolvin/pydantic/issues/1929#issuecomment-707617155 also touch on this.
Since there are solutions for this I would say this isn't a required feature, but if this is interesting to more people I would be open to having a go at a pull request to support this "pydantic natively".

@daviskirk We certainly would be interested in this feature as well!

+1 I also like the idea of using __ to set nested Settings values.
I think the JSON approach is too verbose and counter-intuitive (even if it is more powerful).

Parsing envs for nested field improved in pydantic-settings
FYI, pydantic-settings now is a separate package and is in alpha state. you can install it by pip install pydantic-settings --pre and test it.
Here is your example in pydantic-settings:
from typing import Dict, Optional

from pydantic import BaseModel, Field
from pydantic_settings import BaseSettings

class Backend(BaseModel):
    type: Optional[str] = None
    dsn: Optional[str] = None

class Settings(BaseSettings):
    backends: Dict[str, Backend] = Field(default_factory=dict)


Sortable does not allow sending additional data vai store set method

Custom
I want to send additional data along with data-id to the server.
To me, it looks like I can only send the data-id attribute using sortable.toArray().
Is there a better way I can send additional data than mine janky way which is like this:
put all the additional data to the data-id attribute
data-id="key1=value1key2=value2"
and then on the server I split and extract them

JSON.stringify and JSON.parse might be your friends, but surely there are better solutions to managing state than in the data-id attribute.
This is more of a question, so I'll to close this.


Fix Wrangler Argument

I had to change --compatibility-flag to --compatibility-flags for it to work.
It is also with a s in the documentation: https://developers.cloudflare.com/workers/platform/nodejs-compatibility/

Thanks a lot for taking the time to open the PR @SirCremefresh 😃
However I am not sure I get it, I've been using --compatibility-flag for quite a while and it has always worked, if you run wrangler pages dev -h you can also see that both --compatibility-flags and --compatibility-flag should work:

Maybe this is a bug in wrangler? could double check and eventually you provide some more details? (like your command, node version, wrangler version, etc...)

You are right it now works as well, i did not change the version. I don't know why I got the error.
I can't reproduce it. I will close this issue.
my error:

Hi @dario-piotrowicz
I don't think so when I copy paste the command that gave the error and run it again it works.
I also now checked the wrangler release log and didn't see anything related.
I can't think of anything to to further investigate the error.
command as plain text: npx wrangler pages dev .vercel/output/static --compatibility-flag=nodejs_compat


add details for evaluation

change along with https://github.com/drucker/drucker/pull/11
return detailed evaluation result in evaluate method

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yuki.matoba seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Almost LGTM
But this PR need to merge after merging drucker/drucker#11. And you need to update requirements.txt to load drucker-v0.4.x for the update.


Improve coverage

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.1%) to 93.671%

Totals

Change from base Build<PHONE_NUMBER>6:
4.1%

Covered Lines:
518

Relevant Lines:
553

💛  - Coveralls


Parameter files needed for test systems

Both test systems should have the parameter files included

Parameter files have been included into the test code


Implement connection draining

Implement automatic connection draining on ECS hosts, via Auto Scaling Group lifecycle events.
https://aws.amazon.com/blogs/compute/how-to-automate-container-instance-draining-in-amazon-ecs/
Pull requests welcome, otherwise I will try and look at implementing this over the coming weeks.

How would you want this? Custom lifecycle hook -> SNS -> Step Function? Or is it easier than that?

This should be addressed by PR #59


Add PII to the root README

PII transform is now added to the table in the root README file.

Thanks Shahorkh. This was bound to happen :-)


After selecting photos from gallery, null is returned.

After click "Done", it directly goes to error part and error shows null.
This is options object:
IMAGEPICKEROPTIONS: any = {
quality: 45,
width: 1280,
height: 1280,
maximumImagesCount: 15,
disable_popover: true
}

same here too  . My ionic version 5 and device poco x2 android 10 OS

same here too . My ionic version 5 and device poco x2 android 10 OS
My error : After selecting image its showing like this "ErrorThe image file could not be opened"

The same error here: Android 10, Samsung A10.
After select images, it return "The image file could not be opened"

same here too . My ionic version 5 and device poco x2 android 10 OS
My error : After selecting image its showing like this "ErrorThe image file could not be opened"

The same error here: Android 10, Samsung A10.
After select images, it return "The image file could not be opened"

Same issue for me in android 10 and above

Same issue for me in android 10 and above

Same issue here

Same issue here with Android 10 and Samsung

I was able get it to work by adding this to the android platform section of config.xml:
    <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application" xmlns:android="http://schemas.android.com/apk/res/android">
        <application android:requestLegacyExternalStorage="true" />
    </edit-config>

Have the same issue on Android, however some images are appended, but some don't. Can't track exactly what it is about the images. Filename, location and file format seem to be the same for "good" and "bad" images.  Google Play also issued the statement -
We've detected that your app contains the requestLegacyExternalStorage flag in the manifest file of 1 or more of your app bundles or APKs.

Developers with apps on devices running Android 11+ must use Scoped Storage to give users better access control over their device storage. To release your app on Android 11 or newer after May 5th, you must either:

Update your app to use more privacy friendly best practices, such as the Storage Access Framework or Media Store API
Update your app to declare the All files access (MANAGE_EXTERNAL_STORAGE) permission in the manifest file, and complete the All files access permission declaration in Play Console from May 5th
Remove the All files access permission from your app entirely
For apps targeting Android 11, the requestLegacyExternalStorage flag will be ignored. You must use the All files access permission to retain broad access.

Apps requesting access to the All files access permission without a permitted use will be removed from Google Play, and you won't be able to publish updates.

I have another problem, Android filename has '%20' instead of ' ' (blank space) which prevents me from saving the image. I need to manually fileName.replace('%20', ' ') to have the ability to copy the file.


Bump up changes GHA to detect submodule changes

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

CI seems to be blocked somehow.

Does new version have a different configuration? Java file change is detected somehow.

The changes workflow needs to be approved for a specific commit by the asf admin. Otherwise it cannot run. 🥹


webhook/conformance: Handle incompatible HTTP Filters on a rule

Re: The last two bullets in this section of GEP-1364: https://gateway-api.sigs.k8s.io/geps/gep-1364/#accepted
* A HTTPRoute with one rule that specifies a HTTPRequestRedirect filter and a HTTPURLRewrite filter. Accepted must be false,
  because there's only one rule, and this configuration for the rule is invalid (see [reference](https://gateway
  api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRequestRedirectFilter)) The error condition in this
  case is undefined currently - we should define it, thanks @sunjayBhatia.

* A HTTPRoute with two rules, one valid and one which specifies a HTTPRequestRedirect filter _and a HTTPURLRewrite filter.
  Accepted is true, because the valid rule can produce some config in the data plane. We'll need to raise the more specific error
  condition for an incompatible filter combination as well to make the partial validity clear.

For incompatible filters in an HTTPRoute, seems like we can do somethings similar to this change that validates HTTP header filters: https://github.com/kubernetes-sigs/gateway-api/pull/1497
We could do this instead of/in addition to the status changes described in the GEP

Thanks @sunjayBhatia! I think we already do that with https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1beta1/validation/httproute.go#L127, so maybe we just need a spec update similar to https://github.com/kubernetes-sigs/gateway-api/pull/1497#discussion_r1013488225.

oh nice, missed that! i guess only changes needed are these two locations need an update about the Accepted and possible new condition:

https://gateway-api.sigs.k8s.io/api-types/httproute/#filters-optional
https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.HTTPRouteRule (filters field)

Any chance you can bang out a quick PR to implement that update for us @sunjayBhatia?
I've put this in v0.7.0 so we don't miss it, but if we get the PR done quick, this could make v0.6.0.

yep I can try to get this change done soon

/assign

opened https://github.com/kubernetes-sigs/gateway-api/pull/1540 to address this

/remove-lifecycle stale


add weigths to nodalbalance constraints to provide correct prices as duals

For Nodes with state we multiply the injection with the corresponding weight in the nodal balance constraint.
We don't do this for nodes without state. So if our objective is in EUR, the power values of our carriers are e.g. in MW and our weight ω is in h then the duals of our nodal balance constraints will be in EUR/(MW * ω * h) instead of EUR/MWh.
This change multiplies all injection values in all nodal balance constraints with ω, so our duals will always have the unit EUR/MWh.
I'm not entirely sure if this has some unexpected implications, so I'm leaving this as a PR to review.

I suppose this is something that we need to prominently feature in the docs, because it may be easy to "misunderstand" for users not familiar with optimization: There are a lot other duals/... whose interpretation may change with snapshot duration, choice of unit, etc. But that's another story.
No matter any unwanted implications, the interpretation of nodal_balance should be the same for stateful and non-stateful Nodes, so this is an important fix!

The commit diff view on mobile is not the best, but from what I've seen this looks good! So, if tests are fine I'd say we can merge this as is, and figure out later where this could also happen (note: the old yaml based result extraction did manually account for that).

Oh, good to know, I was not aware, that the result extraction accounted for this.
I do not need this change urgently. So it's fine for me keep this open until you can comfortably review this on a big screen.


add support for cbo.zero in CMO extensions

Currently, the cache block size is assumed to be two times of xlen.

@pawks this look fine to me. Can you also check once and approve the PR ?

Looks good to me.

The zformat encoding does not have an imm_val field. The operation performed in the macro is right, but it should be based on rs1_val and not imm_val. The fix is just to replace imm_val with rs1_val and everything will work similarly. For completeness, the filed rs1_val_data should also be defined in the template.yaml for the instruction even if it is not being used (just so that a change in the cgf does not break CTG).

similarly

The reason I select imm_val instead of rs1_val is that rs1 is the whole address of cbo.zero, it doesn't have offset field to adjust the address to signature address. So rs1_val is relative stable, and what can be changed is only the offset in the cache block size (currently this is two time of xlen)

I have one question: is there anly way to make the signature data length for one instruction variable? The cache block size may be variable. I only found the stride field will affect the length. However it will break CTG if we want to change this.

The reason I select imm_val instead of rs1_val is that rs1 is the whole address of cbo.zero, it doesn't have offset field to adjust the address to signature address. So rs1_val is relative stable, and what can be changed is only the offset in the cache block size (currently this is two time of xlen)

Having it has imm_val will be confusing and architecturally incorrect for the zformat instructions. Its okay to use a relative value in rs1 i.e some post processing after the values are generated before the instruction uses it. It is always good to use only architecturally relevant fields in the source side as the same format may be applicable for multiple instructions. How the values are interpreted are controlled by the domain of each of the variables and the assembly macro itself.

The reason I select imm_val instead of rs1_val is that rs1 is the whole address of cbo.zero, it doesn't have offset field to adjust the address to signature address. So rs1_val is relative stable, and what can be changed is only the offset in the cache block size (currently this is two time of xlen)

Having it has imm_val will be confusing and architecturally incorrect for the zformat instructions. Its okay to use a relative value in rs1 i.e some post processing after the values are generated before the instruction uses it. It is always good to use only architecturally relevant fields in the source side as the same format may be applicable for multiple instructions. How the values are interpreted are controlled by the domain of each of the variables and the assembly macro itself.

OK, I'll try to modify it.

I think the PR is ready to be merged.

I don't think performing the cbo.zero at some location and then loading the value from there to store it back into the signature region is really an efficient testing strategy. I think a parameter is needed in the yaml to configure the model, but a dynamic configuration of the test is not necessary. The value in rs1 is treated as the effective address which identifies a cache block. Hence the test should ideally test if non-zero bits in the LSB do identify the cache block correctly i.e the block index is the value over which coverpoints should be defined. To do so, we can assume a reasonably high cache block size(say 64 bytes) and write tests accordingly. The test will work without problems for any block size under 64 bytes.

@pawks Hi, Pawks. I don't quite understand  how test work for any block size under 64 bytes.
I can add blocksz field to every instruction in template.yaml, generate test cases for cbo.zero with different offset under 64  and directly zero the signature data with that size for test case.
However, in this way, every size under 64 will generate different signature data for this generated test.
Do I misunderstand anything?

I don't think a dynamic test is necessary, and yes, a different
signature will be generated if a model is configured for different
cacheblock sizes.
This kind of issue is why the riscof framework was developed;  it will run
the tests with a reference model configured for whatever blocksize you want
and compare it a vendor implementation.
Dynamically configuring the test will make the test run faster,  (e.g. it
could avoid testing offset between 32..63 if the blocksize is 32f

but if you didn't do that, the tests will still work, just be redundant.

On Tue, Jan 11, 2022 at 8:53 PM liweiwei90 @.***> wrote:

I don't think performing the cbo.zero at some location and then loading
the value from there to store it back into the signature region is really
an efficient testing strategy. I think a parameter is needed in the yaml to
configure the model, but a dynamic configuration of the test is not
necessary. The value in rs1 is treated as the effective address which
identifies a cache block. Hence the test should ideally test if non-zero
bits in the LSB do identify the cache block correctly i.e the block index
is the value over which coverpoints should be defined. To do so, we can
assume a reasonably high cache block size(say 64 bytes) and write tests
accordingly. The test will work without problems for any block size under
64 bytes.
@pawks https://github.com/pawks Hi, Pawks. I don't quite understand how
test work for any block size under 64 bytes.
I can add blocksz field to every instruction in template.yaml, generate
test cases for cbo.zero with different offset under 64 and directly zero
the signature data with that size for test case.
However, in this way, every size under 64 will generate different
signature data for this generated test.
Do I misunderstand anything?
—
Reply to this email directly, view it on GitHub
https://github.com/riscv-software-src/riscv-ctg/pull/22#issuecomment-1010633901,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJVYREJ22MMC22NGJDDUVUCNJANCNFSM5KKFIH2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

if the blocksize is 32f

OK. I am not familiar with riscof currently. I'll study how it transfer blocksize to riscv-ctg later.

I don't find the question that triggers the test/build error. It works successfully in my local test.

These tests have been merged into riscv-arch-test.  When I tried using them, I had to modify the RV_TEST_ISA and check ISA strings for cbo.zero in the rv32i_m/CMO and rv64i_m/CMO directories for riscof to accept them.  I submitted a riscv-arch-test PR419 reflecting these changes, but it would be good to also fix the .cgf in this PR.
-RVTEST_ISA("RV32IZicbozZicsr")
+RVTEST_ISA("RV32IZicsr_Zicboz")
-RVTEST_CASE(0,"//check ISA:=regex(.*I.*Zicboz.Zicsr.);def TEST_CASE_1=True;",cbozero)
+RVTEST_CASE(0,"//check ISA:=regex(.*32.*I.*Zicsr.Zicboz.);def TEST_CASE_1=True;",cbozero)

@liweiwei90 this PR is too old to be merged, it has many conflicts and versioning issues. Also it needs minor revisions too. Can you please add the changes proposed by @davidharrishmc, resolve the conflicts, and setup the correct version please?
As you do these things, I will merge this one into master.


Varenius/more coordinates

Forgot rustfmt. Also want to add equatorial-->ecliptic ( to go from galactic --> equatorial --> ecliptic for VLSR calculation).


Refactor ByteAmount checking args method

This PR related #1612 and #1613 is trying to use Preconditions.checkArgument to check arguments in ByteAmount
The key changes are following:

use Preconditions.checkArgument method
modify the condition expression

cc @billonahill

@billonahill - I've addressed all comments

👍

👍


dyld: lazy symbol binding failed: Symbol not found: _SecRandomCopyBytes

Describe the bug
Ran into this in the Next.js repo after this PR was merged. Was able to replicate the behavior of their build system in a dumbed down script. They seem to individually compile each file concurrently.
Input code
// build.js
const { transform } = require("@swc/core");

const AMOUNT_OF_FILES = 20;
const AMOUNT_OF_LINES = 1000;

for (let i = 0; i < AMOUNT_OF_FILES; i++) {
  transform(`console.log('hello');\n`.repeat(AMOUNT_OF_LINES));
}

then run
node ./build.js

This sometimes just gets aborted with a
dyld: lazy symbol binding failed: Symbol not found: _SecRandomCopyBytes
  Referenced from<EMAIL_ADDRESS>  Expected in: flat namespace

dyld: Symbol not found: _SecRandomCopyBytes
  Referenced from<EMAIL_ADDRESS>  Expected in: flat namespace

zsh: abort      node build.js

It's not deterministic and increasing AMOUNT_OF_FILES and AMOUNT_OF_LINES increases the chance of this happening. The lower these values are, the higher the chance of successfully finishing the script. Sometimes the errors get printed mixed into each other. Using transformSync works without a problem.
Expected behavior
No errors
Version
The version of @swc/core: 1.2.65
Additional context
This happens on Apple M1, macOS Big Sur 11.4.
I've seen it happen on node.js 14, 15 and 16

I was aware of this issue, and seems like a bug related to cross-compilation from intel mac to m1 mac.


sideNav with fixed navbar not exact showing up

just trying http://materializecss.com/navbar.html#navbar-fixed
some menu in mobile device not show ...

See #813


Unable to play Vimeo with sound and fullscreen in iOS

Current Behavior
The vimeo thumbnail appears but does not play the video.
Expected Behavior
Start play the video in fullscreen with sound.
Steps to Reproduce
This setting does not work in iOS:
videoOptions.vimeo = { autoplay: true, playsinline: false }
Works but no sound and inline player:
videoOptions.vimeo = { autoplay: true, background: true, playsinline: true }
Environment

iOS 13.3.1
Safari

I cannot play fullscreen on Firefox 76.0.1 for any video.
I cannot load mp4 on Safari.

See https://github.com/CookPete/react-player#mobile-considerations
iOS and other browsers are slowly killing autoplay – most now require user interaction (ie a click or tap directly on the page or video) to play the video with sound.
iOS has always been very limited in how much control you have over how video plays. This is not likely to change any time soon.


fix: upgrade to version 3.1.41

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
2f8dea9394fed2e653ce3122bc2bee70a91223f9
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest


On-premise ipmi "cloud provider"

How would you envision using powerfulseal for a bare metal on premise kubernetes environment? All of the servers have IPMI access for remote power. Would it be a new cloud driver, or would it be an addition to #17 along with some ssh magic? I might be able to work on some of it with an idea of how this should be implemented with the idea of getting it back upstream.

Hi @SEJeff, thanks for creating the issue 👍
I see #17 as a separate concern, and I'd probably lean towards making it a separate "cloud" driver. That said I've never played with IPMI before - so it sounds like fun to have a go.
In my mind it fits neatly as a driver - it should have its respective config, and implement the driver interface. For the listing/getting capacity, I'm not sure if IPMI supports listing machines, or whether it would need to have some kind of local inventory.

There isn't quite a 1:1 mapping here, which is why I asked.
ipmi is a point to point protocol allowing  power control of a single server off/on just like pulling the power cord or setting bios settings (such as next boot to internal drive or pxe). I believe this is what start() and stop() are for given a cursory read and not being familar with openstack.
What would you expect delete() to do on a bare metal cluster? Raise NotImplementedError?
Would it make sense to just list the remote_servers in the configuration? As part of this, I'd :heart: to see powerfulseal work with minikube / tectonic sandbox for testing. Bonus points that it would make sense to use this for developing powerfulseal itself. If you didn't want the hosts in the config and used some other external inventory, how would you see that working?
How exactly would the NodeInventory stuff work conceptually with a bare metal server?

Some good ideas here.

What would you expect delete() to do on a bare metal cluster? Raise NotImplementedError?

Yup, that sounds reasonable.

Would it make sense to just list the remote_servers in the configuration? (...) If you didn't want the hosts in the config and used some other external inventory, how would you see that working?
How exactly would the NodeInventory stuff work conceptually with a bare metal server?

By local inventory I meant essentially a config in a form of an .ini file, listing the machines to operate on, and the NodeInventory with this local driver would just need to work around missing things like availability zones info etc.

As part of this, I'd ❤ to see powerfulseal work with minikube / tectonic sandbox for testing

Working out of the box with minikube would definitely be awesome, let's look into that.

Hi @SEJeff just checking in to see how things have progressed so far for you guys ?

Closing due to inactivity. Feel free to reopen if you'd like to move forward with this.