io.AddKeyEvent() does nothing

Hi Everyone,
I looked at this all yesterday and can't figure it out. Either I'm just missing something or there is a bug in our implementation of ImGui 1.89+.
My original attempt to convert vsgImGui to ImGui 1.89 used io.AddKeyEvent() to submit the key to the ImGui queue. It all made sense from the documents, built OK and ran, but no keystrokes appeared in the ImGui controls.
@kannode added io.AddInputCharacter() to the KeyPressEvent to submit ASCII characters to a separate character stream queue in the same KeyPressEvent. The ImGui controls now receive the characters and show them as expected, however characters outside the ASCII range don't appear. We could just expand the range that goes to io.AddInputCharacter(), but I don't think it is the correct way to do it. Everything I have read and looking through the other backends, io.AddKeyEvent() should be the way to go.
Also, if you comment out the two io.AddKeyEvent() lines, then there is no change to the function of the program because it is only getting keyboard input from AddInputCharacter(). But, all the other backends that I've checked and documents use AddKeyEvent().
I've stepped through the code in a debugger and still can't figure out. Most other backends also use SetKeyEventNativeData(), but the documents indicate that it shouldn't be necessary.
Does anyone have any insight to this? @kannode, did you uncover more information about AddkeyEvent() while creating your PR?
Regards,
Roland

I believe I saw AddInputCharacter in the glfw imgui integration.
On Mon, Jan 16, 2023 at 8:03 PM Roland Hill @.***>
wrote:

Hi Everyone,
I looked at this all yesterday and can't figure it out. Either I'm just
missing something or there is a bug in our implementation of ImGui 1.89+.
My original attempt to convert vsgImGui to ImGui 1.89 used
io.AddKeyEvent() to submit the key to the ImGui queue. It all made sense
from the documents, built OK and ran, but no keystrokes appeared in the
ImGui controls.
@kannode https://github.com/kannode added io.AddInputCharacter() to the
KeyPressEvent to submit ASCII characters to a separate character stream
queue in the same KeyPressEvent. The ImGui controls now receive the
characters and show them as expected, however characters outside the ASCII
range don't appear. We could just expand the range that goes to
io.AddInputCharacter(), but I don't think it is the correct way to do it.
Everything I have read and looking through the other backends,
io.AddKeyEvent() should be the way to go.
Also, if you comment out the two io.AddKeyEvent() lines, then there is no
change to the function of the program because it is only getting keyboard
input from AddInputCharacter(). But, all the other backends that I've
checked and documents use AddKeyEvent().
I've stepped through the code in a debugger and still can't figure out.
Most other backends also use SetKeyEventNativeData(), but the documents
indicate that it shouldn't be necessary.
Does anyone have any insight to this? @kannode
https://github.com/kannode, did you uncover more information about
AddkeyEvent() while creating your PR?
Regards,
Roland
—
Reply to this email directly, view it on GitHub
https://github.com/vsg-dev/vsgImGui/issues/39, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHWFHIP4ARD3QHNT2GZOIZ3WSXVU7ANCNFSM6AAAAAAT5I6HOM
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
S https://www.nodein.com/uresh K. Kannan, Ph.D.,
Chief Scientist, Nodein
https://www.nodein.com

I initially expected that we did not have to use AddInputCharacter as you do.
However, I stepped through the debugger with just the imgui_glfw implementation (no VSG), and for every keystroke, the ImGui_ImplGlfw_CharCallback was also being called in addition to the keypress and keyrelease glfw callbacks in.
https://github.com/ocornut/imgui/blob/master/backends/imgui_impl_glfw.cpp
At that point, I added the AddInputCharacter(). Yes, I restricted the code to just ASCII with no solid logic behind it, as I have only used ASCII.

Is this issue now resolved?


Drag and drop of sparse multiple selected cells does not work

Testing #119118

spend quite some time to use shift+arrow up/down to select 3 code cells
drag and drop to a different location
I would expect that all 3 code cells will now be adjacent

https://user-images.githubusercontent.com/5047891/112161483-7ca9a480-8beb-11eb-8d37-6d5ef2fcae28.mp4

It's kind of current limitation. We support dnd on a single selection (which can contain more than one cell) but it doesn't work with multiple distinct selections.

Seems to work now, I'm pretty sure I fixed it this year


Fix debounce final event handling

When debounce ends, if there is a pending event, it is now emitted before ending the stream.  This commit also improves the reliability of several time-based tests, including debounce tests.

:+1:


feat: add ast 1.1.2 release

update ast with release 1.1.2

:tada: This issue has been resolved in version 1.332.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix typos in life cycle scripts

I hope you're accepting PRs, but I found two outdated comments in the lifecycle script. Other than that super helpful, thx 👏 :)

Of course I do @SaskiaKeil , thank you very much :grin:


Uptime

Description
Synthetics tracks the availability of services and applications by running user-specified 'Test-Suites', and then displaying related information on Opensearch Dashboards. This service is especially useful when used for problem detection in said user programs before it would have a large impact on end customers.
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Paul Sebastian<EMAIL_ADDRESS>

Codecov Report

Merging #445 (890e438) into uptime (ae15eb0) will increase coverage by 14.66%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             uptime     #445       +/-   ##
=============================================
+ Coverage     60.24%   74.91%   +14.66%
  Complexity      269      269
=============================================
  Files           197       37      -160
  Lines          6588     2029     -4559
  Branches       1287      231     -1056
=============================================
- Hits           3969     1520     -2449
+ Misses         2425      347     -2078
+ Partials        194      162       -32

Flag
Coverage Δ

dashboards-observability
?

opensearch-observability
74.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...rds-observability/common/constants/autocomplete.ts

...hboards-observability/common/constants/explorer.ts

...shboards-observability/common/utils/query_utils.ts

...ic/components/common/search/autocomplete_logic.tsx

...rvability/public/components/explorer/data_grid.tsx

...ervability/public/components/explorer/explorer.tsx

.../notebooks/components/helpers/modal_containers.tsx

...public/components/explorer/docTable/docViewRow.tsx

...alytics/components/common/plots/throughput_plt.tsx

...blic/components/explorer/hooks/use_fetch_events.ts

... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae15eb0...890e438. Read the comment docs.

PR has moved to https://github.com/opensearch-project/observability/pull/478


Remove the support for register the runner outside the module

Due to backwards compatibly the module still supports the scenario to register a runner manual and pass the token. To reduce the complexity and number of scenarios this option will be removed.

A major version bump that throws out a bunch of deprecated stuff would be great

fully agree, feel free to create a PR

@npalm As we always have to store the token somewhere: Which option should be removed (you are referring in your first post)?

We're currently having issues with the parameter store after upgrading from 6.3.1 to 6.5.2.
This only happens when we run a terraform plan with a read-only role. A terraform deploy works fine.
Logs say:
│ Error: reading SSM Parameter (ci-common-large-x86-0-sentry-dsn): InvalidKeyId: arn:aws:kms:us-east-1:205810638802:key/b1bd2030-d46d-41b7-89ef-3ed07a9181fb is pending deletion. (Service: AWSKMS; Status Code: 400; Error Code: KMSInvalidStateException; Request ID: 81ba4e7e-f4b0-4f76-b1c3-9f6df3eac93f; Proxy: null)
│
│   with module.runners["common-large-x86-0"].aws_ssm_parameter.runner_sentry_dsn,
│   on .terraform/modules/runners/main.tf line 27, in resource "aws_ssm_parameter" "runner_sentry_dsn":
│   27: resource "aws_ssm_parameter" "runner_sentry_dsn" {

When inspecting the parameter store I see this:

I will try removing all parameters and letting the module recreate them to see what happens.

We're currently having issues with the parameter store after upgrading from 6.3.1 to 6.5.2.
This only happens when we run a terraform plan with a read-only role. A terraform deploy works fine.
Logs say:
│ Error: reading SSM Parameter (ci-common-large-0-sentry-dsn): AccessDeniedException: User: arn:aws:sts::205810638802:assumed-role/dev/gitlab-20741933-1014135500-5149570679 is not authorized to perform: kms:Decrypt on resource: arn:aws:kms:us-east-1:205810638802:key/a4f312cd-f0bf-4701-9cbe-d044996161ec because no identity-based policy allows the kms:Decrypt action (Service: AWSKMS; Status Code: 400; Error Code: AccessDeniedException; Request ID: 0a802a13-e844-4f89-9d8f-9c31880dff35; Proxy: null)
│ 	status code: 400, request id: 7de4acec-8047-4ef5-a14d-d042971c1375

Keys went to a pending deletion state after making enable_kms = false, but ssm parameters kept pointing to them:
│ Error: reading SSM Parameter (ci-common-large-x86-0-sentry-dsn): InvalidKeyId: arn:aws:kms:us-east-1:205810638802:key/b1bd2030-d46d-41b7-89ef-3ed07a9181fb is pending deletion. (Service: AWSKMS; Status Code: 400; Error Code: KMSInvalidStateException; Request ID: 81ba4e7e-f4b0-4f76-b1c3-9f6df3eac93f; Proxy: null)
│
│   with module.runners["common-large-x86-0"].aws_ssm_parameter.runner_sentry_dsn,
│   on .terraform/modules/runners/main.tf line 27, in resource "aws_ssm_parameter" "runner_sentry_dsn":
│   27: resource "aws_ssm_parameter" "runner_sentry_dsn" {

When inspecting the parameter store I see this:

I will try removing all parameters and letting the module recreate them to see what happens.

Manually removing all parameters and running a deploy with enable_kms = false recreated them with alias/aws/ssm. At this point running a terraform test with the read-only role worked fine.
If we try to set enable_kms = true again, terraform states that it will change the kms key for all parameter stores to the custom key again.
I would rather use aws managed keys for this, does enable_kms = true mean that things are not being encrypted or that things are being encrypted using aws managed keys?

This seems to be a valid point, yes. Could you please create a separate issue for this, @dsalaza4 ?

Planned for the v8 release end of 2024

Will close this now as this is the official strategy from GitLab to handle Runners. Register them manually and go with it.


Add license FAQ to the website

I've postponed migrating from openapi-typescript-codegen a few times. Now that I have time to do it, I noticed the license change and decided to postpone it again. Was the license changed in a hurry? https://github.com/hey-api/openapi-ts/pull/1006
Looking forward to the FAQ on the license change


allow users to readily switch between 'collection' and 'curation'

Need clarification from Andy.

same as #3


Docs issue on NPM page for package import statements?

The docs on this NPM package page:
https://www.npmjs.com/package/v2-stability-client
Show this:
import { generate } from 'stability-client'
import { generateAsync } from 'stability-client'

I had to change them to 'v2-stability-client':
import { generate } from 'v2-stability-client'
import { generateAsync } from 'v2-stability-client'

I have nothing to do with that package

I have nothing to do with that package

Sorry.  The name of your package is very close to the one I am using.  I'll repost over there.

stability-client is the published package from this repo

stability-client is the published package from this repo

Ok, I'll use this one.  Too bad NPM doesn't control what GitHub repos a package is allowed to link to.


Calver search and replace failing

The workflow seems to have trouble with 2 month digits versus 1:
Run<EMAIL_ADDRESS>  with:
    include: meta.yaml
    find: pangeo-dask =.*
    replace: pangeo-dask =2023.1.4

pangeo-dask                 2023.1.4      hd8ed1ab_0  conda-forge
pangeo-dask               2023.01.11      hd8ed1ab_0  conda-forge
pangeo-dask               2023.01.13      hd8ed1ab_0  conda-forge

the 2023.1.4 was from this PR cc @yuvipanda
https://github.com/conda-forge/pangeo-dask-feedstock/pull/104/files

Options are 1. patch the gha-find-replace action and release a new version (see also #8), or maybe simplifying to just get the most recent version string with a simple command:

mamba repoquery search pangeo-dask --json | jq '.result.pkgs[0].version'

"2023.01.13"


Fix broken link to Twitter in newsletter

It looks like the site was migrated at some point from Hugo to Astro, and this link got left behind.
I haven't tested this, as I don't know how to build the site, but I copied the example from src/layouts/BlogPostLayout.astro.

Hey @mtlynch, thanks so much for noticing and taking the time to make a PR!
The fix didn't quite do it. I checked the Netlify deploy preview, and the link looked like this:

So something went wrong with the interpolation. But I pushed a new commit and added a Mastodon link while I was at it.
And this is a total tangent, but I recognized your name from your blog posts! Particularly the ones on bootstrapping TinyPilot. Thank you for writing about your experience. It's very inspiring.


MGMT-18261: Add shell autocompletion script generator command

Adds flightctl completion command that writes an autocompletion script for the specified shell to stdout. This will autocomplete nouns declared in cobra.Command.ValidArgs and flags bound in o.Bind.

It looks great. I tested it and it works well. I just had one minor comment.

Turns out that range dict will return (key, value), so declaring the index and incrementing it explicitly is the only way to convert a dict to a slice AFAIK


Cannot find module 'read-package-json-fast' when using v1.0.37

Describe the bug
When using the<EMAIL_ADDRESS>(and 1.0.36 as well) I get the following error in GitHub Actions:
Error: Cannot find module 'read-package-json-fast'
Require stack:

<EMAIL_ADDRESS>/home/runner/work/_actions/asyncapi/github-action-for-generator/v1.0.37/dist/index.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
at Function.Module._load (internal/modules/cjs/loader.js:690:27)
at Module.require (internal/modules/cjs/loader.js:852:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object. (/home/runner/work/_actions/asyncapi/github-action-for-generator/v1.0.37/node_modules/@npmcli/run-script/lib/run-script.js:1:13)
at Module._compile (internal/modules/cjs/loader.js:959:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
at Module.load (internal/modules/cjs/loader.js:815:32)
at Function.Module._load (internal/modules/cjs/loader.js:727:14)
at Module.require (internal/modules/cjs/loader.js:852:19)

How to Reproduce
use the github-action with v1.0.37 like this

name: Generating HTML from AsyncAPI document
uses<EMAIL_ADDRESS>with:
template: '<EMAIL_ADDRESS>filepath: src/main/resources/asyncapi.yml
parameters: baseHref=/customer-context-asyncapi-generated-html/
output: asyncapi/customer-context-asyncapi-generated-html
Expected behavior
no error

hmmm, the problem was there already right? with 1.0.35? and it was fixed 🤔

no, I think we had problems with other packages before, but not with 'read-package-json-fast'

there was problem with several packages, including this one https://github.com/asyncapi/github-action-for-generator/issues/111#issuecomment-888420811 🤔

Hi @derberg, what about a fix for this issue?

@pioneer2k can you check this out before we merge, like last time?

@derberg  you mean this way?
asyncapi/github-action-for-generator@fbf42ecb7a3873b9d653a7f22377128c3a4d51fb
With that one I get the next error:
Error: Cannot find module 'json-parse-even-better-errors'

@pioneer2k can you try with 67b0dbaacd6f19f435b3f0fb1c6d5a48791aa0bc please 🙏🏼

@derberg 67b0dbaacd6f19f435b3f0fb1c6d5a48791aa0bc seems to work!

@derberg will there be a new release with this fix? Currently this seems not to be the case.

@pioneer2k working on it since yesterday, windows broke my heart on CI level and then other stuff..... will let ya know here once release is out 🤞🏼

@derberg today I tried the new release 1.0.47 - but it already fails in the very beginning of our pipeline (stage "Set up job"). Can you please have a look?
Download action repository<EMAIL_ADDRESS>(SHA:75e31e518d88f65692acb93d24f8c2ee613e04aa)
Error: Could not find file '/home/runner/work/_actions/_temp_d93ea6f1-264d-43c2-b756-c80601f6e04d/_staging/asyncapi-github-action-for-generator-75e31e5/node_modules/.bin/semantic-release'.

@pioneer2k omg, this GitHub action is killing me 😄 I guess I need to plan to start dockerizing it as GitHub Actions support now fetching image instead of code.
Could you try to remove this file on your fork and test this action from your fork. I have no idea why this is happening, as semantic-release is not in node_modules as it is needed only for the release process, so maybe it is failing because of the entry in the .bin folder 🤷🏼

@derberg do you think that could help to test with my own fork? I mean, testing with your last commit has worked, but not with the release.

@pioneer2k I remember I did some additional commits between your feedback and merge because of failing release pipeline

@derberg with this commit from my fork it seems to work. No errors in my pipeline.
Download action repository 'pioneer2k/github-action-for-generator@019f61d7b0e558e305b9ec26e01e654ad5250784' (SHA:019f61d7b0e558e305b9ec26e01e654ad5250784)

@pioneer2k awesome, can you open a PR then?

@derberg  there it is
https://github.com/asyncapi/github-action-for-generator/pull/158


compact: Update filtered blocks list before second downsample pass

Fixes #7488
If the second downsampling pass is given the same filteredMetas list as the first pass, it will create duplicates of blocks created in the first pass.
It will also not be able to do further downsampling e.g 5m->1h using blocks created in the first pass, as it will not be aware of them.
The metadata was already being synced before the second pass, but not updated into the filteredMetas list.

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Re-uses the same block filtering logic from the first pass, to regenerate the list of filtered blocks from freshly synced metadata before the second pass.
I haven't made any changes regarding the metrics logic that takes place after the first filtering:
https://github.com/thanos-io/thanos/blob/57b42d1bf4c1f891538ee3a66604947ff8d0cc53/cmd/thanos/compact.go#L465-L469
as I'm not sure what exactly this is doing. So there may be some downsamples that happen in the second pass that aren't counted in the metrics, if that's what it's doing. Let's keep that separate to this fix.
Verification

Tested against a bucket that was creating duplicate downsampled blocks on v0.35.1.
Verified in compactor logs that no duplicate block is created on the second pass: https://github.com/thanos-io/thanos/issues/7488#issuecomment-2194840665

For this failure on the compactor tests:
https://github.com/thanos-io/thanos/actions/runs/9699030328/job/26793642104?pr=7492#step:5:2050
It is reaching a value of 18 blocks cleaned, and the test is looking for 19.
It was changed in the test from 18 to 19 here https://github.com/thanos-io/thanos/commit/2ed48f79384a67549036a49072a769dad20f714a one day after the change that introduced the filter code which ends up duplicating a block https://github.com/thanos-io/thanos/commit/68bef3fce0812b01e7970fd1d90c36dbb42f562b.
The reasoning at the time was that the hardcoded test value might have been taken from a run of the CI that didn't report the full number in the metric, but looking at it now this +1 has to be from a block being cleaned up that was a duplicate from the downsampling.

@yeya24 I made some further changes to fix the e2e compaction tests, please could you take another look when you have the time?


Add label support

Closes #34
Closes #50
Labeling support has been added intentionally into UpdatePage, so that labels can also be reset/removed easily. Tested successfully with Confluence server 7.4.1.

Thank you for your contribution!

Thank you for your contribution!


New package: Petri v0.1.0

Registering package: Petri
Repository: https://github.com/mehalter/Petri.jl
Created by: @mehalter
Version: v0.1.0
Commit: b6a3ae899f6b66e79a864aed0f5cafad7c8eaaf6
Reviewed by: @mehalter
Reference: https://github.com/mehalter/Petri.jl/commit/b6a3ae899f6b66e79a864aed0f5cafad7c8eaaf6#commitcomment-34849576

@StefanKarpinski could I please request a day early merge to the General repository? This is holding back a pull request to a separate project.


README.md: Del and Backspace in Normal/Visual mode

Actually Del/Backspace seems not to work in Normal/Visual mode.
Moreover, Backspace in Vim doesn't remove chars but just move backward.

thx a lot, I've update the readme


Pega8 support

Please add support for native pega8.x version
(remove sma, upgrade tomcat to version 8.5 or higher)

@dcasavant what is the status of this project given other internal initiatives around docker/tomcat/pega?

Pega Infinity support is coming very soon.  The Docker images will first be available via the standard software distribution kit and then reflected on GitHub a short time later.

Support is being reviewed as part of #19

Merged


Remove code for annotating HTML spec definitions overtaken by upstream…

… changes
not to be merged until https://github.com/whatwg/html/pull/6757 is, and before I can verify the resulting definitions aren't changed

we should be good to go after whatwg/html#6776 gets merged

in fact all the changes here are also in #646, so closing this


biber 2.17 biber-darwin_x86_64.tar.gz is missing

Is there a reason why the file biber-darwin_x86_64.tar.gz is missing on biber version 2.17 on sourceforge?
Not available:
https://sourceforge.net/projects/biblatex-biber/files/biblatex-biber/2.17/binaries/MacOS/
Available in previous version:
https://sourceforge.net/projects/biblatex-biber/files/biblatex-biber/2.16/binaries/OSX_Intel/
Available in next version:
https://sourceforge.net/projects/biblatex-biber/files/biblatex-biber/2.18/binaries/MacOS/
Is it possible to upload it?
Is somewhere documented whats the difference between universal and this file?
Thanks a bunch!

Should be there now.

That was fast, thank you @plk :)


fix: hide axisZ when axis disabled

Only display axisZ when axis enabled. Add Z to axis channels so that it can be toggled with axis option.
chart
    .point3D()
    .data({
      type: "fetch",
      value: "data/cars2.csv",
    })
    .encode("x", "Horsepower")
    .encode("y", "Miles_per_Gallon")
    .encode("z", "Weight_in_lbs")
    .encode("size", "Origin")
    .encode("color", "Cylinders")
    .encode("shape", "cube")
    .coordinate({ type: "cartesian3D" })
    .scale("x", { nice: true })
    .scale("y", { nice: true })
    .scale("z", { nice: true })
    .axis(false)
    .legend(false);

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 86.407%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
10372

Relevant Lines:
11627

💛  - Coveralls


check squash commits by regexp

Right now we have no way to determine squash commits in the diff, and we are requesting pull requests from engine only on merge commits.

Changing default squash commit message is possible in GitLab, and github's default squash commits have a pretty recognizable pattern, so it seems convenient to check for squash commits in this way

Github also supports changing the default message, so it seems enough to match squash merges with regexp.


Async thunk example?

Hi Rudy, and thanks for great work with Haxe and Redux! :-)
Being a Redux newbie, I'm trying to understand how to deal with async loading etc. I can let an middleware function return a promise (as in https://github.com/elsassph/haxe-react-redux/blob/b9974b4f324963c4ffb30d16d1f183c97769b83c/src/example/todo/model/TodoList.hx#L113), but I haven't been able to figure out how to deal with async methods using Thunk.
Do you have a simple async example to share?
Best! / Jonas

Hi!
You can have thunk returning a Promise:
class TodoThunk {
    public static function load() {
        return Thunk.Action(function(dispatch:Dispatch, getState:Void->AppState) {
            return new Promise(function(resolve, reject) {
                var http = new Http('data/data.json');
                http.onData = function(data) {
                    var entries = Json.parse(data);
                    dispatch(TodoAction.SetEntries(entries));
                    resolve(true);
                }
                http.onError = function(error) {
                    dispatch(TodoAction.SetEntries([]));
                    // From the example, but you should do something more meaningful here
                    resolve(true);
                }
                http.request();
            });
        });
    }

    // ...
}

And then use it in your components:
typedef Props = {
    var load:Void -> Promise<Bool>;
}

@:noPublicProps
@:connect
class LoadButton extends ReactComponentOfProps<Props> {
    static function mapDispatchToProps(dispatch:Dispatch) {
        return {
            load: function() return dispatch(TodoThunk.load())
        };
    }

    override public function render() {
        return jsx('
            <button onClick=${load}>Load tasks</button>
        ');
    }

    function load(_) {
        props.load().then(function(_) {
            trace('Tasks loaded');
        });
    }
}

Thanks, Rudy!
Makes it a lot easier than messing with separate middlewares for all async stuff.


Add package tmate

@vcunat thanks, I fixed the pull request. With your comment, I finally understood how nixpkgs could have a different process with cmake even though cmake is not referenced in setup.sh :-). Thanks for that.

Please rename commit's name following our guide in CONTRIBUTING.md

@jagajaga I changed the commit's comment. I didn't find any best-practice guide on naming branches. What do you mean by "rename commit's name"?

He meant the commit message, I'm certain, which you fixed. What do you mean by "naming branches"?

@vcunat the branch is named new-tmate and I was wondering if there was a standard naming scheme (e.g., new/<package>)

Branch name doesn't matter :)
On 8 September 2015 15:36:20 Damien Cassou<EMAIL_ADDRESS>wrote:

@vcunat the branch is named new-tmate and I was wondering if there was a
standard naming scheme (e.g., new/<package>)

Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/9673#issuecomment-138546974


Wrong url to terminate a subscription

Hi,
It seems a bug when here: Subscription.ENDPOINT + this.id + '/terminate'
because the result looks like https://api.recurly.com/v2/subscriptionsXXXXXX/terminate
I think it's should be like Subscription.ENDPOINT + '/' + this.id + '/terminate

This is no longer an issue in the latest release.


Add support for Hardware Design Worksheets and Integration with CheckDates program

Increment version to 2.2.1 and tag pre-release with 2.2.1-beta
Added a new type of assignment: ws (worksheet)
Added integration with a new program: CheckDates
CheckDates finds the first submission for the assignment and adds it to the log file.
CheckDates is not required for cs251tk to run. Currently CheckDates is only in the Hardware Design Specs repository.
Works on the Windows Linux Subsystem - needs to be tested on macOS and Linux.

Initially, I like it.

Coverage decreased (-0.02%) to 65.648% when pulling 612ef595d4cad32f23520b5cc3a3109757fe21c8 on maxnz:master into aade6ea83162d3339b2ff42ecba23b7d63a316c9 on StoDevX:master.

Those asserts are really picky. Should be fixed now.

very assertive?

Would you be open to moving the cs241-specs repo to StoDevX or another org?

Definitely. I can do that now. The only thing I ask is that I get write permissions on that one because I'm currently creating the HD specs as we make and assign the homeworks.

@maxnz Absolutely

I have to give PyCharm some credit: the ctrl-click feature helped me follow all the function calls to make sense of the code. It also has spell-check included.

I think that's it unless if you can think of anything.

There we go. Added a little more to the "CheckDates not installed" message to direct users to the README if they are interested.


feat: Add test for load benchamrk.

Add code for load benchmark test.
So far azure load testing preview is preferred for the benchmark test.
I will run the test in my own environment before converting it to completed PR.

@AsakusaRinne

@AsakusaRinne why close?


humidex calculation

getHumidex() returns 58 given temperature 35 C and humidity %95 but the reference table tells 59.

23 C x 40% humidity = 24 humidex on our interactive, but = 23 humidex on climate data https://www.canada.ca/en/environment-climate-change/services/seasonal-weather-hazards/warm-season-weather-hazards.html#toc7

here is the calculation from ECCC: https://climate.weather.gc.ca/glossary_e.html


Full screen visualization hindered by "Unsupported Engine version..." message

Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
The Unsupported Engine version or in fact any kind of notification that pops up (like connectivity issues) is blocking the view of the graph and of full screen visualization.
Maybe worse is that it can't be moved or mitigated in any way, sometimes hindering the view of data.
Expected behaviour
Semi-transparent notification would be sufficient.
How we can reproduce it?
Start a locally built engine.
Screenshots or screencasts

Enso Version
develop
Browser or standalone distribution
Chrome
Browser Version or standalone distribution
110.0.5481.100
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response

Currently, we hide Graph Editor component when visualization is going full-screen. Seemingly, we need to hide more things.

The new dashboard button is also displayed over full-screen visualization (reported in #6839). Let's fix it in this task as well.


Rolling documentation does not specify window alignment

What is your issue?
It would be very helpful if the documentation for all rolling functions specified that when center=False the rolling windows are right aligned.
Currently the only way to figure this out is to assume that the interface copies the pandas interface.

Happy to take a PR for this!


cannot read property 'options' of undefined use

i got this error when running db_pull "cannot read property 'options' of undefined use".
Any one could tell me what's wrong or what's causing this ?
I am running it on windows without the replace url thing.

my bad miss placed the  grunt.loadNpmTasks('grunt-deployments');


Suggestion Use Zerotier

Hi
for your Secure private networking section may i suggest using zerotier. I have used this for many projects where the provider was missing privatenetworking

WireGuard has been rock solid since the beginning and I don't see any reason to switch. How do they compare regarding security, performance and setup?

Hi
I will cite some things regarding your questions
regarding security https://github.com/zerotier/ZeroTierOne/issues/811
zerotier is p2p and has a ui for access control this can also be managed via API (oppertunity for ansible to auth the node while provisioning)
installation is very simple, more info can be found here: https://www.zerotier.com/download.shtml
I usually add the zerotier interface to the trusted zone in firewalld and whitelist the zerotier private range
as far as performance goes im using it as a backplane network for cephfs. I am media streaming off the cephfs store via kubernetes in a different geographic location
everything runs smooth i have not noticed performance issues with zt but neither have i tested indepth, but for this scope it seems like an ideal fit

ZeroTier is indeed easier to set up than WireGuard, also, it makes it easy to access the nodes w/o configuring WireGuard on your machine (e.g. on a Mac). All in all, it's just easier for building your own "intranet" with ZeroTier than with wg, and its peer-to-peer nature is a good thing in some situations. That being said, I did try to do Ceph (via rook) over zt ~1.5 years ago and the performance was rather suboptimal. But that was quite some time ago and there's possibility that these problems are gone, so maybe it's worth trying again.

Why would you access your cluster via the same private network used between nodes? Just get ZeroTier for this, and only this, if you think it offers a benefit.
WireGuard is performing far too well in every regard to even consider replacing it. It will most likely be integrated into the Linux Kernel any time soon. Configuration is simple and straightforward. I have a hard time understanding why you would prefer ZeroTier over WireGuard. Performance is crucial, I‘ve yet to see some benchmarks of ZeroTier. Feel free to submit iperf results, preferably using Hetzner Cloud‘s smallest VPS, so I‘ve got a direct comparison.


Add torchserve support

As far as i understand, it is not possible to easly port this model to torchserve.
Is not possible to export it in torchscript because some parts of the code, and is not possible to export it with a simple class file for the heavily nested structure.
This complicates a lot deployng the model in a production envirnoment.
Im not a torchserve expert, am I missing something? Do you have suggestions or possible solutions?

In the end, we decided to develop it in-house.
We got it to work via TorchServe in eager mode, both on CPU and GPU.
In our opinion, our work could be really helpful, allowing the stable use of LaMa in a production scenario.
After a bit of cleanup, we are considering releasing our code, so let me know if you could be interested in linking it from the main page.

Hello! This would be interesting, are you using with GPU?  Is it much faster than CPU?

Hi! Such a great contribution definitely would be a welcome! Please share if you find it OK for your company and situation.

@EgonFerri  Nice work, can you share it?

Hey @EgonFerri, would be great if you could share how you got it to work with TorchServe!


Running tests individually in behat3

Hi,
With behat2, we could run individual features with:
bin/behat --profile=api AdminAccessControl.feature
bin/behat --profile=api AdminAccessControl.feature:12

however, I cannot find a way of doing same in behat3. I tried:
bin/behat --suite=api AdminAccessControl.feature
No scenarios
No steps
0m0.03s (13.78Mb)

  [Behat\Testwork\Tester\Exception\WrongPathsException]
  No specifications found at path(s) `AdminAccessControl.feature`.

behat [-s|--suite="..."] [-f|--format="..."] [-o|--out="..."] [--format-settings="..."] [--init] [--lang="..."] [--name="..."] [--tags="..."] [--role="..."] [--story-syntax] [-d|--definitions="..."] [--append-snippets] [--no-snippets] [--strict] [--rerun] [--stop-on-failure] [--dry-run] [paths]

The only thing works is: bin/behat --suite=api but it runs all tests.
behat.yml
default:
    extensions:
        Behat\Symfony2Extension: ~
        Behat\MinkExtension:
            base_url: http://webservice.local/app_test.php/
            sessions:
                symfony2:
                    symfony2: ~
    suites:
        api:
            type: symfony_bundle
            bundle: ApplicationApiBundle
            mink_session: symfony2
            contexts:
                - Application\ApiBundle\Features\Context\FeatureContext:
                    baseUrl: http://webservice.local/app_test.php/

Folder structure
src/Application/ApiBundle/Features/AdminAccessControl.feature
src/Application/ApiBundle/Features/Context/FeatureContext.php

Thanks

Can you try bin/behat --suite=api src/Application/ApiBundle/Features/AdminAccessControl.feature ?
I don't remember how the path name look like when using the symfony_bundle type, as I don't use it myself.

Thanks, that worked and also the one below works as well.
bin/behat --suite=api @ApplicationApiBundle/AdminAccessControl.feature
bin/behat --suite=api @ApplicationApiBundle/AdminAccessControl.feature:12

ah yeah, this was how I provided it in Behat 3.

Do you know how formatter works in 3? The code below work in version 2 but not in 3. I think there is a lack of documentation in particular to 3 in general.
#behat.yml
default:
    formatter:
        name: pretty
        parameters:
            output_styles:
                comment: [ magenta ]

Formatter is pretty simple. Mine written for behat 3 is e.g.:
formatters:
    pretty:
      verbose: true
      paths: false
      snippets: true
      multiline: true
      output_styles:
        passed: [ green, null ]
        passed_param: [ green, null, [ bold ] ]
        skipped: [ blue, null ]
        skipped_param: [ blue, null ]
        failed: [ white, red ]
        failed_param: [ white, red, [ bold, underscore ] ]
        comment: [ black, null ]
        undefined: [ yellow, null ]
        tag: [ black, null ]
    html:
      output_path: %paths.base%/build/html/behat


License / Patent ?

I’m not very well versed on this but I’ve just been informed about some of the H264 patents, and that distributing any H264 encoder could result in needing to pay royalties. Can you shed some light on how this relates to this library?
Thanks.
p.s. I meant to open this issue in your h264 project, apologies.

AFAIK patents applied to H264 usage in industrial scale, no matter which encoder used. But "royalties won't be charged for H.264 encoded Internet video that is free to end users".
https://en.wikipedia.org/wiki/Advanced_Video_Coding#Licensing
I'm not specialist, may be x264 devs know more.

For what it's worth, and IANAL, the Wikipedia page does go on to mention that the royalty-free clause applies only to internet video itself that is distributed freely, and that royalties still might be payable for by products that encode/decode content:

On August 26, 2010, MPEG LA announced that royalties won't be charged for H.264 encoded Internet video that is free to end users.[74] All other royalties remain in place, such as royalties for products that decode and encode H.264 video as well as to operators of free television and subscription channels.[75] The license terms are updated in 5-year blocks.[76]


Updates for spacedock.info

Updates for mods uploaded to spacedock.info

Thanks

You have a problem.  The netkan for SpacetuxSA is correct, but when testing the BetterScienceLabsContinued, it continues to try to download the copy from kerbalstuff

I seem unable to figure out what the conflicts are so I'm going to say what I've seen people say in these situations and ordinate a Rebase of the PR

The problem is that it's trying to download spacetuxsa from kerbalstuff.  I have the updated kerbalstuffsa in this commit, so maybe it's one of those strange situations.  Should I redo this, uploading kerbalstufsa first and then the others?

No the problem at hand right now is that we cannot merge this due to unresolved conflicts, aka something in this PR doesn't sit well with something else we've changed inbetween the creation of your PR and the current state of the repository. You need to rebase.

Rebase mean do it all again?

@Olympic1 solved this in #3206 :)
Rebase is basically you typing a command in the terminal which makes master/origin/whatever-you-call it match the current upstream and then merge your made changes into it, while prompting you to fix the conflicts which might have arosen.

Ok, thank you @Olympic1 for taking care of this for me


AGX Orin Devkit: Update to L4T 35.4.1

Change-type: patch
Tested with: https://github.com/balena-os/balena-jetson-orin/pull/300
For BalenOS v4.1.5 or newer on AGX Orin Devkit

@balena-ci I self-certify!


Add download to generation step

Solves #17

Where is the list of currently supported artifacts defined?
Step 4  Edit pack/ac.yaml and add the artifacts you want to collect.

What currently is missing is the artifacts from https://github.com/forensicanalysis/artifacts/. Those need to go into pack/artifacts/. Anyway those are supplied with a different license so I do not want to simply copy those over.

thanks.
I was able to solve it with the following steps.
$ git clone https://github.com/forensicanalysis/artifactcollector
$ git clone https://github.com/forensicanalysis/artifacts/ -b v0.6.1 /tmp/artifacts
$ cp /tmp/artifacts/*.yaml artifactcollector/pack/artifacts/
$ cd artifactcollector && go generate

It looks like your CI is failing, but you need to quote it. Pulled request for fixed branch.


Channel promise of a write is successful, although SSL handshake fails.

Expected behavior
When a SSL handshake fails, a channel promise of a write operation should fail aswell.
Actual behavior
The channel promise succeeds.
Steps to reproduce
$ git clone https://github.com/s-gheldd/netty-reproducer.git
$ cd netty-reproducer
$ mvn test

Minimal yet complete reproducer code (or URL to code)
https://github.com/s-gheldd/netty-reproducer
Netty version
4.1.16.Final
(last version that had the expected behavior 4.1.13.Final)
JVM version (e.g. java -version)
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)

OS version (e.g. uname -a)
Darwin ghelds-MacBook-Pro.local 15.6.0 Darwin Kernel Version 15.6.0: Mon Oct  2 22:20:08 PDT 2017; root:xnu-3248.71.4~1/RELEASE_X86_64 x86_64

See https://github.com/netty/netty/pull/7380


[ADP-3443] Add a UI page to show deposits

This PR adds a deposit UI page to report the history of deposits given a suitable time window. User will select a time window and have a view of all deposits grouped and summed by a time index determined by the chosen window.
ADP-3443

Broken into smaller PRs


Added STX-based Digital Asset Trading and Escrow Contract for secure peer-to-peer exchanges

STX-based Digital Asset Trading and Escrow Contract
This PR introduces an escrow-based digital asset trading contract on Stacks, allowing users to trade assets (e.g., NFTs, STX tokens, or digital goods) securely with a trustless escrow mechanism. The contract ensures the buyer's funds are protected, and the seller only receives the payment once the buyer confirms the receipt of the asset. In case the buyer doesn't confirm, the asset is refunded to the seller.
Features:

Create Trade: Sellers can create a trade by specifying the asset, price, and trade ID.
Start Trade: Buyers can initiate the trade by sending the specified amount of STX tokens to escrow.
Confirm Receipt: Buyers can confirm the receipt of the digital asset, releasing the payment to the seller.
Refund: If the trade isn’t confirmed, the asset and payment are refunded to the seller.
How It Works:

Create Trade: The seller creates a trade by specifying the asset, price, and trade ID.
Start Trade: The buyer sends the specified STX tokens to the escrow contract.
Confirm Receipt: The buyer confirms the receipt of the asset, and the payment is released to the seller.
Refund: If the trade is not confirmed in time, the trade is refunded to the seller.

Use Cases:

Peer-to-peer decentralized marketplace for digital assets.
Secure trading platform for NFTs or other digital tokens.
Trustless transaction environment that prevents fraud.

Next Steps:

Integrate with a front-end marketplace to allow users to interact with the escrow contract via a UI.
Add additional features like asset verification before trade confirmation.

These PRs can't be accepted because the repo doesn't have contribution guidelines. I don't have the resources to maintain additional contracts.
Errors as strings are not recommended.


API service clear account balance subscription keys

From what I can tell, at a first glance of the code, the account balance subscription keys aren't ever cleared. This means over time we would query balances for more and more accounts.
I can't find evidence of this in the logs, however, so I may have missed something, making this a non-issue.

This appears to be an issue:

Thought about this for a bit. Similar to my recent PR we really only need balances for orders that are solvable (open) right now. What we could do then is as part of maintenance every block get the whole set of solvable orders, update these balances, cache the orders and balances until the next maintenance.
This would also make us not query the database every time the solvable_orders endpoint is fetched because we would always have an up to date set of solvable orders and their balances.

One thing to be careful about is that we might miss orders that came after the latest block but before the next one. While, in general, we won't submit settlements for them because they aren't old enough, we might miss out on :cow: opportunities. Just something to keep in mind.

@vkgnosis I believe this is no longer an issue correct?


logging: use the same log4js instance as juttle-service

Use the juttle-service exported getLogger to make sure that the
configuration applied by logSetup actually takes effect.

lgtm.


Using prost-codec causes raft to fail to build

In my Cargo.toml, I originally had
raft = {version = "0.5.0"}
and everything was fine, but then I needed prost because I am using tower-grpc so I changed the dependency to the following:
raft = {version = "0.6.0-alpha", features = ["prost-codec"]}
However, this did not build successfully and this was the error message:
"process didn't exit successfully: ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rls --edition=2018 --crate-name raft_proto ~/.cargo/registry/src/github.com-1ecc6299db9ec823/raft-proto-0.6.0-alpha/src/lib.rs --color never --crate-type lib --emit=dep-info,metadata -C debuginfo=2 --cfg 'feature="bytes"' --cfg 'feature="lazy_static"' --cfg 'feature="prost"' --cfg 'feature="prost-codec"' --cfg 'feature="prost-derive"' --cfg 'feature="protobuf-codec"' -C metadata=3f50be8a0afcb413 -C extra-filename=-3f50be8a0afcb413 --out-dir ~/Dropbox/offscale/libconsensus-raft-rs/target/rls/debug/deps -L dependency=~/Dropbox/offscale/libconsensus-raft-rs/target/rls/debug/deps --extern bytes=~/Dropbox/offscale/libconsensus-raft-rs/target/rls/debug/deps/libbytes-2744a4ff1130f8d4.rmeta --extern lazy_static=~/Dropbox/offscale/libconsensus-raft-rs/target/rls/debug/deps/liblazy_static-bac2cd672577edff.rmeta --extern prost=~/Dropbox/offscale/libconsensus-raft-rs/target/rls/debug/deps/libprost-71804544e9c0ccef.rmeta --extern prost_derive=~/Dropbox/offscale/libconsensus-raft-rs/target/rls/debug/deps/libprost_derive-edaac461d95d607c.so --extern protobuf=~/Dropbox/offscale/libconsensus-raft-rs/target/rls/debug/deps/libprotobuf-1268ad74f9fe7fd7.rmeta --cap-lints allow --error-format=json --sysroot ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu (exit code: 1)"
Any idea why raft is not building successfully anymore? Thank you :)

I think you need to add default-features = false to your raft dep.
Was there any more to the error message? That is just showing how you ran the RLS. You might get a better error message if you run cargo build.


Add Surface (Low Pitch) by Dimrain47

Song Name
Surface (Low Pitch)
Artist Name
Dimrain47
Source
Youtube
Youtube Link
https://youtu.be/T8kjvZUXwm8?si=QU3XOFW4xnyy65ap
Direct File Link
No response
Song ID
63082
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 27122654

comment

accept


Cannot logout

i try to build a simple rest api with your project.
generate token is ok, view users is ok, all is ok but i can't logout.
when i go to /security/token/destroy i have in the return 200 logout succesfully, but if i try to view users, i can with code 200 OK.. so the logout doesn't work, or i don't know how it works
Can you help me ?

A token is valid during it's lifecycle, you set the expiration time on security.yml. I have updated the project so the approach is different.


iOS Crash: [nullthrows]  "Got unexpected undefined" in UIManager.measureInWindow

Description
I am seeing app crash reports on iOS with the error:

Got unexpected undefined

The stacktrace shows that it comes from this line in UIManager.measureInWindow:
https://github.com/facebook/react-native/blob/v0.72.6/packages/react-native/Libraries/ReactNative/UIManager.js#L88
This implies that the method getFabricUIManager() returns undefined.
My app has fabric disabled.
Full stack track:
Error Got unexpected undefined
    Users/runner/work/together/together/packages/dating-app/node_modules/nullthrows/nullthrows.js:7:23 nullthrows
    Users/runner/work/together/together/packages/dating-app/node_modules/react-native/Libraries/ReactNative/UIManager.js:88:40 measureInWindow
    Users/runner/work/together/together/packages/dating-app/node_modules/@ui-kitten/components/devsupport/components/measure/measure.component.js:60:48 measureSelf
    Users/runner/work/together/together/packages/dating-app/node_modules/@ui-kitten/components/devsupport/components/measure/measure.component.js:50:23 onUIManagerMeasure
    (native) apply
    Users/runner/work/together/together/packages/dating-app/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:474:12 __invokeCallback
    Users/runner/work/together/together/packages/dating-app/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:124:27 anonymous
    Users/runner/work/together/together/packages/dating-app/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:368:10 __guard
    Users/runner/work/together/together/packages/dating-app/node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:123:16 invokeCallbackAndReturnFlushedQueue

Interestingly, the main branch looks like it might not be much better. nativeFabricUIManagerProxy seems to be initialized to undefined (see code), however, the code will only define a value for it if it is null. (see code). However, I could be misreading ithis.
React Native Version
0.71.6
Output of npx react-native info
System:
OS: macOS 14.1.1
CPU: (8) arm64 Apple M2
Memory: 194.55 MB / 24.00 GB
Shell:
version: 3.6.1
path: /opt/homebrew/bin/fish
Binaries:
Node:
version: 18.18.2
path: /usr/local/bin/node
Yarn:
version: 3.6.1
path: /usr/local/bin/yarn
npm:
version: 9.8.1
path: /usr/local/bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.13.0
path: /Users/jeremy/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10811636
Xcode:
version: 15.0.1/15A507
path: /usr/bin/xcodebuild
Languages:
Java:
version: 16.0.1
path: /usr/bin/javac
Ruby:
version: 3.2.2
path: /Users/jeremy/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.6
wanted: 0.72.6
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce
I have not been able to reproduce it directly and am just going by the stack traces from the crash reports.
Snack, screenshot, or link to a repository
Unfortunately, I have not been able to create a reproduction directly.

Unfortunately, I have not been able to create a reproduction directly.

Without a repro we can't really help

After further investigation, it looks like the library which calls measureInWindow (UI Kitten) already has a proposed fix (https://github.com/akveo/react-native-ui-kitten/pull/1790) on their end. So I'm closing this issue.


Android app displays list of devices to unauthenticated users

All a user needs is my username to get a list of my devices?
You shouldn't get anything until after you've provided a correct password.

We say when you pick the device name that it's public.  It's written in our public merkle tree in a way that protects user integrity.

Here are my devices BTW: https://keybase.io/max/devices


change monitoring interval from 5s to 1 minute

We believe this monitoring doesn't really give us much, We should have instances for all clientIds that are ONLINE. ONLINE means user is online with uproxy.
But for some weird case that we saw from user log I see that uproxy keeps sending instance_request for some client ids. These are all jabber... user ids.
I believe user is not really online with uproxy, but for some reason social provider gives us ONLINE, We'd like to investigate this, but for now to avoid xmpp throttling us we'll increase the monitoring interval to 1 minute.

Can you add a description to the commit message or pull request explaining why?

:+1:

Do you have an issue filed for incorrectly viewing some users as online (and if so, can you reference that in the PR description; if not, can you create one)?
Othrewise, LGTM


aggregate unwind ValueError

I am trying to run tests using mockmongo around my dao function which is running an aggregate command (below)
collection1.aggregate([
            {
                "$unwind": {
                    "path": "$collection2",
                    "preserveNullAndEmptyArrays": True
                }
            },
            {
                "$lookup": {
                    "from": "collection2",
                    "localField": "collection2",
                    "foreignField": "_id",
                    "as": "collection2"
                }
            },
            {
                "$match": {"_id": id, "deleted": False}
            }
        ])

But the test fails with
'ValueError: $unwind failed: exception: field path references must be prefixed with a '$' '{'path': '$randomcollection', 'preserveNullAndEmptyArrays': True}'
Any help would be greatly appreciated
I am using
mockmongo = 3.8.0
pymongo=3.4.0
mongo=3.4.9

Hi @revanthreddy, sorry for the delay in the response. Mongomock does not handle the parameter of $unwind as an object yet. The error message is not clear: I'll try to fix at least this quickly.


Shahid Beheshti University, and added Essential Directory.

Since the way Shahid Beheshti University emails are addressed ( e.g<EMAIL_ADDRESS>This is the correct way of having it in lib/domains/ir/ac.

@FunnyPhantom I am sorry, I have to close this request without merging as a duplicate to #4419.


Missing Characters

A few characters seem to be missing from the available character pool, notably the TTG versions of Robin and Cyborg

The TTG versions of Robin and Cyborg are not separate characters, they're transformations accessible from the character wheel for LBM Robin and DC Comics Cyborg once you've entered the TTG world on that file. Same for Fern, both sets of Ghostbusters, Red Lantern Supergirl, the Goonies aside from Sloth, the rest of the A-Team, Jacob Kowalski, and Queenie Goldstein


fix: upgrade minimatch from 5.1.0 to 5.1.6

Snyk has created this PR to upgrade minimatch from 5.1.0 to 5.1.6.
See this package in npm:
minimatch
See this project in Snyk:
https://app.snyk.io/org/organich/project/c7f19be0-2419-4a9b-9d86-e1f3e4321c43?utm_source=github&utm_medium=referral&page=upgrade-pr

Thank you for the PR. Please sign the CLA so we can review this.

Closing this since CLA was not accepted


Add GitHub actions

This runs the scala compile via the wake build system.

@richardxia This is an example using the two new github actions. The hashes need to be replaced with tags as soon as the actions are merged.


support for extended inserts

#Hi. I was getting the "file is encrypted or is not a database" because I had the extended inserts in my SQL backup file (values for multiple rows were in one INSERT command). For example:
INSERT INTO `table_name` VALUES (1,'value1'),(2,'values2'),(3,'value3');
So I did this patch, tested it and it worked for me. Please consider for inclusion, I don't know how to submit patches using GIT, sorry:
--- mysql2sqlite        2018-02-07 19:01:00.000000000 +0000
+++ mysql2sqlite_for_extended_insert.awk        2018-03-12 11:41:34.880073736 +0000
@@ -121,6 +121,15 @@
       NR ": WARN Hex number trimmed (length longer than 16 chars)." )
     hexIssue = 0
   }
+
+  # for extended-insert (INSERT command with multiple rows in the same line) - split into rows
+  if ( match ( $0, /^((INSERT|insert)  *(INTO|into)  *.* (VALUES|values)  *\()/, matches ) )
+  {
+#    print "start of INSERT command="matches[1];
+    gsub( /\),\(/, ");\n"matches[1] )  #replace (..),(..) with INSERT.. (..) and and with semicolon
+    gsub( /\)\); *$/, ");" )  #last tuple in the row - get rid of double parenthesis
+  }
+
   print
   next
 }

@PikMaster would you have an original MySQL dump (or at least few lines of these extended insert statements)? The line you've posted seems not syntactically correct.
Also it's quite a dangerous patch - I'll include its POSIX variant, but comment it out by default as it might destroy the values.

Hi, I see where I got it wrong - there should be just one closing round bracket at the end, just before semi-colon. I corrected it in the post above, for future readers.
Here is the example MySQL dump:
--
-- Table structure for table `firmware_profiles_rules`
--

DROP TABLE IF EXISTS `firmware_profiles_rules`;
/*!40101 SET @saved_cs_client     = @@character_set_client */;
/*!40101 SET character_set_client = utf8 */;
CREATE TABLE `firmware_profiles_rules` (
  `fpr_id` int(11) NOT NULL AUTO_INCREMENT,
  `fp_id` int(11) NOT NULL,
  `shortname_rule` varchar(100) COLLATE utf8_bin DEFAULT NULL,
  `name_rule` varchar(100) COLLATE utf8_bin DEFAULT NULL,
  `type_rule` varchar(100) COLLATE utf8_bin DEFAULT NULL,
  `min_version` varchar(30) COLLATE utf8_bin NOT NULL,
  PRIMARY KEY (`fpr_id`),
  UNIQUE KEY `multi_uniq_idx` (`min_version`,`fp_id`,`shortname_rule`,`name_rule`,`type_rule`)
) ENGINE=InnoDB AUTO_INCREMENT=8 DEFAULT CHARSET=utf8 COLLATE=utf8_bin;
/*!40101 SET character_set_client = @saved_cs_client */;

--
-- Dumping data for table `firmware_profiles_rules`
--

LOCK TABLES `firmware_profiles_rules` WRITE;
/*!40000 ALTER TABLE `firmware_profiles_rules` DISABLE KEYS */;
INSERT INTO `firmware_profiles_rules` VALUES (3,0,NULL,NULL,NULL,''),(4,0,NULL,NULL,NULL,''),(5,0,NULL,NULL,NULL,''),(6,0,NULL,NULL,NULL,''),(7,0,NULL,NULL,NULL,''),(2,1,NULL,NULL,'BIOS','1.0.0'),(1,1,'%DRAC%',NULL,NULL,'1.06.07');
/*!40000 ALTER TABLE `firmware_profiles_rules` ENABLE KEYS */;
UNLOCK TABLES;

Also, I don't quite understand what do you mean by "POSIX variant", do you have a separate tree or something for POSIX and non-POSIX compliant systems?
To split these tuples correctly, you would need something like a full blown parser, as that is hard to do via regular expressions alone. Although, inspired by your post, I did some research and found this - https://stackoverflow.com/questions/4231382/regular-expression-pattern-not-matching-anywhere-in-string/4234491
So it seems to be possible, but not worth implementing it that way.
However, I will try to come up with some better function for separating tuples, that will not destroy the data.

Hi @dumblob here is the patch with working parser.
I admit I don't fully understand your series of "gsub" replacements, but I just pulled it into my print tuple routine.
Also, I don't have extended test cases, so I'm not sure if it's breaking.
--- mysql2sqlite        2018-03-13 15:32:25.662104698 +0000
+++ mysql2sqlite_for_extended_insert2.awk       2018-03-13 15:44:43.682329086 +0000
@@ -103,25 +103,81 @@
 # print all INSERT lines
 ( /^ *\(/ && /\) *[,;] *$/ ) || /^(INSERT|insert)/ {
   prev = ""
-  # single quotes are escaped by another single quote
-  gsub( /\\'/, "''" )
-  gsub( /\\'',/, "\\'," )
-  gsub( /\\n/, "\n" )
-  gsub( /\\r/, "\r" )
-  gsub( /\\"/, "\"" )
-  gsub( /\\\\/, "\\" )
-  gsub( /\\\032/, "\032" )  # substitute char
-  # sqlite3 is limited to 16 significant digits of precision
-  while( match( $0, /0x[0-9a-fA-F]{17}/ ) ){
-    hexIssue = 1
-    sub( /0x[0-9a-fA-F]+/, substr( $0, RSTART, RLENGTH-1 ), $0 )
-  }
-  if( hexIssue ){
-    printerr( \
-      NR ": WARN Hex number trimmed (length longer than 16 chars)." )
-    hexIssue = 0
+
+  # for extended-insert (INSERT command with multiple rows in the same line) - split into rows
+  if ( match ( $0, /^((INSERT|insert)  *(INTO|into)  *.* (VALUES|values)  *)(\(.*\));$/, matches ) )
+  {
+    parser_offset = RSTART -1  #offset in the line where the data to be inserted stsarts
+    tuples_to_split = matches[5]   #all multi-rows data in one variable
+    arr_len = split (tuples_to_split, arr, "")  #split the data into array, to analyze character-by-character
+    parser_round_brackets_open=0  #parser flag to track open round brackets, important from grammar point of view, ie. not quoted inside data
+    parser_single_quotes_open=0  #parser flag to track if we are currently in open single quotes
+    parser_next_char_is_escaped=0  #parser flag to track if next character is quoted, so brackets and single quotes can be ignored
+    parser_tuple_start_pos=0  #where does the currently analyzed tuple start
+    parser_tuple_end_pos=0  #where does the currently analyzed tuple ends
+    for (i=1; i<arr_len; i++)
+    {  #for every character in the rest of the line
+      c = arr[i];  #single character to be parsed
+
+      if (0==parser_next_char_is_escaped)
+      {  #character is not escaped, see if it has special meaning
+        if ("(" == c) {  #opening bracket
+          if (0==parser_single_quotes_open)
+          {  #if not inside quotes, it matters
+            if (0==parser_round_brackets_open) parser_tuple_start_pos=i;  #we see new tuple opening
+            parser_round_brackets_open++;
+          }
+        }
+        else if (")" == c) {  #closing bracket
+          if (0==parser_single_quotes_open) {  #not inside quote, then it matters
+            parser_round_brackets_open--;
+            if (0==parser_round_brackets_open) {  #if all nested brackets closed...
+              parser_tuple_end_pos=i;  #this is the end of tuple
+                # take the tuple as string
+              tuple = substr (tuples_to_split, parser_offset + parser_tuple_start_pos, parser_tuple_end_pos - parser_tuple_start_pos+1);
+              # print "tuple="tuple
+              # print "start of INSERT command="matches[1];
+
+
+              # single quotes are escaped by another single quote
+              gsub( /\\'/, "''", tuple )
+              gsub( /\\'',/, "\\',", tuple )
+              gsub( /\\n/, "\n", tuple )
+              gsub( /\\r/, "\r", tuple )
+              gsub( /\\"/, "\"", tuple )
+              gsub( /\\\\/, "\\", tuple )
+              gsub( /\\\032/, "\032", tuple )  # substitute char
+              # sqlite3 is limited to 16 significant digits of precision
+              while( match( tuple, /0x[0-9a-fA-F]{17}/ ) ){
+                hexIssue = 1
+                sub( /0x[0-9a-fA-F]+/, substr( tuple, RSTART, RLENGTH-1 ), tuple )
+              }
+              if( hexIssue ){
+                printerr( \
+                  NR ": WARN Hex number trimmed (length longer than 16 chars)." )
+                hexIssue = 0
+              }
+
+              print matches[1] tuple";"  #replace (..),(..) with INSERT.. (..) and and with semicolon
+            }
+          }
+        }
+        else if ("'" == c) {  #single quote
+          if (1==parser_single_quotes_open) parser_single_quotes_open--;  #closing the open quote
+          else parser_single_quotes_open=1  #start a single quote
+        }
+        else if ("\\" == c) parser_next_char_is_escaped=1;  #backslash escapes special meaning of bracket or single quote
+      }
+      else
+      {  #character is escaped, take it literally
+        parser_next_char_is_escaped=0  #next character is not escaped
+      }
+
+      # debug print for parser - prints every character processed and the parser flags
+#      print c" parser_round_brackets_open="parser_round_brackets_open" parser_single_quotes_open="parser_single_quotes_open" parser_next_char_is_escaped="parser_next_char_is_escaped;
+    }  #for every character in the rest of the line
   }
-  print
+
   next
 }

This is the test SQL dump file I was using:
LOCK TABLES `firmware_profiles_rules` WRITE;
/*!40000 ALTER TABLE `firmware_profiles_rules` DISABLE KEYS */;
INSERT INTO `firmware_profiles_rules` VALUES (3,0,NULL,NULL,NULL,'nothing'),(4,0,NULL,NULL,NULL,'kot\'ma),(ale'),(5,0,NULL,NULL,NULL,'(ala),(ma,(kota)'),(6,0,NULL,NULL,NULL,''),(7,0,NULL,NULL,NULL,''),(2,1,NULL,NULL,'BIOS','1.0.0'),(1,1,'%DRAC%',NULL,NULL,'1.06.07');
INSERT INTO `firmware_profiles_rules` VALUES (9,0,NULL,NULL,NULL,'');
/*!40000 ALTER TABLE `firmware_profiles_rules` ENABLE KEYS */;
UNLOCK TABLES;

Also, I don't quite understand what do you mean by "POSIX variant", do you have a separate tree or something for POSIX and non-POSIX compliant systems?

It's just that this script is POSIX-compliant and you're using match( $0, /ere/, x ), which is not POSIX (one needs to use match( $0, /ere/ ) and then substr( $0, RSTART, RLENGTH )).

Hi @dumblob here is the patch with working parser...

Wow, I'll need some time to review its edge cases. I think we'll need to rewrite it making functions like skip_to_next_dquote() out of it. This script is used by thousands of users so we can't afford to break something like an insert statement :wink:.

I admit I don't fully understand your series of "gsub" replacements, but I just pulled it into my print tuple routine.

Those are necessary as the SQlite syntax is different and also supports e.g. direct LF and CR characters and therefore it's safer to change escape sequences directly into these characters to avoid wrong parsing of escape sequences later.

Thanks for the patch. It contains a bug which means that the very last record is omitted from the sqlite INSERT. You can see that in your example input/output above, for example.
Suggested fix is to change the for loop on line 121 into:
for (i=1; i<arr_len**+1**; i++)

This has direct conflict  with PR #71.

I'm more and more inclining to explicitly not supporting extended inserts for now.
If anyone will provide a comprehensive set of test cases and a carefully carved patch of a manageable size (not bigger than the current script itself :wink:), I'll review it for merging though.


Add more Vertical Shakers (+Characterization Throughput)

I'm not sure adding a shaker will change our throughput tbh. Currently the characterization arm is 100% busy with even one shaker -- it uses the shaking time to set up other consumables.
To increase throughput we will need to relieve the arm of some tasks. Maybe we need to think about a little powder collection cell/assembly line where we:

place a crucible on a cart
cart moves over, ball is dispensed
moves, cap is dispensed on top
moves into vertical shaker
moves back to start position where the robot arm can resume


GH-2600: Fix Kotlin Listener List<Message<*>>

Resolves https://github.com/spring-projects/spring-kafka/issues/2600
Also reproduced in Java with
@KafkaListener(id = "kgh2600", topics = "kgh2600", batch = "true")
void listen(List<? extends Message<?>> in) {
	System.out.println(in);
}

MMLA did not handle a WildcardType as the list element type.
Also tested with reporter's Kotlin reproducer.
cherry-pick to 2.9.x (pattern matching instanceof will need to be changed)

Cherry-picked to 2.9.x as https://github.com/spring-projects/spring-kafka/commit/ec7fe08f38d9e691f48fb2dd8bdf1d9f1aba02b2


Learn More Dialogue

As an editor I want to be able to learn more about the background fill behaviours.
This is a follow up from #18
Acceptance Criteria

After clicking the "Learn More" the dialogue should pop up
The user is able to click OK to close the dialogue

Design

This dialogue use a material design dialog. As of https://github.com/google/web-stories-wp/issues/232#issuecomment-583399629.

I have recommended using material-ui, which implements the UI for react. Isn't officially supported by Google, but it is extremely popular.

@pbakaus To confirm: is this in Sprint 23 even though it's now a P1?

@pbakaus @jauyong I think the same dialog created for this ticket can be used for #354 . Meaning the size is much smaller

If the size is much smaller, let's get it in. Otherwise let's move to next sprint.

Thanks @spacedmonkey
Per Paul's message above, if this dialog is reused for #354 do you think we can get both done this sprint? Otherwise I'll add a label to get #354 in Sprint 25.
CC: @kmyram

@pbakaus also want to check in regarding Miina's note that this is a P1 and in this sprint...Should this be moved out of the sprint?

@jauyong as mentioned before, if the work is very small, we can put it into this sprint. Otherwise moved it out.

Since I made #706 for links, I'll do this as well


Add Field (Schema evolution)

Context
Currently, the Registers Data Model has no way to evolve the data structure
described in the schema and used in data items. This means a Register has to
be designed upfront with the right fields forever given it is an append-only
log. We need a way to be able to evolve the schema definition and a way to
reflect such evolution on existing and new data.
Changes proposed in this pull request
This RFC proposes a way to add fields to a Register, and defines the meaning of this operation.

I added to the RFC the clarifications I made here. It seems appropriate to be more explicit and concrete about what are the expectations for robust API consumer implementations. In turn, the explanation will land to the specification and perhaps to the API documentation. @bahmady the "REST API Implications" section might be relevant for you once this RFC gets approved.

Final rewrite to squash all intermediate commits.


Cannot withdraw ETH and USDT out of DEX

After some app crashes and several errors, I am not able to withdraw ETH & USDT to Cake. I am able to swap those tokens for DFI on the DEX though. I am always getting an UTXO error when trying to withdraw it. I am fully aware of the workaround for DFI (DFI token to coin) but performing the same steps for ETH & USDT creates an error in the console.
Things I did so far using the console:
.) Sent small DFI to all DFI addresses in use by calling listaccounts {} false false true
.) Converted all DFI token to coins using utxostoaccount
.) Tried to apply the same utxostoaccount to USDT & ETH - got error message, telling me only allowed for DFI
.) Sending in ETH & USDT from Cake - credited successfully
Error I am getting when trying to send out ETH & USDT: "Not enough balance on wallet accounts, call utmost account to increase it."

Hi @mikej289 , thanks for your feedback and for trying the workaround. Kindly send your app logs. If possible, do attach screenshots / screen recordings. This will provide more insight for the investigation. Thank you.

Hi @mikej289 , thanks for your feedback and for trying the workaround. Kindly send your app logs. If possible, do attach screenshots / screen recordings. This will provide more insight for the investigation. Thank you.

The app logs & screenshots have already been sent via David L.

The app logs & screenshots have already been sent via David L.

Hi @mikej289 , nice to e-meet you. Your logs are well received, please give us time to investigate this issue.

Hi @mikej289 , nice to e-meet you. Your logs are well received, please give us time to investigate this issue.

After reviewing your case, here's an update. For existing issue, the team is in the midst of fixing them. For new issue, please give us time to investigate it. Thank you.

Issue 1
New issue: JavaScript error occurred in the main process
Existing issue:_ Corrupted block database detected. Please restart with -reindex or -reindex-chainstate to recover. Do you want to restart?

Issue 2
New issue: Request failed with status code 500

Issue 3
Existing issue: Not enough balance on wallet accounts, call utxostoaccount to increase it

Issue 4
Existing issue: Corrupted block database detected. Please restart with -reindex or -reindex-chainstate to recover. Do you want to restart?
Temporary solution:
wait for blockchain to sync to 100% to continue using app. However, it’ll take quite awhile to load, current block is at 556,166.
I faced the same error and it takes me about 1–2hrs to sync, the lesser apps you run in your mac the better because DeFi app is going to take up a lot of RAM due to the bug.

After reviewing your case, here's an update. For existing issue, the team is in the midst of fixing them. For new issue, please give us time to investigate it. Thank you.

Issue 1
New issue: JavaScript error occurred in the main process
Existing issue:_ Corrupted block database detected. Please restart with -reindex or -reindex-chainstate to recover. Do you want to restart?

Issue 2
New issue: Request failed with status code 500

Issue 3
Existing issue: Not enough balance on wallet accounts, call utxostoaccount to increase it

Issue 4
Existing issue: Corrupted block database detected. Please restart with -reindex or -reindex-chainstate to recover. Do you want to restart?
Temporary solution:
wait for blockchain to sync to 100% to continue using app. However, it’ll take quite awhile to load, current block is at 556,166.
I faced the same error and it takes me about 1–2hrs to sync, the lesser apps you run in your mac the better because DeFi app is going to take up a lot of RAM due to the bug.

are there any solutions? because i have the same problem and cannnot pay out my ETH´s or BTC´s back to the cake pool page.

are there any solutions? because i have the same problem and cannnot pay out my ETH´s or BTC´s back to the cake pool page.

Seems like not yet. I tried all suggested solutions so far and nothing worked so far.

Seems like not yet. I tried all suggested solutions so far and nothing worked so far.

Hello. I have the same problem with, can not send (withdraw) usdt from dex definchain to cake. "Not enough balance on wallet accounts, call utxostoaccount to increas it". So i have a lot of balance and dfi is enough there...whats the problem=

Hello. I have the same problem with, can not send (withdraw) usdt from dex definchain to cake. "Not enough balance on wallet accounts, call utxostoaccount to increas it". So i have a lot of balance and dfi is enough there...whats the problem=

@Huzi1988 @mikej289 @floxcgncgn
The following workaround via console worked in my case
https://www.reddit.com/r/defiblockchain/comments/kvsw4l/stepbystep_workaround_sending_btc_eth_usdt_and/

@Huzi1988 @mikej289 @floxcgncgn
The following workaround via console worked in my case
https://www.reddit.com/r/defiblockchain/comments/kvsw4l/stepbystep_workaround_sending_btc_eth_usdt_and/

awesome! Thx for the article 👍

awesome! Thx for the article 👍

Hi @Huzi1988 @mikej289 , regarding the issue Unable to send BTC / ETH / USDT, kindly refer to https://github.com/DeFiCh/app/issues/195 which we can further discuss on the problem. I'll keep you guys update on that issue there. Thank you.
Thank you @DanielZirkel !

Hi @Huzi1988 @mikej289 , regarding the issue Unable to send BTC / ETH / USDT, kindly refer to https://github.com/DeFiCh/app/issues/195 which we can further discuss on the problem. I'll keep you guys update on that issue there. Thank you.
Thank you @DanielZirkel !

Hi @mikej289 	, update v2.1.6 is out https://defichain.com/downloads/.
Do give a thumbs up to this comment if your issue has been resolved, otherwise, you may reopen this issue with new information (include screenshots) and your app logs. Thank you.

Hi @mikej289 	, update v2.1.6 is out https://defichain.com/downloads/.
Do give a thumbs up to this comment if your issue has been resolved, otherwise, you may reopen this issue with new information (include screenshots) and your app logs. Thank you.


Add toolchain librarypaths to -Wl,-rpath

Fixes #1780
Reused code from compiler-dropin-tool to find out the toolchain path

Tested on staging, seems to work as intended, also didn't break anything, I think...


refactor: remove top-level await in cli.mjs

I would like a reason for this? Why not use a top level await?

I would like a reason for this? Why not use a top level await?

It enforces ESM support in the runtime to run the CLI (node.js versions without ESM are still used, despite security issues, no support, ...).
I will complete changes to make the CLI CJS compliant, like the rest of the code base.

I will complete the changes to make the CLI CJS compliant, like the rest of the code base.

Because of peowly, which is ESM only, CLI can't be easily converted to CJS. Is peowly strictly needed? I think having a code base consistent and working with CJS (with warnings) and ESM ease adoption.

ESLint itself does not support anything older than Node.js 18 and so doesn’t Neostandard?
And currently the CLI is just a config helper, not core to the experience?

Im sympathetic to supporting cjs where appropriate, but the cli isn't imported anywhere and requires a runtime supporting esm so use of TLA shouldn't cause any grief here.

And currently the CLI is just a config helper, not core to the experience?

It's the very first neostandard component the user deal with at migration. In case he tries it on an a CJS code base running with unsupported node.js, the end result of his first experiment is a failure.
ESlint and its CLI while not supported on old node version still works on them (use at your own risk).
The workaround is:

upgrade temporary to recent node version
do the migration
downgrade the node version

Or

do the migration by hand ...

Or

stick to the standard deps

And it can be trivially avoided.
Either a code base support CJS and ESM at a whole, either it only works with ESM. But making a library working with CJS and ESM with an CLI requiring ESM make little sense.

If it was the CLI for running the tests, then I would add https://github.com/voxpelli/version-guard to ensure it fails silently on old versions
Eg. peowly itself uses parseArgs that’s only available in node.js since 16.9.0 / 16.11.0  and top level awaits in esm is supported since 14.8.0, so essentially it would take someone to run something so old that many modern JS and Node API:s are not available there, and that is highly unstable and unsupported, any addition of a modern JS feature will potentially break it, eg something like the highly useable structuredClone that’s available since 17.0.0
As the creator and maintainer of https://github.com/voxpelli/node-installed-check, which this module uses, I’m very keen on publishing correct engine ranges and on sticking to those ranges, and since ESLint doesn’t support anything older than Node 18, Node.JS doesn’t support anything older than Node 18, then the only thing I would be prepared to change is to do a version-guard variant where it exits with a more user friendly error

Also: It makes little sense to me to avoid using ESM in a CLI since that’s the one place ESM actually gives a distinct advantage, as it permits top level await, making for clean readable code

So,

node version check in the cli to display a meaningful message for unsupported version. The way version-guard is implementing it not handy: the version check is not based on a unique fine grained source like engines content in package.json and it does not seem to be able to optionally only use it.
unneeded slower async primitives to read file replaced by faster sync implementation (for the sake of using primitives with a semantic matching CLI synchronous design)?

The way version-guard is implementing it is not handy: the version check is not based on a unique fine grained source like engines content in package.json and it does not seem to be able to optionally only use it.

It has worked well for me for now and is a very simple implementation, which ensures it will work in old runtimes.
Doing a full on semantic versioning check would either require a naive parser of semver ranges or a dependency for parsing the semver ranges, and the dependency is likely to not have as wide support as version-guard needs.

unneeded slower async primitives to read file replaced by faster sync implementation (for the sake of using primitives with a semantic matching CLI synchronous design)?

Any performance difference is negligible in this case, I would say that its a matter of taste where both are acceptable options.
I'm going to a bit harsh and close this. If we want to discuss performance improvements or compatibility improvements we are better of doing so in dedicated issues that focuses on a problem rather than on a solution.
Thanks for the PR though 👍

The way version-guard is implementing it is not handy: the version check is not based on a unique fine grained source like engines content in package.json and it does not seem to be able to optionally only use it.

It has worked well for me for now and is a very simple implementation, which ensures it will work in old runtimes.
Doing a full on semantic versioning check would either require a naive parser of semver ranges or a dependency for parsing the semver ranges, and the dependency is likely to not have as wide support as version-guard needs.

Currently, neostandard is working with different JS runtime. If strict runtime version checking is introduced with version-guard:

it will make suddenly neostandard fails on other JS runtime than node
version-guard can be replaced by a few lines of codes + one dependency to parse semantic version. With cross runtime support

Since tool for coding style is expected to be runtime agnostic, I think the project description should clearly state it as a design goal.

unneeded slower async primitives to read file replaced by faster sync implementation (for the sake of using primitives with a semantic matching CLI synchronous design)?

Any performance difference is negligible in this case, I would say that its a matter of taste where both are acceptable options.

Both works. And one is similar to using an anvil to nail :)

Currently, neostandard is working with different JS runtime

As far as I know, ESLint is only supported on Node.js, and yes, this config even contains eslint-plugin-n so it’s definitely geared towards Node.hs
If one wants a runtime independent solution, then something like Biome (#77) would be a better approach


Figure out why resque-pool is needed and how to remove/update

resque-pool has a vulnerability in the sinatra dependency.  It's only of moderate concern and I don't think sinatra is even used for whatresque-pool is doing.  That said, we are using Sidekiq for delayed jobs, so I do not know why resque-pool is even needed.  When deploying, Sidekiq will not start unless resque-pool is installed.  This is weird because resque-pool and resque are not dependencies of Sidekiq.  We need to figure out why this is, and preferably find a way to remove resque-pool.
It should be noted, however, that this may become a non-issue when we move to kubernetes in the summer 2022.  Since k8s has a different way of deploying Sidekiq.  Might be best to wait on this until then.

Moved to k8s, so moot


Website / Backend Connection

Will CircleBilling have a simple front end to backend connection, with static sites?
For example, WHMCS will automatically pass details through from a login form on your main website, as long as you use the dologin.php File.  I don’t believe BoxBilling has this.
Also, will this project be a constant one, with updates at least once or twice a year, and not being left for almost 5 years with nothing more than a statement saying not enough demand (highly doubt it for free) which BoxBilling has now done.
As even without demand, security patches and small updates should still occur, otherwise your user base will simply leave, and if there’s paid users, revenue would be lost etc.

Alright, also will there be a cPanel hook for auto-login? I’ve come across a theme on github for BoxBilling (will they be compatible with circlebilling?) and it has a cpanel hook, but stock BoxBilling does not.

Please consider using the forum for ideas!


Add post processing algorithm based on work by Hardt, Price, Srebro

This includes preliminary tests, separate plotting utilities.
What this does not include: APIs as discussed on Friday.

I don't think any of my comments should be taken as blocking for checkin. I'm sure that there will be future reworking and test adding, but since we confirmed that the basic algorithm is working, our highest priority is probably agreeing our API.

Checking this in as a preliminary change. Still quite a few changes ahead, but this is a good checkpoint.


Feature request: Allow other version control systems

Not everyone uses Git, so it might make sense to allow defining an arbitrary command to be called instead of the GitHub/GitLab transaction.

Is the version control system you want to support

has an API to retrieve a single file without clone? (Used to acquire staticman.yml)
has an API to append a single file without clone? (Used to insert comments)

Instead of using regular git operation, Staticman makes use of GitHub/GitLab's API to minimum the data traffic. If the target version control system can't do that, Staticman will have to clone everything again and again. It will dramatically increase the complexity (as well as storage and traffic) and I can't image how can Staticman achieve it without rewrite from scratch.
This project is silent for months, fell free to create your forks.

I understand. In that case, this suggestion makes less sense than I was hoping.


Configurable profile picture

Bots can have server profiles, so setting a custom profile picture with a /customise command or similar should be easy

Discord can only update global profile pictures for bots


25 FPS requirement

Im trying to optimize RadNerf to work with videos of various resolutions (and hopefully framerates).
I was wondering why does the readme say that the input videos must be 25FPS? @ashawkey

I tested this with videos of framerates other than 25. You can run the entire process because the model doesn't run on video but rather the extracted images.


Refresh dns record

Now, skydns do not watch the etcd to update local cache.
I want to add a REST api: manual regenerate(refresh) local cache when the dns record change in the etcd.
$ curl http://host:port/refresh/local/skydns/service

any suggestion？
@miekg

The idea of SkyDNS(2) was to move all rest stuff out to etcd and only leave the DNS in skydns. Also with client side caching this does not update all the client at once.


CI: Tests are running for very long after merging #673

After the merging of https://github.com/jonescompneurolab/hnn-core/pull/673, CI time for unit tests has gone up significantly.  This will slow down the speed feedback/development considerably. Can the tests be streamlined?
MacOS: 11m -> 34m
Unbuntu: 19m -> 55m
Windows: 16m -> 1h 43m
@ntolley @carolinafernandezp

Oof that's on me, there's a few changes I can implement:

restrict the maximum number of iterations
simulate a smaller network
increase dt

That should bring everything back to around the same runtime


Using a Service to Expose Your App - curl http://"$(minikube ip):$NODE_PORT" command doesn't work

I have used many of the tips in https://kubernetes.io/docs/tasks/debug/debug-application/debug-service/ but so far I don't know why my kubernetes-bootcamp pod/service is not exposed on the IP address of the minikube container.
I am using minikube with docker desktop on osx.
$ kubectl get svc
NAME                  TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)          AGE
hello-minikube        NodePort    <IP_ADDRESS>   <none>        8080:32572/TCP   5h30m
kubernetes            ClusterIP   <IP_ADDRESS>        <none>        443/TCP          5h32m
kubernetes-bootcamp   NodePort    <IP_ADDRESS>   <none>        8080:31048/TCP   26m

$ minikube ip
<IP_ADDRESS>

I can access the service directly on the pod container
$ kubectl get pods
NAME                                   READY   STATUS    RESTARTS        AGE
kubernetes-bootcamp-5485cc6795-q7d4z   1/1     Running   2 (3h42m ago)   5h26m
$ kubectl exec -ti kubernetes-bootcamp-5485cc6795-q7d4z -- bash
root@kubernetes-bootcamp-5485cc6795-q7d4z:/# curl http://localhost:8080
Hello Kubernetes bootcamp! | Running on: kubernetes-bootcamp-5485cc6795-q7d4z | v=1

as well as another node
$ minikube status
minikube
type: Control Plane
host: Running
kubelet: Running
apiserver: Running
kubeconfig: Configured

minikube-m02
type: Worker
host: Running
kubelet: Running

$ minikube ssh --node=minikube-m02
docker@minikube-m02:~$ curl <IP_ADDRESS>:8080
Hello Kubernetes bootcamp! | Running on: kubernetes-bootcamp-5485cc6795-q7d4z | v=1

I do see the expected iptables rules on the minikube host that is running kube-proxy:
root@minikube:/home/docker# iptables-save | grep bootcamp
-A KUBE-EXT-2TYZFXBKM236ELT2 -m comment --comment "masquerade traffic for default/kubernetes-bootcamp external destinations" -j KUBE-MARK-MASQ
-A KUBE-NODEPORTS -p tcp -m comment --comment "default/kubernetes-bootcamp" -m tcp --dport 31048 -j KUBE-EXT-2TYZFXBKM236ELT2
-A KUBE-SEP-TZES6ZB4476KQUHJ -s <IP_ADDRESS>/32 -m comment --comment "default/kubernetes-bootcamp" -j KUBE-MARK-MASQ
-A KUBE-SEP-TZES6ZB4476KQUHJ -p tcp -m comment --comment "default/kubernetes-bootcamp" -m tcp -j DNAT --to-destination <IP_ADDRESS>:8080
-A KUBE-SERVICES -d <IP_ADDRESS>/32 -p tcp -m comment --comment "default/kubernetes-bootcamp cluster IP" -m tcp --dport 8080 -j KUBE-SVC-2TYZFXBKM236ELT2
-A KUBE-SVC-2TYZFXBKM236ELT2 ! -s <IP_ADDRESS>/16 -d <IP_ADDRESS>/32 -p tcp -m comment --comment "default/kubernetes-bootcamp cluster IP" -m tcp --dport 8080 -j KUBE-MARK-MASQ
-A KUBE-SVC-2TYZFXBKM236ELT2 -m comment --comment "default/kubernetes-bootcamp -> <IP_ADDRESS>:8080" -j KUBE-SEP-TZES6ZB4476KQUHJ
root@minikube:/home/docker#

If I do
minikube service kubernetes-bootcamp --url
http://<IP_ADDRESS>:52620

And open that URL I can see a good response. So not sure if that command mentioned in the docs is just wrong? Maybe it could be replaced with something like
minikube service kubernetes-bootcamp

Which would start a proxy and open in a browser?
Yeah, I think that would work well. I'll make a PR and see how that goes.

Page related to issue: https://kubernetes.io/docs/tutorials/kubernetes-basics/expose/expose-intro/
/language en

/retitle Encountering errors in exposing a service on Minikube as instructed in the 'Using a Service to Expose Your App' tutorial

Similar possible related issues to see https://github.com/kubernetes/website/issues/41438 https://github.com/kubernetes/website/issues/40645

Similar possible related issues to see #41438 #40645

Oh sorry for not searching issues enough. It does seem a catch-all replacement might be to use the minikube service kubernetes-bootcamp command instead as that might work everywhere. If I understand from the other issues it is a limitation of docker desktop on macos.


[BEAM-8691] bigtable-client-core dependency upgrade

https://issues.apache.org/jira/projects/BEAM/issues/BEAM-8691

Upgrading bigtable-client-core to the latest 1.13.0
The exposed API surface reduced. The associated test is updated.
Because bigtable-client-core:1.13.0 introduced conflicts in Maven version range, excluding grpc-core dependencies from bigtable-client-core and google-cloud-core-grpc, so that the module uses grpc version 1.25.0 (detail)
Upgrading gax to avoid linkage errors (detail)
Declaring grpc-grpclb 1.25.0 to avoid linkage errors (detail)

Linkage Check result
Checked beam-sdks-java-core, beam-sdks-java-io-google-cloud-platform, beam-runners-google-cloud-dataflow-java and beam-sdks-java-io-hadoop-format.
https://gist.github.com/suztomo/1bedcd7c63bc88310fff3854c19710d6
For beam-sdks-java-io-google-cloud-platform and beam-runners-google-cloud-dataflow-java

This PR removes linkage errors on gax-httpjson-0.52.0.jar
This PR upgrades the version of appengine-api-1.0-sdk in the errors. These are irrelevant to Beam.

Using this shell script https://gist.github.com/suztomo/ec4834151a81f8e1d26aa0afb278818b

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Java_Examples_Dataflow PreCommit

R: @lukecwik @kennknowles
21 successful checks! Would you review/merge this PR?
@alexvanboxel Thank you.


Add big-endian support to String TensorType in TFLite FlatBuffer models

PR #58494 has added big-endian support to numeric TensorTypes in TFLite FlatBuffers. However, since TFLite uses tflite::DynamicBuffer to encode vector of strings, the header of string buffer contains raw bytes which record the number of strings, the offsets of each string, etc., as shown in the following code snippet:  https://github.com/tensorflow/tensorflow/blob/864bf2ca8e4f314d9ad01d240d9e3fec2b653c93/tensorflow/lite/string_util.cc#L78-L87  Thus the String TensorType will have endianness issue if a TFLite model is used across platforms with different endianness formats.
This PR aims to solve this issue in both C++ and Python code and uses the same guidelines on big-endian machines as PR #58494 , such as:

Convert the string buffers from LE(little-endian) to BE(big-endian) format when loading a TFLite model from a file.
Convert the string buffers from BE to LE format when writing a serialized binary string of TFLite model to a file.
Keep the header of string buffers in BE format when the model/buffer is in memory.

An argument bool from_big_endian was added to the function declaration of FlatBufferModel::ByteSwapBuffer() , because in this function we need to know the endianness of the raw bytes in the header of string buffer, so that we can read the num_of_strings data correctly.
After applying this PR, the String TensorType will be correctly byte-swapped along with other numeric TensorTypes when necessary. We've tested the code change on TensorFlow test suite, it won't cause any regressions on BE/LE platforms, and can fix the following test failure on s390x (big-endian arch) in master branch:
//tensorflow/compiler/xla/service/cpu/tests:cpu_infeed_test

We've also tested this PR with the tensorflow/serving test suite, failures in the following test cases could pass on s390x after this change, since the string tensors in TFLite models which were generated on LE machines could now be loaded successfully on BE platforms.
//tensorflow_serving/servables/tensorflow:saved_model_bundle_factory_test
//tensorflow_serving/servables/tensorflow:tflite_interpreter_pool_test
//tensorflow_serving/servables/tensorflow:tflite_session_test

Hi @terryheo ,
Hope all is well with you and thanks for helping us review the previous TFLite related PRs.
Could you please review this PR when you have a chance? Thanks again!

Hi @terryheo ,
Could you please take a look at this PR when you have some time?
Thank you very much!

Hi @terryheo Can you please review this PR ? Thank you!

Hi @terryheo ,
Could you please review this PR when you have a chance?
Thank you very much!

Hi @zichuan-wei ,
Thank you so much for reviewing this PR.
I've made changes as per your review comment. Could you please take a look again? Thanks!

Hi @zichuan-wei ,
Could you please review this PR again? Thank you very much!

Hi @zichuan-wei ,
I think the failures in Py+CPP Test Suite check are not related to the code changes in this PR, since the changes are specific to Big-Endian systems and most are enclosed in #if FLATBUFFERS_LITTLEENDIAN == 0 macros.
However, I'm not sure why the feedback/copybara - Google internal checks failed, since I couldn't access the logs.
Could you please take a look? Thank you very much!

Hi @gbaned ,
Since I couldn't access the logs, could you please help check why the feedback/copybara - Google internal checks failed?
Thank you very much!

Hi @gbaned ,
Since I couldn't access the logs, could you please help check why the feedback/copybara - Google internal checks failed?
Thank you very much!

Hi @kun-lu20 Sorry for the delay in response. We will check it. Thank you so much!

Hi @gbaned ,
Do you have any updates reg this PR?
Thank you very much!

Hi @gbaned ,
Do you have any updates reg this PR?
Thank you very much!

Hi @kun-lu20 Sorry for the delay in response. We are working on this PR internally. Thank you so much!

@gbaned Thanks for letting me know!