fix: various typos in code samples

Summary
Took a pass with cSpell. Kept the MD file changes in another PR. Could split this one between the VB and CS changes if it's easier

Hi @nschonni
I took a brief look at this. I like the changes. How best should we resolve the CI build errors?  They fall into two concerns:

Missing a project file. Those should be easy to fix by creating a new csproj or vbproj file in the correct folder.
Missing .NET Framework 4.0. Our CI container doesn't have that version, and those (mostly WPF) samples need to have their projects upgraded. Visual Studio should do that automatically.

There's a few ways to handle this. The simplest is if you update the samples affected by this PR. Alternatively, we can update the builds in a new PR, merge that one, then revisit the builds on this one.
Let me know what you'd like to do.

If you want to address the missing project files, I think it might be better done in another PR, since I'm not sure if you'd want to review if the samples should be kept.

Hi @nschonni
I removed a large number of unused samples that were triggered in this PR.
A rebase should simplify things a lot. Or, you can open a new PR with the remaining samples. Whichever is easier for you.

@BillWagner I think there are less errors now 😆

@BillWagner @nschonni
Upgraded the snippets script to allow bypassing these errors. Add a snippets file with the error, like so:
snippets.5000.json
{
    "host": "dotnet",
    "expectederrors": [
        {
            "file": "samples/snippets/core/tutorials/netcore-hosting/csharp/HostWithHostFxr/src/NativeHost/inc.vs/nethost.h",
            "error": "ERROR: Too many projects found. A single project or solution must exist in this directory or one of the parent directories."
        }
    ]
}

You can use the build output logs from the previous run to find the errors you put in snippets file. The summary tab of the run has the output file at the end of the page:

In the file you can find the offending file and error message to put in the snippets file:
  {
    "ProjectFile": "",
    "InputFile": "samples/snippets/core/tutorials/netcore-hosting/csharp/HostWithHostFxr/src/NativeHost/inc.vs/nethost.h",
    "ExitCode": 2,
    "BuildOutput": "ERROR: Too many projects found. A single project or solution must exist in this directory or one of the parent directories.",
    "Settings": null,
    "Errors": [
      {
        "Line": "ERROR: Too many projects found. A single project or solution must exist in this directory or one of the parent directories.",
        "Error": "ERROR: Too many projects found. A single project or solution must exist in this directory or one of the parent directories."
      }
    ],
    "ErrorCount": 1
  },

InputFile and Error are the two fields you need to put in the snippets file.
The snippets file needs to be created at the level of the InputFile or in any parent directory.

Hi @nschonni
This has grown stale. None of us have done what's needed to move it forward. It's got a lot of conflicts now.
I think it might be best to close this, and start with fresh PRs using cSpell on smaller sets of files.
What do you think?

@BillWagner I can try and rebase this again, but I don't plan to redo all of this for a new PR(s) or address the unrelated build failures that exist today

@BillWagner I can try and rebase this again, but I don't plan to redo all of this for a new PR(s) or address the unrelated build failures that exist today

If the rebase is easy and doesn't take much time, let's do it. I'll use the admin switches to merge. I noticed that all the text changes seem to be in comments, so they won't break anything that works.
We keep adding more projects to the CI build, so hopefully there are fewer issues this time. I agree that it's not something I'd expect community contributors to add. Especially at this scale.

@BillWagner rebased. There is still a handful of missing projects, but feel free if you want to push fixes to this branch


Temperature sensor not considered in ClimateGetTemperature

While trying out the newly translated intents I found out that my temperature sensors are not considered. I get the following error:
raise intent.IntentHandleError("No climate entities")
I thought that in prior versions I did get a result.
I understand that the temperature sensor does not qualify as climate device, insofar it makes sense not to consider these sensors in the ClimateGetTemperature intents. I guess the temperature sensor should then be handled over HassGetState. In my view this has two downsides, though: First, the same sentences have to be doubled, which could lead to conflicts. Second, if a user asks about the temperature of an area, it seems not predictable, if the temperature of a temperature sensor or a climate device is returned.
What are your thoughts on this?

First of all, the intent is called ClimateGetTemperature, with an emphasis on Climate. It's meant to work for climate entities, which don't even expose the temperature in the state, but in an attribute.
Second,

I thought that in prior versions I did get a result.
You still do if you ask what is [the temperature of] <temperature sensor name or alias>?

Third, we have long considered allowing multiple "filters" for a single sentence, to select entities in different domains, e.g.

{domain: "climate"} + {domain: "sensor", device_class: "temperature"} for sentences such as what is the temp in the living room?
{domain: "cover", device_class: "door"} + {domain: "binary_sensor", device_class: "door"} for sentences such as how many doors are open?
but the implementation was horrible and never got around to it.

Still, even if we do it, there will be 2 issues to tackle:

a climate entity most likely shows the ambiental temperature. A temp sensor may be that of a 3D printer
how should you tackle multiple readings in a single area? First found entity? Average? Min-max?

To sum up: we'll get to that, but not yet.

Thank you @tetele for your explanations. Makes totally sense to me.

Also, this https://github.com/home-assistant/architecture/discussions/1017


[Bug] Languages aren't filtered

Device information

Tachiyomi version: 2.4.1
Android phone & version: xiaomi redmi 9 Android 10

Steps to reproduce

First step
Open manga
Second step
Observe

Expected behavior
This should happen.
Manga language selected in settings should only be shown
(in this case English)
Actual behavior
This happened instead.
Other languages like Russian, French and Spanish and the likes are shown as well
Bug appeared after update from 2.4 to 2.4.1

This was an issue with dex api. Update your library and it should remove them


support relay Node interface

Hi @MrThearMan and @matti-lamppu
First of all, thank you for your awesome work on this project!
I'd like to report an issue that pops up when the global relay interface Node is used (see docs):
Example query:
query {
  node(id: "%s") {
    ... on ApartmentType {
      building {
        name
      }
    }
  }
}

Causes:
  File "/home/christian/dev/graphene-django-query-optimizer/query_optimizer/ast.py", line 186, in handle_inline_fragment
    fragment_type = get_fragment_type(field_type, inline_fragment)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/christian/dev/graphene-django-query-optimizer/query_optimizer/ast.py", line 271, in get_fragment_type
    gen = (t for t in field_type.types if t.name == fragment_type_name)

It seems that a UnionType is expected (which knows about all the possible implementation types), but we have an InterfaceType instead. I figured i'd open this Issue/PR for potential feedback, while my colleague @winged and I will try to dig deeper and maybe suggest a potential fix.
Thank you in advance!

Hi, thanks for the issue!
I looked into this, and fortunately adding support for Node on the main query type was rather easy to do, so I went ahead and added it. Released in 0.10.3.

@MrThearMan Wow, I didn't expect that - really impressive, thank you so much! Let me know if one can buy you a beer :-)


feat!: allow null values for backup_window and retention_period

what
Sets the default for backup_window and retention_period to null.
BREAKING CHANGE: backup_window and retention_period are now null by default. If you want to keep the old
default configuration, set backup_window = "07:00-09:00" and retention_period = 5.
why
When AWS backup is used, the settings either have to match the AWS backup settings exactly or they
have to be unset.
Trying to apply any diverging settings will result in an error:
InvalidParameterValue: RDS cluster $name is associated with the following AwsBackupRecoveryPointArn: arn:aws:backup:$region:$account:recovery-point:$mode:cluster-$id. The BackupRetentionPeriod can be blank, or you can use the current value, $current_value. For more details, see the AWS Backup documentation

Since matching these settings manually defeats the purpose of having a single source of truth,
this change updates the default values to be null.
I would prefer to make this a non-breaking change, but without adding another variable, this seems to not be possible
since a default can't be overridden with null.
references
This is possible since https://github.com/hashicorp/terraform-provider-aws/issues/33465 was for aws_rds_cluster resources.

@srhopkins @dotCipher Can you share an estimate for when you'll get to review this PR? That would be very useful for my planning. Thank you!

/terratest

@hans-d Thanks! I see the error is

Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: 9f342b56-35a2-405b-b548-b2f29f700952, api error VpcLimitExceeded: The maximum number of VPCs has been reached.

Which I can do nothing about. Does anyone need to be notified about the need for cleanup here?

@hans-d Thanks! I see the error is

Error: creating EC2 VPC: operation error EC2: CreateVpc, https response error StatusCode: 400, RequestID: 9f342b56-35a2-405b-b548-b2f29f700952, api error VpcLimitExceeded: The maximum number of VPCs has been reached.

Which I can do nothing about. Does anyone need to be notified about the need for cleanup here?

I'm already following up on this one - something I cannot fix myself as well unfortunately.

/terratest

Sorry it took so long, @morremeyer
I'm inclined to not accept the PR because

It is a breaking change
Your statement "a default can't be overridden with null" is incorrect

I generally disapprove of breaking changes that have easy non-breaking workarounds, and this one fits that category.

@Nuru I agree with that, I always prefer non-breaking changes to breaking ones. However, when I implemented this, I did not see a way to make a non-breaking change.
Let me re-examine how I came to this conclusion so that I can document it better - or ideally find out I was wrong!

@Nuru Sorry for the delay here, I finally got to test the config. I don't know what I did wrong when I last tested, but of course you were right. Thanks again for looking into it!
Explicitly setting
retention_period = null
backup_window    = null

works as intended. Now, AWS Backup can manage the configuration as needed and we won't have conflicts anymore.
Closing this since it's not needed.


404 error for cognito users login through CLI - unable to login active lease

Version

DCE CLI v0.4.0 (master)
Darwin C02XC78CJGH5 17.7.0 Darwin Kernel Version 17.7.0: Sun Jun  2 20:31:42 PDT 2019; root:xnu-4570.71.46~1/RELEASE_X86_64 x86_64
go version go1.14.2 darwin/amd64
Terraform v0.12.20

404 error when dce leased user (cognito) tries to login through dce CLI
404 error is displayed when running below command:
dce leases login --open-browser
To Reproduce

Execute command "dce auth"
Copy cognito user encrypted token and paste in terminal.
Execute "dce leases login --open-browser " OR dce leases login --print-creds
404 error appears

Expected behavior
Cognito user should be able to login to leased account after running above commands.
Additional context
Currently I am logging in using STS master creds which works with above commands but not for cognito users. Also, after lease is destroyed, the destroyed account session is still Active (user can create resources until session is closed manually) which should be signed out.

Team, any comments on this?

Accept: application/json
Content-Type: application/json
DEBU[0002] Response:  &{404 Not Found 404 HTTP/2.0 2 0 map[Access-Control-Allow-Origin:[*] Content-Length:[84] Content-Type:[application/json] Date:[Tue, 16 Jun 2020 07:36:23 GMT] Via:[1.1 dc57d6ecb65615ae4fed67afa847c0ba.cloudfront.net (CloudFront)] X-Amz-Apigw-Id:[ONdypG1VoAMFplg=] X-Amz-Cf-Id:[DJLlr_8MpI1ODspGPFimdDyXMKhSMyMbfJfzJNvg6w_Z4DM4bQIE0Q==] X-Amz-Cf-Pop:[BLR50-C2] X-Amzn-Requestid:[f3f2316f-9ce9-46a2-98f4-4a9c0f7958e0] X-Amzn-Trace-Id:[Root=1-5ee87677-5e3d9db3fc18a0b3856db27c;Sampled=0] X-Cache:[Error from cloudfront]] {0xc0000ea3c0} 84 [] false false map[] 0xc00047f500 0xc00027d760}
FATA[0002] err:  unknown error (status 404): {resp:0xc0007ce000}

Unable to login after this merge in repo for DCE CLI: #345
@robologic , can you please help clarification on this? it will be helpful to know if I am missing anything from my end or its the merge number after which the dce end user login not working?

This issue is resolved, we were providing Principal Id which was not same as username for cognito. Hence closing Issue.


Remove 'Run After' Editing and Enhance Scope Action for Exception Handling in Designer UI

Editing the "Run After" conditions is no longer supported in the designer UI; therefore, it has been removed.
Added instructions for editing the Scope action in the designer UI, as exception handling can now be directly implemented through the Scope action interface.

@agunay-munichre please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@ecfan
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Feedback added, thank you!

Thank you for the feedback!

@agunay-munichre: Thanks for making the updates. Please also update your PR title and description to accurately reflect the changes? Thank you!

All your comments were addressed! @ecfan

#sign-off


pyo3.rs/ redirects to https://pyo3.rs/v0.16.4/ instead of https://pyo3.rs/v0.16.5/

Bug Description
Currently, the pyo3.rs site's / redirect is redirecting to the 0.16.4 version of the docs instead of the currently published 0.16.5
Steps to Reproduce

Go to https://pyo3.rs/
See it redirects to pyo3.rs/0.16.4 (there's a meta tag with http-equiv=refresh in it)

Backtrace
No response
Your operating system and version
any
Your Python version (python --version)
any
Your Rust version (rustc --version)
any
Your PyO3 version
any
How did you install python? Did you use a virtualenv?
N/A
Additional Info
No response

Thanks for reporting, yes I noticed that too. Our github-pages push seems to be having trouble recently (see #2472), I think we'd better move to a service like Netlify...

The landing page now links to the latest version again.


Improve new user (developer) journey

Let's define and improve the ideal happy path for new developers visiting our dev portal.
Goals:

Complete Sui's version of hello world
We want developers to get enough info to understand and get excited

@bholc646 @kyleqian have already tried going thru some of our docs.
And @kyleqian suggested https://project-serum.github.io/anchor/tutorials/tutorial-0.html#clone-the-repo as a good example of a basic hello world.
@Clay-Mysten

Thanks, Bauer! You mentioned Kyle had pain points. Kyle, can you add them here?

Here are my notes (goes without saying that some of these could just be my preference 😁):

I'm someone who learns best by example, and I was unable to find a comfortable starting point at first
The tictactoe tutorial is a bit advanced as the first exposure. I think it could work, similar to Solana's escrow example, but it would need much more elaboration on what's happening, rather than just stepping through the "how".
The code samples in the repo were useful, but I still didn't feel comfortable using them until I better understood the basics of the programming model
I didn't realize that what I was looking for was somewhere inside https://docs.sui.io/build/move. On first glance, I thought that page was going to be more theoretical, so I skipped over it. The most useful part for me was the "Writing a package" section. Shortly after going through it and doing my own tinkering, a bunch of concepts clicked into place.

Suggestions:

Have a hello world example come very early in onboarding. I like the one Solana has here: https://github.com/solana-labs/example-helloworld.

I think it's important that this example actually gives you a functional project that does something and which you can start editing on your own to produce different effects.
The basic example we currently have is hidden in a page and has no logic.

Create a series of these examples, each demonstrating a new topic.

Each example should be its own project, each able to be cloned / edited / redeployed.
This is what Anchor does well: https://project-serum.github.io/anchor/tutorials/tutorial-1.html#clone-the-repo. Notice how there are different tutorials to demonstrate the early concepts devs must learn. For each tutorial, users are asked to clone an example repo, then are taught basic concepts demonstrated by the example, which the dev can deploy + run + verify on their own.

Walkthroughs for more complex examples like tictactoe could perhaps have their own section, or be later in a tutorial series

This is excellent, concrete input Kyle. I appreciate it immensely and will review it and the tutorials you recommend above in preparation for our meeting tomorrow. Thanks so much!

I'm noting we are on the path to:
Identify the audiences/users
Outline respective workflows of users
Draft instructions for enabling most common workflows
Test instructions internally
Conduct user testing and case studies
Xun has made excellent progress here:
https://github.com/MystenLabs/sui/blob/main/doc/src/build/programming-with-objects/index.md
With notes on that content in:
https://app.golinks.io/programming-objects-series-notes
We are tracking details in:
Sui Critical User Journeys Task List
https://app.golinks.io/sui-cuj-doc
Which is resulting in a restructure of both the Learn and Build sections, to be tracked in separate issues I will reference here.

Adding Sam to review these PRs per Adam before I merge:
https://github.com/MystenLabs/sui/issues/1362
https://github.com/MystenLabs/sui/issues/1363

+Godwin
Hi all,
Just catching you up on progress. We are soon to embark upon:
https://github.com/MystenLabs/sui/issues/1363
https://github.com/MystenLabs/sui/issues/1362
In preparation for the likely breakage that will ensure - despite my best efforts, grep, etc. - I am installing other external link checkers and fixing up issues encountered when running them. We need a clean baseline before shifting things about.
To this end, I've reviewed and starting fixing issues reported in Francois' excellent CI link checker:
https://github.com/MystenLabs/sui/pull/1766
https://github.com/tcort/markdown-link-check/issues/91
And documented our various tools for link checking in a new section near the bottom of:
https://app.golinks.io/dev-portal-work
Note the TODOs to better route these issues to the Docs team. Much, much more to come.

I should note an outstanding concern is catching broken named anchors, ex. page-name#new-anchor. I haven't found a reliable solution for those yet.
Also, Godwin please do let me know how and where to add redirects. Thanks!

Godwin, here is that text file output from linkchecker showing the broken image:
404s-in-live-site.txt
Start checking at 2022-05-11 14:16:31-007

URL        `/img/Sui-logo-blue.png'
Parent URL https://docs.sui.io/_nuxt/css/9baafdd.css, line 4, col 70228
Real URL   https://docs.sui.io/img/Sui-logo-blue.png
Check time 2.864 seconds
Size       1KB

See more progress in:
https://github.com/MystenLabs/sui/issues/1362
https://github.com/MystenLabs/sui/issues/1363

And @joyqvq too!

More external contributions, found on Discord in the #content channel:
https://medium.com/@megalodonear/sui-installing-node-step-by-step-guide-for-beginners-5c766ce94ab9
See also the already outdated:
https://cryptech-nodes.medium.com/sui-installation-bff21222bcad
And from our very own Lu:
https://app.golinks.io/local-net-flow
The latter two already noted in:
https://github.com/MystenLabs/sui/issues/1362
We are starting to evaluate a full-blown contributors program in:
https://github.com/MystenLabs/sui/issues/3380

Release note request tracked in:
https://github.com/MystenLabs/sui/issues/3313

Another external doc with potential:
https://mirror.xyz/0xf3bF9DDbA413825E5DdF92D15b09C2AbD8d190dd/WfE7EVJ3xtG0gPPbB8xG_3lswshWfJH-Pgps9CsA7UU

Adding this user-generated doc from @huitseeker as a solid contribution.
Will likely peel off the Community endeavor in a distinct sub-issue.

I believe we have accomplished all we set out to do here. Work continues in the Build docs refactor issue:
https://github.com/MystenLabs/sui/issues/1362
And the new Contributors issue:
https://github.com/MystenLabs/sui/issues/3901


Quantization for MMDet and MMSeg

Hi, I have a question about this quantization scheme for mmdet and mmseg.
There are only config files for mmcls, but no references for mmdet and mmseg.
How can I use this quantization scheme for them?
For example, there is "skipped_methods" field in config file,
and If I want to quantize mmdetection models, it should be modified.
But I don't know what methods in mmdet should be "skipped"... (Maybe the skipped methods are not seperated now.)
Or, if you have any plans for the support, please let me know.
Thanks

Could anyone answer this question?

Sorry for the late reply because of health reasons. quantize branch is WIP now, we will update it with more complete functions and docs as soon.

Hey! great ppl!
any updates quantize branch for mmseg? i mean qat algorithm
doc will be satisified enough;)
many thks

Hey! great ppl!
any updates quantize branch for mmseg? i mean qat algorithm doc will be satisified enough;)
many thks

btw hope u guys feel better now

still no doc has been updated?
could anyone help for doing quantization among mmseg via mmrazor?
sos

still no doc has been updated? could anyone help for doing quantization among mmseg via mmrazor?
sos

Did you know how to quantize mmseg in mmrazor now? If you do know, please give me a simple example, thanks so much.

If mmdet models' QAT is supported, please let me know. Someone help for the config about the combination of backbone,neck and head?

Hi, is there an update for QAT with mmdet ?


Submissions for 'vshare' are lost

Translations submitted to the vshare plugin are lost. They are never committed and proposed in a PR.
See for more info at https://github.com/splitbrain/dokuwiki-plugin-vshare/issues/16

Seems caused by issue covered by #67, so closing this.


Support to return prometheus metrics with instance label

Why are the changes needed?

For my use case, the instances are not human readable, so I prefer to return the FQDN.

How was this patch tested?

Integration testing.
(base) ➜  dist git:(prometheus_label_2) cat conf/kyuubi-defaults.conf
kyuubi.metrics.prometheus.metrics.instance.enabled=true
kyuubi.zookeeper.embedded.client.port.address=localhost
kyuubi.frontend.bind.host=localhost

Was this patch authored or co-authored using generative AI tooling?

No.

Codecov Report
Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (d50cf17) to head (d24571c).
Report is 4 commits behind head on master.

Files with missing lines
Patch %
Lines

...che/kyuubi/metrics/PrometheusReporterService.scala
0.00%
28 Missing :warning:

.../scala/org/apache/kyuubi/metrics/MetricsConf.scala
0.00%
5 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6864   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         687     687
  Lines       42473   42504   +31
  Branches     5796    5798    +2
======================================
- Misses      42473   42504   +31

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks, merged to master/1.10


Article

@maximilianmetti The paper in paper.md and everytime you push into the branch in compile the pdf in the action tab.
IMPORTANT DO NOT MERGE

Cool.  I'm wondering where the best place for us to store and iterate on this is... what was the platform that you mentioned before that you used for latex?  I think it would be really easy to convert it to markdown from latex...


Docker install support

Installation of Dagda using Docker containers, including the Mongo database (vulndb) and a container for Dagda (dagda), using docker-compose.
The docker socket is shared with the Dagda container, so it is possible to check docker images and containers from the host where docker-compose is executed.
$ docker-compose build
$ docker-compose run --rm dagda vuln_db.py --init
$ docker-compose run --rm dagda check_docker_image.py -c <container_id>

Coverage remained the same at 24.28% when pulling 1deb3ae8696b2894f32f36d6fee2625a8e06bfda on jaguasch:docker into 4df3adb2d36ac0e9042dcfec34e798c9ea17d5da on eliasgranderubio:master.

Coverage remained the same at 24.28% when pulling 1deb3ae8696b2894f32f36d6fee2625a8e06bfda on jaguasch:docker into 4df3adb2d36ac0e9042dcfec34e798c9ea17d5da on eliasgranderubio:master.


Star Wars FFG Roll20 - Dice not rolling

I selected the api compatible character sheet for my game room through game settings. I launch the game and I add a character sheet and it shows me the sheet but the buttons on the sheet seem to not activate? Am I missing something?

Pretty sure you need to create roll tables or use some API with the sheet. Ask help on the Roll20 forums in the "Character Sheet" subforum.

From your game's homepage (where you launch it)

Click Settings
Click API Scripts
In the search type: Star Wars
Select Star Wars: Fantasy Flight Games - Dice Roller

Once it's added, you can launch your game and the die roller should work as expected.

As this isn't an actual bug with he sheet, this issue could be closed as solved.


[Question]: How to Achieve Parallel processing in SentenceSplitter

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I have below simple implementation of SentenceSplitter:
# chunking logic here
splitter = SentenceSplitter(chunk_size=conf.chunk_size, chunk_overlap=conf.chunk_overlap)
for node in splitter.split_text(scrap["scrap_text"]):
   # adiitonal processing like trash removal etc goes here

The above code runs on Apache Spark. Still I am not seeing any parallelism happening in the SentenceSplitter level. Is this the expected behaviour or am I doing something wrong?
If want to parallelize SentenceSplitter, is IngestionPipeline only option or can I do that without using IngestionPipeline?

I would use multiprocessing 🤷🏻
def split(x):
  splitter = SentenceSplitter(...)
  return splitter(x)

from multiprocessing import Pool

with Pool(5) as p:
    results = p.map(split, [doc2, doc2, doc3, ...])

@logan-markewich thanks for quick hint, however I think my issue is slightly different. The code block you shared does the parallelism for the number of docs. That I am getting from the Apache Spark workers.
But my question is how can I split each document and do some transformation in parallel ? Sorry if I was not clear before.

So you want to split the document into pieces and then run nodes in parallel/batches? The solution will be the same as above, or use the ingestion pipeline. I don't know how that translate to apache spark workers, never used that before

So you want to split the document into pieces and then run nodes in parallel/batches? The solution will be similar as above, or use the ingestion pipeline. I don't know how that translate to apache spark workers, never used that before

@logan-markewich Yes you got it right.

To achieve parallel processing for splitting each document into chunks and performing transformations on those chunks within Apache Spark, you can follow a structured approach leveraging Spark's distributed data processing capabilities:

Distribute Your Data: Create a Resilient Distributed Dataset (RDD) or a DataFrame with your documents to distribute them across the Spark cluster.

# Assuming `sc` is your SparkContext and `data` is your list of documents
rdd = sc.parallelize(data)

Define Transformation Function: Implement a function that applies the SentenceSplitter to split the document and then performs any additional processing required on the chunks.

def process_document(document):
    splitter = SentenceSplitter(chunk_size=conf.chunk_size, chunk_overlap=conf.chunk_overlap)
    chunks = splitter.split_text(document)
    # Perform additional processing on chunks here
    return processed_chunks

Apply Transformations in Parallel: Use the map function to apply your process_document function to each document in the RDD, enabling parallel processing of the document splitting and transformations.

processed_rdd = rdd.map(process_document)

Collect or Store the Results: After processing, you can collect the results back to the driver program or store them in an external system.

results = processed_rdd.collect()

This method utilizes Spark's parallel processing capabilities to distribute the workload across the cluster, ensuring that each document is split and processed in parallel. The actual parallelism level will depend on your Spark cluster's configuration, such as the number of worker nodes and cores per node.
Details
To continue the conversation, mention @dosu.

I have something like this already :
df = spark.read\
           .format("kafka")\
           .option("kafka.bootstrap.servers", conf.kafka_brokers)\
           .option("kafka.security.protocol", "PLAINTEXT")\
           .option("failOnDataLoss","false")\
           .option("subscribe", conf.kafka_topic_name)\
           .option("startingOffsets", json.dumps(offsets))\
           .option("endingOffsets", json.dumps(end_offsets))\
           .load()
   rdd = df.foreach(apply_cleanup_and_store)

Now the apply_cleanup_and_store looks like this :
def apply_cleanup_and_store(row):
   # Some preprocessing
   ..
   # chunking logic here
   splitter = SentenceSplitter(chunk_size=conf.chunk_size, chunk_overlap=conf.chunk_overlap)
   for node in splitter.split_text(scrap["scrap_text"]):
      # adiitonal processing like trash removal etc goes here
      ..
      # Store into vector DB

So apply_cleanup_and_store runs on Spark executors. What I want to paralleize is this for loop :
for node in splitter.split_text(scrap["scrap_text"]):


Unable to grant accessibility permissions to Apple Notes

Description
Hi, I am using AppleScript to control Apple Notes. On the macOS runner, the AppleScript doesn't work which I figure is because of the accessibility permission grant not being there for Apple Notes. I looked for ways to grant it in the workflow file programmatically.
I tried this:
sqlite3 $HOME/Library/Application\ Support/com.apple.TCC/TCC.db "INSERT OR REPLACE INTO access VALUES('kTCCServiceAppleEvents','/usr/local/opt/runner/provisioner/provisioner',1,2,3,1,NULL,NULL,0,'com.apple.Notes',X'fade0c000000002c00000001000000060000000200000010636f6d2e6170706c652e66696e64657200000003',NULL,1592919552);"

This succeeds but my Apple Script times out.
Then I tried this:
sqlite3 "/Users/runner/Library/Application Support/com.apple.TCC/TCC.db" "insert into access (service, client, client_type, auth_value, auth_reason, auth_version, indirect_object_identifier_type, indirect_object_identifier) values ('kTCCServiceAppleEvents', '/bin/bash', 1, 1, 2, 0, 0, 'com.apple.Notes')"

Same thing, succeeds but Apple Script times out.
I do try to run osascript -e 'tell application "Notes" to activate' which makes no difference.
I suspect the grant is not given yet.
I looked at similar threads like this one:

https://github.com/actions/runner-images/issues/553#issuecomment-648109166
https://github.com/actions/runner-images/issues/3286

The first one's command is for older macOS version that is on the image now and no longer works due to a change in the TCC DB structure. My scripts above reflect the new structure.
How can I make it possible to script Apple Notes via AppleScript on the macOS runner? How do I debug stuff on it to be able to tell what is happening?
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[X] macOS 13
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
macos-latest
Is it regression?
No idea
Expected behavior
The permission is granted and the AppleScript works and controls Apple Notes.
Actual behavior
The grant is seemingly added to the TCC DB but the Apple Script times out.
Repro steps

sqlite3 "/Users/runner/Library/Application Support/com.apple.TCC/TCC.db" -cmd ".headers ON" "select * from access where service = 'kTCCServiceAppleEvents'" to check the structure
sqlite3 "/Users/runner/Library/Application Support/com.apple.TCC/TCC.db" "insert into access (service, client, client_type, auth_value, auth_reason, auth_version, indirect_object_identifier_type, indirect_object_identifier) values ('kTCCServiceAppleEvents', '/bin/bash', 1, 1, 2, 0, 0, 'com.apple.Notes')" to grant the permission
osascript -e 'tell application "Notes" to activate' and osascript -e 'tell application "Notes" to name of every note in every folder'

Hey @TomasHubelbauer. Thank you for reporting, we will take a look.

Hello @TomasHubelbauer . I made some changes in sql query and it works using provided repro steps. Can you try it?
 sudo sqlite3 $HOME/Library/Application\ Support/com.apple.TCC/TCC.db "INSERT OR REPLACE INTO access VALUES('kTCCServiceAppleEvents','/usr/local/opt/runner/provisioner/provisioner',1,2,3,1,NULL,NULL,0,'com.apple.Notes',X'fade0c000000002c0000000100000006000000020000000f636f6d2e6170706c652e4e6f7465730000000003',NULL,1592919552);"

You can see the failing run here:
https://github.com/TomasHubelbauer/apple-notes-database/actions/runs/6048441753/job/16413788595
The command itself ran fine, but the AppleScript timed out. Have I missed a step?

You can see the failing run here: https://github.com/TomasHubelbauer/apple-notes-database/actions/runs/6048441753/job/16413788595
The command itself ran fine, but the AppleScript timed out. Have I missed a step?

Here is workflow with successful run
https://github.com/sergei-pyshnoi/workflow_test/actions/runs/6074554201/job/16478847170

jobs:
  build:
    runs-on: macos-13
    steps:

      - name: check-directory
        run: |
          sudo sqlite3 $HOME/Library/Application\ Support/com.apple.TCC/TCC.db "INSERT OR REPLACE INTO access VALUES('kTCCServiceAppleEvents','/usr/local/opt/runner/provisioner/provisioner',1,2,3,1,NULL,NULL,0,'com.apple.Notes',X'fade0c000000002c0000000100000006000000020000000f636f6d2e6170706c652e4e6f7465730000000003',NULL,1592919552);"
          osascript -e 'tell application "Notes" to activate'
          osascript -e 'tell application "Notes" to name of every note in every folder'

@sergei-pyshnoi I am using your snippet verbatim (literally copy-pasted it to my workflow file) and I am unable to reproduce your success:
https://github.com/TomasHubelbauer/apple-notes-database/actions/runs/6075355558/job/16481368183
But I realized it is probably because you are using the beta macos-13 runner image while I am using macos-latest. Is this only possible in the beta image? Is there a way to make it work for macOS 12?

Hello @TomasHubelbauer . Sorry for the late response . Unfortunately provided workaround will work only with macos-13. Please those for your pipeline. Regarding exits from beta, please follow the announcements. I am closing this issue for now, but if you have additional feel free to ask.


Bad responses: LinkAThonGrpcTrimmedAndR2R, LinkAThonGrpcTrimmedAndR2RSingleFile

Some scenarios return errors:

Scenario
Environment
Last Run
Errors

LinkAThonGrpcTrimmedAndR2R
Linux, Physical, http, KestrelSockets
9/27/19 1:39:45 AM +00:00
54466

LinkAThonGrpcTrimmedAndR2RSingleFile
Linux, Physical, http, KestrelSockets
9/27/19 1:41:25 AM +00:00
400998

Logs

@rynowak took a look at these, and they just don't work, it's not an issue with the benchmarks. Right now I could just disable them if we don't want to get notified by the bot.


Remove CSS loaders

As per @davidpmccormick's suggestion on https://github.com/wellcomecollection/wellcomecollection.org/pull/7041
Branched off https://github.com/wellcomecollection/wellcomecollection.org/pull/7041 so there were no conflicts, once https://github.com/wellcomecollection/wellcomecollection.org/pull/7040 is reviewed & merged we can collapse this stack

That's annoying – when you remove things it's supposed to make the code smaller!

afaict we don't have any css anywhere that we might be loading, and I couldn't see any issues, but will be thorough about checking stage


generate Enum value description attribute based on GraphQL schema [StrawberryShake]

expected result
public enum EISAccountType
{
    [Description("Adjustments Equity")]
    AdjustmentsEquity,
    [Description("Adjustments 1")]
    Adjustments,
    ExcessCash
}

schema
enum EISAccountType {
  "Adjustments Equity"
  ADJUSTMENTS_EQUITY
  "Adjustments 1"
  ADJUSTMENTS
  EXCESS_CASH
}

We will not generate the description attribute from the server. We will however generate xml documentation.


Minor typo fix

s/can teach use/can teach us/

Hi @cgpotts ,
In the same file (vsm_01_distributional.ipynb), it says
The result is the same (in terms of rank order) as one gets from first normalizing both vectors using $\|\cdot\|_{2}$ and then calculating their Euclidean distance.

Could it be that what you meant was s/Euclidean distance/Cosine distance/?
I got this
abc_comparisons(ABC_normed, vsm.cosine) == abc_comparisons(ABC, vsm.cosine)

Thank you,

One more question from the same file (vsm_01_distributional.ipynb)
So, in building in the length normalization, cosine distance achieves our goal of associating A and B and separating both from C.

Should be read like this?  in building in the length normalization is not quite clear to me.
So, by *using* the length normalization, cosine distance achieves our goal of associating A and B and separating both from C.

@insop Thank you for these corrections – much appreciated!
With regard to the comment:

Should be read like this? in building in the length normalization is not quite clear to me.

I think "build in" is a useful metaphor here – the length normalization is an intrinsic part of the measure.
With regard to the comment

Could it be that what you meant was s/Euclidean distance/Cosine distance/?

It says what I intended! Your observation is correct as well, but it makes a different point, namely, that normalizing cosine has no effect because it is already normalizing all values around the unit sphere. My observation, by contrast, makes a connection between cosine and euclidean.

@cgpotts
Thank you for the clarification.


Query Utility - 'Invalid column type' error when querying for any boolean field.

For some reason we are getting 'Invalid column type' error when querying for any boolean field via Query Utility. Other types of fields are working fine, and no problems when pushing booleans to Data Cloud, it is just querying via Util is failing.

Thanks for the detailed feedback! @avesolovksyy :-) I will look into it when I have some free time.


Documentation View: Font Color/Size Does Not Work

Describe the bug

In the documentation view, if the font color/size is changed, the font does not change.

To Reproduce
Steps to reproduce the behavior:

Go to the lab.
Click on Documentation View.
Switch to different font colors/sizes and check the font.
See the bug.

Expected behavior

Font color/size should change.

GIF

Device information

Type: Laptop
OS: Windows 10
Browser: Google Chrome

This seems to be a bug of the WYSIWYG library we currently use. A fix in that or using another library entirely would be necessary. We might reopen in the future.


[Suggestion] More customization

The option of creating new particles
choose particles for blocks more than just sparkling textures (like the shiny ores)
and also options to change the slime particle color, for resourcepacks that change the slime color

I would love this! I like to change the slime color to Orange.

I too would very much like the ability to change the particle colour
I had a dig through the jar and it appears the colours are handled within the mod as apposed to the texture because my first thought was that I'd manually change it myself

There also seems to be a somewhat hardcoded list of particle effects, so using a resource pack to try and add new effects also doesn't work. I created a resource pack to change effects, and while I was able to change the texture of the particles, when I created an identical copy of the bone.json file called bone2.json, I was unable to assign it to any entity.


Add scale information to plots

when plotting spatial information, scale information is. We should discuss if we can add this to our plots if scale information is available. E.g. in sq.pl.co_occurrence, mark distance with actual units.
It might be more appropriate to raise this issue at scanpy actually, because it mainly concerns sc.pl.spatial, but discussing here might not hurt.

@hspitzer do you have code for doing this easily? I think it would make sense to import in squidpy the sc.pl.spatial function from scanpy, and allow for this addition as well as plotting across multiple slides as discussed in #332

it's coming real fast with #437


Use memory type index for memory allocations

Use the index of the memory type in the memory properties array instead of passing the actual memory type struct on memory allocation.
Pros:

More robust compared to passing actual struct (can't pass bogus data)
Easier for vulkan portability
Remove redundant id field in MemoryType

Cons:

User could cause out-of-boundary exceptions at runtime

On the API side it's probably the same for the user, I would say even a bit nicer with indices.

Addressed all points
bors r=kvark


Feature/1214 toast dark mode

Summary of the changes
Added toast theme prop and added light and dark mode tokens.
Wasn't really sure how to deal with the fact that 90% of the tokens are the same in light and dark mode - I decided to just keep it consistent with other components and added the three lots of all the tokens to color-mode.css. Means there is a lot of repeated code but hopefully this is ok
Related issue
Part of #1214
Checklist
General

[x] Changes to docs package checked and committed.
[x] All acceptance criteria reviewed and met.

Testing

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.
[x] Playground stories in React Storybook up to date, with any prop changes and additions addressed.
[x] Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

[x] Min/max content examples tested with no loss of content or overflow.
[x] All prop combinations work without issue.
[x] Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
[x] Controlled and uncontrolled input components tested.
[x] Props/slots can be updated after initial render.

Please correct me if I'm wrong, but I don't see any difference in toast in light and dark mode. If there's no difference, there shouldn't be a theme prop applied to toast as it has no effect. If all the tokens for toast are the same no matter the mode, then they should be moved to the colors.css file similar to classification banner

Ah ok makes sense - yep it's only the values of the tokens for the toast heading and message which change, but all others stay the same. I will remove the prop and move the other tokens into colors.css 👍

Please correct me if I'm wrong, but I don't see any difference in toast in light and dark mode. If there's no difference, there shouldn't be a theme prop applied to toast as it has no effect. If all the tokens for toast are the same no matter the mode, then they should be moved to the colors.css file similar to classification banner

Ah ok makes sense - yep it's only the values of the tokens for the toast heading and message which change, but all others stay the same. I will remove the prop and move the other tokens into colors.css 👍

Actually ignore me about keeping those tokens in - I understand I can just change the token values for the heading and message to always be white. Will sort it


TypeDefiners must also support RequiredImports

Definitions have code associated with them, so they need to have the ability to modify a files set of imports. Specifically struct_definition can produce the metav1 import, and may produce other imports in the future.
Also a minor modification to how we are excluding some types to be slightly more efficient.

Pull Request Test Coverage Report for Build 147887173

-24 of 24 (0.0%)  changed or added relevant lines in 4 files are covered.
190 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-3.6%) to 31.03%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

hack/generator/pkg/astmodel/enum_definition.go
0
3
0.0%

hack/generator/pkg/astmodel/simple_type_definer.go
0
3
0.0%

hack/generator/pkg/astmodel/struct_definition.go
0
8
0.0%

hack/generator/pkg/astmodel/file_definition.go
0
10
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/zips/env.go
3
0%

pkg/zips/types.go
25
54.76%

pkg/zips/client.go
75
3.96%

pkg/zips/template.go
87
26.32%

Totals

Change from base Build 145995486:
-3.6%

Covered Lines:
1675

Relevant Lines:
5398

💛  - Coveralls


Configuration validation not taking entitiesTs into account

Describe the bug
During configuration validation process (see code), If I were to configure entitiesTs but lefted out entities, then the configuration validation would fail. Adding a non-sense entry to entities array fix the issue.
Stack trace
No stacktrace

To Reproduce

Using normal node environment, install mikro-orm cli and use following configurations:

mikro-orm.config.ts
module.exports = {
    type: 'postgresql',
    //entities: ['./src/entities'],
    entitiesTs: ['./src/entities'],
    dbName: 'postgres',
};

Run mikro-orm CLI Command using ts-node

MIKRO_ORM_CLI_USE_TS_NODE=true MIKRO_ORM_CLI=mikro-orm.config.ts ts-node $(which mikro-orm) debug
Expected behavior
The command exit without error.
Actual Behaviour
Configuration validation failed.
Current MikroORM CLI configuration
 - dependencies:
   - mikro-orm 4.5.10
   - node 16.13.1
 - package.json not found
 - searched config paths:
   - /home/pipat/Workspace/sec2_ChocoTech/apps/doji-backend/mikro-orm.config.ts (found)
   - /home/pipat/Workspace/sec2_ChocoTech/apps/doji-backend/mikro-orm.config.js (not found)
- configuration not found (No entities found, please use `entities` option)

Additional context
When the config was changed to
module.exports = {
    type: 'postgresql',
    entities: ['./src/entities'],
    entitiesTs: ['./src/entities'],
    dbName: 'postgres',
};

The command output became:
Current MikroORM CLI configuration
 - dependencies:
   - mikro-orm 4.5.10
   - node 16.13.1
 - package.json not found
 - searched config paths:
   - /home/pipat/Workspace/sec2_ChocoTech/apps/doji-backend/mikro-orm.config.ts (found)
   - /home/pipat/Workspace/sec2_ChocoTech/apps/doji-backend/mikro-orm.config.js (not found)
 - configuration found
 - will use `entities` array (contains 0 references and 1 paths)
   - /home/pipat/Workspace/sec2_ChocoTech/apps/doji-backend/src/entities (found)
 - could use `entitiesTs` array (contains 0 references and 1 paths)
   - /home/pipat/Workspace/sec2_ChocoTech/apps/doji-backend/src/entities (found)

Also, mikro-orm schema:update --run works as expected after the change.
Probable cause is missing check in this line
Versions

Dependency
Version

node
16.13.1

typescript
v9.1.1

mikro-orm
4.5.10

Well, entities option is required, this is correct behaviour. You either have only entities (in case you use entity references) or both entities and entitiesTs (for folder based discovery).


Use workstation GC to reduce RAM usage?

It might make sense to switch neonkube related services from server GC to workstation mode to save memory:
https://docs.microsoft.com/en-us/dotnet/standard/garbage-collection/performance#issue-generation-0-is-too-big
These services won't really see high traffic, so this will probably be OK:

[ ] neon-acme
[ ] neon-cluster-operator
[ ] neon-node-agent
[ ] neon-sso-session-proxy

In the future, perhaps we could pass in an environment variable that the containers can use to configure server GC for multi-node clusters,

CLOSING: I poked around and I doubt that we'll save much here: cluster-operator is only 60MB and node-agent is 74MB which isn't too bad.


The program 'node' is currently not installed. To run 'node' please ask your administrator to install the package 'nodejs-legacy'

Operating system and version: Ubuntu 16.04
I did the following:
apt-get update -y
apt-get install build-essential libssl-dev -y
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash
source ~/.profile
nvm install 10.0.0

All commands above were executed successfully under the root user.
root@dev-test2:~# nvm list
->      v10.0.0
default -> 10.0.0 (-> v10.0.0)
node -> stable (-> v10.0.0) (default)
stable -> 10.0 (-> v10.0.0) (default)
iojs -> N/A (default)
unstable -> N/A (default)
lts/* -> lts/erbium (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.22.0 (-> N/A)
lts/erbium -> v12.18.3 (-> N/A)
root@dev-test2:~# which node
/root/.nvm/versions/node/v10.0.0/bin/node
root@dev-test2:~# node --version
v10.0.0

Everything looks right under the root user. However, when i switch user to frontend and node was not found. Here is my code:
root@dev-test2:~# su frontend
frontend@dev-test2:/root$ cd ~
frontend@dev-test2:~$ node --version
The program 'node' is currently not installed. To run 'node' please ask your administrator to install the package 'nodejs-legacy'

I am not familiar with linux, and can anyone do me a favor, i will appreciate your help.

See this issue https://github.com/nvm-sh/nvm/issues/1533#issuecomment-303203372


Typo in the readme

There is a typo in the "Run Simulation Demo" part of the readme.md
It says to "roslaunch ros_control_boilerplate rrbot_simulaton.launch" where as the launch file is name "rrbot_simulation.launch" so the current instruction is missing and "i" in the name of the launch file

This PR is merging the wrong branches - it is attempting to merge two branches from this repo but you meant to propose your own branch. Please try again.

The only branches I can create a pull request with are ones that can compare each other. And the only ones on the list that I can choose from that do compare each other are these different ros distro devel branches. I don't have any branches of my own.

Did you fork this repo and create a PR using a branch from your fork? This current pull request is simply wrong.

Hadn't heard of forking before, so nope hadn't done that.

https://gist.github.com/Chaser324/ce0505fbed06b947d962


Images are blurry only on some monitors

This seems to be an issue with all browsers, but each have different problems. I'm just looking for any kind of help on this.
To see what I'm saying -

go this URL http://guidedtours.devmoore.com/
select "provider"
click "next"
click on "3" in the bottom right
click "next" one time

The language dropdown animation is blurry on most screens (but not all), and most browsers (but not all).
Thank you for any help on this at all!

It's probably because you're using very large images as source files.
When text in an image gets scaled too much, image renderers can't handle it with a good antialiasing.
Have you tried using the assets in their final size?


Still structurally the same. Differences:

Don't write temp files to disk, instead parse & use directly
Maintain control of when evaluation happens, rather than delegated to Manager (which we no longer use)
Use a ticker rather than sleeping

Part of #4

LGTM


Added 301 redirect for URLs not matching suffix

Should fix #7670. Not sure about calling response directly.

Should not this be done in UrlManager instead of UrlRule?

Probably yes.

But then implementation becomes a bit more complicated.

May be this functionality should be even moved to yii\web\Request::resolve() and made optional.

I'm against making it optional (or at least making it off by default) since the issue is common and quite hurts website's SEO.

Closed in favor of #7670


python openai v1.x whisper example shows code from the v0.x library

The v1.x shows v0.x code currently:

It can be updated to
import os
from openai import AzureOpenAI

client = AzureOpenAI(
    api_key=os.getenv("AZURE_OPENAI_API_KEY"),
    api_version="2024-02-01",
    azure_endpoint = os.getenv("AZURE_OPENAI_ENDPOINT")
)

deployment_id = "YOUR-DEPLOYMENT-NAME-HERE" #This will correspond to the custom name you chose for your deployment when you deployed a model."
audio_test_file = "./wikipediaOcelot.wav"

result = client.audio.transcriptions.create(
    file=open(audio_test_file, "rb"),
    model=deployment_id
)

print(result)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: eb848087-6fd8-1078-e649-2f714c760218
Version Independent ID: 02efded5-0ecf-6e88-3422-c3f9381dd636
Content: Speech to text with Azure OpenAI Service - Azure OpenAI
Content Source: articles/ai-services/openai/whisper-quickstart.md
Service: azure-ai-openai
GitHub Login: @eric-urban
Microsoft Alias: eur

@kristapratico
Thanks for your feedback! We will investigate and update as appropriate.

Hello @kristapratico
Thank you for bringing this to our attention! We've initiated a pull request (PR) to address this issue. Once the author reviews the changes, they will be merged, and the updates should go live shortly. Your diligence is much appreciated!

@kristapratico
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.
#Please-close


Collection products replica user caching 317

I want to merge this change because...

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases

very very bad "enter", will create a proper pr differently


Rules for scientific name outlier clean-up

[ ] Where there is a “?” with or without space, before Genus name, remove “?” and check off “Fossil Identification Uncertain”
[ ] Where there is a “?” with or without space, after Genus name, remove “?” and check off “Fossil Identification Uncertain”
[x] Where there is a “(?)” with or without space, after Genus name, remove “(?)” and check off “Fossil Identification Uncertain”
[ ] Move the whole name containing double brackets “()” or single bracket “(“ or “)” around Genus or alternate name to “Additional Taxonomic Information”
[x] Change “spp.” to “sp.”
[x] Change “sp. nov.” to n. sp.
[x] Move names containing a letter or number after “sp.” or “n. sp.” into the “Additional Taxonomic Information”, e.g. Acer sp. 1 or Acanthophyllum sp. B
[ ] Move any abbreviated names with single letter Genus name into the “Additional Taxonomic Information”, e.g. A. borealis
[ ] Move names beginning with “aff.”, “cf.”, “?cf.” into the “Additional Taxonomic Information”
[x] Move names containing “=” into the “Additional Taxonomic Information”
[x] Move names containing “s.l.” into the “Additional Taxonomic Information”
[ ] Move strings containing a comma into the Fossil Notes
[ ] Move names or strings with three or more terms into the “Additional Taxonomic Information” – e.g., subspecies such as “Ammobaculites pacalis pattersoni “, long names like “Amundiptychites n. sp. aff. A. sverdrupi” or strings “an imprint of a cycad pinnule”
[ ] Move names containing the word “fragment” or “fragments” into the Fossil Notes and select “Fragment” under the Fossil Condition in Fossil Identification

Created a rule where by if there is a scientific name but no match in the Fossil Types resource model it is moved to the Additional Taxonomic Information field

These changes have been applied to DLVR and TEST. Please have a look there and we can do any further work necessary.


File directory for tvOS should change from NSApplicationSupportDirector to NSCachesDirectory

Permission is denied when writing data to NSApplicationSupportDirectory in tvOS, should use NSCachesDirectory instead.
Also remove most of the function name with "applicaitonSupport" because it's confusing :
a. some of the functions no longer working for Application Support directory only;
b. those of the functions are managing the sub directory which has nothing to do for upper level directory

Still 5 unit test failures:
	-[FIRInstanceIDKeyPairStoreTest testCachedKeyPair]
	-[FIRInstanceIDKeyPairStoreTest testIdentity]
	-[FIRInstanceIDKeyPairStoreTest testKeyPairCache]
	-[FIRInstanceIDKeyPairStoreTest testKeyPairCache]
	-[FIRInstanceIDKeyPairStoreTest testResetIdentity]

This should fix the intermittent test failure. Also removed .h files from a test target and a redundant .m file in a test target.

Fixed typo and created #2544 for the naming issue.


Save invoicing specific fields to reservation (TTVA-179)

When payment by invoice is requested, we require certain fields to be present in the reservation data. However, these fields are not saved to the Reservation object unless the fields are also included in the metadata set. That is not the case when the customer wants to show those fields only when payment by invoice is requested.
Make sure the invoicing specific fields are required and saved even if they aren't included in the metadata set, when invoice is requested.
Refs TTVA-179

Marked as WIP as IfFound an issue related to this that I'll need to look into.

Marked as WIP as I found an issue related to this that I'll need to look into.

Fixed a problem with updating reservations with a PUT request (e.g. approving reservations) by ensuring the invoicing specific fields are always included in the representation.


Wait function

What feature do you want to get added on the base engine?
instead of having to use a 'runTimer' function everytime i want to delay something, could you add like a wait function so instead it will delay in just that line of code
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

that would only be useful in specific occasions, and even then, just use a onStepHit loop

that would only be useful in specific occasions, and even then, just use a onStepHit loop

what part of da wiki is that under

that would only be useful in specific occasions, and even then, just use a onStepHit loop

what part of da wiki is that under

its not in the wiki, but its very easy to implement. just bear with me i forgot what the code was, also same person, this is an alt

`function onStepHit()
stepthinge = curStep % 16; --random step stuff, it goes from 0-15 not 1-16
--you can change the number to be larger if you want to have something that happens every few sections
--for example if you want something to happen every 2 sections, you would change it from 16 to 32
--and then make an if statement checking for 15 and 31, since one section is 16 steps
if stepthinge == 0 then --resets the counter to go back to 0 at the end of the section
    section = curStep / 16;
end

if stepthinge == 7 then --checks if its halfway through the section and then does a thingie
    --do something
    --you can do as much as you want with these, they are very useful for modcharts
end

end`
here is the code, have fun

`function onStepHit()
stepthinge = curStep % 16; --random step stuff, it goes from 0-15 not 1-16
--you can change the number to be larger if you want to have something that happens every few sections
--for example if you want something to happen every 2 sections, you would change it from 16 to 32
--and then make an if statement checking for 15 and 31, since one section is 16 steps
if stepthinge == 0 then --resets the counter to go back to 0 at the end of the section
    section = curStep / 16;
end

if stepthinge == 7 then --checks if its halfway through the section and then does a thingie
    --do something
    --you can do as much as you want with these, they are very useful for modcharts
end

end`

function onStepHit()
    stepthinge = curStep % 16; --random step stuff, it goes from 0-15 not 1-16
    --you can change the number to be larger if you want to have something that happens every few sections
    --for example if you want something to happen every 2 sections, you would change it from 16 to 32
    --and then make an if statement checking for 15 and 31, since one section is 16 steps

    if stepthinge == 0 then --resets the counter to go back to 0 at the end of the section
        section = curStep / 16;
    end

    if stepthinge == 7 then --checks if its halfway through the section and then does a thingie
        --do something
        --you can do as much as you want with these, they are very useful for modcharts
    end
end

youre welome, have fun, you can close this now

No idea how to do that.


Eq 399 Refactoring Navigator component

What is the context of this PR?
Refactoring the navigation and routing components and consolidating the user action functionality into a single place.
The navigation state object is now an actual state pattern, which maintains the current user position in the questionnaire.
The routing component was actually dealing with user actions which isn't its purpose. That should be handled elsewhere and it should only do routing (which we're yet to implement).
The questionnaire manager was also dealing with user actions making it difficult to isolate how they are processed.
The user actions are now handled by the navigator using a chain of responsibility pattern. This means adding a new user action should simply be a case of creating a new UserAction class and placing it in the correct location in the chain.
I appreciate this is a big refactor but I believe it leads us to a more elegant solution going forward. I'm open to comments as there's definitely still room for improvements.
How to review

Check out this branch
Check all the tests still work
Complete a survey and check nothing is broken

[ ] Do all commits have sensible commit messages?
[ ] Is all new code unit tested?
[ ] Are there integration tests if needed?
[ ] Is there sufficient logging?
[ ] Is there documentation or is the code self-describing?

Who worked on the PR
@warrenbailey

Adding a WIP label but i'd still value some feedback on it.

Looks good so far, although I don't fully understand it all yet.  It makes perfect sense to split the user action processing out from the data, and I'm currently looking at better ways to process the form data in view of the changes we want to make around fields/responses/questions.
Keep going!

Thanks for the feedback @weapdiv-david, if anyone else has time to review I'd appreciate it. Otherwise I'll fix the minor quantified code issues and squash the commits ready for merging.

Rebased and squashed the commits ready for merge. I liked to take this further but wonder if it would be better to merge this now and then make another incremental refactor, otherwise this risks getting out of date with master very quickly.

Coverage increased (+0.6%) to 74.25% when pulling 132a0e4495234ab447a515e670a4385fe8366526 on eq-399-code-smells-navigator into 3ca7eb5759b5729fa276aed9e1da923f296c1a38 on master.

Changes Unknown when pulling 702f0d9a9b9b813a30c3676a1f9d6e3209b32ee2 on eq-399-code-smells-navigator into ** on master**.

Happy to merge this... Any other team members wanting to review it? (clue: you should)

Apart from my comment above 👍 from me.

Fixing code review comments and rebasing

Changes Unknown when pulling 70e44932f55ca35d4dfd94adfdae03acc5430b3e on eq-399-code-smells-navigator into ** on master**.

Happy to merge this LGTM 👍


convert all tests to vitest

This converts the mocha and jest tests to vite test.
I had to create a new asymmetric  matcher for vite because it doesn't have expect.closeTo by default. Added types for this too.
2 package locks have been removed and one added because i think pnpm is being run incorrectly, it should always be done from the root and there should only every be one lockfile in the repo, so sure how things are being handled.
Will look at CI but it looks like an install issue.
Fixed the issue with CI, we can't filter the install if we need install devdeps from root.
Closes #19.

2 package locks have been removed and one added because i think pnpm is being run incorrectly, it should always be done from the root and there should only every be one lockfile in the repo, so sure how things are being handled.

Can this be handled in a separate PR / issue? It was made separate lockfiles on purpose, and I don't think it's needed for this PR

Sure. I'll add vitest as a dep to each package.

Sure. I'll add vitest as a dep to each package.

Are you sure it's necessary? prettier and eslint are only added to the root package and run in the subpackages

Side note, i think the ListFileEntry type might be wrong (or the test is wrong). I'm getting a type error in the test file (mocha didn't have type support so it didn't get flagged) but the test is passing.
test is asserting:
{
  lastCommit: {
    date: "2018-11-14T23:35:08.000Z",
    id: "504939aa53e8ce310dba3dd2296dbe266c575de4",
    title: "initial commit",
  },
  oid: "dc08351d4dc0732d9c8af04070ced089b201ce2f",
  path: ".gitattributes",
  security: {
    avScan: {
      virusFound: false,
      virusNames: null,
    },
    blobId: "dc08351d4dc0732d9c8af04070ced089b201ce2f",
    name: ".gitattributes",
    pickleImportScan: null,
    repositoryId: "models/bert-base-uncased",
    safe: true,
  },
  size: 345,
  type: "file",
}

But the type is:
export interface ListFileEntry {
  type: "file" | "directory" | "unknown";
  size: number;
  path: string;
  lfs?: {
    oid:         string;
    size:        number;
   /** Size of the raw pointer file, 100~200 bytes */
    pointerSize: number;
  };
  lastCommit: {
    author: {
      date: string;
    };
    id:      string;
    subject: string;
  } | null;
  security?: unknown;
}

Note the lastCommit member. The type has an author field but the test case doesn't. The test is passing.

Are you sure it's necessary? prettier and eslint are only added to the root package and run in the subpackages

They aren't run in CI, so I guess people are running pnpm i locally (which will install everything) to run those commands.

Sould all be cleaned up now.

(Seems a test is failing)

sad

oh i know


Update to use AWS SDK v3

This PR updates faraday_middleware-aws-signers-v4 gem to use AWS SDK v3 instead.
The similar work was done in #10, but it was closed without merging.

Coverage remained the same at 100.0% when pulling 6c6c94234f9af6c5143c964a6f3ee4ac1abd93da on misoca:aws-sdk-v3 into 6c872f4a432ac9fe9f9ab060340e2a6be3cfc211 on winebarrel:master.

Thank you! 😃
However I will not update this gem to aws-sdk-v3.
Can you use https://github.com/winebarrel/faraday_middleware-aws-sigv4?

Ah... It was described in #10... Thank you.


Setting both a View and DateRangeChanged Parameter affects the view switch control

To reproduce:
<MudCalendar View="CalendarView.Week" DateRangeChanged="DateRangeChanged" />
@code {
private void DateRangeChanged(DateRange dateRange}
{
// Code here
}
}

The page will load with the calendar showing the week view
Change the view by clicking on month or day
Expected: The view changes to the appropriate month/day view
Actual: The view doesn't change until you click a second time

Not a fix but a workaround:
<MudCalendar @ref="calendar"/>
@code {
    private MudCalendar calendar;

    protected override void OnAfterRender(bool firstRender)
    {
        base.OnAfterRender(firstRender);
        calendar.View = CalendarView.Week;
    }
}

A tried that workaround but it still isn't a complete fix. The buttons in the upper right corner don't update. Click on "Month", the calendar updates, but the Week button is still Variant.Filled, while the others are Variant.Outlined.

Using View="CalendarView.Week" is not the correct way to set a default value in Blazor.  The problem is that you are always trying to set the view to Week.
When you click the Month or Day button the component is changing to that view but then your code is immediately changing it back to Week.
You can set a default value like this:
<MudCalendar @bind-View="_view" />
@code {
      private CalendarView _view = CalendarView.Week;
}

Removing the 'bug' label because I don't think it's a bug.

Thank you. That fixed it for me.


[Core][Model] Add simple_model_runner and a new model XLMRobertaForSequenceClassification through multimodal interface

This PR,

Add a new model XLMRobertaForSequenceClassification (for RAG scenario) https://github.com/huggingface/transformers/blob/v4.42.3/src/transformers/models/xlm_roberta/modeling_xlm_roberta.py
which processes input data through a multimodal interface like the following

outputs = llm.process([{
    "prompt": prompt,
    "multi_modal_data": {
        "xlmroberta": inputs,
    }
}])

Add a new model runner(simple_model_runner.py), I didn't use model_runner.py or embedding_model_runner.py because they have procedures like logits(), sample(), and pooling() that we don't need. Maybe we could find a way to create a more general model runner to support 'any' model
Add SimpleSequenceGroupOutput, SimpleRequestOutput, and SimpleOutput for general output
Tensor-parallel is enabled, but no benefits have been achieved so far
Test case/example added

I have two goals:

To find a way to enable vllm to integrate 'any' model
To replace these models' layers with vllm/layers/* as well as TP/PP to achieve performance improvement

CLOSE #6424
CLOSE #6789

If I'm understanding this PR correctly, you are basically using the multi-modal interface to pass data directly to the model (in this case the input IDs and attention mask). Are you working towards making vLLM function out-of-the-box with generic HuggingFace models?

If I'm understanding this PR correctly, you are basically using the multi-modal interface to pass data directly to the model (in this case the input IDs and attention mask). Are you working towards making vLLM function out-of-the-box with generic HuggingFace models?

Yes, you are right. In fact, I have two goals:

To find a way to enable vllm to integrate 'any' model.
To replace these models' layers with vllm/layers/* as well as TP/PP to achieve performance improvement.

After I replaced XLMRobertaForSequenceClassification's query/key/value linear with QKVParallelLinear, I saw a 15% performance improvement.

Im going to take a look at this over the weekend. Thanks @AllenDou!

mark https://github.com/vllm-project/vllm/issues/6424

/ready

Hello @robertgshaw2-neuralmagic , just a friendly reminder to review this PR when you get a chance,
We want to enable more models through this feature,  thank a lot!

Thanks @AllenDou ! this is on my list

mark https://github.com/vllm-project/vllm/issues/6789

mark https://github.com/vllm-project/vllm/issues/1187 https://github.com/vllm-project/vllm/issues/205

I think @robertgshaw2-neuralmagic has been very busy lately... Are you still interested in implementing this? Let's split the PR into smaller parts that are more manageable so that @robertgshaw2-neuralmagic doesn't have to review everything at once.
(By the way, please take into account the changes from #4942.)

I think @robertgshaw2-neuralmagic has been very busy lately... Are you still interested in implementing this? Let's split the PR into smaller parts that are more manageable so that @robertgshaw2-neuralmagic doesn't have to review everything at once.
(By the way, please take into account the changes from #4942.)

Of course, after reviewing https://github.com/vllm-project/vllm/pull/4942, I realized that nm folks have their own methods for supporting 'anymodel'. So, I think maybe I should close this PR. If this feature is needed in the future, I can reopen this PR at any time.

Hey @AllenDou Im really sorry for the delay here, have had no bandwidth
#4942 is only for encoder-decoder, which is separate from the implementation here, so I think we should be able to include both

Hey @AllenDou Im really sorry for the delay here, have had no bandwidth over the past month
#4942 is only for encoder-decoder, which is separate from the feature here, so I do not think this work is a duplicate
I’m happy to pick this back up if you want to reopen the PR

Great, I'll resolve the conflicts and reopen the PR, I hope this won't take up too much of your time :)

Thanks so much, I really appreciate your patience. Resolving our performance issues has just become a huge priority

wwww

Hi @robertgshaw2-neuralmagic , I have rebased and reopened this PR. Please take a look at it. The offline_inference_xlmroberta_awq.py file is a quantized version I've been working on, but I'm encountering some technical difficulties that are proving challenging to overcome. So, this file could be removed if necessary. cc @DarkLight1337

offline_inference_xlmroberta_awq.py is deleted, as after hacking autoawq for xlmroberta model, I see no gain of performance benifit under vllm serving. Trying to fp8.

@AllenDou @robertgshaw2-neuralmagic @DarkLight1337
Is there any timeline on when this could be delivered?

@AllenDou @robertgshaw2-neuralmagic @DarkLight1337 Is there any timeline on when this could be delivered?

Maybe we should wait until @robertgshaw2-neuralmagic gets a chance to review this PR.

A quick heads-up that the new locations of the model tests have been adjusted in #7820, so please merge from main.

Also @robertgshaw2-neuralmagic do you have any timeframe on when you will be available to review this PR?

@AllenDou Hello, thank you for your contribution. I use concurrency to request services, and there will be a series of error reports, including the following errors:
 File "/share5/projects/llm/finetune-accelerate/inference/tensorrtllm-experiment/sglang/code/vllm_test/vllm_sqclassification/vllm/vllm/model_executor/models/xlmroberta.py", line 721, in forward     batch_size, seq_length = input_shape ValueError: not enough values to unpack (expected 2, got 1)
Can you please help to optimize async requests? Thanks
Note:
I use  http://<IP_ADDRESS>:8081/v1/completions, concurrency = 2,
payload:
{
"prompt": "what time is it",
"model":MODEL_NAME,
"stop": "<\s>",
"max_tokens":128,
"stream": False,
"presence_penalty": 0,
"frequency_penalty": 0,
"temperature": 0.0,
"top_p": 1,
}

@AllenDou Hello, thank you for your contribution. I use concurrency to request services, and there will be a series of error reports, including the following errors:  File "/share5/projects/llm/finetune-accelerate/inference/tensorrtllm-experiment/sglang/code/vllm_test/vllm_sqclassification/vllm/vllm/model_executor/models/xlmroberta.py", line 721, in forward batch_size, seq_length = input_shape ValueError: not enough values to unpack (expected 2, got 1)
Can you please help to optimize async requests? Thanks
Note: I use http://<IP_ADDRESS>:8081/v1/completions, concurrency = 2, payload: { "prompt": "what time is it", "model":MODEL_NAME, "stop": "<\s>", "max_tokens":128, "stream": False, "presence_penalty": 0, "frequency_penalty": 0, "temperature": 0.0, "top_p": 1, }

This PR currently does not support frontend access through the http protocol. By the way, the XLM-Roberta model compares the similarity of two strings. Therefore, you need to pass a tuple containing two strings (string, string) as input. Please refer to examples/offline_inference_xlmroberta.py for more details.

[RFC]: Support encode only models by Workflow Defined Engine #8453

Thanks for your reply, can you tell me how to add support for http requests on your branch? Thank you, or can you add this function if it is convenient for you?

@AllenDou Thanks for your reply, can you tell me how to add support for http requests on your branch? Thank you, or can you add this function if it is convenient for you? My final goal is to need llamaForSequenceClassification based on http request, I have added llamaForSequenceClassification to llama.py with reference to your branch, and implemented the forward function, but currently I cannot make the correct request through http.

Is it accessible via http now?

The test results were not as expected, and the input and output methods were very confusing.

@AllenDou Thanks for your reply, can you tell me how to add support for http requests on your branch? Thank you, or can you add this function if it is convenient for you? My final goal is to need llamaForSequenceClassification based on http request, I have added llamaForSequenceClassification to llama.py with reference to your branch, and implemented the forward function, but currently I cannot make the correct request through http.

Is it accessible via http now?

I apologize for the delayed response. I've been working on cute&ptx recently, therefore, this PR will not be updated for now :(

Closing as superseded by #10400. Sorry your PR didn't make it!


Release v0.29.0

Extract API interfaces for all services and generate mock clients (#740).
Handle empty response for errors (#756).
Update SDK to OpenAPI spec + Fix tests (#755).
Add utility to retry on specific errors (#757).

Note: This release contains breaking changes, please see below.
API Changes:

[Breaking] Changed List method for w.ExternalLocations workspace-level service to require request of catalog.ListExternalLocationsRequest, w.StorageCredentials workspace-level service to require request of catalog.ListStorageCredentialsRequest and w.Tokens workspace-level service to return settings.ListPublicTokensResponse.
Added NextPageToken field for catalog.ListExternalLocationsResponse, catalog.ListFunctionsResponse, catalog.ListSchemasResponse and catalog.ListStorageCredentialsResponse.
Added MaxResults field for catalog.ListFunctionsRequest and catalog.ListSchemasRequest.
Added PageToken field for catalog.ListFunctionsRequest and catalog.ListSchemasRequest.
Added OmitColumns and OmitProperties field for catalog.ListTablesRequest.
Added catalog.ListExternalLocationsRequest.
Added catalog.ListStorageCredentialsRequest.
Added settings.ListPublicTokensResponse.
Added dashboards package.
Added vectorsearch package.

OpenAPI SHA: a7a9dc025bb80303e676bf3708942c6aa06689f1, Date: 2024-01-04
Dependency updates:

Bump google.golang.org/api from 0.153.0 to 0.154.0 (#741).
Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /examples/slog (#747) and /examples/zerolog (#748).
Bump golang.org/x/crypto from 0.16.0 to 0.17.0 (#749).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9632fb2) 18.24% compared to head (aef84ba) 18.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   18.24%   18.24%
=======================================
  Files         109      109
  Lines       14810    14810
=======================================
  Hits         2702     2702
  Misses      11886    11886
  Partials      222      222

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add solution for problem "where Do I Belong"

Closing Issue/Referencing Issue
issue reference (#39)
Changes Made In Pull Request

add solution for question "where do I belong"
*problem url: https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-algorithm-scripting/where-do-i-belong

@Yang8547 please add your name and info in README.md and push again. Thanks


Add Qwertee bridge

I didn't run phpunit because my system is still on Buster.
Buster doesn't have php 7.4 by default yet.

They already have a feed for this: https://www.qwertee.com/rss

My bad, I didn't notice that it got an RSS feed. Thanks for the link.
I will try their RSS feed to see the comportment with the last chance tees. I will give an update here in 1 or 2 days.


Use Jest Configuration

Now that https://github.com/facebook/jest/issues/5957 is merged and release, we can drop jest-puppeteer.config.js and use the Jest configuration.
We have to use testEnvironmentOptions and read configuration from this.
jest-puppeteer.config.js support will be deprecated and removed in the next major version.

It is actually not ready because as mentioned in https://github.com/facebook/jest/issues/5957#issuecomment-422027349, it is not possible to access testEnvironmentOptions in globalConfig.

Other projects use global for plugin-related config. Example: https://kulshekhar.github.io/ts-jest/user/config/#ts-jest-options jest-puppeteer could easily use this pattern too

Hello @lukaszfiszer, unfortunately globals are not accessible in globalConfig, see https://github.com/facebook/jest/blob/master/packages/jest-config/src/index.ts#L104. So we are still stuck with jest-puppeteer.config.js...


ROCKETMQ-214

wrapper the AllocateMessageQueueStrategy with ThreadLocal

later , i will append junit test to verify the function.
if you have better solution , please reply.thanks .

What do you want to fix by setting the allocate strategy as thread local?

yes

if any update for this pr, we will close it~


No Factory graphic in city view

Same seems to apply to Manufacturing Plant.

Hoover Dam also.

Not all buildings have been implemented, there's already a bug report for that: #32
Here's a wiki page on the status of building rendering: https://github.com/SWY1985/CivOne/wiki/Status:-City-view-rendering

Okay.  I'll keep that in mind.  Thanks for the info!

I've added Factory, MfgPlant, Nuclear Plant, SDI Defense and Recycling Center to the city view. :-)

Sweet!  I am loving your work.  Great job!


Bugfixes for SnapPlanner

I made the following changes:

Added the missing absolute value in our distance calculation (#16)
Removed the snap_tolerance parameter and, instead, use the DOF resolutions (#17)
Check collision at the start and end-points of the trajectory (#18)

I am holding off on merging the pull request until I do some more testing. It would also be good to get feedback from @siddhss5.

I switched to collision checking the straight-line trajectory, instead of only allowing short snaps. Instead of implementing the collision detection manually, I call the built-in CheckPathAllConstraints function. This is the same function that built-in OpenRAVE planners (e.g. BiRRT) use to collision check edges. I am not sure whether that function does a bisection test or not.
I also added a few unit tests. The test that checks self-collisions fails. This is quite surprising, because a nearly identical test that checks environment collisions passes.
I haven't been able to figure out why. The logic inside CheckPathAllConstraints is incredibly complicated:

CheckPathAllConstraints calls _checkpathvelocityconstraintsfn on the PlannerParameters struct
The filter options are set to 0xFFFF by default, which includes: (see here)

CFO_CheckEnvCollisions
CFO_CheckSelfCollisions
CFO_CheckTimeBasedConstraints
CFO_BreakOnFirstValidation

_checkpathvelocityconstraintsfn defaults to DynamicsCollisionConstraint::Check
DynamicsCollisionConstraint::Check checks both geometric and dynamic feasibility

Passing empty vectors for dq0 and dq1 seems to disable checks for dynamic feasibility (this case)
There is a suspicious comment that says "this does not check the end config, and may or may not check the start based on the value of 'start'"

Check calls the _SetAndCheckState function, which sets the robot's configuration
_SetAndCheckState calls the _CheckState function to actually do the collision checking

I haven't been able to figure out where in this labyrinth is amiss.
@psigen @siddhss5 @cdellin: Any suggestions?

I switched to collision checking the straight-line trajectory, instead of only allowing short snaps. Instead of implementing the collision detection manually, I call the built-in CheckPathAllConstraints function. This is the same function that built-in OpenRAVE planners (e.g. BiRRT) use to collision check edges. I am not sure whether that function does a bisection test or not.
I also added a few unit tests. The test that checks self-collisions fails. This is quite surprising, because a nearly identical test that checks environment collisions passes.
I haven't been able to figure out why. The logic inside CheckPathAllConstraints is incredibly complicated:

CheckPathAllConstraints calls _checkpathvelocityconstraintsfn on the PlannerParameters struct
The filter options are set to 0xFFFF by default, which includes: (see here)

CFO_CheckEnvCollisions
CFO_CheckSelfCollisions
CFO_CheckTimeBasedConstraints
CFO_BreakOnFirstValidation

_checkpathvelocityconstraintsfn defaults to DynamicsCollisionConstraint::Check
DynamicsCollisionConstraint::Check checks both geometric and dynamic feasibility

Passing empty vectors for dq0 and dq1 seems to disable checks for dynamic feasibility (this case)
There is a suspicious comment that says "this does not check the end config, and may or may not check the start based on the value of 'start'"

Check calls the _SetAndCheckState function, which sets the robot's configuration
_SetAndCheckState calls the _CheckState function to actually do the collision checking

I haven't been able to figure out where in this labyrinth is amiss.
@psigen @siddhss5 @cdellin: Any suggestions?

Yikes! You're not going to like this but I'd suggest we get some 'ground truth' by writing a simple line segment checker on our own, maybe even with just increments.
I was thinking it might be nice to write out the 'checkOrder' function as a generator allowing us explore different orders.
Sidd.
(Rapidly written in motion)

On Jan 1, 2015, at 12:16 PM, Michael Koval<EMAIL_ADDRESS>wrote:
I switched to collision checking the straight-line trajectory, instead of only allowing short snaps. Instead of implementing the collision detection manually, I call the built-in CheckPathAllConstraints function. This is the same function that built-in OpenRAVE planners (e.g. BiRRT) use to collision check edges. I am not sure whether that function does a bisection test or not.
I also added a few unit tests. The test that checks self-collisions fails. This is quite surprising, because a nearly identical test that checks environment collisions passes.
I haven't been able to figure out why. The logic inside CheckPathAllConstraints is incredibly complicated:
CheckPathAllConstraints calls _checkpathvelocityconstraintsfn on the PlannerParameters struct
The filter options are set to 0xFFFF by default, which includes: (see here)
CFO_CheckEnvCollisions
CFO_CheckSelfCollisions
CFO_CheckTimeBasedConstraints
CFO_BreakOnFirstValidation
_checkpathvelocityconstraintsfn defaults to DynamicsCollisionConstraint::Check
DynamicsCollisionConstraint::Check checks both geometric and dynamic feasibility
Passing empty vectors for dq0 and dq1 seems to disable checks for dynamic feasibility (this case)
There is a suspicious comment that says "this does not check the end config, and may or may not check the start based on the value of 'start'"
Check calls the _SetAndCheckState function, which sets the robot's configuration
_SetAndCheckState calls the _CheckState function to actually do the collision checking
I haven't been able to figure out where in this labyrinth is amiss.
@psigen @siddhss5 @cdellin: Any suggestions?
—
Reply to this email directly or view it on GitHub.

Yikes! You're not going to like this but I'd suggest we get some 'ground truth' by writing a simple line segment checker on our own, maybe even with just increments.
I was thinking it might be nice to write out the 'checkOrder' function as a generator allowing us explore different orders.
Sidd.
(Rapidly written in motion)

On Jan 1, 2015, at 12:16 PM, Michael Koval<EMAIL_ADDRESS>wrote:
I switched to collision checking the straight-line trajectory, instead of only allowing short snaps. Instead of implementing the collision detection manually, I call the built-in CheckPathAllConstraints function. This is the same function that built-in OpenRAVE planners (e.g. BiRRT) use to collision check edges. I am not sure whether that function does a bisection test or not.
I also added a few unit tests. The test that checks self-collisions fails. This is quite surprising, because a nearly identical test that checks environment collisions passes.
I haven't been able to figure out why. The logic inside CheckPathAllConstraints is incredibly complicated:
CheckPathAllConstraints calls _checkpathvelocityconstraintsfn on the PlannerParameters struct
The filter options are set to 0xFFFF by default, which includes: (see here)
CFO_CheckEnvCollisions
CFO_CheckSelfCollisions
CFO_CheckTimeBasedConstraints
CFO_BreakOnFirstValidation
_checkpathvelocityconstraintsfn defaults to DynamicsCollisionConstraint::Check
DynamicsCollisionConstraint::Check checks both geometric and dynamic feasibility
Passing empty vectors for dq0 and dq1 seems to disable checks for dynamic feasibility (this case)
There is a suspicious comment that says "this does not check the end config, and may or may not check the start based on the value of 'start'"
Check calls the _SetAndCheckState function, which sets the robot's configuration
_SetAndCheckState calls the _CheckState function to actually do the collision checking
I haven't been able to figure out where in this labyrinth is amiss.
@psigen @siddhss5 @cdellin: Any suggestions?
—
Reply to this email directly or view it on GitHub.

It turns out that CheckPathAllConstraints works fine. There is a more fundamental issue here: CheckSelfCollision returns True in the original environment, but False in the cloned environment. Both environments look identical in the viewer, so this seems to be some sort of cloning issue.

It gets even weirder. This test case works: 808b55ad86b09ded4837bfcda66e8d9eefc82494.

I opened an OpenRAVE issue: https://github.com/rdiankov/openrave/issues/335. I'm out of ideas here, so hopefully Rosen can point us in the right direction.

My guess is that the clone is somehow mangling the adjacency list and skipping some/all link pair collision checks. Does 'verbose' print out enough info to verify this? Or maybe the collision report?
Sidd.
(Rapidly written in motion)

On Jan 2, 2015, at 1:42 AM, Michael Koval<EMAIL_ADDRESS>wrote:
It turns out that CheckPathAllConstraints works fine. There is a more fundamental issue here: CheckSelfCollision returns True in the original environment, but False in the cloned environment. Both environments look identical in the viewer, so this seems to be some sort of cloning issue.
—
Reply to this email directly or view it on GitHub.

Nope. CheckSelfCollision immediately returns false without any logging. It also doesn't fill in the CollisionReport.
Rosen thinks this is related to the assumption that initial configuration of the robot (by default: the zero configuration) is not in self collision. This is used to initialize the adjacency list when loading the robot. I had the same idea, but GetAdjacentLinks() returns the same values before and after cloning.


KAFKA-5579 check for null.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6019/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6004/
Test PASSed (JDK 8 and Scala 2.12).

@ewencp, this is a very simple change and is ready to be merged. Thanks!

LGTM, thanks!


fix(iroh-net): Clear the recent pong time when pong is lost

Description
When we do not receive a pong in the timeframe we should have, we remove the last ping time and clear the best_addr.  However the path will be re-selected from the candidates as long as the pong time is set.
This additionally clears the pong time so that there is no longer an indication this path works.  While the DISCO ping-pong is not loss-protected there is already an existing check that ensures this clear is not triggered when there are still other signs of life from the remote node.
Breaking Changes
None
Notes & open questions
Note that when sending call-me-maybe the pong times are also cleared. So while I'm not a particular fan of this, it is the intended way to use this.  Ideally the PathState would be clearer about this data and store this as separately.  But the PathState data needs a general cleanup and I do not want to mix in extra state for now.
Fixes a bug found by @zh522130
Change checklist

[x] Self-review.
[ ] Documentation updates following the style guide, if relevant.
[ ] Tests if relevant.
[ ] All breaking changes documented.

@flub Thank you for resolving this issue so quickly. I was able to reproduce the problem using the old version where, after stopping the server and restarting it after a while, the client could no longer connect to the server. After switching to the current branch for testing, regardless of when the server is restarted, the client can successfully connect to the server within a few to a dozen seconds. Both local area network (LAN) and wide area network (WAN) tests have shown that this fix has resolved my issue.

Okay, IIUC, the recent_pong setting interacts with assign_best_addr_from_candidates_if_empty. So previously it wasn't set to None, which meant that clearing the best_addr didn't have the desired effect, since it was re-set to a bad address in assign_best_addr_from_candidates_if_empty, right?

correct

late to the party I guess. Docs for recent_pong still state
    /// Last [`PongReply`] received.

which is now factually wrong.
The field's naming is good enough to allow for this, but docs should get adjusted accordingly

Fair, but staring at this to try and improve I have not the faintest idea on how to document this right now.  The best I can do is look at the callsites and describe them.  But like...??
/// Last [`PongReply`] received.
    ///
    /// There are times when this gets cleared: specifically when we think this path is no
    /// longer good at all.  This happens when we are no longer receiving any traffic on it
    /// and pongs no longer arrive.  But also when we are are re-sending pings along all of
    /// the network paths (a "full ping").
    ///
    /// Clearing it ensures that the path won't be considered a candidate because it has a
    /// "recent" pong.

But that's pretty rubbish.  I could make a PR with it though if you like.
What probably should happen is that the PathState cleanup that I wanted to start sometime should continue and instead of what "seleect_from_candidates" does now it should use some form of "does_this_path_work" function (but there are already several that are all weird and wrong in some ways).  But that is also a larger project and I feel more like pushing multipath forward at the moment before deciding which bits of PathState need to be cleaned up.
Sorry, excuses.  I know...

I understand and share the frustration. I'm just unhappy how we are still haunted by go code we didn't design and thus it seems we won't ever fully understand. Rant aside, to reduce the ...awkwardness.. maybe we can just say
/// The most recent [`PongReply`] considered relevant for this path.

/// Previous replies might be cleared when they can't be used to determine the
/// aliveness of this path, or are generally considered no longer relevant.

Basically I'm still leaning on being somewhat vague so that anyone reading this code leaves at least with "I don't fully understand this field, I'd rather have some care using it" vs "I fully understand this field" with an outright wrong idea of its use.

How about
/// The most recent [`PongReply`], if more recent than [`PING_TIMEOUT_DURATION`]

?