Create peering using Resource Manager template failed

Getting this error when creating peering using Resource Manager template, even with Owner role at Subscription level.
Status Message: The client has permission to perform action 'Microsoft.Network/virtualNetworks/peer/action' on scope '/subscriptions//resourcegroups//providers/Microsoft.Network/virtualNetworks//virtualNetworkPeerings/', however the current tenant '' is not authorized to access linked subscription ''. (Code:LinkedAuthorizationFailed)
I use this PowerShell command to create a resource: New-AzResourceGroupDeployment
I'm using this scenario - "Create peering between different subscriptions" :
https://docs.microsoft.com/en-us/azure/virtual-network/create-peering-different-subscriptions#template

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52fe18fe-efc5-3e63-8200-8e20e885b55e
Version Independent ID: 86a4f465-d676-e0e4-7367-2ed9f906340a
Content: Create a VNet peering - different subscriptions
Content Source: articles/virtual-network/create-peering-different-subscriptions.md
Service: virtual-network
GitHub Login: @KumudD
Microsoft Alias: kumud

@AIGARSJ , thank you for your query. May I know if the 2 subscriptions are associated with different Azure Active Directory tenants?
If yes, did you complete the below mentioned in the beginning of the doc:

Yes, 2 subscription are associated with different Azure Active Directory tenants.
User created in one Azure AD tenant and added as guest in another Azure AD tenant, so user can access both tenants with single identity. I can create peering between 2 subscriptions associated with different Azure AD tenants when I use Azure Portal and single user account. But can't achieve same thing with Resource Manager template.
Can I use single user with access in both Azure AD tenants to create a peering with Resource Manager template?

@AIGARSJ , let me check on this and get back to you.

@AIGARSJ , I tried to repro this issue in my lab with single user account created in one subscription & added as guest in another subscription and I am getting the "LinkedAuthorizationFailed" error on both ARM template & Azure portal.

Could you please share the steps that you followed while creating the Vnet peering via Azure portal with single user account, which worked for you?

My steps in Azure Portal:

Create userA in TenantA
Create vnetA in SubsA
Create subnetA in vnetA
Create vnetB in SubsB
Create subnetB in vnetB
Invite userA from TenantA
Assign Network Contributor role to userA (guest) in vnetB
In vnetA create peering vnetA-to-vnetB
Specify Resource ID of vnetB
Specify Directory TenantB
Press Authenticate
Press Add
Login with userA to TenantB (Swith Directory option)
In vnetB create peering vnetB-to-vnetA
Specify Resource ID of vnetA
Specify Directory TenantA
Press Authenticate
Press Add
Done - Peering Status: Connected

@AIGARSJ , so when you try to create the peering via ARM template, you already have assigned the Network Contributor role to userA (guest) in vnetB?

@AIGARSJ , so when you try to create the peering via ARM template, you already have assigned the Network Contributor role to userA (guest) in vnetB?

Yes, I have

Thank you for the update @AIGARSJ .
I checked internally and found the same issue reported by another customer and below is the investigation & solution provided by the product group teams:
Since this operation deals with 2 tenants (2 active directory trees), ARM needs 2 authentication tokens in the request. So when you submit an ARM template using PowerShell or CLI (where you log in only once), you cannot peer 2 VNets that belong to different subscriptions (subscriptions belonging to different tenants). So this is expected behavior.
When peering Vnets that belong to 2 different AAD tenants, user needs to send 2 auth tokens to ARM (so that ARM can check that user has access to VNETs in both subscriptions).
We did some research and found that you need to get the additional tenant token in the context.
For CLI
az login --service-principal --username ${appId} --password ${secret} --tenant ${tenant1}
az login --service-principal --username ${appId} --password ${secret} --tenant ${tenant2}
For PowerShell
Connect-AzAccount -ServicePrincipal -Credential $cred  -Tenant "<Tenant 1 ID>"
Connect-AzAccount -ServicePrincipal -Credential $cred -Tenant "<Tenant 2 ID>"
As can be found here: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/share-images-across-tenants#create-a-vm-using-powershell
This should set an auxiliary token and send that to arm.
x-ms-authorization-auxiliary Auxiliary tokens Bearer , EncryptedBearer , Bearer
You can use other methods for authentication too as explained in the below docs. The important part here is that you log in to both tenants.
https://docs.microsoft.com/en-us/cli/azure/authenticate-azure-cli
https://docs.microsoft.com/en-us/powershell/azure/authenticate-azureps?view=azps-7.0.0
Could you please give the above a try and let me know if this works.
Once you confirm the solution, I will assign this issue to the author to update the doc with this information.

@AIGARSJ , I'm following up on my above comment. Could you please update if you were able to try the recommended solution and what is the outcome?

Thank you! It's works!

@AIGARSJ , thank you for the update and glad to hear that it works now. I will assign the doc to the author for update.
@KumudD , could you please update this doc to include the step to get the additional tenant token for successful authentication between 2 different subscriptions belonging to 2 different tenants before creating the Vnet peering via ARM template?

#reassign: @mbender-ms

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


RTL Keyboard Buttons Position

I prefer using keyboards, but I am unable to position using the right-to-left (RTL) buttons. Is it possible to include an option to use the RTL keyboard button position?
Thanks

@sadegh19b feel free to open a PR for it 👍

@fabio-ivona Thank you for your attention. I wanted to let you know that I have been working on adding right-to-left (RTL) support for the keyboard and have submitted a pull request to this repository (#364). I would greatly appreciate it if you could review my changes, and if they are acceptable, we can mark this issue as complete.


[feature] Increase session timeout

Problem Description
I need to log in multiple times per day in the browser, when using omnictl and kubectl. This was bearable for the first two weeks of using Omni on an almost daily basis, but now it feels that I cannot do anything without needing to log in first.
If I am aware of how many times I need to log in during a day (it's at least 6 by the way), then the friction is too great.
Solution
The ideal session timeout looks like GitHub & gh. I cannot remember the last time that I had to log in.
I don't remember K8s login being noticeable with any of the other managed K8s services.
Could I have the same with Omni please?
Alternative Solutions
Integrate with 1Password.
Notes
No response

WDYT @smira @andrewrynhard ?

There are specific trade-offs between having better security and better UX. Omni was designed around better security.
Every API request to Omni, whether it's frontend or omnictl, is signed by a client private key which needs to be refreshed every 8 hours.
Kubernetes API unfortunately doesn't support request signatures, so it's using expiring JWT token.
So there are roughly three login points, each with 8 hours session timeout iirc. Certainly increasing session timeout is an option, but it will affect security. Our next step is going to be adding support for hardware tokens for auth (YubiKey, etc.)

Any chance of making this timeout configurable, maybe on a per account basis?

I have been using the CLI tools less in recent weeks, no longer an issue for me.


Added  the Uzbek language

Thank you. I will review soon.
Please add tests in the test/definitions/ directory.

This has been deployed in<EMAIL_ADDRESS>Thank you again!


Bug: In task view pressing "t r" doesn't remove due date as expected

In a project view, or today, upcoming etc. pressing "t" and then "r" removes the due date as documented. When viewing an individual task however pressing the same keys just puts an "r" character into the due date text entry box.
This is obviously a minor bug and not a big deal, but it does trip me up every so often, so I thought I'd report it.
Thanks!

Thanks for reporting!  I've noted it down in my todos :)  Should be a straightforward fix, probably will do it this weekend.

Fixed in version 107!


Set flow status to killed when killed by violating job-level SLA

This PR is to solve issue https://github.com/azkaban/azkaban/issues/1371.
When a job is killed by violating SLA and no more retries for that job is available, flow will be set as "Killed" instead of "Failed Finishing".
Currently there's no unit case covering FlowRunner#run, so verified manually, we will add corresponding test in our internal integration test framework.
This PR also includes small reformatting done automatically by save plugin.

Currently there's no unit case covering FlowRunner#run

Huh? What about
https://github.com/azkaban/azkaban/blob/master/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest.java
https://github.com/azkaban/azkaban/blob/master/azkaban-exec-server/src/test/java/azkaban/execapp/FlowRunnerTest2.java

@juhoautio hah, i missed the FlowRunnerTest2.java, thanks!


feat: add rename type in sierra program

#[serde(rename = "type")]
https://github.com/starkware-libs/cairo/blob/ad6aeb70ac0ab6c6c129eb088df682705d4f1853/crates/cairo-lang-sierra/src/program.rs#L232

Can you add any context please?

Hope  ty becomes type
https://github.com/starkware-libs/cairo/blob/ad6aeb70ac0ab6c6c129eb088df682705d4f1853/crates/cairo-lang-sierra/src/test_data/fib_jumps#L1519

I don't think we can or should change this - as this is an existing format - this would break existing file with no real need.

scarb new cairo0408
cd cairo0408
scarb build
tree
.
├── Scarb.lock
├── Scarb.toml
├── src
│   └── lib.cairo
└── target
├── CACHEDIR.TAG
└── dev
└── cairo0408.sierra.json
ty in cairo0408.sierra.json
Hope ty becomes type

I understand your reasoning behind changing name of this field, but it is part of a well-established file format that we do not want to change. It happened as it happened and renaming it is not worth the work.


Fix link on simple-nft-example

The existing link points to the old version, it should point to challenge-0

adding pull request


VSCode Version: 1.32.0
OS Version: Linux (Amazon Linux 2)

Steps to Reproduce:

Update from 1.31
Start VS Code

Does this issue occur when all extensions are disabled?: Yes

The default was changed in 1.32 release (see notes).
To return to previous behavior, change window.titleBarStyle settings option to custom.

No idea why you would bring back that old stuff again, but if I can disable it, fine.


Replace docs typography with OnyxHeadline and OnyxLink component

Replace the typography preview for the docs which was added in #211 with the OnyxHeadline and OnyxLink component once they are implemented.

Headline is already done in #236


[BUG] history api returns empty result for certain item ID.

Querying Market History API of Filtered Water returns
{
  "dcName": "陆行鸟",
  "entries": [],
  "itemID": 6153,
  "lastUploadTime":<PHONE_NUMBER>265,
  "stackSizeHistogram": {},
  "stackSizeHistogramNQ": {},
  "stackSizeHistogramHQ": {},
  "regularSaleVelocity": 0,
  "nqSaleVelocity": 0,
  "hqSaleVelocity": 0
}

But market history records do exist, as querying Market Listing API of Filtered Water returns parts of the market history records in recentHistory.
Querying Market History API with other IDs ( such as 5143 or 7153 ) could get normal results.
I'm not sure if this bug is persistent. At least it occurs for now.

Bug still exists. Any investigation done?

Not yet, I’ve been busy tackling feature requests on something else I’ve been getting bugged about. I had a quick look at it when this issue was opened, because I was expecting to see a duplicate record, but I didn’t find anything out of the ordinary. I’ll look into this more later.

The same issue occurs on item 6152.
I deleted the database entries for both of those - can you try doing an upload and seeing if they update correctly after that?

Item 6152 seems working fine for me. I follow your link and it returns something like
{"dcName":"陆行鸟","entries":[{"hq":true,"pricePerUnit":555,"quantity":3,"timestamp":1625323374,"worldName":"ShenYiZhiDi"},{"hq":false,"pricePerUnit":665,"quantity":99,"timestamp":1625306916,"worldName":"ShenYiZhiDi"},{"hq":true,"pricePerUnit":1288,"quantity":3,"timestamp":1625304694,"worldName":"ShenYiZhiDi"},{"hq":true,"pricePerUnit":600,"quantity":2,"timestamp":1625304196,"worldName":"ShenYiZhiDi"},{"hq":true,"pricePerUnit":1499,"quantity":15,"timestamp":1625288928,"worldName":"ShenYiZhiDi"},{"hq":false,"pricePerUnit":665,"quantity":99,"timestamp":1625249901,"worldName":"ShenYiZhiDi"},{"hq":false,"pricePerUnit":780,"quantity":48,"timestamp":1625239785,"worldName":"ShenYiZhiDi"},{"hq":false,"pricePerUnit":6500,"quantity":1,"timestamp":1625229194,"worldName":"ShenYiZhiDi"},...
For item 6153 (filtered water), I visited the market in game with the universalis act plugin turned on. The web frontend shows that the data was uploaded ( the most recent upload time appeared to be several seconds ago ), but the api I mentioned above  still returns empty result after that upload.

I made a modification to the upload code, can you try it one more time now and see if that fixes it?

I uploaded several times but the history api still returns empty results.

I haven’t been able to figure it out yet, so I’ll begin implementing a bigger database change that I’ve been planning for a while to fix this, removing the DC info and just building this from the world info. Should be done in a couple of days at most.

Does this change mean that the structure of the return value of the history api will also change?

It will not have a different structure, but I might have more entries on it depending on how fast it ends up being.

Okay. Thanks for your hard work!

Implemented through #447 #448 #449 - should be fixed now, how does it look?

It works fine now. Thanks!


fix url in metainfo

Coverage decreased (-15.3%) to 63.182% when pulling c691954bee436b1733c01bee731ab835690c782b on fix-metainfo into d0648b4d22e70abf8c5cb8f86d54d44c5b7e6f17 on master.

/cc @sipayRT, @eGavr

Coverage decreased (-1.4%) to 77.048% when pulling a5a40a07291568394f0189be1e875c8169e449a0 on fix-metainfo into d0648b4d22e70abf8c5cb8f86d54d44c5b7e6f17 on master.

Coverage decreased (-1.4%) to 77.048% when pulling a5a40a07291568394f0189be1e875c8169e449a0 on fix-metainfo into d0648b4d22e70abf8c5cb8f86d54d44c5b7e6f17 on master.

От меня пока все
@sipayRT 🆙

/cc @eGavr @j0tunn

Coverage increased (+0.7%) to 79.182% when pulling c028036c295b59be0939c1764d54cbc789019d62 on fix-metainfo into d0648b4d22e70abf8c5cb8f86d54d44c5b7e6f17 on master.

Coverage decreased (-15.09%) to 63.393% when pulling 25223366b4b9c3ebfcaaf04fa7d6ccb95b82e862 on fix-metainfo into d0648b4d22e70abf8c5cb8f86d54d44c5b7e6f17 on master.

Coverage increased (+0.7%) to 79.211% when pulling c71bd0d6a2e766179758d4baa31a2720d2312b30 on fix-metainfo into d0648b4d22e70abf8c5cb8f86d54d44c5b7e6f17 on master.

Coverage decreased (-16.9%) to 63.393% when pulling 1cb0ba9a6075b6926d5d892b142787f7d41d808f on fix-metainfo into a55b17f20e883a92f6fd3a0d0ccad17a348d79d7 on master.

Coverage decreased (-41.7%) to 38.556% when pulling 7873ef5ab9ffd6c3d4de4658070b8ecdf674fe0a on fix-metainfo into a55b17f20e883a92f6fd3a0d0ccad17a348d79d7 on master.

Coverage decreased (-0.9%) to 79.379% when pulling 2a31113ab3d8ee7f33f26a1749ee6bdcaae49cb5 on fix-metainfo into a55b17f20e883a92f6fd3a0d0ccad17a348d79d7 on master.

Coverage decreased (-16.9%) to 63.393% when pulling 10ad20fa1cc65c99c9853dd8969b29f3f8cb2b15 on fix-metainfo into a55b17f20e883a92f6fd3a0d0ccad17a348d79d7 on master.

Coverage decreased (-0.9%) to 79.379% when pulling 153ee329b3b010b149b61808dbf201b84240dc17 on fix-metainfo into a55b17f20e883a92f6fd3a0d0ccad17a348d79d7 on master.

Coverage decreased (-0.9%) to 79.379% when pulling 4c730b5ea4aa3b07acff61ca1ed317a397d94aff on fix-metainfo into a55b17f20e883a92f6fd3a0d0ccad17a348d79d7 on master.

В остальном 🆗

В остальном :ok:

Coverage decreased (-0.9%) to 79.398% when pulling 85c3330c308528bde1aa9ccbd015979194dd266b on fix-metainfo into a55b17f20e883a92f6fd3a0d0ccad17a348d79d7 on master.

Coverage increased (+18.8%) to 79.398% when pulling e1442593c7dea3e53b7081f2836a536270d62491 on fix-metainfo into fbb9ae9019e8eae5e680c40c47dea51877f2bc18 on master.

Coverage increased (+34.9%) to 95.575% when pulling e1442593c7dea3e53b7081f2836a536270d62491 on fix-metainfo into fbb9ae9019e8eae5e680c40c47dea51877f2bc18 on master.


Insynchq.Insync version <IP_ADDRESS>360

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Changing Alignment of "Footer"

The footer of the website is misaligned and requires adjustment.

@BamaCharanChhandogi Please add the label "level" to this issue.

Hi @AkshitGarg24 , If you do not start working on this issue, you can wait. Issue #29 is addressing the same matter.

@BamaCharanChhandogi I was already working on this issue and only had a few changes left. I have now made those changes and created a PR. Kindly merge the PR and please don't forget to add the label before merging it.
Thank you! Happy coding!


New Image Needed

Issue in ./help/c-implementing-target/c-implementing-target-for-client-side-web/c-how-atjs-works/how-atjs-works.md
The image for the diagram for how at.js 2x works is clearly a screenshot from a PowerPoint as the spell check red squiggly line is under at.js and the Page Load icon has been selected as evidenced by the box around it.
It should be replaced with a clean image.

Updated this and other images:
https://docs.adobe.com/help/en/target/using/implement-target/client-side/at-js/how-atjs-works.html


Added remove demo prompt to walkthrough

Please verify the following:

[x] yarn test jest tests pass with new tests, if relevant

Describe your PR

Adds prompt about removing demo code to the new walkthrough
Closes #2178

:tada: This PR is included in version 8.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


running basic scenario in readme

When I run the training scenario from the README:
python3 src/main.py --config=qmix_smac --env-config=sc2 with env_args.map_name=2s3z

I get the following output:
Traceback (most recent calls WITHOUT Sacred internals):
  File "src/main.py", line 34, in my_main
    run(_run, _config, _log)
  File "/home/esquires/repos/rl/rllib/pymarl/src/run.py", line 48, in run
    run_sequential(args=args, logger=logger)
  File "/home/esquires/repos/rl/rllib/pymarl/src/run.py", line 179, in run_sequential
    learner.train(episode_sample, runner.t_env, episode)
  File "/home/esquires/repos/rl/rllib/pymarl/src/learners/q_learner.py", line 100, in train
    loss.backward()
  File "/home/esquires/venvs/rllib/lib/python3.6/site-packages/torch/tensor.py", line 107, in backward
    torch.autograd.backward(self, gradient, retain_graph, create_graph)
  File "/home/esquires/venvs/rllib/lib/python3.6/site-packages/torch/autograd/__init__.py", line 93, in backward
    allow_unreachable=True)  # allow_unreachable flag
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [32, 94, 5, 11]], which is output 0 of SliceBackward, is at
 version 1; expected version 0 instead. Hint: enable anomaly detection to find the operation that failed to compute its gradient, with torch.autograd.set_detect_anomaly(True).

After setting torch.autograd.set_detect_anomaly(True) in the initializer of the QLearner object I get the following:
sys:1: RuntimeWarning: Traceback of forward call that caused the error:
  File "src/main.py", line 88, in <module>
    ex.run_commandline(params)
  File "/home/esquires/repos/rl/rllib/sacred/sacred/experiment.py", line 250, in run_commandline
    return self.run(cmd_name, config_updates, named_configs, {}, args)
  File "/home/esquires/repos/rl/rllib/sacred/sacred/experiment.py", line 199, in run
    run()
  File "/home/esquires/repos/rl/rllib/sacred/sacred/run.py", line 229, in __call__
    self.result = self.main_function(*args)
  File "/home/esquires/repos/rl/rllib/sacred/sacred/config/captured_function.py", line 48, in captured_function
    result = wrapped(*args, **kwargs)
  File "src/main.py", line 34, in my_main
    run(_run, _config, _log)
  File "/home/esquires/repos/rl/rllib/pymarl/src/run.py", line 48, in run
    run_sequential(args=args, logger=logger)
  File "/home/esquires/repos/rl/rllib/pymarl/src/run.py", line 179, in run_sequential
    learner.train(episode_sample, runner.t_env, episode)
  File "/home/esquires/repos/rl/rllib/pymarl/src/learners/q_learner.py", line 56, in train
    chosen_action_qvals = th.gather(mac_out[:, :-1], dim=3, index=actions).squeeze(3)  # Remove the last dim

[ERROR 17:35:55] pymarl Failed after 0:00:17!
Traceback (most recent calls WITHOUT Sacred internals):
  File "src/main.py", line 34, in my_main
    run(_run, _config, _log)
  File "/home/esquires/repos/rl/rllib/pymarl/src/run.py", line 48, in run
    run_sequential(args=args, logger=logger)
  File "/home/esquires/repos/rl/rllib/pymarl/src/run.py", line 179, in run_sequential
    learner.train(episode_sample, runner.t_env, episode)
  File "/home/esquires/repos/rl/rllib/pymarl/src/learners/q_learner.py", line 101, in train
    loss.backward()
  File "/home/esquires/venvs/rllib/lib/python3.6/site-packages/torch/tensor.py", line 107, in backward
    torch.autograd.backward(self, gradient, retain_graph, create_graph)
  File "/home/esquires/venvs/rllib/lib/python3.6/site-packages/torch/autograd/__init__.py", line 93, in backward
    allow_unreachable=True)  # allow_unreachable flag
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation: [torch.cuda.FloatTensor [32, 71, 5, 11]], which is output 0 of SliceBackward, is at
 version 1; expected version 0 instead. Hint: the backtrace further above shows the operation that failed to compute its gradient. The variable in question was changed in there or anywhere late
r. Good luck!

I then broke-up the line so that the gather and squeeze functions are on separate lines and the code complains about the gather line.
I am on 33070bc for pymarl, cdfff9b for smac, and version 1.1.0 for pytorch.
Should I be running a different command than what is in the README?
Thanks.

You should be good with pytorch version 0.4.1
You can check the requirements.txt for all recommended package versions. If I get some time I'll look into what's changed and see if pytorch 1.x support isn't too hard.

Thanks! That seems to have fixed it. Feel free to re-open if you want to investigate pytorch 1.x but this resolves what I was having difficulty with.


[lib] Fix forward references type checking

Fixes #208
What:
Pass the caller memo (frame information) to typeguard to properly resolve forward references.
Why:
It turns out that typeguard will only check the previous frame in the
stack to extract the variables that it will use when resolving forward
references.
How:
Now we are populating the memo context when trying to resolve types by finding out the caller's frame, currently a bit hackish as it's done by comparing the module's path to the current module path (testslide) and testslide module's path.
Risks:
It might break if it's unable to extract the caller's module path.
Checklist:

[x] Added tests, if you've added code that should be tested
[x] Updated the documentation, if you've changed APIs
[x] Ensured the test suite passes
[x] Made sure your code lints
[x] Completed the Contributor License Agreement ("CLA")

Is there any way you can think of achieving this without depending on this private/protected typeguard interface: typeguard._TypeCheckMemo?

Yep, we can try passing the locals and globals, looking
On 14 July 2020 12:12:20 CEST, Fabio Pugliese Ornellas<EMAIL_ADDRESS>wrote:

Is there any way you can think of achieving this without depending on
this private/protected typeguard interface: typeguard._TypeCheckMemo?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebookincubator/TestSlide/pull/211#issuecomment-658096242

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Added Revx Cloud Documentation

changes for revx cloud

@tcgilbert @asifarahiman Is this Destination in private or public beta?

@pwseg,
The integration is in private beta mode.

@pwseg this will go into public today once the docs are deployed


[LIVY-356][SERVER]Add LDAP authentication for livy-server.

What changes were proposed in this pull request?
Currently, livy-server doesn't support LDAP Authentication from client to server(livy). We need to add LDAP authentication as that's preferable method due to security reasons.
Here we reimplement LdapAuthenticationHandle, which is new in hadoop2.8+.
How was this patch tested?
UTs tests for this part have been added. We can test in UTs

Hi @jerryshao This PR is based on the previous #20 , could you please help to review it.

@captainzmc please add the JIRA to the PR title

fix

Hi  @yiheng  , Can you help to review this RP?

fix

fixed annotation to javadoc style

fix review issue

Do we need to change client-http module also to support BASIC authentication?

Do we need to change client-http module also to support BASIC authentication?

open a new JIRA for that？

LGTM as well. Thanks, merging to master.


Please let tf.keras.metrics.MeanIoU support y_pred from logits

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): 2.4.0
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
tf.keras.metrics.MeanIoU doesn't have an option that allow y_pred passed as logits, we want to pass y_pred as a logits tensor, you can simply add an optional step into the update_state function of this class:
    y_pred = math_ops.argmax(y_pred, axis=-1)

Will this change the current api? How?
Yes, add one parameter from_logits, you can keep default as False though:
tf.keras.metrics.MeanIoU(num_classes, from_logits=False, name=None, dtype=None)
Who will benefit with this feature?
Computer vision object detection/segmentation community
Any Other info.

@motionlife Can you prepare a small PR?

@motionlife Can you prepare a small PR?

Sure, just did :)

Thanks for the feature request -- moving discussion to the PR you created.


[requesting suggestions] Name change

Hello everyone & happy new year!
I've got good and bad-ish news: the good is that in some near-ish future, the Julia website may be written using this package which would be awesome. The bad-ish news is that the name of the package is a bit awkward which I've been kindly made aware of recently; as everyone knows, naming stuff well is hard!
So I'm open to suggestion as to  how to rename this package 😄 there's already Jekyll, Hugo, Octopress, Zola, Pelican, Docusaurus, Gatsby, ... (and many, many others) so what shall it be for this one?
Here are a few candidates in no particular order to get the ball rolling

Camus
Hyde
Wombat
Hippo
BloggyMcBlogFace (please don't)
Wakanda
Kayak

I'll aim to rename the package by March (I'll then need a bit of time to refactor things accordingly).
also cc @cserteGT3 @cormullion @asprionj

I like Hyde, as in Dr. Jekyll and Mr. Hyde. But perhaps being a 4 letter name, it might have a problem with approval for the registry?

I think we may want to also consider getting a domain name for the new name. Or at least think about it.

But perhaps being a 4 letter name, it might have a problem with approval for the registry?

I believe that only applies for auto-merging; it could still be manually merged by a maintainer.

@ararslan Is that only for the first time, or for every new version?

I think we may want to also consider getting a domain name for the new name. Or at least think about it.

an advantage of having ".jl" in package names means that namejl.ext makes sense and is also likekly to be available (jekyll did this with jekyllrb.com). For instance hydejl.io/com/org are available afaict.

It’s every version I think

Is that only for the first time, or for every new version?

No, only the first time. For reference, I haven't had any issues registering new versions of EDF.jl after the initial registration.

Interesting! But very difficult to think of a name without knowing some restrictions. Do you want it to link somehow to Julia, blogging, web pages, ... or do you just want a cool name that doesn't mean anything in particular?
I don't think you can have Hyde anyway, even if you really wanted to say "this isn't Jekyll"...
Fun places to look for names include Godchecker, Typefaces (associations with publishing), WordHippo for synonyms, Chemical elements, etc. Or the classic "Combine a color and an animal" ploy? :)

I do think a rename is a good idea, too bad (but not surprising that Hyde is already taken), bit I’m sure we can come up with something even better!

Thoughts on just “JDocs”

I typically associate the prefix J with Java-related software.

Why is it important for the name to indicate Julia?

Packages already have the .jl suffix, so having a J or Ju in the name is a bit redundant.

A few more suggestions
Justina - Julia Static, er, Internet, er... Assistant 🤪
Baskerville - sort of publishing, text, words (and there’s a subtle link to Hugo)
Franklin - could be publishing-ey, but why not remember scientist Rosalind as well?
Despatch - but I can never spell that, so there’s that
I’m slightly unsure of “docs” in the name, because, well, it’s more than that.

Yeah no need for docs or explicit ref to Julia, I guess at the onset it kind of made sense to me but now I like the idea of just picking an easy-to-remember name. Thanks for the suggestions @cormullion! I like Franklin, less so the other ones; I'm also tempted by wombat which is a weird but fun animal, or kayak because it's got 2 ks. Thanks for the fun links too, I'll play with them :)

From @cormullion 's list, I like Franklin the best.

I like Franklin as well

Franklin is pretty good but it will probably be assumed to be named after the more famous Franklin—Benjamin. Perhaps Rosalind would be a good name to honor her specifically? Too familiar?

Yeah I thought so too... but then if we're going with first names and possibly  in the vein of cool scientist, we could also go with Emmy which is easier to write than Rosalind. But then again people may think about like... the emmys... jeez. Tao.jl?

Tao.jl may be confused with Tau.jl and/or Yao.jl.

Hahaha 🙈 , how about Zeno.jl ? (with an allusion to the package's recursive parsing ability).

+1 for Franklin, or what about DrFranklin (like DrWatson.jl)? I like Rosalind as well, and don't find hard to write it.

Good (and paradoxical) idea!
I thought Tolkien might help with some meaningless and pleasant-ish words:

Eldarin
Amandil
Vanyarin
Irithiel
Quamara
Talindra

etc. Plenty still to be claimed for a Github repo. But it's amazing how many words have already been used for projects...

Looking at words that are printing-related, I came up with these ideas:

Codex
Vellum
Albion
Flexo
Paige
Hellbox
Forme
Chase
Letterpress
Quoin
Dingbat
Prepress
Platen
Frisket
Tympan

I would also note that perhaps Franklin is good and can be considered to honor both Rosalind Franklin and Benjamin Franklin, as the latter worked as a printer's devil in his youth and became a very famous writer as well as inventor.

Windings.jl :trollface:

thanks so much for all the help! Sounds like Franklin gets a majority here, I may let this sit a while and then do the necessary refactoring.
In terms of refactoring btw, can I just rename the repo and re-register it or am I safer to start a new repo from zero?

The best approach at the moment is to change the repo name, change the UUID and re-register.

@tlienart If it is possible for you, may I suggest renaming the repo and registering the new name now rather than later? Perhaps some of us can even help with what is required here, and may be a good way to get a few more people engaged with the project in a small way.

The best approach at the moment is to change the repo name, change the UUID and re-register.

@StefanKarpinski short question: if I do that what will happen to current users when they do up? they'll keep having the last minor release (0.4) of 'JuDoc'? so I can do the following steps without breaking people's code and release a Franklin 0.5 which they could then hook on to later?
(FWIW the package doesn't export any function that are likely to be used by other packages as a dependency so unless I miss something it should be ok to proceed).
Thanks! (and thanks everyone else for input 😄 )

Current users won't get upgrades: they'll just stay on the last version registered as JuDoc. Franklin will appear as an entirely new, unrelated package. They can upgrade by doing ] rm JuDoc and ] add Franklin and then search and replacing JuDoc with Franklin.

Sorry, late to the party. Just thought about GatsbyJS; so what about Carraway (the narrator in The Great Gatsby), or Buchanan (surname of Daisy, the love of Gatsby, but also of his adversary who got her first...)?
Anyway, I think Franklin is a good choice.

Thanks all! I'll definitely name future themes in honour of the many great suggestions here but it seems that Franklin just works well for everyone so let's just roll with that. I'll close the issue  and  will try to do that by the weekend or something 😸

Current users won't get upgrades: they'll just stay on the last version registered as JuDoc. Franklin will appear as an entirely new, unrelated package. They can upgrade by doing ] rm JuDoc and ] add Franklin and then search and replacing JuDoc with Franklin.

Is it possible to "deprecate" the package in a 0.5 release by printing a warning that the name has changed?

yeah I'll do that in a registered 0.4.1 release 👍

@asprionj Nice names! Like so many such, there's already a few Github hits - because Gatsby is a thing, Carraway is also a thing, I suppose. A few hits for Buchanan too. Wonder how soon we'll run out of decent names?


Unrecognized algorithm name: PBEWithSHA1AndDESede

Version report
Jenkins and plugins versions report:

Jenkins version: 2.277.4

What Operating System are you using (both controller, and any agents involved in the problem)?

Ubuntu 18.04 - controller

Reproduction steps

In the jdk 8u292 there is a bug as seen here https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8266261
This got introduced in PR #1110 when the jdk got version bumped
In my particular case I am running into this while using the AzureKeyVault Plugin.  This worked/still works just fine under 8u282.
try {
  withAzureKeyvault([[ secretType: 'Certificate', name: 'credential', envVariable: 'CERT_LOCATION' ]]) {
    // Do something
  }
} catch (Exception error) {
  echo "${error}"
}

Step 2...

Results
Expected result:

The expected result is to run whatever is in the // Do something section
Actual result:

There is a java exception happening that the AzureKeyVault plugin is catching, wrapping, and re-throwing
org.jenkinsci.plugins.azurekeyvaultplugin.AzureKeyVaultException: Key protection  algorithm not found: java.security.UnrecoverableKeyException: Encrypt Private Key failed: unrecognized algorithm name: PBEWithSHA1AndDESede

Thanks @mrrsm. Is there any alternative other than switch back to JDK 8u282?
Any assessment of how widely the bug is likely to impact users?
Any indication that JDK 8u292 will receive an out of band patch or will we need to go back to 8u282 until the next quarterly release of JDK 8?

This was the issue which pointed me at the java bug and a potential work around which I am planning on testing shortly for my specific use case.
I'm guessing that anyone doing PKCS#12 certificate work will see this issue.  Unless there is a good case to keep the old PBEWithSHA1AndDESede algorithm using a stronger algorithm for PKCS#12, assuming the workaround above works, seems like a good mitigation path while being able to stay on JDK 8u292.  If someone required PBEWithSHA1AndDESede they would be SOL as of right now unless they revert to a build with JDK 8u282.

Thanks @mrrsm .  I've raised a question for the Jenkins infra team to get their guidance.  My current opinion is that we should continue with Jenkins using JDK 8u292 and rely on the mitigation path described in https://github.com/bcgit/bc-java/issues/941#issuecomment-832008774 and later comments.

Thanks for the prompt replies/action @MarkEWaite
The workaround from Bouncy Castle did not work for me.  I tried a few different algorithms, so far I tried PBEWithHmacSHA256AndAES_256 and PBEWithHmacSHA256AndAES_128, and none appeared to work for my example.  My thoughts are the key/cert that is stored in KeyVault needs that specific set of instructions to decrypt/decode it.
I had to revert to version 2.277.3 to ensure our builds are working, which I have verified that they are.
I am going to keep searching for workarounds and should be able to test on and off as I find them.

I dug into my problem a bit more and figured out why the work around wouldn't work for me.
I am attempting to work on an EV Code signing cert which has the full chain in the pfx file.  The trusted root cert uses the sha1WithRSAEncryption signature algorithm which would use the removed PBEWithSHA1AndDESede class.
I believe if you try to interact with any certificates that are SHA1 signed you will hit this error, even if the certificate isn't in your chain, if it tries to validate it with certificates in your local store it will fail on SHA1 signed certs still as well as I have tested with multiple pfx files with and without the full chain in the pfx.

Per the java bug I linked in my original post.

This issue will either be fixed by JDK-8242565 (already in OpenJDK 8u302-b04 EA build) or by JDK-8266929 (most likely going to be in 8u302-b05 EA build).

An update to jdk 8u302 once it is out of beta should solve this issue.

Jenkins weekly release 2.306 will include Java 8u302 in the latest image.  Scheduled for release Aug 10, 2021.


feat: Service exceptions to period tickets

Description
For the period ticket, service exception needs to be displayed
Testing instructions
Create a period ticket with zeo zone

Add exemptions to confirmation section


Missing Import

Needs additional import
from azureml.core.environment import Environment
so that curated environment can be used
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5b90fbd-19a9-4fe7-032b-765457549f30
Version Independent ID: a23a02a5-23fd-9935-4031-b943aa468030
Content: Train and deploy a TensorFlow model - Azure Machine Learning
Content Source: articles/machine-learning/how-to-train-tensorflow.md
Service: machine-learning
Sub-service: core
GitHub Login: @mx-iao
Microsoft Alias: minxia

@carmelgafa we'll review your feedback and get back to you shortly, thanks!

Thanks for catching this. I've opened a PR to update the docs

Thanks @carmelgafa for the report and @mx-iao for the fix!
I'll proceed to #please-close this issue. If you feel that your documentation issue hasn't been resolved, please feel free to open a new issue with additional information.


VM App policy for Scaleset

Hi!
I saw there is a policy for VM Application and Windows Virtual machines.
Is there also a policy for VMSS? Thanks!

We are not aware of any policy for VMSS, but we would happily accept any contribution for this.
Unfortunately, we cannot create new policies at request.


upload demo videos

https://github.com/Efficient-Large-Model/VILA/assets/7783214/80c47742-e873-4080-ad7d-d17c4700539f
https://github.com/Efficient-Large-Model/VILA/assets/7783214/6079374c-0787-4bc4-b9c6-e1524b4c9dc4

Thank you for fantastic demo, would the script vila_demo.py be released @Lyken17

Our demo is supported by tinychat and awq. @ys-2020  can comment how to reproduce

Thanks for your interest in VILA and TinyChat! Please follow the instructions here for reproduction.


myaccount access link is not visible to admin when admin switch to an org and come back to tenant

Describe the issue:

admin login to console super tenant. my account access url is visible in header
admin switch to the sub organization . Myaccount link is not visible -> This is expected
Admin switch back to super tenant. Still myaccount link is not visible -> This should be available

https://github.com/wso2/product-is/assets/25483865/64ae7057-f042-4e1a-ae8e-579c70b897d5

Here we are setting organization name rather than the id for first level orgs.
https://github.com/wso2/identity-apps/blob/eec53249a0d61b971e21fdd2afe0a623167bf08f/apps/console/src/features/authentication/hooks/use-sign-in.ts#L158
This affects the condition check here, since when a user switches back to root user_org will be available in IDToken. And the organization name becomes empty.
https://github.com/wso2/identity-apps/blob/eec53249a0d61b971e21fdd2afe0a623167bf08f/apps/console/src/features/core/components/header.tsx#L386
Need to validate why aren't we considering org_id other than org_name.

Fix is applied along with: https://github.com/wso2/product-is/issues/17467

Fixed in Beta-SNAPSHOT.
https://github.com/wso2/product-is/assets/37938529/7619190f-a147-4ccd-be08-b916f8d1683c


fix discord link

The CONTRIBUTING.md link is broken.
Replace it with the one in the README, that seems to be working.

Thank you for your contribution! We require all commits to our repo to be signed. You can learn how to do it here: https://docs.github.com/en/authentication/managing-commit-signature-verification


Please invite me to the GitHub Community Organization

Name
Sugam Goel
Discord Username (if applicable)
No response
Additional Context
Being part of this GitHub organization will allow me to connect with other developers who share my interest in programming. I'd like to engage in discussions, participate in events or workshops, and build relationships with professionals in the field.

It's great having you contribute to this project
If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

#Please check your email or organisation page 🙏


Scope with Azure KeyVault must have userAADToken defined

Add-DatabricksSecretScope -BearerToken "dapi" -Region "westeurope" -ScopeName "key-vault-secrets" -KeyVaultResourceId "/subscriptions//resourceGroups//providers/Microsoft.KeyVault/vaults/" -AllUserAccess
Results in an error: Invoke-RestMethod : {"error_code":"INVALID_PARAMETER_VALUE","message":"Scope with Azure KeyVault must have userAADToken defined!"}

Yep (and agreed this is an issue) I've had to remove this from the latest version. Databricks are changing the API and will not commit to the final state until Key Vault backed scopes comes out of Preview. I've no timescales yet. In the meantime if you need these I would deploy them manually - the CLI or REST API do not support them yet.

This still gives an error.
Any timescale when this will be fixed :(
the azure.databricks.cicd.tools helped me a lot in my Continuous deployment pipelines and I want to restrict the manual processes as little as possible.

Microsoft are claiming this works now: https://docs.microsoft.com/en-us/azure/databricks/release-notes/product/2020/october#use-the-databricks-cli-or-the-databricks-api-to-create-azure-key-vault-backed-secret-scopes
However it does not. I've opened a support case and been told that Create Scope only works with Bearer tokens, but Key Vault Backed Scopes require you to use AAD. Go figure. Also raised as an issue with the docs here: https://github.com/MicrosoftDocs/azure-docs/issues/65000#issuecomment-716517977

Cross referencing #77 as these are the same issue. Basically AAD auth only works for users, not service principals. It's "on the backlog".

Hi All, I'm using a standard tier, while creating a scope using CLI I'm getting below error.

databricks secrets create-scope --scope datalake --scope-backend-type AZURE_KEYVAULT --resource-id /subscriptions//resourceGroups/hardikpocs/providers/Microsoft.KeyVault/vaults/kv-hardikpocs --dns-name https://.vault.azure.net/ --initial-manage-principal users
Error: b'{"error_code":"INVALID_PARAMETER_VALUE","message":"Scope with Azure KeyVault must have userAADToken defined!"}'

You are using the official cli. This repo is for the Powershell module. I suggest you contact Databricks.

From: Hardik Anghan @.>
Sent: Sunday, March 21, 2021 6:33:19 AM
To: DataThirstLtd/azure.databricks.cicd.tools @.>
Cc: Simon D'Morias @.>; Assign @.>
Subject: Re: [DataThirstLtd/azure.databricks.cicd.tools] Scope with Azure KeyVault must have userAADToken defined (#43)
Hi All, I'm using a standard tier, while creating a scope using CLI I'm getting below error.
databricks secrets create-scope --scope datalake --scope-backend-type AZURE_KEYVAULT --resource-id /subscriptions//resourceGroups/hardikpocs/providers/Microsoft.KeyVault/vaults/kv-hardikpocs --dns-name https://.vault.azure.net/ --initial-manage-principal users
Error: b'{"error_code":"INVALID_PARAMETER_VALUE","message":"Scope with Azure KeyVault must have userAADToken defined!"}'
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/DataThirstLtd/azure.databricks.cicd.tools/issues/43#issuecomment-803521069, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADBMOSAJPA5FDJNH4FDNVJ3TEWHK7ANCNFSM4G33BB2A.

Still having this issue !
databricks secrets create-scope --scope demo --scope-backend-type AZURE_KEYVAULT --resource-id $vaultId --dns-name $vaultUri
Error: b'{"error_code":"INVALID_PARAMETER_VALUE","message":"Scope with Azure KeyVault must have userAADToken defined!"}'

I am trying to create azure key vault scope in databricks but having below issue. Anyone has any idea about it ?

Hi @simondmorias , I saw your previous post as UserAADToken still in backlog items which is posted last year. Is it fixed now?
I need to automate the keyvault backed secret scope creation in azure devops pipeline. If you have any other option, please let me know. thanks for your time and help.

11 months on and still no fix. seems like a important feature to link Azure Key Vault to Databricks. how do we escalate these problems to the Core team

This is such a requested feature, how is this not fixed yet? Please try and sort this out so we can automate our deployments

It’s a Databricks api limitation. I can’t work around it as they control the api.
On 22 Aug 2022, at 19:32, Jay Freeman @.***> wrote:

This is such a requested feature, how is this not fixed yet? Please try and sort this out so we can automate our deployments
—
Reply to this email directly, view it on GitHubhttps://github.com/DataThirstLtd/azure.databricks.cicd.tools/issues/43#issuecomment-1222761744, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADBMOSAQ63GPYVJ3SB4YI6LV2PBS3ANCNFSM4G33BB2A.
You are receiving this because you were mentioned.Message ID: @.***>

Any updates on this ?
I am facing same issue today


Error ./configure.sh

apt install maven default-jdk default-jre openjdk-8-jdk openjdk-8-jre -y
apt install zlib1g-dev libncurses5-dev lib32z1 lib32ncurses6 -y
chmod +x configure.sh
./configure.sh
....

Have you found a solution?

Install all needed dependencies and configure.sh will be working properly.
--
An outsider, the BaRRaKudaRain
-----Original Message-----
From: "Grisha"<EMAIL_ADDRESS>Sent: 5/11/2019 1:41 AM
To: "tiagorlampert/sAINT"<EMAIL_ADDRESS>Cc: "Subscribed"<EMAIL_ADDRESS>Subject: Re: [tiagorlampert/sAINT] Error ./configure.sh (#16)
Have you found a solution?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


perf: improvements to scan

By dynamically adjusting the positioning and scaling of the scan window relative to the texture, the package ensures optimal coverage and alignment for scanning targets.

In the original package, If there are multiple barcode/qrcodes in the screen, the scan would randomly pick up any barcode/qrcode that shows in the screen, This upgrade fixes it and picks on the qrcode/barcode that is in the center of the camera.

In the original package if you changed the camera size, it would still pick scans even if the barcode are not shown in the screen, This issue is also fixed in the upgraded packaged.

Thanks! LGTM!


Provide a pulseaudio playing stream name

Describe the bug
Spot does not provides, or provides an empty name for its playing stream on pulseaudio.
To Reproduce
Steps to reproduce the behavior:

Play a song
List pulseaudio/pipewire playing stream (with pavucontrol, or wpctl status)
The spot stream does not have a name

Expected behavior
Provide a meaningful stream name, like "spot".
General information:

Distribution: archlinux
Installation method: AUR
Version: 0.4.0

This should be another one line fix.

Depends on the extent of this feature request, we can also provide title, artists, etc, to PulseAudio.

no idea how this works tbh so I'm glad if someone's able to help! :)

no idea how this works tbh so I'm glad if someone's able to help! :)

Name could be provided by setting a env var, see the screenshot above. This could be merged to close this issue.

Cool, feel free to open a PR I'll have a look! :)

Thanks! That was fast!


Avoid duplicate HTTP requests to mute/unmute topics

In #21059, we fixed a 500 issue that would happen when two requests to mute a given topic raced with each other.  I suspect we have a secondary UI issue that some UI widget makes it very easy to accidentally double-click and send two requests to the server to mute a given topic; otherwise this race would never have happened in practice anyway.
Typically, we fix that sort of issue by replacing the submit button for such a widget with a loading indicator while the request is in progress, which in particular prevents you from clicking a second time.  We should probably do an audit of the ~6 widgets that let you mute/unmute topics and use this sort of technique in them where appropriate.
A good example of this is the "message edit" UI.
This issue is fairly low priority -- so I'd encourage only folks who feel confident they can resolve it correctly without much help to work on it.

I suspect #18279 (which deferred updating the UI to when the event is received rather than immediately) to have made it easier to send multiple topic mute requests in quick succession, for example by double clicking the topic mute bell icon (it would stay there for sometime after the first click because of #18279).
For fixing this, if we replace the bell with a spinner after the first click, should the rest of the UI update be done when the sent request completes or when the topic mute event is received?


All scopes are not coming for the new scope selection screen.

I'm using the v2.0 branch and following the ONC g(10) documentation.
For a Standalone patient App test, All selected scopes are not appearing on the scope selection screen.
I'm passing all the scopes mentioned in the documentation while registering the client.

In the above screenshot first scope is empty and we are not able to see the launch/patient, openid and fhirUser scopes.
If I use the reference server, I can see these scopes. Please see the below screenshot:-

Any idea how can I add the remaining scopes for the proxy?
My deadline for the certification is very near. I will really appreciate your help on this.

@sordahl-ga
I agree with all of this.
If you see the screenshot first scope is empty. We have a checkbox for nothing.
For inferno test,( 9.10.04 Health IT Module informed patient when "offline_access" scope is being granted during authorization) it is required that user can accept/deny the offline_access scope at the authorization time.
Or user has to inform that the application has requested “offline_access” before authorizing any scopes.
I don't see offline_scope in the active directory consent screen and we only request active directory consent for once.


Notifications on track change

Apple Music and Cog do this. Should be optional - or is just suppressing notifications sufficient UX?

See:

https://developer.apple.com/documentation/usernotifications - use this instead of the one deprecated in Big Sur
https://cocoacasts.com/local-notifications-with-the-user-notifications-framework

Implemented, though...

would be nice to have UI other than "lol change it in System Prefs" if we do more
a skip button would be cool but inessential
we always post the notification, which means we do get a notification always - but the default behaviour is to suppress it in the foreground
other possibilities - there's no more chat, but other people's now playing might be cool?


/battery_state/current does not update

ISSUE TEMPLATE ver. 0.2.0

Which TurtleBot3 you have?

[ ] Burger
[ ] Waffle
[x] Waffle Pi

Which SBC(Single Board Computer) is working on TurtleBot3?

[x] Raspberry Pi 3
[ ] Intel Joule 570x
[ ] etc (PLEASE, WRITE DOWN YOUR SBC HERE)

Which OS you installed in SBC?
(We have two Waffle Pi's, one with MATE and the other with Raspbian)

[x] Ubuntu MATE 16.04 or later
[x] Raspbian
[ ] etc (PLEASE, WRITE DOWN YOUR OS)

Which OS you installed in Remote PC?

[x] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[ ] Linux Mint 18.x
[ ] etc (PLEASE, WRITE DOWN YOUR OS)

Write down software version and firmware version

Software version: [1.1.0]
Firmware version: [1.1.3]

Write down the commands you used in order

[Remote PC] roscore
[Turtlebot] roslaunch turtlebot3_bringup turtlebot3_robot.launch
[Remote PC] rostopic echo /battery_state

Copy and Paste your error message on terminal

No error

Please, describe detailedly what difficulty you are in

We have two Waffle Pi's, one with MATE and the other with Rasbian. Both have the same software and firmware versions. We need updates to current from the /battery_state topic but it is always displayed as zero. The only subtopics that update from /battery_state are the header, voltage, and percentage. All the other subtopics never update.

Hi @kijongGil
I've updated the firmware using the shell script and still no change.

Hi @kijongGil
Yes, so far the turtlebot3 works well with the teleop package. The only issue so far is that the current from the /battery_state is not being outputted and we need that for our research.

I'm sorry I misunderstood your question. /battery_state has voltage, charge, capacity, design_capacity, percentage and more. You want to check it, right?
This message format is standard for battery_state. Unfortunately, we do not use this data, so the data value is zero. If you want to check current, you have to add current sensor and make to publisher.

This issue will be closed since there were no actions for a while. You can reopen this issue to show this issue to the users whenever. Thanks.


Different time zone is being used in new twts and in replies

Create a new twt, and the reply to it.
2024-12-13T21:39:32Z	A test!
2024-12-13T16:51:20-05:00	(#vborwuq) a reply to that test

We could see that the new twt uses Zulu timezone, and the reply uses -05:00 which is a weird choice since the sandbox is set for Europe/Copenhagen UTC+1
Edit: I found the server it set to America/New_York UTC-5
Live example: https://twtxt-sandbox.eapl.me/twtxt.txt - Lines 37-38

BTW I'll vote to keep the timezone in the twts, as they help to know not only the moment, but the 'local hour' in which the twt was made.

I think the problem happens here
https://github.com/sorenpeter/timeline/blob/main/views/new_twt.php#L61
But I don't know yet why it happens in replies only

I think it's due to a combination of running this line:
require_once("partials/base.php");

https://github.com/sorenpeter/timeline/blob/main/views/new_twt.php#L94
Which triggers the default UTC zone.
date_default_timezone_set('UTC');

https://github.com/sorenpeter/timeline/blob/main/partials/base.php#L61
Whilst when we send a reply with a hash, that base.php doesn't run, but I'd need to make more tests, as I don't remember that code anymore.
Also, are we going to use UTC only, or should we respect the timezone in config.ini ?

Can we make it configurable to use either Z or timeoffset?
I prefer the Z myself,  but I see your point with showing the timeoffset in twtxt.txt for local time.

I agree it should be configurable.
My proposal is that if you leave a default Zulu or UTC timezone, it'll use the 'Z', otherwise your chosen timezone will be used.
That should be explained in config_template.ini
https://github.com/sorenpeter/timeline/blob/d3079b0be432e6f72aaf11a39a531763a32dced0/private/config_template.ini#L31-L33


Make Inc support multiple Inc updates in a single call

Making Inc really atomic
=====================
The Inc modifier currently uses write_attribute to update the attribute on the object locally apart from making the atomic update on the db. This defeats the purpose of atomic updates as a save on the model after this will re-persist the incremented attributes, possibly wiping another atomic modification. Details are here :  http://groups.google.com/group/mongoid/browse_thread/thread/91c121183fdb2405

Updating multiple attributes in a single call to Inc
=======================================
MongoDB supports atomic updates to multiple fields on documents with a single "$inc" operator.

Eg : db.foo.update({}, {"$inc" : { a : 1, b : -1}})
Having this feature in Mongoid will be pretty helpful. Currently the "inc" method takes a field name (key) and a value. Instead it can be made to take a hash of key-value pairs.

#1344 has a better explanation of where the API is going, will work from that issue now.


Refactoring Agent display

while using pyLODE, I had some issues with properly showing contributors names.
I investigated a little and found the following:
names are normalized to use dcterms:title here (ontpub) and here (vocpub)
however, when serializing for html here and here only sdo:name is used.
in the pull request I changed that to use the canonical dcterms:title instead.
I also made minor changes to the formatting:

I changed the CSS for the metadata display a little to make it more compact
in the ORCID icons, I use the actual URL as a title and not the generic Orcid logo as before

@SirkoS thanks for identifying the problem. It needs a solution but I would prefer to move to schema:name rather than towards dcterms:title. This is due to a growing use of schema.org and a diminishing use of DCTERMS.
So I think the PR is essentially correct - solving the issue - but that it should implement schema:name.
I'll leave this comment here for a bit so if you want to fix this, you can, or else I will.
pyLODE update sprint due in Ausgust '24.

Could it not be all of them, with different priorities?

I'm a little hesitant to make schema:name the canonical property for fear of side-effects.
my change so far tried to make the least amount of changes to fix the issue which was changing the property used in the output. If I change the normalization process, this will not only affect agents but also any other entity using any of dcterms:title, rdfs:label, and skos:prefLabel. This includes, e.g., the ontology itself which is also described via dcterms:title and any class described via rdfs:label.
I agree that use of schema:name might be becoming more prominent with description of agents, I don't think the same is true for a generic use to give a label to some entity. So strictly speaking, I would exchange one inaccuracy (dcterms:title for agents) with multiple other ones (e.g., using schema:name to denote class labels).
On a different note, this is an entirely internal change to pyLODE - this would not be visible in both ontology and documentation. So I'd argue it does not matter which property is used internally and it's safer to change as few lines of code as possible.

Could it not be all of them, with different priorities?

Same argument as in the paragraph before. This is an entirely internal thing, so technically you can use whatever property of the 4 (rdfs:label, dcterms:title, schema:name, and skos:prefLabel) in most places anyways.

I have not entirely understood the codebase, so I might be missing something here.


[SPARK-22520][SQL] Support code generation for large CaseWhen

What changes were proposed in this pull request?
Code generation is disabled for CaseWhen when the number of branches is higher than spark.sql.codegen.maxCaseBranches (which defaults to 20). This was done to prevent the well known 64KB method limit exception.
This PR proposes to support code generation also in those cases (without causing exceptions of course). As a side effect, we could get rid of the spark.sql.codegen.maxCaseBranches configuration.
How was this patch tested?
existing UTs

Test build #83866 has started for PR 19752 at commit 98eaae9.

Test build #83866 has finished for PR 19752 at commit 98eaae9.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class CaseWhen(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83866/
Test PASSed.

@kiszk may I kindly ask you to review this please? Thanks.

Sure, it may have some overlaps with #18641. I will review this after #18641 due to avoiding a conflict.

@kiszk actually checking your PR I think that the same issue addressed there would be handled also here by default. What do you think?

@gatorsmile I added a test case to check that the execution plan is WholeStageCodegenExec as expected. I also made some performance test using almost the same code, ie.:
val N = 30
val nRows = 1000000
var expr1 = when($"id" === lit(0), 0)
var expr2 = when($"id" === lit(0), 10)
(1 to N).foreach { i =>
  expr1 = expr1.when($"id" === lit(i), -i)
  expr2 = expr2.when($"id" === lit(i + 10), i)
}
time { spark.range(nRows).select(expr1.as("c1"), expr2.otherwise(0).as("c2")).sort("c1").show }

before this PR, it takes on average 1091.690996ms. After the PR, it takes on average 106.894443ns.
Actually there is a problem which is fixed in #18641 and it is not fixed here, ie. when the code contains deeply nested exceptions, the 64KB limit exception can still happen. But this should be handled in a more generic way in #19813.
@kiszk What do you think?

Test build #84168 has started for PR 19752 at commit 6225c8e.

Test build #84168 has finished for PR 19752 at commit 6225c8e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84168/
Test PASSed.

Test build #84198 has started for PR 19752 at commit f9c20be.

Test build #84199 has started for PR 19752 at commit 9063583.

Test build #84198 has finished for PR 19752 at commit f9c20be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84198/
Test PASSed.

Test build #84199 has finished for PR 19752 at commit 9063583.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84199/
Test PASSed.

LGTM cc @cloud-fan @kiszk

LGTM except a few minor comments

Test build #84206 has started for PR 19752 at commit f4c7896.

Test build #84206 has finished for PR 19752 at commit f4c7896.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84206/
Test FAILed.

Test build #84212 has started for PR 19752 at commit 5adb513.

Test build #84212 has finished for PR 19752 at commit 5adb513.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84212/
Test PASSed.

Test build #84224 has started for PR 19752 at commit c7347b1.

Test build #84224 has finished for PR 19752 at commit c7347b1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84224/
Test FAILed.

Merged build finished. Test FAILed.

Test build #84229 has started for PR 19752 at commit dd5f455.

Test build #84229 has finished for PR 19752 at commit dd5f455.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84229/
Test PASSed.

thanks, merging to master!


author "Gitea"

Gitea version (or commit ref):c5ec66a
Git version:2.7
Operating system:centos 7.5 x64
Database (use [x]):

[ ] PostgreSQL
[x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist:

Description
I have write code and commit to gitea from two computer, all commit is mine, but another computer commit author "Gitea", I think it will be me too.
Screenshots

Could be that on one computer you have not correctly configured Author name/email? check:
git config --list

thanks,


[BUG] - itunes:explicit tag should be true/false not yes/no

The google documentation says that the <itunes:explicit> tag values can be "yes" or "no".
https://support.google.com/podcast-publishers/answer/9889544
But! The apple documentation says that this tag, which can be set on the feed, and/or on individual items, should be "true" or "false", not yes/no!
https://help.apple.com/itc/podcasts_connect/#/itcb54353390
https://itunespartner.apple.com/podcasts/articles/validate-your-podcast-3064
Some rss validators will flag <itunes:explicit>  yes/no values as invalid.
These castanet files (maybe there are others) should be updated to use apple's documented true/false rather than yes/no:

https://raw.githubusercontent.com/mattstratton/castanet/master/archetypes/episode.md
https://github.com/mattstratton/castanet/tree/master/exampleSite/content/episode/*md
https://github.com/mattstratton/castanet/blob/master/REFERENCE.md

So it wouldn't be as simple as just changing all items to yes/no in those files. I think we'd have to change how the RSS Feed is generated, as Google Play uses yes/no Ref here.
I can take a look at this one @mattstratton

PR #327 looks like it's almost the right fix; I made a few comments on how to handle this a little better in that PR.


DOC-4196: add TCEs to the full-text query page

Description

Tabbed code examples (TCEs) for the full-text query page. Please merge as soon as possible.

Checklist

[ ] Does npm test pass with this change (including linting)?
[ ] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@leibale similarly, looks fine to me, any issues I should be focused on that I might be missing?


feat: merge development into main for minor version release

PR-Codex overview
This PR focuses on updating various URLs in the codebase and making minor changes to improve code readability and documentation.
Detailed summary

Updated URLs in markdown files.
Updated package dependencies.
Added new types and interfaces.
Improved error handling.
Added code examples and demos.
Updated documentation.

The following files were skipped due to too many changes: site/packages/aa-ethers/index.md, packages/alchemy/src/middleware/client.ts, packages/alchemy/src/middleware/simulate-uo.ts, site/packages/aa-alchemy/provider/withAlchemyGasManager.md, examples/alchemy-daapp/README.md, packages/accounts/src/kernel-zerodev/e2e-tests/kernel-account.test.ts, site/snippets/provider.ts, site/snippets/getting-started/provider.ts, site/smart-accounts/accounts/light-account.md, site/packages/aa-alchemy/provider/withAlchemyUserOpSimulation.md, site/packages/aa-alchemy/middleware/withAlchemyUserOpSimulation.md, packages/ethers/e2e-tests/simple-account.test.ts, packages/core/src/account/__tests__/simple.test.ts, site/packages/aa-alchemy/provider/withAlchemyEnhancedApis.md, site/snippets/getting-started/send-user-operation.ts, site/index.md, site/smart-accounts/signers/dynamic.md, site/packages/aa-alchemy/provider/simulateUserOperationAssetChanges.md, site/why-account-kit.md, site/packages/aa-core/provider/withUOSimulationMiddleware.md, packages/accounts/src/light-account/__tests__/account.test.ts, packages/alchemy/src/__tests__/provider.test.ts, site/packages/aa-core/provider/checkGasSponsorshipEligibility.md, site/.vitepress/config.ts, packages/core/e2e-tests/simple-account.test.ts, packages/core/src/provider/base.ts, packages/alchemy/src/provider.ts, site/snippets/light-account.ts, site/introduction.md, site/guides/sim-user-operation.md, site/guides/enhanced-apis/nft.md, site/guides/enhanced-apis/token.md, packages/core/src/provider/types.ts, packages/alchemy/src/__tests__/__snapshots__/provider.test.ts.snap, site/overview/getting-started.md, packages/alchemy/e2e-tests/simple-account.test.ts, site/guides/sponsoring-gas/gas-sponsorship-eligibility.md, packages/accounts/src/light-account/e2e-tests/light-account.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

closing in favor of: https://github.com/alchemyplatform/aa-sdk/pull/268


Infer the proxy user automatically for delete batch operation

:mag: Description
Infer the batch user from session or metadata, user do not need to specify the proxy user anymore.
This pr also align the behavior of BatchesResource with that of SessionsResource and OperationsResource(no proxy user parameter).
For Kyuubi Batch, Session and Operation, these resources have the user attiribute.
So we only need to check whether the authentication user has the permission to access the resource.
Issue References 🔗

This pull request fixes #
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[x] Pull request title is okay.
[x] No license issues.
[x] Milestone correctly set?
[ ] Test coverage is ok
[x] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

cc @pan3793 @cxzl25

I think it may be useful in the future.
Currently, we only have a true-false-switch for roles: admin/non-admin. But in the future, we may introduce the real RBAC system, which means we can control tom only allows proxying jerry, as Hadoop does.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (88fae49) 61.40% compared to head (c721a75) 61.40%.
Report is 3 commits behind head on master.

Files
Patch %
Lines

.../apache/kyuubi/server/api/v1/BatchesResource.scala
50.00%
1 Missing and 2 partials :warning:

...ache/kyuubi/server/api/v1/InternalRestClient.scala
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5717      +/-   ##
============================================
- Coverage     61.40%   61.40%   -0.01%
  Complexity       23       23
============================================
  Files           607      607
  Lines         35755    35751       -4
  Branches       4900     4900
============================================
- Hits          21957    21952       -5
- Misses        11413    11414       +1
  Partials       2385     2385

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

have addressed all comments and updated the pr description. @pan3793


WIP: Simplify sidecar egress mTLS config - Phase 1

Signed-off-by: Faseela K<EMAIL_ADDRESS>Please provide a description of this PR:
RFC: Simplify sidecar egress mTLS
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5f7727a1e79b7521dd3490110788c8c64fb50b96
link
true
/test release-notes_istio

lint_istio
5f7727a1e79b7521dd3490110788c8c64fb50b96
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
5f7727a1e79b7521dd3490110788c8c64fb50b96
link
true
/test lint_istio

release-notes_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test release-notes_istio

unit-tests_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test release-notes_istio

unit-tests_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test unit-tests_istio

integ-pilot-multicluster-tests_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test integ-pilot-multicluster-tests_istio

release-notes_istio
97e6a285529a3035b3ced0fd15978aca1bb81cb9
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster-tests_istio
8e70fe32a5a0c064f8adcc467bf37eff3d8d3f18
link
true
/test integ-pilot-multicluster-tests_istio

release-notes_istio
97e6a285529a3035b3ced0fd15978aca1bb81cb9
link
true
/test release-notes_istio

unit-tests_istio
97e6a285529a3035b3ced0fd15978aca1bb81cb9
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
97e6a285529a3035b3ced0fd15978aca1bb81cb9
link
true
/test unit-tests_istio

release-notes_istio
5f2383ad1079a164bb92a3f05d4050238d48d437
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kfaseela: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5f2383ad1079a164bb92a3f05d4050238d48d437
link
true
/test release-notes_istio

unit-tests_istio
5f2383ad1079a164bb92a3f05d4050238d48d437
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is something like kubelet does(it can watch all cm/secret/pvc), i am just not sure we should give the sidecar so high permission

@kfaseela: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Update and add new tests for the refactored restore feature

longhorn/longhorn#1279

@yasker Need to update the image due to the engine version bump and API modification.

Since it's blocking the nightly test now, I am going to merge this PR for now. Let's track any issue found by the QA in a separate issue later.


Falco container restarting due to connection to Kubernetes API reset by peer

Describe the bug

Falco container restarting due to connection to Kubernetes API reset by peer:
Runtime error: Socket handler (k8s_replicationcontroller_handler_event) an error occurred while connecting to https://<IP_ADDRESS>: Connection reset by peer. Exiting.
How to reproduce it

Azure AKS, k8s v1.20.9, istio 1.11.3, install falco with helm chart, wait
NAME          READY   STATUS    RESTARTS   AGE
falco-bghk6   2/2     Running   110        7d3h
falco-c5l66   2/2     Running   79         7d3h
falco-cjzvx   2/2     Running   85         7d3h
falco-fxjhm   2/2     Running   71         7d3h
falco-gnxdv   2/2     Running   70         7d3h
falco-hrnt5   2/2     Running   59         7d3h
falco-hzbvj   2/2     Running   117        7d3h
falco-j67nc   2/2     Running   42         4d
falco-nhzb6   2/2     Running   2          7d3h
falco-nmtcf   2/2     Running   88         7d3h
falco-p9mvc   2/2     Running   79         7d3h
falco-pzc4f   2/2     Running   93         7d3h
falco-sxj5v   2/2     Running   121        7d3h
falco-vdnrj   2/2     Running   5          7d3h
falco-x2ctc   2/2     Running   95         7d3h
falco-xrrsl   2/2     Running   55         7d3h
falco-znl9z   2/2     Running   80         7d3h

Expected behaviour

Falco shouldn't exit, it should log the connection error and retry.
Environment

Falco version:

# falco --version
Falco version: 0.30.0
Driver version: 3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4

System info:

# falco --support | jq .system_info
Mon Nov  1 10:31:52 2021: Falco version 0.30.0 (driver version 3aa7a83bf7b9e6229a3824e3fd1f4452d1e95cb4)
Mon Nov  1 10:31:52 2021: Falco initialized with configuration file /etc/falco/falco.yaml
Mon Nov  1 10:31:52 2021: Loading rules from file /etc/falco/falco_rules.yaml:
Mon Nov  1 10:31:52 2021: Loading rules from file /etc/falco/falco_rules.local.yaml:
Mon Nov  1 10:31:52 2021: Loading rules from file /etc/falco/rules.d/rules-xxx.yaml:
{
  "machine": "x86_64",
  "nodename": "falco-bghk6",
  "release": "5.4.0-1059-azure",
  "sysname": "Linux",
  "version": "#62~18.04.1-Ubuntu SMP Tue Sep 14 17:53:18 UTC 2021"
}

Cloud provider or hardware configuration:
Azure AKS
Istio 1.11.3
Installation method:

Helm chart on https://github.com/falcosecurity/charts

Tested without the istio sidecar being injected, results are the same.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Move memory and parallelism settings for performance test projects to gradle.properties

So anybody running a performance test project will use the same settings as our performance tests.

@lptr If you have more comments, I can address them in a follow up PR.


Back Button freezes? App

Hey,
I logged in, went through all the bottom buttons and after I was at "Peers" I clicked back. The App went to the OD startup screen, but didn't move untill I killed and started it again.

Duplicate of #87


Cedar compatibility (updated)

Compatibility with cedar stack. Specify optional stack in config file; if present, will be used in rake heroku:create.
New and improved version of https://github.com/fastestforward/heroku_san/pull/55

+1

+1

Sorry it took so long to get this merged. Thanks for the work.


Split commit to address Maltonns's PR. Add test for SSVQE

the same test as in maltonn's Pr was added

Please change the title of the pull request, as it may not clear to others what they are about. Specifically, write “this is part of a split commit” and “what the commits are about”.

The test was indeed not set up correctly. It only produced the ground state energy.
Running the fixed code:
from pyscf import gto, mcscf, scf
from quri_parts.algo.optimizer import LBFGS

from chemqulacs.util import utils
from chemqulacs.vqe import vqemcscf
from chemqulacs.vqe.vqeci import Ansatz

geom_water = utils.get_geometry_from_pubchem("water")
mol = gto.M(atom=geom_water, basis="sto-3g")
mf = scf.RHF(mol)
mf.run()

mc = vqemcscf.VQECASCI(
    mf,
    2,
    2,
    optimizer=LBFGS(),
    ansatz=Ansatz.GateFabric,
    layers=2,
    excitation_number=3
)
mc.kernel()
print("-----Produced energies------------")
print(mc.fcisolver.energies)

Produces the output:
converged SCF energy = -74.9644475827695
----VQE-----
Optimizer converged
CASCI E = -74.9656951104499  E(CI) = -1.66322266488406  S^2 = 0.0000000
-----Produced energies------------
[-74.96569511044994, -74.56710399202518, -74.52886408322478, -74.52886408322476]

These are the same energies for which are tested in the ssvqe test.

The following SSVQE calculation
# Run CASCI with VQE with CAS(2e, 2o)
vqe_casci = VQECASCI(mf, 2, 2, optimizer=LBFGS(), ansatz=Ansatz.GateFabric,
                     layers=2, excitation_number=5)
vqe_casci.kernel()

gives the strangely degenerated result:
Calculated electronic state
state   Energy(Hartree) Excitation energy(eV)   Occupancy indicates
S0      -74.965695      0.0000
S1      -74.567104      10.8462                 1 -> 2
S2      -74.528864      11.8868                 0 -> 2
S3      -74.528864      11.8868                 1 -> 3
S4      -74.567104      10.8462                 0 -> 3
S5      -73.792297      31.9298                 0,1 -> 2,3

This is due to the how to generate initial states of SSVQE.
This part (in vqeci.py):
        # Set initial Quantum State
        for m in range(self.n_electron, 2 * self.n_electron + 1):
            if comb(m, self.n_electron, exact=True) >= self.excitation_number + 1:
                break
        else:
            raise Exception("excitation_number is too large")

        occ_indices_lst = sorted(
            list(combinations(range(m), self.n_electron)),
            key=lambda lst: sum([2**a for a in lst]),
        )[: self.excitation_number + 1]
        self.occ_indices_lst = occ_indices_lst

        state_mapper = self.fermion_qubit_mapping.get_state_mapper(
            2 * self.n_orbitals, self.n_electron
        )
        self.initial_states = [state_mapper(x) for x in occ_indices_lst]

In the case of
n_electron=2, n_orbitals=2, excitation_number=5,
fermion_qubit_mapping=jordan_wigner,

the initial states become
Initial State 0: ComputationalBasisState(qubit_count=4, bits=0b0011, phase=0.0)
Initial State 1: ComputationalBasisState(qubit_count=4, bits=0b0101, phase=0.0)
Initial State 2: ComputationalBasisState(qubit_count=4, bits=0b0110, phase=0.0)
Initial State 3: ComputationalBasisState(qubit_count=4, bits=0b1001, phase=0.0)
Initial State 4: ComputationalBasisState(qubit_count=4, bits=0b1010, phase=0.0)
Initial State 5: ComputationalBasisState(qubit_count=4, bits=0b1100, phase=0.0)

The obtained initial states 2 and 3 are not spin-adapted.
These states should be
$$
\frac{1}{\sqrt{2}}(|0110\rangle + |1001\rangle)
$$
$$
\frac{1}{\sqrt{2}}(|0110\rangle - |1001\rangle)
$$

As a summary, the specific revisions are as follows:

Please refactor the original initial state generator into a function.
Allow users to set the initial state as they wish.
If nothing is set, have it call the initial state generator.
For the test, please use the initial state I suggested.

We will address this debugging by creating a new issue.


feat: increase rate-limit global rules limit

What type of PR is this?
feat: increase rate-limit global rules limit
Which issue(s) this PR fixes:
Fixes #2900

/retest

can you add test for this? positive and negative.

can you add test for this? positive and negative.

hi @ShyunnY, maybe add a test in test/cel-validation/backendtrafficpolicy_test.go to ensure the CEL validation.

Sorry, this was an oversight on my part. I have added

/retest


Holiday allowance checkbox does nothing apparently

No changes when I click the checkbox.

I created a merge request #56 about this. But it needs to be reviewed and merged.

I think it is not a bug but the developer may have changed the behaviour regarding to an issue that was argued on #48
It seems still confusing. In my opinion its reason is some companies add the allowance to the net monthly wage but some of them pays it annually. So, if your company adds the allowance to your monthly wage, your calculation is correct. Otherwise you need to type your base salary (excl. holiday allowance) to find your monthly net.
If the company said you that the allowance is included your salary but it will be paid based on the real accumulated earnings of the past year, type your gross to the input, enable "Year Gross Holiday Allowance" option and substract it your gross (manually) and type the difference to the input to calculate your monthly net again.
Am I wrong? I talked with two of my friends in Netherlands and I got this result.

sorry guys, I was out offline for sometime.
@sadokx true, thank you for the feedback!
@mzaferyahsi I made a commend about it.
@koraykupe it's so true. I looking for the way to make it simple and clear for everybody

It shows € 3,604 as monthly net for 53000 gross and € 3,638 for 58000 gross.
(Holiday allowance included, Social security and 30% ruling selected)
May it be true? I think no.

thank you for you feedback,
but it is what it is: Payroll Tax is getting bigger in this case.
if you find exact mistake in calculation, please let me know.

@stevermeister but the payroll tax difference is only € 339 between them.

yes, true.
is it only for  Holiday allowance case?

@stevermeister yes, but without Holiday allowance the difference is € 857 as well. Where did €5000 go?

@eduardomourar may be you have an idea where we lost 5k?

By the way, can real percentage be bigger than 30? It shows 32% for this situation: http://thetax.nl/?year=2017&startFrom=Year&salary=55000&allowance=1&socialSecurity=1&retired=0&ruling=1

no, it can't be bigger than 30, it's one more bug :(

also related to incorrect holiday allowance

I disabled this option for now, while we don't figure out that would be the proper way to implement it also in UX not to may it so confusing

I did some checking to make sure that the calculation were alright:

So, the answer is yes. Even though I am comparing 2015 and 2014, the same logic will apply but tax rates will be different. If you compare only annual amounts (year gross income vs. year net income), adding 5k (58k - 53k) to gross gives 3.5k (46k - 42.5k), which makes sense due to taxes.

Regarding the 32% real percentage, yes, it is wrong. That is because we were calculating the holiday allowance with normal rates, but it has a special rate for that. This was already fixed with the new version with angular 4.

@eduardomourar My friend earns 55K gross yearly and gets ~3400 as net monthly (with 30% rule) in practice. It is less than your calculation. I don't know why. His company might pay holiday allowance yearly but he is not sure. He started in March this year. May it be related to it?
By the way,
How income taxes is calculated?
Let's assume that taxable income is 37000
2017 Total rate is 36.55% up to € 19,982
and 40.80% for € 19,982 to € 67,072
Is the tax amount 37000 * 40.80 = 15.096 or (19982*36.55) + (37000-19982)*40.80 = 7303 + 6943 = 14.246?
And how is personal tax credit and Labour tax credit calculated?

@koraykupe, first of all, let me be clear that I am not a Dutch tax expert. That being said, there are other tax benefits that this tool doesn't consider like rent benefit, child benefit (that you mentioned and it does effect the overall tax credit, yes) and health care benefit, which might apply to your friend.
Just so you know, I also started to work in the Netherlands March 20th this year, and when I compare the monthly gross amount on my payslip, the calculator has €1 less (without 30% ruling) and €2 less (with ruling). So when you have a case like these, that you need to calculate taxes partially for a year and also for a month, getting the precise amount can be really hard and I guess that is why see a difference. Also, keep in mind that is quite common to receive the full (or proportional in my case because I only worked 53 out of 260 business days) holiday allowance in May, or sometimes June.
Regarding you question, if you are talking about taxes on a payslip level, you calculation is correct for the tax amount (payroll + social security tax) ~€14.247. To calculate tax credit I would suggest you look into the code and links here, but basically general credit €1.439, which is €2.254 - 4,787% x (37.000 - 19.982), and labour credit €3.058, which is €3.223 - 3,6% x (37.000 - 32.444).


A way to get current config, or call webpack directly?

I was looking at using https://chrisbateman.github.io/webpack-visualizer/ to get some idea of what's in my bundle, but there isn't really a way to pass arbitrary flags to webpack like this.
One approach would be to provide a command which outputs a node file that generates the same config that would be produced by running the other commands, eg.
kotatus make-config --all --the --usual --flags > webpack.config.js
cat webpack.config.js
module.exports = require('kotatsu/make-config')({ all: true, the: true, usual: true, flags: true });

Another option might be to provide a way to configure via a .kotatsurc file or similar (perhaps .config/kotatsu, to start avoiding the proliferation of files in the root of things. Then I could do webpack --config kotatsu/config and it would autodetect my choices.

Those are good ideas. Let me check what I can add.

Hi, for this specific use case, I use webpack-visualizer-plugin as a webpack plugin and not from its web page.
From a kotatsu project:
npm install --save-dev webpack-visualizer-plugin

In webpack.config.babel.js:
import Visualizer from 'webpack-visualizer-plugin'

export default {
  plugins: [
    new Visualizer()
  ]
}

kotatsu serve --config webpack.config.babel.js src/index.js

Open http://localhost:3000/build/stats.html (generated dynamically)
=> We see the generated page with the "sunburst" diagram
kotatsu build generates a file in the output dir.
Hope this helps!
Next steps: add a --stats option? @Yomguithereal Pull Request suited?
Mock example:
kotatsu serve --stats src/index.js
[kotatsu] (v0.13.0)
Compiling - [==============================] 100%
[kotatsu] Built in 3.5s.
[kotatsu] Done!
[kotatsu] Serving your app on port 3000...
+[kotatsu] Stats available at http://localhost:3000/build/stats.html

This is a nice idea indeed @cbenz. But I feel that the deps introduced by the plugin (notably d3 and React) might hurt some recent projects using npm3.

@Yomguithereal I understand, so let's keep it as a recipe :)


[spi_device] Default to Flash Mode

As BootROM moves to SPI Flash mode to download the images, Generic Mode(a.k.a FwMode) has no usage as of now.
The change to Flash mode needs a few cautious steps due to the clock switch between Generic and Flash/PassThrough mode.
It would be better to have Flash mode by default and SW can skip the clock change sequence from their codes.

sounds good to me!

SGTM, this would eliminate 3 writes at the end of spi_device_init() (here).

For clarity for future readers: "has no usage" and "SW can skip" are only in the context of the boot ROM. Generic mode is supported for post-ROM firmware, and their drivers should take care with power-on defaults. :smile:

quickly checked. Probably no need to change DV sequence as the SPI mode can be updated automatically (DV knows the design default value and the mode sequences want to use)

OK. I will revise the default value. As SPI_DEVICE IP has TPM, Flash modes, I think usage cases of Generic Mode are rare. So, to lessen the burden of back end team, it would be good to remove the feature.
Generic mode creates hassles of maintaining two distinct clocks for the DPSRAM that create many CDC issues to be reviewed.


Wikipedia Dumps

Upload processed Wikipedia dumps to huggingface

Done! https://huggingface.co/datasets/ToluClassics/masakhane_wiki_100


Date parameter for /accounts/balance

Date parameter in the /balance endpoint is missing. How could the balance for a specific day be requested?
balance - blink AIS

balance - common-API

Done.