docker premount postmount implementation using channels

Hi @crosbymichael @jlhawn
I am working on a change for backing up the contents of a mount point (e.g. /run) into a tar stream (Premount), and unpacking the tarstream back once the mounting is done (Postmount). This will help us examine the contents of the image,
@rhatdan was already working on this change, and I am continuing on his efforts.
https://github.com/docker/docker/pull/8478
We are stuck in a strange problem where we are not able to share channels between docker and libcontainer.
I did a small POC in golang, and it works fine if I need to share channels between 2 different packages to synchronize. Can you help us on why it is not working in this particular case {docker: libcontainer}
Below is a small POC to elaborate on what I am trying to do.
Shishir

@mrunnal @crosbymichael @jlhawn We have had a couple of passes on this. First pass was to attempt to pass a  call back function from Docker to libcontainer, but this got blocked because passing functions via json seems to be impossible or very difficult.  So we changed to attempt to use channels, which seemed very promising.  But now we seem some strange interactions that we do not see when using standard go code.
What I would like to see is the abiltiy for a tool using libcontainer to be able to register for a PreMount Channel and a PostMount Channel, in which the caller could implement tooling.  The obvious example would be for mounting a tmpfs over a particular directory.  We would want premount to look at the content of the directory and tar it into memory.  In the postmount we would
untar the memory over the newly created tmpfs.
I could see future tools taking advantage of this capability also.  For example creating certain directories/config on mountpoints after they get created.

BTW This is not really a pull request, but just a way to show you an example of where we are blocked.
If we became unblocked, we could easily complete the pull request.

@shishir-a412ed @rhatdan This is because mount.Mount called in other process with other go-runtime.

I think it is possible to implement such channels over additional pipes to our init-process.

@LK4D4 Ok, how?  :^)

It is design change to libcontainer, so we should discuss it first. But I think it is possible to pass some descriptors as ExtraFiles to initProcess and then just close them when event is occur. Or this can be file lock or some other form of IPC.

@rhatdan @LK4D4 Is this related to https://github.com/docker/libcontainer/issues/380. Based on the thread, i guess the goal is to have PreMount and PostMount callbacks happening inside the fs namespace. Something like:

setup fs namespace
call PreMount
setup mounts
call PostMount ( or do we want this to be called after pivot root ? )

In https://github.com/docker/libcontainer/issues/380, I talked about adding hooks as external scripts ( similar to how http://man7.org/linux/man-pages/man5/lxc.container.conf.5.html works ), but i think creating an additional pipe and/or reusing the initPipe to deliver container events could work too.

@shishir-a412ed @rhatdan Now, when we know why channels is not working, can we move discussion about implementation to docker/libcontainer#380 and close this PR?

Yes we can go back to discussion there.

@rhatdan Thanks!


Error when "restore database from URL" encountered in sql files

I followed along with the instructions at https://erikej.github.io/efcore/2020/05/11/ssdt-dacpac-netcore.html and it was going okay until the build encountered an azure restore database xxx from url = 'xxx' statement, at which point it errored:
Adding /home/tim/repo/.../Restore_v1.0.sql to the model
Unhandled exception: System.Reflection.TargetInvocationException:
Exception has been thrown by the target of an invocation.
 ---> Microsoft.SqlServer.Dac.Model.DacModelException: Add or update objects failed due to the following errors:
EXEC : error SQL46010: Incorrect syntax near URL.
[/home/tim/repo/.../Database.Build.csproj]

The restore database from url option is documented here: https://docs.microsoft.com/en-us/sql/relational-databases/backup-restore/sql-server-backup-to-url?view=sql-server-ver15#support-for-restore-arguments and I see there is a matching option on backup database to
Thanks for the project!

Please share your project (at least options)

The work in progress is here: https://github.com/SkillsFundingAgency/dfc-coursedirectory/blob/linux-builds/src/Dfc.CourseDirectory.Database.Build/Database.Build.csproj (work in progress branch, may disappear later)
It pulls in https://github.com/SkillsFundingAgency/dfc-coursedirectory/tree/cd887928fb48e08cafcd8c34eac8d207ebe283f0/src/Dfc.CourseDirectory.Database

I had a look around and according to this post it seems that it is also an issue with the existing .sqlproj format. @timabell Does the .sqlproj compile as it is, or does it give you the same error?
The post linked above suggests to use dynamic SQL to resolve it, although that is of course less ideal.

Or maybe move the offending script to PostDeployment with "CREATE OR UPDATE" ?

@jmezach The visual studio sqlproj does compile and create a dacpac, yes.
I tried the dynamic sql option and that indeed get past the error though at a cost of the ability of tooling to analyse the file.
I've realised I probably don't actually need that script in the linux build of the dacpac for local development at the moment so I've altered my linux build csproj to not include the problematic folder and now have a successful build. Thanks for your help on this.
@ErikEJ thanks for the suggestion, I didn't get as far as trying it.
I don't know if it makes sense to keep this issue open as I'm not that familiar with dacpacs and don't know if a database restore would be a normal thing to keep in them. I may return here if I end up needing it as part of the build setup later.
Thanks again, very grateful for the quick and helpful responses.

I would expect the original .sqlproj to fail with the same error actually, since both project file formats should be using the same SQL parser. Unless the offending file is not part of the build in the original .sqlproj. What is the build action for that file?
Either way I don't think there's much we can do here if the parser doesn't support it. I checked if there's an update to the NuGet package we're using, but alas there's no newer stable version.
@ErikEJ I've added the suggested workarounds to the README so I think we can go ahead and close this.

Agree, not something this project can fix - we should keep eyes on updates to the NuGet pckage, but I do that regularly anyway for EF Core Power Tools.


Enhancement

Hello,
This is  a really cool enhancement and thank you a lot!.
I wanted to know if it would be possible to make a enhacement that could facilitate the reporting (advanced view).
I was thinking the following:
Is it possible to have in the field the values stored with just ; like a regular multiselect? I have all the technical field (Id) which is stored in the field but I only need to have the values.
Please

Hi!
Thanks for the feedback!
However, as I changed this to open the form I would need the ID as well, I can suggest to you two things:

You can download the version 0.9.53 that is the one I had before.2
Go and download this PCF https://pcf.gallery/multiselect-entity-picker/ Probably that's more what you expect.

Let me know if I can help you with any of those.
Thank you!

In fact, yours is much more pretty and better explained. Moreover you have an impressive filter that was not able to reproduce in the other PCF.
I downloaded the previous version you mentionned but faced some bugs that are solved in current version so I will not be able to use.
Do not worry I will use the latest version you implemented

Great, thanks for the feedback.
Do you think a new PCF with the previous version with bugs fixed would be helpful for the community? If so I can work on that.
What are the bugs you found so I can work with them from version 0.9.53?
Thank you!

I think it would as many customers want to use advanced views. What i was not able to do with 0.9.53 is that results were not displayed directly, I had to type some letters and then click enter (there is no loop like the latest version

Great! Thanks for that! I will create a new PCF so instead of creating tags, the values will be displayed split with the delimiter you want. I will merge the latest features we have for this PCF with the previous one.
Hopefully that will solve the issue you are having. I will contact you once I create the new PCF if you want through this issue, would you like that?
Thanks!

That would BE AWESOME!

Great I will work on that, meanwhile, I can suggest to you creating an onChange function so you can take the attribute you are changing with the MultiSelect, and then set the values in another one.
Like:
var multiselectJSON = getAttribute("multiselect").getValue().map( item => item.name)
getAttribute("yourfieldtodisplay").setValue(multiselectJSON)


showing metrics graph on ingress

how can I have ingress to show metrics graph ? as for now, when you see the ingress sidebar you will read Metrics not available at the moment. so how to have it show the metrics. thanks

Marking this as a bug, since it is still not working (as of 4.2.0-rc.2) and the ingresses is listed as part of https://github.com/lensapp/lens/blob/67898152171cd8a9f6f927f12c47aa306105158c/extensions/metrics-cluster-feature/resources/'s allowed RBAC permissions.

I'm also experiencing this issue, any progress?

would be great to have ability to customize queries for metrics so we could have ability to fix such stuff on our own


Wrong reshape order in PEG

hello, when review your code, find one problem that make me confused:
x = x.reshape(*shape, -1) # in PEG.forward at OmniTokenizer/modules/attention.py
original shape of x is  [b * h * w, t, d], however the target shape is [b, t, h, w, -1] when it called by dec_temporal_transformer or enc_temporal_transformer in OmniTokenizer/omnitokenizer.py
conv3d after this wrong reshape has no meaning for model upon disrupted time-space info.  however, the encode&decode results of he provided model seems ok,  surprising.

Thanks! Fixed already


[BUG] Workflow definition display exception

This is because the arrow icon is clicked and the Bezier line is selected, which is caused by the component

What should I do to avoid it

Don't click the arrow icon if you don't need to delete the connection and node.
If you have clicked the arrow icon, you can click the arrow icon again to deselect it


Do you have plan of adding RWKV finetuning?

Hello,
Do you have plan to integrate RWKV, which should be super fast on embedded devices?
Best,
Zhuoheng

@StarCycle  Hi!
I think that xtuner has already supported the fine-tuning of RWKV (but we do not test it), because transformers supports the RwkvForCausalLM models(https://github.com/huggingface/transformers/blob/main/src/transformers/models/rwkv/modeling_rwkv.py)
Maybe you can have a try. Feel free to contact me if there is any progress.

Great thanks!


Add specific context to server requirements

@kenjohnson03 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Adding the H3 would not make sense as the table is doesn't provide SQL recommendations.  The table only recommends the size of the server that would be required to run Azure AD Connect (assuming the local SQL install).  To add this header the table would need to be updated to provide recommendations on whether to use a local instance of SQL or a remote one.
#please-close


[1.x] Add Universal 2nd Factor (U2F)

Please check these requirements

[X] This feature helps everyone using this package
[X] It's feasible and maintainable
[X] It's non breaking
[ ] I issued a PR with the implementation (optional)

Description
It will be nice to have an option to add U2F from hardware token like the Yubikey 5 NFC

Code sample
tbd

That's sounding great, but I don't have a Yubikey 5 NFC, and buying one from the store takes a whooping $100 I don't plan to invest in. Let alone a cheap testing phone (I only have one).
If anyone has both and is willing to add the code necessary to make it work, I'll accept that PR.

If you want to dig into i can give you a free key 🙃

If you want to dig into i can give you a free key 🙃

Cool, that's half the problem fixed. I'll get a cheapo phone to test. Drop me an email if you want the address. I'm Chile, BTW.


silent=False causes the rainforest to die

I had the best of intentions when setting silent=False automatically. However, I misread the Jinja2 code. I thought it'd just print out the errors and move on.  That's totally not what we want.
Given that, we should nix it automatically getting added.

I would like it to be a command line option, however. It uncovered a lot of problems we should fix.

pybabel doesn't have this as a command line option. It's not too hard to add--you just set JINJA_CONFIG yourself rather than have Puente figure it out for you. Having said that, that's not wildly convenient.
We could make it another setting, but that feels a bit weird.
I don't have other ideas.

Oh, I know! How about we automatically add it on Mondays and the rest of the week, it doesn't get automatically added. Is that a good idea?

Rob fixed MDN to work with everything while having silent=False. In doing that, he discovered bugs in MDN!
After talking about this some more, we decided to leave it with silent=False for now since that will uncover issues.

This uncovered a bunch of template issues and that turned out to be really good. I'm going to leave this in and close this out for now.


chore: remove index parameter from index_block

The index object is already contained in self, so no need to pass it to an instance method, this also avoids referencing to the same object in two ways(index and self.index).

LGTM!


[Bug]: NullReferenceException thrown when calling BrowserTearDown

Version
1.44.0
Steps to reproduce
All tests are failing due to TestCleanup error.
Expected behavior
TestOK property correctly returns true or false and tests are passing., and tests pass
Actual behavior
Message: TestCleanup method XXX.BrowserTearDown threw an exception. System.NullReferenceException: Object reference not set to an instance of an object...
Stack Trace:
PlaywrightTest.get_TestOK() line121
BrowserTest.BrowserTearDown() line54
Additional context
In the PlaywrightTest class line 125
public TestContext TestContext { get; set; } = null!;
The TestContext property is not correctly set up to be automatically injected by MsTest. The initialisation to null! might be misleading.
Solution:
protected bool TestOK
{
   get => TestContext.CurrentTestOutcome == UnitTestOutcome.Passed || TestContext.CurrentTestOutcome == UnitTestOutcome.NotRunnable;
}

public TestContext TestContext { get; set; }

Environment
- Operating System: [Windows 11]
- CPU: [arm64]
- Browser: [All]
- .NET Version (TFM): [net8.0]
- Other info:

Could you help us how to reproduce this issue? We have not seen this before.

`namespace TestProject
{
[TestClass]
public class UnitTest1 : PageTest
{
[TestMethod]
public async Task HomepageHasPlaywrightInTitleAndGetStartedLinkLinkingtoTheIntroPage()
{
await Page.GotoAsync("https://playwright.dev");
        // Expect a title "to contain" a substring.
        await Expect(Page).ToHaveTitleAsync(new Regex("Playwright"));

        // create a locator
        var getStarted = Page.Locator("text=Get Started");

        // Expect an attribute "to be strictly equal" to the value.
        await Expect(getStarted).ToHaveAttributeAsync("href", "/docs/intro");

        // Click the get started link.
        await getStarted.ClickAsync();

        // Expects the URL to contain intro.
        await Expect(Page).ToHaveURLAsync(new Regex(".*intro"));
    }

    public TestContext TestContext { get; set; }
}

}
`

I see, looks like a MSTest bug to me. When TestContext gets overridden, then the inherited class TestInitialize or TestCleanup won't have access to it anymore:
namespace dotnet_mstest;

public class BaseClass
{
    public TestContext TestContext { get; set; } = null!;

    [TestCleanup]
    public void BaseClassTearDown()
    {
        Console.WriteLine("BaseClassTearDown: " + TestContext.TestName);
    }
}

[TestClass]
public class UnitTest1 : BaseClass
{
    [TestMethod]
    public void MyTest()
    {
    }

    // If you comment out the following line, BaseClassTearDown works as expected.
    public TestContext TestContext { get; set; } = null!;

    [TestCleanup]
    public void UnitTest1TearDown()
    {
        Console.WriteLine("UnitTest1TearDown: " + TestContext.TestName);
    }
}

Expected: Passes
Actual: In BaseClassTearDown TestContext is null.
@terius7 as a workaround you can maybe not re-define TestContext and use ours? Since its also public.

Please avoid overriding the property and it will work, and the property will be inherited to all the children.
I don't think this is a bug per-se, the code does exactly what you are asking it to, you have a property TestContext that is hiding a property on the base class, the compiler even recommends to make this explicit by using the new modifier on the property, to highlight that this is hiding a non-overridable member on the base class.
I agree this is not obvious when executing tests, and the framework could work around this edge case at the expense of being a bit slower. And also not being consistent with the behavior of hiding a test method, where only the one visible on the current class is executed (the orange one in the screenshot below).

@evangelink do you think we should fix this in MSTest?

Thanks for the analysis @nohwnd! I do agree with you that we should close this issue as MSTest is working as "intended" when you are doing shadowing. But we agree that shadowing a member in the context of testing is most of the time a bad idea and should be prevented, to this goal we will add an analyzer: https://github.com/microsoft/testfx/issues/3263.
Looking at the code in this issue, I have also noticed that it seems to be a common practice to use the = null! to avoid the nullability analysis, to simplify the code, I suggest to add a code suppressor on MSTest so that's not required: https://github.com/microsoft/testfx/issues/3262


Should check enc_init instead of checkpoint at line 166 in init_model.py

Describe the bug
There might be a typo at line 166 in init_model.py. The check should be on enc_init, but now it's on checkpoint
To Reproduce
Steps to reproduce the behavior:

Go to wenet/utils/init_model.py
Scroll to line 166
The check should be on enc_init, not on checkpoint

Good catch!

Fixed, see https://github.com/wenet-e2e/wenet/pull/2354


[P2] Uncaught TypeError: WebGLRenderingContext.bindBuffer: Argument 2 is not an object.

Summary
Noticed this error + stack trace while playing a practice game locally:
Uncaught TypeError: WebGLRenderingContext.bindBuffer: Argument 2 is not an object.
    postStep vendor.js:52124
    postStep vendor.js:51396
    update BaseParticleSystem.js:1337
    resetSystem BaseParticleSystem.js:1163
    updateSourceToTarget BaseParticleSystem.js:584
    setSourceScreenPosition BaseParticleSystem.js:250
    onResize BattleMap.js:303
    triggerEvents eventbus.js:156
    trigger eventbus.js:89
    resize Scene.js:270
    onResize application.coffee:3489
    later vendor.js:16021
    setTimeout handler*later vendor.js:16017
    setTimeout handler*later vendor.js:16017
    setTimeout handler*_.debounce/< vendor.js:16033
    dispatch vendor.js:4676
    handle vendor.js:4360
vendor.js:52124:8

I'm not sure what the impact is, yet. It seems specific to BattleMap.js.
Impacted services
[x] The frontend app
[ ] The game servers
[ ] Game builds or automation scripts
[ ] Tests or Github Actions
[ ] Infrastructure (Terraform)
Steps to reproduce

Play a practice game; should appear in the console.

Environment information

Operating system: Mac
Browser: Firefox
Browser version: 105.0.1

This appears to also result in disappearing history icons.


[type="submit"] and button line-height

Buttons inherit line-height while inputs don't. Had to change 323 line to

input {
line-height: inherit;
}

Is it OK?

I might be wrong, but it seems that line-height: inherit; is now default behavior for Firefox 34.0.5 and Opera 12.1, while Chrome using it's own predefined line-height (probably normal)

Yes, Chrome's UA stylesheet sets line-height: normal for inputs (as of Chrome 48 anyway):

Firefox 45 also sets line-height: normal (not inherit) for inputs:

@cvrebert, does this mean the fix normalizes behavior on older versions of Firefox and Chrome now? Do you have a way to test? If not, let me know and I will.

Ditto for Safari 9.0.3:

@jonathantneal https://github.com/necolas/normalize.css/blob/5daad010a2f19c12b89f317ba9d2c8e4573210d7/normalize.css#L328-L335 already normalizes this (albeit for different reasons).

The line-height issue was resolved in Firefox 30, so this normalization may be dropped.


Oguejiofor o

Added additional use_cases and screenshot

Thanks for the PR, @oguejioforO. Looks good. 👍🏻


remove warning that was breaking roachtest

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

TFTRs!


Labels for column titles above and below the graph

Plant (Latin Name)
Compound (CAS)
Protein (Uniprot Name)
Disease (OMIM ID)
@hzb-imasine

Closed, although diff font sizes between above and below, why?


Typescript/tsx attribute names auto-completion is cluttered with js/ts keywords

VSCode Version: 1.20.1
OS Version: Windows 10
Typescript: 2.7.1

Steps to Reproduce:

Open a .tsx file
Enter a JSX tag and hit ctrl-space to suggest attributes
Here's my auto-completion list:

Notes:
I'm pretty sure it was working fine a few weeks ago, but can't guarantee it because I jumped a lot between IDEs these last weeks.
If keywords cannot be excluded, it would be better to have the attributes at the top, it's a huge time saver when using React components.

Does this issue occur when all extensions are disabled?: Yes

Tracked upstream by https://github.com/Microsoft/TypeScript/issues/21844
Should already be fixed in typescript@next if you want to give that a try in your workspace


Azure DevOps Demo Generator's limits

Hello,
Where are we supposed to find the product limitations ? I can see that : "Note: The Extractor supports only limited artifacts and work item types and so it should not be considered as a migration tool for moving projects from one server to another. For what's supported and what's not supported, see the limitations section"
But I cannot see the limitations section. Could you please help ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 584e779c-a484-6c51-46db-c1b25c16f757
Version Independent ID: 64b06470-064b-091a-ca10-b9c29dbc57f1
Content: Build an Azure DevOps Demo Generator template
Content Source: docs/demo-gen/build-your-own-template.md
Product: devops
Technology: devops-new-user
GitHub Login: @hsachinraj
Microsoft Alias: sraj

Can these limits be lifted/tweaked somehow at least pragmatically in the code, after the file generation for example?

I think you might have already seen this, but there is a page in the git repo about the limitations
https://github.com/microsoft/AzureDevOpsDemoGenerator/blob/master/docs/Limitations.md

I think you might have already seen this, but there is a page in the git repo about the limitations
https://github.com/microsoft/AzureDevOpsDemoGenerator/blob/master/docs/Limitations.md

How does that answer my questions?

I think you might have already seen this, but there is a page in the git repo about the limitations
https://github.com/microsoft/AzureDevOpsDemoGenerator/blob/master/docs/Limitations.md

Thank you. Indeed I think that the Microsoft doc's note :
"Note: The Extractor supports only limited artifacts and work item types and so it should not be considered as a migration tool for moving projects from one server to another. For what's supported and what's not supported, see the limitations section"(https://docs.microsoft.com/en-us/azure/devops/demo-gen/build-your-own-template?toc=%2Fazure%2Fdevops%2Fdemo-gen%2Ftoc.json&bc=%2Fazure%2Fdevops%2Fdemo-gen%2Fbreadcrumb%2Ftoc.json&view=azure-devops) refers to your link (the github's documentation)


Provide access to state for (debug) printing transitions

We are making heavy uses of sample::Index to deterministically access state as part of our transitions. This works well functionally but makes debugging difficult because it obfuscates, what the transition actually does.
Applying transition 15/18: SendQueryToDnsResource { r_idx: Index(3156979778377414915), r_type: A, query_id: 10855, dns_server_idx: Index(4470972928535618001) }

The above is a transition that simulates sending a DNS query to a system but the domain that is being queried and which server it uses are part of the state and thus determined as part of applying the transition.
It would be useful if the transitions would have to implement a specialised Debug trait that gives access to the current state and allowed resolving these indices to the actual value it is being applied.

Thanks for the feedback. I'll be doing some triaging this weekend after being away for a bit and will take a look at what this may entail. Do you have a workaround you're currently using or is this an active thorn in your side?

Thanks for the feedback. I'll be doing some triaging this weekend after being away for a bit and will take a look at what this may entail. Do you have a workaround you're currently using or is this an active thorn in your side?

Not really using a workaround at the moment. We usually turn up logs of the production code which often contains the same, useful values (like domains & IPs in this case).
This isn't very critical but more a QoL thing as you tagged it as!

Perhaps I can hijack this thread to ask a question on whether we are doing things correctly. Looking at some of the code that proptest-state-machine executes, it looks like I should be able to directly return transitions that are based off the current state:
https://github.com/proptest-rs/proptest/blob/24412f5f10a365c8f12a71e3b3a053677ced91b0/proptest-state-machine/src/strategy.rs#L191-L194
There are two problems with this:

ReferenceStateMachine::transitions doesn't allow returning borrowed data from Self::State, requiring lots of cloning
It doesn't appear to play very well with shrinking. In particular (if I remember correctly) I've found that a strategy based on the initial state, once shrinking is applied to the state doesn't get re-initialised with the shrunk state but keeps its old state.

If a transition could reference the current state and as in the above example, just select a DNS server or a domain, then this issue would also be resolved.

Do you have a workaround you're currently using or is this an active thorn in your side?

I noticed that one way of working around this could be to override test_sequential on StateMachineTest.

We've moved away from indices in most places, making this problem go away.


UNet channel dimension: Some n_filters_factor multiplication causing error

IceNet version: v0.2.7_dev
Python version: 3.11

Description
Running with certain n_filters_factor causes mismatching channel dimensions. E.g. n_filters_factor = 0.3 and n_filters_factor = 0.6. Using values of 0.5 or not setting it doesn't cause issue.
Believe this to be due to Python's bankers rounding approach.
When the channel dimension is multiplied by this factor, and the result is a value which is rounded to the nearest even value - result becomes inconsistent depending on input value to int().
What I Did
Omitting stdout for successful commands:
Note n_filters_factor=0.3 is the change causing the error compared to 0.5, or 1.0 which runs without issue.
$ icenet_data_masks south
$ icenet_data_era5 south -d --vars uas,vas,tas,zg --levels ',,,500|250' 2020-1-1 2020-4-30
$ icenet_data_sic south -d 2020-1-1 2020-4-30
$ icenet_process_era5 notebook_tf_data south -ns 2020-1-1 -ne 2020-3-31 -vs 2020-4-3 -ve 2020-4-23 -ts 2020-4-1 -te 2020-4-2 -l 1 --abs uas,vas --anom tas,zg500,zg250
$ icenet_process_sic notebook_tf_data south -ns 2020-1-1 -ne 2020-3-31 -vs 2020-4-1 -ve 2020-4-20 -ts 2020-4-1 -te 2020-4-2 -l 1 --abs siconca
$ icenet_process_metadata notebook_tf_data south
$ icenet_dataset_create -l 1 -fd 7 -ob 2 -w 4 notebook_tf_data south
$ icenet_train notebook_tf_data notebook_tf_testrun 42 -b 4 --epochs 10 --multiprocessing --max-queue-size 4 --workers 4 --n-filters-factor 0.3 --no-wandb
$ ./loader_test_dates.sh notebook_tf_data | tee testdates.csv
$ icenet_predict -n 0.3 -t notebook_tf_data notebook_tf_testrun example_south_tf_forecast 42 testdates.csv

Traceback on last command:
[31-12-23 18:51:42 :INFO    ] - Loading configuration ./dataset_config.notebook_tf_data.json
[31-12-23 18:51:42 :INFO    ] - Training dataset path: ./network_datasets/notebook_tf_data/south/train
[31-12-23 18:51:42 :INFO    ] - Validation dataset path: ./network_datasets/notebook_tf_data/south/val
[31-12-23 18:51:42 :INFO    ] - Test dataset path: ./network_datasets/notebook_tf_data/south/test
[31-12-23 18:51:42 :INFO    ] - Loading configuration /git/icenet/notebook-pipeline/loader.notebook_tf_data.json
[31-12-23 18:51:42 :INFO    ] - Loading model from ./results/networks/notebook_tf_testrun/notebook_tf_testrun.network_notebook_tf_data.42.h5...
Traceback (most recent call last):
  File "/miniconda3/envs/pytorch/bin/icenet_predict", line 33, in <module>
    sys.exit(load_entry_point('icenet', 'console_scripts', 'icenet_predict')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/git/icenet/icenet/icenet/model/predict.py", line 198, in main
    predict_forecast(
  File "/git/icenet/icenet/icenet/model/predict.py", line 66, in predict_forecast
    network.load_weights(network_path)
  File "/miniconda3/envs/pytorch/lib/python3.11/site-packages/keras/src/utils/traceback_utils.py", line 70, in error_handler
    raise e.with_traceback(filtered_tb) from None
  File "/miniconda3/envs/pytorch/lib/python3.11/site-packages/keras/src/backend.py", line 4359, in _assign_value_to_variable
    variable.assign(value)
ValueError: Cannot assign value to variable ' conv2d_4/kernel:0': Shape mismatch.The variable shape (3, 3, 76, 153), and the assigned value shape (152, 76, 3, 3) are incompatible.

Issue with scaling channel dimension by n_filters_factor.
Based on traceback, issue likely to be where channel dimension is set to 512 (0.3*512 = 153.6), error shows 153, or where it is taken as an input to the next layer:
https://github.com/icenet-ai/icenet/blob/ea3c3a7528b419e409e59ee6c0db35397606ef2d/icenet/model/models.py#L113-L138

Basic working example representing issue:
n_filters_factor = 0.3
channels = [64, 128, 256, 512]

# Multiply each element by n_filters_factor
channels_times_nfac = [c*n_filters_factor for c in channels]

# Cast floats to ints
int_channels_nfac = [int(c*n_filters_factor) for c in channels]

# Multiply each by 2 for shape conv2d is expecting
int_channels_nfac_x2 = [2*c for c in int_channels_nfac][:-1]
int_channels_nfac_x2.insert(0, int_channels_nfac[0])

print(channels_times_nfac)
print(int_channels_nfac)
print(int_channels_nfac_x2)

Output:
[19.2, 38.4, 76.8, 153.6]
[19, 38, 76, 153]
[19, 38, 76, 152]

Looks like could be because of upsampling a layer by 2, culprit does still seem to boil down to rounding causing difference in values.

Using multiple of base 64*n_filters_factor for input channels should fix issue.
Example:
n_filters_factor = 0.3
start_out_channels = 64
reduced_channels = int(start_out_channels*n_filters_factor)
channels = {}
for pow in range(4):
    value = reduced_channels*2**pow
    channels[start_out_channels*2**pow] = value

print(channels)

Output:
{64: 19, 128: 38, 256: 76, 512: 152}


Issues with ChildContent using attribute selector

So, it's me again. I'm having problems to mock component using ContentChild selected by attribute. Here is the demo: https://stackblitz.com/edit/ng-mocks-examples-mp9pgs?file=app/app.spec.ts
Related to #68
Thank you so much for your work. And, do you have a patreon or something so that I can buy you a beer ? :beers:

Thanks for the report!
About beer, thanks, it would be nice. The next task is to configure patreon 🤣

NVM, this explains a lot of things actually  :sweat_smile:

Yeah, but please wait with closing it. I added a fix to avoid runtime failures in such cases.

Hi @GerkinDev,
how is life? I hope everything is fine on your side.
It took a while, and finally I've finished the process of verification and can officially accept beer donations: https://github.com/sponsors/satanTime.

Hi @GerkinDev,
how is life? I hope everything is fine on your side.
It took a while, and finally I've finished the process of verification and can officially accept beer donations: https://github.com/sponsors/satanTime.

Hey there ! Finally ! So, it ain't that much, but I will for sure back you much more when the fundraising of my company is done :) for now, I'm quite low on money.
Take a beer, you deserve it ;)


update kafka-sidecar to support separate key and value format from Reactive Consumer

Currently, we are using Schema Registry to simplify the Reactive Consumer configuration and it requires that both key and value from the Kafka record should have a schema defined with jsonschema, avro or protobuf.
When we are doing that, the key will have the magic bytes even with string format and requires that the producer uses the same schema to produce the record. When working with third-party applications, the producer might just use the string format with the magic key. We need to update the sidecar ReactiveConsumer to support this use case; however, we don't want to make the configuration exposed to normal users as it will make them confused. These configuration properties will be only used by advanced users.

 update kafka-sidecar to support separate key and value format from Reactive Consumer kafka-sidecar master


Add Drop to GIF.app version 1.25

Zero-click movie to GIF conversion. Select a folder to watch and every movie saved or moved into that folder will be converted to an animated GIF. https://github.com/mortenjust/droptogif

Thank you for the contribution. It needed some fixes, so they were made in 3062d08cc430703a9acd2dc1859fa26839fc62a2. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


help

i need help so it keep showing me this error whenever i use webserver
File "C:\Users\\Desktop\Python\Discord\Test.py", line 3, in <module>
    from webserver import keep_alive
  File "C:\Users\\AppData\Local\Programs\Python\Python310\lib\site-packages\webserver\__init__.py", line 17, in <module>
    run_command(["sudo", "mkdir", "-p", f"/etc/webserver/{folder}"])
  File "C:\Users\\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 501, in run
    with Popen(*popenargs, **kwargs) as process:
  File "C:\Users\\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Users\\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1438, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified

and i found a python script so i copied it and then i ofcourse configured it and then after that its working pretty fine without wbeserver but it keep saying "Server couldn't open" this is the code:
import discord
import python_aternos
import webserver
from discord.ext import commands
from python_aternos import Client
from webserver import keep_alive

token =''
client = commands.Bot(command_prefix='$', help_command=None)

@client.event
async def on_ready():
    print(f'Logged in as {client.user}')

@client.command()
async def start(ctx):
    try:
        aternos = Client.from_credentials("", "")

    except Exception as e:
        await ctx.send("Couldnt log in")
        await ctx.send(f"Error {e}")

    else:
        servs = aternos.list_servers()

        for serv in servs:
            if serv.address == 'HorizonSmpDNK.aternos.me:12584':
                myserver = serv

        try:
            myserver.start()
        except:
            await ctx.send("Server couldn't open.")
        else:
            await ctx.send('await ctx.send("SERVER SUCESSFULLY OPENED!\nServer Address: HorizonSmpDNK.aternos.me:12584\nPort: 12584")')

keep_alive()
client.run(token)

yes i copied the code but it isnt working pls respond i really need help i've been stuck...
this is my plan so basically on discord if someone typied $start the server will start but instead it will just say "Server couldn't open" i tried $start many times... pls respond :(

try:
    myserver.start()
except:
    await ctx.send("Server couldn't open.")

Please, replace this code with:
try:
    myserver.start()
except Exception as ex:
    print(ex)

In that case I'll find out which error do you have.
Maybe, myserver contains None so interpreter raises AttributeError.

if serv.address == 'HorizonSmpDNK.aternos.me:12584':

Also, I don't recommend comparing full address, because Aternos can change the port or, for example, move to other domain...
Use if serv.subdomain == 'HorizonSmpDNK': ...

ill try to do that! thanks!

what do "local variable 'myserver' referenced before assignment" means...

import discord
import python_aternos
from discord.ext import commands
from python_aternos import Client
token = ''
client = commands.Bot(command_prefix='$', help_command=None)
@client.event
async def on_ready():
print(f'Logged in as {client.user}')
@client.command()
async def start(ctx):
try:
aternos = Client.from_credentials("", "")
except Exception as e:
    await ctx.send("Couldnt log in")
    await ctx.send(f"Error {e}")

else:
    servs = aternos.list_servers()

    for serv in servs:
        if serv.address == 'HorizonSmpDNK.aternos.me:12584':
            myserver = serv

    try:
        myserver.start()
    except Exception as ex:
        print(ex)
    else:
        await ctx.send('await ctx.send("SERVER SUCESSFULLY OPENED!\nServer Address: HorizonSmpDNK.aternos.me:12584\nPort: 12584")')

client.run(token)

You try to start server before creating variable myserver.
If condition always False (there's no server with that name) or for loop never starts (list_servers returns empty []), myserver won't be declared!
myserver = None
for s in at.list_servers():
  if s.subdomain == ...:
    myserver = s
if s is not None:
  myserver.start()

In your case, error caused by empty servers list.
It's a bug (#48), wait for a new version.


Question about Fine-tuning

Hello, thank you for sharing the code of your great work.
I was wondering if it's possible to fine-tune the pretrained model on a new scene rather than running inference, similar to how it is done in SparseNeuS. In the paper, there was no mention of this so I just assumed that it is not possible but I might be wrong.
Also, I was trying to run the model on a scene from BlendedMVS, but I could not get any meaningful reconstruction as seen here:

when looking at the rendered depth maps, I get something, but the mesh generation does not give good result:

I tried tuning the value of self.offset_dist but still no success. Do you have an idea of what could be wrong here ?
Thanks

I encountered the same problem, any solutions?

I assume your question is answered, feel free to reopen it : )


cleanup: Update requirements throughout the project

What this PR does / why we need it:
Update the requirements throughout the project to be in sync and to reflect the current state of dependencies.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

None

/lgtm


Update docker-compose to build the repo

This pull request updates the docker-compose file to build the repository. It also updates the image and adds the chatflow API key and syncs with Sidekick on create/update.

Supersseded by https://github.com/Answers-AI/Flowise/pull/8


Updating octokit to use latest version 13

Updating octokit to use latest version 13
This is to try to address JSON conversion failure seeing in the production environment.
https://github.com/dotnet/dnceng/issues/3249

Ops Issue : https://github.com/dotnet/dnceng/issues/3249

Looks like there is a breaking change in the API that needs to be resolved.


encoding: DB is not supporting UTF-8

Describe the bug
DB is not supporting UTF-8
Problem Locations
Yes see below.
Steps to Reproduce
I added this markdown content in the description field of a vulnerability:
what an SQLi is

Emphasis, aka italics, with *asterisks* or _underscores_.

Strong emphasis, aka bold, with **asterisks** or __underscores__.

Combined emphasis with **asterisks and _underscores_**.

Strikethrough uses two tildes. ~~Scratch this.~~

1. First ordered list item
2. Another item
⋅⋅* Unordered sub-list.
1. Actual numbers don't matter, just that it's a number
⋅⋅1. Ordered sub-list
4. And another item.

⋅⋅⋅You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown).

⋅⋅⋅To have a line break without a paragraph, you will need to use two trailing spaces.⋅⋅
⋅⋅⋅Note that this line is separate, but within the same paragraph.⋅⋅
⋅⋅⋅(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)

* Unordered list can use asterisks
- Or minuses
+ Or pluses

[I'm an inline-style link](https://www.google.com)

[I'm an inline-style link with title](https://www.google.com "Google's Homepage")

[I'm a reference-style link][Arbitrary case-insensitive reference text]

[I'm a relative reference to a repository file](../blob/master/LICENSE)

[You can use numbers for reference-style link definitions][1]

Or leave it empty and use the [link text itself].

URLs and URLs in angle brackets will automatically get turned into links.
http://www.example.com or <http://www.example.com> and sometimes
example.com (but not on Github, for example).

Some text to show that the reference links can follow later.

[arbitrary case-insensitive reference text]: https://www.mozilla.org
[1]: http://slashdot.org
[link text itself]: http://www.reddit.com

Then submitted it.
Here is what happens with the DB:
bulwark       | query: START TRANSACTION
bulwark       | query: UPDATE `vulnerability` SET `description` = ? WHERE `id` IN (?) -- PARAMETERS: ["what an SQLi is\r\n\r\nEmphasis, aka italics, with *asterisks* or _underscores_.\r\n\r\nStrong emphasis, aka bold, with **asterisks** or __underscores__.\r\n\r\nCombined emphasis with **asterisks and _underscores_**.\r\n\r\nStrikethrough uses two tildes. ~~Scratch this.~~\r\n\r\n1. First ordered list item\r\n2. Another item\r\n⋅⋅* Unordered sub-list. \r\n1. Actual numbers don't matter, just that it's a number\r\n⋅⋅1. Ordered sub-list\r\n4. And another item.\r\n\r\n⋅⋅⋅You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown).\r\n\r\n⋅⋅⋅To have a line break without a paragraph, you will need to use two trailing spaces.⋅⋅\r\n⋅⋅⋅Note that this line is separate, but within the same paragraph.⋅⋅\r\n⋅⋅⋅(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)\r\n\r\n* Unordered list can use asterisks\r\n- Or minuses\r\n+ Or pluses\r\n\r\n[I'm an inline-style link](https://www.google.com)\r\n\r\n[I'm an inline-style link with title](https://www.google.com \"Google's Homepage\")\r\n\r\n[I'm a reference-style link][Arbitrary case-insensitive reference text]\r\n\r\n[I'm a relative reference to a repository file](../blob/master/LICENSE)\r\n\r\n[You can use numbers for reference-style link definitions][1]\r\n\r\nOr leave it empty and use the [link text itself].\r\n\r\nURLs and URLs in angle brackets will automatically get turned into links. \r\nhttp://www.example.com or <http://www.example.com> and sometimes \r\nexample.com (but not on Github, for example).\r\n\r\nSome text to show that the reference links can follow later.\r\n\r\n[arbitrary case-insensitive reference text]: https://www.mozilla.org\r\n[1]: http://slashdot.org\r\n[link text itself]: http://www.reddit.com",1]
bulwark       | query failed: UPDATE `vulnerability` SET `description` = ? WHERE `id` IN (?) -- PARAMETERS: ["what an SQLi is\r\n\r\nEmphasis, aka italics, with *asterisks* or _underscores_.\r\n\r\nStrong emphasis, aka bold, with **asterisks** or __underscores__.\r\n\r\nCombined emphasis with **asterisks and _underscores_**.\r\n\r\nStrikethrough uses two tildes. ~~Scratch this.~~\r\n\r\n1. First ordered list item\r\n2. Another item\r\n⋅⋅* Unordered sub-list. \r\n1. Actual numbers don't matter, just that it's a number\r\n⋅⋅1. Ordered sub-list\r\n4. And another item.\r\n\r\n⋅⋅⋅You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown).\r\n\r\n⋅⋅⋅To have a line break without a paragraph, you will need to use two trailing spaces.⋅⋅\r\n⋅⋅⋅Note that this line is separate, but within the same paragraph.⋅⋅\r\n⋅⋅⋅(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)\r\n\r\n* Unordered list can use asterisks\r\n- Or minuses\r\n+ Or pluses\r\n\r\n[I'm an inline-style link](https://www.google.com)\r\n\r\n[I'm an inline-style link with title](https://www.google.com \"Google's Homepage\")\r\n\r\n[I'm a reference-style link][Arbitrary case-insensitive reference text]\r\n\r\n[I'm a relative reference to a repository file](../blob/master/LICENSE)\r\n\r\n[You can use numbers for reference-style link definitions][1]\r\n\r\nOr leave it empty and use the [link text itself].\r\n\r\nURLs and URLs in angle brackets will automatically get turned into links. \r\nhttp://www.example.com or <http://www.example.com> and sometimes \r\nexample.com (but not on Github, for example).\r\n\r\nSome text to show that the reference links can follow later.\r\n\r\n[arbitrary case-insensitive reference text]: https://www.mozilla.org\r\n[1]: http://slashdot.org\r\n[link text itself]: http://www.reddit.com",1]
bulwark       | error: Error: ER_TRUNCATED_WRONG_VALUE_FOR_FIELD: Incorrect string value: '\xE2\x8B\x85\xE2\x8B\x85...' for column 'description' at row 1
bulwark       |     at Query.Sequence._packetToError (/bulwark/node_modules/mysql/lib/protocol/sequences/Sequence.js:47:14)
bulwark       |     at Query.ErrorPacket (/bulwark/node_modules/mysql/lib/protocol/sequences/Query.js:79:18)
bulwark       |     at Protocol._parsePacket (/bulwark/node_modules/mysql/lib/protocol/Protocol.js:291:23)
bulwark       |     at Parser._parsePacket (/bulwark/node_modules/mysql/lib/protocol/Parser.js:433:10)
bulwark       |     at Parser.write (/bulwark/node_modules/mysql/lib/protocol/Parser.js:43:10)
bulwark       |     at Protocol.write (/bulwark/node_modules/mysql/lib/protocol/Protocol.js:38:16)
bulwark       |     at Socket.<anonymous> (/bulwark/node_modules/mysql/lib/Connection.js:88:28)
bulwark       |     at Socket.<anonymous> (/bulwark/node_modules/mysql/lib/Connection.js:526:10)
bulwark       |     at Socket.emit (events.js:314:20)
bulwark       |     at addChunk (_stream_readable.js:303:12)
bulwark       |     at readableAddChunk (_stream_readable.js:279:9)
bulwark       |     at Socket.Readable.push (_stream_readable.js:218:10)
bulwark       |     at TCP.onStreamRead (internal/stream_base_commons.js:188:23)
bulwark       |     --------------------
bulwark       |     at Protocol._enqueue (/bulwark/node_modules/mysql/lib/protocol/Protocol.js:144:48)
bulwark       |     at PoolConnection.query (/bulwark/node_modules/mysql/lib/Connection.js:198:25)
bulwark       |     at MysqlQueryRunner.<anonymous> (/bulwark/node_modules/typeorm/driver/mysql/MysqlQueryRunner.js:208:44)
bulwark       |     at step (/bulwark/node_modules/typeorm/node_modules/tslib/tslib.js:143:27)
bulwark       |     at Object.next (/bulwark/node_modules/typeorm/node_modules/tslib/tslib.js:124:57)
bulwark       |     at fulfilled (/bulwark/node_modules/typeorm/node_modules/tslib/tslib.js:114:62)
bulwark       |     at processTicksAndRejections (internal/process/task_queues.js:93:5) {
bulwark       |   code: 'ER_TRUNCATED_WRONG_VALUE_FOR_FIELD',
bulwark       |   errno: 1366,
bulwark       |   sqlMessage: "Incorrect string value: '\\xE2\\x8B\\x85\\xE2\\x8B\\x85...' for column 'description' at row 1",
bulwark       |   sqlState: 'HY000',
bulwark       |   index: 0,
bulwark       |   sql: 'UPDATE `vulnerability` SET `description` = \'what an SQLi is\\r\\n\\r\\nEmphasis, aka italics, with *asterisks* or _underscores_.\\r\\n\\r\\nStrong emphasis, aka bold, with **asterisks** or __underscores__.\\r\\n\\r\\nCombined emphasis with **asterisks and _underscores_**.\\r\\n\\r\\nStrikethrough uses two tildes. ~~Scratch this.~~\\r\\n\\r\\n1. First ordered list item\\r\\n2. Another item\\r\\n⋅⋅* Unordered sub-list. \\r\\n1. Actual numbers don\\\'t matter, just that it\\\'s a number\\r\\n⋅⋅1. Ordered sub-list\\r\\n4. And another item.\\r\\n\\r\\n⋅⋅⋅You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we\\\'ll use three here to also align the raw Markdown).\\r\\n\\r\\n⋅⋅⋅To have a line break without a paragraph, you will need to use two trailing spaces.⋅⋅\\r\\n⋅⋅⋅Note that this line is separate, but within the same paragraph.⋅⋅\\r\\n⋅⋅⋅(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)\\r\\n\\r\\n* Unordered list can use asterisks\\r\\n- Or minuses\\r\\n+ Or pluses\\r\\n\\r\\n[I\\\'m an inline-style link](https://www.google.com)\\r\\n\\r\\n[I\\\'m an inline-style link with title](https://www.google.com \\"Google\\\'s Homepage\\")\\r\\n\\r\\n[I\\\'m a reference-style link][Arbitrary case-insensitive reference text]\\r\\n\\r\\n[I\\\'m a relative reference to a repository file](../blob/master/LICENSE)\\r\\n\\r\\n[You can use numbers for reference-style link definitions][1]\\r\\n\\r\\nOr leave it empty and use the [link text itself].\\r\\n\\r\\nURLs and URLs in angle brackets will automatically get turned into links. \\r\\nhttp://www.example.com or <http://www.example.com> and sometimes \\r\\nexample.com (but not on Github, for example).\\r\\n\\r\\nSome text to show that the reference links can follow later.\\r\\n\\r\\n[arbitrary case-insensitive reference text]: https://www.mozilla.org\\r\\n[1]: http://slashdot.org\\r\\n[link text itself]: http://www.reddit.com\' WHERE `id` IN (1)'
bulwark       | }
bulwark       | query: ROLLBACK
bulwark       | (node:240) UnhandledPromiseRejectionWarning: QueryFailedError: ER_TRUNCATED_WRONG_VALUE_FOR_FIELD: Incorrect string value: '\xE2\x8B\x85\xE2\x8B\x85...' for column 'description' at row 1
bulwark       |     at new QueryFailedError (/bulwark/node_modules/typeorm/error/QueryFailedError.js:12:28)
bulwark       |     at Query.<anonymous> (/bulwark/node_modules/typeorm/driver/mysql/MysqlQueryRunner.js:217:45)
bulwark       |     at Query.<anonymous> (/bulwark/node_modules/mysql/lib/Connection.js:526:10)
bulwark       |     at Query._callback (/bulwark/node_modules/mysql/lib/Connection.js:488:16)
bulwark       |     at Query.Sequence.end (/bulwark/node_modules/mysql/lib/protocol/sequences/Sequence.js:83:24)
bulwark       |     at Query.ErrorPacket (/bulwark/node_modules/mysql/lib/protocol/sequences/Query.js:92:8)
bulwark       |     at Protocol._parsePacket (/bulwark/node_modules/mysql/lib/protocol/Protocol.js:291:23)
bulwark       |     at Parser._parsePacket (/bulwark/node_modules/mysql/lib/protocol/Parser.js:433:10)
bulwark       |     at Parser.write (/bulwark/node_modules/mysql/lib/protocol/Parser.js:43:10)
bulwark       |     at Protocol.write (/bulwark/node_modules/mysql/lib/protocol/Protocol.js:38:16)
bulwark       |     at Socket.<anonymous> (/bulwark/node_modules/mysql/lib/Connection.js:88:28)
bulwark       |     at Socket.<anonymous> (/bulwark/node_modules/mysql/lib/Connection.js:526:10)
bulwark       |     at Socket.emit (events.js:314:20)
bulwark       |     at addChunk (_stream_readable.js:303:12)
bulwark       |     at readableAddChunk (_stream_readable.js:279:9)
bulwark       |     at Socket.Readable.push (_stream_readable.js:218:10)
bulwark       |     at TCP.onStreamRead (internal/stream_base_commons.js:188:23)
bulwark       | (node:240) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)

It seems to be due to non-ASCII symbols like ⋅⋅⋅, meaning the DB does not support UTF-8 strings actually.
Expected behavior
Accepting UTF-8 symbols
Screenshots
N/A
version
Bulwark v7.0.11

This also means that actually bulwark supports only US english since greek, cyrilic, chineese symbols, french accents, etc  are rejected because there-out of the US-ASCII scope.

Thanks for the ticket, @noraj.  Looks like this can be configured using the charset property within MysqlConnectionOptions.
https://typeorm.delightful.studio/interfaces/_driver_mysql_mysqlconnectionoptions_.mysqlconnectionoptions.html#charset

I ran your POC locally on the main branch and was able to successfully save a vulnerability.  It looks like you're running it via Docker so I will try that next.
Server Logs of transaction:
query: START TRANSACTION
query: UPDATE `vulnerability` SET `description` = ? WHERE `id` IN (?) -- PARAMETERS: ["what an SQLi is\r\n\r\nEmphasis, aka italics, with *asterisks* or _underscores_.\r\n\r\nStrong emphasis, aka
bold, with **asterisks** or __underscores__.\r\n\r\nCombined emphasis with **asterisks and _underscores_**.\r\n\r\nStrikethrough uses two tildes. ~~Scratch this.~~\r\n\r\n1. First ordered list item\r\n2. Another item\r\n⋅⋅* Unordered sub-list. \r\n1. Actual numbers don't matter, just that it's a number\r\n⋅⋅1. Ordered sub-list\r\n4. And another item.\r\n\r\n⋅⋅⋅You can have properly indented paragraphs within list items. Notice the blank line above, and the leading spaces (at least one, but we'll use three here to also align the raw Markdown).\r\n\r\n⋅⋅⋅To have a line break without
a paragraph, you will need to use two trailing spaces.⋅⋅\r\n⋅⋅⋅Note that this line is separate, but within the same paragraph.⋅⋅\r\n⋅⋅⋅(This is contrary to the typical GFM line break behaviour, where trailing spaces are not required.)\r\n\r\n* Unordered list can use asterisks\r\n- Or minuses\r\n+ Or pluses\r\n\r\n[I'm an inline-style link](https://www.google.com)\r\n\r\n[I'm an inline-style link with title](https://www.google.com \"Google's Homepage\")\r\n\r\n[I'm a reference-style link][Arbitrary case-insensitive reference text]\r\n\r\n[I'm a relative reference to a repository file](../blob/master/LICENSE)\r\n\r\n[You can use numbers for reference-style link definitions][1]\r\n\r\nOr leave it empty and use the [link text itself].\r\n\r\nURLs and URLs in angle brackets will automatically get turned into links. \r\nhttp://www.example.com or <http://www.example.com> and sometimes \r\nexample.com (but not on Github, for example).\r\n\r\nSome text to show that the reference links can follow later.\r\n\r\n[arbitrary case-insensitive reference text]: https://www.mozilla.org\r\n[1]: http://slashdot.org\r\n[link text itself]: http://www.reddit.com",5]
query: COMMIT

Rendered markdown:

As I mentioned, I will try with docker next.

I ran your POC locally on the main branch and was able to successfully save a vulnerability. It looks like you're running it via Docker so I will try that next.

Yes via Docker.
Maybe try other UTF-8 chars > 0xff https://www.fileformat.info/info/charset/UTF-8/list.htm
eg. Œ, ©, Ø, Ŕ, ϖ, etc.


feat(ci): run sqlsmith for all workflows

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Run sqlsmith for all PRs.

[ ] Is runtime reasonable relative to what it is now?

frontend: 12m 23s with vs 7m without
[ ] Decrease frontend load
e2e: 7m 31s with vs 5m without
[ ] Slightly decrease e2e load, so just +2m.

[ ] Remove all extra script files previously used to configure sqlsmith.

Checklist
- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests
- [ ] All checks passed in ./risedev check (or alias, ./risedev c)
Refer to a related PR or issue link (optional)
Closes #4803

Would it help to use a separate workflow to run sqlsmith, so that they can run in parallel with normal tests? thinking

Maybe that will be better, will try that out too.


Indicators doesn't show

I've started spaceman, but the indicators in the bar doesn't show for some reason. I can see that the app is running in activity monitor. Since I can't see it there is no way for me to access the preferences.
How can I debug it?
Running an M2 MacBook Pro with Ventura if that is any help.

I suspect that it is something wrong with the settings since I tried the spaceid app first and I had the same issue. I guess you share some settings/config from the whichspace project, where is that settings stored? Can I edit it manually or restore to the initial settings?

Since the M2 MacBook Pro has a notch, it may be that you have a lot of menu bar icons in the bar and also have a lot of spaces resulting in it being hidden. You could check to see by closing the other apps.

@Jaysce, I don't think that is the problem. Tried to close some apps, but the spaceman bar icon still doesn't show. It is room for at least 6-7 icons between my notch and the remaining apps, so I don't think that is the problem.
Is there a way I can change settings with having access to the bar icon?

You could try the following:

Quit Spaceman
Run defaults delete dev.jaysce.Spaceman  in terminal
Run Spaceman

This should reset the settings to its default values. Let me know if this helps.


Update manual payment form to manual transaction form.

This should (at the very least) let people choose a transaction type (payment vs. refund) and then validate the amount based on that (payments should be positive, refunds should be negative.)

... or we should just remove this form altogether.


Add Double Black sponsorship tier

Adjust our sponsorship tiers on the website to match what we offer to our sponsors.
Currently we have Green, Blue, Black. We want to add Double Black.
The Double Black tier should have it's own section in the Footer like the rest, and be at the top.

Acceptance Criteria

The double black sponsors are pulled from our CMS
Spacing is the same as other lines of sponsors
Clicking the logo links to the company's website (pulled from our CMS)

Look for the sponsors & tier types here when you have your dev server running (at localhost:8000/___graphql)

Completed in #37


Fix sts server plugin creation

In response to a cherrypick label: #20834 failed to apply on top of branch "release-1.5":
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	security/pkg/stsservice/tokenmanager/tokenmanager.go
Falling back to patching base and 3-way merge...
Auto-merging security/pkg/stsservice/tokenmanager/tokenmanager.go
CONFLICT (content): Merge conflict in security/pkg/stsservice/tokenmanager/tokenmanager.go
Patch failed at 0001 fix sts server

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
77a08a5c51b312cb3ac2bcf86b7e8dcbb368c2aa
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Merge Debian package building + service architecture.

Sorry, clicked too fast on the PR creation and opened it on the wrong repository! Thank you for the great example though, has helped us a lot. :)


chore: Remove dual boot documentation in MOTD

I plan to merge the dual boot documentation with the installation guide and re-arrange some of it especially since handheld usage is becoming increasingly popular.

Dual boot guide is gone. It's now included in the installation guide.


rely on external supervisor for puma

/domain @jmileham
since we've got a Procfile now and we're endorsing foreman-backed deployment processes that include their own process supervisor, we don't need nor want to daemonize our puma process nor track its PID.

<< domain lgtm


Feature: Adds IBC compliance & Cookie Set attribute inside CookieDetails Card

Description

This pull request introduces the IBC (Incrementally Better Cookies) compliance attribute inside the CookieDetails Card component that displays the SameSite attribute of cookies and verifies if their values align with the IBC draft proposal.
The implementation ensures that cookies adhere to the recommended SameSite attribute values, such as "Lax" by default and "None" with the "Secure" flag for cross-site delivery. It provides a clear overview of the compliance status, helping developers verify if their cookies meet the IBC standards.
Relevant Technical Choices

Introduces a key-value pair-based UI inside the CookieDetails Card.

Adds two new keys: "IBC Compliant" and "Cookie Set" to represent specific attributes.
Enables a long hover over each key to display a summary of their use cases, providing contextual information.

Updates Cookie Headers Parsing Mechanism:

Enhances the cookie headers parsing mechanism to streamline the values of a cookie.
Takes into account the cookie's header parsed entries, Chrome cookie-store cookie, and previously parsed cookie.
Improves the accuracy and consistency of parsed cookie values, ensuring reliable data extraction.

Testing Instructions

Open a website (say https://indianexpress.com/), now open the Privacy analysis panel in devtools.
Click on the tab Cookies, and click on any cookie.
In the CookieDetails card, you can see IBC Compliant and Cookie Set will be visible with relevant values.

Additional Information:

Screenshot/Screencast

https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/58820001/b5c3f693-ab00-45bf-a4b3-9802eb3dc28f

Fixes #35

@mayan-000 there seem to a small lint warning
/Users/sayedtaqui/projects/ps-analysis-tool/packages/extension/src/utils/getCookie.ts
  21:1  warning  The type 'chrome' is undefined  jsdoc/no-undefined-types

@mayan-000 The colors have changed, they weren't green.

@mayan-000 I tested this on https://samesite-sandbox.glitch.me/ and it seems to work as expected. Is there any website or demo example where one of the cookie compliance is "No" for testing.

@mayan-000 I tested this on https://samesite-sandbox.glitch.me/ and it seems to work as expected. Is there any website or demo example where one of the cookie compliance is "No" for testing.
Also please add a little more detail for "Cookie Set" abbr as its not very clear why the cookie was not set.

@sayedtaqui
There is a cookie on edition.cnn.com

Open the website and scroll a little.
Open the Extension panel and look out for test_cookie, it shows compliance and set-cookie both as "No".

Okay I see another one on https://edition.cnn.com/ 👍


Genre cards added

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #1808
Description
I have added the genre cards as mentioned in #1808

Type of PR

[ ] Bug fix
[x ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
before-

after-

Checklist:

[ x] I have made this change from my own.
[ x] I have taken help from some online resources.
[x ] My code follows the style guidelines of this project.
[x ] I have performed a self-review of my own code.
[x ] I have commented my code, particularly in hard-to-understand areas.
[x ] I have made corresponding changes to the documentation.
[x ] My changes generate no new warnings.
[ x] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers and screenshots after making the changes.

Hi @RishabhDhawad. Its been a few days since u merged my PR. Was something wrong with it? because it has not been added on my gssoc leaderboard till now.

@shruti110503 Done!


Validate on blur, if error once, then validate on input?

This is probably a feature request.
As an end user, it's really distracting to be told my email address is invalid when I haven't finished typing it yet. I want to get that feedback on blur. But if I get an error message, and I go back and fix the mistake, I want to get the visual confirmation that the error is fixed before I leave the input, in case further tweaking is necessary. This is a very common validation pattern, founded on solid research and common sense etc. It should probably be the default for form validation libraries.
I don't see an easy way to configure this here. Can you provide an example of this in action? Or maybe a magic third option in events.config.

There are actually several flags in VeeValide to help enhance user experience.
For example, the situation you mentioned can be achieved with the following snippet https://goo.gl/k19umZ

@Abdelrahman3D Thank you!


Remove support for empty NI name per gRIBI spec.

  * (M) compliance/compliance.go
    - Update tests that do not explicitly specify a network instance
      name for the default network instance name to include one.
  * (M) server/server.go
  * (M) server/server_test.go
    - Update reference server implementation to remove the handling
      of an empty network instance name.

See https://github.com/openconfig/gribi/pull/34 for details of this change.

Thanks! Somehow I missed the latter one. Let me fix that!
On the first one, that is just creating the default RIB on the server (rather than the expectation in the API) since we do not ingest a configuration on the reference server to tell us what the name should be.

Thanks - removed the rewrite in modifyEntry. PTAL.


Retrieving OVER_QUERY_LIMIT status from a model?

Is there some way to know (outside of the log) if you're getting an 'OVER_QUERY_LIMIT' from Google with an acts_as_gmappable model?  I see the status is recorded in the log for the model, but the exception itself is not used to store the error message.
Thanks for the gem

@apneadiving and @mattholtom based on the conversation thread at https://github.com/TGRHavoc/live_map-interface/issues/17 about Google restricting use that is missing an API key, does that mean we cannot use v1.X of gmaps4rails, because we'll be over the quota limit?  Or is there a way to add an API key to v1.X?
I'm seeing this bug in production:

Any help is greatly appreciated!


Cb/simulation results

@claytonpbarrows the PR is passing tests now. The biggest missing item is that we don't have the interfaces to read expressions and auxiliary_variables. I think that if @daniel-thom approves the PR we should merge and address the missing results gathering in a forthcoming PR


fancycode/MemoryModule

Steps to reproduce:
. . .

DllExport:  1.7.4
Used Visual Studio / MSBuild:  vs2022

Im write simple DLL with that code:
using System.Runtime.InteropServices;

namespace SampleSharpDLL
{
    public class Class1
    {
        [DllExport]

        static int TestInt()
        {
            return 11134;
        }
    }
}

and tried call LoadFromMemory from this repo https://github.com/fancycode/MemoryModule
and got this:

But when I try to load the library directly via LoadLibrary everything works. In this regard, I have a question - why is 4096 missing, is this error related to the module that I'm trying or probably I made a mistake when setting some parameters ( DllExport.bat )
Tell me, have I come to the right place or should I redirect this question to the developers of fancycode module :D

Hello,
The question is more related to the question about assembler
implementation how does it work, and as I remember, PE writer evaluates
SizeOfImage using VA/RVA from the last placed section such .reloc plus
its size rounded up to a multiple of the section alignment. Some of the
alignment, in its turn, may also relies on page size including the
mentioned difference 0x1000 up to the two page size etc, or it was
decoder part, never mind.
In other words, I don't recommend to compare both between (like in your
code above) due to various cases.
The SizeOfImage should be enough to allocate memory for image because
its value must contain evaluated size of the image including all headers
(CLR header is inside the well-known .text section, and so on)
On 14.02.2023 23:49, Mortan wrote:

and tried call LoadFromMemory from this repo
https://github.com/fancycode/MemoryModule
and got this:
image
https://user-images.githubusercontent.com/18101486/218858824-3dbdac66-6a14-4a51-8044-443c2e7db82d.png
But when I try to load the library directly via LoadLibrary everything
works. In this regard, I have a question - why is 4096 missing, is
this error related to the module that I'm trying or probably I made a
mistake when setting some parameters ( DllExport.bat )
Tell me, have I come to the right place or should I redirect this
question to the developers of fancycode module :D

I don't see a problem for correct implementation.
You need to contact fancycode/MemoryModule in order to upgrade their MemoryModule using the information from my comment above and so on. I'm closing the issue but feel free to continue if needed.


Gradle release v2.7.0

I saw https://github.com/GoogleContainerTools/jib/releases/tag/v2.7.0-maven appear in my feed and jib-maven-plugin 2.7.0 is indeed on Maven Central: https://search.maven.org/artifact/com.google.cloud.tools/jib-maven-plugin/2.7.0/maven-plugin
The v2.7.0-maven tag on https://github.com/GoogleContainerTools/jib/releases doesn't contain any changelog information, and https://github.com/GoogleContainerTools/jib/blob/v2.7.0-maven/jib-maven-plugin/CHANGELOG.md has the changes still under a '[unreleased]' header. Are those the changes in 2.7.0?


Masthead: there is motion latency on dropdown rollover

When hovering/rolling over the dropdown menu in both L0 and L1 there is a slight delay in state change from top to bottom. It's taking too long for the hover state to deactivate when the mouse rolls over another menu item. It's as if it's sticking.
I don't know if it's a bug or styling issue? Either way, it should behave more like Carbon's UI header.
Screen recordings in here for test:
masthead-dropdown-rollover.zip
This is related to issue #112

REF: https://ibmdotcom-react.netlify.com/?path=/story/masthead--default-with-l1

@larahanlon2 These transition values come directly from the Carbon components. We haven't modified those.
background-color 110ms, border-color 110ms, color 110ms;

http://react.carbondesignsystem.com/?path=/story/ui-shell--header-base-w-navigation-and-actions


People counter project , fixes #294

This project fixes #294 . This counts the number of humans in the frame. I have used HOG ,Histogram of oriented gradients for this task. The accuracy of detecting humans using this is quite good. This project works on Video and tells number of humans in the frame, we can work on images as well using HOG . Python Libraries used are OpenCV and Imutils.

.

@kashish0505kashyap add readme.md file and try to code in notebook (jupyter,google colab, kaggle)  , just install open cv in your notebook...

@kashish0505kashyap add readme.md file and try to code in notebook (jupyter,google colab, kaggle) , just install open cv in your notebook...

Okay


"Open File..." uses gnome-open instead of kde-open in KDE

When I press File > Open File... or File > Open Folder... Atom launches gnome-open instead of kde-open in Kubuntu 14.04. Can this be configured by the user or changed by the developers?

This is handled by Electron - please open an issue on electron/electron instead.  Thanks!


Increase watcher termination reaction timeout to avoid flaky test

The test failure was observed several times on Windows runners, which is slower than Linux runners.
100ms is perhaps too short for the unresponsive watcher to be killed.
W0313 08:27:30.789254    3936 env.go:126] Failed to get Pod Namespace from environment. Using "kube-system" as the Antrea Service Namespace
--- FAIL: TestRamStoreWatchTimeout (0.75s)
    store_test.go:526: w2 was not stopped, expected stopped
    store_test.go:528:
        	Error Trace:	D:/a/antrea/antrea/pkg/apiserver/storage/ram/store_test.go:528
        	Error:      	Not equal:
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestRamStoreWatchTimeout
        	Messages:   	Unexpected watchers number
W0313 08:27:31.564994    3936 store.go:350] Forcing stopping watcher (selectors: &{ app=nginx }) due to unresponsiveness

/skip-all


test: Implement chunked snarkjs fork and monitor memory performances

The chunked snarkjs fork might have an impact on the memory usage during the proving process.
The goal is to test if using this fork gives us a significant improvement in memory usage.

After exploration, this is not required as performances will not be improved by a lot.
But this could lead to a front-end project in the future, to build an enhanced version of snarkjs.


Librespot locks up after a some time

I've seen librespot lock up after some time, disappearing from the discovered devices list (no longer responding to mdns requests). I'm not sure if it actually interrupted playing or just hung up while nothing was playing.
This was observed with a self-compiled git master version (https://github.com/librespot-org/librespot/commit/4e3576ba7c6146cf68e1953daeec929d619b26b1)
This seems to be similar to #247 and #215, though I'm not so sure this is really the same bug. I don't have any meaningful backtrace in the logfile, for example. Also I have quite some details, so it is probably better to have a separate issue unless we can confirm that they are indeed the same.
In the log file, I see:
INFO:librespot_playback::player: Track "Money" loaded
ERROR:librespot_core::session: Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }

It seems librespot has stopped reading from the mdns socket:
pi@Kitchen:~ $ sudo netstat -lnp4|grep librespot
tcp        2      0 <IP_ADDRESS>:40719           <IP_ADDRESS>:*               LISTEN      918/librespot
udp   135616      0 <IP_ADDRESS>:5353            <IP_ADDRESS>:*                           918/librespot

strace shows that no syscalls are happening:
strace: Process 918 attached
futex(0x757ff318, FUTEX_WAIT, 7632, NULLstrace: Process 918 detached
 <detached ...>

gdb also suggests that all threads are locked up:
(gdb) thread apply all bt
Thread 1 (Thread 0x76f92340 (LWP 918)):
#0  0x76cdc464 in pthread_join (threadid=<optimized out>, thread_return=0x0) at pthread_join.c:90
#1  0x009b0b70 in std::sys::unix::thread::Thread::join::h07edb28013cf027c () at libstd/sys/unix/thread.rs:176
#2  0x00564984 in _$LT$std..thread..JoinHandle$LT$T$GT$$GT$::join::hf42ff97141008219 ()
#3  0x0055a260 in _$LT$librespot_playback..player..Player$u20$as$u20$core..ops..drop..Drop$GT$::drop::hac48e437737a6f07 ()
#4  0x004e46b0 in core::ptr::drop_in_place::h7e33a9ed9b5ca32a ()
#5  0x004e4c7c in core::ptr::drop_in_place::hb62ed06addeb6e0b ()
#6  0x008cdd24 in tokio::executor::current_thread::scheduler::release_node::h436b9d48d651653a ()
#7  0x008d0e64 in _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::ha280e7894e4db392 ()
#8  0x008ce278 in _$LT$tokio..executor..current_thread..scheduler..Scheduler$LT$U$GT$$GT$::tick::hd8a23f66e53862f4 ()
#9  0x008c4b6c in _$LT$scoped_tls..ScopedKey$LT$T$GT$$GT$::set::hc32e64633834effa ()
#10 0x008d1604 in _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::hf2008c182fa53f44 ()
#11 0x008d0cd0 in _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::h613425a247458594 ()
#12 0x008d10b0 in _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::hb0b1f89fcde726c3 ()
#13 0x008ccc0c in tokio_core::reactor::Core::poll::h854a3e1b89a82b9b ()
#14 0x004e23b8 in tokio_core::reactor::Core::run::ha4d6f8476bb012d1 ()
#15 0x004dc580 in librespot::main::h95a6d9f6a736a6db ()
#16 0x00b8b940 in ?? ()

Backtrace stopped: previous frame identical to this frame (corrupt stack?)
Thread 2 (Thread 0x767ff2b0 (LWP 926)):
#0  0x76de2704 in epoll_wait () at ../sysdeps/unix/syscall-template.S:84
#1  0x0090a320 in mio::sys::unix::epoll::Selector::select::h060b379467f466c7 ()
#2  0x00908650 in mio::poll::Poll::poll1::hfaa8e74388b143cd ()
#3  0x00907f98 in mio::poll::Poll::poll::h659ee91e412450f3 ()
#4  0x008fbb60 in tokio_reactor::Reactor::turn::h83e3d5bb7567c2fc ()
#5  0x009043c0 in tokio_reactor::background::run::h28e75bf0a40d4e9c ()
#6  0x008ff4a0 in std::sys_common::backtrace::__rust_begin_short_backtrace::hbf7db8b2dd117737 ()
#7  0x00905e60 in std::panicking::try::do_call::h8dfef3beef5bc05f ()
#8  0x009baaac in __rust_maybe_catch_panic () at libpanic_unwind/lib.rs:105
#9  0x00901988 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::ha24a3621df7222f9 ()
#10 0x009adeac in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hb9e8d47ffc984c2e () at /checkout/src/liballoc/boxed.rs:648
#11 std::sys_common::thread::start_thread::hf9e3e04939d5f0be () at libstd/sys_common/thread.rs:24
#12 0x009b0b28 in std::sys::unix::thread::Thread::new::thread_start::hb5f20e9ac9231edc () at libstd/sys/unix/thread.rs:90
#13 0x76cdafc4 in start_thread (arg=0x767ff2b0) at pthread_create.c:458
#14 0x76de2038 in ?? () at ../sysdeps/unix/sysv/linux/arm/clone.S:76 from /lib/arm-linux-gnueabihf/libc.so.6
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Thread 3 (Thread 0x761ff2b0 (LWP 6252)):
#0  0x76ce19a4 in __pthread_cond_wait (cond=0x7681e390, mutex=0x7681b798) at pthread_cond_wait.c:188
#1  0x009a75c4 in std::sys::unix::condvar::Condvar::wait::hab93781440f55022 () at libstd/sys/unix/condvar.rs:78
#2  std::sys_common::condvar::Condvar::wait::hda28562b419be3ea () at libstd/sys_common/condvar.rs:51
#3  std::sync::condvar::Condvar::wait::ha0917b1f460848fe () at libstd/sync/condvar.rs:214
#4  std::thread::park::h93884c2ad9e85a2d () at libstd/thread/mod.rs:803
#5  0x009b034c in std::sync::mpsc::blocking::WaitToken::wait::hb4820b1cfd0e3ab9 () at libstd/sync/mpsc/blocking.rs:81
#6  0x0056ac50 in _$LT$std..sync..mpsc..stream..Packet$LT$T$GT$$GT$::recv::h0d77bae4424c2898 ()
#7  0x0057fa70 in _$LT$std..sync..mpsc..Receiver$LT$T$GT$$GT$::recv::h8d3e9d021d799c3c ()
#8  0x0055a76c in librespot_playback::player::PlayerInternal::run::hedda082537cecf78 ()
#9  0x004fb12c in std::sys_common::backtrace::__rust_begin_short_backtrace::hb57c86e1fbda9cc9 ()
#10 0x004e9150 in std::panicking::try::do_call::hd65e9edeebabae0e ()
#11 0x009baaac in __rust_maybe_catch_panic () at libpanic_unwind/lib.rs:105
#12 0x004fd578 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::h3a3c2b783a091036 ()
#13 0x009adeac in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT
$A$GT$$GT$::call_once::hb9e8d47ffc984c2e () at /checkout/src/liballoc/boxed.rs:648
#14 std::sys_common::thread::start_thread::hf9e3e04939d5f0be () at libstd/sys_common/thread.rs:24
---Type <return> to continue, or q <return> to quit---
#15 0x009b0b28 in std::sys::unix::thread::Thread::new::thread_start::hb5f20e9ac9231edc () at libstd/sys/unix/thread.rs:90
#16 0x76cdafc4 in start_thread (arg=0x761ff2b0) at pthread_create.c:458
#17 0x76de2038 in ?? () at ../sysdeps/unix/sysv/linux/arm/clone.S:76 from /lib/arm-linux-gnueabihf/libc.so.6
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Thread 4 (Thread 0x757ff2b0 (LWP 7632)):
#0  0x76ce19a4 in __pthread_cond_wait (cond=0x7520f000, mutex=0x75215030) at pthread_cond_wait.c:188
#1  0x00920f4c in futures::task_impl::std::ThreadNotify::park::h7b4e63dd494d5597 ()
#2  0x0056c98c in _$LT$std..thread..local..LocalKey$LT$T$GT$$GT$::with::hf6072a215a39b3b8 ()
#3  0x00566570 in futures::future::Future::wait::h8064970af9245539 ()
#4  0x0055c678 in librespot_playback::player::PlayerInternal::run::hedda082537cecf78 ()
#5  0x004fb12c in std::sys_common::backtrace::__rust_begin_short_backtrace::hb57c86e1fbda9cc9 ()
#6  0x004e9150 in std::panicking::try::do_call::hd65e9edeebabae0e ()
#7  0x009baaac in __rust_maybe_catch_panic () at libpanic_unwind/lib.rs:105
#8  0x004fd578 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::h3a3c2b783a091036 ()
#9  0x009adeac in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT
$A$GT$$GT$::call_once::hb9e8d47ffc984c2e () at /checkout/src/liballoc/boxed.rs:648
#10 std::sys_common::thread::start_thread::hf9e3e04939d5f0be () at libstd/sys_common/thread.rs:24
#11 0x009b0b28 in std::sys::unix::thread::Thread::new::thread_start::hb5f20e9ac9231edc () at libstd/sys/unix/thread.rs:90
#12 0x76cdafc4 in start_thread (arg=0x757ff2b0) at pthread_create.c:458
#13 0x76de2038 in ?? () at ../sysdeps/unix/sysv/linux/arm/clone.S:76 from /lib/arm-linux-gnueabihf/libc.so.6
Backtrace stopped: previous frame identical to this frame (corrupt stack?)

Thread 5 (Thread 0x74dff2b0 (LWP 26956)):
#0  0x76ce19a4 in __pthread_cond_wait (cond=0x7681e5d0, mutex=0x76948ea0) at pthread_cond_wait.c:188
#1  0x009a75c4 in std::sys::unix::condvar::Condvar::wait::hab93781440f55022 () at libstd/sys/unix/condvar.rs:78
#2  std::sys_common::condvar::Condvar::wait::hda28562b419be3ea () at libstd/sys_common/condvar.rs:51
#3  std::sync::condvar::Condvar::wait::ha0917b1f460848fe () at libstd/sync/condvar.rs:214
---Type <return> to continue, or q <return> to quit---
#4  std::thread::park::h93884c2ad9e85a2d () at libstd/thread/mod.rs:803
#5  0x009b034c in std::sync::mpsc::blocking::WaitToken::wait::hb4820b1cfd0e3ab9 () at libstd/sync/mpsc/blocking.rs:81
#6  0x00919fec in _$LT$std..sync..mpsc..oneshot..Packet$LT$T$GT$$GT$::recv::h10911dd8ed02a40b ()
#7  0x00911e1c in _$LT$std..sync..mpsc..Receiver$LT$T$GT$$GT$::recv::h86a65277c2302820 ()
#8  0x0090f83c in futures_cpupool::Inner::work::hc3d513a7f0b1bfdb ()
#9  0x00910c88 in std::sys_common::backtrace::__rust_begin_short_backtrace::h41985cfd798e9ad4 ()
#10 0x009114e0 in std::panicking::try::do_call::h954acf9a59e0fa2f ()
#11 0x009baaac in __rust_maybe_catch_panic () at libpanic_unwind/lib.rs:105
#12 0x009112d0 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::h1a23aeeec05d132e ()
#13 0x009adeac in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT
$A$GT$$GT$::call_once::hb9e8d47ffc984c2e () at /checkout/src/liballoc/boxed.rs:648
#14 std::sys_common::thread::start_thread::hf9e3e04939d5f0be () at libstd/sys_common/thread.rs:24
#15 0x009b0b28 in std::sys::unix::thread::Thread::new::thread_start::hb5f20e9ac9231edc () at libstd/sys/unix/thread.rs:90
#16 0x76cdafc4 in start_thread (arg=0x74dff2b0) at pthread_create.c:458
Backtrace stopped: Cannot access memory at address 0x14

Thread 6 (Thread 0x75dfd2b0 (LWP 26957)):
#0  0x76ce4f40 in __lll_lock_wait (futex=futex@entry=0x76948e88, private=0) at lowlevellock.c:43
#1  0x76cddbd4 in __GI___pthread_mutex_lock (mutex=0x76948e88) at pthread_mutex_lock.c:80
#2  0x0090f814 in futures_cpupool::Inner::work::hc3d513a7f0b1bfdb ()
#3  0x00910c88 in std::sys_common::backtrace::__rust_begin_short_backtrace::h41985cfd798e9ad4 ()
#4  0x009114e0 in std::panicking::try::do_call::h954acf9a59e0fa2f ()
#5  0x009baaac in __rust_maybe_catch_panic () at libpanic_unwind/lib.rs:105
#6  0x009112d0 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::h1a23aeeec05d132e ()
#7  0x009adeac in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT
$A$GT$$GT$::call_once::hb9e8d47ffc984c2e () at /checkout/src/liballoc/boxed.rs:648
#8  std::sys_common::thread::start_thread::hf9e3e04939d5f0be () at libstd/sys_common/thread.rs:24
#9  0x009b0b28 in std::sys::unix::thread::Thread::new::thread_start::hb5f20e9ac9231edc () at libstd/sys/unix/thread.rs:90
#10 0x76cdafc4 in start_thread (arg=0x75dfd2b0) at pthread_create.c:458
Backtrace stopped: Cannot access memory at address 0x14

Thread 7 (Thread 0x75ffe2b0 (LWP 26958)):
#0  0x76ce4f40 in __lll_lock_wait (futex=futex@entry=0x76948e88, private=0) at lowlevellock.c:43
#1  0x76cddbd4 in __GI___pthread_mutex_lock (mutex=0x76948e88) at pthread_mutex_lock.c:80
#2  0x0090f814 in futures_cpupool::Inner::work::hc3d513a7f0b1bfdb ()
#3  0x00910c88 in std::sys_common::backtrace::__rust_begin_short_backtrace::h41985cfd798e9ad4 ()
#4  0x009114e0 in std::panicking::try::do_call::h954acf9a59e0fa2f ()
#5  0x009baaac in __rust_maybe_catch_panic () at libpanic_unwind/lib.rs:105
#6  0x009112d0 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::h1a23aeeec05d132e ()
#7  0x009adeac in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT
$A$GT$$GT$::call_once::hb9e8d47ffc984c2e () at /checkout/src/liballoc/boxed.rs:648
#8  std::sys_common::thread::start_thread::hf9e3e04939d5f0be () at libstd/sys_common/thread.rs:24
#9  0x009b0b28 in std::sys::unix::thread::Thread::new::thread_start::hb5f20e9ac9231edc () at libstd/sys/unix/thread.rs:90
#10 0x76cdafc4 in start_thread (arg=0x75ffe2b0) at pthread_create.c:458
Backtrace stopped: Cannot access memory at address 0x14

Thread 8 (Thread 0x747ff2b0 (LWP 26959)):
#0  0x76ce4f40 in __lll_lock_wait (futex=futex@entry=0x76948e88, private=0) at lowlevellock.c:43
#1  0x76cddbd4 in __GI___pthread_mutex_lock (mutex=0x76948e88) at pthread_mutex_lock.c:80
#2  0x0090f814 in futures_cpupool::Inner::work::hc3d513a7f0b1bfdb ()
#3  0x00910c88 in std::sys_common::backtrace::__rust_begin_short_backtrace::h41985cfd798e9ad4 ()
#4  0x009114e0 in std::panicking::try::do_call::h954acf9a59e0fa2f ()
#5  0x009baaac in __rust_maybe_catch_panic () at libpanic_unwind/lib.rs:105
#6  0x009112d0 in _$LT$F$u20$as$u20$alloc..boxed..FnBox$LT$A$GT$$GT$::call_box::h1a23aeeec05d132e ()
#7  0x009adeac in _$LT$alloc..boxed..Box$LT$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT
$A$GT$$GT$::call_once::hb9e8d47ffc984c2e () at /checkout/src/liballoc/boxed.rs:648
#8  std::sys_common::thread::start_thread::hf9e3e04939d5f0be () at libstd/sys_common/thread.rs:24
#9  0x009b0b28 in std::sys::unix::thread::Thread::new::thread_start::hb5f20e9ac9231edc () at libstd/sys/unix/thread.rs:90
#10 0x76cdafc4 in start_thread (arg=0x747ff2b0) at pthread_create.c:458
Backtrace stopped: Cannot access memory at address 0x14

(gdb) info threads
  Id   Target Id         Frame
* 1    Thread 0x76f92340 (LWP 918) "librespot" 0x76cdc464 in pthread_join (threadid=<optimized out>, thread_return=0x0) at pthread_join.c:90
  2    Thread 0x767ff2b0 (LWP 926) "librespot" 0x76de2704 in epoll_wait () at ../sysdeps/unix/syscall-template.S:84
  3    Thread 0x761ff2b0 (LWP 6252) "librespot" 0x76ce19a4 in __pthread_cond_wait (cond=0x7681e390, mutex=0x7681b798) at pthread_cond_wait.c:188
  4    Thread 0x757ff2b0 (LWP 7632) "librespot" 0x76ce19a4 in __pthread_cond_wait (cond=0x7520f000, mutex=0x75215030) at pthread_cond_wait.c:188
  5    Thread 0x74dff2b0 (LWP 26956) "hyper-dns0" 0x76ce19a4 in __pthread_cond_wait (cond=0x7681e5d0, mutex=0x76948ea0) at pthread_cond_wait.c:188
  6    Thread 0x75dfd2b0 (LWP 26957) "hyper-dns1" 0x76ce4f40 in __lll_lock_wait (futex=futex@entry=0x76948e88, private=0) at lowlevellock.c:43
  7    Thread 0x75ffe2b0 (LWP 26958) "hyper-dns2" 0x76ce4f40 in __lll_lock_wait (futex=futex@entry=0x76948e88, private=0) at lowlevellock.c:43
  8    Thread 0x747ff2b0 (LWP 26959) "hyper-dns3" 0x76ce4f40 in __lll_lock_wait (futex=futex@entry=0x76948e88, private=0) at lowlevellock.c:43

I made a core dump file. If it helps, I can share it (but I'm a bit hesitant, since I'm not sure if there's sensitive credentials in there).

I tried to dig into this a bit further, and it turns out the coredump might not be so useful after all. It seems that gdb does not know (or fails to read) the list of shared libraries loaded at runtime, which means it fails to load the debugging symbols of the libraries in use, and fails to render the backtrace. I also noticed that the "program entry point" (as printed by "info shared" IIRC) was different between a running process and a core dump, which might also be related. It also seems that rust has a fairly complicated multithreading model, so I haven't figured out any extra info from debugging a locked up process directly...

I am also experiencing this issue. After 1-3 songs (via Spotifyd 0.2.20) I get the error Connection reset by peer, so I enabled verbose logging (Full debug log can be found here )

11:55:22 [ERROR] Caught panic with message: Spotify servers returned an error. Restart librespot.

Going to try with a fresh compile. Will update with results.

I was having the ConnectionReset problem. What seems to have solved it making sure pulseaudio never quits. Instead of running it with systemd, what I did was
Disable pulseaudio.socket:
$ sudo systemctl --global disable pulseaudio.service pulseaudio.socket
On daemon.conf, disable exit on idle:
exit-idle-time = -1
In default.pa, comment
load-module module-systemd-login
With that I have librespot running on a raspberrypi for a day and no problems so far.

@espindola a bit of a dull question, but are you using alsa or pulseaudio as your backend?
I'm having the same problem with spotifyd but it's using alsa as a backend

@espindola a bit of a dull question, but are you using alsa or pulseaudio as your backend?
I'm having the same problem with spotifyd but it's using alsa as a backend

I am using pulseaudio

I am not quite sure whether this is the same issue but librespot stops to work after about 3 songs aswell, with the log:
[2020-06-17T13:13:09Z ERROR librespot_core::session] Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }
[2020-06-17T13:13:09Z WARN  librespot] Spirc shut down unexpectedly
[2020-06-17T13:13:09Z WARN  librespot_audio::fetch] Error from channel for data receiver for range 8216576 (+16384).

Hi, I am using Librespot through raspotify, experiencing recently many playback stops after a while (seems very random to me sometime after a couple of minutes, sometime after a longer time).
My logs look similar to those reported earlier :
Aug 21 10:11:09 pibureau librespot[27145]: [2020-08-21T08:11:09Z ERROR librespot_playback::player] Unable to load audio item. Aug 21 10:11:09 pibureau librespot[27145]: [2020-08-21T08:11:09Z ERROR librespot_core::session] Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" } Aug 21 10:11:09 pibureau librespot[27145]: [2020-08-21T08:11:09Z WARN  librespot] Spirc shut down unexpectedly Aug 21 10:11:10 pibureau librespot[27145]: [2020-08-21T08:11:10Z INFO  librespot_core::session] Connecting to AP "gew1-accesspoint-b-rx4r.ap.spotify.com:4070" Aug 21 10:11:10 pibureau librespot[27145]: [2020-08-21T08:11:10Z INFO  librespot_core::session] Authenticated as "XXXXXXXXX" ! Aug 21 10:11:10 pibureau librespot[27145]: [2020-08-21T08:11:10Z INFO  librespot_playback::audio_backend::alsa] Using alsa sink Aug 21 10:11:10 pibureau librespot[27145]: [2020-08-21T08:11:10Z INFO  librespot_core::session] Country: "FR"
any ideas on how to fix that? Is it something related to our configuration ?
thanks

Same here, it looks like #331.

same problem for me

Same issue on new Raspberry Pi 4. After 2 songs raspotify disconnects with errors:
Nov 25 23:36:34 raspberrypi librespot[22993]: [2020-11-25T22:36:34Z INFO  librespot_playback::player] Loading <Caution - Radio Edit> with Spotify URI <spotify:track:4cI2rd2D44mBjwUVFxTkUZ>
Nov 25 23:36:34 raspberrypi librespot[22993]: [2020-11-25T22:36:34Z INFO  librespot_playback::player] <Caution - Radio Edit> (228040 ms) loaded
Nov 25 23:39:14 raspberrypi librespot[22993]: [2020-11-25T22:39:14Z ERROR librespot_playback::player] Unable to load audio item.
Nov 25 23:39:14 raspberrypi librespot[22993]: [2020-11-25T22:39:14Z ERROR librespot_core::session] Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }
Nov 25 23:39:14 raspberrypi librespot[22993]: [2020-11-25T22:39:14Z WARN  librespot] Spirc shut down unexpectedly

Although I don't like running java on a headless raspberry pi, I want to state, that the librespot-java project works flawless and I'm not getting any disconnects there

@paulbastian, thank you for your suggestion!
For about one hour Spotify plays without disconnects. So Spocon based on librespot-java is quite good alternative for Raspotify.

The "Connection reset by peer" error is because the Spotify network connection broke, for reasons like a Spotify server was shut down, your Internet connection went offline briefly, or many other issues.  librespot should try to automatically reconnect in this case but it doesn't always seem to for some reason.

this is probably the reason we need to investigate :)
I guess all the Spotify clients face the same kind of issue and have found some workaround.
I am not able to help you for coding but I'll be more than happy to help you as much as I could

Is this still happening for you?
It's known that reconnection isn't handled well. This is likely to be fixed when we get the new API in, which supports reconnection from the ground up.
With the current librespot version however (assuming a stable network) I have no issues running librespot heedlessly for days and weeks at end, connecting and disconnecting in the evenings.

I haven't noticed this issue in a long time. Not sure what changed.

I still see it maybe once a week?  Often it will reconnect without any issues but occasionally it just crashes completely.  It is rare enough that it isn't causing me any problems but it is still happening.

Which version are you on?

I haven't upgraded in a while as it has been running without issue.  But I leave it connected 24/7 so that's probably why.  I guess if you disconnect and reconnect you probably won't see it if it's due to Spotify rebooting servers from time to time.

Please try the latest and report back. There's been a rather large upgrade and rewrite of the asynchronous functions. I also see in main that there will be up to five reconnection attempts when spirc shuts down unexpectedly.
It's probably a lot better than it was, and it's about as good as it's going to get until the new API gets in.

Duplicate of #276.

Sorry for the late reply.  Been running the updated code for the last two months and it does seem to be a lot more reliable.  It will automatically reconnect but it won't resume the previously playing track which somewhat defeats the point as I still have to go mess with it to get it playing again, but it's definitely a step in the right direction!


Adverse effects of slicex/sortx /dropx on significance test results

The effect of slicex/sortx/dropx, applied to y, on significance test results needs to be confirmed.

Resolved by #110


Creates sshdprocessor struct

Codecov Report

Merging #54 (5caf095) into main (8437dca) will increase coverage by 0.01%.
The diff coverage is 40.95%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   51.51%   51.53%   +0.01%
==========================================
  Files          27       27
  Lines        1883     1894      +11
==========================================
+ Hits          970      976       +6
- Misses        872      878       +6
+ Partials       41       40       -1

Flag
Coverage Δ

unittests
51.53% <40.95%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/app.go
0.00% <0.00%> (ø)

ingesters/journald/reader.go
0.00% <0.00%> (ø)

processors/varlogsecure/varlogsecure.go
0.00% <0.00%> (ø)

processors/sshd/sshdprocessor.go
68.23% <54.79%> (-4.83%)
:arrow_down:

processors/rocky/rockyprocessor.go
66.66% <75.00%> (ø)

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


x/tools/gopls: excessive invalidation of analysis results

In the course of CL 503195 I noticed that minor changes to source files (such as the insertion of a comment) cause re-typechecking (from syntax) of far more packages than one might expect based on the change. This appeared to be the case both before and after the change in that CL.
For example, if I enable this log line:
func (an *analysisNode) typeCheck(parsed []*source.ParsedGoFile) *analysisPackage {
	if true { // debugging
		log.Println("typeCheck", m.ID)
	}

and run go run ./gopls check ./gopls/main.go, I observe:

first run: typechecks everything.
second run: typechecks nothing.
edit gopls/internal/lsp/cmd/cmd.go: add a comment after the import block. run again:  type checks a lot of packages, far more than the upward dependencies of the edit. To pick one at random, honnef.co/go/tools/analysis/facts/purity. Yet go list -deps honnef.co/go/tools/analysis/facts/purity | grep gopls is empty, i.e. we re-typechecked a package that does not transitively depend on the changed package.

D'oh. go run ./gopls after a change to cmd.go produces a new executable with a new hash and a new cache subtree, so of course it does all the work again. Time to find the coffee machine in our new digs...


Peer count doesn't go down when peers disconnect

The peer count doesn't go down when peers disconnect. Something's not being cleaned up correctly, probably.

Duplicate of https://github.com/feross/webtorrent/issues/338


Add ability to highlight text on table headers

When there are errors in deploying a service/container, there is no easy way to grab the error except to take a screenshot.

The state is not there anymore, and is selectable..


fix boot logging on rancheros-install installed systems

Before this fix we wouldn't see what services have started or failed.
System init messages not appearing in this log were making RancherOS
look like it silently hangs on boot.

fixes #502