React - Static class field initialization fails

Describe the bug
So after updating some of our dependencies we had to enable typescript's useDefineForClassFields feature. Since then, some of our legacy react class components fail to initialize their static class fields.
This error only occurs if these two conditions are met

The class itself is decorated
The static class field initialization self references another static class field

Transformations produced by webpack or a bare esbuild build seem to work just fine.
e.g.
import React from 'react';
import { observer } from 'mobx-react';

@observer
export default class Test extends React.Component {

  public static foo = 'foo';

  private static fooBar = `${Test.foo}-bar`;

  public render() {
    return <div>{Test.fooBar}</div>;
  }
}

The error happens on the initialization of fooBar because Test.foo is accessed before initialization.
Test.tsx:18 Uncaught ReferenceError: Cannot access 'Test' before initialization
    at <static_initializer> (Test.tsx:18:19)
    at Test.tsx:16:32

The transformed code
var __defProp = Object.defineProperty;
var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
var __decorateClass = (decorators, target, key, kind) => {
  var result = kind > 1 ? void 0 : kind ? __getOwnPropDesc(target, key) : target;
  for (var i = decorators.length - 1, decorator; i >= 0; i--)
    if (decorator = decorators[i])
      result = (kind ? decorator(target, key, result) : decorator(result)) || result;
  if (kind && result)
    __defProp(target, key, result);
  return result;
};
var _jsxFileName = "/home/projects/vitejs-static-initialization-error/src/Test.tsx";
import __vite__cjsImport0_react from "/node_modules/.vite/deps/react.js?v=d1d1a958"; const React = __vite__cjsImport0_react.__esModule ? __vite__cjsImport0_react.default : __vite__cjsImport0_react;
import { observer } from "/node_modules/.vite/deps/mobx-react.js?v=4f531952";
import { jsxDEV as _jsxDEV } from "/@id/__x00__react/jsx-dev-runtime";
let Test = class extends React.Component {
  static foo = "bar";
  static fooBar = `${Test.foo}-bar`;
  render() {
    return /* @__PURE__ */ _jsxDEV("div", {
      children: Test.fooBar
    }, void 0, false, {
      fileName: _jsxFileName,
      lineNumber: 11,
      columnNumber: 12
    }, this);
  }
};
Test = __decorateClass([
  observer
], Test);
export {
  Test as default
};

Reproduction
https://stackblitz.com/edit/vitejs-static-initialization-error?file=src%2FTest.tsx
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.10 - /bin/yarn
    npm: 7.17.0 - /bin/npm
  npmPackages:
    @vitejs/plugin-react: ^2.0.0 => 2.0.0
    vite: ^3.0.2 => 3.0.4

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I think we can close this one because it's unactionable for Vite and this might be a intended behavior (https://github.com/microsoft/TypeScript/issues/48814).


IIPImage and Openseadragon error:  Unable to open [object Object]: HTTP 0 attempting to load TileSource

Hello,
I'm trying to display some images from IIPImage in Openseadragon using the deepzoom protocol.
I've setup a simple page with the viewer loading a single image, but I get the error in the subject.
If I call the url of the dzi manually, I get the following application/xml response, which seems correct:
<?xml version="1.0" encoding="UTF-8"?>
<Image xmlns="http://schemas.microsoft.com/deepzoom/2008"
TileSize="256" Overlap="0" Format="jpg"><Size Width="3680" Height="5520"/></Image>

This is the javascript used to configure Osd, where image is a .tif filename wih path (e.g.: /images/001/0001.tif):
        function loadPlayer() {
            viewer = OpenSeadragon({
                id: "container",
                prefixUrl:"images/" ,
                tileSources: server + "?DeepZoom=" + image + ".dzi"
            });
        }
        $(document).ready(function() {
            loadPlayer();
        });

May you help me please?
Thank you.

I don't know enough about IIPImage to know the issue. Perhaps @jpstroop or @azaroth42 would know.

Not sure either. @softmasters, could you try the IIIF interface from IIPImage, rather than the DZI, and see if that works?

Hello, thank you for your reply.
I'm not sure I can use the IIIF interface because I'm using IIPImage 0.9.9 stable in a production environment and this version does seem to support IIIF. IIIF is supported only in the development version.
A difference I've seen between my server's response and other examples on the web is that my server returns an inline response with application/xml mime type, whereas other examples return the response as a binary attachment. May this be the problem?

I had the same error. The issue is to do with cross site scripting. I downloaded a Chrome plugin to get around it for now. My plan is to have a proxy url within my app that then performs the IIP server query. Not sure if that helps or if you have sorted your problem by now.

Oh, if IIP isn't sending the right CORS headers, that would indeed be a problem. And not one that OpenSeadragon could solve.  Have you filed a bug against IIP for Ruven to fix?
https://github.com/ruven/iipsrv

@azaroth42 interesting point. I just assumed it's something that I had to work around. However, we don't publicly expose the IIP server, so my app has to have a proxy that openseadragon will query.

@azaroth42 I got the same problem when using a proxy locally in my app. The trick was to use a relative URL when declaring the tile sources i.e.
This didn't work - tileSources: "http://localhost:8080/myappath/images.dzi"
But this did - tileSources: "/myappath/images.dzi"
Not sure why.

I think an issue for @iangilman, if it still doesn't work with the CORS headers in place.

If there is something we need to fix inside OSD, please let me know! I don't know enough about CORS to know what needs to be done, but if you provide a repro and info for a fix, we can make it happen. Even better, a patch! :)

Hello,
I've setup a sample page where the problem occurs. Please let me know if you need anything further.
Thank you.

Sorry, forgot the link: http://www.softmasters.net/iip.html

@softmasters Thank you. So on that page I get Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://<IP_ADDRESS>/img?DeepZoom=/images/052/00001.tif.dzi. (Reason: CORS header 'Access-Control-Allow-Origin' missing). Do you know that that server has the correct CORS header?

@iangilman Indeed, the server wasn't sending a CORS header. I've configured the web server to send the header and now it's working.
Thank you for your precious help.
Regards.

@softmasters Glad to hear you got it sorted out!

I get the same problem with DZI files hosted on S3 that is enabled for web access and has CORS policy configured as follows:
<?xml version="1.0" encoding="UTF-8"?>
<CORSConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <CORSRule>
        <AllowedOrigin>*</AllowedOrigin>
        <AllowedMethod>GET</AllowedMethod>
        <AllowedMethod>POST</AllowedMethod>
        <AllowedMethod>PUT</AllowedMethod>
        <AllowedMethod>HEAD</AllowedMethod>
        <MaxAgeSeconds>3000</MaxAgeSeconds>
        <ExposeHeader>ETag</ExposeHeader>
        <AllowedHeader>*</AllowedHeader>
    </CORSRule>
</CORSConfiguration>

The web app itself runs on a separate EC2 host.
If I load the page with OSD (incognito mode) the first time it gives me the error described here if I refresh the page the viewer loads fine.
This is very strange, anyone observed anything like this?

Actually I take it back it fails all the time if I don't have Chrome dev tools opened if I do it succeeds, this is really puzzling...

Is there any special XHR configuration that OSD uses? Our app is AngularJS and we have to problems with any other XHR requests made by the app itself

Ok, I think I found the problem. Will probably be useful to others who suffers the same issue.
Basically the XHR requests were getting cached so the solution is to add a random (GUID is the best) URL param to bust the cache

Maybe makes sense to do it automatically in OSD itself for the tile source?

Oh, yeah, and the reason it was working with dev tools open is that I had "Disable caching" ON there :)

@peterlitvak Thanks for adding your experience. Was the caching happening on the server side or in your angular app that is making the call? I don't know much about Angular but it's something I will keep in mind if we move away from our current platform.

I think caching happens automatically in XHR, I've seen people complaining about the same issue (caching of XHR GET requests) with just JQuery apps.

It shouldn't be complained about. The server should use cache headers properly in responses.
Cache-busting should not be automatically done by OSD. If you can't count on your server/service to use cache headers properly and you want to make sure you get a fresh fetch from the server, then you can use a nonce or whatever :)

I'd imaging that S3 Web hosting handles headers just fine otherwise that would be a major problem, don't you think?

Are you accessing the image server in the same browser from two domains (say localhost and prod.server)?
You have to clear browser cache manually if this is the case.


tag 1.1

我们在1.2 release前tag一下1.1的文档？我已经给org安装 @JuliaRegisterator 了

需要先把Transifex上的source全部更新到1.1-release branch，之前我已经更新了manual的source到1.1，Transifex可能正常检测diff，但目前还没有更新其它的source。

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/15551
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.3.0 -m "<description of version>" 3ba6090b4838eaadf1c6e327af7d9d81e769e5ba
git push origin v1.3.0

Also, note the warning: Version 1.3.0 skips over 1.1.0
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/15552
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.1.0 -m "<description of version>" e46bf271ec567364d6a0c0c743487f4093e5f443
git push origin v1.1.0


Basic car specific materials for the car child-template

When modeling a car, it would be very helpful if you could use some basic car specific materials that are already available in the template. Material preview objects could also be very helpful to see how the materials look in the scene.

Material templates and preview were introduced with v0.3-alpha ;)


Properly report errors in mdx deps

ocaml-mdx deps seems to let some errors slip through as uncaught exceptions.
I think that for clarity it would be better if used result or at least our own exceptions so that we can catch mdx related errors and report them ourself rather than leak those uncaught exceptions.
As an example, when labels are invalide, one gets the following:
ocaml-mdx book/foreign-function-interface/README.md.mdx.deps (exit 125)
(cd _build/default/book/foreign-function-interface && ../../../install/default/bin/ocaml-mdx deps README.md) > _build/default/book/foreign-function-interface/README.md.mdx.deps
ocaml-mdx: internal error, uncaught exception:
           Failure("File \"README.md\", line 230, character 371: invalid code block: `non-deterministic` label cannot be used with a `file` label.")

Closed with #267


Integration tests for Catalog Configuration.

Add Integration tests for read the catalog configuration for the requested catalog.
Relates-To: OLPEDGE-1217.
Signed-off-by: Bautista, Iryna<EMAIL_ADDRESS>

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #116   +/-   ##
======================================
  Coverage    82.8%   82.8%
======================================
  Files          44      44
  Lines         882     882
  Branches      134     134
======================================
  Hits          731     731
  Misses        112     112
  Partials       39      39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2c064...cbdd66d. Read the comment docs.


ObjectSet report controllerOf in status

Output a list of controlled objects in ObjectSet and ObjectSetPhase APIs.
We will need this to coordinate roll forward in the upcoming ObjectDeployment API.
Process outlined in the documentation: https://package-operator.run/docs/concepts/revisions/

Looks good to me.


Extend batch operations with consistency level

Codecov Report
Base: 96.35% // Head: 96.13% // Decreases project coverage by -0.23% :warning:

Coverage data is based on head (c2acb09) compared to base (3d66fb7).
Patch coverage: 87.73% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   96.35%   96.13%   -0.23%
==========================================
  Files          60       60
  Lines        7081     7261     +180
==========================================
+ Hits         6823     6980     +157
- Misses        258      281      +23

Flag
Coverage Δ

unittests
96.13% <87.73%> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

weaviate/client.py
98.30% <ø> (ø)

weaviate/wcs/crud_wcs.py
98.50% <ø> (ø)

integration/test_graphql.py
87.50% <42.85%> (-12.50%)
:arrow_down:

integration/test_authentication.py
89.09% <57.89%> (-6.52%)
:arrow_down:

weaviate/util.py
95.85% <63.63%> (-2.25%)
:arrow_down:

weaviate/connect/connection.py
90.05% <70.37%> (-3.66%)
:arrow_down:

weaviate/batch/crud_batch.py
90.97% <75.00%> (-0.72%)
:arrow_down:

weaviate/data/crud_data.py
91.47% <94.73%> (+2.69%)
:arrow_up:

test/batch/test_crud_batch.py
100.00% <100.00%> (ø)

test/connection/test_connection.py
91.89% <100.00%> (ø)

... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


I can open with Android Studio 3.0

I Download this project,but I can't Open in Android studio 3.0.
And I Use Connectbot Telnet .but the backspace can't use.how can I do.thank you.

@douglaswth I also have this problem


Can not scroll with lspsaga smart scroll

Description

Hi, I got this error when trying to execute keymap for lspsaga smart scroll
E5108: Error executing lua ...te/pack/packer/start/lspsaga.nvim/lua/lspsaga/action.lua:30: attempt to compare nil with number
stack traceback:
        ...te/pack/packer/start/lspsaga.nvim/lua/lspsaga/action.lua:30: in function 'scroll_in_win'
        .../pack/packer/start/lspsaga.nvim/lua/lspsaga/provider.lua:423: in function 'scroll_in_preview'
        .../pack/packer/start/lspsaga.nvim/lua/lspsaga/provider.lua:481: in function 'scroll_in_preview'
        [string ":lua"]:1: in main chunk

Expected Behavior

It should scroll the window up/down
Actual Behavior

It showed the error above
Neovim Built in Behavior

Neovim doesn't have this built in AFAIK
Details

Reproduce
lspconfig.lua
local root_pattern = require('lspconfig.util').root_pattern
local lspconfig = require 'lspconfig'
local capabilities = require('plugins.configs.cmp').capabilities

vim.lsp.set_log_level 'error'

vim.diagnostic.config {
  virtual_text = {
    prefix = '',
  },
  signs = true,
  underline = true,
  update_in_insert = false,
}

local opts = { silent = true }

vim.keymap.set('n', '[d', '<cmd>Lspsaga diagnostic_jump_next<cr>', opts)
vim.keymap.set('n', ']d', '<cmd>Lspsaga diagnostic_jump_prev<cr>', opts)
vim.keymap.set('n', 'gl', '<cmd>Lspsaga show_line_diagnostics<cr>', opts)
vim.keymap.set('n', 'gL', '<cmd>lua vim.diagnostic.setloclist()<cr>', opts)
vim.keymap.set('n', 'gq', '<cmd>lua vim.diagnostic.setqflist()<cr>', opts)

vim.api.nvim_create_augroup('LSPConfigUser', { clear = true })

local on_attach = function(client, bufnr)
  if client.name == 'sumneko_lua' or client.name == 'gopls' then
    vim.api.nvim_create_autocmd('BufWritePre', {
      group = 'LSPConfigUser',
      buffer = bufnr,
      callback = function()
        vim.lsp.buf.format()
      end,
    })
  end

  -- Mappings.
  opts.buffer = bufnr
  -- See `:help vim.lsp.*` for documentation on any of the below functions
  vim.keymap.set('n', 'gD', '<cmd>lua vim.lsp.buf.declaration()<cr>', opts)
  vim.keymap.set('n', 'gd', '<cmd>Lspsaga preview_definition<cr>', opts)
  vim.keymap.set('n', 'gh', '<cmd>Lspsaga hover_doc<cr>', opts)
  vim.keymap.set('n', 'gi', '<cmd>Lspsaga implement<cr>', opts)
  vim.keymap.set('n', 'gk', '<cmd>Lspsaga signature_help<cr>', opts)
  vim.keymap.set('n', 'gr', '<cmd>Lspsaga rename<cr>', opts)
  vim.keymap.set('n', 'gR', '<cmd>Lspsaga lsp_finder<cr>', opts)
  vim.keymap.set('n', 'gA', '<cmd>Lspsaga code_action<cr>', opts)
  vim.keymap.set('x', 'gx', '<cmd>Lspsaga range_code_action<cr>', opts)
  vim.keymap.set('n', 'gf', '<cmd>lua vim.lsp.buf.format()<cr>', opts)
  vim.keymap.set('n', '<c-f>', "<cmd>lua require('lspsaga.action').smart_scroll_with_saga(1, '<c-f>')<cr>", opts)
  vim.keymap.set('n', '<c-b>', "<cmd>lua require('lspsaga.action').smart_scroll_with_saga(-1, '<c-b>')<cr>", opts)
end

local runtime_path = vim.split(package.path, ';')
table.insert(runtime_path, 'lua/?.lua')
table.insert(runtime_path, 'lua/?/init.lua')

lspconfig.sumneko_lua.setup {
  on_attach = on_attach,
  capabilities = capabilities,
  settings = {
    Lua = {
      runtime = {
        version = 'LuaJIT',
        path = runtime_path,
      },
      diagnostics = {
        enable = true,
        globals = { 'vim' },
        neededFileStatus = {
          ['codestyle-check'] = 'Any',
        },
      },
      workspace = {
        library = vim.api.nvim_get_runtime_file('', true),
      },
      telemetry = {
        enable = false,
      },
      format = {
        enable = true,
        defaultConfig = {
          indent_style = 'space',
          indent_size = '2',
          quote_style = 'single',
          call_arg_parentheses = 'unambiguous_remove_string_only',
        },
      },
    },
  },
}

lspsaga.lua
local lspsaga = require 'lspsaga'
lspsaga.setup {
  debug = true,
  use_saga_diagnostic_sign = false,
  -- diagnostic sign
  error_sign = '',
  warn_sign = '',
  hint_sign = '',
  infor_sign = '',
  diagnostic_header_icon = '   ',
  -- code action title icon
  code_action_icon = ' ',
  code_action_prompt = {
    enable = true,
    sign = true,
    sign_priority = 40,
    virtual_text = true,
  },
  finder_definition_icon = '  ',
  finder_reference_icon = '  ',
  max_preview_lines = 10,
  finder_action_keys = {
    open = 'o',
    vsplit = 's',
    split = 'i',
    quit = '<esc>',
    scroll_down = '<c-f>',
    scroll_up = '<c-b>',
  },
  code_action_keys = {
    quit = '<esc>',
    exec = '<cr>',
  },
  rename_action_keys = {
    quit = '<esc>',
    exec = '<cr>',
  },
  definition_preview_icon = '  ',
  border_style = 'single',
  rename_prompt_prefix = '➤',
  rename_output_qflist = {
    enable = false,
    auto_open_qflist = false,
  },
  server_filetype_map = {},
  diagnostic_prefix_format = '%d. ',
  diagnostic_message_format = '%m %c',
  highlight_prefix = false,
}

Environment
NVIM v0.8.0-dev
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by nixbld

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "
/nix/store/rvillp8grvwp6cx1qkwayd4x3jwwsgf2-neovim-unwrapped-master/share/nvim
"

Run :checkhealth for more info

Linux NixOS 22.05

hmmm can  you share how you've bind it.
    require'lspsaga.action'.smart_scroll_with_saga(1, '<c-d>')
    require'lspsaga.action'.smart_scroll_with_saga(-1, '<c-u>')

works for me

@tami5 sorry my lspconfig was a bit long, the binding is included in the issue description, but I put it here:
vim.keymap.set('n', '<c-f>', "<cmd>lua require('lspsaga.action').smart_scroll_with_saga(1, '<c-f>')<cr>", opts)
vim.keymap.set('n', '<c-b>', "<cmd>lua require('lspsaga.action').smart_scroll_with_saga(-1, '<c-b>')<cr>", opts)

this is what I have when running :verbose map <c-f>
n  <C-F>       *@<Cmd>lua require('lspsaga.action').smart_scroll_with_saga(1, '<C-F>')<CR>
        Last set from Lua

hmmm thats odd, the issue is here
    if current_win_lnum >= last_lnum then
      current_win_lnum = last_lnum - 1
    end

so this function scroll_in_win is called by multiple provider, does this happen when you want to scroll hover?, some how last_num isn't set by the caller, which can be a bug

Hi, thanks for taking a look. the smart scroll does not work in all lspsaga windows (hover, preview definition...) (nothing happens), but only the scroll  in  lsp finder generate the error

but only the scroll in lsp finder generate the error

Oh, I see, I was wondering why I didn't experience this error. unfortunately this is the one thing I kept but haven't been using, there are many open issues regarding lsp finder and I recommend replacing with something like telescope lsp_* . feel free to continue debugging if you found a solution please open a pr.

@tami5 but the normal smart scroll command do not work on other lspsaga windows too. (hover, preview definition) 😭

hmmm

this is what I have when running :verbose map <c-f>
n  <C-F>       *@<Cmd>lua require('lspsaga.action').smart_scroll_with_saga(1, '<C-F>')<CR>
        Last set from Lua

Maybe the way the command is set?
n  <C-D>       * <Cmd>lua require'lspsaga.action'.smart_scroll_with_saga(1, '<C-D>')<CR>
        Last set from Lua

mine doesn't have @

it's because i set them in with buffer option. I also set them without buffer option but it doesn't work. Is there a way to jump to the lspsaga window? I can scroll from there. I tried with <C-w>W or <C-w><C-w> but the window only closes.

it's because i set them in with buffer option. I also set them without buffer option but it doesn't work. Is there a way to jump to the lspsaga window? I can scroll from there. I tried with <C-w>W or <C-w><C-w> but the window only closes.

I'm also setting it using buffer, try using old vim api vim.cmd'nmap <buffer>...'
for hovers you can double hover to jump to it, others not sure.

for hovers you can double hover to jump to it, others not sure.

hi, can we make it work the same for other windows? like jumping to the window that we need to scroll when we hit the keymap again when that window is openned?


Define each log level

Related #70
Each level should have a somewhat clear definition.

I think it's best left to the user to find some consistent definition for each level.

I disagree, everyone ends up with a different definition. I'd prefer an opinionated and documented stance but if someone wants to use something different, they always can.


[$1000] Chat - If url ends with slash, then ending double quote is shown as link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Tap on a report
In compose, enter "om https://www.she.com/"
"om https://www.she.com"
Tap send

Expected Result:
Irrespective of url ends with/without slash, url alone must be displayed as link and not ending double quote
Actual Result:
If url ends with slash, then ending double quote is shown as link. If url ends without slash, then correctly url alone displayed as link
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/3ea950da-b0ae-4025-84a2-90b956b72657
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a579e05c4814caf9
Upwork Job ID:<PHONE_NUMBER>685785600
Last Price Increase: 2023-08-11
Automatic offers:

situchan | Contributor | 26192821

@lanitochka17 can you clarify which platforms this occurs on?

Proposal
Please re-state the problem that we are trying to solve in this issue.
When users input URLs in the chat application that end with a slash and then immediately close with a double quote, the application incorrectly includes the double quote as part of the URL link.
What is the root cause of that problem?
the common lib parse links is not perfect, while it is very good enough. It does parse correct many url links with its regex rule, even already considerate of the "(" and ")", it does not include '"'.
What changes do you think we should make in order to solve the problem?
I do not think revise the common lib is a good idea, as it is already good enough.
Indeed, app part has its own utilities function which does not depend on common lib very much, just add some regex rule, it will solve this issue, as follow, I successfully solved this issue, with or without slash, the url link is ok.
My solution does not need common lib changes, just use the common lib function, and add some extra regex rule is ok.

What alternative solutions did you explore? (Optional)
Change the common lib directly, but I really do not suggest to solve the issue like so.

Contributor details
Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e99782a01937e92c

I think the problem is to know what we want, do we accept quotes like this "" after the .com or not ? And do we accept escaped quotes like this: " ? Because right now we are escaping the comment before testing the regexp... So I don't think we can have a different behaviour for " and for &quot. So what should be this behavior ?

And in slack if you don't have a / &quot is not recognized either

What do you think about the above, @parasharrajat?

Sure - assigned you @situchan

Thanks for proposals. I don't think anyone proposed right solution to make url ending with slash work always.
This is basic testing:

Please provide exact root cause why ending with / not work while without / works

@situchan Because the " is transformed into &quot and with slash it is accepted as a path or argument. This is normal behaviour. I think for &quot but not for ". I explaoned the problem here
https://github.com/Expensify/App/issues/24367#issuecomment-1676467982

Proposal
Please re-state the problem that we are trying to solve in this issue.
When users input URLs in the chat application that end with a slash and then immediately close with a double quote, the application incorrectly includes the double quote as part of the URL link.
What is the root cause of that problem?
The root cause is that double quote is being allowed in Url.
but according to RFC2396, double quote is not allowed. instead we should use escaped form %22 for double quote.
Backend is not allowing it as well. e.g: seding http://test.com/test="test" returns http://test.com/test=
https://github.com/Expensify/App/assets/139204153/ea19c56f-8fac-4dd3-8265-44bc37c42d54
What changes do you think we should make in order to solve the problem?
in line https://github.com/Expensify/expensify-common/blob/main/lib/Url.js#L6, we are expected to remove 'quot'
also need some tweaks on auto test case
in line https://github.com/Expensify/expensify-common/blob/main/tests/ExpensiMark-HTML-test.js#L403, replace double quote with %22.
in line https://github.com/Expensify/expensify-common/blob/main/tests/ExpensiMark-HTML-test.js#L444, replace " with %22.
and we can add following test case for this issue.
    testString = '"om https://www.she.com/"';
    resultString = '"om https://www.she.com/"';
    expect(parser.replace(testString)).toBe(resultString);

Proposal
Please re-state the problem that we are trying to solve in this issue.
When there is a " at the end of the url, it is recognized as part of the url
What is the root cause of that problem?
When we transform the links in html  we use this regexp for the path of the url: https://github.com/Expensify/expensify-common/blob/7735de14112a968fd6a4f5af710d2fbaefc8809d/lib/Url.js#L7 This regexp accept quotes as a valid path, the path is only after a / that's why we don't accept quote directly after  .com for example
What changes do you think we should make in order to solve the problem?
We had the same exact problem with parenthesis so we can use the same way to remove the end quote if it's not preceded by another quote.
This is how we were removing the end parenthesis:
https://github.com/Expensify/expensify-common/blob/7735de14112a968fd6a4f5af710d2fbaefc8809d/lib/ExpensiMark.js#L450-L472
What alternative solutions did you explore? (Optional)

Any thoughts on these updated proposals @situchan?

@greg-schroeder Device on which the issue was found: Redmi note 10 s / Chrome

bump @situchan

bumped in c+ room

updating today

Bump @situchan

Bump @situchan

For contributors: can you please share screenshot with these links after applying your solution?
https://www.she.com/path?test="123"
https://www.she.com/path?test="123/"
"https://www.she.com/path?test="123"
"https://www.she.com/path?test="123/"
https://www.she.com/path?test=123"
https://www.she.com/path?test=123/"
https://www.she.com/path?test=/"123"
https://www.she.com/path?test=/"123/"

My proposal  can adapt to what the expected behaviour will be. The truth is there is not a great way to know if the quote is part of the url or not , I was thinking to remove quotes if they are unmatched lile we will do for end parenthesis but for quotes which one to remove if they are 3. Actually I believe we should do lile slacks and remove them all as long as they are like this: " and not alreafy escaped: " my solution is the only one that can do this because I am not using the regexp where the text is already escaped.

@situchan Slack does not accept double quote in URL

@situchan Slack does not accept double quote in URL

@Antasel I know. Did you check https://github.com/Expensify/App/issues/24367#issuecomment-1714528065?

@situchan yes, checked.
I hope you check video again on my proposal. Backend does not accept double quote, but just the escaped form %22.
Checking of slack and the video, I am sure we should follow like Slack for this issue

I like @Antasel's proposal.
I agree double quote should not be included in url. If included, escape it!
Also consistent with backend logic.
🎀 👀 🎀 C+ reviewed

Before fix:

After fix:

Slack:

@situchan I know this was not a proposal but @Antasel proposal is basically what I was commenting here, https://github.com/Expensify/App/issues/24367#issuecomment-1676468774
I didn't go that way because I thought it could create regression by not only removing " but the form """

@ShogunFire I saw that comment but @Antasel provided explanation enough why that solution is ideal.
The main reason why I accepted that solution is it's consistent with backend logic.

@ShogunFire indeed states some root cause, just remove "quote" in addEscapedChar is not enough to solve this issue perfectly.
test the string

you could find that it stops at "=", it is not same as slack.
I know this url is a little stranger, but for the user, he may write it as the image shows, so the url maybe not perfect as we expected with a "?".
And just remove the "quote" still can not solve the url like this

the result is not ideal, and it is a little out of our expectation.

We have no good way to deal with "&quot", if the user will never input this, then the issue will be much easier to solve.

I agree with bringing this in line with how the back-end does it. Let's make sure we add tests for the various scenarios.

@puneetlath  @situchan
The PR https://github.com/Expensify/expensify-common/pull/574 for expensify-common repo is ready for review

@ShogunFire how do you think of this solution which is not perfect? we know it will be still wrong when the string contains """, and it does not like slack, or even GitHub, if we just need to fix "/", there will be many methods to fix it, but fix this issue perfect like slack or GitHub, it will be a little hard, just remove "quot" is too simple, and can only fix the issue at some extent.

check the images, the bug still exists

@gzqyl we don't need to follow slack, github

Work continues on linked PR

@Antasel I've merged the expensify-common PR. Can you please go ahead and open a PR in App to incorporate the changes?

@Antasel I've merged the expensify-common PR. Can you please go ahead and open a PR in App to incorporate the changes?

ok, I am in

@puneetlath
We sorry to say about @Antasel deceased by sudden stroke. we can't believe it yet.
unfortunately our team can't access via his github account, if expensify engineer team allow us to use other account, it will be benefit to us and his family..
if can't, please move forward by internal team.

Hey @situchan - given the situation outlined here, do you think you'd be able to step in to help out with Puneet's request here?

Sorry to hear that.
@puneetlath should I raise app PR?
Actually I am not too worried about app PR as I think expensify-common package version will be bumped anytime from any other PRs.

@situchan yes, if you don't mind that would be great. We can add urgency bonus for the trouble.

Hi @agilejune - Ah, wow, that is really sad news, thanks for letting us know. This is definitely a delicate situation, but we have pretty hard and fast rules when it comes to paying out issues. As it stands, we can only pay the contributor's account directly and won't be able to redirect any payments or anything like that. Also I'm not sure if there's a ton of action we can take to help with GitHub account acesss.
Have you had a chance to contact Upwork or Github to inform them of the situation? It's likely they may have processes in place to help folks gain access to accounts that belong to deceased colleagues/family members.

@greg-schroeder
I contacted his family. and there is policy to collect funds for a deceased freelancer’s estate on upwork.
I am sure you would release milestone for @Antasel 's work.
then his family can get funds via other payment method from upwork

@agilejune thanks. I will just process the issue normally and will let you know as we move towards payment

Sorry for delay, was OOO. Processing today.

Payment summary:
Contributor: @Antasel $1000
C+: @situchan $1000
Paid out @agilejune fyi

@greg-schroeder can you please check https://github.com/Expensify/App/issues/24367#issuecomment-1732968580?

will fire regression test using automation steps


Back-Button in post-view not always leading back

Currently it always leads to the post-overview, even when people started out in the feed view.

this is quite irritating, happens to me in firefox

I think this happens when you follow a HTML link to matchat. then the back-button doesnt work anymore. this happens on our git hub page where a lin to matchat is: https://github.com/researchstudio-sat/webofneeds. i also tested with another html document with a link to matchat. same happens there!

is duplicate of #1312


It allows overlaying on same frames.

https://www.dropbox.com/s/2kb95e073kvn7x6/TKDragView.mov?dl=0
you can see video from above link.
Thank you.

Do you have a bit of time to take a look of the reason?

i had tried my best can you please help me ??i am new to iPhone.

i need last help don't allow overlaying.

For this only my game is not moving ahead.

i am facing same issue @mapedd

can you please help me sir ?

This small help will solve my big problem
i need this help for below project.

Hi iossolution you have any idea to resolve this ??


⚠ Bofrost.be has degraded performance

In 9a07022, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1524 ms

Resolved: Bofrost.be performance has improved in 23daf07 after 9 minutes.


Live Sass Compiler not finding .scss file

Original post
These are my workspace settings:
{
    "liveSassCompile.settings.formats": [
        {
         "format": "expanded",
         "extensionName": ".css",
         "savePath": "~/"
        }
       ],
    "liveSassCompile.settings.includeItems": [
        "/src/styles/main.scss",
    ],
    "git.ignoreLimitWarning": true
}

But when I run Get All Included Files The main.scss is not found. Compiling once by hand works fine.
I'm on a windows 10 machine SSHd into a linux machine. I have installed 5.1.2-alpha

Steps to fix for 5.2 release

[ ] Find cause
[ ] Fix it

Sorry to hear your having an issue.
With the main file open, what's the result of running the liveSass.command.debugInclusioncommand?
Then can you please clear the output window and include the output provided by the liveSass.command.debugFileList command.

When I run liveSass.command.debugInclusion
Checking current file
/home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
File excluded
The file is excluded based on your settings, please check your configuration

When I run liveSass.command.debugFileList
Extension Info
--------------------
Current File
--------------------
/home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
Workspace Folders
--------------------
[0] dev
/home/dave/MagentoAPI/dev
--------------------
Checking workspace folder 0 of 1
Path: /home/dave/MagentoAPI/dev
--------------------
--------------------
Current Include/Exclude Settings
--------------------
Include: [ /src/styles/main.scss ]
Exclude: [ /**/node_modules/**, /.vscode/** ]
--------------------
Included SASS Files
--------------------
--------------------
Included Partial SASS Files
--------------------
--------------------
Excluded SASS Files
--------------------
--------------------

Thanks for your help with this!

Very strange. I've quickly expanded the liveSass.command.debugFileList command in the below revision - just added a search for any/all SASS files in the project. Hopefully, it will help me identify the issue, ready for a proper testing build.
Can you run the command and include the extra output. Thanks
live-sass-5.2.0-nightly.2.zip

Here's the output:
`Extension Info
Current File
/home/dave/MagentoAPI/dev/src/styles/main.scss
Workspace Folders
[0] mc_test
/home/dave/mc_test
[1] mc_dev
/home/dave/mc_dev
[2] mailchimp_integration
/home/dave/mailchimp_integration
[3] MagentoAPI
/home/dave/MagentoAPI
Checking workspace folder 1 of 4
Path: /home/dave/mc_dev

Current Include/Exclude Settings
Include: [ NULL ]
Exclude: [ //node_modules/, /.vscode/** ]
Included SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss
Included Partial SASS Files

Excluded SASS Files

All SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss
Checking workspace folder 2 of 4
Path: /home/dave/mailchimp_integration

Current Include/Exclude Settings
Include: [ NULL ]
Exclude: [ //node_modules/, /.vscode/** ]
Included SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss
Included Partial SASS Files

Excluded SASS Files

All SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss
Checking workspace folder 3 of 4
Path: /home/dave/MagentoAPI

Current Include/Exclude Settings
Include: [ NULL ]
Exclude: [ //node_modules/, /.vscode/** ]
Included SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss
Included Partial SASS Files

Excluded SASS Files

All SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss
Checking workspace folder 0 of 4
Path: /home/dave/mc_test

Current Include/Exclude Settings
Include: [ NULL ]
Exclude: [ //node_modules/, /.vscode/** ]
Included SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss
Included Partial SASS Files

Excluded SASS Files

All SASS Files
/home/dave/MagentoAPI/dev/src/styles/main.scss`
But it's still not compiling after save when it's watching.

That's very strange the files are now being detected in your new workspace structure. Stranger still that it's still not compiling.
Can you set your showOutputOn to Trace save the file and then paste the output here? Thanks

`Command called: "liveSass.command.watchMySass"
Starting to compile all files
Changing status bar to: "Working on it..."
Getting SASS files
Query pattern: undefined
Can be overwritten: true
Checking folder 1 of 1
Folder: dev
Query pattern overwritten
New pattern(s): "/src/styles/main.scss"
No base folder override found. Keeping workspace folder
Found 0 SASS files
Compiling Sass/Scss Files:
Switching UI state
Changing status bar to: Watching
Watching...
VS Code event: "onDidSaveTextDocument"
Found the workspace folder
Workspace Name: dev
SASS file saved
A SASS file has been saved, starting checks
Checking SASS path isn't excluded
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
No base folder override found. Keeping workspace folder
Searching folder
File not found, must be excluded
File excluded
The file has not been compiled as it's excluded by user settings
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------`
I've checked the user settings.json and liveSassCompile settings are listed in that file, only the workspace file.

I have a theory as to why it might not be working.
I have expanded on some trace logs and applied a fix (if this is the cause). Please install the revision below, keep your showOutputWindowOn as Trace, test and then post the output back here.
live-sass-5.2.0-nightly.2.1.zip
Thanks

"live-sass-compiler" is now activate
--------------------
Constructing app model
--------------------
Constructing error logger
--------------------
Clearing any old log data
--------------------
Error logs cleared
--------------------
Changing status bar to: "Starting..."
--------------------
App model constructed
--------------------
Checking for an unread announcement
--------------------
Live SASS commands ready
Commands have been saved and are ready to be used
--------------------
Announcement has already been shown
--------------------
Changing status bar to: Not watching (or Watch SASS)
--------------------
Command called: "liveSass.command.watchMySass"
--------------------
Starting to compile all files
--------------------
Changing status bar to: "Working on it..."
--------------------
Getting SASS files
Query pattern: undefined
Can be overwritten: true
--------------------
Checking folder 1 of 1
Folder: dev
--------------------
Query pattern overwritten
New pattern(s): "/src/styles/main.scss"
--------------------
No base folder override found. Keeping workspace folder
--------------------
Found 0 SASS files
--------------------
Compiling Sass/Scss Files:
--------------------
Switching UI state
--------------------
Changing status bar to: Watching
--------------------
Watching...
--------------------
VS Code event: "onDidSaveTextDocument"
--------------------
Found the workspace folder
Workspace Name: dev
--------------------
SASS file saved
A SASS file has been saved, starting checks
--------------------
Checking SASS path isn't excluded
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
No base folder override found. Keeping workspace folder
--------------------
Searching folder
Search results
--------------------
File not found, must be excluded
--------------------
File excluded
The file has not been compiled as it's excluded by user settings
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------

Still no dice. Hope this helps.

Hey Glenn
I had to remove this from my settings file to get it to work. I tried this previously.
    "liveSassCompile.settings.includeItems": [
        "/src/styles/main.scss",

Didn't know that including a path excluded others. Also, that's the relative path to my workspace so I think it should have worked. Nonetheless, it's working now without specifying the path.

Follow-up, I only got it to work once. Still have the path remove and it's not compiling.

Sorry for the delay, racking my brain.

Didn't know that including a path excluded others. Also, that's the relative path to my workspace so I think it should have worked....

Yeah, the includeItems is the perfect setting when you only have a few files you want to compile. However, saving a specified file - or any other partial files - should still compile any necessary files.

... Nonetheless, it's working now without specifying the path.   ....    Follow-up, I only got it to work once

Strange that it compiled one time.

So I think it may be some kind of compatibility issue when fdir is searching using a SSH connection. Maybe username and password info needs to be passed through so fdir can correctly crawl it 🤷
To test this could you please do a couple of things for me? Firstly, can you use the below nightly build so I can see the output from a specific fdir command?
live-sass-5.2.0-nightly.2.2.zip
After that, could you copy the files locally and test the extension then?
If the issue does lie somewhere in/with fdir then I can reach out to them to see if there's anything that can be done to resolve the matter

Here's the output:
Watching...
--------------------
VS Code event: "onDidSaveTextDocument"
--------------------
Found the workspace folder
Workspace Name: MagentoAPI
--------------------
SASS file saved
A SASS file has been saved, starting checks
--------------------
Checking SASS path isn't excluded
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
No base folder override found. Keeping workspace folder
--------------------
Searching folder
FDIR OUTPUT
[{"dir":"/home/dave/MagentoAPI","files":[]},{"dir":"/home/dave/MagentoAPI/dev","files":["/home/dave/MagentoAPI/dev/docker-compose.yml","/home/dave/MagentoAPI/dev/dockerfile"]},{"dir":"/home/dave/MagentoAPI/dev/.app","files":["/home/dave/MagentoAPI/dev/.app/composer.json","/home/dave/MagentoAPI/dev/.app/composer.lock"]},{"dir":"/home/dave/MagentoAPI/dev/.vscode","files":["/home/dave/MagentoAPI/dev/.vscode/settings.json"]},{"dir":"/home/dave/MagentoAPI/dev/mysql-data","files":["/home/dave/MagentoAPI/dev/mysql-data/#ib_16384_0.dblwr","/home/dave/MagentoAPI/dev/mysql-data/#ib_16384_1.dblwr","/home/dave/MagentoAPI/dev/mysql-data/auto.cnf","/home/dave/MagentoAPI/dev/mysql-data/binlog.000001","/home/dave/MagentoAPI/dev/mysql-data/binlog.000002","/home/dave/MagentoAPI/dev/mysql-data/binlog.000003","/home/dave/MagentoAPI/dev/mysql-data/binlog.000004","/home/dave/MagentoAPI/dev/mysql-data/binlog.000005","/home/dave/MagentoAPI/dev/mysql-data/binlog.000006","/home/dave/MagentoAPI/dev/mysql-data/binlog.000007","/home/dave/MagentoAPI/dev/mysql-data/binlog.000008","/home/dave/MagentoAPI/dev/mysql-data/binlog.000009","/home/dave/MagentoAPI/dev/mysql-data/binlog.000010","/home/dave/MagentoAPI/dev/mysql-data/binlog.000011","/home/dave/MagentoAPI/dev/mysql-data/binlog.000012","/home/dave/MagentoAPI/dev/mysql-data/binlog.000013","/home/dave/MagentoAPI/dev/mysql-data/binlog.000014","/home/dave/MagentoAPI/dev/mysql-data/binlog.000015","/home/dave/MagentoAPI/dev/mysql-data/binlog.000016","/home/dave/MagentoAPI/dev/mysql-data/binlog.000017","/home/dave/MagentoAPI/dev/mysql-data/binlog.000018","/home/dave/MagentoAPI/dev/mysql-data/binlog.000019","/home/dave/MagentoAPI/dev/mysql-data/binlog.000020","/home/dave/MagentoAPI/dev/mysql-data/binlog.000021","/home/dave/MagentoAPI/dev/mysql-data/binlog.000022","/home/dave/MagentoAPI/dev/mysql-data/binlog.000023","/home/dave/MagentoAPI/dev/mysql-data/binlog.000024","/home/dave/MagentoAPI/dev/mysql-data/binlog.000025","/home/dave/MagentoAPI/dev/mysql-data/binlog.000026","/home/dave/MagentoAPI/dev/mysql-data/binlog.000027","/home/dave/MagentoAPI/dev/mysql-data/binlog.000028","/home/dave/MagentoAPI/dev/mysql-data/binlog.000029","/home/dave/MagentoAPI/dev/mysql-data/binlog.000030","/home/dave/MagentoAPI/dev/mysql-data/binlog.000031","/home/dave/MagentoAPI/dev/mysql-data/binlog.000032","/home/dave/MagentoAPI/dev/mysql-data/binlog.000033","/home/dave/MagentoAPI/dev/mysql-data/binlog.000034","/home/dave/MagentoAPI/dev/mysql-data/binlog.000035","/home/dave/MagentoAPI/dev/mysql-data/binlog.000036","/home/dave/MagentoAPI/dev/mysql-data/binlog.000037","/home/dave/MagentoAPI/dev/mysql-data/binlog.000038","/home/dave/MagentoAPI/dev/mysql-data/binlog.000039","/home/dave/MagentoAPI/dev/mysql-data/binlog.index","/home/dave/MagentoAPI/dev/mysql-data/ca-key.pem","/home/dave/MagentoAPI/dev/mysql-data/ca.pem","/home/dave/MagentoAPI/dev/mysql-data/client-cert.pem","/home/dave/MagentoAPI/dev/mysql-data/client-key.pem","/home/dave/MagentoAPI/dev/mysql-data/ib_buffer_pool","/home/dave/MagentoAPI/dev/mysql-data/ib_logfile0","/home/dave/MagentoAPI/dev/mysql-data/ib_logfile1","/home/dave/MagentoAPI/dev/mysql-data/ibdata1","/home/dave/MagentoAPI/dev/mysql-data/mysql.ibd","/home/dave/MagentoAPI/dev/mysql-data/private_key.pem","/home/dave/MagentoAPI/dev/mysql-data/public_key.pem","/home/dave/MagentoAPI/dev/mysql-data/server-cert.pem","/home/dave/MagentoAPI/dev/mysql-data/server-key.pem","/home/dave/MagentoAPI/dev/mysql-data/undo_001","/home/dave/MagentoAPI/dev/mysql-data/undo_002"]},{"dir":"/home/dave/MagentoAPI/dev/php-confs","files":["/home/dave/MagentoAPI/dev/php-confs/override.ini"]},{"dir":"/home/dave/MagentoAPI/dev/src","files":["/home/dave/MagentoAPI/dev/src/AttTest.php","/home/dave/MagentoAPI/dev/src/AttributesSamplePayload.json","/home/dave/MagentoAPI/dev/src/MageAPIdev.code-workspace","/home/dave/MagentoAPI/dev/src/ParentTest.php","/home/dave/MagentoAPI/dev/src/Scratch.php","/home/dave/MagentoAPI/dev/src/SirvTest.php","/home/dave/MagentoAPI/dev/src/Sirvimgtest.php","/home/dave/MagentoAPI/dev/src/SqlQueries.php","/home/dave/MagentoAPI/dev/src/UUconnparams.php","/home/dave/MagentoAPI/dev/src/UUconnparamsbulk.php","/home/dave/MagentoAPI/dev/src/autoConfig.php","/home/dave/MagentoAPI/dev/src/cats.php","/home/dave/MagentoAPI/dev/src/firstUp.php","/home/dave/MagentoAPI/dev/src/home.php","/home/dave/MagentoAPI/dev/src/imgLinkTab.php","/home/dave/MagentoAPI/dev/src/index.php","/home/dave/MagentoAPI/dev/src/login.php","/home/dave/MagentoAPI/dev/src/newGet.php","/home/dave/MagentoAPI/dev/src/newfile.txt","/home/dave/MagentoAPI/dev/src/protect-this.php","/home/dave/MagentoAPI/dev/src/scratch2.php","/home/dave/MagentoAPI/dev/src/style.css","/home/dave/MagentoAPI/dev/src/workingGUZ.php","/home/dave/MagentoAPI/dev/src/workspace.code-workspace"]},{"dir":"/home/dave/MagentoAPI/dev/.app/vendor","files":["/home/dave/MagentoAPI/dev/.app/vendor/autoload.php"]}]
--------------------
Search results
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
  isMatch: true
   - Base path: /home/dave/MagentoAPI
   - Rela path: dev/src/styles/main.scss
  compare: true
   - Orig file path: /home/dave/MagentoAPI/dev/src/styles/main.scss
   - Orig sass path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
File not found, must be excluded
--------------------
File excluded
The file has not been compiled as it's excluded by user settings
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------

Hey @brohon,
So the great team over at fdir believe that they have identified the problem and resolved it. I have released alpha-2 which is available on the ahead branch.
Please download v5.2.0-alpha.2 and see if it has fixed your issue.

Hey @brohon, have you had a chance to test this yet?

Hey @glenn2223 , not yet. Been working on the logic in my application. I'll test it this afternoon and get back to you.

Glenn! No Worries about pestering! It Works! Successfully made a change to the Sass file and it generated my CSS. I didn't have to specify anything in the workspace settings either, which is nice. Below is the output in case you're interested.
Thanks for your diligence on this. It's much appreciated. The open-source world turns 'round because of people like you.
No workspace provided
Using originating path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
Starting compilation
Starting compilation of file
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
Autoprefixer isn't false, applying to file
Path: /home/dave/MagentoAPI/dev/src/styles/main.scss
--------------------
Preparing autoprefixer
--------------------
Starting autoprefixer
--------------------
Completed autoprefixer
--------------------
Saving file
Saving a file to the system
Target: /home/dave/MagentoAPI/dev/src/styles/main.css.map
--------------------
Saving file
Saving a file to the system
Target: /home/dave/MagentoAPI/dev/src/styles/main.css
--------------------
Changing status bar to: Success
Registered timeout to switch state back
--------------------
Generated:
/home/dave/MagentoAPI/dev/src/styles/main.css.map
/home/dave/MagentoAPI/dev/src/styles/main.css
--------------------
Registered timeout to revert UI to correct watching status
--------------------
Firing timeout function to switch back
--------------------
Changing status bar to: Watching
--------------------
Switching UI state
--------------------
Changing status bar to: Watching
--------------------
Watching...
--------------------
Firing timeout function to switch back
--------------------
Changing status bar to: Watching
--------------------

Glad it works and thanks for the compliment!!
I'll push v5.2-rc.1 soon!


Does it possible to use GPUImageLookupFilter for realtime camera?

Is where any way to add images to realtime camera(like merge)? Can GPUImageLookupFilter be used for that?

I think you're looking for one of the blends, which can overlay or otherwise blend still images into a live camera feed.


regenerate_cargo_nix.sh: fix with channels

This workaround is required when using NIX_PATH pointing to a
directory, rather than individual named elements1.  The fix2 still
hasn't made it into a release.

Thank you, @alyssais! :)


Set cell preview mode when toggling edit mode.

This PR fixes #20093
We call toggleEditMode when first creating the text cell component, but we don't set the previewMode value when making the cell editable. This means the preview pane will always show when first creating the cell, even if the default is markdown only. Changing the cell view mode updates the preview mode correctly, which is why you only see this when first creating the cell.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 42.114%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
75.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
28185

Relevant Lines:
62550

💛  - Coveralls


Enable reporting for program plan and plan requirement

Critical Changes
Changes

In response to an issue that prevented users from creating reports for the Program Plan and Plan Requirement objects introduced with HEDA Release 1.57, we've enabled reporting for those objects.

If you've already enabled reporting for Program Plans and Plan Requirements in your org(s), you will experience no change.
For all new HEDA orgs, reporting for Program Plans and Plan Requirements is enabled by default.

Issues Closed
Fixes #617
New Metadata
Deleted Metadata
Testing Notes
Go to report and make sure we can create reports for program plan and plan requirement.
From the App Launcher search for "reports"
Click on the Report link that comes up in the Search results
Click on New Report (you will see the Choose Report Type box appear)
Enter "Plan" into the Search Report Types field
Make sure reports related to Program Plan and Plan Requirements show.

Testing is complete and all looks great. Thanks @jacebryan  and @juliesnow  for your doc recommendations- everything is good to go. Merging this PR.


Patch: Using inherits package instead of node inherits.

Webpack (and react-native) doesn't support node globals / global modules. This pull request removes the util global dependency and replaces it with inherits which implements inherits just as node does, but works without globals.
Note: I am sure about the version range of inherits to be used. Used "^2.0.4" for the moment.

This trims down a browserify build as well

@rvagg do you need me to do something before this can get merged?

@martinheidegger no, just time, there's multiple people in this repo that could object and block this so it's appropriate to leave space for any of them to pipe up.

d30f8f7b3 & v3.0.2

@martinheidegger no, just time, there's multiple people in this repo that could object and block this so it's appropriate to leave space for any of them to pipe up.

Got it, thank you for merging it!

Side question: Should I send a similar PR for the 2.x branch?

@martinheidegger do you use 2.x? probably not, I'd like it to be considered long-dead. See also #103 just now.

I don't use 2.x but I have seen dependencies looking like "through2": "2 || 3" which means that the version used by other dependencies may be chosen (other dependency using 2 instead of 3)

maybe leave it until someone squeaks? if you're packing with the newest webpack that throws up this problem then you're more likely to have v3 in your dependency chain. we can backport if needed but I'm not super keen on keeping ancient things alive and having more surface area for maintenance.


Update docs with  info about /watson/speechToText action

docs for new watson action /watson/speechToText

Close by #364


Javassist v3.19.0-GA 19 Incompatibility

Konichiwa Brett! Hope you are well.
Java 8u25
I've come across an issue using the just released Javassist v3.19.0-GA. It doesn't happen with v3.18.2-GA.
java.lang.VerifyError: Illegal type at constant pool entry 392 in class com.zaxxer.hikari.proxy.PreparedStatementJavassistProxy
Exception Details:
  Location:
    com/zaxxer/hikari/proxy/PreparedStatementJavassistProxy.getLargeUpdateCount()J @1: invokespecial
  Reason:
    Constant pool index 392 is invalid
  Bytecode:
    0x0000000: 2ab7 0188 ad4c 2a2b b600 1bbf
  Exception Handler Table:
    bci [0, 5] => handler: 5
  Stackmap Table:
    same_locals_1_stack_item_frame(@5,Object[#17])

	at com.zaxxer.hikari.proxy.ProxyFactory.getProxyPreparedStatement(ProxyFactory.java) ~[HikariCP-2.3.0-rc4.jar:na]
	at com.zaxxer.hikari.proxy.ConnectionProxy.prepareStatement(ConnectionProxy.java:263) ~[HikariCP-2.3.0-rc4.jar:na]
	at com.zaxxer.hikari.proxy.ConnectionJavassistProxy.prepareStatement(ConnectionJavassistProxy.java) ~[HikariCP-2.3.0-rc4.jar:na]
	at org.flywaydb.core.internal.dbsupport.JdbcTemplate.queryForString(JdbcTemplate.java:181) ~[flyway-core-3.1.jar:na]
	at org.flywaydb.core.internal.dbsupport.postgresql.PostgreSQLDbSupport.doGetCurrentSchema(PostgreSQLDbSupport.java:55) ~[flyway-core-3.1.jar:na]
	at org.flywaydb.core.internal.dbsupport.DbSupport.getCurrentSchema(DbSupport.java:75) ~[flyway-core-3.1.jar:na]
	at org.flywaydb.core.Flyway.execute(Flyway.java:1295) ~[flyway-core-3.1.jar:na]
	at org.flywaydb.core.Flyway.migrate(Flyway.java:919) ~[flyway-core-3.1.jar:na]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_25]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_25]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_25]
	at java.lang.reflect.Method.invoke(Method.java:483) ~[na:1.8.0_25]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeCustomInitMethod(AbstractAutowireCapableBeanFactory.java:1694) ~[spring-beans-4.1.4.RELEASE.jar:4.1.4.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1633) ~[spring-beans-4.1.4.RELEASE.jar:4.1.4.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1562) ~[spring-beans-4.1.4.RELEASE.jar:4.1.4.RELEASE]
	... 55 common frames omitted

This should be fixed in the 2.3.0-rc4 snapshot, can you check it?

Hi Brett,
Something strange is going on :-).
On my local development box, with Javassist 3.19.0-GA, and HikariCP RC4, my system boots fine.
When I deploy the same WAR into an EC2 instance running on Amazon, I get the exception as listed above. I can confirm that in the lib directory, both RC4 and 3.19.0-GA are present, and no rogue RC3 (or prior) or Javassist 3.18.2-GA (or prior) exists.
This is the result of java -version on the EC2 instance:
$ java -version
java version "1.8.0_25"
Java(TM) SE Runtime Environment (build 1.8.0_25-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.25-b02, mixed mode)
and here's what I have locally:
$ java -version
java version "1.8.0_25"
Java(TM) SE Runtime Environment (build 1.8.0_25-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.25-b02, mixed mode)
Any suggestions?
-=david=-

If you delete the 3.19.0-GA jar completely, do you get a similar error?  Maybe another library is embedding (shadowing) the Javassist classes...

Hi Brett,
It's not that I'm afraid. Firstly, I did a grep to determine if any of my 3rd party jars had repackaged javassist. Here are the results:
$ grep -ri "javassist" *.jar
Binary file hibernate-core-4.3.8.Final.jar matches
Binary file HikariCP-2.3.0-rc4.jar matches
Binary file javassist-3.19.0-GA.jar matches
Binary file orika-core-1.4.5.jar matches

Then, I deployed a version of the WAR containing 3.19.0-GA and confirmed the error above. I then removed javassist-3.19.0-GA from the lib directory and restarted the application server, and I got this
java.lang.ClassNotFoundException: javassist.NotFoundException
	at java.net.URLClassLoader$1.run(URLClassLoader.java:372) ~[na:1.8.0_25]
	at java.net.URLClassLoader$1.run(URLClassLoader.java:361) ~[na:1.8.0_25]
	at java.security.AccessController.doPrivileged(Native Method) [na:1.8.0_25]
	at java.net.URLClassLoader.findClass(URLClassLoader.java:360) ~[na:1.8.0_25]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[na:1.8.0_25]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[na:1.8.0_25]
	at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:450) ~[na:na]
	at org.eclipse.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:403) ~[na:na]
	... 82 common frames omitted
Wrapped by: java.lang.NoClassDefFoundError: javassist/NotFoundException
	at com.zaxxer.hikari.HikariConfig.<clinit>(HikariConfig.java:32) ~[HikariCP-2.3.0-rc4.jar:na]

Indicating that the javassist libraries have not been found at all.
-=david=-

Hi (again!)
I've managed to reproduce the issue locally on my machine.
If I add
-noverify
as a JVM parameter, I do not get the javassist error, otherwise, removing the -noverify, causes it to bomb out.
I don't get the problem using javassist 3.18.2-GA with no -noverify.
In summary:
Javassist 3.19.0-GA without -noverify causes HikariCP to bomb out.
Javassist 3.18.2-GA without -noverify does not cause HikariCP to bomb out.
Hope this helps!
-=david=-

I am curious if this is only occurring in the context of Spring?  For example, can you build HikariCP 2.3.0 branch locally using mvn package?  If so, the unit tests are successfully using Javassist 3.19.0-GA without the -noverify flag...

Hi
Cloned repo, mvn package worked.
Changed to javassist 3.19.0-GA in the pom:
[main] INFO com.zaxxer.hikari.HikariDataSource - HikariCP pool HikariPool-15 is starting.
[main] INFO HikariPool - HikariCP pool HikariPool-15 is shutting down.
Tests run: 10, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 8.68 sec <<< FAILURE! - in com.zaxxer.hikari.TestConnections
testBackfill(com.zaxxer.hikari.TestConnections)  Time elapsed: 0.26 sec  <<< ERROR!
java.lang.VerifyError: Illegal type at constant pool entry 392 in class com.zaxxer.hikari.proxy.PreparedStatementJavassistProxy
Exception Details:
  Location:
    com/zaxxer/hikari/proxy/PreparedStatementJavassistProxy.getLargeUpdateCount()J @5: invokespecial
  Reason:
    Constant pool index 392 is invalid
  Bytecode:
    0x0000000: b801 ad4c 2ab7 0188 2b11 00c6 0454 ad4d
    0x0000010: 2a2c b600 1b2b 1100 c704 54bf
  Exception Handler Table:
    bci [4, 15] => handler: 15
  Stackmap Table:
    full_frame(@15,{Object[#2],Object[#431]},{Object[#17]})

	at com.zaxxer.hikari.proxy.ProxyFactory.getProxyPreparedStatement(ProxyFactory.java)
	at com.zaxxer.hikari.proxy.ConnectionProxy.prepareStatement(ConnectionProxy.java:256)
	at com.zaxxer.hikari.proxy.ConnectionJavassistProxy.prepareStatement(ConnectionJavassistProxy.java)
	at com.zaxxer.hikari.TestConnections.testBackfill(TestConnections.java:258)

testCreate(com.zaxxer.hikari.TestConnections)  Time elapsed: 0.003 sec  <<< ERROR!
java.lang.VerifyError: Illegal type at constant pool entry 392 in class com.zaxxer.hikari.proxy.PreparedStatementJavassistProxy
Exception Details:
  Location:
    com/zaxxer/hikari/proxy/PreparedStatementJavassistProxy.getLargeUpdateCount()J @5: invokespecial
  Reason:
....
....

Hope this helps.
-=david=-

Hi,
On the 2.3.0 branch it works (I see in your 2.3.0 pom.xml that you are referencing javassist 3.19.0-GA).
I accidently built with the dev branch, which threw up lots of the errors (when I changed the pom javassist to 3.19.0-GA), as shown above.
Could it be that the 2.3.0-RC4 is wrong somehow?
-=david=-

Yes, that is it.  2.3.0-rc4 was built on Jan. 7, and the pull request with the fix for Javassist 3.19.0-GA was integrated a day later, on Jan. 8.  The fix will therefore be in the 2.3.0 release.

That's great to hear!
Are you still waiting on the other issue feedback before the 2.3.0 release (or perhaps thinking about a 2.3.0-rc5 :-) :-)) release :-)
-=david=-

I'm using IntelliJ IDEA 14, Spring-Boot 1.2.1, HikariCP 2.3.2, Javassist 3.19.0-GA  with the JRebel 6 plugin!
When I start the application with the JRepel plugin, the same exception is thrown as mentioned above, the only workaround is to add the option -noverify. Without the usage of JRebel everything runs perfect.
This only as a hint!
so long...

@UVST what version of JRebel 6?  They have fixed several Javassist issues since the 6.0.0 release:
https://zeroturnaround.com/software/jrebel/download/changelog/6-x/

@brettwooldridge
I'm using JRebel Legacy Agent 6.0.3<PHONE_NUMBER>47)

having the same issue here, using JRebel 6.1.2<PHONE_NUMBER>00)
<spring.core.version>4.1.6.RELEASE</spring.core.version>
<spring.security.core.version>4.0.1.RELEASE</spring.security.core.version>
<spring.data.jpa.version>1.8.0.RELEASE</spring.data.jpa.version>
<spring.test.version>4.0.6.RELEASE</spring.test.version>
<cglib.version>3.1</cglib.version>
<org.javassist.version>3.19.0-GA</org.javassist.version>
<aspectj.version>1.8.1</aspectj.version>
<joda.time.version>2.4</joda.time.version>

<mysql.connector.version>5.1.35</mysql.connector.version>
<HikariCP.version>2.3.7</HikariCP.version>

Caused by: java.lang.VerifyError: Illegal type at constant pool entry 172 in class com.zaxxer.hikari.proxy.StatementJavassistProxy
Exception Details:
Location:
com/zaxxer/hikari/proxy/StatementJavassistProxy.getLargeMaxRows()J @1: invokespecial
Reason:
Constant pool index 172 is invalid
Bytecode:
0x0000000: 2ab7 00ac ad4c 2a2b b600 17bf
Exception Handler Table:
bci [0, 5] => handler: 5
Stackmap Table:
same_locals_1_stack_item_frame(@5,Object[#15])
at com.zaxxer.hikari.proxy.ProxyFactory.getProxyStatement(ProxyFactory.java)
at com.zaxxer.hikari.proxy.ConnectionProxy.createStatement(ConnectionProxy.java:226)

Version 2.3.7 still has the bug. I have to do this to work:
<!-- Connection Pool -->
<dependency>
	<groupId>com.zaxxer</groupId>
	<artifactId>HikariCP</artifactId>
	<version>2.3.7</version>
	<exclusions>
		<!-- Bug do HikariCP -->
		<exclusion>
			<groupId>org.javassist</groupId>
			<artifactId>javassist</artifactId>
		</exclusion>
	</exclusions>
</dependency>

<dependency>
	<groupId>org.javassist</groupId>
	<artifactId>javassist</artifactId>
	<version>3.18.2-GA</version>
</dependency>

Great projet BTW. Cheers from Brasil.

This should be fixed in JRebel 6.2.1 release (see here, search for HikariCP)

Additionally, HikariCP 2.4.0 no longer has a runtime dependency on javassist.


Not getting valid data.

Hi,
first, I am not sure if this is the right place to post this. But I'll give it a try anyway.
I have been using this sensor with this library for quite some time and all of the sudden we started getting really weird data back from our device. I uploaded a picture of the serial data we are receiving from the example sketch.
Pressure: -20053014.00 mbar
Temperature: -389.20 deg C
Depth: -198730.95 m
Altitude: nan m above mean sea level
If we dunk it under water, heat it up or cool it down, this is the numbers we get.
Any Idea of what went wrong? and way I can try and reset the device?
Thanks!
Ryan

Hi Ryan, these look roughly like the numbers you'd get if the device is not responding at all. It sounds like it may be damaged in some way. Do you get the same results if the device is not plugged in?

So yes, that is in fact the data i get once I let it initialize, and then unplug it.
I guess it's a blown sensor.. likely my fault.
Thanks Rusty!


Please don't call it the "grad lemma".

Generally there are two ways that theorems and lemmas are named in mathematics: descriptively (giving some information about what the theorem says, e.g. "the intermediate value theorem") and attributively (giving credit to whoever proved it, e.g. "Cauchy's theorem").  Whatever your feelings about the relative merits of the two, the name "grad lemma" achieves neither: it conveys no information about what the lemma says, nor does it give any credit to the people it refers to,  instead depersonalizing them as "some nameless graduate students".  Moreover it is even factually incorrect, since some of the people in question were actually postdocs at the time.
The HoTT/Coq library calls the analogous theorem adjointify, since it makes a non-adjoint equivalence into a (half-)adjoint one.  That may not be so appropriate if your notion of "coherent equivalence" is not the half-adjoint one, but maybe coherentify would work.  The HoTT/Agda library calls it is-eq, with a comment that this "is a very, very bad name."  But even is-eq is better than "grad lemma".

I think our use of this name dates back to Vladimir's Foundations code where it is called gradth. It is still called this in the Foundations part of UniMath:
https://github.com/UniMath/UniMath/blob/master/UniMath/Foundations/PartA.v#L1759
I agree that "grad lemma" is a bad name and I would be happy to change it to something more descriptive.  Maybe isoToEquiv could be a lot better?

Yes, I know it comes from UniMath.  I haven't quite got up my courage to open an issue there yet, but after you change it here then maybe I will.  I think isoToEquiv would be a great name!

Indeed it was from Vladimir's library and there's no reason to keep the same name given Mike's objections
Sent from my iPhone

On 11 Aug 2017, at 18:37, Anders Mörtberg<EMAIL_ADDRESS>wrote:
I think our use of this name dates back to Vladimir's Foundations code where it is called gradth. It is still called this in the Foundations part of UniMath:
https://github.com/UniMath/UniMath/blob/master/UniMath/Foundations/PartA.v#L1759
I agree that "grad lemma" is a bad name and I would be happy to change it to something more descriptive. Maybe isoToEquiv could be a lot better?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@coquand : Do you also like the name isoToEquiv? If so I'll change it now.

I have renamed this now and there should be no mention of grad lemma anywhere on the master branch  (grepping for grad or Grad doesn't return anything at least). If I still managed to miss something or if some file doesn't load please let me know and I'll fix it. I didn't bother changing this on the many branches, but if we ever decide to merge for example the hcomptrans branch I'll make sure to change this there as well.
@mikeshulman : Thanks for getting us to change this to a more descriptive name. I'll close this issue now.

Thank you!


Airglow/atmospheric scattering at night

Currently, the sky after sunset becomes completely dark. However, atmosphere is never completely dark
and during night, when rayleigh scattering stops dominating, some phenomena appear like airglow or moonlight scattering which gives tint of blue or green, of course very subtle when compared to rayleigh scattering during day.
Is it possible to conduct some research and add such experimental feature which would enrich the project and wouldn't hurt real time performance?

Interesting, I wouldn't say it's completely dark. This is my attempt to use precomputed_atmospheric_scattering (ported to DirectX/HLSL):

(it's better open it in fullscreen)
The sun is opposite to the zenith point now. You can see that even at the top it has some bluish tint. However I wonder if presence of stars would affect significantly the sky color.

Do you use demo code? I increased exposure to 1000 and gamma to 2.5, but it doesn't look lik this.

Well, it's not exactly the demo code that I'm using, I had to change the CPU code so it works with DirectX, the GPU code is adjusted to be compatible with HLSL. Except that, it's the same implementation.
Did you try to play with AtmosphereParameters? I guess increasing top_radius might affect airglow in the night.

This parameter didn't affect night for me. I'd rather leave it as it is. I played with mie parameters to get some hazy summer skies.


Compile/Instal Charabia on openBSD

I am on openBSD running on Raspberry Pi 4. I am unable to install meilisearch due to cargo not able to find charabia. So i decided to
compile from source.
I downloaded the source from github and did "cargo run' in the charabia source code. I get the error:
error: failed to parse manifest at `/home/kabira/LibOpenSource/charabia/Cargo.toml`

Caused by:
  namespaced features with the `dep:` prefix are only allowed on the nightly channel and requires the `-Z namespaced-features` flag on the command-line

Any workaround suggesting would be great.

Look like you need to update your rust version :unamused:

Hello @sandeep-gh!
Have you fixed your issue?

Hello,
I am still figuring out how o upgrade to latest rust on openBSD. It is not
straightforward at all.
I will give it another going sometime next week. Will let know.
Thanks.
-S
On Wed, Sep 7, 2022 at 5:31 PM Clémentine Urquizar - curqui <
@.***> wrote:

Hello @sandeep-gh https://github.com/sandeep-gh!
Have you fixed your issue?
—
Reply to this email directly, view it on GitHub
https://github.com/meilisearch/charabia/issues/118#issuecomment-1239297091,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF5DLBKG45VGIRVLR4EECSDV5B7YVANCNFSM6AAAAAAQCEETPY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ok, I close this issue since it does not seem to be something we can handle on our side
If this is something we can fix, please let us know, I will re-open the issue!


Blog describing Kubernetes suite

Clarifies a major/reoccuring question we get about why
certain tests are skipped, how/when certain tests are needed,
and how to run certain tests.
Fixes #1306
Signed-off-by: John Schnake<EMAIL_ADDRESS>No rush on this one; going to wait a while so the Windows E2E one gets merged and settles. Maybe a week or two and this one can go in.

Still need to integrate some of these changes then I'll merge early next week. Got sidetracked by some other PRs

Made updates based on suggestions; merging.


windows2012R2 stack is missing

I am trying to push the application using pushShoppingCartService.cmd win7-x64 netcoreapp1.1, but I get the following error: 'Stack windows2012R2 not found'. How do I add this stack?

@Spiti : For PCF -> https://network.pivotal.io/products/runtime-for-windows


error on start

Im very interested in this, have you seen
./~/socket.io-client/socket.io.js
Critical dependencies:
1:475-482 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ ./~/socket.io-client/socket.io.js 1:475-482

Yes it's a common thing with WebPack and they actually never found a real fix. You can refer to this Webpack build issues with 1.4.1 was posted and is still open to date.
Nevertheless, this isn't stopping the App from running, it's just a warning message. Everything works as it should.

actually I cant get it to load but it's the previous error, do you know a work around for this?
webpack:///./~/bootstrap/dist/css/bootstrap.css?:13

Hmm that's strange, this is just a warning on my side and didn't stop me from running the application.
However you are showing an error with bootstrap.css, did you check if Bootstrap was installed properly?  I would probably have to retry installing, from scratch, this project (and update Aurelia versions). But considering that 2 other people clicked on the star :star: on top. I would assume that they got it working on their side.
Nonetheless, I'm new to Aurelia (didn't do any real project, except this one that I shared) and I'm trying to switch to Aurelia-CLI, so I might actually redo this template with CLI instead. Or simply add a client-cli.
If you find the error, please feel free to post a PR.

thank you fro the response, it's more than just bootstrap, if you comment that out it goes to the next item I believe is fontawesome, so I will try to get it to work, I dont want to try with CLI because of the webpack vs jspm I want to stay with webpack ;)

However if you find some issues in my code, please make a PR. Thank you

I looked at it in the weekend and I actually got the same errors as you had. Not sure why I was able to run it in the past, but anyhow I modified some code and also updated to latest Aurelia release and it's all good now.
So please give it another try and let me know.


[FLINK-25800][docs] Update wrong links in the datastream/execution_mode.md page.

What is the purpose of the change
Update wrong links in the datastream/execution_mode.md page.
Brief change log
Update wrong links in the datastream/execution_mode.md page.
Verifying this change
Update wrong links in the datastream/execution_mode.md page.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

Hi, @MartijnVisser Would you mind helping me to check it ? Thanks a lot.

Hi, @MartijnVisser Could you help me to check it ? Thanks a lot.

@RocMarshal Thanks again for the PR. Can you also create backports to the release-1.15 and release-1.14 branches?

@RocMarshal Thanks again for the PR. Can you also create backports to the release-1.15 and release-1.14 branches?

@MartijnVisser Thanks for the operation. I'm glad to do it and I'll create it asap.

@MartijnVisser I created BP-1.14 & BP-1.15.
PTAL. Thank you very much.


Nothing happens when running /geyser education new

no output in chat, the console just says username issued command

Don't put a slash on the front. So it should just be geyser new

not having a slash just sends a chat message, I'm running your geyser fork and the extension is loaded

not related to this issue but idk if I should open a new one, when I try to connect on education it can't find the server for some reason, works on bedrock and java

actually education should be udp as well, and you'll need to run it on a different port than bedrock. I'll close this if its all solved though.


[BUG] Can't record a still snapshot while libcamera-vid is recording

The legacy raspivid/picamera stack had a special mode to extract frames without disrupting video recording:
https://picamera.readthedocs.io/en/release-1.13/recipes2.html#capturing-images-whilst-recording
With libcamera, we can have a preview in a GUI window, but I couldn't find options to extract still images from the video stream.
Attempting to use libcamera-still during video recording naturally creates a conflict :
pi@raspberrypi:~ $ libcamera-still --nopreview -o screenshotlive.jpg
[0:38:46.902978936] [1491]  INFO Camera camera_manager.cpp:293 libcamera v0.0.0+3866-0c55e522
[0:38:47.817337184] [1492]  INFO RPI raspberrypi.cpp:1374 Registered camera /base/soc/i2c0mux/i2c@1/ov5647@36 to Unicam device /dev/media3 and ISP device /dev/media0
[0:38:47.838401006] [1491]  INFO Camera camera.cpp:848 Pipeline handler in use by another process
[0:38:47.839941993] [1492] ERROR V4L2 v4l2_videodevice.cpp:1234 /dev/video0[12:cap]: Unable to request 0 buffers: Device or resource busy
[0:38:47.840602987] [1492] ERROR V4L2 v4l2_videodevice.cpp:1234 /dev/video13[13:out]: Unable to request 0 buffers: Device or resource busy

Is there any workaround, of future plan, for libcamera-apps to allow this ? Without resorting to a custom handling of the h264 stream ?
Thanks a lot !

This is not something we intend to do with libcamera-apps unfortunately.
However, @davidplowman might be able to tell you if this might be feasible through picamera2.

Thanks for the feedback,
OK then for now I'll pause video, and I'll implement a picamera2-based handler later to make it smoothly    :)


Console bindings incomplete

console has a lot more functions than the currently bound ones, see https://developer.mozilla.org/en-US/docs/Web/API/console.

I'm on this

Thanks a lot, @glennsl! 👍


Specify alignment for DrawIndexedInstancedIndirect

This updates the description of AlignedByteOffsetForArgs to specify the required alignment (which is DWORD alignment according to the spec)

@TheRealMJP : Thanks for your contribution! The author(s) have been notified to review your proposed change.

It's indicating that the CLA isn't signed. Once that's done, it'll let me merge the PR. Thank you!

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Just signed the CLA so it should be all good now!


UnicodeEncodeError in ntlm3\des.py

Hi,
I have successful been using pyexchange for retrieving calendar items from my company server. The last successful test was several months ago. But yesterday I got this error:
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
I am using Python 2.7.12 |Anaconda 2.2.0 (32-bit)
I enter all relevant parameters as unicode.

It is trying to return a unicode character as an ascii character. You will need to do something along the lines of unicode-variable.encode('utf8') in order to get the data.


New Window replaces current window

open a folder
select "File > New Window"
:bug: the current window changes

fixed with 6d5feae57959287fb116467f4eb6c7079571b466

rebuild triggered


remove setting

how to remove this vim setting

follow https://github.com/amix/vimrc#how-to-uninstall

按照https://github.com/amix/vimrc#how-to-uninstall

thanks. I will read it


Updating Project information and ignored files

Indentation appears broken ... spaces vs tabs?
Also, I'd rather not list the "issues" item. I think it would encourage more people coming here to ask generic questions ...

Crap. Setup a new project in PHPStorm for CI last night and forgot to setup the standards. Will get that fixed up shortly. And remove the "issues" item.
Looking at the Travis build files is strange, too. Have they updated their PHP 5.3.3 to not have SSL enabled by default? That's what the errors seem to imply. Or maybe packagist was just having issues last night?

Yea, Travis is having some issues these days ...


Drop passthru GraphQL API

Right now, all GraphQL API calls for mutations are passed through /api/graphql before they are sent to GitHub. This is necessary because of https://github.com/github/feedback/discussions/3622. Once that is resolved, we can safely drop the passthru API.

Somewhat related:
Note that querying for discussions data will still need to be proxied through /api/discussions because GitHub's GraphQL API requires authentication for all requests. We're using a trick by authenticating as the app in order to get a token that can be used to fetch discussions data without signing in.
However, this means that GraphQL query string should be composed on the server. If we let the client compose the query and just use the passthru API (and supplying the token if the request doesn't have one), users can abuse this to run queries as the application.
We can remove /api/discussions once GitHub allows unauthenticated requests for their GraphQL API.

https://github.com/github/feedback/discussions/3622
We no longer have to include the GraphQL-Features header, so this should now be possible to fix.


Hide UI buttons based on permissions

Workspace template builder
Create workspace
Create Workflow template
Any menu items in context menus (check on menu open)

@rushtehrani checking the permissions required here. Do these look right?
Workspace Template Builder

list workflowtemplates

Create Workspace

create workspaces

Create Workflow Template

create workflowtemplates

Workflow Execution Context Menu

rerun - create workflows
terminate - update workflows

Workspace Context Menu

resume - update workspaces
terminate - delete workspaces
pause - update workspaces

@Vafilor yes, those look right.

@Vafilor was this addressed?

@rushtehrani No, not all of these are in the code yet.


Duplicate log entries

I seem to be getting duplicate log entries in seq. I'm using the exact demo code in the serilogj and running seq 3.4.20.

I just tested this. Compiled and executed JavaConsole in InteliJ.
Waited a bit, checked my (fresh installed) seq 3.4.20 and there's 2 'test' lines, but the JavaConsole application also log's 'test' twice (but with different values for 'blaat').
The log file also has 'test' twice but again, the JavaConsole logs 'test' twice.
So I can't really reproduce the issue.
I do remember an old bug that caused it to send lines twice sometimes. But that was solved a while ago. We've been using this library in our production environment for a while now and it seems rather stable.

I resolved this issue it was related to initializing the logger before springboot initiallized..

this for your assistance..


Add HTTP::Response#connection

The Down gem provides the ability to wrap anything that streams chunks into an IO object. I want to add support for HTTP.rb to Down so that you can do the following:
response = HTTP.any.request.options.get("http://example.com")
remote_file = Down.open(response)
remote_file # IO object which downloads only how much it needs

For this I need to be able to access the connection through the response object, so that I can close the connection if either the downloading finishes or user calls remote_file.close.

I believe connection/client thingy might be changed in relatively near future.

@zanker @tarcieri I think you guys know more of this ;))

@ixti In which way might it be changed? I think it would still make sense to have it available through the response object, because at the moment I have to do
response.body.instance_variable_get("@client").close

to close the connection

Ping 😃. Since you said it might be changed soon, that's all the more reason to create a public method for accessing the connection.

Looks good to me 👍

Thanks!

@janko-m I'm very sorry. Got lots of things moving around this time of my life (which seems like happen every August to me). I'm totally fine with the PR (I should have noted that more explicitly). There were ideas of moving pretty much of sockets work things into separate gem.
There definitely will be changes to API of HTTP methods once I'll find time to work on that (block form that will be closing underlying connection auto-matically).

In any case. Thanks for your PR! :+1:

Don't want to be nagging, but it would be awesome to get a new release with HTTP::Response#connection and HTTP::Response#content_length, since I would like to start adding support for HTTP.rb to Down 😃

Released as 2.1.0.

@tarcieri Thank you! ❤


Need to update README for Testing

What would you like to be added:
The testing README located here needs to be updated for the most recent changes to the functional testing framework.
Reference #45 for more context
Why is this needed:
The existing info is slightly outdated even the changes to functional-tests.yaml

Seems like this should be on me

Assigned


sql: Add column family support for secondary indexes

PR: https://github.com/cockroachdb/cockroach/pull/42073
From release notes:

CockroachDB now allows stored columns in secondary indexes to respect the column family table definitions that they are based on. [#42073][#42073] {% comment %}doc{% endcomment %}

Fixed by #6556.


Use region searches instead of HTM IDs for DP02_04b

The latest version of client/server Butler now supports arbitrary region searches, instead of requiring users to manually figure out the HTM pixelization IDs.  The examples of spatial searches in DP02_04b have been updated to use the POINT() syntax.

This one uses new functionality not available until weekly 33, and the new functionality is client/server only.  (DirectButler will get this in a couple months.)
So this should NOT be merged until both:

The recommended image gets bumped to weekly 33 or newer.
The dp02 alias changes to point to client/server.

You can also now write things like
region = lsst.sphgeom.Circle(...)
datasetRefs = registry.queryDatasets("calexp",
                                     where="visit.region OVERLAPS my_region",
                                     my_region: region})

using any of the region types in lsst.sphgeom..

Jeff incorporated this change in #211