Invoke get_shape() on sparse_tensor leads to feeding error

If I invoke get_shape method on sparse_tensor, the shape tensor will be added into the _unfeedable_tensors set of the current graph. Then when I feed the sparse tensor, an error occurs.
The codes below show this error
import tensorflow as tf
import numpy as np

shape = np.array([7, 9, 2], dtype=np.int64)
indices = np.array([[3, 2, 0], [4, 5, 1]], dtype=np.int64)
values = np.array([1.0, 2.0], dtype=np.float32)
x = tf.sparse_placeholder(tf.float32, shape=shape)

with tf.Session() as sess:
    x.get_shape() # <-- Troublemaker
    # This line leads to the exception:
    # 	   Tensor Tensor("Const:0", shape=(3,), dtype=int64) may not be fed.
    # The side effection of this line is that
    # it adds the 'shape' tensor into Graph._unfeedable_tensors,

    print(sess.run(x, feed_dict={
    	x: tf.SparseTensorValue(indices, values, shape)}))

The stacktrace
ValueError                                Traceback (most recent call last)
<ipython-input-1-baac6f49a954> in <module>()
     10     x.get_shape()
     11     print(sess.run(x, feed_dict={
---> 12     	x: tf.SparseTensorValue(indices, values, shape)}))

/Users/liqimai/anaconda3/lib/python3.5/site-packages/tensorflow/python/client/session.py in run(self, fetches, feed_dict, options, run_metadata)
    765     try:
    766       result = self._run(None, fetches, feed_dict, options_ptr,
--> 767                          run_metadata_ptr)
    768       if run_metadata:
    769         proto_data = tf_session.TF_GetBuffer(run_metadata_ptr)

/Users/liqimai/anaconda3/lib/python3.5/site-packages/tensorflow/python/client/session.py in _run(self, handle, fetches, feed_dict, options, run_metadata)
    944                 % (np_val.shape, subfeed_t.name, str(subfeed_t.get_shape())))
    945           if not self.graph.is_feedable(subfeed_t):
--> 946             raise ValueError('Tensor %s may not be fed.' % subfeed_t)
    947           subfeed_name = compat.as_bytes(subfeed_t.name)
    948           feed_dict_string[subfeed_name] = np_val

ValueError: Tensor Tensor("Const:0", shape=(3,), dtype=int64) may not be fed.

System information
I do not think this bug is related to my environment.
== cat /etc/issue ===============================================
Darwin liqimaideMacBook-Pro.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64
Mac OS X 10.12.6
== are we in docker =============================================
No
== compiler =====================================================
Apple LLVM version 9.0.0 (clang-900.0.37)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
== uname -a =====================================================
Darwin MacBook-Pro.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64
== check pips ===================================================
numpy (1.11.3)
protobuf (3.2.0)
tensorflow (1.0.0)
== check for virtualenv =========================================
False
== tensorflow import ============================================
tf.VERSION = 1.0.0
tf.GIT_VERSION = v1.0.0-rc2-15-g47bba63-dirty
tf.COMPILER_VERSION = v1.0.0-rc2-15-g47bba63-dirty
Sanity check: array([1], dtype=int32)
== env ==========================================================
LD_LIBRARY_PATH is unset
DYLD_LIBRARY_PATH is unset
== nvidia-smi ===================================================
tf_env_collect.sh: line 105: nvidia-smi: command not found
== cuda libs  ===================================================

The issue is that SparseTensor.get_shape calls tensor_util.constant_value_as_shape, which calls tensor_util.constant_value, which calls Graph.prevent_feeding.
@ebrevdo, what do you think the best way of solving this is? Perhaps in the SparseTensor constructor, we can set a new field with the TensorShape.

I'm wary of changing the SparseTensor api.  what if you create 3 placeholders and create a SparseTensor from them.  does this work?

The API would not change, except that calling get_shape would not prevent feeding the tf.sparse_placeholder. I do not think that making that change would affect backwards compatibility.
3 placeholders would work (that's what tf.sparse_placeholder internally does) but ideally calling get_shape on tf.sparse_placeholder would not cause it to be unfeedable.

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

OK great; closing.

I have the same problem too.
But it seems that no one can solve this.
Any ideas?

BY the way. tensorflow is really full of bugs itself, which is nothing comparable to pytorch.

@xChenSky
According to my experience, do NOT specify the shape when declare tf.sparse_placeholder.
x = tf.sparse_placeholder(tf.float32) # work
x = tf.sparse_placeholder(tf.float32, shape=shape) # not work


fix(users): Incorrect UsersService injection

Updated edit profile controller to use the users service correctly. Edit profile now working. Closes #1282.

Coverage remained the same at 70.615% when pulling 48db454cc25e7e20340ff60060a9aaa48963ec32 on t-jennings:fix-users-edit-profile-controller into 8da372519a4f7894966835904ab7bd28368922ea on meanjs:master.

I can confirm that this is indeed a bug in latest master, thanks @t-jennings

LGTM. Other than the commit message. @t-jennings Could you change it to something like fix(users): Incorrect UsersService injection?
Also, it doesn't look like we have coverage here for the Edit Profile route. Would it be possible to add something to this PR? I'm fine with merging this in as is, since it's a small change & fixes a bug. However, we should start building out our test coverage in these area's.

@mleanos it would be nice to get a test for that to increase our coverage.

Updated title to follow convention. I won't be able to provide a test unfortunately, not familiar enough with testing yet.
This is my first PR so it would be awesome if this got merged.

@t-jennings That's understandable about the test. I think it's ok for this to be merged without an accommodating test. @ilanbiala I'm also not opposed to submitting a test myself to this branch. @t-jennings If I submitted a pull request to this branch, would you be able to merge it in?
Also, we're looking for the actual git commit message to be updated. Not the title of the PR.

Coverage remained the same at 70.615% when pulling 69108aaa4b35351817cfd7445a775082b8280122 on t-jennings:fix-users-edit-profile-controller into 8da372519a4f7894966835904ab7bd28368922ea on meanjs:master.

Added commit with correct format for commit message. @mleanos , if you want to submit a PR to add testing I can merge it in.

@mleanos adding a test to this via PR sounds good.

@ilanbiala @t-jennings I've submitted a PR to this PR's branch.
Another thing I noticed about the Edit Profile Controller, is that it's injecting the $location service, but not using it. We can probably get rid of it. @t-jennings Could you remove it?

Any movement on this?

@ilanbiala @t-jennings We can merge this in as is, and I'll add my test in a separate PR. This is a pretty simple PR, and fixes a bug. So it might be best to just get it merged. WDYT?
See https://github.com/t-jennings/mean/pull/1 for the suggested test coverage.

SGTM.


Add ToCBOR for BlockNo

Mostly to ensure (and make clear) that the ToCBOR instance does the same as the Serialise instance.


Minion Driver Update

Changed the test file to better see if the Ignition Contactor task works
Changed the reading pin function to apply to inputs and outputs
Updated some code due to the function change

Messed up by not pulling master and messed up the commit tree. Will try again in another pull request


Crash On Dedicated Server

Server crashes during startup.
Mod version: <IP_ADDRESS>
Forge version: 1.11-<IP_ADDRESS>9
Crash report: hastebin/ukikimukum

Sever crashes during startup.
Mod version <IP_ADDRESS>
Forge version 1.11.2-<IP_ADDRESS>0 (newest)
Crash report: https://gist.github.com/Endmateria/ca8234d319f1a090640491488f828d58#file-crash-2017-02-14_20-51-16-server-txt

Same thing happens to me:
http://pastebin.com/dD2RgYrM
Mod Version: <IP_ADDRESS>
Forge Version: <IP_ADDRESS>9
Java Version: 1.8.0_121

I'll look into it.

Try this: https://www.dropbox.com/s/bws809i4noqo3eh/EnderCompass-1.11-<IP_ADDRESS>-SNAPSHOT.jar?dl=0

I'm not running a server anymore, just singleplayer... but I was able to resolve this issue by only loading the mod client side.  When loaded both server and client side, that's when I'd get the crash.  So if that patch works for you ThomasAunvik, feel free to close the issue, since I'm not gonna set up my whole server again just to test it.

<IP_ADDRESS> Does not crash the server. Thank you!


Custom authentication

Important notices
Our forum is located at https://forum.opnsense.org , please consider joining discussions there in stead of using GitHub for these matters.
Before you ask a new question, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

I am try to understand the feasibility of using a custom authentication mechanism for Captive Portal.
My goal is to :

Host my own page for a Captive Portal.
Authenticate users through our own authentication mechanism (LDAP and RADIUS are a no-go). I just want OpnSense Captive portal to make an HTTPS request to verify authentication status for a particular MAC address. I am also open to any other interaction mechanism.
Use external backend services (hosted on different, accessible parts of the network) to perform authentication.

I would like to know:

Is there a fundamental reason this would be impossible with OpnSense ?
Is it just a matter of modifying the Captive Portal Page template to host my page?
Is this something that should be implemented through a plugin ?
Thank you !

You can build  pluggable authentication method easily:
https://docs.opnsense.org/development/components/authentication.html
Cheers,
Franco

Thank you for the quick response. So in the Captive Portal configuration, this would appear as another authentication method . Correct ?

When configured… same as any other type

Thank you !

One follow up question as I am new to development in OpnSense : I see the existing authentication classes are under src/opnsense/mvc/app/library/OPNsense/Auth/Radius.php in Core. Is it necessary to build a new image with the addition of the new Authentication class  or can the authentication class be added as a plugin ?

Plugin makes more sense, but for custom deployments just dropping the file in the target system is more than enough.


FIRConfiguration setLoggerLevel() has no impact on console logging

[REQUIRED] Step 2: Describe your environment

Xcode version: 10.3
Firebase SDK version: 6.5.0
Firebase Component: Core
Component version: 6.5.0

[REQUIRED] Step 3: Describe the problem
iOS SDK: FirebaseConfiguration.shared.setLoggerLevel() has no impact when using FirebaseApp.configure(options:). .min and .max result in the exact same amount of logging in the console.
Steps to reproduce:

In AppDelegate didFinishLaunchingWithOptions, set the logger level to .min then configure FirebaseApp via configure(options:).
Run the app attached to the debugger.

Expected
Console logging from the Firebase SDK should be at minimum level.
Actual
Console logging is unaffected. Logging looks identical to .max.
Relevant Code:
FirebaseConfiguration.shared.setLoggerLevel(.min)
FirebaseApp.configure(options: fileOptions)

Thanks for the report, we'll look into this shortly.

Related is https://stackoverflow.com/a/44438819/556617

Tried to reproduce this with Xcode 11.2.1 running iOS 13, latest version of FirebaseCore (at master) and was not able to reproduce - .min and .max have vastly different logging counts with .min working as expected.
If this is still an issue you see, please let us know how to reproduce it and I'll re-investigate!

See #5124


KOGITO-4870 It's not possible to execute processes by using the quarkus

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Pull Request
Please add comment: Jenkins retest this

Quarkus LTS checks
Please add comment: Jenkins run LTS

Native checks
Please add comment: Jenkins run native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

Hi @tiagodolphine , I'm not familiar with this code, so I can't say too much.
But this is more or lees what I've could see after applying your changes locally:

I start the app with mvn clean compile quarkus:dev
Now the processes works
I do several invocations and the "Hot replace" is not executed. That's fine.
I do a small change in a java file.
I do a new invocation via rest on my processes, and the "Hot replace" is executed. That's fine, since a java file was modified.
I do a new invocation via rest and I can see again in the log "Hot replace total time: 2.566s", but there are no more modifications
I do a new invocation, and the same "Hot replace total time: 2.566s "
a new invocation, same thing "Hot replace total time: 2.566s"

It looks like after step 4) the hot replace is being executed all the time, not good and not necessary since there are no more modifications since step 4.

Updated the PR with the fix we discussed in the call.

jenkins please test 🌈

The Linux check has failed. Please check the logs.

script returned exit code 143

jenkins please retest this 🙏

Hi @tiagodolphine , I think a test will be more than great to add here otherwise it'll be difficult to catch up this sort of potential error next time. Specially considering "tricks" commented by @evacchi to make the hot reload work.

Hi @tiagodolphine , I think a test will be more than great to add here otherwise it'll be difficult to catch up this sort of potential error next time. Specially considering "tricks" commented by @evacchi to make the hot reload work.

yeah, we need a test for this scenario, but I don't think we have an easy/quick way to do it now, I'll open a JIRA to do it, in this way we can merge this PR just a hotfix, and provide more tests afterward.

Hey @tiagodolphine, I'm testing this PR locally with Task Console and found that the JSON schemas for task-forms are not generated, not sure if that's the same issue.

R locally with Task Console and found that the JSON schemas for task-forms are not generated, not sure if that's the same issue.

I should be working unless it is a different issue, are you running in dev mode or using the generated jar?

The Linux check has failed. Please check the logs.

jenkins please retest this

@MarianMacik can you take a quick look at this, it's a hotfix for the hot reload for processes.

jenkins retest this

The Linux check has failed. Please check the logs.

jenkins retest this

The Linux check has failed. Please check the logs.

jenkins retest this

The Linux check has failed. Please check the logs.

jenkins retest this

jenkins please retest this

The Linux check has failed. Please check the logs.

jenkins retest this

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

impossible to get a green build =/

@tiagodolphine I know that feeling...

jenkins retest this

The Linux check has failed. Please check the logs.

jenkins retest this

The Linux check has failed. Please check the logs.

jenkins please retest this

jenkins retest this please

The Linux check has failed. Please check the logs.

The Linux check has failed. Please check the logs.

jenkins please retest this

The Linux check is successful.


Fix glog may buffer the stdout's output

fix https://github.com/apache/kvrocks/issues/1883

I believe this change will have a significant impact as it removes the global stdout buffer. (e.g. logging behavior, performance without buffer..)
I suggest that we DO NOT pick this patch to version 2.8.0 until a thorough investigation is conducted.
cc @git-hulk @caipengbo

@PragmaTwice Thanks for raising this potential issue, I have linked this in the release proposal.

https://github.com/google/glog/issues/943
FLAGS_logtostdout does not seem to follow FLAGS_logbuflevel
是这个问题导致的，如果去修glog应该更好


Add mount point to cgroup root when initializing cgroup paths for cpu.rt_runtime

PR https://github.com/docker/docker/pull/23430 introduced a couple more
flags including --cpu-rt-runtime to the docker daemon. It appears
recent changes or merge issues may have broken this. It currently does
not take the cgroup mount point into account when determining the cgroup
files to write values to. This breaks docker setting its own
cpu.rt_runtime for the daemon. This also means containers aren't able
to set theirs.
Also, the cgroups.FindCgroupMountpointAndRoot returns back a mount point
that includes the cgroup of the currently running container when docker
is run inside a docker container. this breaks the --cpu-rt-runtime
flag when running docker in docker. A fix has been placed here, but
potentially could be pulled up into libcontainer if this is a better
place for it.

- What I did
Fixed an issue where the docker daemon is not properly setting its cpu.rt_runtime due to using the wrong path.
- How I did it
cgroups.FindCgroupMountpointAndRoot also returns the cgroup mount point, this needs to be prepended to the cgroup path.
- How to verify it
See https://github.com/docker/docker/pull/23430
- Description for the changelog

Fixed an issue where docker daemon wasn't initializing its cpu.rt_runtime_us due to invalid path.
- A picture of a cute animal (not mandatory but encouraged)

Is this fixing the same issue as https://github.com/docker/docker/pull/32162?


Improve h3 example documentation

🚀 Pull Request
closes #842

Sometimes the codecov fails to update it's status, which I believe is an issue on the codecov server side ... I tend to close the PR then reopen it to re-run the CI.
I'll do that now ...

The other option might be to re-run the CI py312 tests job, as it's that that post the code coverage to the codecov service ... might try that next time to see if it works instead of closing/opening the PR 🤔


[BUG] LOG viewer crashed

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I checked the downloaded LOG file, then I didn't reload it to my LOG, I just used the program to change active mods, etc. I deleted the file with this LOG file and now when I try to check, nothing wants to load in this window, I can't click any button in this browser window, after a short while the window turns completely white. I remember that the log was about 50MB and there was also a problem with viewing it, scrolling was terribly laggy.
Expected Behavior
No response
Steps To Reproduce
No response
Environment
- Mod Assistant Version: 2.9.0
- OS: Win 10 22H2
- Virtualized: No

Anything else?
No response

Huh.  gross.  So, my notes below, but included cause you might be interested.
1.) The log is read sync right now - this was great for testing, but super bad for production.  Needs fixed.
2.) A 50MB log is bad, as you know - but it shouldn't crash. There are two ok-ish options here, both with their downsides:

Truncate the log file and only return the last couple MB or so.  The downside is you only have part of the log in the window then - fine if your running game is spamming, but bad for loading a log from discord.
Turn off the color regexs when it is massive, this should speed things greatly.

I'm leaning towards a two-fold solution -

Scenario A : you load a single massive log, it displays, but without color.
Scenario B : you load the game and it gets massive.  Once it hits 10MB or so, it starts only sending the end of the log to the file.  I think I can do this by throwing a "is updating" flag in the bit that watches the open log file for changes.

Thoughts?

Currently I can't do anything to the window, nor change filters or anything else, only minimize the window and close it. As for the solution, I noticed that usually the end of the file is repeated sections with "LUA call stack", I think it would be best to hide it somehow (show only one section and collapse the rest with the possibility of expanding), or cut/stop loading the file after several such entries.

Aye.  the issue is, the render portion takes forever to do it's thing - it's actually reading and sending the file to the window very, very quickly - then the bit to parse through it is super slow.  I'm working on some ways to greatly speed that up, including some automated truncation for stuff like that

sigh.  auto-close.  This is why you don't use "Fix" in a commit message. lol.
Anyway, what I ended up finding is that it was neither the file IO nor the regex parsing that was the limiting factor here - it's that asking chromium to display a few hundred thousand table rows is bad.  So, what it actually does is render the 20 or so that you can see in the window.  And when you scroll, it grabs the appropriate lines that you see now, etc, etc - the bonus is, the filtering and finding code is much, much cleaner, as it is operating on a data structure rather than a DOM structure.  In my tests, the 51Mb log file I made by pasting my regular log a few dozen times together ran every bit as fast as a tiny log file did - with the caveat that it took around a second to load when it hit the window.  If your running, constantly updating log file is that big, you might notice the lag at some point, but the debouncer also doesn't load the log that fast (I think there is a 5 second delay built in there).
Anyway, this will be in the next version, whenever that may be (probably a day or two, I don't have much else cooking, but I do want to update the dependencies again)

I found some large LOG files so you can test them yourself
logs.zip

https://github.com/FSGModding/FSG_Mod_Assistant/assets/605986/e57657c4-4806-45b2-b3d5-ee865b7fd72e
not too shabby now.

Nice

If you are feeling adventurous - https://github.com/FSGModding/FSG_Mod_Assistant/releases/tag/v2.9.91
The new log viewer is in there.  The other huge update is the mod parser is multi-threaded and runs in the background now.  Feels faster, and it is way less resource intensive.

Update release in 3.0.0 - lemme know if you still have issues.  Seems pretty sorted to me - thanks for your continued interest in testing and improving this :)


[7.24.x] Backport #6725

Backport of #6725 for 7.24.
See details in #6725

do we need a release note for backports ? I guess we do


chore: housekeeping

This PR focuses on housekeeping and implementing what might have been missed after merging everything together.

Hey I was playing around with the guildAuditLogEntryCreate event added in this pr and I found that an error occurs with created invites, when I try accessing entry.target.
Output:
ready as testbot
New audit log<PHONE_NUMBER>063872020
Type: INVITE_CREATE 40
Reason: null
User: undefined undefined
node:events:491
      throw er; // Unhandled 'error' event
      ^

TypeError: Cannot read properties of undefined (reading 'id')
    at Collection.update (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/util/Collection.js:30:17)
    at new Invite (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/structures/Invite.js:39:70)
    at get target [as target] (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/structures/GuildAuditLogEntry.js:112:20)
    at Client.<anonymous> (file:///home/shorty/projects/bot-messing-around/index.mjs:21:33)
    at Client.emit (node:events:513:28)
    at Shard.emit (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/gateway/Shard.js:229:26)
    at Shard.wsEvent (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/gateway/Shard.js:2336:22)
    at Shard.onPacket (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/gateway/Shard.js:374:26)
    at Shard._onWSMessage (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/gateway/Shard.js:2465:29)
    at WebSocket.emit (node:events:513:28)
Emitted 'error' event on Client instance at:
    at Shard.emit (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/gateway/Shard.js:229:26)
    at Shard._onWSMessage (/home/shorty/projects/bot-messing-around/node_modules/@projectdysnomia/dysnomia/lib/gateway/Shard.js:2468:18)
    at WebSocket.emit (node:events:513:28)
    at Receiver.receiverOnMessage (/home/shorty/projects/bot-messing-around/node_modules/ws/lib/websocket.js:1180:20)
    at Receiver.emit (node:events:513:28)
    at Receiver.dataMessage (/home/shorty/projects/bot-messing-around/node_modules/ws/lib/receiver.js:541:14)
    at Receiver.getData (/home/shorty/projects/bot-messing-around/node_modules/ws/lib/receiver.js:459:17)
    at Receiver.startLoop (/home/shorty/projects/bot-messing-around/node_modules/ws/lib/receiver.js:158:22)
    at Receiver._write (/home/shorty/projects/bot-messing-around/node_modules/ws/lib/receiver.js:84:10)
    at writeOrBuffer (node:internal/streams/writable:392:12)

Node.js v18.12.1

Code:
import { Client, Constants } from '@projectdysnomia/dysnomia';
import fs from 'node:fs';

const token = fs.readFileSync('token', 'utf8');
const client = new Client(token, {
    gateway: {
        intents: ['guilds', 'guildMessages', 'guildModeration'],
    }
});

client.on('ready', () => {
    console.log('ready as', client.user.username);
});

client.on('guildAuditLogEntryCreate', (entry) => {
    console.log('New audit log', entry.id);
    const typeName = Object.entries(Constants.AuditLogActions).find(([, value]) => value === entry.actionType)?.[0];
    console.log('Type:', typeName, entry.actionType);
    console.log('Reason:', entry.reason);
    console.log('User:', entry.user?.username, entry.user?.id);
    console.log('Target:',entry.target ?  entry.target?.constructor.name : '', entry.targetID);

});

client.connect();

Also another thing I noticed is that the user field is said to always be defined (at least in intellisense) but it actually is undefined in some cases (Specifcally, when I created the invite right off the boot, so I'm probably not cached).

Hey I was playing around with the guildAuditLogEntryCreate event added in this pr and I found that an error occurs with created invites, when I try accessing entry.target.

That one should be fixed in https://github.com/projectdysnomia/dysnomia/pull/26/commits/13237a1778b426dea2ceda35be89a34092f215dd

Also another thing I noticed is that the user field is said to always be defined (at least in intellisense) but it actually is undefined in some cases (Specifcally, when I created the invite right off the boot, so I'm probably not cached).

Indeed, it's an issue related to the incompleteness of the cache - the REST call includes the users referenced in the log, the gateway event doesn't; this will be patched appropriately.


[apply-login-partner-changes] - Partner filter to search other partners

Describe the bug
When a Partner logs in, and finds other partners, filter must show other options
**Sustainable Development Goals Your Work Supports *** -- user select checkboxes with auto refhresh like regions
Current & Upcoming Project Topics * -- user type and search automatically like "search by name"
**Organization/Institution/Corporation Full Name ***  -- user type and search automatically like "search by name"

@robert-dm  done

thanks @eslamzaaki


certainly not the best interaction handler or, yeah not something i would suggest

your event handler has a few things to be made better

the way you are dealing with the interactions won't be the best for the buttons since you are first checking if the INTERACTION_CREATE event gives you a component type or not, i would suggest you to first check for the event having components and then check for the slash commands because you are using a require cache type handler which would fail the interactions when you add many commands

you are deffering the interaction response from the event handler which is TOTALLY NOT THE BEST THING TO DO, i would suggest you to defer the interaction from the command files and then do stuff

once go through https://discord.dev/ you are replying with a followUp to a deferred interaction which works well for now, but further more i would suggest you to use editReply because, i  mean, the name followUp tells that it is for a followed up reply to an interaction, when you are just sending a TYPE 5 not a TYPE 4,

the way you are handling the interaction.defer() error, thats wrong, you are not alerting the user that there has been an error internally in the code, so yeah send a ephemeral (flags 64) type 4 reply saying that there was an error hence the command won't be ran further more

ok i make better
Thanks for Suggest

yes also close the issue once you are done


Remove the inverse checkbox prop where available

User Story

As a [user role below]:
IBM.com Library developer

I need to:
change the include the list of the patterns here

so that I can:
provide the ibm.com adopter developers patterns/components they can use to build ibm.com web pages

Additional information

Story within Storybook with corresponding knobs
Utilize Carbon
Prod QA testing issue (# )

Acceptance criteria

[ ] Include README for the react pattern and corresponding styles
[ ] Minimum 80% unit test coverage
[ ] A comment is posted in the Prod QA issue, tagging Praveen and Chetan, when development is finished
[ ] The Canary URL is added to the Prod QA issue for their testing

@Praveen-sr @chetankan Here is the issue we talked about in our meeting earlier today.  Linda would like you to review the patterns and provide us with a list of the patterns that must be updated.  Thanks.

@RobertaJHahn :- Below mentioned 'Patterns/Components' have inverse option

Card(Static/Clickable)
ImageWithCaption
VideoPlayer
ContentBlockSimple(Default)

Design decisions made:  1) Inverse theme will only be used for Card
Dev issues needed:  1)  Remove inverse from the above patterns.  2)  Prod QA issues are needed.


add .snk config file for cli params/config

At the moment snk places zero work of the pipeline developer. If they follow the snakemake workflow structure then snk works with no extra steps. However there are situations where it'd be good to hook into / modify / customise the snk generated CLI. One simple example is config e.g. I might have a samples csv defined in the pipeline config. The snk config could be used to specify that snk run takes a --samples param that points to the file.

snk will read CLI options from a .snk file in the pipeline repo


Renamed Location.active() to Location.getActive() because the propert…

…y wasn't being found.

#122


fix: collection.index_information return type is MutableMapping not a list

Fixes issue #39

I’ve already pushed a PR to fixe the issue.


Unable to build IdentityServer4 on Windows 10 machine

Issue / Steps to reproduce the problem
Download the latest IdentityServer4 zip file onto a Windows 10 machine from the github site at https://github.com/IdentityServer/IdentityServer4.
Install the latest .Net Core SDK.  I have versions 2 through 3.1 installed.
Execute the build.ps1 file in the project root.
I get a success message for the Nuget restore.
I then get the same "exited with code -532462766" error message for all 5 build.ps1 commands in the root build.ps1 file.  Apparently the "MinVer" nuget package is the cause of the error.  Here is one of the error messages, all 5 are the same except for the location of the build.csproj file:
C:\Users\tregan.nuget\packages\minver\2.0.0\build\MinVer.targets(39,5): error MSB3073: The command "dotnet "C:\Users\tregan.nuget\packages\minver\2.0.0\build../minver/MinVer.dll" --auto-increment "" --build-metadata "" --default-pre-release-phase "" --minimum-major-minor "" --repo "C:\Repo\Core\IdentityServer4-master\src\Storage\build" --tag-prefix "" --verbosity "" --version-override """ exited with code -532462766. [C:\Repo\Core\IdentityServer4-master\src\Storage\build\build.csproj]
I have verified that the paths it is looking for all exist (C:\Users\tregan.nuget\packages\minver\2.0.0\build, C:\Repo\Core\IdentityServer4-master\src\Storage\build\build.csproj).
Extracting from the error message, it appears this command is failing:
dotnet "C:\Users\tregan.nuget\packages\minver\2.0.0\build../minver/MinVer.dll"
The error message complains about the file MinVer.Targets, line 39. That points to the following section of the file, which is obviously responsible for creating the command that is failing to execute:
<Exec Command="dotnet "$(MSBuildThisFileDirectory)../minver/MinVer.dll" @(MinVerInputs->'%(Identity)', ' ')" ConsoleToMSBuild="true" StandardOutputImportance="Low" >

The build was failing because Git was not installed on my machine.  I suggest adding a 3rd step to the instructions: "Install Git".


Create License file

This needs to have a full name added in place of the current sallaben. Fixes #3.

Thanks!


building-gdp: Align to changes after 14th AMM

[ ] GDP now means "GENIVI Development Platform" - See upstream https://at.projects.genivi.org/jira/browse/GDP-197
[ ] Source repositories have been migrated to https://github.com/genivi - See upstream https://at.projects.genivi.org/jira/browse/GDP-189

Developing fix in PR https://github.com/gmacario/easy-jenkins/pull/114

Fix via PR https://github.com/gmacario/easy-jenkins/pull/114


ERR_PNPM_NO_MATCHING_VERSION  No matching version found for<EMAIL_ADDRESS>

UnoCSS version
0.58.6
Describe the bug
ERR_PNPM_NO_MATCHING_VERSION  No matching version found for<EMAIL_ADDRESS>This error happened while installing the dependencies of<EMAIL_ADDRESS>The latest release of @unocss/preset-tagify is "0.58.5".
Reproduction
run
pnpm up --latest

System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Running
pnpm add -D<EMAIL_ADDRESS>
can also trigger this bug

We temporarily closed this due to the lack of enough information. We could not identify whether it was a bug or a userland misconfiguration with the given info.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required


Download generated QRcode image

How can I download the image I generate with component ?
I want on button click to download as a image file.
I noticed the component generates an image with src attribute, but its too big, i dont understand it

See https://jsfiddle.net/xvw0yznd/


Modernize Travis CI runs

Use container-based
Use latest supported versions of Node.js

For the record:

io.js: merged to Node.js upstream long time ago
Node.js v0.10: LTS will end soon, on 2016-10-01
Node.js v0.12: LTS ended on 2016-04-01, unmaintained from 2016-12-31
Node.js v5: unmaintained, https://nodejs.org/en/blog/community/v5-to-v7/

@derhuerst Good point, I'll add it. Thanks for the suggestion!

LGTM


Better way to unload a plugin when certain types of programs are running

I just started using the zinit framework yesterday, and now I arrived at the reason why I decided to go with it in the first place and that is the conditional loading and unloading of plugins.
I use pyenv for managing local pythons on arch, so I installed pyenv plugin using:
# pyenv
zi ice atclone='PYENV_ROOT="$PWD" ./bin/pyenv init - > zpyenv.zsh' \
    atinit='export PYENV_ROOT="$PWD"' \
    atpull="%atclone" \
    as='command' pick='bin/pyenv' src="zpyenv.zsh" nocompile='!'
zi load pyenv/pyenv

The problem is that sometimes when I am trying to work with other programs (like yay, makepkg, reflector, etc) which have nothing to do with my local python, these programs might call other programs that will try to search for and find python3 on the path. Because pyenv modifies the path, these programs will try to execute my local python3, and may fail because some module is not installed.
My current approach is to add the following unload condition:
unload='[[ "$(dirname $0)" = "/usr/bin" ]]'

This seems to unload pyenv whenever a command which exists in /usr/bin is run. However, I'm not sure if that's the correct way of doing this because replacing the above with unload=[[ false ]], also does the same thing. In other words, I'm not sure how unload is supposed to be used 😝.

Ideally, what I would like to happen is that if I write a command which is not owned by my user, then pyenv should be unloaded while running that command, and then afterwards loaded again.
Is this possible? What are the alternatives?
Thanks

I think that you should load pyenv when entering your projects, e.g.: load='[[ $PWD = */(project1|project2)(|/*) ]]' unload='[[ $PWD != */(project1|project2)(|/*) ]]' .

The solution I went with was to modify pyenv.zsh to remove the export PATH line. Now when I need to use pyenv, I just run pyenv exec python. In addition, pipenv also does this to load a certain version of python

The solution I went with was to modify pyenv.zsh to remove the export PATH line. Now when I need to use pyenv, I just run pyenv exec python. In addition, pipenv also does this to load a certain version of python


Consume start and end partition and row keys

Packages impacted by this PR
@azure/data-tables
Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/25252
Describe the problem that is addressed by this PR
We accept startPartitionKey, startRowKey, endPartitionKey and endRowKey parameters when generating table sas token. However internally we are ignoring those provided values.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
To fix this problem we simply need to plumb the values through
Are there test cases added in this PR? (If not, why?)
YES
Provide a list of related PRs (if any)
N/A

API change check
API changes are not detected in this pull request.


Update sources.json - Saarbahn linies

Adding the source for the Saarbahn lines

Next time, please do one combined PR per contribution.


Fixed missing version_string attribute when used with urllib3>=2.3.0

urllib3 in v2.3.0 introduced attribute version_string (https://github.com/urllib3/urllib3/pull/3316/files). This attribute  is missing in VCRHTTPResponse which causes errors like AttributeError: 'VCRHTTPResponse' object has no attribute 'version_string'
This fixes https://github.com/kevin1024/vcrpy/issues/888

When will it be part of official build?

Once I find the time to make a release :)

@kevin1024 Is there anything contributors can do to help get this released sooner?

OK new release just dropped that should resolve this issue.  Thanks everyone for your patience and have a happy new year!


Update Makefile to make the new release structure

Needs to support the tar files with backups and schemas by database
streamline the makefile so there is less duplication

This will be resolved when the new project structure is in place. This will be backups, schemes, backups and docker files with no code


atomic charge

Hello！
I created a chain of  polyvinyl alcohol  for all-atoms MD simulation. I choosed the atom 96  and 97 as oxygen and hydrogen atoms of hydroxyl  in  OPLSAA.
Their charges are  -0.683 and 0.418.This is not electrically neutral .Is this because I chose the wrong atom type? Or  I need to use another tool to calculate atomic  charges？
Thank you！

Yes.  At least one of  your @atom types is wrong.  But I'm not sure its the oxygen or hydrogen atom.  You also have to consider changing the @atom type of the atoms they are bonded to (such as the carbon).
For the carbon atom which is bonded to the OH group, why don't you change it to type @atom:100?  That matches the description, and if you use @atom:85 for the hydrogen atom that's bonded to it, then (if I didn't mess up my arithmetic) each monomer in the polymer becomes neutral.
I will go ahead and close this github issue, admitting that the general issue of how to choose @atom types correctly remains a thorny and unresolved one.  There are some automated tools to infer these types, but I wonder if they work well.  Sometimes, there is not exact match for the atom you want to place, and you just have to pick the atom type which most closely matches the description (after checking the mass to confirm the element type), and then use a 3rd party tool to calculate the charge of the whole system.  Fortunately, in this simple example, I don't think you need to do that.

Dear jewettaij，
I appreciate your help  very much! I choosed  the wrong atom  types  of  carbon.  And  I have solved my problem  now.There is another
small question.When I read  file _“README.md”  to find a way to choose correct atoms type   yesterday，  the chapter  of“ ### Limitations for preparing all-atom simulationsit” says  “some suggestions for selecting the appropriate atom types for your molecules
are provided here.“ However，this website couldn‘t be open.
Thanks again for your help ！

I received a github notification from this user (ALEXysd) regarding a followup comment.  It might not be visible to the public, so I included it below, along with my reply:
"I appreciate your help very much! I choosed the wrong atom types of carbon. And I have solved my problem now.There is another small question.When I read file _“README.md” to find a way to choose correct atoms type yesterday， the chapter of“ ### Limitations for preparing all-atom simulations it” says “some suggestions for selecting the appropriate atom types for your molecules
are provided here.“ However，this website couldn‘t be open."
Hi ALEXysd (Coin).
That link works for me.  According to the service I used, it is also available in China.  Perhaps the web-site was down temporarily. Or, perhaps your web-browser is objecting to the lack of https in the URL?  Try replacing the "http://" with "https://"
https://moltemplate.org/force_field_recommendations.html
(In response to your question, I modified the README.md file to use "https://", and will upload it with the next github commit.  Thanks for pointing this issue out.)
I admit that I'm not sure if this is a helpful web page.  Meanwhile, I attached the contents of that file so that you can read it:
recommendations_force_fields_moltemplate_2021-6-30.zip

Thank you! It works now. When I  click  the link   in  the  file _“README.md”   , my web-browser turns to
"http://moltemplate.org/force_field_recommendations.html)."  rather than  "http://moltemplate.org/force_field_recommendations.html".
There is extra  “).”. This is why I can't open this website.I should  have  checked this .I am too careless .
Thank you for your suggestions and answers ！ Best wishes to you！
.

Thanks for your reply.  I'm glad it's working.  Best wishes to you too.


Replace "categorie" by "category"

Replace "categorie" by "category" in the appshortcut struct and in all references.

I replace the word "categorie" by category".
It is ok.


fix: pin autoray version

Issue #, if available:
Description of changes:
This change will pin the version of autoray to fix incompatibility with Pennylane<0.29.1
https://github.com/PennyLaneAI/pennylane/issues/3867
Testing done:
Testing with unit tests and integ tests
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

If we are upgrading to Pennylane 0.29.1 for all our containers, we will not need to upgrade here

Closing in favor of pursuing #74.


invalid escape sequence DeprecationWarning from template syntax itself

mcve
(this is extracted from a larger example which was rendering actual .j2 files -- however this was the shortest example I could come up with)
from jinja2 import Template

print(Template(r'{{ "\d" }}').render())

Expected Behavior
I'm unclear on the expected behaviour, there's kinda 3 options that I see as reasonable (unranked since I don't really have an opinion here)

warning: produce a warning, but with better indication on the user's fix (especially: point at the actual filename where the problem is)
error: make invalid escape sequences in templates an error
(silence) accept that string tokens in jinja source can have escape sequences that do not comply with python's rules

Actual Behavior
$ python3 -Wonce t.py
/tmp/x/venv/lib/python3.6/site-packages/jinja2/lexer.py:606: DeprecationWarning: invalid escape sequence '\d'
  .decode("unicode-escape")
\d

Full Traceback
This can be converted into an error with -Werror
$ python3 -Werror t.py
DeprecationWarning: invalid escape sequence '\d'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/tmp/x/venv/lib/python3.6/site-packages/jinja2/lexer.py", line 606, in wrap
    .decode("unicode-escape")
DeprecationWarning: decoding with 'unicode-escape' codec failed (DeprecationWarning: invalid escape sequence '\d')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "t.py", line 3, in <module>
    print(Template(r'{{ "\d" }}').render())
  File "/tmp/x/venv/lib/python3.6/site-packages/jinja2/environment.py", line 986, in __new__
    return env.from_string(source, template_class=cls)
  File "/tmp/x/venv/lib/python3.6/site-packages/jinja2/environment.py", line 896, in from_string
    return cls.from_code(self, self.compile(source), globals, None)
  File "/tmp/x/venv/lib/python3.6/site-packages/jinja2/environment.py", line 625, in compile
    self.handle_exception(source=source_hint)
  File "/tmp/x/venv/lib/python3.6/site-packages/jinja2/environment.py", line 787, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<unknown>", line 1, in template
jinja2.exceptions.TemplateSyntaxError: invalid escape sequence '\d')

Your Environment
$ python --version --version
Python 3.6.9 (default, Nov  7 2019, 10:44:02)
[GCC 8.3.0]
$ pip freeze --all
Jinja2==3.0.0a1
MarkupSafe==1.1.1
pip==20.0.2
setuptools==45.2.0
wheel==0.34.2

The "correct" fix for those hitting the same issue:
making a raw string is not valid syntax in jinja so that is not an option:
$ diff -u t.py t.py.new
--- t.py	2020-02-18 09:53:02.892139615 -0800
+++ t.py.new	2020-02-18 09:52:57.860139615 -0800
@@ -1,3 +1,3 @@
 from jinja2 import Template

-print(Template(r'{{ "\d" }}').render())
+print(Template(r'{{ r"\d" }}').render())

$ python3 t.py.new
...
jinja2.exceptions.TemplateSyntaxError: expected token 'end of print statement', got 'string'

the "fix" I needed was to manually escape the backslashes:
$ diff -u t.py t.py.new
--- t.py	2020-02-18 09:53:02.892139615 -0800
+++ t.py.new	2020-02-18 09:53:57.068139615 -0800
@@ -1,3 +1,3 @@
 from jinja2 import Template

-print(Template(r'{{ "\d" }}').render())
+print(Template(r'{{ "\\d" }}').render())

$ python3 t.py.new
\d

exceptions

As a data point: Ansible works around this behaviour by magically inserting missing slashes: https://github.com/ansible/ansible/blob/42bc03f0f5740f2340fcdbe75557920552622ac3/lib/ansible/template/init.py#L130

As a data point: Ansible works around this behaviour by magically inserting missing slashes: https://github.com/ansible/ansible/blob/42bc03f0f5740f2340fcdbe75557920552622ac3/lib/ansible/template/init.py#L130


Reintroduce tags

Short Description
Reintroduces Tags, this breaks existing databases!

Also to get Travis to pass again, just add a mocked bean of the TagService to  AlgorithmControllerTest and ImplementationControllerTest

Also to get Travis to pass again, just add a mocked bean of the TagService to AlgorithmControllerTest and ImplementationControllerTest

Needed a bit more work, but should be done now

If we end up adding tags to other things, we should consider using mixins


Omega index with high score

Hello.
I'm testing the omega index method (original and soft), however, I'm getting a result that doesn't make sense in my view, and I didn't find a reason in the article for that.
I have a file with the expected (ground-truth, gt.cnl) and another with the result of the clustering algorithm (cs.cnl). gt.cnl has 10 groups with 132079 nodes and cs.cnl with 5 groups and 96000 nodes. Using the omega index the score was equal to 0.90 (e.g., ./xmeasures -ox gt.cnl cs.cnl).
In my view, this result does not make sense with what I expected in the ground-truth. Does it is not considered the number of clusters in the analysis? Can anyone give me some guidance? Is there a more detailed manual of using xmeasures?
Thank you for your help.

Hello Yuri,

Does it is not considered the number of clusters in the analysis?

Omega index by definition* does not consider the number of clusters (groups). This measure evaluates co-occurrences of nodes in two collections of clusters.
* L. M. Collins and C. W. Dent, “Omega: A general formulation of the rand index of cluster recovery suitable for non-disjoint solutions,” Multivariate Behavioral Research, vol. 23, no. 2, pp. 231–242, 1988

Can anyone give me some guidance? Is there a more detailed manual of using xmeasures?

So, before evaluating any accuracy measures, you should read about them and select the one that matches your expectations and demands.
Also, you can try other implementations to validate the evaluation correctness. You can start with ParallelComMetric and  CluSim in the Related Projects.


LengthTool is not working properly after upgrading to latest version

Hello,
I am facing issue with LengthTool and BidirectionalTool after upgrading my project with new libraries.
Both these tools were working with old libraries :--
"@cornerstonejs/calculate-suv": "^1.0.2",
"@cornerstonejs/core": "^0.15.3",
"@cornerstonejs/streaming-image-volume-loader": "^0.4.23",
"@cornerstonejs/tools": "^0.23.2",
New library versions :--
"@cornerstonejs/calculate-suv": "^1.0.2",
"@cornerstonejs/core": "^0.21.0",
"@cornerstonejs/streaming-image-volume-loader": "^0.6.1",
"@cornerstonejs/tools": "^0.29.2",
There is no code changes in my project, only  I have upgraded my project with new libraries.
Thanks

Please see the images,
1st image where LengthTool is coming properly
2nd image where line is missing , we can see only end points and  measurement

Here is the problem
If I load images in thumbnail & viewport then below problem appears. Annotation gets drawn but only measurement value is seen.
https://user-images.githubusercontent.com/92505215/209109236-9d7b72b7-c631-4bf4-8942-a7ecf365a0a3.mp4
If I load images in viewport only then it works correctly
https://user-images.githubusercontent.com/92505215/209109610-5a274a55-3711-4164-9baf-c6949181386a.mp4
Here is source code
TestApp.zip
This problem did not exist with earlier version of Cornerstone3Dbeta. Here are the old version details
"@cornerstonejs/calculate-suv": "^1.0.2",
"@cornerstonejs/core": "^0.15.3",
"@cornerstonejs/streaming-image-volume-loader": "^0.4.23",
"@cornerstonejs/tools": "^0.23.2",

I can't reproduce this here https://www.cornerstonejs.org/live-examples/stackannotationtools
I don't think it is data related either. What do you mean when I load images in thumbnail?

I have attached sample application here , can you please check  --
https://github.com/cornerstonejs/cornerstone3D-beta/files/10285892/TestApp.zip

Can you provide a reproducible bug in our examples?


libcamera-apps crash on Rpi 3b+

I see crashes when running any of the libcamera-apps, without the --qt-preview option.
I've found recently closed similar issues, that seems to point towards what I'm seeing: 31, 46, 125
I've tried a lot of avenues of the advice I found and still having issues; I reached out to kbingham, who suggested I open this issue.
Setup:
Raspberry Pi 3b+, Raspbian OS (bullseye) with desktop, latest version from last week. libcamera and libcamera-apps updates from Monday (29th Nov 2021)
Working with an IR camera setup from eBay.
raspinfo.txt
config.txt
I tried with gpu_mem=128 set, but as kbingham described it, that is taking memory away from the desired area for libcamera.
Allocating extra memory for the GPU reduces the memory available for the kernel (citation needed on if this is a correct interpretation of libcamera implementation).
Didn't seem to make a difference either way.
Things that do work:

--qt-preview
-n (no preview when taking pictures or recording raw h264)

Seems like there's an issue with the result returned from the call to eglCreateImageKHR
libcamera-hello_backtrace.txt
Any help I can give to solving this do let me know.
Many thanks!

Hi, perhaps we can start by checking a few things.

Can you report the output of uname -a.
Also vcgencmd version.
And libcamera-hello --version.
Can you confirm that you have re-enabled Glamor (see here).
Could you try it without the config.txt changes (specifically, i2c_arm and those ir ones). Is that any different?
Are you running with an attached display or are you logged in via ssh? Are you using X-forwarding?

Thanks!

Hi David,
Thank you for the link recommending enable Glamor. Enabled it and it's all working. Boy is my face red (bathed in IR light ;P)
For others who follow due to SEO:

A workaround is to open a terminal, run "sudo raspi-config", navigate to "Advanced Options" and enable "Glamor" graphic acceleration. Then reboot your Pi.
We're still investigating a longer term solution, as well as other problems that have been reported.

For completeness, running with display attached. Here's the info you asked for 👍
$ uname -a
Linux raspberrypi3b 5.10.63-v7+ #1488 SMP Thu Nov 18 16:14:44 GMT 2021 armv7l GNU/Linux

$ vcgencmd version
Nov 18 2021 16:19:03
Copyright (c) 2012 Broadcom
version d9b293558b4cef6aabedcc53c178e7604de90788 (clean) (release) (start_x)

$ libcamera-hello --version
libcamera-apps build: 2a38ae93f143 21-10-2021 (14:49:21)
libcamera build: v0.0.0+3156-f4070274

When running over ssh with X-forwarding it failed with the following output:
$ libcamera-hello
libEGL warning: DRI3: failed to query the version
libEGL warning: DRI2: failed to authenticate
X Error of failed request:  BadRequest (invalid request code or no such operation)
  Major opcode of failed request:  155 ()
  Minor opcode of failed request:  1
  Serial number of failed request:  16
  Current serial number in output stream:  16

But I'm happy. Thanks again.


fix mysqlload works with cluster and refactor code

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Update the Google AccessToken Revoke class to use the arg_seperator param in the http_build_query call

Solves https://github.com/google/google-api-php-client/issues/1046 for the new API version

I signed it!

I'm a little confused as to what effect this has, since we provide a single parameter, and so will not require a separator. i.e. this will always output the following, regardless of what the default separator is set to:
string() "token=TOKENSTRING"

It would be great to have a test to cover this, so we can be sure it'll fix the issue.

Indeed you are correct on this. Didn't notice the v2 API always only has 1 parameter. I think you can close this.


Missing Pacific Cod in AKFIN_SPECIMEN

Reposting this issue emailed to me by @zandjyo. Thanks for exploring this, Steve!
Issue Description
There seems to be some differences between AKFIN_SPECIMEN and RACEBASE.SPECIMEN.
@zandjyo: "I had used specimen going back to 1983, the AKFIN_SPECIMEN only has data to 1993 for BS cod and AKFIN_LENGTH has some issues with missing data as well."
This is likely an issue with cruisejoin and cruise_id join on https://github.com/afsc-gap-products/gap_products/blob/main/code/sql_akfin/AKFIN_SPECIMEN.sql#L37
### Tasks
- [ ] Find reason for mismatch and correct data
- [ ] Provide reasoning for why tables are not matching
- [ ] Add reason for mismatch to data changes doc in data report
- [ ] Make into AKFIN data usage example

Steps to Reproduce
From @zandjyo: "Checking on this table shows some missing data as well. Pulling cod data we are missing all the 1980s except 1985, and all the 1990s except 1993, then the 2000s start in 2005 when pulling cod lengths for survey_definition_id in (98,143). There should be length data going back to at least 1982 for every year except 2020.
"Here is my SQL script for this:"

Comparison of last year's BS pcod size comps with this year from the GAP_PRODUCTS.  Very minor changes, mostly completely overlapping.

I will be without network access for the next two weeks so I am heavily leaning on @Ned-Laman-NOAA to figure this one out. The same issue is in play for the AKFIN_LENGTH query so whatever you revise for AKFIN_SPECIMEN will need to be done for AKFIN_LENGTH. A clue to how to resolve this is to look at the query for AKFIN_CRUISE where you join vessel ID, cruise, survey ID, survey_definition_id, and organization ID. Once the problem is found and settled, @EmilyMarkowitz-NOAA, can you work with Ned to replace the revised SQL code via GitHub? Thanks all.

I have revised the two queries for LENGTH and SPECIMEN data and they no reproduce the master cruise list query for AKFIN (see SQLPlus below). The issue was that the constraint statement abs(CRUISE_ID) = CRUISEJOIN was not correct. It seems that abs(CRUISE_ID) does match CRUISEJOIN for reconciled data in RACE_DATA (2005 to present), but does not match CRUISEJOIN for unreconciled cruises preceding 2005.
Here is the Master Cruise List for AKFIN that I was trying to match:
-- master cruise list for AKFIN
select distinct
a.cruisejoin,
a.region,
a.vessel,
b.cruise,
d.survey_definition_id,
d.survey_name,
d.description,
e.name vessel_name,
f.acronym sponsor_acronym,
c.start_date date_start,
c.END_DATE date_end
from racebase.haul a,
race_data.cruises b,
race_data.surveys c,
race_data.survey_definitions d,
race_data.vessels e,
race_data.organizations f
where a.vessel = b.vessel_id
and b.vessel_id = e.vessel_id
and a.cruise = b.cruise
and c.survey_id =  b.survey_id
and c.survey_definition_id = d.survey_definition_id
and d.survey_definition_id in (143,98,47,52,78)
and a.abundance_haul = 'Y'
and f.organization_id = c.sponsor_organization_id
order by a.region, b.cruise
/
-- 187 cruises and 187 vessel, cruises
Here is the corrected code for LENGTH and SPECIMEN. I've cleaned it up a bit from the original by eliminating some commented out lines and such so that the only commented out lines of code are those that I replaced with the ALL CAPS lines:
select a.hauljoin,
species_code,
sex,
frequency,
length as length_mm,
length_type,
sample_type
from racebase.length a, race_data.cruises b, race_data.surveys c,
race_data.survey_definitions d, racebase.haul f
--where abs(a.cruisejoin) = b.cruise_id
WHERE A.CRUISE = B.CRUISE
AND A.VESSEL = B.VESSEL_ID
and a.hauljoin = f.hauljoin
and c.survey_id =  b.survey_id
and c.survey_definition_id = d.SURVEY_DEFINITION_ID
and d.survey_definition_id in (143, 98, 47, 52, 78)
and f.abundance_haul = 'Y'
/
and for SPECIMEN
select  a.hauljoin,
a.specimenid as specimen_id,
a.species_code,
a.length as length_mm,
a.sex,
a.weight as weight_g,
a.age,
a.maturity,
a.gonad_wt as gonad_g,
a.specimen_subsample_method,
a.specimen_sample_type,
a.age_determination_method
from racebase.specimen a,
race_data.cruises b,
race_data.surveys c,
race_data.survey_definitions d,
racebase.haul f
-- where abs(a.cruisejoin) = b.cruise_id
WHERE A.CRUISE = B.CRUISE
AND A.VESSEL = B.VESSEL_ID
and a.hauljoin = f.hauljoin
and c.survey_id =  b.survey_id
and c.survey_definition_id = d.SURVEY_DEFINITION_ID
and d.survey_definition_id in (143, 98, 47, 52, 78)
and f.abundance_haul = 'Y';

Note that for the LENGTH query above, it reproduces that same 187 cruises as the Master Cruise list. For SPECIMEN, it reproduces 186 cruises of the 187 from the Master List because GOA 198402, Vessel 57 did not have any specimen data recorded in RACEBase.

Thanks for this, Ned! I just added the edits you've noted above to the AKFIN_LENGTH and AKFIN_SPECIMEN.

[ ] Next step is to review offending abundance_haul designations/rules to change which cruises get included in the AKFIN_CRUISES table, and therefore what data are included in these tables.

Thanks @Ned-Laman-NOAA, I appreciate your help with this issue and thanks @EmilyMarkowitz-NOAA for h. When I get back to the states on the 10th, I'll rerun and follow up with @zandjyo. Sorry @zandjyo for the slight delay.

Hi @zandjyo
I updated all of the the AKFIN_* tables on the GAP_PRODUCTS schema with @Ned-Laman-NOAA revised SQL code from 8521fcf7986616a692fb556f94bd992abd8d893b. I ran Steve's query from above (in text below) and was able to now get length records from 1982-2023 (sans 2020). Steve, can you compare your records again and get back to us? Thanks all!
SELECT
GAP_PRODUCTS.AKFIN_LENGTH.SPECIES_CODE,
GAP_PRODUCTS.AKFIN_CRUISE.YEAR,
SUM(GAP_PRODUCTS.AKFIN_LENGTH.FREQUENCY) AS "SURVEY_LENGTH"
FROM
GAP_PRODUCTS.AKFIN_HAUL
INNER JOIN GAP_PRODUCTS.AKFIN_CRUISE ON GAP_PRODUCTS.AKFIN_CRUISE.CRUISEJOIN = GAP_PRODUCTS.AKFIN_HAUL.CRUISEJOIN
INNER JOIN GAP_PRODUCTS.AKFIN_LENGTH ON GAP_PRODUCTS.AKFIN_HAUL.HAULJOIN = GAP_PRODUCTS.AKFIN_LENGTH.HAULJOIN
WHERE
GAP_PRODUCTS.AKFIN_CRUISE.SURVEY_DEFINITION_ID IN (98,143)
AND GAP_PRODUCTS.AKFIN_LENGTH.SPECIES_CODE IN (21720)
GROUP BY
GAP_PRODUCTS.AKFIN_LENGTH.SPECIES_CODE,
GAP_PRODUCTS.AKFIN_CRUISE.YEAR
ORDER BY
GAP_PRODUCTS.AKFIN_LENGTH.SPECIES_CODE,
GAP_PRODUCTS.AKFIN_CRUISE.YEAR

I'm going to close this issue, I think we've resolved this. If Steve or anyone else comes back to us and it's not fully resolved, we can reopen this issue.


[SMALLFIX] Remove stale ufs jars in "lib/"

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18781/
Test PASSed.

Merged build finished. Test PASSed.


Reorganize "Get started" section

Everything that is currently situated in the Get started section:

should be moved into a release-independent section.
As a proposal, we could call it "A brief introduction to Keptn" with a reference to its core principles.

The agreed approach for addressing this issue is that a section called Concepts should show the following content:


New PT idea – Integrate Text Grab by Joe Fin

I think it would be great to have this tool Text Grab by @TheJoeFin integrated into PowerToys in the future, if he agreed of course.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

I think this is something the main team (@crutkas, @enricogior, ...) has to decide. But if they are olay with implementing this tool, you @TheJoeFin can create a PR to implement it.

Related to #6190 and #4371

The repro doesn't have a license.  Looking at the commit history, My guess would be it is #4371 which is Image With Text to Text pasting.  Correct?

if so, lets close this as a dup and move the conversation to that issue

This app was just launched. I'll add an MIT license. You could use the Google OCR API mentioned in #4371, but I'd thing Power Toys would prefer to use the OCR built into Windows.
Text Grab is very much a preview right now. I'm working on adding features over the next couple of days. When it is more complete I'd be happy to have it rolled into Power Toys.

Lets move to #4371 as my assumption was correct.

The problem is the WinRT OCR APIs require package identity.
PowerToys is unpackaged and seems like the core team want to keep it that way. So the WinRT OCR APIs will be useless incase of PowerToys.

The problem is the WinRT OCR APIs require package identity.
PowerToys is unpackaged and seems like the core team want to keep it that way. So the WinRT OCR APIs will be useless incase of PowerToys.


Implement Removal of tours marked as "not interested"

If a user clicks on the button "Not interested" then that tour should be removed from the displayed list of tours

If a user clicks on the button "Not interested" then that tour should be removed from the displayed list of tours

Noted.


Can't open a file while another is open

Steps:

Create 2 files (fileA, fileB) using this plugin.
Open fileA.
While fileA is open, click on fileB to open it.
fileB is not displayed. But fileA.

Current workaround:

save file1
Close it.
Then open file2

Resolved:


Browser-Refresh Moves the User Back to User-Registration Page

We should fix this so that a browser-refresh just refreshes the content that is displayed according to the model status.

@eum2o see #5 for the change.
Pls note that there might (or might not) be better solutions to this. I'm still new to all this React-hooks-thingie-stuff.
Manual Integration Test

Started server as described on readme (only using port 5001 instead of 5000 b/c already in use)
Started app w/ npm start
Verified that app starts on submit-username view
Entered name and hit ENTER
Estimation stuff is now displayed
Invoked CMD+R to refresh the browser
Estimation stuff is still displayed with my name ✅


expose core test types properly

This change exposes the types added in #651 to consumers (including our own packages).  This is necessary for any package to use types like Scenario.
Of note, I moved the LavaMoatOpts type into lavamoat-core, because that type is used directly by the Scenario type.  This will avoid an implicit cycle in lavamoat-core & lavamoat.

chore(node, core): move LavaMoatOpts typedef into lavamoat-core
chore(core): expose types from test/util and scenario definition
chore(eslint): prevent n/no-extraneous-* from touching test files with .ts extensions

#1087  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


batch metrics and add more detailed stats

This is addressing issue of multiple calls made to the metrics api (3) mentioned here:
https://github.com/DataDog/chef-handler-datadog/issues/42
At the same time it pulls more details about the chef run allowing for introspection into resource convergence.

https://github.com/DataDog/chef-handler-datadog/pull/73


fix: Edit actions for Lg with structured responses (cut/copy/paste)

Description
Adds cut/copy/paste for nested Lg template with structured responses.
Task Item
closes #6447
https://user-images.githubusercontent.com/1483492/111669627-39f36100-87d4-11eb-8236-d5e8bba6ba4e.mp4

Wrong branch


Receiving transport_read() error: errno=128 when trying to retrieve the device twin

Following the sample in the SDK to retrieve the Device Twin, I have adapted the code from the Azure_IoT_Hub_ESP32 for the esp mqtt.
The sample Azure_IoT_Hub_ESP32 works fine, but the code the retrieve the Device Twin is returning transport_read() error: errno=128.
Using an MQTT client all seems to work as per the logic of the code.  So if you can help me understand what is not working, that would be great.  Or provide a workable example for ESP32 Arduino to get the device twin.
Calling the below function after both client initialized successfully:
`void subscribeToDeviceTwin()
{
char twinDocBuffer[128];
char twinData[128];
if (esp_mqtt_client_subscribe(mqttClient, AZ_IOT_HUB_CLIENT_TWIN_RESPONSE_SUBSCRIBE_TOPIC, MQTT_QOS1) == MQTT_FAILURE)
{

#ifdef DEBUG_SERIAL // Debug info
Serial.printf("[AZURE] The subscription to the device twin topics failed.\n");
#endif
exit(MQTT_FAILURE);
}
az_result rslt = az_iot_hub_client_twin_document_get_publish_topic(&azureClient, twin_document_topic_request_id, twinDocBuffer, sizeof(twinDocBuffer), NULL);
if (az_result_failed(rslt))
{
#ifdef DEBUG_SERIAL // Debug info
Serial.printf("[AZURE] Failed to get the Twin Document topic: az_result return code 0x%08x.", rslt);
#endif
}
#ifdef DEBUG_SERIAL // Debug info
Serial.printf("[AZURE] Send an empty message to topic: %s\n", twinDocBuffer);
#endif
if (esp_mqtt_client_publish(mqttClient, twinDocBuffer, twinData, sizeof(twinData), MQTT_QOS1, DO_NOT_RETAIN_MSG) == MQTT_FAILURE)
{
#ifdef DEBUG_SERIAL // Debug info
Serial.printf("[AZURE] The publish of the device twin topics failed.\n");
#endif
}
}`
The debug output:
2022/7/11 09:15:48 [INFO] Client ID: ESP32GardenSensor1
2022/7/11 09:15:48 [INFO] Username: IoTHub4000.azure-devices.net/ESP32GardenSensor1/?api-version=2020-09-30&DeviceClientType=c/1.3.1(ard;esp32)
2022/7/11 09:15:202250/7/11 [INFO]  MQTT client started09
:15:50 [INFO] MQTT event MQTT_EVENT_BEFORE_CONNECT
2022/7/11 09:15:51 [INFO] MQTT event MQTT_EVENT_CONNECTED
2022/7/11 09:15:51 [INFO] Subscribed for cloud-to-device messages; message id:16042
2022/7/11 09:15:51 [INFO] MQTT event MQTT_EVENT_SUBSCRIBED
[AZURE] Send an empty message to topic: $iothub/twin/GET/?$rid=get_twin
2022/7/11 09:15:52 [INFO] MQTT event MQTT_EVENT_SUBSCRIBED
E (8685) MQTT_CLIENT: mqtt_message_receive: transport_read() error: errno=128
2022/7/11 09:15:52 [INFO] MQTT event MQTT_EVENT_ERROR
E (8686) MQTT_CLIENT: mqtt_process_receive: mqtt_message_receive() returned -1
2022/7/11 09:15:52 [INFO] MQTT event MQTT_EVENT_DISCONNECTED

Hi @Tintin4000 we published an update to the Arduino library which addresses this issue. Are you able to try it out and let us know if your issue goes away?

Can you post the logs as you did before? I just want to double check.

2022/7/12 04:22:21 [INFO] Client ID: ESP32GardenSensor1
2022/7/12 04:22:21 [INFO] Username: IoTHub4000.azure-devices.net/ESP32GardenSensor1/?api-version=2020-09-30&DeviceClientType=c/1.3.2(ard;esp32)
2022/7/12 04:202222/7:/1223 04 [INFO] :22:MQTT client started23
[INFO] MQTT event MQTT_EVENT_BEFORE_CONNECT
2022/7/12 04:22:24 [INFO] MQTT event MQTT_EVENT_CONNECTED
2022/7/12 04:22:24 [INFO] Subscribed for cloud-to-device messages; message id:23806
2022/7/12 04:22:24 [INFO] MQTT event MQTT_EVENT_SUBSCRIBED
[AZURE] Send an empty message to topic: $iothub/twin/GET/?$rid=get_twin
2022/7/12 04:22:25 [INFO] MQTT event MQTT_EVENT_SUBSCRIBED
E (9691) MQTT_CLIENT: mqtt_message_receive: transport_read() error: errno=128
2022/7/12 04:22:25 [INFO] MQTT event MQTT_EVENT_ERROR
E (9692) MQTT_CLIENT: mqtt_process_receive: mqtt_message_receive() returned -1
2022/7/12 04:22:25 [INFO] MQTT event MQTT_EVENT_DISCONNECTED

And on the Azure side:
authType:null
deviceId:ESP32GardenSensor1
errorMessage:Device disconnected, see cause and resolution at https://aka.ms/iothub404104
maskedIpAddress:80.209.90.XXX
protocol:Mqtt
statusCode:404

Ahhh yup okay so the issue is from the second line of the log. It has DeviceClientType=c/1.3.2. That forward slash should be url encoded to a %2F which we did here in the samples for the newest release. You can either take the new sample or just change that line to match what's in the repo. Let me know how that works out for you.

  It worked.  Do you have an explanation so I learn the issue?  Log here under:
2022/7/12 14:24:09 [INFO] Client ID: ESP32GardenSensor1
2022/7/12 14:24:09 [INFO] Username: IoTHub4000.azure-devices.net/ESP32GardenSensor1/?api-version=2020-09-30&DeviceClientType=c%2F1.3.2(ard;esp32)
2022/7/12 14:24:202211/7/12 [INFO]  14MQTT client started:24:
11 [INFO] MQTT event MQTT_EVENT_BEFORE_CONNECT
2022/7/12 14:24:12 [INFO] MQTT event MQTT_EVENT_CONNECTED
2022/7/12 14:24:12 [INFO] Subscribed for cloud-to-device messages; message id:55025
2022/7/12 14:24:12 [INFO] MQTT event MQTT_EVENT_SUBSCRIBED
[AZURE] Send an empty message to topic: $iothub/twin/GET/?$rid=get_twin
2022/7/12 14:24:13 [INFO] MQTT event MQTT_EVENT_SUBSCRIBED
2022/7/12 14:24:13 [INFO] MQTT event MQTT_EVENT_PUBLISHED
2022/7/12 14:24:13 [INFO] MQTT event MQTT_EVENT_DATA
2022/7/12 14:24:13 [INFO] Topic: $iothub/twin/res/200/?$rid=get_twin
2022/7/12 14:24:13 [INFO] Data: {"desired":{"sensor":{"Sleep":5},"$version":2},"reported":{"$version":1}}

The gist of it is that the user agent needs to be URL encoded and if it isn't, then the device can fail if the service fails to parse that. As long as that value is encoded you're good to go 👍🏼


[Bug][GitHub] wrong pipeline name column if run-name is defined

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
If my workflow uses run-name then the name column in _tool_github_runs and cicd_pipelines tables collected with display_title instead of workflow name, as a result, it's hard to filter and query statistics for such workflows.

What do you expect to happen
name column the same as without run-name definition with name of workflow instead dynamic display_title as without run-name

How to reproduce
use run-name in any workflow definition eq:
run-name: "Deploy on ${{ inputs.app_name || github.event.label.name || 'production' }}
Anything else
github connection with github app and graphql configured
no transformation rules enabled
Version
v1.0.0
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The current implementation does not differentiate when collecting names for pipelines, as far as I recall. Consequently, GitHub may return different names depending on whether the run-name was specified.
Both returned names can be meaningful in different contexts. Therefore, I suggest that we maintain both in separate fields to accommodate various users and scenarios, provided they are both available from the API.
I admit that I do not fully grasp the specifics of this issue, nor do I have the time to delve deeply into it at the moment. However, I am open to advancing the development by adding another field for your scenario. If you could investigate what the API offers and outline what needs to be done, it would greatly help us move forward.


SA1649 conflicts with default Razor Pages file/class naming

When creating a Razor Page it will generate a .cshtml and .cshtml.cs files. The model used inside this file is postfixed with Model, which causes SA1649 to be violated.
Eg: When creating a Razor Page called Index, the files generated will be called Index.cshtml and Index.cshtml.cs, but the class generated will be called IndexModel.
Not sure if this case should be allowed in SA1649, as I don't want to switch this rule off for the whole project and adding #pragma warning disable/restore to every Razor Page seems excessive to me?

@sharwell
I know I'm late to the party here, but your suggestion #2 would break the convention that's been in place since the beginning of MVC where model classes end with the Model suffix to distinguish from similarly named objects (usually entities), #3 requires also renaming the .cshtml file, which is part of the URL.
The gotcha here is that in traditional MVC, the cshtml files had no code-behind & the models live in a separate folder... now with Razor Pages the model is the code-behind, which for many scenarios is much cleaner by having related pieces together, but does break this rule as the two long-standing conventions now conflict with each other.
It would be nice if rulesets could apply by subfolder instead of strictly at the project level, but I have a hunch the amount of effort required to make that happen means I'm not likely to see it anytime soon.
Meantime, as ugly as it is, I'm setting my convention to be the first line of all Razor Page code behinds/models is #pragma warning disable SA1649.

Thanks @af4jm for pointing out the problems with the second and third of @sharwell's suggestions
I just want to add the following for the first suggestion: Making the code-behind partial is widely considered as a code smell because it is technically an unnecessary keyword which just clutters the code. I would prefer to not use this approach.

Agreed with @saciervo on the use of partial. For now, I think our team will just apply [SuppressMessage] to every single page model class.

Between the two conventions, I believe that StyleCop should win; however, 1) considering that the MVC developers decided to not follow StyleCop in their design considerations, 2) it is not likely to change and 3) everyone is going to just suppress the warning anyway, StyleCop should ignore this warning for .cshtml.cs files, or at least alter the rule so that it accepts "IndexModel" as an acceptable class name inside "Index.cshtml.cs".

@daviddunson That should be possible using .editorconfig in 16.3.
[*.cshtml.cs]
dotnet_diagnostic.SA1649.severity = none

According to this article, this will only suppress the warning in Visual Studio and the CI builds will fail.

Conventions that are set in an EditorConfig file cannot currently be enforced in a CI/CD pipeline as build errors or warnings. Any style deviations appear only in the Visual Studio editor and Error List.

@daviddunson The property I described in https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2590#issuecomment-518313609 is a new compiler feature, separate from the article you linked to and new for the 16.3 release.


Image tile redundant downloading

I just recently noticed that when I drag my deep zoom image around for a while, and then go back to the same area I was before (without changing the zoom level), I notice that the tiles in that area are blurry and they get downloaded again. Is there some kind of setting that I am missing? And it is not tied to a particular area of the image.
My thinking was that if I drag the image around at a certain zoom level so that all the tiles get shown, then these tiles should not get blurry and get downloaded again.

There is a maxImageCacheCount (default is 200) parameter that you can try to increase.
It will of course consume more memory.
That might not be enough because if you noticed that the image get downloaded again that means that the browser removed it from it own (file system) cache. That would mean that already a lot of data is stored in cache.

I will play with this setting, thanks! I assumed that the tiles get downloaded again as when I drag to the area I visited before the first thing I see is sort of bury/pixelated area which then becomes clear and readable.
The original image (when not sliced) it self is around 7 pixels, does that strike as too much data for the browser?

Seven pixels is a pretty small image! Do you mean gigapixels? :)

Please pardon my spelling.
All the tiles for this image weight up to 7.7MB. In this link you can see all the 14 folders with tiles for this single image.
To better illustrate the issue I have created this (click here) video where you can see that tiles have become blurry when I drag to the area I was in moments ago. Do you have any idea of what is causing this?

I expect those tiles will be a lot bigger in memory, but even so, I don't see why they should be getting flushed.
Can you get the same thing to happen in the viewer on http://openseadragon.github.io? Have you tried in multiple browsers? Do you have a link to the actual page you can share? What options are you using when you create the viewer?

It is a very basic viewer. Please see the page here. I tested this on Chrome, Safari and Firefox - all of them have the same problem.

Thanks for the link! I get the same behavior on that page. I think it probably is just the maxImageCacheCount. Just opening that page on my browser downloads 122 tiles. Zooming into it loads another 40, getting me close to the default 200.
Can you easily rebuild the image? It seems to me like probably the best fix would be to make your tiles bigger (so there are fewer of them). In the past, we've defaulted to 254px tiles, but with modern screens and bandwidth, we can easily do bigger than that. Also, since your image is black and white, it compresses very well. I'd try 510 or even 1022.

"Rebuild the image" - meaning slice into larger tiles? Yes - I'll try that. I will also play with the maxImageCacheCount and see what happens.

How did you check that by opening the page alone downloads 122 tiles? When I look at the Net tab in my Firefox Firebug I see total of 48 requests including the images.

Yes, I used the Net tab. I'm on a large HDPI screen, so it's probably loading more tiles because of that.
And yes, I meant slice into larger tiles :)

I did not go through the whole process of changing the tile size, but I did change the maxImageCacheCount to 2000 which did the trick. Thanks!


WIP: FD methods and surface integrals/terms

This PR basically collects two parts.
Part 1: Surface integrals/terms for additional dispatch (basically finished)
Summary: I introduced a surface integral/term type which is passed to every surface computation, mimicking the approach we have for our volume integrals/terms.
This could be considered to be breaking since it changes a documented constructor of our DG type. On the other hand, the documentation of this constructor was just wrong (since it contained the basis twice but not the mortar). Hence, this is more like a bug fix, I think ;).
Currently, the SurfaceintegralWeakForm is used everywhere; the SurfaceIntegralStrongForm will be used for FD methods later. This will also be useful to get more general methods of @jlchan. When we merge this, we need to remember to notify others.
Part 2: First step towards FD methods in Trixi (WIP)
This is a rough draft adapting the 2D TreeMesh DG solver. TODO:

[ ] Adapt the other TreeMesh stuff (and other mesh types) accordingly
[ ] Add tests for FD methods
[ ] Fix TODO: FD or add them to the list in #607
[ ] Add experimental warnings and/or news
[ ] Add references
[ ] Add docs
[ ] We need to consolidate terms/integrals (#616) before merging this
[ ] Move code to appropriate places (cf. #542). We need more levels in our solver hierarchy.

DG: Current sub-methods are SBP-FD and DGSEM
For each mesh type, we could have a dg_common.jl and a dgsem_common.jl.
More specific methods can be implemented in tree_2d_dgsem, tree_2d_fd etc.

Initial draft of SBP FD methods which needs modifications of SummatioByPartsOperators.jl that I will push later to upstream. Convergence test for linear advection:
julia> using Trixi

julia> convergence_test("examples/tree_2d_fd/elixir_advection_extended.jl", 5, initial_refinement_level=0, abstol=1.0e-10, reltol=1.0e-10, N=32)
[...]
####################################################################################################
l2
scalar
error     EOC
7.68e-05  -
1.33e-05  2.53
1.84e-06  2.86
2.29e-07  3.00
2.86e-08  3.00

mean      2.85
----------------------------------------------------------------------------------------------------
linf
scalar
error     EOC
2.71e-04  -
3.59e-05  2.92
5.22e-06  2.78
6.51e-07  3.00
8.67e-08  2.91

mean      2.90
----------------------------------------------------------------------------------------------------
Dict{Symbol, Any} with 3 entries:
  :variables => ("scalar",)
  :l2        => [2.84821]
  :linf      => [2.90261]

@sloede @andrewwinters5000 @gregorgassner: I implemented a first draft of FD methods. I would like to get feedback before polishing this since I have no motivation to work on this if it will be rejected anyway since people have some strong opinions on coding/naming conventions (cf. #616).

This looks very nice to me. I also looked through the changed files, looks all good to me so far.
Couple of questions:
(i) Did you test the multi-element? Is your EOC test done by increasing the SBP nodes inside the element, or by increasing the number of elements?
(ii) General question: Would it make sense to have Strong Form (Volume, Surface) also for the DGSEM operator?
(iii) The current volume integral implementation is with mul!() as far as I can tell. It seems to me, that this uses the full (non-sparse) D matrix to do the multiplication. I assume, it will be relative straight forward in future, to specify the volume integral further with the specific optimized implementations for a given SBP D matrix?

Thanks for the encouraging feedback :+1:

(i) Did you test the multi-element? Is your EOC test done by increasing the SBP nodes inside the element, or by increasing the number of elements?

I tested multiple elements connected via strong form surface terms/integral. The convergence test increases the number of elements since our convergence_test is constructed having only DGSEM in mind (added to the TODO list, maybe for a future PR).

(ii) General question: Would it make sense to have Strong Form (Volume, Surface) also for the DGSEM operator?

It's definitely an option. However, we don't have a use case for it right now and the weak form should be more efficient. Thus, I don't object implementing it for DGSEM but I think we shouldn't do it unless we have a use case.

(iii) The current volume integral implementation is with mul!() as far as I can tell. It seems to me, that this uses the full (non-sparse) D matrix to do the multiplication. I assume, it will be relative straight forward in future, to specify the volume integral further with the specific optimized implementations for a given SBP D matrix?

I have specialized mul! in SummationByPartsOperators.jl. Thus, it's a reasonably efficient version of in-place multiplication, taking the sparsity structure into account. Some benchmarks (running on GitHub actions) are available at https://ranocha.de/SummationByPartsOperators.jl/stable/benchmarks/.
Nevertheless, this version of the strong form volume terms/integral is only a first draft. To optimize it further, we should compare different versions, including a more intrusive approach (basically fusing the loops). But that's not necessary right now and left for future PRs (since honest optimization will take some time).
Some numbers: Using julia --threads=1 --check-bounds=no:

trixi_include("examples/2d/elixir_advection_extended.jl", polydeg=2, n_cells_max=10^6, initial_refinement_level=8, tspan=(0.0, 1.0)) with 589_824 DOF has a PID of ca. 7.7e-9. The L² error is 9.0e-08.
trixi_include("examples/tree_2d_fd/elixir_advection_extended.jl", initial_refinement_level=3, N=96, abstol=1.0e-8, reltol=1.0e-8, tspan=(0.0, 1.0)) with 589_824 DOF has a PID of ca. 9.3e-9. The L² error is 6.3e-08.

That's not too bad for an un-optimized implementation of the FD methods, I think. In the end, the FD version is much faster since it needs fewer time steps (900 RHS calls for FD vs. 4.80k RHS calls for DGSEM).

I have specialized mul! in SummationByPartsOperators.jl. Thus, it's a reasonably efficient version of in-place multiplication, taking the sparsity structure into account. Some benchmarks (running on GitHub actions) are available at https://ranocha.de/SummationByPartsOperators.jl/stable/benchmarks/.

Oh, wow!

If you promise to finish the rest as well, I'd suggest to consider merging this with the current feature set and doing restructuring/cleanup/renaming in a separate PR

This PR should be in a good shape and more or less ready to merge after another round of reviews. Other features and extensions can be added in new PRs later.

Tests only fail because of the following warnings on Windows:
WARNING: importing deprecated binding Colors.RGB1 into PlotUtils.
WARNING: importing deprecated binding Colors.RGB4 into PlotUtils.

How shall we handle that?

Add it to the list of exceptions for our tests?
Load the package outside of the test command checking for warnings?
Something else?

I'll merge this since the failure on windows-mpi is spurious and not related to this PR.


[Feature request] "Popular" projects?

This is a really cool project!
I was looking at the India figures and they are astonishing. 14M git pushes. 30M repositories. 12M developers. 450k orgs. In the FOSS communities that we're a part of here in India, a conversation that often comes up is the low number of widely used FOSS projects originating from here. But these numbers are hard to reconcile with that observation (anecdotal, of course) and perhaps indicate a different reality altogether.
It would be great if there was a way to get visibility into "popular" projects from geographies. Stars, forks etc. don't of course directly imply quality, usage, or even popularity, but may serve as an indicator. Perhaps there are other data points that serve as indicators.
Thank you

Thanks @knadh! My intuition (could certainly use in depth study) is that these observations are reconcilable:

It often takes years for an open source project to become widely used (there are counterexamples of course, but usually it's a slow buildup, even for say Linux, which started in 1991).
India's developer community has been growing rapidly, so I'd expect current cumulative and activity numbers to be higher than the number of widely used projects well known to have originated from India.
Metrics > originating projects might even be a sign of best practices such as a preference for contributing upstream. It'd be super interesting to find a way to test this.

My guess is that among newer trending projects, the proportion originating from India (or other economy with rapid developer growth, but obviously India is the largest) would be higher than the proportion across all well known projects. Of course this really gets to your feature request: what popular projects are associated with an economy (given that list, it'd be easy to identify which are newer).
Unfortunately, at least for now, I don't see an immediate path to addressing the feature request in this project, which is for aggregate rather than specific (such as identifying specific repositories) metrics. Identifying specific repositories with an economy in the same way we do for aggregate reporting here would have two problems:

Privacy. It'd be hard (at best, and probably impossible for most repos) to do so without revealing the likely location of developers contributing to a specific repo.
It might obtain some surprising results for individual repos as developers move, maintainers are added, etc. The perceived "originating from a geography" for a specific repo probably requires some judgment/may be subjective to some extent, vs mode of developers with triage or above access used for aggregate metrics.

One way to collect such repos (which might be seeds for further study) is through a collection like https://github.com/collections/made-in-india or awesome-list style repo like https://github.com/IonicaBizau/made-in-india
Those are just some initial thoughts; I welcome further discussion.


Add wiki so I can add a Maven pom.xml

Thank you very much for this repo, it made things much easier for me using Milton.
It took me a while to get it working using Maven (I'm not familiar with Gradle). I'd like to share my pom.xml that works to save others time. I was hoping there was a wiki I could put it on, but perhaps it's not enabled for this repo. Would you consider adding one?
Here is my pom.xml:
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
	<modelVersion>4.0.0</modelVersion>
	<groupId>webdav-embedded-server</groupId>
	<artifactId>webdav-embedded-server</artifactId>
	<version>0.0.1-SNAPSHOT</version>
	<repositories>
		<repository>
			<id>milton-repo</id>
			<url>http://dl.bintray.com/milton/Milton</url>
		</repository>
	</repositories>
	<build>
		<plugins>

			<plugin>
				<artifactId>maven-compiler-plugin</artifactId>
				<version>3.2</version>
				<configuration>
					<source>1.8</source>
					<target>1.8</target>
				</configuration>
			</plugin>

		</plugins>

	</build>
	<dependencies>

		<dependency>
			<groupId>org.apache.commons</groupId>
			<artifactId>commons-lang3</artifactId>
			<version>3.7</version>
		</dependency>

		<dependency>
			<groupId>org.eclipse.jetty</groupId>
			<artifactId>jetty-server</artifactId>
			<version>9.0.0.v20130308</version>
		</dependency>

		<dependency>
			<groupId>com.beust</groupId>
			<artifactId>jcommander</artifactId>
			<version>1.72</version>
		</dependency>

		<dependency>
			<groupId>io.milton</groupId>
			<artifactId>milton-server-ce</artifactId>
			<version><IP_ADDRESS></version>
		</dependency>

	</dependencies>
</project>

Thanks for your suggestion!
I have enabled the Wiki for the repository. If you like, you can add your pom.xml to the Wiki yourself. Otherwise I will do that today evening, together with a more complete example how to use the library with gradle.

Done

I misinterpreted your code from above: I thought it would be a pom.xml to use the webdav-embedded-server in another project as an external library. As I wrote, I added wiki pages for that.
But instead, as I now realised, your pom.xml is code for building this project with maven. Sorry for that error. So in this case: The build-system of this library is gradle and I think it would be confusing to provide a second way to build the library. Besides that, I don't see any requirement to build the library yourself, as I provide compiled versions of the library on JCenter. I hope the wiki pages I added clarify that you don't need to know gradle to use this library in your own project.
If you wanted to use the webdav-embedded-server in its standalone version: I additionally added the compiled version to the Release page for easy download without the need to compile it.

Oh I didn't realize there was a precompiled release. In that case yes I don't want to confuse your users by adding such samples.
Maybe some instructions on building with Gradle building might be useful. But otherwise everything's fine.

I should open a new issue for this, but any chance you could upload a jar-with-dependencies or uber-jar? I'd like to use the server as-is, rather than as a library but getting all the dependencies and supplying them at the command line is a bit of work.

I created #2 for this