Implement Navie

Navie Explain
Interactions
~Explain via refactorings:
In VS Code, a new refactoring action allows the user to select text, then Explain with AppMap AI. This action will pop open the web view, providing the selected text as the question prop (described below) to pre-fill the prompt input.~
Explain via command:
This opens the webview. In JetBrains, this might be an additional option under the AppMap main menu.
Technical changes
Launching index:
The index process should now launch with the additional argument --port 0. This requests the index process to listen for JSON RPC requests, with the OS allocating a port.
When the server becomes available, a message will be logged to stdout. Parse stdout for /^Running JSON-RPC server on port: (\d+)$/ and record the port bound for that process.
Ensure the APPMAP_API_KEY environment variable is set to the user's API key. This is the same API key returned via authentication.
Opening the Webview:
Instead of using the Chat page, ChatSearch is used.
The following props are needed:
appmapRpcPort - The port to connect to. This is derived from the regex above.
apiKey - The user's API key retrieved via existing authentication.
savedFilters - Saved filters shared with the AppMap view. These may change, and updates should be handled similar to the AppMap webview.
Optional:
question - Text to pre-load the input field with. In VS Code, this is used by the refactor action to populate the input with the selected text.
If the RPC port has not yet been detected, do not open the window. In VS Code, a notification appears that states:

AppMap Explain is not ready yet. Please try again in a few seconds.

If multiple modules are open in the same window, a selector opens, requesting the user to select a module to communicate with. It's expected that each module already runs its own index process, so this step is to disambiguate which port to connect to.
Content-Security-Policy updated to include:
connect-src http://localhost:${rpcPort} https://api.getappmap.com

VSCode References

Backend initialization and message handling of the web view
https://github.com/getappmap/vscode-appland/blob/develop/src/webviews/chatSearchWebview.ts
Chat search webview front end
https://github.com/getappmap/vscode-appland/blob/develop/web/src/chatSearchView.js
Index process initialization and parsing
https://github.com/getappmap/vscode-appland/blob/develop/src/services/indexProcessWatcher.ts

:tada: This issue has been resolved in version 0.56.0 :tada:
The release is available on:

v0.56.0
GitHub release

Your semantic-release bot :package::rocket:


Composition api migration

Initial work to use vue composition api.
This will first target vtk views, as it should help centralize similar logic to make debugging and testing easier.

[x] VtkThreeView
[x] VtkTwoView

fyi @timthirion

Here are a few notes about this migration that you'd be interested in knowing.
First, why bother with this? Lots of tutorials for vue 3 and react hooks will point out that current class-based component APIs (and options-based APIs for vue) suffer from the same problem: spreading intermixing unrelated lifecycle-aware logic.
For instance, let's look at VtkTwoView. In that component, we have a resize listener that is lifecycle aware, meaning it needs to listen when the component is mounted and needs to stop listening when unmounted. The logic for that is spread across three different lifecycle hooks: created (here), mounted (here), and beforeDestroy (here). Not only is this logic spread across different parts of the component, it's intermixed with other lifecycle-aware logic.
Now, with the composition API, we can instead extract that logic into its own self-contained unit/function, while maintaining lifecycle hooks. You can find all the code in one location here. Sure, it seems like more code to accomplish what we had prior, but using it in a component is suddenly much more reusable and succinct, as can be seen in VtkTwoView.
The gist of this is that there should ideally be less work done towards debugging units of logic now that everything should be in one place. There should be less noise to push aside than with the previous implementation when identifying where the relevant code bits are for some functionality.
In addition, this should ideally help with testing. The classic adage of testing units of functionality is much more tractable with the composition API, since we no longer have to worry about needing mocks for unrelated functionality. My goal is to write more tests to accompany these bits of functionality.

Here are a few notes about this migration that you'd be interested in knowing.
First, why bother with this? Lots of tutorials for vue 3 and react hooks will point out that current class-based component APIs (and options-based APIs for vue) suffer from the same problem: spreading intermixing unrelated lifecycle-aware logic.
For instance, let's look at VtkTwoView. In that component, we have a resize listener that is lifecycle aware, meaning it needs to listen when the component is mounted and needs to stop listening when unmounted. The logic for that is spread across three different lifecycle hooks: created (here), mounted (here), and beforeDestroy (here). Not only is this logic spread across different parts of the component, it's intermixed with other lifecycle-aware logic.
Now, with the composition API, we can instead extract that logic into its own self-contained unit/function, while maintaining lifecycle hooks. You can find all the code in one location here. Sure, it seems like more code to accomplish what we had prior, but using it in a component is suddenly much more reusable and succinct, as can be seen in VtkTwoView.
The gist of this is that there should ideally be less work done towards debugging units of logic now that everything should be in one place. There should be less noise to push aside than with the previous implementation when identifying where the relevant code bits are for some functionality.
In addition, this should ideally help with testing. The classic adage of testing units of functionality is much more tractable with the composition API, since we no longer have to worry about needing mocks for unrelated functionality. My goal is to write more tests to accompany these bits of functionality.

 Which version of node/npm are you on?

I have npm 6.14.4. Is this happening on an npm install after switching to this branch? If so, there might be some minor dependency updates that change things, but I don't know why it would be a large diff.

A ha, I'm on npm 7.5.0. Should we pin to a specific version?

The only update I've made is fixing the versions of the packages. Other changes will be in separate PRs.

LGTM. You'll probably want to create issues for the coming changes if you haven't already.

Yep, I've made issues to address the outstanding concerns.


Cr 934 invalidate endpoint

Motivation and Context
CR-934 moves functionality from PUT endpoint to POST invalidate endpoint.
What has changed

Move the PUT endpoint back to "Dummy" status.
repurpose the original status-change code for the new POST endpoint
usual unit tests updated.

How to test?

usual unit tests
Cucumber test changes are coded and will be in subequence PR.

tested in DEV with the forthcoming cucumber tests.


Remove unnecessary AzureDiscovery class

Codecov Report

Merging #5659 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #5659      +/-   ##
============================================
- Coverage     82.86%   82.84%   -0.02%
+ Complexity    11800    11794       -6
============================================
  Files          1391     1390       -1
  Lines         45359    45357       -2
  Branches       5629     5629
============================================
- Hits          37585    37576       -9
- Misses         5157     5167      +10
+ Partials       2617     2614       -3

Impacted Files
Coverage Δ
Complexity Δ

...io/crate/azure/management/AzureComputeService.java
85.71% <100%> (ø)
0 <0> (ø)
:arrow_down:

...va/io/crate/azure/plugin/AzureDiscoveryPlugin.java
75% <100%> (ø)
5 <0> (ø)
:arrow_down:

...very/src/main/java/io/crate/azure/AzureModule.java
28.57% <20%> (ø)
8 <0> (ø)
:arrow_down:

...ate/azure/discovery/AzureUnicastHostsProvider.java
55.46% <20%> (ø)
14 <0> (ø)
:arrow_down:

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...arch/indices/recovery/BlobStartPrefixResponse.java
66.66% <0%> (-33.34%)
3% <0%> (-2%)

...in/java/io/crate/lucene/match/CrateRegexQuery.java
43.47% <0%> (-30.44%)
4% <0%> (-4%)

...ate/planner/node/dql/PlanWithFetchDescription.java
80% <0%> (-10%)
12% <0%> (-2%)

core/src/main/java/io/crate/types/ArrayType.java
73.84% <0%> (-7.7%)
24% <0%> (-2%)

.../elasticsearch/action/bulk/BulkShardProcessor.java
70.42% <0%> (-3.88%)
44% <0%> (-3%)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0403e75...3e44e51. Read the comment docs.


Update backup-azure-antivirus-scan-exclusion-rules.md

fix a formatting mistake (missing line break causes two items in the list to show on one line)
edit: added a commit to change a weird "you've" into "you have"

@AbhishekMallick-MS
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

I misunderstood the text! It shouldn't have changed. Closing.


Add support for multiple user activities

Summary
This PR adds the capability to handle multiple activities on a User object. Documentation needs improving and we should discuss the use of ActivitySet vs exposing the filtering at the User level.

Added
ActivitySet
Activity
Activity::Secrets
Activity::Timestamps
Activity::Party
Activity::Assets
User#activities
Deprecated
User#stream_type
User#stream_url
User#game

This was merged via shardlab/discordrb@0c814527ab582e6bea31eb17a30f697f42b12149 in the new repo and released in v3.4.0 and can be closed.


define devToolsWebContents for use from remote module

Fixes #1186 , love the way remote lib has been written :) but is this variable needed when we already have getDevToolsWebContents exposed ? Now if someone uses window.getDevToolsWebContents it wont have the emitters attached but still return the right contents, so would it be good to return devToolsContents from there instead of openDevTools ?

Using a devToolsContents property implies that users should always get the it via calling browserWindow.devToolsContents instead aliasing it to a new variable. This implication is necessary because the WebContents object of devtools will change when devtools is closed and reopened, we should probably take a better approach, but since no one is complaining I think current behavior is fine.


Button addition in the testimonial (home page)

GSSOC'23
Addition of button in the testinomial page. As one can look that the testomial button are li component for testinomial 1 and 2 so i wanted to change it!

Issue:

Hey there @Anupkjha2601. Please assign this issue to me to make the work done, Thank You!

hey @Anupkjha2601 1 can you please assign me this issue under gssoc!


Header problem

User logo and night mode should be on the left side
The problem only occurred when the display is medium or small screen
link to component: https://github.com/noams24/Kef-Code/blob/main/src/layouts/partials/Header.tsx

Hello,
The issue should be resolved, and the night mode is now positioned on the left side.

Hello,
The issue should be resolved, and the night mode is now positioned on the left side.

Can you make pull request with that changes that you have made?

@ozn1907 Thanks bro! 👍


MIAD-177 performance improvement

Codecov Report
Attention: Patch coverage is 82.89474% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.14%. Comparing base (2732830) to head (c6ce108).

Files with missing lines
Patch %
Lines

...alertsapi/config/HmppsAlertsApiExceptionHandler.kt
20.00%
7 Missing and 1 partial :warning:

...ps/hmppsalertsapi/client/RetryNetworkExceptions.kt
50.00%
1 Missing and 1 partial :warning:

...sapi/client/prisonersearch/PrisonerSearchClient.kt
94.44%
0 Missing and 1 partial :warning:

...ertsapi/config/AlertRequestContextConfiguration.kt
96.87%
0 Missing and 1 partial :warning:

...mppsalertsapi/resource/PrisonerAlertsController.kt
50.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #231      +/-   ##
============================================
- Coverage     93.37%   93.14%   -0.23%
- Complexity      484      485       +1
============================================
  Files            82       82
  Lines          1675     1692      +17
  Branches        100      101       +1
============================================
+ Hits           1564     1576      +12
- Misses           71       72       +1
- Partials         40       44       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Reload (unchanged) notebook when it changes on disk

open a GH issue notebook
in the integrated terminal open the same notebook in vim
in VIM make changes and save
go to the notebook and save
🐛 the error shows

@jrieken we currently didn't do notebook content auto update yet, right now we only compare on save.
Originally posted by @rebornix in https://github.com/microsoft/vscode/issues/109594#issuecomment-749135522

Looking into this reveals a bigger issue. Whenever we call _loadFromProvider we create a new notebook (NotebookTextModel) but we don't dispose the existing one. This would be OK we call _loadFromProvider only ever once but it is called repeatedly via revert (or whenever using the forceReadFromDisk-flag). This problem will be amplified when we start reloading whenever the underlying file changes on disk.

Use the steps below (https://github.com/microsoft/vscode/issues/114263#issue-784977891) and make sure that

notebooks refresh when changed on disk and when not having unsaved changes
notebooks don't refresh when there are unsaved changed


Sealer builds images of k0s and k3s

Sealer builds images of k0s and k3s
Type: feature request
I hope to deploy k0s and k3s through the sealer, and I need to build relevant images

k0s is already supported, and k3s is still in preparation
@manong123456

@manong123456 Sorry for reply lately! For k0s cluster build, you can see http://sealer.cool/docs/advanced/customize-cluster-image.html#for-k0s,
For deployment, you can see http://sealer.cool/docs/advanced/run-with-clusterfile.html#for-k0s.
If you need a base k0s clusterImage, you can see http://sealer.cool/docs/sealer-images/cluster-images.html#k0s-cluster-image-list.
Hope that helps!


Eyeglass import issues

I try to @import normalize or normalize/import-now,
but eyeglass alone doesn't seem to be able to pick it up.
I prepared a test repo so one can debug it directly:
https://github.com/strarsis/normalize-scss_test/tree/master

Thanks for the test repo! I'll take a look this week. (or someone can beat me to it and do a PR!)

Awesome, thanks for the fix!
The new release doesn't seem to appear in npm yet,
I will test it when it becomes available.

It's out. https://www.npmjs.com/package/normalize-scss


Can you do a one to many mapping with the JDBC template?

Yes you can I probably need to add some doc for that.
you can do one to many with the row mapper as it cannot do aggregation but the JdbcTemplateMapperFactory can return a ResultSetExtractor or PreparedStatementCallBack
	@Test
	public void testPreparedStatementCallback() throws SQLException, ParseException  {
		PreparedStatementCallback<List<DbObject>> mapper = JdbcTemplateMapperFactory.newInstance().newPreparedStatementCallback(DbObject.class);
		List<DbObject> results = template.execute(DbHelper.TEST_DB_OBJECT_QUERY, mapper);
		DbHelper.assertDbObjectMapping(results.get(0));
	}

	@Test
	public void testResultSetExtractor() throws SQLException, ParseException  {
		ResultSetExtractor<List<DbObject>> mapper = JdbcTemplateMapperFactory.newInstance().newResultSetExtractor(DbObject.class);
		List<DbObject> results = template.query(DbHelper.TEST_DB_OBJECT_QUERY, mapper);
		DbHelper.assertDbObjectMapping(results.get(0));
	}

that can do that,
I'll keep the ticket open until I add some more documentation.
The spring jdbc support uses the jdbc mapper under it, so it can to anything sfm-jdbc can do. it just provide wrapper for the spring jdbc api.
if that still does not work, could you send me the spring jdbc code you are using.
PS: the keys need to match the column name coming from resultset not the property name - unless you add an alias.

also checkout https://arnaudroger.github.io/blog/2017/06/13/jdbc-template-one-to-many.html

update doc


Publish via email<EMAIL_ADDRESS>

Allow publishing via email

Done in https://github.com/binwiederhier/ntfy/pull/67/files


Window functions

Hello everyone,
Does anyone know if there is any plan to make window functions available in Doctrine ?

doctrine supports many SQL database platforms and it seems as not each of them supports window functions, so it's unlikely that doctrine will provide native support for that.
If you'd like to do vendor-specific queries, there are two options:

use a native query and hydrate manually (http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/native-sql.html)
write your own DQL extension which makes this feature available in DQL queries (http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/dql-user-defined-functions.html)

Indeed, just go with SQL when doing this sort of stuff.
Closing here as Can't Fix


Minor refinements to readme

This commit makes a few minor refinements to the README file
so that the deployment example shown there may be followed
blindly doing a copy and paste.

The change is using the model name as a proxy for the cloud type.

Thanks. There was a copy/paste typo. The model name for prometheus deployment was incorrect.
The changes are

Add -k8s suffix since by default that is what happens if you do not specify application name
Add controller name in offer and consume since Juju protests otherwise
Add the missing deployment command for prometheus-k8s


Security & Format update

Bump dependencies, most importantly request to address a security issue, see https://github.com/Vinfall/SteamWishlistCalendar/security/dependabot/1 and https://github.com/psf/requests/pull/6655
Update ics package to comply with the new RFC 5545 which obsoletes RFC 2445 (which ics 0.7.2 used), see https://github.com/Vinfall/VNDB-Calendar/commit/d9e36db40d53b4361105b4d567e497a892eb8a68. The generated iCalendar is a bit different but still backward-compatible. With this, SteamWishlistCalendar should now work in more clients.

Thanks a lot!


add thead and tbody to facilitate sorting

If you add a couple tags, the table can easily be sorted by most js table sorting libraries. Helpful to find the last executed or most often run cron job.

@keithbentrup thanks for the contribution, pull request has been merged


test pr build

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EM-4787
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Not required


Update README.md

added a 'Troubleshooting' section with a tip on solving Kotlin DSL accessors generation issues caused by IDE

Thanks for creating this awesome template. There's a nasty bug that might occur with Kotlin DSL accessors
not being generated properly (unresolved references) that affects buildSrc.
Clearing .gradle/build directories or performing "Invalidate caches and restart" in IDE did not work.
The only solution is apparently manually deleting IDE caches as mentioned here.


Update Javascript library repo locations in README

Changed closure-linter and python-gflags from old Google Code SVN locations to Google GitHub locations in javascript README

Thanks!


[REFACTOR] Avoid deprication of Display.getWidth()/getHeight().

Hi, Display.getWidth()/getHeight() are depricated.
So, I tried replacing that for DisplayMetrics.widthPixels/heightPixels.
Thank you for reading.

Looks good, thanks!


StorageInterface instantiates PRI once

ProjectedRowInitializer is kind of expensive to create. It's documented as such:

More specifically, ProjectedRowInitializer will calculate an optimal layout for the given col_ids and layout, treating the vector as an unordered set of ids to include, and stores the information locally so it can be copied into new ProjectedRows. It works almost like compilation, in that the initialization process is slightly more expensive on the first invocation but cheaper on sequential ones. The correct way to use this is to get an initializer and use it multiple times. Avoid throwing these away every time you are done.

However, StorageInterface currently creates one every time GetTablePR() is called -- basically every table operation. It should be instantiated once and stashed as a member in StorageInterface which is exactly what this PR does.
However, I'm seeing weird behavior when I run TPC-C now where the table oids being referenced are sometimes zero. Based on my understanding on StorageInterface life cycle, we should be safe to make this change, so I might need @lmwnshn or @tanujnay112 help to understand what's going on.

Also, we may just end up closing this in lieu of fixing it in the new TPL2 port.

The TPC-C issue is that the delete translator doesn't need a PRI in the StorageInterface and passes a dummy array of col_oids, but because this PR moves the PRI into the StorageInterface constructor, we explode trying to request a PRI for dummy oids. Proposed solutions: need_PRI flag for StorageInterface like need_indexes, maybe pass an empty array, or special case in the storage layer. I don't like the last option.

Proposed solutions: need_PRI flag for StorageInterface like need_indexes, maybe pass an empty array, or special case in the storage layer. I don't like the last option.
After talking with Prashanth, I went with this option and relaxed the semantic check on StorageInterface's constructor in compilation to allow an "undefined length" array (i.e. 0).

Benchmark failure is spurious.


Mark operation output and request/response body enums as @frozen

Since it's not expected that the generated code should support library evolution, we could add @frozen to all of the generated enums. This would greatly improve the ergonomics of switching over enums in the generated code.
Borrowing an example from another issue:
switch result {
case let .ok(reponse):
    case let .json(payload):
        print(payload.body, payload.headers)
    @unknown default:
        break
    }
@unknown default:
    break
}

would become
switch result {
case let .ok(reponse):
    case let .json(payload):
        print(payload.body, payload.headers)
    }
}

@PadraigK thanks for the suggestion.
We do generate @frozen enums in a bunch of places already^0[²] so potentially we might be able to do it for the response body enum too.
@czechboy0 might have some opinions here. Assuming there's no reason not to, is it something you'd want to work on?

Yeah we should add it to all our enums, I don't think there are any downsides.

Great, should be a simple change in translateRequestBodyInTypes. I'll do it on Monday, unless someone else beats me to it.

@PadraigK I've opened a PR for this.
Thanks again for taking the time to try out the generator and for filing the issue!

I discussed this some more with some folks and there's some feedback that we might not want to do this.
To summarise, they highlighted that adopters should only be forced to add the @unknown default case if their target is being compiled with library evolution and this isn't something we should be encouraging. They also suggest that, since @frozen is used for library evolution use cases, using it anywhere makes an implication that we're in the library-evolution game, which we are not.
As I highlighted earlier in this issue thread, we are currently already using @frozen in a couple of places. These are for enum (OpenAPI enum) and OneOf types.
I think we should take a consistent approach here. My PR moved us in the direction of consistent application of @frozen to all places where we generate a Swift enum with cases. But I think we should also consider whether this was completely wrong, and we should instead be removing it everywhere?
//cc @czechboy0 @FranzBusch @dnadoba

Since it's not expected that the generated code should support library evolution, we could add @Frozen to all of the generated enums.

@PadraigK  @frozen only has an effect if library evolution mode is turned on:

When the compiler isn’t in library evolution mode, all structures and enumerations are implicitly frozen, and this attribute is ignored.
https://docs.swift.org/swift-book/documentation/the-swift-programming-language/attributes/#frozen

Adding @frozen is a no-op without library evolution mode turned on and @unknown default is not required.  How do you integrate/build the generated code and the OpenAPI runtime library?

I'm for adding it everywhere, since it's a no-op to code not using library evolution, and solves a major usability issue for folks using library evolution. It's asymmetrical, so for pragmatic reasons here, I'd do the thing that unblocks a set of adopters, and doesn't hurt other adopters.
That said, we should probably also add a paragraph to our docs about how to use generated code, and mention that the generated code is not designed for having a stable ABI (like we already call out the lack of a stable API).

I'm for adding it everywhere, since it's a no-op to code not using library evolution, and solves a major usability issue for folks using library evolution

I don't think I agree with this. The problem is if we start adding annotations for library evolution such as @frozen it conveys the feeling that we are indeed supporting ABI stability in both the generated code but also our runtime library. This is simply not true and would be a significant piece of work. While adding @frozen is silencing some of the errors and warnings for people it doesn't remove the danger of ABI mismatches at runtime.
However, adopters do have a way out of this. When they want to ship an ABI stable framework that uses generated code and the runtime they just need to make sure that all imports are marked with @_implementationOnly. This should make sure to hide the dependency for them and that they don't use any of the types in their public interface.

After talking with @czechboy0 about this offline.

We've not really added any configuration options so far, but this is not the first issue that could justify adding one. I'd be open to us starting to use it more.

I think we should think about how we could add configuration for cases where users genuinely need both options, in a backwards-compatible way. Here, I'm not sure it's needed yet, as always adding @frozen covers both sets of users (as without LE, it's ignored), the only difference is strictness.
As you can imagine, the cost of each configuration option in the generator is adding a whole axis to the test matrix, so it's not cheap, and each of them need to be well justified. I'm not saying this one isn't, just that we should start without it (make the behavior consistent, add @frozen to the missing places, since we already add it some places today), and later if we still feel not generating them is a valuable feature, add an opt-in configuration option to skip them.

So where are we landing on this one? Should we merge #109 as-is (i.e. generating @frozen by default, with no configuration option)? //cc @FranzBusch @czechboy0


Fungible token: always use default icon for now

@kcole16 @corwinharrell @vgrichina - looked at the contract and looks risky to just use whatever is being provided as icon right now as it could affect the UI negatively. I'm setting it to always use the default token icon for now and will update once we see what's being provided.

looks risky to just use whatever is being provided as icon right now as it could affect the UI negatively

@Patrick1904 can you elaborate?


Unity UI text edit field should make virtual keyboard appear

Overview
Open the HandInteractionExamples scene and select a text edit control. This should cause a virtual keyboard to show up by default.
Mixed Reality Toolkit Release Version
MRTK v2

I've hit this pain as well. It would be nice to have this behaviour just work by default. Android and iOS seem to work without any additional logic.

Removing Yoyo since she is not actively working on this.

@keveleigh is this a bug in Unity?

Marking as GA blocker because many partners actually use Unity UI

@julenka / @keveleigh any update on this one?

I'm on vacation until 8/8, I don't have any updates. I believe we assigned this to Kurtis since the issue is actually a problem with how Unity makes the Windows API calls for InputPane.show.

I believe we assigned this to Kurtis since the issue is actually a problem with how Unity makes the Windows API calls for InputPane.TryShow.

Per the above, moving this to "consider for next iteration"


Terminal's pty host process is unresponsive. Terminal crashes and Remote SSH disconnected.

VS Code Version: 1.55.0 (Stable)
OS Version: Windows 10 21H1 x64

Steps to Reproduce:

Use VSCode a while or open few VSCode instances close few reopen few. Basically make sure terminal is opened in each instance by default then close.
Terminal will crash. SSH will disconnect.

Honestly, I wouldn't mind the crashes for terminal but this causes my Remote SSH disconnects from the server and I have to reload all windows one by one. Even local VSCode crashes, all other open windows disconnects if they are connected to a SSH Server.

Does this issue occur when all extensions are disabled?: Yes

Update
In my case, If I open second VSCode instance i got this error and all SSH sessions are terminated. No need to open few or close few. Just second instance triggers.
And sometimes, I had to restart my Windows because after receiving this error, even If I open 1 (one) instance of VSCode at a time, it stills disconnect from remote and unresponsive terminal error given. So, to be clear, once you get this error, its permanent. Since 2 hours I'm using single VSCode instance but I keep getting same issue every few minutes. I am going insane here.

I am also getting this error occasionally since last 2-3 updates after the VSCode team did major changes to make the terminal faster.

I believe this is already fixed, can you see if you can reproduce in the Insiders build?


Reactivate static libs

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

If there is no fundamental needs of disabling the statics libs, this PR only reactivate it to solve: https://github.com/conda-forge/qhull-feedstock/issues/18 and in turn allow package that use qhull at build time to compile again (see e.g. https://github.com/conda-forge/hpp-pinocchio-feedstock/pull/29)

@conda-forge-admin, please rerender

@xhochy I think it is ready to merge, if it is ok to re-activate de statics libs for downstream package requiring qhull at build time :)

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@ymontmarin If you're a bit patient, I can build an alternative later today that separate the dynamic lib out and changes the run_exports.

@xhochy Sorry, I have been a bit messy in my commits, but this looks to work and be ready for merge. I believe it follows the CFEP 18.
However, if you have any enhancement suggestion I can be patient, of course :)

The qhull-static package only contains info directory.
When adding qhull-static as a dependency, the build is not working (missing Qhull::qhullcpp target).
I will recreate a PR to try to fix that.


Label Margin inside ActionBar not working

here is playground demo https://play.nativescript.org/?template=play-ng&id=FpaWzb&v=33
i'm trying to apply  margin to label inside ActionItem but for some reasons it is not working.
<ActionItem>

	</ActionItem>

i also noted one more unexpected behaviour.
when applying margin using css it is still not working.
ActionBar Label{
    margin:10;
}

but here is the catch if i add one more styling padding:10 then both works as expected both applied successfully.
ActionBar Label{
    padding: 10;
    margin:10;
}

Hi, @bhavincb,
In this case, the Label should be set inside a Layout container, which will allow the margin to be set properly. Example:
<ActionBar title="Home" class="action-bar">
	<ActionItem>

	</ActionItem>

	<ActionItem>
		<StackLayout>

		</StackLayout>
	</ActionItem>
	<ActionItem>

	</ActionItem>
	<ActionItem>

	</ActionItem>
	<ActionItem>

	</ActionItem>
</ActionBar>

hii @tsonevn ,
yes i checked it and working pefectly.
but as i said there is some glitch or bug.
because below class has no effects
ActionBar Label{
    margin:10;
}

and if i had padding:10  then it will work with both padding and margins.
below is working class code
ActionBar Label{
    padding: 10;
    margin:10;
}

Hi, @bhavincb,
I have checked again the case with the margin and padding.
On iOS, only the padding will be applied to the Label component.
On Android the padding will be appropriately applied as well, however, the margin will not be respected on the left or right sides. The margin will be attached only to the top. Also, there is no functionality, which allows setting up the margin to the label, while it is used directly in the ActionItem. In this case, it is not clear what it will happen while setting up a margin to the component on different Android devices.
Regarding that, in my previous comment, I have mentioned, what is the correct way to setup margin to a Label in ActionBar item.

hii @tsonevn ,
thank you for detail information regarding issue. As you mentioned there is problem with ActionItem. so please mark this as Bug or add some information to official doc regarding this. so that it help others in future.

Hi, @bhavincb,
Thank you for writing us back.
Indeed we will extend the ActionBar articles for both ns Angular and non-Angular and will describe that this case with margin and padding.

hi @tsonevn ,
should i close this issue? or this will be feature request and will be added to nativescript in future?

Hi, @bhavincb,
I think that this issue should be closed. We will describe this scenario in the docs and will clarify what the right approach is.


Feature: Hide sign-in and create account buttons

To avoid even less confusion and because it looks neat, I like to request to be able to hide the sign-in and create account buttons. See simple mock-up in the screenshot.

How would the user log in to other servers then ?

FediAct is meant for servers you don't need to log-in. If someone has multiple accounts they can whitelist those servers.

I understand the request, yet there are some users who would prefer it to stay and also, it does not bring a great value while adding effort to maintain. Might reconsider this in the future, but for now I'll leave the buttons.
Thanks for posting anyways!

That's a shame. It could be opt-in.


Fix for Bandcamp album and track playback

Currently on lp 1.3.50 if you try to queue a Bandcamp track or album the "Band information not found on the Bandcamp page." friendly traceback is thrown as band_url is not found in the page response any more. This change corrects it to the linkback string instead. Unfortunately on album page sources this is styled as linkback: while on track pages it is linkback : with an extra space inbetween the word and the colon, so there is another line for checking the other linkback string condition.

LGTM

It looks like Bandcamp page formats changed yet again and this fix does not work now.
FTR, the new bandUrl string is contained in  in the new page, in the a href for that span.
On an album page I don't see an easy way to extract the song list so I'm not sure how to go about that there.


Add Clip Type export manifest column

In the recent DAWFileKit refactors, it's now easy to filter clip types.
It would be fairly easy to add the ability to:

extract extracted markers only from certain clip types, or
extract all markers except for markers on certain clip types

This would be similar to the ability to filter by roles, but it would be more broad. Would this be useful?
To be clear, the following are the clip types that could be specified. Some may be a little vague or unfamiliar to average users, so an explanation could be accompanied with them.
https://github.com/orchetect/DAWFileKit/blob/1461eec9441c2eed644a0d6622188975fa5632e5/Sources/DAWFileKit/FinalCutPro/FCPXML/Story/Clips/Meta/FCPXML ClipType.swift#L13-L45

This would be similar to the ability to filter by roles, but it would be more broad. Would this be useful?

It would be definitely be useful. We can have one of two approach?
For Example 1 - The switch method
--include-clip-type <all, audio, audition, gap, clip, liveDrawing, multicam, compound, synchronized, title> (default: all)

I think Example 1 creates more complexity and confusion to the user? And they will never use it.
Example 2 - The database method
We create a new column call Clip Type after Clip Filename in our .csv and .json file.
Our Tool will print the value of the the clip type base on the maker or caption that it attached on?
I think the database method provides maximum flexibility. The user can create custom filters and criteria in their Notion or Airtable Databases. They can filter out any clip type to their desire.
Any thoughts?

https://github.com/orchetect/DAWFileKit/blob/1461eec9441c2eed644a0d6622188975fa5632e5/Sources/DAWFileKit/FinalCutPro/FCPXML/Story/Clips/Meta/FCPXML ClipType.swift#L13-L45

Does DAWFileKit  supports Generator Clip type?
There is also one more hidden clip type Layered Graphic which is basically .psd photoshop file.

Generators are actually video clips internally.
This is the Clouds generator:
video ref="r2" offset="3600s" name="Clouds" start="3600s" duration="240300/2400s"/>

It links to an effect file:
<effect id="r2" name="Clouds" uid=".../Generators.localized/Backgrounds.localized/Clouds.localized/Clouds.motn"/>

So there's no actual generator clip type, and no real way to distinguish them.

We create a new column call Clip Type after Clip Filename

Actually this is a great idea and easy to implement also. For now we'll just add a new Clip Type column.
(As an aside, I'm going to remove the Clip Filename column. There's a few reasons, but Clip Name is always superior in every case.)

Generators are actually video clips internally.

Noted! We can just call them as Video under Clip Type column .

(As an aside, I'm going to remove the Clip Filename column. There's a few reasons, but Clip Name is always superior in every case.)

Change it to Clip Source Filename ?

What are all the possible values would Clip Type would print?
How are we typographically outputting them?
I can update my database template.

Clip Type has been added to the manifest output. Will be in 0.2.5.
Clip Filename actually presents a number of issues and I would like to remove it. It's simple for basic asset clips that only have one video file.
However for compound clips, sync clips, and multicam clips can contain clips using more than one video file. In that case it would not be clear what file to include for this field.

What are all the possible values would Clip Type would print?

Currently these, which are the literal internal clip types FCP uses in the XML:
Asset
Audio
Audition
Clip
Gap
Live Drawing
Multicam
Compound
Sync
Title
Video

It would take a little work but we could interpret some of these types to be more useful to the user, if needed.
One thought is that the Audition type could change to the actual clip type contained within the audition, like this:
Compound (Audition)

Or just make it seemless as the user probably doesn't care that it's an audition, they just care what clip type is contained within:
Compound

One thought is that the Audition type could change to the actual clip type contained within the audition, like this:

So technically Audition is a "virtual" or "dummy" clip type?
I will exclude Audition from the database template.

Or just make it seamless as the user probably doesn't care that it's an audition, they just care what clip type is contained within, and we leave out any indication that it's an audition:

Yes. Let's keep things simple. We can just print is as
Compound

Audition is a "virtual" or "dummy" clip type?

Yeah, a surrogate clip, if you will. When you're editing a FCP project you just see the clip, and the fact that there's other versions of that clip. Audition is not all that useful to the user as a type emitted in the manifest.

we can just print is as
Compound

So yes, that seems like the best way to go there.

Related: I've also confirmed that the audition 'surrogate' is not capable of having markers attached to it. You can only attach markers to the clip within it. Which is useful to know from a technical standpoint, but also it makes sense.

Interesting! Only in FCP, users visually see it s an audition clip. It is more like a 'surrogate' metadata / wrapper  to load the actual clips.

Yes, there is an indicator that the clip contains auditions and you can switch between them. What I mean is that, in a practical sense, the user does not consider it a different clip type just because of that.

Why was this bumped to 0.2.9? This was already done with 0.2.5.


Unreviewed commit on master!

Unreviewed commit(s) COMPARE was merged to master by zencephalon.
Comment with appropriate number of :+1: to approve.

Reviewed requirements satisfied? No
Ancestors reviewed? No

Minimum Reviews
0/2

More info

👍

Review Error for kirkas @ 2024-10-21 18:18:39 UTC
User failed mfa authentication, see go/mfa-help

👍

Minimum Reviews
1/2

omkarb
1

More info


Added Melanoma Detection Example

Thank you for adding this tutorial to monk's model zoo. Your efforts are highly appreciated


It fails the compilation

After installing all the 3 required dependencies and compiling the catkin_make
catkin_make -DCMAKE_BUILD_TYPE=Release
I don't know why, I do get this error. Is it possible to run this package without CUDA or any GPU?

Yeah the problem is that you don't have CUDA so the project_name_lib cannot be build thus cannot be found. I can make updates enabling the code without CUDA or any GPU, but the problem is that your program will be really slow. The yolo module and sgm module all require high calculation capability hardware otherwise it will be a pain running this code. If you really wanna run codes like this, I suggest you find a computer with good gpu.

It seems you are using virtual machine to run ubuntu. Recently I am busy with other things. I guess I will update the code using CPU mode next week. Currently I suggest you to use another good repo: https://github.com/leggedrobotics/darknet_ros. This repo does not have stereo information, only running YOLO darknet under ROS. It can be run with solely CPU. Good luck!

All right. So with a computer with a GPU is enough or in addition requires of CUDA?
How many fps do you think is going to run without GPU?
The location output data of your package are boundary boxes in 3D? what does it mean? that there are cubic boxes or there are 2D boxes located located in space? if so, the depth location of such bounding boxes is taken by the depth value of the central pixel or it does an average of the depth pixels in the bounding box?

We need CUDA. WIthout GPU might be really slow (I guess might be several seconds). Please refer to this pose: https://github.com/pjreddie/darknet/issues/872. I recommend you to use OpenCV directly.
Output format
Just refer to the obstacle_msgs:
point3 centerPos    # 3D bounding box center position (meter)
float32 diameter    # diameter (meter)
float32 height
string classes
float32 probability
uint32 xmin         # 2D bounding box edge coordinate
uint32 ymin
uint32 xmax
uint32 ymax
It has both 2D with boundaries and 3D information with center location. We use median filter to make sure the center of the box is consistent, not noise or outlier.
However, if you want to average over the bounding box it is also OK. You just need to read the source code and do some changes.

All right, thanks for the info.
Still I have some doubts regarding this:

point3 centerPos # 3D bounding box center position (meter)
float32 diameter # diameter (meter)
float32 height

The first one means the position X, Y, X coordinates of the bounding box anchors, right?
What are the other 2 for?
And an important question, how can I use this package by using as input the RGB image and point cloud instead of "/camera_reading ([sensor_msgs/Image])" which I assume is /camera/depth/image_rect_raw?
Because /camera/depth/image_rect_raw is not working well with my camera.

Diameter and height means the 3D dimension or size of the bounding box.
For your second question, I don't understand what do you mean by RGB image and point cloud input. This is a stereo camera package, you can refer to https://github.com/zhanghanduo/cubicle_detect/blob/master/darknet_ros/launch/kitti.launch to see the required sensor topic is left, right image_rect and camera_info. So you don't need point cloud or depth image. It uses built-in sgb method to calculate the depth automatically. If you already have point cloud, you have to change the source code accordingly.

The point is that my camera just produces this set of topics:
/camera_floor/background
/camera_floor/camera_info
/camera_floor/driver/color/camera_info
/camera_floor/driver/color/image_raw
/camera_floor/driver/color/image_raw/compressed
/camera_floor/driver/color/image_raw/compressed/parameter_descriptions
/camera_floor/driver/color/image_raw/compressed/parameter_updates
/camera_floor/driver/depth/camera_info
/camera_floor/driver/depth/color/points
/camera_floor/driver/depth/image_rect_raw
/camera_floor/driver/depth/image_rect_raw/compressed
/camera_floor/driver/depth/image_rect_raw/compressed/parameter_descriptions
/camera_floor/driver/depth/image_rect_raw/compressed/parameter_updates
/camera_floor/driver/extrinsics/depth_to_color
/camera_floor/driver/parameter_descriptions
/camera_floor/driver/parameter_updates
/camera_floor/filter/parameter_descriptions
/camera_floor/filter/parameter_updates
/camera_floor/filter/visualization_marker
/camera_floor/floor
/camera_floor/obstacles
/camera_floor/transform/parameter_descriptions
/camera_floor/transform/parameter_updates
/camera_top/background
/camera_top/obstacles

This means that

/camera_floor/driver/depth/image_rect_raw
is the only depth image topic, that is, there are no left nor right separated images.
It produces:

/camera_floor/driver/depth/color/points
/camera_floor/driver/color/image_raw

And regarding the shapes of the bounding boxes, then they are cubes if I understand well, in such case, how does your algorithm select the depth of such bounding box? Considering all depths the same in every class or depending on the class? The center of such cube aims the center of gravity of the detected object?

Not that complicated. The center of the 3D cube is just the center of the 2D rectangle. Note that in case of the center is outlier or noise, we use a 3x3 median filter to find out the center depth. We just assume for one object the depths of all points are the same.
For your case, you have to modify my code to work on your camera. In darknet_ros/src/YoloObjectDetector.cu, the function getDepth() is used to generate disparity map. Since you already have the depth map, you can easily replace it with your depth map using callback function.

All right. Now I managed to install the NVidia drivers and CUDA.
I install openCV with this guide https://gist.github.com/raulqf/a3caa97db3f8760af33266a1475d0e5e
and when trying to compile your package, after installing the other dependencies, this is what happens:

Do you know what might be the cause?

Ok, not everything compiled properly. After downloading the weights and configuring properly the config file, then I roslaunch cubicle_detect yolo_v3.launch but I have no idea why the program I calling yolo_bdd... weights since I defined that I wanted to use yolov3.weights and yolov3.cfg

Maybe the program bug? You can dive into the darknet_ros/src/YoloObjectDetector.cu, edit the lines:   nodeHandle_.param("yolo_model/weight_file/name", and nodeHandle_.param("yolo_model/config_file/name", configModel, std::string("yolo_bdd_c1.cfg"));.

it is a very weird error since im doing a launch of yolo_v3, not the yolo_v3_bdd

Yes, problem solved.
Now the last issue is that keeps waiting for the image when I am feeding it with my /camera_floor/driver/depth/image_rect_raw from a Intel RealSense camera. Maybe this camera is not compatible with your package

I think if you are familiar with ROS you can change your callback function to adapt to your case.

It should work with the topic I provided since it is the type of 16UC1.
I'm not sure if I should use another topic..
Here there is a full list:
rostopic list yield the followings:
/camera/Motion_Module/parameter_descriptions
/camera/Motion_Module/parameter_updates
/camera/RGB_Camera/parameter_descriptions
/camera/RGB_Camera/parameter_updates
/camera/Stereo_Module/parameter_descriptions
/camera/Stereo_Module/parameter_updates
/camera/accel/imu_info
/camera/accel/sample
/camera/color/camera_info
/camera/color/image_raw
/camera/color/image_raw/compressed
/camera/color/image_raw/compressed/parameter_descriptions
/camera/color/image_raw/compressed/parameter_updates
/camera/depth/camera_info
/camera/depth/image_rect_raw
/camera/depth/image_rect_raw/compressed
/camera/depth/image_rect_raw/compressed/parameter_descriptions
/camera/depth/image_rect_raw/compressed/parameter_updates
/camera/extrinsics/depth_to_color
/camera/extrinsics/depth_to_infra1
/camera/extrinsics/depth_to_infra2
/camera/gyro/imu_info
/camera/gyro/sample
/camera/infra1/camera_info
/camera/infra1/image_rect_raw
/camera/infra1/image_rect_raw/compressed
/camera/infra1/image_rect_raw/compressed/parameter_descriptions
/camera/infra1/image_rect_raw/compressed/parameter_updates
/camera/infra2/camera_info
/camera/infra2/image_rect_raw
/camera/infra2/image_rect_raw/compressed
/camera/infra2/image_rect_raw/compressed/parameter_descriptions
/camera/infra2/image_rect_raw/compressed/parameter_updates
/camera/realsense2_camera_manager/bond
/diagnostics
/rosout
/rosout_agg
/tf_static
Besides, I am watching that your code is processing left and right images, but the input of your system is from just a single topic.


Pay day

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
510315f4-a153-48e7-9c68-   510315f4-a153-48e7-9c68-ec675bd772941cf868b9e1b81dd51a57edfaebfb919e d772941cf868b9e1b81dd51a57edfaebfb919e

Hello @Drakogangcom It seems you forgot to document your issue appropriately. Is there anything that needs to be fixed?

Closing since not issue was reported


Anonymous issue reporting

To help users be able to submit issues without having to create a user, any thoughts on configuring this repo with GitReports?

Done for ATITD and Automato:
https://gitreports.com/issue/DashingStrike/Automato-ATITD
https://gitreports.com/issue/DashingStrike/Automato
Will need to add links to GitHub project READMEs (feel free to send PR), website (I'll do this tomorrow), and in-app (perhaps a "feedback" button on the main page and the ATITD script page).

Links added to all appropriate places, including in-app.


Support alias notation

More readings:
https://developer.salesforce.com/docs/atlas.en-us.soql_sosl.meta/soql_sosl/sforce_api_calls_soql_alias.htm
Need to expand the current API

Added by PR #24


Fixes a mixup between Consumption and Power services initialization

Fixes a mixup between Consumption and Power services initialization on Accessory index.js file to avoid SyntaxError: totalConsumption: duplicate key on devices with ZHAPower before ZHAConsumption.

Already fixed in v1.0.4.
This code wouldn’t fix the issue, but move it to devices where the ZHAConsumption resource comes before the ZHAPower resource.

@ebaauw Look on the change before you answer, please.
Its not the first time I send you PRs and you reject them so quickly, and then later I see you just done the same thing that I did, don't take it personal, you're doing a great job, and I just want to help you.
This change did fixed my ubisys S1-R before your fix on 1.0.4.
If look at the code that I changed, I just made sure to load the correct service based on the corresponding service name, you just mixed up the service names and I changed it to be the correct ones.
Thank you a lot - Again

I do appreciate your help, and I do apologise for glancing over the change too quickly.  I was put off guard a bit by the PR description, and thought you changed the order of:
} else if (params.serviceName === 'Consumption') {

and
 } else if (params.serviceName === 'Power') {

There is no mixup, however; the code combines two resources (ZHAConsumption and ZHAPower) onto the same eve.Consumption service, as this is needed for Eve history.  So when evaluating ZHAConsumption, you check whether a service for ZHAPower was already created, and on ZHAPower you check for ZHAConsumption.  The TypeError was caused because the service for the second (ZHAConsumption) resource wasn't registered in this.servicesByName and the history code creates a computed totalConsumption for ZHAPower without ZHAConsumption.

Oh, OK, Now I understand the code better, maybe a comment there will make it clearer as it placed over many logic if-elses which loads the corresponding service.
I don't fully understand how it fixed the error of my S1-R unit, maybe you can tell, I did just discovered this "mixup" (which I understand your point mentioning it serves just another check of having both Power and Consumption services) by debugging the services creation flow using vscode...
Well, for now I will reverse my code and will delete the branch I created for it.
Thank you very very much.

Its not the first time I send you PRs

I don't see any other PRs by you on any of my repositories?  Or did you change usernames on GitHub.

It was back in the day on the homebridge-hue days and could be my older GitHub account, I don't remember what was it, but I definitely remember it was funny as a bit later you just did exactly what I PR'ed lol.
OK, anyway, I'm happy we're open and discussing anything which is relevant.

Oh, well, I realize one of the things.
It was even with the homebridge-deconz earlier days, when I wanted to have my ubisys S1 to be used as a HK Switch, and I tried suggesting it to you over Issues page, see #28 for example.
Later, you just did it yourself by using Label for ZB switches (Hue Dimmer Switch for example) and using Switch for HK Switches or any other type of light/plug which its serviceName is "Switch".
Again, no bad feelings, but I was frustrated to get the feature I had with HB-hue back into HB-deconz.
OK, next time lol...
Thank you a lot again for the great job.


PHP SDK: Use VaaS HTTP API

Hey. I don't know what's better for you. I can also make a proposal PR if you like that more. I would rewrite the Authenticator stuff like that:
enum Suit: string
{
    case CLIENT_CREDENTIALS = 'client_credentials';
    case PASSWORD = 'password';
}

interface IAuthenticatorOptions {
}

class ResourceOwnerPasswordGrantAuthenticatorOptions implements IAuthenticatorOptions {
    public string $grandType = 'password';
    public function __construct(public string $clientId, public string $username, public string $password) {}
}

class ClientCredentialsAuthenticatorOptions implements IAuthenticatorOptions {
    public string $grandType = 'client_credentials';
    public function __construct(public string $clientId, public string $clientSecret) {}
}

class someAuthenticator {
    private function tokenRequestToForm(IAuthenticatorOptions $options): string
    {
        return match(true) {
            $options instanceof ResourceOwnerPasswordGrantAuthenticatorOptions => http_build_query([
                'client_id' => $options->clientId,
                'username' => $options->username ?? throw new InvalidArgumentException(),
                'password' => $options->password ?? throw new InvalidArgumentException(),
                'grant_type' => $options->grandType
            ]),
            $options instanceof ClientCredentialsAuthenticatorOptions => http_build_query([
                'client_id' => $options->clientId,
                'client_secret' => $options->clientSecret ?? throw new InvalidArgumentException(),
                'grant_type' => $options->grandType,
            ])
        };
    }
}

With that change you don't need the knowledge for what grandType does need what fields, because the classes are specific.

This PR is allot of work. Thank you for tackling it!


♻ refactor: Refactor usecase interface

Pull Request Test Coverage Report for Build #125

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.693%

Totals

Change from base Build #123:
0.0%

Covered Lines:
325

Relevant Lines:
326

💛  - Coveralls


how to set broker true?

i want to open microsoft authenticator app while click call graph api so how do i set broker true in sample code?

Add this in onCreate:
AuthenticationSettings.INSTANCE.setUseBroker(true);

This sample has been archived.
The newer one can be found at: https://github.com/azure-samples/ms-identity-android-native


Update readme on how to connect to a sandbox account

Took a while for me to find out why my authentication failed so I thought that this info in the readme could be useful.

found the solution in issue #32


petset replica fails to initialize

The extended test reveals that sometimes a slave member fails to initialize, in this case member "1" (of 0,1,2) fails to join the replica set because it can't contact itself:
Dec 18 05:38:55.488: INFO: Running 'oc logs --config=/tmp/extended-test-mongodb-petset-replica-jqdp4-qrh5o-user.kubeconfig --namespace=extended-test-mongodb-petset-replica-jqdp4-qrh5o mongodb-replicaset-1 --timestamps'
pod logs for 2016-12-18T10:37:43.981767000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten] MongoDB starting : pid=16 port=27017 dbpath=/var/lib/mongodb/data 64-bit host=mongodb-replicaset-1
2016-12-18T10:37:43.982068000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten] db version v3.2.6
2016-12-18T10:37:43.982308000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten] git version: 05552b562c7a0b3143a729aaa0838e558dc49b25
2016-12-18T10:37:43.982538000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten] OpenSSL version: OpenSSL 1.0.1e-fips 11 Feb 2013
2016-12-18T10:37:43.982805000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten] allocator: tcmalloc
2016-12-18T10:37:43.983041000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten] modules: none
2016-12-18T10:37:43.983276000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten] build environment:
2016-12-18T10:37:43.983512000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten]     distarch: x86_64
2016-12-18T10:37:43.983760000Z 2016-12-18T10:37:43.980+0000 I CONTROL  [initandlisten]     target_arch: x86_64
2016-12-18T10:37:43.983997000Z 2016-12-18T10:37:43.981+0000 I CONTROL  [initandlisten] options: { config: "/etc/mongod.conf", net: { http: { enabled: false }, port: 27017 }, replication: { oplogSizeMB: 64, replSet: "rs0" }, security: { keyFile: "/var/lib/mongodb/keyfile" }, storage: { dbPath: "/var/lib/mongodb/data" }, systemLog: { quiet: true } }
2016-12-18T10:37:43.990110000Z 2016-12-18T10:37:43.989+0000 I STORAGE  [initandlisten] wiredtiger_open config: create,cache_size=3G,session_max=20000,eviction=(threads_max=4),config_base=false,statistics=(fast),log=(enabled=true,archive=true,path=journal,compressor=snappy),file_manager=(close_idle_time=100000),checkpoint=(wait=60,log_size=2GB),statistics_log=(wait=0),
2016-12-18T10:37:44.052474000Z 2016-12-18T10:37:44.051+0000 I CONTROL  [initandlisten]
2016-12-18T10:37:44.052789000Z 2016-12-18T10:37:44.051+0000 I CONTROL  [initandlisten] ** WARNING: /sys/kernel/mm/transparent_hugepage/enabled is 'always'.
2016-12-18T10:37:44.053041000Z 2016-12-18T10:37:44.051+0000 I CONTROL  [initandlisten] **        We suggest setting it to 'never'
2016-12-18T10:37:44.053288000Z 2016-12-18T10:37:44.051+0000 I CONTROL  [initandlisten]
2016-12-18T10:37:44.053518000Z 2016-12-18T10:37:44.051+0000 I CONTROL  [initandlisten] ** WARNING: /sys/kernel/mm/transparent_hugepage/defrag is 'always'.
2016-12-18T10:37:44.053782000Z 2016-12-18T10:37:44.051+0000 I CONTROL  [initandlisten] **        We suggest setting it to 'never'
2016-12-18T10:37:44.055259000Z 2016-12-18T10:37:44.054+0000 I CONTROL  [initandlisten]
2016-12-18T10:37:44.062866000Z 2016-12-18T10:37:44.062+0000 I REPL     [initandlisten] Did not find local voted for document at startup;  NoMatchingDocument: Did not find replica set lastVote document in local.replset.election
2016-12-18T10:37:44.067225000Z 2016-12-18T10:37:44.064+0000 I REPL     [initandlisten] Did not find local replica set configuration document at startup;  NoMatchingDocument: Did not find replica set configuration document in local.system.replset
2016-12-18T10:37:44.068022000Z 2016-12-18T10:37:44.067+0000 I FTDC     [initandlisten] Initializing full-time diagnostic data capture with directory '/var/lib/mongodb/data/diagnostic.data'
2016-12-18T10:37:44.073139000Z 2016-12-18T10:37:44.069+0000 I NETWORK  [HostnameCanonicalizationWorker] Starting hostname canonicalization worker
2016-12-18T10:37:44.077176000Z 2016-12-18T10:37:44.075+0000 I NETWORK  [initandlisten] waiting for connections on port 27017
2016-12-18T10:37:44.116189000Z => [Sun Dec 18 10:37:44] Waiting for local MongoDB to accept connections ...
2016-12-18T10:37:44.201977000Z 2016-12-18T10:37:44.201+0000 I ACCESS   [conn1] note: no users configured in admin.system.users, allowing localhost access
2016-12-18T10:37:44.207463000Z => [Sun Dec 18 10:37:44] Adding mongodb-replicaset-1.mongodb-replicaset.extended-test-mongodb-petset-replica-jqdp4-qrh5o.svc.cluster.local to replica set ...
2016-12-18T10:37:44.289860000Z 2016-12-18T10:37:44.289+0000 I NETWORK  [thread1] Starting new replica set monitor for rs0/mongodb-replicaset-0.mongodb-replicaset.extended-test-mongodb-petset-replica-jqdp4-qrh5o.svc.cluster.local:27017
2016-12-18T10:37:44.290694000Z 2016-12-18T10:37:44.290+0000 I NETWORK  [ReplicaSetMonitorWatcher] starting
2016-12-18T10:37:44.828167000Z {
2016-12-18T10:37:44.828441000Z 	"ok" : 0,
2016-12-18T10:37:44.828688000Z 	"errmsg" : "Quorum check failed because not enough voting nodes responded; required 2 but only the following 1 voting nodes responded: mongodb-replicaset-0.mongodb-replicaset.extended-test-mongodb-petset-replica-jqdp4-qrh5o.svc.cluster.local:27017; the following nodes did not respond affirmatively: mongodb-replicaset-1.mongodb-replicaset.extended-test-mongodb-petset-replica-jqdp4-qrh5o.svc.cluster.local:27017 failed with HostUnreachable",
2016-12-18T10:37:44.828954000Z 	"code" : 74
2016-12-18T10:37:44.829205000Z }
2016-12-18T10:37:44.887793000Z => [Sun Dec 18 10:37:44] ERROR: couldn't add host to replica set!

Guessing there is a race condition here, need to review the petset initialization logic to see if it's reasonable for it to expect to contact itself, and if so, why it can't at this point.

fixed by https://github.com/sclorg/mongodb-container/pull/217


Option to enable word-diff for staged changes

Summary
Allow one to use word-diff for staged changes
Motivation
When you write text instead of code, git's normal diff is useless, it usually highlights a whole paragraph since a paragraph is one line. For any kind of normal text (Markdown, LaTeX, documentation), word-diff is preferred as in git diff --word-diff.
It would be great if Atom would automatically use word-diff when you look at the diff of your staged changes in the Git tab on documents which are not note code (.tex, .md, etc.) Currently, it uses the normal diff.

This should be asked in @atom/github


Linter failures due to natural language checks

Equivalent to https://github.com/adoptium/temurin-build/issues/2831 for this repository.
Note that I don't personally agree with some of them (e.g.site->website) and so we should possibly look at the configuration of the linter before blindly implementing what it's objecting to.

I think  terminology check has been disabled in https://github.com/adoptium/ci-jenkins-pipelines/pull/286 for README.md
If we have other md file with the same issue (e.g failed for 'node' to suggest  'nodejs') we can disable it  later.


Need help for installing hw

Am facing this error :    * Missing (or bad) C library: secp256k1
Can't figure it out

on ubuntu ,try

sudo apt install libsecp256k1-dev


Repeating deprecation warnings #4443

Added message-stack map to prevent showing multiple warning messages from same place.
Didn't change anything for case with "IE < 10 and Safari < 6" - should I add separate array to store shown messages for this case?
Fix for issue #4443

@YahorPadlucki thanks for this! I had just added this feature to v5, but went for a slightly simpler approach. You can check it out here: https://github.com/pixijs/pixi.js/blob/next/bundles/pixi.js/src/deprecated.js#L2-L48
I would argue slightly against this approach only because if there are the same warnings called each frame from different places, it would still spam both messages and kill performance. I tend to lean towards being a little aggressive about silencing repeat warnings to not hurt performance overall.
What do you think?

@bigtimebuddy, I thought that it is useful to show exact place were the warning is called from - to know where to fix it.
With your approach - if you want to fix all deprecations, it can be a bit confusing - when you fix it in one place, refresh, and get it in a new  place - which wasn't logged before.  So you need to know that you better to search same places in code.
Thats the only concern I have.

Yeah, I think the trade-off for fewer warnings for better performance is better. So I'm okay being conservative with warning and the dev having to find-and-replace, refresh than having to spit out every possible warning. I'm considering the worst case scenario, which I saw when we deprecated some filters APIs that get called every frame.

@YahorPadlucki, would you mind changing this to block repeat deprecations based on the message and not the stack trace? Then, I'd like to merge for 4.8.0

Changed. Sorry - didn't get that I need to update my branch - thought you will merge your solution.

Thank you @YahorPadlucki!


Robot allocator send robots home on restart

Robot allocator resets robots states to available, but if a restart happens while robots are on item or station zones they stay there until assigned a job.
On start/restart, robot allocator should send robots home (via jobs?).

This was completed


Getting an exception with only requiring and createSimpleLogger()

Hi,
I'm experiencing the following issue - just downloaded the tool and tried to use it using the simplest example (didn't even log anything, just required and created it):
// create a stdout console logger
const log = require('simple-node-logger').createSimpleLogger();

and I'm getting this:
[1] module.js:538
[1]     throw err;
[1]     ^
[1]
[1] Error: Cannot find module 'simple-node-logger'
[1]     at Function.Module._resolveFilename (module.js:536:15)
[1]     at Function.Module._load (module.js:466:25)
[1]     at Module.require (module.js:579:17)
[1]     at require (internal/module.js:11:18)
[1]     at Object.<anonymous> (/Users/sgivony/dev/nodeapp3/server/routes/index.js:9:13)
[1]     at Module._compile (module.js:635:30)
[1]     at Object.Module._extensions..js (module.js:646:10)
[1]     at Module.load (module.js:554:32)
[1]     at tryModuleLoad (module.js:497:12)
[1]     at Function.Module._load (module.js:489:3)
[1] [nodemon] app crashed - waiting for file changes before starting...

Node js version is v8.9.3
I'm running nodemon

Thanks

Sorry, my bad. Not an issue.


improve Merkle tree proof test coverage

Coverage increased (+0.3%) to 91.326% when pulling 86645ec5b612a811290e0d633cc24d35ac7b3547 on boguslavsky:merkle-proof-format into 03c225d996938c39e366bda75a5748ddec801160 on exonum:master.

Coverage increased (+0.3%) to 91.326% when pulling 86645ec5b612a811290e0d633cc24d35ac7b3547 on boguslavsky:merkle-proof-format into 03c225d996938c39e366bda75a5748ddec801160 on exonum:master.


[Question] Is there possibility to inline json files?

Type of Issue
[ ] Bug Report
[ ] Feature Request
[x] Question

Description
Is there a possibility to inline contents of *.json (or other) files as string in output code of packagr?
My usecase is that I have some of json schemas that I'd like to keep as separate files in source rather than inline them in *.ts files.
As workaround I could require() them and leave resolving for consumer project but that means i need to copy files 'by hand' to each angular package format directories. It could work for esm5 and esm2015 but for flat version it creates problem where relative path of require will resolve to format root directory. And that will break if I happen to have files of same name. There is workaround to this - unique name policy but it feels wrong and makes my build less stable.
Version Information
ng-packagr: 3.0.3
@angular/compiler: 6.0.5
rollup: 0.59.4
tsickle:  0.29.0
typescript: 2.7.2
rxjs: ^6.0.0
node: 10.4.0
npm/yarn: yarn1.7.0

As you mentioned something like this get tricky considered the different modules format. I believe we had this feature some time ago, but was dropped for the same reasons. Using ‘require’ I am not sure if that would work for all module formats and bundlers.
May I ask why not use json files instead of json objects in typescript files?

You're right, require is not universal solution, but it works for my buildprocess right now.

May I ask why not use json files instead of json objects in typescript files?

I guess you meant another way around? Json files are external to frontend part of project. I have this files as 'single source of truth' shared by multiple modules (in different languages).
From my perspective solution is to inline this files, similar to what's happening to html templates. That way it will work in any format. Of course it's solution for static imports only. That said it's enough for my usecase.

Yeah I meant the other way wrong.
In case you have a json schema. Another approach is to convert this to TypeScript via an addition step.
Take a look at this library https://www.npmjs.com/package/json-schema-to-typescript

I'm already using typescript definitions but I need runtime check of incoming data - so I'm using schema to validate data against it.


Update Alignment utility class name documentation

As spotted by @matthewcarleton, the Alignment utility's documented class names are incorrect.
Instead of:
.pf-u-text-left{-on-[breakpoint]}
.pf-u-text-center{-on-[breakpoint]}
.pf-u-text-right{-on-[breakpoint]}
.pf-u-text-justify{-on-[breakpoint]}

They should be the following (with align included):
.pf-u-text-align-left{-on-[breakpoint]}
.pf-u-text-align-center{-on-[breakpoint]}
.pf-u-text-align-right{-on-[breakpoint]}
.pf-u-text-align-justify{-on-[breakpoint]}

:tada: This issue has been resolved in version 1.0.59 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Exploration of background worker proposal

In this ticket we represent the information gathered  in https://www.notion.so/mergestat/Background-Worker-Exploration-0eec087fee3c4b15bd236b75a370c1ef  to undestand more the problem and more confident creating our own app or using another tool for htis

@patrickdevivo  @amenowanna  do you guys consider this https://www.notion.so/mergestat/Background-Worker-Exploration-0eec087fee3c4b15bd236b75a370c1ef  as  completed ?
Or we need to break down of the tickets to completed ?


Subtitles

I can't find any option to add subtitles. Drag/Drop subtitle file is also not working. (I am on 16A254g)

This is an upcoming feature of this project:
https://github.com/amilajack/popcorn-time-desktop/wiki/Road-Map-and-Progress#planned-featuresimplementationsmigrations
You can 'watch' this repo to follow our progress.

Where is 'cache' folder located in this version?

it should be saved in ./tmp/webtorrent

Eventually this will be configurable through an env variable and the UI

Okay, thanks.

Hey! I can't find the cache in ./tmp/webtorrent


DOS extract optimize workflow

DOS extractor optimize workflow: check "PDOSIN" first, then import vasprun.xml

closed as the config file would need "atom_list" from "vasprun.xml" to parse atom selection


Fixed sim docs

Closes #96
Would like a reality check from @gerth2 if possible to make sure I've got the numbers right.

Pretty darn close, looks like change aligns with the example source code. Unfortunately, jason pointed out that even that is off by a few inches.
My "most correct" calculation for width:
Target Width:
https://firstfrc.blob.core.windows.net/frc2020/PlayingField/2020FieldDrawing-SeasonSpecific.pdf Page 207/208
width = end-start + 2tape width = 41.3 - 6.7 + 22.0 = 38.6 in.
Target Height looks good per https://firstfrc.blob.core.windows.net/frc2020/PlayingField/2020FieldDrawing-SeasonSpecific.pdf Page 197.
Target height above ground needs to be wherever photonvision is going to find the centroid of the bright pixel blob. A pretty simplified model says "in the middle", which would yield 89.69 in.

#106 changes this page to all RLIs for code blocks so the docs will automatically update once someone fixes the code in the example repo, this is probably for the best.


update url path to core_concepts docs

Previous link was broken. Found correct link and submitting fix. Thank you.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Distros don't offer Star.

I think they need to include at least zef and p6doc.
Many users will be trying to use Perl6 from distro packages, it's way easier to get a good experience if it's improved.

Is it expected for distros to include Star? Or should Star be a metapackage? In other words, what exactly do we want?

I want zef and p6doc packaged.

I don't see the point of Star in distributions. They will:

offer way more modules than Star, as in not a selection but as many as they can package.
have their own update schedule for the modules.
have their own update schedule for Rakudo.

Right, maybe not star, but the other two.
But we are talking about good newb experience, and finding star is a good thing, even if they don't really need it.

@rafaelschipiura
I keep a list of Rakudo on distros here: https://github.com/nxadm/rakudo-pkg#what-about-packages-provided-by-operating-systems

@nxadm I'm using 2018.05 from Debian.

regarding debian: this is very much work in progress, the current situation is certainly not what we are after in the long run. At the moment we really only have a "bare" perl6, no zef or any modules packaged.
Work is progressing on that front, the next step is a change to the module and rakudo installation/removal scripts to manage precompiled files. After that the first modules can be packaged, which should of course include zef.

On Donnerstag, 14. Juni 2018 00:21:01 CEST nxadm wrote:

I keep a list of Rakudo on distros here:
https://github.com/nxadm/rakudo-pkg#what-about-packages-provided-by-operati
ng-systems

The list is a bit incomplete. Rakudo, Inline::Perl5 and packages for cro and
its dependencies are available for openSUSE Leap 42.2, 42.3, 15.0 and
Tumbleweed: https://software.opensuse.org/package/rakudo
Tumbleweed includes them in the default repository.
They are usually at most one release behind.

So with Zef and Rakudo available and nothing else it used to be quite easy to bootstrap to having something like Star using Task::Star (https://github.com/tadzik/Task-Star). But this is no longer maintained /or/ part of the ecosystem. Perhaps the way Rakudo Star is actually built could be through a versioned meta package? That way the only thing that needs to be packaged is zef alongside the compiler. Personally I freaking hate how Perl 5 has all this hideous melange of OS level packages and then the inevitable CPAN packages. None of which necessarily work well together. The only real claim for why you'd want OS level are for things like libssl and other way more annoying builds where you want better OS compatibility.

@niner
The list was intended to show the OS-supplied versions for the distributions that rakudo-pkg supports. And also which releases were OK to use. It may be a good idea to extend it and make it more generic.
There is PR now in the queue (@MasterDuke17 ++) for adding information for Arch. Maybe the information could be added for openSUSE tumbleweed as well (and Debian testing and unstable.

@robertlemmen,
That is wonderful news. Your work is appreciated. I was under the impression that zef wouldn't be package and I am happy to hear this is the case when the problems you mentioned are solved.

@MattOates

So with Zef and Rakudo available and nothing else it used to be quite easy to bootstrap to having something like Star using Task::Star (https://github.com/tadzik/Task-Star). But this is no longer maintained /or/ part of the ecosystem. Perhaps the way Rakudo Star is actually built could be through a versioned meta package? That way the only thing that needs to be packaged is zef alongside the compiler.

I don't see the use case for a Star metapackage in a distro because the modules are unrelated to a specific task. The idea of Star is to provide an easy way to get started with Rakudo. If the distribution does the packaging job, I don't see what it brings to the table than a collection of unrelated modules.

@robertlemmen @MattOates Thanks guys for the wonderful job, really appreciated. I'm glad to know it will be solved soon.
@MattOates Many sysadmins won't bother to learn language-specific packaging. If it's not available in distro repos, it might as well not exist. But in this first moment Perl 6 is more for developers, so I agree it doesn't make sense to package modules for distros just yet.

There are a number of issues mentioned here. Many of these have been discussed before without much agreement.
Generally distributions have had problems with packaging perl 6 in general (with a few exceptions like OpenSUSE, Debian etc.)
See https://perl6.org/downloads/others.html
I don't think this is the right place to discuss what distros should or shouldn't do. We should try and help them (maybe even join them) but its the responsibility of the distro maintainers to package. We are upstream.
To be frank I currently think any advice to use any packaged distro version of rakudo perl 6 is Bad Advice (unless perhaps for OpenSUSE). Perl 5 had a lot of problems with distro packaged versions and the Perl 6 situation is likely to be worse. The usual Perl 5 advice was to install in parallel with "system perl".
We release perl 6 monthly whereas the average lifespan of a distro perl 6 version is likely to be three years. Although 6.c is feature frozen there are a lot of bug fixes going in which will break code (as shown by toaster runs) and anyone using a version of perl 6 which is more than a few months old is likely to run into those problems.  Neither can IRC really support random versions from many months ago and the usual response is going to be "upgrade maybe its fixed".
Until there is a more stable (in terms of changes) version of Perl 6 something like a Medium Term Support branch its going to be very hard to package anything useful.

@stmuk All true, but it's also true the Perl 6 experience is harmed by that, so the bug should stay open until it's fixed.
People are working on it anyway.

@stmuk generally I agree, but here are some corrections:

Although 6.c is feature frozen there are a lot of bug fixes going in which will break code (as shown by toaster runs)

That's not exactly the case. Toaster shows regressions that we have to fix before the next release, so the failures that you'd typically see are non-existent on monthly releases. If the module actually relied on buggy or experimental behavior, a PR to this module is submitted with a backwards-compatible fix. I do agree that given the pace of rakudo development, there are many fixes coming in that can potentially break existing code, but you can't use toaster as an argument for that. Toaster is by definition a tool that allows us not to do such changes.

Neither can IRC really support random versions from many months ago and the usual response is going to be "upgrade maybe its fixed"

Committable allows to run code on any revision (including monthly releases), so we don't have to recommend upgrading. But it's true that at this point in time the usual response actually works in many cases, yeah…

to me it seems the perceived problems with distributions and perl packages fall into two categories:

velocity. things in perl6 land move quickly, distributions will be slower. true, but that is a feature of a distribution, and is also true for many other pieces of software. slow/fast is quite subjective as well, I for example get annoyed if I have to upgrade an apache every 18 months ;) over time the feature velocity of perl6 will also converge, so it's not really a problem.

quality. module packages are never up date or complete, and interactions between locally installed packages (e.g. through cpanm or zef or so) and distribution-provided packages is poor. this is primarily a function of the amount of work that goes into distro packages. the site/vendor mechanism that exists in perl6 will help with this. the tests that are part of regular perl 5/6 packages can also greatly help if they are used by the distribution in some sort of CI fashion to detect breakages introduced by new versions of packages.

so I personally think that distribution packaging of perl6 modules can work, and it would be fab if we succeed. but it's not going to be trivial and without work. I would also not be surprised if it will be a while until distro packages become preferred over direct installation.
One thing that is interesting in this regard is the granularity of packaging: in some ecosystems (e.g. node), packages tend to be infinitesimally small. that seems to be a deliberate decision and I can of course see good reasons for it. But at the same time such fine-grained packaging has tremendous problems, not only for distributions but also for humans that want to install packages. It seems that some middle ground in terms of package granularity would be an excellent thing to establish culturally...

Not only new installs, sometimes existing installs will have Rakudo upgraded but not modules. Those would break.
Any breaking changes should wait for 6.d.

This is only true for a new rakudo build only -- upgraded rakudos that have modules already installed are still busted after a breaking change

That's a good point. That being said, I've looked through the list of PRs I did to modules during the last few months, and I'm fairly sure that this is not an issue in practice. For example, hash randomization and num precision fixes shouldn't brick installed modules. Even the upcoming change that turns the use of pack without experimental pragma into a compile-time error, only reveals modules that would probably fail during the run anyway (actually I just tested these modules and they're broken in other ways… I invite everyone to participate in 2018-08 ecosystem unbitrot SQUASHathon!).
So let's not blow things out of proportion. I've been putting consistent effort into making sure that we don't break modules willy-nilly.

Yes, that's true, but sometimes we do hear devs talking about it. Which does cause some concern, but we will keep it under perspective.


Merge in all information from the layout models docs

This makes https://flutter.io/basic-widgets/#layout-models redundant
with the dartdocs.


WebServiceTarget - FlushAsync - Avoid premature flush

Keeps track of pendingRequests. Tries to fix #259. Instead of expecting async-target to almost handle it #1853
First idea was to keep track of each individual LogEvent (in a dictionary), but the logic (and the allocations) became a little heavy. Now it just keeps track of a pending request count, so it is not completely correct when races occurs, but I think it is good enough.

This change is

Current coverage is 82% (diff: 79%)

Merging #1868 into master will decrease coverage by <1%

@@             master      #1868   diff @@
==========================================
  Files           276        276
  Lines         18503      18636   +133
  Methods        2859       2862     +3
  Messages          0          0
  Branches       2137       2159    +22
==========================================
+ Hits          15094      15194   +100
- Misses         2917       2946    +29
- Partials        492        496     +4

Powered by Codecov. Last update cf507d5...e50ffbb

I was hoping it was acting like a normal class, and just used default class-reference-hashcode.

yes 're right!

// The default implementation returns the sync block index for this instance.
// Calling it on the same object multiple times will return the same value, so
// it will technically meet the needs of a hash function, but it's less than ideal.
// Objects (& especially value classes) should override this method.

https://referencesource.microsoft.com/#mscorlib/system/object.cs,4de9cf234d0d8b16

Have now also added AutoFlushTargetWrapper into the mix, since #259 also complains that using the AutoFlushTargetWrapper didn't solve their problem.
Now I also have the crutch (AutoFlushTargetWrapper) that people can use when having a target without a proper flush-method.

Reviewed 15 of 17 files at r2, 3 of 3 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

tests/NLog.UnitTests/Targets/WebServiceTargetTests.cs, line 626 at r3 (raw file):

                    CountdownEvent = new CountdownEvent(expectedMessages);
                else
                    CountdownEvent = null;

nice one :)

Comments from Reviewable

@304NotModified  Think I have broken something, as the test-builds are now failing quite frequently.


stacks denovomap memory

update stacks_denovomap to have the same resources as stacks2_denovomap. This isn't configured to run on pulsar but it would be a good one for pulsar if it can run there

this also updates all 'mem: 61.4' to 'mem: 62' because that is better use of the memory on the worker nodes


Removing ApiWrapper and adding sinon

This PR fixes #

Coverage increased (+0.04%) to 37.139% when pulling 9e401f9475b3f237ed090b6a81d61a4c5452a9d6 on aasim/import/sinon into 1b616acfdbb8a4e86189dfb222d3ad477b6436c2 on main.


AttributeError: 'list' object has no attribute 'get'

Updated and get this one
Logger: custom_components.spook
Source: custom_components/spook/repairs/lovelace_unknown_entity_references.py:215
Integration: Spook (documentation, issues)
First occurred: 10:34:36 (4 occurrences)
Last logged: 10:35:21
Unexpected exception from <function AbstractSpookRepair.async_activate.._async_inspect at 0xffff55d203a0>
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/debounce.py", line 117, in _handle_timer_finish
await task
File "/config/custom_components/spook/repairs/init.py", line 130, in _async_inspect
await self.async_inspect()
File "/config/custom_components/spook/repairs/lovelace_unknown_entity_references.py", line 108, in async_inspect
for entity_id in self.__async_extract_entities(config)
File "/config/custom_components/spook/repairs/lovelace_unknown_entity_references.py", line 159, in __async_extract_entities
entities.update(self.__async_extract_entities_from_card(card))
File "/config/custom_components/spook/repairs/lovelace_unknown_entity_references.py", line 215, in __async_extract_entities_from_card
if condition := config.get("condition"):
AttributeError: 'list' object has no attribute 'get'

Ooh man, I can't thank you enough for keeping sending these in 🙏 😍
../Frenck


Issue #6: Travis CI

Adds Travis CI YAML file to configure CI build.
Adds IntelliJ iml files to gitignore.
Closes #6.

Notice that this PR (and all future PRs after this is merged) has an added "All checks have passed" on it with links to view the successful build on Travis CI. If the tests and build failed, the PR could not be merged.


[AudioKit outputDevices] only returning the current output device

I'm working on implementing an output selector in my app, but cannot seem to get a list of available outputs, only the current output.
    for (AKDevice *device in [AudioKit outputDevices]) {
        NSLog(@"Device: %@", device);
    }

Device: <Device: Receiver (Built-In Receiver)>

Decided to use Apple's AVRoutePickerView which will display the stock output select.

Cool, sorry AK didn't do that right.  We're working on a hardware layer that will help this considerably. I'll close this for now.


RancherD does not properly handle EC2 private IPs

What kind of request is this (question/bug/enhancement/feature request): Bug
Steps to reproduce (least amount of steps as possible):

Stand up EC2 instance with a public IP
Use the bash script from get.rancher.io to install rancherd
Wait for proper initialization, then execute rancherd reset-admin

Result:
Observe that the Rancher URL is set to https://
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): rancherd 2.5.1
Installation option (single install/HA): rancherd

https://github.com/rancher/rancher/issues/29162


Smell your Kotlin Code with Detekt

We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner. Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Smell your Kotlin Code with Detekt
Introduction paragraph (2-3 paragraphs):
Detekt  is a static code analysis tool that keeps your codebase tidy. You can enforce a wide range of rule sets in your code. You can configure the rules or add your own custom rules. It gives hints about code blocks that are getting a bit complicated, enforce formatting standards, and sniff out potential bugs before they hatch!
Key takeaways:

Get to know what  is Detekt
Key features of Detekt
Integrating Detekt into your codebase

References:

Detekt Official Site
Detekt on Github

Good afternoon and thank you for submitting your topic suggestion. @1-creator
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

@1-creator
How will this article differ from what is published our other blog sites


Remove Object::ClassMethods

https://github.com/mongoid/mongoid/issues/3951

Coverage decreased (-0.21%) to 98.63% when pulling a902008c0f85ea80c539539f482f41d932659ca4 on akicho8:spike into 701a8f777c6e9c6d8ca14657e07a6128407ef828 on mongoid:master.

Coverage decreased (-0.21%) to 98.63% when pulling a902008c0f85ea80c539539f482f41d932659ca4 on akicho8:spike into 701a8f777c6e9c6d8ca14657e07a6128407ef828 on mongoid:master.

Where it is not a change by my commit, we test fails.


Rendered audio cutting out at moments that it doesn't in the in game replay

Bug description
After grabbing a clip from replay mod that has perfectly good audio from simple voice chat, I rendered the clip using and brought it into davinci, but the audio now has breaks and pauses in a ton of places that the original did not have. I have noticed that in the logs it seems to talk about overlapping with previous snippet but i am not sure if that is apart of it.
Minecraft version
1.20.4
Simple Voice Chat version
1.20.4-2.5.4
ReplayMod version
1.20.4-2.6.14
Mod version
1.20.4-1.3.5
Mod loader and version
Fabric Loader 0.15.7
Steps to reproduce
Record a clip using replay mod, speak for a bit using simple voice chat, get the section of you speaking and render that out with ffmpeg installed. Bring it into a video editor of your choice and place the audio and just listen.
Expected behavior
Audio to be clear
Log files
https://gist.github.com/JimGringo/6cfaab73dc281ce1b3217017750e67a6
Screenshots
No response

Do you have an example replay file where this is happening?

https://drive.google.com/file/d/1hqDArRjoQpsnFTZsuvSMfn0AoQRD6h7O/view?usp=sharing
We used bobby on the camera which is why im assuming the file is so large, but yeah if you play the rendered audio after the replay file you can almost immediately hear the difference.

I unfortunately can't open that replay file, since you are using other mods that make it incompatible.
What happens if you export the same recording again? does it sound exactly the same?

Yeah, this is probably the 10th export of the same clip with the same result. I've tried to recreate it in different circumstances without any luck. I think have found the issue though, the person recording this has a terrible pc, when testing from specifically that computer the exports are bad, so I guess thats the issue solved, idk if you want to close this.


Fix local applications folder path using a tilde

node.js does not expand tildes (nodejs/node#684)
Fixes #5.
I'm not a node developer, there may be a nicer way of concatenating the 2 strings than I am aware of.
Edit: sorry I didn't read the contributing.md document fully at first, I've changed Closes to Fixes. Please let me know if I've missed anything, I'm still learning.

Pressed the wrong button. Sorry.

Fixed already: https://github.com/sindresorhus/app-exists/releases/tag/v2.1.1 :)

Too fast for me :)


RTF to HTML Conversion ignoring font color

Hi,
I am converting the attached RTF using the latest RtfPipe version: 1.0.7388.1242
InflationTrackerRTF.txt
And have noticed that the font color of the  tag element text (Inflation Tracker) is been ignored, the conversion is not setting any font color for this element tag, please see the converted html attach
RtfPipe-Conversion-HTML.txt
As you can see from the original rtf file the color for the 'Inflation Tracker'  tag element should have been set to: #000000
Any ideas why this is happening ?
thanks in advance :)

By default, the library has some logic to not render styles if the style of a given HTML tag matches the parent. The goal here is to make the HTML lighter and easier to use.


Tweak? Transfer overlay hides Token image chain badge

Some token icons like Optimistic's ERC20 Ether token includes a round badge to indicate which chain it is. In our design, we overlay a down (or diagonal) arrow icon over the token icon to indicate a transfer. The overlay might cover the round badge completely
It does in the single Activity screen and only partially in the Activity list on iOS, so we might also want to make it consistent.

I solved this by moving Network icons to the left.


Jackson still handling deserialisation

Have included the snapshot, but Jackson is still being picked.
It does seem like the auto-configuration is activating tho - here's the launch logs. Do I need to explicitly exclude Jackson from the classpath, or similar?
   SpringKotlinxSerializationAutoConfiguration matched:
      - @ConditionalOnClass found required class 'kotlinx.serialization.SerializationStrategy' (OnClassCondition)

   SpringKotlinxSerializationAutoConfiguration.KotlinxSeralizationEncoderConfiguration matched:
      - @ConditionalOnClass found required class 'de.classyfi.libs.spring.kotlinx.serialization.codec.KotlinxSerializationEncoder' (OnClassCondition)
      - found ConfigurableReactiveWebEnvironment (OnWebApplicationCondition)

   SpringKotlinxSerializationAutoConfiguration.KotlinxSeralizationEncoderConfiguration#kotlinxSerializationEncoder matched:
      - @ConditionalOnMissingBean (types: de.classyfi.libs.spring.kotlinx.serialization.codec.KotlinxSerializationEncoder; SearchStrategy: all) did not find any beans (OnBeanCondition)

Is this still open?

I think this was fixed in https://github.com/markt-de/spring-kotlinx-serialization/commit/0ab579d87ab144e17ee32076830730b849610ad3. Please let me know if this isn't the case.