Iterate over ParamSet

I would love to be able to iterate over a ParamSet rather than being limited to calling each p0(), p1() ... method. This would help me avoid having to do this:
for mut visibility in q.p0().p0().iter_mut() { /* ... */ }
for mut visibility in q.p0().p1().iter_mut() { /* ... */ }
for mut visibility in q.p0().p2().iter_mut() { /* ... */ }
for mut visibility in q.p0().p3().iter_mut() { /* ... */ }
// ...

Yep, fully on board with this existing. I suspect that implementing this will require some reflection-style code gen: iterating over fields is not typically supported in a straightforward way.

I think this impossible to implement from Bevy's side. Reflection can't work because that would require each of the items being iterated on implementing Reflect.
You might be able to define your own SystemParam and abstract that away though.

Given that ParamSet elements can have different types, this is likely not going to work without some dynamic dispatch or unsafe transmutation. Closing this out as this is likely not really feasible to do, nor are the benefits that clear here.


Use a connection pool

I noticed in ce721802a5cee716d97a64d05563efc5d0962fc5 there was mention of a desire for a connection pool. The crystal-lang/crystal-db shard is capable of managing pools of arbitrary connection types, including HTTP::Clients — really, anything with a close method).
This commit adds DB::Pool for a thread-safe, configurable connection pool. By default, it spins up a single connection on instantiation and will close all but one connection on checking connections back into the pool. This commit does not add configurability to that connection pool, but it can be added in a followup commit.
DB::Pool is used in several of my own shards that implement network clients:

https://github.com/jgaskins/kubernetes
https://github.com/jgaskins/redis
https://github.com/jgaskins/aws
https://github.com/jgaskins/elasticsearch
https://github.com/jgaskins/neo4j.cr (this actually uses a copy/pasted version of DB::Pool, which was the catalyst for https://github.com/crystal-lang/crystal-db/pull/131 enabling this functionality)

A couple other minor touches in this commit include:

removing a nil check on @callback
explicit assignment of that callback in before_request, favoring assignment from within the method signature
parsing JSON/Protobuf directly from the socket instead of reading the full body into memory, avoiding having multiple representations of the response in memory at once

These would've been separate PRs, but they would not have been able to be done concurrently due to merge conflicts so I shoveled them all in here. :smile:

Thanks for the contribution and detailed writeup @jgaskins; this looks really helpful and I wasn't aware that DB::Pool could be used for this. Give me a couple of days to try it on our side, then I will merge this PR and release a new shard version :)
Out of interest, are you considering using twirp & crystal at shopify?

I wasn't aware that DB::Pool could be used for this.

I added it a while back. I needed a generic connection pool that was more featureful than ysbaddaden/pool — elasticity, the ability to evict broken connections, etc. I originally offered to extract DB::Pool to its own shard, but the discussion ended up heading in the direction of just keeping the connection pool in the db shard.

are you considering using twirp & crystal at shopify?

Not to my knowledge. I work on infrastructure/SRE there, so I don't work on a lot of app features. I mostly get paged when things go wrong. 😄


Add a decompileCFR task

Might be useful if you want to diff the source.

humm, that last change was bad as it assumes the libs have been downloaded before the task is evaluated, and in the cast of Travis they hadnt

I think you should have written {it -> it.name} instead of just {it.name} possibly

{it.name} is perfectly valid. Although I would personally add whitespace for readability: { it.name }

Yeah, the issue is the library’s haven’t been downloaded when the args are processed. I’m going to diff the source with and without the libs to see if it’s even needed.

mind updating the base branch the pull request is targetting?

Undo adding libs as I dont think its required

It is required. Without libs, the decompiler will:

Be forced to add casts to every library method call (LibraryClass.doSomething((Something) something)) since it doesn't know that the call isn't ambiguous.
Be unable to correctly infer generics or remove unchecked casts since it needs the function signature which is in the library class.

now as we always download libs after the intermediary migration, consider adding libs back.


CLOUD-445 quick fix

@keyki pls review this change

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/745/


Izpack 5.0.6 - main branch of changes

This request handles preferably console installations and reactivates as much as possible unit and integration tests.
For me, this is the main candidate to get into 5.0.6, additionally to a couple of pull requests of contributors.
For more details, see the files changed or look at some of the issues here: https://izpack.atlassian.net/.

IzPack project » izpack #885 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

IzPack project » izpack #886 UNSTABLE
Looks like there's a problem with this pull request
(what's this?)

IzPack project » izpack #887 SUCCESS
This pull request looks good
(what's this?)

IzPack project » izpack #888 SUCCESS
This pull request looks good
(what's this?)

IzPack project » izpack #889 SUCCESS
This pull request looks good
(what's this?)

IzPack project » izpack #893 SUCCESS
This pull request looks good
(what's this?)


When installing throw pod jsonFile is nil

When constructing reverseGeoCoder in the constructor jsonFile is all the time nil.

@ramunasjurgilas  check #3  this should solve the issue.

@strfn thanks!


[PE-D][Tester C] Wrong error message

Input wrong prefixes displays unknown command error message instead, even though the command word was correct.

Labels: type.FunctionalityBug severity.Medium
original: sarrrdin/ped#3

Follow-up link:
https://github.com/sarrrdin/ped/issues/3#issuecomment-1296464794


custom hijack function not working as expected

In my application I have users that are designated as agents (but not staff) and users that those agents are assigned to.
I've written a custom hijack function to determine permission, but the hijacking seems to only works if I make the agents staff also.
Is there any way around this limitation?

Hi @chadgh
Thanks for filing this issue.
It seems that you are falling back to the defaults. Does your CUSTOM_HIJACK_HANDLER will be invoked during hijacking? The default settings had grown historically and we will rework them in the future. However, if yes, please provide more info to reproduce the behavior mentioned. The idea of the  CUSTOM_HIJACK_HANDLER is that you can do whatever you want.

Looks like it isn't actually calling the CUSTOM_HIJACK_HANDLER function, but when I try to go to something like /hijack/1 it redirects to /admin/login with some redirect params, but since the user isn't staff, the /admin/login url responds with 403 Forbidden.
Do I need to specify a different login endpoint?

Hijack currently requires at least staff access - all relevant view methods are decorated. That's the reason why you are redirected to the admin page first ...  This should be reworked for version 2.0. Can't give you an ETA on this at the moment.

+1
We've got a similar setup with staff, managers and users and we'd love to be able to use the custom handler with our own is_manager_or_above to allow managers hijacking capabilities.
(Thanks for all the awesome work on django-hijack!)


[bug] List of current associations empty, but only in one group

Version
Build/Run method

[X] Docker (k3s kubernetes)
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt version: 3.4.1
Openzwave Version: 1.6.-1
Describe the bug
Associations empty in one channel of keyfob (Devolo MT2653) while other channels seem ok.
To Reproduce
Steps to reproduce the behavior:

Go to 'groups'
For node, select keyfob (node 2)
For group, select 'Group C' -> list of current associations is empty
For any other group -> list of current associations shows associated nodes

Expected behavior
I would expect to see a list of current associations.
Additional context
The list of associations seems to to be retrieved correctly though. From the log, a while after starting up zwave2mqtt and refreshing node 2 (my keyfob):
2020-07-22 10:40:29.547 Info, Node002, Sending (Send) message (Callback ID=0xa7, Expected Reply=0x04) - MultiChannelAssociationCmd_Get (Node=2): 0x01, 0x0a, 0x00, 0x13, 0x02, 0x03, 0x8e, 0x02, 0x04, 0x25, 0xa7, 0xed
2020-07-22 10:40:29.547 Info, Node002, Encrypted Flag is 0
2020-07-22 10:40:29.557 Detail, Node002,   Received: 0x01, 0x04, 0x01, 0x13, 0x01, 0xe8
2020-07-22 10:40:29.557 Detail, Node002,   ZW_SEND_DATA delivered to Z-Wave stack
2020-07-22 10:40:29.721 Detail, Node002,   Received: 0x01, 0x07, 0x00, 0x13, 0xa7, 0x00, 0x00, 0x11, 0x5d
2020-07-22 10:40:29.722 Detail, Node002,   ZW_SEND_DATA Request with callback ID 0xa7 received (expected 0xa7)
2020-07-22 10:40:29.722 Info, Node002, Request RTT 173 Average Request RTT 532
2020-07-22 10:40:29.723 Detail, Node002,   Expected callbackId was received
2020-07-22 10:40:30.495 Detail, Node002,   Received: 0x01, 0x14, 0x00, 0x04, 0x00, 0x02, 0x0e, 0x8e, 0x03, 0x04, 0x0a, 0x00, 0x00, 0x0e, 0x01, 0x11, 0x01, 0x1b, 0x01, 0x0e, 0x02, 0x69
2020-07-22 10:40:30.495 Detail,
2020-07-22 10:40:30.495 Info, Node002, Response RTT 947 Average Response RTT 1056
2020-07-22 10:40:30.496 Info, Node002, Received MULTI_CHANNEL_ASSOCIATION_REPORT from node 2, group 4
2020-07-22 10:40:30.497 Info, Node002,   The group contains:
2020-07-22 10:40:30.497 Info, Node002,     Node 14 End Point 1
2020-07-22 10:40:30.498 Info, Node002,     Node 17 End Point 1
2020-07-22 10:40:30.498 Info, Node002,     Node 27 End Point 1
2020-07-22 10:40:30.498 Info, Node002,     Node 14 End Point 2
2020-07-22 10:40:30.498 Info, Node002, Querying associations for node 2 is complete.
2020-07-22 10:40:30.499 Detail, Node002,   Expected reply and command class was received
2020-07-22 10:40:30.499 Detail, Node002,   Message transaction complete
2020-07-22 10:40:30.501 Detail,
2020-07-22 10:40:30.501 Detail, Node002, Removing current message
2020-07-22 10:40:30.501 Detail,

But querying the associations returns an empty list:
2020-07-22T10:48:16.923Z z2m:App Zwave api call: getAssociations [ 2, 4 ]
2020-07-22T10:48:16.924Z z2m:Zwave Success zwave api call getAssociations []

While it does work fine for other channels:
2020-07-22T10:48:15.012Z z2m:App Zwave api call: getAssociations [ 2, 2 ]
2020-07-22T10:48:15.013Z z2m:Zwave Success zwave api call getAssociations [ 3 ]

Group 4 is the only group that does not show associations, even though it definitely has (the keyfob turns on lights and ozw logs show the associations are reported). Though group 4 is the only one with multiple associations. I ended up with 4 associations since I added a few while looking for why the list of current associations is empty. So it seems possible to add more associations, but I'm also unable to remove any of the associations (which might be related or a completely different problem)

Just for reference:
this is the method used on ozw shared https://github.com/OpenZWave/node-openzwave-shared/blob/master/src/openzwave-groups.cc#L46
That calls: http://www.openzwave.net/dev/classOpenZWave_1_1Manager.html#a20176eafcbf7cb117d8a137ef17b48e0
I cannot find any errors in how them are called, it may be some compatibility problem of that specific device? Anyway you could manually call those method using mqtt apis to manually remove nodes that are not present in the list.
I don't know how to help you there as on my side everything seems correct

it may be some compatibility problem of that specific device?

I can't tell for sure since I don't have a second Z-Wave network to test with, but I'd be surprised if it's a problem with the device. It's some time ago that I last updated associations, but I didn't have problems with it yet. Also the correct associations seem to be received. This looks more like the list of associations are lost in z2m or in ozw for some reason.

Anyway you could manually call those method using mqtt apis to manually remove nodes that are not present in the list.

Unfortunately I'm not so familiar with using the API manually. Could you point me into the right direction for which method to call and how to do that?

https://github.com/OpenZWave/Zwave2Mqtt#zwave-apis
<mqtt_prefix>/_CLIENTS/ZWAVE_GATEWAY-<mqtt_name>/api/removeAssociation/set
Payload:
{
  "args": [nodeid, group, targetnode]
}

The same for addAssociation
The result of this call will be published in
<mqtt_prefix>/_CLIENTS/ZWAVE_GATEWAY-<mqtt_name>/api/removeAssociation

Thanks! I was able to remove/add associations using addAssociation/removeAssociation this way.
From what I see, the list of current association doesn't list associations with instance ids. E.g. the same group (group 4 on node 2) works fine when I add an association to node 15 (using args [2, 4, 15]). The association shows fine in the UI. If I however add an association with an instance id, e.g. endpoint 2 on node 27 (args [2, 4, 27, 2]), it doesn't show this association in the UI and getAssociations doesn't return it (but it does work on the device). If I add multiple associations, only the ones without an instance id are shown. Ozw debug log correctly lists all associations, so this might be a bug in z2m?

@zargony In fact you are right. Just noticed that there is an override of getAssociations method (http://www.openzwave.net/dev/classOpenZWave_1_1Manager.html#a9b94e5df2e6ea1fbefb786f9f078a01d) that should make the work. I need to understand how to implement this on openzwave shared.
Are you familiar with cpp?

I have found it: https://github.com/OpenZWave/node-openzwave-shared/blob/master/src/openzwave-groups.cc

Cool, thanks for the quick response!
(I'm having troubles cross-building an arm64 image on my Mac to test it, but I'll try asap when I can build on a real Linux)

Isn’t it already available on dockerhub? I mean the arm64 image

Daniel

On 23 Jul 2020, at 23:12, Andreas Neuhaus<EMAIL_ADDRESS>wrote:

Cool, thanks for the quick response!
(I'm having troubles cross-building an arm64 image on my Mac to test it, but I'll try asap when I can build on a real Linux)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Isn’t it already available on dockerhub? I mean the arm64 image

From what I see, images of PRs are built but not pushed to Docker Hub.

Nope, dev tag is used for this :) it is builded on every commit to master branch

Ops sorry I misunderstood, you right I thought the pr was merged. Wait a moment

@zargony dev branch will be the feature in an hour or less, let me know :) This will be available in next release 4.0.0

List of current associations shows fine now. Cool, thanks a lot!
But I still can't seem to remove an association with an instance id. It works for associations without an instance id, but not for associations with an instance id. It looks like the instance id isn't passed to the API call, because ozw log states
2020-07-24 10:37:47.174 Info, Node002, MultiChannelAssociation::Remove - Removing End Point 0 on node 28 from group 4 of node 2

(end point 0 even though I set instance id to 5 on the web page)
Some UX thoughts:

it would certainly be easier to remove an association if you could just select it in the list of current associations and press "remove"
it shows "instance id: 0" for associations without an instance id now, which might be confusing. I think it's common practice to not show the instance id at all if it's 0, e.g. just Node 5, but Node 5, instance 2 or Node 5.2 for instance id 2.

You have to enable multi instance switch end specify the instance there when instance is > 0

I did enable the multi instance switch and specified an instance id > 0. It works for adding a new association, but doesn't seem to work for removing an existing association.

I think I forgot to add instance in removeAssociation call, will fix that tomorrow thanks for the report :)

Daniel

On 27 Jul 2020, at 20:10, Andreas Neuhaus<EMAIL_ADDRESS>wrote:

I did enable the multi instance switch and specified an instance id > 0. It works for adding a new association, but doesn't seem to work for removing an existing association.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

@zargony fixed this too, available on dev branch if you are interested to test it :)

fixed this too, available on dev branch if you are interested to test it :)

@robertsLando Works fine, thanks a lot! (though the UI could be improved at some time ;) )

@zargony I have many UI improvments in my TodoS, What I miss is time :( I try to focus on make things work for now


[UI] Wallet buttons should adjust to lower resolutions

On lower resolution screen, wallet buttons (Receive, Scan, Send) are too big. Something like @gocodingnow/rn-size-matters could deal with it.

Fix released in v0.0.5-alpha.4. Issue will be closed after testing on few devices.
How to get the fix "over-the-air": Go to Settings, you should see 1 pending update in Update manager, click Update and restart - over-the-air updates are opt-in.

v0.0.8-alpha.3 now adjusts all text elements sizes to the screen size.


Install version 0.11.2 of the operator

Fixes: https://github.com/stolostron/backlog/issues/19464
Signed-off-by: Mike Kolesnik<EMAIL_ADDRESS>

/lgtm
/approve


[7.x.x] Bump Dependencies #5113337688

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/5113337688

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


failed deploying service 'web'

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce
Deploy the application from scratch using azd up command.
The message pops up after the documents have been uploaded to Azure Blob Storage and indexed in Azure Search
Any log messages given by the failure

Deploying services (azd deploy)
(x) Failed: Deploying service web
ERROR: failed deploying service 'web': failing invoking action 'deploy', planning provisioning: planning infrastructure provisioning: creating parameters file: reading parameter file template: open C:\Dev\azure-search-openai-demo-csharp\infra\web.parameters.json: The system cannot find the file specified.

Expected/desired behavior
App and resources deploy successfully
OS and Version?
Windows 11
Mention any other details that might be useful

Thanks! We'll be in touch soon.

Closing issue as stale. Deployments are more reliable in the latest versions of the app.


strange phenomenon

when I click the cell， cell will get bulge border . It looks  like  the photo shows.

could you please show me your code? thanks.


SECOND ISSUE IS THAT WHEN THE APP STARTS FROM THE [StartupView] AND NAVIGATES TO THE [NESTED ROUTE VIEW], AN ERROR IS THROWN WHICH IS "Multiple widgets used the same GlobalKey."
BUT WHEN THE APP STARTS DIRECTLY TO THE NESTED ROUTE VIEW THEN THE ERROR IS NOT THROWN.

I BELIEVE THIS SECOND ERROR HAS TO STILL DO WITH THE WAY
THE NESTED NAVIGATION IS SET UP.
  APP

Hmm @ferrarafer  the issue is that I can't use route names to navigate into a nested route but I can Navigate to the View by passing the widget. The issue is why that isn't happening, since the difference just between named routes and widget routing. Becuase Internally when I provide the Extended navigator id to the navigation service, GetX uses the Id provided to find the nested navigator key and it navigates inside its parent but when I do the same with a named route it says the route can't be found, even the generated code creates a separate for UserView names UserViewRoutes, so technically its suppose to work, but I think the issue is from how the routes are setup. Lets wait and see what @FilledStacks thinks when he properly looks at the minimal project, especially the router generated code.

After looking at your implementation I can see the issue and Fernando is right, and wrong 😊 When you’re creating a nested route with UserView you’re telling Stacked that “The user view has its own set of routes with its own router inside it”.
This means that the UserView has to use that Router in order for you to navigate to the routes within it. You can think of the View that has the nested routes as the “Housing View”. It’s only purpose is to setup the router for the nested views and show the initial view. This is an over simplification because it can have its own UI, but you have to use the router in it.
So if you update your UserView to this
class UsersView extends StatelessWidget {
  const UsersView({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    log('UsersView.build()');
    return ViewModelBuilder<UsersViewModel>.reactive(
      builder: (context, model, child) => ExtendedNavigator(
        router: UsersViewRouter(),
        navigatorKey: StackedService.nestedNavigationKey(userRouterId),
        initialRoute: UsersViewRoutes.usersLandingView,
      ),
      viewModelBuilder: UsersViewModel.new,
    );
  }
}

What that means is when you navigate to your UsersView you use the normal navigator since it’s at the root level of your navigator. To navigate within that navigator you then use the nestedNavigationKey.
To make the example work add a new view that's your default view.stacked create view usersLandingView and move your old UI in there. Then you can update your app.dart file to the following.
MaterialRoute(
  page: UsersView,
  children: [
    MaterialRoute(page: UsersLandingView),
    MaterialRoute(page: UserDetailsView),
  ],
),

It works on my side using the normal named navigation.

@ferrarafer this should move to the docs as well. We'll add some more docs as we get our content pipeline streamlined.

Great, I will try it out in my production project. @FilledStacks can you also verify that this current implementation fixes the issue with Flutter complaining about duplicate keys in the widget tree.

Yes, that happens due to the miss use of the routers.


Types of functions in hip_api.h not consistent with HIP runtime and GCC

For example, in HIP-CPU __ffsll is defined with std::uint64_t:
std::uint32_t __ffsll(std::uint64_t x) noexcept
{
    return hip::detail::bit_scan_forward(x);
}

But in the HIP runtime (CLR) and in GCC it is defined with unsigned long long int:
__device__ static inline unsigned int __ffsll(unsigned long long int input) {
    return ( input == 0 ? -1 : __builtin_ctzll(input) ) + 1;
}

When calling HIP-CPU's implementation of __ffsll with unsigned long long int, it will throw a compiler error:
/workspaces/amd/libraries/rocRAND/library/include/rocrand/rocrand_sobol64.h:178:26: error: call to '__ffsll' is ambiguous
        unsigned int z = __ffsll(~x);
                         ^~~~~~~
/workspaces/amd/libraries/rocRAND/build/deps/hip-cpu/include/hip/hip_api.h:95:15: note: candidate function
std::uint32_t __ffsll(std::int64_t x) noexcept
              ^
/workspaces/amd/libraries/rocRAND/build/deps/hip-cpu/include/hip/hip_api.h:101:15: note: candidate function
std::uint32_t __ffsll(std::uint64_t x) noexcept

In the above code block, x is defined as unsigned long long int x.
This makes HIP-CPU not 100% compatible with otherwise valid HIP (GPU) code.

Should I make a PR for this or does this require some discussion first?

Thank you for flagging this. I'd say that this is a historical misjudgement on my part, and that what you are suggesting is correct (matching the HIP public interface).


Tabs title with utf8 characters

Hello,
I used Bootstrap 3 shortcodes Drupal port for a project, where I implemented Bootstrap Tabs. There seems to be a bug when using UTF-8 characters in the tabs title. I used greek and the output was broken, and so was the functionality. This is because, when building the unordered list with the  tags, PHP does not parse the html string as utf-8, so the href attributes get broken.
The problem lies in bs_shortcodes.module @ line 1144
loadHTML($content);
?>
The $content variable contains a string of html-text, but as this is not a complete HTML document, there are no meta data to instruct the parser about the encoding.
As it is mentioned in the official documentation: http://php.net/manual/en/domdocument.loadhtml.php
there can be two solutions for the problem:

Replace line 1144 with:

loadHTML('<meta http-equiv="content-type" content="text/html; charset=utf-8">' . $content);
?>

Replace line 1144 with:

loadHTML(mb_convert_encoding($content, 'HTML-ENTITIES', 'UTF-8'));
?>
I tried both of them and they both seem to work. I'm not really sure which is the most correct.
I will created two patches, one for each solution, and posted them to the modules issue queue:
https://www.drupal.org/node/2458569
Steps to reproduce:

Install a bootstrap 3 subtheme.
Install bs_shortcodes module (shortcode module is a dependency).
Enable Shortcodes filter in FULL HTML text format, and in the filter settings below check "Enable tab shortcode" and "Enable tabs shortcode" options.
Create a node and include this text in body:

[tabs type="tabs"]
[tab title="Αρχική" active="true"]
Δοκιμαστικό κείμενο 1[/tab]
[tab title="Προφίλ"]
Δοκιμαστικό κείμενο 2[/tab]
[tab title="Σχετικά"]
Δοκιμαστικό κείμενο 3[/tab]
[/tabs]

Thank you for this report. Unfortunately we don't maintain the Drupal port of this plugin. You may want to talk to @jjroelofs about implementing your proposed fix in the port.
We've already fixed this issue in the WordPress plugin (see here:
https://github.com/filipstefansson/bootstrap-3-shortcodes/blob/master/bootstrap-shortcodes.php#L1991).


[gardening] Rename files in Formatters group to match the class names

@swift-ci test

looks good to me


Feature/external stub func

This PR is a further improvement upon https://github.com/apache/arrow/pull/38116
In this PR, registering gandiva external stub function is supported

An official PR is submitted to Arrow, so close this one.


MoltenVK standalone lib incorrectly reports VK_EXT_debug_utils as available

When linking to MoltenVK directly (not libvulkan), the results of the instance query vkEnumerateInstanceExtensionProperties() shows the VK_EXT_debug_utils instance extension as available.  I then include VK_EXT_debug_utils in vkCreateInstance() to enable the extension.  However, when I later attempt to define the following procvars I get null pointers in return:
	vkGetDeviceProcAddr( vkcontext.device, "vkQueueBeginDebugUtilsLabelEXT" )
	vkGetDeviceProcAddr( vkcontext.device, "vkQueueEndDebugUtilsLabelEXT" )
	vkGetDeviceProcAddr( vkcontext.device, "vkCmdBeginDebugUtilsLabelEXT" )
	vkGetDeviceProcAddr( vkcontext.device, "vkCmdEndDebugUtilsLabelEXT" )
	vkGetDeviceProcAddr( vkcontext.device, "vkCmdInsertDebugUtilsLabelEXT" )

However, if I link to libvulkan.dylib instead of MoltenVK.dylib, the above procvars are properly defined and are not null.
Perhaps MoltenVK should not be reporting VK_EXT_debug_utils as available when packaged as a standalone lib vs. being included as part of libvulkan.  Or is the functionality truly meant to be present, but not wired correctly when standalone?

Since VK_EXT_debug_utils is an instance extension, MoltenVK returns those function pointers via the vkGetInstanceProcAddr() call.

Using vkGetInstanceProcAddr() works perfectly - thank you very much.
It's interesting that libvulkan seems to cover over this difference and somehow allows vkGetDeviceProcAddr() to handle this case.  MoltenVK is more strict but correct.  Strange, but live and learn...

Thanks for the feedback. Closing this now.


ggplot installs for python<IP_ADDRESS>, but import ggplot gets error re pandas attribute tslib

ggplot-0.11.5-py2.py3-none-any.whl from pypi.org will install on python<IP_ADDRESS> using the WinPython Control Panel. However, when I use IDLE GUI to do "import ggplot", I get the error:
Traceback (most recent call last):
File "<pyshell#29>", line 1, in
import ggplot
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\ggplot_init_.py", line 19, in
from .geoms import geom_area, geom_blank, geom_boxplot, geom_line, geom_point, geom_jitter, geom_histogram, geom_density, geom_hline, geom_vline, geom_bar, geom_abline, geom_tile, geom_rect, geom_bin2d, geom_step, geom_text, geom_path, geom_ribbon, geom_now_its_art, geom_violin, geom_errorbar, geom_polygon
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\ggplot\geoms_init_.py", line 1, in
from .geom_abline import geom_abline
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\ggplot\geoms\geom_abline.py", line 1, in
from .geom import geom
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\ggplot\geoms\geom.py", line 3, in
from ..ggplot import ggplot
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\ggplot\ggplot.py", line 13, in
from .aes import aes
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\ggplot\aes.py", line 11, in
from . import utils
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\ggplot\utils.py", line 81, in
pd.tslib.Timestamp,
File "C:\WinPython\python-3.9.1.amd64\lib\site-packages\pandas_init_.py", line 258, in getattr
raise AttributeError(f"module 'pandas' has no attribute '{name}'")
AttributeError: module 'pandas' has no attribute 'tslib'
Is this project supported on python3? If not, please update docs at pypi.org and other places to show python2 only / deprecated.

@jrbrearley A temporary solution could be to change the imports in ggplot2
https://stackoverflow.com/questions/58143253/module-pandas-has-no-attribute-tslib
This is not pretty though and could really do with a PR

Pretty disappointed that this issue is over a year old and this package is unusable currently.
Python2 has been completely depreciated.


S31 other sensor measurements

Is there any way to get power factor, reactive power, apparent power or any other measurements from a Sonoff S31 device?  As far as I can tell only power, voltage and current is available at the moment.  Is that all there is?

It this info provided in ewelink app?

No. That is all that eWeLink shows as well.

If this info isn't displayed in ewelink app, this component also can't display it


Boundary alignment regression

It seems that the boundary alignment has regressed in a recent update of the package.

Notice that in this screenshot, from the main.dart example, the pin is outside the bounds despite the bounds boundary being enabled.  In previous versions of the sample, the boundary alignment would force the red rectangle to be within the inset bounds.
Coincidentally, I was running this same sample against 0.0.3 and everything was working correctly.

I just tested v0.0.4+1 (8c33543f67da8d357ae533e45cbfa35115d290a8)  and everything works fine for this commit.


tickets/DM-34405: Modernize cachemachine

Merging now before master can change out from under me again.


Update tools.js's TOOL_RECTANGLE so that rectangles have sharp edge, working around weirdness in latest Firefox

As discussed in https://github.com/1j01/jspaint/issues/326, the drawing of rectangles show a blurred/anti-aliased edge in the recent versions of Firefox.  This change restores sharp edges in Firefox.  The change is modeled after how the existing code  handles the degenerate case of drawing the rectangle (when the rectangle is either not as tall or not as wide as double the rectangle line width), but this version just draws four rectangles, one for each side.  There's probably a lot more efficient ways to do this, but this was the simplest fix that fit in with the paradigm that I saw.

Thank you!


Task: Hide GitHub token in the example_processor tool

Description:

Set the environment variable using the following code
import os
os.environ['GITHUB_TOKEN'] = 'your_github_token_here'

use the environment variable in your code like this:
token = os.environ.get('GITHUB_TOKEN')

Create a testcode for the example_processor code

Acceptance Criteria:

[ ] Code should identify missing examples
[ ] inject examples into the codebase
[ ] create a pull request for the user

Automating the process all the way up to pushing to a branch of your fork sounds like a great addition. Even if the example generation tool isn't wanted, adding this functionality to the tool sounds like a great addition. Then we can refine the AI gen process to get things that are wanted.


[Feature]: Integrate driftctl in the mlinfra cli

Describe the Feature
driftctl would be a great addition to the mlinfra cli which would allow users to get the state drift right at their finger tips
Importance of the Feature
From driftctl website: Drift can have multiple causes: from developers creating or updating infrastructure through the web console without telling anyone, to uncontrolled updates on the cloud provider side. Handling infrastructure drift vs the codebase can be challenging. This would help us fix this issue.
Also add checks to see if the driftctl cli is installed beforehand before using it.
Additional context
No response
Feature Category
MLOps Stack Application

driftctl is being discontinued by snyk. Closing this issue.


epubcheck: 4.2.4 -> 4.2.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/w3c/epubcheck/releases.
meta.description for epubcheck is: "Validation tool for EPUB"
meta.homepage for epubcheck is: "https://github.com/w3c/epubcheck"
meta.changelog for epubcheck is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.2.5 with grep in /nix/store/xcgdrs4kzr5q3qkn8crd9f6z37ci850a-epubcheck-4.2.5

directory tree listing: https://gist.github.com/e74727421bf58b8df95eb0d0e21efa35

du listing: https://gist.github.com/00bec55e3677732d8b63aebec414dbba

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
epubcheck

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xcgdrs4kzr5q3qkn8crd9f6z37ci850a-epubcheck-4.2.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A epubcheck https://github.com/r-ryantm/nixpkgs/archive/a3c35acbb830cab4f483704c289d1ca7c30907d9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xcgdrs4kzr5q3qkn8crd9f6z37ci850a-epubcheck-4.2.5
ls -la /nix/store/xcgdrs4kzr5q3qkn8crd9f6z37ci850a-epubcheck-4.2.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

epubcheck

Maintainer pings
cc @eadwu for testing.

Result of nixpkgs-review pr 117432 at a3c35acb run on x86_64-linux 1

1 package built successfully:

epubcheck

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/text/epubcheck/default.nix:17:3:
   |
17 |   installPhase = ''
   |   ^

new release available


change the button href for "text" contact buttons

welp i changed the appearance of the button but did not actually change the href of the button as was the original request in #396 🤦
this pr changes the button from a tel: link to a sms: link
curious what the behavior is on desktop since my laptop has the Messages app blocked 😢
example with the "text" button enabled: https://deploy-preview-420--tsml-ui.netlify.app/tests/times.html?meeting=monday-7pm

on ios i can confirm this hands off properly to the messages app - i'll test on android as well tonight


Occupancy Sensors

When adding Occupancy Sensors to the Config, do you use the integration ID for the occupancy sensor or the room?  From the integration guide, it seems like you would be getting this info from the room, which may include more than one occupancy sensor.
For this house, which would we use:
Powder Room	 Powder Room Sensor	 Device 001	 LRF2-OCR2B-P-WH	17
Parents Bathroom	 MAster Bath Sensor	 Device 001	 LRF2-OCR2B-P-WH	18
Kids Bathroom	 Bath 3 Sensor	 Device 001	 LRF2-OCR2B-P-WH	19
Parents Bathroom	82
Kids Bathroom	86
Powder Room	78
Thanks.

Yes for occupancy sensors use the room id. Lutron reports the whole room as active when any occupancy sensor in that room detects motion and inactive when none do
so use
Parents Bathroom 82
Kids Bathroom 86
Powder Room 78
dear lord you have a lot of rooms lol


Editor Camera Bug

Godot version:
Godot 3 official release
Issue description:
When navigating in the Editor using WASD keys and mouse .. you can stuck in free looking mode
Steps to reproduce:
start navigating using WASD keys and mouse .. then do mouse wheel up or down , now if you release every key you can still rotate the Editor camera and look around .. this should not happen

Closed as duplicate of #14373 (and looks like its fixed already)


bug: attribute "color" on ion-list wont have any effect

Bug Report
Ionic version:

[x] 5.0.5
Current behavior:

Applying color attribute to ion-list wont have any effect. I remember in Ionic 4 it was possible to style the whole list with e.g. color="primary" .
Now i have to apply it to every ion-item
Expected behavior:

It should be possible again to apply color attribute to ion-list
Steps to reproduce:

copy paste this snippet to any page
  <ion-list color="primary>
    <ion-item detail="true">
      <ion-label>test</ion-label>
    </ion-item>
    <ion-item detail="true">
      <ion-label>test</ion-label>
    </ion-item>
    <ion-item detail="true">
      <ion-label>test</ion-label>
    </ion-item>
    <ion-item detail="true">
      <ion-label>test</ion-label>
    </ion-item>
    <ion-item detail="true">
      <ion-label>test</ion-label>
    </ion-item>
    <ion-item detail="true">
      <ion-label>test</ion-label>
    </ion-item>
    <ion-item detail="true">
      <ion-label>test</ion-label>
    </ion-item>
  </ion-list>

list remains white

Other information:

Ionic info:

Ionic:

   Ionic CLI                     : 6.2.2 (/usr/local/lib/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.1.0-dev.202003171608.9d9a02f
   @angular-devkit/build-angular : 0.900.5
   @angular-devkit/schematics    : 9.0.5
   @angular/cli                  : 9.0.5
   @ionic/angular-toolkit        : 2.2.0

Capacitor:

   Capacitor CLI   : 1.5.0
   @capacitor/core : 1.5.0

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : none
   Cordova Plugins   : no whitelisted plugins (1 plugins total)

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   ios-deploy : 1.10.0
   ios-sim    : 8.0.2
   NodeJS     : v12.16.0 (/usr/local/bin/node)
   npm        : 6.13.4
   OS         : macOS Catalina
   Xcode      : Xcode 11.3.1 Build version 11C504

Thanks for the issue. ion-list does not have a color property, so this would not have worked even in v4.
v5 example: https://codepen.io/liamdebeasi/pen/rNVrVBX
v4 example: https://codepen.io/liamdebeasi/pen/XWbBbXJ
Can you provide a repo of this working in a v4 application?

You're right.
Maybe it was later back in Ionic 3.
I'll change this to a feature request!

Thanks for the follow up! I discussed this with the team and decided cascading the color property is not something we are looking to add to the framework at this time. In your use case, this can be achieved using CSS:
:root {
  --ion-color-primary: #3880ff;
}

ion-list ion-item {
  --background: var(--ion-color-primary);
}


FIX: resilient environment settings

Overview
if the application uses generalimport to manage optional dependencies, it's possible that generalimport.MissingOptionalDependency is raised. In this case, we should not report the module as it is not actually loaded and is not a runtime dependency of the application.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #825 (98bf646) into main (90ccb4c) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   76.39%   76.38%   -0.01%
==========================================
  Files         198      198
  Lines       19327    19330       +3
  Branches     3307     3307
==========================================
+ Hits        14765    14766       +1
- Misses       3716     3718       +2
  Partials      846      846

Impacted Files
Coverage Δ

newrelic/core/environment.py
60.30% <75.00%> (-0.64%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hey @aaeabdo - could you sign the Contributor License Agreement real quick? Then I can merge this in.

@aaeabdo Ah probably just a timing issue with CI. Rebasing to the latest and re-running the tests.

Hey @aaeabdo - could you sign the Contributor License Agreement real quick? Then I can merge this in.

Hey @hmstepanek, I did earlier #825 (comment) - is this another one?

Oh! Probably just a timing issue between when you signed it and when the CI check ran then. I'm updating your branch to the latest base and re-running CI checks now...


ebiten: TestImagePixels failed with EBITEN_GRAPHICS_LIBRARY=opengl on macOS

--- FAIL: TestImagePixels (0.04s)
panic: opengl: creating framebuffer failed: gl.IsFramebuffer returns false [recovered]
        panic: opengl: creating framebuffer failed: gl.IsFramebuffer returns false

goroutine 57 [running]:
testing.tRunner.func1.2({0x423f000, 0xc00046a1b0})
        /usr/local/go/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
        /usr/local/go/src/testing/testing.go:1392 +0x39f
panic({0x423f000, 0xc00046a1b0})
        /usr/local/go/src/runtime/panic.go:838 +0x207
github.com/hajimehoshi/ebiten/v2/internal/ui.(*Image).At(0xc00000e288, 0x41291b8?, 0x42627e0?)
        /Users/hajimehoshi/ebiten/internal/ui/image.go:92 +0xb8
github.com/hajimehoshi/ebiten/v2.(*Image).at(0xc000317e28?, 0x412910c?, 0x42cf540?)
        /Users/hajimehoshi/ebiten/image.go:708 +0x46
github.com/hajimehoshi/ebiten/v2.(*Image).At(0x42e7831?, 0x42cf540?, 0xc0000b60cc?)
        /Users/hajimehoshi/ebiten/image.go:681 +0x19
github.com/hajimehoshi/ebiten/v2_test.TestImagePixels(0xc000480680)
        /Users/hajimehoshi/ebiten/image_test.go:106 +0x2b5
testing.tRunner(0xc000480680, 0x4292cc8)
        /usr/local/go/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
        /usr/local/go/src/testing/testing.go:1486 +0x35f
FAIL    github.com/hajimehoshi/ebiten/v2        1.607s

/CC @TotallyGamerJet

@TotallyGamerJet, could you take a look? Thanks!

I'll revert your change (f7e21983cf9fba08253af0a365eb38decd25e0cf) once. Sorry I should have checked all the tests before merging.

@hajimehoshi I'm not sure why it failed for you because the tests passed for me. I'll look into a solution.

Ok, I'll also take a look, thanks

@TotallyGamerJet Just in case, did you use -count=1 when you run the tests? Even if you just  changed an environment variable, the test might not be be executed due to cache.

Apparently GenFramebufferEXT fails and the new framebuffer value is sometimes 0. The behavior is very flaky. I'll take a look further.

@hajimehoshi I haven't been able to figure out what is wrong with the assembly files. I have determined that using syscall.syscallX for three or less argument functions solves the issue consistently. This fix works on both arm64 and amd64. Do you want me to push a PR to purego with this change?

To be clear, I have gone over the arm64 calling convention and there isn't anything inherently wrong with the way purego calls the functions. And it works for other functions without issues

@TotallyGamerJet So you could reproduce the issue, right? Yes, I would like you to create a PR for purego. Thanks!

I was able to reproduce the issue! Still not clear why it passed before even after clearing test cache. I made a PR for purego.

Yes, please!


Add a label precision option as in MagresView 1.6

Expanding on issue raised by @AKM2022

Number of decimal places should work. Only exception may be asymmetry parameters (which lie between zero and 1). Perhaps kludge this by using N+1 places for any such parameters?

This has now been added in the CCP-NC fork. Closing the issue here.


DBZ-5122 Include Oracle Debezium Connector in Debezium Server distribution

DBZ-5122 Include Oracle Debezium Connector in Debezium Server distribution
also checked the lib folder of Debezium Server distribution for duplicate libraries with different version and there is none

I'm not sure whether this will be adequate.  The Oracle connector doesn't ship with the driver due to licensing restrictions, won't we need to explicitly depend on the Oracle odjcb8.jar in the pom, excluding that dependency in the distribution archive so that all the Quarkus compile-time and classpath bindings are satisfied?  @jpechane wdyt?

Exactly neither oracle JDBC driver nor xstream JAR can be present in the distribution.

@Naros, @jpechane The change only includes the Oracle Connector without Oracle driver and xtream. We should also add to the Debezium Server documentation a link to the "Obtaining the Oracle JDBC driver and XStream API files" section of the Oracle Connector documentation

OK, I can confirm the forbidden dependencies are not present as they are marked as provided.
@ggaborg Could you please provide the docs update and we can merge the PR? Thanks

@ggaborg Applied, thanks!


feat: 🎸 update sdk to support private v2 chains (public v7)

Description
add dual version support for private v1/v2 chains
Breaking Changes

JIRA Link
DA-1365
Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward

:tada: This PR is included in version 2.0.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Added docs for Append and Flush leasing operations

Continued from https://github.com/Azure/azure-rest-api-specs/pull/21311


Image for SILKLIFE issue#45

Old image

New image

Old image

New image

Too many changes inside 1 PR.  Do less


Poppins font added

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
Closes issue: #1018
Description
[Please include a brief description of the changes or features added]
I have changed the website's default font to poppins
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:

[x] I have performed a self-review of my code
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

add some screenshot of changes made

screen shots:

There should be some spacing between AgriLearnNetwork and home option. Apply font in blog and about page also.

shall i create a new PR for spacing between AgriLearn Network?

And would you kindly add level1 and gssoc labels to this PR.

And would you kindly add level1 and gssoc labels to this PR.

it will be added in the final PR

ok


Create remove_duplicates.py

For: https://github.com/hanshulll/Hacktoberfest2021/issues/1

@gitshashwat
Congrarts🥳 your PR has been merged.


ValueError: Got more bytes so far than requested

There seems to be an issue with using fsspec to fetch large-ish files over http:
import fsspec
import xarray as xr
with fsspec.open("http://test.opendap.org/opendap/data/nc/coads_climatology2.nc") as f:
    ds = xr.open_dataset(f)

Full error message:

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-5-4b2387e53223> in <module>
      2 import xarray as xr
      3 with fsspec.open("http://test.opendap.org/opendap/data/nc/coads_climatology2.nc") as f:
----> 4     ds = xr.open_dataset(f)

~/.local/share/virtualenvs/condaenv-AbcDeF1z/lib/python3.7/site-packages/xarray/backends/api.py in open_dataset(filename_or_obj, group, decode_cf, mask_and_scale, decode_times, autoclose, concat_characters, decode_coords, engine, chunks, lock, cache, drop_variables, backend_kwargs, use_cftime)
    524                 "with engine='scipy' or 'h5netcdf'"
    525             )
--> 526         engine = _get_engine_from_magic_number(filename_or_obj)
    527         if engine == "scipy":
    528             store = backends.ScipyDataStore(filename_or_obj, **backend_kwargs)

~/.local/share/virtualenvs/condaenv-AbcDeF1z/lib/python3.7/site-packages/xarray/backends/api.py in _get_engine_from_magic_number(filename_or_obj)
    118                 "manager"
    119             )
--> 120         magic_number = filename_or_obj.read(8)
    121         filename_or_obj.seek(0)
    122

~/.local/share/virtualenvs/condaenv-AbcDeF1z/src/fsspec/fsspec/implementations/http.py in read(self, length)
    257         else:
    258             length = min(self.size - self.loc, length)
--> 259         return super().read(length)
    260
    261     def _fetch_all(self):

~/.local/share/virtualenvs/condaenv-AbcDeF1z/src/fsspec/fsspec/spec.py in read(self, length)
   1045             # don't even bother calling fetch
   1046             return b""
-> 1047         out = self.cache._fetch(self.loc, self.loc + length)
   1048         self.loc += len(out)
   1049         return out

~/.local/share/virtualenvs/condaenv-AbcDeF1z/src/fsspec/fsspec/core.py in _fetch(self, start, end)
    596         ):
    597             # First read, or extending both before and after
--> 598             self.cache = self.fetcher(start, bend)
    599             self.start = start
    600         elif start < self.start:

~/.local/share/virtualenvs/condaenv-AbcDeF1z/src/fsspec/fsspec/implementations/http.py in _fetch_range(self, start, end)
    311                         raise ValueError(
    312                             "Got more bytes so far (>%i) than requested (%i)"
--> 313                             % (cl, end - start)
    314                         )
    315                 else:

ValueError: Got more bytes so far (>5242929) than requested (5242888)

The example test NetCDF file above is actually just 5.2MB in size. However, trying it on a smaller file of just 3.0MB works:
import fsspec
import xarray as xr
with fsspec.open("http://test.opendap.org/opendap/data/nc/coads_climatology.nc") as f:
    ds = xr.open_dataset(f, decode_times=False)
    print(ds)

<xarray.Dataset>
Dimensions:  (COADSX: 180, COADSY: 90, TIME: 12)
Coordinates:
  * COADSX   (COADSX) float64 21.0 23.0 25.0 27.0 ... 373.0 375.0 377.0 379.0
  * COADSY   (COADSY) float64 -89.0 -87.0 -85.0 -83.0 ... 83.0 85.0 87.0 89.0
  * TIME     (TIME) float64 366.0 1.096e+03 1.827e+03 ... 7.671e+03 8.401e+03
Data variables:
    SST      (TIME, COADSY, COADSX) float32 ...
    AIRT     (TIME, COADSY, COADSX) float32 ...
    UWND     (TIME, COADSY, COADSX) float32 ...
    VWND     (TIME, COADSY, COADSX) float32 ...
Attributes:
    history:  FERRET V4.30 (debug/no GUI) 15-Aug-96

This was tested using the latest fsspec from master (commit e69b679a94d4342d0ebbe8ba21314ceec0c62a8a) and xarray==0.14.0. Carried forward from https://github.com/intake/intake-xarray/issues/56.

Yep, you are hitting the problem that fsspec would like to be able to random access the file by issuing Range requests, but the server doesn't respect this. Typical remedies would be

set block_size=0 in open, which allows you to stream through the file but doesn't allow random access (so won't work here)
set block_size to a number larger than the file, which will then be held all in memory
use filecache: to save to local, ideally with target_options={"block_size": 0}. This actually needs a small fix (coming)

Brilliant! I can confirm that the below works with fsspec master at commit e6b7e1c6b85553f0f4df17f8a8ea8ee049de1f5a.
import fsspec
import xarray as xr
with fsspec.open(
    urlpath="filecache://test.opendap.org/opendap/data/nc/coads_climatology2.nc",
    target_protocol="http",
    target_options={"block_size": 0}
) as f:
    ds = xr.open_dataset(f, decode_times=False)
    print(ds)

<xarray.Dataset>
Dimensions:  (COADSX: 180, COADSY: 90, TIME: 12)
Coordinates:
  * COADSX   (COADSX) float64 21.0 23.0 25.0 27.0 ... 373.0 375.0 377.0 379.0
  * COADSY   (COADSY) float64 -89.0 -87.0 -85.0 -83.0 ... 83.0 85.0 87.0 89.0
  * TIME     (TIME) float64 366.0 1.096e+03 1.827e+03 ... 7.671e+03 8.401e+03
Data variables:
    SST      (TIME, COADSY, COADSX) float32 ...
    AIRT     (TIME, COADSY, COADSX) float32 ...
    SPEH     (TIME, COADSY, COADSX) float32 ...
    WSPD     (TIME, COADSY, COADSX) float32 ...
    UWND     (TIME, COADSY, COADSX) float32 ...
    VWND     (TIME, COADSY, COADSX) float32 ...
    SLP      (TIME, COADSY, COADSX) float32 ...
Attributes:
    history:  FERRET V5.22   11-Jan-01


rootfs-builder: Don't modify /sbin/init on the build host

Don't modify /sbin/init on the build host when using command AGENT_INIT="yes" ./rootfs.sh centos to build rootfs.
Fixes: #472
Signed-off-by: liangxianlong<EMAIL_ADDRESS>

@devimc Hi, please take a moment to review. Thinks.

/test

@jodh-intel @GabyCT @devimc

@liangxianlong,
Hey, we appreciate the contribution and we'll review this as soon as the time allows.
Please, be patient.
Best Regards,

/test-ubuntu

/review

@jodh-intel ok, i will raise a PR to fix this for the 2.x as soon as possible.

Thank you @liangxianlong ! :smile:
Ping @kata-containers/builder as it would be good to get another review here.

@kata-containers/builder

Fixed in 2.0 by https://github.com/kata-containers/kata-containers/pull/431.


Unauthorized Access (Spaceship::UnauthorizedAccessError)

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Unauthorized Access on select_team
Command executed
Spaceship::Tunes.client.teams.each do |team|
teamId = team['contentProvider']['contentProviderId']
selected_team = Spaceship::Tunes.select_team(team_id:teamId.to_s)

Complete output when running fastlane, including the stack trace and command used

/Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/client.rb:941:in handle_error': Unauthorized Access (Spaceship::UnauthorizedAccessError) 	from /Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/client.rb:922:in block in send_request'
from /Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/client.rb:677:in with_retry' 	from /Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/client.rb:918:in send_request'
from /Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/client.rb:762:in request' 	from /Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/client.rb:165:in team_id='
from /Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/tunes/tunes_client.rb:87:in select_team' 	from /Users/user/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/fastlane-2.204.3/spaceship/lib/spaceship/tunes/spaceship.rb:35:in select_team'

 It was running fine yesterday but today I got that error.

Environment
🚫 fastlane environment 🚫
Stack

Key
Value

OS
12.0.1

Ruby
3.0.2

Bundler?
false

Git
git version 2.30.1 (Apple Git-130)

Installation Source
~/.rbenv/versions/3.0.2/bin/fastlane

Host
macOS 12.0.1 (21A559)

Ruby Lib Dir
~/.rbenv/versions/3.0.2/lib

OpenSSL Version
OpenSSL 1.1.1l  24 Aug 2021

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
13.1

Swift Version
5.5.1

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
No Fastfile found
No Appfile found
fastlane gems

Gem
Version
Update-Status

fastlane
2.204.3
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.5.0

atomos
0.1.3

rexml
3.2.5

CFPropertyList
3.0.4

claide
1.0.3

colored2
3.1.2

nanaimo
0.3.0

xcodeproj
1.21.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.8.0

terminal-table
1.8.0

plist
3.6.0

public_suffix
4.0.6

addressable
2.8.0

multipart-post
2.0.0

word_wrap
1.0.0

optparse
0.1.1

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

artifactory
3.0.15

babosa
1.0.4

colored
1.2

highline
2.0.3

commander
4.6.0

excon
0.88.0

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

ruby2_keywords
0.0.5

faraday
1.8.0

unf_ext
0.0.8

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.4

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.2.5

gh_inspector
1.1.3

json
2.5.1

mini_magick
4.11.0

naturally
2.2.1

rubyzip
2.3.2

security
0.1.3

xcpretty-travis-formatter
1.0.1

dotenv
2.7.6

bundler
2.2.22

simctl
1.6.8

jwt
2.3.0

uber
0.1.0

declarative
0.0.20

trailblazer-option
0.1.1

representable
3.1.1

retriable
3.1.2

mini_mime
1.1.2

memoist
0.16.2

multi_json
1.15.0

os
1.1.1

signet
0.16.0

googleauth
1.1.0

httpclient
2.8.3

webrick
1.7.0

google-apis-core
0.4.1

google-apis-playcustomapp_v1
0.6.0

google-apis-androidpublisher_v3
0.13.0

google-cloud-env
1.5.0

google-cloud-errors
1.2.0

google-cloud-core
1.6.0

google-apis-iamcredentials_v1
0.8.0

google-apis-storage_v1
0.9.0

rake
13.0.3

digest-crc
0.6.4

google-cloud-storage
1.34.1

emoji_regex
3.2.3

jmespath
1.4.0

aws-partitions
1.521.0

aws-eventstream
1.2.0

aws-sigv4
1.4.0

aws-sdk-core
3.121.5

aws-sdk-kms
1.50.0

aws-sdk-s3
1.104.0

tsort
0.1.0

uri
0.10.1

set
1.0.1

forwardable
1.3.2

logger
1.4.3

pathname
0.1.0

shellwords
0.1.0

cgi
0.2.0

date
3.1.0

timeout
0.1.1

stringio
3.0.0

openssl
2.2.0

io-nonblock
0.1.0

ipaddr
1.2.2

io-wait
0.1.0

zlib
1.1.0

resolv
0.2.0

securerandom
0.1.0

digest
3.0.0

time
0.1.0

open-uri
0.1.0

mutex_m
0.1.1

net-protocol
0.1.0

ostruct
0.3.1

english
0.7.1

erb
2.2.0

strscan
3.0.0

abbrev
0.1.0

io-console
0.5.7

tempfile
0.1.1

delegate
0.2.0

fileutils
1.5.0

tmpdir
0.1.2

base64
0.1.0

singleton
0.1.1

net-http
0.1.1

open3
0.1.1

nkf
0.1.0

prettyprint
0.1.0

pp
0.1.0

find
0.1.0

yaml
0.1.1

psych
3.3.0

generated on: 2022-03-17

Yep also have this

I have the same issue

Same issue

Yep, I have same issue

same issue

Similar error.
INFO [2022-03-17 09:02:25.17]: Successfully loaded '/Users/XXX/git/XXX/fastlane/Deliverfile' 📄
WARN [2022-03-17 09:02:25.17]: No values defined in './fastlane/Deliverfile'
INFO [2022-03-17 09:02:25.17]: Login to App Store Connect (XXX)
Reading keychain entry, because either user or password were empty
Loading session from '/Users/XXX/.fastlane/spaceship/XXX/cookie'
Looking for App Store Connect Team with ID 117831961
Auth error received: 'Spaceship::UnauthorizedAccessError', 'Unauthorized Access'. Login in again then retrying after 3 seconds (remaining: 4)...
Loading session from '/Users/XXX/.fastlane/spaceship/XXX/cookie'
Auth error received: 'Spaceship::UnauthorizedAccessError', 'Unauthorized Access'. Login in again then retrying after 3 seconds (remaining: 3)...
Loading session from '/Users/XXX/.fastlane/spaceship/XXX/cookie'
Auth error received: 'Spaceship::UnauthorizedAccessError', 'Unauthorized Access'. Login in again then retrying after 3 seconds (remaining: 2)...
Loading session from '/Users/XXX/.fastlane/spaceship/XXX/cookie'
Auth error received: 'Spaceship::UnauthorizedAccessError', 'Unauthorized Access'. Login in again then retrying after 3 seconds (remaining: 1)...
Loading session from '/Users/XXX/.fastlane/spaceship/XXX/cookie'

we have the issue here, any thoughts about how to workaround?

same issue

I am experiencing the same issue, pilot fails with UnauthorizedAccess Error

same issue

same issue here

facing same issue

Same issue, I did update to macOS Monterey 12.3 yesterday, perhaps that's involved somehow?

I'm facing same issue :( very frustrated

same issue here

Same issue, I did update to macOS Monterey 12.3 yesterday, perhaps that's involved somehow?

I didn't do anything and it's working fine yesterday. Maybe apple updated their API?

Same issue

Same issue here

Same issue =(

Same here. Worked without a problem till yesterday (version 2.204.3). Not done any OS or other updates.

Same issue, Yesterday it was OK.
And today I just updated my machine to 12.3.

Same issue from today at 02:00 GMT+1

I get the same. When i log in to appstoreconnect, it seems like Apple are having some issues though, might be related.

same here

Revert Fastlane to 2.176.0.

@abarisic86 reverting fastlane to 2.176.0 - did it work - curious ?

Anybody able to confirm any work around for this issue? @fastlaneTeam this being looked into?

Same error

Thank you @ronpelayo , this works as a quick fix!
// Gemfile
# running with ruby 2.7.3
source "https://rubygems.org"

gem "fastlane", "2.176.0"

and then bundle install

Same issue

Please add
gem "fastlane", "2.205.0"
in Gemfile

Issue now fixed on fastlane [2.205.0](https://github.com/fastlane/fastlane/pull/20083)
New issue on new release. Error when running select_team

Issue now fixed on fastlane 2.205.0
New issue on new release. Error when running select_team

Same issue here

With version 2.205.1 it still crashes, any recommendations?


Make battery and backlight modules more portable

To situate my problem, I'm using Waybar on FreeBSD. Not all modules are currently implemented on FreeBSD. Although, what I like about the native battery and backlight module are the states. What info does the battery and backlight module require at  the minimum to function? For the battery module I would think the battery %, this is very easily obtainable with a simple command on FreeBSD, so could we for example add a config directive to the battery module that runs a script that outputs the current battery % and use that instead of auto detecting (which is currently only Linux specific)? The same thought applies to the backlight module. Implementing states to the custom module might also work.
How I obtain my battery %: "sysctl -n hw.acpi.battery.percentage" (dont quote me on this one, just trying to state my case)
How I obtain my backlight %: "backlight -q"
Toughts?
EDIT: Coming to think of it, this also applies to the temperature module.

Battery module should work on FreeBSD now


Add student cannot be added before module is instantiated feature

Codecov Report

Merging #178 (55c0c85) into master (6f85906) will increase coverage by 0.25%.
The diff coverage is 39.34%.

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     53.67%   53.93%   +0.25%
- Complexity      712      721       +9
============================================
  Files           135      136       +1
  Lines          3171     3230      +59
  Branches        423      439      +16
============================================
+ Hits           1702     1742      +40
- Misses         1347     1366      +19
  Partials        122      122

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/AddStuCommand.java
37.50% <0.00%> (-37.50%)
:arrow_down:

...s/logic/commands/EditTeachingAssistantCommand.java
0.00% <0.00%> (ø)

...l/person/StudentNameContainsKeywordsPredicate.java
71.42% <71.42%> (ø)

...a/seedu/address/logic/commands/EditStuCommand.java
87.59% <81.25%> (-0.90%)
:arrow_down:

...java/seedu/address/logic/commands/FindCommand.java
100.00% <100.00%> (ø)

.../seedu/address/logic/parser/FindCommandParser.java
100.00% <100.00%> (ø)

.../java/seedu/address/storage/JsonAdaptedModule.java
66.66% <0.00%> (+33.33%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


preload missing "as" attribute

<link rel="preload" href="/_donessr_instructions/1541264901212"><!--iframe placeholder-->

https://github.com/donejs/done-ssr/blob/be5cc9b93e7465a34c2d8c1be82fd5955dc877bc/zones/push-mutations/reattach.js#L54

Thanks, I believe "fetch" is what the value should be: https://developer.mozilla.org/en-US/docs/Web/HTML/Preloading_content

I had to revert this change. For some reason by adding the attribute there are some mutation instructions that get "missed".
I'm not 100% sure but what I think might be happening is:

The document starts loading and fetches the instructions.
The iframe gets attached and starts fetching the instructions.
Since the main doc already downloaded some, not all of the instructions are available.

I think the issue might be that we put the preload link in the main document and not in the iframe doc, when it's used by the iframe actually. I don't have time to fix this right now so going to leave the issue open.
Fixing it is just rearranging some stuff in this file.

@matthewp I don't think GitHub is smart enough to realize that you reverted the commit that just closed this issue again after you reopened it. 🤖


video-display shows wrong slot

the video display shows the unprivileged slot when it should show unavailable which gives users the wrong idea

the problem is that the get-video-views.ts returns undefined both for unprivileged as well as unavailable views.
the solution will be, instead of returning VideoView[], to return some kind of meta object like VideoViewMeta[]
export type VideoViewMeta = {
  status: "unprivileged" | "unavailable" | "available"
  view: VideoView
}


fixed missing frequency for cmip6 cmor checks

should solve #981

The problem with obs4mips persists (tried with dataset CERES-EBAF and variable lwcre).

Blast! lwcre is custom (derived) right? Ill have a look at the custom
loader/checker. Can you test with say tas see if it works for standard
variables at least?
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
On Wed, 20 Mar 2019, 09:39 Mattia Righi<EMAIL_ADDRESS>wrote:

The problem with obs4mips persists (tried with dataset CERES-EBAF and
variable lwcre).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/985#issuecomment-474755811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCow2_18hwM_HyYoFI89fiCWzjSgYVks5vYgG_gaJpZM4b9Nf1
.

With hus (non-derived) and AIRS it works!

Awesome, cheers for testing, Mattia! on my way to work and will have a look
at the derived case right away
Dr Valeriu Predoi.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/985#issuecomment-474773702,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCo3QEFnBZrNV5_T6u5gDSyOgtZt2Wks5vYg4lgaJpZM4b9Nf1
.

ok @mattiarighi now it should work for any derived variable (with base CMIP5, 6 or any other) - I tested with a synthetic derived variable since I don't have CMIP6 data and it works. Note that you need to add frequency: xxx in the custom CMOR table

guys, pls have a test or two and let me know if all works so I can fix the test that's failing (keeping that at the very end); also, it would be very useful, now that @jvegasbsc has gone on daddy leave, to ask @sloosvel to double check these changes when she got time (we should probably merge if all works fine, but keep that in mind) - I really am not a CMORChecks expert at all :smiling_imp:

Now I get a different error for CERES-EBAF with lwcre
2019-03-20 15:25:57,526 UTC [45300] ERROR   Failed to run fix_metadata([<iris 'Cube' of TOA Longwave Cloud Radiative Effect / (W m-2) (time: 36; latitude: 180; longitude: 360)>], {'project': 'obs4mips', 'dataset': 'CERES-EBAF', 'short_name': 'lwcre', 'cmor_table': 'obs4mips', 'mip': 'Amon', 'frequency': ''})
2019-03-20 15:25:57,878 UTC [32979] ERROR   Program terminated abnormally, see stack trace below for more information
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/pf/b/b309057/SOFTWARE/miniconda3/envs/esmvaltool/lib/python3.6/multiprocessing/pool.py", line 119, in worker
    result = (True, func(*args, **kwds))
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 660, in _run_task
    output_files = task.run()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 226, in run
    self.output_files = self._run(input_files)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 392, in _run
    product.apply(step, self.debug)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 259, in apply
    self.cubes = preprocess(self.cubes, step, **self.settings[step])
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 201, in preprocess
    result.append(_run_preproc_function(function, items, settings))
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 187, in _run_preproc_function
    return function(items, **kwargs)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/cmor/fix.py", line 116, in fix_metadata
    checker(cube).check_metadata()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/cmor/check.py", line 100, in check_metadata
    self._check_time_coord()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/cmor/check.py", line 443, in _check_time_coord
    elif self.frequency.endswith('hr'):
AttributeError: 'NoneType' object has no attribute 'endswith'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_main.py", line 228, in run
    conf = main(args)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_main.py", line 156, in main
    process_recipe(recipe_file=recipe, config_user=cfg)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_main.py", line 206, in process_recipe
    recipe.run()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_recipe.py", line 1066, in run
    self.tasks, max_parallel_tasks=self._cfg['max_parallel_tasks'])
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 585, in run_tasks
    _run_tasks_parallel(tasks, max_parallel_tasks)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 630, in _run_tasks_parallel
    task.output_files, updated_products = result.get()
  File "/pf/b/b309057/SOFTWARE/miniconda3/envs/esmvaltool/lib/python3.6/multiprocessing/pool.py", line 670, in get
    raise self._value
AttributeError: 'NoneType' object has no attribute 'endswith'

you need to add frequency: xxx in CMOR_lwcre.dat, I think it's mon

Ok, but how? As an additional variable attribute or at the top of the table?

The frequency is also not unique for the custom variables, since sometimes the same table is used for mon and day.

it's a variable attribute just like units etc; in that case we're kinda screwed since we need to create separate files for different frequencies; the code needs that frequency from the CMOR table in light of the new CMIP6 CMOR table structure

I also found this discrepancy between CMIP5 and 6 standard names:
Amon:
prw:
CMIP5: "atmosphere_water_vapor_content"
CMIP6: "atmosphere_mass_content_of_water_vapor"

do we have a strategy for these cases yet?

it's a variable attribute just like units etc; in that case we're kinda screwed since we need to create separate files for different frequencies; the code needs that frequency from the CMOR table in light of the new CMIP6 CMOR table structure

It's still not clear to me how this affects obs4mips and the custom variables, since both follow their own tables, the latter based on CMIP5. Changes in CMIP6 tables should not have any effect here.

do we have a strategy for these cases yet?

Not yet, as far as I know @jvegasbsc only implemented a fix for the short_name (see #950).

cmor_type1] for obs4mips is CMIP6 as per config-developer

Should we try to update the obs4mips tables as well?

As a quick solution, can we revert the CMIP6 tables to the previous version until this is solved?

OK so here's the status:

with this PR we have all working with the current  CMIP6 tables provided that the derived variables custom CMOR tables contain a valid frequency field; the standard variables should work fine as of now;
if we use cmor_type: CMIP5 in the various data types in config-developer.yml we revert to CMIP5 CMOR tables and we don't need to add frequency fields in the derived variables' CMOR files; or we revert to previous version of CMIP6 CMOR tables; I'd go with the first option since it involves less file tracking

there are small differences if we want to use CMIP5 CMOR tables for CMIP6 data eg:
    _CMIP_5to6_varname = {
        'sic': 'siconc',
        'sit': 'sithick',
        'tro3': 'o3',
    }

but these shouldn't bite us too badly

provided that the derived variables custom CMOR tables contain a valid frequency field

But they don't, and adding it would mean redesigning the way the custom tables are defined (i.e., group them by mip) and regenerate our obs data pool again (including also adjusting most of the cmorizers).
This is something we would need to do anyway at some point, but not now.

if we use cmor_type: CMIP5 in the various data types in config-developer.yml we revert to CMIP5 CMOR tables

Isn't this also controlling the table format (plain text in CMIP5 vs json in CMIP6)?

we revert to previous version of CMIP6 CMOR tables

It still looks the quickest way out to me, at least until we have a clean solution for the issues you mentioned (which may be some work).

using cmor_type: CMIP5 for anything CMIP6 including CMIP6 data works fine no problemo, what you mean by "Isn't this also controlling the table format (plain text in CMIP5 vs json in CMIP6)?" - it just loads different CMOR tables and applies the same checks and cmorization, no worries about tables' format

CMIP5 for anything CMIP6 including CMIP6 data works fine no problemo

That would probably not work for those variables with a different short_name (see #950).
@LisaBock or @axel-lauer any suggestion?

also if you temporarily just add frequency: something in the derived vars custom tables, that doesn't break any CMIP5 functionality and the bonus is that addition will make work with CMIP6 even before we start re-arranging them custom tables and rerun the obs's (OK we just add mon). Alas, the code changes in this PR are actually the ones we will need to be able to work with the latest CMIP6 tables (well, unless @jvegasbsc gets bored of his new wee baby and makes changes :grin: )

CMIP5 for anything CMIP6 including CMIP6 data works fine no problemo

That would probably not work for those variables with a different short_name (see #950).
@LisaBock or @axel-lauer any suggestion?

yesh indeed, but those are not on any ESGF node yet anyway so people can keep their CMIP5 names :grin:

yesh indeed, but those are not on any ESGF node yet anyway so people can keep their CMIP5 names

The CMIP6 data are flowing right now and people are start working with them.
Therefore I'm hesitant introducing changes now and would go back to the previous version (which has been quite extensively tested in our group).

up to you Mattia, I'm fine with either option, only thing is pls don't archive these code changes since I made them through blood and sweat (I was not really good at understanding the CMOR codes until yesterday, you see :fire_engine: )

This PR can stay and should be used to include (and thorougly test) the new CMIP6 tables after we have reverted to the previous version.
Would that be ok?
Can you make a new PR to include the previous tables, i.e. those before #962 ?

yep sounds good :dragon_face:

https://github.com/ESMValGroup/ESMValTool/pull/987

it's a variable attribute just like units etc; in that case we're kinda screwed since we need to create separate files for different frequencies; the code needs that frequency from the CMOR table in light of the new CMIP6 CMOR table structure

It's still not clear to me how this affects obs4mips and the custom variables, since both follow their own tables, the latter based on CMIP5. Changes in CMIP6 tables should not have any effect here.

@mattiarighi Can You address me to which tests you run that generates errors with obs4mips and the custom variables? thanks!
Speaking as a user  working with available CMIP6 data, I won't be very happy to use tables that are 30 revisions (~1yr) old... that's why I suggested the update ...
I see the point of ensuring the stability of the code so that's fine, but this should be sovled as we are only moving the problem forward in time...

@mattiarighi Can You address me to which tests you run that generates errors with obs4mips and the custom variables? thanks!

I've tried a custom variable like lwcre in combination with an obs4mips dataset (CERES-EBAF).

I see the point of ensuring the stability of the code so that's fine, but this should be sovled as we are only moving the problem forward in time...

The stability of the code is the absolute priority: version2_development should always run without errors, that's why we need to revert asap.
We will update the tables again in #985, but this time testing thoroughly all cases.
In that PR we might also need to change the way the custom tables are structured.

@mattiarighi Just to avoid further question, could you share the recipe You used for lwcre and obs4mip so it will be the same test! Thanks!!!

I used recipe_perfmetrics_CMIP5.yml, the diagnostic is called lwcre, like the variable.

so what's the plan with this one, @mattiarighi ? You testing with the code of this PR but with the older CMIP6 tables? It should work fine, Ive tested myself. Anything esle I should be doing abt it?

No, the idea was to put the new tables in this branch, thoroughly test them and then merge.
There were still issues with obs4mips and the derived variables.

aa OK, lemme put the 01.00.30 tables then

@valeriupredoi from this we should remove the following table https://github.com/ESMValGroup/ESMValTool/blob/version2_development_CMIP6FreqIssue981/esmvaltool/cmor/tables/cmip6/Tables/CMIP6_CFsubhrOff.json
that is no more part of the CMIP6 CMOR tables and it is essentially a leftover of the original PR (also from commits you see that it was not changed).

@bouweandela Anyone know if it is still necessary to keep the following table https://github.com/ESMValGroup/ESMValTool/blob/version2_development_CMIP6FreqIssue981/esmvaltool/cmor/tables/cmip6/Tables/CMIP6_CV_test.json

cool, now we are back to what HEAD was before the switch to the older CMIP6 tables

and ready for testing - I have tested (minimally) for all cases but @mattiarighi is the heavy lifter for testing :weight_lifting_man:

@bouweandela Anyone know if it is still necessary to keep the following table https://github.com/ESMValGroup/ESMValTool/blob/version2_development_CMIP6FreqIssue981/esmvaltool/cmor/tables/cmip6/Tables/CMIP6_CV_test.json

probably not since the current CV is mature enough (these were used along previous 01.00.xx versions and I think they just forgot to remove it). But am not a CMOR expert :beer:

@jvegasbsc when you gots time pls review this one man, we need to get the frequency working with the newer CMOR tables versions and we should stop using the already antiquated ones we are using at the moment :beer:

Good job! I am refactoring a bit the frequency code to be a bit more coherent with the rest of the module but that's all

@axel-lauer @LisaBock @schlunma can you run some of your CMIP6 recipes in this branch and see if they work?

cheers muchly @jvegasbsc :beer:
@mattiarighi the tests should be done with CMOR version as late as possible (note we've changed the version for the current main branch to smth pretty old). Current version in this branch is 01.00.30 but the latest on the cmor git is 01.00.31beta - should we test with that too @jvegasbsc

Does it make sense to test a beta version?
If the last stable one is 01.00.30 I would prefer to keep that.
We can update again once 01.00.31 is out, hopefully it won't change much.

Still having problems with `obs4mips'
2019-05-23 10:08:34,939 UTC [15924] ERROR   Failed to run fix_metadata([<iris 'Cube' of TOA Shortwave Cloud Radiative Effect / (W m-2) (time: 36; latitude: 180; longitude: 360)>], {'project': 'obs4mips', 'dataset': 'CERES-EBAF', 'short_name': 'swcre', 'cmor_table': 'obs4mips', 'mip': 'Amon', 'frequency': ''})
2019-05-23 10:08:35,269 UTC [15924] INFO    Starting task toz/toz in process [15924]
2019-05-23 10:08:36,564 UTC [15928] WARNING There were warnings in variable rlut:
rlut: attribute positive not present

2019-05-23 10:08:36,846 UTC [37427] ERROR   Program terminated abnormally, see stack trace below for more information
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
  File "/pf/b/b309057/SOFTWARE/miniconda3/envs/esmvaltool/lib/python3.7/multiprocessing/pool.py", line 121, in worker
    result = (True, func(*args, **kwds))
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 661, in _run_task
    output_files = task.run()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 226, in run
    self.output_files = self._run(input_files)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 392, in _run
    product.apply(step, self.debug)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 259, in apply
    self.cubes = preprocess(self.cubes, step, **self.settings[step])
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 201, in preprocess
    result.append(_run_preproc_function(function, items, settings))
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/preprocessor/__init__.py", line 187, in _run_preproc_function
    return function(items, **kwargs)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/cmor/fix.py", line 116, in fix_metadata
    checker(cube).check_metadata()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/cmor/check.py", line 100, in check_metadata
    self._check_time_coord()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/cmor/check.py", line 443, in _check_time_coord
    elif self.frequency.endswith('hr'):
AttributeError: 'NoneType' object has no attribute 'endswith'
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_main.py", line 228, in run
    conf = main(args)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_main.py", line 156, in main
    process_recipe(recipe_file=recipe, config_user=cfg)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_main.py", line 206, in process_recipe
    recipe.run()
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_recipe.py", line 1066, in run
    self.tasks, max_parallel_tasks=self._cfg['max_parallel_tasks'])
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 586, in run_tasks
    _run_tasks_parallel(tasks, max_parallel_tasks)
  File "/mnt/lustre01/pf/b/b309057/ESMValTool/public/esmvaltool/_task.py", line 631, in _run_tasks_parallel
    task.output_files, updated_products = result.get()
  File "/pf/b/b309057/SOFTWARE/miniconda3/envs/esmvaltool/lib/python3.7/multiprocessing/pool.py", line 657, in get
    raise self._value
AttributeError: 'NoneType' object has no attribute 'endswith'

OK so here's the status:
* with this PR we have all working with the **current**  CMIP6 tables **provided** that the derived variables custom CMOR tables contain a valid frequency field; the standard variables should work fine as of now;

* if we use `cmor_type: CMIP5` in the various data types in config-developer.yml we revert to CMIP5 CMOR tables and we don't need to add frequency fields in the derived variables' CMOR files; or we revert to previous version of CMIP6 CMOR tables; I'd go with the first option since it involves less file tracking

@mattiarighi I am assuming that point 1 of my comment still stands ie we should add frequency to the custom tables. Correct me if I'm wrong @jvegasbsc

Still having problems with `obs4mips'

obs4mips tables master has been updated  a month ago. Probably updating the tables will fix your problems

@mattiarighi I am assuming that point 1 of my comment still stands ie we should add frequency to the custom tables. Correct me if I'm wrong @jvegasbsc

Nothing in this pull request change the way we are working with CMIP5-like tables

obs4mips tables master has been updated a month ago. Probably updating the tables will fix your problems

Can you update them in this branch?

I have just done it

By the way, you are having trouble because swcre and related are not in obs4mips variables, so we get the info from custom tables and that does not contain the frequency. I will need to add some code to deduce the frequency from the table (maybe just assign the most common in the variables)

I have been trying to say that myself since March :rofl: - I was thinking about adding the frequency info in the custom var based on all the component variables in an automatic way (and not by hand in the custom table) but I had left it for you to review and decide - it shouldn't be too hard since all the component vars should have consistent frequencies no?

Some use fx variable together with monthly, e.g. nbp_grid.

good point! The fx var should be sidelined then - #1065 and #1037 are taking care of that the fx variable is treated correctly as a bloody fx variable anyway

I am counting the frequency and assigning the max value

Just tested recipe_ecs_scatter_cmip6.yml successfully.

Mattia, can you test again? Now custom vars will be assigned the table frequency, so I expect this will fix your issue

Thanks, I will test asap.

I can't test anything until #1097 is solved. :sob:

Tested successfully!

@mattiarighi @jvegasbsc shall we merge then? awesome work guys :beer:

Please re-open this pull request in the ESMValTool Core repository. You can do so by pushing this branch to that repository, using the following instructions.
First add the repository with
git remote add esmvalcore git@github.com:esmvalgroup/esmvalcore

or
git remote add esmvalcore https://github.com/esmvalgroup/esmvalcore

if you're not using ssh to connect to GitHub.
Next upload the branch with
git push esmvalcore your_branch

and open a pull request here

Also note the new issue number #38

sorry I did not mean to close that :/

@valeriupredoi is this still relevant?

still is, somewhat relevant albeit the code is starting to become obsolete, see the discussion here https://github.com/ESMValGroup/ESMValCore/pull/158

ie the code = CMOR tables which are even more modern in https://github.com/ESMValGroup/ESMValCore/pull/158

But shouldn't it be moved to Core?

yes, I believe @jvegasbsc is cherrypicking the changes in that Core PR, no?

I will close this when the pull requests is created for the core

Ported to /ESMValGroup/ESMValCore#158


Implement permit fields in the survey metadata form

Overview
Links to jira tickets

https://quartech.atlassian.net/browse/BHBC-1080

This PR contains the following changes

Implement permit fields in the survey metadata form

This PR contains the following types of changes

[x] New feature (change which adds functionality)

How Has This Been Tested?

Locally

Screenshots

will address your final comments in my next pr :)


NPM package

It would be nice if I could install Dolos from an NPM package. The benefit is that Paima would be able to download Dolos for you easily instead of telling users to go through the Dolos setup steps
The Dolos package is fortunately fairly small (~25MBs unzipped) so this shouldn't be an issue bandwidth-wise
If want a simple solution, you can just copy-paste the setup I did for yaci-devkit here
However, given that Dolos is written in Rust, another option is to use the same approach hardhat used which is to setup napi to generate all the packages for you for all the build options

@SebastienGllmt we've enabled the npm installer option. Next release will attempt to publish Dolos as an npm package.


Could not find a package configuration file for "GTest"

Describe the bug
CMake throws error when using find_package(GTest CONFIG REQUIRED).
Environment

OS: Ubuntu 20.04 (WSL 2, x64)
vcpkg version: 2022-02-24-7efe7f2b04912a7d674f86a406f9f2711c0221c6
gtest version: 1.11.0#3
CMake version: 3.22

To Reproduce
Steps to reproduce the behavior:

./vcpkg install gtest
Create a simple CMakeLists.txt file with find_package( GTest CONFIG REQUIRED ).

Expected behavior
Should find GTestConfig.cmake or gtest-config.cmake
Failure logs
CMake Error at tests/CMakeLists.txt:19 (find_package):
  Could not find a package configuration file provided by "GTest" with any of
  the following names:

    GTestConfig.cmake
    gtest-config.cmake

  Add the installation prefix of "GTest" to CMAKE_PREFIX_PATH or set
  "GTest_DIR" to a directory containing one of the above files.  If "GTest"
  provides a separate development package or SDK, be sure it has been
  installed.

Additional context
Checked $VCPKG_ROOT/installed/x64-linux/share/gtest. Directory contains only copyright and vcpkg_abi_info.txt. Could this be the problem?

It was an error on my side. I added was setting the CMAKE_TOOLCHAIN_FILE on the test directory's CMakeLists.txt since the main project did not use any libraries. Sorry

hi,
I'm having a similar problem on WSL2 Ubuntu 20.4,
I've installed gtest on the ubuntu sub system but I can't find the module (.cmake file) for some other third party open source build.
Where should it be? Can I copy such a file (FindGTestConfig.cmake) manually ?
Thanks,
Yair

Same problem on my WSL2 Ubuntu 20.02, CMake 3.16.3.

Same problem on my WSL2 Ubuntu 20.02, CMake 3.16.3.

@adeeconometrics Open a new issue with clear steps.

Same problem on my WSL2 Ubuntu 20.02, CMake 3.16.3.

@adeeconometrics Open a new issue with clear steps.

hi, I'm having a similar problem on WSL2 Ubuntu 20.4, how to reading the issue,can u help me

It was an error on my side. I added was setting the CMAKE_TOOLCHAIN_FILE on the test directory's CMakeLists.txt since the main project did not use any libraries. Sorry

Just to expand on this for any new cmake users like myself, setting this variable needs to be done before the project() function, otherwise use the -DCMAKE_TOOLCHAIN_FILE= when running cmake.
For me I am using vcpkg as a submodule so that path to this toolchain file won't change and therefore can use something like:
if(NOT CMAKE_TOOLCHAIN_FILE)
  set(CMAKE_TOOLCHAIN_FILE
      "${CMAKE_CURRENT_LIST_DIR}/vcpkg/scripts/buildsystems/vcpkg.cmake"
      CACHE STRING "" FORCE)
endif()

project(my-project CXX)


Introduce GraalVM native image generation with bal build

Purpose

Introduce GraalVM native image generation with bal build
Fixes #37608

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing since there are conflicts. Opened #38166