How do I set the parameters in ParameterMap?

I am using the example and I am getting the following output:
`Running elastix with parameter map 0
Current time: Fri Mar 25 09:48:58 2016.
Installing all components.
InstallingComponents was successful.
ERROR:
FixedImageType:  2D unsigned char
MovingImageType: 2D unsigned char
elastix was not compiled with this combination of ImageTypes!
You have two options to solve this:

Add the combination to the CMake parameters ELASTIX_IMAGE_nD_PIXELTYPES and ELASTIX_IMAGE_DIMENSIONS, re-cmake and re-compile.
Change the parameters FixedInternalImagePixelType and/or MovingInternalImagePixelType in the elastix parameter file.

ERROR:
Something went wrong in the ComponentDatabase
Errors occurred!`
I am getting this with all the images it opens. Do I need to set FixedInternalImagePixelType and MovingInternalImagePixelType to float or something to work right? If yes how can I set this in Java?
Or is my compilation wrong?

I suggest not fiddling with internal pixeltypes and instead do one of two things.

Go into the SimpleElastixBuildDirectory/elastix-build and set the USE_ALL_PXELTYPES CMake variable to ON and recompile the project. You may have to start the compilation from the SimpleElastixBuildDirectory/SimpleITK-build directory for the linker to pickup the updated libraries.
Cast the images to a float pixel type using the CastImageFilter:

    CastImageFilter caster = new CastImageFilter();
    caster.setOutputPixelType( sitkFloat32 );
    Image castImage = caster.execute( image );

Let me know how it goes!

@kaspermarstal Your second solution seems to work. Only for float32. Any other encoding seems to fail. Here is my code in case someone wants to use it:
`public void simpleelastixtest() {
	CastImageFilter caster = new CastImageFilter();
	caster.setOutputPixelType(PixelIDValueEnum.sitkFloat32);

	org.apache.logging.log4j.Logger log = MSLog4J2.getLogger();

	// Instantiate SimpleElastix
	org.itk.simple.SimpleElastix elastix = new org.itk.simple.SimpleElastix();

	// Read input
	org.itk.simple.ImageFileReader reader1 = new org.itk.simple.ImageFileReader();

	reader1.setFileName("brain1.png");
	Image castImage1 = caster.execute(reader1.execute());
	elastix.setFixedImage(castImage1);
	log.info(castImage1.getHeight());

	org.itk.simple.ImageFileReader reader2 = new org.itk.simple.ImageFileReader();
	reader2.setFileName("brain1.png");
	Image castImage2 = caster.execute(reader2.execute());
	elastix.setMovingImage(castImage2);
	log.info(castImage2.getHeight());

	elastix.setParameterMap(elastix.getDefaultParameterMap("rigid"));
	elastix.logToConsoleOn();

	// Perform registration
	elastix.execute();

	// Write result image
	ImageFileWriter writer = new org.itk.simple.ImageFileWriter();
	writer.setFileName("test.png");
	writer.execute(elastix.getResultImage());

	elastix.prettyPrint(elastix.getTransformParameterMap());

}`
However the example doesn't save the output image. Or more accurately Elastix is missing the output path  . Is there a way to set the output path for Elastix? Here is the output  of the console. "Brain1.png" is this image.

Looks like there is an error in the example. The call to execute on the writer should be writer.execute(elastix.getResultImage(), "path/to/folder"). Does this help?
The output path controls the directory of the log file. You can set the directory using `LogToFolder("path/to/folder").

@kaspermarstal Thanks for the suggestion. LogToFolder () helps with not producing errors. Now the logs are stored. However even with this the result image is written into the local path "test.png" with 0 size. I am attaching the new code:
`public void simpleelastixtest() {
CastImageFilter caster = new CastImageFilter();
caster.setOutputPixelType(PixelIDValueEnum.sitkFloat32);

org.apache.logging.log4j.Logger log = MSLog4J2.getLogger();

// Instantiate SimpleElastix
org.itk.simple.SimpleElastix elastix = new org.itk.simple.SimpleElastix();

// Read input
org.itk.simple.ImageFileReader reader1 = new org.itk.simple.ImageFileReader();

reader1.setFileName("brain1.png");
Image castImage1 = caster.execute(reader1.execute());
elastix.setFixedImage(castImage1);
log.info(castImage1.getHeight());

org.itk.simple.ImageFileReader reader2 = new org.itk.simple.ImageFileReader();
reader2.setFileName("brain1.png");
Image castImage2 = caster.execute(reader2.execute());
elastix.setMovingImage(castImage2);
log.info(castImage2.getHeight());

elastix.setParameterMap(elastix.getDefaultParameterMap("rigid"));
elastix.logToConsoleOn();
elastix.logToFolder("\\elastixtestlogs\\");

// Perform registration
elastix.execute();

// Write result image
ImageFileWriter writer = new org.itk.simple.ImageFileWriter();
writer.execute(elastix.getResultImage(),"test.png",false);

}`
Running elastix.getResultImage().getHeight() gives me the dimension of the image. So I guess the image is produced.

OK so I just figured it out why it didn't save the image. ImageFileWriter can export only to .nii file formats.


A few typos and common grammar mistakes

Nothing too big here.

Merci bichon :)

J'allais la merger lol
:+1: thx


Does not respond to height set inside media queries.

Hey, can you please give me a more detailed description, ideally with a code snippet on how you use it and how it should behave and how it behaves?

Hello. When an image height is set initially in css, and then changed inside of a media query later on in the css, the new height is not set on the image (or rather the image wrapper) on window resizing. Tested in IE.
http://codepen.io/anon/pen/vOWpdj

Thanks, I’ll investigate as soon as possible. Which IE have you tested on?

IE 10, and IE 11 (in IE 9 the image doesn't show, as commented on another issue)


🎖 Math Magicians: setup 🎖

Project Requirements : https://github.com/microverseinc/curriculum-react-redux/blob/main/math-magicians/project_setup.md
📝 General requirements

✅ No Linters error
✅ Used GitFlow.
✅ Professional README file.
✅ Used React documentation.
✅ The application runs in the browser without errors

Thanks dear @OyePriscilla

You welcome @kambereBr 👍


Fix DynamicalODE Benchmarks

Fix https://github.com/SciML/SciMLBenchmarks.jl/issues/261
The errors look like to be caused by some unicode issues.

Can you fix the manifest conflicts?

I kept the changes from my branch when resolving. I'll wait for the CI to see if it's ok. Sorry for the delay.

There seems to be some network issue with the CI :thinking:

Would it be ok to restart the tests?

I did


Confidence interval

How hard would it be to patch regression.js to give us a confidence interval as well?

Hi @nite,
Like a confidence interval for the gradient? I don't think calculating that would be too difficult, but it's probably outside the scope of this library. I do intend on adding the coefficient of determination (and most likely the standard error) in the near future.
var model = regression('linear', data);
var standardError = model.standardError;
var stat = model.equation[0]; // gradient
var confidenceLevel = 0.95;
var DF = data.length - 2;
var criticalProbability = 1 - confidenceLevel;
var criticalValue =  tDistribution(DF, criticalProb);
var marginOfError = criticalValue * standardError;
var confidenceInterval = [stat - marginOfError, stat + marginOfError];

Yes, we're replicating something like this from ggplot in d3
http://stats.stackexchange.com/questions/85560/shape-of-confidence-interval-for-predicted-values-in-linear-regression
Here's my implementation:
usage:
import regressionService from '/services/regressionService';
regress = regression('linear', inputPoints, 3);
_.merge(regress, regressionService.getErrorLines(inputPoints, regress.points));

regressionService.js:
import math from 'mathjs';
import _ from 'lodash';

function RegressionService(){
    function getErrorMargin(inputPoints, outputPoints) {
        var standardErrorSquared = _.sum(
                _.zip(inputPoints.map(x => x[1]), outputPoints.map(x => x[1]))
                    .map(pair => Math.pow(pair[1] - pair[0], 2)))
            / (inputPoints.length - 2);

        var inputMatrix = inputPoints.map(p => [1, p[0]]);

        return math.sqrt(
            math.diag(
                math.multiply(
                    math.multiply(
                        math.multiply(inputMatrix, standardErrorSquared),
                        math.inv(math.multiply(math.transpose(inputMatrix), inputMatrix))),
                    math.transpose(inputMatrix))));
    }

    function getErrorLines(inputPoints, outputPoints) {
        var errorMargin = getErrorMargin(inputPoints, outputPoints);
        var inputXs = inputPoints.map(x => x[0]);
        var outputYs = outputPoints.map(p => p[1]);
        var lowerErrorYs = math.subtract(outputYs, errorMargin);
        var upperErrorYs = math.add(outputYs, errorMargin);
        return {
            lowerErrorPoints: _.zip(inputXs, lowerErrorYs),
            upperErrorPoints:  _.zip(inputXs, upperErrorYs)
        }
    }

    return {
        getErrorLines: getErrorLines
    }
}

export default new RegressionService();

@Tom-Alexander - What is your ETA on adding coefficient of determination (r2)? This is the only feature keeping us from using this library right now.

I plan on merging it this week @mikelang919

Hi @Tom-Alexander, @nite,
I need to create d3 plot with confidence intervals for linear regression similar to https://web.stanford.edu/~mwaskom/software/seaborn/examples/regression_marginals.html and I am trying to use your RegressionService to get upper and lower lines
Is it enough to just call getErrorLines and used returned data to draw lines?
Do you know the formulas used in calculation?
I can't find good docs and formulas to calculate those lines
Thanks,
Pavel

I see this library added r2 are there plans for standard error as well?


Convert ocamldoc automatically

Either automatically or with a very easy command would be ideal.

Can this be closed?


sfsu hook panics

Since the update to 1.13 sfsu seems to crash every time it tries to register its hooks
"name" = "sfsu"
"operating_system" = "Windows 10.0.22635 (Windows 11 Professional) [64-bit]"
"crate_version" = """
1.13.0
sprinkles 1.13.0
branch:
tag:v1.13.0
commit_hash:efb0ffbb
build_time:2024-05-10 14:32:09 +00:00
build_env:rustc 1.78.0 (9b00956e5 2024-04-29),1.78.0-x86_64-pc-windows-msvc
libgit2:1.7.2"""
"explanation" = '''
Panic occurred in file 'crates\sprinkles\src\contexts\user.rs' at line 27
'''
"cause" = "called `Result::unwrap()` on an `Err` value: Custom { kind: InvalidData, error: Error(\"invalid type: null, expected path string\", line: 3, column: 19) }"
"method" = "Panic"
"backtrace" = """

   0: 0x7ff6eacac03a - <unresolved>
   1: 0x7ff6eaca541b - <unresolved>
   2: 0x7ff6eaa61b66 - <unresolved>
   3: 0x7ff6eacae0c5 - <unresolved>
   4: 0x7ff6eb4b348c - git_midx_writer_new
   5: 0x7ffe81f3257d - BaseThreadInitThunk
   6: 0x7ffe82d4aa48 - RtlUserThreadStart"""

Actually after looking into this a bit more, I wonder how the config even ended up with a null value for the root path.

Is your scoop installed at the default location (~/scoop)?
Also, could you provide, if set, the value of your SCOOP environment variable?
I can't for the life of me figure out why it would get set to null.

Is your scoop installed at the default location (~/scoop)?

Yeah, it's under the home directory

Also, could you provide, if set, the value of your SCOOP environment variable?

Doesn't seem to be set to anything


Zere's Plugin Library Docs README.md link

In README.md it says:

View the library documentation here: https://rauenzi.github.io/BDPluginLibrary/docs

I believe the link should be https://zerebos.github.io/BDPluginLibrary/docs
It seems that the original creator has changed their  GitHub username.

This plugin has reached EOL and will only be receiving high priority fixes!


Add Option for React Templates to be non TypeScript

I understand why it makes sense in Angular to have TypeScript only templates.  React is different. Most of the React community does not use TypeScript and if they do type checking I'm pretty sure they use Facebook Flow.  I'm not advocating creating a Flow template but I would recommend creating a vanilla JavaScript template.  Marius notes :

If you're using React, on the other hand, you might prefer Flow because it easily integrates with Babel and other infrastructure you probably already have in place

https://blog.mariusschulz.com/2017/01/13/typescript-vs-flow

Thanks for the suggestion. We'll bear it in mind but it's not currently planned.


Fatal Crash on ChatOpenAI

This line -
let buffer = try! await openAIClient.chats.stream(model: model, messages: [.user(content: text)], temperature: temperature)
is causing fatal crashes when awaiting a response specifically for me on slow internet. I would recommend not force unwrapping here.
Thread 15: Fatal error: 'try!' expression unexpectedly raised an error: HTTPClientError.deadlineExceeded

You're right, I've done this on pr, I'll merge it first, use 0.27.0, happy hack.


Static ip allocator

LGTM as I will move this into networking/ and update to conform to latest needs.


A simple explanation of wasserstein distance

https://fenghz.github.io/Wasserstein-distance/#

Here you can leave a comment


"index_select_cuda" not implemented for 'Float8_e4m3fn' error from CogVideoXImageToVideoPipeline happens when FP8 used

I have opened a detailed issue here anyone has any ideas?  happens when FP8 used
https://github.com/huggingface/diffusers/issues/9539

this doesnt make sense to me because we are able to use FP8 mode of FLUX  model and T5 XXL when using FLUX with ComfyUI

This appears to be an issue with T5. Additionally, if your GPU is sufficient, you can remove all configurations of cpu_offload and use pipe.to("cuda"). The current FP8 is implemented through torchao with fp8 weights for BF16 inference. If you want to use E4M3 inference, some adjustments will likely be needed. During my testing, I encountered an error similar to yours. I have contacted diffusers about this error, and I suspect there are some incompatibilities within the underlying libraries of torchao, torch, and diffusers. We will attempt to address this in the future, but this work may need to be completed by the community, as we currently do not have enough manpower.

This appears to be an issue with T5. Additionally, if your GPU is sufficient, you can remove all configurations of cpu_offload and use pipe.to("cuda"). The current FP8 is implemented through torchao with fp8 weights for BF16 inference. If you want to use E4M3 inference, some adjustments will likely be needed. During my testing, I encountered an error similar to yours. I have contacted diffusers about this error, and I suspect there are some incompatibilities within the underlying libraries of torchao, torch, and diffusers. We will attempt to address this in the future, but this work may need to be completed by the community, as we currently do not have enough manpower.

thank you so much for reply
i have 24 GB and without optimizations it use 26 GB - i tested on cloud
I opened an issue on Diffusers as well - we are able to use T5 and FLUX in FP8 so i think CogVideo must be same


Turn the GraalVM feature into a pure build time transformation generating JSON configs

As part for this issue we should also:

Begin to make GraalVM specific codepath isolated to prepare Project leyden support
Find a good package since native that would have been idea is a Java reserved keyword

This change will improve debugability and should should use this opportunity to improve unit test coverage.

This is in good shape. I refactored the feature to separate the 'analysis' that computes the configuration from its GraalVM interactions. The GraalVM feature is loosely coupled to the analysis engine and the analysis engine has a collector framework on the backend. There is a default collector that just accumulates computed configuration in java collections, but optionally you can plug in a GraalVM connector that passes that to GraalVM native image.
So the same analysis engine is now used by the feature and by the build time configuration contributor. There is more refactoring to do but this initial work is behaving for a number of samples.

This is in good shape. I refactored the feature to separate the 'analysis' that computes the configuration from its GraalVM interactions. The GraalVM feature is loosely coupled to the analysis engine and the analysis engine has a collector framework on the backend. There is a default collector that just accumulates computed configuration in java collections, but optionally you can plug in a GraalVM connector that passes that to GraalVM native image.
So the same analysis engine is now used by the feature and by the build time configuration contributor. There is more refactoring to do but this initial work is behaving for a number of samples.


feat: Linter fails on 1.0 branch

Feature Type

[ ] Adding new functionality to quinn

[ ] Changing existing functionality in quinn

[ ] Removing existing functionality in quinn

Problem Description
https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563
installing ruff from spec 'ruff==0.5.1'...
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'isort' -> 'lint.isort'
quinn/schema_helpers.py:1[34](https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563#step:4:36):37: F821 Undefined name `Optional`
    |
132 |         return type_lookup[type_str]
133 |
134 |     def _convert_nullable(null_str: Optional[str]) -> bool:
    |                                     ^^^^^^^^ F821
1[35](https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563#step:4:37) |         if null_str is None:
1[36](https://github.com/MrPowers/quinn/actions/runs/9935547834/job/27441930563#step:4:38) |             return True
    |

Found 1 error.
Error: Process completed with exit code 1.

Feature Description
Fix linter problems in 1.0
Additional Context
No response

Should be solved by https://github.com/MrPowers/quinn/pull/251


Modelling the short arm acrocentric arms of human chromosomes

I gather from the T2T papers that the short arms of the acrocentric chromosomes (e.g. 13 & 14) exchange material e.g. through gene conversion (and maybe even recombination). This would be a neat test-case for the GIG encoding, especially if #11 is implemented.

I think once we solve #103, this becomes almost trivial to implement


FTP Unauthorized Access Alert!  (juanpernia.com got hacked this way)

You can find the actual FTP credentials at this link starting with line 17:
https://github.com/juanrules/juan-pernia-wordpress-theme/blob/master/sftp-config.json#L17
With kindness,
Nitescu Lucian | nliplace.com

They got access by using Google dork
Read more at: https://www.exploit-db.com/ghdb/3897/
And because you got hacked ... I am here to help you ;)


Byte Array Interop Breaking Change Announcement

Ensures https://github.com/dotnet/announcements/issues/187 is reflected in the docs.

Hi @TanayParikh - I just realized that we'd need to add this to the TOC as well.

Ensures dotnet/announcements#187 is reflected in the docs.

@TanayParikh Is there a reason you didn't post this at aspnet/Announcements? Just wondering if there's a new process I should be aware of. We normally create an issue in the dotnet/docs repo for .NET breaking changes (but it looks like this is an ASP.NET Core breaking change, so that wouldn't apply).

Ensures dotnet/announcements#187 is reflected in the docs.

@TanayParikh Is there a reason you didn't post this at aspnet/Announcements? Just wondering if there's a new process I should be aware of. We normally create an issue in the dotnet/docs repo for .NET breaking changes (but it looks like this is an ASP.NET Core breaking change, so that wouldn't apply).

No you're absolutely right, it should've gone to aspnet/Announcements instead of dotnet/announcements. Do you happen to have the permissions to move the issue, or should I just create a new issue in aspnet/Announcements?

No you're absolutely right, it should've gone to aspnet/Announcements instead of dotnet/announcements. Do you happen to have the permissions to move the issue, or should I just create a new issue in aspnet/Announcements?

I don' t have permissions, but maybe @Rick-Anderson does?

Thanks @TanayParikh !


controller.nodeclaim.consistency error wrong storage size being reported by the controller

Description
Observed Behavior:
karpenter thinks a nodeclaim has the wrong ephemeral storage set
{"level":"ERROR","time":"2024-05-10T10:23:52.304Z","logger":"controller.nodeclaim.consistency","message":"check failed, expected 300Gi of resource ephemeral-storage, but found 125816812Ki (40.0% of expected)","commit":"2c8f2a5","nodeclaim":"nginx-bsn2h"}
Expected Behavior:
I would expect karpenter to know the correct ephemeral storage size
Reproduction Steps (Please include YAML):
we have an ec2nodeclass called "default" which indeed has 300Gi of storage
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
  annotations:
    karpenter.k8s.aws/ec2nodeclass-hash: "1078616476462511281"
    meta.helm.sh/release-name: karpenter-workers
    meta.helm.sh/release-namespace: karpenter
  creationTimestamp: "2023-11-02T13:15:37Z"
  finalizers:
  - karpenter.k8s.aws/termination
  generation: 3
  labels:
    app.kubernetes.io/managed-by: Helm
  name: default
  resourceVersion: "439476752"
  uid: e8c79922-06c8-4934-8083-b4c9a84ad1dc
spec:
  amiFamily: AL2
  blockDeviceMappings:
  - deviceName: /dev/xvda
    ebs:
      deleteOnTermination: false
      encrypted: true
      kmsKeyID: arn:aws:kms:eu-west-1:xxxxxxx:key/ff5842b6-4991-4464-80fc-1e1682c8664e
      volumeSize: 300Gi
      volumeType: gp3
  metadataOptions:
    httpEndpoint: enabled
    httpProtocolIPv6: disabled
    httpPutResponseHopLimit: 2
    httpTokens: required
  role: development-eu-west-1-karpenter-worker
  securityGroupSelectorTerms:
  - tags:
      cluster/development-eu-west-1/workers: "true"
  subnetSelectorTerms:
  - tags:
      karpenter.sh/discovery/development-eu-west-1: shared
  tags:
    Infra: EKS
    Name: development-eu-west-1-eks-worker-node
    Product: Shared
    karpenter.sh/discovery: development-eu-west-1

our nginx ec2nodeclass is set to have 120
apiVersion: karpenter.k8s.aws/v1beta1
kind: EC2NodeClass
metadata:
  annotations:
    karpenter.k8s.aws/ec2nodeclass-hash: "3386146869567909253"
    meta.helm.sh/release-name: karpenter-workers
    meta.helm.sh/release-namespace: karpenter
  creationTimestamp: "2023-11-02T13:15:37Z"
  finalizers:
  - karpenter.k8s.aws/termination
  generation: 2
  labels:
    app.kubernetes.io/managed-by: Helm
  name: nginx
  resourceVersion: "439330602"
  uid: ce905097-8c23-4f6a-9e20-b10d4fe80dbd
spec:
  amiFamily: AL2
  blockDeviceMappings:
  - deviceName: /dev/xvda
    ebs:
      deleteOnTermination: false
      encrypted: true
      kmsKeyID: arn:aws:kms:eu-west-1:xxxxxxxx:key/ff5842b6-4991-4464-80fc-1e1682c8664e
      volumeSize: 120Gi
      volumeType: gp3
  metadataOptions:
    httpEndpoint: enabled
    httpProtocolIPv6: disabled
    httpPutResponseHopLimit: 2
    httpTokens: required
  role: development-eu-west-1-karpenter-worker
  securityGroupSelectorTerms:
  - tags:
      cluster/development-eu-west-1/workers: "true"
  subnetSelectorTerms:
  - tags:
      karpenter.sh/discovery/development-eu-west-1: shared
  tags:
    Infra: EKS
    Name: development-eu-west-1-eks-nginx-worker-node
    Product: Shared
    karpenter.sh/discovery: development-eu-west-1

the nodeclaim itself for some reason also says 300Gi which is odd
apiVersion: karpenter.sh/v1beta1
kind: NodeClaim
metadata:
  annotations:
    karpenter.k8s.aws/ec2nodeclass-hash: "3386146869567909253"
    karpenter.k8s.aws/tagged: "true"
    karpenter.sh/managed-by: development-eu-west-1
    karpenter.sh/nodepool-hash: "774805070015068538"
  creationTimestamp: "2024-05-10T09:33:49Z"
  finalizers:
  - karpenter.sh/termination
  generateName: nginx-
  generation: 1
  labels:
    karpenter.k8s.aws/instance-category: c
    karpenter.k8s.aws/instance-cpu: "2"
    karpenter.k8s.aws/instance-encryption-in-transit-supported: "false"
    karpenter.k8s.aws/instance-family: c5
    karpenter.k8s.aws/instance-generation: "5"
    karpenter.k8s.aws/instance-hypervisor: nitro
    karpenter.k8s.aws/instance-memory: "4096"
    karpenter.k8s.aws/instance-network-bandwidth: "750"
    karpenter.k8s.aws/instance-size: large
    karpenter.sh/capacity-type: spot
    karpenter.sh/nodepool: nginx
    kubernetes.io/arch: amd64
    kubernetes.io/os: linux
    node.kubernetes.io/instance-type: c5.large
    node.kubernetes.io/worker-ingress-receiver: "true"
    topology.kubernetes.io/region: eu-west-1
    topology.kubernetes.io/zone: eu-west-1a
  name: nginx-bsn2h
  ownerReferences:
  - apiVersion: karpenter.sh/v1beta1
    blockOwnerDeletion: true
    kind: NodePool
    name: nginx
    uid: 32360463-dcfb-47af-8d50-22ff55ed2ddb
  resourceVersion: "439332711"
  uid: e4997948-e77b-4fc9-8ca6-9a5ac4c94e41
spec:
  kubelet:
    clusterDNS:
    - <IP_ADDRESS>
  nodeClassRef:
    name: nginx
  requirements:
  - key: karpenter.sh/nodepool
    operator: In
    values:
    - nginx
  - key: karpenter.sh/capacity-type
    operator: In
    values:
    - spot
  - key: node.kubernetes.io/worker-ingress-receiver
    operator: In
    values:
    - "true"
  - key: node.kubernetes.io/instance-type
    operator: In
    values:
    - c5.large
    - c5.xlarge
    - c6a.xlarge
    - c6i.xlarge
    - m5.large
  - key: topology.kubernetes.io/zone
    operator: In
    values:
    - eu-west-1a
  resources:
    requests:
      cpu: 795m
      ephemeral-storage: 3000Mi
      memory: 1921Mi
      pods: "11"
  taints:
  - effect: NoSchedule
    key: nginx
    value: "true"
status:
  allocatable:
    cpu: 1930m
    ephemeral-storage: 269Gi
    memory: 3114Mi
    pods: "29"
    vpc.amazonaws.com/pod-eni: "9"
  capacity:
    cpu: "2"
    ephemeral-storage: 300Gi
    memory: 3788Mi
    pods: "29"
    vpc.amazonaws.com/pod-eni: "9"
  conditions:
  - lastTransitionTime: "2024-05-10T09:34:43Z"
    status: "True"
    type: Initialized
  - lastTransitionTime: "2024-05-10T09:33:52Z"
    status: "True"
    type: Launched
  - lastTransitionTime: "2024-05-10T09:34:43Z"
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-05-10T09:34:30Z"
    status: "True"
    type: Registered
  imageID: ami-007901c6195ae9299
  nodeName: ip-10-110-4-53.eu-west-1.compute.internal
  providerID: aws:///eu-west-1a/i-00885188cccbf6eef

I have check the actual storage of the ec2 and it is 120Gi which matches what the ec2nodeclass says
this is the nginx nodepool and you can see it references the nginx nodeclass I posted
apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
  annotations:
    karpenter.sh/nodepool-hash: "774805070015068538"
    meta.helm.sh/release-name: karpenter-workers
    meta.helm.sh/release-namespace: karpenter
  creationTimestamp: "2023-11-02T13:15:37Z"
  generation: 1
  labels:
    app.kubernetes.io/managed-by: Helm
  name: nginx
  resourceVersion: "439773588"
  uid: 32360463-dcfb-47af-8d50-22ff55ed2ddb
spec:
  disruption:
    budgets:
    - nodes: 10%
    consolidationPolicy: WhenUnderutilized
    expireAfter: 720h
  template:
    spec:
      kubelet:
        clusterDNS:
        - <IP_ADDRESS>
      nodeClassRef:
        name: nginx
      requirements:
      - key: karpenter.sh/capacity-type
        operator: In
        values:
        - spot
      - key: node.kubernetes.io/worker-ingress-receiver
        operator: In
        values:
        - "true"
      - key: node.kubernetes.io/instance-type
        operator: In
        values:
        - c5.xlarge
        - c6i.xlarge
        - c6a.xlarge
        - c5.large
        - m5.large
      - key: topology.kubernetes.io/zone
        operator: In
        values:
        - eu-west-1a
        - eu-west-1b
        - eu-west-1c
      taints:
      - effect: NoSchedule
        key: nginx
        value: "true"
status:
  resources:
    cpu: "4"
    ephemeral-storage: 251633624Ki
    memory: 11698036Ki
    pods: "58"

Versions:

Chart Version: 0.35.0
Kubernetes Version (kubectl version):
Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.3-eks-adc7111

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

From the commit, I can see that you're running v0.35.0. That version has a bug in it that was resolved in later patch versions. I'd recommend either updating to the latest version (v0.36.1) or just upgrading to the latest patch version on your current minor version (v0.35.4) to get the fix.

Hi Jonathan, I just bumped to 0.36.1 and can still see the error
{"level":"INFO","time":"2024-05-13T11:56:11.838Z","logger":"controller","message":"webhook disabled","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:11.838Z","logger":"controller.controller-runtime.metrics","message":"Starting metrics server","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:11.839Z","logger":"controller.controller-runtime.metrics","message":"Serving metrics server","commit":"fb4d75f","bindAddress":":8000","secure":false}
{"level":"INFO","time":"2024-05-13T11:56:11.838Z","logger":"controller","message":"starting server","commit":"fb4d75f","kind":"health probe","addr":"[::]:8081"}
{"level":"INFO","time":"2024-05-13T11:56:12.139Z","logger":"controller","message":"attempting to acquire leader lease karpenter/karpenter-leader-election...","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.236Z","logger":"controller","message":"successfully acquired lease karpenter/karpenter-leader-election","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.236Z","logger":"controller.provisioner","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.236Z","logger":"controller.disruption.queue","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.236Z","logger":"controller.eviction-queue","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"provisioner.trigger.pod","controllerGroup":"","controllerKind":"Pod","source":"kind source: *v1.Pod"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"provisioner.trigger.pod","controllerGroup":"","controllerKind":"Pod"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller.disruption","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodepool.hash","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodepool.hash","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"provisioner.trigger.node","controllerGroup":"","controllerKind":"Node","source":"kind source: *v1.Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"provisioner.trigger.node","controllerGroup":"","controllerKind":"Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"state.node","controllerGroup":"","controllerKind":"Node","source":"kind source: *v1.Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"state.node","controllerGroup":"","controllerKind":"Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"state.daemonset","controllerGroup":"apps","controllerKind":"DaemonSet","source":"kind source: *v1.DaemonSet"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"state.daemonset","controllerGroup":"apps","controllerKind":"DaemonSet"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"state.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"state.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"state.pod","controllerGroup":"","controllerKind":"Pod","source":"kind source: *v1.Pod"}
{"level":"INFO","time":"2024-05-13T11:56:12.237Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"state.pod","controllerGroup":"","controllerKind":"Pod"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"node.termination","controllerGroup":"","controllerKind":"Node","source":"kind source: *v1.Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"node.termination","controllerGroup":"","controllerKind":"Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"state.nodeclaim","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"state.nodeclaim","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"metrics.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"metrics.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"metrics.pod","controllerGroup":"","controllerKind":"Pod","source":"kind source: *v1.Pod"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"metrics.pod","controllerGroup":"","controllerKind":"Pod"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1.Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller.metrics.node","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Node"}
{"level":"INFO","time":"2024-05-13T11:56:12.238Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller.nodeclaim.garbagecollection","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"lease.garbagecollection","controllerGroup":"coordination.k8s.io","controllerKind":"Lease","source":"kind source: *v1.Lease"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"lease.garbagecollection","controllerGroup":"coordination.k8s.io","controllerKind":"Lease"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodePool"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Pod"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *unstructured.Unstructured"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller.nodeclaim.garbagecollection","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclass","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass","source":"kind source: *v1beta1.EC2NodeClass"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclass","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodeclass","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller.pricing","message":"starting controller","commit":"fb4d75f"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting EventSource","commit":"fb4d75f","controller":"nodeclaim.tagging","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.239Z","logger":"controller","message":"Starting Controller","commit":"fb4d75f","controller":"nodeclaim.tagging","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"INFO","time":"2024-05-13T11:56:12.337Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodepool.hash","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.337Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"state.node","controllerGroup":"","controllerKind":"Node","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.337Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"provisioner.trigger.node","controllerGroup":"","controllerKind":"Node","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.338Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"provisioner.trigger.pod","controllerGroup":"","controllerKind":"Pod","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.343Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"metrics.pod","controllerGroup":"","controllerKind":"Pod","worker count":1}
{"level":"INFO","time":"2024-05-13T11:56:12.343Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.343Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.343Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":1000}
{"level":"INFO","time":"2024-05-13T11:56:12.344Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":100}
{"level":"INFO","time":"2024-05-13T11:56:12.344Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodeclaim.tagging","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":1}
{"level":"ERROR","time":"2024-05-13T11:56:12.344Z","logger":"controller.nodeclaim.consistency","message":"check failed, expected 300Gi of resource ephemeral-storage, but found 125816812Ki (40.0% of expected)","commit":"fb4d75f","nodeclaim":"nginx-bsn2h"}
{"level":"INFO","time":"2024-05-13T11:56:12.347Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.355Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"nodeclass","controllerGroup":"karpenter.k8s.aws","controllerKind":"EC2NodeClass","worker count":10}
{"level":"ERROR","time":"2024-05-13T11:56:12.356Z","logger":"controller.nodeclaim.consistency","message":"check failed, expected 300Gi of resource ephemeral-storage, but found 125816812Ki (40.0% of expected)","commit":"fb4d75f","nodeclaim":"nginx-9v9cf"}
{"level":"INFO","time":"2024-05-13T11:56:12.441Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"state.daemonset","controllerGroup":"apps","controllerKind":"DaemonSet","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.443Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"state.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.443Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"state.nodeclaim","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.443Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"lease.garbagecollection","controllerGroup":"coordination.k8s.io","controllerKind":"Lease","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.443Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"metrics.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":1}
{"level":"INFO","time":"2024-05-13T11:56:12.443Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"state.pod","controllerGroup":"","controllerKind":"Pod","worker count":10}
{"level":"INFO","time":"2024-05-13T11:56:12.444Z","logger":"controller","message":"Starting workers","commit":"fb4d75f","controller":"node.termination","controllerGroup":"","controllerKind":"Node","worker count":100

oh wait I bet its because the nodeclaims have not been replaced since upgrading so it reports on them being wrong


Option name changed

The current option was not even read by redactor.

Coverage remained the same at 98.9% when pulling 1f88842750d8af5e6c8ba10aea99855acbdada45 on nasmorn:patch-1 into 3abc9112a5e8479dcd0cc744f6bf10baf13a2315 on comfy:master.

Coverage remained the same at 98.9% when pulling 1f88842750d8af5e6c8ba10aea99855acbdada45 on nasmorn:patch-1 into 3abc9112a5e8479dcd0cc744f6bf10baf13a2315 on comfy:master.

Coverage remained the same at 98.9% when pulling 1f88842750d8af5e6c8ba10aea99855acbdada45 on nasmorn:patch-1 into 3abc9112a5e8479dcd0cc744f6bf10baf13a2315 on comfy:master.


DefinePlugin / add support for watch mode

Feature request

What is the expected behavior?
For Example: I have a build nr, which increments each "runWatch" hook. But DefinePlugin  only define variables at start, not on re-compile.
What is motivation or use case for adding/changing the behavior?
Now you can use a Function as a value (https://github.com/webpack/webpack/issues/6749). DefinePlugin only should update value with this defined function.
How should this be implemented in your opinion?
Only update values with the user defined function. Many other Plugins use a function for updates values on re-compile.
Are you willing to work on this yourself?
I will support this as good as I can :-)

thx!
if someone need's it, here is an example:
this.plugins.push(new webpack.DefinePlugin({
	'app.env': {
		'appVersion': `"${this.settings.appVersion}"`,
		'appHash': `"${this.settings.appHash}"`,
		'buildNr': webpack.DefinePlugin.runtimeValue(() => `"${this.settings.buildNr}"`, []),
		'apiPath': `"${process.env.APP_APIPATH}"`,
		'stage': `"${this.configuration.mode}"`,
	}
}));

For anybody wondering, this is how you provide a runtime define variable:
// webpack.config.js
const webpack = require('webpack')

module.exports = {
  plugins: [
    new webpack.DefinePlugin({
      MY_VARIABLE_NAME: webpack.DefinePlugin.runtimeValue(
        () => JSON.stringify('ANY_VALUE'),
        // Passing the second argument as `true` reevaluates the defined expression.
        // Beware that this disables module caching and must be used with caution.
        true,
      ),
    })
  ]
}


[add] Introduce health_check_interval, socket_connect_timeout, and socket_keepalive settings to Redis connections

Codecov Report

Merging #40 (cca52ca) into main (8843cb3) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   69.39%   69.48%   +0.09%
==========================================
  Files          12       12
  Lines         624      626       +2
==========================================
+ Hits          433      435       +2
  Misses        191      191

Impacted Files
Coverage Δ

...is_benchmarks_specification/__builder__/builder.py
72.18% <ø> (ø)

...tained_coordinator__/self_contained_coordinator.py
70.15% <ø> (ø)

redis_benchmarks_specification/__common__/env.py
97.05% <100.00%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8843cb3...cca52ca. Read the comment docs.


Kyber Implementation Not Working Properly

Key Exchange Issue with Kyber-1024 in Python
I am encountering an issue while implementing the Kyber-1024 key encapsulation mechanism in my Python project. The shared secret keys between two parties do not seem to match. I have provided a simplified version of the code below:
import oqs

algo = "Kyber1024"
kyber_A = oqs.KeyEncapsulation(algo)
public_key_A, private_key_A = kyber_A.generate_keypair(), kyber_A.export_secret_key()

kyber_B = oqs.KeyEncapsulation(algo)
public_key_B, private_key_B = kyber_B.generate_keypair(), kyber_B.export_secret_key()

shared_secret_A, encapsulated_key_A = kyber_A.encap_secret(public_key_B)
shared_secret_B = kyber_B.decap_secret(encapsulated_key_A)

assert shared_secret_A == shared_secret_B

Output:
Traceback (most recent call last):
  File "/home/flarexes/Desktop/dip/Project/qcrypto.py", line 39, in <module>
    assert shared_secret_A == shared_secret_B
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

Any help would be highly appreciated. Thank you!

Please take a look here for a full example: https://github.com/open-quantum-safe/liboqs-python/blob/main/examples/kem.py


Release v6

As travis can now push to sonatype, we can do a release of v6.
@orange-buffalo ; any reason not to?

@garethahealy, nope, I am for releasing.

Travis build:

https://travis-ci.org/DozerMapper/dozer/builds/236100398

Sonatype release:

https://oss.sonatype.org/content/repositories/releases/com/github/dozermapper/dozer-core/6.0.0/

GitHub release tag:

https://github.com/DozerMapper/dozer/releases/tag/v6.0.0

Maven Central:

http://central.maven.org/maven2/com/github/dozermapper/dozer-core/6.0.0/

Great, thanks a lot!
It would also very nice if the versions in poms were updated to the next snapshot.


Include article title in tweets text when sharing with Twitter

This pull request adds functionality to the Twitter share on the SNS share button below the article.
This pull request will include the article title in the tweet when sharing the article on Twitter.
Currently, only the URL is included in the tweet, not the title of the article.
When the tweet template is displayed, it would be nice to include both the article title and the URL.
Also, when the tweet template is displayed, the article title will be in the selected state. This is a Twitter specification.
It is a function that allows users to easily delete the text written in the template (here, the title of the article).
Please refer to here also about the function of Twitter.
https://developer.twitter.com/en/docs/twitter-for-websites/tweet-button/overview
Thank you!

@lulzneko
Sorry too late. Thanks :)


vueJS / using input mask with flatpickr

hi,
I',m using flatpickr in production and i've got vexing trouble with allow-input option
So, if i try to put data manually like "dd.mm.yyyy", it works pretty nice, but if you add any mask plugin (i'm using this one https://vuejs-tips.github.io/vue-the-mask/), after putting 2 symbols, datepicker automatically wiil add remaining symbols. For example, you put "04" and any next "number" key will generate random date, something like 04.01.2019.
the problem is relevant only for chrome browser :)

I too am having this issue using "vue-flatpickr-component": "^8.1.5", & "vue-the-mask": "^0.11.1",

btw I was able to get masking working by using: https://nosir.github.io/cleave.js/
I just did this inside of my mounted()
mounted() {
      new Cleave(this.$refs.departureDate.$el, {
        date: true,
        datePattern: ['m', 'd', 'Y'],
      });
    },

@robertguss Looking at the API of Cleave I saw there's a method destroy.
 Something like:
data() {
  return {
    cleave: null
  }
},
mounted() {
  this.cleave = new Cleave(this.$refs.departureDate.$el, {
    date: true,
    datePattern: ['m', 'd', 'Y'],
  });
},
beforeDestroy() {
  this.cleave.destroy();
}

This will clean up the event listeners created from cleave.
Reference: https://github.com/nosir/cleave.js/blob/master/src/Cleave.js#L450

Much appreciated @atilacamurca! I will try this. Thank you


irmin: move store signatures in their own modules

With the removal of cap locks in #1341, this results into all the
Irmin.X_STORE being moved to Irmin.X.Store:

Irmin.APPEND_ONLY_STORE is now Irmin.Append_only.Store
Irmin.CONTENT_ADDRESSABLE_STORE is now Irmin.Content_addressable.Store
Irmin.ATOMIC_WRITE_STORE is now Irmin.Atomic_write.Store

Also all the Irmin.X_STORE_MAKER are now Irmin.X.Maker:

Irmin.APPEND_ONLY_STORE_MAKER is now Irmin.Append_only.Maker
Irmin.CONTENT_ADDRESSABLE_STORE_MAKER is now Irmin.Content_addressable.Maker
Irmin.ATOMIC_WRITE_STORE_MAKER is now Irmin.Atomic_write.Maker

This gives some space to move convenient functors (such as Check_closed) closer
to the definitions they act upon.

I don't disagree with an extra level of namespacing, but Store is already used :-) I can move Store to S though.


[Suggestion] Some suggestions

1#
The current idle standing is pretty hunched over, though it works really well, it looks a bit goofy.
2#
Enabling the ladder climbing animation for EVERY ladder in the game would be amazing. I've tried doing it myself by looping through all ladder entities on a map and simply replacing them with br_ladder but that doesn't really work since they aren't all the same length and other issues.
3#
This is really just an arcady/throwing it out there suggestion but a parachute compatible with beatrun 🤷
Great work yall are doing!

Anims are made by MTB, they look how he wants but you can ask him if he wants to change them.
Pretty much impossible to calculate the height for every ladder on the map.
Just no.

Ah, I understand, thank you.


Zero-copy receive optimization disabled the invocation of direct actions

This is a note for what we discussed this week.
Enabling zero-copy receive optimization will disable all direct actions. It should be fixed.
I pasted the related code below
    template <typename Parcelport, typename Buffer>
    std::vector<parcelset::parcel> decode_message_with_chunks(
        serialization::input_archive& archive, [[maybe_unused]] Parcelport& pp,
        [[maybe_unused]] Buffer& buffer, std::size_t parcel_count,
        std::size_t num_thread = -1)
    {
           ........
                    else if (deferred_schedule || allow_zero_copy_receive)
                    {
                        // store parcel if needed
                        deferred_parcels.emplace_back(HPX_MOVE(p));
                    }

https://github.com/STEllAR-GROUP/hpx/blob/8a949a755414f5e908caeb4c03e1ba635e110b4f/libs/full/parcelset/include/hpx/parcelset/decode_parcels.hpp#L354

template <typename Parcelport, typename Buffer>
std::vectorparcelset::parcel decode_message_with_chunks(
serialization::input_archive& archive, Parcelport& pp,
Buffer& buffer, std::size_t parcel_count,
std::size_t num_thread = -1)
{
// ...
else if (deferred_schedule || allow_zero_copy_receive)
{
// store parcel if needed
deferred_parcels.push_back(std::move(p));
}
// ...
}

implementation and usage of the deferred_parcels container to ensure it is defined correctly and use appropriately.

After some analysis of the code - direct actions are still supported, even with zero-copy support on the receiver being enabled. I'll close this ticket.


AttributeError: 'Map' object has no attribute 'add_child'

I am trying to run the minimal example and getting this error. Maybe I am missing something big.

Report:
Date: Tue Mar 29 23:20:12 2022 UTC
                 OS : Linux
             CPU(s) : 8
            Machine : x86_64
       Architecture : 64bit
                RAM : 31.4 GiB
        Environment : Jupyter

  Python 3.8.10 (default, Nov 26 2021, 20:14:08)  [GCC 9.3.0]

    localtileserver : 0.4.4
              flask : 2.1.0
      flask_caching : 1.10.1
        flask_restx : 0.5.1
           requests : 2.27.1
           werkzeug : 2.0.3
              click : 8.0.4
             scooby : 0.5.12
        large_image : 1.12.0
large_image_source_gdal : 1.12.0
         cachetools : 5.0.0
                PIL : 9.0.1
             psutil : 5.9.0
              numpy : 1.22.3
         palettable : 3.3.0
             pyproj : 3.3.0
         osgeo.gdal : 3.0.4
         ipyleaflet : 0.15.0
          traitlets : 5.1.1
            shapely : 1.8.1.post1
             folium : 0.12.1.post1
         matplotlib : 3.5.1

You need to use folium rather than ipyleaflet in this example

@giswqs I ran the example code provided by the library document. And here we meet again. 😄

So, did the example work for your Jupyter on a remote server?

@giswqs No, it's not working and I have been reading previous issues (#1 #29 #66) on this repo and found it's way more complicated than it looks.

🤦♂that method should be add_layer for ipyleaflet. I will update this asap
Regarding your remote environment, what is the environment?

@banesullivan We have a physical server, placed and run from one place. Jupyter notebook docker is installed on it so everyone can access it with a simple link. We access it like a website.
Specs of it are shown in the report mentioned above. Let me know if there are some specific questions about the server.
Thanks!

I think you will want to use the jupyter server proxy set up in that scenario (otherwise, you need to expose the port on which localtileserver is running inside the docker container). Hopefully this guide is all you need: https://localtileserver.banesullivan.com/installation/remote-jupyter.html

@banesullivan Thank you very much for the quick response. I will give it a try.

If it helps, there is a Jupyter dockerfile here: https://github.com/banesullivan/localtileserver/blob/main/jupyter.Dockerfile

@haseeb33 Once you get the example to work, you should then be able to use geemap's add_local_tile()  function as usual.

Hi!
I'm sorry to comment on the closed issue, but my question is very familiar to the original one (as well as to #29 #66). I'm trying to use localtileserver for displaying image with folium on remote Jupyter Hub (physical server) and the image is not showing. As far as I understand, instead of TileClient function I need to use  RemoteTileClient.
I've tried already:
RemoteTileClient('image.tif', host = 'http://<IP_ADDRESS>:port',  default_projection='EPSG:3031')
RemoteTileClient('image.tif', host = 'http://<IP_ADDRESS>', default_projection='EPSG:3031')
RemoteTileClient('image.tif', host = 'http:/user/username/', default_projection='EPSG:3031')

hostname (http://<IP_ADDRESS>) and port were recieved with
from notebook import notebookapp
servers = list(notebookapp.list_running_servers())
print(servers)

So my question is what is the correct way to pass host and port to  RemoteTileClient function? Or am I missing something?
For remote JupyterHub I followed this instruction: https://localtileserver.banesullivan.com/installation/remote-jupyter.html
I'm using localtileserver v.0.6.1
Displaying the same image locally works perfectly.
Also, I've encountered a 404 Client Error, when not specifying default_projection for RemoteTileClient (my data is in EPSG:3031), while for TileClient it was not necessary

@Dodekaphonia, would you please open a new issue for this?


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

@bryant1410 This page has been removed in favour of maintaining Github wiki for this project.


[WIP] Adds update_env script for staging deployment

This might resolve #196, given an addition to the Makefile.
This is also another solution I came across that could work:
https://stackoverflow.com/questions/7250659/how-to-use-python-to-programmatically-generate-part-of-sphinx-documentation
Keep in mind we don't need to do this step if our 'staging' is using a simple HTML file like development.html.
I also had trouble building the docs (my environment), so I wasn't able to test this and get the right script src yet.

@choldgraf Wanted to ping you and see what your thoughts are here? No rush.

Nice! Barring some better way of doing this (that I don't know about), this seems fine to me. We should just make sure to document it well so people know about it

Busy over here!
I'll update this PR soon.

The last hiccup I'm having here is that I can't build the docs. I get an error complaining about recommonmark, but I can't seem to resolve that dependency on either of my systems. If we can update the local URL and make sure the build:docs npm script command works, I think that's the last blocker here!

OK good to know. Hmmm, I can try to build it locally and see if it works then

@choldgraf, just a reminder about my comment in update-url, since it won't work 'out of the box': https://github.com/minrk/thebelab/pull/208/files#diff-15bcc910a34ad71aa4260aabea4a2673


Updating title values in SVG doesn't work

There seems to be a bug in the SVG plugin which makes it impossible to dynamically update the title values.
This is on line 90 of tooltipster-SVG.js: $title.remove();
I assume the above code is there to prevent the default tooltips from showing up. Unfortunately this means that it is not possible to update the title attribute of an SVG element without reloading the page (because it has been removed).
Is there a way to work around this (for example by using a data-attribute?) or is this a bug that needs to be fixed?

Hi, why would you update the title attribute? Update the tooltip content instead with the content method.

Thanks for the quick reply! I was creating the tooltips by populating an empty <title></title> element on the SVG and that was causing the issue. I now target the element ID and then I set the content which works.


Baker id is not resolved

Bug Description
If a mobile wallet contains account with baker, baker id is not correctly resolved.
Id from screenshot should be 5109.
Steps to Reproduce
Use account created with mobile to have a baker on Testnet.
Expected Result
Baker Id should be 5109.
Actual Result

Versions

Software Version: Testnet 2.0.1 (71)
OS: Android 11
Browser: N/A
Mobile device: Pixel 4a

@mh-concordium I don't have an account with baker. But, the fix is simple so it might work. If not, I need an account with baker.

Verified in CCD app Android 2.0.3 (73).


Suggestion: Third key while playing osu! Standard

I tried adding a third key to have as another picture (like x and z) but for smoke.
Since i thought it would add a lot for my stream seeing how i draw a lot with smoke and me and my chat thought it would be funny if we could make the cat smoke while i drew with smoke (hence i need a third key used for a third image).
This might not be something you see as important, if so i understand you and i will try harder to fix it myself but it's quite hard seeing how i only know c and java 😛
And if this is something you don't want in the main code i wouldn't mind if you had time and sent me it privately or something (i dont know how github works)

So you'd want a third key for smoke, corresponding to another image (for example smoke.png)?

The release is out! Sorry for the late update.

Its perfect i love it.
Something i notice tho is that the animated arm (pen/mouse arm) is ontop of the smoke and blunt. But its just so little so probably doesnt matter. Learnt a ton from reading the code changes ty :)

Noted that, it will be fixed in the next release ;)


Update outdated bootstrap/jquery scripts

Title
Update outdated bootstrap/jquery scripts
Summary
Update bootstrap/jquery scripts used within the forbidden template
Why?
The scripts are out of date, and have some vulnerabilities
https://security.snyk.io/package/npm/jquery
https://security.snyk.io/package/npm/bootstrap
How
The forbidden template references these scripts -> https://github.com/gogatekeeper/gatekeeper/blob/master/templates/forbidden.html.tmpl
Acceptance criteria
Jquery updated to non vulnerable versions (3.7.1 current latest)
Bootstrap updated to non vulnerable versions (5.3 current latest)

@georgeeker thanks for creating issue! will update

@georgeeker updated


refactor(domain): use strings.CutPrefix

Close #236.

Everything works except that the coverage data generated by Go 1.20 are off: packages without test files do not appear in the coverage report even with -coverpkg.


[Question]: How to avoid loading my model everytime?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hello everyone,
I apologize if my question seems simple or naive. 😅
I'm currently developing a script that loads models (downloaded from HuggingFace) each time it runs. However, loading the necessary models takes approximately 30 seconds, which is unacceptable for my rapid development process.
I've tried using Ollama, which allows models to reside in GPU memory. Unfortunately, Ollama doesn't support the models I'm using.
A potential solution I'm considering is starting another process that holds the model in GPU memory and performs inference. My script could then communicate with this process via HTTP APIs. However, I'm new to LlamaIndex and could use some help. Can anyone give me some advice?
Thank you!🥰

I am not sure I fully understand the details, however I will try to give an idea anyway hope it's not completely far off :)
One approach would be as you have mentioned to have a running service (e.g. Flask) on same machine/different machine which is always live and you can do an HTTP request to that service so that you do not deal with this inside your llamaindex pipeline.
I am guessing you could also look at workflow deployment through llama-deploy, I guess if you make your code into a workflow it will be loaded once and you can run the workflow through an HTTP call as well, doing whatever you are doing.

@hristogg Thanks!🥰I'll take a look

@HairlessVillager another option is an optimized server dedicated for models, like TGI and TEI from huggingface, or vllm. I think this is a fairly common practice


ARROW-2568: [Python] Expose thread pool size setting to Python, and deprecate "nthreads" where possible

There are two areas where nthreads cannot be replaced immediately by the global thread pool:

when converting Pandas data to Arrow table or record batch, since it uses a Python ThreadPoolExecutor from pure Python code (see dataframe_to_arrays in pandas_compat.py)
when reading or writing Parquet data, since parquet-cpp relies on parallelization facilities in the stable version of Arrow (see https://github.com/apache/parquet-cpp/pull/467)

Elsewhere, we add a use_threads boolean argument and deprecate nthreads.

There's a weird issue on Windows. It seems the global ThreadPool destructor is called after the OS has killed the worker threads, and it hangs on notifying a condition variable. I will have to find a strategy to work it around.

Codecov Report

Merging #2078 into master will decrease coverage by <.01%.
The diff coverage is 96.75%.

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
- Coverage   86.33%   86.33%   -0.01%
==========================================
  Files         242      230      -12
  Lines       41103    40288     -815
==========================================
- Hits        35487    34782     -705
+ Misses       5616     5506     -110

Impacted Files
Coverage Δ

cpp/src/arrow/python/arrow_to_pandas.h
100% <ø> (ø)
:arrow_up:

cpp/src/arrow/util/thread-pool.h
92.3% <ø> (ø)
:arrow_up:

python/pyarrow/tests/test_convert_pandas.py
94.78% <100%> (ø)
:arrow_up:

cpp/src/arrow/status.cc
44.64% <100%> (-1.79%)
:arrow_down:

python/pyarrow/tests/test_ipc.py
100% <100%> (ø)
:arrow_up:

cpp/src/arrow/util/memory.h
100% <100%> (ø)
:arrow_up:

cpp/src/arrow/status-test.cc
100% <100%> (ø)
:arrow_up:

python/pyarrow/lib.pyx
100% <100%> (ø)
:arrow_up:

cpp/src/arrow/util/thread-pool-test.cc
99.45% <100%> (+0.02%)
:arrow_up:

python/pyarrow/tests/test_misc.py
100% <100%> (ø)
:arrow_up:

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5e95a...a7aeed0. Read the comment docs.

I think I addressed all review comments now.


Instructions on Wiki unclear for moving scenes.

Copied the movement JSON to the folder from the wiki... but then what? How to make it work in game? There is no area from which to select the movement script in game.

I have saved the template movement file as a JSON in the directory indicated, but then I still have no idea what to do next to make this work. I'm sure it is maybe obvious, but I am pretty dumb. Can you spell it out or step-by step the rest of the process?


Learning ....github

aall

Please update your local repo with the command
$ git pull
Please add your name in the Contributors List.

ooosso


Sensor Telemetry Data

This branch adds the tracking of telemetry data to Transmission. Telemetry data can include measurements such as light, distance, temperature, et cetera, as defined by the sensor that signs the payload. This adds two new endpoints:

/shipments/{shipment_id}/telemetry
/device/{device_id}/telemetry

The shipment endpoint allows GET calls, and works similarly to tracking data, caching responses for 1 hour. This returns all the telemetry data found for a shipment signed between pickup and delivery, and returns it in a list. Filtering is available for this endpoint based on the telemetry data's sensor_id and/or hardware_id.
The device endpoint allows POST calls, and works similarly to tracking data. This endpoint accepts a signed jws payload, which it will verify against the device's data before storing it on transmission and on the engine.

Looks like the integration tests still need to be fixed

Please rebase

Needs another rebase please


Improve Android product & inventory retrieval

Only submit requests to the Billing engine when the initialization is done
Re-Create the billing manager for each interaction to avoid overlaps
Add a new method to retrieve the list of SKUs a user has currently purchased (Android only, for the moment)

This should also fix https://github.com/JackAppDev/flutter_iap/issues/18
Currently, the fetchInventory does not retrieve active subscriptions, and does not work on iOS. I can work on this in about 2 months.

Could you include an updated readme and example?

@JackAppDev ok, take a look


Fastnlight: Watch studypointhometutorials.com

Fastnlight requests the watch of the watch_keyword studypointhometutorials\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

studypointhometutorials\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Add filtering for SOR pool data service.

Needs PR#267 merged
Adds new poolsToIgnore config option.
Pools included in poolsToIgnore will be filtered out of SOR pools list.
https://app.asana.com/0/1201380039585484/1203701341870003/f

Closed in favour of: https://github.com/balancer-labs/balancer-sdk/pull/276


Improve iOS 9 support

Fixes two issues that prevent Frank from initializing correctly on iOS 9:

The AX Inspector needs to be enabled (as seen in KIF and EarlGrey. If the AX inspector is not enabled, the accessibility properties (such as accessibilityLabel) are not populated and selectors such as marked don't work as expected
Some additional logging in the load method.
The UIApplicationDidBecomeActiveNotification notification is not always sent on iOS 9 - as also documented on StackOverflow

Thank you!


html rendering using pandoc

for example
automated management of the documents â€“ like assigning priorities or work tasks

see the output on https://profiles.ihe.net/ITI/HIE-Whitepaper/

newer version of pandoc out this week solved that problem.
BUT, I can't figure out how to get tables to render in html as tables with boarders. The css recommendations I find are not working for me. They render fine from github pages, just not from pandoc.


fix(vim/#2162): Crash with arrow keys

here were a couple of problems with our existing command-line arrow key handling - the first is that the cmdpos wouldn't always be up-to-date, causing us to get a seg fault when expanding for completions.
Once the seg fault was fixed, another issue was discovered with the arrow keys - the command line had two notions of position - one is the byte position of the cursor relative to the command line text (cmdpos), and the other is the position on-screen of the cursor (cmdspos). The cmdspos isn't really relevant for Onivim, because we have custom rendering outside of a 'terminal grid' - but, the cmdspos could stop the cursor moving if libvim thought it was out-of-bounds. So the cmdspos was also removed.
This brings in https://github.com/onivim/libvim/pull/216, and also adjusts our completion expansion to only trigger at the end of the string, since we don't reliably complete in the middle of a command at the moment.
Fixes #2162

/azp run


If statement is executed despite being commented

Output of helm version:
Client: &version.Version{SemVer:"v2.16.0", GitCommit:"e13bc94621d4ef666270cfbe734aaabf342a49bb", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.16.0", GitCommit:"e13bc94621d4ef666270cfbe734aaabf342a49bb", GitTreeState:"clean"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.7", GitCommit:"8fca2ec50a6133511b771a11559e24191b1aa2b4", GitTreeState:"clean", BuildDate:"2019-09-18T14:47:22Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.6", GitCommit:"96fac5cd13a5dc064f7d9f4f23030a6aeface6cc", GitTreeState:"clean", BuildDate:"2019-08-19T11:05:16Z", GoVersion:"go1.12.9", Compiler:"gc",
Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Minikube
Actual problem:
Despite being commented with '#' the following if statement is being executed:
{{- if ne .Values.something "something else" }}
some configuration
{{- end }}
some other configuration
Is this the expected behaviour?

Helm uses Go’s text/template library for template execution. I think this may be a better question for upstream.
https://golang.org/pkg/text/template/

@doandzhiFt Did you get a chance to ask upstream in Go’s text/template about its behaviour?

Hi, @doandzhiFt - as this is not a Helm-specific issue we pointed you to https://golang.org/pkg/text/template/. I see this on that page:
{{/* a comment */}}
{{- /* a comment with white space trimmed from preceding and following text */ -}}
	A comment; discarded. May contain newlines.
	Comments do not nest and must start and end at the
	delimiters, as shown here.

Hopefully that helps. Please let us know if you have further Helm questions; thanks!


413 Error for INSEE

Hello,
I am getting the 413 Client Error for certain time series data from INSEE. I'm not a programmer but I understand that this error means the data is too big so I used the params argument to pull shorter timespans but it still shows the error.
The exact error:  HTTPError: 413 Client Error:  for url: https://www.bdm.insee.fr/series/sdmx/data/IPC-2015?startPeriod=2020-06-01.
Would appreciate some clarity on this problem.
Thanks

Try to limit the number of columns by providing a key to the data request. See the docs for examples.


Update index.html

Fixed copy right bug using javascript , now it will automatically take current year rather than existing direct copy paste using html.
This PR was for the issue #261

@arghadipmanna101 please label as gssoc . Thanks


[question] Do I need to run this on every host?

I want to have multiple hosts on my infrastructure. Should I put RAP on each host?

Yes, you can put rancher on all host you can then load balance traffic from dns to the different host IP.
Or you can run one RAP on main host , send all traffic to this host , and let it forward request to containers/services spawn on slave host


Make output of eyaml decrypt valid yaml with multiline values.

Per #176, eyaml decrypt doesn't generally work well with multi-line values.  This fixes that.  There's additional testing around this, and we've been running it for about a month now without issue.
Someone may want to run this test on a Windows machine to make sure my line endings make sense.  They should, but it got less testing on there than on linux & mac.

Rebased against master to pick up the test-passing code.  All of them have passed (woohoo!), and anecdotally we've been running this in production for ~4 months now with no problems.


when i run fake gps i got error

rohan@rohan-HP-15-Notebook-PC:~$ dronekit-python/examples/follow_me/run-fake-gps.shSending fake GPS data
Traceback (most recent call last):
File "/usr/bin/gpsfake", line 25, in
import gps.fake as gpsfake   # The "as" pacifies pychecker
File "/home/rohan/.local/lib/python2.7/site-packages/gps/fake.py", line 90, in
from . import packet as sniffer
ImportError: cannot import name packet
please help.thank you

On Tue, 5 Mar 2019, NAGENDRA BABU MARELLA wrote:

File "/home/rohan/.local/lib/python2.7/site-packages/gps/fake.py", line 90, in
from . import packet as sniffer
ImportError: cannot import name packet

Not really a dronekit-python qeustion :-)
You're missing something like the Python packet python-socketio
Peter

@peterbarker how to find that

@peterbarker  is dronekit-python will work on python3 please help if yes what are change i should do please help

This is a support issue please use the forums to post support questions. Thanks


Detect API changes using pre-generated code file by CI approach

Create API review from pull request using code file created by CI. APIView will use this approach instead of converting artifact to code file within server if review file name is passed as a parameter.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Investigate "live view" on block and tx tables for nakamoto

Investigate if our infra and code can handle nakamoto speed without looking performance
Once we have that, if the API supports websockers we want to implement a toggle that allows "live view" on the tx and block lists. This will showcase and be a good representation of Nakamoto

:tada: This issue has been resolved in version 1.120.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Github ubuntu linux installation

I'm trying to run staticjinja from a github workflow script:
...
    steps:
      - uses: actions/checkout@v2
      - run: pip install staticjinja && staticjinja build
...

However, after a successful installation of staticjinja (pip install staticjinja) I get an error trying to run staticjinja build:
...
Successfully installed docopt-0.6.2 easywatch-0.0.5 staticjinja-1.0.3 watchdog-1.0.2
/home/runner/work/_temp/e2263f86-a480-4903-8010-703fbf96db29.sh: line 1: staticjinja: command not found
Error: Process completed with exit code 127.

What am I doing wrong?

Hi! Sorry, just saw this.
I'm not immediately sure. Have you been able to do this in a previous version of staticjinja? I've been making some changes, but nothing that seems related to packaging and the CLI entry point (since I think that is the problem, it's not some internal problem inside staticjinja, it's that the CLI entrypoint simply isn't being installed...).
As some sanity checks, what OS and and python version do you have your runner set up with? (though I imagine this isn't important 😢 )
I can try to look into this more.

Hi! Sorry, just saw this.
I'm not immediately sure. Have you been able to do this in a previous version of staticjinja? I've been making some changes, but nothing that seems related to packaging and the CLI entry point (since I think that is the problem, it's not some internal problem inside staticjinja, it's that the CLI entrypoint simply isn't being installed...).
As some sanity checks, what OS and and python version do you have your runner set up with? (though I imagine this isn't important 😢 )
I can try to look into this more.

In the test PR #135, I wasn't able to reproduce. See the result of the action at https://github.com/staticjinja/staticjinja/runs/1803018502. I do notice that although that run also installed SJ 1.0.3 like yours did, it did install other versions of the other dependencies. I'd guess this might be because of differing python versions? My test used python 3.9.1. Again, knowing your python version might be helpful for me to try to reproduce.
Also, if you could give the entire contents of your action yaml, or give me the link to your failed action run, either of those would also be helpful.

Hi!
Here's the full log for the action:
Run pip install staticjinja && staticjinja build
12
Collecting staticjinja
13
  Downloading staticjinja-1.0.3-py2.py3-none-any.whl (10 kB)
14
Collecting docopt
15
  Downloading docopt-0.6.2.tar.gz (25 kB)
16
Requirement already satisfied: jinja2 in /usr/lib/python3/dist-packages (from staticjinja) (2.10.1)
17
Collecting easywatch
18
  Downloading easywatch-0.0.5.tar.gz (2.9 kB)
19
Collecting watchdog
20
  Downloading watchdog-1.0.2-py3-none-manylinux2014_x86_64.whl (72 kB)
21
Building wheels for collected packages: docopt, easywatch
22
  Building wheel for docopt (setup.py): started
23
  Building wheel for docopt (setup.py): finished with status 'done'
24
  Created wheel for docopt: filename=docopt-0.6.2-py2.py3-none-any.whl size=13704 sha256=4accd09eddf8ad94c881ef613decd51980f3363c9f247495b2d65caa2537fb55
25
  Stored in directory: /home/runner/.cache/pip/wheels/56/ea/58/ead137b087d9e326852a851351d1debf4ada529b6ac0ec4e8c
26
  Building wheel for easywatch (setup.py): started
27
  Building wheel for easywatch (setup.py): finished with status 'done'
28
  Created wheel for easywatch: filename=easywatch-0.0.5-py3-none-any.whl size=3007 sha256=efbf266d084d314e6fc21338a13eac01dcfd6884ce2a594fb5ebe758d15a5740
29
  Stored in directory: /home/runner/.cache/pip/wheels/23/f9/3f/9ba6110942a25ec369c8dfb1e59471e5d9bb56279224a10f5a
30
Successfully built docopt easywatch
31
Installing collected packages: docopt, watchdog, easywatch, staticjinja
24
  WARNING: The script watchmedo is installed in '/home/runner/.local/bin' which is not on PATH.
25
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
26
  WARNING: The script staticjinja is installed in '/home/runner/.local/bin' which is not on PATH.
27
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
28
Successfully installed docopt-0.6.2 easywatch-0.0.5 staticjinja-1.0.3 watchdog-1.0.2
29
/home/runner/work/_temp/ab616b78-9a76-4df5-a8b8-b7aba38dad65.sh: line 1: staticjinja: command not found

And here's the workflow file:
name: Deploy to Firebase Hosting on merge
'on':
  push:
    branches:
      - main
jobs:
  build_and_deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - run: pip install staticjinja && staticjinja build
      - uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: '${{ secrets.GITHUB_TOKEN }}'
          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_CIAN_PARSE }}'
          channelId: live
          projectId: cian-parse
        env:
          FIREBASE_CLI_PREVIEWS: hostingchannels

As you can see, neither python version nor operating system are set, so I assume by default they are Ubuntu / Python 3.9.

Changing the command to: pip install staticjinja && /home/runner/.local/bin/staticjinja build solved the problem, so I'm closing this issue, unless you decide to keep this open.

I think the root cause of the issue is that you are not running actions/setup-python@v2, and thus you have no guarantee which python version is installed. If I google is installed in '/home/runner/.local/bin' which is not on PATH. then it appears that this is a common problem, not just with staticjinja. I didn't read enough of those posts to really get to the bottom of the problem, but you could.
My first reaction would be I would encourage you to use actions/setup-python@v2 instead of just hardcoding in the bin path, since a weird/unknown version of python could cause problems all over the place. Your solution might just work fine though :) Thanks for the issue, and I hope you enjoy staticjinja!

You were 100% right.
After I added setting up python to the workflow, everything started working flawlessly, even without using the staticjinja path explicitly in the command statement.
Thanks!


Add compatibility to the latest BinaryDriver version

Q
A

Bug fix?
no

New feature?
no

BC breaks?
no

Deprecations?
no

Fixed tickets
N/A

Related issues/PRs
N/A

License
MIT

What's in this PR?
I add the latest BinaryDriver version constraint as it seems there was an issue with tags v2.0.0, v4.1,...
You can have a look at https://github.com/alchemy-fr/BinaryDriver/issues/25

Oh, sorry I missed this. Thank you!


Student Summit Watch Party at Microsoft ADC Nigeria

Here's the link.

I think this event had been held already. You can go ahead and close the issue

Ah! Thanks for reminding me @Tonie-NG 🤲🏽


Reassure minor upgrade

Some users were understandably a little incredulous that the short instructions for minor Citus upgrades are sufficient. Adding a reassuring note.

Looks good, but not sure about why we need to add a note to install last on the master node.

I thought perhaps if you upgrade the master to a version with new features before upgrading workers then it might ask them to do things they don't yet understand. But if that's not the case (and won't ever be the case for a minor upgrade) then I'll remove that warning.

I don't know if that line will always be the situation. Let's leave it out for now. Other than that, 🚢


secure-cookie false is ignored if set via command line.

we are trying to replace the official keycloak proxy with this implementation.
We are facing the problem that the error message the cookie is set to secure but your redirection url is non-tls is displayed even if the cmd argument --secure-cookie false is set.
How To Reproduce the erro
create a  file .env
PROXY_DEBUG=true
PROXY_DISCOVERY_URL=https://auth.example.io/auth/realms/playground
PROXY_CLIENT_ID=account
PROXY_CLIENT_SECRET=a1b25660-bf80-41c6-8372-f3dafbad4744
PROXY_LISTEN=":8080"
PROXY_ENABLE_REFRESH_TOKEN="true"
PROXY_REDIRECTION_URL=http://localhost:5050
PROXY_SECURE_COOKIE=false
PROXY_ENCRYPTION_KEY=macsefvijadrufcafpotgaciocgazvaf
PROXY_UPSTREAM_URL=http://localhost:5050
PROXY_RESOURCES="uri: /*"

run docker compose
docker-compose -f https://raw.githubusercontent.com/8gears/keycloak-auth-proxy/feature/go-proxy/docker-compose.yml up

in the file start-proxy.sh you see that PROXY_SECURE_COOKIE is add as --secure-cookie but event if it is hard coded to  --secure-cookie false its not working.

got it should be --secure-cookie=false instead of --secure-cookie true


Logging use of Recipes and Contraptions

Something which tracks whenever a player uses an Contraption.

This is already logged to console I think


[#1] Add a RxJava 3 module copied from the RxJava 2 module.

resolves #1
This replaces https://github.com/resteasy/resteasy/pull/3118

lgtm.  Thanks!


Android 13: Ask for notification permission

SDK 33 requires a permission to post notifications (https://developer.android.com/develop/ui/views/notifications/notification-permission).

Done in https://github.com/binwiederhier/ntfy-android/commit/92ec2d753f4c0a999d4ced5d508be548f4bb03bd


Add support for the suit log (issue #35)

This implements the feature request from #35
The custom modes for the ship log only used standard item lists, so they could be ported to Suit Log without any hassle. I only had to follow the advice from the Suit Log mod (using the generic ItemListWrapper from the Ship Log Slide Reel Player Plus mod).
The second commit fixes an issue where the images for the check list wouldn't load (defaulting to the OTHER_SYSTEM_PLACEHOLDER) unless the ship log was accessed first. It turns out there was a much nicer way to fetch the sprites than by traversing the component hierarchy, and that solves my issue as well.
Scrolling through the inventory throws the following exception, but it doesn't seem to have any ill effect. Not sure if it's my fault, Suit Log's fault, or
NullReferenceException: Object reference not set to an instance of an object
Stacktrace: ShipLogFactListItem.GetPosition () (at <bb45013cdd174c6e9670b07181b0b751>:0)
SuitLog.DescriptionField.GetListBottomPos () (at <3950c138613545e99c60c4ac7de16658>:0)
SuitLog.DescriptionField.GetMaxScroll () (at <3950c138613545e99c60c4ac7de16658>:0)
SuitLog.DescriptionField.UpdateScroll () (at <3950c138613545e99c60c4ac7de16658>:0)
SuitLog.DescriptionField.Update () (at <3950c138613545e99c60c4ac7de16658>:0)

I regularly see the ShipLogFactListItem.GetPosition() stack during my own normal gameplay, and every time I've observed no buggy behavior in the game itself, so I'm pretty sure that's a harmless CSLM issue and not the fault of this PR.
(proper review later)