Suggestion about RPC

Suggestion: can put the image of artist instead google play image
Suggestion2: can change the discord rpc "game" name to Youtube Music instead google play music when using ytmusic
Suggestion3: if the first suggestion not "the best", can only put yt icon when using ytmusic
Bug:

sometimes using Youtube Music, you can see "Unknown Artist"
Big thank you for the attention.

To answer your suggestions:
1 is not possible, due to the way the integration works. The image presented has to be uploaded to discord ahead of time and referenced by name, making that impossible.
2. Possible, but I believe it was discussed the player name is the reason that is displayed, and until they shut down GPM that's the way @MarshallOfSound intended to keep it.
3. Same as above, the icon is the player icon, even though it resembles the GPM icon.
As for unknown artist, I believe that's an issue with the underlying implementation.


[Catalog Graph] Fix kind filter error in dev app

Hello 👋🏻
This PR fixes an issue in the catalog-graph plugin where the catalog graph page shows an error message saying that it Failed to load entity kinds and the Kinds filter doesn't show up, see the screenshot below:

I've fixed this issue by adding a mock for the getEntityFacets function to return the existing kinds from the sample data (since it's called from within the SelectedKindsFilter component).
I've also added two additional Resources to the example data so that the list includes all the core entity kinds.
See the screenshot below of what the dev app interface looks like after the changes:

:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
I don't believe that's necessary since the changes affect only the dev code, please let me know otherwise.
[X] Added or updated documentation
[X] Tests for new functionality and regression tests for bug fixes
no tests available for the dev app
[X] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

This is my first contribution to Backstage, so please let me know if I missed anything.

Changeset added in f2d4136.


[Question] how to query on all replicas

Hi, Maybe someone can help me.
I have 4 nodes (2 shards with 2 replicas) and I want that my query execute on all node in each shard
max_parallel_replicas is useless

max_parallel_replicas works only for the tables created with SAMPLE.  ClickHouse server splits the query by sample section and executes part of the query on N (max_parallel_replicas) replicas.

From official help:
SELECT *
FROM system.settings
WHERE name = 'max_parallel_replicas'

Row 1:
──────
name:        max_parallel_replicas
value:       1
changed:     0
description: The maximum number of replicas of each shard used when the query is executed. For consistency (to get different parts of the same partition), this option only works for the specified sampling key. The lag of the replicas is not controlled.

Example: https://github.com/yandex/ClickHouse/blob/1acf404ed1d88efe4d9c87ee2a7728779f4b58a8/dbms/tests/queries/0_stateless/00124_shard_distributed_with_many_replicas.sql

Thank you!


Line aggregation

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Does it support aggregation function for connecting points

For example, the above image
When scaling the map, the lines and points can always support aggregation function, and currently, the lines will not change when scaling the map.
Describe the solution you'd like
A clear and concise description of what you want to happen.

Not sure if I understand you correctly, but it looks like what you want is scale the width of your lines according to the map resolution. This is possible, and just a matter of the style function configured for the Vector layer. What you can do is something like
const baseSize = 10;
const lineStyle = new Style({
  stroke: new Stroke({
    width: 1,
    color: '#bada55'
  })
});
new VectorLayer({
  // ...
  updateWhileAnimating: true,
  updateWhileInteracting: true,
  style(feature, resolution) {
    lineStyle.getStroke.setWidth(baseSize / resolution);
    return lineStyle;
  }
});

The baseSize depends on the desired line width and the resolution range your map's view is using.

Is there any other method? This method involves a process of thinning the lines when zooming the map. The effect I want is to hide the lines between the points when they are aggregated, and display the lines between them when the points are scattered. Similar to the following image
When points are scattered

When aggregating points

Thank you

const distance = 80;

    const mapInstance = new Map({
        view: new View({
            projection: "EPSG:4326",
            zoom: 10,
            center: [120.721941, 30.286334],
        }),
        controls: [],
        layers: []
    });

    const points = [
        new Point([120.721941, 30.286334]),
        new Point([120.710868, 30.399542]),
        new Point([120.710868, 30.566542])
    ];

    const cluster = new Cluster({
        distance,
        source: new VectorSource({
            features: points.map(point => new Feature({geometry: point}))
        })
    })

    const lineLayer = new VectorLayer({
        source: new VectorSource({
            features: [
                new Feature({
                    geometry: new LineString([
                        [120.721941, 30.286334],
                        [120.710868, 30.399542]
                    ]),
                }),
                new Feature({
                    geometry: new LineString([
                        [120.710868, 30.399542],
                        [120.710868, 30.566542],
                    ]),
                })
            ]
        }),
        style: (feature) => {
            const resolution = mapInstance.getView().getResolution() as number;

            const currLineString = feature.getGeometry() as LineString;

            const pixelsLength = currLineString.getLength() / resolution;

            // 如果线的起点终点都在聚合点上
            const clusterFeatures = cluster.getFeatures();

            const [startCoordinate, endCoordinate] = currLineString.getCoordinates();

            const hasStart = clusterFeatures.some((it) =>
                equals((it.getGeometry() as Point)?.getCoordinates(), startCoordinate))

            const hasEnd = clusterFeatures.some((it) =>
                equals((it.getGeometry() as Point)?.getCoordinates(), endCoordinate))

            if (pixelsLength > distance && hasStart && hasEnd) {
                return new Style({
                    stroke: new Stroke({
                        color: "rgba(255,0,255,0.8)",
                        width: 5,
                    }),
                })
            }
        }
    })
    mapInstance.addLayer(new VectorLayer({
        source: cluster,
        style: (feature) => {
            return feature.get('features').length > 1 ?
                new Style({
                    image: new CircleStyle({
                        radius: 8,
                        stroke: new Stroke({
                            color: "#fff",
                            width: 3,
                        }),
                        fill: new Fill({
                            color: "#00c2fd",
                        }),
                    }),
                })
                :
                new Style({
                    image: new CircleStyle({
                        radius: 8,
                        stroke: new Stroke({
                            color: "#fff",
                            width: 3,
                        }),
                        fill: new Fill({
                            color: "#ff0000",
                        }),
                    }),
                })
        },
    }))

    mapInstance.addLayer(lineLayer)

    mapInstance.setTarget(target);


Request support for Eightree ET20-4 smartplug with power consumption meter

Log Message

Logger: custom_components.tuya_local.device
Source: custom_components/tuya_local/device.py:624
Integration: Tuya Local ([documentation](https://github.com/make-all/tuya-local), [issues](https://github.com/make-all/tuya-local/issues))
First occurred: 12:27:42 (1 occurrences)
Last logged: 12:27:42

<class 'Exception'>: Unable to find device on network (specify IP address) while initialising device bf6708027bf8eeb550ecjn

Information about DPS mappings

{
  "result": {
    "model": "{\"modelId\":\"0000044fsm\",\"services\":[{\"actions\":[],\"code\":\"\",\"description\":\"\",\"events\":[],\"name\":\"默认服务\",\"properties\":[
{\"abilityId\":1,\"accessMode\":\"rw\",\"code\":\"switch_1\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_power\",\"attribute\":\"641\"},\"name\":\"开关1\",\"typeSpec\":{\"type\":\"bool\",\"typeDefaultValue\":false}},
{\"abilityId\":9,\"accessMode\":\"rw\",\"code\":\"countdown_1\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"开关1倒计时\",\"typeSpec\":{\"max\":86400,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"s\"}},
{\"abilityId\":17,\"accessMode\":\"ro\",\"code\":\"add_ele\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"增加电量\",\"typeSpec\":{\"max\":50000,\"min\":0,\"scale\":3,\"step\":100,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"kW·h\"}},
{\"abilityId\":18,\"accessMode\":\"ro\",\"code\":\"cur_current\",\"description\":\"\",\"extensions\":{\"attribute\":\"704\"},\"name\":\"当前电流\",\"typeSpec\":{\"max\":30000,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"mA\"}},
{\"abilityId\":19,\"accessMode\":\"ro\",\"code\":\"cur_power\",\"description\":\"\",\"extensions\":{\"attribute\":\"704\"},\"name\":\"当前功率\",\"typeSpec\":{\"max\":80000,\"min\":0,\"scale\":1,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"W\"}},
{\"abilityId\":20,\"accessMode\":\"ro\",\"code\":\"cur_voltage\",\"description\":\"\",\"extensions\":{\"attribute\":\"704\"},\"name\":\"当前电压\",\"typeSpec\":{\"max\":5000,\"min\":0,\"scale\":1,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0,\"unit\":\"V\"}},
{\"abilityId\":21,\"accessMode\":\"ro\",\"code\":\"test_bit\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"产测结果位\",\"typeSpec\":{\"max\":5,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0}},
{\"abilityId\":22,\"accessMode\":\"ro\",\"code\":\"voltage_coe\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"电压校准系数\",\"typeSpec\":{\"max\":100000000,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0}},
{\"abilityId\":23,\"accessMode\":\"ro\",\"code\":\"electric_coe\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"电流校准系数\",\"typeSpec\":{\"max\":100000000,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0}},
{\"abilityId\":24,\"accessMode\":\"ro\",\"code\":\"power_coe\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"功率校准系数\",\"typeSpec\":{\"max\":1000000000,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0}},
{\"abilityId\":25,\"accessMode\":\"ro\",\"code\":\"electricity_coe\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"电量校准系数\",\"typeSpec\":{\"max\":1000000,\"min\":0,\"scale\":0,\"step\":1,\"type\":\"value\",\"typeDefaultValue\":0}},
{\"abilityId\":26,\"accessMode\":\"ro\",\"code\":\"fault\",\"description\":\"\",\"extensions\":{\"attribute\":\"736\"},\"name\":\"故障告警\",\"typeSpec\":{\"label\":[\"ov_cr\",\"ov_vol\",\"ov_pwr\",\"ls_cr\",\"ls_vol\",\"ls_pow\"],\"maxlen\":6,\"type\":\"bitmap\",\"typeDefaultValue\":0}},
{\"abilityId\":38,\"accessMode\":\"rw\",\"code\":\"relay_status\",\"description\":\"\",\"extensions\":{\"attribute\":\"224\"},\"name\":\"上电状态设置\",\"typeSpec\":{\"range\":[\"off\",\"on\",\"memory\"],\"type\":\"enum\",\"typeDefaultValue\":\"off\"}},
{\"abilityId\":39,\"accessMode\":\"rw\",\"code\":\"light_mode\",\"description\":\"\",\"extensions\":{\"iconName\":\"tcl_function_light\",\"attribute\":\"224\"},\"name\":\"指示灯状态设置\",\"typeSpec\":{\"range\":[\"relay\",\"pos\",\"none\",\"on\"],\"type\":\"enum\",\"typeDefaultValue\":\"relay\"}},
{\"abilityId\":40,\"accessMode\":\"rw\",\"code\":\"child_lock\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-dp_power2\",\"attribute\":\"128\"},\"name\":\"童锁开关\",\"typeSpec\":{\"type\":\"bool\",\"typeDefaultValue\":false}},
{\"abilityId\":41,\"accessMode\":\"rw\",\"code\":\"cycle_time\",\"description\":\"\",\"extensions\":{\"attribute\":\"224\"},\"name\":\"循环定时\",\"typeSpec\":{\"maxlen\":255,\"type\":\"string\",\"typeDefaultValue\":\"\"}},
{\"abilityId\":42,\"accessMode\":\"rw\",\"code\":\"random_time\",\"description\":\"\",\"extensions\":{\"attribute\":\"224\"},\"name\":\"随机定时\",\"typeSpec\":{\"maxlen\":255,\"type\":\"string\",\"typeDefaultValue\":\"\"}},
{\"abilityId\":44,\"accessMode\":\"rw\",\"code\":\"switch_inching\",\"description\":\"/#1控制（bit0--开关，bit7-bit1---通道号）； /#2#3点动倒计时时间（s）；\",\"extensions\":{\"iconName\":\"icon-dp_power2\",\"attribute\":\"128\"},\"name\":\"点动开关\",\"typeSpec\":{\"maxlen\":255,\"type\":\"string\",\"typeDefaultValue\":\"\"}},
{\"abilityId\":46,\"accessMode\":\"rw\",\"code\":\"overcharge_switch\",\"description\":\"\",\"extensions\":{\"iconName\":\"icon-a_power\"},\"name\":\"过充保护\",\"typeSpec\":{\"type\":\"bool\",\"typeDefaultValue\":false}}]}]}"
  },
  "success": true,
  "t":<PHONE_NUMBER>744,
  "tid": "8115c23e4b2911eeb3f09e6a0abc163a"
}

Switch 1:
code: "1"
Test bit:
code: "21"
Fault:
code: "26"
Cycle time:
code: "41"
Random Time:
code: "42"
Add Electricity:
code: "17"
Electricity coe:
code: "25"
Current:
code: "18"
Current coe:
code: "23"
Power
code: "19"
Power coe:
code: "24"
Voltage
code: "20"
Voltage coe:
code: "22"
Relay Status:
code: "38"
Overcharge Switch
code: "46"
Light Mode:
code: "39"
Child Lock:
code: "40"
Count down 1:
code: "9"
Inching Switch:
code: "44"
Product ID

"product_id": "qiv5hllylfebpl4g"
Information about how the device functions

https://eightreesmart.com/products/eightree-mini-smart-wlan-steckdose-mit-alexa-google-home-nur-2-4ghz-wifi-4er-pack?variant=45409741275433

If you fix the connection issues per the log message, then I think you will find this is not an unsupported device.

The device is already mostly covered  (84% - light mode and child lock missing) by smartplugv2_energy.yaml.  Without a log message showing the actual reported dps I cannot take any further action.

As expected: Device matches smartplugv2_energy with quality of 84%. DPS: {"updated_at":<PHONE_NUMBER>.4263015, "1": false, "9": 0, "17": 1, "18": 0, "19": 0, "20": 2319, "21": 1, "22": 564, "23": 29114, "24": 15920, "25": 2620, "26": 0, "38": "memory", "39": "relay", "40": false, "41": "", "42": "", "44": "", "46": false}

But is not possible to add the device id to the "smartplugv2_energy" since most of the functionality is already implemented? I have 12 of this plugs and may be I'll buy more of them in the future, and maybe more people will too, and we all have to remember to set the IP the plug manually, when the auto detection is possible

Product ID is not actually used currently, so adding it is not high priority.
Auto detection is not relying on the product id, it is relying on broadcast messages from the device telling that it is there,  If other integrations such as localtuya are installed, they can intercept the broadcast messages before we see them, in that case setting the IP address will be necessary. Anyway, using Auto causes other issues due to the underlying tinytuya library not being asynchronous, as you can see from the log messages: "Please report issue to the custom integration author for tuya_local doing blocking calls at custom_components/tuya_local/device.py, line 73: parent=tinytuya.Device(dev_id, address, local_key)".

if the Product ID is not important I don't get so, why after creating the new file with my own implementation immediately detected all plugs without setting anything else.
I don't have localtuya installed in my HA, since I came up here because a "youtuber" recommendation. Because of him I could add my implementation (is my first introduction in HA).
If you think this device is not that important, that's not a problem for me, I will keep my implementation. I've just wanted to share the implementation to the community

It is a bit strange that your config works, as the type of dp 40 and 46 do not match the Query Things Data Model information, or the device log, which are both boolean, but in your config you have string.

It is possible that the "force: true" in the smartplugv2_energy config was forcing your plugs offline when configured with that.
Forced polling seems to cause problems for a number of devices, and since smartplugv2_energy just has a couple of unimportant config options and the calibration values as attributes additional compared to smartplugv2, users that require it can probably use smartplugv2_polled instead. So I have removed that from this config.

Thanks for reconsider adding the device


Incorrect location to find the 'deploy' option

The text of the article says:

To deploy a solution using a pipeline, go to Solutions and create or select an unmanaged solution to deploy.
From the Solutions area, choose between two options to include the solution in the pipeline:

Select Pipelines from the left navigation pane.
Select Overview from the left navigation pane, and then select Deploy on the command bar.

However, you actually have to select INTO the solution and then options on the left navigation and on the command bar are available.
Recommend change:

To deploy a solution using a pipeline, go to Solutions and click to open the solution you wish to deploy.
From the solution page, choose between two options to include the solution in the pipeline:

Select Pipelines from the left navigation pane.
Select Overview from the left navigation pane, and then select Deploy on the command bar.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 12d10eee-0a8f-834e-3f8c-8eda0e6653e6
Version Independent ID: 12d10eee-0a8f-834e-3f8c-8eda0e6653e6
Content: Run a pipeline - Power Platform
Content Source: power-platform/alm/run-pipeline.md
Service: powerapps
Sub-service: alm
GitHub Login: @caburk
Microsoft Alias: matp

Thanks for your comment, @briangre. This issue has been assigned to the doc author for review.


Add parameters to allow hiding icons and border of the Cupertino TabBar

This PR introduces two new parameters for the CupertinoTabBar.

onlyIcons which enables only-icons mode by hiding title of all the items
hideBorder - if true hides the top border of the tab bar.

Thanks for your contribution. Thanks so much for adding tests as well!
I have 2 general design level feedback if you're willing to iterate on this PR a bit more:

Instead of a specific feature to hide the borders, just let there be a default Border as a construction parameter but that lets the user override it.
We should fix the optional title issue higher up the stream. Let BottomNavigationBarItem.title be nullable and assert it to be non-null in the Material BottomNavigationBar's constructor (since Material spec doesn't allow un-labeled tabs).

@xster Reasonable and great points. Will do that!

@xster Ready to review again 📃

Thank you for your review. Fixed (hopefully) almost all things you mentioned. Although files formatting is getting out of hands... kinda 😖 It does weird things. Tried using the built one into VSC and it does the same thing as flutter format.

Ah, that auto formatter... Gotta pay more attention to that. Improved the test as well as you suggested.

@xster Reverted that auto-format changes.

Thanks, merging


keymaster_lock_state_changed event not being fired when unlocking via code

Describe the bug
keymaster_lock_state_changed event not being fired when unlocking Schlage lock via pin code.  The event does fire correctly when I manually unlock via the knob, and also when I send a zwave request to unlock, just not when unlocking with a code.
Environment (please complete the following information):

OS: HassOS
VMWare ESXi Virtual Machine
Home Assistant version: 2023.6.2
Hassio
Component version: Keymaster v. 0.0.85
Z-Wave integration name: Z-Wave JS UI v. 1.14.0
Lock make and model: Schlage BE469BP

Logs
Here is my ZWave JS UI event log when unlocking via a pin code:
2023-07-13T14:22:12.376Z - VALUE UPDATED
Arg 0:
└─commandClassName: Door Lock
└─commandClass: 98
└─property: currentMode
└─endpoint: 0
└─newValue: 0
└─prevValue: 255
└─propertyName: currentMode
2023-07-13T14:22:12.379Z - VALUE UPDATED
Arg 0:
└─commandClassName: Door Lock
└─commandClass: 98
└─property: outsideHandlesCanOpenDoor
└─endpoint: 0
└─newValue: false, false, false, false
└─prevValue: false, false, false, false
└─propertyName: outsideHandlesCanOpenDoor
2023-07-13T14:22:12.380Z - VALUE UPDATED
Arg 0:
└─commandClassName: Door Lock
└─commandClass: 98
└─property: insideHandlesCanOpenDoor
└─endpoint: 0
└─newValue: false, false, false, false
└─prevValue: false, false, false, false
└─propertyName: insideHandlesCanOpenDoor
2023-07-13T14:22:12.381Z - VALUE UPDATED
Arg 0:
└─commandClassName: Door Lock
└─commandClass: 98
└─property: doorStatus
└─endpoint: 0
└─newValue: open
└─prevValue: open
└─propertyName: doorStatus
2023-07-13T14:22:12.382Z - VALUE UPDATED
Arg 0:
└─commandClassName: Door Lock
└─commandClass: 98
└─property: boltStatus
└─endpoint: 0
└─newValue: unlocked
└─prevValue: locked
└─propertyName: boltStatus
2023-07-13T14:22:12.383Z - VALUE UPDATED
Arg 0:
└─commandClassName: Door Lock
└─commandClass: 98
└─property: latchStatus
└─endpoint: 0
└─newValue: open
└─prevValue: open
└─propertyName: latchStatus

Your logs there mean nothing, you need to use the event listener in HA to see what's being broadcast by zwavejs.

No event shows up when I do that.  That's why I shared the logs that I did, to show that it was at least being picked up by ZWave JS.  Events for locking the door, unlocking using the knob, and unlocking via zwave call do register.

Listening for that event did not result in anything either.  I saw the event where I locked the door using the keypad, and manually locked the door back with the knob after coming inside, but not when I unlocked the door via a code.
event_type: zwave_js_notification
data:
  domain: zwave_js
  node_id: 8
  home_id:<PHONE_NUMBER>
  device_id: 7310cdefda3d23440705a5f4e14912fb
  command_class: 113
  command_class_name: Notification
  label: Access Control
  type: 6
  event: 5
  event_label: Keypad lock operation
  parameters: {}
origin: LOCAL
time_fired: "2023-07-13T18:23:57.965745+00:00"
context:
  id: 01H587XPGDA2VFDGYCB2DTTVFW
  parent_id: null
  user_id: null

event_type: zwave_js_notification
data:
  domain: zwave_js
  node_id: 8
  home_id:<PHONE_NUMBER>
  device_id: 7310cdefda3d23440705a5f4e14912fb
  command_class: 113
  command_class_name: Notification
  label: Access Control
  type: 6
  event: 1
  event_label: Manual lock operation
  parameters: {}
origin: LOCAL
time_fired: "2023-07-13T18:24:24.617171+00:00"
context:
  id: 01H587YGH9TACD8EQXEWW9A6JY
  parent_id: null
  user_id: null

Oddly enough, it does get triggered when I use the code stored in slot 2, but does NOT when using the code stored in slot 1

The issue you are experiencing is either going to be with zwavejs or the hardware itself.

Oddly enough, it does get triggered when I use the code stored in slot 2, but does NOT when using the code stored in slot 1
Edit: Disregard the above statement. I got it to trigger 1 time after multiple attempts. I have tried a few more times with the code in slot 2 and it is not working.

I had a similar situation and Z-wave JS had to be cleared of the current codes. Once I did that I was able to set/use them again.

This issue just started happening to me 4 days ago now


Future Request - New badges data in inventory

Description
I did PR https://github.com/PokemonGoF/PokemonGo-Web/pull/130 which adds new badges. Now we need info for this badges in player inventory. Badges data that we need to add to inventory:

Kanto - now this is summary of all unique pokemons in pokedex. Should be only for Kanto region pokemons. Can be done by Kanto=Kanto-Johto.
Johto
Gym Leader
Berry Master
Champion
Legendary Pokemon
Unown - i'm not sure if this data is already in inventory.

https://github.com/PokemonGoF/PokemonGo-Web/pull/130
Closed


Using docker with scripts/dist_train.sh

Hi, I just installed OpenPCDet with docker which is incredibly convenient!!!
But when I run with scripts/dist_train.sh, there is an error occurred launch.py: error: unrecognized arguments: --rdzv_endpoint=localhost:xxxxx
I think it's the problem of pytorch version (1.6.0)...

Just simply remove --rdzv_endpoint=localhost:xxxxx would work

Great, thank you for your fast response


toc update

@matthidinger,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/create/libraries/NET.md
:white_check_mark:Succeeded

AdaptiveCards/create/libraries/Typescript.md
:white_check_mark:Succeeded

AdaptiveCards/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Updated validations.py

Fixed the behaviour of the function
Closes #1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Vulnerability : Tesseract module using libwebp-7.dll which is vulnerable.

Current Behavior
Please refer to the CVE :https://nvd.nist.gov/vuln/detail/CVE-2023-4863#range-9603412
Expected Behavior
No response
Suggested Fix
No response
tesseract -v
No response
Operating System
No response
Other Operating System
No response
uname -a
No response
Compiler
No response
CPU
No response
Virtualization / Containers
No response
Other Information
No response

This is not an issue for the official Tesseract code because that code nowhere refers to libwebp-7.dll.

libwebp-7.dll is distributed by Mingw-64. Please check whether that library is really affected by that CVE (and not already patched with a fix).

I am referring to the installation of pre-built binaries that is packaged in this : https://github.com/UB-Mannheim/tesseract/wiki has libwebp-7.dll. what's the libwebp base version of https://developers.google.com/speed/webp/download ?

Also the libwebp-7.dll is based on 1.3.0.
I see there are new changes which are made to this by mingw64 https://github.com/msys2/MINGW-packages/commit/84da8efa6c57695246ed7afe0466eb5e7753c646

That's right. The installer was made before that. The next installer will get those msys2 changes.

Thanks for the confirmation. Can you please confirm when is the next release?

@Cv-securityIQ,

I am referring to the installation of pre-built binaries that is packaged in this : https://github.com/UB-Mannheim/tesseract/wiki

Please report about issues related to a specific binary distribution directly in the distributor's  issue tracker.


Feature request: finalize() and closing

For things that are Closeable, can I request that you also override finalize() to emit an error message if the thing is not closed when it gets finalized?
I've found this useful in other libraries to help catch bugs a little quicker.

 I need to research this, but my understanding is that the GC needs to keep a queue of finalizers.

I originally wondered if the log line was there for the PathChildrenCache, i.e. an object that is created once and not thrown away lightly.  I think it's fine to do this for most Closeable things as they generally entail a certain amount of IO overhead and whatnot that is going to dwarf any extra bookkeeping that the VM has to do (and they generally aren't created that often).  Some examples of things with a finalize method are FileInputStream as well as PlainSocketImpl.
While I agree that adding a finalizer to a String or some other ephemeral, memory-only data structure would not be a good idea, adding it to something with a close() method (implying that there are some resources that need to be cleaned up when you are done) doesn't seem like such a bad idea (especially when it is solely to log out that the object is getting GC'd without close() getting called.)

If only Java had #ifdefs ;) I'll think about this but am inclined not to add it. I've had bad experience with finalizers before.


Networks being deleted, server wide.

Upon a server restart or crash all the flux networks are removed, and you have to reset every single one of the flux plugs etc back to a network by re-creating the network and re-assigning each plug to that network.
Fluxnetworks 1.12.2 version 3.0.8

Found out why, the modpack creator has used an out-dated version and this is fixed in the next release.


Datepicker 0.13.0 - throws date error on textbox change with Angular 1.3.5 stable

I tried to implement the new angular ui bootstrap with angular 1.3.5 stable.
Here's a plunker demo:
http://plnkr.co/edit/6jWsI4nk6hyjh2l6O5Pd?p=preview
when I change the year of second date, which is generated by new Date(), everything updates accordingly.
But when i change the year of first date, which is generated by new Date(1430229600000), it throws an error unless I manually select another date from the datepicker.
Datepicker directive: "ng-model" value must be a Date object, a number of milliseconds since 01.01.1970 or a string representing an RFC2822 or ISO 8601 date.
After selecting another date from the datepicker, it behaves like the second date with no errors.

What is the error message you're seeing?
I don't see an error message when I change the year by replacing 2015 with 2016 on the first date .

Datepicker directive: "ng-model" value must be a Date object, a number of milliseconds since 01.01.1970 or a string representing an RFC2822 or ISO 8601 date.

Ah, I see. This is related to #3294 .
Actually, new Date('28/04/201') fails because 28 cannot be the value of the months field (in US date locale). new Date('03/05/201') parses but actually fails, because it's interpreting 03 as the months.
This is a known issue, I believe we intend to break this behavior soon. When we merge in #3294, the ng-model should get null when the format is invalid. In this case, the format is invalid because the yyyy is not satisfied, there should be 4 digits in the year and the model should not parse.

@chrisirhc
Hi Chris,
the date format is correct as I'm using Australian date locale (dd/MM/yyyy) in the demo.
so new Date('28/04/201') is actually 28-April-201
try deleting the last 2 digits of 2015 and putting 01 after it
then you'll see the js error on the first date but not the second date as the second date converts the year.
and after trying a few different date formats from the dropdown, it looks like datepicker will fail to parse any formats that end with 'yyyy'
Please look into it.
Thanks

Yes, it works only because you're in Australia. This behavior shouldn't be relied upon because it will not work, in say, USA where the locale is different. I think the failure to parse is actually the correct behavior as it's more expected and reliable. However, it shouldn't throw that error in the console. It should just set the ng-model to null. We'll fix that soon once that PR is merged.

Hi Chris,
Just want to make sure that I understand the fix.
When I try to change the date value 28/04/2015 to 28/04/2005, I select 15 then start typing the first letter 0.
Then datepicker will failed to parse the value and fail.
What do I see in the text box?

Do I see 28/04/200? (After I type the other letter 5, will it pass the date parse and work again?)
OR
Do I see the text box value get empty as ng-model is set to null?

You should see 28/04/200 in text box and typing 5, it'll pass the date parsing. That's the intended behavior, but it might be broken. See #3736


Nix

Hi @StefanosChaliasos . This appears to be working as intended on Intel Linux. I don't have an M1 Mac to test this on, so your help on that end of things would be appreciated. Also, are there any facilities for graphical display of the benchmarks which I should look into Nixing?

This still does not work using Nix on Mac. If I change it to /usr/bin/time and run it through Nix, then it works.
So, it turns out that Nix uses a GNU version of time:
[nix-develop-zk-Harness:] /usr/bin/env which time
/nix/store/crjc924qn35syvq9z0bsnkq2m8m97wzb-time-1.9/bin/time
[nix-develop-zk-Harness:] which /usr/bin/time
/usr/bin/time

Can you check this commit, and if you agree with that, include it in this PR?

Thanks, @morganthomas, this one LGTM. Could you please fix the conflicts, and then it's ready to merge.


integrate frank's changes from smhasher3 downstream

https://gitlab.com/fwojcik/smhasher3
frank always has excellent notes on code and iirc he's made some changes that are substantial and fantastic for the hashes here

Closed in latest!


Double-check you're using the right language

As mentioned in https://github.com/whatwg/html/issues/7757, many other specs that need a default language use the document's language rather than the user's language. Since the font name is expected to be presented inside the document, it might work better if this spec switches to the document's language.
However, it's not obvious what to do inside of a Worker if we want to default to the document's language.

Thanks for filing this. This is additionally challenging in that apparently many OS APIs for enumeration don't provide all the strings and let the caller decide which localization to use; instead they only return data for the "current locale".
I haven't checked whether this means current browsers are not conforming per https://www.w3.org/TR/css-fonts-4/#local-font-fallback or not - User agents that also match other full font names, e.g. matching the Dutch name when the current system locale is set to Dutch, are considered non-conformant. - I suspect (but don't know!) that all browsers are non-conformant, and therefore the spec text is aspirational.
Given that, I don't know whether it's best to (1) describe the unpleasant reality here, (2) describe the aspirational state, and declare reality non-conforming, or (3) leave it ambiguous and hope no-one notices...

Maybe describe the aspiration as a SHOULD, and also say implementations MAY obey reality?
I didn't see a test for the css-fonts-4 line in wpt.fyi, but I might have missed the right search term. It's probably worth filing a bug with them to at least test their aspirational claim ... although that might require some difficult changes to the web-platform-tests machine setup. https://github.com/w3c/csswg-drafts/issues/3177 is related, but seems to be about clarifying the aspiration rather than writing a test for it.


Unable to find package Samboy063.Cpp2IL.Core

Error NU1102 : Unable to find package Samboy063.Cpp2IL.Core with version (>= 2022.1.0-development.866)
  - Found 34 version(s) in nuget.org [ Nearest version: 2<IP_ADDRESS> ]
  - Found 0 version(s) in https://nuget.bepinex.dev/v3/index.json

Steps to reproduce:
Install template: dotnet new bep6plugin_unity_il2cpp -n TestMod
Restore NuGet packages

Does this still happen on the latest release?


investigate: rabbitmq image needs update?

Package version (if known): october release
Describe the bug
From astrowq:

I got an error while trying to run an Invenio RDM instance:

ERROR: for invenio-rdm-demo_mq_1  Cannot start service mq: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: "docker-entrypoint.sh": executable file not found in $PATH": unknown

Aftering investigating and looking up for quite some time, I found it was caused by the image used here i.e. rabbitmq:3-management. It is having a bug in it and the above error went away if I chose to use another tag e.g. rabbitmq:3.8-management

Investigate if this was a one time occurrence or if the rabbitmq image needs to be updated.

Tasks for February iteration:

Upgrade image to 3.8-management

Looks like there are no breaking changes: https://www.rabbitmq.com/changelog.html


Improve documentation of Trial.should_prune

The documentation of Trial.should_prune was not precisely consistent after the deprecation of the step argument and could use some clarifications as well regarding how the pruning suggestion is made, i.e. that it depends on previously reported values. This PR addresses these points.
It was brought to discussion in this PR/comment https://github.com/pfnet/optuna/pull/660#discussion_r345104564.

Thanks for the screenshot. I actually verified this locally as well and though that it looked just fine 😄


Predefine Values for Max Integer, Max Long, Infinity, etc

The following application.conf entry appears to be a magic value:
play.http.parser.maxMemoryBuffer=2147483647

... when I'm just specifying the largest possible integer. It would be great to have this predefined as a value:
play.http.parser.maxMemoryBuffer=MaxInt

... or whatever syntax makes the most sense
play.http.parser.maxMemoryBuffer=Integer.maxValue

The way I'd probably do this is to have a reference.conf containing something like:
Constants {
  MaxInt =<PHONE_NUMBER>
}

or whatever you want to call it, and then reference these as ${Constants.MaxInt} etc.
Maybe a good starting point would be for someone to put this together as a single .conf file that anyone can drop in their project. Maybe it should come with the library, would have to think about that more.

Or even:
Integer.MaxValue =<PHONE_NUMBER>
Long.MaxValue = …
And use: ${Integer.MaxValue} :-)
On Wed, May 27, 2015 at 3:49 PM, Havoc Pennington<EMAIL_ADDRESS>wrote:

The way I'd probably do this is to have a reference.conf containing
something like:
Constants {
MaxInt =<PHONE_NUMBER>
}
or whatever you want to call it, and then reference these as
${Constants.MaxInt} etc.
Maybe a good starting point would be for someone to put this together as a
single .conf file that anyone can drop in their project. Maybe it should
come with the library, would have to think about that more.
—
Reply to this email directly or view it on GitHub
https://github.com/typesafehub/config/issues/323#issuecomment-105917974.

--
Cheers,
√

Integer.MaxValue would be more familiar to programmers, but there might be potential confusion with the Scala predefined constant Int.MaxValue or the Java predefined constant Integer.MAX_VALUE. One solution might be to define equivalent constants called Int.MaxValue and Integer.MAX_VALUE.

This looks like falls into a category of concerns not of this library but of a project that uses this library. Mainly because constants such as infinity, unlimited might have different representation value depending on the context.

Int.MaxValue is defined in the SLS. The constants I mentioned are not application-dependent, or hardware-dependent, thus are not context-dependent.

They're language-dependent, though.

Actually, they are JVM dependent. These are constants in most languages. Why not make them available?

I think @havocp's solution is pretty neat – and requires no support from the library.
Note that some libs care about scala.js etc and some not, best leave defining such constants to end libraries / users IMHO.


Problem with serializers and their MemoryStreams

Serializers (well, json one) use internally MemoryStream and I don't think MemoryStream ever shrink their buffers. They just grow them by factor of 2 when required. And serializers are being reused (along with their buffers).
Hence, there is a possibility of using a large chunk of memory and never releasing it - if at some point in time on serializes a huge object.
One possible solution would be to create a new MemoryStream instance each time, but then there could be a lot of GC going on with all those buffers being released.
A better option would be to use RecyclableMemoryStream

Hi @MihaMarkic
Thank you for bringing this up.
Design wise, we made a mistake early on we're planning to correct for a future major version.
The ISerializationWriter interface should not have a GetSerializedContent method. And RequestInformation's body shuold instead be a reference to a callback/function that accepts a writeable stream.
This way the request adapter could call the callback and have the stream being written directly to the network (through the buffer offered by the APIs), reducing copies and memory pressure.
In the meantime, if you observe high memory pressure effects, replacing MemoryStream by recyclable ones should reduce those effects. I believe the place that'd benefit the most from such a change is probably the Json serialization writer
Besides memory pressure, you should not be seeing unclosed Memory streams unless the client application is doing something wrong or unless we missed out something. If you see those, please trace them and point them to us.

@baywet That's even better, indeed. And no, I'm just thinking out loud, don't have such issues ATM.

Would you still be willing to submit a PR in the json serialization repo, and back it up with benchmarks (just for serialization)?
I suspect the reduced memory assignment/garbage collection should yield performance benefits.

@baywet You mean a variant with RecyclableMemoryStream?

I meant for the json serialization writer:

make the changes in a local copy
setup a benchmark project, referencing both the local copy and the published version (you might have to temporary change the namespace of the local copy to avoid conflicts)
run the benchmark, see if we're getting better perf for the changes.

Does that make sense?


APIv2: No events when deleting image

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
When I listen on events through APIv2 and delete image I don't get any event for it. I get it later on when I do some other action, that triggers some event. It feels like events are not flushed/sent, but are only queued.
Steps to reproduce the issue:

sudo curl --unix-socket /run/podman/podman.sock http://d/v1.24/events listen on events
sudo podman run -dit fedora bash
sudo podman rmi -f eb7134a03cd6 (eb7134a03cd6 is the fedora image that was used in ^)

Describe the results you received:
Checking events (step 1. was running the whole time) I don't see any about the image being removed, just about the container being stopped (but not removed).
{"Type":"image","Action":"pull","Actor":{"ID":"","Attributes":{"containerExitCode":"0","image":"","name":""}},"scope":"local","time":1592472737,"timeNano":1592472737248919025}
{"Type":"container","Action":"create","Actor":{"ID":"5f22309892b25090082bb6db24ad937820e6838b813c6453cae87ee299af4ed2","Attributes":{"containerExitCode":"0","image":"registry.fedoraproject.org/fedora:latest","name":"keen_pike"}},"scope":"local","time":1592472737,"timeNano":1592472737274347288}
{"Type":"container","Action":"init","Actor":{"ID":"5f22309892b25090082bb6db24ad937820e6838b813c6453cae87ee299af4ed2","Attributes":{"containerExitCode":"0","image":"registry.fedoraproject.org/fedora:latest","name":"keen_pike"}},"scope":"local","time":1592472737,"timeNano":1592472737698748338}

---------- Now I run step 3. ------------------

{"Type":"container","Action":"start","Actor":{"ID":"5f22309892b25090082bb6db24ad937820e6838b813c6453cae87ee299af4ed2","Attributes":{"containerExitCode":"0","image":"registry.fedoraproject.org/fedora:latest","name":"keen_pike"}},"scope":"local","time":1592472737,"timeNano":1592472737752666694}
{"Type":"container","Action":"stop","Actor":{"ID":"5f22309892b25090082bb6db24ad937820e6838b813c6453cae87ee299af4ed2","Attributes":{"containerExitCode":"0","image":"registry.fedoraproject.org/fedora:latest","name":"keen_pike"}},"scope":"local","time":1592472775,"timeNano":1592472775559431606}
{"Type":"container","Action":"died","Actor":{"ID":"5f22309892b25090082bb6db24ad937820e6838b813c6453cae87ee299af4ed2","Attributes":{"containerExitCode":"0","image":"registry.fedoraproject.org/fedora:latest","name":"keen_pike"}},"scope":"local","time":1592472775,"timeNano":1592472775589530005}

I get the following two messages when I do some other action (like sudo podman pull fedora):
{"Type":"container","Action":"remove","Actor":{"ID":"5f22309892b25090082bb6db24ad937820e6838b813c6453cae87ee299af4ed2","Attributes":{"containerExitCode":"0","image":"registry.fedoraproject.org/fedora:latest","name":"keen_pike"}},"scope":"local","time":1592472775,"timeNano":1592472775825801453}
{"Type":"image","Action":"remove","Actor":{"ID":"eb7134a03cd6bd8a3de99c16cf174d66ad2d93724bac3307795efcd8aaf914c5","Attributes":{"containerExitCode":"0","image":"","name":"registry.fedoraproject.org/fedora:latest"}},"scope":"local","time":1592472776,"timeNano":1592472776034254461}

Describe the results you expected:
I would get all events the first time.
Output of podman version:
Version:      2.0.0-rc6
API Version:  1
Go Version:   go1.14.3
Built:        Thu Jan  1 01:00:00 1970
OS/Arch:      linux/amd64

Output of podman info --debug:
host:
  arch: amd64
  buildahVersion: 1.15.0-dev
  cgroupVersion: v2
  conmon:
    package: conmon-2.0.17-1.fc32.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.17, commit: bb8e273f5925c1a51737644637ef65d094a67ab1'
  cpus: 4
  distribution:
    distribution: fedora
    version: "32"
  eventLogger: file
  hostname: zahlmaschine
  idMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 1935008
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 1935008
      size: 65536
  kernel: 5.6.11-300.fc32.x86_64
  linkmode: dynamic
  memFree: 391274496
  memTotal:<PHONE_NUMBER>2
  ociRuntime:
    name: crun
    package: crun-0.13-2.fc32.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.13
      commit: e79e4de4ac16da0ce48777afb72c6241de870525
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  os: linux
  remoteSocket:
    exists: true
    path: /run/user/1000/podman/podman.sock
  rootless: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: slirp4netns-1.0.0-1.fc32.x86_64
    version: |-
      slirp4netns version 1.0.0
      commit: a3be729152a33e692cd28b52f664defbf2e7810a
      libslirp: 4.2.0
  swapFree: 0
  swapTotal: 0
  uptime: 72h 9m 48.16s (Approximately 3.00 days)
registries:
  search:
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - docker.io
store:
  configFile: /home/mmarusak/.config/containers/storage.conf
  containerStore:
    number: 24
    paused: 0
    running: 0
    stopped: 24
  graphDriverName: overlay
  graphOptions:
    overlay.mount_program:
      Executable: /usr/bin/fuse-overlayfs
      Package: fuse-overlayfs-1.0.0-1.fc32.x86_64
      Version: |-
        fusermount3 version: 3.9.1
        fuse-overlayfs: version 1.0.0
        FUSE library version 3.9.1
        using FUSE kernel interface version 7.31
  graphRoot: /home/mmarusak/.local/share/containers/storage
  graphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  imageStore:
    number: 3
  runRoot: /run/user/1000
  volumePath: /home/mmarusak/.local/share/containers/storage/volumes
version:
  APIVersion: 1
  Built: 0
  BuiltTime: Thu Jan  1 01:00:00 1970
  GitCommit: ""
  GoVersion: go1.14.3
  OsArch: linux/amd64
  Version: 2.0.0-rc6

Package info (e.g. output of rpm -q podman or apt list podman):
podman-2.0.0-0.2.rc6.fc32.x86_64

Possibly reproducible when more then one listener is active.

sudo curl --unix-socket /run/podman/podman.sock http://d/v1.24/events in one terminal
sudo curl --unix-socket /run/podman/podman.sock http://d/v1.24/events in second terminal
sudo curl --unix-socket /run/podman/podman.sock http://d/v1.24/events in third terminal

Do steps 2 and 3 and then one terminal gets all events, but others don't.


Fix L3 Logic in K.1 #3

Align the L3 with how the logic is written in the L2. Our L3 currently looks for the two most recent cytology results. Really we should be looking for a 2-year follow-up cytology that happened after an initial cytology, which would have been three tests ago.
We should look into restructuring this logic so that it looks forward from that initial cytology instead of looking back from today.

This was fixed in PR https://github.com/ccsm-cds-tools/ccsm-cds-with-tests/pull/23. Thanks @ptran265!


Crate-level documentation.

Codecov Report

Merging #92 (8dbb3f6) into master (976b258) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   95.04%   95.04%
=======================================
  Files          57       57
  Lines        9215     9215
=======================================
  Hits         8758     8758
  Misses        457      457

Impacted Files
Coverage Δ

src/lib.rs
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Created a slideshow using the bootstrap carousel

Thank you for your contribution !! keep contributing :heart:

Thank you! I would certainly like to contribute to the other issues as well if that's okay.

Thank you! I would certainly like to contribute to the other issues as well if that's okay.

Please go ahead and keep contributing,  we will be very happy to see your PRs 😃

Thank you!


Make GRXWriteable with single handler robust against streaming Writers

This maintains the invariant that the passed block is always called, and only called once.
CC @ctiller @jtattermusch

LGTM

sanity test fails
src/objective-c/RxLibrary/GRXWriteable.m modified 2016 but copyright only extends to 2015


PackageUris information from kernel file

The URI VM reads from kernel (KernelReaderHelper::SourceTableUriFor) is
file:///usr/local/google/home/zichangguo/dart-sdk/sdk/Junk/breakpoint_test/lib/all_scripts.dart
file:///usr/local/google/home/zichangguo/dart-sdk/sdk/Junk/breakpoint_test/lib/src/func.dart.
However, the URI requested from VS code debugger is:
package:breakpoint_test/src/func.dart
package:breakpoint_test/all_scripts.dart
This causes the mismatch for breakpoint setting. I think it would be helpful for frontend team to provide both package:breakpoint_test/src/func.dart and file:///usr/local/google/home/zichangguo/dart-sdk/sdk/Junk/breakpoint_test/lib/src/func.dart for all the scripts.
This is blocking issue #35859

Bumping priority to P1 as not having access to the fully resolved URI is causing quite a few headaches for finding sources for dart:* libraries. For example, sources in dart:* libraries can be found in all sorts of places including:

sdk/lib/$LIBRARY_NAME/
runtime/bin
runtime/lib

This would be fine if all the sources for a library 'dart:x' were in directory sdk/lib/x or one of the runtime directories, since then it would be possible to simply chop the dart:x part of the script path off and then use a substring comparison to find the correct script. However, there's special cases where this approach won't work which will require even more hacks in the VM to deal with.

@kmillikin, can this work be made a priority?
cc @a-siva

Friendly ping @kmillikin. This is blocking fixes for multiple issues. Can we prioritize this change?

Bumping priority to P1 as not having access to the fully resolved URI is causing quite a few headaches for finding sources for dart:* libraries. For example, sources in dart:* libraries can be found in all sorts of places including:

sdk/lib/$LIBRARY_NAME/
runtime/bin
runtime/lib

This would be fine if all the sources for a library 'dart:x' were in directory sdk/lib/x or one of the runtime directories, since then it would be possible to simply chop the dart:x part of the script path off and then use a substring comparison to find the correct script. However, there's special cases where this approach won't work which will require even more hacks in the VM to deal with.

I don't understand how this is relevant to issue about PackageUris?
Also, you have the resolved URI already (although it is something like org-dartlang-sdk:///sdk/lib/async/future.dart (but that's basically relative to a dir as specified in runtime/vm/BUILD.gn)) - the problem here as I understand it is that for some things (parts) you don't have the the import uri.
Please enlighten me if I'm wrong.
Also the kernel format is currently "semi-locked-down" so I'm not sure we can actually make a change to include the import uri for every source at the moment. @a-siva  @alexmarkov  may know more about how locked down the format is though.
That being said, I'll try looking at actually gathering the information so the frontend can provide it.

Also the kernel format is currently "semi-locked-down" so I'm not sure we can actually make a change to include the import uri for every source at the moment. @a-siva @alexmarkov may know more about how locked down the format is though.
That being said, I'll try looking at actually gathering the information so the frontend can provide it.

Actually I think I can come around that. As I (now) understand a new VM should just be able to read both old and new dill files. I can work with that.

Can this issue be closed (#35859, e9e0daee5c9eb89b58ded0b8e087612f23b9a6fd, 58882ffdd49afdfb53c7be15361340bb64760fe4, 9f00d1b3849b03b2c9cc745d937da4693b5222fe)?

I've confirmed #35859 is now fixed, though I'm not sure if the changes made satisfy what @bkonyi needed above, so probably this is a question for him now.
Thanks!

Let's close this issue. If something else comes up I'll reopen and let you know. Thanks!


Configure forking context with conf file

Currently forking can be disabled with environment variable FLO_FORKING=false.
I would be great to have this configuration in typesafe config, like defining something in reference.conf:
flo.forkingEnabled=true
flo.forkingEnalbed=${?FLO_FORKING_ENABLED}

How about also disabling it by default? Seems to be the cause of a number of bugs lately: #100 #101 #102.
Object serialization and JVM forking is tricky, so we should let ForkingContext accumulate some mileage before being enabled by default.

Merged #104 now. Seems it missed 0.2.11 though.

This has been released. Closing.


filetransfer: locally create ACH files

TODO

Codecov Report

Merging #481 into master will decrease coverage by 5.72%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   58.32%   52.59%   -5.73%
==========================================
  Files         114      110       -4
  Lines        8453     7978     -475
==========================================
- Hits         4930     4196     -734
- Misses       2782     3169     +387
+ Partials      741      613     -128

Impacted Files
Coverage Δ

cmd/server/main.go
15.85% <0.00%> (-0.82%)
:arrow_down:

internal/achx/files.go
67.07% <ø> (ø)

internal/depository/router.go
56.33% <ø> (-2.11%)
:arrow_down:

internal/transfers/mock_transfer_repo.go
15.25% <0.00%> (-6.78%)
:arrow_down:

internal/filetransfer/files.go
43.75% <40.47%> (-22.92%)
:arrow_down:

internal/transfers/files.go
68.33% <51.42%> (-5.67%)
:arrow_down:

internal/filetransfer/outgoing.go
48.31% <57.14%> (-3.57%)
:arrow_down:

...nal/depository/verification/microdeposit/router.go
56.39% <75.00%> (-6.58%)
:arrow_down:

internal/transfers/transfers.go
60.34% <83.33%> (+1.56%)
:arrow_up:

internal/transfers/test_router.go
96.00% <96.00%> (ø)

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d346fdb...f6b7c08. Read the comment docs.


[feature] Revamp moment, locale bundling

OK, so ever since the ES Modules came around and the JS packagers were updated to fit the situation for moment became unbearable.
The biggest offender is the logic that automatically requires locales, which is supposed to work only on node.js (at least that was how it was conceived), where all files are local and it is a cheap operation.
So here is an overview of how I thing this problem can be solved going forward.

moment locales should be "independent" of moment. They should be a collections of data and code (functions) that do not directly depend (read, require/import) on moment.  Thus, using standalone locales, one has to first aquire the locale data somehow, and then give it to moment, which will then register this locale:

var de = require('moment/locale-data/de'); // or through some other means
moment.defineLocale(de); // now moment "learns" de
moment.locale('de'); // ok, now we can switch to 'de', because we know it
moment.locale('fr'); // nope, we don't know what 'fr' is (yet) -- throw exception

to make the situation more palatable we can have plugins/helpers that help with loading locales in the appropriate way for different environments, but hey should be strictly per-environment/use case, and not part of moment core.

// for node.js
var moment = require('moment');
var momentLocaleNode = require('moment-locale-node');
momentLocaleNode.setup(moment); // hook auto-locale loading for node.js
moment.locale('de'); // this loads the 'de' locale data via require, in a nodejs (or similar) env
moment.locale('deee'); // this throws an exception because the 'deee' locale is not present and can not be loaded

// for async style, in browser loading
var moment = require('moment');
var momentAsyncLocaleLoader = require('moment-async-loader');
momentAsyncLocaleLoader.setup(moment);
moment.asyncLocale('de').then(function (moment) {
  // locale de is loaded at this point
});
moment.locale('de') // this will either return normally if the locale is already loaded and available for use or throw an exception if 'de' is not available yet in this scenario

Obviously all of this has to be a new major release, because it is fundamentally changing how locales work. Also, it will be great if the loaders are tested under the respective environments (I hope that moment will become env agnostic, once this is resolved).

Hi, I am a beginner, I am available to work on this. may I?

Hi @BARICISSE , thanks for offering. This may not be a good first issue for a beginner.

See https://momentjs.com/docs/#/-project-status/


AllenNLP TransformerXL

Has anyone done any work on wrapping up TransformerXL for AllenNLP?

Maybe you should ask it in the AllenNLP repo as well?


STMC network  for SLT

Hi, I have read your work carefully and it seems to me well done, congratulations. I am very interested in being able to replicate your results in an end to end manner, and, subsequently, i would like to adapt the work to an Italian Sign Language dataset. Your work is based on two steps, the first is the translation from sign language to glosses through the STMC network. Subsequently, the glosses are translated into text through the transformers. Is there the possibility to share the code regarding the first part in which the STMC network is defined and trained? I'm really interested in the mechanism that takes videos in and translates them into glosses in a continuous way.
Thanks, Enrico

Hello! Thank you for your interest and the kind words! Unfortunately, I do not have code for the STMC network that I can share, I would suggest you reach out to the authors of the STMC model  to ask whether they can share the code with you!


rename project to reviewdog

It seems that travis build was broken with repo name change...

Changes Unknown when pulling 589c91f820df482dc6945509cf15492cd19da9d7 on rename-project into ** on master**.

Changes Unknown when pulling 589c91f820df482dc6945509cf15492cd19da9d7 on rename-project into ** on master**.

This pull request fixed the way to get the diff. The diff of diff_url is incompatible with comment API. I reported to GitHub support with following content.
diff of diff_url[1] field in pull request API[2] response isn't compatible with comment API[3].

[1]: https://github.com/haya14busa/reviewdog/pull/17.diff
[2]: https://developer.github.com/v3/pulls/#response-2
[3]: https://developer.github.com/v3/pulls/comments/#create-a-comment

The comment API needs `position` field and this position is based on diff which we can find `Files chaned view` in browser. https://github.com/haya14busa/reviewdog/pull/17/files
This diff seems to be equivalent to `git diff --find-renames`, which detects file renames.

However, the diff of diff_url seems to be equivalent to `git diff --no-renames`, which doesn't detect file renames.
So, If pull-request contains file renames, we cannot calculate the position for the comment API with diff of diff_url.

I think diff of diff_url should use `git diff --find-renames`, can you fix it?

Thanks in advance.


Fix tpcc-fail issue

This PR fixed the problem of #372 by removing the old version logic. This PR also fixed the issue of "unrecognized column type", which is done by @malin1993ml

Cool. Have you tested this with OLTP-Bench?

Yes. Already tested this with OLTP-Bench.

Changes Unknown when pulling de885a57aa9909b7748fafa49d49afcbb3f1da7c on Michael-Tieying-Zhang:master into ** on cmu-db:master**.

Coverage decreased (-0.3%) to 54.835% when pulling 6b4902a8a0233e1bc988337593faa42c9d277a49 on Michael-Tieying-Zhang:master into 8c21dc7ce42ca8fa2ba7be4493b2281edb4d25ac on cmu-db:master.

Can you rebase on top of master instead of merge, so that all you changes will sit on top of the merge of the last PR(18fda22206e4d30d32b05c5c72c3392e60f3e339), instead of split across that:
https://github.com/Michael-Tieying-Zhang/peloton/commits/master
Here's the guidance you could follow:
https://github.com/cmu-db/peloton/wiki/Git-survival-guide#rebase-or-how-to-screw-the-history

Coverage decreased (-0.1%) to 54.855% when pulling f996ef6b59a1a2238bea684bfdfbbfed36a6ed3e on Michael-Tieying-Zhang:master into 18fda22206e4d30d32b05c5c72c3392e60f3e339 on cmu-db:master.

Coverage decreased (-0.1%) to 54.855% when pulling 98fd025fcccfd68aec13162fdc2b8356d753aa20 on Michael-Tieying-Zhang:master into 18fda22206e4d30d32b05c5c72c3392e60f3e339 on cmu-db:master.

@malin1993ml Done.

Coverage decreased (-0.1%) to 54.849% when pulling cd801d580b6d8ffc487ded6c011fe459e925d2a8 on Michael-Tieying-Zhang:master into 18fda22206e4d30d32b05c5c72c3392e60f3e339 on cmu-db:master.