Update dependabot.yml

This should allow the branches by dependabot access to dockerhub
closes #360
Not sure if it works yet

Seems to work:
https://github.com/vhive-serverless/vSwarm/actions/runs/3643808094/jobs/6152387982
Please go ahead and merge once you are ok with it


Adds ethereum and evm to template node

This doesn't contain the RPC module yet.
Can you @sorpaas verify if the syntax and config is well placed and correct ?

I wasn't sure if I had to also include EVM in the runtime or if I should only have used the pallet Ethereum.

I wasn't sure if I had to also include EVM in the runtime or if I should only have used the pallet Ethereum.

It should also include EVM in the runtime, as you do now. Pallet Ethereum depends on Pallet EVM.


Adding a way to see Security Group Rules

Before Change :  Non-admin users were not able to see Security Group Rules applied to their spaces
After Change : Non-admin users can see the Security Group Rules for their spaces by using  cf space spaceName  --security-group-rules command
Issue : http://rnd-github.huawei.com/cloudfoundry/cli/issues/9

Hi @asifhuawei

The commit message is not complete. should have been something like " Adding a way to see Security Group Rules by non admins"
Does the change work for non-admins? Can you just add the output log from the command.
The PM of cli mentions in the story that you need to take care of both the commands cf space and cf app . But i can see only changes in spaces.

The PR does not include test cases. Ideally any PR which is on enhancement type should include test cases for it to be accepted.

Hi @shashidharatd
Below are the updates on the review comments

The commit message is not complete. should have been something like " Adding a way to see Security Group Rules by non admins"  -- done
Does the change work for non-admins? Can you just add the output log from the command. -- output given below in a comment
The PM of cli mentions in the story that you need to take care of both the commands cf space and cf app . But i can see only changes in spaces.  -- as per discussion with @SrinivasChilveri and reviewing story 77733680 we came to the conclusion that pm wants to implement the changes either in space or app command and he also suggested that impelementing in space is better as in app command we dont have information of space guid and if we try to implement it in app command then we need to make one more call to CC
These are undesired characters. the patch should not include these. similar for other files -- fixed
The PR does not include test cases. Ideally any PR which is on enhancement type should include test cases for it to be accepted. -- New test case added for this feature. Result for the test case is given below in comments

Non-admin user output
cf@cf3:~$ cf org-users huawei
Getting users in org huawei as admin...
ORG MANAGER
asif
BILLING MANAGER
ORG AUDITOR
cf@cf3:~$ cf login
API endpoint: https://api.<IP_ADDRESS>.xip.io
Email> asif
Password>
Authenticating...
OK
Targeted org huawei
Select a space (or press enter to skip):

apps
myspace

Space> 1
Targeted space apps
API endpoint:   https://api.<IP_ADDRESS>.xip.io (API version: 2.18.0)
User:           asif
Org:            huawei
Space:          apps
cf@cf3:~$ ./cf space apps --security-group-rules
Getting info for space apps in org huawei as asif...
OK
apps
Org:               huawei
Apps:
Domains:           <IP_ADDRESS>.xip.io
Services:
Security Groups:   public_networks, dns
Space Quota:
Getting rules for the security group  : public_networks...
destination   :   <IP_ADDRESS>-<IP_ADDRESS>
protocol      :   all
destination   :   <IP_ADDRESS>-<IP_ADDRESS>
protocol      :   all
destination   :   <IP_ADDRESS>-<IP_ADDRESS>
protocol      :   all
destination   :   <IP_ADDRESS>-<IP_ADDRESS>
protocol      :   all
destination   :   <IP_ADDRESS>-<IP_ADDRESS>
protocol      :   all
Getting rules for the security group  : dns...
destination   :   <IP_ADDRESS>/0
ports         :   53
protocol      :   tcp
destination   :   <IP_ADDRESS>/0
ports         :   53
protocol      :   udp

Test Case Output

space command when logged in and an org is targeted when the security-group-rules flag is passed
it shows space information and security group rules
/home/cf/asif/.go/src/github.com/cloudfoundry/cli/cf/commands/space/space_test.go:122
â€¢***

Hi @asifhuawei,
One more clarification. The story has nothing to do with whether the user is admin or not. so can you plz take care of this aspect in commit message.
Commit message can be made little more meaningful.
Thanks
@shashidharatd

@shashidharatd , the commit message is fixed as per review comments


How should we match the configuration values?

Expected Behavior
All the matchings with packages, fully qualified names, class names, imports... that we provide in the configuration file follows some kind of rule.
Observed Behavior
Right now there are a lot of behaviours and they are not documented so it's kind of difficult to know which is the behaviour.
Context
I saw this problem when I refactor the string list in yaml arrays. In some places we use a "contains" in other places an "endsWith", in other places we use glob and in others we use full regex.
In my opinion we can reduce all our needs in two different options:

Regex: It's difficult to read and maintain (by the user) but it gives maximum flexibility. Normally we don't need to provide this option, but whe it's needed there is no problem with it. The regex is a well defined language.
glob: It's much more easy to read and it gives a lot of flexibility too. It's really good for fully qualified names because you don't need to scape the .. I think that these should be the default option.

Options that we don't need:

Complete match. If you need a complete match you can use glob. You just need to scape * and ? and they are not used too much in fully qualified names or similar.
Partial match (aka contains or endsWith). This cases can be easily archived with glob because you just need to add a * at the beggining and/or the end.

An example of this can be found here: #2698

I mentioned in another thread concerning this topic.

I don't think that a uniform guideline for configuration options can be reached. There are many contributed rules and you can't make sure that everyone adheres to the guidelines. That would make it harder for 3rd party contributors to actually contribute a rule. Furthermore, you change a public API here. As a user of detekt, I'm tired of constantly changing my existing config just for the sake of change. It costs time. I'm not sure regarding the user benefit of having a uniform config. The rules are different and would be hard to achieve a uniform guideline.

All in all, you trade freedom and flexibility for consistency.

In my opinion we can reduce all our needs in two different options:

Regex
glob

I don't think so. With regular expressions you can only describe regular languages according to the Chomsky hierarchy.
You can't describe context free or context sensitive languages, which might be applicable for a specific rule's config option. In my opinion this has to be handled and evaluated case by case. For some rules you might want to configure the rule with a regular expression. In other cases a simple string list as we have with the exception ruleset might be fine too.

2. glob: It's much more easy to read and it gives a lot of flexibility too. It's really good for fully qualified names because you don't need to scape the .. I think that these should be the default option.

I'd be for this as the default.
If a user needs more fine-grained control, they can still create a custom rule that maps the same behavior but uses the full Regex mechanism.
The benefit is that default values are easier to read and to manipulate for the vast majority of our users.

Should this be moved to a "Discussion"?


Icons on the Ribbon on iPadOS 16.1

The icons on the Ribbon are not visible, even though they should be there.

Are they visibile in dark mode?

No, they are not visible in dark mode either.
29. 11. 2022 v 21:10, Phillip @.***>:

Are they visibile in dark mode?
—
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fphibr0%2Fobsidian-commander%2Fissues%2F44%23issuecomment-1331237378&data=05|01|lukas.vaner%40mmr.cz|0cbf18da635c4a782ae208dad245b8ac|8227f2a542384dd2baa9cb8d4f57a2e8|0|0|638053494144992623|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=LtjDAQPzQ6C4FPBb6OI2b%2BYxhHRG2JOuv2FGz3wmPeI%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAT22WBQJAZIUPDHFPOI4E4DWKZPKDANCNFSM6AAAAAARZNQXOA&data=05|01|lukas.vaner%40mmr.cz|0cbf18da635c4a782ae208dad245b8ac|8227f2a542384dd2baa9cb8d4f57a2e8|0|0|638053494144992623|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=0UJppd69Dy27yXtJYOSMYtdfcaIMcQ7zzMwOtdDZDMc%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Same problem here. Hope there is an update. The plugin simply doesn’t work


Basic usage issues

The tutorial gives this example:
<leader>c$ |NERDComEOLComment|
Comments the current line from the cursor to the end of line.

But pressing \c$ or ,c$ in vim copies the current line and switched to insert mode.
:echo mapleader doesn't output anything; I haven't added anything related to nerdcommenter to my .vimrc. :map <leader>c$ outputs n <Space>c$ <Plug>NERDCommenterToEOL

Judging from the way the mapping expands for you, your existing vim configuration is screwed up and your leader key is SPACE rather than the usual / or sometimes alternative ,. You should probably poke through your config and figure out where this is getting set and remove it, but it  can also  be set with something like this:
let mapleader = "\"

That being said if you leader is really SPACE as shown, then the function you are expecting should work by pressing <Space>c$.

I found your vimrc in your Github profile, and you are remapping leader to space on line 9. That's your problem. The binding is going to start with a space for you. This is pretty unconventional and is likely to get you in a lot of trouble with other mappings, I highly recommend using a different leader.

Wow, thanks for the expansive answer!

I should mention that using mapleader in a plugin without asking is pretty unconventional and is likely to break people's config.

@TamaMcGlinn Using the leader key is not unconventional at all, in fact it is quite common. This plugin will work just fine with SpaceVIM. The only issue here was a user expected it to work as if \ was hard coded and when people talked about their bindings they expected theirs to work the same way when they had a different leader set. We use whatever the user has set which is defacto the way leader bindings are supposed to work.


add chm-nav.json target to posix.mak

to check json validity @Cybershadow

Seems there is enough interest to keep them, can we integrate checking the chm-nav.json into your tester?

Thanks. This PR looks good, but auto-tester integration may need to wait a bit. The state of things is a bit half-way between this and the new thing, and now the existing one doesn't even build any more. Will try to look into this soon; even if not we'll definitely get this when the new thing is ready.
BTW, chmgen does a few more things than CHM generation, such as checking for broken internal links and generating the tags for dman.


AFSSLPinningModePublicKey behavior when validatesCertificateChain = NO

In AFSecurityPolicy.m, we have the following cases for SSL pinning:

AFSSLPinningModeCertificate & validatesCertificateChain = YES

The entire certificate chain is checked and the certificates in the chain must exactly match ones that the app is pinned to and when that happens, validation passes.

AFSSLPinningModeCertificate & validatesCertificateChain = NO

If ANY certificate in the certificate chain matches the one that the app is pinned against, trust validation passes.

AFSSLPinningModePublicKey & validatesCertificateChain = YES

The entire set of public keys is validated for trust validation to pass

AFSSLPinningModePublicKey & validatesCertificateChain = NO [This is the case that is a problem]

Only the first key in the chain is picked and the public keys that we pin against are checked for validation to pass.

In point 4, it should be ok to pin against the public key of a root CA and hence have the public keys of any certificate in the chain match the public key that the app pins against for trust validation to pass.
Is there a specific reason why this is not the case? I would be happy to submit a pull request based on this.

Agreed.  Submitted #2656 which addresses this case.

@niranjanr I'm digging in here and spotting the same problems. Thanks for calling these out.
I've opened up #2744 for discussion on what should be the proper expected behavior for pinning, and calling for community feedback there. Would love each of your opinions and use cases there.
I'll close this to consolidate, and we can move forward there.

Thanks @kcharwood. Will do.


onCapture not firing

On my own app the event onCapture seems not be fired. The app is hosted on vercel. Have tried with different iPhones with Chrome and Safari.
I've tried with next/dynamic and without. Your Demoapp works.
Here is my code. I have tried with different imports.
Imports
[snip...]

// import { BarcodeScanner } from 'react-barcode-scanner';
// import 'react-barcode-scanner/polyfill';
import { toast } from 'react-toastify';
import dynamic from 'next/dynamic';

const BarcodeScanner = dynamic(
	() => {
		import('react-barcode-scanner/polyfill');
		return import('react-barcode-scanner').then((mod) => mod.BarcodeScanner);
	},
	{ ssr: false }
);

[snip...]

[snip...]

	if (doScan) {
		const getCapturedValueHandler = (value) => {
			alert(value?.rawValue);
			const barcodeValue = value?.rawValue;
			setBarcodeValue(barcodeValue);
			setDoScan(false);

			if (barcodeValue != orderLine?.target?.barcodetext) {
				toast.error(
					`...`,
					{
						autoClose: 10000,
					}
				);
				setBarcodeValue('');
			}

			if (barcodeValue == orderLine?.target?.barcodetext) {
				setActiveStep(activeStep + 1);
			}
		};

		return (
			<Box>
				<Button
					variant="contained"
					size="small"
					color="error"
					startIcon={<Cancel />}
					onClick={() => setDoScan(false)}
				>
					Abbrechen
				</Button>
				<BarcodeScanner
					options={{ formats: ['code_128', 'qr_code', 'data_matrix'] }}
					onCapture={getCapturedValueHandler}
				/>
			</Box>
		);
	}

[snip...]

Have find out, thats this formats whats causing it. Without formats array it works well.
formats: ['code_128', 'qr_code', 'data_matrix']

i tried to add formats and it's work fine;
Can you provide a minimumrepo?
Here is my test code:
'use client';

import dynamic from 'next/dynamic';
import { DetectedBarcode } from 'react-barcode-scanner';

const BarcodeScanner = dynamic(
	() => {
		import('react-barcode-scanner/polyfill');
		return import('react-barcode-scanner').then((mod) => mod.BarcodeScanner);
	},
	{ ssr: false }
);

export default function Demo () {
  const onCapture = (barcode: DetectedBarcode) => {
    console.log(barcode.format, barcode.rawValue)
  }

  return (
    <div style={{ width: '400px', height: '400px' }}>
      <BarcodeScanner onCapture={onCapture} options={{ formats: ['code_128', 'qr_code', 'data_matrix'] }} />
    </div>
  )
}

Here is print:

My code looks like yours but not worked on my mobile devices. Did you try with mobiles? On desktop Chrome it worked fine.

it's because zbar doesn't support data_matrix format;
According doc, zbar not support aztec, data_matrix and pdf417 formats, I will add warning in docs about support formats;
Reference:
https://github.com/mchehab/zbar

The document has been updated


Question: Music on smartphones

Hi,
I used the app on my desktop and smartphone (iPhone) and can listen to the audio only on Desktop. Is mobile audio supported?
Thanks,

No, mobile audio is not supported currently.


Rename PACs and features

Because the last 3 characters of the chip name are only relevant for memory size and don't affect the PAC code generated by svd2rust this PR renames the PACs from e.g.  atsamd21g18a to atsamd21g. This results in 2 crates less to maintain.

This would be a pretty major breaking change for downstream users, and we already have the crate names published on crates.io 😕

I know this not a decision to take lightly. But technically you are not at 1.0 yet, so breaking changes are to be expected.
Additionally, if users use the board crates they won't even notice, because they implicitly depend on the correct PAC.
I don't want to force this through. If the maintainers decide, they don't want to got this route that's fine by me. I just think it will be beneficial in the long run. Especially if you want to add support for other SAME5x devices.
It's also what the Rust STM32 ecosystem is doing, which is arguably the largest Embedded Rust group.


fix: Enforce voting threshold param in oracle endblocker

Description
When updating the oracle rewarding in Ojo we noticed that the param VoteThreshold was not being used to enforce a minimum percentage of votes for a ballot to pass. This PR adds that enforcement and a unit test for it.

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #1707 (46fdb6d) into main (e8ddabf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
+ Coverage   57.50%   57.53%   +0.02%
==========================================
  Files          77       77
  Lines        8034     8039       +5
==========================================
+ Hits         4620     4625       +5
  Misses       3063     3063
  Partials      351      351

Impacted Files
Coverage Δ

x/oracle/abci.go
79.41% <100.00%> (+1.06%)
:arrow_up:

@mergifyio backport release.v4.1.x

https://github.com/Mergifyio backport release/v4.1.x


Hitting OpenAI GPT4 token limit

Love the project here. I've been working to enable complex Q&A over SEC 10-Q and 10-K docs for a while. I ran the code exactly as you provided. Unfortunately, when it gets to the part where it creates the prompt chain and calls the model, it dies because it exceeds the OpenAI token limit (8192 I think). How did you overcome the token issue?

Hi @pytony17 thanks for commenting! This repository is only focused on datasets... the same code provided is for reference just to get you started. Which code are you talking about? I assume this notebook? https://github.com/docugami/KG-RAG-datasets/blob/main/sec-10-q/process_docs.ipynb
This notebook is how the answers were initially generated (before human review/corrections). The process we followed is outlined in the README for the SEC 10-Q datasets. We shared this notebook for completeness, but please note that you should not be required to run this notebook just to use the dataset.
Regardless, if you still want to run this notebook you can try a few things:

In cell 8, make sure you are using the same model we are using i.e. gpt-4-1106-preview. This model has a much larger context limit of 128k tokens. Reference: https://platform.openai.com/docs/models/gpt-4-and-gpt-4-turbo
In the last cell you will notice this line: doc_text = doc_text[:40 * 1024 * 4]  # ~40k tokens, approximately, per document max. You can try to reduce the per document token count although this amount should fit comfortably in the gpt-4-1106-preview context limit.

Hope this helps!


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4242

Questions ?
Please refer to the Backport tool documentation


cdc: enhance deregister protocol

What is changed and how it works?
Issue Number: Close #15487
What's Changed:
When deregister regions from TiKV, emit a "region not found" event, which can make clients more robust.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test

Side effects
Release note
None

/merge


Case #08008 belongs to "compiler_crashers" (and not "compiler_crashers_2") :-)

What's in this pull request?
Case #08008 belongs to compiler_crashers (and not compiler_crashers_2) :-)
Resolved bug number: –

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci please test and merge.

Failures are unrelated.  Thanks! ✨


Xiaomi Philips LED Ball Lamp doesn't work

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.63.0
Python release (python3 --version):
3.6.4
Component/platform:
Windows
Description of problem:
I'm trying to add my Xiaomi Philips LED Ball Lamp but unfortunately I'm getting error and warning.
My token is right, device is connected to my network, I see it in ARP table.
Expected:
Working
Problem-relevant configuration.yaml entries and steps to reproduce:
light:
  - platform: xiaomi_miio
    name: Lampka biurkowa
    host: <IP_ADDRESS>
    token: d91fea3andtherestofmytoken

Traceback (if applicable):
2018-02-11 17:58:33 ERROR (SyncWorker_6) [miio.device] Got error when receiving: timed out
2018-02-11 17:58:33 WARNING (SyncWorker_6) [miio.device] Retrying with incremented id, retries left: 3

Additional info:

Please enable debug output and post your log again:
# configuration.yaml
logger:
  default: warn
  logs:
    homeassistant.components.light.xiaomi_miio: debug
    miio: debug

2018-02-11 18:25:18 INFO (MainThread) [homeassistant.components.light.xiaomi_miio] Initializing with host <IP_ADDRESS> (token d91fe...)
2018-02-11 18:25:18 DEBUG (MainThread) [miio.protocol] Unable to decrypt, returning raw bytes: b''
2018-02-11 18:25:18 DEBUG (MainThread) [miio.device] Got a response: Container:
data = Container:
data =  (total 0)
value =  (total 0)
offset1 = 32
offset2 = 32
length = 0
header = Container:
data = !1\x00 \x00\x00\x00\x00\x03\xact\xca\x00\x00\xf0\xf5 (total 16)
value = Container:
length = 32
unknown = 0
device_id = 03ac74ca (total 8)
ts = 1970-01-01 17:08:05
offset1 = 0
offset2 = 16
length = 16
checksum = \x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00 (total 16)
2018-02-11 18:25:18 DEBUG (MainThread) [miio.device] Discovered b'03ac74ca' with ts: 1970-01-01 17:08:05, token: b'00000000000000000000000000000000'
2018-02-11 18:25:18 DEBUG (MainThread) [miio.device] <IP_ADDRESS>:54321 >>: {'id': 1, 'method': 'miIO.info', 'params': []}
2018-02-11 18:25:18 DEBUG (MainThread) [miio.device] <IP_ADDRESS>:54321 (ts: 1970-01-01 17:08:05, id: 1) << {'result': {'life': 61685, 'token': 'd91fea3cbbhereismytoken', 'mac': '34:CE:andtherestofmac', 'fw_ver': '1.3.0_0033', 'hw_ver': 'ESP8266', 'uid':<PHONE_NUMBER>, 'model': 'philips.light.bulb', 'wifi_fw_ver': '1.5.0-dev(7f7a714)', 'ap': {'rssi': -53, 'ssid': 'WIFI', 'bssid': 'A0:21andtherestofmac'}, 'netif': {'localIp': '<IP_ADDRESS>', 'mask': '<IP_ADDRESS>', 'gw': '<IP_ADDRESS>'}, 'mmfree': 5504}, 'id': 1}
2018-02-11 18:25:18 INFO (MainThread) [homeassistant.components.light.xiaomi_miio] philips.light.bulb 1.3.0_0033 ESP8266 initialized
2018-02-11 18:25:18 DEBUG (SyncWorker_16) [miio.protocol] Unable to decrypt, returning raw bytes: b''
2018-02-11 18:25:18 DEBUG (SyncWorker_16) [miio.device] Got a response: Container:
data = Container:
data =  (total 0)
value =  (total 0)
offset1 = 32
offset2 = 32
length = 0
header = Container:
data = !1\x00 \x00\x00\x00\x00\x03\xact\xca\x00\x00\xf0\xf5 (total 16)
value = Container:
length = 32
unknown = 0
device_id = 03ac74ca (total 8)
ts = 1970-01-01 17:08:05
offset1 = 0
offset2 = 16
length = 16
checksum = \x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00 (total 16)
2018-02-11 18:25:18 DEBUG (SyncWorker_16) [miio.device] Discovered b'03ac74ca' with ts: 1970-01-01 17:08:05, token: b'00000000000000000000000000000000'
2018-02-11 18:25:18 DEBUG (SyncWorker_16) [miio.device] <IP_ADDRESS>:54321 >>: {'id': 1, 'method': 'get_prop', 'params': ['power', 'bright', 'cct', 'snm', 'dv']}
`

Error while setting up platform xiaomi_miio
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 84, in async_setup
SLOW_SETUP_MAX_WAIT, loop=hass.loop)
File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
return fut.result()
File "/usr/lib/python3.6/asyncio/futures.py", line 245, in result
raise self._exception
File "/usr/lib/python3.6/asyncio/tasks.py", line 180, in _step
result = coro.send(None)
File "/usr/lib/python3.6/asyncio/coroutines.py", line 210, in coro
res = func(*args, **kw)
File "/usr/lib/python3.6/site-packages/homeassistant/components/light/xiaomi_miio.py", line 65, in async_setup_platform
from miio import Device, DeviceException
File "/usr/lib/python3.6/site-packages/miio/init.py", line 2, in
from miio.protocol import Message, Utils
File "/usr/lib/python3.6/site-packages/miio/protocol.py", line 179, in
Const(0x2131, Int16ub),
File "/usr/lib/python3.6/site-packages/construct/core.py", line 1894, in init
super(Const, self).init(subcon)
File "/usr/lib/python3.6/site-packages/construct/core.py", line 291, in init
raise TypeError("subcon should be a Construct field")
TypeError: subcon should be a Construct field

Same problem... and in the next 0.64.0 dev too :(
To solve:
sudo systemctl stop<EMAIL_ADDRESS>sudo su -s /bin/bash homeassistant
source /srv/homeassistant/bin/activate
pip3 install -U https://github.com/rytilahti/python-miio/archive/master.zip
exit
sudo systemctl start<EMAIL_ADDRESS>

@km4lin You setup looks good. The device was discovery properly and should be accessible.

@Sergey-SRG Your issue is a duplicate of #12298.

Use hassio.

  - platform: xiaomi_miio     name: Xiaomi Philips Lamp      host: <IP_ADDRESS>     token: 96674bf0954339454d343eb9f3c9433f

@syssi ok, but why i'm having this error and warning?

@km4lin The device doesn't response to the first request sometimes. The connection is established on the second try cp. https://github.com/rytilahti/python-miio/issues/210

@syssi Thank you very much for help, I have been tested on and off function and the light is working.
btw: is there some advice how to change brightness or color temperature of this light?

Please close the issue.

Just click on the device name. A overlay appears. You can change brigthness and the color temperature here.

If you use hassio
SSH into your Raspberry Pi. Open an interactive shell on your home-assistant container (docker exec -it homeassistant /bin/bash) and try to execute the commands again:
pip3 install python-miio

@syssi Oh, i needed to add the device into one of the group. Thank you very much for your help! :) 🥇


Solutions for module-1, module-2

Hello @szikszail, please review the solutions for the first module.

Hello @szikszail, could you please help me with the task in Element module? I am unaware how to continue.
I am also unaware why my tests on addChildren method in Layout class do not pass although I have extended it from Element class.
Thatnk you!

No problem with addChildren method in Layout class after Element module import.

Thank you for your solution!


yaml loader doesn't accept "Infinity" string.

The CLI parses input files with demes.load_all(..., format="yaml") (yaml is a superset of json afterall). But it fails due to Infinity strings.
{
  "time_units": "generations",
  "demes": [
    {
      "name": "a",
      "start_time": "Infinity",
      "epochs": [
        {
          "start_size": 1
        }
      ]
    }
  ]
}

$ python -m demes /tmp/inf.json
Traceback (most recent call last):
  File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/grg/src/demes/demes-python/demes/__main__.py", line 216, in <module>
    cli()
  File "/home/grg/src/demes/demes-python/demes/__main__.py", line 212, in cli
    args.func(args)
  File "/home/grg/src/demes/demes-python/demes/__main__.py", line 91, in __call__
    num_documents, graphs = self.load_and_count_documents(args.filename)
  File "/home/grg/src/demes/demes-python/demes/__main__.py", line 130, in load_and_count_documents
    for graph in graph_generator:
  File "/home/grg/src/demes/demes-python/demes/load_dump.py", line 239, in load_all
    yield demes.Graph.fromdict(data)
  File "/home/grg/src/demes/demes-python/demes/demes.py", line 2006, in fromdict
    deme = graph._add_deme(
  File "/home/grg/src/demes/demes-python/demes/demes.py", line 1486, in _add_deme
    if len(ancestors) == 0 and not math.isinf(start_time):
TypeError: must be real number, not str

Oh no, did I miss this case? Sorry this wasn't caught before.


Feature request: Add more endpints

https://app.anakin.ai
https://www.perplexity.ai
...

Perplexity uses an OpenAI client API so it can be used by changing the endpoint and using the appropriate API key. This usage is already supported.
https://www.perplexity.ai/hub/faq/pplx-api
Thank you for the issue!

Here there are other free endpoints: https://github.com/aandrew-me/tgpt


Unit test failure: EditorService openEditor() - untyped, typed

Refs https://dev.azure.com/monacotools/Monaco/_build/results?buildId=202116&view=logs&j=55ac390b-ffb1-50ea-3650-525dd9a3fd80&t=3a692518-c3cf-5f6a-c273-72f71dc185fb
1) EditorService
       openEditor() - untyped, typed:

      + expected - actual

  Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

Looks like a unhealthy CI machine to me. normally unit tests on macOS take 2 mins:

Here I see almost 13 minutes


⚠ ClamAV has degraded performance

In 4bdbba2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 230 ms

Resolved: ClamAV performance has improved in a2bf589.


feat: pub use

Feature Request
Describe the Feature Request
Same as rust, pub use will reexport the module.
Describe Preferred Solution
Add visibility modifier for use in the cairo_spec.rs.
Change the logic of resolver to reexport the module.
Related Code
mod inner {
pub mod inner {
pub struct Point {...}
}
}
pub use inner::inner::Point
If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[X] Yes
[ ] No

I would also like to highlight, that I think starknet compiler should also build re-exported contracts, am I correct?

Do you mean in the case of nested contract? In this case if nested contract being re-exported, probably should be treated as multiple contracts in the single file.

Do you mean in the case of nested contract? In this case if nested contract being re-exported, probably should be treated as multiple contracts in the single file.

Yes and yes. Although CLIs do not support this, it doesn't mean this is unsupported and this actually works very well elsewhere, for example in Scarb.

Do you mean in the case of nested contract? In this case if nested contract being re-exported, probably should be treated as multiple contracts in the single file.

Yes and yes. Although CLIs do not support this, it doesn't mean this is unsupported and this actually works very well elsewhere, for example in Scarb.

Then yes for sure, reexport contract shall be implemented with “pub use”.

https://github.com/starkware-libs/cairo/blob/cairo-major-update/crates/cairo-lang-starknet/src/contract_class.rs
@mkaput so you want to extend line 115 in contract_class.rs to accept multiple contracts in single crate?

https://github.com/starkware-libs/cairo/blob/cairo-major-update/crates/cairo-lang-starknet/src/contract_class.rs @mkaput so you want to extend line 115 in contract_class.rs to accept multiple contracts in single crate?

I don't know if that's wanted by Cairo team, @orizi would have to chime in here :) What I suggest is making sure the find_contracts function works handles this properly. That's the API endpoint that the ecosystem is using.

We don't have any issues with multiple contracts in a single crate - just when creating the json for submitting to starknet we cannot have more than on available contract - so we need to either:

Have only a single available contract
State specifically which contract would you like (using --contract-path.)

@mkaput I think find_contracts has handled nested contracts in the same crates. I don't think it is a good idea to make "pub use" to reexport contracts from other crates and generate sierra and casm files.

I don't think it is a good idea to make "pub use" to reexport contracts from other crates and generate sierra and casm files.

Could you please elaborate, why do you think so? My point of view is now purely to ensure that this feature is consistent, as we found a better solution of generation of artefacts to be implemented outside the compiler.

I don't think it is a good idea to make "pub use" to reexport contracts from other crates and generate sierra and casm files.

Could you please elaborate, why do you think so? My point of view is now purely to ensure that this feature is consistent, as we found a better solution of generation of artefacts to be implemented outside the compiler.

For reexport I mean use could be recursively resolved as items. I think use in rust works in the same way. For the following reasons I don't think to use use to compile contracts in other crates into artifacts is a good idea.

Actually the logic recursively resolving use as items has been implemented. Currently every use is pub use. Adding visibility to it is a good to hide unwanted reexports. If we are talking consistency, we probably should let it as it is right now.
Resolving as items is a recursive process. If we implement use to compile contract in other crates, it will compile every single contract in the dependencies in the use statements. This is every expensive and I don't think people want this at all. I think most of time we use use just to import some libraries, so that we don't implement same things multiple times and save some efforts.
The compiler right now actually accept a path which could potentially contains multiple crates, and it will search every module under the crates for contracts. So like Scarb it think it completely has the ability to compile all the contracts in a single workspace into artifacts.

The I will re-word this issue to remove reexport, because reexport has been actually implemented.

newest edition on main now supports pub.


Update cmake dependency for GoogleUtilities to 7.12.0

Updated the cmake GoogleUtilities dependency to 7.12.0 since FirebaseCore updated to this version in https://github.com/firebase/firebase-ios-sdk/pull/12059.
#no-changelog

The firestore / cmake  workflows are existing failures (https://github.com/firebase/firebase-ios-sdk/pull/12058, https://github.com/firebase/firebase-ios-sdk/pull/12070).


attitude_fw delete unused and cleanup

TODO: review gain scheduling

I cannot think of a reason to have linear airspeed scalers on the feedforward terms, while quadratic are on the proportional and integral signals. Unless someone has a specific reason to leave it this way, I would be favor of making it all one quadratic airspeed scaler on the output of the sum of the ff p and i signals.

Updated.

@tstastny The reason is that the feedforward is used to compensate for the natural rate damping. For example, in roll, the nondimensional roll moment derivative can be modeled using (1) and generates a roll moment by (2).
Assuming a symmetric aircraft and zero sideslip, the equation can be simplified using only the rollrate damping and the roll moment produced by the ailerons (3).
During a roll at constant speed, the torque produced by the ailerons should exactly compensate for the damping (4).
Simplifying (5) and rearranging to extract the ideal ailerons deflection gives (6).
The first fraction gives the value of the ideal feedforward and we can see that the scaling is linear to airspeed. (The negative sign is then absorbed by the aileron control derivative which is also negative)

Where
V_T : trim airspeed of the model
S : ref surface
b : wing span
p : rollrate
delta_a : aileron deflection
beta : angle of sideslip
rho : air density
l (\ell) : roll torque
C_x : nondimentional derivative of x

The first fraction gives the value of the ideal feedforward and we can see that the scaling is linear to airspeed.

Thanks for the clarification @bresch -- however, I'm curious if the airspeed in the denominator of the coefficient actually has any dynamic physical meaning, or is only meant to be a relative scaling term chosen for comparing coefficients between various aircraft of different configuration and flight operating points; e.g., comparing the efficiency of a lift coefficient for a glider with large span at slow speed vs a lift coefficient for a cessna with small span, and higher speed. In my flight dynamics courses (many years ago) this is how it was always described to us.
I suppose if one wanted to use a similar approach with the scalar here to keep the feedforward gains themselves "comparable" between various aircraft, this could also be ok. But if you can point to an actual physical derivation of why the VT is in the denominator of the coefficient (besides simply a non-dimensionalization choice for units and characteristic parameters), I am always happy to learn something new. Otherwise, I guess the only truly physical term needed for scaling comes from the VT^2 -- i.e. dynamic pressure scaling.
wdyt?

@tstastny Thanks for the question, I actually never questioned this formula and had to read a bit to find an answer.

Firstly, (b/2) * p is the vertical wingtip speed and thus, the ratio (b * p)/(2 * V) is the angle that the wingtips make with the flight path and is called the helix angle.
Secondly, the roll damping coefficient of a rigid wing is constant regardless the airspeed. This coefficient only changes at higher Mach number (> 0.6) due to aeroelasticity (wing twist).
Thirdly, a constant aileron deflection produces a constant helix angle

This together shows that there is a physical linear airspeed relation between the roll rate and the aileron deflection.
The following reference explains quite well why I just summarize and gives nice figures:
Bill Crawford, Flightlab Ground School, 9.5-9.9, "Rolling Dynamics"
The references below also helped me to find the answer:
Helix angle : Stevens & Lewis, Aircraft Control ans Simulation, 3rd edition, p.80-81, "The aerodynamic derivatives"
Constant roll damping : Stevens & Lewis, Aircraft Control ans Simulation, 3rd edition, p.93-94, "Rolling moment, Figure 2.3-6"
Lateral control power, helix angle: Perkins & Hage, Airplane Performance Stability and Control, p.352-353

It would be great to include a brief explanation and references in the comments.

That was the original reasoning. Steady state roll rate for a given aileron deflection is proportional to true airspeed, whereas instantaneous change in roll acceleration due to a change in aileron deflection is proportional to dynamic pressure (indicated airspeed ^2).
Keeping the distinction between true and indicated airspeed in the calculation of the different gain paths is important.

It would be great to include a brief explanation and references in the comments.

@bresch @priseborough Is this something that should/could live in the guide too?

@priseborough Thanks for the precision, I completely ignored that point!
I needed a mathematical proof to convince myself, so I share the equations here:
At low altitude and speed, the indicated airspeed (IAS, V_I) can be converted to true airspeed (TAS, V_T) using a density error factor (1). Squaring, rearranging and adding a 1/2 factor to both sides makes the dynamic pressure expression appear (2). We can now easily see that the dynamic pressure is proportional to the IAS squared (3)

I only found this ref for the IAS to TAS formula used in PX4, does someone have a better reference?
@hamishwillee Absolutely! :)

@hamishwillee Absolutely! :)

@bresch Great, you've scored yourself a job then [evil snigger]. Is that OK?
The question is where? The only ECL doc we have is Using the ecl EKF. Is this a good place?
Looking at this doc it appears to me that we use the term ECL and EKF largely interchangeably. How exactly are they related, along with LPE? (It could be that ECL implements the EKF and the terms are synonymous, or it could be that the ECL is a higher level library that owns other functions and can interchange the control system used - ie ECL plugs in either EKF or LPE)
Either way, I think this doc should move under Concepts, possibly under a topic Estimators, that also includes https://dev.px4.io/en/advanced/switching_state_estimators.html

@bresch Any news on this?

@LorenzMeier About the documentation, I have a draft version that Hamish reviewed, I should be able to make a PR this week. I should make that scaling technique clear and understandable to everyone.
I'm currently reviewing this PR and I'll make sure that the IAS and TAS scalers used correctly.

I'm closing this. The documentation introduced by https://github.com/PX4/Devguide/pull/555 explains the scaling.


Wrong Dedulication Algorithm for Mozilla Observatory Scan

Bug description
Importing the same Mozilla Observatory Scan report multiple times makes the number of findings grow.
Steps to reproduce
Create an engagement
Import the same Mozilla Observatory Scan report multiple times.
Multiple findings are not deduplicated from DefectDojo.
Expected behavior
The deduplication algorithm in DefectDojo deduplicates findings.
Deployment method
Docker Compose
Operating System: Ubuntu 21.04
DefectDojo version: 2.3.1

Closed due to inactivity


Corrupted worlds

Every so often a world create and saved with /world is corrupted, turning into a 0-byte map file. The config file is not affected. This does not happend to default/freebuild.

I think this is caused when the server is closed forcefulyl while saving a map. I probably didn't notice with default or freebuild because while testing on the debug build I don't usually make changes to those worlds, so they never attempt to save. If this is the problem, then I suggest that the map saving function save to a temporary file and, when it's done writing the buffer to the file, overwrite the map file with the temporary file.

This doesn't happen as much after a few small changes in the autosave code and since I started using /shutdown to safely save all maps and shutdown the server. However, it is still a potential issue and should be addressed.


Kong Enterprise 2.4.x license support

Hi according to https://docs.konghq.com/enterprise/2.4.x/deployment/licenses/deploy-license/ the Kong enterprise license is not anymore fetch from the KONG_LICENSE_DATA, but must be placed in /etc/kong/license.json.
Btw, there is no simple way to mount that file int /etc/kong that already exists, appart from copying it from another mount location.
Should the license provided via the API then ?

 The code to read it from there still appears to be unchanged, and I'm able to start a 2.4 test instance using KONG_LICENSE_DATA still. I think that was just an omission in the updated documentation--if you can confirm it works for you also, I'll ask the docs team to correct that and indicate that the environment variable is still supported.

Yes I do confirm it works still with the KONG_LICENSE_DATA, and I was getting confused by the documentation, that dropped that part.
Thanks for your response.


gRPC: add support for CQL duration type

What this PR does:
Add CqlDuration type to represent durations on the client.
Add missing bits to bind duration values and read duration columns.
Note: this is based on v2.0.0 because I started it in the context of GraphQL v2, but it can be backported to v1.
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[x] Documentation added/updated

Cass-4.0 build was failing, probably/possibly due to that flaky test; triggered retry.


Show thread ids everywhere

Currently Flow and some other UIs use thread names only while Timeline uses thread ids only. I find ids to be much more concise for a quick reference, so I propose adding them to all places where a thread name is displayed.
Thanks!

Yeah, make sense.


Infinite loop with untrusted SSL Certificate

I was attempting to use this provider on a bifrost install with a self-signed SSL certificate and that seems to get the provider stuck in an infinite loop.
I was able to get the provider to throw an error by adding this above the time.Sleep call in the waitForConductor and waitForAPI functions.
if strings.HasSuffix(err.Error(), "x509: certificate signed by unknown authority") {
     return
}

But this isn't the most elegant solution.

Sorry for the noise, I didn't realize that I had timeout declared in the provider block - I thought it was set to 0.


Breaking Change with Productive Bees v2.3.0

LJ split common functionality off into a library mod in v2.3.0, meaning the latest version of Productive Bees is incompatible with Centrifuge Tiers. Just wanted to bring attention to it in case the change goes under the radar for most.

https://legacy.curseforge.com/minecraft/mc-mods/centrifuge-tiers-reproduced/files/5120541


ISPN-15758 Publisher should fetch data from remote nodes

When SKIP_CACHE_LOAD flag is used with shared stores, the publisher should fetch the entries from the other nodes except for replicated caches
https://issues.redhat.com/browse/ISPN-15758

Thanks @pruivo


LinkedIn learning and MS Viva integration

Dear Team,
can you please provide guidance if there is any option to integrate the LinkedIn learning or MS Viva to this platform?
If yes - can you please share the details on the How?
thank you
regards,
Attila

Thank you - no further questions


Array.last: add support for ReadonlyArray

Currently this function will error when trying to pass in an array of type ReadonlyArray<T>.
I suspect we'll want to make the same change for other functions which receive arrays… but it does seem like a PITA.

ReadonlyArray<A> is a subtype of Array<A> so I guess that its signature could simply be
<A>(as: ReadonlyArray<A>): Option<A>

Now the question is: should we support ReadonlyArrays? What about functions which return arrays like copy or sort?
@sledorze @raveclassic what do you think? What's your experience with the Readonly* variants?
p.s.
Personally I never bothered to use them, nor the readonly modifier (except when I started using TypeScript). Actually after 19 months of TypeScript daily usage I never experienced a bug related to mutations, I just don't mutate any data structure.

For context, I'm receiving a ReadonlyArray from io-ts’ ValidationError['context']: https://github.com/OliverJAsh/io-ts-reporters/blob/27314683a28b6798c2a357e41477786f4755febc/src/index.ts#L22

Indeed, theoretically using ReadonlyArray is the "correct" thing to do in that case, in practice I'm not sure it was a good idea.
p.s.
Btw in that case Context should be a NonEmptyArray<ContextEntry> so that picking the last element is a total function (I plan to refactor the validation errors in<EMAIL_ADDRESS>

I never use ReadOnlyArray but when a lib exposes it. (we also never mutate but in lowlevel functions with care of keeping referential transparency)
The general reason tu support ReadOnlyArray is to integrate with third part lib.
A discussed here:
https://github.com/types/npm-ramda/issues/113
Note: I'm interested into knowing more about the refactor of errors goal in io-ts

@gcanti mentioned previously that, while Array contains all properties of ReadonlyArray so changing function arguments to take ReadonlyArrays wouldn't break backwards compatibility, it would cause an issue with if we changed existing functions to return ReadonlyArrays.
The solution he proposed was adding overloaded versions of each array function that handle ReadonlyArrays, but another option I think could be worth considering would be to change existing functions that take Arrays as arguments to take ReadonlyArrays, but leave them to return regular Arrays.
As far as I can tell all fp-ts array functions return a new array separate from the source one so having them be different types shouldn't cause an issue. Since Array is a superset of ReadonlyArray, functions of type ReadonlyArray -> Array can still be composed as if they were of type Array -> Array.

I'm working on an application that uses https://github.com/jonaskello/tslint-immutable to keep the other devs on the team honest. One of the rules (which I want enforced) is use of ReadonlyArray.
I frequently find myself having to cast them to Array when I'm using this library. I was honestly surprised that the array functions didn't return ReadonlyArray as there is a strong tendency away from mutation.

This has also been an issue for me.

@gabejohnson curious about tslint-immutable, in your experience is there any difference in practice between readonly-array and no-array-mutation rules?

readonly-array
no-array-mutation

@gcanti no-array-mutation wasn't added until after we began the project (and I wasn't aware of it until today). We swapped it in and it works great!

Closing due to inactivity


Merge upstream

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 6 committers have signed the CLA.:x: optim-aizawa:x: mpfz0r:x: cuonglm:x: mlsmaycon:x: n8felton:x: coanorYou have signed the CLA already but the status is still pending? Let us recheck it.


The latest version starts to crash

Describe the bug
dump file:
ProcessHacker.exe.16536.zip
To Reproduce
Just start it
Expected behavior
everything is ok
Screenshots
na
Desktop (please complete the following information):

10.0.19042.985

Additional context
na

No, I no longer crash immediately after restarting, but once my machine runs for too long, it crashes again.. here are the three recent crashes:
CrashDumps.ZIP

Try updating to the latest nightly build r4330
If it crashes again, there's a new button for 'NormalDump' which you can upload that will include filenames causing the crash.

No buttons appear when it crashes.you can send the debug version here so that you can analyze the reason more easily
CrashDumps.zip

No buttons appear when it crashes

How are you generating these dump files without the exception dialog?

Yes, it is captured by the system. In the C:\Users\user\AppData\Local\CrashDumps\ directory


Timezone in log.html same as the browser and not the one from the device under test

Hello,
The logs generated in log.html doesn't contain a timezone specific, and when opening the logs they also are the same as the browser, and not the same as the device under test.
I saw this was commented in another thread in google groups, but I couldn't see more recent info:
https://groups.google.com/g/robotframework-users/c/Wtg8EYwNVJ8
Could you please check? Is this expected?
Many thanks

From Pekka's response that you linked to, this is the expected behavior currently.  As he mentions, it may be possible to get that information from the remote system, but I could see that being very difficult information to get without installing something.  Most OSes don't just hand this information out freely.
You can see if this could be an enhancement request that anyone is interested in taking on.  https://github.com/robotframework/robotframework/blob/master/CONTRIBUTING.rst#enhancement-requests


fix: remove v1 suffix for ApiUrl if exists [IDE-353]

Description
Currently IntelliJ adds a /v1 suffix for the API URL. This is a temp workaround until the new cli stable is released.
Checklist

[ ] Tests added and all succeed
[ ] Linted
[ ] README.md updated, if user-facing

🚨After having merged, please update the snyk-ls and CLI go.mod to pull in latest client.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Frontend: Build the Sidebar sub component for both Light and Dark mode

Issue Summary
The design for Sidebar as part of the Navbar component has being completed and now it needs to be built using our chosen tech stacks.
Figma link
The design for the Sidebar can be found here. Please make sure what you build follows the design.
Suggested fix

Build the MegaMenu component following the design in the Figma file.
Make sure your codes are maintainable and legible.
After coding the component using React and scss, create storybook for the component.
Test it out on your end and make sure it's working properly.

Coding Rules

Let your codes look neat and readable
No unnecessary spacing and always leave one empty line after each code block
Separate each word with a hyphen - in your scss classes, ids.

PR Rules

Link the issue your PR is for by saying Fixes #PRNumber
Add a description of what your PR is about
Add screenshots or video of the working implementation of your PR

Pl assisgn the issue under gssoc

@naveeng2402
Heyy
Thanks for picking this up
You can work on it
PS: You have maximum 3 days to create a pr else it would be assigned to someone else


Implement DiffProvider for batch operations and fix getCurrentRevision

Speed improvement
The main impact of this PR is that it improves the performance of getCurrentRevisions by extending the DiffProviderEx class that has a specialization for batch operation. (This operation gets called when the user hits a "Refresh" button in VCS log tool window.)
Now, instead of multiple HTTP requests to retrieve the local revisions of items involved, the TFSDiffProvider will perform a single batch tf operation.
On my test repository where I have a big commit with 1500 files, old TFSDiffProvider implementation couldn't update the history in 10 minutes and failed with OutOfMemoryError afterwards. The new implementation performs the operation in about 5 minutes and doesn't increase the memory footprint in a noticeable way.
Unfortunately, tf info still has to go to server to retrieve additional information we don't use. If the command line TFS client would support operation such as localversions, then the performance may be significantly improved once again. I've filed a feature request about that command, please see the details there.
Correctness improvement
From the TFSDiffProvider code it looks that it returns the same value for both getCurrentRevision and getLastRevision return the same value. This seems to be wrong: getCurrentRevision should return a current local version and not the server one. Thus I've changed the getCurrentRevision code to use the same mechanism used by the new batch operation getCurrentRevisions.

@kaylangan, hello. This PR is ready for review. Thanks!


Today and list of words to exclude

hello and thank you for this application which is easy to use, I am in France and I noticed that today is not updated with the time of my smartphone (ios) but I have the impression rather time zone US? Another point is it possible to add a list of words that you want to exclude and therefore not display the news if a word belongs to the list? thanks in advance

I’d love to be able to exclude a list of words too. Would completely transform the app for me!


Identifiers validation failed for dataset Brioflora de la Reserva de Montes Azules, Chis.: Diversidad, biogeografía y depauperación por actividad humana

Identifier validation failed for the dataset Brioflora de la Reserva de Montes Azules, Chis.: Diversidad, biogeografía y depauperación por actividad humana:

Crawler attempt: 306
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 1525
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 1525 total records; 1525 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3740314/step

New IDs sample:

Old IDs sample:

00e5b643babacb5126d178fa533c655f
0409a056185d73d49364d3b6129af49c
05cb648688d241f9a268acb8a74ab923
06c3eeac7fa428c8a0caf3cb4a1c3e76
095fdaa65d929728faf427cc5d95742c
0c99bb7df384fd6db79e24489791b461
0d07da9805fcd57ff8938c16242a3b16
0d4dcb58a9e2fcf43ccac929714a8da8
0f94a57363ba04e8cf922008987ff240
0fcfffb0a16dd315d5a44c8982397cae

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Brioflora de la Reserva de Montes Azules, Chis.: Diversidad, biogeografía y depauperación por actividad humana : https://doi.org/10.15468/dzsqmo.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Brioflora de la Reserva de Montes Azules, Chis.: Diversidad, biogeografía y depauperación por actividad humana:

Crawler attempt: 307
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 1525
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 1525 total records; 1525 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741160/step

New IDs sample:

Old IDs sample:

00e5b643babacb5126d178fa533c655f
0409a056185d73d49364d3b6129af49c
05cb648688d241f9a268acb8a74ab923
06c3eeac7fa428c8a0caf3cb4a1c3e76
095fdaa65d929728faf427cc5d95742c
0c99bb7df384fd6db79e24489791b461
0d07da9805fcd57ff8938c16242a3b16
0d4dcb58a9e2fcf43ccac929714a8da8
0f94a57363ba04e8cf922008987ff240
0fcfffb0a16dd315d5a44c8982397cae

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Brioflora de la Reserva de Montes Azules, Chis.: Diversidad, biogeografía y depauperación por actividad humana : https://doi.org/10.15468/dzsqmo.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Brioflora de la Reserva de Montes Azules, Chis.: Diversidad, biogeografía y depauperación por actividad humana:

Crawler attempt: 309
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 1525
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 1525 total records; 1525 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3741782/step

New IDs sample:

Old IDs sample:

00e5b643babacb5126d178fa533c655f
0409a056185d73d49364d3b6129af49c
05cb648688d241f9a268acb8a74ab923
06c3eeac7fa428c8a0caf3cb4a1c3e76
095fdaa65d929728faf427cc5d95742c
0c99bb7df384fd6db79e24489791b461
0d07da9805fcd57ff8938c16242a3b16
0d4dcb58a9e2fcf43ccac929714a8da8
0f94a57363ba04e8cf922008987ff240
0fcfffb0a16dd315d5a44c8982397cae

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Brioflora de la Reserva de Montes Azules, Chis.: Diversidad, biogeografía y depauperación por actividad humana : https://doi.org/10.15468/dzsqmo.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Add query list samples command

Overview
This pull request implements the bcftools query --list-samples command from bcftools in vcztools. The vcztools command loads the sample IDs from the VCF Zarr group and prints them.
This pull request closes #51.
Example usage
vcztools query -l vcz_test_cache/sample.vcf.vcz
NA00001
NA00002
NA00003
vcztools query --list-samples vcz_test_cache/sample.vcf.vcz
NA00001
NA00002
NA00003

Testing
I added some tests that compare bcftools' output with vcztools' output.
The coverage tool shows no coverage on the code added in this PR because the tests run the code in a different process. Most of the VCF writer code is also not covered because of this testing approach.
References

bcftools query

The coverage tool shows no coverage on the code added in this PR because the tests run the code in a different process.

I've been wondering what our testing strategy should be, and this is one reason to add unit tests that call functions directly (i.e. not via the CLI). In this case it should just be a matter of adding a unit test for list_samples.
I think we need validation tests too of course, but these are less focused on exercising test coverage and more about checking that we match bcftools across a wide range of CLI parameters. So in this case I think it's fine to keep the tests you've already added as well.

Most of the VCF writer code is also not covered because of this testing approach.

I think a lot of the missing VCF writer coverage is because we are not exercising VCF header generation yet, but that's a bigger topic - see #47 and related issues.


Classify applicant requests

As an intake analyst, I want to be able to classify the applicant type, so that I can report out on who makes requests.
Acceptance Criteria
Scenario 1: Open applicant type selector
GIVEN the analyst is on a request:
https://jacklyn808742.invisionapp.com/console/share/XU2L77IGEA/631957829
WHEN the analyst clicks the arrow next to Category (is the the preferred title?)
THEN a drop-down will open with 8 options: Business, Individual, Interest Group, Lawyer, Media, Political Party, Public Body/Government, Research
https://jacklyn808742.invisionapp.com/console/share/XU2L77IGEA/631957829
Scenario 2: Select applicant type
GIVEN the analyst has opened the drop down for Applicant Type
https://jacklyn808742.invisionapp.com/console/share/XU2L77IGEA/631957829
WHEN the analyst clicks the applicant type (e.g. Interest Group)
THEN the drop-down will close
AND the new request type will be displayed (e.g. Interest Group)
https://jacklyn808742.invisionapp.com/console/share/XU2L77IGEA/631957827
...
Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@JHarrietha-AOT to create design based on Material UI functionality
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests

[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

AC to be updated once we have a design.

@mpilchar, fyi - this is ready for refinement tomorrow.


Feature/RingBuffer and ScopedIrqBlocker

Builds on top of #224
Two small changes:

RingBuffer gets a new getter function isEmpty()
Added ScopedIrqBlocker to secure code blocks against concurrency problems

@stephenhensley Please have a look again.

don't worry about rebasing again on this one. I can review/merge as is.


Adds too much spacing for brace-style imports

We use this convention:
import {a, b, c} from './x';

Your package rewrites this as:
import { a, b, c } from './x';

...which won't work for us. This needs to be configurable.

its already in configuration. go to package settings and check 'space for named imports'


Removing old entities, tidying up home assistant

Is there a way of old unused entities being automatically removed when an update happens?

If you remove the device then re-add it does it but I don't know how to do it otherwise I did look, but saw that other people had asked and could not find an answer.
Remove and re-add won't remove the ones that are there.

Closing, not sure its possible to do this by code, it has been asked in the developer forums but no answer.

You don't need to remove/add the device to achieve this. You can just call delete on all the entities of the device. The trick is that HA won't allow delete on those which are still valid so only the invalid ones gets deleted.
Not sure if this can somehow be done as part of the update but at least it is easy to clean-up manually.

That is interesting, no idea but I it can be done in the UI maybe I can code it, will see.

That was not easy, don't know the limitations but now I detect and remove old entities when the integration is re-initialized.
It works by getting all entities at start of config (restart or reload I think) and then removes each one from the list as they are set up.  Anything remaining is assumed to be no longer provided and I flag for removal.
One thing I noted it seemed not to remove immediately so not sure if it is just flagged for later removal but after another restart they disappeared.  Also don't know if they get removed if you have them in use on the Dashboard.
But still its there so will clean up eventually.  Will be in the next beta when I get round to it, but trying to clean up other stuff first.


ItemsControl items won't show

Describe the bug
In some cases, inserting/adding new items to an ObservableCollection that's bound to a ListBox or ItemsControl will cause these items to not show.
This seems to be the case consistently when inserting at the index 0.
This also seems to cause a "defective" state for the VirtualizingStackPanel causing items to overlap.
To Reproduce
In Control Catalog, ListBoxPageViewModel change the following -
Line 23 -
https://github.com/AvaloniaUI/Avalonia/blob/74d0241e7fefe38d1bfcdbac1a95c2dd50a30578/samples/ControlCatalog/ViewModels/ListBoxPageViewModel.cs#L23
Items = new ObservableCollection<ItemModel>(Enumerable.Range(1, 7).Select(i => GenerateItem()));

Change to less items to notice anything.
Line 37 -
https://github.com/AvaloniaUI/Avalonia/blob/74d0241e7fefe38d1bfcdbac1a95c2dd50a30578/samples/ControlCatalog/ViewModels/ListBoxPageViewModel.cs#L37
AddItemCommand = MiniCommand.Create(() => Items.Insert(0,GenerateItem()));

Change the item to be inserted at index zero.

Run Control Catalog
Click on ListBox page
Click the add item button
See error

Expected behavior
Items to be added reliably.
Screenshots
This is the overlapping -

Additional context
Commenting the if in line 1094 in VirtualizingStackPanel and letting the else section always execute, seems to solve the issue.
https://github.com/AvaloniaUI/Avalonia/blob/74d0241e7fefe38d1bfcdbac1a95c2dd50a30578/src/Avalonia.Controls/VirtualizingStackPanel.cs#L1094
@grokys I believe you're the most relevant guy for this (sorry for notification if not)

this bug definitely has a blocker priority. @adirh3 thanks for a hotfix hint. will try this

Thanks @adirh3 - that one was a bit of a 🤦 . #10788 should fix it.

Tried your solution. Still has issue with crash. trying to get element with index -22 from my collection.


HV Boot and Wheels Spinning

Changelist

Testing Done

Resolved Tickets

ok @will-chaba changes addressed.

I wanna merge in today

I wanna merge in today

Respectfully, should not be merged until driving shakedown

I wanna merge in today

Respectfully, should not be merged until driving shakedown

was worried about rebasing especially with the things we want (like telem + sd card)


In .NET 9, remove dependency on Microsoft.Extensions.Primitives by using Span<char> instead of StringSegment

The version parsing uses Microsoft.Extensions.Primitives.StringSegment to efficiently pass subsegments of strings without constructing new string instances.  That library supports all the versions that the semver library does and provides all the needed functionality. As of .NET 9, Microsoft is adding additional methods to do things like split a Span<char> at separator characters. With that, there should be enough support in the BCL to implement semver in terms of Span<char> instead. That would eliminate the dependency on Microsoft.Extensions.Primitives, thereby reducing installed size in apps using the library and avoiding any conflicting dependency version issues.
I will investigate doing this for the next patch version. However, if it causes too much mess in the code to support a variation for newer versions, I may not do this.

After updating to Semver 3.0.0, I noticed that this exact dependency, Microsoft.Extensions.Primitives can not be resolved.
Error: Could not load file or assembly 'Microsoft.Extensions.Primitives, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.

Is this related to this issue or is it just due to NET5 being end-of-life since May 2022 and the library not being available anymore?

@rngcntr I'm not sure what is causing that error. It should be working. Please file a separate bug for that with more detail about versions being used and steps to reproduce.

For reference: https://github.com/WalkerCodeRanger/semver/issues/90


Can't create session file

Describe the bug
I am unable to create session file, it prompts me for my password, and then never creates the file. The folder has full read/write/execute permissions so it should not be a problem, therefore it is a bug. I am already using the latest instaloader 4.2.10 with Python 3.6.9 on Ubuntu 18.04.
To Reproduce
instaloader --login=username profile profilenamehereobviously --sessionfile=/home/name/.instaloder-session
Expected behavior
I expect the session file to be created after being prompted for my password.
Error messages and tracebacks
There are no errors.
Instaloader version
4.2.10
Additional context
None.

To Reproduce
instaloader --login=username profile profilenamehereobviously --sessionfile=/home/name/.instaloder-session

Most probably this wrong invocation is the cause for Instaloader not behaving as expected. The correct option is --sessionfile=..., without -- and sessionfile being separated.

Hi @aandergr
Thanks for your response.
I'm kind of confused. I did --sessionfile=... without -- and sessionfile being separated?
I don't think this bugreport is invalid, it literally specifies that the session file does not exist - which means that the argument is being read:


"Member 'Color/Cursor/Thickness' is declared in another module and needs to be imported" for generic MarkupExtension

Describe the bug
Using a generic MarkupExtension that uses an Avalonia-internal type like Color, Cursor or Thickness throws an error during compilation:
{local:Conditional, Path=#MyCheckbox.IsChecked, True=Green, False=Red, x:TypeArguments=Color}
MSBUILD : Avalonia error AVLN: 9999: System.ArgumentException: Member 'Avalonia.Media.Color' is declared in another module and needs to be imported [C:\Work\Avalonia\samples\Sandbox\Sandbox.csproj]
To Reproduce
Use the attached SandBox/minimal project to reproduce (MainWindow.axaml)
Expected behavior
The MarkupExtension should work in the same way as it does with System.* types like Boolean or String.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 10
Version 11 preview 6

Additional context
Sandbox.zip

Related? #8789

Reopening, as Avalonia doesn't yet use this XamlX build.


Output - Merge persona params w/ response data

Sometimes, params passed into an API don't get returned (passwords). They still might be useful in the output, though. So instead of simply adding the response to the output, let's merge it on top of the persona params.

Hey @jwils0n,
I am new here. Wanna contribute to this issue.
Can you help me kinda onboard.
Thanks :).

@akshat-g-07 Check out this line of code where the output is built:
https://github.com/intuit/saloon/blob/master/src/seeder.js#L104
You can see it's only inserting the response data, but not any persona(resource) params.
When contributing always make sure it's not a breaking change for existing users, unless absolutely necessary, and then it would need appropriate versioning.

Hey @JeremyCroff , Thanks for the informative reply. And sorry for replying late I was stuck with some personal things.
As per my understanding, the steps I need to follow are: 1.) In _saveSuccess, I need to add the persona as a parameter. 2.) Pass the required/desired properties of persona to insert function. 3.) Update the insert accordingly here.
Please let me know if I am coming in the right direction. If yes, then I will start this right away. If no, can you please steer me on the right path.
Thanks :)

The resource param should be the persona data! You should be able to confirm by running it locally


PDO_MYSQL extension of PHP

Can someone help me solve this error when I try to use the pdo_mysql plugin
I tried running this command
ee shell example.com --command = ‘docker-php-ext-install pdo_mysql’ --user = root
The command is executed successfully, but there is no effect on the plugin.
but it still did not work, I tried to rename some things in php.ini and also without success,
I also restarted the ngnix service and nothing was resolved.
Please, if someone knows how to solve it and I can write it step by step.

This has been fixed. pdo_mysql is there by default in the latest version of EasyEngine.
Update your EE to latest via: ee cli update --yes


requirements.txt pyspark>=2.4.7 is installing pyspark 3.0 which is causing issues with my pyspark 2.x job

Symptom:  couldn't write to S3 from within a SageMaker Processing Job.
I had to switch to pip install --no-deps pyspark-deequ to avoid upgrading  pyspark to 3.0.1.
Perhaps cap the version of pyspark defined in requirements.txt to include <3.0?
Note:  I saw this issue on 1.0.2, but upgraded to 1.0.5 while testing.  Not sure if that matters.  Seems like the pyspark version was the issue.

It's fixed
https://github.com/awslabs/python-deequ/blob/d2e6e891528ab6dfe3cc0185c974dacc5ec78c97/requirements.txt#L1
@cfregly you can close this issue

Thanks!


[bug] Splashscreen and main windows are visible in the final msi build for Win11

Describe the bug
During development cargo tauri dev the official example for splashscreen works as expected on all platforms, however the windows 11 final msi builds shows both the main and splashscreen,  seems to be not respecting the visble rule mentioned in #5583, i also tried to cargo update mentioned in the issue but with no success.
project code: https://github.com/MassivDash/S3_Manager
I am unable to test behavior on windows 10, so the problem could be only related to Win11, all other final builds are consistent with dev env
Reproduction

create a fresh svelte project
add splashscreen accroding to docs https://tauri.app/v1/guides/features/splashscreen/
build the project on win11
Observe 2 screen showed at once

Expected behavior
That the splashscreen development behavior will be conistest with the final build
Platform and versions
[✔] Environment
    - OS: Windows 10.0.22621 X64
    ✔ WebView2: 115.0.1901.188
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.71.0 (8ede3aae2 2023-07-12)
    ✔ Cargo: 1.71.0 (cfd3bbd8f 2023-06-08)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN)
    - node: 18.17.0
    - npm: 9.6.7

[-] Packages
    - tauri [RUST]: 1.4.1
    - tauri-build [RUST]: 1.4.0
    - wry [RUST]: 0.24.3
    - tao [RUST]: 0.16.2
    - @tauri-apps/api [NPM]: 1.4.0
    - @tauri-apps/cli [NPM]: 1.4.0

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist
    - devPath: http://localhost:3000/
    - framework: Svelte
    - bundler: Vite

Stack trace
No response
Additional context
No response

Can you try again after re-ordering the windows in tauri.conf.json so that the splashscreen is first? If that doesn't work, try using a 100ms setTimeout for the close_splashscreen invoke call just to check if it's a timing issue, which is my guess rn since the app starts way faster in release mode compared to dev.

The splashscreen.html file seems to be missing while building the installer.
Found that if the url of the splashscreen in tauri.conf.json is changed to some web url, like https://www.google.com, the window can visible.

Following the document, need to configure splashscreen.html to disDir.
  "build": {
    ...
    "distDir": [
      "../dist",
      "../splashscreen.html"
    ]
  },


Autodiscovery not working on tp-link AU due to parenthesis in model name

Hi,
I have a bunch of tp-link kasa things, mostly KP115 and KP303. I'm in Australia so they are the Australian variants.
KP115 is supported already, I measured the AU version and confirmed power profile is matching the model already existing here.
The AU version however has model id 'KP115(AU)'. This is similar for other kasa AU devices e.g. 'KP303(AU)'
I tried adding this as an alias in the model.json but then noticed the following in the logs for a KP115(AU):
2022-11-12 12:43:54.015 DEBUG (MainThread) [custom_components.powercalc.power_profile.model_discovery] switch.fridge: Auto discovered model (manufacturer=TP-Link, model=AU) 2022-11-12 12:43:54.015 DEBUG (MainThread) [custom_components.powercalc] switch.fridge: Model not found in library, skipping discovery
I only had a quick look so maybe wrong but I think this is due to model_discovery.py line 88, regex search deliberately grabs only content within parenthesis, resulting in model = 'AU':
if match := re.search(r"\(([^\(\)]+)\)$", str(device_entry.model)):
Can't add 'AU' as an alias as KP303(AU) is discovered as model=AU as well, presumably other kasa AU devices also are.
Sure I could brute force fix it but I assume the search is this way because some other devices required it and I wouldn't want to break them :)
Happy to provide further info or testing if it helps

Should be fixed in v1.1.0 now

Yeah looks good - they all discovered now :) thanks


Update WidgetsBinding.instance to remove  flutter 3.0 warn

Update WidgetsBinding.instance to remove "Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null." warn for flutter 3.0

Ah it's because I am using V2 that I don't get that issue

Successfully uploaded https://pub.dev/packages/another_xlider "1.1.2".


Update Samples to v0.67

Suggestion
Update Samples to v0.67.
Platforms
Windows
Sample code
No response

Checklist
Can be upgraded to 67:

[ ] Calculator
[ ] CalculatorNuGet
[ ] CameraDemo
[ ] NativeModuleSample

Can't be upgraded to 67:

AppServiceDemo
RssReader
TodosFeed

@TatianaKapos comment says the XAML Island sample in TodosFeed is not upgradable to 67. Does it mean, support for XAML Islands is not available with 67 as of now. If so, what is the roadmap for supporting XAML Islands.


Expose competition in campaign api

What's this PR do?
Exposes competition in campaign object with boolean value or null if not set.
How should this be manually tested?
Hit any /campaigns endpoint and campaigns object should return a line competitions under staff_pick.
{
  data: {
    id: "1736",
  title: "Test Title",
  campaign_runs: {
    current: {
      en: {
        id: "1902"
      }
    },
    past: [ ]
  },
  language: {
    language_code: "en",
    prefix: "us"
  },
  translations: {
    original: "en",
    en: {
      language_code: "en",
      prefix: "us"
    }
  },
  tagline: "Test CTA",
  status: "active",
  type: "campaign",
  created_at: "1445282953",
  updated_at: "1456252247",
  time_commitment: 0,
  cover_image: {
    default: null,
    alternate: null
  },
  staff_pick: false,
  competition: true,
...

What are the relevant tickets?
Fixes #6205

thanks for all the edits @weerd ! I'm getting this error Fatal error: Call to undefined function dosomething_campaign_is_competition() in /var/www/dev.dosomething.org/lib/modules/dosomething/dosomething_campaign/includes/Campaign.php on line 164
 but I think I did it correctly, following Signup.php and dosomething_signup.query.inc -- not sure why it can't get there?

@chloealee you'll need to include dosomething_signup.query.inc via the .module file, otherwise the module has no idea that file exists and when you call the dosomething_campaign_is_competition() function it has no idea where to look :scream:

@weerd ah doi!! Thanks!

Looks sweet! :+1:


feat(ci-plus): make upload-artifacts have a dynamic matrix

This also improves dist-manifest.json to include CI commands in its output, making it more like terraform

Gonna be hammering https://github.com/Gankra/cargodisttest with this for a while to test/experiment.

Closing in favour of #378


Vulnerability nickname

Identifying vulnerabilities by their CVE is tedious. Perhap we can create an option for a nickname that we either gather from the history, or that we name ourselves. We can display the name as "Fool's Errand aka CVE-2018-1234". That way people are driven to reading about a particular vulnerability that pops up time and time again.

So this is a full-stack change, but it's pretty minor. Here's what needs to change.

Allow for a "nickname" field on any YML file for a vulnerability
Add a field in the database, and load it in when we load the vulnerability
Fix the unit tests, because this will break our test data fixtures
Model should smartly concat the two together for "name"

So like:

If the nickname is empty, name is CVE
If the nickname is not empty (e.g "Foo"), name would be "Foo, aka CVE-2018-1234"

And then in various places we can format the CVE and nicknames as subtitles and titles where it makes sense.

Questions on this change:

Is allowing for the YML change in this repo or Chromium Vulnerabilities? (I remember this being over there but wanted to make sure)
Putting the changes in did not break the tests at all. Even adding the data to the fixture did not break any of the tests. Is this intentional?


[BUG]  Cmd + Shift + 'c' calls the 'c' GlobalHotKey handler

Describe the bug
The key sequence to active element selection in chrome (Cmd + Shift + 'c') is activating our 'c' hotkey handler.
How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc)
Using GlobalHotkeys
Expected behavior
Pressing Cmd + Shift + c should not activate the 'c' function in GlobalHotkeys because modifier keys are being pressed, and should instead just enable Chrome element selection.
Platform (please complete the following information):

Version: 2.0.0-pre4
Browser: Chrome
OS: OSX

Are you willing and able to create a PR request to fix this issue?
maybe?
correct me if this is the expected behavior and there's something that I can do to override/customize this.

Hi @snosenzo, thanks for filing your issue.
Unfortunately, this is indeed not surprising (and matches the intended behaviour of the package). If your problem was reversed, and you wanted the hotkey handler to override the browser handler, then I would direct you to the Preventing default browser behaviour section of the Readme.
However, your situation is a little messier and you will have to step outside or react-hotkeys for now ( a feature could be added in the future to declaratively do this). I suggest in your handler, you use the KeyboardEvent's meta property to abort executing whatever your handler does.
I'm closing this for now to help clarify the priority of outstanding issues that need to be addressed, but please let me know if you want to make a feature request to have this added to the library in perhaps a more scalable fashion (the approach above would need to be implemented for each individual handler function).

It may interest the reader to know that there is a ongoing similar discussion about when the longer key sequence is another application action, rather than a browser one: #161.

@snosenzo, the fix should be available in v2.0.0-pre7, so when you press cmd+shift+c, it won't trigger the c action.


WIP: cms_smime.c: remove misleading malloc failure message

Fixes #7418
(see https://github.com/openssl/openssl/issues/7418#issuecomment-430510171)

Switched to 'WIP', because I don't currently have the time to pursue it.

This pull request has been discontinued some time ago.


Fix markdown formatting

The markdown text was incorrectly formatted, and caused text to appear inside a code block.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Nice catch!


Migrated commons-lang usages to commons-lang3

Issue Link - https://github.com/apache/druid/issues/17130

looks great! I hope the tests will pass :)
thank you for taking care of this :)

there is check failing with some license issue
it seems like extensions-core/druid-ranger-security still refereces the old lib:
[INFO] org.apache.druid.extensions:druid-ranger-security:jar:32.0.0-SNAPSHOT
[INFO] +- org.apache.ranger:ranger-plugins-common:jar:2.4.0:compile
[INFO] |  +- commons-lang:commons-lang:jar:2.6:compile

Let me add back the license for commons-lang? It can be removed once the dependencies also migrate to commons-lang3.

@shigarg1 it seems like you don't have any email addresses associated with you github account; so the system would use the noreply email address for the commit<EMAIL_ADDRESS>Let me know if that's ok - or you could add one by following this guide

@kgyrtkirk Updated the email.

After some discussion with @clintropolis we've found that by fixing Druid to not use commons-lang2 ; in fact leads to older versions of commons-lang-2 to appear:

before/after commons-lang jar presences
dev@review:~/dist$ diff -U0  <(find orig/|cut -d/ -f2-|sort) <(find lang3/|cut -d / -f2-|sort)
--- /dev/fd/63	2024-09-27 08:41:47.230818152 +0000
+++ /dev/fd/62	2024-09-27 08:41:47.230818152 +0000
@@ -281 +281 @@
-apache-druid-32.0.0-SNAPSHOT/extensions/ambari-metrics-emitter/commons-lang-2.6.jar
+apache-druid-32.0.0-SNAPSHOT/extensions/ambari-metrics-emitter/commons-lang-2.5.jar
@@ -1018 +1017,0 @@
-apache-druid-32.0.0-SNAPSHOT/extensions/druid-redis-cache/commons-lang-2.6.jar
@@ -1194 +1193 @@
-apache-druid-32.0.0-SNAPSHOT/extensions/druid-thrift-extensions/commons-lang-2.6.jar
+apache-druid-32.0.0-SNAPSHOT/extensions/druid-thrift-extensions/commons-lang-2.4.jar
@@ -1383 +1382 @@
-apache-druid-32.0.0-SNAPSHOT/lib/commons-lang-2.6.jar
+apache-druid-32.0.0-SNAPSHOT/lib/commons-lang-2.4.jar

commons-lang:2.4 is being pulled into the sql module like this

parts of: mvn dependency:tree -pl sql
[INFO] +- org.apache.calcite:calcite-core:jar:1.37.0:compile
[INFO] |  +- net.hydromatic:aggdesigner-algorithm:jar:6.0:runtime
[INFO] |  |  \- commons-lang:commons-lang:jar:2.4:runtime

the net.hydromatic:aggdesigner-algorithm:jar:6.0:runtime is a pretty old artifact; and its only being used in the TileSuggester ; which is connected to Lattice ; I don't think we use those parts right now - so it could be excluded (along with lang-2)
retaining the lang-2.6 reference in the root pom.xml's dependencyManagement could ensure that other usages of lang-2 are upgraded to 2.6 (like before)

new diff
dev@review:~/dist$ diff -U0  <(find orig/|cut -d/ -f2-|sort) <(find lang3/|cut -d / -f2-|sort)
--- /dev/fd/63	2024-09-27 09:04:00.812205455 +0000
+++ /dev/fd/62	2024-09-27 09:04:00.812205455 +0000
@@ -1018 +1017,0 @@
-apache-druid-32.0.0-SNAPSHOT/extensions/druid-redis-cache/commons-lang-2.6.jar
@@ -1349 +1347,0 @@
-apache-druid-32.0.0-SNAPSHOT/lib/aggdesigner-algorithm-6.0.jar
@@ -1383 +1380,0 @@
-apache-druid-32.0.0-SNAPSHOT/lib/commons-lang-2.6.jar

proposed changes diff
diff --git pom.xml pom.xml
index 96dbfa6004..4fd3ca2a28 100644
--- pom.xml
+++ pom.xml
@@ -301,6 +301,11 @@
                 <artifactId>commons-logging</artifactId>
                 <version>1.1.1</version>
             </dependency>
+            <dependency>
+                <groupId>commons-lang</groupId>
+                <artifactId>commons-lang</artifactId>
+                <version>2.6</version>
+            </dependency>
            <dependency>
                <groupId>commons-net</groupId>
                <artifactId>commons-net</artifactId>
@@ -503,6 +508,10 @@
                     <groupId>com.google.guava</groupId>
                     <artifactId>guava</artifactId>
                   </exclusion>
+                  <exclusion>
+                    <groupId>net.hydromatic</groupId>
+                    <artifactId>aggdesigner-algorithm</artifactId>
+                  </exclusion>
                 </exclusions>
             </dependency>
             <dependency>

taking a look at all the jars in the dist tgz (-Pdist -Pbundle-contrib-exts); there are quite a few more deps for which different versions are present: protobuf,okhttp,okio,orc-core,kafka-clients ... and many more :scream:
find lang3/|grep jar|sed -r 's|.*/||'|sort|uniq

Thank you @shigarg1!


Adjust the loader position on PLP

Related Issues

closes #5101
Short Description and Why It's Useful

Adjust the loader position on PLP and add a loader for products as well.
Screenshots of Visual Changes before/after (if There Are Any)

Before:

After:

Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

@filrak, Thanks for your response. For the first loading, I can put it inside .sidebar, since it's rendered under .sidebar. However, for the second loading, it wraps the .products, so I don't think I can put it inside .products. If I put SfLoader inside .products, the loading animation will be prevented by v-if="!loading" in the .products div.
This is the image of page layout when rendering loading icons.

Should I put the .loading for products inside .main, since it can achieve the same visual effect without changing the structure of the page.

Yup, sounds good!

Hi @filrak , I have updated the CSS.

Thank you! Mergin in ;)
If you'd like to contribute more to next but can't find any suitable issues ping me on slack ;)