quit fails to clean up when using multi

~ $ node -v
v10.1.0
~ $ redis-server --version
Redis server v=3.0.6 sha=00000000:0 malloc=jemalloc-3.6.0 bits=64 build=687a2a319020fa42
~ $ lsb_release -a
LSB Version:	core-9.20160110ubuntu0.2-amd64:core-9.20160110ubuntu0.2-noarch:printing-9.20160110ubuntu0.2-amd64:printing-9.20160110ubuntu0.2-noarch:security-9.20160110ubuntu0.2-amd64:security-9.20160110ubuntu0.2-noarch
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.4 LTS
Release:	16.04
Codename:	xenial

Trying to get my head around the redis transaction stuff in order to support atomic events on small (json) objects (ratoms) using watch/multi. The initial code is working but client.quit() doesn't clean up any more:
const newRAtom = (ratom) => {
  const key = getRAtomKey(ratom);
  return new Promise((resolve, reject) => {
    const transaction = client.multi();
    transaction.watch(key);
    client.get(key, (err, value) => {
      if (err) reject(err);
      if (value) reject(key + ' already exists');
      else {
        transaction.set(key, stringify(ratom));
        transaction.exec((err) => {
          if (err) reject(err);
          else resolve(ratom)})}})})};

My theory is that the transaction (multi) ensures that other processes can't create a matching ratom in redis. This works in testing but once the above function has been used client.quit() fails to clean up the client so the javascript tests fail to terminate until -c is used to force an exit. This happens when the newRAtom promise resolves so transaction.exec has been called (and redis monitor shows the expected updates).

Would you be so kind and post a small self contained example that fully covers everything? Right now there is no quit command in your example, so it's hard to look into this.
Would you also please remove things like getRAtomKey, the promise wrapper and similar as it should not have any influence if there is indeed a bug in node_redis.
If there is a bug in your code you might stumble upon that while working on such a example :-)

quit is in the test code:
newRAtom(initialObject)
    .then((ratom) => console.log('new ' + test(ratom.content === initialObject.content)))
    .then(() => refreshRAtom({id: 'foo', type: 'test'}))
    .then((ratom) => processEvent({fn: () => Promise.resolve(newObject), ratom}))
    .then((ratom) => {console.log('process to three ' + test(ratom.content === 3)); return ratom})
    .then((ratom) => deleteRAtom(ratom))
    .catch(err => console.log('something went wrong: ' + err))
    .finally(() => quit());

which works fine and passes except for needing a  to get out of the code.
I will work up a complete minimal repro (there are quite a few files involved) in the next week or so.


size

https://lodash.com/docs/4.17.15#size

Go has built-in len function.
It have similar feature.


Fix for Issue #1280 "Deploying invalid chaincode gives unclear error"

Fix for Issue #1280
update to https://github.com/hyperledger/fabric/pull/1477
Description
changed message to the:
"'go get' failed with error\n"%s"\n", err, string(errBuf.Bytes()))
How Has This Been Tested?
deployments of  chaincode via co-located peer process in latest vagrant environment

from local filesystem: valid& compilable, non-compilable, missing
from http:valid& compilable, non-compilable, missing

Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[ ] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Sergey Pomytkin<EMAIL_ADDRESS>

See PR #1477 for discussion. LGTM. Thanks!

Thank you for this change! Having been fighting with errors related to go get I especially appreciate this improvement.


Autocomplete dropdown opened after losing focus

Reproduction
Steps to reproduce:

Go to https://stackblitz.com/edit/angular-1zzzix?file=app/autocomplete-simple-example.html
Click in the autocomplete so that the dropdown is opened.
Click in any of the chips.

Expected Behavior
The dropdown should close, as the autocomplete lost the focus.
Actual Behavior
The autocomplete dropdown remains open.
Environment

Angular: 8.2.9
CDK/Material: 8.2.1
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS

@jelbourn or @crisbeto I see the same behavior when clicking into an iframe. Will this fix handle that or should a new issue be opened?


nan fillvalue attributes written by xarray

I noticed that xugrid writes nan fillvalue attributes for variables without fillvalue defined. After a quick assessment I see that this is xarray behaviour and it is also happening in their code. A nan fillvalue does not make sense to me and it causes issues in some cases, like this one. In dfm_tools there is a workaround in place that pops nan fillvalue attrs upon reading, but I believe we should avoid writing them. It might be related to xarray not decoding default fillvalues if no fillvalue attribute is present. Either way, let's discuss what is expected/desired behaviour here.
The code below reads a D-FlowFM output which has no nan fillvalue attributes. When writing it with .to_netcdf() there are nan fillvalue attributes. I have tried this also with xugrid testdata, but those datasets already contain nan fillvalue attributes upon reading:
import dfm_tools as dfmt
import xarray as xr
import numpy as np

file_nc = dfmt.data.fm_curvedbend_map(return_filepath=True)
file_out = "temp_fillvals_map.nc"
ds_org = xr.open_dataset(file_nc)
ds_org.to_netcdf(file_out)
ds_out_xr = xr.open_dataset(file_out)

print("nan fillvalue attrs in original dataset:")
ds = ds_org
count_xr = 0
for varn in ds.variables:
    if '_FillValue' in ds[varn].encoding:
        if np.isnan(ds[varn].encoding['_FillValue']):
            print(varn, ds[varn].encoding['_FillValue'])
            count_xr += 1

print()

print("nan fillvalue attrs in dataset written by xugrid/xarray:")
ds = ds_out_xr
count_xr = 0
for varn in ds.variables:
    if '_FillValue' in ds[varn].encoding:
        if np.isnan(ds[varn].encoding['_FillValue']):
            print(varn, ds[varn].encoding['_FillValue'])
            count_xr += 1

Just checking @veenstrajelmer, does https://github.com/pydata/xarray/pull/8713 fix this issue?

I do not think so, this is about (lack of) precision of scale_factor attrs and is unrelated to {"_FillValue":np.nan} in the netcdf file attributes. I found the list of issues @Huite and myself collected a while ago. They are listed in this issue: https://github.com/Deltares/dfm_tools/issues/490

@JoerivanEngelen @veenstrajelmer Just stepping by from https://github.com/pydata/xarray/pull/8713. Correct, that PR won't fix this particular issue. But I'm aiming for solving the default fillvalue issue over at xarray, too. This is moving in small steps, though.

@kmuehlbauer thank you for clarifying this. We were considering to fix it in this package (prevent writing of _Fillvalue:np.nan attributes and add encoding of default fillvalues per datatype if no _FillValue is supplied, both in line with the cf-convention. Do you mean that this behaviour will in the future be taken care of by xarray? In that case we can indeed consider to temporarily put it in xugrid to anticipate future behaviour.


Internal updates

Codecov Report

Merging #1207 (b922711) into master (6256be0) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
- Coverage   99.04%   98.91%   -0.14%
==========================================
  Files          74       74
  Lines        5788     5802      +14
  Branches      965      965
==========================================
+ Hits         5733     5739       +6
- Misses         29       34       +5
- Partials       26       29       +3

Flag
Coverage Δ

unittests
98.91% <100.00%> (-0.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/schemathesis/cli/debug.py
100.00% <ø> (ø)

src/schemathesis/failures.py
100.00% <100.00%> (ø)

src/schemathesis/runner/events.py
100.00% <100.00%> (ø)

src/schemathesis/runner/serialization.py
97.56% <100.00%> (+0.03%)
:arrow_up:

src/schemathesis/_compat.py
77.77% <0.00%> (-11.12%)
:arrow_down:

src/schemathesis/extra/pytest_plugin.py
98.23% <0.00%> (-1.77%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.27% <0.00%> (-1.73%)
:arrow_down:

src/schemathesis/cli/cassettes.py
98.43% <0.00%> (-1.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6256be0...b922711. Read the comment docs.


CI/CD Pipeline enhancement and tag

related with https://github.com/sustainable-computing-io/kepler/pull/711
https://github.com/orgs/sustainable-computing-io/projects/2?pane=issue&itemId=28750581

Hi @jiere , @bradmccoydev, WDYT(what do you think)?

Anything OpenSSF guideline can help here too?

Can you just add in the document that we might follow openSSF in the future?
Maybe also describe what is missing right now?

Anything OpenSSF guideline can help here too?

But in this rfc, I still plan to use tag. or something may aline with OpenSSF.

Can you just add in the document that we might follow openSSF in the future? Maybe also describe what is missing right now?

Again, which part of openSSF? @marceloamaral if you mean https://bestpractices.coreinfrastructure.org/en/login or SBOM(#685) or ?


TieredRewards isn't working

TieredRewards option isnt working here's my config:
tieredRewards:
   10:
    - "cmd: crate givekey %player% epic 1"

Version: 1.17.1
Software: Airplane
Java Version: 16

Hi,
I'll release a patch within 30 minutes that fixes this problem.
I'll let you close the issue once you've checked the behavior :)
Sorry for the inconvenience,
Thanks for the review and the report! ❤


Can this test be uncommented?

https://github.com/ElementsProject/elements-miniscript/blob/b485f430591252cfd767cadc92c050d72f0baac2/src/psbt/finalizer.rs#L533
Is this comment referring to this fixed bug ? https://github.com/BlockstreamResearch/rust-secp256k1-zkp/pull/55
cc @sanket1729

Don't really remember much about this. I should have linked the which issue. I guess we can try and see.


Upgrade workflow : best practices

I want to know what are the best practices when developping multiple application using different version of angular 5 (as it's not always possible to update all applications at once)

is it save to always update angular-cli to the latest version, even if some projects are created with a lower version of the cli / angular ( 4 - 5)
is deleting the node_modules folder then reinstall all packages the only safe option to update angular version in a specific application?
can upgrading angular version and or local angular-cli in a project be made part of global angular-cli as a extra command?

Angular CLI 1.x supports Angular 2, 4 and 5. It should always be safe to update to a newer version of the CLI, barring known bugs.

You shouldn't need to delete node_modules. But it's common enough that different package manager versions do things differently. Also a lot of users aren't used to package locks and sometimes that makes updating dependencies harder. Also when linking npm packages a lot can go wrong with lockfiles. Personally, whenever I see something weird or unexpected happening, I clear node modules and the lockfile. But I have to deal with a lot of odd dependency problems so I don't think I'm the general case.

We're working on that on https://github.com/angular/angular-cli/pull/9321. It will be out in 1.7 final, right now we're still working out some bugs but you can try it out if you want in 1.7.0-beta.3.

Thx, that makes things a little be clearer. Hope 1.7 will land soon.

According to https://stackoverflow.com/questions/36597780/how-do-i-correctly-upgrade-angular-2-npm-to-the-latest-version one should upgrade angular applications using these instructions:

Angular Dep packages: npm install @angular/{animations,common,compiler,core,forms,http,platform-browser,platform-browser-dynamic,router}@latest --save
Other packages that are installed by the angular cli npm install --save core-js@latest rxjs@latest zone.js@latest
Angular Dev packages: npm install --save-dev @angular/{compiler-cli,cli,language-service}@latest
Types Dev packages: npm install --save-dev @types/{jasmine,jasminewd2,node}@latest
Other packages that are installed as dev dev by the angular cli: npm install --save-dev codelyzer@latest jasmine-core@latest jasmine-spec-reporter@latest karma@latest karma-chrome-launcher@latest karma-cli@latest karma-coverage-istanbul-reporter@latest karma-jasmine@latest karma-jasmine-html-reporter@latest protractor@latest ts-node@latest tslint@latest
Install the latest supported version used by the Angular cli (don't do @latest): npm install --save-dev<EMAIL_ADDRESS>
Is this true ? If so it would be nice if this could be improved. Will the new update command in angular-cli 1.7 be able to upgrade a project with all the latest versions ?

Thanks for reporting this issue. This issue was originally reported a long time ago and since then we've had many releases, one of which might have addressed this problem. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.

The new ng update should take care of all the updating as you described.


Same className in production at version 5.x

https://github.com/styled-components/babel-plugin-styled-components/issues/24
I think this bug appeared again in 5.x.
// file1
const Container = styled.div`xxxx`;

// file2
const Container = styled.div`xxxx`;

The above code is normal in the development environment of development.
But after production, they have the same className.

Having this right now as well. Maybe related with https://github.com/styled-components/babel-plugin-styled-components/issues/271 .
Interesting observation from our side:

we have some component files at src/features/... and some at src/common/....
we have a file at ./package.json but also at src/common/package.json. (This is because our src/common/ directory is actually a git subrepo that is shared between multiple projects.)
if we remove the src/common/package.json file, the problem disappears.

So maybe as described in https://github.com/styled-components/babel-plugin-styled-components/issues/271 , if there are components being built by several projects, then there's some hash collision happening in https://github.com/styled-components/babel-plugin-styled-components/blob/master/src/visitors/displayNameAndId.js#L95 ... Not sure, I might be completely wrong, but just adding our three cents.

Hello,
I have found a potential temporary fix for the issue.
I am using Next.js ^10.0.1, but the fix should be framework-agnostic.
First of all, install latest SSR compatible version of styled-components:
yarn add<EMAIL_ADDRESS>
Latest version, 5.2.2 faces ReferenceError: window is not defined error upon server-side rendering. You can track the status of the issue here: https://github.com/styled-components/styled-components/issues/3444
It looks like adding .withConfig({ componentId: "SOME-UNIQUE-ID" }) to the component whose class name is being duplicated and attached to the wrong component fixes the issue. Eg:
const Content = styled.div.withConfig({
  componentId: 'DrawerContentComponent' // pass unique componentId
})`
  min-height: 100%;
  display: flex;
  flex-direction: column;
`;

Warning:
styled-components docs do not mention componentId property in object passed to withConfig method. Therefore it should be treated as private and could break in the upcoming releases.
TypeScript users
For the same reason as mentioned above @types/styled-components do not define componentId config property, which requires type-casting to any:
const Content = styled.div.withConfig({
  componentId: 'DrawerProviderContent',
} as any)`
  min-height: 100%;
  display: flex;
  flex-direction: column;
`;


How to use nodegit with Pulumi/Typescript?

node -v
v12.12.0

npm -v # (or yarn -v)
6.11.3

node -e "console.log(process.platform)"
darwin

node -e "console.log(require('os').release())"
19.3.0

node -e "console.log(console.log(process.arch))"
x64

Hi! I am trying to use this package with Typescript in Pulumi, with the goal to clone a git repository. I am new to Typescript so I am having a hard time figuring out how to use nodegit with this..... I am trying the package @types/nodegit because I think I should be using this one with TS (?), but if I try to use nodegit  as described on nodegit.org, I get Value of type 'typeof Clone' is not callable. Did you mean to include 'new'?.
I am importing the package like this:
import * as Git from "nodegit"

and am trying to clone the repo like this:
const veleroChartRepo  = Git.Clone("https://github.com/vmware-tanzu/helm-charts.git", "/tmp/velero-chart")

If I do new Git.Clone then it complains that I am giving two arguments but none are expected.
Please be patient, I'm new to this 🗡
Thanks!

The typing in the typescript package is not official and is incorrect. NodeGit.Clone is a function. They may have set it up so only the alias NodeGit.Clone.clone is callable. Try leveraging the second signature and also open an issue with the @types/nodegit package.

Thanks @implausible !


[Feature Request]: Test Custom Serving Runtime User Interaction

Type of test
e2e Testing
Description
Add coverage for a full interaction flow of the Custom Serving Runtime interaction
Coverage
Adding a new Custom Serving Runtime

As an admin user
Navigate to the Custom Serving Runtime section
Click in "Add a new Serving Runtime" button
Fill a new Serving Runtime and click the "Add" button
The page should navigate back to the Custom Serving Runtime List and a new Custom Serving Runtime should be added at the bottom of the list.

Arranging and disabling Custom Serving Runtimes

As an admin user
Rearrange and disable some elements in the Custom Serving Runtime List
Create a new Project
Enable a Model Server
The list should only have the Serving Runtimes enabled
The list should have the elements sorted as the list

Moving to closed in favor of new quality initiative work.


Import fails

Expected behavior
The import should have run
Actual behavior
➜  node-firestore-import-export git:(master) node ./dist/bin/firestore-import.js --accountCredentials ~/Downloads/staging-cd6a5-firebase-adminsdk-771d4477a1.json --backupFile mb_staging.json
/Users/harit/bl/sources/webs/q2/node-firestore-import-export/dist/bin/firestore-import.js:55
    const [data, pathReference] = res;
          ^

SyntaxError: Unexpected token [
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:146:18)
    at node.js:404:3
➜  node-firestore-import-export git:(master)

Steps to reproduce the behavior

Checkout the codebase
Run the following commands

npm install && npm run build

export your data using README.md. This command works fine.
Import your data using README.md command. This fails.

➜  node-firestore-import-export git:(master) node ./dist/bin/firestore-import.js --accountCredentials ~/Downloads/staging-cd6a5-firebase-adminsdk-zk1to-771d4477a1.json --backupFile mb_staging.json
/Users/harit/bl/sources/webs/q2/node-firestore-import-export/dist/bin/firestore-import.js:55
    const [data, pathReference] = res;
          ^

SyntaxError: Unexpected token [
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:146:18)
    at node.js:404:3
➜  node-firestore-import-export git:(master)

Additionally, in README.md, the command for import has a typo, the second command import says export instead of import. Thanks

What versions of Node/NPM are you running?

I'm guessing it's a destructuring issue...if you're running node pre v6, that could cause problems.
Can you try changing the target to ES5 or ES3 in the tsconfig and then running npm run build again?
"target": "ES5"

Oh yes, Thanks a lot, @jloosli , that was the issue. I verified it by updating the node version. Additionally, I have seen a issue with the export-import. This is related to the type of the data. For example, the data type for a field was Timestamp, but when downloaded, it because String and during import, it was uploaded as String. This breaks the business logic to fetch the data.


Requests don't seem to be able to send dictionaries to eve

Hi,
I'm trying to use your demo example with the requests library. It does work fine when sending just the firstname and lastname. But not when sending the location dictionary.
payload = {'firstname': 'lapin',
           'lastname': 'lauvages3',
           'location': {'address': 'blabla', 'city': 'Paris'}}
r = requests.post('http://<IP_ADDRESS>:5000/people', data=payload)
print r.text
print r.url

{"_status": "ERR", "_issues": {"location": "must be of dict type"}, "_error": {"message": "Insertion failure: 1 document(s) contain(s) error(s)", "code": 422}}
http://<IP_ADDRESS>:5000/people

But it work fine with curl. I guess I'm missing something in the request code, but I really can't figure it out.
curl -d '{"firstname": "lapin", "lastname": "lauvage3", "location": {"address": "blabla", "city": "Paris"}}'  -H 'Content-Type: application/json'   http://<IP_ADDRESS>:5000/people

{"_updated": "Tue, 14 Apr 2015 08:14:01 GMT", "_links": {"self": {"href": "people/552ccc49bd84780289f8a607", "title": "person"}}, "_created": "Tue, 14 Apr 2015 08:14:01 GMT", "_status": "OK", "_id": "552ccc49bd84780289f8a607", "_etag": "88fe38b3d03967b1746c65a37acfb35531f87088"}

Do you have any idea what I'm doing wrong?
Thanks!

I have figured it out:
payload = {'firstname': 'lapin',
           'lastname': 'lauvages4',
           'location': {'address': 'blabla', 'city': 'Paris'}}
headers = {'Content-type': 'application/json; charset=utf-8'}
r = requests.post('http://<IP_ADDRESS>:5000/people', data=json.dumps(payload), headers=headers)
print r.text
print r.url

{"_updated": "Tue, 14 Apr 2015 08:35:52 GMT", "_links": {"self": {"href": "people/552cd168bd84780289f8a609", "title": "person"}}, "_created": "Tue, 14 Apr 2015 08:35:52 GMT", "_status": "OK", "_id": "552cd168bd84780289f8a609", "_etag": "e8c53dd08bc953757ef26af0d3c46e4eecc8e2a9"}
http://<IP_ADDRESS>:5000/people

:+1:


NoSQLBench workloads - auto token generation

Update JSON API NoSQLBench workloads to take advantage of automatic token generation.
Also includes minor changes to emulate improvements made to Docs API NB workloads under https://github.com/nosqlbench/nosqlbench/pull/1201
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

This has been tested with locally compiled version of nb5, but should not be merged until the release of NB 5.17.3.

This has been tested with locally compiled version of nb5, but should not be merged until the release of NB 5.17.3.

Actually this is not correct. Tests pass with NB 5.17.2, and this can be approved and merged. https://github.com/stargate/jsonapi/actions/runs/4708744043

The token is added only in the nosqlbench/http-jsonapi-crud-basic.yaml, other files don't have this change.. Will this be updated?

Good catch, thanks. I have pushed a fix so you can re-review.

FYI @maheshrajamani - I made a couple additional small improvements to address feedback from @ivansenic re-review.


Attempt to fix CI for non-Buoyant contributors

...by continuing even if coverage fails.
See https://circleci.com/gh/BuoyantIO/linkerd/1564 for an example of the kind of failure we're trying to avoid here.
Fixes #399.

lgtm

:star: 🌄


⚠ SceneTime has degraded performance

In fcaa0b5, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2949 ms

Resolved: SceneTime performance has improved in 501f1a1 after 6 minutes.


try to merge with upstream changes

I've fixed most of the conflicts, except for a big one which breaks the facet questionaire

@chaserx pardon the prototype kludge. src/ui/facet.js is pretty gnarly!

verbal +1 from @eeeschwartz


when move or copy is initiated, have dialog pointed towards source location

when dialog comes up after move or copy is requested, have it initialze to the current source location, right now it just shows the very top levels

also, a double click sets selected in the move/copy dialog, right now it does not.


实验结果差二倍

大哥，我就用中文了哈，你们在METR-LA上复线的结果自己心里不慌嘛？你自己按照步骤来，把结果复线一遍看看。实际结果比你给的预训练结果要差二倍左右吧！你们提前把测试集放在训练集中训练拿过来的是吗？

Thanks for the interests in this work and the feedback. You may find more details in this issue. https://github.com/liyaguang/DCRNN/issues/78
Hope this can help reproduce the results and feel free to update this thread if you have encountered issues.
(Use English to reply so it can possibly help more people who encounter similar problems)


Parse Variable declarations

Parse Variable Declarations
Description
This PR fixes a hole in the current evaluation.
Currently, the following code misses the incorrect class name:
const myStyles = 'bg-wrong-name';

const classNames = [
  {
    base: 'text-wrong-text',
    other: 'flex-no-layout'
  }
];

export function Item() {
  return <div className={clsx('bg-current')} />;
}

This update will identify the wrong class names in all variable declarations with string, object, or array values.
(It will also identify duplicate class names)

[UPDATE:] Expanded PR to include all TW-v3 rules AND expand callee behavior
I've been working on multiple changes for the plugin, the first of which were variable declarations. However, it got too entangled keeping them separate so I'm updating everything here.
The new callee behavior
The current callee behavior will treat things like clsx and cva as the same, when the are quite distinct.  In the case of clsx we want the following to fail:
clsx({
  'bg-wrong-class': 'w-full'
})

In the case of cva we want the following to fail:
cva(['w-full'], {
  variants: {
    good: 'w-auto',
    bad: 'w-random-value'
  }
})

To achieve this, the callees option has been updated to accept an object in addition to the current array. The object should take the form:
type CalleeType = {
  [<callee-name>: string]: 'key' | 'value'
}

The default values are:
{ classnames: 'key', clsx: 'key', ctl: 'value', cva: 'value', tv: 'value' }

Additionally, any existing array that is passed in will be converted to the new form. If the callee existing in the defaults, it will use the 'key'|'value' value from the defaults, otherwise it will default to 'value'.
This is a big update! Please provide any kind of feedback. We are actively using these changes in our projects by temporarily updating our eslint-plugin-tailwind dependencies to:
    "eslint-plugin-tailwindcss": "https://github.com/jd-carroll/eslint-plugin-tailwindcss#variable-declarations",

If you want to see these changes land, please help by contributing documentation and/or test cases. I have arguably spent too much time on creating these updates so I need to re-focus on other items. Either leave a message here or create a PR against my fork.
(❤ for all the effort that went into this plugin already)

Just bumped into code where duplicate class names were not detected:
cva(['w-full', 'w-full'], {
  variants: {
    good: 'w-auto',
    bad: 'w-random-value'
  }
})

Having two strings in the first argument is useful when they are long and we want to render them on separate lines. Example (imagine this inside cva):

It’d be great to see this PR reviewed @francoismassart 🙏


FFun(Fun{ArraySpace}) doesn't return periodic array space

The following behaviour is wrong:
f=Fun(t->[cos(t) 0;
sin(t) 1],[-π,π])
Fun(f,PeriodicInterval([-π,π]))

Not clear how this should be fixed.  The culprit is      FunctionSpace line 248
coefficients(Fun(x->Fun(f,a)[x],b))

The Fun() constructor is now overriden for Fun(::Fun{ArraySpace},S::FunctionSpace) to turn S to an ArraySpace.


tiny typo fix to add_an_exchange.md

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update

What is the current behavior? (You can also link to an open issue here)
spelled falce

What is the new behavior (if this is a feature change)?
false 😃

Other information:

nice project :)

:+1:


Select final web area to avoid devtools

On mac os, I was having an issue with browser.host which can be reproduced with the following steps.

put the following in a talon file:

browser.host: www.google.com
-
testing: app.notify("testing")

in firefox, open google.com
say "testing", verify you get the notification
open dev tools, focus another app, and then focused firefox again
say "testing", you will NOT get the notification

It seems that in this scenario browser.host context matcher is no longer respected. I hunted down the issue to this line.
My change is probably pretty brittle, but at least works on mac (the only operating system where this code applies) chrome and firefox.
Some slack discussion took place here: https://talonvoice.slack.com/archives/C9MHQ4AGP/p1724030602939929

Thanks for the help here. My talon/python environment is still somewhat broken, and without documentation of those APIs I just settled for the brittle solution. This is looking much better. On Mac, it works on both Firefox and Chrome for me. Hopefully it's all right that I used your code in my commit @nriley?

To be clear, yes it's fine if you use it!


Introduce initial support for Google's Palm2 chat model

This implementation does not use the upstream LangChain4j stuff, as we really really don't want to drag in the entire Google Vertex AI client.
This was done based on the API described here and Google's authorization library that was described here.

Closes: #476

P.S. Thanks to @glaforge for his help!

I'll follow this up with some more improvements and tests


Corrected "it's" to "its"

changed "it's" to "its"
What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Description
This just a typo, corrected "it's" to "its"

thanks


Jonah Lomu Rugby (SLES-00377) freezes on black screen after starting on PS2

tonyhax version: 1.3.1
Installation method: Copied across using wLaunchELF 4.43a to memory card
Entry point game: Tony Hawk's Pro Skater 4 (PAL, SLES-03954)
Console model: SCPH-39003
Integrity check: Yes
BIOS version: v5.0 03/19/02 E
Target game: Jonah Lomu Rugby (PAL, SLES-00377)
Bug explanation:
Game freezes on a black screen after displaying piracy notice. Issue occurs using original disc confirmed to be working correctly on same console when booting directly into disc. Suspecting a similar PS2-only issue to #24 as backup copies of the game load properly on an SCPH-102 (v4.5 E).

tonyhax-v1.3.5b.zip
This version does a much more thorough reinitialization of the memory on the PS2. Could you please try it and report back?

Tested using both original and backup copies; both working on SCPH-39003 with v5.0 BIOS.
Also now loading fully: Final Fantasy Tactics (SCUS-94221) and Soul Blade (SLUS-00240), but both require PS1VModeNeg for proper timing/aspect ratio.
Still unable to load Kurushi (SCES-00866) - see opening post of #24.

Perfect, glad this issue is fixed then!


Creation of aws credentials files does not function

When running jaws on a fresh system without the admin credentials setup yet you get the following error while after filling out all of the information for jaws new project
Error: ENOENT: no such file or directory, open '/Users/boushley/.aws/credentials'
    at Error (native)
    at Object.fs.openSync (fs.js:549:18)
    at Object.fs.readFileSync (fs.js:397:15)
    at Object.readFileSync (/Users/boushley/projects/jaws/node_modules/aws-sdk/lib/util.js:102:35)
    at Object.module.exports.profilesMap (/Users/boushley/projects/jaws/lib/utils/aws.js:73:38)
    at /Users/boushley/projects/jaws/lib/commands/new_project.js:231:37
    at tryCatcher (/Users/boushley/projects/jaws/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (/Users/boushley/projects/jaws/node_modules/bluebird/js/main/promise.js:507:31)
    at Promise._settlePromiseAt (/Users/boushley/projects/jaws/node_modules/bluebird/js/main/promise.js:581:18)
    at Async._drainQueue (/Users/boushley/projects/jaws/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (/Users/boushley/projects/jaws/node_modules/bluebird/js/main/async.js:133:10)
    at Immediate.Async.drainQueues [as _onImmediate] (/Users/boushley/projects/jaws/node_modules/bluebird/js/main/async.js:15:14)
    at processImmediate [as _immediateCallback] (timers.js:374:17)

I've got a branch that works past that on my fork however it then runs into a problem where the .aws/credentials file gets created but is empty.

Looks like fs.appendFileSync isn't behaving as we expect.

Tracked down the issue, util.writeFile isn't synchronous and we were treating it as such. Opened #153 that should resolve this.


lx-select multiselect mode dropdown scroll position resets

When using long list with lx-select in multiple mode with checboxes modifing any selection resets the list scroll position to start making batch selects quite inconvinient. I suspect it's got something to do with  ngrepeat having to redigest all the list but other then that have no idea where to start looking for the fix.

We've just released LumX v1.0.0rc1. This new version fixes the issue, so I'm closing it.


LAN SSL requirement

when trying to access a running chainlit over LAN (one box to another) an SSL transport is required
auth0-spa-js must run on a secure origin. See https://github.com/auth0/auth0-spa-js/blob/master/FAQ.md#why-do-i-get-auth0-spa-js-must-run-on-a-secure-origin for more information.
would it be possible to add a --share flag or other method to allow a LAN server to serve pages on a LAN without SSL requirement?

same issue

Should be fixed in the latest version 0.3.0. Please note that it contains breaking changes. We prepared a migration guide to make it easy for everyone.


all_pairs: get all pairwise indices, including 0?

I noticed that not all possible pairs are returned when I tried the all_pairs function and that even with threshold = 0.0, the lowest values are still above 0. Is there a possibility to get all pairwise similarities?

That's odd. It may be a bug. Can you post a code to reproduce this?

Sure, the minimal example below already returns an empty list instead of a list with one element.
sets = [[1,2,3], [4,5,6]]
pairs = all_pairs(sets, similarity_func_name="jaccard",
        similarity_threshold=0.0)
list(pairs)


Extension list does not always load

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:49:23.350Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

code-gnu-global
austin
0.2.1

cpptools
ms-vscode
0.10.0

csharp
ms-vscode
1.6.2

qub-xml
qub
0.3.0

This is an intermittent problem.  Sometimes it works and sometimes it doesn't.
Steps to Reproduce:

Clock on Extensions
Select Popular (or any other extension list to load from internet)
List does not populate

Are you behind a proxy?

Sorry.  I didn't get a notification for you response.  The answer to your question is... yes, I am behind a firewall.  However, I have provided proxy information and logon information in Code.  Still, sometimes the list doesn't load.

#22214


File upload path not correct

when I tried to upload a file from file module it will store a file in storage/app/files folder maybe it should be in storage/app/public/files folder
also, after this it shows a error
SQLSTATE[42S22]: Column not found: 1054 Unknown column '_url' in 'field list' (SQL: insert into `files` (`location`, `is_published`, `tags`, `details`, `_url`, `name`, `mime`, `size`, `order`, `user`, `updated_at`, `created_at`) values (files//536855d389c1453a4aa34c68204d0e2f.pdf, 1, Resume, , /cms/files, Rushabh Joshi - Resume.pdf, application/pdf, 67220, 0, 1, 2018-07-24 11:26:02, 2018-07-24 11:26:02))

The only thing I can determine with this error is that the config for the cms.forms.files is adding in the _url field, I cannot locate anywhere else in the latest version that would be causing that.
By default we don't assume you want to share all these files with website scanners which would find data in your public folders potentially.


Add support for mid-function epilogues on x86 that end in a non-local jump.

Add support for mid-function epilogues on x86 that end in a non-local jump.

The x86 assembly inspection engine has code to support detecting a
mid-function epilogue that ends in a RET instruction; add support for
recognizing an epilogue that ends in a JMP, and add a check that the
unwind state has been restored to the original stack setup; reinstate
the post-prologue unwind state after this JMP instruction.

The assembly inspection engine used for other architectures,
UnwindAssemblyInstEmulation, detects mid-function epilogues by
tracking branch instructions within the function and "forwards"
the current unwind state to the targets of the branches.  If
an epilogue unwinds the stack and exits, followed by a branch
target, we get back to the correct unwind state.  The x86
unwinder should move to this same algorithm, or possibly even
look at implementing an x86 instruction emulation plugin and
get UnwindAssemblyInstEmulation to work for x86 too.  I added
a branch instruction recognizier method that will be necessary
if we want to switch the algorithm.

Differential Revision: https://reviews.llvm.org/D62764
<rdar://problem/51074422>

@swift-ci test and merge


Clarification on Multiple Choice Question Handling in LM-Harness

I am currently exploring the internal workings of the LM-Harness library and am considering contributing to its documentation to help clarify some of its mechanisms for future users.
I have a query regarding the handling of multiple-choice questions (MCQs) within the library. From what I gather, each MCQ is broken down into separate inputs corresponding to each choice, and each is then evaluated by the model. Could you please confirm if my understanding is correct, and elaborate on how exactly the library processes these inputs to select the most probable answer?
To illustrate my question with an example:
Context: "For a physics exam:"
Question: "What is the speed of light?"
Choices:

A. "300,000 km/s"
B. "150,000 km/s"
C. "299,792 km/s" (Correct)
D. "None of the above"

As I understand it, the library constructs individual requests for each choice as follows, using task.py:972

"For a physics exam: What is the speed of light? A: 300,000 km/s"
"For a physics exam: What is the speed of light? B: 150,000 km/s"
"For a physics exam: What is the speed of light? C: 299,792 km/s"
"For a physics exam: What is the speed of light? D: None of the above"

Each of these inputs is then fed into the model. Could you clarify whether the library simply extracts the first token's response, or if there's a more complex mechanism at play involving the vocabulary to determine which choice is the most likely correct answer?
Then the answers are fed into the model.

For a physics exam: What is the speed of light? A: 300,000 km/s -> model

and output might look like this?
{'created':<PHONE_NUMBER>, 'model': 'llama3.1', 'usage': {'prompt_tokens': 82, 'completion_tokens': 58, 'total_tokens': 140}, 'choices': [{'index': 0, 'message': {'role': 'assistant', 'content': "That's correct! The speed of light in a vacuum is approximately 300,000 kilometers per second (km/s), which is equivalent to about 186,282 miles per second (mi/s). This is a fundamental constant in physics, denoted by the letter c. Well done!", 'function_call': None}, 'finish_reason': 'stop', 'logprobs': {'tokens': ['That', "'s", ' correct', '!', ' The', ' speed', ' of', ' light', ' in', ' a', ' vacuum', ' is', ' approximately', ' ', '300', ',', '000', ' kilometers', ' per', ' second', ' (', 'km', '/s', '),', ' which', ' is', ' equivalent', ' to', ' about', ' ', '186', ',', '282', ' miles', ' per', ' second', ' (', 'mi', '/s', ').', ' This', ' is', ' a', ' fundamental', ' constant', ' in', ' physics', ',', ' den', 'oted', ' by', ' the', ' letter', ' c', '.', ' Well', ' done', '!', '<|eot_id|>'], 'token_logprobs': [-0.33203125, -0.6328125, -0.7578125, -0.043945312, -0.0022125244, -0.00019073486, -3.2186508e-06, -7.1525574e-06, -0.38867188, -0.22558594, -8.821487e-06, -0.000111579895, -0.034179688, -0.0012207031, -0.5234375, -3.0994415e-05, -1.180172e-05, -0.036865234, -4.4107437e-06, -1.9669533e-05, -0.003967285, -0.004547119, -5.722046e-06, -1.9140625, -1.3203125, -0.011108398, -0.625, -3.2186508e-06, -2.328125, -0.00016212463, -0.0390625, -2.2411346e-05, -0.043945312, -8.8214874e-05, -5.2452087e-06, -0.0003414154, -0.43554688, -0.005218506, -1.0609627e-05, -0.1328125, -1.1796875, -0.58203125, -0.021240234, -0.00064468384, -0.004699707, -0.20214844, -0.0022125244, -0.8359375, -0.21386719, -5.9604645e-07, -0.0040893555, -0.0001745224, -0.1796875, -0.16601562, -0.30273438, -0.89453125, -0.00013256073, -0.035888672, -0.13671875], 'token_ids': [4897, 596, 4495, 0, 578, 4732, 315, 3177, 304, 264, 29302, 374, 13489, 220, 3101, 11, 931, 41668, 824, 2132, 320, 16400, 2754, 705, 902, 374, 13890, 311, 922, 220, 9714, 11, 16544, 8931, 824, 2132, 320, 8318, 2754, 570, 1115, 374, 264, 16188, 6926, 304, 22027, 11, 3453, 9437, 555, 279, 6661, 272, 13, 8489, 2884, 0, 128009]}}]}
Additionally, I am curious about how the library calculates the accuracy (ACC) from the log probabilities obtained for each choice. Specifically, are we considering the probability of the first token, or are we summing the probabilities across tokens? Could you direct me to the specific lines of code in the LM-Evaluation-Harness that handle this calculation, and provide a brief explanation of the method used?

Hi! I think this discussion should answer your question: https://github.com/EleutherAI/lm-evaluation-harness/issues/942
with respect to #2135, likelihood based tasks aren't supported with chat-completion endpoints as yet. I have made a PR to make that clearer. Also I don't think it's possible with the api you are using as it doesn't seem to support an echo like arg where the logprobs of the prompt (rather than the model generations) are returned.

yeah thats the main one. And not many APIs support echo with chat inputs tbf. together is the only one I know of. I don't think even vllm supports it with their chat-completions endpoint iirc.

@baberabb could you confirm if @monk1337  is right about the question formatting?
If yes, does that mean that harness will receive these options (phrases) individually and you get the likelihood of each option and then , the highest likelihood becomes the correct answer?


Added more scenarios

plane_search
plane_reserve
restaurant_reserve
restaurant_search
party_plan
party_rsvp
Schemas, user instruction templates/dbs, modified APIs. Tested that all APIs are functional.

Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨

@Shikib Actually, can you please first approve https://github.com/RasaHQ/ParlAI/pull/12 ? This fixes the make_scenarios.py script, which you then would have to run again.

@JEM-Mosig I'll merge this after you've merged #12

I just merged #12


Lag in chrome based browsers for duration of the value of the speed option

Has anybody been experiencing lags on chromium based browsers?
chrome:

safari:

Did you by accident perhaps put a css transition (delay) on the tilt element itself?

No, that's not it. I'm getting the same behaviour on http://gijsroge.github.io/tilt.js/ and https://openai.com/
In all cases I am NOT able to consistently produce this behaviour. 10% if the time, when a page has been loaded for a while, tilt will work without lag.
One difference being that on your site the lag occurs for the duration of the speed-value, where as on openai.com the lag stays indefinitely.

As you are expiriencing it on both sites, its probably a local issue because openai is not using tilt.js. I'm really not sure what it could be, sorry.

I had the same problem with lagging, after inspection I found out that I'm having a transition all on the same element as tilt.js, after removing the transition, lagging got better a lot


Flutter Http Headers Have Inconsistent names

I have an app that makes requests here and there and it doesn't work both on Web and on Android, because the header names are inconsistent. I have to do name checks with the ?? operator.
final response = await _client.post(
  'http://<IP_ADDRESS>:8080/login',
  body: jsonEncode({
    'email': email,
    'password': password,
  }),
  headers: {HttpHeaders.contentTypeHeader: 'application/json'},
);

switch (response.statusCode) {
  case 200:
    final authToken = response.headers['authorization'];
    prefs.setString('authToken', authToken);
    userSubject.add(authToken.toUser());
    return;
  default:
    throw Exception('Unknown error');
}

Web

Android

As you can see the names are inconsistent ("Authorization" vs "authorization").
On the web it used to work with "Authorization", but now it is not showing in the response headers either.
It shows me
Web

while in the network tab I have
Web

As you can see, there are a lot more response headers that I don't see in the map.
On Android on the other hand it is always "authorization" and it works.
Complete madness. This is strange, because I developed some of my app while compiling for the Web and when I switched to Android (dev experience) I started seeing this strange behavior.

Hi @DenisBarzanov
can you please provide your flutter doctor -v? Which version of http are you using?
Thank you

http package version
I am using the latest version of http (0.12.0+4). I have it left out blank: http:
flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0, on Linux, locale en_US.UTF-8)
    • Flutter version 1.18.0 at /home/denisbarzanov2002/flutter
    • Framework revision 8f7327f83a (13 days ago), 2020-04-06
      22:11:01 -0400
    • Engine revision 49891e0653
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 1210d27678)

[✓] Android toolchain - develop for Android devices (Android SDK
    version 29.0.2)
    • Android SDK at /home/denisbarzanov2002/Android/Sdk
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.2)
    • IntelliJ at /home/denisbarzanov2002/idea-IU-192.7142.36
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7402

[✓] VS Code (version 1.44.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.9.1

[✓] Connected device (2 available)
    • Chrome     • chrome     • web-javascript • Google Chrome
      79.0.3945.130
    • Web Server • web-server • web-javascript • Flutter Tools

• No issues found!

Hi @DenisBarzanov
Can you please upgrade to latest master channel and try again?
Thank you

Tried it on master, same thing. I will try it on beta later.
[✓] Flutter (Channel master, v1.18.0-6.0.pre.83, on Linux, locale en_US.UTF-8)
    • Flutter version 1.18.0-6.0.pre.83 at /home/denisbarzanov2002/flutter
    • Framework revision 8e5b575174 (17 hours ago), 2020-04-19 17:20:01 -0400
    • Engine revision 2b75c6d111
    • Dart version 2.9.0 (build 2.9.0-1.0.dev 4814f000de)

Still the same result. In the browser I see like 20 response headers and in the app I see just
{cache-control: no-cache, no-store, max-age=0, must-revalidate, content-length: 0, expires: 0, pragma: no-cache}

Hi @DenisBarzanov
This looks like http library dart issue, can you please raise this issue  on their GitHub
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you

Moved to here


fix: does not panic when errors occur during delete

Ref:

https://github.com/manifestival/manifestival/issues/92

I encountered a panic in my environment.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1162cb8]

goroutine 968 [running]:
k8s.io/apimachinery/pkg/apis/meta/v1/unstructured.(*Unstructured).GetKind(...)
	k8s.io/apimachinery@v0.22.5/pkg/apis/meta/v1/unstructured/unstructured.go:226
github.com/manifestival/manifestival.okToDelete(0x0)
	github.com/manifestival/manifestival@v0.7.1/manifestival.go:234 +0x38
github.com/manifestival/manifestival.Manifest.delete({{0xc000798000, 0x34, 0x40}, {0x1cca770, 0xc000288c30}, {{0x1ceb360, 0xc00014f470}, 0x0}}, 0x1cca770, {0x0, ...})
	github.com/manifestival/manifestival@v0.7.1/manifestival.go:179 +0xae
github.com/manifestival/manifestival.Manifest.Delete({{0xc000798000, 0x34, 0x40}, {0x1cca770, 0xc000288c30}, {{0x1ceb360, 0xc00014f470}, 0x0}}, {0x0, 0x0, ...})
	github.com/manifestival/manifestival@v0.7.1/manifestival.go:116 +0x1e5
knative.dev/operator/pkg/reconciler/common.Uninstall(0xc0006cf000)
	knative.dev/operator/pkg/reconciler/common/install.go:76 +0x278
knative.dev/operator/pkg/reconciler/knativeserving.(*Reconciler).FinalizeKind(0xc0004be620, {0x1cca658, 0xc000d4d740}, 0xc000594660)
	knative.dev/operator/pkg/reconciler/knativeserving/knativeserving.go:86 +0x365
knative.dev/operator/pkg/client/injection/reconciler/operator/v1alpha1/knativeserving.(*reconcilerImpl).Reconcile(0xc00021e1e0, {0x1cca658, 0xc000d4d710}, {0xc001266900, 0x19})
	knative.dev/operator/pkg/client/injection/reconciler/operator/v1alpha1/knativeserving/reconciler.go:240 +0x518
knative.dev/pkg/controller.(*Impl).processNextWorkItem(0xc000a9c660)
	knative.dev/pkg@v0.0.0-20220126214246-d7b329c36019/controller/controller.go:542 +0x5a5
knative.dev/pkg/controller.(*Impl).RunContext.func3()
	knative.dev/pkg@v0.0.0-20220126214246-d7b329c36019/controller/controller.go:478 +0x68
created by knative.dev/pkg/controller.(*Impl).RunContext
	knative.dev/pkg@v0.0.0-20220126214246-d7b329c36019/controller/controller.go:476 +0x2de

Release Note

NONE

/kind bug

@l-qing
Please join the list of contributors, so that we do not need the ok-to-test label any more.
This is an example: https://github.com/knative/community/pull/1264/files
You can also add your company as adopter: https://github.com/knative/community/pull/1309

/ok-to-test

/retest

Hi @houshengbo, I solved the unit test failure problem. Could you please help review it again? Thanks!

@l-qing Please join the list of contributors, so that we do not need the ok-to-test label any more. This is an example: https://github.com/knative/community/pull/1264/files You can also add your company as adopter: knative/community#1309

Thank you for your suggestion and invitation. I'll consider it.

/retest

maybe just run "./hack/update-codegen.sh" to catch up the changes.

maybe just run "./hack/update-codegen.sh" to catch up the changes.

That's exactly as you said.
Run # From: https://backreference.org/2009/12/23/how-to-match-newlines-in-sed/
Found diffs in: vendor/k8s.io/code-generator/generate-groups.sh
vendor/knative.dev/pkg/hack/generate-knative.sh
Error: Please run ./hack/update-codegen.sh.
diff --git a/vendor/k8s.io/code-generator/generate-groups.sh b/vendor/k8s.io/code-generator/generate-groups.sh
old mode 100755
new mode 100644
Error: Please run ./hack/update-codegen.sh.
diff --git a/vendor/knative.dev/pkg/hack/generate-knative.sh b/vendor/knative.dev/pkg/hack/generate-knative.sh
old mode 100755
new mode 100644
knative/operator is out of date. Please run hack/update-codegen.sh
Error: Process completed with exit code 1.

I'm just curious, why does it take so many impacts to modify one line of code? 😁

/retest

/retest

/lgtm

The prow CI checks every pr in terms of whether it has the latest manifests and dependencies.
When there is a mismatch, you have to update your pr accordingly.

/retest

/retest

Due to this issue, the CI task has currently failed and I have no choice but to wait for a longer period of time.

https://github.com/knative/toolbox/pull/7#issuecomment-1500139701
https://github.com/knative/toolbox/pull/9#issuecomment-1500216080

@l-qing Currently prows across many knative projects have run into the same issue. We need to fix it first, before merging this pr.

/retest

Hi @houshengbo, my CI tasks passed. Could you please give it an LGTM label when you have time? Thanks!

/lgtm

/lgtm

Thanks!


Preload images

The feature that automatically preloads the external image as url in project.json is speculated to enhance the user experience.

Then, the initial loading time will be longer, and it may even seem like the loading has stopped. It can't be said to necessarily enhance the user experience. Despite all these drawbacks, if you still want this feature, I will consider adding an option in the global settings to turn it on/off.


fix(labs/virtualizer): check for null controller when correcting scroll error

Fixes #4182 by adding a check that the controller is not null.  At the risk of being slightly out of scope, also:

Allow null controller and observers on disconnect (if they were never setup properly on connection, you'd still want the benefits of a full cleanup instead of throwing)
Removed a couple of unnecessary non-null assertions

PS - Looks like there was supposed to be a PR template, but the field was just filled with "...LL error" for me

PS - Looks like there was supposed to be a PR template, but the field was just filled with "...LL error" for me

I think that was just the end of your commit message

This looks like a great change to me. I'd like to give Gray a chance to review in case there's some subtlety where we'd rather fail on a missing controller here

Oh, please add a changeset by running npm run changeset at the root of the monorepo

These changes may indeed be good, but if possible I'd like to understand better how it is that the virtualizer in HomeAssistant ends up in a state where it has no ScrollerController but is trying to correct a scroll error, and ideally I'd like to come up with a minimal repro case so that we can write a test or two.
My guess is that the virtualizer is being disconnected somewhere in the chain of events and then subsequently responds to an async scroll error message (perhaps triggered by a MutationObserver callback) that no longer applies. If this is the case, there may be a spot earlier in the codepath where we can short-circuit, rather than getting all the way into _correctScrollError() without a controller in place.

It's originating from the children resize observer, and it certainly occurs only after a disconnect.  It's possible the items get removed before the virtualizer element is fully disconnected (and maybe that observer isn't considering that situation?).  I don't quite understand that callback enough at the moment and probably not the best to come up with a minimal test.  Here's the longer stack trace:
Uncaught (in promise) TypeError: this._scrollerController is null
_correctScrollError
Virtualizer.ts:741

_finishDOMUpdate
Virtualizer.ts:546

_updateDOM
Virtualizer.ts:538

_handleLayoutMessage
Virtualizer.ts:603

_layout
Virtualizer.ts:441

_sendStateChangedMessage
BaseLayout.ts:478

_reflow
BaseLayout.ts:364

_reflow
flow.ts:491

reflowIfNeeded
BaseLayout.ts:257

_updateLayout
Virtualizer.ts:563

_schedule
Virtualizer.ts:520

_measureChildren
Virtualizer.ts:501

_childrenSizeChanged
Virtualizer.ts:888

_initObservers
Virtualizer.ts:275

connected
Virtualizer.ts:287

_makeVirtualizer
virtualize.ts:130

_initialize
virtualize.ts:141

update
virtualize.ts:91

Given that, I suppose another solution would be to change the order in disconnected(), so that the observers are disconnected before _scrollerController is detached, but maybe that's a distinction without much of a difference?

Thanks for the additional info, @steverep. I'll play around a bit and see if I can come up with a minimal repro, though I may have to come back to you with followup questions.

@steverep I expect to have time to dig into this later today, but two quick questions:

Does this happen to be reproducible in the Home Assistant demo deployment, where I can easily see it?
Would it be easy to point me to the relevant source files in the Home Assistant repo?

1. Does this happen to be reproducible in the Home Assistant demo deployment, where I can easily see it?

Unfortunately, it is not.  Most if not all the virtualizers are in the settings area which isn't in the demo.

2. Would it be easy to point me to the relevant source files in the Home Assistant repo?

Yes, of course.  The repro I am using comes from the virtualizer in our ha-data-table component.  Sorry, it's one of the more complicated components though.
Essentially, the repro goes like this:

Scroll it
Click a row which brings you to another page in the SPA (removes the virtualizer from DOM)
Click another link in the new page to navigate again, then error is in the console

Let me know if I can test anything for you.

@cintaccs In your case (as described in #4238), can you explain how and why the virtualizer is being destroyed / disconnected when the data provided by the containing view changes? I would expect the virtualizer to rerender, but not disconnect.

FWIW, I took a closer look at this today.  If I'm reading the ResizeObserver spec correctly, calling disconnect on the RO should theoretically guarantee the callbacks have all returned since everything is done in the event loop.  That doesn't include anything spawned asynchronously of course, which the _childrenRO does.
The deeper problem seems to be that in _finishDOMUpdate, which is within the asynchronous part of the callback, _childrenRO.observe() is being called.  So the RO is is disconnected, only to just start observing again if that stuff hasn't finished.  Indeed if I set this._childrenRO = null after disconnecting, I get the following error instead:
Uncaught (in promise) TypeError: this._childrenRO is null
    _finishDOMUpdate Virtualizer.ts:545
    _finishDOMUpdate Virtualizer.ts:545
    _updateDOM Virtualizer.ts:542
    _handleLayoutMessage Virtualizer.ts:605
    _layout Virtualizer.ts:449
    _sendStateChangedMessage BaseLayout.ts:478
    _reflow BaseLayout.ts:364
    _reflow flow.ts:491
    reflowIfNeeded BaseLayout.ts:257
    _updateLayout Virtualizer.ts:566
    _schedule Virtualizer.ts:524
    async*set items Virtualizer.ts:252
    _updateVirtualizerConfig virtualize.ts:107
    update virtualize.ts:89
...

Note the RO callback is not in the trace this time.  It's coming from an earlier call to update the DOM.

@steverep Yes, I believe the problem is that something in application code (probably related to the mechanism for switching between views as the user navigates) is causing the virtualizer to kick off an update cycle after it has been disconnected.
In trying to create a minimal repro was, I have tried various ways of toggling between a view with a virtualizer and a view without a virtualizer. However, the only way I've been able to end up in _correctScrollError without a ScrollerController present is really contrived: I intentionally trigger a virtualizer update (by setting its items property to a different value) at the same time as I'm triggering the view update that will cause the virtualizer to be disconnected.
The following Playground example illustrates. If you run it as-is (with the Console open to view log statements) and click the Toggle button, everything is fine. But if you uncomment line 35 and then toggle, you'll see we end up in _correctScrollError without a controller.
The good news is that it should probably be fairly straightforward to short-circuit the virtualizer update cycle in the case where it is not currently connected.
However, I would still like to see if we can figure out what it is in the Home Assistant code (and in @cintaccs app) that triggers a virtualizer update after disconnection so that we can make some more realistic tests.
I do see that there's a set items in your stack trace. Do you know why that would be happening after (or concurrently with) the view change that causes the virtualizer to disconnect?

@graynorton based on my testing, I would suggest you set this._childrenRO = null per my last reply.  I find that the problem is much more reproducible after doing that.

In trying to create a minimal repro was, I have tried various ways of toggling between a view with a virtualizer and a view without a virtualizer. However, the only way I've been able to end up in _correctScrollError without a ScrollerController present is really contrived: I intentionally trigger a virtualizer update (by setting its items property to a different value) at the same time as I'm triggering the view update that will cause the virtualizer to be disconnected.

Yeah, I think that's more or less what is happening.

I do see that there's a set items in your stack trace. Do you know why that would be happening after (or concurrently with) the view change that causes the virtualizer to disconnect?

Nope, the only thing I've narrowed down is that it only seems to error when we have the data filtered, and that means a web worker is involved in returning the reactive property that holds the items.  Although I don't immediately see why that would be a problem.
I'll amend my last post with the full stack trace.  It actually seems to be looping inside lit for a couple update cycles, so maybe the items were actually set long before? 😕

The good news is that it should probably be fairly straightforward to short-circuit the virtualizer update cycle in the case where it is not currently connected.

I'm looking at how to implement that, but how far upstream which would still be safe is not obvious to me.  Certainly stopping at the start of this._updateDOM would work, but are you thinking further?

@cintaccs In your case (as described in #4238), can you explain how and why the virtualizer is being destroyed / disconnected when the data provided by the containing view changes? I would expect the virtualizer to rerender, but not disconnect.

The virtualizer is within a child component of the page that is being refreshed. In order to ensure that the content is really refreshed one of the parents are re-created. In some earlier lit versions at least - this was the only way I could figure out to get the page to refresh. Later the virtualizer was introduced in the child list component. (where the list component is a child of the page component...).
From my point of view - I wouldn't consider it bad to check for existence before destroying .... I guess destroy could happen for a lot of difference reasons - navigating away etc.

@cintaccs thank you for your response!

The virtualizer is within a child component of the page that is being refreshed. In order to ensure that the content is really refreshed one of the parents are re-created. In some earlier lit versions at least - this was the only way I could figure out to get the page to refresh. Later the virtualizer was introduced in the child list component. (where the list component is a child of the page component...).

From what you've reported, it seems most likely that the "old" virtualizer (the descendant of the ancestor view that is being replaced) is somehow receiving property updates that trigger it to re-render, despite no longer being present  in the document's DOM tree. This is a case we should be handle better regardless, but I would still like to understand as clearly as I can the patterns that cause it to occur and write minimal but realistic tests representing these patterns. With that goal in mind, here are a couple of follow-up questions for you:

Am I understanding correctly that the ancestor element is not just re-rendered, but actually destroyed and recreated? How is this achieved?

By what means does the virtualizer receive its data? For instance, is the items property simply populated by properties flowing down the tree of rendered components, or is the virtualizer (or a detached ancestor) subscribed to async updates via some other means?

@steverep Thanks for your continued work on this!

I'm looking at how to implement that, but how far upstream which would still be safe is not obvious to me. Certainly stopping at the start of this._updateDOM would work, but are you thinking further?

I am actually thinking of stopping it earlier. I suspect when we arrive in _updateDOM() in the error case, we have probably already rendered children unnecessarily, and we'd like to avoid doing that. I haven't dug in to the specifics yet, but my sense is that we want to check in or before _updateLayout() whether we're connected, and only kick off the render cycle if we are.
I actually have a bit of time this afternoon, so I'll pull down this branch and take a closer look.

@steverep I actually didn't end up pulling this branch because I wanted to see if short-circuiting rendering at the _updateLayout() stage solved the problem entirely (with no other changes).
Working from main, I made the following changes:

As far as I can tell, this takes care of both #4182 and #3831. Would you mind checking against Home Assistant?

@graynorton could you please provide that diff in text instead of an image?  I'm blind and OCR ain't perfect.

@steverep My apologies—of course! The screenshot was a dumb way to share the diff in the first place.
diff --git a/packages/labs/virtualizer/src/Virtualizer.ts b/packages/labs/virtualizer/src/Virtualizer.ts
index f7fb07c8..7ba732f8 100644
--- a/packages/labs/virtualizer/src/Virtualizer.ts
+++ b/packages/labs/virtualizer/src/Virtualizer.ts
@@ -549,8 +549,16 @@ export class Virtualizer {
     }
   }

+  _shouldUpdateLayout() {
+    // Only update the layout and trigger a re-render if we have...
+    //   a) A layout
+    //   b) A scrollerController, which means we're connected
+    //   c) An offsetParent, which means we're not hidden
+    return this._layout && this._scrollerController && this._hostElement?.offsetParent;
+  }
+
   _updateLayout() {
-    if (this._layout) {
+    if (this._shouldUpdateLayout()) {
       this._layout!.items = this._items;
       this._updateView();
       if (this._childMeasurements !== null) {

@graynorton I can test with HA later tonight and let you know.
Regarding no other changes, correct me if I'm missing something, but wouldn't the changes in this branch still be necessary as a safeguard?  Your change may catch most issues, but it doesn't guarantee the timing, i.e. a disconnect can still happen after that checkpoint.

@steverep I don’t believe so, if everything is working as designed. The fact there is no guard code there is actually intentional, so we don’t inadvertently mask more serious issues, like the unnecessary render that #4182 revealed.
We can and should still remove the truly redundant non-null assertions you noticed in other spots, though.

@steverep I’ll add that I’m very much open to being proven wrong, but before we go and guard against it on a blanket basis, I’d really like to have a concrete, understandable repro that shows how a disconnection might occur in the middle of a virtualizer update cycle. I believe the timing of the mutation and resize observers makes this unlikely or impossible, but I’m not 100% sure.

@graynorton I tested HA last night and was unable to reproduce the error with just your change.  👍🏻
I'll admit my gut is still telling me the timing cannot be guaranteed once _updateDOM fires, but I'll defer to your judgement as you obviously understand the code much better than me.  Time will tell anyway, because if there's a way to break it, HA users will find it. 😉
To that end, I reverted the controller and observer checks here.  The only thing I kept (other than the removal of non-null assertions) was nullifying the the observers on disconnect.  I would argue that's still a worthwhile change as, to your point, it would cause earlier failures after a disconnect by making sure re-observations cannot occur (as was happening here with _childrenRO).
Do you want to add your change here or shall I change the commit message to reflect it as is?

@cintaccs thank you for your response!

The virtualizer is within a child component of the page that is being refreshed. In order to ensure that the content is really refreshed one of the parents are re-created. In some earlier lit versions at least - this was the only way I could figure out to get the page to refresh. Later the virtualizer was introduced in the child list component. (where the list component is a child of the page component...).

From what you've reported, it seems most likely that the "old" virtualizer (the descendant of the ancestor view that is being replaced) is somehow receiving property updates that trigger it to re-render, despite no longer being present in the document's DOM tree. This is a case we should be handle better regardless, but I would still like to understand as clearly as I can the patterns that cause it to occur and write minimal but realistic tests representing these patterns. With that goal in mind, here are a couple of follow-up questions for you:

Am I understanding correctly that the ancestor element is not just re-rendered, but actually destroyed and recreated? How is this achieved?
By what means does the virtualizer receive its data? For instance, is the items property simply populated by properties flowing down the tree of rendered components, or is the virtualizer (or a detached ancestor) subscribed to async updates via some other means?

hmm.. I wish it was simple to answer.
The challenge here is that in the original design of components (early lit days) I had issues triggering a re-render when switching views on the same data model (i.e. switching from cards to list view on the same data - OR - switching in-between different sets of filters for the listings). Also the UI is created to not flicker blank white pages so the header will stay the sub-header might stay - the body of the list will either refresh or be replaced with another type of view etc.
In general I am using the properties of the lit element class components - normal use I would think - however some of these properties are either ARRAYs or OBJECTS and also might be delayed with a event UP and await down flow...
The virtualizer is not subscribing in itself to this - it just knows the items array ...

Thanks, @steverep!

To that end, I reverted the controller and observer checks here. The only thing I kept (other than the removal of non-null assertions) was nullifying the the observers on disconnect. I would argue that's still a worthwhile change as, to your point, it would cause earlier failures after a disconnect by making sure re-observations cannot occur (as was happening here with _childrenRO).

Agreed!

Do you want to add your change here or shall I change the commit message to reflect it as is?

I am flexible on this. I guess it might be somewhat simpler to go ahead and land your improvements first, then have me make a follow-up PR with my change (and likely also some new tests)—only because that way, we don't need to worry about permissions for me to push to your fork, etc.
Another possibility would be for you to just go ahead and apply my patch to your fork so that it ends up here; that would be fine with me if it works for you. Just let me know what you prefer!
Regardless, I personally won't have much time with my computer for the next few days, as I'm about to head out on a trip. I'm hoping there will be some downtime that I can spend to advance this, but in the worst case it would be next Tuesday or Wednesday before I was able to get back to it. I should be able to keep my eye on the discussion here, though.

@cintaccs

hmm.. I wish it was simple to answer.

No worries! Thanks for the additional background. I suspect that the changes Steve and I have identified in this PR will fix the issue for you as well. If it would be feasible for you to try applying my patch to your local setup, that would be great. But if not, that's fine—you can wait until the changes land and let us know if you're still seeing the problem then.

Whenever this is merged and released, it's now going to be difficult to incorporate without first upgrading to lit 3.0.  The choice to only have a patch release 2.0.8 after updating the lit dependency doesn't make sense to me.

@steverep

The choice to only have a patch release 2.0.8 after updating the lit dependency doesn't make sense to me.

Can you explain what you mean here? Making this a minor release wouldn't help, would it?

Can you explain what you mean here? Making this a minor release wouldn't help, would it?

No, this PR should definitely only be a patch.  My point was that the just released 2.0.8 now has a direct dependency on lit 3.0, with no inclusion of 2.x versions.  That makes it a breaking change IMO, and the new virtualizer version should have been 3.0 (unless it still supports lit 2.0 in which case the manifest should be updated).
Right now, you cannot update to 2.0.8 without also updating lit to 3.0 unless you bundle 2 different lit versions which I wouldn't dare do (https://github.com/home-assistant/frontend/pull/18206).

That makes it a breaking change IMO, and the new virtualizer version should have been 3.0 (unless it still supports lit 2.0 in which case the manifest should be updated).

Agreed. I went ahead and merged this PR; will make a separate one to update the version range for the lit dependency.


Issue: Moving CLI Application to another branch

As a developer on this project, I want to move the CLI application code that has been created so far into a new branch called chirp_cli. So that it is still kept somewhere so that the teachers and censors can assess our project work at the end of the course. Our main branch will contain the new Razor Page Chirp that we are going to continue developing.
Acceptance Criteria
Having the CLI application code in a different branch.
New branch is called chirp_cli.
Main branch contains the Razor Page Chirp instead.
Definition of Success
The main only contains the new razor page chirp.

We have moved the CLI application before and after server implementation unto 2 branches so we can focus on getting back up to speed. For now, they'll be protected


FLOPs Reduction & Calculation

I am particularly interested in understanding the mechanisms behind the reduction in GFLOPS achieved by the adaptive computation framework, and I have some questions I was not able to clarify myself:
My understanding is that GFLOPS are primarily tied to the number of computations performed, including matrix multiplications. However, I am unclear about how the reduction in the number of tokens affects the GFLOPS calculation, especially when the dimensions of the input tensors remain the same and the unused tokens are assigned a value of 0.
in act_vision_transformer.py file:
class VisionTransformer(nn.Module):
      def forward_features_act_token(self, x):
            #assigned a value of 0
            out.data = out.data * mask_token.float().view(bs, self.total_token_cnt, 1)

class Block_ACT(nn.Module):
        def forward_act(self, x, mask=None):
              # original dimensions multiplication without reduction of dimensions
              x = x + self.drop_path(self.attn(self.norm1(x*(1-mask).view(bs, token, 1))*(1-mask).view(bs, token, 1), mask=mask))
              x = x + self.drop_path(self.mlp(self.norm2(x*(1-mask).view(bs, token, 1))*(1-mask).view(bs, token, 1)))

Could you kindly provide insights into how the adaptive computation framework in A-Vit leads to GFLOPS reduction, even when the token dimensions are unchanged?
Could you elaborate on how you measure your GFLOPS?
Thanks in Advance.

Actually, the author simply omits the token that is halted when in inference. But that cause a another question that omiting tokens will lead to different tensor shape between samples so that it is impossible to include them in one batch. So it is impossible to calculate with a batch size 64 or what.


I can train the model, but when it comes to testing or evaluating it, I encounter the error message: 'RuntimeError: CUDA error: no kernel image is available for execution on the device.'

I run on Tesla P100.
Environment

torch   1.8.1+cu111
python 3.8
cuda 11.1

When running train.py, I encountered an error. It appears that training has completed successfully, but when it transitions to the evaluation phase, the following error occurs: 'RuntimeError: CUDA error: no kernel image is available for execution on the device.
Error!
Traceback (most recent call last):
  File "test.py", line 210, in <module>
    main()
  File "test.py", line 206, in main
    eval_single_ckpt(model, test_loader, args, eval_output_dir, logger, epoch_id, dist_test=dist_test)
  File "test.py", line 65, in eval_single_ckpt
    eval_utils.eval_one_epoch(
  File "/opt/data/private/cyl/OpenPCDet/tools/eval_utils/eval_utils.py", line 65, in eval_one_epoch
    pred_dicts, ret_dict = model(batch_dict)
  File "/root/miniconda3/envs/pcdet/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/opt/data/private/cyl/OpenPCDet/tools/../pcdet/models/detectors/pointpillar.py", line 21, in forward
    pred_dicts, recall_dicts = self.post_processing(batch_dict)
  File "/opt/data/private/cyl/OpenPCDet/tools/../pcdet/models/detectors/detector3d_template.py", line 271, in post_processing
    recall_dict = self.generate_recall_record(
  File "/opt/data/private/cyl/OpenPCDet/tools/../pcdet/models/detectors/detector3d_template.py", line 308, in generate_recall_record
    iou3d_rcnn = iou3d_nms_utils.boxes_iou3d_gpu(box_preds[:, 0:7], cur_gt[:, 0:7])
  File "/opt/data/private/cyl/OpenPCDet/tools/../pcdet/ops/iou3d_nms/iou3d_nms_utils.py", line 69, in boxes_iou3d_gpu
    max_of_min = torch.max(boxes_a_height_min, boxes_b_height_min)
RuntimeError: CUDA error: no kernel image is available for execution on the device
eval:   0%|

I have verified that my Torch is accessible via CUDA by conducting the following test:
import torch
import sys
print('A', sys.version)
print('B', torch.__version__)
print('C', torch.cuda.is_available())
print('D', torch.backends.cudnn.enabled)
device = torch.device('cuda')
print('E', torch.cuda.get_device_properties(device))
print('F', torch.tensor([1.0, 2.0]).cuda())

I would like to know if this is due to the Tesla P100 not being suitable for this project? Is there any solution available for this situation?
Thank you all for your help.

When I replaced the GPUs in the cluster with 2080ti, the test ran smoothly. As it stands now, the issue seems to be that the Tesla P100 cannot run the test. (Although this is the most aggressive solution, at least it solved the problem.)

When I replaced the GPUs in the cluster with 2080ti, the test ran smoothly. As it stands now, the issue seems to be that the Tesla P100 cannot run the test. (Although this is the most aggressive solution, at least it solved the problem.)

Did you set the TORCH_CUDA_ARCH_LIST manually?
I also got this error msg when I didn't install spconv properly. I am running it on RTX5000 rn.


new(vx-react-spring): add package + AnimatedAxis

:rocket: Enhancements
~This PR adds a new AnimatedAxis component to @vx/axis and the needed react-spring dependency. The surface area is pretty minimal because only ticks are animated so we can fully re-use Axis/AxisBottom/etc and override a new ticksComponent prop which defaults to the old behavior.~
~I'm a little conflicted because generally vx is not opinionated on animation libraries and we don't want to bloat bundle sizes. However, the incentive for this comes from the XYChart POC in #745 where we would like to support animation if users opt in for it. So, we could either~
~a) simply add the needed Axis hooks (ticksComponent) to enable this cleanly, and keep AnimatedAxis in XYChart. or~
~b) add it to @vx/axis to let users opt into using it. It shouldn't affect bundle sizes if consumers use tree shaking or deep imports~
~To make b) a bit cleaner we could consider~

~avoid exporting AnimatedAxis from the index and require a deep import~
~add react-spring as a peer-dep if we want consumers to be able to use an existing version they have~

UPDATE based on feedback
@vx/axis

@vx/axis Axis is refactored to accept a ticksComponent which allows us to animate them
adds a third argument values to tickFormat(value, index, values) so that format logic can more easily leverage all ticks (because numTicks is approximate, lib consumers do not know how many tick values exist a priori)

@vx/react-spring

adds a new package @vx/react-spring that includes react-spring as a peerDep and can be a home for things that depend on react-spring
Adds an <AnimatedAxis /> and <AnimatedTicksRender /> in @vx/react-spring
updates the vx-demo/axis demo to use <AnimatedAxis />

Updated /axis demo

@hshoff @kristw @techniq

I'd like to propose option c): create a new package @vx/react-spring that includes react-spring as a peerDep and can be a home for things that depend on react-spring?

🤯 I dig it! Noting that I think a lot of the XYChart elements might end up living there like AnimatedBars, AnimatedStackedBars, etc. (likely animated equivalents of many things in @vx/shape).
Organizing that over time might be tricky, but I think it'll be a good forcing function to keep things modular / might converge on good patterns over time.

doc page for the new package

@hshoff 🎉

Coverage increased (+2.2%) to 46.97%

I have an AnimatedGrid PR stacked on this, will add some more legit ones there


No Splash Screen is shown

Software and hardware versions
Services, Android 6.0
Problem description
No splash screen is shown on opening of the app even after setting the checkbox preference to true.
Steps to reproduce the problem

Launch the app.
Go to Toolbar and then navigate to settings
Under Device settings, check the 'Show Splash Screen' Checkbox to true.

Expected behavior
It should show the splash screen on the start of the app.
Other information
The logcat doesn't shows anything noticeable about the Splash Screen.

@jbeorse Please check the issue and I can send the PR asap.!

@codedsun thanks for pointing this out, but we do not have a splash screen on purpose. ODK Services is meant to be a background app and have Survey and Tables use it's functionality via intents without the user realizing they are changing apps. A splash screen launching would slow things down as you move between apps. Thanks for looking for bugs in ODK2 we appreciate your efforts!


fix: resets updatedToken state on address change

Adds a useEffect to update token balances when wallet addresses change

Can confirm this fixes the bug on my end!


[Bug]: Icon Broken on Secondary Screen

Before submitting your bug report, please confirm you have completed the following steps

[X] Searched the issue is not already listed in the Issue List (I've searched it)
[X] Searched in the Quicksilver Users' Group for questions relating to tech support.
[X] Downloaded the latest version of Quicksilver for your system and confirmed the issue still persists.

Bug description

If I open the Quicksilver dialog on my Secondary Screen the Icon is broken .... opening on my MacBook Pro's Screen it's fine.
Steps to reproduce

Open Quicksilver

Expected behavior
Same Icon to be shown .....
MacOS Version
macOS 12
Quicksilver Version
2.4.0 (4039)
Relevant Plugins
No response
Crash Logs or Spindump
No response
Screenshots
No response
Additional info
No response

This will be fixed in the next version of QS. Thanks for reporting.


Unable to have the pop-up when i try to connect through a powershell GUI

Since beginning of this week, i'm no more able to use the command "connect-exchangeonline" if it's launch from a powershell GUI.
I don't have any issue with other command like connect-azuread

Hi @tig3r57, thank you for your feedback.
I couldn't reproduce the issue but try to minimize the Windows PowerShell window to see if you have a credential pop-up below it.
Also, please check that you are using the latest version of the Exchange Online PowerShell V2 module:
https://docs.microsoft.com/powershell/exchange/exchange-online-powershell-v2

@dariomws Thank you very much for the contribution and sharing this explanation. @tig3r57 Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Cant download from Ustream a password protected video (having the password)

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.03.20. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2018.03.20

Before submitting an issue make sure you have:

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones
[x ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[x] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

youtube-dl --video-password xxxxxxx "http://www.ustream.tv/recorded/113649559" --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--video-password', 'PRIVATE', 'http://www.ustream.tv/recorded/113649559', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2018.03.20
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.16299
[debug] exe versions: none
[debug] Proxy map: {}
[ustream] 113649559: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 401: Unauthorized (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpbt_jbnlh\build\youtube_dl\extractor\common.py", line 519, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpbt_jbnlh\build\youtube_dl\YoutubeDL.py", line 2199, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

Is there a way of dowloading this video:
http://www.ustream.tv/recorded/113649559

found the way... just enabling in chrome navigation in android phone emulator, with this I could find the m3u8 link... and then used a yt-downloader + ffmpeg combination...


Ordering?

Hi,
Thanks for the great project.
Just wondering how the messages are written to kinesis, w.r.t.
When you have multiple files in the S3 bucket, in which order the data in the files will be written to kinesis?

@0rangeMan just saw this, sorry for the delay. with concurrency of 1, files are downloaded and written in bucket listing order, anything over 1 will lose any particular ordering guarantees


Coveralls

Add coveralls to CI/CD workflow
https://github.com/marketplace/actions/coveralls-github-action

Fixed with Codecov.io integration


sdl_mixer wrapper requires MIDI support

When I try to install the sdl2-mixer wrapper, it fails:
$ go get -v github.com/veandco/go-sdl2/sdl_mixer
github.com/veandco/go-sdl2/sdl_mixer
# github.com/veandco/go-sdl2/sdl_mixer
/tmp/go-build257741081/github.com/veandco/go-sdl2/sdl_mixer/_obj/sdl_mixer.cgo2.o: In function `_cgo_2986dbf602a7_Cfunc_Mix_EachSoundFont':
code/go/src/github.com/veandco/go-sdl2/sdl_mixer/sdl_mixer.go:97: undefined reference to `Mix_EachSoundFont'
/tmp/go-build257741081/github.com/veandco/go-sdl2/sdl_mixer/_obj/sdl_mixer.cgo2.o: In function `_cgo_2986dbf602a7_Cfunc_Mix_GetSoundFonts':
code/go/src/github.com/veandco/go-sdl2/sdl_mixer/sdl_mixer.go:350: undefined reference to `Mix_GetSoundFonts'
collect2: error: ld returned 1 exit status

The reason seems to be that my version of sdl2-mixer was built without MIDI support.
Would it be possible to make MIDI support optional?

Hi, I applied a patch that allows you to disable MIDI support through build tag.
go install -tags nomidi

Excellent, thanks! I ran "go get -v -u -tags nomidi github.com/veandco/go-sdl2/sdl_mixer" and got no error, so it seems it worked :).

Hello! It seems this patch has broken installation of the bindings. When using "go get -v github.com/veandco/go-sdl2/sdl_mixer ", I get the following errors:
../../veandco/go-sdl2/sdl_mixer/midi.go:16: undefined: unsafe in unsafe.Pointer
../../veandco/go-sdl2/sdl_mixer/midi.go:29: undefined: unsafe in unsafe.Pointer
Is it because of a missing import?
Thanks!

Seems so! I fixed it in the latest patch. Sorry about that.


failed to run godep get to generate go dependency

When running godep get ./..., it complains:
package github.com/cloudfoundry/bosh-micro-cli/deployer/registry

	imports github.com/cloudfoundry/bosh-micro-cli/deployer/registry

	imports github.com/cloudfoundry/bosh-micro-cli/deployer/registry: cannot find package "github.com/cloudfoundry/bosh-micro-cli/deployer/registry" in any of:

	/usr/local/go/src/pkg/github.com/cloudfoundry/bosh-micro-cli/deployer/registry (from $GOROOT)
	/Users/dongdong/Work/Projects/bosh-agent/src/github.com/cloudfoundry/bosh-micro-cli/deployer/registry (from $GOPATH)
godep: exit status 1

Based on the investigation, we found the only dependency exists in integration test for fake-registry here:
https://github.com/cloudfoundry/bosh-agent/blob/587fefc980298ca993fd70e2024ca7d6b9e45629/integration/fake-registry/fake-registry.go#L7
The actual referenced code does exists here:
https://github.com/cloudfoundry/bosh-agent/tree/master/Godeps/_workspace/src/github.com/cloudfoundry/bosh-micro-cli/deployer/registry
but this is not synchronized with bosh-micro-cli repo which broke the godep.
-IBM pair Edward + Tom

The registry code was moved within the bosh-micro-cli. The bosh-agent
imports have not yet been updated to reflect that change. You won't be able
to bump those vendored dependencies until that's done.
If you do a godep restore instead, that will check out the vendored
revisions into your go workspace, rather than checking out the latests
revisions.

-Karl Isenberg
Pivotal BOSH Team
On Tuesday, January 6, 2015, Zhang Hua<EMAIL_ADDRESS>wrote:

When running godep get ./..., it complains:
package github.com/cloudfoundry/bosh-micro-cli/deployer/registry
imports github.com/cloudfoundry/bosh-micro-cli/deployer/registry
imports github.com/cloudfoundry/bosh-micro-cli/deployer/registry: cannot
find package "github.com/cloudfoundry/bosh-micro-cli/deployer/registry"
in any of:
/usr/local/go/src/pkg/
github.com/cloudfoundry/bosh-micro-cli/deployer/registry (from $GOROOT)
/Users/dongdong/Work/Projects/bosh-agent/src/
github.com/cloudfoundry/bosh-micro-cli/deployer/registry (from $GOPATH)
godep: exit status 1
Based on the investigation, we found the only dependency exists in
integration test for fake-registry here:
https://github.com/cloudfoundry/bosh-agent/blob/587fefc980298ca993fd70e2024ca7d6b9e45629/integration/fake-registry/fake-registry.go#L7
The actual referenced code does exists here:
https://github.com/cloudfoundry/bosh-agent/tree/master/Godeps/_workspace/src/github.com/cloudfoundry/bosh-micro-cli/deployer/registry
but this is not synchronized with bosh-micro-cli repo which broke the
godep.
-IBM pair Edward + Tom
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry/bosh-agent/issues/8.

ok. we don't have commit access. we will submit a PR for you to review. Thanks!
-IBM pair Edward + Tom

Closing since PR was merged. Reopen if it's still a problem.


tui and crossterm updates

tui has not been updating, so we're also stuck on older crossterm. A fork ratatui is more active. I want to review the code and then switch to it.

Done in 38d60c5d1386fce4aa2ebf4404dcb0f610f7ee12


Merge branch to main for: upgrading NuGet dependencies

Closes #272

Be Advised
Intentionally did not upgrade the MaterialDesignInXaml NuGet package because of a known bug:

#182


Change the way routes are registered

After using soft delete and wanting to make it better I found #133 - It mentions about potentially changing the way routes are registered e.g:
CRUD::routes('car', 'CarCrudController')->withTrash();
CRUD::routes('car', 'CarCrudController')->withReorder();
CRUD::routes('car', 'CarCrudController')->withRevisions();
CRUD::routes('car', 'CarCrudController')->withDetailsRow();
CRUD::routes('car', 'CarCrudController')->withTrash()->withReorder()->withRevisions();

This was so optional routes could be created for new features.
I've taken a look and I think the best way to do this is creating a new class (this would be created as a facade).
Thoughts?

Completely agree. @OwenMelbz has already done that in the 3.2 branch, it's called CrudRouter. Take a look here: https://github.com/Laravel-Backpack/CRUD/blob/3.2/src/CrudRouter.php

Oh, never noticed that. I still think this could be improved upon as that commit only refactors the code to a new class, vs splitting out each of the route functions.

... If you want me to continue with this, the next thing I'm going to add is the ability for other packages to register types of routes, e.g. a package could create a ->withSoftDelete()

@tabacitu What do you want me to do with this? want me to make a PR?

@tabacitu ping

I am on an issue closing rampage and I can't see any movement here - please reopen if it should be open.

I just realised that we need something similar - possibility to list and "undelete" trashed items. As I see, a simple filter will enable the listing of the trashed items. But is there a ready-baked solution for the "undelete" functionality, or do we have to implement it ourselves?

Hi @o15a3d4l11s2 - no official solution yet. But implementing it yourself shouldn't be too difficult:

a filter to list the trashed items;
a button that only shows on trashed items, with a custom action (similar to the delete button, and the destroy functionality);

Hope it helps. Cheers!


Add overload option for the CLI

Hi @AhmedKamal20, thanks for the pull request! There are a couple lint failures here, but otherwise it looks good.
What would you think about renaming the option to -f/--force? That feels more consistent with other command line utilities to me.

@bkeepers Thank you, I fixed the lint errors
And about -f, Yeah I considered that, but it's already being used on
-f FILES, List of env files to parse

@AhmedKamal20 thanks, I'll get a release out soon with this feature.

@bkeepers do you plan on making a new release anytime soon? Looking forward to use this feature. :)

2.8.0 is out with this change. Enjoy!

Thanks a lot @bkeepers 🌟


What happened?
GOOD
Steps to Reproduce
GOOD
What browsers are you seeing the problem on?
No response
Relevant log output
GOOD

Screenshots
GOOD
Code of Conduct

[X] I agree to follow this project's Code of Conduct

thanks!


typo in scalar product code

dot(a, b) == sum(a .* w)  should be  dot(a, b) == sum(a .* b)

Closed by #16.


Describe the feature
You mention CUDA optimization which is "needed" but why do you not have support for Movidius compute stick or a Pine64 Quartz64 Neural Network Acceleration Engine? Is there a cpu strong enough at working this that it can be done without Nvidia-CUDA?
Can that be supported as well or does it provide enough power?

Interesting feature, however our primary target is the training process which occurs mostly on GPU platform. However, edges devices can be an important scenario for inference, we probably will look into this feature in the future.

In other words it will not train OR run without CUDA?

Hi @programmin1 Yes, you can check the detailed requirements.
https://github.com/hpcaitech/ColossalAI#Installation
This issue was closed due to inactivity. Thanks.


sentence update, it didn't run well.

sentence update.
After a closer look at the sentence, it didn't run well.
Therefore this new update to make it clear.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@cmcatee-MSFT Please merge this PR. Thanks