Minor Refactor

Refactored:

CommandResult
CsvAdaptedPerson
ImportCommand
ExportCommand

Codecov Report

Merging #336 (e7bc55c) into master (05ab01c) will increase coverage by 0.14%.
The diff coverage is 90.69%.

@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
+ Coverage     70.74%   70.88%   +0.14%
- Complexity      904      914      +10
============================================
  Files           111      111
  Lines          3633     3644      +11
  Branches        358      350       -8
============================================
+ Hits           2570     2583      +13
+ Misses          967      966       -1
+ Partials         96       95       -1

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/ImportCommand.java
89.65% <83.33%> (+0.76%)
:arrow_up:

...n/java/seedu/address/storage/CsvAdaptedPerson.java
92.68% <92.00%> (+0.68%)
:arrow_up:

...va/seedu/address/logic/commands/CommandResult.java
100.00% <100.00%> (ø)

.../java/seedu/address/storage/JsonAdaptedPerson.java
87.80% <0.00%> (-1.22%)
:arrow_down:

src/main/java/seedu/address/logic/ai/Ai.java
89.36% <0.00%> (+3.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ab01c...e7bc55c. Read the comment docs.


Unnecessary override of the title property in the buckets creation

The configuration for an aggregation defines a title property, such as:
{
  aggregations: {
    tags: {
      title: 'Tags',
      // conjunctive facet (AND)
      conjunction: true,
      // the default is 10
      size: 20
    },
    rating: {
      title: 'Actors',
      // non conjunctive facet (OR)
      conjunction: false,
      // it is sorting by value (not by count). 'count' is the default
      sort: 'term',
      order: 'asc',
      size: 5
    }
  }
}

I assumed it could be used for the UI part of the facets, once the search has been succesful.
But the code for creating the buckets automatically generates a title property out of a humanised version of the id, see
https://github.com/itemsapi/itemsjs/blob/06e2e70812294e94b3759bf7fda47db4633ac765/src/helpers.js#L236-L241

Is title used anywhere else in the code or by other integrations?
Would it make sense to use the humanised version only is the title has not been defined in the configuration, e.g.

return {
    name: k,
    title: aggregations[k].title || humanize(k),
    position: position++,
    buckets: buckets
};

Hey @vanch3d, thanks for catching it. The title is not used anywhere else. Feel free to create a PR


Add ostree commit resolver for otk: otk-resolve-ostree-commit (COMPOSER-2349)

The resolver is a simple call to ostree.Resolve() which handles resolving ostree input options to an ostree.CommitSpec.
The resolver returns the input as-is when the ref is a commit ID (there is nothing to resolve).  This can happen when a user wants to pull an ostree commit by its ID rather than specifying a ref to resolve.

Just one little bit and maybe @mvo5 can chime in here but I think these outputs should live under a tree.const similar to the otk-gen-partition-table and osbuild-gen-depsolve-dnf4 externals that generate defines.

Ah, yes.  Probably.  Though, I'm not entirely sure what our rules and conventions are exactly.
Given the way we describe the Const object
https://github.com/osbuild/images/blob/fa40f2da9f8a2f15a15687e301421be9fa5f6d3b/internal/otkdisk/partition.go#L23-L25
I think it's more appropriate for outputs from externals that will be fed back into another external.
The output from the resolver here is going to be used directly in stage options, so it's probably not necessary to mark them as const.  Though maybe it's still a good convention to specify that modifying one or more might lead to inconsistencies.

Just one little bit and maybe @mvo5 can chime in here but I think these outputs should live under a tree.const similar to the otk-gen-partition-table and osbuild-gen-depsolve-dnf4 externals that generate defines.

Ah, yes. Probably. Though, I'm not entirely sure what our rules and conventions are exactly.
Given the way we describe the Const object
https://github.com/osbuild/images/blob/fa40f2da9f8a2f15a15687e301421be9fa5f6d3b/internal/otkdisk/partition.go#L23-L25
I think it's more appropriate for outputs from externals that will be fed back into another external.
The output from the resolver here is going to be used directly in stage options, so it's probably not necessary to mark them as const. Though maybe it's still a good convention to specify that modifying one or more might lead to inconsistencies.

That is definitely a discussion we could have for now I think we can go with mashing it under const and then have a separate discussion about it when we have this one and the container resolving one in as well (we'll have 4 externals by then).

The Output has been Consted.


Update misleading parameter name AbstractOffsetDateTimeAssert#isBetween

AbstractOffsetDateTimeAssert#isBetween should use inclusive, not exclusive
Also checked other Date/Time asserts and tests: seems like in other classes the parameter names are valid.
Check List:

Fixes: chore argument renaming
Unit tests : NA
Javadoc with a code example (on API only) : NA (autogenerated)
[x] PR meets the contributing guidelines

Following the contributing guidelines will make it easier for us to review and accept your PR.

@radistao good catch!

Integrated thanks @radistao !


update to latest release with bridge mode

@lachie83,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Repeated 502 errors with non-JSON body when running bluebubbles bridge

When attempting to run the bluebubbles bridge, I'm encountering repeated 502 errors with non-JSON body responses.
/usr/local/bin/bbctl run --local-dev --param 'bluebubbles_url=http://localhost:1234/' --param 'bluebubbles_password=<passwordfiller>' --param 'imessage_platform=bluebubbles' sh-imessage
spits out the attached screenshot of errors.

bbctl-macos-amd64 version v0.12.2
MacOS 12.7.4

When using --local-dev, you're responsible for updating the config yourself. It's recommended to not use that flag.


Update Polish translation (checked and tested)

@abose as I promised, I've updated the Polish translation and tested it live on Brackets to make sure the user experience is good enough. I've also compared the other Polish translations and took the best parts of them, so I think it's the most up to date translation available as for now.
I didn't touch the Brackets preferences comments, because I think preferences file is not for a typical user and is best understood in English. In Polish lots of these elements would look quite weird if translated.
@winek could you please have a look at this?

@jurkian Thank you for Helping us with the translation. :fireworks:
The review for this PR is already complete at https://github.com/adobe/brackets/pull/11198.
Verified the change.
Merging.


DM-4016

See staged website at http://docs.lsst.codes/en/tickets-dm-4016/development/workflow.html
This guide is meant to be sufficient for a new hire to get started with the stack. It is intentionally light in details and special cases in many circumstances because I assume there will be additional in-depth guides written in the future that I can link to.
The guide focuses entirely on the lsstsw workflow since it was advocated as the best general workflow by the team.
https://community.lsst.org/t/what-development-workflow-should-be-advocated-w-poll/297?u=jsick
A separate guide should be written around using the shared stack on the NCSA cluster.
For DM-4016

Nice!!!
On Tuesday, October 20, 2015, Jonathan Sick<EMAIL_ADDRESS>wrote:

See staged website at
http://docs.lsst.codes/en/tickets-dm-4016/development/workflow.html
This guide is meant to be sufficient for a new hire to get started with
the stack. It is intentionally light in details and special cases in many
circumstances because I assume there will be additional in-depth guides
written in the future that I can link to.
The guide focuses entirely on the lsstsw workflow since it was advocated
as the best general workflow by the team.
https://community.lsst.org/t/what-development-workflow-should-be-advocated-w-poll/297?u=jsick
A separate guide should be written around using the shared stack on the
NCSA cluster.
For DM-4016
You can view, comment on, or merge this pull request online at:
https://github.com/lsst-sqre/lsst_stack_docs/pull/2
Commit Summary

Create a Development Workflow guide
Source install guide points to dev workflow

File Changes

D development/getting_started.rst
https://github.com/lsst-sqre/lsst_stack_docs/pull/2/files#diff-0 (5)
A development/workflow.rst
https://github.com/lsst-sqre/lsst_stack_docs/pull/2/files#diff-1
(501)
M index.rst
https://github.com/lsst-sqre/lsst_stack_docs/pull/2/files#diff-2 (2)
M install.rst
https://github.com/lsst-sqre/lsst_stack_docs/pull/2/files#diff-3 (2)

Patch Links:

https://github.com/lsst-sqre/lsst_stack_docs/pull/2.patch
https://github.com/lsst-sqre/lsst_stack_docs/pull/2.diff

—
Reply to this email directly or view it on GitHub
https://github.com/lsst-sqre/lsst_stack_docs/pull/2.

--
Dr. David Lee Nidever
Assistant Astronomer, Steward Observatory/UA
LSST DM SQuaRE Science Lead
950 N. Cherry Ave.
Tucson, AZ 85719
(520) 318-8368


Tweak quilt-tester order

Meh, i think it's fine, I don't really want to mess with it, when we move to jenkins it will have it's own way of doing things, and we'll switch to that.


RN callout color fix

Broken by https://github.com/cockroachdb/docs/pull/14436 because I updated css but not scss last time I fixed this callout

This change is

@rmloveland yep! it has turned red when other PRs change unrelated css for some reason. hopefully it's good now. tftr!


Implement configuration item "quickQueryTimpstamp" in grade plugin

Hi Jeremy,
Previously I added a new Settings item downloader.quick.query.timestamp in Core module, and I'v implemented it in gradle plugin, and fixed some publish issues as well, would you please review the changes?
Best Regards.

Wei,
I can't merge this pull request as it will re-introduce the bloat into the repo that I recently removed:
wmaintw wants to merge 3,252 commits into jeremylong:master from wmaintw:master

I had sent messages out to people about this (see archived post). This should not happen again in the future - but we did need to cleanup the size of the repo; sorry for any inconvenience.
The easiest way to fix this might be to re-clone to a new directory, copy the groovy files from the old repo into the new one and then delete the old repo.
--Jeremy

Sorry for the inconvenience, I will delete the old one and re-fork the repo, and then submit new pull request.

Hi Jeremy,
I've created a new pull request (https://github.com/jeremylong/DependencyCheck/pull/305), please close this one.
Best Regards.
Wei MA

Just noticed that, I can close the pull request :)


Updated unread_inbox_emails to parse properly when Gmail has the "Unread items in the first section and inbox, for example (2 : 3)" option set

When using priority inbox the unread count in the gmail UI can be setup to display two counts in the format (10 : 20). At present this parses as 1020 rather than 10.
Example on gmail...

Settings to configure this behaviour...

This pull request splits the count by colon first and takes the first value to return the correct value

Thanks

Wow merging at the speed of light ;-). Thanks!


MGDOBR-1125: New Instance creation ignores Error Handler definition

JIRA: https://issues.redhat.com/browse/MGDOBR-1125
The issue was only present when creating a bridge with an EH configuration without encountering validation errors.

@kelvah Strangely I get a "fatal: Need to specify how to reconcile divergent branches." error from git when fetching locally.
Previously, you rebasing the PR on main fixed it.. Could you please try that here too?

@kelvah Strangely I get a "fatal: Need to specify how to reconcile divergent branches." error from git when fetching locally.
Previously, you rebasing the PR on main fixed it.. Could you please try that here too?

@manstis sure thing. done!

Sorry @kelvah my fault.
I accepted and committed a proposed partial change, by mistake.
I just reverted it: https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox-ui/pull/214/commits/1ec525f8f7602b364791bc5870506bda51989e46

Sorry @kelvah my fault. I accepted and committed a proposed partial change, by mistake. I just reverted it: 1ec525f

No worries. Thanks :+1:
I'm converting this to draft as I spotted some issues and I'm afraid I'll need to change the ErrorHandling component further. Let's give priority to #204.

A couple of minor comments.

@manstis I don't see other comments beside the one here below. :eyes:

However I also noticed if I first try to create an Instance with an existing name (click save and get the name already taken error); correct it and then set the Error Handler to something (other than Ignore) the Error Handler form shows an error (e.g. Webhook URL not set) before I click save again. I believe this behaviour is incorrect and that the Error Handler form errors should not be shown until I click save.

Great catch! Fixed now.
I am now moving to the unsubmitted state when there are saving errors. After the server side validation happens, we have to "reset" the client-side one.

@Srihari1192 would you please give priority to this PR? My current task strictly depends on this. Thank you!


[Not Found] .bz domains

Problem
There's not whois server registered to the IANA Route Database Zone for all .bz domains.
Conclusion
That's make all .bz domains fails.

Fixed.
Closing.


No mouse input registered or displayed

2.3.13 - There are no options to enable or disable mouse input and no mouse input is being displayed when clicking LMB, MMB, RMB or rolling the MMB up or down.

Hello.
Apparently this happen by design and doesn't seem to be an accident as Mouse settings were completely removed - this is an unpleasant surprise for me, I loved the app will all the options I worked with in the last years
May I have access to older versions? I use to have some but discovered that the executable somehow disappeared...
Thank you.


Do not report handled exceptions

We're running our pipelines with a Jenkinsfile and a custom groovy-library that is tailored for our infrastructure. In this library we have defined a couple of exceptions to handle such cases to not immediately fail the pipeline
try {
...something that may fail
} catch(Exception e) {
...write to the log and handle the error
}

However, when looking at the GitHub check details these exceptions are still being reported. The picture below shows such a case where the java.nio.file.NoSuchFileException is gracefully handled by our library, but its still being reported as an error:

This is confusing for our users.

Version report
Jenkins and plugins versions report:

Jenkins: 2.289.2
OS: Linux - 4.15.0-147-generic
---
ace-editor:1.1
ansicolor:1.0.0
ant:1.11
antisamy-markup-formatter:2.1
apache-httpcomponents-client-4-api:4.5.13-1.0
artifactory:3.12.5
authentication-tokens:1.4
authorize-project:1.4.0
basic-branch-build-strategies:1.3.2
blueocean:1.24.8
blueocean-autofavorite:1.2.4
blueocean-bitbucket-pipeline:1.24.8
blueocean-commons:1.24.8
blueocean-config:1.24.8
blueocean-core-js:1.24.8
blueocean-dashboard:1.24.8
blueocean-display-url:2.4.1
blueocean-events:1.24.8
blueocean-executor-info:1.24.8
blueocean-git-pipeline:1.24.8
blueocean-github-pipeline:1.24.8
blueocean-i18n:1.24.8
blueocean-jira:1.24.8
blueocean-jwt:1.24.8
blueocean-personalization:1.24.8
blueocean-pipeline-api-impl:1.24.8
blueocean-pipeline-editor:1.24.8
blueocean-pipeline-scm-api:1.24.8
blueocean-rest:1.24.8
blueocean-rest-impl:1.24.8
blueocean-web:1.24.8
bootstrap4-api:4.6.0-3
bootstrap5-api:5.1.0-1
bouncycastle-api:2.21
branch-api:2.6.5
build-keeper-plugin:1.3
build-monitor-plugin:1.12+build.201809061734
caffeine-api:2.9.1-23.v51c4e2c879c8
checks-api:1.7.2
cloudbees-bitbucket-branch-source:2.9.10
cloudbees-disk-usage-simple:0.10
cloudbees-folder:6.16
command-launcher:1.6
conditional-buildstep:1.4.1
config-file-provider:3.8.1
configuration-as-code:1.51
copyartifact:1.46.1
credentials:2.5
credentials-binding:1.27
cvs:2.19
dark-theme:0.0.12
display-url-api:2.3.5
docker-commons:1.17
docker-java-api:<IP_ADDRESS>
docker-plugin:1.2.2
docker-workflow:1.26
durable-task:1.38
echarts-api:5.1.2-5
email-ext:2.83
extended-read-permission:3.2
external-monitor-job:1.7
favorite:2.3.3
font-awesome-api:5.15.3-4
generic-webhook-trigger:1.74
git:4.8.1
git-client:3.9.0
git-server:1.10
github:1.33.1
github-api:1.123
github-branch-source:2.11.2
github-checks:1.0.13
github-scm-trait-notification-context:1.1
global-slack-notifier:1.5
google-oauth-plugin:1.0.6
gradle:1.37.1
handlebars:3.0.8
handy-uri-templates-2-api:2.1.8-1.0
htmlpublisher:1.25
http_request:1.10
icon-shim:3.0.0
ivy:2.1
jackson2-api:2.12.4
javadoc:1.6
jdk-tool:1.5
jenkins-design-language:1.24.8
jira:3.5
jjwt-api:0.11.2-9.c8b45b8bb173
job-dsl:1.77
jobConfigHistory:2.28.1
jquery:1.12.4-1
jquery-detached:1.2.1
jquery3-api:3.6.0-2
jsch:<IP_ADDRESS>
junit:1.51
kubernetes:1.30.1
kubernetes-client-api:5.4.1
kubernetes-credentials:0.9.0
label-linked-jobs:6.0.1
ldap:2.7
lockable-resources:2.11
login-theme:1.1
mailer:1.34
mapdb-api:<IP_ADDRESS>
material-theme:0.4.1
matrix-auth:2.6.8
matrix-project:1.19
maven-plugin:3.12
mercurial:2.15
metrics:<IP_ADDRESS>
momentjs:1.1.1
multibranch-scan-webhook-trigger:1.0.9
multiple-scms:0.8
next-build-number:1.6
oauth-credentials:0.4
okhttp-api:3.14.9
pam-auth:1.6
parameterized-trigger:2.41
pipeline-build-step:2.15
pipeline-github:2.7
pipeline-graph-analysis:1.11
pipeline-input-step:2.12
pipeline-milestone-step:1.3.2
pipeline-model-api:1.9.1
pipeline-model-definition:1.9.1
pipeline-model-extensions:1.9.1
pipeline-rest-api:2.19
pipeline-stage-step:2.5
pipeline-stage-tags-metadata:1.9.1
pipeline-stage-view:2.19
pipeline-utility-steps:2.8.0
plain-credentials:1.7
plot:2.1.9
plugin-util-api:2.4.0
popper-api:1.16.1-2
popper2-api:2.9.3-1
prometheus:2.0.10
pubsub-light:1.16
purge-build-queue-plugin:1.0
rebuild:1.32
run-condition:1.5
saferestart:0.3
saml:2.0.8
scm-api:2.6.5
script-security:1.78
sidebar-link:1.12.0
simple-theme-plugin:0.7
skip-notifications-trait:1.0.5
slack:2.48
snakeyaml-api:1.29.1
sse-gateway:1.24
ssh:2.6.1
ssh-agent:1.23
ssh-credentials:1.19
ssh-slaves:1.32.0
sshd:3.1.0
structs:1.23
subversion:2.14.4
theme-manager:0.6
token-macro:266.v44a80cf277fd
translation:1.16
trilead-api:1.0.13
variant:1.4
windows-slaves:1.8
workflow-aggregator:2.6
workflow-api:2.46
workflow-basic-steps:2.23
workflow-cps:2.93
workflow-cps-global-lib:2.21
workflow-durable-task-step:2.39
workflow-job:2.41
workflow-multibranch:2.26
workflow-scm-step:2.13
workflow-step-api:2.24
workflow-support:3.8

What Operating System are you using (both controller, and any agents involved in the problem)?

Controller is unkown (x86+linux)
Agent is RHEL 7.5

Reproduction steps

Jenkinsfile with

node('nodename') {
  stage('name') {
    try {
      readFile(file: 'testfile')
    } catch (Exception e) {
      //nothing to see here
      print("cannot find it, so what")
    }
  }
}

Run the Jenkinsfile

Results
Expected result:
Check report success and nothing else ( since the pipeline handled the error)

Actual result:

I wonder if checks-api-plugin could perhaps detect whether the exception was caught, by comparing the exceptions of the readFile step to the exceptions propagating out from the try…catch statement. However, the screen shot says "Environment / Read file from workspace", which does not seem to mention the try…catch, so perhaps it is not treated as a step. Should check the source code.
If you make the catch clause use an exception type that does not match what is thrown, what does the output look like then? Does it show the same exception twice: once for the readFile step and again for just "Environment"?
I am surprised that the "name" from stage('name') does not appear in the output at all.

ExceptionCause might be useful here, for finding the exception that caused the build to fail.

I tried this and did not see any workflow step for the try…catch. There was no ExceptionCause in build.xml or workflow/*.xml, either.
Looking at the FlowGraphTable in Script Console:
import org.jenkinsci.plugins.workflow.graph.FlowNode
import org.jenkinsci.plugins.workflow.support.visualization.table.FlowGraphTable

Run build = Jenkins.get().getItemByFullName("REDACTED").getBuild("3")
FlowGraphTable table = new FlowGraphTable(build.getExecution())

table.build()

for (FlowGraphTable.Row row : table.getRows()) {
	FlowNode startNode = row.getNode()
	FlowNode endNode = row.endNode // private field :(

	println("depth=${row.getTreeDepth()} ${startNode.getDisplayName()}  ${startNode.getError()?.getDisplayName()}")
	if (endNode != null) {
		println("\t${endNode.getDisplayName()}  ${endNode.getError()?.getDisplayName()}")
	}
}

When the exception was caught, the ErrorAction was only on the ReadFileStep.
When the exception was not caught (because catch (NullPointerException e) did not match the type), the ErrorAction was copied to each StepEndNode and FlowEndNode on the way out.  I did not test how this would have been formatted for status checks.

When FlowExecutionAnalyzer finds an ErrorAction in a table row, it could check all table rows at outer depths. If any of those has an end node that does not have any errors, then consider the error handled and suppress it from the output. Complications:

FlowGraphTable.Row.endNode is private. Either add it a public getter or make FlowExecutionAnalyzer itself enumerate the FlowNode instances itself and correlate them via BlockEndNode.getStartNode().
Perhaps the error was handled, but a different error in a sibling step propagated to the end node. I don't think this can be reasonably detected, especially because a finally clause could run more successful steps in between, and a catch clause could throw a different exception that is regardless caused by the original error. If it is not clear whether the error was handled, it seems best to show the error.
I am not sure how the depths work with parallel steps.

Alternatives that would not require examining the end nodes:

If the build did not fail, hide all errors. That seems wrong to me though, especially if warnings still were visible.
If the build did not fail, say "Handled error" rather than "Error". Might be misleading if the build is still in progress.

In any case, the fix would be in FlowExecutionAnalyzer in checks-api-plugin, not in github-checks-plugin.


viewer: make it possible to split recordings back into dedicated windows

(Following a standup discussion)
The current application model (and refinements proposed in #919) make it possible to inspect any number of recordings concurrently in a single Rerun window.
In a way, recordings are akin to tabs in web browsers.
Unfortunately, as of today it is impossible to move any of these recordings back into their own dedicated window (e.g. because you'd like to inspect them side-by-side), similar to e.g. how you'd turn a browser tab into a whole new browser instance.
Implementing such a thing raises even more questions regarding the application and client-server models.

I think just being able to put two recording side-by-side inside the same Rerun window would be a great first step, and quite doable. It would likely force a nice refactor of App too.


Iteration Plan for 5.4 release?

Is there no iteration plan for the next typescript?
And also, is there a way to suggest wich features should be worked on?
And additionally, could also the roadmap be refreshed?
If it is possible to suggest features, I'd like to suggest:
#42048 and #3841 (#32452 nearly the same)

And also, is there a way to suggest wich features should be worked on?

Yes, by giving the issues thumbs up.

https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc then #3841  is already on second page :-)
#42048 has a long way to go

Thumbs up are not the only deciding factor, of course. But that's the way you can express your favor. Anything else would just result in a lot of unnecessary spam and distraction.
And in some cases like #3841 it's simply not viable due to mentioned problems: https://github.com/microsoft/TypeScript/issues/3841#issuecomment-163350868

Thumbs up are not the only deciding factor, of course. But that's the way you can express your favor. Anything else would just result in a lot of unnecessary spam and distraction.
And in some cases like #3841 it's simply not viable due to mentioned problems: #3841 (comment)

yeah, but the properties defined on the constructor, means the static objects of the class should/could be inherited somehow... like in the workaround described here: https://github.com/microsoft/TypeScript/issues/32452#issue-469403238

5.4 plan will be out shortly

#56948


MINOR: Use --force instead of --yes in AclCommand

To be consistent with ConfigCommand and TopicCommand.
No release includes this option yet, so we can simply change it.

Review by @gwenshap, cc @mimaison

LGTM

@ijuma Do we need to keep "yes" for a deprecation cycle for compatibility?

LGTM.


How to used it without composer in wordpress

Describe the feature you would like to see
Hello there,
A WordPress Developer,
unfortunate i can't use composer in my WP project i need to include  your admin php sdk without composer is there any way?
Hope you understood the issue..
Thank in advance.

Using composer is the only supported way, because the SDK pulls in 3rd-party-dependencies and composer makes sure that all of them are conflict-free with other dependencies that might be present in a project.
What you could do is using composer locally or in the build pipeline, if available, upload the vendor directory to your server, and make sure the vendor/autoload.php file is included in your autoloading setup.
Another possibility could be to use a project like https://roots.io/bedrock/ to enable your WordPress project to use composer natively.
However, I can't provide free support for that, I hope you can understand.


encode a staking tx in protobuf

Hei,
I saw that this endpoint /txs/encode allows to encode an Amino JSON tx to an Amino binary tx.
For "amino binary tx" do you mean protobuf?
The endpoint works great for MsgSend transactions but it gives this error "error": "json: cannot unmarshal array into Go value of type map[string]json.RawMessage" when trying to encode a staking/MsgDelegate tx.
What am I missing?

hi @roccomuso yes this is a mainnet bridge issue that is why you are getting that error, I will suggest you contact Terra support and talk with a Developer from Terra through their live chat Developers forum. Click on the  Forum ——>> https://agora.terras.live/ To help you sort this out right away

@hanjukim I'm not able to broadcast a staking tx using the legacy fcd /txs endpoint. That's why I asked here.
I'm getting this error:

"this transaction cannot be broadcasted via legacy REST endpoints, because it does not support Amino serialization. Please either use CLI, gRPC, gRPC-gateway, or directly query the Tendermint RPC endpoint to broadcast this transaction. The new REST endpoint (via gRPC-gateway) is POST /cosmos/tx/v1beta1/txs. Please also see the REST endpoints migration guide at https://docs.cosmos.network/master/migrations/rest.html for more info"


Scanamo unable to deal with BigInteger

I am trying to persist an ADT like so:
final case class InstalledCertDynamoItem(
  serialNumber: BigInt,
  deviceId:  UUID,
  publicKey: String,
  ts:        Long,
  ttl:       Long)

could not find implicit value for evidence parameter of type com.gu.scanamo.DynamoFormat[domain.dynamodb.InstalledCertDynamoItem]

When I remove the serialNumber: BigInt, it works fine! Any workaround for this?

You will need to provide a DynamoFormat for your BigInt, as it is not provided by the library. You can do it like this for instance
implicit val biging: DynamoFormat[BigInt] =
  DynamoFormat.coercedXmap[BigInt, Array[Byte], NumberFormatException](BigInt(_))(_.toByteArray)

Thanks, that worked!


Capture Pixel Buffers

Hi, I really like this package, but I'm trying to do something with it for which I can't see an easy route.
I want to catch every frame before it's added to the video, and send it elsewhere instead of save it to a video file. Is this possible?
I tried using the capturePixelBuffers method, but the handler in there doesn't get called, not sure if it's supposed to work that way though.
Any help would be greatly appreciated 🙏

Talking about WebRTC I have the following class to do this and it works. If this is still an issue can you please provide an example of usage?
import Foundation
import WebRTC
import SceneKit
import SCNRecorder
import Accelerate

final class ARRTCVideoCapturer: RTCVideoCapturer {

    let sceneView: SCNView

    var output: PixelBufferOutput?

    static var format = vImage_CGImageFormat(
        bitsPerComponent: 8,
        bitsPerPixel: 32,
        colorSpace: nil,
        bitmapInfo: CGBitmapInfo(rawValue: CGImageAlphaInfo.last.rawValue),
        version: 0,
        decode: nil,
        renderingIntent: .defaultIntent
    )

    init(sceneView: SCNView, delegate: RTCVideoCapturerDelegate) {
        self.sceneView = sceneView
        super.init(delegate: delegate)
    }

    func startCapture() {
        output = sceneView.capturePixelBuffers { [weak self] (pixelBuffer, time) in
            guard let this = self else { return }

            var pixelBuffer = pixelBuffer
            switch CVPixelBufferGetPixelFormatType(pixelBuffer) {
            case kCVPixelFormatType_30RGBLEPackedWideGamut:
                var sourceBuffer = vImage_Buffer()
                vImageBuffer_InitWithCVPixelBuffer(
                    &sourceBuffer,
                    &Self.format,
                    pixelBuffer,
                    nil,
                    nil,
                    vImage_Flags(kvImageNoFlags)
                )

                var buffer: CVPixelBuffer?
                CVPixelBufferCreate(
                    nil,
                    CVPixelBufferGetWidth(pixelBuffer),
                    CVPixelBufferGetHeight(pixelBuffer),
                    kCVPixelFormatType_32BGRA,
                    [kCVPixelBufferBytesPerRowAlignmentKey as String: 4] as CFDictionary,
                    &buffer
                )

                guard let destinationBuffer = buffer else { break }

                vImageBuffer_CopyToCVPixelBuffer(
                    &sourceBuffer,
                    &Self.format,
                    destinationBuffer,
                    nil,
                    nil,
                    vImage_Flags(kvImageNoFlags)
                )

                sourceBuffer.free()
                pixelBuffer = destinationBuffer
            default: break
            }

            let timeStamp = time.seconds * 1_000_000_000
            let buffer = RTCCVPixelBuffer(pixelBuffer: pixelBuffer)
            let frame = RTCVideoFrame(buffer: buffer, rotation: ._0, timeStampNs: Int64(timeStamp))
            this.delegate?.capturer(this, didCapture: frame)
        }
    }

    func stopCapture() {
        output = nil
    }
}

@maxxfrazer Has the issue been resolved?

Closing since there is no activity.

oh wow that was closed quickly 😅 the code looks to do what I wanted, I'll check it out tomorrow (Monday).
I am wanting it for RTC purposes, so looks to be the right result

@v-grigoriev  could u please  provide full code? Thanks so much, I am want to intergrate AR with WebRTC


License

Thanks so much for putting these together. Its so convenient! I'd really love to use this, but our company can't use any open-source code without a license. Would you mind adding a permissive license so that we can use this code?
The industry standard for ease of use is the MIT license.
Thanks!

@AnthonyMillerSF I feel really bad about taking so long to notice your comment!
I have added an MIT license to the repository, and plan on making some improvements to ensure the data is always fresh.
Stay tuned and I hope you still find some use for this package!


[bug] Auto-reload / hot-reload moves focus away from the code editor

Describe the bug
Coming to Tauri as web dev, I really enjoyed the ergonomics from auto-reload. I'm filing this bug in the hope that it can become more seamless.
Currently, it is causing some friction because whenever I save a cargo-managed file in my editor, cargo would re-compile and a few seconds later, the web view would reload and moves the focus from the code editor to the web view. Because the re-compile time is unpredictable, I would lose focus after an unpredictable interval, which is quite annoying.
EDIT: additional info

vite hot-reload does not disrupt the focus. The issue can be narrowed down to cargo.
I just tried using vscode and its built-in terminal. Same issue. So we can rule out Windows Terminal/tmux/neovim. It's most likely an OS level window management issue
I noticed that as soon as I save the file, the WebView is killed while cargo is recompiling. I'm not sure if that is by-design. I'd expect the WebView to remain open until it can be replaced by the new one. I imagine the focus problem can be solved if the WebView can preserve its identity instead of being closed and reopened. But I might be asking for too much :)

EDIT 2: additional info about my main.rs. There is no focus manipulation logic

fn main() {
    cfg::init().unwrap();
    db::init().unwrap();

    tauri::Builder::default()
        .invoke_handler(tauri::generate_handler![
            cmd::add_bookmark,
            cmd::create_index,
            cmd::list_bookmarks,
            cmd::patch_index
        ])
        .run(tauri::generate_context!())
        .expect("error while running tauri application");
}

Reproduction
My setup

OS: gWSL inside Windows 11
IDE: Windows terminal + tmux + neovim
Renderer: webkitgtk inside gWSL
I'm using vite to handle the javascript bundling

Repro steps

Open any project file in neovim, :w to write to disk

To eliminate vite as the cause, do not touch vite managed content. Consider write to main.rs.
Observe: WebView is closed immediately

Wait for cargo to recompile
Observe: WebView is opened
Observe: The WebView will move focus away from neovim

Expected behavior
The auto-reload should happen in the background. I'd expect the same dev experience as a vite developer
Platform and versions

View platform info dump

Environment
  › OS: Ubuntu 22.04 X64
  › Node.js: 18.12.1
  › npm: 9.1.2
  › pnpm: Not installed!
  › yarn: Not installed!
  › rustup: 1.25.1
  › rustc: 1.66.0
  › cargo: 1.66.0
  › Rust toolchain: stable-x86_64-unknown-linux-gnu
Packages
› @tauri-apps/cli [NPM]: 1.2.2
› @tauri-apps/api [NPM]: 1.2.0
› tauri [RUST]: 1.2.3,
› tauri-build [RUST]: 1.2.1,
› tao [RUST]: 0.15.8,
› wry [RUST]: 0.23.4,
App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:5173/
› bundler: Vite
App directory structure
├─ node_modules
├─ src
├─ .git
├─ dist
├─ .github
├─ src-tauri
└─ public

Stack trace
No response
Additional context
No response

This seems to be just the normal/intended behavior. When a rust related file changes, the app needs to be recompiled and we can't keep the old app alive because it will hold a lock on the file and then the new app won't be able to compile.
I know where the frustration comes from but unfortunately it is something that all compiled languages suffer of, there is no fine-grained reloading like web development HMR.
As for the focus stealing, you can set focus: false in tauri.conf.json while developing or if you are creating the window programmatically, you can disable the focus in development/debug builds like this:
let builder = tauri::WindowBuilder::new(app, "label", tauri::WindowUrl::App("index.html".into()));
#[cfg(debug_assertions)]
builder = builder.focus(false);
let window = builder.build()?;

Thanks @amrbashir. Totally understand the constraints here. I'm trying your suggested workaround but it's still stealing focus. Instead of focus(false), I used focused(false), which I believe is the function you are referring to.
    tauri::Builder::default()
        .setup(|app| {
            let mut builder =
                tauri::WindowBuilder::new(app, "local", tauri::WindowUrl::App("index.html".into()));

            // Do not auto-focus during development
            #[cfg(debug_assertions)]
            {
                builder = builder.focused(false);
            }

            builder.build()?;

            Ok(())
        })
        .run(tauri::generate_context!())
        .expect("error while running tauri application");

@chuanqisun yeah I meant focused, I forgot that focus is deprecated and is just there so we don't break users code.

Thank you @amrbashir. Would you consider reopen this issue or maybe suggest some other workaround? The fn focused() did not prevent focus stealing. The code I pasted above had no effect.


Add some tracing and logging

Copy-pasting from Zulip:
I'm still using #[instrument] because, as I've said earlier, this is far from the biggest compile bottleneck right now; (I'm going to do some tests again to measure the impact it has). Also, while I don't like the syntax instrument has right now (having to add skip(...) everywhere), apparently it's due to be changed in the next version of tracing.
Right now I'm trying to address the use-case that made me want to add more logging: being able to tell when an internal event (warning, something being redrawn, etc) happens and why.
Part of that is adding spans everywhere; since druid, like basically every GUI, uses a variation on the visitor pattern, that means most spans are going be named after the Self type of the function they instrument; except for the root span. For instance, if you have Window::event calling Flex::event calling Button::event, the context chain is going to look like event:Flex:Button.
I feel like I should document that last part somewhere.

Could you also remove all default features besides "fmt" from tracing subscriber? It wont do anything now but will have add compile time improvement later.

Could you also remove all default features besides "fmt" from tracing subscriber? It wont do anything now but will have add compile time improvement later.

Already done in a later commit, which I'm not pushing to keep the review process simple.
But yeah, it's a good point.

Did you consider this approach? Are there some limitations that I've overlooked?

Paraphrasing what I said on zulip for visibility:
Okay, so I've tried the short_type_name() approach, and it fundamentally doesn't work :neutral:
Basically, if I have debug_span!("{}", self.short_type_name) with self.short_type_name = "Button" or something. Instead having a span named Button, I get a span that says {}{self.short_type_name="Button"}.
This is because tracing only accepts string literals as span names; as I understand it, the goal is to cache is whether or not to use a given span at startup, to avoid doing string prefix comparison every time the program needs to compare a span against filter rules.
So I'll keep the #[instrument] approach unless you have objections.


MPCHC and flash player

I would like to point out a detail in the functioning of MPCHC (1.9.11 by clsid2) on Win10 with patched flashplayer.
After discovering a few months ago that MPCHC was no longer reading .swf files, I found that using "runasdate" by Nirsoft setting a date before the block (say December 2020), it still worked. I recently realized that this "trick" no longer worked, MPCHC told me it required "flash for internet explorer" if I tried to open an .sfw file.
So I discovered FlashPatcher by KuromeSan (and flashpatch by leecher1337). I recently installed KB5001391, if that has anything to do with it.
I'm sure I was using the 64bit version of MPCHC because I had downloaded the 64bit version of "runasdate".
The fact is that after using FlashPatcher, which seemed to be successful, it still asked me "flash for internet explorer".
So I tried to open IE11 (now it shows the Win10 version in the properties, so mine is 20H2) and I opened a .swf file from the address bar, and it worked, like a couple of randomly opened animations on the internet (always with IE11).
After hitting my head against the wall for a while and checking which files were patched, I thought "doesn't that only work with 32-bit applications?" I installed MPCHC 32bit and it worked.
I would like to know if this is normal and why, and if anyone knows why before the "runasdate" trick worked with the 64bit version.
Thank you all for your commitment and dedication.

Thanks for your kind reply.
If I understand correctly, the link you suggested is about 32bit applications that try to access 64bit files.
The version of Win 10 I tested on is 64-bit, I don't think anything ran 32-bit, but I'm no expert.
I am attaching images with what FlashPatcher returned to me and then I also tried FlashPatch, so you can check if any file is missing or has been excluded.
https://imgur.com/a/0GjxfoK
The file you have uploaded in the post finds nothing to patch.

i see the problem. you have the windows 7 activeX control installed which is 32 bit only.
try running this script as admiistrator: https://github.com/leecher1337/flashpatch/releases/download/20210317/reinst_flash_w10.cmd  it should restore the flash.ocx that windows update removed, then try use flash patcher on those files.

Hello again!
I followed the instructions, the flash.ocx file was installed and patched.
Here is the result:
https://imgur.com/a/hPeO43E
On the other hand, it means that installing in win10 install_flash_player.exe install_flash_player_ax.exe install_flash_player_ppapi.exe not all files are restored, because KB4580325 is also needed.
https://www.catalog.update.microsoft.com/search.aspx?q=4580325
MPC-HC 64bit however still requires flash player for internet explorer. Maybe it's a problem with the program, maybe it's my system.
Anyway, don't waste time on my problem, I had already set MPC-HC 32bit to read .swf files and MPC-HC 64bit for other media. It's not an optimal solution, but it works.
However, I am happy to have contributed, and if you find a solution, we would all be happy.
Thank you for what you have done so far and for your effort (and also to everyone else who has been involved in patching FlashPlayer).

I also ran the cmd and flash patcher, but my MPC-HC 64-bit and Swiff Player still show the [f](i) symbol.

Since this was left open, the generalized title means it's like the #2 google hit for "how to play SWF in MPC-HC." So I'll just leave these links here for a more general current solution:

Install chinese flash player, clean version: https://gitlab.com/cleanflash/installer
Run FlashPatch to make this work in system web browers: https://github.com/darktohka/FlashPatch (even if you won't be using it in web browsers, this seems to be necessary for MPC-HC to access flash through IE).

See the original Reddit post about Flash Patch for more explanations of how this works: https://www.reddit.com/r/pcgaming/comments/kyql6f/flashpatch_a_new_way_to_keep_playing_adobe_flash/


Support reordering steps by using Ctrl+up/down arrows

Please describe the feature that you want to propose
when a step (or a group of steps) is selected, it would be ncie to be able to move them up and down in the route by using the keyboard, like Ctrl+up and Ctrl+Down

Need to figure out what to do when the node is clicked, currently the form is opened / focused


Remove scipy

Remove dependency no longer required for 5.4.0
See https://github.com/openmicroscopy/openmicroscopy/pull/5412
This is a breaking change
a new tag will be needed

The change looks straightforward and fine to merge to me.


Unable to Change Aimeos logo

The latest Aimeos has Logo coming out of base.blade.php, does not come from page.blade.php of jqadm. How to replace the logo in this version?

The logo for the admin backend hasn't changed and is still in page-standard.php of JQAdm:
https://github.com/aimeos/ai-admin-jqadm/blob/master/admin/jqadm/templates/common/page-standard.php#L148


FreeBSD support

CC?=cc (history repeating), and adjust opam to allow building on non-linux systems (I expect this to work as well on OpenBSD/NetBSD/MacOSX)

Technically it won't work on MacOSX at the final link stage (solo5-kernel-...) unless you have an ELF cross-compiler, the toolchain uses Mach-O. However, I'll merge this for now and add in the appropriate availability constraints to the solo5-kernel-XXXX packages.

thx!


how to get the validate dataset?

what is the validate dataset and how to organize the dir path tree?

The validation dateset for posted results with pretrained weights is the standare ImageNet-1k validation at http://www.image-net.org/challenges/LSVRC/2011/downloads
You can use the smaller https://github.com/modestyachts/ImageNetV2 set for validation as well that uses newer images sampled in a similar manner with the same classes.
The included data loader is like the PyTorch ImageFolder dataset with a few extra features, it works with any image classification dataset where there is one folder per class
You can use these models like torchvision ones with any other training or validation code and datasets as well by using the model_factory.create_model or torch.hub api to instantiate the models. Just make sure you match the appropriate input image sizes and crop ratios if you expect the performance of the pretrained weights to remain as posted.


Add option for docker runtime to provide default volumes

Fixes #993
Not tested yet, will test once PR docker image is built Tested and works just fine 😊

Codecov Report
Base: 49.38% // Head: 49.38% // No change to project coverage :thumbsup:

Coverage data is based on head (3680fd9) compared to base (896746a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1203   +/-   ##
=======================================
  Coverage   49.38%   49.38%
=======================================
  Files          88       88
  Lines        6615     6615
=======================================
  Hits         3267     3267
  Misses       3153     3153
  Partials      195      195

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Tested and confirm working

In case the variable is not set this wont allow to run pipelines anymore: Error response from daemon: invalid volume specification: ''


Add some extra navigation bindings to the main viewer

The navigation pane has bindings that are friendly to folk who like to use WADS and vim cursor-style keys; but I forgot to extend this to the main viewer pane too. This seems like an oversight and one worth fixing.

Closed by #12.


Make UI more like other admin apps, prevent accidental publishing

Use Bootstrap form styles rather than custom ones (and extract common form parts into partials)
Use admin template pattern for attachments table, and truncate large tables with a JS toggle (some documents have over 100 attachments) – instead of https://github.com/alphagov/specialist-publisher/pull/461
Separate publish, edit and withdraw actions and add confirm dialogues to irreversible actions

Completely hide publish button when unavailable, a disabled button is
confusing

Correctly space sections on the show pages with a consistent vertical rhythm
Use lead styles to make summary more readable
Remove collapsible body function, instead restrict height, and don’t show at all unless there is a body
Reduce dependencies on govuk_frontend_toolkit – currently Bootstrap and the toolkit don’t play well together

https://www.pivotaltracker.com/story/show/90529348
Editing a document
Before

After

Viewing a document
Before

Actions:

After

Actions:

Truncated attachments table

Warnings

This looks good to me, but probably worth having someone else look over it as well.

Looks good to me. It's probably worth getting a ruby dev to check the ruby, but otherwise I'm happy.

It looks like you've swapped a collapsing body for a fixed height display. How easy is it to scan through the content when it's shown in a small slice? Are editors looking at that content at all? If they're not, we could probably drop it. If they are, I worry that showing such a narrow slice will make scanning through long documents pretty impossible.
:+1: for the truncated attachments table.

In a couple of commits you hide the publish button altogether when the action is unavailable because "disabled buttons have proved to be confusing in the past". The advantage of showing a disabled button is that it distinguishes between the user not having permissions to publish, and the content item not being a suitable state to be published. Is that a valuable distinction to maintain? If so, is there another way to solve it without using disabled buttons?

@evilstreak The fixed body height is a technique used on other publishing tools on textareas when entering body text. If it's not quite right we can iterate. This is preferable to clicking open on an expand link and seeing an empty box.

To summarise the hangout I've had with @evilstreak, for this PR we are going to:

Move the withdraw button to a different place, because its actions are more like those of publish and it's not a safe action
Re-instate the warning messages for when something can't be published, and check the appropriateness of those messages

For a later PR and after some research:

Consider either remove the body excerpt altogether, or making it easier to expand and see all of the body copy if it's being used

Closing this PR until the first two points are finished.


✅ Test AWS2 SQS in isolation

Fixes #2606
I didn't invent any of these tests. I've just split the tests to have

a project isolating the SQS tests
a project for SNS tests, with only the SQS bits needed to perform those tests

Let me fix the build.

There is going to be a conflict between this PR and this one https://github.com/apache/camel-quarkus/pull/3367
As the Quarkus AWS2 client has moved to  Quarkiverse.
Let's wait for the merge of previous one, and I'll rebase, correct this one

Rebased from main.


feat(jars): destination jar selector on send screen

Resolves #340.
📸
https://user-images.githubusercontent.com/10026790/175030752-68d9fd46-945a-4d3a-afa6-78a900a9de9c.mov

looking very good, just maybe some adjustments:

the X in the input field could be separated and function to reset/empty the field (not combined with the Jar) (like 2 buttons, X and Jar)
clicking the Jar again would open modal, selecting another jar is closing the modal & overwriting the value inside the input field, no need to reset before
the number inside the Jar after choosing is a good idea but needs some formatting, more semi bold and maybe a little bit smaller

thought about the number on the jar a little bit more. it kind of looks like a pillbox with that number on it.
maybe an arrow indicating that the jar will be filled is enough?
and we could maybe use as an input value the jar #X number?

the X in the input field could be separated and function to reset/empty the field (not combined with the Jar) (like 2 buttons, X and Jar)

I think two separate buttons would be a bit fiddly to click honestly. Let's keep it simple and remove the jar symbol and instead indicate which jar we're dealing with in the field itself next to the address. How does that sound?
https://user-images.githubusercontent.com/10026790/175277474-7081a089-5e55-4e80-8b3c-bc82593abbd0.mov

I think two separate buttons would be a bit fiddly to click honestly. Let's keep it simple and remove the jar symbol and instead indicate which jar we're dealing with in the field itself next to the address. How does that sound?

I think this looks awesome and is an improvement to the previous version, which might have been a tiny little bit confusing. Also, this fixed an issue, where the selected jar was not reset after submitting the form. :+1:
ACK.


OSError: [Errno 18] Invalid cross-device link. Is there a better solution now?

          Hi,

the problem is still not solved for wandb==0.12.16. Initializing with wandb.init(dir=tempfile.gettempdir()) is only a workaround, which is not possible in our case. And only downgrading to W&B to 0.9.7 as @timothybrooks suggested helped, but of course, we would like to keep up to date. Any plans of addressing it?
Best,
Daniel
Originally posted by @dkoguciukml in https://github.com/wandb/wandb/issues/1252#issuecomment-1163004853

Hi @hancan0, thank you for the follow up. This hasn't surfaced again over past year so there hasn't been movement on it. I'll be marking it as a feature request and will provide you an update once our team has made a decision on how they'd like to address this.

I ran into the same issue. I tried setting WANDB_CACHE_DIR to be on the same device, but it doesn't help (it just ignores WANDB_CACHE_DIR). Setting WANDB_DIR to /tmp would use a lot of memory and would not survive potential machine crashes. Is there any other way to fix this?

The problem in my case is in https://github.com/wandb/wandb/blob/v0.15.0/wandb/sdk/data_types/base_types/media.py#L128-L129, and it is extremely weird: os.path.join() decided just to output the second part of the path and ignore the first. I don't know how that is possible. After replacing os.path.join with f"{first_part}/{second_part}", it works perfectly.


Do one thing one after the other (Lua)

Describe your problem here.
I want to rotate gf left, then rotate her right. But I'm not sure how to make the game wait for her to finish rotating in one direction before rotating in the other.
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

function onTweenCompleted(tag)

What would you put in the (tag)? Like the name of the tween?

tag is just a variable name, it returns the tag of a tween when it finishes

It doesn't seem to be working, maybe it's because my first tween is under function onStepHit()

Here's what the tweens look like

You are doing a tween every step and doing two tweens at once

I know I am, but I don't know how to fix it

Make one tween and loop it with the function I mentioned

How? (sorry, I'm not smart)

make one tween, under the new function you can check the current angle and do the other tween to create the loop

How do you check the current angle?

getProperty('object.angle')

so just like this?

No, that doesn't work

you need at least one if and the function shouldn't be inside another one

I think you also need to put "gfRotateL" in onTweenCompleted().

So like?

it's getting there but you're not checking the angle value

How do you do that? Like this? idk

doTweenAngle("gfRotateL", "gf", -15, 0.14, "expoIn")
if getProperty("gf.angle") = `your desired angle` then
doTweenAngle("gfRotateL", "gf", 15, 0.14, "expoIn")
end

check to see if this works.

does the desired angle go in quotations?

alternatively:
doTweenAngle("gfRotateL", "gf", -15, 0.14, "expoIn")
function onTweenCompleted("gfRotateL")
doTweenAngle("gfRotateR", "gf", 15, 0.14, "expoIn")
end

Like this? idk

yeah that's correct, now you need to add the other tween below it using else

She still won't rotate to the right

Maybe it's because it's waiting for the 2 really long tweens I have to finish instead of the angle tween

If you were talking about the snippet I pasted, I forgot to change "gfRotateL" to "gfRotateR",

which "gfRotateL"?

Is there a way to maybe instead of making it wait for the tween to finish, just waiting like 50 steps and then playing the next one, and then waiting again

If it's ok I'm just gonna work on this some other time, because this is making my brain hurt.

doTweenAngle("gfRotateL", "gf", -15, 0.14, "expoIn")
if getProperty("gf.angle") = `your desired angle` then
doTweenAngle("gfRotateL", "gf", 15, 0.14, "expoIn")
end

Ended up fixing it on my own. I instead made 2 different scripts and put them in the same song, one for just them floating, and one for gf rotating


Method for aggregation

The method should accept a Dates.Period and apply a function to each of those periods in the TSFrame. Like computing the daily mean of hourly data. Control over the time index that is used in the output would also be nice. Like should the first be used or the last in the period.

Computing the daily mean from hourly data is easy, since it is simply 24 vales each, but the monthly or yearly mean would be harder, since not every period might be of the same length.

@chiraganand @codetalker7 Your thoughts on this feature?

One easy way is to simply apply the given method, i.e. month to the timestamps and then compute the intervals for the aggregation when this changes. idx = findall(diff(month.(timestamps))).  Or in a for-loop.

Doesn't apply() handle this use case?


fix: moved non-verification misbehaviour checks to checkForMisbehaviour

Description

closes: #2007
Commit Message / Changelog Entry
fix: moved non-verification misbehaviour checks to checkForMisbehaviour

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #3046 (63e205e) into main (887cba1) will decrease coverage by 0.08%.
The diff coverage is 33.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3046      +/-   ##
==========================================
- Coverage   78.45%   78.38%   -0.08%
==========================================
  Files         178      178
  Lines       12343    12358      +15
==========================================
+ Hits         9684     9687       +3
- Misses       2234     2244      +10
- Partials      425      427       +2

Impacted Files
Coverage Δ

...light-clients/07-tendermint/misbehaviour_handle.go
77.31% <33.33%> (-8.27%)
:arrow_down:


[php7][L5.1] is laravel5.1 work well in php7?

is laravel5.1 work well in php7?

Yes L5.1 works perfectly on php7 ...

Yeh, I spent some time a few weeks ago making sure it did. :)


CHAOS-5498 Linux JVM memory stress

Linux JVM memory stress docs and fault diagram

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664c8bb04a2b961336265768--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://664f348a33177a085f60d89a--harness-developer.netlify.app


Add dependabot config and Pin rocm-docs-core

To have dependabot make PRs to update requirements and prevent breaking changes when rocm-docs-core is updated.
This is an autogenerated PR.

Is .github/dependabot.yml/dependabot.yml the correct location for this file? I'm not very familiar with this feature, but the examples that I see in other repos are just .github/dependabot.yml.

You are correct. Thank you for pointing that out @cgmb.


Edit Item (Submission Style) - New Feature from 4Science

From release plan spreadsheet
Estimate from release plan: 32 hours
Expressing interest: 4Science
This is a new feature where users can edit an Item using a submission-like form (instead of the old v6.x edit metadata screens, etc) Feature existed in the OR2018 demo code, but was never extracted into a PR.  Uncertain how difficult this effort would be.

we need to note that since our first offer to port this feature from DSpace-CRIS to DSpace, the feature in DSpace-CRIS has evolved significantly. Now-day, the feature is connected with other advanced DSpace-CRIS capabilities especially in terms of managing granular and contextual security over the item. To port such features a large agreement about these aspects would be required and it is unlikely to be something that can happen in just a single release.