Security checking for model-fields breaks use of form-fields only

Checklist

[ x] This issue is not about installing previous versions of django-smart-selects older than 1.2.8. I understand that previous versions are insecure and will not receive any support whatsoever.
[ x] I have verified that that issue exists against the master branch of django-smart-selects.
[ x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[ x] I have debugged the issue to the smart_selects app.
[ x] I have reduced the issue to the simplest possible case.
[ x] I have included all relevant sections of models.py, forms.py, and views.py with problems.
[ x] I have used GitHub Flavored Markdown to style all of my posted code.

Steps to reproduce

Update to 1.5.x

Actual behavior
403 prevents chaining from working
Expected behavior
Chaining to still work
Explanation
The changes in 051ea42 have completely broken my (perhaps niche?) use-case. My models only contain the foreign key that is at the end of the chain, rather than all the foreign keys for each step of the chain. This was a deliberate decision to avoid storing duplicate information in the database since my models are modified by both webui but also via REST API. As such I don't use the Chained model fields at all, only the Chained Form fields, which I've been manually adding to forms.
An example chain is Continent->Country->Address->Item->Child Item. My Child Item contains only an item_id field, not also continent_id, country_id, address_id fields.
The two potential database integrity issues I'm concerned about are:

When client wants to modify the last FK in the chain, not having to look up at reset all parent FKs in the chain too. E.g. if my Item is chained to a different Address, I don't want continent_id, country_id fields on the item to need to be modified.
If a lower item in the chain is modified, associating it with a different parent above it in the chain, not invalidating every single model in the database. E.g. if someone moves an Item to a different Address, every single Child Item model in the database would immediately have an invalid address_id.

I don't want to over-complicate my models by adding complex save() logic to check for and update the parents in the chain each time they are modified.
The security changes stop the form fields working completely because every single lookup is now running a 403 since there are no model fields. I'm not concerned about information leakage via this app. I would prefer the specific check for model-fields were optional, and that the security concerns were mitigated by checking for model and object-level permissions instead.
I'm hoping you'll agree that this is a valid use-case and worth supporting. If so, I'll see if I can help with a PR. In the meantime I'm probably going to have to revert back to 1.3.4 and cherry-pick in the specific bugfixes I need.

I'm hoping you'll agree that this is a valid use-case and worth supporting.

Yep.

and that the security concerns were mitigated by checking for model and object-level permissions instead

This is, AFAICT, difficult to do in a generic fashion to support all users of django-smart-selects. I think a global option to turn off the model field checking (and default to on) would be a sufficient situation. If users need more complicated permissions checks they can use django-autocomplete-light, which requires much more configuration and custom coding than django-smart-selects.

I'll see if I can help with a PR.

That would be great and very appreciated. Please namespace the global option with SMART_SELECTS_ and default to the more secure option.

And if adding tests for the new option aren't too difficult, please add tests for it.


@kanaabe Add Sailthru meta tags on the show page

Closes https://github.com/artsy/force/issues/124
Metaphysics dependency: https://github.com/artsy/metaphysics/pull/411
Spoke with Sara and decided to change definition of some tags. I will add more details inline. Thanks for helping with the integration.

Nice usage of ViewHelpers, looks 💯

 Adding Sailthru metatags on show pages to facilitate email integration

Would it be possible to change "date" to the actual publish date (the date it's live on the website) rather than the date the show opens? we've come across an issue, particularly with promoted content but all shows, where we're promoting shows before they're open but are live on the site. It's a big problem with tomorrow's miami email for gagosian and another promoted show. We can handle manually if necessary but if it were a quick fix it would be a HUGE help.
cc @starsirius

@sperle I am going to work on this today. It requires changes on Metaphysics but should be fine. Will cc you in the PR.

@sperle It turned out to be a bigger issue. The publish_at timestamp was historically used in the Eigen featured shows feed (I am not sure if that's still used, cc @alloy). A large portion of the shows don't have that set.
From what I understand Force only uses the displayable boolean field to determine whether to display a show or not, which means we don't have a timestamp for when it's initially set to displayable: true. Is including that boolean field for Sailthru useful?

The publish_at timestamp was historically used in the Eigen featured shows feed (I am not sure if that's still used, cc @alloy).

A quick search does not yield any occurrences in Eigen’s codebase.

@starsirius not 100% sure I follow but the only relevant field for this matter is 'date' -- if you passed the actual open date as a custom var the way most of the other fields are passed and just literally made 'date' whatever date it is at the time this is happening, that would be sufficient for my purposes.

[ ] Change sailthru.date to now.
[ ] Change sailthru.expire.date to sailthru.expire_date.
[ ] Change title to just show title instead of page title.
[ ] Add sailthru.open.at and sailthru.end.at.


WIP store in localstorage and rehydrate implemented

Codecov Report

Merging #97 into master will decrease coverage by 0.57%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   38.76%   38.18%   -0.58%
==========================================
  Files          54       54
  Lines         792      804      +12
  Branches       80       84       +4
==========================================
  Hits          307      307
- Misses        474      486      +12
  Partials       11       11

Impacted Files
Coverage Δ

src/state/configureStore.ts
0% <0%> (ø)
:arrow_up:

src/state/quests/questSaga.ts
0% <0%> (ø)
:arrow_up:

src/state/stockMarket/stockMarketSaga.ts
0% <0%> (ø)
:arrow_up:

src/containers/App/App.tsx
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b218117...37bbcf4. Read the comment docs.


Timeline cREdit taXonomy (TREx)

Related to #26: how should contributor roles be defined? Answering this question helps establish what each contributor has contributed to the present repository.
This issue serves to capture thoughts for a taxonomy of contributor roles.
I draw conceptually on CASRAI.

Attempt 1 (one)
This protocol establishes the roles that contributors may fall under. Similar to CRediT, the point is to acknowledge the different types of effort contributors bring to the wider project. In the case of The Timeline, emphasis is on types of contribution rather than categorising contributors. This can help if, in the future, a contributor wants to show evidence (to potential employers, etc.) that they can make a certain type of contribution - that they have a certain skill. The below taxonomy can also be used by potential contributors to see how they might support the creation and maintenance of A History of Research Ethics.
It is worth noting that there is a low bar for becoming a contributor to this project. At present, practically taking the time to discuss the project with me (@Ismael-KG) will render you a contributor. I intend that to continue being the case, and to be clear that all contributions are deemed equally valuable.
Contributions then fall under one or both of two broad categories: sustainability or stories. Each of these, in turn, are broken down as follows:
Sustainability
Sustainability contributions are those that relate to the GitHub repository and have little to do with the content of stories.

Engineering: these are contributions that have to do with (i) how the GitHub repository is managed and arranged, (ii) how different sites host content pertaining to the timeline, and (iii) maintenance of the present platform (Tiki-Toki) and its eventual migration to a better platform (hopefully).
Policy-making: this is about writing and improving protocols. For example, on the review process, the code of conduct, or even this very taxonomy!
Communications: these include contributions relating to strategising about social media-usage, but also spreading the word online (at present, communications is mostly @Ismael-KG's tweets, which don't get very far!).
Ideation: this is a broad type of contribution to acknowledge that both stories and protocols can result from discussions that can be held on GitHub issues or offline.

Stories
The content of the timeline can be improved and maintained by the following contribution-types:

Conceptualisation: contributions of this sort occur early on in the story-creation life-cycle. This can amount to something as simple as drawing a fellow contributor's attention to some historical event that might be worth capturing in The Timeline.
Research: research contributions are useful during the conceptualisation and story-writing stages. It is mostly about providing links to useful resources.
Authorship or co-authorship: this is when a new story has been drafted in full by one or more people.
Review: providing reviews requires expertise on the stories to be reviewed. It is about ensuring the accuracy of claims and quality of argumentation. Reviews are "higher-level" than copy-editing.
Copy-editing: this is a thorough analysis of a text's consistency and clarity, and ensures that the text is also in line with The Timeline's style guide (yet to be made).
Proofreading: proofreeding is when contributors scour stories for syntactical, grammatical and spelling mistakes.

Recognition
It would be unfair to create a system where anybody can contribute yet nobody gains recognition, regardless of political inclinations. As contributions grow, sustainability ones will be acknowledged at the end of protocols. For example, a protocol might end with "This protocol was designed by @/so-and-so."
Similarly, stories will end with an acknowledgements section, listing stories-type contributions.

Added to protocols


BAU: Upgrade httparty from 0.18.0 to 0.18.1

Dependabot PR #1076 has been sitting around for a while because it breaks the build.  I just took a closer look and the failures are because the new version of httparty encodes keys in query parameters; there are some places where we had literal [] in key names, and the brackets now get encoded.  This caused a few tests to fail because they assert that the body of a request will contain a specific URL including the literal [].
I'm assuming that the right solution here is to update the test expectations, but I don't have much understanding of how this stuff is being used, so please be sceptical about this assumption.
More detail about the relevant change in httparty can be found here: https://github.com/jnunemaker/httparty/pull/698

I think it's fine; let's deploy to staging and see what happens.


Bugfix: set a default inactivity timeout only if a read or write I/O operation was set

In order to resolve the leaks of UnixNetVConnection, from v5.0.0-rc0,
the feature "Setting default inactivity timeout" was added by TS-1375
(commit 6397b161).
The event EVENT_INACTIVITY_TIMEOUT is used to limit the maximum time
for the transaction. It can reclaim NetVC if the transaction stalls.
For example, HttpSM read the request from client and only received
part of content, or HttpSM send the request to origin server and only
sent part of content.
The event EVENT_ACTIVE_TIMEOUT is used to limit the maximum life time
for the session. It can avoid long live idle sessions.
For example, HttpSM received a HTTP/1.0 request and shutdown read for
ClientVC, and then it requests an OS DNS lookup. Since I/O operation is
not set, only the event "EVENT_ACTIVE_TIMEOUT" is valid for HttpSM.
HttpSM as the processor of HTTP transaction, it should handle the event
"EVENT_INACTIVITY_TIMEOUT" and the event "EVENT_ACTIVE_TIMEOUT" and
perform the same operation. But if it disabled both read and write, it
will only handle the event "EVENT_ACTIVE_TIMEOUT".

Links to #7134 .

Seems like a reasonable approach.  If the netvc is disabled, I think we still want the changes in PR #7134 so we don't lose the previously set inactivity timeout delta if the netvc is temporarily disabled.
But your are correct with the current code, if the netvc is temporarily disabled and the next inactivity timeout is set to 0 and we hit an iteration of the inactivity cop, that netvc's inactivity timeout will be reset to the default inactivity timeout which is probably not desirable since it does reset the previously set inactivity timeout.

The change does sound functionally correct, although, I wonder what happens when active timeout isn't configured (ie set to "0"). It'd leave the VC unmonitored because, there's neither the "active", nor the "inactive" timeout on it now.
That said, we also generally are trying to remove the default inactive timeout mechanism entirely (or set it to a super high value - e.g hours or even days as opposed to the current 5 min value that we are forced to set in production), which means we have to make sure we find all corner cases where there's no specific timeout is monitoring a VC. I think the DNS lookup use case you raised is a nice example of such scenario - as long as we enforce a timeout on the SM for DNS lookup and clean up the VC associated on a timeout, we should be good, but, I'm not sure if there are more such scenarios.
Coming back to the specific change in the PR, it might be worth changing it to
{code}
if (ne->next_inactivity_timeout_at == 0 && nh.config.default_inactivity_timeout > 0 &&
(ne->read.enabled || ne->write.enabled || ne->active_timeout_in == 0) {
{code}

We still don't fully know why the default inactivity timeout is still being applied in production.  We need to track these down and get rid of the need for default inactivity timeout.  It was a temporary safety net and we are now depending on it.
From a production box:
-bash-4.2$ traffic_ctl metric match default_inactiv; sleep 60; traffic_ctl metric match default_inactiv
proxy.process.net.default_inactivity_timeout_applied 929742
proxy.process.net.default_inactivity_timeout_count 281107

proxy.process.net.default_inactivity_timeout_applied 930885
proxy.process.net.default_inactivity_timeout_count 281301

We still don't fully know why the default inactivity timeout is still being applied in production. We need to track these down and get rid of the need for default inactivity timeout. It was a temporary safety net and we are now depending on it.
From a production box:
-bash-4.2$ traffic_ctl metric match default_inactiv; sleep 60; traffic_ctl metric match default_inactiv
proxy.process.net.default_inactivity_timeout_applied 929742
proxy.process.net.default_inactivity_timeout_count 281107

proxy.process.net.default_inactivity_timeout_applied 930885
proxy.process.net.default_inactivity_timeout_count 281301

Oh wow! In our production, proxy.process.net.default_inactivity_timeout_count went down to 0. Are you configuring the SSL handshake timeout @bryancall ? But, yeah looks like you are still seeing significant amounts of default timeouts.


from future import annotations breaks schema generation

In python3.10.4 if from __future__ import annotations is imported and you execute jsonschema.extract on an attrs decorated class,
all types are set to object.

Thanks for the issue! I have fix in #14. PTAL (another pair of eyes doesn't hurt), and if all looks good or if there's a lack of response and I'll get that merged in.

fixing in 2.0.2. Thanks!


Download clarification

Using DASH & wanting both audio and video, I only have the choice of 360p. The setting for default video is 1080p. So how do I get a video of 1080p if available? Please clarify.

360p is the only stream that YouTube has with both audio and video, so if you want to any other quality, you need to download one of the video streams and then one of the audio streams and combine them with an external tool such as ffmpeg.


improvements

to make the select (language names) sorted alphabetically
if i created a "python" paste the "new paste"(link) would link to another "python" creation page.

The first bit was closed in the attached commit, the second bit I won't do with multi-paste being on the horizon again.


Request: Use album artwork as image

Basically what the title is. It would be cool if the image used could be the album art if available, instead of the foobar2k icon.

https://github.com/NaamloosDT/foo_discord/wiki/Frequently-Asked-Questions#does-this-support-album-art


Question: why is column tenant_tkey in bssuser.organization table not always updated?

[Version]
V16.2
[Date]
2016/10/19
[Test category]
Creative
[Description]
I was looking for the tenant ID of my customer organization. So i opened the bssuser.organization table and looked up the organizations.
To my surprise half of them did not have an tenant ID: see pic below

The organizations 'The real thing', 'From Hell' and 'MiniLuv' belong to the default tenant. Therefore the
tenenat ID is empty.
But: 'MiniPlenty' is a customer organisation of 'MiniPax' therefore they should have the same tenant ID: 10000
'DoubleThink' is an customer organisation of 'MiniTrue' and should have the tenant ID: 10001.
Is is confusing that some organization do not have the correct tenant id assigned here.
[Steps to reproduce]
[Expected result]
[Observed result]
[Details]
See above;
[Messages and logs]

This is an issue which is the reason for the issue #389. There is difference in the implementation for customers registered by platform operator and supplier.
Platform operator can choose the tenant and marketplace to associate with his customer organization. The chosen marketplace is one of the tenant-specific marketplaces. In this case the tenant key is written to the database.
In case supplier registers a customer organization, he has only possibility to choose the marketplace. The tenant is then implicitly known (the tenant of the chosen marketplace). This is not reflected in the organization table, the tenant key is missing for the customer organization in this case.

The issue is marked as duplicate to the issue #389


Create GitCherry.md

ADD GitCherry Suggestion (Final Project)

Hey @Florentcvt
There is already a suggestion for the git cherry command.
Do you want to improve on it by changing it?
https://github.com/barraponto/usegit/blob/main/suggestions/cherry.md


WidgetApp.onGenerateInitialRoutes and Navigator. defaultGenerateInitialRoutes should have the same types/parameters

Use case
This change will be useful in situations where you want to override the initialRoutes for certain routes, but keep the usual behavior for the rest. For instance, like when you're initializing deep links vs the normal operation of the app.
Right now, WidgetsApp.onGenerateInitialRoutes takes an InitialRouteListFactory which returns a List<Route> and takes in a String. On the other hand, Navigator. defaultGenerateInitialRoutes and Navigator.onGenerateInitialRoutes take a RouteListFactory which returns a List<Route> as well, but takes in a Navigator and a String.
As such, implementations like the following are NOT possible right now, but still necessary:
MaterialApp(
    onGenerateInitialRoutes: (initialRoute) {
        if (initialRoute == '/deepLink') {
            return [MaterialPageRoute(builder: (context) => const DeepLinkScreen())]
        }
        else {
            // This is NOT possible
            return Navigator.defaultGenerateInitialRoutes(/*NEEDS a NavigatorState I don't have*/, initialRoute);
        }
    }
)

Proposal
I recommend changing WidgetsApp.onGenerateInitialRoutes from an InitialRouteListFactory to a RouteListFactory like the Navigator methods. The previous code will then look like the following:
MaterialApp(
    onGenerateInitialRoutes: (navigatorState, initialRoute) {
        if (initialRoute == '/deepLink') {
            return [MaterialPageRoute(builder: (context) => const DeepLinkScreen())]
        }
        else {
            // This is NOW possible
            return Navigator.defaultGenerateInitialRoutes(navigatorState, initialRoute);
        }
    }
)

cc: @chunhtai

I don't think this worth the breaking change, you can also use navkey to get the navigator stack


add label xeroxprintandscan

installs drivers for many of Xerox's printers and AIO machines

I believe this is already implemented using the xeroxphaser7800 and xeroxworkcentre7800 labels.

I believe this is already implemented using the xeroxphaser7800 and xeroxworkcentre7800 labels.

well, change your label name to be generic for all Xerox printers in nature and I'll close this pull request. It seems like no matter which Xerox model you select, it points you to same package to install.

@robotprom One label can be called by multiple names. See fragments/labels/snagit.sh for an example of how to accomplish this.
I'm going to close this pull request, if you would like to open one to make the xerox name more generic please do so. Apologies for the delay in updating this PR.


Extend Search to include Dataset Descriptions and the Title of the Resource records

This is  report from @Kistine about trouble finding data sets:

as I went to search for a dataset I know is listed under a data entry, no results showed. Is there any way to improve the search feature so that it will display dataset entries based on details within the entry, not just the title of the entry itself?
LNI has been updating a dataset (currently called 'subcontractors') and it's to be replaced with the updated dataset called 'Permit contractors.' When I search on the ODP page for 'subcontractors,' it displays 0 results. In this case, I know that the subcontractors dataset is filed under the LNI permits dataset. This will significantly affect end-users being able to find relevant data. On the editing end, I usually search before I add a dataset just to make sure it doesn't already exist somewhere to avoid duplicative entries.

IIRC it's based on the title and the description.
I don't disagree this might be useful generally - but in this specific case having some text describing the
Subcontractors resources in that description would be helpful as well (and should make it searchable).

Thank you Bryan. Just tested by adding 'subcontractors' to the description of the dataset and that did indeed make it appear in the search. From here on out, we'll aim to list out the dataset names that may fall under one overarching dataset in the description.
If you're able to implement broader search functionality in the future that would be great as I don't know when/if we'll be able to go back and do this for all of our previously released datasets.
Best,
Kistine
[cid:27ebbc6c-d69b-4f4d-9e7f-77901ed64618]
Kistine Carolan
Senior Program Manager, PHL Open Data Programhttps://www.phila.gov/programs/open-data-program/
Office of Innovation & Technology, City of Philadelphia
o: 1234 Market Street | Philadelphia, PA 19107
e: @.***

From: BryanQuigley @.>
Sent: Thursday, May 11, 2023 3:10 PM
To: azavea/opendataphilly-jkan @.>
Cc: Kistine Carolan @.>; Mention @.>
Subject: Re: [azavea/opendataphilly-jkan] Extend Search to include Dataset Descriptions and the Title of the Resource records (Issue #57)
External Email Notice. This email comes from outside of City government. Do not click on links or open attachments unless you recognize the sender.

IIRC it's based on the title and the description.
I don't disagree this might be useful generally - but in this specific case having some text describing the
Subcontractors resources in that description would be helpful as well (and should make it searchable).
—
Reply to this email directly, view it on GitHubhttps://github.com/azavea/opendataphilly-jkan/issues/57#issuecomment-1544539549, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADTMWPF4XED7XZZIYLPBFOLXFU2QRANCNFSM6AAAAAAX6NVLRU.
You are receiving this because you were mentioned.Message ID: @.***>

Is it possible to also check my privileges? Currently, I don't seem to be able to create branches for submitting pull requests.
Best,
Kistine
[cid:1860aa79-fe96-4030-a73c-0a11f79d51cf]
Kistine Carolan
Senior Program Manager, PHL Open Data Programhttps://www.phila.gov/programs/open-data-program/
Office of Innovation & Technology, City of Philadelphia
o: 1234 Market Street | Philadelphia, PA 19107
e: @.***

From: Kistine Carolan @.>
Sent: Thursday, May 11, 2023 4:15 PM
To: azavea/opendataphilly-jkan @.>; azavea/opendataphilly-jkan @.>
Cc: Mention @.>
Subject: Re: [azavea/opendataphilly-jkan] Extend Search to include Dataset Descriptions and the Title of the Resource records (Issue #57)
Thank you Bryan. Just tested by adding 'subcontractors' to the description of the dataset and that did indeed make it appear in the search. From here on out, we'll aim to list out the dataset names that may fall under one overarching dataset in the description.
If you're able to implement broader search functionality in the future that would be great as I don't know when/if we'll be able to go back and do this for all of our previously released datasets.
Best,
Kistine
[cid:27ebbc6c-d69b-4f4d-9e7f-77901ed64618]
Kistine Carolan
Senior Program Manager, PHL Open Data Programhttps://www.phila.gov/programs/open-data-program/
Office of Innovation & Technology, City of Philadelphia
o: 1234 Market Street | Philadelphia, PA 19107
e: @.***

From: BryanQuigley @.>
Sent: Thursday, May 11, 2023 3:10 PM
To: azavea/opendataphilly-jkan @.>
Cc: Kistine Carolan @.>; Mention @.>
Subject: Re: [azavea/opendataphilly-jkan] Extend Search to include Dataset Descriptions and the Title of the Resource records (Issue #57)
External Email Notice. This email comes from outside of City government. Do not click on links or open attachments unless you recognize the sender.

IIRC it's based on the title and the description.
I don't disagree this might be useful generally - but in this specific case having some text describing the
Subcontractors resources in that description would be helpful as well (and should make it searchable).
—
Reply to this email directly, view it on GitHubhttps://github.com/azavea/opendataphilly-jkan/issues/57#issuecomment-1544539549, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADTMWPF4XED7XZZIYLPBFOLXFU2QRANCNFSM6AAAAAAX6NVLRU.
You are receiving this because you were mentioned.Message ID: @.***>

Improving the search is definitely on the TODO, but I have no idea when we can get to it.  The goal is actually to completely switch to a new powerful system.
It really doesn't matter if they are created in your fork or in this repo, - in fact, for anyone else we definitely want them doing the fork/PR/review setup - not needing write access here.
That has me thinking for the case of editing a single dataset by you or @rcheetham @lydiascarf if we should not require a 2nd reviewer (or otherwise lower our requirements to just CI passing).  Thoughts?  (I can mock something up)

Regarding permissions:

@Kistine I've invited you to collaborate via your work email, which should fix your permissions issue, but please let me know if it doesn't!
Also, @Alexander-M-Waldman and @jrmidkiff, your invites expired without being accepted. Would you like me to send them to different email addresses?
@BryanQuigley I can also handle setting up laxer reviewer requirements for trusted people. I'm already working on a CODEOWNERS file so that someone from the city gets requested if a PR touches a city dataset. I think what you're describing can be covered by that file as well but I'll dig in more today.

Regarding search:

@BryanQuigley I've got some availability to look into overhauling search. Was there a particular solution/plugin you were looking into? Let's focus this ticket on that search overhaul going forward (changing the title now)

Hi Lydia,
Sorry it slipped by me to accept the invitation - can you resend it? My
gmail address is fine
Thanks!
On Tue, May 16, 2023 at 8:09 AM Lydia Scarf @.***>
wrote:

Regarding permissions:

@Kistine https://github.com/Kistine I've invited you to
collaborate via your work email, which should fix your permissions issue,
but please let me know if it doesn't!
Also, @Alexander-M-Waldman https://github.com/Alexander-M-Waldman
and @jrmidkiff https://github.com/jrmidkiff, your invites expired
without being accepted. Would you like me to send them to different email
addresses?
@BryanQuigley https://github.com/BryanQuigley I can also handle
setting up laxer reviewer requirements for trusted people. I'm already
working on a CODEOWNERS file so that someone from the city gets requested
if a PR touches a city dataset. I think what you're describing can be
covered by that file as well but I'll dig in more today.

Regarding search:

@BryanQuigley https://github.com/BryanQuigley I've got some
availability to look into overhauling search. Was there a particular
solution/plugin you were looking into? Let's focus this ticket on that
search overhaul going forward (changing the title now)

—
Reply to this email directly, view it on GitHub
https://github.com/azavea/opendataphilly-jkan/issues/57#issuecomment-1549864123,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGIJKQDIZRZTW7KZERUKXA3XGOKELANCNFSM6AAAAAAX6NVLRU
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best,
James Midkiff

@BryanQuigley this has basically been stalled because off-the-shelf, static solutions are by and large not well maintained. what if i set up an SQLite db of searchable metadata and re-implemented search on top of that?

my thought was it would run in-memory on the client side using sql.js. SQLite is very lightweight and it could be useful for other issues like a dynamic hero image slideshow, expansions to filtering, etc. all it would need is an action to keep it synced and then it would be available for all kinds of dynamic reads. something like this feels more in keeping with the JKAN principles of relying on FOSS over platforms and building things to be customizable, but i might not be seeing the whole picture

@timwis i remember you were looking to improve search here. i'm curious if you think an SQLite-based search solution and would be a good fit for upstream JKAN


Runtime error: Could not load an opus lib.

I set up the bot properly, attempted to run it and got this error running the runbot.bat

You dont have the dependencies..
Run update-something and try again
Make sure you have a requirements.txt file


doc: Document requirement to run Cilium as a privileged container

This change is

test-docs-please


If configured with hostnames, use hostnames when getting sampling rules

We have an interesting setup where by we would prefer that requests to get sampling rules was using the configured hostname for the daemon rather than the resolved IP address.
As per the allowed configuration we are using "udp:hostname:2000 tcp:hostname:2001" where hostname is our internal cluster daemon hostname.
When the XRay service is constructed the endpoint resolved is setup to use the IP and Port from the resolved daemon configuration.
Is there a reason for this configuration not to use the configured hostname?

If I understand the question then probably you're asking  if daemon should be able to resolve hostname of your environment where daemon is running? If that is the case then I think SDK should be able to use that hostname and port as long as you use allowed configuration. Here is the method of parsing such double address.

My team and I use a single xray daemon for our entire environment, hosted on Fargate. If we push a config change, that causes the IP to change and as a result upstream resources fail to send xray data because (it appears) to cache the IP which the hostname initially resolved to at launch.
This code returns a static IP address. This seems unnecessary from the start, but it would be nice to simply send the telemetry data to the actual domain and port specified rather than the IP that it initially resolves to.

Hi @edwardofclt , This looks like an enhancement. I think this is a reasonable ask. I will add this item in our backlog. Meanwhile, Feel free to contribute and let me know If I can help in any way :)

Hey @bhautikpip, just checking in here; is there anything I can do to help move this along?


C# code generation

This implements appTarget.nativeType == "C#"
See https://github.com/Microsoft/pxt-samplecs/blob/master/libs/core/Core.cs for accompanying runtime implementation, which should be integrated in the final target.
It currently passes lang-test0.
While we're not using this yet, I would like it merged, to avoid bitrot (especially in cpp.ts, which now also handles parsing C#).

@mmoskal did you do a sanity check for other targets?

Will do tomorrow

From: Peli de Halleux<EMAIL_ADDRESS>Sent: Monday, October 2, 2017 4:55:10 PM
To: Microsoft/pxt
Cc: Michał Moskal; Mention
Subject: Re: [Microsoft/pxt] C# code generation (#3108)
@mmoskalhttps://github.com/mmoskal did you do a sanity check for other targets?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/pxt/pull/3108#issuecomment-333578183, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKLfOAhC-2f7G3rvgmrSuJ2zAxYzECboks5soQdegaJpZM4Pq0jr.

Just checked Adafruit - the exact same binary is generated and no changes in shims.d.ts.


Rename sequence node following new fennel parser

The nvim-treesitter repo recently switched fennel parsers. The new parser defines sequence in its grammer for sequence literals, whereas the old one used sequential_table. Thus this query needs to be updated.

Thanks, checked out and it looks good to me. I'll take a closer look at the new grammar later


data-ic/data-nice has not been updated since july 8

Hello, I see that the data with regard to the intensive care has not been updated since July 8. Is that not going to happen again, or will it be resumed? If the latter is the case, is it already known from when?? Thanks.

Hi @fmeijers,
I did an update of the data. I thought, maybe it is fine to do weekly update for this dataset as well. But if you are unhappy with this, I can have a look on updating this more regularly. The main issue is that automating this pipeline is a bit challenging because nice is blocking so many IP-addresses.

@J535D165 if it helps any I'm mirroring the api output to this repo once an hour. This should be accessible by github pipelines. The data extraction pipeline itself is running on a VM in a hospital so it is unlikely that it's going to be blocked.
https://github.com/Sikerdebaard/dutchcovid19data

Great! I will start using this and automate with GH Actions

Hi, Thanks for your quick responses and solutions. It would be great if the data will be refreshed on a daily basis (or even more frequent;-). I use these data in my Covid-19 dashboard in which all other data is refreshed on a daily basis: bit.ly/COVID-19-DB


Change History, etc

David,
greetings.  Hope all is well with you.
Could you please summarize any functional changes in going to 2.1?
I see Solr 5.2+ is about where Solr rev sits along with Java 7+.
Really basic change history and integration requirements (versions) would help the README or a second file on change/integration.
I'd like to start looking at Solr 5.3 in Xponents taggers (and so SolrTT 2.1)
thanks,
Marc

Hi Marc; I'm doing very well. It'd be nice to catch up some time.
Yes; I should absolutely maintain a CHANGES.txt!  I'll work on that and provide something soon-ish. I've got a conference to prepare for and it's getting to crunch time so I'll set a reminder to do this Monday the 19th.

Please see the new CHANGES.md.  Note that the current master branch, to become version 2.2, works only with Solr 5.2.x.  Supporting 5.3 would be yet another version unfortunately.  It's annoying to see some Lucene devs making such incompatible breaks to the API.  How about I release 2.2 now, then move on to updating master to support Solr 5.3?


Keyboard open GIF keyboard even if i gave keyboardType to 'ascii-capable'

I am having issue for keyboard. I am using gif keyboard extension for ios. When i open my app it's showing gif keyboard even if i use ascii-capable for input.
I want to show default keyboard while text input focus.
Description
My input code is below :
<TextInput
                    keyboardType="ascii-capable"
                    placeholder={translate('firstName')}
                    value={this.state.firstName}
                    style={styles.userInfoText}
                    onChangeText={text => this.setState({ firstName: text })}
                  />

I have attached screenshot what i am getting when keyboard opened.

React Native version:
System:
OS: macOS 10.15.2
CPU: (4) x64 Intel(R) Core(TM) i5-4278U CPU @ 2.60GHz
Memory: 22.09 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 10.16.0 - /usr/local/bin/node
Yarn: 1.21.1 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>10548
Xcode: 11.3/11C29 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.61 => 0.61.5
npmGlobalPackages:
react-native-cli: 2.0.1

Please give me solution


Feature duplicate queries

Hi,
It is an idea born talking with @freekmurze and his great team. It's the first PR for Ray: I hope it should be fine.
Thanks for your effort in the open-source projects, but more, thanks for helping me be a better software developer.
Luca

Thanks, could you also send a PR to spatie/ray to add this to the docs?

Thanks!

Thanks, could you also send a PR to spatie/ray to add this to the docs?

Sure ;)


Deprecate antigen cache-reset command

Deprecated in favor of antigen reset. cache-reset is still
available but the following message will be issued upon running it:
Deprecated in favor of antigen reset.

Use antigen reset command instead. Command will be unavailable on next
major version.
Fixes #258

Please note that current build doesn't contain an up-to-date command completion for antigen.
It does completes cache-reset instead of reset.
This is solved by issuing an:
make build

Then bin/antigen.zsh will be up-to-date. Will be solved next build.


question about the addBiasResidualPostLayerNormV2

Branch/Tag/Commit
main
Docker Image Version
NA
GPU name
NA
CUDA Driver
NA
Reproduced Steps
There is a question about the addBiasResidualPostLayerNormV2 kernel.

Does the mean need to be subtracted from the value "local_out_half2[i]" ? Thanks.

path: src/fastertransformer/kernels/layernorm_kernels.cu

Line569    out_ptr[id] = fma(local_out_half2[i], s_var_2,

fma do multiplies on first three elements, and add the last one.

I was referring to the the subtract:
"local_out_half2[i] - s_mean_2"

I don't get your point. If you want to ask where we subtract the mean, it is here https://github.com/NVIDIA/FasterTransformer/blob/main/src/fastertransformer/kernels/layernorm_kernels.cu#L552.

You got it. Is subtract needed at L569 too ?
I observe that there is a subtract at L625.

L569 save the result in shared memory and already subtract in L522.
Others use local register so need to subtract again.

I see. Thanks.


add toString in ArrmeriaService

Prom metrics for armeria service shows up like this
grpc_service_total_duration_seconds_count{grpc_status="2",hostname_pattern="*",http_status="200",method="GET",service="com.slack.kaldb.server.ArmeriaService$$Lambda$490/0x0000000840562040",} 1102.0
grpc_service_total_duration_seconds_sum{grpc_status="2",hostname_pattern="*",http_status="200",method="GET",service="com.slack.kaldb.server.ArmeriaService$$Lambda$490/0x0000000840562040",} 2.850402313

So adding serviceName toString will help distinguish it

Before you merge, please scrape metrics locally to make sure the fix works as expected.


Change bustCache default to true

I'm thinking about switching the bustCache default to true at this level. Having a hard time thinking of a situation where I wouldn't want that to happen with this lib.
https://github.com/shannonmoeller/handlebars-wax/issues/6

Currently gulp-hb uses the following defaults and it makes sense that these should just be the defaults:
bustCache: true,
cwd: process.cwd()

This is a breaking change and will result in a major bump to v4.0.0.

Published as v4.0.0.


Lower recommended download timeout to 300s

as recommended in https://github.com/scrapinghub/doc.scrapinghub.com/pull/137

I checked crawlera's configurations and looks like it was already changed that way on their side, I think we should also update the user documentation
https://github.com/scrapinghub/doc.scrapinghub.com/pull/139

Also as I understand, that is the timeout per request in crawlera, which means that scrapy should be able to wait for the retries too, and X-Crawlera-Retries defaults to 5, so our default should be 150000, @amleczko what do you think?

Sorry @eLRuLL , @amleczko , I'm not sure I'm following https://github.com/scrapy-plugins/scrapy-crawlera/pull/19#issuecomment-219729968. Which value should be 150000?
In http://doc.scrapinghub.com/crawlera.html#using-crawlera-with-scrapy ,
DOWNLOAD_TIMEOUT = 300 (5 minutes) is recommended for scrapy settings,
which, as far as I understand, is supposed to account for the initial try + 5 retries.
CrawleraMiddleware's download_timeout attribute -- initialized with CRAWLERA_DOWNLOAD_TIMEOUT's value -- sets scrapy's Requests download_timeout in meta dict for requests going through Crawlera, which is that same timeout above.
Or @eLRuLL do you mean the recommended value in http://doc.scrapinghub.com/crawlera.html#using-crawlera-with-scrapy and for CRAWLERA_DOWNLOAD_TIMEOUT should be 30s + 5 x 30s = 180s (30s being default for X-Crawlera-Timeout)?

the second part, sorry I didn't count the first attempt, it would be 180s.

@eLRuLL , @amleczko , updateed to 190s, a bit more than 30s + 5 x 30s = 180s

great I agree with 190, @redapple can we squash the commits to merge? after the merge we should also update the documentation: https://github.com/scrapinghub/doc.scrapinghub.com/pull/139/files

@eLRuLL , rebased


nextToken returning "0.0

Note: If your issue/bug is regarding the AWS Amplify Console service, please log it in the
Amplify Console GitHub Issue Tracker

Describe the bug
A clear and concise description of what the bug is.
Amplify CLI Version
You can use amplify -v to check the amplify cli version on your system
To Reproduce
Steps to reproduce the behavior or terminal output if applicable
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. Mac/Windows/Ubuntu]
Node Version. You can use node -v to check the node version on your system

Additional context
Add any other context about the problem here.

@quorth0n Can you update us with information so we can help you out better?

@ammarkarachi Oh my, I was drafting a ticket and must have opened it inadvertently. Sorry :sweat_smile:


Amazon EKS and Kubeflow 1.3 Compatibility

The https://www.kubeflow.org/docs/distributions/aws/deploy/eks-compatibility/ page shows the compatibility of KF 1.2. Can you please add the compatibility matrix for KF 1.3 as well? Thanks!

AWS Distribution of Kubeflow-1.3.1 is live
Please refer to what’s new: https://github.com/awslabs/kubeflow-manifests/releases/tag/v1.3.1-aws-b1.0.0
For documentation, please refer to the Kubeflow.org website: https://www.kubeflow.org/docs/distributions/aws/
If you have any issues, please refer to the help and feedback section: https://github.com/awslabs/kubeflow-manifests/tree/v1.3-branch#help--feedback
/close


octodns-sync fails when TXT field "too long"

Following the instructions on how to input longer then 255 character TXT fields in Dyn, octodns-sync will fail to sync the multi-segmented TXT records correctly between providers to route53. When I tested the multi-segmented TXT sync from configuration to route53, it also fails.
Both providers require the multi-segmented TXT to be quoted segments without spaces between each segment.
The use of the multi-segment TXT records is for greater then 2048k DKIM records, which are becoming more commonly required.

Hi @brianeclow this is actually a problem one of my coworkers @antonio ran into a couple weeks ago. It's an oversight in the implementation, something I didn't even know was possible and thus didn't allow for/implement a solution to. It'll take a bit of digging and thinking to come up with an appropriate solution to. I think that octoDNS should be able determine when a record needs to be broken up into multiple segments automatically and do the right thing with the provider, but haven't yet been able to implement that and verify for sure.

this is actually a problem one of my coworkers @antonio ran into a couple weeks ago

My bad, I have been meaning to open this issue for a while but couldn't find the time. Thanks for raising this issue @brianeclow !

PR with WIP fix for this is https://github.com/github/octodns/pull/115

Awesome. Thank you on the quick turn around. Do you have an idea when you will be cutting the next version with this patch?

Awesome. Thank you on the quick turn around. Do you have an idea when you will be cutting the next version with this patch?

I'll probably hold off until the google cloud provider has landed to avoid doing 2 quick releases. In the meantime a pip/requirements.txt line like the following should grab it:
-e git+ssh://git@github.com/github/octodns.git@e0f357d9f9c041238b069b5fc4c1f4c663bf16a8#egg=octodns

Did this break? I've got a DKIM record that is >255 characters and octodns 0.9.6 returns this with an unchunked value at the end:
2019-09-17T17:40:15  [140441762571072] INFO  Route53Provider[route53] _apply:   sending change request for batch of 1 mods, 1 ResourceRecords
Traceback (most recent call last):
  File "/usr/local/bin/octodns-sync", line 11, in <module>
    load_entry_point('octodns', 'console_scripts', 'octodns-sync')()
  File "/src/octodns/octodns/cmds/sync.py", line 39, in main
    dry_run=not args.doit, force=args.force)
  File "/src/octodns/octodns/manager.py", line 313, in sync
    total_changes += target.apply(plan)
  File "/src/octodns/octodns/provider/base.py", line 143, in apply
    self._apply(plan)
  File "/src/octodns/octodns/provider/route53.py", line 745, in _apply
    self._really_apply(batch, zone_id)
  File "/src/octodns/octodns/provider/route53.py", line 756, in _really_apply
    HostedZoneId=zone_id, ChangeBatch=batch)
  File "/usr/local/lib/python2.7/site-packages/botocore/client.py", line 314, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/site-packages/botocore/client.py", line 612, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.errorfactory.InvalidChangeBatch: An error occurred (InvalidChangeBatch) when calling the ChangeResourceRecordSets operation: [Invalid Resource Record: FATAL problem: CharacterStringTooLong (Value is too long) encountered with '"v=DKIM1\; k=rsa\; p=MIIB...

The config file looks like this:
mail._domainkey:
  ttl: 120
  type: TXT
  values:
  - v=DKIM1\; k=rsa\; p=MIIB...<record is 417 characters>


API to support sampling behavior in xDS matcher

This is the API change for issue: https://github.com/envoyproxy/envoy/issues/30147.
Adding a skip_percentage in the Matcher proto to control how much percentage of traffic will go to ext_proc or logging server after matching condition is met.
The name of the configuration is skip_percentage not sampling_percentage as by default skip_percentage is zero.  sampling_percentage  = 1 - skip_percentage.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @htuch @rshriram @kyessenov

/wait (for CI to be green)

/assign @yanavlasov @tyxia

For reviewers, the complete prototyping of the solution is: https://github.com/envoyproxy/envoy/pull/34611.

There is ongoing discussion internally on the direction of this PR. We can start the review once that is settled.
BTW, @yanjunxiang-google  should we just review https://github.com/envoyproxy/envoy/pull/34611, which has complete picture of this feature. I don't have strong opinion though

There is ongoing discussion internally on the direction of this PR. We can start the review once that is settled.
BTW, @yanjunxiang-google should we just review #34611, which has complete picture of this feature. I don't have strong opinion though

I am fine either to review the API separately or review the entire solution as a whole.  Review the API separately has the benefit to focus on the API itself before going into the details of the implementation.

Noticed https://github.com/envoyproxy/envoy/pull/34611 is being reviewed. Let me close this PR.


Changed Homepage Dropdown Menu

Added Translations for the Languages that were from the Latin Alphabet. #570

You don't need to edit translations manually

I just wanted to see the page display properly and you know when in Rome...


NUTS Classic Broken

Summary:
The NUTS "classic" sampler suffers from the same problems that were addressed in #2180.
Description:
The NUTS "classic" sampler grabs the wrong left subtree boundary which technically renders if invalid.  The right subtree also needs its own local rho to compute valid termination criteria.  The classic code isn't user facing, but should be fixed in case we expose it in the future.
Current Version:
v2.13.1

Upon inspection NUTS "classic" does the subtrees correctly and the bug was inadvertently introduced when the new version was created.


🧪 PIP_COMPILE_DISABLE

enforce PIP_COMPILE_DISABLE in ci/cd

:tada: This PR is included in version 1.9.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Perf]Prevent resizable component rerenders

Description
This PR contains changes for Preventing re-renders of Resizable component on keyPress on top of selectively-update-redux-store branch.
This is a draft PR, To test performance on deploy Preview and check for complete suite of Integration tests.
Fixes # (issue)
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Checked Profiler for Re-renders of Resizable component.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=059cdd8

/ok-to-test sha=0e27158


testing: panic + Skip is not reported as a failure, though Error + Skip is

What version of Go are you using (go version)?

$ go version
go version go1.18.3 darwin/arm64

Also reproduced on Go Playground using 1.17, 1.18, and latest dev branch.
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/prashant/Library/Caches/go-build"
GOENV="/Users/prashant/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/prashant/go/pkg/mod"
GONOPROXY="github.com/chronosphereio"
GONOSUMDB="github.com/chronosphereio"
GOOS="darwin"
GOPATH="/Users/prashant/go"
GOPRIVATE="github.com/chronosphereio"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/prashant/.gimme/versions/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/prashant/.gimme/versions/go/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.3"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/prashant/tmp/panic-skip/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/2f/kn4pgn0x5dv1nqm97qh06sch0000gp/T/go-build1443169597=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Called t.Skip inside of a cleanup function, for a test that failed due to a panic.
func TestCleanupSkipPanic(t *testing.T) {
	t.Cleanup(func() {
		t.Skip("skip: t.Failed() = ", t.Failed())
	})
	panic("fail")
}

See playground for other similar tests and how they behave:
https://go.dev/play/p/zK1cXf5iAG5
What did you expect to see?
Expected the test to be marked as failed due to the panic.
What did you see instead?
The test was marked as skipped, and the cleanup function (or defer) reported the test as not failed.
=== RUN   TestCleanupSkipPanic
    prog.go:21: skip: t.Failed() =  false
--- SKIP: TestCleanupSkipPanic (0.00s)

cc @bcmills

Duplicate of #49929


[CORE] [SPARK-9760] Use Option instead of Some for Ivy repos

This was introduced in #7599
cc @rxin @brkyvz

Also I am not sure how to add a test case for this as our existing unit tests use a custom Ivy repository which is always specified in --repositories. The bug only happens when --repositories is not specified

Merged build triggered.

Merged build started.

Test build #40255 has started for   PR 8055 at commit c02e0b4.

LGTM - @brkyvz this is why our coding style wants Option instead of Some!

Sorry for introducing this. A way to test this is to not provide a repository, and use a fake coordinate so that it fails with a RuntimeException, and not a NullPointerException.

Added a test case but I'm not sure how useful it is as a lot of things can throw a RuntimeException ? @rxin let me know if its worth having it vs. a few seconds added to the test suites.

Merged build triggered.

Merged build started.

Test build #40257 has started for   PR 8055 at commit 51d69ee.

I see why SparkSubmitUtilsSuite didn't catch this. I think I use either Some(repo) or none. Never Some(null). I thought we could add it to SparkSubmitUtilsSuite and use the intercept, not in an end to end SparkSubmitSuite test... May be you can add a comment on the line and say that they should remain as Options? I don't think the test is very useful in the current setup

Test build #40255 has finished for   PR 8055 at commit c02e0b4.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait DataSourceRegister

Merged build finished. Test FAILed.

Test build #40257 has finished for   PR 8055 at commit 51d69ee.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #40260 has started for   PR 8055 at commit 51d69ee.

Test build #40260 has finished for   PR 8055 at commit 51d69ee.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Test build #40273 has started for   PR 8055 at commit 51d69ee.

@brkyvz Removed the test case now. I'm not sure adding a comment is really relevant as the argument to the method is an Option. And you are right that we can't quite test this in SparkSubmitUtilsSuite as passing None wouldn't trigger the bug.

Merged build triggered.

Merged build started.

Test build #40274 has started for   PR 8055 at commit 890f306.

Test build #40273 has finished for   PR 8055 at commit 51d69ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merging this - thanks.

Hallelujah! Finally

Test build #40274 has finished for   PR 8055 at commit 890f306.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.


Improve documentation for public consumption

Improve documentation such that it is consumable as an open-source project. This should include any basic rationale about tuning, why or when to use this, examples, dataset sizes we have, etc.

We should also have a better list of features and publish the API docs somewhere maybe. There's probably some need to normalize and fix some of the scaladoc comments/documentation.

Improve scaladocs, and add publishing the scaladocs API to GitHub as part of the release lifecycle.
E.g. https://alvinalexander.com/scala/how-to-generate-scala-documentation-scaladoc-command-examples

See: https://github.com/sbt/sbt-ghpages

Scaladoc looks good now. Adding publishing to pages.


No bounding boxes around the object!

I am using frozen_inference_graph generated after training with my dataset.
The same frozen_inference_graph.pb works fine with my Android Device. But in iOS I do not see any boxes around my objects.
I used your repository and executed it with the ssd_mobilenet_v1_coco_11_06_2017 model. It works fine. But my frozen_inference_graph is not working fine.
My files are added to the folders correctly and removed other models from the models folder. References are created accordingly. Also, changed my label_map file according to my trainig set. I don't know where I am going wrong.
Please help with this.
Thanks in advance.

It is at the top of TensorflowGraph.mm, line 15, and set to 50%.   Inference scores below that value are ignored.   The actual logic of ignoring anything below the threshold is on line 240 of that same file.  You could inspect your scores coming out of your graph there.

I tried to change the threshold value. Seems like the error is with loading the model file.
2018-05-18 10:44:02.784622+0530 tensorflowiOS[3924:1996601] [MC] System group container for systemgroup.com.apple.configurationprofiles path is /private/var/containers/Shared/SystemGroup/systemgroup.com.apple.configurationprofiles 2018-05-18 10:44:02.785697+0530 tensorflowiOS[3924:1996601] [MC] Reading from public effective user settings. 2018-05-18 10:44:03.665824: E /Users/oraclechatbot/Desktop/tensorflowiOS/swift/Tensorflow/TensorflowUtils.mm:99] Could not create TensorFlow Graph: Not found: Op type not registered 'GatherV2' in binary running on iPhone. Make sure the Op and Kernel are registered in the binary running in this process. 2018-05-18 10:44:03.675079+0530 tensorflowiOS[3924:1996748] Failed to load model
This is the message from the console.

Sorry for the delay,  Did you ever figure this out?   Please verify that you built the iOS libs with ANDROID_TYPES_FULL . I have seen errors similar to yours when loading a graph using a Tensorflow build where i've forgotten to set that.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.3 to before v4.4.272",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=7c18d2205ea76eef9674e59e1ecae4f332a53e9e",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a3536dce5895f714d9eead8afb92629a3fb5875b"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "7c18d2205ea76eef9674e59e1ecae4f332a53e9e",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "a3536dce5895f714d9eead8afb92629a3fb5875b",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: caif: add proper error handling\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.4.272 by commit a3536dce5895f714d9eead8afb92629a3fb5875b, it was introduced in version v3.3 by commit 7c18d2205ea76eef9674e59e1ecae4f332a53e9e. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1000712


feat: completing the MPC ceremony 🙏

I can't commit the radix files because they're over 500mb in size. We'll think of a different solution. In the meantime I'm creating this PR so we can see the diff.
Closes #282

Just pushed a new version that will fetch radix files from a public s3 repo

Here's exactly what is changed:

Radix files are stored in an S3 bucket, which link is set in an env variable. They're ignored in gitignore and nodemon.
I added a port in docker-compose.dev.yml so we can (in dev) access the different endpoints without having to run the whole ./start-nightfall in future development
At index.mjs, node checks if the radix files are already present in the volume. If not, it will get them from the provided url.
At generateKeys.mjs the phase2 starts. It computes the mpc.params from the radix files. Then makes a secure pseudo-random number using crypto and contributes to it. It then generates another random number and applies a random beacon to it. The result is final.params. It then takes these params and creates the proving and verifying keys. After that, the process continues as previous.
I obviously removed the old setup command and file, as it's replaced with this trusted setup now

So far I haven't seen any problem regarding RAM constraints, and I was able to run the MPC successfully (although quite visibly slower) with 8gb RAM


[Website] Image docs should link to the data URI requirements/limitations

We mention that data URI is supported, but don't call out the size or other limitations. We should update the schema docs to link to the specific constraints, similar to what we do with TextBlock markdown support

URL: https://adaptivecards.io/explorer/Image.html

#6316


should vs. shall in floating-point rm field text

In the current base ISA spec there is this text:
Some instructions that have the {\em rm} field are nevertheless unaffected by the rounding mode; they should have their {\em rm} field set to RNE (000).
Would the word "shall" be a better fit than "should" in this instance? In other words, it is absolutely required that assemblers set the rm field to RNE for instructions that are unaffected the by the rounding mode?

It is not absolutely required; these instructions execute the same way if rm is set to some other valid value.  So, "should" is the better wording in this case.

To help clarify can you give an example of an F extension instruction that has an rm field, is unaffected by rounding modes, "should" have it's rm field set to 000, but is legal to set the field to something other than 000? What specifically was this text going after?
Part of the confusion is that the spec is to me inconsistent with the field naming of bits 14:12. In the Chapter 25 table the four possible instruction formats all refer to these more generically as funct3, with only certain instructions calling those funct3 fields 'rm'. While the chapter 11 descriptions refer to all OP-FP and F[N]MADD/F[N]MSUB 14:12's as 'rm', with the fields being 'RM' for certain instructions. Some instructions use 14:12 as part of the decode and seem more appropriate to call the related field funct3 instead of rm (e.g. FMIN / FMAX). So from all this it's not clear which instructions "have an rm field" as far as this text is concerned.
I agree that instructions that are unaffected by rounding modes should obviously be unaffected, but the labeling differences between the chapter 25 table and the chapter 11 text make it unclear to me which instructions have rm fields and which just have funct3 fields that are part of the decode.
One possible case I see where an instruction unambiguously has an rm field and does not round is FCVT.D.S. But this instruction is part of the D extension, not the F extension where the text I mentioned is located.

"Have an rm field" = "Have a field named rm in the instruction listings."  So the comment doesn't apply to FMIN, for example.
The last paragraph you wrote is what we were going for.  Another example besides FCVT.D.S is FCVT.D.W[U].

I'd like to leave the text where it is, but I agree it deserves some clarification.  Will push something shortly.

Thanks Andrew.


Refresh data of the DataGrid

Hello,
I've followed the steps described here https://github.com/MyToolkit/MyToolkit/wiki/ViewModelBase, but I can't refresh the data of the DataGrid, whereas the first load works well.
My ViewModel looks like this:
`
public class HomeViewModel : ViewModelBase
{
...
private SQLiteDataService sqliteDataService;
	private ObservableCollection<Car_Form> _carForms;
	public ObservableCollection<Car_Form> CarForms
	{
		get { return _carForms; }
		set { Set(ref _carForms, value); }
	}

	public HomeViewModel()
	{
		this.sqliteDataService = new SQLiteDataService();
		...
	}

	public void LoadCar_Forms()
	{
		List<Car_Form> carForms = sqliteDataService.GetCar_Form();
		_carForms = new ObservableCollection<Car_Form>(carForms);
	}

	public void RefreshCar_Forms()
	{
		Car_Form newCarForm = new Car_Form{ ... };
		sqliteDataService.InsertCar_Form(newCarForm);
		LoadCar_Forms();
	}
}

`
And my XAML looks like this:
    <controls:DataGrid x:Name="DataGrid" Grid.Row="1"     				   ItemsSource="{Binding CarForms}"     				   SelectionMode="Single"     				   DefaultOrderIndex="1">     	<controls:DataGrid.Columns>     		<controls:DataGridTextColumn Width="*" Header="Form Nr" Binding="{Binding form_id}" />     		<controls:DataGridTextColumn Width="*" Header="Submitter" Binding="{Binding submitter}" />     		<controls:DataGridTextColumn Width="*" Header="Company" Binding="{Binding company}" />     		...     	</controls:DataGrid.Columns>     </controls:DataGrid>
And the Model looks like this:
    public class Car_Form     {     	[PrimaryKey, NotNull]     	public int form_id { get; set; }     	[MaxLength(100), NotNull]     	public string form_code { get; set; }     	[MaxLength(200), NotNull]     	public string submitter { get; set; }     	...     }
When I enter the first time in LoadCar_Forms() the data are well displayed: there is no problem with SQLite.
When I try to refresh the data, I enter in RefreshCar_Forms() and I call again LoadCar_Forms(), but the new data are not displayed in the DataGrid.
But if I close and relaunch the app, the new data is this time correctly loaded and displayed!
Where is my mistake?

In LoadCar_Forms you need to assign the property instead of the field:
CarForms =

Oh right thank you...
`


Proofread microbenchmark docs for STREAM, OSU microbenchmarks, and DGEMM

Please proofread the microbenchmark docs for STREAM, OSU microbenchmarks and DGEMM to make sure they make sense from a third party POV.

STREAM questions:

Which optimization flags were used? I assumed -O2 -fopenmp as is done here: https://github.com/jeffhammond/STREAM/blob/master/Makefile
Were MPI ranks bound to cores? I assumed yes, and the srun commands now include --cpu-bind=core
Was the stream-mpi.exe executable used? I assumed yes, and the srun commands now reflect that
Was the STREAM_ARRAY_SIZE set to 40,000,000 rather than 40? That appears to give similar results to what is on the page (I used gcc 9.4.0 and openmpi/3.1.6 on Darwin's spr-hbm partition)

STREAM changes:

Defined compile time pre-processor constants (-DSTREAM_ARRAY_SIZE=40000000 -DNTIMES=20) in the build section along with optimization flags (-O2 -fopenmp)
Added example make command to the build section
Added export OMP_NUM_THREADS=1 to the running section commands
Added --cpu-bind=core to the srun command
Changed the executable in the running examples from ./stream to ./stream-mpi.exe
Fixed typo where STREAM_ARRAY_SIZE=40 is now STREAM_ARRAY_SIZE=40000000

OSUMB questions:

Would it be helpful to add the commands to run each of the tests? I think the table in the Running section gives enough info, but I wanted to double-check with you.

OSUMB changes:

Added a sentence under the Purpose section.

DGEMM questions:

I do not see the dgemm_omp_fixes.patch file referenced in the documentation. I am leaving that as is for now.
Maybe this is a Darwin thing, so I'll check on Roci, but I needed to modify the makefile pass in the include directory containing cblas.h, and LDFLAGS was not passed to the make rule and wasn't linking. I did not check Makefile.intel yet.

DGEMM changes:

Fixed typo in Example Results section that mentioned Branson instead of DGEMM
(Tentative) Updated Makefile to pass LDFLAGS to the make rule and to append to CFLAGS rather than overwrite CFLAGS. Did not make any changes to Makefile.intel
(Tentative) Updated make command in documentation to reference passing the include directory. It is now make CFLAGS=-I<openblas_include_dir>

Done!


It copies only folder to my drive .

Are you requesting a feature or reporting a bug?
If reporting a bug, is there already an issue open for this same bug?
What is the current behavior?
What is the expected behavior?
How would you reproduce the current behavior (if this is a bug)?
Specify your

operating system:
browser:

no idea what this issue title means


delay work in final method checks until we absolutely need it

We do a lot of computations during final method checks eagerly, potentially throwing away the results if we determine we don't need to do the full amount of checking.  We shouldn't do that, because in many cases the work can be delayed until we need it.
In _check_final_ancestors, we can probably avoid doing either the ancestors computation or determining instance methods, should one or the other say we don't need it.  I want to try and get numbers tomorrow; my hunch is that it's faster to compute instance methods, reject everything that's never been final, and then early exit if we don't have any methods to check.
Motivation
Speed.
Test plan

See included automated tests.

This makes things go faster and doesn't break anything, so let's put it up for review.

Probably best if we re-roll this one. :( I don't have much context on this.


364 overlap wrangle

Using pythons diff lib to find the similarity match of two columns
wrangles:
    - find_match:
        input_a: col1
        input_b: col2
        output: TEST

col1
col2
TEST

mario
supermario
*****mario

luigi
superluigi
*****luigi

peach
superpeach
*****peach

yoshi
superyoshi
*****yoshi

equal
equal
EXACT_MATCH

no match
A EMPTY

no match

B EMPTY

BOTH EMPTY

Closing. This will be merged with #533 PR


Update office-deployment-tool-configuration-options.md

Added 2007 version of Office as also being removed by RemoveMSI parameter. (see referenced article for validation https://docs.microsoft.com/en-us/officeupdates/odt-release-history#june-9-2020)

@MsCharisa -- Thanks for submitting this update. We'll also be updating this topic soon -- https://docs.microsoft.com/DeployOffice/upgrade-from-msi-version.


Fix unescaped backslashes in JSON produced by GPT

Fixes https://github.com/spatie/ignition/issues/264.

Thanks!


video data from ChiPy in March 2016 (courtesy CarlFK)

"ChiPy Python Mentorship" http://veyepar.nextdayvideo.com/main/C/chipy/S/chipy_march_2016.json?id=10841
"The wonder and the horror of the mock module" http://veyepar.nextdayvideo.com/main/C/chipy/S/chipy_march_2016.json?id=10843
"Python-based data science to understand knowledge discovery and expertise: A science perspective" http://veyepar.nextdayvideo.com/main/C/chipy/S/chipy_march_2016.json?id=10840
Scraper likely not necessary, json metadata might not be perfect.  If more info is needed, stick it in a comment.

Looks good :) https://github.com/zerok/pytube-importer-depy2016 should be usable for this :)


stack level too deep (SystemStackError) with rspec-expectations

Hi @myronmarston,
I'm on my way down the rabbit hole to support 1.9.3. and 1.8.7 for aruba. Now I'm facing this error every time I use a negated alias for a matcher on ruby 1.9.3. I use rspec-expectation 3.3.
/home/user/.rvm/gems/ruby-1.9.3-p551/gems/rspec-expectations-3.3.0/lib/rspec/matchers.rb:972: stack level too deep (SystemStackError)

and I'm not sure if it's a bug or a mistake by me. This is a minimum failing example which works fine on 1.8.7 and > 2.0, but not on 1.9.3. I think rspec's code takes a "different route" for 1.8.7, so maybe it's the way ruby 1.9.3 behaves in contrast to > 2.0.
require 'rspec/expectations'

RSpec::Matchers.define :run_too_long do
  match do |actual|
    true
  end
end

RSpec::Matchers.define_negated_matcher :have_finished_in_time, :run_too_long

include RSpec::Matchers

expect('command').to run_too_long
$stderr.puts 'run too long works'

expect('command').to have_finished_in_time
$stderr.puts 'have finished in time not'

These are the installed gems:
Gems included by the bundle:
  * archive-tar-minitar (0.5.2)
  * aruba (0.8.0)
  * ast (2.0.0)
  * astrolabe (1.3.0)
  * bcat (0.6.2)
  * binding_of_caller (0.7.2)
  * builder (3.2.2)
  * bundler (1.10.5)
  * childprocess (0.5.6)
  * coderay (1.1.0)
  * columnize (0.9.0)
  * contracts (0.9)
  * cucumber (1.3.20)
  * cucumber-pro (0.0.17)
  * debug_inspector (0.0.2)
  * debugger (1.6.8)
  * debugger-linecache (1.2.0)
  * debugger-ruby_core_source (1.3.8)
  * diff-lcs (1.2.5)
  * docile (1.1.5)
  * domain_name (0.5.24)
  * eventmachine (1.0.7)
  * faye-websocket (0.9.2)
  * ffi (1.9.10)
  * fuubar (2.0.0)
  * gherkin (2.12.2)
  * http-cookie (1.0.2)
  * httparty (0.13.5)
  * json (1.8.3)
  * kramdown (1.7.0)
  * license_finder (2.0.4)
  * method_source (0.8.2)
  * mime-types (2.6.1)
  * multi_json (1.11.1)
  * multi_test (0.1.2)
  * multi_xml (0.5.5)
  * netrc (0.10.3)
  * parser (<IP_ADDRESS>)
  * powerpack (0.1.1)
  * pry (0.10.1)
  * pry-debugger (0.2.3)
  * pry-doc (0.8.0)
  * pry-stack_explorer (<IP_ADDRESS>)
  * rack (1.6.4)
  * rainbow (2.0.0)
  * rake (10.4.2)
  * relish (0.7.1)
  * rest-client (1.8.0)
  * rspec (3.3.0)
  * rspec-core (3.3.1)
  * rspec-expectations (3.3.0)
  * rspec-mocks (3.3.1)
  * rspec-support (3.3.0)
  * rubocop (0.32.1)
  * ruby-progressbar (1.7.5)
  * simplecov (0.10.0)
  * simplecov-html (0.10.0)
  * slop (3.6.0)
  * thor (0.19.1)
  * unf (0.1.4)
  * unf_ext (<IP_ADDRESS>)
  * websocket-driver (0.5.4)
  * websocket-extensions (0.1.2)
  * xml-simple (1.1.5)
  * yard (<IP_ADDRESS>)

This is the installed ruby:
ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-linux]

Can you have a look at this? Thanks in advance.
Cheers,
Dennis

Here's the output of all rubies tested
$ bundle exec /home/user/.rvm/rubies/ruby-1.8.7-head/bin/ruby test2.rb

run too long works
/home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-support-3.3.0/lib/rspec/support.rb:86: expected "command" to have finished in time (RSpec::Expectations::ExpectationNotMetError)
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-support-3.3.0/lib/rspec/support.rb:93:in `call'
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-support-3.3.0/lib/rspec/support.rb:93:in `notify_failure'
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-expectations-3.3.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:50:in `handle_matcher'
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
        from /home/user/.rvm/gems/ruby-1.8.7-head/gems/rspec-expectations-3.3.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
        from test2.rb:16

$ bundle exec /home/user/.rvm/rubies/ruby-1.9.3-p551/bin/ruby test2.rb
run too long works
/home/user/.rvm/gems/ruby-1.9.3-p551/gems/rspec-expectations-3.3.0/lib/rspec/matchers.rb:972: stack level too deep (SystemStackError)

$ ruby -v
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]

$ bundle exec /usr/bin/ruby test2.rb
run too long works
/home/user/.gem/ruby/2.2.2/gems/rspec-support-3.3.0/lib/rspec/support.rb:86:in `block in <module:Support>': expected "command" to have finished in time (RSpec::Expectations::ExpectationNotMetError)
        from /home/user/.gem/ruby/2.2.2/gems/rspec-support-3.3.0/lib/rspec/support.rb:93:in `call'
        from /home/user/.gem/ruby/2.2.2/gems/rspec-support-3.3.0/lib/rspec/support.rb:93:in `notify_failure'
        from /home/user/.gem/ruby/2.2.2/gems/rspec-expectations-3.3.0/lib/rspec/expectations/fail_with.rb:27:in `fail_with'
        from /home/user/.gem/ruby/2.2.2/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:40:in `handle_failure'
        from /home/user/.gem/ruby/2.2.2/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
        from /home/user/.gem/ruby/2.2.2/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
        from /home/user/.gem/ruby/2.2.2/gems/rspec-expectations-3.3.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
        from /home/user/.gem/ruby/2.2.2/gems/rspec-expectations-3.3.0/lib/rspec/expectations/expectation_target.rb:54:in `to'
        from test2.rb:16:in `<main>'

Thanks for the detailed repro instructions!
It's certainly not user error on your part.  It looks like a bug in ruby 1.9.  I've pared it down to this minimal repro script:
max_stack_frames = 10

TooManyStackFrames = Class.new(StandardError)

set_trace_func proc { |event, file, line, id, binding, classname|
  if event == "call" && caller.size >= max_stack_frames
    raise TooManyStackFrames, "Stack has exceeded #{max_stack_frames} frames"
  end
}

module MyModule
  def respond_to_missing?(method, *)
    super
  end
end

class MyClass
  include MyModule

  def respond_to_missing?(method, *)
    super
  end
end

include MyModule

instance = MyClass.new
instance.respond_to?(:some_method)

This triggers the stack overflow error:
foo.rb:7:in `block in <main>': Stack has exceeded 10 frames (TooManyStackFrames)
	from foo.rb:12:in `respond_to_missing?'
	from foo.rb:13:in `respond_to_missing?'
	from foo.rb:13:in `respond_to_missing?'
	from foo.rb:13:in `respond_to_missing?'
	from foo.rb:13:in `respond_to_missing?'
	from foo.rb:13:in `respond_to_missing?'
	from foo.rb:13:in `respond_to_missing?'
	from foo.rb:21:in `respond_to_missing?'
	from foo.rb:28:in `respond_to?'
	from foo.rb:28:in `<main>'

Note that this problem only occurs if you include RSpec::Matchers on main.  Is there a reason you have to do that for aruba?  Besides causing this problem, it also makes all the RSpec::Matchers methods available on EVERY object in the system which is clearly not desirable.
Anyhow, I'm not yet sure what we can do about this since it appears to be a bug in Ruby.

Note that this problem only occurs if you include RSpec::Matchers on main.

No, we include Aruba::Matchers in Aruba::Api / Aruba::Api::Core. But the problem is the same. I only used "main" to reduce the noise.
Thanks for the detailed explanation.

No, we include Aruba::Matchers in Aruba::Api / Aruba::Api::Core. But the problem is the same. I only used "main" to reduce the noise in the bug report.

I tried to come up with a repo case that does not involve main and I could not.  I'd like to see what you are doing...can you provide an aruba branch that repros the problem and tell me what spec to run?

No, problem: This is the PR and this the branch. You need to make some adjustments here and here. It needs to be run_too_long for the "positive" case and have_finished_* for the negative one. Then try one test from these.

Sorry, try feature/hooks/before/command.feature. One of the test.rb's failed.

And I think you're right. In this example we use main.

  Scenario: Run a simple command with a before hook
    Given a file named "test.rb" with:
      """
      require 'aruba/api'

      Aruba.configure do |config|
        config.before :command do |cmd|
          puts "about to run `#{cmd}`"
        end
      end

      include Aruba::Api
      setup_aruba
      run_simple("echo 'running'")
      puts last_command.stdout
      """
    When I run `ruby test.rb`
    Then it should pass with:
      """
      about to run `echo 'running'`
      running
      """

Do all of the places that exhibit this problem use main?  If there are any that do not, I'd still like to see them.

If I remember correctly only the tests for the before and after-hooks showed the problem. So no I'm no aware of any other tests which failed with StackLevel too deep.

So I've realized that this is an MRI bug I've seen before:
https://redmine.ruby-lang.org/issues/5236
Unfortunately, when you include a module in main in 1.9, if that module has already been included in any classes, and has any methods that use super, they will infinitely recurse.  I don't know of a way for RSpec to fix this.  There's a pretty easy work around for your use in aruba, though...
Define a file like features/support/work_around_mri_19_module_bug.rb:
if RUBY_VERSION[0, 3] == '1.9'
  # MRI 1.9 has a bug where including a module in a superclass after it has been
  # included in a subclass causes uses of `super` to infinitely recurse. We want
  # to include `RSpec::Matchers` in `main` for easy demonstration in our scenarios,
  # but doing so triggers this bug because modules included in `main` get included
  # in `Object` and `RSpec::Matchers` is also included in custom RSpec matchers as well.
  #
  # Our work around here is to provide this file which can be loaded before RSpec
  # is loaded in order to include `RSpec::Matchers` in `main` BEFORE it is included
  # in anything else.
  #
  # For more info on this bug see:
  #
  # - https://redmine.ruby-lang.org/issues/5236
  # - https://redmine.ruby-lang.org/issues/3351
  module RSpec
    module Matchers
    end
  end

  include RSpec::Matchers
end

Then in your cucumber environment, export the RUBYOPT environment variable:
RUBYOPT="-r ./features/support/work_around_mri_19_module_bug"

That will work around the bug by ensuring RSpec::Matchers is included in main before it is included in anything else.  In your cucumber scenarios you can still do the inclusion into main; it'll just be a no-op at that point to avoid this bug.

Wow, thanks a lot! Having such a workaround is definitively helpful.
I'll need to make up my mind how to go on. I'm not sure if I like OUR test setup at this place. Using aruba like this seems a little bit out of scope for the library. I'm not sure if we really need those hooks from 1.0.0 on. Maybe I change the feature test. I plan to use those tests as documentation like you do at rspec and as this does not really show how aruba should be used, maybe this should be rewritten. But anyway, thanks a lot that you helped me! :smile:


Using API Gateway ANY method yields 500 when invoking

I'd like to be able to set up event triggers to proxy http requests from Api Gateway.  Notice how I have an any method event for the /pets, and /pets{petId} paths.
AWSTemplateFormatVersion: 2010-09-09
Transform: AWS::Serverless-2016-10-31
Description: aws-lambda-rest example for pets endpoints

Resources:
  PetsResource:
    Type: AWS::Serverless::Function
    Properties:
      Handler: io.andrewohara.pets.PetsResource
      Runtime: java8
      CodeUri: ./kobaltBuild/libs/example-pets-0.0.1.jar
      Timeout: 30
      MemorySize: 1024
      Events:
        Pets:
          Type: Api
          Properties:
            Path: /pets
            Method: any
        Pet:
          Type: Api
          Properties:
            Path: /pets/{petId}
            Method: any

The API Gateway appears to be set up correctly.  However, when I invoke the method, I get a 500 error.
Thu Mar 08 21:03:00 UTC 2018 : Execution failed due to configuration error: Invalid permissions on Lambda function
Thu Mar 08 21:03:00 UTC 2018 : Method completed with status: 500

This is easily fixed by explicitly writing out an event for each HTTP resource/path combination, but it would be nice to have this method supported, since API Gateway supports it.

This seems like is it a duplicate of #59. @oharaandrew314 would you agree?

Yes, this seems to be a duplicate.  Closing.


when line is too long, bufio.ReadLine may not read all data

when line is too long, bufio.ReadLine may not read all data

A test case for this would also be good.

I have add a test case for this and I'm sorry about the package name


Use default docker from platform in Github actions/CI

Signed-off-by: Pavol Loffay<EMAIL_ADDRESS>

Minikube needs new docker version. Running apt-get update on docker didn't help.


WIP: feat: introduce invocation-id into x-goog-api-client

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕

Closing in favor of design prototyped by @BenWhitehead in https://github.com/googleapis/java-storage/pull/1242


How to configure Rollbar transform in serilog app.config?

How would a reference to an Action<Payload> be configured in a .NET app.config file?  For reference, access token and environment are configured as follows:
<add key="serilog:write-to:Rollbar.accessToken" value="abcdefsadfasdfasdfsdfsafd"/>
<add key="serilog:write-to:Rollbar.environment" value="foobar"/>

It would also be helpful to show the appsettings.json for configuration as well.
I don't know if this works, but this is similar to samples from other sinks:
    "Serilog": {
        "Using": [
            "RollbarCom"
        ],
        "WriteTo": [
            {
                "Name": "Rollbar",
                "Args": {
                    "accessToken": "myAccessToken",
                    "environment": "production",
                    "proxyAddress": "myProxyAddress",
                    "scrubFields": {
                        "myFirstScrubField",
                        "mySecondScrubField"
                    },
                    "asyncLogging": true,
                },
                "restrictedToMinimumLevel": "Verbose"
            }
        ],
    }

In particular, I'm not sure if/how the sink will handle 'outputTemplate'--this is one that I'd appreciate clarity on.

Configuring rollbar directly in the appsettings file would be a handy feature. Or is there already a way to configure rollbar in appsettings?


Added Alert component example

Flash message example with Alert bootstrap component.

Merged with some adjustments, thanks!


Add cli flag to only include results if they have query strings

Add (-qs | --query-strings-only) flag to only include urls in outputs if they have query strings

I would suggest making these kind of filter operations a bit more uniform by adding a flag like --filter. This would let us implement something like --filter qs, to only allow URLs with query strings, but potentially also --filter scheme=http to only output URLs which specify a http scheme. Adding separate flags for all potentially useful options probably isn't a good idea usability-wise.

Nice idea, decided to add -m|--mode flags. Keeping in the other flags as well in case people prefer that option. If the amount of modes gets out of hand, we could of course remove those. Did some refactoring of the flag parsing as well (https://github.com/ameenmaali/urldedupe/commit/72f2c61def5f9a083fe9da8440a430db3a596408)


Resolved conflicts and updated BuddyTrail

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #143
Description
Added the hover effect the Exclusive Deals and Offers section , now the cards have the hover effects

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[x] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

@tusharmishra069 Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Wallet connect does not work on Brave Browser

Describe the bug
Connect to StarkNet does not work on Brave Browser. Assuming it must just be a setting.

Was this issue fixed? I was able to connect on brave with no problems


Script clean up

Major change of note is applying StandardJS to the "Cypher Systems by Roll20 Companion" script.
Also converted message strings to template literals and cleaned up some text.
Refactored some objects, functions, and variables for clarity.

This was supposed to be a PR for my fork, not the main repo. :)

This was supposed to be a PR for my fork, not the main repo. :)


libmem: add package

[libmem] add new port

I did my best to fulfill requests. But now it have to implement keystone port for xrepo, so we could advance further.

right, we need to add keystone first

@waruqi Should compile for linux as well now.

error: @programdir/core/sandbox/modules/os.lua:264: cannot runv(kstool -b x64 "mov rax, 1; ret"), No such file or directory
How come for capstone no such issue persists?

error: @programdir/core/sandbox/modules/os.lua:264: cannot runv(kstool -b x64 "mov rax, 1; ret"), No such file or directory How come for capstone no such issue persists? Maybe we need python 3 persisting on system?

        package:add("PATH", "bin")

->
        package:addenv("PATH", "bin")

How to enforce it to use /MD VS runtime?
Maybe I should not use set_policy("compatibility.version", "3.0") inside of xmake.lua files that relate to port, it is option only for ONLY people who compile projects?

#TODO fix Mac OS flags for keystone?

Also to mention, we can check CI Github builds there. And only one solution comes to make at least DLL /MD linkage working over Windows is go for:
    if is_plat("windows") then
        add_defines("LM_EXPORT")
    end

on_load(function (package)
        if package:is_plat("windows") then
            package:add("defines", "LM_EXPORT")
        end
    end)

How to enforce it to use /MD VS runtime BY DEFAULT?

please do not modify it.

这种根本用不到的 fuzz bin 完全可以不去编译，可以看下有没有 option 去禁用，或者打 patch 禁止编译它们。也就变相解决了链接问题，还能加速安装

[ 74%] Linking CXX executable fuzz_asm_arm_thumb.exe
cd /C/Users/runneradmin/AppData/Local/.xmake/cache/packages/2410/k/keystone/0.9.2/source/build_517176e1/suite/fuzz && "/C/Program Files/CMake/bin/cmake.exe" -E rm -f CMakeFiles/fuzz_asm_arm_thumb.dir/objects.a
cd /C/Users/runneradmin/AppData/Local/.xmake/cache/packages/2410/k/keystone/0.9.2/source/build_517176e1/suite/fuzz && /D/a/_temp/msys64/mingw64/bin/x86_64-w64-mingw32-g++.exe -m64 -m64 -O3 -DNDEBUG -m64 -m64 -Wl,--whole-archive CMakeFiles/fuzz_asm_arm_arm.dir/objects.a -Wl,--no-whole-archive -o fuzz_asm_arm_arm.exe -Wl,--out-implib,libfuzz_asm_arm_arm.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles/fuzz_asm_arm_arm.dir/linkLibs.rsp
D:/a/_temp/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/14.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: CMakeFiles/kstool.dir/objects.a(kstool.cpp.obj):kstool.cpp:(.text.startup+0x30): undefined reference to `getopt(int, char* const*, char const*)'
cd /C/Users/runneradmin/AppData/Local/.xmake/cache/packages/2410/k/keystone/0.9.2/source/build_517176e1/suite/fuzz && /D/a/_temp/msys64/mingw64/bin/x86_64-w64-mingw32-g++.exe -m64 -m64 -O3 -DNDEBUG -m64 -m64 -Wl,--whole-archive CMakeFiles/fuzz_asm_arm_armv8be.dir/objects.a -Wl,--no-whole-archive -o fuzz_asm_arm_armv8be.exe -Wl,--out-implib,libfuzz_asm_arm_armv8be.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles/fuzz_asm_arm_armv8be.dir/linkLibs.rsp
cd /C/Users/runneradmin/AppData/Local/.xmake/cache/packages/2410/k/keystone/0.9.2/source/build_517176e1/suite/fuzz && /D/a/_temp/msys64/mingw64/bin/ar.exe qc CMakeFiles/fuzz_asm_arm_thumb.dir/objects.a @CMakeFiles/fuzz_asm_arm_thumb.dir/objects1.rsp
collect2.exe: error: ld returned 1 exit status
cd /C/Users/runneradmin/AppData/Local/.xmake/cache/packages/2410/k/keystone/0.9.2/source/build_517176e1/suite/fuzz && /D/a/_temp/msys64/mingw64/bin/x86_64-w64-mingw32-g++.exe -m64 -m64 -O3 -DNDEBUG -m64 -m64 -Wl,--whole-archive CMakeFiles/fuzz_asm_arm_thumb.dir/objects.a -Wl,--no-whole-archive -o fuzz_asm_arm_thumb.exe -Wl,--out-implib,libfuzz_asm_arm_thumb.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles/fuzz_asm_arm_thumb.dir/linkLibs.rsp
make[2]: *** [kstool/CMakeFiles/kstool.dir/build.make:102: kstool/kstool.exe] Error 1

Lets hope my solution would work there... https://github.com/xmake-io/xmake-repo/pull/5430/commits/a33558cba5605fd705aae48d9e4182f95448eba2

Also to mention, we can check CI Github builds there. And only one solution comes to make at least DLL /MD linkage working over Windows is go for:
    if is_plat("windows") then
        add_defines("LM_EXPORT")
    end

on_load(function (package)
        if package:is_plat("windows") then
            package:add("defines", "LM_EXPORT")
        end
    end)

From previous time we saw Github CI managed to succeed with .LIB for Win. But had complete failure in case of .DLL
I hope now it will work for /MD at least.

ci 不要改。。仅仅处理包的问题

I made a few further commits by mistake related to github CI. I did not have intention to actually change github CI or adding few more dockerfiles.

I have tried to rebase it over. Should be good to go for now.

error: D:\a\xmake-repo\xmake-repo\packages\l\libmem\xmake.lua:34: ...gramdir\core\sandbox\modules\import\core\tool\linker.lua:75: @programdir\modules\core\tools\link.lua:175: _D63BF349A32043208DAD2EB2C15C6470.o : error LNK2019: unresolved external symbol "class std::optional<class std::vector<struct libmem::Thread,class std::allocator > > __cdecl libmem::EnumThreads(void)" (?EnumThreads@libmem@@YA?AV?$optional@V?$vector@UThread@libmem@@V?$allocator@UThread@libmem@@@std@@@std@@@std@@XZ) referenced in function "void __cdecl test(void)" (?test@@YAXXZ)
_D63BF349A32043208DAD2EB2C15C6470.o : error LNK2019: unresolved external symbol "class std::optional __cdecl libmem::GetThread(void)" (?GetThread@libmem@@YA?AV?$optional@UThread@libmem@@@std@@XZ) referenced in function "void __cdecl test(void)" (?test@@YAXXZ)
C:\Users\RUNNER~1\AppData\Local\Temp.xmake\241009_D63BF349A32043208DAD2EB2C15C6470.b : fatal error LNK1120: 2 unresolved externals
In case of /MD it just literally refers to my tests :(

error: @programdir/core/sandbox/modules/os.lua:264: cannot runv(kstool -b x64 "mov rax, 1; ret"), No such file or directory How come for capstone no such issue persists? Maybe we need python 3 persisting on system?

        package:add("PATH", "bin")

->
        package:addenv("PATH", "bin")

https://github.com/xmake-io/xmake-repo/actions/runs/11248590755/job/31275174488?pr=5430
Maybe I miss something?

I thinks you should split keystone package to seperate pr.

https://github.com/xmake-io/xmake-repo/pull/5459

Good idea. That already points in case keystone to /MD or /MT shared lib MSVC fails there in workflow for
Windows / build (windows-2019, shared, x86, MT) (pull_request) Failing after 8m
Windows / build (windows-2019, shared, x86, MD) (pull_request) Failing after 8m

https://github.com/xmake-io/xmake-repo/actions/runs/11257052776/job/31300394917?pr=5430

please remove keystone and rebase dev

We most likely need to exclude IPhoneOS according to
https://github.com/xmake-io/xmake-repo/pull/5474

Hopefully rdbo upstream this patch since in it's cmake build they don't exported either but seems to be intended as part of the api.

we can export symbols automatically.
https://github.com/xmake-io/xmake-repo/blob/9c99372efa88ade86d6c4911a4e7e74853113e75/packages/u/udt/xmake.lua#L27

error: ...es/private/action/require/impl/actions/patch_sources.lua:100: patch(/home/runner/work/xmake-repo/xmake-repo/packages/l/libmem/patches/cxxexport.patch): unmatched checksum!
stack traceback:

github ci 挂了 不知道为啥

https://www.githubstatus.com/

Maybe make it more strict only adding is_plat("windows") since other builds working?

Patch
diff --git a/packages/l/libmem/port/xmake.lua b/packages/l/libmem/port/xmake.lua
index b50db9ef..0f80bc20 100644
--- a/packages/l/libmem/port/xmake.lua
+++ b/packages/l/libmem/port/xmake.lua
@@ -8,12 +8,10 @@ target("libmem")

     if is_plat("windows") and is_kind("shared") then
         add_rules("utils.symbols.export_all", {export_classes = true, export_filter = function (symbol)
-            if symbol:find("libmem", 1, true) then
-                return true
-            end
+            return symbol:find("libmem", 1, true) and true or false
         end})
     end
-    if is_kind("shared") then
+    if is_plat("windows") or is_kind("shared") then
         add_defines("LM_EXPORT")
     end

diff --git a/packages/l/libmem/xmake.lua b/packages/l/libmem/xmake.lua
index 9e07cdd5..ed80ace1 100644
--- a/packages/l/libmem/xmake.lua
+++ b/packages/l/libmem/xmake.lua
@@ -21,7 +21,7 @@ package("libmem")
     end

     on_load(function(package)
-        if package:config("shared") then
+        if is_plat("windows") or package:config("shared") then
             package:add("defines", "LM_EXPORT")
         end
     end)

done