IE11 Blank Page

When running react-static start and using IE11, all I get is a blank page with no console errors. If I use react-static build, it seems to work.
I believe this to be an issue with dev mode not being transpiled to ES5. If this is indeed the issue, is there any way to run dev while transpiling to ES5?

Are you seeing any errors in the console?
Do you have a .babelrc file in your project root that points to react-statics preset?
Have you tried installing and importing babel-polyfill?

There are no errors in the console.
I do have a .babelrc that extends the one from react-static.
I also have tried installing and importing babel-polyfill.
Not sure what else to try at this point.

This was apparently an error with one or more of the many dependencies in my project.
I fixed it by adding the BabelEnginePlugin to webpack.

@Ericky14 How did you add BabelEnginePlugin?  I am struggling to get this implementation to work.  Any guidance to how you did so would be greatly appreciated.  I tried importing polyfill as well and did not have any luck either.

@abonventre
This is what I have on my static.config for webpack config.
    webpack: (config, args) => {
        config.plugins.push(
            new BabelEnginePlugin(
                {
                    presets: ['env', 'stage-0'],
                    plugins: [
                        'transform-decorators-legacy',
                        'babel-plugin-styled-components'
                    ]
                },
                {
                    verbose: false
                }
            )
        );

        if (args.stage === 'prod') {
            for (var i = 0; i < config.plugins.length; i++) {
                let plugin = config.plugins[i];

                if (plugin.constructor.name === 'UglifyJsPlugin') {
                    config.plugins.splice(i, 1);

                    config.plugins.push(
                        new uglify({
                            uglifyOptions: {
                                mangle: false,
                                compress: {
                                    hoist_props: false
                                }
                            }
                        })
                    );
                }
            }

            config.entry = ['babel-polyfill', config.entry];
        } else if (args.stage === 'dev') {
            config.entry = ['babel-polyfill', ...config.entry];
        }

        return config;
    }


Limit the max capacity of PooledByteBufAllocator

We limit the memory usage in another way, which limits the max capacity of both the heap memory and the non-heap memory in MemoryHealthChecker


Adding cli command for fixing variables in exercise configs when pipe…

…lines are updated.

Codecov Report

Merging #424 (e2ea459) into master (87b807c) will decrease coverage by 0.65%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   69.04%   68.38%   -0.66%
==========================================
  Files         431      432       +1
  Lines       15915    16067     +152
==========================================
  Hits        10988    10988
- Misses       4927     5079     +152

Impacted Files
Coverage Δ

...p/V1Module/presenters/ExercisesConfigPresenter.php
86.76% <ø> (ø)

app/commands/runtimes/FixConfigVariables.php
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b807c...e2ea459. Read the comment docs.


[🐞] translated routes from rewriteRoutes get ignored for [...catchall] route in same folder

Which component is affected?
Qwik City (routing)
Describe the bug
I have the following routing folder structure:

[lang]

[...uri]
projects

The paths /en/projects//de/projects are correctly rendered by the projectsroute folder.
Any other urls /en/some-pageor /de/example/some-other-sub-path get correctly rendered by the [...catchall] route folder.
For better i18n for the application i know wanted to use the new rewriteRoutes feature and added the following:
qwikCity({
      rewriteRoutes: [
        {
          prefix: '',
          paths: {
            'projects': 'projekte'
          },
        },
      ],
    })

Expected behavior:
/de/projekte/some-projekt should be rendered via the projects route folder.
Actual behavior:
Unfortunately this is not the case but i can see the catchall route is used instead. When deleting the catchall route from the folder structure the rewriteRoutes is working correctly though.
It seems that the catchall routes are matched before the routes defined via the rewriteRoutes config. Is this an expected behavior or is there a way to prioritise the rewriteRoutes?
Reproduction
https://stackblitz.com/edit/qwik-starter-jnup5o?file=vite.config.ts
Steps to reproduce

open reproduction
visit: https://qwikstarterjnup5o-s2um--5173--a2aabdd9.local-credentialless.webcontainer.io/de/projects
visit: https://qwikstarterjnup5o-s2um--5173--a2aabdd9.local-credentialless.webcontainer.io/de/projects/someproject
visit: https://qwikstarterjnup5o-s2um--5173--a2aabdd9.local-credentialless.webcontainer.io/de/somepage/test
visit: https://qwikstarterjnup5o-s2um--5173--a2aabdd9.local-credentialless.webcontainer.io/de/projekte/someproject

it renders the catchall route

delete or rename the [...uri] route folder
visit: https://qwikstarterjnup5o-s2um--5173--a2aabdd9.local-credentialless.webcontainer.io/de/projekte/someproject

it renders the projects route

System Info
System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 2.74 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.15.0/bin/yarn
    npm: 8.15.1 - ~/.nvm/versions/node/v16.15.0/bin/npm
  Browsers:
    Chrome: 120.0.6099.199
    Edge: 119.0.2151.46
    Safari: 17.2.1
  npmPackages:
    @builder.io/qwik: ^1.3.2 => 1.3.2
    @builder.io/qwik-city: ^1.3.2 => 1.3.2
    @builder.io/sdk-qwik: ^0.7.5 => 0.7.5
    undici: 5.26.0 => 5.26.0
    vite: 4.4.9 => 4.4.9

Additional Information
No response

Indeed, that can be considered a bug. Would you be interested in contributing a PR? The rewrites should happen before the route matching.

Alright, thanks for the confirmation that this is not an expected behavior. I hope to find some time the next few days to dig into this!

Damn, I was going to write exactly this issue. Will take a look if I can create a PR. Any clue @wmertens
Thanks

This is where routes are matched, you can look up the call chain from there.

This is where routes are matched, you can look up the call chain from there.
https://github.com/BuilderIO/qwik/blob/302b27eb7f6cd9c7e47c70cdfcf478c13c916faf/packages/qwik-city/middleware/request-handler/request-handler.ts#L20

Hi @wmertens , thanks for the tip. I finally realised the issue was at build time, as the rewritten routes were pushed at the end of the routes array, instead of the original route + 1 index.
Hope its all good and you can merge it soon!


Investigate Cmac::new_varkey performance implications

After a quick benchmark it appears that significant portion of the parsing of a packet is spend in transformation from keys::AES128 to Cmac::<Aes128>. That needs to be confirmed with additional tests and a way to perform this operation only once if possible should be found.

Fixed with #17


MSVC Support

Looks like MSVC does not support Higher order (lambda) functions with auto properly.
However we can return lambdas from template functions and lambda template variables:
https://godbolt.org/z/MG74eo


Requirements

What version of ios is required to build this stuff?

"This stuff" can be built on any iOS 4.x-5.0.

Thanks. Gonna tune it for ios3.

Try to build it for iOS 3 without any changes: may be it'll work. It doesn't hardly depend on version-specific API.


Update database semantic conventions

Release v0.6.0 of the opentelemetry spec included some changes to the
database semantic conventions, among them being changes to some of the
fields used to convert to Azure Dependency Targets etc.
https://github.com/open-telemetry/opentelemetry-specification/pull/575
This commit updates the exporter to handle the new names for these
fields, however as the new equivalent to db.instance is db.name,
which can change when the database is changed inside a connection.

Should resolve #7

Ah sorry, don't know how I missed that, I did try to do a search through the codebase! Anyway should be updated now.

Perfect. Thanks again 👍


travis tls/ssl issue fix

fix for travis builds as per https://github.com/travis-ci/travis-ci/issues/7131
also moved all urls to https

Coverage remained the same at 97.522% when pulling 27b7e5d00b34af7f61515ecdb75002285db4bcb9 on travis_tls_ssl_fix into 9440fab11b2092aac5c980ea01359e1a0d561de7 on master.

looks like this fixes #176 🎉 🎉 🎉


[ppc64le] allow replacing httpredir in dockerfile

Extension of #28640, allows replacing of the default httpredir.debian.org in /etc/apt/sources.list
with a user-specified mirror. This will (hopefully) fix CI apt issues for ppc64le.
Note that ppc64le/golang:1.6.3 image is debian:jessie based.
Signed-off-by: Christopher Jones<EMAIL_ADDRESS>

/cc @andrewhsu

LGTM
# cat sources.list
deb http://httpredir.debian.org/debian jessie main
deb http://httpredir.debian.org/debian jessie-updates main
deb http://security.debian.org jessie/updates main


Removing 'Api key' setting does not delete it

I created an API key and PWS device on wunderground.com, thinking that key would be useful and maybe I could upload observations from our devices. Sadly the latter is not possible though (see #59).
Never mind, I still want to obtain forecasts so I keep the adapter running. However, with the API key I entered in place the following error occurs:
2020-03-20 19:12:10.579  - error: weatherunderground.0 (18240) no observations in response from https://api.weather.com/v3/wx/observations/current?apiKey=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx&geocode=0%2C0&units=m&language=en&format=json

I guess that because I haven't submitted observations from the newly created station this might be broken on the WU end. Or it could be an issue elsewhere, who knows?
Anyhow, I see under the API key the instructions are, "Optionally enter your own NEW PWS owner apikey from Weatherunderground, leave empty if you do not have one
If left empty the current general key is tried to extract from WU webpage"
So I removed the key and tried again. The API key setting is empty when I reload configuration page but the error above does not change. In fact, the URL is the same. It is still using the old key even though I removed it in configuration settings.
So I deleted the entire weatherunderground.0 object tree as I notice the URL is stored there, thinking it would be regenerated.
True, the tree and URL were re-generated but with the old API still. Where is this coming from?
I even tried changing the key to 'xxx' but it magically found the old one still!

One moment... I check the keys in the URLs being requested and in my profile in WU and they are not the same. It seems the key I entered (and then deleted) on the ioBroker admin page is not the same key in the URL.
I think I see the problem and it is nothing to do with the API key field. I make a more useful issue here: #61.


npm install fails if xcode recently updated

npm install on magellan fails due to this error:
npm ERR<EMAIL_ADDRESS>install: `node-gyp configure build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp configure build'.
npm ERR! This is most likely a problem with the node-proxy package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp configure build
npm ERR! You can get their info via:
npm ERR!     npm owner ls node-proxy
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/dcadwal/dev/test7/boilerplate-nightwatch/npm-debug.log

As is often the case, the real error is masked, until you run npm install node-proxy directly:
Agreeing to the Xcode/iOS license requires admin privileges, please re-run as root via sudo.

The fix:
Open up Xcode, and accept the new user agreement. This was happening because a new version of Xcode was downloaded and the new agreement was not accepted.


Refactor Umple src directory and set up feature model

The src directory with Umple files is too messy, and there are some very large files.
This project would involve firstly,

making some subdirectories of src and putting certain functionality there so there are relatively few files left in the main directory. The subdirectories would be organized by architectural unit and feature (use git mv to do any moves to preserve history)
Splitting the largest files into smaller ones so no file is excessively massive.

Secondly it would involve creating a feature model of Umple as a whole that could be viewed in Umple, with the ability to generate a version of Umple with a subset of features (this would be as a case study rather than expressing a desire to actually switch of features, although in the extreme it might be possible to create a version of Umple that can deal with mixsets along with embedding methods in other languages only).

This Issue has been worked on with several PRs including #1678 #1679 #1680 #1681 #1682


Adding reentrancy flag to REL_Relationships_TDTM

Critical Changes
Changes
Updates to Prevent Reentrancy Issues

We've updated the REL_Relationships_TDTM class to prevent reentrancy issues on Relationship record updates.

Issues Closed
Fixes #535
New Metadata
Deleted Metadata
Testing Notes

Keeping this as a draft PR until #790 is merged

CCE feedback on release note usability:
"We've updated the REL_Relationships_TDTM class to prevent reentrancy issues on Relationship record updates."
What value did the changes to REL_Relationships_TDTM class bring to EDA?
Who would find the most value in knowing about these changes/improvements?


[BugFix] Fix the disk size stats of rowset

Why I'm doing:
    // calculated by index + data
    optional int64 total_disk_size = 12;
    // calculated sum(segmentgroup.data_size)
    optional int64 data_disk_size = 13;
    // calculated sum(segmentgroup.index_size)
    optional int64 index_disk_size = 14;

total_disk_size = data_disk_size + index_disk_size
What I'm doing:
When some indexes are created on the table, there will be errors in rowset disk space statistics, which can lead to generate some large files.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@Mergifyio backport branch-3.3

@Mergifyio backport branch-3.2


Use native JavaScript/ECMAScript module syntax

New purescript versions complain about unsupported JS syntax

Closing as I implemented this more recently.


fix: do not invalidate session if offline when identification fails.

Fixes an issue where the session (token and identifier) was deleted if the server was unreachable during Talo initialization.
Player had to re-authenticate.
With this fix, players will be identified after relaunching the game, or if gamedevs explicitly call Talo._check_session() (which isn't part of the API).

fix looks good to me! it does highlight how the player needs to be cached locally since the identify request will still fail and not actually set the current player/alias. but that can come separately. thanks!


feat(agentless, workload): [SSPROD-43929]: Add Azure functions

Lets discuss this, I actually think this may be better suited as an additional submodule

Replaced by:
https://github.com/sysdiglabs/terraform-azurerm-secure/pull/62


[AMSDK-8600] - Implement setRequestAuthorizationLevel API

Adding an API to facilitate prompting for required permission level in iOS.

The following API is added to the Places Monitor extension.
+ (void) setRequestAuthorizationLevel: (ACPPlacesRequestAuthorizationLevel) requestAuthorizationLevel;
Sample Usage:
To request for WhenInUse permission
// set the request authorization level
[ACPPlacesMonitor setRequestAuthorizationLevel: ACPPlacesRequestAuthorizationLevelWhenInUse];
// start monitoring
[ACPPlacesMonitor start];

Further when its required to upgrade to Always Allow authorization
// set the request authorization level
[ACPPlacesMonitor setRequestAuthorizationLevel: ACPPlacesRequestAuthorizationLevelAlways];

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

closing this will open against dev


Add support for Jekyll 3 and provide additional configuration options

Hello Aaron,
I hope you don’t mind, but I wish to suggest a couple of changes/improvements for this rather wonderful plugin:

Jekyll 3 support: Not only does the latest version of Jekyll have a few API changes and deprecations, but it also introduced a hooks interface for plugins. I’ve refactored the code slightly so that both post loops (Jekyll::Hooks.register :posts, :post_render do |post| for Jekyll 3, site.posts do |post| for older versions) call a crosspost_payload definition. One issue I did notice using the old posts loop, is that liquid variables don’t get transformed. As hooks takes the already rendered code, this isn’t an issue for users of Jekyll 3. I tried to fix it for the older loop method, but it didn’t look easy — and is actually what led me to implementing the hook based approach.

Configuration options: Ideally, it would be great if this plugin was available as a Ruby Gem (and more than happy to help out on that front). Yet, to do that, there needs to be some flexibility for authors, as the plugin code would be abstracted away. With that in mind, I’ve exposed a few of the Medium API options, and also allow users to define where the cache folder is created. I’ve given this a default value of .jekyll-crosspost_to_medium, which follows conventions used by other plugins, as well as Jekyll itself (which uses .jekyll-metadata). The config variable is also based on existing conventions.

I'm no Ruby expert, but slowly learning by doing! I’ve been using this on my own site, but no doubt needs further testing, especially on older versions of Jekyll.
Do let me know if you have any feedback. And if you have a chance to test it with your own site, that’d be useful too.
Best,
Paul

Oh, one final note: I also changed the source of tags from categories to tags. Seemed like there was a greater likelihood that the tags you use on your own site would match the concept of tags used on Medium. (On many Jekyll sites, categories are used more as a means of creating permalinks, or site sections, i.e. /blog, /links, /photos etc).

Thanks so much! All of your logic & arguments make sense to me. I’ve not made a Gem before, so any help in that area would be welcome.
I’m also in Octopress 2 still on my own site (waiting on the migration instructions for Octopress 3), so I need to do some testing to make sure this all works there as well. Watch this space!

Excellent news! With regards to creating a gem, there’s a pretty good guide on the RubyGems site: http://guides.rubygems.org/make-your-own-gem/. I created a few (simple) gems for Jekyll recently, which might help point the way also, i.e. https://github.com/paulrobertlloyd/jekyll-roman (which in turn uses code found in other (Jekyll) gems…!)
As to Octopress, I don’t know too much about the previous version, but I know that version 3 takes a less invasive approach, one that essentially provides set of gems you can install on top of a standard Jekyll install. I guess the migration depends on how many Octopress features you’re using (some of which may now be possible in core Jekyll).
Looking forward to hearing how these updates fare with your installation. Fingers crossed!

Actually I will just merge the pull request and then fix the issue. I have some other fixes to add as well.

Fantastic, thanks @aarongustafson! Will file a separate issue for creating a Gem.


Examples/kubernetes dev with model downloading functionality

Hi,
I have built the helm chart according to the template you had provided earlier. I think this can still be improved in some ways. Any comments are welcome.
Feature set for the Helm chart

[x] High availability
[x] Multi models
[x] Support of embeddings and completions models
[ ] Load balancing
[x] Auto scaling
[x] CUDA support
[x] Downloading functionality
[ ] Redownload on upgrade hook. (Currently the models are downloaded only on the first deployment, there is no redownload functionality on upgrade if required)

Pending testing

[ ] Load balancing
[ ] multi GPU support using MiG for kubernetes docs & microk8s

Maybe it would be easier if I push the base branch to the original repo ?

Yes, Ideally we merge here first and once finalized we can push example/kubernetes to the main repo.

@phymbert @OmegAshEnr01n Awesome work you've done here, small question, when this chart is deployed are the models's api compatible with Open IA api, like the way together ai works, where i just change the OPENAI_API_KEY and OPENAI_BASE_URL (https://api.together.xyz/v1)

Hi @ceddybi,
Please check the server API docs from llama.cpp.

POST /v1/chat/completions: OpenAI-compatible Chat Completions API. Given a ChatML-formatted json description in messages, it returns the predicted completion. Both synchronous and streaming mode are supported, so scripted and interactive applications work fine. While no strong claims of compatibility with OpenAI API spec is being made, in our experience it suffices to support many apps. Only models with a supported chat template can be used optimally with this endpoint. By default, the ChatML template will be used.

Is it necessary to limit to MiG here?  llama.cpp supports pre-ampere GPUs, so it would be nice to use more standard multi-GPU container techniques.


[DNDiscord] - Character creation & Stat assignment.

Going to put this on hold/close this as the feature will be going through a rebranding of sorts, which will come with a complete redesign of the initial idea I had.


latest release is 0.12.0 while VERSION file states 0.11.0

What was the intended purpose for VERSION? Shall we consider not having this info duplicated?

I have to check (again) the Makefile, I think I forgot some step last time sadly.
Maybe is it time to rethink the whole project structure?

Closing since we don't use VERSION file anymore

Closing since we don't use VERSION file anymore


Redirect to sign up form does not work

Clicking on "First time, sign up" should redirect the user to sign up form

Could you please check http://<IP_ADDRESS>:8450

Fixed


include default value in rf search space

LGTM, just curious why data_size is a list

It's a tuple of # rows and # columns. I updated the docstr just now.


Panic. Invalid Character

If I provide a token I get

panic: invalid character '<' looking for beginning of value

Getting the same error.

Please see #12


Android Pending Payments Confusion - IPurchasesUpdatedListener Implementation

I'm just looking at how to deal with Pending payments on Android. After reading the plugin docs and the google docs it states that in order to receive updates we should implement PurchasesUpdatedListener - in XF by implementing IPurchasesUpdatedListener.
This all sounds fine and reasonable in principal but I'm a still a little confused.
The InAppBillingPlugin also sets it's own listener internally https://github.com/jamesmontemagno/InAppBillingPlugin/blob/a0d0f3c620f2bd77c0734e0a2d5f18aa790a7cb1/src/Plugin.InAppBilling/InAppBilling.android.cs#L60 during the call to  ConnectAsync();
This leads me to think that if I also register a listener in my MainActivity won't this result in getting multiple updates during a normal purchasing process? Both the Plugin and `MainActiivty listener would be registered at that point.
It looks like this Plugin listener would be disconnected in the call to DisconnectAsync();, which is called in my code immediately after any billing processes.
At that point it seems to make sense to have the MainActiivty listener to then process any updates changing a Pending into Cancelled or Purchased outside of the Connect() Disconnect() flow.
Are there any examples of handling this?

This does make a stack of sense. Thanks James, much more convenient, obvious and explicit.

Cools, i will try to push a thing out in the next few days

Would be good to have an example usage I think.
Since the general advice in the documentation follows connect -> do your thing -> disconnect, it would be good to document how this should be treated in a similar or different manner.
It would suggest from the approach above that you connect during app initialisation and would need to then remain connected in order to receive the events.
Unless I'm actually reading this wrong myself at the moment.

Sorry to pick on the closed issue, but I have the weirdest thing happening:
Xamarin app, latest version of billing plugin.
In my MainActivity I added the recommended code snippet to add purchase update listener.
Now I am getting this compile error:
MainActivity.cs(128,64,128,89): error CS0117: 'InAppBillingImplementation' does not contain a definition for 'OnAndroidPurchasesUpdated'
Any ideas? The web is silent...

Should be there... https://github.com/jamesmontemagno/InAppBillingPlugin/blob/master/src/Plugin.InAppBilling/InAppBilling.android.cs#L29
Make sure that you are compiling your Android app against Android 10 +


Use color scheme 'name' as key (vs an index number)

Currently color schemes are referred to by their name attribute:
"colorScheme": "Monokai Soda",
But they're stored in an array, ie keyed by index number. The actual key used - name - is mixed in with the colors. This makes the file slightly harder to parse if you're hand editing, and is also odd - you don't expect the name to be one of the colors.
Instead of:
  "schemes": [
    {
      "background": "#1A1A1A",
      "black": "#CCCCCC",
      "blue": "#9D65FF",
      "brightBlack": "#625E4C",
      "brightBlue": "#9D65FF",
      "brightCyan": "#58D1EB",
      "brightGreen": "#98E024",
      "brightPurple": "#F4005F",
      "brightRed": "#F4005F",
      "brightWhite": "#F6F6EF",
      "brightYellow": "#E0D561",
      "cyan": "#58D1EB",
      "foreground": "#C4C5B5",
      "green": "#98E024",
      "name": "Monokai Soda",
      "purple": "#F4005F",
      "red": "#F4005F",
      "white": "#C4C5B5",
      "yellow": "#FA8419"
    }
  ]

It would be better to do:
  "schemes": {
    "Monokai Soda": {
      "background": "#1A1A1A",
      "black": "#CCCCCC",
      "blue": "#9D65FF",
      "brightBlack": "#625E4C",
      "brightBlue": "#9D65FF",
      "brightCyan": "#58D1EB",
      "brightGreen": "#98E024",
      "brightPurple": "#F4005F",
      "brightRed": "#F4005F",
      "brightWhite": "#F6F6EF",
      "brightYellow": "#E0D561",
      "cyan": "#58D1EB",
      "foreground": "#C4C5B5",
      "green": "#98E024",
      "purple": "#F4005F",
      "red": "#F4005F",
      "white": "#C4C5B5",
      "yellow": "#FA8419"
    }
  }

So, we just discussed this right now.
There are a couple issues here. If we use the name as the primary key for the scheme, and don't include the name property in the scheme object, then the object can't really exist independently. The scheme object is now dependent upon being in a map of other colors.
Also, what happens if we have more sources for settings than just the singular profiles.json file?  These might conflict, they might not have the name as the key for the object.
I'm not really sure what we get from switching to this schema, esp. when #2515 will both not reorder settings, and add a defaults.json where the name is the first key.


bug: Background is black using solarized-osaka

Did you check docs and existing issues?

[X] I have read all the tokyonight.nvim docs
[X] I have searched the existing issues of tokyonight.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
v0.9.4
Operating system/version
MacOS Ventura 13.5.2
Describe the bug
It seems like the background color is not set.

When I check the Normal highlight (which is what controls the background if I am not mistaken) i see this
:highlight Normal
Normal         xxx guifg=#9eabac

I tried this on both iTerm2 and newly installed WezTerm and had the same thing happen.
It also doesn't seem to happen with other colorschemes I have installed such as solarized (normal) and tokyonight.
The problem also exists on neovim 0.10.0 dev build
I don't know if this is an issue with my system or the colorscheme at this point. Do you have any ideas?
Steps To Reproduce
nvim -u repro.lua with the minimal configuration results in the screenshot above
Expected Behavior
The background should not be black (unless it should?)
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "craftzdog/solarized-osaka.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("solarized-osaka")
-- add anything else here

Can't reproduce with repro.lua

Ok, thanks! Then it must be something with my setup 👍

It seems that setting transparent = false works. It seems that transparent is set to true as default in config.lua but in the README it is set as false. I must have read the Readme as the default config.

good point, thanks!


mkdir: cannot create directory ‘//Downloads’: Permission denied

For now I just want to use drogon's thread pool
Will AOP help me?
thank you all

not set any json config file .
    std::vector<drogon::internal::HttpConstraint> filtersAndMethods = {
        drogon::Get,
        drogon::Post,
        drogon::Head,
        drogon::Put,
        drogon::Delete,
        drogon::Options,
        drogon::Patch,
    };

    /*  All requests are forwarded to func */
     auto func = [&](const drogon::HttpRequestPtr &req, std::function<void(const drogon::HttpResponsePtr &)> &&callback) {...}
    drogon::app().registerHandlerViaRegex("(.*)", func, filtersAndMethods);

    drogon::app()
        .setLogPath("/tmp_dir/drogon_log")
        .addListener("<IP_ADDRESS>", 80)
        .run();

run web framework on docker container .
$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 11 (bullseye)
Release:        11
Codename:       bullseye

I do test

execute myself logic without Dorgon Framework , done .
execute myself logic with drogon , crash

func has been called

log file content :
20230321 05:00:19.249643 UTC 8 ERROR Unhandled exception in /my/http/path, what(): Timezone database not found at "//Downloads/tzdata" - HttpAppFrameworkImpl.cc:141

console content
mkdir: cannot create directory ‘//Downloads’: Permission denied

Maybe link to : https://github.com/HowardHinnant/date/issues/641

myself error . sorry

Solve the problem : https://github.com/HowardHinnant/date/issues/781


[No QA] Create new Edit Limit Type page

Details

Creates new Edit Limit Type page.
Fixed Issues

$ https://github.com/Expensify/App/issues/44328
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Pre-steps:

Comment out the feature check in the WorkspaceEditCardLimitTypePage file, so you can access the screen.
To see Smart Limit option you need to enable Approvals for the Workspace. You can do it by enabling Workflows feature, and then enabling Approvals in the Workflows section.

Steps:

Open any workspace.
Update the URL to end with /expensify-card/1/edit/limit-type, for example: https://dev.new.expensify.com:8082/settings/workspaces/YOUR_POLICY_ID/expensify-card/1/limit-type.
Make sure the page looks like expected. Try to click through several options and make sure it works as expected.
Make sure the confirm modal appears on Save and looks as expected.

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1721374931849419

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/31dcbd69-b340-487e-8e69-321268c7596f

Android: mWeb Chrome

https://github.com/user-attachments/assets/03c120bf-303e-49b7-9236-9ee5537ac4d8

iOS: Native

https://github.com/user-attachments/assets/17f5bf6e-7f2c-465a-95d3-120701a4ab74

iOS: mWeb Safari

https://github.com/user-attachments/assets/86bad370-6bfa-400c-a348-ca3b607cfd52

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/89ff5ebf-1625-4460-9e9b-1b588f3be08c

MacOS: Desktop

https://github.com/user-attachments/assets/3e44aa3e-57d4-49ae-87a1-ac90ad2ba39b

@DylanDylann or @allgandalf should be a reviewer of this PR

Let's do it!

I believe this is all set for your re-review, @allgandalf?

Hmm, what do we normally do for those? (If we already have a pattern established.)
I'm tempted to say we should leave room for the checkmark even when it's not selected, but I don't know that I want to make this a special one-off treatment. Definitely curious for other designers' thoughts on this one. I can see it going either way, but I think leaving room for the checkmark always would probably make it feel a little smoother to switch between options.

I can see it going either way, but I think leaving room for the checkmark always would probably make it feel a little smoother to switch between options.

I tend to agree with this. I think I would just always put that right space there, even when no checkmark is available.

@allgandalf Updated

https://github.com/user-attachments/assets/7eed3eb7-7cc7-46ce-922f-9dec39c6eb85

Agreed with the designers. That updated version looks good to me!

@MariaHCD could you please take a look at the PR 🙏

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Change Text - Recover Your Investment in 3 – 6 Months

We need to ensure we are not misrepresenting this number. we could use
Recover Your Investment in 6 - 9 Months
Recover Your Investment in 7.5 Months
Or...?

I think 6-9 is perfect. 7.5 is just the median, but realistically it will be a range. Some may recover it within 3, potentially. :)

find ./ -type f | xargs sed -i 's/3 - 6/3 - 9/'


Port afl-analyze to windows

Hi, I've ported afl-analyze to windows and update some color definitions from latest afl
> afl-analyze.exe -i 1.bmp -D C:\Tools\DynamoRIO-Windows-7.1.0\bin32\ -t 2000 -- -coverage_module gdiplus.dll -target_module test_gdiplus.exe -target_offset 0x10b0 -nargs 2 -- test_gdiplus.exe @@

afl-analyze for Windows 2.52b by<EMAIL_ADDRESS>Based on WinAFL 2.52b by<EMAIL_ADDRESS>Based on AFL 2.52b by<EMAIL_ADDRESS>
[+] Read 58 bytes from '1.bmp'.
[*] Performing dry run (mem limit = 0 MB, timeout = 2000 ms)...
[*] Analyzing input file (this may take a while)...

    Offset 0, length 2: "magic value" section
    Offset 2, length 12: "magic value" section
    Offset 14, length 4: suspected length field
    Offset 18, length 8: "magic value" section
    Offset 26, length 2: no-op block
    Offset 28, length 6: "magic value" section
    Offset 34, length 24: no-op block

[+] Analysis complete. Interesting bits: 37.93% of the input file.
[+] We're done here. Have a nice day!

Also supports color mode on Win10:

Ooh, very nice!
Looks good to me thus far, but let me test afl-analyze tomorrow and I'll merge then.

Looks like everything is working so I'm doing the merge. Thank you for submitting it!
A couple of follow-up observations:

I don't think it's critical here, but the tool is somewhat slow due to not taking advantage of persistence (-fuzz_iterations 1). Was that a deliberate decision (e.g. to avoid variable coverage)?

It would also be nice to add a usage example somewhere, either to the README or when printing the usage in the tool itself.


README in .github for actions overrides main repo readme

I think the .github/README.md takes over as the default for the repo readme.
We should keep the original, then update the name in the action to maybe "HOWTO.md"
Or maybe there is another cause for this.

fixed


Feature demanded : Liquid democracy

Implement some feature of the concept of liquid democracy as liquidfeeback or other.

What do you think it's LREM not Alternative Libertaire.


[BUG] Wrong icon on the place order button

Use paper plane as symbol
Fixes #2742

@rkalman I made the change - let's see if @SchrodingersGat likes it that way. I am very indifferent about it.


Option to open Manual Entry screen first

Hello guys.
Thank you all for useful library.
Could you add support for open Manual Entry screen first instead of Scanner screen?
Also would be nice to have, as option, photo icon on the right side of Card number input field instead of "Camera" button on the top left corner on iOS:

Thank you.

Yes, you can open manual entry screen first as below:
let cardIOVC = CardIOPaymentViewController(paymentDelegate: self, scanningEnabled: false)
cardIOVC?.modalPresentationStyle = .formSheet
present(cardIOVC!, animated: true, completion: nil)


Add donate command

[ ✅] Have you followed the guidelines in our Contributing document?
[ ✅] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ✅] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ✅] Have you written new tests for your changes? Here's an example.
[ ✅] Have you successfully run brew style with your changes locally?
[ ✅] Have you successfully run brew tests with your changes locally?

This seemed to work locally, using brew test-bot Could someone give a little guidance on how to run a single spec locally or point to a doc that helps me sort that out myself?
Thanks!

From the issue:

It would be a helpful if a brew user wants to donate and can't remember the URL or how to find it.

I think I'd like to see a few more people struggling with this before we add an extra command for this. It's linked prominently on the README and homepage both of which are easy to find. It's also outputted on first install too.

This seemed to work locally, using brew test-bot Could someone give a little guidance on how to run a single spec locally or point to a doc that helps me sort that out myself?

Run brew tests and brew style; they should point out the errors here.

Run brew tests and brew style; they should point out the errors here.

(You may want to hold off on this until we've decided whether this PR would be merged).

It would be a helpful if a brew user wants to donate and can't remember the URL or how to find it.

How would such a user remember (or learn about) the existence of brew donate?  Most of the ways of finding this out would also point the user to the relevant URL.

@MikeMcQuaid: the extra s on tests makes all the difference. Thanks!
I’ll go sort it out because (a) it makes it easier to contribute in the future, and (b) it’ll be here if you ever want it.
@chdiza: I can’t speak to everyone’s experience. My learning of Homebrew was to install it, type brew help and start reading and trying. If brew help commands had contained donate, it would have put the thought in my head.

Passing on this due to the above, sorry @purp! Hope we'll get more contributions from you in future ❤


API: Application Revisions retrieving updated

API to get Application revisions updated to more correct one.
In near future (https://github.com/qubell/vermilion/pull/5116) /applications/:id.json will not return instances and revisions.

@vasichkin please take a look

Looks good


[FEATURE REQ]Revisit DAC: should we not stop on shared token cache credential if we find an expired one

Currently if we find an expired token in shared token credential, we stop attempting next credential.
Let's continue on all dev credentials: do not stop trying with dev credentials until obtaining a valid token or completing the chain

https://github.com/Azure/azure-sdk-for-net/issues/35919
https://github.com/Azure/azure-sdk-for-java/issues/34733
https://github.com/Azure/azure-sdk-for-js/issues/25717
https://github.com/Azure/azure-sdk-for-python/issues/30167

The Python PR: https://github.com/Azure/azure-sdk-for-python/pull/30441


Add pip upgrade to prod docker file

Very minor change to work with newest pip installation - this also removes warnings during the container generation process (and this mirrors the setting in the simtools-dev image)

@tobiaskleiner - great, thank you!


Feature Gen.char() - Closes #1005

PLEASE READ CAREFULLY BEFORE CONSIDERING MERGE:
The idea behind this implementation of Gen.char() is to have a default of ASCII character generation, but to allow the user to specify CharRanges if they want to customize the generated values. The purpose of using CharRange instead of a collection of Chars is to perhaps make it easier to define, perhaps save a bit of memory, and perhaps a bit of performance.
If, for example, one wanted to use Chinese as the chars to generate, most likely you are going to be dealing with Unicode ranges:
https://en.wikipedia.org/wiki/CJK_Unified_Ideographs_(Unicode_block)

List of CJK Unified Ideographs, part 1 of 4 (U+4E00..U+62FF)
List of CJK Unified Ideographs, part 2 of 4 (U+6300..U+77FF)
List of CJK Unified Ideographs, part 3 of 4 (U+7800..U+8CFF)
List of CJK Unified Ideographs, part 4 of 4 (U+8D00..U+9FFF)

(not a complete set)
To have to convert all of these to complete collections, as opposed to ranges, is clumsy and inefficient in my opinion. Using ranges seems to fit well with how we think of characters as Unicode ranges.
val CJK_IDEOGRAPS = listOf(
    '\u4E00'..'\u62FF',
    '\u6300'..'\u77FF',
    '\u7800'..'\u8CFF',
    '\u8D00'..'\u9FFF'
)

Gen.char(CJK_IDEOGRAPHS).take(5)

娺 孿 屗 巳 天

When multiple ranges are given, the distribution is even across all characters via the new weighted Gen.choose() function. For example:
Gen.char('A'..'B', 'C'..'E')

is equivalent to doing this with the weighted Gen.choose():
Gen.choose(1 to 'A', 1 to 'B', 1 to 'C', 1 to 'D', 1 to 'E')

In the actual implementation, the weights are the length of the CharRange, a range is chosen by weight, then a random Char is chosen from the CharRange. See the tests for proof that this works.
ADDITIONAL NOTES
I did not make CharSets public. I did not want to do so without a discussion on whether it is considered appropriate for the project to expose such an object.
And another thing, I did not include the space character in the default generated characters. Please let me know if this is not the desired behavior.

I approve the way you did things. I really like this PR!
I would recommend you to extract some behavior to more methods to make it clearer.
Awesome!

@Kerooker I will clean it up. Also, do you think it would be appropriate to expose a CharSets object to the users with pre-defined character sets, or should we leave it up to the users to define their own?
Another think I should add should be a Gen.char(<String>) that picks from a string of chars.

No, I don't believe we should allow the charsets
A String is a CharArray and I believe it's a CharList aswell. I think there should be a Gen.char("string") yeah

@Kerooker Updated per feedback.

I think this is ready to merge.
@sksamuel @EarthCitizen what do you think?

Ok, you had your chance.
I'm merging this xD

@Kerooker My apologies. I did not see the notification for your previous message. Yes, I am ready for this to merge.


Integration test for acoustic comms

This issue discusses addition of a new test case for the acoustic comms plugin.
My idea is to have 3 LRAUV vehicles in a line, so that the 1st and last one are far apart from each other and won't be able to communicate directly using comms, due to the distance. Hence, the first vehicle will talk to the middle one, which will relay the message to the last vehicle. We can run this communication the other way round to confirm it works correctly. There should also be a measurable lag between the time the msg was sent and when it was received, as sound is not instantaneous.
We can have an additional vehicle in motion, that tries to communicate with these 3 vehicles.

I modified the demo slightly : https://github.com/osrf/lrauv/pull/240

Integration test proposed here : https://github.com/osrf/lrauv/pull/243


Tab teardown crashing resulting from renewed renderer destruction order issues

I can reliably crash a release build of WT by just closing tabs.
>	TerminalControl.dll!Microsoft::Console::Render::DxEngine::_CreateDeviceResources(const bool) Line 170	C++
 	TerminalControl.dll!Microsoft::Console::Render::DxEngine::StartPaint() Line 692	C++
 	TerminalControl.dll!Microsoft::Console::Render::Renderer::_PaintFrameForEngine(Microsoft::Console::Render::IRenderEngine * const pEngine) Line 90	C++
 	TerminalControl.dll!Microsoft::Console::Render::Renderer::PaintFrame() Line 68	C++
 	[Inline Frame] TerminalControl.dll!Microsoft::Console::Render::RenderThread::_ThreadProc()	C++
 	TerminalControl.dll!Microsoft::Console::Render::RenderThread::s_ThreadProc(void * lpParameter) Line 151	C++

Various things under RenderThread::s_ThreadProc.
If you ask the Renderer what it thinks, it says this:
this->_destructing
true

However, we're here:
https://github.com/microsoft/terminal/blob/b9d83baaeb149410dc8e520ec829eb891b2087a7/src/renderer/base/renderer.cpp#L59-L71
We passed the _destructing check and . . . now we're very sad.

This seems worse since #825.


Missing /preview route

When using a Docker image later than 2950, the /preview route no longer exists.
For example, using 2951:
[WARN ] 2023-02-28 23:26:56.672 [http-nio-8080-exec-1] PageNotFound - No mapping for POST /preview
[WARN ] 2023-02-28 23:26:56.684 [http-nio-8080-exec-1] DefaultHandlerExceptionResolver - Resolved [org.springframework.web.HttpRequestMethodNotSupportedException: Request method 'POST' not supported]

I suspected an issue with dslEditor, but even toggling that property to true results in the same output.

This was removed in the open source version (2951+) ... I'd recommend using Structurizr Lite instead, as it will give a far better previewing experience (autolayout diagrams, manual layout diagrams, docs, decisions), particularly with auto-refresh enabled.
I assume you're using VS Code ... if so, just start Lite up and point it to the same folder, then open http://localhost:8080 in your web browser.

Thanks, we will give Lite a shot.


feat: add exception message to the kafka header for debugging purposes

Actually i offered this feature. Glad to here you're already using X-Exception and X-ExceptionAt fields @oguzhaneren
We return err to cronsumer if we want to publish error topic. we have err, library can add X-ErrMessage to header by default. Client can also add but this library is dealing with error handling. we can expose the error by default :)

Implemented by @oguzyildirim


Allow for dep injection into lush spec function

This is just a "work with the shed door open" kind of issue, subject to change.
_something_(a, b, x).lush(function(a, b, c)
  return {
    Normal { a ... }
  }
end)

This should allow for a scheme to handle light and dark modes without having to maintain two specs.
-- main_spec.lua

-- this would be lush independent, depending on theme author.
-- could be a string, or a table of colors or ...
local style_name = get_some_config_var("g:my_theme_style") -- "dark"
local style_colors = require('lush_theme.my_theme.colours).get_by_name(sub_theme_name)

lush.inject({style_colors, some_other_config}).with(function(style, other)
  return function()
    Normal { fg = style.color_a }
  end
end)

How to do this:

in a non-breaking manner
in an extends compatible way

local spec = lush.extends({harbour}).inject(style).with(function(inject)
  return {
    ...
  }
end)

Is the chaining all "too smart", maintain old chains but move to a function or table inference and promote more complicated to build the config in parts? Can probably show deprecation warnings when running Lushify.
some_theme = require("lush_theme.harbour")
local config = {
  extend = {harbor},
  -- allows for injection of other themes if wanted, but does not automatically extend those themes
  -- is that confusing?
  inject = {style, harbor, require('lua.some.lib')},
}

config.spec = function(style, harbour, helper_lib)
  return {
    Normal { fg = harbour.normal.fg, bg = style.red500}
  }
end

return lush(config)

lush(...) already infers on table && table.__lush && table.__lush.type == "parsed_lush_spec", so we would either

be checking the table didn't have those keys, or
or have a lush.new_config() which returns a map with type information
or you call lush.with_config() or similar

I have a theme, it has two styles, regular and no italics, how do I build this?

spec into extends(spec).with(group = {spec.group, gui = "" or gui = spec.group.gui.rep(italic, "")

I have a theme, it has two styles, subzero and scorpion. It is a direct palette swap.

lush.inject(palette).with( normal  fg  = palette.normal.fg, bg = palette.color1)

I have a theme, it has two styles, lake and ocean, ocean is generally the same as lake but some colors are darker and a few groups change.

Get lake as parsed spec,  ocean extends lake and just fiddles which groups it needs to.

Two styles, light and dark. Half the specs are shared half are not.

Palettes should conform to some agreed shape, probably have three specs

base (never exposed to end user) probably just the raw function that accepts a palette
light
dark

Define palettes
-- norm and comment are different colors but are applied the same
-- no matter which spec

-- light_palette.lua         -- dark_palette.lua
light = {                    dark = {
  norm = hsl(blue),            norm = hsl(dark_blue),
  comment = hsl(red)           comment = hsl(dark_red),
  light_tone = hsl(green)      dark_tone = hsl(orange)
}                            }

Define base
-- base.lua
return function(palette)
  Normal { fg = palette.norm },
  Comment { fg = palett.comment }
end

Define light
-- light.lua

-- get palette
palette = require("lush_theme.ld.light_palette")

-- get base generator
base_fn = require("lush_theme.ld.base")
-- apply palette to base
base_spec = lush.inject(palette).with(base_fn)

-- extend base for light specifics
return lush.extends(base_spec).with(function()
  CursorLine { bg = palette.light_tone },
  Search { base.Normal, fg = base.Normal.fg.lighten(20) }
end)

Define dark
-- dark.lua

-- get palette
palette = require("lush_theme.ld.dark_palette")

-- get base generator
base_fn = require("lush_theme.ld.base")
-- apply palette to base
base_spec = lush.inject(palette).with(base_fn)

-- extend base for light specifics
return lush.extends(base_spec).with(function()
  CursorLine { bg = palette.dark_tone },
  Search { base.Normal, fg = base.Normal.fg.darken(20) }
end)

Important, both light.lua and dark.lua return valid specs, so they can be used with extends by an end user. A lush spec file should always return a lush spec, fully formed.
Now either colors.vim checks some config val
" colors.vim
if g:ld_style == "light" then
  lua require("lush")(require("lush_theme.ld.light")
else
  lua require("lush")(require("lush_theme.ld.light")
end

OR, there is a third "spec" that does the same thing in lua and returns the real spec.
-- light_or_dark.lua
return require("lush_theme.ld."..vim.g.ld_style)

-- colors.vim
lua require("lush")(require("lush_theme.ld.light_or_dark")

The split files starts to break :Lushify', buit fwatch can actually fix this for us, probably :LushifyDir` and just bang lush on every file change? Needs to do the unwatch/rewatch shuffle for vims save style.

My idea for backwards compatibility: in addition to colors that can be stringified, we can have a function that accepts a dependency table.
Of course there should be a helper to make it easy:
local function InjectableColors()
  return setmetatable({}, {
    __index = function(_, key)
      return function(deps) return deps[key] end
    end,
  })
end

local colors = InjectableColors()

local parsed = lush(function()
  return {
    HighlightA = colors.blue, -- function that can accept a dependency later on
    HighlightB = hsl("#dadada"), -- can be stringified directly
  }
end)

lush(parsed) -- errors, because dependency is still missing

parsed.inject { blue = hsl("#3238a8") } -- associate this table as a dependency for this spec
lush(parsed) -- injectable color objects will now be resolved here using the table above

parsed.inject { blue = hsl("#16c4f7") } -- re-injection is possible
lush(parsed)

What do you think of this workflow?


Contributing WASI support

I've made some small changes (e.g deleting strenuous import Foundation calls and other small changes) to make this library compatible with the swift wasi compiler. @mzaks would you consider accepting those changes upstream?

Hi @oxcug feel free to create a PR.

@mzaks Will do, I imagine it's best to push to the google flatbuffer repo? Or should I make the change to this one?

@oxcug I would recommend to make a PR on the official Google Repo.

Gotcha, will make a PR and tag you. Might take me a few days to getting around to it though.


Improve classvars behavior

I think these changes snuck their way into main due to too many things happening at once (there was a ClassVars PR already), but I've addressed feedback from #5215 that was fortunately visible due to not being up-to-date with the main branch.

please review


Slow performance

I just tried out D3DShot on my PC and the performance is pretty slow. My native display resolution is 3840x2160, and the graphics card is Nvidia GTX 1080, the average fps I'm getting is about 20. I tried benchmark with both the included benchmark method, and by counting the total frames added. Both yield similarly slow performance. Below is one of the many benchmark runs:

Capture Output: NumpyCaptureOutput
Display: <Display name=Generic PnP Monitor adapter=NVIDIA GeForce GTX 1080 resolution=3840x2160 rotation=0 scale_factor=2.5 primary=True>
Capturing as many frames as possible in the next 60 seconds... Go!
Done! Results: 20.4833 FPS

I looked at other issues with D3DShots and tried out some ways to improve this, for example, I tried running a Windowed or Fullscreen game when benchmarking, I also tried just staying in normal desktop environment, both yield similar results.
My graphics card driver is up-to-date (GeForce 460.89, 12/15/2020), my Windows 10 version is 2004, build 21277.1000.
To clarify, everything else graphics related is normal, games would run at normal FPS (60+), and nothing lags or is slow.

I have also tried different resolutions and scaling factors, and surprisingly (or unsurprisingly) nothing helped, the FPS stayed at about the same level, with slight improvement from the native resolution (4K) 's ~20 fps to 1080p's ~25 fps. Also, I tried D3DShot on my laptop with a 1080p screen and an Intel UHD 620, which worked really well and was very fast, so could this be a driver/graphics card/resolution problem?

Can I use your code to check fps?

Can I use your code to check fps?

Same here:
Preparing Benchmark...
Capture Output: NumpyCaptureOutput
Display: <Display name=Generic PnP Monitor adapter=NVIDIA GeForce GTX 1060 6GB resolution=1680x1050 rotation=0 scale_factor=1.0 primary=True>
Capturing as many frames as possible in the next 60 seconds... Go!
Done! Results: 28.117 FPS

Same here:
Preparing Benchmark...
Capture Output: NumpyCaptureOutput
Display: <Display name=Generic PnP Monitor adapter=NVIDIA GeForce GTX 1060 6GB resolution=1680x1050 rotation=0 scale_factor=1.0 primary=True>
Capturing as many frames as possible in the next 60 seconds... Go!
Done! Results: 28.117 FPS


Traffic date in milliseconds on packet header when encapsulating instead of Date object

Use Date()'s getTime() method in order to do it

https://github.com/comnetunb/protocol/commit/83df8e6589d1f4a1d14d802bafffbaa387bea7c0


Public Read write access to the buckets where resources are uploaded.

Hi,
I see that the buckets which are getting created as got public-read

https://github.com/aws-quickstart/taskcat/blob/master/taskcat/stacker.py#L317
https://github.com/aws-quickstart/taskcat/blob/master/taskcat/stacker.py#L325

Also the objects which are being uploaded to the bucket has got public-read permission
https://github.com/aws-quickstart/taskcat/blob/master/taskcat/stacker.py#L349
Is it necessary to have the "public-read" for the buckets and the objects ?

It depends on how the cfn is structured. If your userdata is using curl to pull file then yes public read is needed.
You can also add a existing private bucket and IAM roles to your cfn.
If the s3bucket is specified in the config.yml then taskcat will not create a bucket.
global:
  owner<EMAIL_ADDRESS>  project: sample-cloudformation-project <- Must match the root directory of project (usually the name of git repo)
  s3bucket: projectx-templates

I am using existing bucket,  I am using IAM profile to run the task cat the this role does not have "s3:PutObjectAcl".
How about this for the existing bucket.
https://github.com/aws-quickstart/taskcat/blob/master/taskcat/stacker.py#L349
s3_client.upload_file(filename, self.get_s3bucket(), upload, ExtraArgs={'ACL': 'public-read'})
My account admin does not want me to grant public-read permissions on any objects in s3

You can skip the upload by commenting the stage call as a workaround.
https://github.com/aws-quickstart/taskcat/blob/master/taskcat.py#L43

ok, Thanks,
Can you please make this as command line parameter where we skip upload  s3 and just test ?

Yes good idea, I will add that to the feature roadmap

Depends on https://github.com/aws-quickstart/taskcat/issues/59

@pankajvkulkarni,
The permissions issues have been addressed in pull #67, via issue #59. Your feature request for the additional parameter to skip S3 has been moved to #68 .
Closing this out.

Issue Fixed in https://github.com/aws-quickstart/taskcat/pull/72 👍


remove centered layout from layout menu

fixes #62984
See comment
https://github.com/Microsoft/vscode/issues/62984#issuecomment-439497802

Thanks for this PR.
I know that @bpasero specificly introduced this action in our layout menu.
It feels to me like it belongs in the layout menu, and not in the Appereance menu - and we should remove it from there. However if we put it in the layout menu than it is not consistent with the other non toggling layouts.
In the apperance menu there is already zen mode which is more general than just layout and is a super set of centered editor layout.
@bpasero @misolori let me know what you think

I am fine removing it from the "Layout" menu because it is a broader thing compared to the other options (and a toggle actually). Strictly speaking, editor layouts are about how to arrange editor groups and the centered editor layout is not doing that, but just changing another layout option.

It also has some automatic resize behavior so it is a bit differnt to other options.
So yeah let's go with the removal in the layout menu. Merging this PR in


New tonal specs

https://android-review.googlesource.com/c/platform/frameworks/support/+/2865794/2/compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/DynamicTonalPalette.android.kt
Will it be implemented? I mean to support my given key color

Yes, it's already supported. Sorry for the late response.

How?

Or it's done internally?


feat: improve home page for small screen devices

What feature?
These are the changes that can improve the overall user experience of the page:

Remove large gap and maybe add a distinct light gradient line (let me know about the separation line)

adding a slight box shadow (not excessive)

center the brand logo

Improve visual heirarchy

Here, documentation links and license heading seem closer than their respective elements.

I don't know about custom hyperlinks, since many people avoid using it for the sake of design and visual appeal.

Add screenshots

Already done with the points

Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

yeah @Anmol-Baranwal we need to fix these.

just we need to remove the extra spaces
center the logo
need to align the footer texts
don't add the box shadow

could you share your progress on this issue?

I will complete this by tomorrow or till late night today. (I haven't started)

could you share your progress on this issue?

I will complete this by tomorrow or till late night today. (I haven't started)

cool

@priyankarpal
Can you check whether the project is running locally?
Because, there is a error even if package exists.

let me check

@Anmol-Baranwal yeah it's running

let me check

I was doing this 2 days back as well, I even tried to install the package. By the way, the branch is updated and is on main.
I will fork it again.

use pnpm i to install again


Support gcc4

Of these proposed changes:
Patches for older gcc versions, especially "last with property X", (X=C-only, GPLv2-only, etc.) are very welcome. However the musl support needs to be complete/correct so that we don't advertise support but then produce a broken toolchain. Especially the dynamic linker pathnames need to be right.
Things that change/override GCC behavior in ways orthogonal to musl probably should not be done except possibly as suggested configurations in config.mak.dist. If langs other than C and C++ are actually broken with musl we could consider forcing them off though, but I'd rather not poke into gcc build internals any more than we have to (e.g. only installing known components we want) since it makes it harder to configure and violates principle of least surprise. Disabling multilib by default is probably not the right thing to do, but if it's needed for some targets we should work out a clean way to do this, possibly at the gcc level.
Using system zlib looks good to me, but I've also gotten requests in the other direction to build gmp/mpfr/mpc as part of the build process rather than requiring them to be prebuilt.
Powerpc ld64 option is actually wrong but doesn't matter because it's the default. The right value should be selected/forced as part of musl target in gcc, however, not as part of build script.
Ability to override SOURCES looks desirable. So does adding .gitignore.

I committed a variant of the SOURCES patch.

i just spent a few hours comparing these patches with the ones i did in 2019 for https://github.com/GregorR/musl-cross and the latter ones are much more aligned with current mcm ones - in fact i redid them all based on the gcc5 patches in this repo.


Re-add build status that was mistakenly removed.

@lavalamp @eparis

k8s.io/contrib/submit-queue
submit-queue/submit-queue.go:185: unknown e2eTester field 'BuildStatus' in struct literal

@eparis fixed.


Remove kustomize command dependency

Kustomize command is integrated to kubectl/oc, it's not used as
standalone command anymore.

/retest

/retest

@jduimovich you can use oc kustomize, nobody blocks you to use kustomize but it's not in the scripts so it's not needed to be installed.
Unfortunately the validation is failing for some reason, maybe it's used in some other project with testing scripts.

Yeah
command -v kustomize >/dev/null 2>&1 || { echo "kustomize is not installed. Aborting."; exit 1; }

the start script in the e2e tests seems to check for kustomize.
I think we should just remove the uses of it in our scripts now, and then remove the kustomize install later.


Centralized Project Showcase with Repository Integration

Is there an existing feature request for this?

[X] I have searched the existing feature requests

Describe the feature you would like to request
There should be a section where users can upload their project details along with a link to their repository.
i can implement both frontend and backend for it
What problem does this feature solve?
This feature centralizes project information, providing a quick, comprehensive view of each project. It makes it easier for others to understand, access, and collaborate on projects directly through linked repositories.
Alternative solutions
No response
Confirmation

[X] I have read the Bitbox Contributing Guidelines
[X] I am a GSSOC-EXT contributor
[X] I am a HACKTOBERFEST contributor
[X] I have starred the Bitbox repository
[X] I would like to help implement this feature

Hello @Sawan-Kushwah, Can you make this blog web page beautiful like the contributor web page ->

The blog appearance is not good and check the blogs also it's also not lookin good.

@Anuj3553 yes i can 👀

I am rasing an issue please assign me that


How to show the imported csv data into table using reactjs?

I have an upload button to import only CSV files to my Reactjs application. I can successfully upload the data(CSV) using React file reader but now I want to show the CSV data it into a table. I think this could help me but I cannot understand how to use it https://github.com/marudhupandiyang/react-csv-to-table here. Below is my code:
import React, { Component } from 'react';
import ReactFileReader from 'react-file-reader';
import { CsvToHtmlTable } from 'react-csv-to-table';
import './App.css';
class App extends Component {
handleFiles = files => {
var reader = new FileReader();
reader.onload = function(e) {
// Use reader.result
alert(reader.result);
}
reader.readAsText(files[0]);
}
render() {
return (

<ReactFileReader handleFiles={this.handleFiles} fileTypes={'.csv'}>
Upload

);
}
}
export default App;
please help. It's very important to me.

This repo is now deprecated, issue closed.


Route continues to be processed even if providing a redirectTo

If a route defines a redirectTo value, the current route should stop processing the route and instead wait to process the route of the redirect.
Currently, what is happening is that Angular detects a redirectTo value and updates $location, but then continues processing the route that was intended to be redirected. Templates are loaded, resolves are processed, ng-view then updates the view with a new template and instantiates the controller all for a route that should have been redirected.
A common use case for assigning a function to the redirectTo is to validation authentication, permission check, or some other logic to determine if the route should continue or redirect else where. In the end, this happens, but in between, unexpected results may occur by updating the view and instantiating controllers for logic that wasn't expected to be executed.
http://plnkr.co/edit/8QlA0ouuePH3p35Ntmjy?p=preview

LGTM - I am going to rebase and see if it breaks anything.
There is a small chance of a Breaking Change in case people expected a redirected controller to run...

@petebacondarwin Seems there is a regression in latest ngRoute 1.6.3 and resolves are again  processed twice for routes that have redirectTo value. Most likely the regression is caused by feat($route): implement resolveRedirectTo

@maximnaidenov - can you provide a reproduction? That commit was from almost a year ago.

@petebacondarwin While preparing a sample I realized the problem is in my code and is provoked by the restructuring in the mentioned feature. Sorry for bothering you.


Distributed Tracing overview refers to istio-pilot deployment

https://preliminary.istio.io/docs/tasks/observability/distributed-tracing/overview/ instructs the user to change the trace sampling rate using kubectl -n istio-system edit deploy istio-pilot.
The is no longer valid, the user could use istiod instead of istio-pilot.
Better might be to not even tell the user they can edit an active Deployment but expand the section that tells them to set values.pilot.traceSampling with instructions to use istioctl manifest apply ... --set values.pilot.traceSampling=...

I have verified this is no longer present on  https://preliminary.istio.io/docs/tasks/observability/distributed-tracing/overview/


Converting circular structure to JSON

Do you want to request a feature or report a bug?
bug
What is the current behavior?
i try to push object in array but have this error 'Converting circular structure to JSON',i check your closed issues and find some for it, and try to add a static value ,for example - let a = 123;
and i got again this errpr
If the current behavior is a bug, please provide the steps to reproduce.
in some component ;
let temp = 1234;
this.AddProduct(temp);
in store :             state.products.push()
and that all

What is the expected behavior?
added a this variable into array
If this is a feature request, what is motivation or use case for changing the behavior?

@AlexeyTcapaev this sounds like an issue with your application, not this plugin. Please do not try to serialize any references to objects in your JSON to prevent this.

@AlexeyTcapaev I do think so, otherwise come up with a reproducible codesandbox and reopen this issue as I do not have the time to delve into this myself.

In my case I had Converting circular structure to JSON caused by an event listener on resize. It seems to many values in a short period of time were provided, so I fixed it using Vue.nextTick

Guys, I was having this error, I was importing the lib like that:
plugins: [createPersistedState()],
I changed to:
plugins: [createPersistedState],
and it worked!!

Bianca, it seems with this "trick" it won't update the local storage anymore, so that didn't work for me.
I debugged my application by setting a breakpoint in the module's setState function and found the offending object that could not be serialized to JSON. In my case some of my objects had references to "parent" objects that I could remove. If that's not an option for you, you can try to workaround like this: https://stackoverflow.com/questions/11616630/json-stringify-avoid-typeerror-converting-circular-structure-to-json

@sermo-de-arboribus this is weird, because this bug that you said happened to me when I was importing with the parentheses. Try to uninstall and install it again, maybe it will work like it happened to me. I didn't have to do a workaround.

Guys, I was having this error, I was importing the lib like that:
plugins: [createPersistedState()],
I changed to:
plugins: [createPersistedState],
and it worked!!

well, it works on my project! You know why? I really want to know.


DataLayouter.beginIInd should delegate to beginIInd

DataLayouter.beginIInd() currently calls super.beginI(), should be calling super.beginIInd()

Corrected in https://github.com/io7m/jpplib/commit/cf77f9051081cce230c3500ba6f4676d75d3daf5
Thanks!


 Upstream isn't changing their docker image to chown volumes on start - they've had a year to do it and numerous issues here and on https://github.com/grafana/grafana. Let's just fix it here.
Which issue this PR fixes

#4156
#5576
#5635
#5102
#8857
#9660
#10116
#10276
#10306

Special notes for your reviewer:
Let's not have a broken chart for users one second longer, just merge this damn thing. See #10306 for how this has gone on for far too long.
What this changes is that if a user does --set persistence.enabled=true it just works. No other settings, no having to finagle with persistence.size or persistence.accessModes={ReadWriteOnce}, no having to manually kubectl run and mount the PV to chown it, no manually modifying the deployment with an additional init container. All of that nonsense is fixed by just following a few of the tips people laid out, and basically resubmitting #5576.
Checklist

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

This didn't work last time I tried it but what the hey
/assign @linki

@prydonius @viglesiasce @linki Could this be reviewed? The chart is broken as it is with persistence.enabled=true.

/ok-to-test

/lgtm

quick question, I'm getting the following errors:
  Warning  Failed                 16s (x3 over 18s)  kubelet, gke-development-default-pool-fb598d53-13qt  Error: ImagePullBackOff
  Normal   Pulling                0s (x2 over 20s)   kubelet, gke-development-default-pool-fb598d53-13qt  pulling image "busybox:1.3.0"```

is it not supposed to be `1.30.0`: https://hub.docker.com/_/busybox/

1.30.0 PR

@sei-jmattson @nicwest my apologies, in my hurry I used a different laptop to make the suggested fix and made a typo. :(


crowdin config change for godot

this is to change the brach i10n dev, since that branch seems like it is somewhat connected to crowdin for translations

changed my mind, created a new branch instead. check #93


simple extension example

This is a simple example of a server extension.

Overall, this looks really good. Thanks, @echarles!
I think it would be interesting to add a simple Javascript file that lives behind the /static/server_simple endpoint.
This repo by @markellekelly is another great example. This repo includes an example of how to leverage the static_url method added in the ExtensionHandler to access the extension's static files. It even shows how to build a Typescript frontend, bundle with webpack, and load in the browser behind the static_url.

@Zsailer Thx for your review. I have a few ideas to refactor a bit. Also, if ok with @markellekelly, I will inject here the work mark has done to showcase the static_url and typescript example.

@Zsailer just pushed the typescript example. This is still WIP but you can always scan and give me feedback.
One question that was asked yesterday during the server meeting and one info you gave is related to a server which would have multiple extensions (eg. jlab, voila, notebook combined in one server) - I don't see how this is possible: this would mean creating a application with would combine the different handlers, but what about the static content place? We only have a single place for content...

but what about the static content place? We only have a single place for content...

Each extension should serve its static files behind /static/<extension_name.

The ExtensionHandler patches tornado's static_url to achieve this.
The ExtensionApp adds a /static/<extension_name> endpoint for that extension and ExtensionHandlers added to that App properly route templates to that extension's  static content.

In practice, it looks like this:

/static/notebook goes to Jupyter notebook's static content,
/static/simple_ext goes to your example extension's static content,
/static/voila goes to Voila's static content
etc.

I get that, but a server is launched with SimpleServer(ExtensionApp), so we can only have one extension, and one static path per tornado listening port? I don't see how to have multiple extensions per server port.

Ah, yes! Remember that ExtensionApps are also server extensions and use the old load_jupyter_server_extension mechanism. That means you can load multiple extensions if they are enabled.
One way to test this directly is by calling:
jupyter server --ServerApp.jpserver_extensions="{'my_ext': True, 'notebook': True}"

Or you can enable them automatically in the jupyter_server_config.d folder.

An ExtensionApp starts a ServerApp, append its own handlers, and loads other extensions if they are enabled in jupyter_server_config.d. (Note, you can block other extensions by setting ExtensionApp.load_other_extensions = False if you want a standalone extensions without other extensions).

Thx Zack. The example has now 2 apps and brings to me more clarity on how the extensions are working. I may bring more fine-tuning but this PR can already be reviewed.

@Zsailer Just pushed changes that implements your comments - I was also considering moving Makefile to README which is must didactic for an example case.
I can take additional comments. To me, this is ready for review/merge.

@Zsailer I am trying the default_url but not sure to understand it.  Should it be the URL that is rendered when the extension is invoked. If you look at simple_ext1, I define default_url = '/template/home' (or default_url = '/simple_ext!/template/home'), but when I invoke http://localhost:8888/simple_ext1, it goes to the error handler (by definition of its handlers) - Which the default_url is useless.
Any background or fixes will help to make it work. I would expect that the default_url works without having to define a default hander.

@Zsailer I have doubts with my last commit on how the settings/configs/flags is handled in the extensions. I have left some TODO in the source that you can review or we can speak on this during the weekly meetings.

@Zsailer my doubts around flags/settings are confirmed. In https://github.com/jupyterlab/jupyterlab/pull/7416 jupyter lab --watch breaks.

Current issues:

Configuration is not taken into account jupyter simple-ext1 --SimpleApp1.configA "ConfigA from command line" does not show up in the config.
ExtensionAppJinjaMixin does not call both _prepare_templates method with consequence that templates are not available in the settings - PR removes the Mixin, TBD maybe in a separated PR?
jupyter simple-ext11 --generate-config fails with "The ExtensionApp has not ServerApp ".

Waiting a bit on @Zsailer feedback before opening separated issues for these.

Thanks, @echarles. Apologies for the delay.

Configuration is not taken into account jupyter simple-ext1 --SimpleApp1.configA "ConfigA from command line" does not show up in the config.

Hm, try adding = between your config name and value, i.e.:
jupyter simple-ext1 --SimpleApp1.configA="ConfigA from command line"
works for me. I think the = has always been required by traitlets CLI for trait values.

ExtensionAppJinjaMixin does not call both _prepare_templates method with consequence that
templates are not available in the settings - PR removes the Mixin, TBD maybe in a separated PR?

This looks like the issue is in the ExtensionApp itself, not the ExtensionAppJinjaMixin. The _prepare_templates method in ExtensionApp should have an initialize_templates() call at the end.
Feel free to open an issue/PR to fix this if you'd like.

jupyter simple-ext11 --generate-config fails with "The ExtensionApp has not ServerApp ".

This is a bug. The following lines need to be removed from the ExtensionApp.
https://github.com/jupyter/jupyter_server/blob/750ff3f03fe83cdff12b1a1c989d220f42e512c8/jupyter_server/extension/application.py#L215-L223
Feel free to open an issue/PR to fix this if you'd like.

Thx @Zsailer Adding an = fixes the params via CLI. I will open 2 PRs (my) tomorrow (hopefully with tests) for the other 2 issues.

@Zsailer Would be great to merge this. It can be very useful to test simple extensions and show users how to develop. It will not hurt anything as the example folder is in is own island.


Excel UI crashes on OSX with Anaconda 2.4.1

When running FlowCal's Excel UI on OSX with Anaconda 2.4.1, the following error message is shown:
2016-01-04 15:19:07.322 python[83254:10454178] -[NSApplication _setup:]: unrecognized selector sent to instance 0x101ca0970
2016-01-04 15:19:07.324 python[83254:10454178] An uncaught exception was raised
2016-01-04 15:19:07.324 python[83254:10454178] -[NSApplication _setup:]: unrecognized selector sent to instance 0x101ca0970
2016-01-04 15:19:07.324 python[83254:10454178] (
	0   CoreFoundation                      0x00007fff931b0ae2 __exceptionPreprocess + 178
	1   libobjc.A.dylib                     0x00007fff9c76873c objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff931b3b9d -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
	3   CoreFoundation                      0x00007fff930ec601 ___forwarding___ + 1009
	4   CoreFoundation                      0x00007fff930ec188 _CF_forwarding_prep_0 + 120
	5   libtk8.5.dylib                      0x0000000104acc76d TkpInit + 472
	6   libtk8.5.dylib                      0x0000000104a44f91 Initialize + 1541
	7   _tkinter.so                         0x0000000104910a3d Tcl_AppInit + 77
	8   _tkinter.so                         0x000000010490e485 Tkinter_Create + 997
	9   libpython2.7.dylib                  0x00000001000c74bc PyEval_EvalFrameEx + 40124
	10  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	11  libpython2.7.dylib                  0x000000010003e100 function_call + 176
	12  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	13  libpython2.7.dylib                  0x000000010001dbed instancemethod_call + 333
	14  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	15  libpython2.7.dylib                  0x00000001000bc547 PyEval_CallObjectWithKeywords + 87
	16  libpython2.7.dylib                  0x000000010002211e PyInstance_New + 126
	17  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	18  libpython2.7.dylib                  0x00000001000c0013 PyEval_EvalFrameEx + 10259
	19  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	20  libpython2.7.dylib                  0x00000001000c567d PyEval_EvalFrameEx + 32381
	21  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	22  libpython2.7.dylib                  0x00000001000c567d PyEval_EvalFrameEx + 32381
	23  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	24  libpython2.7.dylib                  0x00000001000c6238 PyEval_EvalFrameEx + 35384
	25  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	26  libpython2.7.dylib                  0x00000001000c567d PyEval_EvalFrameEx + 32381
	27  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	28  libpython2.7.dylib                  0x000000010003e100 function_call + 176
	29  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	30  libpython2.7.dylib                  0x000000010010436c RunModule + 124
	31  libpython2.7.dylib                  0x0000000100104e76 Py_Main + 2390
	32  python                              0x0000000100000f54 start + 52
	33  ???                                 0x0000000000000003 0x0 + 3
)
2016-01-04 15:19:07.324 python[83254:10454178] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSApplication _setup:]: unrecognized selector sent to instance 0x101ca0970'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff931b0ae2 __exceptionPreprocess + 178
	1   libobjc.A.dylib                     0x00007fff9c76873c objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff931b3b9d -[NSObject(NSObject) doesNotRecognizeSelector:] + 205
	3   CoreFoundation                      0x00007fff930ec601 ___forwarding___ + 1009
	4   CoreFoundation                      0x00007fff930ec188 _CF_forwarding_prep_0 + 120
	5   libtk8.5.dylib                      0x0000000104acc76d TkpInit + 472
	6   libtk8.5.dylib                      0x0000000104a44f91 Initialize + 1541
	7   _tkinter.so                         0x0000000104910a3d Tcl_AppInit + 77
	8   _tkinter.so                         0x000000010490e485 Tkinter_Create + 997
	9   libpython2.7.dylib                  0x00000001000c74bc PyEval_EvalFrameEx + 40124
	10  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	11  libpython2.7.dylib                  0x000000010003e100 function_call + 176
	12  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	13  libpython2.7.dylib                  0x000000010001dbed instancemethod_call + 333
	14  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	15  libpython2.7.dylib                  0x00000001000bc547 PyEval_CallObjectWithKeywords + 87
	16  libpython2.7.dylib                  0x000000010002211e PyInstance_New + 126
	17  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	18  libpython2.7.dylib                  0x00000001000c0013 PyEval_EvalFrameEx + 10259
	19  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	20  libpython2.7.dylib                  0x00000001000c567d PyEval_EvalFrameEx + 32381
	21  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	22  libpython2.7.dylib                  0x00000001000c567d PyEval_EvalFrameEx + 32381
	23  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	24  libpython2.7.dylib                  0x00000001000c6238 PyEval_EvalFrameEx + 35384
	25  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	26  libpython2.7.dylib                  0x00000001000c567d PyEval_EvalFrameEx + 32381
	27  libpython2.7.dylib                  0x00000001000c83a3 PyEval_EvalCodeEx + 2131
	28  libpython2.7.dylib                  0x000000010003e100 function_call + 176
	29  libpython2.7.dylib                  0x000000010000c552 PyObject_Call + 98
	30  libpython2.7.dylib                  0x000000010010436c RunModule + 124
	31  libpython2.7.dylib                  0x0000000100104e76 Py_Main + 2390
	32  python                              0x0000000100000f54 start + 52
	33  ???                                 0x0000000000000003 0x0 + 3
)
libc++abi.dylib: terminating with uncaught exception of type NSException
/Users/felixekness/Downloads/FlowCal-master/Run FlowCal (OSX): line 4: 83254 Abort trap: 6           python -m FlowCal.excel_ui

The error is reproducible in an OSX virtual machine. Furthermore, the following instructions are
enough to trigger the error:
import FlowCal
filetypes = [('Excel files', 'xlsx')]
FlowCal.excel_ui.show_open_file_dialog(filetypes=filetypes)

So it appears that the problem is in show_open_file_dialog.

Upon further investigation, I came up with a minimal code that triggers the error:
import matplotlib.pyplot as plt
from tkFileDialog import askopenfilename
askopenfilename()

If matplotlib is not imported, the error does not happen. So it seems that the interaction of these two modules is what causes the error.

Found more cases of matplotlib/tkinter incompatibilities in OSX: http://grokbase.com/t/python/tkinter-discuss/148c2kycbw/tkfiledialog-askopenfile-mac https://mail.python.org/pipermail/tkinter-discuss/2014-August/003656.html https://aeon.stsci.edu/ssb/trac/pyraf/ticket/108
It seems that the problem is matplotlib's backend, which by default is macosx in OSX, but TkAgg everywhere else.
Methods for changing the backend are documented here:
http://matplotlib.org/faq/usage_faq.html#what-is-a-backend
Accordingly, the following works:
import matplotlib
matplotlib.use('tkagg')
import matplotlib.pyplot as plt
from tkFileDialog import askopenfilename
askopenfilename()

I guess one solution would be to change the backend temporally inside show_open_file_dialog.

Unfortunately, changing the backend inside show_open_file_dialog using matplotlib.use does not work. Apparently, the backend has to be set before importing maptlotlib.pyplot and others for the first time. Some ways to solve this that I can think about are:

Calling matplotlib.use inside FlowCal.__init__.py, if the operating system is OSX and the detected backend is macosx. The drawback is that any use case of FlowCal that does not involve the Excel UI will have its backend changed. The problem is in show_open_file_dialog, so the fix should stay there.
Changing the window manager library, at least for OSX. This means requiring a new library. Also, most other GUI libraries have a non-native appearance. Nevertheless, the ones I found are pygtk, pyqt, and easygui.

I thought about another solution: The backend can also be set via the environment variable MPLBACKEND. Because this is a problem that occurs only in OSX and when using the Excel UI, one easy solution is to set this variable inside the Run FlowCal (OSX) script before calling FlowCal.

Proposed fix implemented in 65977a2a5d1565d80dbf807bdc90dd5efd025eb3. The problem looks fixed in my virtual machine. Will wait for @felixekn to test it in his computer. If it passes, I will merge into develop and close the issue.

It seems to be working in @felixekn's computer, but I'll test some more with different versions tomorrow. Ideally I would use a slightly older version of Anaconda or figure out how to cleanly change matplotlib to 1.4.3 and test.


Can't extract tables that have vertical orientation

Some pdf's have tables that are in vertical orientation (rotated). Tabula is not able to extract these tables. Is there a defect for this issue or can this be added as a new feature?

Hi.
This is not a defect, Tabula doesn't yet support extracting tables from rotated pages. Many PDF viewers, such as Preview in macOS, support rotating and re-saving the document. After doing that, re-upload the file to Tabula and it should work.

I want to programatically extract tables form 100's of pdf documents. Manually changing rotation is not a good option. This is a common case and I see many other folks have requested this feature. Can you add this to the backlog?

Yes, it is far from ideal. We can add it to the backlog for sure, but I don't know if it's ever going to be implemented. Tabula is made in our very little spare time.
You're more than welcome to hire a developer and, if desired, contribute the feature as a pull-request.
Thanks.


Preview does not work for many images

Description
For some reason Files cannot show preview for many images in my folder.

Steps To Reproduce

Install windows 11 pro.
Install files.
Go to folder with many pictures.

Expected behavior
Previews work.
Files Version
Версия: <IP_ADDRESS> OS Version: 10.0.22000.376
Windows Version
Windows 11 pro 21H2 10.0.22000.376
Relevant Assets/Logs
debug.log

Thanks for the report. What file format are those images? What have you set as default program to open those images?

Should be the same as #6130

Thanks for the report. What file format are those images? What have you set as default program to open those images?

Images are png. I set nomacs as default image viewer.

Should be the same as #6130

Opening folder in explorer does not helps, previews are already generated.

Why close?

https://github.com/files-community/Files/issues/7509#issuecomment-1008274187


ZVM: add column in instance list page

ZVM: add column in instance list page. The column will show ZCC+hexadecimal of instance ID.

There's no plan to do this. Close.

There's no plan to do this. Close.


Add an API for uploading robot configuration files

I'm working on a tool to simplify the programming process for teams without good development skills.
As part of this tool I'm using the API to upload and build robot code. I would love to also have an API to upload robot configuration files so that students don't have to worry about keeping them up to date by themselves.

Hey Andrew! Can I ask what "API to upload and build robot code" are you referring to? I'm not presently aware of which API this might be.

Hey Danny. I'm using the API as documented in the OpenFTC project here: https://github.com/OpenFTC/Extracted-RC/blob/3f86727ccaa5424401ec941922e78f0bf50100cc/OnBotJava/src/main/java/org/firstinspires/ftc/onbotjava/OnBotJavaProgrammingMode.java#LL83C27-L83C27
I know that there's not official documentation for the API, but I think that it would be beneficial.