Actions on SliverAppBar.large and SliverAppBar.medium is not shown on flutter 3.10.x

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Use flutter 3.10.x,
Implement SliverAppBar with either SliverAppBar.large or SliverAppBar.medium
Provide list of action buttons to actions parameter
Provide a FlexibleSpaceBar to flexibleSpace

I think the issue is relate with this.
Expected results
I can get this result with flutter v3.7.12

Actual results
I get this result after updating to flutter v3.10.0

Code sample
Code sample
SliverAppBar.large(
  actions: const [
    ...
  ],
  flexibleSpace: FlexibleSpaceBar(
  ...

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.10.4, on macOS 13.4 22F66 darwin-arm64, locale en-ID)
    ! Warning: `flutter` on your path resolves to /Users/alif.akbar/fvm/versions/3.7.12/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/alif.akbar/fvm/versions/3.10.4. Consider adding /Users/alif.akbar/fvm/versions/3.10.4/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/alif.akbar/fvm/versions/3.7.12/bin/dart, which is not inside your current Flutter SDK checkout at /Users/alif.akbar/fvm/versions/3.10.4. Consider adding /Users/alif.akbar/fvm/versions/3.10.4/bin to the front of your path.
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.79.0)
[✓] Connected device (2 available)
[✓] Network resources

! Doctor found issues in 1 category.

Hi @alifgiant
This is fixed by https://github.com/flutter/flutter/pull/122542. However, the fix isn't available in the stable 3.10.x channel yet,  currently it is available on beta and above.
Here I created a simple sample to showcase this.

code sample
import 'package:flutter/material.dart';

/// Flutter code sample for [SliverAppBar.medium].

void main() {
  runApp(const AppBarMediumApp());
}

class AppBarMediumApp extends StatelessWidget {
  const AppBarMediumApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        colorSchemeSeed: const Color(0xff6750A4),
      ),
      home: Material(
        child: CustomScrollView(
          slivers: <Widget>[
            SliverAppBar.medium(
              leading:
                  IconButton(icon: const Icon(Icons.menu), onPressed: () {}),
              title: const Text('Medium App Bar'),
              flexibleSpace: FlexibleSpaceBar(
                // Add a random image to background.
                background: Image.network(
                  'https://picsum.photos/seed/picsum/200/300',
                  fit: BoxFit.contain,
                ),

              ),
              actions: <Widget>[
                IconButton.filledTonal(icon: const Icon(Icons.add), onPressed: () {}),
                IconButton.filledTonal(icon: const Icon(Icons.info), onPressed: () {}),
                IconButton.filledTonal(icon: const Icon(Icons.more_vert), onPressed: () {}),
              ],
            ),
            // Just some content big enough to have something to scroll.
            SliverToBoxAdapter(
              child: Card(
                child: SizedBox(
                  height: 1200,
                  child: Padding(
                    padding: const EdgeInsets.fromLTRB(8, 100, 8, 100),
                    child: Text(
                      'Here be scrolling content...',
                      style: Theme.of(context).textTheme.headlineSmall,
                    ),
                  ),
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

stable 3.10.x
beta 3.12.x

Closing as fixed

Hi @TahaTesser thanks. Do you know when will it arrived to stable channel?
I see 3.10.4 has fixes regarding SliverAppBar, why the fix not included?

@alifgiant
This should be available in the next major stable release.

I see 3.10.4 has fixes regarding SliverAppBar, why the fix not included?

That's a different issue.

This should be available in the next major stable release.
that would be a quite long wait. what could i do to show the action buttons on current stable?

@TahaTesser
I'm working on an app that needs to be released this week, any work arounds?

@dickermoshe i found that we can use SliverAppBar directly without .large or .medium to show the actions. The trick is to manually set the height param.


CI setup

Closes #3
Github Actions setup against multiple versions of ruby and activesupport gem

🎉 all CI is green ✅


Bump protobuf dependency to latest

@dweomer or @kinarashah could you review? I can't add reviewers

LGTM (also @cmurphy you have been added with write permissions which should allow for adding reviewers in the future)


[Athena] Added support for reading the schema from Glue

Added support for reading the schema from Glue, which includes views info in addition to tables info.

Thanks @pvieito!


Remove unnecessary FormatJoinString() method

https://github.com/sdoubleday/scdtype6generator/blob/eeaee4ef109aa7aba61e20a44610393b8f9d0976/SCDType6Generator/LineProcessor.cs#L146

Closed - turns out, we DID need that.


⚠ SkipTheCommericals has degraded performance

In 07f63d7, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 10023 ms

Resolved: SkipTheCommericals performance has improved in 2fdec9c.


Back Button Size to be reduced

Back Button size is greater than Hamburger Menu button it not suitable for view
This is captured on mobile 640XL using Windows Template Studio
and I also studied something About Showing Alt + Left Tool tip when hover anywhere on the app.
To avoid that Windows Template Studio Created this Line of Code at Shell page
private void OnLoaded(object sender, RoutedEventArgs e)
{
// Keyboard accelerators are added here to avoid showing 'Alt + left' tooltip on the page.
// More info on tracking issue https://github.com/Microsoft/microsoft-ui-xaml/issues/8
KeyboardAccelerators.Add(_altLeftKeyboardAccelerator);
KeyboardAccelerators.Add(_backKeyboardAccelerator);
}
but this code Throw an error for Mobile Application.
Please Review this Also

Thanks @jevansaks, I'll open an issue on WTS for the second part

The NavigationViewBackButton is set to 40x40 by its style. 24pt icon. Picked up from rs_generic.xaml.
The TogglePaneButton is set to 48x44 according to its RS2 style. 16pt icon.
Running the same app on desktop (not phone), we pick up RS5 styles and TogglePaneButton has dropped to 40x40 according to the new RS5 standard density. The NavigationViewBackButon remains at 40x40. So they match in footprint. They also match with 16pt icons.
So there are two issues: The control footprints are different. Also the back button icon size is larger.
Switching to the 2.1 prelease build the footprint is fixed (due to downlevel density); both are 40x40. But the 24pt back button icon remains. Again, this appears to be a phone-specific difference. On desktop the icon is 16pt.

Sadly, phone is going out of support at the end of the year so unless we have a repro on a supported platform (desktop, xbox, etc) then we can't justify spending time on this.


Async method should has Async as its name.

All the methods don't have Async as end of it's method name. Should we change it? For example, Jobs.List() to Jobs.ListAsync()?

But why? Earlier APIs has to distinguish between newer async and older non-async methods, so they adopted such a naming convention to add the Async suffix. Modern APIs that don't have any non-async counterparts don't have to adopt this convention.
In fact, any method returning Task or ValueTask (or their generic counterparts) can be awaited. It doesn't have to have the async keyword in its declaration.

Agree. Closing this issue.

But why? Earlier APIs had to distinguish between newer async and older non-async methods, so they adopted such a naming convention to add the Async suffix. Modern APIs that don't have any non-async counterparts don't have to adopt this convention.
In fact, any method returning Task or ValueTask (or their generic counterparts) can be awaited. It doesn't have to have the async keyword in its declaration.

@michael-damatov that's different from my understanding that Microsoft libraries have Async at the end of the asynchronous methods so it's a bit confusing to me as the SDK consumer to write code with await but not Async. But if that's the decision of this repo, then I have no objection. (maybe my knowledge is old)


Adding password optional property

Simon,
As I said , I had to add password optional property.
Thank your for helping me :)

OK merged and npm published 0.4.1 Thanks!

Think I need to do a bit of a refactor, cleanup and es6ify on this codebase.

hehe You've done a very nice work .
Do you have any ideas to improve this project ?
Date: Sat, 23 Jul 2016 21:53:18 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [simonswain/straw] Adding password optional property (#10)
Think I need to do a bit of a refactor, cleanup and es6ify on this codebase.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Waypoint: Nest an Anchor Element within a Paragraph - Confusion about  placement

Challenge "Waypoint: Nest an Anchor Element within a Paragraph"
I get a lot of questions about the test "Your a element should be nested within your new p element."  For some reason a lot of users want to move the new
 element down to the bottom of the page.  The test code only checks to see if the first
 element contains the anchor.
 Users like to put it here -->

View more cat photos

One of two things should happen:

The test should be changed to find the p element anywhere on the page or
There should be a change to the challenge text to say to leave the image tag in place and wrap the
 around it.

Haha, I had noticed the same thing so I put in PR #3813 that should solve this whenever it gets merged into the master branch. Closing since this is already in staging :smile:

Haha, there is something to be said for problems being solved before you even file them!
Thanks @ltegman!


broken hostname resolution, especially for localhost

Do you want to request a feature or report a bug?
Bug
What did you do?
I recently upgraded my system and found that traefik is not honoring the /etc/hosts file like it used to.
I have configured a service with url = http://localhost:809.
What did you expect to see?
I expected to see the proxy connect to http://<IP_ADDRESS>:809
What did you see instead?
The proxy was connecting to http://localhost.so:809/.
Note: .so is the TLD for my server.
Output of traefik version: (What version of Traefik are you using?)
Version:      2.3.0-rc4
Codename:     picodon
Go version:   go1.15
Built:        2020-08-19T16:02:03Z
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
http:
  routers:
    xxx:
      rule: "Host(`xxx`)"
      service: xxx

  services:
    xxx:
      loadBalancer:
        servers:
        - url: http://localhost:809

/etc/hosts in container
<IP_ADDRESS>	localhost

# The following lines are desirable for IPv6 capable hosts
::1     localhost ip6-localhost ip6-loopback
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters

Official docker image on docker 19.03.12 with --net host on Debian 10.

Hello,
Could you try with some others versions? (v2.2.9, v2.3.0-rc3, ...)

Yes, good idea. I tried other versions and they all have the same issue. The image I was using before was v2.2.0. I rebuilt the server and moved from CentOS 6 to Debian 10, so some things changed; though I'm not sure what triggered this behaviour.
The hostname has not changed and docker was fairly recent on the old system.

I don't think this is related to Traefik, because I don't reproduce.

Other tools work fine, like ping and wget. Is there documentation on how traefik does hostname resolution?

like the other programs, but if you are using a container, your /etc/hosts will not be used, it's expected.

That isn't expected at all. The other programs do use /etc/hosts.

Are you saying traefik isn't supposed to work with url = http://localhost:PORT ? That would only work if it honors /etc/hosts.

If your /etc/hosts is not in the container, it's expected.

It is in the container. Docker puts it there.

From my point of view, your issue is question, so could we continue the discussion into the community forum https://community.containo.us
Thank you.

This is absurd. So your position is that traefik does not work with url = http://localhost:PORT.

Could provide a full repoducible example in the community forum?
I don't reproduce neither locally with a binary (without Docker) nor with a Docker container.

I spend time to answer you, I will spend time to help you on the community forum, it's not fair.


featureSupport partition prune

Proposed changes
Issue Number: noissue
Problem summary
Rewrite filter->project to project -> filter to make sure when do partition prune the tree looks like this: project -> filter -> olapscan.
Enable the MergeConsecutiveProject MergeConsecutiveFilter.
Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Please add unit tests to cover tests in ListPartitionPrunerTest and RangePartitionPruneTest.

@morrySnow

Please add unit tests to cover tests in ListPartitionPrunerTest and RangePartitionPruneTest.

Current support  RangePartitionPrune first in this PR


Word2Vec.py ReluGrad is not finite

Running the tutorial as downloaded from tensorflow.org results in an exception stating that the ReluGrad is not finite.  This happens with the learning rate set to .00001 and concurrent steps set to 1.  Once this exception is thrown, learning stops.  It happens at epoch 0, roughly step 500,000.

This seems to have fallen through the cracks.  @a-dai: Did you get a chance to glance at this?  @bugulnoz: Is it still an issue?

Automatically closing because there was no response. Please reopen if it is still an issue.


Merge in Kit's 3d printed wheel hubs

To be default in master. Keep the other wheel hubs (with the holes drilled through the wheels) as a documented backup.
Update documentation correspondingly.
Also: are Traxxas wheels still available?

See https://github.com/nasa-jpl/open-source-rover/issues/273


HEDA Settings page needs translated

This is using Spanish (after 1.51 release can also use French to check, and possibly Catalan later).
I saw this in both HEDA package 1.50 and HEDA package 1.51
Note- I was in chrome.
Steps:

Go to the User Settings page.->Change the language in Language and Time Zone section to "Spanish" (Note- my Locale was still English (United States)). Save.
I refreshed the browser a couple of times (I'm in lightning).
Other tabs looked translated (contacts, accounts, terms, etc.)
Go to Heda Settings Tab. The title was translated. But all the sub tabs and other sections/text were all in English.  See screenshot.

Note- the screenshot was taken with French in 1.51 release (QA Sandbox), however it looks the same in Spanish. Heda settings tab name is translated but not the content of each sub tab.

This has long-since been resolved.


Build new RPC enabled controller module for test harness

The current implementation of the controller is based on the CTypes based controller. This is deprecated, and this issue is tracking the implementation of a new RPC enabled controller using the pybind11 package.

Filed sub issues for each API:
#52 #53 #54 #55 #56 #57 #58 #59 #60 #61 #62


Disable new relic in wsgi file.

Coverage remained the same at 92.556% when pulling 7656a573b916658dc3c867d763e2903872e1d711 on johngian:wsgi-issue into 19b3a14325139c41471b56d2fb1559621539cddd on mozilla:master.

Coverage remained the same at 92.556% when pulling 8a437e899a342be4e1bf3207f31a7abb81479e3e on johngian:wsgi-issue into 19b3a14325139c41471b56d2fb1559621539cddd on mozilla:master.


bump version

Current coverage is 91.37% (diff: 100%)

Merging #7 into master will not change coverage

@@             master         #7   diff @@
==========================================
  Files             3          3
  Lines            58         58
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             53         53
  Misses            5          5
  Partials          0          0

Powered by Codecov. Last update 6e45255...9ba7558


Dependencies are re-downloaded on every run

Issue Type

Bug report

Molecule and Ansible details
ansible 2.7.5
  config file = None
  configured module search path = ['/home/calvin/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/calvin/Desktop/ansible/lib/python3.6/site-packages/ansible
  executable location = /home/calvin/Desktop/ansible/bin/ansible
  python version = 3.6.7 (default, Oct 22 2018, 11:32:17) [GCC 8.2.0]
molecule, version 2.19.0

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used: Ubuntu 18.04 in Docker
platforms:
  - name: ansible-awx
    image: ubuntu:18.04

Desired Behavior
Galaxy should download only once instead of every run, especially if it already exists and the version matches
Actual Behaviour
First run
(ansible) ➜  ansible-awx molecule converge
--> Validating schema /mnt/hgfs/repos/ansible-awx/molecule/default/molecule.yml.
Validation completed successfully.
--> Test matrix

└── default
    ├── dependency
    ├── create
    ├── prepare
    └── converge

--> Scenario: 'default'
--> Action: 'dependency'
    - downloading role 'ansible_git', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-git/archive/1.0.tar.gz
    - extracting calvinbui.ansible_git to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_git
    - calvinbui.ansible_git (1.0) was installed successfully
    - downloading role 'ansible_pip', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-pip/archive/1.0.tar.gz
    - extracting calvinbui.ansible_pip to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_pip
    - calvinbui.ansible_pip (1.0) was installed successfully
    - downloading role 'ansible_nodejs', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-nodejs/archive/1.0.tar.gz
    - extracting calvinbui.ansible_nodejs to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_nodejs
    - calvinbui.ansible_nodejs (1.0) was installed successfully
    - downloading role 'ansible_docker', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-docker/archive/1.0.tar.gz
    - extracting calvinbui.ansible_docker to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_docker
    - calvinbui.ansible_docker (1.0) was installed successfully
Dependency completed successfully.

Second run
(ansible) ➜  ansible-awx molecule converge
--> Validating schema /mnt/hgfs/repos/ansible-awx/molecule/default/molecule.yml.
Validation completed successfully.
--> Test matrix

└── default
    ├── dependency
    ├── create
    ├── prepare
    └── converge

--> Scenario: 'default'
--> Action: 'dependency'
    - changing role calvinbui.ansible_git from 1.0 to 1.0
    - downloading role 'ansible_git', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-git/archive/1.0.tar.gz
    - extracting calvinbui.ansible_git to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_git
    - calvinbui.ansible_git (1.0) was installed successfully
    - changing role calvinbui.ansible_pip from 1.0 to 1.0
    - downloading role 'ansible_pip', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-pip/archive/1.0.tar.gz
    - extracting calvinbui.ansible_pip to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_pip
    - calvinbui.ansible_pip (1.0) was installed successfully
    - changing role calvinbui.ansible_nodejs from 1.0 to 1.0
    - downloading role 'ansible_nodejs', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-nodejs/archive/1.0.tar.gz
    - extracting calvinbui.ansible_nodejs to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_nodejs
    - calvinbui.ansible_nodejs (1.0) was installed successfully
    - changing role calvinbui.ansible_docker from 1.0 to 1.0
    - downloading role 'ansible_docker', owned by calvinbui
    - downloading role from https://github.com/calvinbui/ansible-docker/archive/1.0.tar.gz
    - extracting calvinbui.ansible_docker to /tmp/molecule/ansible-awx/default/roles/calvinbui.ansible_docker
    - calvinbui.ansible_docker (1.0) was installed successfully
Dependency completed successfully.

molecule/default/requirements.yml
---

- src: calvinbui.ansible_git
  version: 1.0
- src: calvinbui.ansible_pip
  version: 1.0
- src: calvinbui.ansible_nodejs
  version: 1.0
- src: calvinbui.ansible_docker
  version: 1.0

molecule/default/mocule.yml (snippet)
---
dependency:
  name: galaxy

Just my 2cts, but i had the same concern even without molecule and this behaviour should be fix on the ansible-galaxy/mazer side.
This is ansible-galaxy/mazer who need to choose to download the role again and not molecule and many discussions already exist about this :
https://github.com/ansible/proposals/issues/23
https://github.com/ansible/ansible/issues/6466
https://github.com/ansible/galaxy-issues/issues/49
https://github.com/ansible/mazer/issues/173
Regards,

Closing out based on two points:

Multiple people said this shouldn't be solved here (see https://github.com/ansible/molecule/issues/1641#issuecomment-476236049 and https://github.com/ansible/molecule/issues/1641#issuecomment-455198351)
Setting force:false is maybe bad (see https://github.com/ansible/molecule/issues/1641#issuecomment-455200311)

Let's put some pressure on upstream :+1:

@rgarrigue has come to chat about this on IRC and I'm re-opening.

I am closing this because this is more of a limitation of galaxy and there is not much molecule can do about it. Still, this does not mean that a PR related to this ticket would not be appreciated.

I recently started using the molecule to integrate my project's Ansible functions into the CI/CD process and quickly ran into two problems:

Duplication of the dependency file, for the use of the molecule (project/requirements.yml) and the role itself (project/meta/requirements.yml)
Inability to force the download of roles if they had already been installed previously, being cached in the folder ~/.cache.

After much research and many attempts, I found the following solution:
.env.yml
---
ANSIBLE_ROLES_PATH: galaxy_roles

.gitignore
(...)
galaxy_roles/
(...)

molecule/default/molecule.yml
---
dependency:
  name: shell
  command: ansible-galaxy install -r meta/requirements.yml -p galaxy_roles/ --force
driver:
  name: docker
platforms:
  - name: molecule-ubuntu
    image: ubuntu
    pre_build_image: true
provisioner:
  name: ansible
verifier:
  name: ansible
lint: |
  set -e
  yamllint .
  ansible-lint

This way, just by changing dependency to shell and executing the command to install roles to a different folder (always forcing the installation) I can use the same dependency file for the molecule and the role itself.
So I always have the most up-to-date dependencies and avoid code duplication.
I hope it's useful to someone.

In fact if you are using latest version of molecule, it will install repository revel requirements.yml itself without you having to add anything to molecule.yml file. You are better of removing dependency block from molecule config.
In fact molecule own logic is smarter than galaxy itself and installs dependencies only when they are missing (galaxy from 2.9 does not support that, not even ability to upgrade them).

In fact if you are using latest version of molecule, it will install repository revel requirements.yml itself without you having to add anything to molecule.yml file. You are better of removing dependency block from molecule config.
In fact molecule own logic is smarter than galaxy itself and installs dependencies only when they are missing (galaxy from 2.9 does not support that, not even ability to upgrade them).

Thanks for your reply ssbarnea, but in may case I using my own dependencies from my git repository, and when I changed something and doesn't change the tag, the molecule not will force the dependence update, it executes the command without "--force" flag, and I am using the latest version of molecule. And with the solution that I proposed, I didn't need add a an additional "dependencies.yml" to the root project folder, it will consume the meta/dependencies.yml directly from the role.


Elasticsearch.Extensions.Logging  Just Log ECS format to File from .NET [FEATURE]

I really like Elasticsearch.Extensions.Logging.  It is a piece of cake to implement.
However, not all of my apps are logging to Elastic.  Some are logging to Splunk.  ECS is a superior schema.  I would like to utilize it as the common logging output.  Splunk should have no problem with it.
How can I just log from .NET logging to a file with ECS format?  Can you provide me some guidance here?  Most are using NLog.

There is an example here for using it with NLog Console Target:
https://github.com/elastic/ecs-dotnet/blob/master/src/Elastic.CommonSchema.NLog/README.md
Should be trivial to use it for NLog FileTarget (Change from type="Console" to type="File")

There is an example here for using it with NLog Console Target:
https://github.com/elastic/ecs-dotnet/blob/master/src/Elastic.CommonSchema.NLog/README.md
Should be trivial to use it for NLog FileTarget (Change from type="Console" to type="File")

I knew about NLog but was hoping for without to minimize dependencies.  However, NLog does provide a rich set of features.  I will check it out.  Thank You!

I knew about NLog but was hoping for without to minimize dependencies.  However, NLog does provide a rich set of features.  I will check it out.  Thank You!

This would be a good enhancement, although currently I'm focusing on getting Extensions to GA, so that it is broadly available and easy to add.
Currently the logger submits the log event to the elastic client, which takes care of sending it to the server, etc, although bypassing that to write the output to a file won't be too much of a change.
Some considerations though:

Should it be an option on this logger, although it is only using the ECS format and not actually logging to Elasticsearch, or a separate logger provider package?
Assuming you mean the JSON format that would be submitted, what formatting options would you want, e.g. whitespace, newlines, indenting, etc, or just single line output?
Structure of the file; each JSON fragment would make sense, but would you be expecting a starting array "[" and then commas "," in between, or just fragments separate by newlines (e.g. JSON Lines format, https://jsonlines.org/)
What file management features would you want, e.g. timestamped files, maximum size, rolling files, cleanup, etc. (for one such approach, see https://github.com/sgryphon/essential-logging/tree/master/src/Essential.LoggerProvider.RollingFile)

This would be a good enhancement, although currently I'm focusing on getting Extensions to GA, so that it is broadly available and easy to add.
Currently the logger submits the log event to the elastic client, which takes care of sending it to the server, etc, although bypassing that to write the output to a file won't be too much of a change.
Some considerations though:

Should it be an option on this logger, although it is only using the ECS format and not actually logging to Elasticsearch, or a separate logger provider package?
Assuming you mean the JSON format that would be submitted, what formatting options would you want, e.g. whitespace, newlines, indenting, etc, or just single line output?
Structure of the file; each JSON fragment would make sense, but would you be expecting a starting array "[" and then commas "," in between, or just fragments separate by newlines (e.g. JSON Lines format, https://jsonlines.org/)
What file management features would you want, e.g. timestamped files, maximum size, rolling files, cleanup, etc. (for one such approach, see https://github.com/sgryphon/essential-logging/tree/master/src/Essential.LoggerProvider.RollingFile)

Thinking about these, and based on what you want (import into Splunk, or some other tool), logging using ECS JSON Lines format, with rolling file options, seems to fit what you need.
Either a new logger EcsJsonLinesLogger or some sort of flag like EcsJsonLinesFormat, although a new logger may be better otherwise the configuration and code becomes a big mess with two parts (file or Elasticsearch) only one of which is used at a time.
Extracting out the common gathering parts, and composing them into two different loggers, may be neater.

Thinking about these, and based on what you want (import into Splunk, or some other tool), logging using ECS JSON Lines format, with rolling file options, seems to fit what you need.
Either a new logger EcsJsonLinesLogger or some sort of flag like EcsJsonLinesFormat, although a new logger may be better otherwise the configuration and code becomes a big mess with two parts (file or Elasticsearch) only one of which is used at a time.
Extracting out the common gathering parts, and composing them into two different loggers, may be neater.

This is great work.  I will take a look when I get a chance.  Just replicating the NLog rolling file features will make it great.  It would just have to be something that FileBeat and Splunk would work with.  Splunk will work with most valid JSON whether it is an array or just blobs separated by CRLF.  I have used FileBeat with NLog JSON delimited with CRLF.
I was looking at doing something like it.  However, I would probably just end up using NLog since I am usually pressed for time.  The NLog feature set is rich along with the community.  ECS negates most of the formatting feature set.  The targets are nice.  There is probably already an elastic target.
I was also looking to experiment with an Eventsource to ECS mapping too.  Eventsource is the native .NET instrumentation.  It really is the holy grail of logging/instrumentation since it is captured in Perfview with all of the other .NET eventsources.   However, developers don't seem to like coding an eventsource.

This is great work.  I will take a look when I get a chance.  Just replicating the NLog rolling file features will make it great.  It would just have to be something that FileBeat and Splunk would work with.  Splunk will work with most valid JSON whether it is an array or just blobs separated by CRLF.  I have used FileBeat with NLog JSON delimited with CRLF.
I was looking at doing something like it.  However, I would probably just end up using NLog since I am usually pressed for time.  The NLog feature set is rich along with the community.  ECS negates most of the formatting feature set.  The targets are nice.  There is probably already an elastic target.
I was also looking to experiment with an Eventsource to ECS mapping too.  Eventsource is the native .NET instrumentation.  It really is the holy grail of logging/instrumentation since it is captured in Perfview with all of the other .NET eventsources.   However, developers don't seem to like coding an eventsource.

I personally feel if you want to log to file you should use NLog or Serilog or @sgryphon's Essential.LoggerProvider.RollingFile.
There are tons of edgecases to logging to file that are already better handled by existing logging frameworks. Probably one of the major reasons there is no FileLoggerProvider OOTB from Microsoft either. If there was one we'd definitely look into supporting that.
Elastic.CommonSchema.NLog helps you to log to file in ECS format with NLog.
Elastic.CommonSchema.Serilog ships with EcsTextFormatter that allows you to log to any sink accepting an ITextFormatter (e.g console/file) in ECS format.
It might make sense to ship a custom Console Logger Formatter though.
This would make it super easy to log ECS logs to stdout which is useful in docker/k8s setups.


GatewayClassObservedGenerationBump feature type

What happened:
GatewayClassObservedGenerationBump is marked as an additional feature, but it Is marked neither as extended conformance nor as experimental conformance: https://github.com/kubernetes-sigs/gateway-api/blob/f6d4eb7a31506be144d5288526eb5f3cceb1bcf1/conformance/utils/suite/suite.go#L56-L57
My guess is that it is extended conformance, is it correct? If so, we should add (extended conformance) at the end of the comment line as all the other features above and below.

This relates back to https://github.com/kubernetes-sigs/gateway-api/issues/1584 which initiated the change in the first place. In retrospect I believe the intention was to make this part of core conformance, as every implementation should be updating object status to indicate (for each condition) that they've seen the latest generation of the object.

/help

/assign

/remove-help

Blocked on https://github.com/kubernetes-sigs/gateway-api/issues/1822

Just a status update that we're still blocked on #1822, once that is complete we should probably add this to the agenda for a few meetings in a row to give people a heads up of our intention to make it core and then go for it at some point prior to GA.

#1822 has gone through, this is no longer blocked @mlavacca


Builtin official python support

Hi
I just want to ask if there is any plan for the official support for python intellisense? If so is there any expected timeline for it ?
Thanks

I think there are no plans for an official support. But you can download an Python extension where the Python Language is supported with Intellisense, Linting, Debugging .... and so on.

I think there are no plans for an official support. But you can download an Python extension where the Python Language is supported with Intellisense, Linting, Debugging .... and so on.

We recommend the Python extension that @Daylien mentioned and have invested in it. We don't have plans to bundle it though.

We recommend the Python extension that @Daylien mentioned and have invested in it. We don't have plans to bundle it though.


Coverlet's abstraction of transparency is (inevitably) leaky

I have a system of UnitTest.dll which links against SystemUnderTest.dll and SampleCode.dll; my unit test instructs the system under test to use Mono.Cecil to read symbol data for the sample code.
This fails when run under coverlet with
Error Message:
 System.InvalidOperationException : Operation is not valid due to the current state of the object.
Stack Trace:
   at Mono.Cecil.ModuleDefinition.ReadSymbols(ISymbolReader reader)

I'd be happy enough with a solution that went "if (running under coverlet) then (look in this deterministic named folder instead for the unaltered code)", but the folder to test for the existence of to look in is not even documented.
I expect similar problems might occur for code using the Microsoft.Cci facilities from FxCop, but haven't yet tested that.

This is definitely something that's bound to happen. Considering that coverlet rewrites assemblies I can imagine that an assembly trying to rewrite another assembly that coverlet has already instrumented will be a problem. There are two approaches I currently see to fix this:

#77 when fixed will allow the developer to simply ignore the assembly his code wishes to rewrite
Update the assembly PDB to match the changes made to the assembly. This comes with the added benefit of making code within instrumented assemblies debuggable during tests

The first approach is currently being worked on, the second one will make it into coverlet sometime in the future

This affects even read-only operations that want to match IL with source (e.g. static analysis); #77, however will be an entirely satisfactory resolution

#77 fixed and merged in. See new release here: https://www.nuget.org/packages/coverlet.msbuild/2.0.0


Use timeout utility instead of double-sub-shell hell

It turned out that for incremental builds for Node.js, the test always waited 10m no matter that the build finished sooner.
It's not clear why it happened, but when debugging, it seemed like some weired race-condition happened that let some sleeps hang.
Anyway, it's not clear whether there is a reason to not use timeout utility that seems to serve exactly for this reason.

@SlouchyButton Any idea why timeout could be a problem here?

[test]

[test]

[test]

[test]

[test]

[test]

Let's get merge it and distribute to s2i-nodejs-container as first.


Pip not installing with correct shebang

I am running the latest version of the python:3.8-slim-buster image.
When I try to install a package (pg_activity in this case), pip is not placing the correct shebang in the executable:
➤ docker run --rm -it python:3.8-slim-buster bash
root@11b637f012cd:/# which python
/usr/local/bin/python
root@11b637f012cd:/# which pip
/usr/local/bin/pip
root@11b637f012cd:/# pip install pg_activity
Collecting pg_activity
  Downloading pg_activity-2.1.2-py3-none-any.whl (45 kB)
     |████████████████████████████████| 45 kB 3.1 MB/s
Collecting humanize
  Downloading humanize-3.2.0-py3-none-any.whl (70 kB)
     |████████████████████████████████| 70 kB 3.9 MB/s
Collecting psutil>=2.0.0
  Downloading psutil-5.8.0-cp38-cp38-manylinux2010_x86_64.whl (296 kB)
     |████████████████████████████████| 296 kB 25.1 MB/s
Collecting attrs
  Downloading attrs-20.3.0-py2.py3-none-any.whl (49 kB)
     |████████████████████████████████| 49 kB 19.9 MB/s
Collecting blessed
  Downloading blessed-1.18.0-py2.py3-none-any.whl (81 kB)
     |████████████████████████████████| 81 kB 19.2 MB/s
Collecting wcwidth>=0.1.4
  Downloading wcwidth-0.2.5-py2.py3-none-any.whl (30 kB)
Collecting six>=1.9.0
  Downloading six-1.15.0-py2.py3-none-any.whl (10 kB)
Requirement already satisfied: setuptools in /usr/local/lib/python3.8/site-packages (from humanize->pg_activity) (54.1.1)
Installing collected packages: wcwidth, six, psutil, humanize, blessed, attrs, pg-activity
Successfully installed attrs-20.3.0 blessed-1.18.0 humanize-3.2.0 pg-activity-2.1.2 psutil-5.8.0 six-1.15.0 wcwidth-0.2.5
root@11b637f012cd:/# which pg_activity
/usr/local/bin/pg_activity
root@11b637f012cd:/# pg_activity --version
bash: /usr/local/bin/pg_activity: /usr/bin/python3: bad interpreter: No such file or directory

Indeed, that binary does not exist in /usr/bin, so there should be no reason for pip to assign it to the shebang, right?
root@11b637f012cd:/# cat /usr/local/bin/pg_activity
#!/usr/bin/python3

"""
pg_activity
author: Julien Tachoires<EMAIL_ADDRESS>license: PostgreSQL License

Copyright (c) 2012 - 2019, Julien Tachoires
Copyright (c) 2020, Dalibo

Permission to use, copy, modify, and distribute this software and its
documentation for any purpose, without fee, and without a written
agreement is hereby granted, provided that the above copyright notice
and this paragraph and the following two paragraphs appear in all copies.

IN NO EVENT SHALL JULIEN TACHOIRES BE LIABLE TO ANY PARTY FOR DIRECT,
INDIRECT, SPECIAL, INCIDENTAL, OR CONSEQUENTIAL DAMAGES, INCLUDING LOST
PROFITS, ARISING OUT OF THE USE OF THIS SOFTWARE AND ITS DOCUMENTATION,
EVEN IF JULIEN TACHOIRES HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

JULIEN TACHOIRES SPECIFICALLY DISCLAIMS ANY WARRANTIES, INCLUDING, BUT
NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
FOR A PARTICULAR PURPOSE. THE SOFTWARE PROVIDED HEREUNDER IS ON AN "AS IS"
BASIS, AND JULIEN TACHOIRES HAS NO OBLIGATIONS TO PROVIDE MAINTENANCE,
SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
"""

...

Compare with: https://github.com/dalibo/pg_activity/blob/master/pg_activity#L1
cc @Yajo

That seems to be a problem with the pg_activity-2.1.2-py3-none-any.whl; it has somehow embedded #!/usr/bin/python3 instead of the #!/usr/bin/env python3 that is in the upstream.
pip install --no-binary pg_activity pg_activity fixes it to install with the a working executable path (#!/usr/local/bin/python). Not sure why the wheel is making assumptions about the python path. Sounds like a bug in the creation of the wheel. :shrug:
Right now, I don't see this as a bug in the Docker image itself.

Ok, thanks for the help @yosifkit :smiley:
I just thought it could be a problem with the python installation in the image that was causing the wrong executable path.
I will open the issue upstream :+1:


ACM-13449: Label ConfigMaps and Secrets for backup

In order for the ACM hub DR solution to include our required ConfigMaps and Secrets, they must be labeled with
cluster.open-cluster-management.io/backup=true.
Ensure the label is present on each reconcile.
The ImageClusterInstall is already covered because all resources in the hive.openshift.io group are automatically backed up.
Resolves https://issues.redhat.com/browse/ACM-13449

/retest

Just FYI see https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_management_for_kubernetes/2.10/html/business_continuity/business-cont-overview#resources-that-are-backed-up for the list of objects being backed up by default


Update the doctrine mapping xml schema

Allow uses of extension tags and/or attributes inside the embedded tag
relates to https://github.com/Atlantic18/DoctrineExtensions/pull/1379

Makes sense to me.

While it is indeed an interesting improvement, it also evidences the fact that DoctrineExtensions should most probably have its own mapping files, un-mixed with Doctrine's.
I'm going to close this, as I think we should stop having external namespaces creeping features into core.

Note: had a similar discussion with the folks building Skipper18 (an ORM tool) - the mix of ORM and extensions mappings is quite problematic for them as well (similar use-cases), and separate mapping files would be the best solution.


Add export for ROUTINE_PROMISE_ACTION action type

To use in some custom actions, reducers, middleware  etc.
For example my use case is to have routine to promise converter using redux-thunk.
// import { ROUTINE_PROMISE_ACTION }  from 'redux-saga-routines' <== missing export
const ROUTINE_PROMISE_ACTION = '@@redux-saga-routines/PROMISE'

export default function routineToPromiseAction (routine) {
  return (payload) => (dispatch) => new Promise((resolve, reject) => dispatch({
    type: ROUTINE_PROMISE_ACTION,
    payload: {
      payload,
      routine,
      defer: { resolve, reject },
    },
  }))
}

May be it is better to export full middleware for redux-thunk like for redux-saga?

This is just example use case. I don't see reason for coupling Your lib with redux-thunk.
But some middleware for "converting" routines to promises would be nice feature and it should be doable without redux-thunk but this is probably topic for other discussion.
Anyway I still think it would be nice to have this action type exported.
For example react-router-redux also exports LOCATION_CHANGE action type. https://github.com/reactjs/react-router-redux/blob/master/src/index.js#L2

I agree with you about exporting action type.


Basic ImportLhotse processor

This is a minimal example of how Lhotse manifests could be imported into SDP/NeMo. It would enable leveraging 80+ existing data prep modules in lhotse for various dataset. Typically, the user code would look sth like:
#
# Lhotse prep. Full list of recipes:
# https://github.com/lhotse-speech/lhotse/tree/master/lhotse/recipes
#

from lhotse.recipes import download_librispeech, prepare_librispeech

libri_root = download_librispeech("data/download")
libri = prepare_librispeech(libri_root, output_dir="data/lhotse")
cuts_train_clean_100 = CutSet.from_manifests(**libri["train-clean-100"])
cuts_train_clean_100.to_file("data/lhotse/cuts_train_clean_100.jsonl.gz")

#
# NeMo import
#
from sdp.processors.datasets.lhotse import LhotseImport

processor = LhotseImport(
  "data/lhotse/cuts_train_clean_100.jsonl.gz",
  "data/nemo/train_clean_100.json"
)
processor.process()

This version supports only "basic" type of data (single utterance per audio file, single channel), but it could be later extended to support broader set of Lhotse data types (multi-channel, multi-file, mixed cuts, augmented cuts, resampled data, url/pipe audio sources, tarred data, etc.), possibly by using cuts.save_audios() to create a local copy of processed audio data (which I think is happening in some NeMo workflows as well).
CC @vsl9

Hi @pzelasko, thank you for this review! Overall this looks good.
Some comments:

Let’s add Lhotse to requirements/tests.txt, and maybe add a comment about it in requirements/main.txt?
Currently the LhotseImport docstring will not show up in docs, could you please add it? I think in docs/src/sdp/api.rst is suitable
Currently there is pytest.importorskip, but maybe we should just let the test fail if Lhotse is not installed?
In future we should add a processor that can call the recipes here? https://github.com/lhotse-speech/lhotse/tree/master/lhotse/recipes

cc @vsl9 @Kipok

Thanks @erastorgueva-nv and sorry for a late reply -- I missed this message :) I'll apply your suggestions


UPDATE REQUEST

Username and Discrim: mo#9999
User ID:<PHONE_NUMBER>92815124
Image Link: https://cdn.discordapp.com/attachments/713629764597973043/782302584340873256/latest.png

Added, make sure you completely reinstall the theme as I recently redid some things.

Added, make sure you completely reinstall the theme as I recently redid some things.


Feature Request: Add Mod Memory Reporting

I'm one of those users who installs a lot of mods.  I install enough that I have to think before I install another mod, so as to avoid Terraria using too much memory.
However, aside from enabling/disabling my mods one-by-one and checking memory usage each time, the only method I have to go by is looking at the file sizes.  This is a very flawed method however, as the files (I assume) include a lot of compressed data.  As I've found, Calamity has a higher impact on memory than Sacred Tools, despite the SacredTools.tmod being nearly twice as large as CalamityMod.tmod.
So, what I'd like to see is some feature that allows tmodloader to report the memory usage of each individual mod, so that I can make a more informed decision on which mods to remove when I am trying to cut down.

The new beta already has this feature. If you like to try it then download the beta.


Improvements of the Vert.x Generator and enrichers

Important - this is more an umbrella issue for me, to track some work I would like to do in the Vert.x generator / enrichers. So it's not a bug, just features that will get implemented soon
Tasks
[ ] - Detects cluster manager from the project classpath and adds -cluster to the command
[ ] - Enable JMX metrics registration when vertx-dropwizard-metrics is in the classpath
[ ] - Allows passing parameter to the application
[ ] - If the Infinispan Cluster Manager is used, force IPv4
[ ] - Disable async DNS resolution (as it is not able to resolve names exposed by other namespaces)

One of the task is related to https://github.com/fabric8io/fabric8-maven-plugin/issues/976.

PR submitted: https://github.com/fabric8io/fabric8-maven-plugin/pull/1035


Change the mobile layout of search results accordions

Problem Description:
The search results accordions lacks cohesive mobile design.
Expected Behavior/Solution:
Implement mobile layout for search results accordions.
Requirements:

[x] Add break line between list and Show All button

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[x] Wireframe/Mockup - POW
[x] Committee discussions - Sarah
[x] Feasibility/Team discussion - Sarah
[x] ~Backend requirements - TBD~
[x] Frontend requirements - Kam
[x] Are new regression tests required for QA - Amy

No change in regression tests required

[x] ~Questions~

UAT/LUX Examples:

Andy Warhol

Dependencies/Blocks:
N/A
Related Github Issues:

#269

Related links:
N/A
Wireframe/Mockup:

Figma file 1
Figma file 2
Figma file 3
Figma file 4
Figma file 5
Figma file 6

@roamye - should this move to 12/16?

Note:
There is a ticket opened for the related materials accordion: https://github.com/project-lux/lux-frontend/issues/95, which adds the header  Concept to the left column and Related results  to the right column.
Is there a way for mobile to still show these results on one line rather than right below each other? If this is not the case, we may need to re-think how to differentiate this accordion in the mobile view as the Concept(ex; Paper) links look more as a header on mobile than desktop.

Also - if a list does not have a show more button at the bottom, is the line still useful to have? (see related materials)

none of these should impact deployment just something I noticed
@kamerynB

Approved by UAT


Swift Compiler crash when building swift-testing with cmake

Description
Following the Using CMake to build the project for macOS in CONTRIBUTING.md.
I got some compiler crash using Xcode 16.0.0's default Swift toolchain or the latest open source Swift 6.0.2 toolchain.
Expected behavior
Compile fine.
Actual behavior
Crash:
error: compile command failed due to signal 6 (use -v to see invocation)
Begin Error in Function: '$s7Testing13ConfigurationV15exitTestHandleryAA04ExitD9ArtifactsVAA0fD0VYaYbKcvpfiAfHYaYbKcfU_'
Found outside of lifetime use?!

Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.

Full log file
log.txt
Steps to reproduce
gh repo clone swiftlang/swift-testing
cd swift-testing
# export CMAKE_Swift_COMPILER='/Library/Developer/Toolchains/swift-6.0.2-RELEASE.xctoolchain/usr/bin/swiftc'
cmake -G Ninja -B build
cmake --build build

swift-testing version/commit hash
a4ed760ce69261101fefffd1abf78ea663a4a44c
Swift & OS version (output of swift --version ; uname -a)
swift-driver version: 1.115 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.10 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx15.0
Darwin Kyle-MiniMax.local 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:11 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6020 arm64
CMake version
cmake version 3.30.5
CMake suite maintained and supported by Kitware (kitware.com/cmake).

Transferred because of the compiler crash. Thanks for filing!

I was about to transfer as well and agree. Note that the -swift-version compiler flag is 6 as expected, that "effective version" is misleading.

Is there any suggested easy way to workaround it temporary? (Have tried to reset the HEAD into the 6 days ago, still not work)
I'm playing with some swift-testing patch and I'd like to verify it with the cmake build.

You could try a release/6.1 or main branch snapshot toolchain instead. Trying one of those and posting the result here might help narrow down the issue, too.

You could try a release/6.1 or main branch snapshot toolchain instead. Trying one of those and posting the result here might help narrow down the issue, too.

The issue is originally happening on the latest main branch. Tried with release/6.1 branch, it is the same crash issue.

It seems the crash has been fixed with the latest commit for swift-testing. e2ec0411e5f7407fc2d325c9feea8f0ac10a60e2


Feature request: Remove docker-compose-environment associated volumes

As well as for other containers, passing config object to stop is allowed, it'd be great to have this feature for Docker Compose environments down or stop methods. Such as
await dockerComposeEnvironment.stop({
  removeVolumes: true
});

await dockerComposeEnvironment.down({
  removeVolumes: true
});

Thanks.

Hi @gdonoso94, removing volumes isn't supported by docker-compose stop, but is in down, i'll raise a PR to support it. I'll also add the timeout so the options are the same for docker-compose as for a standard container.

Just seen that removing volumes is the default behaviour. Regardless I'm making it configurable.


Script execution error: Illegal Construction

Getting this in every browser (latest versions) and with different script extensions.

My mistake, fixed

Thank you, it's working now as intended.


Request: no fee elevation on transaction types with already "elevated" fees

With the current fee escalations on the XRPL, people are no longer getting AccountDelete transactions through: at their default 'one object reserve' Fee amount (currently 2 XRP) they are rejected because transaction queues are full.
Often even upping the fee by 50% with one extra XRP to 3 XRP will not get the AccountDelete transactions through.
I feel that, for a specific transaction with high fee like AccountDelete, fee elevation should not apply & they should go straight past the queue, as the fee is already elevated to one object ownership level to begin with.
I would very much like to see that updated in the next rippled release.

But wouldn't that create a situation where the transactions in a queue is delayed which can continue the queue's state of full since transactions with high fees (like AccountDelete) is prioritized to the next ledger?
From my understanding, this would prioritize transactions that burn high amounts of XRP but if the transaction fails to enter a queue, wouldn't it mean that there are other transactions with even higher fees?

A fee as high as one owner count (2 XRP, currently) deserves to be in front of the queue if you ask me.

Quote @mDuo13 (off-Github conversation)

I agree with you that AccountDelete is a special case and it doesn't entirely make sense to apply the Fee Escalation rules to it the same way. But, I think we need to be thoughtful about how we handle this special case, because it has the potential to be a heavy-load transaction, so we want to make sure that whatever we do with it doesn't further expose the ledger to load issues. (But, the current cost is probably actually high enough that it can't affordably be a spam mechanism.)

I think the "next rippled release" is going to be a relatively fast follow on 1.8.1 focused on bug fixes, optimizations, and stability. So, I wouldn't want to rush a new policy for AccountDelete out alongside that, unless we're confident it's the best way to handle it long-term.

AccountDelete can also remove Offers, SignerLists, and probably a few other things. That can translate to a pretty heavy load, which is one reason the fee is so high to start with.

Maybe that draws the case for account deletion not to be 'possibly' doing extraordinary amounts of work and rather require those to be done before deletion.

AccountDelete can also remove Offers, SignerLists, and probably a few other things. That can translate to a pretty heavy load, which is one reason the fee is so high to start with.

That's new information for me, I thought an AccountDelete won't execute if there are still objects owned, like SignerLists and Offers.
Also, like mwni (quote) said elsewhere:

The 2 XRP cost of closing an account should not be seen as a transaction fee, but rather an upfront cost at the time of opening the account. That's how it's been communicated. And there's possibly not one single scenario where one could do a spam attack for 2 XRP a pop

This is another her good point: it's a reserve, not a fee. Now we're 'abusing' it as a fee, by elevating it.

I agree with the logic that it's a reserve not a fee, and I can understand how end users would be frustrated when their "reserve" gets burned. Since this has been "marketed" as a reserve, maybe it makes sense to adjust the ledger behavior to be in line with the marketed expectations.
I have a difficult time envisioning account delete transactions becoming an attack/spam vector, particularly with base tx fees so low already, but many of you all are more knowledgeable about this than I am. If people are already forfeiting 2+ XRP, than it seems reasonable that the higher-fee transactions would be prioritized in the queue.

It's not a reserve. You do not get it back. It is a fee, but ideally one that is fixed and completely separate from the common transaction fee.

It's not a reserve. You do not get it back. It is a fee, but ideally one that is fixed and completely separate from the common transaction fee.

You're conflating two things: there's an account reserve--the minimum balance that one needs to maintain while the account exists--and then there's a fee to delete an account.
When I created my wallets the account reserve was much higher than it is today, and an amount of XRP equal to the reserve was treated as "unspendable" (pedantry: it's not technically unspendable; you can "spend" it in some contexts). As the reserve dropped, the amount of XRP available to me increased. If the reserve had increased, more of my XRP would be treated as "unspendable".
Before the network activated support for account deletion that was the end of it: the reserve functioned effectively as an spam-protection mechanism (which is the reason behind having an account reserve), since to create an account meant committing some amount of XRP that you could not recover.
But account deletion made it possible to delete accounts, something that Arthur Britto and David Schwartz didn't implement because they hadn't come up with a zero cost mechanism to allow that. In other words, they hand't worked out how to prevent account deletion from being used as an attack vector.
Once that was sorted, the problem became that the account reserve was no longer an effective anti-spam mechanism. Without deletable accounts, the attacker could still create 50,000,000 accounts but would have to commit 1,000,000,000 XRP to do so. But with a fully recoverable reserve, coupled with a cost of 12 drops per tx, would mean that creating and destroying 50,000,000 accounts would cost the attacker around 1,200 XRP.
So deleting an account needed to impose a cost; not large enough to make deletion meaningless, but large enough to discourage abuse.
The easiest way to do that was to make the AccountDelete account expensive: the most reasonable approach, at the time, seemed to be to simply make the transaction cost some "fixed" network-controlled value; I picked one incremental reserve.
If we want to reframe this as a fixed "up-front" cost, then that's one thing, but then you're just shifting it away from the AccountDelete transaction to the Payment transaction. And how would you implement it there? Would you make a payment for 100 XRP but only 98 would be delivered? That's a support nightmare. Or would you charge it as a fee? If so, what's the difference in charging it for the Payment instead of the AccountDelete?
Also, note that using the fee logic is convenient because it already has the "burn" logic built into it. Any changes will require updating invariant checkers, and transaction analysis tools and everything else.
I think that talking about this is great and maybe we can come up with something better than what I originally came up with--God knows I don't have a monopoly on good, or for that matter, bad ideas--but I do think that the existing system is elegant. Not without it's flaws, to be sure. But elegant nonetheless.

@nbougalis Thank you for shining light on the history of the matter. This is very valuable information. I want to clarify, by it I meant the irrecoverable portion of the reserve. And the "up front" statement was about how it is being perceived, not how it should be implemented. I actually think it's excellent the way it is, aside from the fact that the scaling factor applies to it aswell.

this has been "marketed" as a reserve, maybe it makes sense to adjust the ledger behavior to be in line with the marketed expectations.
~ crypticrabitt

I agree on this part of the argument, the problem is, it's a normal transaction just like any other transaction on a full queue.
I also see the reserve as a fee, from my understanding, the xrpl treats it as a fee but since it is being marketed as a reserve, what if we just ignore transactions with elevated fees (like AccountDelete) in the Fee Elevation mechanism, so that other queued transactions are not effected by transactions with elevated fees (2 XRP as of now).


Fix Kubernetes deployment model using spec.selector.match_labels to locate itself

Another great catch here.
Definitely just got lucky off of naming conventions but this was just totally wrong. Maybe we need some fuzzing for some of this shit?


Add warning about potentially-missing no-bundler feature

I'm still not sure about this one, because it adds extra string that is only needed for debugging one specific scenario, but will remain in all production builds using bundlers too... I guess I'll keep it open and see if more people run into the same issue.


chore(appveyor): add in node 4 for appveyor

This just adds node 4 into the mix for appveyor unit testing (based off the config from cash)

LGTM (since this is a fairly safe change, I'm just going to merge)


Tar archiving of huge data

I want to use sharpcompress to create huge tar archives (TBs) without compression but I can't do it by next reasons:

There is no async interface for TarWriter. Is it by design?
There is no interface to write buffer. Yes, I can create another stream class to gather data but there is overhead to convert buffer (that I already have) into stream just to unwrap it into buffer inside sharpcompress.
Actually TarHeader class will be enough for me but by some reason it is internal. Why?

Is there any chance that some of these issues will be resolved?

You could capture the task and thus solve your first problem. See my solution here:
https://github.com/turbolocust/SimpleZIP/blob/master/SimpleZIP_UI/Application/Util/WriterUtils.cs
It can also be done without a child or nested task, but the immediate cancellation of the whole operation isn't as reliable then.

Making everything async is kind of just a matter of search/replace.  I’m not 100% there’s benefit but I love async/await so hey.

2). I’m not 100% sure what you’re asking for here
3)Not sure how this helps.
I don’t honestly see what’s blocking the creation of large tar files.  Maybe a code sample will help.

One of issues with archiving huge amount of data is resuming of process (due to instance reboot, IO failure, etc). At this moment I have next issues with sharpcompress:

On Dispose TarWriter will "close" archive with double call of PadTo512(0, true);
Providing sync stream to TarWriter means that I should block on all async operations in stream.
In my API I have buffer pool with 4MB arrays. So to transfer 1GB need 262 buffers. But in real life used about 10-30 buffers (they just reused when don't need anymore). But sharpcompress will allocate additionally 13K buffers of 80KB each.

If TarHeader class will be available outside of library then it is pretty easy to implemenet resume logic - if written data length more then header size - just skip header and some part of content. Otherwise serialize header and skip part of it's content.

Now using ArrayPool for Skip/Transfer: https://github.com/adamhathcock/sharpcompress/pull/326
This should help for 3

Fix for 1: https://github.com/adamhathcock/sharpcompress/pull/327
I felt like I did it for a reason though

I would like to make it async all the but that's a bigger PR.


Wait group should add before the goroutine creating

The calls to Add should execute before the statement creating the
goroutine or other event to be waited for.
Signed-off-by: kun<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling 9b6e8800b48b9fafced7c002965c5783831e350c on oiooj:pr-wg into b1d39bb4f15ea207aabe775e7a950993dbb7e84c on jaegertracing:master.

Thanks!


why do you have this " 'worker' => new ObjectId()" when a new job is added

Could you explain, please what is the meaning to have this:
mongodb-php-task-scheduler/src/Scheduler.php/prepareInsert method
$document = [
..
'worker' => new ObjectId(),
...
];
I added a job and the job has this in the DB:
{ "_id" : ObjectId("5c7d99dd3b775021615e86e3"), "class" : "Mail\MailJob", "status" : 0, "created" : ISODate("2019-03-04T21:34:17.684Z"), "started" : ISODate("2019-03-04T21:34:17.684Z"), "ended" : ISODate("2019-03-04T21:34:17.684Z"), "worker" : ObjectId("5c7d99d93b775021615e86e2"), "data" : "Date: Mon, 04 Mar 2019 21:34:17 +0000\r\nSubject: Hello...\r\nFrom: root root@localhost\r\n\r\nWorld", "options" : { "at" : 0, "interval" : 0, "retry" : 0, "retry_interval" : 300, "force_spawn" : false, "timeout" : 0, "priority" : 60, "ignore_data" : false } }
There are no running workers yet.  What is ObjectId("5c7d99d93b775021615e86e2")???

Could you explain, please what is the meaning to have this:
mongodb-php-task-scheduler/src/Scheduler.php/prepareInsert method
$document = [
..
'worker' => new ObjectId(),

From the simple fact that one can not change the size of records within a capped collection. See https://docs.mongodb.com/manual/core/capped-collections/#document-size
Therefore the initial job gets initialized with a random objectId for a worker.
As soon as the job gets executed by a worker, the worker will change the worker id in the job.


[FIX] Remove outdated NUMPY_MMAP calls when loading image

Changes proposed in this pull request
This pull request removes the outdated NUMPY_MMAP import from nipype (ref. issue #172).

Renamed the name of the branch and made a new PR (#175).


add develop template

Hello @phalanx-hk! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/test_sample.py:

Line 14:80: E501 line too long (85 > 79 characters)
Line 16:80: E501 line too long (85 > 79 characters)


chore: rename disruption taint

Fixes #N/A
Description
Replaces the disruption taint as per https://github.com/kubernetes-sigs/karpenter/pull/1222.
karpenter.sh/disruption=disrupting:NoSchedule -> karpenter.sh/disrupted:NoSchedule
When the taint is removed by the orchestration queue or disruption controller, we'll also remove the v1beta1 equivalent version of the taint. This ensures we don't leave nodes tainted if Karpenter is upgraded after they've been disrupted but before they've been terminated.
How was this change tested?
make presubmit and validation against the AWS provider (TODO)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

6 of 12 (50.0%)  changed or added relevant lines in 5 files are covered.
15 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.1%) to 78.007%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/node/termination/controller.go
1
2
50.0%

pkg/controllers/state/statenode.go
3
4
75.0%

pkg/controllers/provisioning/controller.go
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/state/statenode.go
1
84.26%

pkg/controllers/node/termination/controller.go
1
62.4%

pkg/scheduling/requirements.go
2
98.01%

pkg/test/expectations/expectations.go
4
94.25%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

Totals

Change from base Build<PHONE_NUMBER>3:
-0.1%

Covered Lines:
8821

Relevant Lines:
11308

💛  - Coveralls


Implement Open Food Facts contribution signup inside Smoothie

What

[ ] Implement user registration inside Smoothie

[ ] Leverage the support in openfoodfacts-dart

[ ] https://github.com/openfoodfacts/openfoodfacts-dart/blob/master/DOCUMENTATION.md#register-a-new-user
[ ] https://github.com/openfoodfacts/openfoodfacts-dart/blob/f7b254e80a339c37ce85a1ad7d9f8bc9978be9d8/lib/openfoodfacts.dart#L713

[ ] Here's the visual/code reference the Android signup PR: https://github.com/openfoodfacts/openfoodfacts-androidapp/pull/3737

Part of

#419

@monsieurtanuki would you be interested by this one ? There's some pre-existing Android code and logic to steal from.

@teolemon Working on it...

Virtually done.
But I tried to put trash data, and the only thing I got is a rather discrete

status=400
error=Unrecognized request error

We'll definitely need more explicit messages. By the way there's no language parameter in OpenFoodAPIClient.register.
In the meanwhile, @teolemon could you point me to some existing pre-validation code before the actual call to register?

Ok @teolemon I had a look at your OP links. I don't speak kotlin but I think I can handle this.
Screenshot:


Support GenericFastAdapter for Drag n drop, filtering

I was trying implement a RV with multiple view types ex: MultiModelItemActivity where there items are separated by headers (2 view types: header view, item view). I want to allow drag and drop items under different headers and support filtering of items through search
Currently

DragDropUtil.onMove() accept an ItemAdapter so cannot be used with GenericFastAdapter
GenericFastAdapter does not support filtering

Is there any way to achieve what I want ?

@kaushalyap the sample also has an itemAdapter: https://github.com/mikepenz/FastAdapter/blob/develop/app/src/main/java/com/mikepenz/fastadapter/app/MultiTypeModelItemActivity.kt#L39
The FastAdapter is the managing element. the ItemAdapter is the specific implementation which knows how to work with items. where they are located and so on.

So its possible. Thanks

@mikepenz DragDropUtil.onMove() not still compatible since it cannot accept a ModelAdapter

Look at its code: https://github.com/mikepenz/FastAdapter/blob/develop/library-extensions-utils/src/main/java/com/mikepenz/fastadapter/utils/DragDropUtil.kt it is super straight forward. and you might simply want to bring it into your project for the time being. will check to change the accepted adapter type to be ModelAdapter in the future

@mikepenz about to submit a PR. It's a small change anyways

Yes I am using Drag util, but how could I change the accepted parameter type?

@kaushalyap you copy it to your project and make it accept the IItemAdapter until a new release is available with the change from @AllanWang

Okay thanks!


Android plays sounds when screen is off/locked

Bug report

Summary
We have some life-cycle sounds that are triggered with Player#play() automatically. I've found that if a user a user opens the app and then locks the screen, if a life-cycle sound occurs with their screen off/locked, the sound still fires. Obviously this happens in Android only, since iOS naturally prohibits sounds from being triggered in this state.
After perusing the docs there doesn't seem to be a straight-forward setting to disable this behavior.
Environment info

react-native info output:
  React Native Environment Info:
    System:
      OS: macOS 10.15.5
      CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
      Memory: 1.92 GB / 16.00 GB
      Shell: 5.7.1 - /bin/zsh
    Binaries:
      Node: 12.18.3 - /var/folders/4q/95v7ctsj40b6_dks5cc9jz0m0000gp/T/yarn--1597676850639-0.9726677800039152/node
      Yarn: 1.22.4 - /var/folders/4q/95v7ctsj40b6_dks5cc9jz0m0000gp/T/yarn--1597676850639-0.9726677800039152/yarn
      npm: 6.14.6 - ~/.nvm/versions/node/v12.18.3/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
      Android SDK:
        API Levels: 28, 29
        Build Tools: 28.0.3, 29.0.2, 29.0.3, 30.0.1
        System Images: android-28 | Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom
    IDEs:
      Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
      Xcode: 11.6/11E708 - /usr/bin/xcodebuild
    npmPackages:
      react: ^16.8.4 => 16.12.0
      react-native: 0.59.10 => 0.59.10

Library version<EMAIL_ADDRESS>Steps to reproduce

Set up an app using the library
In your root component delay the playing of a sound for 10 second (or whatever)
Launch your app on Android
Once loaded hit the power button on the Android device, so that the screen is off
Wait the remainder of the 10 second duration
Hear the sound play

Describe what you expected to happen:
Naturally, for step 6, the sound should not play.
Reproducible sample code
function App() {
  const player = Player.new('https://example.com/sound.mp3');

  useEffect(() => {
    const timeout = setTimeout(() => {
      player.play();
    }, 10000);

    return () => { clearTimeout(timeout) }
  }, []);

  ...
}

Has anyone else noticed this behavior?


Update jawn to 0.10.4

Current coverage is 81.54% (diff: 100%)

Merging #449 into master will not change coverage

@@             master       #449   diff @@
==========================================
  Files            80         80
  Lines          2135       2135
  Methods        2043       2043
  Messages          0          0
  Branches         92         92
==========================================
  Hits           1741       1741
  Misses          394        394
  Partials          0          0

Powered by Codecov. Last update eb6cdcd...f9fedef


fix: Doc/07-LuaFunctions_*.md small style problem again.

Doc//07-LuaFunctions_ja.md: fix style again
Oops, I lost other style problem...

Thank you !
I merged.


How to certify as approved for use with Continuous Availability on NetApp Azure Files

Hi, I'm posting to ask about getting other solutions aside from MS SQL and FSlogix certified, supported and listed on the referenced page for use on NetApp Azure files.  I'm happy to post some details here or contact someone directly.
One example is ProfileDisk from Liquidware : https://www.liquidware.com/products/profileunity/profiledisk
That uses attached VHDX files in the same way that FSlogix containers do.
Thanks in advance!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc5f53d2-1808-428e-acd2-3c0dd63be3c6
Version Independent ID: 8f37b6eb-c9c0-ba3f-e75f-1748b54bf3b7
Content: Enable Continuous Availability on existing Azure NetApp Files SMB volumes
Content Source: articles/azure-netapp-files/enable-continuous-availability-existing-SMB.md
Service: azure-netapp-files
GitHub Login: @b-hchen
Microsoft Alias: anfdocs

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

@unixpunk - Thanks for reaching out!  I'll consult our product team and get back to you.

@unixpunk - Can you reach out to me via email<EMAIL_ADDRESS>or<EMAIL_ADDRESS>for further discussion?  Our product team indicated that (some of) the mentioned solutions are known requests but require certification.  Thanks.

Will do, thanks!


@apply is becoming available in Chrome

As of this writing (April 8, 2016), the feature is very new and has not yet landed in Google Chrome or even Chrome Canary, but it is available behind a flag in the latest Chromium nightly.
http://zeke.sikelianos.com/css-from-the-future/

Perhaps it is time to re-phrase the README and check that postcss-apply follow the spec.

Toying around an interesting idea, not really a spec yet ?

Ohh, just found your comment in https://github.com/MoOx/postcss-cssnext/issues/203#issuecomment-208735885

Hi,
postcss-apply follow the "spec" as much as possible from its very first version, and will stay on that path. But once again, I think it's not really a spec yet.
Anyway, I'll rephrase that sentence, it's not really appealing.

Yes, please please stay on the draft spec path!

@pascalduez very good to know. I'm considering adding postcss-apply to our front end pipe line and knowing that this might be a standard is very appealing.


feat: added card component

References https://autoricardo.atlassian.net/browse/DM-155
Component - figma: https://www.figma.com/file/8vy6tgk0DV9KSKyJBjiLSH/AS24-Web-Patterns?node-id=5%3A6707
Motivation and context
Extract card component
Before
No card component 🥺
After
Card component 🤩

How to test
Please check that the design is correct on the corresponding breakpoints and play around with the text. Now you can test it with the branch deployment wuuuuuuiiii.
Thank you 🌮

Oh, there's one more thing that just came to my mind. Do we want to tackle the placeholder image in the components package to have it contained? that would mean that the image prop would be optional and we would render the placeholder if the image is not passed. WDYT?

Oh, there's one more thing that just came to my mind. Do we want to tackle the placeholder image in the components package to have it contained? that would mean that the image prop would be optional and we would render the placeholder if the image is not passed. WDYT?

Lovely feedback!
Yes, we could do it here. I just need to sync with Enrique about the design on mobile/desktop and then I can implement it. Thank you! 🌸


Dev Mode: Warn about missing defaults for unconfigured settings

I have this setting update.enableWindowsBackgroundUpdates:
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/update/electron-browser/update.contribution.ts#L62
When the user doesn't configure it, reading this value from the configuration service should return the default value. This works from the renderer process. It doesn't from the main process. Instead of getting the default false value, I get undefined.
Maybe regression?

I think, the contribution happens on the renderer side and not on main side. Hence you see undefined.

Yes, I forgot that contributions are only required from the renderer side.
For my specific fix, I split my contributions into two: configuration (down in platform) and others (up in workbench).
But it took me way too long to figure this one out. I just wasn't expecting the config service not to have defaults. It would be great to have warnings when accessing unset configuration values, for which no default was ever specified.

One way to do is while accessing the value, check if the requested setting is registered or not. Obviously this should be done only in dev mode to not impact perf. But one problem is that at present, there are quite number of such unregistered settings that components are accessing. Hence, I think it is not worth doing this.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!


subscriber: consider making with_default_env the default

do we really need an explicit with_default_env? would it be better to just have Builder::default() read the default env variables if they're set? i could be convinced either way on that one.
Originally posted by @hawkw in https://github.com/tokio-rs/console/pull/195#pullrequestreview-833252597

cc @pnkfelix @seanmonstar what do you think about this? if we're going to change it, it might be good to do before 0.1 so we don't have to immediately deprecate with_default_env...

I have a slight bias to leaving things the way they are, because I'm not confident that it is a good idea to have no way to turn off the code path that accesses the environment variables...

Cool, let's not change this, then.


Fix to work with strict_variables=true

If selinux is disabled, the $::selinux_current_mode variable is undefined and throws an error when run with strict_variables=true
Getting the value with getvar fixes this.

Cool! Thanks for the code.


In discrete image based car, bird, snake termination issue is present

Some times during initialization if agent doesn't find the goal for long time. it terminates by default (for all further episodes ) at some boundary instead of moving towards the goal

Example below


Does the CrawlLinks Shortest Path functionality exclusively support English filenames?

I use the Shortest style link in Obsidian.
When I input in the Korean, the path under the folder is not parsed.
Just in case, I tried changing both the file name and link to English, and it worked properly.
Is it correct that file names in a different language are not supported?

Click English filename shortese link (Parsed well)

Click Korean shortest link (Can't parse dir path)

Sorry. I just deploy with netlify, It's working well!
Why is it that the functionality does not operate as intended locally?


Render following pages, when only first has a background.

Added pisaBackground to pisaBackgroundList, even if it’s None.
xhtml2pdf/document.py:140 generates page for every item in context.pisaBackgroundList.
When a template has a background only on the first page, the following pages have pisaBackground of None, but they also should get rendered.
See issue #426

Coverage increased (+0.7%) to 53.527% when pulling 12582fd78d04d4f90fb2570d06934adf231fc1c6 on KaczuH:issue-426 into 689f30d68a9b860f022c5feb21599b8ff842f608 on xhtml2pdf:master.


Pandas and h5py load the same data (ndarray) differently: hvl_t support.

Based off this question. In fact more or less copied and pasted :)
I have a file in HDF5 format.  It was created using the HDF5's C++ API using these:
    struct SignalDefH5
    {
        char  id   [128];
        char  name [ 64];
        char  units[ 16];
        float min;
        float max;
        hvl_t tags; /* This right there does not work in Pandas... */
    };

    struct TagDefH5
    {
        char  tag [ 64];
        char  desc[256];
    };

Note that tags is supposed to be a list of strings. If I load the file using h5py, I get this:
    >>> import h5py
    >>> hfile = h5py.File('test.h5', 'r')
    >>> signals = hfile['/signals']
    >>> signals[0]
    ('id1', 'a pressure', 'bar', 0.0, 300.0, ['Pressure'])
    >>> type(signals[0][5])
    numpy.ndarray

However, if I use Pandas to load the same file, I get this:
    >>> store = pd.HDFStore('test.h5')
    >>> store.root.signals
    /signals (Table(179,)) ''
      description := {
      "id": StringCol(itemsize=128, shape=(), dflt='', pos=0),
      "name": StringCol(itemsize=64, shape=(), dflt='', pos=1),
      "units": StringCol(itemsize=16, shape=(), dflt='', pos=2),
      "min": Float32Col(shape=(), dflt=0.0, pos=3),
      "max": Float32Col(shape=(), dflt=0.0, pos=4),
      "tags": StringCol(itemsize=64, shape=(), dflt='', pos=5)}
      byteorder := 'little'
      chunkshape := (234,)
    >>> store.root.signals[0]
    ('id1', 'a pressure', 'bar', 0.0, 300.0, '\x02\x00\x00\x00\x00\x00\x00\x00\xf0f\x1e\x04\x00\x00\x00\x00\xba\nVT\xd1!\xa7\xdd\xb0\xe3\x9a\x02\x00\x00\x00\x00@\xecR\x1f\xa2\x7f\x00\x00}B\x178\x96\xa4u\xe6\xb0\xdd\x7f\x02\x00\x00\x00\x00 \x01')
    >>> type(store.root.signals[0][5])
    numpy.string_

So, Pandas cannot cope with this type yet it would be nice if it could... I am quit happy to test any patch and help in as much as I can.
 (That's the library pandas uses to handle HDF5.)
I think your question reflects some confusion about the purpose of HDF5 support in pandas. HDF5 is an extremely flexible file format, so mapping every HDF5 file onto native pandas data structures is hopeless. Instead, pandas uses HDF5 for a custom binary serialization format (one still readable by other tools). If you want to read/write arbitrary HDF5, you should probably stick to h5py, and write your own helper functions for reading and writing dataframes.

I can map it using hd5py, as shown above. I have just tried with pytables and it does not work. Should I report it as a bug there instead of here?

@kierun as I explained in the SO answer, this is not implemented in PyTables AFAIK. You can use h5py, read it, and then try to map to a pandas structure (though it doesn't look like it would nicely map).
PyTables implements a sub-set of HDF5 with a pythonic interface; h5py is a much more strict c-API translation.
This is not a bug; rather you are expecting arbitrary structure support which does not exist.

I am really struggling to understand why a list of string is an "arbitrary structure".  We have string in Python and in PyTables as entities. We have arrays/lists. So, how come we cannot have an array/list of strings?
Maybe it's the C++ side fault for using something weird, but in that case there should be a way to change that, should there not?
I am really not trying to be a pain, but I just don't get it how a collection of base types is not support.

@kierun its not a 'list-of-strings', rather a sub-node (I think) of 2 other items. If you put them in the main table this might work. I don't know.

@jberka And now I get it... Looking back at the C++ code, it writes a  H5::VarLenType which indeed is an arbitrary structure.  Thank you very much for your patience. ^_~


[M02] Incorrect token initialization data

Incorrect token initialization data
In PR #8831, the migrationsConfig.js file is updated to include initialization data for the deployment of the StableTokenBRL.
This initialization data is incorrectly set to be a copy of the StableTokenEUR initialization data. Specifically the tokenName and tokenSymbol are set incorrectly to Celo Euro and cEUR.
This incorrect token initialization will not affect the inner logic and accounting of the token itself. However, this mislabelling can cause errors in indexing this token in exchanges, and will likely confuse users which can greatly affect its utility and adoption.
Consider updating the migrationsConfig.js to have appropriate tokenName and tokenSymbol set specific to the StableTokenBRL.
Part of the OpenZeppelin Release 6 Audit: @georgercarder @clarkhenry

As a clarification, wanted to point out that file is only used for testing proposals and not for mainnet (not even testnets).


skipped index: bloom fiter not working

(you don't have to strictly follow this form)
Bug Report
when i use bloom type skip index, find it did not work, and will trigger full table scan
Briefly describe the bug
the skipped index not working, and system.mutations is empty;

The result you expected
the skipped index should working.
How to Reproduce

create a table test, include eventId field(string type);

add skip index;
ALTER TABLE  event_result ADD INDEX eventId_index(eventId) TYPE bloom_filter(0.0001) GRANULARITY 1;
ALTER TABLE event_result  MATERIALIZE INDEX eventId_index;

query by skip index
select eventId from test where eventId in ("aaaa")

Version
https://github.com/ByConity/byconity-deploy,  config with s3 as storage
i try byconity:stable is not working

Hi @datavisorhenryzhao thank you for reporting the issue, @hustnn please help to look into this issue

I think it is already fixed in our recent release, can you trying 0.2.1?


Update README to use version 2.1 of validation scripts

Let's update this to use the new tag that @jprinet will create before merging.


Updated the README.md

Description
I tried to add more clarity with sentences adding some grammatical enhancements and so on.

Closes #12342

Types of changes

[X] Documentation
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (anything that would change an existing functionality)
[ ] Maintenance (refactor, code cleaning, development tools...)

Checklist

[X] I have read and follow the CONTRIBUTING.md document.
[X] The pull request title and template are correctly filled.
[X] The pull request targets the right branch (develop or develop-v...).
[X] My commits are correctly titled and contain all relevant information.
[X] I have updated the documentation accordingly to my changes (if relevant).
[ ] I have added tests to cover my changes (if relevant).

The suggested changes do not make it better imho.


Update web.magentatv.de.config.js & osn.com.config.js

Fixes #2367
Fixes #2358
Fixes #2282

As for web.magenta.de https://api.prod.sngtv.magentatv.de/EPG/JSON/Login?&T=Windows_firefox_127 can give the best EPG server available for your host.
{"enctytoken":"*random*","encryptiontype":"0002","platformcode":"0200","epgurl":"http://api.prod.sngtv.magentatv.de:33220","version":"MEM V200R008C18SPC806B002","epghttpsurl":"https://api.prod.sngtv.magentatv.de:33227","rootCerAddr":"http://api.prod.sngtv.magentatv.de:33220/EPG/CA/iptv_ca.der","upgAddr4IPTV":"https://slbedifk11100.prod.sngtv.t-online.de:33428/EDS/jsp/upgrade.jsp","upgAddr4OTT":"https://slbedmfk11100.prod.sngtv.t-online.de:33428/EDS/jsp/upgrade.jsp,https://slbedmfk11100.prod.sngtv.t-online.de:33428/EDS/jsp/upgrade.jsp","EPGDomainNameList":[{"key":"2","value":"appepmfk10045.prod.sngtv.t-online.de"},{"key":"3","value":"<IP_ADDRESS>"},{"key":"4","value":"<IP_ADDRESS>"},{"key":"5","value":"<IP_ADDRESS>"},{"key":"6","value":"<IP_ADDRESS>"},{"key":"7","value":"<IP_ADDRESS>"}],"sam3Para":[{"key":"SAM3ServiceURL","value":"https://accounts.login.idm.telekom.com"},{"key":"OAuthScope","value":"ngtvepg"}]}
On EPGDomainNameList, you have 2 diff domains.
AUTH is
https://api.prod.sngtv.magentatv.de/EPG/JSON/Authenticate?SID=firstup&T=Windows_firefox_127 with {"terminalid":"00:00:00:00:00:00","mac":"00:00:00:00:00:00","terminaltype":"WEBTV","utcEnable":1,"timezone":"Africa/Ceuta","userType":3,"terminalvendor":"Unknown","preSharedKeyID":"PC01P00002","cnonce":"753adeceff416ad53da6be620722bc65"}
https://api.prod.sngtv.magentatv.de/EPG/JSON/AllChannel?SID=first&T=Windows_firefox_127 gives all channels.

Test failed:
npm test -- osn.com

> test
> run-script-os osn.com

> test:default
> TZ=Pacific/Nauru npx jest --runInBand osn.com

 FAIL  sites/osn.com/osn.com.test.js
  ✕ can generate valid request headers (10 ms)
  ✓ can generate valid url (3 ms)
  ✓ can parse response (ar) (140 ms)
  ✓ can parse response (en) (1 ms)
  ✓ can handle empty guide

  ● can generate valid request headers

    expect(received).toMatchObject(expected)

    - Expected  - 1
    + Received  + 1

      Object {
    -   "Referer": "https://www.osn.com/ar-ae/watch/tv-schedule",
    +   "Referer": "https://www.osn.com/ar-sa/watch/tv-schedule",
      }

      14 | it('can generate valid request headers', () => {
      15 |   const result = request.headers({ channel: channelAR, date })
    > 16 |   expect(result).toMatchObject({
         |                  ^
      17 |     Referer: 'https://www.osn.com/ar-ae/watch/tv-schedule'
      18 |   })
      19 | })

      at Object.<anonymous> (sites/osn.com/osn.com.test.js:16:18)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 4 passed, 5 total
Snapshots:   0 total
Time:        3.777 s
Ran all test suites matching /osn.com/i.

Your test is concerning osn.com, not magentatv.de

Will take a check a bit later, just to make sure I have no issues as well on my side. Though Arhey having an quack on the OSN configuration makes me think we'll have to take a look soon

Your test is concerning osn.com, not magentatv.de

The initial PR was for osn and magenta.
osn needs more work, it has been removed from this PR.

PopeyeTheSai10r changed the title ~Update web.magentatv.de.config.js & osn.com.config.js~ Update web.magentatv.de.config.js


[1.20.1] Xray failure

The bug occurs without having Optifine or Optifabric installed? (Optifine bugs won't be fixed)

[X] Yes, I don't have Optifine install.

Mod version
2.3.1
Minecraft version
1.20.1
Mod loader
Fabric
Description of the issue
The mod will not make blocks invisible or reveal covered blocks.
Excepted behavior
I expected to see a transparent ground where blocks within it are revealed.
Obtained behavior
The brightness increased but the terrain did not become invisible and i couldn't see covered blocks in freecam.
How to reproduce
Install Xray-Mod-2.3.1 with Fabulously Optimized 5.3.0-Beta2 on the Fabric mod loader.
Launch the game.
Load a world in singleplayer or on multiplayer.
Toggle the default xray preset.
Observe.
Apply the Xray Ultimate resource pack.
Observe.
Do I want to contribute to fix it?
Maybe
Something else?
This seems to be a recurring issue.

can confirm this does not work on 1.20.1


wrong times in pprof fields

https://github.com/grafana/pyroscope-rs/pull/134

fixed in https://github.com/grafana/pyroscope-rs/pull/155


fix UUID serialization issue at login_user

Currently if you use the UUID field for the user primary key then while logging in you get the traceback
UUID('85410f5f-ec82-4148-ba78-5be5a79f0fb1') is not JSON serializable
This happens because:
https://github.com/arteria/django-hijack/blob/master/hijack/helpers.py#L117
Once the session serializer finds a UUID field it fails.
The problem is also described here:
https://code.djangoproject.com/ticket/24161
The fix is also from Djangos current code:
https://github.com/timgraham/django/blob/0f7f5bc9e7a94ab91c2b3db29ef7cf000eff593f/django/contrib/auth/__init__.py#L111

Thanks @madisvain  for you  PR! The changed will be available in v 1.0.10.  Will push to PyPI soon.


Add FAQ for "Can managed and unmanaged disks colocate on a single VM?"

Some customers asking "can we co-locate managed and unmanaged disks on the same VM?" and the answer is no.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 263abdef-3478-8261-6c4c-5d608698ba4e
Version Independent ID: 61ef3094-fda7-d7b9-e19c-4e8f6a5b2f2d
Content: Frequently asked questions (FAQ) about Azure IaaS Windows VM disks
Content Source: articles/virtual-machines/windows/faq-for-disks.md
Service: virtual-machines-windows
GitHub Login: @roygara
Microsoft Alias: rogarana

@TeppeiIshii
Thanks for the feedback! We are currently investigating and will update you shortly.

@roygara could you take a look at this as a possible enhancement to the documentation?


Hudi Multi Writer DynamoDBBasedLocking issue

Hi,
This is the first time we are setting up hudi with Multi writer,
Below are my hudi config properties, I have set up
HoodieWriteConfig.WRITE_CONCURRENCY_MODE.key()->"optimistic_concurrency_control",
HoodieCompactionConfig.FAILED_WRITES_CLEANER_POLICY.key()->"LAZY",
HoodieLockConfig.LOCK_ACQUIRE_NUM_RETRIES.key()->"3000",
HoodieLockConfig.LOCK_ACQUIRE_CLIENT_NUM_RETRIES.key()->"1",
HoodieLockConfig.LOCK_PROVIDER_CLASS_NAME.key()->"org.apache.hudi.aws.transaction.lock.DynamoDBBasedLockProvider",
DynamoDbBasedLockConfig.DYNAMODB_LOCK_TABLE_NAME.key()->"hoodi_lock",
DynamoDbBasedLockConfig.DYNAMODB_LOCK_PARTITION_KEY.key()->"lock",
DynamoDbBasedLockConfig.DYNAMODB_LOCK_REGION.key()->"us-east-1",
HoodieAWSConfig.AWS_ACCESS_KEY.key()->"XXX",
HoodieAWSConfig.AWS_SECRET_KEY.key()->"XXX",
HoodieAWSConfig.AWS_SESSION_TOKEN.key()->"XXXX",
DynamoDbBasedLockConfig.DYNAMODB_ENDPOINT_URL.key()->  RegionUtils.getRegion("us-east-1").getServiceEndpoint(AmazonDynamoDB.ENDPOINT_PREFIX) //"dynamodb.us-east-1.amazonaws.com"
I have created dynamodb table which will be used for locking, and partition key as lock
Below are my questions,
Is it mandatory to set AWS_ACCESS_KEY,AWS_SECRET_KEY ?  - I dont want to set these keys
Should we need to create Dynamodb table or Hudi will create it automatically? we create AWS resources with Cloudformation
I am getting below exception while connecting to dynamodb table
com.amazonaws.services.dynamodbv2.model.AmazonDynamoDBException: The provided key element does not match the schema
Dynamodb table is created with partition key lock(String)

@zhedoubushishi
@nsivabalan
Please help me here

Is it mandatory to set AWS_ACCESS_KEY,AWS_SECRET_KEY ?

No you should not need to. in aws env you'll just rely on whatever roles for your service to access another service. Please raise support case with aws and get help to configure roles properly.

@koochiswathiTR Thanks for raising this!  The config naming of partition_key is confusing to new comers.  Here's what you need to do:
(1) As @xushiyan already mentioned, you don't need to set the credentials in env variables if the instance or service is already granted access with the proper roles;
(2) By default, hoodie.write.lock.dynamodb.partition_key is set to the table name, so that multiple writers writing to the same table share the same lock.  If you customize the name, make sure it's the same for multiple writers;
(3) Note that, what hoodie.write.lock.dynamodb.partition_key specifies actually means the value to use for the column, and not the column name itself.  The column name is fixed to be key in DynamoDB table;
(4) The DynamoDB table for locking purposes is automatically created from the Hudi code, so you don't have to create the table yourself.  If you do so, make sure that the key column is present in the table, not lock or the value specified by hoodie.write.lock.dynamodb.partition_key.
Let me know if this solves your problem.  Feel free to close it once all good.

we have improved our docs around this
When using the DynamoDB-based lock provider, the name of the DynamoDB table acting as the lock table for Hudi is specified by the config hoodie.write.lock.dynamodb.table. This DynamoDB table is automatically created by Hudi, so you don't have to create the table yourself. If you want to use an existing DynamoDB table, make sure that an attribute with the name key is present in the table. The key attribute should be the partition key of the DynamoDB table. The config hoodie.write.lock.dynamodb.partition_key specifies the value to put for the key attribute (not the attribute name), which is used for the lock on the same table. By default, hoodie.write.lock.dynamodb.partition_key is set to the table name, so that multiple writers writing to the same table share the same lock. If you customize the name, make sure it's the same across multiple writers.
https://hudi.apache.org/docs/concurrency_control
Hope this answers your question.
Feel free to re-open or raise a new issue if you need more assistance.


Save the book data in a GitHub Actions cache

This should make it slightly easier to test/deploy changes to the rendering code, because all the books data will be cached between runs.

This is something that can only really be tested on main, so merging as-is – but I wanted the PR as a little milestone marker.


Height calculation when using SSR is wonky

First render after hydrating an SSR rendered view has a seemingly random height. After the first swipe the height recalculates to the correct height.

Similar issue here. I have a SwipeableViews with animateHeight={true} and tabs. My initial tab gets cut off on the bottom before the first swipe (consistently within tab, randomly between tabs). After the first swipe the height is correctly recalculated.

I think you're missing the part where this is an SSR issue.
Client side rendering works.

@qbitza SSR rendering is disabled with animateHeight

Hum, maybe it doesn't have to be this way. Anyway, I do no longer maintain this library, all my firepower is targeted at Material-UI. Feel free to work on it.

A pity, as we really would have loved to use this component.

@qbitza The library is already pretty stable. Just have to find someone else to keep pushing it.