App Crashes with Fatal signal 6 SIGABRT on Android, works fine on iOS

Device
Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)
Run Log
Launching lib/main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...
Resolving dependencies...
Running Gradle task 'assembleDebug'...
Built build/app/outputs/apk/debug/app-debug.apk.
D/EGL_emulation( 5811): eglMakeCurrent: 0xd788c600: ver 3 0 (tinfo 0xbea08740)
D/eglCodecCommon( 5811): setVertexArrayObject: set vao to 0 (0) 1 0
I/OpenGLRenderer( 5811): Davey! duration=880ms; Flags=1, IntendedVsync=147055416692, Vsync=147055416692, OldestInputEvent=9223372036854775807, NewestInputEvent=0, HandleInputStart=147063080756, AnimationStart=147063103561, PerformTraversalsStart=147063106099, DrawStart=147747192191, SyncQueued=147748305438, SyncStart=147750795069, IssueDrawCommandsStart=147751505231, SwapBuffers=147816177519, FrameCompleted=147938750711, DequeueBufferDuration=11437000, QueueBufferDuration=183000,
I/Choreographer( 5811): Skipped 52 frames!  The application may be doing too much work on its main thread.
Syncing files to device Android SDK built for x86...
I/pawfect.pawfec( 5811): Background young concurrent copying GC freed 90128(9721KB) AllocSpace objects, 41(1508KB) LOS objects, 71% free, 2442KB/8586KB, paused 48.561ms total 529.452ms
D/eglCodecCommon( 5811): setVertexArrayObject: set vao to 0 (0) 1 0
D/EGL_emulation( 5811): eglMakeCurrent: 0xd788e4c0: ver 3 0 (tinfo 0xd78da8c0)
D/eglCodecCommon( 5811): setVertexArrayObject: set vao to 0 (0) 10 0
W/libc    ( 5811): malloc(388011204) failed: returning null pointer
F/libc    ( 5811): Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 5866 (pawfect.pawfect), pid 5811 (pawfect.pawfect)

Build fingerprint: 'google/sdk_gphone_x86/generic_x86:10/QSR1.190920.001/5891938:user/release-keys'
Revision: '0'
ABI: 'x86'
Timestamp: 2019-11-07 21:09:32+0530
pid: 5811, tid: 5866, name: pawfect.pawfect  >>> xyz.pawfect.pawfect <<<
uid: 10134
signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
eax 00000000  ebx 000016b3  ecx 000016ea  edx 00000006
edi ea6c533e  esi bfde6810
ebp ee51dad0  esp bfde67b8  eip ee51dad9
backtrace:
#00 pc 00000ad9  [vdso] (__kernel_vsyscall+9)
#01 pc 00092328  /apex/com.android.runtime/lib/bionic/libc.so (syscall+40) (BuildId:<PHONE_NUMBER>8016ad14f4b98c3ab6c65c)
#02 pc 000ad651  /apex/com.android.runtime/lib/bionic/libc.so (abort+193) (BuildId:<PHONE_NUMBER>8016ad14f4b98c3ab6c65c)
#03 pc 0110697a  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#04 pc 012636eb  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#05 pc 01263764  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#06 pc 011a004b  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#07 pc 012632ec  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#08 pc 013cf385  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#09 pc 013cf0fa  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#10 pc 013ceb7f  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#11 pc 0125eb0a  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#12 pc 0125fa13  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#13 pc 0125f9d3  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#14 pc 0110f869  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#15 pc 0125b47b  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#16 pc 0125f7ac  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#17 pc 0119eadc  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#18 pc 011e563d  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#19 pc 011e54b4  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#20 pc 011e56e9  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#21 pc 011e496c  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#22 pc 011e4ecc  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#23 pc 0112b469  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#24 pc 01114729  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#25 pc 011144a5  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#26 pc 01114adb  /data/app/xyz.pawfect.pawfect-zcLch5QlUxnJpvpz5seX4g==/lib/x86/libflutter.so (BuildId: 7ca566457ac4b7d6)
#27 pc 0011a8e5  /apex/com.android.runtime/lib/bionic/libc.so (__pthread_start(void*)+53) (BuildId:<PHONE_NUMBER>8016ad14f4b98c3ab6c65c)
#28 pc 000af6a7  /apex/com.android.runtime/lib/bionic/libc.so (__start_thread+71) (BuildId:<PHONE_NUMBER>8016ad14f4b98c3ab6c65c)
Lost connection to device.
Could not update files on device: HttpException: Connection closed before full header was received, uri = http://<IP_ADDRESS>:64731/XKLXqgskrKE=/
Flutter Doctor Output
[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.15 19A602, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.39.1)
[✓] Connected device (1 available)
• No issues found!
uditchugh@Udits-MacBook-Pro pawfect % flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.15 19A602, locale en-IN)
• Flutter version 1.9.1+hotfix.6 at /Users/uditchugh/Desktop/dev/flutter
• Framework revision 68587a0916 (8 weeks ago), 2019-09-13 19:46:58 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
• Android SDK at /Users/uditchugh/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.1, Build version 11A1027
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 41.0.2
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.39.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.5.1
[✓] Connected device (1 available)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)
• No issues found!

Hi @thecoffeehog
Fatal signal 6 SIGABRT it might means that your device hang at some point
Lost connection to device.
Could not update files on device: HttpException: Connection closed before full header was received, uri = http://<IP_ADDRESS>:64731/XKLXqgskrKE=/

the one you posted is the whole flutter build --verbose?
if it isn't could please you post the full extent
thank you

Thanks, @iapicca for the quick response.
TheLost connection.. is coming after the crash and the SIGBART error.
I have updated the issue with flutter run --verbose output.

This is crashing due to a large malloc that fails:
W/libc ( 5811): malloc(388011204) failed: returning null pointer
The malloc happens during decoding of a PNG image in Skia (specifically in SkPngInterlacedDecoder::setUpInterlaceBuffer)
third_party/libcxx/include/memory:3381
third_party/skia/src/ports/SkMemory_malloc.cpp:28
third_party/skia/src/ports/SkMemory_malloc.cpp:74
third_party/skia/include/private/SkMalloc.h:59
third_party/skia/include/private/SkTemplates.h:240
third_party/skia/src/codec/SkPngCodec.cpp:758
third_party/skia/src/codec/SkPngCodec.cpp:677
third_party/skia/src/codec/SkPngCodec.cpp:1153
third_party/skia/src/codec/SkCodec.cpp:388
third_party/skia/include/codec/SkCodec.h:366
third_party/skia/src/codec/SkCodecImageGenerator.cpp:55
...

Is there a particular PNG file used by your app that reproduces this bug?  That PNG might be malformed.  Or possibly something is going wrong inside Skia during decoding.

The app works fine on iOS so I don't think it's an image in the app which
is causing the issue.
On Fri, 8 Nov, 2019, 1:42 AM Jason Simmons<EMAIL_ADDRESS>wrote:

This is crashing due to a large malloc that fails:
W/libc ( 5811): malloc(388011204) failed: returning null pointer
The malloc happens during decoding of a PNG image in Skia (specifically in
SkPngInterlacedDecoder::setUpInterlaceBuffer)
third_party/libcxx/include/memory:3381
third_party/skia/src/ports/SkMemory_malloc.cpp:28
third_party/skia/src/ports/SkMemory_malloc.cpp:74
third_party/skia/include/private/SkMalloc.h:59
third_party/skia/include/private/SkTemplates.h:240
third_party/skia/src/codec/SkPngCodec.cpp:758
third_party/skia/src/codec/SkPngCodec.cpp:677
third_party/skia/src/codec/SkPngCodec.cpp:1153
third_party/skia/src/codec/SkCodec.cpp:388
third_party/skia/include/codec/SkCodec.h:366
third_party/skia/src/codec/SkCodecImageGenerator.cpp:55
...
Is there a particular PNG file used by your app that reproduces this bug?
That PNG might be malformed. Or possibly something is going wrong inside
Skia during decoding.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/44352?email_source=notifications&email_token=AB7ELG4MPF4LNYCJR45SW7TQSRZB5A5CNFSM4JKJE2N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNU47Q#issuecomment-551243390,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7ELGYN3I7S6MG232CMYD3QSRZB5ANCNFSM4JKJE2NQ
.

@jason-simmons I wanted to get this done quickly so I replaced all my images and tried and it seems you were right. It was an issue with some PNG.
But I am still surprised as to how it worked all fine on iOS.

use android:largeHeap="true" and it will fix issue for me.

Fixed for me
add the following in your app/build.gradle
buildTypes {
release {
        minifyEnabled false
        shrinkResources false


Prepare v5.1.0

Update CHANGELOG.md and version #s
[no-log]

Could you try to get #2496 in for the release? no-unsafe-any was pretty broken in 5.0 :bug:


403 error

Running Ollama model locally on my Ubuntu 20.04 machine.
I can verify the service is working correctly for localhost and <IP_ADDRESS>
curl http://<IP_ADDRESS>:11434/api/generate -d '{ "model": "llama3.2", "prompt": "What is water made of?", "stream" : false }' {"model":"llama3.2","created_at":"2024-10-12T01:19:13.325620726Z","response":"Water is a compound made up of two elements: hydrogen and oxygen. It's composed of one molecule of each element, with the chemical formula H2O.\n\nIn more detail, each molecule of water consists of:\n\n* Two hydrogen atoms (H) bonded to\n* One oxygen atom (O)\n\nThis bond between the hydrogen and oxygen atoms is what gives water its unique properties, such as its ability to dissolve a wide range of substances and support life as we know it.","done":true,"done_reason":"stop","context":[128006,9125,128007,271,38766,1303,33025,2696,25,6790,220,2366,18,271,128009,128006,882,128007,271,3923,374,3090,1903,315,30,128009,128006,78191,128007,271,29353,374,264,24549,1903,709,315,1403,5540,25,35784,323,24463,13,1102,596,24306,315,832,43030,315,1855,2449,11,449,279,11742,15150,473,17,46,382,644,810,7872,11,1855,43030,315,3090,17610,315,1473,9,9220,35784,33299,320,39,8,70241,311,198,9,3861,24463,19670,320,46,696,2028,11049,1990,279,35784,323,24463,33299,374,1148,6835,3090,1202,5016,6012,11,1778,439,1202,5845,311,73739,264,7029,2134,315,33155,323,1862,2324,439,584,1440,433,13],"total_duration":2155936003,"load_duration":1183158420,"prompt_eval_count":31,"prompt_eval_duration":22426000,"eval_count":96,"eval_duration":947470000}
However the extension returns 403 Forbidden error
Upon further investigation, it appears to be CORS issue
I followed this guide to allow OLLAMA_ORIGINS=*
I am aware this is unsafe, hence submitting this issue, may be there is a better work around that I am not aware of?

Unfortunately I had to do it as well. I think this happens only in certain situations like browser extensions as I am usually able to call Ollama locally (and even behind a reverse proxy) without problems.
Closing this because it is an Ollama based issue - I may suggest you to set OLLAMA_ORIGINS to your subnet if you use it locally.

Just wanted to add that the same happens on macos.

That's exactly what I did :)

And to solve it permanently I did this.
Quoting here for convenience.

@kellerkind84 is this working now? It's covered in the FAQ. As @dims mentioned, just:
1. stop the ollama application;

2. run `launchctl setenv OLLAMA_HOST "<IP_ADDRESS>"`

3. restart ollama

4. check in `~/.ollama/logs` to see if "Listening on [::]:11434" is in one of the log files

Make sure you're looking in the last log file for step 4.


draft: potential fix for #1298.

Hi maintainers, this is a draft of a fix for #1298. It adds a follow_symlink boolean flag to Marimo's ServerConfig (defaulting to false), and propagates it to the call site where the StaticFiles for /assets is constructed. This allows users to set it via their ~/.marimo.toml files like so:
[server]
follow_symlink = true

I've verified this works by patching this PR into my Bazel repo using the setup described here: https://github.com/marimo-team/marimo/issues/1298#issuecomment-2091813225. I also verified this PR passes ruff and mypy.
I've kept this PR simple. This is the first time I've tried to change marimo's codebase, so I could definitely have missed things from the discussion in #1298. Suggestions are welcome.

I have read the CLA Document and I hereby sign the CLA.

It looks like the test failures are spurious. I'm also not sure how to sign the CLA. (The bot above told me to post a comment saying I signed it, which I did above, but no luck.)

@Ubehebe yea the test are snapshot tests - running it once fixes it


wrong hyperlink

Hyperlink for the text: "Install Azure IoT Edge for Linux on Windows" redirects to "Install and manage Azure IoT Edge with Windows containers" instead of linux.
Probably should be linking to "https://docs.microsoft.com/en-us/azure/iot-edge/how-to-install-iot-edge-on-windows?view=iotedge-2018-06&tabs=powershell" instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c4758821-fb75-d65f-f2f4-395a7f79c66c
Version Independent ID: 094ca99f-558a-2e83-9638-6ba14644a1a2
Content: PowerShell functions for Azure IoT Edge for Linux on Windows
Content Source: articles/iot-edge/reference-iot-edge-for-linux-on-windows-functions.md
Service: iot-edge
GitHub Login: @v-tcassi
Microsoft Alias: fcabrera

Hello @Heidern89
I have assigned the issue to the content author for further review.

Thanks for catching this @Heidern89
Resolved in this PR by @DixitArora-MSFT
#please-close


bug: cannot generate docs on python 3.10

output from make docs:
make -C docs html
make[1]: Entering directory '/mnt/c/Repos/python-docx/docs'
sphinx-build -b html -d .build/doctrees   . .build/html
Traceback (most recent call last):
  File "/mnt/c/Repos/python-docx/.venv/bin/sphinx-build", line 5, in <module>
    from sphinx.cmd.build import main
  File "/mnt/c/Repos/python-docx/.venv/lib/python3.10/site-packages/sphinx/cmd/build.py", line 25, in <module>
    from sphinx.application import Sphinx
  File "/mnt/c/Repos/python-docx/.venv/lib/python3.10/site-packages/sphinx/application.py", line 48, in <module>
    from sphinx.util.tags import Tags
  File "/mnt/c/Repos/python-docx/.venv/lib/python3.10/site-packages/sphinx/util/tags.py", line 11, in <module>
    from jinja2 import nodes
  File "/mnt/c/Repos/python-docx/.venv/lib/python3.10/site-packages/jinja2/__init__.py", line 6, in <module>
    from markupsafe import escape
  File "/mnt/c/Repos/python-docx/.venv/lib/python3.10/site-packages/markupsafe/__init__.py", line 13, in <module>
    from collections import Mapping
ImportError: cannot import name 'Mapping' from 'collections' (/usr/lib/python3.10/collections/__init__.py)
make[1]: *** [Makefile:20: html] Error 1
make[1]: Leaving directory '/mnt/c/Repos/python-docx/docs'
make: *** [Makefile:43: docs] Error 2

Did you run pip install -r requirements-docs.txt in your virtualenv? The versions of Sphinx and its dependencies are quite specific for these docs. It works for me locally and on ReadTheDocs so I'd look there first.

Yes, I installed requirements-docs.txt in my virtualenv. Problem is fixed when I updated dependencies from requirements-docs.txt to the latest versions. It looks like an issue with some dependency, probably on Python 3.10. Which Python version do you use?

My local virtualenv for python-docx has Python 3.8.18 installed. I expect that was on purpose because I got a new machine a few months ago, and I vaguely remember downgrading it for the purpose of building the docs.

I think it would be good to update soon anyway, because the end of support for Python 3.8 is October 2024.

Yeah, at some point ReadTheDocs won't support that version anymore and we'll be forced to update I suppose. Switching to the new templates will require pretty broad changes I expect so that's not going to be a quick job :)
The docs aren't really something designed for folks to build for themselves. I don't even use them locally myself, I always go to ReadTheDocs to consult them. But I suppose if you were working offline for some reason that might be handy.


Create a new 'Dev' branch

I prefer us to use Dev branch for the development work and master branch is being the main branch from which you can deploy to from.

Sounds good. I've created a dev branch from master just now.


build of ACM host example is broken with Arduino Core 2.0.2

Thank you so much for this great library!
The acm.ino build is fine when it is in use with Arduino Core 2.0.1
However,  Espressif have recently released the 2.0.2 one and, unfortunately, we've got a regression -
$ arduino --verify --verbose-build acm.ino

< ... skipped ... >

..... /home/user/Arduino/libraries/EspTinyUSB/src/host/common/usb_host.cpp -o /tmp/arduino/libraries/EspTinyUSB/host/common/usb_host.cpp.o
/home/user/Arduino/libraries/EspTinyUSB/src/host/common/usb_host.cpp: In member function 'bool USBhost::init(bool)':
/home/user/Arduino/libraries/EspTinyUSB/src/host/common/usb_host.cpp:68:31: error: 'const usb_host_client_config_t' has no non-static data member named 'client_event_callback'
         .max_num_event_msg = 5};
                               ^

unfortunately, I am currently facing the same problem. I am building a flightcontroller based on ESP32 S2 following the gamepad example. Is there no solution for this yet?

Same problem.

Fixed by https://github.com/chegewara/EspTinyUSB/pull/75


Add license automatically

add make add-copyright and make check-copyright in Makefile to add and check copyright for files automatically
check if all needed copyright is added in workflow
add copyright to needed files

This is based on #3100

@bangqipropel add necessary info to make your commit and PR summary clear. and link it to the right issue. thanks.

@bangqipropel add necessary info to make your commit and PR summary clear. and link it to the right issue. thanks.

@luolanzone Hi, I see, but it seems like the "Linked issues", "Assignees" or something like that is not editable for me, seems like no permission for me, for the antrea main fork, you have any idea whom I should ask the permission for?

@bangqipropel , you don't need such permission, please update the description to link the issue, you can take a look at this help doc: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Codecov Report

Merging #3122 (2c88847) into feature/multi-cluster (6e66fcb) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           feature/multi-cluster    #3122   +/-   ##
======================================================
  Coverage                  39.95%   39.96%
======================================================
  Files                        182      182
  Lines                      21352    21352
======================================================
+ Hits                        8531     8533    +2
+ Misses                     11980    11978    -2
  Partials                     841      841

Flag
Coverage Δ

unit-tests
39.96% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...uster/controllers/multicluster/controller_utils.go
44.18% <ø> (ø)

pkg/ovs/openflow/ofctrl_action.go
11.25% <ø> (ø)

pkg/ovs/openflow/ofctrl_bridge.go
1.20% <ø> (ø)

pkg/ovs/openflow/ofctrl_flow.go
36.92% <ø> (ø)

pkg/agent/openflow/pipeline.go
21.53% <0.00%> (+0.06%)
:arrow_up:

pkg/agent/cniserver/ipam/antrea_ipam_controller.go
65.38% <0.00%> (+3.84%)
:arrow_up:

@luolanzone @antoninbas @jianjuns  can be reviewed again, thanks!

why is this being merged into feature/multi-cluster instead of main?

changed

/skip-all

@bangqipropel  Could you help to resolve the conflicts? thanks.

Hi @antoninbas @tnqn  Could you help to review this issue again, @bangqipropel  has fixed the code conflicts. thanks.

/skip-all

I approved bu looks like the CI checks are not running correctly. You may need to close and re-open the PR?

I approved bu looks like the CI checks are not running correctly. You may need to close and re-open the PR?
@antoninbas
Have done this but some of the Jenkins still report errors, I also have this error on other PRs, is there something wrong with Jenkins?

Most Jenkins jobs a re marked as failed when they do not run. /skip-all should make then "green" but maybe the command doesn't cover all jobs (only the required ones).

/skip-all


Monitoring WT client - insufficient runtime info and/or insufficient documentation

I run 0.12.1-beta, and have a WT configured. I need to figure out if the WT is actually doing it's job, at least as far as the client can determine this.

wtclient tower/towers
and
wtclient stats
{
"num_backups": 6,
"num_pending_backups": 6,
"num_failed_backups": 0,
"num_sessions_acquired": 4,
"num_sessions_exhausted": 1
}

it seems nothing can reliably tell me if the WT accepted my channel states. Like the output above tells me that all the 6 backups are also "pending" - sounds to me like they were not successfully committed to the WT. Yet the WT debug log tells me:

[DBG] WTWR: State update 6 accepted for XX
[DBG] WTWR: Sending MsgStateUpdateReply(code=0 last_applied=6) to XX

and similarly on the client:

[INF] WTCL: (legacy) SessionQueue(XX) uploaded backup(XX, NNNN) seqnum=6

So is the "num_pending_backups" broken and should actually be zero, as all backups have successfully been commited? If not, what is the meaning of num_pending_backups?
What can I figure out from the output of lncli wtclient towers? adding/removing a WT does not actually add/remove the WT from there, but just changes the active_session_candidate. I always have a positive number of sessions, and an empty session array - which confuses me.
Before I dug into this today, I noticed my WT crashed 2 weeks ago. The lncli wtclient stats was basically the same as above, with num_backups=num_pending_backups=210 - but with the WT being down and the output looking just like with a running WT... no help from the command.

So is the "num_pending_backups" broken and should actually be zero, as all backups have successfully been commited? If not, what is the meaning of num_pending_backups?

I've confirmed this is a bug, the num_pending_backups field isn't decremented at the moment when a backup is accepted. I'll open a PR to fix this.

What can I figure out from the output of lncli wtclient towers? adding/removing a WT does not actually add/remove the WT from there, but just changes the active_session_candidate. I always have a positive number of sessions, and an empty session array - which confuses me.

lncli wtclient towers -h is your friend, you can also use -h on any of its subcommands. Adding/removing a tower depends on the parameters used, e.g. if you provide an address, then that address will be added/removed. If you provide just the tower pubkey, the tower as a whole is added/removed. As for the sessions being empty, you need to use the flag --include_sessions. We added this flag to make the command output easier to glance.


doc: updated the comment of OOP killer

This commit is trivial. It is to update the existing comment of OOP killer
for maintenance and readability.
Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: Version: 1.20190225. Thank you for submitting PR #511. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

It's trivial commit.
I am going to merge this PR because the CI is passed.


Rebuild full widgets when use TextFormField inside BottomSheet

When use TextFormField inside bottom sheet and click on TextFormField, it rebuild full widget from builder bottom sheet parameter to end. I note that rebuild four times when click on and four time when back.

When use TextFormField inside bottom sheet and click on TextFormField, it rebuild full widget from builder bottom sheet parameter to end. I note that rebuild four times when click on and four time when back.

Hello @Harbey127. Thank you for filing this issue. Can you please provide the following information?

A complete and minimal, reproducible example.
The output of flutter doctor -v
The output of flutter run-v


Issue with Azure AD

Hi,
I am just trying to access a custom WebAPI I have developed in my Azure tenant. However, I keep on getting the below error on the console:
The user or administrator has not consented to use the application with ID ‘XXXX’.
The XXXX is my Client ID in Azure. I am able to get a request_token, but when it tries to do the POST for the authentication, I get the above mentioned error.
Any ideas of what could be the reason?
Daniel Reyna

Unfortunately, I do not.  You might look through the commit history for the developer that added this provider.  Not much of a Microsoft user myself.
If the contributor doesn't respond, you'll have to take it to Stack Overflow.
Best,


vscode php-intellisense GO to Defination

From one class defination to another class defination not working....
Originally posted by @vibranttheme in https://github.com/felixfbecker/vscode-php-intellisense/issues/360#issuecomment-483612282

Just move to PHP Intelephense.. https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client

PHP Intelephense. go to defination for example
require_once( 'class.db.php' ); $db = new DB;  class MM {  function insertData($tablename,$insertdata){ $save = $db->insert($tablename,$insertdata); }	 }
Now jump from class MM to function insert in classs.db.php file not working.

PHP Intelephense. go to defination for example
require_once( 'class.db.php' );
$db = new DB;
class MM
{
function insertData($tablename,$insertdata){
$save = $db->insert($tablename,$insertdata);
}
}
Now jump from class MM to function insert in classs.db.php file not working.

Have you open the folder as project? Intelephense need that. Anyway you need to open this issue on intelephense git.
It should works well, because I already use it on big project like Dolibarr


is tochdistill support knowlede distillation for Vision Foundation Models like Grounding Dino / Grounding DinoSAM ?

Hi Team,
Currently i am working in Grounding Dino vision foundation model for object detection ( https://github.com/IDEA-Research/GroundingDINO). The model size is around 660 MB. I want to deploy it in the edge device and i like to use Grounding Dino model (as teacher model) for KD.
I want to know whether torchdistill package supports vision foundation model ?
if it is so i want to know is there any sample link / demo code available for Vision foundation model KD.
thanks for your help.

Please read https://github.com/yoshitomo-matsubara/torchdistill#issues--questions--requests and use Discussions instead
Closing this as it's not a bug.


How to use set  REST_V2.value  in  self.protocol of class Model ?

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
How to use set  REST_V2.value  in  self.protocol of class Model ?

https://github.com/kserve/kserve/blob/1314130e93375bbda6ba46703af07a52262d1399/python/kserve/kserve/model.py#L72C14-L72C22
I am currently using a custom container ( custom code deployed as a docker image) and currently its using v1/models apis .
I am facing this issue https://github.com/kserve/kserve/issues/3007 for v1 apis , hence I am migrating to v2/models apis.  When I searched the documentation , there was no way to pass  the protocol version for custom container. Also even Inside kserve python sdk there is no way to set protocol as  REST_V2.value in Model class since it's already hard-coded.
My yaml
apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  name: some-name
spec:
  predictor:
    containers:
      - name: some-name
        image: some-image:v1
        env:
          - name: PROTOCOL
            value: v2
          - name: MODEL_NAME
            value: some-name

My python code :
import kserve
from typing import Dict
from kserve.utils.utils import generate_uuid
from kserve import InferRequest, InferResponse, InferOutput
import os

class AlexNetModel(kserve.Model):
    def __init__(self, name: str):
       super().__init__(name)
       self.name = name
       self.load()

    def load(self):
        self.ready = True

    def predict(self, payload: InferRequest, headers: Dict[str, str] = None) -> InferResponse:
       pass

if __name__ == "__main__":
    model = AlexNetModel("custom-model")
    kserve.ModelServer().start([model])

Environment:

KServe Python sdk Version: kserve==<IP_ADDRESS>

@Rstar1998 are you using protocol version for doing anything in the model server? This field is primarily used by transformer to call out to the predictor according to the protocol version passed in on transformer, not sure how much useful this field is on custom predictor.

Is this issue still open? I would like to contribute to this.


[BULK UPDATE] DocuTune - Fix build validation issues: docs-link-absolute

[BULK UPDATE] DocuTune - Fix build validation issues: docs-link-absolute
Global effort to fix build validation errors
The Microsoft Skilling team is fixing build validation errors and specific brand inconsistencies in Microsoft technical documentation for the rest of FY23 Q1. This will help address various accessibility, security, and usability issues. This PR was generated using DocuTune. It includes only targeted fixes and minor formatting adjustments.
DocuTune PRs improve quality of technical content by finding and automatically correcting a broad set of issues only where the correction is suitable. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!
CorrelationId: 0df9c2d6-63f8-4d1e-8b57-b33611a06514
InitiativeId: docutune-build-validation-issues-2022-05
PointOfContact: Alex Buck

#docutune-draft

Docs Build status updates of commit 66e2795:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Contributing.md
:white_check_mark:Succeeded

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#docutune-ready

@AlexJerabek
Please merge the changes in this PR. For more information, see the description at the top of this PR.
Any pre-existing build validation issues or insufficient Acrolinx scores should be addressed in a separate PR.
#docutune-request-approval

Docs Build status updates of commit c992597:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Contributing.md
:white_check_mark:Succeeded

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


feat: Color code of alert should show green when it RESOLVED for discord sink.

Is your feature request related to a problem?
Color code is showing red when get resolved alert on discord , it should show green

Describe the solution you'd like
Here it should show in green color code.

Should get fixed in https://github.com/robusta-dev/robusta/pull/775/files


Dynamic query example

Hi, it would be nice to show how you can deal with dynamically changed queries like filters on a marketplace, if it's a even possible with the library.

Yeah, this is the example from sqlx on rust:
Took this example from stackoverflow.
use sqlx::{query_builder::QueryBuilder, Execute};

struct Search {
    id: i64,
    username: Option<String>,
    min_age: Option<i8>,
    max_age: Option<i8>,
}

fn search_query(search: Search) -> String {
    let mut query = QueryBuilder::new("SELECT * from users where id = ");
    query.push_bind(search.id);

    if let Some(username) = search.username {
        query.push(" AND username = ");
        query.push_bind(username);
    }

    if let Some(min_age) = search.min_age {
        query.push(" AND age > ");
        query.push_bind(min_age);
    }

    if let Some(max_age) = search.max_age {
        query.push(" AND age < ");
        query.push_bind(max_age);
    }

    query.build().sql().into()
}

fn main() {
    dbg!(search_query(Search {
        id: 12,
        username: None,
        min_age: None,
        max_age: None,
    })); // "SELECT * from users where id = $1"
    dbg!(search_query(Search {
        id: 12,
        username: Some("Bob".into()),
        min_age: None,
        max_age: None,
    })); // "SELECT * from users where id = $1 AND username = $2"
    dbg!(search_query(Search {
        id: 12,
        username: Some("Bob".into()),
        min_age: Some(10),
        max_age: Some(70),
    })); // "SELECT * from users where id = $1 AND username = $2 AND age > $3 AND age < $4"
}

Ah I see, thank you for the example! It's not possible to compose a query dynamically like that with Squirrel as it only (intentionally) works with plain old .sql files. But you could use that final query directly and let squirrel generate the code
select
  *
from
  users
where
  id = $1
  and username = $2
  and age > $3
  and age < $4;

I see, do you plan eventually support it? I'm not sure if that last example would work with optional fields, e.g. if a user hasn't provided the age, may Squirrel automatically detect it and generate query without age filter??

No, Squirrel doesn't generate any queries, it only uses the query you write to create type-safe wrappers around those without creating new ones


fetch api - WIP and Not ready to merge

Supports fetch_api  on the client and server side.
TODO in a separate PR

api/protocol to report fetch failed

Suggest closing. This is no longer applicable.

does not apply anymore.


Dual screen(Multi screen) system are lock only one screen

Hi.
I have multi screen system.
run this bot lock only one screen :(
check it please
Thanks.

Weird! I have a triple monitor setup and it works for me. What version of Windows are you using?


[Snyk] Upgrade recharts from 2.1.8 to 2.10.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade recharts from 2.1.8 to 2.10.4.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 37 versions ahead of your current version.
The recommended version was released a month ago, on 2024-01-09.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Regular Expression Denial of Service (ReDoS) SNYK-JS-D3COLOR-1076592
586/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.3
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Release notes

Package name: recharts

2.10.4 - 2024-01-09What's Changed
Fix some older bugs annoying bugs, TS typings, update to the storybook theme, and more
Fix

ResponsiveContainer: fix ref.current.current without breaking users using current implementation by @ HHongSeungWoo in #4008 - closes #3718
Brush: Allow Brush to be controlled with start and end index via state by @ ckifer in #4034 - closes #2404
Legend: TypeScript - Add the dataKey type to legend props by @ HHongSeungWoo in #4035 - closes #2909
Pie: TypeScript -  added payload to PieSectorDataItem  type by @ PavelVanecek in #4030
Pie: unique sector keys fix by @ imagineLife in #4009 closes #3273
RadialBar: allow className to be passed to Radial Bar background by @ ckifer in #4027 - closes #4011

Storybook

Storybook: Added Legend component story! by @ AnujSharma141 in #4039
Storybook: add controlled brush storybook entry by @ ckifer in #4032
Storybook: Custom Storybook theme for Recharts brand by @ csdiehl in #4016

New Contributors

@ csdiehl made their first contribution in #4016
@ AnujSharma141 made their first contribution in #4039

Full Changelog: v2.10.3...v2.10.4

2.10.3 - 2023-12-01What's Changed

Fix non-unique react key bug(s) by @ imagineLife in #4006 - closes #4004

New Contributors

@ hkmarques made their first contribution in #4002

Full Changelog: v2.10.2...v2.10.3

2.10.2 - 2023-11-29What's Changed
Patch some bugs from 2.9 / 2.10
Fix

Tooltip: Fix tooltip rendering crash when activeItem is undefined by @ tran-simon in #3982
Cursor: should no longer show gray background on hover where there was none previously @ HHongSeungWoo in #3992
Tooltip: show tooltip when data prop is on individual cartesian component by @ HHongSeungWoo in #3988
LabelList -  TypeScript: LabelList offset prop issue by @ ckifer in #3999

Accessibility

Brush: set default aria-label and allow value override by @ enriquetamames-cpi in #3950

Refactor / Cleanup

Removing some eslint errors for "no array index key" by @ imagineLife

New Contributors

@ tran-simon made their first contribution in #3982
@ enriquetamames-cpi made their first contribution in #3950

Full Changelog: v2.10.1...v2.10.2

2.10.1 - 2023-11-19Fixes #3978
Full Changelog: v2.10...v2.10.1

2.10.0 - 2023-11-19

2.9.3 - 2023-11-06Fix
Brush: Fix an issue where after 2.9 Brush does not correctly slice data when using Line components - fixes #3929 - thank you @ HHongSeungWoo

2.9.2 - 2023-11-01Fix another TS issue from 2.9.
Fix

Line/ActiveDot: Fix breaking type change for the onClick function of activeDot on Line - this resolves #3922 - thank you @ andrewangelle for the quick turnaround

2.9.1 - 2023-10-30Bug fixes following 2.9.0
Fix

TypeScript: fix breaking change in ActiveShape types - fixes #3911 - thanks @ andrewangelle
CartesianGrid: fix breaking change where you could no longer render CartesianGrid without a y-axis - fixes #3907 - thanks @ akamfoad
Line: fix infinite loop when strokeDasharray is '0' on Line - fixes #3899 (and maybe others)

Full Changelog: v2.9.0...v2.9.1

2.9.0 - 2023-10-15 Read more

2.8.0 - 2023-08-25

2.7.3 - 2023-08-08

2.7.2 - 2023-06-22

2.7.1 - 2023-06-15

2.7.0 - 2023-06-15

2.7.0-alpha.0 - 2023-05-26

2.6.2 - 2023-05-10

2.6.1 - 2023-05-10

2.6.0 - 2023-05-08

2.5.0 - 2023-03-15

2.4.3 - 2023-02-16

2.4.2 - 2023-02-15

2.4.1 - 2023-02-10

2.4.0 - 2023-02-09

2.3.2 - 2023-01-12

2.3.1 - 2023-01-12

2.3.0 - 2023-01-12

2.3.0-alpha.1 - 2023-01-05

2.3.0-alpha.0 - 2023-01-04

2.2.0 - 2022-12-08

2.1.16 - 2022-10-29

2.1.15 - 2022-10-12

2.1.14 - 2022-09-06

2.1.13 - 2022-07-26

2.1.12 - 2022-06-27

2.1.11 - 2022-06-24

2.1.10 - 2022-05-19

2.1.9 - 2022-02-10

2.1.8 - 2021-12-14

    from recharts GitHub release notes

Commit messages

Package name: recharts

c1c91b1 2.10.4
205beaf fix: cursor key throwing non-unique key error (#4041)
59246f1 Storybook: Added Legend component story! (#4039)
0d94292 feat: Add the dataKey type to legend props (#4035)
048d006 Fix: allow Brush to be controlled with start and end index (#4034)
7a68e5c docs: add controlled brush storybook entry (#4032)
e59c8f4 Referenceline get end points tests (#4031)
79b2b75 Pie payload types (#4030)
99b4b51 Lint test fixes (#4029)
ed7dc34 allow className to be passed to Radial Bar background (#4027)
e8ea9db Custom Storybook theme for Recharts brand (#4016)
fec5dcc Chore: adjust pie sector key value (#4009)
eddf7f4 fix: ref of the responsive container (#4008)
bf649b2 chore(deps-dev): bump vite from 4.4.11 to 4.5.1 (#4012)
e471a96 Separate cursor component (#3994)
aa1ff2d chore: add missing storybook dependency
91c8954 chore: upgrade storybook
6e6e425 chore(deps-dev): bump @ adobe/css-tools from 4.3.1 to 4.3.2 (#4007)
bdb2595 2.10.3
c0aefd1 Chore: Update keys (stop "new bugs") (#4006)
1e84ac6 chore: fix pie sector key value (#4005)
9968181 Update Storybook story for Pie Chart with Needle example to accommodate resizable charts (#4002)
03ce609 2.10.2
336d15b Set More "key" property values (#4001)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

👍


Stopped with status

Description
This PR add a new event called DOBBY_CTRL_EVENT_STOPPED_WITH_STATUS. This event has an additional parameter i.e. the return code of the app. This event is fired after DOBBY_CTRL_EVENT_STOPPED event. Client code could choose to subscribe to any of the 2 events. The DobbyProxy is currently still subscribed to the DOBBY_CTRL_EVENT_STOPPED event.

@bgray-sky and @iml04 if you are happy I will merge this PR on my local fork.
After this I can create a new PR for merging to the main repo.


Create 0000-01-02-swethagangaguptha.md0000-01-02-swethagangaguptha.md

Add swethagangaguptha's file

j


get-help examples

I'm wondering if there's a place that has a detailed list of the commands and what they do ( with examples). This would help immensely for us newbies that want to get up and running quickly and efficiently.

https://github.com/dfinke/ImportExcel/tree/master/Examples

There are quite a lot of examples if you do
get-help import-excel -full
or
get-help export-excel -full
But there are bound to be things which could be added and would make things better. If Anyone has any they are welcome even if only posted here as  command-line and description we can put them into the help text.
get-command -Module importexcel | get-help | format-table name,synopsis
Gives a list of commands an quick idea of what they do.


Run test after replacing template values

The workflow is included in the template, and we don't want that expansion to be attempted when packages using this template build for the first time. We'll have to do this another way.


Consider to remove entrypoint metadata, do not specify root

During the last ZEP meeting we discussed if it's possible and useful to not have an explicit root of a zarr hierarchy. See the meeting notes here.
This would include to drop the global /meta and /data prefix as described in #177, but possibly also the entrypoint metadata.
This discussion is directly related to those comments: https://github.com/zarr-developers/zarr-specs/issues/177#issuecomment-1336690423
I'll try to summarize the arguments:
Pro explicit root

A zarr hierarchy has a clear address.
Global extensions which move/change metadata (e.g. consolidated metadata) can be configured via the entrypoint metadata. Entrypoint metadata can be a good "gateway" to set up arbitrary extensions, without needing to find any other metadata first.

Contra explicit root

Groups and arrays can be moved anywhere and still are valid groups/arrays (but extensions would need to be part of all respective metadata). (Let's refer to this as nesting invariance.)
Any extensions which don't affect the metadata can be (and then maybe should be) copied into all contained arrays.

One particular case that changes some of these arguments is introducing group-wise extensions, e.g. consolidated metadata within an arbitrary sub-group of a hierarchy. This would weaken nesting invariance, as only the whole group with the extension can be moved freely. E.g. moving any array in the group with consolidated metadata would require an update of the metadata. However, if extensions don't affect metadata, it would be very pratical to simply copy all extensions into the respective arrays.

My currently favoured strategy would be:

Remove the explicit entrypoint metadata
Move the relevant metadata into the groups:

Probably drop metadata encoding (#174)
zarr_format in all group and array metadata
extensions in (relevant or all) group and array metadata

Implicit groups are always opened via their next explicit parent group, arrays w/o metadata must look up extensions in their parent group

The topmost entry of a group hierarchy must be explicit (similar to current entrypoint), e.g. if a collection of arrays should be openable as a group, the topmost group must have metadate, e.g. to specify the zarr version.
The strategy for implementations would be to traverse the store hierarchy upwards from any given url, until array or group metadata is found.

cc all participants of the last zep call: @MSanKeys963 @joshmoore @jbms @WardF @DennisHeimbigner @rabernat

Let's discuss this in the next ZEP meeting tomorrow, so far no objections have been raised. cc @zarr-developers/implementation-council


Change dependency from IFS-core to IFS proper.

The files are in mk2expansion's .zips, we should install them.

Fair enough


fix showing Python testing extensions

Before the colcon_core.python_testing extensions were not listed in the extensions / extension-point verbs.

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   77.59%   77.59%
=======================================
  Files          48       48
  Lines        2517     2517
  Branches      400      400
=======================================
  Hits         1953     1953
  Misses        550      550
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2691a...1defabb. Read the comment docs.


Bump to fasterXml

Slight bump to jackson fasterXml, cause Snyk told me to.

Codecov Report

Merging #56 (752402a) into master (6571ffa) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 752402a differs from pull request most recent head b79e84e. Consider uploading reports for the commit b79e84e to get more accurate results

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage     71.21%   71.21%
  Complexity      369      369
=========================================
  Files            55       55
  Lines          1473     1473
  Branches        230      230
=========================================
  Hits           1049     1049
  Misses          305      305
  Partials        119      119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6571ffa...b79e84e. Read the comment docs.


TypeError: Cannot read property '__esModule' of undefined when /* webpackPrefetch: true */

🐛 Bug Report
I am using serverless to deploy a React app. When I use loadable for code splitting everything is fine until I try to prefretch resources. Adding /* webpackPrefetch: true */ causes a server side crash on importing my < App >
TypeError: Cannot read property '__esModule' of undefined
    at /Users/alexgawley/code/serverless/tmp/loadable-repro/.webpack/service/src/servers/static.js:29310:34
    at Object.<anonymous> (/Users/alexgawley/code/serverless/tmp/loadable-repro/.webpack/service/src/servers/static.js:29312:12)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at /Users/alexgawley/code/serverless/tmp/loadable-repro/node_modules/serverless-offline/dist/lambda/handler-runner/in-process-runner/InProcessRunner.js:157:133
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async InProcessRunner.run (/Users/alexgawley/code/serverless/tmp/loadable-repro/node_modules/serverless-offline/dist/lambda/handler-runner/in-process-runner/InProcessRunner.js:157:9)

To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/agawley/loadable-repro
npm i
npm run offline

load http://localhost:3000
Expected behavior
The page should load with a 'show/hide' link which reveals the lazy-loaded component SomeText. If you remove the /* webpackPrefetch: true */ comment from app.js you get the expected behaviour (but no prefetching!)
Link to repl or repo (highly encouraged)
https://github.com/agawley/loadable-repro
Please provide a minimal repository on GitHub.
https://github.com/agawley/loadable-repro
Issues without a reproduction link are likely to stall.
Run npx envinfo --system --binaries --npmPackages @loadable/component,@loadable/server,@loadable/webpack-plugin,@loadable/babel-plugin --markdown --clipboard
Paste the results here:
## System:
 - OS: macOS 10.15.7
 - CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
 - Memory: 834.46 MB / 16.00 GB
 - Shell: 5.7.1 - /bin/zsh
## Binaries:
 - Node: 12.22.1 - ~/.nvm/versions/node/v12.22.1/bin/node
 - Yarn: 1.22.10 - /usr/local/bin/yarn
 - npm: 7.13.0 - ~/.nvm/versions/node/v12.22.1/bin/npm
## npmPackages:
 - @loadable/babel-plugin: ^5.13.2 => 5.13.2
 - @loadable/component: ^5.15.0 => 5.15.0
 - @loadable/server: ^5.15.0 => 5.15.0
 - @loadable/webpack-plugin: ^5.15.0 => 5.15.0

Hiya. Does anyone have any ideas on this? Another couple of days of debugging hasn't helped. I'm pretty sure this is going to be something whacky to do with my having two different webpack configs, but I can't for the life of me figure out what. Thanks!

I've also experienced some problems with prefetch, to the level that I cannot use them, but not even close to your case.

Got an answer from webpack. It's a bug in webpack (https://github.com/webpack/webpack/issues/12993). PR is here (https://github.com/webpack/webpack/pull/13431)


Add boilerplate docs

We need to add standard docs including:
CODE_OF_CONDUCT.md
LICENCE.md
The can probably just be copied from https://github.com/nodejs/node-addon-api

PR to add base governance docs: https://github.com/nodejs/js-native-api-test/pulls

PR landed, closing


Ex5 Solution

Name: Pritam Sinha
Score: 3
Chemical Accuracy: 2.481113 mHa
Number of Parameters: 16

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry for the delay. Thank you very much for your submission!


Logging a null value

When calling
Logger.LogError("Unable to resolve token: <{0}>", token)

and token is null string, I get an argument null exception.
I would have expected it to have logged "Unable to resolve token: <>"
Here is the stack trace:
Parameter name: args
   at System.String.Format(IFormatProvider provider, String format, Object[] args)
   at Microsoft.Extensions.Logging.Internal.LogValuesFormatter.Format(Object[] values)
   at Microsoft.Extensions.Logging.Internal.FormattedLogValues.ToString()
   at Microsoft.Extensions.Logging.LoggerExtensions.MessageFormatter(Object state, Exception error)
   at Microsoft.Extensions.Logging.Console.ConsoleLogger.Log(LogLevel logLevel, Int32 eventId, Object state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.Logger.Log(LogLevel logLevel, Int32 eventId, Object state, Exception exception, Func`3 formatter)
   --- End of inner exception stack trace ---
   at Microsoft.Extensions.Logging.Logger.Log(LogLevel logLevel, Int32 eventId, Object state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.LoggerExtensions.LogError(ILogger logger, String format, Object[] args)
   at Macu.Raptor.MemberSite.Services.Middleware.SsoAuthenticationHandler.HandleAuthenticateAsync() in C:\Development\Code\Macu.Raptor\src\Macu.Raptor.MemberSite\Services\Middleware\SsoAuthenticationHandler.cs:line 31
   at Microsoft.AspNet.Authentication.AuthenticationHandler`1.HandleAuthenticateOnceAsync()
   at Microsoft.AspNet.Authentication.AuthenticationHandler`1.<InitializeAsync>d__48.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Microsoft.AspNet.Authentication.AuthenticationMiddleware`1.<Invoke>d__18.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Microsoft.AspNet.IISPlatformHandler.IISPlatformHandlerMiddleware.<Invoke>d__8.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Microsoft.AspNet.Diagnostics.DeveloperExceptionPageMiddleware.<Invoke>d__7.MoveNext()

Oh, one possible easy fix,
In Microsoft.Extensions.Logging.Internal.LogValuesFormatter:Format method, change the last 3 lines from
            }

            return string.Format(CultureInfo.InvariantCulture, _format, values);

to
                return string.Format(CultureInfo.InvariantCulture, _format, values);
            }

            return string.Format(CultureInfo.InvariantCulture, _format, (object)null);

@BrennanConroy Could you investigate?

@veccsolutions What's the type of token?  Is it a string, or an object[]?

@muratg token is a string value.

string token = null;
_logger.LogInformation("Unable to resolve token: <{0}>", token);

I noticed that even doing logger.Info(null) blows up. I don't think a logger should ever throw an exception..

I'd rather say that the logging infrastructure should never throw an exception. But loggers themselves - well, if they have major errors (or simple a bug), they might throw, and the logging infrastructure will let it bubble up. We don't want the logging infrastructure to hide bugs in loggers.

Agreed with @Eilon. This bug is about finding out if the abstractions are at fault or specific implementations.

@muratg Our loggers should still be resilient to this though.

I'll close this in favor of https://github.com/aspnet/Logging/issues/422.


Allow . in package names

fixes #921
Changed the code to check if before and after the . is a number, fixing package names like gtkmm-4.0.

This fixes issue https://github.com/poac-dev/poac/issues/921

What is going on with poac format...

@How2PlayGithub  Please avoid spamming the CIs here.  You should try compiling your code locally.  Thanks.

Quick problem: Whenever I change it to what clang-tidy tells me to do, it just tells me what I originally did
/home/usr/Documents/poac/poac-out/debug/../../src/Manifest.cc:427:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
  427 |     if (!(std::isalnum(c) || c == '-' || c == '_' || c == '/'
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         !                 &&   !=     &&   !=     &&   !=
  428 |           || (c == '.' && (i > 0 && !std::isdigit(name[i - 1]))
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           &&    !=     ||    <=  ||
  429 |               && (i < name.size() - 1 && !std::isdigit(name[i + 1]))))) {
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |               ||    >=                ||

/home/usr/Documents/poac/poac-out/debug/../../src/Manifest.cc:427:9: error: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr,-warnings-as-errors]
  427 |     if (!(std::isalnum(c) && c != '-' && c != '_' && c != '/'
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         !                 ||   ==     ||   ==     ||   ==
  428 |           && (c != '.' || (i <= 0 || !std::isdigit(name[i - 1]))
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |           ||    ==     &&    >    &&
  429 |               || (i >= name.size() - 1 || !std::isdigit(name[i + 1]))))) {
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |               &&    <                  &&

@How2PlayGithub  I would suggest you work on this first.

I would check if these are only the characters for this pass and check if dots are only surrounded by numbers in the next pass.

All done! I've tested it and it works

Hi @How2PlayGithub,
Thank you for your interest in contributing to this project.  After multiple rounds of review, it seems that the required changes are still not correct, and I am concerned that the necessary effort to understand and implement the changes may not have been fully put in.
To maintain the quality of the codebase and respect everyone’s time, I need to set some clear expectations:

Please thoroughly review the project code before making changes.
Make sure to test your changes thoroughly before submitting them for review.
If you are unsure about how to implement a change, feel free to ask for guidance, but make sure to put in the effort to understand the feedback provided.

Given the current situation, I am closing this PR.  I encourage you to take the time to fully understand the changes needed and, once you feel confident, you can submit a new PR.
Thank you for your understanding.
Best regards,
Ken


Use uglify-es instead of uglify-js to support ES6

Also updating package-lock, referencing local uglify-js install, and fixing tween deprecation

@tommytee I ended up doing the same change + some cleanup.


advice to reduce cpu usage?

is there a guide that tells that?

What CPU usage are you referring to? Billed CPU usage from a contract action?

What CPU usage are you referring to? Billed CPU usage from a contract action?

Yes, that's what i mean

You should post these type of questions on eosio.stackexchange.com

I tend to agree with @yashbhavsar007.  This is an open-ended question with complex answers much more suitable for StackExchange.  The documentation team has been made aware of it, and perhaps some document will be included to address questions such as this.  Until then, StackExchange is your best bet.

ok，thanks


KDTree bug

KDTrees occasionally enter an infinite loop when rebalancing.
Unfortunately it appears inconsistent, but probably has to do with specific agent positions and the median comparing them to. Can occasionally (rarely) be seen in the Flocking model: https://codesandbox.io/s/flocking-vw76q

Whew, fortunately not an issue with KDTrees themselves, rather with the implementation of the Flocking model. When looking at a neighbor occupying the same position, the separation Vector got assigned an infinite value, which ends up resolving to NaN somewhere in the calculations... KDTree can't handle NaN values, so it threw up its hands and kept on trying to rebalance.
tl;dr not a library issue!


ModuleNotFoundError: No module named 'awswrangler.s3._describe'; 'awswrangler.s3' is not a package

Describe the bug
Unable to import awswrangler
How to Reproduce

conda install -c conda-forge awswrangler=2.16.1
import awswrangler as wr

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Input In [3], in <cell line: 1>()
----> 1 import awswrangler as wr

File /opt/conda/envs/ml10/lib/python3.10/site-packages/awswrangler/__init__.py:10, in <module>
      8 import awswrangler.data_types  # noqa
      9 import awswrangler.utils  # noqa
---> 10 from awswrangler.__version__ import __description__, __title__, __version__  # noqa
     11 from awswrangler.athena import Athena  # noqa
     12 from awswrangler.aurora import Aurora  # noqa

File /opt/conda/envs/ml10/lib/python3.10/site-packages/awswrangler/lakeformation/__init__.py:3, in <module>
      1 """Amazon Lake Formation Module."""
----> 3 from awswrangler.lakeformation._read import read_sql_query, read_sql_table  # noqa
      4 from awswrangler.lakeformation._utils import (  # noqa
      5     _build_table_objects,
      6     _get_table_objects,
   (...)
     13     wait_query,
     14 )
     16 __all__ = [
     17     "read_sql_query",
     18     "read_sql_table",
   (...)
     27     "wait_query",
     28 ]

File /opt/conda/envs/ml10/lib/python3.10/site-packages/awswrangler/lakeformation/_read.py:14, in <module>
     12 from awswrangler._config import apply_configs
     13 from awswrangler.catalog._utils import _catalog_id, _transaction_id
---> 14 from awswrangler.lakeformation._utils import commit_transaction, start_transaction, wait_query
     16 _logger: logging.Logger = logging.getLogger(__name__)
     19 def _get_work_unit_results(
     20     query_id: str,
     21     token_work_unit: Tuple[str, int],
     22     client_lakeformation: boto3.client,
     23 ) -> Table:

File /opt/conda/envs/ml10/lib/python3.10/site-packages/awswrangler/lakeformation/_utils.py:13, in <module>
     11 from awswrangler import _utils, exceptions
     12 from awswrangler.catalog._utils import _catalog_id, _transaction_id
---> 13 from awswrangler.s3._describe import describe_objects
     15 _QUERY_FINAL_STATES: List[str] = ["ERROR", "FINISHED"]
     16 _QUERY_WAIT_POLLING_DELAY: float = 2  # SECONDS

ModuleNotFoundError: No module named 'awswrangler.s3._describe'; 'awswrangler.s3' is not a package

Expected behavior
No response
Your project
No response
Screenshots
No response
OS
Amazon SageMaker Data Science Image
Python version
3.10.4
AWS DataWrangler version
2.16.1
Additional context
No response

Had an older version of awswrangler installed. Had to remove it and its dependencies before reinstalling latest version


e2e test script help

I think the -t and -c options are not very clear to user. Update them so they are more clear to use.

closing as this will be resolved by https://github.com/dora-metrics/pelorus/issues/938


Clarify wording for Learn More screen in Uncertain Delivery State

Here's a first cut for modifying the Learn More screen for DASH pods.
The top part of the graphic is what is displayed now.
The bottom part matches the current commit.
For both cases, I had to scroll up to read all the text.
Removed graphic because I updated words based on comments. See later comment for new graphics.

Looks great - the PR on the slider needs to include this Deactivate Pod button too

Can I ask why there needs to be this deactivate pod button here at all.  If the pod has lost comm, how do you deactivate it from this menu?

Yes, it should skip the "deactivate" part, and just have a "Forget Pod" button.  There does need to be a way to get out of this state, if comms cannot eventually be restored.

Making changes one commit at a time.
This commit adds a primary button with the label "Keep Waiting" which dismisses this screen and renames the destructive button from "Deactivate Pod" to "Discard Pod". There is no logic change to action for that destruction button in DeliveryUncertaintyRecoveryView.swift with this commit.
The graphic below shows the modified portion of the wording for the Unable to Reach Pod screen. (The top portion is same as in prior graphic).

I will need guidance if additional modifications are desired to the actions. Right now, the next screen after tapping Discard Pod (on the screen in prior comment) is the Deactivate Pod screen, which, if comms still fail, takes you to the Discard Pod screen as shown in the graphic below.

See comment when testing similar change for OmniKit: https://github.com/LoopKit/OmniKit/pull/23#issuecomment-1888537322

Updated with the graphics that match the latest commit (25 January 2024). After working with the uncertain comms for OmniKit, I modified those words then came back to this PR and modified them for consistency.
Top row - comes from LoopKit and is not modified.
Middle row - shows top and bottom of the screen addressed by this PR
Bottom row - shows the screen shown after comms are restored (not modified by this PR)


Added targets to install and deploy via helm

Signed-off-by: Rafael Porres Molina<EMAIL_ADDRESS>

@rporres i did not make this PR, GitHub's database kept storing things just not reading them again ;)


add ramp network fiat provider

text correction:
current: focuses excellent UX
updated: focuses on excellent UX

updated text:
Ramp Network provides the ultimate crypto on-boarding flow. This globally accessible product focuses on excellent UX, supports multiple payment options and ensures lowest slippage and transactional fees.


Failed to load the native TensorFlow runtime error in python..

As i try importing Tensorflow i get following import error. Someone please help me.
`Traceback (most recent call last):
File "C:\Python34\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 18, in swig_import_helper
fp, pathname, description = imp.find_module('_pywrap_tensorflow', [dirname(file)])
File "C:\Python34\lib\imp.py", line 297, in find_module
raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named '_pywrap_tensorflow'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Python34\lib\site-packages\tensorflow\python_init_.py", line 66, in
from tensorflow.python import pywrap_tensorflow
File "C:\Python34\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 28, in
_pywrap_tensorflow = swig_import_helper()
File "C:\Python34\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 20, in swig_import_helper
import _pywrap_tensorflow
ImportError: No module named '_pywrap_tensorflow'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<pyshell#0>", line 1, in
import tensorflow as tens
File "C:\Python34\lib\site-packages\tensorflow_init_.py", line 24, in
from tensorflow.python import *
File "C:\Python34\lib\site-packages\tensorflow\python_init_.py", line 72, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Python34\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 18, in swig_import_helper
fp, pathname, description = imp.find_module('_pywrap_tensorflow', [dirname(file)])
File "C:\Python34\lib\imp.py", line 297, in find_module
raise ImportError(_ERR_MSG.format(name), name=name)
ImportError: No module named '_pywrap_tensorflow'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Python34\lib\site-packages\tensorflow\python_init_.py", line 66, in
from tensorflow.python import pywrap_tensorflow
File "C:\Python34\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 28, in
_pywrap_tensorflow = swig_import_helper()
File "C:\Python34\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 20, in swig_import_helper
import _pywrap_tensorflow
ImportError: No module named '_pywrap_tensorflow' `
Failed to load the native TensorFlow runtime.
See https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md#import_error
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.`

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

@rohanjhanepal are you still seeing this issue? Which version of the binary did you use?

Nagging Assignee @yifeif: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@rohanjhanepal do you have MSVCP140.DLL is installed on your system as mentioned in #8385?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 29 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 44 days with no activity and the awaiting response label was assigned. Is this still an issue?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

Closing due to staleness. Please use the latest version for TensorFlow and test again. Feel free to open a new issue if it still persists. Thanks!


Add irrigation service to rain bird

Description:
It's great that you can turn on your irrigation through home assistant. The annoying part I had with Rain Bird is that you have to set the duration up front within the config. This means that if you want to do a different duration, you have to reload home assistant. With this change, a new service is being added, allowing you to send along the duration.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10288
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

@konikvranik since you seem to be kinda maintaining rainbird I believe, you might want to check out my MR.

@peternijssen pleas, rebase onto #26393 where is upgrade to pyrainbird 0.3.1

Thanks @konikvranik. Will update soon.

 I messed something up.

Let me close this and get a proper fix. Sorry once again :(


Current version does not build on mac and amiga

Unfortunately I can't build the current version :(
Both Amiga and MacOS complain about _strdup now (seems to be a windows hack?)
Not sure what to do. Just define _strdup strdup?
Mac: global.h:82 is now including malloc.h.
This file does not exist on the mac.
Also I am getting operator new is missing exception specification in clang on macos.
Also mac includes gamepad_unix :O
It might be time for a CI :D

ah also amiga is complaing about LE_USE_SIMD not being defined...When you accepted my pull request I thought the way would be to not define the LE_SIMD/SSE stuff for amiga. I don't mind to have everything defined for everything but currently unsure if this was a mistake or if it was intended :S

Hi @m0ppers,
my bad!
I tried to clean up and homogenize the preprocessor definitions but I did several mistakes.
Weird that malloc.h does not exist on the mac as it is part of the C library basics.
Anyway, not needed there.
strdup is a MSVC problem which is now fixed properly.
I fixed both Linux and Windows versions.
"new is missing exception specification"
Is this a CLang error or just a warning?
The whole engine is exception free, compiles with no-exceptions, and I would like to preserve it that way.
CI is an excellent idea.

Concerning LE_USE_SIMD, LE_USE_SSE
There is a hierarchy for these flags.
LE_USE_SIMD
LE_USE_SSE
LE_USE_AMMX
LE_USE_SIMD is meant to tell the compiler to use generic vectorisations optimisations and such.
It's the basic level of SIMD.
Then come either LE_USE_SSE or LE_USE_AMMX which are platform specifics.
They make only sense enabled when LE_USE_SIMD is also enabled as they require some definitions and declarations introduced by LE_USE_SIMD to work (at least for SSE) (such as alignment, instruction set, ABI ...).

As I said I would like the preprocessor definitions always defined.
Which to me means (config.h.in):
/** Performance optimizations /
#ifndef AMIGA
#define LE_USE_SIMD					${LE3D_USE_SIMD}					/* Use SIMD instructions & vectors /
#define LE_USE_SSE2					${LE3D_USE_SSE2}					/* Use Intel SSE2 instructions /
#define LE_USE_AMMX				       0
#else
#define LE_USE_SIMD					${LE3D_USE_SIMD}
#define LE_USE_SSE2					0
#define LE_USE_AMMX					${LE3D_USE_AMMX}					/* Use Apollo AMMX instructions */
#endif // AMIGA
#endif // LE_CONFIG_H

Well it does now :-)
@m0ppers  I had to right an hack for timing measurement on MacOs based on some suggestions I found on StackOverflow.
I have not yet checked if this work as intended. It should also be cleaned up somehow.

I think we can close this issue now.


[SPARK-15621]  [SQL] Support spilling for Python UDF

What changes were proposed in this pull request?
When execute a Python UDF, we buffer the input row into as queue, then pull them out to join with the result from Python UDF. In the case that Python UDF is slow or the input row is too wide, we could ran out of memory because of the queue. Since we can't flush all the buffers (sockets) between JVM and Python process from JVM side, we can't limit the rows in the queue, otherwise it could deadlock.
This PR will manage the memory used by the queue, spill that into disk when there is no enough memory (also release the memory and disk space as soon as possible).
How was this patch tested?
Added unit tests. Also manually ran a workload with large input row and slow python UDF (with  large broadcast) like this:
b = range(1<<24)
add = udf(lambda x: x + len(b), IntegerType())
df = sqlContext.range(1, 1<<26, 1, 4)
print df.select(df.id, lit("adf"*10000).alias("s"), add(df.id).alias("add")).groupBy(length("s")).sum().collect()

It ran out of memory (hang because of full GC) before the patch, ran smoothly after the patch.

cc @JoshRosen @rxin

Test build #65340 has started for PR 15089 at commit 4964b9a.

Test build #65340 has finished for PR 15089 at commit 4964b9a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65340/
Test PASSed.

@JoshRosen The current fix looks good to me. Could you also fix the case that LocalLimit is correctly inserted when we turn a Python DataFrame with limit into a Python RDD?

Test build #65456 has started for PR 15089 at commit 27b162b.

Test build #65456 has finished for PR 15089 at commit 27b162b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65456/
Test FAILed.

Merged build finished. Test FAILed.

Test build #65500 has started for PR 15089 at commit fc4858c.

Test build #65500 has finished for PR 15089 at commit fc4858c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65500/
Test PASSed.

@JoshRosen Answer your questions here:

This is special designed for Python UDF (we do not have similar requirement in other place), I'd not to make it general without have a real use case from other places.

Since we already have page pool, so I did not try to re-use the page here (will be more complicated).

Test build #65505 has started for PR 15089 at commit 9a84870.

Test build #65505 has finished for PR 15089 at commit 9a84870.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65505/
Test PASSed.

Test build #65848 has started for PR 15089 at commit 87ecc0d.

Test build #65850 has started for PR 15089 at commit 5239042.

Test build #65848 has finished for PR 15089 at commit 87ecc0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65848/
Test PASSed.

Test build #65850 has finished for PR 15089 at commit 5239042.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65850/
Test PASSed.

@JoshRosen Could you take another look?

Test build #66127 has started for PR 15089 at commit c4f890c.

Test build #66132 has started for PR 15089 at commit 14aef61.

Test build #66127 has finished for PR 15089 at commit c4f890c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66127/
Test PASSed.

Test build #66132 has finished for PR 15089 at commit 14aef61.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66132/
Test PASSed.

Test build #66187 has started for PR 15089 at commit ca607e0.

Test build #66187 has finished for PR 15089 at commit ca607e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66187/
Test PASSed.

LGTM - we should double check whether the synchronized block is sufficient, but we can fix that in a follow-up pr if needed.
Merging in master.


Update string.md

spacing issue in example
Closes #
Describe your proposed changes here.

[ ] Signed the InfluxData CLA
(if necessary)
[ ] Rebased/mergeable

!signed-cla


How to setup Thunderbolt networking?

Hey, really interested in your hardware setup with networking done over Thunderbolt natively (instead of using thunderbolt to 10gbe adapters)
How exactly did you set this up? I haven't been able to find any documentation or info on how to implement something like this or even a mention of networking over Thunderbolt in this way. Do you get the full 40gbps bandwidth?

Basically you need thunderbolt-net: https://christian.kellner.me/2018/05/24/thunderbolt-networking-on-linux/
In my case I connect 3 Proxmox nodes where I run ceph (Kubernetes uses the traditional Ethernet network - 1 GB). Each of the 3 Proxmox ceph nodes has 3 Thunderbolt ports.
I have not used the Thunderbolt mesh recently as the performance without it was good enough and there was an annoying issue with the Thunderbolt mesh: when you restart the nodes the other nodes loose the connection and do not recover it until I manually go and do it. Most likely something that could be fixed but I moved my focus to something else before I figured it out.
There was a Proxmox tutorial I used - I tried to google it but I do not find it.
You might want to ask in the k8s-at-home discord - others there also tried the Thunderbolt network setup (and I am also member there).


Document the VSCode plug-in for Zowe

Under "Extending Zowe CLI",  document the Zowe VSCode plug-in.
Most of the usage/use cases are documented in the readme for the plug-in, which is displayed in the Visual Studio Code marketplace. This article in Zowe CLI can just document the following:

Overview
Use cases
Installing
Prominent link to the Readme for more detailed information.

Complete/published https://zowe.github.io/docs-site/user-guide/cli-vscodeplugin.html


docs: Minor grammar tweaks.

This corrects a few minor grammar things in doc comments.

Good catch, thank you!


Can't update leaf nodes

I found a very odd behavior that I can not understand. If I check the this.isLeaf property in order to update a property the property is not updated. Take a look at this piece of code:
var traverse = require('traverse');
var obj = {user:{age:99,name:'Bob', action: ()=>'Swim'}};

/* This will do nothing, the same object is returned */
traverse(obj).map(function (x) {

    this.isLeaf && this.update('Leaf!')
});

But the below code works perfectly
var traverse = require('traverse');
var obj = {user:{age:99,name:'Bob', action: ()=>'Swim'}};

traverse(obj).map(function (x) {

    if(typeof x === 'string'){
        console.log(this.isLeaf) // This outputs true!!!
        return this.update('Leaf!!') // And this works
    }
});

Why the second one works ? it says that the node is a leaf node, so the condition is the same for both

I can't reproduce this issue... not sure what have happened before


Get all Target and Role data for a given target name

Similar to #744 but more generic -- allows for retrieving all Target and Role data for a specified target name, in the form of a list of TargetWithRole structs

LGTM!  The hash equivalency check from #744 might also be useful for those using this function, but I'm fine with that being a separate PR if you prefer.  :)  Thanks for adding this!  This seems more general purpose.

LGTM pending CI


Various cleanups to instantiation

Cleaning up some cruft to make it easier to work on #215

Cool 👍


stats.preset config option not allowed

Bug report

What is the current behavior?
When using the object option for stats, the preset is not an allowed sub-option.
While, it is well documented here: https://webpack.js.org/configuration/stats#preset it appears to be missing from the WebpackOptions.json schema.
If the current behavior is a bug, please provide the steps to reproduce.
Create a minimal webpack build and enable something like:
// Example from https://webpack.js.org/configuration/stats/#extending-stats-behaviours
module.exports = {
	// ...
    stats: {
        preset: 'minimal',
        moduleTrace: true,
        errorDetails: true
    },
};

What is the expected behavior?
It should be possible to extend stats preset settings without receiving an error, and with configurations being merged properly.

Other relevant information:
webpack version: 4.41.5
Node.js version: v12.10.0
Operating System: Mac OS 10.14.6
Additional tools: None

This option was introduced in webpack 5. It's not available in webpack 4:
https://v4.webpack.js.org/configuration/stats/#extending-stats-behaviours

So the documentation on webpack.js.org which says "webpack v4.41.5" is actually for webpack 5? Is there are link somewhere to get to the v4 docs, other than just knowing? If not, maybe I should see if I can make an update to the docs website, because I found it very confusing and frustrating.

@dougalg I ran into this same issue and was confused by the documentation too. It really should be clearer that the default documentation is for the v5 beta :(
The v4 documentation is still available: https://v4.webpack.js.org/configuration/stats/ and properly doesn't list the "preset" option, but to get to the v4 docs you have to scroll to the bottom of the left sidebar.
It's strange to me that the default docs is for beta, and doesn't make that clear. Thanks for having raised this issue previously.


Change Package and Library names

We use https://github.com/SnapKit/SnapKit framework in our app. They use the name "SnapKit".
I suggest renaming your Package to SnapSDK.

This is fixed by https://github.com/Snapchat/snap-kit-spm/pull/4


Add note about repository move to README

r? @jonas-schievink
(rust_highfive has picked a reviewer for you, use r? to override)


Add requested CPU and memory for NodeSample

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Opened a new PR : https://github.com/newrelic/nri-kubernetes/pull/61


Update README.md

Add TRANSACTION_SERVICE_AUTH_TOKEN as a required environment variable that needs to be set
The value of TRANSACTION_SERVICE_AUTH_TOKEN needs to be some_other_random_token else the tests fail as It won't be able to match with the mocked network request

I think we should just match to whatever is set in the variable and not with the string some_other_random_token. Setting the token to any non-empty value is considered correct and the tests should also pass that way.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.268%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11195

Relevant Lines:
12683

💛  - Coveralls

Wouldn't this be a little confusing? We are not using the auth token anywhere (yet)

Yes I agree. This is given the current state of the CGW which requires this though. Thus my comment on the PR:

I think we should just match to whatever is set in the variable and not with the string some_other_random_token. Setting the token to any non-empty value is considered correct and the tests should also pass that way.

Makes sense to remove this from the test for now. But in its current state anyone who follows the instructions is going to have these tests failing.

Then tests should set their own random token. We cannot enforce an option that's not used anywhere


raise an error when pptx export fails

Let user know why it failed

Codecov Report
Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.03%. Comparing base (a85d724) to head (7eced35).
Report is 8 commits behind head on main.

Files
Patch %
Lines

...ynamicreporting/core/utils/report_remote_server.py
85.71%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   75.91%   76.03%   +0.11%
==========================================
  Files          16       16
  Lines        5015     5065      +50
  Branches     1055     1059       +4
==========================================
+ Hits         3807     3851      +44
- Misses        856      859       +3
- Partials      352      355       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Inform users Multipoint Services were removed

Prevent people from wasting time reading documentation on features no longer available.

@Xelu86, @robinharwood,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#assign: @robinharwood, @Xelu86


Fix guided tour

Fixes #30. I'll make a release with this fix because it's important for first-time users.
Bootstrap had a similar issue (https://github.com/twbs/bootstrap/issues/30553) which led me to the jQuery issue (https://github.com/jquery/jquery/issues/4665). It's also explained in the release notes.

You plan to release from head, not a patch release with just this, right?

Yes, I'll make a proper release. (4.0.1)


Set Accept header

We should set the accept header, too.

http://docs.guzzlephp.org/en/5.3/clients.html?highlight=accept#headers


chore: swap reflect on webpack to core-js

New reflect-metadata 0.1.4 broke webpack.
On the one hand, there is a dozen of warnings with this line:
const nodeCrypto = isNode && function () { try { return (void 0, require)("crypto"); } catch (e) { } }();
Also, reflect is stuck on an old Typescript and that fires hundred of errors (which broke our build).
So I am recommending that we swap reflect-metadata for the one inside core-js which works perfect.
On the other hand I am investigating the warnings to see if they can be fix on webpack or reflect-metadata.

HOLY SMOKE!  What does this mean for every sample (including the QS repo) that is loading reflect-metadata now?
How do we tell people about it?

No. For some reason only webpack complains about it and only on build.
Perhaps if we do system.js builds on the other examples, it will complain the same, but since we don't, we are green on that.
So in short, when we build a webpack application with 0.1.4 it gives warnings (a reflect or webpack bug, yet to confirm) and errors, and that is because reflect uses a really old typescript to create the final build.
If we were to build our examples (we don't) we would probably get the same errors. And since webpack is the only one with the errors, is the only one complaining.
Ideally we would fix webpack if the warnings are a bug on their side and reflect to update the typescript version.
Short them solution is to move to core-js and personally I see this like a long term solution because we can get all our polyfills in one place.
The problem is that the build is broken and we cannot leave it as is.

merged, live.


Makes both diffbots write to a mysql db for image expiry deletion purposes - and azure file support

also updates everything else

We ball


Checking if the token provided is valid

I have get the token manually from this page and save it environment everytime I run my notebook.  The token is valid for 24 hours, is there a function in pyinaturalist to check if the token is valid or not.
Currently I notice that pyinaturalist doesn't provide a descriptive error when an invalid or expired token is used.

For error messages, currently you should see something like this:
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api.inaturalist.org/v1/observations

I don't currently know of a way to differentiate between a 401 error due to an invalid token vs something you shouldn't have access to (like modifying another user's observations).
I could definitely add a function to check if a token is valid, though.
You might already be aware, but there are some other authentication features documented here, like keyring integration. Those do require creating an iNat Application, though, which is a bit inconvenient. You used to be able to get one instantly, but now you have to apply for one (I'm guessing because someone abused it at some point).
You mentioned you're running this in a notebook; are you using Jupyter or something else that runs in the browser? There might be an easier way to refresh access tokens without needing to copy/paste it every 24 hours. I should have some time to look into that later next week.

@JWCook This issue could be resolved by writing documentation. I could now help with it, now that I have spent a week looking into pyinaturalist.
Creating iNat Application requires you to have significant contributions so I choose to go with the API route.

I added a few more notes about authentication to the docs, but any contributions to that would be welcome!


Fix typos in test names

@ryanplusplus FYI We have some issue currently because of which maintainers can't merge. We will merge as soon as the issue is resolved.

@ryanplusplus FYI We have some issue currently because of which maintainers can't merge. We will merge as soon as the issue is resolved.

No worries!


Update 05 Juptyer notebooks to address MLJLinearModels 0.6 update

Updates the Manifest and replaces LogisticClassifer() with LogisticClassifer(lambda=0.001)
cc @roland-KA

Codecov Report

Merging #36 (49898f9) into dev (00d2294) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #36   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          1       1
  Lines          4       4
=====================================
  Misses         4       4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d2294...49898f9. Read the comment docs.