SPI API: Adding  3-wire mode support

I had 2 options:

keep the same size of spi_config structure and take a bit from the slave attribute
rework the spi_config structure

I took the 2nd option because C bit-fields is a no-go on a public API (if I had to go with C bit-fields) or parsing operation on one attribute and some in another would have been really ugly.
Also because the lines mode (single/dual/quad/octal) are not really used anywhere: such modes require some additional changes on the SPI API to be properly used (xec SPI driver tried to use it as it is but it's not exactly right, as writing a command forces the user to configure the controller on single line, holding CS, then re-configure on dual/quad/octal in order to get the command result at the right mode: it's heavy and cumbersome and limit the possibilities as well of these modes).
To really enable these modes something like #20564 should be done.
This obviously breaks struct spi_config a bit, but macros have same names, full duplex is by default (since it's 99.999% of the cases anyway) etc...

@tbursztyka
It seems a very good job! Before looking at it in a more detailed way I have a question: did you use hts221 sensor to test SPI 3 wire? Have you also tested other sensors?

@avisconti  I am in the process of testing hts221 for this purpose, this is the only 3wire sensor I have at hand. But if it works for it, it should work for the others as well (knowing that other SPI controllers than STM32 will need to be updated as well).

Looks like some sensors can do full or half duplex, such as lis2dh (another ST sensor). I guess this will need a DTS solution in order to differentiate one or the other. (currently the spi version of this driver is obviously hard-coding full duplex mode).

@avisconti I am in the process of testing hts221 for this purpose, this is the only 3wire sensor I have at hand. But if it works for it, it should work for the others as well (knowing that other SPI controllers than STM32 will need to be updated as well).

I saw that you are also implementing multi-instance, which is good! In such a casa may I ask you,  if not bothering too much, to use the common stmemsc API you can find under sensor/stmemsc ?
Those routines are common among many ST sensors (mostly SPI 4-wires and I2C) and would be nice to have that part tested as well. If I'm requesting too much, I can do it later.
And you may also make use of the latest DT helpers like I did in #38343 (not merged yet), in particular in commit c74640bceee66fbfa87bc019b23936225d4da2bf.  Please let me know.

Looks like some sensors can do full or half duplex, such as lis2dh (another ST sensor). I guess this will need a DTS solution in order to differentiate one or the other. (currently the spi version of this driver is obviously hard-coding full duplex mode).

Yes, I agree.

I saw that you are also implementing multi-instance, which is good! In such a casa may I ask you, if not bothering too much, to use the common stmemsc API you can find under sensor/stmemsc ?

Sound relevant to do it now on hts221

I saw that you are also implementing multi-instance, which is good! In such a casa may I ask you, if not bothering too much, to use the common stmemsc API you can find under sensor/stmemsc ?

Sound relevant to do it now on hts221

@tbursztyka  Yes, and I guess you should cerry-pick c74640bceee66fbfa87bc019b23936225d4da2bf because the PR is still not merged.

@tbursztyka I checked with Microchip HW team and the MCHP XEC QMSPI controller can only support the 3 pin half-duplex mode if the QMSPI MOSI and MISO pins are externally connected together. Need to add driver logic to return an error if the driver is configured for 3-pin mode.

@tbursztyka I checked with Microchip HW team and the MCHP XEC QMSPI controller can only support the 3 pin half-duplex mode if the QMSPI MOSI and MISO pins are externally connected together.

That's always the case for all SPI controller as far as I know, so that's totally fine.

Need to add driver logic to return an error if the driver is configured for 3-pin mode.

At first yes, I'll update all drivers so they reject SPI_HALF_DUPLEX, but it would be nice that each SPI driver owner would enable the support relevantly afterwards.

@tbursztyka Yes, once the PR is merged I will implement support in the XEC SPI driver(s).
Somewhat off topic: Is there any chance your PR for dual/quad SPI or another will be merged?  Or has the Zephyr community decided dual/quad should be handled by a the flash driver?  If I implement a flash driver using the same QMSPI controller I will have "duplicate" drivers because the SPI driver has no support for dual/quad.

Isn't this a stable API change? It has to go through the stable API change process if so.

Isn't this a stable API change? It has to go through the stable API change process if so.

Yes thus why I put the DNM label. I want first to see users reaction, then once it's tested and proven to work: I'll propose the change through https://docs.zephyrproject.org/latest/reference/api/api_lifecycle.html#stable (And I'll probably push for an updated #20564 as well)

I would like an answer to this question.

time zone, anyone?  ;)

Isn't this a stable API change? It has to go through the stable API change process if so.

Yes thus why I put the DNM label.

Great, thanks; I'm dropping my -1 on that understanding then.

@avisconti  can you re-review please?
@mbolivar-nordic Could you re-review, especially the last commit I added. There is no device at the moment that will use such property in DTS, but I hope this is the best way to expose it.

@anangl could you take a look please?

@mbolivar-nordic please revisit

@henrikbrixandersen please revisit


model: plaidml: New ML library

This looks dope! https://github.com/plaidml/plaidml#hello-vgg
We should wrap it!
The approach here should probably be to wrap keras first... see 2020-06-30 meeting minutes / recording

Closing for now


Http/2 truncates large downloads

The problem was with HTTP/2. The data in cache is not truncated. If requested via HTTP/1.1 the entire file is returned. If a "large enough" file is requested via HTTP/2, the stream will be closed before the last bits are delivered.
In my test, I was requesting a file 191941 bytes long.  It would download fine via http1.1, but via http2, it would stop early and only download around 180K bytes.  In verbose mode, curl would provide the following output.
{ [16384 bytes data]
* transfer closed with 11719 bytes remaining to read
 93  187k   93  175k    0     0   366k      0 --:--:-- --:--:-- --:--:--  368k
* Closing connection 0
* TLSv1.2 (OUT), TLS alert, Client hello (1):
} [2 bytes data]
curl: (18) transfer closed with 11719 bytes remaining to read

Looking through the code, the logic to decide when to terminate the stream was flawed. It would decide that it could close the stream if

The stream thinks it is done AND
The amount of data available to read (before we read it) is less than or equal to the window space to send back to the client.

There is a timing flaw here if data is still flowing into the reader. We really need to check the amount of data we really read and we need to make sure the reader is empty.   I have a fix for this locally, and it seems to fix the issue.  I want to write an autest for this issue before putting up a PR.

Hmm, didn't @maskit fix something like this recently (like a few weeks ago)?

The issue I fixed was caused by inactive timeout. The timer wasn't reset.
I read the code around the two condition when I fixed the issue, and it was suspicious. There should be some logic to delay termination of the stream but I won't be surprised if there is a flaw in that area.
Tests for this issue will definitely be useful!

Sigh, having problems reproducing in a test.  Looking for a faster machine to run the test.

FWIW, there is a curl option to rate limit its throughput, which helped us in debugging a timeout issue:
curl --limit-rate 2M ...

Definitely fails against my working branch.  So we have a good test anyway.  Will work through to catch up my branch with the latest 7.1 and at a minimum get a regression test for this case committed.

@shinrich says this is likely fixed already, so closing for now.


Messaging: Slack closure email

Messaging
Due to https://github.com/PostHog/meta/pull/152
Waits for https://github.com/PostHog/meta/issues/162
Waits for https://github.com/PostHog/posthog.com/pull/7307
Details
1x email to 5,000 users exported from the Slack group
First draft:

CC @smallbrownbike @MarconLP
@andyvan-ph and @charlescook-ph for approval

Slight language tweaks.
I'd like to send this tomorrow alongside https://github.com/PostHog/posthog.com/pull/7307 if @andyvan-ph can give me a quick 👍

If it's been a great place to swap ideas and chat, why are we closing it? Would probably say something like it worked when we only had X users (either PostHog or Slack) but now we've got Y people, we've outgrown it, it doesn't keep history, lots of extra features etc. we've built ourselves?
Sorry for the extra hassle (and not giving timely feedback), but I also wonder if it coming from @jamesefhawkins directly will land more strongly as well - a more heartfelt founder type thing?

If it's been a great place to swap ideas and chat, why are we closing it? Would probably say something like it worked when we only had X users (either PostHog or Slack) but now we've got Y people, we've outgrown it, it doesn't keep history, lots of extra features etc. we've built ourselves?

Sorry, should have been clear -- this is covered in the blog post, which I was going to add a link to within the copy when it is published. Don't think we need to explain all the details in the post, personally.

Sorry for the extra hassle (and not giving timely feedback), but I also wonder if it coming from @jamesefhawkins directly will land more strongly as well - a more heartfelt founder type thing?

Happy to go this route. @jamesefhawkins if you want to send me some copy, or I can draft if you prefer? Once I have that I can set it to come from you via C.io.

Lacking further feedback or new copy, I've scheduled this in for Friday. Happy to take amends until then, however.


Documentation: Updated Index & Secure Coding Practices

Indexes:
I've revamped the indexes page so it's a little easier to follow, and when you should use indexes in your SilverStripe application:

Removed the reference about the ability to use raw SQL (the framework doesn't support this).
Added documentation on what indexes the framework does add
Added some information on composite indexes.
Added some information about when indexes get created/updated & how.

Secure Coding Practices:
I've added to the documentation to include

Information about security headers,
The use of HTTPS, and forcing TLS.
Using secure cookies (framework defaults to un-secure cookies)

Thanks @tractorcow, @chillu, @madmatt  I've updated the PR with your changes.


Lexer

lexer(" (set position (* 60 (+ initial rate)))") should  return a linked list that looks like this:
[identifier, closed_paren]  -> [identifier, closed_paren] ->[identifier, closed_paren] -> [variable, rate] -> [variable, initial] -> [operator, +] -> [identifier, open_paren]  -> [indentifier, 60] -> [operator, *] -> [identifier, open_paren] -> [variable, position] ->[operator, set] -> [identifier, open_paren]

Easier one: lexer("(+ (+ 2 3) 7)") should return:
[identifier, open_paren] -> [operator, +] -> [identifier, open_paren] -> [operator, +] -> [num, 2] -> [num,3] -> [identifier, closed_paren] - > [num, 7] -> [identifier, closed_paren]

(
set
position
(
*
60
(
+
initial
rate
)
)
)```

vtomole@vtomole:~/c48/src$ ./c48
left_paren
symbol
symbol
left_paren
identifier
num
left_paren
identifier
symbol
symbol
right_paren
right_paren
right_paren

vtomole@vtomole:~/c48/src$ ./c48
(
+
(
+
2
3
)
7
)

lleft_paren
identifier
left_paren
identifier
num
num
right_paren
num
right_paren


Feature request: add fresh 1.4 define* helper function

Add fresh 1.4 helpers for route, app and layouts.

https://github.com/denoland/saaskit/issues/575

https://github.com/denoland/saaskit/pull/574

Hi @harshmangalam, can you please elaborate on why we need these helpers?

https://deno.com/blog/fresh-1.4#quicker-typing-with-define-functions
No need to bother about importing types like RouteContext and shorter for async component.

https://github.com/denoland/saaskit/pull/590

Completed in #590.


(GH-10) Added documentation link to the readme.

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   88.23%   88.23%
=======================================
  Files           3        3
  Lines         136      136
  Branches       19       19
=======================================
  Hits          120      120
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6121d06...c266829. Read the comment docs.


Question: disable capitalization of text values

I'm not sure if it's by design or a bug but the first character of ever word gets capitalized when the tree is rendered.
For example, when in the codesandbox example - in the treeDisplayData object -  I change
text: "Root 1"
to
text: "Root 1 test"
it renders as "Root 1 Test"
Can I disable this behavior?

Answering my own question, I did this by adding this to my global scss file:
span.capitalize {
  text-transform: none !important;
}

But  you'd need to be more specific with your selector if you have other span elements that use  text-transform.

Hi,
Indeed, that something that could be set in the customOptions. I'll change this soon :slightly_smiling_face:

Hi, sorry it took longer that expected, but the new version is out https://github.com/scalia/vuejs-tree/tree/2.1.0 :slightly_smiling_face:
You can change the text class with the customStyles option (the key is in text.class)


Cheatsheet - Quantum gate matrix memorization

Hi @aasfaw ,
Hope you are doing well. As a beginner, I often used to face difficulty in memorizing the matrix representation of the unitary operators. I am sure, most beginners will be facing this difficulty, especially if they are not engaged with the text very often.
As a result of this, every time I had to revisit the gates, as I would often mix things up e.g. like getting confused between phase gate and other gates.
I created this cheat sheet today as a permanent remedy to my recurring problem. I feel this can help other learners as well.
I know it's not much of a  contribution, but this will give me confidence that in spite of being a beginner, I too can start small and slowly contribute and do more than creating issues only.
I therefore request you to please review it and include it somewhere in the textbook, if the team finds it useful

This is a nice set of mnemonics @der-datenzauberer. Can you please create a folder called ch-appendices in content/ and submit this image in a notebook named cheatsheet_memorizing_quantum_gate_matrices.ipynb in that folder, with some description of how to use the cheatsheet within the notebook?


Auto-saving forms

Hi @wsmd, thanks for creating this useful library!
Quick question - I was wondering what is the best usage pattern recommended for autosaving forms? Do you think we should use onChange at the form level, parse the field that was updated and submit the results? Or use onChange at the field level? Or do you think the library can support submitOnChange as a first class option?

Hi @oyeanuj,

I was wondering what is the best usage pattern recommended for autosaving forms? Do you think we should use onChange at the form level, parse the field that was updated and submit the results?

The library attempts to provide a great deal of flexibility, which means it's really up to the developer to handle various cases depending on the context. I think your auto-saving use case if a good fit for the form-level onChange and handle the form state object from there accordingly.

do you think the library can support submitOnChange as a first class option?

The library does not currently provide any submission functionality (since the main goal of this library is to make it easier to handle the form state itself related to inputs, not the actual form behavior). That said, I'm open to ideas and suggestions! Perhaps you could elaborate more on the submitOnChange to help better understand the problem it tries to solve.
I'd happily reopen on the issue if this does not answer your question. Let me know if you have any further questions!


ErrNotFound package typo

Repository not found errors never reach the handler. It's an error from the controller, not from the repository:
https://github.com/PacktPublishing/Microservices-with-Go/blob/338ef732b987f3a881ce50c2c7fdfd0195c9c9a4/Chapter02/src/metadata/internal/controller/metadata/controller.go#L31-L33

+1 for this

@b441berith can this be merged in please


Resign Backups: Add sub nav and summary

Closes: #489

Coverage decreased (-0.3%) to 89.222% when pulling cf33b5b09d5339ccc9813a48550d9508318d73b9 on na3d:backup-redesign-oct into e94c5cb0531aff014c8edced6fc6838da047ebd2 on linode:master.

This view you're showing here is not the summary page though, correct? The view you are showing is a backup detail view. The summary page has four boxes to represent the four backup slots. You click on one to get to the backup detail view.

It is the summary page that doesn't have a snapshot yet, as that data isn't in the Linode API endpoint yet, and I want this out so more than one person can work on backups.

There is no backup details page, as per your design.  It is only Summary, History, and Settings pages.  I am not sure it would make sense to have both a summary and a details page, given how similar the terms are.

Oh, I see what you mean, um, there isn't a design for the details panel for the summary page.

Just to reiterate, this is what we've talked about as the primary Summary view.

Clicking on one of them (when you can click on one of them because they exist takes you to one of these pages depending on whether or not the backup is a snapshot or auto):

Sidenote: This is one of those scary views @briansteffens has mentioned where you don't know where you are because there's no breadcrumb. Maybe this should be made into a two-part modal (a first in the Linode redesign but not something new to the web). This sidenote shouldn't be a stopper for now, but just bringing it up for the sake of it not being awesome rn.

Coverage decreased (-0.4%) to 89.098% when pulling ae1d555a8c0ee4ff401e928c27c76fa256ce8935 on na3d:backup-redesign-oct into e94c5cb0531aff014c8edced6fc6838da047ebd2 on linode:master.

More changes to be done in future PRs. 👍

Thank you!


Choose which egg to incubate and which incubator.

Expected Behavior
Choose which egg to incubate and which incubator. I would like to incubate only 2km and 5km eggs, using only the infinite incubator in the first levels. At level 20 or so, I would start using all my incubators in 10km eggs. Because the pokemon hatched are directly related with the player level.
How I would use it:
Incubate 2 Km and 5 Km eggs with the infinite incubator, incubate than 10 Km, only if no 2km or 5km egg present.
At level 20: Start incubating all eggs with all incubators, including the 3 use incubators.
How it would help others
Better Pokemon at higher levels.

This has already been added. Perhaps you're using an outdated config file.

Thank you @SGColdSun! I will check it!


Fixes #152: GraphiteReporter retries connection to the server too often.

Connection will be retried for a fixed number of times (5) before aborting the reporting process.
Connection will be opened/closed in each scheduled reporting process.

The GraphiteReporter class seems bit difficult to follow. Part of the reason is that the stateful behaviour like retrying graphite connections is hidden inside helper methods like doReport, reportGauge, and so on. So looking at the top level of report() it is impossible to say anything about the retry behaviour.
This obviously is an existing issue with this class and nothing to do with this PR. However, as a part of this PR we should take this opportunity to rectify these issues.
So could we instead refactor the report() along the lines of:
            Stream<? extends Metric> metrics =
                    Stream.of(
                            gauges.values().stream(),
                            counters.values().stream(),
                            histograms.values().stream(),
                            meters.values().stream(),
                            timers.values().stream()
                    ).flatMap(x -> x);

            retries = 0;
            metrics.forEach(metric -> {
                try {
                    if (retries < MAX_RETRIES) {
                        reportMetric(metric);
                    }
                } catch (UncheckedIOException e) {
                    retries++;
                }
            });

I think I have somehow addressed  all your comments. Even though it's true that the class could be greatly improved by handling all the different meters in an uniform way, the problem I see in the current (previous to this PR) implementation and Mikko's code sample is that we are linking the I/O errors with the metric being reported and skipping a metric just because there was a connectivity issue (which will affect all the other metrics anyway).   Even if the code could be easily changed to do the retry logic  around the 'reportMetric' , it would still be mixing different concerns -what we really want to retry is the I/O operation itself and not any other logic.  I would rather completely decouple the I/o operations from the rest of the code.
Since this was an urgent issue to fix, maybe we can address that in a different issue altogether (I think the whole class and test can be completely refactored).


Update frontend to support manual data recording

In GraphQL challenge query, expose both fitbit user IDs & display name of challenge participants
In frontend, use these in the activity recording form

#20 addresses one part of this.


Add possibility to vertical carousel

Is your feature request related to a problem? Please describe.
Is the possibility to add carousel which showing images, vertically?
Describe the solution you'd like
Through props we will choose, in which way carousel will work.
Describe alternatives you've considered
No response
Additional context
No response

Thank you for sharing this idea, but I'm afraid this feature doesn't seem like a good fit for this library. While I can see that vertical scrolling may feel natural on mobile viewports, I'm not sure how this UX would work on desktop viewports. While this library favors mobile UX, I'm not keen on implementing features exclusive to mobile.


Campaign Dashboard-Details: Significant Events

Context
This is part of EPIC: MI Workflow Redesign #270
This issue covers the associated Significant Events of a campaign deployment

A Significant Event is an event observed during a deployment that is notable for the occurrence of a great example of one or more specific phenomena relating to the campaign.
Significant events may occur within or outside of an IOP.
Though similar in design, there are separate issues for IOPs, and CDPIs

Current

https://admgstaging.nasa-impact.net/campaigns/7671b7c9-5031-4803-b527-a594283f33b8

New
Only see one version of the same Significant Event at a time

https://www.figma.com/file/zY7BS9fR1huZ0CieHf3Dm8/MI-Workflow-Change?node-id=437%3A25982

Significant Events accordion: Changes to the header: Significant Events (X Published). The count here is the total # of published Significant Events, not all the drafts associated with a Significant Event.

Each Significant Events includes the Status, IOP Name, Last Published date, Lasted Edited date

All published Significant Events allow user to View. Unpublished Significant Events and updates allow users to Edit

Unpublished Flow

If no Significant Events, show empty state message There are no Significant Events yet
Selecting New will bring up a new draft page.  https://www.figma.com/file/zY7BS9fR1huZ0CieHf3Dm8/MI-Workflow-Change?node-id=182%3A23385
Once a Significant Event is created, users can edit the Create draft https://www.figma.com/file/zY7BS9fR1huZ0CieHf3Dm8/MI-Workflow-Change?node-id=264%3A24960
When saved, draft moves to In Progress
When saved, draft moves to In Review
When requested, draft moves to In Admin Review
When approved, Significant Event is published, and users are brought back to the Details page with the new published version shown. https://www.figma.com/file/zY7BS9fR1huZ0CieHf3Dm8/MI-Workflow-Change?node-id=437%3A25876
Users can View a published Significant Event https://www.figma.com/file/zY7BS9fR1huZ0CieHf3Dm8/MI-Workflow-Change?node-id=182%3A22493

Published Flow

If a user wants to edit a published Significant Event, they first need to view it and then click Edit.
Once an Edit is created, the Create diff view draft is shown  https://www.figma.com/file/zY7BS9fR1huZ0CieHf3Dm8/MI-Workflow-Change?node-id=279%3A30948
When saved, draft moves to In Progress diff view
When saved, draft moves to In Review diff view
When requested, draft moves to In Admin Review diff view
When approved, Significant Event is published, and users are brought back to the Details page with the new published date. https://www.figma.com/file/zY7BS9fR1huZ0CieHf3Dm8/MI-Workflow-Change?node-id=438%3A27104

Closing this issue as we have released the new MI workflow and do not plan to make these additional changes.


[SMALLFIX] [branch-1.6] Retry IOException for AbstractClient connect

This PR fixes the issue that 1.6 start local cluster failure with NOSASL mode.
Without this PR:
2017-09-26 19:08:20,336 ERROR ProcessUtils - Uncaught exception while running Alluxio worker, stopping it and exiting.
java.lang.RuntimeException: Failed to get a worker id from block master: org.apache.thrift.transport.TTransportException: java.net.SocketException: Connection reset
	at alluxio.worker.block.DefaultBlockWorker.start(DefaultBlockWorker.java:202)
	at alluxio.worker.block.DefaultBlockWorker.start(DefaultBlockWorker.java:75)
	at alluxio.Registry.start(Registry.java:128)
	at alluxio.worker.AlluxioWorkerProcess.startWorkers(AlluxioWorkerProcess.java:242)
	at alluxio.worker.AlluxioWorkerProcess.start(AlluxioWorkerProcess.java:217)
	at alluxio.ProcessUtils.run(ProcessUtils.java:31)
	at alluxio.worker.AlluxioWorker.main(AlluxioWorker.java:55)

With this PR, this problem is resolved.
Root cause:
In checkVersion, any TException including TTransportException are wrapped with IOException. We should always retry those possibly transient exceptions, unless we know specific ones that should not be retried.
  protected void checkVersion(AlluxioService.Client client, long version) throws IOException {
    if (mServiceVersion == Constants.UNKNOWN_SERVICE_VERSION) {
      try {
        mServiceVersion = client.getServiceVersion(new GetServiceVersionTOptions()).getVersion();
      } catch (TException e) {
        throw new IOException(e);
      }
      if (mServiceVersion != version) {
        throw new IOException(ExceptionMessage.INCOMPATIBLE_VERSION.getMessage(getServiceName(),
            version, mServiceVersion));
      }
    }
  }

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17061/
Test PASSed.


Monitor sensible UpdateReferralProgram and UpdateVolumeDiscountProgram proposals in fuzzing runs

In overnight fuzzing runs, after a number of steps, "sensible" UpdateReferralProgram and UpdateVolumeDiscountProgram proposals are suddenly rejected before they reach core and are exposed in the governances API.
PR #613 allows vega_sim.api.helpers.ProposalNotAcceptedError to unblock overnight testing and adds some syncs which may resolve the issue.
Ticket is to monitor the affects of the above PR. If the errors still occur then the issue will need to be investigated further

Closing as error no longer occurring after fix.


How to rebase binary after the binary has been loaded using API？

I want to rebase an binary using API, but got follows errors.
>>> target_block = currentProgram.memory.blocks[0]
>>> target_block
ram[00000000:00123456]
>>> currentProgram.memory.moveBlock(target_block, 0x10000, None)
Traceback (most recent call last):
  File "python", line 1, in <module>
TypeError: moveBlock(): 2nd arg can't be coerced to ghidra.program.model.address.Address

What is the correct method to rebase an binary?

moveBlock is right method, but type of second argument should be Address.

@saruman9 Yes, but How to use Address type? Is there any python example?

Tried Address and got new error.
>>> target_block = currentProgram.memory.blocks[0]
>>> target_address = target_block.getStart()
>>> target_address = target_address.add(0x1000)
>>> type(target_address)
<type 'ghidra.program.model.address.GenericAddress'>
>>> currentProgram.memory.moveBlock(target_block, target_address, None)
Traceback (most recent call last):
  File "python", line 1, in <module>
	at ghidra.program.database.module.TreeManager.moveAddressRange(TreeManager.java:500)
	at ghidra.program.database.ProgramDB.moveAddressRange(ProgramDB.java:2199)
	at ghidra.program.database.mem.MemoryMapDB.moveBlock(MemoryMapDB.java:680)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:567)
java.lang.NullPointerException: java.lang.NullPointerException

You should set monitor parameter. You can use:

dummy monitor;
current monitor.

For first case:
from ghidra.util.task import TaskMonitor
currentProgram.getMemory().moveBlock(target_block, target_address, TaskMonitor.DUMMY)

For second case:
currentProgram.getMemory().moveBlock(target_block, target_address, monitor)

@saruman9 Thanks! It's work.


gamemode causes disconnect if not 1 or 0

This isn't really a big deal, but using /gamemode will cause a disconnect if anything other than 1 or 0 is put after it. Didn't see this on here, so I thought I would let you know.

I confirm the issue, while its not a problem(as only 0 and 1 are in use) I tend to hit the wrong key and get booted

If this issue is fixed, can it be closed? We have way too many stale issues.

@bryanburke I accidentally set an invalid gamemode the other day and was not kicked. I'm guessing @dola fixed it with the above.

I never closed this because I didn't test it in detail. But I think it should be fixed like that.


Workorder Sidesheet Mat status - MCCR status

Put on hold. We need proper requirement from customer.

Solution is to keep "Material status" and change "MCCR status" to "MC status" with the same values to the columns in the table view

Reopened to set to Done (is tested/verified).


Remove <3.12 Requirement for Python

Describe the bug
Since pandas-stubs has an upper Python version bound, all downstream projects that use poetry to manage dependencies have to set their upper Python version bound to <3.12. While this doesn't necessarily cause any issues, it would be great for downstream projects to be able to leave the version range open (i.e. >=3.8)
To Reproduce

Add pandas-stubs as a dependency to a poetry project
Run poetry lock
Check if the output says to set the upper Python version bound to <3.12

Duplicate of https://github.com/pandas-dev/pandas-stubs/issues/625.

Closing as it is dup of #625


Bump Ossec version to 2.8.1

This discussion was started in PR https://github.com/jtimberman/ossec-cookbook/pull/31
Moving here
PRs related to update
https://github.com/jtimberman/ossec-cookbook/pull/31
https://github.com/jtimberman/ossec-cookbook/pull/38

Others PR's discussed as being merged as part of version bump...
https://github.com/jtimberman/ossec-cookbook/pull/33
https://github.com/jtimberman/ossec-cookbook/pull/34

Any updates on this??

Any updates on this??

Ossec is coming from the upstream repo now so you should always get the latest.


Hourly Forecasts

Allow the user to put a time + date in to get an idea of what the weather will be like then. At the moment, it only displays the weather right now.

Team 2 is working on this issue

[x] @mukhsadr
[x] @carolgeng


OS X "Add period with double-space breaks Editor

Do you want to request a feature or report a bug?
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/gmertk/e61z7nfa/.
What is the expected behavior?
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

Closing in favour of https://github.com/facebook/draft-js/issues/2422


Support for milliseconds

Not supporting milliseconds
When zooming into a timeseries the $__timeWindow do not support milliseconds.
Reproduce
Grafana query string used
SELECT $__time(timestamp), $__value(data) FROM table.part_raw WHERE tag == 'sensor' AND $__timeFilter(timestamp) GROUP BY $__timeWindow(timestamp)

Zoom in to a high resolution timeseries
Resulting SQL:

SELECT
  window.start,
  avg(data) AS value
FROM
  table.part_raw
WHERE
  tag == 'sensor'
  AND timestamp BETWEEN '2023-06-21 17:28:10'
  AND '2023-06-21 17:33:12'
GROUP BY
  window(timestamp, '')

Notice the lack of proper time bin window in the group by.
Expected behavior
Support of milliseconds when zooming
SELECT
  window.start,
  avg(data) AS value
FROM
  table.part_raw
WHERE
  tag == 'sensor'
  AND timestamp BETWEEN '2023-06-21 17:28:10'
  AND '2023-06-21 17:33:12'
GROUP BY
  window(timestamp, '1 milliseconds')

Workaround
Fixing Grafana "Min Interval" to 1 second
Environment:
Plugin Version: 1.2.4
Grafana Version: 10.4.0
ADB Serverless: Current (v 2024.15)

Hi @jarandmoen
Thanks a lot for opening the issue!
I added milliseconds support for the macro now. The v1.2.5 release should resolve the issue.


Fix icon for "Logout"

We currently have a "settings" icon for the "Logout" button in the dashboard:

Here's the line it's on: https://github.com/papercups-io/papercups/blob/master/assets/src/components/Dashboard.tsx#L143
Find a more appropriate icon here: https://ant.design/components/icon/
And then import in here https://github.com/papercups-io/papercups/blob/master/assets/src/components/icons.tsx before replacing the existing icon

Fixed in https://github.com/papercups-io/papercups/pull/64


Explore AssemblyScript integration

We have a PR https://github.com/playcanvas/engine/pull/2213 which explores one way of using AssemblyScript (WASM) modules by Playcanvas. I would like to explore a way to build custom functions using AssemblyScript, which can be called by the main engine in JS to optimize hot functions / but perhaps do more in the future.
Main objectives:

build system should build the engine as currently, but build wasm module along it from separate ts files.
perhaps https://www.npmjs.com/package/rollup-plugin-assemblyscript could be useful here
but also this is interesting as it allows to embed the wasm module into main script
https://blog.scottlogic.com/2017/10/30/migrating-d3-force-layout-to-webassembly.html
https://github.com/rollup/plugins/tree/master/packages/wasm

AssemblyScript allows code to be compiled to WASM, but also generate TS code. It would be good to have this as an option during development / debugging, allowing easy debugging of AssemblyScript code in form of TS.

Later:

AssemblyScript has support for SIMD and atomics (experimental features), it'd be great to see if these can be used. I'm not sure what the impact is of the code using these still being able to compile to TS.

As far I know AssemblyScript allows code to be compiled to WASM, but also generate TS code is not exactly true. AS has these outputs:
asc --help
Output

  --outFile, -o         Specifies the output file. File extension indicates format.
  --binaryFile, -b      Specifies the binary output file (.wasm).
  --textFile, -t        Specifies the text output file (.wat).
  --jsFile, -j          Specifies the JavaScript (via wasm2js) output file (.js).
  --idlFile, -i         Specifies the WebIDL output file (.webidl).
  --tsdFile, -d         Specifies the TypeScript definition output file (.d.ts).

And the wasm2js output looks like this:
function assembly_Quat_Quat_clone($0) {
  $0 = $0 | 0;
  return assembly_Quat_Quat_constructor(0, HEAPF32[$0 >> 2], HEAPF32[($0 + 4 | 0) >> 2], HEAPF32[($0 + 8 | 0) >> 2], HEAPF32[($0 + 12 | 0) >> 2]) | 0;
 }

 function assembly_Quat_Quat_conjugate($0) {
  $0 = $0 | 0;
  HEAPF32[$0 >> 2] = Math_fround(HEAPF32[$0 >> 2] * Math_fround(-1.0));
  HEAPF32[($0 + 4 | 0) >> 2] = Math_fround(HEAPF32[($0 + 4 | 0) >> 2] * Math_fround(-1.0));
  HEAPF32[($0 + 8 | 0) >> 2] = Math_fround(HEAPF32[($0 + 8 | 0) >> 2] * Math_fround(-1.0));
  return $0 | 0;
 }

(not exactly debug friendly)
The other option you might refer to is: https://www.assemblyscript.org/portability.html
In this case AS generates nothing, but the .ts-files are consumed directly by e.g. rollup and AS should provide polyfills for stuff like Mathf.sincos
Small problem could be: The portable standard library is still pretty much a work in progress and we are extending it as we go while working on the compiler.
Just the info I found so far, I like your idea to test the AS code from pure JS (because that makes it way easier to debug/test), I just need to investigate further how to do it best in my PR 😅

I integrated your idea to use AssemblyScript from pure JavaScript for debugging purposes in my PR now. It was a bit more tricky than expected, because I tried to optimize and strip down everything that isn't "really" needed for the AS code:

Only allow new pc.Vec3(1, 2, 3), not new pc.Vec3([1, 2, 3])
Remove toString() methods to not mess around with strings in AS
Removed optional arguments (every argument is required in AS math code)
Normal Mat3/Mat4 uses Float32Array .data internally, which I replaced with direct access fields named m0, m1, m2, ...  to have the least amount of indirect data access possible

So the job of the JavaScript wrapper over the AssemblyScript code resulted in readding these four points. As an example to readd the old abilities, this is how the pc.Quat JS wrapper over the AS code looks like:
import { Vec3 } from "./vec3";

import { Quat as Quat_AS } from "../../assembly/Quat";

class Quat extends Quat_AS {
    constructor(x?: any, y?: any, z?: any, w?: any) {
        if (x && x.length === 4) {
            super(
                x[0],
                x[1],
                x[2],
                x[3]
            );
        } else {
            super(
                (x === undefined) ? 0 : x,
                (y === undefined) ? 0 : y,
                (z === undefined) ? 0 : z,
                (w === undefined) ? 1 : w
            );
        }
    }

    getEulerAngles(eulers) {
        if (eulers === undefined) {
            eulers = new Vec3();
        }
        return Quat_AS.prototype.getEulerAngles.call(this, eulers);
    }

    transformVector(vec, res) {
        if (res === undefined) {
            res = new Vec3();
        }
        return Quat_AS.prototype.transformVector.call(this, vec, res);
    }

    toString() {
        return '[' + this.x + ', ' + this.y + ', ' + this.z + ', ' + this.w + ']';
    }

    toStringFixed(n) {
        return '[' + this.x.toFixed(n) + ', ' + this.y.toFixed(n) + ', ' + this.z.toFixed(n) + ', ' + this.w.toFixed(n) + ']';
    }
}

Object.defineProperty(Quat, 'IDENTITY', {
    get: (function () {
        var identity = new Quat();
        return function () {
            return identity;
        };
    }())
});

Object.defineProperty(Quat, 'ZERO', {
    get: (function () {
        var zero = new Quat(0, 0, 0, 0);
        return function () {
            return zero;
        };
    }())
});

export { Quat };

@kungfooman - I tried to integrate rollup-plugin-assemblyscript, to allow assembly script file (.as) to build into wasm module, and be usable inside the engine, but have issues with this. Any idea how this could be made to work? (my rollup / node build skiils are zero).
https://github.com/playcanvas/engine/commit/5c3a124f5ce0a37ef71479f90e15e979b9cfceea

@mvaligursky Thank you for trying! I am also trying around to see what would make most sense for easily/quickly testing all possible permutations in the example browser, and I am not sure if rollup-plugin-assemblyscript is the best way to go yet (e.g. a custom plugin for bundling .wasm into .js could be a better fit).
My example browser currently looks like this:

Because we have so many different builds and flavors now... JS/NORMAL, JS/PROFILER, X64/DEBUG or X32/PROFILER etc.
To exhaust every possible permutation the build step should create 6 .wasm integrated single-request .js files:
AS32
AS64
AS32 (DEBUG)
AS64 (DEBUG)
AS32 (DEBUG PROFILER)
AS64 (DEBUG PROFILER)

List could increase in future, when WebAssembly supports 16bit and/or 128bit floating points. 😅
And then another question, should we also differentiate between .wasm bundled/unbundled versions? Browsers are optimized to load/prepare the .wasm code straight as the data comes over the network (called Streaming Compilation), and bundling it into .js de-optimizes that path while increasing the .js parsing time and size (it may be just 10 KB and a few milliseconds extra parsing time or so).
All ideas are welcome, I am still fleshing this out for my PR


Phoenix 1.7 compilers warning

I am running into a warning from: https://github.com/danschultzer/pow/blob/master/mix.exs#L13
1.7 has this line removed, and apparently it's throwing the warning from having the line in this file, too.
Is it possible to create a separate branch for 1.7 with this line removed? Making the assumption that others running > 1.7 will still need the line.
warning: the :phoenix compiler is no longer required in your mix.exs.

Please find the following line in your mix.exs and remove the :phoenix entry:

    compilers: [..., :phoenix, ...] ++ Mix.compilers(),

  (phoenix 1.7.0-rc.1) lib/mix/tasks/compile.phoenix.ex:8: Mix.Tasks.Compile.Phoenix.run/1
  (mix 1.14.0) lib/mix/task.ex:421: anonymous fn/3 in Mix.Task.run_task/4
  (mix 1.14.0) lib/mix/tasks/compile.all.ex:92: Mix.Tasks.Compile.All.run_compiler/2
  (mix 1.14.0) lib/mix/tasks/compile.all.ex:72: Mix.Tasks.Compile.All.compile/4
  (mix 1.14.0) lib/mix/tasks/compile.all.ex:59: Mix.Tasks.Compile.All.with_logger_app/2
  (mix 1.14.0) lib/mix/tasks/compile.all.ex:33: Mix.Tasks.Compile.All.run/1

==> pow

See: https://github.com/phoenixframework/phoenix/issues/5201

Thanks! I realized that the compiler wasn't necessary since Elixir 1.11. I have removed it in #684. Will work on full Phoenix 1.7 support and make a release.


⚠ Samsung has degraded performance

In d3bf1c2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2497 ms

Resolved: Samsung performance has improved in 6b332f4.


Inconsistent link styles in main nav

We currently underline on hover: headers & links in content and in "on this page". But we don't underline links in the main nav. The hover states of the main nav items are also different.
It would be great to have the same link styles, so users don't get confused about what is clickable or not.

Can you please include what you think should be different? The main nav is made to replicate the nav of blockstack.org

I updated the description. @jasperjansz's opinion would be great


[swift-3.1-branch] Delete the unused integer protocols

The protocols were included in Beta 2 by mistake and should be removed.
rdar://problem/30341102

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b23076ed5152dec60ec38a07716b8960aaa9efac
Test requested by - @moiseev

@swift-ci Please test macOS platform

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b23076ed5152dec60ec38a07716b8960aaa9efac
Test requested by - @moiseev

@swift-ci Please test macOS platform

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b23076ed5152dec60ec38a07716b8960aaa9efac
Test requested by - @natecook1000

@swift-ci Please test macOS platform

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b23076ed5152dec60ec38a07716b8960aaa9efac
Test requested by - @natecook1000

Doesn't look like the failing test is related to the change, does this need rebasing to fix some since-resolved bug elsewhere?

@swift-ci Please clean test macOS platform


Let mpp task send remote read request after it is scheduled.

What problem does this PR solve?
Issue Number: ref #6233
Problem Summary: currently, mpp task will send remote read requests instantly even before schedule. this will consume resources uselessly.
What is changed and how it works?
Let mpp task send remote read request after it is scheduled.
Check List
Tests

[ ] Unit test

[ ] Integration test

[x] Manual test (add detailed scripts or steps below)

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/merge


on k8s application mode, stop job with savepoint.

What problem does this PR solve?
Now, on k8s application mode, when we stop job with savepoint , it can not stop correctly。
if  the user do not provide the custom savepoint path ,we will use the state.savepoints.dir of the flink configuration

good job. 2022 happy new year!


Integrate review feedback into Sharepoint baseline

🗣 Description
This update includes the following changes to the M365 SharePoint security configuration baseline:

Changes to improve overall consistency of format and language throughout
Grammar and spelling fixes
Language and verbiage updates for increased reader clarity

This update does NOT include any materially significant changes to the number of or content in policy items in the baseline itself that would require a change in settings to align with the baseline recommendations.
💭 Motivation and context
The updates included further refine and improve the overall readability and clarity of the baseline document. The result should be a baseline that is easier to interpret and use as a reference for M365 tenant administrators.
Closes #537
🧪 Testing
Compare the separately provided Word version with track changes of the SharePoint baseline document with the changes in the markdown in this branch. Accepted/modified suggested changes as appropriate and mirrored in markdown, rejected and additional changes commented in Word and sync'd to markdown as needed.
Manual review of markdown and ensure that the automated markdown test on the PR passes.

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Create a release.

@ahuynhMITRE Please follow all hyperlinks to ensure that they work appropriately including between sections of the document.

I also ran the markdown validation test as well as run the product and compared the baseline. it all matches.


[Question] If I deploy smart contract 2 times - how can I interact with first one deploy?

After I deploy smart contract using
near deploy <created-account> build/hello_near.wasm

I may use it like
near view <created-account> get_greeting

But I cant understand, where did CLI save contract address.
Question - If I deploy smart contract 2 times - how can I interact with first one deploy?

the most simple way would be just to remove and redeploy contract
https://github.com/near/near-cli-rs/issues/109


CASMCMS-9191: Provide troubleshooting/remediation for CFS components with 0-length ID fields

This provides information on how to identify and correct the problem originally reported in CASMTRIAGE-7462.
Backports forthcoming.

/backport release/1.5


sparse.linalg.svds inconsistency between docstring and code

My apologies for not providing a code example, but my example reads in a large matrix, and the problem seems simple enough to address without an example.
See the svds function defined at line 1724 here:: scipy/arpack.py at master · scipy/scipy
For the 2nd argument, k, the docstring reads:
    k : int, optional
        Number of singular values and vectors to compute.
        Must be 1 <= k < min(A.shape).

In contrast, in the code at line 1816, the check on k is as follows:
    if k <= 0 or k >= min(n, m):
        raise ValueError("k must be between 1 and min(A.shape), k=%d" % k)

I believe the check in the docstring is the correct one. I tried to get k=4 singular values from a 4-row matrix, and I get an error:
~/anaconda/lib/python3.8/site-packages/scipy/sparse/linalg/eigen/arpack/arpack.py in svds(A, k, ncv, tol, which, v0, maxiter, return_singular_vectors, solver)
   1815
   1816     if k <= 0 or k >= min(n, m):
-> 1817         raise ValueError("k must be between 1 and min(A.shape), k=%d" % k)
   1818
   1819     if isinstance(A, LinearOperator):

ValueError: k must be between 1 and min(A.shape), k=4

Yet for the image array I am processing:
In [1]: min(image.shape)
Out[1]: 4

Incidentally, the use of "between" in the error message is ambiguous (or just incorrect). k=1 is certainly valid.  The docstring has better wording.

Sorry, this issue is not correctly described. I'll double-check and try again.


No xpython executable with the 0.7.1 wheel

Something we noticed in the debugger tests after updating to 0.7.1:
https://github.com/jupyterlab/debugger/pull/415/checks?check_run_id=614674756
Also reproducible locally with:
(test)
$ pip show xeus-python
Name: xeus-python
Version: 0.7.1
Summary: A wheel for xeus-python
Home-page: UNKNOWN
Author: Sylvain Corlay, Johan Mabille
Author-email: UNKNOWN
License: UNKNOWN
Location: /home/jtp/miniconda/envs/test/lib/python3.8/site-packages
Requires: pygments, jedi
Required-by:

(test)
$ which xpython
xpython not found

With 0.6.8:
(test)
$ pip show xeus-python
Name: xeus-python
Version: 0.6.8
Summary: A wheel for xeus-python
Home-page: UNKNOWN
Author: Sylvain Corlay, Johan Mabille
Author-email: UNKNOWN
License: UNKNOWN
Location: /home/jtp/miniconda/envs/test/lib/python3.8/site-packages
Requires: jedi, pygments
Required-by:

(test)
$ which xpython
/home/jtp/miniconda/envs/test/bin/xpython

This is actually expected. Instead can use the launcher:
python -m xpython_launcher


Migrate to postgresql

If we can migrate to postgresql we have more flexibility with data structures and also reporting tool choices are more

We can use helihost server to host the postgresql db

Not pursuing this further because

heliohost seems to be a bit slow
pythonanywhere does not allow the communication with heliohost [not whitelisted]

Note: I have HelioHost account, free postgresql server. 2 DBs are available with remote access enabled
user<EMAIL_ADDRESS>


A-Boat-Sentinal

[ * ] I have read the steps to getting a blot
[ * ] I am submitting art that...

[ * ] is algorithmically generated (will change each time the program is run)
[ * ] is drawable on a blot (fits in the work area & doesn't overlap too much)
[ * ] is original (not copied from somewhere else)
[ * ] doesn't call Math.random() (See the documentation on [randomness]

I tried to make a ship with the German flag on it

Just an update, I will be closing this PR. Please create a new PR once you have updated your art! We are doing this due to new management of the PR system.


What does the string candidate ["422", "4XX", "default"] mean?

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from fastapi.openapi.utils import get_openapi
from fastapi.exceptions import RequestValidationError
from fastapi import FastAPI, Request, Response, status
import uvicorn
from pydantic import BaseModel
from fastapi import Query

app = FastAPI()

class Payload(BaseModel):
    test: str = Query(
        ..., min_length=100, max_length=200, title="test"
    )

@app.put("/items/",
responses={
        200: {
            "description": "OK"
        },
        400: {
            "description": """Validation Error

            This is the true status_code returned when a Validation Error occurs
            """
        },
        "4XX": {
            "description": """Validation Error

            ["422", "4XX", "default"] has a special meaning.
            What does the string candidate ["422", "4XX", "default"] mean?
            Suppress the appearance of 422 in the document.
            If I don't define this, 422 will appear in the documentation.

            https://github.com/tiangolo/fastapi/blob/2b54432a9c78730b0dd69fca8f15d932d5a31d6b/fastapi/openapi/utils.py#L332
            """
        },
    })
async def read_items(
    payload: Payload,
):
    return [{"name": "Foo"}]

@app.exception_handler(RequestValidationError)
async def validation_exception_handler(request: Request, exc: RequestValidationError):
    return Response(
        status_code=status.HTTP_400_BAD_REQUEST,
        content="validation_failed",
    )

def custom_openapi():
    if app.openapi_schema:
        return app.openapi_schema
    openapi_schema = get_openapi(
        title="Custom title",
        version="2.5.0",
        description="This is a very custom OpenAPI schema",
        routes=app.routes,
    )
    openapi_schema["info"]["x-logo"] = {
        "url": "https://fastapi.tiangolo.com/img/logo-margin/logo-teal.png"
    }
    app.openapi_schema = openapi_schema
    return app.openapi_schema

app.openapi = custom_openapi

if __name__ == "__main__":
    uvicorn.run(
        app,
        host="<IP_ADDRESS>",
        port=8085,
    )

Description

I want to change the status_code of the validation error from 422 to 400
Changed implementation by @ app.exception_handler (RequestValidationError)
However, status_code 422 appears in the document.
To remove status_code 422 from the document, I need to write one of the following in the document

"422"
"4XX"
"default"

Why ?
What does the string candidate ["422", "4XX", "default"] mean?
I don't want to document this because "422", "4XX" and "default" are all lies
reference: https://github.com/tiangolo/fastapi/blob/2b54432a9c78730b0dd69fca8f15d932d5a31d6b/fastapi/openapi/utils.py#L332

Operating System
Linux
Operating System Details
No response
FastAPI Version
0.78.0
Python Version
3.10.2
Additional Context
No response

Added at this https://github.com/tiangolo/fastapi/pull/435


[WIP] [Efficient Metadata Operations] [DEPENDS_ON PR#2362] Complete the code to handle partial seal notifications from helix.

Codecov Report
Base: 73.21% // Head: 14.48% // Decreases project coverage by -58.73% :warning:

Coverage data is based on head (1097306) compared to base (86ae0f7).
Patch coverage: 39.31% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2375       +/-   ##
=============================================
- Coverage     73.21%   14.48%   -58.73%
+ Complexity    10694     2368     -8326
=============================================
  Files           767      767
  Lines         59563    59646       +83
  Branches       7297     7317       +20
=============================================
- Hits          43607     8639    -34968
- Misses        13560    50491    +36931
+ Partials       2396      516     -1880

Impacted Files
Coverage Δ

...om/github/ambry/clustermap/ClusterParticipant.java
0.00% <ø> (-28.58%)
:arrow_down:

...va/com/github/ambry/clustermap/AmbryPartition.java
1.49% <0.00%> (-68.69%)
:arrow_down:

...a/com/github/ambry/clustermap/ClusterMapUtils.java
39.19% <0.00%> (-50.65%)
:arrow_down:

...ub/ambry/clustermap/HelixBootstrapUpgradeUtil.java
0.00% <0.00%> (-79.98%)
:arrow_down:

...m/github/ambry/clustermap/HelixClusterManager.java
0.00% <0.00%> (-88.76%)
:arrow_down:

.../com/github/ambry/clustermap/HelixParticipant.java
36.68% <0.00%> (-46.40%)
:arrow_down:

...y/clustermap/RecoveryTestClusterAgentsFactory.java
0.00% <ø> (ø)

...b/ambry/clustermap/StaticClusterAgentsFactory.java
0.00% <ø> (-30.77%)
:arrow_down:

...github/ambry/clustermap/ReplicaStatusDelegate.java
87.50% <33.33%> (+11.02%)
:arrow_up:

...rc/main/java/com/github/ambry/store/BlobStore.java
76.73% <64.10%> (-5.62%)
:arrow_down:

... and 608 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[mock_uss] avoid full file scan when querying interaction log

This PR attempts to improve the performance of the /mock_uss/interuss_logging/logs GET endpoint by.
It:

updates the mock USS's interaction logger to store a full timestamp in the relevant filename
updates the endpoint logic to filter out files that are older than the required time

Test plan: the qualifier is still able to run locally against an updated mock_uss, and the scenarios that rely on the interuss_logging/logs  endpoint are passing.
This is not guaranteed to solve #677 but is very likely to improve the situation.

Some relevant observations I made while investigating scenarios that failed with the new version of the interaction logging endpoint, and the reason for adding an additional time buffer in requests(*)
At least on my local setup, there is a slight clock skew between running containers and my OS: under certain circumstances (which happens to be often or always for me), the mock_uss containers runs slightly behind. As a result interactions are timestamped with a too old timestamp and are ignored when qualifier specifies the time since which interactions should be returned.
Here is a sample of the logged interactions:
julien@Woosh scdsc_a_interaction_logs % ls -l
total 64
-rw-r--r--  1 julien  staff  2589 Aug 16 10:19 000000_Outgoing_POST_2024-08-16T08:19:49.217310Z.json
-rw-r--r--  1 julien  staff  2058 Aug 16 10:19 000001_Incoming_GET_2024-08-16T08:19:49.229415Z.json
-rw-r--r--  1 julien  staff  2590 Aug 16 10:19 000002_Outgoing_POST_2024-08-16T08:19:49.355719Z.json
-rw-r--r--  1 julien  staff  2059 Aug 16 10:19 000003_Incoming_GET_2024-08-16T08:19:49.366266Z.json
-rw-r--r--  1 julien  staff  2047 Aug 16 10:19 000004_Incoming_GET_2024-08-16T08:19:49.398353Z.json
-rw-r--r--  1 julien  staff  2962 Aug 16 10:19 000005_Incoming_POST_2024-08-16T08:19:49.418825Z.json
-rw-r--r--  1 julien  staff  1856 Aug 16 10:19 000006_Incoming_POST_2024-08-16T08:19:56.497142Z.json
-rw-r--r--  1 julien  staff  1534 Aug 16 10:19 000007_Outgoing_POST_2024-08-16T08:19:56.517779Z.json

The relevant interaction here is one of the two first Outgoing_POST ones, which both have a timestamp that is slightly before the time that the qualifier will use, as illustrated in the snapshot below:

(The timestamp is passed in the from_time in this query http://scdsc.log.uss6.localutm/mock_uss/interuss_logging/logs?from_time=2024-08-16T08:19:49.377425Z)
08:19:49.377425 is just after the second outgoing request that was made at 08:19:49.355719
(*) we could consider adding this buffer as a default in the library code that queries the interactions, instead of leaving that responsibility with the caller: opinions welcome. Note that we already decided against having this buffer on the server side, as we want our mock_uss to implement precise APIs.

Both comments addressed.


Geolocation.watchposition stops working when app in background or device locked

Hello!
As almost everybody here, I'm trying to capture device`s geolocation intending to track my company cars when delivering.
For that, I'm using Geolocation.watchposition and it's working very well on IOS and most part of android devices I've been testing. However, and only on Samsung devices with Knox Library, the location services stop working when I lock ou minimize my app. When it comes to foreground, everything gets working again, but I loose every coordinate I got when locked ou in background.
Would someone know whats the catch?
10x in advance for any help

:wave: This library (and most other location ones) are designed to be used when the app is in the foreground. This is because running code in the background is more complicated and would lead to a much more complicated library. Most app do not need to track location in the background, so it's usually not worth supporting.
As your use case does require background location tracking, your best bet is to use this React Native library, which is specifically designed to support it:
https://github.com/transistorsoft/react-native-background-geolocation

https://github.com/transistorsoft/react-native-background-geolocation library is paid for android.

To make background location work:
iOS:
In order to enable geolocation in the background, you need to include the 'NSLocationAlwaysUsageDescription' key in Info.plist and add location as a background mode in the 'Capabilities' tab in Xcode.
Android 10 and above( API >= 29):
You need to add <uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION" /> and also check & request permission at runtime.

in 2024 where existing many applications the geolocation like uber, 99, in-drive and others , i think is essentials processing in background

I hope it will help: https://github.com/michalchudziak/react-native-geolocation/blob/master/example/src/configs/BackgroundLocationUpdates.tsx#L28


spike (1 day) - triggering airflow DAGS with python

What is this
We'll want to be able to trigger airflow DAGs from python.
It feels like a common use case so have a look around for packages or plugins to do this.
ideally it'd be pure python rather than a plugin as it'd be nice to reuse the same component to trigger the initial DAG from a lambda, but I'm not wedded to it, be practical. Airflow also has an api so working our how to trigger a dag via an api PUT/POST wold also be of use.
What to do
Investigate the options and try and implement a few different ways of doing this.
Spin up a local airflow via this and (I think, read the docs) docker-compose up  to use while developing/playing.
Accetpance Critiera

[ ] Feed back to the team examples of how to trigger airflow Dags with python.

Clone or fork the [AWS MWAA local runner[(https://github.com/aws/aws-mwaa-local-runner) repo - my fork is here: https://github.com/SarahJohnsonONS/aws-mwaa-local-runner
The README is very helpful - follow the instructions in the "Get started" section to build the image and then run the local Airflow environment to see the DAGs that have already been created.
I followed this tutorial in my_other_dag.py, and created my own DAG in my_dag.py, based on the decorator approach here.
Next steps: figure out how to use the Airflow REST API and/or the Airflow Python client.


Add debug syncing commands for dymint

The following cli command should reveal:

[ ] height of last block received from p2p
[ ] height of last block received from da
[ ] last block applied source (da or gossip)
[ ] number of accumulated blocks pending to be applied (cache occupancy)
[ ] height of lowest block pending in cache
[ ] height of highest received block

closing in favor of https://github.com/dymensionxyz/dymint/issues/978


[pixivFANBOX] Embed raises an unsupported url provider 'fanbox.creator' error

Prerequisites

[x] Did you read FAQ section in readme.md?
[x] Did you test with the latest releases or commit ?
[x] Did you search for existing issues in Issues?

Description
Unsupported embed type fanbox.creator which is not even a valid URL.
The post contains a ZIP file, is it a pixivFANBOX change? This did not happen before.
Steps to Reproduce

Run PixivUtil2 with f3
Attempt to download example post 4384185 (NSFW, public post)

Expected behavior: Getting post cover, pictures, ZIP file and HTML.
Actual behavior: PixivUtil2 throws a fatal error and stops. If using f2 with the creator, it stops and exits upon reaching the post.
Log:
Error processing FANBOX post: 4384185 ==> Unsupported url embed provider = fanbox.creator for post = 4384185, please update content_provider.json.
Versions
20220804
20220825

updated https://github.com/Nandaka/PixivUtil2/blob/master/content_provider.json
You can just replace your copy with the updated one.

Working as intended with the provided file additions. Closing, thanks a lot for the quick reply!


مشكلة  [ :There is a problem with PHP session. We can not start it.: ]

Kleeja error :
[ :There is a problem with PHP session. We can not start it.: ]
Session Error!
Visit Kleeja Website for more details.
Version . has been used
php 7.4.1
php 7.4.30
php 8.0.20

Hi @Abu-haron did you change any thing in the code, or using a plugin ?


improve Haskell makers

only enable makers that are available
use Stack to run makers, when Stack is available
add a maker for Liquid Haskell

@benekastah @nathyong @expipiplus1 @etcinit
y'all have contributed to the Haskell makers before, if you are interested and inclined, your feedback on this change would be much appreciated!

There seems to be a bit of duplication in that file around finding the stack executable and using it. I don't know if vimscript makes this easy to abstract over.
I don't use Stack, but as long as it doesn't interfere with running these things under Nix then I'm happy.
Liquid haskell maker looks good!

Ah, you noticed that. ;) Ok, DRYed it up, please take another look.

This is a bit better. I added comments to explain what its doing too.

@bonds
Is this good to go?
Can I squash it into one commit?  You could also do so and force-push to this branch, in case you want to massage the commit message.

@blueyed good to go and squashed with updated commit message.

Thanks!


add npm audit to install script to surface supply chain issues

Sub #658
User story
As a user I want to be as confident as possible that there are no vulnerabilities in the libraries we rely on to run IF and its plugins.
Rationale
We aim to be dependency minimal, but we do use several libraries and we install plugins that have their own set of dependencies. We want to see quickly whether there are any vulnerabilities in the total dependency set. We can do this easily by adding npm audit to our install script for our repositories and recommend it to plugin builders too via our documentation.
Implementation details

[ ] add npm audit to out install script
[ ] add a note to our plugin builders guide that recommends doing the same

Priority
3/5
Size
XS
What does "done" look like?
install script includes npm audit
Deadline
tbc

as per @jawache comment on #658, when you have a chance, please refine and add help-wanted

We can just close this - the audit report is already done as part of npm i


HV-1368 Update NotEmptyDef, NotBlankDef... to use the specification c…

…onstraints

https://hibernate.atlassian.net/browse/HV-1368

Jenkins, retest this please


processors not applied in the right order

Let's take a submission example:
   true
Assume two processors, clean-string followed by true-false. Currently, it seems as though they are used in the wrong order (if processors A and B, the raw input will be first processed with B then with A which isn't normal). The result of that issue is:

The true-false processor can't find a matching equivalent because of the extra spaces
The clean-string removes the spaces, final input = true
But the expected value is True so the user gets 0

I would like to contribute, but since I am not able to download and use this application, I am not able to understand how this works. I would really appreciate if u add more in the wiki of Sphinix section.

The wiki is definitely to be improved, I will try to at least update and finish the getting started tomorrow. If you have specific questions concerning how this particular issue may be resolved, I'll be happy to guide you.


backblaze and default b2-chunk-size settings

HI,
This in in reference to the b2-chunk-size setting discussed in https://github.com/ncw/rclone/issues/456
I was trying to debug a strange go issue that turned out to be an out-of-memory error, and only later found out that the default chunk size is 96M, even though I'm syncing a folder tree with lots of small files (no files close to that size). Unfortunately, that also means that each b2 thread (I was using --transfers 32) takes almost 100mb of memory.
If there's no need to chunk (under b2-upload-cutoff), can it default to a smaller chunk value (e.g. buffer-size or something)? Or can you not allocate memory that way?

It does say this in the docs, maybe it could be clearer?
96MB used to be the minimum size for a chunk, but b2 changed it so that it is now 5MB.  I think 96MB is still the recommended chunk size which is why I haven't changed the default.
(Note B2 counts MB = 1,000,000 bytes whereas rclone counts MB as 1,048,576 bytes)

If there's no need to chunk (under b2-upload-cutoff), can it default to a smaller chunk value (e.g. buffer-size or something)? Or can you not allocate memory that way?

If there is no need to chunk, then rclone won't buffer the file into memory.

If there is no need to chunk, then rclone won't buffer the file into memory.

If this is the case, why does system memory use peg out at 96M * threads regardless of whether the file is over or under the chunk size? This is syncing a large file tree to a new b2 location where most of the files are a few kB.

If there is no need to chunk, then rclone won't buffer the file into memory.

Here's the issue (output from htop). Should be self-explanatory. In both cases, I'm syncing a file tree with exclusively small files (most < 4kb) to a new crypted b2 location.

Even a single large file (above 200MB) to upload will have been enough for rclone to allocate the memory.  It uploads large files by chunking them up and uploading the parts in parallel (which is what backblaze recommend).
Perhaps you could try a transfer with --b2-upload-cutoff set bigger than your biggest file?


doc changes

Crucial updates to developer versus user guide. This is still a WIP but would like to get these changes in ASAP.
All Submissions:

[ ] Have you followed the guidelines in our Contributing document?

[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

[ ] Does your PR follow our Code of Conduct?

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?

[ ] Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

[ ] Is this code designed to be testable?

[ ] Is the code documented well?

[ ] Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

[ ] Have you added tests to cover your changes?

[ ] Have you linted your code prior to submission?

[ ] Have you updated the documentation and README?

[ ] Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

[ ] Have secrets been stripped before committing?

@sayar reminder to merge this in when possible. i addressed your comment


YAML parse error when reading cassettes

I'm having some issues using VCR against an external API.  I keep getting back a Psych::SyntaxError ((<unknown>): couldn't parse YAML at line 0 column 607) when trying to replay saved interactions.
I was having this issue when using YAML cassettes, so switched to JSON serialization, but am still getting the same error.  For what its worth, I can parse the JSON in the cassette manually without any problems.
The only thing I can think of is that somehow it is still trying to use the YAML serializer with a json cassette.  My code looks like this:
VCR.use_cassette(path_to_cassette, serialize_with: :json) do
  response = HxApi.get(request.path_info, query: request.params)
  [
    response.code,
    response.headers.to_hash.slice('content-type', 'content-length'),
    [response.body]
  ]
end

And the setup code looks like this
VCR.configure do |c|
  c.default_cassette_options = { serialize_with: :json }
  c.cassette_library_dir = 'spec/vcr_cassettes'
  c.hook_into :webmock
  c.ignore_hosts '<IP_ADDRESS>' # allow selenium/capybara to do its thing
end

Hmm, I don't have any ideas right now about what could be causing this.  There are several things that would help me troubleshoot this.

The full backtrace (both with serialize_with: :yaml and serialize_with: :json).
The cassette file itself.
An executable example of the problem I can play with.

The last one is probably the most important/useful.  You can contact me privately if you have a private repo that you're willing to grant me access to.

I have a feeling it could be down to an encoding issue in the response body from the api, however using the :preserve_exact_body_bytes didn't seem to solve the issue.  I'd rather not have to use this though as it is nice to have the cassettes human readable.
Someone is working on sorting the API encoding issues out, in the mean time I'll try and send you a copy of the cassette and put together an executable example.

FWIW, The error Psych::SyntaxError doesn't sound like the kinds of errors I've usually seen when it's an encoding issue.


Add parser support for timestampadd

DataFusion's parser cannot parse timestampadd(year, 2, d) because year is not a keyword, so it assumes that this is an identifier and looks for a column with this name.
This PR works around the issue by providing a custom prefix parser in the DaskSqlDialect where we can override parsing of just this expression and then fall back to DataFusion. This is a new feature that was added to sqlparser relatively recently.

Codecov Report

Merging #857 (727ac1d) into main (c19ea06) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   77.44%   77.58%   +0.13%
==========================================
  Files          71       71
  Lines        3600     3600
  Branches      634      634
==========================================
+ Hits         2788     2793       +5
+ Misses        685      676       -9
- Partials      127      131       +4

Impacted Files
Coverage Δ

dask_sql/_version.py
34.00% <0.00%> (+1.44%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Closing this now that these changes are part of https://github.com/dask-contrib/dask-sql/pull/838


Toggle is broken on Chrome

Chrome 101.0.4951.64
https://user-images.githubusercontent.com/5571736/169422211-46c97024-4759-4c99-92bc-f8fd25835be3.mov
Sorta works on safari but there's a check background image that is not aligned and not configurable with a modifier. I believe if a checkmark is require it should be specified as an additional modifier class
https://user-images.githubusercontent.com/5571736/169422220-c3ba1194-0ea5-4b0e-a949-1f16de3a3358.mov

This is not from daisyUI. There's another plugin or some external CSS applying styles to the checkbox. If you're using @tailwindcss/forms plugin, please disable it (because this plugin and daisyUI do the same job and you don't need them both together)
Let me know if you have any questions


Remove transaction-pool test-helpers feature

test-helpers feature is a bad idea in general, because once the feature is enabled somewhere in
the workspace, it is enabled anywhere. While removing the feature, the tests were also rewritten to
get rid off other "only test" related code.
Contributes towards: https://github.com/paritytech/substrate/issues/9727

bot merge

bot merge


Review Request

We are a team of two people and we have removed the tasks for the student C from our project list.
The link to our project is here.

Hi Team,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 💯

Descriptive info ✔

Required Changes ♻

[ ] Kindly make sure to assign all tasks to at least one team member each as per this requirement.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you very much for your feedback. We have assigned the respective tasks to corresponding team mates.

Status: Approved :green_circle: :1st_place_medal: :100:

Hey @Sajeelzafar, @SelmaNdapanda :wave:
Great work on implementing the requsted changes. Your project is complete. :blush:
There is nothing else to say about your project. :+1:
Highlights :1st_place_medal:
:heavy_check_mark: Following Requirements
:heavy_check_mark: Following Github Flow
:heavy_check_mark: Descriptive PR Title
:heavy_check_mark: Descriptive PR Summary
:heavy_check_mark: Following Linters
Optional
All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.
Cheers and Happy coding! :clap: :clap: :clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Optional Changes

[ ] It would be nice if you add your team member names in this Review Request issue summary above. and you can tell which student is student 1 and which student is student 2 :blush: for more details


Testnet support ??

Is there any testnet support ??? I want to generate address and want to transfer test tether on that address from external source??
is this possible ???

If you mean (ropsten or some other testnet) - no, Poloniex works only with real crypto-currencies.

okay thanks for your reply.
If possible then please suggest something on this
I want to do tether (USDT) transfer i.e create usdt wallet and create transaction.
did you know any other API or any other thing that could help to implement USDT????

Do you support Testnet3 BTC?


Add 'no op' execution mode

The idea: we execute a sequence of ND4J operations without any operations actually occurring. Furthermore, we have access to information on what specifically occurs between the start and the end of the no-operation mode.
Use cases:

Estimating memory use without actually allocating any memory (inc. whether that array allocation occurs within a workspace or not)
Knowing which operations specifically are executed

Some possible complications: any operations that returned a non-INDArray result. For example, entire array reductions, get double etc; we may simply be able to return zero for these operations, however.

yep, we'll return stubs everywhere, since in our codebase we'll have guarantee that result of no-op run won't be used anywhere (as in, model won't be saved, etc)


added an EmailJS template that is fairly easy to use

@BrendanGlancy Need few improvements

onsubmit it should not reload page
it should not show native browser alert. you can try some popup alert
replace server info with env variables
move this section to end of page (2nd last section).
in portfolio.js add option to hide/show contact form.

Okay, I will work on that in the coming days; thanks for the feedback.
Would you like me to add a section in the readme about how to add the .env variables?

@1hanzla100 I believe these are the changes you requested let me know if there's anything else.
Success Alert

Error Alert

@BrendanGlancy  I will Test it out and merge it to master after testing


chore: bdd-spring-1578936036 to 0.0.1

chore: Promote bdd-spring-1578936036 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add batching code to FirebaseStorageManager to allow for infinite scroll

Add code for batching queries, change credentials to allow any batching queries to be made locally or deployed.

So I added more test to make sure the batching code functions as intended! The one with successive batches in a row was especially important to make sure it worked.


Renamed --outs-only to --dvc-only

Changes pending to iterative/dvc/pull/3797
Fixes iterative/dvc/issues/3589
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Please request my review here if/when iterative/dvc/pull/3797 is merged. Thanks

@jorgeorpinel the corresponding pr in the dvc got merged, can you please review the pr?

Yup, thanks again for that core contribution. Reviewing...

FYI an official way to request reviews on Github is on the top-right corner:

But np, a comment also works.

Oops not sure I should've merged this yet though. Hopefully not a big deal... When can we expect iterative/dvc/pull/3797 released @efiop? Thanks

@jorgeorpinel not a big deal, it'll be released (or pre-released at least) soon


0.18.0 Changes

Signed-off-by: lorenabalan<EMAIL_ADDRESS>Motivation and Context

To make the release easier to navigate, I'm incorporating all changes for 0.18 in one branch / PR:

#55 ➡  Reverts quantumblacklabs/kedro-starters#49. In kedro 0.18 , openpyxl is the default and will be installed through kedro[pandas.ExcelDataSet].
#37 ➡  Rename mini-kedro to standalone-datacatalog.
#68 ➡  General cleanup to sync up starters with project template; see PR description for details.

How has this been tested?

Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Assigned myself to the PR
[ ] Added tests to cover my changes

Just to check I understand the scheme... Is this what we're planning to do?

point this branch to kedro@develop just for CI testing purposes
release kedro 0.18
revert this branch to kedro@main
merge this branch

Just to check I understand the scheme... Is this what we're planning to do?

Yes something like that but please be patient and bear with me, I was going to update the release checklist with the concrete steps as well. This is my proposal, no official agreement.

I think we're going to need to update the pyspark ProjectContext to reflex the new KedroContext signature.

I think we're going to need to update the pyspark ProjectContext to reflex the new KedroContext signature.

Yes good point!


Generate changelog for each release

Changelog generation should be automated, and have predictable URLs that can be used on the website.

This issue was moved to AdoptOpenJDK/openjdk-build#475


Keybase causes a complete system freeze on MacOS Mojave 10.14 Beta (18A377a)

Every time Keybase is launched, it causes a cascade of problems that end up with a necessity to manually power off MBP by holding the power button, and then quickly rm -rf /Applications/Keybase.app upon reboot (as Keybase automatically adds itself to startup items) frequently necessitating multiple forced reboots :/.
Some of the symptoms include:

Finder being completely unable to access any files:

Any shell command interacting with the file system hangs indefinitely and becomes impossible to interrupt:

Gradually all apps become unresponsive and hang indefinitely, with the OS being unable to (force) kill them nor reboot.

I'm happy to provide any info required, ideally if it doesn't require running Keybase client…
Here are the logs I've found, and can provide (if they don't contain any sensitive data):
Keybase.app.log                                               keybase.service.log
Keybase.app.log.1                                             keybase.service.log-20180629T105625+0700-20180704T102128+0700
keybase.git.log                                               keybase.service.log-20180802T091856+0700-20180807T122430+0700
keybase.kbfs.log                                              keybase.start.log
keybase.kbfs.log-20180221T132226+0700-20180223T144655+0700    keybase.updater.log
keybase.kbfs.log-20180605T112419+0700-20180607T223602+0700

@meeDamian Thanks for the report.  I haven't heard from others that Keybase causes problems like this on Mojave, so I'm a little stumped.  I assume you had the Finder extension installed?  (If not, it seems pretty unlikely that Keybase could be so disruptive.)
That extension uses osxfuse, and there have been some reports of issues with it (https://github.com/osxfuse/osxfuse/issues/508), but nothing like this.  It might be a good idea for us to upgrade though.
Have you looked in any of your kernel/boot logs for any panics related to Keybase or KBFS?
You might try uninstalling the keybase kernel extension (kextunload).
If you can get me those logs you mention, I'll take a look through them and see if there's anything unusual.  Normally you could do that with keybase log send, but if that doesn't work for you you can zip them up and put them somewhere for me to download.  The logs don't contain super sensitive data, but they will reveal who you've interacted with on Keybase, and the names of files and directories you've accessed in KBFS.

I'm not sure if I had "Finder extension" installed, but keybase fs used to be available under /keybase/… (if that answers the question?).
Logs were almost 700Mb, so here's a compressed version: https://www.dropbox.com/s/8gg9pi62l03c7lw/keybase-logs.7z?dl=0

Have you looked in any of your kernel/boot logs for any panics related to Keybase or KBFS?

I'm sorry, I wouldn't know how, but I'm happy to run commands and provide output :).

Hmm, from the logs I don't see any issues mounting the file system under the usual /Volumes/Keybase location.  (/keybase is a separate mountpoint that redirects to the /Volumes one.)
I'd start by looking in /var/log/system.log and /var/log/kernel.log, to see if there's anything related to keybase, or kbfs, or the keybase kernel extensions.
If you still have access to the keybase command line, you can try to get rid of the kernel extension with keybase uninstall -c fuse,redirector.  If not, maybe you can try:
sudo kextunload -b com.github.kbfuse.filesystems.kbfuse

to get rid of the extension until we can figure out if and why it's causing problems for you.

Here's (slightly redacted) the output of: zgrep -i -A10  keybase /var/log/system.log.* https://gist.github.com/meeDamian/f66ecc382f3b82ebee602078463cad95 . /var/log/kernel.log doesn't exist. Again, do lmk if you need anything more from there.
I'll definitely try both ways you've described! Hope to regain access to chats at least :).

Thanks!  The most unusual thing I see here is this:
/var/log/system.log.3.gz:Aug 31 16:30:30 DM-2 com.apple.xpc.launchd[1] (keybase.kbfs[12188]): Service did not exit 5 seconds after SIGTERM. Sending SIGKILL.
/var/log/system.log.3.gz:Aug 31 16:30:33 DM-2 com.apple.xpc.launchd[1] (keybase.kbfs[12188]): Service did not exit 3 seconds after SIGKILL.
/var/log/system.log.3.gz:Aug 31 16:30:33 DM-2 com.apple.xpc.launchd[1] (keybase.kbfs[12188]): Abandoning service instance. This may lead to deadlocks.

Is this around the time things starting freezing for you?  Though I guess you've rebooted several times and are still seeing the issues, so it's not a one-time thing.
We're going to try building a new version with an upgraded osxfuse kernel extension, including the Mojave-specific changes, and we'll see if that helps.

If useful, I can send complete syslogs as well.
I needed to reboot several times, if I didn't manage to stop/uninstall keybase before it started. If I did manage to prevent it from starting, everything was fine & no reboot was necessary.

sometime ago I removed a version of MacOSFuse: https://osxfuse.github.io

Hey Folks, we've put together a test build that includes an updated Fuse extension (3.8.2) that has beta Mojave support. Before we put it into a public release, could any of you please try it and see if it solves the issue for you?
Here's the build to install: https://s3.amazonaws.com/prerelease.keybase.io/darwin-test/Keybase-2.5.2-20180907045719%2B47eb1322da.dmg
You'd need to quit the Keybase app (either by right clicking the dock icon, or through the menu icon) first, then drag the Keybase app in the dmg into Applications as instructed. After installing, open the Keybase app, and check the new kbfuse version:
kextstat | grep kbfuse

If it says 3.8.2, you have the new version effective. Please let us know if it works!
Note that if other users have logged in on your machine, and has Keybase opened, it'd prevent the auto updater from installing the new fuse extension. But after a reboot it should install the new extension fine. If you are the only one logged in, you shouldn't need to reboot.

Hi Song Gao,
Thank you for the update to Keybase with the updated Fuse extension. I followed your instructions and installed and started Keybase with out any problems.
I will let you know about any issues on the thread:
https://github.com/keybase/client/issues/13537 https://github.com/keybase/client/issues/13537
Nice ;)
--
Thomas Juul Dyhr
<EMAIL_ADDRESS>
Den 7. sep. 2018 kl. 23.05 skrev Song Gao<EMAIL_ADDRESS>Hey Folks, we've put together a test build that includes an updated Fuse extension (3.8.2) that has beta Mojave support. Before we put it into a public release, could any of you please try it and see if it solves the issue for you?
Here's the build to install: https://s3.amazonaws.com/prerelease.keybase.io/darwin-test/Keybase-2.5.2-20180907045719%2B47eb1322da.dmg https://s3.amazonaws.com/prerelease.keybase.io/darwin-test/Keybase-2.5.2-20180907045719%2B47eb1322da.dmg
You'd need to quit the Keybase app (either by right clicking the dock icon, or through the menu icon) first, then drag the Keybase app in the dmg into Applications as instructed. After installing, open the Keybase app, and check the new kbfuse version:
kextstat | grep kbfuse
If it says 3.8.2, you have the new version effective. Please let us know if it works!
Note that if other users have logged in on your machine, and has Keybase opened, it'd prevent the auto updater from installing the new fuse extension. But after a reboot it should install the new extension fine. If you are the only one logged in, you shouldn't need to reboot.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/keybase/client/issues/13537#issuecomment-419565488, or mute the thread https://github.com/notifications/unsubscribe-auth/AFxKuU_JIjixYdAFdPyWJdx9bHb57ho8ks5uYt-AgaJpZM4WU9Bb.

I had a similar issue. It fixed my issue too. :)

I just submitted a new error message through the 'Keybase log send' mechanism. Not enough slots available for kbsf.. as startup message for Keybase - although Keybase seems to work?!  log ID is:
47a68826ce52520e4ee1471c

Yay, it works 🎉🎉🎉🎉🎉.
After all this time I'm able to use Keybase on my computer again 😃!

Thanks all for testing! I'm gonna try to get it into the coming public release then. You all could thank Benjamin here for making osxfuse work with Mojave. We just "fused" it into KBFS :)
@docdyhr thanks for the log! We'll take a look. As long as it works it's likely fine (i.e. the error message might have been wrong).


Resizing the radius on touch

Tell me, how can I change the radius of a point when touching on the graph? I looked for similar problems in others, I did not find similar problems. And does the chart allow you to zoom when viewing the chart?
I use the latest version
https://github.com/imaNNeo/fl_chart/assets/26271353/79c88aed-faa6-4b78-a4ee-1da84d73be2e

Hi! First, just to help you in future issues, "I use the latest version" could stop being true when the package upgrades, so keep an eye on that.
Inside LineChart.data -> LineChartData.lineTouchData -> LineTouchData.getTouchedSpotIndicator is a method that returns List<TouchedSpotIndicatorData?>. This TouchedSpotIndicatorData asks for FlLine indicatorBelowLine, FlDotData touchedSpotDotData, and the touchedSpotDotData is the FlDotData that accepts a FlDotCirclePainter (which has a radius parameter) as the result of getDotPainter.
Sorry about the previous paragraph. I'm not sure what you are familiar with at any point.
About the zoom, maybe InteractiveViewer or RawMagnifier could be what you are looking for? If it's not what you wanted, please give us more context.


LOC record - HorizPre and VertPre default values are incorrectly encoded

func (rr *LOC) parse(c *zlexer, o, f string) *ParseError {
	// Non zero defaults for LOC record, see RFC 1876, Section 3.
	rr.HorizPre = 165 // 10000
	rr.VertPre = 162  // 10
	rr.Size = 18      // 1
	ok := false

According to RFC-1876 those fields should be:
a pair of four-bit unsigned
integers, each ranging from zero to nine, with the most
 significant four bits representing the base and the second
number representing the power of ten by which to multiply
the base.  This allows sizes from 0e0 (<1cm) to 9e9
(90,000km) to be expressed

Those values should probably be:
HorizPre = 1000000 = 110^6 = 0x16
VertPre = 1000 = 110^3 = 0x13

This was closed by #1084.


Move OS' MIDI methods into InputEventMIDI

Partially addresses https://github.com/godotengine/godot-proposals/issues/8761.
Related to https://github.com/godotengine/godot/pull/86716 and https://github.com/godotengine/godot/pull/86693.
This PR moves the OS' methods related to MIDI into the InputEventMIDI, as static methods.
The previous methods are still available, but are marked as deprecated.
This means the following:

Currently
This PR

OS.open_midi_inputs()
InputEventMIDI.open_inputs()

OS.get_connected_midi_inputs()
InputEventMIDI.get_connected_inputs()

OS.close_midi_inputs()
InputEventMIDI.close_inputs()

The original intention was to move the global constants as well, but that fell through for the time being, and will be done in a separate PR for further discussion.
On the other hand, the methods are comparatively safer to implement and do not break existing compatibility. See the proposal for reasoning.

I updated the PR to have InputEventMIDI's methods call the OS ones as above. The intention for the originals to be deprecated should still be clear.

In fact this should probably be handled by updating the regression project, see:
https://github.com/godotengine/regression-test-project/blob/3.x/AutomaticBugs/BasicData.gd#L28

My solution was indeed unfortunately wrong, so the two options now are to either change the name or add to the regression project (and revert my suggestions)

Should be easy if it really is just adding "open_inputs" to the exceptions. Although part of me wonders if it's a good opportunity to come up with a better name for these three methods.

It would be simple yeah but that would have to be merged before this

https://github.com/godotengine/regression-test-project/pull/80


The Chevalley-Serre relations define simple Lie algebras with splitting Cartan subalgebras

We have an implementation of the Chevalley-Serre relations which turns a matrix into a Lie algebra. When the input matrix is a genuine Cartan matrix, the resulting Lie algebra is:

finite-dimensional
simple
contains a splitting Cartan subalgebra

We should add these facts to Mathlib.

If we use a Chevalley basis then we should be able to get something that works over $$\mathbb{Z}$$.
Possibly relevant: https://mathoverflow.net/questions/195567/comparing-a-chevalley-basis-with-the-canonical-basis-of-the-adjoint-module?noredirect=1&lq=1

Steinberg's Lecture Notes on Chevalley groups should be relevant.


Brush up the observability config

add proper defaulting
cleanup test (was pretty shaggy with wrong variable names and such)
raised coverage a bit

/assign mattmoor @mdemirhan

/lgtm
/approve