Error: stale element reference: element is not attached to the page document

Hello,
I have implemented a pretty complex scenario and I've coded this:
		let oRiskInputSelector = {
			selector: {
				controlType: "sap.m.Input",
				id: "RiskOpp",
				viewName: "Risk",
				interaction: "focus"
			}
		}
		let oRiskInput2 = await browser.asControl(oRiskInputSelector);
                await oRiskInput2.setValue("test");

The command setValue returns the error above. What am I doing wrong?

oRiskInput2 vs $oRiskInput2 ?!?

There was a type in the code I copied in, without $ sign. I tried to getWebElement and use $ but that doesn't work either

Hi @marco-paciucci,
a little bit more context and your error message would be nice to have! Why can't you just use enterText?
let oRiskInputSelector = {
			selector: {
				controlType: "sap.m.Input",
				id: "RiskOpp",
				viewName: "Risk",
				interaction: "focus"
			}
		}
		await browser.asControl(oRiskInputSelector).enterText("test");

The UI5 Testrecorder could also help you to improve the performance of writing your tests. There is now also a dedicated wdi5 dialect.

I've tried your suggestion but I'm getting this error:
[wdi5] reusing internal control with id RiskOpp.ibp.ibpbaseplanningobjectmanagement-v2.view.Risksap.m.Input [0-0] [wdi5] Can not call "enterText,_controlSelector,selector,interactWithControl,_browserInstance,executeAsync,options,beforeCommand,options,beforeCommand,apply", because control could not be found [0-0] [wdi5] Can not call "enterText,_controlSelector,selector,interactWithControl,_browserInstance,executeAsync,options,beforeCommand,options,beforeCommand,apply,executeAsyncScript,options,beforeCommand,options,beforeCommand,apply", because control could not be found
What's wrong?

the message clearly states
control could not be found
so please check whether your selector is working

There is definitely a bug somewhere, the control is there.
What I am doing is the following:

Worklist Screen->Click on Add Object Button-->displays a new form in place with an input field (whose selector is the one shown above and works perfectly-->click on save button which creates the business object-->returns to the worklist and in here I select the newly created object-->the object displays in a form, click on edit button which makes fields editable, try to modify the input field with the selector above and "the control could not be found".

This means that the first time the selector works perfect, the second time it does not, it's like it's not attached to the page DOM.
This looks like a bug to me.
What could I do?

Hi @marco-paciucci,
thank you for the additional context. This sounds more or less the same as this issue. Try to use forceSelect in your selector to tell wdi5 to retrieve the control again from the browser scope.
Regards,
Simon

Hello,
I coded this:
`	await browser.asControl({
forceSelect: true,
selector: {
id: "application-IBPBPOV2-Manage-component---risk--RiskOpp",
			interaction: {
					idSuffix: "inner"
			}
	}}).enterText(sNewText);`

but I am still getting this:
] Can not call "enterText,_controlSelector,selector,interactWithControl,_browserInstance,executeAsync,options,beforeCommand,options,beforeCommand,apply", because control could not be found [0-0] [wdi5] Can not call "enterText,_controlSelector,selector,interactWithControl,_browserInstance,executeAsync,options,beforeCommand,options,beforeCommand,apply,executeAsyncScript,options,beforeCommand,options,beforeCommand,apply", because control could not be found
I then coded this:
		await browser.execute((a) => { 			sap.ui.getCore().byId("application-IBPBPOV2-Manage-component---risk--RiskOpp").setValue(a); 		}, sNewText);
and this works but I don't like this dirty solution.
What am I doing wrong in the first solution?


Handle diagnostics that fail

The entire workflow shouldn't crash if you are just missing a variable used by a single diagnostic. It should exit cleanly, and report the status on the CSET front page.

I have mixed feelings on this one, as having the workflow hold if a task fails is very useful for debugging. It may be something we want to make dependent of whether debugging logging is enabled.


How to avoid re-rendering when we were updating the state?

How to avoid re-rendering when we were updating the state?
I have varius setstate, but i need the calling last and update before other states, how make this?

This issue looks like a question that would be best asked on StackOverflow.
StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.
Will close this as this is really a question that should be asked on StackOverflow.


Development: Fix flaky priorityExamTest

Checklist
General

[x] This is a small issue, only related to the integration tests, that I tested locally and was confirmed by another developer on a test server.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] We strictly followed the server coding and design guidelines.
[x] We added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] We documented the Java code using JavaDoc style.

Motivation and Context

The testPriorityRunningExam() in LocalVCLocalCIIntegrationTest.java is very flaky on several branches.
Description

The flakiness came to be, as a 10 seconds timeout was exceeded.
This happens, as we need to wait for a build to be done being processed, to then check the priority of the result.
We are not yet entirely sure where the huge delay comes from, but there are several steps involved (e.g. cloning) which on their own take some time, and accumulated could lead to the large observed delay.
We eliminated the need for the test to wait a long time, by directly inspecting the queued item when it is added to the queue, therefore simplifying the test by a lot.
Steps for Testing

Run the tests locally
Check that the test does not fail in the test system

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Summary by CodeRabbit

Bug Fixes

Improved reliability of the testPriority method by adding a mechanism to monitor attempts for the presence of a BuildJob.
Set a maximum timeout of 15 seconds for the await() function to prevent indefinite hanging during test execution.

These enhancements ensure more consistent test performance and better diagnostics in case of failures.

I have a question about the testing steps. Where and how to Run the tests? On my local machine? Together with changes from another branch (which have problems with this test)?

I have a question about the testing steps. Where and how to Run the tests? On my local machine? Together with changes from another branch (which have problems with this test)?

The flakyness with this test was branch unrelated, so just using this branch to run the test locally should be enough. You can also check the test system for failing tests: https://bamboo.ase.in.tum.de/browse/ARTEMIS-TESTS7060-JAVATEST-14 currently there are none :)


1.20.2 support

Currently, the mod crashes when run on 1.20.2 fabric. See a log here
Reproduction

Install Fabric 1.20.2 (I am using Prism)
Install Fabric API and Better Command Block UI
Launch and see crash stated in attached log

Updated 👍


Prefer KotlinCompile.compilerOptions over KotlinCompile.kotlinOptions

KotlinCompile.kotlinOptions used JavaBean properties.
KotlinCompile.compilerOptions uses Gradle properties.
This is a follow up to

#22027

Wrapper update is necessary for the kotlin-dsl plugin update. A new wrapper update will be done post-merge to get rid of the branch snapshot.

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

@bot-gradle test and merge

@bot-gradle test and merge

@bot-gradle test and merge

I've triggered a build for you.


Make api swagger docs for endpoint to create data product metadata clearer

User Story
As a developer
I want to make our api documentation as clear as possible
So that our users have a good experience using the api and are not confused/frustrated by putting unnecessary content in their requests
Value / Purpose
Clear documentation increases the usability of our service
Hypothesis
If we change the way our json schemas (data product metadata mainly) are presented in the swagger docs to only display the information that is required to be given to us by a user (not any auto generated data)
Then a user will not be able to waste their time trying to fill in metadata that we'll be generating and that could cause an error with their request
Proposal
Either:

Remove the keys that are autogenerated from the current schema json and save in a separate json schema file. Then the swagger docs can ref the schema that contains only data expected from a user.
See if it is possible to configure swagger to ignore certain keys within a schema and not display them in the user docs.

Additional Information
No response
Definition of Done

[ ] Another team member has reviewed
[ ] Tests are green

We might be able to refine the schema within swagger.json but need to test if this will work
https://swagger.io/docs/specification/data-models/oneof-anyof-allof-not/
If not, will have to go with the separate schema approach.


Logrotate path with spec tests

@anshprat I went ahead and added unit tests to provide you an example of what reasonable coverage for all the code you added looks like. I'd really like us to have better cadence about unit testing in the future. Once my travis tests pass, I'm happy to merge.

ha, I didn't even know you could do that! submit a patch into my patch.


Add missing period

Learn Build status updates of commit 0ca572c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/msbuild/walkthrough-using-msbuild.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Looks good; thanks, @AndrewKeepCoding


cargo-src: launch server before processing data

We currently read in all save-analysis data and cross-reference it before starting the server. We should start the server first and then read in the data in parallel. We can provide the source pages without links to start with, then we should use the semantic data once it is available. We should indicate to the user which state we are in.

This is much harder than expected. It is mostly done, however, if we load a page without analysis info, then finish processing, then reload, we still don't get analysis info. I don't think we cache on the client. I think the issue is that we clear the cache of files at the start of loading analysis, then load the page which puts a page in the cache, but never invalidate it at the end of analysis. Also, we don't indicate the current status to the user.

Ok, the last bit was easier than expected. Now just need to add API to indicate the status (and track that on the server).


Boxed blobs version 2

Experimenting with boxing blobs.
Should hopefully eventually resolve #331

This is no longer needed. The root issue was identified. Fixed here:

#354

This is no longer needed. The root issue was identified. Fixed here:

https://github.com/ethereum/c-kzg-4844/pull/354


Feature/2120 browser lang gtm

What does this pull request aim to achieve? 💯
Resolves #2120
Please be concise and link any related issue(s):

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[x] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[x] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

@FedericaZn will have to test this once it's on staging.
To double check, @OzkanAbdullahoglu, we have 2 variables - one for browser default language and one for selected language? And the selected language variable will update whenever the user changes language manually?

@FedericaZn will have to test this once it's on staging.
To double check, @OzkanAbdullahoglu, we have 2 variables - one for browser default language and one for selected language? And the selected language variable will update whenever the user changes language manually?

@FedericaZn will have to test this once it's on staging.
To double check, @OzkanAbdullahoglu, we have 2 variables - one for browser default language and one for selected language? And the selected language variable will update whenever the user changes language manually?

Only the last part hasn’t been completed yet, we have two variables, but the selected language is not updating. I 'll handle that asap.

@FedericaZn will have to test this once it's on staging.
To double check, @OzkanAbdullahoglu, we have 2 variables - one for browser default language and one for selected language? And the selected language variable will update whenever the user changes language manually?

Only the last part hasn’t been completed yet, we have two variables, but the selected language is not updating. I 'll handle that asap.

right now language data layer should be overwritten when the user changes the language from the menu. I couldn't perform a proper test without accessing gtm.

right now language data layer should be overwritten when the user changes the language from the menu. I couldn't perform a proper test without accessing gtm.

After I access gtm, I think dataLayers working as expected. (thnx @FedericaZn , @doheekim93)

And this is when we change the language

After I access gtm, I think dataLayers working as expected. (thnx @FedericaZn , @doheekim93)

And this is when we change the language


[qtbase] Make feature pcre2 to hard dependency when install static library

Fixes #22482
When install qtbase[core,gui,doubleconversion]:x64-windows-static, qtbase will build failed with the following error:
-- The following REQUIRED packages have not been found:
 * WrapPCRE2
-- The following OPTIONAL packages have not been found:
...
CMake Error at C:/Program Files/CMake/share/cmake-3.22/Modules/FeatureSummary.cmake:464 (message):
  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
  run.

This need install qtbase[pcre2], add fatal error to remind install feature pcre2.

This LGTM, thanks!


⚠ Bofrost.fr has degraded performance

In e8e2653, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1131 ms

Resolved: Bofrost.fr performance has improved in a7e1329 after 6 minutes.


Add next page cache on channels.

This PR add a prefetch and caches the response when the user visits the channel page.
It should close issue #1851

Thanks for checking out LBRY and the contribution! If you haven't already, please make sure to check out our contributors guide.
Can we send you LBC in appreciation for your work

Hi @seanyesmunt, I think we need a new state because we don't want to re-fetch the same page again, going back and forth right ?, so somehow we need to keep track of the page numbers that were already been fetched correct?, currently I've added a call to fetch the page after fetching the current page.  Also I've added a function to fetch the next available page to fetch, for example if you click on the page 1 the first time it will fetch 2 and 3, if you click on the page 2, then It will try to fetch page 4 and 5, that's why the state is needed.
Let me know what do you think!

If we go to page 1 (and fetch page 2/3 in the background), it's ok to fetch them again when we get to that page. What if the content was updated? The main goal with this is to have content appear on the screen faster when going to other pages.

cool @seanyesmunt , I will work on that this night.

Hi @seanyesmunt , I've just updated the code! Thanks for the insight I was overthinking a lot on this one. 👍

@dan1d This is looking better but I still think it can be simplified.
What if doFetchClaimsByChannel took a third argument cacheNextPage.
If that argument is passed in, you can check if there is an additional page and then call doFetchClaimsByChannel from inside the function with the next page.
    // Somewhere else
    doFetchClaimsByChannel(uri, 1, true)

    function doFetchClaimsByChannel(uri, page, cacheNextPage) {
      ...
      if (cacheNextPage && page + 1 < totalPages) {
        doFetchClaimsByChannel(uri, page)
      }
    }

Doing that would allow opting into this behavior too

@dan1d see above, let us know when you think and when you can get this fixed up :)

Today will be ready, I'm going to implement the recursive changes that you
asked!
El lun., 29 oct. 2018 a las 13:16, Thomas Zarebczan (<
<EMAIL_ADDRESS>escribió:

@dan1d https://github.com/dan1d see above, let us know when you think
and when you can get this fixed up :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-desktop/pull/2044#issuecomment-433971980,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADJBsA4tmEAJg03GZ68TASelmqafe6Cpks5upyn2gaJpZM4XdAGF
.

@seanyesmunt  Code updated! Thanks for the insight on the recursive function, I'm working with Ruby/Ruby on Rails currently so I'm a bit rusty with React/Redux/JS.

@dan1d This is looking good. When testing I see that there are 3 claim_list_by_channel calls. I see one for page: "1", one for page: "1", and a third one with no params (I'm not sure where that is coming.)
Could you check it out? I'm not sure if it's your new code or not but we shouldn't be making that third call.

Also I rebased and pulled in the latest changes from master, so you should pull from your fork. You might notice few minor changes from recent PR's

I'm going to close this while I do some repo cleanup. If you plan to finish this up please re-open! I think it would be a great feature in the app.


Bug: Clicking on an empty space sometimes fails to deselect items

Description
As the title describes. In this case, some hotkeys (Ctrl++, Ctrl+-, etc.) cannot be used, nor can multiple selections be made by dragging. Repeated navigation and layout changes may fix or reoccur.
Steps To Reproduce

Set the layout to List.
Close the app window with the list layout open. (Make sure to set background running to off and startup settings to "Continue where you left off".
Restart the app.
Observe deselection doesn't work.

Requirements
Make deselection, selection rectangles and hotkeys work.
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.4046
Log File
No noteworthy logs are output.

Is this new to v3.2.2?

No, it also happens in v3.2.0.

Yeah, when I was playing around List layout, this issue, where selection rectangle won't work, happened.

This seems to occur when the list layout is displayed before displaying the grid or tile layout. This will not occur when the list layout is displayed after displaying the grid or tile layout.


A cloud error pop-up appears When we click on "Buy" of the bottom menu bar.

This is happening only on the first click when we land on the home screen after wallet initialization.

Verified this issue on dev app v1.7.9(315)


Wire up priority task processor implementation

What changed?
Wire up implementations for priority task processor

Why?
Priority task processor is part of the multi-tenancy effort for throttling task processing for bursty domains

How did you test it?
Tested locally with feature flag turned both on and off through unit and integration test.

Potential risks
No risk when the feature flag is turned off.
If the flag is turned on, may impact performance.

Coverage decreased (-0.3%) to 67.141% when pulling 6c48c19b298689f3cf82f3697d44bf46f4262ed0 on yycptt:wire-up-task-processor into a933ae05c05c9d6d4abb87038b58d9b47f0eac38 on uber:master.


MacOS 14.4.1 (23E224) is rejected

Hi, will this work on 14.4.1? I tried open it but it said not supporting on this Mac.

It runs on 14.6.1.
Did you check installation instructions? Since the app is not signed by Apple, it may cause such issues.
You need to enable System Settings->Privacy & Security->Security->App Store and identified developers option.
Sometimes, depending on your configuration, you need to disable "Gate keeper" option to install unsigned apps.
You can have more information link
OR
If you install XCode, you can compile the app in your system.

Right, I did the same thing as here. Also I tried sudo spctl --master-disable in that link. However, it is still shown as blocked and not supported. I may have to learn to use the Xcode to compile it. Thank you.

What is your laptop chip? Is it M1 or M2? The other machine I've tested is also M2.
You can easily compile the application, by the way.
Clone or download the repository on your computer.
Open the zip folder.
Then double click on the icns creator.xcodeproj file.
It will open the project in XCode and press the Run button.

I'm on Intel, Sonoma 14.5 and also can't run it. Is this application only for Apple Silicon?

I am also intel core i9.
Now I compiled it. Thank you.
But the compiled app is under /Users/ykliu/Library/Developer/Xcode/DerivedData/icns_creator-dkrdurhnmpvjsydfyzjfqhckrwiw/Build/Products/Debug
I then copy that to the Applications directory.

@dotvhs @yuankailiu I tested older versions on my Intel macbook. They worked fine. So, it shouldn't be a problem for Intel based machines.
Instead of using Debug product, it is better to choose Release version.
@yuankailiu you can access the compiled version from Xcode menu.
Also, I released a patched version 3.5.1 as prerelease for macOS 14+ you can try to run this version if your system is above 14.
Let me know if it works out or not.

Let me know if it works out or not.

Still a no from me, I'm on 14.5

Still a no from me, I'm on 14.5

Ok. I will check the on my old Intel-based Mac also.
Thanks for the feedback @dotvhs

@dotvhs and @yuankailiu , I submit a pre-relelase for Intel-based Macs. It seems to be fine on my mid-2015 macos 12.7.6.
Let me know if it works on your machines.
https://github.com/alptugan/icns-creator/releases/tag/v3.5.3

Let me know if it works on your machines.

It finally launches, yes! Thank you for your work. For some reason it is unable to save .icns though but it finally launches now. When I press "Generate .icns" - nothing happens. Generating .iconset seems to be working fine though, it opens save file dialog.
Also unrelated (i think?) minor bug is that when I tab out and tab back, the app window changes its size and all the options are invisible.
Still, thank you for your work!

@dotvhs For now, the app saves files to the source image directory. I will fix the save issue.
"the app window changes its size and all the options are invisible."
Actually two tabs are different form each other. The options in .icns are not available for .iconset mode.
.iconset -> creates the iconset folder and creates a single icns file.
.icns -> it allows you to create icns files in specific resolutions.

Great! thanks very much! It works for me as well.


Cargo's shuttle is incapable of selling anything

Description
Anything inside the cargo shuttle will not be sold on recalling of the shuttle, no matter what it is or where it is. You put something on the pallet, recall the shuttle, call the shuttle back, the item is still there, didn't get removed and no funds were earned.
Reproduction
Put something on the cargo shuttle, recall it, call it back.
Additional context
One of the first mentions of this bug was on the 27th in the main discord, in the #bugs-feedback channel under the bug report "Cargonia's ship wont sell anything. but weirdly we can buy stuff."

Should be fixed by #12306


Support richer volcano scheduling

What you would like to be added?
The current training operators, such as TFJob, cannot set queues and priorities, which can be achieved through annotations or other forms.
Why is this needed?
I need this to train my data.
Love this feature?
Give it a 👍 We prioritize the features with most 👍

Thanks for creating this @shaoqingyang!
I think, we have this APIs to specify queue and priorities to integrate with volcano scheduler: https://github.com/kubeflow/training-operator/blob/master/pkg/apis/kubeflow.org/v1/common_types.go#L231
Won't it work for you ?
cc @lowang-bh

I have a question about https://www.kubeflow.org/docs/components/training/user-guides/job-scheduling/
For volcano and scheduler plugin, we need to configure the training-operator with:
...
    spec:
      containers:
        - command:
            - /manager
+           - --gang-scheduler-name=volcano
          image: kubeflow/training-operator
          name: training-operator
...

But when it comes to Kueue, we only need to specify the label in the metadata without modifying the configuration of training-operator, which is more simple and user-friendly:
metadata:
  labels:
    kueue.x-k8s.io/queue-name: user-queue

May I ask why we didn't implement a unified scheduling framework for these three schedulers? What prevents us from implementing such a unified scheduling framework?
Also, current ManagedBy field in RunPolicy only supports kubeflow.org/training-operator and kueue.x-k8s.io/multikueue. Maybe it will make users puzzled and think we only support kueue(or just for me)?
PTAL if you have time👀 @kubeflow/wg-training-leads

/remove-lifecycle stale


Typeless inline fragments

Per http://facebook.github.io/graphql/#sec-Inline-Fragments, TypeConditions can be optional for Inline Fragments. I found this while playing around with adding Validations  as a learning exercise, and felt that it may make a better first PR than the Validations themselves.

Thanks for the PR. Good pickup on the optional type condition! Will try and get this merged ASAP.

See comments otherwise looks good. Think there might be merge conflicts with #31 though (because name.value), but we'll fix on whichever is merged last.

Rebased, compacted, and force pushed after making the changes you suggested.

Nice!


Build with test

This pull request makes the repo build with "./gradlew build --no-build-cache --rerun-tasks -x :jballerina-unit-test:test". This build was tested in 2 separate machine and this command builds it one machine but fails in the other.
if in the case it doesn't build (due to unidentified intermittent test cases in integration tests) use "./gradlew build --no-build-cache --rerun-tasks -x :jballerina-unit-test:test -x :jballerina-integration-test:test" to build it.
The test cases skipped are documented here -> https://docs.google.com/document/d/1GkT46RZKsfA0Usvjv1IaaBDkx6sfdxFU-dhmOFiajx4/edit
if any test cases are not documented in the doc then you can find them commented in their respective testng.xml files. All test tasks that have failure intermittent or not are documented in the above doc, only certain test cases within test tasks might be missing from the doc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chiran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@m36dot Whats the issue this PR addresses?
If this is something no longer valid, can we close this?


Remove files

Remove some files that don't belong
Removals

Remove "=" and "maxWidth" files

Review

@virginiacc

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Good catch! :+1:


SILK Interpreter

How does it work? I don’t see any “interpreting” code. Is there like a psuedocode algorithm for the Interpetation loop?

Talking about 2.3.2 not 3.0.0


feat(taikoon): ui qa checklist

[x] Background, light mode:

[x] Remove pink gradients
[x] Bg color: #f8f8f8

[ ] Blur header background once scroll starts
[ ] Apply custom style to navigation menu buttons
[ ] Align nav buttons as the only centered element on the top bar
[ ] "Mint now" button custom styles
[ ] Replicate taiko.xyz hover animation for "Mint now"
[ ] Change "WTF" to "Learn more"
[x] Sticky scrolling
[ ] Change Information.section background color to pink/50 (#FFC6E9) on light mode

[ ] Font size corrections

[ ]  Change headline on faq sections, "WTF?" > "FAQs"

[ ] Style corrections on FAQ items

[ ] Ensure display space for footer on all resolutions
[ ] Mimic animations from taiko.xyz footer

@bearni95 Please add svelte-i18n, while we may not initially have other languages, it is a lot easier later on if it was prepared right away. It's also easier to adjust text in a single file rather than dozens.


WIP query design doc

Closing, but cc @batiati. I am not sure whether we have any internal docs for scans infrastruture, but it might be a good idea to add those!


Issue with which RANs show in work queue after doing some selecting of zones

After showing/hiding other zones a few times I was only seeing agreements belonging to me that did not yet have plans

@LisaMoore1 Are you able to provide some screenshots and steps to reproduce this?

I have had it happen a couple of times after I’ve been testing for awhile. Next time it does I’ll screenshot what I can (not much to see except I seem to be missing things) and see if I can identify anything else useful.
Losa

From: Caleb Sharp<EMAIL_ADDRESS>Sent: July-23-20 11:57:31 AM
To: bcgov/range-web
Cc: Moore, Lisa FLNR:EX; Mention
Subject: Re: [bcgov/range-web] Issue with which RANs show in work queue after doing some selecting of zones (#874)
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@LisaMoore1https://github.com/LisaMoore1 Are you able to provide some screenshots and steps to reproduce this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bcgov/range-web/issues/874#issuecomment-663176565, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI632E5I3BZOLN46PAN33MTR5CBZXANCNFSM4PFBLOSA.

@LisaMoore1 Ok, sounds good. Can you include the exact URL when you are able to reproduce this again? Thanks.


[issue 2449] fix problems with trailing slash...

... in path names on windows, which in turn will escape the quotes
What does this PR change? What problem does it solve?
See #2449 - if you're autocompleting a path with spaces in it, e.g. c:\test thing\ then it can't be read because the backslash escapes the trailing quote.
Was the change previously discussed in an issue or on the forum?
Closes #2449
Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[x] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[x] All commit messages are formatted in the same style as the other commits in the repo.
[x] I'm done! This pull request is ready for review.

Small addendum: While I think this fixes the linked issue, the handling of args and especially the lack of tests (although I only looked in cmd_backup_test.go isn't too great, so I wouldn't say I am 100% confident.

I'm not sure this is a good idea. Isn't it possible to create a filename that ends with a quote? This rather sounds like a bug in the autocompletion of powershell / cmd (?). Or somewhere in the command line parsing.
https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_special_characters?view=powershell-7.2 looks like a backslash is not an escape code in powershell, so it shouldn't cause a problem. Before adding a workaround we should first investigate what the actual problem i.

@MichaelEischer, no in Windows filenames containing quotes are forbidden (as some more characters) see e.g. https://en.wikipedia.org/w/index.php?title=Filename&oldid=1063519062#Comparison_of_filename_limitations for FAT and NTFS

I just did a bit of testing, and it seems that the command line handling of trailing slashes is far more broken:
PS C:\Users\Michael> .\restic.exe -r testrepo backup 'test space\' "test space\" ".\test space\" -v
enter password for repository:
repository 2b35bc1d opened successfully, password is correct
no parent snapshot found, will read all files
error: CreateFile \\?\C:\Users\Michael\space": The filename, directory name, or volume label syntax is incorrect.
error: CreateFile \\?\C:\Users\Michael\test space" -v: The filename, directory name, or volume label syntax is incorrect.
error: CreateFile \\?\C:\Users\Michael\test space" test: The filename, directory name, or volume label syntax is incorrect.
Fatal: unable to save snapshot: snapshot is empty
PS C:\Users\Michael>

To clean this up a bit, restic got the following three paths to backup: test space" test, space" and test space" -v. This essentially means that just removing a trailing quote will randomly work in some situations, but will still break horribly in most situations.
The above command line was passed to restic as "C:\Users\Michael\restic.exe" -r testrepo backup "test space\" "test space\" ".\test space\" -v (as retrieved via windows.UTF16PtrToString(syscall.GetCommandLine())). The command line parsing in Go happens here:
https://github.com/golang/go/blob/85b5f86584686677c554b2538a7edee96d684aea/src/os/exec_windows.go#L156 .
(cmd turns the above command line into  .\restic.exe -r testrepo backup 'test space\' "test space\" ".\test space\" -v which is also broken)
The way I understand https://docs.microsoft.com/en-us/cpp/c-language/parsing-c-command-line-arguments?view=msvc-170 Go is behaving correctly here, which would mean that Powershell messed up the parameter encoding.

Good catch, thanks. Yeah to be honest I haven't got a lot of experience with PS and its brokenness as I tend to stay away if possible.
The interesting questions are thus: Is it worth fixing at all? Would a very basic check including "we detected some wonky backslashes please double check" warning be better?
As I said in #2449 originally: "The most puzzling thing is is that is actually creates the snapshot with 0 files." - that's the thing that's actually annoying me. "Don't tab-complete" is a perfectly fine solution for this, but I think that one's important (and maybe my bad for not splitting it out into a separate issue)

@winks Does the empty snapshot problem still exist with restic 0.13.0? I'm a bit puzzled why my test did not create a snapshot.

No change between 0.12.1 and 0.13.1 for me.
# this is 0.13.1
PS F:\7zip> C:\Apps\bin\restic.exe -r .\backup\ init
enter password for new repository:
enter password again:
created restic repository c46255b814 at .\backup\

Please note that knowledge of your password is required to access
the repository. Losing your password means that your data is
irrecoverably lost.
PS F:\7zip> C:\Apps\bin\restic.exe -r .\backup\ backup '.\New folder\'
enter password for repository:
repository c46255b8 opened successfully, password is correct
created new cache in C:\Users\Florian\AppData\Local\restic
found 1 old cache directories in C:\Users\Florian\AppData\Local\restic, run `restic cache --cleanup` to remove them
no parent snapshot found, will read all files
error: CreateFile \\?\F:\7zip\New folder": The filename, directory name, or volume label syntax is incorrect.
Fatal: unable to save snapshot: snapshot is empty

PS F:\7zip> C:\Apps\bin\restic_0.12.1.exe -r .\backupold\ init
enter password for new repository:
enter password again:
created restic repository d13cdf131e at .\backupold\

Please note that knowledge of your password is required to access
the repository. Losing your password means that your data is
irrecoverably lost.
PS F:\7zip> C:\Apps\bin\restic_0.12.1.exe -r .\backupold\ backup '.\New folder\'
enter password for repository:
repository d13cdf13 opened successfully, password is correct
created new cache in C:\Users\Florian\AppData\Local\restic
found 1 old cache directories in C:\Users\Florian\AppData\Local\restic, run `restic cache --cleanup` to remove them
no parent snapshot found, will read all files
error: CreateFile \\?\F:\7zip\New folder": The filename, directory name, or volume label syntax is incorrect.
Fatal: unable to save snapshot: snapshot is empty

That is only with powershell. Both work fine when being run in cmd.exe

Now I'm confused. The problem in #2449 seems to be that an essentially empty snapshot is created. But in the example restic properly complains about a broken filename and does not create a snapshot.
I guess we could tell users not to use slashes before a quote on windows if a file cannot be read. Although it's a somewhat hacky solution.

Yeah sorry, rereading the output of the other one I am now also a little confused. I am reasonably sure that this 0.12.1 mentioned here and in the other issue on Jan 22 is the same binary. I didn't investigate further and just renamed it when I tested 0.13.1 - so it looks like one time it failed and one time it created an empty snapshot...

From what I can tell, there's no (reasonable) way to properly fix the path parsing in restic. So, my suggestion would be to add a section to the FAQ (https://restic.readthedocs.io/en/stable/faq.html) instead.


feat: command help text template preprocessing

Changes

:gift: all command help text template preprocessed

In preparation for a complete update of all command help text, this PR updates all commands to have their help text passed through a template preprocessor which, by default, provides the effective command name.
/kind enhancement
Fixes #216

@lkingland there's a conflict to be resolved

@lkingland there's a conflict to be resolved

Thanks @zroubalik , logs of rebasing needed...


Creating an issue template for the project

Hey. I was wondering if it would be helpful to add an issue template. If you plan on having a template for this project then please assign me this issue as I'd like to work on it as a GSSOC'21 participant.

Sure that would be great!

I want to work on this issue.

@AnjaliPatle start your PRs.  1 more day to complete


Hyperledger Identus Q3 2024 report

Closing PR in favor of https://github.com/LF-Decentralized-Trust/governance/pull/44/


NPE from ably-java SDK

We've observed exceptions that seem to be coming from the ably-java SDK. This is strange because when analyzing the error trace I could not find any usage of the PresenceMessage.clone() method in the mentioned files. We should investigate it and decide whether that's an AAT issue or an ably-java issue.
Exception: io.ably.lib.types.AblyException: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object io.ably.lib.types.PresenceMessage.clone()' on a null object reference
       at io.ably.lib.transport.ConnectionManager.onMessage(ConnectionManager.java:1159)
       at io.ably.lib.transport.WebSocketTransport$WsClient.onMessage(WebSocketTransport.java:183)
       at org.java_websocket.client.WebSocketClient.onWebsocketMessage(WebSocketClient.java:641)
       at org.java_websocket.drafts.Draft_6455.processFrameBinary(Draft_6455.java:959)
       at org.java_websocket.drafts.Draft_6455.processFrame(Draft_6455.java:912)
       at org.java_websocket.WebSocketImpl.decodeFrames(WebSocketImpl.java:401)
       at org.java_websocket.WebSocketImpl.decode(WebSocketImpl.java:233)
       at org.java_websocket.client.WebSocketClient.run(WebSocketClient.java:516)
       at java.lang.Thread.run(Thread.java:919)

Before trying to fix this I think we should add  Leak canary to the project.

I think this crash can occur only in Presence.endSync method in ably-java.
Which is called in Presence.endSyncAndEmitLeaves()
which can be called in Presence.setPresence here and here.
which is called Channel.onPresence or in ChannelBase.onSync
both are called in ChannelBase.onChannelMessage
which is called in AblyRealtime.onMessage
which is called in ConnectionManager.onChannelMessage
which is called in ConnectionManager.onMessage either here or here as both would match the stack trace we got from DH

The proposed fix for this issue has been released for the underlying, core SDK: https://github.com/ably/ably-java/releases/tag/v1.2.21


Can't get generator to work properly

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ x] question about how to use this project

Summary
I'm trying to get the SWR hooks to be generated but the SDK is lacking those. Not sure what I'm doing wrong?

Other information
graphql.ts

export type SdkFunctionWrapper = <T>(action: () => Promise<T>) => Promise<T>;

const defaultWrapper: SdkFunctionWrapper = (sdkFunction) => sdkFunction();
export function getSdk(
  client: GraphQLClient,
  withWrapper: SdkFunctionWrapper = defaultWrapper
) {
  return {};
}
export type Sdk = ReturnType<typeof getSdk>;
export type SWRInfiniteKeyLoader<Data = any> = (
  index: number,
  previousPageData: Data | null
) => string | any[] | null;
export function getSdkWithHooks(
  client: GraphQLClient,
  withWrapper: SdkFunctionWrapper = defaultWrapper
) {
  const sdk = getSdk(client, withWrapper);
  return {
    ...sdk,
  };
}
export type SdkWithHooks = ReturnType<typeof getSdkWithHooks>;

my config
overwrite: true
schema:
  - https://graphql.fauna.com/graphql:
      headers:
        Authorization: "xxx"
generates:
  src/generated/graphql.ts:
    plugins:
      - "typescript"
      - "typescript-operations"
      - "typescript-graphql-request"
      - "plugin-typescript-swr"
  ./graphql.schema.json:
    plugins:
      - "introspection"
config:
  rawRequest: true
  useSWRInfinite:
    - allQuestions

You must set the documents field.
I also fixed it because the example in the document didn't have it.


Another alpha release?

It's two months since alpha6, whereas before, the cadence of alpha release was quite exactly every three weeks. Considering the amount of things still under discussion for beta1, especially considering what "beta readiness" may require, I think it's worth biting the bullet of having one more alpha, rather than holding out for beta1 while hugely increasing the volume of changes.
In fact, it might even be worth having a separate (short-lived!) alpha once "beta readiness" is achieved, to ensure broader testing before actually committing to everything that is being promised by the beta label.

Whether or not to have more alpha releases was discussed at today's OTC meeting which has led to this proposal:
https://mta.openssl.org/pipermail/openssl-project/2020-October/002285.html

Which has passed, the next alpha is Thursday.


change Stream::poll to Stream::poll_next

This was part of the 0.2 RFC.

r? @aturon or @cramertj

@seanmonstar Thanks!


[BUG] Settings should be synced before syncing mappings

What is the bug?
When customer adds new mappings in the leader index and these mappings are dependent on analyzers which are newly defined in the settings, the replay fails on the follower side.
As per this logic, the follower tries to apply the operations directly. If the operations need mapping update, it then tries to sync remote mapping. But the syncing of remote mapping will fail if the settings have not been synced by the metadata polling task which happens every 1 minute.
How can one reproduce the bug?
Steps to reproduce the behavior:

Start replication on follower
Define analyzer in the leader index settings and add new mappings which use this analyzer
Immediately after step 2, start indexing documents which contain the new mappings.
IndexReplicationTask will encounter exception and replication will get auto-paused

What is the expected behavior?
The replication should work successfully by syncing all the settings and mappings
Do you have any additional context?
This problem can be solved by syncing the remote settings before syncing the mappings here

Able to reproduce this locally
curl -XPOST http://${LEADER}/fruit-1/_close
curl -u 'admin:admin' -XPUT "http://${LEADER}/fruit-1/_settings" -H 'Content-Type: application/json' -d \
'{
  "settings": {
    "analysis": {
      "analyzer": {
        "std_folded": {
          "type": "custom",
          "tokenizer": "standard",
          "filter": [
            "lowercase"
          ]
        }
      }
    }
  }
}'

curl -XPUT "http://${LEADER}/fruit-1/_mapping?pretty" -H 'Content-type: application/json' \
-d '
{
  "properties": {
      "my_text": {
        "type": "text",
        "analyzer": "std_folded"
      }
    }
}'

curl -XPOST http://${LEADER}/fruit-1/_open

Then indexing documents
 curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_status?pretty"
{
  "status" : "PAUSED",
  "reason" : "AutoPaused:  + [[fruit-1][0] - org.opensearch.OpenSearchException - \"analyzer [std_folded] has not been configured in mappings\"], ",
  "leader_alias" : "leader-cluster",
  "leader_index" : "fruit-1",
  "follower_index" : "fruit-1"
}

HI @soosinha,
A user will only be able to update the static settings of leader index only after closing the index.
When cross cluster replication is set for a index and the index is closed the index, if there is get changes request during this time then the replication will go into autopaused state, ex:
curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_status?pretty"
{
  "status" : "SYNCING",
  "reason" : "User initiated",
  "leader_alias" : "leader-cluster",
  "leader_index" : "fruit-1",
  "follower_index" : "fruit-1",
  "syncing_details" : {
    "leader_checkpoint" : 0,
    "follower_checkpoint" : 0,
    "seq_no" : 1
  }
}
❯ curl -XPOST http://localhost:9200/fruit-1/_close
{"acknowledged":true,"shards_acknowledged":true,"indices":{"fruit-1":{"closed":true}}}%
❯
curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_status?pretty"
{
  "error" : {
    "root_cause" : [
      {
        "type" : "replication_exception",
        "reason" : "failed to fetch replication status"
      }
    ],
    "type" : "replication_exception",
    "reason" : "failed to fetch replication status"
  },
  "status" : 500
}
❯
curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_status?pretty"
{
  "status" : "PAUSED",
  "reason" : "AutoPaused:  + [[fruit-1][0] - org.opensearch.indices.IndexClosedException - \"closed\"], ",
  "leader_alias" : "leader-cluster",
  "leader_index" : "fruit-1",
  "follower_index" : "fruit-1"
}

If the user closes the index and opens it again, it is possible that getChanges request comes in during this time and Auto-pause the replication. However it is also possible that open and close is done so quickly and the there is no getChanges called between them, hence leaving the replication in syncing state.
If a user does the following

close the index
updates setting to create new analyzer
updates index mapping to use the above analyzer
closes the index
ingest data using the new mapping.

if the above is performed instantaneously, then we see that the replication goes to auto pause with a different reason
 curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_status?pretty"
{
  "status" : "PAUSED",
  "reason" : "AutoPaused:  + [[fruit-1][0] - org.opensearch.OpenSearchException - \"analyzer [std_folded] has not been configured in mappings\"], ",
  "leader_alias" : "leader-cluster",
  "leader_index" : "fruit-1",
  "follower_index" : "fruit-1"
}

To overcome the above the user must simply pause the replicaiton and then update the index settings on leader index and then resume the replication. This will lead to leader index settings to be replicated on follower index.
Testing details

start replication
index documents on leader index
pause replication on follower index
close leader index
update setting and create analyser
update index mapping to use the analyzer
open the leader index
ingest data | optional
resume replication on follower index
ingest data | if not done on step 8

When resume replication is triggered new persistent tasks are spinned up and the leader index settings are synced by IndexReplicationTask.
Adding testing details below:
{
  "status" : "SYNCING",
  "reason" : "User initiated",
  "leader_alias" : "leader-cluster",
  "leader_index" : "fruit-1",
  "follower_index" : "fruit-1",
  "syncing_details" : {
    "leader_checkpoint" : 0,
    "follower_checkpoint" : 0,
    "seq_no" : 1
  }
}
❯ chmod 777 pause_resume.sh
❯ curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_pause"  -H 'Content-Type: application/json' -d  '{}'

{"acknowledged":true}%
❯
curl -XPOST http://localhost:9200/fruit-1/_close
{"acknowledged":true,"shards_acknowledged":true,"indices":{"fruit-1":{"closed":true}}}%
❯ curl -u 'admin:admin' -XPUT "http://localhost:9200/fruit-1/_settings" -H 'Content-Type: application/json' -d \
'{
  "settings": {
    "analysis": {
      "analyzer": {
        "std_folded": {
          "type": "custom",
          "tokenizer": "standard",
          "filter": [
            "lowercase"
          ]
        }
      }
    }
  }
}'

curl -XPUT "http://localhost:9200/fruit-1/_mapping?pretty" -H 'Content-type: application/json' \
-d '
{
  "properties": {
      "my_text": {
        "type": "text",
        "analyzer": "std_folded"
      }
    }
}'

{"acknowledged":true}{
  "acknowledged" : true
}
❯ curl -XPOST http://localhost:9200/fruit-1/_open
{"acknowledged":true,"shards_acknowledged":true}%
❯ curl -XPOST "http://localhost:9200/fruit-1/_doc/99" -H 'Content-Type: application/json' -d '{"value" : "data99", "my_text": "monu singh"}'
{"_index":"fruit-1","_id":"99","_version":1,"result":"created","_shards":{"total":2,"successful":1,"failed":0},"_seq_no":1,"_primary_term":3}%
❯ curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_resume"  -H 'Content-Type: application/json' -d  '{}'

{"acknowledged":true}%
❯ curl -XPOST "http://localhost:9200/fruit-1/_doc/98" -H 'Content-Type: application/json' -d '{"value" : "data98", "my_text": "monu singh"}'

{"_index":"fruit-1","_id":"98","_version":1,"result":"created","_shards":{"total":2,"successful":1,"failed":0},"_seq_no":2,"_primary_term":3}%
❯ curl -k -u 'admin:admin' "http://localhost:9201/_plugins/_replication/fruit-1/_status?pretty"

{
  "status" : "SYNCING",
  "reason" : "User initiated",
  "leader_alias" : "leader-cluster",
  "leader_index" : "fruit-1",
  "follower_index" : "fruit-1",
  "syncing_details" : {
    "leader_checkpoint" : 2,
    "follower_checkpoint" : 2,
    "seq_no" : 3
  }
}
❯ curl "localhost:9201/fruit-1/_settings?include_defaults=true"
{"fruit-1":{"settings":{"index":{"replication":{"type":"DOCUMENT"},"number_of_shards":"1","translog":{"generation_threshold_size":"32mb"},"plugins":{"replication":{"follower":{"leader_index":"leader-cluster:fruit-1"}}},"provided_name":"fruit-1","creation_date":"1692334252284","analysis":{"analyzer":{"std_folded":{"filter":["lowercase"],"type":"custom","tokenizer":"standard"}}},"number_of_replicas":"1","uuid":"8SlRCbGTQ5mfaq_YAcgq2A","version":{"created":"137217827"}}},"defaults":{"index":{"flush_after_merge":"512mb","plugins":{"replication":{"translog":{"retention_size":"536870912b","retention_lease":{"pruning":{"enabled":"false"}}}}},"final_pipeline":"_none","max_inner_result_window":"100","unassigned":{"node_left":{"delayed_timeout":"1m"}},"max_terms_count":"65536","routing_partition_size":"1","force_memory_term_dictionary":"false","max_docvalue_fields_search":"100","merge":{"scheduler":{"max_thread_count":"4","auto_throttle":"true","max_merge_count":"9"},"policy":{"reclaim_deletes_weight":"2.0","floor_segment":"2097152b","max_merge_at_once":"10","max_merged_segment":"5368709120b","expunge_deletes_allowed":"10.0","segments_per_tier":"10.0","deletes_pct_allowed":"20.0"}},"max_refresh_listeners":"1000","max_regex_length":"1000","load_fixed_bitset_filters_eagerly":"true","number_of_routing_shards":"1","write":{"wait_for_active_shards":"1"},"verified_before_close":"false","mapping":{"coerce":"false","nested_fields":{"limit":"50"},"depth":{"limit":"20"},"field_name_length":{"limit":"9223372036854775807"},"total_fields":{"limit":"1000"},"nested_objects":{"limit":"10000"},"ignore_malformed":"false"},"soft_deletes":{"enabled":"true","retention":{"operations":"0"},"retention_lease":{"period":"12h"}},"max_script_fields":"32","query":{"default_field":["*"],"parse":{"allow_unmapped_fields":"true"}},"format":"0","sort":{"missing":[],"mode":[],"field":[],"order":[]},"priority":"1","codec":"default","max_rescore_window":"10000","max_adjacency_matrix_filters":"100","analyze":{"max_token_count":"10000"},"gc_deletes":"60s","searchable_snapshot":{"repository":"","index":{"id":""},"snapshot_id":{"name":"","uuid":""}},"optimize_auto_generated_id":"true","max_ngram_diff":"1","hidden":"false","translog":{"flush_threshold_size":"512mb","sync_interval":"5s","retention":{"size":"-1","age":"-1"},"durability":"REQUEST"},"auto_expand_replicas":"false","mapper":{"dynamic":"true"},"recovery":{"type":""},"requests":{"cache":{"enable":"true"}},"data_path":"","merge_on_flush":{"enabled":"true","max_full_flush_merge_wait_time":"10s","policy":"default"},"highlight":{"max_analyzed_offset":"1000000"},"routing":{"rebalance":{"enable":"all"},"allocation":{"enable":"all","total_shards_per_node":"-1"}},"search":{"slowlog":{"level":"TRACE","threshold":{"fetch":{"warn":"-1","trace":"-1","debug":"-1","info":"-1"},"query":{"warn":"-1","trace":"-1","debug":"-1","info":"-1"}}},"default_pipeline":"_none","idle":{"after":"30s"},"throttled":"false"},"fielddata":{"cache":"node"},"codec.compression_level":"3","default_pipeline":"_none","max_slices_per_scroll":"1024","shard":{"check_on_startup":"false"},"max_slices_per_pit":"1024","allocation":{"max_retries":"5","existing_shards_allocator":"gateway_allocator"},"refresh_interval":"1s","indexing":{"slowlog":{"reformat":"true","threshold":{"index":{"warn":"-1","trace":"-1","debug":"-1","info":"-1"}},"source":"1000","level":"TRACE"}},"remote_store":{"translog":{"buffer_interval":"650ms"}},"compound_format":"0.1","blocks":{"metadata":"false","read":"false","read_only_allow_delete":"false","read_only":"false","write":"false"},"max_result_window":"10000","store":{"hybrid":{"mmap":{"extensions":["nvd","dvd","tim","tip","dim","kdd","kdi","cfs","doc"]},"nio":{"extensions":["segments_N","write.lock","si","cfe","fnm","fdx","fdt","pos","pay","nvm","dvm","tvx","tvd","liv","dii","vec","vem"]}},"stats_refresh_interval":"10s","type":"","fs":{"fs_lock":"native"},"preload":[]},"queries":{"cache":{"enabled":"true"}},"warmer":{"enabled":"true"},"max_shingle_diff":"3","query_string":{"lenient":"false"}}}}}%

As we can see from the last output, replication is in SYNCING state and the leader index mapping std_folded is now synced on follower index.

Thanks @monusingh-1 for working on this and verifying the behavior.
If the analyzer settings were dynamic, only then it would have been a bug. But since the index has to be closed before updating the analyzer settings, auto-pause of replication is the expected behavior


Button associated with a list item to trigger an action

I'd like to be able to display a button associated with a list item to trigger an action when it's clicked.
This button needs to have a custom name, so that it can be different for each item in the list. It will probably be displayed before the icon. When a button is clicked, the list item must be written to a file (or something better) so that a loop can read the file and determine that a specific button has been clicked. swiftDialog does not need to execute any action, but only give a report of what was clicked.
I have no alternative for this scenario.

Hi - I don't see a use case for this that can't be served by checkboxes using a switch style, which can also display an app icon.
Performing actions within a running dialog based on user input in that same dialog is currently not something im working on but may look at in the future.

Hi. In the first project requiring this function, a main dialog (pane) has an item list dynamically populated by external events (not linear workflow). And on a specific item list, you may choose to click on a "Details" button to display a dialog which is also going to have a dynamic list of items reporting what is happening on the list item clicked (linear workflow). The mechanism only knows to be informed that a "Details" button has been clicked to trigger the display of a new dialog. If technically feasible, I will be very happy to finally being able to give a chance to this project thanks to swiftDialog. DEPNotify was obviously limited to linear workflows whereas it appears it clearly appears that swiftDialog can break this boundary. So let's see what the future is going to be !

closing as wontfix (more accurately, not that it isn't a good idea, but I don't have any immediate plans to implement something like this since swiftDialog currently does not have any in-progress actions and adding that type of stuff isn't on the radar)


update SAML Attribute and Identifier requirement

if more than one slack applications need to integrate with AAD, please change Identifier to your slack application URL https://<DOMAIN NAME>.slack.com but https://slack.com

@newgamer1117 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: newgamer1117 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @newgamer1117 - Thank you for your pull request. Would you take a moment to sign the CLA? After the CLA is signed, we can merge your changes. Thanks!

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver I've signed


✨ Test: Create test.so

Do not review, this is a test.

@laurentsimon Can we close this?

sure. Closing


Add translation of keynote speaker profiles

Big thanks to 昱廷 for the translation！
Close #92.

Current coverage is 94.20%

Merging #127 into master will not affect coverage as of 4f87790

@@            master   #127   diff @@
=====================================
  Files           31     31
  Stmts         1000   1000
  Branches         0      0
  Methods          0      0
=====================================
  Hit            942    942
  Partial          0      0
  Missed          58     58

Review entire Coverage Diff as of 4f87790

Powered by Codecov. Updated on successful CI builds.

竟然沒有 merge …耍蠢了…


[SPIRV] Break SPIRVVectorize pass into GenericVectorization and SPIRVVectorLowering passes.

This removes vectorization patterns from SPIRVVectorize pass and delegate it to GenericVectorization. It renames the old pass to SPIRVVectorLowering because it is mainly lowering vector ops.

I was wondering how DNS could test if there was a regression :P

I was wondering how DNS could test if there was a regression :P

haha, should renamed it to WIP. :p

@qedawkins submitted this in https://github.com/openxla/iree/pull/15009, so I'm going to close this one


Remove extra namespace scope identifier

Problem
What is being fixed?  Examples:

Already in namespace {}, extra namespace with same scope identifier

Change overview
Remove extra namespace scope identifier
Testing
How was this tested? (at least one bullet point required)

Cleanup only, no logic change

dup of 16082


Asset Store link dead

The asset store page linked in the README is now dead.

Thanks for letting me know. I updated the readme to keep a link there for anyone who already had that package added to their assets, and included a new link to help you find alternatives.


merge 3 ecs feature flags to 1

What does this PR do?

Currently users need to set three feature flags to enable ecs task collection.

DD_CONTAINER_LIFECYCLE_ECS_TASK_EVENT_ENABLED
DD_ORCHESTRATOR_EXPLORER_ECS_COLLECTION_ENABLED
DD_ECS_TASK_COLLECTION_ENABLED

This PR deletes first 2 feature flags and update agent to only rely on the last one to simplify the setup.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes
Create an ECS Cluster and Deploy the Datadog Agent:
Set up an ECS cluster and deploy the Datadog agent.
Update the agent's task definition by adding the following environment variables:
{
"name": "DD_ECS_TASK_COLLECTION_ENABLED",
"value": "true"
},

Verify Agent:
Ensure the agent is correctly sending task payloads.
Use the agent status command to check and confirm the number of tasks being sent.

LGTM but just want to make sure that ecs_task_collection_enabled will not be used independently from the orchestrator collection

Yes, currently only orchestrator collection needs ecs_task_collection_enabled.  We can set this flag to true in the feature

/merge


Added a German translation of the 2.0 version

This is a German translation of the Open Definition V2.0.

Thanks!


Release REX-Ray 0.4.0

This patch marks the release of REX-Ray 0.4.0.

Coverage remained the same at 44.98% when pulling 62cc75eda0d9b9635fb16f018324094bac99b04d on akutz:release/0.4.0 into 9705dfeb17644b36563d9dd9e5af8c3701b9aea6 on emccode:master.

[Current coverage][cc-pull] is 45.98%

Merging [#467][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #467   diff @@
==========================================
  Files             2          2
  Lines           187        187
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits             86         86
  Misses          101        101
  Partials          0          0

[][cc-pull]

Powered by Codecov. Last updated by [9705dfe...62cc75e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/rexray/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/rexray/compare/9705dfeb17644b36563d9dd9e5af8c3701b9aea6...62cc75eda0d9b9635fb16f018324094bac99b04d
[cc-pull]: https://codecov.io/gh/emccode/rexray/pull/467?src=pr


Expose complete Tracing APIs in the tracing toolkit

[ ] If this is non-trivial feature, paste the links/URLs to the design doc.

[ ] Update the documentation to include this new feature.

[x] Tests(including UT, IT, E2E) are added to verify the new feature.

[ ] If it's UI related, attach the screenshots below.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<9999>.

[ ] Update the CHANGES log.

A question, how do you make toolkit works in the test scenario?

A question, how do you make toolkit works in the test scenario?

The CI shows the build failure. I think when I write the test scenarios, there are some wrong maven operations. I try to re-clone the project now, it can't build successfully in local. I will fix it, sorry.

A question, how do you make toolkit works in the test scenario?

I just call the every toolkit method in specific condition, such as new HTTP request, new thread. I see the CI shows the build failure. I cannot get what the failure means. All scenarios are ok in my local.

I think I should add license header to the TestService file.

A question, how do you make toolkit works in the test scenario?

I just call the every toolkit method in specific condition, such as new HTTP request, new thread. I see the CI shows the build failure. I cannot get what the failure means. All scenarios are ok in my local.

I mean we don't have released new toolkit, how does your maven dependency work?

I simulate the original toolkit scenario that add the toolkit java file into the test scenario.

OK, I see.

Please fix code style. The style file is in the root.

Happy Chinese New Year @wu-sheng . I see that there are two errors and many jobs cancelled when do the CI test and plugins-test.3.yaml test, but I am confused about the error hint. Could you give me some suggestions?

https://github.com/apache/skywalking-java/actions/runs/3973854409/jobs/6812802618#step:5:1
Read this. It reports there is a new plugin. Do you forget to follow the existing key?
BTW, cancelled tasks means pre conditions or parallel tasks had failed.
Focus on the error status ones.

https://github.com/apache/skywalking-java/actions/runs/3973854409/jobs/6812802618#step:5:1
Read this. It reports there is a new plugin. Do you forget to follow the existing key?
BTW, cancelled tasks means pre conditions or parallel tasks had failed. Focus on the error status ones.

I get why errors happen. I add new key toolkit-tracer in the skywalking-plugin.def but not change the Plugin-list.md. So in should I just follow the old key toolkit-trace or add new key into the Plugin-list.md.

As tests passed, you should update manual APIs docs about how to use these new APIs.

As tests passed, you should update manual APIs docs about how to use these new APIs.

Ok, I will do it.

Actually, I have some questions about tag API design. Do you think I should add tag API into the SpanRef class just like the log API?

Yes, I think we should provide complete APIs in spanRef.

Ok, I will do it.

One more suggest, please rename test name from apm-newtoolkit-trace-scenario to apm-tracer-toolkit-scenario
New is not a proper word as this test would exist for years.

As tests passed, you should update manual APIs docs about how to use these new APIs.

If I finish the docs about the new API, how should I submit them?

What do you mean how? Do you mean update the existing toolkit doc or create a new one?

What do you mean how? Do you mean update the existing toolkit doc or create a new one?

 Just ignore this question, haha.

https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-trace/
This doc should be split as several docs and listed on the menu

Add trace toolkit dependencies
Use native tracer
Read tracing context
Annotations
Use correlation context

2 should include ActiveSpan APIs

https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-trace/
This doc should be split as several docs and listed on the menu

Add trace toolkit dependencies
Use native tracer
Read tracing context
Annotations
Use correlation context

2 should include ActiveSpan APIs

Actually, I have completed the docs with the five parts you listed in use cases which are Span creating, inject/extract capture/continue, tag and log for span, async prepare/finish for span crossing threads. So for the current parts you listed, should I also write docs for original trace toolkit? Because I think I have no annotations.

https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-trace/
This doc should be split as several docs and listed on the menu

Add trace toolkit dependencies
Use native tracer
Read tracing context
Annotations
Use correlation context

2 should include ActiveSpan APIs

Actually, I have completed the docs with the five parts you listed in use cases which are Span creating, inject/extract capture/continue, tag and log for span, async prepare/finish for span crossing threads. So for the current parts you listed, should I also write docs for original trace toolkit? Because I think the new API has no annotations.

The parts are for you to reorganize your new one and existing docs  into one list.
Yours are good, they should be in my (2)

The parts are for you to reorganize your new one and existing docs into one list. Yours are good, they should be in my (2)

I think the menu you list is of Application-toolkit-trace.md. So should I only modify this file or create a new file? BTW, whether the heading is banned in the markdown docs?

You could keep one if you want. Each menu needs a new file .
What do you mean banned? Which markdown format actually?

I add the tag API, change apm-newtoolkit-trace-scenario to apm-toolkit-tracer-scenario and upload my original doc about new designed API.

You could keep one if you want. Each menu needs a new file . What do you mean banned? Which markdown format actually?

I can't really get what you mean. Do you mean that I should new five markdown files corresponding "Add trace toolkit dependencies", "Use native tracer", "Read tracing context", "Annotations" and "Use correlation context" respectively? And my newly designed API should be in the "Use native tracer" file. Other files should contain the docs of the old API.
The banned means that I find no one uses heading(in markdown syntax are #, ##, ###, ...) in the markdown docs.

The banned means that I find no one uses heading(in markdown syntax are #, ##, ###, ...) in the markdown docs.

This is supported.
https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/java-plugin-development-guide/
Multiple levels are supported. Check this doc markdown.

I can't really get what you mean. Do you mean that I should new five markdown files corresponding "Add trace toolkit dependencies", "Use native tracer", "Read tracing context", "Annotations" and "Use correlation context" respectively?

Yes, five docs. The contents include your new write and existing doc(https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-trace/)

The banned means that I find no one uses heading(in markdown syntax are #, ##, ###, ...) in the markdown docs.

This is supported.
https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/java-plugin-development-guide/
Multiple levels are supported. Check this doc markdown.

I can't really get what you mean. Do you mean that I should new five markdown files corresponding "Add trace toolkit dependencies", "Use native tracer", "Read tracing context", "Annotations" and "Use correlation context" respectively?

Yes, five docs. The contents include your new write and existing doc(https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-trace/)

Ok, I get it. One other question, should I consider this doc https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-trace-cross-thread/ ?

I have completed these five docs.

Ok, I get it. One other question, should I consider this doc https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/application-toolkit-trace-cross-thread/ ?

Maybe merge this as 6th?

Ok, I will do it. But I think the thing I need to do for this cross-thread-doc is only removing the dependency part.

I have completed these five docs.

You need to update menu.yml to add  this as sub menu items.

Changes.md seems not updated.

lgtm. Thanks for your contributions.

Ok, it is a wonderful first-issue experience for me. I'm sorry for the doc is still for more polish including the titles and import things which I want to do more changes today.
I hope to do more contributions to the skywalking community, see you next time.


Add params_to_tune prototype for native NNs (RNNModel, MLPModel)

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Proposed Changes
Look at #1196. Here we also propose an alternative signature for the hyperparameter tuning.
Closing issues
Closes #1196.

Codecov Report

:exclamation: No coverage uploaded for pull request base (automl-2.0@636c64f). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             automl-2.0   #1217   +/-   ##
============================================
  Coverage              ?   7.70%
============================================
  Files                 ?     177
  Lines                 ?   10586
  Branches              ?       0
============================================
  Hits                  ?     816
  Misses                ?    9770
  Partials              ?       0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

It was decided that solution isn't good:

Difficult to customize
Too much coupling with optuna


apparmor: Add apparmor profile for postgresql

Add apparmor profile in the postgres ami image.
Signed-off-by: Lakshmipathi Ganapathi<EMAIL_ADDRESS>

@darora @dragarcia @inian Draft with postgres profile. Need to add pgbouncer profile too.


jsuri: need to declare global Uri as type instead of var

Declaring the global Uri as a var instead of as a type leads to runtime
errors as the jsuri script leaks Uri to global directly when not loaded
via AMD or CommonJS, instead of leaking a jsuri module object.
Developers working with jsuri in the global namespace need to use Uri
directly instead of prfacing with jsuri in order to avoid runtime issues
with 'jsuri' being undefined.

Actually, before accepting this, perhaps it needs a bit more than the regular check. I'm not sure how to really handle this particular situation, so I could very well have screwed up here or even in the original PR for jsuri. Someone want to give some advice?

@coldacid thanks mate!

I think may be the responsibility of the user.


added custom color props for primary and secondary toast buttons

This is an attempt to add the enhancement requested in Issue 21 (https://github.com/acidjazz/tv-toast/issues/21). If this isn't the best way to fix this, I would be happy to take feedback and try again.

@SandraRodgers Thanks for the PR! I'll look it over and test it ASAP

@acidjazz Great! By the way, it's a great component. Very clean and easy to use.

This looks great so far, I wonder if we could:

[ ] move the other classes that style the button into this ( the focus classes and active:bg-gray-50)
[ ] if we could have these classes stack w/ what you pass through, so that you can style it w/out having to specify all of them.

Ok, I have attempted to make the classes 'stackable' like you suggested. I wasn't sure about names for the props so you might want to change those (or tell me what to change them to).... I tried not to make them too long but still understandable regarding the type of toast (single action or multiple). Also, I had forgotten to add the props for the single action toast so added that in this commit. Let me know if you have any other suggestions to make this better!

@SandraRodgers names are great! this looks good so far, I'll run through it and test stuff ASAP!

@SandraRodgers BTW I actually went back to your simpler setup realizing stacking isn't as realistic as I thought, i added some detail in the readme to let people know what defaults will be swapped out.

That's good, I liked the stacking idea but I can see how having just one prop for each button might be more straightforward for someone looking to style the buttons. Happy I was able to contribute!


Wxa validate

增加目标值获取和对比逻辑
主要用于设置密码，再次确认密码场景

Codecov Report

Merging #25 into dev will decrease coverage by 0.27%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##              dev      #25      +/-   ##
==========================================
- Coverage   94.69%   94.41%   -0.28%
==========================================
  Files          63       63
  Lines        1017     1021       +4
  Branches      270      271       +1
==========================================
+ Hits          963      964       +1
- Misses         44       46       +2
- Partials       10       11       +1

Impacted Files
Coverage Δ

packages/wxa-validate/src/utils/index.js
83.33% <25%> (-5.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d49f0...473155b. Read the comment docs.


Project Structure Documentation page not working

What would you like to share?
The Project Structure Documentation link in readme leads to a "Page not found". It should lead to a page with proper context which would help especially the beginners to understand and contribute to the project.
Additional information
No response
Would you like to work on this issue?

[ ] Yes, I want to work on this issue!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Yeah, the markdown file is removed now so it is showing 404. I think we have two options here

we remove the link and update the readme and act as if is never there
we create a new project-structure file and talk about the new project structure since the project has moved to nextjs.


Ruff linter and ruff formatter conflict

Currently, pre-commit runs ruff lints before ruff-format. This can be annoying when pre-commit is used to format the code because the linter may fail due to formatting issues (such as line length) before the formatter runs. I see two potential solutions:

Reorder the ruff and ruff-format hooks so that formatting occurs first.
Disable lint rules related to formatting issues.

@hombit, ruff does not recommend ordering these hooks when using the linter with "--fix":

When running with --fix, Ruff's lint hook should be placed before Ruff's formatter hook, and before Black, isort, and other formatting tools, as Ruff's fix behavior can output code changes that require reformatting.

The formatter would help us to remove linting issues for some of the rules (e.g. line-too-long) but then we'd have to rerun the formatter after the linter to make sure its automatic changes didn't break the format. It's another kind of egg-chicken problem. Closing it for now!


fix(challenges): Edit Description, Add Tests and Solution for Project Euler 40

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX
Description

Updated the problem description to more closely match the one on the Project Euler page. Also added more tests along with a solution that user @elliotjz contributed to the fCC Arcade Mode.
BREAKING CHANGE: None
Here's the solution for QA:
function champernownesConstant(n) {
  let fractionalPart = '';
  for (let i = 0; fractionalPart.length <= n; i++) {
    fractionalPart += i.toString();
  }

  let product = 1;
  for (let i = 0; i < n.toString().length; i++) {
    const index = 10 ** i;
    product *= parseInt(fractionalPart[index], 10);
  }

  return product;
}

@scissorsneedfoodtoo thanks a lot for all the updates to the project euler sections!

@raisedadead, of course! Thank you for QAing and merging all of these.


fix: trim test name

This should help with integration of older/less well written test names.

Damn this doesn't actually work. Need to put the processing elsewhere.

This works now. It's a bunch more complicated but it makes sure each part of the name path is trimmed and escaped.


[FEATURE] : Update the logo of the website

Hey contributors,
I think the logo of the website needs to be changed. do mention if you want to work on this, then I'll assign

@PritamSarbajna  hey , we would like to take up this issue and create a project
Contributors: Sayali Ghanwat , Nilesh Jha , Ritik Jain , Sidhharth Kanojia .

@sayalihere Go for it ✨

Hello,looks like the issue is still open,can you please assign me to it ?
i would be very grateful

Hey @akuliakuli thanks for being interested in this repo but unfortunately this issue is been assigned to @sayalihere.
Feel free to check other issues or if you want to collaborate just contact with the assignees 🙌

Hey i love making Logo for website. I would love to work on this issue and can provide a great logo for website


Make errors be highlighted in red and warnings in orange

For make file, makes it easier to read

@James-Sangalli search for how to make xmllint behave?

@James-Sangalli this is related to #129 129


-[SDWebImageDownloadToken cancel]: unrecognized selector sent to instance 0x158d60360 (null)

New Issue Checklist

[ ] I have read and understood the CONTRIBUTING guide
[ ] I have read the Documentation
[ ] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
e.g. ios / tvos

Platform Version
e.g. 8.0

SDWebImage Version
e.g. 3.7.6

Integration Method
e.g. carthage / cocoapods / manually

Xcode Version
e.g. Xcode 7.3

Repro rate
e.g. all the time (100%) / sometimes x% / only once

Repro with our demo prj
e.g. does it happen with our demo project?

Demo project link
e.g. link to a demo project that highlights the issue

Issue Description and Steps
Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

Feel free to reopen the ticket after providing the data required in the issue template


KAFKA-14452: Make sticky assignors rack-aware if client rack is configured (KIP-881)

Best-effort rack alignment for sticky assignors when both consumer racks and partition racks are available with the protocol changes introduced in KIP-881. Rack-aware assignment is enabled by configuring client.rack for consumers. The assignment builders attempt to align on racks on a best-effort basis, but prioritize balanced assignment over rack alignment.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@dajac Thanks for the initial review, have addressed your comments.


fix(perf): get current commit tag in CI

Fix the way how we get a tag of a current commit in CI.
Changelog left blank.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


for non-increment primary key

Eloquent will set key attribute as last insert id. But some time our primary key is not auto increment. Even, it may be a string. It will be mistakenly set as 0 in these case.
Please take a little change with Illuminate\Database\Eloquent\Model::insertAndSetId(), so that we can configure whether primary key is auto increment.

Set the incrementing property to false on your model.

From our docs:

https://laravel.com/docs/master/eloquent


Currently, the watch option to confd isn't supported.

This adds it to confd.toml if specified

thanks for the contribution @gozer


Enhance centralized published dependency resolution

Separate coordinate resolver into two interfaces -- once which resolves to variant precision and one which resolves to coordinate precision Split resolving methods into two, one accepting external dependency one accepting project dependencies This allows the module dependency methods to return null, allowing us to remove need for the weird version dependency mapper Use ObjectMapper to instantiate publishing types, since they have a lot of dependencies Pull ResolvedCoordinates into its own top-level class
In general, this commit un-does some of the logic consolidation done in previous work, but results in less indirection and easier to follow code. The primary advantage here is the removal of the declared version mapper, which felt very out of place in the first PR
Follow-up to: https://github.com/gradle/gradle/pull/26276

@bot-gradle test this

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Fix nightly CD for GPU builds

Description
This PR fixes nightly CD GPU tests by updating the build toolchain to use cmake static build and updating dnnl headers stash location. It removes 7.5 arch for cu100, cu101, cu102 builds to solve oversized libmxnet.so binary issue with cmake builds.
It also fixes the issue with dnnl headers packaging into nightly build artifacts. Fixes #18120
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Also @mseth10 do you mind updating the description [removing extraneous content] and also adding the Jenkins Pipeline build where you tested it out or a command you used to reproduce & test this fix. Thanks

@ChaiBapchya updated the description. Check it out.

Retriggered one previously broken pipeline as http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job/detail/mxnet-cd-release-job/1048/pipeline


Check user-groups permissions before offering "Mark as resolved"

From the Help Center doc on the "Mark as resolved" feature:
https://zulip.com/help/resolve-a-topic

Users can resolve and unresolve a topic if they have permission to edit topics. Organization administrators can configure who can edit topics.

If the user doesn't have permission to resolve/unresolve a topic, we shouldn't offer the button for it, because it takes up space and will always show a server error when they tap it (maybe after making them wait a while on a slow connection).
I've left this out of my work on #744 for expediency; the button is just always offered. The client-side permission check is also not implemented in the legacy RN app.
We're transitioning to a new permissions system based on user groups:

#814

Let's plan to implement this just in that new system, skipping the old system, so we don't have to implement it twice. That'll just mean giving the same behavior as the legacy RN app until the server is upgraded to version 10 or later.

Note the ongoing work to build a dedicated permission: https://github.com/zulip/zulip/issues/21811 / https://github.com/zulip/zulip/issues/21811.
In the future, I expect this to additionally be controlled by a per-channel permission (details TBD).


[pigeon] The flutter create command should have a flag to generate a plugin boilerplate (in Swift/Kotlin) which uses pigeon for easier setup

Use case
This would make it much easier to use pigeon in a new plugin.

Proposal
Enhance the flutter create command to add an option to generate the boilerplate project for a plugin which uses pigeon.
An additional flag like --pigeon would be easy for new developers to use.

cc @gaaclarke

I don't think flutter create --sample services supports pubspec templates, only dart classes?

@jmagman My first thought was that the tool could support arbitrary templates that can be authored.  flutter create -t ~/templates/pigeon_swift.flutter_template

See https://github.com/flutter/flutter/issues/15279

See also conversations in https://github.com/flutter/flutter/issues/13611, https://github.com/flutter/flutter/issues/18819, and https://github.com/flutter/flutter/issues/14719.

See also conversations in https://github.com/flutter/flutter/issues/13611, https://github.com/flutter/flutter/issues/18819, and https://github.com/flutter/flutter/issues/14719.


Add basic image parser fuzzing

Hi!
I wrote a fuzzer, and it found some issues. Asking for it to be merged even if the problems are not fixed.
I wrote a unit test to have a place to put the bad input I found, so it's easier to reproduce and possible to prevent the problem from appearing in the future. Unfortunately, the unit test works differently on posix and non-posix, since I did not want to demand C++17 or boost filesystem to recurse the input directory.
These problems were found, undefined behaviour sanitizer is needed to reproduce. I also could not reproduce all problems with gcc, clang was needed.
integer overflow when allocating data
this has been fixed, by adding the overflow check (integer_utils.h). There is a binary file which triggers the error, but since it's fixed now the file passes without problems. To reproduce, build the unit test with clang and address sanitizer.
Status: fixed
out of range value casted to unsigned char
This is commented in the pixel.h file, and there is an example file.
Status: unfixed
reference binding to null pointer of type 'dlib::rgb_pixel
I believe this is because the data pointer is empty or the index is invalid, but I'm not sure since I did not look into it. I just added an example file integer_overflow_and_nullpointer.bin that provokes it, and added an assert in the pixel.h file (maybe insufficient).
Status: unfixed
signed integer overflow in image_loader.h
0 - biHeight overflows if biHeight is INT_MIN. added a comment, and there is an example file to provoke it.
Status: unfixed
large allocations
I think it's problematic if a small input file can result in a (unreasonably) large allocation. One of these is inside giflib, so that is not dlib's problem. But there are other places where it would make sense to be a bit more skeptic to the input, I wrote a comment about it in serialize.h
Fuzzing will find these allocations quite quick if using address sanitizer. I think there's a problematic middle ground between reasonably small allocations and ridiculously large ones. The former will be fast anyway and the latter will cause an exception std::bad_alloc to be thrown which is good. However, inbetween a lot of memory will be used and if it's initialized, it may slow down the process a lot. This warrants a more pessimistic attitude against the input data, IMHO.
Fuzzing
I had to modify the code here and there to make it go faster - fuzzing this was extremely slow (one case per second or so) but with the fixes, it is at least 50 a second or so, which also is slow. You are probably the best person to point out what could be changed to get the speed up.
The HangChecker class could be adjusted a bit, to account for evil input not hogging the parser. For now, it's only limited in fuzz mode and does nothing in production mode.
Cheers,
Paul

Hmm, I don't get why appveyour doesn't like check_c_source_compiles ?
Unknown CMake command "check_c_source_compiles"

I used cmake 3.10 on Ubuntu while developing, and appveyour has 3.13.3 according to the output.
I'm too tired to troubleshoot this now, sorry.

Hmm - have you considered using boost/safe_numerics to address these sorts of problems? https://github.com/boostorg/safe_numerics

Hmm - have you considered using boost/safe_numerics to address these sorts of problems? https://github.com/boostorg/safe_numerics

@robertramey Yes, I did not want to bring in a dependency on boost (especially when it's so newly added).

Yes, please don’t add any new dependency.

On Jul 19, 2019, at 2:48 PM, Paul Dreik<EMAIL_ADDRESS>wrote:
Hmm - have you considered using boost/safe_numerics to address these sorts of problems? https://github.com/boostorg/safe_numerics
@robertramey Yes, I did not want to bring in a dependency on boost (especially when it's so newly added).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I fixed some of the issues, but I really would like you to reconsider having the fuzzing constructs in the master branch. Having a separate branch for fuzzing leads to manual maintenance - every time you make a change on master, someone needs to update that branch. I have done that during development of the fuzzers in fmt, and it's not a long term solution.
The fuzzer itself lives in a separate directory, just like the tests, so it should not be interfering with anyone.
I think the results above, from a very basic shot at fuzzing, show that it is indeed useful and worth a bit of uglification of the source code.

I fixed some of the issues, but I really would like you to reconsider having the fuzzing constructs in the master branch. Having a separate branch for fuzzing leads to manual maintenance - every time you make a change on master, someone needs to update that branch. I have done that during development of the fuzzers in fmt, and it's not a long term solution.
The fuzzer itself lives in a separate directory, just like the tests, so it should not be interfering with anyone.
I think the results above, from a very basic shot at fuzzing, show that it is indeed useful and worth a bit of uglification of the source code.

I do a lot of this kind of testing myself, but I don't commit the code that involves intrusive changes to the actual library.  So I'm already accustomed to the churn, and normally just throw away the code.
Can you break this PR up into specific PRs targeted at fixing the issues surfaced by fuzzing while keeping any instrumentation code used for finding them in a separate fork?  I'm cool with stuff like safe multiplies being in dlib main though.  That's all to the good.

I submitted the bugfixes on separate pull requests as instructed.
Would you be ok with add the fuzzers in the fuzzer/ directory on master? They won't interfere since it's just a subdirectory not being referenced. The constructs for preventing slow input could be kept on another branch, preferably in this repo instead of mine. That means people wanting to use or contribute to fuzzing, could find them in this repo.
Closing this pull request anyhow.

Yeah I'm happy with that, so long as no intrusive code is in master.  But certainly fuzzer tooling could be in master, in tools/fuzzer, dlib/testing/fuzzer, or some similar location.  I'm not totally sure why the intrusive code is needed at all though.  Why can't a timeout at a higher level be used?  That's what I typically do when I do this kind of testing.  This keeps any fuzzing code out of the actual codebase.