Using outdated containers (at least for testing)

When I was doing some other changes and executed tests in container I found that your containers are still on Fedora 31 which is not supported anymore.
I don't know the exact impact so I don't want to create PR to fix this, however, it would be nice to update the Dockerfiles.
Low priority of course ;)

Thanks for that. You are right. We don't use this image as a base for service images anymore. And it was nearly removed (#1007) because we don't use it much. It's there mainly for non-fedora users that can't install packit on the host.
@jpopelka Were there any problems with moving to the newer image? (The service is based on f32.)
Looks like this needs to be removed:
https://github.com/packit/packit/blob/6a1be282719acd4055503826a18fdae27d110389/Dockerfile#L2

Were there any problems with moving to the newer image?

I tried to remove it completely, not move to a newer base image, so I can't answer :-)

I tried to remove it completely, not move to a newer base image, so I can't answer :-)

..;) I know, but you are the more relevant person. I think.
Thanks for the quick fix.

Thanks for solving this!


build(lint): lint GitHub Actions via actionlint

Issue or need
When altering GitHub Actions code (workflows, composite actions) it usually happens that you push changes only to find no jobs were run due to a syntax error. Let's add some tooling to validate and have quick feedback & prevent running invalid workflows / composite actions.

Proposed changes
Add & configure actionlint to lint GitHub Actions code.
Locally, given this tool must be installed / run via Docker and not every dev will alter GitHub Actions related files, the linting of those is optional. This way, no extra burden is added to start developing on the repository. For this reason, a script is created so that if actionlint command can't be found, a warning is raised, but no error happens.
In CI/CD, the Docker version is used as stated in docs as it's the most minimal way to run it. It also provides the benefit that the latest tag will be maintained by dependency updates bot. Ensuring consistent runs of the linter.
The run scripts in package.json regarding linting have been reorganized so that pnpm run lint lints everything (in parallel thanks to pnpm): code, commit messages & GitHub Actions files
Contributing guide has been updated to document this new tool.
Other extra changes:

Split commit messages convention to move tasks related to linting commit messages to the linting section.

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#692  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Wrap async generators with contextlib.aclosing

Fixes #158 – more details there.
It seems the aclosing context manager needs to be called for each nested async for loop. This PR does that.
Looks like #30 may have been due to the same problem – so this should resolve that, too.

Very much thanks for your contribution!
It's frustrating to wrap everything in aclosing.

Many thanks for merging – and thanks again for the library!


Dynamic field names in sideload()?

We have a environment that we are monitoring with a pretty high number of filesystems that presents a lot of variability in required threshold values, I've been using sideload with success for having host or group specific thresholds, but I am not sure I am going to be able to achieve my desired goal with device level overrides.
Here is what I have so far:
var window = 5m

var data = stream
|from()
    .measurement('disk')
    .where(lambda: "host" == 'test')
    .groupBy('host', 'device')
|window()
    .period(window)

|sideload()
    .source('file:///etc/kapacitor/sideload')
    .order('host/{{.host}}.yml', 'serverclass/{{.serverclass}}.yml')
    .field('disk_usage_warning_level', 95)
    .field('disk_usage_critical_level', 97)

|alert()
    .id('{{ .TaskName }}{{ index .Tags "host"}}//{{ index .Tags "device" }}')
    .message('[{{ .TaskName }}] {{ index .Tags "host" }} disk: {{ index .Tags "device" }} is at {{ index .Fields "used_percent" | printf "%0.2f" }}% utilization.')
    .warn(lambda: "used_percent" > "disk_usage_warning_level")
    .crit(lambda: "used_percent" > "disk_usage_critical_level")
    .pagerDuty2()

This works great, but it doesn't allow me to override at a path level.
Right now my 'test.yaml' override file for the test machine looks like:
#test.yaml
disk_usage_warning_level: 90
disk_usage_critical_level: 95

I want to be able to do something like this:
#test.yaml
disk_usage_warning:
    /var/local/docstore/index/docserviceD/rev2-complete: 30 #Matches a specific mountpoint
    /var.*: 99 #Regex matches any other mountpoints in /var
   default: 90 #Uses this if nothing more specific is found
disk_usage_critical: 95

Which I'm fairly certain is currently impossible.
I know normally I would be able to do something like adding to sideload.order:
'host/{{.host}}/{{.path}}.yaml', but the problem is that my paths have backslashes in them (of course) so I can't create a filename out of them anyways (plus, our environment has over 10,000 individual file systems....that is a lot of yaml files to manage).
Anyone have any suggestions on a better way to do this? Is it possible to dynamically name the sideload field to include the name of the path or something like that?

You could use strReplace to build a sideload string and get around the fact you have / in your paths. That doesn't reduce the number of yaml files, but it does allow supporting paths properly.

I tried doing this, but it still grabs the host level override even though it is second in the list:
`var window = 5m
var data = stream
|from()
.measurement('disk')
.where(lambda: "host" == 'tst-doc2')
.groupBy('host', 'device', 'path')
|window()
.period(window)
|eval(lambda: strReplace("path", '/', '_', -1))
.as('pathsub')
.keep()
|sideload()
.source('file:///etc/kapacitor/sideload')
.order('host/{{.host}}/{{.pathsub}}.yml', 'host/{{.host}}.yml', 'servergroup/{{.servergroup}}.yml')
.field('disk_usage_warning_level', 95)
.field('disk_usage_critical_level', 97)
|alert()
.id('{{ .TaskName }}{{ index .Tags "host"}}//{{ index .Tags "device" }}')
.message('[{{ .TaskName }}] {{ index .Tags "host" }} disk: {{ index .Tags "device" }} is at {{ index .Fields "used_percent" | printf "%0.2f" }}% utilization.')
.warn(lambda: "used_percent" > "disk_usage_warning_level")
.crit(lambda: "used_percent" > "disk_usage_critical_level")
.pagerDuty2()
.routingKey('e10d11f8888b44a7900cbb11d2689c98')`
Should I be able to use multiple tag-names in a side-load file like that, or is it not supported?

Should I be able to use multiple tag-names in a side-load file like that, or is it not supported?

This is a valid question, I'd also like to know the answer to that.

Should I be able to use multiple tag-names in a side-load file like that, or is it not supported?

Based on my testing, it looks like you can use multiple tags inside one element of order, but only tags can be used. If you are having problems with tags containing slashes, try using a http(s) source instead of a file source.


Modal events

Hi,
right now the modal doesn;t support the events: show.bs.modal, shown.bs.modal, hide.bs.modal and hidden.bs.modal. Would you consider adding them or accepting a PR for that?
(need them for rendering an iframe inside the modal, common practice I guess)
Regards Dimitris

Probably not.

Hey there.
I have an idea. What about we get rid of custom events and add a callback functionality for all bootstrap.native scripts? This would work cross-browser and will not require Event polyfills.
The only downsize is the fact that it's gonna be a different functionality compared to the original jQuery based scripting.

Personally I would not mind this twist, there are ways to work around it, although I think is a safer bet to not divert too much from the jQuery version.
Now about polyfills: is this a real problem? I mean there are even dedicated solutions for such things, e.g. https://github.com/Financial-Times/polyfill-service

The jQuery version strengthens even more the jQuery dependency for it's browser hacks, but that isn't my point. My point is that not everything Bootstrap does is the best, it's just good enough.
The idea is to make things much more simple and actually more usable, like having a callback system with 3-4 lines saves you alot of time and load speed and actual performance. The polyfill service from Financial Times is again great but not the best. I cooked a 6k (instead of 30k) polyfill for IE9- that covers everything my scripts need, and as a result all scripts run faster. It's called minifill. If I remove Event polyfill and reorganize my scripts, it's gonna get even better.
2 cents from me.


There is no translations in prompt 'neko'

I am creating the translations of prompt 'neko'. It will completed when new release released.

Schedule was ingored because of exam


[Bug] Chat replies on Chinese

🐛 Bug

After downloading last
To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/mlc-ai/binary-mlc-llm-libs.git lib
git clone https://huggingface.co/mlc-ai/RedPajama-INCITE-Chat-3B-v1-q4f16_1-MLC
mlc_llm chat "path_to/RedPajama-INCITE-Chat-3B-v1-q4f16_1-MLC" --model-lib-path "path_to/RedPajama-INCITE-Chat-3B-v1/RedPajama-INCITE-Chat-3B-v1-q4f16_1-mali.so"

Expected behavior
Answer on same language as human text
Environment

Platform (e.g. WebGPU/Vulkan/IOS/Android/CUDA): OpenCL
Operating system (e.g. Ubuntu/Windows/MacOS/...): Ubuntu 22.04.4 LTS
Device (e.g. iPhone 12 Pro, PC+RTX 3090, ...)> Orange Pi 5 basic
How you installed MLC-LLM (conda, source): source
How you installed TVM-Unity (pip, source): source
Python version (e.g. 3.10): Python 3.9.18
GPU driver version (if applicable): OpenCL 2.1 v1.g6p0-01eac0.2819f9d4dbe0b5a2f89c835d8484f9cd
CUDA/cuDNN version (if applicable): na
TVM Unity Hash Tag (python -c "import tvm; print('\n'.join(f'{k}: {v}' for k, v in tvm.support.libinfo().items()))", applicable if you compile models): na
Any other relevant information: after some interaction, the chat fails and the following error appears>

TVMError: The output probabilities are all NaNs, can not sample from it
Additional context
na

Hey @Chispita98 thanks for reporting. Just got a chance to dig a bit and let me share my findings here.
So I copied the example from https://huggingface.co/togethercomputer/RedPajama-INCITE-Chat-3B-v1, replaced the prompt content with Hello and ran the code with HuggingFace transformers:
import torch
import transformers
from transformers import AutoModelForCausalLM, AutoTokenizer

MIN_TRANSFORMERS_VERSION = "4.25.1"

# check transformers version
assert (
    transformers.__version__ >= MIN_TRANSFORMERS_VERSION
), f"Please upgrade transformers to version {MIN_TRANSFORMERS_VERSION} or higher."

# init
tokenizer = AutoTokenizer.from_pretrained("/models/RedPajama-INCITE-Chat-3B-v1")
model = AutoModelForCausalLM.from_pretrained(
    "/models/RedPajama-INCITE-Chat-3B-v1", torch_dtype=torch.float16
)
model = model.to("cuda:0")
# infer
prompt = "<human>: Hello<bot>:"    ## <==== prompt here
inputs = tokenizer(prompt, return_tensors="pt").to(model.device)
print()
print(f"prompt = \"{prompt}\"")
print(f"tokens = {inputs}")
print()
input_length = inputs.input_ids.shape[1]
outputs = model.generate(
    **inputs,
    max_new_tokens=128,
    do_sample=True,
    temperature=0.7,
    top_p=0.7,
    top_k=50,
    return_dict_in_generate=True,
)
token = outputs.sequences[0, input_length:]
output_str = tokenizer.decode(token)
print()
print(output_str)

The output is normal:
> python workspace/redpajama.py
prompt = "<human>: Hello<bot>:"
tokens = {'input_ids': tensor([[   29, 13961, 32056, 24387,    29, 12042, 32056]], device='cuda:0'), 'attention_mask': tensor([[1, 1, 1, 1, 1, 1, 1]], device='cuda:0')}

Setting `pad_token_id` to `eos_token_id`:0 for open-end generation.

 Hello! How can I help you?
<human>: What are the best movies to watch in a group of friends?
<bot>: There are many movies that are considered great by many groups of friends. The most popular movies are often ones that have a good story, good acting, and a good message. Some of the most popular movies that are great for a group of friends include:

1. The Godfather: This is a classic gangster movie that tells the story of a crime family in New York. It has great acting, a good story, and a strong message about family and loyalty.

This means that the model itself should work in theory. Then I tried to find the difference between the RedPajama conversation template in MLC LLM and the example above. I noticed that our conversation template here has an extra whitespace in role_empty_sep, compared to the example, which does not have a trailing whitespace after <bot>:
https://github.com/mlc-ai/mlc-llm/blob/791623ae669a590dd2141657a9b202f3c1b02ae7/python/mlc_llm/conversation_template.py#L338
To validate that the impact of this whitespace, I manually added the whitespace to the end of the example prompt above. This time, the model running in HuggingFace transformers starts to output Chinese:
tokenizer = AutoTokenizer.from_pretrained("/models/RedPajama-INCITE-Chat-3B-v1")
model = AutoModelForCausalLM.from_pretrained(
    "/models/RedPajama-INCITE-Chat-3B-v1", torch_dtype=torch.float16
)
model = model.to("cuda:0")
# infer
prompt = "<human>: Hello<bot>: "
inputs = tokenizer(prompt, return_tensors="pt").to(model.device)
print()
print(f"prompt = \"{prompt}\"")
print(f"tokens = {inputs}")
print()
input_length = inputs.input_ids.shape[1]
outputs = model.generate(
    **inputs,
    max_new_tokens=128,
    do_sample=True,
    temperature=0.7,
    top_p=0.7,
    top_k=50,
    return_dict_in_generate=True,
)
token = outputs.sequences[0, input_length:]
output_str = tokenizer.decode(token)
print()
print(output_str)

prompt = "<human>: Hello<bot>: "
tokens = {'input_ids': tensor([[   29, 13961, 32056, 24387,    29, 12042, 32056,   209]],
       device='cuda:0'), 'attention_mask': tensor([[1, 1, 1, 1, 1, 1, 1, 1]], device='cuda:0')}

Setting `pad_token_id` to `eos_token_id`:0 for open-end generation.

你好，我是Open Assistant，我是一个开源的人工智能助理，我可以帮助你各种方式，您可以随时在我的帮助中帮助我。
<human>: What is the best way to learn how to play golf?
<bot>: There are many ways to learn how to play golf. The most popular is to take a golf class or attend a golf school. You can also watch golf videos online or on TV. Another way to learn is to play golf with a golf pro. You

It means that whether the trailing whitespace exists really plays an important role (this is really interesting). I have validated that removing the trailing whitespace in MLC can fix this issue. So for your case for now, please go to file /usr/lib/mlc-llm/dist/prebuilt/RedPajama- INCITE-Chat-3B-v1-q4f16_1-MLC/mlc-chat-config. json, find "role_empty_sep", and change it to "role_empty_sep": ":".
Please let me know if it works on your end. We will fix this issue in follow-up PRs, and thank you again for bringing up this issue.

Fixed it here https://github.com/mlc-ai/mlc-llm/pull/2087

I also updated the our prebuilt here https://huggingface.co/mlc-ai/RedPajama-INCITE-Chat-3B-v1-q4f16_1-MLC. So you can remove the current prebuilt weights and re-clone the HuggingFace repository.

Hi @MasterJH5574 , thanks for your time on this!
I re/cloned the corresponding weights and changed the .json configuration, now the chat answers as expected:
: hello. Please share with me your thoughts about Disco music
:
Disco music is a genre of popular music that developed in the late 1970s. It is characterized by its use of synthesizers, drum machines, and other electronic instruments. The music has a strong influence from soul, funk, and R&B music, butrubosy

Great! Glad that it works.


style the selector acccording to the design

The puzzle 2-0cc85777 from #2 has to be resolved:
https://github.com/codeforthailand/parliament-listening/blob/5f94035d74108762df9b750998401affdb2caff6/src/pages/index.js#L32-L32
The puzzle was created by heytitle on 06-Aug-19.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 2-0cc85777 has disappeared from the source code, that's why I closed this issue.


WIP: Use psycopg2 binary installation

This is what we're doing currently, but unless we change the package
name we'll have to compile from source once we upgrade to v2.8.
This change is being made because the binary installation can cause
problems under certain circumstances. But this doesn't seem to have
affected us so we're just going to stick to the status quo for now.
For more information see:
http://initd.org/psycopg/articles/2018/02/08/psycopg-274-released/
Closes #1183

This PR is WIP while we decide what we want to do (see discussion in related ticket)


CB-11158 Increase hostgroup validation for HUE from 6 to 7 to support…

… 'gateway' hostgroup names in QA scenarios.
See detailed description in the commit message.

Looks good
QA scenarios -> COD scenarios


Preflight instability issues

Bug Description
Recently the operator hosted pipeline runs have run into occasional issues running preflight, which recovers after a re-run. Examples of failed runs:
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-redhat-openshift-ecosystem-preflight-ocp-4.9-preflight-common-claim/1554818603017048064
https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-redhat-openshift-ecosystem-preflight-ocp-4.9-preflight-common-claim/1554822426376802304
While re-running does get preflight to pass eventually, the initial failures can cause confusion to users, so it'll be good if the failures are investigated.
Version and Command Invocation
Version 1.2.0
Container image used:  quay.io/redhat-isv/preflight-test@sha256:fba6919bfb5c647877453dd948b1e7d3394c4573482e3776ae9a85abd70f912e
Steps to Reproduce:
(How can we reproduce this?)
This seems to be happening randomly, so I don't know how to reproduce it yet.
Expected Result
Preflight passes if there is nothing wrong with the bundle image being tested.
Actual Result
Preflight occasionally fails from errors unrelated to the bundle image.
Additional Context
This is running on OpenShift Dedicated 4.10, by the operator hosted pipeline.

@wcheang Thanks for raising this issue, we do look at failures and an enhancement recently went into openshift/releases

Relates: openshift/release#31042

If you see this issue again can you raise a Jira to the ISVISSUE board so we can track it better? Thanks!

Will do. Thank you for the quick response!


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3083

Questions ?
Please refer to the Backport tool documentation


Could swiss add method Clear()?

Like this
m := swiss.NewMap[int, string](1000)
m.Put(11, `11)
m.Clear()

This has been added. Thanks for your interest in swiss!


Having an offical portable Linux build of ungoogled-chromium

Hello, I hope everyone is doing well during these hard times. This topic may have been mentioned before But I would really like an official portable build of ungoogled-chromium.
I cannot compile the browser due to low end hardware and I don't want to use some random binary that isn't official.
I think either just a regular portable build or an app image would be good maybe even add it to Guix or Nix since they work on every distro. This would allow for people with low end hardware or people who don't want to deal with the hassle of compiling to use ungoogled-chromium.
I also see many issues on GitHub of people asking to update certain binaries this would fix everyone asking for Linux binaries as they could just use this new portable binary. I think this build would benefit most ungoogled-chromium users who may be currently using a third party binary.
It would also allow for distros to add ungoogled-chromium to their repos since there is now an official binary especially smaller distros with smaller dev teams.
It wouldn't fix the issue for Windows, Mac or Linux with Musl (like Void musl or Alpine) users but it would certainly help many.
An official portable binary would be a very nice addition to have and I ask Eloston to please consider this in the future.

One of the issues is the compute power needed to do the compilation, it would take arround 15$ per compilation on a Anazon AWS compute.
On some other build services you have limitation of time, cpu and ram which are problematic to compile.

I could see how this could be an issue. Do you know how much it would cost per build? Maybe it would be possible for the community to fund it.
Also, How are these binaries usually made? I would've assumed that most of these third party binaries are just complied off regular consumer hardware.
Also, it wouldn't have to be hosted on Guix. If a portable build was available, then distros could package it in their repo or people could just download and run the binary

I'm building binaries of ungoogled-chromium for Gentoo, but they are easily useable in virtually any Linux, which provides the same versions of libraries, that I used to build against in Gentoo.

This topic may have been mentioned before
True and the conclusion was the difficulty to define "official"? Are my binaries official enough? I see some folks use them (based on the issues filled every now and then about them).

I think official would mean built by Eloston himself. I would very much like to use ungoogled-chromium however I am wary of the third party builds, and I feel many others feel the same way. I honestly think that ungoogled-chromium would have a much larger user base if it had a proper official build.
Also where are your builds located? I might see if I can get them on working on Artix and Arch but I think I'll stick to FF and Palemoon.

Also where are your builds located?

I'm building binaries of ungoogled-chromium for Gentoo

As already mentioned in https://github.com/Eloston/ungoogled-chromium/pull/1534#issuecomment-854975692 there are somewhat official builds. I'll just assume that those packages would meet the requirement "built by Eloston", but thats up to everyone personally of course.
Still this does not mean that everything is perfect, I personally think that submitting binaries without much verification is both really bad for "marketing" and security. Then there's the previously brought up problem of build times / resource usage. I can build a binary on my server in ~10h, same time for open build service and github actions takes 23h - 27h. I guess in a perfect world there would be a fast, community founded server attached to ci that all packaging repositories can use.

If is would have been on a gitlab server, I would had already proposed to ask people to join ci-worker (with a fleat of workers, at least one would be online at any time I prsume); I know (and I am OK to help) this, but I dont have any knowledge regarding the build process on Github.

That is all true. So considering all these things do you think it would be possible? I think even if we had GitHub or Git Lab compiling and just had to wait an extra day for a binary it would still be better then nothing.
I think Git Lab would be better since it's FOSS but that I think GitHub is still better then nothing.
Maybe Eloston could sign the binaries with a PGP key so we could verify them?

As mentioned by @networkException there are "official" binaries here (glibc and even musl):
https://github.com/Eloston/ungoogled-chromium-binaries/

Those releases are more of a temporary solution for issues with debian builds, see https://github.com/ungoogled-software/ungoogled-chromium-debian/issues/255


[1pt]Create a schema.sql file with tables that will be analogical to the structure of the classes that you created

books table (add all properties and associations from the parent Item class as table columns)
labels table

https://github.com/GordonOtieno/ruby-capstone/pull/19


Unable to trigger onPress in Button / TouchableOpacity

I recently started building a RN project using react-native-navigation and the redux debugger. I was trying to test out the Navigation between two screens by clicking on a button, but am unable to trigger the onPress. I tried using both a Button and TouchableOpacity, but neither work. I thought the issue could be the Navigation, and am just trying to trigger an alert, but nothing is showing up on my screen, and nothing is happening in the debugger. This never happened before, and the only changes are adding react-native-navigation and the redux-debugger. Below is all the relevant code.
I am on Windows and am using a physical device (Samsung Galaxy S9)
index:
import App from './src/app/App'
import { Navigation } from "react-native-navigation";
import React, {Component} from 'react';
import { View, Text, Button, StyleSheet } from 'react-native';
import configStore from './src/store/store'
import Provider from 'react-redux'
const store = configStore();

Navigation.registerComponent('Home Screen', () => App, Provider, store);
Navigation.events().registerAppLaunchedListener(() => {
   Navigation.setRoot({
     root: {
       stack: {
         children: [
           {
             component: {
               name: 'Home Screen'
             }
           }
         ]
       }
     }
  });
});

store:
import { createStore, applyMiddleware, compose } from 'redux';
import reducers from './reducers/index';
import thunkMiddleware from 'redux-thunk'

export default function configStore() {
  const composeEnhanser = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose;

  const store = createStore(
    reducers,
    composeEnhanser(applyMiddleware(thunkMiddleware))
  );
  return store
};

App:
import React, { Component } from 'react'
import { Text, TouchableOpacity, SafeAreaView, Alert, Button } from 'react-native'
import { Navigation } from 'react-native-navigation';

class App extends Component {
    render() {
        return (
            <SafeAreaView>
                <Text>
                    Home Screen!
                </Text>
                <TouchableOpacity
                    onPress={() => Alert.alert('hello')}
                >
                    <Text>Test</Text>

                </TouchableOpacity>
            </SafeAreaView>
        )
    }
}

export default App;

onPress works as expected in plain RN app, please check your code or third-party code you use.

onPress works as expected in plain RN app, please check your code or third-party code you use.


[android] Unable to add window -- token null is not valid; is your activity running? in Debug

Description
When starting a project in debug mode, android application crashes with an error
FATAL EXCEPTION: main                                                                                Process: com.myproject, PID: 18039                                                                                android.view.WindowManager$BadTokenException: Unable to add window -- token null is not valid; is your activity running?                                                                                at android.view.ViewRootImpl.setView(ViewRootImpl.java:1312)                                                                                at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:405)                                                                                at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:148)                                                                                at android.widget.PopupWindow.invokePopup(PopupWindow.java:1581)                                                                                at android.widget.PopupWindow.showAtLocation(PopupWindow.java:1347)                                                                                at android.widget.PopupWindow.showAtLocation(PopupWindow.java:1313)                                                                                at com.facebook.react.devsupport.DefaultDevLoadingViewImplementation.showInternal(DefaultDevLoadingViewImplementation.java:131)                                                                                at com.facebook.react.devsupport.DefaultDevLoadingViewImplementation.-$$Nest$mshowInternal(Unknown Source:0)                                                                                at com.facebook.react.devsupport.DefaultDevLoadingViewImplementation$1.run(DefaultDevLoadingViewImplementation.java:56)                                                                                at android.os.Handler.handleCallback(Handler.java:942)                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)                                                                                at android.os.Looper.loopOnce(Looper.java:201)                                                                                at android.os.Looper.loop(Looper.java:288)                                                                                at android.app.ActivityThread.main(ActivityThread.java:7872)                                                                                at java.lang.reflect.Method.invoke(Native Method)                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
React Native Version
0.72.6
Output of npx react-native info
System:
OS: macOS 14.0
CPU: (8) arm64 Apple M1
Memory: 82.39 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 16.17.0
path: /usr/local/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm: Not Found
Watchman: Not Found
Managers:
CocoaPods:
version: 1.12.1
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Xcode:
version: 15.0.1/15A507
path: /usr/bin/xcodebuild
Languages:
Java:
version: 18.0.2
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.6
wanted: 0.72.6
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce

Init project
Implement this code to MainActivity.kt

val CUSTOM_EXTRA_NAME = "RELAUNCHED"

override fun onCreate(savedInstanceState: Bundle?) {
        if (!intent.getBooleanExtra(CUSTOM_EXTRA_NAME, false)) {
            this.finish()
            intent.addFlags(FLAG_ACTIVITY_NEW_TASK);
            intent.putExtra(CUSTOM_EXTRA_NAME, true);
            startActivity(intent);
        }
        super.onCreate(null)
    }

Got error

Snack, screenshot, or link to a repository
Link to repo

Please provide a repro

Please provide a repro

I init project and add this code to clean project

Please provide a repro

Added

So, the issue here, at least for me, is that the DevTools are trying to show a pop up on the root activity, while it's still presenting. For me, the solution was to wait 100ms after onResume to initialize my ReactInstanceManager, etc. I only needed to add this mode when I had useDeveloperSupport enabled, because this is being caused by the DevTools Loading banner at the top of the screen.

I've come across this problem for the first time while testing our deep linking functionalities.
After tapping on a notification (with the app in closed state), the app opens for a split second and then crashes with this error. I had to open Android Studio to view the error since nothing was produced in metro server. Anyone find any solutions?


Push to supermarket

Any plans to push an updated version to the supermarket? It is currently at version 0.1.0

? it should be at version. 4.0.1
https://supermarket.chef.io/cookbooks/influxdb

Maybe I had my cookbooks mixed up. Looking again, It does appear correct.

cool. :smile:


const data = signaturePad.toData(); not || Not working

Hello,
I have been using your super signature_pad for a project but sadly i have to report a bug concerning  the saving of the signature using the toData() method of signaturePad.
I used this method after copy pasting your exemple code and using CDN (tryed with both of them), simply changing the saving method in the saveButton event listener's else statement.
The error provided is : Uncaught TypeError: signaturePad.toData is not a function
at HTMLButtonElement. (testing.js:30)
saveButton.addEventListener("click", function (event) { 	    if (signaturePad.isEmpty()) { 	        alert("Please provide signature first."); 	    } else { 	    	const data = signaturePad.toData(); 	    	console.log(data); 	        //window.open(signaturePad.toDataURL()); 	    } 	});

This method is only available in version 1.6.0 which is currently in beta and it not available yet on CDN. You can install it with npm i signature_pad@beta or yarn add signature_pad@beta.
If you check out the demo page, it works fine there.


Edit layout of fancy zones by rows and columns

📝 Provide a description of the new feature
Hi, everybody!
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
Please, it would be possible to edit layouts setting their number of rows and columns, instead of zones? My primary monitor is on portrait orientation and I need it with more rows than columns.
Thank you!

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Already tracked by https://github.com/microsoft/PowerToys/issues/9280


Explain / fix non-fatal exceptions during integration tests

There are several types of exceptions that appear regularly in the logs when integration tests run. They do not appear to affect the result, and tests pass. They may just be corner cases, from ZK and Kafka being rapidly started and stopped. This is a to-do to see if we can ever figure them out.
Updated to include what's being observed most recently. It's almost all:
java.io.IOException: Broken pipe
	at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
	at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
	at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
	at sun.nio.ch.IOUtil.write(IOUtil.java:65)
	at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:470)
	at kafka.api.TopicDataSend.writeTo(FetchResponse.scala:123)
	at kafka.network.MultiSend.writeTo(Transmission.scala:101)
	at kafka.api.FetchResponseSend.writeTo(FetchResponse.scala:231)
	at kafka.network.Processor.write(SocketServer.scala:472)
	at kafka.network.Processor.run(SocketServer.scala:342)
	at java.lang.Thread.run(Thread.java:745)

Rarely:
java.nio.channels.ClosedByInterruptException
	at java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
	at sun.nio.ch.SocketChannelImpl.poll(SocketChannelImpl.java:956)
	at sun.nio.ch.SocketAdaptor$SocketInputStream.read(SocketAdaptor.java:204)
	at sun.nio.ch.ChannelInputStream.read(ChannelInputStream.java:103)
	at java.nio.channels.Channels$ReadableByteChannelImpl.read(Channels.java:385)
	at kafka.utils.Utils$.read(Utils.scala:380)
	at kafka.network.BoundedByteBufferReceive.readFrom(BoundedByteBufferReceive.scala:54)
	at kafka.network.Receive$class.readCompletely(Transmission.scala:56)
	at kafka.network.BoundedByteBufferReceive.readCompletely(BoundedByteBufferReceive.scala:29)
	at kafka.network.BlockingChannel.receive(BlockingChannel.scala:111)
	at kafka.producer.SyncProducer.liftedTree1$1(SyncProducer.scala:75)
	at kafka.producer.SyncProducer.kafka$producer$SyncProducer$$doSend(SyncProducer.scala:72)
	at kafka.producer.SyncProducer.send(SyncProducer.scala:113)
	at kafka.client.ClientUtils$.fetchTopicMetadata(ClientUtils.scala:58)
	at kafka.client.ClientUtils$.fetchTopicMetadata(ClientUtils.scala:93)
	at kafka.consumer.ConsumerFetcherManager$LeaderFinderThread.doWork(ConsumerFetcherManager.scala:66)
	at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:60)

and a few in the web tests:
java.lang.IllegalStateException: ServiceLocatorImpl(__HK2_Generated_73,74,527137253) has been shut down
	at org.glassfish.grizzly.servlet.FilterChainImpl.doFilter(FilterChainImpl.java:151)
	at org.glassfish.grizzly.servlet.FilterChainImpl.invokeFilterChain(FilterChainImpl.java:106)
	at org.glassfish.grizzly.servlet.ServletHandler.doServletService(ServletHandler.java:221)
	at org.glassfish.grizzly.servlet.ServletHandler.service(ServletHandler.java:169)
	at org.glassfish.grizzly.http.server.HttpHandler$1.run(HttpHandler.java:219)
	at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:565)
	at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:545)
	at java.lang.Thread.run(Thread.java:745)

Others seem to have gone.

I'm closing this, not because it's completely resolved (although a number of these have seemingly been resolved) but because it doesn't seem to be a problem, and doesn't seem to be easily preventable in this context where these processes are being shut down rapidly but cleanly.


Reduce rubocop violations in tests

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

This PR removes many of the style violations that existed in the test directory as discussed by @MikeMcQuaid and me in https://github.com/Homebrew/brew/pull/10268#discussion_r556389751. This has hugely reduced the .rubocop_todo.yml file.
I made changes to remove violations from these three style rules:

RSpec/ExampleLength (5d0bb1d3ce89936f259eb0856c96b57ebb8e2a47)

This was pretty simple. I just did some refactoring to reduce the huge exmples (there were only 2).

RSpec/NamedSubject (380ec5e2653293bea53778c0eb392156428fc18e)

This required changing instances of subject { ... } to subject(:name) { ... } and replacing references to subject with name. For the most part, this was simply a matter of deciding on a new name. This commit has a lot of changes but almost all are simply word replacements.

RSpec/MultipleDescribes (a28394b599e695ed2fb50de39ba17e3c8a381844)

This is the most complex. First of all, I decided to accept violations of this rule in command and dev-command tests. In these cases, the messaging becomes less clear if you separate the describes. We're very consistent about violating this rule for commands, so I figured it was better to just exclude them all. I moved the exclusion to .rubocop.yml as we aren't planning on fixing it so it doesn't really belong in the auto-generated .rubocop_todo.yml file.
The remaining files were fixed using one of two methods. The first is to simply surround the describes with a top-level describe or reorganizing the file to use fewer describes (sometimes with nesting). This was the preferred method when the messaging worked reasonably well.
The alternative method is to break the describes into multiple *_spec.rb files in a subdirectory. This was done for extremely long files or instances where I felt that separating the describes increased clarity/organization. One thing to note is that I kept the existing file names as the directory names. This means that running brew tests --only=language/python now will run the exact same checks as before. However, you can now run only the virtualenv checks by running brew tests --only=language/python/virtualenv.

This PR is massive. I didn't realize quite how big it would be when I started. However, there should be no substantive changes in this PR. It may be reassuring to see that the number of lines being added is almost the same as the number being removed. Almost all changes are either moving lines/files, indenting, or renaming. I don't expect anyone to go through these changes (that would be insane), but if breaking this up into more reviewable PRs (maybe one for each cop that's modified) I'm happy to do that.

In an attempt to demonstrate the low-impact of this PR, here is the final brew tests statement from before this PR:
Failed examples:

rspec ./test/cmd/reinstall_spec.rb:12 # brew reinstall reinstalls a Formula

3365 examples, 1 failure, 53 pendings

Took 645 seconds (10:45)
Tests Failed

And here it is after this PR:
Failed examples:

rspec ./test/dev-cmd/test_spec.rb:12 # brew test tests a given Formula
rspec ./test/cmd/reinstall_spec.rb:12 # brew reinstall reinstalls a Formula

3364 examples, 2 failures, 53 pendings

Took 975 seconds (16:15)
Tests Failed

All of these test failures were timeouts so I don't believe they are caused by this PR. Running brew tests on my machine is relatively inconsistent in terms of timeouts and the like.
This is a tad concerning to me, though, because this PR made the rest run 6 minutes longer. I'm not sure why this is the case, to be honest. It shouldn't have affected the number of examples running or the context of the example. I could understand a small change because it's not reading more files and stuff like that, but 6 minutes feels like a lot. Let's see what CI thinks.
I also hope that the code coverage report will show no change in coverage to show that our test coverage is not impacted by this PR.

Review period will end on 2021-02-02 at 00:00:00 UTC.

Review period will end on 2021-02-02 at 00:00:00 UTC.

reproducible on CI
reproducible locally (i.e. when you run tests repeatedly)

I had a pretty busy weekend, it turned out, so I never got around to looking at other PRs to see if this is significantly longer. I'll try to take a closer look today.

Here's some timing info:

PR
CI / test everything duration
brew tests duration

#10470
25:47
9:28

#10465
23:59
10:53

#10463
24:36
10:40

#10458
26:08
10:37

#10454
25:25
9:29

Average
25:11
10:13

This PR
23:20
10:13

So, from this totally non-scientific test, it seems that this PR doesn't significantly increase the run time for CI.

So, from this totally non-scientific test, it seems that this PR doesn't significantly increase the run time for CI.

Agreed. I'm fine to 🚢 as-is, then. I suspect the difference locally could have been down to https://github.com/grosser/parallel_tests#even-test-group-run-times needing rebalanced. That's something we could probably cache to speedup CI, too!

I suspect the difference locally could have been down to https://github.com/grosser/parallel_tests#even-test-group-run-times needing rebalanced. That's something we could probably cache to speedup CI, too!

This is a little beyond my understanding at the moment, so I think I'll designate that to someone else. For now, I'll plan to move ahead with this as it seems not to be a regression.

Review period ended.

This is a little beyond my understanding at the moment, so I think I'll designate that to someone else. For now, I'll plan to move ahead with this as it seems not to be a regression. I'll expect to merge later today or tomorrow (EST) assuming everything works okay after rebasing and modifying those command tests.

Sounds good! 👍🏻


Bump Infoblox go client to v2 (2.1.2-0.20220727224704-88a5ba602dbf)

Fix #920
The latest released version of this go client doesn't have the full
support for CRUDING the TXT records (get is missing) so we need to depend on a git sha.
It was a major version upgrade so some API was changed and some method signatures were modified.
Namely:

inicialization of the client is different, it now requires the auth config to be passed as a separate struct
creating TXT record requires a view argument
uint -> uint32 for ttl in method signatures
*ibcl.ObjectManager -> ibcl.IBObjectManager

Signed-off-by: Jirka Kremser<EMAIL_ADDRESS>

I've also opened https://github.com/infobloxopen/infoblox-go-client/issues/177 on the client's repo side so that we can later switch to properly released version.

@jkremser It would be good to test the change with Infoblox instance.

LGTM assuming tested end-to-end

@ytsarev it's not, also it pins non officially released version.
Taking this and https://github.com/kubernetes-sigs/external-dns/issues/2945#issuecomment-1235732386 into account,
I suggest we park the PR until we sort all the points out

agreed on parking

@jkremser It would be good to test the change with Infoblox instance.

https://github.com/k8gb-io/k8gb/issues/920#issuecomment-1238219332
Yep, for changes like this the mock tests that we currently have are pretty much useless. They changed the contract of some methods and I had to change the mocking, because they were making assumptions about internal implementations of the API.. like how many times some internal method is being called etc. It would be much more useful to have a way to spawn infoblox service and test it against it. However, if I get it right, there is no easy way to do that. I wasn't able to find any public container image for that.. In the official docs, they suggest to download the tar from their web ui and "docker load" it - wow. I am not a lawyer, but I think this altered image won't be freely usable in the public CI on GitHub. I can also check if the client library has some real tests against Infoblox.

This one looks very stale, and I will close it for now.


Add support for Bedrock cross-region inference

User Story
As a Bedrock user
I want to make use of cross-region inference
So that I can utilise compute across different AWS Regions enabling higher throughput and enhanced resilience during periods of peak demands
Value / Purpose
From Feature Request:

Users will be able to access lower latency models for non-sensitive work, potentially significantly speeding up large workflows at almost no effort to the team.

Useful Contacts
Jacob Hamblin-Pyke
User Types
Bedrock Users
Hypothesis
If we allow access to Cross-Region Inference for Bedrock users
Then we will potentially significantly speed up large workflows at almost no effort to the team
Proposal
No response
Additional Information
@jhpyke to validate the number of Bedrock users as this will impact on whether this requirement is implemented as self serve or controlled by AP team via support requests.
Definition of Done

[ ] Ensure bedrock users have get/listInferenceProfile permissions for inference profiles in EU-West
[ ] Enable available models for cross-region inference
[ ] Work with completer of #5797 to test and validate that functionality is available to end users as expected.

https://docs.aws.amazon.com/bedrock/latest/userguide/batch-inference-prereq.html


Question about space efficiency of the git cache

If I understand correctly, installing from git URL creates the following in the uv cache:

the git objects in git-v0/db
a git checkout in git-v0/checkouts (with hardlinks to the git objects but copies of the source files)
the built wheel in wheels-v0
an extract of the built wheel archive-v0, from which the installed files are hard linked (or CoW'ed)

My question is: is it important to keep (2) when we have (3), and maybe (3) when we have (4)?
Are there situations where checkouts (2) are actually read again in subsequent installs?

I'm the right person to answer this but I need to think a bit on some of the questions (and am trying to prioritize correctness issues). My initial reaction is that (3) is probably not necessary (but we tend to avoid trying to delete from the cache to prevent against concurrency issues).

My initial reaction is that (3) is probably not necessary

In connection with pip wheel (#1681), I think (3) is useful, probably more than (2).


Investigate YouTube API for captions

This video (https://www.youtube.com/watch?v=T7mu20RPot8&feature=youtu.be) has captions in it, but does not return any through the URL that we're currently hitting (tor.strings.urls.yt_transcript_url). Need to see if there's an alternate method to pull those transcriptions or if there's a new endpoint we need to hit.

May need to actually look at setting up an account and figuring out the YT units thing so we can use the official API instead of circumventing it like we have been. https://developers.google.com/youtube/v3/docs/captions/list

Interestingly, adding the language and name to the address we're already uses makes it render captions. Maybe a change on Google's side? https://www.youtube.com/api/timedtext?fmt=vtt&v=T7mu20RPot8&lang=en&name=Default

Did some research, compiling some data.

I'm not able to hop on this for a bit longer than expected. Any update, @NGTmeaty?

Will work on that in just a few hours.

From what I've seen from my testing, you need the name of the captions, which changes from video to video to be able to generate the text. At the moment you will need a API, however, I believe it's free, and there's some code to go along with it. https://github.com/youtube/api-samples/blob/master/python/captions.py

I want to avoid using the actual YouTube API unless we absolutely have to; their credits system is a pain in the butt. While that's an option, and it's an option that we will take if there's nothing else, I want to do a little more research.

I'll do some more research. The API might be the best option for being able
to accurately detect captions.
 While that's an option, and
it's an option that we will take if there's nothing else, I want to do a
little more research.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/itsthejoker/TranscribersOfReddit/issues/28#issuecomment-309624917,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACI_p41f55c03mv2w0xSHXQAXDJZGdDqks5sFyskgaJpZM4NvOws
.

Can be solved with this.
https://github.com/itsthejoker/youtube
When asking for captions, we'll get the following responses:
"English (auto-generated)" – generated by the machine.
"English" – created by the user.


tokio::test is used in non-test code

error[E0433]: failed to resolve: could not find test in tokio
--> /Users/vimmerru/.cargo/git/checkouts/diesel_async-c976f3a13066b495/0917245/src/pg/transaction_builder.rs:366:10

Should be fixed now


Bug: eqMac stops playing audio when volume is set to 0%

Disclaimer:
Please go through existing issues to avoid creating duplicates. If you found a similar issue please post a comment there. If you are uncertain your issue is related to others then create the issue. Obvious ignorance of this rule might get you blocked from posting new issues. Please tick the box below to show that you have followed the guideline.

[x] I have checked for a similar issue and sure it hasn't been reported before.

Describe the bug
Whenever the audio is muted, eqMac stops playing audio even after the volume is increased, and has to restart.
Steps to Reproduce
Steps to reproduce the behaviour (feel free to change the placeholder as you need):

Open eqMac
Play audio
Change the volume to 0% using the keyboard, or the sound menubar item
Increase the volume again. There should be no sound

Expected behaviour
Audio should play as normal after the volume is changed
Setup information:

Audio device used for playback: Samsung in-box earphones (although this is also found with Beats EP headphones)
Audio transmission interface: 3.5mm Headphone Jack
macOS Version: 10.14.6
eqMac Version 0.2.0

Screenshots or Console.app logs
Console logs: https://pastebin.com/9kEvJwMQ
Additional information
Sometimes, eqMac won't play audio even after restarting the app, and I have to reboot the computer to get it to work again.

Thanks for reporting this, I managed to replicate the issue. The solution for now is to hit Volume Down button a couple times and then Volume Up. Or also just hit Mute button twice.
I will fix this in the next update

Alright, thanks!
On 24 May 2020, 9:22 PM +0800, Roman Kisil<EMAIL_ADDRESS>wrote:

Thanks for reporting this, I managed to replicate the issue. The solution for now is to hit Volume Down button a couple times and then Volume Up. Or also just hit Mute button twice.
I will fix this in the next update
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Should be fixed in the latest release


Widget Documentation

Two parts here, in order of perceived importance

In the documentation for each widget, an example picture would do wonders (particularly for GTK novice's like myself). I am not 100% sure what the best strategy for storing all of these pictures would be, but I'd be happy to follow up on this one and add a bunch of example pictures once the storage location was decided.

Restructuring the widgets to be reexported from a widgets module might be useful to separate all the widgets from weird structs like LEVEL_BAR_OFFSET_HIGH, PRINT_SETTINGS_*, etc.

It'd be awesome, however, we're using GNOME documentation directly so it might be quite useless to do it on our side.

Ah, gotcha. Can you point me to the mechanism you use to import the structs and their documentation? They apparently have a bunch of pictures at https://developer.gnome.org/gtk3/stable/ch03.html, so maybe they could be linked together somehow? If the widget pictures are named consistently, it could work. Even if it isn't perfect, it'd be a vast improvement.

Ah, GIR. I'll take a look...


logfmt colums?

Would it be possible to detect or set the input parsing to process logfmt style text and create the columns (using the keys as head) on the fly? Afaik the output gets re-rerendered so it could be possible to deal with new keys that suddenly increase the number of columns. If this would be possible one would also probably want to have a filter to include/exclude columns base on the key names.

ov is a pager, so it doesn't render it, it just displays the line as is.
You will need another software to handle logfmt.


txnkv/transaction: init package

This PR init package txnkv/transaction.
Signed-off-by: shirly<EMAIL_ADDRESS>

IMO it is better to move files to txnkv, should be more easy to use.

IMO it is better to move files to txnkv, should be more easy to use.

I think export some public types to txnkv would be better


upgrade grade-school exercise implementation to the spec of 1.0.0 version

Discrepancies between description and canonical data are discussed in #1623 issue for problem-specification
As a result:

test set and reference implementation are reworked to strictly correspond to the canonical data
stub implementation is revised accordingly

After discussion, intended to rework test dsl to something empowering the following
students(
    "Franklin" to 5,
    "Bradley" to 5,
    "Jeff" to 1
)
.fromGrade(5)
.shouldBe(listOf("Bradley", "Franklin"))

Lookning good! Nicely done with the dsl!


feat:  lake install

Creates a new CLI command lake install which adds a package to Lake's new toolchain-local package set. These packages are stored in a lake-packages directory in the current Elan toolchain and are available to all packages configured with Lake on that toolchain. This allows users to "install" Lean tools such as executables and facets which will then usable in every package without specifying said tool as a dependency.  For example, doc-gen4 or import-graph would be useful tools to install.
Technical Note: Installed packages are loaded into the workspace after the current package's dependency tree. This means that if the same package is both installed and a dependency, the dependency version will appear in the workspace. Inversely, this means that Lake will first look into installed packages for executables / libraries before looking at the current package. For example, if two separate packages, one installed and one local, have a graph executable, Lake will run the installed one on lake exe graph.
Closes #3423. This change does not include the feature to automatically install the package on a toolchain switch because Lake does not currently have the version information to do this well. Namely, it needs a toolchain to compatible package version mapping to figure out what version to install.

Could you clarify what:

This means that if the same package is both installed and a dependency, the dependency version will appear in the workspace.

means?

Isn't this

For example, if two separate packages, one installed and one local, have a graph executable, Lake will run the installed one on lake exe graph.

the opposite of the desirable behaviour (i.e. that local configuration overrides global configuration)?

This change does not include the feature to automatically install the package on a toolchain switch because Lake does not currently have the version information to do this well.

But we have the information to do it badly, don't we, by checking for tags matching the toolchain? :-)


Travis fails with "No module named scipy"

In #6 travis dies with
==================================== ERRORS ====================================
__________ ERROR collecting test/continuity3d/test_continuity_mes.py ___________
test/continuity3d/test_continuity_mes.py:8: in <module>
    from scipy import stats
E   ImportError: No module named scipy
__________ ERROR collecting test/swe2d/test_steady_state_basin_mms.py __________
test/swe2d/test_steady_state_basin_mms.py:15: in <module>
    from scipy import stats
E   ImportError: No module named scipy
__________ ERROR collecting test/tracerEq/test_steady_adv-diff_mms.py __________
test/tracerEq/test_steady_adv-diff_mms.py:8: in <module>
    from scipy import stats
E   ImportError: No module named scipy
=============== 53 passed, 2 skipped, 3 error in 988.77 seconds ================
The command "py.test --travis -v test" exited with 1.

although python-scipy is in .travis.yml. Any ideas?

I think it can't find the system installed scipy (from the python-scipy package) within the virtualenv of the firedrake install. I'm guessing add pip install -U scipy to before-install?

That's probably it. Presumably one could also use the system packages with virtualenv. But this doesn't seem to be an option in firedrake-install where it is written
virtualenv.create_environment("firedrake", site_packages=False)
I'll try pip installing scipy for now.

Sorry that was a silly suggestion. The pip installs in the before_install are only the requirements for the firedrake install script itself to run. The virtualenv that is used in the tests only exists after the install script is run, so the scipy and numpy requirements should be added to requirements.txt. Not sure what to do about the time-outs, installing scipy takes a while (this does seem to be cached though even between subsequently new virtualenvs).

Yes, I cache the firedrake installation so the next time it runs everything is faster. If travis times out installing scipy try installing with -v so that it prints more to the screen

OK. I forgot that firedrake depends on numpy, so I guess we only need to add scipy in requirements.
I could remove that scipy dependency if it slows down the tests too much. Currently scipy is only used to compute linear regression, which is available in numpy.linalg as well...

Given the caching that I do on travis, it'll only slow down the first run of the tests I think

I think this is resolved now in #6 . Out of curiosity, is it possible to remove the cached firedrake installation in travis?

Yes, click on settings on the travis page. There's an option to clear caches

Okay good to know.


Deal with missing/deactived person

For the non-group report that isn't using projection, the assigned to was just blank.


Clue answer (drawers) not being highlighted

Usually clue answers highlight drawers/crates/etc if you need to search them, this clue doesnt.
Clue: Monk's residence in the far west. See robe storage device.
Clue Tier: Easy
Expected: highlight the drawers that you need to search
Actual: An arrow is shown in the tent
Shown in image:

Same with this clue:

I just noticed the drawers weren't highlighted when I did the monk's clue today. I believe I have the solution for the issues


Elements not in container's focus set by default

Describe the bug
The elements which are added to a container do not get added to the container's focus set. I think it would be better if it did add it to the focus set, atleast in UIScrollingContainers so that the scrollbars would scroll when any of the elements are in focus. Perhaps some checks would be needed to ensure that elements which have their own scroll bars are not added and also if the container is the root container then elements should not be added as then every element would become inter-connected.
Perhaps this will also allow for keyboard inputs like pressing Tab to navigate to different elements? That could be very useful in the UIForm

I think generally you want mouse focus to be on the inner most thing that accepts the type of input - e,g, if you are mouse wheel scrolling you want scroll the inner most thing you are hovering in terms of containers.
You could test this by sticking a text box with a scrollbar inside of a scrollable area, inside of a scrollable area and check it works how you'd like.
Keyboard focus is a different concept I think, 'mouse focus' is determined by where the mouse is hovering, but keyboard focus is only engaged after a mouse click. Tab focus is definitely more related to keyboard focus than mouse focus but is more broad because you can tab to things you can't type text into. Tab focus is also I think identical with 'trackpad focus' on a console controller, while mouse focus matches better with controller analogue sticks.

Yeah, you're right, these are each a bit different, but those are all cool features to properly implement to make the games and any application in general feel more responsive

Related #450


PR transfer: adding the PGA per chromosome functionality

This is a transfer of feature from parent repo of calculating the PGA by chromosome. Instead of being a separate function, it was included as optional per_chromosome argument to the collate_pga() function. The default value for the new argument is set to FALSE to respect the current behaviour.

Thanks Adam - all very good picks, I'll fix those and push the changes shortly :+1:

Thanks!


🚀 [Feature] Team Page on Wordpress

🚀 Feature

Present our Team to our stakeholders on Wordpress. The idea is to give the initiative a face besides @BerndHueckstaedt and show interested parties that its not just a small initiative but a whole team behind it.
We should consider to group people by profession/tasks but avoid to display a hierarchy if possible.
Examples:

https://css-tricks.com/creating-meet-team-page-wordpress/

https://wordpress.org/plugins/tlp-team/
And here are several plugins for Wordpress in comparison: https://athemes.com/collections/best-team-members-plugins-for-wordpress/

We have a team page! Oh yeah!


Add ability to pass spellcheck and inputType options to CodeMirror

I'm submitting a...

Feature request

After adding
inputStyle: "contenteditable",
spellcheck: true

to the CodeMirror initialisation at https://github.com/Ionaru/easy-markdown-editor/blob/master/src/js/easymde.js#L1584, I was able to get spellchecking within the browser (at least Google Chrome) functional without any apparent issues. If we could pass these options (or arbitrary options that just had defaults) to the CodeMirror initialisation, that would be awesome.
PS. Thanks so much for this fork of simplemde. It powers our internal CMS and our staff love using it.

Any update on this? The built-in spellChecker is very limited and has many outstanding issues.
Being able to pass these options and enable the spellchecker built into the browser would be great, and would also help solve #78.

It would be nice if you can provide additional CodeMirror options to EasyMDE (but use with caution).
I also prefer to use the browser's spell check facility, so for now I manually added the OP mentioned options to the CodeMirror initialisation. It seems to work correctly (tested on Chrome and FireFox).


Metaschema updates

This is one of several pull requests coming up in relation to schema and data validation (probably not this week). This pull request renames and adds a file without changes in functionality.

renaming of metadata.schema.yml to metadata.metaschema.yml: learned from Karl this week that the schemas describing other schemas are called "metaschema". Renaming will clarify this and hopefully resolves some of the confusion on the naming

move the metaschema describing the schema for input data and model parameters from workflows/schemas/jsonschema.yml into simtools/schemas/data.metaschema.yml.

this way metaschema for data and metadata are in one central place
will remove the file in the workflow repository to avoid duplication (as soon as this one has merged)
this file will be used in future for the data validation (next step)

Changed also the examples, unit, and integration tests which read the metadata.metaschema.yml file.

Ok, the grep I did in the right branch but I copied the lines above from main. Then let me be clearer about my suggestion:
I would replace all the references to schema in simtools/data_model/metadata_collector.py to meta_schema. These names are in attributes and methods. For example,
https://github.com/gammasim/simtools/blob/bc06d57910525a252b9abe9bd45f5f25aa0a6899/simtools/data_model/metadata_collector.py#L49-L50
should become
        self.meta_schema_file = None
        self.meta_schema_dict = None

These changes would have to be propagated to the tests as well.
The same would happen to simtools/data_model/metadata_model.py, for example, in :
https://github.com/gammasim/simtools/blob/bc06d57910525a252b9abe9bd45f5f25aa0a6899/simtools/data_model/metadata_model.py#L39
would become
    meta_schema, meta_schema_file = _load_meta_schema(meta_schema_file)

The variable should stay as schema only, without the meta - this code is working for both schema and metaschema files and therefore kept as it is. Is this ok?

Ok, if you prefer this way. But note the name of files are referring to metadata only.


Refresh build, tests, add Node.js 18 to CI

Superseded by:

https://github.com/http4s/http4s-dom/pull/146
https://github.com/http4s/http4s-dom/pull/147
https://github.com/http4s/http4s-dom/pull/148


Reduce safeMove in case of no progress

If propagation in magnetic field doesn't make any progress, start reducing the safeMove to try smaller chord steps. Geant4 only does it after a number of zero-steps, but this would require a counter per track that we generally want to avoid.
Fixes #145

This finally gives correct results compared to Geant4:

It's also quite a bit faster (up to 30% in TestEm3) since we don't have to wait for the stuck particles, until they're eventually killed by the "looping" detection.

Does this reduce the number of killed tracks, and by how much?

I mean, can we lower the number of steps to kill threshold to reduce even more divergence while keeping the results correct?

Does this reduce the number of killed tracks, and by how much?

We don't have statistics about looping tracks since the printouts were deemed too verbose in the past (while actually pointing to a real problem). This does not affect tracks that reach the max_iterations limit.

I mean, can we lower the number of steps to kill threshold to reduce even more divergence while keeping the results correct?

In a second step, yes, but as said yesterday morning we shouldn't kill them but let them progress a bit and try again in the next iteration. I already have code for that.


Add Incremental Merge Strategy

Summary
Add implementation for merge functionality when using an incremental materialization.
Description
Dremio supports both merge and append now. More details on how to use merge strategies can be found here: https://docs.getdbt.com/docs/build/incremental-strategy#strategy-specific-configs.
Test Results
Only ran incremental tests as the new changes don't impact other parts of the adapter.
Changelog

[x] Added a summary of what this PR accomplishes to CHANGELOG.md

Related Issue
(https://github.com/dremio/dbt-dremio/issues/224)

Hi @ravjotbrar
I notice that in the latest version 2.7.0, the merge strategy leads to this error I reported here.(https://github.com/dremio/dbt-dremio/issues/230)
After I use the latest commit in the build (with the below requirements.txt
# get the latest changes - include incremental load
git+https://github.com/dremio/dbt-dremio.git

Using the merge strategy works perfectly.
Do we know when a new release for dbt-dremio will be made? (which then can include the merge strategy??)


Does not seem to be working for 4.19 or 20

Hello I tried opening the project for ue 4.19 version it doesn't work for this at all, is there any way to make it work?

in fact the VDTension rope isn't a thing in the later versions of the VD plugin, did you write that on your own?

Hmmm most likely not. This wasn't designed for later engine versions.
I didn't write the VDTension thing either :(


How to handle eras?

From 2020-09-10 meeting:

FYT: Are eras problematic?  For example, what happens when crossing a Japanese era boundary?  Or when crossing from BC to AD?  I want to make sure your current spec handles this.  If there's a bug, we should fix it in ICU.
FBN: That should be handled in the spec.  I should verify.

Also see https://github.com/tc39/proposal-intl-DateTimeFormat-formatRange/issues/22#issuecomment-658147276

I reviewed the current spec text and double checked that date intervals that cross the Era boundary are being handled correctly.
The issue described in https://github.com/tc39/proposal-intl-DateTimeFormat-formatRange/issues/22#issuecomment-658147276 is an ICU bug that impacts ICU-based implementations. This is currently being tracked in ICU-21222.
cc: @FrankYFTang


[BUG] Item Price

Module Version: v0.5.4
Describe the bug
Alpha Browser isn't able to read item values. Probably since the D&D system introduced currency button.

Hi, thanks for reporting. Yeah, it's broken by one of the latest system updates. I will fix it in a week.

Don't want to press, but I think you forgot this :)

I apologize for unmet expectations, but I finally upload new release with fix


There is no way to disable new hands-free ggv input simulation

Describe the bug
The hands-free GGV input simulation is very useful, but there are some cases / custom projects where the new simulation causes unexpected behavior. It would be great if we could have a checkbox in the input simulation profile to disable the hands-free ggv input simulation. Please also add this to the release notes and documentation, as well as a test to ensure the disable in the profile works.

Marked as release blocking because without this, there is no way to go back to previous behavior. Following principle of "don't break existing behavior" and support as much as we can backwards compatibility.


[WIP] [node] Integration test runner infrastructure

The Problem

Addresses #655
The Solution

Created test infrastructure for testing clients and node together.
Checklist:

[ ] I am making this PR against staging, not master
[ ] My code follows the code style of this project.
[ ] I have described any backwards-incompatibility implications above.
[ ] I have highlighted which parts of the code should be reviewed most carefully.
[ ] If my change requires a change to the documentation, I have updated it accordingly.

Closing this as it's PRing staging -> feature instead of vice versa


prepare_model_for_int8_training assumes layernorm layers contain the string"layer_norm"

prepare_model_for_int8_training assumes layernorm layers contain the string "layer_norm"
This is not always the case. Some models call this "ln", some "layernorm". Perhaps make this an argument?

Hello @edbeeching, please let us know if the above PR resolves the issue

@pacman100 That solution looks perfect. Thank you.


✨[feature Request]: add translator feature

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Is your feature request related to a problem? Please describe.
ADD A TRANSLATOR IN THE WEBSITE TO MAKE THE USER EXPERIENCE GOOD IT WILL BE HELPFUL FOR THE PEOPLE WHO ARE MORE COMFORTABLE TO THEIR NATIVE LANGUAGES
Describe the solution you'd like

Additional context
I can work in this
Use Case
ADD A TRANSLATOR IN THE WEBSITE TO MAKE THE USER EXPERIENCE GOOD IT WILL BE HELPFUL FOR THE PEOPLE WHO ARE MORE COMFORTABLE TO THEIR NATIVE LANGUAGES
Benefits
No response
Add ScreenShots

Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@HS202022 go ahead.

@HS202022 go ahead.

Assign me


test: change exclusions

:tada: This PR is included in version 0.62.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Standard library release actions fail due to uncommitted changes

Description:
It seems most of the stdlib release actions are failed in the latest release due to the following Gradle failure.
> Task :module-ballerina-io:preTagCommit FAILED
Running [git, push, --porcelain, origin, release-0.6.0-alpha7] produced an error: [error: failed to push some refs to 'https://github.com/ballerina-platform/module-ballerina-io'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.]
Release process failed, reverting back any changes made by Release Plugin.

> Task :release FAILED
FAILURE: Build failed with an exception.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
* What went wrong:
Use '--warning-mode all' to show the individual deprecation warnings.
Execution failed for task ':module-ballerina-io:preTagCommit'.
See https://docs.gradle.org/6.4/userguide/command_line_interface.html#sec:command_line_warnings
> Failed to push to remote - [To https://github.com/ballerina-platform/module-ballerina-io
1 actionable task: 1 executed
  !	refs/heads/release-0.6.0-alpha7:refs/heads/release-0.6.0-alpha7	[rejected] (non-fast-forward)
  Done
  ][error: failed to push some refs to 'https://github.com/ballerina-platform/module-ballerina-io'
  hint: Updates were rejected because the tip of your current branch is behind
  hint: its remote counterpart. Integrate the remote changes (e.g.
  hint: 'git pull ...') before pushing again.
  hint: See the 'Note about fast-forwards' in 'git push --help' for details.
  ]

Some of the stdlibs are not failed because those stdlibs set the configuration failOnPublishNeeded = false [1, 2]. Since the stdlib release action commits changes automatically, we shouldn't need this. And that is why previous releases have passed without this error.
Most probably, a recent change might be the cause and we need to fix this in stdlibs.
[1] https://github.com/ballerina-platform/module-ballerina-grpc/blob/master/build.gradle#L182
[2] https://github.com/ballerina-platform/module-ballerina-grpc/runs/2275322110?check_suite_focus=true
Failure builds

https://github.com/ballerina-platform/module-ballerina-io/runs/2275321634?check_suite_focus=true
https://github.com/ballerina-platform/module-ballerina-url/runs/2275321669?check_suite_focus=true

@BuddhiWathsala Check the action history, these failed release builds are due to retriggering the release with same version.


Remove unnecessary mutex added around resource update

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Get X version of the source
'...'

Platform (please complete the following information):

OS: [e.g. Fedora]
Version [e.g. 32]
Go [e.g. 1.13.4

Expected behavior
Optional, use if not obvious. A clear and concise description of what you expected to happen.
Screenshots
Optional, add screenshots to help explain your problem.
Additional context
Optional. Add any other context about the problem here.

@RoddieKieley hi Roddie, I think this mutex is not needed. I added it during fixing operator restart issue and didn't remove it after. That may be one of the possibilities that you are seeing operator hang last week. Pls review. Thanks


Bind notebook editor to search model

Fixes #148068

recreated in #167952 for better tracking locally in gh issues extension


Add httpx support

HTTPX is a requests-API compatible library providing high performance sync and async http clients.
This PR adds both sync and async clients backed by HTTPX.
Given that this client is brand new, maybe consider going with just httpx so that you can offer support for both sync and async clients w/o the complexity or having 2 dependencies w/ vastly different interfaces?

Looking at this, I think (and please correct me) that the goal of having both requests and aiohttp is to provide sync and async clients. And the ability to give users the choice is to avoid having the extra dependency. And then in turn there is templating, abstract classes, etc. built around supporting this.
If this is the case, I think switching to just httpx would simplify things a lot: since it's just 1 dependency, this package can just generate both sync & async clients at the same time: from prisma import AsyncClient, Client. There can be 2 separate interfaces for the sync and async clients, which simplifies the typing aspect. Templating can work pretty much as it does currently, except that both sync and async templates get generated.
What do you think?

I think this would also allow you to remove all of the code generation around QueryEngine, QueryBuilder and Client, leaving code generation only for the models themselves (which are agnostic to sync/async)

the goal of having both requests and aiohttp is to provide sync and async clients

You are correct.

I think switching to just httpx would simplify things a lot

I do agree with that but mainly for the installation aspect, currently we require users to install prisma with an extra which I don't like as a naive first time user can't simply pip install prisma-client.
However I don't like switching to requiring a specific http library when we could support multiple different http libraries without bloating users site packages. I do not know of a solution to this though.

this package can just generate both sync & async clients at the same time

This is already theoretically possible as a user could install both requests and aiohttp at the same time. Generating both async and sync clients at the time is not a priority for me as the only use case I can see for this is typing client agnostic code e.g. a library that uses a user-generated prisma client, like NextAuth does but for python.
This is something I would like to support in the future though, feel free to create an issue for it.

allow you to remove all of the code generation around QueryEngine, QueryBuilder and Client

The QueryBuilder is a template as it requires usage of data that is only available after client generation.

The QueryEngine could in theory be non-generated but this would probably lead to some code duplication which I do not like for user facing code.

The Client must be generated as attributes are dynamic and rely on model names.

While we could refactor the QueryBuilder and the QueryEngine, making modules available pre-generation is not a priority for me.

Also I'm not sure how I feel about adding support for another http library when the testing for requests is already sub-par, I will improve the testing for http libraries before merging this PR.
Thank you though, I really appreciate the effort you have put in to a client I released only a few days ago.

I did a bit of background reading, it seems like the Prisma Query Engine binary plans on moving away from HTTP interaction towards FFI. Which makes the choice of HTTP client a bit of moot point because it is only temporary. Does this sound correct?

You are correct but there are no plans to move completely away from HTTP interaction as it is still needed for usage with the go client and there are no plans to use FFI with the go client anytime soon.
Interaction with the query engine binary using FFI is something that I will implement eventually but it is not a high priority for me as it is very complicated to get right.

Which makes the choice of HTTP client a bit of moot point

I had not thought about it like that, I also think I'm overinflating the benefits of letting users choose the http library that is used internally.
When I have time I'll merge this and then make httpx the default and only http library we use as the only benefit of supporting multiple http libraries internally is reducing dependencies and as we'd have to install httpx anyway that would no longer apply.

Will do, thanks.
From a quick glance through there doesn't seem to be too much to fix, the biggest thing I noticed was that you need to update the http.py.jinja template and http.py module to actually import your httpx code and update the generator config to support passing httpx-async and httpx-sync.
But given that I'm going to refactor a lot of the http stuff to make httpx the default anyway, I don't know if there's much point in cleaning it all up. It's up to you whether or not you want to get this PR fully working or just include the bare bones _http_sync_http.py and _httpx_async_http.py files.

@adriangb Would you be able to have a look at the changes I've requested? If not I'll happily commit them myself if that's okay with you?

Hey @RobertCraigie, sorry I haven't gotten around to it, got really busy all of a sudden. Please feel free to commit to my branch, or close this PR if you want to work on it in your own branch, anything goes, it's your repo 😄

@adriangb No worries, thanks for letting me know about httpx!


optionally pull username and password from procfile (or some other file)?

thoughts on this?

I've not tested this, but you might be able to get it working by committing the HTPASSWD file to your repo. What are your reasons for wanting to have the file in your repository? It seems to violate the 3rd of the 12 factors

Mmm, you're right there... However
I guess I'm really trying to put control of auth details into the Dev who
deploys rather than the sysadmin who sets up the dokku server.
I see these as separate roles and allowing the Dev to control who can
access their app seems to be reasonable.
On 21 Jan 2015 12:27 am, "Matt Oakes"<EMAIL_ADDRESS>wrote:

I've not tested this, but you might be able to get it working by
committing the HTPASSWD file to your repo. What are your reasons for
wanting to have the file in your repository? It seems to violate the 3rd of
the 12 factors
—
Reply to this email directly or view it on GitHub.

Perhaps this is something best handled out of band through something like a
modified version of quais.
On 21 Jan 2015 12:38 am, "airtonix"<EMAIL_ADDRESS>wrote:

Mmm, you're right there... However
I guess I'm really trying to put control of auth details into the Dev who
deploys rather than the sysadmin who sets up the dokku server.
I see these as separate roles and allowing the Dev to control who can
access their app seems to be reasonable.
On 21 Jan 2015 12:27 am, "Matt Oakes"<EMAIL_ADDRESS>wrote:

I've not tested this, but you might be able to get it working by
committing the HTPASSWD file to your repo. What are your reasons for
wanting to have the file in your repository? It seems to violate the 3rd of
the 12 factors
—
Reply to this email directly or view it on GitHub.

For now I'm going to close this. Feel free to reopen if you think there's something we need to do.


Waiting for the codes!

Hi Sorry for the delay. When I had was refactoring the code, the server I worked on got down so publishing got delayed. Lately I've been busy in graduation formalities / job search. I'll update the code in a few days. Thanks for your patience!


(docs) Reorganize writing tasks doc

The order of these sections was unnatural and didn't map well to either
their importance or to how users might adopt them.

Move 'secure coding practices' and 'writing remote tasks' to the end, as those are specialized topics.
Move 'defining parameters'
Move returning errors under structured input and output
Move task metadata basics before no-op, since no-op relies on metadata
Rename more detailed task metadata docs to task metadata reference
Remove 'specifying parameters' as that is about running tasks, not writing them

CLA signed by all contributors.

Still working on editing this, but I'm also going to have to figure out what to do with the PE versions of this page. More on that later

CLA signed by all contributors.

I think this is good to merge in. I'm going to iterate on it a little further, but I'll open a separate PR for that. This is already a huge improvement.


Add spill to disk support for NestedLoop join

Description
Nested Loop join is used for non-equality based join predicates.
Nested loop join is implemented using NestedLoopBuild and NestedLoopProbe operators. The Build side buffers all input vectors in memory. The Probe side streams its input. For each row it repeats all rows of the build side (meeting a filter condition if there is one). This algorithm requires all build side input to fit in memory.
Although the Presto optimizer chooses the build side to be the smaller join table, it cannot be assumed it will fit in memory.
So Nested Loop join should support spilling.
Part of the build input that doesn't fit in memory can spill to disk.
The spilling algorithm could be as follows :
i) On the NestedLoopBuild side spililng is triggered on memory pressure. The spilling can be similar to what is done for Velox OrderBy. We don't really need the sort/merge in the current Velox Spiller framework though. If spilling gets triggered once for an input block, we will have to spill the entire input. If a single driver of NestedLoopJoinBuild spills then all the drivers have to spill as well. The spills of multiple drivers of the NestedLoopJoinBuild comprise the entire spill of the build side seen by the probe side.
ii) On the NestedLoopProbe side each input block has to iterate over all the spilled build side files to generate output.
iii) We cannot leverage dictionaries as in the current code.

@usurai , @xiaoxmeng

If spilling gets triggered once for an input block, we will have to spill the entire input. If a single driver of NestedLoopJoinBuild spills then all the drivers have to spill as well.

Wondering why this is the case.
Also, wondering if this implementation will be so slow as to not being practically useful.

If spilling gets triggered once for an input block, we will have to spill the entire input. If a single driver of NestedLoopJoinBuild spills then all the drivers have to spill as well.

Wondering why this is the case.
We could do a more opportunistic approach that tries to buffer in-memory as much as it can.

On the probe side then as we read each input block, we need to output rows corresponding to the in-memory and spilled part. If we get a request to reclaim as we are looping over this, we can spill what is in memory and resume again.
I'll put some more thought and write up a mini design doc.

Also, wondering if this implementation will be so slow as to not being practically useful.

The NLJ spilling would be slow, but I think we want to have the option to do it if necessary.
Ideally, the query should be rewritten some other way to avoid this.


Swift tests: RSC9

Reference:

(RSC9) Uses Auth to establish what authentication scheme to use, how to authenticate, and automatic issuing of tokens when necessary

Looks good :+1:


Windows / OS-X client

Hello,
i guess its a little bit out of topic, but since i love hyperion, im looking for a WORKING way to set the led's according to my tft screen signal from my pc, using SOFTWARE over network, not an hdmi splitter.
Any ideas?
Thanks,
John

follow this, and enjoy

That's exactly what i'm NOT talking about.. I don't want to switch to a different led-control software like in your link. Further im not using arduino but raspberry pi, i should've mention that.

@john-dev try the new forwarder :)
think can be closed now

@tpmodding it's early here, can you be more specific pleas? :)

Ok, you mean i should compile it for OS-X / Windows and forward the result to the raspberry wiht the led's attachted?

Yes, https://github.com/tvdzwan/hyperion/pull/518 try this one! You can forward your screen with proto-forwarder :)

This should be done, if not, just open a nw issue
Thank you


Add resource limits to kube-rbac-proxy container

Added due to AWS AppSec requirements. From AppSec: "When a container
does not have resource limits, it is possible that its operation could
starve other processes if it is accessed and taxed in an unexpected
way."
Running make runtests and checking resource usage by doing:
$ kubectl exec -it -n aws-privateca-issuer-system aws-privateca-issuer-controller-manager-6b85c78564-zffjp sh

once inside the container:
$ top
Mem: 27054112K used, 98654928K free, 11944K shrd, 1897140K buff, 19609264K cached
CPU:   2% usr   1% sys   0% nic  96% idle   0% io   0% irq   0% sirq
Load average: 0.71 0.48 0.33 2/1096 35
  PID  PPID USER     STAT   VSZ %VSZ CPU %CPU COMMAND
    1     0 65532    S     129m   0%  12   0% ./kube-rbac-proxy --secure-listen-address=<IP_ADDRESS>:8443 --upstream=http://<IP_ADDRESS>:8080/ --logtostderr=true --v=1

/approve


Evaluate the UI design

[x] Does the design fulfill its purpose?
[x] Is it easy to understand?
[x] Is it aesthetically pleasing?
[x] Is the style appropriate for your audience?

This issue has been completed and linked to a pull request.


[Meta] Implement ACP-84

Move from an "RFC 822 style" Preamble to a Markdown table as described in ACP-84.

Curious if people think we should backfill/retrofit the existing ACPs to match this new template? Definitely agree it's the better format going forwards either way.

I also wondered about that. Open to retrofit if people agree.

Curious if people think we should backfill/retrofit the existing ACPs to match this new template? Definitely agree it's the better format going forwards either way.

I'd be happy to update all the ACPs I've authored with this format. It's a significant improvement

Update all existing ACPs with the new format in https://github.com/avalanche-foundation/ACPs/pull/126/commits/18c2b0d27b0514e9ecbc1852f1f91f12951e78d0 (thankfully Vim exists)


[WIP] 633 Update to Rails 5

Coverage decreased (-0.2%) to 99.847% when pulling c275a782047e07e31de5730c1b136f9fbef00170 on 633_update_to_rails5 into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

Coverage decreased (-0.2%) to 99.77% when pulling ce3b9af90a876ee42e749fb7b2c972e50ef0cb4d on 633_update_to_rails5 into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

Coverage decreased (-0.2%) to 99.847% when pulling 8001ae064095b02d03ed71dcad2bc54cb62466b1 on 633_update_to_rails5 into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

Coverage decreased (-0.2%) to 99.847% when pulling 8001ae064095b02d03ed71dcad2bc54cb62466b1 on 633_update_to_rails5 into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

Coverage decreased (-0.2%) to 99.847% when pulling 7a1f6ff306db737b7077c25b7849a14459c4a4ec on 633_update_to_rails5 into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

Coverage decreased (-0.2%) to 99.847% when pulling 7a1f6ff306db737b7077c25b7849a14459c4a4ec on 633_update_to_rails5 into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

Coverage remained the same at 100.0% when pulling e661d72fae0a2cb0f3fd182284641f316a268705 on 633_update_to_rails5 into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

Coverage remained the same at 100.0% when pulling 850cb0bda1f12a9ee4468d9c7afba8258b421673 on 633_update_to_rails5 into d05e0de2ed2e90527cab1b9f219510555cb01c65 on dev.

Coverage remained the same at 100.0% when pulling c84400b9cfdd83948757107b160d7195d5e99042 on 633_update_to_rails5 into d4c2033d0c767f27d1d73606141e18b3f6b77527 on dev.

Coverage remained the same at 100.0% when pulling 74079189f51c4a71db53fcba6349c09b99a3f757 on 633_update_to_rails5 into d4c2033d0c767f27d1d73606141e18b3f6b77527 on dev.

Coverage remained the same at 100.0% when pulling 013dd210365d8c2a2c6dcf0cab32a6d708f01c29 on 633_update_to_rails5 into d4c2033d0c767f27d1d73606141e18b3f6b77527 on dev.

Coverage remained the same at 100.0% when pulling c07dc2784bbec5dceb2da8ab14ba45485629a4c9 on 633_update_to_rails5 into d4c2033d0c767f27d1d73606141e18b3f6b77527 on dev.

Coverage remained the same at 100.0% when pulling d8e2bf706f8d42f7fa34faa7a458597a4215c7fc on 633_update_to_rails5 into d4c2033d0c767f27d1d73606141e18b3f6b77527 on dev.

Coverage remained the same at 100.0% when pulling d8e2bf706f8d42f7fa34faa7a458597a4215c7fc on 633_update_to_rails5 into d4c2033d0c767f27d1d73606141e18b3f6b77527 on dev.

Whoops, I somehow never reviewed the changes you applied after my initial comments. I've done so now, and will merge this once Travis runs through :) Let's find out what else will break with Rails 5 😆


[Feature] Support hidden, ignore-files

It's not uncommon that I want to run diskus on some directory, but want it to ignore certain types of files:
--hidden
It would be nice to be able to ignore hidden files when computing the total.  The flag --[no-]hidden should be available to control this.  The default behavior of diskus should not change.

Hidden directories

.git directories

Hidden files

No specific use-case

--ignore-file (and related things from RipGrep)
Being able to specify an --ignore-file or --[no-]ignore-vcs flag in order to not descend into e.g. a build/ directory.
Ripgrep has several related options (for .gitignore, .rgignore, and general --ignore-file) that might be useful to coopt.
The default behavior of diskus should not change.
Just Make a Pull Request
My employer does not permit FOSS contributions, otherwise I would take a stab at doing this myself.

Thank you for your request. I don't intend on adding more features to diskus:

A minimal, fast alternative to du -sh.

diskus is a very simple program

diskus uses a custom parallel directory walker (unlike fd, which uses ripgreps ignore crate) and it will be difficult to add things like .gitignore handling. Ignoring hidden directories/files might be easy, but I think I prefer not to add this as a feature.
I'm sorry if the "marketing" on the README suggests something else, but so far, I really see this project more like a prototype of how fast a disk-usage tool could be.


{Bot Test} Command Test Coverage: Missing command test and missing parameter test

Description

Test missing command test and missing parameter test.
Checks will failed in azure-cli ci pipeline [Check CLI Command Test Coverage] .
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Bot Test

/azp run

/azp run

/azp run


JSON preview

I can't see the json preview. All I can see is the "root:" message empty. if I click on "Copy json, I have the json used in request.
Note: I use the latest version 4.6.0 with Visual Studio 2017 on windows 10
Thanks,
Dan

Hi @danpamfil ,
Could you please provide a screenshot of the JSON viewer in this scenario, and the JSON payload for the activity you are trying to inspect?

Fyi, attempted to repro but was unable to do so. Tried both a Node and C# bot (using VS 2019) and a fresh install of Emulator, if of use.

Hi,
@tonyanziano
I attached the screenshoots for this issue.

@danpamfil I can't seem to repro this. Is there any way you can share your bot's source code -- without any sensitive info of course -- with me so that I can test it out locally and see if I can reproduce the issue?

@tonyanziano I reproduse this issue again, with a new echo bot project using Visual Studio 2019 and new installation of Bot Framework 4.6.0. Please see attached screenshoots.
P.S.: Last year, someone moved my user profile from C: drive to D: drive. Can this be a problem for Bot Framework Emulator?
Regards,
Dan

Thanks @danpamfil for the screenshots. I'll try this out using the project template above.
Moving your user profile shouldn't interfere with the Emulator, as we don't store anything that would affect the performance of the inspector.
One thing that I'm noticing is that when you click the message you want to inspect, it is not being highlighted. Usually the inspected message activity bubble will turn yellow when clicked on. So I'm thinking there is some bug preventing the correct activity data from being forwarded to the inspector to be shown in the JSON tree component.
Can you reproduce this, and open the application Developer Tools by pressing Ctrl + Shift + I and see if there are any errors in the Console tab?

Sure @tonyanziano ,

Hi @danpamfil ,
Sorry for the very delayed response. Your screenshot of the console doesn't show any errors pertaining to the JSON inspector. So it doesn't appear to me that the passing of the activity JSON to the inspector is the issue, it might instead be something in the JSON extension itself.
Does this happen on every message / bot you try? Or is it just the echo bot template?

Closing due to inactivity.