Added support for 'allow-downloads' attribute for CSP sandbox directive

As reported in issue #168 Chrome browser no longer allows downloads if Sandbox mode is enabled and allow-downloads is not explicitly specified. This pull request adds support for an 'allow-downloads' attribute on the Sandbox directive.

This would be a helpful PR to merge and release. Sorry if the answer is obvious to those in the know, but is there a reason to block this PR?
Perhaps it's just the usual and understandable factors of priorities and available time. Thanks in advance for any replies.

Hi,
Thanks for this PR. I really need this to be implemented.


Moving TV Show Name Disrecpencies

I am frequently encountering mismatches with names. I just tried to "Tell Plex to play Godfather" and it played the movie "Go (1999)" and does so every time I ask the same thing. No logs that I can see. What do I need to do to provide you with logs/help fixing these mismatches?

Adding the code below to your configuration.yaml file will add debug logs to your full HA logs. This might help in diagnosing what Google Assistant is hearing and what Plex Assistant is parsing.
logger:
  logs:
    custom_components.plex_assistant: debug

Plex Assistant uses fuzzywuzzy in order to pick the highest scoring match between the spoken title and a list of media titles. You can help this process in cases where TV shows and movies have the same title by mentioning movie, tv, or show in your command like "tell plex to play the movie godfather".
In the case you mention though they are very different. Try using complete titles, for example Godfather is actually not the name of the movie, it is "The Godfather". Check the actual movie titles on Plex to see where there may be discrepencies.

Looked into this more and this is just an embarassing bug that will be fixed in the next version.
The "the" in "GodfaTHEr" is getting caught in the detection of the seperator between media and device. Should have a release out soon with the fix as Pychromecast just fixed the grey screen issues. I'm fixing things up since this makes cast delay no longer needed. This will not only speed things up quite a bit, but also make configuration considerably easier. Also tweaking the fuzzy seaching to, hopefully, be more accurate.

These issues should be remedied in the latest release


chore: drop MulZeroClass. in mul_zero/zero_mul

Search&replace MulZeroClass.mul_zero -> mul_zero, MulZeroClass.zero_mul -> zero_mul.
These were introduced by Mathport, as the full name of mul_zero is actually MulZeroClass.mul_zero (it's exported with the short name).

bors d+
Thanks! I edited the description with a brief explanation.

bors merge


ENH: update package version to 0.247.1

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #238.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #238

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11634144463.

I think I broke something @bollwyvl when trying to update the pypi url? Something about the SHA hash


fix: start menu does not respect package manager

Add a command to each start menu entry in package.json and use it instead of assuming this is a yarn script. This opens the door for decoupling start menu from yarn/npm and allowing it to be used in other project types as an entry point.
This change also adds ScriptOptions to node.addScript() such that it is possible
to register a start menu entry together with adding scripts to the project.
Fixes #217
BREAKING CHANGE: node.addScript(script, command) now takes a single command instead of variable arguments. Use node.addScript(script, [s1,s2].join(' && ')) to build a command from multiple statements.

@Chriscbr @abelmokadem what do you think?

Registering start menu entries with addScript() LGTM!

This opens the door for decoupling start menu from yarn/npm and allowing it to be used in other project types as an entry point.

How do you mean - like project types in other languages, or ...? It seems like the information that is getting added in package.json is a bit redundant, at least in the current use case ("build" command refers to "yarn run build" which refers to "tsc && ...") My concern would be if this added layer of indirection later on leads to build logic seeping elsewhere, like...
"scripts": {
  "test": "yarn run lint && ...",
  "compile": "tsc && ..."
},
...
"start": {
  "build": {
    "desc": "Full release build (test+compile)",
    "command": "yarn run test && yarn run compile",
    "category": 0
  }
}

In that sense, I don't think we would want projen to accidentally develop its own build system logic. That said I probably have less experience using different build systems, so maybe what I'm describing isn't a big concern.

I am actually thinking there is some value in making projen a programming language agnostic entry point for interacting with the project, similar to npm run or yarn run. Naturally not a build system but the front end for interacting with your project. This doesn't mean that node project types won't have all those commands available through npm scripts but I think we can offer a very attractive experience that spans beyond a specific language if projen takes that role.
To that end, decoupling the start menu from npm scripts (and moving it outside of package.json) can go a long way.
The beauty is that this is all governed by our code so it won't incur additional setup overhead.
This is just the first step.

Ah gotcha, yeah this definitely makes sense as an intermediary step then. 👍


No validation on input

Because of the use of ng-bind-html, users can type <script> tags and insert code, or break the page because JQuery tries to execute the code blocks.
I am currently fixing this manually with text.replace('script>', 'div>');

Just saw this was fixed by https://github.com/ritz078/ngEmbed/pull/15!


emmet abbrivation command is not working, please fix it

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

1


Empty ExtendedProperties in Google Contacts

I have posted this also to SO (http://stackoverflow.com/questions/40051023/empty-extendedproperties-in-google-contacts)  but got no real replies.
Some users of my application (which uses Google API .NET client) during update of Google contacts are receiving error like: [Line 23, Column 38, element gd:extendedProperty] exactly one of g:extendedProperty/@value, XML is required.
This is triggered by element: <gd:extendedProperty name="GCon" /> which does not have value filled. I am not updating this field, I am updating other fields (via call to Google .NET API Update call) and despite this error is thrown. I do not see how I can overcome this. I can find such property, but API does not give me option to set it to empty value. I can put some dummy value: <gd:extendedProperty name="GCon" value="dummy"/> but I do not want to broke some other application which sets this property.
What other solutions do I have?

Google Contacts is a gdata API.  This client library only supports discovery apis.  Here is GitHub project for Google-gdata however I dont think anyone is supporting that anymore.    I think stack is going to be the best place to get help for it.

ok, I will close this issue here.


dgram.js error after upgrading to version 6.0.0

Node version : v6.9.1 (tried v6.9.2 too)
Doing :
isOnline().then(online => {
    // ...
  })

dgram.js:530
    throw new Error('Not running'); // error message from dgram_legacy.js
    ^

Error: Not running
    at Socket._healthCheck (dgram.js:530:11)
    at Socket.close (dgram.js:424:8)
    at Timeout.setTimeout (/Users/sylvain/git/gd-cli/node_modules/is-online/index.js:48:15)
    at ontimeout (timers.js:365:14)
    at tryOnTimeout (timers.js:237:5)
    at Timer.listOnTimeout (timers.js:207:5)

if I comment :
// udpSocket.close();
It works correctly. Maybe it's not required to close since it timeout ?

probably is necessary add another validation:
if (udpSocket && udpSocket.Socket) {
Can you check ?

The issue looks to be that the udpSocket variable is not shared correctly between the two functions. The udpSocket = null in listen does only change the local variable on that function's scope, not the one in send. I'll fix that by using a top-scope variable.


Working with a new reference map

Hi all,
First of all, thank you for your awesome work.
Your code is very well structured and commented on, and that really helps to understand and learn how it works.
I have been trying to implement it on a new dataset.
I was able to run it without issues with the catec example.
However, with my data, I need help to get it to work.
You can find here a small set of my data (together with a launch file that executes your package):
The issue seems to be related to the map, even when I reduced the size of the map drastically, the method still seems to not be able to recognize it.
One interesting fact is that If I play my bag file and load your catec.bt map, the method tries to find the correct alignment and works much better than with my map,
Using my map, after giving the initial pose the current scan stays for a few seconds in that pose and then jumps far away.
I have tried to create smaller and dense maps, however, I have yet to succeed to make it work.
Is there something special I should consider while changing the map (besides the size which was already mentioned in this issue)?
The other question I have is about using the odometry from LOAM, I think I will create another issue for that later.

Hi Miguel Ángel,
At first glance, I can see in your launch file that parameter "align_method" is set to 3, which is ICP. Please, set to 1 (DLL).
In addition, I would have a look at the TF-tree to see if the different frames are ok, and well-connected.
If the error persists, do not hesitate to email me (you find my email it in the paper), so that you can give me details directly.
Un abrazo,
Fernando caballero

Hi Miguel Arturo,
The TF seems to be right. Your map, in principle, looks good, do not see any reason to not work properly. I will take a look at your bag and map during this week, and let you know about it.
Regarding your questions about the .bt, we use it because it is convenient. Normally, you do not have a single point-cloud of the map. Instead, people launch a slam, localize the robot and then “accumulate” the poin-cliuds of the different robot's poses. We use octomap for mapping, which produce .bt files a representation of the environment. If you have a single .pcd file with the point-cloud of the envirnoment, then it is easy to update the code to read directly from it insteat of the .bt.
Fernando Caballero

Hi Fernando,
A ok, so the .bt is used because of octomap. I also like it; it is very convenient to have a representation of the free space for me as well!
Thanks, let me know if you have issues or questions regarding my bag and map files.
Best,
Miguel

Hi Miguel,
Taking a look to your data, I can see the following issues:

The resolution of your map is approximately 0.5m. The distance function grid is set to the resolution of your map, and 0.5 definitely too high. Create a map with 0.05 resolution, so that the distance function can have good granularity.
I think the initial position given in the launch file is wrong.
I have the filling that the lidar is upside-down but this transform is not included into the sensor to base_link TF, could it be?

Hope this help,
fernando

Dear Miguel, did you solve this issue? Something new to comment?

Dear Fernando,
Thanks for your help.
I'm sorry for not getting back to you sooner; I have been focusing on other issues.
Recently, we have tried the following:
We first generated a new map ConSLAM_cut05.bt with a resolution of 0.05, as you instructed, and obtained an accurate initial robot position.
However, a significant drift occurs during the localization process, and the LIDAR scan point cloud does not align with the 3D map.
Even with the correct initial z value, the map jumps at the very beginning and seems to be below the floor of the prior map.
As a result, we modified the z-coordinate of the initial position from 0.58 to 3.58. Subsequently, the robot appeared in the correct position, and it ran stably for the first 40-50 seconds. However, severe deviation issues started occurring afterward.
Here is the link to Dropbox, which contains the files (launch file, bt.map, rosbag) and recorded video https://www.dropbox.com/scl/fo/s2q0la83senu6gboo7fox/h?rlkey=uor566d2jbkhfq9iw0t7un9d1&dl=0
The lidar is also not upside-down; it only looks like that at the beginning since it scans some points in the ceiling. Moreover, other localization algorithms work very well with that initial pose, so the pose is correct.
We appreciate any help.
Best,
Miguel

Hi again Miguel,
I found a small bug in the loss function parameterization, in the DLL Solver. Once fixed, I was able to run your bag using 2.5m as initial altitude. You can find the result in the following video:
https://drive.google.com/file/d/1qeOdwUJgNZ-IBTSwzhv9SDU6_fsl3ebn/view?usp=sharing
Please, notice that DLL does not compute roll and pitch angles, if you do not provide an IMU or 6DoF odometry, it will be assumed the roll and pitch angles are zero. In this case, you can see in the video (second 50) that the LIDAR is tilted, but this tilt angle is not compensated because your bag have no IMU neither 6DoF odometry. This produces alignment errors in the solution that could be mitigated if IMU was provided.
I just push the fix to the solver, update your git and check if things works.
Fernando


SODEV-35387 - feat(chromatic): Skip Chromatic label and output

Do you have a test PR for this? Seems like I saw it somewhere


Capacity overflow when adding runtime table cfg only with 20 lookups

See branch issue/14067.
(* Replicating https://github.com/o1-labs/proof-systems/blob/master/kimchi/src/tests/lookup.rs#L130 *)
let main_runtime_table_cfg () =
  let num = 5 in
  let first_column = Array.init size ~f:Field.Constant.of_int in
  let table_ids = Array.init num ~f:Int32.of_int_exn in
  Array.iter table_ids ~f:(fun table_id ->
      add_plonk_constraint (AddRuntimeTableCfg { id = table_id; first_column }) ) ;
  let num_lookup = 20 in
  let rec make_lookup i n =
    if i = n then ()
    else
      let table_id = i mod num in
      add_plonk_constraint
        (Lookup
           { w0 = fresh_int table_id
           ; w1 = fresh_int 1
           ; w2 = fresh_int 1
           ; w3 = fresh_int 2
           ; w4 = fresh_int 2
           ; w5 = fresh_int 3
           ; w6 = fresh_int 3
           } ) ;
      make_lookup (i + 1) n
  in
  make_lookup 1 num_lookup

Getting
Uncaught exception:

  (Failure "capacity overflow")

Raised by primitive operation at Kimchi_pasta__Vesta_based_plonk.Keypair in file "src/lib/crypto/kimchi_backend/pasta/vesta_based_plonk.ml", line 53, characters 48-474
Called from Kimchi_backend_common__Dlog_plonk_based_keypair.Make.create in file "src/lib/crypto/kimchi_backend/common/dlog_plonk_based_keypair.ml", line 192, characters 6-126
Called from Pickles__Impls.Step.Keypair.generate in file "src/lib/pickles/impls.ml", line 46, characters 20-46
Called from Pickles__Cache.Step.read_or_generate in file "src/lib/pickles/cache.ml", line 101, characters 14-174
Called from CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 31, characters 17-27
Re-raised at CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 36, characters 4-11
Called from Pickles__Cache.Step.read_or_generate in file "src/lib/pickles/cache.ml", line 121, characters 25-38
Called from CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 31, characters 17-27
Re-raised at CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 36, characters 4-11
Called from Pickles__Compile.Make.compile.(fun) in file "src/lib/pickles/compile.ml", line 613, characters 51-66
Called from Pickles_types__Vector.map in file "src/lib/pickles_types/vector.ml", line 140, characters 48-51
Called from Pickles_types__Vector.map in file "src/lib/pickles_types/vector.ml", line 140, characters 55-64
Called from CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 31, characters 17-27
Re-raised at CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 36, characters 4-11
Called from Pickles__Wrap_main.wrap_main.main.(fun) in file "src/lib/pickles/wrap_main.ml", line 215, characters 28-50
Called from Snarky_backendless__Snark0.Run.Make_basic.with_label in file "src/lib/snarky/src/base/snark0.ml", line 1253, characters 14-18
Called from Pickles__Wrap_main.wrap_main.main.(fun) in file "src/lib/pickles/wrap_main.ml", line 213, characters 10-466
Called from Snarky_backendless__Snark0.Run.Make_basic.with_label in file "src/lib/snarky/src/base/snark0.ml", line 1253, characters 14-18
Called from Snarky_backendless__Snark0.Run.Make_basic.as_stateful in file "src/lib/snarky/src/base/snark0.ml", line 755, characters 14-18
Called from Snarky_backendless__Checked_runner.Make_checked.constraint_count in file "src/lib/snarky/src/base/checked_runner.ml", line 313, characters 12-36
Called from Snarky_log.Constraints.log in file "src/lib/snarky_log/snarky_log.ml", line 28, characters 6-257
Called from Pickles__Compile.Make.log_wrap in file "src/lib/pickles/compile.ml", line 323, characters 8-223
Called from Pickles__Compile.Make.compile in file "src/lib/pickles/compile.ml", line 640, characters 28-58
Called from Pickles__Compile.compile_with_wrap_main_override_promise in file "src/lib/pickles/compile.ml", line 1047, characters 4-274
Called from Pickles.Make_str.compile_promise in file "src/lib/pickles/pickles.ml" (inlined), line 294, characters 4-238
Called from Pickles.Make_str.compile in file "src/lib/pickles/pickles.ml", line 303, characters 6-183
Called from Dune__exe__Pickles_test_optional_custom_gates.register_test in file "src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml", line 342, characters 4-1023
Called from Dune__exe__Pickles_test_optional_custom_gates.register_feature_test in file "src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml", line 400, characters 2-66
Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
Called from Base__List0.iter in file "src/list0.ml" (inlined), line 25, characters 16-35
Called from Dune__exe__Pickles_test_optional_custom_gates in file "src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml", line 425, characters 2-51

Found that it comes from the module vec in stdlib.

The variable size is a random value. And the error depends on the value of size. Sometimes, we are getting:
  "Assert_failure src/lib/crypto/kimchi_backend/common/poly_comm.ml:131:16"

Raised at Kimchi_backend_common__Poly_comm.Make.of_backend_without_degree_bound.(fun) in file "src/lib/crypto/kimchi_backend/common/poly_comm.ml", line 131, characters 16-28
Called from Stdlib__Array.map in file "array.ml", line 106, characters 21-40
Called from Base__Array0.map in file "src/array0.ml" (inlined), line 51, characters 15-34
Called from Kimchi_backend_common__Poly_comm.Make.of_backend_without_degree_bound in file "src/lib/crypto/kimchi_backend/common/poly_comm.ml", line 129, characters 10-156
Called from Kimchi_backend_common__Dlog_plonk_based_keypair.Make.full_vk_commitments.g in file "src/lib/crypto/kimchi_backend/common/dlog_plonk_based_keypair.ml", line 232, characters 12-62
Called from Base__Option.map in file "src/option.ml", line 265, characters 23-28
Called from Pickles_types__Vector.init in file "src/lib/pickles_types/vector.ml", line 123, characters 45-48
Called from Pickles_types__Vector.init in file "src/lib/pickles_types/vector.ml", line 123, characters 52-69
Called from Kimchi_backend_common__Dlog_plonk_based_keypair.Make.full_vk_commitments in file "src/lib/crypto/kimchi_backend/common/dlog_plonk_based_keypair.ml", line 262, characters 8-185
Called from Pickles_types__Vector.map in file "src/lib/pickles_types/vector.ml", line 140, characters 48-51
Called from CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 31, characters 17-27
Re-raised at CamlinternalLazy.force_lazy_block in file "camlinternalLazy.ml", line 36, characters 4-11
Called from Pickles__Wrap_main.wrap_main.main.(fun) in file "src/lib/pickles/wrap_main.ml", line 215, characters 28-50
Called from Snarky_backendless__Snark0.Run.Make_basic.with_label in file "src/lib/snarky/src/base/snark0.ml", line 1253, characters 14-18
Called from Pickles__Wrap_main.wrap_main.main.(fun) in file "src/lib/pickles/wrap_main.ml", line 213, characters 10-466
Called from Snarky_backendless__Snark0.Run.Make_basic.with_label in file "src/lib/snarky/src/base/snark0.ml", line 1253, characters 14-18
Called from Snarky_backendless__Snark0.Run.Make_basic.as_stateful in file "src/lib/snarky/src/base/snark0.ml", line 755, characters 14-18
Called from Snarky_backendless__Checked_runner.Make_checked.constraint_count in file "src/lib/snarky/src/base/checked_runner.ml", line 313, characters 12-36
Called from Snarky_log.Constraints.log in file "src/lib/snarky_log/snarky_log.ml", line 28, characters 6-257
Called from Pickles__Compile.Make.log_wrap in file "src/lib/pickles/compile.ml", line 323, characters 8-223
Called from Pickles__Compile.Make.compile in file "src/lib/pickles/compile.ml", line 641, characters 28-58
Called from Pickles__Compile.compile_with_wrap_main_override_promise in file "src/lib/pickles/compile.ml", line 1049, characters 4-274
Called from Pickles.Make_str.compile_promise in file "src/lib/pickles/pickles.ml" (inlined), line 294, characters 4-238
Called from Pickles.Make_str.compile in file "src/lib/pickles/pickles.ml", line 303, characters 6-183
Called from Dune__exe__Pickles_test_optional_custom_gates.register_test in file "src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml", line 347, characters 4-1023
Called from Stdlib__List.iter in file "list.ml", line 110, characters 12-15
Called from Base__List0.iter in file "src/list0.ml" (inlined), line 25, characters 16-35
Called from Dune__exe__Pickles_test_optional_custom_gates in file "src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml", line 430, characters 2-51

For instance, with the value size = 1_000, we are getting capacity overflow.
With the value size = 10, we are getting the assert failure in poly_comm.

This is fixed by computing correctly the domain size


unit tests

create unit tests for all sections of code.

The current ways to run SimPrily:
See https://github.com/agladstein/SimPrily#input
The following can be run with examples 1, 3, 4, 6, 7 in the examples directory.
python simprily.py -p examples/eg1/param_file_eg1_asc.txt -m examples/eg1/model_file_eg1_asc.csv -g genetic_map_b37/genetic_map_GRCh37_chr1.txt.macshs -a array_template/ill_650_test.bed -i 1 -o output_dir --profile

python simprily.py -p examples/eg1/param_file_eg1_asc.txt -m examples/eg1/model_file_eg1_asc.csv -g genetic_map_b37/genetic_map_GRCh37_chr1.txt.macshs -a array_template/ill_650_test.bed -i 1 -o output_dir

python simprily.py -p examples/eg1/param_file_eg1_asc.txt -m examples/eg1/model_file_eg1_asc.csv -g genetic_map_b37/genetic_map_GRCh37_chr1.txt.macshs -i 1 -o output_dir

python simprily.py -p examples/eg1/param_file_eg1_asc.txt -m examples/eg1/model_file_eg1_asc.csv -a array_template/ill_650_test.bed -i 1 -o output_dir

python simprily.py -p examples/eg1/param_file_eg1_asc.txt -m examples/eg1/model_file_eg1_asc.csv -i 1 -o output_dir

There are other possible combinations with the optional arguments, but i'm not going to list them all here.
In the model file
-macs,./bin/macs, or -macs_file
will change what runs the simulation.
You can find an example with -macs_file here https://github.com/agladstein/SimPrily/tree/master/examples/macs_file_input
You also can run it and create the pseudo array (https://github.com/agladstein/SimPrily/blob/master/Manual.md#snp-array-ascertainment-arguments)
You need to include the following in the model file
-discovery, 1
-sample, 2
-daf, daf
-random_discovery, True

After -random_discovery can be True or False.
You can also include the following options in the model file
https://github.com/agladstein/SimPrily/blob/master/Manual.md#germline
https://github.com/agladstein/SimPrily/blob/master/Manual.md#pedmap
-germline

and
-pedmap


LAB_05_Implementing_and_configuring_virtualization_in_Windows_Server.md

Source:
An IT office and datacenter are in Seattle to support the Seattle location and other locations. Contoso recently deployed a Windows Serverserver and client infrastructure.
Current Translation:
IT オフィスとデータセンターはシアトルにあり、シアトルの場所やその他の場所をサポートしています。 Contoso では最近、WindowsServer サーバーとクライアント インフラストラクチャを展開しました。
Suggested Translation:
IT オフィスとデータセンターはシアトルにあり、シアトルやその他のオフィスをサポートしています。 Contoso 社では最近、Windows Server とクライアント インフラストラクチャをデプロイしました。

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team


remove failing test form CI?

https://github.com/scverse/cookiecutter-scverse/blob/92c74be6dd2e1619151346ed48da6cdf3abcbe94/{{cookiecutter.project_name}}/tests/test_basic.py#L9

I think we can just skip that specific test when running tests for the instantiated project. That way we can check if the tests of that project run in general while still teaching people to write tests.


Fix broken comments introduced by ddmd conversion

Broken style was introduced by ddmd conversion.
Ping: @yebblies

Auto-merge toggled on

@yebblies Thanks!


config: add flatcar variant

Hi,
With the latest Alpha release of Flatcar (3185.0.0), Ignition version has been updated to 2.13.0. Besides Ignition v1 and v2 configurations, Ignition configurations with specification v3 (up to 3.3.0) are now supported.
This PR brings a flatcar butane variant to generate Ignition spec to version 3.3.0.

Looks good generally; one bug and some nits.

LGTM!  CI is failing on the gofmt check though.

LGTM! CI is failing on the gofmt check though.

@bgilbert done. I use goimports to format *.go files and it does not run gofmt with the -s option as required by golangci-lint. Anyway, thanks for your review and for the feedback regarding LUKS usage, really appreciated !


Optional eventBatchSize and eventFlushInterval

Hi, as per the docs the eventBatchSize and eventFlushInterval seem optional in 2.9.0
This is confirmed by the type definitions:

However, I'm getting the following console warnings:
[OPTIMIZELY] - WARN  2022-07-27T10:01:02.068Z Invalid eventBatchSize undefined, defaulting to 10
[OPTIMIZELY] - WARN  2022-07-27T10:01:02.068Z Invalid eventFlushInterval undefined, defaulting to 1000

Related to: #175

@opti-jnguyen @opti-josh-holt 👋 Are either of you able to please assist with the above and #175? Or let me know who else I can ask. Thank you.

This and #175 have been picked up by Optimizely support 👍

Closing as per Opti Support update

Hi everyone! Can we watch the progress once the support team picks it up?
The latest version published on npm is 2.9.2 (from March 2023) and it still logs these warnings.

Just adding to the chorus, I don't think this should have been closed. I'm using the latest version of the react SDK (3.1.0), which logs these warnings despite the configs supposedly being optional. It's very annoying. Either the configs should be mandatory, or those logs should not be emitted.
There's also this error:
client.js:1 [OPTIMIZELY] - ERROR 2024-05-19T10:32:41.837Z undefined: ODP is not integrated

I had to spend ages reading through the SDK source config in order to figure out that I need to pass odpOptions: { disabled: true } when initialising the client. I feel like this error should only occur if I've explicitly tried to enable ODP without configuring it properly. If I haven't tried to enable or configure ODP at all, then it should just silently be disabled, not log errors.

We've tested #262 which depends on JS PR #930 We anticipate should resolve this error.


The protocol scheme was added in the phase of finding the active RM.

I faced with the issue "Python request: No connection adapters were found for..." when I passed yarn-site.xml file and called the constructor of the class ResourceManager without any arguments.
According to the Yarn documentation https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/ResourceManagerHA.html
the protocol scheme isn't stored in the values of parameters yarn.resourcemanager.webapp.address.rm-id & yarn.resourcemanager.webapp.https.address.rm-id

Can you confirm that you tried it on python 3.8.1?
I seem to have noticed change in behaviour and detailed my finding in #69

@dimon222 I faced with the issue (lacking of the protocol scheme) using Python 3.8.0 version.
I've just updated Python version on 3.8.1 and run the unit tests:
... raise exceptions.NoMockAddress(request) requests_mock.exceptions.NoMockAddress: No mock address: GET example.com://80/ololo
Indeed, not all tests successfully completed on the 3.8.1 version.
On the 3.7.6 Python version the situation is the same:
`λ C:\temp\venv\hadoop-yarn-api-python-client\Scripts\python.exe --version
Python 3.7.6
Testing started at 11:42 PM ...
C:\temp\venv\hadoop-yarn-api-python-client\Scripts\python.exe "C:\Program Files (x86)\JetBrains\PyCharm Community Edition 2019.3\plugins\python-ce\helpers\pycharm_jb_unittest_runner.py" --path C:/git/hadoop-yarn-api-python-client/tests
Launching unittests with arguments python -m unittest discover -s C:/git/hadoop-yarn-api-python-client/tests -t C:\git\hadoop-yarn-api-python-client\tests in C:\git\hadoop-yarn-api-python-client\tests
DEBUG:yarn_api_client.application_master:Get configuration from hadoop conf dir
INFO:yarn_api_client.base:API Endpoint example.com://80/ololo
DEBUG:requests_mock.adapter:GET example.com://80/ololo 404
INFO:yarn_api_client.base:API Endpoint example.com://80/ololo
DEBUG:requests_mock.adapter:GET example.com://80/ololo 200
INFO:yarn_api_client.base:API Endpoint example.com://80/ololo
Error
Traceback (most recent call last):
File "C:\Python\3.7.6\lib\unittest\case.py", line 59, in testPartExecutor
yield
File "C:\Python\3.7.6\lib\unittest\case.py", line 628, in run
testMethod()
File "C:\git\hadoop-yarn-api-python-client\tests\test_base.py", line 32, in test_valid_request_with_parameters
response = client.request('/ololo', params={"foo": 'bar'})
File "C:\git\hadoop-yarn-api-python-client\yarn_api_client\base.py", line 78, in request
response = self.session.request(method=method, url=api_endpoint, headers=headers, timeout=self.timeout, **kwargs)
File "C:\temp\venv\hadoop-yarn-api-python-client\lib\site-packages\requests\sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "C:\temp\venv\hadoop-yarn-api-python-client\lib\site-packages\requests_mock\mocker.py", line 111, in _fake_send
return _original_send(session, request, **kwargs)
File "C:\temp\venv\hadoop-yarn-api-python-client\lib\site-packages\requests\sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "C:\temp\venv\hadoop-yarn-api-python-client\lib\site-packages\requests_mock\adapter.py", line 255, in send
raise exceptions.NoMockAddress(request)
requests_mock.exceptions.NoMockAddress: No mock address: GET example.com://80/ololo
DEBUG:requests_mock.adapter:GET https://example2:8022/cluster 200
DEBUG:requests_mock.adapter:GET https://example2:8022/cluster 500
Error to access RM - HTTP Code 500
DEBUG:requests_mock.adapter:GET https://example2:8022/cluster 404
Error to access RM - HTTP Code 404
DEBUG:requests_mock.adapter:GET https://example2:8022/cluster 401
Error to access RM - HTTP Code 401
DEBUG:yarn_api_client.history_server:Get information from hadoop conf dir
DEBUG:yarn_api_client.resource_manager:Get configuration from hadoop conf dir: /etc/hadoop/conf
Ran 85 tests in 0.199s
FAILED (errors=1)
Process finished with exit code 1
Assertion failed
Assertion failed
Assertion failed
`

Interesting, I'm able to run tests successfully on 3.8.0
Also TravisCI confirms all tests on 3.8.0 and 3.7.1. Could be some change been ported to other python trees.
https://travis-ci.org/toidi/hadoop-yarn-api-python-client/builds/629721243

@dimon222 I think I found interesting thing:
`C:\Users\Melchizedek\Downloads
λ python
Python 3.8.1 (tags/v3.8.1:1b293b6, Dec 18 2019, 22:39:24) [MSC v.1916 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.

from urllib.parse import urlparse
urlparse('example.com:80')
ParseResult(scheme='example.com', netloc='', path='80', params='', query='', fragment='')
`

`Python 3.7.4 (default, Jul  9 2019, 00:06:43)
[GCC 6.3.0 20170516] on linux

from urllib.parse import urlparse
urlparse('example.com:80')
ParseResult(scheme='', netloc='', path='example.com:80', params='', query='', fragment='')
`

It's due with the test "test_valid_request_with_parameters()":
    def get_client(self):         client = base.BaseYarnAPI()         client.service_uri = base.Uri('example.com:80')
where base.Uri is
class Uri(object):     def __init__(self, service_endpoint):         service_uri = urlparse(service_endpoint)

I think I confused this thread with another issue altogether. My apology for this.
Essentially 2 issues.

This PR is fixing prepending protocol for URLs parsed out of configuration file since we directly parse it from config to pass to requests library when user didn't supply any argument.
Test is breaking because new python patch is changing the way urlparse works, so it will break when user is passing urls like "localhost:80" to constructor manually (not via configuration file). I've prepared fix for this in another PR #70 .

Thanks for helping, hopefully @lresende @kevin-bates can assist on reviewing this PR.

@dimon222
You're welcome =)
I'm glad I was able to help.

Hello!
This test is failing because get_resource_manager_endpoint function is now returning RM address with a protocol scheme.

I have added a PR that enables builds with the latest Python 3.8.x and I still cannot see any breaking build issues - see build results.
Having said that, I will trust @dimon222 and/or @kevin-bates judgment here. Please let me know what do you guys think.

@lresende test is written in assumption that it was working with this type of URL, but I guess it wasn't. It's highly possible that regression was introduced when active_rm check was changed to utilize requests library, as it's the requests library that looks for scheme


Make webhook http connections resuable

The httplib will always create a new http.Client. That's no problem when there are few webhook sent. But when you have hundred of thousand webhooks to be sent, it will never reuse http connections. So let's keep only one http.Client for webhooks.

Codecov Report

Merging #6976 into master will increase coverage by 0.05%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #6976      +/-   ##
==========================================
+ Coverage   41.44%   41.49%   +0.05%
==========================================
  Files         441      440       -1
  Lines       59696    59450     -246
==========================================
- Hits        24739    24670      -69
+ Misses      31732    31563     -169
+ Partials     3225     3217       -8

Impacted Files
Coverage Δ

models/webhook.go
56.73% <40%> (-3.03%)
:arrow_down:

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

routers/repo/view.go
42.02% <0%> (-1.02%)
:arrow_down:

modules/httplib/httplib.go

models/gpg_key.go
56.66% <0%> (+0.83%)
:arrow_up:

modules/log/colors_router.go
87.5% <0%> (+4.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de76b6...b293feb. Read the comment docs.


Expose drag and drop from filesystem to GDScript

from
https://godotengine.org/qa/5972/list-files-that-been-dragged-onto-games-window-their-directory

I want to create a batch processing application in godot - that takes for input files that have been dragged and dropped by the user to the application window. Is that something that is possible to do in godot? I need to get that data and store it in an array

Other possible applications of this would be for plugins - being able to drag external files onto a godot plugin window.

After some investigation, i found there's a API for using D&D from the OS exposed to GDScript, there's a MainLoop::_drop_files virtual function, and files_dropped(StringArray files, int screen) signal on SceneTree.
I've made a simple example, where you can drag images into the application window, and it'll show all images in a ItemList:
drag_n_drop_os.zip

Thank you! I am going to try this out today

files_dropped(StringArray files, int screen) is missing in the documentation!
:o

@blurymind, i think this is because this feature is not available in 2.0.x versions. Only on Github HEAD.

nice! I wonder how many other hidden features there are :)

Seeing as to how this feature exists already in godot head master - do you guys think I should close this? Is there anything that is missing in the current implementation?

Well, IMO this should be closed since we already support it in master. If there are bugs with the implementation itself, open a new issue, but if there are issues with the way it is exposed, you might decide it is better to comment here.

I think the file @TheHX provided should be included in the demos folder. It is awesome! :)

Mayby @TheHX demo put in godot-demo-projects ?

@TheHX Do you know how to tell this action to trigger only when the cursor is over a specific node?
Right now the files get loaded when I drag them anywhere on the app window - but I want them to load only when dragged onto a specific node!

I'm not sure if there's any way to do this, without using some crazy tricks. But this id be a nice improvement for the drag and drop, but i don't know how this should be exposed.

@TheHx What does the 'screen' (string) value do? I noticed that it always returns a zero.

I'm not sure, but i think the screen parameter is index of the from where the files are dragged, but as it seems the feature is not implemented:
https://github.com/godotengine/godot/blob/master/platform/windows/os_windows.cpp#L767
https://github.com/godotengine/godot/blob/master/platform/x11/os_x11.cpp#L1531
https://github.com/godotengine/godot/blob/master/platform/osx/os_osx.mm#L330

@TheHX  perhaps it would be useful if all gui related nodes get a _drop_files signal

I don't think so, actually the D&D system in Godot is based on virtual functions, as you can see in this script.

I tried doing it with focus_enter and focus_exit signals and a variable. Didnt work. Focus enter signal requires the user to click on the node - which doesnt work with drag and drop.
Can you come up with any workarounds?
We might have to reopen this bug - because drag and drop does not seem to be properly exposed to gdscript at the moment.

@vnen can you reopen the bug? I shouldnt have closed it so early. Drag and drop is missing a very key element at the moment

@blurymind it's better if you open a new issue with a proper request.


Akka-http

motivation :
How to built simple but powerful rest API and system integration interface with akka-http

what's akka-http ,and how it is related with spray
the server side API
the client side API
integrate with actors
reactive file piping

@Hawstein would you take care of this?

No problem


Count gists

This should count the additions to gists (or, if that's not possible, just the line count)

You've finished this

Thanks


Changed Discord link to permalink invite to channel

The Discord link has been changed to a permalink invite to the server but land direct into the gaussian splatting channel.
When clicked, whether you have joined the server or not, you will see:

Fixes: https://github.com/playcanvas/supersplat/issues/202

It looks like a scary url, but I trust you!! Thanks @yaustar!! <3

Oh, it used .gg as the TLD. It's the one I copied from Discord 😅 so it should be fine!


MemPass::Type2Undef functionality is generally useful and should be factored out somewhere

The ability to find (and create if it doesn't exist) and undef of a given type is useful, and e.g. would be useful in spirv-reduce.
We should consider factoring it out from MemPass::Type2Undef.

Looking at this again I think the functionality is too trivial to warrant refactoring.


New Bank Added (BANCREA)

It's a member of the "Asociación de Bancos de México":

https://www.abm.org.mx/bancos-integrantes/index.htm#

Release v1.3.5


Invoke-CMApplyDriverPackage.ps1 error 1 incorrect function

getting error 1 incorrect function in status message queries
The task sequence execution engine failed executing the action (Apply Drivers) in the group (Driver & BIOS Management) with the error code 1
The operating system reported error 1: Incorrect function.
on the client no log file is written.
has anyone an idea?

When I try to start Invoke-CMApplyDriverPackage.ps1 on CMD in WinPE we receive the error message "No such interface supported" and then Access denied.

Do you have an excerpt of the error occurring in c:\_SMSTaskSequence\Logs\Smstslog\smsts.log?
You should be able to copy it from the task sequence deployment status messages for the device.
Alternatively you can try deploying the Task Sequence in Debug mode to step through and see what's missing or holding it up.

in the c:_SMSTaskSequence\Logs\Smstslog\smsts.log is no error. it ends up with Set MDM variables successfully.
but in the AdminService.log we receive the following error every 10 minutes
IOCompletionCallback
System.ComponentModel.Win32Exception (0x80004005): The specified network name is no longer available

Parameters: -BareMetal -Endpoint "xxx" -TargetOSName "Windows 11" -TargetOSVersion "21H2" -OSVersionFallback
strange is that the BIOS Updates are working


feat: remove support for rome-ignore (#4252)

Summary
Closes https://github.com/biomejs/biome/issues/4256

Test Plan
Removed the tests that were verifying the migration. CI should pass

The PR title should be like remove trailingComma option I think.


brightness: set minimum value to 5%

Set the minimum allowed value for the normal brightness to 5%, in order to avoid having the screen completely off even though the device is on. Standby brightness range is untouched.

The code is adequate, LGTM.


Watchdog seems to work on ha-sip-next, but not on ha-sip

I dont know if this should be reported as a bug, but with running ha-sip-next (slug 8cd50eef-ha-sip-next)
and do a manual call from developer tools/services like this :
service: hassio.addon_stdin
data:
  addon: 8cd50eef_ha-sip-next
  input:
    command: dial
    number: sip:port_01@<IP_ADDRESS>:5060
    ring_timeout: 30
    sip_account: 1

it rings until timeout, but if I manually answer it after a few rings like this :
service: hassio.addon_stdin
data:
  addon: 8cd50eef_ha-sip-next
  input:
    command: answer
    number: sip:port_01@<IP_ADDRESS>:5060
    post_action: hangup

it stops ringing,  but the addon resets itself, the log shows ha-sip-next just started.
Here is the log i catched before it resets the addon :
| 01:32:48.928211 [1] Registering call with id sip:port_01@<IP_ADDRESS>:5060
| 01:32:48.928241 [ ] Add to state: sip:port_01@<IP_ADDRESS>:5060
| 01:32:48.934527 [1] Calling
| 01:32:48.994896 [1] Early
| 01:32:56.160646 [ ] Got "answer" command for sip:port_01@<IP_ADDRESS>:5060
| 01:32:56.160741 [1] Trigger answer of call (if not established already)
| 01:32:56.160763 [1] Call will be answered now.
01:32:56.160               call.cpp  pjsua_call_answer2(id, param.p_opt, prm.statusCode, param.p_reason, param.p_msg_data) error: Invalid operation (PJ_EINVALIDOP) (status=70013) [../src/pjsua2/call.cpp:723]
Traceback (most recent call last):
  File "/ha-sip/main.py", line 113, in <module>
    main()
  File "/ha-sip/main.py", line 108, in main
    c.handle_events()
  File "/ha-sip/call.py", line 149, in handle_events
    self.answer(call_prm)
  File "/root/.local/lib/python3.11/site-packages/pjsua2-2.14-py3.11-linux-x86_64.egg/pjsua2.py", line 5848, in answer
    return _pjsua2.Call_answer(self, prm)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pjsua2.Error
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped

I was trying to stop a ringing phone, as with the current bridging I do between two analog phones, if calling a phone and then just hang up, the target phone will just keep ringing until timeout...I wanted to stop the ringing, and that do happen now.
I trigger the 'answer' command in the 'call_disconnected:' webhook
Very happy how things work now, but maybe there is a bug going on here since the addon restarts itself...

I think I might found a workaround....as after a crash, sometimes its restarting and sometimes not...
so I found that every addon have a binary sensor to tell if its running or not. It needs to be enabled manually
In Settings -> Devices & Services -> Devices (tab) ..search 'ha-sip' or ha-sip-next and click on it
Under sensors there are +5 entities not shown, enable binary_sensor.ha_sip_running or binary_sensor.ha_sip_next_running
Now I can have an automation, that triggers on {{ states('binary_sensor.ha_sip_next_running') == 'off' }}
and executes
service: hassio.addon_restart
data:
  addon: 8cd50eef_ha-sip-next

Nice workaround! I really wonder what's going on here, because both versions are exactly the same, except the name. And if this sensor is able to identify a not working ha-sip, why doesn't the watchdog restart the add-on? I see nothing I can do here, except hoping that pjsip gets more stable or I find a bug in my code.


Allow authority nodes to sumbit inherents to the pool.

CC @nczhu

@tomusdrw build failing, is this still a draft?

It's ready. After all it wasn't required for UTXO chain, but might be worth to keep anyway.

ok - we do definitely need a means of allowing modules to be able to validate unsigned extrinsics.

and regarding terminology, it makes sense to define two groupings of Unsigned Extrinsics:

Inherents: those that the author is putting in as opinion and which other authorities must agree with (e.g. timestamp::set).
UnsignedTransactions: those which can be identified as valid in and of itself, similar to normal, signed, transactions, except that there's some other way - interior to the extrinsic - that proves it.

Essentially, the difference between these two is that the latter group can be distributed over the network and can checked by running in validate_transaction.

Isn't this something that can be determined via the transaction APIs for runtime? I don't see why we would need to make a distinction at the substrate level.

I'm just making a distinction in terms of language and usage. Nothing formal.

There are already three important instances where we would want to distribute Unsigned Extrinsics around the network:

UTXO txs in a UTXO chain
Authority "I_AM_ONLINE" reporting
Polkadot DOT-claims

They each include one or more signed statements using signing crypto that isn't typical substrate account signing. They all need to be gossiped and can all be reasonably checked as being valid in the same way as normal Transactions.

Yup, the naming was the main source of confusion here. In the last commit I've also added ensure_unsigned alias method which can be used in contexts where unsigned transactions are expected to avoid calling them "inherent".

cool - how far off are we from allowing nodes to fully handle unsigned transactions from RPC through pool into the chain?

@gavofyork If I understand the question correctly it's all supported right now without any changes required. What's required from the runtime implementation is correct implementation of validate_transaction that returns TransactionValidity::Valid even though the signatures are not there (that's what @0x7CFE is doing for the UTXO chain).
The pool doesn't have a notion of sender/signature at all, just works on the TransactionValidity.

ok - it would be good to be able to declare validate_transaction per module.

@thiolliere we talked about this, right?

@tomusdrw so what's the point of having an Inherents pool? wouldn't a pool only be useful for Unsigned Transactions?

So the way I understand this correctly is, that substrate extrinsics can be split into:

Inherent - unsigned stuff included in block by block producers (not propagated over the network)
Transaction - stuff that goes through validate_transaction and ends up in the pool and is propagated over the network
2.1. Signed transactions - transactions using substrate crypto, have a sender
2.2. Unsigned transactions - everything else; validity has to be enforced by the runtime somehow

Inherent extrinsics are also coming from modules (via ProvideInherentData or sth like that) and are validated by proper modules as part of the block execution. Transactions are executed via Executive and dispatch calls to modules. By default inherents are constructed when we start creating new block (we call into runtime to produce a set of inherent data).
InherentPool is needed for inherents created asynchronously either via Offchain Workers or (in case of this PR) via RPC / UI. They are just added to the next block right after InherentData and before Transactions.

ok - it would be good to be able to declare validate_transaction per module.

Currently we have valdate_transaction being impleemnted in the Executive, we could collect some additional checks from modules if we figure out that the transaction is going to be dispatched to one of them. That seems beyond scope of this PR though.

InherentPool is needed for inherents created asynchronously either via Offchain Workers or (in case of this PR) via RPC / UI

I don't see why inherents would ever be generated via offchain workers or RPC/UI. They would all just be unsigned transactions (though those generated through offchain workers would probably not be published on the network).

That seems beyond scope of this PR though.

Sure.

I don't see why inherents would ever be generated via offchain workers or RPC/UI. They would all just be unsigned transactions (though those generated through offchain workers would probably not be published on the network).

It seems way more complicated to:

Have them be unsigned transactions that pass validate_transaction function in the runtime
Alter transaction pool logic to support transactions that are ok to be propagated and some that are not (who would actually decide that? It would need to be part of TransactionValidity)

While I agree that submiting inherents through RPC might not be useful in general, offchain workers however will probably use it quite frequently.
IMHO if we don't want to include this PR let's rename the RPC method to author_submitTransaction, to avoid confusion cause it can't handle arbitrary extrinsics correctly currently.

So the thing is that inherents always fulfil two properties:

They're constructed by the block author.
They're agreed as valid by the majority of other authorities.

For RPC submission and off-chain workers, it's not necessarily going to be the block author. Indeed for block workers, I'd very much hope that it's used by all sorts of actors beyond block authors.

Have them be unsigned transactions that pass validate_transaction function in the runtime
Alter transaction pool logic to support transactions that are ok to be propagated and some that are not (who would actually decide that? It would need to be part of TransactionValidity)

This can be safely skipped in cases where we're confident that it will do something useful. Worst case is that the transaction panics when it's inserted into the block which would only be a DoS vector if we accept arbitrary such transactions from public sources. This is not be the case here, at least for offchain-workers.

Actually, I think we can get away with saying all Transactions, even Unsigned, should be published. So that leaves only two kinds of unsigned extrinsics:

Inherents, generated synchronously as part of block production as a means of oraclising author opinions on-chain. Only available to current block author and must be agreed upon by all other block authors.
Unsigned Transactions, sourced from either RPC submit_transaction, gossiped from peers or through internal APIs. Non-opinionated and intrinsically valuable, passes validate_transaction (though not necessarily verified, depending on source). E.g. Polkadot's DOT claim transactions, online attestations.

Closing this in favour of a different PR that will remove the InherentsPool and introduce a do-not-propagate flag for some unsigned extrinsics in the transaction pool.


AssertionError in DeepSpeed During Parameter Management: assert not param.ds_active_sub_modules

When training 72b model, actor model is deploy in two nodes, and it will raise this error. could help solve it?
sceipts:
ray job submit --address="http://<IP_ADDRESS>:8265"
--runtime-env-json='{"working_dir": "/workdir/openrlhf"}'
-- python3 -m openrlhf.cli.train_ppo_ray
--ref_num_nodes 1
--ref_num_gpus_per_node 4
--reward_num_nodes 1
--reward_num_gpus_per_node 1
--actor_num_nodes 2
--actor_num_gpus_per_node 8
--vllm_num_engines 1
--vllm_tensor_parallel_size 4
--pretrain /workdir/Qwen2___5-72B-Instruct
--reward_pretrain /workdir/qwen2_5-14b-instruct-rm-offload
--save_path /workdir/qwen2_5-72b-reinforce
--micro_train_batch_size 1
--train_batch_size 240
--micro_rollout_batch_size 1
--rollout_batch_size 256
--n_samples_per_prompt 1
--max_epochs 1
--prompt_max_len 1024
--max_samples 100000
--generate_max_len 512
--advantage_estimator reinforce
--zero_stage 3
--bf16
--actor_learning_rate 5e-7
--init_kl_coef 0.01
--prompt_data /workdir/ulu_ppo_demo_10k.json
--input_key input
--apply_chat_template
--normalize_reward
--adam_offload
--gradient_checkpointing
--save_steps 100
--use_tensorboard  /workdir/tensorboard
--ckpt_path /workdir/qwen2_5-72b-reinforce/checkpoints_reinforce_ray
--remote_rm_url "http://localhost:5000/get_reward"
--vllm_sync_backend gloo
error messages:
(ActorModelRayActor pid=5986)
Train epoch [1/1]:  94%|█████████▍| 15/16 [05:08<00:35, 35.35s/it, pg=0, rm=1, ret=1, glen=264, tlen=497, kl=0, act_lr=2.5e-7]
(ActorModelRayActor pid=5986)
Train epoch [1/1]: 100%|██████████| 16/16 [05:08<00:00, 27.87s/it, pg=0, rm=1, ret=1, glen=264, tlen=497, kl=0, act_lr=2.5e-7]
Train epoch [1/1]: 100%|██████████| 16/16 [05:08<00:00, 19.28s/it, pg=0, rm=1, ret=1, glen=264, tlen=497, kl=0, act_lr=2.5e-7]
Traceback (most recent call last):
File "/usr/local/lib/python3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/local/lib/python3.10/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/workdir/openrlhf/cli/train_ppo_ray.py", line 417, in
train(args)
File "/workdir/openrlhf/cli/train_ppo_ray.py", line 171, in train
ray.get(refs)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/ray/_private/auto_init_hook.py", line 21, in auto_init_wrapper
return fn(*args, **kwargs)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/ray/_private/client_mode_hook.py", line 103, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/ray/_private/worker.py", line 2623, in get
values, debugger_breakpoint = worker.get_objects(object_refs, timeout=timeout)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/ray/_private/worker.py", line 861, in get_objects
raise value.as_instanceof_cause()
ray.exceptions.RayTaskError(AssertionError): ray::ActorModelRayActor.fit() (pid=6091, ip=psx2gtw6xqsya8hrc-worker-0.psx2gtw6xqsya8hrc.hadoop-djst.svc.cluster.local, actor_id=417ab9388fbcd87e1ebfa56602000000, repr=<openrlhf.trainer.ray.ppo_actor.ActorModelRayActor object at 0x7f5c33d51750>)
File "/workdir/openrlhf/trainer/ray/ppo_actor.py", line 392, in fit
trainer.fit(
File "/workdir/openrlhf/trainer/ppo_trainer.py", line 237, in fit
status = self.ppo_train(steps)
File "/workdir/openrlhf/trainer/ray/ppo_actor.py", line 123, in ppo_train
self._broadcast_to_vllm()
File "/workdir/openrlhf/trainer/ray/ppo_actor.py", line 154, in _broadcast_to_vllm
with deepspeed.zero.GatheredParameters([param], enabled=self.strategy.args.zero_stage == 3):
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 2230, in exit
self.params[0].partition(param_list=self.params, has_been_updated=False)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1375, in partition
self._partition(param_list, has_been_updated=has_been_updated)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1524, in _partition
self._partition_param(param, has_been_updated=has_been_updated)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 18, in wrapped_fn
ret_val = func(*args, **kwargs)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1557, in _partition_param
free_param(param)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 18, in wrapped_fn
ret_val = func(*args, **kwargs)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 281, in free_param
assert not param.ds_active_sub_modules, param.ds_summary()
AssertionError: {'id': 0, 'status': 'AVAILABLE', 'numel':<PHONE_NUMBER>, 'ds_numel':<PHONE_NUMBER>, 'shape': (152064, 8192), 'ds_shape': (152064, 8192), 'requires_grad': True, 'grad_shape': None, 'persist': False, 'active_sub_modules': {2}, 'ds_tensor.shape': torch.Size([77856768])}
(LLMRayActor pid=4164, ip=<IP_ADDRESS>) update weight: model.embed_tokens.weight, dtype: torch.bfloat16, shape: torch.Size([152064, 8192])
2024-12-26 18:38:00,035	ERR cli.py:68 -- ---------------------------------------
2024-12-26 18:38:00,035	ERR cli.py:69 -- Job 'raysubmit_V62nQ4CamVE3GSpi' failed
2024-12-26 18:38:00,035	ERR cli.py:70 -- ---------------------------------------
2024-12-26 18:38:00,035	INFO cli.py:83 -- Status message: Job entrypoint command failed with exit code 1, last available logs (truncated to 20,000 chars):
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 18, in wrapped_fn
ret_val = func(*args, **kwargs)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 1557, in _partition_param
free_param(param)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 18, in wrapped_fn
ret_val = func(*args, **kwargs)
File "/usr/local/lib/python3.10/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 281, in free_param
assert not param.ds_active_sub_modules, param.ds_summary()
AssertionError: {'id': 0, 'status': 'AVAILABLE', 'numel':<PHONE_NUMBER>, 'ds_numel':<PHONE_NUMBER>, 'shape': (152064, 8192), 'ds_shape': (152064, 8192), 'requires_grad': True, 'grad_shape': None, 'persist': False, 'active_sub_modules': {2}, 'ds_tensor.shape': torch.Size([77856768])}
(LLMRayActor pid=4164, ip=<IP_ADDRESS>) update weight: model.embed_tokens.weight, dtype: torch.bfloat16, shape: torch.Size([152064, 8192])

could you try other deepspeed versions?

could you try other deepspeed versions?

let me try other deepspeed versions.  By the way, can it be caused by the setting of train_batch_size ?
I remember that  it will raise error : "AssertionError: Check batch related parameters. train_batch_size is not equal to micro_batch_per_gpu * gradient_acc_step * world_size 256 != 1 * 85 * 3", if set the train_batch_size to 256.
In the DeepspeedStrategy init() function, the world_size may be 3 (3 nodes) ? Then the gradient_acc_step = 85 = 256 * 1 // 1 // 3.

train_batch_size % actor_size % micro_batch_size should == 0

train_batch_size % actor_size % micro_batch_size should == 0

Thx 👍, it works.
I also have another feedback. It seems that the "accumulated_gradient" is not correctly calculated in deepseed.py, If train using multiple nodes and the number of nodes are not power of 2 (eg. 3),  since it seems the the world_size will be 3, the accumulated_gradient would not be power of 2.
https://github.com/OpenRLHF/OpenRLHF/blob/main/openrlhf/utils/deepspeed/deepspeed.py#L86
When forcefully setting batch_size=256, accumulated_gradient to 16 allows it to run normally.

train_batch_size % actor_size % micro_batch_size should == 0

Thx 👍, it works. I also have another feedback. It seems that the "accumulated_gradient" is not correctly calculated in deepseed.py, If train using multiple nodes and the number of nodes are not power of 2 (eg. 3), since it seems the the world_size will be 3, the accumulated_gradient would not be power of 2. https://github.com/OpenRLHF/OpenRLHF/blob/main/openrlhf/utils/deepspeed/deepspeed.py#L86
When forcefully setting batch_size=256, accumulated_gradient to 16 allows it to run normally.

so no  need to change deepspeed versions?

train_batch_size % actor_size % micro_batch_size should == 0

Thx 👍, it works. I also have another feedback. It seems that the "accumulated_gradient" is not correctly calculated in deepseed.py, If train using multiple nodes and the number of nodes are not power of 2 (eg. 3), since it seems the the world_size will be 3, the accumulated_gradient would not be power of 2. https://github.com/OpenRLHF/OpenRLHF/blob/main/openrlhf/utils/deepspeed/deepspeed.py#L86
When forcefully setting batch_size=256, accumulated_gradient to 16 allows it to run normally.

so no need to change deepspeed versions?

yes.


Data Table

Related to #199
Introduce styling for basic features including:

table rows
check boxes
select and multi-select
column sorting
expansion
what’s in the mockup

Note: Toolbar, Filtering and Pagination is out of scope for this issue.
Visuals are here: https://drive.google.com/file/d/18bkHlqe-WbytkwOgopJG8G5TOiFPSVS2/view

Closed by #749


RNN gemm operations with leading dimension zero

Environment
v1.0 compiled either with: (i) jit defaults, (ii) USE_CBLAS or (iii) forced to use ref_gemm
Steps to reproduce

Either let Intel MKL spew ERROR messages via USE_CBLAS,
or put add printfs in extended_sgemm and verify that rnn tests and examples often call extended_sgemm with matrix leading dimension lda==0.

Actual behavior

rnn tests and examples call extended_sgemm with leading dimension lda==0
tests and examples still pass.
Often happens right after a previous extended_sgemm call with identical dimensions for all other M,N,K,ldb,ldc dimensions

Expected behavior
Intel MKL's cblas_sgemm should not spew out ERROR messages with USE_CBLAS.
Are such calls be no-ops? Can these calls be avoided?
Sample outputs in #415.

Hi @kruus ,
First, a note on lda==0. This is expected. The extended_sgemm function supports packed layout for both matrices A and B. In those cases, the leading dimension is irrelevant as metadata with the physical layout of the packed matrix is part of the buffer containing the packed matrix itself.
Regarding the CBLAS use case, you are right, this is a bug, we should have a check to not call the cblas function if one of the matrix is packed. Could you try the patch below and tell me if it solves your issue?
diff --git a/src/cpu/gemm/gemm.cpp b/src/cpu/gemm/gemm.cpp
index 95f4228..ff10e79 100644
--- a/src/cpu/gemm/gemm.cpp
+++ b/src/cpu/gemm/gemm.cpp
@@ -110,7 +110,9 @@ mkldnn_status_t extended_sgemm(const char *transa, const char *transb,
         return status;

 #ifdef USE_CBLAS
-    if (!force_jit_nocopy_gemm) {
+    auto packed_A = *transa == 'p' || *transa == 'P';
+    auto packed_B = *transb == 'p' || *transb == 'P';
+    if (!(force_jit_nocopy_gemm || packed_A || packed_B)) {
         bool trA = *transa == 't' || *transa == 'T';
         bool trB = *transb == 't' || *transb == 'T';
         CBLAS_TRANSPOSE Cblas_trA = trA ? CblasTrans : CblasNoTrans;

tested with USE_CBLAS (and no sse, but this is irrelevant to this issue).
No warnings noted this time, so I think this lda==0 issue functions-as-expected (fixed)
Some test errors, but that concerns #515.


Change slide key from number to string

Prevents warning -> "Warning: Failed child context type: Invalid child context virtualizedCell.cellKey of type number supplied to CellRenderer, expected string. "  from Flatlist data attribute.
Avoids the warning for people copying code from the readme :)

Further discussion here: https://github.com/facebook/react-native/issues/18291

Could you update the examples as well?

None of the examples use a number as a key prop - they use the key extractor function to get the item title, so they should be fine.

Ah of course.


github: github integration

Taken from https://github.com/zenodo/rdm-project/issues/10

Users connect their GitHub accounts via OAuth

User and organization repositories list fetched to populate GitHub settings page; synchronized every 24h or on demand
Webhooks created on repository enabling
On a new (pre)release publish:

Event payload received on Zenodo
Metadata fetched for the release

From basic information (release title, version tag, authors, links)
From metadata files like .zenodo.json and CITATION.cff

ZIP ball file of the release downloaded
New version record is published with metadata and ZIP ball file

Release history tracked in GitHub settings for each repository
Release errors retried and tracked
Still possible to create "manual" versions, or have drafts in progress that don't interrupt the workflow
GitHub DOI badge always pointing to the latest DOI/version
GitHub Settings UI pages (repositories list and repository releases) contain some interactive elements currently implemented with jQuery

Toggle button for enabling/disabling integration for repositories
"Sync now..." button, triggering repositories fetch from the GitHub API

Prerequisites

All metadata fields have to be part of the record/deposit schema (since they can be included in .zenodo.json files)

Next steps

Webhooks module review and integration + GPL -> MIT
GitHub module review and integration + GPL -> MIT
a. Fully working backend and programmatic API
b. Metadata extraction and mapping (translation of .zenodo.json, and updated CITATION.cff mapping) to InvenioRDM datamodel
c. Integrate publishing step with the RDMRecord service
Migration (and possible rewrite) of interactive UI parts into React

Nice to haves:

Admin  for new admin interface
REST API to support new admin interface + permissions

Current

CITATION.cff generation

Future

Sub-Tasks

[ ] Update invenio-webhook backend
[ ] Refactor invenio-github backend
[ ] Refactor invenio-github UI

Closing this issue since the feature was already migrated to RDM.
Still is missing docs, but that is being tracked separately as part of the v12 release


Add Instituto Code - https://institutocode.org

Non-profit institute - InstitutoCode

@rony-novaes First stage of verification passed, official domain is institutocode.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@rony-novaes Regrettably, this request has signs of fraud. I have to close it without merging.
It does not mean that something is wrong with the school. The issue is related to a combination of suspicious factors related to the domain itself.
Please feel free to apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for your understanding!


Add teammate participation

Allows teammate participation to be added to other projects

Codecov Report

Merging #253 into master will decrease coverage by 0.44%.
The diff coverage is 10.71%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e7844...f9c1456. Read the comment docs.


Gas Profiled Rust Integration Tests

Port go integration tests to rust using cosm-orc hitting a local Stargaze node
Replace the drone task with a github action that runs the integration tests and posts the gas usage diff from main in the PR

Having contract integration tests in rust is nice, because we can use the latest native rust contract types directly, instead of having to maintain manual conversions that can stale.
Posting the gas usage diff from main in the PR has helped us catch unwanted gas usage increases and redesign things before merging the PR.
Hitting a real node makes it easy to use the latest and correct chain gas configs and limits.
This is what the Gas Usage diff PR comment looks like:
https://github.com/DA0-DA0/dao-contracts/pull/536#issuecomment-1321281784

Thank you @de-husk. If you can merge in main will get this merged in.

Sorry for the delay, I didnt see the github notifications when this was initially approved.
I rebased main.


Several ManyToMany state null

Hi,
similarly to #388 I have the problem that when a class has several ManyToMany to the same entity, the requery Jackson parses resoles them but the entity state is null. Thus they don't get inserted. Am I doing something wrong? Please find below a very simple example. Lookin at Person after it was deserialised, the states of timelinePictures and profilePictures are null. I used requery version 1.3.2.
String testJson = "{\n" +
    "  \"name\": \"Great name\",\n" +
    "  \"timelinePictures\": [\n" +
    "    {\n" +
    "      \"src\": \"https://static.pexels.com/photos/86462/red-kite-bird-of-prey-milan-raptor-86462.jpeg\"\n" +
    "    }\n" +
    "  ],\n" +
    "  \"profilePictures\": [\n" +
    "    {\n" +
    "      \"src\": \"https://static.pexels.com/photos/145939/pexels-photo-145939.jpeg\"\n" +
    "    }\n" +
    "  ]\n" +
    "}";
DatabaseSource databaseSource = new DatabaseSource(this, Models.DEFAULT, 1);
Configuration configuration = databaseSource.getConfiguration();
EntityDataStore<Persistable> store = new EntityDataStore<>(configuration);

ObjectMapper objectMapper = new EntityMapper(Models.DEFAULT, store);
  try {
      Person person = objectMapper.readValue(testJson, Person.class);
  } catch (IOException e) {
  e.printStackTrace();
  }

Entities
@Entity
@JsonDeserialize(as = PersonEntity.class)
public abstract class Person {
  @Key
  @Generated
  int id;

  String name;

  @ManyToMany
  @JunctionTable(name = "person_picture_timeline")
  List<Picture> timelinePictures;
  @ManyToMany
  @JunctionTable(name = "person_picture_profile")
  List<Picture> profilePictures;
}

@Entity
@JsonDeserialize(as = PictureEntity.class)
public abstract class Picture {
  @Key
  @Generated
  int id;

  String src;
}

Thanks for the test code, will try to reproduce

Thanks for the quick fix, it works well. However, it does not work when using custom setters for the collections above (state will be null again). Adding @JsonIgnore to the setters solves this problem.
Wouldn't it also be a solution to generate setters for generated entities? Internally they could just call the generated getter. Not sure if I should open an issue or if this works intendend @npurushe?


CABF SMIME BR <IP_ADDRESS>.e - KeyUsages

Addressing #754 with separate lints to check presence and criticality of the KU extension as well as covering the allowed KUs for RSA, EC and Edwards curve public keys.
One shortcoming is that for the Edwards curve keys I've had to leave a TODO in place as I don't think zcrypto has support for curve 448 in certificates (correct me if I'm wrong but I couldn't see it when I looked).  That being said, it doesn't stop the checks working adequately for keys defined on curve 25519 so I don't think it should be a blocker for merging this PR.

Can you guys help me understand why I seem to be having an issue testing this and some other changes regarding SMIME lints out?
I have a PEM with Email Protection EKU and I can't get any SMIME lints to trigger when running zlint directly. -lint-sources-list doesn't show SMIME and the lints aren't ever added to the registry that I can tell. Is there some other pieces missing that we need for running the CLI or as a library?

@cardonator do you have a particular branch I can take a look at?

I am working on this branch. https://github.com/zmap/zlint/compare/master...cardonator:zlint:check_aia_internal_names
I will email you a pem I'm testing with, I haven't generated a cert to test with yet.

@cardonator
Ah, so the cert that you sent me is fine, and it indeed passes the "is this an email cert" check, however there seems to be a regression with regard to cert-to-source-document dispatch that broke smime from the CLI.
$ ./zlint -list-lints-source
    Apple
    CABF_BR
    CABF_BR
    CABF_EV
    Community
    ETSI_ESI
    Mozilla
    RFC3279
    RFC5280
    RFC5280
    RFC5480
    RFC5891
    RFC8813

Listing CABF twice with no SMIME version is incorrect and smime lints are not showing up in the registry on master. I've fired up #759 for me to go fix this.
In the meantime, you are fine to continue writing-and-testing lints as this is an issue in the CLI.

Thanks @christopher-henderson and sorry to hijack this thread. I will continue on my branch.


render elastic graphs

Rendering engines

https://github.com/OpenKieler/elkjs
https://github.com/dagrejs/dagre

fixed in 7f185f589bc1853ca8c5f152b5708ee272bf36a7


Return correct error when creating a bucket with empty CreateBucketConfiguration

Problem

See problem described in #2210.
One of the other S3 tests (test_streaming_upload_from_file_to_presigned_url) is failing on my machine due to the lack of a region. See #3080 for more information.
Some of the contributor documentation is a little sparse for newbies.

Changes
This PR:

updates the contributor documentation
fixes the failing S3 test by providing a region
adds a test for empty CreateBucketConfiguration
returns the correct exception when presented with an empty CreateBucketConfiguration

Notes

🙏  This is my first PR against this codebase, please be gentle!
ℹ   I'm using this as practice because I want to implement Application Autoscaling (#1931).
❓ I'm not sure why test_streaming_upload_from_file_to_presigned_url is failing, it was passing yesterday.

Fixes #2210, fixes #3080

Coverage increased (+0.002%) to 94.393% when pulling f78239f40fb252baa26f2f3bd4e6c129f00108c3 on dawngerpony:fix/2210-s3-empty-createbucketconfiguration into 6305f707d28d11000fda0336fe628a3d4743f4ba on spulec:master.

Let me know if you need any  help with the Application Autoscaling btw.
If you want an idea on how to get started with a completely new service, have a look at this PR: #2957 . It's a very clean implementation of the another new service (Managed Blockchain) that was introduced recently, and should be a good starting point.

Thank you for the lovely welcome, @bblommers - I'm glad my PR looked good to you! 😄 Also thank you for the link to the PR, I'll use it as a template when mocking Application Auto Scaling.

Welcome to the team!


Consistent freeze when using .MultiThreaded (and sometimes crash) on world.Progress()

After few cycles the world.Progress() just never returns, probably waiting on some lock. I had crashes before with multithreaded as well, but now its just freeze. Only 2 multithreaded systems are these 2:
    public static void Move(World world)
    {
        world
            .System<Velocity, Position>("Move")
            .MultiThreaded()
            .Each(
                (Iter it, int i, ref Velocity v, ref Position p) =>
                {
                    p.X += it.DeltaTime() * v.X;
                    p.Y += it.DeltaTime() * v.Y;
                }
            );
    }

    public static void RandomDestination(World world, Random random)
    {
        world
            .System<Position, Destination, Velocity>("RandomDestination")
            .Without<GridPath>()
            .MultiThreaded()
            .Each(
                (ref Position p, ref Destination d, ref Velocity v) =>
                {
                    v.X = 0;
                    v.Y = 0;
                    d.X = p.X + random.Next(-100, 100);
                    d.Y = p.Y + random.Next(-100, 100);
                }
            );
    }

When i Remove .MultiThreaded on both the freeze stops. My world has 2 threads set:
        world.SetThreads(2);

The more entities I have the faster the lockup happens.
My loop mostly looks like this:
        using var world = World.Create();
        world.SetThreads(2);

        // Do i need this? Apparently cant register components in multi treaded
        world.Component<Position>();
        world.Component<Map>();
        world.Component<Layer>();
        world.Component<Translate>();
        world.Component<Scale>();
        world.Component<Velocity>();
        world.Component<Source>();
        world.Component<Texture>();
        world.Component<Light>();
        world.Component<Occluder>();
        world.Component<Collider>();
        world.Component<GridPath>();
        world.Component<Destination>();
        world.Component<Camera>();
        world.Component<Tint>();

#if DEBUG
        world.Import<Ecs.Units>();
        world.Import<Ecs.Stats>();
        world.Set(default(flecs.EcsRest));
#endif

        // Some other stuff...

        // Flecs Systems register
        Systems.UpdateCamera(world, renderer);
        Systems.DisableEntities(world, grid);
        Systems.RandomDestination(world, random);
        Systems.FindPaths(world, grid);
        Systems.FollowPaths(world, grid);
        Systems.Move(world);
        Systems.ProcessOccluders(world, renderer);
        Systems.ProcessColliders(world, grid);
        var drawTextures = Systems.DrawTextures(world, renderer);
        var drawLights = Systems.DrawLights(world, renderer);
        var drawPaths = Systems.DrawPaths(world, grid);
        var drawGrids = Systems.DrawGrid(world, grid);

        // Do stuff
        while (!Raylib.WindowShouldClose())
        {
            var delta = Raylib.GetFrameTime();
            Console.WriteLine("Before progress");
            world.Progress(delta);
            Console.WriteLine("After progress");

            // Manually calling textures and light systems later and some other rendering stuff
        }

* thread #1, name = 'Game', stop reason = signal SIGSEGV: address not mapped to object
  * frame #0: 0x00007c8e6c7d308b libcoreclr.so`___lldb_unnamed_symbol15044 + 27
    frame #1: 0x00007c8e6c7e761f libcoreclr.so`___lldb_unnamed_symbol15373 + 255
    frame #2: 0x00007c8e6c7e6bf5 libcoreclr.so`___lldb_unnamed_symbol15363 + 469
    frame #3: 0x00007c8e6cb5d1d0 libc.so.6`___lldb_unnamed_symbol3369 + 1
    frame #4: 0x00007c8e6c542caf libcoreclr.so`___lldb_unnamed_symbol6240 + 47
    frame #5: 0x00007c8def5d7024
    frame #6: 0x00007c8def5d6fd2
    frame #7: 0x00007c8def5f5b8d
    frame #8: 0x00007c8def5f5b1d
    frame #9: 0x00007c8e6b77cfa9 libflecs.so`flecs_run_intern(world=0x00005871f50fcb20, stage=0x00005871f5503800, system=104725, system_data=0x00005871f661f190, stage_index=3, stage_count=32, delta_time=0.299937189, param=0x0000000000000000) at flecs.c:63450:21
    frame #10: 0x00007c8e6b77cabf libflecs.so`flecs_run_pipeline_ops(world=0x00005871f50fcb20, stage=0x00005871f5503800, stage_index=3, stage_count=32, delta_time=0.299937189) at flecs.c:52930:9
    frame #11: 0x00007c8e6b77ec1a libflecs.so`flecs_worker(arg=0x00005871f5503800) at flecs.c:53360:9
    frame #12: 0x00007c8e6cbb439d libc.so.6`___lldb_unnamed_symbol3666 + 941
    frame #13: 0x00007c8e6cc3949c libc.so.6`___lldb_unnamed_symbol4097 + 7

managed to get some stacktrace i think.
Currently was testing on this:
        world
            .System<Position>("CullEntities")
            .Kind(Ecs.PostLoad)
            .MultiThreaded()
            .Rate(2)
            .TermAt(0)
            .In()
            .With(Ecs.Disabled)
            .Optional()
            .InOut()
            .With<Camera>()
            .Singleton()
            .In()
            .Each(CullEntities);

The body of cullentities is empty:
    private static void CullEntities(ref Position position)
    {
        Logger.Debug("CullEntities");

        // var camera = it.World().Get<Camera>();
        // var (left, top, right, bottom) = camera.GetBounds(CameraOffset);
        //
        // foreach (int i in it)
        // {
        //     var pos = positions[i];
        //     var entity = it.Entity(i);
        //     if (pos.X < left || pos.X > right || pos.Y < top || pos.Y > bottom)
        //     {
        //         entity.Disable();
        //     }
        //     else
        //     {
        //         entity.Enable();
        //     }
        // }
    }

I feel it could be related to this issue that I'm currently working on https://github.com/BeanCheeseBurrito/Flecs.NET/issues/50.

I feel it could be related to this issue that I'm currently working on #50.

Small update. I was able to reproduce it on my end and it looks like the changes on the binding-context-fix branch fixed the crashes with multithreaded systems. I believe https://github.com/BeanCheeseBurrito/Flecs.NET/issues/49 and https://github.com/BeanCheeseBurrito/Flecs.NET/issues/45 are also fixed by these changes.

I feel it could be related to this issue that I'm currently working on #50.

Small update. I was able to reproduce it on my end and it looks like the changes on the binding-context-fix branch fixed the crashes with multithreaded systems. I believe #49 and #45 are also fixed by these changes.

Oh awesome, will try that branch and report back

Ok tried bunch of stuff and on your branch I cant reproduce #48, #45 or #49 anymore, amazing.

Fixed by #54, closing


citra: refactor & update

Motivation for this change
This was mainly written by @JoshuaFern, they asked me to continue their PR (#152936) as they don't have access to a linux machine right now. Review happened there as well.
I've adressed CR comments, and made some small formatting changes.
The only thing broken right now is the title bar, and the about section. They currently don't display version information, though that's not a regression. I think it should be fine for now.
cc @SuperSandro2000 you reviewed the previous PR as well.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Please fix the conflicts.

My apologies, I completely forgot about this one. A friend of mine opened up an updated pull request implementing similar features: https://github.com/NixOS/nixpkgs/pull/173433


Node-fetch functionality

Hi, I'm a complete newbie here, so not sure if this is possible, but:
I am using this with node-fetch, otherwise the calls to "fetch" are undefined.  So I am just adding
const fetch = require('node-fetch');
to both fetchJSON.js and configureRefreshFetch,js
Is it possible to develop something where you somehow inject the fetch client?   I know that fetch-cookie does it with something like the following:
module.exports = function fetchCookieDecorator (fetch, jar, ignoreError = true) {   fetch = fetch || window.fetch
and then you just inject it when requiring fetch-cookie:
var nodefetch = require('node-fetch')   const tough = require('tough-cookie')   let personalJar =  new tough.CookieJar();   const fetch = require('fetch-cookie')(nodefetch, personalJar, false)
Like I say, not sure if possible, but thought I would just ask...

Hey, I see what you mean. fetchJSON function expects global fetch available, but to configureRefreshFetch function you pass the fetch you want to decorate. So you should be able to do it by defining fetch for configureRefreshFetch yourself. Basically when passing the fetch to configureRefreshFetch you should only make sure that the returned promise is rejected on error response.
Something like:
const nodefetch = require('node-fetch');

const fetchRejecting = (url, options) => nodefetch(url, options).then(response => response.ok ? response : Promise.reject(response))

// ... setup according to the readme

Ok, great, thanks.  I'll try that.


Can I remove CAMERA permission?

If I don't need FileType.CAMERA.
Can I remove CAMERA permission?
If my app has CAMERA permission. I need give google play privacy policy url.

I found camera permission is added by image_picker.
I think remove image_picker for FileType.IMAGE and FileType.CAMERA better.
Separate it for difference requirement.

If you don’t need it you don’t have to provide those permissions as well. The image_picker is just re-used here in order to prevent two packages but I get your idea. I’ll take in consideration.

No. I don't give CAMERA permisiion in AndroidManifest.xml
But still appear CAMERA permission in app.
Untill I remove image_picker in my file_picker fork.

https://github.com/flutter/plugins/blob/master/packages/image_picker/android/src/main/AndroidManifest.xml
image_picker will auto add permission.

That’s right, I forgot the grantUriPermissions is set to true on the image_picker.

I'll reopen so others may see this. I would like to have more feedback since I get the point, that it would be fine to have it separated in both plugins, but I can also understand that this is more reliable for some users since they have to only import one plugin and it will handle picking all file types.

Just this

Google play asks me privacy policy

Hum, I see. The privacy policies. This may be useful in the meantime.

OK is a nice sample
https://docs.google.com/document/d/14xHZa1PqxpgntwhStx0dnaiPOV1uDAY0RzQyF5GkPpw/edit
But if some one just need pick document. remove useless permission better.

hi , I have this problem too, I want to remove the camera permission, plz help.

This is a tricky one because the plugin supports picking files from camera so it will always have to have that permission.
One option will be removing this feature entirely and let users use this along with image_picker if needed.

Version 1.3.0 was deployed on dart pub and fixes this, alongside with other requested features and bug fixes. See changelog.
Thank you all for your feedback.


in tags mode, when entering Chinese is always have the english alphabet

in tags & multiple mode, in the chrome browser, when entering Chinese is always have the english alphabet
Test Url
view:

what's the problem ?
How can I fix it ?

Have the same issue

I think it is the same issue with #5267. I am still waiting for updates.


[UI] remove relative import and fix log level

closes https://github.com/intel/llm-on-ray/issues/72, closes https://github.com/intel/llm-on-ray/issues/57

Close this first as I‘ll address https://github.com/intel/llm-on-ray/issues/72 and https://github.com/intel/llm-on-ray/pull/90 in two separate PRs. Thanks @xwu99.


Adding password validation.

I want to add password validation for signup, to consider the password length and strength making sure it contains number, capital letters , special characters to make it more secure.

Thank you for the suggestion! We agree that adding password validation to ensure strong passwords is a great idea for enhancing security. Please go ahead with implementing that.
Additionally, we would also like you to implement a forgot password flow as part of this task ( Backend & frontend ). Could you please confirm if you're working on both? Looking forward to your acknowledgment!

Thank you. I am on it.

I would like to work on this project. Please assign it to me.

any update @Bz14

Hey @Bz14 I can work on this.

@ratnesh-maurya can you assign me.

sure @Koushikkd07

any update @Koushikkd07

i want to work on this issue .assign me this project

@ratnesh-maurya I can work on this issue
please assign me


Default to, or allow configurablity for, blockOwnerDeletion=true

It's typical for controllers to default to blockOwnerDeletion=true so that foreground deletion performs a full cleanup. Currently blockOwnerDeletion is always null when managed by the operator sdk.

This is added using the default method from fabric8, I agree with this issue in general, just should not be a default in fabric8?
https://github.com/java-operator-sdk/java-operator-sdk/blob/19e6dfd8aad25d3623d5fa938fc8d7cf4e663fb5/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java#L241-L241

Will be picked up eventually by https://github.com/fabric8io/kubernetes-client/issues/5838


Integrated Jupyter notebook fails

Bug: Notebook Editor, Interactive Window, Python Editor cells
Steps to cause the bug to occur

create ipynb file wait
enter import sys (anything really)
hit play button

Actual & Expected behavior
Activating Python 2.7.13 32-bit to run Jupyter failed with Error: Command failed: "C:/Program Files/ArcGIS/Pro/bin/Python/envs/py37/Scripts/activate.bat" && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python c:/Users/admin/.vscode/extensions/ms-python.python-2019.10.41019/pythonFiles/printEnvVariables.py The system cannot find the path specified.
Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running:                       Local
Extension version:                               2019.10.41019 (8 October 2019)
VS Code version:                                1.39.1
Setting python.jediEnabled:               true | false
**Python     2.7.13
OS:                                                     Windows10

Version: 1.39.1 (system setup)
Commit: 88f15d17dca836346e787762685a40bb5cce75a8
Date: 2019-10-10T23:31:28.683Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17134
My opinion:
It seems to activate an environment that is different to the one required, in setting bottom left

Can you upload your console log?
Go to 'Help | Toggle Developer Tools,' click on the console tab, right click, save as, and upload here?
This is likely a conda activation problem (possibly related to #3834)

I suspect the same thing.  I did realise I had to have conda.
VSCode_jupyter.log
Unfortunately, this laptop is very locked down :(

Dupe of #5344

So I do have to have conda?
Never indicated to be a prerequisite for VSCode python extension.
Where do I change the command that is done upon running jupyter,  it seems really bad since it is currently calling a different version than the one that is indicated in the bottom left corner of the IDE

Conda is not a prerequisite. In order to run notebooks, having jupyter installed is.
If you have conda it may not work because of how we call it. Conda has suggested we try another way (which is what #5344) is about.
Sorry, but there is no single place where the command line is configured. The algorithm is a little more complicated:

Detect your environment
If conda, start conda and scrape environment variables
Run python with this environment to search for jupyter
If jupyter can be found, start jupyter like so: 'python -m jupyter notebook '
If jupyter cannot be found, try searching through other environments until we can find one that will run jupyter.

The root cause of your problem is that we can't start the right conda environment and scrape its environment. It looks like it's getting stuck just launching it.

Thanks all sorted, nothing wrong with VS Code just Operator


Options interface export

Added export to the Options interface.
The change is needed to support use cases in which wrapper hooks might need to type check parameters passed to useMutation hook.

Released v2.1.0

Released v2.1.0


reqirements installation

add to tutorial https://stackoverflow.com/questions/7225900/how-can-i-install-packages-using-pip-according-to-the-requirements-txt-file-from