Drop override values when present

Joi@17 started adding an override special value on allow/disallow lists (see here), there appears to be no reliable way to detect that value, so I went as far as I could to make sure that's the one and strip it, but there's no guarantee.
Also, the tests don't pass locally based on coverage, but that's not really new.

@Marsup v14.1.1 released.


feat: redirection after variable edition ; commit after rebase master

Which issue(s) this PR fixes

Fixes #141
Additional comments

I had to rename the file to .tsx to add code in the toast.
The style of the toast may (will) be done in another issue.
Agreements

[X] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[X] I hereby agree to grant TOSIT a copyright license to use my contributions.

The toast's style may be improved in a new issue (as requested by @PaulFarault) to better show the link "configure a new deployment" like a button, and to better fit the size of the toast with the content.

#186 has been created (thx @mdrutel) this PR is now ready to be merged


feat: KEDA is supported by Microsoft Azure

KEDA is supported by Microsoft Azure given they sponsor Azure compute.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Relates to https://github.com/kedacore/governance/issues/31

Putting in draft until Azure subscription becomes active.


allow resample_poly() to output float32 for float32 inputs.

Problem: resample_poly() inadvertently upgrades the user-supplied filter to double precision, such that single precision inputs to resample_poly() yield a double precision output.
See #9104.
Solution: Preserve the filter dtype during zeropadding of the filter

Following TDD can you add a test that fails on master (showing the problem) but passes on this PR?


Add test failure cause mapping

Closes #26299

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

ReadyForNightly build

@donat, @hegyibalint added tests for cases that I have.
ps. I cannot resolve my conversations. I haven't rights to it.

@donat, @hegyibalint added tests for cases that I have.
ps. I cannot resolve my conversations. I haven't rights to it.

No problems. Thanks for the feedback!

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge


Suggestion:Can I start a 'sub-tour' in my codetour?

A tour with multiple path will be useful.
By doing this,I can record how program is running.Moreover,I can record my decision tree.

hey
Wouldn't those features combined kind of make a "sub-tour" capability?

linking tours, and making one "primary"
link to another tour, even on specific point

So your primary tour could at some arbitrary points, have "decision tree" through other .tour links.
And if carefully crafted, those could link back
Primary
• 1
• 2

 sub-tour
•  2.1
•  2.2
•  2.3

<
| 3
...

Thanks for reply after so long.
These features really solve my problem.


Expected Behavior

Light/ dark button flickers when menu items are clicked; it switches back and forth to its current state.
Format for the page layouts cause the menu to flicker

Steps to Reproduce

Click any menu item, the dark/light button flickers
Click any menu item the layout of the page jumps instead of a smooth transition

Code Reproduction URL
No response
Additional Information
No response

Hey @technosprout, We have finally addressed the issue. You can check it now. Thanks


[Question]/[Feature ] Supporting multiple users and groups by tenants

Hi!
I add try to add a new user to existing shellhub setup and I'm getting an error on add a new user .
There is a way to manage groups and users by tenants ?
Best Regards

I add try to add a new user to existing shellhub setup and I'm getting an error on add a new user .

Are you using the provided utility (./bin/add-user) to add a new user?

There is a way to manage groups and users by tenants?

The only way to manage users is by using the following utilities:

./bin/add-user
./bin/del-user
./bin/reset-user-password

Hi !
Yes !
use the ./bin/add-user rror on add a new user .
using the TENANT_ID=xxxxxxx ./bin/add-user xxxxxx xxxxxxx<EMAIL_ADDRESS>

Hi !
Yes !
use the ./bin/add-user rror on add a new user .
using the TENANT_ID=xxxxxxx ./bin/add-user xxxxxx xxxxxxx<EMAIL_ADDRESS>
You cannot add multiple users with the same tenant id.

@gustavosbarreto can you add it has feature  ?

Is this something that's on the road map, especially for the cloud version?
Without it the cloud version is pretty much unusable in a production environment.

@RotemEmergi @jakew009 We are working on it. It will be available both in the open-source version and in the Cloud.

@RotemEmergi @jakew009 We are working on it. It will be available both in the open-source version and in the Cloud.

Excellent, we currently use rttys, but we'd rather use Shellhub.
At the moment there is a distinct lack of security features though which makes us hesitant.

Hello @jakew009 @RotemEmergi, the feature will be available in next release. Thanks for your patience.

Hello @jakew009 @RotemEmergi, the feature will be available in next release. Thanks for your patience.


[Refactor] Clarify dependency construction for chat library

Purpose
DependencyContainer.swift contained at type-erased dictionary of objects, primarily used by the main chat class.
The pattern of being able to register() and resolve() objects at run-time is convenient for applications where they will be changed at run-time, but this is not the case with our library.
DependencyContainer.swift provided a means to do a lot of object construction, which is then handed back to the calling class.
This PR provides a clear set of dependencies and maintains type information.
As a result, we have

Reduced complexity in the code
Reduced the number of test cases as checks are enforced at compile-time
Clarified object usage in the code at call sites, enabling further refactoring of dependencies

This PR covers only the Chat library; but there are deeper improvements to be made on the calling library side.
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull request checklist
This PR has considered:

[ ] Color Theming
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] View Data Injection
[ ] Demo App UI/UX update

How to Test
Perform the usual tests; note no breakages
What to Check
No change to functionality.

With the differing structure of chat, is it possible to get rid of the container object here as well?

With the differing structure of chat, is it possible to get rid of the container object here as well?

Thanks, looks good!


remove option to filter for None in some location related filters

some fields don't make sense to filter for none. and some result in queries that return unexpected results
Removed option None from:

Installed at location
Installed in rack
Installed in device
Located at location

fixes #197


GithubUtils.getStagingDeployCashData() returned a deploy blocker issue in list of PRs

Action Performed:

We merged a pull request that had the CP staging label
The action createOrUpdateStagingDeploy failed

It recognized a deploy blocker listed in the current deploy checklist as a pull request. See logs here: https://github.com/Expensify/App/runs/6972270023?check_suite_focus=true
9487 (which is an issue) is listed both in the PRList and the deployBlockers arrays

Backup of the deploy checklist issue's markdown at the time of the error

**Release Version:** `1.1.78-0`
**Compare Changes:** https://github.com/Expensify/App/compare/production...staging

**This release contains changes from the following pull requests:**

- https://github.com/Expensify/App/pull/9031
  - [ ] QA
  - [x] Accessibility

- https://github.com/Expensify/App/pull/9266
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9347
  - [ ] QA
  - [x] Accessibility

- https://github.com/Expensify/App/pull/9401
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9404
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9445
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9460
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9462
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9468
  - [x] QA
  - [x] Accessibility

- https://github.com/Expensify/App/pull/9473
  - [ ] QA
  - [ ] Accessibility

**Internal QA:**
- [x] https://github.com/Expensify/App/pull/9458 - @yuwenmemon @mountiny

**Deploy Blockers:**
- [ ] https://github.com/Expensify/App/issues/9487

**Deployer verifications:**
- [ ] I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.
- [ ] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Expected Result:
https://github.com/Expensify/App/issues/9487 should not have been returned in PRList by GithubUtils.getStagingDeployCashData().
Workaround:
Fix the deploy blocker, restart the deploy action
Platform:
Platform-independent
View all open jobs on GitHub

Note that this is an issue with our Github deploy actions, but I think it should be able to be worked on externally too.

Got a PR up to fix this.


Database passwords with capitals don't work.

Passwords with capital letters for MySQL access aren't properly parsed in the code. The code runs fine when used but MySQL returns a generic acces denied error. It took me quite some time to figure this out sadly as I didn't expect the tool to be the problem. The upside is however that I can confirm this behavior is present on Ubuntu 12.04, 14.04, 16.04 and Debian 8.
If this is intentional a mention in the readme or config file would be appreciated.

If this is intentional a mention in the readme or config file would be appreciated.

Definitely not intended, I'm looking into it.


chore: list Homebrew installation method in README

Signed-off-by: Christopher Rybicki<EMAIL_ADDRESS>

This is...peculiar. I do see those version on brew, but we are not explicitly publishing them.
I'd like to find an explanation to this before we publicize it.

@iliapolo  I believe I found the source - it looks like the Homebrew maintainers have an "autobump" GitHub workflow that includes cdk8s in it. This commit in specific added cdk8s to the list of autobump targets: https://github.com/Homebrew/homebrew-core/commit/ed312b910e8a1620bbfefa50bee2c2635d53157f.


Feat: Add kusion config core functions

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

347 of 430 (80.7%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 73.728%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/config/util.go
31
45
68.89%

pkg/config/operator.go
296
365
81.1%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
7389

Relevant Lines:
10022

💛  - Coveralls

Please use "Rebase and merge"! @liu-hm19


Fix unit test: new morphology test file to fulfil MorphIO change

Context
MorphIO with commit aabd346 is strict about soma types: ASC/H5 are contours, SWC is single point, cylinders or neuromorpho 3 point. One of the test morph files used by our unit tests is not valid after this change because of morphology contour with only a single point.
Scope
New tests/sample_data/morphology/simple.h5 is copied from MorphIO repo MorphIO/tests/data/h5/v1/simple.h5
Testing
Existing tests
Review

[x] PR description is complete
[ ] Coding style (imports, function length, New functions, classes or files) are good
[ ] Unit/Scientific test added
[x] Updated Readme, in-code, developer documentation

What is that morphology used for? Is it instantiated in NEURON? I found that with neurolucida ascii files, that a single point wouldn't create a soma, and I imagine that h5 would do the same?

Yes, the morphology file is loaded by NEURON in the test. I recall the discussion in https://github.com/neuronsimulator/nrn/issues/2602 that a contour is expected by NEURON. So the new morph .h5 file as a contour should be fine, right? As for  the old h5 file with a single point, we didn't see errors perhaps because the fe exception was ignored by python.

I don't know about h5 morph file.  With asc files, we got nan errors from hoc as in BBPP134-1022. As for loading h5 file in python, I would guess the FP errors were ignored in Python and soma was discarded. @pramodk knows more about NEURON.
BTW, with https://github.com/neuronsimulator/nrn/pull/2605, such errors are raised directly.

I guess it depends on how the h5 is loaded; anyways, just something to be aware of.


Sent without errors but not taken

Strange problem:
I wrote small func:
let iosConnection;

function silent (obj, ids) {
  if (! iosConnection) {

    let connectData = {
      cert: APN_CERT_FILENAME,
      key: APN_KEY_FILENAME,
      production: false
    };
    iosConnection = apn.Connection(connectData);

    iosConnection.on("connected", function() {
      l.log("Connected");
    });

    iosConnection.on("transmitted", function(notification, device) {
      l.log("Notification transmitted to:" + device.token.toString("hex"));
    });

    iosConnection.on("transmissionError", function(errCode, notification, device) {
      l.error("Notification caused error: " + errCode + " for device ", device, notification);
      if (errCode === 8) {
        l.log("A error code of 8 indicates that the device token is invalid. This could be for a number of reasons - are you using the correct environment? i.e. Production vs. Sandbox");
      }
    });

    iosConnection.on("timeout", function () {
      l.log("Connection Timeout");
    });

    iosConnection.on("disconnected", function() {
      l.log("Disconnected from APNS");
    });

    iosConnection.on("socketError", l.error.bind(l));
  }

  let message = new apn.notification(obj);
  return iosConnection.pushNotification(message, ids);
}

"Ids" is an array like ['123123', '24234'] of registration keys.
When i call it in a simple form:
'use strict';

var apnlib = require('./index');

apnlib.silent({hhg :true}, ['3453535']);

All sent and received on test phone
But when i start this as part a long lived daemon messages sent (all ok with -debug mode) but not received.

Do you see any different log messages when running daemonised?


Offline import of Jupyter (ms-toolsai.jupyter, v2021.11.1001550889) fails

Environment data

VS Code version: 1.63.2
Jupyter Extension version v2021.11.1001550889
OS: Windows 10 20H2

Expected behaviour
Expected successful install as the following python exentions had no issues:
ms-python.python-2021.12.1559732655.vsix
ms-python.vscode-pylance-2021.12.2.vsix
Actual behaviour
Install fails: "Unable to install extension 'ms-toolsai.jupyter' as it is not compatible with VS Code '1.63.2'."

Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Download extension from https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter

"Import from VSIX" on airgapped VSCode instance
Failure

FWIW - Installing to an online instance of VSCode through the extension marketplace works - same version.
Output for Jupyter in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Jupyter)

XXX

This is a known problem. The marketplace lists ALL versions of the extension but doesn't distinguish between insiders or stable versions of VS code.
Please upvote this issue here:
https://github.com/microsoft/vsmarketplace/issues/43


updating alt text for huddle links

Was in a bit of a rush yesterday.
Another good spot from @clarkie

looks great


New UW schema based on new Sinopia schema

Current UW schema* is based on Sinopia schema v009.

determine current Sinopia schema version conformance and
reproduce UW schema from this new Sinopia schema version or
make changes to existing UW schema reflecting updates in newer Sinopia schema

*For RDA profile, to account for local props needed to facilitate creation of format-specific profiles, etc.

@CECSpecialistI
@alexiskeely
I am still ignorant about what Sinopia schema version should be used to validate before upload to Sinopia nowadays. Do either or you know? Is it the newest (0.2.1)?
The ETD profile I output today validated with v009, and uploaded fine (or so it seemed to me), so maybe this isn't a pressing issue.
But still, it seems like before too long we'll need to 1) revamp the UW schema based on a newer version and 2) change the schema values in our format-specific profiles.

I haven't kept up. Yes, at some point, their changes may require changes in our schema. If we can't figure it out, it will crash down on us -- but it won't be fatal I believe!

ALSO
Add new prop subtype to schema for PTs.

I'm officially making this a TO-DO for myself. Will use Sinopia schema v0.2.1 as base.

Closing issue for now - per @briesenberg07 and @gerontakos discussion a new UW schema to validate UW master RDA profile is currently low priority for LD4P2 work.
NOTE that current UW schema (based on Sinopia schema v0.0.9) is referenced in master RDA profile, so even though it is out-of-date, removing it from this repo, etc., might cause additional problems when editing the profile in oXygen or another environment that checks against referenced profile.


Unable to parse 'minItems', 'maxItems' properties from swagger yaml file

As I used v1.0.22, I found the parser can't analyze 'minItems' and 'maxItems' of array properties.
the structure example show as follow

This should be fixed in the latest version, give it a try.

great, hoping for the new version.
BTW, do you have any plan to support swagger 3.0

Great, hoping for the new version. thanks

@webron

@webron
i use the 1.0.33(the lastversion) parser yaml,but do not find minItems maxItems

Hi @lipengfeigodliness @tingwood, can you please post the spec you're using as text, thanks


Move read_hdf to Blockwise

Superceeds #7284 (since that PR is now quite stale)
Follows same approach as #7415 and #7615 to use Blockwise for Dask-Dataframe's read_hdf.  A slight refactor of the original logic was required.

Thanks @rjzamora! @ian-r-rose could you take a look at this when you get a moment?

Apologies for the delayed response here @rjzamora. Would you mind taking care of the merge conflict here and then we can merge this in

No worries!  Conflict should be resolved.  I will also fix any problems if a fresh ci run turns up any failures.

I'm going to merge this since it's passing CI :)


How about Undo/Revert capability?

I believe that if the activitylog can show exactly how the model looked like before it was updated it should also provide the methods to revert the changes to the previous state.
Any drawbacks you could anticipate in adding such feature?

At the end the method would be pretty simple:
$activity->subject->update($activity->changes['old']);

Some conditions before to do it only for update activities.
Drawbacks I could think about would be:

Problem to restore casted values
"Impossible" data combination because of skipped updates (state machines and so on)

And things like this. Because of this I'm a bit against this feature in the package. The code to implement this is super easy (in this simple way). But I already see the issues like "destroyed model after restore" because of any special app circumstances we can't handle in the package.
I would like to let @freekmurze decide about it.

Not sure if at this point the "cascaded" actions are also logged in such a manner that we could track the changes back to a revertible action. The project I'm having in mind has softDeletes  on all models so the destroy method would not really deleting anything....

With destroyed I meant something like "post has no author but is published" because they were set in different activities.
And executing all activities between now and the point to reset to would be an option but could/would create unexpected results.
So it sounds trivial, and is, for a specific usecase. But as package maintainer an added feature should be usable by all/most of the users. And adding a note to the docs is most times not enough because a lot (of the issues we get) don't read the docs. 😔

I agree that undo is complicated and might corrupt data. But if you know what you're doing, undoing specific Activity is useful. Many people ignore the docs, so it's risky to include it in to the package, but if someone searches for an example - here's my code with simple checks:
class Activity extends \Spatie\Activitylog\Models\Activity
{
    public function undo(Bool $unchangedOnly = true, Bool $deleteCreated = true)
    {
        $subject = $this->subject;
        if ($subject !== null) {
            if ($this->description == 'updated') {
                foreach ($this->properties['old'] as $field => $data) {
                    if ($unchangedOnly && $subject->$field != $this->properties['attributes'][$field]) {
                        trigger_error('Subject changed; cannot undo', E_USER_WARNING);
                        return null;
                    }
                    $subject->$field = $data;
                }
                $subject->save();
                return $subject;
            } elseif ($this->description == 'created') {
                if ($deleteCreated) {
                    $subject->delete();
                    return $subject;
                } else {
                    trigger_error('Subject not deleted; $deleteCreated is set to `false`', E_USER_WARNING);
                    return null;
                }
            }
        }
        return null;
    }
}

I don't think that Undo/Revert changes is the responsibility of this package.

Primary with the new capability to adjust the "changes" array and custom casts in Laravel core it's impossible for us to properly restore data.
I will close this issue as there's no way we could properly restore data or go back to a given point in history. In case you need such logic you could probably investigate event sourcing.
https://event-sourcing-laravel.com/
https://github.com/spatie/laravel-event-sourcing
https://eventsauce.io/


[AutoPR compute/resource-manager] Add missing properties for Vmss zone GA

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2445

Codecov Report

Merging #1949 into restapi_auto_compute/resource-manager will increase coverage by <.01%.
The diff coverage is 100%.

@@                            Coverage Diff                            @@
##           restapi_auto_compute/resource-manager    #1949      +/-   ##
=========================================================================
+ Coverage                                  53.16%   53.16%   +<.01%
=========================================================================
  Files                                       4731     4731
  Lines                                     117423   117425       +2
=========================================================================
+ Hits                                       62425    62427       +2
  Misses                                     54998    54998

Impacted Files
Coverage Δ

...te/v2017_12_01/models/virtual_machine_scale_set.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7549fec...a7b0b58. Read the comment docs.


ESP_32 support

Hi All,
I was wondering if library supports esp_32 WROOM? I tried to set the ESP_CFG_ESP32 to 1 and  ESP_CFG_ESP8266 to 0 to be able to use the library for ESP32 but I've received an error at the compile time. In esp_config_default.h it's mentioned that ESP_CFG_ESP32 must be set to 0, so does this mean that library doesn't support ESP32?
Also I should mention that when I set get time and date request I am getting the following format which is not compatible with the current parser :

I've added the following code in (espi_parse_cipsntptime.c before "msg->msg.tcpip_sntp_time.dt->date = espi_parse_number(&str);" ) and problem is resolved:
if (*str == ' ') str++;

For now yes.

Hi Sorry I didn't get that what do you mean by yes? It does support? But I can't enable that.

For now it does not support.

OK thanks

Informarion I have is that Espressif thinks to made ESP8266 and ESP32 comnands compatible. So far this is not the case, some commands accept different parameters, like CWDHCP, for example.
Once migration is done, library will support both. Put yourself to watch list and you will be notified.


[openssl] Update to 3.0.4

Describe the pull request

What does your PR fix?
Fixes #25366

I have no idea where this error on x86-windows comes from. I just updated the versions, so either upstream changed their build system or someone messed up this port previously.
'""C:' is not recognized as an internal or external command,
operable program or batch file.
jom: D:\buildtrees\openssl\x86-windows-rel\Makefile [crypto\aes\aes-586.asm] Error 1
jom: D:\buildtrees\openssl\x86-windows-rel\makefile [build_libs] Error 2

The log looks like it would call the compiler with / path separator instead of \ in cmd. That's why the program name is C: when we see C:/Program Files/....
Additionally:
a) At the top of ports/openssl/uwp/portfile.cmake, there is  vcpkg_add_to_path("${PERL_EXE_PATH}") but I guess it should be  JOM_EXE_PATH.
b) I don't see what makeopenssl.bat is used for.

@JonLiu1993 I don't have time to debug this.


Inline attachment support?

It would be awesome to extend #2 so that attachments.inline work.

@mcolyer PR's are always welcome!


Asking for help with hardware decoding to convert into JPG images.

Thanks for the great work you have done with this library!
I am using the hardware_decoding example for hardware decoding, and I have obtained Frame.Data(). However, I keep encountering errors when trying to save the frame as a JPG image, which prevents me from proceeding.
I plan to take timed screenshots with my camera and send them to WeChat, but due to the aforementioned errors, I can't continue. Could someone help me? Here is the decoder information for my camera's VLC streaming.
Can you provide a demo for saving a frame to an image?

Could you share the code and the error you're getting?
Anyway check out this part of the Demuxing/Decoding example on how to properly generate a go image with the data of a frame. Once you get an image.Image, you can use jpeg.Encode or png.Encode to save it to a file. Beware as you may need to convert to proper RGBA in order to get good result.

This is my streaming information.
Input #0, rtsp, from 'rtsp://<IP_ADDRESS>':
  Metadata:
    title           : Media Presentation
  Duration: N/A, start: 0.040000, bitrate: N/A
  Stream #0:0: Video: hevc (Main), yuv420p(tv), 2560x1440, 25 fps, 25 tbr, 90k tbn

Now it's working properly, but the conversion efficiency is too low. How can I use RKMPP hardware acceleration to achieve image transcoding?
if s.inputStream.CodecParameters().MediaType() == astiav.MediaTypeVideo {

	fd := finalFrame.Data()

	var err error
	if i, err = fd.GuessImageFormat(); err == nil {
		if err := fd.ToImage(i); err != nil {
			log.Error("guessing image format failed: %v", err)
		}
	} else {
		nv12, err := fd.Bytes(1)
		if err != nil {
			log.Error("copying frame data to the image failed: %v", err)
			return
		}
		i = NV12ToRGBA(nv12, finalFrame.Width(), finalFrame.Height())
	}
}

// NV12ToRGBA converts NV12 formatted data to an RGBA image.
func NV12ToRGBA(nv12 []byte, width, height int) *image.RGBA {
	// Create an RGBA image
	rgba := image.NewRGBA(image.Rect(0, 0, width, height))

	// Iterate through each pixel in the NV12 data and convert it to RGBA
	for y := 0; y < height; y++ {
		for x := 0; x < width; x++ {
			// Calculate indices for Y, U, and V components
			yIndex := y*width + x
			uvIndex := width*height + (y/2)*width + (x/2)*2

			// Extract Y, U, and V components
			yComp := float64(nv12[yIndex])
			uComp := float64(nv12[uvIndex])
			vComp := float64(nv12[uvIndex+1])

			// Convert YUV to RGB
			r := clamp(yComp + 1.402*(vComp-128))
			g := clamp(yComp - 0.344136*(uComp-128) - 0.714136*(vComp-128))
			b := clamp(yComp + 1.772*(uComp-128))

			// Set the RGBA values
			rgba.Set(x, y, color.RGBA{R: r, G: g, B: b, A: 255})
		}
	}

	return rgba
}

// Helper function to clamp a value to the range [0, 255]
func clamp(v float64) uint8 {
	if v < 0 {
		return 0
	}
	if v > 255 {
		return 255
	}
	return uint8(v)
}

You could use a filter instead (checkout format and possibly hwdownload as well as the example) and if your goal is to transcode checkout this example

If your target platform is RKMPP, you may need to use go-astiav/bump/n6.1 (see issues #27 and #57). For hardware encoding and decoding, consider using ffmpeg-rockchip. The mainline FFmpeg does not support Rockchip Mpp.

Closing this issue, but feel free to reopen it if needed 👍


Add setNoMoreTsBlocks(), close() and abort() methods in SinkHandle

Coverage increased (+0.02%) to 65.349% when pulling 6237d9a5ccb3ce30055e8537ffe8e7eb456e76ab on mpp-ty into 5edf9e966693f0f1be4f0d8e11ee0c6dde5eb02d on master.


Codewarrior2000 bael 2142

Pull request for code refactoring based on advice from Kevin Gilmore

Started over again and open a new PR #5484 (https://github.com/eugenp/tutorials/pull/5484)


Let's talk

I am opening this discussion because, since I am using this very helpful library, there are many questions that come to my mind.
First of all, I use this client to help me building a monorepo with libraries based on Angular 2. Those libraries will by used by all Angular apps in my company. The architecture that I am trying to resolve is describes HERE.
As you can read in the README, there are a lot of issues that I can solve with oao but I still need to write some scripts for particular parts.
1st subject : please keep oao simple !
Like everybody, I started to use Lerna at the first time. But it was changing too much my way of working (I mean the company way). I am not saying it's a bad way but companies have their own rules and usually you can't change them easely.
When I tried to fit lerna to it, I had to add a lot of --skip-something options on each command...It was ugly and finally I don't felt that lerna could helps me.

Oao helped me with oao bootstrapand oao all but for example, I cannot profite of oao prepublish/publish. Why ? Because It's already specifying a list of rules that I am forced to follow (some examples) :

oao prepublish:

Fields are copied from root package : Really, it's a very good idea but...why can't I choose the list of properties that I want to copy ?
...

oao ppublish:

The current branch should be master : companies can have their own git workflow and they can use other branches. (don't react too fast like "Stupid guys, there is an option for that", continue reading ;-))
No uncommitted changes should remain in the working directory : during my build, I am modifying some dependencies version of each package.json to align versions of all of my libs (by example Angular version). I don't want to push those generated package.json, it's only when I am building the app for publishing...but I can't publish because they are modifications
Asks the user for an incremented master version : this is an example but other subjects are difficult to manage when we want that only a CI tool can publish.

I know I can solve a lot of those issue with options : --no-master, --no-confirm,...and probably may more coming like lerna. But why didn't we think in another way : putting in place a working core without rules (I am not saying removing checks like verifying that glob paths are directories, ...).
And later, adding options to add functionnalities.
It can also be a config file, for example :
oao.json
{
    "bootstrap": {
        "packages": [
            "packages/*",
            "other/*"
        ],
        "...": "..."
    },
    "prepublish": {
        "strictVersion": true,
        "copyFromRoot": {
            "packageFields": [
                "description",
                "author"
            ],
            "readme": true
        },
        "...": "..."
    },
    "publish": {
        "strictBranch": "master",
        "confirm": true,
        "strictCommit": true,
        "...": "..."
    }
}

Or we could even have a core that allows to plug a list of configurations, plugins, etc...
2nd subject : missing the build step !
Ref doc : Asks the user for confirmation that it has built all sub-packages for publishing (using something like yarn build).
Fine, when I build my app :

I create a dist/ folder at the root containing the list of built packages (I transpile and rollup my packages).
Next, I copy in the corresponding dist/, the package.json and I replace placeholders version for each package.
Next, I copy in the corresponding dist/, the README.md for each package.
... many scripts for manual build

And now, you should think : "ok, but it's not my business". My issues here are :

If I want to publish, I need to publish each package of my dist folder and not the original ones...how do I do ?
If I want to work locally, I need to oao bootstrap my dist folder. Links will enter in conflict with the original ones...how do I do ?
...

I think it could be good to have a relation between the source files and the built files. I mean, my tool should be able to take in account my dist/ folder at the root or in each package folder.
I don't know exactly how but, I think the build steps should be part of the tool.
3rd subject : Who cares ?
Me ;-) and many others. When I expose the subject during meetups, I feel that people are interested by the monorepos but they don't find a good tool, or they create many differents ways of doing it.
4th subject : Sorry
I you already know, english is not my main language so, in advance, sorry for my bad sentences probably too strict and not in a good and polite way
Final
Thank you if you read all of this. I am really open to your constructive criticism ! Today I am not enough good in node js developments to start those kind of project but I hope some of my ideas will became debates, issues, CR, etc...

First of all, I'm glad you're using oao to build stuff and are more or less happy with it :smile: Also thanks for opening up this interesting discussion on the direction oao should take, and more generally on the trend that most tools have towards becoming increasingly bloated over time.
I totally agree with you that oao should be kept simple. This is my number-one priority, and I will do my best to keep it like that. Having said this, I agree with some of your ideas but not 100% with some others. Let's have a look:

Default CLI options: I'm not so sure that most functionality should be disabled by default and only enabled via CLI options. In many cases, users may end up with kilometric command lines that, as you said, would be "ugly" (and unwieldy). I'm more for a sensible set of options that suit most users, even if that means that others will need to disable some options. The defaults of course may also change with time as we learn more.
Also note that for you some things may currently be "must have by default" (e.g. filtering subpackage directories that don't have a package.json), but others might find the check against non-master publishing a life-saver (see @gaearon's tweet)

Configuration files: That may be a good idea, and it's not incompatible with having a set of default options. I would be happy to merge a PR for this functionality, although oao is so simple (see above) that I personally don't need a config file.

Build step: Again, I agree with you that "oao must be kept simple", but that also means we should probably not broaden its scope to become a Swiss-army knife for monorepos. You have a dist folder where you publish from, but another user may use a different directory structure or publish approach. Presently, oao caters to the (arguably) most extended way of having (.gitignored) build folders in their own individual sub-packages, which are published along with their respective package.json files (I believe Babel, Jest, Create React App and others follow that approach). For other use cases, I'd recommend using custom scripts (also possible in JS with tools such as ShellJS).

P.S. During prepublish, you can choose the list of properties you want to copy via the --copy-attrs <attrs> option. An additional option, yes :wink:

I understand your points of views. You convinced me on almost all points.
I completly agree that the build phase cannot be defined clearly in the process. I completly agree that my way of doing could not fit the way of other users.
I just think that "a set of options that suit most users" could be a plugin that contains all of this options and this plugin could injected by default. And if we want to change it, we are able to re-implement this plugin in a different way but the core still stay the same.
Do you know gradle ? You can apply plugins that interfer with the lifecycle/configurations of the tool. I like this way, to be able to inject my specificities/plugins inside the tool without having to write and run those specifities inside side scripts.
To push the frontiers of thinking :

The package manager (npm, yarn) could be a plugin : And the core is just an abstraction of it's functionallities that propose a common way to install, publish, etc.. and the plugin could take in charge those tasks.
The way that we manage a monorepo could be a plugin : it takes in charge the scanning of directories, the inter-dependencies with links, etc...
...

I think in this way, we could keep a core simple with many open doors that the plugins could use.
I know, I am talking a lot and I don't propose a real implementation of that :-) and I know it's not the goal of this tool which is already focused on yarn, monorepo, etc.. (which is great ;-))

This conversation stalled due to lack of time, and parts of it may be obsolete now that Yarn workspaces have entered the scene and oao supports them (as well as config files). Feel free to reopen if more ideas crop up.


[BUG]: Nav links aren't links

Description of the bug
The nav links are not actually links and therefore can't be accessed by keyboard users tabbing through the site.
Steps To Reproduce
Use the tab button to navigate through the site starting at the URL bar. It jumps from the JAYANT GOEL logo to the download resume button missing out the nav items
Additional Information
No response

Hey @emmalearnscode
Thanks for letting me know about the above bugs(#16, #17, #18, #19).
But now it has been finally been fixed 🙌.
Feel free to visit again my portfolio and It should work perfectly fine(Remember to clear the cache and then reload ).
Thank you.


Change Editable Multi-line Selection Background Color

Hello!
How can I change the background color of editable multi-line text if it is selected? Because currently, it is near impossible to understand if it is selected or not. As an example:

I have selected the 4th line as you can see from the light colored dots in the this line but it is really hard to understand if it is selected. I want to do something like this:

Thanks!

Hi @kkeld,
Firstly, the highlight of editable areas is not meant to be used in production, I added it as a way to visually identify any mistakes in the provided ranges while the constrains are getting added during development. That's why I didn't give a easy to use API to modify the styling
There is a workarounds,
You can find the classnames for the single line editable area and multiline editable are in this file https://github.com/Pranomvignesh/constrained-editor-plugin/blob/master/src/utils/enums.js
You can add a CSS file and overwrite the style in those classes.
Since, I have seen few issues similar to this, I consider to modify the ToggleHighlightOfEditableAreas API to accept the classnames. I have to develop and test it. So, in the mean time, I would advice you to go with the workaround

This issue is stale because it has been open 30 days with no activity. Add required comments or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.


No consumer groups

Since upgrading Kafka to 2.12-2.10 I can no longer list consumer groups in my prod environment. Dev is running the same version of Kafka with the same config, and has no issues. I've tried using the latest Burrow code on prod, and get the same empty list. Dev is still rocking on with a much older burrow install and is displaying the consumer list just fine.
From the prod Burrow logs: [WARN] Failed to decode __consumer_offsets:49 offset 172116: valver 3
The only reference I can find to this error is #53 but I can't find anything in there that will help me. As far as I can tell I'm committing offsets to Kafka.
I have spent many hours on this, and I'm probably more confused now than when I started. I have even gone so far as to shut down my pipeline and purge and reinstall Kafka, in case there were some old topic settings that caused this, but no luck.
Clients for both environments are all Logstash 6.6.0 (not sure if this is relevant), and they all have the same consumer config.
What's my next step to get this figured out?

You're running a 0.x version of Burrow. You're going to need to update to latest and provide the logs from that.
From the log message you did provide, it's failing to decode the message because it's using schema version 3 for the message value. That was added back in 10d4dc39ebe33fbacd9f96879b4019b8d473ea0f

@toddpalino all good, got Burrow upgraded to the latest and I can now query the API. Thanks.

Hey,
I also faced the same issue just after upgrading my kafka to version 2.1.1, so I follow the above guidelines and now I move to burrow v1.2.2, but now when I try to run the burrow via docker compose it exit with below logs.

burrow | Reading configuration from /etc/burrow
burrow | Burrow failed at March 27, 2019 at 3:10pm (UTC)
burrow | Existing process running on PID 1. Exiting burrow exited with code 1

What other changes do i suppose to do apart from upgrading to burrow version v1.2.2. I appreciate you r help in this regard.


open link in a new tab?

Is there anyway to open the link in a new tab? right now it opens it in the same tab

According to the demo(http://tasti.github.io/react-linkify/),
<Linkify properties={{target: '_blank'}> ...

One possibility is instead of using properties, you can just place the props you want each of your links to have directly on Linkify. For example:
<Linkify target="_blank">...</Linkify>

My worry here is that there may be some overlap that isn't ideal, where there's a prop on Linkify that is also on a but with different values. I think there are little to none of these, and seems to be more intuitive.

@tasti I'd be happy to implement the target idea and make a PR if you're interested

Would love to include this, give it a shot :)

@jb-reefer presuming this didn't happen?

@dharness never got the shot - I can work on it this weekend, but if you want to do it feel free!

@dharness submitted a PR!

Hey didn't expect that! Much appreciated!

Add target: "_blank" property as part of options prop


No issues received in SonarStash plugin

Hi !
I wanted to use this plugin. I have project where are we using maven sonar plugin + sonarqube 5.3.
I have installed sonar starh plugin, setup stash url / user / password + installed sonnar-runner.
In stash i have created branch and pull request on which i have run sonnar-runner. Sonnar runner executed (as i was expecting) SonarStash plugin. He posted comment that pull request contains NO ERROR and approved pull request.
But on purpose i have created some issue in branch.

In pull request in stash i can see change of code (errors in code)
In sonarqube i can see 3 new major issues (errors in code which i have made)
But Sonnar Stash posted no comment

I was little diging in code and in class 'StashIssueReportingPostJob' i have in contructor place little logging message how many issues contains property 'projectIssues' in constructor. Result is 0. Altogether my project is quite big and contains 650 critical + major issues (and 3 major are new created only in branch).
Do you have any ideas why SonarStash plugins does not receive any issues ?
Thank tou very much !

Hello @senty
Could you please post the command line used to run your SQ analysis with the plugin?
Cheers,
Antoine

Hi,
from project root directory :
sonar-runner -Dsonar.branch=[STASH_BRANCH] -Dsonar.login=sonar -Dsonar.password=sonar -Dsonar.stash.notification -Dsonar.stash.project=[STASH_PROJECT] -Dsonar.stash.repository=[STASH_REPO] -Dsonar.stash.pullrequest.id=[STASH_PR_ID] -X
Also i am adding 'export SONAR_RUNNER_OPTS="-Xdebug -Xnoagent -Djava.compiler=NONE -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=8000"' so i can debug it from IDE.

No analysis mode?

Thank you very much for response ! I made some experiments ...
Configuration of sonar analyses i have in file 'sonar-project.properties'
`
sonar.projectKey = horec
sonar.projectName = Horec
sonar.projectVersion = 1.0
sonar.dynamicAnalysis = false
sonar.forceAnalysis = true
sonar.verbose = true
sonar.analysis.mode=publish
#source settings
sonar.sources = src/main/java
sonar.language = java
sonar.sourceEncoding = UTF-8
#modules settings
sonar.modules = [MODULES_TO_SCAN]
[HERE ARE PATHS e.g : module.sonar.projectBaseDir = my/path]
sonar.junit.reportsPath=target/surefire-reports
sonar.jacoco.reportPath=target/jacoco.exec
`
When i have switched analyss mode into issues or preview, issues were in sonar stash plugin. But no comments has been pushed into pull request. After debuging of SonarQubeCollector i have founded probably problem with inputFileCache :
Sonar analyses mode :
publish -> files are present (inside InputFileCache inputFileCache), but no issues
preview -> issues are in sonar stah plugin, but files not (InputFileCache inputFileCache is blank)
issues -> issues are in sonar stah plugin, but files not (InputFileCache inputFileCache is blank)

No ideas why i am not receiving issues and files ?

Hello @senty,
Sorry for the delay to answer. Could you please replace your analysis mode from "publish" to "preview"?
Cheers,
Antoine

Hello @senty,
Any news on this issue?
Cheers,
Antoine

Close the ticket as there is no more activity.
To be reopened if the problem still occurs.
Cheers,
Antoine


Update audiomanager SRC_URI_remove to match meta-ivi change

meta-ivi: dcfc3e68 "Use http protocol to fetch sources (OSSINFR-30)"
Updating to meta-ivi 10.0.1 release includes this commit in which
SRC_URI for the audiomanager upstream string is changed.

Direct meta-ivi link https://github.com/GENIVI/meta-ivi/commit/dcfc3e68f01a151abfc63155f3ded60677f98b96
This is to be merged before https://github.com/GENIVI/genivi-dev-platform/pull/24 (both PR's will fail CI unless tested together)

To upgrade 11.0, I'll change this scheme. :)

I've add a change to this commit to fix the QA issue discussed here:
https://github.com/GENIVI/genivi-dev-platform/pull/24
A change in cmakeslist for the dev package stemming from meta-ivi10.0.1 inclusion of:
https://github.com/GENIVI/meta-ivi/commit/8421336085769112d7abbf228fadffb6e0f018b9

Built and booted for rasp pi2

Ok, I plan to merge this, and bring it into the GDP PR request before close of play today, I see no objections.


chore(docs): fix comments in README

Changed "//" to "#" at 2 lines

Description

References

Closes #27
Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Thanks for your contribution @samhitha999 , may we ask that you sign the CLA above in order for us to merge the PR?

Hello @samhitha999 , thank you for your contributions.  We will need the CLA(Contributor License Agreement) to be signed in order to accept the PRs as per our CNCF guideline.
Thank you!

Thanks for your PR @samhitha999 - closing it as it has become stale and the fixes have since been merged in other PRs


Expose view and taffy node from ViewId

Rationale: Solving two problems here:

It is impossible to implement the same code as the default implementation of View::layout() outside of the floem crate, which limits what components in other crates can do to lay themselves out.

Most of the components in floem::views actually implement layout by manipulating the taffy tree (e.g, in Label, self.id.taffy().borrow_mut().set_style(text_node, style);.  It is possible to implement at least the things I am trying to do right now simply by having access to the existing taffy NodeId for a View and using ViewId::set_taffy_style, so rather that the more extreme approach of exposing the whole taffy tree, I opted simply to add a call to get the node id - otherwise, the only access to it is from within a layout method which (prior to this patch at least) was inaccessible unless you could afford to give up the default layout behavior.

I'm not entirely sure that just exposing the view() method is ideal here (though something is needed) - in my case I was debugging a panic from the borrow_mut() call in View::layout() which turned out to be that I was misusing the ViewId that gets passed in to the closure in add_overlay() as the id of the overlay component, which was already in use by the container for the overlay - so I wanted to reimplement the default behavior with logging to see exactly where things were going wrong.  Attempting to use try_borrow_mut() instead to detect the source of the problem runs into lifetime problems between the erased lifetimes of RefMut<'_, Box<dyn View>> and &mut LayoutCx<'_>, which had to be resolved with some compiler trickery like this monstrosity (again, this is just debug code):
fn layout_if_posible<'l, V: View + ?Sized + 'l>(
    view_cell: &Rc<RefCell<Box<V>>>,
    cx: &mut LayoutCx<'_>,
) -> Option<NodeId> {
    if let Ok(view) = view_cell.try_borrow_mut() {
        return Some(layout_view(view, cx));
    }
    None
}

fn layout_view<'l, V: View + ?Sized + 'l>(
    mut v: RefMut<'l, Box<V>>,
    cx: &mut LayoutCx<'_>,
) -> NodeId {
    v.layout(cx)
}

So it might actually be better to expose a method on ViewId that takes a closure with a signature like with_view_id(&mut self, mut f : impl FnMut(&mut dyn View)) so users of the API are insulated from the erased lifetimes involved, and (perhaps?) use try_borrow_mut there and return a boolean (is there ever a legitimate case where there could be contention for the view, or was that only because I was abusing one id for two views?).
At any rate, this patch is likely to be harmless as-is.

Adding taffy_node looks good to me.
I'm a bit nervous exposing View to user though. I still can't understand why you'd need to access View?

To have the ability to reimplement the same functionality (or a portion of it) that View::layout does. Specifically, it gets the View instance so that it can call layout on it to recursively lay out its children.
If you have a reason to override layout in a View in another create, then you lose the ability to do that - at least in a straightforward way, or in a way that will return a NodeId.
I agree, exposing View is not ideal - it could be abused.
Is there another way to achieve the same thing?
I could imagine just moving the default implementation of layout() into a plain fn that takes an id and a layout context, and that would solve most problems (maybe someone will need to do the default layout on every child except one? I can't really imagine this, but it's not impossible, I suppose).

I just added a commit which avoids making ViewId.view() public, and instead moves the default implementation of View.layout() into a standalone fn which is callable by any view implementation in any crate.
That will probably solve the problem well enough.

I'm running into these same issues now. Would be great to have this


Silence audit and funding messages from npm

While reviewing some logs, I noticed the following:
added 1 package, changed 30 packages, and audited 382 packages in 6s

58 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

While I'm not against security, nor supporting OSS maintainers (I co-maintain 10+ projects myself!), I am against noisy logs that add no value.
So let's silence these:

When they appear in CI, they add no value.
We've got our own security tools for vulnerable deps, which we rely on instead of npm audit results.
When I'm skimming logs looking for debug information, these just get in my way.
There may be a speed boost if the audit/fix metadata requires an additional API call,  and silencing actually skips that rather than merely silencing it.

There's multiple ways to silence these: https://benjamincrozat.com/disable-packages-are-looking-for-funding
Originally I tackled this by adding --no-audit --no-fund flags, but there's a lot of different entrypoints and workflows that call npm ci or npm install. Even if I do manage to get them all, there's always a risk someone will come along later and add another entrypoint. So that's why I went the .npmrc route.
After this change, the logs are much better:
added 1 package, changed 30 packages, and audited 382 packages in 6s

xref:

https://github.com/github/dependabot-action/pull/1301


Impedance mismatch between RangeWithValue and NumberProperty?

From https://github.com/phetsims/dot/issues/78
I think there's a problem with some (many?) usages of RangeWithValue.  A typical usage is like this:
// 1. Create range with value
// 2. Create a NumberProperty that has range: rangeWithValue and initialValue: rangeWithValue.defaultValue

Why not create the NumberProperty directly in the first place?  Declaring it as a RangeWithValue in one place then picking values out for the NumberProperty redundant?  For example, CLBConstants.js declares:
BATTERY_VOLTAGE_RANGE: new RangeWithValue( -1.5, 1.5, 0 ), // Volts

Then the Property is declared like so:
    // @public {Property.<number>}
    this.voltageProperty = new NumberProperty( voltage, {
      tandem: tandem.createTandem( 'voltageProperty' ),
      units: 'volts',
      range: CLBConstants.BATTERY_VOLTAGE_RANGE
    } );

And the voltage variable came from:
CLBConstants.BATTERY_VOLTAGE_RANGE.defaultValue,

Or is this expected because we sometimes have one range creating many Property instances (say, one per screen?)
Here's the same thing happening in BeersLawSolution:
    this.concentrationProperty = new NumberProperty( concentrationRange.defaultValue, {
      units: 'moles/liter',
      range: concentrationRange,
      tandem: options.tandem.createTandem( 'concentrationProperty' )
    } );

By that token, why aren't the units associated with the range, so we could do something like this?
    this.concentrationProperty = new NumberProperty( concentrationRange.defaultValue, {
      units: concentrationRange.units,
      range: concentrationRange,
      tandem: options.tandem.createTandem( 'concentrationProperty' )
    } );

Or is there a better way to pass RangeWithValue to a NumberProperty?
Leaving self-assigned for now to think it over before discussing with other members of the team.

@samreid said:

I think there's a problem with some (many?) usages of RangeWithValue. A typical usage is like this: ...

Until 10/17/18 (which is actually before this issue was created), the type of NumberProperty's range option was {Range|{min:number, max:number}|null}.  The API changed, so keep that in mind when you're evaluating the usages shown above.  And for at least one of the examples above (BLL), NumberProperty and its range option didn't exist when the code was written.

Or is this expected because we sometimes have one range creating many Property instances (say, one per screen?)

I don't know if it's "expected".  But it's certainly possible with this implementation, and I've used that frequently.  If 2 screens have models with the same NumberProperty (e.g. voltageProperty), they need 2 instances of that NumberProperty, but can share one instance of its Range or RangeWithValue.
Ranges are also things that tend to evolve during sim design/implementation, so I typically put them in a Constants.js file, along with other things that I may need to touch frequently.  I don't have a need to put a NumberProperty instance in Constant.js, because Property instances are typically not shared across screens.

Or is there a better way to pass RangeWithValue to a NumberProperty?

The range option to NumberProperty is optional, and it's a {Range}, not a {RangeWithValue}.  The range is used for validation, not initialization.  If it is a {RangeWithValue}, there's no requirement that the initial value comes from range.defaultValue.  I see nothing wrong with the current approach - it's flexible and straightforward.

One other possibility would be to create a new type RangeWithValueNumberProperty which knows how to take the default value and range, like so:
this.concentrationProperty = new RangeWithValueNumberProperty( concentrationRange, {
  units: 'moles/liter',
  tandem: options.tandem.createTandem( 'concentrationProperty' )
} );

Skimming through occurrences of .defaultProperty, I saw >20 cases that could use this pattern, and it will free us up from specifying the same thing twice in all of these cases (and prevent the values from getting out of sync during maintenance).
@pixelzoom can you please review and advise?

If you don't mind, let's defer work on this issue until after the holiday.  I'd like to discuss before you proceed.

I'm somewhat on the fence at the moment, so I'm happy to avoid implementing RangeWithValueNumberProperty for now.  However, if we had, say 50+ occurrences that matched this pattern, I would probably change my tune.  So how about marking deferred for now and re-evaluating in a year or so?

Deferred, to be revisited no later than 11/21/2019.


How to integrate chat in existing project

How to integrate chat in existing project

How to integrate chat in existing project

Interested

@MunahhadMaaz @zaidqattan I'm planning to migrate into separate framework in the future which can be installed via cocoapods or spm

@aslanyanhaik did you work on how to integrate it in existing project?


Failed to determine Card type Arts in TW

Before opening an issue:

[x] I tested the latest release
[x] I looked at other issues (even the closed ones)
[x] I read the Troubleshooting Guide
[x] I'll fill this template properly

Describe the bug
FGA can't determine Arts in TW server, but works fine on other types.
Screenshots

Device Info:

Device model: NoxPlayer
Screen size: 1920x1080
Android Version: Android 7.1.2
RAM: 3GB

I'm on TW too and this is a problem for me as well. I think the problem in #627 happened again. Did TW change the font back? Let me go make some screenshots and see if we can fix this.

@ShibaShika would you mind double-checking if #721 works for you?

FYI, it will take a while for the fix to be built, Github Actions is not working right now: https://www.githubstatus.com/

@the3dsandwich
Works good, thank you.


Requests dependency version included is vulnerable

requests dependency has a vulnerability for versions <2.60.0 and >2.2.5
For more details visit  => Snyk link
Relevant PR: #28

PR: #28 merged. This resolves the issue.


graalvm-ce: 20.3.0 -> 21.0.0

Motivation for this change
Needed for PR #111864.
Will probably break clj-kondo and babashka.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112042 run on x86_64-linux 1

1 package failed to build:

clj-kondo

3 packages built:

babashka
graalvm11-ce
graalvm8-ce

CC @borkdude.

BTW PR https://github.com/NixOS/nixpkgs/pull/111864 shows that we can build leiningen projects from source using a small hack: https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/maven.section.md#double-invocation. Maybe building everything from source is the answer for making it easier to do those GraalVM bumps, but AFAIK we still need to provide stubs for older/newer versions of GraalVM.

I think clj-kondo and babashka work with 21.0.0 and from then on upgrading GraalVM shouldn't be so painful anymore, hopefully. The problem I'm currently still inspecting with 21.0.0 is the slightly larger image size, but I'm planning to upgrade within the next couple of weeks.

No problem @borkdude, we can wait.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112042 run on x86_64-darwin 1

1 package failed to build and are new build failure:

clj-kondo: log https://termbin.com/4vrw

3 packages built:

babashka
graalvm11-ce
graalvm8-ce

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112042 run on x86_64-linux 1

1 package failed to build and are new build failure:

clj-kondo: log https://termbin.com/xhw8

3 packages built:

babashka
graalvm11-ce
graalvm8-ce

irb on Linux not working.
$ ./graalvm11-ce/bin/irb
<internal:core> core/kernel.rb:234:in `gem_original_require': libtruffleruby.so: cannot open shared object file: No such file or directory (RuntimeError)
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/ripper/core.rb:12:in `<top (required)>'
        from <internal:core> core/kernel.rb:234:in `gem_original_require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/ripper.rb:2:in `<top (required)>'
        from <internal:core> core/kernel.rb:234:in `gem_original_require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/irb.rb:12:in `<top (required)>'
        from <internal:core> core/kernel.rb:234:in `gem_original_require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/gems/gems/irb-1.2.6/exe/irb:9:in `<top (required)>'
        from <internal:core> core/kernel.rb:400:in `load'
        from <internal:core> core/kernel.rb:400:in `load'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/bin/irb:42:in `<main>'

graalvm8-ce and graalvm11-ce work on macOS.
babashka is built successfully on macOS, though not tested.
Building clj-kondo fails with the following error:
Fatal error:com.oracle.svm.core.util.VMError$HostedError: Option name "HotSpotPostOnExceptions" has multiple definitions: org.graalvm.compiler.hotspot.meta.HotSpotExceptionDispatchPlugin$Options.HotSpotPostOnExceptions and org.graalvm.compiler.hotspot.meta.HotSpotNodePlugin$Options.HotSpotPostOnExceptions
        at com.oracle.svm.core.util.VMError.shouldNotReachHere(VMError.java:68)
        at com.oracle.svm.hosted.option.HostedOptionParser.collectOptions(HostedOptionParser.java:89)
        at com.oracle.svm.hosted.option.HostedOptionParser.<init>(HostedOptionParser.java:62)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:258)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:529)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:119)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner$JDK9Plus.main(NativeImageGeneratorRunner.java:561)
Error: Image build request failed with exit status 1
com.oracle.svm.driver.NativeImage$NativeImageError: Image build request failed with exit status 1
        at com.oracle.svm.driver.NativeImage.showError(NativeImage.java:1676)
        at com.oracle.svm.driver.NativeImage.build(NativeImage.java:1426)
        at com.oracle.svm.driver.NativeImage.performBuild(NativeImage.java:1387)
        at com.oracle.svm.driver.NativeImage.main(NativeImage.java:1374)
        at com.oracle.svm.driver.NativeImage$JDK9Plus.main(NativeImage.java:1858)

@taku0 I know what the issue is there: the uberjar depends on 20.3.0 specific classes. It will be fixed once clj-kondo itself upgrades to 21.

irb on Linux not working.
$ ./graalvm11-ce/bin/irb
<internal:core> core/kernel.rb:234:in `gem_original_require': libtruffleruby.so: cannot open shared object file: No such file or directory (RuntimeError)
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/ripper/core.rb:12:in `<top (required)>'
        from <internal:core> core/kernel.rb:234:in `gem_original_require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/ripper.rb:2:in `<top (required)>'
        from <internal:core> core/kernel.rb:234:in `gem_original_require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/irb.rb:12:in `<top (required)>'
        from <internal:core> core/kernel.rb:234:in `gem_original_require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/mri/rubygems/core_ext/kernel_require.rb:92:in `require'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/lib/gems/gems/irb-1.2.6/exe/irb:9:in `<top (required)>'
        from <internal:core> core/kernel.rb:400:in `load'
        from <internal:core> core/kernel.rb:400:in `load'
        from /nix/store/z9c6fpm77sf5i742x2wxdczaynr16n2f-graalvm11-ce-21.0.0/languages/ruby/bin/irb:42:in `<main>'

Fixed.

graalvm8-ce and graalvm11-ce work on macOS.
babashka is built successfully on macOS, though not tested.
Building clj-kondo fails with the following error:
Fatal error:com.oracle.svm.core.util.VMError$HostedError: Option name "HotSpotPostOnExceptions" has multiple definitions: org.graalvm.compiler.hotspot.meta.HotSpotExceptionDispatchPlugin$Options.HotSpotPostOnExceptions and org.graalvm.compiler.hotspot.meta.HotSpotNodePlugin$Options.HotSpotPostOnExceptions
        at com.oracle.svm.core.util.VMError.shouldNotReachHere(VMError.java:68)
        at com.oracle.svm.hosted.option.HostedOptionParser.collectOptions(HostedOptionParser.java:89)
        at com.oracle.svm.hosted.option.HostedOptionParser.<init>(HostedOptionParser.java:62)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner.buildImage(NativeImageGeneratorRunner.java:258)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner.build(NativeImageGeneratorRunner.java:529)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner.main(NativeImageGeneratorRunner.java:119)
        at com.oracle.svm.hosted.NativeImageGeneratorRunner$JDK9Plus.main(NativeImageGeneratorRunner.java:561)
Error: Image build request failed with exit status 1
com.oracle.svm.driver.NativeImage$NativeImageError: Image build request failed with exit status 1
        at com.oracle.svm.driver.NativeImage.showError(NativeImage.java:1676)
        at com.oracle.svm.driver.NativeImage.build(NativeImage.java:1426)
        at com.oracle.svm.driver.NativeImage.performBuild(NativeImage.java:1387)
        at com.oracle.svm.driver.NativeImage.main(NativeImage.java:1374)
        at com.oracle.svm.driver.NativeImage$JDK9Plus.main(NativeImage.java:1858)

I think I will add a basic babashka test, so we can make sure it works.

@GrahamcOfBorg build babashka clj-kondo graalvm8-ce graalvm11-ce

FWIW babashka proper is now upgraded to GraalVM 21.0.0. Clj-kondo will soon follow.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112042 run on x86_64-darwin 1

1 package failed to build and are new build failure:

clj-kondo: log https://termbin.com/sq3c

3 packages built:

babashka
graalvm11-ce
graalvm8-ce

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112042 run on x86_64-linux 1

1 package failed to build and are new build failure:

clj-kondo: log https://termbin.com/u7v4

3 packages built:

babashka
graalvm11-ce
graalvm8-ce

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112042 run on x86_64-darwin 1

1 package failed to build and are new build failure:

clj-kondo: log https://termbin.com/gyqr

3 packages built:

babashka
graalvm11-ce
graalvm8-ce

Both clj-kondo and babashka are now based on GraalVM 21.0.0 Java 11.

@borkdude Yeah, I saw on Twitter. Thanks for the great work!

@GrahamcOfBorg build babashka clj-kondo graalvm8-ce graalvm11-ce

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112042 run on x86_64-linux 1

4 packages built:

babashka
clj-kondo
graalvm11-ce
graalvm8-ce

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:
babashka:

buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/interpreters/clojure/babashka.nix:24:3:
   |
24 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/interpreters/clojure/babashka.nix:48:3:
   |
48 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

clj-kondo:

buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/development/tools/clj-kondo/default.nix:22:3:
   |
22 |   buildPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/clj-kondo/default.nix:40:3:
   |
40 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

graalvm11-ce:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/compilers/graalvm/community-edition.nix:102:9:
    |
102 |         installPhase = {
    |         ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

graalvm8-ce:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/compilers/graalvm/community-edition.nix:102:9:
    |
102 |         installPhase = {
    |         ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112042 run on x86_64-darwin 1

4 packages built:

babashka
clj-kondo
graalvm11-ce
graalvm8-ce

@SuperSandro2000 Can we have this PR merged?


fix(docker img build): skipping debug builds when not making a release

Adjusted the build scripts to skip building debug versions unless the GH actions runs for a release by including a SKIP_DEBUG variable in command.

@yurishkuro please review the PR and suggest changes.

Got them all, working on it


[CircleGraph] Introduce formatted index.js

This will introduce index.js with format applied

added '// eslint-disable-next-line' for variables don't follow camelCase
changed '==' to '==='
use tab size 4 to follow original source

ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

For #520


OnItemMovedListener provide wrong "to" position when dragged to bottom of screen from top

I have encountered this issue while playing testing it in a demo project. The details are as below:
My UI Layout:

Recycler view of layout_height "match_parent".
Individual item view height is approx. 180 dp (basically only 3 items fits on screen in portrait)
Drag handle view to center right (size 60x40)
There are 5 items in Recycler view

Steps that I used to reproduce:

Drag item at position 0 to bottom of screen (inside recycler view, most probably 'to' position will be 2) and make sure it doesn't scroll and then lift the finger.
OnItemMovedListener reports 5 as the "to" position where it should be 2. So after calling notifyDataSetChanged(), the dragged item goes to last position in Recycler view.
If I let the recycler to scroll while dragging and release the view in center of the screen, reported "to" position is correct.
If I drag an item from bottom towards top of the screen, reported position is also correct.

BTW thanks for your time in making this.

Hi,
Thanks for this report, I can reproduce the issue. Just debugging now!
Emile

OK I think this is fixed, let me know if you give it a go. Thanks.


AddEqualityFilter title setting

I was wondering about the AddEqualityFilter setting title.

When I use the title, is that the title of what is to be displayed in the grid? Or am I misreading this or using it wrong?

It is the title of filter, not column

Right but when I run my application, this is what I see:

which isn't what I set the filter name as

What is Serenity version

1.9.25

Fixed in later versions, you should update

Aye it's in my JIRA for this sprint
On Mon, May 2, 2016, 05:39 Volkan Ceylan<EMAIL_ADDRESS>wrote:

Fixed in later versions, you should update
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/volkanceylan/Serenity/issues/627#issuecomment-216176102


Testing drawStatus property 2

Description
Test drawStatus property binding in the following samples:

integrated-windows-authentication: Binding progress indicator might not be viable as it's being set multiple times
filter-by-definition-expression-or-display-filter: Binding label might not be viable as it's being set multiple times
list-related-features

Checklist:

[ ] Set target branch to main (current release) or v.next (next release)
[ ] Request a reviewer
[ ] Assign a reviewer
[ ] Tag reviewer in comment

Assigning @jenmerritt for a first review please.

Assigning @alan-edi for a second review please.

Thanks for the review @alan-edi, I used https://rt-iwa1.esri.com/portal as the URL along with the credentials used for connecting to the VPN including the Esri domain.


Unify RolePermissions component - replace other versions

Replaces https://github.com/ansible/ansible-hub-ui/pull/2246 now that rbac (#2239) is merged.

RolePermissions comes from d8e4f75446c5f3965ea24c0970c269bec9648311 (ansible/ansible-hub-ui#1863),
taken from src/containers/group-management/group-detail-role-management/group-detail-role-management.tsx
But the same logic also appears in:
src/components/role-management/role-form.tsx
src/components/role-management/role-permissions.tsx
src/containers/role-management/role-list.tsx
with variations on editability, showing extra permissions, and hiding empty permission groups.
=> setPermissions, showCustom, showEmpty on RolePermissions :)
also TODO ensure changes from https://github.com/ansible/ansible-hub-ui/pull/2228 survive

This is being handled in #2955 , will close when done.

Merged in https://github.com/ansible/ansible-hub-ui/pull/2955


[r] Inconsistent behavior of SOMATileDBContext

Description

ctx <- tiledbsoma::SOMATileDBContext$new(c(key="value")) is available at the C++ level
ctx <- tiledbsoma::SOMATileDBContext$new(); ctx$set('key', 'value') is not available at the C++ level

This is confusing and error-prone.
Context: I debugged this while doing code review, trying to find out why setting soma.init_buffer_bytes was not actually increasing the buffer sizes as desired.
Reproduction
This script:
tiledbsoma:::set_log_level('debug')

try_ctx <- function(ctx) {
  # obs <- SOMADataFrameOpen('/var/s/v/pbmc3k_processed/obs', tiledbsoma_ctx=ctx)
  # print(obs$read())
  # print(ctx)

  cat("Access 1", ctx$get('soma.init_buffer_bytes'), "\n")
  cfg <- as.character(tiledb::config(ctx$context()))
  cat("Access 2", cfg['soma.init_buffer_bytes'], "\n")
}

ctx <- tiledbsoma::SOMATileDBContext$new(c(soma.init_buffer_bytes="2000000000"))
try_ctx(ctx)

cat("\n")
ctx <- tiledbsoma::SOMATileDBContext$new()
ctx$set('soma.init_buffer_bytes', "4000000000")
try_ctx(ctx)

produces:
Access 1<PHONE_NUMBER>
Access 2<PHONE_NUMBER>

Access 1<PHONE_NUMBER>
Access 2 NA

The problem is that the C++ code in question here uses the second access  method, whereas the unit-test logic is testing the first access method.
A clue is the fact that if you do print(ctx) then in my first ctx in the repro script (set at constructor time) the key soma.init_buffer_bytes appears in alphabetical order in the print output along with the other configs -- whereas in my second ctx (set a key-value pair post-construct) the key soma.init_buffer_bytes appears before all the other configs in the print output.
Analysis
There appears to be a well-intended layering of TileDB-core-level configs and application-level configs here:

https://github.com/single-cell-data/TileDB-SOMA/blob/1.2.4/apis/r/R/SOMATileDBContext.R#L51-L53
https://github.com/single-cell-data/TileDB-SOMA/blob/1.2.4/apis/r/R/SOMATileDBContext.R#L90-L96

This seems to mean that values set at construction time (as in my repro script) become part of the core-level config, but values set post-construct (as in my repro script) become (implicitly) part of the application-level map/dict without being pushed down to core-level config.
Suggestions

I'm open to discussion on whether this is a bug or a feature. (Personally I lean toward the former.)
If we decide this is a bug:

Fix the bug: ctx$set needs to push key/value pairs down to core-level config

If we decide this is a feature:

User-visible on-line help needs to be very clear about this
Code-level docstrings at all four levels of the inheritance hierarchy (SOMATileDBContext -> SOMAContextBase -> MappingBase -> MappingBase) need to be very clear on: which class has which role; the fact that core-level mappings (which are pushed down to core config) and application-level configs (which are not) are stored in the same class; offer vignette material showing how to use soma.init_buffer_bytes

Also (perhaps for a separate PR): we need vignette material showing explicitly how to correctly use soma.init_buffer_bytes. This is especially important because (a) as found here, it's easy to get it wrong and have the attempted config setting not take effect; (b) our current default is 16MB which is quite small.

It seems like a bug if ctx is a mutable object. If immutability of this object is supported in R, why not make ctx immutable (raise an error on set)?


feat(lib): re-enable writev support

Tokio's AsyncWrite trait once again has support for vectored writes in
Tokio 0.3.4 (see tokio-rs/tokio#3149.
This branch re-enables vectored writes in Hyper. Using vectored writes
in HTTP/2 requires a git dependency on a h2 branch that adds writev
support in h2.
I've removed the adaptive write buffer implementation
that attempts to detect whether vectored IO is or is not available,
since the Tokio 0.3.4 AsyncWrite trait exposes this directly via the
is_write_vectored method. Now, we just ask the IO whether or not it
supports vectored writes, and configure the buffer accordingly. This
makes the implementation somewhat simpler.
This makes a pretty noticeable performance improvement in the
HTTP/1 end to end benchmarks.

Vectored writes are now enabled based on whether the AsyncWrite
implementation in use supports them, rather than though adaptive
detection. To explicitly disable vectored writes, users may wrap the IO
in a newtype that implements AsyncRead and AsyncWrite and returns
false from its AsyncWrite::is_write_vectored method.

I have no idea why CI won't start... (also, super minor conflict in Cargo.toml).

h2 pr: hyperium/h2#500


Can’t send messages from IRC

I just noticed that several messages I wrote to ceylon/user via the IRC bridge (Ctrl+F duckduckgo or “U+5350” in the logs) were never sent – no one can see them on the web interface.

Must be a fairly recent bug: This message :point_right: April 28 2015 10:51 PM was also sent via IRC.

Odd, seems to partially work now: The first two of these messages :point_right: April 29 2015 3:55 PM were also sent via IRC.

Could you perhaps provide some additional information that might help us debug this?
For instance, what IRC client are you using? If it's running on a laptop, does this sort of behaviour get exhibited after waking from sleep perhaps? Are you connected now and can you successfully send messages to a room?
Just saw your update, when you say partially, what do you mean?

Pidgin. Desktop computer, running on a stable internet connection.
“Partially” is perhaps misworded. My latest messages arrived fully. If you have a test room that I can spam freely, I can test it some more.

Cool, just created https://gitter.im/gitterHQ/irc-test
I don't know Pidgin very well, but would be good to see if there's some sort of console or debugging environment it has so we can see what's going on.

there’s a “Debug Window”, when the problem occurs again I’ll see if anything pops up there.

Okay, problem’s there again, and there’s nothing related to it in the Debug window. (I think that’s mostly intended for XMPP.)

I experienced a similar problem with LimeChat a while ago (mid-March). Messages I sent through IRC bridge weren't showing in the web interface. It seemed to happen in multiple rooms.

I also had this problem. I was able to send one message that showed up in the web interface, but other messages did not show up. I also only received a handful of the dozen of messages that were actually being sent to the room.

I'm hitting this issue, do you need help reproducing the problem?
I'm working on a bot that connects to the IRC bridge using the cinch gem in ruby.  I was testing last night, created a private room (for me and my bot account) and many messages went through, then it stopped working.  Since then I have sent several messages from the Web UI, and all have been received by the IRC client, but its replies don't show up in the Web UI.
Interestingly, now when I log into the Web UI with my bot account and post a message to the room, it doesn't even show up.  Has my bot account (@not-bdunne) been rate-limited or disabled in some other way?

@bdunne I have exactly the same issue. Any news? :smile:


HA Version 2023.8.0 Beta breaks integration

Version of the custom_component
4.2.0
Describe the bug
Devices no longer available/connecting
As per https://github.com/albertogeniola/meross-homeassistant, In the past 24 hours, Meross has changed the signature of its HTTP API version (keeping the same API version in place). That did break every HomeAssistant integration version below 1.2.6 (included). In order to solve the issue, you should upgrade to version 1.2.8 which includes the necessary changes to work again with the updated version of the Meross APIs.
This seems to have affected Meross LAN as well.
HA beta update 2023.8 seems to have broken the integration.

Hello @TheOneOgre,
It looks like this issue was raised back in december and related to the @albertogeniola custom component. This wasn't affecting meross_lan at the time nor it should affect it now.
Are you experiencing any issue so far?

Hello @TheOneOgre, It looks like this issue was raised back in december and related to the @albertogeniola custom component. This wasn't affecting meross_lan at the time nor it should affect it now. Are you experiencing any issue so far?

Interesting, I guess maybe coincidence that it broke for me and I saw that haha. Yeah my meross garage opener msg100 just disconnected and is not being discovered by the integration anymore. The meross cloud iot one however is functioning perfectly fine however.
I will post debug logs when I get home today.

So I completely reinstalled the integration, power cycled my device, and it was detected, key was pulled for the device and it finished the config flow, but then immediately dropped into "failed to set-up" Here is the log:
`This error originated from a custom integration.
Logger: homeassistant.config_entries
Source: custom_components/meross_lan/meross_device.py:578
Integration: Meross LAN (documentation, issues)
First occurred: 3:14:16 PM (2 occurrences)
Last logged: 3:18:49 PM
Error setting up entry msg100 - redact for meross_lan
Traceback (most recent call last):
File "/config/custom_components/meross_lan/helpers.py", line 586, in exception_warning
yield
File "/config/custom_components/meross_lan/meross_device.py", line 183, in init
device_registry.async_get(ApiProfile.hass).async_get_or_create(
File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 479, in async_get_or_create
device_info_type = _validate_device_info(config_entry, device_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 141, in _validate_device_info
raise DeviceInfoError(
homeassistant.helpers.device_registry.DeviceInfoError: Invalid device info {'connections': {('mac', '48:e1:e9:69:6f:5c')}, 'default_manufacturer': 'Meross', 'default_name': 'Smart Garage Door (redact)', 'identifiers': {('meross_lan', 'redact')}, 'model': 'msg100 3.5.0', 'sw_version': '3.2.5', 'via_device': None} for 'meross_lan' config entry: device info needs to either describe a device, link to existing device or provide extra information.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/meross_lan/init.py", line 516, in async_setup_entry
device = api.build_device(config_entry)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/meross_lan/init.py", line 402, in build_device
device = class_type(descriptor, config_entry)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/meross_lan/switch.py", line 50, in init
super().init(descriptor, entry)
File "/config/custom_components/meross_lan/cover.py", line 495, in init
super().init(descriptor, entry)
File "/config/custom_components/meross_lan/meross_device.py", line 351, in init
super().init(
File "/config/custom_components/meross_lan/meross_device.py", line 181, in init
with self.exception_warning("DeviceRegistry.async_get_or_create"):
File "/usr/local/lib/python3.11/contextlib.py", line 155, in exit
self.gen.throw(typ, value, traceback)
File "/config/custom_components/meross_lan/helpers.py", line 588, in exception_warning
self.warning(
File "/config/custom_components/meross_lan/meross_device.py", line 470, in warning
LOGGER.warning(f"MerossDevice({self.name}): {msg}", *args, **kwargs)
^^^^^^^^^
File "/config/custom_components/meross_lan/meross_device.py", line 207, in name
return self._get_internal_name()
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/meross_lan/meross_device.py", line 578, in _get_internal_name
return self.descriptor.productname
^^^^^^^^^^^^^^^
AttributeError: 'ToggleXMixinGarageMixinMerossDevice' object has no attribute 'descriptor'
`

Which versions of HA and Python are you running it on?

Which versions of HA and Python are you running it on? It looks to me that you are running on 2023.8 beta and I guess that code is rather unstable right now... I'm having a look to possible breaking changes anyway in order to prepare and maybe update meross_lan before the beta goes to release ;)

Indeed it is the beta/dev branch version: 2023.8.0.dev20230717
I am not sure what version of Python, whatever this version of HA ships with haha

Also experiencing the same issue on the beta

Just answer the question regarding python version - it is 3.11. Support for 3.10 is dropped in HA 2023.8

I have the same issues here on 2023.8.0b1. Getting 'Failed to setup' for a MSS426 (6 gang extension) and MSS210 (single socket)

Failure with 2023.8.b as well;
Some more log data:
This error originated from a custom integration.

Logger: custom_components.meross_lan
Source: custom_components/meross_lan/helpers.py:588
Integration: Meross LAN (documentation, issues)
First occurred: 1:35:55 PM (4 occurrences)
Last logged: 1:37:14 PM

MerossDevice(Microwave): DeviceInfoError(Invalid device info {'connections': {('mac', '48:e1:e9:22:70:98')}, 'default_manufacturer': 'Meross', 'default_name': 'Smart Plug<PHONE_NUMBER>3169251h5048e1e9227098)', 'identifiers': {('meross_lan', '20062974313169251h5048e1e9227098')}, 'model': 'mss310 2.0.0', 'sw_version': '2.1.16', 'via_device': None} for 'meross_lan' config entry: device info needs to either describe a device, link to existing device or provide extra information.) in DeviceRegistry.async_get_or_create
MerossDevice(Fergus Ambient Light): DeviceInfoError(Invalid device info {'connections': {('mac', '48:e1:e9:1d:8f:3c')}, 'default_manufacturer': 'Meross', 'default_name': 'Smart Light<PHONE_NUMBER>243390814348e1e91d8f3c)', 'identifiers': {('meross_lan', '2005289271243390814348e1e91d8f3c')}, 'model': 'msl420 2.0.0', 'sw_version': '2.1.11', 'via_device': None} for 'meross_lan' config entry: device info needs to either describe a device, link to existing device or provide extra information.) in DeviceRegistry.async_get_or_create
MerossDevice(Kitchen Smart Light): DeviceInfoError(Invalid device info {'connections': {('mac', '48:e1:e9:1d:8d:4e')}, 'default_manufacturer': 'Meross', 'default_name': 'Smart Light<PHONE_NUMBER>310490814348e1e91d8d4e)', 'identifiers': {('meross_lan', '2005282443310490814348e1e91d8d4e')}, 'model': 'msl420 2.0.0', 'sw_version': '2.1.11', 'via_device': None} for 'meross_lan' config entry: device info needs to either describe a device, link to existing device or provide extra information.) in DeviceRegistry.async_get_or_create

This error originated from a custom integration.

Logger: homeassistant.config_entries
Source: custom_components/meross_lan/meross_device.py:471
Integration: Meross LAN (documentation, issues)
First occurred: 1:35:55 PM (4 occurrences)
Last logged: 1:37:14 PM

Error setting up entry Microwave (mss310) for meross_lan
Error setting up entry msl420<PHONE_NUMBER>243390814348e1e91d8f3c for meross_lan
Error setting up entry Kitchen Smart Light (msl420) for meross_lan
Traceback (most recent call last):
  File "/config/custom_components/meross_lan/helpers.py", line 586, in exception_warning
    yield
  File "/config/custom_components/meross_lan/meross_device.py", line 183, in __init__
    device_registry.async_get(ApiProfile.hass).async_get_or_create(
  File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 511, in async_get_or_create
    device_info_type = _validate_device_info(config_entry, device_info)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/device_registry.py", line 165, in _validate_device_info
    raise DeviceInfoError(
homeassistant.helpers.device_registry.DeviceInfoError: Invalid device info {'connections': {('mac', '48:e1:e9:22:70:98')}, 'default_manufacturer': 'Meross', 'default_name': 'Smart Plug<PHONE_NUMBER>3169251h5048e1e9227098)', 'identifiers': {('meross_lan', '20062974313169251h5048e1e9227098')}, 'model': 'mss310 2.0.0', 'sw_version': '2.1.16', 'via_device': None} for 'meross_lan' config entry: device info needs to either describe a device, link to existing device or provide extra information.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 388, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/meross_lan/__init__.py", line 516, in async_setup_entry
    device = api.build_device(config_entry)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/meross_lan/__init__.py", line 402, in build_device
    device = class_type(descriptor, config_entry)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/meross_lan/switch.py", line 50, in __init__
    super().__init__(descriptor, entry)
  File "/config/custom_components/meross_lan/sensor.py", line 331, in __init__
    super().__init__(descriptor, entry)
  File "/config/custom_components/meross_lan/sensor.py", line 500, in __init__
    super().__init__(descriptor, entry)
  File "/config/custom_components/meross_lan/meross_device.py", line 351, in __init__
    super().__init__(
  File "/config/custom_components/meross_lan/meross_device.py", line 181, in __init__
    with self.exception_warning("DeviceRegistry.async_get_or_create"):
  File "/usr/local/lib/python3.11/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/config/custom_components/meross_lan/helpers.py", line 588, in exception_warning
    self.warning(
  File "/config/custom_components/meross_lan/meross_device.py", line 471, in warning
    if self._trace_file:
       ^^^^^^^^^^^^^^^^
AttributeError: 'ToggleXMixinElectricityMixinConsumptionMixinMerossDevice' object has no attribute '_trace_file'

Thank you @krahabb this is working for me after updating

Home Assistant 2023.8 final broke Meross LAN for me as well. Hoping for a solution.

Home Assistant 2023.8 final broke Meross LAN for me as well. Hoping for a solution.

Update the custom component that should fix it.

Home Assistant 2023.8 final broke Meross LAN for me as well. Hoping for a solution.

Update the custom component that should fix it.

Thank you for replying so fast 😄
I deleted the Meross LAN integration and reinstalled and reconfigured it.
It sill shows the same issue:

Do I have to do anything else to update it?

@PV-Joe you need to UPDATE the component from HACS, not just remove and readd the same components from Settings

@PV-Joe you need to UPDATE the component from HACS, not just remove and readd the same components from Settings

Brillant suggestion!
I reinstalled from HACS and now Meross LAN is working with Home Assistant 2023.8.0 again 😄
i didn‘t realize there are two ways of installing the integration.
Thx for your fast response to my problem 👍


Add release action

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: danilapog:x: rootroot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Create Hail Query Stage

Port script https://github.com/populationgenomics/rare-disease/blob/initial_content/reanalysis/hail_filter_and_classify.py into this repository

Requires relevant documentation
Requires more testing
Remove GCP dependence through CloudPathLib
Remove Analysis-runner dependency where possible

If we could run this without Dataproc, that would be awesome.