OutOfMemoryError thrown from the UncaughtExceptionHandler with Gradle 8.1

Current Behavior
When we running the DependencyReportTask on our project (300+ modules) the gradle process stop on some strange OOM error, adding --stacktrace would not print the stacktrace.
I tried to use as much as possible of memory for the heap by using org.gradle.jvmargs="-Xmx56G" but the OOM happen before the heap used by gradle daemon reach 10G.
Here what we see in the logs :
...
debugUnitTestCompilationApi - API dependencies for /debugUnitTest (n)
No dependencies

debugUnitTestCompilationCompileOnly - Compile only dependencies for /debugUnitTest. (n)
No dependencies

debugUnitTestCompilationImplementation - Implementation only dependencies for /debugUnitTest. (n)
No dependencies

debugUnitTestCompilationRuntimeOnly - Runtime only dependencies for /debugUnitTest. (n)
No dependencies

debugUnitTestCompileClasspath - Compile classpath for /debugUnitTest.
<-------------> 4% EXECUTING [36s]
> :platform-api:dependenciesForAll > Resolve dependencies of :platform-api:customerSupportDebugUnitTestCompileClasspath
> :MainApplication:dependenciesForAll > Resolve dependencies of :MainApplication:benchmarkCompileClasspath
> :App:module:dependenciesForAll
> :Acquisition:common-unit-tests:dependenciesForAll
> :voip:dependenciesForAll
> :Acquisition:debug:dependenciesForAll
> :Acquisition:module:dependenciesForAll
> :fal-kotlin:falcor-samurai:dependenciesForAll > Resolve dependencies of :falcor-kotlin:falcor-samurai:debugUnitTestCompileClasspath
> :App:app:dependenciesForAll > Resolve dependencies of :App:app:customerSupportDebugUnitTestCompileClasspath
> :Acquisition:impl:dependenciesForAll

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "pool-1-thread-1"

It stop on
Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "pool-1-thread-1"

Notice the BUILD FAILED in ..s isn't even printed in the output, gradle just stop after the Exception: java.lang.OutOfMemoryError thrown...
Issue also reproduce with Gradle 8.2.1, 8.3 and latest 8.4 nightly.
It's an Android project (AGP 8.0.2). I could not reproduce the issue with project-replicator, generated project wouldn't work :(
Expected Behavior
DependencyReportTask should pass, like it was the case with Gradle 8.0.2.
Context (optional)
We're using DependencyReportTask to generate our lockfiles.
https://docs.gradle.org/current/userguide/dependency_locking.html
Steps to Reproduce
I could not reproduce the project/issue with project-replicator, generated project wouldn't work :(
Gradle version
8.1
Gradle version that used to work
8.0.2
Build scan URL (optional)
No response
Your Environment (optional)
AGP 8.0.2
Java 17.0.7-zulu
Kotlin 1.9.0

I suspect an OOM in the gradle-wrapper.jar. When I updated to 8.2.1 I used the cmd ./gradlew wrapper --gradle-version=8.1 which also update a new gradle-wrapper.jar. I can't remember how old was our gradle-wrapper.jar but since this update it OOM.

This build where we run DependencyReportTask generate a LOT of logs in the console, that could be the problem.
If I revert gradle-wrapper.jar to the version we had before, it passes.
gradle-wrapper.jar/build-receipt.properties
buildTimestamp=20130404052254+0000
commitId=e627060303f3a4bc8b9dd938730489ff3aba7613
hostname=builds.gradle.org
isSnapshot=true
javaVersion=1.7.0_02
osName=Linux
osVersion=2.6.38-16-server
project=gradle
rcNumber=
username=tcagent2
versionBase=1.6
versionNumber=1.6-20130404052254+0000

Thank you for providing a valid report.
The issue is in the backlog of the relevant team and is prioritised by them.

As a workaround, please try to change wrapper memory settings as documented here.

I'm blind but I don't see any wrapper-specific memory settings at mentioned docs.
There is just org.gradle.jvmargs. I have there this
org.gradle.jvmargs=-Xmx15g -XX:MaxMetaspaceSize=600m -XX:+HeapDumpOnOutOfMemoryError -XX:+UseParallelGC -XX:+UseCompressedOops -Dfile.encoding=UTF-8
but I'm still getting this
$ ./gradlew :app:dependencies > dependencies.txt

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "pool-1-thread-1"

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "main"

What else I should set there please?

Just found this out today, gradle works  but the wrapper fails!

Thank you for providing a valid report.
The issue is in the backlog of the relevant team and is prioritised by them.
As a workaround, please try to change wrapper memory settings as documented here.

I second @tprochazka we have the org.gradle.jvmargs= but doesn't help, this seems independent to that, OR the wrapper is ignoring those fields?

I have currently this setup
org.gradle.jvmargs=-Xmx35g -XX:MaxMetaspaceSize=1024m -XX:+HeapDumpOnOutOfMemoryError -XX:+UseParallelGC -XX:+UseCompressedOops
kotlin.daemon.jvmargs=-Xmx35g -XX:MaxMetaspaceSize=1024m -XX:+HeapDumpOnOutOfMemoryError -XX:+UseParallelGC -XX:+UseCompressedOops -Dfile.encoding=UTF-8

To make it working.


Add metrics support

I followed this steps and adopt for kubernetes with helm https://www.cockroachlabs.com/docs/stable/monitor-cockroachdb-with-prometheus.html

Templated
---
# Source: cockroachdb/templates/poddisruptionbudget.yaml
kind: PodDisruptionBudget
apiVersion: policy/v1beta1
metadata:
  name: test-release-cockroachdb-budget
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.0.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: cockroachdb
      app.kubernetes.io/instance: "test-release"
      app.kubernetes.io/component: cockroachdb
  maxUnavailable: 1
---
# Source: cockroachdb/templates/service.discovery.yaml
# This service only exists to create DNS entries for each pod in
# the StatefulSet such that they can resolve each other's IP addresses.
# It does not create a load-balanced ClusterIP and should not be used directly
# by clients in most circumstances.
kind: Service
apiVersion: v1
metadata:
  name: test-release-cockroachdb
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.0.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: cockroachdb
  annotations:
    # Use this annotation in addition to the actual field below because the
    # annotation will stop being respected soon, but the field is broken in
    # some versions of Kubernetes:
    # https://github.com/kubernetes/kubernetes/issues/58662
    service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
    # Enable automatic monitoring of all instances when Prometheus is running
    # in the cluster.
    prometheus.io/scrape: "true"
    prometheus.io/path: _status/vars
    prometheus.io/port: "8080"
spec:
  clusterIP: None
  # We want all Pods in the StatefulSet to have their addresses published for
  # the sake of the other CockroachDB Pods even before they're ready, since they
  # have to be able to talk to each other in order to become ready.
  publishNotReadyAddresses: true
  ports:
    # The main port, served by gRPC, serves Postgres-flavor SQL, inter-node
    # traffic and the CLI.
    - name: "grpc"
      port: 26257
      targetPort: grpc
    # The secondary port serves the UI as well as health and debug endpoints.
    - name: "http"
      port: 8080
      targetPort: http
  selector:
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/component: cockroachdb
---
# Source: cockroachdb/templates/service.metrics.yaml
kind: Service
apiVersion: v1
metadata:
  name: test-release-cockroachdb-metrics
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.0.5
    app.kubernetes.io/name: cockroachdb-metrics
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: cockroachdb
spec:
  type: "ClusterIP"
  ports:
  - name: "metrics"
    port: 8080
    targetPort: "http"
  selector:
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/component: cockroachdb
---
# Source: cockroachdb/templates/service.public.yaml
# This Service is meant to be used by clients of the database.
# It exposes a ClusterIP that will automatically load balance connections
# to the different database Pods.
kind: Service
apiVersion: v1
metadata:
  name: test-release-cockroachdb-public
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.0.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: cockroachdb
spec:
  type: "ClusterIP"
  ports:
    # The main port, served by gRPC, serves Postgres-flavor SQL, inter-node
    # traffic and the CLI.
    - name: "grpc"
      port: 26257
      targetPort: grpc
    # The secondary port serves the UI as well as health and debug endpoints.
    - name: "http"
      port: 8080
      targetPort: http
  selector:
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/component: cockroachdb
---
# Source: cockroachdb/templates/statefulset.yaml
kind: StatefulSet
apiVersion: apps/v1
metadata:
  name: test-release-cockroachdb
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.0.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: cockroachdb
spec:
  serviceName: test-release-cockroachdb
  replicas: 3
  updateStrategy:
    type: RollingUpdate
  podManagementPolicy: "Parallel"
  selector:
    matchLabels:
      app.kubernetes.io/name: cockroachdb
      app.kubernetes.io/instance: "test-release"
      app.kubernetes.io/component: cockroachdb
  template:
    metadata:
      labels:
        app.kubernetes.io/name: cockroachdb
        app.kubernetes.io/instance: "test-release"
        app.kubernetes.io/component: cockroachdb
    spec:
      affinity:
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
            - weight: 100
              podAffinityTerm:
                topologyKey: kubernetes.io/hostname
                labelSelector:
                  matchLabels:
                    app.kubernetes.io/name: cockroachdb
                    app.kubernetes.io/instance: "test-release"
                    app.kubernetes.io/component: cockroachdb
      # No pre-stop hook is required, a SIGTERM plus some time is all that's
      # needed for graceful shutdown of a node.
      terminationGracePeriodSeconds: 60
      containers:
        - name: db
          image: "cockroachdb/cockroach:v20.1.3"
          imagePullPolicy: "IfNotPresent"
          args:
            - shell
            - -ecx
            # The use of qualified `hostname -f` is crucial:
            # Other nodes aren't able to look up the unqualified hostname.
            #
            # `--join` CLI flag is hardcoded to exactly 3 Pods, because:
            # 1. Having `--join` value depending on `statefulset.replicas`
            #    will trigger undesired restart of existing Pods when
            #    StatefulSet is scaled up/down. We want to scale without
            #    restarting existing Pods.
            # 2. At least one Pod in `--join` is enough to successfully
            #    join CockroachDB cluster and gossip with all other existing
            #    Pods, even if there are 3 or more Pods.
            # 3. It's harmless for `--join` to have 3 Pods even for 1-Pod
            #    clusters, while it gives us opportunity to scale up even if
            #    some Pods of existing cluster are down (for whatever reason).
            # See details explained here:
            # https://github.com/helm/charts/pull/18993#issuecomment-558795102
            - >-
              exec /cockroach/cockroach
              start --join=${STATEFULSET_NAME}-0.${STATEFULSET_FQDN}:26257,${STATEFULSET_NAME}-1.${STATEFULSET_FQDN}:26257,${STATEFULSET_NAME}-2.${STATEFULSET_FQDN}:26257
              --advertise-host=$(hostname).${STATEFULSET_FQDN}
              --logtostderr=INFO
              --insecure
              --http-port=8080
              --port=26257
              --cache=25%
              --max-disk-temp-storage=0
              --max-offset=500ms
              --max-sql-memory=25%
          env:
            - name: STATEFULSET_NAME
              value: test-release-cockroachdb
            - name: STATEFULSET_FQDN
              value: test-release-cockroachdb.test-namespace.svc.cluster.local
            - name: COCKROACH_CHANNEL
              value: kubernetes-helm
          ports:
            - name: grpc
              containerPort: 26257
              protocol: TCP
            - name: http
              containerPort: 8080
              protocol: TCP
          volumeMounts:
            - name: datadir
              mountPath: /cockroach/cockroach-data/
          livenessProbe:
            httpGet:
              path: /health
              port: http
            initialDelaySeconds: 30
            periodSeconds: 5
          readinessProbe:
            httpGet:
              path: /health?ready=1
              port: http
            initialDelaySeconds: 10
            periodSeconds: 5
            failureThreshold: 2
      volumes:
        - name: datadir
          persistentVolumeClaim:
            claimName: datadir
  volumeClaimTemplates:
    - metadata:
        name: datadir
        labels:
          app.kubernetes.io/name: cockroachdb
          app.kubernetes.io/instance: "test-release"
      spec:
        accessModes: ["ReadWriteOnce"]
        resources:
          requests:
            storage: "100Gi"
---
# Source: cockroachdb/templates/job.init.yaml
kind: Job
apiVersion: batch/v1
metadata:
  name: test-release-cockroachdb-init
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.0.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: init
spec:
  template:
    metadata:
      labels:
        app.kubernetes.io/name: cockroachdb
        app.kubernetes.io/instance: "test-release"
        app.kubernetes.io/component: init
    spec:
      restartPolicy: OnFailure
      terminationGracePeriodSeconds: 0
      containers:
        - name: cluster-init
          image: "cockroachdb/cockroach:v20.1.3"
          imagePullPolicy: "IfNotPresent"
          # Run the command in an `while true` loop because this Job is bound
          # to come up before the CockroachDB Pods (due to the time needed to
          # get PersistentVolumes attached to Nodes), and sleeping 5 seconds
          # between attempts is much better than letting the Pod fail when
          # the init command does and waiting out Kubernetes' non-configurable
          # exponential back-off for Pod restarts.
          # Command completes either when cluster initialization succeeds,
          # or when cluster has been initialized already.
          command:
            - /bin/bash
            - -c
            - >-
              while true; do
              initOUT=$(set -x;
              /cockroach/cockroach init
              --insecure
              --host=test-release-cockroachdb-0.test-release-cockroachdb:26257
              2>&1);
              initRC="$?";
              echo $initOUT;
              [[ "$initRC" == "0" ]] && exit 0;
              [[ "$initOUT" == *"cluster has already been initialized"* ]] && exit 0;
              sleep 5;
              done
---
# Source: cockroachdb/templates/serviceMonitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: test-release-cockroachdb
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.0.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: cockroachdb-metrics
      app.kubernetes.io/instance: "test-release"
      app.kubernetes.io/component: cockroachdb
  namespaceSelector:
    any: true
  endpoints:
  - port: "metrics"
    path: /_status/vars
    interval: 30s
---
# Source: cockroachdb/templates/tests/client.yaml
kind: Pod
apiVersion: v1
metadata:
  name: test-release-cockroachdb-test
  namespace: "test-namespace"
  annotations:
    helm.sh/hook: test-success
spec:
  restartPolicy: Never
  containers:
    - name: client-test
      image: "cockroachdb/cockroach:v20.1.3"
      imagePullPolicy: "IfNotPresent"
      command:
        - /cockroach/cockroach
        - sql
        - --insecure
        - --host
        - test-release-cockroachdb-public.test-namespace
        - --port
        - "26257"
        - -e
        - SHOW DATABASES;

Screenshots

Metrics

Prometheus discovery

Prometheus query

@DuskEagle @jlinder I'm done

@DuskEagle @jlinder I'm done adding prometheus support

Templated
---
# Source: cockroachdb/templates/poddisruptionbudget.yaml
kind: PodDisruptionBudget
apiVersion: policy/v1beta1
metadata:
  name: test-release-cockroachdb-budget
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.1.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: cockroachdb
      app.kubernetes.io/instance: "test-release"
      app.kubernetes.io/component: cockroachdb
  maxUnavailable: 1
---
# Source: cockroachdb/templates/service.discovery.yaml
# This service only exists to create DNS entries for each pod in
# the StatefulSet such that they can resolve each other's IP addresses.
# It does not create a load-balanced ClusterIP and should not be used directly
# by clients in most circumstances.
kind: Service
apiVersion: v1
metadata:
  name: test-release-cockroachdb
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.1.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: cockroachdb
  annotations:
    # Use this annotation in addition to the actual field below because the
    # annotation will stop being respected soon, but the field is broken in
    # some versions of Kubernetes:
    # https://github.com/kubernetes/kubernetes/issues/58662
    service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
    # Enable automatic monitoring of all instances when Prometheus is running
    # in the cluster.
    prometheus.io/scrape: "true"
    prometheus.io/path: _status/vars
    prometheus.io/port: "8080"
spec:
  clusterIP: None
  # We want all Pods in the StatefulSet to have their addresses published for
  # the sake of the other CockroachDB Pods even before they're ready, since they
  # have to be able to talk to each other in order to become ready.
  publishNotReadyAddresses: true
  ports:
    # The main port, served by gRPC, serves Postgres-flavor SQL, inter-node
    # traffic and the CLI.
    - name: "grpc"
      port: 26257
      targetPort: grpc
    # The secondary port serves the UI as well as health and debug endpoints.
    - name: "http"
      port: 8080
      targetPort: http
  selector:
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/component: cockroachdb
---
# Source: cockroachdb/templates/service.public.yaml
# This Service is meant to be used by clients of the database.
# It exposes a ClusterIP that will automatically load balance connections
# to the different database Pods.
kind: Service
apiVersion: v1
metadata:
  name: test-release-cockroachdb-public
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.1.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: cockroachdb
spec:
  type: "ClusterIP"
  ports:
    # The main port, served by gRPC, serves Postgres-flavor SQL, inter-node
    # traffic and the CLI.
    - name: "grpc"
      port: 26257
      targetPort: grpc
    # The secondary port serves the UI as well as health and debug endpoints.
    - name: "http"
      port: 8080
      targetPort: http
  selector:
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/component: cockroachdb
---
# Source: cockroachdb/templates/statefulset.yaml
kind: StatefulSet
apiVersion: apps/v1
metadata:
  name: test-release-cockroachdb
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.1.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: cockroachdb
spec:
  serviceName: test-release-cockroachdb
  replicas: 3
  updateStrategy:
    type: RollingUpdate
  podManagementPolicy: "Parallel"
  selector:
    matchLabels:
      app.kubernetes.io/name: cockroachdb
      app.kubernetes.io/instance: "test-release"
      app.kubernetes.io/component: cockroachdb
  template:
    metadata:
      labels:
        app.kubernetes.io/name: cockroachdb
        app.kubernetes.io/instance: "test-release"
        app.kubernetes.io/component: cockroachdb
    spec:
      affinity:
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
            - weight: 100
              podAffinityTerm:
                topologyKey: kubernetes.io/hostname
                labelSelector:
                  matchLabels:
                    app.kubernetes.io/name: cockroachdb
                    app.kubernetes.io/instance: "test-release"
                    app.kubernetes.io/component: cockroachdb
      # No pre-stop hook is required, a SIGTERM plus some time is all that's
      # needed for graceful shutdown of a node.
      terminationGracePeriodSeconds: 60
      containers:
        - name: db
          image: "cockroachdb/cockroach:v20.1.4"
          imagePullPolicy: "IfNotPresent"
          args:
            - shell
            - -ecx
            # The use of qualified `hostname -f` is crucial:
            # Other nodes aren't able to look up the unqualified hostname.
            #
            # `--join` CLI flag is hardcoded to exactly 3 Pods, because:
            # 1. Having `--join` value depending on `statefulset.replicas`
            #    will trigger undesired restart of existing Pods when
            #    StatefulSet is scaled up/down. We want to scale without
            #    restarting existing Pods.
            # 2. At least one Pod in `--join` is enough to successfully
            #    join CockroachDB cluster and gossip with all other existing
            #    Pods, even if there are 3 or more Pods.
            # 3. It's harmless for `--join` to have 3 Pods even for 1-Pod
            #    clusters, while it gives us opportunity to scale up even if
            #    some Pods of existing cluster are down (for whatever reason).
            # See details explained here:
            # https://github.com/helm/charts/pull/18993#issuecomment-558795102
            - >-
              exec /cockroach/cockroach
              start --join=${STATEFULSET_NAME}-0.${STATEFULSET_FQDN}:26257,${STATEFULSET_NAME}-1.${STATEFULSET_FQDN}:26257,${STATEFULSET_NAME}-2.${STATEFULSET_FQDN}:26257
              --advertise-host=$(hostname).${STATEFULSET_FQDN}
              --logtostderr=INFO
              --insecure
              --http-port=8080
              --port=26257
              --cache=25%
              --max-disk-temp-storage=0
              --max-offset=500ms
              --max-sql-memory=25%
          env:
            - name: STATEFULSET_NAME
              value: test-release-cockroachdb
            - name: STATEFULSET_FQDN
              value: test-release-cockroachdb.test-namespace.svc.cluster.local
            - name: COCKROACH_CHANNEL
              value: kubernetes-helm
          ports:
            - name: grpc
              containerPort: 26257
              protocol: TCP
            - name: http
              containerPort: 8080
              protocol: TCP
          volumeMounts:
            - name: datadir
              mountPath: /cockroach/cockroach-data/
          livenessProbe:
            httpGet:
              path: /health
              port: http
            initialDelaySeconds: 30
            periodSeconds: 5
          readinessProbe:
            httpGet:
              path: /health?ready=1
              port: http
            initialDelaySeconds: 10
            periodSeconds: 5
            failureThreshold: 2
      volumes:
        - name: datadir
          persistentVolumeClaim:
            claimName: datadir
  volumeClaimTemplates:
    - metadata:
        name: datadir
        labels:
          app.kubernetes.io/name: cockroachdb
          app.kubernetes.io/instance: "test-release"
      spec:
        accessModes: ["ReadWriteOnce"]
        resources:
          requests:
            storage: "100Gi"
---
# Source: cockroachdb/templates/job.init.yaml
kind: Job
apiVersion: batch/v1
metadata:
  name: test-release-cockroachdb-init
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.1.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/component: init
spec:
  template:
    metadata:
      labels:
        app.kubernetes.io/name: cockroachdb
        app.kubernetes.io/instance: "test-release"
        app.kubernetes.io/component: init
    spec:
      restartPolicy: OnFailure
      terminationGracePeriodSeconds: 0
      containers:
        - name: cluster-init
          image: "cockroachdb/cockroach:v20.1.4"
          imagePullPolicy: "IfNotPresent"
          # Run the command in an `while true` loop because this Job is bound
          # to come up before the CockroachDB Pods (due to the time needed to
          # get PersistentVolumes attached to Nodes), and sleeping 5 seconds
          # between attempts is much better than letting the Pod fail when
          # the init command does and waiting out Kubernetes' non-configurable
          # exponential back-off for Pod restarts.
          # Command completes either when cluster initialization succeeds,
          # or when cluster has been initialized already.
          command:
            - /bin/bash
            - -c
            - >-
              while true; do
              initOUT=$(set -x;
              /cockroach/cockroach init
              --insecure
              --host=test-release-cockroachdb-0.test-release-cockroachdb:26257
              2>&1);
              initRC="$?";
              echo $initOUT;
              [[ "$initRC" == "0" ]] && exit 0;
              [[ "$initOUT" == *"cluster has already been initialized"* ]] && exit 0;
              sleep 5;
              done
---
# Source: cockroachdb/templates/ingress.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: test-release-cockroachdb-ingress
  namespace: test-namespace
  labels:
    helm.sh/chart: cockroachdb-4.1.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
spec:
  rules:
    - http:
        paths:
          - path: /
            backend:
              serviceName: test-release-cockroachdb-public
              servicePort: "http"
---
# Source: cockroachdb/templates/serviceMonitor.yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: test-release-cockroachdb
  namespace: "test-namespace"
  labels:
    helm.sh/chart: cockroachdb-4.1.5
    app.kubernetes.io/name: cockroachdb
    app.kubernetes.io/instance: "test-release"
    app.kubernetes.io/managed-by: "Helm"
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: cockroachdb
      app.kubernetes.io/instance: "test-release"
      app.kubernetes.io/component: cockroachdb
  namespaceSelector:
    any: true
  endpoints:
  - port: "http"
    path: /_status/vars
    interval: 10s
---
# Source: cockroachdb/templates/tests/client.yaml
kind: Pod
apiVersion: v1
metadata:
  name: test-release-cockroachdb-test
  namespace: "test-namespace"
  annotations:
    helm.sh/hook: test-success
spec:
  restartPolicy: Never
  containers:
    - name: client-test
      image: "cockroachdb/cockroach:v20.1.4"
      imagePullPolicy: "IfNotPresent"
      command:
        - /cockroach/cockroach
        - sql
        - --insecure
        - --host
        - test-release-cockroachdb-public.test-namespace
        - --port
        - "26257"
        - -e
        - SHOW DATABASES;

ServiceDiscovery

Scraped metrics

@DuskEagle I'am done


Send push notifications in different languages

At the moment, push notifications can only be sent in one language and don't have translations. This should be changed to reflect the current features of WordPress.

We should use the tabbed view design of pages translations for push news as well.


Support building Windows msi file

Update Makefile to build msi
Add podman.wxs to define podman.msi

Version information provided by Makefile

Add podman.bat wrapper for podman-remote-windows.exe to ensure environment
Add wix xml schemas for reference

Signed-off-by: Jhon Honce<EMAIL_ADDRESS>

13000 line XML file... oh dear

13000 line XML file... oh dear

Be afraid...  :-)

Do we end up with man pages or Windows equivalents?


Inference on a new scene

Hi, authors
Very great work. I want to infer your model in a new scene, how should I prepare the data?

If I remember correctly, we process the scene based on the motion sequence roughly using the following steps:

Transform the motion sequence to the coordinate origin.
Transform the scene accordingly.
Cut the scene into a chunk (we focus on the local region).

If you only have the scene data, you can align the scene to the coordinate origin and then cut it into a chunk. For more details, you can refer to the code here.


Add new instructors as Carpentry@UiO community members

Consequence of updated mentoring document: https://github.com/uio-carpentry/organisational/pull/102#issue-1285688247
I don't have the overview over current (new) instructors... we may also have to clarify whose task this is? The library representatives? -> add other assignees if someone else has the overview

I agree; this is a task we at the library will take on. I have added @sofgilbert to this Issue and we will fix it.
At this point in time, we might go for an instructor/helper status survey, as we did in 2019.


ObjectId is converted to a string.

I am writing an application with this connector. What the application is doing is reading a collection in from MongoDB doing some analysis on the information, and writing it back into another collection. But since the ObjectID is converted to a string, it doesn't update the correct object and just creates a new object. Is there a way to retain the ObjectID without converting it to a string?

Hi @kshahbazk,
there is no way to do that at the moment but it seems an interesting feature for next releases. We also encourage you to participate in the implementation of this feature if you feel confident with the code.
Thanks for the suggestion.

Hi @kshahbazk,
I faced the same issue and have a quick solution for this. But need to change the
source code the Spark-MongoDB.

Hi, @joohnnie , could you explain your solution for the issue? Maybe I could help with the implementation.


Mobile app and Api

Hi there, thank you for a fantastic piece of work. I will be using your app every day for some time.
It happens that I am a front-end / UI developer. I think it would be amazing to make a mobile app out of this project. How difficult would it be to enable REST API? I am a React developer, but I could contribute to making a React Native app.
Best regards.
Mateusz

Hey Mateusz, thank you I'm happy you enjoy this application.
I really appreciate your offer to help create a mobile app. Unfortunately I have very little time and energy to work on this project. I used to have much more time to devote to it but I now have other priorities. I'm sorry but I'm not able to commit to developing a REST api for this application.


test(share): add Full Node reconstruction tests

Mainly:

Improves testnet utility in share pkg
Adds a test that Full Node can reconstruct a block from Light Nodes only. The number of nodes is gotten from the paper and a special script that Mustafa shares(I will add it in a separate PR, it is useful to be in the codebase)
The test with multiple Full Node will go in a subsequent PR

Substitutes https://github.com/celestiaorg/celestia-node/pull/598
Based on #682
Closes https://github.com/celestiaorg/celestia-node/issues/600
My favourite part about these tests is that they won't require any changes if we e.g. move to a completely new protocol for Share transportation

Did you link to the right issue? #598 is a closed PR.

Is this going to be merged into #682, or does it require #682 to be merged into main first? If the latter, please convert this into a draft to avoid merging too soon.

Draft until https://github.com/celestiaorg/celestia-node/pull/682 is merged

So the main blocker here is to make tests run while being limited with 8k goroutines, which is not trivial.

Includes the code from https://github.com/celestiaorg/celestia-node/pull/815. Will be removed once it is merged

Unfortunately, it is very unlikely that we will see these tests merged with the race detector for them before upgrading to 1.19 with an unlimited race detector.

All the tests are passing reliably with go1.19beta1 with unlimited race detector. Run then 10 times in a row, now flakiness found yet

What's the plan here? Disable race detector for this test till 1.19 is released? Or wait till 1.19 is released?

I extracted the tests and disabled the race detector for them. Fully ready for review

@musalbas, added you here as a reviewer. Do we need more harness tests or is this enough? Do we need tests where there are more than two Fulls with their own subnetworks?

Ok, then I think there is nothing else to do in this PR. Testground reconstruction is planned but orthogonal to this PR.


Add documentation for endpoints

What are we going to use?

documentation in markdown files with something like docbox
auto generated with something like apidocs
...?

Closing in favor of #134


Change language to turkish fails with HTTP 500

When I try to change to Turkish tr, the respose fails with:
DoesNotExist at /api/manage/change-language/
Language matching query does not exist.

I've already made the change on the server side to include Turkish, so I'm not sure what else needs to be done to get it to work.

Have you added a language to the database? http://localhost:8000/admin/venue/language/

It should fix your problem, and I'll add a 404 code instead of 500

That did solve the problem, thank you. However, can't do manual configuration every time we wipe the system; that is error prone.
Also there are languages in settings.py: are those just ignored? If these lines are ignored, they should be removed.
Anyway, I will update the title of this issue to change it so that some file in github controls this (whether it is a configuration file or a database migration doesn't matter to me)


Error on obfuscating a DLL

Hi,
when I try to obfuscate a dll developed with Visual Studio, I get this error message:
"An error occurred during processing:
Failed to get type definitions for CreoParamLm, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=f4e4fd84ef410cf6
Cannot clean pool"
I didn't find any info searching with Google for this typology of error, do you have any idea?
Thanks in advance.

The actual error message is right above the exception message in console output, https://github.com/obfuscar/obfuscar/blob/784529c9d67a8bb16ec023237b3f1562e2cb0f0c/Obfuscar/AssemblyInfo.cs#L522

Thank you very much, I will try to solve the problem.


RoaringBitmap of small universe vs. BitSet

Hi,
I guess it makes little sense to use RoaringBitmap for a small universe, for instance 512 or 1024 at most (size of entries in a trie-structure of a temporal data store, for child-pointers).
Kind regards
Johannes

And also for storing, which records out of the 512 or 1024 are present in a data page fragment (variable sized).

Okay, just from running my unit (or more or less most of them are actually rather integration tests) I got the impression, that it's indeed way slower using RoaringBitmap (but didn't make any Benchmarks).

I think that this is addressed in the README:
This being said, there are definitively cases where attempting to use compressed bitmaps is wasteful. For example, if you have a small universe size. E.g., your bitmaps represent sets of integers from [0,n) where n is small (e.g., n=64 or n=128). If you are able to uncompressed BitSet and it does not blow up your memory usage, then compressed bitmaps are probably not useful to you. In fact, if you do not need compression, then a BitSet offers remarkable speed.

I am going to close this issue since I feel it is already addressed.


Default floating point values in single_image_random_dot_stereograms_ops.cc cause syntax error

Have I written custom code: yes
OS Platform and Distribution: Ubuntu 18.04
TensorFlow installed from: origin master
TensorFlow version: 1.9
Bazel version 0.15.2
CUDA/cuDNN version: 9.1/7.1
GPU model and memory:  NVIDIA-SMI 390.48
Exact command to reproduce: use code below in python3 script
Mobile device: N/A
 import tensorflow as tf
  vol = tf.contrib.util.make_tensor_proto([256, 256])

Import of /localhome/local/projects/lme_custom_ops/tensorflow/contrib/image/init.py causes syntax error on my system (see issue https://github.com/tensorflow/serving/issues/421).
Traceback (most recent call last):
File "main.py", line 6, in <module>
    import geometry as geometry
File "/localhome/local/projects/deep-iterative-reco/geometry.py", line 20, in <module>
    volume_origin = tf.contrib.util.make_tensor_proto([-((_volume_xy-1)/2 * _volume_spacing),-((_volume_xy-1)/2 * _volume_spacing)], tf.float32 )
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/util/lazy_loader.py", line 53, in __getattr__
    module = self._load()
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/util/lazy_loader.py", line 42, in _load
    module = importlib.import_module(self.__name__)
File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/contrib/__init__.py", line 48, in <module>
    from tensorflow.contrib import image
File "/usr/local/lib/python3.6/dist-packages/tensorflow/contrib/image/__init__.py", line 70, in <module>
    from tensorflow.contrib.image.python.ops.single_image_random_dot_stereograms import single_image_random_dot_stereograms
File "/usr/local/lib/python3.6/dist-packages/tensorflow/contrib/image/python/ops/single_image_random_dot_stereograms.py", line 27, in <module>
    "_single_image_random_dot_stereograms.so"))
File "/usr/local/lib/python3.6/dist-packages/tensorflow/contrib/util/loader.py", line 56, in load_op_library
    ret = load_library.load_op_library(path)
File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/load_library.py", line 73, in load_op_library
    exec(wrappers, module.__dict__)
File "<string>", line 28
    def single_image_random_dot_stereograms(depth_values, hidden_surface_removal=True, convergence_dots_size=8, dots_per_inch=72, eye_separation=3, mu=0,333299994, normalize=True, normalize_max=-100, normalize_min=100, border_level=0, number_colors=256, output_image_shape=[1024, 768, 1], output_data_window=[1022, 757], name=None):
                                                                                ^
SyntaxError: invalid syntax

Works again if I change the default kwargs float arguments to integer values. Reason maybe localization option (I am from Germany which uses , to indicate decimal point. E.g. 1.2 == 1,2 in Germany). Though I think I am using the US standard.
Using this code in /tensorflow/contrib/image/ops/single_image_random_dot_stereograms_ops.cc solves the problem (not using floating values).
REGISTER_OP( "SingleImageRandomDotStereograms" )
    .Attr( "T: {double,float,int64,int32}" )
    .Input( "depth_values: T" )
    .Output( "image: uint8" )
    .Attr( "hidden_surface_removal: bool = true" )
    .Attr( "convergence_dots_size: int = 8" )
    .Attr( "dots_per_inch: int = 72" )
    .Attr( "eye_separation: float = 3" )
    .Attr( "mu: float = 3333" )
    .Attr( "normalize: bool = true" )
    .Attr( "normalize_max: float = -100.0" )
    .Attr( "normalize_min: float = 100.0" )
    .Attr( "border_level: float = 0.0" )
    .Attr( "number_colors: int = 256" )

On python2 executing the following...
  Python 2.7.15rc1 (default, Apr 15 2018, 21:51:34)
  [GCC 7.3.0] on linux2
  Type "help", "copyright", "credits" or "license" for more information.
  >>> import locale
  >>> locale.setlocale(locale.LC_ALL, '')
        'LC_CTYPE=en_US.UTF-8;LC_NUMERIC=de_DE.UTF-8;LC_TIME=de_DE.UTF-8;LC_COLLATE=en_US.UTF-8;LC_MONETARY=de_DE.UTF-8;LC_MESSAGES=en_US.UTF-8;LC_PAPER=de_DE.UTF-8;LC_NAME=de_DE.UTF-8;LC_ADDRESS=de_DE.UTF-8;LC_TELEPHONE=de_DE.UTF-8;LC_MEASUREMENT=de_DE.UTF-8;LC_IDENTIFICATION=de_DE.UTF-8'

Though I compiled for python3:
Python 3.6.5 (default, Apr  1 2018, 05:46:30)
Type "copyright", "credits" or "license" for more information.

IPython 5.5.0 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.

In [1]:
...:
...: import locale

In [2]: locale.localeconv()
Out[2]:
{'currency_symbol': '',
'decimal_point': '.',
'frac_digits': 127,
'grouping': [],
'int_curr_symbol': '',
'int_frac_digits': 127,
'mon_decimal_point': '',
'mon_grouping': [],
'mon_thousands_sep': '',
'n_cs_precedes': 127,
'n_sep_by_space': 127,
'n_sign_posn': 127,
'negative_sign': '',
'p_cs_precedes': 127,
'p_sep_by_space': 127,
'p_sign_posn': 127,
'positive_sign': '',
'thousands_sep': ''}

I am using tensorflow revision 6d71d3fc659b317a38586f71ae94410ad3261f55 on Ubuntu 18.08. cuDNN 7.1, CUDA 9.1
This seems to be related: https://github.com/tensorflow/tensorflow/issues/2974

I'm gonna mark this as contributions welcome in case anyone wants to submit a PR addressing this.
@gunan do you know anything about localization or who would?

No idea, as we all use US settings, I think this is best handled by the community, who has a high chance of reproducing the problem.

Please remove the assignee, as this issue is inviting external contributions. Otherwise, remove the contributions welcome label. Thank you.

Seems to be also related to #10370
Anyway, I only have this problem with tensorflow versions >= 1.9  (1.9, 1.10)
I never had troubles with tensorflow from v1.0 - v1.8
So the following code sinppet, that reproduces the error, works in my old tensorflow environments but fails in the new one.
import tensorflow as tf
import locale
locale.setlocale(locale.LC_ALL, locale="de_AT.UTF-8")
dataset = tf.data.Dataset.from_tensor_slices([ ["a","b","c","e"]])
dataset = dataset.apply(tf.contrib.data.assert_element_shape( tf.TensorShape(4) ) )

It yields the same error as above (in tf >=1.9) when tf tries to import single_image_random_dot_stereograms and does so with the wrong floating point conversion style.
When I ran the debugger in tf 1.10 to the load_library.py file, it generates the wrong floating point style in line 61 when it calls "wrappers = py_tf.GetPythonWrappers(op_list_str)" which calls this C++ function.
Setting the locale setting of LC_NUMERIC to US style before this function call and back to the original style fixes this error for me.
However, I don't have experience with i18n, so I don't know about side effects. (I guess US style needs to be intsalled?). But a warning/ exception would be nice if the code is called with the wrong locale setting.
  import locale
  bak = locale.getlocale(locale.LC_NUMERIC)
  locale.setlocale(locale.LC_NUMERIC,"en_US.UTF-8")
  wrappers = py_tf.GetPythonWrappers(op_list_str)
  locale.setlocale(locale.LC_NUMERIC,bak)

Added a PR #22044 for the fix.

After this solution, I have still the same issue in the last version of tensorflow (1.11). Why does that happen?

@grzegorz700 the PR was only merged recently and may not be part of 1.11. Can you try with the nightly build if possible?

I'm using TensorFlow 1.12.0 and still facing the same error. Any suggestions please?
File "/home/deepakvellampalli/carla_9_3_rllib/models.py", line 7, in <module>     import tensorflow.contrib.slim as slim   File "/home/deepakvellampalli/.local/lib/python3.5/site-packages/tensorflow/contrib/__init__.py", line 57, in <module>     from tensorflow.contrib import image   File "/home/deepakvellampalli/.local/lib/python3.5/site-packages/tensorflow/contrib/image/__init__.py", line 70, in <module>     from tensorflow.contrib.image.python.ops.single_image_random_dot_stereograms import single_image_random_dot_stereograms   File "/home/deepakvellampalli/.local/lib/python3.5/site-packages/tensorflow/contrib/image/python/ops/single_image_random_dot_stereograms.py", line 27, in <module>     "_single_image_random_dot_stereograms.so"))   File "/home/deepakvellampalli/.local/lib/python3.5/site-packages/tensorflow/contrib/util/loader.py", line 56, in load_op_library     ret = load_library.load_op_library(path)   File "/home/deepakvellampalli/.local/lib/python3.5/site-packages/tensorflow/python/framework/load_library.py", line 77, in load_op_library     exec(wrappers, module.__dict__)   File "<string>", line 28     def single_image_random_dot_stereograms(depth_values, hidden_surface_removal=True, convergence_dots_size=8, dots_per_inch=72, eye_separation=, mu=, normalize=True, normalize_max=, normalize_min=, border_level=, number_colors=256, output_image_shape=[1024, 768, 1], output_data_window=[1022, 757], name=None):                                                                                ^ SyntaxError: invalid syntax
Thanks in advance!

Same here!

did someone solve this?

It happens when you also have an incompatible import statement.

@varunjammula @medard0 the PR for the fix should have been in the latest version of TensorFlow. If the issue persist (or different but similar issue), can you open a new issue with the exact steps to reproduce?

It happens when you also have an incompatible import statement.

Hi @varunjammula
Could elaborate what do you mean by 'incompatible import statement' ? I have similar issue now and I would like to understand it more.

What worked for me:
Instead of the call
import tensorflow.contrib.slim as slim

use
bak = locale.getlocale(locale.LC_NUMERIC)
locale.setlocale(locale.LC_NUMERIC,"en_US.UTF-8")
import tensorflow.contrib.slim as slim
locale.setlocale(locale.LC_NUMERIC,bak)

following the rationale set in comment https://github.com/tensorflow/tensorflow/issues/21164#issuecomment-417274023


feat(automated releases): add version bump only filter + test repo context for packages

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change
[ ] The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

PR Links and Envs

Repository
PR Link
PR Env

Monolith
Monolith PR
Monolith Env

Portal
Portal Link
Portal Env

Another Repo
Another Link
Another Env

🚀 Styleguide deploy preview ready!https://62686cba28a59b00ae2eb984--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://62686e7e41caf90094b327fb--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://62687c361640c70f0b2aea10--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://62694c39115c23378782df13--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://62694f0f41a18139d7eed609--gamut-preview.netlify.appDeploy Logs


:bug: Update migration wave form & modal styles

Resolves https://issues.redhat.com/browse/MTA-742

This is a bug that @gitdallas would probably know how to best solve. Not sure the correct PF approach to make the modal /form field css be static when the dropdowns open. Seems like there is a bottom padding on the modal that changes when there is a new "last element" present within the modal scope in the dom.

You lost the "to" between the two date inputs. Not a deal breaker, but it is noticeable.
Changing the appendTo for the date input really does help.

IMO the "to" seemed very out of place. But that is probably a @JustinXHale question.

You lost the "to" between the two date inputs. Not a deal breaker, but it is noticeable.
Changing the appendTo for the date input really does help.

IMO the "to" seemed very out of place. But that is probably a @JustinXHale question.

I agree it does seem out of place, but for PF we do use "to" centered for date and time range.


README -- PBMC

README needs a fix ... The "B" in PBMC is "blood" not "bone"

Thank you for the catch!


refactor: icon to icons for sliceheader component

SUMMARY
mirgrates the filter indicator icon to the icons component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before

after

TESTING INSTRUCTIONS
Must enable native filters and crossfiltering feature flags and go to dashboard component
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true


TODO: .vimbkp needs to be mkdired at setup

Not needed. Vim should create this itself.
On one system, /tmp was used instead. Unknown why.


Complete list of onshore wind units?

Hi @MichaelKavanagh,
this is more of a data issue but maybe you know a solution: Is there a complete list of onshore wind units and their IDs somewhere? When downloading B1610 data, the PSR Type column says “Generation” for all entries and does not differentiate between wind / solar / gas / coal... When looking at B1420 data, I see several “Wind Onshore” units but the list is incomplete. Some units (e.g. BRYBW-1 and CRGHW-1) are classified again as “Generation”. A complete listing of onshore wind units would be very helpful. Do you know if it is available in any of the APIs?
Cheers
Ben

Yeah, I've battled with this before but didn't find a satisfactory answer. Please do update me if you find one.

What I have used was https://www.netareports.com/data/elexon/ft.jsp?id=42 (this one is for wind, but you can do it for the other fuel types also) - the data from NETA -, then extract the Unit ID (the one between brackets) and then do a matching for the units mentioned as "Generation". I used VLOOKUP in Excel, but you can use whatever you prefer.

@BogdanOxera that site is gold! Thanks for the tip!

My understanding is that NETA just aggregates and displays information from Elexon, is this correct?
A list of BM Units and fuel types is available from Elexon: B1420 (https://www.bmreports.com/bmrs/?q=foregeneration/capacityperunit), with more information about specific units available in other reports. However, the PSR type is not always correct, as noted above.
I am going to close this issue as it is not a bug in this package, but feel free to keep the discussion open.

@MichaelKavanagh NETA seems to use additional sources besides Elexon. From their website:

Welcome to the NETA reports website. This service provides access to data and information on the GB electricity market utilising Elexon market data as well as data from additional sources such as APX, LEBA, Meteo Group and Spectron.

They got the PSR types of BRYBW-1 and CRGHW-1 correct, while Elexon doesn't. Thumbs up from my side!


Add a table to show differences between different backends

Is your feature request related to a problem? Please describe.
In the README, there is only a list of the differents backends.
Describe the solution you'd like
I would be nice to have a little bit of comparison between backends, like a table, to help chose which one to use when someone has no idea.
EDIT : Forgot to fill the body of the issue

It supports all UNIX and Windows terminals
https://github.com/crossterm-rs/crossterm/blob/b9c8dcdbfa39d6dbe14a73d30a89fea7883b4dcc/README.md

https://github.com/crossterm-rs/crossterm/blob/b9c8dcdbfa39d6dbe14a73d30a89fea7883b4dcc/.github/workflows/crossterm_test.yml#L19
Crossterm definitely supports MacOS.


strip trailing zeros when checking scale

Description
Scale wasn't being checked properly, 2.0 didn't count as an integer
Changes
strip trailing zeros when checking scale
enable test
Issue
Resolves #824

Change looks reasonable. My only question would be: Would it be sensible to enforce at an earlier point that BigDecimals always have trailing zeroes stripped, since (afaik) they're never useful? We could get some potential efficiency improvements if we pushed that all the way to the profile reading stage.

We could do it in coerceToBigDecimal, and get rid of lines like BigDecimal n = new BigDecimal(o.toString());.

Change looks reasonable. My only question would be: Would it be sensible to enforce at an earlier point

I'm not sure myself, either it needs to be everywhere that bigdecimals can potentially be created, and preferably somehow have this enforced.
or just in the 1 place that it matters.
but it would be a lot nicer to have it dealt with early, and never have to worry about it later in the program
🤷♂

Yeah, it's always annoying when a type gives you more freedom than you actually want. I'm happy to approve this change, in preference to solving the harder problem - let's reconsider if we find ourselves stripping zeroes in too many places.


Redirect /style-guide to zeroheight

Summary of changes
Asana Ticket: Retire /style-guide, 301 redirect to zeroheight
The style_guide_controller now redirects requests to corresponding pages on the new zeroheight design site. I also updated the test for this controller to verify that the redirects are happening correctly. A note about the zeroheight slugs, for my reviewers: they seem to function equally well with or without the page title appended to the end with hyphens, i.e. https://zeroheight.com/2fedee66c/p/43fa10 functions just as well as https://zeroheight.com/2fedee66c/p/43fa10-about, which the former redirects to. I elected to include the title but am looking for feedback in that area as to what best practice should be.

Before getting review, please check the following:

[x] Does frontend functionality render and work correctly in IE?
[x] Have we load-tested any new pages or internal API endpoints that will receive significant traffic?
[x] Are interactive elements accessible to screen readers?
[x] Have you checked for tech debt you can address in the area you're working in?
[x] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages?

(I've filled out this template to the best of my ability, this doesn't contain front-end changes so some of them are kind of n/a)

Interesting note about the title suffix, let's actually not include them. The shorter URL seems preferable and if both are equal, we probably want flexibility to change the page title without accidentally updating a URL suffix.
This is looking good to me, when you follow up with Aayesha (she's off today) can you ask her to update mbta.com/dsg vanity URL as well?

Gotcha @phildarnowsky. Will squash 👍


Throwing on async transition doesn't cancel transition

According to the Asynchronous Transitions doc

Returning a Promise from a lifecycle event will cause the lifecycle for that transition to pause. It can be continued by resolving the promise, or cancelled by rejecting the promise.

Rejecting a promise returned in a lifecycle event should cancel the transition, as it happens when returning false on some lifecycle events like onTransition and onBeforeTransition.
But rejecting the returned promise doesn't have this effect, the transition completes as if the promise was resolved correctly, which can be demonstrated with this code
const StateMachine = require('javascript-state-machine');

const stateMachine = new StateMachine({
  init: 'open',
  transitions: [
    { name: 'close', from: 'open', to: 'closed' },
    { name: 'requireInfo', from: 'open', to: 'requiresInfo' },
  ],
  methods: {
    async onClose() {
      throw new Error('failed close')
    },
    async onRequireInfo() {
      return 'transitioned to require info'
    }
  }
})

async function test() {
  console.log('stateMachine.state:', stateMachine.state)
  try {
    const result = await stateMachine.close()
    console.log('stateMachine.state:', stateMachine.state)
  } catch (error) {
    console.log('error:', error.message)
    console.log('stateMachine.state:', stateMachine.state)
  }
  try {
    const result = await stateMachine.requireInfo()
    console.log('stateMachine.state:', stateMachine.state)
  } catch (error) {

    console.log('error:', error.message)
    console.log('stateMachine.state:', stateMachine.state)
  }
}

test()

Output:
stateMachine.state: open
error: failed close
stateMachine.state: closed
error: transition is invalid in current state
stateMachine.state: closed

The code above should end up transitioning the state from open to requiresInfo, but instead it perform the close transition. There's no actual waiting on the promise, as the catch is only called after all lifecycle events trigger. Changing https://github.com/jakesgordon/javascript-state-machine/blob/0d603577423244228cebcd62e60dbbfff27c6ea3/src/jsm.js#L157 to:
                  .catch((err) => {
                    console.log('called catch')
                    this.failTransit(err);
                  })

And adding a console.log(event) right before https://github.com/jakesgordon/javascript-state-machine/blob/0d603577423244228cebcd62e60dbbfff27c6ea3/src/jsm.js#L148 shows the following output
stateMachine.state: open   # right before calling stateMachine.close()
onBeforeTransition
onBeforeClose
onLeaveState
onLeaveOpen
onTransition
doTransit
doTransit
onEnterState
onEnterClosed
onClosed
onAfterTransition
onAfterClose
onClose
called catch # here the catch is handled, no other lifecycle event should trigger while the promise is still pending
error: failed close
stateMachine.state: closed

When writing this issue I actually noticed that the problem is that there's no waiting on the resolve or reject of a promise, the other lifecycleEvents are triggered no matter what happens with the promise.

Yes.
I confirm this situation. Which is a shame.
The only solution would be to return false in on of the above mentioned callbacks.

Will this be fixed ? Is this library dead ?


mvp-cockpit: Error during execution of the blueprint

After adding a blueprint to create a new VDC and trying to execute it I get this:
Error during execution of the blueprint:\n ERROR: could not execute job:job: vdc!vdc4yves3
See repository yves03 in the Cockpit for Artilium: https://artilium.aydo2.com/ays81/ays81/Blueprints?ayspath=/optvar/cockpit_repos/yves03

I know, we looked at that one as well.

Here's the full stack trace:
[Mon28 08:57] - ...le/baselib/atyourservice81/Service.py:540  - INFO     - schedule action install on service:vdc!vdc4yves
[Mon28 08:57] - ...le/baselib/atyourservice81/Service.py:560  - INFO     - action install already in ok state, don't schedule again
/opt/jumpscale8/lib/JumpScale/data/capnp/ModelBase.py:67: UserWarning: This message has already been written once. Be very careful that you're not setting Text/Struct/List fields more than once, since that will cause memory leaks (both in memory and in the serialized data). You can disable this warning by setting the `_is_written` field of this object to False after every write.
  buff = self.dbobj.to_bytes()
[Mon28 08:57] - .../atyourservice81/AtYourServiceRepo.py:433  - INFO     - init service: service:vdc!vdc4yves
/opt/jumpscale8/lib/JumpScale/data/capnp/ModelBase.py:67: UserWarning: This message has already been written once. Be very careful that you're not setting Text/Struct/List fields more than once, since that will cause memory leaks (both in memory and in the serialized data). You can disable this warning by setting the `_is_written` field of this object to False after every write.
  buff = self.dbobj.to_bytes()
[Mon28 08:57] - .../atyourservice81/AtYourServiceRepo.py:433  - INFO     - init service: service:vdc!vdc4yves3
Error of job: vdc!vdc4yves3 (init):
*TRACEBACK*********************************************************************************
no producer g8client found. cannot continue init of service:vdc!vdc4yves3

******************************************************************************************

**** TRACEBACK ***
Traceback (most recent call last):
  File "/opt/jumpscale8/bin/ays", line 490, in <module>
    cli()
  File "/opt/jumpscale8/bin/ays", line 137, in blueprint
    repo.blueprintExecute(role=role, instance=instance, path=path)
  File "/opt/jumpscale8/lib/JumpScale/baselib/atyourservice81/AtYourServiceRepo.py", line 326, in blueprintExecute
    self.init(role=role, instance=instance)
  File "/opt/jumpscale8/lib/JumpScale/baselib/atyourservice81/AtYourServiceRepo.py", line 434, in init
    service.init()
  File "/opt/jumpscale8/lib/JumpScale/baselib/atyourservice81/Service.py", line 521, in init
    job.executeInProcess()
  File "/opt/jumpscale8/lib/JumpScale/baselib/jobcontroller/Job.py", line 177, in executeInProcess
    raise j.exceptions.RuntimeError("could not execute job:%s" % self)
JSExceptions.RuntimeError: ERROR: could not execute job:job: vdc!vdc4yves3 (init) ((type:runtime.error)

OK, now I see what the problem is, let me fix it


CUJ Testing for Beta v2 - Creator can Undo or Redo any Action They Take

Feature Description
In preparation for the Beta 2 release we would like to have validation and confirmation of the CUJ functionality detailed in
https://github.com/google/web-stories-wp/issues/1651

[x] cmd/ctrl-z should always undo my most recent action
[x]  cmd/ctrl-shift+z should always redo most recent action
[x]  alt. use redo/undo buttons

Verified in QA


error: building sdl2:x64-osx failed with: BUILD_FAILED

I'm trying to compile the code from this project: https://github.com/GPSnoopy/BelgianChocolateDuke3D
but I'm getting this error at the end of the process, I'm on macOS Sonoma:
error: building sdl2:x64-osx failed with: BUILD_FAILED
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+sdl2
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[sdl2]+Build+error
Include '[sdl2] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8
vcpkg-scripts version: 14e7bb4ae 2022-05-10 (1 year, 7 months ago)
What could be?

vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8
vcpkg-scripts version: 14e7bb4 2022-05-10 (1 year, 7 months ago)
What could be?

I don't know. But I would suggest trying the last version, not last year's version.

How do I update vcpkg to the latest version on macOS?

How did you get it?
Assuming you cloned the master branch from this git repo, you do
git pull
./bootstrap-vcpkg.sh

Otherwise start from scratch:
https://github.com/microsoft/vcpkg/#quick-start-unix

I did a clean reinstallation of vcpkg and I'm on the latest version, also download the packages that the project needs, however, I noticed that the code downloads the 2022 version when compiling and gives the aforementioned error...
I'm going crazy, I compiled this same code on Ubuntu and I had no problems.
Any other suggestions as to what might be?

the code downloads the 2022 version when compiling

https://github.com/GPSnoopy/BelgianChocolateDuke3D/blob/6826682f43d94f27117a8570c4fc058ede9c236a/vcpkg_macosx.sh#L8
That is not vcpkg code. Remove that line. Or find another commit that works for you. Or convert that project to manifest mode.

Thanks for the help, I removed the line and the first process showed no errors.
However, when compiling the game files it shows this error:
CMake Error at build/vcpkg.macosx/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
Could not find a package configuration file provided by "SDL2-mixer" with
any of the following names:
SDL2-mixerConfig.cmake
sdl2-mixer-config.cmake

Add the installation prefix of "SDL2-mixer" to CMAKE_PREFIX_PATH or set
"SDL2-mixer_DIR" to a directory containing one of the above files.  If
"SDL2-mixer" provides a separate development package or SDK, be sure it has
been installed.
Call Stack (most recent call first):
CMakeLists.txt:65 (find_package)
I'm about to give up

In July, sdl-mixer's CMake config changed, so additional changes are required to the project.
You can try to change CMakeLists.txt line 65-66:
-	find_package(SDL2-mixer CONFIG REQUIRED)
-	set(SDL2_ALL_LIBRARIES SDL2::SDL2main SDL2::SDL2-static SDL2::SDL2_mixer)
+	find_package(SDL2-mixer NAMES SDL2_mixer CONFIG REQUIRED)
+	set(SDL2_ALL_LIBRARIES SDL2::SDL2main SDL2::SDL2-static $<IF:$<TARGET_EXISTS:SDL2_mixer::SDL2_mixer>,SDL2_mixer::SDL2_mixer,SDL2_mixer::SDL2_mixer-static>)

Thank you very much for all your help friend, I made the changes to the lines and apparently the code compiled, with a few warnings, however, the bin folder is empty and the compilation did not generate any executables.
Any ideas what it might be?

This not vcpkg issue. And please use the latest vcpkg. :)

We hope your question was answered to your satisfaction; if it wasn't, you can ping me with more info and I will reopen.


Plugin files aren't being updated

About
Plugin files (vehicle data, new config.yml etc.) aren't being saved in the newest dev version (to be found in the branch 2.5.0) - hence new vehicles aren't saved as well and can't be used.

Minecraft version: 1.17.1 (and possibly other versions too)
Server software: Paper
Plugin version: 2.5.0-dev9

Note: This does not occur in 2.4.3.
When and why?
All the time (when updating - config isn't updated; when driving - fuel isn't saved; when getting vehicles from /vehicle menu - aren't saved and thus can't be placed or driven)...
Documentation
No photos necessary, self-explanatory.

bump

Try it on the latest version, if everything works just blame it on an ancient version of Minecraft.

My obvious suggestion would be to save this data in a database instead of in a yaml file, much more reliable.

After reports, this issue has been found still present in 2.5.0-pre1.

I'm pretty sure this is fixed in my PR
#141

This happened because the plugin wasn't able to determine vehicle price, my PR fixes this by getting it from skin data


Exports are empty after importing modified export?

Hi.
This ties into - https://github.com/helloworld1/FreeOTPPlus/issues/72
I've noticed if I perform an export using either available format, and then modify it with updated labels/issuers, it imports perfectly fine as expected - but then when I try to export in either format, the output file is empty / 0bytes in size.

This seems to have resolved itself on further exports.


Add tod config set-spinners

Not going to do this one, as it is a bit of a niche function in the config. Going to mostly focus on timezone and token.


UAT | View hearings for judge has stopped working

https://github.com/user-attachments/assets/4b68ef6c-51e0-4a53-8f0f-34f160834a1f

View_Hearing_Judge.zip
Tested in QA Working fine


[G2M] Plotly - adjust legend styling to Cox design

Changes:
Plotly - Legend

changed position of label in legend & styling to fit with Figma design

Figma design:

Without fix in Cox app:

With fix in Widget Studio:

Looks good. The text for the legend appears a bit smaller in proportion to the graph, is it because the scaling is different in widget studio vs cox app?

Yes, in Widget Studio in Editing mode, the chart or map area extends with the control panels on the side (something we should perhaps look into later), that's why the font size looks smaller in widget-studio than in the app. I took the screenshot from the editing mode of the widget.


New chapters and all Excel files

add code for the new chapters and all the Excel files previously in the .gitignore

Closed so the newer one with feedback from TRs on Chapter 7 can be included


[Bug] UWP Toasts always show up in the top left corner

IF YOU DON'T ANSWER THIS TEMPLATE - THE BOT WILL AUTOMATICALLY CLOSE YOUR ISSUE!
Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[ ] iOS
[ ] Android
[x] UWP
[ ] .NET Standard

Version of Library
<IP_ADDRESS>0
Version of OS(s) listed above with issue
Windows 10
Steps to Reproduce

Instantiate toast using ToastConfig. Whatever position is set is ignored.

        var toastConfig = new ToastConfig("message");
        ToastConfig.DefaultPosition = ToastPosition.Bottom;
        toastConfig.BackgroundColor = System.Drawing.Color.FromArgb(48, 66, 105);
        toastConfig.SetDuration(2000);
        UserDialogs.Instance.Toast(toastConfig);

Expected Behavior
Toast appears at the bottom of the page as it does with Android and iOS
Actual Behavior
Toast appears in top left corner ignoring both default positioning and explicit position settings

This is the intended behaviour for UWP


Replace bff admin client with store client

Scope of changes
Previously the BFF was using its own authenticated client to connect to the Admin API in order to retrieve data from GDS. However this relied on the BFF having to create its own tokens for authenticating with the Admin API. This PR tries a different approach in the direction we've been taking with the recent BFF PRs, which allows the BFF to connect to the trtl database directly in order to retrieve the GDS records.
This involved a bit of refactoring, the Admin client was completely removed in favor of the generic store client. The BFF test suite has also been changed up a bit (it now requires running some trtl bufconn servers since we are directly interacting with the GDS records rather than the client mock).
SC-8655
Type of change

[ ] bug fix
[ ] new feature
[ ] documentation
[x] refactoring

Acceptance criteria
This should not change the overall behavior of the BFF except that the configuration will have to be updated again.
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[x]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report
Base: 43.99% // Head: 39.39% // Decreases project coverage by -4.59% :warning:

Coverage data is based on head (674c69b) compared to base (71cfd73).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   43.99%   39.39%   -4.60%
==========================================
  Files         613      156     -457
  Lines       22734     2452   -20282
  Branches     1372      624     -748
==========================================
- Hits        10002      966    -9036
+ Misses      11432     1310   -10122
+ Partials     1300      176    -1124

Flag
Coverage Δ

unittests
39.39% <ø> (-4.60%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...s/CertificateReview/BasicDetailsReview.stories.tsx

...ds-user-ui/src/components/MissingRequire/index.tsx

web/gds-user-ui/src/theme/breakpoints.ts

...rc/components/Modal/ConfirmationResetFormModal.tsx

web/gds-user-ui/src/components/StatCard/index.tsx

web/gds-user-ui/src/utils/constants.ts

...mponents/NeedsAttention/NeedsAttention.stories.tsx

web/gds-user-ui/src/modules/start/index.tsx

...ithub.com/trisacrypto/directory/pkg/trtl/backup.go

...com/trisacrypto/directory/pkg/gds/certman/certs.go

... and 448 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


class-no-dup

Coverage increased (+0.003%) to 99.793% when pulling 5bce351a0f3875260997dae9fab6425056284292 on Genability:class-no-dupe into 8bce3909ac7184e2d64ab6c669aa437a9479e837 on htmllint:master.

Thanks!


Fasta doesn't emit error or warning for field overriden by method

E.g.:
class C {
var foo;
}

class D extends C {
void foo() {}
}

No error or warning from Fasta.
Also the reverse is allowed:
class C {
void foo() {};
}
class D extends C {
var foo;
}

No error or warning here either.

@kmillikin - I bumped this to Beta 3.  Can you move to Beta 4 or Dart 2 if one of those is more appropriate?

We have not implemented (all) override detection yet, so this is an instance of the broader issue.  I'm moving it to the next mileston (Dart2 stable) where all the other issues with incorrect code are going.

Duplicate of issue #31850.  Fixed in 8f6c6c2a8edd514cdb6533541189a6572318facd.


[bn] Localization of uid.md

localised it in bengali #45729

@Noblesse013 Please fix them

@Noblesse013 Please fix them

i did . please check if more changes is required or not!

/lgtm

/label tide/merge-method-squash


Encryption key problem

Description
Whenever tries to play on Hianime it says "Can't retrieve encryption key".
The website is working perfectly fine.
Provider
HiAnime
Reproduction steps

Go to HiAnime
Try to stream any content
It shows error

Operating system
Android TV
Logs
No response
Please confirm the following

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] If related to a provider, I have checked the site and it works, but not the app.

I had something like this too, normally it sould be 100% fixed on Release 1.7.0


Release/snowplow fractribution/0.1.0

Description & motivation
Add support for Snowflake
Checklist

[x] I have verified that these changes work locally
[x] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)
[x] I have raised a documentation PR if applicable (Link here if required)

Release Only Checklist

[x] I have updated the version number in all relevant places
[x] I have update the Github pages dbt docs
[x] I have updated the CHANGELOG.md

Thanks for looking more into the overall code as well, Ryan! I have added a yml for the macros and added exception handling for the potentially missing variable, then replaced the dbt docs as well. For the remaining topics I think we can wait until the next release as it will most likely be about adapter support changes (there will be even more things to harmonise in this regard) and also more time to think them through.


add href to svg

is it possible to add a link to the page in the html/markdown code
![https://co2birth.date Shield for 1982-01-01.](https://co2birth.date/shields/1982-01-01.svg)

and
<img src="https://co2birth.date/shields/1982-01-01.svg" alt="https://co2birth.date Shield for 1982-01-01." />

or in the svg source itself?
https://github.com/co2birthdate/website/blob/master/components/shield.js
would be cool if it linked to the specific date page

hi, could you elaborate more on the issue?

what is the current behavior?

what is the expected behavior?

where in the codebase it's located?


Switched to more robust parsing of start-date of recurring events

Removed simple date-parser and switched start-date parsing for recurring events to the more robust parser.

Hi @ahaarrestad, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@ahaarrestad, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;

hi @ahaarrestad can you state why this change is important and have an issue created? I think there should also be a unittest added to clarify the expected parsing result.

I've added issue https://github.com/OfficeDev/ews-java-api/issues/169 to explain the problem. I'll look into a couple of unit-tests to make sure that nothing has been broken by moving to the more robust date-parser.

I will rewrite the pull-request a bit to make sure we don't break anything. The parsing ended up an hour or two off. I'll add the appropriate unit-tests and a fix to make it all ok again.

Rewrote the pull-request and added a simple test for parsing dates

I have extended the unit-tests to verify parsing of a couple of simple examples.

I have added some formal suggestions for handling the test. As I saw you removed the old parsing method. Maybe it could be useful to just declare it as deprecated?

I'll update the headers and javadoc. We do not need to deprecate the methode, since it was not used outside the api (protected) and I have changed the only method calling it from within the api. Agree?

I have updated the pull-request as we have discussed. Please review the changes. Anything more we should change before merging?

any more changes we need to address?

fixed merge-conflict

anything more we should do regarding this pull request?

@ahaarrestad thanks for your work.
If no one else has any comments to adress we are fine with this I think. Maybe you can squash the unnecessary commits only leaving the ones relevant for understanding the flow (Codechanges seperated from Tests for instance)

I'd like to review this one too. This date parse routine is quite a crucial part of the library which has contained several bugs before. I'll review these changes ASAP.

I'm working on a rebase / squash. something went wrong.... I'll be right back :-)

can anybody please reopen this pull-request?

@ahaarrestad Your branch currently doesn't contain any new commits over the OfficeDev/ews-java-api master branch.

If you need any help, I'm on Gitter.

Do you want me to open a new pull-request or can this one be re-opened?

You need to commit on the branch this PR is connected with. I'll reopen it then.

Commits made earlier today.

An alternative approach: https://github.com/eveoh/ews-java-api/compare/fix-date-parsing?expand=1

I was wondering that this PR is against your master branch maybe thats the cause of the problem while it cannot be reopened? seen here. Maybe just create a new PR. @evpaassen the alternative approach has no tests included.

@serious6 http://stackoverflow.com/questions/5601730/should-private-protected-methods-be-under-unit-test

It was a mistake to use my head-branch. Won't do that next time :-)

regarding the tests: testing protected methods through public methods is ok, but might be tricky. Sometimes you can verify a method better if you test it separately.

@evpaassen I think the valid argument for providing tests should be to test a (perhabs important) behavior rather then an implementation detail. The test should underline the expected behavior of the methods and will help us to avoid exceptions in the future. One of the argument in the post you mentioned is that these methods would be covered by tests at higher level. This may be true for projects that already have large test-suites which we really dont have by now. @ahaarrestad I leave it up to you if you want to provide tests for the methods changed or if you want to write tests for the calling methods :-)

@serious6 The real problem is that the method shouldn't be protected. I'm creating tests for this method a.t.m.


[genesis][breaking] un-revert previous attempt to integrate discovery in genesis

looks good besides my confusion

the validator genesis config for CT is also not randomized currently. talking with @ankushagarwal tomorrow about actually implementing this.
see

https://github.com/libra/libra/blob/master/docker/validator-dynamic/docker-run-dynamic.sh#L36
https://github.com/libra/libra/blob/master/config/config-builder/src/main.rs#L297
https://github.com/libra/libra/blob/master/config/config-builder/src/validator_config.rs#L130
https://github.com/libra/libra/pull/3294/files#diff-1625684a48bef45fe806419650a0ac31R156

so the validator (and now full node) configs are just using placeholders in CT

:umbrella: The latest upstream changes (presumably c37682e7a6379ab0dfb05d3d302ec7b238d4324b) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra r=davidiw

:pushpin: Commit 54bc5ea has been approved by davidiw

:hourglass: Testing commit 54bc5ea58a8770f69a5ae841f682b8cb2ff9bedf with merge 6badf0e8b3e0e325eee14d120782ab38ad1ecb0a...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing 6badf0e8b3e0e325eee14d120782ab38ad1ecb0a to master...


Running http2 server without TLS connection?

Can you tell me a way to create a http2 server without tls connection?

https://github.com/labstack/echox/blob/master/website/content/cookbook/http2.md

Hi @adithya66
i think tls connection is mandatory. But in cookbook tell that how to make own TLS Certificate.
https://www.ssl.com/article/an-introduction-to-http2/

I'm closing this old issue.
How to start HTTP/2 Cleartext Server can be found in https://echo.labstack.com/guide/customization/
import "golang.org/x/net/http2"

s := &http2.Server{
  MaxConcurrentStreams: 250,
  MaxReadFrameSize:     1048576,
  IdleTimeout:          10 * time.Second,
}
e.Logger.Fatal(e.StartH2CServer(":1323", s))


Support for volatile keyword

https://msdn.microsoft.com/en-us/library/x13ttww7.aspx?f=255&MSPPError=-2147217396
Related to forum thread:
http://forums.bridge.net/forum/community/help/3288-volatile-keyword-support
Expected
// should compile, but be ignored as volatile is not relevant in the JavaScript world.

Actual
// Compiler error
// Predefined type 'System.Runtime.CompilerServices.IsVolatile' is not defined or imported

Steps To Reproduce
http://deck.net/b3b85f8e79f76a9bdde624dfa81aded8
class VolatileTest
{
    public volatile int i;

    public void Test(int _i)
    {
        i = _i;
    }
}

@geoffreymcgill, We don't have threads yet though.

@michaelcheers, Yes, we will get code with volatile keyword compiled.


Change group chat title

Is it possible to extend the API to change group chat titles?
Here's the message_batch form data sent when updating a group chat title:
message_batch[0][action_type]: ma-type:log-message
message_batch[0][author]: MY_ID
message_batch[0][author_email]:
message_batch[0][coordinates]:
message_batch[0][is_filtered_content]: false
message_batch[0][is_forward]: false
message_batch[0][is_spoof_warning]: false
message_batch[0][is_unread]: false
message_batch[0][log_message_data][name]: NEW_TITLE
message_batch[0][log_message_type]: log:thread-name
message_batch[0][manual_retry_cnt]: 0
message_batch[0][message_id]: MESSAGE_ID
message_batch[0][source]: source:chat:web
message_batch[0][source_tags][0]: source:chat
message_batch[0][status]: 0
message_batch[0][thread_fbid]: THREAD_FBID
message_batch[0][thread_id]:
message_batch[0][timestamp]:<PHONE_NUMBER>745
message_batch[0][timestamp_absolute]: Today
message_batch[0][timestamp_relative]: 23:32
message_batch[0][timestamp_time_passed]: 0

The important line seems to be this:
message_batch[0][log_message_data][name]: NEW_TITLE

And here are the differences between message_batch[0] when sending a message and when changing chat title;
--- user_message
+++ title_change
-message_batch[0][action_type]: ma-type:user-generated-message
+message_batch[0][action_type]: ma-type:log-message
 message_batch[0][author]: MY_ID
 message_batch[0][author_email]:
-message_batch[0][body]: MSG_BODY
 message_batch[0][coordinates]:
-message_batch[0][force_sms]: true
-message_batch[0][has_attachment]: false
-message_batch[0][html_body]: false
 message_batch[0][is_filtered_content]: false
 message_batch[0][is_forward]: false
 message_batch[0][is_spoof_warning]: false
 message_batch[0][is_unread]: false
+message_batch[0][log_message_data][name]: NEW_TITLE
+message_batch[0][log_message_type]: log:thread-name
 message_batch[0][manual_retry_cnt]: 0
 message_batch[0][message_id]: MESSAGE_ID
-message_batch[0][source]: source:titan:web
+message_batch[0][source]: source:chat:web
+message_batch[0][source_tags][0]: source:chat
 message_batch[0][status]: 0
 message_batch[0][thread_fbid]: THREAD_FBID
 message_batch[0][thread_id]:
 message_batch[0][timestamp]:<PHONE_NUMBER>745
 message_batch[0][timestamp_absolute]: Today
 message_batch[0][timestamp_relative]: 23:32
 message_batch[0][timestamp_time_passed]: 0
-message_batch[0][ui_push_phase]: V3

Yes it's definitely possible! We're working on it. Thanks for the package info, that really helps.

Hey @jackwilsdon, is this something like what you're looking for?
14345129967c68ccc7ee226c3718271bb6b0a7a0

Looks good. Doesn't seem to be available on NPM which is odd. Downloaded it via NPM, got 0.1.5 (latest) but the code for setTitle is missing. Had to clone the repo manually.
Also is there a way to monitor events happening in chat? Such as people joining/leaving or the bot leaving a chat?

Awesome! We just wanted to get your approval. We'll look into listening to those events and get back to you. Can you create other issues for those?

Issue resolved, thanks!


Clean up comments

Code is over-commented. Especially remove things like "uncomment this code to get different behavior".

This was done during the update to EIP20.


Question: Would this work with AWS RDS?

Would this work on mySQL (or MariaDB) database's hosted on AWS RDS?

Yes I believe so. I haven't run shift on either of those specifically, but as long as pt-osc works shift should be fine.

Great, I'll try it out on a VM in the coming days and report back, in case others are curious in the future

Awesome, let me know how it goes

@gordonmurray any luck?

I'm testing this with RDS but still not sure which file I should edit to list DB instances and what is the purpose and use of cluster drop down.


Add an option to attach link to the generated badge

Currently, the generated markdown syntax for the Peerlist badge doesn't contain a link. Let's add an option to attach the link to the Peerlist profile to it.

Quick start

Try it out here: peerlist-readme-badge.netlify.app
Follow the below syntax to add the link to the Peerlist profile

[![Peerlist](https://peerlist-readme-badge.herokuapp.com/api/vinitshahdeo?style=flat-square)](https://peerlist.io/vinitshahdeo)

Local development

The react app is available inside the client/ directory in the feature/web-app. Try it out here: peerlist-readme-badge.netlify.app

Follow the commands below to build locally 👇
git checkout feature/web-app
cd client
npm install
npm run start

I am interested in this issue. please assign it to me

Sure @ramdhanihendrie. Assigning this to you.

I am interested in this issue please assign it to me

@ramdhanihendrie @FreemRL - please take a look at #30


Using vue-router

I'm trying to use the cue-router module to switch components thus I have the following.
main.js
import Vue from 'vue'
import Resource from 'vue-resource'
import Router from 'vue-router'
import App from './components/app'
import Intro from './components/intro'

Vue.use(Resource)
Vue.use(Router)

const route = new Router()

// Pointing routes to the components they should use
route.map({
  '/': {
    component: Intro,
    subRoutes: {
      'app': {
        component: App
      }
    }
  },
  '/app': {
    component: App
  }
})

// Any invalid route will redirect to home
route.redirect({
  '*': '/app'
})

route.start(Intro, '#section')

in my intro.vue file I have
<template>

Create your MIA

Enter

</template>

I have in my index.html

        <router-view></router-view>

However when I click on the anchor link....the has changes cut not the DOM content. I'm not sure why though

Since this is neither a bug or a feature request, I recommend posting your question on either the forum or the Gitter chat.

i'm pretty sure that this has been sorted out in the many months since, however i ran into this problem and hit this post. i've made a gist here of a set up with this template https://gist.github.com/maxmckenzie/6a35c578be703fdc66556b468a2b3237 Basically i did not like the idea of pulling all of the imports into the main.js the code here still uses the App.js to load in components. I've not tested it with multiple routes just with home, but hopefully it'll help


fix: fallback to address on ENS timeout

Description
Spotted while offline. When trying to get the reverse resolution for an address, ENS will timeout when offline and we do not gracefully handle this, the User Menu just shows "Metamask" (I didn't test it with other wallets):

Now, we don't have offline capabilities in the app to the extent that this fix would be useful when offline, but it's nice to know that any timeout to ENS reverse lookups - for any reason - will be gracefully handled.
Notice
Before submitting a pull request, please make sure you have answered the following:

[ ] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk
We should do some regression testing to make sure that the user menu doesn't break in other circumstances because of this.
Testing

Go offline
Run the app and connect to your wallet
Current account's address should be displayed

Screenshots (if applicable)

Is the problem with the original code that there wasn't a catch call in case of error?

Is the problem with the original code that there wasn't a catch call in case of error?

Yeah precisely! It throws only in the case of a network error.


downgrade vue-template-compiler

Per https://github.com/villeristi/vue.js-starter-template/issues/12

Thx for the PR! This got fixed in latest version0.9.1 & doesn't need downgrading anymore.


GEODE-8396: Fixing NullPointerException in create jdbc-mapping command

Fixed the determination of partitioned region in CreateMappingCommand#createAsyncQueue.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[X] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[X] Is your initial contribution a single, squashed commit?

[X] Does gradlew build run cleanly?

[X] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@DonalEvans Thanks for the review.


iframe

Is that weird iframe supposed to be the app?

Yes, pretty much.  It used to be a full admin dashboard.  You can just ignore the broken dashboard.  I am opening up an issue to fix the default page.  Thanks for checking in on this.


Re-enable SRML tests

The SRML tests were disabled in #1921 as the SRML website is currently undergoing extensive maintenance.
This issue shall serve as a reminder to re-enable the SRML tests when the website is up and running again.

The SRML website has changed from solardat.uoregon.edu to solardata.uoregon.edu. Thus, the get_srml function is currently not working. I am waiting to correct this issue, as there is a good possibility that the file structure will change in the near future. In the meantime, it's possible to get data by changing the URL in the get_srml function, as shown below:
    df, meta = pvlib.iotools.get_srml(
        station='HE',
        start='2020-06-01',
        end='2020-06-30',
        url='http://solardata.uoregon.edu/download/Archive/')


[Feature Addition]: Web Application for American Sign Language Detection

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : [Feature Addition]: Web Application for American Sign Language Detection
:red_circle: Aim : The aim is to create a web application with the best accuracy scored existing model present /developed in the Model folder of the project.
:red_circle: Dataset : N/A
:red_circle: Approach : Try to create a Flask/React app.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Email ID :
Participant ID (if applicable):
Approach for this Project :
What is your participant role? (Mention the Open Source program)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Full name :Rishita Chourey
GitHub Profile Link : https://github.com/RishitaChourey
Email ID<EMAIL_ADDRESS>Approach for this Project : Try to create a flask app for the american sign language model
What is your participant role? GSSoC'24 contributor
I would like to work on this.Please assign me this issue

Cool. Make sure you use the existing project's model, dataset for implementing the web app as this an addition to the existing project structure. Here is the existing project, American Sign Language Detection.
Follow this project structure,
Project Dummy
|- Dataset
  |- dataset.csv
  |- README.md
|- Images
  |- img1.png
  |- img2.png
  |- img3.png
|- Model
  |- project_dummy.ipynb
  |- README.md
|- Web App
  |- app.py
  |- templates
  |- demo.mp4
  |- README.md
|- requirements.txt

Here is a project which already deployed using the Web App, Brain Tumor Detection
Looking forward to hearing from you @RishitaChourey

Full name : Adhithyan vp
GitHub Profile Link : Adhivp
Email ID<EMAIL_ADDRESS>Participant ID (if applicable):
Approach for this Project : Will make a Flask app for the same, Will make a simple flask app to try out the model and will be easily deployable in any deployment platform
What is your participant role? (Mention the Open Source program) GSSoC'24 contributor

Cool. Make sure you use the existing project's model, dataset for implementing the web app as this an addition to the existing project structure. Here is the existing project, American Sign Language Detection.
Follow this project structure,
Project Dummy
|- Dataset
  |- dataset.csv
  |- README.md
|- Images
  |- img1.png
  |- img2.png
  |- img3.png
|- Model
  |- project_dummy.ipynb
  |- README.md
|- Web App
  |- app.py
  |- templates
  |- demo.mp4
  |- README.md
|- requirements.txt

Here is a project which already deployed using the Web App, Brain Tumor Detection
Looking forward to hearing from you @RishitaChourey

@Adhivp please go through the structure and requirements. Are you up for this?

Yeah ok

I feel like this is level 3 as I will be trying to deploy and also have to work with camera , what is your take on this @abhisheks008 ?

Initially all the issues are being tagged as Lavel 2, after judging the quality of the pull request/contribution it can be upgraded to Level 3. No issues with that.
Assigning this issue to you @Adhivp

ok @abhisheks008

@abhisheks008 Should I make a image uploader kind of website , where we can upload image of the hand and then it will return the classification / should I make a live webcam where live predictions will come.

@abhisheks008 Should I make a image uploader kind of website , where we can upload image of the hand and then it will return the classification / should I make a live webcam where live predictions will come.

Yes a Flask app will be enough


Add gsutil example script for syncing data to target bucket

This issue outlines the need for an example script to be used with gsutil, a common way of interfacing with Cloud Storage buckets. A focus should be placed on making this script align with the Google Cloud resources of this template.

This was added via the merge of #9


Avoid 3 second limit to acknowledge slack calls

Fixes an issue that was moved to the composer repo: https://github.com/microsoft/BotFramework-Composer/issues/6484
Description
Execute the bot logic asynchronously so that we can acknowledge the slack http call in less than 3 seconds, otherwise slack will start retrying the call basically rendering the bot unusable.
Specific Changes

-Created a method for processing all activities with a proactive message.
-Calling that method without awaiting it instead of awaiting RunPipelineAsync

Closing, custom adapters have been moved to community.