require instead of import

I'd like to use this babel plugin with require declarations and it doesn't seem to be working.
require('icon.svg')

I'm getting the usual error SyntaxError: Unexpected token < that is when the plugin is not there

I'm getting the same. Only import syntax seems to work. Any direct way to parse require as well?

The plugin looks specifically for imports: https://github.com/kesne/babel-plugin-inline-react-svg/blob/master/src/index.js#L19
I use ES Module Syntax in all of my projects, so I haven't bothered to add support for require. I would happily accept a PR that did though!

I've made it (miraculously) work for myself here.
I'm also using Webpack/TypeScript (those guys where the ones changing the import syntax to require in the first place), and they compile the code expecting an ES6 module structure. To match that, I changed how the SVG function is returned, so that it's within an object's default property, as you can see below.
var default_avatar_svg_1 = function () {
    function default_avatar_svg_1(props) {
        return React.createElement("svg", (0, _extends3.default)({
            version: "1",
            xmlns: "http://www.w3.org/2000/svg",
            width: "21.333",
            height: "21.333",
            viewBox: "0 0 16.000000 16.000000"
        }, props), React.createElement("path", {
            d: "…"
        }));
    }

    return {
        default: default_avatar_svg_1
    };
}();

Thus, I haven't created a PR here.
Although it works, I'm not particularly proud of the whole thing. It's also the first time I fiddle within these three technologies, so I'm sure I might have done something stupid there. If any of you knows anything that could help me there, please do let me know!

+1 Because this would allow to import a complete folder with require.context.


manage.py migrate fails

Ahoj,
v nové verzi mi to hází tohle:
(seeder) bash-4.2$ ./Seeder/manage.py migrate
Traceback (most recent call last):
  File "./Seeder/manage.py", line 17, in <module>
    execute_from_command_line(sys.argv)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/management/__init__.py", line 367, in execute_from_command_line
    utility.execute()
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/management/__init__.py", line 359, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/management/base.py", line 294, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/management/base.py", line 342, in execute
    self.check()
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/management/base.py", line 374, in check
    include_deployment_checks=include_deployment_checks,
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/management/commands/migrate.py", line 62, in _run_checks
    issues.extend(super(Command, self)._run_checks(**kwargs))
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/management/base.py", line 361, in _run_checks
    return checks.run_checks(**kwargs)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/checks/registry.py", line 81, in run_checks
    new_errors = check(app_configs=app_configs)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/checks/urls.py", line 14, in check_url_config
    return check_resolver(resolver)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/core/checks/urls.py", line 24, in check_resolver
    for pattern in resolver.url_patterns:
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/utils/functional.py", line 35, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/urls/resolvers.py", line 313, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/utils/functional.py", line 35, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/opt/virtualenv/seeder/lib/python3.4/site-packages/django/urls/resolvers.py", line 306, in urlconf_module
    return import_module(self.urlconf_name)
  File "/opt/virtualenv/seeder/lib64/python3.4/importlib/__init__.py", line 109, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 2254, in _gcd_import
  File "<frozen importlib._bootstrap>", line 2237, in _find_and_load
  File "<frozen importlib._bootstrap>", line 2226, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 1200, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 1129, in _exec
  File "<frozen importlib._bootstrap>", line 1471, in exec_module
  File "<frozen importlib._bootstrap>", line 321, in _call_with_frames_removed
  File "/opt/Seeder/Seeder/urls.py", line 20, in <module>
    from www import views as www_views
  File "/opt/Seeder/Seeder/www/views.py", line 39
    **super().get_context_data()
     ^
SyntaxError: invalid syntax

Mas stary python - ja mam Python 3.5.2

Hele, doteď se jelo na 3.4, 3.5 není v repozitářích CentOS, 3.5 musím kompilovat - je to stopro nutné?

jsi si jisty, ze to tam neni? https://www.softwarecollections.org/en/scls/rhscl/rh-python35/ muzu to fixnout docela jednoduse ale lepsi by bylo mit 3.5... Ale jestli neni tak neni.

Pěkný repo, testnu to.

Hele ještě jeden dotaz, jak je to s UWSGI a virtualenv?
UWSGI běží v Python verzi: 3.4.3
Virtualenv má binárky pro Python: 3.5
To je cajk nebo ne?
*** has_emperor mode detected (fd: 7) ***
[uWSGI] getting INI configuration from seeder.ini
*** Starting uWSGI 2.0.12 (64bit) on [Wed Feb 15 23:16:06 2017] ***
compiled with version: 4.8.5 20150623 (Red Hat 4.8.5-4) on 02 January 2016 19:52:54
os: Linux-3.10.0-327.13.1.el7.x86_64 #1 SMP Thu Mar 31 16:04:38 UTC 2016
nodename: war.webarchiv.cz
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 8
current working directory: /etc/uwsgi.d
writing pidfile to /opt/Seeder/seeder.pid
detected binary path: /usr/sbin/uwsgi
your processes number limit is 31212
your memory page size is 4096 bytes
 *** WARNING: you have enabled harakiri without post buffering. Slow upload could be rejected on post-unbuffered webservers ***
detected max file descriptor number: 1024
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
uwsgi socket 0 bound to UNIX address /opt/Seeder/seeder.sock fd 3
Python version: 3.4.3 (default, Jan 26 2016, 02:25:35)  [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]
Set PythonHome to /opt/virtualenv/seeder
Fatal Python error: Py_Initialize: Unable to get the locale encoding
ImportError: No module named 'encodings'
Wed Feb 15 23:16:07 2017 - [emperor] curse the uwsgi instance seeder.ini (pid: 5460)
Wed Feb 15 23:16:07 2017 - [emperor] removed uwsgi instance seeder.ini

tak malý posun..
--- no python application found, check your startup logs for errors ---
[pid: 25886|app: -1|req: -1/1] <IP_ADDRESS> () {34 vars in 508 bytes} [Thu Feb 16 13:13:21 2017] GET /robots.txt => generated 21 bytes in 0 msecs (HTTP/1.1 500) 2 headers in 83 bytes (0 switches on core 0)
announcing my loyalty to the Emperor...
Thu Feb 16 13:13:21 2017 - [emperor] vassal seeder.ini is now loyal
--- no python application found, check your startup logs for errors ---
[pid: 25885|app: -1|req: -1/2] <IP_ADDRESS> () {36 vars in 623 bytes} [Thu Feb 16 13:13:21 2017] GET /wayback/*/http://www.uur.cz => generated 21 bytes in 0 msecs (HTTP/1.1 500) 2 headers in 83 bytes (0 switches on core 0)
announcing my loyalty to the Emperor...
Thu Feb 16 13:13:21 2017 - [emperor] vassal seeder.ini is now loyal
--- no python application found, check your startup logs for errors ---
[pid: 25886|app: -1|req: -1/3] <IP_ADDRESS> () {42 vars in 1149 bytes} [Thu Feb 16 13:13:24 2017] GET / => generated 21 bytes in 0 msecs (HTTP/1.1 500) 2 headers in 83 bytes (0 switches on core 0)

*** Starting uWSGI 2.0.12 (64bit) on [Thu Feb 16 13:10:38 2017] ***
compiled with version: 4.8.5 20150623 (Red Hat 4.8.5-4) on 02 January 2016 19:52:54
os: Linux-3.10.0-327.13.1.el7.x86_64 #1 SMP Thu Mar 31 16:04:38 UTC 2016
nodename: war.webarchiv.cz
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 8
current working directory: /
writing pidfile to /run/uwsgi/uwsgi.pid
detected binary path: /usr/sbin/uwsgi
setgid() to 987
setuid() to 991
your processes number limit is 31212
your memory page size is 4096 bytes
detected max file descriptor number: 1024
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
*** starting uWSGI Emperor ***
your mercy for graceful operations on workers is 60 seconds
*** Operational MODE: no-workers ***
spawned uWSGI master process (pid: 25882)
*** Stats server enabled on /run/uwsgi/stats.sock fd: 7 ***
*** has_emperor mode detected (fd: 7) ***
[uWSGI] getting INI configuration from seeder.ini
*** Starting uWSGI 2.0.12 (64bit) on [Thu Feb 16 13:10:38 2017] ***
compiled with version: 4.8.5 20150623 (Red Hat 4.8.5-4) on 02 January 2016 19:52:54
os: Linux-3.10.0-327.13.1.el7.x86_64 #1 SMP Thu Mar 31 16:04:38 UTC 2016
nodename: war.webarchiv.cz
machine: x86_64
clock source: unix
pcre jit disabled
detected number of CPU cores: 8
current working directory: /etc/uwsgi.d
writing pidfile to /opt/Seeder/seeder.pid
detected binary path: /usr/sbin/uwsgi
your processes number limit is 31212
your memory page size is 4096 bytes
 *** WARNING: you have enabled harakiri without post buffering. Slow upload could be rejected on post-unbuffered webservers ***
detected max file descriptor number: 1024
lock engine: pthread robust mutexes
thunder lock: disabled (you can enable it with --thunder-lock)
uwsgi socket 0 bound to UNIX address /opt/Seeder/seeder.sock fd 3
Python version: 3.4.3 (default, Jan 26 2016, 02:25:35)  [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)]
PEP 405 virtualenv detected: /opt/virtualenv/seeder
Set PythonHome to /opt/virtualenv/seeder
*** Python threads support is disabled. You can enable it with --enable-threads ***
Python main interpreter initialized at 0x1350540
your server socket listen backlog is limited to 100 connections
your mercy for graceful operations on workers is 60 seconds
mapped 509376 bytes (497 KB) for 6 cores
*** Operational MODE: preforking ***
added /opt/Seeder/Seeder/ to pythonpath.
Traceback (most recent call last):
  File "/opt/Seeder/Seeder/wsgi.py", line 13, in <module>
    from django.core.wsgi import get_wsgi_application
ImportError: No module named 'django'
unable to load app 0 (mountpoint='') (callable not found or import error)
*** no app loaded. going in full dynamic mode ***
*** uWSGI is running in multiple interpreter mode ***
spawned uWSGI master process (pid: 25884)
Thu Feb 16 13:10:38 2017 - [emperor] vassal seeder.ini has been spawned
spawned uWSGI worker 1 (pid: 25885, cores: 1)
spawned uWSGI worker 2 (pid: 25886, cores: 1)
unable to stat() /opt/Seeder/reload.touch, events will be triggered as soon as the file is created
Thu Feb 16 13:10:38 2017 - [emperor] vassal seeder.ini is ready to accept requests

uwsg mi píše:
(seeder) [root@war Seeder]# tail -f /var/log/seeder/uwsgi.log
--- no python application found, check your startup logs for errors ---
[pid: 8522|app: -1|req: -1/16] <IP_ADDRESS> () {42 vars in 1157 bytes} [Thu Feb 16 15:59:10 2017] GET / => generated 21 bytes in 0 msecs (HTTP/1.1 500) 2 headers in 83 bytes (0 switches on core 0)

imho jde o tohle: ImportError: No module named 'django'
Ale moc nevím co si s tím počít
*** Operational MODE: preforking ***
added /opt/Seeder/Seeder/ to pythonpath.
Traceback (most recent call last):
  File "/opt/Seeder/Seeder/wsgi.py", line 13, in <module>
    from django.core.wsgi import get_wsgi_application
ImportError: No module named 'django'
unable to load app 0 (mountpoint='') (callable not found or import error)
*** no app loaded. going in full dynamic mode ***
*** uWSGI is running in multiple interpreter mode ***

Jestli je vyjebaný virtualenv nebo uwsgi

např.
(seeder) [root@war Seeder]# Seeder/manage.py migrate
System check identified some issues:

WARNINGS:
?: (mysql.W002) MySQL Strict Mode is not set for database connection 'legacy_seeder'
        HINT: MySQL's Strict Mode fixes many data integrity problems in MySQL, such as data truncation upon insertion, by escalating warnings into errors. It is strongly recommended you activate it. See: https://docs.djangoproject.com/en/1.10/ref/databases/#mysql-sql-mode
source.Source.keywords: (fields.W340) null has no effect on ManyToManyField.
www.TopicCollection.sources: (fields.W340) null has no effect on ManyToManyField.
Operations to perform:
  Apply all migrations: admin, auth, authtoken, blacklists, comments, contenttypes, contracts, harvests, legacy_db, publishers, qa, reversion, sessions, source, thumbnail, voting, www
Running migrations:
  No migrations to apply.

hmm, imho v tom wsgi nepouzivas virtualenv.

resp rozhodne nepouzivas spravny, doporucuji ten stary smazat a vytvorit novy.

by bylo fajn vytvorit ten novy pomoci python3.5

čt 16. 2. 2017 v 20:26 odesílatel Visgean Skeloru<EMAIL_ADDRESS>napsal:

by bylo fajn vytvorit ten novy pomoci python3.5

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WebarchivCZ/Seeder/issues/349#issuecomment-280432413,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATQLKHIt8K5KScLMfIAgbXDA9ENw3NOks5rdKLdgaJpZM4MBjCy
.

Hele, je novej ve 3.5.
čt 16. 2. 2017 v 23:22 odesílatel Rudolf K<EMAIL_ADDRESS>napsal:

čt 16. 2. 2017 v 20:26 odesílatel Visgean Skeloru <
<EMAIL_ADDRESS>napsal:

by bylo fajn vytvorit ten novy pomoci python3.5

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WebarchivCZ/Seeder/issues/349#issuecomment-280432413,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATQLKHIt8K5KScLMfIAgbXDA9ENw3NOks5rdKLdgaJpZM4MBjCy
.

a jakou mas konfiguraci wsgi?

(seeder) [root@war Seeder]# cat /etc/uwsgi.ini
[uwsgi]
uid = uwsgi
gid = uwsgi
pidfile = /run/uwsgi/uwsgi.pid
emperor = /etc/uwsgi.d
stats = /run/uwsgi/stats.sock
cap = setgid,setuid
logto = /var/log/seeder/uwsgi.log

(seeder) [root@war Seeder]# cat /etc/uwsgi.d/seeder.ini
[uwsgi]
virtualenv      = /opt/virtualenv/seeder
pythonpath      = /opt/Seeder/Seeder
plugins         = python3
master          = 1
pidfile         = /opt/Seeder/seeder.pid
touch-reload    = /opt/Seeder/reload.touch
socket          = /opt/Seeder/seeder.sock
chmod-socket    = 777
cheaper-algo    = spare
cheaper         = 2
cheaper-initial = 2
cheaper-step    = 1
processes       = 6
vacuum          = 1
harakiri        = 60
wsgi-file       = /opt/Seeder/Seeder/wsgi.py
env             = PATH=/opt/rh/rh-python35/root/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin
env             = LD_LIBRARY_PATH=/opt/rh/rh-python35/root/usr/lib64
env             = XDG_DATA_DIRS=/opt/rh/rh-python35/root/usr/share:/usr/local/share:/usr/share
env             = PKG_CONFIG_PATH=/opt/rh/rh-python35/root/usr/lib64/pkgconfig

scl enable rh-python35 bash
virtualenv seeder
případně:
virtualenv -p /opt/rh/rh-python35/root/usr/bin/python seeder

mám pocit, že jsem zkoušel i
python -m venv seeder

když virtualenv aktivuji:

(seeder) [root@war seeder]# python -V
python: error while loading shared libraries: libpython3.5m.so.rh-python35-1.0: cannot open shared object file: No such file or directory

Jediné jak to funguje je:

(seeder) [root@war seeder]# source /opt/rh/rh-python35/enable
(seeder) [root@war seeder]# python -V
Python 3.5.1

Proto jsem navíc dodal ty env, do seeder.ini pro uwsgi.

http://modwsgi.readthedocs.io/en/develop/user-guides/installation-issues.html hmm, myslim ze je problem, ze to wsgi neni zkompilovane pomoci pythonu3.5, ale ok, asi to bude nejjednodusi dat zpatky na python3.4

tak můžu ho zkusit buildnout s 3.5

jak chces, pro me to neni zas takovy problem zmenit a vypada to ze je to komplikovany proces rozchodit pthon 3.5

testnu a uvidíme

Ahoj, bavil jsem se s Járou. Můžeš to hodit na 3.4? Zkusím paralerně připravit prostředí kde to půjde ve 3.5, ale teď bychom potřebovali testovat, tak to bude nejrychlejší.

jasne, udelam to dneska.


[ICD] Fix corner cases where multiple reports are emitted on entering active mode

Certain chain of event will lead to emitting reports twice in a row when waking up when defining ICD_REPORT_ON_ENTER_ACTIVE_MODE
For instance:
Device wakes up due to max subscription interval expired -> Schedule Engine Run -> Goes from idle mode to active mode in ICD manager -> Scheduler Engine Run.
We need to establish a mechanism that keeps track of if a run is scheduled and prevent it if that is the case.
(Using theIsEngineRunScheduled() method form ReadHandlerNode could be a way)

We need to establish a mechanism that keeps track of if a run is scheduled and prevent it if that is the case.

If a run is scheduled but not happening, ScheduleRun is a no-op, no?  But this may be an issue where we have different definitions of "run" and "scheduled"....


Spelling mistake at EmbeddedChannel#readOutbound()

Netty 5.0.0.Alpha2
Context:
Javadoc of EmbeddedChannel#readOutbound(),
"from" is mistakenly spelled "froum"
https://github.com/netty/netty/blob/43ebbc3fa065155fa67732b0cbd7c12843b0f3f7/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java#L190

@ferrybig how about doing a PR against the 4.1 branch ?

Pull request made: https://github.com/netty/netty/pull/4682 did not know how to add the pull request to this issue

Fixed by https://github.com/netty/netty/pull/4682


opt: improve search_branch by using get_key

In the benchmarks, this brings search times down by at least 40%, with the amount increasing as the prefix length grows.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#510  👈
#509
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite

Merge activity

Oct 28, 8:50 AM EDT: A user started a stack merge that includes this pull request via Graphite.


Update drop_missing_rows to filter_blank_rows API.

Pull Request Description
Implements https://www.pivotaltracker.com/story/show/183390042 and https://www.pivotaltracker.com/story/show/183390370
Important Notes

Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the
Scala,
Java,
and
Rust
style guides.
All code has been tested:

[x] Unit tests have been written where possible.
[ ] If GUI codebase was changed: Enso GUI was tested when built using BOTH
./run ide build and ./run ide watch.

Looks really good to me.


Multiple Strategies

Searching GitHub people are using a combination of Strategies like this:
release {
    grgit = new OpenOp(dir: '.').call()

    versionStrategy Strategies.FINAL
    versionStrategy Strategies.PRE_RELEASE
    defaultVersionStrategy Strategies.DEVELOPMENT
}

With: gradlew build
the jar produced has a developer formatted version as expected by the default versing strategy.
With:./gradlew release -Prelease.scope=major -Prelease.stage=final
the error message "Stage final is not one of [dev] allowed for strategy development." is presented.
How can these Strategies work together?

By adding
println "Repository is " + (grgit.status().isClean() ? "clean." : "not clean.")
to the above release block this helped show the problem.  As documented the FINAL and PRE_RELEASE Strategies will be ignored if the repository is dirty.  Thus, it fell to the DEVELOPMENT Strategy which did not understand 'final' for the Stage.  Once the local changes were git committed the FINAL and PRE_RELEASE Strategies accepts their associated Stages.
For newbies perhaps this error message would add clarity
Stage final is not one of [dev] allowed for strategy development.  Strategies X, Y, Z, ignored stage final since the repository is not clean.

Yeah, the default message can be a little confusing. If you turn on the --info level logging it tells you each strategy that was skipped. I'll have to see if/how a more helpful message could be generated.


3d Model type added to media_types.py

Fixes

Fixes #[#658] by @[AetherUnbound]
Description

This PR updates the file media_types.py by adding the media type "3D Model" to the list of possible media types to allow the ingestion server to perform data refreshes for that media type.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Will merging this now allow ingestion to work before there are 3d models to ingest?

@sarayourfriend yes, adding this should not impact ingestion. The passing CI gives me confidence that everything that works now remains functional after this change.


I'm getting the following error on my Rails App

Change detected to: app/assets/stylesheets/application.scss
error app/assets/stylesheets/application.scss (Line 6: File to import not found or unreadable: font-awesome.
Load paths:
../projects/APPNAME (DEPRECATED)
../projectsAPP/app/assets/stylesheets)
My Gemfile for assets looks something like this:
gem 'haml-rails'
gem 'jquery-rails', '~> 2.1.1'
gem 'modernizr-rails'
Static Assets
gem 'sass-rails', '~> 4.0.0'
gem 'jquery-rails', '~> 2.1.1'
gem 'autoprefixer-rails'
gem 'font-awesome-rails'
In the application.scss file I've added the following line, restarted multiple times:
@import "font-awesome";
What am I missing?

Just restart your app,it work for me.


file.path

Looks like I forgot a spot. This line should be file.path('Datasets','ne_10m_land.zip'))
https://github.com/liannesheppard/ENVH556_2021course/blob/dd0dbddd16bde5507ef7320d3c7f7ae873ea5317/Week8LabGeostatistics.Rmd#L782

Resolved by https://github.com/liannesheppard/ENVH556_2021course/commit/66b8b445caf289341aea73cc15297665e8fd4842


PagedList has no public constructor

Is there any reason that PagedList has no public constructor? All of the constuctors are currently internal. As a result, I can't unit test code that returns a PagedList because I can't create a PagedList to return in the unit test.
I propose exposing a public constructor - or a static class that will return a new PagedList that is modifyable outside of UnitOfWork, similar to the Empty() method.
I'll even do the work and submit a pull request, if this seems reasonable. (I think it does.)

I'm agree with you, can U PR for this?

Yes. I will create it as soon as possible.

any update on this issue?


Debug AppVeyor CI

Per #267.
See for example AppVeyor job 380.

Occurs only for Python 3.6; not Python 3.7.
conda update --quiet --yes conda appears to downgrade some packages.
Messages appear like:ERROR conda.core.link:_execute_actions(337): An error occurred while installing package 'conda-forge::tqdm-4.43.0-py_0'.
CondaError: Cannot link a source that does not exist. C:\Miniconda36-x64\Scripts\conda.exe
Attempting to roll back.

CondaError: Cannot link a source that does not exist. C:\Miniconda36-x64\Scripts\conda.exe

conda install […] then fails.

2c807a7 seems to fix the issue by ensuring conda per se is updated from conda-forge. Cherry-picked back to the original PR.


Use name clearer than "PIN" for binding token

Remark by Pieter, try to avoid the name "PIN" because people have other expectations for PIN than we need here.
Specifically, that a PIN stays the same.

@arnoutt zegt: DigiD noemt het 'koppelcode' / 'verification code'. Dat klinkt ook goed

Cons: 'PIN' is a very familiar term, in both English and Dutch and the expectation is that it is a 4 digit number, which it is.

4 digits was just an arbitrary proof-of-concept choice, we could also make it a more sophisticated base32 verification code?

@mrvanes the discussion was not about the amount of numbers, but about the term used to classify them.
@FlorisFokkinga officially PIN means Personal Identification Number, which this (binding token) definitely is not. So I am in favour of renaming it to the terms above.

@arnoutt, That's the familiar choice between clarity and correctness. ;)

True, but I don't see why verification code should be less clear :) In fact, it might be even more clear!

https://github.com/SURFscz/pam-weblogin/pull/30

Merged en tested
╰─▶ make test USERNAME=u2

pamtester weblogin "${USERNAME:-unspecified}" authenticate
Please sign in to: https://test.sram.surf.nl/weblogin/cloud/16230707-2313-4fe4-bebe-eb3b6f2bbe8d
Verification code:
User<EMAIL_ADDRESS>has authenticated successfully
pamtester: successfully authenticated


Angular client headers

Hi guys,
I use your Angular client along with Laravel and have to globally set the X-CSRF-Token for Laravel ajax for POSTs to work.  I am getting an issue with your service not liking the extra headers
I get the error:

Request header field X-CSRF-Token is not allowed by Access-Control-Allow-Headers.

I set the header globally in the app config as I have loads of ajax posts and it's not practical to set it manually every time:
 $httpProvider.defaults.headers.common = {
    'X-Requested-With': 'XMLHttpRequest',
    'X-CSRF-Token': $('meta[name="_token"]').attr('content')
};

I have tried overriding it using:
client.setExtraHeader('X-CSRF-Token', null);

That has no effect and I cannot see any methods in the client to remove headers.
Any suggestions?  (Thanks in advance!)

I confirm that we do not announce X-CSRF-Token header support. Any ideas around it @vvo ?

Maybe flush existing header in _computeRequestHeaders: line 906 of AlgoliaSearch.js ?

Hey to both of you. I will force or clean headers in the angular request build implementation on monday.
If you already have a solution @ajarti feel free to contribute, that's easy!

Hi guys,
I have experimented a bit and in Angular 1.4 you can clear common headers by setting them undefined in the $http request (see: 'Setting HTTP Headers' on https://docs.angularjs.org/api/ng/service/$http)
I wrote a little code to generate the clearing:
var commonHeadersToClear = {};
angular.forEach($http.defaults.headers.common, function(value,key){
    commonHeadersToClear[key] = undefined;
});

and then pass then to the 3rd param of the http request and this works fine in normal $http requests.
I tried to use the js client setExtraHeader method to set them to undefined, but that failed to clear them as it looks like the headers are already flushed but the header is still included in the querystring? It looks like the inlineHeaders function in the client gets to them and just converts the undefined to empty, but still includes the header in the querystring .... and boom!
That is of course if I am reading it correctly :)
Does that help?

Yes thanks a lot for this investigation!

Only a pleasure @vvo :) I have a deadline for Monday that I am probably not going to make, so can't allocate any additional time this weekend unfortunately.  I am using Algolia in it so will just manually add the X-CSRF-Token and X-Requested-With to my Laravel API calls for the time being.
Thanks again for looking at this, much appreciated.


Project workflows

It fails to add card to the project since the workflow doesn't have access to our secrets. After it's merged, it will have.

New releases of modules, like Drash - the tests would only usually fail like this, it’s cause the tests assert a certain version is present in the deps file to make sure it updated properly, so I guess these tests failing are a false positive

What should I do about the tests?

What should I do about the tests?

separate issue


Notification: Message are not highlighted in the timeline

0.12.2 opens the room around the notified message but the message is not highlighted. This makes me hard to find it among other messages.
It should be highlighted with the left vertical bar:

Closed with #3323


"The formula cannot be installed from the bottle"

Hi there. I'm trying to install Bun on WSL2 Ubuntu 22.04 using Homebrew and I keep getting this error:

I have pruned Homebrew's cache and untapped/retapped the tap multiple times but to no avail.
I can't seem to figure out what's wrong here. Shouldn't it just work?

The good news is that it appears to be downloading the right asset from Github.
Could you run the following command, to see if there's any extra logs? (-vd should enable verbose & debug logs)
brew install -vd bun 2>&1 | tee install.log

@Electroid Thanks for the quick response.

The good news is that it appears to be downloading the right asset from Github.

Yeah that's what makes it weird :/
Sure, here's the full output of that command:
Running `brew update --auto-update`...
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaLoader): loading /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/oven-sh/homebrew-bun/Formula/bun.rb
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading glibc from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading<EMAIL_ADDRESS>from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading gcc from API
/usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/git --version
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading gmp from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading m4 from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading isl from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading libmpc from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading mpfr from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading zstd from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading lz4 from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading xz from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading cmake from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading openssl@3 from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading ca-certificates from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading ncurses from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading pkg-config from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading gpatch from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading zlib from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading binutils from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading bzip2 from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading bison from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading unzip from API
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading zip from API
/usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Linuxbrew/4.1.10\ \(Linux\;\ x86_64\ Ubuntu\ 22.04.2\ LTS\)\ curl/7.81.0 --header Accept-Language:\ en --retry 3 --fail --location --silent --head https://github.com/oven-sh/bun/releases/download/bun-v0.8.1/bun-linux-x64.zip
==> Fetching oven-sh/bun/bun
/usr/bin/env /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Linuxbrew/4.1.10\ \(Linux\;\ x86_64\ Ubuntu\ 22.04.2\ LTS\)\ curl/7.81.0 --header Accept-Language:\ en --fail --silent --retry 3 --remote-time --output /home/arad/.cache/Homebrew/downloads/819c9044390433362a2e61126a1895235c9e2ea9f6ee4bbf39641f24c02470a5--bun-linux-x64.zip.incomplete --location https://objects.githubusercontent.com/github-production-release-asset-2e65be/357728969/a39b9354-a2c2-44a1-a3b5-2924c18d5446\?X-Amz-Algorithm=AWS4-HMAC-SHA256\&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A\%2F20230908\%2Fus-east-1\%2Fs3\%2Faws4_request\&X-Amz-Date=20230908T004937Z\&X-Amz-Expires=300\&X-Amz-Signature=1af4dfa77724cb83f4d27008f74e73cc83a2cde7f0791d63afb4a187e350e63e\&X-Amz-SignedHeaders=host\&actor_id=0\&key_id=0\&repo_id=357728969\&response-content-disposition=attachment\%3B\%20filename\%3Dbun-linux-x64.zip\&response-content-type=application\%2Foctet-stream
==> Downloading https://github.com/oven-sh/bun/releases/download/bun-v0.8.1/bun-linux-x64.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/357728969/a39b9354-a2c2-44a1-a3b5-2924c18d5446?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20230908%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230908T004937Z&X-Amz-Expires=300&X-Amz-Signature=1af4dfa77724cb83f4d27008f74e73cc83a2cde7f0791d63afb4a187e350e63e&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=357728969&response-content-disposition=attachment%3B%20filename%3Dbun-linux-x64.zip&response-content-type=application%2Foctet-stream
Error: The following formula cannot be installed from bottle and must be
built from source.
  bun
Install Clang or run `brew install gcc`.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/formula_installer.rb:403:in `install'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/upgrade.rb:218:in `install_formula'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:358:in `install_formula'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:303:in `block in install_formulae'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:302:in `each'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/install.rb:302:in `install_formulae'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/install.rb:295:in `install'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:94:in `<main>'
==> Verifying checksum for '819c9044390433362a2e61126a1895235c9e2ea9f6ee4bbf39641f24c02470a5--bun-linux-x64.zip'
==> Installing bun from oven-sh/bun

Needless to say I can install other formulae just fine:


一直报 Preprocessor dependency "sass" not found. Did you install it?； 按照文档删除pnpm.yaml也不行

➜  Network: http://<IP_ADDRESS>:8848/
Preprocessor dependency "sass" not found. Did you install it?
Preprocessor dependency "sass" not found. Did you install it? (x2)
Preprocessor dependency "sass" not found. Did you install it? (x3)
Preprocessor dependency "sass" not found. Did you install it? (x4)
Preprocessor dependency "sass" not found. Did you install it? (x5)
17:26:18 [vite] Internal server error: Preprocessor dependency "sass" not found. Did you install it?
Plugin: vite:css
File: E:/练习项目vue3/pure-test/src/style/index.scss

请好好看文档 最上方

好的

使用nvm管理node版本
切换的node版本为16.16.0
pnpm版本为6.32.3
npm源地址为原版地址
遇到一样的问题

如果你那么喜欢不规范命名或者中文目录
你可以尝试这样做
https://github.com/xiaoxian521/vue-pure-admin/commit/271b953081e2190770998313089f55a43cbe4a4d

好的,谢谢


Handle nested symbols.

Closes #61. Adds an extra test.
This may return some false positives. For example, in the following case:
# Cell 1
class Foo:
    def __init__(self):
        self.counter = 0

    def inc(self):
        self.counter += 1

    def bar(self):
        return {'baz': 0}

# Cell 2
obj = Foo()

# Cell 3
obj.inc()

# Cell 4
obj.bar['baz']

get_dependencies(4) will return cells 1, 2, 3, and 4, when technically cell 3 isn't absolutely necessary for this output. However, I'd argue that it's better to keep cell 3 because it modifies the internal state of obj and better reflects the final state of the program. Open to other thoughts/suggestions though.

Sweet, thanks for adding the test Shreya! I'm not 100% sure if this covers all the cases for nested symbols but I think this is a good starting point; we can see if there's any weird behavior and iterate as appropriate.
Btw the third cell is included because we're partially hacking in some underwhelming static slicing functionality via the liveness checker. I.e. this block in safety.py:
            for live_timestamp, version in sym.version_by_liveness_timestamp.items():
                if version < live_timestamp:
                    cell_num_to_static_deps[live_timestamp].add(version)

If I comment that out, it's actually smart enough to leave out cell 3.
Overall though, our approach of using a kind-of-sad static slicer in order to catch all the conditional branches but leaves out some stuff + a very badass dynamic slicer that captures everything else seems to be quite solid.


Add support for Maven Polyglot POM formats

I'll take a look at this change this week. I think it's something we can reasonably support. But there are a few things we (Heroku) have to consider before official adopting support like this. We repeat the buildpacks detection logic in a few places internally to enable various platform features for Java apps, and we'd have to replicate this change in those places (unfortunately).
In the meantime, it would be helpful if you could modify an app like https://github.com/kissaten/java-minimal to include a pom.yaml or similar for testing.
Thanks!

I've create a fork of java-minimal that uses the YAML POM format: https://github.com/ecopoesis/java-minimal

I'm thinking that I may merge this but leave it undocumented (at least for the time being). That would mean the buildpack would work, but a few Heroku features (such as JVM Language Metrics) might not work without some manual setup steps. Will decide for sure this week.

I'm merging this PR into #86 and closing this PR so I can add an integration test, and run those tests on CI (they won't run from a forked PR because they require an API key).


[WIP] nixpkgs: Begin moving to buildSystem parameter, away from crossSystem

In response to #36217, #49510, #49765.
Motivation for this change
The general issue seems to be that localSystem is the wrong abstraction.
It is documented in only one section of the manual, about invoking nixpkgs for cross compilation and apologizing for the current situation. It does not seem to be useful outside the task of invoking nixpkgs. In this issue I (too) am proposing to use the existing build and host terminology, instead of maintaining separate terms local and cross for the singular purpose of invoking nixpkgs.
In a declarative system, we care more about the result than the
process, and the only useful property of the result is hostSystem.
Knowing hostSystem, the only other piece of information we need
in order to derive the previous attributes is buildSystem, which
is extrinsic to the result and can typically be forgotten.
This PR is work in progress. TODO:

[ ] Test more extensively
[ ] Decide what the impure defaults should be in top-level/impure.nix

Probably best to have buildSystem ? null. Cross-users will have specify buildSystem or we'll have to keep crossSystem around for the purpose of simultaneously setting hostSystem and buildSystem = currentSystem. Any opinions?

[ ] Implement the impure defaults, in a backwards compatible way
[ ] Add deprecation message to localSystem and possibly crossSystem

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@matthewbauer I'd recommend anyone to avoid :-1: reactions.
However, I do understand that you can have reasons to dislike this change.
My best guess is that I'm asking for feedback too early. Or maybe such a 'philosophical' difference doesn't matter to you? I don't know.
Please write a comment about what needs to improve. It seems that 4 other people would like to see a change like this happen.

Sorry about that! I was going to post a comment but didn’t have time to explain the full reasoning. Basically:

buildSystem should be the same thing as localSystem. Renames are fine but this pr seems to treat them differently.
hostSystem is such a loaded term that I want to avoid using. “Host” in some contexts is what in Nixpkgs we thing of as “build”. It’s the legacy of autoconf naming.

Sorry about that!

No problem!

* buildSystem should be the same thing as localSystem. Renames are fine but this pr seems to treat them differently.

The build and local serve the same purpose, but build doesn't have to be specified by the user if it is the same as hostSystem.

* hostSystem is such a loaded term that I want to avoid using. “Host” in some contexts is what in Nixpkgs we thing of as “build”. It’s the legacy of autoconf naming.

Ok, let's call it runSystem. I'd argue that this one is simple "the" system, but that name seems to be taken.

* defaulting to null produces too many conditionals IMO.

An implementation concern. I'll see if I can rewrite it such that it has fewer conditionals. I do think that the user interface here is more important than the number of conditionals.

The defaults that i would like would be:
  * localSystem is the system nix autodetects
  * crossSystem == localSystem in native builds

nothing specified -> build = current, run = current (native build, same behavior)
run specified -> build = current, run = args.run (similar to specifying crossSystem)
build specified -> build = args.build, run = current (new behavior, useful for doing remote cross builds while using the 'run' device)
both specified -> obvious (fully specified, same behavior)

This seems like a very simple "intuitive" defaults scheme to me.
The only issue is that you now have to give two arguments for a remote non-cross build of a foreign architecture; for example a darwin user deploying to linux using a linux build farm.
Some choices:

Accept this; require two arguments for a remote build
Keep localSystem around for the purpose of a remote building shorthand - mutually exclusive with the other flags after deprecation period
Introduce a remoteSystem parameter to serve as a shorthand - mutually exclusive with the other flags. localSystem can be removed after deprecation period
Change the runSystem-only invocation to set buildSystem too - require both for cross compilation
Change the buildSystem-only invocation to set runSystem too - similar to setting localSystem currently. This complicates the defaults, requiring more documentation etc.
Instead of defaulting to currentSystem, we could default to system which then defaults to currentSystem. This means reintroducing a system parameter that may or may not be compatible with a currently obsolete system parameter.

I quite like the latter option, but I don't know enough about the history of cross compilation yet to judge it. It seems quite elegant:
system overrides the default, currentSystem
buildSystem overrides system but only for build
runSystem overrides system but only for run

mmm agree the autoconf terminology is bad, but if we rename it here we should rename the existing hostPlatform too. I suppose that is more work and more controversy.

Are there any updates on this pull request, please?

TL;DR: Someone please pick this up because this could be much more elegant. Sadly I'm not the right person to do it.
My goal with this PR was to separate the "what" from the "how", where the "what" is most important. I believe that the primary focus of this interface should be the build result, so the platform where the build result can run. Because this is the most essential parameter, I think it should always be set via the same parameter name. Cross builds can then be achieved by changing the platform that builds it.
This is a more top-down design approach than the current bottom-up one.
Nix itself is the result of top-down thinking; taking a step back and designing a system to accomplish a high-level goal. Traditional package managers seem to be the result of a bottom-up approach: what can we build on top of make, tar, etc so we don't have to build everything from source all the time. Anyway, I'm going to cut myself off here to avoid getting too verbose :).
Sadly I'm not the right person to chase this little redesign. I'm not very closely involved with the nixpkgs cross compilation business, so I think that everyone is better off when I leave this and perhaps someone else picks this up. I don't need any credit for this either, because I've only done the easy part.


Abstract bot to work w/ all events

Before, the bot would be hardcoded to a specific event. Now it will work across all events in the meetup group.
NOTE: it is not currently on so the group won't be spammed 😂

Yep.
This is not ready to merge yet tho. Note #11


Issue summarization misses information from comments

Testing #6321
It sometimes includes information from the comments, but not in this case:

The summarize tool appears to drop it (appending copy from log view):
copilotLanguageModelWrapper - 375c6f47
Metadata
url              : https://api.enterprise.githubcopilot.com/chat/completions
model            : gpt-4o
maxPromptTokens  : 64000
maxResponseTokens: 4096
location         : 4
postOptions      : {"temperature":0.1,"top_p":1,"max_tokens":4096,"tools":[{"type":"function","function":{"name":"copilot_codebase","description":"Search for relevant file chunks, symbols, and other info about the current workspace or codebase","parameters":{"type":"object","properties":{"query":{"type":"string","description":"The query to search the codebase for. Should contain all relevant context. Can be a full natural language sentence, or keywords."}},"required":["query"]}}},{"type":"function","function":{"name":"copilot_vscodeAPI","description":"Use VS Code API references to answer questions about VS Code extension development.","parameters":{"type":"object","properties":{"query":{"type":"string","description":"The query to search vscode documentation for. Should contain all relevant context."}},"required":["query"]}}},{"type":"function","function":{"name":"github-pull-request_issue_fetch","description":"Get a GitHub issue/PR's details as a JSON object.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue/PR from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue/PR from."},"name":{"type":"string","description":"The name of the repository to get the issue/PR from."}},"required":["owner","name"]},"issueNumber":{"type":"number","description":"The number of the issue/PR to get."}},"required":["issueNumber"]}}},{"type":"function","function":{"name":"github-pull-request_notification_fetch","description":"Get a GitHub notification's details as a JSON object.","parameters":{"type":"object","properties":{"thread_id":{"type":"string","description":"The notification thread id."}},"required":["thread_id"]}}},{"type":"function","function":{"name":"github-pull-request_issue_summarize","description":"Summarizes a GitHub issue or pull request. A summary is a great way to describe an issue or pull request.","parameters":{"type":"object","properties":{"title":{"type":"string","description":"The title of the issue/PR"},"body":{"type":"string","description":"The body of the issue/PR"},"comments":{"type":"array","items":{"type":"string"},"description":"The array of associated string comments"},"fileChanges":{"type":"array","items":{"type":"object","properties":{"fileName":{"type":"string","description":"The name of the file of the change"},"patch":{"type":"string","description":"The patch of the change"}}},"description":"For a PR, the array of associated file changes"}},"required":["title","body","comments"]}}},{"type":"function","function":{"name":"github-pull-request_notification_summarize","description":"Summarizes a GitHub notification. A summary is a great way to describe a notification.","parameters":{"type":"object","properties":{"lastReadAt":{"type":"string","description":"The last read time of the notification."},"lastUpdatedAt":{"type":"string","description":"The last updated time of the notification."},"unread":{"type":"boolean","description":"Whether the notification is unread."},"title":{"type":"string","description":"The title of the notification issue/PR"},"body":{"type":"string","description":"The body of the notification issue/PR"},"unreadComments":{"type":"array","items":{"type":"string"},"description":"The array of unread comments under the issue/PR of the notification"},"threadId":{"type":"number","description":"The thread id of the notification"},"notificationKey":{"type":"string","description":"The key of the notification"},"fileChanges":{"type":"array","items":{"type":"object","properties":{"fileName":{"type":"string","description":"The name of the file of the change"},"patch":{"type":"string","description":"The patch of the change"}},"required":["fileName","patch"]},"description":"For a notification about a PR, the array of associated file changes"}},"required":["title","unreadComments","lastUpdatedAt","unread","threadId","notificationKey"]}}},{"type":"function","function":{"name":"github-pull-request_suggest-fix","description":"Summarize and suggest a fix for a GitHub issue.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue from."},"name":{"type":"string","description":"The name of the repository to get the issue from."}},"required":["owner","name"]},"issueNumber":{"type":"number","description":"The number of the issue to get."}},"required":["issueNumber","repo"]}}},{"type":"function","function":{"name":"github-pull-request_formSearchQuery","description":"Converts natural language to a GitHub search query. Should ALWAYS be called before doing a search.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue from."},"name":{"type":"string","description":"The name of the repository to get the issue from."}},"required":["owner","name"]},"naturalLanguageString":{"type":"string","description":"A plain text description of what the search should be."}},"required":["naturalLanguageString"]}}},{"type":"function","function":{"name":"github-pull-request_doSearch","description":"Execute a GitHub search given a well formed GitHub search query. Call github-pull-request_formSearchQuery first to get good search syntax and pass the exact result in as the 'query'.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue from."},"name":{"type":"string","description":"The name of the repository to get the issue from."}},"required":["owner","name"]},"query":{"type":"string","description":"A well formed GitHub search query using proper GitHub search syntax."}},"required":["query","repo"]}}},{"type":"function","function":{"name":"github-pull-request_renderIssues","description":"Render issue items from an issue search in a markdown table. The markdown table will be displayed directly to the user by the tool. No further display should be done after this!","parameters":{"type":"object","properties":{"arrayOfIssues":{"type":"array","description":"An array of GitHub Issues.","items":{"type":"object","properties":{"title":{"type":"string","description":"The title of the issue."},"number":{"type":"number","description":"The number of the issue."},"url":{"type":"string","description":"The URL of the issue."},"state":{"type":"string","description":"The state of the issue (open/closed)."},"createdAt":{"type":"string","description":"The creation date of the issue."},"updatedAt":{"type":"string","description":"The last update date of the issue."},"closedAt":{"type":"string","description":"The closing date of the issue."},"author":{"type":"object","description":"The author of the issue.","properties":{"login":{"type":"string","description":"The login of the author."},"url":{"type":"string","description":"The URL of the author's profile."}}},"labels":{"type":"array","description":"The labels associated with the issue.","items":{"type":"object","properties":{"name":{"type":"string","description":"The name of the label."},"color":{"type":"string","description":"The color of the label."}}}},"assignees":{"type":"array","description":"The assignees of the issue.","items":{"type":"object","properties":{"login":{"type":"string","description":"The login of the assignee."},"url":{"type":"string","description":"The URL of the assignee's profile."}}}},"commentsCount":{"type":"number","description":"The number of comments on the issue."}}},"required":["title","number","url","state","createdAt","author","commentCount","reactionCount"]},"totalIssues":{"type":"number","description":"The total number of issues in the search."}},"required":["arrayOfIssues","totalIssues"]}}},{"type":"function","function":{"name":"searchConfigurations","description":"Use this tool to search for settings and commands. This will return all those settings and commands that contain the provided keywords. Each result will have a type to know if it is a setting or a command. A setting includes the description, default value, current value and other possible values and a command includes the description and possible arguments to be used to invoke the command.","parameters":{"type":"object","properties":{"keywords":{"type":"string","description":"List of keywords to search for the settings and commands"}}}}},{"type":"function","function":{"name":"updateSettings","description":"Use this tool to update settings. This tool support bulk updates, so you can update multiple settings at once. Provide the settings to update as a key value pair of setting id and new value. The value of the setting must follow the setting schema.","parameters":{"type":"object","description":"Dictionary of settings to update. The key is the setting id and the value is the new value of the setting.","properties":{},"additionalProperties":true}}},{"type":"function","function":{"name":"runCommand","description":"Use this tool to run a command. This tool will run the command with the provided arguments if the command supports them. The arguments must follow the command arguments schema provided by the searchConfigurations.","parameters":{"type":"object","properties":{"key":{"type":"string","description":"Id of the command"},"argumentsArray":{"type":"string","description":"Arguments to pass to the command as JSON stringified array"}}}}}],"stream":true}
intent           : undefined
startTime        : 2024-10-22T08:51:43.416Z
endTime          : 2024-10-22T08:51:45.214Z
duration         : 1798ms
ourRequestId     : ae0b92ae-1152-4d6d-9184-ac2f4cdd9c7f
requestId        : ae0b92ae-1152-4d6d-9184-ac2f4cdd9c7f
serverRequestId  : ae0b92ae-1152-4d6d-9184-ac2f4cdd9c7f
timeToFirstToken : 812ms
Request Messages
System
Follow Microsoft content policies.
Avoid content that violates copyrights.
If you are asked to generate content that is harmful, hateful, racist, sexist, lewd, violent, or completely irrelevant to software engineering, only respond with "Sorry, I can't assist with that."
Keep your answers short and impersonal.
Use Markdown formatting in your answers.
Make sure to include the programming language name at the start of the Markdown code blocks.
Avoid wrapping the whole response in triple backticks.
The user works in an IDE called Visual Studio Code which has a concept for editors with open files, integrated unit test support, an output pane that shows the output of running the code as well as an integrated terminal.
The active document is the source code the user is looking at right now.
You can only give one reply for each conversation turn.
Assistant
Instructions:

The user will ask a question related to GitHub, and it may require lots of research to answer correctly. There is a selection of tools that let you perform actions or retrieve helpful context to answer the user's question.
If you aren't sure which tool is relevant, you can call multiple tools. You can call tools repeatedly to take actions or gather as much context as needed until you have completed the task fully. Don't give up unless you are sure the request cannot be fulfilled with the tools you have.
Don't ask the user for confirmation to use tools, just use them.
When talking about issues, be as concise as possible while still conveying all the information you need to. Avoid mentioning the following:
The fact that there are no comments.
Any info that seems like template info.
User
Summarize issue microsoft/vscode-copilot#7221
Assistant
🛠 {"id":"call_hgBIgYc8N3og3hOJatrtiAmD","type":"function","function":{"name":"github-pull-request_issue_fetch","arguments":"{"issueNumber":7221,"repo":{"name":"vscode-copilot","owner":"microsoft"}}"}}
Tool
🛠 call_hgBIgYc8N3og3hOJatrtiAmD
{"title":"UX: Better entry point for code reviews in SCM","body":"✨ doesn't make to make code review easy enough to discover as the icon is over-loaded as AI smart action and is only available on hover for changes.\n\n1. UI element that is easy to understand. ✨ on the changes could mean a lot of different things (my first thought is always smart staging)\n2. Place it where it can be easily found and used as a user works on a commit/branch.\n3. We might want to offer other "compare with", like #7068, should those be offered as drop-down?","comments":[{"body":"Came up a lot pre-Universe from various people who tried to find this feature. The hover-only sparkle is way too hidden.\n\nMonkeypatch idea for Universe until we find a better UX: Show the sparkle always for Staged and Changes, right aligned from the hover buttons. cc @lszomoru for thoughts."},{"body":"The visibility of all actions in the Source Control view can be toggled using the scm.alwaysShowActions setting. I do not believe that we should create actions that are "always" visible and do not respect the setting. "},{"body":"https://github.com/microsoft/vscode-copilot/pull/9454 for the icon change"},{"body":"The actions in the view titlebar are shown whenever the mouse is anywhere over the view, i.e., much more than the actions on the Changes / Staged Changes node. Maybe we could also add it there and let it review all local changes.\n\n"}]}
User
Above is a stringified JSON representation of the issue or pull request. This can be passed to other tools for further processing.
User
Above is the result of calling the functions github-pull-request_issue_fetch.
Assistant
🛠 {"id":"call_qjTb4OclCarjsZ07fyEERzjL","type":"function","function":{"name":"github-pull-request_issue_summarize","arguments":"{"title":"UX: Better entry point for code reviews in SCM","body":"✨ doesn't make to make code review easy enough to discover as the icon is over-loaded as AI smart action and is only available on hover for changes.\n\n1. UI element that is easy to understand. ✨ on the changes could mean a lot of different things (my first thought is always smart staging)\n2. Place it where it can be easily found and used as a user works on a commit/branch.\n3. We might want to offer other \"compare with\", like #7068, should those be offered as drop-down?","comments":["Came up a lot pre-Universe from various people who tried to find this feature. The hover-only sparkle is way too hidden.\n\nMonkeypatch idea for Universe until we find a better UX: Show the sparkle always for Staged and Changes, right aligned from the hover buttons. cc @lszomoru for thoughts.","The visibility of all actions in the Source Control view can be toggled using the scm.alwaysShowActions setting. I do not believe that we should create actions that are \"always\" visible and do not respect the setting.","https://github.com/microsoft/vscode-copilot/pull/9454 for the icon change","The actions in the view titlebar are shown whenever the mouse is anywhere over the view, i.e., much more than the actions on the Changes / Staged Changes node. Maybe we could also add it there and let it review all local changes.\n"]}"}}
Tool
🛠 call_qjTb4OclCarjsZ07fyEERzjL
Summary:

The issue highlights the need for a more intuitive entry point for code reviews in the SCM. The current icon (✨) is overloaded with AI smart actions and only appears on hover, making it hard to discover. The suggestions include:

Creating a UI element that is easy to understand.
Placing the element where it can be easily found during commit/branch work.
Considering offering other "compare with" options, similar to issue #7068, possibly as a drop-down menu.

There are no additional details provided in the comments.
User
Above is the result of calling the functions github-pull-request_issue_summarize.
Response
Assistant
Summary:
The issue highlights the need for a more intuitive entry point for code reviews in the SCM. The current icon (✨) is overloaded with AI smart actions and only appears on hover, making it hard to discover. The suggestions include:

Creating a UI element that is easy to understand.
Placing the element where it can be easily found during commit/branch work.
Considering offering other "compare with" options, similar to issue #7068, possibly as a drop-down menu.

There are no additional details provided in the comments.

I seem to get this a lot if the issue has comments that are just fixed via #xyz. My response contains
Comments: Three comments with no additional information provided.

With the PR https://github.com/microsoft/vscode-pull-request-github/pull/6389 the summarization should give a summary of every single comment:

It doesn't always work, e.g.:

Log (I don't get the feedback button currently):
copilotLanguageModelWrapper - e60d67f1
Metadata
url              : https://api.enterprise.githubcopilot.com/chat/completions
model            : gpt-4o
maxPromptTokens  : 64000
maxResponseTokens: 4096
location         : 4
postOptions      : {"temperature":0.1,"top_p":1,"max_tokens":4096,"tools":[{"type":"function","function":{"name":"copilot_codebase","description":"Search for relevant file chunks, symbols, and other info about the current workspace or codebase","parameters":{"type":"object","properties":{"query":{"type":"string","description":"The query to search the codebase for. Should contain all relevant context. Can be a full natural language sentence, or keywords."}},"required":["query"]}}},{"type":"function","function":{"name":"copilot_vscodeAPI","description":"Use VS Code API references to answer questions about VS Code extension development.","parameters":{"type":"object","properties":{"query":{"type":"string","description":"The query to search vscode documentation for. Should contain all relevant context."}},"required":["query"]}}},{"type":"function","function":{"name":"github-pull-request_issue_fetch","description":"Get a GitHub issue/PR's details as a JSON object.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue/PR from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue/PR from."},"name":{"type":"string","description":"The name of the repository to get the issue/PR from."}},"required":["owner","name"]},"issueNumber":{"type":"number","description":"The number of the issue/PR to get."}},"required":["issueNumber"]}}},{"type":"function","function":{"name":"github-pull-request_notification_fetch","description":"Get a GitHub notification's details as a JSON object.","parameters":{"type":"object","properties":{"thread_id":{"type":"string","description":"The notification thread id."}},"required":["thread_id"]}}},{"type":"function","function":{"name":"github-pull-request_issue_summarize","description":"Summarizes a GitHub issue or pull request. A summary is a great way to describe an issue or pull request.","parameters":{"type":"object","properties":{"title":{"type":"string","description":"The title of the issue/PR"},"body":{"type":"string","description":"The body of the issue/PR"},"comments":{"type":"array","items":{"type":"string"},"description":"The array of associated string comments"},"fileChanges":{"type":"array","items":{"type":"object","properties":{"fileName":{"type":"string","description":"The name of the file of the change"},"patch":{"type":"string","description":"The patch of the change"}}},"description":"For a PR, the array of associated file changes"}},"required":["title","body","comments"]}}},{"type":"function","function":{"name":"github-pull-request_notification_summarize","description":"Summarizes a GitHub notification. A summary is a great way to describe a notification.","parameters":{"type":"object","properties":{"lastReadAt":{"type":"string","description":"The last read time of the notification."},"lastUpdatedAt":{"type":"string","description":"The last updated time of the notification."},"unread":{"type":"boolean","description":"Whether the notification is unread."},"title":{"type":"string","description":"The title of the notification issue/PR"},"body":{"type":"string","description":"The body of the notification issue/PR"},"unreadComments":{"type":"array","items":{"type":"string"},"description":"The array of unread comments under the issue/PR of the notification"},"threadId":{"type":"number","description":"The thread id of the notification"},"notificationKey":{"type":"string","description":"The key of the notification"},"fileChanges":{"type":"array","items":{"type":"object","properties":{"fileName":{"type":"string","description":"The name of the file of the change"},"patch":{"type":"string","description":"The patch of the change"}},"required":["fileName","patch"]},"description":"For a notification about a PR, the array of associated file changes"}},"required":["title","unreadComments","lastUpdatedAt","unread","threadId","notificationKey"]}}},{"type":"function","function":{"name":"github-pull-request_suggest-fix","description":"Summarize and suggest a fix for a GitHub issue.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue from."},"name":{"type":"string","description":"The name of the repository to get the issue from."}},"required":["owner","name"]},"issueNumber":{"type":"number","description":"The number of the issue to get."}},"required":["issueNumber","repo"]}}},{"type":"function","function":{"name":"github-pull-request_formSearchQuery","description":"Converts natural language to a GitHub search query. Should ALWAYS be called before doing a search.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue from."},"name":{"type":"string","description":"The name of the repository to get the issue from."}},"required":["owner","name"]},"naturalLanguageString":{"type":"string","description":"A plain text description of what the search should be."}},"required":["naturalLanguageString"]}}},{"type":"function","function":{"name":"github-pull-request_doSearch","description":"Execute a GitHub search given a well formed GitHub search query. Call github-pull-request_formSearchQuery first to get good search syntax and pass the exact result in as the 'query'.","parameters":{"type":"object","properties":{"repo":{"type":"object","description":"The repository to get the issue from.","properties":{"owner":{"type":"string","description":"The owner of the repository to get the issue from."},"name":{"type":"string","description":"The name of the repository to get the issue from."}},"required":["owner","name"]},"query":{"type":"string","description":"A well formed GitHub search query using proper GitHub search syntax."}},"required":["query","repo"]}}},{"type":"function","function":{"name":"github-pull-request_renderIssues","description":"Render issue items from an issue search in a markdown table. The markdown table will be displayed directly to the user by the tool. No further display should be done after this!","parameters":{"type":"object","properties":{"arrayOfIssues":{"type":"array","description":"An array of GitHub Issues.","items":{"type":"object","properties":{"title":{"type":"string","description":"The title of the issue."},"number":{"type":"number","description":"The number of the issue."},"url":{"type":"string","description":"The URL of the issue."},"state":{"type":"string","description":"The state of the issue (open/closed)."},"createdAt":{"type":"string","description":"The creation date of the issue."},"updatedAt":{"type":"string","description":"The last update date of the issue."},"closedAt":{"type":"string","description":"The closing date of the issue."},"author":{"type":"object","description":"The author of the issue.","properties":{"login":{"type":"string","description":"The login of the author."},"url":{"type":"string","description":"The URL of the author's profile."}}},"labels":{"type":"array","description":"The labels associated with the issue.","items":{"type":"object","properties":{"name":{"type":"string","description":"The name of the label."},"color":{"type":"string","description":"The color of the label."}}}},"assignees":{"type":"array","description":"The assignees of the issue.","items":{"type":"object","properties":{"login":{"type":"string","description":"The login of the assignee."},"url":{"type":"string","description":"The URL of the assignee's profile."}}}},"commentsCount":{"type":"number","description":"The number of comments on the issue."}}},"required":["title","number","url","state","createdAt","author","commentCount","reactionCount"]},"totalIssues":{"type":"number","description":"The total number of issues in the search."}},"required":["arrayOfIssues","totalIssues"]}}},{"type":"function","function":{"name":"searchConfigurations","description":"Use this tool to search for settings and commands. This will return all those settings and commands that contain the provided keywords. Each result will have a type to know if it is a setting or a command. A setting includes the description, default value, current value and other possible values and a command includes the description and possible arguments to be used to invoke the command.","parameters":{"type":"object","properties":{"keywords":{"type":"string","description":"List of keywords to search for the settings and commands"}}}}},{"type":"function","function":{"name":"updateSettings","description":"Use this tool to update settings. This tool support bulk updates, so you can update multiple settings at once. Provide the settings to update as a key value pair of setting id and new value. The value of the setting must follow the setting schema.","parameters":{"type":"object","description":"Dictionary of settings to update. The key is the setting id and the value is the new value of the setting.","properties":{},"additionalProperties":true}}},{"type":"function","function":{"name":"runCommand","description":"Use this tool to run a command. This tool will run the command with the provided arguments if the command supports them. The arguments must follow the command arguments schema provided by the searchConfigurations.","parameters":{"type":"object","properties":{"key":{"type":"string","description":"Id of the command"},"argumentsArray":{"type":"string","description":"Arguments to pass to the command as JSON stringified array"}}}}},{"type":"function","function":{"name":"vscode-websearchforcopilot_webSearch","description":"Search the web for relevant up-to-date information","parameters":{"type":"object","properties":{"query":{"type":"string","description":"The query to search the web for"}},"required":["query"]}}}],"stream":true}
intent           : undefined
startTime        : 2024-10-24T08:10:49.305Z
endTime          : 2024-10-24T08:10:52.701Z
duration         : 3396ms
ourRequestId     : 563a7fbd-c56b-4e38-be0c-d7c7a82a504b
requestId        : 563a7fbd-c56b-4e38-be0c-d7c7a82a504b
serverRequestId  : 563a7fbd-c56b-4e38-be0c-d7c7a82a504b
timeToFirstToken : 888ms
Request Messages
System
Follow Microsoft content policies.
Avoid content that violates copyrights.
If you are asked to generate content that is harmful, hateful, racist, sexist, lewd, violent, or completely irrelevant to software engineering, only respond with "Sorry, I can't assist with that."
Keep your answers short and impersonal.
Use Markdown formatting in your answers.
Make sure to include the programming language name at the start of the Markdown code blocks.
Avoid wrapping the whole response in triple backticks.
The user works in an IDE called Visual Studio Code which has a concept for editors with open files, integrated unit test support, an output pane that shows the output of running the code as well as an integrated terminal.
The active document is the source code the user is looking at right now.
You can only give one reply for each conversation turn.
Assistant
Instructions:
- The user will ask a question related to GitHub, and it may require lots of research to answer correctly. There is a selection of tools that let you perform actions or retrieve helpful context to answer the user's question.
- If you aren't sure which tool is relevant, you can call multiple tools. You can call tools repeatedly to take actions or gather as much context as needed until you have completed the task fully. Don't give up unless you are sure the request cannot be fulfilled with the tools you have.
- Don't ask the user for confirmation to use tools, just use them.
- When talking about issues, be as concise as possible while still conveying all the information you need to. Avoid mentioning the following:
- The fact that there are no comments.
- Any info that seems like template info.
User
Summarize microsoft/vscode-copilot#7221
Assistant
🛠 {"id":"call_t4SMJRfggfnkq8gfKcP7Uuwn","type":"function","function":{"name":"github-pull-request_issue_fetch","arguments":"{\"issueNumber\":7221,\"repo\":{\"name\":\"vscode-copilot\",\"owner\":\"microsoft\"}}"}}
Tool
🛠 call_t4SMJRfggfnkq8gfKcP7Uuwn
{"owner":"microsoft","repo":"vscode-copilot","title":"UX: Better entry point for code reviews in SCM","body":"✨ doesn't make to make code review easy enough to discover as the icon is over-loaded as AI smart action and is only available on hover for changes.\n\n1. UI element that is easy to understand. ✨ on the changes could mean a lot of different things (my first thought is always _smart staging_)\n2. Place it where it can be easily found and used as a user works on a commit/branch.\n3. We might want to offer other _\"compare with\"_, like #7068, should those be offered as drop-down?","comments":[{"body":"Came up a lot pre-Universe from various people who tried to find this feature. The hover-only sparkle is way too hidden.\n\nMonkeypatch idea for Universe until we find a better UX: Show the sparkle always for _Staged_ and _Changes_, right aligned from the hover buttons. cc @lszomoru for thoughts.","author":"digitarald"},{"body":"The visibility of all actions in the Source Control view can be toggled using the `scm.alwaysShowActions` setting. I do not believe that we should create actions that are \"always\" visible and do not respect the setting. ","author":"lszomoru"},{"body":"https://github.com/microsoft/vscode-copilot/pull/9454 for the icon change","author":"daviddossett"},{"body":"The actions in the view titlebar are shown whenever the mouse is anywhere over the view, i.e., much more than the actions on the Changes / Staged Changes node. Maybe we could also add it there and let it review all local changes.\n![Image](https://github.com/user-attachments/assets/eb587144-1ab6-4446-8ec5-48bb01801bfc)\n","author":"chrmarti"}]}
User
Above is a stringified JSON representation of the issue or pull request. This can be passed to other tools for further processing.
User
Above is the result of calling the functions github-pull-request_issue_fetch.
Assistant
🛠 {"id":"call_nWDplvughKYl7v7DhjG7ggkq","type":"function","function":{"name":"github-pull-request_issue_summarize","arguments":"{\"title\":\"UX: Better entry point for code reviews in SCM\",\"body\":\"✨ doesn't make to make code review easy enough to discover as the icon is over-loaded as AI smart action and is only available on hover for changes.\\n\\n1. UI element that is easy to understand. ✨ on the changes could mean a lot of different things (my first thought is always _smart staging_)\\n2. Place it where it can be easily found and used as a user works on a commit/branch.\\n3. We might want to offer other _\\\"compare with\\\"_, like #7068, should those be offered as drop-down?\",\"comments\":[\"Came up a lot pre-Universe from various people who tried to find this feature. The hover-only sparkle is way too hidden.\\n\\nMonkeypatch idea for Universe until we find a better UX: Show the sparkle always for _Staged_ and _Changes_, right aligned from the hover buttons. cc @lszomoru for thoughts.\",\"The visibility of all actions in the Source Control view can be toggled using the `scm.alwaysShowActions` setting. I do not believe that we should create actions that are \\\"always\\\" visible and do not respect the setting.\",\"https://github.com/microsoft/vscode-copilot/pull/9454 for the icon change\",\"The actions in the view titlebar are shown whenever the mouse is anywhere over the view, i.e., much more than the actions on the Changes / Staged Changes node. Maybe we could also add it there and let it review all local changes.\\n![Image](https://github.com/user-attachments/assets/eb587144-1ab6-4446-8ec5-48bb01801bfc)\"]}"}}
Tool
🛠 call_nWDplvughKYl7v7DhjG7ggkq
### Summary

**Title:** UX: Better entry point for code reviews in SCM

**Body:**
- The current icon for code review is overloaded as an AI smart action and only appears on hover for changes, making it hard to discover.
- Suggestions:
  1. Use a UI element that is easy to understand. The current ✨ icon could be misinterpreted (e.g., as _smart staging_).
  2. Place the code review option where it can be easily found and used during commit/branch work.
  3. Consider offering other _"compare with"_ options, similar to [#7068](https://github.com/undefined/undefined/issues/7068), possibly as a drop-down menu.

**Comments:**
- **Comment 0:** (Author: undefined) - No additional information provided.
- **Comment 1:** (Author: undefined) - No additional information provided.
- **Comment 2:** (Author: undefined) - No additional information provided.
- **Comment 3:** (Author: undefined) - No additional information provided.
User
Above is the result of calling the functions github-pull-request_issue_summarize.
Response
Assistant
### Summary

**Title:** UX: Better entry point for code reviews in SCM

**Body:**
- The current icon for code review is overloaded as an AI smart action and only appears on hover for changes, making it hard to discover.
- Suggestions:
  1. Use a UI element that is easy to understand. The current ✨ icon could be misinterpreted (e.g., as _smart staging_).
  2. Place the code review option where it can be easily found and used during commit/branch work.
  3. Consider offering other _"compare with"_ options, similar to [#7068](https://github.com/undefined/undefined/issues/7068), possibly as a drop-down menu.

**Comments:**
- **Comment 1:** The hover-only sparkle is too hidden. Suggestion: Show the sparkle always for _Staged_ and _Changes_, right aligned from the hover buttons.
- **Comment 2:** The visibility of all actions in the Source Control view can be toggled using the `scm.alwaysShowActions` setting.
- **Comment 3:** A pull request for the icon change has been created.
- **Comment 4:** Actions in the view titlebar are shown whenever the mouse is over the view. Suggestion: Add the review option there to review all local changes.

This is with GitHub Pull Requests v0.99.2024102404.

Hi thanks for verifying. I will make the prompt stricter about this.

Turns out that in the package.json the summarization tool was not correctly defined too, which I think was contributing to this issue.


chore(main): release 1.29.0

:robot: I have created a release beep boop
1.29.0 (2024-09-09)
Features

export all fluent type (a4df553)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Andesite-Lab/Core/releases/tag/v1.29.0 :sunflower:


Unable to produce deployable project from source

Hello,
Ideally, I'd like to mirror the source in my own repo and deploy updates via CI/CD, but I'm having no luck setting up such a deployment locally, let alone in DevOps. I followed the instructions for building it myself:
dotnet build dirs.proj
dotnet test dirs.proj
dotnet pack dirs.proj

I see that /out/bin/Debug-x64 is populated with folders for the various projects and services, but the format doesn't resemble what I'm used to seeing if I right click an sfproj project in Visual Studio and select package. I expect to see an output directory (typically in /<SfProjectName>/pkg/<buildTarget>) populated with directories for each service (e.g. "MyServicePkg/") and the ApplicationManifest.xml, but I don't see this produced anywhere.
Three questions then:

How can I change the directory to which this is outputting the packaged app?
How do I change the target (e.g. to Release)?
How do I get this to build such that I can extract the directory and produce my own sfpkg file?

Thanks!

Hello,
If you want to build the SF pkg via command prompt or PowerShell instead of using Visual studio then try the following.
First need to install some tools:

Install both NuGet.exe and MSBuild.exe. Install NuGet from here https://docs.microsoft.com/en-us/nuget/reference/nuget-exe-cli-reference#installing-nugetexe and install MSBuild from here . If you have already installed VS then it can already be installed, for me its located "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin". Alternatively, can try using "dotnet msbuild ..."  instead but people have reported issues: https://github.com/microsoft/service-fabric/issues/907.
(Optional) Add the folder where you placed nuget.exe and MSBuild.exe to your PATH environment variable to use the CLI tool from anywhere

Then do the following to restore, build and package SF app.

dotnet build projects - dotnet restore .\dirs.proj
nuget restore on .sln -> nuget restore .\YarpSF.sln
msbuild on .sln -> msbuild .\YarpSF.sln /p:configuration="Release"
msbuild /t:package on sfproj -> msbuild ./src/YarpProxyApp/YarpProxyApp.sfproj /t:Package /p:PackageLocation=c:\temp\sfbuildout /p:platform="x64" /p:configuration="Release"

To create sfpkg look here: https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-package-apps#create-an-sfpkg
To create CI/CD pipeline for SF app Azure DevOps look here: https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-tutorial-deploy-app-with-cicd-vsts
Let me know if you have any issues with the above steps or have any questions.

I hope the steps above helped. Closing this issue for now since have not heard back with a response.


fix: now using promise-pool-ext

:tada: This PR is included in version 2.4.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Append does not work on lists

Is this behaviour intended?
In [1]: from sqlitedict import SqliteDict

In [2]: db_test = SqliteDict("db_test.db", autocommit=True)

In [3]: db_test['test'] = []

In [4]: db_test['test'].append(1)

In [5]: db_test['test']
Out[5]: []

In [6]:

Yes, see the README.


chore: bump version to 0.1.4

Some notable changes have been introduced that are worthy of a new release:

Support for init args.
Switching the runtime from drun to PocketIC

Should we establish proper releases like with stable structures? This way we can also have a log of what changed/added to each release.

It's a bit tricky because we have two versions to track: canbench-bin, the binary, and canbench-rs, the rust library. Any ideas on how to track the two artifacts with their different versioning in github releases?

Maybe the easiest solution would be to simply increment the versions of both with every release, WDYT?

Yeah that would certainly be the easiest. They are also very closely related -- unlike for example the bitcoin and watchdog canisters which are two separate binaries and there it makes sense to have a separate release.


Ityfuzz ignores contract ownership

Following contracts give corpus items with non-reverted status, though in fact default callers don't have permission to call functions due to onlyGovernor modifier. I thought that there is some voting mechanism based on token quantity, but even with flashloan and oracles disabled result doesn't change.
ETH: 0x72426BA137DEC62657306b12B1E869d43FeC6eC7,0xa7695eED05094E28AA575CB0cCa3CF17848a7981,0x0D017aFA83EAce9F10A8EC5B6E13941664A6785C,0xc0F42F73b8f01849a2DD99753524d4ba14317EB3,0x77314EB392b2be47C014cde0706908b3307Ad6a9,0xcecaD69d7D4Ed6D52eFcFA028aF8732F27e08F70,0x9c354503c38481a7a7a51629142963f98ecc12d0,0x80c898ae5e56f888365e235ceb8cea3eb726cb58,0x5A4eEe58744D1430876d5cA93cAB5CcB763C037D,0xDcEe70654261AF21C44c093C300eD3Bb97b78192,0x501804B374EF06fa9C427476147ac09F1551B9A0,0x3fF8654D633D4Ea0faE24c52Aec73B4A20D0d0e5,0x0c4576ca1c365868e162554af8e385dc3e7c66d9,0x89eb88fedc50fc77ae8a18aad1ca0ac27f777a90,0x21fb5812d70b3396880d30e90d9e5c1202266c89,0x2A8e1E676Ec238d8A992307B495b45B3fEAa5e86,0x5e3646A1Db86993f73E6b74A57D8640B69F7e259,0x1827F9eA98E0bf96550b2FC20F7233277FcD7E63,0x7d82e86cf1496f9485a8ea04012afeb3c7489397,0xe75d77b1865ae93c7eaa3040b038d7aa7bc02f70,0x39254033945AA2E4809Cc2977E7087BEE48bd7Ab,0xea2ef2e2e5a749d4a66b41db9ad85a38aa264cb3,0x856c4Efb76C1D1AE02e20CEB03A2A6a08b0b8dC3,0x9c459eeb3FA179a40329b81C1635525e9A0Ef094

#52 #137
the problem has been found.

The problem lies again at control leak check. evm/host.rs. And different methods that are protected by modifiers occurs in both 3 places in fn call(&mut self, input: &mut CallInputs, state: &mut S) -> (InstructionResult, Gas, Bytes) where ControlLeak could be returned.

For this issue, I still need to further investigate the reasons behind it.

yeah, it is due to control leak. trying to fix in #156


caching doc fix

missing an important 'not' :)

@dclim should probably backport this one

@fjy created backport PR to 0.9.0 #2667

:+1:


Test travis

Thanks Mike, seems like it worked since I was able to merge the Azure docs update PR.


Add a warning for use case of Backup from MR DB restored into Non-MR DB

When a user takes a backup from a MR DB, they have no idea that they cannot restore it into a Non-MR DB. We should include a "warning" to that effect on the Backup page, Restore page and the Known limitations page -- for both 21.1 and 21.2 docs as well as Cockroach Cloud docs.
CC: @adityamaru

Migrating to JIRA: https://cockroachlabs.atlassian.net/browse/CC-5433


Revert "Revert "Fix shutdown of closed fd when c-ares opens a second fd""

This reverts https://github.com/grpc/grpc/pull/15685
The issue with the original PR was that the socket stress loop wasn't setting SO_REUSEADDR on its newly opened sockets. In each of the failed tests in the sponge log of the previous failures, the sockets stress loop fails to bind to it's socket due to errno: 98.
Presumably this started happening on continuous Kokoro runs pretty quickly because of the business of those tests.
The error could be reliably reproduced locally by:

Hack the sockets stress loop to use some static port, rather than picking one from the port server (e.g., port 12000).
Start up some TCP server on your machine that listens on port 12000.
Set up some connection to that server and send something.
Bring down the server abruptly, while the client is still connected
Run bins/dbg/resolver_component_tests_runner_invoker --test_bin_name=resolver_component_test, and watch the sockets stress loop fail to bind to its port with errno: 98

****************************************************************

libgrpc.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                            ++++++++++++++
  +0.0%      +8 [None]                                                                                +968  +0.0%
  +0.6%     +64 src/core/lib/iomgr/ev_epollex_linux.cc                                                 +64  +0.6%
       +89%     +73 fd_shutdown                                                                            +73   +89%
  +0.6%     +16 src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_ev_driver_posix.     +16  +0.6%
       +21%    +213 grpc_ares_notify_on_event_locked                                                      +213   +21%
      [NEW]    +116 fd_node_shutdown_locked(fd_node*, char const*) [clone .isra.1] [clone .part.2]        +116  [NEW]
       +22%     +64 grpc_ares_ev_driver_create                                                             +64   +22%

  +0.0%     +88 TOTAL                                                                              +1.02Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                                                cpu_time    real_time
----------------------------------------------------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/32768                                              +4%         +4%
BM_PumpStreamClientToServer<InProcessCHTTP2>/32768                                        +8%         +8%
BM_PumpStreamServerToClient<InProcess>/32768                                              +5%         +5%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768                       -4%         -4%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768                    -6%         -6%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/2/0  -5%         -5%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/262144                       +5%         +5%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/2097152                        +7%         +7%

This one is ready for a look

test failures:

linux: https://github.com/grpc/grpc/issues/15693
windows: https://github.com/grpc/grpc/issues/15693
mac: https://github.com/grpc/grpc/issues/15693,


Fixed reload 404 error. Implemented getServersideProps() to access content

ℹ Repository information
Implemented getServerSideProps to access the data from JSON file.
The repository has:

[ ] At least three issues with the good first issue, or other labels specified in firstissue.json (see labels and the end).
Link:
[ ] At least 10 contributors.
[ ] At least 1000 stars.
[ ] Detailed setup instructions for the project.
Link:
[ ] CONTRIBUTING.md
[ ] Actively maintained (last updated less than 1 months ago).

@romeshkosme  Thanks for your contribution! I am just back from my holidays - I will have a look at the PR soon. 🙏🏼  again for the refactoring!

Hello! I tested these changes, but getServersideProps does not work when the site is being exported as static html. Since the website is static, this fix won't do it here. Are there alternatives?


VScode 能使用 WSL中安装的Git&Python

网上有支持：http://blog.plusls.cn/windows/vscode-using-python-in-wsl/
但不够完整，期望官方给予这些功能.
期待：VScode 能直接使用 WSL 下安装的 Git/Python/PHP等。利于集成开发

This issue was closed because it doesn't meet our standards of a properly filled issue. Please read our guide about Submitting Bugs and Suggestions.


Bootstrap selectpicker's dropdown menu is being overlapped by Jconfirm box

I've a problem here. I read the issue with the datepicker (issue 212), and worked with the z-index for the selectpicker's dropdown menu but it didn't work.

That selectpicker is from Bootstrap Select. I tried to lower the z-index of the jconfirm's box, and increases the z-index of the dropdown menu, but still it didn't work.
I need to make it so that the dropdown menu will display on top of the confirm box.

Hi,
try data-container=".jconfirm"
bye


Set filetype to allow easier mapping customization

Could you please add set filetype=startuptime or similar for the startuptime buffer? This would be useful e.g. for making a ftplugin to set up additional mappings for the startuptime results buffer (such as mapping q to quit the buffer, etc.)

Good idea. Thanks!
The vim-startuptime buffer now has filetype=startuptime (3dbec6d2c9fc97ec12b2391c6b92208179bc36c4).


Improve the csv file linkage with Freecen2Place

Have modified the rake task foo:check_and_refresh_freecen2_places_cache to confirm that the freecen2place link is set for csv files.
Still need to add to the incorporation rake task


KAFKA-2452: Add new consumer option to mirror maker.

Change looks good afaict. It doesn't look like MirrorMaker has any tests. @becketqin how did you test this?

Ignore previous - looks like there is related dialog in the jira itself. @gwenshap can we merge this?

@guozhangwang Thanks for the review. I addressed you comments. It looks the test failure is irrelevant. Mind take another look?

LGTM


census cell dup check

Initial commit of a notebook/tool which searches for potentially mislabeled copies of duplicate cells, i.e., those with potentially incorrect is_primary_data metadata.
PR also includes a change to the pre-commit configuration to lint items in the tools directory beyond the builder.

FYI: @jahilton

include the collection_id if readily available

@jahilton - the Census has no knowledge of collections and I've been repeatedly waved off from including it.
@brianraymor - is there a REST API that I can hit to map a dataset_id to a collection_id?


Speed up Hatch installation

This is the new way, speedup on Windows ~35-50%, other platforms 2-3x

It seems that it is not working.

Yeah, figuring out the best way to fix Windows. I can't just do ./main.sh because that is in the directory where the action is checked out so you must do a full path. When the shell is bash the backslashes aren't treated literally and therefore get stripped which makes it so the full path doesn't exist. When the shell is not specified it works because then Windows uses PowerShell but every step of an action requires an explicit shell... so might have to have 2 steps that are conditional based on the platform because you cannot use conditional syntax within the shell value. Nightmare.

Windows:

Old: 35s
New: 12s

Linux:

Old: 12s
New: 2s

macOS:

Old: 10s
New: 5s, although on macOS 14/ARM it's similar to Linux (sometimes 3 seconds rather than 2, Linux is consistently 2)

Everything is fixed now, thanks for your patience!


Bug: Upgrade to v2.3.0.RELEASE throws nested exception at runtime

Affects Version(s): \2.3.0.RELEASE
Upon upgrade to 2.3.0.RELEASE
runtime error:
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.kafka.config.internalKafkaListenerAnnotationProcessor': Instantiation of bean failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.kafka.annotation.KafkaListenerAnnotationBeanPostProcessor]: Constructor threw exception; nested exception is java.lang.NoClassDefFoundError: org/springframework/core/log/LogAccessor
--Reverted back to 2.2.9.RELEASE, no issues
--tested previous version 2.2.8.RELEASE, no issues

You have to use Spring Framework 5.2 which is a minimal requirements for this spring-kafka-2.3.0.RELEASE.
However it may sound like you use Spring Boot 2.1.x, where Spring Kafka 2.3 is for Spring Boot 2.2.
Consider to upgrade to that one. RC1 has been released a couple days ago: https://spring.io/blog/2019/10/03/spring-boot-2-2-0-rc1-has-been-released

Please, let us know how it is for you and we will close this with a Works as Designed resolution.

Boot 2.2 GA is currently scheduled for Oct 16.