sail run cdr/sail fails "Unknown option --data-dir"

OS: Ubuntu 18.04 LTS desktop (running in virtual machine)
Docker: 19.03.8
Git: 2.17.1
Here is the end of the console output:
chafey@linuxmint:~$ sail run cdr/sail
2020-04-04 15:22:03 INFO	running docker build --network=host -t cdr_sail -f /home/chafey/Projects/cdr/sail/.sail/Dockerfile /home/chafey/Projects/cdr/sail --label com.coder.sail.base_image=cdr_sail
Sending build context to Docker daemon  9.506MB
Step 1/7 : FROM codercom/ubuntu-dev-go:latest
 ---> 1dae51fcd27f
Step 2/7 : SHELL ["/bin/bash", "-c"]
 ---> Using cache
 ---> 0f2735aed597
Step 3/7 : RUN sudo apt-get update &&     sudo apt-get install -y htop
 ---> Using cache
 ---> 787baab67bde
Step 4/7 : RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash &&   . ~/.nvm/nvm.sh   && nvm install node
 ---> Using cache
 ---> 727021ac2bb8
Step 5/7 : LABEL project_root "~/go/src/go.coder.com"
 ---> Using cache
 ---> 49715d1d7243
Step 6/7 : RUN wget -O /tmp/hugo.deb https://github.com/gohugoio/hugo/releases/download/v0.55.4/hugo_extended_0.55.4_Linux-64bit.deb &&   sudo dpkg -i /tmp/hugo.deb &&   rm -f /tmp/hugo.deb
 ---> Using cache
 ---> f72071ec13e9
Step 7/7 : LABEL com.coder.sail.base_image=cdr_sail
 ---> Using cache
 ---> 9cf7d7d1fd51
Successfully built 9cf7d7d1fd51
Successfully tagged cdr_sail:latest
2020-04-04 15:22:04 INFO	using repo image cdr_sail
2020-04-04 15:22:04 INFO	writing sail proxy logs to /tmp/sailproxy_cdr_sail142932399
2020-04-04 15:22:05 ERROR	failed to wait for project to be online: container cdr_sail not running
+ cd /home/user/go/src/go.coder.com/sail
+ sudo chown user:user /home/user/.vscode
+ code-server --host localhost --port 0 --data-dir /home/user/.config/Code --extensions-dir /home/user/.vscode/host-extensions --extra-extensions-dir /home/user/.vscode/extensions --allow-http --no-auth
+ tee /tmp/code-server.log
Unknown option --data-dir
2020-04-04 15:22:05 ERROR	build run failed: container cdr_sail not running

Building and running the master version of sail did not resolve this issue, but it did produce a new error:
chafey@linuxmint:~/src/sail$ ./sail run cdr/sail
2020-04-05 14:34:20 INFO        running docker build --network=host -t cdr_sail -f /home/chafey/Projects/cdr/sail/.sail/Dockerfile /home/chafey/Projects/cdr/sail --label com.coder.sail.base_image=cdr_sail
Sending build context to Docker daemon  9.506MB
Step 1/7 : FROM codercom/ubuntu-dev-go:latest
 ---> 1dae51fcd27f
Step 2/7 : SHELL ["/bin/bash", "-c"]
 ---> Using cache
 ---> 0f2735aed597
Step 3/7 : RUN sudo apt-get update &&     sudo apt-get install -y htop
 ---> Using cache
 ---> 787baab67bde
Step 4/7 : RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash &&   . ~/.nvm/nvm.sh   && nvm install node
 ---> Using cache
 ---> 727021ac2bb8
Step 5/7 : LABEL project_root "~/go/src/go.coder.com"
 ---> Using cache
 ---> 49715d1d7243
Step 6/7 : RUN wget -O /tmp/hugo.deb https://github.com/gohugoio/hugo/releases/download/v0.55.4/hugo_extended_0.55.4_Linux-64bit.deb &&   sudo dpkg -i /tmp/hugo.deb &&   rm -f /tmp/hugo.deb
 ---> Using cache
 ---> f72071ec13e9
Step 7/7 : LABEL com.coder.sail.base_image=cdr_sail
 ---> Using cache
 ---> 9cf7d7d1fd51
Successfully built 9cf7d7d1fd51
Successfully tagged cdr_sail:latest
2020-04-05 14:34:21 INFO        using repo image cdr_sail
2020-04-05 14:34:21 INFO        writing sail proxy logs to /tmp/sailproxy_cdr_sail659976749
2020-04-05 14:34:22 ERROR       failed to wait for project to be online: container cdr_sail not running
+ cd /home/user/go/src/go.coder.com/sail
+ sudo chown user:user /home/user/.vscode
+ tee /tmp/code-server.log
+ /usr/bin/code-server --host localhost --port 0 --user-data-dir /home/user/.config/Code --extensions-dir /home/user/.vscode/host-extensions --extra-extensions-dir /home/user/.vscode/extensions --auth=none --allow-http
Unknown option --allow-http
2020-04-05 14:34:22 ERROR       build run failed: container cdr_sail not running

Digging into this more and am discovering some really strange things.  Sail depends on the docker image codercom/ubuntu-dev-go:latest which was updated on 3/18/2020 with digest 36afe0c005fc.  This image includes version 3.0.1 of code-server which was released 3/27/202 which is a whole 9 days AFTER the docker image was created.  How can a docker image include a piece of software that hasn't been released yet?  Perhaps I am misunderstanding things, but this project may be compromised - best to steer clear until the maintainers fix things and explain what happened

It looks like this should be resolved by https://github.com/cdr/sail/issues/268


all: add mux for db connections

This PR is using a mux inspired by Atlas which is now in charge of the connection to DB.
The SchemaImporter now only implements dialect specific converters.
Updated the readme and CLI to use mux.

Looks good, besides one comment.

changed it.


Automated deletion for images in the container registry

Feature Description
I'm heavily using the package registry introduced with Gitea 1.17 (using 1.17.0+rc2 at the moment).  This starts to consume lots of space on my hard disk.
It would be nice, if Gitea would have the possibility to automatically delete packages (especially container images) after a configurable time. The configuration could come from the linked repository.
Gitlab has a similar feature allowing to configure a time to keep images (e.g. at least 2 weeks) and the amount of images to keep (e.g. keep the last 5 images).  So only if both conditions were exceeded it would delete the images.
Alternatively it would already be helpful to allow bulk deletion using a checkbox in the packages list. Right now I need a lot of clicks to delete old packages (6 per container image starting on the packages overview list). And every time I delete one old image I'm back on the packages overview site.
Screenshots
No response

related #20766

Implemented this in #21658.


Update stm32cubeide.rb

Thanks! I'll update soon :)

I've updated cubeide -- can you test and report issues?


Integrate with cdxgen

Nice project!
I'm the author cdxgen a tool to generate rich software bill-of-materials
https://github.com/CycloneDX/cdxgen
We recently added a command called evinse to detect API endpoints in Java, Javascript, typescript code using static analysis.

Below are the links to evinse command, CycloneDX specification and a sample json generated with endpoints.
https://github.com/CycloneDX/cdxgen/blob/master/ADVANCED.md#evinse-mode
https://cyclonedx.org/docs/1.5/json/
bom.evinse.json.txt
It would be nice to see cdx integrated into this project so that your platform could work with both static and runtime data.

@prabhu thanks for sharing this, we definitely are looking into this actively. thank you! @ankush-jain-akto


First assessment of new panan-01 and panan-005: Ready to save with higher frequency output?

We now have 20 years of panan-01 and 7 years of panan-005, so I looked into some key metrics the assess them. If there are no major concerns about any of these, I would like to run panan-005 further and save daily output.
The shift of SWMT peak to lighter density classes in panan-01 is significantly reduced, but there is still a slight shift in the Adelie and Ross.
No shift of the peak SWMT density in panan-005, except for an initial shock, and higher SWMT and about 2 Sv higher cross contour transport in panan-005 compared to pnan-01.

Time series of othe rproperties can be found here
Some properties (e.g. MOC, T and S on the shelf) are still drifting but that's probably nothing too big. In the case of the T and S below 3000 m everywhere the drift is reduced a lot in panan-005 compared to panan-01.
I think it looks ok for our purposes and I would continue panan-005 saving higher frequency output. I don't think I need to save anything with a higher frequency than daily as we are not using panan-005 to create movies?

[ ]  Daily temperature: thetao
[ ]  Daily salinity: so
[ ]  Daily u,v: uo,vo
[ ]  Daily mixed layer depth  mlotst
[ ]  Monthly T advection zonal, meridional T_adx,T_ady
[ ]  Monthly surface mass flux wfo
[ ]  Monthly net surface boundary heat flux hfds
[ ]  Monthly Net salt flux into ocean at surface (restoring + sea-ice) salt_flux
[ ]  Daily mean SIC,SIT siconc,sithick
[ ]  daily SSH zos
[ ]  daily SSH snapshots zos

If there are no objections I will continue panan-005 at the end of the week and save all of the variables above in addition to what is already saved.
Something that is strange in both panan-01 and panan-005 is the age tracer at the northern boundary. It looks like it gets reset to 0 at the boundary. I haven't looked in the code at all yet whether we can change that. I wanted to use the age tracer at the bottom to trace the AABW pathway but now the signal of AABW gets overwhelmed by the inflow from the north.
https://github.com/COSIMA/mom6-panan/assets/38216156/8da68f70-df0f-4af2-9930-5a26bea821bd

Nice evaluation Christina.
Bugger about the age tracer, I guess we should have thought of that before! I think we may still be able to use it in the first ~10 years though, because it looks like there is still a separation between the young Antarctic-sourced waters and the low age coming from the north. Much beyond 10 years and that might not be the case though.
I think it would be worthwhile to have a meeting with @schmidt-christina, @willaguiar and I (and anyone else who would like to join) to think about exactly what analysis we envisage doing with the output from these runs and make sure we have everything covered. e.g. some additional diags we might want to consider are:

daily depth integrated x,y heat transport (2D)
daily heat, freshwater and salt fluxes - would these be better for more accurate SWMT? (2D)
monthly sea ice transport
Do we have any mixing diagnostics turned on? If not, maybe we want monthly 3D net diffusivity to look at mixing along AABW pathways? Or are there other diagnostics that would be useful to get at this question?

What do we envisage using daily u, v, temp, salt for? Would we be better off with daily mass transports on density layers instead of daily u and v? That would enable us to look at high frequency variability in bottom water, and probably we could still use them for ASC studies?

Good idea to meet Adele, but I will only be working until next Thursday, before taking two days off and then flying to Germany.
I haven't looked into which mixing diagnostics to turn on, but that's on my list of things to check.
@MatthisAuger should probably join such a meeting as he wants to use panan-005 and needs daily u,v,T,S

Would be interested to join such a meeting indeed!
I probably could do part of the analysis I'm planning to do with daily mass transport on density layer. Daily T,S at least would still be very useful for studying the dense water overflows, so I can evaluate the contribution of steric height on the SSH signal and look at the T/S variability of the overflows.

Agreed on the meeting
For my Antarctic Slope Current project, Ill need mostly daily depth integrated x,y heat transport (2D), and perhaps daily u,v , or depth integrated mass transports

A bit more than 1 year of high frequency output is available now. You can access it using this database /g/data/e14/cs6673/mom6_comparison/Python_scripts/panan_005deg_jra55_ryf.db using the expt name panan_005deg_jra55_ryf. The data is here /scratch/e14/cs6673/mom6/archive/panan_005deg_jra55_ryf_2023_05_17/ with daily output starting in output108. Only the output unitil output120 is cleaned up atm, so the first year. I will clean up the output of year 2 and 3 when it's available next week.

I also transferred the latest panan-01 data here (overwriting the old data
there):
/g/data/ik11/outputs/mom6-panan/panant-01-zstar-ACCESSyr2/
I have yet to rerun the years with high frequency output.
On Thu, 22 Jun 2023 at 16:28, Christina Schmidt @.***>
wrote:

A bit more than 1 year of high frequency output is available now. You can
access it using this database
/g/data/e14/cs6673/mom6_comparison/Python_scripts/panan_005deg_jra55_ryf.db
using the expt name panan_005deg_jra55_ryf. The data is here
/scratch/e14/cs6673/mom6/archive/panan_005deg_jra55_ryf_2023_05_17/ with
daily output starting in output108. Only the output unitil output120 is
cleaned up atm, so the first year. I will clean up the output of year 2 and
3 when it's available next week.
—
Reply to this email directly, view it on GitHub
https://github.com/COSIMA/mom6-panan/issues/48#issuecomment-1602078485,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA44U5WALXLW47FMDM2KM3XMPQ2HANCNFSM6AAAAAAZEO5RXQ
.
You are receiving this because you commented.Message ID:
@.***>

Hi @schmidt-christina and thanks again for the outputs.
I get an error when trying to open them from my Jupyter Notebook sessions.
If I try cc.database.create_session('/g/data/e14/cs6673/mom6_comparison/Python_scripts/panan_005deg_jra55_ryf.db')
I get OperationalError: (sqlite3.OperationalError) unable to open database file
I can't access it either when trying to directly open the ncfiles from your folders.
It might be a file permission issue?

@MatthisAuger Christina is away on leave at the moment. I would suggest requesting to join the e14 project (and send Rishav Goyal and Matt England an email explaining you need to access the data). The files have e14 group reading permissions on scratch.
@schmidt-christina when you're back it would be good to transfer the output to ik11.

Oh sorry my mistake actually. Switched to ARE recently and forgot I had to add e14 manually when creating a session.

I think my problem come from the data being on /scratch/e14 and not on /g/data/e14. I can access /scratch/e14 from my terminal but not from my jupyter notebook. On the later one I can only access /g/data/e14. Does that make sense?

Did you add access to scratch/e14 in the storage line as well as gdata?

Much better indeed. Sorry about that and thanks @adele157

All data is now on ik11 in
/g/data/ik11/outputs/mom6-panan/panant-005-zstar-ACCESSyr2


Azure pipelines

PR checklist

[x] Addresses an existing issue: fixes #656 , refer to PR #655
[x] New feature, bugfix, or enhancement

[ ] Includes tests

[ ] Documentation update

Overview of change:
Add support for CI using Azure Pipelines
Is there anything you'd like reviewers to focus on?
I have created a build pipeline for tslint-microsoft-contrib project here: https://dev.azure.com/ms/tslint-microsoft-contrib
Microsoft employees should all have access to this already. Currently it's building off of my fork of the project, however, you or Will Smythe can change it to point to your repo.
I had to add the reporter to publish the results:

However, I found a new solution so that the reporter will not affect developers working on this project.

@JoshuaKGoldberg

Whoops, I accidentally pushed a commit to your azure-pipelines branch. Sorry about that 😄 force-pushed it out of the history.

Well this is spooky. Here are three PRs with failing tests:

apawast#1: failing .ts.lint test; correctly reports the failure
apawast#2: failing Mocha test with the cross-var changes
apawast#3: failing Mocha test without any package changes

The .ts.lint test correctly fails, but neither build with failing Mocha tests picked up on it. That seems like a blocker (unless there was user error on my end?).

I reproduced those test failure locally and realized that the message that you changed isn't what it's testing for, it's testing for true or false. The message could be anything and it'll pass regardless. I changed the tests to say false instead of true and it failed locally immediately. I didn't want to have random failing builds in the pipeline setup so I didn't push but if you want I can reproduce it in a different branch or something.

Ha, user error on my end indeed. I'll take another look. Thanks!

@apawast  https://github.com/apawast/tslint-microsoft-contrib/pull/3 is correctly on failed unit tests after reverting changes to package.json. That seems to indicate changes to package.json in this PR can be reverted, right? Unless I'm (again) missing something, could you please?
Also, in case it's useful, some feedback about Azure Pipelines itself:

Going directly from the links in https://github.com/apawast/tslint-microsoft-contrib/pull/3, it takes several clicks through pages to get to the actual error log. That's a little annoying as a user; I just want to directly go to the error description.
The log in https://dev.azure.com/apawast/tslint/_build/results?buildId=212 does not have colored text the way Circle and Travis. It's very convenient to be able to quickly scan through logs for the red error text (and inconvenient not to be able to).

I'm happy to send you / your team more detailed feedback here or via another channel if you'd like.

The changes I made to package.json are for test reporting. Azure Pipelines also has rich test reporting which works well with commonly used test runners including the mocha-junit-reporter. If you switch from the Logs tab to the Tests tab of a build you can see the test reporting. The default setting of the pipeline is to show failed/aborted tests so if a test failed, you wouldn't have to look through the logs, you could just view them in the Test tab first thing (which helps with the colorless logs issue). However, I have also added a force color variable to ensure the logs show colored text too.
For the issue about getting through several clicks, that is just how Github handles getting to the pipeline from the repo. We can't do anything about it, however, I have heard there is a project in the works to fix this.
Any other feedback you have, you can email it to me at<EMAIL_ADDRESS>and I will be happy to pass it on to the appropriate people!

The changes I made to package.json are for test reporting. Azure Pipelines also has rich test reporting which works well with commonly used test runners including the mocha-junit-reporter

Yes, but tslint and tslint-microsoft-contrib don't use a commonly used test runner. From #655:

Also worth to add: there are new npm tasks that should generate report from Mocha. However #489 will migrate almost all test away from Mocha, and only test for few utils and deprecated formatters will left as mocha tests. I do not think that it worth it to have report just for them.

For this PR to be merged, there should be no package.json or package-lock.json changes.

I have also added a force color variable

Awesome, thanks!

that is just how Github handles getting to the pipeline from the repo. We can't do anything about it

No, it's how you handle getting to the pipeline from the repo 😄. See these PR on CircleCI: https://github.com/general-language-syntax/GLS/pull/641. Clicking Details takes you directly to a well-formatted display of which tasks failed.
Anyway, this is bikeshedding - the real sticking point here is the package.json changeset.

Okay I see. I have no problems removing the changes from them if you're okay with no test reporting (at least the logs will be colorful and I'm sure that's what you're used to looking at them anyways).
I don't really know much about that repo to pipelines process, I was just relaying what other PMs informed me. But I'll definitely look into it!

@JoshuaKGoldberg I changed them to match your master. Everything look okay?

Node 6 build failures are unrelated.

Thanks for setting this up @apawast! We'll try this out for a while and send you feedback as we come across it.

Oh, just a heads up, I don't have permissions to add it as an app to this repository. You'll want to work with @HamletDRC for that, I believe. It might need an admin who's a member of the @microsoft organization.


Upgrade ruby, bundler, rubocop support

Resolves the rubocop warnings mentioned in https://github.com/IBM/ruby-sdk-core/pull/41

Test with ruby 2.7, 3.0, 3.1. 2.7 is end of life and all prior are also but we can possibly keep 2.7 supportable for now.  See: https://www.ruby-lang.org/en/downloads/branches/
Upgrade to bundler 2 and rubocop 1.40+
Fix some obvious rubocop violations
Remove all non-required .rubocop.yml settings to simplify the configuration

Note, this should probably bump the version since we're somewhat dropping support for older rubies.

@jrafanie Sorry for the late response! Can we merge this PR? I think so, but want to make sure it's ready and works fine, since this repo doesn't have automated builds.

@jrafanie Sorry for the late response! Can we merge this PR? I think so, but want to make sure it's ready and works fine, since this repo doesn't have automated builds.

@pyrooka let me rebase and test locally and report back if it's still good

@jrafanie Sorry for the late response! Can we merge this PR? I think so, but want to make sure it's ready and works fine, since this repo doesn't have automated builds.

@pyrooka let me rebase and test locally and report back if it's still good

ok, @pyrooka, I rebased and tested all of my rubies via:
bundle install
bundle exec rake

They all pass the cop checks and tests.
   ruby-2.7.8
   ruby-3.0.6
   ruby-3.1.4
   ruby-3.2.2

Let me know what we can do to get tests running on here via travis or github actions.

Thanks for checking it! I merge this now and will take a look how we could resurrect the Travis builds in this repo.


Bad visibility of auto imported paths in completion popup

VSCode Version: 1.18
OS Version: Windows 10

See these 2 screenshots - if i have some big type, it's not possible to see from which place it will be imported until i have to scroll the doc to the bottom:

Suggestion: Move Auto import from .... to the top

Reproduces without extensions: Yes

/duplicate of #32180 + #27553

Sorry, incorrectly marked this as a duplicate

For this issue, we cannot move the entire auto import from '...' part to the start of the details section because this may hide the type information information in the condensed detail view, especially for longer paths
Current:

With auto imports at front:

Not sure how we can express this so it works in both the compressed and expanded details view.
@ramya-rao-a @chrmarti @jrieken Any ideas?

Can you use some markdown-styles for the path, like "Auto Import from @types/foo"? Another idea is to somehow shorten those overly-verbose detail labels for unnamed types...

Thanks @jrieken! Yes, I'll try some markdown formatting for the path but now now I am remembering why we went with the current presentation in the first place.
We could also just move the import blurb to the top of the details and accept that the details label will be less useful in the compact suggestion UI. The import path may be the most important part anyways in many cases


How to fix:  ValueError: need more than 1 value to unpack

Traceback (most recent call last):
File "/home/pete/parse-idxstatus.py", line 19, in
key, val = (x.strip() for x in line.split('='))
ValueError: need more than 1 value to unpack
Does not span split line correctly, sees as 2 lines:
fn = /data/archived_data/private/pete/Rudde,
Sally/data home/attachmentZ.tiff

Interesting, I've never seen it split over two lines like that.
Could you upload the full idxstatus.txt file somewhere and link to it?
Also, what version of recoll are you using?

I believe I have fixed the problem with continuation lines here:
https://github.com/nbeaver/recoll-status/commit/8de5ae380beaba19da3130ab98203bdccb3c1055
I've also added an idxstatus file with continuation lines here:
https://github.com/nbeaver/recoll-status/blob/master/idxstatuses/004.txt
Let me know if this problem re-occurs, but I'm closing this for now.


The latest version from master does not work on Android, only on iOS

Had to fork off the latest tag to fix the following:
[javac] Compiling 32 source files to /Users/ishaigorodsky/Workspace/git/ceMobileApp/platforms/android/ant-build/classes
[javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
[javac] warning: [options] target value 1.5 is obsolete and will be removed in a future release
[javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
[javac] /Users/ishaigorodsky/Workspace/git/ceMobileApp/platforms/android/src/me/apla/cordova/AppPreferences.java:18: error: cannot find symbol
[javac] import me.apla.cordova.AppPreferencesActivity;
[javac]                       ^
[javac]   symbol:   class AppPreferencesActivity
[javac]   location: package me.apla.cordova
[javac] /Users/ishaigorodsky/Workspace/git/ceMobileApp/platforms/android/src/me/apla/cordova/AppPreferences.java:82: error: cannot find symbol
[javac] 			Intent i = new Intent(cordova.getActivity(), AppPreferencesActivity.class);
[javac] 			                                             ^
[javac]   symbol: class AppPreferencesActivity
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 2 errors
[javac] 3 warnings

You're too fast! Try latest version.

Back at you :+1:
I was not counting on it fixed right away.


Fix #256 by changing python Windows search heuristic

Prefer python3 and python over py -3 on Windows. This will ensure that an active virtual environment is found, rather than an arbitrary system python.

Sorry for these style issue, I'm not a ruby dev

Me neither, no problem :D

@slonopotamus  Thanks for the quick response!
We're currently using a backport on my fork as our pygments gem to solve this issue - Do you know when this change might make it into a published release?

TaDaa! https://github.com/pygments/pygments.rb/releases/tag/v2.4.1


fix: [#4684] ESLint issues in adaptive-expressions-ie11

Addresses # 4684
#minor
Description
This PR removes the unnecessary eslint.config file of adaptive-expressions-ie11 to use the root one directly.
Specific Changes

Removed 'only-warn' plugin from adaptive-expressions-ie11.
Removed eslint.config file of adaptive-expressions-ie11.

Testing
The following image shows that there are no more ESLint issues in adaptive-expressions-ie11.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 84.277%

Totals

Change from base Build<PHONE_NUMBER>8:
-0.3%

Covered Lines:
20431

Relevant Lines:
23091

💛  - Coveralls

Promoted /4835


Purchase necessary parts

Purchase:

SWD connector x2
Jlink x1
2x BLE module (Wi-Fi)?
QWIC modules?
LCD?
Battery pack? (Got 2 LiFePo4 batteries but no rack for them?)
SpO2 sensors?

Purchased SWD connectors, JLink mini EDU x2 (lol).


[tensorflow-cc:x64-windows]build failed

CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155
Environment

OS: Windows 10 version 1909
Compiler: visual studio 2019

To Reproduce
Steps to reproduce the behavior:

./vcpkg install tensoflow-cc:x64-windows

Expected behavior
E:\vcpkg> vcpkg install tensoflow-cc:x64-windows
.........................
-- Warning: Building TensorFlow can take an hour or more.
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
Command failed: static_link.bat
Working Directory: E:/vcpkg/buildtrees/tensorflow-cc/x64-windows-dbg/bazel-x64-windows-dbg
See logs for more information:
Call Stack (most recent call first):
installed/x64-windows/share/tensorflow-common/tensorflow-common.cmake:296 (vcpkg_execute_build_process)
ports/tensorflow-cc/portfile.cmake:11 (include)
scripts/ports.cmake:140 (include)
Error: Building package tensorflow-cc:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: tensorflow-cc:x64-windows
Vcpkg version: 2021-08-12-85ab112d5ee102bc6eac8cdbbfdd173a71374e04
Additionally, attach any relevant sections from the log files above.
E:\vcpkg>
I faced this message at last stage.
Failure logs
build-x64-windows-dbg-err.log
E:\vcpkg\buildtrees\tensorflow-cc\x64-windows-dbg\bazel-x64-windows-dbg\static_link.bat.
The size of this file is 0 KB.
I can't understand about this error.
Please help me.

Command failed: static_link.bat

The relevant error message will be found in log file postbuild3-x64-windows-dbg-*.log. Please share it. Maybe also postbuild1-* and postbuild2-* already have a message that something went wrong.

@tuiho0706proton ,Could you please share the postbuild3-x64-windows-dbg-*.log?

My environment: Win10 &VScode,when I use the command"vcpkg install opencv:x64-windows,I face the same problem.

Ping for response.


fix: speedup wanna-ml by reducing imports being loaded

Describe your changes
The wanna-ml cli was slow due to the several google.cloud related imports that happen when it starts.
This PR moves several imports to be done only when required, speeding up considerable wanna-ml
Issue ticket number and link

https://github.com/avast/wanna-ml/issues/116
https://github.com/avast/wanna-ml/issues/105

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] If it is a core feature, I have added thorough tests.

Codecov Report
Attention: Patch coverage is 71.11111% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.35%. Comparing base (605b03a) to head (f6087ab).

Files
Patch %
Lines

src/wanna/cli/plugins/pipeline_plugin.py
0.00%
6 Missing :warning:

src/wanna/cli/plugins/tensorboard_plugin.py
0.00%
3 Missing :warning:

src/wanna/cli/plugins/job_plugin.py
66.66%
2 Missing :warning:

src/wanna/core/services/base.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   74.55%   74.35%   -0.21%
==========================================
  Files          57       57
  Lines        2838     2866      +28
==========================================
+ Hits         2116     2131      +15
- Misses        722      735      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Crash in _create_nodes canvas_item_editor_plugin.cpp:6258 when dragging texture from FileSystem dock to CanvasItem editor

This is my first time compiling godot for mono so its probably something bad with my build (see attached build.zip for batch commands used to build)
Godot version:
Version 4 (Git head @ f14008b) - built with mono enabled
OS/device including version:
Windows 64 bit
godot.windows.opt.tools.64.mono.exe
Issue description:
2021-02-15_15.38.39_19680.log.zip
CrashHandlerException: Program crashed
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[0] CanvasItemEditorViewport::_create_nodes (C:\home_dev\godot\editor\plugins\canvas_item_editor_plugin.cpp:6258)
[1] CanvasItemEditorViewport::_create_nodes (C:\home_dev\godot\editor\plugins\canvas_item_editor_plugin.cpp:6258)
[2] CanvasItemEditorViewport::_perform_drop_data (C:\home_dev\godot\editor\plugins\canvas_item_editor_plugin.cpp:6418)
[3] CanvasItemEditorViewport::drop_data (C:\home_dev\godot\editor\plugins\canvas_item_editor_plugin.cpp:6547)
[4] Viewport::_gui_drop (C:\home_dev\godot\scene\main\viewport.cpp:1799)
[5] Viewport::_gui_input_event (C:\home_dev\godot\scene\main\viewport.cpp:1938)
[6] Viewport::input (C:\home_dev\godot\scene\main\viewport.cpp:3044)
[7] Window::_window_input (C:\home_dev\godot\scene\main\window.cpp:912)
[8] call_with_variant_args<VisualScriptPropertySelector,Ref<InputEvent> const &> (C:\home_dev\godot\core\variant\binder_common.h:280)
[9] Callable::call (C:\home_dev\godot\core\variant\callable.cpp:51)
[10] DisplayServerWindows::_dispatch_input_event (C:\home_dev\godot\platform\windows\display_server_windows.cpp:1796)
[11] Input::_parse_input_event_impl (C:\home_dev\godot\core\input\input.cpp:626)
[12] Input::flush_accumulated_events (C:\home_dev\godot\core\input\input.cpp:842)
[13] DisplayServerWindows::process_events (C:\home_dev\godot\platform\windows\display_server_windows.cpp:1532)
[14] OS_Windows::run (C:\home_dev\godot\platform\windows\os_windows.cpp:622)
[15] widechar_main (C:\home_dev\godot\platform\windows\godot_windows.cpp:163)
[16] _main (C:\home_dev\godot\platform\windows\godot_windows.cpp:187)
[17] main (C:\home_dev\godot\platform\windows\godot_windows.cpp:199)
[18] __scrt_common_main_seh (d:\agent\_work\63\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[19] BaseThreadInitThunk
-- END OF BACKTRACE --

Steps to reproduce:

build w mono
build.zip
open project
drag icon.png onto the main window

Minimal reproduction project:
monotest.zip

Just to update: this also happens in the non-mono build, looks like its when the wrong node type is the scene root (Node3d wont let me drag the icon.png, Node2d crashes)

Confirmed locally with 866cad9767222e70f802b24e930b606e8f0bef62. CC @godotengine/2d-editor.


Encoding bug I found within Hashlink

Whenever I use the alert method from Window in hashlink, it seems to be using the wrong encoding for the text as shown in the screenshot below.

duplicate of #1631

oops


fix(logger): log_event does not serialize classes

Issue #, if available:
closes #947
Description of changes:
@event_source(data_class=S3Event)
@log.inject_lambda_context(log_event=True)
def lambda_handler(event: S3Event, context: LambdaContext):
   ...

Changes:

Add dict data from raw_event when available

Checklist

[X] Meet tenets criteria
[X] Update tests
[X] Update docs
[X] PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #984 (354529f) into develop (ed7a978) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #984      +/-   ##
===========================================
- Coverage    99.96%   99.96%   -0.01%
===========================================
  Files          119      119
  Lines         5326     5299      -27
  Branches       607      607
===========================================
- Hits          5324     5297      -27
  Partials         2        2

Impacted Files
Coverage Δ

aws_lambda_powertools/logging/logger.py
100.00% <100.00%> (ø)

aws_lambda_powertools/utilities/batch/base.py
99.19% <0.00%> (-0.02%)
:arrow_down:

aws_lambda_powertools/tracing/tracer.py
100.00% <0.00%> (ø)

aws_lambda_powertools/metrics/metrics.py
100.00% <0.00%> (ø)

aws_lambda_powertools/logging/formatter.py
100.00% <0.00%> (ø)

...ws_lambda_powertools/middleware_factory/factory.py
100.00% <0.00%> (ø)

...s_lambda_powertools/utilities/parser/models/sns.py
100.00% <0.00%> (ø)

..._lambda_powertools/utilities/feature_flags/base.py
100.00% <0.00%> (ø)

...lambda_powertools/utilities/parser/models/apigw.py
100.00% <0.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7a978...354529f. Read the comment docs.


create-payload-app does not read packageManager value in monorepo

Link to reproduction
No response
Payload Version
3.0.0-beta.59
Node Version
20
Next.js Version
15
Describe the Bug
When in a monorepo, the packageManager value in the root package.json and nested package.json are not evaluated. This causes it to use npm incorrectly. The .npmrc also does not seem to be taken into account.
Reproduction Steps

npx create-payload-app inside of monorepo

Adapters and Plugins
No response

Package manager detection has been improved in recent versions of cpa. I don't think monorepo detection is worth supporting currently. For the time being, --use-pnpm, --use-yarn, etc can be used to force the package manager choice.


Use a more Resource oriented Registry

Add a registry client for a better mock experience.
Add a more Resource oriented API structure that
focuses on Push/Fetch(ing) a Resource.
Refactor Localization, Configuration and
resource-controller to use the new registry.
TODO:

[ ] Update the Resource object to contain a SnapshotRef optionally
[x] Update localization and configuration to use the optional resourceRef object they now have
[ ] Update the way the various resources watch Snapshots. Use the Owner to find the right object

The OCIClient is actually an OCMClient that uses a Repository to fetch and store oci objects, right?
Can we have this client in pkg/ocm? It would accept a Repository to do OCI related actions. We could have an interface in place of Repository as well for when we will have other targets.

Had a chat with Soulé. I agree with his views and will be doing the following:

Reverse dependency from OCI -> OCM to OCM -> OCI

OCI will basically be handled like a Cache and OCM is the one fetching things
Implement an IsCached interface method for the cache to identify if a cache entry exists ( so we can change it to anything else basically it's up to the caching layer to identify entries )
For OCI this most likely will be the repository name

Creating Snapshots will be done by the controllers

The controllers are kube aware, so they should handle any creation of kube objects
They can still use a transparent GetResource thing, the OCM layer should provide that action not the OCI layer

@souleb @phoban01
Okay, here is what I came up with...
Following our talk Soule, I had this vision where the oci layer works like a cache. And the controllers and everything doesn't care about the OCI layer directly but use the cache and OCM to fetch data.
This triggered a couple of changes. The most significant difference is that the snapshot now defines a cache entry identifiable by a struct called Identity. This Identity can contain ExtraIdentity now too. I take that Identity, create a hashicorp hash, and use it as a repository name.
Anything that gets a Snapshot should be able to get the blob or the digest or the tag or whatever.
This is now a snapshot:
// SnapshotSpec defines the desired state of Snapshot
type SnapshotSpec struct {
	Identity Identity `json:"identity"`
}

What is an Identity? It's a map[string]string and it identifies a cache entry. It looks like this:
	identity := v1alpha1.Identity{
		cache.ComponentNameKey:    componentVersion.Spec.Component,
		cache.ComponentVersionKey: componentVersion.Status.ReconciledVersion,
		cache.ResourceNameKey:     obj.Spec.Resource.Name,
		cache.ResourceVersionKey:  obj.Spec.Resource.Version,
	}

Snapshots are still created. They are essential to share information where a computed resource resides—for example, the output for Localization and Configuration.
The OCM client is now responsible for caching. But the controllers also use the cache to cache intermediate resources that aren't OCM-related. Why? Because if the OCM abstraction had a Push it would suggest that OCM is being used to push something to a different repository. But that's not true. The caching layer is being used. So the controllers are also cache-aware.
Please review and mull it over in your heads. I'm keen to hear your opinions on it. It's pretty nice to use it now.
The remote controller can either use the cache or use OCM without caching.
I will add more tests to the caching part later and add the cache to be optional. I haven't added a switch for that yet.

Overall I think the approach is good. I suppose one thing I would like to see in future is that we don't need to give controllers access to the remote OCM registry, for this to happen we would need the OCM library to support creating an access method using the in cluster component descriptors (this should not be too difficult?).
I the indexing suggestions that @souleb has made are important to follow up on too.


⚠ Jenkins Plugins Artifactory has degraded performance

In ea7d6b5, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1367 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 6888c0c after 1 hour, 44 minutes.


[Identity] Notes on MSAL integration in README

Fixes #12669
Feedback appreciated ✨

@sadasant, @scottaddie,
Please take a look at the discussion in https://github.com/Azure/azure-sdk-for-js/issues/12565 to see if we have missed addressing anything

@ramya-rao-a In this PR we’re mainly trying to express how we use MSAL. Should we also include information about ms-rest-* libraries?


Replace golang.org/x/crypto with v0.8.0

Addresses https://pkg.go.dev/vuln/GO-2023-1571

@wallyqs
Any chance we can merge this and release?

@samuelattwood
Help?

Updated as part of #144


Python 3?

Are there plans to bring this to Python 3?

Hi
Yes! we will be updating the code for Python 3 very soon.
We aim to do this within next week or so.

Great. I'll keep an eye out for the next release.


Update to SBT 1.9.6 and remove build.properties boilerplate

Trick I got from https://github.com/sbt/sbt-github-actions/pull/163#discussion_r1327598500

Nice clean up.


Some keys not work

Hi, thanks for your great work, I'm trying to rewrite your lib using Swift and it works pretty well already, but I've met the problem, that some important keys just don't work, in example KEYCODE_TV_INPUT, it's very important key on controller and it's not work.
In your lib they don't work either, do you have any idea why it could happen? Just for doublecheck I've tested the same key using ADB, and input source screen appears.

@XITRIX R u able to open tls connnection with server and get the response.

Yes, I already have fully working prototype

I also did implement for ios too in react native. can we connect over skype

I use the key map from android ref : https://developer.android.com/reference/android/view/KeyEvent
What’s the value work for that key ?

@louis49, yes, I'm also using it, and most of keys works perfectly, but some of them - doesn't and I cannot see any reason for it, the most valuable key for me is KEYCODE_TV_INPUT which is #178, this key does nothing using your lib and my replica of it, but using adb shell input keyevent 178 it opens sources screen without any problem. Tried with SHORT direction, and START_LONG\END_LONG, nothing. KEYCODE_PROG_RED and other 'colored' buttons also not work.

@louis49, what app did you used to capture socket traffic between your android device and android TV? If it's not a problem, could you write a small manual?

@XITRIX Did u used below library for making tls connection from ios to android TV.
https://github.com/Kitura/BlueSSLService.

No, I've made it from scratch

@XITRIX Thanks. Any reference or doc if u can share to achieve tls connection. I am new to swift and ur guidance will be really helpful.

Sorry, but I cannot help with any detailed information until app I'm working on will be released

@XITRIX Ohk Ohk. I understand. I thought u r making it open source. Thanks by the way.
Will wait for ur app.

I think I'll open source it when it will be released

@louis49, what app did you used to capture socket traffic between your android device and android TV? If it's not a problem, could you write a small manual?

You can use Wireshark to analyze packets : https://www.wireshark.org/

Hi, thanks for your great work, I'm trying to rewrite your lib using Swift and it works pretty well already, but I've met the problem, that some important keys just don't work, in example KEYCODE_TV_INPUT, it's very important key on controller and it's not work.
In your lib they don't work either, do you have any idea why it could happen? Just for doublecheck I've tested the same key using ADB, and input source screen appears.

@XITRIX Can u do a small favour in suggesting. Were u able to crack tls connection using swift. in other thread u said u did in C.

There are bridging libraries for OpenSSL on Swift, I am using them

@louis49, Hi, I've tried to understand how to use use Wireshark. I've tried to dump traffic using PCAPdroid, and dump ssl_keys.log using mitmproxy to decode ssl traffic inside Wireshark, but I always end with untrusted connection between phone and TV, while I could see all ssl traffic of all other phone apps. SSL unpinning XPosed modules also doesn't help. Could you give some hints about how I could get decrypted traffic? May be you know some web articles where I could find useful information?
Anyway the info I'm trying understand, is how phone send updates to the textfields on TV, so I could modify input text right from my device

There are bridging libraries for OpenSSL on Swift, I am using them

@XITRIX Thanks for your detailed work. I also need ur guidance. I only know Swift. Never did anything in Objective C or C.
Is it possible to achieve it only using swift.

@techie-gabbar, Hi, yes, it is possible to do with Swift only + OpenSSL Swift bindings, but you still need to understand some C concepts, cause OpenSSL will work with OpaquePointers and also you will not find any manuals for OpenSSL on Swift, you'll need to translate C->Swift code manually.

@louis49, Hi, I've tried to understand how to use Wireshark. I've tried to dump traffic using PCAPdroid, and dump ssl_keys.log using mitmproxy to decode ssl traffic inside Wireshark, but I always end with untrusted connection between phone and TV (System CA mitmproxy certificate installed), while I could see all ssl traffic of all other phone apps. SSL unpinning XPosed modules also doesn't help. Also tried Frida with Objection. Could you give some hints about how I could get decrypted traffic? May be you know some web articles where I could find useful information?
Anyway the info I'm trying understand, is how phone send updates to the textfields on TV, so I could modify input text right from my device

You need to change the key/cert inside the application by decompile and recompile it :
Then, you can set your own certificate inside whireshark to analyze packets
https://blog.isec.pl/introduction-to-apk-reverse-engineering-bypassing-root-detection-and-certificate-pinning/
https://braincoke.fr/blog/2021/03/android-reverse-engineering-for-beginners-decompiling-and-patching/#patching-with-apktool

@louis49, Thank you for the info, have you decompiled Home app or TV's service? I've tried to patch Home app with apktool, but it fails with recompiling it, with TV's service it works fine, but I could not install it, cause my TV cannot be rooted. Anyway thanks for the articles, I'll investigate them carefully.

@XITRIX have you managed to get the volume up & volume down keys to work? they also doesn't seem to work

@Ganime422 R u able to make Pairing work in IOS using Swift. Any insights would be helpful.

@Ganime422, no, they work without any problem, Google Home app sends default volume_up/down keycodes and they works fine

Hello @XITRIX, I have generated SSL key with OpenSSL-for-iPhone. But can not find way to tap/ping/pair via socket with that SSL certificate. Any guidance would be helpful

@XITRIX have you managed to send letters keys such as KEYCODE_A? I am able to send commands like dpads etc. but no letters nor numbers etc.

With the help of Aymkdn/assistant-freebox-cloud KEYCODE_CHANNEL_UP, KEYCODE_CHANNEL_DOWN now working. All I have to do is change the send commands.
For KEYCODE which has value over 2 digit(greater than 99) you have to send [ 82, 5, 8, <KEYCODE>, 1, 16, 3 ]
other wise send [ 82, 4, 8, <KEYCODE>, 16, 2 ]
P.S: I still could not find any solution for keyboard inputs(KEYCODE_A and goes on to Z).


Picking up changes from master.

Merging with master

What is this commit Merge branch 'features/auto_upgrade' into temp and why was it added?  Is there a better description we can use for it?


IG:DM Pop!_OS

So
I got the AppImage for my computer and successfully installed it
So now on IG:DM no chats are shown
Except when I search for a particular user and send a message and then all the messages from that chat will show up
Otherwise I can't use it like I should
Thanks for this awesome project
Sorry I can't donate...
I'll wait for a reply or fix
A big thanks!

do you mind sharing what version of IGdm you are using? And where it was downloaded  from?

I'm not using it at the moment
But I used an AppImage from the official website (I'm on Pop!_OS 18.04 LTS)
I couldn't ever see the chats...
Thanks!
On Tue, 14 May 2019 at 10:42, Ifedapo .A. Olarewaju <
<EMAIL_ADDRESS>wrote:

do you mind sharing what version of IGdm you are using? And where it was
downloaded from?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ifedapoolarewaju/igdm/issues/977?email_source=notifications&email_token=ALY35653QE5KPRMPRUBM2PLPVKCRVA5CNFSM4HMRDTR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVK52UA#issuecomment-492166480,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALY3566UIX6C2D2QH5GSEEDPVKCRVANCNFSM4HMRDTRQ
.


Merge 'ossu-develop' into 'ossu/master'

@evanplaice :+1:

:+1:

Don't we need to be merging stuff onto develop and then merging onto master from develop?


Eliminate coordinated omission

As noted in #51, eliminate coordinated omission by sending messages at regular intervals and measure round-trip-time based on when the client should have sent the message, regardless of whether the client was delayed in sending the message.

Thank you, @JanStureNielsen! Great work! 🙌


Add option to use root navigator or not

This fixes #13
I tried set this to false and the back button could work properly. So I think it would be nice if we have this option.

That's a great update, thanks for opening the PR @minhdanh! Merging it now will prepare a release with this included soon


improve test cases

Test cases do not always flow nicely after one and another resulting in unnecessary failures.
I need to extend and improve the test cases.

fixed in the latest version will add more tests later


About sincos_pos_embed

(https://github.com/hustvl/MIMDet/blob/main/models/benchmarking.py#L592)
I don't understand why do we need to do this? Because self.pos_embed has been initialized by resized pos-emded from pretrain checkpoint.

Hi, @qiy20! We have tried to use learnable resized position embed, it gets about 0.6 bbox AP and 0.4 segm AP improvements. Code and result will be updated after more experiments are done. Thanks for your attention!

@vealocia Thanks for your reply! I want to know which type of pos_embed is used in the reproduction process?

@vealocia Thanks for your reply! I want to know which type of pos_embed is used in the reproduction process to get 48.0AP(25e)

48.0 AP is achieved with sincos_pos_embed=True. So it means a re-initialized frozen sin/cos position embedding.

Many thanks!

I believe the issue at hand was addressed, as such I'm closing this. Feel free to ask if you have further questions.


Captcha shouldn't be required for reporting your own package to gallery owners.

Just noticed this oddity of our code.

Can this be closed? Not sure how to report my own package. Has this been removed?

@xavierdecoster can you check if this is still relevant?

Seems this is already fixed. Thanks for bringing this issue under our attention!
FYI: this is the URL to report one of your own packages
https://www.nuget.org/packages/{PackageId}/{PackageVersion}/ReportMyPackage


Where's this option?

Hello Ilia ;-)
pardon, when I enter Virtualmin the first time, the opened tab on the bottom is "New Virtualmin Features".
How to choose another opened tab? eg. Status....
thanks

In options you can open all tabs but not specific

I mean you can set to expand all

"Make all accordions expanded" ? if so, is already on yes... but only "New Virtualmin Features" is opened...

Do you read change logs? :) goto Webmin->Webmin Configuration->Webmin Themes

Oh you mean it doesn't work?

indeed, it doesn't work...

Hmm.OK, pal! Will take a look as get back to PC. What happens if you click hide new features button?

if i click that, nothing is opened :-D

Do you click on the text? I'm confused. All is opening in my case. What browser are you using?

I clicked the hide new features button... "Make all accordions expanded" is already set on Yes in Authentic options... so it doesn't work.
I'm forced to click on a tab to expand it...
Chrome or Firefox do the same thing...

There is one error that I just  fixed - but it didn't break functionality...
Ok, I think I know what you mean. Just if you goto theme options and click save button - it will work for you after that, right? There was in error in default settings. Just fixed it.

right... on 13.02 it works only if you Save settings...

OK. I will fix it! Why didn't you just say that right away.. :)

Thanks!

:-D 'cause i didn't try before, really... thank you


Support deployment in namespaces with stricted Pod Security Admission

Describe the bug
The Pod Security Admission will be enforced upon Openshift and the operator should make sure it conforms to the restricted security level.

The changes to support the deployment in namespaces with the restricted policy will be included in 1.1.0


Enable HIP language

If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX.

There are currently CI build failures on rhel9 and ubuntu22. I tried rolling back this change and building, and the same error still occurs, so the problem it's not due to this PR. I believe the build failure is happening because of a known compiler bug. When I use the available staging compiler build that contains the fix for the compiler issue, everything builds fine on ubuntu22. I haven't been able to grab an equivalent staging compiler build for rhel9.


Suggestion: Instead of public S3 bucket use CloudFront distribution

Hi,
i have just deployed your solution yesterday and it really works well!
A minor thing, being an AWS employee, where public S3 buckets are not allowed ;):
I'd suggest switching to a private bucket and use a CloudFront distribution in front.
Not sure if you automate this easily, but maybe worth mentioning.
Again, thanks for your work!

@frumania I'm glad to hear that it works, thank you for your input!
Regarding the S3 bucket which serves the resources; it's defined in the CloudFormation template
Line 259
    # Images Bucket
    BuildBadgesImagesBucket:
        Type: 'AWS::S3::Bucket'
        DeletionPolicy: Retain
        Properties:
            BucketName: !Sub '${AppName}-badges-images-${Stage}'
            AccessControl: PublicRead
            WebsiteConfiguration:
                IndexDocument: index.html
            CorsConfiguration:
                CorsRules:
                    - AllowedHeaders:
                          - '*'
                      AllowedMethods:
                          - GET
                          - HEAD
                      AllowedOrigins:
                          - 'https://github.com'
                          - 'https://www.github.com'
                      MaxAge: 90

If you want to make it private, just play with the above properties of this bucket.
Alternatives for using a private S3 bucket

Create an API Gateway and a Lambda Function which is allowed to fetch the data from the private S3 bucket
I think that putting a CDN in front of the S3 bucket (such as CloudFront) would be no good; you'll have to invalidate the cache of this CloudFront distribution after each time that this app generates a badge

If you feel that the 1st alternative (API Gateway + Lambda Function) can work for you, let me know and I'll add another folder with this kind of application

@2:
Good point, but I think it works automatically and invalidates the cache. At least I didn't notice any issue here.
Anyway, i did create a custom version for me, all good, no action item :).
Just wanted to give feedback 👍


undefined method 'register_application_command'

Summary
Bot command returns undefined method for register_application_command and application_command
I'm running through the example for slash commands an ultimately getting errors...
require 'discordrb'

bot = Discordrb::Bot.new(token: 'TOKEN')

bot.register_application_command(:spongecase, 'Are you mocking me?', server_id: 'SERVER_ID') do |cmd|
  cmd.string('message', 'Message to spongecase')
  cmd.boolean('with_picture', 'Show the mocking sponge?')
end

The bot.register_application_command line is outputting this error:
undefined method `register_application_command' for #<Discordrb::Bot:0x000000011c04c140 @should_parse_self=false, @client_id=nil, @type=:bot, @name="", @shard_key=nil, @prevent_ready=false, @compress_mode=:large, @token="Bot TOKEN", @gateway=#<Discordrb::Gateway:0x000000011c047f00 @token="Bot TOKEN", @bot=#<Discordrb::Bot:0x000000011c04c140 ...>, @shard_key=nil, @ws_success=false, @check_heartbeat_acks=true, @compress_mode=:large, @intents=nil>, @users={}, @voice_regions={}, @servers={}, @channels={}, @pm_channels={}, @restricted_channels=[], @voices={}, @should_connect_to_voice={}, @ignored_ids=#<Set: {}>, @ignore_bots=false, @event_threads=[], @current_thread=0, @status=:online> (NoMethodError)

There's a similar output for bot.application_command

Environment
Ruby version:
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [arm64-darwin21]
Discordrb version:
discordrb (3.4.0)
discordrb-webhooks (3.3.0)

Also got the same error and noticed indeed that current version does not have this in the code.
Any ETA on a new release that includes it?

At the moment, it is highly recommended to use the main branch for all current projects, (locked to a commit perhaps) since there are many bugs in 3.4.0 that occur in regular operations that will cause problems.
Our next release will be 4.0, which we are working towards but we have 1 developer doing the majority of all the planning and changes and it's highly dependent on their time, energy, and motivation for the project.
I'd advise joining the discord (https://discord.gg/discord-api) to get the most up to date information on how things are proceeding and what plans are being made

Recently I had this issue with my app, I find that I was executing the command with ruby app.rb. Instead, you need to use bundle exec ruby app.rb and give the permissions to your bot in Discord. Hope this can help someone, cheers.


[Question] Making API calls from outside the auth middleware

The documentation paragraph Accessing API for the current shop describes how to use the current authenticated shop to make API calls to Shopify like so:
// Returns instance of \OhMyBrew\BasicShopifyAPI (ohmybrew/basic-shopify-api)
$shop = ShopifyApp::shop();
$shop->api()->rest(...);

According to docs:

For this to properly work your route must be behind auth.shop

Jobs (and webhooks)
Let us say, that we implement a queued job that needs to make API calls to Shopify - it might for example be the CustomersDataRequestJob described here.
This job will be fired by some controller behind the auth.webhook middleware.
Such a queued job will be fired by some controller behind the auth.shop middleware (or the auth.webhook middleware). It could also be an event listener that registres something happens, which require an API call to Shopify on behalf of the currently authenticated shop.
Events and listeners
Say that we have a controller behind the auth.shop middleware. When something relevant occurs, then we dispatching an event like so: event(new OrderHandled($order));
We have an event listener for this event, which should then make some API call to Shopify - might for example be adding meta data to the order.
Question
How should the job or event listener get an instace of \OhMyBrew\BasicShopifyAP authenticated as the shop that originally made the request? One need to be sure that the instance is authenticated as the store that originally was responsible for firing the event og job.
Thanks for input.

Not sure I entirely follow.. but you can just look the shop up via eloquent and get the API instance.
$shop = Shop::where('shopify_domain', 'domain.myshopify.com')->first();
$shop->api()->rest(...);

@ohmybrew Thanks for your explanation. I was not aware that I could get the api directly from the App\Shop model.
We are passing this model to any queued jobs, so using this will make it possible to use the shops api.


Implement method to get appdata/local share folder cross-platform

Right now everything goes in the working dir even when not in portable mode

Done in f5fde5e215135d21409abc773b86a384a1625710.


DCOS-47966 Enable UI-Update plugin for UI

High-level description
Added ui-update plugin to /etc/ui-config.json to enable a new ui plugin that gives access to update the UI using the new UI update service.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-47966 UX for UI Update/Reset flow.

Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label [Ready For Review]

@mesosphere-mergebot label [Ship it]


Out of date

Unfortunately this page is out of date - "Diagnostic settings" has changed to "Diagnostic settings (classic)" and looks different (No possibility to set a storage account).
In the new Monitoring section "Diagnostics" is not available.
So the question how to access diagnostic logs remains unanswered.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96cdd2e8-0dd2-0ce4-8230-24743e400413
Version Independent ID: 39143a1b-7512-9ce0-3060-f78b605fd91c
Content: Viewing diagnostic logs for Azure Data Lake Storage Gen1
Content Source: articles/data-lake-store/data-lake-store-diagnostic-logs.md
Service: data-lake-store
GitHub Login: @twooley
Microsoft Alias: twooley

@rworbis Thanks for the Comment. We are actively investigating and will get back to you soon.

@rworbis : Thank you for brining this to our attention. We have assigned the issue to the content author . They will evaluate & update the document as appropriate.

@rworbis For Azure Data Lake Gen1 it is shown as "Diagnostic settings".

For Azure Data Lake Gen2 it is shown as "Diagnostic settings (classic)".

Note: For Azure Data Lake Gen1; Diagnostic Logs tab is removed from settings section and for gen2 it is not supported.
@twooley Could you please update the document with the latest updates.

Duplicate of #19726

@twooley Could you please update the document with the latest updates?


lib-detection gets stuck searching for dependencies

I went to compile my code to find that it was never finishing (after running for about ~45 minutes). When I would interrupt the process it would display a traceback to Arduino-Makefile/bin/lib-detection somewhere around line 70 ( currentFile = open(os.path.join(USER_LIB_PATH, lib, lib + ".h")) )
For some reason, it was getting stuck calculating SKETCH_LIBS_DEPS. As a workaround, I specified every library and every library dependency directly in the ARDUINO_LIBS variable of the makefile, commented out that section of lib-detection, and replaced it with SKETCH_LIBS_DEPS = []. This approach seems to be working for now.

My project is somewhat large with 15 libraries specified in my USER_LIB_PATH. Each individual library is fairly simple, with a handful of includes and an average size of ~200 - 300 lines, with a couple libraries being substantially larger. Some libraries include other libraries. Hardcoding dependencies in the makefile without commenting out lib-detection did not help.
Unfortunately, I cannot upload my project as it's for work and parts of it are confidential, but would be happy to try and provide any specific information that might be helpful.
Thanks!
CURRENT_OS = MAC
ARDUINO_VERSION = 165-r
ARDMK_VERSION = 1.5

closing for now, feel free to reopen.


What's new / "recent_changes" returns None

Describe the bug
What's New / "recent_changes" returns None even though it exists.
To Reproduce
import play_scraper as ps

data = ps.details('com.supercell.clashofclans')
print(data['recent_changes'])

Expected behavior
Should return the value for 'what's new' when it exists.
Screenshots
Not required
Desktop (please complete the following information):

OS: [Windows 10]
Python Version [3.7.2]
play_scraper Version [0.5.2]

Additional context
Issue can be resolved by changing code to
recent_changes = changes_soup.text

Fixed by #33


Reorder error check and defer file.close()

ISSUE TYPE

Bug fix Pull Request

SUMMARY

Defering a file.close() should be done after the error returned by file.open() is checked, so I've reordered the statements.

Defering a file.close() should be done after the error returned by file.open() is checked, so I've reordered the statements.

@seb-ehm I feel it is a good practice to add a defer file.close() immediately after file opening to avoid missing file closer. it works fine irrespective of its call. could you please justify the need for re-ordering it..?

Closing the PR. Change is not required

Thank you for the quick response. I agree that the reordering is not strictly neccessary. However, when I try to familiarize myself with a codebase, I run a static analysis, and this is a warning that came up.
Without reordering, file.Close() is going to return an unhandled error when the config file is not found - it's still going to work, just as you say, I just prefer either handling or avoiding any possible errors. Not handling possible errors for file.Close() in those two cases is fine, as the configs are only read and not written to, so no meaningful errors can occur on file.Close().

hey @seb-ehm,
Would you mind sharing more info about static analysis you carried out? E.g which tool you used and results?

I've used staticheck and Sonarqube with the default settings. In the past, I've used golangci-lint, but I've had some issues with it lately after some upgrades to my system.. I'm not near a computer right now but will try to post a summary of the results as soon as possible.

golang_ci_lint.txt
I've managed to get golangci-lint running again and ran it with a selection of linters, staticcheck included. The Sonarqube report does not add a lot of information, so I didn't include it.
A lot of the warnings are debatable and are mostly about style (e.g. quite a few from the gocritic linter), but some can be helpful. E.g. the dead code warnings at the beginning; for example
pkg/notify/elasticsearch.go:40:2: indexSuffixFormat is unused (deadcode) 	indexSuffixFormat = "02-01-2006"
is a leftover of a refactoring and can be safely removed.
Other warnings might be worth a look (e.g. unchecked errors, missing cases in switch ).
Let me know if you think that some of them might be worth fixing.


Keyboard Notification Race

@jessesquires
Have you seen or heard of the toolbar occasionally getting out of place relative to the keyboard?
I've cornered a hard-to-reproduce situation which causes the toolbar to be behind the keyboard.
When a keyboard dismisses then is shown quickly (as when pushing from a VC which was showing the keyboard into a JSQMessagesViewController subclass) the keyboardControllerKeyboardDidHide delegate callback arrives after the frame change notifications.

jsq_didReceiveKeyboardDidHideNotification calls jsq_handleKeyboardNotification
jsq_didReceiveKeyboardDidShowNotification calls jsq_handleKeyboardNotification
the jsq_didReceiveKeyboardDidHideNotification animation completion block fires, calling the delegate's keyboardControllerKeyboardDidHide.

2015-01-26 15:53:03.856 ChatApp[6715:60b] ----- jsq_notifyKeyboardFrameNotificationForFrame
2015-01-26 15:53:03.857 ChatApp[6715:60b] keyboardDidChangeFrame
2015-01-26 15:53:03.870 ChatApp[6715:60b] ----- jsq_notifyKeyboardFrameNotificationForFrame
2015-01-26 15:53:03.871 ChatApp[6715:60b] keyboardDidChangeFrame
2015-01-26 15:53:03.873 ChatApp[6715:60b] ----- jsq_notifyKeyboardFrameNotificationForFrame
2015-01-26 15:53:03.874 ChatApp[6715:60b] keyboardDidChangeFrame
2015-01-26 15:53:03.887 ChatApp[6715:60b] ----- jsq_notifyKeyboardFrameNotificationForFrame
2015-01-26 15:53:03.888 ChatApp[6715:60b] keyboardDidChangeFrame
2015-01-26 15:53:03.889 ChatApp[6715:60b] ----- jsq_notifyKeyboardFrameNotificationForFrame
2015-01-26 15:53:03.890 ChatApp[6715:60b] keyboardDidChangeFrame
2015-01-26 15:53:03.928 ChatApp[6715:60b] HIDE jsq_handleKeyboardNotification animation finished: 1
2015-01-26 15:53:03.929 ChatApp[6715:60b] keyboardControllerKeyboardDidHide
2015-01-26 15:53:03.930 ChatApp[6715:60b] SHOW jsq_handleKeyboardNotification animation finished: 1

While the show animation completes after the hide animation, there is no notification to the delegate, so the delegate was last told that the keyboard did hide.
The problem is this:
The toolbar is adjusted upward when the frame changes (which is during the animation) and the toolbar is adjusted downward both when the frame changes and when keyboardControllerKeyboardDidHide is called, which is after the animation.
One solution I can see is to fire a redundant frame-change notification in the show keyboard animation completion block:
    [self jsq_handleKeyboardNotification:notification completion:^(BOOL finished) {
        [self.panGestureRecognizer addTarget:self action:@selector(jsq_handlePanGestureRecognizer:)];
		[self jsq_handleKeyboardNotification:notification completion:nil];
    }];

Another solution would be a dedicated delegate message for keyboardControllerKeyboardDidShow.
Yet another solution would be to remove the keyboardControllerKeyboardDidHide message rely on the frame change messages.
Do you have any thoughts on this issue?
Ray

I tested commenting out the body of keyboardControllerKeyboardDidHide (on iOS 7.1 & 8.1), and the UI appeared to behave normally. To my mind this may be the best solution, if you're inclined to take a fix in this area.

Thanks for the thorough report @walsh2000 !
This was introduced by PR #646 (which also introduced #706).
I'd love a fix for all of the above! :smile:

I'm just trying to make your job easier :)
I've tested that removing/commenting the code in keyboardControllerKeyboardDidHide does resolve the issue I've seen. I'll investigate what PR #646 was trying to fix to see if commenting/removing the method causes a regression.

@jessesquires
Were you ever able to reproduce #645?
I encountered this and I resolved it by changing the keyboardDidChangeFrame logic to something like this:
- (void)keyboardController:(JSQMessagesKeyboardController *)keyboardController keyboardDidChangeFrame:(CGRect)keyboardFrame {
	[self setToolbarBottomLayoutGuideConstant:CGRectGetHeight(keyboardFrame)];
}

Instead of using the converted rect, which appeared to be bogus periodically and would lead to something like #645.
The fragile aspect of this change is that we bake in the assumption that the keyboard takes up the bottom portion of the screen.

That bug has appeared in various forms. (See #314) There was a video in #645.
Now that I re-watch that video, there's a lot more complicated UI going on there — which may be part of the issue.
I support all the changes you are suggesting here, and I think PR #646 should be reverted. (And, thus closing #706.)
Regarding the keyboard frame coordinate space, there were some attempts to fix this in PR #454, but it was never resolved. If we fixed the coordinate conversion issues, then we can close #405 too.
In any case, all of these issues mentioned here seem to be related. I'd love to knock them all out soon.

@jessesquires
I discovered a problem with my keyboardDidChangeFrame today (when hardware keyboards are used)
I was able to resolve the issue, still retaining the assumption that the keyboard is at the bottom of the view:
- (void)keyboardController:(JSQMessagesKeyboardController *)keyboardController keyboardDidChangeFrame:(CGRect)keyboardFrame {
	CGFloat height = CGRectGetHeight([[self view] frame]);
	CGFloat bottom = CGRectGetMinY(keyboardFrame);
	height -= bottom;
	[self jsq_setToolbarBottomLayoutGuideConstant:height];
}

I haven't tried this on iPad. I don't know how this will work with a split iPad keyboard.

@walsh2000 - related to #557 ?

@jessesquires
Yes, I think so based upon what LeoNatan wrote:

The only public API condoned method is to test if the keyboard's end frame will be outside of the main screen.

This fits what I was seeing when I fixed the issue with the above snippet

(height - minY)

@walsh2000
i started on some of this work.
how is that snippet above different from what's in develop? i'm using CGRectGetMaxY, but that should be equal to the view height.

I think the difference is that I'm not using the keyboardFrame's Y, which has been adjusted (corrupted) by the convertRect call in -[JSQMessagesKeyboardController jsq_handleKeyboardNotification:completion:]
CGRect keyboardEndFrameConverted = [self.contextView convertRect:keyboardEndFrame fromView:nil];

Under some circumstances the convertView does not produce a realistic value for keyboardEndFrameConverted. Perhaps convertView is offscreen or out of the view hierarchy. The notifications come in pretty fast and I didn't trace it.
So, while the keyboardFrame height/width is accurate (I tested only in Portrait), its X & Y are not always right.
That led me to believe that if I assumed the keyboard takes up the bottom "CGRectGetHeight" of the screen, that I could accurately compute the toolbar's bottom offset using just the height of the keyboard alone. For my unpublished app which admittedly has a very limited user-base, the above snippet has been consistently positioning the toolbar correctly.
However, it should be noted that there is an ugly assumption baked in there.
It might be worthwhile discovering what triggers convertRect to produce unexpected results. My suspicions were that the view was offscreen or was out of the view hierarchy, but I never did confirm either notion. If we could positively know when convertRect might return those unexpected results, perhaps we can compensate for it and then maintain the existing positioning logic. (Freeing us from my keyboard-position assumption)

Ahhh got it. That makes sense! Thanks @walsh2000

Also having issues with toolbar animating behind the keyboard.
My UIWindow is is offset 40pt from the top of my screen.
I was able to resolve by the following:
CGRect keyboardEndFrameConvertedNew = [self.contextView.window convertRect:keyboardEndFrame toView:self.contextView];```
&
```objc
CGFloat heightFromBottom = heightFromBottom = MAX(0.0f, CGRectGetMinY(keyboardFrame));

I'm not sure if both UIKeyboardWillChangeFrameNotification & UIKeyboardDidChangeFrameNotification both need to be observed? as this will trigger multiple animations for toolbar constraint updates. Perhaps UIViewAnimationOptionBeginFromCurrentState animation option could be used to avoid animation issues.
Not had the chance to properly investigate. So take these comments lightly.

hey @walsh2000 and others - just bashed some bugs tonight and closed a number of issues.
I would love some help on this — the last major issue before the 6.1.4 release is ready for Cocoapods.

@jessesquires
You'd like a pull request? or are you asking for help testing?
I can put together a PR for how I've worked around this in my app.
Ray

@walsh2000 - PR would be awesome!

@jessesquires
My solution builds in an assumption that the keyboard is always at the bottom of the screen. I tested the app out with the floating/split keyboard.
Here is how the app looks before my modifications (not great, but usable)

With my modifications (in the simulator) the keyboard covers up the input field. I don't know how widely the floating and/or split keyboard is used, but I don't want to introduce this nasty regression. I'm going to investigate a more thorough solution which does not assume that the keyboard's frame is always at the bottom of the screen.

Adding on:
There are two issues:
#557 Where the keyboard's frame is occasionally reported offscreen and the toolbar reacts
#763 Where the input field resigns first responder because keyboardControllerKeyboardDidHide is called after a keyboard did appear notification.
I'm going to tackle #763 separately from #557.

More:
I looked at the two videos in #645

https://www.dropbox.com/s/iehlriqqc4eim9l/chat-bummer-1.mov?dl=0
I am not convinced this is due to the notifications. It could be related to some bug in the manually setting the toolbar's y offset.
https://www.dropbox.com/s/bv1uw6gfckoyzqa/chat-bummer-2.mov?dl=0
I didn't see anything wrong on this one. At the end of the video, the toolbar appears to rest where I would expect.

With this mindset, I'm not clear on why we need the keyboardControllerKeyboardDidHide delegate callback. However, since @toblerpwn added it, it must be helping him. Rather than suggest we remove the callback (and regressing @toblerpwn's project), I'd like to suggest we create a new property which can short circuit these two lines in keyboardControllerKeyboardDidHide:
    [self jsq_setToolbarBottomLayoutGuideConstant:0.0f];
    [self.inputToolbar.contentView.textView resignFirstResponder];

Here is a preview of the comment for this new property:
/**
 *  Specifies whether or not the inputToolbar should resignFirstResponder & snap to the bottom of the screen after the keyboard did hide animation.
 *
 *	@see https://github.com/jessesquires/JSQMessagesViewController/issues/763
 *  @discussion Some projects require the inputToolbar to be snapped to the bottom after the keyboardDidHide animation completes.
 *	However if the screen pushing the JSQMessagesViewController onto the UINavigationController stack was showing the keyboard
 *	that previous screen will hide the keyboard on the transition.
 *	When the JSQMessagesViewController comes on screen and becomes first responder, the previous screen's keyboardDidHide notification
 *	is picked up by the JSQMessagesViewController, causes it to resignFirstResponder. In this way, the input toolbar is not initially the first responder.
 *  Setting this property to `NO` will result in no action being taken when the keyboardControllerKeyboardDidHide message arrives.
 *	Setting this property to `YES` will result in the inputToolbar resigningFirstResponder & pinning to the bottom of the view when the keyboardControllerKeyboardDidHide message arrives.
 *	Under normal circumstances, `NO` is the right thing to do, because the keyboardController:keyboardDidChangeFrame: messages will take care of the inputToolbar's positioning.

 *  The default value is `NO`.
 */
@property (assign, nonatomic) BOOL resignFirstResponderOnKeyboardDidHide;

PR to follow.

This also addresses #706 if the new boolean is left at the default (NO)

Okay. 27d7a2e09c6f resolves this issue.
I was working off of an old fork & didn't notice that you'd reverted the changeset on 2/5.
We can close this one without a code change.

Sorry, I meant to close this. You've resolved this with the revert.

thanks @walsh2000 !
any testing that you can do on develop right now is much appreciated!

@jessesquires
The tip of develop looks good in my app. Nothing stands out with a light smoke-test.
To verify, I was using this in my Podfile
pod 'JSQMessagesViewController' , :git => 'https://github.com/jessesquires/JSQMessagesViewController.git', :commit => '09db017b871a37df25d38598cba774f976bd8d13'

Thumbs up here! :) :+1:

@walsh2000 - thanks so much!

heyo @jessesquires & @walsh2000 - just wanted to chime back in here and let you know that reverting the changes made in #646 prevent our app from using JSQ; both issues now re-appear in the latest public cocoapod version.
the problem with video #2 (https://www.dropbox.com/s/bv1uw6gfckoyzqa/chat-bummer-2.mov?dl=0) to be more clear is that the JSQMessagesViewController is completely off-screen, and yet its toolbar animates back on to the bottom of the screen bounds (i.e. it is overlapping a different controller and displaying completely outside of the message controller's bounds).
we are not doing anything fancy or hard-coding anything weird.
in terms of finding a solution that works for everyone, what is best? should I re-open #645? I am unsure exactly how to approach a fix without digging in deeper with one of you; my approach to fixing it would be to essentially re-do #646 which is clearly not what you want.
sorry for not replying earlier; release crunch and all that. =/

hey @toblerpwn - it's not that #645 was unwanted, just that it caused other side effects. i'm always open to other possible solutions. :smile: however, based on the video, my first thought is that this is specific to your implementation.
absolute worst case scenario: you can maintain a custom fork, and point cocoapods to fetch from your fork

@jessesquires - yeah, we're doing the latter...I saw mention of a custom property in #823 to opt-in to the behavior we're looking for, but it looks like that was not implemented?


fix(Schema Registry): append '/' to RestService.BaseAddress and remove '/' from subject requests

fixes: https://github.com/confluentinc/confluent-kafka-dotnet/issues/993

It looks like @jonathansant hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot

[clabot:check]

@confluentinc It looks like @jonathansant just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

thanks! I think a number of people have hit this issue.
sorry for the delay in reviewing (end of quarter madness).
lgtm except for 1 minor change request.


Update integration directory

Signed-off-by: cheyang<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #609 (096b51d) into master (d8fdcf7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   18.40%   18.40%
=======================================
  Files          61       61
  Lines        2527     2527
=======================================
  Hits          465      465
  Misses       2012     2012
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fdcf7...096b51d. Read the comment docs.


Activate and deactivate dapps

Description

From the aspect of our dApps, user would like to set the period of the activation.
So I've added activate and deactivate to dapp.cr as abstract methods. (which is a super class of users dApps.)
activate and deactivate will return the block index which dApps will be activated or deactivated.
User can return nil when user want that the dApp will always be activated or never be deactivated.
This branch is forked from sign-for-senders like others.
Related Issues

None

Checklist

[ ] Every CI jobs finished successfully

great!!


Older Apple ][ support

Hi,
I started a branch in https://github.com/andreasbaumann/cpm65/tree/apple2_plus to tackle older Apple machines
with 40-column displays only (or later some Videx 80-columns card).
I can report that CP/M-65 runs just fine on my IMC-2001 Apple ][ plus clone, many thanks for that. :-)
I also started a screen driver, but run into a 2K BIOS issue, I think in the loader (hence I disabled or didn't implement some
things yet). Tested with CLS, SCRNTEST, LIFE and QE, they seem to work so far.
Any ideas how to solve that, but the obvious one: to support reading from extends in loader.S?
What about loading the screen driver in userland after booting (like capsdrv.asm)? It's assembled with ASM currently, but
this could also be llvm, I suppose.
Another wild idea is to load a SCREEN.SYS after BIOS.SYS (again with a 2K limit).
I can of course also try to learn proper 6502 assembly coding and do some byte shaving.. ;-)

Oh, good that it runs --- the Apple II disk system is notoriously touchy.
Regarding making the BIOS bigger: the answer is, I'm not sure. We get up to one track loaded for us automatically, which is currently all we need. Loading another track would mean calling into the Apple II ROM as the disk driver isn't ready yet. That would also mean allocating another track from the already rather small disks for the extra BIOS --- but given that the minimum block size in CP/M is 2kB, we'd have to do that anyway.
The other thing is to build the BIOS twice, once for 40-column machines and once for 80-column machines (I guess you're trying to autodetect whether the card's installed?). That's a bit suboptimal but might be the easiest option.

The code for the 40 and 80 column mode is not that different, just some address calculations differ and the switching
between the two text pages, so this can easily be done with an #ifdef.
I think I found a solution for the memory problem: I followed the ideas in the atari800 port: I'm keeping a very simple
TTY driver in bdos.sys, which can run in 40/80 columns mode depending on the Apple model. Then there is a
SCRNDRV.COM which loads an extended TTY/SCREEN driver on top which can be as big as it wants (ok, less than the
size of a floppy disk perhaps).
This should be ok, as the BIOS bootup and the CCP should work just fine with the first TTY driver. Before using anything
which requires a working SCREEN driver one can simply load it with SCRNDRV.COM.
Switches are in apple2e.inc and I can set the model in build.py to
    cflags=["-DAPPLE2E"],
    cflags=["-DAPPLE2PLUS"],

(not sure if that is the smartest thing to do, will se)
There is some trouble ahead, because in principle I would like to call the old TTY driver from the new one (for instance
to stop the disk motor). But I need the same cursorx, etc. variables in the TTY and the SCREEN driver. One option would
be to put them in well known places in the zero page. I tried in an older commit to have a common.S file to share
the variables between bdos.sys and scrndrv.com, but then realised that the first one gets relocated and the second one
loaded into user space, so they cannot share variables this way.

Very nice!
Re exposing BIOS data: I hadn't thought about that. I think there are probably two ways to do it; the first is to add extra calls to the BIOS strategy table, but this is a little fraught because the numbers must be sequential and it would cause problems if new BIOS calls were ever to be added. The second is to create a driver. Allocating an ID for 'internal BIOS use' would be easy, and then you could add whatever entrypoints you like. The downside there is that there is some overhead for a driver, although it's not a lot --- twenty bytes plus the name, plus two bytes per entrypoint.
Also, it's very easy to persuade the build system to make something twice with different flags. That is, indeed, the whole reason it exists...

Didn't tackle the BIOS variable sharing thing yet, as I still have a lot of bugs in the screen driver itself I want to test and fix first.
I added a simple tetris from https://codeberg.org/eu/tetris.git, seems ok from the license point of view and is really small.
This tests the timeout parameter of the screen_getchar in a natural way (the tetris pieces should move down also when you don't press a key). :-)
Some interesting questions arise:

A non-waiting screen_getchar was missing (there is a screen_waitchar in lib/screen.h, lib/screen.S) has to indicate timeout. in assembly this is the carry flag, this translates to cpm_error or so for "normal" system calls (in cpm-65 in llvm-mos).
I was wondering whether to go the C route and use an int16_t for that and passing '-1' to indicate timeout?
Where to get randomness from (I know that Applesoft Basic did it by increasing some KEYIN counter in the zero page)
Putting that in the screen/tty driver feels a little bit awkward. Currently the seed is 42 in tetris.c which makes gaming
somewhat predictable. ;-)

Created a pull request https://github.com/davidgiven/cpm65/pull/177


jack: segfault in process_handler

Built from git, a29e0a4fc9000dad1610558334c62f0b6c571c46
Output:
desktop /tmp $ baresip
baresip v0.6.0 Copyright (C) 2010 - 2019 Alfred E. Heggestad et al.
Local network address:  IPv4=eno1:<IP_ADDRESS>
aucodec: PCMU/8000/1
aucodec: PCMA/8000/1
aufilt: vumeter
auplay: jack
ausrc: jack
vidcodec: H264
vidcodec: H263
vidcodec: MP4V-ES
medianat: stun
medianat: turn
medianat: ice
Populated 1 account
Populated 3 contacts
Populated 2 audio codecs
Populated 1 audio filter
Populated 3 video codecs
Populated 0 video filters
baresip is ready.
dom1@localhost: {0/UDP/v4} 200 OK (Asterisk PBX 16.1.1) [1 binding]
All 1 useragent registered successfully! (40 ms)
>                              100
call: connecting to 'sip:100@localhost;transport=udp'..
call: SIP Progress: 100 Trying (/)
audio: Set audio decoder: PCMU 8000Hz 1ch
audio: enable auplay resampler: 8000Hz/1ch --> 48000Hz/2ch
jack: play 48000Hz,2ch
jack: engine sample rate: 48000 max_frames=128
zsh: segmentation fault (core dumped)  baresip

Backtrace:
Reading symbols from /usr/bin/baresip...done.
[New LWP 24659]
[New LWP 24655]
[New LWP 24658]
[New LWP 24657]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
Core was generated by `baresip'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007ff738d1142a in process_handler (nframes=128, arg=0x55ff566d47b0) at modules/jack/jack_play.c:67
67				int16_t samp = st->sampv[j*st->prm.ch + ch];
[Current thread is 1 (Thread 0x7ff73140c700 (LWP 24659))]
(gdb) bt
#0  0x00007ff738d1142a in process_handler (nframes=128, arg=0x55ff566d47b0) at modules/jack/jack_play.c:67
#1  0x00007ff738cccd8e in ?? () from /usr/lib/libjack.so.0
#2  0x00007ff738cccc96 in ?? () from /usr/lib/libjack.so.0
#3  0x00007ff738cca4db in ?? () from /usr/lib/libjack.so.0
#4  0x00007ff738ceb072 in ?? () from /usr/lib/libjack.so.0
#5  0x00007ff738683a9d in start_thread () from /usr/lib/libpthread.so.0
#6  0x00007ff73841ab23 in clone () from /usr/lib/libc.so.6

~/.baresip/config, parts that differ from the default config:
audio_player            jack
audio_source            jack
audio_alert             jack
ausrc_srate             48000
auplay_srate            48000
ausrc_channels          2
auplay_channels         2

#module                 alsa.so
module                  jack.so

can you print the content of st->sampv ?
it is possible that the sampv buffer is allocated too late:
	err = start_jack(st);
	if (err)
		goto out;

	st->sampc = st->nframes * prm->ch;
	st->sampv = mem_alloc(st->sampc * sizeof(int16_t), NULL);
	if (!st->sampv) {
		err = ENOMEM;
		goto out;
	}

	info("jack: sampc=%zu\n", st->sampc);

you can try to move the allocation of st->sampv to inside start_jack.
after st->nframes is set and before jack_connect

@dominikh could you please re-test with commit f9d0c6b525e3202e547c035c6726682b3bd6a0f3 ?

should be fixed in master. please re-open if the bug is still there.


feat(core): add capability to define default behaviour to dialogue edges

Adding the capability to define default behaviour to dialogue edges.
The example is modified so that when including the ChitChatDialogue all attempts of initiating a dialogue will be rejected by default and will only be allowed if you specifically write a handler that does so.

This is just a minor example to demonstrate how we can effectively build complex dialogues that automate certain steps without the user having to modify/copy every individual step (which is part of the main benefits of dialogues from their inception)

While we are able to provide default behaviour to some or all of the graphs edges, this feature also allows a graph designer to only expose handlers for some of the interactions effectively 'hiding' some steps from the user of the dialogue.
One of the use-cases could be a re envisioned token payment dialogue in which two agents interact and agree on a token price for a specific service but the actual exchange of the wallet address and token payment can be 'automated' within the dialogue.


Flaky onboarding with link test

The onboarding with link test sometimes fails with a 403 Invalid CSRF token error.
To replicate, run npm test:e2e:dev and run all tests multiple times.
You'll see the onboarding with link failing with an 403 Invalid CSRF token error eventually.

Hey @andrecasal!
I just tried this myself and I was unable to reproduce with a fresh bootstrap of a new Epic Stack app. I ran the tests 10 times to be sure. Sorry!


TypeError: Array.prototype.reduce called on null or undefined

Problem
Howdy @todvora - I believe there's something wrong with the version you published a couple hours ago.
Repro
Clone https://github.com/reactiveui/documentation and git reset cf0f22c5cf2c49b91f7453b5bb83010921db2842 - any other commits past this point is where we have disabled the plugin.
Stacktrace
TypeError: Array.prototype.reduce called on null or undefined
TypeError: Array.prototype.reduce called on null or undefined
    at reduce (native)
    at redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:263:21
    at redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:1565:9
    at _fulfilled (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:796:13)
    at redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:857:14
    at runSingle (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:137:13)
    at flush (redacted\oss\rxui-documentation\node_modules\gitbook-plugin-image-captions\node_modules\q\q.js:125:13)
    at nextTickCallbackWith0Args (node.js:433:9)

I'm having the same issue, probably cased by #6. Unfortunately I'm not familiar with promises, can't help much here :(

Hi guys, thank you for the error report and sorry for my delay. I’ve been for the last two weeks in the wild, offline.
The first thing I just did do is a rollback to the previous, working version. New release is 0.3.3. Could one of you provide some minimized version of book source code, that causes this crash? Maybe as a markdown snippet, so I could extend the test suite and figure it out?
Thank you!

Thanks! Our books are publicly available at https://github.com/contao/docs
Be aware of the several subfolders with individual books.

Hi,
I've been able to reproduce this error on books from @aschempp and @ghuntley. It should be fixed now in the release 0.3.4. Could you please later confirm, that everything works ok for you?
@ghuntley: next time you don't have to disable a plugin entirely. It should be enough to specify a version of plugin, that works for you. In this case as<EMAIL_ADDRESS>This notation comes from gitbook itself and works for every plugin.
Thank you for the bugreport and testing materials!
Regards,
Tomas

Thanks for the fix! The build worked now :-)
https://travis-ci.org/contao/docs#L8351

Thanks for the feedback Andreas! Closing this issue now, hopefully is it fixed for @ghuntley too.


Turbosrc doesn't recognize maintainers of organizational github urls to repo.

If I recall correctly, Turbosrc is parsing the url. So for example github.com/turbo-src/ is an organization and it's expecting 7db9a.

Resolved with PR #111 merge


WIP: weather module improvements

Work in progress:

[x] add unit and language handling for weather provider darksky
[ ] feels like temperature
[ ] openweathermap forecast for newer api keys (grouping 3h forecasts)
[ ] some more config options from the previous modules

Warnings

:warning:

Please include an updated CHANGELOG.md file.This way we can keep track of all the contributions.

  Generated by :no_entry_sign: dangerJS


Changing sphinx theme din't recreate index.html

i change my theme from alabaster to sphinx_rtd_theme and rebuild my project.
The theme changed got effective in rest of the pages except for my index.html
I tried wiping out and rebuilding it dint work out either.
Link: http://dj-extensions.readthedocs.org/en/latest/index.html
Is that something intended or an bug?
Regards

Cached maybe? I get a page with our theme.

This issue went once docs got rebuilt when I updated the docs content.
On this particular issue I just changed only html theme in conf.py (dint update any contents in rst files) and  theme was not updated only for index.html. Weirdly I was able to see updated theme in http://dj-extensions.readthedocs.org/en/latest/ which point to index but not in http://dj-extensions.readthedocs.org/en/latest/index.html
I think it was not caching issue on client side, because I tried multiple browsers (also in private mode) and 2 machines. Even I tried wiping and rebuilding the docs the issue persisted until I pushed a new change to docs rst files.
I dint grab a screenshot to show you now, though.

This appears to be resolved, I'm going to close this as it doesn't seem to be a bug. If anyone else notices similar problems, we can reopen this.