Implement Add to List for dynamodb:UpdateItem

This handles the add-to-list case using the legacy AttributeUpdates parameter.

Added test coverage.
Verified against real AWS backend.

Closes #3561

Coverage decreased (-0.3%) to 94.299% when pulling fef78470db1e9aca30839b2aed5386da873c697e on bpandola:close-3561 into 6dfd64ff3c09b548a6b914ce6fc64ec86a9ffefe on spulec:master.

Coverage decreased (-0.3%) to 94.299% when pulling fef78470db1e9aca30839b2aed5386da873c697e on bpandola:close-3561 into 6dfd64ff3c09b548a6b914ce6fc64ec86a9ffefe on spulec:master.


Add other error message for metrics-server in default kubeadm config

This is the error message currently printed by the default-manifest metrics-server for a default kubeadm cluster installation for every node.
I believe this PR will make troubleshooting the metrics-server on a basic kubeadm install easier because this error message currently brings very few results online for kubernetes as it is not documented anywhere, even in the project repository.

Hi @adamency, Sign EasyCLA first.

Here are links ->

Intro to EasyCLA.
Sign EasyCLA according to the type of contributor

@utkarsh-singh1 @Arhell @neolit123 Yes I know, I had already looked at the checks list and went to the link to integrate EasyCLA to my account, however it is asking much more than other solutions where I have been used to only be required to sign-off the commits, so I will need time to think about it when I'm less busy.
@neolit123 I will also then provide with a screenshot where we can see that I'm actually printing the logs for a metrics-server container if that is sufficient ?

Hi @adamency, you haven’t signed the Contributor License Agreement (CLA) yet. Kindly sign the agreement to proceed with this PR.

/close
Please feel free to reopen this (or open a new PR) when the CLA is signed.


Automatically wrapping CSS in @-moz-document url-prefix("chrome:") breaks some themes

I've noticed that every theme downloaded from https://zen-browser.app/themes has its CSS automatically wrapped in @-moz-document url-prefix("chrome:") query. This breaks any theme that already has a @-moz-document query defined at its root.
I noticed this is breaking Compact Topsites. Is there an official workaround for this behavior?

The chrome.css files have this prefix because they are only intended to affect the browser chrome. They are not intended to function as userContent.css files for now

The chrome.css files have this prefix because they are only intended to affect the browser chrome. They are not intended to function as userContent.css files for now

Interesting. I probably missed this while checking the documentation on authoring themes. Still, does Zen plan to only support themes customizing browser chrome? If so, I can create a PR to remove Compact Topsites for now till this stance changes in future.


Cross-linking to other patterns

Learn Build status updates of commit 8e1539d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/patterns/competing-consumers-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@EdPrice-MSFT
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Learn Build status updates of commit 20c5dbd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/patterns/competing-consumers-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 92ed628:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/patterns/competing-consumers-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#Sign-Off


cmd/go2go: unclear error message in embedded type lists

What did you do?
Ran this program: https://go2goplay.golang.org/p/S4MLyTi6yA-
package main

import (
	"fmt"
)

type interger32 interface {
	type int32
}

type number interface {
	type float64, int, int32
	interger32
}

func Largest[type T number](s []T) T {
	var largest T
	for _, v := range s {
		if v > largest {
			largest = v
		}
	}
	return largest
}

func main() {
	arr := []int{101, -1, 45, 646, 3}
	l := Largest[int](arr)

	fmt.Printf("largest in %v is: %v", arr, l)
}

What did you expect to see?

Either it runs or produces a comprehensible error message about int32 been repeated in interfaces interger32 & number

What did you see instead?
type checking failed for main
prog.go2:28:15: int does not satisfy number (int not found in int32)

Just for the record, the problem is not that int32 is repeated in both interfaces, the problem is that int is not repeated in both interfaces: When interfaces are embedded, all the type lists are intersected. This way we can guarantee that if a type T satisfies an interface that embeds an interface E, T also satisfies E.
Agreed that we could use a better error message. Not urgent.

seems resolved at tip.

I'm going to re-open this. The error message at tip could be better. For:
package p

type interger32 interface {
	~int32
}

type number interface {
	~float64 | ~int | ~int32
	interger32
}

func f[T number]() {}

func _() {
	_ = f[int]
}

we get:
x.go:15:8: int does not satisfy number

We should say a bit more as to why.


SDL | Setting ValidateAudience to true to address CodeQL flag

This PR is setting the default value of ValidateAudience in  TokenValidationParameters to true.

Looks like the enclave test failures are due to this change:
Microsoft.Data.SqlClient.SqlException : The validation of an attestation token failed. The token signature does not match the signature omputed using a public key retrieved from the attestation public key endpoint at 'IDX10208: Unable to validate audience. validationParameters.ValidAudience is null or whitespace and validationParameters.ValidAudiences is null.'. Verify the DNS apping for the endpoint - see https://go.microsoft.com/fwlink/?linkid=2157649 for more details. If correct, contact Customer Support Services.

/azp run

/azp run


Deploy to heroku by travis

Pull Request Test Coverage Report for Build 1498

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.714%

Totals

Change from base Build 1497:
0.0%

Covered Lines:
87

Relevant Lines:
98

💛  - Coveralls


crashing after i sign in

after I logged into my account its started loading and then crashed
even with the insider build

same issue

same here


jupyterlab error displaying widget

Hello
I was using ipsankeywidget with jupyter notebooks but I've recently (today) reinstalled it and was hoping to be able to use on jupyter lab with the new support.
However I am getting an error: Error displaying widget: model not found even with very simple diagrams. the extensions seem to be correctly installed.

If I try to run the same notebook using the classic notebook I don't get the same error but there is no rendered image.
thanks!

I have the same trouble, but have the following installed. Works PERFECTLY in notebook, but delivers ' Error displaying widget: model not found'
Any pointers?
ipysankeywidget           0.3.0                      py_0    conda-forge
jupyter                   1.0.0                      py_2    conda-forge
jupyter_client            6.1.3                      py_0    conda-forge
jupyter_console           6.1.0                      py_1    conda-forge
jupyter_contrib_core      0.3.3                      py_2    conda-forge
jupyter_contrib_nbextensions 0.5.1                    py37_0    conda-forge
jupyter_core              4.6.3            py37hc8dfbb8_1    conda-forge
jupyter_highlight_selected_word 0.2.0                 py37_1000    conda-forge
jupyter_latex_envs        1.4.4                 py37_1000    conda-forge
jupyter_nbextensions_configurator 0.4.1                    py37_0    conda-forge
jupyterlab                2.1.1                      py_0    conda-forge
jupyterlab_server         1.1.1                      py_0    conda-forge


[BUG] Can't extract interface

From vscode-dotnettools created by julioct: microsoft/vscode-dotnettools#545
Describe the Issue
Extracting an interface is an essential part of day-to-day coding activities, but with the latest C# extension version you can't do it.
In version 1.26.0:

In latest version:

Can we get the Extract interface... context menu item back?
Steps To Reproduce

Use the lightbulb to open the context menu item on any class
The extract interface... context menu item is not there

Expected Behavior
The extract interface... context menu item should be there.
Environment Information

OS: Windows 11
VS Code version: Code - Insiders 1.83.0-insider
Extension version: 2.2.10

O# feature gap fill.

Temp workaround:
Open workspace settings (json)
Add:
{
  "dotnet.server.useOmnisharp": true,
...
}

When is this feature going to be implemented? It's a very important one, in my opinion. I think VSCode is very close to replacing Visual Studio for Small to medium projects

Temp workaround:
Open workspace settings (json) Add:
{
  "dotnet.server.useOmnisharp": true,
...
}

That doesn't help with C# Dev Kit installed, which most people would want to use:

This is so basic. Any updates on proper support?

I have "C#" (Microsoft) and "C# Extensions" (JosKreativ) extension installed but not "C# Dev Kit" and it still doesn't work with Omnisharp :/

Months go by with this issue persisting. It actually hinders productivity by quite a lot having to manually implement interfaces and abstract classes. Disabling C# DevKit and enabling OmniSharp does resolve the issue but the extension itself along with other useful dependencies help with development.
Any updates or progress on this?

I took a closer look at this feature.
From O#, it looks like,

It simply gets all the code action providers from Roslyn
For extract interface, it creates many wrapper types in the code path when code action is invoked
I. https://github.com/dotnet/roslyn/blob/main/src/Tools/ExternalAccess/OmniSharp/Internal/ExtractInterface/OmniSharpExtractInterfaceOptionsService.cs
II. https://github.com/OmniSharp/omnisharp-roslyn/blob/ac7b9b8509356e39583de2b9fdf363005e6c8595/src/OmniSharp.Roslyn/WorkspaceServices/ExtractInterfaceWorkspaceService.cs#L19
In simply words, it extracts all the extractable symbol in the type to a new interface. (In VS, we create UI to let user make choice)

If we want to close the gap between O#, it's easy to just create similar types in our LSP layers. But it's hard to create a similar thing in VS, because we don't control any UI in VSCode.

Is it foreseen in near future?
Thanks.

Is there any update on this?

C# support gets worse and worse :-(


grammar

https://www.a-or-an.com/a_an/handle
thanks

There’s something for everything now... 🤣
On Fri, Dec 27, 2019 at 1:06 AM Eric Marchand<EMAIL_ADDRESS>wrote:

https://www.a-or-an.com/a_an/handle
thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OAuthSwift/OAuthSwift/pull/567?email_source=notifications&email_token=ABU2FGEZAPUSLHZBVE5VQW3Q2WLM7A5CNFSM4J6B6AS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWUGYQ#issuecomment-569197410,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABU2FGDCR4WQ44AV7INPCH3Q2WLM7ANCNFSM4J6B6ASQ
.


[Frontend] Preserve .swiftdeps files

The Swift compiler uses files with an extension of ".swiftdeps" to store information about cross-file dependencies. These files are read in at the start of compilation to compute a dependency graph, and updated as compilation proceeds. However, because these files are updated on every build, an issue with dependency analysis is hard to reproduce—the inputs have been lost.
Address this by renaming swiftdeps files that are about to be overwritten, to .swiftdeps~. This preserves dependency information from the most recent compilation (but no further back).

Resolves SR-3164.

Thank you! Can you do the same for the top-level build record file too? (Which has the same extension even though it's a different format.)

@jrose-apple Done! Let me know what you think.
@swift-ci please smoke test

You're quite welcome! Let me know if you have any ideas for meatier tasks involving incremental compilation. :)


Add max. addresses / outgoing edges as config option to search incoming / outgoing

In many cases it does not make sense to go deeper when hitting a node with more than X (e.g., 1000) outgoing edges because this is most probably an exchange.
Suggestion: add max. outgoing nodes to context menu config and consider this when traversing the graph. Using that restriction it would be possible to go deeper than 3 steps

improve setting of breadth value (< skipNumNeighbors)

criterion for skipping a node is its number of addresses, not neighbors

done


Wrangling of new dataset: HumanAdiposeTissue GSE128890

Dataset/group this task is for:
GSE128890
Wrangler responsible for this dataset/lab:
A wrangler working on operations this sprint
Description of the task:

[x] Curated metadata spreadsheet (please see all comments in this ticket below): https://drive.google.com/drive/folders/1dOTCQ1TAoQm4Pm0VjUM1lxfXryWYL89h

[x] Secondary review of dataset (@mshadbolt)

[x] Validate the dataset by uploading to ingest

[x] Validate the dataset with graph validator?

[x] Add to list of datasets 'Complete' for MVP: https://docs.google.com/spreadsheets/d/1DfRFfZpZEmWU6aubKwIZ4D0lfm038IW0fmHRigS8yBU/edit#gid=552473761

Came across an issue identifying whether the single human sample is derived "from the abdominal subcutaneous adipose tissue of a 31 y.o. human female" as it states in the GEO soft file, or whether tissue from 8 human donors was pooled as implicitly suggested in the publication. Will email contributing author.

Asked Patrick Searle this:
"One more question I had is about cell type selection using FACS. In the methods the following markers are used to enrich for human stromal vascular cells: CD26, ICAM1, CD45, CD31, CD142. Which of these markers, if any, is a positive selection marker? or are they all used for enrichment of SVCs by negative selection?"
Reply:
"For the SVC sequencing, we excluded cells expressing CD45 and CD31 (Lineage-).   The other markers were used as positive selection markers for sorting cells in downstream validation/functional analysis (CD26, ICAM1, CD142)."

asked Patrick Searle this:
"the metadata file downloaded from the GEO database (accession: GSE128890) suggests there is just 1 Human abdominal subcutaneous adipose tissue sample which is derived from a 31 y.o. female (id: GSM3717979). However, in the publication methods section the collection of 8 Human adipose samples is described. It would be great to know whether the 8 adipose tissues were pooled prior to single cell RNA sequencing, or whether the sequencing data is available for only 1 of these donors."
Reply:
"The sequencing data is only available for 1 donor.  We did validation and follow up by other methods in a larger panel."

The complete metadata sheet based on the publication, GEO metadata and email exchange with Patrick Searle can be found here: https://docs.google.com/spreadsheets/d/1wxbHjaF7Jmleg_UnokdwU1zeKsbiHmbVD61KdUuGEKU/edit#gid=563050045
This metadata sheet needs:

Secondary review

Validation with the graph validator

Transfer of raw fastq from the public archives to ingest UI

Ami to add remaining ontologies first

Secondary review:
Project - contributors

Data curator role isn't present for Ami Day
multiple authors don't have orcid filled in even though they are available from the paper

Collection protocol

The collection protocol for the two mice strains seems pretty much the same so it could be combined into one protocol to simplify

Specimen from organism

I think for organ part the term UBERON:0014455:subcutaneous abdominal adipose tissue might suit better for the human specimens
in the collection protocol for the mice they mention 'white adipose depots' and am wondering if it is worth using the white adipose tissue - UBERON:0001347 term perhaps inguinal fat pad||axillary fat pad||white adipose tissue? though maybe not important to be that important with the tissue typeas well as the locations? I think I would definitely change the 'inguinal part of abdomen' to the 'inguinal fat pad' though.

Enrichment protocol

Is there any difference between the protocols that were used for size selection for human vs mouse cells? could potentially collapse into one if no difference

Sequence file
Are we sure that the four sets of I1, R1, R2 from cell suspension SRX5692097 should be analysed separately? i.e. do we know that these are cell suspensions that were split into libraries rather than a single library being split? Just need to confirm this to ensure the process id is grouping the right set of files together and ideally copy this into the library preparation id column.
I think for the other two cell suspensions that they should have all the same proces id as they are the same cell suspension sequenced on different lanes. but maybe I have misunderstood the structure of the experiment.

Thanks @mshadbolt I have made the suggested changes.
For the last point about the process ids: I re-read the methods and there is no specification about whether cell suspensions were divided into technical replicates before library preparation or whether a single library preparation was divided into technical sequencing run replicates. I decided to replace the run accessions in the process ids column with the experiment accessions, as I would think the same experiment accession indicates the runs are technical replicates.

@ami-day this was included in the export so I am guessing we can close the ticket now?

This project has been exported, so closing this ticket.

Preparing for SCEA with ID E-HCAD-20

Preparing for SCEA with ID E-HCAD-20

I think this ticket should be in finished, it was exported as part of MVP and is in the browser here:
https://data.humancellatlas.org/explore/projects/42d4f8d4-5422-4b78-adae-e7c3c2ef511c?catalog=dcp2


[BUG]SAML SingleLogoutService requests to ADFS are not signed and causing errors when we trigger dashboard logout

Describe the bug
SingleLogoutService requests are not signed  and ADFS is rejecting these requests,  as requests are not signed.
To Reproduce

Configure SAML with ADFS as IDP to login to DashBoard.
As part of configuration, in adfs metadata.xml, keep SingleLogoutService urls
Trigger Logout on Kibana dashboard.

Expected behavior
OpenSearch should post Signed SingleLogoutService requests to ADFS.
Additional context
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/saml.html

[Triage] Thanks for filing this issue.

@peternied this issue can be closed. The plugin does support signing SAML requests
https://opendistro.github.io/for-elasticsearch-docs/docs/security/configuration/saml/#request-signing

@devardee Thanks for looking at this issue, I did not see documentation saying why this feature should not be supported, did I miss something?
However being that its support its called out, it seems like this issue could be transitioned from a bug to a feature request instead.

@peternied the feature requested in the issue is already supported by the plugin. However, the AWS Managed Opensearch Service does not provide this feature.


4.3.0 Legacies Collection Thread

Hello everyone, I would like to close the threads with leagcy suggestions that were made for 4.2.0 ( #83 #99 ) and start here in a consolidated list of the still open points as well as for new suggestions.
I would request that you please use this thread for any requests for additional legacies, description or name change suggestions, etc.
Open ToDos:

[x] Buff Paladin Legacy the same way Rogue and Dread Knight were
[ ] Change Base Shifter Name and Description, someone have a good idea please?
[x] Rework Tactician to also be an Inquisitor subtype buffing it in the process
[ ] Bloodrager Legacy - Chimeric Rager
[x] Witch Legacy - Pactmaker
[x] Inquisitor Legacy - Domain Lord
[x] Inquisitor Legacy - Divine Prosecutor
[x] Druid Legacy - Nature Mage
[ ] Player Legacy - Computer Nerd

Base Archetype:
Bloodrager
Name:
Bloodrager Legacy - Chimeric Rager
Description:
Much like the Chimera you draw upon the power of inhuman bloodlines and learned how to slowly either awaken or fuse more of them into yourself.
However, you would rather use that to empower your melee attacks rather than your spells.
After all, what is the point of draconic claws or a phoenixes burning wings if you only use them as a fallback?

Wait what do you mean there are no computers in this world and all that knowledge and skill is useless?
Well at least some of the theoretical knowledge about magic is applicable in this world...
Archetypes:
All
Mechanics: Essentially a purposfully underpowered legacy that only grants some minor benefits (potentially skill focus arcana) so there is an option for players who consider all the other options too overpowered
Suggestions that are either To much work for this release due to the amount of customization or require more detail so that I know what to do
ThePiggyGalaxy commented 17 hours ago •

I'd like a separate monk-adjacent legacy, for a monk that like the shifter halves his ac bonus when wearing armour, but unlike the shifter feat it just works with all armour (instead of non-metal) this would also be fine to be changed to all non-heavy armour (in which case you could add something like that as a class feat or normal feat after a certain monk level and armour proficiency).
You could call this: Armoured Daoist / Ironclad Daoist.
With a description along the lines of: While you train your body and mind you've come to the epiphany that flesh inherently is weak, so you chose to train in both body and armour, and have specialised your martial arts around this, coward.
Also it would be amazing for this legacy in particular to have a single weapon choice which they'll have to commit to like the Sword saint, but making that a separate legacy is fine as well.
If included in prior mentioned legacy it could be called: Imperial master (as in the Chinese / Korean imperial army) or a Samurai
With a description along the lines of: Since young you have trained for your lord and country, to utilise martial arts specifically meant for one specific weapon and whilst wearing a set of armour, you became the pinnacle of your lords army and then died, idiot.

Most of the Feats mentioned for these would have to be custom created, so this is something for a later build.

Inquisitor has domains too (and without bonus spells, which is perfect) so that effectively the same thing yes.
Regarding Witch I think you know by now I would just include it in the Mastermind (or give it for free to this subclass ang getting to choose a dual at lvl1 ?)

the potential split of villain into mastermind and tbd is part of the 5.0 discussion, so for 4.3 the class is still villain which alongside IP is the only current option for the as of now unnamed witch archetype.

Yes sorry I mixed them up.
Will work on the Leyline witch legacy later.
Side question : domain would have to scale off CHA I guess?

          Personally I think this extent of Kineticist powers should be a separate op ability instead of legacy that you can chose on lvl 1.

I know it's balancing a class that isn't balanced by design, but it still makes other choices suboptimal and what's wrong in balancing abilities in the same category so one ability doesn't feel worthless compared to others. And I like doing solo runs with Protagonist that way it doesn't feel too op.
Originally posted by @Nerin3 in https://github.com/JohN100x1/WOTR_IsekaiMod/issues/108#issuecomment-1477933346

Oracle legacy feels weak compared to sorcerer legacy though
As for tactician maybe I'd move studied target there or give him inquisitor abilities and just make it into inquisitor legacy.

their definition is literally identical  except for the name I used for the selection though:
                   Helpers.CreateLevelEntry (1, ExtraSelection ),
                   Helpers.CreateLevelEntry(3, ExtraSelection),
                   Helpers.CreateLevelEntry(6, ExtraSelection),
                   Helpers.CreateLevelEntry(9, ExtraSelection),
                   Helpers.CreateLevelEntry(12, ExtraSelection),
                   Helpers.CreateLevelEntry(15, ExtraSelection),
                   Helpers.CreateLevelEntry(18, ExtraSelection),

                    Helpers.CreateLevelEntry(1,  OracleSelection),
                    Helpers.CreateLevelEntry(3, OracleSelection),
                    Helpers.CreateLevelEntry(6, OracleSelection),
                    Helpers.CreateLevelEntry(9, OracleSelection),
                    Helpers.CreateLevelEntry(12, OracleSelection),
                    Helpers.CreateLevelEntry(15, OracleSelection),
                    Helpers.CreateLevelEntry(18, OracleSelection),

Now the Oracles class feats are not 100% identical to sorcerer, so if you pick a bloodline each time you might get more usage out of it, so if you have a suggestion on where to add those additional selections I will consider it. I am also considering removing some levels for the sorcerer variation because as it stands it already is much more than just a full class progression...
Making the tactician also an inquisitor subtype is certainly an option to buff him, heck I started from the monster tactician when I first came up with it and then went: well but I always missed Animal Teamwork, oh and wasn't there another class that grants the ability to temporarily grant tactic feats to others? Not that I ever really use that lastoption because between my animal companion and summons who needs to buff human companions :D
It was very much a prototype...

Maybe move the sorcerer to every 4 levels and Oracle to every odd level, or just one of those two changes?

Yes sorry I mixed them up. Will work on the Leyline witch legacy later.
Side question : domain would have to scale off CHA I guess?

Making Domains work on Charisma is sadly not very feasible unless I completely switch them over for all characters.
The Attribute is actually set in the Resource of the ability in a field that permits only a single value. So that would have to be switched over to charisma. A bonus feat granting additional uses based on either int or charisma might be possible though

I'd like a separate monk-adjacent legacy, for a monk that like the shifter halves his ac bonus when wearing armour, but unlike the shifter feat it just works with all armour (instead of non-metal) this would also be fine to be changed to all non-heavy armour (in which case you could add something like that as a class feat or normal feat after a certain monk level and armour proficiency).
You could call this: Armoured Daoist / Ironclad Daoist.
Also it would be amazing for this legacy in particular to have a single weapon choice which they'll have to commit to like the Sword saint, but making that a separate legacy is fine as well.
If included in prior mentioned legacy it could be called: Imperial master (as in the Chinese / Korean imperial army) or a Samurai

Making Domains work on Charisma is sadly not very feasible unless I completely switch them over for all characters. The Attribute is actually set in the Resource of the ability in a field that permits only a single value. So that would have to be switched over to charisma. A bonus feat granting additional uses based on either int or charisma might be possible though

A tad sad since DC (for those which have one) are WIS based too, but if it can be fixed...
Not on Git but Homebrew Archetypes includes an Elder Mythos Cultist that is based on charisma for spellcasting and domain (and is eligible for Impossible domains mythic ability)

Correction on your statement, the cultist gets two specific domains Madness and Chaos that are Charisma based.
Those domains are also hardcoded to charisma in it so would use charisma even if they were added on another Archetype of cleric.
As is the void domain they added separatly from the archetype.
If you add on another domain with Impossible domain it should be calculated wis based unless I overlooked something in their code.
Feel free to try and then tell me.

Correct they are special versions added specifically by the archetype.
9ebe166b9b901c746b1858029f13a2c5 is the normal madness domain
edeaf656aa3652d49abb2350b4c1e579 their tailored version

@kjk001 I could make some tests and you were perfectly right impossible domains are calculated WIS based for use/day and DC but not the 3 specific ones.
There are not so many domain powers with DC so not so bad if a CHA bonus cannot be added.

Maybe for oracle add ability to get Final Revelation earlier by spending a feat, and make revelation feats separate?

I would always at least bundle it with the Arcana Option so people that feel they have enough revelations have the option to pick a spell instead.
Or perhaps just with a repeatable none option.
But I will consider such a second selection and where and how many levels of it to add

@Nerin3 on another note since your suggestions for flavortext tend to be good could I encourage you to fill in some of those "?" above?

I'd like a separate monk-adjacent legacy, for a monk that like the shifter halves his ac bonus when wearing armour, but unlike the shifter feat it just works with all armour (instead of non-metal) this would also be fine to be changed to all non-heavy armour (in which case you could add something like that as a class feat or normal feat after a certain monk level and armour proficiency).
You could call this: Armoured Daoist / Ironclad Daoist. With a description along the lines of: While you train your body and mind you've come to the epiphany that flesh inherently is weak, so you chose to train in both body and armour, and have specialised your martial arts around this, coward.
Also it would be amazing for this legacy in particular to have a single weapon choice which they'll have to commit to like the Sword saint, but making that a separate legacy is fine as well.
If included in prior mentioned legacy it could be called: Imperial master (as in the Chinese / Korean imperial army) or a Samurai With a description along the lines of: Since young you have trained for your lord and country, to utilise martial arts specifically meant for one specific weapon and whilst wearing a set of armour, you became the pinnacle of your lords army and then died, idiot.
In the same vein some more isekai backgrounds in cultivation settings or just ancient China settings would do great, e.g.

Scholarly sectarian: You used to be part of a scholarly faction of the murim of your old world, you used all your time acquiring knowledge but died before you could obtain all of it.
You can use the highest between your intelligence or your wisdom when you use knowledge, lore or perception checks and gain proficiency in these
Demonic cultist: Before you died you used to practice demonic arts inside of the Demonic Cult of your previous world's murim, this made you quite aggressive, but helped you grow your strength quickly, however your increased aggression was likely the cause of your death
You can use the highest between your strength and dexterity for athletics and mobility check and gain a proficiency in these

should I make a separate issue for the background suggestions?

probably a good idea because I think John doesn't check this thread as it contains only my todos

Another the Paladin's Legacy. Something like "Light in the Dark"
Combining all the passive auras of a paladin and his archetypes that affect his allies.
At the same time, these auras act 30 feet around the character. If it is possible to do so. Just like the archetype of the paladin Martyr.
It may not look as strong as other legacies, so you can add something else there, for example, tactical feats.

Another the Paladin's Legacy. Something like "Light in the Dark"
Combining all the passive auras of a paladin and his archetypes that affect his allies. At the same time, these auras act 30 feet around the character. If it is possible to do so. Just like the archetype of the paladin Martyr.
UPD: You can also add auras from other classes so that the hero is a "tower of auras". Otherwise, it may be extremely weak compared to other legacies.

All paladin auras, 30f instead of 20 (martyr) and pack it up with Warrior of the holy light features and voila

All paladin auras, 30f instead of 20 (martyr) and pack it up with Warrior of the holy light features and voila

I'm not sure about that. The "Power of Faith" ability requires "lay on hands", so you will need to add a similar ability, but I don't want that.
 And strengthening this assembly with auras would be a nice addition. And i'm afraid that something might break in my character's abilities...

Regarding the different pools of similar abilities? Perhaps yes. Thought it would match the light theme.
There is a mod that fused them by the way.

I believe through something like what the resource unification mod does, this would be fine if it were done as such.

I believe through something like what the resource unification mod does, this would be fine if it were done as such.

It would also be quite unecessary for our mod as our ressources are already unified for the most part and getting more unified to the base game as we go.
You could if you took the shaman legacy for example switch to a level of shaman and watch as those spirit progressions suddenly move out of the class and onto the character level for being displayed. Same for Kineticist and their Kinetic Blast. It would be a waste of a level but you can do it to check :)
I can check if there is a way to increase the range of auras only if a specific feat is present rather than for everyone.

If it has to be for everyone that's not really an issue I guess, since the other abilities of the Martyr paladin (songs) are already on a 30f basis. That would buff them just a little.

 There, you learned how to make pacts with various beings, from spirits and demons to dragons and gods. You use your pacts to gain power, knowledge, and allies in this strange new world. But beware, for every pact has a price, and some beings may not be so willing to cooperate with you.
Archetypes:
Any archetype really?

Base Archetype:
Inquisitor
Name:
Inquisitor Legacy - Domain Lord
Description:
You were a devout believer in your previous world, but you discovered a dark secret within your church that led to your death. Now, you have been reborn in a world where the gods are numerous and diverse, and you seek to learn their secrets and powers. You can access various divine domains as you level up, gaining their spells and abilities. You are not afraid to use any means necessary to uncover the truth and expose corruption, even if it means going against your own faith.
Archetypes:
Every non-evil archetype?
Mechanics: Mythalars idea for an evangelist build moved over to inquisitor, gaining new domains every few levels. Reason for the move from cleric to Inquisitor is that I need to patch Inquisitor anyway for its other legacy.

Base Archetype:
Druid
Name:
Druid Legacy - Nature Mage
Description:
You were a nature lover in your previous world, but you lived in a polluted and crowded city that stifled your connection to the natural world. You dreamed of escaping to a place where you could be free and wild, and one day you got your wish. You have been reincarnated in a world where nature is abundant and diverse, and you have learned how to tap into its primal magic. You can cast spells that manipulate the elements, summon creatures, and enhance your own abilities.
Archetypes:
IP, Hero?

Base Archetype:
Inquisitor - Judge
Name:
Inquisitor Legacy - Divine Prosecutor
Description:
Judgement Master Description: You were a judge in your previous world, but you were killed by a corrupt system that twisted the law to serve its own interests. You have been reborn in a world where law is often ignored or perverted, and you have sworn to uphold the law and punish the lawbreakers. You can use your judgements more often and more effectively than other inquisitors, enhancing your abilities and weakening your foes. You are a champion of law and order, and a scourge of chaos and anarchy.
Archetypes:
Any, but restricted to Lawful alignment.

please see the first post, the fact that paladin will get the same treatment as rogue and dread knight got is literally the first todo on the list ;)
As for magus, I will also add that rework to the list somewhere, but current order is Paladin, Inquisitor, Druid, Bloodrager, Witch, Oracle, Arcanist for the class based legacies that need either creation or some adjustment based on the recent feedback.
About the only archetype that is problematic for magus is eldritch scion because that ***** actually duplicates every single ressource of the class...

Well all options are on the table I guess !
Just saying that, as a separate legacy, it's quite barren but can actually be a niche thing since exploits are CHA sacled.

Well all options are on the table I guess !
Just saying that, as a separate legacy, it's quite barren but can actually be a niche thing since exploits are CHA sacled.

for now the villain will get it as an option and when the 5.0 rework comes it can either be directly merged into the main progression or can be added there as a freebie granted by it.
I have the bad feeling that when the actual list of new restrictions on who can pick what legacy comes out for patch 4.3 I will make myself really unpopular as people didn't take the announcement that the options would remain restricted even on the Dual Class Selection serious at all.

Quite logic though.
The issue is criterias : domain powers for examples can be selfish, generous, good or bad.
Same goes with subclass mechanics : only allowing related legacies (melee for edgelord, castery for mastermind etc...) would only double on what they already have/could have.
Support is an issue by itself : bard legacy, as described, would be odd for baddy but bards can be of every alignements so...
Good luck xD (or make a UMM option that supress restrictions?)

Those are good questions.
My original thought was to go a similiar route to the chimera sorcerer and give them all an additional domain for every 5 levels because without the special spell list(though that was true for Inquisitor when compared to Cleric anyway) and with the freedom that IP has in picking their spells domains actually loose some of their utility, so I think that will not make them too overbuffed.
Then remove 1 or 2 of those selections on Judge and Tactician in exchange for their additional boni that they might get on top of the base archetype.
Or Maybe I will reduce the number of tactical Feats the Judge and Domain Lord have access to adding even more domains for the lord and some other judgy abilities for the Judge.
Either way I feel that no matter what I go with it likely will lead to adjustments in the next few patches as user feedback comes in, so I will just try to strive for something that is at least somewhat balanced when compared to the other legacies...

So Judge already looses all the Tactics feats and Bane in Exchange for his judgements, so perhaps just adding bane back there and they will already be fine, I will post screens later when I have a first build, in the meantime paladin now works...

Oh I would have based the Tactician on the Tactical Leader actually, but replacing the Tactician ability (wich is very limited), by a reduced version of Life-Bonded Friendship and with a normal teamwork progression.

That would replace Tactician, Hunter Tactics and summon tactics

IIRC @JohN100x1 really likes the General vibes, so sharing only to pets and summons is not very satisfying.
On the other hand Tactician grants only one teamwork feat to everyone but just X times/day.
A new ability that shares all of them continuously would solve this, and justify less domains (or one really).
You could test it with just the Azata superpower to have some insight.

hm, given how gutted the actual tactical feat selection progression on that archetype was I kind of forgot it was there and actually used Forester Tactics for the lower level version that buffs allies instead of swift tactician.
Why did no one comment on that for the old archetype?
Ok, I'll change that feat over since using that instead makes sense...

the domain is below the screenshot even though the selection doesn't work yet.
I will have to overwrite the default Inquisitor feat for it with a custom one as otherwise no option is selectable(similar problem appeared for Oracle, Sorcerer, and Shaman when first implementing them and you know what I should probably check witch patron too...
But yeah, first to do a hardcopy of every pladin feat, luckily there are not that many and some John had already copied

Yeah I saw there was domains below those.
And yes the paladin alignment restriction is a chore...
Regarding witch patron those are not really useful since they do not condition hexes (contrary to shaman) and only give new spells that you already have as an IP.

Witch ironically also worked without having to recreate the selection.
I also moved the first domain selection of all inquisitor archetypes to level 2, while I am sure Toybox is to blame for the fact that I have to jump back to it after selecting a god but it is annoying and you get the second level early enough...

Second question, the answer is yes.
First question, that would have also solved the valid god restriction on level 1 with toybox active and in theory yes, let me test it.
But first the Bloodrager because that waited long enough...

Ah, I remembered, the Bloodrager legacy should be compatible with Tome of the firebird's Phoenix bloodline, if it doesn't just reference the existing / enabled bloodlines from the base class (as far as I know this mod is the only one to add bloodlines apart from tabletop tweaks)

If a bloodline is missing blame the other mod creator and when they define and add it to the array.
At the point when we run:
bloodlines.SetFeatures(FeatTools.Selections.BloodragerBloodlineSelection.Features.m_Array);
we should technically already be ashamed of ourself.
But yes please do mention if you find any such legacy so we can see if there is yet another later place where we can mod stuff :D

Bit late, but you can change the name of Shifters to Skinwalkers and treat them like the Navajo boogeyman. They would drop right into the Villain category though. You don't get much more evil than a Skinwalker.

Bit late, but you can change the name of Shifters to Skinwalkers and treat them like the Navajo boogeyman. They would drop right into the Villain category though. You don't get much more evil than a Skinwalker.

@Brody1018 I can certainly rename it and change the description as long as your complete suggestion is in by tommorow evening. Otherwise it will have to wait till the next patch.
I would not move it to villain though because that is a methodical planner rather than just an evil anything, so until the villain is split into two archetypes in 5.0 the shifter would still fit the edge lord better(after all an edge lord can be evil too)

Skinwalkers are rare and dangerous predators that choose to exist above the natural order. Rather than communing with nature like the druids, Skinwalkers are known to choose a powerful predator, often times protectors of forests or mountains, before stalking them from the shadows until they find an opportune moment to lay a trap and claim their life. They will then ritually skin their prey before donning their hide and using it to transform into a semblance of its once mighty owner.

I am now torn on this because I just noticed that this leaves us with a distinct lack of truly heroic options for shifter legacies(besides dragon which can always be heroic).
So I would actually move this to the next patch while we all consider Holy Beast and Griffonheart Shaper for additional archetypes.
On that note, since I checked the nexus page and saw a request for cavalier there, any suggestions for names and descriptions for legacies based on cavalier and its Knight of the Wall and Standard Bearer archetypes?
In a similiar vein I will actually split the magus into two upon reimplementing it as a buffed version, Sword Saind and Spelldancer, so open for suggestions on that as well

I am now torn on this because I just noticed that this leaves us with a distinct lack of truly heroic options for shifter legacies(besides dragon which can always be heroic).
So I would actually move this to the next patch while we all consider Holy Beast and Griffonheart Shaper for additional archetypes.

Would it be possible/easy to implement a choice to allow the shifter to become demons or other mythical beasts? The novelty of being different types of demons would be interesting enough even if you lack the levels to be as truly overpowered as some other choices. If so, you can go down the path of the Red Mask in Alush and have them be some sort of wicked savior to demons. Or you can just do the same thing and have them be wicked.

possible, yes, if it is easy I can't tell, isn't there a demon based archetype?
If it was just porting that then it would be very easy, if we have to make our own spells and abilities then no it would be hard.

There is a demon-based archetype, but I have heard (I haven't tested it myself) that they do not have the ability to transform and only have minor aspects.

closed with #122


ci(goreleaser): Warnings related to set-output and node version in goreleaser workflow

Context
We usually get 7 warnings when goreleaser runs. Here's the run from v0.21.9 for reference.

Solution

GitHub Actions: Deprecating save-state and set-output commands - 2023-July-24
GitHub Actions: All Actions will run on Node16 instead of Node12 by default

Completion

[ ] Fix set-output warnings
[ ] Fix node version warnings

I think we fixed this. I don't see the warnings in GHA anymore.


Release v12.2.0

What
Release GOV.UK Prototype Kit v12.2.0 from a support branch.
This will be a small release including only:

Bumping the version of GOV.UK Frontend to v4.3.0
Including the new step-by-step pattern

Done when

[x] The support branch has been created
[ ] The changes have been tested and made in the support branch
[ ] Release notes have been drafted
[ ] The release has been published to GitHub with the release notes as drafted, following the releasing from a support branch process
[ ] The release comms have been published
[ ] The website has been updated to reflect changes to step by step pattern

We might want to hold off the release to await GOV.UK Frontend v4.3.1


Remove prefer-to-be from Recommended Configuration

Summary
The rule prefer-to-be should not be enabled with the recommended rule set, as it is a stylistic and preference-based rule.
Issue
Using toBe() over toEqual (or toStrictEqual) is not strictly better and there are good reasons to not use prefer-to-be. I prefer using toEqual for both primitives and objects, because it removes unnecessary nuance about when to use which. toEqual almost always does what I want, except for rare cases when I need to compare object references. For an article with a bit more depth, refer to https://dev.to/thejaredwilcurt/why-you-should-never-use-tobe-in-jest-48ca.
The recommended ruleset should only contain rules that are almost always beneficial and prevent bugs. This is not the case for prefer-to-be. The best reasoning I could find for such a rule was purely stylistic, because "it reads better" (from https://github.com/jest-community/eslint-plugin-jest/issues/801). Note that eslint-plugin-jest does not include prefer-to-be in the recommended rule set, but the style rule set instead.
It would also help to add some reasoning to the rule to help people decide whether they should enable it or not - again, similar to what eslint-plugin-jest does:

When asserting against primitive literals such as numbers and strings, the equality matchers all operate the same, but read slightly differently in code.
This rule recommends using the toBe matcher in these situations, as it forms the most grammatically natural sentence. For null, undefined, and NaN this rule recommends using their specific toBe matchers, as they give better error messages as well.

I didn't have a specific reason of making prefer-to-be a recommended rule to be honest. You're reasoning made me think through it a bit more. I agree with you that it shouldn't be a recommended rule.

Thank you! Appreciate the fast response


✨ Make network client timeout customizable

Purpose of this PR is to make network client's timeout customizable.
In our wallet, we support both WC V1 and WC V2. We use 10 seconds as timeout for V1. However for V2 it is 5 seconds as default and it makes things on our end a little bit inconsistent.
Thanks in advance!

@jakubuid thinking about this more, we should probably put a min and max that is allowed. We don't want to potentially raise any issues with edge-case values

@jakubuid thinking about this more, we should probably put a min and max that is allowed. We don't want to potentially raise any issues with edge-case values. Specifically we probably don't want a timeout that is longer than the rebalancing timer.
Maybe we do a min of 5 seconds and a max of 1 min?

Sounds good to me

Unfortunately, I am not able to resolve conflicts;
Only those with write access to this repository can merge pull requests.
I'll be waiting for you to resolve them, then I can merge.
Thanks!

I assume I need your assistance for tests, @Elyniss 😇

On it 🫡

Imo, all good, @mitsinsar
Android-Core:

Relay:

Thanks for your quick response @Elyniss. Since I don't have permission to merge it, this pr will be waiting for your action.
Thanks a lot!


[QUERY] Azure Communication Service .Net SDK: does SDK have any opportunity to get text transcript of speech during video(or audio) call?

Library name and version
Azure.Communication.Calling 1.0.0-beta.29
Query/Question
Hi! So, my question in the title: does .Net SDK have any opportunity to get text transcript of speech during video(or audio) call? I want to get text of participant's speech during video call and analyze it with TextAnalyticsClient from Azure.AI.TextAnalytics SDK. Is it possible? Thank you.
Environment
Windows 10 OS Build 17763.2565
Microsoft.NETCore.UniversalWindowsPlatform version 6.2.13
Microsoft Visual Studio Community 2022 (64-bit) Version 17.0.4

I've already got answer here: https://docs.microsoft.com/en-us/answers/questions/738122/azure-communication-service-does-net-sdk-have-any.html Thank you!


Thai

Add Thai support.

Fixed with #79.

Unfortunately, Aksharamukha does not provide ALA-LC compatibility. there are two options:

Adapt Plangsarn (if we have access to the source code to reverse-engineer)
Start from scratch under catalogers' supervision.


Change TF_BUILD_BUILDNUMBER to BUILD_BUILDNUMBER

Microbuild V2 no longer uses TF_BUILD_BUILDNUMBER but passes simply
BUILD_BUILDNUMBER. Update MIEngines vesrion settings to account for this.

Without this, the minor version number was not getting included in the clrdbg nuget package.

@pieandcakes

Left you a comment but beyond that, LGTM


Update CLI flags docs

Describe the PR
--generatedTime was documented as true by default, although immediately
after we stated that it was false by default.
Also capitalized the --exclude docs, and updated README.md's output for
consistency.
Relation issue
None, this is just a cosmetical fix.
P.D.: great tool!

@colega Thanks for your contributions.


Lab 3: One minor addition

Module: 00
Lab/Demo: 03
Exercise 4
Task: 01
Step: 04
Description of issue
Might be good to add that one still needs to select the server before able to click OK.  i.e add select SEA-SVR2 to the end:
like so:
On SEA-SVR2, switch to the Failover Cluster Manager console, right-click or access the context menu for FSCluster, select Move, select Select Node, select SEA-SVR2, and then select OK.

Good clarification. Will look to update this in the next week. Thanks for the feedback.

Lab 3, ex. 4, task 1, included suggested addition.


CVE-2022-41723 - golang.org/x/net need update to 0.7.0 or above

A vulnerability reported on golang.org/x/net version 0.4.0 which is used in cru-tool version 1.26.0, more details in https://github.com/advisories/GHSA-vvpx-j8f3-3w6h
While golang.org/x/net was already updated to 0.8.0 in source change was not yet released.
Can you please create new release including this change or share ETA for next release timeline?
Guy

We can cut a new release if the other maintainers are happy with that. WDYT @kubernetes-sigs/cri-tools-maintainers ?

Dear @saschagrunert, @kubernetes-sigs/cri-tools-maintainers, is there a way to speed up creating new release? Please!

@saschagrunert   , great initiate team. @saschagrunert  please add in the release notes that v1.26.1 fixes this CVE
as we it wasn't present we thought its not being supported

@tshaiman done :)


   I'm going with both.

:crystal_ball: :crystal_ball: :smile_cat:

Seems fixed to me?


Cleanup build script related to Crowdin integration

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
This is a subtask of #17972.
Solution
No response
Alternatives
No response
Anything else?
cc @urfreespace would you help with this task?
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Closed by:

https://github.com/apache/pulsar-site/pull/250
https://github.com/apache/pulsar-site/pull/243


whois: 5.3.1 -> 5.3.2

whois (5.3.2) unstable; urgency=medium

Added the .ge TLD server.
Updated the charset for whois.nic.cl. (Closes: #900047)
Updated the list of new gTLDs.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Oops! Hahaha, one second! :)

(accidentally included some debugging "changes" haha, pushed without them :))

Success on x86_64-darwin (full log)
Attempted: whois
Partial log (click to expand)
install -d /nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2/share/man/man5/
install -m 0755 whois /nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2/bin/
install -m 0644 whois.1 /nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2/share/man/man1/
install -m 0644 whois.conf.5 /nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2/share/man/man5/
post-installation fixup
gzipping man pages under /nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2/bin
patching script interpreter paths in /nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2
/nix/store/jklqafj9nrd4pb2lygiwlnl1q1c2pn2p-whois-5.3.2

Success on x86_64-linux (full log)
Attempted: whois
Partial log (click to expand)
install -m 0644 whois.conf.5 /nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2/share/man/man5/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2
shrinking /nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2/bin/whois
gzipping man pages under /nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2/bin
patching script interpreter paths in /nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2
checking for references to /build in /nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2...
/nix/store/n4rfjwq2plgqdwv7znfyb92hp7v3b7v7-whois-5.3.2

Success on aarch64-linux (full log)
Attempted: whois
Partial log (click to expand)
install -m 0644 whois.conf.5 /nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2/share/man/man5/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2
shrinking /nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2/bin/whois
gzipping man pages under /nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2/bin
patching script interpreter paths in /nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2
checking for references to /build in /nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2...
/nix/store/l313w7ms51ms0yydxsfmvpfdbc7lxlil-whois-5.3.2


OutputVariables not present in next phase

VSTS, hosted linux agent.
Attempting to use Output Variables feature. I understand its in preview, was wondering if the lack of persistence through phases is current state (documentation unclear).
What's not working?
AgentPhase1,Task 1:
Write-Host "##vso[task.setvariable variable=foo;isSecret=false;isOutput=true;]bar"
Manually set the output variables reference name to test1
AgentPhase1,Task 2:
echo $TEST1_FOO = Returns expected "bar"
AgentPhase2,Task 1:
New phase, not seeing the variable (either by running set or echo $TEST1_FOO)
Expectation:
Output variables pass between tasks AND phases, i.e.:
PHASE1_TASK1_FOO=bar

It works in yaml (and therefore the agent): https://github.com/Microsoft/vsts-agent/blob/master/docs/preview/yamlgettingstarted-phases.md#output-variables
There's an experience missing in the designer (phase level variables).

I'm following up on the designer.  A developer community issue might be better for the service side designer issue.  Will update

Followed up with designer team - it's on the backlog but at least a couple sprints out.  use yaml


Stacked sorts on Input.table()

Having the ability to stack sorts on an Input.table(dates,{sort:'date',sort:'month'}) would be useful.
Dates is an unordered list.
For example.  I could sort by date and then month  to get put my data into chronological order.
It's like clicking on the dates column and then the months column.

I thought that issue 114  was similar but it would not give the same results as a cascading sort.

The syntax would have to be slightly different—maybe with:

an array: sort: ["date", "month"]
a comparator: sort:(a, b) => d3.ascending(a.date, b.date) || d3.ascending(a.month, b.month)
or an accessor: sort: (d) => ${d.month}-${d.date}`

It'd be nice if custom per-column sorting functions could be supported, which would also be available to user interaction (clicking column headings). Something like this:
const PRIORITIES = ['low', 'medium', 'high']

Inputs.table(data, {
    // ...
    sort: [
        // needs to be an array not an obj at top level because ordering is important
        // (i.e. if result of first comparator is non-zero, other comparators aren't evaluated)
        { column: 'priority', direction: 'desc' },
        { column: 'date', direction: 'asc' },
    ],
    comparators: {
        title: new Intl.Collator('en-US').compare,
        date: (a, b) => d3.ascending(a.date, b.date),
        priority: (a, b) => PRIORITIES.indexOf(a.priority) - PRIORITIES.indexOf(b.priority),
    },
})

In this example, the default sorting would be by priority (from high to low), and within the same priority, by date (from earlier to later). Clicking on the title, date, or priority headings would sort by that heading, alternating between 'asc' and 'desc' orderings. It'd also be nice to have a user action for "reset to default sort order", or better yet, allowing users to combine sort orders themselves (but the latter option would be kinda complex to implement, so maybe out of scope).


Proof of Concept: make a custom function available in a form-js form

The Camunda Assistant GPT suggested that one can create a custom function in JS, that is made available to the FEEL engine within a form-js form.
I'd like to test this out with a toSentence function that would replace the complex/ugly code we currently have to transform the benefit names and eligibility checks from camel case to a more readable format. (used in the "Results" section of the form)

With some more research, it looks like the only way to do this that would make the custom function usable when building/previewing the form is to fork the form-js repo.
I will take another look at the docs to see if I missed anything, otherwise I don’t know if the complexity is worth the time right now.

Letting this go for the moment, since having a toSentence function available in the form is the only compelling use case at the moment, and we already have a working (if clunky) solution for that.


How to add a simple page to the theme?

Not exactly an issue, but can someone please help on how to add a simple page to the theme which includes top navigation and footer, for example a simple content page for Privacy Policy?
Adding a "default" type of page does not include the top navigation, content is not aligned as themes layout.
TIA

I am trying to find out exactly the same. Would be really nice if someone can help here...


Source control stuck at "Scanning workspace for git repositories..."

Type: Bug

Dev Containers: Clone Repository in Container Volume...
Add Dev Contailer Configuration Files: From 'docker-compose.yml'
Select 0 additional features
Open Source Control

Observed with 1.77
Observed with Insiders
Not seen after downgrading to 1.76

Found https://github.com/microsoft/vscode/issues/173429 but not a good fit becuase remote SSH is not involved here.
User had the same issue here and gave me the hint to downgrade https://www.reddit.com/r/VisualStudioCode/comments/12bc0l5/dev_container_and_git_repository/

VS Code version: Code 1.77.3 (Universal) (704ed70d4fd1c6bd6342c436f1ede30d1cff4710, 2023-04-12T09:19:37.325Z)
OS version: Darwin x64 22.4.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
5, 4, 4

Memory (System)
64.00GB (1.55GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (35)

Extension
Author (truncated)
Version

vscode-junos
cod
0.3.0

gitlens
eam
13.5.0

copilot
Git
1.82.15

copilot-labs
Git
0.12.791

vscode-pull-request-github
Git
0.62.0

gitlab-workflow
Git
3.61.0

pinescript
Jey
3.0.1

vscode-docker
ms-
1.24.0

black-formatter
ms-
2023.2.0

isort
ms-
2022.8.0

python
ms-
2023.6.0

vscode-pylance
ms-
2023.4.20

jupyter
ms-
2023.3.1201040234

jupyter-keymap
ms-
1.1.0

jupyter-renderers
ms-
1.0.15

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

remote-containers
ms-
0.288.1

remote-ssh
ms-
0.100.0

remote-ssh-edit
ms-
0.84.0

vscode-remote-extensionpack
ms-
0.24.0

live-server
ms-
0.4.7

remote-explorer
ms-
0.4.0

remote-server
ms-
1.0.0

autodocstring
njp
0.6.1

iosxr
phi
1.0.3

vscode-thunder-client
ran
2.6.2

ansible
red
1.2.44

vscode-commons
red
0.0.6

vscode-yaml
red
1.12.2

jinjahtml
sam
0.20.0

vscode-multiclip
sle
0.1.5

vscode-djaneiro
the
1.4.2

jinja
who
0.0.8

markdown-all-in-one
yzh
3.5.1

I recently ran into the same problem and it has been resolved.
Do you have AWStoolkit installed? In my case, this extension was conflicting.

Thanks for the tip.  I can't think why it would be related to an extension, since moving between VS Code versions triggered the issue with no changes to extensions having been made.
I'll experiment with extensions and see what happens.

I have this issue still - I have created a minimal reproducible test case for you:
https://github.com/jonsage/vscode-git-scanning-bug
So here, if you create a GitHub Codespace from this repo you will find that you get the "Scanning workspace for git repositories..." issues whether you open it in the browser of through VS Code Desktop.

@jonsage, thanks for the repo. I am able to reproduce, and will share my findings later this week.

Since this is a dupe and the other bug is closed and verified, I'll mark this as verified. @jlixfeld it would be helpful if you can verify that it is fixed for you in the latest Insiders build of VS Code


losses and results

Hi, this is a interesting work for depth estimation, i have some problems in your project:

losses from final prediction, why do not add a loss for initial prediction in your training instead of only final supervision, and have you tried it in trianing?
i have tried the released model for kitti dataset, but i got the wrong results that RMSE & MAE > 10000(mm), my env is python=3.6 torch=1.6 torchvision=0.7 on ubuntu 16.04, thanks

I tried supervision on the initial depth but I thought it was too strong so refinement from the propagation was not good enough.

Are you using the same arguments for testing?

python main.py --dir_data PATH_TO_KITTI_DC --data_name KITTIDC --split_json ../data_json/kitti_dc.json
--patch_height 240 --patch_width 1216 --gpus 0,1,2,3 --max_depth 90.0 --num_sample 0
--test_only --pretrain ../results/NLSPN_KITTI_DC.pt --preserve_input --save NAME_TO_SAVE --legacy
You might miss some arguments such as --num_sample 0 or --legacy

Thanks for your reply, the initial prediction brings more uncertainty if without supervision. If different weights for initial and final predictions are tried by you? For testing, I ignored the legency param and tested on the single GPU.

I haven't tried weighting between the initial and the final predictions.
For the pretrained models, --legacy flag is essential. Please try with that option.

Thanks, i will try it


multiple definition of `ProcEntryArray' and prev_post_parse_analyze_hook

PostgreSQLv14 source code compiled and install with GCCv11.1.
Installed Path:/usr/local/postgres_14/gcc/bin(pg_config)
OS:RHEL8.4
Steps are followed:
export PATH=/usr/local/gcc-11/bin:/usr/local/postgres_14/gcc/bin:$PATH
export LD_LIBRARY_PATH=/usr/local/gcc-11/lib:/usr/local/gcc-11/lib64:$LD_LIBRARY_PATH
git clone https://github.com/pgsentinel/pgsentinel.git
$ cd pgsentinel/src
$ make
-Wl,--as-needed -Wl,-rpath,'/usr/local/postgres_14/gcc/lib',--enable-new-dtags -lm
get_parsedinfo.o:(.bss+0x8): multiple definition of prev_post_parse_analyze_hook' pgsentinel.o:(.bss+0x8): first defined here get_parsedinfo.o:(.bss+0x0): multiple definition of ProcEntryArray'
pgsentinel.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
make: *** [/usr/local/postgres_14/gcc/lib/pgxs/src/makefiles/../../src/Makefile.shlib:293: pgsentinel.so] Error 1

can you give it a try, adding
PG_CFLAGS=-fcommon

in the extension Makefile? (before PG_CONFIG = pg_config)
Thanks
Bertrand

recent gcc versions have  default to -fno-common producing the errors mentioned in this issue.
Temporary workaround can be to set
PG_CFLAGS=-fcommon

in the extension Makefile.
In the same time, I'm doing minor code changes to avoid such errors even with fno-common.
Thanks
Bertrand

Fixed in https://github.com/pgsentinel/pgsentinel/commit/eb7125265cd7dbc32150dd78648bbfcfd40660bf
Thanks
Bertrand

Thanks for the optimazation, I meet the same problem.


throws error when trying to send multiple transactions

I get the following error when I try to send multiple transactions:
Error: "transaction submit error ShelleyTxValidationError ShelleyBasedEraBabbage (ApplyTxError [UtxowFailure (UtxoFailure (FromAlonzoUtxoFail (ValueNotConservedUTxO (Value<PHONE_NUMBER> (fromList [])) (Value<PHONE_NUMBER> (fromList []))))),UtxowFailure (UtxoFailure (FromAlonzoUtxoFail (BadInputsUTxO (fromList [TxIn (TxId {_unTxId = SafeHash \"5259ff6a04ca3226173g7fcdbfcd7a2e34b82f7857d72096b3cd9e25d95021f7\"}) (TxIx 1)]))))])"
    at Blockfrost.submitTx (file:///node_modules/lucid-cardano/esm/src/provider/blockfrost.js:177:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Object.submitTx (file:///node_modules/lucid-cardano/esm/src/lucid/lucid.js:371:24)
    at async TxSigned.submit (file:///node_modules/lucid-cardano/esm/src/lucid/tx_signed.js:21:16)

Also, can someone guide me on how to use Kupmios, because blockfrost is giving too many errors?

Hey, you usually have to wait until one transaction is confirmed on the blockchain before submitting another one. You can only send multiple transactions in a row when one transactions doesn't depend on another, or in other words all txs use unique utxos and don't reuse the ones from another tx.

Is there a way to know or wait until the previous transaction is confirmed?

Yes, after submitting a tx you get back the tx hash. You could the following:
const tx = await lucid.newTx()
//....

const txHash = await tx.submit();

await lucid.awaitTx(txHash);

//... submit another tx

Thanks a lot, I will try that.


Cleaning up the codebase from unused methods

Hello,
Just thought it would be nice to remove some unused methods, there's more but I tried to focus only on the helper methods that seem to not be used anywhere.
Thanks
Trello for cross reference: https://trello.com/c/C89RwZ19/348-cleaning-up-unused-methods-on-whitehall

Staging and Integration. Staging only receives public traffic, no admin traffic. Some admins use integration occasionally to test things.

Talking about this offline. I'm a little worried because it's so easy for one of these methods to be called by send("thing_you" + "thought_wasnt_called"). We'd have to go through each method to verify that it really isn't called, preferably by location the commit where the last callsite was removed.

It also might be useful to share the code that identified those methods: https://gist.github.com/Davidslv/64c3e300fc9e6e2e95e38128d8445d9b

Putting this back in planning for now - see https://trello.com/c/C89RwZ19


Update fabric_relation to instance method

closes https://github.com/microsoft/dbt-fabric/issues/222

Microsoft github policies does not allow integration tests with forked repositories. I am pulling in this change in v.1.8.8


Standard conflicts with SQL

Hey @Cameron-Van-Eck,
I've just found out (thanks to @jd-au), that the current standard conflicts with VOTable compliance because of the columns catalog and interval.  These are reserved words in SQL. I'd suggest we change them to: catalog_name and obs_interval.

Thanks for pointing this out. I've made this change (commit 50cd570) and updated the paper (and mentioned in my reply-to-referee).


Unable to resolve type SplitButton from namespace https://github.com/avaloniaui

Describe the bug
When I am tring to add a split button to my program, it hints me that "Unable to resolve type SplitButton from namespace https://github.com/avaloniaui". As I've tried to use DataGrid and met the same problem, I try to add NuGet package Avalonia.Control.SplitButton, but there is no such a package.
To Reproduce

Open Visual Studio 2022.
Create an Avalonia MVVM Program.
Use <SplitButton> Control.
See error.

Environment
Windows 11 + Visual Studio 2022 + AvaloniaUI 0.10.18

It's not available in 0.10.18.
This control was added in 11.0-preview versions.

Allright, maybe this should be written in document.


How is max_line_length enforced / used?

Hi,
I'm trying to understand how max_line_length is used within Atom using your plugin.  Typically in Eclipse if I have a maximum line length set I have to select the area and hit crtl + shift + f it will reformat the code to set the proper maximum line length.  How is this achieved in Atom using this package?
Thank you
editorconfig code:
max_line_length = 160

Atom 1.23.3 + editorconfig 2.2.2:
Indeed, guides display at 80 chars when .editorconfig max_line_length is 120

Same with Atom 1.24.0 and editorconfig 2.2.2

Same with Atom 1.27.1 (and editorconfig 2.2.2).

Closing as Atom is abandoned.


Added ppc64le supported hashicorp-vault image

Description
Added ppc64le supported hashicorp-vault image
Enable test execution for power arch

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[ ] I checked that each commit in the pull request has a meaningful subject line and body.

[ ] I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

Reference: https://issues.apache.org/jira/browse/CAMEL-19482


Update and rename README.md to README.rst

:+1: lgtm, just a rename and formatting

actually if there are any actually changes in the first commit (besides a rename), then I prematurely approved, and this is difficult to review

comparing rendered pages https://github.com/caskdata/netty-http/blob/8c577336f6a528565530644cdc9a5395c6e39df9/README.md and https://github.com/caskdata/netty-http/blob/awholegunch-patch-1/README.rst

as @awholegunch pointed out, missing copyright statement in the license.  Otherwise, :+1: LGTM


wasmtime.Trap is difficult to inspect

Currently, unless I'm mistaken, we'll have to check the wasmtime.Trap's Message() to figure out what happened.
While there could be user-defined traps, there seem to be a bunch of pre-defined ones in wasmtime:
https://github.com/bytecodealliance/wasmtime/blob/bde955579336e124b2c01b3164314bf2d6eec378/cranelift/codegen/src/ir/trapcode.rs#L8-L54
It would be nice if these were exposed to Go, allowing for use with errors.Is() or errors.As(), instead of inspecting the message string.

Under the hood a trap is a Trap in Rust, which does indeed have a TrapCode to inspect. Currently the C API, however, does not expose any accessors on traps other than the message itself. It should be fine to add those to wasmtime itself though! We already have one custom accessor and it shouldn't be too hard to add more.

I've dug in a bit today, and, please correct me if I'm wrong, we'd have to

define enums (integer constants) for the trap code rust enum in c-api

translate them in the c-api crate, via a function along the lines of
WASM_API_EXTERN bool wasmtime_trap_code(const wasm_trap_t*, int *code);

For (1.), we'd just use the most obvious mapping..? (It should be OK, since one cannot feed an int into the c-api that wouldn't correspond to any defined enum, I think...that's referring to a common issue with rust enums vs C enums I've stumbled upon)

Indeed yeah that should do it! Since we have to define the mapping in the header file I think we'll probably just want to write down a mapping in the header file which we mirror into the c-api implementation which matches on the Rust enum and produces the right C value.


AKCORE-61: Added more Integration tests for shareFetchRequest

This PR contains multiple Integration tests to test different edge cases for shareFetchRequest
Reference : AKCORE-61

Merging to continue working on multi-consumer tests.


Use existing properties to set the max memory, don't add them to the resources

Instead of defining a new memory_Mb in the resources (very specific to this scheduler), we should reuse concepts already into AiiDA and independent of the scheduler.
E.g. we have metadata.options.max_memory_kb in CalcJobs:
https://github.com/aiidateam/aiida-core/blob/ff1318b485a8b803e115b78946cc4593fc661153/aiida/engine/processes/calcjobs/calcjob.py#L249
and this is passed to the scheduler in the JobTemplate:
https://github.com/aiidateam/aiida-core/blob/ff1318b485a8b803e115b78946cc4593fc661153/aiida/schedulers/datastructures.py#L284
See e.g. how it's used in SLURM:
https://github.com/aiidateam/aiida-core/blob/develop/aiida/schedulers/plugins/slurm.py#L383-L396

Just as a note that we just merged https://github.com/aiidateam/aiida-core/pull/5260 which adds the property default_memory_per_machine, which allows to define the default memory (in kB) to use for a particular Computer. We explicitly chose for kB (instead of MB) to be consistent with the already existing max_memory_kb option.


Solved Issue #8

This Pull Request resolves Issue #8
Description:
Created folder with github username
Added xor.c
unrolled.c
circular.c

Issue #8 and #4 are added in proper folders

Please reference all the Issues as well in the PR Description!


[Feature request] An extension that makes #try return a monad

It would be really nice if Foo.try({..}) returned a Dry::Monads::Try or Result.

@jamiehodge I moved it to dry-types, it should be done here. It's quite easy to implement in a way similar to dry-schema: https://github.com/dry-rb/dry-schema/blob/951488facaf6cc27b8a24887ef416e601b714671/lib/dry/schema/extensions.rb#L3-L5 Feel free to take a stab or this will wait another chance.


OkHttpClient.proxy() is nullable.

Also, add a couple other internal nullability cleanups.

General travis CI failure - https://github.com/travis-ci/travis-ci/issues/9891


Any typing for this sequelize-typescript :)

I'm trying to find the @types/sequelize-typescript to not have a compiler error (it still run lol but it's annoying), is it avaible somewhere or it need to be created?
Thanks a lot!

@Tower450 first of all sequelize-typescript is not a framework. And it does have typings.

Thanks i know it's not a framework sorry for the word i used, can you share it to me i'm not able to find it

@Tower450 this lib is already written in typescript, hmm how comes u don’t have typings?

My VScode is showing me module not found but it does compile lol

it worked nevermind sorry thanks for your help

Hey @Tower450, what need to be done to get it working with vscode? :)
I didn‘t get the “you should put the npm install with @types...” - can you explain it again for me? :)

Sure, when you want to use a typescript library and you install it with npm or yarn whatever, you need to install the library in the @types folder , but when you do npm install --save sequelize-typescript, it saves the folder in the root of node_modules instead of  @types folder so typescript compiler says that he do not find the module even if he actually finds it in some way at the execution.

So the sequelize-typescript module folder is now located under node_modules/@types/sequelize-typescript? This is strange and shouldn't be necessary. I'm using JetBrains WebStorm, where it is working perfectly fine. Which typescript version are you using? I will try to reproduce it with vscode

It's not typescript the problem, pretty sure it's the TSlint or VScode but stillz would be perfect to fixes this, would be cleaner. And yes i copied paste the folder into @types and it fixed my problem.

@Tower450 In VSCode, with the way we structure our types, installing sequelize-typescript and @types/sequelize will work. I'd be interested in your tsconfig.json and the specific compile errors, as I haven't run into that error.
This is a snippet from my package.json
{
  "dependencies": {
    ...
    "sequelize": "4.8.4",
    "sequelize-typescript": "0.5.0",
    "@types/sequelize": "4.0.59",
    "typescript": "2.5.2"
    ....
  }
}

VSCode v1.17.2
Node 8.5.0
NPM 5.4.2

ummm. @types/sequelize is in devDependencies it's the only difference

Welp - if you think it's a problem with TSlint or VScode you could submit an issue on their repos.
This package doesn't need to do anything - and other modules like ava and angular, also don't need to be installed under @types to get intellisense or compilation to work properly in VSCode.

alright thanks for the info guys i appreciate! :) anyway i found a solution

Guys you really need to put the definition in @types  change your READM.me with
npm install --save-dev @types/sequelize-typescript

Here is a screenshot of what it's doing with all your configuration.
I hope it can help, i showed the error to a senior and he did not understand like you guys but i'm pretty i am on a defect in some way. But i do agree that everything on your side seems to be good.

@Tower450 I’m using sequelize typescript in one of my projects. This lib already provides type definition files so we don’t need to publish it to @types. U better check your tsconfig.json file or something else.

@Tower450 can you provide an example repo, which reproduces the issue?

tsc -v 2.4.2 and the only solution is to copy the repository into
node_modules\@types

By the way, here is my tsconfig.json
{
  "compilerOptions": {
    "strictNullChecks": true,
    "rootDir": "./src",
    "lib": ["es2017"],
    "target": "es6",
    "outDir": "dist",
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true
  },
  "exclude":[
    "node_modules",
    "src/__test__"
  ]
}

@Tower450 Can you prepare a github repository for me? :) That would make it much easier for me

@Tower450 Either a small/minimal github repo (ideal) or a gist with package.json, tsconfig.json and a single typescript file that has that error you are seeing in VSCode would be helpful. None of our team has this issue, we just npm install sequelize-typescript @types/sequelize and it works (typescript can find all type definitions). In your screenshot it looks like you haven't configured tsconfig.json properly.

there is my configuration
https://github.com/team-chiru/sidemark-back/tree/dev

Try setting moduleTesolution -> node and module -> commonjs
{
  "compilerOptions": {
    "moduleResolution": "node",
    "target": "es6",
    "module": "commonjs"
  },
  "exclude": [ "node_modules" ]
}

alright thanks :)


circuit builds

We need to enable circuit ci on this repo - I would, but I'm not the repo owner.
@diasdavid @VictorBjelkholm

Done


added tooltips on create campaign page

@Vallsurf you think this is good to go? Would love to close it out

This branch needs a rebase onto master, but I can't push it up to this PR without authorization from Val. One option would be to create a new PR and merge that @kbertash

@Reltre @nowfred @kbertash -- can we get a plan and merge this?
@Vallsurf -- see Tyler's comment in case you want to do the rebase.

Gonna put a hold on this right now since usability testing revealed that we don't need tooltips, everyone was able to figure out what to do without them. Definitely a win from a UX perspective!


Scene2d label wrapping incorrectly

When using label wrapping, for some texts, the wrapping isn't performed correctly.

As you can see in the screenshot above, "water." text fits the line. In fact, if you add a blank space to the end (or an extra dot), it draws in a single line.
Code to reproduce:
public class LabelWrappingBug extends ApplicationAdapter {

	private BitmapFont bitmapFont;
	private Stage stage;

	@Override
	public void create () {
		stage = new Stage(new ScreenViewport());
		bitmapFont = new BitmapFont(Gdx.files.internal("ringbearer.fnt"));

		LabelStyle style = new LabelStyle(bitmapFont, Color.WHITE);
		Label label = new Label("It is filled with water.", style);
		label.setWrap(true);
		label.setAlignment(Align.center);

		Table table = new Table();
		table.add(label).prefWidth(600);

		table.setFillParent(true);

		table.debug();

		stage.addActor(table);
	}

	@Override
	public void render () {
		Gdx.gl.glClearColor(0, 0, 0, 1);
		Gdx.gl.glClear(GL20.GL_COLOR_BUFFER_BIT);

		stage.act();
		stage.draw();
	}

	@Override
	public void dispose () {
		stage.dispose();
		bitmapFont.dispose();
	}
}

Font files:
ringbearer.zip
The LibGDX version I'm using is 1.9.10. I'm testing on Desktop, using Ubuntu 18.04 LTS. Java version is 1.8.0_201.
I believe the issue is explained here: https://stackoverflow.com/questions/43618643/libgdx-label-text-wrap-bug
It has something to do with second call to layout.setText in Label class, probably a rounding issue.
I suspect this is also causing the labels padding to be calculated wrong sometimes. For example (text is cut of on the right):

Let me know if you need more information and if I can help somehow! Kind regards, Lucas.

Label does layout twice: first to determine the wrapped width, then again using that width. Maybe this could be avoided, I don't remember why it the first one isn't sufficient. It sure does a good job finding bugs though.
For the first layout, this check:
https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/graphics/g2d/GlyphLayout.java#L180
The glyph r (in "water") has a glyphWidth of 26 and the xAdvance is 17. x is 347, so + 17 = 364. The period after r is narrow at 7 wide, so 364 + 7 = 371, which is the GlyphLayout width.
The second layout should fit within 371, but 347 + the 26 width of r = 373. The r is so large it extends past the period, something like this, where the red line is the xAdvance:

This is a discrepancy between the GlyphLayout width and the width which will fit the text without wrapping. Wrapping wants to fit the whole glyph. The bounds are tightly fitting using only the last glyph. I suppose the bounds should use the max of any glyph, which would fix this.
This isn't a rounding problem. If that is an issue maybe we can ceil somewhere, but it hasn't been reported as reproducible.

Thanks Nathan for looking into this. I appreciate your time!

Sorry, the fix is not good. The wrapping code modifies the run, so the max width that was stored before that is too large.

Just in case anyone else runs into this: I experienced broken text rendering after bumping libgdx from 1.9.10 to 1.9.11 (this issue I presume?) I was rendering a TypingLabel inside a ScrollPane, and letters were cut off at the end instead of the word being wrapped into a new line. It also looked like table padding was not taken into account, since text would spill over the padding.
I found that updating to 1.9.12 fixes this problem again, presumably due to this fix:

Fixed GlyphLayout not laying out correctly with color markup.

But I'm not sure. I just wanted to mention it because I lost over an hour staring at my own code trying to figure out what I broke when it came to me that I might have pulled in the problem via the version bump that I clearly did not test well enough :-)
Anyway, thanks for putting a fix together so quickly! Appreciate it.


Unicode - Ascii printing dispatch

Please don't merge this yet, I'm sending this mainly because I'd like some feedback on the API and whatnot. So as it stands, this succesfully dispatches &str and String to the Unicode, and &[u8] to the ASCII printing functions.
Problems

The type-by-type implementation is tedious, but I haven't found a way to make a nice blanket implementation. Since there are no negative trait bounds I don't see a simple way around this problem. If anyone has any ideas, feel free to post them.
Is there a more efficient way to convert a &str to a *const i32? The current method works, but allocating a new Vec for each string seems like a bit of an overkill. (Also do we have to explicitly push a \0 at the end of these Vecs?).
I can't figure out a way to simply accept a byte literal in the print functions: I have to add an as &[u8] for it to work.
There are two possible API designs:

Take the text we want to print by value: this makes it nicer to directly print &str values (no need for an explicit &), but will move String values. Note that this is equivalent to the current implementation, since we didn't support passing Strings earlier. The only problem is that you cannot simple do an as_ref on the String, since it has both AsRef<str> and AsRef<[u8]> implemented, leading to an ambigous call... On this note, I really wish Rust would differentiate between the &str and &[u8] representations.
Take it by reference: this makes it more annoying to print &str (and so string literals), since you have to explicitly add a & to every one of them, but has the advantage of not moving String values.

Alternatives:

We could just drop the whole UTF thing, assert on AsciiExt::is_ascii() and keep doing things as they are now. If I understand correctly this is pretty much what the Python bindings do (the libtcod docs say that UTF is not supported with them).

We could dispatch at runtime based on is_ascii, so we only do the &[u8] to UTF conversion when it's absolutely needed. This is probably the most flexible solution, but loses out in raw performance with ASCII strings. The thing is that the implementation in this PR heavily favors the use of UTF strings, which will have worse performance (due to the string-by-string Vec allocations).

Have libtcod style _utf functions. I don't really like this option. It doesn't make for a very user-friendly API: we have these explicit functions when we could've dispatched them either at runtime or compile time. The only advantage is being able to use &str in both functions (not possible with this PR, possible with Alt #2).

Opinion
After giving it some thought, I actually think that Alternative #2 is probably the best option here. It makes it easy to use the interface correctly. The printing of ASCII strings is probably the most common use-case, so making it easy should be a top priority. With the runtime dispatch we add a single if overhead, but retain correctness (in the UTF case we would've had to do the conversions anyway). This PR was actually pretty fun to experiment with (and provided some great experience for my hobby project!), but it's being too tricky for a library API in my opinion. If there's a decision I'd be happy to implement whatever it ends up being.
cc @P1start since they seemed to be interested in the whole conversion.

Thanks for looking into this alternative, too.
I think I'm leaning towards the second alternative as well. If the runtime cost gets too high, we can re-evaluate. Plus the users can always use the FFI functions (though I don't want to have that as an answer for every difficult problem :-) ).
Just checking: the reason why he have to do the Vec -> *i32 dance is because Rust's strings are UTF-8 but libtcod's aren't?
If we do go with the alternative 2. we should be able to keep the same interface, right?

The Vec -> i32 dance is necessary, because Rust stores Unicode characters as an array of [u8]s, but libtcod expects wchar_t (which is just wrong... it should be uint32_t).
And yes, we can keep the same interface with Alt #2.

Cool. Let's go with alternative #2 then. You wanna look into it? I can do it but it'll be a few days before I have the time.

Closing in favor of #163


czinspect: Remove ld-based hack for help text

This has come back to bite us. Switch to using xxd for generating help text in czinspect. This should fix the macOS build in #1. This adds xxd as a build-time dependency, which is part of vim.

The clang 5.0 CI build failed, however there is a commit in #17 which removes the failing job. I'll review #17 so we can get it merged, then re-test this branch.


Add pt-br translation of password-generator

Hello, following the issue https://github.com/laisfrigerio/app-ideas/issues/10
Added folder 2-Intermediate folder (i saw that other issue alse created this folder, but i made my branch from main, i hope that there's no conflict on merging)
Translated the Password-generator

Hey, @leticiavargas
First of all, thank you so much for you time and collaboration!!!
A collaborator chose the same exercise to translate. So a recommend you to create a new branch and translate a new exercise, ok?


test creating sized snapshots for filesystem and block volumes

Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
Exercises the snapSize behaviour of volume snapshot class.
What this PR does?:
Tests creating sized snapshots for filesystem and raw block volumes.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

This PR is based on top of branch used for PR 308 and hence we see that commit here as well. That commit doesn't need review against this PR.


Issue using jdm-editor react component in another project

please find the snippet
import { DecisionGraph, JdmConfigProvider } from '@gorules/jdm-editor';
import<EMAIL_ADDRESS>function App() {
  return (
    <div className="App">
      <JdmConfigProvider>
        <DecisionGraph
          onChange={(val) => setGraph(val)}
        />
      </JdmConfigProvider>

    </div>
  );
}

export default App;

Error
Failed to compile.
[eslint]
src/App.js
Line 11:30:  'setGraph' is not defined  no-undef
Search for the keywords to learn more about each error.
ERROR in [eslint]
src/App.js
Line 11:30:  'setGraph' is not defined  no-undef
Search for the keywords to learn more about each error.
webpack compiled with 1 error

Hi, this looks like and issue on your side with linter when using components - you will need to set a state you are missing const [graph, setGraph] = useState()