Chrome Memory Crash?!

So, i was making an Undertale Battle sprite, good, good. And RIGHT when i was going to save... BAM!!!  I was like,"Its cool, its cool." Until...  I was left staring at a blank canvas of what all of my hard work was... Just vanished... Like that...  JUST... BAM! GONE. Please... Please fix this... And if there is a way to recover my work, i will do all that i can to get that picture back... Please... Please please please... I am freaking desperately searching for anyone else who had this problem and nothing. Please... Fix this. And if there is a way, please help me recover my work!...

I am really sorry about that :(
Unfortunately, if you didn't save your progress at any point I don't have any way to restore your sprite.
There is a one-shot recovery tool in the import panel:

But if you already made a new sprite with the application this won't work, as it only allows to restore the last edit.
If you could I'd appreciate having the specs of the sprite you were editing:

resolution
number of frames
number of layers
... as well as the approximate duration of your session.

I think the issue is probably linked to the way I keep the history of edits to allow undo/redo. Everything is stored in memory, so as you edit the same sprite without reloading the page it can get too big and crash the browser.
In the short term I think we could limit the number of stored history states. This number should depend on the specs of the sprite, because we obviously can store a lot more steps for small sprites than for bug sprites.

Sorry again about this issue, but I will close this ticket in favor of #374 where I will implement some of the fixes I mentioned here.


[Question] How to use useEvent for any target?

How can I use useEvent for any target when the target wasn't initialed yet? For example:
const inputRef = useRef(null)

useEvent('someevent', () => {...}, inputRef.current) // inputRef.current is null now

return (
    <input ref={inputRef} />
)

You should use useState instead of useRef.  That will cause your component to re-render when inputRef is set and will re-execute useEvent with a non-null value.

Hi @dakiesse, have you tried to use the options?
const inputRef = useRef(null)
useEvent('someevent', () => {
    ...
}, inputRef.current, { capture: true });

return (
     <input ref={inputRef} />
)


enqueue ONBUILD instructions from multiple ancestors

I'm sorry for the lack of a better name for this feature request.
I want heroku buildpacks to be docker images. That way, Heroku apps could be built with Docker, generating both a valid docker container to run the app, and a valid Heroku slug that could be deployed to Heroku.
While playing with the idea, I found that all buildpacks will have a common set of ONBUILD instructions. Eg.: all buildpacks need to run their bin/compile against the app source code.
Initially I thought that chaining ONBUILD (#4244) in a base image for buildpacks could be a solution to avoid all buildpacks having to C&P a piece of shared Dockerfile:
Using Heroku buildpacks as Docker images to build apps.
Discussions on irc (#docker-dev) made me realize that ONBUILD ONBUILD may not be very flexible. It would only allow buildpack-base -> buildpack -> app hierarchies. Composing buildpack images (a.k.a. buildpack-multi) would not be possible that way (eg.: buildpack-base -> buildpack-ruby -> buildpack-pgbouncer -> app.
Some alternatives that were proposed:

Introspection: allow buildpacks to call docker --introspect --change "ONBUILD RUN ... and similar things during build. That way buildpack images could enqueue their ONBUILD commands and propagate ONBUILD commands from their ancestors.

Chained docker build invocations, as suggested by @proppy. It's not clear to me though how it would enable the use case I originally mentioned (Heroku buildpacks as docker images).

INCLUDE: #735. With it buildpacks could just add the shared set of commands to their Dockerfiles.

Any other ideas? I'm happy to help with code and PRs once we settle on a design.

Guys any update on this? this is extremely needed. In my rails application I use FROM rails:onbuild but I need a middle image to add some stuff, which doesn't yet have the rails app files.

I'd like to resque ONBUILD inheritance, is this possible?

Hello!
We are no longer accepting patches to the Dockerfile syntax as you can read about here: https://github.com/docker/docker/blob/master/ROADMAP.md#22-dockerfile-syntax
Mainly:

Allowing the Builder to be implemented as a separate utility consuming the Engine's API will open the door for many possibilities, such as offering alternate syntaxes or DSL for existing languages without cluttering the Engine's codebase

Then from there, patches/features like this can be re-thought. Hope you can understand.


"keytype not treated"

Using the latest TG app as of today, 1.8.2, MX Linux (Debian derivative).
Built the decryptor with plain downloading go and installing in /usr/local as per the golang.org instructions. "go build" in the directory where main.go is at.
mkdir decrypted
./telegram-desktop-decrypt bulkdecrypt ~/.local/share/TelegramDesktop/tdata/D877F783D5D3EF8C/map0 decrypted/
could not decrypt file '/home/[myname]/.local/share/TelegramDesktop/tdata/D877F783D5D3EF8C/map0': keytype not treated: 154048071
This is all.. greek.. to me. What might this be?

In https://github.com/atilaromero/telegram-desktop-decrypt/blob/d3c9d4a2671f3df3de66de5ccd2b2526f7b10487/tdata/decrypted/map.go#L46 , while the decrypted map0 file is parsed, it reads a 4 bytes that should correspond to a "keytype". The map0 says, for each of the other files in his directory, those with strange names, which filetype it is, using this number. It should be a number between 0x00 and 0x15, but you got 0x92e9647.
Those numbers were extracted from https://github.com/telegramdesktop/tdesktop/blob/fa3117e41ed4862541a94b4df50710490247fe7a/Telegram/SourceFiles/storage/localstorage.cpp#L497 at version 1.5.1, but the list on 1.8.8 seems to be the same.
Maybe something else changed in a new version of telegram desktop, or the decrypted map parsing should be doing something else, or your file may be corrupt. I'm not sure which of these options is happening here.

Have exactly the same problem and my file is not corruted.

Then the map parsing is definitively lacking something.

Hey, I know what is that number, you shouldn't change it to hex format, it's user's telegram number id, now you know this, can you make it work? I reeeeeeeeeeeeally need it, thanks :)

Same here.
Your thing doesn't work

The fix should be the XamarinDeveloper's suggestion, to accept the number as the telegram number ID. But to to that, I (or someone else) will have to revise the parser, which should be expecting this. It will be likely necessary to compare it with an updated version of Telegram Desktop source code, to follow what it does. Unfortunately, I will not have the spare time to do this any time soon. Hopefully someone else could send a push request, who knows!

It is on my todo list, the thing is that it is already too long.


[BUG] Android matter sdk setFabricId does not accept values which touch twos compliment

Reproduction steps
Using an example fabric id: d5f9b903418fda11, I am unable to set the fabric id on the controller params since it only accepts a "signed" Long as a parameter. This fabric id can be parsed as an unsigned Long but when converting to a Long it becomes a negative value and fails the sdk check:
public Builder setFabricId(long fabricId) {
        if (fabricId < 1L) {
            throw new IllegalArgumentException("fabricId must be > 0");
        } else {
            this.fabricId = fabricId;
            return this;
        }
}

Repro steps:

Try to set a valid fabric id with a value greater than 7FFF_FFFF_FFFF_FFFF on the controller parameters.

Bug prevalence
everytime
GitHub hash of the SDK that was being used
8f66f4215bc0708efc8cc73bda80620e67d8955f
Platform
android
Platform Version(s)
No response
Anything else?
No response

I think we should consider to update with Long instead of long.
for example, Long l1 = Long.parseUnsignedLong("d5f9b903418fda11");
I think this issue happens in several place with uint64_t in android controller.
both EventNumber and FabricId needs to be fixed since they are defined with
uint64_t EventNumber;
uint64_t FabricId;

@joonhaengHeo do you have bandwidth to fix this issue?


DevTools failed to load SourceMap: ..://ljjemllljcmogpfapbkkighbhhppjdbg/build/env.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

Version
6.0.0-beta.7
Browser and OS info
89.0.4389.90 64bit  (cohort: 89_Win_72)
Steps to reproduce
just open a vue page served by webpack-dev-server
and then show:
DevTools failed to load SourceMap: Could not load content for chrome-extension://ljjemllljcmogpfapbkkighbhhppjdbg/build/env.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME
What is expected?
No Warning
What is actually happening?
In DevTool Console panel :
DevTools failed to load SourceMap: Could not load content for chrome-extension://ljjemllljcmogpfapbkkighbhhppjdbg/build/env.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

same issue

same issue (but I run Linux Mint, rather than Windows)

Same issue, but on iOS in Chrome and Brave.

I wanted to follow up with more information about this issue. This breaks the whole extension for me with this error:
Uncaught (in promise) TypeError: Cannot set property '__VUE_DEVTOOLS_UID__' of null
    at registerAppJob (backend.js:1437)

Uncaught (in promise) TypeError: Cannot read property 'id' of null
    at getComponentInstance (backend.js:3225)
    at Object.sendComponentTreeData (backend.js:3150)
    at Bridge.<anonymous> (backend.js:754)
    at Bridge.emit (backend.js:3720)
    at Bridge._emit (backend.js:1126)
    at backend.js:1058
    at Array.forEach (<anonymous>)
    at backend.js:1058
    at listener (backend.js:2105)

Found a fix for this. In  developer tools in chrome browser, go to settings(click the gear icon on the same bar as the console tab). Find and uncheck box that says Enable Javascript Sourcemap. exit settings and reload(I did a hard reload/empty cache. The error should be gone.

Found a fix for this. In developer tools in chrome browser, go to settings(click the gear icon on the same bar as the console tab). Find and uncheck box that says Enable Javascript Sourcemap. exit settings and reload(I did a hard reload/empty cache. The error should be gone.

Kudos! Did the trick for me.

Can somebody explain what this error means? I can't tell if it's causing the weird issue I'm having while modifying some code I'm not very familiar with that uses Laravel 8 and Vue (v?).
DevTools failed to load SourceMap: Could not load content for http://localhost:8002/js/vue-resize.esm.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
I'm not familiar with vue-resize.esm.js.map... is that a file in the /js folder that Google likes Chrome to look for to help DevTools understand your code?

is that a file in the /js folder that Google likes Chrome to look for to help DevTools understand your code?

Yes, source maps helps DevTools unpack your minified code. It's just for when you're running in dev. See: MDN: Use a Source Map.
As to why this is breaking Vue DevTools I'm not totally sure.

Found a fix for this. In developer tools in chrome browser, go to settings(click the gear icon on the same bar as the console tab). Find and uncheck box that says Enable Javascript Sourcemap. exit settings and reload(I did a hard reload/empty cache. The error should be gone.

This is a workaround, not a fix, as the likelyhood is that if you are using VueJS DevTools, you are wanting to use sourcemaps, so dont want to untick this option as its a global flag for all sourcemaps.
The actual fix for this is one of two options:

Exclude the sourcemap line from the end of the JS file if sourcemaps are not going to be included in the built code.
Include the sourcemaps in the extension, and the problem also goes away.

P.s. I got this error for the utils.js script instead:
DevTools failed to load source map: Could not load content for chrome-extension://ljjemllljcmogpfapbkkighbhhppjdbg/build/util.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

Since I'm not very familiar with the Vue implementation on the project I referenced, I'm not sure the previous developers even implemented the sourcemap or Vue or whatever properly to begin with. I will be able to determine this better with more review of the code, which I can do when I use the project again, and if I find anything useful there that would be helpful for this thread, I'll post here again. Thanks for the info.

I got this error for the utils.js script instead:

Same issue on macOS (Big Sur 11.5) Chrome (Version 92.0.4515.107 (Official Build) (x86_64)) and Vue.js devtools 6.0.0 beta 15 + ViteJS (2.4.3)

Just started getting this as well

I got this error for the utils.js script instead:

Same issue on macOS (Big Sur 11.5) Chrome (Version 92.0.4515.107 (Official Build) (x86_64)) and Vue.js devtools 6.0.0 beta 15 + ViteJS (2.4.3)

Same issue here on win10

Source maps are not generated for the production build of the devtools extension:

I'm still seeing these warnings ...

DevTools failed to load source map: Could not load content for chrome-extension://ljjemllljcmogpfapbkkighbhhppjdbg/build/fast-copy.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

If source maps are not generated for the production build of the devtools extension, then why does the production version check for source maps? It seems like it guarantees an error.

Was googling for similar issues and found this. As the OP mentioned this is an issue caused by Chromium Bug 1052872. So I did a little workaround in my chrome browser and it worked for me.
Here's what I did:

Go to chrome://flags (chrome experimental features) page on your chrome browser.
Search for Extensions on chrome:// URLs flag and enable it.
Restart the browser.

Alternatively you can go directly to chrome://flags/#extensions-on-chrome-urls and enable the flag.
I think this will work on other chromium based browsers too. You need to replace the name of the browser on flag url for other chromium browsers. e.g. edge://flags or brave://flags.
Warning: I do not know whether this poses any risk or security vulnerability, so you are proceed at your own risk if you want to!

Just documenting a super-weird variation of this issue in case anyone else encounters something similar....
My error was:
DevTools failed to load source map: Could not load content for chrome-extension://eehlbikncmbbmebknibmlajbmhjiepbh/main.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME
That main.map bit really perplexed me and was super hard to pin down (good luck searching main.*!), but eventually with some help from this SO answer I was able to find it in my Chrome extensions by searching that hash, which turned up this completely unrelated extension, highlight-to-google-calendar by @blackwood (no shade intended, just pinging you in case this is of interest, love the extension btw!), which I just so happened to install yesterday. Switching this extension's "Site access" settings from "On all sites" to "On click" resolved the issue for me.
Still I can't understand why another extension would get picked up by Vue DevTools... :thinking:

OP states this is being served by webpack-dev-server so should not be a production build. I just ran into this same issue with a simple webpack project, no Vuejs and got the same warnings in chrome devtools because webpack config needs to be told to create source maps. In case this helps anyone else I added the devtools option to my webpack.config.js
const path = require('path');

module.exports = {
  mode: 'development',
  entry: './src/index.js',
  output: {
    path: path.resolve(__dirname, 'dist'),
    filename: 'bundle.js',
  },
  devtool: 'eval-source-map',
  watch: true,
};

Other devtool options Here

devtool: 'eval-source-map' It works. Thanks!


Kuna, Idaho

Hi there, can you put in a request for Kuna, Idaho please?
Thanks!

Hi @nmousleh27, thanks for your interest in adding your city to the website. Emails on defund12.org are all written by community members. To add your city, you must provide:

Subject line for the email
Email addresses (at least one) of the government officials you’d like to receive the message
Detailed message concerning the budgeting decisions at stake in your community

Until you provide this content, we cannot post your city.
Follow our email style guidelines for quicker acceptance. Remember that messages must be city-specific and focused on defunding the police. If your message is copied from an external source, please provide a link to the original source.
Your request will be closed until you reply with the necessary content. Thank you!


DRAFT: Responsive design for map

Description
Leaving this PR open while I work on the responsive design for the map, to get deployments on netlify to test on my phone :)
Don't merge yet! But ideas and feedback welcome in this PR.
TODO:

[ ] vertical card layout for small-width devices
[x] collapsible drawer for medium / large width devices

Motivation
Testing Guidelines
Try it on mobile and tablets etc...
Additional Notes
Related to #75

Mobile view is still not done yet, and I think that'll be a task that I finish tomorrow, but I think this PR has enough enhancements now that we should get this in as-is, and i'll add the other functionality tomorrow :)
So feel free to review now.


Exception in server tick loop - Agricraft + DynSur compatibility problem

I posted the crash file over here:
http://www.minecraftforum.net/forums/support/modded-client-support/2778061-1-10-2-self-modded-crash-exception-in-server-tick#c2
If i should paste the code here, feel free to tell me and i will do.

Fix will be in <IP_ADDRESS>.  For some reason the entity villager that Agricraft adds doesn't have an internal name.

Release with fix now on CurseForge.


synthesis : generate language from parse tree ?

I realize this is not the main usage of lark.
However I was curious to know if it would be possible to do the opposite of parsing. That is generating a "program" in the defined (via a lark grammar) language, given the parsed tree.
This would basically mean inverting the control flow...
This could be useful in program synthesis, and when translating between languages, to be able to translate changes both ways.
It naively seems it would be doable, if the grammar is not ambiguous. Is it suitable for lark ? If feasible, where should one start to implement such a feature ?
Any other thought on this topic ?

That actually exists in Lark: https://github.com/lark-parser/lark/blob/master/lark/reconstruct.py
And here's an example of reconstructing JSON with it: https://github.com/lark-parser/lark/blob/master/examples/reconstruct_json.py
But before you get too excited, it's very experimental, and I haven't got it to work with more complex grammars yet. I'll keep working on it though, when I have the time.

This is a very interesting feature and I would like to use this to remove unused objects. I gave it a go with our grammar, but it seemed to fail. Should the parser be made using keep_all_tokens or not?

@FRidh  No, keep_all_tokens is unrelated. If you get an error you should post it, and perhaps I'll be able to help. But since it's a complicated and experimental feature, I can't guarantee it.


Can you export the type IDescriptors?

Hi there,
I'd like to map some names to descriptors, and I realized the type IDescriptors isn't exported in papi.
Thanks

Scratch that, I realized ChainDefinition is the same :)


History

Why history don’t work in app eve?

It should work. Please provide logs if it still doesn't work for you.

Where is localised log file?

How can I activate them?


Maven Dependancy

Is it possible to install the 3scale lib as a dependancy to my POM file?  something along the lines of
	<dependency>
		<groupId>net.threescale</groupId>
		<artifactId>threescale-api</artifactId>
		<version>3.0.1</version>
	</dependency>

using a repository tag perhaps?

Do you guys have the lib (threescale-api) in maven repository? If yes, which repository? I could not find it in maven central. Can you please share the repository and dependency definition for this api?

Hi
We don't currently have it deployed there.
We do intend to do this when we can allocate a resource to do so.
Tom Corcoran | Sales Engineering
3SCALE | Out-of-the-Box API Management Platform
email<EMAIL_ADDRESS>mobile:  +34 671 102 875
web: http://www.3scale.net
On Sun, Mar 1, 2015 at 12:26 AM, riteshimoonlight<EMAIL_ADDRESS>wrote:

Do you guys have the lib (threescale-api) in maven repository? If yes,
which repository? I could not find it in maven central. Can you please
share the repository and dependency definition for this api?
—
Reply to this email directly or view it on GitHub
https://github.com/3scale/3scale_ws_api_for_java/issues/20#issuecomment-76556738
.

Any updates on this? Also, when doing this, could you please review and merge #27?

This is obviously super late, but I just wanted to update this issue.  This maven project is now available in Central here:
http://repo.maven.apache.org/maven2/net/3scale/3scale-api/3.0.2/
As of 3.0.2 you will notice some changes to the groupId and artifactId.
Also note that https://github.com/3scale/3scale_ws_api_for_java/pull/27 was subsumed (and therefore closed) by https://github.com/3scale/3scale_ws_api_for_java/pull/29


Vulnerabilities | Host IP address hard coded in PHP script

In index1.php file, the host IP address is hard coded. Hardcoding sensitive information like IP addresses can pose security risks.

Solved the issue.

Host IP address is removed from php files.


Added another Go port

Hello,
I have made few days ago Go port of this model. It is different from other Go port. It follows typical Go standard and notations better while preserving style of llama2.c

I also think I did Go port first. haha !
UPD: I see other versions of it popup: https://github.com/haormj/llama2.go so it is debatable who is first, if that matters anyways.

Anyways,
Would be great to include it here!
Thank you!

I also created one: https://github.com/saracen/llama2.go
Separate from the others I guess in that it's dependency free, implements mmap, concurrency and I'm trying to eliminate bound checks where possible.
@karpathy Happy to add unless it feels like we're overcrowding the README with Go ports :smile:. Let me know.

gosh, haha!

Gophers galore! Sounds like we need to get collaborating on one!
I believe mine is the most faithful line by line port and definitely want to increase performance while tracking fidelity to the c implementation.

The "bad locality" problem was fixed, but your ports all still have it
You can check here how it was made

thanks. will look into it !

your ports

haha. not really my ports ! I maintain only one
and original port (https://github.com/tmc/go-llama2/blob/master/go/run.go#L352) still has it too 🤷🏻♂

speaking of solution, I see memset, Go does not have it. so need to see if we can adjust it for Go.


Append 'Controller' automatically on create

As the title says, it automatically appends 'Controller'.
Example:
php artisan make:controller Foo // App\Htpp\Controllers\FooController.

Because of strtolower, case with:
php artisan make:controller FoocontroLleR // App\Http\Controllers\FoocontroLleR

This is explicitly for the Controller but it is highly possible make pr for generating this automatically for all make commands, without hardcoding.

No plans to implement this right now. Controllers don't have to be suffixed at all and I don't want to force it on people.


Updated product name.

Change product name from "Apps" to "App" to reflect correct product name.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@jamesche75 : Thanks for your contribution to the Azure documentation! The author, @wesmc7777, has been notified to review your proposed change.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jamesche75 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@jamesche75 : Thanks for your contribution to the Azure documentation! The author, @wesmc7777, has been notified to review your proposed change.

@jamesche75 This is already fixed in the most recent version. Thanks! #please-close


Feature: home screen widgets

It would be nice to have an ability to add widgets to android home screen.
Informational - data from sensors/other entities.
Control - turning switches/lights/groups/automations on/off/run, media player play/stop/back/forward/volume/source/on/off, etc.

Not sure if I should make another issue about this -- but it looks like you can make custom quick tiles in the notification bar too. That would be really rad as well.


App won't compile since updating to 4.0.0-rc.0

Version info

Angular: 4.0.1
Firebase: 3.9.0
AngularFire: 4.0.0-rc.0
Debug output
** Errors in the JavaScript console **
WARNING in ./src/app/app.module.ts
31:14-27 "export 'AuthProviders' was not found in 'angularfire2'

WARNING in ./src/app/app.module.ts
32:12-23 "export 'AuthMethods' was not found in 'angularfire2'

WARNING in ./src/app/app.component.ts
29:57-68 "export 'AngularFire' was not found in 'angularfire2'

WARNING in ./src/app/app.component.ts
29:88-99 "export 'AngularFire' was not found in 'angularfire2'

WARNING in ./src/app/google-api.service.ts
217:57-68 "export 'AngularFire' was not found in 'angularfire2'

WARNING in ./src/app/google-api.service.ts
217:88-99 "export 'AngularFire' was not found in 'angularfire2'

ERROR in /Users/vanderbergha/Firebase-Projects/brilliant-badger/src/app/google-api.service.ts (5,10): Module '"/Users/vanderbergha/Firebase-Projects/brilliant-badger/node_modules/angularfire2/index"' has no exported member 'AngularFire'.

ERROR in /Users/vanderbergha/Firebase-Projects/brilliant-badger/src/app/app.component.ts (2,10): Module '"/Users/vanderbergha/Firebase-Projects/brilliant-badger/node_modules/angularfire2/index"' has no exported member 'AngularFire'.
/Users/vanderbergha/Firebase-Projects/brilliant-badger/src/app/app.component.ts (2,23): Module '"/Users/vanderbergha/Firebase-Projects/brilliant-badger/node_modules/angularfire2/index"' has no exported member 'FirebaseListObservable'.

ERROR in /Users/vanderbergha/Firebase-Projects/brilliant-badger/src/app/app.module.ts (6,29): Module '"/Users/vanderbergha/Firebase-Projects/brilliant-badger/node_modules/angularfire2/index"' has no exported member 'AuthProviders'.
/Users/vanderbergha/Firebase-Projects/brilliant-badger/src/app/app.module.ts (6,44): Module '"/Users/vanderbergha/Firebase-Projects/brilliant-badger/node_modules/angularfire2/index"' has no exported member 'AuthMethods'.
/Users/vanderbergha/Firebase-Projects/brilliant-badger/src/app/app.module.ts (48,53): Argument of type '{ provider: any; method: any; }' is not assignable to parameter of type 'string'.

There are some API-changes in v4.
https://github.com/angular/angularfire2/blob/master/docs/version-4-upgrade.md

@avanderbergh We changed the API to make it easily tree-shakable. You are now required to explicitly import the features you need as an NgModule. We also removed the pre-configured auth features and defaulted to Firebase Authentication's methods to stick to one API.
See #854 for the initial proposal and the migration guide for reference.

@davideast I am having a similar problem can you please help me fix. I am like struggling because of this.
[23:00:27] typescript: C:/Users/Harsha Varun/MyIonicProject/src/pages/third/third.ts, line: 4
Module '"C:/Users/Harsha Varun/MyIonicProject/node_modules/angularfire2/index"' has no exported member
'AuthProviders'.
L3:  import {FourthPage} from '../fourth/fourth';
L4:  import { AuthProviders, AuthMethods, AngularFire } from 'angularfire2';
[23:00:27] typescript: C:/Users/Harsha Varun/MyIonicProject/src/pages/third/third.ts, line: 4
Module '"C:/Users/Harsha Varun/MyIonicProject/node_modules/angularfire2/index"' has no exported member
'AuthMethods'.
L3:  import {FourthPage} from '../fourth/fourth';
L4:  import { AuthProviders, AuthMethods, AngularFire } from 'angularfire2';
[23:00:27] typescript: C:/Users/Harsha Varun/MyIonicProject/src/pages/third/third.ts, line: 4
Module '"C:/Users/Harsha Varun/MyIonicProject/node_modules/angularfire2/index"' has no exported member
'AngularFire'.
L3:  import {FourthPage} from '../fourth/fourth';
L4:  import { AuthProviders, AuthMethods, AngularFire } from 'angularfire2';
package.json
"name": "MyIonicProject",
"version": "0.0.1",
"author": "Ionic Framework",
"homepage": "http://ionicframework.com/",
"private": true,
"scripts": {
"clean": "ionic-app-scripts clean",
"build": "ionic-app-scripts build",
"lint": "ionic-app-scripts lint",
"ionic:build": "ionic-app-scripts build",
"ionic:serve": "ionic-app-scripts serve"
},
"dependencies": {
"@angular/common": "4.1.0",
"@angular/compiler": "4.1.0",
"@angular/compiler-cli": "4.1.0",
"@angular/core": "4.1.0",
"@angular/forms": "4.1.0",
"@angular/http": "4.1.0",
"@angular/platform-browser": "4.1.0",
"@angular/platform-browser-dynamic": "4.1.0",
"": "3.7.0",
"": "3.7.0",
"": "3.7.0",
"": "2.0.1",
"angularfire2": "^4.0.0-rc.0",
"firebase": "^4.0.0",
"ionic-angular": "3.2.1",
"ionicons": "3.0.0",
"rxjs": "5.1.1",
"sw-toolbox": "3.6.0",
"zone.js": "0.8.10"
},
"devDependencies": {
"": "1.3.7",
"": "1.1.2",
"": "1.1.2",
"angularfire2": "^4.0.0-rc.0",
"typescript": "2.2.1"
},
"description": "An Ionic project"
}
Thanks in advance


imagesatintl.com is broken

Steps to reproduce

Open this website - https://www.imagesatintl.com/

Actual behavior

Website doesn't work
Screenshot:

Your environment

Adguard version: 2.12.248 nightly

Same issue on Mac btw

@sfionov the website seems to use the old SPDY protocol, wouldn't it be better to enforce HTTP/1.1 in this case?

core/pull-requests/762


Another round of typo clean up & Converted tabs to spaces.

Converted tabs to spaces & Fixed some more typos.
I'm sure I might of missed a few but oh well.

:heart: it! Thanks :smile:

@06b are you just pasting the code in word and running a spell checker or are you actually good at spelling :smille:

@albertjan HA! I actually think I have a VM which for some sick reason has word as it's default html editor... I need to update that. I wish I was this good at spelling, some of it typos I caught at first was when I was looking in the code and trying to get a better understanding of how Nancy works (Still over my head - you guys are crazy smart :+1: ) but recently like within the last two weeks I found some plugin which has a spell checker either on my work or home machine.
So that's why part of my commits were just like one offs and others were a whole batch of updates. It depended on which machine I was working on at the time, also some of them aren't typos just the wrong word spelled right so some of it was me reading.
If you want I can share the plugin, funny enough is I think it has helped me a bit with my own spelling because I've started catching like statements in my own code comments or even like messages I type in websites which wasn't provided by a copywriter where it's either broken english or just typos.
There are a few parts in Nancy where I noticed it would say like ontop instead of on top, that didn't bother me as much but I mean I can always find them and fix that as well.
I figured this would be the best I could do to help out, haha didn't mean to bomb you guys with a ton of pull requests all at once.


Learning

Need support

Learning

Closing as stale.
If you want to create a PR, create an issue in ASF jira and then create a PR with the issue ID.
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute


Merge software and hardware barcodes to a same method

I have:

[x] searched open and closed issues for duplicates

Bug description
This issue continues discussion started in #221 about barcode generation.
Currently the hardware and software barcodes are implemented in two separated methods for the sake of simplicity. However we want to merge the user call to the barcode method, with an optional boolean argument named force_software=False than allow users that have hardware barcode capabilities to force software rendering.
If your printer does not support hardware rendering according to the printer database then software barcodes are going to be used automatically.

Issue dependency: we should close #244 before moving on the code refactoring.
As a side task one has to test and tweak the soft_barcode default values once #243 gets merged so that hardware and software barcodes have more or less the same size.

Hello everybody!
I just wanted to share with you that I've been (slowly) working on this feature for a few months now and it looks like I could have a PR in a few days that should close both #244 and #245.
Stay tuned for the news ;)

Great, thank you!
If you want to, you could already create a PR for the draft version. Nevertheless, whether now or later, I am looking forward to you PR :)


Gitlab Custom Protocol/Port

These changes allow users to choose which protocol and port to use when querying Gitlab's API.  Also added some more information in the Readme about running the collector and which properties are required.  Should resolve #973 and #957 .

LGTM

Hi ,
We need to download latest package again or just add the lines as you mentioned in the above 3 files..
added support for custon protocol and port
updated readme
small readme fix

@vetrivelan25 When this pull request is accepted, you will just need to pull the latest changes from master.

LGTM.

LGTM

LGTM

Thanks for your help now it's working!!!

Glad to hear it, let me know if you run into anything else.


Keras customized image preprocessing function incurs Value Error “output array is read-only”

I want to use some customized image preprocessing function along with ImageDataGenerator function in Keras. For example, my customized function looks like this:
def customizedDataAugmentation(x):
   choice = np.random.choice(np.arange(1, 4), p=[0.3, 0.3, 0.4])
   if choice==1:
       x = exposure.adjust_gamma(x, np.random.uniform(0.5,1.5))
   elif choice==2:
       ix = Image.fromarray(np.uint8(x))
       blurI = ix.filter(ImageFilter.GaussianBlur(np.random.uniform(0.1,2.5)))
       x = np.asanyarray(blurI)
   return x

And the way to use it is like:
        self.train_datagen = image.ImageDataGenerator(
            rescale=1./255,
            zoom_range=0.15,
            height_shift_range=0.1,
            horizontal_flip=True,
            preprocessing_function=customizedDataAugmentation
        )

However, when I start training, it jumps out this error:
Traceback (most recent call last):
File "/home/joseph/miniconda3/envs/py27/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
File "/home/joseph/miniconda3/envs/py27/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
File "/home/joseph/miniconda3/envs/py27/lib/python2.7/site-packages/keras/utils/data_utils.py", line 560, in data_generator_task
    generator_output = next(self._generator)
File "/home/joseph/miniconda3/envs/py27/lib/python2.7/site-packages/keras/preprocessing/image.py", line 1039, in next
    x = self.image_data_generator.standardize(x)
File "/home/joseph/miniconda3/envs/py27/lib/python2.7/site-packages/keras/preprocessing/image.py", line 494, in standardize
    x *= self.rescale
ValueError: output array is read-only

self.image_data_generator.standardize(x) is the function that calls the customized function. The definition looks something like this:
def standardize(self, x):
    if self.preprocessing_function:
        x = self.preprocessing_function(x)
    if self.rescale:
        x *= self.rescale
    ....

If I don't call my customized function I wouldn't have this error though.
Anyone knows what's happening?
(I'm using Keras 2.0.6, tensorflow-gpu 1.2.1

Same issue ... How did you manage it?


ci: ockam-builder - install commitlint

Part of #3664
Proposed Changes
Installs commitlint using npm in the ockam-builder docker image to be used in github workflow
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

Merged in #3771

Thank you @elpiel 🥳

🙌🙌 thank you too


Preparing v1.2.0 release

Codecov Report

Merging #39 (bd79509) into main (c809bfa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   76.08%   76.08%
=======================================
  Files          21       21
  Lines        1597     1597
=======================================
  Hits         1215     1215
  Misses        382      382

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c809bfa...bd79509. Read the comment docs.


Reuse the deserialized buffer when serializing parser state cache

We serialize the parser state cache after either deserializing from the cache stream or generating bytecode and serializing that. If we succeeded to deserialize the parser state cache from a buffer retrieved from the cache stream, we can avoid serializing the bytecode into a buffer again.

@dotnet-bot test windows x64_debug please


putc error

Dear Micooke,
When I used your OLED smarty example, I am getting the following error. Could you please let me know, how to troubleshoot it.
C:\Users\nobee\Documents\Arduino\libraries\SFE_MicroOLED/SFE_MicroOLED.h:118:18: error: macro "putc" requires 2 arguments, but only 1 given

Heya, can you please provide me with more info so that i can replicate it :

Arduino version?
Have you installed sandeeps repo?
What example are you trying?

Ah, theres a few issues here. Have you uploaded the softdevice to your hardware? This needs to be done using a board from sandeeps repo at the moment (any board with the right chipset).
The accelerometer example uses my squix78_OLED repo - which is currently broken. Ill redo the example to use u8g2 or my sparkfun_OLED. Ill also create a travis CI build file for this so i can very every push works.
Long story short, ill look in to it and get back to you.

Thank you very much micooke. I was so desperately trying to reach anyone who can help me with this. Hope I can work with this fitness tracker. So far it was difficult.

Yes, in fact I am also using 1.8.5 version. May be a stupid question, but I think I misunderstood your instructions from your github:
4.3 Install arduino-nRF5-smartwatches : Do you mean that I need to keep this folder inside the hardware folder in Documents/Arduino/hardware/arduino-nRF5-smartwatches or do I need to keep it in Documents/Arduino/hardware/arduino-nRF5, which is sandeep's repo.
I am asking this because I am getting the following error:
No valid hardware definitions found in folder arduino-nRF5-smartwatches.
Could not find boards.txt in C:\Users\nobee\Documents\Arduino\hardware\arduino-nRF5-smartwatches\variants. Is it pre-1.5?

The folder structure for hardware has changed, so the easiest way is to install it through the board manager then copy over the latest version from github into its installed directory.
Otherwise from memory the folder in documents/hardware needs another layer to say what architecture it is. I.e. Boards.txt would be located in Hardware/arduino-nRF5-smartwatches/nRF5/boards.txt instead of Hardware/arduino-nRF5-smartwatches/boards.txt
Im sorry, i dont have a pc with me to check. If that doesn't work then the easiest way is to install the old release then copy over the libraries you want to the libraries folder until i create a nee release.

Success. Thanks for the tip. I uninstalled Arduino and installed everything again in order as you explained above. Now the MicroOLED_64X32 is compiled. Although, I don't see anything on the screen yet, but compiling the code itself seems a big success for the time being. I think, my definition of pins might be wrong. Could you please if the below definitions are correct for ID107HR:
#define PIN_RESET 30 // Connect RST to pin 30 (SPI & I2C)
#define PIN_DC     0 // Connect DC to pin 0 (SPI only)
#define PIN_CS    29 // Connect CS to pin 29 (SPI only)
#define DC_JUMPER 0  // DC jumper setting(I2C only)
MicroOLED oled(7,8);
Do I need to change anything?
Thank you so much for your help so far.

Ive tested my libraries against i2c, SoftwareI2C and SPI for the 64x32 and 64x128 oled screens. Hence my examples are in a bit of flux. When i get time ill tidy them up so that it instantiates using the correct pin mapping and peripheral type, based off whether e.g. #ID107HR is defined

Thanks for the help. I got the screen working now. I am able to display the acceleratorometer data on screen. I didn't use: MicroOLED oled(OLED_RST, OLED_DC, OLED_CS) as it was giving me an error. My code is as following:
`#include <Wire.h>
#include <SPI.h>
#include <KX022.h>
#include <SFE_MicroOLED.h>  // Include the SFE_MicroOLED library
#define PIN_RESET 30 // Connect RST to pin 30 (SPI & I2C)
#define PIN_DC     0 // Connect DC to pin 0 (SPI only)
#define PIN_CS    29 // Connect CS to pin 29 (SPI only)
#define DC_JUMPER 0  // DC jumper setting(I2C only)
//#define USE_SOFTWAREI2C
#ifdef USE_SOFTWAREI2C
#include <SoftwareI2C.h>
SoftwareI2C sWire(14, 16);
KX022 acc(sWire);
#else
KX022<> acc(Wire);
//KX022 acc(Wire); // TwoWire is the default class, so this is the same as above
#endif
#define OLED_WIDTH 64
#define OLED_HEIGHT 32
MicroOLED oled(OLED_RST, OLED_DC, OLED_CS); // (pin_rst, pin_dc, pin_cs)
float xyz[3];
uint32_t tPage;
bool B1_isPressed = false;
uint8_t page_num = 0;
const uint8_t page_count = 2;
void draw_page(uint8_t idx = 0);
void setup()
{
Wire.begin();
Serial.begin(9600);
Serial.println(FILE);
pinMode(PIN_BUTTON1, INPUT_PULLUP);
acc.init();
oled.setScreenSize(OLED_WIDTH, OLED_HEIGHT);
oled.begin();
//oled.flipScreenVertically();
//  oled.setTextAlignment(TEXT_ALIGN_LEFT);
//  oled.setFont(ArialMT_Plain_10);
draw_page(page_num++);
delay(3000); // show splash for 3s
tPage = millis();
}
void loop()
{
if (!B1_isPressed & !digitalRead(PIN_BUTTON1)) // timer used for button debounce
{
page_num = (page_num + 1 < page_count)?page_num+1:0;
}
B1_isPressed = !digitalRead(PIN_BUTTON1);
if (millis() - tPage > 20) // 20ms = 50Hz
{
tPage = millis();
draw_page(page_num);
}
yield();
delay(500);
oled.clear(PAGE); // Clear the display's internal memory
oled.clear(ALL);  // Clear the library's display buffer
}
void float2chars(float &in, char (&out)[5])
{
bool sign_bit = (in < 0);
uint16_t tmp = sign_bit?(-in * 10):(in * 10);
out[0] = (sign_bit)?'-':' ';
out[1] = char('0' + (tmp / 10));
out[2] = '.';
out[3] = char('0' + (tmp % 10));
out[4] = '\0';
}
void draw_page(uint8_t idx)
{
switch(idx)
{
case 1:
page_accelerometer(); break;
default:
page_startup();
break;
}
}
void page_startup()
{
oled.clear();
//oled.drawString(0,0,"github.com/");
//oled.drawString(0,10,"micooke");
//  oled.drawString(0,20,TIME);
oled.display();
}
void page_accelerometer()
{
char fltBuf[5];
acc.getAccelXYZ(xyz);

oled.clear();
oled.setCursor(5, 4); // points cursor to x=27 y=0
oled.print("X");
oled.setCursor(25, 4); // points cursor to x=27 y=0
float2chars(xyz[0],fltBuf);
oled.print(fltBuf);

oled.setCursor(5, 14); // points cursor to x=27 y=0
oled.print("Y");
oled.setCursor(25, 14); // points cursor to x=27 y=0
float2chars(xyz[1],fltBuf);
oled.print(fltBuf);

oled.setCursor(5, 24); // points cursor to x=27 y=0
oled.print("Z");
oled.setCursor(25, 24); // points cursor to x=27 y=0
float2chars(xyz[2],fltBuf);
oled.print(fltBuf);

oled.display();

}`

Now, I would like to work with the HR sensor. If you don't mind could you please point me towards a right direction. Thanks a lot for your help so far.

I haven't got that working properly. I need to upload my update, but not getting any usefull data from the sensor. It is a Si1143, ive pulled another repo into mine but haven't done anything with it. It didn't work for me in its default state. Pinout is in readme.md

Okay, Thanks for letting me know. I am looking at the following library:
https://github.com/Cornell-Engineering-World-Health/Si1143-Pulse-Oximetry/blob/master/IRE.ino

Let me know if you get something working and ill write/adapt a library using it

This is the one i was working on
https://github.com/micooke/SI1143_Pulse_Prox_Sensors
If you find an algorithm to decouple the motion induced noise using the accelerometer - definitely let me know 😊

I too looked at that library, but it is written with ports for providing the I2C address. Are you sure that I2C address for HR sensor is 0x5A ??
To be frank, I am really not good with coding. I am trying my best to hack this fitness tracker to use it for light measuring device. If I get it working I will let you know.

Hi, I have Si1143 file compiled. But unfortunately, I was not able to see the output on the serial port as I don't know how to use the serial port with black magic probe. So, I am now trying to see the bmp values on OLED screen which might take some time. Please see the file below, which would work with serial port. Let me know, if it works with your fitness tracker.
https://github.com/scientistnobee/Si1143

Yes, its 0x5A. SPI and I2C interrupts are shared on the nRF51, by default it is set to use 1xSPI, 1xI2C - so you need to use a SoftwareI2C library (luckily i wrote one) and modify your code to work with SoftwareI2C

Okay. But I feel I didn't progress much today, although I spent my whole day on it. Just to clarify, I want to detect the light values using this SI1143 sensor. I am not interested in BPM measurements. So, if you have any semi working code, could you please share. I had a look at your library in the following, but I couldn't able to compile it.

I got it the wrong way around, the Si1143 library (https://github.com/micooke/Si1143) is hardware I2C, use SoftwareI2C for the accelerometer.

Thank you. I will check it now and let you know my progress.

No worries. Ill leave this issue open for the meantime. If i dont hear anything ill close it in a couple months

Hi Mark, I am able to communicate with Si114 using the code from @najnesnaj below link. I am updating here, so anyone following this thread might find this useful. Thanks for your help in troubleshooting the code.
https://github.com/najnesnaj/smartband

@micooke concerning an algorithm for cleaning up the heart rate signal: I started digging around for scientific papers on that topic and there are quite a few. For a start you can simply type: "photoplethysmography accelerometer" into Google Scholar. I plan to try to implement such an algorithm at some point but getting DFU to work has a higher priority to me :)

Hi Mark,
What are the typical values of photodiodes  (als_vis and als_ir) you get using your Si1143 codes. I am getting these values as below:
AMBIENT_VIS<PHONE_NUMBER>
AMBIENT_IR      15859711
AMBIENT_VIS     21234092
AMBIENT_IR      16843020
AMBIENT_VIS     20906423
AMBIENT_IR      16449826
AMBIENT_VIS     20840893
AMBIENT_IR      16843038
AMBIENT_VIS     21496239
AMBIENT_IR      16580882
AMBIENT_VIS     21234088
AMBIENT_IR      16974110
AMBIENT_VIS     21430716
AMBIENT_IR      16974110
AMBIENT_VIS     21168546
AMBIENT_IR      16580890
AMBIENT_VIS     21758384
AMBIENT_IR      16843038
AMBIENT_VIS     21168569
AMBIENT_IR      16711968
AMBIENT_VIS     20709798
AMBIENT_IR      17039635
AMBIENT_VIS     20644250
AMBIENT_IR      16777498
AMBIENT_VIS     21234097
AMBIENT_IR      16908574
AMBIENT_VIS     21168543
AMBIENT_IR      16580891
AMBIENT_VIS     21168564
AMBIENT_IR      16908577
AMBIENT_VIS     21365150
AMBIENT_IR      16515358
AMBIENT_VIS     20840879
AMBIENT_IR      16711960
AMBIENT_VIS     21561779
AMBIENT_IR      16580897
AMBIENT_VIS     20709793
AMBIENT_IR      16777501
AMBIENT_VIS     21168539
Do you think these values are realistic and do they make sense? I don't know what these numbers corresponds to. Please let me know, if you have any idea. Thank you.

Heya, i haven't looked at this in a while.. I'm away from my test setup at the moment, so I'll try and reply next week.
From memory they both should be measuring distance, so try placing a solid object different distances away and observing the measurements. Ambiant is without the leds on. Should be useful for detecting on /off wrist to turn on /off the leds for hr measurement

Oh, and it's short range. 8cm as the max distance comes to mind.. Dunno, i would have to check the datasheet

I think als_vis and als_ir are the only photodode measurements while ps_data measuring the distance.
I thought als_vis is given by ALS_VIS_DATA=256*ALS_VIS_DATA1+ALS_VIS_DATA0 as shown in page 36 of the following pdf.
https://www.silabs.com/documents/public/application-notes/AN498.pdf
But these values (als_vis and ALS_VIS_DATA) are not the same when I read from the sensor. So I don't know what pulse.als_vis is measuring.

Mark any update on these pulse.als_vis values?

Sorry no. I've been flat out with work, and I'm about to be away for a while so probably no update for a month im sorry

No worries. All the best with your work. By the way, did you ever encountered the following problem, while working with ID107HR.
I was able to upload the code, If I chose softdevice as "none" in the "tools" "softdevice" options of Arduino IDE. However, if I chose "s130", Arduino IDE is struck while uploading the code to ID107HR.
If you are busy please ignore this.

Yeah sometimes my programmer gets itself into a state. I normally have to remove it and restart Arduino. Normally with a blackmagic probe.

Hi Mark,
I resolved the above soft device inclusion problem. I downloaded the softdevice file from Nordioc and kept in the softdevice folder of Sandeep's core.

I actually had the same issue when running this on Linux so i wrote this (only valid for the current revision of sandeeps repo) : https://github.com/micooke/arduino-nRF5-smartwatches/blob/master/canihaz_softdevices.sh

@scientistnobee - regarding the sensor value : ALS_VIS_DATA=256*ALS_VIS_DATA1+ALS_VIS_DATA0 is the same as ALS_VIS_DATA=(ALS_VIS_DATA1 << 8) +ALS_VIS_DATA0
<< is a bit shift operator in c. So im bit shifting by 8, which is multiplying by 2^8.
The max 16b value is 2^16 - 1 = 65535 so something else is happening. I'm averaging (line 402 - 413) and i suspect the issue is there. I'll have a look in the next week, sorry been busy with the release :)
Cheers

Thanks for your working on this problem. I am still struggling with this. Hope we can resolve this soon.

Just a note, using the board manager - try installing 0.2.0 to get the latest of everything... excluding the file i just updated :)
https://github.com/micooke/Si1143/blob/master/Examples/ReadSensors/ReadSensors.ino
Using ReadSensors.ino, Im getting the following :
inside the house

Active LEDs [red, ir1, ir2] = [502, 384, 247]
Ambiant LEDs [visible, ir] = [272, 562]

inside the house, finger against sensor

Active LEDs [red, ir1, ir2] = [5556, 3277, 252]
Ambiant LEDs [visible, ir] = [256, 265]

Note, by default 5 samples are averaged together (see samples_to_average):
https://github.com/micooke/Si1143/blob/da51cfe2a745b1db8d0f387e96afe5eb6a8f245c/Si114.h#L104
I just commited this. The diff may make the measurements a bit easier to understand:
https://github.com/micooke/Si1143/commit/da51cfe2a745b1db8d0f387e96afe5eb6a8f245c

I never be able to get connected to Si114x with your library. I don't know what the problem is. I get only the following result
No SI114x found

What board settings are you using?

I used the generic nrf51 variant with your files of variant.h in it.
How can I attach the HR sensor to the hardware i2c? Could you please tell me your configuration?

What is the physical device?
I'm using the id107hr variant - it's a nrf51.
Do you have the latest si1143 library? As i said I updated it. If your library is templated, then it is the latest.
One thing, i released the wrong commit by accident - software i2c doesn't work (no error produced), but the standard wire library does (this is the default example)

I have only 107HR device. yes, I do download your latest version of the library. I updated your variants as well to version 0.2.0. I am not changing anything in your ReadSensors.ino, so I am sure I am not using software I2C.

Are you selecting ID107HR for the board and I2C:Accel=SW, HeartRate=HW for the Board Variant?

Thanks for the tip. Now I understood, what you have been saying all these days. I didn't see the Board variant before. I am extremely sorry for that. Now I am getting sensible values.

Now coming to the values, if I keep my smart phone flash light shining on to the sensor, I can see the Ambient Visible and IR photo diode values changing as expected. However, there is no significant change in the Active LEDS values. So Active LEDS are only measuring the reflectance values i.e distance wrt to the sensor rather than light coming on the sensor. If that is the case, how these LEDS are used to measure the heartbeat rate?

Not a problem, it's easy enough to miss.
With PPG you measure the variance in reflected signal, which should peak and trough in time with your blood flow - ie your heartrate. As i said, I haven't got this part working

Thanks for understanding. I am looking forward to PPG measurements.

Hi Mark, I again hit the softdevice problem. If I select softdevice as "none" I am able to upload the code, but if I chose s130, I could not. This time, I copied the softdevice into the softdevice folder in your core, just like I did before for sandeep's code. But it is still not working. Please let me know, if there are any tricks to get it worked this time.

Solved the above problem. After copying the softdevice file in to the softdevice folder, I had to restart the Arduino. Now it's working.

By the way, I developed a simple UART communication app using MIT app inventor platform. One can modify it for any other purpose.

https://github.com/scientistnobee/Simple-BLE-UART

Hi, I encounter a strange problem. My code on the ID107HR is running for a while (15 minutes) then it stops working. What I mean is that it stops communicating on serial port and stops displaying values on the OLED screen. But still the LEDs of HR sensor are switched on for at least 2-3 hours until the battery is completely discharged. Then if I charge the device again, it works for a while and again same problem repeats. Do you know what's going on?

Heya,
Ive never had this issue, and its kind of hard for me to say without looking at the code. The first thing i would look at is memory - are you using up all your memory, are you going out of bounds of an array, are you forgetting to deallocate memory, etc. The second thing i would look at is commenting out the serial stuff, and commenting out the oled stuff (one at a time) and seeing if the error still occurs.

Hi Mark,
Thanks for the suggestions. I will try as you suggested. In between, I am posting my code here. Please have a look and let me know, if you see any obvious problems. `#include <Wire.h>
#include <SPI.h>
//#include <KX022.h>
#include <SFE_MicroOLED.h>  // Include the SFE_MicroOLED library
#include  <avr/dtostrf.h>
#include <Si114.h>
PulsePlug<> pulse(Wire);
#include <BLEPeripheral.h>
#include "BLESerial.h"
BLESerial bleSerial(10, 2, 9);
unsigned long long lastSent = 0;
#define OLED_WIDTH 64
#define OLED_HEIGHT 32
MicroOLED oled(OLED_RST, OLED_DC, OLED_CS); // (pin_rst, pin_dc, pin_cs)
float xyz[3];
uint32_t tPage;
bool B1_isPressed = false;
uint8_t page_num = 0;
const uint8_t page_count = 2;
void draw_page(uint8_t idx = 0);
void setup()
{
Wire.begin();
bleSerial.setLocalName("UART");
bleSerial.begin();
Serial.begin(9600);
Serial.println(FILE);
pinMode(PIN_BUTTON1, INPUT_PULLUP);
oled.setScreenSize(OLED_WIDTH, OLED_HEIGHT);
oled.begin();
draw_page(page_num++);
delay(1000); // show splash for 1s
tPage = millis();
while (pulse.isPresent() == false)
{
Serial.println(F("No SI114x foundxxx"));
delay(1000);
}
Serial.println(F("SI114x Pulse Sensor found"));
pulse.init();
}
void loop()
{
if (!B1_isPressed & !digitalRead(PIN_BUTTON1)) // timer used for button debounce
{
page_num = (page_num + 1 < page_count)?page_num+1:0;
}
B1_isPressed = !digitalRead(PIN_BUTTON1);
if (millis() - tPage > 20) // 20ms = 50Hz
{
tPage = millis();
draw_page(page_num);
}
yield();
delay(1000); // show splash for 3s
oled.clear(PAGE); // Clear the display's internal memory
oled.clear(ALL);  // Clear the library's display buffer
}
void float2chars(float &in, char (&out)[5])
{
bool sign_bit = (in < 0);
uint16_t tmp = sign_bit ? (-in * 10) : (in * 10);
out[0] = (sign_bit) ? '-' : ' ';
out[1] = char('0' + (tmp / 10));
out[2] = '.';
out[3] = char('0' + (tmp % 10));
out[4] = '\0';
}
void draw_page(uint8_t idx)
{
switch(idx)
{
case 1:
page_accelerometer(); break;
default:
page_startup();
break;
}
}
void page_startup()
{
oled.clear();
//oled.drawString(0,0,"github.com/");
//oled.drawString(0,10,"micooke");
//  oled.drawString(0,20,TIME);
oled.display();
}
void page_accelerometer()
{
pulse.readSensor(3);
Serial.print(F("Active LEDs [red, ir1, ir2] = ["));
Serial.print(pulse.led_red);
Serial.print(F(", "));
Serial.print(pulse.led_ir1);
Serial.print(F(", "));
Serial.print(pulse.led_ir2);
Serial.println(F("]"));
Serial.print(F("Ambiant LEDs [visible, ir] = ["));
Serial.print(pulse.als_vis);
Serial.print(F(", "));
Serial.print(pulse.als_ir);
Serial.println(F("]"));
float total=pulse.led_red+pulse.led_ir1+pulse.led_ir2;
char fltBuf[5];
char charVal[10];

oled.clear();
oled.setCursor(5, 4); // points cursor to x=27 y=0
oled.print("Vis");
oled.setCursor(25, 4); // points cursor to x=27 y=0
dtostrf(pulse.als_vis,5,0,charVal);
oled.print(charVal);

oled.setCursor(5, 20); // points cursor to x=27 y=0
oled.print("IR");
oled.setCursor(25, 20); // points cursor to x=27 y=0

// float2chars(pulse.als_ir,fltBuf);
dtostrf(pulse.als_ir,5,0,charVal);
oled.print(charVal);
oled.display();
bleSerial.print("V");
bleSerial.print(pulse.led_red);
bleSerial.print(",");
bleSerial.print("I");
bleSerial.print(pulse.led_ir1);

}`

Hi Mark, I have an update. As you predicted the bleSerial is causing the problem. If I remove the lines related to bleSerial, the device works continuously without stopping. Do you have any idea how to make the device keep working with bleSerial ? I need this bleSerial as I want to monitor remotely.

I'm not sure exactly. One thing I would try is replacing all delay()  calls with a millis() based delay i.e.
yield();
delay(1000); // show splash for 3s

becomes
uint32_t t = millis();
while (millis() - t < 1000)
{
yield();
}

The reason being that a lot of wireless comms require background processes to maintain a connection, and also considering it is uart it will have an interrupt service routine for receiving Bluetooth data. Passing control to yield() frees up the processor for these processes.
The other thing it could be is an error in the btSerial library.

Yet another thing, you could remove Serial comms and replace them with bleSerial.
I doubt that they conflict, but it's another thing to tick off. Particularly if you aren't using hardware serial

Hi Mark,
Thanks, I did replace the Serial comms with bleSerial and it is working as I updated above. I have made the changes to delays as you suggested. I am waiting to see when it will stop working.

Hi Mark, replacing the delays with millis(), didn't help the BLE stopping problem. I raised issue at Sandeepmistry's repo https://github.com/micooke/arduino-nRF5-smartwatches/issues/2
Hope someone helps.

Hi Mark,
I am having this Bluetooth problem only if I use your new version of the 0.2.0 version and new Si1143 library. If I fall back to the old Si1143 library and using generic nRF51, I don't have any problem. I am reporting here, just to let you know.

Oh damn, thanks for finding that out! Most likely candidate is the library. Sorry for the delay, new phone and i wasnt getting notifications. Unfortunately it's bad timing, I'm offline for a bit. Rest assured that this will be my highest priority when i get back. Ta, Mark

Hi Mark,
Thanks for your reply. I am glad that you would look into this problem. I just came from holidays.

Hi Mark,
I got the following error message.
C:\Users\nobee\Documents\Arduino\libraries\Timezone\src/Timezone.h:16:66:
fatal error: TimeLib.h: No such file or directory
Where can I find that file? As you can see in the attached image, the
Timezone library is flagged as in compatible.
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On Thu, Jan 31, 2019 at 4:22 AM Mark Cooke<EMAIL_ADDRESS>wrote:

Give this a try:
https://github.com/micooke/arduino-nRF5-smartwatches/tree/master/libraries/examples/Examples/ID107_u8g2_sensors_clock_bleUart
Use the default configuration for ID107 (HW Accelerometer, SW Heartrate),
and it uses the u8g2 library (https://github.com/olikraus/u8g2)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/micooke/arduino-nRF5-smartwatches/issues/5#issuecomment-459209869,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHmv3nRSgKgJtzC1qB-WOELo9USK6sQDks5vIm-ggaJpZM4T5JPT
.

Oops, like like a library interdependency! Line 16 of Timezone.h is
#include <TimeLib.h> // https://github.com/PaulStoffregen/Time
So you will be that. It's a very good library, I use it on other projects to e.g. sync the time to gps.
Dont worry about the complaints. The library says it's for avr, but there is no avr specific code in it.

Hi Mark,
I installed the timeLib, but I am getting the following error.
'PIN_WIRE1_SDA' was not declared in this scope
It is pointing the error to ID107HR_sensor.h file. In particular to the
following line SoftwareI2C sWire(PIN_WIRE1_SDA, PIN_WIRE1_SCL);
I tried with both Board variants (Accl:HW, Hr:SW and Accl:SW, Hr:HW)
On Thu, Feb 7, 2019 at 8:26 PM Mark Cooke<EMAIL_ADDRESS>wrote:

Oops, like like a library interdependency! Line 16 of Timezone.h is
#include <TimeLib.h> // https://github.com/PaulStoffregen/Time
So you will be that. It's a very good library, I use it on other projects
to e.g. sync the time to gps.
Dont worry about the complaints. The library says it's for avr, but there
is no avr specific code in it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/micooke/arduino-nRF5-smartwatches/issues/5#issuecomment-461583108,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHmv3qNbsMtin7w_srlE2oOfS79mjqI4ks5vLIv3gaJpZM4T5JPT
.

That's actually very strange because selecting those options is what changes the defines I'm referencing.
Try this : In the Arduino Ide, go to the board manager and update to the latest which is 0.2.1
Of it still doesn't work, try adding
#include <arduino.h> to the top of ID107_sensors.h. It may be that I'm working on a newer ide and the linker is better so it doesn't need the explicit include

Sorry about the run around, I'm trying to make it easy for people :disappointed:

Hi Mark,
After updating the board manager the code has compiled without any errors.
Now, what I am supposed see. I can't see anything on the screen or on the
serial output.
On Thu, Feb 21, 2019 at 10:16 AM Mark Cooke<EMAIL_ADDRESS>wrote:

Sorry about the run around, I'm trying to make it easy for people 😞
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/micooke/arduino-nRF5-smartwatches/issues/5#issuecomment-465942680,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHmv3rs_rAn_cMxvjmFtKlaE_xjQPWAbks5vPnHegaJpZM4T5JPT
.

You may need to reflash the bootloader and try uploading it again.
The ble example will just output the filename over serial at startup. However it will display the sensor information on the oled, which you can cycle through by clicking the side button. It will also push the vis and ir sensor readings over bluetooth, peripheral name UART as per your example

Hi Mark,
Thanks for your help while I was hacking the fitness sensor. Thanks to your
help, we built a small biolab instrument with the fitness tracker and our
results are published in the ACS journal (see the attached pdf and the link)
I also cited your github page in the paper. Only because of you, I was able
to get the Si114x sensor working. I hope to get it working with your
updated library, which I yet to make it happen.
I owe you a treat. Thanks, again.
https://pubs.acs.org/doi/10.1021/acs.analchem.9b02628
On Fri, Mar 8, 2019 at 10:28 PM Mark Cooke<EMAIL_ADDRESS>wrote:

You may need to reflash the bootloader and try uploading it again.
The ble example will just output the filename over serial at startup.
However it will display the sensor information on the oled, which you can
cycle through by clicking the side button. It will also push the vis and ir
sensor readings over bluetooth, peripheral name UART as per your example
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/micooke/arduino-nRF5-smartwatches/issues/5#issuecomment-471098047,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHmv3s1dH8AOveagcuf_oreyaRqQHI1Xks5vUuQKgaJpZM4T5JPT
.

Great work! Thanks for the reference, and im glad you got something out of my work. Happy to help anytime in the future :)

Thank you so much for your kind help, Mark.
I will get back to you on your new Si114x library soon.
On Mon, 16 Sep 2019, 21:59 Mark Cooke<EMAIL_ADDRESS>wrote:

Great work! Thanks for the reference, and im glad you got something out of
my work. Happy to help anytime in the future :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/micooke/arduino-nRF5-smartwatches/issues/5?email_source=notifications&email_token=AB427XW2HEWNZ6AABRNUBVLQJ7XUPA5CNFSM4E7ESPJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62QCSQ#issuecomment-531956042,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB427XQXC2ZAPI2MQPQJUIDQJ7XUPANCNFSM4E7ESPJQ
.


Improvements

Reorganize:

logo.js:

move getQueryParam() to new utils.js
rename logo.js to nobs_logo.js

totop.js:

move jumpToTop() to nobs.js

completed


Feature Request: Add :Leet next and :Leet previous navigation

I love using the leetcode.nvim plugin, and I have a suggestion that could make it even better. How about adding two new sub commands?
What I’m Suggesting

:Leet next: This would let us jump to the next problem in the set, making it easier to keep solving without going back to the menu. or opening problem lists.
:Leet previous : This command would let us quickly navigate back to the last problem we were working on. For instance, if we're currently on problem 21, using this command would take us to problem 20.

Why It Would Help

Smoother Navigation: It would really speed up how we move through problems.
More Intuitive: It feels more natural to navigate problems this way, especially for those of us who like using keyboard shortcuts.

I think these small additions could really enhance the experience for all users. Thanks for considering this!

Have you tried using :Leet tabs?

@kawre btw, how to close tab?


Shortcut syntax doesn't work for nested components

Description
Right now, use LiveVue.Components, vue_root: "./assets/vue/*.vue" doesn't work correctly for nested components.
The reason is simple - I need to decide on a convention how to name such functions. These are the options:

1. Keep only filename, discard the path:
assets/vue/helpers/Modal.vue -> <.Modal>
it can cause conflicts when two Vue in different directories files share names

2. Keep full path, replace path separators by underscores?
assets/vue/helpers/Modal.vue -> <.helpers_nested_Modal>

3. Keep full path, replace path separators by PascalCase?
assets/vue/helpers/nested/Modal.vue -> <.HelpersNestedModal>

4. Same as before, but remove duplicates (similar to Nuxt auto-imports)
assets/vue/helpers/welcome/WelcomeModal.vue -> <.HelpersWelcomeModal>

Maybe make this configurable? I really like the idea Nuxt is using with appending paths to the names.
P.S. Thank a lot for this project, I just tried to find something similar - and here it is!

Thanks, glad you like it 😊
Could you tell more about your use-case? I'm trying to be careful about this feature since it can potentially create a lot of functions.

Could you tell more about your use-case? I'm trying to be careful about this feature since it can potentially create a lot of functions.

I like conventions used in Nuxt (and in Phoenix) - with paths, imports, component names etc. For example, when you have a MainMenu component it would probably have children like MenuItem which make sense only in context of the MainMenu component. So, when we auto-import such hierarchy, it makes sense to name the child as MainMenuMenuItem. Of course, it is possible to just name the component file like that, but then we can have a lot of unnecessary duplication for deep hierarchies.
But probably I was a bit too hasty, I need to experiment more before I can formulate more clear ideas :)
Currently I'm playing with the lib, trying to adapt UnoCSS for my setup with LiveVue and get rid of Tailwind.
But it's a bit chaotic at the moment :)
And it is not clear for me yet how to work with LiveView and LiveVue components together in general. Of course, the easiest way is to build the full frontend part on Vue components and maybe use useState or Pinia to work with the backend, but in this case, there will be one entry point from the LiveView part, which would then need to route everything inside, a lot of LiveView futures will be lost etc.
Please mind that I'm just thinking out loud, my words might not make sense, I spent just a few hours with all of this so far. :-D
Btw, I've added eslint and typechecker and sometimes they are not happy about absence of type for the LiveVue object :)
Also, I got some issues with imports: the default /assets/vue path conflicts with node_modules/vue on imports, but most probably its related to my clumsy hands: I'm not that experienced with the frontend stuff.


Fixed an issue where processing indicator wouldn't go away

Fixed an issue where the processing indicator wouldn't go away. This happened when the pubSelector was changed, but the change didn't result in any new rows.
For example, if you have a collection with 30 rows, going from page size 50 to page size 100 doesn't actually get any new rows. So some of the autorun blocks were never triggered.
This possibly addresses https://github.com/aldeed/meteor-tabular/issues/252

+1 for merging this :)

+1

+1

+1 Great job, excellent find :)

To anyone with write access, let’s merge.

Can I do anything to help this get merged? I'm having the same issue and the fix looks pretty obvious and clean to me.

+1

+1

+1

+1

Anyone?

Author seems to be on vacation or something. This seems to fix the issue however.

I fixed another issue where "Processing" indicator would be displayed and not go away when clicking on the currently selected page

@gaiazov Thanks for your efforts on this, your second commit has fixed the issue I was having.  I hope this gets merged in soon.

+1

+1

+1 merge

Thanks, I've merged this manually.


Bsg_f1 is out of sync with bsg_manycore

With PR # 190 (bsg manycore mem cfg) merged in bsg_manycore, the filelist and hardware in bsg_f1 is out of sync. Could you guys please take a look this? Thanks!

We’ve never promised that bsg manycore and F1 master are in sync. That’s the point of bladerunner
But we know of the issue and we’re working to fix it

On Oct 27, 2019, at 8:47 PM, Borna Ehsani<EMAIL_ADDRESS>wrote:

With PR # 190 (bsg manycore mem cfg) merged in bsg_manycore, the filelist and hardware in bsg_f1 is out of sync. Could you guys please take a look this? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Cool, thanks!

Addressed in #445


Physical Projectile Attack Damage Support

Hey there,
the "Physical Projectile Attack Damage Support" Gem reduces the attack rate of Molten Strike Magma Balls - even though this is not true in the game.
PPAD reduces your Projectile attack speed, however Molten Strike is a Melee Attack that has a secondary effect of Firing Projectiles - so while in theory the Magma Balls themselves attack slower, this has no actual effect since they are fired every time you Attack with the Melee portion - which is unaffected by that modifier.

This is a limitation that applies to a lot of skills that have multiple parts; in this case, the Magma Balls part is a projectile skill, so its attack speed must be affected by projectile attack modifiers, just as its damage is. The attack/cast rate for secondary skill parts should generally be ignored anyway, or at least taken with a grain of salt, as the skill mechanics often render it inaccurate; it's only shown at all because it is sometimes correct.
The ultimate solution would allow calculations from different skill parts to be combined, but that requires a significant overhaul of the skill calculation system; it's a reasonably high priority as it also allows CoC and other trigger setups to work, but it's not likely to happen any time soon due to the amount of work required.

Multistrike Attack Speed Bonus Not Applied to Molten Strike Balls #1025 is a separate issue than counting the number of balls that are generated.  Pathofbuilding does count attack speed bonuses in it's dps calculations but not ball generation per se - according, the attack speed bonus for multistrike should be included for consistency with the approach.


feat: Add support for enabling EFA resources

Description

Add support for enabling EFA resources (nodegroup security group rules, expose EFA interfaces via launch template, create and use placement group, ensure only the AZs that support the instance type are used in the subnets provided)

Motivation and Context

Make it easier to enable EFA support across the different compute options available to users

Breaking Changes

No

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

This PR is included in version 20.4.0 :tada:


Employees page and "days used" column

The "days used" column does not respect revoked days off.
STR:

approve new request
and then revoke it (as admin)
see that on the Employee page it is treated as approved invokation (used days already decremented)
** on other hand Absences section still treat the request as active one (which is true)

Very likely the code that build the employees list page does not check the revoke_pending status

Fixed and pushed into master.


add optional http basic auth to pinot broker

Description
Added support for an optional HTTP basic auth provider to pinot-broker, which enables user- and table-level authentication of incoming queries.
HTTP basic auth configuration uses pinot's regular properties format. For example:

pinot.broker.access.control.class=org.apache.pinot.broker.broker.BasicAuthAccessControlFactory
pinot.broker.access.control.principals=admin,user
pinot.broker.access.control.principals.admin.password=verysecret
pinot.broker.access.control.principals.user.password=secret
pinot.broker.access.control.principals.user.tables=myUserTable,myOtherUserTable

Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[x] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes
Added support for an optional HTTP basic auth provider to pinot-broker, which enables user- and table-level authentication of incoming queries.
Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document

Codecov Report

Merging #6552 (e79b1f2) into master (1beaab5) will decrease coverage by 1.41%.
The diff coverage is 60.60%.

@@            Coverage Diff             @@
##           master    #6552      +/-   ##
==========================================
- Coverage   66.44%   65.03%   -1.42%
==========================================
  Files        1075     1337     +262
  Lines       54773    65871   +11098
  Branches     8168     9610    +1442
==========================================
+ Hits        36396    42841    +6445
- Misses      15700    19968    +4268
- Partials     2677     3062     +385

Flag
Coverage Δ

unittests
65.03% <60.60%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/pinot/broker/api/resources/PinotBrokerDebug.java
0.00% <0.00%> (-79.32%)
:arrow_down:

...pinot/broker/api/resources/PinotClientRequest.java
0.00% <0.00%> (-27.28%)
:arrow_down:

...ot/broker/broker/AllowAllAccessControlFactory.java
71.42% <ø> (-28.58%)
:arrow_down:

.../helix/BrokerUserDefinedMessageHandlerFactory.java
33.96% <0.00%> (-32.71%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ava/org/apache/pinot/client/AbstractResultSet.java
66.66% <ø> (+9.52%)
:arrow_up:

...n/java/org/apache/pinot/client/BrokerResponse.java
100.00% <ø> (ø)

.../main/java/org/apache/pinot/client/Connection.java
35.55% <ø> (-13.29%)
:arrow_down:

...n/java/org/apache/pinot/client/ExecutionStats.java
15.55% <ø> (ø)

...inot/client/JsonAsyncHttpPinotClientTransport.java
10.90% <ø> (-51.10%)
:arrow_down:

... and 1200 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ff276...e79b1f2. Read the comment docs.

re the first comment (which I somehow can't respond to inline):
.map(_principals::get) is fine if the key, i.e. the token, is null. There's even a unit tests for this.


feat: add metadata service integration tests

Test coverage for the metadata service component. Necessary in order to have some certainty of not breaking basic functionality with future code changes. This branch depends on changes of #145, and is a prerequisite for considering merging of #144

configures metadata service test setup and teardown
adds basic business logic test coverage to metadata service api (CREATE, GET, LIST, HEARTBEAT) testing both the api responses, and that data is stored in DB.

Note: covers the metadata primary key constraints behavior of current master which does not allow duplicate entries. test_metadata_post will break, and require updating once #30 is merged.
TODO:

[ ] rebase from master after #145 is introduced, or alternatively merge this onto #145

metadata api test coverage:

[x] flows
[x] runs
[x] steps
[x] tasks
[x] artefacts
[x] metadata

will these tests be runnable using github actions? it seems like it will require a postgres db to be running

will these tests be runnable using github actions? it seems like it will require a postgres db to be running

Eventually yes and we already have this workflow at ui branch: https://github.com/Netflix/metaflow-service/blob/ui/.github/workflows/test.yml#L49
Here you can find the past runs https://github.com/Netflix/metaflow-service/actions/workflows/test.yml
For local test runs we have a separate PR https://github.com/Netflix/metaflow-service/pull/145 with docker-compose.test.yml which takes care postgres dependency


Investigate alternatives to password grant access_tokens for IDM access from IG

See: https://github.com/SecureApiGateway/secure-api-gateway-ob-uk/pull/427
The IG ClientCredentialsOAuth2ClientFilter behaviour is being overridden for IDM access_tokens by using password grant flow.
It appears that the reason for this is that to get an IDM access_token we need to have an identity (subject) in addition to a client. Therefore, client_credentials alone is not sufficient to get a token.
Improving this would allow us to stop using Password grant (which is being removed in OAuth2.1), and potentially allow us to stop having to create an identity as part of the SAPI-G platform config

Still valid? Linked PR is merged

Yes, the PR highlights where the issue is

JWT profile for OAuth 2.0 authorization grant seems to be the best solution to avoid using the password_grant.
Docs:

https://www.rfc-editor.org/rfc/rfc7523.html
https://backstage.forgerock.com/docs/am/7.2/oauth2-guide/oauth2-jwt-bearer-grant.html
https://backstage.forgerock.com/docs/am/7.2/oauth2-guide/oauth2-jwt-bearer-grant.html#configure-trusted-jtw-issuer

We would still need to create an identity to use when accessing IDM, currently this is handled via the service_account.ig
If we set up JWT bearer support, then we can establish trust between IG and AM via signed JWTs.
A lot more configuration is needed to achieve this (compared to the password_grant). We also need to investigate if IG supports this OOTB or whether we would need to impl our own handler to produce such requests.


Adds brave-spring-beans for configuring Tracing without custom code

This adds Factory Beans so that legacy apps can configure Tracing
without writing custom code.
This is tested against https://github.com/openzipkin/brave-webmvc-example/pull/15

note: I will polish this up (ex commented out stuff) when other things land

will add top-level readme as a part of https://github.com/openzipkin/brave/issues/410


[Accessibility] Provide Links in Posts

To assist in theme selection for users of screen readers demo theme should include some hyperlinks as discovered here: https://git.habd.as/comfusion/after-dark/issues/3#issuecomment-7

With After Dark delisted for self-hosting this will be resolved elsewhere. I still encourage Hugo maintainers to address this.


E447 can't find file "sys/types.h" in path

I wrote small c code, include
#include <stdio.h>
#include <sys/types.h>

I can use gf to open the stdio.h file, but can not open sys/types.h file.  My sys/types.h locates at
/usr/include/i386-linux-gnu/sys/types.h and compiled with gcc fine.
Why spf13-vim can find my stdio.h, but not sys/types.h file?

I'd solved it with customized .vimrc.local file:
set path+=/usr/include/i386-linux-gnu


Login protocol for non-admin users

Add login protocol for authentification of non-admin users. This should be considered to avoid giving staff permissions to users that we only want so they want to vote.

Root page should redirect to this login
Login should be for non-staff and staff included
Admin login doesn't work - it requires user to be staff.

Users now can:
login -> /accounts/login/
logout -> /accounts/logout/
change password-> /accounts/password/
This needs to be referenced by other views in order to manage the user authentification


Neither extraScrollHeight nor extraHeight are not working on Android (iOS works)

I have react-native 0.37.0 and react-native-keyboard-aware-scroll-view 0.2.6, basic scrolling functionality works for me, but neither extraScrollHeight nor extraHeight works for me.
Work on iOS version, though.
I'm using it because I have buttons below input and I want to make them visible when the keyboard is present. I set extraScrollHeight to the buttons' height and it works for me on iOS but not on Android.

I have the same issue. +1 The text input lands just above the keyboard like without this module.
react-native: 0.39.0
react-native-keyboard-aware-scroll-view: 0.2.6

I think that's not the same issue, @devbriguy. Have you tried to set up android:windowSoftInputMode="adjustResize" in your manifest?

Yes. I see then it's adjusting automatically. I do however need this in another part of the app. Is it possible to toggle or override it?

+1

@devbriguy use this lib https://github.com/jr-k/react-native-android-keyboard-adjust

@lesniakania I'm super busy ATM, will try to work on this asap.

@lesniakania if you feel you can investigate and send a PR, that would be awesome too :)

I removed android:windowSoftInputMode="adjustResize" and same result as before. I have both props in-use.

@alvaromb I already checked the Keyboard code in RN, sadly it only emits keyboardDidShow and keyboardDidHide events. So our code never be called when the Keyboard shows and hides. Is there any particular reason that you choose keyboardWillShow and keyboardWillHide event?

@Swordsman-Inaction those events were the only ones available when I developed the component. Do you wanna change them and check if that solves this issue?

@alvaromb
First, we can use keyboardDidShow and keyboardDidHide events on iOS, but the animation is much slower than before since it takes more than 500ms to emit those events after the Will* events are emitted. Even I decreased the _KAM_KEYBOARD_OPENING_TIME from 250ms to 0ms, it's still slow to show the Keyboard. So the solution here is still use Will* events on iOS and use Did* events on Android.
Second, you wrote the UIManager.viewIsDescendantOf thing for iOS, right? But Android doesn't have this, so it doesn't work on Android which causes the error. I will try to implement this method on Android first, then get back to this issue.

Hi @Swordsman-Inaction!

So the solution here is still use Will* events on iOS and use Did* events on Android.

OK.

Second, you wrote the UIManager.viewIsDescendantOf thing for iOS, right? But Android doesn't have this, so it doesn't work on Android which causes the error

Yes, I wrote that function on the react-native repo: https://github.com/facebook/react-native/pull/7876. It's only available on iOS (sorry, I was an iOS developer before, I don't have Android experience). The solution would be to send a PR to the react-native repo to add that function into the Android code, which I believe it should be easy to do because the layout methods I based on should be in Android too.
Ping me if you need further help.
Many thanks for your work!

Should work with the latest release https://github.com/APSL/react-native-keyboard-aware-scroll-view/releases/tag/v0.3.0

I'm encountering the same issue using the 0.3.0
Do you still see the problem too @lesniakania or others ?

I'm getting this on 0.4.1 on RN 0.49. extraScrollHeight has no effects on Android.

Ping @Swordsman-Inaction

@luco
Could you please provide more detail?
Did you set enableOnAndroid to true?

@luco android:windowSoftInputMode needs to be adjustPan

I really fail to understand the logic of even having that enabledOnAndroid prop, and worse, it is false by default.


fix

Changed "bignum" to "cl:bignum".

What kind of problem do you see with this bignum declaration (and with which Common Lisp implementation/version)?


underflow

It's pretty easy to trigger arithmetic underflow using the new_starting_at api:
let slab = Slab::<u32, usize>::new_starting_at(1, 1);
assert_eq!(slab.get(0), None);

Thanks


BUG: Strings like '2E' are incorrectly parsed as valid floats

A work colleague, David Chase, encountered some surprising behaviour, which can be reduced to the following.  The data-frame
DataFrame({'x': [2.5], 'y': [42], 'z': ['2E']})

does not round-trip correctly.  The string '2E' is interpreted as a valid float, but it should not be (according to man strtod(3), which seems a reasonable spec).
This PR changes the three variants of xstrtod() to reject a string where no digits follow the 'e' or 'E', and includes tests for this case.

Thanks for feedback.  Will tidy up the following:

move test to io/test_parsers.py
use self.read_csv in test
remove redundant assertion on behaviour with '2E3'

and force-push new commits.

New commits address feedback from @jreback.  Can squash or otherwise re-order if preferred, but for review, separate commits seemed cleaner.

pls add a whatsnew note (bug fixes)

Have created an issue (#12237), to have something to refer to in the whatsnew entry.

@bennorth you didn't actually have to create an issue as you can just refer to the PR number itself (but ok)

(Ah, OK, sorry.  I saw that the other entries in whatsnew did refer to issues so followed that pattern.)

Should have seen that one --- there is no self in that top-level function.  Will revert.

(Build/test failure matches failure in current master and appears unrelated to this change.)

ok, couple of small comments. pls squash. ping when green.

(Rebased on master and squashed.)

(Force-push of b51a35a is fresh re-base onto master.)

@jreback Pinging as requested --- squashed, rebased, and build is green.

@bennorth lgtm. But have a look here: https://github.com/pydata/pandas/pull/10133
maybe move your tests near this one (if they are not there now)
why did this other issue not fix the problem?

Yes, it does make sense to move the new tests near related ones.  New commit on the way.  Thanks.

Recent build failures were in master and unrelated.  Have just force-pushed newly-rebased commit.

thanks @bennorth

Thanks!