Fix broadcast error on multi-node training with ZeroStage3 and TensorParallel=2

Hi, while enabling TensorParallel=2 and ZeroStage3 on multi-node training for Megatron-DeepSpeed, I encountered error on this bcast
RuntimeError: Global rank 0 is not part of group <torch.distributed.ProcessGroupCCL object at 0x14e99ef52c30> raise RuntimeError(f"Global rank {global_rank} is not part of group {group}")
In TensorParallel=2, ds_process_group would be [0, 2, 4, ... ] and [1, 3, 5, ...] which does not contain global rank 0. So I believe this bcast should use local rank 0 inside current self.ds_process_group.

@YizhouZ, thanks for this PR. Apologies for the delay as we resolve some CI issues. We plan to merge soon.

@YizhouZ, thanks for this PR. Apologies for the delay as we resolve some CI issues. We plan to merge soon.

Thanks!

@YizhouZ, do you know why this is not a problem for zero stage 1 or 2?

@YizhouZ, do you know why this is not a problem for zero stage 1 or 2?

Hi @tjruwase only stage 3 would trigger this post_init_method, others would not go into this place as far as my test result shows.

@YizhouZ, thanks for confirmation. That makes sense since TP>1 is not very well tested with ZeRO stage 3. This certainly shows a gap in our unit tests.
I have one request. Could you please add a TODO in here for integrated testing of TP and ZeRO 1/2/3? Thanks!

@YizhouZ, thanks for confirmation. That makes sense since TP>1 is not very well tested with ZeRO stage 3. This certainly shows a gap in our unit tests.
I have one request. Could you please add a TODO in here for integrated testing of TP and ZeRO 1/2/3? Thanks!

Added.

@tjruwase Could you please help me trigger the CI? My CLA was reviewed and passed today. Thank you!

@tjruwase  seems like the post_init causes issue with stage 1 as well .(after some tests).

@abhilash1910, I don't think that is possible since this code path is only for zero stage 3. Can you please share more details of what you are seeing, such as a stack trace?

I think so too, this should be only in stage 3. However sometimes I do see a hang sometimes in stage 1 (not the same trace or crash).
I will revalidate on this and let you know @tjruwase .

Hi @tjruwase, it seems the current CI failure is not triggered by my changes, I see the previous check is passed but the latest one is failed and the difference is only readme file. And the error msg seems unreasonable and not related to my part:
______________________ TestPipeCifar10.test[topo_config0] ______________________ [gw3] linux -- Python 3.8.8 /tmp/actions-runner/_work/DeepSpeed/DeepSpeed/unit-test-venv/bin/python Worker 0 hung. ----------------------------- Captured stdout call ----------------------------- [2023-05-08 20:11:57,287] [INFO] [comm.py:622:init_distributed] Initializing TorchBackend in DeepSpeed with backend nccl ----------------------------- Captured stderr call ----------------------------- [W ProcessGroupNCCL.cpp:1569] Rank 0 using best-guess GPU 0 to perform barrier as devices used by this process are currently unknown. This can potentially cause a hang if this rank to GPU mapping is incorrect.Specify device_ids in barrier() to force use of a particular device. [W ProcessGroupNCCL.cpp:1569] Rank 3 using best-guess GPU 3 to perform barrier as devices used by this process are currently unknown. This can potentially cause a hang if this rank to GPU mapping is incorrect.Specify device_ids in barrier() to force use of a particular device. [W ProcessGroupNCCL.cpp:1569] Rank 1 using best-guess GPU 1 to perform barrier as devices used by this process are currently unknown. This can potentially cause a hang if this rank to GPU mapping is incorrect.Specify device_ids in barrier() to force use of a particular device. [W ProcessGroupNCCL.cpp:1569] Rank 2 using best-guess GPU 2 to perform barrier as devices used by this process are currently unknown. This can potentially cause a hang if this rank to GPU mapping is incorrect.Specify device_ids in barrier() to force use of a particular device. Process Process-4: Traceback (most recent call last):   File "/opt/conda/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap     self.run()   File "/opt/conda/lib/python3.8/multiprocessing/process.py", line 108, in run     self._target(*self._args, **self._kwargs)   File "/tmp/actions-runner/_work/DeepSpeed/DeepSpeed/tests/unit/common.py", line 195, in _dist_init     dist.barrier()   File "/tmp/actions-runner/_work/DeepSpeed/DeepSpeed/unit-test-venv/lib/python3.8/site-packages/deepspeed/comm/comm.py", line 120, in log_wrapper     return func(*args, **kwargs)   File "/tmp/actions-runner/_work/DeepSpeed/DeepSpeed/unit-test-venv/lib/python3.8/site-packages/deepspeed/comm/comm.py", line 395, in barrier     return cdb.barrier(group=group, async_op=async_op, device_ids=device_ids)   File "/tmp/actions-runner/_work/DeepSpeed/DeepSpeed/unit-test-venv/lib/python3.8/site-packages/deepspeed/comm/torch.py", line 214, in barrier     return torch.distributed.barrier(group=group, async_op=async_op, device_ids=device_ids)   File "/tmp/actions-runner/_work/DeepSpeed/DeepSpeed/unit-test-venv/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 2526, in barrier     work = group.barrier(opts=opts) RuntimeError: CUDA error: out of memory CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect. For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Could you please check it? Thank you!

@YizhouZ, apologies for the merging delay. I am confident that the CI issues are not due to your PR but due to infastructure problems. I will ensure this PR is merged, so no need to worry about it. Sorry once again for the delay, we really appreciate your contribution.

Hello，I have other questions, in partition_parameters.py,  has funcation apply_with_gather(), there are similar codes of dist.broadcast (param.data, 0, group = param.ds_process_group), isn't this okay?


Work Item 3610903 (#179)

Work Item 3610903

Work Item 3610903
Updates for new restrictions on mapSize limitations for streetView maps when using a basic key (as opposed to an enterprise key)

Update get-a-static-map.md

Update get-a-static-map.md

Docs Build status updates of commit 2c92e75:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/rest-services/imagery/get-a-static-map.md
:warning:Warning
View
Details

BingMaps/rest-services/media/BallardStreetImage.jpg
:white_check_mark:Succeeded
View

BingMaps/rest-services/imagery/get-a-static-map.md

Line 10, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'bing-maps'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Animation lags (skips frames) when moving to the background and back to the foreground

Overview
I've noticed that when going to another tab or another window, the animation starts to lag and skip frames (I'm using Mozilla Firefox). The lag (skipped frames) continues even when the animation loops.
Labels

[ ] Add the Type: Bug label to this issue.

@Rapsssito can you share the player usage code in this case ?

@theashraf, the animation I am using is the same that I provided in #175 (which is also the same I was using when I discovered #174).

@Rapsssito, I'm unable to replicate this issue, but I can suggest a few enhancements that might help in this case.
You may want to consider disabling frame interpolation. Here's how you can modify your code:
import { DotLottie } from 'https://cdn.jsdelivr.net/npm/@lottiefiles/dotlottie-web/+esm';
const canvas = document.getElementById('dotlottie-canvas');
const player = new DotLottie({
    autoplay: true,
    loop: true,
    canvas,
    src: canvas.getAttribute('data-src'),
    // Disable frame interpolation for better performance, this will make the player not render the in-between frames
    useFrameInterpolation: false,
});

It would also be helpful if you could run performance profiling and download the profiling data. This would allow me to better investigate this issue.

@theashraf, thanks for the answer. However, using the changes you proposed in #174, it doesn't seem like the issue is still occurring. I will close this issue for now.


Send Amount screen is shown instead of “Sending” screen after scanning QR code from “Please confirm your contact’s account” screen

Frequency: 100%
Repro App version:  Test Flight build Valora app build  v1.0.0 (17) , Android Valora Mainnet build v1.0.0 (16)
Does not Repro on: Android Valora Mainnet build v1.0.0 (11)
Repro on device: iPhone 7+ (13.3.1), Google Pixel Xl (8.1)
Test Account:
User A :<PHONE_NUMBER>/ Backupkey.
Send secure flow user B : Backup Key:<PHONE_NUMBER>.
Pre-condition:
Make sure user B should have two accounts with one number to trigger a send secure flow.
Repro Steps:

Launch the Application and sign in with user A.
Tap on Send button.
Enter User B number.
Enter Amount on Send button.
Tap on Send button.
Tap on Scan QR code from “Please confirm your contact’s account” .
Scan user B QR code and observe.

Current Behavior: Send Amount screen is shown instead of “Sending” screen
Expected Behavior:  Sending screen should be shown
Investigation: Issue does not repro when the user enters a 4 digit account number.
Impact: User may feel frustrated that they need to enter an amount again.
Attachment:Android_QRCodeRedirectionIssue.mp4 (Bug observed at 20 sec)

Closed by #5090

@tarikbellamine  I have verified issue on latest build Test flight build v1.2.0 (25) , Android internal build 1.2.0(1004294313) and found that issue fixed as now user is redirect to Sending screen after scanning the QR code from Please confirm your contact's account.
Devices used: Google Pixel Xl (8.1) , IPhone 6+ (12.4.5)


chore(package): update npm-template-sync to version 8.5.38

Pull Request Test Coverage Report for Build 2211

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.509%

Totals

Change from base Build 2210:
0.0%

Covered Lines:
361

Relevant Lines:
375

💛  - Coveralls


[FEATURE REQUEST] Add parameter for separation for Row and Columns

Use case

Very often I need to add some distance between widgets in a row or a column and for this I need to insert some SizedBoxes widgets.
Proposal
It would be amazingly useful if Column and Row would have a parameter for adding some space between the children. Inspiration comes from Wrap widget which has runSpacing and spacing parameters.

Duplicate of #55378


cleaned up master branch of mock observables

Cleaned up code to make a better master branch.  I will work in developer branches for now on.
Delta Sigma Calculation is working.  It is slow.

@duncandc - Do you know what is causing the test suite to fail? Is it failing on your local machine?

It doe snot fail on my machine.  Not sure what the problem is.

Ok, try and look into it, will you? @eteq has lots of experience with Travis, maybe ask him if there are typical causes of Travis fails that don't show up locally


[DOCS] Add latest bug fix to 8.0.0-rc1 release notes

Adds an entry for #1870 to the 8.0.0-rc1 release notes, which was missing.

@masseyke, can you provide a 👍 before I merge this?

This is not in the 8.0 branch -- it's only in master.

@masseyke, you're right on this one -- @pugnascotia thought that there might be a missing release note for rc1, but the PR that I included was only for 8.1.0. I'm going to close this without merging.


Assets accessible in header & footer?

It seems that files (images, stylesheet), passed in via the files argument, are correctly accessible in index.html but not in header.html or footer.html.
How can I embed files in the header or footer?
Expected Behavior
File accessible in index.html are accessible to header and footer as well.
Current Behavior
It currently doesn't seem to be able to read those files.
Your Environment

Version used: thecodingmachine/gotenberg:5 (Docker)

Could you share your header.html or footer.html?
I suspect this is a Chrome limitation...

In my tests the header and footer are like:

        <meta charset="utf-8">
        <link rel="stylesheet" type="text/css" href="styles.css">

Hello world!

where in styles.css there's:
.red {
    color: red;
}

and what I get is this:

Ok I'm pretty sure this is indeed a limitation of Google Chrome.
I've tried to load an image from an URL, it did not work.
For stylesheets, best option would be using the style tag instead.

Is this considered expected behaviour (wontfix) or a bug then?

You can insert image in the footer/header if you use a Base64 image inline
IE 👍

The colors are working too but it seems that you can't use the color : white ,  because you can't apply any css background in the footer or header... that's very unfortunate


Add the error's message to the APIException

This PR adds the error message returned by the App Store server to the APIException class.
As each error returned by the App Store server contains both an errorCode and an errorMessage, it might be useful to attach the errorMessage to the APIException as well.

Thank you for the submission, this was included in a series of PRs across all four repos aimed at allowing handing unknown cases better. Specific PR series
https://github.com/apple/app-store-server-library-java/pull/60
https://github.com/apple/app-store-server-library-python/pull/52
https://github.com/apple/app-store-server-library-swift/pull/21
https://github.com/apple/app-store-server-library-node/pull/48


cannot import name mapping from collections Python 3.10 (Fix)

When installing on Python 3.10 There is an issue when importing Mapping from collections.
I've fixed it locally for my project, you just need to change line 30 in rumps.py from:
from collections import Mapping, Iterable

To
from collections.abc import Mapping, Iterable

Actually the problem is already fixed on latest version but it is not on the pypi.
See https://github.com/jaredks/rumps/issues/173


How to deal with "Enable Visual Debugging = true, but components is not showing in DontDestroyOnLoad"?

https://github.com/atkdefender/Pic/blob/main/pic20201124122017.jpg

@atkdefender
I think problem was because you had trouble when registering all context observers
Solution only one, get some report via adding log in catch section at Contexts
e.g. } catch(System.Exception e) {Debug.LogError(e);}
After u got a report you can handle problem

related #967

After adding these Debug.LogErrors I'm getting the following exception:
UnityEngine.UnityException: get_isPlaying is not allowed to be called from a MonoBehaviour constructor (or instance field initializer), call it in Awake or Start instead. Called from MonoBehaviour 'SceneLoader' on game object 'SceneLoader'.
See "Script Serialization" page in the Unity Manual for further details.


micro: port op BATCH_MATMUL from lite

@tensorflow/micro
This issue tracks my work porting operator BATCH_MATMUL from lite to micro.
The port will be submitted in a number of PRs. Here's a rough flight plan per @advaitjain and @petewarden:
PR 1: Extract the code for parsing the op from a flatbuffer out of ParseOpDataTfLite in tensorflow/lite/core/api/flatbuffer_conversions.cc into a standalone function that can be called from micro's op resolver
PR 2: Extract the reference implementation out of tensorflow/lite/kernels/internal/reference/reference_ops.h into its own header which can be included without dragging in reference_ops.h's dependences
PR 3: Copy operator from lite to micro making minimal changes and not including in the build
PR 4: Delete extra code from the micro copy of the operator
PR 5: Port micro copy of operator as necessary and add a corresponding test

Closing, since this is no longer active.


🚀 [Feature]: Export db option to reuse for 3rd modules.

Feature Description
https://github.com/gofiber/storage/blob/main/redis/redis.go
Storage module is a pure operation api.
s.Get,Set,Delete...
How about export s.Db redis.Client option for 3rd modules.
Otherwise it would have to create a extra new client instance.

@jsonchou We plan on allowing re-using connections as part of #967

https://github.com/gofiber/storage/issues/967


Add watch= argument to deprecate validator-update

Prior to this change, we mixed a virtual event validator-update to help track properties. This works currently because the validation workflow allows ember to exercise the validator and consume tracked properties.
We will be doing a big refactoring which will break this assumption requiring better and more explicit control on dependent properties.
This change introduces a new API and deprecates the old one. It will be a step towards the 2.0.0 release.
This PR should precede #10

I looked into this and helpers don't seem to cause the same non-tracking behavior that (fn) did. I added some tests in PR #10 to cover this use case. I have a feeling the oddness of not updating the modifier (or in your case validation on argument changes) is because the fn helper creates a lazy system which doesn't get consumed by the modifier in time.
This is fixed with the watch= or use of custom helpers instead of the fn helper in PR #10
Thus, this PR is valid and should make it into a minor release to that the upgrade to a major release after #10 is easy to migrate to.

When I tried this with a custom validator helper it autotracked. When I did this with the (fn …) it did not autotrack requiring my watch= hack.

Superseded by #14


Run Inference on cluster

Bash scripts to run tracking on single video #186
Bash script to loop over all escape events for #213
Guide on how to run tracker on cluster
Have tested this on cluster pointed to this branch, these bash scripts have been edited to pointed back to main

Codecov Report
Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@aff5c23). Learn more about missing BASE report.

Files
Patch %
Lines

crabs/detection_tracking/inference_model.py
0.00%
50 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage        ?   38.70%
=======================================
  Files           ?       20
  Lines           ?     1279
  Branches        ?        0
=======================================
  Hits            ?      495
  Misses          ?      784
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Closing because superseded by #251, which incorporates the changes of #253 (and previously #241)


CDN URL undefined with --nocdn option

I get this output with --nocdn option.
CDN URL: https://undefined/
CloudFront is super slow, this link should be valid in next 10 minutes or so.

@stojanovic
Hi, I fixed this problem. So please confirm the branch I made.
https://github.com/stojanovic/scottyjs/pull/37


Update config-proxy.html.md.erb

Clarify no_proxy instructions so that customers do not block access to credhub when they set up proxy variables for their CF applications.
#163439742
#170880034

Thanks @julian-hj


autorotate timer messed up after pauseonhover

With auto-rotation, when you mouseover a tab (or main banner area), the rotation pauses, and when you mouseleave (move the mouse away), the rotation unpauses and continues after 1 second.
However, if you keep doing this mouseover and mouseleave over the tabs (or main banner area) continuously and rapidly, the timer will all be messed up and the rotation will no longer follow the set "delay", but rotate at a random time.

Hi, the issue with the timer has been fixed at version 1.4.5, thanks.

Hi, Thanks for the fix. However, I found that the problem still persists if I do the rapid mouseover/mouseleave BEFORE the first rotation happens.  It can be replicated more easily if you set a higher delay.

Fixed at version 1.4.6.
;-)

The timer issue is fixed, but pauseonhover still doesn't work on the very first rotation - hover on the very first slide/tab before it rotates to the second one.  Only happens once after initialization.

At version 1.4.7 the rotation stops on the first tab.


[Plugin] CircleCI: tests

Several groups of tests should be implemented:

[ ] custom hooks
[ ] API integration
[ ] UI components

Hi! I am new to the repo, but I would like to work on this issue (adding tests to the CircleCi plugin). I plan to inspire myself by a test setup from some other plugin to keep consistency.

@kernelgonnapanic Thanks, and welcome! :grin:


codec: UNKNOWN library not start any stream

I got this messages from serial monitor:
0:18:00.977 -> Simple vs1053 Streaming example.
20:18:03.259 -> wifi connected - starting decoder
20:18:06.519 -> decoder running - starting stream
20:18:06.566 -> codec: UNKNOWN
I tryed several url:
http://streams.regenbogen.de/rr-eurodance-128-mp3
http://mp3.ffh.de/ffhchannels/hqeurodance.mp3
http://mp3.hitradiort1.c.nmdn.net/rt1eurodancewl/livestream.mp3
http://<IP_ADDRESS>:8000/stream/1/
I have used expressif esp32 board with vs1053, set these pins:
#define VS1053_CS     5
#define VS1053_DCS    16
#define VS1053_DREQ   4

Hmm not really sure. All the stream urls above work ok for me.
I think you are trying the example with only changed pins?

I just compiled with esp32 core version 2.0.3 and then I can reproduce your problem.
With 2.0.2 it works for me. Could you please try to compile and flash with 2.0.2?

You have right, thats was the problem, now working well:) You need notice this in description to prevent this issue or check what is the problem with the new core.
Thank you for investigation, have a nice day.

Just a question - this is not issue, because im not pro developer, how can i display on serial monitor just one function, not the full function loop? example if i want see just the audio_showstreamtitle?

Thanks for checking out the problem. Something has changed between 2.0.2 and 2.0.3.
For now just use 2.0.2, until I debug this issue.
About audio_showstreamtitle, audio_showstation and audio_eof_stream:
You can use these routines, but you don't have to.

I try simple make this, using your included example, but im unable to compile.
I dont know what a parameter i need give for audioshowstreamtitle:

#include <VS1053.h>
#include <ESP32_VS1053_Stream.h>

#define VS1053_CS     5
#define VS1053_DCS    16
#define VS1053_DREQ   4

ESP32_VS1053_Stream stream;

const char* SSID = "xxxx";
const char* PSK = "xxxx";

void setup() {
    Serial.begin(115200);
    WiFi.begin(SSID, PSK);

    while (!WiFi.isConnected())
        delay(10);

    SPI.begin();
    stream.startDecoder(VS1053_CS, VS1053_DCS, VS1053_DREQ);
    stream.connecttohost("http://mp3.ffh.de/ffhchannels/hqeurodance.mp3");

}

void loop() {

   audio_showstreamtitle();   //?

}

Possible to run in this form and/or impossible or i have forget something?

The three audio_xxx functions are called automatically when stream data becomes available. (And you have an instance of that particular function)
The data becomes available through const char* info.
If you want to use that data later on in your program you will have to save it.
In the example below the station name is saved as String currentStation and can be used throughout the rest of the code.
And to proccess the stream stream.loop() has to be called every couple of milliseconds.
#include <VS1053.h>
#include <ESP32_VS1053_Stream.h>

#define VS1053_CS     5
#define VS1053_DCS    16
#define VS1053_DREQ   4

ESP32_VS1053_Stream stream;

const char* SSID = "xxxx";
const char* PSK = "xxxx";

String currentSong = "";

void setup() {
    Serial.begin(115200);
    WiFi.begin(SSID, PSK);

    while (!WiFi.isConnected())
        delay(10);

    SPI.begin();
    stream.startDecoder(VS1053_CS, VS1053_DCS, VS1053_DREQ);
    stream.connecttohost("http://mp3.ffh.de/ffhchannels/hqeurodance.mp3");

}

void loop() {
    stream.loop();
}

void audio_showstreamtitle(const char* info) {
    currentSong = info;
    Serial.printf("currently playing: %s\n", currentSong.c_str());
}

This loop call method was for me new, never seen before.

Also this sream.loop() dont call any other functions what is not part of this library.
I have checked also the sound (ealier i have just want see the decoded url) and i need report, i dont have sound from the vs1053 jack decoder. Please check this too if you have time.

It looks like a bug in HTTPClient  -or some underlying code- causes this issue.
The http.begin() call has some weird behaviour after setting http.setConnectTimeout() as in timing out before the set time has elapsed.
See https://gitter.im/espressif/arduino-esp32?at=6288f01367db9a59dbdde996

And should be fixed 26 days ago in master with espressif/arduino-esp32#6633

Ok thanks for the information, i will re check later.

If im good understand, after the fix, we can use your library with the new esp32 core too, but we still need wait for the fix ,,official".
Currently i have tested your library working well with esp32 core 2.0.2, i have just a question, and notice/small issue
What if somebody try play a bad url? There is any error handling? Or normaly simple will not start the stream nad i can catch this issue with stream.isRunning() and if i dont receive station name?
And i have noticed durint testing trouble with handling special characters - not typical use case, but can generate weird result if somebody try play not only english streams, example in my case hungarian.  I dont know library can handle UTF8 characters, but currently if showstation or streamtitle have spacial characters like áéűúőöüóí and/or uppercase variants user will receive like this:
TOP FM r⸮di⸮ >> 90s, 00s what looks originaly TOP FM rádió >> 90s, 00s.
I dont know this need hard work to handle or do you want handle this, but i dont opened currenly new issue.

also a link for the special character using station:
http://live.topfm.hu:8000/radio.mp3
another one:
http://live.topfm.hu:8000/comedy.mp3
Here showstation have special characters.

What if somebody try play a bad url? There is any error handling? Or normaly simple will not start the stream and i can catch this issue with stream.isRunning() and if i dont receive station name?

connecttohost() has a boolean result you can check. Or use isRunning(). Or currentCodec().

And i have noticed durint testing trouble with handling special characters - not typical use case, but can generate weird result if somebody try play not only english streams, example in my case hungarian. I dont know library can handle UTF8 characters, but currently if showstation or streamtitle have spacial characters like áéűúőöüóí and/or uppercase variants user will receive like this:

The character encoding upstream can be a real pita.
I 'solved' that issue with https://github.com/CelliesProjects/eStreamPlayer32_VS1053/blob/main/percentEncode.h.
There are probably better solutions you can find on github.

Thank you for the help:) If im add this header + in code:
const String urlEncode(const String& s) {
    //https://en.wikipedia.org/wiki/Percent-encoding
    String encodedstr{""};
    for (int i = 0; i < s.length(); i++) {
        switch (s.charAt(i)) {
            case ' ' : encodedstr.concat("%20");
                break;
            case '!' : encodedstr.concat("%21");
                break;
            case '&' : encodedstr.concat("%26");
                break;
            case  39 : encodedstr.concat("%27"); //39 == single quote '
                break;
            default : encodedstr.concat(s.charAt(i));
        }
    }
    ESP_LOGD(TAG, "encoded url: %s", encodedstr.c_str());
    return encodedstr;
}

and calling url with so, request encode the url:
stream.connecttohost(urlEncode(station[currentstation].url));
im receiving same non encoded stationname:)
But as workaround (by my wifi radio), im just simple adding manual the station name (using Serial monitor input feature) and im display this without using the stationname decoding. The oled driver what im using have special character support and so looking better.

i have continued testing my project also the vs1053 stream library features, now with different file types like ogg, aac and special type flac/ogg. Whatever normal ogg stream i try, i get false to streamisrunning and codec: unknow and code fail to play ogg streams, no sound.
Tested normal ogg streams:
http://retro.dancewave.online/retrodance.ogg
https://icast.connectmedia.hu/4765/mr2.ogg
https://www.jazzradio.hu:8000/jazzradio_192.ogg
If i try flac ogg (maybe not supported), library detect codec: ogg and streamisrunning true but no sound.
Flac type ogg stream:
http://retro.dancewave.online/retrodance.flac.ogg
Another question is the vs1053 patches, im not sure, because im not developer, your library load all of these using the standard vs1053?
I just ask this because i saw a nice feature using vs1053 library by one of the updated Edzelf webradio:
[(https://github.com/blotfi/ESP32-Radio-with-Spectrum-analyzer/blob/master/src/Esp32_radio.cpp)]
[(https://github.com/blotfi/ESP32-Radio-with-Spectrum-analyzer/blob/master/src/patches.h)]
Here i just thinked about will be a nice feature use this spectrum analyser ,,patch" but im not sure possible to use with your library/ and how is possible to use.. This patch making possible to somehow read the spectrum bands during decode stream and this can be displayed using example OLED display rectangle draw feature.
I see included a patches header file and in main code calling this:
// spectrumAnalyzerAppl1053b-2.plg
// results in XRAM 0x1810 .. 0x1877
#define BASE 0x1810
void VS1053::getBands()
{
    write_register(SCI_WRAMADDR, BASE+2);
    bands = read_register(SCI_WRAM);
    write_register(SCI_WRAMADDR, BASE+4);
    for (uint8_t i = 0; i < 14; i++) {
        uint8_t val = read_register(SCI_WRAM);
        /* current value in bits 5..0, normally 0..31
        peak value in bits 11..6, normally 0..31 */
        uint8_t cur1 = val & 31;
        uint8_t cur = (cur1*curvol)/30; // big bars
        if ( cur < 0 ) cur = 0;
        else if ( cur > (Spectrum_hy-4) ) cur = Spectrum_hy-4;
        spectrum[i][0] = cur;
    }
}

Maybe i was blind, in example was not included the bitrate display, but was included in readme section:)
I have tryed somehow make usable the spectrum analyser plugin for vs1053, but with my programing skill almost impossible. because i saw only one example, im not sure this will be working.
Also i have make a mod on library localy, i have found a command in original vs1053 library, what with users possible to set bass/trebble but currently not in using in vs1053 stream:
if (!_vs1053) {         ESP_LOGE(TAG, "could not initialize vs1053");         return false;     }     _vs1053->begin();     _vs1053->loadDefaultVs1053Patches();     _vs1053->switchToMp3Mode();     uint8_t rtoneCustom[4] = { 7, 15, 13, 8 } ;	     _vs1053->setTone(rtoneCustom); //bass treble cutom values      setVolume(_volume);     return true; }


Tooltips on tables

When trying to use bootstrap tooltip on td elements(DataTables), the tooltip is creating a new column and pushing the data to right. This could be even an issue with dataTables but a google search said that dataTables generally work woth tooltips? What is the problem?

use this option to work normally in table:
container: 'body'
or as data attr like this:
data-container="body"


Bug associated with duckduckgo redirection

Ok, I'm totally puzzled. I'm playing with the scoring function in scorePages.py, and the following is happening.
I typed in the following three queries, in this order:
"python string replace" -- got results
"python unicode" -- no result, redirected to duckduckgo
"video games with animals" -- got results page but with the results of the first query -- 'python string replace'
What gets me is that if I modify the scoring function (change the threshold, etc), I can stop this effect. Regardless... it seems some variable is holding search results longer than it should...

I couldn't reproduce this, tried the queries in order.

"python string replace" -- got results
"python unicode" -- no result, redirected to duckduckgo
"video games with animals" --  got proper results

Right, if I use the original scoring function, it doesn't happen. What confuses me is that I'm only changing stuff in the scoreDocs function in scorePages, without touching the best_urls variable. My guess is that I've done something horribly wrong with a global variable.
Anyway, I suggest I make my changes to scoreDocs and open a pull request so you can have a look at it...

Well, with my final scoring function, I don't get this bug anymore (although I'm only changing thresholds etc). So there is definitely something dodgy going on but I don't know what. Shall I close this for the minute, or wait a bit just in case the bug reappears?

I'm also not getting this bug. So I'm closing the issue. if it reappears we can open it again.


[6.1] Fix an infinite loop if a conflict marker is found but it's not at the start of a new line

Explanation: The parser would enter into an infinite loop when a closing conflict marker was not at the start of a line. Until I found the underlying issue, I was looking at performance issues with conflict marker lexing and was able to improve the parsing time of a file consisting of only conflict markers by 2x (not that it matters much in practice but doesn’t hurt either). That’s included in a second commit.
Scope: Lexing of conflict markers
Risk: Low
Testing: Added a test case / manually tested performance of conflict marker parsing
Issue: rdar://137746823
Reviewer:   @DougGregor @rintaro on https://github.com/swiftlang/swift-syntax/pull/2899

@swift-ci Please test


Minimum content in API

Couple of tickets referring to content within the API and the minimum content and clarifying partcular entries. See

JIRA 520
JIRA-499
JIRA-500

IG updated to include definition of minimum content

Reviewed. All of the mentioned items in JIRA tickets included in corresponding IG chapters.


Ensure Tutorial App can be built with Android Studio Electric Eel

We want to make sure that the previous stable release is compatible with it.

@iamralpht I've taken a shot at this and I'd need a day or so to accomplish this.
Problem 1 is that Electric Eel only supports AGP 7.4.2, not 8, which is what everything currently uses. So the assumed easy fix is to pin the Tutorial app's AGP version to 7.4.2.
But problem 2 is that the Tutorial App is relying on the build-logic subproject for some build config and for the setFigmaToken tasks. The build config is easily solved, but in order to have the setFigmaToken tasks, I would have to separate that code from the build-logic subproject into it's own plugin and publish the plugin to gMaven. I had always intended to do this at some point, after we had more than just the setFigmaToken tasks to publish as a "DesignComposeGradlePlugin", and it would only take a day or less to do this. But until that happens, the Tutorial app will only be compatible with Android Studio Flamingo.
I would like your input here.

Moving to the current iteration, since we didn't complete this in the previous.

Update from triage review -- WIP is working, and also creates a new plugin for the setFigmaToken logic. Should be in review later today with some tests on the new work.


Left sidebar is missing

Name of Defective Feature
Left sidebar
System Settings (Required)

ToolKit Version: 2.5.1
Operating System (Mac/Windows/Etc): macOS 10.13.4
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 66.0.3359.181
Other Extensions: ABP, 1Password X, etc

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":false},{"key":"AdditionalColumns","value":true},{"key":"AdjustableColumnWidths","value":false},{"key":"AutoDistributeSplits","value":false},{"key":"BetterScrollbars","value":"1"},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":true},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"ChangeEnterBehavior","value":true},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":true},{"key":"CollapseSideMenu","value":false},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":false},{"key":"CreditCardEmoji","value":false},{"key":"CurrentMonthIndicator","value":true},{"key":"CustomFlagNames","value":false},{"key":"DaysOfBuffering","value":false},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":false},{"key":"DisplayUpcomingAmount","value":false},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":"2"},{"key":"EnableRetroCalculator","value":false},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":true},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":true},{"key":"HideHelp","value":false},{"key":"HideReferralBanner","value":true},{"key":"ImportNotification","value":"1"},{"key":"IncomeFromLastMonth","value":"0"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":false},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"1"},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":false},{"key":"ReconciledTextColor","value":"3"},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":false},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"RunningBalance","value":"0"},{"key":"SeamlessBudgetHeader","value":false},{"key":"ShowCategoryBalance","value":true},{"key":"ShowIntercom","value":false},{"key":"SpareChange","value":false},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":true},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleMasterCategories","value":false},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"1"},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":false},{"key":"goalIndicator","value":true},{"key":"highlightNegativesNegative","value":false},{"key":"l10n","value":"0"},{"key":"options.dark-mode","value":false},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":false},{"key":"reports","value":false}]

Steps to Reproduce the Behavior

Load YNAB.

Expected Behavior

Left sidebar visible.
Actual Behavior

Left sidebar not visible when loading YNAB most of the time with toolkit enabled. Reloading the page makes it reappear.

can you open the  console and see if there are any errors? (cmd + option + i) on your keyboard

Looks like Stylist is an old, unsupported user styles extension? I just removed it and will see if that works.

Nope, wasn't that. I just restarted the browser and the issue is still occurring.

interesting -- that's the only errors you're seeing? I'm not seeing this with the same settings :( did this start happening after an upgrade or is this your first time using the toolkit?

Yes, that's the only error. I've been using the toolkit since maybe 2.2, and I think this started with the 2.4 update, maybe?

same happens to me.
i'm on canary tho: Version 68.0.3438.3 (Official Build) canary (64-bit)

@rictorres did this just start happening to you with v2.5.1?

to be honest i don't know. i usually use ynab from my phone.
so it can be that few versions were released in between :(

Getting this issue as well, though I don't really have the time to research it properly right now.
I was getting an Adblock Plus error (below), and refreshing fixed it... but I reenabled Adblock and wasn't able to replicate the issue (or the console error). Can't tell if that is related or not.
Console error:
Error in event handler for (unknown): TypeError: Cannot read property 'trace' of undefined
at ext.backgroundPage.sendMessage.response (chrome-extension://gighmmpiobklfepjocnamgkkbiglidom/include.preload.js:499:20)

I just ran into this using Firefox but it's related to Rollbar not being defined;

Refreshing the page produced a few more errors but the sidebar did show up.

and two more like the first screen shot.
I've never had it happen while using Chrome.

I've been seeing this issue too. I'm not 100% sure but I think it happens more when the YNAB tab doesn't have focus while loading.

Geiseku, I've noticed that also, but I can't prove it!

I don't run YNAB in a tab. I run it standalone as though it's a regular Windows program. I do run it as a tab in FF though. I'll see if I notice the same thing y'all are seeing.

I can fairly consistently reproduce this on Chrome version 67.0.3396.87 (Official Build) (64-bit) just by switching to another tab while YNAB is loading.

I just played around with this a bunch and can confirm (using the same version of Chrome on macOS) that it's switching to another tab while loading that causes the issue. It doesn't occur if I turn off the Toolkit, and I've tried turning off all extensions other than the Toolkit and I can still reproduce the bug.

@mamstergrub does it still happen if you turn off all Toolkit features related to the sidebar? e.g. collapse sidebar and import notifications

Great question, dbaldon. I turned off all of those features, and now I can't reproduce the bug. The features I was using were:

Import notifications (not currently working anyway, right?)
Budget quick switch
Hide referral banner
Account name height

I can try turning them on one at a time and see what happens.

I've submitted a PR for the import notifications feature but you're right that it is currently not working.
This sounds like it could be a timing issue. Which screen are you typically on when you load YNAB? Budget or Account?

That further reinforces my comment about the timing issue. If only I could recreate it as easily as you seem to be able to do.

Budget screen.

ok, thanks

Steps to reproduce, in case it isn't clear what Geiseku and I were talking about:

Quit and restart Chrome.
Open second tab.
Launch YNAB in second tab.
Immediately switch back to first tab and wait a few seconds.
Switch back to second tab. Sidebar is missing.

It doesn't require restarting Chrome, but it seems to happen more if I haven't loaded YNAB previously since launching the browser.

I don't think there is anything we can do about this. It's a timing issue that results in many DOM elements not being added as expected;

To get around this you can refresh the page or click your email address at the bottom of the page, go to My Account and then click the Back to Budget link.

@mamstergrub I wish there was something we could do but if the elements are there, we're "up a creek". Have you ever had this happen without the Toolkit being active? I should think it's possible but can't say for sure.

I started seeing this the past week or so.
For what it's worth, the issue has been discussed on YNAB's support forums here and here
The consensus seems to be that this doesn't occur when the toolkit is not enabled.

I've stumbled across what seems to be a reliable way to reproduce this behavior. What I've found is if I switch away from YNAB (running as it's own app, iow not as a tab in my main browser though I think either would behave the same) while the "new beta is available" popup is displayed, then click OK on the popup, the left sidebar is missing. I don't 'know how long I've been switched away but I know it's been more than 5 minutes as I've really been multi-tasking when this has happened.
Can others try this and see if it happens to you as well? It will require access the beta. Are any of you that chimed in on this Issue Toolkit beta users?

I haven't installed the beta before, but if you tell me how I'd be happy to try it.

Go here to sign up; Toolkit for YNAB Chrome Beta Sign Up

After you've been added you'll get an email with a link to the beta extension. I suggest doing the following

[ ] Export your settings from YNAB into a xxx.json file
[ ] Hit the link and install the Beta
[ ] Close YNAB

Okay, I've installed the beta. Do I just need to wait for a new beta
version to become available in order to try reproducing the bug using the
steps you outlined above?
Thanks,
Matthew
On Thu, Oct 4, 2018 at 2:53 PM David Baldon<EMAIL_ADDRESS>wrote:

After you've been added you'll get an email with a link to the beta
extension. I suggest doing the following

Export your settings from YNAB into a xxx.json file
Hit the link and install the Beta
Close YNAB

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1320#issuecomment-427182060,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVyOnpmqlnYuqJIHQenvNbwOKq3xu5W1ks5uhoNbgaJpZM4UO8NU
.

I was hoping you would perform those steps right off. Have you tried using the Beta? If so and you didn't perform the steps, yes you'll have to wait until the next beta. We usually don't announce when a beta is available but I'll try for the next few betas. @joshmadewell I'll need a heads up on when a beta is being released.
Don't forget to turn one or the other extension off. You'll see really stuff happening if both are running at the same time. The slider between the Bug Report button and the Open Settings button is where you turn an extension on or off.

Hmm, when I installed the beta I turned the release version off, made sure
the beta was on, and loaded YNAB, but the window never popped up. (I do
usually get the dialog when the release version updates, so I don't think
it's a popup blocker issue.)
On Fri, Oct 5, 2018 at 10:49 AM David Baldon<EMAIL_ADDRESS>wrote:

I was hoping you would perform those steps right off. Have you tried using
the Beta? If so and you didn't perform the steps, yes you'll have to wait
until the next beta. We usually don't announce when a beta is available but
I'll try for the next few betas. @joshmadewell
https://github.com/joshmadewell I'll need a heads up on when a beta is
being released.
Don't forget to turn one or the other extension off. You'll see really
stuff happening if both are running at the same time. The slider between
the Bug Report button and the Open Settings button is where you turn an
extension on or off.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1320#issuecomment-427446572,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVyOnm3NlPsuxBAuMViMg1jqTxkPOgn0ks5uh5uWgaJpZM4UO8NU
.

@mamstergrub I am pretty sure you only get the pop-up for a new version release when the extension was installed before. When you add the beta, you won't get a pop-up until the next beta version releases.

@mamstergrub you're going to see a new beta today if you haven't already.

@Wolfsblvt is right that the first time you run with the beta you do not get the popup (seems odd to me).

Yeah, I think YNAB would have to automatically open a budget. I've got a ton of budgets and I as far as I know, YNAB simply opens the last budget I had open.
There'll be another beta come along so we can try it then.

I think "open last used budget" is an option that I turned off at some
point. I can turn it back on if I can find it. :)
On Mon, Oct 8, 2018 at 8:48 AM David Baldon<EMAIL_ADDRESS>wrote:

Yeah, I think YNAB would have to automatically open a budget. I've got a
ton of budgets and I as far as I know, YNAB simply opens the last budget I
had open.
There'll be another beta come along so we can try it then.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1320#issuecomment-427885095,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVyOni95f5mZh2-yJAfVoRgEP_F-GF31ks5ui3PJgaJpZM4UO8NU
.

fwiw: in the last beta push I added something that could fix this issue -- it's not definitive because I still can't make this issue happen consistently (I have seen it happen before, though).
fwiw, you can open console and paste the following code to make the modal appear on refresh:
localStorage.setItem('ynab-toolkit-latest-version-beta', '2');

Okay, well, I've been able to reproduce it pretty often by switching tabs
while YNAB is loading, so for the moment I'll keep running the beta, switch
tabs at will, and see what happens.
On Mon, Oct 8, 2018 at 8:51 AM Josh Madewell<EMAIL_ADDRESS>wrote:

fwiw: in the last beta push I added something that could fix this issue
-- it's not definitive because I still can't make this issue happen
consistently (I have seen it happen before, though).
fwiw, you can open console and paste the following code to make the modal
appear on refresh:
localStorage.setItem('ynab-toolkit-latest-version-beta', '2');
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1320#issuecomment-427886088,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVyOnlvMJY40wuYeuVzan_h-sZk8OfLuks5ui3R1gaJpZM4UO8NU
.

A change was included in the latest beta so I'd be interested to see if you can still reproduce it by switching tabs. If you try that, please let me know the results.

For anyone watching this thread -- please watch for this issue after updating to version 2.9.0! I made a change which I hope might solve this issue. My confidence in the fix is low but who knows!

so has anyone on this thread seen this issue lately?

Nope! I think it might be fixed. Thanks!
On Wed, Oct 31, 2018 at 8:51 PM Josh Madewell<EMAIL_ADDRESS>wrote:

so has anyone on this thread seen this issue lately?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/1320#issuecomment-434922348,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVyOnnMuRCBWg2xSNa32PwWFPuNLsGHOks5uqm-4gaJpZM4UO8NU
.

Not for quite a while now, thanks.

Nice!


neopixel hsl cannot be used

item.setPixelColor(0, neopixel.rgb(255,255,0))
works but
item.setPixelColor(0, neopixel.hsl(360, 100, 50))
throws the error
Argument of type 'HSL' is not assignable to parameter of type 'number'.
(In the block editor you can't connect the hsl block)
Am I using it wrong or is this a bug? The help reference pages don't exist so I can't look it up. (is that another bug?)

And of course I right after discover another block for converting to rgb.
item.setPixelColor(0, neopixel.hsl(Math.random(361), 100, 50).toRGB()) this works.
Was this added very recently or did I just not see it? Anyway, why is this conversion even needed?

setPixelColor expects the second argument as RGB (number). neopixel.hsl is an object to store the a HSL (hue, saturation, luminosity) format color. This is as expected.

We should get rid of that HSL class.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Abhijith Chatra<EMAIL_ADDRESS>Sent: Thursday, January 19, 2017 5:39:02 PM
To: Microsoft/pxt
Cc: Subscribed
Subject: Re: [Microsoft/pxt] neopixel hsl cannot be used (#1178)
setPixelColor expects the second argument as RGB (number). neopixel.hsl is an object to store the a HSL (hue, saturation, luminosity) format color. This is as expected.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F1178%23issuecomment-273953032&data=02|01|jhalleux%40microsoft.com|6d114cacdcc34177602408d440d51e98|72f988bf86f141af91ab2d7cd011db47|1|0|636204731471890411&sdata=u9POs8dSNLZr%2BwRj7c4K99qmtN9p23u8arDOThItWFw%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KSNSPXh3GKIt0wh5DBv-vsHQ5AQ3ks5rUBA2gaJpZM4Ln8d_&data=02|01|jhalleux%40microsoft.com|6d114cacdcc34177602408d440d51e98|72f988bf86f141af91ab2d7cd011db47|1|0|636204731471890411&sdata=vC5QbzF46qSwS9R9z76mQD8MVKxOPYeNHoGU7b9LL6U%3D&reserved=0.

Ok I will keep this open. Request to remove HSL from neopixel package.

I would like to argue for keeping the hsl function but make it return a number instead of an object. In other words the hsl function should have the convert built in.
I think it is great for kids to learn that there are multiple ways of defining colors. And in some cases hsl is easier than rgb. (For example I wanted to have something run through different bright colors. A random hue is perfect for that. Random rgb gives a very different result.)

Exactly what we planned.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Niels<EMAIL_ADDRESS>Sent: Friday, January 20, 2017 1:20:30 AM
To: Microsoft/pxt
Cc: Peli de Halleux; Comment
Subject: Re: [Microsoft/pxt] neopixel hsl cannot be used (#1178)
I would like to argue for keeping the hsl function but make it return a number instead of an object. In other words the hsl function should have the convert built in.
I think it is great for kids to learn that there are multiple ways of defining colors. And in some cases hsl is easier than rgb. (For example I wanted to have something run through different bright colors. A random hue is perfect for that. Random rgb gives a very different result.)

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F1178%23issuecomment-274020075&data=02|01|jhalleux%40microsoft.com|013b919f465d4f84c63108d44115952e|72f988bf86f141af91ab2d7cd011db47|1|0|636205008328792209&sdata=tdVyTlxM%2BqLMjZwOnJCiDmR9KTc2XKHZpvbE9xEN7Yc%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KQQGDOzWlX9C8v53i59ZM_OKatxlks5rUHxegaJpZM4Ln8d_&data=02|01|jhalleux%40microsoft.com|013b919f465d4f84c63108d44115952e|72f988bf86f141af91ab2d7cd011db47|1|0|636205008328802217&sdata=X6r%2FR8Laoz%2Bdl2HEi%2BjzdExfYuXtixKNwz9B4ub45LY%3D&reserved=0.

So why did this still get removed? Now the hsl function is gone?

The microbit issues have moved to https://github.com/Microsoft/pxt-microbit repo.
If this is still an issue please open the issue in that repo or let us know, we will reopen in that repo.


*: enforce max lease TTL with 9,000,000,000 seconds

math.MaxInt64 / time.Second is 9,223,372,036. 9,000,000,000 is easier to
remember/document.
Closes #9374.

@yudai Thanks! I will merge this by today.


The generator transform pass does not know about generator methods

With --classes parse, generator methods are not transformed by the generator transform pass. Is it intentional that the generator pass is only supposed to work with classes transformed away?

Not intentional, just an oversight.
class C {
  *m() {}
}

needs to be compiled to something like:
class C {
  m() {
    return $traceurRuntime.createGeneratorInstance(function($ctx) {
      ...
    }, $__0, this);
  }
}
var $__0 = C.prototype.m = $traceurRuntime.initGeneratorFunction(C.prototype.m);


Status update from Homekit

Just wondering, will this plugin notify Indigo of device state changes made from HomeKit? From my usage this doesn't seem to be happening, so that say if I turn on/off a light using HomeKit, Indigo will not update the device status accordingly. Please advise. Thanks!

I don't see how that possible, as the only way to update the state of an Indigo-controlled device is to use Indigo's API to tell Indigo to update the device, so Indigo knows the correct state of the device.
Are you trying to get Indigo to know the state of a Homekit-only device?  If so, that's not what this plugin does.

Hi thanks for the quick reply! I'm not sure I understand what you mean, so my situation is: I'm using Indigo and Homebridge to replace my Insteon Hub Pro. And I found when I operate my Insteon devices from HomeKit, the device state is not updated in Indigo, so that I have to run a schedule to iterate through all devices to update their states. I was hoping if when HomeKit operates a device, this plugin can somehow notify Indigo of the device state change, that'll be perfect. I guess the missing part is to get this status change from HomeKit? Are you saying this is not possible to realize? Please advise. Thanks a lot!!

This plugin plus Indigo would replace the Insteon Hub Pro and would keep Indigo's state updated correctly.  If you use the Insteon Hub Pro and Indigo at the same time, state gets confused because Insteon devices can only link to one hub - they can't link to both Indigo and the Insteon Hub.

Thanks for the reply! I think now I get what you're saying. I haven't removed the Hub Pro yet so I might be operating my Insteon through the old HomeKit devices that belong to the Hub Pro. I'll try to remove the Hub Pro and operate through HomeBridge and see if the device states update correctly. Will report back when I get it done. Thank you again! Very much appreciated!

Turns out it is exactly as you said. I removed the Insteon Hub Pro and use Indigo exclusively, now everything works like a charm! Thanks for the help!


fix invisible header bug

fixes #211

works as expected in other states (fullscreen, idle, index). easy one line fix. :tophat: :rabbit2:

Thanks. @dcposch Looks like the z-index was needed afterall.


No example file

Hello! I'm here because example file mentioned on site does not exist anymore :(

You can find it in the wiki now: https://www.midnightdust.eu/wiki/midnightlib/


Feature request - Add type prop to Button component

When using the Button component inside am HTML form, I can't set the button type to 'submit'. Giving access to the type prop of the button element through to Button component would make this possible with very little change.
Example use:
<form onSubmit={handleSubmit}>
  ...
  <Button type='submit' text='Create item' />
</form>

Heya @cyruskorn, thank you for using our library. This feature makes a lot of sense, great that you reached out✨

fixed in v1.3.0 #240


(Comparitive) Bar Chart

Checklist

[X] I am running the latest version of the card
[X] I checked if there isn't another feature request opened with the same request
[ ] I checked that the feature is not already available in the dev branch

Is your feature request related to a problem? Please describe.
I would like to display a side-by-side comparisum of sensors. (I am using fuel prices in nearby locations.)
The 'radialBar' is close to what I want, but it displays as percentages.
Describe the solution you'd like
A bar chart that displays the current value of a list of sensors, so that they can be visually compared.
Describe alternatives you've considered
In the meantime I am going to try to use the radialBar.
I have a separate graph for historical data (trend over the last month).
Additional context
I haven't been able to find another card that can do this.

A link to another similar request: https://www.reddit.com/r/homeassistant/comments/pjur6b/how_can_i_make_a_bar_chart_where_each_bar_is_a/


Prepare 0.1.0 release

Thanks for your hard work, please ensure all items are complete before opening.

[x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1.
[x] You have added tests for any code changes.
[x] You have completed the PR template below.

What
Prepare 0.1.0 release.

+1


Question from a total noob

I'd love to use this but I'm a total newbie and unsure how to work this.
Per your directions, I dropped my Obsidian files into the notes folder and ran NPM START but all I see is your sample site. How do I get it to process my own files and do I need to make an index of some sort?
Thanks!
Ray

I'm sorry that you're encountering issues. It's a bit difficult to debug issues without a reproducible test case, but here goes!

Did you run npm install?
I hope you didn't replace the notes folder. There's one file, notes.11tydata.js, which needs to remain.
The notes are on a subpage (ie. localhost:8080 shows the main site. Notes are on localhost:8080/notes/)

@ScootRay As this was a question as opposed to a bug/feature, I'm closing it. Feel free to start a discussion if you still need help.

@ScootRay As this was a question as opposed to a bug/feature, I'm closing it. Feel free to start a discussion if you still need help.


Ensure long IAM names do not cause failed deployments

[05/10/17 12:26 PM] Pierre: one thing: the first time I ran, I called the whole stack john-ecs-cd
[05/10/17 12:27 PM] Pierre: and this made CodeDeploy fail because the deployment CFn stack failed because the IAM role name was longer than 64 chars

Pedantic accuracy: the stack name was actually johns-ecs-cd

I wasn't able to get this to fail with johns-ecs-cd, but really-long-stack-name-trying-to-cause-errors did break the IAM resources created. https://github.com/awslabs/ecs-refarch-continuous-deployment/issues/9 should resolve this issue. Thanks!


Is there any way to show some part of next element?

Hello. Thanks for creating svelte carousel.
I want to ask, is there any way display some partof next element? Sorry if my question is unclear.
Here is the example I want to achieve.

I don't find how to set how many elements to display, e.g. perView in GlideJS or slidesToShow in Slick Carousel. I use slick carousel in previous and set slidesToShow to 1.2 to display 20% of next element.
When I use svelte-carousel, it only display exact 1 element.

It would be great if svelte-carousel do this!

Hello @niwasmala,
Thank you!
There is no ready-to-use way to achieve it yet, but I think you can play with customizing css styles which start with sc-.


Getting a exception thrown

AttributeError: 'dict' object has no attribute 'replace'

looks like the issue is this line in main.py, this is my first time looking at python, so I'm not sure how to go about a fix for a PR

Looks like this was fixed on last change pushed to master

@anthr76 Sorry about that.  I pushed a change without testing it fully.  Should be fixed now.


adds bbmap and ampliconclip

for use with SARS-CoV-2 iwc workflows
Installation sequence for tool-installers

[X] Test using @galaxybot test this
[ ] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

Closing this in favor of #529 ;)


Request Upgrade to .NET Standard 2.0

For those of us using WPF on .NET 4.6.1 an upgrade to the recently released .NET Standard 2.0 is necessary to replace Ver 1.1 of this library

650456ab7912d56146b6883e71e8320d4d1b8101


CoreGraphics: CGColorSpace incorrectly coupled with ColorFormat

Right now when a color space is created, the format is determined. The format effectively also specifies the byteOrder and alphaPosition (which are both flags of bitmapInfo). However, imageCreate or contextCreate, bitmapInfo is also specified and there may be a conflict. If there is a conflict between the colorSpace format and the bitmapInfo then the colorSpace format will prevail (incorrectly).
ColorSpace should be paired with a colorSpaceModel at ColorSpaceCreate time and the ColorFormat should be determined at imageCreate or contextCreate time after taking into consideration: colorSpace, bitsPerPixel, bitsPerComponent and bitmapInfo (effectively alphaPosition + byteOrder + floatIntSelectorBit)

@shahmeeresmail thanks for reporting and fixing this!


Run screenshot comparison tests on CircleCI

This is a long-overdue step forward in the CI setup. Every PR will now trigger a screenshot test build on CircleCI like this.
This paves the way for the next wave of graphical improvements.

Very cool.  This is great.

Wow, awesome!


chore/update-release: update release command with --no-private

@luwes wow 🥳
I just published all 5 packages with Lerna and that was a breeze
Just this one small change, adding --no-private so that the "packages" in examples/ get ignored (without this flag lerna was attempting to publish the examples)


traitor: 0.0.3 -> 0.0.7

Motivation for this change
Update to latest upstream release 0.0.7
Change log: https://github.com/liamg/traitor/releases/tag/v0.0.7
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.


Set decimals for fiatBalance and fiatConversion to 4

Closes #907

Set 4 decimals for fiatBalance and fiatConversion

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.01%) to 31.527%

Files with Coverage Reduction
New Missed Lines
%

src/routes/balances/converters.rs
1
61.73%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
12262

Relevant Lines:
13966

💛  - Coveralls


Mute beep option

this commit fixes #18

Oops, I've accidentally closed the PR : [
I believe you could update this line to window.AudioContext || window.audioContext || window.webkitAudioContext. Does it help?

It work's well! Later I'll commit this, thanks.


How to implement for self-hosted user?

I see there is a documentation for docker users only. Is there a roadmap for MATTERMOST self-hosted (ubuntu) users? Can anyone help on how to set it up?

it's
git clone
npm install
npm run start
Works on any platform that runs node.js
That's all.

I think you're confused, I asked for mattermost?

OK, I think you are confused :-) as this forum is not about mattermost, but the ChatGPT plugin. And my instructions above apply to the plugin.

I don't get it. This is a bot that can be used with Mattermost. You can run the bot with or without docker. There are no limitations on the way that you are running your Mattermost instance, but having a Mattermost instance up and running is a precondition for using the bot. There is no information in this forum on how to install Mattermost. That would not belong here. Just like you won't find information in the Mattermost forum on how to install Ubunutu or build your own PC.

=) I'm not asking a question about how to install mattermost. I'm not asking a question about how to set up mattermost. I'm asking how to integrate the bot in this repo into mattermost, there is only information on docker in the narration. I hope it is understood.

I hope it is understood.

No, I am sorry, it's not understood.
That's the question I answered first. It will let you integrate the bot with any Mattermost instance, no matter how and where it is hosted and this does not involve docker at all. If you don't understand, I am sorry, I don't think I can help you. This is not a polished end-user product for those who don't now a little node.js and command line tools.

I hope one day will get it.


getStatusMessage() returns an Array sometimes

Sometimes you get an Array instead of a String as Return-Value of the Function \Petschko\DHL\Response->getStatusMessage(); which should be String

This is not a Bug... If more then 1 object is wrong it turns into an Array. I have to change the PHP-Docs

"Fixed" PHP-Doc... https://github.com/Petschko/dhl-php-sdk/commit/1db099455711937eec16d33064c228caa7a3b200


Introduce new BBG to Azure AD integration

Description:
It would be great to have a write-up on setting up a connection with Azure AD.

Closing the issue since BBG is not maintained by the team.


L10n of "Feedback" section

Details (optional)
In each term page, "Feedback" section is displayed in English, regardless of the language user has chosen.
Example 1,
Example 2:

Cf. Kubernetes website:

I would like to work on this issue , can it be assigned to me

@jihoon-seo, I wasn't able to find the actual html file for the different languages , could you help me out by giving me the location of these files , so that I can make necessary changes .

@gullapalli9482 Let me add placeholders for this!

I understand it better now i think, so just to keeps things clear , the feedback section needs to get converted to whichever language it's opened in , am i getting it right?

@gullapalli9482 Please refer to the PR #519,
and you can add L10n to dev-xx that you want to (e.g. dev-hi) !

hello @jihoon-seo, I'm a new contributor here can I contribute by working on this issue.

@Shivansh-yadav13 Please refer to the PR #519,
and you can add L10n to dev-xx that you want to (e.g. dev-hi) !


Deduping ESM and CJS versions of the same package

Feature request

What is the expected behavior?
When part of the codebase import 'some-dep' and transient dependencies require('some-dep'), and some-dep's package.json looks like this:
{
  "exports": {
    ".": {
      "browser": {
        "require": "./dist/browser-cjs/index.js",
        "import": "./dist/esm2017/index.js"
      },
      "default": "./dist/esm2017/index.js"
  }
}

As it's the case with most @firebase/* packages - this results in both dist/browser-cjs/index.js and dist/esm2017/index.js to be included separately.
In this situation, it would be nice to have a way to force using the same dist file to minimize bundle size.
What is motivation or use case for adding/changing the behavior?
Minimizing bundle size.
How should this be implemented in your opinion?
Not sure, and not even sure if it's fixable, I just want to start the conversation about this issue

OH just found out about resolve.conditionNames
I was able to solve this by using
{
  resolve: {
    conditionNames: ['import', 'default'],
  }
}

Actually I'm realizing this break some packages... I think I would need more of a cherry picking approach, e.g. applying a custom conditionNames only for a specific list of dependencies that I know will play well with that.
I'm thinking maybe there's a way to write a Webpack plugin for this? Would love a few pointers on how to achieve that, I can't figure how to hook to dynamically transform any dependency's package.json exports before Webpack uses it for resolving


Oto 1.0 driver for the Kinc library

I’m sorry that this is PR is against the 1.0 branch, but as you have seen, the Beep library is taking forever to transition to Oto 2.x (https://github.com/faiface/beep/pull/130) so I think it’s still worth having it in Oto 1.0.
This driver is activated when building with -tags kinc. It uses the Kinc library (https://github.com/Kode/Kinc) which is a low-level multiplatform framework similar to SDL.
I have successfully tested the driver on the following platforms:

Windows x64
Linux x64
Xbox One
Xbox Series X
PlayStation 5
Nintendo Switch

The driver also compiles properly for the PlayStation 4, but I do not have the appropriate hardware to test it. Given that it works flawlessly on all the other platforms and there is no platform-specific code, I’m not too worried.

Note: Go dependency was bumped to 1.17 because of the use of unsafe.Pointer and unsafe.Slice.

Oto v1 is a maintenance mode so I cannot accept the PR, sorry.

Also I don't plan to accept this change even for v2 so far


[Ballista] Introduce StageManager for managing tasks stage by stage

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

It's better to manage tasks by stages rather than mess them up for the whole system or the whole job. With Stage, it will be much easier to maintain the task status changes within a stage, which will also be easier for future task error handling. And it will also be easier to manage the stage status changing and error handling.

Introduce StageManager for managing all of the stages.

With this change, it will be much efficient to fetch a task to be scheduled from some Stage. And it also makes it possible to schedule tasks by the priority of stages.
Additional context

#1704

There are three levels of job state: task -> stage -> job.
For the state machine of task:

For the state machine of stage:

For the state machine of job:

Sequential diagram for Pull-based task scheduling:

Sequential diagram for Push-based task scheduling:


[stable/elasticsearch-curator] Add support for init containers

Add support for init containers to be run before the Elasticsearch Curator task. This is useful for checking if the Elasticsearch cluster is available or configuring settings before running a Curator action. A common use case would be to configure an AWS S3 bucket to be used as an Elasticsearch backup repository.

@mikelorant Can this be merged?


generation of token accounts

The generation of token accounts in parties_generators.ml would be implemented like normal parties. There would be 1~max_other_parties of parties that creates new token parties. The creation of token parties would be implemented as a pair of parties. The first one would just be a normal parties that pay the creation fee and the second would create a new account with the token_id being the derived token_id of first account.

duplicate of #11102


Proof of concept of an ssp helper for jinja

Types of changes

[ ] Hot fix (emergency fix and release)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[ ] My code follows the code style of this project.
[ ] Documentation for my change is up to date?
[ ] My PR meets testing requirements.
[ ] All new and existing tests passed.
[ ] All commits are signed-off.

Summary
Opening this PR for feedback on approach. I was in need of these types of methods while writing a document-based SSP using trestle author jinja to pull the appropriate data out of my OSCAL SSP.
This obviously will need tests to be added before merging.
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

@rahearn Post community meeting, I wanted add some thoughts here and see if they aligned with what you got out of the meeting:

An SSPInterface would be generally helpful for data retrieval for the SSP object.
You need to be able to add this object to the Jinja lookup table without altering the code or a way to provide additional Python objects dynamically.

Does this sound right?

Does this sound right?

Yes, it does. Where I was unclear after the meeting was what the timeline for that was, and whether this PR should be improved to either be a short-term gap filler or a start of that work, or if it should be closed and serve only as a proof-of-concept/early use case example. Do you have thoughts on that?

Yes, it does. Where I was unclear after the meeting was what the timeline for that was, and whether this PR should be improved to either be a short-term gap filler or a start of that work, or if it should be closed and serve only as a proof-of-concept/early use case example. Do you have thoughts on that?

Good question. Since the timeline of the effort we disucssed yesterday is still undefined, I don't think we should make it a blocker for this work.
Maybe breaking up into two distinct PRs may help with this.

Adding the SSPInterface could serve as a short term solution and possibly used in the long term solution.
Address the Jinja lookup table requirement (maybe this would be a follow-on PR). This might have to use a plugin solution.

What do you think?
@butler54 @vikas-agarwal76 Please chime in if you disagree.

Address the Jinja lookup table requirement (maybe this would be a follow-on PR). This might have to use a plugin solution.

I had a thought on how to implement this this morning. I'm going to take a crack at it soon, and likely close this PR if it works well.

Closing this in favor of a new method built around jinja filters. Will have a PR sometime this week (probably)


My NFTs menu option is not showing on node

Hi,
I've tried to update our node to start supporting NFTs, using the "stable" docker images for backend and frontend (see the docker-compose attached), it's still now showing in the menu.

From the discussion on the discord, recommendation is to wipe out database and resync again. That seems to be odd considering it should be new feature not related to previous Transactions / Blokcs, plus loosing our global feed is not optimal either.

Any suggesting how to progress and get the NFTs available on our node without wiping database?
Thanks.

version: "3.7"
services:
  backend:
    container_name: backend
    image: docker.io/bitclout/backend:stable
    command: run
    volumes:
    - db:/db
    - ./:/bitclout/run
    ports:
    - 17001:17001
    - 17000:17000
    env_file:
    - dev.env
    expose:
    - "17001"
    - "17000"
  frontend:
    container_name: frontend
    image: docker.io/bitclout/frontend:stable
    ports:
    - 8080:8080
    volumes:
    - ./:/app
    env_file:
    - dev.env
    expose:
    - "8080"
  nginx:
    container_name: nginx
    image: nginx:latest
    command: "/bin/sh -c 'while :; do sleep 6h & wait $${!}; nginx -s reload; done & nginx -g \"daemon off;\"'"
    volumes:
      - ./nginx.dev:/etc/nginx/nginx.conf
      - ./data/certbot/conf:/etc/letsencrypt
      - ./data/certbot/www:/var/www/certbot
    depends_on:
      - backend
      - frontend
    ports:
      - 80:80
      - 443:443
  certbot:
    image: certbot/certbot
    entrypoint: "/bin/sh -c 'trap exit TERM; while :; do certbot renew; sleep 12h & wait $${!}; done;'"
    volumes:
      - ./data/certbot/conf:/etc/letsencrypt
      - ./data/certbot/www:/var/www/certbot
volumes:
  db:

Sadly, I wiped mine and I am still not seeing NFTs

Your local docker instance could be caching the stable tag for our images.  Try switching it to latest, clearing your local cache, or specifying a specific SHA.

Pointing to specific sha worked, not sure why it cached the stable tag. Thanks @maebeam


Add set for Counter

This is for the case where a separate service (i.e. GHC's RTS) maintains a count on your behalf, therefore inc/dec don't apply and would be more work to figure out than simply setting the counter. Example: how much time has been spent in GC. This number always increases (a counter), but if I simply add, that is incorrect. A set is the right action.

I like the sanity check idea, sure! A no-op seems OK to me. 👌
A push to hackage would be nice in your own time, thanks. We're currently using my github repo, so whenever you have time would be lovely.

@chrisdone-artificial https://github.com/bitnomial/prometheus/blob/master/src/System/Metrics/Prometheus/Metric/Counter.hs#L43-L46
let me know what you think about that.

@wraithm It seems like this has a race condition:
0 <- readCounter c -- ThreadId=0
0 <- readCounter c -- ThreadId=1
writeCounter c 2 -- ThreadId=1
writeCounter c 1 -- ThreadId=0

@wraithm It seems like this has a race condition:
0 <- readCounter c -- ThreadId=0
0 <- readCounter c -- ThreadId=1
writeCounter c 2 -- ThreadId=1
writeCounter c 1 -- ThreadId=0

Yuuuup. You're totally right, and I should have noticed that when writing this 😓
Hmmm... Though, wouldn't the writeCounter alone version you wrote also lead to a race condition as well? You'd have to have some external sequencing on calling set, no?

@wraithm I mean, this may not matter. But you're using an "atomic counter", so I thought I'd mention it.
An IORef with an atomic modify would be more stable e.g. atomicModifyIORef' could return the max between the old value and the new one. But that's a bigger change to your library.

@wraithm I mean, this may not matter. But you're using an "atomic counter", so I thought I'd mention it.
An IORef with an atomic modify would be more stable e.g. atomicModifyIORef' could return the max between the old value and the new one. But that's a bigger change to your library.

I'm not necessarily opposed to exposing multiple counter implementations, one with atomic primops and one with an IORef and a more flexible API.

@wraithm I don't want to create work for you! In my particular case, I don't have multiple writers.
How about:
-- | Write @i@ to the counter, if @i@ is more than the current value. This
-- is useful for when the count is maintained by a separate system (e.g.
-- GHC's GC counter).
--
-- WARNING: For multiple writers, the most recent one wins, which may
-- not preserve monotonicity. If you have stronger requirements than this,
-- please check with the author.
-- See <https://github.com/bitnomial/prometheus/pull/44> for discussion.
set :: Int -> Counter -> IO ()
set i (Counter c) = do
    n <- readCounter c
    when (i > n) $ writeCounter c i

That way, the user is informed and we're not hiding anything.

I tweaked my wording in the doc string, slightly.

@wraithm I don't want to create work for you! In my particular case, I don't have multiple writers.
How about:
-- | Write @i@ to the counter, if @i@ is more than the current value. This
-- is useful for when the count is maintained by a separate system (e.g.
-- GHC's GC counter).
--
-- WARNING: For multiple writers, the most recent one wins, which may
-- not preserve monotonicity. If you have stronger requirements than this,
-- please check with the author.
-- See <https://github.com/bitnomial/prometheus/pull/44> for discussion.
set :: Int -> Counter -> IO ()
set i (Counter c) = do
    n <- readCounter c
    when (i > n) $ writeCounter c i

That way, the user is informed and we're not hiding anything.

Yeah, adding a good comment makes sense. I'll just drop the readCounter check. I don't think it makes much sense to have that given that it's already relying on the user to have external synch. I'll add the comment and revert back to your implementation in the morning.

Sounds good to me! Thanks. 👍

Pushed

Looks good! 👍


Issue #3 - Unable to see the logo properly

I noticed that it was unable to see the logo on the vs code marketplace for this theme for the last few days, I hope that you fix this minor issue!

This was already fixed on the last update. THANK YOU!


Create a command line interface for Winch.

Description
We need a simple to use CLI that allows users to interact with Winch after installing.
Checklist

[x] Possibly create our own crate for parsing CLI args
[ ] Installing and uninstalling commands
[ ] Custom user hosted repo handling (--index=)

Been looking at this crate, BPAF seems more straight to the point than Clap.

Completed in production release 1.


Added defines

Added the simplest form of defines as they are in the C standard.
This makes it possible to define NULL which makes the code much more readable.
Also you can define variables like NUMBEROFREGISTERS so they cannot be changed.
If you want you can also define boolean states with true as 1 and false as 0.
I also changed to global symbol table into a simple fixed size hash table.
I'm also not too sure if the grammar.md is changed correctly.
As adding defines is part of a precompilation the compile_define does not follow the normal rules of scanner and parser.
Also this merge adds infrastructure for other precompilation possibilities if they are wished.
NEW EDIT:
I will update to the new master branch when I have time...

@leodennis @ChristianMoesl I close this PR but keep it in mind for future reference.


Manual OpenAI async code vs official AsyncOpenAI

I noticed that you're making async calls to OpenAI API manually in async def async_create_completion(). Is there any reason for this instead of using the AsyncOpenAI from the official library?
The reason I found this is because I was instrumenting our app with OpenTelemetry and OpenLLMetry just to find that async OpenAI calls from Adala are not instrumented - because OpenLLMetry expects standard openai package calls. It would be great to stick to the official package to make this (and other) useful tricks working.

Hi, still looking for a response

Hi, thanks for reaching out! Happy to say this is under development in #120 and should be merged in next week. Interested to hear more about your use case if you have details to share.

Thank you. This is great to hear!
I hope it'll make it easier for us to use LangFuse or something similar as we move towards more instrumentation and observability for our production environment.
PS I'm happy to share our use cases privately, as we're working on an internal proprietary tool.
I would also appreciate it if our (very simple) bugfixes are merged (or fixed otherwise) - like this one: https://github.com/HumanSignal/Adala/pull/98

Fixed in #120


(firefox) 50.0.1 fails to install on windows 7

On a Windows 7 base install the package fails to install:
Log snippet:
2016-11-29 08:51:28,937 [INFO ] - VERBOSE: Importing alias 'Start-ChocolateyProcess'.
2016-11-29 08:51:28,952 [DEBUG] - Running 'ChocolateyScriptRunner' for Firefox v50.0.1 with packageScript 'C:\ProgramData\chocolatey\lib\Firefox\tools\chocolateyInstall.ps1', packageFolder:'C:\ProgramData\chocolatey\lib\Firefox', installArguments: '', packageParameters: '',
2016-11-29 08:51:28,952 [DEBUG] - Running 'C:\ProgramData\chocolatey\lib\Firefox\tools\chocolateyInstall.ps1'
2016-11-29 08:51:29,030 [DEBUG] - Running Get-ProcessorBits -compare '64'
2016-11-29 08:51:29,046 [ERROR] - ERROR: Cannot bind parameter 'FilterScript'. Cannot convert the "Name" value of type "System.String" to type "System.Management.Automation.ScriptBlock".
2016-11-29 08:51:29,077 [DEBUG] - Built-in PowerShell host called with ['[System.Threading.Thread]::CurrentThread.CurrentCulture = '';[System.Threading.Thread]::CurrentThread.CurrentUICulture = ''; & import-module -name 'C:\ProgramData\chocolatey\helpers\chocolateyInstaller.psm1'; & 'C:\ProgramData\chocolatey\helpers\chocolateyScriptRunner.ps1' -packageScript 'C:\ProgramData\chocolatey\lib\Firefox\tools\chocolateyInstall.ps1' -installArguments '' -packageParameters '''] exited with '-1'.
2016-11-29 08:51:29,077 [DEBUG] - Calling command ['"C:\Windows\System32\shutdown.exe" /a']
2016-11-29 08:51:29,295 [DEBUG] - Command ['"C:\Windows\System32\shutdown.exe" /a'] exited with '1116'
2016-11-29 08:51:29,420 [DEBUG] - Capturing package files in 'C:\ProgramData\chocolatey\lib\Firefox'
2016-11-29 08:51:29,420 [DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\Firefox\Firefox.nupkg'
  with checksum 'BA66410C2DFC01E02665ADAAF3AC66FC'
2016-11-29 08:51:29,420 [DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\Firefox\Firefox.nuspec'
  with checksum '02BA111071C520CBE5B57FA2AC9D7DFE'
2016-11-29 08:51:29,436 [DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\Firefox\tools\chocolateyInstall.ps1'
  with checksum '1DDE4ECD5D6C9E1409D0DDA7BBE442A2'
2016-11-29 08:51:29,436 [DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\Firefox\tools\chocolateyUninstall.ps1'
  with checksum '7F629F206A6B2FB667C8B7A996BA7FBE'
2016-11-29 08:51:29,436 [DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\Firefox\tools\helpers.ps1'
  with checksum '871A8284A7A4368B07499484BE62AB9D'
2016-11-29 08:51:29,436 [DEBUG] -  Found 'C:\ProgramData\chocolatey\lib\Firefox\tools\LanguageChecksums'
  with checksum '60CCA1BE4DB66E36DDD02CF0031F7DE8'
2016-11-29 08:51:29,467 [DEBUG] - Attempting to delete file "C:\ProgramData\chocolatey\.chocolatey\Firefox.50.0.1\.files.update".
2016-11-29 08:51:29,467 [DEBUG] - Attempting to delete file "C:\ProgramData\chocolatey\.chocolatey\Firefox.50.0.1\.sxs".
2016-11-29 08:51:29,467 [DEBUG] - Attempting to delete file "C:\ProgramData\chocolatey\.chocolatey\Firefox.50.0.1\.pin".
2016-11-29 08:51:29,467 [DEBUG] - Attempting to delete directory "C:\ProgramData\chocolatey\lib-bad\Firefox".
2016-11-29 08:51:29,498 [DEBUG] - Sending message 'HandlePackageResultCompletedMessage' out if there are subscribers...
2016-11-29 08:51:29,498 [ERROR] - The upgrade of firefox was NOT successful.
2016-11-29 08:51:29,498 [ERROR] - Error while running 'C:\ProgramData\chocolatey\lib\Firefox\tools\chocolateyInstall.ps1'.

I suspected a powershell version incompatibility and upgraded to 5.0 with choco. And indeed after that it starts working again. Should we upgrade powershell or is this something that can be resolved in the installer script?

that's definitely not supposed to happen.
All powershell install/uninstall scripts should be posh v2 compatible.
I'll look into this and see where I did go wrong with this package.
thanks for reporting it.

@octomike I set up a windows 7 test environment with powershell v2.0, and I'm unable to reproduce this.
Any chance you can share the full log, so I can try to see where it fails?

We definitelly need Win7 vagrant machine.


swc.minify() always assumes strict mode

Describe the bug
swc.minify() always behaves as if the passed-in code is in strict mode, regardless of whether JsMinifyOptions["module"] is true or false. You can successfully configure swc.transform() in this way with Options["isModule"], but there doesn't seem to be a way to pass this configuration directly to minify or to have minify look for and use a .swcrc file.
Input code
swc.minify('const f = () => "\240";', {
    compress: {
        defaults: false,

        arguments: false,
        arrows: false,
        booleans: false,
        booleans_as_integers: false,
        collapse_vars: false,
        comparisons: false,
        computed_props: false,
        conditionals: true,
        dead_code: true,
        directives: false,
        drop_console: false,
        drop_debugger: false,
        ecma: 5,
        evaluate: false,
        expression: false,
        hoist_funs: false,
        hoist_props: false,
        hoist_vars: false,
        ie8: false,
        if_return: false,
        inline: 0,
        join_vars: false,
        keep_classnames: false,
        keep_fargs: false,
        keep_fnames: false,
        keep_infinity: false,
        loops: false,
        module: false,
        negate_iife: false,
        passes: 1,
        properties: false,
        reduce_vars: false,
        sequences: false,
        side_effects: false,
        switches: false,
        toplevel: false,
        typeofs: false,
        unused: false,
    },
    format: { comments: false, semicolons: true },
    mangle: { toplevel: false },
    module: false,
    toplevel: false,
    ecma: 5,
});

Config
// see object passed to `minify` above

Playground link
No response
Expected behavior
Because JsMinifyOptions["module"] is set to false in the configuration object passed to swc.minify(), I expect the following output:
const f=()=>"\xa0";

Actual behavior
Instead, I receive the following error:
× Legacy octal escape is not permitted in strict mode

    ╭────
01 │ const f = () => "\240";
    ·                  ──
    ╰────
Caused by:
    0: failed to parse input file
    1: error was recoverable, but proceeding would result in wrong codegen
    2: Syntax Error

Version
1.3.6
Additional context
I can get this to work in the playground, but only because the playground allows a full .swcrc where I can set isModule to true. I'm assuming the playground uses transform instead of minify.

Compiler::minify unconditionally parses as a module here:
https://github.com/swc-project/swc/blob/e0d4220264ec3926f0a5d6b774ea782f2e511a08/crates/swc/src/lib.rs#L1045
Shouldn’t this be based on opts.module?

Yeah, it should use opts.module. It's a kind of legacy.


Laggy.

Issue Type: Performance Issue
It occures a few minutes after starting VSCode. The screen starts lagging very much and it gets unusable, so I have to restart it.
VS Code version: Code 1.50.1 (d2e414d9e4239a252d1ab117bd7067f125afd80a, 2020-10-13T14:44:48.716Z)
OS version: Linux x64 5.8.0-25-generic

Please review https://github.com/microsoft/vscode/wiki/Performance-Issues and add information here.


Rear Camera not using right resolution

The Unihertz website advertises a rear camera resolution of 48 MP but the Lineage Camera app only reports 11.8 MP.

I cannot confirm this.
Lineage Camera and Open Camera (for both Original and Camera2 API) report a max. resolution of 48 MP (8000x6000 P)
Can you elaborate this issue a little bit further? Like which model/variant you use and also which of the releases?

I use the Atom L EEA
The system was built from source by myself with test-keys and the signature-spoofing patch.
Build date was 18.03.2022
I have pasted the Camera section of Deviceinfo here.

I just "updated" to your latest Release "v20220216-alpha", so that signature spoofing and Magisk got disabled but the problem persists.
Full Deviceinfo output

You've got me worried for a bit ;)
OK. So you've built your own ROM and also while testing mine you encountered that the resolution is not what it's used to be.
May I ask how you got the Deviceinfo? I just want to compare it with mine. Currently I can only rely on what Camera and Open Camera tell me.
Here is a screenshot from the Camera pp which shows the full resolution:

Here is a screenshot from the Open Camera app which shows the full resolution:

Did you check if the stock rom reports the correct resolution? Just to rule out any hardware problem.

Camera

Open Camera app

I have not checked the stock rom yet. Will try in the next few days or so.

Just in case you did everything else on building your ROM correctly:
Did you "upgrade" the bootloader and all the other other bits from the stock rom 20210518 or did do the switch to LOS right after unboxing your device?

So, after overwriting everything with Stock (20210518) using SP-Flash (is that what you meant with upgrading?), the Camera and system did report 48MP capability, [deviceinfo].
(relevant section:     "#CAMERA2API=": {         "0=back<LIMITED>8000x6000([100, 3200])": {)

After that I rebooted to bootloader and installed your vbmeta and recovery (v20210810-beta).
Restart to recovery worked but TWRP did not accept any input. (a known problem apparently?)
Using SP-Flash I installed the Lineage Recovery I build as part of the OS.
Since lineage recovery can be controlled using the hardware keys I used that to sideload your lineage-17.1-20220216-UNOFFICIAL-Atom_L_EEA-signed.zip.
There was a "signature verification failed" error but I chose to ignore that and install anyway. (I checked the MD5 of the file on SD and that wasn't the problem)
Reboot to Lineage
The Camera app still only shows 11.8MP max, [deviceinfo]
(relevant section:     "#CAMERA2API=": {         "0=back<LIMITED>4000x3000([100, 3200])": {

I just switched my development phone from L TEE to L EEA to make sure the ROM is indeed working correctly. Previously I had some mixup with L TEE and XL TEE so I wanted to be sure that this isn't also the case here.
Besides the decryption not working in TWRP (Could be a side effect from fast switching between TEE and EAA, I'll have to look into this) everything else is working as expected. In TWRP the touchscreen is responding (binary hack) and Camera in LOS is correctly reporting 48 MP.
So I'm at a loss here. As long as I cannot reproduce the error I don't have anything to analyze.
As we both seem to be from europe (and even german speaking as from the screenshots) may I ask from where you are exactly? I'm from Austria by the way.
It would be interesting to get this sorted out as I had various other claims that my ROM isn't behaving as it should. So it would really help to have such a misbehaving device in my own hand to test it. Maybe, if we are not too far away from each other we could figure something out.

A little heads up:
Now on A11 / LOS 18.1 I also have the camera defaulting back to 12MP.


Stand in line ||   not sure why the empty array can't be checked, i think there's a bug

Challenge Stand in Line has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:43.0) Gecko/20100101 Firefox/43.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
//  arr = [2,4,7,9,3];
arr = [];
function queue(arr, item) {

  newItem = arr.shift();
  arr = arr.push(item);// Your code here
  if (typeof arr !== null)
    {
  return newItem;  // Change this line
    }

}

// Test Setup
var testArr = [1,2,3,4,5];

// Display Code
console.log("Before: " + JSON.stringify(arr));
console.log(queue(arr, 6)); // Modify this line to test
console.log("After: " + JSON.stringify(arr));

I'm assuming you're talking about this test:

queue([], 1) should return 1
This isn't a bug. You're setting newItem to a value that doesn't exist. You need to push the item to the array first.

For future reference, please go to our main room or help room.


templates for Travis and AppVeyor deploys

as reference
.travis.tmpl.yml...
appveyor.tmpl.yml...

resolved, see /examples dir


React app improve calendar global display fix bug

Description
Fix some bugs and improve calendar
Tests

Steps to reproduce :

Go to event page.
Screenshots

code smells are from commented code that I probably need in future