Update docs for pagination.

Description
Add docs for pagination feature.
Keeping this as a draft, because there are some upcoming changes. Reviews and discussions are welcome though.
Note: query-optimizer-improvement.md wasn't deleted and recreated, just renamed and changed.
Issues Resolved
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1592 (78bdf01) into feature/pagination/integ (8e624a5) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@                     Coverage Diff                     @@
##             feature/pagination/integ    #1592   +/-   ##
===========================================================
  Coverage                       97.23%   97.23%
  Complexity                       4233     4233
===========================================================
  Files                             387      387
  Lines                           10628    10628
  Branches                          721      721
===========================================================
  Hits                            10334    10334
  Misses                            287      287
  Partials                            7        7

Flag
Coverage Δ

sql-engine
97.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


feat: add JetStream push subscription

Fixes https://github.com/the-codegen-project/cli/issues/45

:tada: This PR is included in version 0.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


MGMT-17064: move bootstrap out of config

TODO:

update agent test to reflect current changes (remove skip)
add status handling for controllers
reflect base conditions

reviewing

It crashes here right away (panic) I guess there is no reader now, as you said, we need to work on the test harness again at this point.
I am ok to merge and help with that tomorrow.

 It crashes here right away (panic) I guess there is no reader now, as you said, we need to work on the test harness again at this point.
I am ok to merge and help with that tomorrow.

good catch late change I didn't vet added coverage if config is not created with NewDefault()

Running the agent with this PR (after fixing the use of matching key and cert) leads to an enrollment request that cannot be approved by the server:
https://ui.flightctl.edge-devices.net/devicemanagement/enrollmentrequests/5b1e0038a7d7bca46f83201a9ddfedb214db9504855f7004a1b705e562961ad9
If you realize, the Certificate Signing Request is not shown, and approval throws the following error:
Error 422: - {"message":"Error approving and signing enrollment request: not a valid PEM encoded block"}

udates bootstrap to properly plumb csr

Test are failing because the CSR is not being approved

Test are failing because the CSR is not being approved the issue appears to be that we are waiting for the test to enrollAndWaitForDevice but I believe that process has changed a bit.

The first test passes, device creates enrollment,
but then it hangs on the cleanup:

We close the context but the agent continues looping trying to enroll even when shutdown is requested, looking at the code to figure out why.

https://github.com/mangelajo/flightctl/commit/dbe6a599d4b0f3677052fbe45e2d2f1eb0f0e9a0
This commit should fix most of the agent testing but one... I guess we need to disable that specific one and ping @avishayt for handling the new template version API in there

Running the agent with this PR (after fixing the use of matching key and cert) leads to an enrollment request that cannot be approved by the server:
https://ui.flightctl.edge-devices.net/devicemanagement/enrollmentrequests/5b1e0038a7d7bca46f83201a9ddfedb214db9504855f7004a1b705e562961ad9
If you realize, the Certificate Signing Request is not shown, and approval throws the following error:
Error 422: - {"message":"Error approving and signing enrollment request: not a valid PEM encoded block"}

This has been handled 👍
@avishayt can you merge on Sunday and look at necessary changes to re-enable the last agent test case?


Video: remove black lines showing on the sides

Video always shows black lines on the left and right sides. These should be removed.

Done in #755


DevDeps: Direct and indirect reliance on canvas module fails on ARM / Apple M1

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
The canvas module doesn't install natively on an ARM computer (see eg. https://github.com/Automattic/node-canvas/issues/1733) making it hard to contribute to this project when on eg. an Apple M1.
Previously a replacement was suggested in #4757 but it was there pointed out that canvas is also an indirect dependency due to assetgraph-builder.
When preparing a PR right now for another issue this caused me issues in installing the dev dependencies and to thus run the test suites, but when I removed those two dependencies as a temporary local workaround for me, then I could get it installing.
Steps to Reproduce
Expected behavior:  a local npm install in the mocha project works on an ARM-based computers
Actual behavior:  a local npm install in the mocha project fails on my MacBook Air M1
It fails due to there existing no prebuilt binary for arm64, the following URL returns 404: https://github.com/Automattic/node-canvas/releases/download/v2.9.0/canvas-v2.9.0-node-v93-darwin-unknown-arm64.tar.gz
Actual error:

See the full error log here

npm ERR! code 1
npm ERR! path /Users/pelle/Sites/smallrepos/mocha/node_modules/canvas
npm ERR! command failed
npm ERR! command sh -c node-pre-gyp install --fallback-to-build
npm ERR! Failed to execute '/Users/pelle/.nvm/versions/node/v16.13.2/bin/node /Users/pelle/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/Release --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v93' (1)
npm ERR! node-pre-gyp info it worked if it ends with ok
npm ERR! node-pre-gyp info using<EMAIL_ADDRESS>npm ERR! node-pre-gyp info using<EMAIL_ADDRESS>| darwin | arm64
npm ERR! node-pre-gyp info check checked for "/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/Release/canvas.node" (not found)
npm ERR! node-pre-gyp http GET https://github.com/Automattic/node-canvas/releases/download/v2.9.0/canvas-v2.9.0-node-v93-darwin-unknown-arm64.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.9.0/canvas-v2.9.0-node-v93-darwin-unknown-arm64.tar.gz
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v93 ABI, unknown) (falling back to source compile with node-gyp)
npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://github.com/Automattic/node-canvas/releases/download/v2.9.0/canvas-v2.9.0-node-v93-darwin-unknown-arm64.tar.gz
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using<EMAIL_ADDRESS>npm ERR! gyp info using<EMAIL_ADDRESS>| darwin | arm64
npm ERR! gyp info ok
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using<EMAIL_ADDRESS>npm ERR! gyp info using<EMAIL_ADDRESS>| darwin | arm64
npm ERR! gyp info find Python using Python version 3.9.9 found at<EMAIL_ADDRESS>npm ERR! gyp info spawn<EMAIL_ADDRESS>npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/Users/pelle/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/pelle/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/pelle/Library/Caches/node-gyp/16.13.2/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/Users/pelle/Library/Caches/node-gyp/16.13.2',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/Users/pelle/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/Users/pelle/Library/Caches/node-gyp/16.13.2/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! Package cairo was not found in the pkg-config search path.
npm ERR! Perhaps you should add the directory containing `cairo.pc'
npm ERR! to the PKG_CONFIG_PATH environment variable
npm ERR! No package 'cairo' found
npm ERR! gyp: Call to 'pkg-config cairo --libs' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (/Users/pelle/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:259:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
npm ERR! gyp ERR! System Darwin 21.3.0
npm ERR! gyp ERR! command "/Users/pelle/.nvm/versions/node/v16.13.2/bin/node" "/Users/pelle/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--fallback-to-build" "--module=/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/Release/canvas.node" "--module_name=canvas" "--module_path=/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/Release" "--napi_version=8" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v93"
npm ERR! gyp ERR! cwd /Users/pelle/Sites/smallrepos/mocha/node_modules/canvas
npm ERR! gyp ERR! node -v v16.13.2
npm ERR! gyp ERR! node-gyp -v v8.4.1
npm ERR! gyp ERR! not ok
npm ERR! node-pre-gyp ERR! build error
npm ERR! node-pre-gyp ERR! stack Error: Failed to execute '/Users/pelle/.nvm/versions/node/v16.13.2/bin/node /Users/pelle/.nvm/versions/node/v16.13.2/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js configure --fallback-to-build --module=/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/Release/canvas.node --module_name=canvas --module_path=/Users/pelle/Sites/smallrepos/mocha/node_modules/canvas/build/Release --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v93' (1)
npm ERR! node-pre-gyp ERR! stack     at ChildProcess. (/Users/pelle/Sites/smallrepos/mocha/node_modules/@mapbox/node-pre-gyp/lib/util/compile.js:89:23)
npm ERR! node-pre-gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
npm ERR! node-pre-gyp ERR! stack     at maybeClose (node:internal/child_process:1064:16)
npm ERR! node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
npm ERR! node-pre-gyp ERR! System Darwin 21.3.0
npm ERR! node-pre-gyp ERR! command "/Users/pelle/.nvm/versions/node/v16.13.2/bin/node" "/Users/pelle/Sites/smallrepos/mocha/node_modules/.bin/node-pre-gyp" "install" "--fallback-to-build"
npm ERR! node-pre-gyp ERR! cwd /Users/pelle/Sites/smallrepos/mocha/node_modules/canvas
npm ERR! node-pre-gyp ERR! node -v v16.13.2
npm ERR! node-pre-gyp ERR! node-pre-gyp -v v1.0.8
npm ERR! node-pre-gyp ERR! not ok
npm ERR!      /Users/pelle/.npm/_logs/2022-02-09T07_28_28_922Z-debug-0.log

Reproduces how often: 100%
Versions

The output of mocha --version and node node_modules/.bin/mocha --version:  master
The output of node --version: v16.13.2
Your operating system

name and version:  MacOs 12.2
architecture (32 or 64-bit): Arm64 (Apple M1)

Your shell (e.g., bash, zsh, PowerShell, cmd): zsh
Your browser and version (if running browser tests):
Any third-party Mocha-related modules (and their versions):
Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version):

Additional Information

@juergba Is there some documentation somewhere mentioning that that's the intended way to install a local dev copy?

Yes, in our contributing guide.


[CM] Update disclaimer text on blog articles - Pt 1

Description
Update the disclaimer text to change all occurrences of KlimaDAO to Carbonmark and crypto-assets to digital-assets
Related Ticket
Related to #2272
How to Test
TODO

@0xemc & @jabby09 - was having difficulty with the translation conflicts on this branch. My git seemed to be in a weird state when interacting with this branch and went through multiple rebases but didn't fix the conflicts, so will close this branch off.
I've re-created the branch of the latest staging here - https://github.com/KlimaDAO/klimadao/pull/2314
The changes are the same just hopefully without the translation conflicts.

@0xemc & @jabby09 - was having difficulty with the translation conflicts on this branch. My git seemed to be in a weird state when interacting with this branch and went through multiple rebases but didn't fix the conflicts, so will close this branch off.
I've re-created the branch of the latest staging here - https://github.com/KlimaDAO/klimadao/pull/2314
The changes are the same just hopefully without the translation conflicts.


set_traffic_lights_inset was Reset during zoom

I have a mac app and have code in setup
 #[cfg(target_os = "macos")] {
        // Set a custom inset to the traffic lights
        window.set_traffic_lights_inset(12.0, 18.0).unwrap();

        // Make window transparent without privateApi
        window.make_transparent().unwrap();
      }

also add set_traffic_lights_inset in on_window_event
  .on_window_event(|window, event| {
      match event {
          WindowEvent::Resized(_) => {
              #[cfg(target_os = "macos")]
              {
                let webview_window = window.get_webview_window("main").unwrap();
                webview_window.set_traffic_lights_inset(12.0, 18.0).unwrap();
              }
          }
          _ => {
          }
      }
  })

I've noticed that when I double-click the toolbar, set_traffic_lights_inset only works when the zooming behavior starts and ends. I'm curious how to keep traffic_lights in the correct position during zooming.
Currently during zooming, traffic_lights are reset to the position when set_traffic_lights_inset is not set.

Ah, good catch! This is definitely something we should fix. I will try to push a fix for this in december once I'm back from my break.

+1 That's Necessary

+1 That's Necessary

@arjOman send a patch then? comments like these are useless


TxProfile rejected

For https://github.com/evcc-io/evcc/discussions/8138 discussion. Do not commit.

@andig Ich würde dafür votieren generell auf TxDefaultProfile umzustellen.

Hold your horses. I'm still having reliability issues with this. I am still experimenting. Anyway, the problem with TxDefaultProfile is that it's simply not how this should work. If anybody else sets a TxProfile then that will overrule TxDefaultProfile and evcc can´t regulate anymore.

This is a structural fix.

Gibts hier noch was zu tun? M.E. Bugfix bei ABB?

No, see https://github.com/evcc-io/evcc/discussions/8138 . ABB firmware was according to spec after all. I would like to see my car charging properly tomorrow and if successful then I'll click this through to review for you to integrate. I don´t know how to make this a separate PR though, sorry.

Full ack after reading the spec. It seems that our OCPP library does not follow the spec in this regard.

Car still charging today. Looks ok to me. PLease integrate.

Thank you so much for troubleshooting and fixing this!

Hey, this will not work! The duplicate function was there for a reason (or you can solve it with an IF statement if you want). The transactionId can only be passed in setChargingProfile, but not in a RemoteStartTransaction (the transaction is still to be started, so the transactionId is unknown and the spec does not allow it).

Did you try? An unknown txn id is 0 which is the zero value for integers. Due to omitempty, Go will not include this in the json.

I will give it a try...

Having trouble to test this. I am getting other errors with 0.120.2 , which I can´t really pin down to a specific cause.

Please start discussion with logfile. Be aware of https://github.com/evcc-io/evcc/issues/10029. Lets close here- this has already been confirmed working.

This is working for me.


[FLINK-32222] avoid using non-public DataInputDeserializer and DataOutputSerializer. Remove overkill ThreadLocal cache. Update archunit violations

Linked to this PR:

Removed non public classes usages except Preconditions, VisibleForTesting and ClosureCleaner for which violations are added here. I updated violations store in advance of the merge of the above PR that fixes the Connector rule.

Removed overkill ThreadLocal cache as the other similar connectors, don't cache Streams for Split serialization. This allows simpler and more standard serialization code.

@zentol PTAL ?

closing this PR because ticket number is incorrect. For jira ticket linking, re-submitting the same PR with correct ticket number as renaming does not update the PR link in jira.


nimble crash on sdk v4.2.1 &v4.3 beta3 when executing ble_gap_conn_rssi (IDFGH-5305)

Hi esp team!
I developed a BLE central application on ESP32 based nimble in past year, the nimble worked well until I upgraded the SDK to 4.2 (I also tried v4.3 beta 3, the result was the same).
My device supported to connect to multiple BLE peripherals concurrently, the problem is: After established one connection with a BLE Device, esp32 doing ble_gap_conn_rssi regularly(10 seconds) on the device, and sometimes, the ble_gap_conn_rssi caused the esp32 crash! Here's the output of the trace log, for reference:
Guru Meditation Error: Core  0 panic'ed (StoreProhibited). Exception was unhandled.
Core  0 register dump:
PC      : 0x401bf5da  PS      : 0x00060530  A0      : 0x801191fc  A1      : 0x3fff4690
0x401bf5da: put_le16 at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/porting/nimble/src/endian.c:28
A2      : 0x00000001  A3      : 0x00000c35  A4      : 0x00000000  A5      : 0x00060323
A6      : 0x00000001  A7      : 0x3ffb00cc  A8      : 0x801206e2  A9      : 0x3fff4670
A10     : 0x00000000  A11     : 0x00000000  A12     : 0x3fff3400  A13     : 0x00000000
A14     : 0x00000000  A15     : 0x00000000  SAR     : 0x00000004  EXCCAUSE: 0x0000001d
EXCVADDR: 0x00000001  LBEG    : 0x4000c2e0  LEND    : 0x4000c2f6  LCOUNT  : 0xffffffff
Backtrace:0x401bf5d7:0x3fff4690 0x401191f9:0x3fff46b0 0x401193e5:0x3fff46d0 0x401188ad:0x3fff46f0 0x401188cf:0x3fff4720 0x4011eaae:0x3fff4740 0x400d9c35:0x3fff4760 0x40092919:0x3fff4780
0x401bf5d7: put_le16 at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/porting/nimble/src/endian.c:24
0x401191f9: ble_hs_hci_cmd_send at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_hci_cmd.c:80
0x401193e5: ble_hs_hci_cmd_send_buf at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_hci_cmd.c:125
0x401188ad: ble_hs_flow_tx_num_comp_pkts at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_flow.c:99
0x401188cf: ble_hs_flow_event_cb at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_flow.c:120
0x4011eaae: ble_npl_event_run at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/porting/npl/freertos/include/nimble/nimble_npl_os.h:121
(inlined by) nimble_port_run at /Users/zhonghui/esp/esp-idf/components/bt/host/nimble/nimble/porting/nimble/src/nimble_port.c:81
0x400d9c35: blecent_host_task at /Users/zhonghui/Source/manding/mbox/mbox_esp32/main/Task_Device_NB.c:2305
0x40092919: vPortTaskWrapper at /Users/zhonghui/esp/esp-idf/components/freertos/xtensa/port.c:143

Hi @zhongpang , Thanks for reporting the issue.
StoreProhibited is something trying to write to non-existent memory, like accessing a NULL pointer. I tried applications of 4.3 sdk by modifying it to call ble_gap_conn_rssi . But i couldn't reproduce the issue.   Can you please:

Share some snippet of the example code that i can try to reproduce this issue ?
It is mentioned that in latest SDK versions you are observing the issue. May i know which previous SDK versions were not showing this behaviour for the same application at your end ?

Hi @RahulEspressif,
Thanks for the reply!

Here the sigle line code which randomly caused the crash:
ret =   ble_gap_conn_rssi(dev_config->conn_id,
&dev_config->value_signal);
In the call stack, the line in my App 2305 is: nimble_port_run();
By disable "Enable Host Flow control" in menuconfig, the problem disappeard.
In this project, I used esp-idf started from 4.0, bluedroid stack, then nimble stack, it was stable on 4.1 in my memory, and started to encounter various of problems start from 4.2 rc, my device is a BLE -> 4G hub, so besides the niuble problem, I also been blocked by uart2 problem(which used to drive my 4G module...) for couple days.
Plese let me know if you need more information, thx.

Hi @zhongpang  ,

By disable "Enable Host Flow control" in menuconfig, the problem disappeard.

There is a known issue in recent releases causing unexpected protocol behaviours. We suggest to either use this option ( of disabling host flow control ) OR wait for the next official release where we have added fix for same.
Thanks,
Rahul

@RahulEspressif
Is this the same issue as https://github.com/espressif/esp-idf/issues/7026 ?
If yes, the release/v4.2 branch already has the fix for testing.

@zhongpang ESP-IDF v4.2.2 is released that has the fix for NimBLE and it is functional as expected. You can find it here: https://github.com/espressif/esp-idf/releases/tag/v4.2.2
Please give it a try and let us know in case of any issues

@zhongpang Thanks for reporting. Would you please help share if any updates or details for this issue? Thanks.

@zhongpang Thanks for reporting. Would you please help share if any updates or details for this issue? Thanks.

Thanks for reporting, will close due to short of feedback, feel free to reopen with more updates.


mx:Tree is not working

Project Details are :
https://paste.apache.org/cpo8y
Test case is available on VDI.
Go to Fixed Asset from Select in Menu
Go to Security -> Groups from Setups in Menu
File : com/dbz/modules/SEC/dbzSecurityPolicy.mxml
In Royale

In Flex

https://paste.apache.org/hn4gj
mx:Tree is using itemRenderer="com.dbz.controls.TreeViewCheckBoxRenderer"
TreeViewCheckBoxRenderer is our library file
Please check this issue

Still tree is not shown in dbzSecurityPolicy
Everything is blank and screen hanged on this Setup.
There's an exception in this setup now
TypeError: this.generator is not a constructor                    (ClassFactory.js)

Exception in TreeViewCheckBoxRenderer which is in library
Uncaught SyntaxError: Unexpected token .                        (TreeViewCheckBoxRenderer.js)

@aharui for the 'this.generator is not a constructor' part... perhaps you have seen that before. If not, it might need something like this, I think:
new (this.generator)()

@aharui Exception :

In Royale Tree items doesn't shown

In Flex : Tree item

The compiler is not transpiling the code in TreeViewCheckBoxRenderer's updateDisplayList.  What does that source code look like?

In Starting it was looking like : https://user-images.githubusercontent.com/42200979/71641333-0ce48c80-2cbc-11ea-9c73-296b5e9f49fe.png
now blank Page and applicatiton will be hanged on this Setup : https://user-images.githubusercontent.com/42200979/84645573-387dcb00-af1a-11ea-8d40-fd2fec25369f.png

10 days ago, I asked about the source code for TreeViewCheckBoxRenderer's updateDisplayList.  That is likely a major part of the problem.
It may be also that the dataProvider is not being set correctly.  Check what is being assigned to the XMLListCollection.  Explain why the dataProvider is already set to an ArrayList instead of an XMLListCollection.
You mentioned an exception creating the XMLListCollection but I don't see the stack trace of the exception.  XMLLists may throw a caught exception when initializing.

TreeViewCheckBoxRenderer extends TreeItemRenderer
Code for TreeViewCheckBoxRenderer's updateDisplayList :
override protected function updateDisplayList(unscaledWidth:Number, unscaledHeight:Number):void {
			super.updateDisplayList(unscaledWidth, unscaledHeight);
	        if(super.data){
			    if (super.icon != null){
				    myCheckBox.x = super.icon.x;
				    myCheckBox.y = 2;
				    super.icon.x = myCheckBox.x + myCheckBox.width + 17;
				    super.label.x = super.icon.x + super.icon.width + 3;
					myCheckBox.setStyle("borderColor", 0x666666);
				}
				else{
				    myCheckBox.x = super.label.x;
				    myCheckBox.y = 2;
				    super.label.x = myCheckBox.x + myCheckBox.width + 17;
					myCheckBox.setStyle("borderColor", 0x666666);
				}
			    if (data.@state == STATE_SCHRODINGER){
					myCheckBox.setStyle("borderColor", 0xFF4545);
			    }
			    else{
					myCheckBox.setStyle("borderColor", 0x666666);
			    }
			}
	    }

Hmm.  Why is the code using “super.data” and “super.icon” and “super.label”?  The compiler is not generating the right code, so that’s a bug, but if you don’t need to use super, then don’t and maybe the renderer will work better.

so what should i use instead of super.data,super.icon and super.label?

Unless overridden, you can always access public and protected base class properties without "super", just like most of the time you don't need to use 'this.' in your code.

I replace super.data with data
super.icon with icon
super.label with label
now setup looks like :

How does the renderer choose what to display?  labelField? labelFunction?  dataBinding?  Make sure the any binding expressions use (data as XML).foo instead of just data.foo

<mx:Tree id="tvGroupMember" itemRenderer="com.dbz.controls.TreeViewCheckBoxRenderer"
	       dataProvider="{secMemDataProvider}" contentBackgroundColor="#F2F2F2"
	       x="2" width="245" labelField="{secMemLabelField}" defaultLeafIcon="{null}"
	       borderVisible="false" folderClosedIcon="{null}" folderOpenIcon="{null}"
	       top="23" bottom="5"/>

dataProvider="{secMemDataProvider}"
[Bindable] public var secMemDataProvider:ListCollectionView =
new XMLListCollection(new XMLList("<node state='unchecked' label='Empty' value='0'/>"));

labelField="{secMemLabelField}"
[Bindable] public var secMemLabelField:String = "@label";

If you use the default renderer does the label show up correctly?  If so then how your custom renderer TreeViewCheckBoxRenderer handles the data property is the main issue


README Formatting

  Please Check The Preview

Disable Unused Widgets:

Packages

Releases

Disable Unused Tabs:

Projects

Why not to use GitHub Wiki

Fixex license text

General formatting / spacing

Added license badge

Moved building / usage into dedicated files

Added quicklinks

If you have any questions.

In case you do not agree with some of the changes made in this PR,
please first let me know about them, before disregarding it entirely so
we can possibly find a middle ground and have it not go to waste.

Thank you for your attempt to contribute! Here is my view:

I like README to be not too fancy. A couple of badges might be acceptable, but no more than that.
In my opinion, skilled designers should use <br>s only when absolutely necessary.
I don't like hiding useful information in <details>.
signatures and functors are part of SML '97, so "Most of SML '97 language + Signatures + Functors" makes little sense.
Did you try running my software in your computer? At least, you didn't notice that --lua-stackless-mode is wrong.
I accept your suggestion to disable "Packages". Removing "Releases" does not make sense because there may be a release in the glorious future. For now, "no releases" indicates that the software is alpha-quality.
I don't think the current use of GitHub wiki is too much a problem.

Therefore, I close this PR.
I advise you not to spend too much time twiddling READMEs of other people's software. Such PRs are unlikely to be accepted.

I like README to be not too fancy. A couple of badges might be acceptable, but no more than that.

Sure.

In my opinion, skilled designers should use s only when absolutely necessary.

You do know that you cannot access CSS in GitHub markdown?
Except for GitHub Pages sites.

I don't like hiding useful information in .

Sure.

signatures and functors are part of SML '97, so "Most of SML '97 language + Signatures + Functors" makes little sense.

Most of SML '97 language, including signatures and functors

Sorry, read that in the alternative way of a list.

At least, you didn't notice that --lua-stackless-mode is wrong.

Yes, a spelling mistake.

I accept your suggestion to disable "Packages".

Cool~

Removing "Releases" does not make sense because there may be a release in the glorious future. For now, "no releases" indicates that the software is alpha-quality.

Sure, whatever you think it implies.

I don't think the current use of GitHub wiki is too much a problem.

I see~

Therefore, I close this PR.

No hard feelings in that regard.

I advise you not to spend too much time twiddling READMEs of other people's software.

Thanks for the advice, I will happily ignore it.

Such PRs are unlikely to be accepted.

Well history proves otherwise, while not
mostly, enough people seem to enjoy
having their documentation formatted.


ReShade gotchas

Any gotchas with using ReShade instead? I think an outlined list of gotchas and maybe some help from the community to document the solution may go a long ways to prevent problems.
It appears the latest version is compatible and the shaders compiled but I'm not sure if something is extremely off or not.
I'm willing to contribute documentation for it.

GShade and ReShade are basically equivalent now so my shaders will work just fine with base ReShade assuming you have the depth info addon that comes prepackaged with it.


Fix constants

The first commit fixes some constants:

EPSILON = 2^−10, its biased exp is 5, so its bits should be 5<<10 = 0x1400.
10^5 <= MAX < 10^6, so MAX_10_EXP should be 5.
10^−5 <= MIN < 10^−4, so MIN_10_EXP should be −4.
MAX_EXP and MIN_EXP are 16, −13, because like C's float.h, std::f32 assumes the significand is in the range 0.5 ≤ x < 1.0. (The text of the IEEE-754 standard uses 1.0 ≤ x < 2.0, such that its maximum and minimum exponent values are 15 and −14.)
f32::NAN::to_bits() gives 0x7FC0_0000, so its equivalent is 0x7E00.

The second commit fixes some tests that compared the difference between 7.1 representations with EPSILON. However EPSILON is in relation to 1.0. Since 7 uses two more significant bits than 1, the difference should be compared with 4 × EPSILON instead.

I added some tests, and fixed a bug caught by them in MAX_10_EXP which should be 4, since 10^4 ≤ MAX < 10^5. (Previously I stated that 10^5 ≤ MAX < 10^6, which was incorrect.)


Outdated Copilot for Go code suggestions

Request information to use Go slices.contains function (go 1.21). Keeps suggestion outdated code. Push copilot a bit and we get:

I apologize for the confusion. As of my last update, the latest stable version of Go is 1.17, and it does not include a slices package in the standard library. If Go 1.21 has introduced a slices package with a Contains function, I'm currently not updated to provide information or examples on it. I recommend referring to the official Go documentation or other reliable resources for the most accurate and up-to-date information.

Go 1.17 is from Aug 16, 2021  ... Go 1.22 (latest) is from Feb 6, 2024
There is a 3 year gap in information, resulting in outdated suggestions and checks.

Duplicate of #560, needs a newer model with more recent knowledge cutoff.


Limit candidates to one application per job

Goal
The goal here is to only allow candidates to send one application per job
Context
How will this improvement affect the application? Give plenty of contexts.
Currently, in the app, a user can submit as many applications as they want. This could be problematic as it could easily bloat our database but also be a nightmare for companies wanting to review candidates for an application.
Notes
Have an idea how this could be accomplished? Leave notes here!

Every application is its own document in the database containing a candidateId. We could loop through all applications for that job to check if one already exists. If so, then disable the apply button and present a meaningful message "You applied for this job on XX X, XXXX"

Definition of Done

[ ] The apply button is disabled if a user has already submitted an application

Closed with #302


feat(AlgebraicGeometry): the small affine Zariski site

Could you also add a PR description? (You may also point out that this is an example of dense subsite given by a non fully faithful functor, but only locally so.)

Thanks!
bors merge


Hide all visualisations of vote progress for proposals that are not accepted.

The API only gives us a vote weight upon closing of the vote. Therefore the any of the ui that uses this should be removed.

QA signed off


java.sql.SQLNonTransientConnectionException: No operations allowed after connection closed.   burp 1.7  爆这个错误

java.sql.SQLNonTransientConnectionException: No operations allowed after connection closed.

+1


Conflict between native dependencies only enabled for targets we don’t care about

Problem
As part of the same application, I have been trying to use both wgpu 0.9 (for rendering only) and wgpu 0.11 (for compute only). However, it appears that adding both wgpu 0.9 and wgpu 0.11 dependencies yields a Cargo error:
Execution failed (exit code 101).
C:/Users/devel/.cargo/bin/cargo.exe metadata --verbose --format-version 1 --all-features
stdout :     Updating crates.io index
error: failed to select a version for `web-sys`.
    ... required by package `wgpu v0.11.0`
    ... which satisfies dependency `wgpu11 = "^0.11"` of package `wgpu_test v0.1.0 (C:\Users\devel\work\trash\wgpu-test)`
versions that meet the requirements `^0.3.53` are: 0.3.55, 0.3.54, 0.3.53

all possible versions conflict with previously selected packages.

  previously selected package `web-sys v0.3.50`
    ... which satisfies dependency `web-sys = "=0.3.50"` of package `wgpu v0.9.0`
    ... which satisfies dependency `wgpu = "^0.9"` of package `wgpu_test v0.1.0 (C:\Users\devel\work\trash\wgpu-test)`

failed to select a version for `web-sys` which could resolve this conflict

I understand that this is caused by the fact that we depend on two different versions of the same native library, which could cause link issues (and I guess that’s why we have a links entry on that Cargo.toml on the wasm-bindgen project). However, that web-sys dependency should be enabled only when targeting WASM:
[target.'cfg(target_arch = "wasm32")'.dependencies]
wasm-bindgen = "0.2.76" # remember to change version in wiki as well
web-sys = { version = "0.3.53", features = [

In my case I’m only targeting native platforms and am OK having the web target fail to compile.
Is there a way not to have this dependency conflict for native dependencies that are not enabled for the platform I’m targetting?
Steps

cargo new wgpu_test
Copy the following Cargo.toml file:

[package]
name = "wgpu_test"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
wgpu = "0.9"
wgpu11 = { package = "wgpu", version = "0.11" }

cargo check will fail.

Possible Solution(s)
No response
Notes
No response
Version
cargo 1.58.0-nightly (94ca096af 2021-10-29)
release: 1.58.0
commit-hash: 94ca096afbf25f670e76e07dca754fcfe27134be
commit-date: 2021-10-29
host: x86_64-pc-windows-msvc
libgit2: 1.3.0 (sys:0.13.23 vendored)
libcurl: 7.79.1-DEV (sys:0.4.49+curl-7.79.1 vendored ssl:Schannel)
os: Windows 10.0.22000 (Windows 10 Pro) [64-bit]

Thanks for the report!  This is essentially a duplicate of #5969, so closing in favor of that.


Conduct 3-5 user interviews with women of varying ages and write report

[ ] Update wiki: https://github.com/fchikwekwe/FaceSpace/wiki


Joint ER[P/F] and topo plot

Once #2662 is merged, only one aspect is missing for my favorite way to plot.

Combined time series and topoplots, like EEGLAB has.
I'd like to implement this next, but I'm wondering about the API. A function mne.viz.evoked.joint_plot? Another arg for evoked.plot, or maybe evoked.plot_topomap? A new method (joint_plot) for evoked?

I would add times param to evoked.plot to add topos from specific time
instants.

I'd also want to expose most or all other params for plot_topoplot though, and also allow auto times (e.g. the new 'peaks'  functionality), how about a list | dict arg? (if list, treat it as times)

hum then can you make it work just by passing a fig or axis object that
contains the evoked.plot to a new function. Our plot functions have already
too many parameters.

For the future: EEGLAB also has joint time-frequency/topo plots.

So if we also want that (IMO they're very nice), one should think about an API that also covers that case.

nilearn.plotting handles this by returning more than a fig and having an
object that allows to interact with plot and complement it.
Something along these lines:
fig = evoked.plot()
fig.add_topo(times=...)

Hm ... but that's not really MNE style is it? Also I'm not sure I could program that ...
Both the topoplot and the ts plot need access to the original evoked object. And API wise, I think a method on evoked objects is always nicest.
Would you be okay with a new method (evoked.jointplot) like this:
def jointplot(evoked, title=None, ts_args=None, topo_args=None):
"""Plots joint top and time series.

    evoked : evoked
        instance of evoked
    title : str
        The title of the figure
    ts_args : none | dict
        dict of args that are passed to evoked.plot
    topo_args : none | dict
        dict of args that are passed to evoked.plot_topo

    returns : fig"""

So if called without args, it'd just return default ts and topo plots. But you could still do e.g.
evoked.jointplot(title="P3 plot", ts_args=dict=(spatial_colors=True), topo_args=dict(times=.3))

and e.g. more elaborate args to topoplot.

first let's make it work, test it on many datasets, then we'll make it nice
with a good API

Ok!

Closed by #2738


Update README.md

updated Readme with all the required information for the setup
Summary
Briefly describe the purpose of this PR.
Description
Explain in detail what this PR is all about. This should include the problem you're solving, the approach taken, and any technical details that reviewers need to know.
Images
Include any relevant images or diagrams that can help reviewers visualize the changes, if applicable
Issue(s) Addressed
Enter the issue number of the bug(s) that this PR fixes

Template should be strictly Closes <issue_number>
Example: Closes #1

Prerequisites

[ ] Have you followed all the CONTRIBUTING GUIDELINES?

thanks


Change the name (sounds like operating system)

See title

Name will be changed in 2030. Please remind me


Fix and ammend gemspec metadata

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Was browsing rubygems.org and wanted to see the official docs but got linked to rubydoc.info instead.
Description

The docs_url key is called documentation_uri. Right now, because of the wrong key rubygems.org links to rubydoc.info instead of the URL previously set in docs_url.
The other keys were set to show what could be done to also show up on RubyGems.org. While there is no "mailing list", I think GitHub discussions are the closest thing.
Happy to add, change, remove any attributes that are unwanted. See the metadata docs for the possible keys.

Good point about the mailing list. I applied the changes. :)


fix problem when Oni start with number passed as first parameter (#2584)

add force to treat args always as string

Thanks for the PR @borjarus sorry for the delay looking at it (started a new job so been mega busy) this looks good :+1:


Error-  Multiple APi call in one scenario in karate

I am trying to use two api call (Post & put call) in one scenario in karate framework. But I am not able to validate 2nd Api call response. when i tried to do (like response.id ), it passing 1 st api call response.
Is there any quick fix for it?

@vimal738 please ask these kinds of questions on stack overflow: https://stackoverflow.com/questions/tagged/karate


Readme: Some additions

Things i stumbled upon while running dicto.

Best weak ever regarding PRs =)
Thx!


UpdatePort implementation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

40 of 40 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 69.181%

Totals

Change from base Build<PHONE_NUMBER>:
1.2%

Covered Lines:
743

Relevant Lines:
1074

💛  - Coveralls


'All changes made will be lost' warning upon exiting unedited collection item

Bug report
Describe the bug
When exiting an item that features the plugin custom fields, the user is warned about data loss and forced to click 'Save', even if nothing was updated.
Steps to reproduce the behavior

In the Content Manager go to a collection where you use the lat/lon custom field
Click on a collection item an open it
Do not edit anything
Click the Back link at the top of the page
See error

Expected behavior
Normally going back to the items list of the collection as no content was updated.

@claudiobgit Thank you for reporting this. I will check whether this could be fixed.


Fixes to the 1.19 version

Eliminating all kinds of cruft
Signed-off-by: Mary Anthony<EMAIL_ADDRESS>

Thanks! LGTM

cool i will rebase after this ;)


Translate summary.md

Thanks everyone!
I only copied from their translation.

inductor
ebiiim
kousukekikuchi1984
MATTENN
beagle
MakTak
akihirok2k2
hidesuke
ichika
peacock
gim_kondo
hykw
misato8310
aoi

Also

morin_river
waku-tkd


Show prefixes and suffixes for administrative relations in search

Description
It would be very nice if name:prefix:xx and name:suffix:xx are shown when searching via iD. Currently when I search for Добрич I get 3 results with identical names which is not ideal.
Screenshots

these names are coming directly from nominatim, iD doesn't have access to the tags at this point (example)

The main OSM website passes in an extratags=1 parameter that gives it access to name:prefix and name:suffix. But I think the labels you’re seeing are actually derived from the class and type fields, translated according to one of the many messages in Translatewiki.net. iD could probably interpret the class and type as a key and value, respectively, to match it against a preset and display the preset’s icon and label. The extratags would help us match the result to a more specific preset.


Can you give more ways for donating?

Describe the solution you'd like
Hi, I would like to support your project, can you add the "Donate" option, so that I can donate via PayPal?

Yes

Thanks for your support
Hum not sure how to make it fair since we're 3 peoples to work on it. If you want to donate please do for Homebridge dev team.


[Development] - Choose a software stack.

The software stack should match the feel of the philosophy of the site.

The Chosen Stack:
After months of deliberation the chosen stack is as follows:

[x] Next.js
[x] MDX
[x] Styled JSX

While this goes against one of the main philosophies of the stack (design and development minimalism), I hope that JAMstack fundamentals will make it easier to create and host a blogfolio. It's also an experimentation with newer technologies which should make this project fun.


ISPN-11380 Remove old cli backend

https://issues.redhat.com/browse/ISPN-11380
Second try

Integrated into master, thanks @gustavonalle !


Option to zip log files automatically

It would be really handy if morgan could compress the logs on the fly or zipped them automatically on rotation.
winston-daily-rotate-file calls such an option zippedArchive: A boolean to define whether or not to gzip archived log files. (default 'false')
They seem to compress the logfile in one piece on rotation:
        if (options.zippedArchive) {
            this.logStream.on('rotate', function (oldFile) {
                var gzip = zlib.createGzip();
                var inp = fs.createReadStream(oldFile);
                var out = fs.createWriteStream(oldFile + '.gz');
                inp.pipe(gzip).pipe(out).on('finish', function () {
                    fs.unlinkSync(oldFile);
                });
            });
        }

I guess it would be too risky to use on-the-fly compression because in case of an abrupt process termination the file could be rendered invalid...

hi @Simran-B morgan does not implement any kind of file writing. This module accepts a stream option where it will write your logs out to a stream. You can use things like a transform stream to do transformations like compression on the data or file rotation, though this is all outside of morgan directly.


Code cleanup

This PR is mostly focused on standardising the naming convention used for CSS classes and simplifying the styling and templates throughout the system.
While the update is focused on the CSS and HTML, some changes will necessarily be made to the JS implementation wherever classes have been used as selectors.
Note: Since the new message cards have significant template changes, older messages will not be correctly styled.  It might be worth notifying users when they open the updated system for the first time, just so we don't get a pile of erroneous bug reports.
Note: We've instead decided to ship legacy chat message styles so that users don't end up with random unstyled messages in their chat history.

TODO: The sheet setup header was broken when the main sheet header was rewritten. Will probably tackle this this afternoon.

TODO

Update the action buttons for section headings, aspects, and consequences to the new format.
Add the increment and decrement buttons for skills to the new action button implementation.
Remove all references to the old action buttons in the JS code once the remaining buttons have been updated.
Extract the stress boxes to a new component that can be reused for consequences.
Standardise the desk classes.

TODO

Fix the visual bug present in the main page sheet tabs when resizing the sheet. Should be a matter of increasing the size of the corner shapes so that the background never pokes through. See below:

Fix the styles for the stunt range bar. Currently it looks like this:

It should look for like this:

Great work once again, thank you very much! ❤


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/106314

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/106530

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/106801

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/115807


[PROPOSAL] Use ARN for AWS resources

Purpose:
I believe we should utilize the identifiers provided by the relevant platforms whenever feasible. Amazon has it's own internal identifiers (ARNs) that guarantees global uniqueness. Instead of us trying to come up with something better, we should use this in namespace + name.
Proposed implementation
We need to stay compatible with what we are already sending, but for all the new resources we should primarily rely on ARN's, and for existing resources, we should probably add symlinks facets with those.
We can also think about the dedicated ARN-Facet, specific to Amazon services. We should think whether we want to go this way, because then we will probably have to do the same for other providers and their identifiers (GCP, Azure etc.)
Where it came from:
I was looking at S3 and i notices that current namespace format for S3 (s3://) does NOT guarantee it being globally unique. I thought with S3 it's the same as with GCS - that the bucket name must be globally unique, but in the AWS docs we can see that:

Bucket names must be unique across all AWS accounts in all the AWS Regions within a partition. A partition is a grouping of Regions. AWS currently has three partitions: aws (Standard Regions), aws-cn (China Regions), and aws-us-gov (AWS GovCloud (US)).

Related: #2765

Bucket names must be unique across all AWS accounts in all the AWS Regions within a partition. A partition is a grouping of Regions. AWS currently has three partitions: aws (Standard Regions), aws-cn (China Regions), and aws-us-gov (AWS GovCloud (US)).

😮

Regarding S3, is there any way distinguish AWS-based S3 implementation from non-AWS? These have different naming (ARN for AWS, URL for others).

Another good question is whether we should treat something like MinIO as S3 - despite them having S3 API

Another good question is whether we should treat something like MinIO as S3 - despite them having S3 API

Why not? This is S3-compatible object storage. For example, Spark can use the same Hadoop-AWS library to read and write data to Minio.

I think for lineage the system/location of particular dataset is more important than access technology - for the same reason we treat differently SQL databases, despite the fact they all can use JDBC or Python DBAPI.

What would be okay, if MinIO was just a some kind of storage with multiple supported protocols - in this case dataset namespace should be protocol agnostic.
But MinIO had only S3 interface, IIRC.

There are storages with multiple supported protocols, like Apache Ozone, Ceph, JuiceFS. In this case it is also hard to detect whether a specific storage supports multiple protocols or just one, on client side, as it only have information about current connection options (url/host+port/...), and have no information about other protocols which might be used by other jobs.
For example, one job may access data using hdfs://namenode:8020/path, while other one uses webhdfs://namenode:9870/path. These are the same path in the same storage, but neither first nor second job does not know that.
IMHO, this logic should be on OL events consumer side, and probably depend on instance-specific options. For one organisation protocol does not matter, for other one it might be (to detect users which use deprecated protocol, for example).


devreadonly user

@snopoke i couldn't find anywhere where we actually set this user up. i went through some iterations on this to try and get it right. still trying to figure out why i'm only able to read from some tables
cc: @wpride @orangejenny

You should take a look at this: https://github.com/dimagi/commcarehq-ansible/pull/380/files#diff-ca3206fc1d7501d5550eed5478ab055fR120
This also described it quite well: http://stackoverflow.com/a/762649

ah great thanks!

man can't believe i missed that

I think that PR hasn't been merged because it contains some Ansible 2.0
stuff. @sravfeyn might recall exactly what.

Yeah, that PR is supposed to manage various pg user and db creation, and permissions via a user-db-permission mapping config. It needs Ansible2.0. I didn't prioritize it as it was not needed for ICDS, yet.
That PR is more general purpose than this, but I am fine with having this merged for now.

closing for now as this is no longer blocking formplayer and seems the work in the other PR is the better route


Update to latest code generator for azqueue

Add build.go and format generated code.

The linter failure will be addressed in https://github.com/Azure/azure-sdk-for-go/pull/19756


Doesn't open at all in OSX Mojave 10.14, no errors

Even after allowing it to open (in the Security & Privacy screen), the app won't open. The icon bounces in the dock but that's it. No messages or errors. Tried version 3.7.0.

Java is 1.8 (1.8.0_181-b13)

I realize now this is a duplicate of https://github.com/wiztools/rest-client/issues/77.

(cross posting from #77 )
I've modified the code and dependencies to support Java 8. A build of this version is available here:

http://download.wiztools.org/rest-client/restclient-ui-fat-3.7.1-SNAPSHOT.jar
http://download.wiztools.org/rest-client/restclient-ui-3.7.1-SNAPSHOT.dmg

Can the audience test the builds and let me know if it works as expected? Especially in Mac I want help knowing if the .dmg version works with both Java 8 (with no Java 10 installed in parallel) and Java 10.
Once this sanity confirmation is given by the community, I'll publish the release.


TypeScript: setFieldValue first parameter type

🚀 Feature request
Current Behavior
First of all, thank you for this wonderful library. setFieldValue works wonderfully but the first parameter is purely a string which typographical error might become an issue.
Desired Behavior
Strictly define the first parameter should be part of the passed argument for the type of the initialValues if type is defined on the hooks being used (e.g. useFormikContext).
Suggested Solution
Since the Type of the initialValues is strictly defined, I think we can also identify the first parameter as keyof of the actual Type passed as an argument or the actual shape of the object.

Who does this impact? Who is this for?
TypeScript Users - So we can remove the margin for error and no debugging will be needed.
Describe alternatives you've considered

Additional context
As much as possible we try to make it as Object-Oriented as possible and which we also use TypeScript - I feel that strongly-typed string to navigate the property is a little bit off.
I am more than happy to contribute to making this Feature Request working if deemed valid. Thank you!

this issue is a duplicate of #1334. keyof is not a good solution because fields can be nested, like:
<Formik initialValues={{
  name: {
    first: '',
    last: '',
  }
}} {...etc}>
  <Field name="name.first" />
</Formik>

there are attempts to make the field names, but they may not be merged for a while because they use brand new TypeScript features.
attempts:
#2655

Yes, I've realized keyof wouldn't actually be able to cut it for nested implementations but still stated it to spark some discussion. But since this is a dupe, i'll be sure to look out on those referenced PRs. Thank you!


Fix #5807 - Race condition in Invoker

This change addressed a race condition in the ObjectMethodExecutor where
the default argument values array can become visible before it is
initialized. If a second observer accesses the array while it is being
initialized, it can observe a null value for a reference type parameter,
leading to a nullref.
The fix here is to make everything immutable and initialize it all up
front. There's no reason to create an OME without eventually running it,
so there's no downside to doing the initialization up front.

/cc @anurse @BrennanConroy

This doesn't affect SignalR currently, we don't use GetDefaultValueForParameter anywhere. But we should probably copy this to keep up to date and up front initialization would be nice.

Also, do we need a test of the possible race?

This is not something you can do casually. I don't recommend that we get into the business of concurrency testing.

@dougbu updated

8f4ca32f485f9142b66cda1e2644dceec677fde1


Build py.test test identifer from item.location and item.getmodpath

parse_test_name previously relied on a cls attribute that wasn't present for pytest.Item instances for functional tests.
This takes advantage of some properties of the pytest.Item class to avoid relying on th cls attribute, instead munging together the relative file path the test "modpath" (e.g. TestSomething.test_method).
The implementation has changed, but the actual results for test names should be the same.

With this test project I get almost identical test names between pytest and nosetests.  The exception is that the current nosetests sometimes elides classnames, compare test names fortest_something_2.
py.test
modules/module.py:
	test_project.tests.test_something:TestSomething.test_something
	test_project.tests.test_something:test_something
tests/test_something_2.py:
	test_project.tests.test_something_2:TestSomething.test_something
tests/test_something.py:
	test_project.tests.test_something:TestSomething.test_something
	test_project.tests.test_something:test_something
modules/module_2.py:
	test_project.tests.test_something_2:TestSomething.test_something

nosetests
modules/module.py:
	tests.test_something:TestSomething.test_something
	tests.test_something:test_something
tests/test_something_2.py:
	tests.test_something_2:test_something
tests/test_something.py:
	tests.test_something:TestSomething.test_something
	tests.test_something:test_something
modules/module_2.py:
	tests.test_something_2:test_something


[5.1 04-24-2019] [Index] Handle memberwise initializers with defaulted arguments.

Cherry-pick 99d4e8090cdc735c8e20df8811fed9758d409b44 to swift-5.1-branch-04-24-2019
Patch by: @DougGregor
Reviewed by: @benlangmuir

Fix indexing crash when calling a memberwise initializer that has synthesized default values, which became legal after SE-0242.
rdar://problem/50303017

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - b0cdae3679f304925f72ab9dea9897cadfe1b5c1

Build failed
Swift Test Linux Platform
Git Sha - b0cdae3679f304925f72ab9dea9897cadfe1b5c1

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - b0cdae3679f304925f72ab9dea9897cadfe1b5c1

Build failed
Swift Test Linux Platform
Git Sha - b0cdae3679f304925f72ab9dea9897cadfe1b5c1


ENH: added laterality modifier

@fedorov -- I have added the use of the laterality modifier to the quantitative measurements query.

@deepakri201 @vkt1414 I discussed this with @bcli4d, and since this query just adds a new column and does not remove anything, we could update v18 to include the updated content.
However, we should be very sure we are not missing anything else. Let's for now use a table that is non-public and spend more time analyzing the data. Once the analysis is done and we know there will be no additional modifications, we can propagate this to the release. Sounds good?

@fedorov -- That sounds good to me!

same with me.

@fedorov I added the lateralityModifier to the schema

@deepakri201, @fedorov, I've regenerated dicom_metadata_curated_series_level, dicom_metadata_curated_series_level_view, quantitative_measurements and quantitative_measurements_view in idc-dev-etl.idc_v18_pub and idc-pdp-staging.idc_v18. I will push to the public BQ dataset after you've verified that they are good.

Hi @bcli4d,
I apologize for the delay, I missed this. The quantitative_measurements table looks good to me, thanks!

@bcli4d sorry for pushing on this at the last moment. We need this to be fixed and make resulting parquet files available on aws before tomorrow. Thank you!

@vkt1414 Done. Please verify and let me know if there are any issues (direct email wouldbe best)

I do see the Laterality attribute now. Thank you!

👍
On Tue, Jun 4, 2024, 6:37 PM Vamsi Thiriveedhi @.***>
wrote:

I do see the Laterality attribute now. Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/ImagingDataCommons/etl_flow/pull/103#issuecomment-2148700612,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGK2VI2VR7LQTVPNRZALUYDZFZTWJAVCNFSM6AAAAABHPTR2IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYG4YDANRRGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@bcli4d @vkt1414  lateralityModifier does show up in idc_v18, but I do not see it in idc_current.

@fedorov, @vkt1414  bigquery-public-data.idc_current  views have been updated. Please verify.


Security vulnerabilities in dependencies

Running npm audit reveals 31 vulnerabilities (21 low, 9 high, 1 critical)

I've highlighted the subjected dependencies in 5c8b80b.

Is it against the master? Most recent and used is in (STILL! for years ;d) in the dev branch.

Unless someone is running verb's devDependencies on a production server, there is no reason at all for us to ever be concerned with these "vulnerabilities".

Also, unless the vulnerability is directly in verb, you should create issues on the mentioned libraries. Those libraries should submit patches to fix the vulnerabilities. We should not be expected to bump majors to fix a security issue.

Understood.
CVE often (if not mostly) also includes memory issues, such as leaks, so even if it is essentially a development-bound dependency, it's still relevant to follow up.

even if it is essentially a development-bound dependency, it's still relevant to follow up.

Agreed, but we should focus our energy on forcing authors of those libraries to fix the root of the problem, instead of hacking at the leaves by creating issues on dependant libraries.
IMHO, it's not okay for the maintainers of those libs to ask implementors to bump a major to fix a security issue. They need to release patches so that everyone gets the fixes automatically. I personally think we should all stand our ground on that.

however, I do appreciate that you care and that you took the time to create issues about it. I should have made that clear as well.


URGENT: Have commits on the analysis component

During your generator add every some requests a commit request (say 1000). Implement in analysis a function to plot the difference between the submitted and the committed data and their throughput. One graph you could have is every time unit, how many were submitted and how many committed.

Post commits aggressively in the end to get the final commit so that the post and commit lines meet.

Closed now with new addition on final commits https://github.com/fotiskoun/CCF/pull/91


[Request]Allows the player to change resourcepacks.

The  resourcepacks that the game comes with by default which will affects my frame rate extremely.Such as Ender Pearl ,Eye of Ender.The animation of these items caused my frame rate to drop to 10.
So I want to be able to allow players to change texture packs,thanks! 😃

The resourcepack location: config\paxi\resourcepacks
Just remove the zip file.


MINOR, DOCS : Fixed old and added new javadocs to org.apache.kafka.common.utils.Utils

Committer Checklist (excluded from commit message)

[X] Verify design and implementation
[X] Verify test coverage and CI build status
[X] Verify documentation (including upgrade notes)

Hi, request for review @AndrewJSchofield


[ADDED]: Contact Form

Pull Request Type
What kind of change does this PR introduce?
[x] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Issue Number: #1058
What is the new behavior?

Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Improve upgrade of deb package

Pass -o Dpkg::Options::="--force-confold" --force-yes as options to package so that dpkg won't generate errors about pre-existing /etc/init.d/mongod or /etc/mongod.conf file(s).
This allow more robust upgrade path : if a previous mongodb package is already installed in the node it will allow transparent upgrade.

@drazzib Thank you so much for great PR! I'll merge and test!

@sunggun-yu No problem! Please notify me once a new release is out.

@drazzib
Hi, your change has been released. sorry for late notice.
I did refactoring little bit.
Thank you so much!


Activating extension jacobdufault.cquery failed:  Cannot read property 'replace' of undefined

I've tried it on macOS(10.12.4) but failed
Here is the error stack:  TypeError: Cannot read property 'replace' of undefined
    at activate (/Users/Caffrey/Documents/cquery/vscode-client/out/src/extension.js:111:58)
    at Function.t._callActivateOptional (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:373080)
    at Function.t._callActivate (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:372865)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:372640
    at Object.m [as _notify] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:62432)
    at Object.enter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:66006)
    at n.Class.derive._oncancel._run (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:67834)
    at n.Class.derive._oncancel._completed (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:67275)
    at c (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:70786)
    at n.Class.derive.join.i.forEach.J.then.o.(anonymous function) (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:4:71003)
(node:3566) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

if (!clientConfig.cacheDirectory) {
        console.log('Updating cache directory');
        clientConfig.cacheDirectory = context.storagePath.replace(/\\/g, '/') + "/cquerycache/";
        config.update('cacheDirectory', clientConfig.cacheDirectory, false /*global*/).then(() => {
            console.log('Updated config cache directory');
        }, (reason) => {
            console.log('Cache directory update failed');
            console.log(reason);
        });
    }

it seems like context.storagePath is undefined

Did you open just a single cc file, or an entire directory? Looking at the docs undefined is an expected value for opening a single file (but this is a valid bug that needs fixing).

Please reopen if this is still an issue.


WebApp not creating.

I am trying to create WebApp for the application using the "Deploy to  Azure" button. It opens my Azure and asked for site name and other details. After it starts deployment it fails. I could not catch what is the error. Please  resolve.

@VairaRajagopalan - if you're using the first option, make sure to first fork this repo and then supply the new url as an input in the git url on the azure creation page.


In "sort by" the ASC and DESC is not so clear

name  should be from A to Z and from Z to A
cpu usage/mem usage should be from high to low and from low to high
the status is different, if you choose ASC i shows the down vm first? so it should be also from A to Z ? i'm not sure..

you are right, this would make more sense.
The status is also sorted alphabetically, so I guess from A to Z would be right descriptor.


Add an example how to filter and retrieve raw database values

Codecov Report

Merging #8 (6537fa6) into main (85bf78c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          442       497   +55
  Branches        61        70    +9
=========================================
+ Hits           442       497   +55

Impacted Files
Coverage Δ

src/choicefield/fields.py
100.00% <100.00%> (ø)

tests/test_choice_field.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


String route binding still has URI escape sequences

With a controller as below:
[Route("api")]
public class ValuesController : Controller
{
    [HttpGet("{param}")]
    public string Get(string param)
    {
        return param;
    }
}

requests to this action which contain URI escape sequences (e.g. %20 for space) are carried through in the param value, rather than being escaped as they were in ASP.net 4; i.e. GET /api/a%20b assigns param the value "a%20b" instead of "a b"

This is very likely a manifestation of this kestrel bug: https://github.com/aspnet/KestrelHttpServer/issues/124


Sample wanted for ajalt/mordant

About the library

Description:    Full-featured text styling for Kotlin command-line applications
GitHub: https://github.com/ajalt/mordant

What the sample could do
Print something nice to the console with colors and styles
Wants to contribute the sample?

Say so in a comment here
Follow instructions in CONTRIBUTING.md
Submit your pull request!

I would like to work on this !

Go for it!


Compute SSAO at half resolution by default

Follow-up to https://github.com/godotengine/godot/pull/49736 (can be merged independently).
This provides a significant speedup for a small quality loss.
The quality loss is generally more noticeable during a project's early stages of development (e.g. in level blockouts) than it is in a finished project.
Some added rationale:

People with low-end or even mid-range GPUs may not know why an effect is slow, so it's better to default to a lower quality version that can reasonably run on such GPUs.
People with high-end GPUs will generally figure out how to increase graphics settings.

Eventually, automatic graphics quality adjustment could be used, but I think it's better to err on the side of caution from now.

With the current GPU shortages, most people will not be able to upgrade their GPU until after Godot 4.0 is released. Some people will also have to "downgrade" their GPU due to their current GPU calling it quits and having to replace it with a much slower option (integrated graphics or low-end dedicated GPU).

Personally, I think this is a bad idea. there is quite a visible downgrade, and if you don't have a GPU to run them properly, you probably don't have a GPU to run them well anyhow, and it'd make more sense to just have GI and SSAO off by default.
(and I'm not some rich boy that has an RTX 3090 or RX 6900 XT or anything modern, but like a nearly decade old card equivalent to a 2 gig GTX 650)

there is quite a visible downgrade

Which screen resolution are you using? In 1440p (a resolution increasingly common among gamers), computing GI/SSAO at half resolution means computing it in 720p, which isn't too bad.

1080p, which is also the more common resolution (if not lower, like 720p) by anyone running such crappy hardware (by todays standards, and even the standards of Pre RTX era)
The Way I see it:
If you're running an IGPU you're not running 1440p.
If you're running an IGPU you don't expect to be able to use high quality settings (unless you've got modern high end APUs from like AMD)
If you're running a decade old low end machine, you don't expect to be able to run demanding things such as GI and SSAO (SSAO does however run just fine even on high settings on a decade old low end DGPU but not really worth it as from 200 fps you drop to 100-60 depending on SSAO settings at full res, and better results come from lowering the SSAO resolution compared to using half size SSAO)
If you've got a low end machine from the last 5 years, you've got an nvidia 1030-1050 level card, which can run SSAO just fine, and GI too, to some extent, at worst 30 fps (excluding SDFGI, as that can be quite demanding when switching cascades on lower end GPUs, sufficiently so to not be usable due to stutters, but being able to render even medium settings SDFGI when stationary at usable framerates, however 1050s could probably use it)
and yes, while adding Textures and materials makes the effects slightly less visible, it's still quite visible, and adds an effect that kind of feels like every mesh was cut out and then pasted on to the frame.

Ok I've done some further testing and the issue with half res SSAO/GI giving a terrible visual downgrade is actually only really clearly visible without FXAA & Debanding (why Debanding seems to help a little I have no idea, really it shouldn't afaik) on, when running on a 1080p display... so I'd say half res is ok when running above 1080p resolution, or running 1080p with some AA settings turned on, and it does have an increasingly large performance improvement when going up with resolution relative to observable quality loss.

We discussed this in a PR meeting last week and decided that using half resolution by default for SSAO is a good idea, but it won't look good enough for GI at low resolutions. GI performance was already improved significantly by https://github.com/godotengine/godot/pull/54677 and https://github.com/godotengine/godot/pull/57707, so it's less important to render GI at half resolution to improve performance now.

Thanks!


Feature req: custom icon for .bat launchers

Hello, this tool is really great. Lots of improvements since last time I passed by !
I'm trying to set it according to my needs and I have one feature request for the upcoming updates.
My main browser is launched "clean" from ram and I used a .bat (or .cmd) script for the launcher (to copy it to ram and start the real launcher with the correct settings - mainly I use the options to launch it googled or ungoogled). I tried assigning the icon in the main browser declaration config.ini but the icon is not taken into account.
[browser:chrlauncher]
name = ChromeX Portable
cmd = C:\PortableApps\Internet Browsers\ChromeX\Chromium Portable\chrlauncher.exe
hidden = n

[browser:chrlauncher:default]
name = Default
arg = "%url%"
icon = C:\PortableApps\Internet Browsers\ChromeX\Chromium Portable\chrlauncher.exe
rule = scope:domain|rsload.net

[browser:chromexram]
name = ChromeX RAM Portable
cmd = C:\PortableApps\Internet Browsers\ChromeX\CX2RAM.bat
icon = C:\PortableApps\Internet Browsers\ChromeX\CX2RAM.ico
hidden = n

[browser:chromexram:default]
name = Default
arg = "%url%"
icon = C:\PortableApps\Internet Browsers\ChromeX\CX2RAM.ico
rule = scope:domain|rsload.net

It's just an aesthetic issue because overall it's actually working, but it would be great to personalize the browsers main icons if possible. Consider that I use several versions of chromium with their default profile and I'd love to have them distinguishable at first glance by using a specific icon for each of them.
Thanks and have a great day !

This is coming in v4, you should be able to change icons for profile and a browser:

You can now do this in v4.

You can now do this in v4.

Amazing !!! Thanks, a fix that is a nice surprise indeed !
Have a nice summer !
V.


Code cleanup

Check List:

Fixes #???
Unit tests : NA
Javadoc with a code example (API only) : YES / NO / NA

Notes
Most of these changes are documentation improvements and cleanup.
Plan on tackling some of the other problems, like a handful of {@link}s and also some language migrations to Java 8 lambdas and other improvements after this.

Thanks for the code review and cleanup !
I haven't used much java 8 features as I want to keep the master branch close to my 2.x branch (that relies on Java 7) so that features developed on 2.x are easy to merge in master.

Thanks !


Add note to the README about making authenticated API requests

We have to set an OAuth 2 Bearer Token when requesting JSON from the API. This token can be set to anything in test/development but will need to be a real token issued by Signon in production.
The Bearer Token can be set using cURL:
$ curl http://localhost:3000/assets/596e30c4edf877ece4000000 \
-H"Accept: application/json" \
-H"Authorization: Bearer 123" \
-v

@floehopper added examples of making authenticated API requests in PR #253. Closing.


Filter non-JS files out of the lint tree

When an addon tree contains non-JS files, those files will pass through the JSHint tree untouched, which means they ultimately get duplicated in the app tree as well. If the app happens to also use a preprocessor associated with that extension (which is always the case for an addon's dummy app), those files are then processed twice.
This change just filters down the tree handed off to broccoli-jshint to only include .js files.
Below are example logs using a doctored-up version of ember-cli-pegjs. Note that addon-parser.pegjs appears in both input trees in the first log.
Before:
PEG toTree input (addon)

└── modules/
   └── modules/my-test-addon/
      └── modules/my-test-addon/parsers/
         └── modules/my-test-addon/parsers/addon-parser.pegjs

PEG toTree input (app)

└── dummy/
   ├── dummy/.gitkeep
   └── dummy/app.js
   └── dummy/components/
      └── dummy/components/app-version.js
   └── dummy/controllers/
      ├── dummy/controllers/array.js
      ├── dummy/controllers/object.js
   └── dummy/index.html
   └── dummy/initializers/
      ├── dummy/initializers/app-version.js
      └── dummy/initializers/export-application-global.js
   └── dummy/my-test-addon/
      └── dummy/my-test-addon/tests/
         └── dummy/my-test-addon/tests/modules/
            └── dummy/my-test-addon/tests/modules/my-test-addon/
               └── dummy/my-test-addon/tests/modules/my-test-addon/parsers/
                  ├── dummy/my-test-addon/tests/modules/my-test-addon/parsers/addon-parser.pegjs
   └── dummy/router.js
   └── dummy/templates/
      └── dummy/templates/application.js

After:
PEG toTree input (addon)

└── modules/
   └── modules/my-test-addon/
      └── modules/my-test-addon/parsers/
         └── modules/my-test-addon/parsers/addon-parser.pegjs

PEG toTree input (app)

└── dummy/
   ├── dummy/.gitkeep
   └── dummy/app.js
   └── dummy/components/
      └── dummy/components/app-version.js
   └── dummy/controllers/
      ├── dummy/controllers/array.js
      ├── dummy/controllers/object.js
   └── dummy/index.html
   └── dummy/initializers/
      ├── dummy/initializers/app-version.js
      └── dummy/initializers/export-application-global.js
   └── dummy/my-test-addon/
      └── dummy/my-test-addon/tests/
   └── dummy/router.js
   └── dummy/templates/
      └── dummy/templates/application.js

I believe we actually want this behavior, and instead of constantly funneling and merging, we would prefer to have as linear a build pipeline as possible.

I definitely understand wanting to keep as linear a build as possible, but I think I'm missing something as to why preserving the extra files is desirable. Is the cost of the funnel worse than the cost of the duplicated processing on those files?

Is the cost of the funnel worse than the cost of the duplicated processing on those files?

this is non-obvious, both have pros and cons. What I can say, is that we have a tendency right not, to funnel, to split a tree, apply a filter/transform, and then merge-merge it. Which is redundant.

Makes total sense – thanks for taking the time to write up your thoughts.
This PR was a knee-jerk reaction to "why on earth are my files hitting the preprocessor twice in two different places?", but the scenario it happens in probably isn't a super common one.
Happy to go with whatever @rwjblue thinks – it seems like this buys some improvement for that scenario today, but I can see not wanting to introduce one more split that will just have to be changed in the future if linearization can happen.

closing this as there is no lintTree anymore


replace parser object creation with pluggable object factory

 Issue by clmcgrath
Monday Jul 10, 2017 at 22:55 GMT
Originally opened as https://github.com/gsscoder/commandline/pull/458

allow all objects to be specified with ParseArguments()
add overridable object factory call

clmcgrath included the following code: https://github.com/gsscoder/commandline/pull/458/commits

 Comment by clmcgrath
Tuesday Oct 31, 2017 at 16:10 GMT

any update on this would be appreciated

 Comment by ericnewton76
Tuesday Oct 31, 2017 at 16:41 GMT

I wish we could get some traction moving things forward.
See Issue #488


Menu Ordering not working properly

I tried $menuWeight in the app/config/Bonfire.php also weight of MenuItem in the  modules/Base/Module.php, but nothing working to ordering it.
I want the menu order:

Dashboard
Types
Products
Users
Settings
Tools

Here is the screenshot:

am i missing something?

Are user_list and other keys named routes? Cause I see it shouldbe user-list, no?

@dgvirtual Yes, there exist all of those named routes in there module's Route Config file.

In modules/Products/Config/Routes.php

$route->match(['get', 'post'], 'products', [ProductController::class, 'list'], ['as' => 'product-list']);

In modules/Base/Config/Routes.php

// Manage Types
$route->match(['get', 'post'], 'types', [TypeController::class, 'list'], ['as' => 'type-list']);

In modules/Category/Config/Routes.php

$route->match(['get', 'post'], 'categories', [CategoryController::class, 'list'], ['as' => 'category-list']);

Ok, so, they all contain dashes, not undescores. But you use underscores in $menuWeights property

Ok, so, they all contain dashes, not undescores. But you use underscores in $menuWeights property

Oops, Old habit of mine. I am mostly use underscores rather than dash.
I replaced routes alias with underscores and it working fine.
Thanks man!


Issue: RAG_FILE_MAX_COUNT and RAGE_FILE_MAX_SIZE are ineffective and don't work.

Hello,
I’ve followed the documentation and added the necessary configuration parameters, while also ensuring I'm using the latest release. However, it seems that these two specific parameters may not yet be fully functional. Despite reviewing the code, I couldn't identify where they are actively utilized. At the moment, it appears they are simply registered within config.py and main.py, without triggering any checks or errors elsewhere in the codebase.
Could you clarify if this is an intended feature or if it's reserved for future development?
Thank you!

https://github.com/open-webui/open-webui/blob/6b463164f4b129e0ce4bdc9008dd661214fe5eb5/src/lib/components/chat/MessageInput.svelte#L182
it's being used.