Official Tone.js Examples are causing crackling on my android phone

I have a Samsung Galaxy S8+ (Android 9, Chrome 79), and my wife has a Samsung Galaxy Note 8 -- If I visit:
https://tonejs.github.io/examples/simpleSynth.html and just press a key for a long time, the crackling occurs almost immediately.
This also happened in my own project when I was sending a simple triggerAttack, and also with a sequence. I thought it was just my code, so that's why I checked out the official examples and they're doing the same.  Firefox and Chrome on my desktop are perfectly fine.
Any ideas here?

Seems like it's most likely performance crackling. There's a chance also that it's somehow clipping on the software side, so you can try setting the output of Tone.js to lower (Tone.Master.volume.value = -10).
If it's performance limitations of the device, you can try using just the 'basic' oscillator instead of the 'am' or 'fm' oscillator which might be a little lighter on the processor. My guess since it happens on sustained notes is that it's not really anything that i can fix on the Tone.js-side, but a limitation of running the Web Audio API on your phone.
Have you run any non-Tone.js example to compare the performance of vanilla Web Audio vs Tone.js? There's a simple fm synth example here. Let me know if it runs any better than the Tone.js synth

It's not just on sustained notes, it happens on regular non-sustained notes during sequences or loops too.
I tried out that simple fm synth example, and it still crackles on my phone.  I'm starting to think it's just an issue with our devices/current version of the OS and/or Chrome.
I tried out these examples on my daughter's Amazon Kindle Fire HD10 tablet and it was fine -- had my mom try them out on her old iPhone and it works fine.
Hopefully an update to Android will fix the issue(s).
Thanks!

@designcourse thanks for following up. yeah it's unfortunate that the Web Audio API's performance varies so much between devices. There's only so much i can do if the underlying device can't support certain things.
I'm going to close this. but if you or anyone discovers there's something specific that can be done for this device, please share!

Same problem here on phone using audio or synth. But have had others try it on their now-faster processor phones and it seemed to not be there anymore-suggesting to me a processor performance issue. But now I get a double play when playing an .mp3 note on the phone-but not on desktops or laptops.  https://icanplaypiano.com//  Any suggestions?

I experienced the problem on a pixel 6 device.  Setting sampler.Volume = -5 corrected the issue.

Thank you. Forgot I had the problem. Seems like it ended when I switched from using P5.js to straight html.
From: leotohill @.***
Sent: Wednesday, December 11, 2024 2:29 PM
To: Tonejs/Tone.js
Cc: easycodeboy; Comment
Subject: Re: [Tonejs/Tone.js] Official Tone.js Examples are causing crackling on my android phone (#604)
I experienced the problem on a pixel 6 device. Setting sampler.Volume = -5 corrected the issue.
—
Reply to this email directly, view it on GitHub https://github.com/Tonejs/Tone.js/issues/604#issuecomment-2537064500 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ANXZANYIORO5D2QNCTWH7GL2FCOALAVCNFSM6AAAAABTOJRFVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGA3DINJQGA .
You are receiving this because you commented.Image removed by sender.Message ID: @.***>


Trying to get it running

Nice work on this! Saw your comment on my old issue on the original library. Currently running into an issue getting it setup. Currently testing it on a Raspberry pi 3b. I have all the possible Halo Home products so I should be able to help get it fully functional
avion: Fetching devices
mqtt: Connecting to broker
exclude
None
mqtt: Done
Task exception was never retrieved
future: <Task finished name='Task-1' coro=<run.<locals>.new_coro() done, defined at /home/deadman/.local/lib/python3.11/site-packages/aiorun.py:209> exception=TypeError("argument of type 'NoneType' is not iterable")>
Traceback (most recent call last):
  File "/home/deadman/.local/lib/python3.11/site-packages/aiorun.py", line 219, in new_coro
    await coro
  File "/home/deadman/.local/lib/python3.11/site-packages/avionmqtt/__init__.py", line 361, in main
    await mqtt_register_lights(settings, location, mqtt)
  File "/home/deadman/.local/lib/python3.11/site-packages/avionmqtt/__init__.py", line 148, in mqtt_register_lights
    await mqtt_register_category(settings["groups"], location["groups"], mqtt)
  File "/home/deadman/.local/lib/python3.11/site-packages/avionmqtt/__init__.py", line 143, in mqtt_register_category
    if (include is not None and pid in include) or pid not in exclude:
                                                   ^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable```

It looks like it's not liking your settings, what does your look like?

Specifically, exclude seems to be set to something other than a list - if not in use, simply remove this from the yaml

Nice yeah it was, didn't realize empty ones weren't allowed, removed those and it can hook up to the mesh it seems and I see the devices in the mqtt broker. But my log is spammed with the following and HA can't control the lights.
mesh: scanning for devices
mesh: Error connecting to device
mesh: Done

and repeat over and over

Are you able to scan for devices using bluetoothctl or similar? What kind of bt interface du you have?

From the code, that error would suggest not being able to scan for devices, so maybe the Bluetooth service isn't started, or the device driver not properly loaded.
Would probably be good to handle errors like these a bit more gracefully.

Yeah you are 100% correct, debugging why I don't have Bluetooth on a fresh Raspbian install right now and will let you know once i get that working

So I installed raspberrypi-sys-mods, and switched to a proper power supply for it and it seems to work now. My existing mesh is showing up now and HA can control it!!!

I'll be adding more details on how I have it set up later. It's running as a service, and I have sun automations updating the temperature for the entire mesh. Avi-on's app and API doesn't let you set the temperature without also turning the lights on (iirc), but this does.

Very nice, Yeah I'll work on getting the rest of my various products added to the mesh so we can get that documented in the implemtation and working properly. I don't expect it to be very hard.


Multiple authentication methods support

Currently, only the first authentication method supported by a server is tried:
https://github.com/python-caldav/caldav/blob/c19abb303dc915cd8471628ef0a4f034204d1b5b/caldav/davclient.py#L549
However, sometimes servers support multiple authentication method, e.g. Bearer and Basic, but caldav will not attempt to connect if the unsupported method appears first in the WWW-authenticate header. For instance, this is the header provided by my server:
Bearer realm="Foobar", Basic realm="Foobar", charset="UTF-8", Basic realm="Foobar", charset="UTF-8", Basic realm="Foobar", charset="UTF-8"

Instead of just looking for the first authentication method in the header, I suggest to iterate over all the methods in the header until one is found that does not raise a NotImplementedError.
What do you think?

Ouch.  I thought I had nailed this once and for all.  I guess I'll have to release a new minor version soon.
(IMO, I shouldn't really have to think about this ... IMO this logic should belong to the requests library)


Configure the soft and hard limits at customer's provisioned capacity.

We don't believe customers will notice producer throttling in time to act, a safety factor of 2 there would have been a little over 1 min of throttling before the hard limit. Moving to a factor of 5 would give them 2m 30s or so to react.
The hard limit is what really protects the broker anyway, so we just simplify the documentation and monitoring story to the hard limit.
There is an outstanding question should the hard limit be at or slightly beyond the provisioned storage?
https://issues.redhat.com/browse/MGDSTRM-8110

LGTM, added a comment to https://docs.google.com/document/d/1JGyj_z2G61Ept3gg1P0f26vAd1UpEOmbpTcNFkSYRus/edit to make the doc effort around the capacity values aware of this change.

Thanks Steve, I was wondering where to flag it for docs (not that I have access to that doc but I'm sure that will be sorted soon).


Fix third_party.exposed().

This cleans up #2328 by fixing the root cause of the interpreter
identification leak of exposed attrs. The API to report exposed
sys.path elements, third_party.exposed(), worked at build time,
with a full Pex distribution available, but returned an empty iterator
at run time, with the subset of Pex available in the runtime
.bootstrap/.

The setuptools build backend introduced to handle pre-testing Python 3.13 in CI is quite flaky. Yet another instance: https://github.com/pantsbuild/pex/actions/runs/7545643289/job/20541741101?pr=2330#step:5:1847
I'm working on switching the build system in a separate PR to handle dynamic Requires-Python metadata without using setuptools to solve the files it leaks to the source root during the build process problems.

The setuptools build backend introduced to handle pre-testing Python 3.13 in CI is quite flaky...

Fix in #2331


The response-transformer plugin continuously detects outdated configuration to synchronize

Summary
This has specifically been observed with the response-transformer plugin but may extend to others as well.
In these cases, the KongPlugin resource is created (and attached to an Ingress), resulting in the entry correctly being added to Kong with a plugin associated to the route. The issue is that by watching the ingress-controller logs, you can see that the plugin is repeatedly trying to be updated.
The larger risk here is that it may trigger things like https://github.com/Kong/kong/pull/3423 this when many plugins are used.
Kong Ingress controller version
0.1.0
Kubernetes version
1.9.3
Environment
RDS Postgresql Kong Database
What happened
The KongPlugin was created and the Kong configuration was created, but the ingress-controller logs show that it thinks the two are out of sync and tries to persist the changes every 10 minutes.
Immediately after saving a new configuration I can sometimes get a "up to date" message but on the next synchronization check (10 minutes?) it's back to being "outdated".
Expected behvaior
Updates are not attempted against Kong when the KongPlugin and Kong database appear to be in sync.
Steps To Reproduce

Create a KongPlugin with the following configuration

apiVersion: configuration.konghq.com/v1
kind: KongPlugin
metadata:
  name: add-security-headers
config:
  add:
    headers:
    - "X-Xss-Protection:1; mode=block"

Attach this plugin to an Ingress using response-transformer.plugin.konghq.com: add-security-headers

Tail the ingress-controller container logs filtered for add-security-headers

Observe similar to the following logs that repeat regularly

I0823 01:27:55.081377       7 kong.go:784] configuring plugin stored in KongPlugin CRD add-security-headers
I0823 01:27:55.133977       7 kong.go:824] plugin add-security-headers configuration in kong is outdated. Updating...

Other Information
I spent a bit of time trying to further isolate this without much success. I did try specifying all components of the response-transformer plugin (remove/append/replace) with empty lists/maps with no success. I'm having trouble determining what exactly is causing it to think the values are mismatched.

@jaygorrell
I'm reading the documentation for this plugin and it seems like, it doesn't accept an array of header.
Could you please try the following?
apiVersion: configuration.konghq.com/v1
kind: KongPlugin
metadata:
  name: add-security-headers
config:
  add:
    headers: "X-Xss-Protection:1; mode=block"

I tried the string formatted values instead of a list but didn't have any luck, but I did get this worked out.
Looking at pluginDeepEqual here:
https://github.com/Kong/kubernetes-ingress-controller/blob/b16e4f881ef2415ebb08c99156afaca553e51420/internal/ingress/controller/kong.go#L1177
It iterates over each k/v in the config map, making sure the KongPlugin config items are in Kong and with the same value. For most plugins this is straightforward but the transformer plugins have a nested structure that this method doesn't account for that -- so in my case it just compares the add key as a whole. Using my example above, in Kong, the structure is this:
                "add": {
                    "headers": [
                        "X-Xss-Protection:1; mode=block"
                    ],
                    "json": {}
                },
                "append": {
                    "headers": {},
                    "json": {}
                },
                "remove": {
                    "headers": {},
                    "json": {}
                },
                "replace": {
                    "headers": {},
                    "json": {}
                }

The value of the add key also contains the empty json dict, which causes the check to fail.
Changing my KongPlugin to this fixes the issue:
apiVersion: configuration.konghq.com/v1
kind: KongPlugin
metadata:
  name: $((basename))-upside-add-security-headers
config:
  add:
    headers:
      - "X-Xss-Protection:1; mode=block"
    json: {}

It's also interesting and worth noting that the empty data structure in Kong is a map, while a populated value is a list. That's a little unintuitive but unrelated to Kong Ingress -- aside from how you need to match the values.
I think there's still an issue to be addressed here in code for a better way to compare the objects but if you think this is acceptable, feel free to close the issue.

I tried rolling out this temporary fix but hit another snag. Basically the order of the headers and json keys can vary in how they get persisted in Kong, regardless which order they appear in the KongPlugin. In my above example, many of the json keys are coming back before the headers key.
This means you would need to create the KongPlugin, query Kong to see the order, then adjust the configuration order to match.

This issue should be fixed now with #106 merged in.
The other issue is with the plugin as noted in https://github.com/Kong/kong/issues/3166.
Closing this, please re-open if needed.


Write data migration for profiles that don't provide a main topic

The method main_topic_or_first_topic is very expensive and only takes care about 142 profiles that don't provide a main topic.
A data migration should insert the first topic of those profiles as the main_topic.

done


FIxed TIcket 31354: Include Port in Host when not default

When constructing the authority (host+port) for a URI it should
include the port number if the port is not the standard port for
the given scheme (80 for HTTP, 443 for HTTPS).
This change ensures that calls to request.build_absolute_uri()
will return a correct URL when the SERVER_PORT (or X_FORWARDED_PORT)
is something other than the default.

@apollo13 is this closer to what you were thinking? I think you may have wanted to handle the port extraction in the _get_host_and_port method, but I think it's better to keep the logic for resolving the port in one place.

#12679

@dgcgh This PR looks certainly a bit cleaner, though what worries me is that we are doing work here multiple times in get_port. Ie if X_FORWARDED_HOST is set there should be no need to look into HOST at all. Not that parsing regexes is the end of the world, but it is extra validation for stuff that will never get used.
Also now that https://github.com/django/django/pull/12679/files#diff-0eb6c5000a61126731553169fddb306eR155 moved out you'd also have to duplicate it for get_raw_uri where we'd want to replace _get_raw_host with the new functionality too.

I thought that get_raw_uri was the valid use case for an unvalidated _get_raw_host. Is there another you can point me at? do we want get_raw_uri to get the normalized version of the host:port? if so maybe there isn't a valid use case for an unvalidated version of get_host.
we can check for a port on the various host headers slightly more efficiently than the validation regex, which was surprising to me because I'm used to simple regular expressions (those without backtracking, or lookahead) being nearly as fast as split() or replace(). we get a nearly 50% performance boost from doing a split and integer parse to check that the last colon delimited slice is a port (assuming the header is well formed):
In [8]: timeit.timeit('anre.match("[::1]:8080")', setup='''import re; anre=re.compile(r"^([a-z0-9.-]+|\[[a-f0-9]*:
   ...: [a-f0-9\.:]+\])(?::(\d+))?$")''')
Out[8]: 0.9723994840169325

In [10]: timeit.timeit('x="[::1]:8080".split(":")[-1]; int(x)')
Out[10]: 0.5013509549899027

Though it seems unlikely that someone would want the port from the request without fetching the host at some point, and it makes me wonder when syntax validation should occur. It might be better to lazily populate an instance variable with the canonical host and port number. That would mean we could relocate the port resolution logic to _get_raw_host_and_port and have both get_port and get_host take that path. what do you think?

@apollo13 also, I see your point about HTTP_HOST not needing to be parsed if X_FORWARDED_HOST is present. I decided to go with this cascade pattern to prevent having to test all of the conditions in each clause. I think it's easier to read, but it is work that we can avoid.

I thought that get_raw_uri was the valid use case for an unvalidated _get_raw_host.

Yes, but that also means we'd have two functions which basically do the same (with only a slight variance). I'd like to go towards one function if possible.

do we want get_raw_uri to get the normalized version of the host:port?

Hard to say, I'd dig in the history of that file to see how it changed and which tickets were affected. Because as you pointed out the test coverage is probably not optimal.

In [10]: timeit.timeit('x="[::1]:8080".split(":")[-1]; int(x)')

That alone is not correct though as an IPv6 addr without a port would then need extra handling.

what do you think?

Dunno, it depends a little bit on what the promises of the actual functions are. I'll do some code digging tomorrow.

| That alone is not correct though as an IPv6 addr without a port would then need extra handling.
that's what the int(x) is for, if the address doesn't have a port then we'll get some number with a bracket in it, we just have to try: it and pass if an exception is thrown....
now that I test that, the failure case is terrible:
In [10]: timeit.timeit('''x="[::1]".split(":")[-1]
    ...: try:
    ...:     y=int(x)
    ...: except:
    ...:     pass
    ...: ''')
Out[10]: 1.6620176819851622

but we can use x.isdigit(), that's better:
In [17]: timeit.timeit('''x="[::1]".split(":")[-1]
    ...: if x.isdigit():
    ...:   pass
    ...: else:
    ...:   pass
    ...: ''')
Out[17]: 0.37632922403281555

What worries me about this approach is what will happen if the selected host header is not well formed. where will that error be exposed, and will it provide the user with a useful diagnosis?

So I took my time machine and found https://code.djangoproject.com/ticket/25099#comment:7 which introduced the splitting between raw and validated hosts.
So I'd argue that the raw methods should use the unvalidated host header as much as possible. get_raw_uri literally only exists (in Django's use at least) for the 500 templates so I am okay with not keeping the behaviour 100%, but we should keep invalid host headers as they serve as debugging aid.

okay, so we're stuck with _get_raw_host doing basically what it currently does, so we do need two code paths. Though I could roll _get_host_and_port into get_host without losing any functionality. It seems that the leaky abstraction may have been using _get_raw_host in get_host. (if I'm reading that correctly)

Superseded by #12844.


feat: add cython extension for signature

This is roughly at 10% improvement to the unmarshall path

Additional significant improvements would require getting rid of the dict dispatch so we can make the read functions cdef instead of cpdef. That trade off may not be worth it though since it would make the pure python code paths slower.


How to structure the data when applying the framework to my own dataset?

Hi! First of all thanks for making this open-source. I would like to apply the framework to physiological time series data. However, it is not that clear to me how to structure the dataset and the events. I saw that in the two examples you provide, the events are a DataFrame containing a single timestamp. Is that because the duration of each event is the same? Can the package generalize to events of variable duration (e.g., 2-4 seconds)?

Hi! Thank you for your interest in this open-source package. Indeed, you can pass the events as a DataFrame or a list. Each event can be defined as a single time point or an interval of time (starting time and stopping time).
For instance, if events are given as a DataFrame, it can either have two columns where one column contains the starting time of each event and the second column contains the stopping time. Alternatively, it can just contain one column with the midpoint of each event.
In your case, you can pass the events as a DataFrame with two columns containing the starting and stopping time of each event. Please don't hesitate to ask if you have any further questions. I'm here to help! 😊

Thank you for the clear reply. I am still having some issues (each time point gets predicted as an event), I think that I might be missing something about the parameters.
The main difference of my data from yours (credit card and Mars) is that I have a sampling time of 10 ms, and the events last from 2 to 4 seconds. Should I make some changes to the default parameters? I hope that I am not asking too much :swear. Thank you in advance 🙏

You're welcome, I'm happy to help! Our method, provided in this package, divides the time series into overlapping partitions, known as sliding windows. The width argument determines the width of each window, which is an integer representing the number of time steps in each window. Additionally, the step argument defines the number of time steps to slide each window.
In your case, with a sampling time of 10 ms, you might want to set width to 401. This would make the duration of each window match the maximum duration of your events: (401-1)*10 ms = 4000 ms = 4 seconds.
For instance, the code below specifies the width of the windows to be 401, corresponding to a 4-second duration. Your events will be considered to have a maximum 4-second duration.
meta_model = MetaModel(output_dir="your_output_folder", dataset=your_dataset, events=your_events, width=401, step=1)
meta_model.fit()

Please don't hesitate to ask if you have any further questions. I'm here to help! 😊

This was super useful and the detection results improved a lot 🚀 . So, if I got it correctly, with this line of code
interval = Interval(mid_time - radius, mid_time + radius)
you define new events that are centered around the middle of each event and with duration equal to width. Therefore, if I set width to 401, each event will be considered lasting 4 seconds (even shorter and longer ones). So there is no way to predict events of variable duration, right? Or am I missing something?


adding Tone Analyzer v2

Adds a new V2 api wrapper for Tone Analyzer. The Tone Analyzer API is changing (about to be published), mainly changing /synonym from POST to GET.
v1 wrapper is unchanged. v2 wrapper is added. test cases for v2 are also added.

Hey @herchu, I saw that you are sending content-type: application/json for synonyms and scorecards. If you set json: true it will automatically add the content-type header and parse the response as json, no need to add the header manually.  See this

I just fixed the headers issue; using only the json:true property now

Detail of changes in V2:
changes

synonym api is now GET and accepts a single word (and it is /synonyms, plural)
synonym api now returns an object, not an array
tone accepts a GET (alternative to POST)
tone api now returns which words have synonyms available

other misc fixes

improvements on synonyms dictionaries
tone algorithms have also been improved
fixed spelling to semantic_type in synonym response
"hops" properties now make sense

thanks @herchu

Published to npm in v0.10.0


All code related to Trompa Processing Library to be removed

All code related to Trompa Processing Library that is under the trompace/application folder can be removed and moved to the TPL or at least stop it's development in order to avoid developing things twice

Let's talk about this in more detail in person.
I think it makes sense to move trompace.client to the TPL - this is the part that actually has code to do with reading configuration files and executing algorithms.
The code in trompace.application is a generic interface for sending queries to the CE. My thoughts is that it is better suited to stay in this repository.


Re-home Key Vault Scripts from Governance Directory to Security Directory

Added to branch #189 . Closed.


Reload mask when change mask done and validation fixed

I made a lot of chances sinse my last commit about mask change. I hope at least to help you in some way.
Thank you

This would be useful and exactly solve what I need. Hope this get's merged soon!

+1

+1

+1

+1

+1
I think you should also add an example in the sample pages as part of this change: https://github.com/candreoliveira/ngMask/tree/master/examples

Please, this.

please merge this!!


inference code on single video？

Dear all:
thanks for sharing this great work!  I read the readme.md carefully and could not found any tips on inference on single video? anyone share the inference code?

Hi @dragen1860,
There is no explicit script for inference. To solely perform evaluation, you can modify train/model.py by commenting out lines 378-582, i.e.: https://github.com/alexandrosstergiou/Squeeze-and-Recursion-Temporal-Gates/blob/1641b59b73c951a5b05d17b5528894ae73a014b8/train/model.py#L378-L582
And adding
break

at line 657

looks reasonable! thanks for your tips.


Add a dedicated error variant for planned failures in index scheduler tests

Pull Request
Related issue
Fixes #3086
What does this PR do?

Add a dedicated test variant in test cfg to avoid reusing a misleading existing error

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Hi!
Wanted to get in touch so I thought I might as well pick a "good first issue".
About the code itself: in the enum error itself, only four existing variants are under the "Irrecoverable errors" comment, but in the impl ErrorCode for Error a fifth one is there, the catch-all anyhow variant. What should be the truth? I guess the anyhow one being a catchall it should be considered irrecoverable too as a baseline, for lack of information. One could imagine later refining that case depending on the underlaying error wrapped by anyhow.

bors try

Rebased on main and added the new error type to the big match


Add "testing only" message to serve output

The serve function should only be used for testing.
To make that clear, add a message such as:

WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.

Done in v6


fixes #33 adds TRUST_PROXY environment variable

Description of Change
If TRUST_PROXY environment variable is set to true, enables the feature in the app so that the app can run behind proxies that terminate https and forward http
Related Issue
fixes #33
Motivation and Context
Checklist

[ x ] Ran npm run lint and updated code style accordingly
[ x ] npm run test passes
[ x ] PR has a description and all contributors/stakeholder are noted/cc'ed
[ x ] tests are updated and/or added to cover new code

The documentation that this should be added to is probably in the sample website which I can't edit.

[ ] relevant documentation is changed and/or added

@isaacwhite I think this is as far as I can get it.  I'm not sure where to start with the issue on import-fresh.  I agree with your thinking that it makes more sense to go there, but my JS knowledge is far short of what is needed to fix that one.  Let me know your thoughts on moving forward with decache for now or if it needs to be dealt with.
I left the require.main == module comment open so you could make sure it was what you were thinking.


Update installation.rst. cid --> django-cid

Just found this while trying to follow the installation doc.

Hey @pabloz - Sorry I didn't pick up on this earlier. I have fixed all the errors my code was generating with newer versions of pep8, and merged this change in manually


README.md is not finished.

The README.md does not contain the amount of detail i've provided in my past repositories.
Need to add the 'about this project' section, much like the Jellyfin-Lavender one.
Also need to add a 'Getting Started' section.
To my defense, this is basically a cluster of random websites off my machine. As these were not intentionally supposed to originally be open sourced.

This should be sufficient.
I will likely take another look at this when it's up for review.
https://github.com/owospace/spce.moe/commit/5e4213fa0d269aa6b583cf2928d2ae84c7ccb4d8


[SILInliner] Only guaranteed args get lexical lifetimes.

Previously, when inlining, both owned and guaranteed arguments were wrapped in lexical lifetimes before using them to within inlined callees.  That is redundant, however, because SILGen add lexical lifetimes for owned arguments within functions.  Here, the redundancy is removed by only adding lexical lifetimes for guaranteed arguments that are passed to inlined callees.

@swift-ci please test


create ru.ru.json

Hi, you need to expand the mod, namely to translate it into other languages. I just want to offer a translation of the mod into Russian, and if you like it, you can add it to the mod.
Here is my translation, please rate it:
https://drive.google.com/file/d/1SVTOojykUwpelfrLZYBZjKezvJp0mG7z/view

You should create a pull request for this: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request


QTpy

Are there plans to add the QTpy to the Windows drivers, for Windows 7?

we can, note we're kinda deprecating win 7 support...and strongly encourage moving to win 10...

please check the latest release :)


lib.sources: docs, tests, refactoring

Motivation for this change

Start documenting lib.sources in the manual
Improve maintainability with tests
Add sources.trace for debugging
Refactor cleanSourceWith to support trace and future functions like #112083

Perhaps unlike that pr, these changes should be uncontroversial and can hopefully be merged soon, to deliver some of its benefits and to simplify that pr.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/source-combinators/13331/9

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/source-combinators/13331/1

Rendered:

Haven't been able to confirm this yet, but it looks like this breaks a workflow in which the src is a nonexistent path.

Haven't been able to confirm this yet, but it looks like this breaks a workflow in which the src is a nonexistent path.

Some spacebar heating vibes here. How did it work and what did you use it for?
I don't think I can reproduce it using primitives in the Nix 2.4 repl, but maybe I'm overlooking something.
nix-repl> builtins.filterSource (_: _: false) ./this-does-not-exist
error (ignored): error: bad archive: input doesn't look like a Nix archive
error: getting status of '/home/user/h/nixpkgs/this-does-not-exist': No such file or directory

nix-repl> builtins.path { path = ./this-does-not-exist; filter = _: _: false; }
error (ignored): error: bad archive: input doesn't look like a Nix archive
error: getting status of '/home/user/h/nixpkgs/this-does-not-exist': No such file or directory

@roberth

Some spacebar heating vibes here.

Yes I thought the same when I found it :D
I also wasn't able to reproduce with a repl, so I'll stop commenting about it here and work around the issue.

In case anyone else runs into this: you can work around this issue by using pkgs.emptyDirectory instead of a nonexistent directory.


Update construct_runtime.md

Update ProvideInherent impl code

Sync with latest code at https://github.com/paritytech/substrate/blob/master/srml/timestamp/src/lib.rs

Thank you for your multiple contributions! Keep it up :)

Please also feel free to write to us ways we can make improvements to the clarity and content of the docs

@shawntabrizi
If you have time, could you have a look at #149 ?
It looks like Log and RawLog are removed....


Lose NavigationViewItem selection after setting an item property

Describe the bug
I have a small demo that allows me to change a property on a NavigationViewItem.  This is implemented using an ObservableCollection object, where Category is a class that derives from INotifyPropertyChanged.  It has one changeable property: Name.
The property change works as expected, but I then lose the item selection until I click on it again.
Why does the item selection go away when I change its property?  Is there a workaround to restore the selection programmatically? I've tried just setting SelectedItem on the navigationview, but that doesn't work.
Steps to reproduce the bug

Start the app
Click on the first button in the NavigationViewItem list (item becomes selected at this point)
Click the "Test Name Change" button
The item's name changes to "blah blah blah" as expected, but the item is no longer selected
Clicking on the item restores the selection

Expected behavior

Start the app
Click on the first button in the NavigationViewItem list (item becomes selected at this point)
Click the "Test Name Change" button
The item's name changes to "blah blah blah" as expected and the item remains selected

Screenshots

MainWindow.zip
NuGet package version
WinUI 3 - Windows App SDK 1.0 (If you're seeing your issue in older previews of WinUI 3, please try this release)
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
May 2021 Update (19043)
Additional context
I attached a screenshot of the handler that sets the Name property on the selected item.
Also attached the MainWindow.xaml and MainWindow.xaml.cs files for the project.

@ojhad thoughts?


Key error when running the code

Hi, I am unable to run the code. I keep getting this error -
Traceback (most recent call last):
  File "/usr/local0/Adarsh/DRew-main/lrgb/main.py", line 104, in <module>
    load_cfg(cfg, args)
  File "/home/rml/.local/lib/python3.10/site-packages/torch_geometric/graphgym/config.py", line 500, in load_cfg
    cfg.merge_from_file(args.cfg_file)
  File "/home/rml/.local/lib/python3.10/site-packages/yacs/config.py", line 213, in merge_from_file
    self.merge_from_other_cfg(cfg)
  File "/home/rml/.local/lib/python3.10/site-packages/yacs/config.py", line 217, in merge_from_other_cfg
    _merge_a_into_b(cfg_other, self, self, [])
  File "/home/rml/.local/lib/python3.10/site-packages/yacs/config.py", line 478, in _merge_a_into_b
    _merge_a_into_b(v, b[k], root, key_list + [k])
  File "/home/rml/.local/lib/python3.10/site-packages/yacs/config.py", line 491, in _merge_a_into_b
    raise KeyError("Non-existent config key: {}".format(full_key))
KeyError: 'Non-existent config key: train.mode'

Im not sure how to fix this. Any suggestions would be helpful.

I think this is a torch (and possibly pyg) version issue


When hovering over the sync icon only show its own tooltip

Right now, if you have a synced layer and you hover over the sync icon in the Layers List, two tooltips appear, one from the dataset now and one from the sync icon. Only the sync tooltip should appear when hovering the sync icon.

Also, let's change its copy and add "Synced" as a prefix. So, in the case above it would say "Synced a few seconds ago"
cc @ramiroaznar

Should this issue be fixed by the onboarding squad?

Bravo is mostly working on the mobile embed right now, but I'm not sure.
cc @matallo


Mouse-over issue with line continuations

The optional & at the beginning of the next line in a line continuation leads to incorrect mouse-over behavior. A mouse-over of a in the argument list of routine_OK shows integer, intent(in) while in routine_TROUBLE it shows logical, intent(out).
I don't think it is an issue of the language server, as the type of all three arguments is correctly parsed and shown when typing call routine_TROUBLE(...) in the main program.
   subroutine routine_OK( &
      a, b, c)
      integer, intent(in)     :: a
      real,    intent(inout)  :: b
      logical, intent(out)    :: c
   end subroutine routine_OK

   subroutine routine_TROUBLE( &
      & a, b, c)
      integer, intent(in)     :: a
      real,    intent(inout)  :: b
      logical, intent(out)    :: c
   end subroutine routine_TROUBLE

Thanks for the report! This was actually an issue in the language server (see issue above). It should now be fixed in master and will be included in the next patch.


Presentation Exchange: Required Constraints

As per https://github.com/decentralized-identity/presentation-exchange/issues/361

updated spec here https://github.com/decentralized-identity/presentation-exchange/pull/368


v0.5.x broken when used with @marko/run-adapter-node/middleware

When used with a custom Express server, as per https://github.com/marko-js/run/tree/main/examples/node-express, v0.5.x results in a broken build. Works fine with 0.4.12 and earlier.
See reproduction in https://github.com/vwong/marko-run-bug

Fixed with 0.5.7


No match for {:ok, _} = Logger.add_backend(Sentry.LoggerBackend)

Environment

Elixir version (elixir -v): 1.8.1
Erlang/OTP version (erl): 10.3
Sentry version (mix deps): 7.0.6
Operating system: MacOS

Description
I just integrate with Sentry and this code did not work for me:
{:ok, _} = Logger.add_backend(Sentry.LoggerBackend)

i'm getting this error at build time:
** (Mix) Could not start application apollo: exited in: Apollo.Application.start(:normal, [])
    ** (EXIT) an exception was raised:
        ** (MatchError) no match of right hand side value: {:error, :already_present}
            (apollo) lib/apollo/application.ex:9: Apollo.Application.start/2
            (kernel) application_master.erl:277: :application_master.start_it_old/4

I removed the pattern matching to build and it logged the event in Sentry, is it really necessary or is there something wrong in my config?

It looks like you may be adding it multiple times.
Is this in an umbrella app?

I added in all the apps inside the umbrella

{:error, :already_present} suggests the Logger backend has already been added.  It's only necessary to make that function call once, so if you're calling it in each umbrella application, you'll get that error.

got it! thanks!
I need apps to be independent of each other, so I'll create an app to initialize the sentry and add this app as dependencies of the others, thus ensuring that it will only be initialized once.


Updating events with past ones, and 3 new ones

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/mixed-reality, working directory: W:\r0ed-s, target branch: master, target branch commit: 42f4c3d594b58dae09ca786e354bc7538d49593e, source branch: 034b0209a3da52de8911ed2e0b84078e/master, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/sf-academy-events.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Feature] Use encryption to store SSH passwords and set a master password for decryption

You can set your own password
After the setting is completed, you can add a new password.
The password can probably be encrypted using aes256 (or better)
Every time you open ssh, it will check whether a password has been set and enter the password automatically.
I think this will be useful!

Hello @MHNightCat thank you very much for the idea. I thought about this feature, but deliberately decided to not go into this rabbit whole 🐰 The reason is very trivial - I don't have enough expertise in data security and therefore I cannot take a risk of storing users' passwords. Though, it can be quite straightforward to implement the functionality, it will be much much harder to do that properly. That's why I encourage people to use SSH keys instead. I hope you understand my concerns.
Users' convenience and data security always go into opposite directions and we need to balance somewhere in between. 🙂
Roman.

I totally understand. Thank you for your reply.
This cli app is really great!


ARROW-6978: [R] Add bindings for sum and mean compute kernels

Was curious how easy this would be and what issues I'd run into. So far I've only done sum() but will also add mean, min, max.
Issues so far (cc @wesm):

See workarounds in sum.Array. (1) missing/null values are always dropped, while R provides an option for how to treat missingness. Interestingly, it looks like min and max do have this null option supported (in MinMaxOptions) but sum and mean do not (yet).
(2) There is no sum method for boolean type
There is no sum implemented for Scalars, which may be fine (I would expect it to be no-op for numeric types, just thought logically it maybe shouldn't error)
Summing integers seems to promote to return int64 if given int32 (I didn't try with smaller ints), even when overflow is not a danger (I was adding numbers 1 to 5). It would be nice if it returned the same type it got unless it has to go bigger to avoid overflow.

Good observations. If you open JIRA issues for these we can address each one in due course, none strike me as too difficult (with the null/not-null thing, what we would do is short-circuit and return null if there is any null. Maybe you want to implement that "in software" in R since I'm unclear how useful the option is in C++)

I can make JIRAs.
Check and return NA if there are any NA is what I did in R in this PR. That works, of course, but I wonder if we do want it in C++ for consistency with other functions (min/max handle this in C++ already, for example).

OK, we should introduce a ScalarAggregateOptions providing null handling behavior, then

Also for pandas such null-skipping option woudl be useful (although the default there aligns with what arrow already does, but pandas also exposes that as an option)

Summing integers seems to promote to return int64 if given int32 (I didn't try with smaller ints), even when overflow is not a danger (I was adding numbers 1 to 5). It would be nice if it returned the same type it got unless it has to go bigger to avoid overflow.

This would mean that the output type starts to depend on the values of the input, and not just on the types of the input (which is something to avoid, I think?).
But does the kernel machinery allow right now to specify the output type? (or is this always implicitly inferred from the input types?) This is how numpy solves this: by default it will also use int64 for the result, but it has the option to specify the output dtype (so you could do np.array([1, 2, 3], dtype="int8").sum(dtype="int8") to preserve int8 type for the sum)


helm lint with-subcharts applies wrong values to subcharts

Hi,
I think I found a logic bug in the helm lint validation.
The following command work fine:
helm lint . -f tests/test.yaml
But this make troubles
helm lint --with-subcharts . -f tests/test.yaml
My believe is that the passed tests/test.yaml data of ingress.host is passed to each subchart as root data for values.yaml, but it shell just pass relevant data to the schema validation.
In my scenario the root chart/schema validates correct because ingress.host is a valid struct for the root chart. Though for whatever reason the webserver charts fail, because they know a schema for ingress (a schema that knows ingress.hosts but knot ingress.host ) and they see data for ingress that should not be there and was never defined, because it belongs just to the root chart.
Output:
[root@localhost chart]# helm lint --with-subcharts . -f tests/test.yaml
==> Linting .

==> Linting charts/common-0.0.0.tgz

==> Linting charts/coreconnect/charts/mssql-0.0.10.tgz

==> Linting charts/coreconnect/charts/webserver-1.2.11.tgz
[INFO] Chart.yaml: icon is recommended
[ERROR] values.yaml: - ingress: Additional property host is not allowed
- ingress: Must validate all the schemas (allOf)
- (root): Must validate all the schemas (allOf)

[ERROR] templates/: values don't meet the specifications of the schema(s) in the following chart(s):
webserver:
- ingress: Additional property host is not allowed
- ingress: Must validate all the schemas (allOf)
- (root): Must validate all the schemas (allOf)

==> Linting charts/graylog-2.3.4.tgz

==> Linting charts/netdesigner

==> Linting charts/netdesigner/charts/common-0.0.0.tgz

==> Linting charts/netdesigner/charts/redis-17.16.0.tgz

==> Linting charts/netdesigner/charts/webserver-1.2.11.tgz
[INFO] Chart.yaml: icon is recommended
[ERROR] values.yaml: - ingress: Additional property host is not allowed
- ingress: Must validate all the schemas (allOf)
- (root): Must validate all the schemas (allOf)

[ERROR] templates/: values don't meet the specifications of the schema(s) in the following chart(s):
webserver:
- ingress: Additional property host is not allowed
- ingress: Must validate all the schemas (allOf)
- (root): Must validate all the schemas (allOf)

==> Linting charts/netparser

==> Linting charts/netparser/charts/common-0.0.0.tgz

==> Linting charts/netparser/charts/webserver-1.2.11.tgz
[INFO] Chart.yaml: icon is recommended
[ERROR] values.yaml: - ingress: Additional property host is not allowed
- ingress: Must validate all the schemas (allOf)
- (root): Must validate all the schemas (allOf)

[ERROR] templates/: values don't meet the specifications of the schema(s) in the following chart(s):
webserver:
- ingress: Additional property host is not allowed
- ingress: Must validate all the schemas (allOf)
- (root): Must validate all the schemas (allOf)

==> Linting charts/netshop

==> Linting charts/netshop/charts/common-0.0.0.tgz

==> Linting charts/netshop/charts/mysql-9.19.1.tgz

==> Linting charts/netshop/charts/redis-17.16.0.tgz

==> Linting charts/smtp-0.0.0.tgz

Error: 19 chart(s) linted, 3 chart(s) failed

tests/test.yaml
---
ingress:
  host: "bla-net.local"

Output of helm version:
version.BuildInfo{Version:"v3.14.0", GitCommit:"3fc9f4b2638e76f26739cd77c7017139be81d0ea", GitTreeState:"clean", GoVersion:"go1.21.5"}
Output of kubectl version:
Client Version: v1.29.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
The connection to the server localhost:8080 was refused - did you specify the right host or port?
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
not relevant

agree, this seems like a bug

Also seeing this...

Same here!

Please take a look at the proposed solution for this issue: #13155

I'm seeing the same problem here - the current grafana/loki chart (6.7.4) does not lint if it's in a subchart - I did not find a way to work around it. It seems that in my case, any $.Values references in the subchart resolves to nil...


I can not render mi webpage when headless is true

Hello. I expose my problem. I am trying to access a website with PuppeteerSharp which, conveniently and on purpose, I will not be able to access. This is because the only thing I need is a code that generates that website after performing several actions that are not relevant now.
The question is: if I set "headless" to "false", the page will not load after a few seconds, but google will generate a web view as shown on the screen. When generating it, my code will be found in the HTML code and I will be able to get it (image 1)

On the contrary, if I set my "headless" to "true", the page will not load, but google does not generate the preview in which my code is inserted. It stays as a completely blank screen, as seen on the screen (image 2)

Is there anything I can do?

How is your code inserted in the Chrome error page?


SVIDs are not readable by containers running as a different user

When you have a pod with a container running as a different user than the sidecar container, the SVID file can't be read because permission is denied. This is because the file is chmodded as 0600. The only way to avoid this is to either change the running user (not possibly if you have multiple containers that need access to the token and each run as a different user) of the sidecar or set an fsGroup on the pod's securityContext.
In our case, we are adding the spiffe-helper on the workload's behalf (in this case using a mutating admission webhook). We didn't feel it was safe/appropriate to modify the fsGroup for every single pod using the platform.
I'm suggesting we allow the file's chmod to be configured.

If it helps, this reproduces this problem
kind: ConfigMap
apiVersion: v1
metadata:
  name: helper-conf
data:
  helper.conf: |
    agent_address = "/run/spire/agent/socket"
    jwt_svids = [
      {
        jwt_svid_file_name = "/etc/jwts/aws.jwt"
        jwt_audience = "sts.amazonaws.com"
      }
    ]
---
apiVersion: batch/v1
kind: CronJob
metadata:
  name: spiffe-job
spec:
  schedule: "*/1 * * * *"
  concurrencyPolicy: Replace
  successfulJobsHistoryLimit: 1
  failedJobsHistoryLimit: 1
  jobTemplate:
    spec:
      template:
        spec:
          containers:
            - name: main
              image: busybox
              args: ['/bin/sh', '-c', 'cat /etc/jwts/aws.jwt; echo "";']
              volumeMounts:
                - name: jwts
                  mountPath: /etc/jwts
              securityContext:
                runAsUser: 1337
                runAsGroup: 1337
                readOnlyRootFilesystem: true
          initContainers:
            - name: wait-for-svid
              image: ghcr.io/spiffe/spiffe-helper:nightly
              volumeMounts:
                - name: helper-conf
                  mountPath: /etc/spiffe-helper
                - name: spire-agent
                  mountPath: /run/spire/agent/socket
                - name: jwts
                  mountPath: /etc/jwts
              command: ["/spiffe-helper", "-config", "/etc/spiffe-helper/helper.conf", "-daemon-mode=false"]
              securityContext:
                runAsUser: 10000
                runAsGroup: 10000
                readOnlyRootFilesystem: true
            - name: spiffe-helper
              image: ghcr.io/spiffe/spiffe-helper:nightly
              restartPolicy: Always
              volumeMounts:
                - name: helper-conf
                  mountPath: /etc/spiffe-helper
                - name: spire-agent
                  mountPath: /run/spire/agent/socket
                - name: jwts
                  mountPath: /etc/jwts
              command: ["/spiffe-helper", "-config", "/etc/spiffe-helper/helper.conf"]
              securityContext:
                runAsUser: 10000
                runAsGroup: 10000
                readOnlyRootFilesystem: true
          restartPolicy: Never
          volumes:
            - name: helper-conf
              configMap:
                name: helper-conf
                items:
                  - key: helper.conf
                    path: helper.conf
            - name: spire-agent
              hostPath:
                type: Socket
                path: /run/spire/agent/socket
            - name: jwts
              emptyDir:
                medium: Memory
          securityContext:
            runAsUser: 1505
            runAsGroup: 1505
            runAsNonRoot: true

https://github.com/spiffe/spiffe-helper/pull/173/files#diff-81a0c52a44e81d83f6dd8ba18dfbc635501d877dcbcaf058141883987e008542R39 introduced this breakage.


Fix undefined error in evaluate function

Fix issue #17124

Hey, thanks! You can just do this._list && this._list.length > 0 and that should fix the issue more succinctly.
Can you change it?

done

@LeaVerou do you have an estimate when are you going to merge it into main branch?

Oops, I forgot about this! Merged now, thanks for fixing it! (and for your patience!)


sqlcipher: 4.4.0 -> 4.4.2

Motivation for this change
fixes https://github.com/NixOS/nixpkgs/issues/106239
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110768 run on x86_64-darwin 1

6 packages built:

python37Packages.patator
python37Packages.pysqlcipher3
python38Packages.patator
python38Packages.pysqlcipher3
qtox
sqlcipher

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110768 run on x86_64-darwin 1

6 packages built:

python37Packages.patator
python37Packages.pysqlcipher3
python38Packages.patator
python38Packages.pysqlcipher3
qtox
sqlcipher

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110768 run on x86_64-linux 1

1 package marked as broken and skipped:

retroshare

8 packages built:

kmymoney
python37Packages.patator
python37Packages.pysqlcipher3
python38Packages.patator
python38Packages.pysqlcipher3
qtox
skrooge
sqlcipher

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110768 run on x86_64-linux 1

1 package marked as broken and skipped:

retroshare

8 packages built:

kmymoney
python37Packages.patator
python37Packages.pysqlcipher3
python38Packages.patator
python38Packages.pysqlcipher3
qtox
skrooge
sqlcipher

backport: https://github.com/NixOS/nixpkgs/pull/110790

backport: https://github.com/NixOS/nixpkgs/pull/110790


add the ability to start docker images

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 141 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 9.281%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

docker/dockercli.go
0
68
0.0%

docker/docker.go
0
73
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
222

Relevant Lines:
2392

💛  - Coveralls


Allow Module::load to accept AsRef

Is your feature request related to a problem? Please describe.
It allows to avoid PathBuf::to_str and the subsequent .unwrap() in my use case.
Idk if the change of the Module::filename to the OsString works.
Describe the solution you'd like
    pub fn load(filename: impl AsRef<Path>) -> Result<Self, std::io::Error> {
        let contents = read_to_string(filename)?;
        Ok(Self::new(filename, &contents))
    }

Describe alternatives you've considered
Nothing.
Additional context
Nothing.

The reason it currently isn't supported is because deno_core doesn't accept it upstream so Module could accept it, but then the runtime may be unable to load them.
It seems wise to move that limitation as far up in the call chain as possible

It actually seems like it may no longer be the case
I will look into this further

Does in fact seem to work!
I have opened a PR on deno_core to fix resolve_path upstream, but have it working on my end already
Since it does require changing the signature of Module::filename incompatibly I will go from 0.7 to 0.8 for this change


Bug in categorical for the C backend

Below is a snippet of C code produced by HKC for the categorical statement for the naive_bayes benchmark, and is generated by this portion of the C backend.
r_h4 = ((((double)rand()) / ((double)RAND_MAX)) * exp(ws_h3));
ws_h3 = log(0);
it_h2 = 0;
while (1)
{
  if ((r_h4 < exp(ws_h3)))
  {
    out_g.weight = 0;
    out_g.sample = (it_h2 - 1);
    break;
  }
  ws_h3 = logSumExp2(ws_h3,_h1.data[it_h2]);
  it_h2++;
}

The problem is that, as implemented, this code causes a segmentation fault by accessing memory outside the valid range of _h1.data. In this example _h1.length == 10 while it_h2 == 9258. Clearly out of bounds, but the error is not observable until we run afoul of memory access protection.
There two potential things wrong with this code which could cause the issue observed here.

Looking at the values in the _h1 array which has type struct array_prob, all the values are ~4400. This is a somewhat non-sensical value for a probability (particularly in log domain). That seems odd to me, but perhaps this is valid for Hakaru. For the sake of categorical, all the elements have more or less the same probability, so it should be picking the values more or less uniformly for this example.
The termination condition r_h4 < exp(ws_h3) will never test true.  exp(4000) == inf, and inf < inf is always false. If the values in the _h1 array are valid, then categorical needs to handle these cases. It looks like the implementation of categorical in LogFloatPrelude handles this by dividing every value by the maximum, then sampling from the resulting array.

What is a "large" input? Is the input the size of the array or the positive reals in the array?
I haven't tested the old code (before the patch today) much to try to replicate this bug, but even with an array of 10,000,000 I do not segfault. This is a program I tried to break it with:
categorical(array _ of 10000000: 10000)

the error is not observable until we run afoul of memory access protection
What do you mean here?

In this case, "large" means that the probabilities in the given array are large. The input size of the array in my example above is only 10 elements.
When I say large, I mean that the physical representation of the probabilities in the runtime is large. That is, the value in memory of the log-spaced probabilities is >4000 in the case of naive_bayes. Thus, a naive exponentiation results in +inf being used in the termination criterion.
In your example, categorical(array _ or 10000000: 10000), that 10000 is placed into log-space, so it is still safe to exponentiate by categorical.

the error is not observable until we run afoul of memory access protection

What do you mean here?

The input array to categorical is small, only 10 elements. The program does not crash, however, unit it is indexed at its 9258th element. Everything between there and element 10 is garbage that the program accesses but will not crash the program. The benchmark segfaults only when it reaches a region of memory that has not been allocated to it by the OS.
I pushed a commit (f2e2b73) which I think fixes the issue, but a review would be welcome. It tries to copy the behavior of categorical in LogFloatPrelude.

did this fix it for you? I finally got around to testing hkc with naive_bayes and am getting SIGSEGV errors. Were you able to create another program that fails?

After these fixes, the naive_bayes benchmark works fine for me. Did naive_bayes fail with commit f2e2b73?

That commit failed as well. Which commit of naive_bayes are you using?

I should note that there is an error in the FFI specification that interfaces the C code with the Haskell code. The FFI specification is
gibbsC :: ArrayStruct Double
       -> ArrayStruct Double
       -> ArrayStruct Int
       -> ArrayStruct Int
       -> ArrayStruct Int
       -> Int
       -> IO (ArrayStruct Double)

but the return type of the C code is mdata_nat. The segfault you are seeing is caused by trying to print the results of the C code in Haskell. I pushed a commit to the naive_bayes repo which should fix the problem.

Yeah problem solved. Thanks!


feat: import labels from json (#56)

closes #56
labels are imported from the docs/label.json file (this might need to be moved in the future)
Future improvements, check for changes to docs/label.json only

Great 👍  thanks @nhcarrigan for reviewing, definitely ended much better than what I started with 🤓


Request to Add OpenSSL Support in "cupsHashData" (cups/hash.c) Function for AirPrint Web UI Interface

Dear Team.
I am Sahaya Darcius from Bixolon Co., Ltd, and I hope you all doing well. As a part of our ongoing efforts to develop AirPrint support for our printers, we have been using the PAPPL framework, CUPS 2.4.5, and OpenSSL-1.1.1g. While our printing functionality has been successfully implemented, we have encountered an issue with the Web UI interface.
Upon conducting a thorough analysis, we have identified the root cause of the problem, which lies in the "cupsHashData" function within the "papplClientGetCSRFToken" function in the "client-accessors.c" file. It has come to light that this function returns incorrect Hash binary data.
Upon further investigation, we discovered that the "cupsHashData" function in the "cups/hash.c" file only supports GnuTLS and does not extend its compatibility to OpenSSL. The discrepancy in the algorithm values passed from the "papplClientGetCSRFToken" function is another contributing factor, as it uses "sha2-256," whereas OpenSSL expects "sha256."
In light of these findings, we have taken the initiative to resolve the issue by implementing our own hash data function for sha256 using OpenSSL. I am delighted to inform you that this solution has proven to be successful, and the Web UI is now functioning optimally.
However, we believe that adding OpenSSL support to the "cupsHashData" function in the "cups/hash.c" file would greatly enhance its usability and flexibility for other users facing similar challenges. Therefore, I kindly request your esteemed team to consider integrating OpenSSL support into the "cupsHashData" function.
Your support in implementing this enhancement will undoubtedly benefit many users in the community who rely on CUPS and OpenSSL for their printing solutions.
Thank you for your time and consideration.
Best Regards,
Sahaya Darcius P

Hi @sahayap ,
if your new hash function is part of open source code and applicable after changes into CUPS code, it would be great if you opened a pull request.
I've created a PR implementing the function in OpenSSL - it was interesting to try OpenSSL for once.

@zdohnal I already have the code in the libcups repository, was planning on copying it over along with the other changes for CUPS 2.5... We can also apply the hash changes for CUPS 2.4.x...

@michaelrsweet I've taken the commit from master for this and applied in 2.4.x directly (review of the merge sounded as waste of your time since it is a plain copy of your commit from master - without translation typo fix - do let me know if you would like to do reviews of such commits too next time).
I didn't see any API breakage and build+test passed on my machine.
Fixed in master and 2.4.x

This commit breaks builds of cups without gnutls/openssl as it drops the #ifdef HAVE_GNUTLS logic and makes gnutls required if openssl is not available, which is unfortunate given the security fixes in 2.4.7.
Could the #ifndef HAVE_GNUTLS logic be instantiated please?

Ouch, I'm sorry for that - the removal should happen in 2.5, so the fix has to be a little bit different in 2.4.x - I've created PR here https://github.com/OpenPrinting/cups/pull/794 .
But be aware TLS library like OpenSSL/LibreSSL or GnuTLS are required since 2.5.


mark imported docs, this will remove the 'edit this page' link

cf https://fluxcd.io/docs/contributing/flux2/

vs https://deploy-preview-269--fluxcd.netlify.app/docs/contributing/flux2/

I have this wild idea of storing the origin of the imported document in the frontmatter, and then using this to show an alternative (and functioning) edit button.


0.3.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@mariusvniekerk you recently helped with the r-tiledb-feedstock package in switching to tinytest. We've been stuck on this dependency update for a while because the windows build package is failing with make: *** No rule to make target '$(CXX11STD)''.  Stop..
This update doesn't change anything with the build structure compared to the last successful release of 0.3.0. Any chance you have some insights, or can point us to someone who can help, into why on windows it can't find a c++11 compiler?

@conda-forge-admin, please rerender


[Bug Report] Autocomplete input throw error on change event

Element UI version
2.13.1
OS/Browsers version
Chrome Version 81.0.4044.113 (Official Build) (64-bit) / MacOS 10.15.4
Vue version
2.6.11
Reproduction Link
https://codepen.io/daofresh/pen/BaoQgbe?editors=1011
Steps to reproduce

Type something in the autocomplete input
Click any option or click outside the input
Check the console

What is Expected?
No error in the console
What is actually happening?
Error appears in console

same problem

same problem, you can change version 2.13.1 to 2.31.0

same problem, you can change version 2.13.1 to 2.31.0

2.31.0 exist?

same problem, you can change version 2.13.1 to 2.31.0

2.31.0 exist?

No. It's normal.

same problem, you can change version 2.13.1 to 2.31.0

2.31.0 exist?

you can change ^element-ui: 2.13.0 to element-ui: 2.13.0 in your package.json file，and delete your local node_moudles and then npm install

I think this is a consequence of the change to emit a change event on clear.

I like react，because it throw event handler

same problem, you can change version 2.13.1 to 2.31.0

2.31.0 exist?

No. It's normal.

太可爱了吧，我真的去install了

4d前dev分支改了这个问题，不知道啥时候能发版，坐等发版升级

same problem, you can change version 2.13.1 to 2.31.0

2.31.0 exist?

No. It's normal.

太可爱了吧，我真的去install了

hahaha. I do apologize, I got mistake. The normal version is 2.13.0.


Network Device creation fails due to ACL template

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform Version
Terraform v0.13.5

provider developer.equinix.com/terraform/equinix v1.0.0 (master)

Affected Resource(s)

equinix_network_device

Terraform Configuration Files

resource "equinix_network_device" "network-edge" {
  name               = var.name
  throughput         = var.throughput
  throughput_unit    = var.throughput_unit
  metro_code         = var.metro_code
  type_code          = var.type_code
  package_code       = var.package_code
  notifications      = var.notifications
  hostname           = var.hostname
  term_length        = var.term_length
  account_number     = var.billing_account
  version            = var.sw_version
  core_count         = var.core_count
  # Include redundant device when ha is set to true
  dynamic "secondary_device" {
    for_each = var.ha ? [1] : []
    content {
      name           = "${var.name}-secondary"
      metro_code     = var.metro_code
      hostname       = var.hostname
      notifications  = var.notifications
      account_number = var.billing_account
    }
  }

Debug Output
Error: cannot fetch primary network device ACLs due to Equinix REST API error: Message: "Not Found", HTTPCode: 404, ApplicationErrors: [Code: "", Property: "", Message: "", AdditionalInfo: ""]

Expected Behavior
With the introduction of ACL template in ECX, it is no longer possible to create a network device without specifying the aclTemplateId attribute. It is also not clear whether the template should be created first and referenced in the device resource definition or other way around. Looking at the aclTemplates branch I see that the device UUID is an attribute of the ACL template, but as of today you cannot create a device without specifying the template ID.
If the ACL is specified as a list, the ECX backend converts it to a template, but the provider apply still fails with the REST error:
Error: cannot fetch primary network device ACLs due to Equinix rest error: httpCode: 404,

Actual Behavior
The apply fails with the REST API error
Steps to Reproduce

terraform apply

@abudilov this should be fixed by #19

Closing the issue as November release went to prod and ACL template feature was merged.


Multiple requests

Describe the feature you'd like

Share function (preferably e-mail)
Ability to submit for article corrections
Did this article help you section
Add GIF's

Describe the benefits this feature would bring to BookStack users

The share function would help those in the K-12 IT like myself giving internal users the ability to share articles amongst themselves to benefit each other
Article corrections are handy for those that find updated ways to deploy software and want to submit these changes with description for review and then approve those changes adding it to the article
Feedback from the community of "your users" helps to get stats of whether the article was helpful or not anonymously
Gif's would give us the ability to add tasks in motion and giving end users a visual way of viewing the process they need to follow in the article

Thanks for the input @athornfam2 but I'm going to close this off since multi-request issues are hard to track & manage and since some of these are already open in some form.
GIFs should be supported, if there's an issue uploading/using a GIF feel free to file a bug report issue.


High resource usage

When running in debug mode, the Electron hosted app will use up a lot of RAM. Not sure if this happens only when the app is hidden in the tray or not.

Either case, when the app is unfocused, it could potentially throttle down all requests to the node and network.

The current instance was responsive of sorts, but the dev-tools was white and unresponsive.

The current instance was responsive of sorts, but the dev-tools was white and unresponsive.

Currently fully responsive, but uses a lot of resources:

Currently fully responsive, but uses a lot of resources:


New nuget release?

I wanted to installed this project as a Nuget packet but the last release 0.6.17 is from 2018 and it seems that much have happen since then. Is it possible to create a new release that can be installed in this way?
Thanks!

I've made a forl of the repo at https://github.com/Chinchilla-Software-Com/HubSpot.NET
I've made a few enhancements and fixed a few things
The latest nuget packages are published at https://www.nuget.org/packages/_SquaredUp.HubSpot.NET/


Copy repository url to clipboard with JS

Most browser today support document.execCommand('copy') so it would be nice to have this option instead of the 1-step flash or 3-step JS solution

Another solution is to simply use https://clipboardjs.com/

Ideally, you would create a pull request.
Alternatively, you could attach a patch as a file to this issue.
If you need help with either of the two, let mw know.
The solution I would implement would work like the one used earlier with the Flash button, i.e. click the copy button to copy the URL. Which is not unlike Github does it.

ok for copy button. ...

To integrate a copy button (remove flash button et prompt button) do this (it is a js solution) :

download clipboard.js from https://clipboardjs.com/ : https://codeload.github.com/zenorocha/clipboard.js/zip/refs/heads/master
copy from this archive the file clipboard.js-master/dist/clipboard.min.js into src/main/resources/clipboard.js/clipboard.min.js
edit file src/main/java/com/gitblit/wicket/pages/BasePage.html line 56 after
copy the code

save the file
edit file "/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.html"
find (line 18) replace all
 ...
 by

  [repository primary url]

save the file
try it (see image) ....

I was just spending some time, looking into clipboardjs and the ways it can be integrated. Is there any specific reason why you chose the function an to work with a parent element?

I have started the implementation in pull request #1438. Feel invited to review it.
Do you have a good idea how to display a tooltip, like when you click the copy button on Github's repository page? It will give you a "Copied" tooltip for a few seconds.

Is there a specific reason why you chose the an function to work with a parent element?

Yes, I don't know the java framework used and it removes the "span" declaration when it affects the text. So, I wrote a button where the click is used by the clipboardjs library.  The problem is then to recover the text (without knowing the Id, because it is the java framework that puts it). So I use the parent as search point followed by the "clipboard-text" class. It's easier and can be adapted to many situations.
In general, I try to decorate the back-office from UX/UI (front office)
PS : usually, I use Java back offices as data service, and the user interface, I write it in html/js/css with the framework Aurelia.io (kind of Angular framework, VueJS, but simpler) => MVC.
Here, if I understood correctly, the framework mixes controller+vue,  like React does in JS.

I will look at
From:   "Florian Zschocke" @.>
To:     "gitblit/gitblit" @.>
Cc:     "piradix" @.>, "Comment"
@.>
Date:   20/11/2022 19:13
Subject:        Re: [gitblit/gitblit] Copy repository url to clipboard
with JS (#1241)
I have started the implementation in pull request #1438. Feel invited to
review it.
Do you have a good idea how to display a tooltip, like when you click the
copy button on Github's repository page? It will give you a "Copied"
tooltip for a few seconds.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID:
@.***>

Do you have a good idea how to display a tooltip, like when you click the copy button on Github's repository page? It will give you a "Copied" tooltip for a few seconds.

I'll look for

I added some code for a tool tip.

I added some code for a tool tip.

Can I see it ? (branch ... tag ... )

@piradix, if you didn't find any issues with it I'm going to merge the pull request.

I see the icon "copy", but click don't work (no event are under it).
In fact, it doesn't download the 2 new js file "clipboard.min.js" and "gitblit-ctcbtn.js".
These files exist in "/Gitblit/src/main/resources/clipboard/"
I suppose is due to component use line 56 of BasPage.html  <wicket:container wicket:id="bottomScripts"></wicket:container>
And if you want to put the icon to the right of line and not after the text, write the icon in first of line, then in it style add "float: right". => all copy icon'll be align to right line. It is more beautiful for sub menu of git, Smartgit/hg ...
Example :
/span>
Otherwise the line size will not be good (=>css hack). See image ...

Which browser do you test with an how do you run Gitblit?
I tested with Firefox and had Gitblit running from the IDE and with "moxie run" under macOS as well as building a GO version and installing it on a Linux machine and testing from localhost as well as through a reverse proxy. The copy worked in all cases.

I tried with Eclipse as IDE on macOS, Firefox 107. I do see the .js files getting downloaded in the dev tools network tab, and copying as well as the tooltip work for me. Same with Safari.

It run getBottomScriptContainer()
But it don't run method addBottomScript()

I find the problem

if depot is empty (no file), you get my problem (see image): buttons are show but disabled.
else all are right

Ah, excellent! Thank you!

There seems to be no french translation for the empty repository page. If you like, feel free to contibute one.

Where is the I18n properties file to translate or other files ?

You find the english file under src/main/java/com/gitblit/wicket/pages/EmptyRepositoryPage.html and would create a new src/main/java/com/gitblit/wicket/pages/EmptyRepositoryPage_fr.html file.

The French version, see zip file
EmptyRepositoryPage_fr.zip

The French version, see zip file
EmptyRepositoryPage_fr.zip


Date range picker issues in (and not in) Firefox

I noticed some small issues with the date range picker and I'm too dumb to fix them so hopefully someone else can :D (these screenshots are from the example in the docs)

In Firefox, every selected cell is rounded:

And in browsers other than Firefox, there are some corners sticking out of the first selected cell (it's hard to see but it's there)

Fixed in PR: https://github.com/shadcn-ui/ui/pull/1852
about the firefox behavior, has an opened bug about has selector + pseudo-element

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


UP-4877: Improving ADA for Marketplace

Checklist

[x] the individual contributor license agreement is signed
[x] commit message follows commit guidelines
[x] message properties have been updated with new phrases
[x] view conforms with WCAG 2.0 AA

Description of change
https://issues.jasig.org/browse/UP-4877

Added role to table headers and added header. Also added caption.
Added alt attribute to icons.
Changed the options list and added rule to each item..
Added a css specification to darken the disabled text.
Added aria attributes where necessary.
Improved accessibility to dialog.
Improved overflowing issues.

great job !
2017-07-20 14:14 GMT+02:00 dorisgjata<EMAIL_ADDRESS>
@dorisgjata commented on this pull request.
In uportal-war/src/main/webapp/WEB-INF/jsp/Marketplace/portlet/entry.jsp
https://github.com/Jasig/uPortal/pull/954#discussion_r128497556:

@@ -512,7 +519,7 @@
<portlet:renderURL var="initialViewWithFilterURL" windowState="MAXIMIZED">
<portlet:param name="initialFilter" value="${portletCategory}"/>
</portlet:renderURL>

- ${portletCategory}

- ${portletCategory}

I fixed this on the last commit
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/Jasig/uPortal/pull/954#discussion_r128497556, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABaa1uflvDcI_9zjImaVhL5AE2lyh4pwks5sP0SrgaJpZM4ObwkF
.

Three :white_check_mark: Approvals, no pending changes requests that I see, merging this.
Thanks @dorisgjata and @colcampbe3! Looking forward to the PR bringing the changes to version 5.

Heya @dorisgjata and @colcampbe3, is there any update on forward-porting these changes to uPortal 5.0?

Hey @asgrant and @bpowell :wave:  are there still plans to forward port these fixes to uPortal :five: ?

Hey @ChristianMurphy,
I would like to start work on work on porting changes to uPortal 5, but I'm having some difficulty working with it, and would need a little direction to get us started.
The main problem is that I would like to be able to test my changes somehow, but I don't know how to deploy my uPortal 5 to run in Tomcat with the edits I've made (since the marketplace files are in uPortal 5). The uPortal 5 docs say that there's some way to deploy uPortal 5 on its own, but I wasn't able to find anything helpful in the docs on how to do that. I know uPortal-start exists, but I don't know how to use that to run   my local edits of uPortal 5.
If you could point me in the right direction, I'd gladly run through making these changes.

Hey @colcampbe3! :wave:
uPortal no longer includes deployment code.
uPortal-start is now used to run uPortal 5. :new:

A quick summary the new setup:
in uPortal
./gradlew install # builds snapshot to maven local

Then in a different folder
git clone https://github.com/Jasig/uPortal-start
cd uPortal-start
edit gradle.properties # change `uPortalVersion` to `5.0.0-SNAPSHOT`
./gradlew portalInit
./gradlew tomcatStart
# You should be able to access the snapshot portal on `localhost:8080/uPortal`

The uPortal-start README.md includes above information and more.
If you run into issues with the build, the uPortal-dev members (including myself) are happy to help.


[navtree] drag-and-drop of object into empty collection doesn't work

https://github.com/user-attachments/assets/1d929b3d-0330-4a52-bb95-1cde5c951653
EDIT: This only happens if it's an empty collection

Dragging vertically and not horizontally will rearrange items — in order to drag an object into a collection, it needs to be dropped below and to the right of the collection in order to trigger that operation.
The position cycling is probably a bug of some kind, though.

Closing because this is intentional (what you do to drop into the collection is move the mouse to the right).
Feel free to reopen if you want an issue for the cycling behavior, but it doesn't seem that important to me.


No scrolling happening when scrolling on the .simplebar-track container

Hello,
when scrolling on the scrollbars track (.simplebar-track), the contents of the container don't scroll. When setting the z-index to a negative number, scrolling works. Do you see any problems in changing the z-index this way?
Thank you

Yeah you won't be able to drag the scrollbar with the mouse.
I didn't find a solution for this yet.

I see. I didn't notice at first. Thank you for your help.


Index documentation / source

I am trying from pynamodb to dyntastic and I am finding trouble to understand how to use indexes or which ones are supported. I've found some misleading clues:
https://github.com/nayaverdier/dyntastic/blob/main/dyntastic/main.py#L66
# TODO: support INCLUDE projection?
        self.projection = "KEYS_ONLY" if keys_only else "ALL"

https://github.com/nayaverdier/dyntastic/blob/main/dyntastic/main.py#L98
        validated, fields_set, errors = validate_model(model, item)
        if errors:
            # assume KEYS_ONLY or INCLUDE index

https://github.com/nayaverdier/dyntastic/blob/main/README.md?plain=1#L164
DynamoDB Indexes using a `KEYS_ONLY` or `INCLUDE` projection are supported:

So what are the projections supported?
Also, how could we use the dyntastic.Index class so I can add the index as a field to another model?

@photonbit That is confusing from the source, thanks for pointing that out. The first comment, from Index, is only used for table creation, which is meant just for setting up tests at this point, and that only supports keys only indexes.
But all indexes should be supported, just by passing the index name as a string to the query function. If an index does not include all the attributes, the resulting models will error when you try to access a missing attribute (until you call refresh(), or if you pass load_full_item=True to query.


Backport of dbalek's fixes made after Apr 22, 2017

This is a batch commit of changes for NetBeans 9 done during legal review of sources already being reviewed and donated. These changes were not part of original donation and contain important fixes for Apache NetBeans to work on/with JDK9.

Are you the author of all these changes? The "Backport of dbalek's changes" title seems to imply that you are, but if not the authors need to be identified.

Yes, he's the author.

Why do you think the changes are not mine?

Because there's so many. It's a compliment. :-)

That is cumulative work since April till now :-)

Cool! I did not imply the changes are not yours, just verifying that they are as it's important in an Apache context. With my incubation mentor hat on...we're all good, thanks for clarifying.

OK, looked through them, makes sense to me, merging.


Support Google Drive syncing for native google docs/sheets

The API responses for Google docs and sheets have null checksums and null download links.  The sync code relies on the download link to stream the file to S3.  Add support for these files using the approach outlined here.  Will need to pick default mime types for docs and sheets.  Ex: Word for docs, Excel for sheets.

Handy to find google sheet id


Add missing generic type for Angular 9

Summary of changes:
Added the generic type in module declaration to support Angular 9.
Checklist:

[X ] npm run build runs without error
[X ] ng serve spawns app, Intercom messenger is visible and interactive, and there are no errors in the console

Closes issue: #101

Sorry if I did something wrong, this is my first attempt at a pull request :)

Thanks for the PR! 🎈🎈🎈I’ll take a look at soon as I can.

This looks good, except you're also going to want to upgrade @angular/* in devDependencies (so that it compiles with latest angular) and in peerDependencies (so that consumers don't get type collisions with Angular 8-). Thanks for the PR!

Hello,
What's the status? Waiting for this merge : )
Thx


suggestions - split & exact search

olo
thank you for sharing
i used this module as per example in docs
as an average python non-professional (wanna-be) programmer,
i have huge difficulties splitting the query result into simple strings
i tried .split(','), multiple for loops and other suggestions / codes from google search, failed
i checked result type, got 'class main.city'
question
how must i write a pycities code, so i can easily split a result like ie
proper returned single city :
name = result[1]
longitude = result[2]
country_name = result[3]
or, if multiple cities are returned :
name = result[0][1]
longitude = result[0][2]
country_name = result[0][3]
i tested by querying 'paris', limit = 5
i got results, including 'parys', 'annapolis', 'new orleans', which makes no sense to me
so i would suggest to add parameter for exact search (matching name parameter),
or to also search by ie country_name, at the same time,
so wrong results are discarded before they reach users eyes & consequently brain
have fun
aum

ok, i tried to hire sherlock holmes, he is too busy, so i opted to chatgpt
below is a working example code
import sys
from dataclasses import dataclass

from pycities import RowFactoryModelConfig, CityDatabase, dict_factory
# we need location / name & country
name = "paris"
country = "france"

@dataclass(frozen=True)
class City:
    id: int
    name: str
    country_name: str
    latitude: str
    longitude: str
    timezone: str

    def __str__(self):
        return f" {self.id}, {self.name}, {self.country_name}, {self.latitude}, {self.longitude}, {self.timezone}"

# create row factory for your custom model
def city_factory(cursor, row) -> City:
    return City(**dict_factory(cursor, row))

# set your factory config for custom model
RowFactoryModelConfig.set(City, city_factory)
# create new instance with our model; fetch wanted fields
db = CityDatabase[City](
    fetch_fields=(
        "id",
        "name",
        "country_name",
        "latitude",
        "longitude",
        "timezone",
    )
)
# connect to database
try:
    db.connect()
    result = db.search(query=name, lang="en", limit=5)
    # print("result type : " + str(type(result)) + "\n")  # > list
    for res in result:
        if name.lower() != res.name.lower():
            continue
        if country.lower() != res.country_name.lower():
            continue
        print(f"res.name : {res.name}")
        print(f"res.country_name : {res.country_name}")
        print(f"res.latitude : {res.latitude}")
        print(f"res.longitude : {res.longitude}")
        print(f"res.timezone : {res.timezone}")
    db.close()
    print("pycities: get coordinates for location - success")
except Exception as e:
    print(f"exception : {str(e)}")

long live pycities
have fun


Doc: class diagrams

Output can be previewed here: https://my-lisa.readthedocs.io/en/lisa-next/kernel_tests.html

Hmph, the TestBundle diagram needs plantuml & graphviz to be installed. I might just generate that locally and commit the image.

Generating the images locally implies you have to commit in binary images, which means we kind of lost the benefits in having just textual representations to version control, isn't it?
I probably like better the idea to add the required dependencies to the lisa-install script, maybe guarded by an explicit flag, something similar to what we do for the SDK.

If there's no objections then I'll add these dependencies.


awesome-font and github logo added

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: adhavalboy sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for the PR but I don't like the addition of the GitHub logo here–it creates an inequity among the three "Made with ______" callouts at the bottom, and I'm trying to keep a developer-y text-based aesthetic here.
But, again, thank you for this. Your PR is noted!


Add middleware lock while dequeuing the stack

Throw an exection when trying to add a middleware in a dequeing stack

Can you make the property protected, and add a docblock for it?

Sure,
it's done

Thanks!

You're welcome :)


Error handling is poor

Error handling in OpenBLAS is currently poor and inconsistent. Some routines, such as gemm_driver, call exit when memory cannot be allocated; that's a no-no for library code. Other routines are even worse: they fail to check whether memory has been allocated and just continue, causing segfaults. Error messages may be printed, but sometimes to go to stdout, sometimes to stderr.
Apple's BLAS has a SetBLASParamErrorProc function that allows installing a custom error handler. Implementing this API in OpenBLAS might be a good idea.

I got OpenBLAS: malloc failed in gemm_driver when using 80 threads. What is the maximum number of threads I can use without running into these malloc issues?

Strange - what is your hardware, and how much memory do you have ? The job array in the gemm driver is only on the order of 20 bytes per thread, and I do not recall this ever having been an issue

This is my hardware (it's a cluster in a university).
Type: Silicon Mechanics Rackform R2504.V6
OS: Linux Ubuntu 18.04 LTS
Processor: x2 20-core Intel(R) Xeon(R) CPU E5-2698 v4 @ 2.20GHz
RAM: 512 GB RAM

hmm, that hardware looks normal enough (though I'm not sure if I have something similar enough to reproduce the problem). Does it happen with a reasonably recent OpenBLAS, and with some publicly available source ?

I use Julia 1.9 with Flux 0.14.6. I don't actually know what my version of OpenBLAS is. I don't have a MWE because I have only gotten this error once, so I have not made a MWE but the code I was running was training a deep NN, if that helps at all.

I do not know Flux, but both version numbers appear to be current so I'm assuming your OpenBLAS is too. Best I could do at this point is have the error message write exactly how much memory it was trying to allocate at that point - but it cannot have been much, and I see no practical way for continuing with the GEMM call once it happens. The vast majority of OpenBLAS' memory requirement is in the memory buffer, sized at build time according to the maximum number of threads supported by that build. Would it be possible that your ML code itself was running in parallel, and making concurrent calls into OpenBLAS at the time (so effectively N*80 threads) ?

I really doubt that. When I set the number of threads to 8 (I have not tried a higher number) I do not get this error. I will report here if I see this error again.


FirefoxOS: control A2DB connexion

When I'm listening to a podcast using my car speakers (connected using A2DP to my phone), the music application interferes with HF: play events are triggered when:

the connexion is established
the car's sound volume is changed
I then have to manually stop the music player on FxOS to continue listening to my podcast.

Additionally, it would be great if the play/pause button of the car could play/pause HF.
(Bluetooth API seem to require a certified app, unfortunately.)

We've rethought the direction of the app; anything requiring packaged/certified Firefox OS APIs isn't going to be implemented.


Redux-logger and redux-batched-actions

I made a gist of how to tune redux-logger to work nicely with redux-batched-actions. May be worth adding to examples section). Here is before/after example.

Added, thank you!