Automated Package Upgrade

:tada: This PR is included in version 12.0.43 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[all hosts] (Resources) Adding April Community Call link

Docs Build status updates of commit e9412b1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/office-add-ins-community-call.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


🏪 Add Trader Stage Support

Don't want to sell them too early 😀

opted to slot this under the electricTier3 Trader Stage requirement


feat: gestion onglet documents-263

:tada: This PR is included in version 0.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Instance Constructor as Static member?

In Function Member Invocation it lists Instance Constructor as a Static Member.  Just wanted to check and see if that is right.
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/expressions#function-member-invocation

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e783650c-e063-e268-316e-564362cb1e37
Version Independent ID: aa9f4996-cab4-0bed-6452-213342453785
Content: Expressions
Content Source: spec/expressions.md
Product: dotnet-csharp
GitHub Login: @dotnet-bot
Microsoft Alias: wiwagn

Thanks for spotting this and pointing out the issue @Mandated
I've submitted a PR with the fix:  dotnet/csharplang#2111

Moving to dotnet/csharplang.   See dotnet/csharplang#2209
Closing here.


Confusing alpha channel in ColorPicker

Describe the bug
The alpha channel in the ColorPicker is a bit confusing: the value represented in the TextBox (where you can type or paste the HEX color) uses the ARGB form, but the order of the color sliders is RGBA.
Also, when the IsAlphaEnabled property is set to false, the alpha control is still visible (although disabled)
Screenshots

I did a deeper review here and don't think it can be "fixed" without causing other people to complain. Bottom line though, this issue shouldn't be a bug and is more of a discussion at this point.
** Hex formats ARGB vs RGBA **

[ARGB] This is a big one, XAML itself uses #AARRGGBB or #ARGB format. This started back in WPF and continues with Avalonia for compatibility. The hex color parser is obviously setup to handle only this format and can't be changed to auto-detect ARGB or RGBA. For this reason alone we likely cannot change the hex input box default -- it should match other cases in Avalonia.
[ARGB] Both the WPF Color struct and Avalonia's Color struct use ARGB format in the constructors and in FromArgb() methods. Again, this establishes the XAML convention.
[ARGB] WinUI ColorPicker : The WinUI ColorPicker was the original basis for this control in Avalonia. It is the reason for the "confusion" points you mentioned above. The WinUI ColorPicker has the same issues (however they refer to Alpha as Opacity and use a percentage)

[RGBA] CSS added (in-draft still...) the hex color notation with alpha in #RRGGBBAA format. I really, really, wish this aligned with XAML but it doesn't. XAML pre-dates CSS here by quite a bit and unfortunately they chose different formats. I would argue CSS format is actually better though as optional parameters should go at the end. Additionally, it matches with rgba() and hsla() notation parameter ordering.

https://drafts.csswg.org/css-color/#hex-notation
https://caniuse.com/css-rrggbbaa

[RGBA] In Avalonia 11 it is now possible to define colors using some CSS function notation like rgba() or hsla(). This was done for compatibility with CSS and what users are used to in that case. However, the alpha component is at the end and it does differ from hex values. This isn't so bad in this case because ordering is clear by the rgba( prefix itself.
[Other] Looking at photo editing apps like Gimp and PhotoShop, these apps don't even have an alpha channel in the color edit dialogs. That makes them useless as examples for this discussion.

This also relates to an older discussion: https://github.com/AvaloniaUI/Avalonia/pull/7724#discussion_r816374775.
I'm debating a few things here since there isn't a way to make everyone happy here. Someone is going to think it's wrong no matter what is done:

Leave it alone, it matches XAML and the WinUI ColorPicker
Add another property to actually control the color format RGBA or ARGB. That would allow XAML standard as default but also CSS RGBA format which is more popular now.

That opens up potential secondary issues though: Should it use existing Avalonia color format enums? (no, probably not) Should this control the alpha slider position as well?

Rename the alpha slider to opacity like WinUI

Alpha Slider Enabled/Visible
I'm not planning to change the behavior here. IsAlphaEnabled and IsAlphaVisible allow controlling this just like Control.IsEnabled and Control.IsVisible. The concept is already established. If you want to hide the slider use IsAlphaVsisible.
That said, the hex value should be removing the alpha component when both IsAlphaEnabled=False and IsAlphaVisible=False. It currently isn't.

One addition: I think if you are happy if the sliders are matching the order of #ARGB this is easy to achieve if you provide your own control template for ColorView. Basically copy & paste the original and reorder the sliders.
Original style to edit: https://github.com/AvaloniaUI/Avalonia/blob/30438713d1dbee8cb168520d3b2d25e79ba9e973/src/Avalonia.Controls.ColorPicker/Themes/Fluent/ColorView.xaml#L507-L731

I suppose another idea here is to change alpha hex format in Avalonia from XAML ARGB to CSS RGBA formats. That would fundamentally fix this once and for all (while making more sense too, optional parameter at the end).
However it would break a lot of apps in difficult to find ways. Don't think it would ever be considered a good idea for this reason.

I would like to add a new property to control the hex input format -- and only the hex input format (sliders will stay matching WinUI for now). That should be a good compromise and allow devs to use RGBA when they want to match CSS or the slider ordering.
However, naming the enum is tricky at it should be generalized more than just ARGB and RGBA (even though the hex input is only using those formats right now). I'm leaning towards something like the below. Feedback welcome.
enum AlphaPosition
{
    // ARGB or AHSV, etc.
    Leading,

    // RGBA or HSVA, etc.
    Trailing
}

// In ColorView
public AlphaPosition HexAlphaPosition { get; set; }

That is planned to be addressed; however, I still don't consider it a bug and its by design matching WinUI. Please comment on the original issue if you have any suggestions for the new enum.

@berruezo any thoughts on this?

I need some feedback here or I probably won't be implementing a change for a while. Its best not to create a new enum and property like this without some discussion/feedback. People usually have differences of opinion and right now it matches WinUI.
Additionally, if the author of the issue doesn't consider it important enough to engage I have to think it isnt enough of an issue to spend time on it for now. Everyone is busy. Please engage in the discussion if you want changes.

Pinging @berruezo for an alternative channel. He may answer tomorrow sorry for the delay.

Sorry, I didn't get notified about the new replies in the thread
The enum looks good to me, it would allow us to have the same order for the sliders as for the hex value, which was the main point of concern. I find the name of the property and values pretty accurate with what it's doing.

I've added support for these changes in https://github.com/AvaloniaUI/Avalonia/pull/10439.
ColorView now has the HexInputAlphaPosition property which can be used to configure this to match XAML/WinUI (ARGB) or CSS (RGBA).
I decided to set the property default value to AlphaComponentPosition.Trailing which is what you initially wanted. The reasons are compelling:

It matches the now more widely used CSS standard
It matches the default slider ordering as shown to end-users

The only downside is it now differs by default than the WinUI control and XAML hex formats. However, it's better future proofed following CSS. It's also better to change it now before the control is released in a stable version of Avalonia. This can be switched back to the XAML/WinUI by setting the property directly on the control to Leading.

Cool! About this other issue:

That said, the hex value should be removing the alpha component when both IsAlphaEnabled=False and IsAlphaVisible=False. It currently isn't.

Is it also fixed in #10439?

@berruezo I opened #10816 to fix the last issue above.


Review AddXyz() method overloads to make the API more consistent

Currently we have a mix of overloads that take some discrete parameters for things like file names and optionality and overloads that take lambdas for things like reload. Even in the simplest usage in the default templates we have a mix that doesn't seem very cohesive (see https://github.com/aspnet/Templates/pull/477). This item is to track doing some API review and if possible cleanup and rationalize what we have to make it better.

In the templates review today the feedback was that the lambda overloads of the AddXyz() methods have a lot of syntax overhead and that we should have overloads with discrete parameters for the simple cases, including one that takes both optional  and reloadOnChange.
cc @haok @davidfowl @DamianEdwards @rustd

Also moving this to RC2.

This is what the template should look for RC2
            var builder = new ConfigurationBuilder()
                .SetBasePath(env.ContentRootPath)
                .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true)
                .AddJsonFile($"appsettings.{env.EnvironmentName}.json", optional: true);

As part of this change can we also remove any existing APIs that take ReloadOnChanged as follows
Configuration = builder.Build().ReloadOnChanged("appsettings.json");

7e98d3c1dcb107a7c46cee5019f888268da109b5

@rustd @phenning Now that these are in, templates can switch to these new overloads

@phenning Can you please update the templates with the next coherence signed build?


Wrong link for pictures? Some don't show

line 1196 : https://changelog.qgis.orgimages/entries/5959d2a149797fdbd8108653dad86b4ba93d54a1.gif should probably be:
images/entries/5959d2a149797fdbd8108653dad86b4ba93d54a1.gif
line 1197 : https://changelog.qgis.orgimages/entries/f8d2510c5cdf7241f1ed61a9bdd0211f1d6fb0f7.gif should probably be:
images/entries/f8d2510c5cdf7241f1ed61a9bdd0211f1d6fb0f7.gif
line 1210 : https://changelog.qgis.orgimages/entries/f0cad8bbc2de6c44b22c4875c45ed6e24e9f4bf6.png should probably be:
images/entries/f0cad8bbc2de6c44b22c4875c45ed6e24e9f4bf6.png
line 1213 : https://changelog.qgis.orgimages/entries/44767fa890705c09d9c4b21b998807c7999ddde4.gif  should probably be:
images/entries/44767fa890705c09d9c4b21b998807c7999ddde4.gif
line 1214 : https://changelog.qgis.orgimages/entries/3a408fbcff1ee8d5889c3fe30c0d9d831b050698.gif  should probably be:
images/entries/3a408fbcff1ee8d5889c3fe30c0d9d831b050698.gif
line 1231 ; https://changelog.qgis.orgimages/entries/fd1a05c782e4e2e487a5ed876dc6c396269b0acf.gif should probably be:
images/entries/fd1a05c782e4e2e487a5ed876dc6c396269b0acf.gif

@DelazJ  Harrissou,  would you have a look at this?
Don't know if you have already seen it.
Thanks in advance

@DiGro I will have a look later, but I think I have to do a new export and manually add the images. The links you provide are not valid, AND we should not link back to changelog.qgis.org, the links should link to local copies.
Thanks for brining it up though, I had not seen it (because Firefox does not show the 'broken image' icon...

@rduivenvoorde I maybe misunderstand you but I think @DiGro's changes are correct; they do not link to changelog site but instead remove the references and the images they link to are already available in this repo.
What looks weird to me is that the build did not error while using changelogs URL which do not exist.

@rduivenvoorde Did you have time to check this PR? Thanks

@DelazJ @DiGro ah sorry, slipped in time...
Yes works, I was wrong about missing images. Images are just there. Thanks @DiGro !!


Added method to convert an Elemental HTMLElement to Errai HTMLElement to deal with legacy Views

@tiagobento Would you mind to review?
Cherry picked from: https://github.com/errai/errai/pull/343

Jenkins please retest this


docs: add optional initialData [SignInScreen]

add initialData: FirebaseAuth.instance.currentUser in  SignInScreen to avoid get null  in authStateChanges() even with user is signed in.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Thanks @rubensdemelo for the PR, I've tweaked a little bit.

Should I make any change ?

Not sure about that statement, because even user isnt signin, initialData: FirebaseAuth.instance.currentUser will return false.
And on first build, authStateChanges returns null.

Hey @rubensdemelo, not sure what you mean? See here.
Also - the example uses a condition where it won't matter if it is null or false:
  if (!snapshot.hasData) {
      return SignInScreen(
        providerConfigs: []
      );
    }

Thanks


Full site testing of WP 6.2

@mikethicke that weird second login is back. Seems like every time we update that issue comes back.

Testing completed.


update randomatic dependency to v3.0.0

being included as a dependency for rollup-watch (which is deprecated), so just removing that devDependency.


Dev

In order to keep python 2.7 compatibility, switch from using the
“flush” parameter for the print function to using sys.stdout.flush().

Quick fix for flushing out the output.


Notification-Service app extension Linker error: "Framework not found AdaEmbedFramework"

Attempting to build an iOS 13 project on simulator using Xcode 14.3. Ventura OS, M1 machine. My other comrades have no problems on various other OS and Xcode versions.
Running SDK: 1.3.9
Getting only linker error:
Framework not found AdaEmbedFramework
Have tried:

Update pod file iOS spec to project iOS version as they were mismatched:
https://stackoverflow.com/questions/63727672/framework-not-found-pods-onesignalnotificationserviceextension

Updating to latest version, 1.8.0

Perhaps it's some other problem and Ada is just the alphabetical first framework to fail.
**additional note **:
I have also tried removing extension references as discussed below, as the frameworks are "inherited" from the actual app target, without success:
"As it turned out, the problem appear to be that my extension initially was "too heavy". After stripping it from all third-party package references, I was finally able to build and run it on M1 Mac as well"
https://stackoverflow.com/questions/70001083/notification-service-extension-starting-on-iphone-ipad-but-not-on-m1-mac

Leaving a note that the issue above is unrelated to this dependency. It was necessary to run simulators through Rosetta and now it's OK


fix: disable ios automatic extra space behavior when pasting

Details
Implemented a new prop in the RN TextInput called smartInsertDelete. This prop will allow us to disable the extra space that iOS system put when we paste something inside a input like the Composer.
Two PR's were made to the upstream RN repo and Expensify RN repo respectively:

https://github.com/facebook/react-native/pull/36111
https://github.com/Expensify/react-native/pull/40

I also included a patch in this PR to address this changes and it can be removed later when we have a new RN version to use.
Fixed Issues
$ https://github.com/Expensify/App/issues/14049
PROPOSAL: https://github.com/Expensify/App/issues/14049#issuecomment-1420923599
Tests

Go to any report.
Copy the content of a message.
Paste the content inside the Composer a few times. It should not insert extra spaces before the pasted content.
Edit a message and paste something a few times. It should not insert extra spaces before the pasted content.

Offline tests
This feature doesn't change or is impacted by offline mode.
QA Steps
Same as above.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/20051562/218173952-3db8b4d2-7641-4a4f-b0d7-d3a23e00aa7e.mov
https://user-images.githubusercontent.com/20051562/218174002-eb7867a3-2130-4cc9-a48a-a4d04bb8cf96.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/20051562/218174535-19a81e2e-e89b-4a5c-a47c-5bf640775f9e.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/20051562/218174979-ec279a4a-fff7-42ce-9702-f0785ebff64a.mov

Desktop
https://user-images.githubusercontent.com/20051562/218175033-d4bad106-8bd1-42b4-8611-f917ad4e0f96.mov

iOS
https://user-images.githubusercontent.com/20051562/218175337-eae96f11-1894-4cd0-8147-87af2fc3c240.mov

Android
https://user-images.githubusercontent.com/20051562/218176578-e46b3a59-3746-4dae-b728-1961599a6049.mov

I have read the CLA Document and I hereby sign the CLA

Hi @mountiny , I was revisiting my PRs and noticed that the issue related to this one was closed as being fixed. But the issue is not fixed in iOS yet as we can see in the following video:
https://github.com/Expensify/App/assets/20051562/8075ea87-17a5-43e2-b034-0e27d48108a1
To actually fix the issue we need to merge this PR. I can confirm that we already have the smartInsertDelete prop available to use on main branch as it is using Expensify RN 0.71.2-alpha.3, which includes this fix.
So, I just need to remove the patch from this PR and merge it to fix the issue. In the following video I added the smartInsertDelete prop in src/components/Composer/index.ios.js file on main branch to show that we can use the prop now.
https://github.com/Expensify/App/assets/20051562/098f244e-d30a-4e7c-b7d1-53797e81fa8e

@fabioh8010 thanks for the heads up, I think we can keep that issue closed
Sorry I got a little bit lost on this PR, are we holding for the RN update you are working on right?

@mountiny What I mean is that the fix I did in our RN fork is already available on Expensify/App main branch, so I would just need to update this PR to remove the patch and it could be tested and merged.

@fabioh8010 ah, ok then please update the PR and we can tag C+ to help with the PR testing

@fabioh8010 the HOLD in the title is not needed anymore right?

@mountiny Yes, we can remove the HOLD and test the PR, I removed the patch.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/3069065/acd27f37-ff67-48ae-ada1-2a41790ab236

Mobile Web - Chrome
https://github.com/Expensify/App/assets/3069065/8a0e0a8a-0cad-4a12-9a75-3128593b7b90

Mobile Web - Safari
https://github.com/Expensify/App/assets/3069065/a5417a51-c711-4a7b-b612-aac47ab43c76

Desktop
https://github.com/Expensify/App/assets/3069065/9c8d4f2f-5bbf-46af-9ed1-aafe0b5dfb43

iOS
https://github.com/Expensify/App/assets/3069065/b778874f-aae2-4139-b437-d2d391cf27b0

Android
https://github.com/Expensify/App/assets/3069065/e749ef8e-d5da-4e0b-9773-8e2a9f0e592a

Thanks for the patience here. @mountiny All yours, tested this on Composer.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix "undefined symbol: luaopen_libpng" when running torch-android

libpng is a high usage lib for android' image related apps. Thus, when android has already loaded "libpng" module in system, the other "libpng" library generated by torch-image module would have a name conflict issue. Thus, when lua tried to require 'libpng', the dlsym() func would always return the original lib handle, which leads that torch cannot find "luaopen_libpng" exported func.
Solution: we rename this lib to avoid name conflict issue.

if you could rename it from luajit_png to lua_png, this PR is good to go.

thank you!


🐛 [Paperless-NGX] Unable to install OCR language

Which addon?

Addon name : Paperless-NGX
Addon version : 1.10.2

Describe the bug
Package tesseract-ocr-NLD not found! :(
It does not matter what language you use none of them will be installed it seems like

To Reproduce

Install addon (fresh installation)
Go to configuration tab and enter NLD as language (as can be found here: https://tesseract-ocr.github.io/tessdoc/Data-Files-in-different-versions.html)
Absorve the log that it cannot be installed

Full addon log
/etc/cont-init.d/99-run.sh: executing
[12:26:39] INFO: Defining variables
[12:26:40] INFO: Starting redis
[12:26:40] INFO: Initial username and password are admin. Please change in the administration panel of the webUI after login.
Paperless-ngx docker container starting...
243:C 12 Dec 2022 12:26:40.601 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
243:C 12 Dec 2022 12:26:40.601 # Redis version=6.0.16, bits=64, commit=00000000, modified=0, pid=243, just started
243:C 12 Dec 2022 12:26:40.601 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf
243:M 12 Dec 2022 12:26:40.606 * Running mode=standalone, port=6379.
243:M 12 Dec 2022 12:26:40.606 # Server initialized
243:M 12 Dec 2022 12:26:40.606 # WARNING overcommit_memory is set to 0! Background save may fail under low memory condition. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
243:M 12 Dec 2022 12:26:40.607 * Ready to accept connections
Installing languages...
Hit:1 http://deb.debian.org/debian bullseye InRelease
Get:2 http://deb.debian.org/debian-security bullseye-security InRelease [48.4 kB]
Get:3 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB]
Get:4 http://deb.debian.org/debian-security bullseye-security/main amd64 Packages [209 kB]
Fetched 302 kB in 2s (189 kB/s)
Reading package lists...
Package tesseract-ocr-NLD not found! :(
Package tesseract-ocr-ENG already installed!
Package tesseract-ocr-DAN not found! :(
Mapping UID and GID for paperless:paperless to 0:0
Creating directory /tmp/paperless
[nltk_data] Downloading package snowball_data to
[nltk_data]     /config/addons_config/paperless_ng/nltk...
[nltk_data]   Package snowball_data is already up-to-date!
[nltk_data] Downloading package stopwords to
[nltk_data]     /config/addons_config/paperless_ng/nltk...
[nltk_data]   Package stopwords is already up-to-date!
[nltk_data] Downloading package punkt to
[nltk_data]     /config/addons_config/paperless_ng/nltk...
[nltk_data]   Package punkt is already up-to-date!
Adjusting permissions of paperless files. This may take a while.
Waiting for Redis...
Connected to Redis broker.
Apply database migrations...
Operations to perform:
  Apply all migrations: admin, auth, authtoken, contenttypes, django_celery_results, documents, paperless_mail, sessions
Running migrations:
  No migrations to apply.
Did not create superuser, a user admin already exists
Executing /usr/local/bin/paperless_cmd.sh
2022-12-12 12:27:16,775 INFO Set uid to user 0 succeeded
2022-12-12 12:27:16,782 INFO supervisord started with pid 246
2022-12-12 12:27:17,788 INFO spawned: 'gunicorn' with pid 609
2022-12-12 12:27:17,794 INFO spawned: 'celery' with pid 610
2022-12-12 12:27:17,800 INFO spawned: 'celery-beat' with pid 611
2022-12-12 12:27:17,807 INFO spawned: 'consumer' with pid 612
2022-12-12 12:27:17,813 INFO spawned: 'celery-flower' with pid 613
Checking if we should start flower...
2022-12-12 12:27:17,877 INFO success: celery-flower entered RUNNING state, process has stayed up for > than 0 seconds (startsecs)
2022-12-12 12:27:17,888 INFO exited: celery-flower (exit status 0; expected)
2022-12-12 12:27:18,891 INFO success: gunicorn entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2022-12-12 12:27:18,891 INFO success: celery entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2022-12-12 12:27:18,892 INFO success: celery-beat entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2022-12-12 12:27:18,892 INFO success: consumer entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
[2022-12-12 11:27:23,401] [INFO] [paperless.management.consumer] Using inotify to watch directory for changes: /config/addons_config/paperless_ng/consume
[2022-12-12 11:27:23 +0000] [609] [INFO] Starting gunicorn 20.1.0
[2022-12-12 11:27:23 +0000] [609] [INFO] Listening at: http://[::]:8000 (609)
[2022-12-12 11:27:23 +0000] [609] [INFO] Using worker: paperless.workers.ConfigurableWorker
[2022-12-12 11:27:23 +0000] [609] [INFO] Server is ready. Spawning workers
/usr/local/lib/python3.9/site-packages/celery/platforms.py:840: SecurityWarning: You're running the worker with superuser privileges: this is
absolutely not recommended!
Please specify a different user using the --uid option.
User information: uid=0 euid=0 gid=0 egid=0
  warnings.warn(SecurityWarning(ROOT_DISCOURAGED.format(
[2022-12-12 11:27:25,273] [INFO] [celery.beat] beat: Starting...

 -------------- celery@86689438-paperless-ng v5.2.7 (dawn-chorus)
--- ***** -----
-- ******* ---- Linux-5.15.74-x86_64-with-glibc2.31 2022-12-12 11:27:25
- *** --- * ---
- ** ---------- [config]
- ** ---------- .> app:         paperless:0x7f7c3cc48eb0
- ** ---------- .> transport:   redis://localhost:6379//
- ** ---------- .> results:
- *** --- * --- .> concurrency: 1 (prefork)
-- ******* ---- .> task events: ON
--- ***** -----
 -------------- [queues]
                .> celery           exchange=celery(direct) key=celery

[tasks]
  . documents.tasks.bulk_update_documents
  . documents.tasks.consume_file
  . documents.tasks.index_optimize
  . documents.tasks.sanity_check
  . documents.tasks.train_classifier
  . documents.tasks.update_document_archive_file
  . paperless_mail.tasks.process_mail_accounts
[2022-12-12 11:27:25,550] [INFO] [celery.worker.consumer.connection] Connected to redis://localhost:6379//
[2022-12-12 11:27:25,563] [INFO] [celery.worker.consumer.mingle] mingle: searching for neighbors
[2022-12-12 11:27:26,596] [INFO] [celery.worker.consumer.mingle] mingle: all alone
[2022-12-12 11:27:26,682] [INFO] [celery.apps.worker] celery@86689438-paperless-ng ready.

Full addon config
CONFIG_LOCATION: /config/addons_config/paperless_ng/config.yaml
OCRLANG: ENG NLD
PAPERLESS_OCR_MODE: skip
PGID: 0
PUID: 0

Please try in lowercase. I need to adapt the readme

Was just about to write that haha, it is indeed lower case :)
Perhaps change this: https://github.com/alexbelgium/hassio-addons/blob/master/paperless_ngx/rootfs/etc/cont-init.d/99-run.sh#L14
to:
if bashio::config.has_value "OCRLANG"; then export PAPERLESS_OCR_LANGUAGES=$(bashio::config "OCRLANG",,); fi

Thanks, pushed! Please check if the language really is added in paperless ngx (that is the second expected step). Thanks

Yes it is now installing it but not activating it. The config.yaml file should also be adjust to include the language in the PAPERLESS_OCR_LANGUAGE line. (this is without a s at the end.
PAPERLESS_OCR_LANGUAGES=<list>

    Additional OCR languages to install. By default, paperless comes with English, German, Italian, Spanish and French. If your language is not in this list, install additional languages with this configuration option:

PAPERLESS_OCR_LANGUAGES=tur ces

To actually use these languages, also set the default OCR language of paperless:

PAPERLESS_OCR_LANGUAGE=tur

Defaults to none, which does not install any additional languages.

(source: https://docs.paperless-ngx.com/configuration/#docker)


Using the correct color when File Icon Type is set to Monochrome

Description
Added CoolGray color and applied to icons when file icon type setting is set to monochrome.
Related Issues

#1764

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] The issues this PR addresses are related to each other
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] My changes are all related to the related issue above
[x] I documented my code

Screenshots

Fix swiftlint issues.


Make name field optional to simplify syntax

When defining geometries I often name my solid/volume the same as the variable that holds the object (e.g. val foo = solids.box("foo", 1,1,1)). I am finding myself doing too much "copy and paste", perhaps there can be a default value such as the name of the object (reflection) or in case this is not available some random not in use name.
Also I recommend looking into https://geant4.web.cern.ch/sites/geant4.web.cern.ch/files/geant4/collaboration/working_groups/geometry/docs/textgeom/textgeom.pdf, the Geant4 Text Geometry plain text description (which can be exported to GDML). In this description you can define physical volumes without the need of defining its solid / volumes first. I found this description very useful and user friendly to write simple geometries, perhaps we could integrate some of the best parts of this description.
Text Geometry: Tube physical volumes defined in a single line
:VOLU target TUBE 0 50 100 G4_Ge
:PLACE target 1 world R00 0. 0. 0.

Example where this happens a lot:
https://github.com/mipt-npm/gdml.kt/blob/e01cd969ae621ba4661ef8d51fcb72e0a28efc1e/gdml-script/src/test/kotlin/babyIAXO.gdml.kts

Done in 0.4.0-dev-1. It is a breaking change for places where the name is in the first place. See showcase examples for the reference.


Create lowest_common_subsequence.cpp

made c++ file for lowest common subsequence between two numbers.
Assigned Issue Number?
#001
Language Opted?
C/C++/Python/Java/...
Number of files added or updated?
1/2/3
Name of these files?
main folder => sub_folder => ... => ... =>  file.py
example :
Algorithms => Searching => Linear_Search => Linear_Search.py
Checklist

[ ] I was assigned for this otherwise my PR will be rejected.
[ ] I've read the contribution guidelines.
[ ] I've referred the correct issue number.
[ ] I've filled up this entire template correctly.

:star2: this repository and support.

made pull request !


Clean up duplicate/unused metrics in controller

This PR cleans up duplicate or unused metrics in Pinot controller.
e.g. the following validation metrics are duplicate comparing to the hourly metics:
offlineSegmentDelayMillis
lastPushTimeDelayMillis
Removing these two validation metrics can help reduce the number of metrics a lot in Pinot controller.
The controller metric CONTROLLER_NOT_LEADER as a global metric isn't valid any more.
The controller metrics LLC_KAFKA_DATA_LOSS can be removed because it's duplicate with LLC_STREAM_DATA_LOSS.

Codecov Report

Merging #4750 into master will decrease coverage by 19.48%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #4750       +/-   ##
=============================================
- Coverage      57.7%   38.21%   -19.49%
=============================================
  Files          1207     1207
  Lines         64766    64743       -23
  Branches       9414     9413        -1
=============================================
- Hits          37371    24740    -12631
- Misses        24568    37741    +13173
+ Partials       2827     2262      -565

Impacted Files
Coverage Δ
Complexity Δ

...g/apache/pinot/common/metrics/ControllerMeter.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

.../core/realtime/PinotLLCRealtimeSegmentManager.java
62.99% <ø> (-11.37%)
0 <0> (ø)

...apache/pinot/common/metrics/ValidationMetrics.java
76.27% <ø> (+35.17%)
0 <0> (ø)
:arrow_down:

.../helix/core/realtime/SegmentCompletionManager.java
38.51% <ø> (-31.39%)
0 <0> (ø)

.../org/apache/pinot/common/http/MultiGetRequest.java
0% <0%> (-100%)
0% <0%> (ø)

...nullvalue/RealtimeNullValueVectorReaderWriter.java
0% <0%> (-100%)
0% <0%> (ø)

...n/function/PercentileEstMVAggregationFunction.java
0% <0%> (-100%)
0% <0%> (ø)

...che/pinot/common/restlet/resources/TablesList.java
0% <0%> (-100%)
0% <0%> (ø)

...ransformer/timeunit/CustomTimeUnitTransformer.java
0% <0%> (-100%)
0% <0%> (ø)

...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java
0% <0%> (-100%)
0% <0%> (ø)

... and 595 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74aea85...09931aa. Read the comment docs.


Apply SPA best practices

Mainly, leverage browser caching, since there are lots of images to be dowloaded by the client.

Added caching for all GET requests, as well as "must-revalidate" header. Problem is, preflight requests are made this way, even with the addition of .WithExposedHeaders() within the middleware's CORS configuration. According to performance metrics in dev env, minimal overhead is added this way. Consider doing more research in the topic as per https://dunglas.dev/2022/01/preventing-cors-preflight-requests-using-content-negotiation/


transport speed is abnormally low

Hi
I run quic server and client on local machines. But I found out that the transport speed between client and servers are abnormally low, around 1500 bps for 50MB file, 137bps for 200MB file. I run quiche-server and quiche-binary. I'm wondering if this is the usual performance of quiche or is there anything I need to change.

How are you measuring the speed? Some trace logs and packet captures would help understand things better.

Hi, I'm measuring the speed with the .stats() method. I run the binary of quiche-server and quiche-client, don't think I can do RUST_LOG=trace.
The command run server is ./quiche-server --root ~/quic/quiche/tools/apps/target/debug  --listen  <IP_ADDRESS>:4433 --cert ~/quic/quiche/examples/cert.crt --key ~/quic/quiche/examples/cert.key,
run client is   ./quiche-client https://<IP_ADDRESS>:4433/output.dat --no-verify
I run both server and client on one single server seprated by namespace, the traffic flows to another server and then traverse back.
Here is the topology.

We've discussed this in the Slack and there seemed to be some issues with your testbed's performance. Is that still the case? Can we close this issue since the reproduction criteria seem hard without more detail.

Yes, sorry for taking it so long. I'll close it now.


Provide HTTP/2 server example in the website

Right now, hyper.rs only provides an HTTP/1 server example. It might be a good idea to add an HTTP/2 version.
Also see https://github.com/hyperium/hyper/issues/3411

Sure, any help with the documentation is always welcome!

I would like to contribute, can I take up this issue? @dswij

It's yours if you want it @n1haldev , I am swamped.


Fix tennis

This pull request will fix issue #56, which returns tenni while pluralize.singular('tennis').
Since Tennis is usually uncountable, I added the word to uncountables array.
Here is reference for word tennis

https://en.wiktionary.org/wiki/tennis

Coverage remained the same at 100.0% when pulling d931a4b5c4ccd6b104be2a0c0a8295b31dc287f7 on PeterTeng:peter/fix-tennis into 08e11ddc21211bba4c7dfce77176d0b8a25ac635 on blakeembrey:master.

Thanks!


Table Column Sorting Feature Request

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.
The only issue I found similar was for one section.
Is your feature request related to a problem? Please describe.
I'm always frustrated when I can't sort the tables by headings because it makes it very difficult to easily find data in a large table.
Describe the solution you'd like
I would like to be able to click on the headings in any table and have it sort data by that heading.
Describe alternatives you've considered
The only alternative is that I can think of at the moment is to live with it or switch back to the competitor. :'(
Additional context
No other context at this time.

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.
The only issue I found similar was for one section.
Is your feature request related to a problem? Please describe.
I'm always frustrated when I can't sort the tables by headings because it makes it very difficult to easily find data in a large table.
Describe the solution you'd like
I would like to be able to click on the headings in any table and have it sort data by that heading.
Describe alternatives you've considered
The only alternative is that I can think of at the moment is to live with it or switch back to the competitor. :'(
Additional context
No other context at this time.

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


SqlConnection.OpenWithCreate()?

Context
One of the friction points that we have around databases in .NET Aspire is that for local development we don't automatically create the databases for the user. In deployment scenarios we often do create the database because we emit (in the case of AZD) Bicep that creates the database resource for the various databases that we support in the tree.
I've been looking at various options to decorate the app model with some code to support creating the database but we need to be careful to not suddenly make the app host require client side dependencies just to support this scenario (which could lead to dependency management issues since the AppHost would logically have a dependency thing on everything).
We could create a special package for each database resource type which includes this creation logic but that seems like a sledge hammer.
Proposal
Stepping back a bit the main issue we have is that the database doesn't exist when you first got to connect to it. Tools like EFCore have some extensive plumbing to work around this where you can ensure that the database exists - but we don't have that if say you just want to use SqlConnection directly. The SqlConnection.Open(...) method doesn't allow us to specify that we want the database to be created if it doesn't exist.
But what if it did?
What if we had an API like this:
SqlConnection.OpenWithCreate()
We could potentially provide an extension method in the Aspire application libraries to plaster over this issue. It would mirror what is done in EF today where if the database does not exist it connects to the same server using the default database (it parses the connection string using the builder) and then calls CREATE DATABASE.

@davidfowl @DamianEdwards @eerhardt

I don't think this is the right level to provide this API. If this is generally valuable, it should be in SqlConnection itself. Aspire components generally don't try to wrap or augment the underlying library's APIs, but rather provide the glue necessary to augment an existing client library with the missing pieces to satisfy the "Aspire requirements" (telemetry, config, health checks, etc).
We should be asking ourselves "What about Aspire is making this a problem? Why don't others hit it?" I think the answer is:
By default, .NET Aspire starts the database server from scratch on every F5. Typical application development experiences against databases don't do this. Outside of the "app" someone creates the database server, the database, and the tables. This happens once and doesn't need to happen again on every F5.

We could create a special package for each database resource type

We did this already in #2986.

@roji Thoughts?

If this is generally valuable, it should be in SqlConnection itself

I actually agree. And part of filing this issue and putting up the PR is to facilitate the conversation. What we'd basically be asking here is for the various ADO.NET providers to implement an overload for the Open() and OpenAsync() methods.
It would take some time for that to filter through the ecosystem, so the question is are we happy with folks having to implement this themselves in the meantime?
For example if https://github.com/dotnet/sqlclient decided to take this on, would we need to wait until .NET 9.0 for it?

Note also that "database creation" is only the tip of the issue. The app also needs the tables created, and optionally seeded with data.

The reason database creation comes up often is because it looks like the apphost does create the database (AddDatabase). The user didn't call AddTable so there shouldn't be an expectation that the tables would be created.

builder.AddSqlServer("server").AddDatabase("database"); actually creates the database.

I think this is probably the way customers expect it to work for local development. There are really two broad approaches to make this work:

Add a dependency on Microsoft.Data.SqlClient to Aspire.Hosting.SqlServer and add a hook that creates the database once the server is online.
Inject some script/configure an initialization container to create the database.

I've tried option 2 above but its so clunky that it makes me want to just do option 1 ... but I don't like that because it'll end up pulling all the client libraries into the AppHost as a dependency which could create a bit of a socialisation issue. Perhaps we can do it this way but provided we have enough abstraction we can change the implementation down the track.

Databases use persisted data by default. So the DB isn't wiped away between F5s

There is always a first run. I think if we don't provide people the ability to git clone then F5 then we've missed a big part of the promise of Aspire.

Optionally, database servers stay running and are re-connected between F5s, so I can look at and modify the data in the database without the whole app running.

I think we'll need to make this work for sure.

@nycdotnet what you proposed is not totally out of line with what we were thinking. We had been agonizing a fair amount about bringing client library dependencies into the AppHost. But we've made peace with that now having evaluated some of the other options. If client library dependencies present a problem for folks, then in those specific cases they would need to work around it.
We are doing some experimentation at the moment around an eventing mechanism which would allow firing off logic like creating a database.

The features we're building to implement stop/start/restart commands and to enable waiting for dependencies (the eventing model @mitchdenny mentions) will enable building something like the tasks above. Resources will be able to implement commands backed by code that runs in the app model.
This will not work when deployed and is a local development experience only.


@NonNull on field ignored with manual constructor

Given this class
import lombok.NonNull;
import lombok.ToString;

@ToString
public class Test {
    @NonNull String foo;

    Test() {
        foo = null;
    }

    public static void main(String[] args) {
        Test test = new Test();
        System.out.println("Created a Test " + test);
    }

}

I had expected an exception when calling the Test constructor.  Instead, it printed the Created message, including "foo=null".  Reading the documentation, it seems that a manual constructor prevents the null checks on a field, but this should be highlighted much more strongly.
A better fix would be to have lombok add if (foo == null) throw ... to the end of the constructor.  This would preserve the intuitive contract of "a @NonNull field will not be null"

This is intentional behaviour.


IOS Companion - Not able to close Sound settings when zoom is enabled

What version of Music Assistant has the issue?
2022.7.4
The problem
On IOS, when the zoom setting is activated, the free space is too little to close the overflow menu.

How to reproduce
Enable zoom in the display settings
Relevant log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2022.7
What type of installation are you running?
Home Assistant Container
On what type of hardware are you running?
Raspberry Pi

In version 2022.8.1 I have added a close button on various places for accessibility reasons, including in this slideout menu.


version 1.1.0: nodejs child_process exec used

shelljs replaced by node child_process exec.
Added upgrade the version 4.3.* of cordova to the dependencies.
Example added to README.md

Thank you for your contribution! Merging.

I will submit the new version to npm later today.

Thanks to you...

I've just submitted the 1.1.0 version to npm.


Refine install.sh

can work without sourcing (problematic in zsh)
installs bash completion
do not create directories (duplicate with the main)
can specify installing version

Thank you :)


SearchAnchor search view clear button shows up even if you haven't entered any text

Steps to reproduce

Add a SearchAnchor to your app
Run the app. (I tried macOS and Web-CanvasKit)
Open the full search view
Don't type anything
Notice the clear button on the right

Expected results
The clear button will only be shown once you have text added. Otherwise there's nothing to clear and it could be mistaken as an exit button.
Actual results
The clear button is shown even if you haven't entered any text
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: SearchAnchor.bar(
            barHintText: 'Search',
            suggestionsBuilder: (context, controller) {
              return [];
            },
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots

Flutter version info
Version info
Flutter 3.19.0-3.0.pre.43 • channel main • https://github.com/flutter/flutter
Framework • revision f961fdf2ba (4 hours ago) • 2024-01-10 17:37:07 -0500
Engine • revision a045134c91
Tools • Dart 3.4.0 (build 3.4.0-14.0.dev) • DevTools 2.31.0

Thanks for the report. In native for example, as shown below (using android emulator), the X button appears after inputing text and goes away after removing or deleting the text.
https://github.com/flutter/flutter/assets/67046386/3c80562c-0d41-4084-8828-7b85058e0dd7
Currently, the SearchAnchor.bar shows the X button upon receiving the focus.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.16.5, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.16.5 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 78666c8dc5 (13 days ago), 2023-12-19 16:14:14 -0800
    • Engine revision 3f3e560236
    • Dart version 3.2.3
    • DevTools version 2.28.4
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.19.0-3.0.pre.50, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.19.0-3.0.pre.50 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 3e5cad037c (68 minutes ago), 2024-01-10 22:42:23 -0500
    • Engine revision ade9f18fa0
    • Dart version 3.4.0 (build 3.4.0-16.0.dev)
    • DevTools version 2.31.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.


Replace fonts with one from Viktor

Description (what's changed?)
Replaced fonts in editor with updated ones from Viktor

Task linked: CU-86ayfgqag Add new fonts from Viktor and also new font icons

Task linked: CU-86ayfgqag Add new fonts from Viktor and also new font icons


Remove the reference to k8s flatten hash

That configuration can break 3.4+ environments that need the
namespacing.

@wshearn, moved this PR to be based on stg.

Gotta wait on the bot to come back and we can retest and look at why it is failing

ok to test

@wshearn, how do I see what failed?  I only get a 404 when I click on the details link.

it is one of these
[test]
ok to test

I guess it was failing due to the bot issues yesterday.

So do I merge this now, or does somebody else?


finalize requirements.txt and pip install

The top priority remaining from the version 0.2 refactor is a clear, fully tested, and fully documented installation process.
The focus point for this is the requirements.txt.

Side note: the developer installation method should be
pip install -e .
from the repo top level folder.
This command calls the setup.py file, which reads dependencies from the requirements file

The requirements.txt needs to be extended to include the following:

[x] Version numbers for all packages (e.g. pip install matplotlib==3.0.3)
[ ] Operating system dependencies
(e.g. pyreadline==2.1; platform_system == "Windows" - see here and here
[ ] Testing of of all this across all operating systems and multiple devices
[x] Removal of any redundancies

Finalizing this is number one top priority.

@mhough and @JadinTredup - would be great if you two could take the lead on this, as you are (I believe) the ones with access to all OS types.

@JohnGriffiths I will try on Windows and Linux but I do not have a MacOS.

Just wanted to update this for the sake of documenting it: the current working set of requirements for both Windows and Linux (with version numbers) is in "requirements_test.txt" once it is confirmed to work on Mac as well we can move it to the main requirements file.

I'm installing on Windows in a new Anaconda environment ((conda 4.8.4) using:
pip install -r requirements.txt
I get the following error during the installation:
ERROR: psychopy 2020.2.4.post1 has requirement pyglet>=1.3, but you'll have pyglet 1.2.0 which is incompatible.
but the installation continues after that error it looks like psychopy ends up getting installed successfully:
Running setup.py install for psychopy ... done
Successfully installed...psychopy-2020.2.4.post1...pyglet-1.2.0...
full log of installation:
conda-log.txt

Following up -- I had issues running N170 experiment after installing using requirements.txt
The N170 session would start, but would only display a blank gray screen. None of the faces or houses would show up.
I uninstalled pyglet 1.2.0 (pip uninstall pyglet) and then re-installed using pip install pyglet
Pyglet 1.5.7 was installed. Then the N170 experiment ran normally.
I made a new environment and modified the requirements.txt to not include a specific pyglet version. The pip installation then ran without errors, and the N170 worked first try in the new environment

@jartuso sorry I should have mentioned somewhere that we should be trying out "requirements_test.txt" as the current list of requirements. I will move them over to the main requirements file.

Do we have anyone who has verified if these requirements work on Mac yet?

I can confirm a clean pip install on Mac OS X 10.14.6 with a fresh miniconda 3.8 using requirement_test.tx. On Mac OS X, conda install python and pip or it will use the /usr/bin/python following current directions.
Runs n170 experiment successfully with port set to /dev/cu.usbserial-DB00M80D
raw = load_data(save_fn) still doesn't work with positional argument errors. Will follow up.
Tested on both MacBook Air with USB port and MacBookPro with USB-C USB Hub


isDatabase - Connection to Database "Database-Name" is not Available

Describe the bug
After updating to the latest version of the plugin (I've been using an outdated version for which this error did not occur), upon calling "isDatabase" on a database name, I receive the error "Connection to database "database-name" not available.
I have noted this issue raised here: https://github.com/capacitor-community/sqlite/issues/377 but believe it is different as I'm not trying to open a connection, and the API docs on isDatabase state that it should work without a database connection: https://github.com/capacitor-community/sqlite/blob/master/docs/API.md#isdatabase
To Reproduce

Create a new SQLiteConnection(CapacitorSqlite) connection

Call await CapacitorSQLite.isDatabase({ database: "database-name" })

Expected behavior
Receive error: ERROR MESSAGE: {"message":"isDatabase: Connection to database-name not available","errorMessage":"isDatabase: Connection to database-name not available"}
Screenshots

Smartphone (please complete the following information):

Device: Simulator - iPhone 14

Additional context
I'm developing in Ionic/Vue

@michaelbutler1998 may be you should look at the doc there is know à readonly boolean to provide

Apologies @jepiqueau, I thought this was an optional parameter. This has resolved my issue

@michaelbutler1998 it is optional if you use the ISQLiteConnection wrapper not if you use directly the CapacitorSqlite plugin. Have a good app development


[Question] about numberAds param

Hi,
I'd like to ask about the numberAds param.
It's hard for me to figure out how to use it and what it does.
I am very new to flutter.
I thought it would cache 4 ads and show the cache with the index.
Isn't this how it's supposed to work?
I put up my code below.
It just shows the same ad everywhere.
There are not much of docs or example around it.
reloadAddoes not seem to do the job either. ( does not render another ad )
Ultimately, what I am trying to do is preloading ads before the render.
Thanks for the awesome project.
import 'package:flutter/material.dart';
import 'package:flutter_native_admob/flutter_native_admob.dart';
import 'package:flutter_native_admob/native_admob_controller.dart';

class AdmobPage4 extends StatefulWidget {
  @override
  _AdmobPage4State createState() => _AdmobPage4State();
}

class _AdmobPage4State extends State<AdmobPage4> {
  static const _adUnitID = "ca-app-pub-5046562646162404/5259802678";

  NativeAdmobController _nativeAdController;

  @override
  void initState() {
    _nativeAdController = NativeAdmobController();
    _nativeAdController.setTestDeviceIds(["C3F8FA9E55B3AE3C8D581B59F724E8B0"]);

    super.initState();
  }

  @override
  void dispose() {
    _nativeAdController.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: ListView.builder(
          itemCount: 200,
          itemBuilder: (context, index) {
            if (index % 4 == 0) {
              int idx = (index / 4).floor();
              return Container(
                height: 330,
                padding: EdgeInsets.all(10),
                margin: EdgeInsets.only(bottom: 20.0),
                child: NativeAdmob(
                  numberAds: idx,
                  loading: Container(color: Colors.red),
                  adUnitID: _adUnitID,
                  controller: _nativeAdController,
                ),
              );
            }
            return Container(
              margin: EdgeInsets.only(bottom: 20.0),
              height: 200.0,
              color: Colors.green,
            );
          },
        ),
      ),
    );
  }
}

I can't figure out how it works, I tried use this param to get different ads in a ListView but it doesn't work. Does someone know?

any update on this?

Any update on this question, it has been more than 1 year?


VM unit tests, remove informers

What this PR does
Remove informers in order to simplify test setup. This also improve test runtime from ~15 seconds down to ~0.2 seconds.

Fixes #
Why we need it and why it was done in this way
Special notes for your reviewer

Release note

NONE

/approve

/hold
unit test failure is relevant

@fossedihelm PTAL

/hold cancel
Rebased


Add fire trail to Fire extension

Fire extension could use a trail.

Note that this does not need to be a trail for all projectiles – e.g. for cannon blobs it could be a simple color change, for hats we could add a fire effect to the flying hats


Add jquery.tinymce.js non-minified file version

The project doesn't have a non-minified version of jquery.tinymce.js. When using package managers like JSPM and Webpack we end up having to minify the provided minified version and that process is very slow.

I will include this in the build script. Closing this one since this repo is for distribution only.

Thank you @spocke. Could you please check if the plugins non-minified files are being updated?
For example, the advlist files appear to be from different versions:

It there wasn't any change to that particular plugin then it won't be updated since the diff would be 0 lines. The minified file would still be updated though.

Got it. Thanks for the clarification


Allow building on non-Windows

Attempting to use this code on Unix will throw a runtime exception Named_pipe.Not_available, similar to Lwt_unix and [mirage/ocaml-conduit].

This is the ocamlmod failure.


Possible to use sharp to blend two images together?

I'm hoping to use sharp to blend two images together at different opacities, to stitch together a cross fade.  It's not evident from the overlayWith documentation that this is possible.  Would someone kindly let me know if this is a supported use case?  Thanks!

Hello, did you see #859?

Looks to be the solution, thanks.


Add scope to README

e.g. no file formats, simple math functions that use pandas and numpy.

already done.


Argument design are weird

Normally in *nix, we would design a command line argument around input file(s), not an input folder (since it can be done easily via folder/*). I suggest change the argument layout from
cr2-to-jpg.py [-h] -s SOURCE -d DESTINATION

to
cr2-to-jpg.py [-h] [--prefix PREFIX] [--postfix POSTFIX] FILE [FILE ...]

where bracket [ ... ] indicate optional arguments. This way it will convert files with .cr2 extension into .jpg, preserving original filename, but if we want to move this output file around, just turn --prefix folder/ option on.

@neizod, I apologise, I have not seen these notifications of open issues. I will look at this change. This script has been forked a fair bit now and I'm sure others have improved on this process.


Update code.py

Not merging as this is the debian packaigng - you should probably send this upstream.


SearchHeaderCell Type not accepting flex properties

Evergreen uses flex as a way of defining column width. TextHeaderCell and HeaderCell both accept flexBasis/flex/flexGrow without typescript errors. SearchHeaderCell results in the following error:
Type '{ flexBasis: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<SearchTableHeaderCell> & Readonly<SearchTableHeaderCellProps> & Readonly<{ children?: ReactNode; }>'.
  Property 'flexBasis' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<SearchTableHeaderCell> & Readonly<SearchTableHeaderCellProps> & Readonly<{ children?: ReactNode; }>'. [2322]

How to Reproduce

Action: compiling code with a flex property on a SearchHeaderCell tag
Version: 4.21.2

Ah, looks like SearchTableHeaderCell props should extend TableHeaderCellProps (omitting own props), and TableHeaderCellProps should extend TableCellProps (omitting own props).

Hmm, im confused. Doesn't it do that? https://github.com/segmentio/evergreen/blob/master/index.d.ts#L1371
It looks like the heredity tree goes: SearchTableHeaderCellProps --> TableHeaderCellProps --> TableCellProps --> PaneProps , which should work.... but it's very possible im missing something

It might have to do with the way PaneProps is using typeof Box. What version of typescript are you on?

TypeScript Version 3.4.5

Any update on this?

Still waiting on this

I'm unable to reproduce the error using latest evergreen or on TypeScript 3.7.5+


Concurrent stream combinators

Currently we have the Stream::for_each_concurrent, buffer_unordered, and buffered, which use FuturesUnordered to run streams concurrently. Calling the combinators "buffered" is not great for visibility in my experience, and it might be more obvious if they were named concurrent/concurrent_unordered (or similar) with a limit: Option<usize> parameter. Or perhaps just introduce concurrent and make the limit field in buffered non-optional (undoing https://github.com/rust-lang/futures-rs/pull/2429). for_each_concurrent is also trivially implemented as stream.concurrent().for_each(...), so it may not be worth having.

Note that https://github.com/rust-lang/futures-rs/pull/2429 is not released yet so we could easily add concurrent(_unordered) without breaking changes.

Both renaming buffered/buffer_unordered and removing for_each_concurrent look like good ideas.

If anyone decides to implement this, concurrently seems like a good name.


#fix/reducing bundle size

update : installed @next/build-analyzer + reducing _app.tsx bundle, more to come
update : code splitting page on /index, /article/[slug], /user/posts
fix : title not showing when lazy loading the whole app
update : added splash screen
update : added splash screen
fix : splash screen getting cut out

I pushed focusing on the ui and stuff.


タイトルレベルの変更と details タグで囲むフラグの追加

:tada: This PR is included in version 1.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


mriqc_clf T1w classifier not working in mriqc latest release on docker

Hello,
I am interesting in the T1w classifier function mriqc_clf which seems to be no longer supported in the latest release
On my system,  container image files for both the latest and second latest version (0.16.1) of MRIQC were downloaded from docker hub.
When I ran the classifier on the latest version
singularity exec -H ~/mengjia_space -B ~/mengjia_space:/output ~/mriqc-21.0.0.sif mriqc_clf --load-classifier -X group_T1w.tsv -v
I got the error
WARNING: skipping mount of /local/path/to/output: stat /local/path/to/output: no such file or directory
FATAL:   container creation failed: mount /local/path/to/output->/output error: while mounting /local/path/to/output: mount source /local/path/to/output doesn't exist
(base) [rbc@cubic-login5 mengjia_space]$ singularity exec -H ~/mengjia_space -B ~/mengjia_space:/output ~/mriqc-21.0.0.sif mriqc_clf --load-classifier -X group_T1w.tsv -v
Traceback (most recent call last):
  File "/opt/conda/bin/mriqc_clf", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.8/site-packages/mriqc/bin/mriqc_clf.py", line 190, in main
    from ..classifier.helper import CVHelper
  File "/opt/conda/lib/python3.8/site-packages/mriqc/classifier/helper.py", line 19, in <module>
    from sklearn.metrics.scorer import check_scoring
ModuleNotFoundError: No module named 'sklearn.metrics.scorer'

However, when I ran the same command with the second latest (0.16.1) version
singularity exec -H ~/mengjia_space -B ~/mengjia_space:/output ~/mriqc_0.16.1.sif mriqc_clf --load-classifier -X group_T1w.tsv -v, I was able to obtain the output file with prediction labels.
/usr/local/miniconda/lib/python3.7/site-packages/sklearn/utils/__init__.py:4: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Sequence
/usr/local/miniconda/lib/python3.7/site-packages/sklearn/ensemble/weight_boosting.py:29: DeprecationWarning: numpy.core.umath_tests is an internal NumPy module and should not be imported. It will be removed in a future NumPy release.
  from numpy.core.umath_tests import inner1d
211112-09:45:37 mriqc.classifier:INFO Results saved as /cbica/projects/RBC/mengjia_space/mclf_run-20211112-094536*

Is it true that mriqc_clf is no longer supported? Thank you so much for your help and feedback!!

The MRIQC classifier aged pretty badly. We have outsourced it to the nipreps/mriqc-learn package, where I'm also moving this issue for reference.


convert sd1.5 lora to sdxl?

I found your project looking to an answer to my question - how to convert an sd1.5 lora into sdxl.
From what I found it doesn't seem to be possible without retraining a new model which is a bummer since 90% of models are for 1.5. I'm not expecting a high quality conversion either just getting them to run would be fine.
Do you think its possible to write a converter, possibly with use of this repo?

I think what you're looking for is X-adapter but I don't think it has a proper ComfyUI plugin outside this one, which is just a wrapper around diffusers.

Thanks! That's what I was looking for.


Scaladoc for monix.eval.Task.delayResultBySelector seems incorrect

Scaladoc comment for delayResultBySelector is identical to the one for delayResult
https://github.com/monix/monix/blob/master/monix-eval/shared/src/main/scala/monix/eval/Task.scala#L190-L208

Thanks for the report @n4to4, I've pushed a fix.


Adding Electrolux 9kg Ultimate Care Heat Pump Dryer

Is your feature request related to a problem? Please describe:
No problems
Describe the solution you'd like:
I would like to see the Electrolux 9kg Ultimate Care Heat Pump Dryer added to the supported appliances please.
Describe alternatives you've considered:
No alternatives
Additional context:
N/A

@jampat000 Any luck on heat pump dryer, i am looking for it Aswell , Appreciate any info on it . Thank you


Websocket with wrong protocol on HTTPS Development ENV

Describe the bug
When forcing HTTPS=true on NPM start the error "WebSocket connection to 'ws://localhost:3000/sockjs-node' failed: Connection closed before receiving a handshake response"
I couldn't find a solution for this without ejecting the code.
Did you try recovering your dependencies?

It is a brand new npx create-react-app app. The problem is not present in other project running react-scripts 3.0.1
Which terms did you search for in User Guide?

Searched for websocket, force wss
On google I searched for create-react-app websocket, create-react-app force wss, create-react-app https
Environment

System:
OS: macOS 10.15
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Binaries:
Node: 10.16.3 - /usr/local/bin/node
Yarn: 1.5.1 - ~/.yarn/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
Browsers:
Chrome: 78.0.3904.108
Firefox: 62.0
Safari: 13.0.2
npmPackages:
react: ^16.12.0 => 16.12.0
react-dom: ^16.12.0 => 16.12.0
react-scripts: 3.3.0 => 3.3.0
npmGlobalPackages:
create-react-app: Not Found
Steps to reproduce

npx create-react-app app
cd app
npm i cross-env
replace "start": " react-scripts start" to "start": "cross-env HTTPS=true react-scripts start"
npm start
Open https://localhost:3000
script still tries to open websocket on WS protocol.

Expected behavior

Script opens websocket on WSS protocol
Actual behavior

Script still tries to open websocket on WS protocol.

Reproducible demo

I think I've hit this or related to it too, my setup:

react-scripts 3.3.0
react-dev-utils 10.0.0
yarn start on localhost:3000 (that works)
actually loading the site over https://.ngrok.io (I need it for trusted redirect dance)

And I get SecurityError: Failed to construct 'WebSocket': An insecure WebSocket connection may not be initiated from a page loaded over HTTPS.
The same scenario works with following versions:

react-scripts 3.2.0
react-dev-utils 9.1.0

Can you try https://github.com/facebook/create-react-app/pull/8079 ?
It should fix your issue.

@mikecaulley Ran into same issue and like to confirm patch in #8079 seems to work here 👍
(did patch it in manually)
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>
(trimmed for brevity)

Yeap, worked fine, thanks !


gitea panics on a markdown syntax error (nested links)

Gitea version (or commit ref): master (acb6f8a), also 1.5.1
Git version: Tested 2.10.1, 2.18.0
Operating system: Tested Ubuntu, macOS
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL): https://try.gitea.io/earwig/markuptest
[ ] No
[ ] Not relevant

Log gist: https://gist.github.com/earwig/f44165540933bbe277a4704136ba80b9

Description
The syntax is this: [\[\[foobar\]\]](https://example.org)
Expected result: [[foobar]]
I noticed it when trying to mirror one of my repos.

I don't get why "visitLinksForShortLinks" logic in modules/markup/html.go is used, where it's used at all. Why nested links should be processed, any working example where they are needed.
Probably over-engeneering?

Agreed, I looked through the code myself while trying to debug and couldn’t understand it either. None of tests seem to go through that code path, unless I’m missing something.

On Sep 19, 2018, at 4:54 PM, SagePtr<EMAIL_ADDRESS>wrote:
I don't get why "visitLinksForShortLinks" logic in modules/markup/html.go is used, where it's used at all. Why nested links should be processed, any working example where they are needed.
Probably over-engeneering?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This bug still causes an uncaught internal server error in production, as you can see from the reproduction I linked in the original post. This issue should not be closed.

I was looking at all of the link generating code recently and can see whats causing this here. This happens because of a few things:
First, the markdown processor does correctly render this and outputs

[[foobar]]

However, then gitea runs its own processors and this happens to match the following regex:
https://github.com/go-gitea/gitea/blob/master/modules/markup/html.go#L53
It does that because it sees anything inside double brackets as a possible MediaWiki/Github style short link like
[[link|example]]
[[example|link]]

Relevant comments/function here:
https://github.com/go-gitea/gitea/blob/master/modules/markup/html.go#L389
That function seems to assume too much about the text match, and fails when it isn't actually what was expected. This also does other bad things like turn this bogus text into a link:
[[]]example

See: https://try.gitea.io/mrsdizzie/test/issues/2
A quick test of changing shortLinkPattern to
shortLinkPattern = regexp.MustCompile(`\[\[(.+?\|.+?)\]\](\w*)`)

Makes the offending example (and my test) in this issue work as expected, but will slightly effect another test. I'll take a look at it and come up with something that matches all the current tests and also includes these new test and create a pull request.

Closed per merged PR.


Visual Studio Code Formatting/Splitting Texts & Codes

Issue Type: Bug
Visual Studio Code is breaking up texts and codes copied either from Atom, ST4, or any other text editor.
Screen-recording is available at https://jmp.sh/vtp8LDP
Pretty sure I’m missing something important but can’t figure it out yet.
Not sure if it is a bug or configuration though lmost of the settings are still in default.
Have searched around a bit but can’t seem to find anyone else with the same issue.
Any insight to get it to stop would be appreciated.
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4278U CPU @ 2.60GHz (4 x 2600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
27, 16, 9

Memory (System)
8.00GB (0.08GB free)

Process Argv
--crash-reporter-id a3fd3659-696c-4ec2-9227-29b783c8cd32

Screen Reader
no

VM
0%

Extensions (15)

Extension
Author (truncated)
Version

cloudcode
goo
1.13.0

terraform
has
2.13.0

smarty
imp
0.3.0

vscode-azureresourcegroups
ms-
0.4.0

vscode-azurevirtualmachines
ms-
0.4.0

vscode-docker
ms-
1.14.0

vscode-dotnet-runtime
ms-
1.1.0

vscode-kubernetes-tools
ms-
1.3.3

remote-containers
ms-
0.183.0

azure-account
ms-
0.9.8

azurecli
ms-
0.5.0

vscode-yaml
red
0.20.0

code-spell-checker
str
1.10.2

vscode-stripe
str
2.0.3

vscode-icons
vsc
11.5.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30311712
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vscorecescf:30322572
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255cf:30323309
vscorehov:30309549
vscod805cf:30301675
binariesv615:30325510

It seems to me that the source you are copying the text from has inserted new lines into the copied text, perhaps due to text wrapping in the source. Does this occur even with text wrapping turned off in the source editor?

@sbatten
Good evening.
Yes, it does happen even with text wrapping disabled.
I have 3 text editors: Atom, Sublime Text 4, and Visual Studio Code which I just started using this year and have started loving it.
But this is a vexing problem making it difficult to switch to it completely.
Even when you write a code with VSC, save it and then open it later with the same editor, you will encounter the same issue.
Write a code with Atom, ST4 and then open it with VSC, you will encounter the same issue.
Write a code, minify it then open it with VSC, the same happens.
And strangely, this tends to happen with texts within HTML snippets.
Terraform, Vagrant and others don't have this issue.

@metacogni can you share the code snippet you are using to help troubleshoot? A screen recording can help a lit.


New crates.io release

Hi,
crates.io is at 0.3.8, which is ancient! I'm pinning to the github repo in the meantime, but a release would be appreciated.
Thanks!

I've unfortunately shot myself in the foot here: lonlat_bng has a hard dependency on https://github.com/urschrei/ostn15_phf, which is too big to publish to crates.io. AFAIK there's no easy way to solve this, because even vendored dependencies have to be published in order for the depending crate to publishable.

Ah, no worries then!
(FWIW, I wound up switching to proj, since I already have a dependency on it anyway for another transformation)

proj is the way to go for sure. IIRC you'll need to use it with the network feature enabled (if you can) in order to access the higher-quality OSTN15 conversion, since it can't be included in the proj db by default (again because the dataset is too big). That having been said, you may not need the high-quality transform; the standard version will be accurate within ~10 m, and you don't need to worry about compounding errors if you're only converting once (presumably from BNG to EPSG 4326).

The proj accuracy is definitely fine; my particular use case is just for visualization. I found this library because the code I'm porting actually uses the Python wrapper: https://github.com/Urban-Analytics/RAMP-UA/blob/3cf45d225501ef64ad6439c9e4c330f052708853/coding/model/opencl/ramp/snapshot_convertor.py#L6
I was amused to find your name crop up as a dependency here. :)

The proj accuracy is definitely fine; my particular use case is just for visualization. I found this library because the code I'm porting actually uses the Python wrapper: https://github.com/Urban-Analytics/RAMP-UA/blob/3cf45d225501ef64ad6439c9e4c330f052708853/coding/model/opencl/ramp/snapshot_convertor.py#L6
I was amused to find your name crop up as a dependency here. :)

Oh that's amazing 🤦♂. The author of that file was even doing his PhD in the same department as me, sitting about 10 yards away.


Workbook build templates

🛠 Description

Add sub-templates folder structure
Update error/warning messages format
Add text guidance on queries
Add "Use Standard Storage to store Managed Disks snapshots" recommendation
Add orphaned snapshots query
Added logic in Build-workbook.ps1 to merge templates of any workbook "following the same folder structure and placeholders method"

Fixes #234
📷 Screenshots
🔬 How has this been tested?

[X] 🫰 PS -WhatIf / az validate
[X] 👍 Manually deployed + verified
[X] 💪 Unit tests

@flanakin I created a new PR for the split workbook task. I added logic to remove the workbook.json file after its built to only have the one in the releases folder. I need to have the template file as there needs to be a file with the placeholders, it cannot be done on the same workbook.json file. Take a look and let me know if this approach is ok.


[ODS-5390] Add Redis External Cache Feature

Approving this for now. But please sign all your commits and then we can merge this.


Disables usage of parenthesis in unit enum variants.

With these changes it is no longer possible to do Option::None() instead it should be done with Option::None.
This changes also fixes enum turbofish without parenthesis so Option::None::<T> can be used.
Ref #3585 (Does not close but addresses other issue mentioned on the comments)
Closes #3375

Test when enums are specified with their fully qualified path including the library names both with and without the () (lib_a::inner_lib::my_enum::MyEnum::VariantA())
Test function calls and method calls that take no arguments both with and without the () and both with and without their fully qualified paths including the library names

Added the tests mentioned above in most recent change. Thanks to this I found an issue where a fully qualified path method with no parameters could be called without parenthesis. This issue was fixed with a new error thrown.


bugfix return when txn state is null when doing abort txn

Proposed changes
follower #17893
When doing broker load, if we encountered one error before the txn starts, then there would be one abort txn rpc. Unfortunately, there is no txn state for the corresponding txn, so the following procedure would throw NPE when accessing the null state.
This pr makes it just return if there is no corresponding txn state.
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildadd

run buildadd

Is there any issue to record this error?


Deleted loop breakout if ADC device name was not old format

Presently there is no upstream commit for this addition.
Deleted loop breakout if ADC device name was not old format
ADCSensor was checking for old ADC device name.
If that name was not found a loop breakout occurred.
Thus ADCSensor never found the new ADC device name.
Signed-off-by: Tom Ippolito<EMAIL_ADDRESS>

Can one of the admins verify this patch?