Inconsistent / undefined behavoiur of lfs_file_seek around LFS_FILE_MAX

Hello,
consider these 4 test cases.

[cases.test_cur_int32max] and [cases.test_end_int32max] return different values for current cursor position depending on whether we use LFS_SEEK_CUR or LFS_SEEK_END (note that CUR should be equal to END, since no additional writes or seeks were performed, but returned value is different). The return value in both cases should be the same (either INT32_MAX (preferably) or 0).
[cases.test_ub_cur_int32max] and [cases.test_ub_set_int32max] work as expected (return error when seeking past LFS_FILE_MAX) but rely on undefined behaviour in lfs_file_seek (signed integer overflow), so they may not work as expected for every platform and compile options combination.

Checked on d01280e64934a09ba16cac60cf9d3a37e228bb66.
Proposed solution: compute temporary offset calculations in lfs_file_seek using int64_t before casting them to 32-bit values.
[cases.test_cur_int32max]
code = '''
    lfs_t lfs;
    lfs_format(&lfs, cfg) => 0;
    lfs_mount(&lfs, cfg) => 0;
    lfs_file_t file;
    lfs_file_open(&lfs, &file, "kitty",
            LFS_O_WRONLY | LFS_O_CREAT | LFS_O_APPEND) => 0;

    assert(LFS_FILE_MAX == INT32_MAX);

    lfs_file_seek(&lfs, &file, INT32_MAX, LFS_SEEK_SET) => INT32_MAX;

    // behaviour: returns INT32_MAX, not 0 (what LFS_SEEK_END returns) /////////////////////////////
    lfs_file_seek(&lfs, &file, 0, LFS_SEEK_CUR) => INT32_MAX;

    lfs_file_close(&lfs, &file) => 0;
    lfs_unmount(&lfs) => 0;
'''

[cases.test_end_int32max]
code = '''
    lfs_t lfs;
    lfs_format(&lfs, cfg) => 0;
    lfs_mount(&lfs, cfg) => 0;
    lfs_file_t file;
    lfs_file_open(&lfs, &file, "kitty",
            LFS_O_WRONLY | LFS_O_CREAT | LFS_O_APPEND) => 0;

    assert(LFS_FILE_MAX == INT32_MAX);

    lfs_file_seek(&lfs, &file, INT32_MAX, LFS_SEEK_SET) => INT32_MAX;

    // behaviour: this returns 0, not INT32_MAX (what LFS_SEEK_CUR returns) ////////////////////////
    lfs_file_seek(&lfs, &file, 0, LFS_SEEK_END) => 0;

    lfs_file_close(&lfs, &file) => 0;
    lfs_unmount(&lfs) => 0;
'''

[cases.test_ub_cur_int32max]
code = '''
    lfs_t lfs;
    lfs_format(&lfs, cfg) => 0;
    lfs_mount(&lfs, cfg) => 0;
    lfs_file_t file;
    lfs_file_open(&lfs, &file, "kitty",
            LFS_O_WRONLY | LFS_O_CREAT | LFS_O_APPEND) => 0;

    assert(LFS_FILE_MAX == INT32_MAX);

    lfs_file_seek(&lfs, &file, INT32_MAX, LFS_SEEK_SET) => INT32_MAX;

    // ok behaviour: returns LFS_ERR_INVAL /////////////////////////////////////////////////////////
    // lfs_file_seek(&lfs, &file, 10, LFS_SEEK_CUR) => 0; // [*]
    lfs_file_seek(&lfs, &file, 10, LFS_SEEK_CUR) => LFS_ERR_INVAL;

    // BUT, relies on UNDEFINED behaviour (signed integer overflow) on line
    //    if ((lfs_soff_t)file->pos + off < 0) { ... }
    // when compiling with -fsanitize=undefined:
    //   lfs.c:3671:35: runtime error: signed integer overflow:<PHONE_NUMBER> + 10 cannot be represented in type 'int'
    // Note, you must uncomment the line marked with [*], otherwise runtime error is not reported for some reason.

    lfs_file_close(&lfs, &file) => 0;
    lfs_unmount(&lfs) => 0;
'''

[cases.test_ub_set_int32max]
code = '''
    lfs_t lfs;
    lfs_format(&lfs, cfg) => 0;
    lfs_mount(&lfs, cfg) => 0;
    lfs_file_t file;
    lfs_file_open(&lfs, &file, "kitty",
            LFS_O_WRONLY | LFS_O_CREAT | LFS_O_APPEND) => 0;

    assert(LFS_FILE_MAX == INT32_MAX);

    lfs_file_seek(&lfs, &file, INT32_MAX, LFS_SEEK_SET) => INT32_MAX;

    file.ctz.size = INT32_MAX; // simulate writing INT32_MAX bytes to file to force the error
    lfs_file_size(&lfs, &file) => INT32_MAX;

    // ok behaviour: returns LFS_ERR_INVAL /////////////////////////////////////////////////////////
    // lfs_file_seek(&lfs, &file, 10, LFS_SEEK_END) => 0; // [*]
    lfs_file_seek(&lfs, &file, 10, LFS_SEEK_END) => LFS_ERR_INVAL;

    // BUT, relies on UNDEFINED behaviour (signed integer overflow) on line
    //    lfs_soff_t res = lfs_file_size_(lfs, file) + off;
    // when compiling with -fsanitize=undefined:
    //   lfs.c:3677:20: runtime error: signed integer overflow:<PHONE_NUMBER> + 10 cannot be represented in type 'int'
    // Note, you must uncomment the line marked with [*], otherwise runtime error is not reported for some reason.

    lfs_file_close(&lfs, &file) => 0;
    lfs_unmount(&lfs) => 0;
'''

Hi @m-kostrzewa, thanks for creating an issue and providing reproducible tests, sorry about the late response.
It looks like @lucic71 created a PR over here to address this: https://github.com/littlefs-project/littlefs/pull/1017
Some of the trickiness is we want to avoid uint64_ts where possible since they can bring quite a penalty code-size-wise on 32-bit and 8-bit devices.

Ah, @m-kostrzewa actually there's an explanation for the first issue:

[cases.test_cur_int32max] and [cases.test_end_int32max] return different values for current cursor position depending on whether we use LFS_SEEK_CUR or LFS_SEEK_END (note that CUR should be equal to END, since no additional writes or seeks were performed, but returned value is different). The return value in both cases should be the same (either INT32_MAX (preferably) or 0).

This matches POSIX behavior in that seek changes the current position of the file pointer, but not the size of the file. The size is not changed until a write occurs on the file.
So when you seek to LFS_SEEK_END+0, it seeks to the end of the file, which is zero since no write occurred. If the file contained some data the LFS_SEEK_END+0 would return the end of the file.
In theory you could fill the file with zeros by writing a single byte at INT32_MAX-1, or with lfs_file_truncate(&lfs, &file, INT32_MAX), but littlefs doesn't currently support sparse files so this would quickly explode.


Documentation incorrect for Quaternion32

From Quarternion32.java
 * This version of quaternion uses **double** precision fields to save the value of each component. It
 * is meant for garbage free usage and for situations where heap memory is limited. When memory is
 * not a constraint, the use of {@link **Vector2D32**} is preferable.

I fixed this typo in Euclid. I probably won't change it here.


Re Issue #2717

This appears to be related to issue 2717
https://github.com/SolastaMods/SolastaUnfinishedBusiness/issues/2717
Hello! Firstly, thanks so much for creating and supporting this mod, loving it so far.
I have also encountered this looting issue. This occurs with both controller and mouse/kb. I can easily reproduce this issue by dropping an item on the ground and trying to pick it up. Usually I can pick up loot after a few tries, but sometimes it just doesnt want to work. In these cases I have to make a character stand on the loot bag so that the loot action appears on the ui. I have attached a save with an item dropped on the ground, let me know what else I can do to help!
Cant loot.zip

this is a limitation on how custom formations work. we've changed the default formation to minimize that. nothing else we can do.


Add support for referring to images by digest

Supersedes #11109 by @ncdc with implementation of https://github.com/docker/docker/pull/11109#issuecomment-78370899
Overview
When I create a container, I may specify an image such as mysql:latest. When the image is pulled, latest is resolved to a particular image at that point in time. If I later want to add more containers (e.g. possible read slaves in the MySQL case), all the new containers must use the exact same image as my first container. Using a tag isn't sufficient as the tag can be updated to point at a different image. We need a way to refer to images using immutable identifiers.
With the v2 image format, image manifests have content-addressable, immutable digests. The v2 registry supports retrieving manifests by digest; this pull request adds the corresponding support to the Docker Core.
Digest reference format
We'll need to provide a means to reference an image by its digest. I'd like to propose the following format:
namespace/repository@digest

Supported commands
We'll need to make sure the following commands continue to work as they currently do, as well as with an optional digest:

docker build
docker pull
docker create
docker run
docker rmi

This list should eventually be comprehensive; anywhere you can refer to an image, you should be able to do so by digest. For the time being, the commands listed above should be sufficient for the use case listed in the overview.
docker images
If you pull an image from a v2 registry, the registry provides the image manifest's digest as a response header. If you pull by tag, you'll have both the tag and the digest. If you pull only by digest, you won't have the tag information. 1 question to resolve is how to display images, tags, digests, and v1 image IDs in the docker images command.
It is possible (likely?) that a variety of code exists to scrape the output of docker images. If we change the format, e.g. by adding a new column, or overloading an existing column to sometimes show a v1 image ID vs a digest, we will probably break whatever code is out there doing the scraping. We need to determine how critical it is to retain the existing column and data formats in the docker images command.
I have the following ideas regarding this output:

if an image was pulled by tag, and the registry it's pulled from includes the image's digest, display repository, tag, digest, and image id
if an image was pulled by digest, display repository,  for tag, digest, and image id

docker images questions

should we add a new DIGEST column?
if yes, should we always display it, or only display it if you indicate that you want to see digests (e.g. via a filter)

there can be confusion if you pull an image by digest and then run docker images - you won't see the image you just pulled

should we display the digest instead of the v1 image ID (or some other value)?

Questions
What about v1 registry support?
The v1 registry won't support this feature.
If I create an image locally via docker tag or docker commit, can I refer to it by name@digest?
As proposed in https://github.com/docker/distribution/issues/46, the registry is responsible for determining an image's digest and assigning it to the image. For an image that has not yet been pushed to a v2 registry, it may not be possible to refer to it by name@digest. This is unlikely to be a significant issue, as the use case for name@digest is consistent deployments using images pulled from registries. Or, if the community thinks this should be supported, we can revisit what component(s) are responsible for calculating digests.
Additional information
See #10740 for more backstory.
Todo:

[x] Test cases
[x] Update documentation

These files are not properly gofmt'd:
api/client/commands.go
Please reformat the above files using gofmt -s -w and amend to the commit the result.

@GordonTheTurtle I don't know what you're talking about. Is it a specific commit that you're complaining about because the tip of the branch seems fine.
@jfrazelle ^ is this guy serious?

@jlhawn it looks like you changed the behavior so that it no longer stores the digest->id reference when pushing or pulling by tag. I've restored this in an additional commit: https://github.com/ncdc/docker/commit/a6df96e2af4046bc3bd1271e19da09affdf63f52.


Speak audio is interupted when second message arrives

When a bot sends multiple messages with a Speak value the client will no longer finishing playing the text-to-speech audio before starting the second message. Instead the first message is cut off when the second arrives.
Using master/webchat.js with Bing Text to Speech service. Happens in Chrome and Edge.
Previous versions of webchat would finishing playing the first message before starting the second.

Working on it while we are baking the new W3C adapter for Unified Speech SDK (which support Custom Speech). Bing Speech will be deprecated by Cognitive Services team in 2019 October.
Expect a drop, private or public, in mid-December for the new SDK. Few reasons we might not able to go public: not enough testing on Web Chat, Cognitive Services did not ship their SDK in NPM by this date.
We are not sure if this bug is inside the existing adapter or not. We will figure it out while developing the new adapter. In case if it is not, we will have it fixed in Web Chat, expect sooner than 12/15.

Will be fixed in #1442.
The main culprit: the adapter does not set speaking property to true/false. Fixed the adapter code and bumped the version in this PR will get it fixed.


App stops working when user runs app for iphone 11 Pro Max Simulator

App stops working when user runs app for iphone 11 Pro Max Simulator

can you give me more specific error detail? i ran the example app and it worked

Basically it just hang the simulator.. nothing happens when it become firstResponder..
NOTE:- When I ran it on physical device then it works as expected..
Please try it with  Xcode 11.0 iphone Pro Max simulaor
Thanks

hey @Kaustubh2018  sorry for late reply.
no you don't need KeyboardObserver and it is irrelevant to UnderLineTextField. the KeyboardObserver only observe keyboard's frame changes and push scrollview's bottom so view would be visible. if you remove observer the keyboard will cover views in bottom.

@Kaustubh2018  about simulator freezing when a textfield become a firstRepsoner, i could'nt reproduce the same bug. i am currently building the example app with Xcode 11.1 (11A1027) on a mid 2014 macbook pro

Hi,
Following was happening with me ... and I got the solution from the last comment...This was not from your side...Thanks for helping...
https://forums.developer.apple.com/thread/122972
Solution:
"Simulator -> Edit -> Automatically Sync Pasteboard" cancel selected.
"Hardware -> Restart"


Property variance type annotations for Flow plugin

Non-method properties and indexers of object types, declare class, and
interfaces can be "positive" or "negative." Class fields, but again not
methods, can also have variance.
This PR generalizes the variance annotations for type parameters into a
new node type, and reuses that node for those properties.
The code for object types is reused for interfaces and declare classes.
The changes there are straightfoward.
The code for class fields is reused for object literals, which do not
support variance annotations (currently). This code is a bit sketchy,
because we always parse variance annotations in the parsePropertyName
extension, then error in a the subsequent parse phase for object
literals (parseObjPropValue) or class methods (parseClassMethod).

Tests fail due to missing babel support, which is added in the referenced PR to Babel.
Is it possible to bump these versions in lock step, or do I need to break up this change into multiple steps?

Heads up, I'm going to change this to roll back the addition of a new variance node. Instead, I will continue to use the "plus" | "minus" | null format that currently exists for type parameters.

Current coverage is 94.52% (diff: 97.29%)

No coverage report found for master at 2697bfd.

Powered by Codecov. Last update 2697bfd...0651e0a

OK, I removed the new node type, so this is no longer a breaking change. In order to preserve the existing error messages, I needed to pass around the position of the variance annotation out-of-band, which is a bit hacky, because we need to be careful to clean up after ourselves with delete.
In the future, when Babel approaches a major version and we can make the breaking change, I'd like to go back to having a separate node type for variance annotations.


Shopping list Details - Delete Confirmation Dialog does not appear

"Pressing Delete option opens the delete confirmation dialog"
Created a Shopping List.
Opened Shopping list using the eye icon
Clicked the stacked dots icon
Clicked "Delete"
Shopping list deleted without confirmation dialog box appearing

Now a pass


Add probabilities when user does not know previous pattern

We can calculate the steady state probability of any given pattern using a Markov model.  Thus, we can get initial probabilities for the 4 states and display it to the users when they select "I don't know" for the "Previous Pattern".  This builds on issue #13.
If my calculations are correct (details below; someone please verify), given no information about the previous week and no information on Mon - Sat for the current week, the chances for each pattern are:
pattern0: 0.346
pattern1: 0.247
pattern2: 0.148
pattern3: 0.259

I'm using a Markov chain with the pattern numbers & probabilities from Ninji's TurnipPrices::calculate().  And, since I've not done these calculations in over a decade, I'm using an online calculator with the following data:
0.20 0.30 0.15 0.35
0.50 0.05 0.20 0.25
0.25 0.45 0.05 0.25
0.45 0.25 0.15 0.15

I'm not certain how this is affected by issue #48, which seeks to update probabilities based on Bayes.  I suspect the problems are independent; that is, the solution for issue #48 will just work when given these probabilities.  If not, maybe a HMM would work?

If my calculations are correct (details below; someone please verify), given no information about the previous week and no information on Mon - Sat for the current week, the chances for each pattern are:
pattern0: 0.346
pattern1: 0.247
pattern2: 0.148
pattern3: 0.259

Verified that these numbers looks good to me: Wolfram alpha link, link 2 (The vector in link 2 is the first eigenvector for the previous link)

I'm not certain how this is affected by issue #48, which seeks to update probabilities based on Bayes. I suspect the problems are independent; that is, the solution for issue #48 will just work when given these probabilities. If not, maybe a HMM would work?

I also think that #48 should just work with these probabilities.

hasn't verify yet, but issue #48 can work with this just fine, it only provides another pre-defined probability pattern. Use these pre-defined probabilities as P(pattern is k) after entering MonAM price

@peter50216 Thank you for validating and, in particular, for providing the Wolfram Alpha links.  They helped greatly with developing a solution.

Fixed in #109.


BL-586 Feature/meeting model update

Description
Co-authors: Kristina Cernekova, Sujata Sahoo, Roger Vieira
Meeting collection schema updated to match the plan for restructuring the DS database.
Type of change

[x] New feature

Checklist:

[x] My code follows PEP8 style guide
[x] I have removed unnecessary print statements from my code
[x] I have made corresponding changes to the documentation if necessary
[x] My changes generate no errors
[x] No commented-out code
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Scrapped this because there were accidental commits


[Deploy] Webex Teams recipe

Service
Integration of Webex Teams web client.
Link to your repository
https://github.com/sdasilva/recipe-webexteams
Additional Information

boost


Pull request for new lab - 200 - BUILD AWS HEALTH AWARE OPERATION CHANGE PROCESS Authors

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It's been reviewed and approved by Rich Boyd (ricboy@) and Phong Le (huu@).

It's been reviewed and approved by Rich Boyd (ricboy@) and Phong Le (huu@).


Try to fix s6-overlay-suexec: fatal: can only run as pid 1

See breaking changes https://www.home-assistant.io/blog/2022/06/01/release-20226/#breaking-changes

Sorry, I did not reload my browser and did not see this PR. I fixed it in the meantime. Let me know if it works now. Thanks

Perfect. Thank you.

Was fixed in in   3b0a504feea2f  and 1cc83eaabee .


Fix all command no longer removes unused imports

The Fix All no longer seems to remove the unused imports. I have the following settings defined in my settings.json
"[python]": {
    "editor.codeActionsOnSave": {
      "source.fixAll": true,
      "source.organizeImports": true
    }
},
"python.analysis.fixAll": [
    "source.unusedImports"
  ],

OS:  MacOS(13.5.2 (22G91))
VsCode version: 1.82.0
Python extension version: v2023.16.0
Pylance extension version: v2023.9.10
It was working up until few days ago and today I noticed that it no longer works. I have tested this on insiders version as well along with pre-release versions of both pylance and python extensions.
So not sure where the bug is.

Any update on this ?

looks like it is broken.

Is this a dupe of #4830 ?
Try doing this:
"python.analysis.enableSyncServer": false

ya, it works with that.
closing as a dup.

@rchiodo thanks for the tip, is there a downside of changing the default value of True to False ?


Add spacing below button

Description
When content of a page is scrollable, there should be more space between the 'Next' button and the edge of the screen.

Hi


Add support to use responsive images inside markdown content

This issue is not valid to solve the problem of insert a hero image inside text blocks.
Because a hero image must be larger than the text container.


let Lntxbot have internal transfers correctly handled

Invoices fulfilled internally within lntxbot users (including within one same user) do not respond with any payment_hash or payment_preimage. Still, if the reply has succeeded status it means it has gone through. We can handle the situation by giving a checking_id based on the hash of the response (it will not be directly queriable, but at the same time it needs to be unique in the DB), assign a blank fee to value 0, and leave the preimage blank

Codecov Report

Merging #263 (91ced3a) into master (bba3cbc) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   30.21%   30.21%
=======================================
  Files          31       31
  Lines        2317     2317
=======================================
  Hits          700      700
  Misses       1617     1617

Impacted Files
Coverage Δ

lnbits/wallets/lntxbot.py
16.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba3cbc...91ced3a. Read the comment docs.

Do NOT merge as is. This assumes that the hash of the response to the api request is unique, which might not be a safe assumption. #262 proposes a proper random value, which guarantees uniqueness checking_id in a rather stronglier way (or at least one that is more resistant to external attack)

@fiatjaf


Credit card validation

Add credit card validation support.

It would be better to include this feature in another library.
In a pure SEPA processing platform, we does not need to deal with Credit Card number.

@jycr, thank you for your feedback.
JBanking is meant to address general banking concerns, it is not only a library for SEPA. So I still think this feature can have its place in this library.

If you add an other functionnal domain (for example: "credit card"), have you planned to split this new domain into dedicated Maven module?
It would be great because we can import only needed module in our application.

@jycr, I did not plan to split jbanking in multiple modules for the time being.
Fyi I planned to work mainly on #34 for the next few releases.


Create target directory in tantivy new if it doesn't exist

Currently, tantivy new -i foo simply prints PathDoesNotExist("foo") when the directory foo does not exist. Considering that tantivy new is run outside the target directory (like cargo new), it would be more friendly to automatically create it.

Thanks!

Thanks! Maybe I should have updated the README.md too


In-App "User Manual" Link/Destination Broken; Receive a 404: Not Found" Error

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.804
Where did you get the app from?
Google Play
Android version
14 (Build Number: AP2A.240805.005)
Device model
Pixel 8 (Standard, NOT Pro)
Steps to reproduce

Tap hamburger menu
Select Settings
Under the Miscellaneous section heading, tap User Manual

Expected behavior
Open a user manual docs site, e.g. a GitHub pages site, containing end-user documentation.
Actual behavior

User Manual Link opens in default or selected web browser
Site response from GitHub Pages is "404: Not Found"

Logs
No response

Update/Addition
The in-app link appears to be the intended link to the User Manual, but the Manual is what's actually broken as I noticed the same User Manual link is in the thunderbird-android repo README
Small Apology Regarding Filing Location of this Issue
If the repo that powers the GitHub Pages site is not this one and is publicly accepting issues, then I apologize for not filing this issue in that repo, instead.

We've abandoned the user manual because we don't have resources to keep it up-to-date. However, I've now restored the last version and added a deprecation notice: https://docs.k9mail.app/en/6.400/
The in-app link to the user manual will be removed in the next stable release.


vagrant: Use ruby 2.7

Description of changes
If anyone knows ruby things better than I do, let me know if there's a better way. But since 8826b550a0d519c9adfd5d024ec8557170d34dc5, vagrant no longer builds.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/225136  this builds with ruby 3.1

So it does.

I tried to update the commit message, but failed to push.
vagrant: Use ruby 2.7

Because vagrant fails to build with ruby 3.1.

Fixes: 8826b550a0d5 ("ruby: update default version to `ruby_3_1`")

https://github.com/NixOS/nixpkgs/pull/225136 was merged instead.


Any way to refresh the model?

Hello,
Thanks for building this widget! I am seeing an odd issue -- I've bound an object property to the idp-output attribute. However when my script changes that value, the duration does not change. I have to tap the duration picker open, and then hit cancel before it will refresh itself.
Is there any way to manually trigger the picker to refresh?

Hello enayetn
I have pushed a fix for the issue! Let me know if it works as expected.

Nice! Works great, thanks 😀


Is there any change of the defination of icustay in compare with mimic-III and eICU

Hi,
Thanks very much for your great work.
I want to know how many icu patients were included in mimic-iv, so  I queried the data via bigQuery with this sql string:
SELECT count(distinct hadm_id) as hadm,count(distinct subject_id) as subject,count(distinct stay_id) as stay FROM physionet-data.mimic_icu.icustays
and I found there were only 50k+ patients with about 69k+ icustay were documented.
I am very curious about the result, because from the patients table, we can find more then 383k unique patients and previous eICU database included 200k+ icustay entries.
So,  was I wrong?
Any comments will be appreciated!

I get the same results. My understand is that dataset also has emergency room visits, so not every patients will have an ICU stay.

Yes, correct. The idea for mimic_core is to contain ED/ICU patients. As a result, most patients in mimic_core will not go the the ICU (and not be in mimic_icu).
The MIMIC-ED data will give information about the ED patients. It's not yet available however.
Finally, the ICU stays are only merged into the same stay_id if they are consecutive. This is different from MIMIC-III, where any ICU stays within 24 hours were merged together.

Thanks very much for your reply.


Unable to change the row count via state after 2.1.0

Hello,
Since version 2.1.0, I noticed that providing the table count using state only reflects the initial value. Take the following example:
this.state = {
    count: 5
}
const options = {
            count: this.state.count,
            serverSide: true,
            rowsPerPage: 10,
            rowsPerPageOptions: [10, 25, 50]
}

After querying the server and modifying the state count, the row count on the bottom right will still show the old value of 5.
Expected Behavior
this.setState({count: 100})

Expected to show the row count to 100 instead of 5.
Steps to Reproduce (for bugs)
Please use the following link as a demonstration:
https://codesandbox.io/s/muidatatables-custom-toolbar-lwgog?fontsize=14
If you rollback the mui-datatables version to 2.0.0, the behavior will be as expected.

I am also noticing a similar issue with other options such as column configuration.

I believe this is a duplicate of https://github.com/gregnb/mui-datatables/issues/610#issuecomment-494701967.

It is. Thanks for pointing out. I couldn't find that issue when I opened this.


pylance reports missing imports when "pip install -e ."

Type: Feature Request
I have a local module that I am importing in another module, and I use "pip install -e ." to keep changing and working on both modules.
Doing this, in the VSCode editor, my imports are reported as missing, flagging them in yellow.
The code runs totally fine and python can find them.
In both modules the environment is the same and is the one that is activated.
This gets solved by installing the modules without the -e flag ("pip install ."), so it is a specific issue about how pip behaves when using that flag.
It is not crucial, but it would be nice to see in the editor that all is fine.
Thanks,
VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Issue remains with version 1.76.0

/extPython


Infinite recursion with localAction middlewares

If use localAction middlewares, which throw some error, it make infinite recursion on io.call actions
For fix it, need to place:
if (action.name === 'io.call') {
  return next(ctx);
}

on each localAction middleware

what is localAction? 🤔

This line cause infinite recursion:
https://github.com/tiaod/moleculer-io/blob/da2a53f4a341a4463a82e11d1745e69da25c0413/src/index.js#L240
Seems err object is recursive and it heap all free memory with stack trace:
<--- Last few GCs --->

[20024:0x55f4d184bc50]    20414 ms: Mark-sweep 1353.1 (1458.4) -> 1353.1 (1442.4) MB, 42.4 / 0.0 ms  (average mu = 0.147, current mu = 0.002) last resort GC in old space requested
[20024:0x55f4d184bc50]    20486 ms: Mark-sweep 1353.1 (1442.4) -> 1353.1 (1442.4) MB, 72.3 / 0.0 ms  (average mu = 0.060, current mu = 0.001) last resort GC in old space requested

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x274c46d1d971 <JSObject>
    0: builtin exit frame: stringify(this=0x274c46d10941 <Object map = 0xc9455003e21>,0x0d2ae35025b1 <undefined>,0x065581cc4a69 <JSFunction replacer (sfi = 0x29c3d41d83c9)>,0x0f07f1936da9 <Object map = 0x3686281c35c1>,0x274c46d10941 <Object map = 0xc9455003e21>)

    1: stringify [0x226592c38941] [/home/darky/Desktop/Projects/backend/node_modules/fast-safe-stringify/index.js:11] [bytecode=0x4e16...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: 0x55f4d01b96f1 node::Abort() [node]
 2: 0x55f4d01bafb7 node::OnFatalError(char const*, char const*) [node]
 3: 0x55f4d0351492 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0x55f4d03516eb v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0x55f4d06e9573  [node]

Module fast-safe-stringify internally used by winston logger

Create PR: https://github.com/tiaod/moleculer-io/pull/13
for fix it

Thank you! :smile:

Released 1.0.8


Enhacement: Show scene limits through debug panel (#1873)

What does this PR change?
How to test the changes?

Launch the explorer using --debug
Open the Current Scene in the panel at the right side.
Move the avatar and visit different scenes (goerli world recommended).

The panel should show information about the current scene (name, parcels and height). If you enable the "Show scene bounds" checkbox, a red box should surround the scene.
If there is no scene info, "" should be displayed, and the box should not be visible.
https://github.com/user-attachments/assets/958ac25c-7fcd-4738-b0e5-e0db3b2ed56a

Summary by CodeRabbit

New Features

Introduced a new constant CURRENT_SCENE for better categorization in debugging.
Enhanced scene debugging capabilities with new UI bindings for scene properties.

Bug Fixes

Restructured diagnostic categories by removing and reintroducing the "ASSET_BUNDLES" category, improving reporting accuracy.

Documentation

Updated the ISceneFacade interface for clarity by repositioning the IsEmpty property.

Chores

Updated the subproject commit reference for unity-shared-dependencies to track the latest version.

QA testing for this ticket is complete, and the feature works as expected. Here are two observations:
1. The scene name displays as a sequence of letters rather than something more recognizable (e.g., "dollhouse").

2. When the "Show scene bounds" checkbox is enabled, there is a visual glitch on the scene's floor. This issue only occurs when the checkbox is selected and does not affect functionality (e.g., second scene visited in the video --> seed).

Is this expected? @QThund
🟢 Everything else is functioning correctly. Approved by QA!
Explorer.2024-09-11.15-52-58.mp4

Yes it is. The glitch happens due to z-fighting between the base of the red box and the ground of the scene. It can be easily fixed if needed. About the name, I didn't find an easy way to get a "prettier" name. That name may be useful to search for the scene in the Unity scene hierarchy.


Fix options not updating in the component when updated from Python

Because the options were only loaded from args when the component was constructed, they would not update when the options argument was changed from Python. This fixes this problem by removing the options from state, and retrieving them directly from args in the render function.
Small app demonstrating the problem:
import streamlit as st
from streamlit_free_text_select import st_free_text_select

options_count = st.session_state.get('options_counter') or 1
if st.button('Add option'):
    options_count += 1
    st.session_state['options_counter'] = options_count

if st.button('Remove option') and options_count > 1:
    options_count -= 1
    st.session_state['options_counter'] = options_count

options = [f"Option {i}" for i in range(options_count)]

selection = st_free_text_select('test', key='something', options=options)
st.write(f"Selected option: {selection}")

Hey!
Thanks for the contribution! How should one handle options, that are selected from the options list but then removed? Maybe set the component value to None?
Best
Sander


Revert "fix, search failing if there is a next url"

Reverts andjosh/clubhouse-cli#138
This can be merged once https://github.com/clubhouse/clubhouse-lib/pull/68#issuecomment-578241220 is addressed.

👋 A backend fix has been deployed, everything should be fine now. Let us know if this is not the case.


Add ability to make all texts editable

Hi, could you add the functionality where you can edit all the texts of this plugin? It's bad to see those texts also because in my opinion this plugin is excellent for city roleplays.

Added in v1.2.1 https://modrinth.com/plugin/journey/version/1.2.1


Add documentation covering TLS configuration

This documentation should include diagrams and examples. It should describe the purpose of TLS configuration on each resource and the server vs client roles here.

@hbagdi are you able to take this one on?

/assign

Closed by https://github.com/kubernetes-sigs/service-apis/pull/391


feat(highlights): basic highlights for Aerial support

Very basic but looks good on my end.

Thanks. This plugin will take up a lot of UI, so I think we should create some config for this one. Something general like symbols_outline, so that other similar plugins can use the same config if needed.
Default could be:
{
    transparent_background = {
        symbols_outline = true
    },
    flat_background = {
        symbols_outline = false
    },
}

So by default it would have the same (darker) background as file-tree and LineNr

I just checked and they don't seem to have a way to set background for the whole window...
Then the config stays unchaged I guess, but this could be a todo for the future if they ever support it.
This looked a bit better for me:
    hl.set("AerialNormal", { fg = colors.fg2 })
    hl.set("AerialLine", { fg = colors.fg, bg = colors.bg4 })
    hl.set("AerialLineNC", { fg = colors.fg2, bg = colors.bg3 })

I've looked at some other places where a line is selected in this colorscheme (pmenu, telescope) and non-neutral color for fg is never used, only brighter bg if needed, so I think this is more in line with the colorscheme style.

Glad a config wasn't needed as I have no idea what that would have meant. Thanks for the help. Looks great!

It really is much easier than it may sound like :) file-tree plugins could be used as a reference
Also next time, there's no need to manually edit doc/mellifluous.txt, it get's updated automatically from readme with a github workflow (using panvimdoc). So just pushing changed readme is enough.


Swagger ui auth

Issue: #167

[X] Tick here to confirm that you have run RunCodeFormatter.ps1

Description:
Enable Authentication with Swagger UI
Test:
Build and run Nether.Web
Navigate to /api/swagger/ui and click the Authorize button at the top of the page. Select nether-all, and then sign in to nether. Validate that you can call APIs appropriate to your user permissions (e.g. admin APIs for admin user, player APIs for player user)

Hi @stuartleeks, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Stuart Leeks). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Dev Box Pool list not alphabetized

Dev Home version
0.1601.561.0
Windows build number
10.0.22635.4010
Other software
OS Build Version: 10.0.22635.4010.amd64fre.ni_release.220506-1250
.NET Version: .NET 8.0.6
Steps to reproduce the bug
Click create environment list
Expand project list
Expected result
Alphabetical list
Actual result
Not an alphabetical list

Included System Information
CPU: Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
Physical Memory: 31.6GB (14.35GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHome.Canary_0.1401.500.0_x64__8wekyb3d8bbwe (Core Widget Extension)
Microsoft.Windows.DevHome.Canary_0.1401.500.0_x64__8wekyb3d8bbwe (Hyper-V Extension)
Microsoft.Windows.DevHomeAzureExtension.Canary_0.1000.549.0_x64__8wekyb3d8bbwe (Dev Home Azure Extension (Canary))
Microsoft.Windows.DevHome_0.1601.561.0_x64__8wekyb3d8bbwe (Core Widget Extension)
Microsoft.Windows.DevHome_0.1601.561.0_x64__8wekyb3d8bbwe (Hyper-V Extension)
Microsoft.Windows.DevHome_0.1601.561.0_x64__8wekyb3d8bbwe (Windows Subsystem for Linux Extension)
Microsoft.Windows.DevHomeAzureExtension_0.1100.561.0_x64__8wekyb3d8bbwe (Dev Home Azure Extension (Preview))
Widget Service:
MicrosoftWindows.Client.WebExperience_524.21802.0.0_x64__cw5n1h2txyewy

Hi @acangialosi, I just tested out the latest version of Dev Home: ver 0.1601.561.0 and the Azure extension ver: 0.1100.561.0. I confirmed that the pools were sorted. Can you confirm that you're using these version only? By the looks of the extensions you have installed you still have the old Canary versions and they may still be enabled. You can either uninstall them or disable them.
Let me know if the issue is resolved. This should be fixed as of the last release of the Azure extension last month, I confirmed that both my projects list and pools list are both sorted when I use those two above versions of the apps

Reconfirmed on the latest version of Dev Home; this has been fixed.
Please reopen if needed with additional details.

Closed by mistake.


Chore merge main 46d7c30 to ??

[x] https://github.com/twbs/bootstrap/commit/46d7c30eb3e2cf3539b6c47865b1de09d7514ae8
[x] https://github.com/twbs/bootstrap/commit/87be2b9d24c60db1070b2241d7046fc002132a4e
[x] https://github.com/twbs/bootstrap/commit/688d7e352a3c6370d7aa1871c0bb1d461af6a8e7
[x] https://github.com/twbs/bootstrap/commit/b0ce89229b3103bc216377470ed1eaaa2f3b9800
[x] https://github.com/twbs/bootstrap/commit/e16ee0a191ccb429b910ee60237424b3e5bca27a
[x] https://github.com/twbs/bootstrap/commit/59231069e9dc81355214bb002af0126d5e15da8c
[x] https://github.com/twbs/bootstrap/commit/58880cfbaccd5438ddb735eed5cec6f29bfbe017: not having details regarding this change, I've backported it only to the same files
[x] ~https://github.com/twbs/bootstrap/commit/04a720bf7f266f3f17a551a99832929ee15908e6~:  we don't have any dashboard examples in Boosted
[x] https://github.com/twbs/bootstrap/commit/5cb92cd6c07087673d308cd5a3094092bcda1f84
[ ] https://github.com/twbs/bootstrap/commit/953b4b6c1b67e120235fc19f565444a0f7a97a76
[ ] https://github.com/twbs/bootstrap/commit/2c4e1cd660ee03e1fc9f2804487ae8c567d8d1e3
[ ] https://github.com/twbs/bootstrap/commit/192b7f785ee91dd8dde62bc37a8c6fa02cdba194
[ ] https://github.com/twbs/bootstrap/commit/b3bca581f12601455bce520d2d8935f982c51bf7
[ ] https://github.com/twbs/bootstrap/commit/1baec29637844256e6bb52f6cf5fb96611ed3d0c
[ ] https://github.com/twbs/bootstrap/commit/b003fc78805954584e1ee364a4ad39d7c79e819a
[ ] https://github.com/twbs/bootstrap/commit/816d11ecaee31ea4074d51b34119803274c1525e
[ ] https://github.com/twbs/bootstrap/commit/f54befa74b3d8de86c65a9bb07e2815ce2985deb
[ ] https://github.com/twbs/bootstrap/commit/f545964f8f7446a889b9226d865807d58b7fb8cb
[ ] https://github.com/twbs/bootstrap/commit/930740afbc87931475df4785c9e13e0818e8af66
[ ] https://github.com/twbs/bootstrap/commit/6ce0c62e21ec4d611020d421e94de52115216afe
[ ] https://github.com/twbs/bootstrap/commit/2bc395b563768cf250d3e2c637db67d936e42a01
[ ] https://github.com/twbs/bootstrap/commit/7b8211ce64438679acf68d2734c629bf0b8eb0a2
[ ] https://github.com/twbs/bootstrap/commit/13f40f17911a93525e4057fd4197a589eab482eb

https://github.com/twbs/bootstrap/commit/58880cfbaccd5438ddb735eed5cec6f29bfbe017

crossorigin shouldn't have been added in the first place. In the upstream site it's not needed, unless you have hit an issue which is fixed by adding crossorigin=anonymous :)

Oo good catch, I thought it was removed upstream, not added 😄 Now fixed!


Filter mideleg and medeleg according to available bits

Currently we do not allow delegating exceptions and interrupts from M-mode: https://github.com/CharlyCst/mirage/blob/28a5b99233249f5a9752155827cd03ca3b2c8850/src/virt.rs#L614-L615
But eventually we would like to allow delegating traps and interrupts for performance reasons.
Depending on the implementation, only some of the bits can be set. To properly allow delegation we must first discover which bits can be set by M-mode, and then only allow the virtual firmware to set those bits.

Update: We now have support for interrupt and trap delegation. We detect the available bits for mideleg and filter the value that can be written.
https://github.com/CharlyCst/miralis/blob/09c6b15e9d74b754cf2a0b82136707697db361fe/src/virt.rs#L1070-L1071
Closing the issue as completed :)


config: enforce configuration values programmatically

For testing purposes, I would like to make sure to programmatically disable certain modules such as serviceDiscovery and MMRP - instead of having to enforce the use of an environment variable for running tests.
@ronkorving @qubyte help/pointers on how I could get this done would be most welcome.

I'll have to refresh myself on how how mage modules work again before I have much useful to say. However, for regular node modules I'm a big fan of sinon for stubbing the exports of object-like modules, and sandboxed-module (much heavier) for function-like modules.
Regardless of how mage modules work, the latter solution will always work, but since it means loading modules from scratch each time it is used, it usually entails careful use of before when writing tests to avoid loading everything for every test.

The main issue is that right now, the configuration is loaded as soon as we require MAGE; this means that there are no ways to programmatically disable those two modules since they basically get set up right after configuration in the current code path:
https://github.com/mage/mage/blob/master/lib/mage/Mage.js#L241

Yup, sandboxed-module can rescue you from this case by allowing you to stub config. Something like
let Mage;

before(() => {
    Mage = SandboxedModule.require('../path/to/Mage', {
        requires: {
            '../config': {
                // replacement config here
            },
            // stub other modules if needed
        }
    });
});

The cost is that you're loading a fresh instance of that Mage module in a sandboxed environment.
A better way might be to have config required higher up in the app, and fed in as an argument to a setup function. Tests would then require in the pre-setup Mage and call the setup function with whatever config they like. Naïvely I'd alter setupCoreLibs to take config as an argument. That would alter ./lib/mage/index.js to look like:

/** @module mage */

const config = require('../config');
const Mage = require('./Mage');

// Make a mage instance with the loaded configuration, and assign it as the module.exports.

const mage = module.exports = new Mage(module);
mage.setupCoreLibs(config);

// Global default settings override.

require('http').Agent.defaultMaxSockets = 100;	// max 100 parallel client sockets per agent

In tests you would now require and manipulate mage/Mage directly, avoiding mage/index and baked in config.

@ronkorving what do you think? Seems that would require tangible changes... nevertheless, it would be rather useful, for testing if anything.

I'm a big fan of feeding configuration from the outside, and not have modules read their own. It would be a significant change though, but in the long run, I'm in favor.

Actually, we could just add a set method on the config, and require it prior to requiring  MAGE. Let me try to have a crack at this.


Update nuspec file to current format

Side notes from chat: nuspec file probably should be upgraded, as it's using a now-deprecated format.

Closing this: if still relevant, it will be update when porting to .NET Core. Progress can be tracked in #143


Add Workflow and CBMAWorkflow classes. Support pairwise CBMA workflows

Closes None.

Changes proposed in this pull request:

Convert cbma_workflow function into a class (CBMAWorkflow).
Add Workflow base class.
Support pairwise estimators in Diagnostics.
Support pairwise estimators in Workflow.
Support pairwise estimators in Report.

@jdkent We are getting an error while building the documentation. It seems related to the nimads source file:
WARNING: /home/docs/checkouts/readthedocs.org/user_builds/nimare/checkouts/809/examples/01_datasets/05_plot_nimads.py failed to execute correctly: Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/checkouts/809/examples/01_datasets/05_plot_nimads.py", line 28, in <module>
    nimads_studyset = download_file("https://neurostore.org/api/studysets/Cv2LLUqG76W9?nested=true")
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/checkouts/809/examples/01_datasets/05_plot_nimads.py", line 25, in download_file
    return response.json()
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/809/lib/python3.8/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Thanks for the heads up, I should have fixed the issue now.

Great point.


data method not called with this as argument when using mixins with data option

Version
2.5.9
Reproduction link
https://codepen.io/cool_zjy/pen/KyLpve
Steps to reproduce

run the reproduction
VueComponent logged in console
uncomment // mixins: [mixin],
run the reproduction again

What is expected?
VueComponent logged in console
What is actually happening?
undefined logged in console

Please use this to access component instance in hooks and other methods.
https://codepen.io/Akryum/pen/OOYywd

@Akryum Why? Since 2.5 data function receives vm instance as the first argument https://github.com/vuejs/vue/pull/6760

I'm on a PR.

I think the fix is adding this as the second arg on call in the mergeDataOrFn function


Branch doesn't align with RPI2/IoT instructions on blog

Trying to generate/find RPI2 binaries for Windows 10 IoT development however the blog post on the matter is misaligned with the git repo.
https://msopentech.com/blog/2015/05/15/uap-in-action-running-opencv-on-raspberry-pi-ii/

Hi @riverar, thanks for your feedback!
Binaries have been deleted here, I've just restored it. Let me know if you hit other issues when following the blog post steps and thanks again for finding this!


Add an option to simply pass AwilixContainer via the plugin options

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal
I want to propose an option to pass a custom AwilixContainer to the plugin.
Motivation
Hi, thanks for the great plugin.
Currently, this plugin uses a singleton container declared inside it.
While we can directly access it via import { diContainer } from '@fastify/awilix' and call diContainer.dispose() to reset its contents, I think it's more intuitive if we can just pass a new AwilixContainer when we initialize the plugin.
This proposal is mainly for testing. Sure, we can dispose and re-initialize deps on-the-fly, but the option to provide the diContainer makes the test far easier.
Example
export type FastifyAwilixOptions = {
  disposeOnResponse?: boolean
  disposeOnClose?: boolean
  asyncInit?: boolean
  asyncDispose?: boolean
  eagerInject?: boolean
  container?: AwilixContainer<Cradle> // <- default to `diContainer` defined in the plugin
}

// register AwilixContainer with plugin option.
// this way we can easily swap the dependencies in testing environment.
fastify.register(fastifyAwilixPlugin, {
  container: newDIContainer
})

(and with this implementation, we can merge plugin code for each injectionMode)

Sure, I'll look into it!

@yshrsmz It was released in 5.0.0, could you please test it and report back if it works as expected?


Write a C# program to find the largest two elements in an array

Description
Write a C# program to find the largest two elements in an array
Input: arr[] = {12, 13, 1, 10, 34, 1}
Output: The largest two elements are 34 and 13

Input: arr[] = {10, 5, 10}
Output: The largest two elements are 10 and 5

Input: arr[] = {10, 10, 10}
Output: The largest two elements are 10 and 10

How to contribute

Comment !assign to assign this issue to yourself
Fork this repository
Create a new branch
Save the solution in program/program/find-the-largest-two-elements-in-an-array/FindTheLargestTwoElementsInAnArray.cs
Commit the changes
Create a pull request

!assign


selected checkboxes 'stick' when removed

[Apologies if repeat or invalid bug or wrong repo]
The code at https://gist.github.com/maxf/efd173cf14a77f4af381cf8ad4c13a20 has a basic List String model and turns it into a ul with checkboxes for each string in the model, as so:

There's also a message that lets the user remove items by clicking the relevant checkbox. For instance, when clicking on the 3rd item, it removes  "three"  from the model and view renegerates the Html:

As you can see the 3rd checkbox is now ticked. But clearly shouldn't.

This is what the Html.Keyed module is for. If you can't figure out how to use it to avoid the issue you describe, please ask on Slack or on the mailing list.
http://elm-lang.org/community

Note that while the documentation of that module just says "... to reuse nodes more efficiently", it's really not just about efficiency, but also about correctness, as in your case.

Thanks for the workaround @jvoigtlaender
Indeed, it's about correctness here.

Why do you not close the issue here?

To the point, what I indicated is not a workaround. It is the API you have to use for what you want to do.

I'm not sure how this is not a bug. The tick mark appears on an checkbox I didn't interact with.
Using an external package to get the correct behaviour is indeed a workaround, not a fix, in my opinion.

@maxf This is because keyed will cause node regeneration, if you just (from the perspective of the virtualdom) change the text and even handler it does not know that it needs to reset any possible user state of it without knowing that the underlying model changed, which is exposed via keyed.  It is technically the same checkbox just mutated with the new data, keyed tells it that it is an entirely new checkbox.

How is elm-lang/html an "external package"? It's the same package you are using, and Keyed is the proper API for your use case.
But I won't argue further here. I mentioned before that if you need discussion of this, the place for that discussion is not here. Slack or the mailing list us it. In fact, if you check the mailing list archive, you are bound to find several threads around this already.

@jvoigtlaender ; you're right, it's not an external package. But my point stands, and I've started a discussion at https://groups.google.com/forum/#!topic/elm-discuss/ZZQvfFLpzPE


Display Show Smoke Signal events

Smoke Signal has a data lexicon for Events and RSVPs.
Initial success: Display events inline
Stretch goal: display RSVP status inline and allow user to toggle

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

In progress here https://smokesignal.sonaruo.com/ -- visit your profile and look at the events tab in your profile.


Dev server improvements

Changes
This improves the dev server logging. Now:

✅ All console.* messages log and keep (even across page loads!)
✅ Plugins can throw and the output will bubble up to the dev server
✅ Dev server shows state as ERROR or READY, along with error log (error persists even after fix)

Screenshots
Default (no errors)

React

Vue

Svelte

Lit Element

How about the status bar at bottom? Any changes needed there?

Testing

Wow! Huge improvement! I'm going to try to pull it down tomorrow and play around with it. How does the proxy output look? Might be nice to have that listed below the main line?

My previous csa generated app just sits at loading...

Made some changes! Will let the screenshots show:
Startup, Simple Project (Preact), No Workers

load() Error, Simple Project (Preact), No Workers

Startup, Complex Project (Svelte + TypeScript)

Errors, Complex Project (Svelte + TypeScript)

White Color Scheme

Seems like the latest batch of changes fixed the issue with it not starting.
One thing I noticed which is probably unrelated to these changes, but missing files are a bit annoying.

Would still love to see proxy get some love with these changes but I can submit a PR after the fact if you want.
Currently, it just logs to console which is now greatly improved to where we can at least see the errors.

It would be nice to see something like this (example of Next.js):

+1 for better proxy output, can take a look at that similar to Next.js
Not sure what the service worker issue is but most likely not related to this PR, would love more info if you want to spin up an issue/discussion to debug/triage

Not sure what the service worker issue is but most likely not related to this PR, would love more info if you want to spin up an issue/discussion to debug/triage

I previously had a service worker registered on that localhost:port, so when I started the app it requested a /service-worker.js file. I just thought it was a lot of output for a missing file. Is there a way we could condense the fact that we're checking different file extensions? maybe like service-worker.[js|mjs|jsx|ts|tsx]?
I just pulled in the latest and ran it again, seems like something changed? Might be an issue with linking? I know at one point it wasn't adding the absolute path

Also, just curious if it would make sense to make paths relative to the running directory instead of absolute? For example,
/Users/mstramel/Projects/testing/snowpack-tests/test-1/public/service-worker.js
to
/public/service-worker.js
since the project is being ran out of /Users/mstramel/Projects/testing/snowpack-tests/test-1

Lets keep output as is for now, but would be curious to clean up in a follow up PR. I have definitely made mistakes mapping a relative path to an absolute path in my head (when a tool doesn't give you the full absolute path) so I'm sensitive to it as a debugging tool.
@stramel I'm confused why the plugin name is that full path in your logs, are you on the latest version of the babel plugin? If updating doesn't fix it, can you share your config file? That's definitely a bug

@stramel I'm confused why the plugin name is that full path in your logs, are you on the latest version of the babel plugin? If updating doesn't fix it, can you share your config file? That's definitely a bug

It went away after I updated my dependencies. 👍


[ltla-umappp|ltla-*] new ports

This adds the port ltla-umappp and all required dependencies. I included them in a single PR, because all 6 libraries are using the same project layout, same CMake handling, are all header only and overall relative small libraries without any patches or other edge cases and have many dependencies on each other. I assume reviewing will be very similar for all of them, so maybe it is easier to look at them at once. However, if you want a single port per PR I could split it up.

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

/azp run

Testing usages.

Testing usages.

Tested usage on x64-windows.


style attr gets re-evaluated when other attrs need change

Describe the bug
Found a weird behaviour when working on asciinema-player - style attr gets re-evaluated when other attrs need change.
Your Example Website or App
https://asciinema.org
Steps to Reproduce the Bug or Issue
I created minimal reproduction example in the Solid Playground.

go to https://playground.solidjs.com/?version=1.3.13#NobwRAdghgtgpmAXGGUCWEwBowBcCeADgsrgM4Ae2YZA9gK4BOAxiWGjIbY7gAQi9GcCABM4jXgF9eAM0a0YvADo1aAGzQiAtACsyAegDucAEYqA3EogcuPfr2ZCouOAGU0Ac2hqps+YpU6DW09CytwiBl6CGZcNFoIXgBhAAs0NREACkJ5QjIASn4rXgcEsj5y-DU4XgBeXkzC2oA+IsSS0ogguAA6NVoPTIBySuqAQiH8y3aSoVwmRIFmdW5EXhzaPJ7l-olJaZLJCNm4ecZEzOKO-X0HKDU1Ml5RuEbeBN44ADdxfAcNZgAa0QVxKAB4yIQoIkKPgAF61EAbLbLaK4aQvREvRqSZpI3JkHoyWi0SRg-SQ6HNY7XW4iWhwMgQIZ8Zj3HzYwofb6-f5oIEgma8G68CFQxKYkCc3H4zaE4mk8mUiDU9pTKxHCBWKIxOIfJIMCAuRhvEBXZZdPjAVFGrDPU4GtEAXTqDicLncXnumQADOr2hbyrwMI44PAja63i17bhHUbMjbcG8ANS8ACM-qucwWDVBopM9FwuA+BGItRUBaLCRU7wgSQBgMRIaE4fRqo6HRAiZxefBqXSIlKu3LYCEIhricR3fy0n07Y65MrxZVV39mqsQlE4kyUdaYLjxuFzTt9OY9FbPQ8pwAotVWwAhfAASSyKighEIKny-rAkidQA
click on the button several times
notice how "style!" gets logged to the console on every click

Expected behavior
I expected that style={style()} attr won't be re-evaluated given the style() function doesn't use any prop that click handler mutates, but it does. I found that referencing the same prop inside the component body instead doesn't cause this behaviour - only changes to a prop that's use in one of the attrs causes this. I found this out when changes to my classList caused re-eval of style, but it seems it's not classList specific, as any attr name (xyz in my example) reproduces this.
Screenshots or Videos
No response
Platform

OS: Linux
Firefox
Version: 98.0.2

Additional context
No response

You return a new object every time style() is called, thus it gets re-evaluated. Use createMemo to avoid that: https://playground.solidjs.com/?hash=-939766425&version=1.3.13

More so though it's that we group things. Creation is generally much more expensive than update. Generally grouping with shallow diff is better than wrapping each in a separate effect, except where structural reconciliation is involved. So re-evaluating expressions may happen but it won't apply them. If it is expensive memo it, otherwise probably not worth worrying about.

Aha, I see. Thanks for the clarification.
For my use case it kinda does matter, given asciinema-player mutates props very frequently, sometimes hundreds of times per second (https://github.com/asciinema/asciinema-player/blob/8009671f94a507b8695f48e31e81ca8c6996349e/src/components/Terminal.js#L22 - props.blink is frequently updated causing style re-eval). While I don't have a lot going on in my style function the unnecessary eval just compounds in my case.
I can use a memo fine, that was actually my plan B here, so will do that.
Is the "You return a new object every time style() is called, thus it gets re-evaluated" behaviour documented somewhere?

I don't think it matters here. Because it isn't inlined it de-opts to a style helper anyway that does a diff. Most things do shallow referential to check for changes which @atk is referring to but this one doesn't matter. It's always an object so knows it needs to diff.

Hmm, ok.. I don't understand any of it but I guess you don't find it as a bug so I'm going to close it. Thanks.


Create a docker image?

It'd be really useful to have an official docker image along with your releases, that we could use in our CI pipeline.

Sure, why not! If there's a way to automate that for free, using Github Actions for publishing the new image, I'm up for it. As I don't know too much how that all works, help would be appreciated.

I'm not familiar with github CI unfortunately, we use woodpecker CI which is an open source one for all our projects, and it has a docker buildx plugin that can build and push to dockerhub.
I'm sure one probably exists for github tho.

I've decided for things like this, rather than deploying a full docker image, its probably just easier to use cargo binstall in the CI. Here's some sample CI code:
commands:

- wget https://github.com/cargo-bins/cargo-binstall/releases/latest/download/cargo-binstall-x86_64-unknown-linux-musl.tgz
- tar -xvf cargo-binstall-x86_64-unknown-linux-musl.tgz
- cp cargo-binstall /usr/local/cargo/bin
- cargo binstall -y cargo-machete
- cargo machete

Nice! TIL binstall. For what it's worth, one might also take the latest release exe from Github, modify it to make it executable, and then put it in $HOME/.cargo/bin, then run cargo machete.


Implement naming convention checking workflow

As the title suggests, implement naming convension workflow.
It would check whether the pushed/changed file, maintains snake_case for variable names, and kebab-case for file names.
Assignee is @Vivek-GuptaXCode
Use the test-workflow branch to test the changes

Relevant workflow link

Sign-off criteria:

[ ] Exclude .dot files, i.e .gitignore
[ ] Exclude files that are in .dot folders
[ ] Only check the .sh files that have changed
[ ] Check the file name only (not whole path), i.e file-name.sh not Array/file-name.sh
[ ] For non-conforming files, display the whole path
This list is not exhaustive, implement as many checks/criterias as you wish

Fixed by https://github.com/JohnRTitor/Shell-Programming-Assignments/commit/cfe4d050efe149013ffc2cff6f656a18399f4ff2
Note: this runs a seperate script located in the workflow folder


SWA - Failed to deploy the Azure Functions - EnvironmentId tag is set

Seeing an issue when deploying swa with an api using ADO AzureStaticWebApp@0 task
api works fine when running the swa cli emulator locally
Function Runtime Information. OS: windows, Functions Runtime: ~4, dotnet version: 6.0
Finished building function app with Oryx
Zipping Api Artifacts
Done Zipping Api Artifacts
Zipping App Artifacts
Done Zipping App Artifacts
Uploading build artifacts.
Finished Upload. Polling on deployment.
Status: InProgress. Time: 0.1298361(s)
Status: InProgress. Time: 15.981754(s)
Status: InProgress. Time: 31.2706856(s)
Status: Failed. Time: 46.393219(s)
Deployment Failed :(
Deployment Failure Reason: Failed to deploy the Azure Function
I see a similar issue was raised https://github.com/Azure/static-web-apps/issues/622
I have tried changing the api from .net to node/js etc and received the same error. swa is deployed to west europe.

Hi @johnmccormick99
This looks like an issue on our side, we are looking into it.

Hey @johnmccormick99,
Looks like we have a bug with how we handle the 'EnvironmentId' tag. Can you try removing this from your SWA?

@miwebst - I've just hit the same issue - where do I find the EnvironmentId tag (to remove it) please ?

Your deployment failure could be caused by something else (i.e. failure to startup). In this specific incident, an EnvironmentId tag was added to the SWA and caused the issue. Tags can be added/removed in the Overview in the Portal. If you did not add it, it likely does not exist and you are hitting another issue.

Probably best to confirm that your Function is able to startup and function as expected using the Function tools in VS Code.

Hello,
Same issue for me.
It works in my local environment npx swa start build --api-location api but never when I try to deploy it with an AzureStaticWebApp task in my pipeline.
I tried with javascript, typescript and dotnet function but nothing works.
Any 'EnvironmentId' tag set in my side.
---End of Oryx build logs---
Function Runtime Information. OS: windows, Functions Runtime: ~4, dotnet version: 6.0
Finished building function app with Oryx
Zipping Api Artifacts
Done Zipping Api Artifacts
Zipping App Artifacts
Done Zipping App Artifacts
Uploading build artifacts.
Finished Upload. Polling on deployment.
Status: InProgress. Time: 0.1238067(s)
Status: InProgress. Time: 15.2399686(s)
Status: InProgress. Time: 30.4544307(s)
Status: Failed. Time: 45.592686(s)
Deployment Failed :(
Deployment Failure Reason: Failed to deploy the Azure Functions.

I'm going to update the title of this issue and close it as the initial issue around 'EnvironmentId' is rare and likely not relevant to these tests. My advice for debugging this type of issue would be to add application insights and see what logs are emitted when you deploy: https://docs.microsoft.com/en-us/azure/static-web-apps/monitor

We've documented the workaround here: https://blog.johnnyreilly.com/2022/07/07/static-web-apps-failed-to-deploy-the-azure-functions

We've documented the workaround here: https://blog.johnnyreilly.com/2022/07/07/static-web-apps-failed-to-deploy-the-azure-functions

Hey @johnnyreilly  we don't have any EnvironmentId in our tags, still facing the Azure functions issue.
Do you know any other reasons, or is it a MS issue?

I'm not sure I'm afraid


Nextcloud app won't use jwt_secret

After updating to the latest onlyoffice docker, I can't seem to get any connection to it from Nextcloud. I can access it from the browser, but when trying to connect to it from nextcloud I get
{"reqId":"1XkYs4VQGhXTJPV3ZZkF","level":3,"time":"2018-11-15T14:01:12+00:00","remoteAddr":"internal-ip","user":"--","app":"onlyoffice","method":"GET","url":"\/apps\/onlyoffice\/empty?doc=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJhY3Rpb24iOiJlbXB0eSJ9.dzGbTTowX_dLViEYKGyYN9oHW9oXPBr-IiwOyv0OtEc","message":"Download empty without jwt","userAgent":"--","version":"<IP_ADDRESS>"}
{"reqId":"x34OZ0ymJPY86Tg5SdLw","level":3,"time":"2018-11-15T14:01:13+00:00","remoteAddr":"internal-ip","user":"--","app":"onlyoffice","method":"GET","url":"\/apps\/onlyoffice\/empty?doc=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJhY3Rpb24iOiJlbXB0eSJ9.dzGbTTowX_dLViEYKGyYN9oHW9oXPBr-IiwOyv0OtEc","message":"Download empty without jwt","userAgent":"--","version":"<IP_ADDRESS>"}
{"reqId":"ehm4C3KAMs1jfqkUbIaN","level":3,"time":"2018-11-15T14:01:14+00:00","remoteAddr":"internal-ip","user":"--","app":"onlyoffice","method":"GET","url":"\/apps\/onlyoffice\/empty?doc=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJhY3Rpb24iOiJlbXB0eSJ9.dzGbTTowX_dLViEYKGyYN9oHW9oXPBr-IiwOyv0OtEc","message":"Download empty without jwt","userAgent":"--","version":"<IP_ADDRESS>"}
{"reqId":"vxDMR3EKLvDKv74wiA2r","level":3,"time":"2018-11-15T14:01:16+00:00","remoteAddr":"external-ip","user":"zingmars","app":"onlyoffice","method":"PUT","url":"\/apps\/onlyoffice\/ajax\/settings","message":"GetConvertedUri on check error: Error occurred in the document
service: Error while downloading the document file to be converted.","userAgent":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko\/20100101 Firefox\/63.0","version":"<IP_ADDRESS>"}

The thing is, I already have the following lines in the config.php -
'onlyoffice' =>
  array (
   'verify_peer_off' => true,
   "jwt_secret" => "<>",
   "jwt_header" => "<>",
  ),

I also set the secret key field in the settings.
Server side I get this
onlyoffice_1  | [2018-11-15 14:01:14.638] [ERROR] nodeJS - error downloadFile:url=https://domain/apps/onlyoffice/empty?doc=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJhY3Rpb24iOiJlbXB0eSJ9.dzGbTTowX_dLViEYKGyYN9oHW9oXPBr-IiwOyv0OtEc;attempt=3;code:undefined;connect:undefined;(id=conv_check_98850012_docx)
onlyoffice_1  | Error: Error response: statusCode:403 ;body:
onlyoffice_1  | {"message":"Access denied"}
onlyoffice_1  |     at Request._callback (/var/www/onlyoffice/documentserver/server/Common/sources/utils.js:250:18)
onlyoffice_1  |     at Request.self.callback (/var/www/onlyoffice/documentserver/server/Common/node_modules/request/request.js:185:22)
onlyoffice_1  |     at emitTwo (events.js:126:13)
onlyoffice_1  |     at Request.emit (events.js:214:7)
onlyoffice_1  |     at Request.<anonymous> (/var/www/onlyoffice/documentserver/server/Common/node_modules/request/request.js:1161:10)
onlyoffice_1  |     at emitOne (events.js:116:13)
onlyoffice_1  |     at Request.emit (events.js:211:7)
onlyoffice_1  |     at IncomingMessage.<anonymous> (/var/www/onlyoffice/documentserver/server/Common/node_modules/request/request.js:1083:12)
onlyoffice_1  |     at Object.onceWrapper (events.js:313:30)
onlyoffice_1  |     at emitNone (events.js:111:20)

Hello @zingmars, please make sure that JWT header in the section below matches the header in local.json of the document server.
'onlyoffice' =>
array (
'verify_peer_off' => true,
"jwt_secret" => "<>",
"jwt_header" => "<>",
),
Section in local.json:

I have it set in default.json as mentioned here - https://github.com/ONLYOFFICE/onlyoffice-owncloud/issues/193#issuecomment-400638470. I also have tried setting the JWT_HEADER by setting environment variables for the container as per https://helpcenter.onlyoffice.com/server/docker/document/docker-installation.aspx

@zingmars

After updating to the latest onlyoffice docker

Please check if JWT settings are set in the Document Server container


PR description file from command line

Currently the PR description is taken from the README file of the project. When running large campaigns it's possible you need to create PRs with different descriptions.
It would be useful to provide a command line parameter to specify the file to be used for the description instead of copy pasting the content in the REDME file.
The REDME file would continue being the default value.
turbolift create-prs --description prs/description1.md

Thanks @Dan7-7-7 !


ViewModel always creating a new one

An example of use when the viewModel is re-created, since the owner of the BackStackEntry always changes. so never works ViewModelStoreOwner.getViewModel
NavHost(
        navigator = navigator, initialRoute = startDestination, modifier = modifier
    ) {
        scene(HOME_ROUTE) {    <- there is always a new viewModelStoreOwner
            val viewModel = viewModel(HomeViewModel::class) {
                HomeViewModel(appContainer)
            }
            HomeView(viewModel)
        }
    }

Hi, can you provide more information or an example project that reproduce this bug? I've check the todo sample and it's working for me.
https://user-images.githubusercontent.com/8370277/232263582-b3377826-ff59-427c-b6b6-07c98085cc6b.mp4

class NoteListViewModel : ViewModel() {
    init {
        println("NoteListViewModel instance ${this.hashCode()}")
    }
...

class NoteEditViewModel(
    private val id: Int?,
) : ViewModel() {
    init {
        println("NoteEditViewModel instance ${this.hashCode()}")
    }
...

@Composable
fun App() {
    val navigator = rememberNavigator()
...
NoteEditScene(
 id = id,
 onDone = {
      navigator.goBack()
 },
 onBack = {
     navigator.navigate("/home")
     //navigator.goBack()
 }
 )

Before switching to PreCompose, I used androidx.navigation
composable("/home") {
val viewModel: HomeViewModel = viewModel(factory = HomeViewModel.provideFactory(...))

and there the viewModel was not created again. Therefore, I expected the same behavior after switching to PreCompose.
17.04.2023 16:51:42.webm

You use navigator.navigate("/home") instead of navigator.goBack() in NoteEditScene's onBack callback, which navigates to a new route and eventually creates a new instance of HomeViewModel, that's by design. If you want to navigate to the home while keeping the HomeViewModel as a single instance, you can use navigator.navigate("/home", options = NavOptions(launchSingleTop = true)).

Thank you. It would be nice to be able to see the back stack of state routes while developing, debugging, and learning how to use the library. For example, the ability to observe the current position as a string "/home/page1/page2" and so on.


Can you get the starter code for the fourth assignment?

Sorry for bothering you.
So I have been taking the course online, and now I have reached the fourth assignment, but the starter code isn't there anymore. It asks you to fill out the Google form, but after that it provides this link, which is broken.
Can you help me with that? I would really appreciate it.

@Mr-Welcome1 I'm sorry I didn't see your message until now. So you need the assignment 4-Priority Queue starter code？

Thank you for responding. I was able to obtain it.


camera based 3D bounding box detection (transformer multicue)

Hi,
I am curious to understand how the camera pipeline estimates 3D bounding boxes from 2D bounding boxes.
Is there a paper, that you guys can point to?
Is the 3D information out of this module used in fusion?
If so, why is not included in the demo record file?
Thanks in advance

I am wondering if you could share some more information about this issue. I am unable to understand how exactly do we calculate the center of the object and how do we use (H,W,L) and orientation to project 3D Bounding boxes.
Thanks


How to consume the converted model from CoreML with image input/output?

I found this topic mentions that the data buffer should be manipulated before you can use it. however the generated wrap class uses VideoFrame with does not support BGR format( an exception will be thrown if you try to evaluate the model).  any examples for how to consume this kind of model would be great.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c28f709-f39f-51e1-dbd6-049496ec9b8d
Version Independent ID: b2a668cf-c3b8-2236-2f6c-0e876f4393a0
Content: Convert existing ML models to ONNX - UWP app developer
Content Source: windows-apps-src/machine-learning/conversion-samples.md
Product: windows
GitHub Login: @wschin
Microsoft Alias: sezhen

Which API version are you using? Windows.AI.MachineLearning.ImageFeatureValue should support BGR format.

I checked the api you provided, it seems only available on insider preview [Windows 10 Insider Preview (introduced v10.0.17709.0) ]. I'm using the public version under "Windows.AI.MachineLearning.Preview" namespace.

Hi @JohnMasen, many apologies for the delay on this. Now that Windows.AI.MachineLearning has been fully released publicly, have you tried again with the current APIs? The ones you were using were preview APIs.


Mismatch between PROTO list and Addnode Dialog

Describe the Bug
A new PROTO can be added using the add node dialog but then it is not found at revert.
Steps to Reproduce

Start Webots.
Create a new PROTO file.
Add this new PROTO node to the simulation => PROTO found.
Save and revert the simulation => PROTO not found.

Expected behavior
It should find the PROTO even after revert.

It is actually only if the new PROTO is located in the installation directory of Webots, because the WbProtoList assumes that the files in the installation directory won't change during runtime.

Not sure what is the best solution, to re-generate completely the list at revert or to deny adding them from the add node dialog.

I would avoid re-generating the complete list for just this very special case.

I checked and both would complexify the code and increase either the world loading time or add node creation. I propose to keep it as is as it's a shame to slow down one or the other for this very specific edge case.


Config not found

# 1
u1%git clone git@github.com:jlelse/GoBlog.git
u1%cd GoBlog
u1% cp example-config.yml config.yml
u1% go run .
2023/08/13 09:14:50 Failed to load config file: Config File "config" Not Found in "[/tmp/GoBlog/config]"
exit status 1
u1% ls config.yml
config.yml

And
# 2
u1% go build -tags=linux,libsqlite3,sqlite_fts5 -o GoBlog
u1% ./GoBlog
2023/08/13 09:18:53 Failed to load config file: Config File "config" Not Found in "[/tmp/GoBlog/config]"
u1% pwd
/tmp/GoBlog
u1% ls config.yml
config.yml

In the documentation  isn't mentioned where to copy the example-config.yml to, if it's not the root directory.

Don't just copy the example-config.yml. Create a new config.yml file or .yaml, you can also use config/config.yaml, and just add the settings you want to modify in there.


Feature/initialization fixes

Some updates to a readme, added 2 missing migrations and changed the db service name in docker-compose configuration. Also changed psycopg2 to psycopg2-binary.

Removed migrations, since they were added against (still) unsupported version of django-ilmoitin.

Removed migrations, since they were added against (still) unsupported version of django-ilmoitin.

Looks good! just a minor comment, approved already

Looks good! just a minor comment, approved already


Improve Level Select Screen

As long as the level key (argument to super in level constructor) and the key in levelMap are the same, things should work. We will refactor this system later.


Add long description to setup.py

Fixes #1088
Changes

Added the README.md as a long description in the setup.py
Added long_description_content_type field

Co-Authored by:
Martin Achtner<EMAIL_ADDRESS>Jad Saliba<EMAIL_ADDRESS>

Thank you. Could you pls run python setup.py bdist_wheel on your local env to see the result?

Validated on my local environment after the merge


Kernel abstractions

This PR contains all abstractions to the kernel class, and is meant to give a sense of the overall architecture of what is to come. All methods current raise NotImplmenetedError, and the bulk of the changes are actually documentation. The person reading this is simply meant to read the docstrings and comment on the chose of design. In its current form, the kernel consists of four "sub-kernels" covering simulations, scenarios, traffic lights, and kernels. More details can be found within the PR itself.

Pull Request Test Coverage Report for Build 1332

0 of 178 (0.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.005%) to 74.548%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flow/core/kernel/traffic_light/base.py
0
14
0.0%

flow/core/kernel/simulation/base.py
0
16
0.0%

flow/core/kernel/kernel.py
0
23
0.0%

flow/core/kernel/scenario/base.py
0
42
0.0%

flow/core/kernel/vehicle/base.py
0
83
0.0%

Totals

Change from base Build 1213:
-2.005%

Covered Lines:
5067

Relevant Lines:
6797

💛  - Coveralls

@mtgibson2014  is doing this.

Looks good but we should discuss the raised issues.

Okay, this looks fine to me. I'm approving it and you can merge it when you're ready.


updated login function for mw >= 1.27

Breakage with new mw version:
Methods which do not require POST requests ignore the request body (f.e. list allimages), therefore we need to split POST and GET functions further or append the parameters to the url (on top of the params in the body). (the current implementation is garbage anyway)

I can't get clientlogin to work, so we'll use login and require a password from Special:BotPasswords


[FR] Option to delete a column without delete the field into all the rows

Option to do not remove the fields inside all rows when you remove a column

Option added with 0.3.1 =)
Enjoy!


SMP Intergarion Xcode 14.3 Plugin troubles

Hey. I read solution for previous issue, but it didn't help me. I clone my project from git which already contains R.swift dependency.
I tried remove R.swift from SPM and install again, it didn't help me.
Now I see next:

This solution worked for me: https://github.com/mac-cain13/R.swift/issues/813#issuecomment-1457045537

Duplicate of https://github.com/mac-cain13/R.swift/issues/822


I want to show a success message after verification !!

i used VerifyFirtsEmail , i want to show a success message after verification !!
i do this in my user model
 public function sendEmailVerificationNotification()     {         $this->newEmail($this->getEmailForVerification());     }

i find the solution by using  @if(session()->has('verified'))


Struggling to get strdup memory leak detection to work

Hello,
I've been completely stumped trying to understand why strdup is not working on my machine: ubuntu 20.04 LTS
I compiled latest source that is git, tried latest passing build as well which was april 2020, same problem
For some reason I'm not able to get strdup override defines to work
Here is a simple test code I added to the examples folder
#include "CppUTest/TestHarness.h"
#include <stdio.h>

extern "C" {
#include <string.h>
}

TEST_GROUP(StrdupGroup)
{
    void setup()
    {
    }
    void teardown()
    {
    }
};

TEST(StrdupGroup, StrdupWithoutFreeNoMemoryLeak)
{
    char mystring[] = "this will be duplicated";
    char * dupstr = (char*)strdup(mystring);

    STRCMP_EQUAL("this will be duplicated", dupstr);
}

TEST(StrdupGroup, StrdupWithFreeFails)
{
    char mystring[] = "this will be duplicated";
    char * dupstr = (char*)strdup(mystring);

    STRCMP_EQUAL("this will be duplicated", dupstr);

    free(dupstr);
}

TEST(StrdupGroup, StrdupPrintWhichDefinesCompilerSees)
{
#ifdef CPPUTEST_USE_STRDUP_MACROS
        printf("CPPUTEST_USE_STRDUP_MACROS\n");
#endif
#ifdef CPPUTEST_USE_MALLOC_MACROS
        printf("CPPUTEST_USE_MALLOC_MACROS\n");
#endif
#ifdef CPPUTEST_HAVE_STRDUP
        printf("CPPUTEST_HAVE_STRDUP HAS STRDUP MACRO\n");
#endif
#ifdef HAVE_STRDUP
        printf("HAVE_STRDUP\n");
#endif
#ifdef CPPUTEST_USE_MEM_LEAK_DETECTION
        printf("CPPUTEST_USE_MEM_LEAK_DETECTION\n");
#endif
}

StrdupWithoutFreeNoMemoryLeak = will pass, however as you can see I never try to free the duplicated string
StrdupWithFreeFails = will fail, because I'm trying to free a pointer that the library is not aware of
StrdupPrintWhichDefinesCompilerSees = just a poormans way checking which includes are visible.
And here is the output:
Linking CppUTestExamples_tests
Running CppUTestExamples_tests
.!!!!CPPUTEST_USE_MALLOC_MACROS
CPPUTEST_USE_MEM_LEAK_DETECTION
.
AllTests/StrdupTest.cpp:27: error: Failure in TEST(StrdupGroup, StrdupWithFreeFails)
StrdupWithFreeFails:27: error:
        Deallocating non-allocated memory
   allocated at file: <unknown> line: 0 size: 0 type: unknown
   deallocated at file: AllTests/StrdupTest.cpp line: 35 type: free

...........................................
Errors (1 failures, 49 tests, 45 ran, 284 checks, 4 ignored, 0 filtered out, 0 ms)

We can see that none of STRDUP defines are visible for some reason.
But in configure I can see it did detect system's support
checking for strdup... yes

I can also see it defined in CppUTestGeneratedConfig.h file
/* Define to 1 if you have the `strdup' function. */
#ifndef CPPUTEST_HAVE_STRDUP
#define CPPUTEST_HAVE_STRDUP 1
#endif

Am I missing something completely obvious?
Any help would be appreciated

I got it to work, I was checking which CppUTestGeneratedConfig.h was it using when compiling, it seems it used the original one and not the generated one
/*
 * This file is confusing, sorry for that :) Please never edit this file.
 *
 * It serves 3 purposes
 *
 * 1) When you installed CppUTest on your system (make install), then this file should be overwritten by one that
 *    actually contains some configuration of your system. Mostly info such as availability of types, headers, etc.
 * 2) When you build CppUTest using autotools, this file will be included and it will include the generated file.
 *    That should be the same file as will be installed if you run make install
 * 3) When you use CppUTest on another platform that doesn't require configuration, then this file does nothing and
 *    should be harmless.
 *
 * If you have done make install and you still found this text, then please report a bug :)
 *
 */

#ifdef HAVE_CONFIG_H
#include "generated/CppUTestGeneratedConfig.h"
#endif

For some reason HAVE_CONFIG_H wasn't defined.
As a work around, I copied the generaeted file over this one, and it seemed it started working.
Not sure if this is a bug, or user error?

In my usage of cpputest as a submodule and MakefileWorker.mk I have the same problem.
I've gotten around it by adding some stuff to my Makefile:
INCLUDE_DIRS += $(CPPUTEST_HOME)
CPPUTEST_CPPFLAGS += -DHAVE_CONFIG_H

Is this something that will be changed/fixed, or should I just do this forevermore?
Seems a bit odd to have to include the root of CPPUTEST repo as well as it's include directory.


image icon etc?

Hey!
Thanks for what you done!
Do you have plans for update the source about image, icon, etc?

Hey, I don't really do anything with the CPKs, but it's not hard to extract them yourself: https://exvius.gamepedia.com/How_to_data_mine

@aEnigmatic OK. Thanks!


rez-env : REZ_CONFIG_FILE + default_shell not taken into account..

Hi,
seems the REZ_CONFIG_FILE for the default_shell variable isn't always respected.
For instance with the rez-env cli, it isn't respected.
$ REZ_CONFIG_FILE=path_to_my_rez_config.py rez-env foo
I could debug this quite deeply in the code, while I can understand the root problem, I'm not sure what's the best solution :
within rez-env command function (rez/cli/env.py::L119) :
the opts obtained from the actual command line arguments is passed. This one has shell value which actually in my case is defaulted to 'tcsh' (my default system shell is that).
But in that command function the rez config instance is also imported from rez.config import config.
In that config instance the default_shell value is well set to the one I've set in my own config file exported above (default_shell = '/bin/bash' ; basically).
But at the end of the function the execute_shell() method called on the context is passing the opts.shell, which is not what I want ..
the parser used higher level should default the shell value to the one obtained from configuration file.
And effectively : in setup_parser : config from rez.config is imported but was not used..
Given it's simple I'm gonna propose a small PR to fix this specific issue.
But I'm guessing the same should be done possibly for other rez-xxx commands.. at least it is fixing our situation temporarily.

Hey thanks for the head's up Gregory, will take your fix soon.
A
On Wed, Mar 15, 2017 at 6:19 AM, Grégory Starck<EMAIL_ADDRESS>wrote:

Hi,
seems the REZ_CONFIG_FILE for the default_shell variable isn't always
respected.
For instance with the rez-env cli, it isn't respected.
$ REZ_CONFIG_FILE=path_to_my_rez_config.py rez-env foo
I could debug this quite deeply in the code, while I can understand the
root problem, I'm not sure what's the best solution :
within rez-env command function (rez/cli/env.py::L119) :
the opts obtained from the actual command line arguments is passed. This
one has shell value which actually in my case is defaulted to 'tcsh' (my
default system shell is that).
But in that command function the rez config instance is also imported from
rez.config import config.
In that config instance the default_shell value is well set to the one
I've set in my own config file exported above (default_shell = '/bin/bash'
; basically).
But at the end of the function the execute_shell() method called on the
context is passing the opts.shell, which is not what I want ..
the parser used higher level should default the shell value to the one
obtained from configuration file.
And effectively : in setup_parser : config from rez.config is imported
but was not used..
Given it's simple I'm gonna propose a small PR to fix this specific issue.
But I'm guessing the same should be done possibly for other rez-xxx
commands.. at least it is fixing our situation temporarily.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/issues/395, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABjqShi4V-BaSaJ2Uaz6sQqniGmIMSB4ks5rluhSgaJpZM4MdCSh
.

if it looks like a good fix to you (given I don't know all the code base), great :)

GST beat me to the punch with this ticket.  I actually have some code snippets that explains what gst is proposing (I think).  In rez.shells, add the follow function.
def get_default_shell():
    shell = config.default_shell
    if shell:
        return shell
    return system.shell

Then, in rez.cli.env, instead of defaulting to system.shell for the --shell argument, call and use the result of get_default_shell().


If resolvedFileName differs with realPath only in casing use the resolvedFileName before realpath so that errors can be reported with forceConsistentCasingInFileNames

Fixes #49470

@DanielRosenwasser do you think we can take this as well given we are taking the other fix for forceConsistentCasingInFileNames.
@typescript-bot cherry-pick this to release-4.8

My personal opinion is that this is less important than the long-path fix, but it seems low-risk and I have no particular objection.

@sheetalkamat @andrewbranch @amcasey This PR causes a performance regression with eslint in our code base. I have narrowed this down by testing our code with specific TS commits, and this is the culprit.
We have:

288,000 lines of TS
Webstorm

Running eslint --fix on save

ESLint config has prettier plugin which reformats code when eslint --fix runs

All of these together means we went from <0.5s to run eslint --fix on save to now taking ~10 seconds for each save.
Can you suggest a mechanism by which this change could have contributed to this slowdown? I haven't so far dived deeply into this code.

@imaginetheheadline Thanks for the heads up!  No, it's definitely not obvious to me how this could cause a major slowdown.  We've had problems in the past with accidentally making too many realpath calls, but it's not clear to me how this could cause that.
I think that if you grab a trace with pprof-it, the cause will jump right out.  The pprof file will contain only information about the code that's executing, not the code that's being analyzed, so it should be safe to share (though it will contain the paths to your copies of the code being run (e.g. c:\users\me\typescript\lib\tsc.js)).

@amcasey Have been running pprof-it a little and so far I'm noticing the following.
Context: I've been running a locally-installed TypeScript starting from this commit, and then comparing with removing this commit, and see the following results:
Pre-commit

eslint --fix runs in about 48 seconds, with garbage collection taking an additional 9-12 seconds.

Post-commit

eslint --fix runs in about 77 seconds, with garbage collection taking an additional 65-75 seconds
The main increase I can see so far, is time to run createDiagnosticExplainingFile

I have logged the fileProcessingReason here and can see that FileIncludeKind.Import is now at ~22,000 compared to ~6,500. Other FileIncludeKind values are about the same.

Memory usage in createDiagnosticExplainingFile is also high now.

If anything stands out from that that you can recommend I check next, let me know. Otherwise, I may be able to share the pprof files as well.

@amcasey Yeah, sure, I'll raise a proper issue tomorrow.
The diagnostics is a good question. Can you clarify what diagnostics means in this case? Would you expect that to be always running across the code, or would we only want that to be turned on in particular instances? I had checked our tsconfig to see if we were turning something on but I didn't see it. I'm also wondering if this might be the result of the config of some of the chain of tools here: typescript -> typescript-eslint -> eslint -> prettier.
I'll put all of this on the reported issue tomorrow.

@imaginetheheadline Oh, sorry, diagnostics is jargon for the error-like things (errors, warnings, and, in some languages, suggestions).  Broadly, things that might display as a squiggle in the editor.  In a general sense, it can refer either the error check or a specific instance of an error, but I was referring to instances of errors.  That is, if you looked in your Errors/Problems window, your output suggests you would see 6500 entries (now 22000)?

@amcasey Yeah I see. It says 55 errors, 2195 warnings, and 13,170 typos lol. Those don't seem to be all from TypeScript though. I'll restart the conversation with more info when I file the issue. Thanks so much for your replies!

If I'm not mistaken, those diagnostics are not error diagnostics - they're generated when running with things like explainFiles, traceResolution, and more.
I could be wrong though.