lineTo issues when lines overlap

I've had this weird issue for over a year now and I am trying to fix it now but I am out of ideas. I'm not sure if it's related to Pixi, WebGL or something else. We have an application where we render maps from a xml file using Pixi and we noticed these strange lines extending from what should actually be drawn. The xml file is autogenerated from an image and often has a lot of unnecessary and overlapping lines and polylines in it. Except from this issue, Pixi has handled it extraordinarily well, so thanks!
Expected Behavior
lineTo should not render any additional lines outside of the points I gave it.
Current Behavior
When I render a polygon (no difference if closed or not), in special circumstances some lines are being extended beyond what should be drawn. The length of the extended line increases with thicker lineStyles.
From what I've observed, it happens when you draw a line in a specific angle a, then draw a longer line with angle -a, going back and overlapping the previous line and then draw another line in angle b.
Possible Solution
Unfortunately I have no idea.
Steps to Reproduce
// 2ND POINT GOES BACK AND CAUSES LINE TO EXTEND WEIRDLY
const g = new PIXI.Graphics();
g.lineStyle(2, 0xff0000);

g.moveTo(42, 99);
g.lineTo(35, 92);
g.lineTo(61, 117);
g.lineTo(85, 118);

g.position.set(100, 0);

Environment
We saw it happen on many different devices with different OS and browsers.
Tested on:

pixi.js version: 5.3.7, 5.3.3
Browser & Version: Chrome 88, Firefox 86 and many others
OS & Version: Win10, Linux, Mac OS Big Sur 11.1
Running Example: https://www.pixiplayground.com/#/edit/egnGEqCLAen4GkMZcYrE2
Example Code:https://pastebin.com/kMC90VyU

Thanks for reporting @ps-lvuksan this indeed looks like a regression in behavior.
I tried changing the cap and join and miterLimit properties of the lineStyle with not effect.
I'm not seeing this in 5.2.5, so I think this was introduced in 5.3.0 when we added those new lineStyle Graphics features. @SukantPal this one is probably for you.

@ps-lvuksan This issue seems to be fixed on PixiJS 6.0.1; I've updated that playground you've posted in this issue and now the bug isn't there.

This might've been a duplicate of #6722.


RqPrint should reject requests without Content-Length

@rultor release, tag is 0.9.7

@rultor release, tag is 0.9.7

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.9.7

@yegor256 Done! FYI, the full log is here (took me 20min)


ESP32 Arduino Library

Hey @sepfy
Great work !
Any plans for an Arduino ESP32 library for small folks like me?
Thanks

Hello @sepfy , can you release a arduino esp32 library to stream video p2p

Sorry, No such plans in the near future


If camera component is added to entity in scene, splat will not render

Here's a simplified example of code that will prevent splat from rendering:
    <a-scene>
      <a-entity gaussian_splatting="src: https://huggingface.co/cakewalk/splat-data/resolve/main/train.splat;"></a-entity>
      <!-- the following line makes the splat not render -->
      <a-entity id="player" camera position="0 1.6 0" look-controls></a-entity>
    </a-scene>

Error reproduction: https://glitch.com/edit/#!/phantom-copper-sphere?path=index.html%3A15%3A0
(remove line 13 to see it work correctly)
console error:
index.js:16 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'el')
    at n.init (index.js:16:40)
    at n.initComponent (component.js:318:10)
    at n.updateProperties (component.js:300:12)
    at e.exports.Component (component.js:76:8)
    at new n (component.js:660:15)
    at d.initComponent (a-entity.js:319:17)
    at d.updateComponent (a-entity.js:471:10)
    at d.updateComponents (a-entity.js:442:12)
    at a-entity.js:243:12
    at a-node.js:150:17

Ok I'm not sure why but it appears that if an entity on the scene includes a camera component, then this is not available when init lifecycle method is first run on gaussian_splatting component.
A hack is to wrap the loading event with 1 second timeout
		setTimeout(() => {
			this.loadData(this.el.sceneEl.camera.el.components.camera.camera, this.el.object3D, this.el.sceneEl.renderer, this.data.src);
			if (!!this.data.cutoutEntity) {
				this.cutout = this.data.cutoutEntity.object3D;
			}
		}, 1000);

Instead we should probably listen to some sort of event being finished?

Instead we should probably listen to some sort of event being finished?
Yes, the webxr discord said wait until the a-frame scene loaded. See #23 ready for review


UX design of the multi-account hedera mapping to the user

Problem description
As a Guardian user I would like to be able to see the all Hedera accounts mapped to my account in order to implement the "Max 1K NFTs" workaround as described in the parent ticket.
Requirements
The UX need to be simple and don't emphasise the complexities and even the existence of multiple hedera accounts for a user. However when the user need to they should be able to see (this low-level technical info) what hedera accounts are mapped to her/him, and what is the balance in NFTs on each of them is.
DOD
UI mock-ups reviewed by Dev and Stakeholders
Acceptance Criteria
The existence of the non-intrusive UI to manage multiple accounts and large volume of NFTs as per requirements.

No longer required as per info from @sergmetelin


[ELE-587] Add criticality from metadata in a separate field

Is your feature request related to a problem? Please describe.
Not  a problem but criticality is a huge topic which I think is important to consider.
Describe the solution you'd like
To extract the criticality from the meta field in dbt_models.
Describe alternatives you've considered
Use regex as below
select meta,
    regexp_extract(meta, r'^\W+\w+\W+\w+@\w+.\w+",\s"criticality"\W+(\w+)\W+') as criticality,
from `my_project.elementary.dbt_models` as models
where meta <> '{}'

Would you be willing to contribute this feature?
Let me know if I can help with anything but I don't know about the language used.
ELE-587

Hi @maria-samper,
Could you please share which levels of criticality do you use today?
Also, do you configure criticality for models only or also for specific tests?

Hi @Maayan-s ,
we currently use low, medium and high and only for models as the criticality is usually associated with the model.


Wanted to improve footer design on the website

Is your feature request related to a problem? Please describe.
No problem in the footer but it is not attractive as I wanted
Describe the solution you'd like.
No response
Describe alternatives you've considered.
No response
Additional context.
Assign this task to me if you wanted to change footer design !
Show us the magic with screenshots
No response
Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@akshattiwarii can you make the footer like this.

for all the pages in website.

yes sure

And do it properly.


Lint Python code with ruff

Ruff supports over 500 lint rules including bandit, isort, pylint, pyupgrade, and flake8 plus its plugins, and is written in Rust for speed.
The ruff Action uses minimal steps to run in ~10 seconds, rapidly providing intuitive GitHub Annotations to contributors.

Moves isort out of tox.ini and into ruff and pyproject.toml.
Now when you want to fix imports, just do ruff --select="I" --fix.

OK. But I'm already running black. Black is also an auto formatter / linter.
Will this not interfere with Black?

https://beta.ruff.rs/docs/faq/#is-ruff-compatible-with-black
TL;DR: Black is a formatter and Ruff is a linter that has been designed to be compatible with Black.


Add install message

I'm dumb and couldn't figure out the gem name for second there.


Kibana Version Support 5.6.7

Any chance of some continued support for 5.6.x?

Should be an easy port from my latest 5.6.X release. Look for a release this weekend since this isn't my day job.
FYI - I only release new versions when asked... I have too many versions in flight right now. ;-)

Done and released.


[WIP] [KEP-4346]: feature-gate InformerMetrics to alpha

add feature description for InformerMetrics alpha promotion
KEP:  https://github.com/kubernetes/enhancements/issues/4346
code PR:  https://github.com/kubernetes/kubernetes/pull/123367

Hello @chenk008 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

@drewhagen Sorry, i think the code PR is still under discussion, so it will delay.

/hold
@chenk008 Kubernetes 1.30 is releasing today.
This PR will need to be targeting the dev-1.31 branch once it is available. Our team will keep you posted.

You can reopen this in the next release cycle and target dev-1.31. Thanks! :)

Heads up that dev-1.31 branch is created now, if you choose to reopen this for the next release.


Separated Python Error object for Rate Limit Error

Hi,
Twitter API python library does this, but we don't. Currently, we use HTTPError for this. We have to parse the result first before identifying that it was caused by rate limit. A RateLimitError object will be great.
Thanks,
Ami

Curious how you're parsing them at the moment, the _get_reason() method?

Oh, there is that method? Currently I just see if there is Limit Exceeded written in the exception string

Yeah, it's the method behind that exception string. I was hoping you'd come up with something better :)

Thanks!
But a separate exception will still be great. To make sure I don't catch any exception I shouldn't catch.

As the client library talks to many backend APIs (including YouTube) and each one has the opportunity to signify its own type of rate-limiting, and we cannot tie the client library to any particular static set of them for maintainability reasons, I'm going to close this issue.  Please let me know if you think this is in error, but please try to provide some example code changes if you do that give us a clue about how to do this while still retaining maintainability.


Whats wrong?

arkmanager install
Running command 'install' for instance 'main'
[  WARN  ]      Your ARK server exec could not be found.
[  ERROR  ]     The ARK SavedArks directory is not writable, and saveworld will fail
Installing ARK server ...
Message from syslogd@server1 at Dec 10 22:09:34 ...
sert_20161210220933_8.dmp[5721]: Finished uploading minidump (out-of-process): success = yes
Message from syslogd@server1 at Dec 10 22:09:34 ...
sert_20161210220933_8.dmp[5721]: response: Discarded=1
Message from syslogd@server1 at Dec 10 22:09:34 ...
sert_20161210220933_8.dmp[5721]: file ''/tmp/dumps/assert_20161210220933_8.dmp'', upload yes: ''Discarded=1''
Message from syslogd@server1 at Dec 10 22:09:44 ...
sert_20161210220943_7.dmp[5769]: Finished uploading minidump (out-of-process): success = yes
Message from syslogd@server1 at Dec 10 22:09:44 ...
sert_20161210220943_7.dmp[5769]: response: Discarded=1
Message from syslogd@server1 at Dec 10 22:09:44 ...
sert_20161210220943_7.dmp[5769]: file ''/tmp/dumps/assert_20161210220943_7.dmp'', upload yes: ''Discarded=1''

ark@server1:~$ arkmanager install
Running command 'install' for instance 'main'
[  WARN  ]      Your ARK server exec could not be found.
Installing ARK server ... \

Duplicate of #681


⚠ Fetchers has degraded performance

In 0aeb60a, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 261 ms

Resolved: Fetchers performance has improved in eabc2a3.


Investigate test loader changes in ember-cli-qunit@4

Just a reminder to double check to the changes made in https://github.com/ember-cli/ember-cli-qunit/pull/176 to make sure ember-exam still functions properly.

So the ember-cli-qunit changes do cause problems here, I'm going to investigate a way to make it backwards and forwards compatible.

I think parallelization is no longer working on ember-cli v2.13.x  due to this change since it comes with ember-cli-qunit v4.0.x  by default.

Seems likely. I'll try to find some time to look into it soon but would greatly appreciate if someone else could investigate before then.

I'm seeing this as well. Running ember exam --split 4 --parallel looks like each test is being run 4 times.

I can confirm TestLoader.prototype.loadModules is not being executed when using ember-cli-qunit v4.0.x
That means ember exam runs the whole test suite N times when using  --parallel --split=N
I guess this needs to be refactored to support the new behavior on cli-qunit.
https://github.com/trentmwillis/ember-exam/blob/master/vendor/ember-exam/test-loader.js#L55-L59

Looks like<EMAIL_ADDRESS>changed the order of execution of some things, thus test-helper.js runs first and calls start() which runs the TestLoader. This happens before ember-exam can monkeypatch the TestLoader class. I want to update this addon to take a more explicit approach, similar to ember-cli-qunit.

I'm encountering the same issue, i.e. the whole suite is executed when splitting. @trentmwillis anything I can do to help getting your PR in master?

I just released v0.7.0 which should make it possible to work with<EMAIL_ADDRESS>Note you'll need to invoke a new loadEmberExam function though.

@trentmwillis Awesome, works for me. Thanks so much!

Works for me for the most part. The only issue I've encountered (in parallel only) is that somehow my custom inflector rules not being respected. I am following this pattern: https://guides.emberjs.com/v2.13.0/models/customizing-adapters/#toc_pluralization-customization
I have a model 'bars' that is uncountable that is referenced through a hasMany on 'foo'. When running the model and serializer tests for 'foo' the test fails saying:
No model was found for for 'bar'
These tests do not fail when running without parallelization.


Update GitHub Actions & Azure DevOps Extension to use new DevContainer CLI

It seems like this is done - @stuartleeks is this issue safe to close?


[UberDriverDispatch] "Only one driver can be assigned to a request" is not satisfied

If I understand correctly, we are using a Shared state to control whether a specific request was fulfilled or not. i.e. DriverThreadSharedState
Unfortunately, when we spawn threads for each driver in DispatchThread.dispatch(), we create a new object of DriverThreadSharedState for each individual thread. Which means, each thread operates on its own state.
List<DriverThread> driverThreads = drivers.stream()                 .map(d -> new DriverThread(d, **new DriverThreadSharedState()**)).toList();
How to reproduce:
In the dispatch function, remove the break statement at Line 64 and print all the results for a request.
For certainty, we can also change the probability of a driver accepting a request to 1.
It should print that multiple drivers were assigned to the same request.
Possible fix:
Initialize a common shared state and pass it to each driver thread.
Please let me know if I can improve on the explanation and can submit a fix for this.

Hi Devanshu, the issue is genuine. Thanks for spending time and finding this out. I have fixed it.
Also, next time onwards, if you find any such issue, please raise an issue and also you can raise the fix in a separate PR.


🐞 Event Intervals

Check for existing bug reports before submitting.

[X] I searched for existing Bug Reports and found no similar reports.

Expected Behavior
There should be an "Add Interval" button in the event creation modal, as per the documentation
Current behaviour
There is no such button
Reproduction
Create a new calendar, create a new event, see no button.
Which Operating Systems are you using?

[ ] Android
[x] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version Check
1.7.4 and 1.5.8
Plugin Version
1.4.0
Confirmation

[ ] I have disabled all other plugins and the issue still persists.

Possible solution
No response

I want to add an event that occurs every number of days, but the only recurring options are every year, every month, or every day. The documentation states that there should be an "Add Interval" button when you create an event but I can't find it. There's also no tag when you create a note event.

I was looking for the same (event on 30th, recurring every 3 months) and tried via UI and notes.
The "Recurring" button in the event creation dialog was confusing: I understood the appearing input as the interval setting, but I could not get it to behave accordingly.
When playing around in a note/frontmatter, I managed to create an event that was recurring on 1. day in the 1. month, 2. day in 2. month, n-th day in n-th month. This is when I looked into the code.
This cache update functions seems to have a (semi related) bug here:
https://github.com/javalent/calendarium/blob/c8302e41004aeb8e734b9d1dfc2e571287d46fe9/src/stores/cache/event-cache.ts#L214C1-L219C26
const start = date.day[0] ?? this.month;
const end = date.day[1] ?? this.month;

When there is no date.day[x], it defaults to this.month. I assume that should be this.day.
I might be misunderstanding it's purpose of the RecurringCalEventDateBit, but to me it looks like Range and Recurring got mixed up here. I'm wondering if the second item in the array was always supposed to be the end date, could we not have put in intervals here and kept the end date input separately?

In my ideal case, I would read this as: "Starting from the last Day of the 3rd Month of the 10th Year, repeat every 3 months (until a potential end-date entered separately)"
In the end a simple interval input with integer day|month|year might be better suited, together with plain start and end dates.
Then a Range is just a Recurring with interval defaulted to 1 day
And for Recurring it could additionally check for every date between start and end to also match the interval by something like e.g. ((this.month - start.month) % interval) === 0 if the interval unit was set to month.


 Is this safe? and how can  i download

This is not an issue nor a problem,  you are on GitHub and the app you are trying to determine whether it is safe or not. It is safe, since it is open source. Your anti-virus deleted it because it is an unverified app, it is a false flag.


Make Lutron scenes accessible from HomeKit?

I very much appreciate the homebridge-pico. It provides significant critical functionality. Thank you!
A major new piece of desirable functionality would be to enable triggering Lutron scenes from HomeKit. These scenes have the significant advantage that Lutron has worked out a very elegant synchronized method for multiple lights/devices all responding together (through programming the switches ahead of time). HomeKit will never be able to replicate this through its independent device communication model.
To enable HomeKit to trigger Lutron scenes requires some new infrastructure in the homebridge-pico setup to send info in the other direction, i.e. receive requests from HomeKit and send them to the Caseta hub. Additionally, the scenes need to show up in HomeKit – I suspect they will just have to appear as new devices rather than HomeKit scenes, but that should work pretty well. On the Lutron hub, I think the scenes are DEVICE 0, with each of the scenes having a separate trigger number, so I think that communication will be fairly straightforward to establish.
I'd be happy to help with programming this, but I can't get started as I don't know enough to set up the basic communication infrastructure from HomeKit to Lutron. Once that is in place I could help with the details of the messages to the hub.
Thanks for considering this!

Do you see anything on the bus (if you have full logging enabled) when a scene is fired?
This may not be possible with the way I'm integrated.

No, there's nothing on the bus even with full logging. But if I do a direct telnet connection I can invoke a scene using a command to the Device 0.


Openshift 4.11 Pod security standards

Created new SCC to match baseline pod security standards by setting allowPrivilegeEscalation: false and updating clusterrole to use new SCC. This is required from Openshift 4.11 onwards.

@CathalOConnorRH @Mo3m3n has already worked on implementing this in his PR #241 and there is a discussion going on there. Could you please check that and see if this PR is bringing other changes than what he submitted there?

@CathalOConnorRH @Mo3m3n has already worked on implementing this in his PR #241 and there is a discussion going on there. Could you please check that and see if this PR is bringing other changes than what he submitted there?

I believe these are different, @Mo3m3n is implementing pod security on ckcp deployment, this PR is implementing pod security on the pods created by the pipeline runs which will be on the workload clusters

@CathalOConnorRH Shouldn't this rather be handled by the Openshift pipelines operator ?
There are multiple applications deployed in this project, some of them via operators (pipelines, gitops, etc) others directly by our scripts (kcp pod, syncer pod, etc).
My understanding is that it is the scope of the operator to make sure deployments runs in the cluster.
One way to double check this is to try running Openshift pipelines operator in 4.11 and see we get any warnings about restricted security policy.

@Mo3m3n  There is an upstream story opened for this for v1.9 but no release date set yet. This will secure pipelines sooner and allow us to resolve any issues we may encounter.

Setting as draft, as my understanding is that this PR might not be merged.

@CathalOConnorRH has this PR gone stale? If it is not needed anymore please close it. If it is still relevant please respond to the feedback and rebase the changes.

@CathalOConnorRH Could you check if this PR is relevant anymore with the changes to the repo? If not, please close it.


Add drep information for GET_ACCOUNT_INFO

For the GET_ACCOUNT_INFO message, we want to have drepId within the staking response.

This information will be required by wallets, if they withdraw after the next hardfork.


Support passing in dom elements as well as strings

My use case: interop with ember-native-dom-helpers which returns dom elements.
That way I can write things like:
import { find } from 'ember-native-dom-helpers';

test('it exists', async function(assert) {
  assert.dom(find('h1')).hasClass('bar');
});

You can already do that, but there is no reason to do it in this case because dom() already does pretty much the same thing as find()

My apologies, it wasn't obvious from looking at the docs + code.


Don't find item() function related information on this page?

Where is the explanation for item().type, item().name etc?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: befd9a68-45a2-9105-1b1b-16bf792a2d73
Version Independent ID: 2c2e1fa5-7824-5fe9-7382-bf5573a25be3
Content: System variables in Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/control-flow-system-variables.md
Service: data-factory
GitHub Login: @djpmsft
Microsoft Alias: daperlov

Hey @rgg-amahajan
You can find the item syntax in the for-each activity documentation: https://docs.microsoft.com/en-us/azure/data-factory/control-flow-for-each-activity#iteration-expression-language
Best,
Daniel
#please-close

Will do, thank you for the swift response @djpmsft ! It might also help to make item() functions discoverable in the "Add dynamic content" blade.

@rgg-amahajan Thanks for the feedback. I see a difference why item() function  is not mentioned under Add dynamic content blade. Item() function is specific to few activities (for eg: filter activity,  ForEach activity) and mostly comes into picture when iterating over a collection. Where as the other out of box functions provided in the Add dynamic content blade are generic functions and can be used is most of the activities.
But please feel free to share your feature request suggestion/idea in ADF user voice forum. Once you post your feedback please do share the feedback link here, so that other users can up-vote and/comment on your suggestion.
Thank you.


Avoiding prop type fail?

react-apollo complains about a prop-type failure on children when doing:
const Graphs = adopt({
  query: <Query query={USER_LEAGUES} />,
  join: <Mutation mutation={JOIN_USER_LEAGUE} />,
  quit: <Mutation mutation={QUIT_USER_LEAGUE} />,
});

is there a better solution than this?
const Graphs = adopt({
  query: ({ render }) => <Query query={USER_LEAGUES}>{render}</Query>,
  join: ({ render }) => (
    <Mutation mutation={JOIN_USER_LEAGUE}>{render}</Mutation>
  ),
  quit: ({ render }) => (
    <Mutation mutation={QUIT_USER_LEAGUE}>{render}</Mutation>
  ),
});

Or am I doing something wrong 😬 ?

For sure @danielmahon, in this case is better using render prop!


fix(website): :bug: Fix the presigned URL for video preview in the Analysis view

When an External bucket is defined in the MIE configuration, the pre-signed URL for the video preview must be generated using the data plane bucket instead of the external bucket.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Starting on August 30, 2023 Content Analysis on AWS will no longer be supported and the GitHub repository will be archived. Existing deployments will continue to run. If you have deployed Content Analysis on AWS via cloning GitHub open source code, you may continue to use the solution.
The functionality provided by Content Analysis on AWS will be superseded with functionality in Media2Cloud on AWS and Content Localization on AWS. We encourage you to explore these solutions.
https://github.com/aws-solutions/media2cloud-on-aws
https://github.com/aws-solutions/content-localization-on-aws


Created Contributing.md

#3
Implemented the Contributing.md file for a better and streamlined contribution to the project.

The branch you have created, specifically in the Contributing.md file, has conflicts that need to be resolved. Kindly use the web editor or your preferred tool to address these conflicts promptly.

Just a friendly reminder, please make sure to star the repository and click on "Watch" to stay updated with the latest developments and changes in the project.


XS✔ ◾ add

❌ Add a description.

@AsfaMumtaz Image is available for testing. docker pull stakater/workshop-exercise:SNAPSHOT-PR-171-abdc7125


[BACKPORT][v1.3.x][BUG] Backing image is not deleted and recreated correctly

https://github.com/longhorn/longhorn/issues/4256

Verified on longhorn v1.3.x head eb186e
Result Pass
Steps

Follow reproduce steps, this error not happened
Run e2e test_exporting_backing_image_from_volume twice, the error not happened as well


Cut / Copy Not Working in iPad OS

Looks like it's all working for me now.
Originally posted by @TylerLeonhardt in https://github.com/microsoft/vscode/issues/101564#issuecomment-906629795
You all seem to say this is working for you now, but I’m still getting the same problem as the issue above describes. What was the fix or is this actually still ongoing?

can you share if you're using vscode.dev or insiders.vscode.dev and what version of iPadOS you're using?

Mmmmm, I'm using github.dev (vs code inside of Codespaces) so I'm wondering if that means that this hasn't been fixed within the codespaces implementation side of things. I'm using the most current version of iPadOS, so 15.3. Thanks!

@anthonygualandri have you tried this today? We just released a new stable version of VS Code which I believe should have a fix for this. Ensure Codespaces is using version 1.64 of VS Code.

@TylerLeonhardt thanks for the reply! So it looks like the version used when I fire up the codespace is 1.64:
Version: 1.64.0
Commit: 5554b12acf27056905806867f251c859323ff7e9
Date: 2022-02-03T04:19:17.872Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.3 Safari/605.1.15
Any other things it could be?

Thanks for trying. It seems to be hit or miss because @rebornix and I can't repro... but someone else on our team has. @anthonygualandri can you try copy/paste in here:
https://microsoft.github.io/monaco-editor/
this will help us narrow down where the problem may be.

No problem glad to help! I just bought a brand new iPad thinking I was going to be able to use it as a laptop replacement as I do all def stuff in codespaces. So not having copy and paste definitely won’t work hahaha. I tried using that page you linked to and I can copy, cut and paste just fine with the on screen apple keyboard the vs code menu when long pressing the screen and the external keyboard. However, I was only able to under and redo with the external keyboard for some reason.

@TylerLeonhardt Just checking back to see if any updates on finding the sources of the issues with this. Thanks!

I tried copying and pasting again today this time I got a message from vs code in the browser saying that clipboard is being blocked by the browser with "Learn More" button that took me to the following url:
https://code.visualstudio.com/docs/remote/codespaces#_how-do-i-allow-vs-code-to-access-my-clipboard-for-reading
I couldn't find a way to get to this setting on the ipad os browsers though, either Safari or Chrome. Wondering if you all ran into this at all and know a way to enable, or if this is actually not the problem? Thanks!

Sorry for the delay. Spinning many plates 😅

I couldn't find a way to get to this setting on the ipad os browsers though

This dialog doesn't show up on iPad. The browser just doesn't do it, for some reason. It only seems to happen on Desktop Chrome and Chromium based browsers.
With that said..... let me summarize here so I can formulate what to do next:
Cut/Copy doesn't work for you at all if you use either an external keyboard or the on screen keyboard
You reproduce this in GitHub Codespaces
You are unable to repro this behavior in https://microsoft.github.io/monaco-editor/
Were you able to repro this using https://vscode.dev ?

No problem. Totally understand. Glad to hear you guys have a fix in mind that you can look to implement next week. So in terms of trying this in vscode.dev, I just tried it now and cut, copy and paste work with both direct iPad long pressing as well as external keyboard. Same as with the repo env link you sent me to test, I can undo and redo with the external keyboard, but the on screen keyboard does not do undo and redo. I see the back and forward arrows display as usable (unlike in the codespace.do env), but when I press them they don't work. Anyway, hopefully that helps further pin point things for you.
What are the differences between vscode.dev and codespaces.dev? Does vscode.dev keep all local package installation, etc, remote like codespaces.dev? With vscode.dev can you install extensions and debug locally like with codespaces.dev?
Thanks for all the help!

I would have expected that vscode.dev & codespaces would behave the same... but I guess not. @jkeech @joaomoreno any ideas why there might be a difference in behavior here?

@anthonygualandri, can you also try on github.dev using the same repository that you try on vscode.dev? There are three different websites that are similar but distinct. Knowing which one(s) are working will help narrow it down:

vscode.dev (the lightweight editor in the browser) - example: https://vscode.dev/github/microsoft/vscode
github.dev (the lightweight editor in the browser) - example: https://github.dev/microsoft/vscode
Codespaces (*.github.dev) - Create a new codespace from microsoft/vscode, it will give you some-random-name.github.dev

(1) and (2) are both completely client side in the browser. (3) is partially client side and partially running on the remote container. If it's working for you in (1), I'd also expect it to work in (2) since those are very similar to each other. If it doesn't work in (2), that would be interesting to know. Even for (3), it should be similar enough to (1) and (2) to not make a difference here, but I'm not as familiar with the implementation details between the pure client side version and the remote-attached version.

@jkeech Ok, so I tried things in the GitHub.dev env and it works, as expected there as with vscode.dev. I can copy, paste and cut with on screen keyboard and external. I can also undo and redo with the keyboard and with the fly out menu inside the code editor, but not with the on screen iPad keyboard. For the codespaces env, I wasn't sure how to create a new codespace from microsoft/vscode as you can only select a repo that's currently yours. I created a new one from an existing repo I have and the behavior there is the same as with my original codespace where I noticed the problem initially. No copy, paste, cut, redo, undo of any kind. I'm currently importing the microsoft/vscode repo into my account from GitHub, but it's taking forever to complete (probably because it's so huge!), but I expect the behavior to be consistent with the experiences till now. So think you know where to target for a fix with this?

so I tried things in the GitHub.dev env and it works, as expected there as with vscode.dev.

Thanks for trying that out! It looks like this issue is something that only happens when running VS Code in the web connected to a remote backend (like Codespaces). @TylerLeonhardt, is there something different about the way they keybindings work in a remote-attached scenario compared to a serverless/client-side scenario? Codespaces isn't initializing the VS Code workbench differently in the two flows, so I don't think this is something that the embedder is doing to interfere with the cut/copy/paste on iPad.

So I was able to repro this in Codespaces. Here’s something very interesting:
Codespaces:

a web connected remote backend that isn’t Codespaces:

The cursor appears to be different… however, tbh I don’t know what this means exactly… all I know is that with the circle cursor, copy works… without it, it doesn’t.
CC @alexdima curious if you have any ideas
Oh yeah, I did notice that copying in the search view or the find widget or the terminal… all of that worked. It was only the editor that had an issue. To attempt to help with this I added the commit above which forces cmd+c to go through our copy code (instead of relying on the browser to do the right thing).
We have a wild workaround in place only for Safari that allows behaviors like copying from the terminal to work correctly and @rebornix and I’s suspicion is that that is causing copy in the editor to fail sometimes.

@TylerLeonhardt How's the editor at  https://microsoft.github.io/monaco-editor/ behaving? (That would rule out the wild workaround).

@alexdima yeah that link works totally fine. Same for @anthonygualandri (at summarized here https://github.com/microsoft/vscode/issues/142057#issuecomment-1050409696 )

The cursor appears to be different… however, tbh I don’t know what this means exactly… all I know is that with the circle cursor, copy works… without it, it doesn’t.

I think the circle cursor indicates the iPad gesture way of selecting text using (ie using your fingures or a stylus vs using a keyboard). Apple has this hybrid mouse / gesture thing going which is mucking everything up for sure. When I use the "mouse" on the iPad connected keyboard and I right click it shows me the gestures looking copy, paste, etc buttons like as if I was on my phone or iPad without a keyboard connected and doing it with my finger. But if I highlight some text on the screen with the "mouse" using the keyboard and then cmd+c to copy it, I don't get that circle cursor thing or the bubble copy/paste buttons. It just copies the text. So basically, this is Apple forcing you to program things on your end to handle their frankenstein way of having given mouse/keyboard functionality to the iPad, instead of doing it the computer laptop way the rest of the software world is used to.
I'll check back Friday to test out using Insiders. Thanks @TylerLeonhardt for working on this!

@alexdima also to summarize, I was able to repro in Codespaces... I remember Kai had mentioned similar copy issues in vscode.dev, though I wasn't able to repro... and @rebornix wasn't able to repro in Codespaces OR vscode.dev.
My theory is that there could be a race condition between these handlers in our wild workaround and the browser's handler of Copy natively and that my change essentially forces cmd+c to always use our service... but that's just a hunch.

Not sure if you changed anything yet, but I'm still getting the same behavior.

@TylerLeonhardt Swinging back to this to see if there's any new updates since the last little burst back and forth. Hope all's well!

We might have repro steps for this on macos via https://github.com/microsoft/vscode/issues/148154

From investigating https://github.com/microsoft/vscode/issues/148154, I discovered that document.execCommand('cut') and document.execCommand('copy') are no-ops in Safari when the <textarea> is empty (i.e. nothing selected). I think that perhaps something similar might be going on in the iPad. I pushed  https://github.com/microsoft/vscode/commit/155389030c0741ef9dc76da7b03b67559d34ee74 to always have something selected in the <textarea> when there is a selection in the editor. I will optimistically close this issue too, because I think the change will help the iPad case too.

This seems to be working for me now in Codespaces when it used to not work. @anthonygualandri please let us know how it goes for you!


TSlint new rules

I was thinking of changing TSlint config from recommended to all and then just switch off rules we don't want. I will allow us to check rules faster (we don't need to go and look for rules we want in docs, just see it in action).
It will also help in some progression.
For now I would recommend adding:

"ban-types": [true, ["String"], ["Number"], ["Boolean"]] - it will force us to use string, number, boolean instead of these
"deprecation" - it finds deprecations in code Deprecated APIs should be avoided, and usage updated.
"no-duplicate-imports" - we can combine some imports into one Using a single import statement per module will make the code clearer because you can see everything being imported from that module on one line.
"no-empty" - empty classes, constructors Empty blocks are often indicators of missing code.
"no-empty-interface" - remove empty interfaces An empty interface is equivalent to its supertype (or {}).
"no-implicit-dependencies" - Disallows importing modules that are not listed as dependency in the project’s package.json Disallows importing transient dependencies and modules installed above your package’s root directory.
"no-non-null-assertion" https://palantir.github.io/tslint/rules/no-non-null-assertion/
"no-unnecessary-class" - Disallows classes that are not strictly necessary.
"no-unnecessary-qualifier" - Warns when a namespace qualifier (A.x) is unnecessary.
"prefer-template" - https://palantir.github.io/tslint/rules/prefer-template/
"strict-type-predicates" - https://palantir.github.io/tslint/rules/strict-type-predicates/ we can find some issues in stryker coz of that (we can do separate issue for that too)
"cyclomatic-complexity": [true, 30] - (there is no issue from that line, but it can prevent one in the future) - https://palantir.github.io/tslint/rules/cyclomatic-complexity/
"member-access": [true, "check-accessor", "check-parameter-property"] - set public, private of get, set too, it makes code cleaner i guess
https://palantir.github.io/tslint/rules/no-inferrable-types/ - remove obvious types
https://palantir.github.io/tslint/rules/no-unnecessary-type-assertion/
"trailing-comma": [true, {"multiline": "never", "singleline": "never"}] - remove trailing comma, more consistent code
https://palantir.github.io/tslint/rules/whitespace/ - more consistent, readable code
https://palantir.github.io/tslint/rules/newline-before-return/ - readability
https://palantir.github.io/tslint/rules/no-irregular-whitespace/
https://palantir.github.io/tslint/rules/no-redundant-jsdoc/ - Forbids JSDoc which duplicates TypeScript functionality.
https://palantir.github.io/tslint/rules/prefer-object-spread/ - Object spread allows for better type checking and inference.
https://palantir.github.io/tslint/rules/no-misused-new/

what we have now

order
https://palantir.github.io/tslint/rules/member-ordering/
import ordering
in-objects ordering
in-namespaces ordering
(couldn't find all of them)

Most of these rules will be super easy to implement since we might have no issue with that.
If you agree with sth like that I can make PR changing only TSlint config just from recommended to all (no changes on files)

I agree with most rules. I'm a big fan of the cyclomatic complexity rule and stuff like no-inferrable-types. Also, stuff that can be fixed automatically seems like a good idea as well.
The once I don't agree with:

https://palantir.github.io/tslint/rules/newline-before-return/ - I don't see the point here. Maybe we can create a separate issue for it and a separate PR so we can really see the changes.
https://palantir.github.io/tslint/rules/member-ordering/ - I actually agree with the statement on the rule description page:

A common opposite practice to member-ordering is to keep related groups of classes together.
I also feel like a lot of ordering feels like 'pampering'. A developer that chooses a specific order can have some great reasons why. Forcing an ordering now also results in huge file changes and hard to track history (not the greatest reason not to do something, but if the code actually remains the same, I don't file like we should force it).

@kmdrGroch can you find yourself in my reasoning?

There is nothing to complain, as you are member and owner of this package. I am just giving you some idea about it. I also prepared PR with "reverse implementation" of tslint, you might want to take a look. Actually, we don't really need member-ordering but I think newline-before-return makes a difference in some "crowded" places, so you can really see where you return some value. But it is personal preference etc.

There is nothing to complain, as you are member and owner of this package.

It's open source, so room for discussion 👍

I also prepared PR with "reverse implementation" of tslint,

Yeah, I've taken notice. You can use that branch to implement the rules that we agree on.

I think newline-before-return makes a difference in some "crowded" places, so you can really see where you return some value

After we've implemented the rules that we agree on, you can do a PR specifically for this one rule. That way I can see what the differences are.

We could decide which of these highlighted by me you would like to have and we can make some issues. It will be easier to fix I guess, as long as you don't want me to make 6000changes PR


OOM crashes in v0.20.1

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
Using 0.20.1 on Azure, all VMIs failed. The volumecontainerdisk container was hitting the OOM killer 100% of the time.
What you expected to happen:
VMIs to start!
How to reproduce it (as minimally and precisely as possible):
Take a vanilla ubuntu 18.04 image, and create a VMI with a minimal config. It will fail if you are running in Azure (AKS). Dockerfiles and VMI spec included below for reference.
Anything else we need to know?:

Problem is specific to Azure; not seen elsewhere. Not a clue why, frankly, though if we are just running out of memory there are various possibilities.

Problem is specific to v0.20.1; does not repro in v0.19.

Problem manifests with either scratch containers or those based on kubevirt/container-disk-v1alpha

If you create a VMI, then copy and hack the pod spec to remove the resource limits, then the OOM killer does not kick in; however the compute pod doesn't work either. This is not a supported thing to do but is suggestive that the underlying problem can be resolved with different limits for the volumecontainerimage pod.

Environment:

KubeVirt version (use virtctl version): v0.20.1
Kubernetes version (use kubectl version): 1.13.9
VM or VMI specifications: See below
Cloud provider or hardware configuration: Azure AKS, using nodes with 16/32 cores and 64/132GB RAM
OS (e.g. from /etc/os-release): Ubuntu 16.04 as installed by AKS
Kernel (e.g. uname -a): Don't know - getting access to the boxes is a pain, but could find out if it helps.
Install tools: AKS

Dockerfile (using completely vanilla downloaded ubuntu image)
FROM kubevirt/container-disk-v1alpha
# qcow2
ADD bionic-server-cloudimg-amd64.img /disk

Also tried this Dockerfile:
FROM scratch
# qcow2
ADD bionic-server-cloudimg-amd64.img /disk

VMI spec I used
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachineInstance
metadata:
  name: ubuntuvmi
  labels:
    billy: bob
spec:
  domain:
    resources:
      requests:
        memory: 1024M
        cpu: 2
    devices:
      disks:
      - name: containerdisk
        disk: {}
      - name: cloudinitdisk
        disk: {}
  volumes:
  - name: containerdisk
    containerDisk:
      image: metaswitchglobal.azurecr.io/plw/ubuntu:1804
  - name: cloudinitdisk
    cloudInitNoCloud:
      userData: |-
        #cloud-config
        password: ubuntu
        chpasswd: { expire: False }
        ssh_pwauth: True

I've discussed on slack with @slintes, @fabiand and @rmohr. Many thanks to all of you for your help.

Peter, thanks for reporting. Was there an outcome of the discussion which gives a hint why this could be happening?

Sorry for the delay, missed this question.
It looks like (slightly speculatively) the 20M resource limit in the volumecontainerdisk container is too low, and the OOM killer destroys the container. I don't have any idea why I always see the OOM killer and it isn't seen in other environments, but I am running in Azure.
If it's easy to get a build with a larger (or configurable) limit, it would be pretty simple for me to test a fix in that environment.

Hey. it would be helpful if you can try to set a higher request for the
container and see if it fixes your issue.
There were some changes in the containerDisk area which could explain this.

I thought the request was hard-coded in KubeVirt? I tried just manually changing the pod spec (removing limits from the containers), and that changed the behaviour, in that the VM didn't start any more but it didn't hit the OOM killer while copying disk contents.

yes, memory request/limit for the containerdisk container is hardcoded
We might have 2 issues here:

the values might be too low for new containerdisks (strange though that this is happening in @plwhite's env only so far)
the values are very likely too low for old containerdisks

the values are very likely too low for old containerdisks

oh, no, old containerdisks also use the new binary only

To progress this, is there some way I can change the hardcoded limit? Even if it's a bit of a hack for now, it might give some information about what is going on.

You could build KubeVirt on your own, you only need to have make and docker installed:

change limits at [0] and following lines
run DOCKER_PREFIX="index.docker.io/<yourDockerUsername>" DOCKER_TAG="<aDockerTag>" make bazel-push-images manifests

That will build and push new images (make sure you are logged in in your docker account), and create manifests in _out/manifests/release
[0] https://github.com/kubevirt/kubevirt/blob/master/pkg/container-disk/container-disk.go#L126

Thanks - let me have a shot at that. I should get to that later in the week.

OK, so I changed that file and set all of the memory limits in the container to 200M and the CPU limits to 100m just for good measure. Having done so, I rebuilt and redeployed and can now create VMs based on container images - I've tried at least a dozen including some multi-GB images.
I have no idea what the actual memory limit should be in practice; for the monster images I am often working with 200M is a rounding error. Incidentally, this may be a silly proposal (I haven't got the backgorund), but I would have expected the volumecontainerdisk image to run as an init container and then terminate after the copy releasing that memory, in which case having a slightly over-large limit would matter much less.

Thanks a lot for the valueable feedback!
I'm a bit busy myself this week, followed by 2 weeks vacation.
Maybe @rmohr can follow up on this next week, when he is back from his vacation, he is very familiar with this topic.

Sure - happy to help, especially given that this is after all a bug that only I have come across! Do let me know if there's anything else I can do.

@plwhite could you please retest with https://github.com/kubevirt/kubevirt/pull/2687 and close if no longer reproducible?

Looks like #2687 fixes this.

Great :) Thx for the feedback!

We saw this in 0.21.0. Was resolved after upgrading to 0.22.0.


Build for Windows with a Wine Docker image

This is actually more of a question than a issue. I'm using Docker to build a Electron app, one build for Windows, one for Linux.
However, this app is using native Node addons. I was wondering if I could build a native addon for Windows with node-gyp inside a Docker container using wine?

Node Version:  10.2.1 for Node and 5.6.0 for npm
Platform:  Docker using electronuserland/builder:wine image
Compiler:
Module:

Verbose output (from npm or node-gyp):

I think the answer is "we don't know", but if you work out, report back or write it up somewhere, I'm sure it'll be fascinating and helpful for someone out there. Best of luck.

@paul-roman I am looking at something similar. Were you able to get it working?

@paul-roman I am looking at something similar. Were you able to get it working?


before_record_request mutates request

I have run into the same problem as #356, but instead with the request. Using filters does not mutate the request, but using the before_record_request callback does modify the request.
I would provide a patch (as the fix is trivial), but I can't quite figure out how to test this using httplib (which is what the tests use). Unlike the requests package, I can't find in the httplib API where the request headers would be stored.

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale and we have a lot of old tickets that need to be groomed, I'm closing this for now to make it easier to see what is still relevant.
However if it is still needed, please feel free to re-open or create a new ticket.
Thanks! 🙏


Question about the pretrain model

Hi jingyuan, I would like to know the mask ratio of the pretrain model for CelebA. Have you used 40%-50%  to train the model? And are the results under different mask ratio reported in your paper tested using a single pretrain model, or  have  you trained several models for different mask ratios. Thx!

Hi jingyuan, I would like to know the mask ratio of the pretrain model for CelebA. Have you used 40%-50% to train the model? And are the results under different mask ratio reported in your paper tested using a single pretrain model, or have you trained several models for different mask ratios. Thx!

The results are from a single model trained with various mask ratios. The maximum mask ratio is ~60%.

Hi jingyuan, I would like to know the mask ratio of the pretrain model for CelebA. Have you used 40%-50% to train the model? And are the results under different mask ratio reported in your paper tested using a single pretrain model, or have you trained several models for different mask ratios. Thx!

You might check the mask generation process described in partial convolution's paper. We followed the configurations in that paper.


Rename Zap to Zappy

thank you!

Thanks for merging this @falexwolf! I should have mentioned that this relies on https://github.com/theislab/anndata/pull/71 :) So please take a look at that one too when you get a chance.


Failed to start language server even though it definitely exists

I have been having issues configuring kak-lsp to work with Lua. I downloaded sumneko's Lua LS and grabbed the binary from the vscode extension repo, and set up kak-lsp as so:
[language.lua]
filetypes = ["lua"]
roots = [".git/"]
command = "home/raiguard/.servers/sumneko-lua/bin/lua-language-server"
args = ["-E", "home/raiguard/.servers/sumneko-lua/main.lua"]

I enabled kak-lsp on filetype Lua in my kakrc:
hook global WinSetOption filetype=(rust|lua) %{
    echo -debug "Enabling LSP for filetype %opt{filetype}"
    lsp-enable-window

    # Other settings are below this point, such as auto_highlight_references and semantic tokens
}

However, when I open a Lua file, this error appears:

I tested the command in my shell manually, and it works perfectly:

Any idea what is going on?

command = "home/raiguard/.servers/sumneko-lua/bin/lua-language-server"

this should likely be command = "/home/raiguard/.servers/sumneko-lua/bin/lua-language-server"
No such file or directory is a pretty standard message in this case.

Jeez... I cannot believe that I didn't put the leading slash. I quadruple-checked those paths... Thanks!
The error no longer appears, but nothing else is happening. If I figure out why that is I'll close this issue. Otherwise, I'll let you know.
Thanks for the amazing plugin!

One problem is that lua-language-server version  1.17.1  (without setting args in kak-lsp.toml) sends "workspace": [], as part of initialization, which gives an error like
Mar 18 22:43:11.761 ERRO panic: panicked at 'Failed to parse response: Error("invalid length 0, expected struct WorkspaceServerCapabilities with 2 elements", line: 0, column: 0)', src/context.rs:151:64, module: kak_lsp:265

WorkspaceServerCapabilities corresponds to the "workspace" field in JSON. According to the lsp_types library, it should either be null, or have two elements.

Well, the original problem is solved, so I'll close this issue. I switched to actual Linux yesterday (I was using WSL before) and I'm having different issues with the sumneko server unrelated to kak-lsp. Thanks for you help!

@krobelus Are you certain that WorkspaceServerCapabilities requires both fields? I looked at the lsp spec and all properties in that table look like they're marked as optional:
/**
	 * Workspace specific server capabilities
	 */
	workspace?: {
		/**
		 * The server supports workspace folder.
		 *
		 * @since 3.6.0
		 */
		workspaceFolders?: WorkspaceFoldersServerCapabilities;

		/**
		 * The server is interested in file notifications/requests.
		 *
		 * @since 3.16.0
		 */
		fileOperations?: {
			/**
			 * The server is interested in receiving didCreateFiles
			 * notifications.
			 */
			didCreate?: FileOperationRegistrationOptions;

			/**
			 * The server is interested in receiving willCreateFiles requests.
			 */
			willCreate?: FileOperationRegistrationOptions;

			/**
			 * The server is interested in receiving didRenameFiles
			 * notifications.
			 */
			didRename?: FileOperationRegistrationOptions;

			/**
			 * The server is interested in receiving willRenameFiles requests.
			 */
			willRename?: FileOperationRegistrationOptions;

			/**
			 * The server is interested in receiving didDeleteFiles file
			 * notifications.
			 */
			didDelete?: FileOperationRegistrationOptions;

			/**
			 * The server is interested in receiving willDeleteFiles file
			 * requests.
			 */
			willDelete?: FileOperationRegistrationOptions;
		};
	};

Unless I'm misunderstanding what ?: means.

Yeah, it's optional

If "workspace" is null or missing (not sure which one), then it's considered absent.
otherwise "workspace" must to be a list of two elements

The empty list ([]) does not match 1., so it looks like a bug in the language server.

Oops, I deleted my reply just before you replied. :/
I realized that the LSP spec shows that it needs to be an object, and the server is returning an empty array. So, definitely a bug in the server.


Namespaces with use, Inheritance and autocompletion

When extending a class from a namespace class without full name (which is the whole point of namespaces), the resolution is not happening. Neither cmd+click on method works, nor is any auto-completion offered.
Example: (In single file using curly syntax for brevity)
<?php
namespace First {
	class Bar {
		public function foo($test) {
			echo $test;
		}
	}
}

namespace Test {

	use First;

	class Foo extends Bar {
		public function bar($test) {
			echo $test;
		}
	}
}

namespace {
	/** @var \Test\Foo $test */
	$test = new \Test\Foo;
	$test->foo();
}

?>

It works when I replaced class Foo extends Bar with class Foo extends \First\Bar so I'd assume use isn't implemented.

Your use declaration is incorrect. The last part of the use name must match the first part of the type reference. ie
use First\Bar and extends Bar or  use First and extends First\Bar
Executing your example code gives:
PHP Fatal error:  Class 'Test\Bar' not found in [PATH] on line 15


Added missing translation to tamil language

@prafuldivani we use Crowdin for managing the translations. Please add the translations here


Fix: From and Until Timestamps when OOO for One Day

Problem Statement

As of now when a user selects OOO from website-my, the timestamp is stored as the 00:00:00 UTC timestamp for the chosen date.
Problem arises when the user chooses to be on OOO for one day. Suppose a user chooses to be on OOO from 02/10/2023 till 02/10/2023, then both the from and until timestamps are chosen as the 00:00:00 UTC timestamps for both. In this case,<PHONE_NUMBER>000.
Hence, the from and until timestamps become equal resulting in a OOO for 0 ms. This would cause problems when updating the OOO dates in the user's discord nickname.
With this issue, the from and until timestamp for the day must be set to 00:00:00 UTC and 23:50:59 UTC respectively.

Refer to the screenshot higlighting the issue

Approach

First step, a solution design documentation must be submitted highlighting the proposed solution. To proceed with development, the design solution documentation must have at least 3 reviews and approvals.
Second step, TDD methodology must be used to fix the issue. The first PR submitted should contain the test cases, followed by another PR with the fix.
The fix PR should only be raised when the PR with test cases have been reviewed.

ETA Breakdown:
Design Doc: 1 day
Code Changes + Tests : 1 day
Review+Buffer: 3 day
Completion : 9th Oct 2023


bgImage No Longer Working with PhoneGap Build

Repoening issue #27
There is no background image being shown on either iOS or Android anymore. I will try upload a screenshot.
Even the controls are not visible until you click on the blank screen.

There are more details in issue #27

Please use the template for an issue

What is the version of the plugin in package.json?
This functionality works as expected in the latest version

also: post the code that's causing the issue


ci(actions): update renovatebot/github-action action to v40.2.3

This PR contains the following updates:

Package
Type
Update
Change

renovatebot/github-action
action
patch
v40.2.2 -> v40.2.3

Release Notes

renovatebot/github-action (renovatebot/github-action)
v40.2.3
Compare Source
Documentation

update references to ghcr.io/renovatebot/renovate to v37.431.4 (f771ec2)
update references to ghcr.io/renovatebot/renovate to v37.438.2 (f1b8354)
update references to renovatebot/github-action to v40.2.2 (02b9835)

Miscellaneous Chores

deps: update dependency @semantic-release/github to v10.0.7 (044641a)
deps: update dependency @semantic-release/github to v10.1.0 (503fd55)
deps: update dependency @types/node to v20.14.10 (0eef375)
deps: update dependency npm-run-all2 to v6.2.1 (1334247)
deps: update dependency npm-run-all2 to v6.2.2 (8a5d6f9)
deps: update dependency prettier to v3.3.3 (7e9c4ee)
deps: update dependency rimraf to v5.0.8 (a7a38a8)
deps: update dependency rimraf to v5.0.9 (d03e7a3)
deps: update pnpm to v9.5.0 (083af31)
update example files with newer options (#855) (db9fb1a)

Build System

deps: lock file maintenance (16855c5)

Continuous Integration

deps: update actions/setup-node action to v4.0.3 (29f9c5a)
deps: update renovate docker tag to v37.426.2 (2091eb8)
deps: update renovate docker tag to v37.426.4 (a2bbdde)
deps: update renovate docker tag to v37.427.0 (8a56556)
deps: update renovate docker tag to v37.428.2 (c912317)
deps: update renovate docker tag to v37.428.3 (680e80b)
deps: update renovate docker tag to v37.429.0 (2b8723e)
deps: update renovate docker tag to v37.429.1 (362fe74)
deps: update renovate docker tag to v37.431.0 (65f80c0)
deps: update renovate docker tag to v37.431.4 (c9bf0d3)
deps: update renovate docker tag to v37.431.7 (5a79cc4)
deps: update renovate docker tag to v37.432.0 (b7fe9a6)
deps: update renovate docker tag to v37.433.0 (a80f43d)
deps: update renovate docker tag to v37.433.2 (1f0eb2c)
deps: update renovate docker tag to v37.434.2 (d841653)
deps: update renovate docker tag to v37.437.3 (51174a8)
deps: update renovate docker tag to v37.438.2 (e3a014b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This issue has been resolved in version 1.4.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Rename package to avoid conflict with dependency

@bredamc this is a kind of steel thread to get the bare minimum working. I've pushed it to quay.io so that you can try it out with podman.
There's a sample data set that you can download and extract from here: https://www.dicomlibrary.com/?manage=02ef8f31ea86a45cfce6eb297c274598
Then you can use that as the input directory, and just create an empty output directory. Once you've got those, then you can run the following (modify <INPUT_DIR> and <OUTPUT_DIR> in the following to be the locations of those folders on your machine:
podman run --rm -v <INPUT_DIR>/series-000001:/incoming -v <OUTPUT_DIR>:/outgoing grdryn/pl-heudiconv pl-heudiconv /incoming /outgoing

Updated command that worked:
podman run --rm -v ./incoming/series-000001:/incoming:z -v ./outgoing:/outgoing:z quay.io/grdryn/pl-heudiconv pl-heudiconv /incoming /outgoing


Features/multistream

This code allows to import and fuse multiple streams

I don't use Matlab very much these days so I'm afraid I can't provide a strong endorsement.
I have a few comments but I might have misunderstood the code so I could be incorrect.

I guess the user chooses which time base to interpolate on in stream, then all other args.fuse_stream_names are interpolated on that time base. Is that correct? What happens if stream's time base extends well beyond the fused streams? Are they extrapolated out? This can be dangerous.
Is there any handling of data types? What if someone is fusing a float64 stream onto an int stream?

I guess the user chooses which time base to interpolate on in stream, then all other args.fuse_stream_names are interpolated on that time base. Is that correct? What happens if stream's time base extends well beyond the fused streams? Are they extrapolated out? This can be dangerous.

Yes, the user select a "primary" stream on which others are interpolated.

Is there any handling of data types? What if someone is fusing a float64 stream onto an int stream?

There is no handling of data types. That's a good point.

Merging for now. We will debug as needed.


Sanbox environment with specific localization

Hello,
I have tried to create a Sandbox environment using this link: https://aka.ms/getsandboxforbusinesscentral
I always end up with a Cronus USA company. I suppose it means that the database is also that of the US localization.
Is there a way to create a Sandbox with a different localization?
Salut!
Laura Nicolàs

This repo is for al extensibility issues only. Transferring issue.


[3pt]  - Add tests for comments counter - Student B

Make sure that function for the comments counter is covered with unit tests using Jest.

Here is the pull request seeking to address the issue.


fix gh-1672, support @RequestParam without a value

see #1672

Codecov Report

Merging #1678 into master will decrease coverage by -0.03%.

@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
- Coverage   74.46%   74.44%   -0.03%
==========================================
  Files         195      195
  Lines        6051     6050       -1
  Branches      760      759       -1
==========================================
- Hits         4506     4504       -2
  Misses       1215     1215
- Partials      330      331       +1

Impacted Files
Coverage Δ

...cloud/netflix/feign/support/SpringMvcContract.java
87.41% <ø> (-0.79%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a3157...c8fded8. Read the comment docs.

I think it's ok that the coverage was decreased due to the offset of the removed lines.


Provide all retrieved documents as source in the citation section

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Ask a question/Chat -> Ask question -> view citations

Any log messages given by the failure

Expected/desired behavior

I understand that the code for the citations is in AnswerParser.tsx (?). How can I change the code - or any other code If my assumption is wrong - so that all retrieved documents are provided in the citation section?
Also it would be great to be able to split the citation-section into 2 parts: one as is (sources that contain facts used in the answer) & a second part like "related topics/also see" (the rest of the retrieved documents)

OS and Version?

Windows 10

azd version?

1.4.2

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Update:
I successfully changed the code in AnswerParser.tsx by reusing the same logic done for the "fragments" for a new variable "otherFragments". The whole new code looks like this:
`import { renderToStaticMarkup } from "react-dom/server";
import { getCitationFilePath } from "../../api";
type HtmlParsedAnswer = {
answerHtml: string;
citations: string[];
otherSources: string[];
};
export function parseAnswerToHtml(answer: string, isStreaming: boolean, onCitationClicked: (citationFilePath: string) => void): HtmlParsedAnswer {
const citations: string[] = [];
const otherSources: string[] = [];
// trim any whitespace from the end of the answer after removing follow-up questions
let parsedAnswer = answer.trim();

// Omit a citation that is still being typed during streaming
if (isStreaming) {
    let lastIndex = parsedAnswer.length;
    for (let i = parsedAnswer.length - 1; i >= 0; i--) {
        if (parsedAnswer[i] === "]") {
            break;
        } else if (parsedAnswer[i] === "[") {
            lastIndex = i;
            break;
        }
    }
    const truncatedAnswer = parsedAnswer.substring(0, lastIndex);
    parsedAnswer = truncatedAnswer;
}

const parts = parsedAnswer.split(/\[([^\]]+)\]/g);
const otherParts = parsedAnswer.split(/\|([^\|]+)\|/g);

const fragments: string[] = parts.map((part, index) => {
    if (index % 2 === 0) {
        return part;
    } else {
        let citationIndex: number;
        if (citations.indexOf(part) !== -1) {
            citationIndex = citations.indexOf(part) + 1;
        } else {
            citations.push(part);
            citationIndex = citations.length;
        }

        const path = getCitationFilePath(part);

        return renderToStaticMarkup(
             onCitationClicked(path)}>
                {citationIndex}

        );
    }
});

const otherFragments: string[] = otherParts.map((part, index) => {
    if (index % 2 === 0) {
        return part;
    } else {
        let citationIndex: number;
        if (otherSources.indexOf(part) !== -1) {
            citationIndex = otherSources.indexOf(part) + 1;
        } else {
            otherSources.push(part);
            citationIndex = otherSources.length;
        }

        const path = getCitationFilePath(part);

        return renderToStaticMarkup(
             onCitationClicked(path)}>
                {citationIndex}

        );
    }
});

const allFragments: string[] = fragments.concat(otherFragments);

return {
    answerHtml: allFragments.join(""),
    citations,
    otherSources
};

}
`
It can be rendered in the Answer.tsx accordingly:
{!!parsedAnswer.otherSources.length && (                 <Stack.Item>                     <Stack horizontal wrap tokens={{ childrenGap: 5 }}>                         Other Sources:                         {parsedAnswer.otherSources.map((x, i) => {                             const path = getCitationFilePath(x);                             return (                                  onCitationClicked(path)}>                                     {${++i}. ${x}}                                                              );                         })}                     </Stack>                 </Stack.Item>             )}
I changed the sample conversation in retrievethenread.py to this (bold text is new):
` # shots/sample conversation
question = """
'What is the deductible for the employee plan for a visit to Overlake in Bellevue?'
Sources:
info1.txt: deductibles depend on whether you are in-network or out-of-network. In-network deductibles are $500 for employee and $1000 for family. Out-of-network deductibles are $1000 for employee and $2000 for family.
info2.pdf: Overlake is in-network for the employee plan.
info3.pdf: Overlake is the name of the area that includes a park and ride near Bellevue.
info4.pdf: In-network institutions include Overlake, Swedish and others in the region
"""
answer = "In-network deductibles are $500 for employee and $1000 for family [info1.txt] and Overlake is in-network for the employee plan [info2.pdf][info4.pdf]. Other sources: |info3.pdf|"`
So basically just a rework of existing code. It does work sometimes. The issue now is, that I didn't find a prompt context, that is stable enough to reliably return the "other sources". I added something like this: "For those sources that you did not include, because no fact in your response was based on that source: Include the source name - ONLY the source name - after your response under "Other sources:"".
If anyone is interested in this feature, I am happy about your opinion on this approach and/or better working prompt contexts to ensure a stable behaviour.


Implement test time augmentations to avoid high frequency fluctuations

With a variety of models, we see that virtually stained structures show high-frequency fluctuations over time. This may be due to the sensitivity of ConvNets to small changes in local texture and orientation of edges. One way to average over these effects is to do test time augmentation. Let's experiment with one of our trained models and compare the temporal consistency of predictions with and without test-time augmentations.
Relevant paper: https://www.nature.com/articles/s41598-020-61808-3

Closed by #91.


Not necessarily the DoIT Help Desk.

Reduces need to fork-and-customize HTML templates when configuring MISC_URLS.helpdeskURL to point elsewhere than DoIT Help Desk.

Coverage remained the same at 39.199% when pulling 4fe9e7ed42ae14e71ccba3c663b296e0dfc9cb9a on not-necessarily-doit into 26c7b27e06266b9622f01168d1779e1c39e489a2 on master.


Maximum count of a character in a string.

The code will find the maximum number of times a character repeats. It will print the maximum occurred character.
I will be implementing this issue in CPP.
Kindly assign me this issue @tarun26091999.

The code will find the maximum number of times a character repeats. It will print the maximum occurred character.
I will be implementing this issue in CPP.
Can I work on this issue?

Hello @Roshni1809 ma'am, Could you please assign this issue to me under GSSOC'21

Hello ma'am,I am a participant at GSSoC'21, May I take this work? I will code it in C++

Hello,
I would like to contribute to this issue in java as a GSSoC 2021 participant
kindly assign me the issue

I am gssoc'21 participant. I would like to implement it in python

Can i work on this issue in Java.PLease assign it to me @OjusWiZard

@OjusWiZard done. please review it and merge it


Migrations: CHECK enum columns

hi @AndriySvyryd, Could you tell me which file i can add this CHECK?

This is about adding a CHECK constraint to enum columns e.g.:
mycol VARCHAR(10) NOT NULL CHECK (mycol IN('Useful', 'Useless', 'Unknown'))

The easiest way of doing this is by adding a SqlServer convention (IModelFinalizedConvention) that calls AddCheckConstraint for all enum properties.

Hi @AndriySvyryd
Following test is my expectation, Is that correct?
` [ConditionalFact]
public void Can_create_check_constraint_for_enum()
{
var modelBuilder = CreateConventionModelBuilder();
var entityType = modelBuilder.Entity().Metadata;
        modelBuilder
            .Entity<Customer>()
            .HasCheckConstraint("CK_Customer_EnumValue", "CHECK (mycol IN('Sun', 'Mon', 'Tue'))");

        var checkConstraint = entityType.FindCheckConstraint("CK_Customer_EnumValue");

        Assert.NotNull(checkConstraint);
        Assert.Equal(entityType, checkConstraint.EntityType);
        Assert.Equal("CK_Customer_EnumValue", checkConstraint.Name);
        Assert.Equal("CHECK (EnumValue IN('Sun', 'Mon', 'Tue'))", checkConstraint.Sql);
    }`

@SARAVANA1501 Not quite, this should happen without needing to call WithEnumConstraint()

@AndriySvyryd ,
SqlServerEnumConstraintConvention
Please review the convention, and guide me to register it with other conventions,
Thanks.

You are heading in the right direction.

Call entityType.GetDeclaredProperties() instead of entityType.GetProperties() to avoid going over the same properties.
Don't call property.SetIsNullable(false)
The convention can be added in SqlServerConventionSetBuilder:

    ConventionSet.AddBefore(
        conventionSet.ModelFinalizedConventions,
        new SqlServerEnumConvention(),
        typeof(ValidatingConvention));

Add tests to EFCore.SqlServer.Tests

I'll give further feedback on the PR

Fixed in e17584c457a49c4dcd90fd5cf47cd3a61ae4db53


N orient 3

Hi @agramfort
I have imported the bcs function from mne to test n_orient = 3 in a correct way as we discussed
I think we need to go through the code to see whether I did it in a correct way?

Hi @agramfort  The code currently passes all the tests  except iterative_sqrt
It should be something related to the initialization of the alpha since previously it worked well with the following manual tuning of alpha:  https://github.com/braindatalab/BSI-Zoo/blob/2eff796807882a3aa3fc7aa70940f296d8363f22/bsi_zoo/estimators.py#L229
alpha_max = abs(L.T.dot(y)).max() / len(L)
alpha = alpha * alpha_max

(I have commented out these two lines)
But right now we have this in the bcd code
alpha_lc = alpha / lipschitz_constant
which I think change the scale of the alpha a little bit. would be appreciate if you could take a look at this. (currently all the test are passed since I commented out iterative_sqrt function in the test)

@AliHashemi-ai can you see why CIs are red here? thanks

@AliHashemi-ai can you see why CIs are red here? thanks

I have checked that this is the error:

do you have any idea how to resolve it @agramfort ? it seems it refers to an whitespace around an operator

@AliHashemi-ai run flake8 locally on your code to replicate the problem and fix it

@AliHashemi-ai run flake8 locally on your code to replicate the problem and fix it

Thanks @agramfort . Done. Now the flake8 error is fixed. Looking forward to your comment on how to tune alpha for iterative_sqrt function. Please look at my explanations above.

@AliHashemi-ai it should be ok now. Basically with sqrt you have weights which are zeros and it breaks the solvers. So the fix is to screen dipoles with zero weights and not to consider them in the inner loop

feel free to merge it with master if you agree with the this version

we did it @AliHashemi-ai 🎉 👏
let's move on to the next item of our todo list now


How to modify hud size？

Please don't open issue for questions. Use Stack Overflow and at least read the Wiki


balena-yocto-scripts: Update to v1.14.9

Update balena-yocto-scripts from 1.14.7 to 1.14.9
Changelog-entry: Update balena-yocto-scripts from v1.14.7 to v1.14.9
Signed-off-by: Alex Gonzalez<EMAIL_ADDRESS>

@balena-ci retest

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins retest this please

Retrying rpi3 don't issue a new retest: https://11a1d0258e8782b188c3598b57c155c6.balena-devices.com/job/leviathan-raspberrypi3/434/console


Smart quotes and em dash

Thanks for this nice pdf library. I'm trying to write some pretty standard text to pdf, but I'm running into issues with the limited UTF8 support. What is required to add support for a few more characters?
Specifically, I'd like smart quotes and em dash support.

Hey. Adding support for those shouldn't be too bad. Unfortunately PDF text is not encoded as UTF-8 if you use the standard fonts, it has its own encoding. If you look in Appendix D of the spec (https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/pdf_reference_archives/PDFReference.pdf) you can see what characters there are, and what their encoding is. I see that emdash & left/right quotes are in there.
I've had a go at adding the support - can you check out https://github.com/AndreRenaud/PDFGen/tree/smart-quotes and tell me if it fixes things? Let me know if there are other characters, or feel free to add them yourself & send it through. You can see the change that I made there to the switch statement to add them.


Fix TestEKSSuite/Test00UpAndRunning/agent_pods_are_ready_and_not_restarting flaky new-e2e test

What does this PR do?
Increase the timeout of the TestEKSSuite/Test00UpAndRunning/agent_pods_are_ready_and_not_restarting new e2e test.
Motivation
Make it less flaky because it failed a few times recently.
Additional Notes
The CI complains that the Windows agent pod isn’t ready:
=== FAIL: tests/containers TestEKSSuite/Test00UpAndRunning/agent_pods_are_ready_and_not_restarting (300.00s)
    k8s_test.go:115:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:181
        	            				/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.21.8.linux-amd64/src/runtime/asm_amd64.s:1650
        	Error:      	Should be true
        	Messages:   	Container agent of pod dda-windows-datadog-rv45w isn’t ready
    k8s_test.go:115:
        	Error Trace:	/go/src/github.com/DataDog/datadog-agent/test/new-e2e/tests/containers/k8s_test.go:115
        	            				/go/pkg/mod/github.com/stretchr/testify@v1.9.0/suite/suite.go:115
        	Error:      	Condition never satisfied
        	Test:       	TestEKSSuite/Test00UpAndRunning/agent_pods_are_ready_and_not_restarting
        	Messages:   	Not all agents eventually became ready in time.
        --- FAIL: TestEKSSuite/Test00UpAndRunning/agent_pods_are_ready_and_not_restarting (300.00s)

Yet, when showing the state of the cluster, the same CI logs show that the Windows agent pod is up and running and hasn’t restarted:
        NAMESPACE                       NAME                                                   READY   STATUS    RESTARTS   AGE   IP            NODE                          NOMINATED NODE   READINESS GATES
        datadog                         pod/dda-windows-datadog-rv45w                          3/3     Running   0          16m   <IP_ADDRESS>   ip-10-1-48-172.ec2.internal   <none>           <none>

Also, we can notice that even when the TestEKSSuite/Test00UpAndRunning/agent_pods_are_ready_and_not_restarting passes, it’s sometimes close to the current timeout:

And indeed, the data collected during the tests are showing that the Windows agent pods takes several more minutes to start than the Linux ones:

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Bump deps & update CHANGELOG

Overview

Do the thing
Checklist

[ ] tests/ added or updated
[ ] CHANGELOG.md's Unreleased section is updated
[ ] Documentation is updated

Coverage remained the same at 90.354% when pulling 930c215942c4cfd04bd392fc3b4bc7cb0a90f6ee on bump-everything into ca00e6b8e0b722759f0af687c9df6a31127fd879 on develop.


Prefetch immediately

In react-query, you can create and call a prefetch method without using a hook or any other context. I understand that Redux requires dispatching the event as it interacts with the Redux store, but I have the need to just call a prefetch method immediately without having to use the hook and then calling the function. The "dispatch" verbose solution seems like it might work, but would be a bit cumbersome to connect to my components each time I just want to prefetch right away.

Yeah, but also that prefetch in react-query has to be called somwhere, so you're back to calling it in a useEffect, right?
So in react-query, you would have to do
useEffect(() => {
  queryCache.prefetchQuery('user/5', () => fetch('/user/5'))
}

So you could do it multiple ways:
const prefetchUser = usePrefetch('getUser');
useEffect(() => { prefetchUser(5) })

const dispatch = useDispatch();
useEffect(() => { dispatch(api.internalActions.prefetchThunk('getUser', 5)) })

or, just before even rendering react
store.dispatch(api.internalActions.prefetchThunk('getUser', 5))

Honestly, I don't really see how this is so much more cumbersome?
But of course you could abstract that once:
const usePrefetchImmediately = (endpoint, arg) => {
  const dispatch = useDispatch();
  useEffect(() => { dispatch(api.internalActions.prefetchThunk(endpoint, arg)) })
}

and then just do
usePrefetchImmediately('user', 5)

in your components

That is exactly the solution I have done now, however the react-query solution is just a normal function actually, no hooks. I can use them anywhere in my application, without having to follow the rules of hooks. I am working in a older project where I am using RTK, and started to use react-query as well.
I am just trying to see if everything I am doing in react-query can translate over to RTK query.
I have made a similar function to your usePrefetchImmediately,( with the same name haha), but I am using usePrefetch inside it. Is there a way in typescript to get the union of string literals that represent your endpoints to pass into usePrefetch?

@cole-robertson Here is my go at typing this... It's possible Lenz might chime in here though with something better.
type EndpointNames = keyof typeof api.endpoints;

export function usePrefetchImmediately<T extends EndpointNames>(
  endpoint: T,
  arg: typeof api.endpoints[T] extends ApiEndpointQuery<infer Def, any> ? Parameters<Def['query']>[0] : any,
  options: PrefetchOptions = {}
) {
  const dispatch = useDispatch();
  useEffect(() => {
    dispatch(api.internalActions.prefetchThunk(endpoint, arg, options));
  }, []);
}

Rereading that: it could be written a little simpler, using the initiate method as source for the second argument:

type EndpointNames = keyof typeof api.endpoints;

export function usePrefetchImmediately<T extends EndpointNames>(
  endpoint: T,
  arg: Parameters<typeof api.endpoints[T]['initiate']>[0],
  options: PrefetchOptions = {}
) {
  const dispatch = useDispatch();
  useEffect(() => {
    dispatch(api.internalActions.prefetchThunk(endpoint, arg, options));
  }, []);
}

This should now also be covered by the useQuerySubscription hook. See the release notes for 0.2.0: https://github.com/rtk-incubator/rtk-query/releases


Parallel and Segmented Downloads No Longer Working

I recently updated to the newest build. Since then parallel and segmented downloads are no longer working. When using pget-to-local the terminal screen shows the following:

It appears that it only uses one connection now.

It has always been like this for pget-to-local.
1 file is transferred using n amount of parts. There are no parallel transfers with a pget transfer. Only a mirror transfer has parallel and pget.
This can also be demonstrated by opening the .lftp.lftp-pget-status to see the number of parts defined.
For example, when using the defaults.
size=5368709120
0.pos=62750720
0.limit=1073741824
1.pos=1096941568
1.limit=2147483648
2.pos=2173730816
2.limit=3221225472
3.pos=3251339264
3.limit=4294967296
4.pos=4324589568
4.limit=5368709120

I am not sure what the problem is here since what you are claiming is a bug, is actually how it has always behaved for this particular custom command.

Please look here https://lftp.yar.ru/lftp-man.html
Search for -P (case sensitive) or --parallel and you will see this is not a option for the pget command.
Please also check your task manager when using the pget comamnd to see there will a a number of ssh/cygwin task equal to the number of parts selected.

Sorry for the confusion and lack of detail in my post. When using the pget command, it is no longer breaking the download into segments. In task manager there is only one instance of ssh/cygwin running. It is also no longer showing the status of the download with the "dots" and "circles" like before either.
When using the mirror command, it is no longer running parallel downloads or segmenting the files.

Try setting the override settings again. I have tested it and cant find any issues.

Thank you. That worked. It is now behaving normally again.

actually, I think I see the problem. i'll fix it now

Ok, so there was a silly bug created by myself. I didn't notice it because of the override worked.
The check to make decided if to use the lftp conf was checking the wrong filename. That is fixed now so it shoudl work as expected with this fix https://github.com/userdocs/LFTP4WIN-CORE/commit/c593c182162f825f329bdf7b04f9b96f0436c03c
Thanks for letting me know.


Starboard is becoming trivy-operator

I am posting this here if anyone has not seen the announcement yet:
https://github.com/aquasecurity/starboard/discussions/1173

.


Add typescript support.

This project is great! Will you have official typescript support?

I'd second this, I'm in the process of deciding whether to use this or ant.d atm

Same, I'd love to use this with Typescript

I love shard-react. The design is beautiful and elegant. Can you guys please add Typescript support

+1

@design-revision Maybe we can think about refactor by typescript or use ts declaration files?

I have added a PR with type declarations.
They arent perfect, but its a good starting point.
See #31

+1

@BendaCoding are the types committed and available through npm?

+1

I would also appreciate the typescript support.

Typescript support please!

I also please very much

++

++++

+1 This is basically a requirement of all modern UI frameworks at this point @design-revision

+1 This is basically a requirement of all modern UI frameworks at this point @design-revision

+1 This is great project! I would appreciate typescript support. Then more better.

I have found types filetypes/shards-react.d.ts in PR #31.
It seems, it have not merged yet, so I extracted type declarations. (and I modified it a little.
I will share this one for all, And very respect for @BendaCoding !
shards-react.d.ts.txt


Rewrite commitlint configuration to JS

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (197ec5e) 100.00% compared to head (66a2270) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines           58        58
=========================================
  Hits            58        58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Maintenance: Release 1.16

Summary
Release 1.16

Logging 1.6.2

Why is this needed?
Update Logging to 1.6.2

#656
#670

Which area does this relate to?
No response
Solution
No response
Acknowledgment

[x] This request meets Powertools for AWS Lambda (.NET) Tenets

[ ] update examples


JavaScript heap out of memory

I'm using an AWS r3.2xlarge EC2 instance.  After about 30 minutes of hanging at "Fetching all objects with files..." I'm getting the error below.  I think it's failing whilst building the checks array of objects with files.  Estimated around 2M files...
? About to start the file transfer. Does the above look correct? Yes
Initializing transfer configuration...
Connecting to MongoDB
Successfully connected to MongoDB
Initializing s3 adapter
Fetching schema...
Fetching all objects with files...
<--- Last few GCs --->
1504270 ms: Mark-sweep 1219.9 (1431.9) -> 1213.7 (1432.9) MB, 1594.8 / 0.0 ms [allocation failure] [GC in old space requested].
1505925 ms: Mark-sweep 1213.7 (1432.9) -> 1213.3 (1434.9) MB, 1654.6 / 0.0 ms [allocation failure] [GC in old space requested].
1507700 ms: Mark-sweep 1213.3 (1434.9) -> 1221.5 (1403.9) MB, 1775.3 / 0.0 ms [last resort gc].
1509375 ms: Mark-sweep 1221.5 (1403.9) -> 1230.3 (1403.9) MB, 1674.4 / 0.0 ms [last resort gc].
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 0x603ce8cfb51
1: /* anonymous */ [/home/ec2-user/parse-files-utils/lib/index.js:80] [pc=0x3e9fb4794436] (this=0x334f67723949 <a ParsePromise with map 0x2c3d5040ed1>,r=0x32104f80c0d1 <JS Array[1000]>)
2: wrappedResolvedCallback [/home/ec2-user/parse-files-utils/node_modules/parse/lib/node/ParsePromise.js:153] [pc=0x3e9fb474cbb8] (this=0x334f67723949 <a ParsePromise with map 0x2c3d5040ed1>)
3: argum...
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
1: node::Abort() [node]
2: 0x109624c [node]
3: v8::Utils::ReportApiFailure(char const*, char const*) [node]
4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
6: v8::internal::Factory::NewJSArrayStorage(v8::internal::Handlev8::internal::JSArray, int, int, v8::internal::ArrayStorageAllocationMode) [node]
7: v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
8: v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int) [node]
9: 0x9cf139 [node]
10: 0x9f07e8 [node]
11: 0x9f2946 [node]
12: 0x3e9fb40092a7
Aborted
I've tried $npm start config.js --  --max_old_space_size=49152
Any ideas on other things to try?

I have 2 suggestions for you
First you can add swap file to increase the capacity of memory
Second start biggest ec2 instance after your work finished you can terminate it

No Matter which size instance I use it fails at the same place even using   --max_old_space_size=4096.
It's failing inside getAllObjects when the array r hits 513785.
As it happens in this collection i have 700k documents so if i can cap it at 500k and then run it again but changing the sort by CreatedAt date descending and using less than it might work.
something like this...
function getAllObjects(baseQuery)  {

  var allObjects = [];
  var next = function() {
    if (allObjects.length) {

      baseQuery.lessThan('createdAt', allObjects[allObjects.length-1].createdAt); // <-- changed this line
    }
    return baseQuery.find({useMasterKey: true}).then(function(r){
      allObjects = allObjects.concat(r);
      if (r.length == 0 || r.length > 500000) {   // <-- changed this to stop after 500k objects
        return Promise.resolve(allObjects);
      } else {
        return next();
      }
    });
  }
  return next();
}

function getObjectsWithFilesFromSchema(schema) {
  var query = new Parse.Query(schema.className);
  query.select(schema.fields.concat('createdAt'));
  query.descending('createdAt');  // <-- I've changed this to descending
  query.limit(10000); // < --  I've increased this
  var checks = schema.fields.map(function(field) {
      return new Parse.Query(schema.className).exists(field);
  });
  query._orQuery(checks);

  return getAllObjects(query).then(function(results) {
    return results.reduce(function(current, result){
      return current.concat(
        schema.fields.map(function(field){
          var fName = result.get(field) ? result.get(field).name() : 'DELETE';
          var fUrl = result.get(field) ? result.get(field).url() : 'DELETE';
          return {
            className: schema.className,
            objectId: result.id,
            fieldName: field,
            fileName: fName,
            url: fUrl
          }
        })
      );
    }, []);
  });
}

Anyone else had similar issues with this script?

@BarryWood34 yes, other people are definitely having this issue.  take a look at https://github.com/parse-server-modules/parse-files-utils/issues/17#issuecomment-269552573
for a proposed solution.  if that works for you, then we should get that change in.  please let me know if it works and if you're willing, submit a pull request with the change (if not, just let me know and I'll make the change)

@acinader ok, it turns out I was way overcomplicating it - can't believe I didn't spot it sooner...
All I actually needed to do is add some additional lessThan,greaterThan dates below to break it down into smaller chunks and run several times.  No need to amend the code that's there, except perhaps to add a comment for those with the same problem with large collections...
...
function getObjectsWithFilesFromSchema(schema) {
  var query = new Parse.Query(schema.className);
  query.select(schema.fields.concat('createdAt'));
  //  *** OPTIONAL - additional constraints if working with very large collections ***
  // query.greaterThan('createdAt','2011-04-11T00:00:00.0001Z');  // <-- optional
  // query.lessThan('createdAt','2012-04-11T00:00:00.0001Z');   // <-- optional
  query.ascending('createdAt');
  query.limit(1000);
  var checks = schema.fields.map(function(field) {
      return new Parse.Query(schema.className).exists(field);
  });

It might help others.


Feature request: disable_max_size

The disable_max_lines option is useful for disabling Aerial for too long files. However, when opening a large, oftentimes computergenerated, json without whitespace the file is only one line even though it is very large.
It would be useful to alternatively disable Aerial if the file is larger than n bytes

Added!


Demo videos

Suggested by @napvasconcelos: one or two short (1-2 min) videos showing

the main capabilities of the manual sorting GUI
a quick "getting started"  video with the main instructions to install and run the software on example data

cc @nsteinme @nippoo

That's a great idea; I think it would probably help a lot. I could work on
this with @nippoo when I'm back if it isn't done by then.
On Mon, Jul 13, 2015 at 4:14 AM, Cyrille Rossant<EMAIL_ADDRESS>wrote:

Suggested by @napvasconcelos https://github.com/napvasconcelos: one or
two short (1-2 min) videos showing

the main capabilities of the manual sorting GUI
a quick "getting started" video with the main instructions to
install and run the software on example data

cc @nsteinme https://github.com/nsteinme @nippoo
https://github.com/nippoo
—
Reply to this email directly or view it on GitHub
https://github.com/kwikteam/phy/issues/532.

So where can we see the demo video?

They haven't been done yet as far as I know