About the support edition of "Attack surface reduction"

[フィードバックをこちらに入力してください]
Although it is written that "Attack surface reduction" can also be used with a "Pro" license,
In the case of "E3 License", it is written that it can be operated using "Event Viewer".
Isn't it correct for "Pro and E3 License"?
If not, please remove the "Pro" notation from support.
Attack surface reduction features across Windows versions
You can set attack surface reduction rules for devices running any of the following editions and versions of Windows:
Windows 10 Pro, version 1709 or later
Windows 10 Enterprise, version 1709 or later
Windows Server, version 1803 (Semi-Annual Channel) or later
Windows Server 2019
To use the entire feature-set of attack surface reduction rules, you need a Windows 10 Enterprise license. With a Windows E5 license, you get advanced management capabilities including monitoring, analytics, and workflows available in Defender for Endpoint, as well as reporting and configuration capabilities in the Microsoft 365 security center. These advanced capabilities aren't available with an E3 license, but you can still use Event Viewer to review attack surface reduction rule events.
https://docs.microsoft.com/ja-jp/windows/security/threat-protection/microsoft-defender-atp/attack-surface-reduction

ドキュメントの詳細
⚠ このセクションを編集しないでください。 docs.microsoft.com で必須です ➟ GitHub の問題のリンク。

ID: 5d747289-63b2-f71a-b40c-31b52982215c
Version Independent ID: b52f6593-03f2-aa57-ec0e-eaef560dcaf0
Content: 攻撃表面の縮小ルールを使用してマルウェアの感染を防止する - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/attack-surface-reduction.md
Product: w10
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

Hello @hidemaruki ,
It works following way:

Windows 10 pro and Windows Server do not support entire feature set of ASR (Source)
Windows 10 Enterprise and Windows 10 Enterprise E3 support all features, but doesn't support advanced management capabilities
Windows 10 Enterprise E5 supports everything

The paragraph you are talking about, is related to the statements 2 and 3 above, it is not related to Windows 10 pro.
Dear @denisebmsft , could you please confirm?
Thank you

Hello @hidemaruki ,
It works following way:

Windows 10 pro and Windows Server do not support entire feature set of ASR (Source)
Windows 10 Enterprise and Windows 10 Enterprise E3 support all features, but doesn't support advanced management capabilities
Windows 10 Enterprise E5 supports everything

The paragraph you are talking about, is related to the statements 2 and 3 above, it is not related to Windows 10 pro.
Dear @denisebmsft , could you please confirm?
Thank you

Hello, @MaratMussabekov ,
Thank you for reply.
You mean "Attack Surface Reduction" need "Windows 10 Enterprise" lisence only.
So I think I can apply Attack surface reduction to "Windows 10 Pro" without upgrading actual OS to "Windows 10 Enterprise E3 or E5" if only I have "Windows 10 Enterprise E3 or E5" license.
I think I can apply Attack surface reduction to "Windows Server 2019" if only I have "Windows 10 Enterprise E3 or E5" license, also.
Dose it makes sense?
If my understanding is correct, I completely agree with your text.

Hello, @MaratMussabekov ,
Thank you for reply.
You mean "Attack Surface Reduction" need "Windows 10 Enterprise" lisence only.
So I think I can apply Attack surface reduction to "Windows 10 Pro" without upgrading actual OS to "Windows 10 Enterprise E3 or E5" if only I have "Windows 10 Enterprise E3 or E5" license.
I think I can apply Attack surface reduction to "Windows Server 2019" if only I have "Windows 10 Enterprise E3 or E5" license, also.
Dose it makes sense?
If my understanding is correct, I completely agree with your text.


Add RSS generation

The API should have a route /rss which will return a RSS feed of the latest posts. gorilla/feed seems to make this relatively simple. I could accept a tag/category parameter, and the RSS link in the frontend could change depending on what category the user is currently looking at.

Pushed back as if I decide to use s3, it may change the way files are handled.


Create events for changes

Is your feature request related to a problem? Please describe.
We need to notify another systems when a version has changed and which is the new tag being used.
Describe the solution you'd like
I'd like to be able to monitor a kubernetes event containing at least:

resource type ("deployment")
resource name ("foo")
tag used ("1.2.3")
namespace ("foo")
optionally, previous tag
optionally, image name and/or repository.

This way we could add another piece to the pipeline to notify external services.
Describe alternatives you've considered
I've considered:

to use ArgoCD-notifications, but it only monitors Applications, so it won't know the tag being used.
to use kubernetes-event-exporter, configuring a label with the tag, but after running argocd-image-updater the tag disapears, and events might be duplicated due to replication.

Additional context
By creating an event, other systems can take it to perform other different actions: notifications (email, slack, pagerduty, ...), maintain a dashboard, monitoring (grafana with tags showing the tag currently used), traceability (logs), ...

Thank you for this idea, @magmax. I do agree that it would be useful to emit Kubernetes events for certain events that happen within Argo CD Image Updater.

I've being browsing the code and it doesn't seem to be difficult. I can try to do it by myself, but I have never written anything in golang. I will need some help, specially with tests.
Can you give me this weekend to try, @jannfis ?

@magmax I'd very much appreciate if you go ahead and try to implement it! There's no time pressure at all, and I'll be happy to guide you through any specifics and questions you might have. No worries about no experience with golang, we will work it out together :)

Done here: https://github.com/argoproj-labs/argocd-image-updater/pull/167
not sure how to link PR and issues.

Well done!
Do you know when this feature will be included in a release? We are very much looking forward to using this feature!!

@matthisholleville It is planned to be launched in version 0.10.0, but I've been waiting for that version around 5 months.
I'm not sure about the roadmap. Maybe @jannfis knows.

@matthisholleville ey! it is out!
https://github.com/argoproj-labs/argocd-image-updater/releases/tag/v0.10.0

Yeah, sorry for the delay. Was a little short on time recently :)


Custom babel config?

Suggestion:
Ability to change the babel config
Why?
It is quite difficult to stay on top of all the new development in ES*
There are some features that I would to use today in webpackbin today: example decorators (stage 2) or styled-jsx (by zeit)
With a customizable babel config, this does not become an overhead for the maintainers
Suggested approach:
Let users override defaults by adding a .babelrc to the bin

I might be completely wrong here. I did read go through the entire docs 🙊


Doesn't clean non-workspace crates that exist inside a workspace

I have a git with the following layout
.
├── Cargo.toml
├── app-wasm
│  ├── Cargo.toml
├── cli
│  ├── Cargo.toml
├── crates
│  ├── api
│  │  ├── Cargo.toml
│  ├── models
│  │  ├── Cargo.toml
...

Where the top-level Cargo.toml looks like:
[workspace]
members = [
    "crates/*",
]
exclude = [
    "cli",
    "app-wasm",
]

Where cli and app-wasm are standalone applications that use the workspace crates.
I used the following commands:

After rustup update: cargo sweep -r --toolchains="stable" "$HOME/repos/"
As well as cargo sweep -r -t 0 "$HOME/repos/"

Actual:

Did not clean the incremental folder from the top-level workspace target folder.
Did not clean any artifacts from cli or app-wasm.

Expected:

All targets properly cleaned.

I am willing to work on a PR if this can be confirmed to be a bug.
Thanks!

I can't reproduce this bug. I have your workspace layout and ran
; cargo run --manifest-path cli/Cargo.toml
   Compiling cli v0.1.0 (/home/jnelson/rust-community/cargo-sweep-66/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 0.21s
     Running `cli/target/debug/cli`
; cargo sweep -r --maxsize 0
[INFO] Successfully removed: "/home/jnelson/rust-community/cargo-sweep-66/cli/target/debug/deps/cli-a05f7f2d31159c21"
[INFO] Successfully removed: "/home/jnelson/rust-community/cargo-sweep-66/cli/target/debug/deps/cli-a05f7f2d31159c21.d"
[INFO] Successfully removed: "/home/jnelson/rust-community/cargo-sweep-66/cli/target/debug/.fingerprint/cli-a05f7f2d31159c21"
[INFO] Cleaned 3.96 MiB

Can you post the exact commands you're running, as well as the version of cargo-sweep?

Sure, I just reproduced it --
cargo install-update -l
Package           Installed           Latest              Needs update
cargo-sweep       v0.6.2              v0.6.2              No

Then I run
# Contains lots of top-level projects, some of which are rust projects,
# some of which are workspace projects,
# some of which have folders with projects in them.
cargo sweep -r --maxsize 0 "$HOME/repos/"
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes
[INFO] Cleaned 0.00 bytes

Now check one of the subprojects...
cd repos/company-name/workspace-project-folder/non-workspace-subfolder/target
du -h .

 16K    ./release/.fingerprint/crossbeam-epoch-8ae397b9da37dc89
 16K    ./release/.fingerprint/swift-bridge-ir-6c74206b15dbb725
8.0K    ./release/.fingerprint/quote-6a7327282a4672f5
8.0K    ./release/.fingerprint/proc-macro2-2979496c850aadf5
 16K    ./release/.fingerprint/pebble-ios-f62ef605c6f6f0fa
 16K    ./release/.fingerprint/tokio-macros-9a06342b42913104
 16K    ./release/.fingerprint/quote-75ed8aa68ebecbfb
 16K    ./release/.fingerprint/async-trait-4afa65846246732f
 16K    ./release/.fingerprint/libc-fb4c6b2baee25cad
 16K    ./release/.fingerprint/serde_derive-4a156cacdcfd2adb
... A lot more
 16K    ./aarch64-apple-ios/release/.fingerprint/signal-hook-registry-6cee91521f014614
 16K    ./aarch64-apple-ios/release/.fingerprint/untrusted-31ac7c520c8fb430
 16K    ./aarch64-apple-ios/release/.fingerprint/idna-48c003e0e9fb658f
 16K    ./aarch64-apple-ios/release/.fingerprint/webpki-aa82e8c44dacbbcf
 16K    ./aarch64-apple-ios/release/.fingerprint/tracing-core-dfb8653bf2c04219
 16K    ./aarch64-apple-ios/release/.fingerprint/socket2-8f2869cfa2cc49c4
 16K    ./aarch64-apple-ios/release/.fingerprint/http-8635f79f5448518f
 16K    ./aarch64-apple-ios/release/.fingerprint/mime-76aa990a8fa6102d
 16K    ./aarch64-apple-ios/release/.fingerprint/bytes-59a50d53babe16da
... A lot more
 14M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
 37M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
 37M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
5.5M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
5.5M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
 85M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
 85M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
9.6M    ./aarch64-apple-ios-sim/debug/incremental/private-symbol-here
... A lot more
  0B    ./debug/build/encoding_rs-1747592e3b4b3c5d/out
8.0K    ./debug/build/encoding_rs-1747592e3b4b3c5d
1.7M    ./debug/build/crc32fast-12828e40be895ae5
  0B    ./debug/build/parking_lot_core-3d6e85baf63bab8a/out
 12K    ./debug/build/parking_lot_core-3d6e85baf63bab8a
1.6M    ./debug/build/memoffset-035911e99805014d
1.8M    ./debug/build/libc-e968c670dd108265
4.0K    ./debug/build/anyhow-cd4743d14c29a12f/out

 15G    .

So cargo-sweep, in this instance, failed to remove 15 GiB of data in the target folder for me.

And if I do it from the "worspace project folder" I get this
cd repos/company-name/workspace-project-folder/non-workspace-subfolder
cargo sweep -r --maxsize 0
[INFO] Cleaned 0.00 bytes

I'm happy to provide any information you think is valuable.

If I run cargo-sweep from the directory itself, it works
cd repos/company-name/workspace-project-folder/non-workspace-subfolder
cargo sweep -r --maxsize 0
... Lots of files deleted
[INFO] Cleaned 10.66 GiB

Note: I have multiple non-workspace subfolders, i.e. multiple non-workspace Cargo.toml's and projects.

I had some time over, so I looked into it. It's pretty clear to me that this never worked, and I don't know how you got it to work @jyn514 .
main.rs:
            if let Some(target_directory) = is_cargo_root(entry.path()) {
                target_paths.insert(target_directory);
                iter.skip_current_dir(); // no reason to look at the src and such
            }

As soon as it finds a directory with a valid Cargo root, it just skips all subdirectories.

If I just comment out the iter.skip_current_dir(); line, it magically starts working.

Ah ok, the problem is multiple root workspaces, not that the directory is ignored altogether. Seems like a simple fix - do you want to make a PR with that change? :)

Yes, I was making a patch already <3

Thanks @jyn514 🎉

Nice, can we have a new release for that?


Add docs describing how to use ClientTrafficPolicy

Description:

Describe the issue.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

xref: https://github.com/envoyproxy/gateway/pull/2223

closed with https://github.com/envoyproxy/gateway/pull/2223


Show log while building

When I'm too impatient, or something is taking suspiciously long, I often used to log into the screen running the old codespeed runner and take a look at the current build logs. I can imagine implementing something like that to be quite a bit more complicated with this kind of infrastructure, but it would be a pity if the more powerful system wasn't able to replicate this simple action.

For a start, showing just the elapsed time would already make the queue view more informative.

Would showing the last ~100 or so lines work, or do you want to see the entire output?

Regarding the current logs: The bench script could redirect the stdout of the programs it calls to stderr. Then the runner could print all stderr it receives from the benchscript. This solution feels a bit ugly to me, but on the other hand, the bench script's stdout is reserved for the bench results.

The bench script could redirect the stdout of the programs it calls to stderr.

As you said, it must in fact do that to prevent messing up the bench results

We will have a look ourselves to address the problems, but if you want you can quickly note down what you think or want out of this feature here.


Support alt text on URL previews with images

Is your feature request related to a problem? Please describe.
Images generated from URI previews, e.g. url images generated from cards/og:image or gifs from giphy.com
Describe the solution you'd like
A clickable Alt button just like we get with image uploads, which then renders as alt text for the URI preview images.
Describe alternatives you've considered
None
Additional context
Requested due to https://bsky.app/profile/margaretprice.bsky.social/post/3kormcuqqhr26

And now there's real gif support we should also have the ability to add/edit alt text for those


POC: Move Kyma Environment Broker from control-plane into new repository

Description
After a discussion with SRE, we do not need a monolith repository for the control plane anymore.
Reason

We don't want to be affected by other components' tests and configurations when developing KEB.
Ownership for the whole repository assigned only to Gophers. We'd like to make use of GitHub actions for testing pipelines etc.
We can finally implement Auto-bump for PR, existing ticket

Ideas

new repo in kyma-project org for KEB
new way of deploying KEB into environments (find a way how we will manage charts and image versions) See how Lifecycle Manager component is used in the Argo CD.
move tests from fast-integration to the new KEB repository.
move subscription cleanup job outside of KEB (double check)

AC

[ ] 1) Figure out how argoCD manages KEB in the environments. Document results in the comment.
[ ] 2) Check if we can easily move KEB code and deployments out of control-plane repository. Document results in the comment.

[ ] 2.1) Check KCP CLI if it will still work

[x] 3) Add all templates to this repository, labels etc (reference repository: btp-manager) Done by @MarekMichali
[x] 4) Make sure all git history is cloned/copied into new repository @piotrmiskiewicz
[ ] 5) Document a process how we will switch in ARGO CD from control-plane deployments to kyma-environment-broker deployments
[ ] 6) POC: we have a KEB instance in the DEV Env deployed from the new repo. Still, KEB deployment from the control-plane is a default one.

Moving git history

clone the old repository:

git clone https://github.com/kyma-project/control-plane
cd control-plane

git remote rm origin

Remove all unnecessary files

git filter-branch --subdirectory-filter components/kyma-environment-broker -- --all

or just remove files manually and commit it (the history will contain all history from control-plane like Provisioner)
3. Checkout the existing new repository
4. Define a remote with a link the the old one:
git remote add old <filesystem path to the cloned old repo>

Pull from old repo:

git pull old main --allow-unrelated-histories --rebase

NOTE: if the old repo contains the same file like in the new one be aware of conflicts. Think about running:
rm CODE_OF_CONDUCT.md CONTRIBUTING.md LICENSE NOTICE.md README.md .gitignore

in the old or in the new one.

We made a decision to first move code and start developing KEB in the new repository, but keep deployments via control-plane. Then as a next step we will take care about moving deployment into new repository.

These are components that have KEB dependencies

components/kyma-metrics-collector
tests/e2e/provisioning
tools/cli

In order to move the code we could take these steps

Copy the code to the new repo
Check whether the above mentioned components will still work after changing the dependencies to the new repo
Check with pjtester if the KEB prow jobs will work after changing to the new repo
Change the dependencies in the mentioned components
Change KEB related prow jobs to point to the new repo
Remove KEB from control-plane and leave a note where to find the code base.

pre-main-kcp-cli and post-main-kcp-cli are triggered with this regex: run_if_changed: '^tools/cli|^components'
We need to check if we need to run the job also from the new KEB repository

PR with jobs building new repository: https://github.com/kyma-project/test-infra/pull/8843

Verified builds:

[ ] "pull-new-keb-build"
[ ] "post-new-keb-build"
[ ] "pull-new-keb-cleanup-job-build"
[ ] "post-new-keb-cleanup-job-build"
[ ] "pull-new-keb-subaccount-cleanup-job-build"
[ ] "post-new-keb-subaccount-cleanup-job-build"
[ ] "pull-new-keb-trial-cleanup-job-build"
[ ] "post-new-keb-trial-cleanup-job-build"
[ ] "pull-new-keb-deprovision-retrigger-job-build"
[ ] "post-new-keb-deprovision-retrigger-job-build"
[ ] "pull-new-keb-runtime-reconciler-job-build"
[ ] "post-new-keb-runtime-reconciler-job-build"

Consolidated Plan
These are components that have KEB dependencies:

components/kyma-metrics-collector
tests/e2e/provisioning
tools/cli

In order to move the code we could take these steps:

[ ] Clean pull requests in control plane

[ ] Investigate if prow jobs with run_if_changed set to KEB are save to either remove. The reason is that we are not aware of Prow being able to trigger build across multiple repositories. For example,pre-main-kcp-cli  and post-main-kcp-cli are triggered with this regex: run_if_changed: '^tools/cli|^components'We need to check if we need to run the jobs also from the new KEB repository .

[ ] Copy the code to the new repo with the history of all commits. Script that automates the process for the specified subdirectory.

[ ] KEB moved to https://github.com/kyma-project/kyma-environment-broker
[x] Copy https://github.com/kyma-project/control-plane/tree/main/components/kyma-environment-broker flattening the structure
[x] Copy https://github.com/kyma-project/control-plane/tree/main/resources/kcp/charts/kyma-environment-broker leaving structure as is
[ ] Copy docs
[x] scripts/generic_make_go.mk (can be manually)
[ ] Should cleanup subscription from Frogs still be moved?

[ ] Copy KEB related prow jobs to definitions that point to the new repo. Buliding two images. Change Prow pipelines to point to the new KEB repository

[ ] Check with pjtester if the KEB prow jobs will work after changing to the new repo.
[ ] Check whether the above mentioned components will still work (build) after changing the dependencies to the new repo.
[ ] Check if all run_if_changed are necessary

Prow Jobs:

[x] "pull-new-keb-build"
[ ] "post-new-keb-build"
[x] "pull-new-keb-cleanup-job-build"
[ ] "post-new-keb-cleanup-job-build"
[x] "pull-new-keb-subaccount-cleanup-job-build"
[ ] "post-new-keb-subaccount-cleanup-job-build"
[x] "pull-new-keb-trial-cleanup-job-build"
[ ] "post-new-keb-trial-cleanup-job-build"
[x] "pull-new-keb-deprovision-retrigger-job-build"
[ ] "post-new-keb-deprovision-retrigger-job-build"
[x] "pull-new-keb-runtime-reconciler-job-build"
[ ] "post-new-keb-runtime-reconciler-job-build"

[ ] Create parallel argo setup for new repository - can work on old repo, if we would like to postpone switching.

[ ] Customize Deployment Scripts that deploy a separate resources (separate namespace).
[ ] Make sure that istio that resides in the Control Plane repository does not break the build
[ ] Check schema-migrator

[ ] Change the packages and dependencies in KEB and Control Plane

[ ] Remove KEB and rename imports in control plane - wip - https://github.com/kyma-project/control-plane/pull/3045
[ ] Rename imports in new KEB repo - wip - https://github.com/kyma-project/kyma-environment-broker/pull/29
[ ] check if broker builds work on prow

[ ] Remove KEB from control-plane and leave a note where to find the code base.

[ ] Subchart Removal - make sure that removal of chart does not cause any downtime because it will for sure cause deployment removal.

[ ] Github Actions

[ ] Protect branches

[ ] Remove repo syncing action

[ ] Cleanup remains

[ ] Versioning

[ ] Does KCP Cli work?

[ ] Run linting always ?? is it necessary?? scripts always https://github.com/ralikio/kyma-environment-broker/pull/1

[ ] Dependa bot

[ ] generic jobs in test-infra

Missing build: https://github.com/kyma-project/test-infra/pull/8880
Dependabot: https://github.com/kyma-project/kyma-environment-broker/pull/34
ESlint: https://github.com/kyma-project/kyma-environment-broker/pull/32

Version Update Bump pointing to the new repository: https://github.com/kyma-project/control-plane/pull/3068

Environments Cleanup job: https://github.com/kyma-project/kyma-environment-broker/pull/46

New KEB Helm chart for easy refactoring: https://github.com/kyma-project/kyma-environment-broker/pull/63


Add parameter configuration to adjust time partition origin

Description
The previous default time partition origin was 0, and this PR has added configurable parameters to adjust the origin to meet specific needs

Hi, the code looks good to me, but I think we need some UT/ITs to show the configuration works.

BTW，Upgrade tests need to be done manually

Added display of time partition origin in cli:

Regarding upgrade compatibility, we manually tested that this parameter will only take effect at the first startup, so it will not cause compatibility issues.


Added: issue fixes 326-330

I've checked the following points:

[ ] I've formatted the code by pressing (STRG + K + D)
[ ] I've removed unnecessary usings
[ ] I've not used magic variables
[ ] I've used localization service instead of text
[ ] All public things have comments
[ ] This has been followed: conventions

@nick-samygin please rebase the branch from dev.

@nick-samygin please resolve the conflicts


refactor: move configuration into dedicated package

Create a new config package to centralize and improve configuration management. This change reduces duplication and provides better separation of concerns.
Key changes:

Create new pkg/config package with Config struct and related methods
Add comprehensive config validation for address, ports, and TLS files
Centralize logging configuration and initialization
Add thorough unit tests with testify for all config functionality
Support loading config from files, flags, and environment variables
Improve TLS key file permission handling and validation
Remove config handling from main.go and webhook package

The config package now serves as the single source of truth for all configuration, making the codebase easier to maintain and test.w
Summary by Sourcery
Introduce a new config package to manage configuration loading, validation, and logging initialization.
Enhancements:

Centralize configuration management and logging setup.

Tests:

Add unit tests for the new config package.

@sourcery-ai review


Should model-server /generateToken be not a get?

Given it is not idempotent (a different token is generated each time). I think we should use POST instead

To connect a local MPS instance to the model server a user has to open /generateToken in the browser and copy/paste that token into MPS. We could return the same token each time for the same user.

Obsolete. There is now a keycloak server running in the cluster that generates JWT tokens.


_isClickDisabled throws error if parent is removed from DOM

Since I upgraded leaflet to version 1.8.0, two components in my app have stopped working.  I have applied DomEvent.disableClickPropagation() to the control container, like so:
L.DomEvent.disableClickPropagation(container);
and it used to work without any problem before the upgrade. Since the upgrade, whenever I select one of the options available from the search (react-search-box) or the select (react-select) dropdown menu, I get this error:

@mourner and @Falke-Design do you guys have any idea what I could do to fix this? Or is there anything that you guys can do on your side? Thanks for your precious time!
Originally posted by @AngelaCandela in https://github.com/Leaflet/Leaflet/issues/7439#issuecomment-1148829666

@Falke-Design I set up this demo in codesandbox, I hope it helps! Once again, thank you so much for your help!
Originally posted by @AngelaCandela in https://github.com/Leaflet/Leaflet/issues/7439#issuecomment-1148999564


[Good First Issue]: Verify red-pajama-3b-instruct with GenAI text_generation

Context
This task regards enabling tests for red-pajama-3b-instruct. You can find more details under openvino_notebooks LLM question answering README.md.
Please ask general questions in the main issue at https://github.com/openvinotoolkit/openvino.genai/issues/259
What needs to be done?
Described in the main Discussion issue at: https://github.com/openvinotoolkit/openvino.genai/issues/259
Example Pull Requests
Described in the main Discussion issue at: https://github.com/openvinotoolkit/openvino.genai/issues/259
Resources

Contribution guide - start here!
Intel DevHub Discord channel - engage in discussions, ask questions and talk to OpenVINO developers

Contact points
Described in the main Discussion issue at: https://github.com/openvinotoolkit/openvino.genai/issues/259
Ticket
No response

.take

Hello @AishwaryaDekhane, are you still working on this? Is there anything we could help you with?

I'm working on it. Please allow me couple of days more.

.take

Hello @AishwaryaDekhane what is the status ?

Hello @AishwaryaDekhane, are you still working on this? cc @pavel-esir

.take

Hello @p-wysocki , I asked 3 week ago. This happened second time.

.take

@kuanxian1 any updates here?

.take

Hi @Wovchena
I tried running the redPajama instruct model in OpenVino with the chat sample and the model seems to produce reasonable output after i added the chat template to tokenizer_config.json of  model :

However, i am having issue running the pytest after adding the model to the nightly list for all the test cases as below:

I am wondering if you could assist me with this ? I tried rebuilding the project but got the same error.

Try running setuvars.sh. See the instruction for the details https://github.com/openvinotoolkit/openvino.genai/blob/master/src/docs/BUILD.md


Type annotations are frequently ignored in --checkJs

TypeScript Version:  2.3.2
Code
class Wrapper {
  constructor() {
    /** @type {boolean} */
    this.isThing = false;
    this.isThing = !this.isThing;
  }
}

Expected behavior:
This passes.
Actual behavior:
Every once in a while:

test.js(4,5): error TS7022: 'isThing' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.

It's very inconsistent whether or not this error (and other similar errors) appears. It seems like being part of a larger project makes it much more likely.
Since this bug is much easier to consistently reproduce on larger codebases, I've pushed a commit that reproduces the bug in the context I hit upon it:
https://github.com/Zarel/Pokemon-Showdown/tree/e34c77930a7eaae05a28eb68cbc392c777b8c590
If you checkout this commit and run tsc, you'll get three errors which I believe are related:

sim/dex-data.js(101,3): error TS7022: 'exists' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
sim/dex.js(87,7): error TS2322: Type 'string[]' is not assignable to type '("Pokedex" | "FormatsData" | "Learnsets" | "Movedex" | "Statuses" | "TypeChart" | "Scripts" | "It...'.
Type 'string' is not assignable to type '"Pokedex" | "FormatsData" | "Learnsets" | "Movedex" | "Statuses" | "TypeChart" | "Scripts" | "Ite...'.
sim/dex.js(1476,33): error TS2531: Object is possibly 'null'.

(All three of them disappear when I copy/paste the relevant code into a new file to try to create a simple testcase, and all three are incorrect.)
Here's a screenshot of it failing in Visual Studio Code:

The compiler honors the type annotation, but since these are all assignments, it is not clear which one is the declaration, it still tries to evaluate the expressions. the assumption is that the right-hand-side of the assignment will have a type we can use, but here this.exists = !!(this.exists && this.id); it has a self reference, and that triggers the implicit any.
The solution here would be to give JSDoc higher precedence. this could mean doing two passes, one to find the JSDoc, and one to compute the expression if none was found.

The other thing is that !anything should be boolean, so even with the self reference, it shouldn't need to trigger the implicit any, right?
Also, shouldn't it be clear that the first one is the declaration? I know TypeScript can handle variables being different types in different parts of the code. I've written code like:
/** @type {string | number} */
let a = ...;
if (typeof a === 'string') return;
// a's inferred type is now number

So when we get to this.exists = !!(this.exists && this.id);, even if it is a self-reference, TypeScript should know what type it is, shouldn't it?

Based on the discussion in https://github.com/Microsoft/TypeScript/issues/15747, @type should always have precedence. for contextual typings purposes, we need to first walk all the binary expressions we have, and see if any of them has a @type, then use that as a type, instead of checking the expression directly.


[vim9script] "gvim.exe -u _vimrc" error in Windows

Steps to reproduce

gvim.exe -u _vimrc

vim9script
set nocompatible

set gfn=Consolas:h16

source ~/.vim/vim-plug/plug.vim
plug#begin('~/.vim/plugged')
    Plug 'vim-airline/vim-airline'
plug#end()

"gvim.exe<ENTER>" works fine with vim9script _vimrc.
However, "gvim.exe -u _vimrc<ENTER>" does not.

Expected behaviour
no errors in "gvim.exe -u _vimrc"
Version of Vim
9.0.1640
Environment
Windows 11 x64 22H2
Logs and stack traces
No response

In particular: #10772 (comment)

Thank you!
"-N -u" works well.


No mic pop up on android

Samsung tablet

Problem was  ecsuse I was using http not https. So need to have app force https. See
https://medium.com/@seunghunsunmoonlee/how-to-enforce-https-redirect-http-to-https-on-heroku-deployed-apps-a87a653ba61e


invalid memory address

Getting the below error while trying to pull stats:
curl 'localhost:8080/statistics?pretty'
2015/02/23 14:15:14 http: panic serving <IP_ADDRESS>:33959: runtime error: invalid memory address or nil pointer dereference
goroutine 15 [running]:
net/http.func·009()
/usr/lib/go/src/pkg/net/http/server.go:1093 +0xae
runtime.panic(0x6b1500, 0xa25168)
/usr/lib/go/src/pkg/runtime/panic.c:248 +0x106
github.com/otoolep/syslog-gollector/input.(*Rfc5424Parser).GetStatistics(0x0, 0x711f40, 0x6, 0x7fb7b4071da8, 0x0)
/home/admin-ti/syslog-gollector/src/github.com/otoolep/syslog-gollector/input/parser.go:49 +0x5
main.ServeStatistics(0x7fb7b4071cf8, 0xc21000fb40, 0xc210072820)
/home/admin-ti/syslog-gollector/src/github.com/otoolep/syslog-gollector/syslog-gollector.go:84 +0x1bc
net/http.HandlerFunc.ServeHTTP(0x7a3328, 0x7fb7b4071cf8, 0xc21000fb40, 0xc210072820)
/usr/lib/go/src/pkg/net/http/server.go:1220 +0x40
net/http.(*ServeMux).ServeHTTP(0xc21001e8d0, 0x7fb7b4071cf8, 0xc21000fb40, 0xc210072820)
/usr/lib/go/src/pkg/net/http/server.go:1496 +0x163
net/http.serverHandler.ServeHTTP(0xc21001f5a0, 0x7fb7b4071cf8, 0xc21000fb40, 0xc210072820)
/usr/lib/go/src/pkg/net/http/server.go:1597 +0x16e
net/http.(*conn).serve(0xc21006a480)
/usr/lib/go/src/pkg/net/http/server.go:1167 +0x7b7
created by net/http.(*Server).Serve
/usr/lib/go/src/pkg/net/http/server.go:1644 +0x28b

Thanks for the report @dirtdiver512
I have a feeling this was fixed in a fork by https://github.com/emmanuel/syslog-gollector/commit/d957c153207c8f83859e1985bdd66e383d6ebc90. I'm going to port this change and close this issue. Let me know if you see it again.

Yeah, this is basically hitting the stats endpoint if the server or parser objects are not allocated. This can happen if Kafka can't be contacted, or if parsing is disabled.
I'll fix this shortly.

Fixed.

Just updated with the lasted and still getting the below…?
2015/03/02 18:41:09 http: panic serving <IP_ADDRESS>:44873: runtime error: invalid memory address or nil pointer dereference
goroutine 14 [running]:
net/http.func·009()
/usr/lib/go/src/pkg/net/http/server.go:1093 +0xae
runtime.panic(0x6b1500, 0xa25168)
/usr/lib/go/src/pkg/runtime/panic.c:248 +0x106
github.com/otoolep/syslog-gollector/input.(*Rfc5424Parser).GetStatistics(0x0, 0x711f40, 0x6, 0x7f396a117d80, 0x0)
/tmp/gollector/src/github.com/otoolep/syslog-gollector/input/parser.go:49 +0x5
main.ServeStatistics(0x7f396a117cd0, 0xc21000f960, 0xc2100724e0)
/tmp/gollector/src/github.com/otoolep/syslog-gollector/syslog-gollector.go:84 +0x1bc
net/http.HandlerFunc.ServeHTTP(0x7a3368, 0x7f396a117cd0, 0xc21000f960, 0xc2100724e0)
/usr/lib/go/src/pkg/net/http/server.go:1220 +0x40
net/http.(*ServeMux).ServeHTTP(0xc21001e8d0, 0x7f396a117cd0, 0xc21000f960, 0xc2100724e0)
/usr/lib/go/src/pkg/net/http/server.go:1496 +0x163
net/http.serverHandler.ServeHTTP(0xc21001fb90, 0x7f396a117cd0, 0xc21000f960, 0xc2100724e0)
/usr/lib/go/src/pkg/net/http/server.go:1597 +0x16e
net/http.(*conn).serve(0xc210069480)
/usr/lib/go/src/pkg/net/http/server.go:1167 +0x7b7
created by net/http.(*Server).Serve
/usr/lib/go/src/pkg/net/http/server.go:1644 +0x28b
From: otoolep<EMAIL_ADDRESS>Sent: Tuesday, February 24, 2015 9:34 PM
To: otoolep/syslog-gollector
Cc: dirtdiver512
Subject: Re: [syslog-gollector] invalid memory address (#18)
Closed #18 https://github.com/otoolep/syslog-gollector/issues/18 .
—
Reply to this email directly or view it on GitHub https://github.com/otoolep/syslog-gollector/issues/18#event-241502957 .Image removed by sender.

Can you provide more details about your setup? Does the gollector connect to Kafka? Please show me the entire output from the program, and the curl command you execute.

Yes I just did anouther fresh install.  I am trying to get it to send logs to kafka, single server, basic install.  I can see syslogs going into kafka for a little while but then stops.  So when I try and check the stats I get this error, but the diag still works.   This is my first go at it.  Here is the command and results:
admin-ti@kafka:/tmp/kafka/kafka_2.10-<IP_ADDRESS>$ curl 'localhost:8080/statistics?pretty'
curl: (52) Empty reply from server
admin-ti@kafka:/tmp/kafka/kafka_2.10-<IP_ADDRESS>$
admin-ti@kafka:/tmp/syslog-gollector$ sudo bin/syslog-gollector -topic="poc-av" -udp="<IP_ADDRESS>:514"  -parse="false"
[sudo] password for admin-ti:
[03/03/15 07:49:26] [INFO] syslog server starting on kafka, PID 19005
[03/03/15 07:49:26] [INFO] machine has 4 cores
[03/03/15 07:49:26] [INFO] Admin server: localhost:8080
[03/03/15 07:49:26] [INFO] kafka brokers: localhost:9092
[03/03/15 07:49:26] [INFO] kafka topic: poc-av
[03/03/15 07:49:26] [INFO] kafka batch size: 10
[03/03/15 07:49:26] [INFO] kafka buffer time: 1000ms
[03/03/15 07:49:26] [INFO] kafka buffer bytes: 524288
[03/03/15 07:49:26] [INFO] parsing enabled: false
[03/03/15 07:49:26] [INFO] channel buffering capacity: 0
[03/03/15 07:49:26] [INFO] listening on localhost:514 for TCP connections
[03/03/15 07:49:26] [INFO] listening on <IP_ADDRESS>:514 for UDP packets
[03/03/15 07:49:26] [INFO] Admin server started
[03/03/15 07:49:26] [INFO] attempting to connect to Kafka localhost:9092...
[03/03/15 07:49:26] [INFO] kafka producer created
[03/03/15 07:49:26] [INFO] connected to Kafka at localhost:9092
2015/03/03 07:50:08 http: panic serving <IP_ADDRESS>:38859: runtime error: invalid memory address or nil pointer dereference
goroutine 15 [running]:
net/http.func·009()
    /usr/lib/go/src/pkg/net/http/server.go:1093 +0xae

runtime.panic(0x6b1500, 0xa25168)
    /usr/lib/go/src/pkg/runtime/panic.c:248 +0x106

github.com/otoolep/syslog-gollector/input.(*Rfc5424Parser).GetStatistics(0x0, 0x711f40, 0x6, 0x7f4c05896da8, 0x0)
    /tmp/syslog-gollector/src/github.com/otoolep/syslog-gollector/input/parser.go:49 +0x5

main.ServeStatistics(0x7f4c05896cf8, 0xc21000faa0, 0xc210072b60)
    /tmp/syslog-gollector/src/github.com/otoolep/syslog-gollector/syslog-gollector.go:84 +0x1bc

net/http.HandlerFunc.ServeHTTP(0x7a3368, 0x7f4c05896cf8, 0xc21000faa0, 0xc210072b60)
    /usr/lib/go/src/pkg/net/http/server.go:1220 +0x40

net/http.(*ServeMux).ServeHTTP(0xc21001e8d0, 0x7f4c05896cf8, 0xc21000faa0, 0xc210072b60)
    /usr/lib/go/src/pkg/net/http/server.go:1496 +0x163

net/http.serverHandler.ServeHTTP(0xc21001fb90, 0x7f4c05896cf8, 0xc21000faa0, 0xc210072b60)
    /usr/lib/go/src/pkg/net/http/server.go:1597 +0x16e

net/http.(*conn).serve(0xc21006a480)
    /usr/lib/go/src/pkg/net/http/server.go:1167 +0x7b7

created by net/http.(*Server).Serve
    /usr/lib/go/src/pkg/net/http/server.go:1644 +0x28b

admin-ti@kafka:/tmp/kafka/kafka_2.10-<IP_ADDRESS>$ curl 'localhost:8080/diagnostics?pretty'
{
"started": "2015-03-03 07:49:26.383983979 -0900 AKST",

"uptime": "3m9.818499926s"

}admin-ti@kafka:/tmp/kafka/kafka_2.10-<IP_ADDRESS>$ mailto:}admin-ti@kafka:/tmp/kafka/kafka_2.10-<IP_ADDRESS>$
From: otoolep<EMAIL_ADDRESS>Sent: Monday, March 02, 2015 5:58 PM
To: otoolep/syslog-gollector
Cc: dirtdiver512
Subject: Re: [syslog-gollector] invalid memory address (#18)
Can you provide more details about your setup? Does the gollector connect to Kafka? Please show me the entire output from the program, and the curl command you execute.
—
Reply to this email directly or view it on GitHub https://github.com/otoolep/syslog-gollector/issues/18#issuecomment-76877991 .Image removed by sender.

Is any call to the statistics API functional? I mean is it working for you, but it fails later?

Fixed by thttps://github.com/otoolep/syslog-gollector/commit/f2ffb54320fd232c286e5a3d272bc5ffeac1fbf2
Thanks @dirtdiver512 for the bug report. Let me know if the latest code doesn't address the crash.


Teams fx migration samples

Build Pipeline -
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/5962805228


Add a Collision Button

I think it might be interesting to have a button on the toolbar so that the user can activate or deactivate the collision of a block on your map
I saw that inside the block data there is a bool that defines the collision, however it doesn't seem to be working

There should probably be a way to configure collision layers/masks, so that you can mark certain brushes to block players but not bullets for instance.

There should probably be a way to configure collision layers/masks, so that you can mark certain brushes to block players but not bullets for instance. If you disable all layers/masks, then the brush would be nonsolid and anything could pass through it.

Just to confirm - there is not presently a way to edit collision layers and masks?

At the moment, no.  Planning to add it in a future update.  If you really need it for now, you can run a script to walk through the CyclopsConvexBlockBody nodes and set it on the StaticBody3D children.


How do I make the bot join a voice channel?

So there's 2 voice channels in my discord general and Music and I want the bot to join Music but my current code it doesn't seem to work
Script

http://discordjs.readthedocs.org/en/indev/docs_client.html#voiceconnections

.joinVoiceChannel requires a channel resolvable. Not a string.
http://discordjs.readthedocs.org/en/indev/docs_client.html#voiceconnections

What does that mean exactly?

A Resolvable for a channel is the channel ID
http://discordjs.readthedocs.org/en/rewrite-docs/docs_resolvables.html#voice-channel-resolvable

sad


chore(ci): run snyk on github action on pull requests

Ensures that the Snyk github action runs on Pull Requests
Description

References

Review Checklist

[ ] I have added documentation for new/changed functionality in this PR or in openfga.dev
[x] The correct base branch is being used, if not main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ref: rewrap a couple usage blocks

Per https://github.com/iterative/dvc.org/pull/3325#pullrequestreview-903978598 and https://github.com/iterative/dvc.org/pull/3325#pullrequestreview-903978835 originally

Some quality-related ideas on what criteria to use when formatting usage blocks. Potentially we can later match this in the core repo too (-h help output).

Meaning the line width specific to code blocks? I don't think so unfortunately, in fact code blocks are allowed any line width by the linter. We should always sanity check the review app before merging -- that's how I detect code blocks that are scrolling horizontally.

I approved this again but is this an epic?

is this an epic?

No but there are follow up tasks (I'll make an issue after this or something).


APEXMALHAR-2031 enable WindowDataManager to save window files under u…

…ser configured path

@ilooner please review and merge


Update validation-basics.md

There is no config in the custom rule expression, only $config in the message.

thanks!


How to send a file?

https://github.com/Soontao/light-odata/blob/39e0efb6c51b6d2c088313211ec9c434a07754c3/src/odata.ts#L314
Why does body turn into a string? When I try to send a file to the server, my FormData turns into "{}". Is it possible to do without this?

ok, I get it, will plan this.


Remove unused images from _docs/setup/kuberenetes/img

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Tahler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Major efficiency improvements from building from source (not mentioned in docs)

Hi JAX devs,
One thing I've observed recently is massive performance gains (2x speed increase or more) from building jaxlib from source, likely as a result of XLA's ops being compiled with all the vector instructions my machine has (as opposed to the binary that pip downloads). I first noticed this after building the (ROCm) GPU version and noticing that it was a lot faster than the pip-installed CPU only version even though my CPUs have higher floating-point bandwidth than my GPU, so I tried comparing the CPU-only pip version and the build-from-source CPU-only version, and found the massive performance gains I'm talking about here.
This doesn't seem to be mentioned anywhere in the JAX documentation, and it would probably be useful for a lot of people, so I figured I'd bring it up here. I'm happy to add a note in the docs myself and make a PR if that's easier for y'all than writing it yourselves and you'd want that.
I suppose you could also compile multiple variants of jaxlib and include those with the pip package if you think that's a better solution (to just make the pip package fast on more systems)...

This is actually a little bit surprising to me!
The reason I say this is that JAX (via XLA) is a just-in-time compiler. That is, it generates code for your particular hardware, tailored for your particular hardware, every time it is run. For example, if you have an Intel Skylake CPU, JAX would generate AVX512 instructions via JIT compilation, even though the jaxlib wheel itself does not require or use such instructions. The build flags should only really affect things like the speed of the compiler itself, and should not benefit significantly from, say, vectorization.
Can you share a benchmark and instructions to reproduce the issue? I'd like to reproduce this so I can dig into it a little bit deeper and see what is going on.
(As it happens, I was thinking of at the very least requiring AVX instructions for JAX shortly for a host kernel I'm planning to add, but I'm surprised there's any meaningful difference at the moment!)

Sure, I'll put together a good benchmark for this (the code I observed the effect on isn't a good benchmark, but I should be able to extract a good one from it) and drop it here later today.
Meanwhile, are you sure that XLA actually compiles everything at runtime? For example, when I was building jaxlib, I saw that files like org_tensorflow/tensorflow/compiler/xla/service/cpu/runtime_matmul.cc were being compiled. This caused me to think that maybe XLA pre-compiles certain ops (e.g. matrix multiplication) and links them in at runtime for faster compiles---is this true?  If so, it would explain the difference, I think. If not, why are those files being compiled at all?

There are a small number of kernels (matmul, convolution) that are precompiled. It's possible they are relevant here.
That said, most 32-bit kernels use MKL-DNN, which I believe also uses JIT compilation internally (https://oneapi-src.github.io/oneDNN/dev_guide_cpu_dispatcher_control.html). There are however a number of Eigen kernels that are not dispatched at runtime; it's possible you are hitting one of them. So a benchmark would be helpful.

I'm re-building JAX in a fresh environment now to test out the benchmark I've written, so as soon as that's done and I've verified that the benchmark shows what I think it will (probably in about an hour based on the current compilation rate) I'll drop it and instructions for replication here. Based on what's going on in the actual code I observed this effect in, I'll be surprised if it doesn't turn out that matrix multiplication kernels explain almost the entire difference, since the majority of the FLOPS are spent on a few big batched matrix multiplies (i.e. multiplying a whole bunch of 3x3 matrices against each other by vmap-ing over axis 0 of a 3-d array)

What are the types of the matrices? Are they float64 or float32?

float64

FWIW, I'll be running the benchmark on a Haswell CPU, so I have AVX2 but not AVX512

Hm, so this is somewhat interesting; the difference I observed must be in something other than matrix multiplication, because the following benchmark shows about a 10% time reduction from using locally-compiled jaxlib as opposed to pip-installed jaxlib on my machine (as opposed to the ~50% improvement I saw on my production code):
import jax
from jax import numpy as jnp
from jax import random
from jax.config import config
from sys import argv
import time
config.update('jax_enable_x64', True)

N = 5000
if len(argv) > 1:
    N = int(argv[1])

def time_execution(f, args):
    start = time.time()
    out = f(*args).block_until_ready()
    stop = time.time()
    print(f"Execution time (seconds): {stop - start}")
    return stop - start

@jax.jit
@jax.vmap
def func(x):
    xx = x @ x
    xxx = xx @ x
    return jnp.array([jnp.trace(x), jnp.trace(xx), jnp.trace(xxx)])

key = random.PRNGKey(0)
key, subkey = random.split(key)
A = random.normal(key, shape=(N,3,3))

ttot = 0.0
for _ in range(10):
    ttot += time_execution(func, (A,))

print(f"average time: {ttot / 10}")

I'll try to come up with a similarly compact benchmark that reproduces the more dramatic speed improvement I originally observed on my code.

Float64 matmul and/or convolution could explain things. MKL-DNN (aka one-DNN) only supports float32. For other cases, we use Eigen, which does depend on the target architecture at build time. Unfortunately it is somewhat difficult to safely mix Eigen kernels built with different compilation options in the same binary without creating ODR problems.
The question I have is: would requiring AVX support (as TensorFlow's binaries do already) be enough to capture most of the performance benefit? To answer that, we'd need a good benchmark, and that's where you can help!

I see --- I'll let you know when I have a better benchmark than the one above (i.e. one that shows more than 20%-ish of the speed difference that I observed, which is all I captured in that one). Thanks!

#5738 enables AVX by default. I'd be interested to know if it help significantly, although I can probably verify that myself if you have a benchmark.

Great -- I'll test that either later today or tomorrow morning. I tried unsuccessfully to reproduce the problem in a reasonably short (lines of code-wise) benchmark earlier (I could only reproduce an approximately 10% speed difference as opposed to the 50% I saw originally, and that was pretty consistent across the several variations of benchmark program I tried), but I'm interested in figuring out what's going on here so I'll try a bit more tomorrow to reproduce it in a benchmark I can share

Closing; I'm assuming that enabling AVX by default is enough to fix this. Please reopen if you have a benchmark that proves otherwise!


FAMD results discrepancies with boolean vs category variable

Hello,
I have a dataset composed of 8 numerical variables and a single category variable (0 or 1).
I'd like to perform a FAMD.
If I treat this category variable as a boolean, I obtain this plot of row coordinates:

When I enforce the variable as a category, I obtain this plot:

An interactive demo is available here: https://repl.it/repls/DismalClientsideTheory
Is this expected ?
Thanks !
prince==0.6.3

Hey @Melkaz,
I took a look at this and I believe the current API makes sense. If you treat a variable as a category, then it will be one-hot encoded and an MCA will be used. If the variable is treated as a boolean, then it treated as a numeric variable with two possible values, and a PCA will be used. Do you agree?

Yeah, I thought about it also and it makes sense.
Thanks :)


Document fallback_type

Adds documentation and test for custom fallback type.
Tests for MySQL are breaking because MySQL doesn't support custom types.
I could either add checks where necessary or remove the test altogether.

Replaced by  #30


KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest

Some tests in TopicBasedRemoteLogMetadataManagerTest flake because waitUntilConsumerCatchesUp may break early before consumer manager has caught up with all the events.
This PR adds an expected offsets for leader/follower metadataOffset partitions and ensures we wait for the offset to be at least equal to the argument to avoid flakyness.
Refer Gradle Enterprise Report for more information on flakyness.

CC: @clolov @satishd

Thanks for the feedback @kamalcph @satishd!
I've modified the tests so that we propagate a Consumer<RemoteLogMetadata> down to ConsumerTask and use it only for tests.
This allows us to replace waitUntilConsumerCatchesUp with TestUtils.waitForCondition to actually wait on the consumption of all expected RemoteLogMetadata objects we set up in the tests instead of relying on offsets which is ambiguous.
Please have a look and let me know your thoughts!

@chia7712 looks like we still suffer from thread leaks in CI :( I've rebased from trunk to trigger CI again

looks like we still suffer from thread leaks in CI :( I've rebased from trunk to trigger CI again

I have noticed that too. so sad :(


Make conmon and crio share the same constants

This patch adds a little program config.go, which
outputs config.h based on the constants set in oci.go
This will make sure that conmon and crio use the same constants.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

Did you forget to add/commit config.go?

Yup, this is why you don't rush to get things done on a Saturday morning.

/test all

/test integration_rhel

lgtm

I am going to merge this and then cleanup the comment in the other patch I just created.

@rhatdan, when GOPATH is not set, this change introduces build regression
$ make conmon
make -C conmon
make[1]: Entering directory '/mnt/tests/kubernetes/install/local-cluster-up/cri-o/conmon'
go run config.go
config.go:8:2: cannot find package "github.com/sirupsen/logrus" in any of:
	/usr/lib/golang/src/github.com/sirupsen/logrus (from $GOROOT)
	/mnt/tests/kubernetes/install/local-cluster-up/cri-o/_output/src/github.com/sirupsen/logrus (from $GOPATH)
make[1]: *** [Makefile:15: config.h] Error 1
make[1]: Leaving directory '/mnt/tests/kubernetes/install/local-cluster-up/cri-o/conmon'
make: *** [Makefile:73: conmon] Error 2

Could the conmon/Makefile do the same vendor setup / magic as the top level Makefile does?

https://github.com/kubernetes-incubator/cri-o/pull/1441 is fixing the problem for me.


Support vision camera v4

Support vision camera v4

I just realized there are several PRs here that I didn't notice, sorry! I guess GitHub forces you to explicitly "watch" your own repos to get these notifications? Anyways, it looks like you've created your own fork and published this to NPM already. I'm happy you were able to get this to work, and thanks for making the PR to let me know about it.


Display a loading spinner on Log in button

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Currently if a user clicks on Log in it does not show any loading status

Describe the solution you'd like
A clear and concise description of what you want to happen.

Display a loading spinner on Log in (from react-bootstrap) between user click and server response period.
Do not forget to hide/disable the spinner after you receive a response from the server.

Additional context
Add any other context or screenshots about the feature request here.

frontend/src/pages/LoginPage.js:55
This won't be a straightforward react state update task as you might have to modify frontend/src/context/AuthContext.js and pass extra props in order to achieve this task.

Heyo!
May I take this on?

Sure @lejara


[FLOC-1555] Container with dataset

https://clusterhq.atlassian.net/browse/FLOC-1555
Depends on #1218 being merged for nice diff.
There's no acceptance test because it's a pain to do lacking e.g. ability to poll for currently running containers. So will want to return to it later when it's easier. Or, ideas welcome.

Merged master in to this branch and resolved conflicts to make the diff easier for review.

Thanks. There are a few minor optional comments to address if you want to, otherwise merge.

There's no acceptance test because it's a pain to do lacking e.g. ability to poll for currently running containers. So will want to return to it later when it's easier. Or, ideas welcome.

Can you file an issue for adding this and mark it as blocking FLOC-1139 so we don't lose track of the remaining work?

There's a blocking acceptance issue I filed yesterday... FLOC-1567.


HDFS-15500. In-order deletion of snapshots: Diff lists must be update only in the last snapshot

See https://issues.apache.org/jira/browse/HDFS-15500

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
31m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
28m 50s
trunk passed

+1 :green_heart:
compile
1m 17s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
1m  9s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 52s
trunk passed

+1 :green_heart:
mvnsite
1m 20s
trunk passed

+1 :green_heart:
shadedclient
16m 13s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 50s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 26s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 58s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 56s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
1m  1s
the patch passed

-0 :warning:
checkstyle
0m 43s
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 185 unchanged - 0 fixed = 186 total (was 185)

+1 :green_heart:
mvnsite
1m  8s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
2m 30s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 18s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
2m 58s
the patch passed

_ Other Tests _

-1 :x:
unit
133m 39s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s
The patch does not generate ASF License warnings.

235m 18s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics

hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy

hadoop.hdfs.TestDFSStripedOutputStream

hadoop.hdfs.TestReadStripedFileWithMissingBlocks

hadoop.hdfs.TestEncryptionZonesWithKMS

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2233

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux fb60895c474a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9b9f7ea16a2

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/testReport/

Max. process+thread count
3644 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@szetszwo , can you take care of the checkstyle issue?

./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:1574:    assert assertsEnabled = true; // Intentional side effect!!!:27: Inner assignments should be avoided. [InnerAssignment]

@bshashikant The checkstyle issue is intentional as stated in the comment.  That is the way to check if assert is enabled in the code.


Review dotnet build documentation

https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-build

@BillWagner @mairaw Was this label approved? Accidental add by @dsplaisted perhaps?

@Thraka I'm unaware of this label.

The label is intentional.  The CLI team is going to go through the CLI documentation topics and review them to see if they're up-to-date, accurate, etc.  I discussed using a project in this repo to track this with @mairaw, though I don't know if I specifically discussed creating a new label.


chore(main): release 3.3.0

:robot: I have created a release beep boop
3.3.0 (2024-09-18)
Features

:sparkles: /terminal slash command (43a9f0c)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.3.0
:sunflower:


Implement fetch sec-filings

Implement #2007 . @dmoklaf give feedback - can structure be improved more? How do you use the data?

I use these  exactly like news - to suggest recent changes that could explain sudden moves in the stock price. Thus what matters are primarily the date, type of form / title, and URL to get more details (in this case, the EDGAR URL).

Try it #1080

Works perfectly ! Bravo


[Feature] update dynamic graph construction for graph2seq

Description
Updated dynamic graph construction (i.e., graph topology construction and embedding construction disentanglement) for graph2seq
Checklist
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [$CATEGORY] (such as [Doc], [Feature]])
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented
[x] To the my best knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[ ] If the PR is for a new model/paper, I've updated the example index here.

Dynamic graph's modification.


GetFontOffset Native

getFontOffset needed for the space demo. For native, it needs the context. So, it gets forwarded for a few methods.
Native part : https://github.com/BabylonJS/BabylonNative/pull/1002

Changing plan. I'll modify the demo instead.


Add docker container flows

Builds and pushes images for astria-conductor and astria-sequencer-relayer.
Builds are done when any of following occur

pull requests where there are changes in corresponding folders, or to the workflow file.
when tagged releases of format v{major}.{minor}.{patch}--{component-name} are created

Fixes #42

I lean bothways when it comes to the tags (i.e. release a global tag for all images to ensure they play together vs. tagging the services/binaries individiually). I can see the lock-step as being an advantage.

@SuperFluffy My argument here would be that using a single tag to release all packages breaks semantic versioning.
Practically, sequencer-relayer and conductor are highly linked, but we need a tagging strategy that works across anything in monorepo. I don't want to release a new minor version of the sequencer and thus a new major version of our EVM rollup even if there are no breaking changes to the EVM.
The tagging format I've gone with fits within semver regex, and I believe (could be wrong) will auto work with the tagging functionality that exists in the docker actions. I'm working on figuring out how to test this.


Add deprecation warning for govuk-colour's legacy parameter

We missed deprecating the $legacy parameter of the govuk-colour mixin when we deprecated the other legacy colour palette code in v4.4.0. As we want to remove this parameter in v5, we should deprecate it beforehand.
This doesn't use our usual _warning mixin due to mixins not being allowed within functions.

Decided not to do a v4.6.x patch release at this time, as it would involve some refactoring to split govuk-colour into public and private variants so that we can suppress internal warnings.
We'll revisit it if we find other reasons to do a v4 patch or feature release in future.


[5.2] Apply a middleware only once

As discussed in: https://github.com/laravel/framework/issues/12877, https://github.com/laravel/framework/pull/12879, and https://github.com/laravel/framework/pull/12903.
This PR makes a single middleware applied only once on a single route, I can't think of a scenario where applying a middleware multiple times on the same route is useful.

Something wrong with travis:
Could not load package shopware/shopware in http://packagist.org: [UnexpectedValueException] Could not parse version constraint ~v2.0.0-rc1: Invalid version string "~v2.0.0-rc1"

Please rebase and force push, and that'll fix travis.


Added a README example of using the pack-mock-server as a stub.

Hi,
You have a great tool here that I nearly ignored and reimplemented due to lack of documentation! :-)
I don't mind if you don't use this change, or if you correct / expand / rewrite it, but please do the poor souls trying to use your lovely software a favour and put in something like this in for us. Also if I've got it wrong please god tell me because it took me ages to piece together it's usage - simple as it is.
I'm not a ruby developer so picking through the source code and trawling google groups for clues was not fun. What I (and people like me) need is simple, vanilla usage examples - hence why I've used curl. You have an example of starting the server but I was like "Great! Now what...?" :-)
I still have no idea what else pact mock service can do!
As a side note, again not being a Ruby developer I tried downloading the standalone release, expanded the zip, recoiled in terror at the volume of stuff in there, and decided it was be less hassle and more obvious to install Ruby with homebrew. I wonder if it would be possible to boil standalone releases down to less files or reorganise the folder structure so that it was blindingly obvious what to do with it. e.g. an executable (the only bit I care about - could even be a shell script to invokes the app delegating arguments to the real programme?), a readme and a folder containing all the other stuff / dragons / voodoo.
Thanks and keep up the good work, I'll be looking at pack broker later so you might get another one of these...
Dave

Hi Dave,
Thanks for your PR. While this will work to a certain extent, the mock service is not designed to work this way, and there may be some unexpected issues. Please read this FAQ: https://github.com/realestate-com-au/pact/wiki/FAQ#why-are-the-pacts-generated-and-not-static
I will merge your PR, but add some caveats about it not being the intended use case.
I agree, the standalone package is unfortunately large. It is created using Travelling Ruby, which bundles a version of Ruby inside the package. There's no way to make that smaller that I know of.
The lack of documentation for how to set up interactions manually is because there aren't many people who use it that way. It's generally used with either the Ruby client or the Javascript client, both of which have fairly comprehensive documentation. Are you after something like this gist? https://gist.github.com/bethesque/9d81f21d6f77650811f4

Also, you don't need the X-Pact headers when you're actually executing the request, only when you're setting it up.

Hi Beth,
Thanks for the update. Thing is, and I'm not trying to be difficult - but that stuff doesn't actually work for me... I mean quite literally not philosophically, I get errors. :-)
Are you running a newer version or something?
If I run the mock with the control param then I can use it (as submitted) but I have to supply the headers that you've taken off. If I don't run with control then it won't accept a call to PUT / interactions, and if I switch it for a POST and change the headers as per your example I get this:
curl -X POST
-H "Content-Type: application/json"
-H "X-Pact-Mock-Service: true"
-d @pacts/ExampleConsumer-ExampleProvider.json
http://localhost:1234/interactions
Results in:
E, [2016-01-12T14:50:12.259847 #16406] ERROR -- : Error ocurred in mock service: NoMethodError - undefined method []' for nil:NilClass   E, [2016-01-12T14:50:12.259915 #16406] ERROR -- : /Users/DaviSmi5/.gem/ruby/2.1.3/gems/pact-support-0.5.4/lib/pact/consumer_contract/interaction.rb:22:in from_hash'
/Users/DaviSmi5/.gem/ruby/2.1.3/gems/pact-mock_service-0.8.0/lib/pact/mock_service/request_handlers/interaction_post.rb:24:in respond'   ...more stacktrace...   {"message":"Error ocurred in mock service: NoMethodError - undefined method []' for nil:NilClass"...
Thank you for the gist, I haven't tried running it as is (sorry I'm just between meetings...) but I shall as soon as I can. In theory it is exactly what I was looking for.
Any ideas?
Thanks,
Dave

I think you may be getting confused between the mock server and the control server. The control server can be used for the administration of one or more mock servers. It accepts only "administration" requests. You send the POST or PUT to /interactions, and it will return a header with the location of the mock server. You then run the tests against that location.
If you just use a mock server directly (which is the normal way), then you need the X-Pact-Mock-Service header to tell the mock server that a given request is an "administration" request, rather than a request from the actual code. When code under test runs, the lack of the X-Pact-Mock-Service header tells the mock server that it is a "real" request.
Please try the gist and let me know if that doesn't work.

Hi Beth,
Thanks for the update.
I was trying to use it in the normal way (your second paragraph) and I also thought I might be confused! ...but what you describe is actually exactly what I thought was supposed to happen. I just couldn't make it work.
However, your gist seems to work perfectly so I'll compare it with mine and debug from there.
Thanks again,
Dave

Ok I've sussed it. I was trying to upload the pact file that was output by the Pact-JVM specs2 lib. The pact file in your example is more cut down. For example this is the pact-jvm output that doesn't work:
{
  "provider" : {
    "name" : "ExampleProvider"
  },
  "consumer" : {
    "name" : "ExampleConsumer"
  },
  "interactions" : [ {
    "providerState" : "Provider service is available",
    "description" : "a request for a greeting",
    "request" : {
      "method" : "GET",
      "path" : "/hello"
    },
    "response" : {
      "status" : 200,
      "body" : "Hello there!"
    }
  } ],
  "metadata" : {
    "pact-specification" : {
      "version" : "2.0.0"
    },
    "pact-jvm" : {
      "version" : "3.0.4"
    }
  }
}

...but this works exactly as you said it should.
{
  "providerState" : "Provider service is available",
  "description" : "a request for a greeting",
  "request" : {
    "method" : "GET",
    "path" : "/hello"
  },
  "response" : {
    "status" : 200,
    "body" : "Hello there!"
  }
}

More stuff for the README.md? ;-)

Yes, POST to /interactions only accepts one interaction. PUT to /interactions accepts a list of interactions. Neither of them were designed to accept a "pact file".

I've put in a link to the gist in the README, and taken out the instructions that didn't work for now so they don't mislead anyone.

Yep, again I still hadn't realised that you can use PUT to upload a list - might be work adding to the Gist.
Right, I'll leave you alone Beth. Thank you for all the help, we got there in the end. :+1:


cleanup(dns-records) remove cert.ci.jenkins.io record (managed in jenkins-infra/azure)

Related to https://github.com/jenkins-infra/helpdesk/issues/3688, this PR removes the managed DNS record from this repository in favor of https://github.com/jenkins-infra/azure/blob/58e52440a4ba252afb140064a0667fafebe6d4fc/cert.ci.jenkins.io.tf#L62-L68
(otherwise both projects are competing to control this record and its value).

Plan: 0 to add, 0 to change, 1 to destroy. as expected


Need more details on a step in the tutorial setup

There's a step in the tutorial setup that needs to be more specific. I've had so many problems getting your vanilla tutorial to start (Angular2 noob).

It's not really obvious at all which directory you should be in to run npm install angular2-google-maps --save

It says cd my-maps-project. This means that you're changing directory to that project. So you should be in the correct folder by the point in which you need to run npm install.
Or am I misunderstanding something?

You must be in the directory where your package.json file is located.


[WIP] templates: Add documentation_search template, and make sure it renders.

https://github.com/zulip/zulip/issues/5803
Testing Plan:
I'll also figure out how to add automated tests for this - both in making sure that something renders for both /help/ and /api/, and to make sure that the right search results are returned for a relatively stable page. I'll also do some manual testing.
GIFs or Screenshots:
I'll add these later

@Lyla-Fischer cool!  @synicalsyntax can you give this a review?

Looks like this PR is still WIP; @Lyla-Fischer can you let me know when this PR is complete and resolved of its merge conflicts? I'd be happy to take a look then :)

ya, sorry this is getting stale. I've gotten distracted by my non-zulip project, which is re-launching at the World Maker Faire this weekend!

@Lyla-Fischer any chance you have time to update this?

Yes. Sorry I've been out of it again, but I'll try to do this by the end of the weekend.

Because the source repository for this pull request was deleted, this pull request has been automatically closed by GitHub as an unintended side effect of renaming our default Git branch. If this change is still desired, please open a new pull request, referencing this one in the description.


Value Area Not Colored

Package works.  Appreciate efforts to replace ColorHighlighter.
However, Value Area is being highlighted but not coloured (see below)
As previously asked, it would also be nice to be able to alter the way value highlighting is done, with say an underline etc.
Thanks again!
Version: 1.2.0
Sublime Build: 3176
OS: MacOS 10.12.6 (Sierra)
Settings: All true

What is your color scheme? Are there any errors in the console? Please try restarting Sublime Text and/or “resetting” ColorHighlight from the command palette.

Same issue over here:
Build 3176
Mojave


fix(HLS): Report HLS playlist updates as media playlist in network filters

@theodab can you review again? Thanks!


Requirements added

Coverage remained the same at 32.935% when pulling 7ec3a6d989f62aeaa48269a5533ccab7f97b35eb on AntonP1337:master into ac071d03dc93133cae1752f91af9e3e6e5dc939e on failys:master.

Remove the path from the rich_picture element, i.e. <rich_picture image="scopeDiagram.jpg" />
When the model is imported, the image directory can be set so this path will be set then without hardcoding it here.

Asset name “CCVTV Cameras” should be “CCTV Camera”.  In general, asset names should be singular not plural.

Asset “CCTV Recordings” should be “CCTV Recording”

I would suggest renaming “Passenger’s Bag” to “Passenger Luggage”

The vulnerability "Reduced survallance[sic] and security capacity" is a corollary of something else.  What is the cause of this reduced capability - that is your vulnerability.

The “Disclosure of confidential health records” is, strictly speaking, a risk resulting from some threat and vulnerability coming together.  In this case, I think the vulnerability should be something like “Health record visible”

The “Lack of defined business process” is really a vulnerability rather than a threat.  It would only be a threat if Maria did something that would be successful because of the lack of defined process.  Also, when you do define this as a vulnerability, you should be specific about what actual process should be defined, as some processes may be easier to define than others.

The “Increased risk of theft” should be called Theft.  Also, if you have done a PESTLE analysis of Balkan Rail it would be great if we could incorporate elements of this into the model.  Also, I don’t think Jack is concerned with ‘availability’ rather than ‘unlinkability’.

You have two requirements with the name “CCTV Installation”.  You should rename the first one of these to something more relevant, i.e. “CCTV camera placement”


[Bug]: Sourceforge Download Site not available

What happened?
The sourceforge download site https://nchc.dl.sourceforge.net appears to be unavailable, causing problems when trying to download apps such as WinSCP and KeePass using the URI provided by Get-EvergreenApp.  Not sure if this is a temporary problem with the nchc.dl.sourceforge.net site or if sourceforge URI's provided by Evergreen need amending to point at a different sourceforge downloads destination?
Version
2303.789
What PowerShell edition/s are you running Evergreen on?
Windows PowerShell
Which operating system/s are you running Evergreen on?
Windows 10
Have you reviewed the documentation?

[X] Troubleshooting at: https://stealthpuppy.com/evergreen/troubleshoot/
[x] Known issues at: https://stealthpuppy.com/evergreen/issues/

Verbose output
Get-EvergreenApp -Name WinSCP | Test-EvergreenApp

Result URI
------ ---
 False https://nchc.dl.sourceforge.net/project/winscp/WinSCP/5.21.8/WinSCP-5.21.8-Setup.exe

Get-EvergreenApp -Name KeePass | Test-EvergreenApp

Result URI
------ ---
 False https://nchc.dl.sourceforge.net/project/keepass/KeePass%202.x/2.53.1/KeePass-2.53.1.msi
 False https://nchc.dl.sourceforge.net/project/keepass/KeePass%202.x/2.53.1/KeePass-2.53.1-Setup.exe

Manually downloading KeePass returns ixpeering.dl.sourceforge.net right now. Unfortunately SourceForge doesn't provide a good way to return mirrors. Hopefully this is temporary.
WinSCP looks to have a new download location, so it might be time to update that application.

Hi Aaron, appreciate the quick investigation and all the work you do on Evergreen.  I would assume all the following Evergreen Apps would be impacted:
Application  Endpoints

7zip         nchc.dl.sourceforge.net
gretl        nchc.dl.sourceforge.net
KDiff3       nchc.dl.sourceforge.net
KeePass      nchc.dl.sourceforge.net
ProjectLibre nchc.dl.sourceforge.net
SAGAGIS      nchc.dl.sourceforge.net
VeraCrypt    nchc.dl.sourceforge.net
WinSCP       nchc.dl.sourceforge.net
Hopefully the nchc mirror will be back online soon.

So KeePass would go from:
Version Architecture Type URI
------- ------------ ---- ---
2.53.1  x86          msi  https://nchc.dl.sourceforge.net/project/keepass/KeePass%202.x/2.53.1/KeePass-2.53.1.msi
2.53.1  x86          exe  https://nchc.dl.sourceforge.net/project/keepass/KeePass%202.x/2.53.1/KeePass-2.53.1-Setup.exe

to:
Version Architecture Type URI
------- ------------ ---- ---
2.53.1  x86          exe  http://ixpeering.dl.sourceforge.net/project/keepass/KeePass%202.x/2.53.1/KeePass-2.53.1-Setup.exe

I've added a branch to test this result: 082f09031000d2a3521a45c28ac92bc5fb6dbc2d
This works OK, but returns only the file defined in best_release.json that SourceForge uses to define the primary download for a specific project.

Would be a shame not to have the other installer types available but probably preferable to have a more reliable download source for the main installer. So personally, I'd be happy with that update - but Deyda will probably need to implement some changes to NeverRed, as he currently uses the msi for KeePass.
Many thanks.

This is a bummer. Would it be possible to add 7-zip's own download URLs directly if SourceForge now won't support the different installation types, like MSI?

Get-GitHubRepoRelease has a -ReturnVersionOnly parameter - that value is then used in defining a URL to binaries hosted elsewhere, so the SourceForge function could be updated to do the same

It seems things have changed a bit since yesterday. I don't have that mu knowledge into how SF functions, but at least the URL returned by Get-EvergreenApp now takes you to a web page that responds:
https://sourceforge.net/projects/sevenzip/files/7-Zip/22.01/7z2201-x64.msi/download?use_mirror=netcologne
However it's not exactly the setup file you get, if you attempt to simply download the "expected" file from the URL.

Here's how the release can be resolved without hard coding anything other than the best_release.json - this approach would be ideal:
$BestRelease = Invoke-RestMethod -Uri "https://sourceforge.net/projects/sevenzip/best_release.json"
$httpWebRequest = [System.Net.WebRequest]::Create($BestRelease.platform_releases.windows.url)
$httpWebRequest.MaximumAutomaticRedirections = 3
$httpWebRequest.AllowAutoRedirect = $true
$Resolved = $httpWebRequest.GetResponse()
$Resolved.ResponseUri.AbsoluteUri

The version number is captured from the response in $BestRelease, so like the GitHub function, I can return just the version number from that JSON response, and then hard code the URLs into Evergreen and do a string replace on the version number to get to https://www.7-zip.org/a/7z2201-x64.exe.
Now if only we could get the vendors to stop using the hot steaming pile of shite that SourceForge is...

Here's what can be returned from SourceForge by returning only the installer defined in best_release.json:
Version      : 22.01
Architecture : x64
Type         : exe
Size         : 1575742
Md5          : a6a0f7c173094f8dafef996157751ecf
URI          : http://ixpeering.dl.sourceforge.net/project/sevenzip/7-Zip/22.01/7z2201-x64.exe

Here's what will be returned after adding the -ReturnVersionOnly parameter to Get-SourceFourceRepoRelease and hardcoding the URLs from the 7zip site:
Version Architecture Type URI
------- ------------ ---- ---
22.01   x64          exe  https://www.7-zip.org/a/7z22.01-x64.exe
22.01   x86          exe  https://www.7-zip.org/a/7z22.01.exe
22.01   ARM64        exe  https://www.7-zip.org/a/7z22.01-arm64.exe

This would then be similar to the other applications that use SourceForge.

Is there a way to also include the MSI file in the above output?

I rethought through the solution and how get this:
Version      : 22.01
Architecture : x64
Type         : msi
Size         : 1912320
Md5          : 50515f156ae516461e28dd453230d448
URI          : http://ixpeering.dl.sourceforge.net/project/sevenzip/7-Zip/22.01/7z2201-x64.msi

Version      : 22.01
Architecture : x64
Type         : exe
Size         : 1575742
Md5          : a6a0f7c173094f8dafef996157751ecf
URI          : http://ixpeering.dl.sourceforge.net/project/sevenzip/7-Zip/22.01/7z2201-x64.exe

Version      : 22.01
Architecture : ARM64
Type         : exe
Size         : 1607459
Md5          : 8db963c7d47f982df0723ea8c0599a9e
URI          : http://ixpeering.dl.sourceforge.net/project/sevenzip/7-Zip/22.01/7z2201-arm64.exe

Version      : 22.01
Architecture : ARM32
Type         : exe
Size         : 1658438
Md5          : 109aafc5593286a951c1046658d120ba
URI          : http://ixpeering.dl.sourceforge.net/project/sevenzip/7-Zip/22.01/7z2201-arm.exe

Version      : 22.01
Architecture : x86
Type         : exe
Size         : 1290308
Md5          : 734e95cdbe04f53fe7c28eeaaaad7327
URI          : http://ixpeering.dl.sourceforge.net/project/sevenzip/7-Zip/22.01/7z2201.exe

Version      : 22.01
Architecture : x86
Type         : msi
Size         : 1490432
Md5          : b25400614f24ebd0b76421e596ee18c6
URI          : http://ixpeering.dl.sourceforge.net/project/sevenzip/7-Zip/22.01/7z2201.msi

KeePass:
Version      : 2.53.1
Architecture : x86
Type         : exe
Size         : 4408888
Md5          : 0f6def7c3a9ea84e45768b7a02d2cabc
URI          : http://ixpeering.dl.sourceforge.net/project/keepass/KeePass%202.x/2.53.1/KeePass-2.53.1-Setup.exe

Version      : 2.53.1
Architecture : x86
Type         : msi
Size         : 3789312
Md5          : 9687c510596ca019c2d7b25e39aeb50d
URI          : http://ixpeering.dl.sourceforge.net/project/keepass/KeePass%202.x/2.53.1/KeePass-2.53.1.msi

Change pushed to development branch so that you can test it out if you like 53c7d38338714b886bb6998a2507e6a3848b4e78
I'll update a release in the next 24 hours

Fix released in v2304.791

New release seems to be working nicely. Think this issue can be closed? Many thanks.

Reopening this as the downloads aren't redirecting to the right place


Add linting pre-commit hooks

Is your feature request related to a problem? Please describe.
Developers should have a seamless PR experience, and the repo should always be left formatted per our standards. Developers can currently push improperly formatted code to the repo.
Describe the solution you'd like
Add in something like husky to make sure developers know their code is in the proper state before it moves on to the next step.

This issue is dependant on #52


Add annotations param to create_model function

i was generating some pydantic models from proto models and ran into this issue, when i encountered non-default fields
import pydantic
SimpleModel = pydantic.create_model('SimpleModel', foo=(str, 'bar'))
very_important_field_description = '''Very important description, for non-default field, which will cause
                                   failure on model creation ;('''
Boom = pydantic.create_model('Boom', bar=pydantic.Field(..., description=very_important_field_description))

Traceback (most recent call last):
File "/Users/urm8/Library/Application Support/JetBrains/PyCharm2020.1/scratches/scratch_28.py", line 8, in
Boom = pydantic.create_model(
File "/Users/urm8/Documents/pydantic/pydantic/main.py", line 856, in create_model
return type(__model_name, (base,), namespace)
File "/Users/urm8/Documents/pydantic/pydantic/main.py", line 280, in new
inferred = ModelField.infer(
File "/Users/urm8/Documents/pydantic/pydantic/fields.py", line 309, in infer
return cls(
File "/Users/urm8/Documents/pydantic/pydantic/fields.py", line 271, in init
self.prepare()
File "/Users/urm8/Documents/pydantic/pydantic/fields.py", line 344, in prepare
self._set_default_and_type()
File "/Users/urm8/Documents/pydantic/pydantic/fields.py", line 375, in set_default_and_type
raise errors.ConfigError(f'unable to infer type for attribute "{self.name}"')
pydantic.errors.ConfigError: unable to infer type for attribute "bar"

Added annotations param to fix this. (I was suprised FieldInfo has no info about field type :( )
NoBoom = pydantic.create_model(
    'NoBoom',
    annotations={'bar': SimpleModel},
    bar=pydantic.Field(..., description=very_important_field_description,))

Change Summary
Add optional annotations param in create_model function
Related issue number
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

Hello @urm8
I don't understand your PR. I would have loved to first have an opened issue to discuss your problem
From what I see it's pretty normal that you get your error. You try to do (I write with BaseModel instead of create_model to be more explicit)
from pydantic import BaseModel, Field

class SimpleModel(BaseModel):
    foo: str = 'bar'

class Boom(BaseModel):
    bar = Field(..., description='xxx')

which generates the error
pydantic.errors.ConfigError: unable to infer type for attribute "bar"

What you want to do is just add the type of bar
class Boom(BaseModel):
    bar: SimpleModel = Field(..., description='xxx')

To do the same with create_model, it's in the documentation. You are supposed to give a tuple with the type and the default value. So here you would write
SimpleModel = create_model('SimpleModel', foo=(str, 'bar'))
Boom = create_model('Boom', bar=(SimpleModel, Field(..., description='xxx')))

Fields are defined by either a tuple of the form (<type>, <default value>)

oh, my bad, I thought <default value> in tuple may only be concrete value like 123 or SimpleModel(foo='thing') not FieldInfo instance.


feat(circleci): add circleci plugin

Summary
Add circleci plugin.
cicd_scopes corresponding to circleci project
cicd_pipelines  corresponding to circleci workflow
cicd_pipeline_commits  corresponding to circleci vcs
cicd_tasks  corresponding to circleci job
Does this close any open issues?
Closes #4633
Screenshots

Other Information
Any other information that is important to this PR.

Great job! @coldgust , I will review this asap

Hi @warren830, I have joined the wechat group.

@coldgust Great, can you send me a msg(you can find me by @nirvana within the group), we want to issue you a certificate.

@coldgust Still some issues for e2e, please check, thanks/


fix: fine tuning ad fixes

Q
A

Branch?
main for features / current stable version branch for bug fixes

Tickets
#...

License
MIT

Doc PR
api-platform/docs#...

Thanks @malikalahfaoui!


prepare.lm.done overwritten on load graph

The prepare.lm.done property appears to be overwritten in GraphHopper.loadOrPrepareLM during loading a landmark graph.
The graph properties file has the correct enty prepare.lm.done=true.
Reading directly the properties file, the property comes with right true value.
But if loading the graph and use the getProperties() to retrieve it, then the property comes false.
This is probably due to tmpPrepare being false.

Okay, we should do this 'done=true' only if it did some work. The difference here to CH is that CH data is loaded with the graph and for LM we need to load it separately if it was already created.


chore: upgrade prom-client from 11.x to 12.x and update tests.

Upgrade prom-client from 11 to 12.
Update tests for prom-client 12.0.0: metrics are collected on scrape of metrics endpoint, not on an interval.
Update tests for prom-client 12.0.0: Cannot add the default metrics twice to the same registry
Refactor integration tests based on different server/configuration.

We also need to update engines in package.json to node >= 10 and that would be a good time to add a CHANGELOG.md file before releasing this version,

As we have here a breaking change,I also guess it would be a good time to add a CHANGELOG.md file before releasing this version.
It would nice to add engines in package.json with node >= 10.


Sync stack policies 2

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes have been detected in com.azure:azure-core-management. You can review API changes here
API changes
+         @Override public boolean authorizeRequestOnChallengeSynchronously(HttpPipelineCallContext context, HttpResponse response)
+         @Override public void authorizeRequestSynchronously(HttpPipelineCallContext context)

API changes have been detected in com.azure:azure-core-test. You can review API changes here
API changes
+         @Override public BinaryData getContent()

API changes have been detected in com.azure:azure-core-tracing-opentelemetry. You can review API changes here
API changes
+         @Override public HttpResponse processSynchronously(HttpPipelineCallContext context, HttpPipelineNextPolicy next)

API changes have been detected in com.azure:azure-core. You can review API changes here

API changes have been detected in com.azure:azure-core. You can review API changes here


Change font and font-size for Zen

It seems like it should be possible to change the font face and size for the editor in Zen using user styles but I can't seem to get it to work. Is this currently possible?

:+1:  for a settings option.
Note for other googlers; this is now:
[data-zen="true"] {
    atom-text-editor:not(.mini) {
        font-size: 24px;
    }
}

Well, it is for me :wink:
Atom: 0.201.0 | Zen: 0.14.0

Yes that would work. Settings options for packages can't change values in the stylesheets, they can only apply inline styles (or mess about with changing your actual config values). So using your personal stylesheet for this is actually preferable over all other options.


Add Radio Paradise to the list of merchants

What's the name of your business?
Radio Paradise
What's the URL of the website?
https://radioparadise.com/
Write a brief description of your business/service (max 50 characters)
Listener supported & always 100% commercial free on-line radio
Enter the URL where a Monero mention can be found
https://payments.radioparadise.com/?f=crypto
How do you accept Monero? (choose only one option)

[ ] Monero integrations (github.com/monero-integrations)
[ ] Globee
[x] Native wallet
[ ] Other payment gateaway (Coinpayments, Morphtoken, etc. Please specify)

How would you categorize your business? (choose only one option)

[ ] Exchange
[ ] Block Explorer
[ ] Payment Gateway
[ ] Web Hosting
[ ] Tool
[ ] Service
[ ] Goods
[x] Entertainment

Comment

I'm not sure this radio would qualify as "merchant". Looks more like it's a project distributed for free, that users can support by donating Monero. If that's the case i don't think the merchant page is the correct place to list this. We only have the "tools" section which is an exception to the rule (and IMO should be removed from the merchants page).

Fair enough. I just happened to be listening to them while working and they had a blurb mentioning crypto currency as a way to support them and when looking into it, found Monero as an alternative. I thought it was in the project's interest to list as many ways to spend monero as possible and added the suggestion here on Github.
Not sure whether they run the service as a business or not, but the listener-provided support appears to be used to cover costs and support the artists they play
https://payments.radioparadise.com/?file=crb

Hello. We recently changed the purpose of the "Merchants" page and now it doesn't list merchants anymore (see #1736), so we are going to close this issue. Now we list 2 merchants directories:

https://cryptwerk.com/pay-with/xmr/
https://www.acceptedhere.io/catalog/currency/xmr/

Consider requesting to be added to one of the directories above if your service fits.


Use NumberDeviceClass for temprature readwrite

Should fix https://github.com/albaintor/homeassistant_electrolux_status/issues/83
Catalog updates just because they align with the changes in api.py. Only api.py is the cause of the issue

Done, thanks