First-time null values taken as object attributes

Is your feature request related to a problem? Please describe.
When the first notification arrives with an attribute value of Null, QL creates a column for it of type null
Describe the solution you'd like
In those cases, don't commit to a data type and simply ignore the attribute.
Describe alternatives you've considered
Additional context

Hi @taliaga @c0c0n3 ,
I want to contribute in this issue.
Please confirm my below understanding:

Case 1: All the attributes have Null value.
Case 2: One of the attributes have Null value and all the others have valid values.

For case 1:  No value will be stored neither will table be created.
For case 2: Table will be created for the valid attributes and attributes with Null values are ignored. No column for that value is created.

Hi @pooja1pathak thanks for volunteering :-)
This gets confusing for me too so I'll try to state the problem a bit more precisely below, mainly for my own benefit so I'll be able to understand what's going on a year from now :-)
Call E = { e[1], ..., e[n] } the set of entities being notified to QL (i.e. what gets POSTed to /v2/notify) and T the set of DB tables we have when QL gets the notification. Also let's say we've got a test function:
known : Entity x Attr --> Bool
known(e, a) = T  just in case ∃ t ∈ T for e.type and ∃ column t.a

Then for each attribute a of e[k] (k = 1, ..., n)

If not known(e[k], a) and not has_value(e[k].a) (has_value as defined in the Reporter module), then do not store a. You can simply delete the attribute from the Python entity dictionary here.
In all other cases, i.e. when condition (1) is false, keep the attribute. Just leave it be, the existing code should take care of storing it in the DB.

The challenge here is to come up with an efficient implementation of that test function. We have a metadata table you can query. Ideally we should wrap all this in a transaction to avoid race conditions but given the current implementation of the notify endpoint, that's easier said than done. So if you agree I suggest we blissfully ignore race conditions---all that can happen anyway is that we won't store a "no-value" attribute we should've stored, not a big deal in my opinion.
For some more context see #241. The problem there is related but not the same.

@pooja1pathak @chicco785
After reviewing #298, I can't help thinking that maybe we shouldn't go down that road. Do we actually have cases of notifications in the wild where we get an attribute value of "Null" (i.e. a string containing the chars N, u, ...) as in
{
    "id": "nasty::1",
    "type": "Device",
    "state": { "type": "Text", "value": "Null" },
    "temp": { "type": "Number", "value": "Null" }
}

My understanding is that this issue got raised because of entities like this instead
{
    "id": "nasty::1",
    "type": "Device",
    "state": { "type": "Text", "value": null },
    "temp": { "type": "Number", "value": null }
}

Notice the JSON null value here as opposed to a string containing "Null" as word. The case of JSON nulls should already be covered by PR #278 which fixed #209.
Going back to the first example up there, I reckon we can all agree we can safely ditch something like this
"temp": { "type": "Number", "value": "Null" }

since the value here isn't even a number, but what about
"state": { "type": "Text", "value": "Null" }

Looks suspicious and most likely an error but how can we tell for sure? After all the value ("Null") is compatible with it's declared type (Text) and perhaps "Null" actually names a state the device can be in---e.g. it could stand for device not yet initialised, init error, etc.

Hi,
to be honest i don't recall how this issue was born.
is there are test were we can see it occurring? then maybe there is a
problem in the old pr and related test.
a similar issue, that is for sure something to think about is "dropping"
attributes that cannot be cast to the proper attribute format,
so we save at least the other values and don't reject the full message.
On Fri, 3 Apr 2020 at 14:35, c0c0n3<EMAIL_ADDRESS>wrote:

@pooja1pathak https://github.com/pooja1pathak @chicco785
https://github.com/chicco785
After reviewing #298
https://github.com/smartsdk/ngsi-timeseries-api/pull/298, I can't help
thinking that maybe we shouldn't go down that road. Do we actually have
cases of notifications in the wild where we get an attribute value of
"Null" (i.e. a string containing the chars N, u, ...) as in
{
"id": "nasty::1",
"type": "Device",
"state": { "type": "Text", "value": "Null" },
"temp": { "type": "Number", "value": "Null" }
}
My understanding is that this issue got raised because of entities like
this instead
{
"id": "nasty::1",
"type": "Device",
"state": { "type": "Text", "value": null },
"temp": { "type": "Number", "value": null }
}
Notice the JSON null value here as opposed to a string containing "Null"
as word. The case of JSON nulls should already be covered by PR #278
https://github.com/smartsdk/ngsi-timeseries-api/pull/278 which fixed
#209 https://github.com/smartsdk/ngsi-timeseries-api/issues/209.
Going back to the first example up there, I reckon we can all agree we can
safely ditch something like this
"temp": { "type": "Number", "value": "Null" }
since the value here isn't even a number, but what about
"state": { "type": "Text", "value": "Null" }
Looks suspicious and most likely an error but how can we tell for sure?
After all the value ("Null") is compatible with it's declared type (Text)
and perhaps "Null" actually names a state the device can be in---e.g. it
could stand for device not yet initialised, init error, etc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/smartsdk/ngsi-timeseries-api/issues/224#issuecomment-608408641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAF5YAVP5RX6LF2I3LMENPTRKXJXRANCNFSM4IETUWAA
.

don't recall how this issue was born.

Um, the plot thickens. I've got a faint recollection of Thomas explaining it to me and pointing the finger at JSON null but I never actually saw the culprit myself, so can't tell for sure. If my memory serves me well, it was some LORAWAN data he was struggling with.

is there are test were we can see it occurring?

Not that I know. I couldn't find anything like that.

"dropping" attributes that cannot be cast to the proper attribute format

Great idea! In fact, this is the second time you have it :-)) You asked me to open an issue a while back, see #241.

Hi @c0c0n3 , @chicco785
I have checked for the above, below is my observation:
CASE-1:
When we notify QL for an entity say Room with 2 attributes i.e., temperature and pressure as for the very first notification, temperature value is set null with type Number and pressure value is 15 of type Number. The notification successfully gets processed.
Entity is created in Crate DB as temperature with value "NULL" of type Number and pressure with value 15 of type Number.
In second notification, temperature value is set 25 with type Number and pressure value null with type Number. This time also, Notification is successfully processed.
Entity updated in Crate DB as temperature with value 25 of type Number, pressure with value "NULL" and type Number.
Now when I try to get entity for pressure and temperature using requests: /v2/entities/RoomTest1/attrs/pressure?aggrMethod=sum&aggrPeriod=hour and /v2/entities/RoomTest1/attrs/temperature?aggrMethod=sum&aggrPeriod=hour respectively.
I get value 15 as response for pressure and 25 for temperature. This is as per expected result.
This means the type of attribute is set to Number when first notification is received.
CASE-2:
When we notify QL for an entity say Room with 2 attributes i.e., temperature and pressure as for the very first notification, temperature value is set null with type Number and pressure value is 15 of type Number. The notification successfully gets processed.
Entity is created in Crate DB as temperature with value "NULL" of type Number and pressure with value 15 of type Number.
In second notification, temperature value is set 25 with type Text and pressure value null with type Number. This time also, Notification is successfully processed.
Entity updated in Crate DB as temperature with value 25 of type Number, pressure with value "NULL" and type Number.
Now when I try to get entity for pressure and temperature using requests: /v2/entities/RoomTest1/attrs/pressure?aggrMethod=sum&aggrPeriod=hour and /v2/entities/RoomTest1/attrs/temperature?aggrMethod=sum&aggrPeriod=hour respectively.
I get value 15 as response for pressure and 25 for temperature.
This means the type of attribute is set to Number when first notification is received and is not updated after that.
CASE-3:
When we notify QL for an entity say Room with 2 attributes i.e., temperature and pressure as for the very first notification, temperature value is set null without any type and pressure value is 15 of type Number. The notification successfully gets processed.
Entity is created in Crate DB as temperature with value "NULL" of type Text and pressure with value 15 of type number.
In second notification, temperature value is set 25 with type Number and pressure value null with type Number. This time also, Notification is successfully processed.
Entity updated in Crate DB as temperature with value 25 of type Text, pressure with value "NULL" and type Number.
Now when I try to get entity for pressure and temperature using requests: /v2/entities/RoomTest1/attrs/pressure?aggrMethod=sum&aggrPeriod=hour and /v2/entities/RoomTest1/attrs/temperature?aggrMethod=sum&aggrPeriod=hour respectively.
I get value 15 as response for pressure and No record found for temperature.
It may be because temperature is saved as Text and it is not updated when we add Type as Number.
In my opinion if for any entity value is null and no Type is defined then we should ignore that attribute without committing to any type. If this suggestion looks good to you, I can work in that direction and update my PR.

Hi @pooja1pathak, thanks for testing those scenarios :-)

CASE-1 ...
type of attribute is set to Number when first notification is received.
CASE-2 ...
type of attribute is set to Number when first notification is received and is not updated after that.

Spot on! That's how notifications work at the moment. #241 explains in more detail what happens under the bonnet---see problem section.

CASE-2 ...
In second notification, temperature value is set 25 with type Text and pressure value null with type Number. This time also, Notification is successfully processed.

I reckon that's because of implicit type conversions. The temperature column got created numeric in the first notification and the temperature value in the second notification is the string "25" which happens to be convertible to the integer 25.

CASE-3 ...
Entity is created in Crate DB as temperature with value "NULL" of type Text

Quantum Leap defaults attributes of unknown NGSI type to Text. Since an attribute DB column gets created the first time we see an attribute, if there's no NGSI type, the column winds up with a text type, I suppose.

CASE-3 ...
second notification, temperature value is set 25 with type Number... updated in Crate DB as temperature with value 25 of type Text

Implicit type conversions kicked in again I reckon.

CASE-3 ...
get entity for pressure and temperature... No record found for temperature

This is an instance of #296---single-table/one attribute scenario. Have a look at this comment over there for the details.

In my opinion if for any entity value is null and no Type is defined then we should ignore that attribute without committing to any type.

I like your suggestion. Let's put a bit more flesh on the bones of this. I'm going to use the same notation defined in my earlier comment, please have a look there for the details.
So what we want is this. For each entity e and attribute a
not known(e, a) and not has_value(e.a)  ===>  do not store a
otherwise                               ===>  do nothing

I've already mentioned the challenge here is to come up with an efficient implementation of the known function. But come to think of it, we can get pretty much the same desired outcome if we just delete a from e whenhas_value(e.a) = false and there's no type, i.e. if the implementation is
not has_value(e.a) and e.a.type is None  ===>  del e.a
otherwise                                ===>  do nothing

and that happens after calling  _filter_empty_entities. (At some point we should reimplement all this using stream processing so that we don't loop through the entity array one gazillion times, but I'll leave that for another day :-)
With the above implementation if an attribute comes in for the first time with no value and no type, we just ignore it as you suggested. If the attribute exists already in the DB and it comes in with no value and no type, by deleting it, we won't change much: the net result will still be a DB null for that field in the corresponding entity row. If we happen to delete all attributes (except for entity ID and type which we should never touch), then the insert should still work fine in both of the above scenarios---famous last words :-)
There's a side-effect though. An attribute won't be "queryable" until such a time we get notified of an actual value or a typed null/none. Until that time, the client will get a 404 when trying to retrieve it, e.g.
/v2/entities/RoomTest1/attrs/temperature. So 404 won't necessarily mean Quantum Leap never got notified of that attribute, but rather: Quantum Leap hasn't yet seen a value for that attribute or a typed null. In part this is happening already, so I don't think this is actually a big deal?

Thank you for the detailed explaination :-)
I am writing a new function which will get called after _filter_empty_entities to filter no_value and no_type attributes from the entities, as suggested by you.
I'll update my PR once it is done.

Thank you for the detailed explaination :-)

Pleasure! Thank you for the detailed report and suggestion!

I'll update my PR once it is done.

That's great, thanks a stack!

Hi @c0c0n3  I've updated my PR #298  as per our discussion.

Hi @pooja1pathak I've just merged your PR. Great stuff, thank you sooooo much!!
Closed by #298


Add task to dump Win32 resources

This task extracts Win32 resources from the main managed assembly into a RES file that we subsequently pass as input to the platform linker.
Fixes #5095.

          F:\vsagent\51\s\bin\Windows_NT.x64.Debug\build\Microsoft.NETCore.Native.targets(295,5): error MSB4018: The "DumpNativeResources" task failed unexpectedly. [F:\vsagent\51\s\tests_downloaded\CoreCLR\GC\Coverage\LargeObjectAlloc2\Test.csproj]
        F:\vsagent\51\s\bin\Windows_NT.x64.Debug\build\Microsoft.NETCore.Native.targets(295,5): error MSB4018: System.IO.FileNotFoundException: Could not load file or assembly 'System.Reflection.Metadata, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. [F:\vsagent\51\s\tests_downloaded\CoreCLR\GC\Coverage\LargeObjectAlloc2\Test.csproj]

This looks like a problem with binding redirects caused by running tests on .NET Framework. Adding https://github.com/ericstj/buildtools/blob/master/src/common/AssemblyResolver.cs to the CoreRT build task may fix it.

Adding https://github.com/ericstj/buildtools/blob/master/src/common/AssemblyResolver.cs to the CoreRT build task may fix it.

That unfortunately doesn't help - S.R.Metadata is a 64-bit PE file, so I just get BadImageFormat instead :(
I think Simon is working to get rid of the desktop MSBuild dependency for #7032, so this can wait for that.

That unfortunately doesn't help - S.R.Metadata is a 64-bit PE file,

https://github.com/dotnet/corert/pull/7146 should fix this part of the problem.

         D:\j\workspace\debug_windows---5721b50c\bin\Windows_NT.x64.Debug\build\Microsoft.NETCore.Native.targets(295,5): error MSB4061: System.TypeInitializationException: The type initializer for 'Build.Tasks.DesktopCompatibleTask' threw an exception. ---> System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. [D:\j\workspace\debug_windows---5721b50c\tests_downloaded\CoreCLR\GC\API\GCHandle\PinObj_neg\Test.csproj]

Great, the Jenkins CI machine uses some ancient version of the .NET Runtime. Maybe this can wait until we migrate off Jenkins then...


SOLR-16585: Fix NPE in MatchAllDocs pagination

See: https://issues.apache.org/jira/browse/SOLR-16585

Thanks everyone; committed and backported to branch_9x and branch_9_1.

It's worth to add some similar test case into. Solr examples/CLI smoke tests. Also, it's worth to add more variety into this test case.

Definitely; didn't want to delay getting something up though. Will look into building out testing further.

Hello, @magibney. I'm wondering if we have such test cases.

testMatchAllDocsPlain() was updated to hit a wide variety of offsets, in and out of range of the target docset. That's all for now, but that was the big gap that prevented catching this.
At a high level, what other combinations were you thinking should be tested? I don't actually think smoke tests add that much with this. Couldn't hurt; but the problem here was "no tests", not "no integration tests". As alarming as this regression was, I don't see anything inherent in this functionality to indicate a need for integration tests for this, any more than any other functionality.

@magibney what about https://github.com/apache/solr/pull/1378/files ?


Toggle cluster filters for mixing and matching instead of one at a time

Some logic to toggle filters on and off so multiple parameters can be mixed and match (instead of one at a time)

Hi @sibeshkar ,
Currently, on selecting any of the options from the filter panel (p2p, state, city, travel, age), only grouping of the clusters are changed but cluster data remains the same. In this case,  I feel  term "cluster filters" might be misleading.
Even if logic for toggling filters on and off is added to filter panel, user would still not be able to filter cluster data by state, city or age.
Having a separate control to filter cluster data might be helpful.
For example, filter cluster data by state "Maharastra" or filter cluster data by city "Pune".


_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 37s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-procedure in the patch failed.

I wonder how this manifests? On restart the procedure shows up as alive again?
Fix looks good though.

I asked Mei, the reporter of this jira, and she found it when reading code about HBCK. Let me add a UT to reproduce it.

@Joseph295 any progress on this nice fix?

I am trying to add ut, tried several times, but didn't succeed. on holiday now, will continue after holiday.

Its ok @Joseph295  The fix is 'obviously' correct. If hard adding test, that is ok. Enjoy your holday. Let me merge this.


Generate 1 click links based on part of the Title

I'd like to generate 1 clicks based on a word in the Title of a Team Backlog Item.
Is this possible?
So I have title: 'Implement blah'
Using JSON:
{
"applywhen": {
"System.WorkItemType": "Team Backlog Item",
"System.Title": "???"	}
}
Can I identify only the word 'Implement' somehow?

Anyone has a solution for this? would be really helpfull to be able to pull up specific templates based on user story names/id


Add port argument to controller deployment

port changing doesn't work

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/mychartname])

@silenceleaf
Would you mind to sign DCO and bump to latest version please? Thank you.

@silenceleaf
Would you mind to sign DCO and bump to latest version please? Thank you.

just clicked

@silenceleaf
Sign DCO instruction: https://github.com/helm/charts/pull/18464/checks?check_run_id=282315823


Changing find value doesn't update value searched

Current Behaviour
First find works great - search for all

Change find value and find next, uses original find value - - search for allo, finds all

Expected Behaviour
new find value used in search
Your Environment

Data Curator version: 0.14.0
Operating System and version:  macOS High Sierra 10.13.4

If Find panel is closed and reopened, this bug doesn't occur


Retrieve all users from keycloak in frontend

We need to be able to display a list of all the users that exists in keycloak with name (for displaying) and userId (for backend).

We need a function to get ALL users from keycloack


”Băcia”, ”Petreni”, ”Tâmpa”, ”Totia” are listed in the drop-down menu

Description:
When user writes ”Băcia”, ”Petreni”, ”Tâmpa”, ”Totia” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Băcia"

Expected results
The location appears in the drop-down menu as "Sat Băcia, HUNEDOARA (Băcia)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Petreni"

Expected results
The location appears in the drop-down menu as "Sat Petreni, HUNEDOARA (Băcia)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Tâmpa"

Expected results
The location appears in the drop-down menu as "Sat Tâmpa, HUNEDOARA (Băcia)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Totia"

Expected results
The location appears in the drop-down menu as "Sat Totia, HUNEDOARA (Băcia)".


Add new gitignore.

This PR adds new rules to .gitignore, so that it can maintain a clean git dictionary.
Checklist (can be deleted from PR description once items are checked)

[ ] New code is “linted” i.e. code formatting via rustfmt and language idioms via clippy
[ ] There are no extraneous changes like formatting, line reordering, etc. Keep the patch sizes small!
[ ] There are functional and/or unit tests written, and they are passing
[ ] There is suitable documentation. In our case, this means:

[ ] Each command has a usage example and API specification
[ ] Rustdoc tests are passing on all code-level comments
[ ] Differences between Rust’s IPFS implementation and the Go or JS implementations are explained

[ ] Additions to CHANGELOG.md files

Hi there @FledgeXu! Could you elaborate what files did the previous .gitignore miss, and on what platforms?

These files should be ignored in .gitignore_global instead of in .gitignore. So I will close this PR.


Infernal-router

[x] Deeply nested routes
[x] Server-side rendering
[x] Use browser history
[x] Use memory history
[x] Client side async routing
[ ] Server side async routing (is it even possible?)
[x] Get rid of wrapper component since you can now just nest routes
[x] Tests passing

Any requests ?

One more bug left...

Can you do programmatic rerouting? Ie. forward the the user to a specific route, for instance to a logout screen if the user gets logged out etc.

@svenanders
You should have history available on the context.
    componentDidMount() {
        // if (!userLoggedIn) ...
        this.context.history.push('/page/login')
    }

Let me know if you need any other features


fix cutting board block

display is wrong. and also collision box

collision / boundbox is done. display todo in blockbench

done.


rename /campaigns to users/campaigns

Fixes #138
Rename /campaigns to users/campaigns

I slept on the naming of this route and I still feel kinda iffy about it. What about user-campaigns/?
With users/ without a resource id following it, I think it suggests that it should return info for all users. I also wonder if there are any scenarios where this path could be technically problematic since it shares the same name as the main users path.

campaign-activity?  or activity/campaigns ?  (later we could have activity/games, etc)

or just campaigns games etc

Another suggestion would be using user/ as a "resource" for the current authenticated user, and user/campaigns for the list of all campaigns. This is how GitHub handles listing the current user repos vs. a specific user's repos.

Ah, probably why Andrea suggested user/campaigns in the first place. oops. That also works if we want to do user/games and the like later on.

awesome, thanks! Just changed it to user/campaigns

:+1:

Makes sense to me! :+1:


Omnisharp doesn't work properly

Everything works fine, except goto definition, perhaps the problem is that omnisharp uses -lsp flag, but should use -s as in OmniSharp/omnisharp-vim.

Works for me with the settings in config.md
https://user-images.githubusercontent.com/13316262/106802151-66ce2900-6617-11eb-93aa-b0f94041c809.mov

Duplicate of https://github.com/neovim/neovim/issues/13827


Can not have two parallel Polestar IDs anymore

I have two cars and two separate polestar IDs. Until 1.7.2 this worked fine but in 1.7.3 the second car is no longer available.

I can see that the integration can successfully authenticate with the first entry (tried to anonymize the logs a bit):
2024-10-24 16:25:02.083 DEBUG (MainThread) [custom_components.polestar_api] async_setup_entry: <ConfigEntry entry_id=79a8864e79aa908b1b02d47ca4cb1dff version=1 domain=polestar_api title=Magnus Polestar state=ConfigEntryState.SETUP_IN_PROGRESS unique_id=None>
<....>
2024-10-24 16:25:03.401 DEBUG (MainThread) [custom_components.polestar_api.pypolestar.auth] {'data': {'getAuthToken': {'id_token': None, 'access_token': 'eyJhbGciOiJSUzI1NiIsImtpZCI6IlVVdkRibjM5QkZkcklhUWR0ZXhFVHdfYkxEa19SUzI1NiIsInBpLmF0bSI6ImwifQ.eyJzY29wZSI6IiIsImNsa
<......>
2024-10-24 16:25:05.053 DEBUG (MainThread) [custom_components.polestar_api.pypolestar.polestar] {'data': {'getConsumerCarsV2': [{'vin': 'XXX', 'internalVehicleIdentifier': XXX, 'salesType': '82B', 'currentPlannedDeliveryDate': '2021-05-27', 'market': 'SE', 'originalMarket': 'SE', 'pno34': 'XXX', 'modelYear': '2021', 'registrationNo': 'TBA97R',

but then it seems to reuse the same authentication for the second car and of course gets the same API response back:
2024-10-24 16:25:10.963 DEBUG (MainThread) [custom_components.polestar_api] async_setup_entry: <ConfigEntry entry_id=90f0c8caa13aa5f0c56c2bcd2f2392ba version=1 domain=polestar_api title=Emma Polestar state=ConfigEntryState.SETUP_IN_PROGRESS unique_id=None>
<....>
2024-10-24 16:25:11.480 DEBUG (MainThread) [custom_components.polestar_api.pypolestar.auth] {'data': {'getAuthToken': {'id_token': None, 'access_token': 'eyJhbGciOiJSUzI1NiIsImtpZCI6IlVVdkRibjM5QkZkcklhUWR0ZXhFVHdfYkxEa19SUzI1NiIsInBpLmF0bSI6ImwifQ.eyJzY29wZSI6IiIsImNsa
<......>
2024-10-24 16:25:12.473 DEBUG (MainThread) [custom_components.polestar_api.pypolestar.polestar] {'data': {'getConsumerCarsV2': [{'vin': 'XXX', 'internalVehicleIdentifier': XXX', 'salesType': '82B', 'currentPlannedDeliveryDate': '2021-05-27', 'market': 'SE', 'originalMarket': 'SE', 'pno34': 'XXX', 'modelYear': '2021', 'registrationNo': 'TBA97R',

Do you have access to each others cars?

Should work before on old version:
https://github.com/pypolestar/polestar_api/issues/150

I deleted both integration entries and re-added one of them. Only one of the cars show up and when I try to add the second entry using the other polestar ID, it fails and cannot generate devices and sensors. Doesn't matter which one I start with.
I then downgraded to 1.7.2 and experience the same thing.
If I downgrade to 1.6.15, I do get both cars displayed as two devices under the same integration entry.

The challenge is most likely that both devices see both cars and there's nothing telling any of them which one to ignore?

I now deleted everything, restarted HA, and then installed the latest 1.7.3 version of the integration.
When I add the first entry using my polestar ID, only one car shows up. In the polestar app I see both.
When I add the second entry using the other polestar ID, it fails to create devices and sensors due to duplicate IDs.
Couldn't this mean that the api does indeed provide information on both cars, but that the integration only picks up the first of them?

I agree and believe the integration does not work as intended with multiple cars. Moving this to https://github.com/pypolestar/polestar_api/discussions/185 for further discussion and we'll circle back here later.

https://github.com/pypolestar/polestar_api/releases/tag/1.8.0b1 now published (pre-release),please test

Can you provide me with some more debug logs adding 1st car, then the other (both with VIN). You should be able to turn on debugging with the following action:
action: logger.set_level
data:
  custom_components.polestar_api: debug

You can email me the logs (see github profile for address).

I've done some additional work in #191 and I can now even add two copies of the same car. I have not yet tried with two different Polestar IDs and need some more help testing that.

Just tried as a guest of another Polestar, but as it does not show up in the API I cannot debug it :-(

I am now using two instances in parallel and can now see both our cars in the family. Each ID only displays one car (we are both admins in both cars).

Yes, it works fine for my use case where we have two separate owner
accounts, one for each car. If we buy a third one I will test what happens
when one owner owns two cars ;)
mån 18 nov. 2024 kl. 21:32 skrev Jakob Schlyter @.***>:

So everything works now for you @magnushacker
https://github.com/magnushacker ?
—
Reply to this email directly, view it on GitHub
https://github.com/pypolestar/polestar_api/issues/182#issuecomment-2484069803,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA73OUSHQTRSQOZIKMCIEGL2BJFFLAVCNFSM6AAAAABQRIKYPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBUGA3DSOBQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fix file permissions

Description
Fix.
Give the deploy user control over the match list file.
Changelog

Modify the Ansible playbook to chown with the deploy user.

@krivard Another iteration. Need to adjust some file perms on the proxy.


Merge pull request #9 from Chicook/Desarrolladores

Merge pull request #8 from Chicook/main

Cerrando cambio


ManagedMembers.close() causes caller to throw NullPointerException

RaftStateClient.close() invokes ManagedMembers.close() with lambda on the result.
      members.close().whenCompleteAsync((result, error) -> {
        if (error == null) {
          future.complete(null);
        } else {
          future.completeExceptionally(error);
        }
      }, context);

However, ManagedMembers.close() returns null if permits > 0, causing a NullPointerException to be thrown in the caller.

Good catch!

On Jul 15, 2015, at 11:35 AM, Don Mendelson<EMAIL_ADDRESS>wrote:
RaftStateClient.close() invokes ManagedMembers.close() with lambda on the result.
  members.close().whenCompleteAsync((result, error) -> {
    if (error == null) {
      future.complete(null);
    } else {
      future.completeExceptionally(error);
    }
  }, context);

However, ManagedMembers.close() returns null if permits > 0, causing a NullPointerException to be thrown in the caller.
—
Reply to this email directly or view it on GitHub.

ManagedMembers.close() gets called multiple places in code; RaftStateClient.close()  is just one instance.
My motivation was to close test members in a unit test of consensus. What happens if one cluster node is down, what happens if there is no quorum? In my tests, Copycat.close() throws fails every time with TestCluster. (In an acceptance test of NettyCluster, I would kill processes, of course.)
Consensus is based on how many members are configured for the cluster, not how many are currently alive, correct?

As an alternative to closing a node, I tried just not opening one or more. Without a majority of configured members, Copycat.open() failed on the client with TimeoutException. Is this intended behavior if the cluster is not healthy?

Right, consensus is based on the number of ACTIVE nodes in the cluster, and that number should always be fixed (until membership changes have been added).
I don't think you should be seeing a TimeOutException and I think timeouts and retries are a work in progress, and it's debatable how various failures should be handled. Our Jepsen tests have proved the correctness of the algorithm but at the same time exposed a lot of inefficiencies in how clients handle servers being down.
This is how failures should be handled currently:
If you're using the Netty cluster, the Netty client has a fixed timeout of 5000 milliseconds. That is, it expects a response within 5000 milliseconds. When the Raft client first starts (every server extends client, and RaftClient is the interface through which operations are submitted to servers) it should attempt to connect to a random Raft server and register a new session. In the event that the cluster times out, it should retry with another random server. (This is one of the areas where there's an inefficiency we've see in Jepsen tests. In a partition/failure where a majority of the cluster is not available, a client will essentially hammer the cluster with attempts to register a new session or keep an existing session alive until the partition/failure is resolved).
Once a client (or server) finds the leader, it should start sending periodic keep alive requests and can submit state changes. If the client fails to communicate with the leader, it should go back to step 1 and start hitting random nodes until it can reach the existing leader or a new leader.
Because all servers are also clients, this behavior applies to both. Essentially, the client is what's exposed to the user, and the fact that a node is a client or a server should be relevant only to Copycat internally. That said, Jepsen tests have used clients and servers in those roles exclusively.
A bit of refactoring is currently being done to help resolve some of the issues with connections between clients and servers. Truthfully, the Cluster abstraction is too high level for Raft, and so it's being moved up to the core module and replaced with lower level Clients, Servers, and Connections to be used by the Raft implementation. Part of the reasoning for this is to allow for bi-directional communication between the client and server (as basically a socket, which doesn't currently exist) but also to allow the Raft implementation to manage connections and their errors more efficiently. For instance, the RaftClientContext will maintain a single Connection to the current leader, and RaftServerContext a set of Connections only to other servers. The Raft implementation will then expose a set of Sessions through which higher level APIs like the Cluster can communicate, and things like timeouts, failures, and retries will be handled differently on the Raft client/server level from the Copycat level.
There may simply be differences in the TestCluster that aren't present in the NettyCluster. All our Jepsen tests have been done on legitimate networks using the NettyCluster, and I'd be curious whether this same behavior exists in that environment. BTW we've basically been using the example server in the examples directory to test via Jepsen.

On Jul 17, 2015, at 2:34 PM, Don Mendelson<EMAIL_ADDRESS>wrote:
As an alternative to closing a node, I tried just not opening one or more. Without a majority of configured members, Copycat.open() failed on the client with TimeoutException. Is this intended behavior if the cluster is not healthy?
—
Reply to this email directly or view it on GitHub.

Recent improvements to configuration changes in Copycat make this issue fixed :-)


test: Kubernetes 1.19.1 without EndpointSlices

Kubernetes 1.19.1 may have some relevant bug fixes. More importantly,
EndpointSlices are now also disabled for it by disabling the feature
that uses them in kube-proxy. That part was missing before, causing
kube-proxy to fail.
Perhaps this will increase stability of Kubernetes 1.19 testing. There
have been random failures recently during sanity testing where
connecting to the node port failed.

@avalluri testing passed, so it at least didn't get worse :sweat_smile:
Please review and merge.


Breaking change in 2.1.0 regarding key in UserInfo

Bug
Plugin Version:  2.1.0
Platform (e.g., Android v21):  iOS 10.x
Device/Hardware:  Simulator and devices
Expected behavior
In AppDelegate.ReceivedLocalNotification() the key "LocalNotificationKey" is expected in UserInfo
Actual behavior
The "LocalNotificationKey" key is not present. This is because in iOS 10 the new notification framework is used, and it doesn't use "LocalNotificationKey"
Steps to reproduce the behavior

Create local notification using Plugin.LocalNotifications.CrossLocalNotifications.Current.Show("Test","Test",-1)
Inspect UserInfo in AppDelegate.ReceivedLocalNotification() and see the key is missing

ReceivedLocalNotification is deprecated in iOS 10+.  You instead should implement a UNUserNotificationCenterDelegate class and override WillPresentNotification (see the README and sample).
This plugin uses UserInfo for iOS 9.x and older to provide the notification's identifier.  However, on iOS 10+ the identifier can be accessed in the UNNotification's Request property.  For example, in WillPresentNotification you can access it via notification.Request.Identifier.


Is it possible to release test artifacts for python, php, java and jimple?

I want to reuse the test fixtures in my project.
Can this be done be a PR? like adding this line in build.sbt
Test / packageBin / publishArtifact := true

Which classes specifically are you interested in? I was already pondering the release of test artefacts, but maybe it is better to do some restructuring first.

classes like PySrc2CpgFixture

no test jar for python

test jar for c
libraryDependencies ++= Seq(
  "io.joern" %% "pysrc2cpg" % joernVersion,
  "io.joern" %% "pysrc2cpg" % joernVersion % Test classifier "tests"
)

#1930

All test code is now released as separate test artifacts. For reference: https://github.com/joernio/joern/pull/1930


grpc: support full set of Google credentials.

This supports things like OAuth, GCE default creds, refresh tokens, etc.
Risk Level: Low
Testing: Minimal tests. grpc::Channel/CallCredentials are opaque and don't provide much in the way
of inspection from tests (CC: @vjpai).
Signed-off-by: Harvey Tuch<EMAIL_ADDRESS>

Also, remove corresponding [#not-implemented-hide:] from grpc_service.proto.

return this if allow_insecure is true? I don't think the default implementation should allow call credentials to be enabled on an insecure channel.
I think grpc may drop the call credentials on an insecure channel anyway: https://github.com/grpc/grpc/issues/8142

Let's not take the (about to change) restriction from gRPC library to here. We have discussed the use cases with gRPC security (cc @jiangtaoli2016) to and they are going to relax this on gRPC side. The particular use case we have is by sending credentials over unencrypted unix domain sockets, to bootstrap SDS.
cc @wattli @incfly


⚠ Bofrost.be has degraded performance

In 262faff, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1869 ms

Resolved: Bofrost.be performance has improved in 97d65ca.


Remove unused functions

Remove unused functions spotify-play and spotify-pause, and the corresponding functions from all backends.
Ref: #40

Not 100% on this.

This is a Spotify API (and player)... why are we restricting to a subset of the things the Spotify API can do?

"Play" is the obvious place to start when testing out a... music player API. It's where I started and how I noticed the missing functions.

"Play" is not "Toggle Play/Pause", just like "Pause" isn't. I can see a lot of use for either. E.g. my "go-home" function stops languages servers, stops certain buffers with certain processes, auto-commits note files, and was going to pause Spotify. But now you've dropped "Pause" because you don't use it yourself in spotify.el? Seems odd... Yes I can ask for status and wait and check it and act on it, but I used to just be able to... pause. Or play.

If more people seem to need these functions, I can add those back, but until then, since these are not referenced in the remote-mode, there's little reason to keep them.
If you require these functions, you can add those in your emacs configuration and it will work as expected. That's the beauty of elisp. :)


Button hover effect

The pic might help you visualize.
So, the left screen is yours @SONA-1111  and the right one is the current site.

Make the button spacing as it is on the current website as yours have too much gap in between.
The IMAGE DESCRIPTION and GENERATE buttons are stretched to the boundary so reduce some margin so that it looks like the pic I provided.
As you can see the @copyright is not visible on your screen so fix it.

And try doing all the changes in the same PR as this is your 3rd PR for the same issue.

Cool


BUG: When multiple tokens exist for the same config, the returned permission level is incorrect

When multiple service tokens are created for the same config, the returned permission level during Terraform state refresh is incorrect.
Reproduce:
provider "doppler" {}

resource "doppler_project" "this" {
  name        = "test-project"
}

resource "doppler_environment" "environment" {
  project = doppler_project.this.name
  name    = "local"
  slug    = "local"
}

resource "doppler_service_token" "service_token_read" {
  project = doppler_project.this.name
  config  = doppler_environment.environment.slug
  name    = "read"
  access  = "read"

  depends_on = [
    doppler_environment.environment
  ]
}

resource "doppler_service_token" "service_token_write" {
  project = doppler_project.this.name
  config  = doppler_environment.environment.slug
  name    = "write"
  access  = "read/write"

  depends_on = [
    doppler_environment.environment
  ]
}

run terraform apply
run terraform apply again

The 1st run successfully creates the tokens with the required permission levels.
Response on the 2nd run:
Terraform will perform the following actions:

  # doppler_service_token.service_token_read must be replaced
-/+ resource "doppler_service_token" "service_token_read" {
      ~ access  = "read/write" -> "read" # forces replacement
      ~ id      = "test-project.local.73df0b0c-b6a1-4036-aa2a-6a379a0c675a" -> (known after apply)
      ~ key     = (sensitive value)
        name    = "read"
        # (2 unchanged attributes hidden)
    }

Hey @AnitaErnszt, thanks for reporting this! I'm seeing the same behavior and I've got a fix.

Thanks again for letting us know about this! The fix has been shipped in the latest version of the provider (terraform-provider-doppler v1.1.6)

Thank you, managed to test it and working as expected 👍


upgrade gluster client to 10

Codecov Report
Patch and project coverage have no change.

Comparison is base (b7b5968) 39.09% compared to head (ae6c1d4) 39.09%.
 Consider uploading reports for the commit da40a00 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   39.09%   39.09%
=======================================
  Files          33       33
  Lines        3988     3988
=======================================
  Hits         1559     1559
  Misses       2283     2283
  Partials      146      146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


JRE version mismatch problem

Hello sir,
We are using pebble template engine for preparing message. We are facing problem like our development and production servers are running in 1.6 but pebble jar is compiled in 1.7. So we stuck in the testing phase. Please help us fix this problem?
Error we received : java.lang.UnsupportedClassVersionError: JVMCFRE003 bad major version; class=com/mitchellbosecke/pebble/loader/Loader, offset=6
Pebble POM:

maven-compiler-plugin
2.3.2

1.7
1.7

I am pretty new to github. Can i use this link(https://github.com/PebbleTemplates/pebble/releases) to download source code of that specific version and compile with jdk1.6. OR is there any other links i can download jre1.6 compiled version of pebble jar?

Fork the code, checkout it and rebuild it with a jdk6 version. Maybe it
isn't compatible though and you will have some refactoring to do.
On Dec 20, 2016 9:59 AM, "sureez"<EMAIL_ADDRESS>wrote:

I am pretty new to github. Can i use this link(https://github.com/
PebbleTemplates/pebble/releases) to download source code of that specific
version and compile with jdk1.6. OR is there any other links i can download
jre1.6 compiled version of pebble jar?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PebbleTemplates/pebble/issues/246#issuecomment-268264491,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKLZhwgGXMLpNfpKoMGOgD0UrbrDcdioks5rJ-1sgaJpZM4LR4-3
.

There are few refactoring had to be done to compatible with jdk6. All testcases are successfully build.
Thanks. Closing this issue.


Fix repair loop, throwables

Replaces the check in the Repair() function with RepairRequired() to ensure we always get the same result when we check in town as we do when we check mid-run. This should prevent the endless tp loop bug.
Also replaces the RepairRequired() function with the one from SoundsLegit's repair_throwables branch.

Obsolete with #422


character varying = typeid error: Recipe jet failed on line 52 with exit code 1

Describe the bug
It's giving error while generating the types
Connecting to postgres database...
Retrieving schema information...
Error trace:
 - failed to get 'public' schema metadata:
 - failed to get public tables metadata:
 - failed to query BASE TABLE metadata:
 - jet:
 - pq:
 - operator is only a shell:
 - character varying = typeid
error: Recipe `jet` failed on line 52 with exit code 1

Environment (please complete the following information):

OS: windows
Database: postgres
Database driver: no
Jet version v2.10.1

Code snippet

CREATE TABLE public.application_user (
    id public.application_user_id DEFAULT public.typeid_generate('application_user'::text) NOT NULL,
    customer_id public.customer_id NOT NULL,
    access_failed_count integer DEFAULT 0 NOT NULL,
    email text NOT NULL,
    email_confirmed boolean DEFAULT false NOT NULL,
    lockout_enabled boolean DEFAULT false NOT NULL,
    lockout_end timestamp with time zone,
    normalized_email text NOT NULL,
    normalized_user_name text NOT NULL,
    password_hash text NOT NULL,
    phone_number text,
    phone_number_confirmed boolean DEFAULT false NOT NULL,
    user_name text NOT NULL,
    created_at timestamp with time zone DEFAULT now() NOT NULL,
    updated_at timestamp with time zone DEFAULT now() NOT NULL
);

https://github.com/jetpack-io/typeid
Using this as the primary key
Expected behavior
It should translate the typeid to text

Hi @spa5k,
I'm having a problem to reproduce the bug. Generator successfully generates code for application_user table. Could you share how application_user_id and customer_id is defined.
Error trace points to operator error. It seems you are trying to compare typeid and varchar, which is not allowed.

Hey I was able to fix it up, so basically in this file - https://github.com/jetpack-io/typeid-sql/blob/main/sql/03_typeid.sql, they were using VARCHAR and sometimes with fixed length of 63, I basically replaced it with text and it worked.


Update scalafmt-core to 3.0.4

Updates org.scalameta:scalafmt-core from 3.0.3 to 3.0.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-patch

Superseded by #199.


fix: fix issue https://github.com/odpf/guardian/issues/298

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
47 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 73.83%

Files with Coverage Reduction
New Missed Lines
%

core/provider/service.go
47
61.11%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
5933

Relevant Lines:
8036

💛  - Coveralls


Label array only contains initial value.

Describe the bug
The extractor for a label is seen to contain only the initial value. Rather than all values.
Can be seen here
/schema/173#labels
To Reproduce
Create a Label that works on an array of data. Check the Combination function. The first value is displayed.
Version
0.7.11
Java
17

OS
any
Browser
FF118

This issue has been fixed.

@whitingjr do we know which PR fixed this issue?


Feature Suggestion: docker swarm  logs should provide aggregated logs from all services

I did check that this didn't exist in open issues / couldn't find a roadmap which mentioned this.
I am using swarm to create a small (<20 containers, <10 service) backend, and would like to be able to view the logs as the service starts in a similar way to docker-compose up.  e.g. a collated or aggregated view of all the logs.
(If I'm not in the right place, or it's already been discussed and dismissed, please let me know :) )

This issue is for https://github.com/docker/swarmkit not the old standalone Swarm.


Camel-case label config properties

In the configuration, you have both startVersion and major-label.    Should we stick with camelCase, since package.json uses devDependencies, etc.?

Good point. I can change that! That'll unfortunately break the current configs, so I'll make it a major version change, but I like the consistency.

@daveashworth Let's see this baby in action then!

@daveashworth Up to you how you want to handle this.

Any update on this? @daveashworth

No update AFAICT.    Been swamped @ work =/

@ericclemmons @daveashworth If you guys are cool with this change, I can take it over the finish line.

We believe in youuuuuuuuuuuuuuuu!

Aye aye!


Add --help Support Via [CmdletBinding()]

In an effort to make Powershell scripts more consistent when executing them from another shell (i.e. pwsh script.ps1 or ./script.ps1) in a Linux/Unix-like fashion, it would be great to add --help as a way to get detailed help from the script file (through comment based help or HelpMessage).

Dupe of #6397


set_axis_lock not working on KinematicBody 3D

Godot version:
3.1 Beta 3
OS/device including version:
Kubuntu 18.04
Issue description:
The Axis lock is not working.
According to the docs I'd assume to call:
set_axis_lock(move_lock_z,true)
print("lock z " , get_axis_lock(move_lock_z))

The output on the console is : "lock z False"
And the body still moves on z axis by collision.
I tried some variations:
self.set_axis_lock(PhysicsServer.BODY_AXIS_LINEAR_Z, true)
self.set_axis_lock(move_lock_z, true)
move_lock_z = true
PhysicsServer.body_set_axis_lock(self.get_rid(), PhysicsServer.BODY_AXIS_LINEAR_Z, true)

Neither of them results in a locked z axis.
For a 2.5D platformer z-axis lock would be crucial
the whole axis lock panel that was available in 3.06 in the inspector is gone as well in 3.1
Was the feature discarded?
Minimal reproduction project:
AxisLockBug.zip

@AndreaCatania

hey whole year passed, fix this bug maybe?

@Favkis Godot is a community-developed project. Bugs are fixed when someone opens a pull request :slightly_smiling_face:

That's an odd one. Anyone figure out a proper workaround for now at least?

That's an odd one. Anyone figure out a proper workaround for now at least?
Edit: This seems to work for me:
self.transform.origin.z = 0

that is the same hack i have been using, it seems to be okay .... again yes also i am waiting for any sort of official recognition or promise of fixing this bug actually ever since i started with godot at version 3.0
i'm not sure of what the consequences of the hack may be but so far it does seem to have none

Fixed with #25798.

Fixed with #25798.


Standardise uptime

I was wondering, maybe uptime as an information variable should be a standard in the library. The library itself has a the ability to make a connection. If this was the case, even when integrating with something like the bot, all the bot would  have to do would be to interpret the uptime.
The uptime does not have to be given in a particular format, maybe just plainly as seconds or raw time.time(). Any other application using the library can interpret it in the way it wants. You usually see client connection or actual uptime as default information on a variety of interfaces now, so I was placing the idea.

    def get_runtime(self, milliseconds=True):
        """
        Get the time the connection has been alive.
        :param milliseconds: bool True return the time as milliseconds, False return seconds.
        :return: int milliseconds or seconds.
        """
        up = int(time.time() - self._init_time)
        if milliseconds:
            return up * 1000
        return up

Will be in next version.


find-refs missing references from dependent node.

given the following code:
template <typename T> void foo();
template <typename T> void bar() {
  foo<T>(); // find-refs only gives 1 foo-decl reference
}

I think find-refs should consider the UnresolvedLookupExpr foo<T>() as the reference of foo decl. The fix is to extend the libindex to report references from UnresolvedLookupExpr.

Sam mentioned that we may want to switch the implementation of find-refs from libIndex to FindTargets at some point. I believe that would solve this.

Yes, exactly. Switching from libindex to FindTargets is one of tasks in our backlog, but we don't prioritize it at the moment (at least Q1).


feat: fast l2 for uint8

L2 distance over uint8 slice.

$ cargo bench --bench l2 -- uint8

Gnuplot not found, using plotters backend
L2(uint8, scalar)       time:   [60.735 ms 61.018 ms 61.342 ms]
                        change: [-2.6199% -2.3826% -2.0310%] (p = 0.00 < 0.10)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe

L2(uint8, auto-vectorization)
                        time:   [63.153 ms 63.176 ms 63.206 ms]
                        change: [-2.1376% -2.0736% -2.0031%] (p = 0.00 < 0.10)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild

Codecov Report
Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 81.03%. Comparing base (f9a4d3d) to head (c3cec35).

Files
Patch %
Lines

rust/lance-linalg/src/distance/l2.rs
0.00%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2161      +/-   ##
==========================================
+ Coverage   81.00%   81.03%   +0.03%
==========================================
  Files         179      179
  Lines       50923    50929       +6
  Branches    50923    50929       +6
==========================================
+ Hits        41248    41271      +23
+ Misses       7277     7273       -4
+ Partials     2398     2385      -13

Flag
Coverage Δ

unittests
81.03% <0.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ecotop Light 23.010 Biomas boiler state not enumerated

Describe the bug
Missing enumeration of States "Solarfocus Boiler boiler status" - shows "0" instead of "Bereitschaft"
Expected behavior
Numbers shall be enumerated
Desktop (please complete the following information):

Home assistant version: [e.g. 2023.4.1]:  2024.2.1
Solarfocus custom component version [e.g. 3.0.0]:  4.0.4
Solarfocus firmware version [e.g. 23.020]: 23.010

Additional context
Root cause is that for EcoTop Light at least for this verison the enum starts at 0
adding this to strings.json (de.json, en.json) fixes this
      "bb_status" : {
        "state" : {
          "0": "Bereitschaft",
          "1": "Zündphase",
...

fom the ecomanger-touch_Modbus pdf

de are available -> only default and en are missing
will be closed by https://github.com/LavermanJJ/home-assistant-solarfocus/pull/94

Adding the Mod bus register description (german) I just got from Solarfocus (with permission to share on github)
EcoMT_Modbus-TCP_Anleitung_v11-231212_DE.pdf
it includes information about registers and at which version they are available

That's great! I'll take this information to extend the integration accordingly.


restore publish durable object script that was deleted in the move

@greg-mckeon

This looks good to me


chore: fix ESLint errors

They were introduced in https://github.com/nodejs/node-core-utils/pull/367 because it landed after https://github.com/nodejs/node-core-utils/pull/371 but the Travis run happened before that.

@nodejs/automation-collaborators


Steps to make use of this. When Launching stack always give ROLLBACK_COMPLETE status

Hi I would like to make my ECR public. I am a beginner in AWS. So I am not too sure how can I make use of this except that I do click the create stack under the deploy instructions.
However when I have done creating it in the aws console, it always give me roolback_complete status, where it seems it does not allow me to launch the stacks.
Is there some steps required before go to create the stack? I would appreciate your help. Thankyou so much.

Please try again with the latest version. The previous version had referenced an outdated version of the NodeJS runtime.

Hi So I have successfully deployed the stack. Right now I have an ECR created on my console (named my-first-repo). For now it still needs the docker client to get the credentials so that I can push or pull images to ECR. I am pretty sure that I missed sth, but don't know what it is. I tried to access the invoke URL on the API Gateway(both HEAD and GET method) and it gives error. Thank you.

Please include the error message you are receiving and the request you are executing.

It returns 404 notfound
This 806ycvye8k.execute-api.us-east-2.amazonaws.com page can’t be foundNo webpage was found for the web address: https://806ycvye8k.execute-api.us-east-2.amazonaws.com/Stage/{proxy+}
HTTP ERROR 404

It looks good to me:
curl -i  https://806ycvye8k.execute-api.us-east-2.amazonaws.com/v2/
HTTP/2 200
date: Wed, 11 Mar 2020 17:54:54 GMT
content-type: application/json
content-length: 0
x-amzn-requestid: 29cce6d6-db83-4561-9a25-44b1d706b82d
x-amz-apigw-id: JPLdRHQ_iYcFS7g=
x-amzn-trace-id: Root=1-5e6925ee-b012b2a1eedeb7ed7854e651

I think you are all set.


Customize Expandable List

Hi,
I want to add button parent_view. Normally when we click parent-item, its expand chlds. But I want do another job for this. How can i customize this view actions ?
Thanks.

I figure it out with extending new class from easyTemplateParent. Then override bindView method for adding actions on custom elements.


Custom NavigationPageRenderer

I am creating a custom renderer to be able to change the Back Button Style of the Navigation Bar. I've already create a repository demonstrating this at https://github.com/bbl-Laobu/CustomBackIconDemo.
Now, I am trying to add animation to my page transitions using your solution.
Normally, the customer renderer inherits from NavigationRenderer for iOS and  NavigationRenderer or NavigationPageRenderer (Appcomp) for Droid.
When using your transitions solution, what should my custom renderer inherit from to still have your animations working? You can see my custom NavigationPageRenderer for iOS here https://github.com/bbl-Laobu/CustomBackIconDemo/blob/master/iOS/NavigationPageRendereriOS.cs

@bbl-Laobu  Hi! For now i'm thinking to publish all source code of my plugin.
I will update you.

@bbl-Laobu  For now you can get all source code from this repo.


Expectations for KubernetesClient

Since the operator sdk now depends on quarkus-kubernetes-client are we forced to use the openshift client or is there a mechanism to still use the DefaultKubernetesClient?
I'm asking due to https://github.com/fabric8io/kubernetes-client/issues/3179

Right now there isn't but my view on this is that we should address the underlying concern with the client.

I'm assuming this is addressed, please re-open with additional details if needed.


GetCheermotes throws JsonSerializationException

When attempting to get information from cheermotes using: await TwitchAPI.Bits.v5.GetCheermotes("DamnICantFly");
A JsonSerializationException is thrown.

Exception thrown: 'Newtonsoft.Json.JsonSerializationException' in Newtonsoft.Json.dll
Additional information: Cannot deserialize the current JSON object (e.g. {"name":"value"}) into type 'TwitchLib.Models.API.v5.Bits.Action[]' because the type requires a JSON array (e.g. [1,2,3]) to deserialize correctly.

When checking out the data which is returned from the await before attempting to deserialize, it seems exactly the same as when checking out the direct url "https://api.twitch.tv/kraken/bits/actions?channel_id=damnicantfly&client_id=[client_id]&api_version=5".
Not sure if I'm doing something wrong, but this seems like a bug.

Looks like a bug. Looking into it now.

Feel free to reopen this if that commit didn't fix the problem. Pushing a new nuget package tonight/tomorrow morning: 1.5.3

I can confirm, this fixed the problem. Thank you for your quick response!


Add libnetcdf to jigsaw build deps

This should be fixed for all machines be included but is causing particular trouble on Compy

Checklist

[ ] Testing comment in the PR documents testing used to verify the changes

Testing
This fixed problems with building Jigsaw on Compy

I spoke too soon, this didn't help.


Does it support stm32 as end device?

Thanks for this great work !
Is it possible to use raspberry gateway with sx1278 and end devices with stm32 and sx1278 ?
Regards

@tftelkamp


Add support for Oracle Linux

It would be awesome if you could add support for Oracle Linux, specially to be run on the Oracle Cloud Infrastructure.

Given the uncertainty surrounding RHEL clones, I do not want to commit support for any which is not already supported.


Component: Basic List

Add support for simple lists as seen on https://www.post.ch/de/empfangen/empfang-steuern

Figma
https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=19518%3A5339&mode=design&t=WG8hb62cKWE4ErqU-1
Dev
https://next.design-system.post.ch/?path=/docs/utilities-list--docs

@wueestd maybe a duplicate

changed it to a basic list

@wueestd ready to be tested, thank you 👍

@Cian77 awesome job, I added some comments. choos what ever seems to be relevant for you :)

@wueestd I have added your recommendations. Concerning documentation. I think we should not over do it, as a UX Designer should know certain basics.

I added a dev ticket https://github.com/swisspost/design-system/issues/2342 and updated the Component gallery entry for lists https://github.com/orgs/swisspost/projects/4/views/1?pane=issue&itemId=14331616

Ready for implementation

Closing as done


Kops Compatibility #1: Set RecordType at source

Use constants for RecordType's
Set RecordType in the sources
Remove ALIAS type (This is only used to determine if we should create an AliasTarget for the AWS provider and should be internal to the AWS provider. Also when we add multiple-target support we will group records by DNSName/RecordType, so we need to convert the RecordType back to a CNAME in order to properly compare current vs desired. Additionally AliasTarget only supports single targets, so when we switch to multiple-targets we will need to determine based on the target count as well.)

lgtm

@sethpollack could you please rebase this PR on master, and then we can get it merged :)

Let's test that in our production setup. Then it's good to go.

@sethpollack Just went through this PR again and noticed again how great it is, thanks 😃

Thanks


Update compute_note_hash_and_nullifier compiler check to accept AztecAddress type

In this PR I typed everything in aztec-nr and noir-contracts but I couldn't type contract_address in compute_note_hash_and_nullifier function because it broke the compiler check. Update the compiler check and set the contract_address type to AztecAddress in compute_note_hash_and_nullifier function.

Implemented the macro change here but didn't manage to finish the corresponding changes in aztec-packages before my vacation.


Add edi.py connect-clients project

LinuxForHealth connect-clients/edi.py is a Python LinuxForHealth connect client based on LinuxForHealth EDI, with the following additional features:

A transform workflow step to provide a basic transform from X12 270 to FHIR R4 CoverageEligibilityRequest
A transmit workflow step to send a FHIR R4 CoverageEligibilityRequest to LinuxForHealth connect
A NATS subscriber to receive FHIR R4 CoverageEligibilityResponse results
A basic transform from FHIR R4 CoverageEligibilityResponse to X12 271.

Closing this PR, but we'll keep the branch around.  Before making this an example client, it needs to take advantage of newer LinuxForHealth X12 features, which were in progress when this was created.


Cast Array object not  getting loaded

https://contactmentor.com/find-object-in-array-of-objects/#:~:text=We can find objects with minimum and maximum,using Array.find ( (item) %3D> item.property %3D%3D max_value%2Fmin_Value)


WORK IN PROGRESS: Use Chroma as new default syntax highlighter

Fixes #3888

Looks promising:
Hugo docs with Pygments and no caching:
time hugo --ignoreCache
Started building sites ...
Built site for language en:
0 of 6 drafts rendered
0 future content
0 expired content
230 regular pages created
51 other pages created
1 non-page files copied
15 paginator pages created
16 categories created
total in 15498 ms

With Chroma (also no cache):
▶ time hugo
Started building sites ...
Built site for language en:
0 of 6 drafts rendered
0 future content
0 expired content
230 regular pages created
51 other pages created
1 non-page files copied
15 paginator pages created
16 categories created
total in 928 ms

fast and faster as usual. Bump for Chroma!

https://github.com/alecthomas/chroma/issues/18


Why not throw out the error code of database?

Hi rbock, our team has used sqlpp11 for two months. Everything goes fine and thanks to your well done ORM framework, our coding efficiency has been improved a lot.  Thanks again for all your kind support and replies :)
But there is one more thing that I confuse about is, why you didn't put error code into sqlpp::excetion when designing it? It is very useful to catch the error code thrown by the native database (such as ROW NOT EXIST, PRIMARY KEY CONFLICT WHEN INSERT), based on which we can flexibly adjust our code logics. Isn't it?

Thanks for the feedback. I am happy to read that you are making such good progress :-)
To me, such errors always indicated a logic error in the C++ code that needs to be fixed.
That being said, individual connectors can, of course, add more information to exceptions. See the postgresql connector. It would be possible to add such constructs to other connectors as well.

Thank you.

To me, such errors always indicated a logic error in the C++ code that needs to be fixed.

One counter example would be inserting something that has a non-auto incrementing unique key. In that situation it might be best to try to insert, change the key if it fails, and try again. Also there's other issues that might have nothing to do with the code, like lock wait timeouts, full storage, or communication errors. These can often be indistinguishable without getting the full error state.

My view on these example is different, but again: if that is what you need, then you could add more specific exceptions in the connectors.
I wouldn't mind.


Allow Docker Secrets in config

As referenced here, an accepted methodology is to create a second environment variable for files, i.e.:

WEBEX_BOTID
Containing the raw string, e.g. "1234-0987-ABCD"
WEBEX_BOTID_FILE
Containing the filename to the secret, e.g. /run/secrets/WEBEX_BOTID

An alternative would be to assume that any unreferenced environment variable could also be a secret, and proactively check the file location as part of the environment variable check, but this seems like it might be too opaque and prone to error.

Sensitive variables that could require secrets are:

TUYA_DEVICE
WEBEX_PERSONID
WEBEX_BOTID
O365_APPID
O365_APPSECRET


Is there implementation code for bond?

BOND: Aligning LLMs with Best-of-N Distillation

sorry，we just open-sourced our PF-PPO code.


Add optimized solution for the problems in Python

Add optimized solution for the problems in Python.
Add comment and explain each and every line.
Variable name should be meaningful and in camelCase like FooBar,FooBarTest.
Add solution link in readme file with Python language category in solution section.
Your Code must be pretty formated.
Have a good commit message.

Hey, I want to contribute to this repo. Could you please elaborate which problems are being referred?

Hey, I want to contribute to this repo. Could you please elaborate which problems are being referred?

Hey @rhymasharma, You can solve any problems of your choice whihc you are able to solve.

hey @Shubhamlmp i am interested in this task

Hey@Shubhamlmp  just assign me this task

hey i want to contribute pls assign me this issue


backport 5.8

Explain the changes
Backported:

https://github.com/noobaa/noobaa-core/pull/6663
https://github.com/noobaa/noobaa-core/pull/6742
https://github.com/noobaa/noobaa-core/pull/6747

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

opened new backport PR #6801


feat: smoothness in a vector bundle

Add lemmas about smoothness in a smooth vector bundle. Also rename the old smoothOn_coordChange to smoothOn_coordChangeL.

Thanks :tada:
bors merge


Fix the guide to the deprecated OpenJDK installation command.

The previous Brew installation command for adoptOpenJDK is now deprecated.
Followed the documentation and change the method to install Temurin.

👍 Still this is on hold till facebook/react-native#32186

Whether it is JDK8 or JDK11, the Brew installation command has already been deprecated. See here for deprecation notices for previous commands.
The beginning of this PR, I submitted to fix the current JDK8 installation document, but Nicola wants to wait for 11, so I've modified the commit for JDK11.

#2800 has also changed the documentation for Choco on Windows, but the documentation for Brew on Mac remains a deprecated command.
If you accept this PR, please merge #2800 first, then merge this PR.

Reviving this PR as we're discussing it here https://github.com/reactwg/react-native-releases/discussions/13#discussioncomment-2083760
@1natsu172 can I ask you to rebase and fix the merge conflict?

@cortinico done for rebased and fixed conflict and applied to 0.67's guide.

@cortinico I resubmitted. Please review it.

@Simek this should be now ready to go 👍


create example from-path

Method  from_path is relevant when the .env file is located in a directory lower in the hierarchy from CWD. An example of using from_path will not be superfluous.

I feel like the from_path doc already explains its purpose, regardless of where the .env file actually is.
If it is still unclear, please reopen the issue.


Future of svemix

Describe the bug
The new routing changes in kit will probably change the future of svemix.
I've just managed to avoid generating the page endpoints in #54 and i'm a little bit frustrated now because the new routing proposal would make svemix kinda obsolete. I love svemix because you can write your server code directly inside your svelte files.
I see a few ways to continue svemix

Fork SvelteKit before the new routing changes and try to be up to date with any changes in kit unrelated to routing.
Change svemix to use the new folder-based routing.
Discontinue svemix

Your Example Website or App

Steps to Reproduce the Bug or Issue

Expected behavior

Screenshots or Videos

Platform

Additional context
No response

You are not alone in feeling frustrated. The change will obsolete most youtube tutorials, a shitload of github repositories.
I will discontinue my experiments, until that thing has settled.

I've an advice that may sound funny. But I think this sort of project should be based upon svelte not sveltekit. Also the current routing changes in sveltekit has created a room for a sveltekit competitor framework. I love SvelteKit but many including me would also welcome a new SvelteKit alternative. Just think about it.


progressSort() doesn't clear other column sorts, whereas setSort() does. Docs suggest both are viable options

I'm submitting a ...
[x] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid/blob/master/CONTRIBUTING.md#question

not sure if it's a bug or intended feature, docs unclear.
Current behavior
https://www.ag-grid.com/javascript-grid-header-rendering/#sorting
The grid-header component docs state you have 2 options when looking to programatically change the sort of a col.  setSort() to manually specify a sort order, or progressSort() to move to the next sort state.
Expected behavior
setSort() will clear the sort state of the other columns, progressSort() leaves them in tact, which can lead to rather complicated undesirable states as this is effectively forcing mutli-col sort without the user having to hold shit to opt-in to such a feature.
Minimal reproduction of the problem with instructions
https://www.ag-grid.com/javascript-grid-header-rendering/exampleHeaderComponent.html
edit the following function.
MyHeaderComponent.prototype.onSortRequested = function ( /*order,*/ event) {
    // this.agParams.setSort(order, event.shiftKey);
    this.agParams.progressSort(event);

};

remove order param from function call
swap out this.agParams function call, to use progressSort(event); instead

What is the motivation / use case for changing the behavior?
Trying to implement a sort style with repeated clicks of cols toggle through the 3 states: asc, desc and null, as opposed to 3 separate icons in the demo.  Using progressSort() to leverage the automation of progressing to the next sort state, however this doesn't reset the sorts of other cols, unlike setSort()

ag-Grid version: 9.1.0

Browser: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36"

Bump, any news or thoughts on this?

Hi,
Thank you for raising this issue for us, at this moment we are reviewing how we process Feature Requests/questions that come through from GitHub.
As I am sure you are aware, we offer two products:
ag-Grid - this is entirely free to use in line with our MIT license
ag-Grid Enterprise - our commercial version which funds the development of both versions.
We currently have a very full pipeline of work which can be viewed here: https://www.ag-grid.com/ag-grid-pipeline/
This will be our priority for the coming months and as a result, we don’t have capacity to take feature requests/questions from GitHub, but you might find that yours has already been raised in our pipeline.
We will do a periodic review of GitHub issues for any bugs raised and these can also be tracked on our pipeline page.
Thanks for your understanding.
ag-Grid Team.


Role presentation missing on some tables

Describe the bug
For accessibility we are trying to add role="presentation" and found it was missing from in a few spots. I did review #2256 and that didn't seem to address this.
MJML Section
https://github.com/mjmlio/mjml/blob/d1879e81e16eff85f8a653094f9c066398bdee92/packages/mjml-section/src/index.js#L196
and
MJML Table
https://github.com/mjmlio/mjml/blob/d1879e81e16eff85f8a653094f9c066398bdee92/packages/mjml-table/src/index.js#L78
(I hope that is a helpful way to indicate where/how to resolve missing attributes)
To Reproduce
Steps to reproduce the behavior:
https://mjml.io/try-it-live/mkjNKlEmR77
<mjml>
  <mj-body>
    <mj-section>
      <mj-column>

        <mj-image width="100px" src="/assets/img/logo-small.png"></mj-image>

        <mj-divider border-color="#F45E43"></mj-divider>

        <mj-text font-size="20px" color="#F45E43" font-family="helvetica">Hello World</mj-text>

        <mj-table>

            No role on this table either

        </mj-table>
      </mj-column>
    </mj-section>

  </mj-body>
</mjml>

Expected behavior


How to determine if Windows has been locked?

If the robot runs on the lock screen, the bot fails.
How can I find out if the screen has been locked?

We probably have the same problem, but I'm on Mac OS
See: #527

Resolved


Form not submitted

I've implemented this but my form is not submitted. Button type is submit.
In console I am getting error "uncaught exception: null"
The above is happening when I am clicking on Verify button in the captcha images.

Can you please try to reproduce your issue on codepen? Like what I did here: https://codepen.io/albertcht/pen/MXraNr, that would be easier to debug. I only need your html redered by your frontend code.

It's working in codepen.

Following issue I am facing with my code.
recaptcha__en.js:251 Uncaught (in promise) null
hp @ recaptcha__en.js:251
(anonymous) @ recaptcha__en.js:249
nf @ recaptcha__en.js:71
jf @ recaptcha__en.js:71
b @ recaptcha__en.js:68

Can you reproduce your error on codepen? Otherwise I don't have any clues about your issue.

It's resolved now. I was not adding the id and name to my submit button.


[discoverygo] 1080p no longer available ?

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.11.15. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ ] I've verified and I assure that I'm running youtube-dl 2017.11.15

Before submitting an issue make sure you have:

[X] At least skimmed through the README, most notably the FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[X] Question
[ ] Other

E:\>youtube-dl -F --verbose https://www.discoverygo.com/fast-n-loud/the-race-busch-vs-logano/
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-F', '--verbose', 'https://www.discoverygo.com/fast-n-loud/the-race-busch-vs-logano/']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.11.15
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-82966-g6993bb4, ffprobe N-72383-g7206b94, rtmpdump 2.4
[debug] Proxy map: {}
[debug] Using fake IP <IP_ADDRESS> (US) as X-Forwarded-For.
[DiscoveryGo] the-race-busch-vs-logano: Downloading webpage
[DiscoveryGo] the-race-busch-vs-logano: Downloading m3u8 information
[info] Available formats for 5a14a85b6b66d16cfa1ffb28:
format code  extension  resolution note
hls-63       mp4        96x54        63k , avc1.42000a, 6.0fps, mp4a.40.5
hls-134      mp4        192x108     134k , avc1.42000b, 15.0fps, mp4a.40.5
hls-244      mp4        288x162     244k , avc1.42000c, 15.0fps, mp4a.40.5
hls-452      mp4        448x252     452k , avc1.420015, 30.0fps, mp4a.40.5
hls-760      mp4        768x432     760k , avc1.4d001e, 30.0fps, mp4a.40.5
hls-1208     mp4        992x558    1208k , avc1.4d001f, 30.0fps, mp4a.40.5
hls-1884     mp4        1088x612   1884k , avc1.4d001f, 30.0fps, mp4a.40.5
hls-3293     mp4        1280x720   3293k , avc1.64001f, 30.0fps, mp4a.40.5 (best)

Description of your issue, suggested solution and other information
I can no longer download 1080p videos from any of the DiscoveryGO sites.  I don't know if this is an issue with the extractor, or if they are no longer posting 1080p videos.
This is currently available without a login: https://www.discoverygo.com/fast-n-loud/the-race-busch-vs-logano/

No 1080 for this video.


DIGEQ-57 add enable justification checkbox

What
Add a checkbox in enable justification of answers in the survey runner. A justification can only be provided if a warning message is shown. Therefore this field is disabled if the user selects 'error' as the 'validation failure type'. By default the checkbox is unchecked even if the user selects 'warning' as the 'validation failure type'.
How to test

Check out this branch
Add a new survey and add a questionnaire to that survey
On the questionnaire builder page add a text question and numeric question
In the validation rules, set the error type to 'warning'
Enable the justification checkbox
Set the error type to 'error'
7 Check that the justification checkbox is unchecked.

Who can review
Anyone apart from @warren-methods

Functionally this looks good; however I checked with the product team if they ever could consider an occasion when a survey author would create a validation rule that performs a "Soft" check and not want a justification; they couldn't think of one. I think we should amend this to always add a justification flag if a validation has a soft flag. I presume (rightly or wrongly) that a user can give a null justification (i.e. leave it blank?)

If that's the case then we don't need this at all. We can display the justification text box on the survey runner if the error type is warning.

We don't need this, we can just use the validation type field


Vv 226 contract test verify sign up link

What

added contract test for verifySignUpLink

Why
Screenshots
Notes

This branch has been rebased with #840 as addUserToVerification gateway is required for contract testing


Update package.json

update the package.json to support in the window 10

nah ..
rmdir build won't work on mac when the build folder is not empty. I use mac for development, so I need this.
You could use Git Bash as your terminal (rm is supported there). It's documented in the README :)


build.cmd korebuild issues

So build.cmd is blocked from running even after I installed the various listed components:
      "Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
      "Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Win81",
      "Microsoft.VisualStudio.Component.VC.ATL",
      "Microsoft.VisualStudio.Component.Windows10SDK.15063.Desktop"

I went ahead and just removed these entries and was able to build the repo

Run run.ps1 install vs. It will bring up the vs installer. There may be some differences in the components vswhere returns versus what is actually installed.

Is that the correct command?
C:\github\IISIntegration [dev ≡ +0 ~1 -0 !]> .\run.ps1 install vs
Using KoreBuild 2.2.0-preview1-17081
Specify --help for a list of available options and commands.
Exception thrown: 'Microsoft.Extensions.CommandLineUtils.CommandParsingException: Unrecognized command or argument 'install'

build.cmd -u first. That will download a newer version of korebuild.

I was able to run install vs, and it succeeded but I still get the same error:
C:\github\IISIntegration [dev ≡ +0 ~2 -0 !]> .\run.ps1 install vs
Using KoreBuild 2.2.0-preview1-17090
Starting msbuild with arguments: msbuild C:\Users\haok\.dotnet\buildtools\korebuild\2.2.0-preview1-17090\KoreBuild.proj -t:InstallToolsets -v:n
Executing 'C:\Users\haok\.dotnet\x64\dotnet.exe msbuild C:\Users\haok\.dotnet\buildtools\korebuild\2.2.0-preview1-17090\KoreBuild.proj -t:InstallToolsets -v:n'
Microsoft (R) Build Engine version <IP_ADDRESS>72 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 6/15/2018 2:41:06 PM.
     1>Project "C:\Users\haok\.dotnet\buildtools\korebuild\2.2.0-preview1-17090\KoreBuild.proj" on node 1 (InstallToolsets target(s)).
     1>InstallToolsets:
         C:\Users\haok\.dotnet\buildtools\korebuild\2.2.0-preview1-17090\modules\KoreBuild.Tasks\vswhere.exe -latest -prerelease -products Microsoft.VisualStudio.Product.Enterprise -format json
         Found vs installation located at C:\Program Files (x86)\Microsoft Visual Studio\Preview\Enterprise
         Downloading 'https://aka.ms/vs/15/release/vs_Enterprise.exe' to 'C:\Users\haok\AppData\Local\Temp\vs_Enterprise.exe'
         Downloaded visual studio exe to C:\Users\haok\AppData\Local\Temp\vs_Enterprise.exe.
         Calling: C:\Users\haok\AppData\Local\Temp\vs_Enterprise.exe modify --installPath "C:\Program Files (x86)\Microsoft Visual Studio\Preview\Enterprise" --in C:\Users\haok\AppData\Local\Temp\vs_Enterprise.json --wait --norestart
     1>Done Building Project "C:\Users\haok\.dotnet\buildtools\korebuild\2.2.0-preview1-17090\KoreBuild.proj" (InstallToolsets target(s)).

Build succeeded.

C:\Users\haok\.dotnet\buildtools\korebuild\2.2.0-preview1-17090\modules\KoreBuild.Tasks\module.targets(154,5): error : Could not find an installation of Visual Studio that satisifies the specified requirements in C:\Github\IISIntegration/korebuild.jsonExecute run.ps1 install vs to update or install the current vs installation. [C:\Users\haok\.dotnet\buildtools\korebuild\2.2.0-preview1-17090\KoreBuild.proj]

Weird, that shouldn't be happening. Vswhere.exe is the one responsible to for checking which components are installed. Can you check which component vswhere.exe thinks you don't have installed? Ex: emove the  "Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Win81" dependency and build again.

"Microsoft.VisualStudio.Component.Windows10SDK.15063.Desktop"

Let me double check that installed is checked, I manually did these earlier today as well

Alright thanks. This could be a bug with vswhere.exe.

@mikeharder was having fun with this recently. I think VS Where didn't like preview builds?

So I need to install an older non preview build with these components?

no. you shouldn't need to at all. Delete the line in korebuild. I'll ping @mikeharder about the issue with vswhere.exe and how we can fix it in build tools.

Ok cool, next problem I'm seeing is the functional tests are failing locally off a clean dev, is there some other setup I need to do for the functional tests to pass?  IIS is installed and I'm able to create new projects and run them against IIS thru VS...

Run in an administrator console or run this script: https://github.com/aspnet/IISIntegration/blob/dev/tools/update_schema.ps1

Closing, please reopen if there is anything else to do here.


General strategy of this Repo

Hey Scott,
first of all, thanks for making (and not abandoning, haha) Vuetober! I've been wondering why OctoberCMS doesn't offer this via first-party plugins. I wanted to discuss the viability of your additions in large-scale production environments as I am not sure. Please don't take any offense from my harsh-seeming criticism - I'm only trying to spark fruitful discussions, as I might not be the only one thinking this.
OctoberCMS is an extremely powerful framework that (for the most part) lets you get stuff done really quick. Using various layouts you're free to put your content anywhere you like; using plugins you can add Localization support to your application, and so on.
Now, with Vuetober, a lot of these things seem obsolete as you've got the Vue-Router routing to your custom Vue components, first and foremost. Simply put, what you did is pack vue-cli-webpack into a folder and the only business OctoberCMS has with it is running your index file. Any new page you create, any URL scheme change you make, any layout adaption you develop - it all has to be done by the developer, in the respective .vue or .js files. The actual OctoberCMS backend is useless.
In order to make use of the actual CMS part of OctoberCMS, we have to install API plugins that expose our data to a public endpoint (seemingly without any means of internal security, like access tokens, although that's not a huge caveat as I don't see how you could exploit that), and we have to fetch these data and forward them to our component tree or use Vuex to have components watch changes to the ground truth.
This.
Is.
Super.
Cumbersome.
Then I might as well write a clean Laravel/Lumen API if I can't access October's benefits out of the box, besides having to take care of all of my routing.
I stumbled across Vuetober while looking for something that enables me to easily combine vue-cli into the original OctoberCMS process, i.e. still use the ecosystem with the October router automagically finding the corresponding page, layouts, components, while having the benefit of HMR during development and Reactiveness on the web application itself.
The largest issue I have is that I won't be able to hand the CMS part to my clients and say "there you go, just click 'Add Page', type your desired URL, click that 'EN' thing to translate the page to different languages, and it'll just work!". I work a lot with repeaters and custom tabs in layout files to make it easier for customers to e.g. create a "staff" page. I do not currently see any way to access such functionality from within a Vuetober theme - or at least, not without using JS libraries for parsing the staff.htm page for its variables. What you suggest in #26 is not at all sufficient, because in most cases it is not simply content but a composition of (OctoberCMS) components.
I think #24 is the closest discussion to what I am looking to achieve with this, although I am not completely certain.
Some brainstorming:
Would it be possible to have some kind of watcher running upon OctoberCMS's "save action", that then parses any .htm files changed/created by OctoberCMS, grabs the respective layout and components' markup, fills it with the variables some non-developer changed via the backend, and adds this to e.g. my StaticPage.vue template slot automagically, furthermore inserting a route into my router?

Hi, you make some good points here. This project came about because of the way that I personally was using October. The frontend tools for October, while good, do not operate at the level I needed them to. For example, how do you unit test an October component? How would you make an SPA with them? How would you integrate build tools to write modern javascript? etc...
It was these sorts of road blocks that led me to develop Vuetober, and I developed it with this mindset... "October's backend is amazing, but I want to handle the frontend". This is why I generally don't work with plain Laravel/Lumen projects. Yes, creating the APIs and the frontend would be the same as with Vuetober, but I wouldn't have the ability to quickly make beautiful lists and forms to manage everything. October's backend still gives me that, as well other things like administrator roles, dashboards, plugins I can integrate, and so on.
With that said, some of the concerns you have are totally valid. I don't think Vuetober would be a good fit for something you're looking to hand off to a client. This project is a better fit for sites that are going to have a developer working on it.
As for your concern about exposing endpoints to the public, there are no security concerns here. If you're using Vuetober with the RainLab.User plugin, just wrap your routes in this middleware I added a while back. This will give you basic authenticated routes, but if you need something fancier there should be nothing preventing you from implementing that.
And lastly, it might be possible to get Vuetober working with October's frontend tooling, I just have not dug into this much. @daftspunk even had the idea a while back to use October's component system to make plug-and-play APIs, which could be a really cool technique. I'd be interested to see the results of any experiments you (or anyone else) does with regard to this.


LS fails to start with Could not find an SCM for dependency :sourceror

Environment

Elixir & Erlang versions (elixir --version): Erlang/OTP 25 [erts-13.2] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit:ns] Elixir 1.14.4 (compiled with Erlang/OTP 25)
Elixir Language Server version:  ElixirLS release v0.14.5
Operating system: Windows 10 German
Editor or IDE name (e.g. Emacs/VSCode): VSCode
Editor Plugin/LSP Client name and version: ElixirLS: Elixir support and debugger v0.14.5

Current behavior
ElixirLS does not start 5 times and is shut dwn
Logs:
Starting ElixirLS release v0.14.5
Running in c:/Daten/Code/elixir/servy
** (Mix.Error) Could not find an SCM for dependency :sourceror from ElixirLS.LanguageServer.Mixfile
(mix 1.14.4) lib/mix.ex:513: Mix.raise/2
(mix 1.14.4) lib/mix/dep/loader.ex:195: Mix.Dep.Loader.with_scm_and_app/4
(mix 1.14.4) lib/mix/dep/loader.ex:141: Mix.Dep.Loader.to_dep/3
(elixir 1.14.4) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
(elixir 1.14.4) lib/enum.ex:1658: Enum."-map/2-lists^map/1-0-"/2
(mix 1.14.4) lib/mix/dep/loader.ex:358: Mix.Dep.Loader.mix_children/2
(mix 1.14.4) lib/mix/dep/loader.ex:316: anonymous fn/4 in Mix.Dep.Loader.mix_dep/2
(mix 1.14.4) lib/mix/project.ex:397: Mix.Project.in_project/4
[Error - 10:39:19 AM] Server initialization failed.
Message: Pending response rejected since connection got disposed
Code: -32097
[Info  - 10:39:19 AM] Connection to server got closed. Server will restart.
true
Repro
open VS with empty mix project
uninstalling / reinstalling VS Code plugin did not help
Expected behavior
it starts

Please ensure if you have hex installed. If you do please try removing all files and dirs from Mix.Utils.mix_cache()

hex was installed, clearing the cache helped

I'm going to close this. If anybody has repro steps for the stacktrace please post it here or report to elixir bugtracker


Be able to delete users

As an admin of the dashboard, I want to be able to delete users. Should not be able to delete my own user.

Hello, Bentalese, i will like to help with this issue but i need an understanding of the project, its directories and files


Add support for getSourceReport - now final

The VM Service has now added a stable getSourceReport API – it was added at some point in 1.16 SDK
Would be good to expose this API in this package.

@johnmccutchan @turnidge: What version of the VM service protocol first included this method?

Looks like it was added in 3.1 - see here https://github.com/dart-lang/sdk/commit/bf385e448c30323d68524df99f7329174f70ceef

https://codereview.chromium.org/1929063002/

Wondering if this can be prioritized? This may seem like a low priority but a lot of community package builds are broken because of this and coverage package.


Only resize if smaller/larger

So the documentation for vipsthumbnail mentions

You can append < or > to mean only resize if the image is smaller or larger than the target.

How do I do this in php?

Hello @andrews05, the C docs have all the detail:
http://jcupitt.github.io/libvips/API/current/libvips-resample.html#vips-thumbnail
So you use the optional size parameter, for example:
$tiny = $huge->thumbnail(128, ["size" => "down"]);

And it'll only downsize.

Thank you! Sorry, still finding my way around the documentation I need.


If branch = label then new commits are only pulled when flux is started

Following option 2) https://github.com/weaveworks/flux/blob/master/site/faq.md#i-have-a-dedicated-kubernetes-cluster-per-environment-and-i-want-to-use-the-same-git-repo-for-all-how-can-i-do-that
If you happen to set the label to the same as the branch name, then the newest commit (abc...) on startup of flux is fetched and applied. But then from there on out every time it polls it will say that HEAD=abc... and not apply changes even if you've since pushed a new commit. Restarting flux will then cause it to fetch the actual newest commit and start over being stuck at that commit.
Changing the label to something else, doing git push --delete origin tags/<label> and then restarting flux fixes this.

We can

make sure we fully qualify refs when asking which revisions they point to, and
(if still necessary) warn if we detect that the tag has the same name as a branch.

@sebastianblunt may I ask you what version on Flux you are running? I tried to replicate the issue to start working on it but I am seeing different behavior from Flux than what you describe.
In my setup (running of a build from latest master, with --git-branch and --git-label set to something), new commits are applied but the actual tag never reaches git (which is nevertheless something that needs to be fixed).

I'm still on 1.8.1.

Thanks for the speedy response!
This changes the issue to: if --git-branch and --git-label have the same name, Flux (silently) fails to create a sync tag.