HDFS-15711. Add Metrics to HttpFS Server.

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
26m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 26s

trunk passed

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
shadedclient
16m 44s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 50s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 49s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
compile
0m 20s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 20s

the patch passed

-0 :warning:
checkstyle
0m 17s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 3 new + 49 unchanged - 0 fixed = 52 total (was 49)

+1 :green_heart:
mvnsite
0m 29s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
15m 13s

patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 24s
/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04.txt
hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)

-1 :x:
javadoc
0m 23s
/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt
hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)

-1 :x:
findbugs
0m 50s
/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.html
hadoop-hdfs-project/hadoop-hdfs-httpfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
5m 19s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

109m  8s

Reason
Tests

FindBugs
module:hadoop-hdfs-project/hadoop-hdfs-httpfs

Write to static field org.apache.hadoop.fs.http.server.HttpFSServerWebApp.metrics from instance method org.apache.hadoop.fs.http.server.HttpFSServerWebApp.init()  At HttpFSServerWebApp.java:from instance method org.apache.hadoop.fs.http.server.HttpFSServerWebApp.init()  At HttpFSServerWebApp.java:[line 111]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4a0c4347a290 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7dda804a1a7

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/1/testReport/

Max. process+thread count
717 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 59s

trunk passed

+1 :green_heart:
compile
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
16m  5s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 48s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 48s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 21s

the patch passed

-0 :warning:
checkstyle
0m 16s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt
hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 2 new + 49 unchanged - 0 fixed = 51 total (was 49)

+1 :green_heart:
mvnsite
0m 29s

the patch passed

-1 :x:
whitespace
0m  0s
/whitespace-eol.txt
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedclient
14m 41s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 48s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m 18s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

80m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5401478f2ba9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7dda804a1a7

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/2/testReport/

Max. process+thread count
716 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
31m 18s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 14s

trunk passed

+1 :green_heart:
compile
0m 27s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 22s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
shadedclient
18m  7s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 22s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 45s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 42s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 22s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
checkstyle
0m 13s

the patch passed

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 39s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 21s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 49s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m  6s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

116m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2fdc2afda5a0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / da1ea2530fa

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/3/testReport/

Max. process+thread count
708 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 45s

trunk passed

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
shadedclient
16m 18s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 49s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 48s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 26s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m  6s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 49s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m 20s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

81m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7bceb921af61 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 01383a21722

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/4/testReport/

Max. process+thread count
719 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 29s

trunk passed

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 30s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
17m  7s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 50s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 47s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  1s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m  5s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 47s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m 21s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

81m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2521

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 406d6f7b4e04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c2cecfc9b95

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/5/testReport/

Max. process+thread count
719 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Angular+Tailwind: New classes are not added when symlink is present

Preamble
Yes, this bug report is very unspecific to webpack and I cannot say what is wrong where, because I don't have the knowledge, but the tailwind developer said the bug could be in webpack and the angular developer said the problem seems to rely in webpack.
My previous issues leading me to webpack:
https://github.com/tailwindlabs/tailwindcss/issues/10555
https://github.com/angular/angular-cli/issues/24705
Information from @thecrypticace (tailwind developer)

On the initial build we are returning the expected content paths from our plugin for postcss-loader to hand off to webpack.
On subsequent builds Tailwind CSS itself isn't called at all by Angular (I'm guessing PostCSS itself isn't called)
This problem is only present when a glob path is passed to postcss-loader AND there is a symlink inside the "root" (non-dynamic) directory of the glob path.
I suspected this was a problem with the persistent cache but disabling the angular cache does not fix this.

He said that he is willing to provide additional information if needed.
Information from @alan-agius4 (angular developer)

This seems to be an issue with Webpack itself.
I can see that the correct dependencies are added by postcss/tailwinds in<EMAIL_ADDRESS>But, for some reason when the added ContextDependency is a directory with a nested symlink, Webpack do not invalidate the correct files.

Bug report
New tailwind classes are not added in ng serve without restarting it, while a symlink exists in tailwinds content path.
This issue can be fixed by removing the symlink. Now class changes are added without restarting ng serve.
It does not matter what file type it is, the existence of a symlink is enough to break it.
Actual Behavior
Changes in files are not reflected in watched output.
Expected Behavior
The dependency should be invalidated and recompiled.
How Do We Reproduce?
setup new angular project:
ng new --minimal --style scss --defaults tailwind-symlink-bug
cd tailwind-symlink-bug/
npm install --save-dev tailwindcss
ln -s<EMAIL_ADDRESS>src/assets/README.md
echo "module.exports = { content: ['./src/**/*.{html,ts}'] };" > tailwind.config.js
echo -e "@tailwind base;\n@tailwind components;\n@tailwind utilities;" > src/styles.scss

replace html in app.component.ts with following:

start:
ng serve

You will see a red square. Now change bg-red-500 to bg-green-500 -> the square will disappear, as the new tailwind class is not generated. A restart of ng serve will add it.
If you remove the symlink at src/assets/README.md and restart ng serve, the problem above does not appear.

Sorry for delay, sounds like symlinks are disabled in ng
/cc @alan-agius4

You can try to enable "preserveSymlinks": true in the build section of your angular.json?

It is and was enabled, as I use shared types between client and server. So this does not fix the problem.

@bagbag Can you try to reproduce it with pure webpack setup

@bagbag That is why I think something wrong in angluar, postcss-loader don't know about symlinks nothing

/cc @alan-agius4

@bagbag Hope you solved your problem, if no please open an issue in angular-cli repo (you can ping me), postcss-loader doesn't know nothing about files/symlinks and etc, so the problem is not here
If you still have a problem can you provide a reproducible example?

@alexander-akait I haven't tested it with the current versions, but there was nothing solved back then. There is already an issue and example at https://github.com/angular/angular-cli/issues/24705.


How to uninstall open horizon

I installed open horizon, it was working fine but I forgot to save HZN_ORG_ID and HZN_EXCHANGE_USER_AUTH. Then I restarted my system, after restart I was unable to make connection with horizon api (getting error). I tried reinstalling it but I was getting same error in re-installation.
Error: Can't connect to the Horizon REST API to run GET http://localhost:8510/node. Run 'systemctl status horizon' to check if the Horizon agent is running. Or set HORIZON_URL to connect to another local port that is connected to a remote Horizon agent via a ssh tunnel. Specific error is: Get "http://localhost:8510/node": dial tcp <IP_ADDRESS>:8510: connect: connection refused
Output of command "systemctl status horizon":
horizon.service - Service for Horizon control system
Loaded: loaded (/lib/systemd/system/horizon.service; enabled; vendor preset: enabled)
Active: failed (Result: exit-code) since Fri 2021-01-15 00:45:54 IST; 15min ago
Process: 23471 ExecStart=/usr/horizon/bin/anax -v $ANAX_LOG_LEVEL -logtostderr -config /etc/horizon/anax.json (code=exited, status=98)
Main PID: 23471 (code=exited, status=98)
Jan 15 00:45:54 user-Vostro-3546 systemd[1]: horizon.service: Service hold-off time over, scheduling restart.
Jan 15 00:45:54 user-Vostro-3546 systemd[1]: horizon.service: Scheduled restart job, restart counter is at 6.
Jan 15 00:45:54 user-Vostro-3546 systemd[1]: Stopped Service for Horizon control system.
Jan 15 00:45:54 user-Vostro-3546 systemd[1]: horizon.service: Start request repeated too quickly.
Jan 15 00:45:54 user-Vostro-3546 systemd[1]: horizon.service: Failed with result 'exit-code'.
Jan 15 00:45:54 user-Vostro-3546 systemd[1]: Failed to start Service for Horizon control system.

I would love to work on this issue. Please assign it to me.

Please assign this issue to me as well.

@tinkoosingh I could get around this by removing the packages horizon and horizon-cli completely i.e.
apt-get remove horizon horizon-cli
Then simply re-run the script. There is also a flag -P (when used with -S that solves the issue) but it also deletes the created volumes for the containers.
Did you find a better alternative?

Uninstall feature was already there in existing script, only image deletion logic was missing. So fixed as part of pr https://github.com/open-horizon/devops/pull/42.
Hence closing this issue.


slumber not detected as Python 3 compatible

The slumber library is compatible with Python 3, and its setup.py includes the Python 3.4 trove classifier. It is, however, flagged as not compatible:
$ caniusepython3 --projects slumber
Finding and checking dependencies ...

You need 1 project to transition to Python 3.
Of that 1 project, 1 has no direct dependencies blocking its transition:

  slumber

@foobuzz that's because they haven't updated their metadata on PyPI: notice how https://pypi.org/project/slumber/ lacks any list of classifiers in the right-hand column. Would you like to provide a PR to add the project to the overrides.json file?


Add 'Good for first PR flag'

Good evening! I complete #176 task, can you review my code, and give me advice on how I can improve it? Thanks!

Hello! thanks for PR but could you add some screenshots for understanding how it look like?

Hello! Thanks for your answer, now this is a very simple implementation, I thought to add an icon (for example font awesome), but did not do it without asking you.
If you gave me advice on how to improve this, I would be grateful to you, thanks
Some screenshots.


[ios] Crash when sharing from screenshot preview

Trying to share a screenshot from the screenshot preview, or an image from the Twitter app, the share extension crashes.
This is because the incoming image data has type UIImage, not the expected type, URL.
Both these PRs offer suggested fixes: https://github.com/ajith-ab/react-native-receive-sharing-intent/pull/65 and https://github.com/ajith-ab/react-native-receive-sharing-intent/pull/126

Duplicate of https://github.com/ajith-ab/react-native-receive-sharing-intent/issues/56


Syntax Highlighting

If you add a .gitattributes file at the root of your repo, you can map a file extension with an existing syntax. If you put JavaScript for example, then it's going to try and highlight your language as JavaScript and while not perfect, will look a lot better than the all black version :)
// .gitattributes
*.delta linguist-language=JavaScript

Thanks! Definitely makes the code nicer to read on GitHub. 👍 However it also causes GitHub to report the language statistics incorrectly. I'll try using this for a while to see how it feels.

Yeah, that's unfortunate, haven't found a workaround for this :(


⚠ Turnos 24x7 has degraded performance

In e8357fc, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1058 ms

Resolved: Turnos 24x7 performance has improved in 324eac0.


Request: Remove Combine Dependency

This library is soooo close to being able to work on Linux and provide easy mocking in the Swift on Server ecosystem. Unfortunately, it's utilizing Combine which is not available on Linux.
Can you remove the Combine dependency and support Linux?
If you require a current value subject that's linux and async/await compatible, might I suggest an implementation similar to this one?

Started work on this in #94

@Tyler-Keith-Thompson You were right as the CI job passed on linux for the first run after removing Combine 🚀

@Tyler-Keith-Thompson Linux support was added in Mockable 0.2.0

Fantastic! Thank you!


Code completion for properties show the type as the property name

It should show the property name instead.

Fixed by https://github.com/gradle/declarative-lsp/commit/caff8a1f93ff47eedb478009c1409178db0c5354


fix: update conditions in 'indicesOfNearest' for custom series. close #14869

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

Fix wrong calculation for axis pointer
Fixed issues

#14869

Details
Before: What was the problem?

https://jsfiddle.net/kbztor76/

Use provided example (with option 'trigger: axis' for tooltip)
Slide along one bar by mouse
In the middle of the bar, the tooltip changes and shows info from the next bar

After: How is it fixed in this PR?

Update condition and choose the one that diff >= 0

Misc

[ ] The API has been changed (apache/echarts-doc#xxx).
[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
NA.
Others
Merging options

[x] Please squash the commits into a single one when merge.

Other information

Hi, thanks for your contribution first. We only need to commit the directly related changes. It's unnecessary to commit those dist/i18n files and package-lock.json.

Hi, thanks for your contribution first. We only need to commit the directly related changes. It's unnecessary to commit those dist/i18n files and package-lock.json.

Thanks, I've updated pr

@100pah Please take a look at this change

@pissang @plainheart @AndrewRatnikov
I think this issue can not be resolved by change the condition when finding "nearest data".
(This PR seems do not change the effect).
To resolve this issue, I think we probably enhance the strategy from "finding the nearest data item" to "finding nearest graphic element". "finding the nearest data item" is only suitable to charts like scatter, where all of the elements are the same. For series with variable size of elements, we should better travel the elements and find the one that is nearest to the axis pointer. The travel could be based on List#getItemGraphicEl().


[Bug]: IVideo.DeleteAsync() hangs

Version
1.42.0
Steps to reproduce
I raised a similar issue before. It looks like PathAsync works, but DeleteAsync hangs.
I believe it only occurs when the page has not been interacted with, which can happen in our test suite, as we spawn a new browser in a SetUp method, but then the test might execute some logic to realise it doesn't need to run on the current environment, and then the browser closes without any other interaction.
This should be able to replicate it:
var pw = await Playwright.CreateAsync();

var browser = await pw.Chromium.LaunchAsync();

var context = await browser.NewContextAsync(new BrowserNewContextOptions
{
    RecordVideoDir = Environment.CurrentDirectory
});

var page = await context.NewPageAsync();

await page.Video!.DeleteAsync();

Console.WriteLine("Finished");

Expected behavior
Video file deletes
Actual behavior
.NET process hangs indefinitely
Additional context
No response
Environment
.NET 6/7/8

Windows + Linux

Video.DeleteAsync will wait until the video processing is done. It's done when the page has been closed, so doing the following works for me:
var pw = await Playwright.CreateAsync();

var browser = await pw.Chromium.LaunchAsync();

var context = await browser.NewContextAsync(new BrowserNewContextOptions
{
    RecordVideoDir = Environment.CurrentDirectory
});

var page = await context.NewPageAsync();
await context.CloseAsync();
await page.Video!.DeleteAsync();

Console.WriteLine("Finished");

Ah my bad. Thanks!


Update steampipe-plugin-sdk to v1.5.1

Closing this Issue, since we will be tracking it here as a part of the maintenance schedule


TypeScript comments showing up on OperatorHub.io

When selecting any Operator on operatorhub.io and selecting Install, the following shows up on the right side: // @ts-ignore

Thanks for reporting this!  We will be working on the fix shortly.

The issue has been fixed with this merged PR:
https://github.com/operator-framework/operatorhub.io/pull/241
Thanks!


feat(TextInput): Convert TextInput (Part 4) - TextInputAction & TextInputInnerVisualSlot

Closes https://github.com/github/primer/issues/4365

Changelog

New

Changed

Updated TextInputAction  to use CSS modules behind feature flag
Updated TextInputInnerVisualSlot  to use CSS modules behind feature flag
Updated snapshots

Removed

Rollout strategy

[ ] Patch release
[x] Minor release
[ ] Major release; if selected, include a written rollout or migration plan
[ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

[x] Added/updated tests
[ ] Added/updated documentation
[ ] Added/updated previews (Storybook)
[ ] Changes are SSR compatible
[x] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge
[ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

Failing integration tests are the same owns failing in main https://github.com/primer/react/pull/5276


Catalog should not be created without catalogType

Catalog can be created successfully without catalog type:

When get this catalog, its catalog type is empty.

Both catalogType and properties are not required now, in order to allow user to create an empty catalog and update it later.
@FireDefend please correct me if I'm wrong.
PS: this is not an OSS related issue.


Restore build service listener subscription for build service from included build correctly

Before this change, BuildServiceProvider instances would be written to the configuration cache in the context of the build in which they are referenced, no matter which build they were registered with. That has implications when build services are registered as build event listeners since event listener subscriptions are stored in the context of the root build.
After this change, BuildServiceProvider instances registered as build event listeners are simply marked as used and then later written to the cache in the context of the correct build.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


New Pre-Release

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c15bfc4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #91   +/-   ##
=========================================
  Coverage          ?   87.93%
=========================================
  Files             ?      277
  Lines             ?     6697
  Branches          ?        0
=========================================
  Hits              ?     5889
  Misses            ?      808
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15bfc4...db6136a. Read the comment docs.


cargo-doc and reexported types

Example (lib.rs):
extern crate serde;

pub mod reexport {
    pub use serde::Serialize;
    pub use serde::ser::Error as SerError;
}

In the generated documentation for the reexport::SerError type there is a reference to the serde::Serialize, but this reference is broken (target/doc/reexport_test/trait.Serialize.html instead of target/doc/reexport_test/reexport/trait.Serialize.html).

Thanks for the report! I think this is a bug with rustdoc though perhaps, not Cargo? Mind reopening in rust-lang/rust?


Refactor: Modeld: Extract model running logic to separate classes

Description
The model running logic has been refactored into separate classes for TICI and non-TICI hardware: TinygradRunner and ONNXRunner. These classes are located in the new file model_runner.py. The runners handle all tasks related to model execution, including preparing inputs, running the model, and slicing the outputs. This makes modeld.py cleaner, and easier to manage and debug.
Sequence diagram for model inference process
sequenceDiagram
    participant M as Modeld
    participant R as ModelRunner
    participant T as TinygradRunner/ONNXRunner

    M->>R: prepare_inputs(imgs_cl, numpy_inputs)
    R->>T: prepare_inputs(imgs_cl, numpy_inputs)
    T-->>M: prepared inputs

    M->>R: run_model()
    R->>T: run_model()
    T-->>R: model outputs
    R->>R: slice_outputs()
    R-->>M: parsed outputs

Class diagram for ModelRunner hierarchy
classDiagram
    class ModelRunner {
        <<abstract>>
        +model_metadata
        +input_shapes
        +output_slices
        +inputs: dict
        +__init__()
        +slice_outputs(model_outputs)
        +prepare_inputs(imgs_cl, numpy_inputs)*
        +run_model()*
    }

    class TinygradRunner {
        +model_run
        +__init__()
        +prepare_inputs(imgs_cl, numpy_inputs)
        +run_model()
    }

    class ONNXRunner {
        +runner
        +frames
        +__init__(frames)
        +prepare_inputs(imgs_cl, numpy_inputs)
        +run_model()
    }

    ModelRunner <|-- TinygradRunner
    ModelRunner <|-- ONNXRunner

    note for ModelRunner "Abstract base class for model runners"
    note for TinygradRunner "Implementation for TICI hardware"
    note for ONNXRunner "Implementation for non-TICI hardware"

Verification

Ran the pipelines and drove the code changes

@YassineYousfi FYI


lean: 3.23.0 -> 3.24.0

Motivation for this change
Mathlib has updated to use the new version of lean so to stay up to date we have to update lean as well.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

And it builds on aarch64 again!

And it builds on aarch64 again!


Fade duration time is broken in version 2.4.1

When there is a time (in my case 1000ms) in "fade duration" in version 2.4.1, the fader won't move. When the time is set to 0, it moves fine. When reverting back to version 2.4.0 the functionality is restored. I made a video demonstrating what I am talking about.
https://www.dropbox.com/s/w2gitdv4efirx23/IMG_0642.MOV?dl=0

@istnv
Thank you for looking into this. I did a full uninstall of Companion and re-installed version 2.4.1 and everything is working fine. I appreciate the quick response!


Skills won't increment over 6-

No matter what I do, I cannot get a skill over 6-.

I believe I fixed this in the most recent release, though I'm not 100% certain all the math is correct

Still an issue in 2.0.5. Now the skill will display correctly but still rolls as if it's 6-.

Please try the most recent release. Note this is still not fixed for skills derived from the 'power' type item as that item type needs a rework

Actually, I have! Works great now. I feel like I could run my Fantasy HERO game if the character sheet form were scrollable or able to be resized.
I keep checking for updates and I was not disappointed by the latest iteration. It's getting there!
On Wednesday, March 8, 2023 at 09:25:25 PM EST, dmdorman @.***> wrote:
Please try the most recent release. Note this is still not fixed for skills derived from the 'power' type item as that item type needs a rework
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Can confirm. Works with added skills, but not with power derived skills.

I believe this should work for power derived skills as of Version 2.1.0

Confirmed. Working in 2.1.0


Added scale tag

Added the scale tag, this allows you to spin up multiple instances of the same container without redefining it multiple times.

@Frueber I'll be holding off on completing this until after version 1.0 is released (that should be feature locked at this point), but I wanted to get this to you for review now in case there was something you noticed.


error FS0192: internal error: null: GetTRefType

I never got this error before, but now when I call this bit of the F# Data docs generation script:
Literate.ProcessDirectory
  ( dir, docTemplate, output @@ sub, replacements = ("root", root)::info,
    layoutRoots = layoutRoots, fsiEvaluator = fsiEvaluator )

I get this error
error FS0192: internal error: null: GetTRefType

Get it both on VS2013 and VS2015. I tried to downgrade F# Formatting to previous version I used without issues, but now it doesn't work anymore. I have to idea of what's going on
Ideas?

I think referencing FSharpVSPowerTools.Core should work e.g. https://github.com/fsprojects/ProjectScaffold/commit/29be5a01404a755755c90f1812c1c6b456cdf4d9 or https://github.com/fsprojects/Paket/commit/081bc56245eb9e97556000f94fd089a915b0cb49.
I think this is the same issue as https://github.com/tpetricek/FSharp.Formatting/issues/261.

Thanks, the reference fixed that issue, though now I have a bunch of other problems :/
I get these error messages in the middle of all the warnings:
  [2 sec] Error while building member-name for FSharp.Data.CsvRow because: the type '[]`1' does not have a qualified name
  [2 sec] Error while building member-name for FSharp.Data.HtmlDocumentExtensions.Descendants because: not a named type
  [2 sec] Error while building member-name for FSharp.Data.HtmlDocumentExtensions.Descendants because: not a named type
  [2 sec] Error while building member-name for FSharp.Data.HtmlDocumentExtensions.DescendantsWithPath because: not a named type
  [2 sec] Error while building member-name for FSharp.Data.HtmlDocumentExtensions.DescendantsWithPath because: not a named type
  [2 sec] Error while building member-name for FSharp.Data.TextConversions.AsFloat because: the type '[]`1' does not have a qualified name
  [2 sec] Error while building member-name for FSharp.Data.Runtime.JsonConversions.AsFloat because: the type '[]`1' does not have a qualified name

And then at the end I get this crash:
System.InvalidCastException: The result type 'RazorEngine.Compilation.RazorDynamicObject' of the dynamic binding produced by the object with type 'RazorEngine.Compilation.RazorDynamicObject' for the binder 'Microsoft.CSharp.RuntimeBinder.CSharpConvertBinder' is not compatible with the result type 'FSharp.MetadataFormat.Type' expected by the call site.
   at CallSite.Target(Closure , CallSite , Object )
   at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
   at ActLike_IEnumerator`1_2514cc75195440fa9e6a5aaebbe5c7b3.get_Current()
   at System.Collections.Generic.List`1.InsertRange(Int32 index, IEnumerable`1 collection)
   at CallSite.Target(Closure , CallSite , List`1 , Object )
   at System.Dynamic.UpdateDelegates.UpdateAndExecuteVoid2[T0,T1](CallSite site, T0 arg0, T1 arg1)
   at CompiledRazorTemplates.Dynamic.RazorEngine_428c500878434cd6a28d8152bd48fb65.Execute() in c:\Git\FSharp.Data\docs\tools\templates\part-nested.cshtml:line 4
   at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context, TextWriter reader)
   at RazorEngine.Templating.TemplateBase.<>c__DisplayClass3.<Include>b__2(TextWriter tw)
   at RazorEngine.Templating.TemplateWriter.WriteTo(TextWriter writer)
   at RazorEngine.Templating.TemplateBase.Write(TemplateWriter helper)
   at CompiledRazorTemplates.Dynamic.RazorEngine_baf87a52e7974a3b8d986c4b0f2a4985.Execute() in c:\Git\FSharp.Data\packages\FSharp.Formatting\templates\reference\namespaces.cshtml:line 43
   at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context, TextWriter reader)
   at RazorEngine.Templating.RazorEngineCore.RunTemplate(ICompiledTemplate template, TextWriter writer, Object model, DynamicViewBag viewBag)
   at RazorEngine.Templating.RazorEngineService.RunCompile(ITemplateKey key, TextWriter writer, Type modelType, Object model, DynamicViewBag viewBag)
   at RazorEngine.Templating.DynamicWrapperService.RunCompile(ITemplateKey key, TextWriter writer, Type modelType, Object model, DynamicViewBag viewBag)
   at RazorEngine.Templating.RazorEngineServiceExtensions.<>c__DisplayClass4.<RunCompile>b__3(TextWriter writer)
   at RazorEngine.Templating.RazorEngineServiceExtensions.WithWriter(Action`1 withWriter)
   at RazorEngine.Templating.RazorEngineServiceExtensions.RunCompile(IRazorEngineService service, String name, Type modelType, Object model, DynamicViewBag viewBag)
   at <StartupCode$FSharp-MetadataFormat>.$Razor.ProcessFileModel@130.Invoke(Unit _arg1) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 131
   at FSharp.MetadataFormat.RazorRender.handleCompile[a](String source, FSharpFunc`2 f) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 95
   at FSharp.MetadataFormat.RazorRender.ProcessFileModel[b](Type modelType, Object model, FSharpOption`1 properties) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 130
   at FSharp.MetadataFormat.RazorRender`1.ProcessFile[a](model model, FSharpOption`1 properties) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 137
   at FSharp.MetadataFormat.MetadataFormat.Generate(FSharpList`1 dllFiles, String outDir, IEnumerable`1 layoutRoots, FSharpOption`1 parameters, FSharpOption`1 namespaceTemplate, FSharpOption`1 moduleTemplate, FSharpOption`1 typeTemplate, FSharpOption`1 xmlFile, FSharpOption`1 sourceRepo, FSharpOption`1 sourceFolder, FSharpOption`1 publicOnly, FSharpOption`1 libDirs, FSharpOption`1 otherFlags, FSharpOption`1 markDownComments, FSharpOption`1 urlRangeHighlight, FSharpOption`1 assemblyReferences) in c:\Tomas\Public\FSharp.Formatting\src\FSharp.MetadataFormat\Main.fs:line 1128
   at <StartupCode$FSI_0002>.$FSI_0002.main@() in C:\Git\FSharp.Data\docs\tools\generate.fsx:line 144
Stopped due to error

Do you use the load script i.e. https://github.com/fsprojects/Paket/commit/081bc56245eb9e97556000f94fd089a915b0cb49? Hopefully @matthid can help with these issues.

Yes, I did: https://github.com/fsharp/FSharp.Data/commit/61aef22473f552d23ef33261fb0b003ddd3e47a2

I think this is basically the same root cause as https://github.com/Antaris/RazorEngine/issues/248. It is really hard to find a good default when anonymous types are involved (https://github.com/tpetricek/FSharp.Formatting/blob/master/misc/templates/reference/namespaces.cshtml#L46). The idea for the new recursive wrapping behavior was that we can now support "inner" anonymous classes, but a wrapper can only do so much... when you start using concrete types in the middle it will break apart... Its actually a bit hidden in the template:

Model is a wrapper
Model.Types is a wrapper
typesAndModules.AddRange expects an IEnumerable<object>
Model.Types doesn't implement IEnumerable<object> however we return a wrapper anyway (because we support casting to interfaces in the hope that the underlaying object implements it, or at least has all the members)
on the returned wrapper object the call to the property Current fails because the Current member with the expected signature doesn't exist.

This is really a sick edge case and the following should work:
typesAndModules.AddRange((IEnumerable<FSharp.MetadataFormat.Type>)Model.Types);
typesAndModules.AddRange((IEnumerable<FSharp.MetadataFormat.Module>)Model.Modules);

Please try that and report back the results. Of course you can always stick to static types. I'm not sure if RazorEngine can ever perfectly support anonymous types. But as this is now the second time somebody is hit by this I'm thinking of changing back the defaults...

Tried replacing lines 4 and 5 in https://github.com/fsharp/FSharp.Data/blob/master/docs/tools/templates/part-nested.cshtml with this:
typesAndModules.AddRange((IEnumerable<FSharp.MetadataFormat.Type>)Model.Types);
typesAndModules.AddRange((IEnumerable<FSharp.MetadataFormat.Module>)Model.Modules);

But got same error:
System.InvalidCastException: The result type 'RazorEngine.Compilation.RazorDynamicObject' of the dynamic binding produced by the object with type 'RazorEngine.Compilation.RazorDynamicObject' for the binder 'Microsoft.CSharp.RuntimeBinder.CSharpConvertBinder' is not compatible with the result type 'FSharp.MetadataFormat.Type' expected by the call site.
>    at CallSite.Target(Closure , CallSite , Object )
   at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
   at ActLike_IEnumerator`1_595e3c03faf64c8c83ccbf016e2b3e1a.get_Current()
   at System.Collections.Generic.List`1.InsertRange(Int32 index, IEnumerable`1 collection)
   at System.Collections.Generic.List`1.AddRange(IEnumerable`1 collection)
   at CompiledRazorTemplates.Dynamic.RazorEngine_762bacced35a4ab389ff7753ba4f1355.Execute() in c:\Git\FSharp.Data\docs\tools\templates\part-nested.cshtml:line 4
   at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context, TextWriter reader)
   at RazorEngine.Templating.TemplateBase.<>c__DisplayClass3.<Include>b__2(TextWriter tw)
   at RazorEngine.Templating.TemplateWriter.WriteTo(TextWriter writer)
   at RazorEngine.Templating.TemplateBase.Write(TemplateWriter helper)
   at CompiledRazorTemplates.Dynamic.RazorEngine_169a5a913d1d42c5a215c825b5296a17.Execute() in c:\Git\FSharp.Data\packages\FSharp.Formatting\templates\reference\namespaces.cshtml:line 43
   at RazorEngine.Templating.TemplateBase.RazorEngine.Templating.ITemplate.Run(ExecuteContext context, TextWriter reader)
   at RazorEngine.Templating.RazorEngineCore.RunTemplate(ICompiledTemplate template, TextWriter writer, Object model, DynamicViewBag viewBag)
   at RazorEngine.Templating.RazorEngineService.RunCompile(ITemplateKey key, TextWriter writer, Type modelType, Object model, DynamicViewBag viewBag)
   at RazorEngine.Templating.DynamicWrapperService.RunCompile(ITemplateKey key, TextWriter writer, Type modelType, Object model, DynamicViewBag viewBag)
   at RazorEngine.Templating.RazorEngineServiceExtensions.<>c__DisplayClass4.<RunCompile>b__3(TextWriter writer)
   at RazorEngine.Templating.RazorEngineServiceExtensions.WithWriter(Action`1 withWriter)
   at RazorEngine.Templating.RazorEngineServiceExtensions.RunCompile(IRazorEngineService service, String name, Type modelType, Object model, DynamicViewBag viewBag)
   at <StartupCode$FSharp-MetadataFormat>.$Razor.ProcessFileModel@130.Invoke(Unit _arg1) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 131
   at FSharp.MetadataFormat.RazorRender.handleCompile[a](String source, FSharpFunc`2 f) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 95
   at FSharp.MetadataFormat.RazorRender.ProcessFileModel[b](Type modelType, Object model, FSharpOption`1 properties) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 130
   at FSharp.MetadataFormat.RazorRender`1.ProcessFile[a](model model, FSharpOption`1 properties) in c:\Tomas\Public\FSharp.Formatting\src\Common\Razor.fs:line 137
   at FSharp.MetadataFormat.MetadataFormat.Generate(FSharpList`1 dllFiles, String outDir, IEnumerable`1 layoutRoots, FSharpOption`1 parameters, FSharpOption`1 namespaceTemplate, FSharpOption`1 moduleTemplate, FSharpOption`1 typeTemplate, FSharpOption`1 xmlFile, FSharpOption`1 sourceRepo, FSharpOption`1 sourceFolder, FSharpOption`1 publicOnly, FSharpOption`1 libDirs, FSharpOption`1 otherFlags, FSharpOption`1 markDownComments, FSharpOption`1 urlRangeHighlight, FSharpOption`1 assemblyReferences) in c:\Tomas\Public\FSharp.Formatting\src\FSharp.MetadataFormat\Main.fs:line 1128
   at <StartupCode$FSI_0006>.$FSI_0006.main@() in C:\Git\FSharp.Data\docs\tools\generate.fsx:line 137
Stopped due to error

Hmm, @matthid is the expert on RazorEngine-related things.
It looks as if the engine did not like something in some of the templates for generating API reference. Does F# Data use a customized version, or the default one?

Yeah scratch that I have a repro and I'm thinking about it if you want a "quick" fix you can either use static types or enumerate manually (with a foreach) instead of using AddRange
foreach (var t in Model.Types) { typesAndModules.Add(t); }

this works in my repro case at least. I'm trying to fix the more general case at well but it seems to be really really ugly so I will need some time to think about it.

That worked, problem fixed. Thanks :)
https://github.com/fsharp/FSharp.Data/commit/96f49bf6ee100b68bf9eec69f8990184fd893c16

Do we need to do the same fix in the default F# Formatting templates?

This is a custom template. The default one has Modules and Types separated, but I preferred having them all together ordered alphabetically, as the difference between a type with static methods and a modules with functions is not that meaningful

You are welcome.
Actually I use F# formatting as some kind of additional integration test in RazorEngine so that shouldn't happen. If you ever drastically change them it would be nice to mention me so I can update the templates in the RazorEngine documentation generation as well.
So its quite unlikely that a RazorEngine version ships that breaks F#.Formatting as I'm using it for several projects now :).

By the way RazorEngine 3.6.2 should support that now... you are now able to use your original template. (Of course you need to wait a new F# formatting release as it is bundled there).

The Error while building member-name for errors mean that some member names could not be build and therefore you could get some "empty" entries in your documentation, besides that they shouldn't hurt. However they are printed out because they show FCS limitations (or members we should filter out somewhere along the line).

Thanks @matthid, next time I update the template I'll let you now


Child Form MenuStrip Not Showing

I updated to the 3.1.0-beta7 (for .NET5 compatibility) and am having problems with the MenuStrip being updated when a child form is active. Both MainForm and ChildForm have a MenuStrip field. My program starts out with only the MainForm and MainForm's MenuStrip is showing, but it doesn't get switched to the ChildForm's after adding it. Previously, after adding the ChildForm, the MenuStrip would show for the ChildForm instead of the MainForm.
Example:
// MainForm menu showing
var childForm = new ChildForm();
childForm.Show(mainFormDockPanel, DockState.Document);
// Expect ChildForm menu showing

What is ".net5 beta7"? You also need to provide a minimal sample project to reproduce the issue.

.NET 4.8

.NET 5

Source Code:
DockPanelSuite-MenuStripBug.zip

Looked into this a bit more and it seems like the problem is that in 3.1.0-beta7, ChildForm.MdiParent == null after adding it to the dockPanel. Instead it should be MainForm which seems to result in the menu strips being merged.

Figured it out, the default value for DockPanel.DocumentStyle was changed to DocumentStyle.DockingWindow. Previously it was DocumentStyle.DockingMdi. Setting this properly fixes the problem.


Is there easy way to create cluster with reverse-proxy enabled using powershell or azcli without template?

az sf cluster create --resource-group $ResourceGroupName --location $Location
--cluster-name $ClusterName --cluster-size $ClusterSize --os WindowsServer2016DatacenterwithContainers
--vault-name $VaultName --vault-resource-group $ResourceGroupName
--certificate-subject-name $Subject --certificate-password $Password --certificate-output-folder .
--vm-sku $VmSku --vm-user-name $VmUserName --vm-password $VmPassword
--reverse-proxy-endpoint-port 19081 # like this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2e251c01-0830-5b77-46f9-7929c0a4d556
Version Independent ID: 85c404d3-319d-66a8-49eb-bbb923563ab6
Content
Content Source
Service: service-fabric

I have more questions.
The reverse proxy on the service fabric is disabled by default.
Isn't recommended to use a service address through that?
If so, I wonder what is the most recommended method for open-api service.

@wminos Thanks for your comments. I have forwarded your questions to the content author to review and provide an answer. Thanks for your patience.

#in-process

@wminos Hi, good questions.  Right now you need to enable reverse proxy in the template.  No, reverse proxy is not enabled by default but our sample templates do have reverse proxy enabled.  It is recommended for services within the cluster to communicate with each other using reverse proxy.  It is not recommended for a client outside the cluster to use reverse proxy to communicate with services inside the cluster, though, since all services in the cluster are then exposed.
You can use Azure API Management as an API gateway for your SF services (see https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-tutorial-deploy-api-management).  In APIM, you can create custom groups to give developers visibilities to your APIs.  I think that would give you some flexibility to create open-api services. See https://docs.microsoft.com/en-us/azure/api-management/api-management-key-concepts#a-namegroups-a-groups .
Hope that helps.

I originally wanted to automate with a simple cli, but it might have been greedy.
Answer Thank you very much!


Migrate tests to new testing framework

closes #68
this PR is about:

Moving tests form old framework to new framework. If some tests from old approach are already moved to new approach, they are just deleted.
Cleaning repository from all residues after old test framework.
In column from_description method - adding support for types, where part of type name is specified after percision/char_size.

nit: Please also change the commit messages into present tense.

Please squash Fix test_timestamps expected_schema and Add support for types, where part of type name is specified after percision/char_size. Also rename it to Fix get_columns_in_relation timezone type detection.
Also rename new testing framework to pytest (shorter).
Remove old test framework -> Remove jaffle shop tests

Thank you for your valuable contribution!


Enable Data Table Renderers to work on github.dev and in the web version of vscode IDE

see docs: https://code.visualstudio.com/api/extension-guides/web-extensions
& Microsoft VSCode Notebook Renderers that currently work in a browser:
https://github.com/microsoft/vscode-notebook-renderers
Current Pyolite notebook raw JSON data output due to lack of rich data table renderers in that vscode IDE context:

Looks like this works after adding browser entry point to package.json & using https://github.com/microsoft/vscode-test-web to test data table renderers extension locally:

ok. that fixes web extension loading ...

confirmed that those changes work in Code Spaces:

However, those sample notebook files are download in vscode web editor on github.dev and vscode.dev because the construction path of example notebooks is an http based Url, not a file in web IDE.

released in v1.10: https://github.com/RandomFractals/vscode-data-table/releases/tag/v1.10.0


Windows Support

I'm going to start this as a placeholder. In my brief searching, I don't see a suitable package to replace pkg/term for Windows terminal support.
See pkg/term/#8
go get -u neugram.io/ng
# neugram.io/ng/eval/shell
C:\go\src\neugram.io\ng\eval\shell\job.go:48:10: undefined: syscall.Termios

Thanks. We should have a basic stdio mode for general portability.
There is another significant Windows issue, which is Go plugin support. It doesn't work on Windows yet, which means all Neugram can do is import a few builtin std lib packages.

Is that in reference to go/#19282?

wrt the plugin support and importing Go packages.
perhaps we could have a RPC/IPC plugin mode (like hashicorp's plugin or Nate Finch's pie) ?
it would be slower, but more robust (the usual dilemma) and would work on all platforms.
(also, one could reload an imported package. not sure how that would mesh with Go/ng, though)

When I'm asked if someone should use -buildmode=plugin or an RPC/IPC-based process solution, I almost always recommend the latter. It is far more robust to break your code up into processes if you can.
However I think a general interpreter like Neugram is one place where -buildmode=plugin does make sense. Consider this example:
package ingo

var X *int

func Inc() { *X++ }

and the neugram session:
var x int
import "ingo"
ingo.X = &x
ingo.Inc()
print(x)

How does neugram make this work with RPC/IPC? One possibility is moving all value declarations into the plugin, but this requires constant recompilation on variable declaration, and doesn't solve serializing the state for reloading. The whole machine comes out far more complex than using shared objects, and with lots of quirky failure modes. (Consider the above example only with pointers in structures, or slices.)
I think it would be far less work to get -buildmode=plugin working on windows. There has already been some good work on -buildmode=cshared, and .dll files are well defined. It would probably be a 6-week project for me. I don't know when I can get to it, my current leave is too short and windows support doesn't fit into my day job, but it is entirely possible.

there is also the issue of:
package ingo
func Get() chan int { ... }

which would probably break channels' basic assumptions.
ok. let's find some time to get "brainman" to work on plugin :)


How can I resize components on the grid?

Not sure if this is the right place to ask, as I assume it's not really a bug, just me misunderstanding how the module works. Anyhow, I tried to have a custom component resizable on the grid. However, I could not get it working.
When I put the component inside a div, I can resize that div, but the component itself is not resized with it.
When I put the component inside the grid tags directly, I can't resize or move it at all and the borders of the grid are not matching the borders of the component either.
I have uploaded an example on code sandbox:
https://codesandbox.io/s/7zl7mm90m0
How can I implement a custom component properly?
Best regards,
W.

Ah, okay. All I had to do was add overflow property to the style. Closing this :-)


[firebase_auth] Migrate linkWithCredential function from FirebaseAuth to FirebaseUser

Firebase authentication plugin should have linkWithCredential function inside the user object, currently, it is on the FirebaseAuth class which makes no sense. As the linking should be done to an existing user, adding the function to the user object would make more sense.
Its similar approach to the native firebase auth SDKs on Android and IOS. Documentation to the linkWithCredential on Android is here.

There's an incomplete thread at https://github.com/flutter/flutter/issues/32317 with discussion (+cc @ebologger, @awazgyawali).
The issue description says "[linkWithCredential] is on the FirebaseAuth class which makes no sense". I tend to disagree: since linkWithCredential references no dynamic fields of FirebaseUser, it makes sense as a static method.
This change has broken the current architecture of our app since there's no FirebaseUser instance in the code path that used to invoke linkWithCredential.

Additionally I'd like to re-iterate that the following workflow now looks like it's making what you want, but doesn't:
user1 = login();
logout();
user2 = login();
user1.link(account);

because in reality this will do user2.link(account) since linkToCredential always operates on the currentUser.


Add support for unregistering queries

[x] allow clients to unregister queries
[x] clear interests of disconnected clients.

Thanks to https://github.com/TimelyDataflow/differential-dataflow/pull/149 this is now finally a thing. 309d08e1a53f82d3d95213a017b3c9222e1e1e8d adds an Uninterest command. Dataflows are cleaned up once the set of interested clients is empty. Client interests are not yet cleaned up on disconnect.


Hotfix -Set empty supplier sample name flag

While we hope to be rid of this shortly, and it doesn't affect newly
generated manifests, older manifests still have the flag set
incorrectly on upload. This prevents samples from appearing
in reports, and some lab processes.

So not a problem with new manifests, as the samples are generated on upload and the flag defaults to false. But pre-existing manifests seem to set the flag to true on manifest generation, so it never gets unset.
Obviously this fix is only temporary, and can be removed once we've migrated historical data.


Update Navigator component doc

Related to #8203 to update the Navigator component reference doc.
Test plan (required)
Started up the website and checked:
http://localhost:8079/react-native/docs/navigator.html

Note
The code is not Flow-ified so depended on jsdoc formatting to get the method parameter types. There's a current issue with handling optional types via react-docgen which parses components. There's an open PR to look into this: https://github.com/reactjs/react-docgen/pull/89. When that's resolved the replaceAtIndex method parameter type that's documented for cb needs to be updated to make it optional.

By analyzing the blame information on this pull request, we identified @janicduplessis and @hedgerwang to be potential reviewers.

This looks great. A lot more complete and detailed.
@hramos What do you think? Good to go?

Two minor typo nits, the new API doc looks great!

After some discussion...
Examples in ES6 format (class ... extends ....), etc.
No AppRegistry -- everything is a class that can be used in existing apps.

@facebook-github-bot shipit

I have to kick this thing .... our internal diff got whacked.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.

And third time is a charm...
@facebook-github-bot shipit

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Rendering issues with multiple flags on Safari

On Safari 12.0.3 and macOS 10.14.3, viewing https://pixelastic.github.io/css-flags/
Burundi - red stars misaligned with green outlines
Comoros, Maldives, Pakistan, Singapore, Tunisia, Turkey, Uzbekistan, Western Sahara - ghost outline next to the crescent
Greece - blue line at the bottom of the white cross (should not be there)
Guyana - red outline that bleeds over the black
South Korea - ghost outlines inside the taegeuk
South Africa - discontinuity when white strips merge
Vanuatu - discontinuity when black strips merge

Thanks for the report. I know there are issues on Safari, it's a proof of concept only working on Chrome.
I'm going to close this issue as I don't work on this project anymore and this will cleanup my list TODO list :)
I'm open to anyone submitting a PR though.


Use a elevated command shell as integrated terminal

The VScode integrated terminal documentation say that is possible use a elevated shell as integrated terminal (https://code.visualstudio.com/docs/editor/integrated-terminal#_configuration). However, there is no exemples describing how to do that.

Check the help for runas.exe and run it in the terminal: runas.exe /help


Should keywords (like int and try) be handled differently than other words?

For example the pattern
int :[var]

Check how Comby behaves

Cómo intentionally didn't treat keywords different, so for now don't implement

Closing since don't plan on fixing


Kinematic body does not have physics body option

Godot version
3.4.4
System information
Windows 10
Issue description
My player just passes through the objects
Steps to reproduce

Minimal reproduction project
No response

Please provide a simple example project.

Closing due to lack of response, if you provide the requested information this can be reopened


how can i ignore compile error

when the code running, it will never run this code in catch, but when compiling, it prompt error，how can i fix it?

It looks like you just deleted/ignored our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


user highlighting - inconsistent behaviour

is it intentionally, that stream members only get highlightet wenn you highlight a message in the stream (but not if you select the stream/topic in the left column) ?
i always find this confusing
see discussion at https://chat.zulip.org/#narrow/stream/101-design/topic/user.20highlighting
i don't see the point why highlighting stream or topic does not also highlight stream members, this should be consistent or at least transparent, why it's the way it is.
thank you

This will be resolved via #21285.


Exported Android apk insta-crashing with APK expansion and PCK encryption

Godot version
v4.0.3.stable.official [5222a99f5]
System information
Windows 11, Android Samsung A14, Android SDK API 33
Issue description
When using custom build export templates with Android, PCK encryption and APK expansion, the Android App is insta-crashing with:
 FATAL EXCEPTION: main
Process: org.philhudson.test_and_enc, PID: 23907
 java.lang.RuntimeException: Unable to start activity ComponentInfo{org.philhudson.test_and_enc/com.godot.game.GodotApp}: java.lang.IllegalArgumentException: org.philhudson.test_and_enc: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
                                                                                at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4169)
                                                                                at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:4325)
                                                                                at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
                                                                                at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
                                                                                at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
                                                                                at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2574)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                at android.os.Looper.loopOnce(Looper.java:226)
                                                                                at android.os.Looper.loop(Looper.java:313)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:8757)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
                                                                                Caused by: java.lang.IllegalArgumentException: org.philhudson.test_and_enc: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
                                                                                Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
                                                                                at android.app.PendingIntent.checkFlags(PendingIntent.java:408)
                                                                                at android.app.PendingIntent.getActivityAsUser(PendingIntent.java:491)
                                                                                at android.app.PendingIntent.getActivity(PendingIntent.java:477)
                                                                                at android.app.PendingIntent.getActivity(PendingIntent.java:441)
                                                                                at org.godotengine.godot.Godot.onCreate(Godot.java:688)
                                                                                at androidx.fragment.app.Fragment.performCreate(Fragment.java:2949)
                                                                                at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:475)
                                                                                at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:278)
                                                                                at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2189)
                                                                                at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2100)
                                                                                at androidx.fragment.app.FragmentManager.execSingleAction(FragmentManager.java:1971)
                                                                                at androidx.fragment.app.BackStackRecord.commitNowAllowingStateLoss(BackStackRecord.java:311)
                                                                                at org.godotengine.godot.FullScreenGodotApp.onCreate(FullScreenGodotApp.java:69)
                                                                                at com.godot.game.GodotApp.onCreate(GodotApp.java:45)
                                                                                at android.app.Activity.performCreate(Activity.java:8591)
                                                                                at android.app.Activity.performCreate(Activity.java:8570)
                                                                                at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1384)
                                                                                at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:4150)
                                                                                ... 12 more

There have been suggestions to turn on Gradle build and add the following dependency, as per:
https://stackoverflow.com/questions/67045607/how-to-resolve-missing-pendingintent-mutability-flag-lint-warning-in-android-a
and
https://github.com/godotengine/godot/issues/38758
adding:  implementation "androidx.work:work-runtime-ktx:2.7.1"
does not resolve the issue.
Also note that for the reproduction project, I am not using gradle build to show the most basic form of the issue.
Please let me know if you have additional comments or requests for additional reproduction steps.
Steps to reproduce

Open up example project
Attempt to run on Android device or simulator with one click deploy or exported APK
Observe logs in adb, see app crash instantly on device

Minimal reproduction project
Adding shared url as the project includes export templates which are big, total download size around 150mb which exceeds the 25mb limit here:
https://drive.google.com/file/d/10_ZnggmkBl39KIhkSyiEQaNiRrwN3Lkc/view?usp=sharing

Is it working with non encrypted PCK? The error seems to be from the Java part, which is not related to PCK encryption.

Is it working with non encrypted PCK? The error seems to be from the Java part, which is not related to PCK encryption.

Correct, this is related to the Java part, I only experienced it when using APK expansion and PCK encryption.
I generally think that there are other issues with PCK encryption however, this resolved the insta-crash mentioned above, but instead has a different error 'Download failed because the resources could not be found'. Which I believe is still related to PCK encryption, but this PR above only addresses the first stage of the crash.
We can see the new error string is: case IDownloaderClient.STATE_FAILED_FETCHING_URL: which I'd need to debug but I'd assume it relates to asset resolution/loading?

Download failed because the resources could not be found'. Which I believe is still related to PCK encryption

No it's unlikely related, it might be related to OBB downloading. PCK encryption is handled by platform independent C++ code and only works with the local filesystem.

I think you're right, it does look related to OBB downloading.


If TCP socket in CLOSE_WAIT state, gen_tcp:send/2 gets blocked indefinitely

This causes a process queue to grow indefinitely as well. In order to avoid it, send_timeout option for gen_tcp:connect/4 should be used. Also, it is recommended to use send_timeout_close, in order to have a socket closed on timeout automatically.

I finally tagged a new version (v0.9) that includes your PR.
Very sorry for the way too long delay!


Improved Deepspeed Imports

What does this PR do?
As mentioned in #12786 PL needed some changes to imports. So as per the dicussion this is my First PR for Deepspeed Imports and later on I will create seprate PRs for Fairscale and all Loggers, etc.

Fixes #<issue_number>
#12786
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

Cool, LGTM, thanks @carmocca


Update LICENSE with filled copyright boilerplate

I noticed the LICENSE file did not follow the instructions in the APPENDIX: How to apply the Apache License to your work..
I removed the APPENDIX and added use the copyright information found in the License section of the  README.md

Please see #189 Unapplied License issue for more details about this pull-request.

thank you, it reflect what's on the readme

thank you, it reflect what's on the readme


fix: inputs change event

Why
Change event was being filtered because it was comparing a full url to an origin in js.
How
Added a separate config option for origin which is stable to match against.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chunk compression type is hardcoded to passthrough for metric columns

There doesn't seem to be a way to use LZ4 compression for metric column.
https://github.com/apache/pinot/blob/f2f8e38f9424bcacf3946197c9afcd50ef1d58fa/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java#L100

This makes sense the way it is for a couple of reasons:

chunks for metric columns are tiny: 4-8KB depending on the data type. This means there would be many chunks to decompress in a column scan.
general purpose compression algorithms work better on text than arbitrary numeric data, so the compression ratio for the average user’s column likely wouldn’t be very good.

These two factors combine to make a less than compelling case for general purpose compression of metric columns.
There are numerous encoding techniques which could be explored for metric columns in the future, which tend to produce better space reductions and are faster to decode.
If you have a metric column which you expect to be compressible because it has lots of duplicates, it would be worth experimenting with using a dictionary column instead.

IMO this is a bug. For metrics, we use PASS_THROUGH by default, but should allow overriding it if it is explicitly configured in the FieldConfig

@Jackie-Jiang let's make it configurable when there are encoding modes which make sense for numeric data. LZ4 and Snappy aren't good options for numeric data, and are dominated by dictionary encoding.

Here are the sizes of 8KB (1024 doubles) of different distributions/patterns with Snappy and LZ4. There are encodings which can be introduced to reduce the size of metric columns (e.g. xor or delta encoding) but making it possible to compress metric column with general purpose compression algorithms isn't in the user's interest.

Compression
Distribution
Compressed Size (KB)

Uncompressed
integer increments
8.00

LZ4
integer increments
4.09

Snappy
integer increments
4.02

Uncompressed
noisy increments
8.00

LZ4
noisy increments
8.03

Snappy
noisy increments
8.00

Uncompressed
sinusoidal
8.00

LZ4
sinusoidal
8.03

Snappy
sinusoidal
8.00

Uncompressed
normal(0,1)
8.00

LZ4
normal(0,1)
8.03

Snappy
normal(0,1)
8.00

Uncompressed
exp(0.999)
8.00

LZ4
exp(0.999)
7.23

Snappy
exp(0.999)
7.16

I think in many cases the metric values don't change much - for example cpu usage gauge will have only slight variations for a given metric series over a small interval (say, 10 minutes). We have seen good compression ratios - in our data (storing Kubernetes metrics), we are getting 1 bytes per row instead of 8 allocated for the 'double' column. As a workaround we marked the value column as dimension to get the LZ4 compression to get the savings.

The problem is you won't get any savings from LZ4 - those CPU readings can be almost identical but with a little bit of noise the data is difficult for a text oriented algorithm like LZ4 to compress. The XOR of any two adjacent values will typically have very few set bits so can result in high compression ratios, perhaps even 8x. Implementing codecs such as xor or delta encoding is a feature that has been discussed before, would not be very difficult, and it would solve your problem in a way making metric columns compressible would not.


state_data: Accept null for realm_*_limit_seconds fields

Cc @sahil839 (#29264). The failure to annotate these as .nullable() caused crashes loading Zulip Cloud and forced us to roll back a deployment.
Be careful to check the type in the backend code of every field you add to a Zod schema, including whether it might be null (.nullable()) and/or undefined (.optional()). Do not just make up a type that feels right!

Apologies. Will be careful now.


Add minimal travis and test infrastructure

This creates a "make test" Makefile targt (that for now always passes) and a .travis.yml file so that we can bootstrap our travis integration.

This change is

Not sure if travis is only triggered, when there is already a .travis.yml file in the repo? On my private repo travis was triggered and passed.

Ok. it needed a few settings under travis-ci.org...

This was superseded by #194


java.lang.SecurityException: Permission Denial

Describe the bug
Example fails to launch.
I've added <uses-permission android:name="android.permission.INTERACT_ACROSS_USERS_FULL" /> as the error message suggests.
To Reproduce
Launching lib/main.dart on SM N950F in debug mode...
✓  Built build/app/outputs/flutter-apk/app-debug.apk.
Connecting to VM Service at ws://<IP_ADDRESS>:53631/ptKhfUvRWL0=/ws
I/flchart.exampl(27981): Compiler allocated 4MB to compile void android.view.ViewRootImpl.performTraversals()
D/vndksupport(27981): Loading<EMAIL_ADDRESS>from current namespace instead of sphal namespace.
E/flutter (27981): [ERROR:flutter/fml/platform/android/jni_util.cc(182)] java.lang.SecurityException: Permission Denial: broadcast from android asks to run as user -1 but is calling from user 0; this requires android.permission.INTERACT_ACROSS_USERS_FULL or android.permission.INTERACT_ACROSS_USERS
E/flutter (27981): 	at android.os.Parcel.createException(Parcel.java:1966)
E/flutter (27981): 	at android.os.Parcel.readException(Parcel.java:1934)
E/flutter (27981): 	at android.os.Parcel.readException(Parcel.java:1884)
E/flutter (27981): 	at android.app.IActivityManager$Stub$Proxy.reportActivityFullyDrawn(IActivityManager.java:7312)
E/flutter (27981): 	at android.app.Activity.reportFullyDrawn(Activity.java:2092)
E/flutter (27981): 	at io.flutter.embedding.android.FlutterActivity.onFlutterUiDisplayed(FlutterActivity.java:1061)
E/flutter (27981): 	at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate$1.onFlutterUiDisplayed(FlutterActivityAndFragmentDelegate.java:88)
E/flutter (27981): 	at io.flutter.embedding.android.FlutterView$2.onFlutterUiDisplayed(FlutterView.java:133)
E/flutter (27981): 	at io.flutter.embedding.engine.FlutterJNI.onFirstFrame(FlutterJNI.java:461)
E/flutter (27981): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/flutter (27981): 	at android.os.MessageQueue.next(MessageQueue.java:326)
E/flutter (27981): 	at android.os.Looper.loop(Looper.java:181)
E/flutter (27981): 	at android.app.ActivityThread.main(ActivityThread.java:7073)
E/flutter (27981): 	at java.lang.reflect.Method.invoke(Native Method)
E/flutter (27981): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
E/flutter (27981): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
E/flutter (27981): Caused by: android.os.RemoteException: Remote stack trace:
E/flutter (27981): 	at com.android.server.am.UserController.handleIncomingUser(UserController.java:1818)
E/flutter (27981): 	at com.android.server.am.ActivityManagerService.broadcastIntentLocked(ActivityManagerService.java:25781)
E/flutter (27981): 	at com.android.server.am.ActivityManagerService.broadcastIntentLocked(ActivityManagerService.java:25712)
E/flutter (27981): 	at com.android.server.am.ActivityManagerService.broadcastIntent(ActivityManagerService.java:26582)
E/flutter (27981): 	at android.app.ContextImpl.sendBroadcastAsUser(ContextImpl.java:1264)
E/flutter (27981):
E/flutter (27981):
F/flutter (27981): [FATAL:flutter/shell/platform/android/platform_view_android_jni_impl.cc(1201)] Check failed: fml::jni::CheckException(env).
F/libc    (27981): Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 27981 (flchart.example), pid 27981 (flchart.example)
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
Build fingerprint: 'samsung/greatltexx/greatlte:9/PPR1.180610.011/N950FXXSEDTL1:user/release-keys'
Revision: '9'
ABI: 'arm64'
pid: 27981, tid: 27981, name: flchart.example  >>> dev.flchart.example <<<
signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
Abort message: '[FATAL:flutter/shell/platform/android/platform_view_android_jni_impl.cc(1201)] Check failed: fml::jni::CheckException(env).
'
    x0<PHONE_NUMBER>000000  x1<PHONE_NUMBER>006d4d  x2<PHONE_NUMBER>000006  x3<PHONE_NUMBER>000008
    x4<PHONE_NUMBER>000000  x5<PHONE_NUMBER>000000  x6<PHONE_NUMBER>000000  x7<PHONE_NUMBER>000000
    x8<PHONE_NUMBER>000083  x9  00000076e21f8838  x10 fffffff87ffffbdf  x11<PHONE_NUMBER>000001
    x12<PHONE_NUMBER>d50c80  x13<PHONE_NUMBER>000000  x14 ffffffffffffffff  x15 00004110d9d7d5a8
    x16 00000076e222f2a0  x17 00000076e216e920  x18 0000007fe54f2a9a  x19<PHONE_NUMBER>006d4d
    x20<PHONE_NUMBER>006d4d  x21<PHONE_NUMBER>000083  x22<PHONE_NUMBER>000034  x23 000000765c5bc430
    x24 000000765c5bc418  x25<PHONE_NUMBER>000000  x26 00000076e2e0f5f8  x27<PHONE_NUMBER>000034
    x28<PHONE_NUMBER>000001  x29 0000007fe54f3350
    sp  0000007fe54f3310  lr  00000076e2161d68  pc  00000076e2161d94
backtrace:
    #00 pc<PHONE_NUMBER>021d94  /system/lib64/libc.so (abort+124)
    #01 pc<PHONE_NUMBER>45a1dc  /data/app/dev.flchart.example-9AhcNIXDu5aIJLzoWG6OEA==/lib/arm64/libflutter.so (offset 0x1458000)
Lost connection to device.
Exited (sigterm)

Versions
[✓] Flutter (Channel stable, 2.5.0, on macOS 11.5.2 20G95 darwin-x64, locale en-GB)
    • Flutter version 2.5.0 at /Users/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4cc385b4b8 (3 months ago), 2021-09-07 23:01:49 -0700
    • Engine revision f0826da7ef
    • Dart version 2.14.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/dev/Library/Android/sdk
    • Platform android-31, build-tools 30.0.2
    • ANDROID_SDK_ROOT = /Users/dev/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.0, Build version 13A233
    • CocoaPods version 1.11.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.0)
    • VS Code at /Users/dev/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.27.0

[✓] Connected device (2 available)
    • SM N950F (mobile) • ce10171ac02ea43b037e • android-arm64  • Android 9 (API 28)
    • Chrome (web)      • chrome               • web-javascript • Google Chrome 96.0.4664.55

which version of the FlChart are you using?
^0.40.2

Did flutter run after uninstalling the app and it ran fine

Still facing this. Did flutter clean, unsinstalled the existing app.

Dude, I'm pretty sure it is not related to this library.
Try to remove the fl_chart dependency and let me know is it happening or not.

Dude, I'm pretty sure it is not related to this library. Try to remove the fl_chart dependency and let me know is it happening or not.

You're correct, I commented all the samples and removed the package and this error persists.


Implementing gridindexing for MOM5 B-grids

Following code suggestion by @hrsdawson in #922, this PR will implement grid indexing for MOM5 B-grids.

Apart from the adapted assertion message, it all looks okay to my eyes.


Implement proper fmod meta-function

Current meta implementation of fmod is only a dummy implementation, accurate only if x and y are not too far apart.
It should be refined into a proper implementation working for the full range of inputs.
For example the following test fails in single precision:
ml_fmod(0x1p+100, 0x1.4e4p-10), result is -0x1.17p+75 vs expected [0x1.3cp-12;0x1.3cp-12]

Improvements integrated in master branch.
The new scheme use an iteration to provide an accurate fmod.


docs: include table of packages in README

Description
I would like the README of this mono-repository to have a table of packages similar to the one that the i18n already has.
I believe some of the advantages of this table would be:

Lets developers read the packages the mono-repository contains at first glance and what they do
Lets developers easily navigate to a package without searching through the directories since they are linked through the packages table

Further context

I'm willing to contribute this change

I'm not sure if it makes sense to have one in the root of the SDK repo, but perhaps in https://github.com/dart-lang/sdk/tree/main/pkg would make sense? It would likely be best separated into two tables, a first one for packages in the directory that are published, and a second one for packages in the directory that aren't.
\cc @devoncarew for thoughts.

Any updates on this issue?
Having a table for the packages sounds good to me to. Separating them into two tables sounds great. Having a name, description, contribution point/docs for each package are some of the columns I can think of.

Any updates regarding this issue? (cc: @parlough , @devoncarew)

Any updates here? Is this ready to be worked on? @parlough

@parlough can you assign this to me based on our offline discussion yesterday?


fix(testing resources): Test resources issue

Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

/test all

/test integration-service-e2e

/retest

/test all

/test e2e-tests

/test integration-service-e2e

/test integration-service-e2e


VSCode Extension: Add "Start if not running" command

I often make a dependent task for Azurite for my testing and launch tasks like so:
		{
			"label": "azurite",
			"command": "${command:azurite.start}",
			"problemMatcher": [],
			"isBackground": true
		},

However this always throws a bunch of toast errors if Azurite is already running. If I had a azurite.startifnotrunning command that would suppress error notifications about it already being started and only show errors if it failed would be very helpful. Thanks!

Hi @JustinGrote, thanks for bringing up this. We will evaluate this in our furture releases. Also welcome anyone wants to contribute this!

Thanks for posting the sample tasks.json entry, @JustinGrote! I would also like this feature. In the meantime, I opted for the following to run the task only once, when VSCode opens the source folder:
    {
      "type": "process",
      "label": "azurite blob storage",
      "command": "${command:azurite.start_blob}",
      "problemMatcher": [],
      "isBackground": true,
      "runOptions": {
        "runOn": "folderOpen"
      }
    }

Documentation about runOptions: Tasks: Run behavior


Add ReducePartitionBy

Commit Message
Add ReducePartitionBy (#458)
This patch adds a parallelizable transducer ReducePartitionBy(f, rf, [init])
that can be used for fusing intra- and inter-partition reductions. It also
is used for a performance specialization of array |> PartitionBy(f) that
does not require allocations of vectors any more.
For example, ReducePartitionBy can be used for implementing group reduce
operations that runs in parallel and uses constant space (Note: hash-based
group reduce requires the space at least as large as/proportional to the
number of groups).