Activity toggle isn't keyboard accessible.

Expected Behavior
When I open a document I should be able to navigate between Design, Debug and Test via keyboard.
Actual Behavior
Currently, this is not supported.
Reproduction Steps
No response
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2022.5.0-beta.2
What operating system are you using?
macOS
Operating System Version
macOS Monterey
Installation method
download from insomnia.rest
Last Known Working Insomnia version
No response

Hi @pavkout thanks for reporting this!
Marking this as an improvement/feature request. We are missing that functionality and seems that it would be really useful. We'll update you here if there's anything released on this.
Feel free report other issues/improvements you come across 👍


Typescript / Build / Error

I am use this plugins for project nextjs with typescript
after running to build projet get this error 👍
Could not find a declaration file for module 'react-slide-toggle'. '/Volumes/Macintosh-SSD250/Projets/Next/nextjs-store/node_modules/react-slide-toggle/dist/ReactSlideToggle.umd.js' implicitly has an 'any' type.
  Try `npm install @types/react-slide-toggle` if it exists or add a new declaration (.d.ts) file containing `declare module 'react-slide-toggle';`

> 1 | import SlideToggle from "react-slide-toggle";

so i guess must to add types for typescript.

In your project if you create a new folder in src called typings ( really anywhere that's recognized as source ) and a file called react-slide-toggle.d.ts, you can then make the following declaration:
declare module 'react-slide-toggle';
After adding this code the error should disappear and you should be able to import it like the documentation states.  GL


Constraints_md

constraints

[x] Constraints Definitionin this project
[x] External constraints
[x] Project Duration
[x] Availability
[x]  Technology
[x] Internal & external constraints
[x] Image link for better understand

perfect job by team leader! Galal 👍!


startValue is ignored when saving trimmed video in mp4 format

Here is the code I'm calling.
final savedPath = await trimmer.saveTrimmedVideo(
      startValue: _startValue,
      endValue: _endValue,
      outputFormat: FileFormat.mp4,
      storageDir: StorageDir.temporaryDirectory,
      videoFileName: 'trimmed_video',
);

The field startValue has no effect on the output, while endValue works as expected.
Changing format to gif instead of mp4 produces correct output but I need the output as mp4.

Closing this as it is a duplicate of #85 , please continue the conversation there.


textblob download_corpora error

when I run
python -m textblob.download_corpora
there were some errors
File "D:\SoftWare\Anaconda2X86_27\lib\xml\etree\ElementTree.py", l_raiseerror
raise err
xml.etree.ElementTree.ParseError: mismatched tag: line 15, column 3
What can I do? Thanks!

I am also facing the same issue. Any guidance will be of great help.
After doing, sudo pip install -U textblob
I get:
Downloading/unpacking textblob
Downloading textblob-0.11.0-py2.py3-none-any.whl (633kB): 633kB downloaded
Requirement already up-to-date: nltk>=3.1 in /usr/local/lib/python2.7/dist-packages (from textblob)
Installing collected packages: textblob
Successfully installed textblob
Cleaning up...
But on executing  python -m textblob.download_corpora
I get the following error:
No module named textblob

Probably a temporary error downloading the files, similar to this issue on Stack Overflow.
Closing for lack of activity.


Fix bug in type_from_column_spec

Fixes bug in type_from_column_spec, which is used in _standardize_dataframe. The bug was in the variable names while unpacking the col_specs. Here column_spec_name should be the key and the data type should be the value.

Interesting! Thanks for the contribution.
I agree that the documentation is not in line with behavior and therefore this is a bug.
What confuses me is the difference between the default implementation and the column_spec implementation.
First:
https://github.com/asreview/asreview/blob/942f755368e71cd7abe77232a3cc292e98a66465/asreview/io/utils.py#L117-L120
Second:
https://github.com/asreview/asreview/blob/942f755368e71cd7abe77232a3cc292e98a66465/asreview/io/utils.py#L121-L124
The second accepts column specs in this format:
https://github.com/asreview/asreview/blob/942f755368e71cd7abe77232a3cc292e98a66465/asreview/config.py#L48-L65
A small refactor can align the two (where we replace the column_spec implementation with the default format). What do you think?

Hi @J535D165, thank you for your quick response. I found this bug because I was trying to use the type_from_column_spec function.
From what I understand, FIRST and SECOND can be achieved with a single function type_from_column, and type_from_column_spec is not at all necessary. If the users want to define custom column_specs (or definitions), they can use the same format as COLUMN_DEFINITIONS and use type_from_column

Indeed! Sorry for the confusion. Interested in deprecating that function in our code base?

Should I refactor the code and create a pull request? How w can go about it?

Yes, you can refactor the code in this PR (no need to start a new one). I don't think there is a need to add a deprecation warning as this is not a public part of the API and you are probably the first one to use it ;) Internally, it is never used haha

Yeah, I was thinking the same. I will refactor the code. Do you think any additional tests are needed or the current tests will suffice?

Let me rerun. Looks like a timeout error. Nice refactor, everything looks good to me!

Thank you..Passed all tests :) .. Will this change be available right away if I upgrade ASReview using pip?

It was a pleasure to merge your first contribution to asreview core. Looking forward to colab in the future!

The new version will not be available immediately, but I will create a new release soon.

Thank you @J535D165 . I was my first ever contribution to a big open-source project. I am working on few things and plan to contribute to ASReview frequently in future as I see it as a great opportunity for me to learn. Thank you for your guidance.


[url_launcher] Update deps and docs in url_launcher_web

Description
Updated dependencies and docs in the package so it can be usable from pub.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

I'll land this when it checks go green


Ability to collapse and expand all files in search results

It may help to find what I am looking for when got results in many files.
Thank you!

Try focusing on one of the file headers in the results then pressing Ctrl+LeftArrow (probably different modifier on macOS).

Thyere are two commands (unbound to any keybinding) you can use from the Command Palette or make your own keybinding:
Search: Expand All search.action.expandSearchResults
Search: Collapse All: search.action.collapseSearchResults

Yes, and the expand/collapse actions are in the search view toolbar. Thanks @gjsjohnmurray and @ArturoDent

Found it,
Thanks


merge_fixtures is having some problem parsing parameters

python:2.7.5
version:0.1.3
errror:
usage: manage.py merge_fixtures [-h] [--version] [-v {0,1,2,3}]
                                [--settings SETTINGS]
                                [--pythonpath PYTHONPATH] [--traceback]
                                [--no-color]
manage.py merge_fixtures: error: unrecognized arguments:

dupe of reopened issue


Inclusion of More Models

Based on the work done so far, I feel that our analysis would benefit from the inclusion of different ML models. I believe only utilising Ridge regression might limit our scope too much. Perhaps we can include other models (ie Random Forest Regressor) in order to compare the effectiveness of different approaches.

I have opened a pull request to incorporate random forest modelling. Since it takes a while to optimize and fit the random forest model, I have split the fit_transform_evaluate_model.py script into two.
The first script will process train and test data and pickle the fitted models:
fit_models.py (outputs processed test data and pickled models)
run command:
python python src/fit_models.py --source_data=data/processed --output_dir=results
dependencies:
data/processed/train_df.csv,
data/processed/test_df.csv
outputs:
data/processed/x_test_sparse.npz
data/processed/y_test.csv
results/tables/grid_search_ridge.csv
results/tables/grid_search_ridge.csv
results/models/rf_model.pickle
results/models/ridge_model.pickle
The second script takes the pickled models and processed test data to generate evaluation/comparison metrics:
compare_models.py (outputs processed test data and pickled models)
run command:
python src/compare_models.py --source_data=data/processed --output_dir=results
dependencies:
data/processed/x_test_sparse.npz
data/processed/y_test.csv
results/models/rf_model.pickle
results/models/ridge_model.pickle
outputs:
results/tables/test_scores.csv
results/tables/negative_coefficients_ridge.csv
results/tables/positive_coefficients_ridge.csv
results/tables/coefficient_comparison.csv
results/figures/predicted_vs_actual_chart.png

We did include more models now. We can close this issue


Css generated for Firefox ReadOnly to -moz-readonly does not work after upgrading angular 8 to 9

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Yes, after upgrading from Angular 8 to 9, dedicated css for firefox about "ReadOnly" when associate with other rules is not well generated during ng serve.
Description
This issue appear only on Firefox.
In Angular 8, a piece of style (from SCSS) code is automatically generated to ensure the compatibility with firefox about :read-only. Code is duplicated with :-moz-read-only . (with firefox prefixe equivalent)
In Angular 9, this piece of style code is duplicated alone, in consequence, all the css block code is not duplicated, then, not interpreted.
(I supposed first that was due to browserslist package, but package version is equal)
To illustrate, this code :
.element1:focus,
.element1:read-only {
  background-color: red;
}

Is perfectly generated in angular cli 8:
.element1[_ngcontent-rga-c0]:-moz-read-only,
.element1[_ngcontent-rga-c0]:focus {
 background-color:red
}
.element1[_ngcontent-rga-c0]:focus,
.element1[_ngcontent-rga-c0]:read-only {
 background-color:red
}

But wrongly generated in angular cli 9
.element1[_ngcontent-wxy-c0]:-moz-read-only {
 background-color:red
}
.element1[_ngcontent-wxy-c0]:focus,
.element1[_ngcontent-wxy-c0]:read-only {
 background-color:red
}

In consequence, the other css style associate to the same css rule, :focus, is never interpreted on firefox due to :read-only which is unknown for this browser.
🔬 Minimal Reproduction
Here is a repository with angular 9, where the bug appear :
https://github.com/albanlorillard/angular9-readonly-bug
Here is a repository with angular 8, where the bug NOT appear :
https://github.com/albanlorillard/angular8-readonly-bug
In both case,
use ng serve --prod
and run with Firefox
inspect in the style editor.
🔥 Exception or Error
No exception.
🌍 Your Environment

Angular CLI: 9.1.0
Node: 12.14.1
OS: win32 x64

Angular: 9.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.0
@angular-devkit/build-angular     0.901.0
@angular-devkit/build-optimizer   0.901.0
@angular-devkit/build-webpack     0.901.0
@angular-devkit/core              9.1.0
@angular-devkit/schematics        9.1.0
@ngtools/webpack                  9.1.0
@schematics/angular               9.1.0
@schematics/update                0.901.0
rxjs                              6.5.4
typescript                        3.8.3
webpack                           4.42.0

Anything else relevant?
Specific on Firefox browser.
I test on Firefox developer 75.0b9 (64 bits)
And Firefox 73.0 (64-bit)

Hi @albanlorillard,
I'm sorry, but this issue is not caused by Angular CLI. Please contact the author(s) of the autoprefixer project or file an issue on their issue tracker.
You can try to reproduce the issue using: https://autoprefixer.github.io, as a workaround you should be able to write the expected prefixed output directly.

Hi @alan-agius4 ,
Thanks for your answer, I reported to them (https://github.com/postcss/autoprefixer/issues/1301)


Change video_demo slightly so it works on web.

Description
Modify video_demo slightly so it compiles and runs on web (with flutter run -d chrome, for example).
This changes:

Short-circuit connectivity check, until that plugin becomes available for web.
Prevent platform checks if kIsWeb is true.

Related Issues

https://github.com/flutter/flutter/issues/46669

Tests
Existing tests seem to pass.
$ flutter test
Building flutter tool...
Running "flutter pub get" in flutter_gallery...                     0.5s
00:41 +127 ~17: /usr/local/google/home/dit/github/flutter/examples/flutter_gallery/test/smoke_test.dart: Flutter Gallery app smoke test
> VideoDemo initController "butterfly"
> VideoDemo initController "bee"
> VideoDemo dispose
< VideoDemo dispose
01:09 +128 ~17: /usr/local/google/home/dit/github/flutter/examples/flutter_gallery/test/smoke_test.dart: Flutter Gallery app smoke test with semantics
> VideoDemo initController "butterfly"
> VideoDemo initController "bee"
> VideoDemo dispose
< VideoDemo dispose
01:10 +129 ~17: All tests passed!

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

cc @rami-a (this may help when migrating the video demo to the gallery v2?)

Waiting for @goderbauer to take another look, and for the tree to become green again!

Yay! Thanks @fluttergithubbot! :D

flutter update-packages breaks with this commit.

Only my update-packages seem to be broken with this commit, others aren't having an issue.


USDZ export causes our models to be face-down and tiny

This relates to the AR Mode in Model Viewer on iOS.
We’re trying to sort out why our models are being flipped face-down and resized to be tiny only on iOS when the AR mode button is pressed, even though they appear correctly in the viewer’s normal mode and on Android devices.
An example: https://playcanvas.com/viewer?load=https://metadata.plaguepoppets.io/ipfs/bafybeichk75gele2kbns5ymcesq5ekjpiju2egdqf4pp6uyobfxcevn26m.glb
Video:
https://github.com/playcanvas/model-viewer/assets/8558670/3b954a46-ee4c-441a-913d-24ba0f151c7f
Any ideas?

Could you try this with a model that is not animated please? USDZ format support does not handle animations currently.

That's interesting... Apple's "Reality Converter" seems to support animations so I guess it's not an issue with the file format, just not implemented by playcanvas? I'll see if I can rip the animations out of one of our GLBs to see if it helps... not an ideal solution for us for sure, though.

Could you try this with a model that is not animated please? USDZ format support does not handle animations currently.

There are many things missing from our USDZ implementation currently: https://github.com/playcanvas/engine/issues/4644
It's a complex format. They have native libraries to generate it, which are not available for javascript, so we generate a text based version of the format ourselves, but the documentation for this is limited.

Can confirm that removing animations does not solve the issue: https://playcanvas.com/viewer?load=https://metadata.plaguepoppets.io/ipfs/bafybeig25xsytquqq5fqkqccvsmyoamaudsct6dqop67xdk4r5ijo4oakm.glb

There are many things missing from our USDZ implementation currently: #4644
It's a complex format. They have native libraries to generate it, which are not available for javascript, so we generate a text based version of the format ourselves, but the documentation for this is limited.

Maybe I'll see if ChatGPT can help with porting the python libraries to javascript... There's also this C++ library from Google: https://github.com/google/usd_from_gltf

The other option would be to convert your glTF models to USDZ off-line, and download and use those for QuickLook instead of using runtime conversion, which is more limited.

This is also a possible solution: https://github.com/playcanvas/engine/issues/4644#issuecomment-2296331624


[FEATURE REQUEST] Quick Budget Half/Quarter Underfunded for bi-weekly/weekly paycheck-ers

Is your feature request related to a problem? Please describe.
I, along with many others, receive a paycheck every 2 weeks. I'm not yet at a point in my finances where I can budget a whole month in advance, so I have to manually enter half of a budget category's goal/needed funding every 2 weeks.
Describe the solution you'd like
It would be fantastic to have additional Quick Budget options, like "Half of Underfunded" and/or "Quarter of Underfunded" to automatically budget half of the underfunded amount in all categories/selected categories.
Additional context

We've got a similar request being tracked here: https://trello.com/c/VRUE1EKe


Type inconsistencies in implementations of ValueContainer#getValue?

Hello, I have a question on Data API.
I wanted to implement my own version of abstract data manipulator. I've already verified that it works for simple data constructs. While writing type proofs, I've found that it is not easy to ensure that the return value of getValue is Optional<V>. The question is; is it OK to return Optional<Value<E>> or Optional<ImmutableValue<E>> instead of Optional<V> in ValueContainer#getValue?
Looking at SpongeAPI code, it does the same thing as I do; it actually returns Optional<Value<E>> instead of Optional<V>: AbstractData#getValue, and Optional<ImmutableValue<E>> instead of Optional<V>: AbstractImmutableData#getValue
In the former code for example, shouldn't there be a case where V is ImmutableValue<E> and the code leads to a potential heap pollution? If so, may I propose the signature of ValueContainer#getValue to be
<E> Optional<? extends BaseValue<E>> getValue(Key<? extends BaseValue<E>> key)

instead?

It's never OK to return a weaker type. The abstract implementation provided in the API is a lose contracted and semi functioning implementation to provide developers ways to implement their own Data without having to write all of the boilerplate code themselves. It's been intended to strip away the abstract implementation in #1198, but it's not completed as other priorities take precedence.
To answer the question about whether the implementation does cause heap pollution: Short answer is no, but the long answer is dependent on the developer using the abstract implementation. If the plugin developer is returning a Value of a weaker type than the Key supports, that is their fault as the generic contract in their own created Key instances. Ultimately, Sponge's implementation of all Sponge provided Data does assure that heap pollution does not take place, because the return types of the Suppliers are matching the Value types identified by the Key.
It would be a good type check to use the Key's TypeToken to validate that the supplier is returning the correct type, and point it out to the plugin developer, but in short, the implementation is not responsible for what is ultimately considered "user error".
Proposing the change of signature isn't advisable as it breaks usability of the multiple types of possible Values available from Keys and restricts developers to having to do the type checking themselves.

Thank you for the reply. Now I see why the signature is like that.
I'm not yet clear with the (currently provided) implementation of Abstract(Immutable)Data.
If I'm not mistaken, AbstractData#getValue always returns a Value wrapped in Optional, and AbstractImmutableData#getValue always returns an ImmutableValue wrapped in Optional(I recognize that ensuring E is upto the plugin developer).
Does this imply that, for example, given a key that expects a Value<Int> from one manipulator, manipulator.asImmutable().getValue(key) should equal Optional.empty() because the immutable version does not have the corresponding mutable Value?

If I'm not mistaken, AbstractData#getValue always returns a Value wrapped in Optional, and AbstractImmutableData#getValue always returns an ImmutableValue wrapped in Optional(I recognize that ensuring E is upto the plugin developer).

You're confusing the declared type versus the instance type. Yes the internal Map declares the entries as Supplier<Optional<Value<?>> etc. but the actual return type has the contract of at least returning the type Value whereas the actual implementation of many differs based on the Key used as demonstrated in some implementations which end up being type checked based on the contracted methods.

Does this imply that, for example, given a key that expects a Value from one manipulator, manipulator.asImmutable().getValue(key) should equal Optional.empty() because the immutable version does not have the corresponding mutable Value?

Remember that the Values and Manipulators are contracted to have guaranteed equivalency when transferring from mutable -> immutable -> mutable such that the values are the same, and if the value is a bounded value, the bounds would likewise be the same. The one aspect of differences is that we're always passing the underlying raw value (whether it's an int, boolean, String, List<PotionEffect> etc.) to create either a new Value/ImmutableValue or if it's possible to retrieve a cached ImmutableValue.

hmm, I've tried the following code in spongevanilla-1.12.2-7.1.0-BETA-22(it's Kotlin code but I don't think that matters much):
causePlayer.get(SpongeHealthData::class.java).map {
    val healthKey: Key<MutableBoundedValue<Double>> = Keys.HEALTH
    val mutableManipulatorValue: Optional<MutableBoundedValue<Double>> = it.getValue(healthKey)
    val immutableManipulatorValue: Optional<MutableBoundedValue<Double>> = it.asImmutable().getValue(healthKey)

    println(mutableManipulatorValue)
    println(immutableManipulatorValue)
    val unwrapped: MutableBoundedValue<Double> = immutableManipulatorValue.get()
}

Declared types of those val variables are all inferred types. As the types suggest, I would expect MutableBoundedValue to be in both optionals.
However, what is logged is
[STDOUT]: Optional[SpongeBoundedValue{key=SpongeKey{..., valueToken=...mutable.MutableBoundedValue<....Double>, ...]
[STDOUT]: Optional[ImmutableSpongeBoundedValue{key=SpongeKey{..., valueToken=...mutable.MutableBoundedValue<....Double>, ...]

Therefore at the last line, ClassCastException is thrown. Is this still what is intended?

Yes... You'd still get a ClassCastException because you're declaring the type as ImmutableBoundedValue<Double>, which is what the return type would be (the pointer is to the latest commit that has edited the file, so that if bleeding ever changes in the future, the link will still work).
The other problem is that relying on the generics for the Key to inflect the value retrieved is not going to work in this case because the Key declares the generic as a mutable value, even though the value returned from the ImmutableDataManipulator/ImmutableDataHolder would always return an ImmutableValue or subclass thereof. Granted, the java docs are not clear on that aspect, but your local variable declaration is still valid for this line:
    val immutableManipulatorValue: Optional<MutableBoundedValue<Double>> = it.asImmutable().getValue(healthKey)

but the result will still be the same as explained above. The return value at runtime will be an immutable variant. Without breaking virtually all of Data API (due to the key values being declared with how they are), I could make the breaking change to where there's a base for the extraneous specific value types without them being mutable or immutable and only available as retrieval without being able to set the value unless you type check for mutability.

I see.

The other problem is that relying on the generics for the Key to inflect the value retrieved is not going to work in this case because the Key declares the generic as a mutable value, even though the value returned from the ImmutableDataManipulator/ImmutableDataHolder would always return an ImmutableValue or subclass thereof.

So that goes back to my original question; is this implementation ok?

Let me rephrase the question...
Suppose I have an implementation of immutable manipulator which returns ImmutableValue<E> wrapped in the Optional when inquired a value with getValue(Key<Value<E>>). Should such an implementation be avoided and should it always return Value<E> wrapped in the Optional, unlike the code in SpongeCommon does currently?

Re-opening because I may end up breaking Values API by splitting up the different types into immutable base types and then mutable types where asMutable() will be available (by default, all values would be immutable in a small regard, unless casting is considered), but we will have strict Immutable types still.

Closing as this will be resolved when #1843 is merged.


Migrate to GuCDK

What does this change?

Refactors the CDK setup to use GuCDK

to be deployed in the newsletters stack (which is hosted in the frontend account)

Adds a snapshot test of the stack
Updates the riffraff artifacts to use the new cloudformation templates

Deployment plan

Move parameter store items under the newsletters stack
Deploy the new stack

Because this is a scheduled lambda, both the old & new stacks can coexist

Tear down the old stack

 Migrate Newsletters API to GuCDK


Add global flag

Resolves https://github.com/okteto/okteto/issues/2182
Enable builds with manifest v2 and support the --global tag

Can't be merged until --global is available at cli okteto build

@teresaromero can we merge this one now cli 2.0 is available?

this PR only adds the flag of --global to the argument list, but we should check that there is compatibility between actions v1 and v2, as default values are different meaning in 2.0. path and file at v2 are pointing to services and manifest file, instead of Dockerfile and it's path...

@teresaromero I would update the action to follow the cli 2.0 syntax. people can ping to a previous action version if needed


Passenger README assumes Dalli for session store

Blindly cutting and pasting the if defined?(PhusionPassenger) stanza didn't work for me, because we're using :active_record_store.  Maybe add if Rails.application.config.session_store == :dalli_store?

No plan to fix.


set limit to amount of contacts to select

made a PR to the underlying library
https://github.com/1gravity/Android-ContactPicker/pull/8

will be release when lib version 1.2 is out


make the data-server and schema-server addresses configurable via ENV vars

https://github.com/iptecharch/config-server/pull/20


Script problem

Hi,
I am wondering if you can tell me why my script keeps throwing the below error?
CraftTweaker-1.10.2-3.0.16.jar
LootTweaker-1.10.2-0.0.4.jar
`import loottweaker.vanilla.loot.LootTables;
import loottweaker.vanilla.loot.LootTable;
import loottweaker.vanilla.loot.LootPool;
val simple_dungeon = LootTables.getTable("minecraft:chests/simple_dungeon");
//simple_dungeon
simple_dungeon.removeItemEntry(minecraft:bone);`
error
regards
scalda

removeItemEntry is a method of LootPool, not LootTable.
LootTables contain LootPools. LootPools contain LootEntries. Use table.getPool(poolName) to get a particular LootPool from a LootTable.

Thanks for that but I sorted it long before you replied to this
On 18 Mar 2017 02:28, "Daomephsta"<EMAIL_ADDRESS>wrote:

removeItemEntry is a method of LootPool, not LootTable.
LootTables contain LootPools. LootPools contain LootEntries. Use table
.getPool(poolName) to get a particular LootPool from a LootTable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Leviathan143/LootTweaker/issues/11#issuecomment-287510294,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABwLm3fSNvNRDe6oFYcTVJ84jVDmpbuVks5rm0FmgaJpZM4MfNJz
.

@scalda if you solve your own issue it is common courtesy to close it ypurself with the resolution for others incase they have the same issue.
Not being a complete fuck-tard to people who are helping you.

@bookerthegeek Please do not use insults.
@scalda As booker said, it is common courtesy to leave the solution for others.


[DE] add content/de/cloud_native_security.md

Add german translation for the Cloud Native Security part
https://github.com/cncf/glossary/issues/516

follow up #990


Failed to process download URL

DEBU[0000] Using /data to match uid and gid
DEBU[0000] Resolved UID=1000 from match path
DEBU[0000] Resolved GID=1000 from match path
2022/03/10 17:33:10 Failed to get from URLGet https://www.minecraft.net/en-us/download/server/bedrock/: dial tcp: lookup www.minecraft.net on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:38056-><IP_ADDRESS>:53: i/o timeout
Failed to process download URL
When installing the latest version from the QNAP server, a download error appears.

 I would suggest researching docker DNS QNAP configuration issues.

hmm...
itzg/docker-minecraft-server was installed without any problems.


Persistent Component - Causing Problems

When uploading a custom json configuration, one component from the original configuration persists, but does not work, and when interacted with, it resets the configuration.
The persistent component is "upper Cube/Cone Missed" which is the second component in the auto section.
This component does not exists in our custom configuration, but is showing up on the webpage, and when we click on it, suddenly the configuration resets, but the component does not work.

This is happening for us as well.

Taking a look!
On Sun, Feb 26, 2023, 10:15 AM Allen Gregory @.***>
wrote:

This is happening for us as well.
—
Reply to this email directly, view it on GitHub
https://github.com/FRC2713/QRScout/issues/9#issuecomment-1445386364, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSYETMHJS7SUYT2SKSD4GDWZNXRPANCNFSM6AAAAAAVHSVC6I
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Could one of you upload your config file for me to test with?

https://drive.google.com/file/d/1E3th62ELcriYDH4F61FJYv-jKrTFVCti/view?usp=drivesdk

This should be fixed once vercel picks up the changes from #10 .  Also added dark mode which will be picked up automatically if your OS is set to dark mode.

actually, ill let one of you confirm and close.

Resolved for us! Thank you very much! Excited to use this again this year!


Persist the backfill state when the backfill task is finished

https://github.com/risingwavelabs/risingwave/pull/12535 doesn’t persist the backfill state yet, it will backfill again during recovery.

Do we also want to handle recovery for this issue? Seems like this PR only persist the backfill state for cdc executor, but I'm not sure if that's sufficient.
In meta, we need to persist the table fragments and table proto as well. Otherwise they will be lost on recovery.
Similar to https://github.com/risingwavelabs/risingwave/pull/12167

I take a look of https://github.com/risingwavelabs/risingwave/pull/12167, since CREATE TABLE is always Foreground (it will return success after collect the initial barrier), so I think we don't need to recover its progress likes Background streaming job does.

I take a look of https://github.com/risingwavelabs/risingwave/pull/12167, since CREATE TABLE is always Foreground (it will return success after collect the initial barrier), so I think we don't need to recover its progress likes Background streaming job does.

Ah got it. Makes sense to me.


Cache downloads before starting build. (fixes #59)

Why? This separates the process of downloading the dependencies and
then building them. This helps support packaging efforts as we can just
download the dependencies and tar up the directory ready to be built.
Steve, you probably object to the use of cp, which I will remove and replace with the tar pattern, if you can convince me why it is problematic ;)

Really nice treatment of a delicate change. Super job. I have added a couple of minor comments that I think need sorting out.


database cleaner breaks .reload in some cases?

We have some code where we reload an instance and then call update_attributes.
instance.reload.update_attributes error: error, last_sync_failure: Time.now

After the update from 1.2.0 to 1.6.1 this suddenly fails because it's trying to do an insert instead of an update in the database (making a database restraint fail).
The really funny thing is
instance.reload.reload.update_attributes error: error, last_sync_failure: Time.now

works just fine. As does
instance.tap(&:restore_attributes).update_attributes error: error, last_sync_failure: Time.now

No time right now to create a small testrepo, but figured I'd mention it anyway.
No other gems or code where updated.

Very odd and probably not related to this gem.


Don't prompt publish if set to private

Addresses issue #18

FYI, regardless of where npm is configured to publish it will throw an error if you try to publish when the private flag is turned on. I wasn't aware of this behavior previously, but @Prestaul clued me in a few weeks ago.


Setting Control's layout to "Full Rect" makes the Control disappear if the parent is Node2D.

Godot version
3.5 rc3
System information
Windows 10
Issue description
If the parent of a Control Node happens to be Node2D or node that inherits from it and the Layout is set to "Full rect", then the node disappears, minimizes to (0,0) dimensions. This doesn't happen if the Control is child of Node, Control or Spatial, the fill the viewport as expected. It's weirdly inconsistent with the rest of the engine.
Steps to reproduce

Add Node2D or node that inherits from it to the scene inside the editor
Add child Control node to it.
Press this:

Minimal reproduction project
No response

I think this is expected as a plain Node2D does not have any size. If Sprite is used as the parent, the full rect control will correctly take up the textured area.
For nodes that are not 2D, i.e. not a subclass of CanvasItem, the viewport rect is used.

That is intended behavior? Ok, wow. Should I open proposal for a change? I can't think of single time where this would be useful when using Control inside Node2D.

This is how the anchor system works. All CanvasItem nodes have get_anchorable_rect() which provides the rect area for child controls to anchor.
https://github.com/godotengine/godot/blob/a0f70c58196ad6c879926f8b40f1c2c083114d8f/scene/2d/canvas_item.h#L390-L391
Control nodes override it:
https://github.com/godotengine/godot/blob/a0f70c58196ad6c879926f8b40f1c2c083114d8f/scene/gui/control.cpp#L1688-L1690
So does Node2D nodes that have visual representations. e.g.
https://github.com/godotengine/godot/blob/a0f70c58196ad6c879926f8b40f1c2c083114d8f/scene/2d/sprite.cpp#L75-L77
https://github.com/godotengine/godot/blob/a0f70c58196ad6c879926f8b40f1c2c083114d8f/scene/2d/touch_screen_button.cpp#L326-L332
There is also a similar issue #18166.
Anyway, feel free to open an proposal if you think it's better to change the behavior in 4.0.

I think the control's rect should not be changed if the parent's anchorable rect is Rect2(0, 0, 0, 0) when using one of the layout options.

Printing an message might be annoying. e.g. Rect2(0, 0, 0, 0) is a valid choice for animation.

Wouldn't valid solution be if Node2D's implementation of get_anchorable_rect() would just return viewport size?

Returning the viewport size would result in problematic behavior as described in #36166.


Fix style

On Nov 7, 2018 05:40, 谭九鼎<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/dotnet/docs/pull/8908
Commit Summary

Fix style

File Changes

M docs/standard/io/file-path-formats.mdhttps://github.com/dotnet/docs/pull/8908/files#diff-0 (4)

Patch Links:

https://github.com/dotnet/docs/pull/8908.patch
https://github.com/dotnet/docs/pull/8908.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/docs/pull/8908, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJZVQzv8GI1SHMNKI7mPCpRWgPqHE1xOks5uskEYgaJpZM4YRpea.


Implement vale in pyfluent-visualization

Hi @PipKat!
Following https://github.com/pyansys/pyfluent/pull/655, I have open this new PR to implement vale in the pyfluent-visualization repo. Let me know if you have any problems. Just, check out my branch and start implementing there the vale checks.
Thanks in advance!
As it is being done in other PyAnsys projects, vale has been implemented. Vale is a linter which eases the review process to the documentation team by detecting common mistakes and forcing the developer to follow the Google style guidelines when writing the docs.

@dnwillia-work All checks have passed. As I indicated in chat, the edits made in this PR are only the ones needed to get Vale implemented. Would you please assign another reviewer so that we can get this PR merged? I see you have an issue opened here about all the doc changes that need to be made. Once I complete a PR adding Vale info to the Python Developer's Guide, I can add a link to your issue. The content I'm adding explains how to run Vale locally and fix the issues that are found so that your PR can be completed. @RobPasMue Just tagging you so that you see that I've resolved the Vale issues.

@dnwillia-work All checks have passed. As I indicated in chat, the edits made in this PR are only the ones needed to get Vale implemented. Would you please assign another reviewer so that we can get this PR merged? I see you have an issue opened here about all the doc changes that need to be made. Once I complete a PR adding Vale info to the Python Developer's Guide, I can add a link to your issue. The content I'm adding explains how to run Vale locally and fix the issues that are found so that your PR can be completed. @RobPasMue Just tagging you so that you see that I've resolved the Vale issues.

Done, I've added Aseem and Sean, either of them can approve.

@dnwillia-work All checks have passed. As I indicated in chat, the edits made in this PR are only the ones needed to get Vale implemented. Would you please assign another reviewer so that we can get this PR merged? I see you have an issue opened here about all the doc changes that need to be made. Once I complete a PR adding Vale info to the Python Developer's Guide, I can add a link to your issue. The content I'm adding explains how to run Vale locally and fix the issues that are found so that your PR can be completed. @RobPasMue Just tagging you so that you see that I've resolved the Vale issues.

Thanks @PipKat, LGTM!

@ajain-work and @seanpearsonuk  We are looking for another person to review and approve this PR. Thanks!


Slack importer: Moving slack importer to zulip server repo.

Usage:
./manage.py convert_slack_data <slack_zip_file> "realm_name" --output <output_dir>
(default output_dir would be in /tmp/converted-slack-data- (prefix))
./manage.py import --destroy-rebuild-database <output_dir> to import converted data into the zuilp instance.
I have added the following:

Travis tests in  tools/travis/backend.
zerver_realm_skeleton in /zerver/fixtures (this is the skeleton json data format of the realm)
slack_data_to_zulip_data script in zerver/lib
created the ./manage.py command convert_slack_data

For the system bots:
I have added the list of the system bots in  zerver/fixtures

I'll probably need to do a more detailed review on this before adding it to the server repo.  Feel free to ping me if I don't get back to it soon.

The documentation https://github.com/zulip/zulip/blob/e5c05f128ab752aa256e6a46742ef7f224871e50/templates/zerver/help/import-users-and-channels-from-slack.md should be updated to use the new method.

@gglanzani might be interested in subscribing to this.

Merged, thanks @rheaparekh!  sorry it took me so long to get to this

@showell The Travis tests are failing in the master due to the commit messages linter. It was added after this PR and I hadn't updated this.

@rheaparekh Thanks for the heads up.  I think we're fine going forward.


Custom log format for Nginx and GoAccess

hi ,
i got this error below when i generate to .html is there any configuration that i missed on goaccess.conf  ?
Token '[05/Sep/2017:06:25:05' doesn't match specifier '%h'
Token '[05/Sep/2017:06:25:20' doesn't match specifier '%h'
Token '[05/Sep/2017:06:25:21' doesn't match specifier '%h'
here's my custom logs :
log_format upstreamlog '[$time_local] $remote_addr - $remote_user - $server_name to: $upstream_addr: $request upstream_response_time $upstream_response_time msec $msec request_time $request_time';

Please post a few lines from your access log.

Closing this. Feel free to reopen it if you are still having this issue along with a few lines from your access log.

Sep  9 06:39:01 thunder CRON[16142]: pam_unix(cron:session): session opened for user root by (uid=0)
Please provide log,date and time format

@anamika-m please note that goaccess is a web log (access.log) analyzer, so you won't be able to parse that string.

Mar  1 06:30:58 gw kernel: [782740.844689] FORWARD-New-Connection: IN=eth1 OUT=eth1 MAC=2c:41:38:88:45:35:d4:85:64:16:54:62:08:00 SRC=<IP_ADDRESS> DST=<IP_ADDRESS> LEN=60 TOS=0x00 PREC=0x00 TTL=254 ID=1646 PROTO=ICMP TYPE=8 CODE=0 ID=5 SEQ=6250
Please provide log,date and time format

@anamika-m Try this, it should work:
goaccess your.log --log-format='%d %t %^ %v: %^ %U: %^ %^ %^ %^=%h %R %^=%b %^ %^ %^=%L %^' --date-format='%b %e' --time-format=%T --ignore-panel=BROWSERS --ignore-panel=OS --ignore-panel=STATUS_CODES --ignore-panel=REFERRING_SITES --ignore-panel=REQUESTS_STATIC --ignore-panel=NOT_FOUND --http-method=no --http-protocol=no


Removes bytes from sparse array HTML repr

Closes #5543

[ ] Tests added / passed
[ ] Passes black dask / flake8 dask

Thanks @jrbourbeau !  Merging.


Emit node configuration warnings for GeometryInstance3D distance fade

The visibility range begin/end margin properties must be set above 0.0 for the fade transition to be visible.
This closes https://github.com/godotengine/godot/issues/55366.
Question: Are there use cases where you want only one of the transitions to be smooth? Is this needed for intermediate LOD levels (when you have 3 or more LOD levels), for instance? Right now, the node configuration warning will be emitted individually for the "begin" and "end" fade transitions. If this is a problem, we should merge both together and only emit a single warning if neither of the transitions have a non-zero margin.

Question: Are there use cases where you want only one of the transitions to be smooth? Is this needed for intermediate LOD levels (when you have 3 or more LOD levels), for instance? Right now, the node configuration warning will be emitted individually for the "begin" and "end" fade transitions. If this is a problem, we should merge both together and only emit a single warning if neither of the transitions have a non-zero margin.

Yeah, intermediate LOD levels grant using different fade modes on the begin and far range limits, so the PR looks good as it is now.


I'm being run in an Ignite directory.

Sorry, I couldn't create a new app here, I'm being run in an Ignite directory.

[x] ignite the cli

Computer
  Platform: darwin

Ignite
  Version: 1.13.0
  Path: /Users/ankitkr/.nvm/versions/node/v6.9.2/bin/ignite

Node
  Version: v6.9.2
  Path: /Users/ankitkr/.nvm/versions/node/v6.9.2/bin/node

NPM
  Version: 3.10.9
  Path: /Users/ankitkr/.nvm/versions/node/v6.9.2/bin/npm

Yeoman
  Version: 1.8.5

React Native CLI
  Version: 2.0.1

App
  React Native Version: ¯\_(ツ)_/¯

Just installed ignite with guidelines but facing this error when init a new app.
ignite new test
test folder does not exists in the directory.
Am I missing something?
#349
// https://github.com/infinitered/ignite/blob/master/ignite-cli/src/index.es

// Early exit if the project name already exists (#349)
const checkDir = (project) => {
  if (fs.existsSync(process.cwd() + '/' + project.toString())) {
    console.log(`Sorry, I couldn't create the directory for "${project}" - it already exists. :(`)
    Shell.exit(1)
  };

  if (fs.existsSync(process.cwd() + '/App')) {
    console.log('Sorry, I couldn\'t create a new app here, I\'m being run in an Ignite directory.')
    Shell.exit(1)
  }
}

Everything appears to be good - checking on the current directory where I've init'ed ignite with CLI.

Is there an App directory in that folder? That check is a little over-simplified.

Damn! I missed it, there is an App directory in my folder, sorry about this 💯

No problem, in the future we'll have a more specific check that won't fail when a generic folder is present.


[reggen] Add missing validation for simple block syntax

This validate function was only invoked on the complex block syntax before.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

I accidentally noticed this when trying to add an error message for #8514.

Closing this, since we can merge this commit together with #17050.


Space Breaks Search

If the search contains a space it throws an error of
"Error
An Error Occurred in handleGetSearch'. Code: -3 -
No URL set!”
By playing with the phone remote app for Roku I discovered that if the space is replaced with a + the search works and the + is treated as a space in the search.
So, I think a simple find and replace of space with + in the search string will fix this issue.

Thanks for the bug report. Will get this added into v2.2

Awesome! Thank you!
On Tue, Jul 10, 2018 at 9:46 PM, Chris Taylor<EMAIL_ADDRESS>wrote:

Thanks for the bug report. Will get this added into v2.2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Checked into development. Added to Release v2.2 .
Closing bug report.


[5.2] [Typechecker] Fix _modify for wrapped properties with observers

Cherry-pick of #29931

Since we implemented _modify synthesis for property wrappers, it seems like we go through the _modify even when the wrapped property has explicit observers attached to it, which means the observer is never called. For example:
@propertyWrapper
struct Foo {
  private var _storage: [Int] = []

  init(wrappedValue value: [Int]) {
    self._storage = value
  }

  var wrappedValue: [Int] {
    get { _storage }
    set { _storage = newValue }
  }
}

class Bar {
  @Foo var someArray = [1, 2, 3] {
    willSet { print(newValue) }
  }
}

let bar = Bar()
bar.someArray[0] = 4 // This doesn't trigger willSet anymore

This used to work fine on Swift 5.1, but not anymore.
So, if the wrapped property has any observers, then fix _modify to call setter.
Resolves SR-12178, SR-12089
Resolves rdar://problem/59496047

@swift-ci please test

cc: @najacque

Build failed
Swift Test OS X Platform
Git Sha - 8a049d02c9d2633bbf9440665811a35c8c80ada1

Build failed
Swift Test Linux Platform
Git Sha - 8a049d02c9d2633bbf9440665811a35c8c80ada1

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 8a049d02c9d2633bbf9440665811a35c8c80ada1

Build failed
Swift Test OS X Platform
Git Sha - 8a049d02c9d2633bbf9440665811a35c8c80ada1

@swift-ci test

Build failed
Swift Test Linux Platform
Git Sha - fa1370eaeefc11f43816fc9405ea2afc85e15c5d

Build failed
Swift Test OS X Platform
Git Sha - fa1370eaeefc11f43816fc9405ea2afc85e15c5d

@swift-ci please test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - fc6b6c5027dab317e36a8c22696cb0e26f1eea49

Build failed
Swift Test OS X Platform
Git Sha - fc6b6c5027dab317e36a8c22696cb0e26f1eea49

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 36b5262a0f72dc01de618e398f0762d654135d26

Build failed
Swift Test OS X Platform
Git Sha - 36b5262a0f72dc01de618e398f0762d654135d26

I think it’s going to be difficult to get this merged, because this branch is missing some fixes from master (i am not sure which ones though), so I need to find out what’s needed or I need to figure out how to fix the test failure. There were 7 or more before and I’ve got it done to 1.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - a422a1e2921932da169479c6b48fa78963e455b0

Build failed
Swift Test OS X Platform
Git Sha - a422a1e2921932da169479c6b48fa78963e455b0

I'm relatively new here, so I need to understand the processes. I'm afraid this being merged only a few hours ago, it didn't make it in Swift 5.2.2 which is in Xcode 10.4.1, right? How would I know this precisely? Can I find Swift 5.2.2 release notes somewhere?

Yes. It should be available in the next Xcode 11.4.x release, I believe.


Type consistencies in core

Fixes #45307:

Remove Color's /= real_t or /= float check for if the divisor is zero. This needs approval from @reduz.

Color's operators are changed from real_t to float because Color never has a need for more precision than float (using double is useless for Color).

Color's operators have the parameter name p_rvalue changed to p_scalar (this is what the vectors use).

Additionally:

Use get_float() for Color in core/io/resource_format_binary.cpp

Use real_t for AABB quantizing methods (new in #44656).

Use real_t for Basis rotated binding.

Use int instead of double for integer calculations in String::similarity.

Thanks!

Thanks!


Autotag Complete Not Wkring since Last Forge Update

Autotag Complete Not Wkring since Last Forge Update
I also tried a clean new installation in another folder with 1111 Webui, it doesn't work with Forge

It works normally for me on forge f2.0.1v1.10.1-previous-549-g4baf8ffb / Commit hash 4baf8ffb9c617c05a4e3c23dcaafcdcedf5e42b2, which is the most recent release on the forge main branch at the time I write this.
So if it wasn't caused by something already fixed by now in forge and still doesn't work for you, I can't help you without more information. Are there any errors logged in the terminal window or in the browser console?

I get errors like this when typing in A1111. It works fine in forge though.

*** Error loading script: model_keyword_support.py
Traceback (most recent call last):
File "E:\Data\Packages\Stable Diffusion WebUI Forge\modules\scripts.py", line 525, in load_scripts
script_module = script_loading.load_module(scriptfile.path)
File "E:\Data\Packages\Stable Diffusion WebUI Forge\modules\script_loading.py", line 13, in load_module
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\Data\Packages\Stable Diffusion WebUI Forge\extensions\a1111-sd-webui-tagcomplete\scripts\model_keyword_support.py", line 7, in
from scripts.shared_paths import EXT_PATH, STATIC_TEMP_PATH, TEMP_PATH
ModuleNotFoundError: No module named 'scripts.shared_paths'

*** Error loading script: tag_autocomplete_helper.py
Traceback (most recent call last):
File "E:\Data\Packages\Stable Diffusion WebUI Forge\modules\scripts.py", line 525, in load_scripts
script_module = script_loading.load_module(scriptfile.path)
File "E:\Data\Packages\Stable Diffusion WebUI Forge\modules\script_loading.py", line 13, in load_module
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\Data\Packages\Stable Diffusion WebUI Forge\extensions\a1111-sd-webui-tagcomplete\scripts\tag_autocomplete_helper.py", line 20, in
from scripts.model_keyword_support import (get_lora_simple_hash,
ModuleNotFoundError: No module named 'scripts.model_keyword_support'

*** Error loading script: tag_frequency_db.py
Traceback (most recent call last):
File "E:\Data\Packages\Stable Diffusion WebUI Forge\modules\scripts.py", line 525, in load_scripts
script_module = script_loading.load_module(scriptfile.path)
File "E:\Data\Packages\Stable Diffusion WebUI Forge\modules\script_loading.py", line 13, in load_module
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "E:\Data\Packages\Stable Diffusion WebUI Forge\extensions\a1111-sd-webui-tagcomplete\scripts\tag_frequency_db.py", line 4, in
from scripts.shared_paths import TAGS_PATH
ModuleNotFoundError: No module named 'scripts.shared_paths'

@gitupp22 never seen that before, but it looks like an encoding error. That is most definitely not related to this though, so please open a new issue for it.
@andy8992 This is an old forge bug that has been fixed on their side ages ago, see #299. TL;DR: you need to make sure forge is updated and likely have to recreate your venv. It's a dependency conflict that messes up not only TAC, but all extensions that import from local files without a module.

@ThesiiNCey Thanks for the info, I had a look and was able to figure something out. However, it's sadly out of my control. The short answer is that Civitai Browser Plus is pretty buggy right now, especially on forge.
The actual issue is related to https://github.com/BlafKing/sd-civitai-browser-plus/issues/326.
Civitai Browser Plus has some update conditions that result in infinite loops, the main culprit I could find was this part of its UI code:
preview_html.change(fn=None, _js="() => adjustFilterBoxAndButtons()")
adjustFilterBoxAndButtons() is a function that on its own makes changes to the preview HTML, so it triggers itself again and again. This results in massive lags even on a high-end system, I'm seeing constant 8% CPU usage in chrome vs 0-1% without Civitai Browser installed.
Why does this affect Tag Autocomplete instead of just causing laggy UI?
Because Gradio, at least in forge, uses a queuing system to process scripts. Normally, this is good for performance as it spreads out loading a bit. But in this case the queue gets completely filled with these infinite update loops, so almost no other script gets a chance to load. This doesn't just affect TAC, but it's especially noticeable here, since TAC needs to load its tag files into the browser before it can even start working.
You can easily test this yourself:
Start the webui, wait until the page loads, then switch to a different tab for a few seconds and back to the webui. Suddenly, TAC will work again, even if it wasn't before. That's because as soon as the page is no longer the open tab, gradio pauses UI updates to save performance, resulting in a much emptier queue and TAC getting a chance to load.

Now, all this being said, there is pretty much nothing I can do to fix this on my side. You'll have to wait until Civitai Browser is updated to resolve these infinite loop issues. I would honestly recommend not using it at all until then (at least on forge) as the performance issues it causes make the whole UI worse to use.

@crusader290 I think you are talking about a different thing here. It sounds more like what I mentioned in #297, this could be the cause here:

Like some other implementations (maybe also dependent on settings), the SD model now gets loaded not on startup, but on demand (i.e. once you click generate)
TAC uses the webui's internal model database to fast-reload embeddings and figure out if they're SD1/SD2/SDXL, so before the model is loaded, embeddings will show up as "unknown". This is not fixable. Once the model was loaded for the first time, it should show the correct types.
This also means that newly added embeddings will only show up after a model switch/reload

TAC has a force-refresh button at the bottom of its settings list, you could try generating something so the model is guaranteed to be loaded and then hit that refresh button. That should update the embedding list if nothing else works.

Thank you so much!


Segfault when compiled inside docker

After running my compiled application, I get the following segfault:
#0 0.348
#0 0.348 ===== CRASH =====
#0 0.348 si_signo=Segmentation fault(11), si_code=1, si_addr=0x510
#0 0.602 Aborted (core dumped)

That's how my dockerfile looks:
FROM dart:latest

WORKDIR /app
RUN dart pub global activate melos
COPY . .
RUN $HOME/.pub-cache/bin/melos bs --no-flutter
RUN dart compile exe x/bin/x.dart -o x/bin/x
RUN ./x/bin/x

Doing a dart run inside the container instead of compile runs the app without issues.
On my host machine the steps described above in very same order without docker are working as expected, the compiled application is running fine. I also tried to base the docker image on my local version 2.17.6 => docker:2.17.6, but it didn't solve the problem.
Please let me know how I can provide more information.

@FaFre can you describe your host environment? (e.g. are you by chance using an M1 Mac)?

@mraleph No, this is a normal x64, running Linux
Flutter doctor:
[✓] Flutter (Channel stable, 3.0.5, on Manjaro Linux 5.19.1-3-MANJARO, locale en_US.UTF-8)
    • Flutter version 3.0.5 at /home/fafre/Software/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (8 weeks ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /opt/android-sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = /opt/android-sdk
    • ANDROID_SDK_ROOT = /opt/android-sdk
    • Java binary at: /usr/bin/java
    • Java version OpenJDK Runtime Environment (build <IP_ADDRESS>+1)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = chromium

[✓] Linux toolchain - develop for Linux desktop
    • clang version 14.0.6
    • cmake version 3.23.3
    • ninja version 1.11.0
    • pkg-config version 1.8.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Manjaro Linux 5.19.1-3-MANJARO
    • Chrome (web)    • chrome • web-javascript • Chromium 104.0.5112.79 Arch Linux

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Okay, this seems to be related to shared library I compile in another build step. I will further investigate, for now I will close this issue.


Add off-by-default verbose logging support to the MRTK

This change introduces a LogVerbose and LogVerboseFormat helper along with some initial logging to critical systems (in particular, the input system and input simulation).
Currently the act of debugging issues in MRTK is fairly difficult because you have to be able to locally repro and issue (which usually means getting the exact setup of a consumer). It's otherwise fairly impossible to debug without having a local setup.
Logging is a super common way of adding more information to the code so that instead of having to set up a local repro, we can ask consumers to take a log (i.e. just send us their unity player log/editor log between specific timestamps). The idea here is that we can use the log to either figure out what's wrong (oh look, you used ARM64 and there's this ARM64 bug that's affecting everyone right now), or use the log to narrow down on a specific issue (hey, we think it's probably because of the way this system is misbehaving, we still need to get a local repro but it'll be easier to immediately look into things because we know where to look).
Overall this change adds:

Verbose logging ability off by default (configured via the diagnostics tab).
Some initial logging in the input system/MRTK core object.
Docs guidance (both for the diagnostics system tab and for coding guidelines to add logs for interesting events)

Usually you invest in logs from the beginning, so that they're useful from the get go - until we have more logs here it'll likely be that these won't be fully useful, however we have to start somewhere.

/azp run

/azp run mrtk_docs

What is the perf impact of the default logging level?

/azp run

What is the perf impact of the default logging level?

Should be fairly minimal - it's doing an int comparison to know whether or not to log. The statements in here that do string interpolation also don't evaluate unless logging is enabled, so the memory changes should be zero.

:shipit:


grep: ../RadeonRays/include/radeon_rays.h: No such file or directory

When run "Tools/premake/linux64/premake5 gmake" on Linux system, there is error for not finding radeon_rays.h below. Actually the file should be under "RadeonRays/RadeonRays/include/radeon_rays.h"
$ Tools/premake/linux64/premake5 gmake
grep: ../RadeonRays/include/radeon_rays.h: No such file or directory
>> RadeonRays: CL kernels embedded
>> CLW: CL kernels embedded
Building configurations...
Running action 'gmake'...
Generated Makefile...
Generated Baikal/Makefile...
Generated Gtest/Makefile...
Generated RadeonRays/RadeonRays/Makefile...
Generated RadeonRays/CLW/Makefile...
Generated RadeonRays/Calc/Makefile...
Done (76ms).

You need to follow submodule update steps from readme file


Type schema creation refactoring.

@confluentinc It looks like @BillyFromAHill just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

does this fix a problem? after a quick look, it looks like the suggested factoring is probably better, but every change comes with a risk of breaking something and I need to review 3rd party changes very carefully (so this PR will probably remain unactioned due to time prioritization). that said, thanks for the contribution!

does this fix a problem? after a quick look, it looks like the suggested factoring is probably better, but every change comes with a risk of breaking something and I need to review 3rd party changes very carefully (so this PR will probably remain unactioned due to time prioritization). that said, thanks for the contribution!

This PR removes necessity of static _Schema field for the type and some of the copypaste around schema resolving. We needed it for our project, but in result we made some workarounds.


TAS: assign pods based on ranks for Job

What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #3533
Part of #3450
Special notes for your reviewer:
Does this PR introduce a user-facing change?

TAS: support rank-ordering of Pods for the Kubernetes batch Job.

cc @PBundyra

@PBundyra anything missing before we merge?

We discussed offline that e2e tests will be added in a follow up PR. In that case, LGTM. Thanks @mimowo
/lgtm


~ "Added meta tag"

Added meta tag in the main html file for the website to be responsive for all devices
<meta name="viewport" content="width=device-width, initial-scale=1.0">

Thanks! Sorry, but I was sick for few days and I didn't notice your PR :D


Add .mjs extension for testjs icon

Changes proposed:

[x] Add
[ ] Delete
[ ] Fix
[ ] Prepare

I was just reading about [mjs](https://medium.com/passpill-project/files-with-mjs-extension-for-javascript-modules-ced195d7c84a) and thinking maybe it's best to assign them a different icon, so to make them distinguishable from the vanilla js ones. Something in the line of the official JS icon but with a different background color, like this.

And additionally test.mjs file extension should get its own icon too.

TBH, I'm not really sure about creating a new icon for .mjs. In the end is just plain js and it's indeed supported by the js language id. I mean, in .jsx for instance we have some sort of DSL, so it makes sense to put a specific icon. But in ES6 modules, we're just writing vanilla JavaScript. We don't have icons for CommonJS, AMD or UMD modules, for example.

I'm glad to do a small contribution here ;)
I agree that for now modules icons should look like js ones, the appeal to use .mjs is already too low to also give away the familiar "javascript yellow"


Symbol Editor compatibility with Military Overlay Information Model Layer Package (lpkx)

This is the Military Overlay Layer Package, which I just wrote solutions pages for. I don't know what else needs to be done to have the editor work with this, but it contains the same Military Overlay gdb schema. Not a showstopper, but should be done at some point.
Until released, you can load the layer package here: https://github.com/Esri/military-features-data/blob/master/data/mil2525d/overlay_templates/layerpackages/MilitaryOverlay.lpkx

Previously we had a message that popped up that could take the user to a website to download the overlay template if it didn't detect the Military Overlay database.  If we add the capability to add in the layer package if the schema isn't detected, do we want to give the user a choice to go to the website to get the overlay as well?  Or just ask if they want to add the layer package?

We probably no longer need this - we just want to make sure we don't do anything (like the deferred "go to share overlay task") that assumes the add-in will only be running with MilitaryOverlay template now.
It would be good if we could figure out where to put an "About" button/box that would still take you to the latest template/doc at: http://esriurl.com/AFDMilitaryOverlay
The released lpkx is here btw in case you don't have: http://solutions.arcgis.com/defense/templates/military-overlay-information-model/ ( @Dbarnes1 - not sure what the short URL is for this)

Thanks, then I'll just give the option for adding the lpkx file.  We should add another task/issue for the "About" button I guess.
I'll grab the latest lpkx, it needs to be included in the add-in to work (at least at the moment).

esriurl.com/MilitaryOverlayInformationModel short url for the information model

Assigning to @Dbarnes1 to verify the 2 cases:

Project has MOIM loaded and addin is enabled / works as expected
Project does not have MOIM and addin adds layer package to project

Assigning to @BobBooth to possibly verify with #30 (while Dan is busy)

Testing reveals a small issue - when I created a new, blank project and started searching for symbols, I did get the "do you want to add the layer package" message. However, I had no map in my project yet, so I got the "please add a map and try again" message. All very well so far. I added a map. Then I changed it coordinate system to WGS 84 UTM zone 12 N (the default coordinate system of new maps seems to be Web Mercator (auxiliary sphere) which is frowned upon). After I did this, I went back to the add in, searched, and did not immediately get the "military schema not detected" message. I double-clicked the same symbol I had picked before. Nothing. It seems you have to choose a different symbol to trigger the "add layer package" logic.  Can we make it so clicking any of the symbols triggers it?

I will mark this verified, as it works. I will add an additional issue to fix layer for the enhancement to smooth that little bump.
@csmoore @Dbarnes1 @tlauver


Duplicate template file names cause build error

If there are any duplicate file names across any template directories, a build error occurs as the temporary .archive directory uses a flat file structure.
https://travis-ci.org/ampproject/ampstart/builds/207479033

[19:37:17] Starting 'bundle'...
fs.js:894
  return binding.mkdir(pathModule._makeLong(path),
                 ^
Error: EEXIST: file already exists, mkdir '.archive/article/css'
    at Object.fs.mkdirSync (fs.js:894:18)
    at Object.done (/home/travis/build/ampproject/ampstart/tasks/bundle.js:57:10)
    at process.nextTick (/home/travis/build/ampproject/ampstart/node_modules/jsdom/lib/jsdom.js:320:18)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

Fixed


[Multi-stage] Remove PhysicalPlanContext and clean up op-chain executor logic

Remove PhysicalPlanContext and use OpChainExecutionContext instead
Add request metadata in OpChainExecutionContext
Clean up unused fields

Codecov Report

Merging #11439 (f73d486) into master (37e70ec) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #11439      +/-   ##
============================================
- Coverage     14.50%   14.49%   -0.02%
  Complexity      201      201
============================================
  Files          2301     2302       +1
  Lines        123819   123988     +169
  Branches      18848    18894      +46
============================================
+ Hits          17965    17969       +4
- Misses       104337   104498     +161
- Partials       1517     1521       +4

Flag
Coverage Δ

integration
<0.01% <0.00%> (?)

integration1
<0.01% <0.00%> (?)

integration2
0.00% <0.00%> (?)

java-11
14.47% <0.00%> (-0.03%)
:arrow_down:

java-17
14.48% <0.00%> (-0.01%)
:arrow_down:

java-20
14.47% <0.00%> (-0.03%)
:arrow_down:

temurin
14.49% <0.00%> (-0.02%)
:arrow_down:

unittests
14.48% <0.00%> (-0.03%)
:arrow_down:

unittests2
14.48% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...requesthandler/MultiStageBrokerRequestHandler.java
24.21% <0.00%> (+0.18%)
:arrow_up:

...va/org/apache/pinot/query/runtime/QueryRunner.java
0.00% <0.00%> (ø)

...g/apache/pinot/query/runtime/operator/OpChain.java
0.00% <0.00%> (ø)

...ot/query/runtime/plan/OpChainExecutionContext.java
0.00% <0.00%> (ø)

.../pinot/query/runtime/plan/PhysicalPlanVisitor.java
0.00% <0.00%> (ø)

...runtime/plan/pipeline/PipelineBreakerExecutor.java
0.00% <0.00%> (ø)

.../runtime/plan/server/ServerPlanRequestContext.java
0.00% <0.00%> (ø)

...ry/runtime/plan/server/ServerPlanRequestUtils.java
0.00% <0.00%> (ø)

.../runtime/plan/server/ServerPlanRequestVisitor.java
0.00% <0.00%> (ø)

.../pinot/query/service/dispatch/QueryDispatcher.java
0.00% <0.00%> (ø)

... and 1 more

... and 17 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


I Faced an issue with image_picker library on IOS 17.2.1

Steps to reproduce
once I tried to select an image from gallery, this error is thrown: (PlatformException(invalid_image, Cannot load representation of type public.jpeg, NSItemProviderErrorDomain, null))
Expected results
the image should be selected.
Actual results
PlatformException(invalid_image, Cannot load representation of type public.jpeg, NSItemProviderErrorDomain, null)
Code sample
await _imagePicker.pickImage(source: camera ? ImageSource.camera : ImageSource.gallery).then((image) {
debugPrint('TSTS image: ${image?.path}');
if (image != null) {
widget.onImageSelected(image);
}
}).catchError((e) {
debugPrint('TSTS e: ${e.toString()}');
});
Screenshots or Video
No response
Logs
No response
Flutter Doctor output
[✓] Flutter (Channel stable, 3.16.3, on macOS 14.2 23C64 darwin-arm64, locale
en-AE)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.85.1)
[✓] VS Code (version 1.85.1)
[✓] Connected device (3 available)
! Error: Browsing on the local area network for iPhone. Ensure the device is
unlocked and attached with a cable or associated with the same local area
network as this Mac.
The device must be opted into Developer Mode to connect wirelessly. (code
-27)
! Error: Browsing on the local area network for Alex el. Ensure the device
is unlocked and attached with a cable or associated with the same local
area network as this Mac.
The device must be opted into Developer Mode to connect wirelessly. (code
-27)
[✓] Network resources
• No issues found!

@emadeddintabbaa I see this was closed as completed?  Was it fixed, or did you figure out a work around?  I'm running into a similar issue

Yes, it is working.
On Fri, Jan 5, 2024 at 12:00 AM Mylon Blueford @.***>
wrote:

@emadeddintabbaa https://github.com/emadeddintabbaa I see this was
closed as completed? Was it fixed, or did you figure out a work around? I'm
running into a similar issue
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/140601#issuecomment-1877685088,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3WL25XTAK5YKX2EKZPDGBDYM4C6VAVCNFSM6AAAAABBCH5DNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGY4DKMBYHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@emadeddintabbaa was there anything you had to do to get it working?

On Fri, Jan 5, 2024 at 12:21 AM Mylon Blueford @.***>
wrote:

@emadeddintabbaa https://github.com/emadeddintabbaa was there anything
you had to do to get it working?
—
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/140601#issuecomment-1877710734,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3WL25UAGVHS7ZD3SLWQIZTYM4FL7AVCNFSM6AAAAABBCH5DNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXG4YTANZTGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

No it was an issue with IOS version I think, it was not related to flutter

@emadeddintabbaa ahh ok, thanks!


Optional parallelization of cosine similarity computation (Issue #95)

The PR adds parallel_cosine_similarity to find_duplicates which is set to True by default so that it won't break any existing code.
I have a really huge dataset and not enough RAM to use multiprocessing so introducing the ability to disable parallel computation of cosine similarity was the only way to use the package.

Oh, I haven't changed the the tests...

Related to #95

@EduardKononov Do you intend to work on this?

@tanujjain yes, I do, but later because I have no free time at all now. The deadline is mid-January. Hope sooner

Unfortunately, I still have no time to do that. I'm here just to notify that I remember but have no opportunity

Unfortunately, I still have no time to do that. I'm here just to notify that I remember but have no opportunity

@EduardKononov Thanks for the info. Do you think you'll have time in the following weeks? Otherwise, I may have to start working on it sometime in February(2nd/3rd week).

@EduardKononov Thanks for the info. Do you think you'll have time in the following weeks? Otherwise, I may have to start working on it sometime in February(2nd/3rd week).

@tanujjain no, I don't think so

@tanujjain no, I don't think so

Closing since this is being tackled in #185


Is upgrading a release installed from local chart files supported?

I am trying to upgrade some values in a helm release installed before by this command: helm upgrade -i --create-namespace -n foo barRelease ./chart
I tried UpgradeChart method in this package, but it seems that a chart name like repo/chart which represents a chart in some repo has to be provided.
I read some code of this method and find it invoked GetChart method indeed.
So I wonder If I am using this package the right way and if this package supports my case of upgrading release values of local charts?

/cc @zvonkok


Initilizing PoolVector2Array with Vector3 causes crash with no error message

Godot version:

6312f18
Issue description:

I had mistakenly tried to initialize with wrong type. I would of expected an error message telling me so, but none was given. When running this understandably crashes, but would be nice to show  user why.
var points_relative = PoolVector2Array([
			Vector3(point.x + 1, point.y),
			Vector3(point.x - 1, point.y),
			Vector3(point.x, point.y + 1),
			Vector3(point.x, point.y - 1)])

Steps to reproduce:
Add above in script

At runtime there is now an error printing saying non-existent vector 3 constructor. Would be nice to have this show up in editor before running, but that is beyond scope of this issue.


Enhanced Clipping and Rendered Visuals Tracking in ServerCompositionVisual

What does the pull request do?
This PR enhances the clipping calculation within the ServerCompositionVisual by taking Clip.Bounds into account. The primary goal is to ensure that visuals, which are not within a dirty rect, are not re-rendered when different ClipToBounds and Clip geometry parameters are set.
What is the current behavior?
Currently, ServerCompositionVisual.Render method do nothing if boundaries of the visual do not intersect with DirtyRect. This approach effectively minimizes the areas of the scene redrawn, especially when a single element is invalidated. However, this optimization is only effective when ClipToBounds=true. While having ClipToBounds=false but setting an explicit Clip is valid, it's not considered in the current implementation.
What is the updated/expected behavior with this PR?
After this PR, the ServerCompositionVisual will also consider changes to the Clip property, allowing it to recalculate when the clip is altered. This ensures accurate rendering even when ClipToBounds=false but an explicit Clip is set.
How was the solution implemented (if it's not obvious)?

Clip.Bounds was considered in the clipping calculation within ServerCompositionVisual.
Added unit tests under CompositorInvalidationClippingTests to verify the correct rendering of visuals not in the dirty rect with different ClipToBounds and Clip geometry parameters.
For test purpuses a counter for rendered visuals in ServerCompositionVisual was introduced.

Checklist

[x] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
Obsoletions / Deprecations
Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0038492-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Please address that "remove public" comment. Otherwize LGTM

@dotnet-policy-service agree company="JetBrains GmbH"

You can test this PR using the following package version. 11.0.999-cibuild0038528-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0038530-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]


update rebar locks for bookshelf, bifrost, and erchef

Pulls in mochiweb from the "mochi" org via updated opscoderl_wm.  Also updating other deps for latest fixes and enhancements, since it's been a while.
Replaces https://github.com/chef/chef-server/pull/585
ChangeLog-Entry: [oc_erchef] [bookshelf] [oc_bifrost] pull in the latest
webmachine and mochiweb dependencies to resolve an issue which could
lead to requests being rejected under sudden load.
ping @chef/lob

:+1: iff pedant passes.  It is a lot of dependency change but the majority of these have been safe-to-upgrade in the past.

Yeah, we did have a clean pedant run.  For future releases, I'd like to make updating rebar locks the first thing we do after we cut a new release - sot hat we have more time to run with them -  instead of the last thing we do before we cut a release.

@marcparadise :+1: on that idea.  We should add it to the release process.  Integrate as early as possible with a set up update deps.


Relative path support for bufferBaseFilename property when set on config?

May I check if the bufferBaseFilename supports relative paths?
When configured in the app.config  such as:
<add key="serilog:write-to:Seq.bufferBaseFilename" value="~/app_data/seq_buffer" />
Seq writes on this system to \windows\system32\inetsrv~\app_data
Ideally it would of written to the relative path of the web app.

Apologies, this is possibly more relevant to serilog-settings-appsettings


make currency code show after value in formatter->asCurency()

What steps will reproduce the problem?
in config I have
'formatter' => [
	'currencyCode' => 'AED',
],

then I use
\Yii::$app->getFormatter()->asCurrency(100);
I get AED100.00
How can I specify the pattern of the output like I want to get 100.00 AED

It depends on locale you're using. Either set different locale to the component or change application language.


investigate PubTator as resource for NGD calculation

In https://github.com/biothings/BioThings_Explorer_TRAPI/issues/326, we implemented an NGD scoring system based on semmeddb. As a low priority item, we could also investigate creating an NGD service based on Pubtator, which presumably has significantly better performance on NER.  Pubtator files are automatically updated for download at https://ftp.ncbi.nlm.nih.gov/pub/lu/PubTatorCentral/. We'd want to confirm that no one else in Translator had already done this.

TODO: Consider implementing NGD using Painless (scripting on ES side)


node-ip kubelet flag is not working as expected

Environmental Info:
K3s Version:  v1.23.9+rke2r1
Node(s) CPU architecture, OS, and Version:
Linux ip-172-29-204-225 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Cluster Configuration:
3 servers 3 workers
k3s config:
egress-selector-mode: disabled
node-name: ip-xxx-xx-xxx-xxx.eu-central-1.compute.internal
flannel-backend: none
disable-cloud-controller: true
node-ip: xxx.xx.xxx.xxx
node-external-ip: xxx.xx.xxx.xxx
kube-apiserver-arg:
- "service-account-key-file=/etc/rancher/service-account.pub"
- "service-account-issuer=https://xxxxxx.s3.eu-central-1.amazonaws.com"
- "service-account-signing-key-file=/etc/rancher/service-account.key"
- "enable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota,NodeRestriction,Priority,TaintNodesByCondition,PersistentVolumeClaimResize,PodSecurityPolicy"
- "audit-log-path=/var/log/k8s-audit/audit.log"
- "audit-policy-file=/etc/rancher/k3s/audit_policy.yaml"
- "audit-log-maxage=90"
- "audit-log-maxbackup=10"
- "audit-log-maxsize=500"
kube-controller-arg:
- "service-account-private-key-file=/etc/rancher/service-account.key"
kubelet-arg:
- "cloud-provider=external"
- "provider-id=aws:///eu-central-1c/i-xxxx"
- "node-ip=xxx.xx.xxx.xxx"
- "max-pods=60"

tls-san:
- "int-xxxxxxxxxx.elb.eu-central-1.amazonaws.com"
no-deploy:
- "traefik"
- "metrics-server"
- "servicelb"

CNI plugin: aws eni cni
CCM: cloud-provider-aws
Describe the bug:
When using aws vpc cni k3s nodes gets all pods IPs in to node status.addresses, example:
 status:
    addresses:
    - address: xxx.xxx.xxx.xxx              <--- actual node IP
      type: InternalIP
    - address: zzz.zz.zzz.zzz              <--- some POD IP
      type: InternalIP
    - address: zzz.zz.zzz.zzz              <--- some POD IP
      type: InternalIP
    - address: zzz.zz.zzz.zzz              <--- some POD IP
      type: InternalIP
    - address: zzz.zz.zzz.zzz              <--- some POD IP
      type: InternalIP
    - address: yyy.yy.yyy.yyy              <--- some POD IP
      type: InternalIP
    - address: ip-xxx-xxx-xxx-xxx.eu-central-1.compute.internal
      type: InternalDNS
    - address: ip-xxx-xxx-xxx-xxx.eu-central-1.compute.internal
      type: Hostname

and this sometime causing weird issues like this:
Error from server: Get "https://xxxxxxxxxx:10250/containerLogs/my-deployment/my-deployment-75b555c4b9-5fp2v/my-pod": x509: certificate is valid for <IP_ADDRESS>, xxx.xx.xxx.xxx, xxx.xx.xxx.xxx, not yyy.yy.yyy.yyy

where xxx.xx.xxx.xxx is the actual node IP and yyy.yy.yyy.yyy is some pod IP running on the same node and listed in node status.addresses
Usually passing --node-ip  flag to the kubelet makes sure that the only InternalIP node will have in status.addresses is going to be that IP passed with --node-ip, but that does not work for k3s. I've tried passing it via kubelet-arg: as well as node-ip and node-external-ip in my k3s config but every node still get all pods IPs running on the same now listed in node status.addresses
Steps To Reproduce:
Installed K3s with aws vpc CNI, configure kubelet with node-ip and describe node to see node status.addresses
Expected behavior:
Once kubelet flag --node-ip is supposed to set only one internalIP for the node addresses to the value passed via flag.
Actual behavior:
kubelet flag --node-ip seems ignored and with AWS VPC CNI node gets all pods IPs running on that node in node status.addresses
Additional context / logs:

I'm not sure how this is something that K3s is doing. The node status address fields are set by the cloud provider, and you've disabled the k3s embedded CCM in favor of using the AWS CCM and VPC CNI.

@brandond thanks for looking in to this. I thought there is a chance that that flag just not passed somehow to kubelet. But I think you are right, there is a high chance that aws ccm is causing this.

The issue was in the k8s.io/cloud-provider and kubelet which was fixed in https://github.com/kubernetes/kubernetes/pull/107750/files
So after upgrade to k3s 1.24.4 and AWS ccm to 1.24.0 the issue is gone, thanks for the pointer @brandond ! 🙇🏽


Add transaction table

The table schema is provided here
CREATE TABLE IF NOT EXISTS spacebox.transaction
(
    `timestamp` DATETIME,
    `height` Int64,
    `txhash` String
    `codespace` String
    `code` int64
    `raw_log` String, // as is
    `logs` String, // correct JSON  array string
    `info` String,
    `gas_wanted`   Int64,
    `gas_used`     Int64,
    `tx` String, // correct JSON string
    `events` String // correct JSON  array string
    `signer` String
) ENGINE = ReplacingMergeTree()
      ORDER BY (`timestamp`, `height`, `txhash`, `signer`);

All fields from the tx_response
events from tx -> events
signer from tx -> auth_info -> signer_infos -> public_key -> key converted in bech32 like regular cosmos address

@malekvictor
Field height, gas_used and gas_wanted are always 0


fix cursor pointer for Kaapi theme

A small css fix to have a change of cursor on the clickable buttons.
For Kaapi theme of @Jom97

I don't really like this since i think there's enough visual feedback when hovering over clickable buttons. And i don't think it looks good when you're hovering over the player-controls and the cursor changes into a pointer over each control element.


Cannot build SNAPSHOT.jar

Describe the bug
I did all the configuration and building steps on the wiki, but the IntelliJ IDEA just gave me a "DEVBUILD.jar", a single jar file, and it wouldn't run because it doesn't have a main class.
To Reproduce
Steps to reproduce the behavior:

Clone repo
Start IntelliJ IDEA
Press green start button on the top menu line of the program right next to the button that says main after editing configuration to build a jar, with the command "clean install" as the wiki suggests
Check the target folder

Expected behavior
Two .jar files, in which one of them would be named SNAPSHOT.jar, and it would start the engine.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
JDK: AdoptOpenJDK11

Additional context
As shown in the screenshot, it also opens up the game screen. I'm not sure if that is supposed to happen or not.

To run a jar file in the command line, you have to type use "java -jar pathtojarfile". It looks like you forgot to add the -jar flag in your command. Also, the game screen is supposed to come up as you've shown in your screenshot.


ibtool: impure-symlink-style Darwin package

Motivation for this change
Adding an impure derivation for ibtool. My current motivation for doing this is packaging MoltenVK.
There are a few other impure Darwin derivations that work by making symlinks to system libraries/tools, but I'm sure I've broken some convention or something here. @copumpkin, I'm curious about the right way to do this.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

:-1: on this. Ibtool doesn't come with macOS by default - you need to install xcode for this to work.
If you really need ibtool for a project, you can use ${darwin.xcode}/Contents/Developer/usr/bin/ibtool.

Ah, thanks, I’ll give that a go. That could obviate the need for this.

Agree with @matthewbauer. If the "pure" one works, that'd make me happier than this. The only other idea I have around ibtool (which I think we all really want in some form or other) is something like https://github.com/davidquesada/ibtool or hacking at https://github.com/Microsoft/WinObjC, neither of which are super good fits.

Closing for now. Feel free to reopen if you think this is still relevant.


Request Headers section in README seems misleading

Perhaps it is related to #1770.
So the README says that an example below will be  normalized:
curl -H "secret_PassWord: swordfish" ...

But actually - it won't. If header name contains an underscore - in env it will remain as is and without HTTP_ prefix, and it won't appear in headers helper at all.

Please fix?

I am adding some integration specs, not sure whether we want to merge them, but they do demonstrate a different behaviour.
Test here: https://github.com/ruby-grape/grape/pull/1927

Interesting, I have such issues in a Rails app, with Grape API mounted in routes.rb. And code like env.to_json does not even work there, it ends up with an infinite loop.
Perhaps that's some new activesupport-5.2.4 bug though.
However, I can try env.keys instead, and my initial issue is still reproducing. Perhaps there's something else is wrong with the project. I gotta dive deeper into it to figure it out.


Bug in the Builder < Best Exp tab

When "Auto Select Current Submarine" is checked and using the "Best Exp" menu if two submarines are the same level, for example rank 89, then when switching from one sub to the next in-game the suggested destinations will give the message "No route found, check speed and range ... ". This message will persist when selecting the first sub again or any other submarine of the same level, including submarines on different worlds.
Thus far the only way I have found to work around this bug is by selecting another submarine map in the Best Exp dropdown menu, letting the destinations load, and the switching back to the desired map.

If you still have this issue happening after the update, pls comment here

Bug appears to still be present. Updated: Bug can also be recreated by using the aforementioned settings and clicking on a submarine via in-game, backing to the sub selection, and clicking the same submarine again.


ExpirationDate default

The default-ExpirationDate of 6 months from now can sometimes exceed the 180 days limit on SPO and result in the error
The specified expiration date is invalid. Should be greater than today and within 6 months
I needed to supply the expiration date with (GetDate).AddDays(180).ToString("yyyy-MM-ddTHH:mm:ssZ") to avoid getting the error.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 746cfa49-4283-ca23-368b-ad2b85b655bb
Version Independent ID: f52226dd-12c8-b2d1-d5e1-2c44eb9f6c09
Content: Add-PnPWebhookSubscription (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Add-PnPWebhookSubscription.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@AngryVirginian Thank you for this feedback
We want to make sure your PnP issue is handled appropriately.
We have a separate repo for the PnP PowerShell issues. We want your issue to get the proper attention it deserves.
Please open your issue in this repo: https://github.com/SharePoint/PnP-PowerShell
I am going to close this issue so that we can track to correct one in the PnP PowerShell repo.

Looks the default Expiration on the cmdlet was updated to 6 months minus 72 hours without updating the docs.


nacos 1.1.3 config data not exist

我们鼓励使用英文，如果不能直接使用，可以使用翻译软件，您仍旧可以保留中文原文。
We recommend using English. If you are non-native English speaker, you can use the translation software.
Which Component
see nacos issue 1818：https://github.com/alibaba/nacos/issues/1818
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
e.g.  MacOS  、Java8 、 Version 0.2.1.RELEASE

Currently, it is rather rigid, and the subsequent nacos can support the optimization of suffix reading into dynamic

I've done compatibility, and it's going to be dynamic

👍


Fix leaking process in hostport proxy

...also allow non-bash shell scripts.
Fixes #10494 and #10496
I verified the boilerplate against invalid files and it still flags them but now allows #!/bin/sh to pass.
low risk.

Can I get a review on this?

@ArtfulCoder for review

ping @ArtfulCoder

I somehow missed this. reviewing now. sorry for the delay.


Prevent spurious animation effects for PM unread counts

We have an animation effect when the count for PMs changes.  It's mostly driven by this function: unread_ui.animate_private_message_changes.
The problem with the function is that it doesn't correctly detect when the PM count has changed.  It naively uses a single global variable to track the "last" unread count, which doesn't work when you have multiple PMs.
We can fix this by tracking PM counts per conversation, or just look directly into the HTML to see if it's changed.  The latter is probably better, but either solution would work.

@showell can I try to solve this issue?

I fixed this in a pending PR by just removing the animation, with buy-in from Tim and Rishi.


Add npmignore

Turns out that if you do not include an .npmignore file, npm will use the .gitignore (if present) which means that npm was ignoring the build directory.
see: https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package

Oh wow!  Thanks, I was banging my head against this.


Scroll fix

Codecov Report

Merging #906 (bf44b6e) into master (528c2dd) will increase coverage by 0.00%.
The diff coverage is 89.83%.

@@           Coverage Diff           @@
##           master     #906   +/-   ##
=======================================
  Coverage   74.07%   74.08%
=======================================
  Files         133      133
  Lines       12729    12775   +46
=======================================
+ Hits         9429     9464   +35
- Misses       3300     3311   +11

Impacted Files
Coverage Δ

assemblyline/datastore/store.py
81.81% <75.00%> (-0.91%)
:arrow_down:

assemblyline/datastore/collection.py
62.18% <91.42%> (+0.28%)
:arrow_up:

assemblyline/datastore/exceptions.py
100.00% <100.00%> (ø)

assemblyline/odm/random_data/__init__.py
88.67% <100.00%> (+0.33%)
:arrow_up:

assemblyline/odm/models/user.py
85.10% <0.00%> (-14.90%)
:arrow_down:

assemblyline/odm/randomizer.py
93.96% <0.00%> (-1.30%)
:arrow_down:

assemblyline/odm/models/config.py
99.55% <0.00%> (+<0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support for MODULE.bazel

Is anyone working on this?

Not an active priority for us right now but we are always open to community contributions 😀
otherwise, ill happily make this ticket into a feature request, i just can't give any timeframes on its completion.

I tried to do this myself; however, I haven't used maven for almost 20 years, and I'm just not in that world at all. There's a lot of dependencies, and I'm stuck.
Please make this into a feature request.

Looking ahead, I want to let you know that we're shifting our focus towards protovalidate. Your understanding and continued support mean a lot to us. Feel free to reach out if you have any questions or feedback as we make this transition.

As explained in the README, this project is in maintenance mode. We recommend upgrading to protovalidate.
I'm going to go ahead and close this issue, but feel free to open one against protovalidate if needed. Thanks!


[wip] v3

This is the Swarm migration and integration branch.  It also includes the initial work on the UI refresh.
This will close #438.
It is not yet ready for merge

:+1: