v1.3.0 fails to build on Fedora 35

From https://bugzilla.redhat.com/show_bug.cgi?id=1987402 / https://koji.fedoraproject.org/koji/taskinfo?taskID=72330774
[ 48%] Building CXX object sandbox/CMakeFiles/sandbox.dir/sandbox.cpp.o
cd /builddir/build/BUILD/cereal-1.3.0/redhat-linux-build/sandbox && /usr/bin/g++  -I/builddir/build/BUILD/cereal-1.3.0/./include -I/builddir/build/BUILD/cereal-1.3.0/sandbox/sandbox_shared_lib -Wall -g -Wextra -Wshadow -pedantic -Wold-style-cast -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -std=gnu++11 -MD -MT sandbox/CMakeFiles/sandbox.dir/sandbox.cpp.o -MF CMakeFiles/sandbox.dir/sandbox.cpp.o.d -o CMakeFiles/sandbox.dir/sandbox.cpp.o -c /builddir/build/BUILD/cereal-1.3.0/sandbox/sandbox.cpp
In file included from /builddir/build/BUILD/cereal-1.3.0/unittests/common.hpp:59,
                 from /builddir/build/BUILD/cereal-1.3.0/unittests/pair.hpp:29,
                 from /builddir/build/BUILD/cereal-1.3.0/unittests/pair.cpp:28:
/builddir/build/BUILD/cereal-1.3.0/unittests/doctest.h:4021:47: error: size of array 'altStackMem' is not an integral constant-expression
 4021 |         static char             altStackMem[4 * SIGSTKSZ];
      |

Build here: build.log.txt

Any update?

Updated the bundled version of doctree.h to a recent version helped (see #714).

Fixed in v1.3.1

Fixed in v1.3.1

Hmm .. last release it is 1.3.2 released almost 10 months ago.

Fixed in v1.3.1

Hmm .. last release it is 1.3.2 released almost 10 months ago.

Yup and the issue was actually fixed in #716 2 years ago.

OK. Just reenabled in 1.3.2 test suite execution on packaging and looks like everything is OK now.
Thx 👍


php module api version discrepancy

Bug Report

Q
A

PHP version
8

SAP NW RFC SDK version
7.5

Extension version/git ref
php_sapnwrfc-2.0.0-beta2-7.4.26-vc15-nts-x64

Summary
php -m
PHP Startup: sapnwrfc: Unable to initialize module
Module compiled with module API=20200930
PHP    compiled with module API=20210902
These options need to match

Current behavior

How to reproduce

Expected behavior

You cannot use a pre-built DDL for PHP 7.4 on PHP 8.
/close


Remove libcurl_vendor

Instead rely on system provided version.
@clalancette I went ahead and did this anyways. I'll trigger CI on all platforms to see where we stand.

Linux
Linux-aarch64
macOS
Windows

I don't have a good solution for Windows (or the time to iterate on this).

libcurl_vendor should do the appropriate thing if you already have the curl development libraries installed.  That is, on Linux, it is just a simple wrapper around the real libraries.  If that is not working for you, then something else has gone wrong.  Please open a separate issue with details on your platform, what you are trying, and the error output you are getting.

Ok will do that


Verify lineNumber

Verify that the lineNumber provided is not past the end of the buffer provided.

Merge at will


NuGet package

Are there any plans to make this available as a NuGet package?

If will need to be converted to project.json and then I can publish.  Is
that something you'd like to do as part of a PR?
On 16 September 2016 at 09:03, Dave Lewis<EMAIL_ADDRESS>wrote:

Are there any plans to make this available as a NuGet package?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jchannon/Nancy.Siren/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGapggppTtQOSIWvgH-5QKmni9HZcAIks5qqk1jgaJpZM4J-r4M
.

Yeah I can do that. Will have a look over the weekend.


Could not find module ‘IHaskell.IPython.Stdin’

I am trying to install ihaskell from source using the sandbox instructions provided in the Readme.  When I run the cabal install step I get the following error.
src/Main.hs:36:18:
    Could not find module ‘IHaskell.IPython.Stdin’
    Perhaps you meant
      IHaskell.IPython.Types (from ipython-kernel-<IP_ADDRESS>)
      IHaskell.IPython.Kernel (from ipython-kernel-<IP_ADDRESS>)
      IHaskell.IPython.ZeroMQ (from ipython-kernel-<IP_ADDRESS>)
    Use -v to see a list of the files searched for.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/11834789-could-not-find-module-ihaskell-ipython-stdin?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F332399&utm_medium=issues&utm_source=github).

Make sure to install IHaskell from source and not from Hackage; Hackage is outdated again. (Sorry, should fix this.) Install via cabal install instead of cabal install IHaskell.

Thanks - that seems to work for ihaskell but I am still struggling with installing the display components.
So I am assuming the instructions should read:
cd IHaskell
cabal sandbox init
cabal sandbox add-source ihaskell-display/* ghc-parser ipython-kernel
cabal install
cabal install $(basename ihaskell-display/*)

but the last line does not seem to successfully install the display packages, instead it gives me:
basename: extra operand ‘ihaskell-display/ihaskell-blaze’

Try installing  them via
cabal install ihaskell-display/*

For some reason that seems to get me back to the original issue.  It tries to re-install ihaskell because:
ihaskell-<IP_ADDRESS> (reinstall) changes: utf8-string-1 -> 0.3.8
and then fails with the error:
Could not find module ‘IHaskell.IPython.Stdin’
BTW. I also get an error:
Failed to install magic-1.1
Build log ( /Users/rrottier/Haskell/IHaskell/.cabal-sandbox/logs/magic-1.1.log ):
Configuring magic-1.1...
Building magic-1.1...
Preprocessing library magic-1.1...
Data.hsc:19:10: fatal error: 'magic.h' file not found
#include "magic.h"
         ^
1 error generated.

I have installed libmagic using homebrew as per the .sh file.

Try to install both of them at once:
cabal install . ihaskell-display/*

Yeah, the sandbox instructions aren't well updated :( I usually install everything with ./build.sh.
You may need to use --extra-lib-dirs and --extra-include-dirs for cabal; something like this:
cabal install . ihaskell-display/* --extra-lib-dirs=`brew --prefix libmagic`/lib --extra-include-dirs=`brew --prefix libmagic`/include

Works perfectly.  Thanks for the help.   Maybe worth updating the readme.
:-)

readme updated. Thanks.


Dates become undefined if schema validation produces error in form action

Description
In both of these form submissions below, I had selected a date. If the schema produces an error in the form action, the date becomes undefined. Other fields do not have this issue as far as I can tell. Only dates. This means that such an error would require the user to re-enter the dates every time.
I also do not think this is a Valibot issue, as performing client-side validation does not create this side effect.

MRE: https://stackblitz.com/edit/superforms-dates-issue?file=src%2Froutes%2F%2Bpage.svelte

Thank you for reporting, will be fixed in the next release. And thank you very much for sponsoring! :)

Should be fixed now with 2.3.0, can you confirm that it is?

Yep! It works. Thank you :)


FutureWarning raised by browser.cookies.delete()

Pytest-Splinter's browser fixture deletes cookies by calling browser.cookies.delete():
https://github.com/pytest-dev/pytest-splinter/blob/47141cd477254abcb2a15cdf7e72bdb97da29f95/pytest_splinter/plugin.py#L609-L615
This is causing a FutureWarning under splinter 0.19:
…/splinter/driver/webdriver/cookie_manager.py:24: FutureWarning: Deleting all cookies via CookieManager.delete() with no arguments has been deprecated. use CookieManager.delete_all().

Splinter's documentation has been updated to recommend calling delete_all(): https://splinter.readthedocs.io/en/latest/cookies.html#delete-all-cookies

I missed the existing open PR in #172.


Prepending API endpoints involving user to prevent mismatches with future endpoints

We will be adding new API endpoints for multi-cluster support. These new API endpoints will follow the pattern /computes/{..}. However many existing API endpoints follow the pattern /{user}/{..}. Thus, there is a possible issue of incorrect api resolution when a {user} name is computes. To clean up the endpoints and to avoid such cases, endpoints containing /{user}/ are prepended with a static /users/. This will ensure correct end-point resolution.

Codecov Report

Merging #157 (6197494) into main (f8b3c45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   21.29%   21.29%
=======================================
  Files          34       34
  Lines        1503     1503
=======================================
  Hits          320      320
  Misses       1173     1173
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b3c45...6197494. Read the comment docs.


pull request for e2e test at 02/03/2017 09:56:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


RLS/CI: update GEOS to 3.11.0 for wheels

For the wheels for 2.0 we can start using the latest GEOS 3.11.0 release (for 1.8.x, I would keep GEOS 3.10.x, so was not planning to backport this).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.328%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2077

Relevant Lines:
2463

💛  - Coveralls


Add to PMACS

Always ssh with -Y
immediately do xbash
get standard env with source /project/bbl_projects/apps/default_modules.sh

@a3sha2

@TinasheMTapera  don't forget to add to tutorial
merci!!


upload the helm chart to a helm repo

It is possible to consume the helm chart from the git repo, but it would be way easier if it would be in a helm repository.

Hi , you can try this.
helm repo add pvc-exporter https://kais271.github.io/pvc-exporter/helm3/charts/

can you also include the namespace change? :)

it is working

I have merged your changes.  And packaged a new charts as v0.1.1-fix

works great! thanks!


Rogue Feature That Automatically Converts Plain Text Emails to HTML-look Should Not Be Happening

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
(latest version on Google Play as of 21/7/2024)
Where did you get the app from?
Google Play
Android version
13 with Lineage OS
Device model
No response
Steps to reproduce
Open a received email message which has plain text with at least one single line containing only equal signs (=) on K-9 Mail. The email will have a HTML look with a line separator instead of multiple equal signs, which suggests that HTML instead of plain text  was used on that email.
Expected behavior
Plain text emails should only have characters displayed. This design will cause misunderstanding between the sender and recipient.
Actual behavior
A line separator is displayed for plain text emails having only euqal signs on at least one line in the context.
Logs
NOTICE: This bug report was submitted using the new GitHub issue form, and the tag "unconfirmed" cannot be edited by the poster. This has been confirmed as a bug or an intentionally-designed rogue feature.

This is done intentionally. See https://github.com/thunderbird/thunderbird-android/blob/b67649dd4201949a86cfe87c425e468317a870c6/legacy/core/src/main/java/com/fsck/k9/message/html/DividerReplacer.kt
The app is converting a plain text body to HTML before displaying it. During that conversion quite a few changes are made, e.g. quote characters are removed and quoted text is turned into (nested) block quotes. That's done to improve the usability of plain text messages. While this behavior may have resulted in a misunderstanding in your case, it is appreciated by a lot of users.
I don't see us adding a setting to turn off this behavior. If you need an email client that displays plain text bodies as-is, K-9 Mail is probably not the right choice for you.


Add ability for bot to add new team members to all rooms

As part of the onboarding, have this bot pull people into all the rooms.

https://power-pack.io/ may be able to handle this

@brondsem I guess this doesn't solve the "Add new person to the team" problem, but once they're in the team, they're added to all session rooms.  I can reopen this issue if you'd like that to be part of this one.


add postgres sample

Aww thanks for doing this. I'm not going to accept this PR because this is actually a companion repo to my Complete Intro to Databases course so I need the samples to match the curriculum but this is great code. Hope it was fun to write! Thanks again.


don't resize embeddings to multiples of 32x by default

resizing the embeddings to larger than the actual number of tokens causes problems with llama.cpp downstream. let's not enable this by default for safety.

YES! I had to modify downstream code for this 😂

While on this topic, I was wondering whether to consider using the "smart resize" code floating around in fast chat and other repos.


No API reference?

Describe the issue
I really appreciate complete configuration examples, but I'm finding them difficult to understand without an API reference that explains each directive individually.
Configuration
Paste full Caddyfile below:
N/A - don't have one yet, because I'm struggling to understand use to use caddy-auth-portal for my use-case in the first place

Version Information
http.authentication.hashes.scrypt v2.4.5
http.authentication.providers.http_basic v2.4.5
http.handlers.authentication v2.4.5
http.authentication.providers.jwt v0.5.0
http.handlers.authp v1.4.24

Expected behavior
I can find an official API reference.
Additional context
I want to have the authentication portal on a dedicated subdomain and authenticate for other subdomains, but I don't understand the individual directives being used in e.g. #94 well enough to implement it.

@sbrl , the majority of it should be in README.md files in “caddy-auth-portal” and “caddy-auth-jwt” plugins.
Also, i don’t recognize the jwt version you have in your module output.

@greenpau, hmmm, I see. I've read both of those extensively, but still have a number of questions.
To take just 1 example from many, where can redir be used and in what contexts?
Another key point on #94 is e.g. auth.example.com, why is there both a n auth_portal`` definition and an route /* { import my-auth ...` definition? Isn't the second one redundant?

Also, I don’t recognize the jwt version you have in your module output.

Ah, thanks for that. Looks like I got the wrong github repo in my xcaddy build. Fixed:
http.authentication.hashes.bcrypt v2.4.5
http.authentication.hashes.scrypt v2.4.5
http.authentication.providers.http_basic v2.4.5
http.handlers.authentication v2.4.5
http.authentication.providers.jwt v1.3.16
http.handlers.authp v1.4.24

To take just 1 example from many, where can redir be used and in what contexts?

the “redir” is caddy directive, not auth portal specific. You could get help in Caddy community forum and reading caddy docs. This directive simply tells to redirect users to another page.
additionally, each “route” directive handles request in a certain way. Importantly, if two directives match the same requested path, the first one mentioned in the config wins. The other will be disregarded.
How about you try your best to construct caddyfile based on your current understanding of how things work and paste it here? Then, I will try helping you getting to a working config.

Oh I see. I couldn't tell if it was specific to caddy-auth-portal/caddy-auth-jwt or whether it was a generic caddy directive.
Ah, ok - got it.
Sure thing. Here's my first attempt:
(auth) {
	jwt {
		primary yes
		trusted_tokens {
			static_secret {
				token_name {$JWT_TOKEN_NAME}
				token_secret {$JWT_TOKEN_SECRET}
			}
			set auth_url https://auth.mooncarrot.space/
			allow roles superadmin authp/admin authp/user
		}
	}
}

auth.mooncarrot.space {
	auth_portal {
		cookie_domain mooncarrot.space
		ui {
			theme basic
		}
		jwt {
			token_name {$JWT_TOKEN_NAME}
			token_secret {$JWT_TOKEN_SECRET}
		}
		backend local /etc/caddy/users_db.json local
	}
}

*.mooncarrot.space {
	import auth

	reverse_proxy https://fabio.mooncarrot.space:443 {
		#header_down strict-transport-security	"max-age=31536000"
	}
}

....but I get this error:
run: adapting config using caddyfile: parsing caddyfile tokens for 'route': /etc/caddy/Caddyfile:54 - Error during parsing: parsing caddyfile tokens for 'jwt': /etc/caddy/Caddyfile:26 - Error during parsing: unsupported root directive: trusted_tokens

....yet in #94 trusted_tokens seems to be a thing?
What I'm trying to accomplish here is to use Caddy as a generic reverse proxy to my cluster which authenticates all users before they access any backend services. Then I can port forward to Caddy on my router instead of Fabio (which does support http basic authentication, but caddy-auth-portal is significantly more sophisticated).

@sbrl , try this:
auth.mooncarrot.space {
  route {
    authp {
      backend local /etc/caddy/users_db.json local
      cookie domain mooncarrot.space
      ui {
        links {
          "My Website" https://www.mooncarrot.space/ icon "las la-star"
          "My Identity" "/whoami" icon "las la-star"
        }
      }
      transform user {
        match origin local
        action add role authp/user
      }
    }
  }
}

*.mooncarrot.space {
    jwt {
      primary yes
      allow roles authp/admin authp/user
      set auth url https://auth.mooncarrot.space
    }
    reverse_proxy https://fabio.mooncarrot.space:443
}

@sbrl , updated the above example with crypto key directives. They are optional if you are running a single instance of your server.

Hey, thanks @greenpau! I added a route there to avoid an error about things being unordered, and also moved the user db into a subdirectory that I've chowned to the caddy user & group:
(auth) {
	jwt {
		primary yes
		allow roles authp/admin authp/user
		set auth url https://auth.mooncarrot.space
		#crypto key verify a138a4f3-830e-42f4-bb55-27fd3943c368
    }
}

auth.mooncarrot.space {
	route {
		authp {
			backend local /etc/caddy/data/users_db.json local
			cookie domain mooncarrot.space
			# crypto key sign-verify a138a4f3-830e-42f4-bb55-27fd3943c368
			ui {
				links {
					"mooncarrot.space" https://mooncarrot.space/ icon "las la-star"
					"Identity" "/whoami" icon "las la-star"
				}
			}
			transform user {
				match origin local
				action add role authp/user
			}
		}
	}
}

*.mooncarrot.space {
	import auth

	route {
		import auth
		reverse_proxy https://fabio.mooncarrot.space:443
	}
}

.....however I'm met with an error about a read-only filesystem:
run: loading initial config: loading new config: loading http app module: provision http: server srv0: setting up route handlers: route 1: loading handler modules: position 0: loading module 'subroute': provision http.handlers.subroute: setting up subroutes: route 0: loading handler modules: position 0: loading module 'subroute': provision http.handlers.subroute: setting up subroutes: route 0: loading handler modules: position 0: loading module 'subroute': provision http.handlers.subroute: setting up subroutes: route 0: loading handler modules: position 0: loading module 'authp': provision http.handlers.authp: backend configuration for "default" instance in "portal-default-000001" context failed: failed initializing database at "/etc/caddy/data/users_db.json": failed database commit to "/etc/caddy/data/users_db.json": open /etc/caddy/data/users_db.json: read-only file system

...yet I can write to the directory as the caddy user just fine:
$ sudo -u caddy touch /etc/caddy/data/testfile
$ ls /etc/caddy/data/testfile
-rw-rw-r-- 1 caddy caddy 0 Sep 26 14:27 testfile

@sbrl , please use the template I posted. Avoid the “import” statement, unless you understand what it means.

@sbrl regarding the error
failed database commit to "/etc/caddy/data/users_db.json": open /etc/caddy/data/users_db.json: read-only file system
It looks like the process cannot write to the provided path.

Removing the import has no effect (I thought it was a way to have reusable snippets in a caddyfile? *.mooncarrot.space is not the only domain I want to add this for).  /etc/caddy/data/users_db.json does not exist, because I expected that caddy-auth-portal would create it.
I can prove that the directory is writeable by the following:
$ systemctl show caddy | grep -i user=
User=caddy
DynamicUser=no
$ sudo -u caddy nano  /etc/caddy/data/users_db.json
$ cat  /etc/caddy/data/users_db.json
testing
$ rm  /etc/caddy/data/users_db.json

expected that caddy-auth-portal would create it.

@sbrl , are you using containers/docker? What is your OS?

@sbrl , are you using containers/docker? What is your OS?

I do use containers @greenpau, but not on the host upon which Caddy is running. This is a plain old Ubuntu Server 20.04 instance on amd64 (specifically an Athlon 3000G), running Caddy with systemd with the official package - specifically I followed these instructions: https://caddyserver.com/docs/build#package-support-files-for-custom-builds-for-debianubunturaspbian

@sbrl , btw, you are editing the file as root (see sudo), while running caddy server as caddy user. It could be that caddy user has no write access.

@greenpau true, but I use -u caddy to ensure it's the caddy user, not root. In addition, the file does not exist when  start Caddy - rather it's a directory that is chowned to caddy:caddy. I assume that caddy-auth-portal will create an initial template user DB? Or do I need to lift one from somewhere myself?

@sbrl , this look like something filesystem related. I can offer little help here.

haha, found it! It was ProtectSystem=full in the systemd service file. Moving the data dir elsewhere fixed it.
Now I'm going to play around with the web administration panel :D


fix(price-text): fixed color of price txt

Fixes this

:tada: This PR is included in version 1.170.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore(main): release 1.0.5

:robot: I have created a release beep boop
1.0.5 (2024-12-07)
Bug Fixes

attaching to nofile buffers (#175) (246b7dc)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.0.5
:sunflower:


Bug: Item Qualities reset on dragging between compendium and character sheet or character sheet to character sheet.

I installed the dev mod tonight and we noticed that weapons lose all qualities when you add them to a character sheet from the compendium.  Further testing revealed it also happened when dragged from character to character.  This didn't happen to attachments, they transferred fine.

In the dev branch... note this will require a restart of Foundry in order to activate (only needed for dev branch)

In the dev branch... note this will require a restart of Foundry in order to activate (only needed for dev branch)


Synchronize Data.swift from the overlay

This pulls in the fixes for:
Guard Data access to NSData._isCompact under availability guards
Ensure that hashing data with zero bytes avoids empty allocations and fix bridged empty data hashes from de-referencing null values (#12509)
Data slice mutation support (#11939)

@swift-ci please test

Foundation/Data.swift:1645:9: error: use of unresolved identifier '_withStackOrHeapBuffer'
        _withStackOrHeapBuffer(hashRange.count + 1) { buffer in
        ^~~~~~~~~~~~~~~~~~~~~~
Foundation/Data.swift:32:12: error: value of type 'NSData' has no member '_isCompact'
    return data._isCompact()
           ^~~~ ~~~~~~~~~~
Foundation/Data.swift:1496:9: error: use of unresolved identifier '_withStackOrHeapBuffer'
        _withStackOrHeapBuffer(estimatedCount) { allocation in
        ^~~~~~~~~~~~~~~~~~~~~~
Foundation/Data.swift:1579:9: error: use of unresolved identifier '_withStackOrHeapBuffer'
        _withStackOrHeapBuffer(totalCount) { conditionalBuffer in
        ^~~~~~~~~~~~~~~~~~~~~~

I guess it is missing the helper func: will add it to this later today

@phausler Let's get this one in

@swift-ci please test and merge

@swift-ci please test and merge

Foundation/Data.swift:32:12: error: value of type 'NSData' has no member '_isCompact'
    return data._isCompact()
           ^~~~ ~~~~~~~~~~
Foundation/HTTPCookie.swift:252:74: warning: 'characters' is deprecated: Please use String or Substring directly
            secureString = properties[.secure] as? String, !secureString.characters.isEmpty

@swift-ci please test and merge

@swift-ci please test and merge


Changing replication type from ZRS to GZRS/RA-GZRS with Azure portal.

Current documentation states that live migration request is needed to switch from  ZRS to GZRS/RA-GZRS.
https://docs.microsoft.com/en-us/azure/storage/common/redundancy-migration?tabs=portal#switch-between-types-of-replication
However, as far as I've tested, replication type can be changed from Azure portal in some regions.

Japan East ... Successfully changed to GZRS/RA-GZRS.

West US 2 ... Poral returns an error on attempt of switching to GZRS/RA-GZRS

If changing replication type from  ZRS to GZRS/RA-GZRS is allowed with Azure portal, the documentation should be also updated accordingly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66ebb48e-c896-a747-bc42-aa203978a1cd
Version Independent ID: 6e7bfefb-e67c-b5d5-89f7-6f1b6a2e8b61
Content: Change how a storage account is replicated - Azure Storage
Content Source: articles/storage/common/redundancy-migration.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@thiruma0203
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@tamram
Can you please check and add your comments on this doc update request as applicable.

@thiruma0203 - I've checked with the storage engineering team on this. Although some regions may support moving from ZRS to GZRS/RA-GZRS in the portal, not all regions do currently. Therefore, our recommendation for the time being is that customers need to reach out to support to perform the live migration. Support may then recommend that they try the live migration themselves.
#please-close


chore(txs): cleanup logging and error handling

Motivation
Cleans up the txs package from excessive logging and antipattern occurrences of log an error then return it.
Description
Test Plan
TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed
[ ] Update changelog as needed

bors try

bors merge

git checkout errors on windows
bors merge

bors merge


Do not recommend surefire 2.12 in the guide

Surefire 2.12 has pretty serious issue on Windows (SUREFIRE-824), which prevents single tests from being executed. Therefore when following the guide, one gets to situation, which things he knew that always worked without problems suddenly break and suspects Arquillian.
The issue is fixed with surefire 2.12.3

Related to #325


Startup API flood

The Issue
When starting the application, the API gets flooded to oblivion and never really starts. The console output suggests that there might be at least one race condition causing calls to be replayed more than once. Also no timeout between checks seems to be present.
Steps to reproduce

make sure no daemon is running
start LBRY
cry a little

Expected behaviour
LBRY app should open
Actual behaviour
The daemon never actually starts and the app will fail to load
System Configuration
{
  "id": null,
  "jsonrpc": "2.0",
  "result": {
    "build": "release",
    "ip": "*************",
    "lbrynet_version": "0.10.3",
    "lbryschema_version": "0.0.4",
    "lbryum_version": "2.7.22",
    "os_release": "4.8.0-52-generic",
    "os_system": "Linux",
    "platform": "Linux-4.8.0-52-generic-x86_64-with-Ubuntu-16.10-yakkety",
    "processor": "x86_64",
    "python_version": "2.7.12"
  }
}

Screenshots
not a screenshot but a video of the issue:
https://www.youtube.com/watch?v=Jr-RlXm-w1w

let me add one thing i just noticed:
after hitting close, a daemon appears to start
niko@niko-T440p:~/lbry$ ps x | grep lbry
21618 ?        Sl     0:03 /opt/LBRY/lbry
21622 ?        S      0:00 /opt/LBRY/lbry --type=zygote --no-sandbox
22346 ?        S      0:00 /opt/LBRY/resources/app/dist/lbrynet-daemon
22348 ?        Sl     0:00 /opt/LBRY/resources/app/dist/lbrynet-daemon
22360 pts/2    S+     0:00 grep --color=auto lbry

Let me know if you see this again post 0.12.2.


Update CASE REVIEW #1777436 and #1767495

@v-abiss : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @v-abiss For your content updates, note that Microsoft style is to use "allowlist" instead of "whitelist". Thanks.

@steved0x : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@steved0x : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@steved0x : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Won't install on Safari

Safari Version 10.1.2 (12603.3.8). MacOS Sierra 10.12.6.
I tied to install the release. I tried to install via the Extension Builder from source (created a certificate first). No go.
The system.log shows this at the time of the attempted install:
Jul 22 22:33:15 localhost Safari[77604]: assertion failed: 16G29: libxpc.dylib + 74307 [BF896DF0-D8E9-31A8-A4B3-01120BFEEE52]: 0x89
Jul 22 22:33:28 localhost Safari[77604]: BUG in libdispatch client: kevent[EVFILT_MACHPORT] monitored resource vanished before the source cancel handler was invoked
Any ideas?

Never mind. It seems like Safari is unable to install any extension at all. Something else wrong I suppose.


ceph-common: remove absolute path to handler include files

This breaks if the roles don't live in the same place as the playbook.
See: https://github.com/ceph/ceph-ansible/issues/1265
Signed-off-by: Andrew Schoen<EMAIL_ADDRESS>

jenkins test this please

jenkins test ansible2.2-docker_cluster

Merging even if jenkins for docker is not happy since there is no docker related changes.


Track user progress separately by certifications paths (with API endpoint)

Is your feature request related to a problem? Please describe.
The only public progress indicator of a given user is the total points count.
But those points are a sum of the number of solved challenges on all certifications paths.
I think it would be cool if we had the points separated by certification path and also indicated as a percentage.
Describe the solution you'd like
On a user page, instead of having the total points progress, display the points separately by certification path.
Describe alternatives you've considered
It would be great if this is also queryable as an API endpoint.

That heatmap is kind of complex and has always been somewhat problematic. I'm not against improvements, but this sounds like added complexity. I'm not sure exactly how you envision this @rafaelpac, perhaps a mock or something might help.
I potentially like the idea of having some user info being available via an api. Not sure if we want to open that up for extra external traffic though.

Hi, thanks for your interest!
Today, if I go to my page, this is what I see:

I have got 96 points from the Responsive Web Design path and 77 from the JS Algorithms and Data Structures path.
That sums up to 173 points. I am not sure where the other 2 points came from.
I would like to see something like this:

I would like to use this to track my kids progress (with a little python script that I wrote).
To do that today I would need to use something like Selenium, login with their usernames, find the points elements in the DOM and sum them.
It would be much easier and less prone to errors if I could check their public page at once or even better if I can get it from an API.

Hi there @rafaelpac I think you might be interested in https://github.com/freeCodeCamp/classroom From the README:

For a while now teachers have been asking for a way to get a birds eye view of multiple students who are progressing through the course. This is why we set out to make freeCodeCamp classroom mode, an interactive dashboard for teachers to view multiple freeCodeCamp users’ progress on their courses.

Is that more or less what you're looking for?

Thanks @ojeytonwilliams! This looks great indeed!
But I am not sure if I know enough to use this, is there a demo version of it running publicly somewhere?

cc @ahmadabdolsaheb

Thanks for bringing this to my attention. Our profile is due for a redesign and we should make the number more meaningful. It will most likely be a tooltip or a dropdown that reveals more info about the user's points.
I will work on a mock/wireframe next week, share it here, and we can continue the discussion.

check #48234


Markdown support

Why doesn't HubPress support Markdown or other popular lightweight markups?

Practically all static site Jekyll blogging platforms support one of the 26
different flavors of markdown.
HubPress sets itself apart because it supports the AsciiDoc syntax only. It
is more suitable for bloggers who want to write more detailed blogs with
complex syntax.
On Sat, 16 Apr 2016, 02:40 Chase May<EMAIL_ADDRESS>wrote:

Why doesn't HubPress support Markdown or other popular lightweight markups?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/HubPress/hubpress.io/issues/371

--
Sent from Mobile.

Does the comment in #25 meant hubpress which use asciidoctor as backend would support a subset of markdown?

It has limited legacy support for some markdown constructs.
They are only supported to help folks migrate from markdown to AsciiDoc,
not really as a long term solution.
On Fri, 22 Apr 2016, 00:03 kfkelvinng<EMAIL_ADDRESS>wrote:

Does the comment in #25
https://github.com/HubPress/hubpress.io/issues/25 meant hubpress which
use asciidoctor as backend would support a subset of markdown?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/HubPress/hubpress.io/issues/371#issuecomment-212934497

--
Sent from Mobile.


Refresh control?

Is there a way to access the refresh control for the calendar?
Or has anyone figured out how to do it?

Unfortunately, no such feature for now. If you create a PR for this, I'm happy to merge it!


Argo rertyStrategy doesn't have "retryOn"

So I'm trying to configure my pod to retry both "on Error" and "on Failure." But Argo doesn't seem to like accept "retryOn" as a parameter to "retryStrategy" as exampled in here: https://github.com/argoproj/argo/tree/master/examples#retrying-failed-or-errored-steps
I've also noted another example which uses "retryPolicy" which Argo throws the same error:
https://github.com/argoproj/argo/blob/master/examples/retry-on-error.yaml
Checklist:

[*] I've included the version.
[ *] I've included reproduction steps.
[* ] I've included the workflow YAML.
[ ] I've included the logs.

What happened:
Argo gives me a 'Failed to parse workflow: error unmarshaling JSON: while decoding JSON: json: unknown field "retryOn"'
What you expected to happen:
It would run.
How to reproduce it (as minimally and precisely as possible):
My workflow yaml (up to offending part):
`
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
generateName: full-run-dag
spec:
entrypoint: generate
arguments:
parameters:
- name: s3-path
value: placeholder
templates:

name: generate
parallelism: 16
steps:

name: generate
template: gen-file-list
arguments:
parameters:

name: s3-path
value: "{{workflow.parameters.s3-path}}"

name: run-full-pipeline
template: run-full-pipeline
arguments:
parameters:

name: file
value: "{{item}}"
withParam: "{{steps.generate.outputs.result}}"

name: run-full-pipeline
inputs:
parameters:

name: file
dag:
tasks:
name: c1
template: step1
arguments:
parameters:

name: file
value: "{{inputs.parameters.file}}"
name: s3-path
value: "{{workflow.parameters.path}}"

name: c2
template: step2
dependencies: [c1]
arguments:
parameters:

name: file
value: "{{inputs.parameters.file}}"
name: s3-path
value: "{{workflow.parameters.path}}"

name: gen-file-list
inputs:
parameters:

name: s3-path
script:
image: {myImage}
command: [python3.6]
source: |
[ A python script that generates a list of data files, each one sent to 'step1' for it process]

env:

name: AWS_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
name: aws-secret
key: aws_access_key_id
name: AWS_SECRET_ACCESS_KEY
valueFrom:
secretKeyRef:
name: aws-secret
key: aws_secret_access_key

name: step1
retryStrategy:
retryOn: "Always"
limit: 5
`

Environment:

Argo version:

argo: v2.2.1
BuildDate: 2018-10-11T16:26:28Z
GitCommit: 3b52b26190163d1f72f3aef1a39f9f291378dafb
GitTreeState: clean
GitTag: v2.2.1
GoVersion: go1.10.3
Compiler: gc
Platform: linux/amd64

Kubernetes version :

clientVersion:
buildDate: "2019-09-24T22:12:08Z"
compiler: gc
gitCommit: 1861c597586f84f1498a9f2151c78d8a6bf47814
gitTreeState: clean
gitVersion: v1.14.7-eks-1861c5
goVersion: go1.12.9
major: "1"
minor: 14+
platform: linux/amd64
serverVersion:
buildDate: "2019-12-22T23:14:11Z"
compiler: gc
gitCommit: c0eccca51d7500bb03b2f163dd8d534ffeb2f7a2
gitTreeState: clean
gitVersion: v1.14.9-eks-c0eccc
goVersion: go1.12.12
major: "1"
minor: 14+
platform: linux/amd64
Other debugging information (if applicable):
Failed to parse workflow: error unmarshaling JSON: while decoding JSON: json: unknown field "retryOn"

Message from the maintainers:
If you are impacted by this bug please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

What version please?

using v2.4.3 and same error is returned

argo: v2.2.1

retryOn is only available on version v2.5+

We experienced this error with v2.6.1.
The docs refer to retryOn, which does not appear to be valid. They should refer to retryPolicy

I am having the same issue with Argo v2.7.0. Should we open a new Issue?
Error:
Failed to parse workflow: error unmarshaling JSON: while decoding JSON: json: unknown field "retryOn"

YAML:
retryStrategy:
  limit: 2
  retryOn: OnError

Output from argo version:
argo: v2.7.0
  BuildDate: 2020-03-31T23:35:04Z
  GitCommit: 4d1175eb68f6578ed5d599f877be9b4855d33ce9
  GitTreeState: clean
  GitTag: v2.7.0
  GoVersion: go1.13.4
  Compiler: gc
  Platform: linux/amd64

@mattbennett @appellod Sorry about this guys. The correct field name is retryStrategy.retryPolicy.
One of the doc files incorrectly listed the field as retryStrategy.retryOn, that has been fixed in: https://github.com/argoproj/argo/pull/2591

That seems to have fixed it. Thank you for the fast response!


GROOVY-8326: @Override should not copied onto methods generated by ap…

…plying @Memoize

+1. It begs the question about whether other annotations should have special treatment, e.g. should @SafeVarargs or @SuppressWarnings be transferred only onto the new internal method and be removed from the original? But I see no reason why the approach being used couldn't be extended over time to handle such cases - it will all be "invisible" to the user.

Thanks for picking this up so quickly, @jwagenleitner.

Merged!


scroll inertia

Please add support for setting the amount of scrolling momentum (as animation duration in milliseconds).
The behavior can be seen accessing the demo page of malihu-custom-scrollbar-plugin.
A quote from the documentation of the mentioned plugin:

scrollInertia: integer
Set the amount of scrolling momentum as animation duration in milliseconds.
Higher value equals greater scrolling momentum which translates to smoother/more progressive animation. Set to 0 to disable.

Hi, first of all, thank you for the interest. However, I'm afraid this feature may not be supported, as I want to make this plugin working the same as the native scroll works as much as possible. It means that implementing momentum is up to the browser, not to JavaScript scripts.
The main reason I think like above is that some browsers and even some mouse drivers implement their own momentum function, and thus I can't be sure that our own implementation doesn't make collision with them. I also think that it will also cause performance issues due to the timers and animations. They are not cheap at all(hooking the scroll event itself is also not cheap by the way).
I am really sorry again, and I really appreciate your suggestion. Forking the plugin and modifying it is completely free.
Thanks!

Hi,
OK, it makes sense. Thanks for the feedback!
Best regards,
Mihai


Fp transit tutorial rev 3

These changes do not reflect subsequent code modification requests.

Looks good, ready to merge but waiting on the source code repo to get merged to main which is dependent on the js files being on npm


network: Fix benchmarks sporadic issues with netns

This commit gets rid of doNetNS() function as it is too complex and it introduces some sporadic issues related to the use of go routines and network namespaces at the same time. The cause of those issues
is about some processes/threads changing during the runtime, causing some confusion with the network namespaces used.
The only way is to really make sure everything is controlled by our library, meaning we make all of our network implementations rely on the same "safe" function safeDoNetNS(). This patch also improves this
function by calling into runtime.LockOSThread(). This implies that no matter who is the caller of this function, it will end up in the expected network namespace with the guarantee the thread won't change
during the execution.
This is solving all sporadic issues related to the usage of network namespaces that have been found with the benchmarks.
Fixes #219

Coverage increased (+0.02%) to 67.047% when pulling<PHONE_NUMBER>337d65189ccb9da191ddd67878eb5f on topic/semaphore_ci into fbc84a7312f21c36aabcd963cabcf671ed9bb282 on master.

lgtm

LockOSThread wires the calling goroutine to its current operating system thread. Until the calling goroutine exits or calls UnlockOSThread, it will always execute in that thread, and no other goroutine can.

I haven't checked if that function is called by a short-lived goroutine, but if that isn't the case, it should be a good idea to call UnlockOSThread so we don't end up with 1 goroutine take a full thread and not sharing it with any other.

@dlespiau I agree and I will add a defer call to the function. But just want to let you know that we can do this because in the CreatePod() function, the PrestartHook() function is the first one where we can expect safeDoNetNS() to be called, meaning that we already achieved our goal to keep the PID == TID. Look at api.go, I had added an init() function calling into LockOSThread(). The reason for this is about keeping the consumer of the library with its process ID the same than the thread ID until we get into the hook. Indeed, dockerd inspects only /proc/PID/ns/net, meaning we cannot have a different thread ID.
I will submit a second patch to this PR, in order to Unlock all threads for every APIs function, and one Unlock right after we don't need it anymore in the case of CreatePod().

This is definitely a bit fiddly, it also means the consumer of the library can't call API functions in a goroutine (it could be scheduled in a different thread than the main thread). They need to call API functions from the main thread (probably worth documenting).
I'm not sure I follow the reason why your patch work. runtime.LockOSThread will lock the calling goroutine on its current thread, so I don't see any guarantee that the calling goroutine will be bound to the main thread unless it's already running onto the main thread.

Coverage increased (+0.3%) to 67.305% when pulling ada130bf2676cbf3d4553d5daea96c8f51436345 on topic/semaphore_ci into 189b10033225b37dd639e79658ad66cec0081ee1 on master.

@dlespiau Forcing the lockOSThread() inside the init() is the way we force the main thread to have the same ID than the process. When the runtime import virtcontainers library, init() is executed, making sure the thread is locked.
I agree this is not nice... But dockerd forces us to do that because of the wrong implementation...

I get the init() point, what I don't get is why putting a LockOSThread thread inside the function works. This depends on the thread the function is being called from. if the function is called form a goroutine with tid != pid, LockOSThread locks that function on to that thread, not the main thread.

After a brief discussion on IRC, lgtm for the first patch.
The second patch though looks a bit ugly. I'd rather not have it in that form if possible.

Coverage increased (+0.02%) to 67.055% when pulling 5d33348f28d876d61c3160c04d229f845e34d1b4 on topic/semaphore_ci into 189b10033225b37dd639e79658ad66cec0081ee1 on master.

@sboeuf go 1.10 may have a fix for this in the longer term https://github.com/golang/go/issues/20676


get historical rates

Hi Florian,
would it be possible to point laravel-swap at the latest version of swap to open up the possibility of picking historical rates?
Thanks,
Gerard

Hey Gerard,
as you can see I opened a pull request here https://github.com/florianv/laravel-swap/pull/17
This is currently a work in progress, but I hope to wrap it up soon!


fix(popup,undo): make undo-tree visualizer work with our popup manager

Fixes #5317
undo-tree-visualizer-{show/hide}-diff changes the value of undo-tree-visualizer-diff, so even if it is set to t (as default in doom), when the user quits the visualizer (by pressing q), this variable is set to nil (in undo-tree-visualizer-hide-diff).
An unexpected behavior is that first the visualizer is shown in a side window, and the second time it is invoked, it is shown in a popup.
This forces undo-tree visualizer always show in popup, and makes it respect the value of undo-tree-visualizer-diff.

Thanks for taking a look, @hlissner . I close it now as it seems to be an upstream bug.


Add api_server interaction for data retrieval

As described in issue #23

@lorcalhost , what is the python3-gunicorn library? It should be gunicorn just.
https://pypi.org/project/gunicorn/

@DmytroLitvinov I'm not sure where it came from, I must have been tired yesterday night.
I will fix it right away, thanks for noticing.

Shall we drop this?


Please add sync settings function

New Issue Checklist (tick off like this: [x])

[x] I checked existing issues (open and closed) for possible duplicates
[ ] I can reproduce the problem on the latest stable version (not nightly!)
[ ] If you have a problem a specific website: adding the domain to your blacklist does not solve the problem
[x] The issue is not about adding entries to the default blacklist

What is your browser?

[x] Firefox
[ ] Chrome

What is your operating system?

[ ] Linux
[ ] Mac
[x] Windows

Description (please include examples/screenshots where applicable)
as title
please add sync settings function or cloudstore save settings
thanks a lot

No time to work on this at the moment, but maybe someone else has?


Solace client panic with CGO runtime errors when trying to instantiate with [boringcrypto] library.

We are facing an issue with CGO runtime error: cgo argument has Go pointer to unpinned Go pointer, when we try to integrate both boringcrypto & solace-client libraries.

We don't see any issue when we tried to link solace-client library without boringcrypto. But with boringcrypto CGO started panic with a UnPin Go pointers exists at runtime and doesn't allow the application to start.

We did few investigation to see if the issue is known and resolved by other Go client libraries and found an interesting issues with imdb-go-client that claims, if the Go pointer pass to C function and the allocation is done with new() then CGO runtime panics with the unsafe pointer. And as resolution to replace new() with C.malloc(). Please check this issue for more details.

Also, please check this issue that we wanted to understand with boringcrypto. https://github.com/golang/go/issues/64694

Error message
panic: runtime error: cgo argument has Go pointer to unpinned Go pointer
goroutine 1 [running]:
solace.dev/go/messaging/internal/ccsmp.(*SolClientContext).SolClientSessionCreate.func1.1(0x7f78f10cc5b8?, 0x30?, 0xc000640000?, 0xc000aca7e0?)
/go/src/github.com/example/vendor/solace.dev/go/messaging/internal/ccsmp/ccsmp_core.go:265 +0x51solace.dev
/go/messaging/internal/ccsmp.(*SolClientContext).SolClientSessionCreate.func1()
/go/src/github.com/example/vendor/solace.dev/go/messaging/internal/ccsmp/ccsmp_core.go:265 +0x25

Hi @DeeptimanQlik, can you please raise this issue by contacting<EMAIL_ADDRESS>so we can investigate it further?
Cheers,
MV


UCA - wrong punishment reason

Description
LabyMod version: 4
Minecraft version: 1.12.2
Addon version: 2.3.0

Checklist
Reporter (You)

[x] Issue name according to naming conventions added (UCA - <short description>)
[x] Bug description added and information provided

Refinement (We)

[x] Project linked
[x] Milestone linked
[x] Contributor assigned

Start issue (We)

[x] Branch according to naming convention created (bug/UCA-<issue-number>-<short-description>)
[x] Pull request according to naming convention created (bug/UCA-<issue-number>-<short-description>)
[x] Reviewer assigned to pull request

Bitte eine Beschreibung hinzufügen


Typo "GitHub Action workflows"→"GitHub Actions workflows"

https://docs.microsoft.com/en-us/visualstudio/deployment/deploying-applications-services-and-components?view=vs-2022
https://github.com/MicrosoftDocs/visualstudio-docs/blob/main/docs/deployment/deploying-applications-services-and-components.md
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit c78cf15:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/deployment/deploying-applications-services-and-components.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off Thanks!


Made changes in header!

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

👨💻 Changes proposed:
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Changes made -

Logo image changed to actual text with same font and size parameters.
Corresponding font link is added as internal style in-order to easily get it.

The href value of this text change to #. (initially though it refers to itself it was not working!).

Also commented the previously unreferenced code from styles.css

Description -
Firstly the each page header consists of image as logo (i.e.  Medsats) which doesn't not perfectly gel up with the background of the header.
Thus, in-order to convert it into text I have found out the most relevant font, whose link I have mentioned in the internal styling format. Also made the  appropriate changes in the positions of the stethoscope image and Medstats text symbol. The previous font related parameters are taken care in this change too, You can compare the image of logo used and the text in my change are almost alike.
Secondly as the Name of the organization is mentioned in anchor tag ,the href provided to it is not working(there is chance that this issue might be only on my side) but the change I have made will work any ways as it references to the top of page.
I would like to highlight that the changes related to the header are made only on the home page(i.e. index.html) the same logo exits on other pages too! So if you agree the changes I made , I would like to proceed with same to the remaining pages.
**Also if I had made any blunder ,being a newbie , your suggestions are most Welcome !
Hope you get me back with reply!
Thank you!**
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.
[ ] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.
[x] I am a participant of Hacktoberfest 2023.

📷 [Screenshots]
Updated header pic-

📄 Note to reviewers
I would like to highlight that the changes related to the header are made only on the home page(i.e. index.html) the same logo exits on other pages too! So if you agree the changes I made , with your approval I would like to proceed with same on the remaining pages.

Your changes are not consistent across all the pages of the website.


🐛 Bug Report: [plugin-api-docs] Ignoring http scheme with swagger 2.0 file

📜 Description
I have a swagger 2.0 API spec.
It contains a host and a HTTP scheme. When I make a request, the swagger viewer indicates that it sent the request using HTTP but looking at the Network and Console tab of the developer tools I see that it used HTTPS.
👍 Expected behavior
Use HTTP scheme when selected
👎 Actual Behavior with Screenshots
Used HTTPS scheme.

👟 Reproduction steps
Use the following API spec:
---
    swagger: "2.0"
    info:
      description: "test-service"
      version: "1.0.0"
      title: "test-service"
    basePath: "/api/1/accounting"
    host: "test-service.svc.eqx.dal.prod.kubernetes:8080"
    schemes:
      - http
    tags:
    - name: "test-service"
    - name: "test-service-debugging"
    paths:
      /triggerError:
        get:
          tags:
          - "test-service-debugging"
          summary: "(DEV) Manually trigger an error"
          operationId: "triggerError"
          parameters: []
          responses:
            "200":
              description: "Trigger an error"

And create an API type component with it.
Use plugin-api-docs to create an API plugin.
Make a request using the swagger viewer and observe using developer tools that it used a HTTPS scheme
📃 Provide the context for the Bug.
No response
🖥 Your Environment
yarn run v1.22.19
$ /Users/rwatkins/sqsp-src/backstage/node_modules/.bin/backstage-cli info
OS:   Darwin 21.6.0 - darwin/arm64
node: v16.17.1
yarn: 1.22.19
cli:  0.19.0 (installed)
backstage:  1.6.0

Dependencies:
  @backstage/app-defaults                          1.0.7
  @backstage/backend-common                        0.15.2, 0.16.0
  @backstage/backend-plugin-api                    0.1.3
  @backstage/backend-tasks                         0.3.6, 0.3.7
  @backstage/catalog-client                        1.1.1, 1.1.2
  @backstage/catalog-model                         1.1.2, 1.1.3
  @backstage/cli-common                            0.1.10
  @backstage/cli                                   0.19.0
  @backstage/config-loader                         1.1.5, 1.1.6
  @backstage/config                                1.0.3, 1.0.4
  @backstage/core-app-api                          1.1.1
  @backstage/core-components                       0.11.2, 0.12.0, 0.9.5
  @backstage/core-plugin-api                       1.0.7, 1.1.0
  @backstage/dev-utils                             1.0.7
  @backstage/errors                                1.1.2, 1.1.3
  @backstage/integration-react                     1.1.5
  @backstage/integration                           1.3.2, 1.4.0
  @backstage/plugin-api-docs                       0.8.10
  @backstage/plugin-app-backend                    0.3.37
  @backstage/plugin-auth-backend                   0.16.0
  @backstage/plugin-auth-node                      0.2.6
  @backstage/plugin-catalog-backend-module-github  0.1.8
  @backstage/plugin-catalog-backend                1.5.0
  @backstage/plugin-catalog-common                 1.0.7, 1.0.8
  @backstage/plugin-catalog-graph                  0.2.22
  @backstage/plugin-catalog-import                 0.8.12
  @backstage/plugin-catalog-node                   1.2.0
  @backstage/plugin-catalog-react                  1.2.0, 1.2.1
  @backstage/plugin-catalog                        1.6.0
  @backstage/plugin-github-actions                 0.5.10
  @backstage/plugin-home                           0.4.26
  @backstage/plugin-kubernetes-backend             0.7.3
  @backstage/plugin-kubernetes-common              0.4.3
  @backstage/plugin-kubernetes                     0.7.3
  @backstage/plugin-lighthouse                     0.3.10
  @backstage/plugin-org                            0.5.10
  @backstage/plugin-pagerduty                      0.5.3
  @backstage/plugin-permission-common              0.6.4, 0.7.0, 0.7.1
  @backstage/plugin-permission-node                0.6.5, 0.7.0
  @backstage/plugin-permission-react               0.4.6, 0.4.7
  @backstage/plugin-proxy-backend                  0.2.31
  @backstage/plugin-scaffolder-backend             1.7.0
  @backstage/plugin-scaffolder-common              1.2.1
  @backstage/plugin-scaffolder                     1.7.0
  @backstage/plugin-search-backend-module-pg       0.4.2
  @backstage/plugin-search-backend-node            1.0.3, 1.0.4
  @backstage/plugin-search-backend                 1.1.0
  @backstage/plugin-search-common                  1.1.0, 1.1.1
  @backstage/plugin-search-react                   1.2.0
  @backstage/plugin-search                         1.0.3
  @backstage/plugin-sonarqube-backend              0.1.3
  @backstage/plugin-sonarqube                      0.5.0
  @backstage/plugin-stack-overflow                 0.1.6
  @backstage/plugin-tech-radar                     0.5.17
  @backstage/plugin-techdocs-backend               1.4.0
  @backstage/plugin-techdocs-module-addons-contrib 1.0.5
  @backstage/plugin-techdocs-node                  1.4.1
  @backstage/plugin-techdocs-react                 1.0.5
  @backstage/plugin-techdocs                       1.3.3
  @backstage/plugin-user-settings                  0.4.8
  @backstage/plugin-xcmetrics                      0.2.30
  @backstage/release-manifests                     0.0.6
  @backstage/test-utils                            1.2.1
  @backstage/theme                                 0.2.16
  @backstage/types                                 1.0.0, 1.0.1
  @backstage/version-bridge                        1.0.1, 1.0.2
✨  Done in 2.05s.

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No response

This might be due to browser security, if the CSP rule upgrade-insecure-requests is active.
If you are using the app-backend plugin which serves the frontend from the Backstage backend, you can override this in config:
backend:
  csp:
    upgrade-insecure-requests: false

If you have your own serving infra, you'll want to use its native ways of injecting the right CSP header.

That's fixed it. Thanks


GetListing() throws exception after installing TLS security update CVE-2019-1318

FTP OS: Unix
Computer OS: Windows 2016 Server, Windows 10
After installing Windows Security update for TLS we're getting an exception ("Object reference not set to an instance of an object") when trying to list files using the GetListing() method on an FTP-site using TLS1.2 protocol.
https://portal.msrc.microsoft.com/en-US/security-guidance/advisory/CVE-2019-1318
We also get the same exception when using GetNameListing(). After uninstalling the Windows Update everything works as expected again.
Logs :

# OpenPassiveDataStream(EPSV, "MLSD /", 0)
Command:  EPSV
Response: 229 Extended Passive mode OK (|||50604|)
Status:   Connecting to XX.XX.XX.XX:50604
Command:  MLSD /
Response: 150 Accepted data connection
Status:   FTPS Authentication Successful
Status:   Time to activate encryption: 0h 0m 0s.  Total Seconds: 0,0433908.
+---------------------------------------+
-----------------------------------------
Status:   Disposing FtpSocketStream...

# CloseDataStream()
Status:   Disposing FtpSocketStream...
Exception thrown: 'System.NullReferenceException' in FluentFTP.dll

Wow, I was just researching this exact problem today, talk about good timing.
Extra info here:
[1]
https://www.limilabs.com/blog/ftp-tls-encrypted-data-connections-fail-ems
[2]
https://forum.filezilla-project.org/viewtopic.php?t=51601
[3]
https://forum.filezilla-project.org/viewtopic.php?t=36903

I'm not seeing exceptions, I'm getting a 450 response when calling GetListing or GetNameListing.
This is my log:

# Connect()
Status:   Connecting to xx.xx.xx.xx:990
Response: 220 Unauthorized access prohibited!
Command:  AUTH TLS
Response: 234 Using authentication type TLS
Status:   FTPS Authentication Successful
Status:   Time to activate encryption: 0h 0m 0s.  Total Seconds: 0.1496005.
Command:  USER xxxxx
Response: 331 Password required forxxxxx
Command:  PASS ***
Response: 230 Logged on
Command:  PBSZ 0
Response: 200 PBSZ=0
Command:  PROT P
Response: 200 Protection level set to P
Command:  FEAT
Response: 211-Features:
Response: MDTM
Response: REST STREAM
Response: SIZE
Response: MLST type*;size*;modify*;
Response: MLSD
Response: AUTH SSL
Response: AUTH TLS
Response: PROT
Response: PBSZ
Response: UTF8
Response: CLNT
Response: MFMT
Response: EPSV
Response: EPRT
Response: 211 End
Status:   Text encoding: System.Text.UTF8Encoding
Command:  OPTS UTF8 ON
Response: 202 UTF8 mode is always enabled. No need to send this command.
Command:  SYST
Response: 215 UNIX emulated by FileZilla

# SetWorkingDirectory("someFolder")
Command:  CWD Attendance
Response: 250 CWD successful. "/someFolder" is current directory.

# GetNameListing(null)

# GetWorkingDirectory()
Command:  PWD
Response: 257 "/someFolder" is current directory.
Command:  TYPE I
Response: 200 Type set to I

# OpenPassiveDataStream(PASV, "NLST /someFolder", 0)
Command:  PASV
Response: 227 Entering Passive Mode (xx,xx,xx,xx,4,3)
Status:   Connecting to xx.xx.xx.xx:1027
Command:  NLST /someFolder
Response: 150 Opening data channel for directory listing of "/someFolder"
Command:  QUIT
Response: 450 TLS session of data connection has not resumed or the session does not match the control connection
Status:   Disposing FtpSocketStream...

# Dispose()
Status:   Disposing FtpClient object...
Status:   Disposing FtpSocketStream...
The program '[21892] TheApp.exe' has exited with code -1 (0xffffffff).

Not exactly sure but it appears to be the same TLS session resumption bug.
See : https://github.com/robinrodricks/FluentFTP/issues/347

Not exactly sure but it appears to be the same TLS session resumption bug.
See : #347

Agreed, thanks.  I'll keep an eye on #347 for movement.

Not exactly sure but it appears to be the same TLS session resumption bug.
See : #347

It's not the same issue. That issue is for Linux clients, where the .NET SSLStream on Linux never supported session resumption. This issue specifically mentions being on a Windows client after installing the CVE-2019-1318 patch. This is something that worked on Windows before and does not work now. That windows update breaks .NET SSLStream's session resumption function on Windows when trying to connect to a Linux server.
I agree that you can't fix this, but it's not a server issue because CVE-2019-1318 was a Windows specific TLS fix. What they do have in common is that the native SSL libraries on both platforms (after the windows patch) can't re-use a TLS session via SSLStream.
(Disclaimer: I don't use FluentFTP, but I found this issue looking into ways around this same problem with another library that relies on SSLStream)


fix: Switch roles in dlc channel

I am unsure if this is intended to stay that way, but if the mobile app is proposing the dlc channel, the mobile app is offering and the coordinator is accepting. Correspondingly, these values are currently switched.
This change fixes that issue.

bors r+


ID3v2 chapter support

Would it be possible to implement id3v2 chapter support and set them based on the timestamps and names/tags of the individual mp3 files?
i use mp3cat to combine split audiobooks into one file to make it available to my podcast client with DirCaster. Chapter support would be a great addition to this setup.
Thank you for this nice piece of software.

Hi @uffsalot, that was my original use-case too :)
That does sound like an interesting idea but I'm not going to add any extra features to mp3cat as my plan is to keep it as simple as possible. There's an existing fork called mp3binder (https://github.com/crra/mp3binder) that has a lot of extra functionality -- you could try suggesting the idea there.


Package ES6 only works on first load

I built a package based on CSS3 / CSS4, HTML5 and its APIs, the package contains 101 files and uses promises to differentiate the files and measure their priority, at the end of a promise, you may or may not start another one as needed, in the following format:
import(/* webpackMode: "lazy-once" */ /* webpackChunkName: "exemple1" */ /* webpackPrefetch: true */ /* webpackPreload: true */ "../module1").then(exemple1 => {
import(/* webpackMode: "lazy-once" */ /* webpackChunkName: "exemple2" */ /* webpackPrefetch: true */ /* webpackPreload: true */ "../module2").then(exemple2 => {
//code execution or do another import
});
});

The modules look like this:
export default function Exemple1() {
//code
};
new Exemple1()

The package works perfectly without the Webpack, with the Webpack, it only works in the first access, in the later accesses it works partially, it was verified that all the modules appear in the source map, but only some are executed, although all of them are really necessary, the Total non-minimized packet size is 411 kb or 652 KB on disk, no errors have been logged on the console. See the configuration files: (no dependencies required)
Package.json - Name, description, version, main file and test file have been omitted for security reasons.
{
   "private": true,
   "mode": "production",
   "main": "....",
   "name": "....",
   "description": "...",
    "version": "...",
    "scripts": {
        "test": "....",
        "dev": "npm run development",
        "development": "npx webpack",
        "watch": "npm watch",
        "prod": "npm run production",
        "production": "npx webpack"
    },
    "devDependencies": {
        "webpack": "^5.35.0",
        "webpack-cli": "^4.6.0"
    },
    "dependencies": {
        "es6-promise": "^4.2.8"
    }
}

Webpack.config.js
const path = require('path');
var webpack = require('webpack');

module.exports = {
mode: 'production',
cache: false,
devtool: 'source-map'
}

A reduction in the number of pieces (files generated) was attempted with the code below, but it did not solve the problem:
module.exports = {
[...]
entry: './main.js',
output: {
    path: path.resolve(__dirname, './dist'),
    publicPath: 'js/',
    filename: 'main.js',  library: 'packgeexemple',
    sourceMapFilename: '[name].[contenthash].map',
    chunkFilename: '[name].[contenthash].js',
    libraryTarget: 'window',
    libraryExport: 'default',
    clean: true,
},
optimization: {
     splitChunks: {
       cacheGroups: {
         vendor: {
           test: /[\\/]node_modules[\\/]/,
           name: 'vendors',
           chunks: 'all',
         },
       },
     },
	 },
  plugins: [
    new webpack.optimize.LimitChunkCountPlugin({
      maxChunks: 5,
    }),
  ]
}

How can this be resolved?

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.
I will reopen then you fix it, respect time of other developers, thanks

Please go to https://github.com/webpack/webpack/issues/new/choose and chose Bug report and use the issue template

@alexander-akait alexander-akait
It's right now? https://github.com/webpack/webpack/issues/13198


Right pattern for reporting error to user

With Redux Saga, what's the recommended pattern to report error while executing an operation to user? With redux-thunk we can return a promise while dispatching an operation and allow user to essentially observe that promise. Since all the actions are plain objects in saga world, this isn't possible. And it's not always convenient to report error via state change (think react native alerts)

I think that there is no difference between redux-saga and redux-thunk on the ability for reporting the progress to user. Because of Redux is single state, we need to put the operation progress to the store. And the state is changed only by Actions. So you can dispatch Actions based on the progress of operations.
Note: callAPI(...) returns Promise object
// redux-thunk (action creator)
function fetchRequest(id) {
  return dispatch => {
    dispatch({ type: FETCH_OBJECTS_REQUEST });
    callAPI(id).then(data => {
      dispatch({ type: FETCH_OBJECTS_SUCCESS, data });
    }).catch(error => {
      dispatch({ type: FETCH_OBJECTS_FAIL, error });
    });
  };
}

// redux-saga
function* runRequest({ payload }) {
  const { id } = payload;
  const { data, error } = yield call(callAPI, id);
  if (data && !error) {
    yield put({ type: FETCH_OBJECTS_SUCCESS, data });
  } else {
    yield put({ type: FETCH_OBJECTS_FAIL, error });
  }
}

function* handleRequest() {
  yield* takeLatest(FETCH_OBJECTS_REQUEST, runRequest);
}

In redux-thunk you can do
function fetchRequest(id) {
  return dispatch => {
    dispatch({ type: FETCH_OBJECTS_REQUEST });
    return callAPI(id).then(data => {
      dispatch({ type: FETCH_OBJECTS_SUCCESS, data });
      return data;
    }).catch(error => {
      dispatch({ type: FETCH_OBJECTS_FAIL, error });
      throw error;
    });
  };
}

And in the calling function
this.props.dispach(fetchRequest()).then((data) => {
  // Do something upon success
}, (err) => {
  // Do something upon failure
})

Strictly speaking this isn't going through the store, but sometimes it's really convenient to be able to do stuff like this when interacting with other APIs that are imperative rather than declarative.

Umm... I understand what you want to say. I have no idea to do directly like that with redux-saga.
If you do so, React component (which calls this.props.dispach) is no longer pure. This causes decreasing of testability.

when interacting with other APIs that are imperative rather than declarative

Does this mean an use-case like chained API calling?
For example, please consider two API endpoints; /users and /users/<id>/posts.
You want to load a list of users from /users endpoint first, and then load a list of latest posts for each user. But if you get an error on calling /users, you don't want to call /users/<id>/posts.
this.props.dispach(fetchRequest()).then((data) => {
  this.props.dispatch(fetchOtherRequest()).then((data) => {
    // Do something upon success both
  }, (err) => {
    // Error handling
  });
}, (err) => {
  // Do something upon failure
})

If chained API call is your hidden needs, it's a common pattern in redux-saga.
function* handleRequestSearchByLocation() {
  while (true) {
    const action = yield take(SUCCESS_USER);
    const { payload, error } = yield call(API.searchByLocation, action.payload.location);
    if (payload && !error) {
      yield put(successSearchByLocation(payload));
    } else {
      yield put(failureSearchByLocation(error));
    }
  }
}

function* handleRequestUser() {
  while (true) {
    const action = yield take(REQUEST_USER);
    const { payload, error } = yield call(API.user, action.payload);
    if (payload && !error) {
      yield put(successUser(payload));
    } else {
      yield put(failureUser(error));
    }
  }
}

export default function* rootSaga() {
  yield fork(handleRequestUser);
  yield fork(handleRequestSearchByLocation);
}

As @kuy mentioned it depends on the sepecific use case. If you want to achieve a general purpose communication mechanism you make take a look at the Channel API.

I think this didn't resolve the problem  it's not always convenient to report error via state change (think react native alerts)?
How can I do that?

https://github.com/itinance/redux-saga-rn-alert

Just looking at this and I like the solution provided by @kuy .  That said, you can still use thunks alongside sagas when you need to.


Release version to v2.1.0

Prepare for 2.1.0 release

it would be cool to introduce the CHANGES.md file before creating this release.

i've labeled the PRs with milestones 2.1.0 here.
Can someone please, for each PR, add the appropriate category label

i've labeled the PRs with milestones 2.1.0 here.
Can someone please, for each PR, add the appropriate category label.
Once this is done, let me know and i'll generate the CHANGES.md (or you can do it yourself with https://github.com/neuropoly/changelog)

Done in 874a16c :) changelog is very useful and easy to use :tada: !!

Once I do the release, should I directly copy/paste the content of the CHANGES.md file in the release description?

@andreanne-lemay i see that some PRs have two categorie labels: there could be only one. Can you correct please?

Once I do the release, should I directly copy/paste the content of the CHANGES.md file in the release description?

no, you can simply add the following:
Release notes and Changelog


Error when including rehype plugins

🐛 Bug Report
Unable to add rehypePlugins in docusaurus.config.js. Results in following error during docuasaurus start and docusaurus build.
ValidationError: "rehypePlugins[0]" must be a string
Have you read the Contributing Guidelines on issues?
Yes.
To Reproduce
(Write your steps here:)

npx @docusaurus/init@next init docusaurus classic
npm i --save remark-math rehype-katex
In docusaurus.config.js import the two packages and add to docs:

const katex = require("rehype-katex");
const math = require("remark-math");

module.exports = {
  // ...
  presets: [
    [
      "@docusaurus/preset-classic",
      {
        docs: {
          // It is recommended to set document id as docs home page (`docs/` path).
          homePageId: "doc1",
          sidebarPath: require.resolve("./sidebars.js"),
          remarkPlugins: [math],
          rehypePlugins: [katex],
          // Please change this to your repo.
          editUrl:
            "https://github.com/facebook/docusaurus/edit/master/website/",
        },
        // ...
      },
    ],
  ],
};

docusaurus start

Expected behavior
Expect to be able to serve website.
Actual Behavior
docusaurus start

Starting the development server...
ValidationError: "rehypePlugins[0]" must be a string

(Write what happened. Add screenshots, if applicable.)
Your Environment

Docusaurus version used: 2.0.0-alpha.59
Environment name and version (e.g. Chrome 78.0.3904.108, Node.js 10.17.0): Node 14.5.0
Operating system and version (desktop or mobile): Windows 10

Reproducible Demo
https://github.com/mattcorner/docusaurus-equations-error/blob/master/docusaurus.config.js

I should add that I get the same issue when following the documentation for adding rehype/remark plugins from the documentation:
https://v2.docusaurus.io/docs/markdown-features#configuring-plugins

Thanks, this is a mistake in the plugin validation. #3120 will fix this issue (and also other issues related to config validation)

released in https://github.com/facebook/docusaurus/releases/tag/v2.0.0-alpha.60

This still seems to be an issue, following the docs at https://v2.docusaurus.io/docs/markdown-features#configuring-plugins I get an error in validation when using this config which is straight out of the docs
const rehypeTruncate = require("rehype-truncate");
....
rehypePlugins: [rehypeTruncate]

ValidationError: "rehypePlugins[0]" does not match any of the allowed types

@teikjun can you take a look please?

@mattmillerart thanks! It will be fixed in #3247


[2.1.1] Fix losing UTC DateTimeKind on ISO8601 UTC values (#2317)

Port #2317 to release/2.1
⚠⚠⚠ DO NOT MERGE ⚠⚠⚠
release/2.1 has not yet been opened for servicing fixes.
⚠⚠⚠ DO NOT MERGE ⚠⚠⚠

Approved for 2.1.1 but the branch is not yet open


question: Is there a way to match if a value is in an array?

I'd like to be able to use cognito with the "cognito:groups" field, to see if a person is in a group and transform their roles accordingly.  However, the match statements all seem to assume it's looking at a string.  Is there a way to match if an element appears in an array?

I should also add, it appears there's some difficulty with the match directive parsing the field with a colon in it.

@mattatjff , what is your current config the output of /whoami?

Not sure what that refers to.  I don't have any additional configuration with respect whoami, other than that I have "enable id_token cookie ".  Perhaps I'm misunderstanding something, but my understanding was that the match directive allowed you to match the ID Provider's claims in order to modify/transform the claims in the plugin.
Passing ?format=json&id_token=true to whoami gets the Cognito token which includes claims like:
"cognito:groups": [
  "groupname1",
  "groupname2",
  "..."
]

What I'm trying to do is basically say something like:
transform user {
        match cognito:groups myapp
        action add role authp/user
        ui link "My Application" / icon "las la-star"
}

Such that if a user is in the group "myapp" in cognito, they are a user for this application.

my understanding was that the match directive allowed you to match the ID Provider's claims in order to modify/transform the claims in the plugin.

Yes. However, it might work differently than how you think it work.
Here is the working config:
                oauth identity provider cognito-us-east-1 {
                        driver cognito
                        realm cognito-us-east-1
                        client_id {env.WEB_APP_CLIENT_ID}
                        client_secret {env.WEB_APP_CLIENT_SECRET}
                        user_pool_id {env.USER_POOL_ID}
                        region us-east-1
                        icon "AWS Cognito US" priority 100
                        enable id_token cookie
                }

...

                        transform user {
                                match origin cognito-us-east-1
                                action add role authp/user
                        }

Currently, you need to create "custom:roles" attribute to propagate Cognito roles to be able to match them.
https://github.com/greenpau/go-authcrunch/blob/50f3edc60f01348d580c769761097734f4f0527e/pkg/idp/oauth/validator.go#L124C11-L129
However, I could adjust this by making cognito:groups to work the same way how custom:roles work.
When using custom:roles, the value you specify in Cognito UI would be "role1|role2".
That would require me to make changes.
I need to see the actual token with cognito:groups in it. Please enable debug and capture the token.

Looks like the tokenFeilds in the validator already accounts for "groups" and there are others who are looking for similar transformation on other projects:
https://github.com/greenpau/go-authcrunch/blob/50f3edc60f01348d580c769761097734f4f0527e/pkg/idp/oauth/validator.go#L29C1-L29C38
https://github.com/smallrye/smallrye-jwt/issues/105
Perhaps simply transforming cognito:groups to groups and cognito:roles to roles would be sufficient?

Perhaps simply transforming cognito:groups to groups and cognito:roles to roles would be sufficient?

I don't think you can transform on cognito:groups field, because it is non-standard.
That's why I need to modify the logic.
As a side thing, I will add an option of including the following into roles.
  "cognito:roles": [
    "arn:aws:iam::23094802482:role/example"
  ],

Tried to build this to test, but running into this: https://github.com/caddyserver/caddy/issues/5797

@mattatjff , I am working on the fix and will be releasing new version soon. Will update this issue once completed.

@mattatjff , please try this release https://github.com/greenpau/caddy-security/releases

I don't know go... but this is including the entire id_token from cognito as the role... I think the error is here:
https://github.com/greenpau/go-authcrunch/blob/8eb4bfba8f4993876bc0fa8c03045835d64222e2/pkg/idp/oauth/validator.go#L126C1-L126C34
I believe this should probably be switch values := val.(type) { ... as v is indeed a string, but that's assigned to the ID token itself earlier.

@mattatjff , let me quickly fix it. The issue with that specific function is that it is not being tested properly. So I took a shortcut.
If the next one fails, I would need to write a proper unit test 😭

v1.1.22 confirmed good... works with either group or the role attached to it.  Thank you very much.

Enjoy the journey 😄

@greenpau you too.  Thanks for the great piece of software, this really saved me a ton of time.  Any place I can donate?

Any place I can donate?

Github Sponsors

Hi @mattatjff, I am looking to add testimonial sections to https://authcrunch.com. Could you please write one and send it to me at<EMAIL_ADDRESS>


Support For Mobile

Would it be hard to do a support for mobile devices for this plugin?

That’s going to be difficult. Large parts of the core would have to be rebuilt for this, as they are based on nodejs libraries, which are not available on mobile. This will be an issue, if at all, for version 2

Thanks for considering this!

That’s going to be difficult. Large parts of the core would have to be rebuilt for this, as they are based on nodejs libraries, which are not available on mobile. This will be an issue, if at all, for version 2

thank you for considering this!

moved to Roadmap

That’s going to be difficult. Large parts of the core would have to be rebuilt for this, as they are based on nodejs libraries, which are not available on mobile. This will be an issue, if at all, for version 2

If you turn it into a PWA you could include the entire node.js and it would be acceptable as Android application (or as a - self-hosted or not - web-based service ChromeOS would turn it into an application). That should be a lot less work. Even a web-assembly might make sense.

Hi, I am confused about the status of this feature request.
Is it "completed" as it appears to be indicated on the roadmap or does it require further work?
I would love to be able to use mobile devices(android, iOS) as well to utilise this plugin


⚠ Bofrost.fr has degraded performance

In 794f30b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1234 ms

Resolved: Bofrost.fr performance has improved in a8f8723 after 21 minutes.


[WCCMMUD] MajorMud - Map of Newhaven has extra Carriage Returns

Module Information

Identifier: WCCMMUD
Module Name: MajorMud
Version: 1.11g

Describe the bug
Map of Newhaven has extra Carriage Returns
To Reproduce
Steps to reproduce the behavior:

Enter MajorMud module
Create character if none exists, enter game
Execute "MAP" command
See Error

Expected behavior
Map displays correctly
Screenshots
No Console Error

Software Information:

OS: Windows Server 2019 Standard
Telnet Client: NetRunner
MBBSEmu Build: 101820-1

The problem here is that the information is coming from a .ANS file, which already has properly formatted \r\n newline escapes.
When we outprf(), the helper method FormatNewLineCarriageReturn is called, which replaces any \r\ with \r\n and any \n with \r\n. I'm adding code to verify that the sequence being replaced isn't already \r\n (or reverse order) to ensure we don't DOUBLE the new lines.

The fix has broken TA's st\r\n output

Maybe we want to continue the prior behavior during a prfmsg call but do not do the expansion in a normal prf write?


publicly available logs?

It would be interesting to expose the logs publicly,
then someone else could do more analytics on them.

On Roadmap


Add github workflow to check scala code is formatted

Similar to pekko core, replaces the sbt scalafmt check with a github actions one. Also removes the sbt scalafmtCheckAll from the current github actions.

lgtm


Fail fast on template not found

When one of template needed for cluster provisioning not found we need
to fail with panic on SG start-up. We don't wont let user to pass all cluster
configuration steps and fail during cluster spin up because of nil pointer.
Closes #900

Tested this with an empty template folder and got this on start up of the API:
`panic: template certificates not found
goroutine 1 [running]:
github.com/supergiant/supergiant/pkg/workflows/steps/certificates.Init()
/Users/ehenley/go/src/github.com/supergiant/supergiant/pkg/workflows/steps/certificates/certificates.go:29 +0x150
github.com/supergiant/supergiant/pkg/controlplane.configureApplication(0xc4200f1260, 0x0, 0x0, 0x1)
/Users/ehenley/go/src/github.com/supergiant/supergiant/pkg/controlplane/server.go:218 +0x6c3
github.com/supergiant/supergiant/pkg/controlplane.New(0xc4200f1260, 0xc4200f1260, 0x23815e9, 0x3)
/Users/ehenley/go/src/github.com/supergiant/supergiant/pkg/controlplane/server.go:90 +0x50
main.main()
/Users/ehenley/go/src/github.com/supergiant/supergiant/cmd/controlplane/main.go:42 +0x13f
exit status 2`
When trying this with master, I was able to get the API running, so this looks to be working.

@eldridgeh yeah, the idea is to fail on start-up and not let user do cluster configuration.


Allow setting URL for redis config

What changed?
We allow setting a Redis URL in our config via redis_options instead of having to specify a host, port, and password.
E.g.
// instead of this
config :redbird, :redis_options, [host: ...]

// we can now do this
config :redbird, :redis_options, [url: "redis:// ..."]

This is particularly helpful when dealing with Redis + SSL, when the URL scheme changes from redis to rediss.
Implementation details
Redix (the library we use to communicate with Redis) will automatically set ssl: true when it is passed a URL with a rediss scheme.
Unfortunately, the only way to pass a URL to Redix is by passing a modified set of options ({url, list_of_opts} instead of list_of_opts).
Instead of passing those options to Redbird.Redis.start_link/1 only to then pass them again to Redix.start_link/1, we now rely on Redix's child_spec function directly, and put it in our supervision tree.
Finally, to abstract the configuration of options, we create a new module Redbird.Config which handles the merging of options and separating the url from the rest of the options if one is present.

I'd love to use this project and this is the only blocker for me at the moment.

Seems like this PR got approved quite while ago but still not merged into master? As @JacquiManzi mentioned this is the only blocker for us to upgrade redbird to the latest version and we hope to see this to be merged soon.


[docs] Add a guide for setting dark mode by default

Preview: https://deploy-preview-34839--material-ui.netlify.app/joy-ui/customization/dark-mode/
From the docs feedback.

How do I set global dark mode by default?

[x] I have followed (at least) the PR section of the contributing guide.

👍
Thoughts:

A demo could help a lot to be able to build reproductions that are dark mode only. It could also serve as a visual regression test case.
I wonder if setting the default is more important than the rest of the page, so maybe it should be closer to the top.
The dark mode docs page is under "How to guide" but all the pages that aren't API references are also how to guides in our docs, only that they are groups in "logical" sections. So per this rational, I think that it could be better to have the docs about the dark mode under the Customization section. Meaning, we could use "How to guide" for pages we don't know where else to put.

Agree on all points, let me update them altogether.

@oliviertassinari it is ready for a second review.

added typescript
added "identify the system mode" demo.

@samuelsycamore @danilo-leal Wow 😲, it looks much much better. The content flow is so smooth.


Links to MDN are broken with typedoc-plugin-mdn-links since version 4.0.0

What package is the bug related to?
typedoc-plugin-markdown
Describe the issue
After upgrading to version 4.0.1, the links to MDN generated by typedoc-plugin-mdn-links include a space in the beginning, so they refer to an invalid local path instead of an external website.
Output on version 4.0.0-next.44:
#### Returns

[`Promise`](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Promise)\<`void`\>

Output on version 4.0.1:
#### Returns

[`Promise ↗`](%20https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Promise%20)\<`void`\>

By the way, it'd be great if there was a configuration to not add  ↗ to text of external links.
Thanks for making this awesome plugin :)
TypeDoc configuration
{
    "$schema": "https://typedoc.org/schema.json",
    "entryPoints": ["./src/index.ts"],
    "out": "./docs/api",
    "tsconfig": "./tsconfig.json",
    "readme": "./README.md",
    "excludeExternals": true,
    "excludeInternal": true,
    "excludePrivate": true,
    "githubPages": true,
    "hideGenerator": true,
    "jsDocCompatibility": true,
    "plugin": ["typedoc-plugin-markdown", "typedoc-vitepress-theme", "typedoc-plugin-mdn-links"],
    "hideBreadcrumbs": true,
    "hidePageHeader": true,
    "preserveAnchorCasing": true,
    "useCodeBlocks": true,
    "expandObjects": true,
    "expandParameters": true,
    "parametersFormat": "table",
    "propertiesFormat": "list",
    "enumMembersFormat": "table",
    "typeDeclarationFormat": "list",
    "sort": ["source-order"],
    "docsRoot": "./docs"
}

Expected behavior
I expect external links to be valid and start with http and not %20http and end with the content of the original link and not %20

Thank you. Fixed in<EMAIL_ADDRESS>


Add a Codacy badge to README.md

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         128    128
=====================================
  Hits          128    128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b16a1...67abb12. Read the comment docs.


Embedded proxmox exporter

Request
Integrate this with Grafana Agents
https://github.com/prometheus-pve/prometheus-pve-exporter
Use case
Added monitoring capabilities.

hey there yes, still interested just got side tracked with some things, hopefully make some progress here soon.

Hiya, just wondering how far through this you'd got? I'd be interested in this functionality for Grafana Alloy, I don't know much about how the agents are coded but I'd be interested in contributing towards your repo if I find the time.


refactor: add index file and id to fe data

添加了 index.json 文件，包含所有的数据文件路径
为 fe 数据文件添加了 id 字段，可用于前端跳转索引

Codecov Report

Merging #44 into master will increase coverage by 0.2%.
The diff coverage is 22.22%.

@@            Coverage Diff            @@
##           master      #44     +/-   ##
=========================================
+ Coverage   29.67%   29.87%   +0.2%
=========================================
  Files          17       17
  Lines         401      405      +4
  Branches       18       18
=========================================
+ Hits          119      121      +2
- Misses        282      284      +2

Impacted Files
Coverage Δ

app/schema/table.ts
55.55% <ø> (ø)
:arrow_up:

app/schema/table_donation.ts
40% <0%> (ø)
:arrow_up:

app/schema/table_travel_hotel.ts
40% <0%> (ø)
:arrow_up:

app/schema/table_clinic.ts
40% <0%> (ø)
:arrow_up:

app/schema/table_hospital.ts
40% <0%> (ø)
:arrow_up:

app/schema/table_logistical.ts
40% <0%> (ø)
:arrow_up:

app/service/shimo.ts
25% <50%> (+1.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2404fad...80834d7. Read the comment docs.


WIP: Fix varian reader memory bugs

See #430
For reference on misaligned access: https://stackoverflow.com/questions/44745953/correctness-of-misaligned-access-in-c
For reference on unsigned integer sizes: https://en.cppreference.com/w/cpp/language/types

I think the ComponentType is not the problem, but instead that I miscalculated the i += 4 in the loop and it's an off-by-one error trying to write an element after the array, i.e. UB.
Adding a conditional check may or may not affect performance. I've gotten results of 1.1x faster (gcc), exactly equivalent (gcc) and 1.2x slower (clang). See for yourself https://quick-bench.com/q/roJudMNw92oObliax_nMYgg75b8

Now only the xmlparse.c from ITK is giving errors:
212: /Users/andreas/Projects/ITK/Modules/ThirdParty/Expat/src/expat/xmlparse.c:4218:12: runtime error: left shift of<PHONE_NUMBER>741598797 by 5 places cannot be represented in type 'unsigned long'
212: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/andreas/Projects/ITK/Modules/ThirdParty/Expat/src/expat/xmlparse.c:4218:12 in
212: /Users/andreas/Projects/ITK/Modules/ThirdParty/Expat/src/expat/xmlparse.c:4218:18: runtime error: unsigned integer overflow:<PHONE_NUMBER>1346387264 +<PHONE_NUMBER>4885702730 cannot be represented in type 'unsigned long'
212: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /Users/andreas/Projects/ITK/Modules/ThirdParty/Expat/src/expat/xmlparse.c:4218:18 in
212:
212: Error per Pixel = 0
212: MSE = 0
212: PSNR = infdB
212: QI = 1
212:
212: Error per Pixel = 0
212: MSE = 0
212: PSNR = infdB
212: QI = 1
212:
212: Error per Pixel = 0
212: MSE = 0
212: PSNR = infdB
212: QI = 1
212:
212:
212: Test PASSED!
1/1 Test #212: rtkVarianTest ....................   Passed    3.47 sec

Thanks. I tested it on my mac and it seems to have fixed the bug. Can you squash all the commits in one and prefix the message with "BUG:"? It would be nice to add "Fixes #430" after a blank line to have the issue automatically closed.

Thanks @agravgaard !


Use build release

Changes

Use release.yaml from build github release
Replace manifestival/controller-runtime-client with  manifestival/client-go-client

Fixes https://github.com/shipwright-io/operator/issues/184

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[ ] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
None

@adambkaplan I am tryijng to move from manifestival/controller-runtie-cient to maifestival/client-go-client, hoping it handling the server side apply
hiweer the tests are not working unfortenately on envtest.
Do you have any idea why envtest is not initlialzing with client-go?

From Refinement, nothing to do here, and it might be fixed by another PR.


Type api

This will be the "engineering" branch, i.e. by the time we merge I want it to be in good enough shape to be usable in a library.

This will be the "engineering" branch, i.e. by the time we merge I want it to be in good enough shape to be usable in a library.

FWIW, I'm not sure this is the best approach. The whole repo is pre-release. We might as well take this work, do the minimum possible such that:

it compiles
the tests pass
gaps & defects are clearly marked with comments or warning-generating code

Then merge it to master.
In other words, master should be the point of collaboration.

OK, makes sense. I'll fix the last few big items (like error remaining in code) and then we cen reviiew & merge


#4793: Implement ResnetBlock2D using ttnn for stable_diffusion model

This PR contains the resnet block 2d sub-module implemented using ttnn for the stable diffusion model.

CI Link,
[post-commit] Run all post-commit workflows Link


fix: do not push conan-cache after template cleanup

Codecov Report

Merging #13 (c11de00) into main (1d3592d) will decrease coverage by 77.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #13       +/-   ##
==========================================
- Coverage   77.77%   0.00%   -77.78%
==========================================
  Files           3       3
  Lines          36      23       -13
  Branches       19      14        -5
==========================================
- Hits           28       0       -28
- Misses          7      23       +16
+ Partials        1       0        -1

Flag
Coverage Δ

Linux
0.00% <ø> (-37.04%)
:arrow_down:

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

test/tests.cpp
0.00% <0.00%> (-100.00%)
:arrow_down:

test/constexpr_tests.cpp
0.00% <0.00%> (-100.00%)
:arrow_down:

src/main.cpp
0.00% <0.00%> (-42.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3592d...c11de00. Read the comment docs.


Support for tuya 3.4 devices

Hi,
I was trying to use your project to gather data from my smart plugs which are Tuya 3.4, but it doesn't seem like this project works with it (different payload format).
Would you consider adding support for it? I tried playing around but couldn't really get it to work.
The format is more or less documented in the python project https://github.com/jasonacox/tinytuya

Hi @davidfrickert,
thank you for opening issue.
This has been asked previously, eg here.
Thing is, that I don't have 3.4 device at my disposal, so I won't do anything about it.
PRs are always welcome.

understandable, i don't have enough expertise in this kind of stuff to know how to fix it, so I just built a simple python Webserver that uses the tinytuya module to communicate with my devices and adapted this project to call that service. seems to work fine for me !