Support pure NETSTANDARD (UWP)

Ideas stolen from #2053 (Fixed unit tests to pass in pure NETSTANDARD mode, though not activated).
This will allow pure Windows Store Apps to use NLog ver. 5 without depending on System.Threading.Thread (not available until NetStandard2_0). Will require a new NetStandard1_4 build that defines NETSTANDARD (but not NETSTANDARD1_3).
Little funny that UWP (NETSTANDARD1_4) doesn't support NETSTANDARD1_3 use of Thread, Mutex, Process, FileWatcher or Trace (Will compile but when used by project that targets the UWP platform, then it will not work).

Cool, but i'm not sure if this solves the UWP problem.

NLog NetStandard1_3 makes use of libraries not available for UWP (Trace, Process, Mutex, Thread, FileWatcher).
I don't know if it would make sense to only have a pure NetStandard1_4 (UWP) and NetStandard1_5 (Thread + Process + Environment + etc.)

Wouldn't it be more logical to fix netstandard 1.3 or add uwp10 instead of the netstandard 1.4?
Or are those libs used in netstandard 1.3 also not used in 1.5?

Wouldn't it be more logical to fix netstandard 1.3 or add uwp10 instead of the netstandard 1.4?

Well it seems NetStandard 1.4 is the first NetStandard-version that supports UWP. Don't know if there is a special TargetFramework that specifies NetStandard-mode supported by UWP ?

Just tested the local compiled NLog NetStandard1_3, and it works when writing to the following location:

Windows.Storage.ApplicationData.Current.LocalFolder.Path

And when using the current NLog 5.0 Beta6, then one get the following exception:

System.IO.FileSystem.Watcher, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.'

That should also work. Then NetStandard1_3 would be the pure build, that can be used by UWP (Only depending on basic libraries).

Any idea of the UWP10 framework gives compile errors instead of runtime?
Making exceptions just for UWP, sounds that we should create a UWP10 build.

Any idea of the UWP10 framework gives compile errors instead of runtime?

UWP App compiles fine, but gives runtime exception when trying to access/load the NLog library/functionality.

Making exceptions just for UWP, sounds that we should create a UWP10 build.

Not sure I understand. What exceptions are we talking about?

Not sure I understand. What exceptions are we talking about? NetStandard1_3 is now platform independent, and NetStandard1_5 depends on platform dependent libraries.

The NetStandard1_3 .
Any idea if a program in .NET 4.6 uses the .NET 4.5 or the NetStandard  DLL?

Any idea if a program in .NET 4.6 uses the .NET 4.5 or the NetStandard DLL?

I certainly hope it depends on NET4_5, as the NETSTANDARD is still very crippled until NetStandard2_0.

I certainly hope it depends on NET4_5, as the NETSTANDARD is still very crippled until NetStandard2_0.

Agree on that ;)

The NetStandard1_3 .

Still not sure I understand, about the exception thing. Is it bad to have two NetStandard-builds? And better to have a UWP_NetStandard1_3 build and a NetStandard1_5 build?
Anyways very satisfied with the changes in this PR independent of NetStandard1_3 becoming platform independent or not. The only difference between NetStandard1_3 and NetStandard1_5 is the ability to use file-watcher (And the environment-layout).

And better to have a UWP_NetStandard1_3 build and a NetStandard1_5 build?

Doubting about this. I think it's better to have indeed a UWP build currently.

Doubting about this. I think it's better to have indeed a UWP build currently.

So introducing a new NETSTANDARD_UWP that specifies that System.Threading and System.Process is not available?

@gtbuchanan & @304NotModified I have now added a new define NETSTANDARD1_3PLUS. It means NETSTANDARD1_3 with extra dependencies (non-UWP).
I have no clue (or maybe patience for) how to modify the build-configuration to make an UWP-NETSTANDARD1_3 build (Without the define NETSTANDARD1_3PLUS).
But maybe adding this new UWP-build-definition can be made in a new PR.

@gtbuchanan Would have preferred to make some kind of NetStandard1.3 build without reference to UWP or Uap10.0.

@304NotModified Have been able to show failing tests on Travis (Caused by NLog tests stealing Console-out). Not sure what is going on for the appveyor-build.

@304NotModified Have now made AppVeyor build fail without using ErrorActionPreference, but instead by returning the exitcode from dotnet test.

I think this is still WIP?

about the failing CallSiteLineNumberTests under netstandard. I was thinking I disabled them (skip in xunit), but maybe that's still in another branch

I think this is still WIP?

Nah just me trying to fix all the failing unit tests revealed in the Travis build, but it is probably better for another PR.

Would be nice of we could got appveyor working (by skipping tests on netstandard).

Would be nice of we could got appveyor working (by skipping tests on netstandard).

Yes but I think that is for a different PR. My guess is that they are failing because they run in release-mode, instead of debug-mode.

Could you also skip AssemblyVersionTests + ExtensionTests netstandard? Those are on the todo list. :) thanks! (i think that are the lasts to get appveyor succeeding)

Could you also skip AssemblyVersionTests + ExtensionTests netstandard?

Like I said before, they are not failing on NETSTANDARD. It is the NET4_5 build :)

Like I said before, they are not failing on NETSTANDARD. It is the NET4_5 build :)

oops sorry missed that

the failing ExtensionTests is because of the extra folder in bin. But maybe a bit out of scope for this PR ;)

Have added the missing dependency to the unit-testing-project, and changed how to lookup the full-path of SampleExtensions.dll.
Now extension dll loading is working for NetStandard1.5 on Travis,

Is this WIP?

Is this WIP?

Nope just stumbling around.

Heads up, I'm running into an issue building my app in Release mode. UWP appears to require a Runtime Directives file (rd.xml) file to define which types are accessed via reflection so they aren't stripped from the build.
I encounter the following unhandled exception when my code sets LogManager.Configuration in Release mode:

Exception thrown: 'System.Reflection.MissingMetadataException' in System.Private.Reflection.Core.dll
Additional information: 'System.Text.UTF8Encoding' is missing metadata.  I'm going to try to build rd.xml as I go to work through the errors.

@gtbuchanan Met the same challenge, seems NET Native is playing tricks with reflection. I have tried to resolve the exceptions without needing to update rd.xml.
Have you tried to use the NuGet-package generated by the appveyor-build (NLog.dll from Uap10.0 build) ?

Reviewed 15 of 37 files at r1, 48 of 60 files at r2, 7 of 10 files at r3, 1 of 1 files at r4, 4 of 5 files at r5, 6 of 8 files at r7, 2 of 2 files at r8, 7 of 8 files at r9, 1 of 1 files at r10.
Review status: 91 of 95 files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

src/NLog/project.json, line 138 at r10 (raw file):

        "System.Security.Principal": "4.0.1",
        "System.Threading.AccessControl": "4.0.0"
      },

x

src/NLog/project.json, line 140 at r10 (raw file):

S0436

src/NLog/Internal/ObjectGraphScanner.cs, line 92 at r10 (raw file):

                return;
            }

x

src/NLog/Internal/ObjectGraphScanner.cs, line 127 at r10 (raw file):

                catch (System.Exception ex)
                {
                    InternalLogger.Info(ex, "{0}Type reflection not possible for property {1}. Maybe because of .NET Native.", new string(' ', level + 1), prop.Name);

maybe we should move this to IsDefined as this is a helper already?
we should use also the generic one here I guess (see above)
type.IsDefined<NLogConfigurationItemAttribute>

src/NLog/Internal/TargetWithFilterChain.cs, line 119 at r10 (raw file):

                try
                {
                    // Check if hack used by LoggerImpl.Write() is possible

maybe a good candidate to move to StackTraceUsageUtils?

src/NLog/LayoutRenderers/NLogDirLayoutRenderer.cs, line 61 at r10 (raw file):

            var location = ReflectionHelpers.GetLocation(assembly);
            if (string.IsNullOrEmpty(location))
                location = new Uri(ReflectionHelpers.GetCodeBase(assembly)).LocalPath;

aren't those ReflectionHelpers c# extensions?

tests/NLog.UnitTests/LogManagerTests.cs, line 537 at r10 (raw file):

                Parallel.ForEach(r, a =>
                {
                    var res = c.Resolve<ClassA>();

I'm not sure if we test the same functionality in the new test? This was threadsafety in combination with DI (As far as I remember)

tests/NLog.UnitTests/Internal/EnumHelpersTests.cs, line 42 at r10 (raw file):

namespace NLog.UnitTests.Internal
{
    public class EnumHelpersTests : NLogTestBase

I guess this is to allow running in parallel? If so, please add this as remarks thanks!

tests/NLog.UnitTests/Internal/PlatformDetectorTests.cs, line 39 at r10 (raw file):

namespace NLog.UnitTests.Internal
{
    public class PlatformDetectorTests : NLogTestBase

idem remarks

tests/NLog.UnitTests/Internal/StringBuilderExtTests.cs, line 41 at r10 (raw file):

namespace NLog.UnitTests.Internal
{
    public class StringBuilderExtTests : NLogTestBase

idem remarks

Comments from Reviewable

Great work! Some small questions!

Review status: 91 of 95 files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

Comments from Reviewable

Thanks. Have tried to reply the questions.

Comments from Reviewable

Review status: 91 of 95 files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

src/NLog/project.json, line 138 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
x

Removed the warning.

src/NLog/project.json, line 140 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…

S0436

Removed the warning.

src/NLog/Internal/ObjectGraphScanner.cs, line 92 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
x

?

src/NLog/Internal/ObjectGraphScanner.cs, line 127 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
maybe we should move this to IsDefined as this is a helper already?
we should use also the generic one here I guess (see above)
type.IsDefined<NLogConfigurationItemAttribute>

Well I like the InternalLogger-part.

src/NLog/Internal/TargetWithFilterChain.cs, line 119 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
maybe a good candidate to move to StackTraceUsageUtils?

I have little experience with StackTrace. And how to cater for calling the StackTrace constructor in a nested method. I would prefer that Activator.CreateInstance-hack was not used at all :)

src/NLog/LayoutRenderers/NLogDirLayoutRenderer.cs, line 61 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
aren't those ReflectionHelpers c# extensions?

Yes better fix that :)

tests/NLog.UnitTests/LogManagerTests.cs, line 537 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
I'm not sure if we test the same functionality in the new test? This was threadsafety in combination with DI (As far as I remember)

The original bug was about creating new loggers from multiple threads, while another thread is working on updating the NLog configuration. At least when looking a the callstack.

tests/NLog.UnitTests/Internal/EnumHelpersTests.cs, line 42 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
I guess this is to allow running in parallel? If so, please add this as remarks thanks!

Yes unit tests not using NLog LoggingConfiguration, doesn't need to inherit from NLogTestBase.

tests/NLog.UnitTests/Internal/PlatformDetectorTests.cs, line 39 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
idem remarks

Yes unit tests not using NLog LoggingConfiguration, doesn't need to inherit from NLogTestBase.

tests/NLog.UnitTests/Internal/StringBuilderExtTests.cs, line 41 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
idem remarks

Well the NLogTestBase is mostly for resetting NLog-LoggingConfiguration. And in XUNIT2 protect against running multiple NLog-LoggingConfigurations in parallel. Tests not using the NLog-Core-Engine is allowed on run in parallel.

Comments from Reviewable

src/NLog/Internal/TargetWithFilterChain.cs, line 119 at r10 (raw file):
Previously, snakefoot (Rolf Kristensen) wrote…
I have little experience with StackTrace. And how to cater for calling the StackTrace constructor in a nested method. I would prefer that Activator.CreateInstance-hack was not used at all :)

You convinced me not to use the StackTrace constructor in UWP Apps, so skipped the validation. Now callsite only works using the NLog.Fluent callsite-attributes.

Comments from Reviewable

Reviewed 1 of 8 files at r9, 16 of 17 files at r11.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

src/NLog/Internal/ObjectGraphScanner.cs, line 92 at r10 (raw file):
Previously, snakefoot (Rolf Kristensen) wrote…
?

sorry X is also the shortcut of next file in reviewable.io ;)

src/NLog/Internal/ObjectGraphScanner.cs, line 127 at r10 (raw file):
Previously, snakefoot (Rolf Kristensen) wrote…
Well I like the InternalLogger-part.

sure but we could add that inside prop.IsDefined? (maybe also as warn?) We only miss the level indent I guess

src/NLog/LayoutRenderers/CallSiteLineNumberLayoutRenderer.cs, line 87 at r11 (raw file):

                if (logEvent.Properties.TryGetValue("CallerLineNumber", out callerLineNumber) && callerLineNumber is int)
                {
                    linenumber = (int)callerLineNumber;

any idea of as is more efficient here, even with ints? (boxing)

src/NLog/Internal/TargetWithFilterChain.cs, line 119 at r10 (raw file):

I have little experience with StackTrace. And how to cater for calling the StackTrace constructor in a nested method.

true about that. Missed that one.
I think fluent is good enough for now indeed

Comments from Reviewable

src/NLog/LayoutRenderers/CallSiteLineNumberLayoutRenderer.cs, line 87 at r11 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
any idea of as is more efficient here, even with ints? (boxing)

Usually "as" is much faster than "is". But since integer is a valuetype, then it has restrictions. I just wanted the code to be simple.

Comments from Reviewable

src/NLog/Internal/ObjectGraphScanner.cs, line 127 at r10 (raw file):
Previously, 304NotModified (Julian Verdurmen) wrote…
sure but we could add that inside prop.IsDefined? (maybe also as warn?) We only miss the level indent I guess

Don't like use of the InternalLogger in the pure library methods. Might introduce unexpected noise/exceptions at an unwanted location.

Comments from Reviewable

PS: fixed also SL build with 659a7990b65ad8f51f0239d3176f12d093ccbe7f

https://github.com/snakefoot/NLog/pull/1

@304NotModified Have applied the fixes, and now there is a green AppVeyor-build

@snakefoot could you please change the version to beta07 (appveyor.yml)? Then it's easier to test (because beta06 is already on nuget)

@304NotModified Have updated project.json with new version number (beta07)

thanks @snakefoot !
Works well for me on asp.net core.

Reviewed 5 of 5 files at r12, 3 of 3 files at r13, 1 of 1 files at r14.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

src/NLog/Internal/ObjectGraphScanner.cs, line 127 at r10 (raw file):
Previously, snakefoot (Rolf Kristensen) wrote…
Don't like use of the InternalLogger in the pure library methods. Might introduce unexpected noise/exceptions at an unwanted location.

OK

Comments from Reviewable

\0/

summary of what has been changed in support:
Layout renderers:

${AssemblyVersion} - netstandard 1.5
${machinename} - now also netstandard 1.3 (was previously 1.5+)
${NLogDir} - netstandard 1.5

targets:

OutputDebugString  - netstandard 1.3

updated https://github.com/NLog/NLog/wiki/platform-support

@304NotModified These bonus updates are also included:

${windows-identity} : Enabled for NetStandard 1.3+
Auto flush on shutdown : Enabled for NetStandard 1.5+
File Archive Mutex : Enabled for NetStandard 1.3+
Mutex File Appender : Enabled for NetStandard 1.3+

Could you please update this one? https://github.com/nlog/nlog/wiki/platform-support

@304NotModified Completed. The feature list looks very complete. Seems only a fully working GetCurrentClassLogger() is missing.
Guess one could consider to use the StackTrace-constructor-hack for NETSTANDARD1_3PLUS to capture the calling class.

That would be nice. I prefer the hack over nothing. But the hack isn't working on all devices?

@304NotModified StackTrace-constructor-hack will not work for .NET Native, not sure whether the hidden (internal) constructor works on non-windows platforms. Think it is better leave the possible implementation of the hack to someone who is more motivated for fixing and testing it.
Or just wait for Q3 2017 where NetStandard 2.0 is released :)


Added dark data banner

Added a banner image of "dark data".

Coverage increased (+0.35%) to 70.77% when pulling 364bf0224462432ec98d75d965c9ee4d869b8b74 on dark-data-banner into 88b37d31bebcd5cb3bf7c91551a44956762f19f5 on master.

Coverage increased (+0.35%) to 70.77% when pulling 2e716756ed0e827e6e97e754a9bfe0c1e3734e69 on dark-data-banner into 88b37d31bebcd5cb3bf7c91551a44956762f19f5 on master.

Coverage increased (+0.35%) to 70.77% when pulling 2e716756ed0e827e6e97e754a9bfe0c1e3734e69 on dark-data-banner into 88b37d31bebcd5cb3bf7c91551a44956762f19f5 on master.

@zhangce Should we merge and deploy this?

I think it looks good.
Ce
On Wed, May 27, 2015 at 10:56 PM, Zifei Shan<EMAIL_ADDRESS>wrote:

@zhangce https://github.com/zhangce Should we merge and deploy this?
—
Reply to this email directly or view it on GitHub
https://github.com/HazyResearch/deepdive/pull/307#issuecomment-106163968
.

@zhangce Do we want to link this banner to somewhere? Currently it links to nowhere.

@zhangce https://github.com/zhangce Do we want to link this banner to
somewhere? Currently it links to nowhere.

I think it is OK because it is a general description of DD.
Ce
On Thu, May 28, 2015 at 1:56 AM, Zifei Shan<EMAIL_ADDRESS>wrote:

@zhangce https://github.com/zhangce Do we want to link this banner to
somewhere? Currently it links to nowhere.
—
Reply to this email directly or view it on GitHub
https://github.com/HazyResearch/deepdive/pull/307#issuecomment-106200742
.


Default version can't be changed after making invalid version the default

I registered a Galaxy workflow using the .dockstore.yml procedure. I then removed the leading forward slash in primaryDescriptorPath and testParameterFiles and pushed this to another branch. Curiously without forward slashes I see the tool ids and DAG for this workflow, even though this seems to be invalid (see screenshot, where the error message is also missing .ga as valid extension for Galaxy workflows). With leading forward slash the workflow appears to be valid, but tools ids and DAG can't be displayed. If I now set the default version to the invalid workflow I can't change it back to the valid workflow.

┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Sprint: Backlog
┆Issue Number: DOCK-1601

Hi,
I can confirm that the error message should list .ga as an extension for Galaxy workflows.
I cannot reproduce the error where the default version cannot be changed after making the invalid version default.
Do you happen to have a screenshot of the error message?

There's no error message, the action had just disappeared from the actions menu. Which is now there again, but I did push a version with a leading slash to that branch.

Could it be possible that you navigated to the public version of the workflow which only has view as an option?
i.e. https://dockstore.org/workflows/github.com/mvdbeek/workflow-testing-repo/COVID-19 variation analysis on Illumina metagenomic data:no_forward_slash?tab=versions

That could be what happened, yes.

(discussion continues at https://github.com/galaxyproject/galaxy/issues/10359 )


Suite stops on failure after adding this printer

I really like this test printer but the only issue I have so far is that as soon as a test fails the whole suite aborts. This behaviour seems to happen only with this printer.
Is this intentional or is it a bug?

Hi, yeah... it's a bug. I will fix it so that this printer is in line with the traditional PHPUnit printer.

That would be great, thanks!

This has been fixed in 1.2. Thank you for your input!


How can I get mongo running status?

Is there a metric like mysqld_exporter's mysql_up to express mongo's running status.

There are mongodb_instance_uptime_seconds and mongodb_repl_member_health


Use the "hipchat_announce" option for deciding whether to send messages

Fixes https://github.com/hipchat/hipchat-rb/issues/107

Coverage remained the same at 100.0% when pulling 86302c9ed9e3c9c2509fb5098abf5f7ff91558b0 on arkadyan:hipchat_announce into f4cd2010d371277ff00bc364edfd61170c0bd79d on hipchat:master.


[Design] Tshirt

Tshirt design adjustments and Back side text addition

Deisgns and Mockup can be found in the following Google drive url
https://drive.google.com/drive/folders/1boxGQzuYQa-8GCmEWIilRUzi5YY6gXNz?usp=sharing


Low priority: Add fractional bond orders to SMIRFF

Eventually, we need to add capacity to SMIRFF for fractional bond orders, which we will obtain from a semi-empirical QM calculation. This will be used downstream eventually (after this summer) for parameter interpolation.

Suggested FFXML format:
<HarmonicBondForce length_unit="angstroms" k_unit="kilocalories_per_mole/angstrom**2" fractional_bond_order="interpolate-linear">
   <Bond smirks="[#6:1]-[#6:2]" length1="1.526" k1="620.0" length2="1.426" k2="820.0" length3="1.326" k3="1020.0"/>
   ...
</HarmonicBondForce>

So, an interesting question is whether we would allow fractional bond orders only for SMIRKS matching ~ bond types or whether we would allow them for any. Presumably it would be for any, I suppose, as you have here. Otherwise the concern would be that the semiempirical calculation would give us a fractional bond order but the previous SMIRKS would prevent us from using it... Is that what you're thinking?
@cbayly13 , does this look suitable?

We want to exclude triple bonds so the form I would suggest is:
[#6:1]!#[#6:2]
which is asking for a carbon-carbon bond of any order except triple, thus allowing double, single, and aromatic. Most useful conjugation is across CC, CN, and CO bonds so I would want to start with
[#6:1]!#[#6:2]
[#6:1]!#[#7:2]
[#6:1]~[#8:2]
and see how far we can get with that. In the last case only a "~" is needed because singlet state C#O does not occur in pharmaceutically relevant molecules.

In principle triple bonds would not be ruled out, because they can conjugate too, but I am expecting a lot of finessing needed to map:
single<-->conjugatedSingle<-->aromatic<-->conjugatedDouble<-->double
correctly, which is where all atom-typed ligand force fields fall down.

@jchodera - for reasons I can explain in more detail when I see you in person later this week, we may now want to do this sooner rather than later (in brief, it has to do with trying to put parm@frosst in SMIRFF format, which will be MUCH MUCH easier for specific types of systems if we have this).
The format above looks reasonable to me for bonds but may require notation adjustments. Specifically, for torsions, we use k1, k2, k3, (periodicity1, periodicity2,...) etc. to pick up multiple torsion terms which apply to the same SMIRKS. This probably means the choice of k1, k2, k3 for bonds is less than ideal since the numbering would mean something different there than it does for torsions.
Would you be happy with k_order1, k_order2, etc. instead?
This would also mean that for torsions, we could accommodate multiple torsion parameters that apply to different bond orders (whereas, as currently proposed, you'd have a name clash between k1 for the first torsional term and k1 for the term applying to bond order 1). For example, right now we have
<PeriodicTorsionForce phase_unit="degrees" k_unit="kilocalories_per_mole">
<Proper smirks="[#6X4:1]-[#6X4:2]-[#8X2:3]-[#1:4]" idivf1='1' periodicity1="3" phase1="0.0" k1="0.16" idivf2="1" periodicity2="1" phase2="0.0" k2="0.25" id="t0006" parent_id="t0002"/> <!-- HO-OH-CT-CT from frcmod.Frosst_AlkEthOH -->
...

and this could extend to
<PeriodicTorsionForce phase_unit="degrees" k_unit="kilocalories_per_mole" fractional_bond_order="interpolate_linear">
<Proper smirks="[#6X4:1]-[#6X4:2]-[#8X2:3]-[#1:4]" idivf1='1' periodicity1="3" phase1="0.0" k1_order1="0.16" k1_order2="0.25" idivf2="1" periodicity2="1" phase2="0.0" k2_order1="0.25" "k2_order2"="0.0" id="t0006" parent_id="t0002"/> <!-- HO-OH-CT-CT from frcmod.Frosst_AlkEthOH -->

(Note that I made up the k1_order1 and k2_order2 values out of thin air for illustration purposes.)
If this looks reasonable, I expect I can actually implement this myself without significant difficulty so we can try it out.

Other than changing "order" to "bondorder" for clarity, this proposal
sounds fine!

How are we going to evaluate the bond orders, though? Are we planning to
take them from the OEMol for now, or should we add bond order to the
Topology at this point?

How are we going to evaluate the bond orders, though? Are we planning to
take them from the OEMol for now, or should we add bond order to the
Topology at this point?

Well, we'll get the bond orders from an OEMol. But, right now createForce only works with the Topology so I think this means that either:

we need to update the Topology to include bond order, or
createForce will need major updates/re-architecting to be able to pull the bond orders from the stored reference molecules in the Topology class

It seems like the first would be much better and doesn't look like it should be much work -- we just need self._bondorders added to Topology to track the order of each bond in self._bonds, it seems. I'd update generateTopologyFromOEMol to store this info. Then this would be used in createForce to pick which parameters to use when actually assigning from the FFXML.
Sound reasonable?
Unrelatedly, I updated the above API proposal in my post to use your terminology of "bondorder" rather than "order" so I'd put this in in the right way.

I would just add to the _Topology class we use inside of forcefield.py for now. We already use this "augmented" topology instead of the OpenMM Topology as the argument to createForce, so this is the natural place to extend things for now until we can get them into OpenMM.
We do have an open OpenMM issue on bond orders that you should probably comment in too.

Also, let's standardize fractional_bond_order to fractional_bondorder too.

Agreed on both of those, @jchodera .

One other issue I forgot to bring up earlier, @jchodera - we think we need to extend the SMIRFF format slightly to add the option to kekulize molecules before assigning parameters (default False, as at present).
We're thinking of putting parm@frosst into SMIRFF format sooner rather than later, and two things will make it take a lot less human time: first, kekulizing molecules before assigning parameters, and second, having bond orders (this has to do with some issues relating to how to handle aromatic molecules that still have strong single/double character and ALSO handle aromatic molecules which do not). For Smarty/Smirky/etc., we're of course not kekulizing, but this will help Christopher in putting parm@frosst into this format.
What about adding this as a tag in the parameter file, i.e. something like
<SMIRFF kekulize="True">
...
</SMIRFF>

where if kekulize is False or unspecified, the current behavior would be retained?

Setting global parameters like kekulize in the <SMIRFF> tag sounds fine. This could instruct ForceField to copy and kekulize all of the molecules it is asked to parameterize.

I should probably also deal with #42 at the same time and put in a version attribute.

For the record, OpenEye support reports we can retrieve partial (Wiberg) bond orders from i.e. AM1-BCC calculations done with their tools, such as via this code snippet:
mol = OEGraphMol()
    ifs = oemolistream(argv[1])
    while OEReadMolecule(ifs,mol):
        if OEAssignPartialCharges(mol, OECharges_AM1BCCSym):
            for bond in mol.GetBonds():
                print (bond.GetData("WibergBondOrder"))

This may or may not be supported in future releases (they're putting in a feature request to retain it and I'll update with the outcome of that) but it's there for now and we can use it for this.

Are you going to add the support for this to forcefield.py, @davidlmobley?

Yes, @jchodera . Could be I'll get to work on this while traveling back on Friday, though more likely it'll be early next week. Since I can see how to do it easily enough, your time will be better spent on the property calculation things.

@jchodera - any thoughts on whether we should REQUIRE floating point bond orders, or fall back to something else (i.e. bond orders as integers if the user provides an OEMol and doesn't want to do a charging calculation) if the user insists on not doing an AM1 calculation?
I'm thinking the simplest and probably best behaved might be to populate the bond orders using bond.GetOrder() for regular OEMols if there are no wiberg bond orders (no AM1 calculation has been done), otherwise populate with the Wiberg bond orders. Probably I should have an optional argument to the charging calculation which would override this so we can have it retain integer orders when we want it to.
Thanks.


Allow optional helpers.php file

Proposal
I suggest enabling Jigsaw to check if a helpers.php file exists in the project root.
If true, merge the arrays in config.php and helpers.php.
If false, nothing breaks (similar to how the blade.php file is optional).
Reason
Jigsaw's flexibility allows us to easily add any helper in the config file.
This is great, but generally a config file should consist of constant/static values. It would make sense to put helper functions in a separate file.
Users should have the option to use a separate file, but still be free to put everything in a single file if they prefer it that way.

I'd like to work on this one.

@fawzanm Wonderful, let me know if you need any help!

@damiani currently jigsaw loads the config files to an array in ConfigFile.php. We can either have a separate file to check for custom config files or have an additional method in the ConfigFile.php itself.
I think we should have a separate class and use that in the ConfigFile to lookup for the extra config items. Can I ge tyour thoughts on this?

@damiani currently jigsaw loads the config files to an array in ConfigFile.php. We can either have a separate file to check for custom config files or have an additional method in the ConfigFile.php itself.
I think we should have a separate class and use that in the ConfigFile to lookup for the extra config items. Can I ge tyour thoughts on this?

@damiani I am thinking of moving in this direction make more sense.
We can take an optional second parameter (an array of file names) in the ConfigFile constructor and merge them to the config items.
Can I have your input on this?

Note: I already made a PR for this in the past tightenco/jigsaw#264
Maybe if we could get input from @damiani on what could be improved here we could close both this issue and my PR

@raniesantos You are right, thanks for calling my attention to that PR.
@fawzanm Turns out that PR did close this issue... thanks for offering to pick this up, and if you're interested in tackling another Hacktoberfest issue, let me know and I'll help out as needed!

@damiani any other good first time issues available? :)


Use Glide instead of Picasso to increase Performance, available memory... etc

Picasso and Glide has almost same methods (especially method names!), but Glide use RGB_565 so save image memory.
check out this document and publish new version.
thanks to nice library!

Thanks for the suggestion. Have not yet explored glide fully, can you edit this pull request to merge to develop branch? I'll merge to master in some time for a new version.

Ok, but Github doesn't support change target branch, so i close this pull request and send request again.


Added Rundeck Helm Chart.

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/assign @mgoodness

A few high-level comments:

Move this chart to incubator instead of stable.
Change from deployment to statefulset, instead of defining PVs directly.
This chart should work out of the box without requiring the user to pre-load a kubernetes secret.

Why the request to move this to incubator?  I thought incubator was when people used non-stable apis?

@dcwangmit01 As far as I know it's not a requirement for charts to go into incubator first.  I submitted a chart back in April directly to stable.
As far as your other points I agree they should be addressed.  If the author does not have time to address them it's possible this chart could go into incubator first, but preferably the issues would be address and we would get it directly into stable.  I'll leave that up to @Deepak-Routray .
I'm also not sure why this should be a statefulset.  Deployments+PVCs are a perfectly normal way to handle persistent data.  Statefulsets are normally used in clustering situations where you want stable pod names.  In this charts situation in most cloud providers replicaCount should always be 1.
As for the helm install . needing to work 100% agree.
I'll make a pass through and review the chart.

I must agree with @dcwangmit01 about statefulset being ideal here.
ref: https://stackoverflow.com/a/41707491
The key differentiator here is the volumeClaimTemplates mechanism, which is far superior to the component-based PV+PVC pattern I usually see in stateful deployment charts.  Consider the need to go past n=1. Statefulsets do this far more gracefully than do stateful Deployments.

The volumeClaimTemplates will provide stable storage using PersistentVolumes provisioned by a PersistentVolume Provisioner.

docs: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/
excerpt:
Using StatefulSets

StatefulSets are valuable for applications that require one or more of the following.

Stable, unique network identifiers.
Stable, persistent storage.
Ordered, graceful deployment and scaling.
Ordered, graceful deletion and termination.
Ordered, automated rolling updates.

@josdotso Of the benefits of statefulsets I'm not sure which if any of those are relevant to Rundeck.  The main question would be how does Rundeck do clustering.  As far as a replicaCount=1 service is concerned you should see no difference.  The stable/jenkins chart which is very similar to Rundeck uses a Deployment.
Certainly a volumeClaimTemplates is useful if you need the pod to come back with the same volume it originally was running with.  This can be very useful in a clustering situation.
It would be great if someone was familiar with Rundeck clustering and what is needed to support it.
A quick glance at Rundeck's documentation on clustering shows they used a shared storage so in this case PVC are not actually viable and you would use a shared NFS, Database, Object store, etc.  Which certainly looks more like a deployment and not a statefulset.
http://rundeck.org/2.7.2/administration/scaling-rundeck.html#clustering-and-horizontal-scaling

@sstarcher @dcwangmit01 @josdotso Thanks all for sparing time for reviewing the PR and providing valuable feedback. My sincere apologies for delay in the response.
Unfortunately I deleted the source repository and need to create a new PR with review comments from all of you incorporated. Would add all of you as a reviewer and retain this PR to maintain history. Few individual review comments have my response inline.
We can use this PR or the new PR for any further reviews/feedback. Thanks Again.

@dcwangmit01 @josdotso
Agreed on statefulset to have more cleaner design with other benefits. Would test service with multiple replication to reap benefits of the same.

@dcwangmit01
Would keep it in stable for now. I have removed dependency on secret and chart can be deployed in standard way. Moreover Migration to StatefulSet is done as well. Hope that is fine.

@sstarcher @dcwangmit01 @josdotso
Follow up PR is https://github.com/kubernetes/charts/pull/6641
Can you please review the changes?

any update on this chart? we're interested on having Rundeck on k8s, would be nice if you guys finally implement it.
thanks!

@adrianlop Hi Adrian. Thanks for the interest. This chart is now active on PR 7335 (https://github.com/helm/charts/pull/7335 ). Unfortunately I am no more able to update this PR. So closing this out very soon. Request you to review and follow PR 7335.
Thanks,
Deepak


Only support compressed reads if the compression setting is present

PR #8106 was created with the assumption that no blob is larger than 256 MiB. Due to #7852 we have checking for writes of blobs larger than that limit, but we didn't have checking for reads of such large blobs: in theory, we could be reading these blobs every day but we just don't happen to write the blobs for some reason.
Therefore, we now add a warning for reads of such large blobs as well.
To make deploying compression less dangerous, we therefore only assume a blob is compressed if the compression setting is present in the config. This also means that we can't back out of compression once we enabled it.
Part of https://github.com/neondatabase/neon/issues/5431

I'd like most of the changes of this PR to be temporary: that is, eventually the compression setting should disappear and we assume any blob larger than 256 MiB must be a compressed blob. That change can happen however months in the future.

why is PageServerConf::image_compression an Option?

That's what the option type is for, to indicate None. But of course it can be also inlined.

we'll have to support decompressing layers with compressed blobs into perpituity.

yes, this PR is only meant for a temporary period until compression is rolled out everywhere. at that point, I'd like to revert most of it. Of course, for the transition period, and maybe also beyond, it might make sense to have the ability to easily revert the config setting.
The risk is that we might be reading 256 MiB large blobs in production right now, and on deploy of current main we yield corrupted data. This PR is just to avoid that situation.
Maybe both of your suggestions could be combined, and one could change ImageCompressionAlgorithm to:
enum ImageCompressionAlgorithm {
    DisabledNoDecompress,
    Disabled,
    Zstd { level: Option<i8> },
}

ImageCompressionAlgorithm::DisabledNoDecompress would interpret any blobs larger than 256 MiB as uncompressed, while ImageCompressionAlgorithm::Disabled would still decompress them. DisabledNoDecompress would be the default at the start, for a couple of weeks until compression is rolled out. Then, we can switch to Zstd or Disabled as the default, and remove the DisabledNoDecompress variant.
How does that sound?

Ok, thanks for clarifying.
I think it has to go like so:

roll out software that guarantees we don't write new blobs >= 256MiB
then do a full scrubber run, ensuring that all blobs are < 256MiB
invariant now: all length fields have the LEN_COMPRESSION_BIT_MASK bits zeroed, so, we can use them for compression
start shipping/enabling code that interprets the LEN_COMPRESSION_BIT_MASK

But let's take that discussion into Slack.

Regarding this PR, I now understand its importance and we should definitely merge it before the code from #8106 hits prod, because that would mean doing (4) before invariant (3) is established.


Oasis not working

It seems like Olive Innovations no longer support free accounts, or at least the link oasis.oliveinnovations.com doesn't work any more, and there is no new link to be found on their site. So, there seems to be no way for new users (and existing?) to use MFA :(

@bigpjo Hi Paul, this question is for you ;)

Hi.
Sorry the documentation should be updated.
Oasis was moved to its own domain.
Available at www.oasis2fa.com
It is still free for 10 users per month.
Enjoy

Ah, great. Thanx 😊👍

Documentation updated in next release. @bigpjo, I wasn't able to find the link to download the "Gateway application", for people who want to sync their Active Directory with Oasis when using Myrtille in Enterprise mode. Do you still have such feature?

Hi cedric.
Yes we are updating our site. Will be there within next 7 days
On Fri, 18 Sep 2020, 18:46 cedrozor<EMAIL_ADDRESS>wrote:

Documentation updated in next release. @bigpjo https://github.com/bigpjo,
I wasn't able to find the link to download the "Gateway application", for
people who want to sync their Active Directory with Oasis when using
Myrtille in Enterprise mode. Do you still have such feature?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cedrozor/myrtille/issues/224#issuecomment-695000631,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGEAPZOFXKQXT4HX6WV3BJ3SGOMIFANCNFSM4PEUBJJQ
.


I want to add two buttons problem from codeforces

Sure go for it✌

I want to contribute @tanus786. Please assign me so that I can complete hacktoberfest 🙏.

@SanjoySaha24  kindly assign me this,I want to contribute to this

Accept my pull request 🙏 @tanus786.


Ability to read in models from Papyrus, Ecore, Umlet, RSA etc.

Originally reported on Google Code with ID 420

It would promote the use of Umple to be able to process models written in various XML
formats and other formats so that they could be used in the context of Umple.
One suggestion is that any attempt to process a file, where that file is detected as
something other than Umple (because of the presence in the first line of standard XML
tags etc.) would pass it over to a separate processor that would translate it to Umple,
which would then be parsed as normal.
Ideally at the very least, the formats that Umple produces (e.g. score) could be read.
UML constructs not recognized could be ignored. In an agile manner, we could just start
with finding classes, attributes, generalizations and associations.
Test cases could include various files found on the Internet or in specs for UML.
Formats to input could include Papyrus XMI, Umlet, Ecore, RSA XMI, etc.

Reported by @umple on 2013-09-17 12:54:02

Instructions for taking a Papyrus model and exporting it to Umple:

Change directory to "Umple"
Copy a Papyrus model, for example, cp cruise.umple/test/cruise/umple/compiler/PapyrusImport_ClassAssociationManyToMany.uml.txt ~/Downloads/PapyrusImport_ClassAssociationManyToMany.uml
Run a full build against Umple project
Copy Umple cli jar file, for example cp dist/umple-<IP_ADDRESS>60.78bb27cc6.jar ~/Downloads
Run Umple cli: java -jar ~/Downloads/umple-<IP_ADDRESS>60.78bb27cc6.jar -i ~/Downloads/PapyrusImport_ClassAssociationManyToMany.uml

Step 5 will generate an Umple file named PapyrusImport_ClassAssociationManyToMany.uml.ump, which is the processed Umple file:

class Teacher
{
	* -- * Student;
}

class Student
{
	* -- * Course;
}

class Course
{
}

They don't need to run a full build ... they just need to download Umple, but yes, thanks for this info. We need to get this into the user manual too.

Enhancing Scxml importer
The original Scxml importer couldn't parse "<raise>" tags, an additional parsing step was added to parse "<raise>" tags

Implementing Papyrus importer
Previously there was no Papyrus importer in Umple, a pr with unit tests and implementation was for it https://github.com/umple/umple/pull/1939/files.
It this pr, parsing class, attribute, association and generalization is covered.


 We should record only enough point for dataPoints of TimeSeries
To Reproduce
Running a master over 100 days.
Open  http://localhost:19999/metrics or open http://localhost:8081/api/v1/master/webui_metrics

We only use the latest 20 points of data.

Expected behavior
Open page in a second, but wait for minutes.
Urgency
High
Additional context
We should limit the size of TimeSeries#mDataPoints
public class TimeSeries {
  private final List<DataPoint> mDataPoints;
...
}

@tieujason330 can you help take a look this issue, thanks

Fixed by #13660 (thanks for @tieujason330 )
Closing this issue and feel free to re-open it if you still it happening.


Sha256 HTLC Support

Change hash function used for HTLCs from keccak256 to sha256.
This enables support for atomic swaps with Bitcoin, Litecoin, Cosmos, Polkadot, EOS, and a range of other chains that use sha256.
It also enables better interoperability with the Connext state channel infrastructure.
Also includes numerous test cleanups and documentation improvements.

@SilentCicero is this ready to review?

@adlerjohn yes, go for it.


[BUG] Get-PnPListItem -List $list not returning all fields on items when list has many fields

Reporting an Issue or Missing Feature
It looks like Get-PnPListItem does not return all fields on items when there are many fields in the list, when you fetch all list items by only providing the -List Parameter
ListA has 222 fields based on Get-PnPField -List $listA
ListB has 112 fields based on Get-PnPField -List $listB
$allItemsListA = Get-PnPListItem -List $listA
$singleListItemListA = Get-PnPListItem -List $listA -Id 104

$allItemsListB = Get-PnPListItem -List $listB
$singleListItemListB = Get-PnPListItem -List $listb -Id 41

Expected behavior
$allListItemsListA[1].FieldValues.Count should be the same value as $singleListItemListA.FieldValues.Count
$allListItemsListB[1].FieldValues.Count should be the same value as $singleListItemListB.FieldValues.Count
Actual behavior
For ListA that has 222 fields:
$allListItemsListA[1].FieldValues.Count only shows 192 FieldValues.
$singleListItemListA.FieldValues.Count shows all FieldValues, or 202 FieldValues.

For ListB that has 112 fields:
$allListItemsListB[1].FieldValues.Count shows all FieldValues, or 92.
$singleListItemListB.FieldValues.Count also shows all FieldValues, or 92.

Steps to reproduce behavior
# ListA has 222 fields.
$allListItemsListA = Get-PnPListItem -List $listA -PageSize 1000
# allListItemsListA[1] is the same item as $singleListItemListA
$allListItemsListA[1].FieldValues.Count

# singleListItemListA is the same item as allListItemsListA[1]
$singleListItemListA = Get-PnPListItem -List $listA -Id 104
$singleListItemListA.FieldValues.Count

# ListB has 112 fields.
$allListItemsListB = Get-PnPListItem -List $listB -PageSize 1000
# allListItemsListB[1] is the same item as $singleListItemListB
$allListItemsListB[1].FieldValues.Count

# singleListItemListB is the same item as allListItemsListB[1]
$singleListItemListB = Get-PnPListItem -List $listB -Id 41
$singleListItemListB.FieldValues.Count

What is the version of the Cmdlet module you are running?
2.5.0
Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

In my experience there is no guarantee that Get-PnPListItem will return all fields. Most of the times it returns the fields that are included in the default view.
The -Id parameter uses different CSOM code to retrieve the data than when loading all list items, which might explain the different behavior .
I would suggest to use the -Fields parameter to specify which fields you want to retrieve, documentation at https://pnp.github.io/powershell/cmdlets/Get-PnPListItem.html#-fields

hi @nozzrangar , this is by design.
As @jackpoz mentioned , we use a different query when you specify the -Id parameter. It will return different results .
If you need to fetch specific fields, use -Fields parameter and pass the field internal names.


Laravel 10.x Shift

This pull request includes the changes for upgrading to Laravel 10.x. Feel free to commit any additional changes to the shift-86205 branch.
Before merging, you need to:

Checkout the shift-86205 branch
Review all pull request comments for additional changes
Run composer update (if the scripts fail, add --no-scripts)
Clear any config, route, or view cache
Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

:x: Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 10 versions and merge any changes:

[ ] app/Http/Middleware/Authenticate.php
[ ] lang/en/validation.php

:warning: Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.
You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 9ad1ee54 and make the config file changes manually.

:information_source: Shift updated your dependencies for Laravel 10. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 10. Watch dealing with dependencies for tips on handling any Composer issues.
The following dependencies were updated by a major version and may have their own changes. You may check their changelog for any additional upgrade steps.

[ ] chelout/laravel-relationship-events
[ ] htmlmin/htmlmin
[ ] realrashid/sweet-alert

:information_source: Shift detected your application has a test suite. To make verifying the upgrade to Laravel 10 easier, Shift did not upgrade your test suite to PHPUnit 10.
Once you have completed your upgrade, you may run the PHPUnit 10 Shift for free to upgrade your test suite to PHPUnit 10 separately.

:information_source: Laravel 9 adopted anonymous migrations. Shift automated this change to align with modern Laravel conventions and avoid naming migrations.

:warning: Laravel 10 has added a return type of array to the Event broadcastOn and Notification via methods. However, you may still return a single channel from these methods.
Shift added the array return type to these methods in the following classes. You should review them to ensure you are returning an array, or remove the return type.

[ ] app/Notifications/Dues/PaymentReminder.php
[ ] app/Notifications/Dues/SummaryNotification.php
[ ] app/Notifications/Dues/TransactionReminder.php
[ ] app/Notifications/ExpiringPersonalAccessTokenNotification.php
[ ] app/Notifications/GlobalAttendanceNotification.php
[ ] app/Notifications/MembershipAgreementDocuSignEnvelopeReceived.php
[ ] app/Notifications/MembershipAgreementSigned.php
[ ] app/Notifications/PaymentReceipt.php
[ ] app/Notifications/TeamAttendanceNotification.php
[ ] app/Notifications/Travel/AllTravelAssignmentsComplete.php
[ ] app/Notifications/Travel/DocuSignEnvelopeReceived.php
[ ] app/Notifications/Travel/TravelAssignmentCreated.php
[ ] app/Notifications/Travel/TravelAssignmentReminder.php

:information_source: Now with type hints in your code, defining types within PHP DocBlocks is redundant. Laravel has removed all of the @param and @return tags from its DocBlocks where types are defined with PHP. Similarly, Shift removed these tags from any DocBlock where the code now has equivalent type hints.

:information_source: Laravel 10 added PHP type hints to all user-land code included in a new Laravel application. In an effort to modernize your code, Shift added type hints to any method which is used by Laravel, as well as any method which had types defined in its PHP DocBlock.

:information_source: Shift understands you may wish to preserve your full DocBlock even with PHP type hints in code. All of Shift's automation is done in nice, atomic commits. So you may easily undo this change by running git revert 1bfa6e7d.

:warning: In Laravel 10 you may no longer directly cast a DB:raw() expression to a string. Instead, you must retrieve the value from the expression using the getValue() method.
Shift detected calls to DB::raw(). You should review these instances to see if you are casting the result to a string.

[ ] app/Models/User.php
[ ] app/Nova/Metrics/AttendancePerWeek.php

:information_source: All of the underlying Symfony components used by Laravel have been upgraded to Symfony 6.2. Shift detected references to Symfony classes within your application. You should review the Symfony change log for any additional changes.

:information_source: Laravel began using Vite to build frontend assets in Laravel 9.19. While you may continue to use Laravel Mix, it is no longer the default. If you wish to modernize your application to use Vite, you may run the Vite Converter for free.

:warning: Shift detected your application contains stub files. With all of the type hints added in Laravel 10, you should review these files and add any type hints you want to have when generating classes with artisan make.

:warning: Laravel 10 requires Composer 2.2 or higher. You should verify the Composer version in your environments by running composer --version to ensure it meets this new requirement. If necessary, run composer self-update to update Composer.

:warning: Shift detected you are using a Laravel package like Horizon or Nova which may need to have its published assets regenerated after upgrading. Be sure to use artisan to republish these assets as well as php artisan view:clear to avoid any errors.

:tada: Congratulations, you're now running the latest version of Laravel!
Next, you may optionally run the following Shifts to ensure your application is fully upgraded, adopts the latest Laravel conventions, and easier to maintain in the future:

Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.
Laravel Fixer automatically updates your code to the latest Laravel conventions.
Tests Generator intelligently generates model factories, HTTP Tests, and configuration for your application.
CI Generator intelligently generates CI jobs to lint PHP, check code style, and run tests, including Dusk.

You may also use the Shift Workbench to automate common tasks for maintaining your Laravel and PHP applications.


[Storage]Error occurs deploying test-resources.json in China and US Gov cloud

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.
In US Gov and China, deploy resource fails with error Versioning is not supported for the account.Please refer to this pipelie for more details.
Versioning is not supported for the account
After investigation, we found that neither US Gov nor China cloud support setting Versioning in storage account. Below are data protection in portal:
US Gov & China Cloud:

Azure Cloud:

The Version enable setting has been defined in test-resources.json at row 101.

@jongio @danieljurek for notification.

Versioning is a preview feature. Please see this documentation link https://docs.microsoft.com/en-us/azure/storage/blobs/versioning-overview for details on preview and how to opt-into it.

@v-xuto - Can you please follow up on this?

@jongio This issue was solved, please close it.


Feature/xarray refactoring

Make transformations and datacube backends separate/independent

Codecov Report
Patch coverage: 94.50% and project coverage change: +0.15% :tada:

Comparison is base (d5be964) 96.88% compared to head (9976933) 97.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #61      +/-   ##
===========================================
+ Coverage    96.88%   97.04%   +0.15%
===========================================
  Files           40       46       +6
  Lines         5235     5374     +139
===========================================
+ Hits          5072     5215     +143
+ Misses         163      159       -4

Files Changed
Coverage Δ

polytope/datacube/backends/mock.py
87.50% <66.66%> (ø)

polytope/datacube/backends/datacube.py
89.74% <78.57%> (ø)

...tacube/transformations/datacube_transformations.py
82.22% <82.22%> (ø)

...lytope/datacube/transformations/datacube_cyclic.py
92.85% <92.85%> (ø)

...ytope/datacube/transformations/datacube_reverse.py
92.85% <92.85%> (ø)

...lytope/datacube/transformations/datacube_merger.py
93.65% <93.65%> (ø)

polytope/datacube/datacube_axis.py
91.89% <96.36%> (+3.94%)
:arrow_up:

polytope/datacube/backends/xarray.py
97.03% <97.03%> (ø)

...ytope/datacube/transformations/datacube_mappers.py
98.46% <97.22%> (ø)

polytope/datacube/__init__.py
100.00% <100.00%> (ø)

... and 22 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Suggestion] Remove the kube context: user, cert & key from kubeconfig when we delete a cluster

Suggestion
Remove from the kubeconfig file the kube context (user, cert & key, etc) when we delete a cluster.
When we delete an idpbuilder cluster, the kind cluster is well removed but not the kube context from the kubeconfig file. This is due to the fact that we are missing to pass the path of the file to the command kind lib function provider.Delete(name, "")
// see https://github.com/cnoe-io/idpbuilder/blob/8c6cd9704ae118981a89b3c5b541db1924f31643/pkg/cmd/delete/root.go#L43

provider := cluster.NewProvider(cluster.ProviderWithLogger(kind.KindLoggerFromLogr(&logger)), detectOpt)
if err := provider.Delete(name, ""); err != nil {
		return fmt.Errorf("failed to delete cluster %s: %w", name, err)
}

See also - kind delete function: https://github.com/kubernetes-sigs/kind/blob/main/pkg/cluster/internal/delete/delete.go#L27-L39

@cmoulliard Is #362  similar to what you are expecting with kubeconfig path?

Is #362 similar to what you are expecting with kubeconfig path?

Yes. We will use such an issue to push a PR offering such a new kubeconfig path flag


Title of cell in Settings tab is sometimes clipped at the bottom when there is a subtitle #1896

Closes #1896

Remember to git rebase master

Remember to git rebase master

@hboon , ok! tell me device you reproduce this issue.

@vladyslav-iosdev iOS 12.4 iPhone X simulator

@vladyslav-iosdev iOS 12.4 iPhone X simulator

@hboon  its strange but, i can't reproduce this on. tried on Iphone X 12.4  also will try on other devices.

@vladyslav-iosdev if you can't reproduce it after a while, let me know and I'll try to figure it out.

@vladyslav-iosdev if you can't reproduce it after a while, let me know and I'll try to figure it out.

@hboon  I sent new commit, check it, maybe it could help.

@vladyslav-iosdev I pushed a commit. It was complaining about constraint violation. Removing the margin appears to help. Would you help to verify that it still works for you on a few devices and then squash the 2 commits?
There are a few other constraint violations, but we can ignore those for now.

@vladyslav-iosdev I pushed a commit. It was complaining about constraint violation. Removing the spacing appears to help. Would you help to verify that it still works for you on a few devices and then squash the 2 commits?
There are a few other constraint violations, but we can ignore those for now.
(and git rebase master)

@hboon  Done, seems like its working, tested on several devices.


Error updating feeds

Hello,
I have the following error running "node updateFeeds.js" :
/app/updateFeeds.js:21
  console.log(count, feed.feed);
                          ^

TypeError: Cannot read property 'feed' of undefined
    at Timeout.doFeed [as _onTimeout] (/app/updateFeeds.js:21:27)
    at listOnTimeout (internal/timers.js:535:17)
    at processTimers (internal/timers.js:479:7)

When I comment console.log(count, feed.feed); located line 21, it's working properly. So I guess you just forgot to comment it before pushing.
Have a nice day :-)

Closing this because the code no longer works this way. We now consume items from a message queue instead of using a for loop.


Webrtc blocker doesn't work

Describe the bug
Webrtc network limiter doesn't work
Webrtc leak prevent doesn't work
Nor do adguard extension's block webrtc work
To Reproduce
Install any of these extension and try to block webrtc and check it
Expected behavior
It should block webrtc but it doesn't
Screenshots

Smartphone (please complete the following information):

Device: [e.g. realme narzo 50 pro 5g ]
Android Version : [e.g. A13]
Kiwi Browser Version [ e.g. 116.0.5845.57 ]

Additional context
JUST IT

For developer: please, add switch off webrtc in options Kiwi!

I don't know why Kiwi team doesn't care about fixing this important bug :/


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/*-test.mjs' as in template
chore(package): set $.ava.extensions='mjs' as in template

Coverage remained the same at 40.229% when pulling 0c2190a9475331769e7d74be7a29c059d3fb9fcb on npm-template-sync-1 into 5fd0d6628ed801d8f598a237f7092881f32962db on master.

:tada: This PR is included in version 8.1.53 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Custom command to manage collaborators

Hi @mislav,
May I know, is this a right thing for hub to support an addition custom command to manage collaborators to a repository?
As I can see, in the custom commands section, hub tries to minimize the use of web interface. So, collaborator management would be a better thing to add there, as I keep using that(web interface) often and doesn't like it.
We can have such a working for it:
hub collaborators [-l] [-a USER] [-r USER] [-c USER]

-l          list collaborators
-a USER     add a collaborator
-r USER     remove a collaborator
-c USER     check if a USER is collaborator

Can I hear something back from you?

:+1: In the meantime I'm using github-add-collab to quickly add collaborators.

No, right now we're not interested in supporting this feature mostly because it would add to the things we need to maintain. We want to instead support more actions related to the git and issues/PRs workflows.

@mislav Are there any plans to add this kind of functionality now or is this project still focused on issue/PR workflows?

@srafi1 I still don't think this is a good fit for hub, but you may be able to script adding collabs to a repo using hub api
You're welcome to share some code in a gist if you ever come up with a working script! 👍

Looks like this isn't too difficult using hub api with some json parsing using jq:
List collaborators: hub api repos/:user/:repo/collaborators | jq ".[].login"
Add collaborator: hub api -X PUT repos/:user/:repo/collaborators/:new_collaborator
Remove collaborator: hub api -X DELETE repos/:user/:repo/collaborators/:collaborator
Verify collaborator: hub api repos/:user/:repo/collaborators/:collaborator -i  | grep "Status: 204"  && echo yes || echo no
I can put this in a script in a bit.

Here's the completed script: https://github.com/srafi1/dotfiles/blob/master/scripts/hub-collab
(refrains from using jq because it's not a builtin command)

@srafi1 This is great! Thank you for sharing
You are welcome to contribute such scripts to hub-api-utils


TestDiscovererTests failures

DecoratedTests
TestCaseRunTests
TestCaseRunTestsWithTest
TestCaseSubclasses

I tested all 4 scenarios manually and they work fine in the product, so it's a matter of fixing the tests so we stop thinking the product is broken.

Both GetTestCasesFromAnalysis and GetTestCasesFromAst fail to find the test class.
One problem is that MakeDocumentUri doesn't handle filename being <string> (invalid path chars)
Another is that TestAnalyzer.GetTestCaseClasses enumerates cls.Mro but the only value is the test class itself, TestCase is not there.
There must be something fundamental that is missing in the setup of the analysis/project entry, I don't know what it is.


Determine lava and water fluid explosion resistance by their block explosion resistance

The explosion resistances of the water and lava fluids are hardcoded as 100. For reasons I've explained in the discussion section, this makes it impossible to make water and lava destructible using Purpur's blast-resistance-overrides config and any other method of overriding explosion resistance.
This PR is simple: it changes the blast resistance overrides patch to ensure that the fluid explosion resistances of water and lava are the same as their block explosion resistances. Because both values are 100 in vanilla, this has no effect for servers that do not modify water/lava explosion resistance. However, making this changeable is required for any server that needs to reduce the protective ability of fluids or permit underwater explosions.

Requested changes made


Tests do not pass on the master branch

When running
git clone https://github.com/besok/graphviz-rust
cd graphviz-rust
cargo test

I get
...
   Doc-tests graphviz-rust

running 7 tests
test src/cmd.rs - cmd (line 12) - compile ... ok
test src/printer.rs - printer::AttributeValuePrinter (line 23) ... FAILED
test src/attributes/mod.rs - attributes (line 6) ... ok
test src/printer.rs - printer::PrinterContext (line 49) ... ok
test src/printer.rs - printer (line 4) ... ok
test src/printer.rs - printer::DotPrinter (line 188) ... ok
test src/lib.rs - (line 12) ... ok

failures:

---- src/printer.rs - printer::AttributeValuePrinter (line 23) stdout ----
error[E0599]: no method named `with_attribute_formatter` found for mutable reference `&mut PrinterContext` in the current scope
  --> src/printer.rs:40:18
   |
19 | /             ctx.with_node_mult_attr_s_l()
20 | |                 .with_attribute_formatter(id!("custom"), formatter)
   | |                 -^^^^^^^^^^^^^^^^^^^^^^^^ method not found in `&mut PrinterContext`
   | |_________________|
   |

error: aborting due to 1 previous error

It could be useful to set up a continuous integration service (for instance with GitHub Actions) to ensure that such failures are detected early.

Thank you. That is a good catch.


Local test refactor, fixes #371, fixes #381

The Problem:
OP #371. Our tests in the platform package are interdependent, requiring the full package tests to be run in order to run a given individual test.
The Fix:
This PR breaks most of the test interdependencies. It moves start and remove functionality to the provision/cleanup handled in TestMain, so that individual tests can run without having to test the whole package. It also updates a couple tests, notably TestLocalExec, so that they can run without dependency on tests previous.
This also resolves #381, allowing ddev stop to run successfully unless there are no containers found.
There are a couple smaller tests I did not update to run independently, TestGetAppsEmpty and TestRouterNotRunning. These tests both validate a state in which no applications are running. I can update them if there's a strong desire, but I figured there's not much value in running these tests individually.
The Test:
Aside from TestGetAppsEmpty and TestRouterNotRunning, you should be able to pick an individual test out of local_test.go and run it. Sites should spin up for the test, it should pass, and then sites should tear down.
Automation Overview:

This is largely an automation-specific improvement.
Related Issue Link(s):
#371 OP for test refactor
#381 - ddev stop only works if site is in running state.
Release/Deployment notes:

Well YEEHAW! Thanks!

I'd love to see this land today so I can rebase it into Windows testing changes.

BTW, I think I'll be forced to implement test download (and extraction) caching just to speed up my windows work. Completely amazing how long tar extraction takes on Windows.

This has been updated based on the feedback. "short mode" is set with an Env Var and handled in TestMain as opposed to the separate test function. Additional explicit cleanup of site data dirs added, as well as some other fixes/cleanup to the tests.

Going to give me lots of rebasing to do :)


Fix the formatting, make examples simpler to follow

Examples are so over polluted by unnecessary detail, the formatting makes it even more difficult to see entire text.  So much needless scrolling for nothing.  Very poor explanation of problem by polluting example by irrelevant details, horrible formatting.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be073b14-6d0b-60be-7dff-4674bcb6c674
Version Independent ID: a5fa3e78-73de-3360-1253-00545a2b4ef2
Content: Chaining Tasks by Using Continuation Tasks
Content Source: docs/standard/parallel-programming/chaining-tasks-by-using-continuation-tasks.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

@dinobu Thanks for the comment -- in general I agree with you that examples should be as simple as possible. However, I don't know which examples in this doc you're referring to or what parts of them you see as irrelevant details. I'm closing this issue now but you're welcome to reopen and provide more details to let us know which parts of the example code in this doc need work.


Wrap UnionTypeNode

Would open up navigation without resorting to ts.UnionTypeNode <=> ts-simple-ast casting.

[ ] getTypeNodes
etc..

Just a suggestion could be a couple of helper methods like is or has a NullKeyword and UndefinedKeyword.
example with casting:
function foo (node : sast.Node)
{
    const unionTypeNode = <ts.UnionTypeNode>node.compilerNode;
    for (let i = 0, n = unionTypeNode.types.length; i < n; i++) {
      const type = unionTypeNode.types[i];
      console.log((<any>ts).SyntaxKind[type.kind]);
    }
}

Hi @kjpou1, this is implemented in 6.10.0.
Also, I added TypeGuards.isUndefinedKeyword. The TypeGuards.isNullLiteral has been around for a bit.
Let me know if you find any issues with it.

Works like a charm.  Thanks @dsherret !


"Vădăstrița" is listed in the drop-down menu

Description:
When user writes ”Vădăstriț" the location appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running. After every step delete the text you typed from the search bar.

Step 1
Type "Vădăstrița" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Vădăstrița, OLT".

Step 2
Write in the search bar "Vădăstrița".

Expected results
The location is listed in the drop-down menu as "Sat Vădăstrița OLT (Vădăstrița)".


Remove @_implementationOnly annotations

These annotations produce warnings when compiling swift-syntax without library evolution using Swift ≥5.10.
Replace them by private import when compiling using Swift ≥5.11.
Also mark the import of XCTest from SwiftSyntaxMacrosTestSupport as private, fixing rdar://119517162.
rdar://119517162

@swift-ci Please test


refactor: schema based framework for general commands factory

This refactor seems quite a lot of effort and not really useful for most users.
I write a doc to try to explain my ideas: https://github.com/linrongbin16/fzfx.nvim/wiki/A-General-Schema-for-Creating-FZF-Command
Let's just close it here.


[Feature request] Random pause

Expected Behavior
(I don't know if this has already been implemented to this bot but i think it will be good if it's not actually the case.)
Make the bot randomly stop "a random amount of time" every "some random time".
In order to make the bot less detectable.
config.json example :
"minPauseTrigger": 300 (minimum time in seconds before any pause)
"maxPauseTrigger": 3600 (maximum time in seconds before any pause)
"maxPauseDuration": 300 (in seconds)
"minPauseDuration: 10 (in seconds)

+1

Please move your feature request/s to our feature hub - http://feathub.com/PokemonGoF/PokemonGo-Bot

https://github.com/PokemonGoF/PokemonGo-Bot/issues/3843#issuecomment-239708680


[Form] Checkbox

This pull request has been deployed to Vercel.

✅ Preview:
https://matou-technologies-purrfect-ui-storybook-15.vercel.app

🔍 Inspect:
https://vercel.com/matou-technologies/purrfect-ui/AHjXxo4oC7KqvH75W6dP719XUFSf


add indices_view

1.add  indices_view
2.update  CONTRIBUTING

add package command

Thanks! I will review this issue during the week :)


Add Splash Screen + Cleanup

Added splash screen and attempted to reduce the white flicker
Did some cleanup

closes #129


httplib.InvalidURL

After installation on Debian, we are fronted by server error 500 when logging in.
The apache error log reveals that:
[wsgi:error] [pid 9080:tid<PHONE_NUMBER>32800] [client OBFUSCATED:14184] Error - <class 'httplib.InvalidURL'>: nonnumeric port: '{{NIPAPD_PORT}}'
Please advise

in /etc/nipap/nipap.conf alter the row that starts with:
xmlrpc_uri =
to correct values for your web-user that you created earlier


Set up a script to prevent users from having to have PHP and composer installed

https://docs.npmjs.com/misc/scripts
https://github.com/garthenweb/node-composer-runner

My idea is to set up a postinstall script, but I to figure out how to verify PHP is on the machine before it runs.

https://github.com/garthenweb/node-composer-runner

I don't think this is going to be reasonable – people will just have to learn about composer.


feature(wire): Wrap errors

1. What does this PR implement?
Create standalone Error type for wire and wrap errors with it.
2. Does the code have enough context to be clearly understood?
Yes
3. Who are the specification authors and who is accountable for this PR?
@AlejandroCabeza
4. Is the specification accurate and complete?
N/A
5. Does the implementation introduce changes in the specification?
N/A
Checklist

[!WARNING]
Do not merge the PR if any of the following is missing:

[X] 1. Description added.
[X] 2. Context and links to Specification document(s) added.
[X] 3. Main contact(s) (developers and specification authors) added
[X] 4. Implementation and Specification are 100% in sync including changes. This is critical.
[X 5. Link PR to a specific milestone.

Added a nitpick, I think it would be better that way. But having a separated module is ok. Alternatively you may reexport the module in wire directly:
pub use crate::wire_errors::Error;

I generally favour splitting stuff into files, but I do very much agree having Error exported from the same file would be ideal.
For the sake of arguing: How does refactoring wire.rs into a wire module sound?
All this being said, I can certainly put Error back inwire.rs.

Added a nitpick, I think it would be better that way. But having a separated module is ok. Alternatively you may reexport the module in wire directly:
pub use crate::wire_errors::Error;

I generally favour splitting stuff into files, but I do very much agree having Error exported from the same file would be ideal. For the sake of arguing: How does refactoring wire.rs into a wire module sound? All this being said, I can certainly put Error back inwire.rs.

Yeah, wire could be its own module actually, then it would have the mod with the implementation and an error.rs file. Then reexport the Error from the mod. That would tick all the boxes.


Add Cassandra workload DSE test

What this PR does:
Adds an e2e test for the Cassandra workload in DSE.
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated

Looking good so far. Are you planning to run the DSE e2e test on GHA, or should we tackle this later?

Right, I forgot that part.
All done now 👍


Smooth Animations

@bodymovin ,
I've been using the plugin to animate shape layers, creating paths and generating strokes and outputting those animated strokes (I'm using the start and end keyframes as well as color slider to change the lines colors as theyre animating in and out) into SVG. I've noticed though that the animation isn't as smooth and robust for these types of animations as their desktop counterparts. Is it better to animate shape layers as opposed to strokes generated by the effects panel in after effects? I'm just curious if you could explain what types of presets/libraries/effects in AE we should avoid if we want to make well performing animations. Thanks!

Hi, I'm not sure I understand which animations work better than others.
When you say their desktop counterparts, what are you comparing them to?
Can you share an .aep with examples?

I'm using Plugin called Motion v2 by Mt. Mograph. and on export i can't see any effect i added using that plugin.
Here is the dropbox link to .aep project file.

@themanisingh Hi, I think with the latest version, it should work fine.

Using Motion 2 on a little demo project to test bodymovin. Noticing that the Warp effect (which automatically stretches/squashes to match movement) isn't appearing in the exported animation. Should it be, as far as you know? If so, is there anything special I need to change in my export settings to see this effect?
(BTW, I'm aware that this original issue is very poorly-named, vague and unhelpful in general, I'm only posting this here because it already mentions Motion v2).

@cmalven Hi, unfortunately, the warp effects is not supported by the plugin.

Thanks @bodymovin your comment to @themanisingh above made me think that it might work.


fix: remove publish step

:tada: This PR is included in version 1.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Skip empty commits

If a change has only updated the update time but hasn't changed the files, we shouldn't bother committing the change.
This may require a solution for writing to the github cache to keep track of the latest version, however there's no point in committing versions with no config changes.
New builds with no changes will still be committed under this change.

Fixed as of https://github.com/boomboompower/twitch-experiments/commit/a66abbd3efef97f44e0209a74dd9349256dac461


Task unification: add fields to todo

Coverage increased (+0.01%) to 93.775% when pulling a727400cfe61a430f621b079b1c50197d24422f5 on task-unification-add-fields-to-todo into 896d1944a8130942a95c84bc23edfc05a6ca9c0f on main.


validation in client side for  inputs before  sending request

If  /dashboard/login page

suppose if  we click login button without filling anything in input field then also the form submitted ,
To prevent this we can add some  client side validation using javascript so that form only submit after some basic validaton

Sugarizer-Server forms does not depend on client side validation. If you propose to implement client side validation in Sugarizer-Server, then it needs to be implemented in all the forms in the UI.
At this moment, the simplest thing which can be implemented here is HTML input "required" attribute. But it will interfere with the "Password cannot be blank" popup on submitting the form.
@llaske what's your opinion on this?

suppose if we click login button without filling anything in input field then also the form submitted , To prevent this we can add some client side validation using javascript so that form only submit after some basic validaton

I support the change. It seems that if the form gets submitted even when blank then it may be seen as a vulnerability to DDOS attack. It will be pretty easy to create automation to click on a button. this may lead to overflow of request on the server that may push it to its limits.
A validation may at the least increase the complexity of the script making it a bit difficult if not completely stop it.

Added a  simple validation before sumitting form
if will prevent submition in  following cases :

if  username is empty
if  password is empty
if  only white space is filled in input field

Used similar  notification  popup that is used for  displaying other messages
changes here
if is beneficial then we can add simililar thing for all other forms

since sugarizer-server also works for different languages  and  so it is not a good idea to add client side validation notifications


SettingWithCopyWarning on rank_genes_groups_violin()

It is low-priority I think (the function should work anyway), but I get the following Warning when I execute rank_genes_groups_violin():
/Users/user/.pyenv/versions/3.6.4/lib/python3.6/site-packages/scanpy/plotting/tools/__init__.py:1037: SettingWithCopyWarning:
A value is trying to be set on a copy of a slice from a DataFrame

See the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
  df['hue'][df['hue'] != group_name] = 'rest'

The interested line is the following:
https://github.com/theislab/scanpy/blob/639dcd4c2385a24271733a8f05d838dbf70175e6/scanpy/plotting/tools/__init__.py#L1159
If I remember correctly Pandas API, such line should be rewritten as:
df.loc[df['hue'] != group_name, 'hue'] = 'rest'

Francesco

Thank you very much! You're right, the line isn't good style... I'll correct that... for some reason, I don't get the warning...

I was working on a PR in the same function and I decided to include the fix in that. I don't know if it's appropriate.


applyImpulse not working after aframe upgrade

Hello,
I upgraded to aframe 0.9.0 with aframe-physics-system v3.3.0 and applyImpulse seems to be broken after that. I upgraded from aframe 0.8.2 and aframe-physics-system 3.3.0 where all was working fine.
Here is my code -
entity.setAttribute('dynamic-body', true);       entity.addEventListener('body-loaded', function () {        setTimeout(function () {           let pStart = new CANNON.Vec3();           let force = pStart.copy(attachment.object3D.getWorldPosition());           force.scale(140, force);           entity.body.applyImpulse(force, entity.body.position);        }, 0);       })
It used to work perfectly fine but now I see this message in console log -

Closing it as raised the same question on SO -
https://stackoverflow.com/questions/55238394/aframe-physics-system-with-aframs-0-9-0


Be aware of message delivery in kafka sink

Current implementation:

Use ThreadedProducer::send in rdkafka to produce messages to kafka sink. send will return immediately when the message is put into the client's internal buffer and the actual I/O happens asynchronously since kafka producer will do both time-based and size-based buffering.
Use a void implementation for ProducerContext::delivery. Ack on successful message delivery will be lost in such case.
Call ThreadedProducer::flush + ThreadedProducer::commit_transaction on seeing a checkpoint barrier.

(btw, I think we can avoid using the transactional producer given that user can no longer enable transactional produce)
The current implementation is suboptimal in the following aspects:

We can only know whether a message is successfully written to kafka on checkpoint boundary. This means we need to persist all changelogs in log store with sink & ckpt decoupling even when sink can keep up in the happy path.
It is hard to do error handling because we won't know whether there is any error happening in the async produce I/O.

Ideas on improvements:

Implement ProducerContext::delivery correctly. Basically we use this callback to be aware of message delivery outcome and can act quicker. We may need to use channel to integrate the callback result into our current framework.
Use FutureProducer instead of ThreadedProducer. FutureProducer wrap the async delivery into a Future, which I think it is more intuitive to use.

Personally I prefer 2. Furthermore, I think we can consider refactoring sink executor implementation to use an actor-based model to poll sink writer instead of calling the sink writer methods on receiving stream messages.

related: #11229


Add transitive dependencies

Purpose
$Subject

IMO, with the latest update in ballerina-lang, these changes are not required.

IMO, with the latest update in ballerina-lang, these changes are not required.

Yes, I close this pr.


What is minimum I have to pass so form will update to state.

I would love to see some examples of onSubmit etc. All the examples I see seem to reinitialize the form to a blank state, but I don't see where the Redux state is being updated. And I'm not sure how much sate-updating is done by default through the redux-form library. So I'm trying to figure out what to put into my onSubmit etc but the examples are not reducing my confusion..
Say I have a singular applicant object in my state with a name field.
class App extends React.Component {
render() { return(
<ApplicantForm
  initialValues={this.props.applicant}
  onSubmit={updateApplicant} //the action for updating applicants
/>
);}
export default connect((state)=>state)(AdvancedMode);
}

class ApplicantForm extends Component {
	render() {
		const {fields: {name}, handleSubmit} = this.props;
		return (
			<form onsubmit={handleSubmit}>
				<label>Name:</label><input type="text" {...name} />
				<input type="submit" value="save" onClick={handleSubmit}/>
			</form>
		);
	}
}

ApplicantForm = reduxForm({
	form: 'applicant',
	['name']
})(ApplicantForm);

export default ApplicantForm;

With this setup it is updated, and re-renders on change and submit, but when I submit, it ends up with a 'redux-form/TOUCH' action and never actually updates the applicant in state.
my reducer looks like:
function applicant(state = {}, action){
	switch (action.type) {
	case UPDATE_APPLICANT:
		return Object.assign({}, state, action.applicant);
	default:
		return state;
	}
}

Where is your updateApplicant function? You left that out, so I can't tell if you are dispatching the UPDATE_APPLICANT action correctly.

updateApplicant() is imported from my actions.js. Basically matches the
examples for setting up actions in the redux docs... I will post complete
code later on when I'm at my computer.
On Mon, Nov 2, 2015 at 11:22 Erik Rasmussen<EMAIL_ADDRESS>wrote:

Where is your updateApplicant function? You left that out, so I can't
tell if you are dispatching the UPDATE_APPLICANT action correctly.
—
Reply to this email directly or view it on GitHub
https://github.com/erikras/redux-form/issues/206#issuecomment-153072277.

Have you figured this out?

I would love to see some examples of onSubmit etc.
+1


Automatically adjust margins

Sometimes the song name is really long but it's cut off, since the space is equally seperate between title, album and artist. It would be nice if the margins were automatic and allocate space more efficiently.

Turns out that automatic margins only work for single albums so it's not really worth using.


Update 5.0.2 to Spring boot 1.4.3

Spring boot 1.4.3 is GA and has many fixes - https://github.com/spring-projects/spring-boot/milestone/75?closed=1
A quick check by bumping up to 1.4.3 in gradle properties seem to work well for CAS 5.0.1

Move the issue over to CAS.

PS When the change is in place, the overlay will be auto-updated when CAS is released.

Forgot to mention that you need to make sure you are not running with duplicate JARs. A quick check generally is not enough.If you wish to use 1.4.3 you might as well bump to 5.1.