fix(app): H-S confirm attachment modal form stopPropagation addition

closes #10881
Overview
There are 2 bugs that both don't exist on edge since they were introduced by some additions I made to release_6.0.0. That is why I made this off of the release_6.0.0 branch
1st bug: When I added the input tag, type submit to allow you to submit your value using the keyboard, it introduced a bug where the confirm attachment modal would not appear correctly. This PR fixes it by adding stopPropagation and preventDefault
2nd bug: I had onCloseClick called for both temp and shaking commands, causing the modal + slideout to close completely whenever you hit submit on the slideout
Changelog

add stopPropagation and preventDefault to handle click
add logic for onCloseClick() to only occur when you are on the temp slideout

Review requests

try to submit a shaking command via heater-shaker slideout. The confirm attachment modal should pop up and work as expected.

Risk assessment
low

Both slide-outs behave the same now 👍 👍


bz69439 - fix: improper handling of conflicting cache-control directives

Currently ExpiresFilter pickup the first-added cache-control header as the effective field, cause follow-up directives (like no-store or max-age) to be ignored.
rfc9111 - 4.2.1 - If directives conflict (e.g., both max-age and no-cache are present), the most restrictive directive should be honored.

remove cacheControlHeader from servlet response wrapper ExpiresFilter.XHttpServletResponse.
go through all cache-control fields when verify add-expire-header possibility.
test case added.

Thanks for the PR. I have applied a fix based on this PR.
Removing the cache-control header caching removes a deliberate performance optimisation (and doesn't update the Javadoc to reflect that change either). I opted for the simpler approach of merging multiple headers into a single header in the cache. I also slightly changed the test cases.


update readme to reflect "implementation"

This is a very minor issue, but the readme should be updated to reflect that in the project dependencies, "compile" is deprecated and is going to be removed by the end of 2018. "implementation" should be used instead for buildtime improvements, see https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration?utm_source=android-studio#new_configurations

nice! Thank you. The docs have been updated with implementation instead of compile.


Logging Behaviours: Event Driven Logging vs. Client.lastRequest

How would you guys feel about a PR that allows the client object to emit events? I'd like to add it soon.
My primary reason for wanting this behaviour is for logging reasons. Using Client.lastRequest wouldn't be my approach as you need to monitor it for changes and log accordingly. Using something like the following would be preferable:
Client.on('request', function (xml) {
 // Do logging here
});

The same approach could be taken for a server.

I think this is a really good idea and it would be a valuable feature for this library. I'd love to see a PR for this :+1:

+1

Awesome, while I'm working on my project I'll tackle this an submit a PR. Hopefully within 1-2 weeks.

Sending a PR now.
Two events are exposed on Client instances, "message" and "request".
"message" contains just the Soap Body.
"request" contains just the entire Soap request contents.
Having both is useful if you do not want headers in the XML you get from the event.

@herom let me know when you guys plan on merging the PR (#547) for this.

Sorry for the late response @evanshortiss and thanks a lot for your contribution, we appreciate it a lot :+1:
In order to get this merged, I have to ask you to follow our Guidelines for Submitting a  Pull  Request, which - in your case - means, that we ask you to squash your commits into a single one. Your best bet would be with git rebase -i HEAD~2 and a force push onto your remote repository, I guess. If you don't know what git rebase is, I'd recommend to head over to the (excellent) GitHub Help pages here and here.

Thanks @herom I'm pretty sure I've successfully rebased and squashed into a single commit following those instructions

thanks a lot :dancers:

This works great for us, but it would be even more awesomer if it also emitted a corresponding response event. Then all logging of requests and responses could be done in one spot and I wouldnt have to remember to do it in each callback.


..mod identified as AMPL instead of Modula-2

Hi,
In my repo, files with name in the form of ..mod, for example: Oberon07.Files.mod, were identified as AMPL, while *.mod were identified correctly as Modula-2. I would like all of them to be Modula-2, could you guys address this issue?

Thanks for the bug report!
We have a heuristic in place to recognize Module-2 .mod files. It matches on the MODULE line (e.g., MODULE Oberon07.Out;). The regular expression we use is:
/MODULE\s\w+\s*;/i.match(data) # matches `MODULE Poc;`, but not `MODULE Oberon07.Out;`

I can update it to match on dots too:
/MODULE\s[\w\.]+\s*;/i.match(data) # matches both `MODULE Poc;` and `MODULE Oberon07.Out;`

Are there other special characters we should consider?

Whoa, so that's how linguist recognize Modula-2 source code. In that case, I recommend this construct:
It was used in Active Oberon dialect.

That looks less common. Couldn't we just fix the current heuristic?

No problem at all, that's just my suggestion. Anyway, thank you for your efforts!

So, are there other special characters we should consider besides .?

No, not at all, I think it's enough.


Added Creator object to DefaultOnRatingListener

Added Creator object to DefaultOnRatingListener as it is set extends Parcelable
Otherwise, it will throw a RuntimeException: Parcelable protocol requires a Parcelable.Creator object called CREATOR

:+1:

Thanks @lionscribe! We'll release a 4.0.1 version with this fix soon.

@lionscribe The version 4.0.1 is now available. Thanks for your work

You are very welcome. Thank you for a useful product.
On Jan 12, 2016 4:22 PM, "Lucas Ponzoda Vaño (Pocho)" <
<EMAIL_ADDRESS>wrote:

@lionscribe https://github.com/lionscribe The version 4.0.1 is now
available. Thanks for your work
—
Reply to this email directly or view it on GitHub
https://github.com/androidsx/rate-me/pull/76#issuecomment-171059186.


Fix upgrade-prerequisites

The KAYOBE_CONFIG_ROOT variable is out of scope so is undefined:
/home/ubuntu/src/kayobe-config/tools/upgrade-prerequisites.sh: line 38: /tools/rabbitmq-quorum-migration.sh: No such file or directory
Even though the script is being called using that very same variable: https://github.com/stackhpc/terraform-kayobe-multinode/blob/main/ansible/files/multinode.sh#L374

Converted to draft - untested

I had to make this change on customer system upgrade. So, this is tested. However we didn't considered the case when the system doesn't use Kayobe environment. I'll add a commit for this.

I had to make this change on customer system upgrade. So, this is tested. However we didn't considered the case when the system doesn't use Kayobe environment. I'll add a commit for this.

We discussed this in person but for future reference, this script is designed to be run in CI only. There are too many edge cases on customer deployments to cover

Tested and working here: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/11662590141/job/32469246299
There's a weird order of operations here:
This PR needs to merge
Then this one in the github workflows: https://github.com/stackhpc/stackhpc-openstack-gh-workflows/pull/8
Then we need to make a new release of that repo
Then I need to make a new one to SKC stackhpc/2024.1 which will bump the version it uses to that release


Feature Request: Tesla Motors API Support for Tracking

I really appreciate the new Volvo support and looking forward to other car brand supports. I'm especially interested in a support for tracking down Teslas.
I learned that Tesla has an officially undocumented API, which is somewhat documented[1].
I would love to see support for Teslas beeing build into Home Assistant!
[1] http://docs.timdorr.apiary.io/#reference/vehicles/state-and-settings

Feature requests should be posted in the forums.

Ah, thanks I didn't knew that. Actually I'm not registered there...

So I've added it there too: https://community.home-assistant.io/t/tesla-motors-api-support-for-tracking/4782


om upload-product can show a failure if Ops Manager takes too long to respond

om can show a failure when uploading large tiles that take a long time to decompress. As an example, I'm having trouble uploading SRT on a brand new terraformed azure opsman.
When I upload the tile, ops manager takes little over 6 minutes to decompress and validate the tile. By default, the idle connection timeout on Azure is 4 minutes.
The result looks like this:
+ om -k upload-product --product ./srt-2.5.2-build.7.pivotal
processing product
beginning product upload to Ops Manager
 10.12 GiB / 10.12 GiB  100.00% 8m9s1s2s
21m50s elapsed, waiting for response from Ops Manager...
retrying product upload after error: could not make api request to available_products endpoint: Post https://pcf.example.com/api/v0/available_products: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
processing product
beginning product upload to Ops Manager
...

If I browse to the ops manager about 10 minutes into the "waiting for response from Ops Manager" I can see the tile is available to stage. om sees the timeout, retries twice, and then exits with a failure after exhausting retries.
My workaround is to increase the idle connection timeout on the Azure VM. Having om check if the tile is there already before each retry attempt could also help.

The PR has been prioritized for review.
Steps our team will go through before/after pulling it in:

include a concrete procedure for replicating the error
affirm that we do not error if the product is already there

To our team's understanding, this is most easily replicate-able on Azure, and is due to a server timeout on the Azure side, not a timeout from om.

We're pretty sure this isn't governed by the Azure idle timeout, but by our default request-timeout.
The upshot is: extend your request-timeout in your env.yml file and you won't see this problem. We've heard that "over 9000" is sufficient, but probably excessive.
We've also updated the related PR with more information about changes we'd like to see in the messaging, but increasing the timeout is probably the best play for most people, as those changes may not land for a while.

Here's our followup story: https://www.pivotaltracker.com/story/show/166833456

@pivotal-todd-ritchie this should have been released with better error messaging in v3.0.0.
Closing this issue.


Add attachment support for "Attachment" columns in Airtable

I noticed recently there's a new "attachment" column type in Airtable. I haven't looked into using it yet, but I suspect we can use it to support images and documents.
Acceptance Criteria:

[ ] Must support images as this is the highest demanded feature right now
[ ] Must support documents as that's part of the "attachment" field.

Had a look into this for file-based attachments, and it should be reasonably simple to implement:

Custom document model, so the Airtable attachment id can be stored for future reference
Custom serializer to map between Wagtail documents and Airtable attachments:

For import, this'll require downloading the file at the specified URL into the document's file
For export, just the Attachment ID needs to be returned for existing objects. For new ones, it'll require sending up a public URL for the document (.file.url should be fine)

Ensure M2M models are correctly updated and diffed when inserting.

Besides the final point, I'm sort of expecting to be able to do this without modifying the library at all, and even that's only a guess. I'd expect something similar to work for images.
Attempting in the next few weeks - I'll report back my findings!


Feasibility of creating TorchSharp.NativeAssets.WebAssembly?

This is related to the issue raised here
TorchSharp.NativeAssets.WebAssembly is something post TorchSharp 1.0 and something a remote feasibility evaluation when the Blazor WebAssembly native library interop technology is much more mature.

@GeorgeS2019 -- I would suggest closing this for now. For TorchSharp to properly work with WebAssembly, there would have to be a WA backend libtorch implementation, which goes beyond what this project is scoped to accomplish.


fix: sonar warnings

:tada: This PR is included in version 0.102.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Research localization (i18n)

Need to research how we can help support localization.

Slack Conversation / Request: https://cengage.slack.com/archives/C8Y4FR63U/p1638386599031000


"Error" in documentation regarding "Get Vehicle Data"

Hello,
I think the output shown is from /webapi/v1/user/vehicles/:VIN/status call and not from /webapi/v1/user/vehicles/.
Kind regards,
Dietmar

Thanks Dietmar - I'm just submitting a pull request which will fix this.


Animation broken using compose 1.5.0-beta01

What broke?
When using compose 1.5.0-beta01, resetOffset() animation will not complete.

How to reproduce?
Use compose 1.5.0-beta01
What made it broke?
Internally in compose's implementation, a PointerInputResetException() has been thrown causing cancellation.
Potential fix?
Making SwipeableActionsBox() always enabled kinda fixes it. But I'm not sure if there are side effects.

Fixed in v1.2.0. Thanks both of you!


'timeout. not yet replicated' error

Hi,
I'm doing some quick tests with rarepress. While minting multiple files in batch, I saw a lot of 'timeout. not yet replicated:xxxx' in my console.
After some search in the source code of how 'upload' function and 'check' function are implemented, I got the following two questions:

the 'check' function use a 'while' loop to check whether the cid has correctly been pushed. Does that mean the 'upload' request can never fail ? (all upload request will eventually been processed immediately or soon ?)

what would be the best practice if a batch upload continues to be blocked at the 'timeout, not yet replaceted: xxx' state ? Should we cut the current execution and re launch a new one ? or should we just wait ?

Thanks a lot

I have the same question. Is this project still maintained?


:sparkles: merge clair and clair klar together

merge the two parsers clair and clair klar

Also would be good to add a breaking change section to the upgrade notes for folks that could be using Clair Klar in an API based import. Here is an example from then Nessus -> Tenable conversion was made

Very good point about the breaking change @Maffooch

@Maffooch, could you review it very closely? I don't have much experience with db migrations and don't want to messup the db. I also included database migrations for OpenVAS: https://github.com/DefectDojo/django-DefectDojo/pull/9322

Could you please merge this PR before https://github.com/DefectDojo/django-DefectDojo/pull/9375 because of the db migrations.

@Maffooch do you have time to take a look at this?


Order of frames wrong when grabbing

Hi, I'm extracting a whole video frame by frame using the AWT grabber, and play the frames in a window.
I'm basically seeing the video, but in a weird back-and-forth motion (frames are repeated a lot in a strange pattern).
What could this be?
Program. framesFromVideo function.
Note: This does not occur with all videos... maybe I shouldn't have downloaded MP4s from weird sources, lol.
Anyone see this before?

That's b-frame reordering. FrameGrab is low-delay so it doesn't reorder frames for you. Transcoder however does have the logic of frame reordering built-in.
In B-frame sequence frames are stored in weird order where a P-frame that's a future reference is transmitted first followed by all the B-frames that refer to it.
Display order:
/-------/-------/-------
I-B-B-P-B-B-P-B-B-P
Bitstream order:
I P B B P B B P B B
So if your intention is to play this stream back you will need to reorder frames by the PTS or POC. Use the code below as an inspiration:
TreeMap<Double, BufferedImage> reorderBuffer = new TreeMap<Double, BufferedImage>();
AWTFrameGrab8Bit fg = AWTFrameGrab8Bit.createAWTFrameGrab8Bit(NIOUtils.readableFileChannel("filename"));
PictureWithMetadata8Bit pmd = fg.getNativeFrameWithMetadata();
// Either convert it to BuffferImage right away or clone using Picture8Bit.cloneCropped() method
// the underlying buffer will be reused for the next frame.
BufferedImage img = pmd.getPicture() == null ? null : AWTUtil.toBufferedImage8Bit(pmd.getPicture());
reorderBuffer.put(pmd.getTimestamp(), img);

// Allow for 5 frames in reorder buffer, that will cover the most common case of I-B-B-B-P
if (reorderBuffer.size() >= 5) {
  double leastPts = reorderBuffer.keySet().iterator().next();
  BufferedImage toOutput = reorderBuffer.get(leastPts);
}

Ah. There is no ready-made code for it? I'm looking into Transcoder.java

In case it matters at all; this helped me solve my similar issue, though I went with a - I think cleaner - implementation:
private static class SortedImage implements Comparable<SortedImage> {

	private final double timestamp;
	private final BufferedImage data;

	private SortedImage(PictureWithMetadata p) {
		data = loadVideoFrame(p.getPicture());
		timestamp = p.getTimestamp();
	}

	@Override
	public int compareTo(SortedImage o2) {
		return Double.compare(timestamp, o2.timestamp);
	}

}

private static void loadVideo() {
	try {
		SeekableByteChannel bytes = NIOUtils.readableChannel(new File(VIDEO_FILE));
		FrameGrab videoData = FrameGrab.createFrameGrab(bytes);
		ArrayList<SortedImage> li = new ArrayList();
		for (int i = 0; i < videoFrames.length; i++) {
			videoData.seekToFramePrecise(i);
			PictureWithMetadata src = videoData.getNativeFrameWithMetadata();
			li.add(new SortedImage(src));
		}
		Collections.sort(li);
		for (int i = 0; i < videoFrames.length; i++) {
			videoFrames[i] = li.get(i).data;
		}
	}
	catch (Exception e) {
		e.printStackTrace();
	}
}


refactor: transform to monorepo

Hello, following up my previous PR #2, this is a proposal for transforming the repo with duplicated files into a pnpm monorepo with 2 packages, lib and example.
For this to work, i had to set many deps to external in vite.config.ts, so the app using this lib needs :

react
react-dom
three
@react-three/drei
@react-three/rapier (and its  provider)
@react-three/fiber (and its  provider)
leva (and its  provider)

Tho I believe it was never meant to be used without any of these.
You can try it using :
pnpm --filter ecctrl build
pnpm --filter example dev
I suspect you manually publish your releases so npm publish now becomes pnpm --filter ecctrl publish

Hi @ledouxm, thanks for your proposal! To be honest, I'm not really familiar with using pnpm. I have tested it locally, but it's not working as I expected. I think I will stick with the TypeScript version you provided and continue development based on that. Thanks for your effort! 😊


Grammatically updated the tutorial01 tech docs

Small grammatical update to the tutorial01 tech docs

Thanks for this patch, however the current wording is correct and we try to avoid trivial wording changes unless it's a big problem as it creates extra work for documentation translators.

Thanks for this patch, however the current wording is correct and we try to avoid trivial wording changes unless it's a big problem as it creates extra work for documentation translators.


Update package:vm_service constraints to >=12.0.0 <16.0.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-7.0%) to 93.037%

Totals

Change from base Build<PHONE_NUMBER>4:
-7.0%

Covered Lines:
628

Relevant Lines:
675

💛  - Coveralls


[MM-50171] - Update plan details badge from yearly to annual

Summary
Update plan details badge from YEARLY to ANNUAL
Ticket Link
https://mattermost.atlassian.net/browse/MM-50171
Screenshots
Before

After

Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/cherry-pick cloud

Cherry pick is scheduled.


chore(main): release 1.0.5

:robot: I have created a release beep boop
1.0.5 (2024-03-25)
Miscellaneous

update to API Key (#28) (848c1ee)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/momentohq/laravel-cache/releases/tag/v1.0.5 :sunflower:


Update dpe and cfi versions

LGTM, just needs DPE to track an upstream commit once https://github.com/chipsalliance/caliptra-dpe/pull/326 is merged


Add dropdown to switch CTV theme

It's not realistic to pre-compute everything. Other topics should be explored via forks.


Fix compileSdkVersion on newer flutter

Make a non-breaking change to ensure compatibility with the newer Flutter version and enable our app to build successfully.
in Android/build.gradle add:

ext {
    compileSdkVersion   = 34
}

I will add it and make an update. Thanks a lot. I missed the PR


Node.js 16 deprecations in triage workflows

Workflows set up by Cypress.io to support triaging are producing deprecation warnings:

add-issue-to-triage-board.yml

add-to-triage-project-board / add-contributor-pr-comment
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

triage_closed_issue_comment.yml

closed-issue-comment / handle-comment-scenarios
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The source of the workflows is outside of the scope of this repo and not viewable externally, so I can't fix the issues.

@jennifer-shehane
If triaging in this form is no longer being used then the workflows with deprecations should be disabled.
If the workflows are still being used, then they need to be updated to run without deprecation warnings:
actions/checkout@v3 => @v4
actions/setup-node@v3 => @v4
actions/github-script@v6 => @v7

See also open issue https://github.com/cypress-io/cypress/issues/28653

Yah these still are used, it's just no longer public because it's just our internal triage process of getting through new messages.

I added the links to the workflows causing the deprecations:
-> cypress-io/cypress/.github/workflows/triage_add_to_project.yml@develop
-> cypress-io/cypress/.github/workflows/triage_handle_new_comments.yml@develop
and correct that comment that these are not visible.

PR #28879 is planned to fix this issue.

Testing comment workflow on closed issue.


Table creation partition/cluster support

Is your feature request related to a problem? Please describe.
Quickly looking through the source code, it looks like there is no support for partition/cluster configuration at time of table creation.  The best reference I see anywhere close to this is in the function base.py -> get_indexes.  So it looks like we can just get indexing information but not set indexing.
Describe the solution you'd like
Added support for index configuration.
Describe alternatives you've considered
Will probably need to make another SQL query to check metadata if indexing is in place, and if not, set the indexing via SQLalchemy text() function.

I think one of the challenges is that current DDL only supports defining clustering/partitioning on table creation, but doesn't support altering them afterwards. So I'm not sure if overriding Index class would work, or we should add a new class such as Clustering and Partitioning instead.
Current API allows modifying clustering settings in-place, but not for partitioning.
Also there are several constraints compared to regular relational DB:

At most one clusterings/partitioning is allowed per table
Only top-level columns and specific data types are supported
Clustering has limit on number of columns for multi-column sorting (4 columns for now)
Partitioning can only specify 1 column
Optional filtering requirement on partitioned column

Thanks @chalmerlowe !!!

Thank @nlenepveu
They did all the heavy lifting.


Multi Adapter problem

What is the problem with this?

A FastItemAdapter is a FastAdapter + a ItemAdapter
A FastAdapter can only be constructed with ItemAdapters (ModelAdapter).
You are trying to construct a FastAdapter with a FastAdapter which it does not like :D


Implement EncodedAnnotation and AnnotationElement classes

In some applications which are compiled with all the Annotation information, it is necessary to implement these classes in order to avoiding a crash in the application, parsing fails because the pointer of the file doesn't advance with the parsing and it contains some missing data so it's necessary to implement both classes and add them to parser.
Here it's necessary to include the code: https://github.com/Fare9/KUNAI-static-analyzer/blob/3b711de554d8e712cf17672d0adb2e303fdae750/src/DEX/parser/dex_encoded.cpp#L52
It's possible to follow Androguard's code:
https://github.com/androguard/androguard/blob/8d091cbb309c0c50bf239f805cc1e0931b8dcddc/androguard/core/bytecodes/dvm.py#L1612
https://github.com/androguard/androguard/blob/8d091cbb309c0c50bf239f805cc1e0931b8dcddc/androguard/core/bytecodes/dvm.py#L1764
https://github.com/androguard/androguard/blob/8d091cbb309c0c50bf239f805cc1e0931b8dcddc/androguard/core/bytecodes/dvm.py#L1716

Problem already solved in refactoring branch of Kunai: https://github.com/Fare9/KUNAI-static-analyzer/blob/refactoring/kunai-lib/lib/DEX/parser/encoded.cpp#L51-L53


Support exponential backoff

Is it possible to retry errors using an exponential backoff with this library? I couldn't see a place to tell re-frame-http-fx-2 to wait n ms before reissuing the query, but maybe I'm missing something.

Firstly, this library has gone through several iterations and will likely go through more. Its very much subject to changes as its a more an experiment than anything else at this point. So this is important feedback and discussions to have at this point.
The original intent has always been, let the library user decide and implement their own state handling logic. In other words, their own problem handling strategy, their own retry logic, exponential backoff or not etc. The library just provides a scaffolding on which to make those application-specific decisions.
In the current iteration the :in-problem state handler triggers any re-tries by returning the fx {:http {:trigger :retry :request-id request-id}.
Since the user writes the :in-problem handler, normal re-frame mechanisms for delays (dispatch-ms) can be used but it is a bit inconvenient as another event handler to return the fx would need to be provided.
In a previous iteration, re-tries used to be just dispatches instead of fx return values so it was more convenient to use dispatch-ms.
In any case, where this question of retries goes next largely depends on other major open design questions about the library such as if we will use the current http-focused fsm model at all or bake a more refined general concept of the same into re-frame proper.


[ADD] Added image upload capability from pull request #925

Motivation and Context

Description

Contribution Checklist

[ ] I have built and tested the code locally and in a deployed app
[ ] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
[ ] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
[ ] I didn't break any existing functionality :smile:

@pcgtbruns is there a flag for me to disable this feature ?


Unify nptracker and VMP

Unify nptracker and VMP

Update tracker struct to store NetworkPolicyStatus. Minor optimisation on the VMP rest, to avoid computing NetworkPolicyStatus for an ANP.
Also cleanup trackers when account is deleted.

Signed-off-by: Anand Kumar<EMAIL_ADDRESS>

/nephe-test-e2e-agentless

/nephe-test-e2e-agentless

/nephe-test-e2e-kind

/nephe-test-e2e-eks

/nephe-test-e2e-aks


Add files via upload for my university

@y-67 Regrettably, this request has signs of fraud. I have to close it without merging.
It does not mean that something is wrong with the school. The issue is related to a combination of suspicious factors related to the domain itself.
Please feel free to apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for your understanding!


Update ProceduralFairings

Update ksp_version
Update resources.homepage to new format
General cleanup of the spacing

LGTM, merging with thanks.


Connection management for unused endpoints

In partition moved / upgrade scenarios, an address / endpoint may not be used by any physical partition for containers taking part in the connection warm up flow. Such addresses / endpoints should be removed from the open connections flow.

API change check
API changes are not detected in this pull request.


The filter is not properly styled on the products page

The filter div is not properly styled on the products page in mobile-view.
It is overlaying on the products cards.
This issue is coming on all the products categories.
It should be styled properly in mobile-view.

https://github.com/user-attachments/assets/c641be87-6947-4a8d-8f23-42960f91246c

I am a GSSoC'24 contributor.
I want to work on this issue.
Please assign this issue to me under GSSoC'24.

@codervivek5 Please assign this issue to me under GSSoC'24


Couldn't Find the "Dotted Edges Function"

Could you please give us the example codes for each architecture?
I need to draw the "dotted edges", unfortunately, I did not find it. Could you please help me the find out the function, please?
-- Rafsanjani

I have solved the above issue.


Implement explorer page

[ ] Create route for explorer page

create quick wireframe for the showcase page

This page should give a brief intro the experiments
experiments should be show cased as a card and linked to
create placeholder experiment


API delegering - virksomhet søk gir ikke noe treff

Gå til API delegering side
Start API delegering og søk etter en org - gir ikke noe treff
Den pleide å funke i går, nå feiler det i alle AT miljøer

Please create these issues in altinn-access-management-frontend repo instead so we don't have to transfer it before referring it in our PRs

Testet akkurat fiksen som ble pushet på dette @anishastphen, nå skal det funke igjen i alle andre miljøer enn AT23 😁

@anishastphen
I've added a fix that works in AT23 as well. So that you can search for orgs.
However, since the mock is now active in this environment, you can only search for orgs that are present in the mock data.
To this end I've added 910510789 (VIKESÅ OG ÅLVUNDFJORD) and 991825827 (Digitaliseringsdirektoratet) to the registry mock data so that these are now available for search.
But delegation to them will unfortunately fail.
If there is a certain user (with org) that you usually use for testing and an org you usually use for delegation, you can send me their info (with partyid's) and I can add them to the full flow of the mock data.
Otherwise, the mocking will only be a temporary thing anyway, so maybe it's tolerable that just AT23 will have some failing tests for now.

fix works in AT22 and AT24, fails only in AT23
so will close the issue for now and will check in AT23 once its available


new synonyms for abnormal dental pulp canal morphology and abnormal dental pulp chamber morphology

PMID:38105557 uses coronal and radicular as synonyms for pulp chamber and pulp canal, respectively we should add the synonyms
abnormal coronal pulp chamber morphology for abnormal dental pulp chamber morphology
abnormal radicular pulp morphology for abnormal dental pulp canal morphology
also the tow terms have child terms for enlarged but not for decreased so we should add those

Synonyms have been added, as suggested above.
Also added:
small dental pulp chamber MP:0031621
small dental pulp canal MP:0031622


More reponses when loading on cp

You get a response and you get a response everybody gets a response! (7 new ones that are even worse then the others)

Remove the 404 one

To corny? ok

@jonas747 done

Replaced with I think its working...


fixes mount().debug() output with mixed children

closes #475
could one of the other maintainers look at this to make sure this change actually makes sense?

LGTM. should we make sure we have a similar test for shallow debug?

@ljharb good point, I've added it


Changing editor tabs causes system lag

Select the SuiteCloud tool where you encountered the issue
SuiteCloud Extension for VSCode
Version of the SuiteCloud Tool
v1.6.0
Operating system
Windows 10
Node Version / VSCode Version
v20.9.0
JAVA Version
java 17.0.10+11-LTS-240
Bug description
Type: Performance Issue
Full system slowdown for 5-8 seconds when changing tabs in VSCode. Used the Extension Biset feature to isolate the SuiteCloud extension as the culprit
Extension version: 1.6.0
VS Code version: Code 1.87.1 (1e790d77f81672c49be070e04474901747115651, 2024-03-06T00:21:36.258Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 1805)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.73GB (15.29GB free)

Process Argv
--crash-reporter-id af82388d-2eb5-4c4f-b138-07764eaf55b8

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    2	   144	 22196	code main
    0	   207	  5392	extensionHost [2]
    0	    87	  8236	     electron-nodejs (start-server.js )
    0	   133	 12812	     "C:\Users\pkennedy\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\pkennedy\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=5392
    0	    85	 15796	     electron-nodejs (languageserver.js )
    0	    86	 19232	     electron-nodejs (tsserver.js )
    0	   112	 21836	     "C:\Users\pkennedy\AppData\Local\Programs\Microsoft VS Code\Code.exe" c:\Users\pkennedy\.vscode\extensions\streetsidesoftware.code-spell-checker-3.0.1\packages\_server\dist\main.cjs --node-ipc --clientProcessId=5392
    1	   294	 24076	     electron-nodejs (tsserver.js )
    0	    88	 13460	       electron-nodejs (typingsInstaller.js typesMap.js )
    0	    85	 24684	     electron-nodejs (eslintServer.js )
    0	    33	  6676	   crashpad-handler
    0	    84	  7624	ptyHost
    0	    11	 20272	     conpty-agent
    0	    78	 24228	     "C:\Program Files\PowerShell\7\pwsh.exe" -noexit -command "try { . \"c:\Users\pkennedy\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\contrib\terminal\browser\media\shellIntegration.ps1\" } catch {}"
    0	    49	 15864	   utility-network-service
    0	   106	 21164	shared-process
    0	   321	 23936	window [1] (Api.ts - non-netsuite-project - UHK Support - Visual Studio Code)
    1	   120	 23960	window [3] (Issue Reporter)
    0	   211	 25916	window [2] (df-ukg-api.js - netsuite-account-customization-sandbox-1 - UHK Support - Visual Studio Code)
    0	    77	 25952	fileWatcher [2]
    0	   132	 27848	   window
    0	   267	 28340	   gpu-process
    0	   111	 32852	fileWatcher [1]
    0	   389	 33008	extensionHost [1]
    0	   232	   952	     electron-nodejs (tsserver.js )
    0	   127	 28044	       electron-nodejs (typingsInstaller.js typesMap.js )
    0	   113	  2292	     electron-nodejs (eslintServer.js )
    0	   115	 16728	     electron-nodejs (languageserver.js )
    0	   109	 24320	     electron-nodejs (start-server.js )
    0	   107	 28624	     "C:\Users\pkennedy\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\pkennedy\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=33008
    0	   130	 34336	     "C:\Users\pkennedy\AppData\Local\Programs\Microsoft VS Code\Code.exe" c:\Users\pkennedy\.vscode\extensions\streetsidesoftware.code-spell-checker-3.0.1\packages\_server\dist\main.cjs --node-ipc --clientProcessId=33008
    0	   154	 34728	     electron-nodejs (tsserver.js )

Workspace Info
|  Window (df-ukg-api.js - netsuite-account-customization-sandbox-1 - UHK Support - Visual Studio Code)
|  Window (Api.ts - non-netsuite-project - UHK Support - Visual Studio Code)
|    Folder (netsuite-account-customization-sandbox-1): 681 files
|      File types: js(410) csv(17) json(10) md(7) ts(7) gitkeep(6) html(3)
|                  gitignore(2) xml(2) gif(2)
|      Conf files: package.json(2) jsconfig.json(1) project.json(1) gulp.js(1)
|    Folder (non-netsuite-project): 593 files
|      File types: ts(156) js(143) map(143) md(22) json(20) sh(4) gitignore(2)
|                  txt(2) yaml(2) editorconfig(1)
|      Conf files: package.json(2) launch.json(1) settings.json(1)
|                  tasks.json(1) tsconfig.json(1)
|      Launch Configs: node(2);

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
vscrpc:30673769
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30986170
pythontbext0:30879054
accentitlementst:30887150
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:30979542
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
dsvsc020:30976470

Steps To Reproduce
There isn't much needed to reproduce. When the extension is active in either a repo with NetSuite files or one completely devoid of NetSuite files when changing tabs/editors the system heavily lags for 5-8 seconds. The mouse buffers and slowly works its way through the path.

Open project with SuiteCloud extension installed
Open several editors
Switch between editors and wiggle mouse

Actual Output
No response
Expected Output
No response
Anything else?
No response

Hi @df-pkennedy
Thanks for your message and all the info you shared with us.
I cannot replicate the issue with a project of similar size than yours. However, could you please share with us the following?

A screenshot of your environment, I am specially interested in the info that appears in the status bar like in the follow image.

Could you try to install version 1.3.2 of our VsCode Extension and see if you have similar problem? We have some suspicion about a feature that was inserted after.

Thanks.

@df-pkennedy I dont think this is related to the suitecloud extension.
Can you try increasing the allocated resources in VSCode?
You can increase/decrease the available RAM for VS Code on its Settings. Go to File -> Preferences -> Settings, there you can type files.maxMemoryForLargeFilesMB and change the value for your desired maximum RAM. Restart VSCode and try again.

Closing because of no response


Download remote folder

Every-time I try to Right click -> Download on a remote folder the plugin tells me to "Please select a folder first".
I can only surmise that this is not intended behaviour as there is nowhere to "Select a folder first"

Did you try left clicking on the folder first to select it?

First left-click a folder to select it, then right-click -> "Download"


Add Unit Tests

closing this issue as it is too wide of a focus and also we have added first set of unit tests.


How to set slider initPosition from the activity? It should be dynamic. Because it could be different in each time.

Version 0.9.3 is available now. You can call setInitPosition dynamically.


Network Foundations: Client unclassified Service Project Creation

As a; Platform Engineer
I want: To be able be implement within our landing zone the client services project
So that: we can realize the network design and deploy it in a repeatable, tested manner
Refinement Notes:
In Scope: Unclassified projects
Out of Scope: Evolution to tenant namespaces

Acceptance Criteria:

namespace and GCP SA, K8S SA, IAM permissions, project to allow tier4 resources management
billing id is attached to the project
kpt package is published
documentation is created
security controls identified for package and documentation


unit tests: order of arguments

I see in std/unittest.e:
public procedure test_equal(sequence name, object expected, object outcome)

But many of the tests have outcome before expected.
That will lead to confusing test error messages. For example, in the raindrops exercise, if the number is not divisible by 3 or 5 or 7, I return the incorrect value "foo", and the test results say:
  failed: 2 to the power 3 does not make a raindrop sound as 3 is the exponent not the base, expected: "foo" but got: "8"

This will be a large effort to fix. I can help if you want to divide the labour.

There are 20 tasks. If you're happy to take the top 10....

Added test_aquels() shim to flip the args, PR created for this.

All fixed


Don't load image from cache

My server unfortunately returns the same image URL even if the picture is updated. Therefore I somehow need to skip the cache when loading an image. Could you please help me how this can be done?
I tried to clear the cache before loading the image:
 PINRemoteImageManager.sharedImageManager().defaultImageCache().removeAllObjects()
 profileImage.pin_cancelImageDownload()
            profileImage.pin_setImageFromURL(profileImageURL, placeholderImage: placeHolder) {
                (result:PINRemoteImageManagerResult!) in
            }

Nevertheless the image is returned from the cache.

The call to profileImage.pin_cancelImageDownload() makes me suspicious.
Here's a situation that can happen with the above code.
Lets say you've called pin_setImageFromURL with a URL. Let's say it's not in the cache, so it goes off and downloads the image.
Now lets say you run the above code. Clearing the cache does nothing because the image isn't in there yet.
Then, you cancel the image download. Cancelling a download isn't guaranteed to happen synchronously, and therefore may or may not prevent the original download from completing and getting set in the cache.
Then, when you call pin_setImageFromURL again, lets say the image from the first call has finished downloading and now is in the cache. It will get returned.
If this is an issue for you, you could submit a PR for a synchronous version of cancelImageDownload.

Hopefully this helps, feel free to re-open if this doesn't explain your issue.


Primary button variant has too low contrast for the expanded button

Rather than setting the background color of the host element, we could use one of the pseudo-elements, the same which is used for the hover effect. Instead of lightening, it should probably get darker when expanded.

Closing in favor of https://github.com/vaadin/vaadin-web-components/issues/119 which describes the same problem.


remove redundant useMemo and afterUpdateCallback

mapActions is js functional object; react will re-create it on each reconcilation so useMemo does nothing here; also mapActions is a straightforward O(1) function so its optimisation will cost more than direct use

afterUpdateCallback is not used from anywhere

released in<EMAIL_ADDRESS>


Include available Refactor menus in Contextual Code Generation list

I had a feeling that the Refactor menus are very useful, but they are not easily accessible due to the fact that every option needs a separate shortcut assigned in order to access using keyboard only (unless you press the right-click button on your keyboard which is cheating). So, inspired by Visual Studio, I thought it would be nice if the available options were to show up in the existing code generator menu (assign the shortcut to Ctrl+OemPeriod and boom).

Currently

Rename
Extract Method
Extract Local Variable
Generate Delegate Methods
Organise Imports
Truncate Imports

are available in the completion list, but more can be added with just 2 lines of code for each.
Plus, extended the support of Convert to Constant to also work for strings.

Great idea! :+1:

Really neat contribution!


SQL Syntax Issue

I am submitting the following to my elasticsearch instance.  While my local docker instance returns my records starting with graphic, the AWS Open Distro returns me any records that contain graphic.  Is this something that can be addressed or work around provided.
Sample Query
query="SELECT * FROM company_1 WHERE name LIKE 'graphic%'"
Thank You

Hi @mlrlite, can you clarify the versions in each situation? In one situation, it sounds like you're running the ODFE Docker image locally. Which version?
In the other situation, when you say "AWS Open Distro," do you mean Amazon Elasticsearch Service? One of the RPM or Debian packages on EC2? Something else? Which version?
The SQL plugin is constantly evolving, so I wouldn't be surprised if this was a bug in older versions that's since been fixed.

My local has the following
{     "cluster_name": "docker-cluster",     "cluster_uuid": "9YSYZx8PSP6mbzSR4MaflA",     "name": "12b8b4ddfaa3",     "tagline": "You Know, for Search",     "version": {         "build_date": "2019-09-06T14:40:30.409026Z",         "build_flavor": "default",         "build_hash": "1c1faf1",         "build_snapshot": false,         "build_type": "docker",         "lucene_version": "8.1.0",         "minimum_index_compatibility_version": "6.0.0-beta1",         "minimum_wire_compatibility_version": "6.8.0",         "number": "7.3.2"     } }
My aws service is using:
{   "name" : "dcb6310d7bf62ea71ad53d4a79c3687d",   "cluster_name" : "279625311674:spendhq-es-search-demo",   "cluster_uuid" : "AcZ9u2aAQDmcY-J7mpvlkg",   "version" : {     "number" : "7.1.1",     "build_flavor" : "oss",     "build_type" : "tar",     "build_hash" : "7a013de",     "build_date" : "2019-09-05T07:25:23.525600Z",     "build_snapshot" : false,     "lucene_version" : "8.0.0",     "minimum_wire_compatibility_version" : "6.8.0",     "minimum_index_compatibility_version" : "6.0.0-beta1"   },   "tagline" : "You Know, for Search" }
Please let me know if there is anything else I can provide.

Hi @mlrlite, it looks like your Docker cluster is running the "default" version of Elasticsearch, which doesn't have the ODFE plugins and instead has a proprietary SQL plugin. Did you install the ODFE SQL plugin manually on the Docker image? If you didn't and are instead using the proprietary plugin, that could absolutely cause the difference in behavior, as the two codebases have nothing in common.
I just tested ODFE 1.3 vs. Amazon Elasticsearch Service, which is running an older version of the ODFE plugin, and the search results for your query were identical.

I was able to use the aws open distro version locally and now both environments are identical.  I am still facing the same issue with my original post
query="SELECT * FROM company_1 WHERE name LIKE 'graphic%'" returns me any records with the name like 'graphic' and not starting with.  At this point I have to separate each 'phrase' with like statements which seems excessive but the only way people are accomplishing this at the moment.

Hey @mlrlite, are you saying that your local ODFE cluster and your AES domain are now behaving identically, but the behavior is undesirable? Or they behaving differently, and one behavior is desirable and the other isn't?
If they're behaving the same, then it's likely just a SQL bug that we can report and investigate. If they're behaving differently, then there's more troubleshooting to do.

Yes my local and aws are now in sync.
Currently I believe we have narrowed the issue down to a SQL bug.  Let me provide an example.
With the normal elasticsearch docker install (not ODFE), the following returns me what I want (phrases starting with 'graphic')
query="SELECT * FROM company_1 WHERE name LIKE 'graphic%'"
example results: graphic company 1, graphic llc
With ODFE, the same query returns me any words containing 'graphic'.  It just seems the like statement isn't performing the sql like it should.
example results: alpha graphic inc, california graphics corporation
My expectation is that when using 'graphic%' it should perform like any other sql should.  In ODFE it does not.  what would the next steps be?

Hi @mlrlite, awesome, thanks. That sounds like a bug on our end. I've reported it in the SQL repository here: https://github.com/opendistro-for-elasticsearch/sql/issues/368


DynamoDBContext.GetUnconfiguredTable not always the same as AmazonDynamoDBClient.DescribeTable result

Probably a bit of an edge case here, but here's the scenario:
Trying to create an operation that changes the keys on a dynamo table, this seems to be only possible by deleting and recreating the table - if there's a better way then that would be preferable.
This used to work with the old unified SDK.
We're testing using DynamoDB Local (not sure if that's relevant.)
Ignoring that this code is indescribably crude 🙍
The Client property is an instance of AmazonDynamoDBClient that is created when the local dynamo is spun up, and retained throughout the test run.
private void MoveToDifferentSchema<TFrom, TTo>(Func<TFrom, TTo> transform, List<KeySchemaElement> keySchemaDefinition, List<AttributeDefinition> attributeDefinitions)
{
   TFrom[] existingData;
   using (var context = new DynamoDBContext(Client))
   {
      existingData = context.Scan<TFrom>().ToArray();
   }

   var tableInfo = Task.Run(() => Client.DescribeTableAsync(new DescribeTableRequest()
   {
                TableName = TableUtilities.DetermineTableName<TFrom>()
   }).Result).Result;

   Client.DeleteTable(TableUtilities.DetermineTableName<TFrom>());
   WaitForTableToBeDeleted<TFrom>(TimeSpan.FromSeconds(30));

   var createRequest = new CreateTableRequest(
      TableUtilities.DetermineTableName<TTo>(),
      keySchemaDefinition,
      attributeDefinitions,
      new ProvisionedThroughput(tableInfo.Table.ProvisionedThroughput.ReadCapacityUnits, tableInfo.Table.ProvisionedThroughput.WriteCapacityUnits));

   Client.CreateTable(createRequest);

   WaitForTableToBeCreated<TTo>(TimeSpan.FromSeconds(90));

   BatchWriteItems(existingData.Select(transform));
}

private void BatchWriteItems<T>(IEnumerable<T> data)
{
   using (var context = new DynamoDBContext(Client, new DynamoDBContextConfig()) {
      _logger.Info(GetType(), "Table created, writing migrated data");
      var write = context.CreateBatchWrite<T>();

      write.AddPutItems(data);

      write.Execute();
      _logger.Info(GetType(), "Migrated data written.");
   }
}

The code fails on the BatchWriteItems with the error message that "Number of range keys does not match the number of hash keys on table..."
The trigger seems to be that calling Context.GetUnconfiguredTable with the tablename returns the previous schema with just one key, whereas the call to Client.DescribleTable gives the new Schema.
Given the Context is created new, presumably there's some level of shared cache here around the table configs that isn't up-to-date with the table change.
Anyone able to help?

My suspicious appears to be correct, as adding Table.ClearTableCache(); before doing the write fixes the test.

You are correct, there is an in-process cache and that is exactly what you are running into.
We cover it in some detail in this blog post, including clearing it out using Table.ClearTableCache() as you noticed, or disabling it altogether.
If you are only "modifying" tables during testing, it might be a good idea to disable the cache there.

@PavelSafronov Okay, that's fine. Why doesn't the cache reflect operations the SDK itself does?
In this case, I'm deleting a table through the SDK, so surely it should remove that table from the cache?

The approach you describe may work, but would require a number of checks (need to verify that the same account is doing the delete, even if different credentials under a common account are used, in the same region or ServiceUrl), and would only be able to catch a small number of delete scenarios (it would only work if delete is performed in the same process). If we did go with this approach, the solution would be incomplete and fairly complicated.
Additionally as you pointed out this is an edge case, since a large number of users are likely working with unchanging tables, so we decided to go with the simpler approach that will cover almost all of the customers and provided cache controls for the other cases.

The original and follow-up questions have been answered, I'm going to close this issue.


Incompatibility with Django 1.8

Per Django 1.8 docs:
### Database backend API

The following changes to the database backend API are documented to assist those writing third-party backends in updating their code:

BaseDatabaseXXX classes have been moved to django.db.backends.base. Please import them from the new locations:

I am working on a patch for this. Looks to be a simple fix of switching imports out.

That's great. Glad they're starting to think about backend developers.

I used your pull request in my #102 which solves more related problems with Django 1.8, but also not all. Maybe it is enough for you. More info in my Readme.


Indices Error in CRF

Hi!
I dont know if you can help me, but Ill ask.
I created my own pipeline to generate data in the format that is needed by your network, without needing to save it in a file or something like that. Right now Im not using any word embeddings, and the network is training and loss is falling. Until at some point in the training an error comes up:
InvalidArgumentError (see above for traceback): indices[2,5] = 1716 is not in [0, 1681)
[[Node: crf/Gather_1 = Gather[Tindices=DT_INT32, Tparams=DT_FLOAT, validate_indices=true, _device="/job:localhost/replica:0/task:0/cpu:0"](crf/Reshape_3, crf/add_2)]]
Which happens at the tf.contrib.crf.crf_log_likelihood
Do you have any idea what this could be?

Nevermind, I found it, it was just a index shift, because my tags started at 1 instead of 0. The error message was just to cryptic for me.

great you found out! closing the issue.


Converting web pages with authentication

Is there a way to use this on websites that require authentications?

Not directly on the command line, but if you use it through Rails and a controller with a pdf respond_to format, authentication works through Rails. See the readme section on Rails middleware.


Race condition in chargePoint.Start()

chargePoint.Start() sets global variable
ocppj.FormationViolation = ocppj.FormatViolationV16

Same variable is written by centralSystem.Start() which creates a race condition during test.
This is particularly problematic since centralSystem.Start() cannot be serialised, i.e. it is not clear when the cs actually has started.

A potential workaround could be to use dispatcher.IsRunning() to determine if at least the cs' Go routine has started. This leads to another race. While dispatcher.IsRunning() uses mutex, DefaultServerDispatcher.Start() does not serialise its access to d.running. I can provide a PR for this second race.

@lorenzodonini thank you for the quick merge. Could we keep this issue open? The workaround is now fixed, the race in ocppj.FormatViolationV16 still present. I you can give a hint what this value- shared between CS and CP- should do I could take another look.

Looks like there is a design issue with FormationViolation. It is used for creating error messages in ocppj.Endpoint. Instead of global variable it should be part of endpoint defintion.

I agree this should be an override within the endpoint instead of a global variable. I re-opened the issue and will move the discussion to the open branch.


[cellClass]/[rowClass] function does not have the scope of component class

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
at the moment it is not possible, to add a style-classe depending on a property from the component (in the plnkr example below you can see one property name I'm checking against in the getClass-fucntion and one hardcoded - which does work).
is there already a way to inject some properties into the function over the template? or is it possible to change the function call internally to apply the scope from the class?
Expected behavior
possibility to change the scope of the function to the scope of the component where the function belongs to, or the possiblity to inject parameters for some checks
Reproduction of the problem

http://plnkr.co/edit/iQWBqGpJwt0o9sB0BzOk
What is the motivation / use case for changing the behavior?

my special need for it is to highlight rows when they match on a property which is set in the component class
Please tell us about your environment:

Table version:
9.1.0

Angular version: 4.1.1

Browser: [all]

Language: [all]

Possible workaround:
Instead of this:
@Component({
  ...,
  template: `<ngx-datatable [rowClass]="getRowClass"></ngx-datatable>`
})
class SomeComponent {
  otherFunc() {
    return true;
  }

  getRowClass(row) {
    return {
      'some-class': this.otherFunc()
    };
  }
}

Do this:
@Component({
  ...,
  template: `<ngx-datatable [rowClass]="rowClass"></ngx-datatable>`
})
class SomeComponent {
  otherFunc() {
    return true;
  }

  rowClass = (row) => {
    return {
      'some-class': this.otherFunc()
    };
  }
}

Awesome, thanks for providing that example @eppsilon !
Would you mind PR'n this to the docs :)?

@eppsilon thanks the solution works.
Any idea if there is any performance issue with this?
From what I understand, the fat arrow syntax creates a new function every time it is triggered, and it seems to be triggered for every row.

You can also use an anonymous arrow func to reference the component scope:
@Component({
  ...,
  template: `<ngx-datatable [rowClass]="rowClass"></ngx-datatable>`
})
class SomeComponent {
  someVariable = true;

  rowClass = (row) => {
    return {
      'some-class': (() => { return this.someVariable === row.someVariable })()
    };
  }
}

not able to add multiple classes

not able to add multiple classes
getRowClass(row) {
return {
'class1': row.isImportant,
'class2': row.isWarning,
};
}


Unicode regexes not supported

[21:53:07]>>> parse(u'我')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/d33tah/virtualenv-py2/local/lib/python2.7/site-packages/greenery/lego.py", line 1641, in __repr__
    string += ", ".join(repr(c) for c in self.concs)
  File "/home/d33tah/virtualenv-py2/local/lib/python2.7/site-packages/greenery/lego.py", line 1641, in <genexpr>
    string += ", ".join(repr(c) for c in self.concs)
  File "/home/d33tah/virtualenv-py2/local/lib/python2.7/site-packages/greenery/lego.py", line 1404, in __repr__
    string += ", ".join(repr(m) for m in self.mults)
  File "/home/d33tah/virtualenv-py2/local/lib/python2.7/site-packages/greenery/lego.py", line 1404, in <genexpr>
    string += ", ".join(repr(m) for m in self.mults)
  File "/home/d33tah/virtualenv-py2/local/lib/python2.7/site-packages/greenery/lego.py", line 1169, in __repr__
    string += repr(self.multiplicand)
  File "/home/d33tah/virtualenv-py2/local/lib/python2.7/site-packages/greenery/lego.py", line 636, in __repr__
    string += repr("".join(str(char) for char in sorted(self.chars, key=str)))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u6211' in position 0: ordinal not in range(128)

I've seen (very frustrating) issues like that before and in my experience they are generally caused by one's console encoding. The Python program
from greenery.lego import parse
print(parse(u'我'))

works fine for me at the command line with python uni.py, so in any case this isn't a problem with greenery.

Uh, also, Python 2.7 is not supported.


[bug] set_actionvation_policy() breaks window.show()

Describe the bug
Making an app use the Accessory activation policy (app.set_activation_policy(tauri::ActivationPolicy::Accessory);) makes the window.show() method not work.
P.S. I wrote in the Discord forums and they asked me to log the issue here.
Reproduction
main.rs:
fn main() {
    tauri::Builder::default()
        .setup(|app| {
            app.set_activation_policy(tauri::ActivationPolicy::Accessory);
            Ok(())
        })
        .invoke_handler(tauri::generate_handler![greet])
        .run(tauri::generate_context!())
        .expect("error while running tauri application");
}

tauric.conf.json:
"windows": [
  { "visible": false }
]

App.tsx (you can do it in global shortcut handler):
getCurrent().show();

Expected behavior
The window to show.
Platform and versions
Environment
› OS: Mac OS 12.4.0 X64
› Node.js: 16.15.1
› npm: 8.11.0
› pnpm: Not installed!
› yarn: 1.22.19
› rustup: 1.25.1
› rustc: 1.63.0
› cargo: 1.63.0
› Rust toolchain: stable-aarch64-apple-darwin
Packages
› @tauri-apps/cli [NPM]: 1.0.5
› @tauri-apps/api [NPM]: 1.0.2
› tauri [RUST]: 1.0.5,
› tauri-build [RUST]: 1.0.4,
› tao [RUST]: 0.12.2,
› wry [RUST]: 0.19.0,
App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:1420/
› framework: React
App directory structure
├─ node_modules
├─ public
├─ src-tauri
├─ .vscode
└─ src
Stack trace
No response
Additional context
No response

Hello, my app uses vanilla js but calling appWindow.show() works fine on accessory. Perhaps it's just typescript?


Bug: missing windows build for 0.8.5

Description
PS C:\Users\zeno.jiricek\.dotfiles> comtrya apply -m shells.powershell

A new version of comtrya is available: v0.8.4 -> v0.8.5
Changelog: https://github.com/comtrya/comtrya/releases/tag/v0.8.5
Run to update: curl -fsSL https://get.comtrya.dev | sh
ERROR execute:manifest_load{manifest="asdf.yml"}: Unrecognized file extension for manifest
ERROR execute:manifest_load{manifest="neovim.yml"}: Unrecognized file extension for manifest
ERROR execute:manifest_load{manifest="xresources.yml"}: Unrecognized file extension for manifest
ERROR execute:manifest_load{manifest="systemd.yml"}: Unrecognized file extension for manifest
ERROR execute:manifest_load{manifest="autorandr.yml"}: Unrecognized file extension for manifest
ERROR execute:manifest_load{manifest="awesome.yml"}: Unrecognized file extension for manifest
ERROR execute:manifest_load{manifest="picom.yml"}: Unrecognized file extension for manifest
ERROR execute: Unresolved dependency dependency="devtools.asdf"
ERROR execute: Unresolved dependency dependency="devtools.ssh"
ERROR execute: Unresolved dependency dependency="devtools.wsl2-create"
 INFO execute:{manifest="packagemanagers.scoop"}: Completed
 INFO execute:{manifest="packagemanagers.winget"}:{action=file.copy}: nothing to be done to reconcile action
 INFO execute:{manifest="packagemanagers.winget"}: Completed

cmdlet Remove-Item at command pipeline position 1
Supply values for the following parameters:
Path[0]:
PS C:\Users\zeno.jiricek\.dotfiles> comtrya -v
comtrya 0.8.4

USAGE:
    comtrya.exe [FLAGS] [OPTIONS] <SUBCOMMAND>

FLAGS:
    -h, --help        Prints help information
        --no-color    Disable color printing
    -V, --version     Prints version information
    -v, --verbose     Debug & tracing mode (-v, -vv)

OPTIONS:
    -d, --manifest-directory <manifest-directory>    Directory

SUBCOMMANDS:
    apply       Apply manifests
    contexts    List available contexts (BETA)
    help        Prints this message or the help of the given subcommand(s)
    version     Print version information
PS C:\Users\zeno.jiricek\.dotfiles> iwr "https://get.comtrya.dev/ps" -UseBasicParsing | iex
Installing comtrya to C:\Users\zeno.jiricek\.comtrya

    Directory: C:\Users\zeno.jiricek

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          24/08/2023 10:10 AM                .comtrya

Installed comtrya 0.8.4

Installation complete.
Add comtrya to your path by adding the following line to your Microsoft.PowerShell_profile.ps1 and open a new terminal:
$env:PATH+=";$env:USERPROFILE\.comtrya"

PS C:\Users\zeno.jiricek\.dotfiles>
PS C:\Users\zeno.jiricek\.dotfiles>
PS C:\Users\zeno.jiricek\.dotfiles>
PS C:\Users\zeno.jiricek\.dotfiles> comtrya -v
comtrya 0.8.4

USAGE:
    comtrya.exe [FLAGS] [OPTIONS] <SUBCOMMAND>

FLAGS:
    -h, --help        Prints help information
        --no-color    Disable color printing
    -V, --version     Prints version information

Steps to reproduce
 PS> iwr "https://get.comtrya.dev/ps" -UseBasicParsing | iex
 PS> $env:PATH+=";$env:USERPROFILE\.comtrya"
 PS> comtrya -v

Expected behaviour
comtrya -v should be and report latest version (at this time it's 0.8.5 and not the one it prints which is 0.8.4)
Environment

OS: windows 11
Version: comtrya --version see above.

Additional information
Add more context which didn't fit in the fields above.

btw all my manifests are here https://github.com/airtonix/dotfiles

I am assuming with newer releases and having figured out how to do releases, we can close this now.


UUID pattern of tcp-client OAM service needs an update

The current pattern provided for uuid of tcp-client-interface-configuration Oam services is
"^([a-z]{2,6})-([0-9]{1,2})-([0-9]{1,2})-([0-9]{1,2})-tcp-c-([a-z]{2,6})-([0-9]{1,2})-([0-9]{1,2})-([0-9]{1,2})-000$"
The sequence number here is "000".
Problem statement:
As per understanding, it is possible that more than one tcp-client instance shall be created for an application.
For example, in RegistryOffice://v1/register-application, we have an attribute called "tcp-server-list". So, while registering an application, an application is allowed to inform it's both HTTP and HTTPS addresses to RO. In this case, multiple tcp-clients would be created for an http-client instance.
Proposal:
To update "sequence-number" part of uuid pattern to be ([0-9]{3}) instead of 000.
So, the pattern would look like "^([a-z]{2,6})-([0-9]{1,2})-([0-9]{1,2})-([0-9]{1,2})-tcp-c-([a-z]{2,6})-([0-9]{1,2})-([0-9]{1,2})-([0-9]{1,2})-([0-9]{3})$".
Updating shall be made in tcp-client/remote-protocol, tcp-client/remote-address and tcp-client/remote-port Oam service APIs.
Kindly let me know your thoughts

Call on 17th of February:
I would prefer having just one cin the Config.
To be checked, whether this is possible.
Issue to be closed, if possible having just one TcpClient.

Kindly please find the following details ,

Apart from RegistryOffice , for other applications , there should be a single tcp-client.
In RegistryOffice , to provide “https” information of an application to GenericRepresentation GUI, this tcp-server-list attribute was introduces , where

every registering application shall also provide the “https” information if available
if more than 1 tcp information is provided in the tcp-server-list , then for each , a tcp-client will be created in the RO’s config file

By default , the tcp-client with suffix “-000” will be considered for internal communication within the MicroService Environment
(This concept is now obsolete) For generic representation GUI, the mapped tcp-client uuid in the “Action-profile” will point to the required instance
Based on the above point , for now , there is no use-case/logic utilizing the 2nd tcp-client

Kindly please consider the following proposal for further discussion ,
(There is a circular dependency)

Until we decide on the issue https://github.com/openBackhaul/ApplicationPattern/issues/649 , leaving

the tcp-server-list attribute in RO/register-application as it is now ,
the "sequence-number" part of uuid pattern of the tcp-client-interface-configuration Oam services as it is now

For internal communication , applications will use the tcp-client with suffix “-000” by default. (In case of wrong IP value , OAM services shall be used to correct them later)

Just one thought that came into my mind, while working myself back into the issue:
If the RO (or any other application) would hold >1 TcpClients, wouldn't that require to change the client update function, too?

Thanks for clarifying @openBackhaul


Elementable should not be a metaclass

This made sense when it actually returned the Element class, but now it just returns a container. It should just be a function, and honestly all the messy code inside it should also be functions.

Maybe the returned container should be an Enum? The only annoying thing is having to type .value all the time.


Support for html error messages with validation-msg-*

Should have support to show html as error message
validation-msg-pattern="
Not valid length

Not valid length
"
Not valid length

You're right, it should! Unfortunately I won't be able to look into this until next week probably the week after that. Pull Requests are always welcome of course :)
The related function can be found here: https://github.com/johannesjo/ng-fab-form/blob/master/src/ng-fab-form-p.js#L81

This should work now with the newest release.

Tnx


Fix link url

Summary
Fix link url that returns 404 Not Found.
Same as this PR: Fix 404 links by kaakaa · Pull Request #1642 · mattermost/docs
Ticket Link
N/A
Checklist

[x] Includes text changes and localization file (.../i18n/en.json) updates

Ah it's broken here too? Wow, thanks for finding this.
I'll also add a redirect from https://about.mattermost.com/default-plugins-uploads so that existing 4.4 installs won't have a broken link.


Error: NotSupportedError: Failed to load because no supported source was found.

Getting this error when using the audioplayers package:
Error: NotSupportedError: Failed to load because no supported source was found.
    at Object.createErrorWithStack (http://localhost:51082/dart_sdk.js:5054:12)
    at Object._rethrow (http://localhost:51082/dart_sdk.js:37670:16)
    at async._AsyncCallbackEntry.new.callback (http://localhost:51082/dart_sdk.js:37666:13)
    at Object._microtaskLoop (http://localhost:51082/dart_sdk.js:37526:13)
    at _startMicrotaskLoop (http://localhost:51082/dart_sdk.js:37532:13)
    at http://localhost:51082/dart_sdk.js:33303:9

Steps to Reproduce

Add the audioplayers package in the pubspec.yaml file below dependencies.
Get audio from the internet or just record some sample audio.
Add the audio file under the assets in pubspec.yaml file.
Anywhere in the main.dart file or any other file play audio using AudioCache().play('audio/[any file].[file extension]'); (don't forget to import it first).
Important: Run it on any web browser (chrome and edge are the only options currently).

Expected results: I expected the audio file to play normally.
Actual results: I got the above error.

Logs
flutter run --verbose:
  [+88446 ms] Error: NotSupportedError: Failed to load because no supported source was found.
     at Object.createErrorWithStack (http://localhost:60696/dart_sdk.js:5054:12)
     at Object._rethrow (http://localhost:60696/dart_sdk.js:37670:16)
     at async._AsyncCallbackEntry.new.callback (http://localhost:60696/dart_sdk.js:37666:13)
     at Object._microtaskLoop (http://localhost:60696/dart_sdk.js:37526:13)
     at _startMicrotaskLoop (http://localhost:60696/dart_sdk.js:37532:13)
     at http://localhost:60696/dart_sdk.js:33303:9

Hi @Xzoky174
From what I can see, the issue is related to a 3rd party plugin rather than to Flutter itself. Please open the issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself.
If you disagree, please write in the comments,
providing your flutter doctor -v, your flutter run -v,  your pubspec.yaml, a minimal reproducible code sample that does not use 3rd party plugins, your complete flutter run -v logs running the minimal code sample
and I will reopen it.
Thank you


Babel errors when using nativewind/babel plugin on brand new bare React Native Project

Describe the bug
Creating a new project with react-native-cli crashes on babel
To Reproduce
Steps to reproduce the behavior:

Follow the react-native-cli getting started

Run the project
The app should crash on babel

Expected behavior
App runs properly and allows adding tailwind classes to react native components
Expo Snack

Screenshots

Additional context
//babel.config.js
module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: ['nativewind/babel'],
};

@lakardion I got that error when trying the V4 which i think moved away from using Babel Plugin.
Check other versions

https://github.com/marklawlor/nativewind/issues/600#issuecomment-1804741121


Logo/icon ideas

Here are a few ideas for logos/icons to get started. If any of them take your fancy, suggest some directions to take them forward. I've kept to the Julia colorscheme for now, since that seems to be the thing...

Hrm, since it's about technical documentation, maybe work with cogwheels? E.g. like this, but with three julia-coloured wheels and the document only indicated in the background (in light grey or something)?

Yes, I've done cogwheel action before...

However, the idea has already been used to good effect by the https://github.com/JuliaInterop org. And it is a well-worn cliché too, so worth avoiding for that reason as well?

Hehe, the wheels look cool. Ok, JuliaInterop has the three wheels. So what about a single wheel in the background and three julia-coloured documents in the foreground (possibly "connected" by the wheel?). Or the three documents in a "cycle of arrows" to illustrate the (fast) iterative workflow of JuDoc?

Q&D illustration of the last idea:

That's great!

How about this version? Any suggestions for further improvements? Smaller "documents" to make the circle more prominent?

Ok, getting closer I think:

Ok, one more; could not get the cogwheel out of my head. This one is not really "clean" yet, but illustrates the idea:

Wow all this is great, thanks both! @asprionj I must admit I prefer the circle with the 3 docs rather than the cogwheel one. @cormullion I quite liked your central one (The J's in  a circle) but I fear it's a bit too Julia generic?

Yes, it’s a familiar problem with logo design, whether to go ‘swoosh’ or ‘wrench’: https://pivotmarketing.com/4-things-logo-doesnt/


Update from 'EMMO-python' -> 'EMMOntoPy'

Description:

Fixes #476
The repository name has been changed !!!
This PR updates all repository files that mentions the now old name to the new name, where applicable.
Type of change:

[x] Bug fix.
[ ] New feature.
[ ] Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

[ ] Is the code easy to read and understand?
[ ] Are comments for humans to read, not computers to disregard?
[ ] Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
[ ] Has the documentation been updated as necessary?
[ ] Does this close the issue?
[ ] Is the change limited to the issue?
[ ] Are errors handled for all outcomes?
[ ] Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Fixed the issue with the pre-commit CI/CD job by using Python 3.8 instead of Python 3.7 in the job.
It seemed to me that this was the issue due to bandit referencing EntryPoints, which has been significantly updated between the two verisons.
Another solution would be to downgrade bandit in the pre-commit hook config file, however, I'd prefer to have the latest version running for these hooks - especially bandit, which tries to find security risks in the code.
All other jobs are still running with Python 3.7 to ensure the package still works with this lowest supported version.


aspnet-codegenerator Unhandled Exception: System.InvalidOperationException: Failed to get Project Context

Trying to use aspnet-codegenerator to scaffold a razor page as outlined here;
https://docs.microsoft.com/en-us/aspnet/core/tutorials/razor-pages/model
And getting an "Unhandled Exception: System.InvalidOperationException: Failed to get Project Context" for any action. My project is targeting net47
>dotnet aspnet-codegenerator razorpage -h

Unhandled Exception: System.InvalidOperationException: Failed to get Project Context for C:\Dev\Neptune\Neptune.Web\Neptune.Web.csproj.

   at Microsoft.Extensions.ProjectModel.MsBuildProjectContextBuilder.Build()
   at Microsoft.VisualStudio.Web.CodeGeneration.Tools.Program.<>c__DisplayClass8_0.<Execute>b__0()
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at Microsoft.VisualStudio.Web.CodeGeneration.Tools.Program.Execute(String[] args, Boolean isNoBuild, ILogger logger)
   at Microsoft.VisualStudio.Web.CodeGeneration.Tools.Program.Main(String[] args)

My .csproj looks like the following
  <PropertyGroup>
    <TargetFramework>net47</TargetFramework>
  </PropertyGroup>
	<ItemGroup>
	  <PackageReference Include="Microsoft.AspNetCore" Version="2.0.0" />
	  <PackageReference Include="Microsoft.AspNetCore.Authentication.Cookies" Version="2.0.0" />
	  <PackageReference Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" Version="2.0.0" />
	  <PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="2.0.0" />
	  <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.0.0" />
	  <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.ViewCompilation" Version="2.0.0" PrivateAssets="All" />
	  <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.0.0" />
	  <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="2.0.0" PrivateAssets="All" />
	  <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="2.0.0" />
	  <PackageReference Include="Microsoft.VisualStudio.Web.BrowserLink" Version="2.0.0" />
	  <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="2.0.0" PrivateAssets="All" />
	  <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Templating" Version="2.0.0" />
	</ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.EntityFrameworkCore.Tools.DotNet" Version="2.0.0" />
    <DotNetCliToolReference Include="Microsoft.Extensions.SecretManager.Tools" Version="2.0.0" />
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>

The problem is that dotnet build fails (see https://github.com/dotnet/cli/issues/8187). So other tools like the Entity Framework ones that return the contexts in the project don't run. This is also why Apply Migrations checkbox does not appear in Visual Studio Web Publish Settings.

Yep, same problem. Fixed build and problem went away.

Closing since fixing the build fixes the issue.

Would it be possible to have the errors point to common causes like this?


YARN-11388: Prevent resource leaks in TestClientRMService.

Description of PR

Guarantee servers always get closed, even if a test throws an exception.
Keep the generated excludeFile in a random test directory.
Clean up most style and whitespace warnings.

How was this patch tested?
Ran unit tests locally.
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 19s

trunk passed

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 12s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 25s

trunk passed

+1 :green_heart:
shadedclient
21m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
compile
0m 58s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 48s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 10 unchanged - 16 fixed = 12 total (was 26)

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  0s

the patch passed

+1 :green_heart:
shadedclient
21m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
99m 10s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

201m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5187/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5187

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ba31b6c05a6f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0d7d415fed073eedb4a3949046800b9d277f5029

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5187/1/testReport/

Max. process+thread count
995 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5187/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@szilard-nemeth and @slfan1989 , I noticed you have been pretty active in the ResourceManager tests. Are you available to review this? Thank you.

@szilard-nemeth and @slfan1989 , I noticed you have been pretty active in the ResourceManager tests. Are you available to review this? Thank you.

@cnauroth Thank you so much for inviting me to look at the code, I took a quick look, LGTM, I'll take a closer look at it again later.

@szilard-nemeth and @slfan1989 , I noticed you have been pretty active in the ResourceManager tests. Are you available to review this? Thank you.

@cnauroth Thank you so much for inviting me to look at the code, I took a quick look, LGTM, I'll take a closer look at it again later.

Thank you, @slfan1989 !

@cnauroth Thank you very much for your contribution! LGTM.

I have merged this to trunk, branch-3.3 and branch-3.2 (after resolving some minor merge conflicts). @slfan1989 , thank you for your review!


Add tests about number of clusters inconsistency

Can you please tell me which tests did you added/modified? Because I cannnot see the changes here in the PR. It shows that everything was added.

@jordanmontt
added : testNumberOfClustersCentersMatchExpectation, testInconsistentNumberOfClusters, testNumberOfClustersCantBeNegative, testNumberOfClustersCantBeSuperiorToNbData, testNumberOfClustersCantBeZero
changed: just the formatting of old tests not the content

I just talked with Oleks and we agreed that is not necessary to check, for example, if the number of cluster is not negative, is not zero, etc... Also in Pharo is considered a bad practice to type check.
So, can you please delete the tests please:

testInconsistentNumberOfClusters
testNumberOfClustersCantBeNegative
testNumberOfClustersCantBeSuperiorToNbData

and also can you rename the variable nbClustersto only clusters in the test: testNumberOfClustersCentersMatchExpectation ?

And finally rename the test testNumberOfClustersCentersMatchExpectation to testNumberOfCentroidsMatchExpectation
Thanks !

Thank you @Croshiw :)


error in laravel 5.4

Laravel Version: 5.4
Voyager Version: 0.11.7
PHP Version:
Database Driver & Version:

Description:
just follow all the installation step.
try to access localhost/admin
error come up like this:
SQLSTATE[42S02]: Base table or view not found: 1146 Table 'test.roles' doesn't exist (SQL: select * from roles where name = user limit 1)
Steps To Reproduce:

sori, just to much work. miss something small


ensure "freeze" gets percolated down through structs

I'm honestly not entirely sure freeze is a thing that matters for starlight, but we should try to be consistent.

I'm not sure it's even possible to implement it meaningfully.


Phoebemirman/ch17658/categorical outcomes cut off on mobile

https://app.clubhouse.io/augur/story/17658/categorical-outcomes-cut-off-on-mobile

Coverage increased (+0.02%) to 56.485% when pulling b98dd6f7949ad4e90195a222c45b1044f6170d4f on phoebemirman/ch17658/categorical-outcomes-cut-off-on-mobile into a1a74a149a3d5307e9f9dbe60349bb9487a05d91 on master.

Coverage increased (+0.02%) to 56.485% when pulling b98dd6f7949ad4e90195a222c45b1044f6170d4f on phoebemirman/ch17658/categorical-outcomes-cut-off-on-mobile into a1a74a149a3d5307e9f9dbe60349bb9487a05d91 on master.


RequestError [HttpError]: Resource not accessible by integration

I used this in one of my GitHub actions and it failed with the following error:
RequestError [HttpError]: Resource not accessible by integration
    at /home/runner/work/blogg-template/blogg-template/node_modules/@octokit/request/dist-node/index.js:66:23
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async createPullRequest (/home/runner/work/blogg-template/blogg-template/node_modules/octokit-create-pull-request/lib/create-pull-request.js:23:18) {
  name: 'HttpError',
  status: 403,
  headers: {
    'access-control-allow-origin': '*',
    'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset',
    connection: 'close',
    'content-encoding': 'gzip',
    'content-security-policy': "default-src 'none'",
    'content-type': 'application/json; charset=utf-8',
    date: 'Thu, 02 Apr 2020 23:24:52 GMT',
    'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
    server: 'GitHub.com',
    status: '403 Forbidden',
    'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
    'transfer-encoding': 'chunked',
    vary: 'Accept-Encoding, Accept, X-Requested-With',
    'x-content-type-options': 'nosniff',
    'x-frame-options': 'deny',
    'x-github-media-type': 'github.v3; format=json',
    'x-github-request-id': '0404:3924:66ACE:F1476:5E867444',
    'x-ratelimit-limit': '1000',
    'x-ratelimit-remaining': '997',
    'x-ratelimit-reset': '1585873490',
    'x-xss-protection': '1; mode=block'
  },
  request: {
    method: 'GET',
    url: 'https://api.github.com/user',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit.js/16.43.1 Node.js/12.13.1 (Linux 5.0; x64)',
      authorization: 'token [REDACTED]'
    },
    request: { hook: [Function: bound bound register] }
  },
  documentation_url: 'https://developer.github.com/v3/users/#get-the-authenticated-user'
}

Any idea what the issue might be? Thanks.

Looks like the request causing the error is GET /user, which is not an endpoint used by this plugin. A GitHub Action cannot access the GET /user endpoint, it requires an authentication bound to a user

I added a new token with user access and it solved that issue. However, a new 422 issue came up:
RequestError [HttpError]: Reference already exists
    at /home/runner/work/blogg-template/blogg-template/node_modules/@octokit/request/dist-node/index.js:66:23
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async createPullRequest (/home/runner/work/blogg-template/blogg-template/node_modules/octokit-create-pull-request/lib/create-pull-request.js:103:3) {
  name: 'HttpError',
  status: 422,
  headers: {
    'access-control-allow-origin': '*',
    'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset',
    connection: 'close',
    'content-length': '121',
    'content-security-policy': "default-src 'none'",
    'content-type': 'application/json; charset=utf-8',
    date: 'Fri, 03 Apr 2020 14:34:59 GMT',
    'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
    server: 'GitHub.com',
    status: '422 Unprocessable Entity',
    'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
    vary: 'Accept-Encoding, Accept, X-Requested-With',
    'x-accepted-oauth-scopes': 'repo',
    'x-content-type-options': 'nosniff',
    'x-frame-options': 'deny',
    'x-github-media-type': 'github.v3; format=json',
    'x-github-request-id': '0407:2B9E:66084C:ACBE5B:5E874993',
    'x-oauth-scopes': 'repo, user',
    'x-ratelimit-limit': '5000',
    'x-ratelimit-remaining': '4951',
    'x-ratelimit-reset': '1585926337',
    'x-xss-protection': '1; mode=block'
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/bukharim96/blogg-template/git/refs',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit.js/16.43.1 Node.js/12.13.1 (Linux 5.0; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"sha":"8aeb1b9edb2ada58723c2da5c63dac854c1cf94c","ref":"refs/heads/master"}',
    request: { hook: [Function: bound bound register] }
  },
  documentation_url: 'https://developer.github.com/v3/git/refs/#create-a-reference'
}

Not sure why the ref's not update.

The error is likely coming from this part of the code:
https://github.com/gr2m/octokit-create-pull-request/blob/f139e9919bc0e27669cac2b91fee11777b011398/lib/create-pull-request.js#L103-L108
It means the branch already exists (the head parameter). I think we could catch this error and throw an error that is more clear. Would you like to get a PR going for that?
You should be able to resolve the problem by deleting the branch from your repository. You can also set head to a name that will change each time, e.g.
  head: `my-branch-${Date.now()}`


Double bubble cryo tanks

This PR is a revision of PR #64. It removes inconsistencies in the geometry of the cryogenic tanks in the fuselage. Some models assumed that the geometry was a double bubble while others only applied to circular sections. Now, the tank cross-section can be a double bubble in general, following the fuselage section.
This PR also introduces a function double_bubble_geom() that can be used to calculate the geometric properties of a double-bubble shape, including a scaled-down version.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 96.87500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.38%. Comparing base (018c044) to head (96705ba).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

src/cryo_tank/tankWmech.jl
94.11%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   73.32%   73.38%   +0.06%
==========================================
  Files          77       78       +1
  Lines       13846    13878      +32
==========================================
+ Hits        10152    10185      +33
+ Misses       3694     3693       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I removed my double bubble geometry function from utils and replaced it with a scaled geometry function in layout, so as to use the new fuselage data structures


Do we need to set environment variable IGNITION_VERSION?

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
In the CMakeLists of "dolly" they check for the env var of IGNITION_VERSION to be set to "fortress" in order to search for ignition-gazebo6.
I was wondering if we should also set that in an activation script? Thoughts?
https://github.com/chapulina/dolly/blob/de9efdf34235d749b9f3b458607d554816304b88/dolly_ignition/CMakeLists.txt#L6-L11
Installed packages
-

Environment info
-

Yes I think I've seen this elsewhere (the ROS ign packages maybe). Good idea!

In the specific case, IGNITION_VERSION is specified by the CI, see https://github.com/chapulina/dolly/blob/6a9b6d698a38cca092901257ca4343d8b2a40176/.github/workflows/ci.yml#L33 . I would be inclined not to define such a variable, for two main reasons:

Consistency with apt/homebrew packages: I do not think any apt/homebrew package of Modern Gazebo (i.e. what was formerly known as Ignition) defines it
As "Modern Gazebo"/Ignition distributions are meant to be side-by-side installable I am not sure setting, I do not think it make sense to have a single env variable.

However, I would need to check how ros_ign build system works. Perhaps @chapulina herself may have some input on this?

Actually, i saw that in the released version of this package Gazebo5 is hard coded... sadly