Remove references to accessibility issues in Frontend Docs from accessibility statement [before 31 March]

What
Once #52 has been merged and deployed, update the accessibility statement to remove the reference to issues caused by the technical documentation template, and update the compliance status.
Why
The known accessibility issues should be resolved by updating to v2.2.0 of the template. (The prototype kit training docs do not have any tables, so there's nothing to do re row headers)
Done when

[ ] References to issues in Frontend Docs removed
[ ] Compliance status updated
[ ] Changes 2i'ed

As discussed in the tech writers' docs catchup, the actions to update accessibility statements are as follows:

In your product team's tech doc accessibility statement:

remove the reference to the tech doc template from the "How accessible this website is" section
remove the reference to the tech doc template from the "Non-compliance with the accessibility regulations"
in the "How we tested this website", update the last tested date and remove the bulleted list
update the "What we’re doing to improve accessibility" section
in the "Preparation of this accessibility statement", update the last reviewed and last tested dates

If the documentation is now fully compliant with the regulations, reflect this in the statement using the phrase "This website is fully compliant with the Web Content Accessibility Guidelines version 2.1 AA standard" in the following sections:

How accessible this website is
Compliance status
What we're doing to improve accessibility - suggest you put something in about maintaining the fully compliant status

Check the sample accessibility statement here for more information if needed.


load_grammar now collects all imports to make before loading them to …

fixes #348

Looks good. Thanks!


how to upload an object to camHUD

Describe your problem here.
how to add external object to camHUD?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

just do: (your object).cameras = [camHUD];


quantum-docs-pr/articles/quickstarts/search.md

Looks like the code for Operations.qs got cut off on the website:  https://docs.microsoft.com/en-us/quantum/quickstarts/search?view=qsharp-preview&tabs=tabid-vs2019
The complete code appears to be here:  https://github.com/microsoft/Quantum/blob/master/samples/algorithms/simple-grover/SimpleGrover.qs

Thank you very much! I cannot reproduce your error, everything appears ok to me in the browsers I tried (Chrome, Edge and Edge Chromium).
Can you confirm that you're still getting the code cut off? Just discard a temporary synchronisation error between repos.

I just tried again in Chrome, Firefox, and Safari.  Apologies if I'm missing something obvious.  I see the same Operations.qs snippet (after following the first link above) in all three browsers.

Oh, I wasn't understanding you correctly, now I get what you mean, my bad. Yes, you're right. However, that cut apparently was made intentionally by looking at the .md code. But I don't get why, maybe it is a mistake on the ending line.
@cgranade, I think you were involvend in this tutorial. Is there any reason why the code is cut at line 27 to not show NIterations? If not I can make a quick PR to change the ending line.


Advanced Search

As a User, I want to be able to select the name of field, operator and value, so that i can narrow my search results.

Acceptance Criteria:

[ ] Given that i want to narrow my search results, when i select advanced search option, then i should be able to select a field from a drop down list.
[ ]  Given that i want to combine two keywords, when i select advanced search option, then i should be able to select an operator from a drop down list.
[ ] Given that i want to narrow my search results, when i select advanced search option, then i should be able to select a value from a drop down list.


glsl-to-spv-worker: re-connection causes deeper and deeper directory creation

The glsl-to-spv-worker should not do os.chdir

Fixed in #354.


Preparation of **Test Tracking ** SHEET

For this I wanted to know that how I can get corresponding values from the tracking number .
My challenges are
1--> If the tracking number having only one item  there is no issue it will not overwrite. But in this scenario consider here it will like dynamic. So how will it be possible to get the required output
2--> I don't have any knowledge for this one..
It is like when  someone will.enter anything  on the sheet same time the name or id  along with time need to display

So if the person who is entering like received qty same time the name  time should be recorded accordingly
3--> This one too please if any knowledge regarding this please share with me .Last one to make a ""zave Button" by selecting all values will be transfered to different sheet


Update ruby version

There is a more recent Ruby version available for you to use:
2.6.6
The latest version will include security and bug fixes. We always recommend
running the latest version of your minor release.
Please upgrade your Ruby version.

@athomschke works on that here https://github.com/rubymonsters/speakerinnen_liste/pull/1105


Registry Viewer should allow filtering of devfiles via arch

Which area this feature is related to?

/area registry
Which functionality do you think we should add?

Why is this needed? Is your feature request related to a problem?
Viewer should filter devfiles via arch
Detailed description:
Since the multi arch feature is delivered via https://github.com/devfile/api/issues/244; viewer should now let users filter via arch
Describe the solution you'd like

Just like Stack/Sample and Tags, viewer should have an option for Archs.
Describe alternatives you've considered

Additional context

Blocked by https://github.com/devfile/api/issues/566

This issue should be fixed when the registry viewer design is updated

This does not seem to be implemented yet, will leave this open as an upcoming addition. #959 would be useful to couple with this feature.

/area registry-viewer

closing as rotten (created > 2 years). Feel free to re-open if it's not a requirement.


Anyone there

Is this repo work for nopCommerce 4.5

Not yet. We have plans for that sometime late this year or early next year.

Thank you for replying.

You're very welcome.


pyright says it is not awaitable

async_property version: 0.2.2
Python version: 3.10
Operating System: Windows

Description
I am having problems with pyright because of the types. when I try to await an async_cached_property I get the following hint:
  C:\bakdata\kpops\kpops\component_handlers\topic\proxy_wrapper.py:87:39 - error: "AsyncCachedPropertyDescriptor" is not awaitable (reportGeneralTypeIssues)
  C:\bakdata\kpops\kpops\component_handlers\topic\proxy_wrapper.py:87:39 - error: "AwaitableOnly" is not awaitable (reportGeneralTypeIssues)

What I Did
https://github.com/bakdata/kpops/blob/2f7212fa00660b4219cb4532c734ac220b330bdd/kpops/component_handlers/topic/proxy_wrapper.py#L106
https://github.com/bakdata/kpops/blob/2f7212fa00660b4219cb4532c734ac220b330bdd/kpops/component_handlers/topic/proxy_wrapper.py#L37

@irux I have a draft PR here to fix it: https://github.com/ryananguiano/async_property/pull/15/files
haven't tested it yet. maybe you can install from this branch and test it out?

@ryananguiano Just tried out the branch, it doesn't solve the issue:
  <REDACTED>:19:22 - error: "AsyncCachedPropertyDescriptor" is not awaitable
    "AsyncCachedPropertyDescriptor" is incompatible with protocol "Awaitable[_T_co@Awaitable]"
      "__await__" is not present (reportGeneralTypeIssues)
  <REDACTED>:19:22 - error: "AwaitableProxy" is not awaitable
    "AwaitableProxy" is incompatible with protocol "Awaitable[_T_co@Awaitable]"
      "__await__" is an incompatible type
        Type "() -> T@__await__" cannot be assigned to type "() -> Generator[Any, None, _T_co@Awaitable]"
          Function return type "T@__await__" is incompatible with type "Generator[Any, None, _T_co@Awaitable]"
            "object*" is incompatible with "Generator[Any, None, _T_co@Awaitable]" (reportGeneralTypeIssues)


Update tracy docs regarding --iree-hal-dump-executable-sources-to=

As pointed out by @KoolJBlack , it is now necessary to pass --iree-hal-dump-executable-sources-to= for Tracy sampling to work. That is because Tracy sampling relies on the presence of source files, and at some point the source file debug info that we generate switched to referencing the original source file to referencing the executable intermediates.
This updates tracy docs to reflect that. That still won't fix tracy sampling on IREE's own test/benchmark bytecode modules, doing that would require passing --iree-hal-dump-executable-sources-to= in iree_bytecode_module.
@KoolJBlack please confirm if --iree-hal-dump-executable-sources-to= is enough? I think you had said --iree-hal-dump-executable-files-to= is enough, and it's just my own guess that --iree-hal-dump-executable-sources-to= is the part that matters.

Just a quick note,
I've been using --iree-hal-dump-executable-files-to= which seems to dump everything per https://github.com/openxla/iree/blob/611402e434cd10d2741deae2dcab9662bb4d94f0/docs/website/docs/developers/general/developer-tips.md?plain=1#L148-L152.
Indeed tracy uses the sources from --iree-hal-dump-executable-sources-to=but it also requires the intermediates from IREE_PRESERVE_DYLIB_TEMP_FILES=your/path. I think its worth emphasizing these are both necessary in the same place so its easy to understand why (especially if something doesn't work).
Source view annotation shows sources on the left tied to the dylib temp files on the right from sampling:

@ScottTodd , should we merge this? And then we can revisit once #15699 is fixed ?


okhttp3 connect leak

logger produced:
[okhttp3.OkHttpClient] A connection to https://discord.com/ was leaked. Did you forget to close a response body? To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE);

could not reproduce with latest version -> closing issue for now

@M5rian I am awaiting this to be patched!!!

Right now I'm waiting for the stacktrace...

This problem seems to come in and out, it might be dependent on a specific event which happens which is rare for the bridge... for example how it is started.

It is not a major issue, therefore we will deal with it when it comes up again

@M5rian during testing commit d4ebe2bb8fa43e56291a6b457c6e7c6ef4ef5aff I had this:

seems like commit 781010e53397e482ecd409294659ee88e050c02a fixed the issue
T


Desubroutinize if needed

For example, running it on Noto's third_party/noto_cjk/NotoSansKR-Regular.otf results in:
roozbeh@machine-name:~/compreffor/compreffor$ ./cxxCompressor.py NotoSansKR-Regular.otf
Warning: There are subrs in NotoSansKR-Regular.otf
Traceback (most recent call last):
  File "./cxxCompressor.py", line 387, in <module>
    main(**kwargs)
  File "./cxxCompressor.py", line 342, in main
    handle_font(filename)
  File "./cxxCompressor.py", line 320, in handle_font
    font.save(out_name)
  File "/home/roozbeh/fonttools/Lib/fontTools/ttLib/__init__.py", line 214, in save
    self._writeTable(tag, writer, done)
  File "/home/roozbeh/fonttools/Lib/fontTools/ttLib/__init__.py", line 629, in _writeTable
    tabledata = self.getTableData(tag)
  File "/home/roozbeh/fonttools/Lib/fontTools/ttLib/__init__.py", line 642, in getTableData
    return self.tables[tag].compile(self)
  File "/home/roozbeh/fonttools/Lib/fontTools/ttLib/tables/C_F_F_.py", line 20, in compile
    self.cff.compile(f, otFont)
  File "/home/roozbeh/fonttools/Lib/fontTools/cffLib.py", line 72, in compile
    for child in topCompiler.getChildren(strings):
  File "/home/roozbeh/fonttools/Lib/fontTools/cffLib.py", line 243, in getChildren
    children.extend(topDict.getChildren(strings))
  File "/home/roozbeh/fonttools/Lib/fontTools/cffLib.py", line 1422, in getChildren
    charStringsComp = CharStringsCompiler(items, strings, self)
  File "/home/roozbeh/fonttools/Lib/fontTools/cffLib.py", line 180, in __init__
    self.items = self.getItems(items, strings)
  File "/home/roozbeh/fonttools/Lib/fontTools/cffLib.py", line 286, in getItems
    cs.compile()
  File "/home/roozbeh/fonttools/Lib/fontTools/misc/psCharStrings.py", line 289, in compile
    "seac"), "illegal CharString"
AssertionError: illegal CharString

Apparently you need to desubroutinize first.  Let me see how you can do that.

I believe we came up with a patch to fonttools last summer to
desubroutinize but I don't think it ever got merged.
On Tue, Jun 2, 2015 at 7:47 PM, Behdad Esfahbod<EMAIL_ADDRESS>wrote:

Apparently you need to desubroutinize first. Let me see how you can do
that.
—
Reply to this email directly or view it on GitHub
https://github.com/googlei18n/compreffor/issues/1#issuecomment-108133777
.

Ah nice, I didn't see you already linked to it.


(Wiki) Updating MP2 Filesystem Listing

Is there an updated list for MP2 that can be pushed? https://github.com/PartyPlanner64/PartyPlanner64/wiki/Main-Filesystem-Listing
I had begun filling in the blanks in excel but do not want to do something that had been done already.

Nope, I don't have any notes on those. If you'd like to see it updated, feel free to post some here and I'll add them to the wiki!

Closing this github issue, as updates have been coming in for this page since opening the wiki for updates by other users.


Fix values on images page

Update to current Docker API and add virtual size of the image.
Also replace the deprecated Comment with some informations about the
build machine.

LGTM


is gtnet module is the Uni-directed-A version as stated in the paper?

Hi, I just want to confirm that the current gtnet module in net.py is the Uni-directed-A version of the model for multi-step forecasting as stated in the paper?

yes, it is.


Fix Integration Test logging so that it works and uses log4j2

Description
This PR fixes Integration Test logging by ensuring it also uses log4j2.
It also adds some log.debug statements to the authentication processes, to allow for easier debugging of authentication ITs (which I used to track down the random test failure in AuthenticationRestControllerIT....submitted separately as #8031 ).
Instructions for Reviewers
Currently, on main, if you run Integration Tests, the resulting logs in failsafe-reports/[class]-output.txt are very limited.  You will see some basic DSpace-oriented logs at the top of those logs when DSpace initializes the database & kernel. But, once tests start running, the DSpace logs are completely lost  and you'll only see a series of MockHttpServletRequest and MockHttpServletResponse logs as each REST API test is run.
After installing this PR, you'll notice that DSpace logs now appear between individual MockHttpServletRequest logs, so that you can better understand what actions that REST API request triggered in DSpace.  Additionally, each test method now logs its start/end like this...
2021-11-11 19:01:56,053 INFO  org.dspace.app.rest.test.LoggingTestExecutionListener @ ---
2021-11-11 19:01:56,053 INFO  org.dspace.app.rest.test.LoggingTestExecutionListener @ Starting execution of test method: testLoginLogoutStatusLink()
2021-11-11 19:01:56,053 INFO  org.dspace.app.rest.test.LoggingTestExecutionListener @ ---

... logs from this test method appear here...

2021-11-11 19:01:56,569 INFO  org.dspace.app.rest.test.LoggingTestExecutionListener @ Finished execution of test method: testLoginLogoutStatusLink()

I also added an example in the new log4j2-test.xml of how to turn on DEBUG logs for just REST API tests.  This can be used to verify that the newly added log.debug statements now all appear in failsafe-reports as well.

Just fixed some minor merge conflicts after recent mergers to main.


Feature/gh14 pt2 where clauses

Codecov Report

Merging #25 (4b34ee2) into develop (9e0965c) will decrease coverage by 0.08%.
The diff coverage is 80.00%.

@@              Coverage Diff              @@
##             develop      #25      +/-   ##
=============================================
- Coverage      96.70%   96.62%   -0.09%
- Complexity       372      375       +3
=============================================
  Files             12       12
  Lines            910      918       +8
=============================================
+ Hits             880      887       +7
- Misses            30       31       +1

Impacted Files
Coverage Δ

src/QueryBuilder/QueryBuilderHandler.php
96.20% <80.00%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0965c...4b34ee2. Read the comment docs.


composer can not install alpha version

please install intervation package of version 3.0.0 or more


gres and gpus-per-node only lists t4 when g4 (T4) and g5 (A10G) are set

AWS ParallelCluster version [e.g. 3.1.1]: 3.7.0

Configured a cluster with a GPU queue with 2 instance types
InstanceType: g4dn.2xlarge
InstanceType: g5.2xlarge
srun only allows type t4 for gpu type, not a10g
srun -p gpu --time=6:00:00 -c 8 --gpus-per-node=1 --gpus-per-node=t4:1 --pty /bin/bash -i <--- Works
srun -p gpu --time=6:00:00 -c 8 --gpus-per-node=1 --gpus-per-node=a10g:1 --pty /bin/bash -i <--- Doesn't
Files
/opt/slurm/etc/pcluster/slurm_parallelcluster_gpu_partition.conf
/opt/slurm/etc/pcluster/slurm_parallelcluster_gpu_gres.conf
Only contains the g4 instances, no g5
$ cat /opt/slurm/etc/pcluster/slurm_parallelcluster_gpu_gres.conf
# This file is automatically generated by pcluster
NodeName=gpu-dy-g4dn2xlarge-[1-128] Name=gpu Type=t4 File=/dev/nvidia[0-0]
$
$ cat /opt/slurm/etc/pcluster/slurm_parallelcluster_gpu_partition.conf
# This file is automatically generated by pcluster

NodeName=gpu-dy-g4dn2xlarge-[1-128] CPUs=8 RealMemory=31129 State=CLOUD Feature=dynamic,g4dn2xlarge,gpu Weight=2000 Gres=gpu:t4:1

NodeSet=gpu_nodes Nodes=gpu-dy-g4dn2xlarge-[1-128]
PartitionName=gpu Nodes=gpu_nodes MaxTime=INFINITE State=UP
$

Hi lletourn,
that is an expected behaviour since it si not possible to map multiple GPU type for the same nodes: using Multiple instance type allocation, for a given node the characteristic has to be set in the slurm config, prior to the actual launch. For this reason the instance types selected for the Multiple instance type allocation have to comply with some restrictions.
In your case: the GPU number and manufacturer is a constraint but the type is not, this in order to have a degree of flexibility in selecting multiple instance types.
If you plan specify the gpu per node with the type I suggest to create multiple compute resource in a single queue, in that case each set of nodes will have the corresponding GPU type.

I never noticed the "The same number of accelerators of the same manufacturers." in the intances section. Why doesn't pcluster return an error then if it's not allowed?
Oh I didn't notice compute ressource is a list. This should work indeed.
But if we have a limit of 1,000 vCPUS for G type nodes how can we set the maxcount for both compute resources?
Thanks for the help.

Hi Louis,
T4 and A10G are both from Nvidia. So our code accepts them to be in the same InstanceTypes. However, the CLI validation could be improved to also check the specific GPU type. I will bring this feature request to our team.
Unfortunately, it is currently not possible to limit the overall number of compute nodes across multiple compute resources.
Thank you,
Hanwen


Help output generated by -h, --help flag is sent to stderr, should go to stdout instead

See https://github.com/atc0005/check-vmware/issues/555 for details.

N/A. The check_mysql2sqlite binary uses a different flag package which defaults to sending the help text to stdout.
Nothing to do here.


Same probrom like #1470

#1470
there is my config:
pnpm: 9.0.6
husky: 9.1.6
eslint: 9.13.0
lint-staged: 15.2.10
pre-commit hook: pnpm lint-staged
lint-staged config in root:
"scripts": {
    "lint:fix": "eslint . --fix --format eslint-formatter-pretty"
}

"lint-staged": {
    "*.js": "pnpm lint:fix"
}

when i use 'pnpm lint:fix', it work, but when i use 'git commit', it just output error without fix it, i tried everything, help me please!

You command includes eslint . which means ESLint will lint all files, not just staged ones. I don't know how to configure pnpm for you, maybe just try this:
"lint-staged": {
    "*.js": "eslint --fix --format eslint-formatter-pretty"
}

bro, thanks for your reply, but it still not work, this has troubled me for a long time

✔ Preparing lint-staged...
⚠ Running tasks for staged files...
❯ package.json — 1 file
❯ *.js — 1 file
✖ eslint --fix [FAILED]
↓ Skipped because of errors from tasks.
✔ Reverting to original state because of errors...
✔ Cleaning up temporary files...
✖ eslint --fix:
/Users/pumbaa/Desktop/q-station/packages/q-template-vue3-uniapp/src/pages/index/index.js
3:1   warning  Missing JSDoc @param "a" description     jsdoc/require-param-description
3:1   warning  Missing JSDoc @param "a" type            jsdoc/require-param-type
4:1   warning  Missing JSDoc @param "b" description     jsdoc/require-param-description
4:1   warning  Missing JSDoc @param "b" type            jsdoc/require-param-type
5:1   warning  Missing JSDoc @param "c" description     jsdoc/require-param-description
5:1   warning  Missing JSDoc @param "c" type            jsdoc/require-param-type
6:1   warning  Missing JSDoc @param "d" description     jsdoc/require-param-description
6:1   warning  Missing JSDoc @param "d" type            jsdoc/require-param-type
7:1   warning  Missing JSDoc @param "e" description     jsdoc/require-param-description
7:1   warning  Missing JSDoc @param "e" type            jsdoc/require-param-type
9:10  error    'handleClick' is defined but never used  @typescript-eslint/no-unused-vars
9:22  error    'a' is defined but never used            @typescript-eslint/no-unused-vars
9:25  error    'b' is defined but never used            @typescript-eslint/no-unused-vars
9:28  error    'c' is defined but never used            @typescript-eslint/no-unused-vars
9:31  error    'd' is defined but never used            @typescript-eslint/no-unused-vars
9:34  error    'e' is defined but never used            @typescript-eslint/no-unused-vars
14:3   warning  Unexpected console statement             no-console
16:3   warning  Unexpected console statement             no-console
17:3   warning  Unexpected console statement             no-console
18:3   warning  Unexpected console statement             no-console
19:3   warning  Unexpected console statement             no-console
✖ 21 problems (6 errors, 15 warnings)
husky - pre-commit script failed (code 1)
always output errors, just don't repair it

I think I understand now. Using lint-staged with eslint can automatically fix all issues classified as warnings. However, if there are problems that are warnings with errors, it will throw an error. I’d like to know if this is by design or if there’s another reason causing it, Looking forward to your reply @iiroj

This is directly related to the exit code of ESLint, if it's not 0 lint-staged will fail. So in this case if ESLint failed to automatically fix all the problems, it will fail the commit. There's at least the --max-warnings flag available for ESLint: https://eslint.org/docs/latest/use/command-line-interface#--max-warnings


[$250] Secondary contact - Technical message is displayed when clicking unlink button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.19-9
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Click on Account Settings > Profile > Contact methods > Add secondary contact method and DON'T VERIFY it
Logout > Enter the secondary login email address
Click on 'Unlink' button

Expected Result:
Link sent message should be displayed
Actual Result:
unlinkLoginForm.linkSent is displayed
Workaround:
Unknown
Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/dd513db6-3115-4cbf-83e7-d4b1c123c39e

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01804377f1573ea50d
Upwork Job ID:<PHONE_NUMBER>082051171
Last Price Increase: 2024-08-13
Automatic offers:

etCoderDysto | Contributor | 103559320

Issue OwnerCurrent Issue Owner: @mananjadhav

We think that this bug might be related to #vip-vsb

@bfitzexpensify  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Technical message is displayed when clicking unlink button
What is the root cause of that problem?
Here we pass a key (unlinkLoginForm.linkSent)  to translation content to DotIndicatorMessage
https://github.com/Expensify/App/blob/88ad9c709fc95520520150b7f6f6692c45057267/src/pages/signin/UnlinkLoginForm.tsx#L58-L62
Here we are displaying a key to translation content that is located in en.ts and es.ts rather than fetching the translation content from en.ts and es.ts
https://github.com/Expensify/App/blob/de8c7aff0599212afd2875ee0c7cbea3aca40144/src/components/DotIndicatorMessage.tsx#L84-L89
What changes do you think we should make in order to solve the problem?
We should call transalte method with account.message here
messages={{0: translate(account.message)}}

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Secondary contact - Technical message is displayed when clicking unlink button
What is the root cause of that problem?
When we click on unlink button we call - Session.requestUnlinkValidationLink()
We build success data here -
https://github.com/Expensify/App/blob/420c2a13cc176dca5adf8dcc8132ef5f8ff678f7/src/libs/actions/Session/index.ts#L787-L825
We directly use unlinkLoginForm.linkSent (which is key) instead of using the message related to that key.
https://github.com/Expensify/App/blob/420c2a13cc176dca5adf8dcc8132ef5f8ff678f7/src/languages/en.ts#L1581-L1587
What changes do you think we should make in order to solve the problem?
We should use the message instead of key.
We can use something like - Localize.translateLocal() for that.
We should for other actions related to unlink
What alternative solutions did you explore? (Optional)

Will review the proposals by tomorrow. I was OOO.

@etCoderDysto's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

PR will be ready for review today

@mananjadhav PR is ready for review

@bfitzexpensify This should be ready for payout as I can see it's deployed to production last week. We don't have an offending PR as we never added the fix for this I cannot pinpoint when it should've been added.
I also don't think we need a regression test for this one.

@bfitzexpensify I think this issue is ready for payout. Automation is failing here. It has been more than 7 days since PR was deployed to prod

@bfitzexpensify I have accepted the offer. Thanks!

@bfitzexpensify I think I have accepted a duplicate offer. One received here, and the other received here. Should I end the contract sent here?

$250 approved for @mananjadhav


Incompatible with Swift 3

There are about 9 bugs causing by Swift 3 not being able to compile. Could anyone try to update the code?
Thanks!

Look at the swift3 branch @LinusGeffarth.


now terrascan just hangs in a pre-commit

repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.81.0
hooks:

id: terraform_providers_lock
id: terraform_checkov
exclude: (^generate-code/)
args:

--args=--framework=all
--args=--quiet
--args=--include-all-checkov-policies

id: terraform_docs
files: ^IaC/environments/2-test|^IaC/environments/3-staging|^IaC/environments/4-prod|^IaC/modules
exclude: (.template/.$|./examples/.|./test/.*)
args:

--args=--config=.terraform-docs.yaml
--hook-config=--path-to-file=README.md
--hook-config=--add-to-existing-file=true
--hook-config=--create-file-if-not-exist=true

id: terraform_fmt
exclude: (^generate-code/)
#AC_AWS_0369 - I do have Flow Logs Enabled.  It is done dynamically so terrascan does not see it
#AC_AWS_0479 - this is being done, line 91 of modules/ec2_complete/main.tf sets it.  It is done dynamically so terrascan does not see it
#AC_AWS_0480 - detailed monitoring is set to true via variables.  Line 52 of modules/ec2_complete/main.tf consumes and sets the variables.  They are set to true
###terrascan is INCORRECTLY flagged 'optional' as an Experiment.  It was released in 1.3.0 of terraform.
###I have opened this issue - https://github.com/tenable/terrascan/issues/1580
###I see no way to ignore checking for experiments after hours of googling.  So commenting out for now
id: terrascan
args:

--args=--iac-dir=IaC/environments/2-test
--args=--policy-type=aws
--args=--verbose
--args=--non-recursive
--args=--skip-rules="AC_AWS_0369,AC_AWS_0479,AC_AWS_0480"

#aws-ec2-enable-at-rest-encryption - They are set to be encrypted.   It is done dynamically so terraform_tfsec does not see it
#aws-ec2-require-vpc-flow-logs-for-all-vpcs - I am setting Flow Logs.  It is done dynamically so terraform_tfsec does not see it
#aws-s3-enable-bucket-logging - I do have logging enabled.  It is done dynamically so terraform_tfsec does not see it
#aws-ec2-enforce-http-token-imds - Yes this is set dynamically. It is done dynamically so terraform_tfsec does not see it

id: terraform_tfsec
files: ^IaC/environments/2-test|^IaC/environments/3-staging|^IaC/environments/4-prod|^IaC/modules

files: ^generate-code
  args:
    - >
      --args=--format json
      --no-color
      -e aws-ec2-require-vpc-flow-logs-for-all-vpcs,aws-ec2-enable-at-rest-encryption,aws-s3-enable-bucket-logging,aws-ec2-enforce-http-token-imds

NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"
Description
Trying to run the above configuration and now terrascan just hangs and never completes.
What I Did
I let it run for 20 minutes.
Command pasted above.

Does a verbose flag show any log?


chore(flag-pull): Remove Pull Flag

List of Changes

remove flag pull from request/response models. It's still exist as column with default value = true.

link swagger
Motivation and Context

How Has This Been Tested?

🤖 junit
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Integration tests need changes?
Is it possible to deploy in DEV environment and verify that integration tests are successful?

This is a report https://reports.cucumber.io/reports/41194c54-def3-454f-99e9-0bffbe52ab99


WMIC error on startup.

SQL Operations Studio Version: 0.32.2 (but it has been happening with the last two stable releases as well)

Steps to Reproduce:
Occurs immediately after initial launch of the program. I am running the following extensions: SQL Server agent, SSMS Keymap. I am using version control through GIT GUI. Ru

edit: windows 7 64bit

@DanwithArduino there's some code that tries detect where the system is 32-bit or 64-bit using wmic.exe.  Maybe this error is Win7-specific or something.
Do you know if the path in error message is referring to valid file?  On my system the exe is at C:\Windows\System32\wbem\WMIC.exe

Is there anything I can do to provide any more information on this error?

@DanwithArduino sorry for delay.  Could you please confirm if you have a file at C:\Windows\System32\WMIC.exe?  i.e., without the wbem component of the path.
It seems like SQL Ops Studio is trying to run the program from there.  Also, if you run "wmic.exe" from the global run dialog box (Windows Key+R) what happens?
From the error message I'm guessing there is a non-executable file with the name "wmic.exe" on the path prior to the C:\Windows\System32\wbem directory.

Indeed, the one that resides in my system32 folder, but not the wbem sub folder, may be the issue...

Running from the run dialog does indeed pop the same error.

@DanwithArduino you should be able to resolve this issue by either (1) removing the invalid wmic.exe from your path or (2) reordering your path such that C:\Windows\System32\wbem is ahead of C:\Windows\System32.
I'll close this issue now since it looks like the problem is understood.  Please let me know if there are additional questions I can help with.


Analyzer reports 3 issues for 1 problem involving a non-const arg to a const constructor in a list

Given this code:

void f(int y) {
  const list = [
    C(y),
    C(),
    ...[C(), C(), C()],
  ];
  print(list);
}

class C {
  const C([int? x = 1]);
}

Analyzer produces 3 diagnostics on the y argument in C(y):

Arguments of a constant creation must be constant expressions. (view docs)
Try making the argument a valid constant, or use 'new' to call the constructor.
The values in a const list literal must be constants. (view docs)
Try removing the keyword 'const' from the list literal.
Const variables must be initialized with a constant value. (view docs)
Try changing the initializer to be a constant expression.

Two issues:

These should be compressed into one error. I think the first is a fair one to keep, over the others.
The suggestion in the first, "use 'new'" is not helpful, unnecessary, and erroneous.

I think the problems can be solved by considering whether a const constructor call is explicit (with const) or implicitly const because of a const context.

I agree that the first is the root cause. It looks like we're deciding that an instance creation expression isn't a const expression if some of the arguments aren't const expressions, but I think we should recover by assuming that it will be a constant expression when the deeper issue is addressed. I think that doing so would remove the last two diagnostics naturally.


core.client.route-filter

im trying to remove the guest state.
   for (var i = 0, roles = toState.data.roles; i < roles.length; i++) {           if ((Authentication.user && Authentication.user.roles !== undefined && Authentication.user.roles.indexOf(roles[i]) !== -1)) {             allowed = false;             console.log("------------------- truee --------------------------");             break;           }         }
but none of my console.log is in the console,  and wherever i put
   $state.go('authentication.signin').then(function () {
              // Record previous state
              storePreviousState(toState, toParams);
            });

total:
    function stateChangeStart(event, toState, toParams, fromState, fromParams) {
      // Check authentication before changing state
      if (toState.data && toState.data.roles && toState.data.roles.length > 0) {
        var allowed = false;

        console.log(toState.data);
        console.log("-------------------------------");
        console.log("TESTING");

        for (var i = 0, roles = toState.data.roles; i < roles.length; i++) {
          if ((Authentication.user && Authentication.user.roles !== undefined && Authentication.user.roles.indexOf(roles[i]) !== -1)) {
            allowed = false;
            console.log("------------------- truee --------------------------");
            break;
          }
        }
        console.log("allowed: " + allowed);

        if (!allowed) {
          event.preventDefault();
          if (Authentication.user !== null && typeof Authentication.user === 'object') {
            $state.transitionTo('forbidden');
          } else {
            console.log("redirecting to login");
            $state.go('authentication.signin').then(function () {
              // Record previous state
              storePreviousState(toState, toParams);
            });
          }
        }
      }
    }

it wont show any reflection.
what do i need to do so all non users will be redirected to the signin page?

Why not simply update the policies for the routes? For server side API set data.roles in the server policies file articles.server.policy.js to have only user and/or admin. And for client side update articles.client.routes.js and core.client.routes.js to set data.roles with only user and/or admin. This should prevent guest access on the API and the client routes and redirect the user to signin page if they hit any of  those pages.

Because i dont USE the policies cause i couldnt make Them work with post requests

@frkwhiteangel @sujeethk There's a difference in the access granted, for users, between the server-side (ACL policy), and the client-side (route based). The latter is merely used to restrict specific client-side routes based on the User's roles.
@frkwhiteangel In your case, you would need to update your client-side route configurations to include the { data: roles: ['user', 'admin'] } if you want only logged in users to access that route.
See this Articles route config, which allows all users (including guests) access the the Article list route. And see the Admin config
If the data.roles config is not present on a state, it inherits from it's parent's settings (if this setting is present in the parent config). Otherwise, it allows all users; the default is to allow access if the configuration is not present.
See: https://github.com/meanjs/mean/blob/master/modules/core/client/config/core.client.route-filter.js#L16
Alternatively, you may change the behavior of the the route-filter to only allow access to logged in users, if the setting isn't present. My preference is to just treat all my client-side routes as "open" unless specified otherwise. And the effort it takes to accomplish/maintain this is minimal.

So by just specifying data there would grant them ? According to the articles config


Add doc page about datasets and readers

OK, one last question: is it possible to download only specific datasets instead of all? If so, a short explanation would be nice.

Good point, all done!

Thanks @hofaflo!


Intermittent acquireTokenSilent timeout issue

Please follow the issue template below. Failure to do so will result in a delay in answering your question.
Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[x ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
Version:  "@azure/msal-angular": "^1.0.0-alpha.1" ,"msal": "^1.2.1-beta.1"
We are experiencing intermittent acquireTokenSilent Token renewal operation failed due to timeout issue. We observed that we have block_token_requests error as well, but the timeout issue sometimes disappears sometimes doesn't, although the block_token_requests error is always there. I've included a detailed verbose log (with sensitive info stripped out) below for both working and non-working cases. I've observed that the block_token_requests error is when acquireTokenSilent's callback redirects to a route that's guarded by MsalGuard. All of our routes are guarded by MsalGuard and we would like it to work this way.
Question
We think the  timeout error is not related to block_token_requests, because we've tried to create our own guard to not activate the redirect route in hidden iframe, however the timeout issue still occurs although block_token_requests is not observed anymore. We've tried to increase the timeout to 30s with no luck.
What's the reason for this timeout error? We've not observed this in older versions. We recently updated to the alpha version due to SSO requirement.
Details of the app:
For our app, we have all of our routes guarded with MsalGuard, and the default callback from login/acquireToken redirects to one of the guarded Home route. Our APIs have interceptors to make sure acquireToken is successful before making an API call.
Verbose Logs:
The one that's not working:
msal client logging: Fri, 17 Jan 2020 20:31:44 GMT:1234-1.2.0-Verbose location change event from old url to new url
main.js:1081 msal client logging: Fri, 17 Jan 2020 20:31:44 GMT:1234-1.2.0-Info Navigate to:https://xxx/oauth2/v2.0/authorize?response_type=id_token&response_mode=fragment
msal client logging: Fri, 17 Jan 2020 20:31:51 GMT:1234-1.2.0-Info Returned from redirect url
msal client logging: Fri, 17 Jan 2020 20:31:51 GMT:1234-1.2.0-Info Processing the callback from redirect response
msal client logging: Fri, 17 Jan 2020 20:31:51 GMT:1234-1.2.0-Info State status:true; Request type:LOGIN
msal client logging: Fri, 17 Jan 2020 20:31:51 GMT:1234-1.2.0-Info State is right
msal client logging: Fri, 17 Jan 2020 20:31:51 GMT:1234-1.2.0-Info Fragment has id token
VM11 main.js:680 LOGIN SUCCESS
msal client logging: Fri, 17 Jan 2020 20:31:51 GMT:1234-1.2.0-Verbose location change event from old url to new url
msal client logging: Fri, 17 Jan 2020 20:31:51 GMT:1234-1.2.0-Info Token is already in cache for scope:f7de192f-f705-4194-83a8-d49228fa3e6c
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Verbose renewing accesstoken
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Verbose renewToken is called for scope:xxx
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Info Add msal frame to document:msalRenewFramehttps://scopexxx
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Verbose Renew token Expected state: 8920e54e-7a8a-48a3-bf26-d9139f211458
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Info Navigate to:https://xxx/oauth2/v2.0/authorize?response_type=token&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.2.0&domain_hint=organizations&client-request-id=16f1e18a-fcad-4513-a10a-7d9d1e8f79b3&prompt=none&response_mode=fragment
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Verbose Set loading state to pending for: scopexxx
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Info LoadFrame: msalRenewFramehttps:/xxx.onmicrosoft.com/api/user_impersonation
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Info Add msal frame to
msal client logging: Fri, 17 Jan 2020 20:31:55 GMT:1234-1.2.0-Info Frame Name : msalRenewFramehttps:// Navigated to: https://xxx.onmicrosoft.com/oauth2/v2.0/authorize?response_type=token&scope=&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.2.0&domain_hint=organizations&client-request-id=16f1e18a-fcad-4513-a10a-7d9d1e8f79b3&prompt=none&response_mode=fragment
acquire token failure {"errorCode":"block_token_requests","errorMessage":"Token calls are blocked in hidden iframes","name":"ClientAuthError"}
msal client logging: Fri, 17 Jan 2020 20:31:58 GMT:1234-1.2.0-Error Error when acquiring token for scopes: ClientAuthError: Token calls are blocked in hidden iframes
msal client logging: Fri, 17 Jan 2020 20:32:28 GMT:1234-1.2.0-Verbose Loading frame has timed out after: 30 seconds for scope
app.component.ts:181 acquire token failure {"errorCode":"token_renewal_error","errorMessage":"URL navigated to is https://xxx.b2clogin.com/xxx.onmicrosoft.com/policy/oauth2/v2.0/authorize?response_type=token&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.2.0&domain_hint=organizations&client-request-id=16f1e18a-fcad-4513-a10a-7d9d1e8f79b3&prompt=none&response_mode=fragment, Token renewal operation failed due to timeout.","name":"ClientAuthError"}
app.module.ts:79 msal client logging: Fri, 17 Jan 2020 20:32:28 GMT:1234-1.2.0-Error Error when acquiring token for scope Token renewal operation failed due to timeout.
The one that works:
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Verbose location change event from old url to new url
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Info Token is already in cache for scope:f7de192f-f705-4194-83a8-d49228fa3e6c
app.component.ts:146 LOGIN SUCCESS
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Verbose renewing accesstoken
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Verbose renewToken is called for scope
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Info Add msal frame to document:msalRenewFramehttps://
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Verbose Renew token Expected state:
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Info Navigate to:https://xxx.b2clogin.com/xxx.onmicrosoft.com&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.2.0&domain_hint=organizations&client-request-id=e41c5916-dab0-4394-beb3-305aad9c4f5b&prompt=none&response_mode=fragment
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Verbose Set loading state to pending for: scope
msal client logging: Fri, 17 Jan 2020 20:26:03 GMT:1234-1.2.0-Info LoadFrame: msalRenewFramehttps://
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info Add msal frame to document:msalRenewFramehttps://
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info Frame Name : msalRenewFramehttps:// Navigated to: https://xxx.b2clogin.com/xxx.onmicrosoft.com/policy/oauth2/v2.0/authorize?response_type=token&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.2.0&domain_hint=organizations&client-request-id=e41c5916-dab0-4394-beb3-305aad9c4f5b&prompt=none&response_mode=fragment
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info Returned from redirect url
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info Processing the callback from redirect response
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info State status:true; Request type:RENEW_TOKEN
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info State is right
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info Fragment has access token
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Info The user object received in the response is the same as the one passed in the acquireToken request
msal client logging: Fri, 17 Jan 2020 20:26:04 GMT:1234-1.2.0-Verbose acquiring token interactive in progress
acquireTokenSuccess
msal client logging: Fri, 17 Jan 2020 20:26:07 GMT:1234-1.2.0-Verbose location change event from old url to new url
app.component.ts:181 acquire token failure {"errorCode":"block_token_requests","errorMessage":"Token calls are blocked in hidden iframes","name":"ClientAuthError"}
msal client logging: Fri, 17 Jan 2020 20:26:07 GMT:1234-1.2.0-Error Error when acquiring token for scopes: ClientAuthError: Token calls are blocked in hidden iframes

I can no successfully reproduce this!
I'm not sure if there are also other scenarios, but this one is for sure one.
Reproduce:

Use Chrome (may also work with other browsers)
Open "any" site (e.g. github) in a tab
Open another tab and navigate to your site which uses MSAL (note: ensure that a token has to be acquired via the hidden iframe => i.e. 1 hour passed since you last accessed it)
As soon as you open the site in the new tab, start switching between the gitbhub tab and the site-with-msal tab
You will get the timeout

=> this may sound a little hard to reproduce, but it actually isn't, it happens for me almost always when you do that
=> this happens because Chrome seems to pause script execution (maybe even http requests?) in inactive tabs
I already informed @jasonnutter via E-Mail, so he is informed.

I seem to have the same issue - await msal.acquireTokenSilent(req) never completes. I can see the iframe and it seems to have received the token. FWIW I'm redirecting to a blank page.
In my case/setup, it's reproducible every time.

I noticed that the timeout seems to only happen when the blank redirect page is not on sameorigin. Is there any reason same origin should be necessary?

@mbrevda Yes, in order MSAL to read the url of the iframe, the redirect uri needs to be on the same origin as the application. Otherwise, we have no way to read the response, which would result in a timeout.

Thanks. I guess what threw me off was that the src isn't set to the same origin:

Might want to document this requirement somewhere!

@mbrevda Initially, we the src to a location on your authority (e.g. login.microsoftonline.com), and then when the operation is complete, the authority redirects that response (and thus the iframe) to the provided redirect uri, which allows us to parse it.
You can read more about the implementation of the implicit flow here: https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-implicit-grant-flow

@pasanenl Is this still an issue with the latest versions of MSAL Angular and MSAL?

@jasonnutter We no longer use MSAL for Angular.

Hello
I'm using msal-angular 1.0.0-beta.4 and I am having the same problem. I don't know how to reproduced it and as described above it seems to be intermittent. When clearing the cache and refreshing the app, it works again but obviously this is not a fix. Is this bug being investigated ?

@jasonnutter We no longer use MSAL for Angular.

out of curiosity, what do you use to authenticate your Angular app to Azure AD then ?

@graphicsxp We wrote our own authentication service using MSAL v1.2.1 JS directly.

@jasonnutter, yes this is still an issue with the latest MSAL Angular and MSAL version.
Browser: Chrome / Firefox (latest versions)
MSAL: 1.3.0-beta.1
MSAL Angular: 1.0.0-beta.5
Our routes are protected by MsalGuard and whenever they try to renew the token silently, the same issue as already mentioned can be observed. Right now the only way for us to "resolve" it is by clearing the browser cache / local-storage.
Our setup is pretty much the same as it is used by the angular 9 samples, with some mitigation tactics suggested by the FAQ in order to prevent CORS issues.

MSAL config

function MSALConfigFactory(): Configuration {
return {
auth: {
clientId: 'xxxxxxxxxx',
authority: 'https://login.microsoftonline.com/xxxxxxxx',
validateAuthority: true,
navigateToLoginRequestUrl: true,
redirectUri: ${window.location.origin},
},
cache: {
cacheLocation: 'localStorage',
storeAuthStateInCookie: isIE
},
};
}
function MSALAngularConfigFactory(): MsalAngularConfiguration {
return {
popUp: !isIE,
consentScopes: ['openid', 'profile'],
extraQueryParameters: {}
};
}
`

app-routing.module

const routes: Routes = [     {         path: 'station', component: StationComponent, canActivate: [MsalGuard],         children: [             {                 path: ':id', component: StationDetailComponent, canActivate: [MsalGuard]             }         ]     },     {path: '', pathMatch: 'full', redirectTo: 'station'},     {path: '**', redirectTo: 'station'}, ];

app.module

`
],
entryComponents: [
AppComponent,
MsalComponent
]
})
export class AppModule {
constructor() {
console.log('APP Module Constructor!');
}
ngDoBootstrap(ref: ApplicationRef) {
    if (window !== window.parent && !window.opener) {
        console.log('Bootstrap: MSAL');
        ref.bootstrap(MsalComponent);
    } else {
        //this.router.resetConfig(RouterModule);
        console.log('Bootstrap: App');
        ref.bootstrap(AppComponent);
    }
}

}
`

Error:

@captain-clean What happens when you open the login.microsoftonline.com url in its own tab? Also, if you share the client-request-id with me, I can look up server logs for the request.

Opening the login.microsoftonline.com url in its own tab redirects to our site with the id_token as part of the request parameters. Though it doesn't seem that it's parsed by the msal library.
The client-request-id for the most recent, unsuccessful request is: 28e1d54b-004a-4239-a77c-b108706daee7

Opening the login.microsoftonline.com url in its own tab redirects to our site with the id_token as part of the request parameters. Though it doesn't seem to be parsed by the msal library.
The client-request-id for the most recent, unsuccessful request is: 28e1d54b-004a-4239-a77c-b108706daee7

Thanks. Can you try setting system.loadFrameTimeout in your configuration to an artificially high number, e.g. 20000 (20 seconds). Do requests still timeout?

I've tried increasingsystem.loadFrameTimeout to 35 seconds, but had no immediate success resolving the issue.
core.js:6189 ERROR Error: Uncaught (in promise): ClientAuthError: URL navigated to is https://login.microsoftonline.com/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/oauth2/v2.0/authorize?response_type=id_token&scope=openid%20profile&client_id=XXXXXXXXXXXXXXXXXXXXXXXXX&redirect_uri=http%3A%2F%2Flocalhost%3A4200&state=eyJpZCI6IjAzNGQwZGEyLWY0OGItNDJiOS05MzQ1LTY4MDIxZWQwZjM4ZSIsInRzIjoxNTg3NDQ3MDY1LCJtZXRob2QiOiJzaWxlbnRJbnRlcmFjdGlvbiJ9&nonce=6436f939-2a7f-4fed-ac28-bfc9c4eb87a5&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.3.0&login_hint=XXXXXXXXXXXXXXXX&client-request-id=17bfbb91-7cbc-4b49-b4f6-0fc2a7fbb4c9&prompt=none&response_mode=fragment, Token renewal operation failed due to timeout.
ClientAuthError: URL navigated to is https://login.microsoftonline.com/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/oauth2/v2.0/authorize?response_type=id_token&scope=openid%20profile&client_id=XXXXXXXXXXXXXXXXXXXXXXXXX2&redirect_uri=http%3A%2F%2Flocalhost%3A4200&state=eyJpZCI6IjAzNGQwZGEyLWY0OGItNDJiOS05MzQ1LTY4MDIxZWQwZjM4ZSIsInRzIjoxNTg3NDQ3MDY1LCJtZXRob2QiOiJzaWxlbnRJbnRlcmFjdGlvbiJ9&nonce=6436f939-2a7f-4fed-ac28-bfc9c4eb87a5&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.3.0&login_hint=XXXXXXXXXXXXXXXX&client-request-id=17bfbb91-7cbc-4b49-b4f6-0fc2a7fbb4c9&prompt=none&response_mode=fragment, Token renewal operation failed due to timeout.
    at ClientAuthError.AuthError [as constructor] (AuthError.js:22)
    at new ClientAuthError (ClientAuthError.js:105)
    at Function.push../node_modules/msal/lib-es6/error/ClientAuthError.js.ClientAuthError.createTokenRenewalTimeoutError (ClientAuthError.js:132)
    at WindowUtils.js:73
    at ZoneDelegate.invokeTask (zone-evergreen.js:399)

client-request-id: 17bfbb91-7cbc-4b49-b4f6-0fc2a7fbb4c9
I noticed that after increasing the timeout to 35 seconds, the token seems to be present after I refresh my browser tab even though the initial token renewal request failed due to a timeout. But, this is only seems to be the case on Google Chrome (v 81.0.4044.113). Firefox (v 75.0) on the other hand, never seems to be able to recover after the initial, failed request.

@captain-clean Thanks! In that request, it looks like you are setting the redirect URI to http://localhost:4200, and that page appears to setup to redirect away to the station route. I believe this is causing the problem, as the page you use for the redirectUri should not invoke a redirect of its own, as that can prevent MSAL from parsing the response in the iframe (which can result in a timeout). The simplest solution would be to set the redirectUri to a dedicated redirect page that does not perform any redirects or require authorization.

@jasonnutter I'm having this issue across my entire team, and don't have the MsalGuard applied to our root route, nor do we redirect to a different route from the route that we specify as the redirectUri.
When I click on the link in the error message, our app opens in a new tab, and we are logging in successfully, but if I refresh the page, the error returns.
Where does one set system.loadFrameTimeout if they want to play with that number?

@jasonnutter Sorry for the late reply. I gave your suggestion a try, but did not succeed fixing my problem.
When setting the redirectUri to a page not requiring authentication I experience the same issue. Also, I've noticed that when allowing X-Frame-Options: SAMEORIGIN rather than X-Frame-Options: DENY the request is more likely to succeed.
Thanks for the help.

@jakehockey10 If you can share a Fiddler trace, that would be helpful.
@captain-clean A Fiddler trace would also be helpful here.

Also, I've noticed that when allowing X-Frame-Options: SAMEORIGIN rather than X-Frame-Options: DENY the request is more likely to succeed.

When silently acquiring tokens, MSAL will load your redirect URI inside an iframe. If you have your server setup to return the X-Frame-Options: DENY header, your app will be unable to load in the hidden iframe, which results in the library being unable to read the response, which will result in a timeout. Make sure that X-Frame-Options is set to SAMEORIGIN, if set at all.

I hope this is what you were after.  I haven't used Fiddler before:
#	Result	Protocol	Host	URL	Body	Caching	Content-Type	Process	Comments	Custom
1	200	HTTPS	www.fiddler2.com	/UpdateCheck.aspx?isBeta=False	785	private	text/plain; charset=utf-8
2	200	HTTP	Tunnel to	www.googleapis.com:443	0			chrome:15792
3	200	HTTP	Tunnel to	oauthaccountmanager.googleapis.com:443	0			chrome:15792
4	200	HTTP	Tunnel to	teams.microsoft.com:443	0			teams:10100
5	200	HTTP	Tunnel to	docs.google.com:443	0			chrome:15792
6	200	HTTP	Tunnel to	teaminc.visualstudio.com:443	0			gitkraken:5736
7	200	HTTP	Tunnel to	teaminc.visualstudio.com:443	0			gitkraken:5736
8	200	HTTP	Tunnel to	dev.azure.com:443	0			gitkraken:28020
9	200	HTTP	Tunnel to	southcentralus.notifications.teams.microsoft.com:443	0			teams:10100
10	200	HTTP	fiddler2.com	/content/GetArticles?clientId=1B72D59DF7D0D15D518DDEE26CECBB116C1DC5CF8F8C7EB030832824FE10848B	874	no-cache; Expires: -1	application/json; charset=utf-8	fiddler:32620
11	200	HTTP	fiddler2.com	/content/GetBanner?clientId=1B72D59DF7D0D15D518DDEE26CECBB116C1DC5CF8F8C7EB030832824FE10848B	144,183	no-cache; Expires: -1	application/json; charset=utf-8	fiddler:32620
12	200	HTTP	Tunnel to	ssl.gstatic.com:443	0			chrome:15792
13	200	HTTP	Tunnel to	www.google-analytics.com:443	0			chrome:15792
14	200	HTTP	Tunnel to	www.google-analytics.com:443	0			chrome:15792
15	200	HTTP	Tunnel to	www.googletagmanager.com:443	0			chrome:15792
16	200	HTTP	Tunnel to	stats.g.doubleclick.net:443	0			chrome:15792
17	200	HTTP	Tunnel to	stats.g.doubleclick.net:443	0			chrome:15792
18	200	HTTP	Tunnel to	www.google.com:443	0			chrome:15792
19	200	HTTP	Tunnel to	www.google.com:443	0			chrome:15792
20	200	HTTP	Tunnel to	www.google.com:443	0			chrome:15792
21	200	HTTP	Tunnel to	cloudsearch.googleapis.com:443	0			chrome:15792
22	200	HTTP	Tunnel to	digitaldev.teaminc.com:443	0			chrome:15792
23	200	HTTP	Tunnel to	digitaldev.teaminc.com:443	0			chrome:15792
24	200	HTTP	Tunnel to	bat.bing.com:443	0			chrome:15792
25	200	HTTP	Tunnel to	digitaldev.teaminc.com:443	0			chrome:15792
26	200	HTTP	Tunnel to	clients4.google.com:443	0			chrome:15792
27	200	HTTP	Tunnel to	digitaldev.teaminc.com:443	0			chrome:15792
28	200	HTTP	Tunnel to	login.microsoftonline.com:443	0			chrome:15792
29	200	HTTP	Tunnel to	login.microsoftonline.com:443	0			chrome:15792
30	200	HTTP	Tunnel to	teamdigitalclientportalapi-dev.azurewebsites.net:443	0			chrome:15792
31	200	HTTP	Tunnel to	teamdigitalclientportalapi-dev.azurewebsites.net:443	0			chrome:15792
32	200	HTTP	Tunnel to	browser.pipe.aria.microsoft.com:443	0			teams:10100
33	200	HTTP	Tunnel to	graph.microsoft.com:443	0			chrome:15792
34	200	HTTP	Tunnel to	graph.microsoft.com:443	0			chrome:15792
35	200	HTTP	Tunnel to	18.client-channel.google.com:443	0			chrome:15792
36	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
37	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
38	200	HTTP	Tunnel to	browser.pipe.aria.microsoft.com:443	0			chrome:15792
39	200	HTTP	Tunnel to	aadcdn.msauth.net:443	0			chrome:15792
40	200	HTTP	Tunnel to	aadcdn.msauth.net:443	0			chrome:15792
41	200	HTTP	Tunnel to	login.live.com:443	0			chrome:15792
42	200	HTTP	Tunnel to	logincdn.msauth.net:443	0			chrome:15792
43	200	HTTP	Tunnel to	aadcdn.msauthimages.net:443	0			chrome:15792
44	200	HTTP	Tunnel to	webshell.suite.office.com:443	0			chrome:15792
45	200	HTTP	Tunnel to	outlook.office.com:443	0			chrome:15792
46	200	HTTP	Tunnel to	aadcdn.msauthimages.net:443	0			chrome:15792
47	200	HTTP	Tunnel to	play.google.com:443	0			chrome:15792
48	200	HTTP	Tunnel to	shellprod.msocdn.com:443	0			chrome:15792
49	200	HTTP	Tunnel to	autologon.microsoftazuread-sso.com:443	0			chrome:15792
50	200	HTTP	Tunnel to	loglogin.lastpass.com:443	0			chrome:15792
51	200	HTTP	Tunnel to	teaminc.visualstudio.com:443	0			gitkraken:5736
52	200	HTTP	Tunnel to	teaminc.visualstudio.com:443	0			gitkraken:5736
53	200	HTTP	Tunnel to	passwordsleakcheck-pa.googleapis.com:443	0			chrome:15792
54	200	HTTP	Tunnel to	lastpass.com:443	0			chrome:15792
55	200	HTTP	Tunnel to	lastpass.com:443	0			chrome:15792
56	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
57	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
58	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
59	200	HTTP	Tunnel to	presence.teams.microsoft.com:443	0			teams:10100
60	200	HTTP	Tunnel to	config.fp.measure.office.com:443	0			chrome:15792
61	200	HTTP	Tunnel to	browser.pipe.aria.microsoft.com:443	0			chrome:15792
62	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
63	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
64	200	HTTP	Tunnel to	lpcres.delve.office.com:443	0			chrome:15792
65	200	HTTP	Tunnel to	a.config.skype.com:443	0			chrome:15792
66	200	HTTP	Tunnel to	outlook-1.cdn.office.net:443	0			chrome:15792
67	200	HTTP	Tunnel to	browser.pipe.aria.microsoft.com:443	0			chrome:15792
68	200	HTTP	Tunnel to	outlook-1.cdn.office.net:443	0			chrome:15792
69	200	HTTP	Tunnel to	outlook-1.cdn.office.net:443	0			chrome:15792
70	200	HTTP	Tunnel to	outlook-1.cdn.office.net:443	0			chrome:15792
71	200	HTTP	Tunnel to	outlook-1.cdn.office.net:443	0			chrome:15792
72	200	HTTP	Tunnel to	outlook-1.cdn.office.net:443	0			chrome:15792
73	200	HTTP	Tunnel to	webdir.online.lync.com:443	0			chrome:15792
74	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
75	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
76	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
77	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
78	200	HTTP	Tunnel to	browser.pipe.aria.microsoft.com:443	0			chrome:15792
79	200	HTTP	Tunnel to	swx.cdn.skype.com:443	0			chrome:15792
80	200	HTTP	Tunnel to	clients4.google.com:443	0			chrome:15792
81	200	HTTP	Tunnel to	login.windows.net:443	0			chrome:15792
82	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
83	200	HTTP	Tunnel to	outlook.office365.com:443	0			chrome:15792
84	200	HTTP	Tunnel to	login.microsoftonline.com:443	0			chrome:15792
85	200	HTTP	Tunnel to	webdir4a.online.lync.com:443	0			chrome:15792
86	200	HTTP	Tunnel to	webdir0b.online.lync.com:443	0			chrome:15792
87	200	HTTP	Tunnel to	bf4f13b4b68c4decad058f50ccb73154.fp.measure.office.com:443	0			chrome:15792
88	200	HTTP	Tunnel to	waconafd.officeapps.live.com:443	0			chrome:15792
89	200	HTTP	Tunnel to	outlook.office.com:443	0			chrome:15792
90	200	HTTP	Tunnel to	upload.fp.measure.office.com:443	0			chrome:15792
91	200	HTTP	Tunnel to	webpooldm10b05.infra.lync.com:443	0			chrome:15792
92	200	HTTP	Tunnel to	outlook.office.com:443	0			teams:10100
93	200	HTTP	Tunnel to	teaminc.visualstudio.com:443	0			gitkraken:5736
94	200	HTTP	Tunnel to	teaminc.visualstudio.com:443	0			gitkraken:5736

@jakehockey10 Fiddler can generate .saz file, can you try doing that and email it to me (email in my profile)? Thanks!

Finally found time to send it over.  Should be in your inbox shortly

@jakehockey10 Haven't received it yet, try again?

Here is a screenshot of it in my sent folder. I forwarded it to you again just now.

@jasonnutter I tried again, sending from my personal email. Thanks for your patience

Seeing this intermittently as well.  We're using Msal v1.3.0 & azure/msal-angular v1.0.0.

@jasonnutter We no longer use MSAL for Angular.

respect!, track how many issues for it, it's a mess, it doesn't sit well with IOS and MAC os at all.
One more 'solution' from Microsoft:(

Hi everyone,
I faced the same problem in production application and we have discovered 2 problems :

we were passing the graph scope to every acquireTokenSilent. using only our custom scope for custom api resources access fixed part of the issue by stopping retrieving a new token for every request. This means we removed openid profile from our scope resources and we are using it only for signin.
we implemented a retry strategy in angular interceptor based on https://www.learnrxjs.io/learn-rxjs/operators/error_handling/retrywhen

return defer(() => this._msalService.msalService.acquireTokenSilent({ scopes, redirectUri: '' }).then((response: AuthResponse) => {
        token = response.tokenType === ServerHashParamKeys.ID_TOKEN ? response.idToken.rawIdToken : response.accessToken;
        if (token) {
          req = req.clone({ headers: req.headers.set('Authorization', `Bearer ${token}`) });
        }
        return req;
      }))
      .pipe(
        retryWhen(genericRetryStrategy()),
        mergeMap(nextReq => next.handle(nextReq))
      );

Hope it can help

We have the same issue here after upgrading to MSAL Angular version 1.x.x.
When will this be fixed?

@alexandermainz Timeouts can happen for many reasons. Are there errors in the browser console or in the MSAL logs? Are you using hash routing?

Closing. If you are having problems with timeouts, please open a new issue, thanks!


Provide Admin Interface for the adding/editing of Messages

Still in the pie-in-the-sky phase - but it would be really nice to have a non-code interface for the addition of new messages or resources for the bot.  This would NOT be for the addition of a new endpoint (or slash command or event) - just for small changes to existing functionality.  Haven't thought it through much further than that, but welcome suggestions or thoughts at this stage.

@BethanyG I think this is great, but seems like a far future feature - let's add to back log for now?

agreed.  Do we have a backlog tag?
-B
Sent from my iPhone

On Feb 28, 2018, at 3:45 PM, Angelo Cordon<EMAIL_ADDRESS>wrote:
@BethanyG I think this is great, but seems like a far future feature - let's add to back log for now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

not so much admin feature, but the view-resources feature we've just merged in #64 is a start to something like this


Add more torque units

Add

J/rad

and units based on mass at surface of the earth:

lb*ft (pounds-force-feet) or ft*lb (foot-pound force)
ft*pdl (foot-poundal)
in*lbf (inch-pound force)
oz*in (ounce-force-inches) or in*ozf?
g*cm (gram-centimetre) or cm*g?
tonne*m (tonne-metre) or m*tonne?

where
gravity = 9.80665 m/s^2
http://en.wikipedia.org/wiki/Conversion_of_units#Torque_or_moment_of_force
http://www.convertunits.com/info/tonne-meter
http://en.wikipedia.org/wiki/Torque

I'd also appreciate Nmm and Ncm, being practical units for me.

Simply add the units to Units.csv
https://github.com/objorke/QuantityTypes/blob/master/Source/QuantityTypes/Quantities/Units.csv#L152
and make a pull request!

Done (for Ncm, Nmm, not sure about the others suggested on top)


Grafana agent crashes postgresql-k8s ARM charm in loki_push_api._setup_promtail() : KeyError: 'aarch64'

Bug Description
Data Team has created ARM support for PostgreSQL VM and K8s.
VM works well, but K8s crashes on relation postgresql-k8s<>grafana-ahent-k8s:
> juju status
Model    Controller  Cloud/Region    Version  SLA          Timestamp
testk3s  lxd         k3sarm/default  3.4.2    unsupported  10:35:54+02:00

SAAS        Status  Store  URL
grafana     active  lxd    admin/cos.grafana
loki        active  lxd    admin/cos.loki
prometheus  active  lxd    admin/cos.prometheus

App                  Version  Status   Scale  Charm                Channel        Rev  Address        Exposed  Message
grafana-agent-k8s             active       1  grafana-agent-k8s    latest/edge     75  <IP_ADDRESS>   no
postgresql-k8s       14.11    waiting      1  postgresql-k8s       14/candidate   248  <IP_ADDRESS>  no       installing agent
postgresql-test-app           active       1  postgresql-test-app  latest/stable  118  <IP_ADDRESS>    no       received database credentials of the first database

Unit                    Workload  Agent  Address      Ports  Message
grafana-agent-k8s/0*    active    idle   <IP_ADDRESS>
postgresql-k8s/0*       error     idle   <IP_ADDRESS>         hook failed: "logging-relation-changed"
postgresql-test-app/0*  active    idle   <IP_ADDRESS>         received database credentials of the first database

See the debug-log below.
To Reproduce
juju set-model-constraints arch=arm64
juju deploy postgresql-k8s --trust --channel 14/edge --config profile=testing # rev248
juju deploy grafana-agent-k8s --trust --channel edge # rev75
... relate all together with COS.
Environment
10:37:17 ✔ taurus:((rev248))~/canonical/postgresql-k8s-operator$ grep LIB lib/charms/loki_k8s/v0/loki_push_api.py
LIBID = "bf76f23cdd03464b877c52bd1d2f563e"
LIBAPI = 0
LIBPATCH = 29
Relevant log output
unit-grafana-agent-k8s-0: 09:31:18 ERROR juju.worker.uniter.operation hook "agent-pebble-ready" (via hook dispatching script: dispatch) failed: exit status
 1
unit-grafana-agent-k8s-0: 09:31:18 ERROR juju.worker.uniter pebble poll failed for container "agent": failed to send pebble-ready event: hook failed
unit-postgresql-k8s-0: 09:31:20 ERROR unit.postgresql-k8s/0.juju-log logging:13: Uncaught exception while in charm code:
Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/./src/charm.py", line 1690, in <module>
    main(PostgresqlOperatorCharm, use_juju_for_storage=True)
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/venv/ops/main.py", line 544, in main
    manager.run()
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/venv/ops/main.py", line 520, in run
    self._emit()
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/venv/ops/main.py", line 509, in _emit
    _emit_charm_event(self.charm, self.dispatcher.event_name)
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/venv/ops/main.py", line 143, in _emit_charm_event
    event_to_emit.emit(*args, **kwargs)
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/venv/ops/framework.py", line 352, in emit
    framework._emit(event)
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/venv/ops/framework.py", line 851, in _emit
    self._reemit(event_path)
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/venv/ops/framework.py", line 941, in _reemit
    custom_handler(event)
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/lib/charms/loki_k8s/v0/loki_push_api.py", line 1855, in _on_relation_changed
    self._setup_promtail()
  File "/var/lib/juju/agents/unit-postgresql-k8s-0/charm/lib/charms/loki_k8s/v0/loki_push_api.py", line 2321, in _setup_promtail
    if not self._is_promtail_installed(promtail_binaries[self._arch]):
KeyError: 'aarch64'

### Additional context

The charm is using the latest loki library LIBPATCH 29.

You are using the v0 library. Loki is currently on v1, where this has been addressed.


Change the idle timeout to 5 mins for client connection settings

This PR makes sure the idle timeout is long enough for the action invocation to complete. By default, the idle timeout for a client connection is 1 minute. This PR changes it to 5 minutes in order to give enough time for the action call to finish. As an Akka client,  the idle timeout needs to be configured for both of clientConnectionSettings and connectionPoolSettings.
Closes: #3016

description? what is the pr solving?

This has already been added by me to the relevant application.conf in 1a4493f. I might've used the wrong setting, but we should keep akka-related settings in the relevant config file, thoughts?

akka.http.client.idle-timeout = 90 s added to application.conf should have worked, but based on my observation, it works in travis for openwhisk, but the configuration for timeout and even other akka client settings does not work in the Jenkins build, which is the reason that I switch all the configurations of akka client for test cases into the REST framework in scala code. @markusthoemmes @rabbah

@houshengbo I presume that's due to a missing application.conf on the Jenkins side then?

@markusthoemmes Is this you can fix for Jenkins? Besides, we need to change the timeout of akka.http.host-connection-pool.idle-timeout and akka.http.host-connection-pool.client.idle-timeout as well.
@jeremiaswerner We are still seeing the timeout issue occasionally raised for sequence tests. IMO, we need to change

akka.http.client.idle-timeout
akka.http.host-connection-pool.idle-timeout
akka.http.host-connection-pool.client.idle-timeout.

@houshengbo sounds good, can you add those to the application.conf settings in tests and roll back the code changes?

@houshengbo I took the liberty to add a commit and rebase the branch so you'll need to refetch your branch.

@markusthoemmes Thank you. This works for me.


Highly sub-optimal UX of make cli-install at HEAD of master

What happened:
A user followed dubious KUDO installation instructions on a third-party site (see (3) Get started) and got a non-functional KUDO installation, where the API resources matched HEAD code (and so included a MutatingWebhookConfiguration unconditionally), except for the statefulset's docker image reference, which was kudobuilder/controller:v0.13.0 docker image (which requires an ENABLE_WEBHOOKS=true env variable to be set to actually serve the endpoint).
The result was:
Error: failed to install instance zookeeper-instance: installing Instance: Internal error occurred: failed calling webhook "instance-admission.kudo.dev": Post https://kudo-controller-manager-service.kudo-system.svc:443/admit-kudo-dev-v1beta1-instance?timeout=30s: dial tcp <IP_ADDRESS>:443: connect: connection refused

What you expected to happen:
Several things:
Ideally, no end-user instructions should encourage installation of unreleased code from tip of master. We should ask Mayadata to point to our install instructions instead. Since we cannot find and weed out all such sites, we should also make it more awkward to use this method.
Secondly, when using CLI built from tip of master, then by default:

either the docker image used should be something matching the tip of master as closely as possible. Probably something like kudobuilder/controller:latest which should be built and pushed on every commit,
or the default should be to fail and require a docker image tag to be specified explicitly

How to reproduce it (as minimally and precisely as possible):
Follow the aforementioned instructions.
Anything else we need to know?:
The reason why v0.13.0 was used is because it gets the version from $LDFLAGS which we set with:
GIT_VERSION_PATH := github.com/kudobuilder/kudo/pkg/version.gitVersion
GIT_VERSION := $(shell git describe --abbrev=0 --tags | cut -b 2-)
[...]
LDFLAGS := -X ${GIT_VERSION_PATH}=${GIT_VERSION} -X ${GIT_COMMIT_PATH}=${GIT_COMMIT} -X ${BUILD_DATE_PATH}=${BUILD_DATE}

and at the point the user ran make cli-install a couple of days ago, the latest tag happened to be v0.13.0. Today it is v0.14.0-rc1.
More details in slack thread.
Environment:

Kubernetes version (use kubectl version):
Kudo version (use kubectl kudo version):
Operator:
operatorVersion:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

Note this is not the first time someone had an issue with installing KUDO like this. The first time we removed such instructions from our site: https://github.com/kudobuilder/kudo.dev/pull/236 but apparently this is not enough.

Isn't the issue here that we're referencing the last released controller even if master is already ahead? Once a version of KUDO is released, we should consider every commit to master afterwards as commits towards the next version of KUDO and this should also be reflected in the controller image kubectl kudo init will use. I.e. it should reference the next, still unreleased image that users would have to build on their own.

Isn't the issue here that [...]

Yes, I think this is a re-phrasing of what I wrote under:

Secondly [...]

In the initial message.

Yes, you're right.

it was definitely not good that we advertised make cli as an installation method on our website... that is fixed.   We can't control what people do on their sites...
we should not pollute the dev workspace with messages that are meaningless to devs... if someone wants to "build" linux and has issues with their OS... yeah.. that is why we have packaged solutions.
the title of this issue seems completely wrong to me... make cli-install is optimal for it's purpose... it has a sub-optimal UX for those that don't know or understand the nuances of dev... for which we have optimal solutions for.

I don't agree with most of this issue as well:

we should NOT spend time on defaulting an image "close" to master... there is an --kudo-image flag for managing the preferred image for devs
and I'm strongly opposed to using the ":latest" flag... for lots of reasons.. but a simple 1 is when we have a breaking change, latest may be more sub-optimal.

The solution to me is clear...   if you are not a dev... are not an advanced user... don't use the dev tools.

With regards to the original user issue, I have asked Murat at Mayadata to update their blog and just point to our install instructions.

Ken, can you please explain what you mean by:

if someone wants to "build" linux and has issues with their OS...

What "issues with OS" do you have in mind? The issue the user faced was not OS-related as far as I can tell. It was the fact that, at times, the CLI built on tip of master points to a controller image which is incompatible with the rest of it.


Configuration file

Hi,
I love the cockpit concept but cannot really find a way to configure MongoDb with username/password auth. The documentation is basically zero on this.
I tried something like this with no luck:
database:
    server: mongodb://username:password@ipaddress:27017/
    options:
        db: dbname

I copied the sqlite "accounts" data into an "accounts" collection in Mongo.
No success either. Cockpit does not log until I remove these lines from the config file (that is, restoring SQlite).
Any help?
Thanks

did you after switching to mongodb open/run /install in the browser?

Yes, but it autodirects to the login page. Is this unexpected?
Do you have any sort of material/document I can skim to get some ideas?
Thanks
2017-11-22 15:02 GMT+01:00 Artur<EMAIL_ADDRESS>
did you after switching to mongodb open/run /install in the browser?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/agentejo/cockpit/issues/602#issuecomment-346358531,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMXfHujGk2bdguxPRdszjbcB1FiGj1mLks5s5CmPgaJpZM4QmMim
.

Hi all,
I also get the same problem when I update config.yaml by adding these line:
database:
  server: mongodb://localhost:27017
  options:
    db: cockpitdb

The browser shows error 500. I have try to add these line before and after run /install.
I have install mongodb on localhost, PHP 7.1 and nginx.

Hi @frankglv, I have solve this problem. If you got same situation like I described above, it is because PHP extension for MongoDB is not installed. You can see this page to install MongoDB PHP Driver http://php.net/manual/en/mongodb.installation.pecl.php
And I think Cockpit must describe about this issue in documentation.

If anyone has a working example of how to connect to MongoDB 3.6.3 with config.yaml I would really appreciate it. I installed the mongodb pecl extension, enabled it, and restarted php7.2-fpm and apache2 without issue.
I've tried a couple of config variations of this in config.yaml:
# use mongodb as main data storage
database:
    server: mongodb://username:password@localhost:27017
    options:
        db: cockpit

and this:
# use mongodb as main data storage
database:
    server: mongodb://localhost:27017
    options:
        db: cockpit
    auth:
        username: cockpit
        password: Cb0CzQwSa8yzQ5f

Both both throw the following fatal error:
[Tue Mar 20 00:49:53.925658 2018] [proxy_fcgi:error] [pid 7558:tid<PHONE_NUMBER>71552] [client <IP_ADDRESS>:44694] AH01071: Got error 'PHP message: PHP Fatal error:  Uncaught MongoDB\\Driver\\Exception\\RuntimeException: there are no users authenticated in /var/www/html/cockpit/lib/MongoDB/Operation/InsertOne.php:106\nStack trace:\n#0 /var/www/html/cockpit/lib/MongoDB/Operation/InsertOne.php(106): MongoDB\\Driver\\Server->executeBulkWrite('cockpit.cockpit...', Object(MongoDB\\Driver\\BulkWrite), Object(MongoDB\\Driver\\WriteConcern))\n#1 /var/www/html/cockpit/lib/MongoDB/Collection.php(751): MongoDB\\Operation\\InsertOne->execute(Object(MongoDB\\Driver\\Server))\n#2 /var/www/html/cockpit/lib/MongoHybrid/Mongo.php(102): MongoDB\\Collection->insertOne(Array)\n#3 /var/www/html/cockpit/lib/MongoHybrid/Client.php(40): MongoHybrid\\Mongo->insert('cockpit/account...', Array)\n#4 /var/www/html/cockpit/install/index.php(63): MongoHybrid\\Client->insert('cockpit/account...', Array)\n#5 {main}\n  thrown in /var/www/html/cockpit/lib/MongoDB/Operation/InsertOne.php on line 106\n
I want to use MongoDB because the project needs a more robust DB than sqlite3. So, grateful for any help you can provide. Thanks very much.

@frankglv After experiencing the same issue, I dig into the doc and found the problem. The database name is required if you specify the username/password in the server URI. Otherwise, Mongo try to connect to the admin database.
So just adding the database name at the end like this should solve your problem.
database:
    server: mongodb://username:password@ipaddress:27017/dbname
    options:
        db: dbname

And don't forget to redo the /install
Link to doc: https://docs.mongodb.com/manual/reference/connection-string/

Hello!
I've installed cockpit on Ubuntu 16.04.4 LTS using repository packages for PHP7 and drivers with nginx. Works perfectly with SQLite but can't use MongoDB. I believe my config.yaml file is ok.
This is the error:
PHP message: PHP Fatal error:  Uncaught Error: Call to undefined method MongoDB\Driver\ReadConcern::isDefault() in ...lib/MongoDB/Operation/Count.php:124

And this is the driver:
mongodb

mongodb support => enabled
mongodb version => 1.1.5
mongodb stability => stable
libmongoc version => 1.3.3
libbson version => 1.3.3

Could it be the driver? I installed it using apt-get.
Thanks!

@rlora You are running a very old version of MongoDB. Try to update to 3.6.

@cguillou thanks! I'm running mongo on a Compose deployment, tried with two versions, I think 2.4 and 3.6. Maybe it is the driver then, I'll try to compile a new one.


Implement C package: Declarations8

Description
Decl8
Change request type

[ ] Release or process automation (GitHub workflows, internal scripts)
[ ] Internal documentation
[ ] External documentation
[x] Query files (.ql, .qll, .qls or unit tests)
[ ] External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

[ ] No rules added
[x] Queries have been added for the following rules:

DCL30-C

[ ] Queries have been modified for the following rules:

rule number here

Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?

[ ] Yes
[x] No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

[ ] Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

[ ] Confirmed

Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author

[x] Have all the relevant rule package description files been checked in?
[x] Have you verified that the metadata properties of each new query is set appropriately?
[x] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[x] Are the alert messages properly formatted and consistent with the style guide?
[x] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[x] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

Reviewer

[ ] Have all the relevant rule package description files been checked in?
[ ] Have you verified that the metadata properties of each new query is set appropriately?
[ ] Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
[ ] Are the alert messages properly formatted and consistent with the style guide?
[ ] Have you run the queries on OpenPilot and verified that the performance and results are acceptable?As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
[ ] Does the query have an appropriate level of in-query comments/documentation?
[ ] Have you considered/identified possible edge cases?
[ ] Does the query not reinvent features in the standard library?
[ ] Can the query be simplified further (not golfed!)

Notes DCL30-C
I chose to implement a specific subset of cases for this rule, as opposed to the general title/description of the rule. The examples in the wiki only describe the cases that I chose to cover and the tool comparison part of the wiki/logistics details described confirm that handling more general cases is a more difficult problem
This query was very close to several pre-existing queries...

the C++ rule M7-5-1 covers one specific part of the cases that I chose to cover (however C does not have references so I opted to write one query to unify the cases and omit the unnecessary reference bits)
the out of the box queries - ReturnStackAllocatedMemory and StackAddressEscapes also cover pretty similar scenarios, however as I said, I chose to unify the results into one query and additionally StackAddressEscapes has the same FP that my version does so I think maybe the results are not too different?

possible expansions
if it seems necessary for this query to cover more of the ways that storage durations can conflict or lead to undefined behaviour , possibly this query for thread storage durations could be a shared query split for the thread case specifically

There is actually an even closer shared query we've written: DoNotCopyAddressOfAutoStorageObjectToOtherObject.qll
This is used in:

M7-5-2 AssignmentOfEscapingAutoStorage.ql
Rule 18.6 AutomaticStorageObjectAddressCopiedToOtherObject.ql

I think the query you've written covers essentially the same topics, so I think I would recommend replacing your query with an import query for the same library. The shared query could be extended if it doesn't cover all the cases (return statements?).

There is actually an even closer shared query we've written: DoNotCopyAddressOfAutoStorageObjectToOtherObject.qll
This is used in:

M7-5-2 AssignmentOfEscapingAutoStorage.ql
Rule 18.6 AutomaticStorageObjectAddressCopiedToOtherObject.ql

I think the query you've written covers essentially the same topics, so I think I would recommend replacing your query with an import query for the same library. The shared query could be extended if it doesn't cover all the cases (return statements?).

@lcartey, thanks for the review! I took a look,
I think DCL30-C == M7-5-1 + M7-5-2 (this one is actually using the out of the box equivalent for stack addresses that I found, but is the refined for our purposes version, so thank you for the much better find!)
I have now split and use the shared lib for the M7-5-2 part
however now that I look at the M7-5-1 implementation , I still think that maybe my version of it makes more sense for C (omitting the references stuff and using dataflow instead of not), unless you think that both need an update?


The Env variables are packed into the JS bundle

This plugin is using some environment variables to get azure account related info with the prefix "NX_".
But at the same time, the nx react plugin will inject environment variables with the same prefix into the code, and it will cause the credential leak.

#8
I created a PR @NiklasPor  could you take a look?

Fixed in 3.0.0 thanks for pointing this out 👏


feat(ingest/fivetran): support overriding destination db

Improves ingestion perf + reduces memory usage/errors
Deprecates sources_to_database in favor of a unified config.
Supports overriding platform/db details for sources and destinations.

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@coderabbitai configuration


Offer to design a logo

I'm an experienced designer, and I just found out about this great tool.
If it's something that could help the cause even if it's only so that online articles can put a face on it (and, therefore, a bit of a brand to it), I will design its icon and/or any other imagery that may be requested.
Nevertheless, great job !

I would love to have a logo for the project. but never came up with a good "metaphor" for it..
Any help is greatly appreciated, specially since I won't have time to work on the logo anytime soon. I don't even have illustrator installed on my current laptop.
PS: I designed logos for my other projects (MOUT, Crossroads, Hasher...) and I do agree that it helps when the project have an identity - I used to be a designer but nowadays I usually stick to development (portfolio with design work done prior to 2009)...

Then our stories are reversed :) I've been a developer (mostly low level, C stuff) since I was a kid and I design was always something I wanted to give some time to.
Let me know if you come up with something specific you think should be in the logo, in the meantime I'll try to come up with something simple. I'd be cool to have a simple frontend like jsbeatufier using esformatter. Let's see what the time brings.

Hi there,
Ideally, I wanted an illustrated logo plus the typography but "esformatter" proved to be too long for that, so I opted for a mixed solution.

Critics? ;)

@nmaxcom I think it looks nice :smile:

Happy to hear that from a pro :blush:
Can't wait to see it around!

Forgot to upload!
Illustrator source: main.ai.zip
And the exports:

I like the direction but the font seems to have too much negative space.  Also, what if the "f" was the knockout color, since the project focus is the formatting?  Just some thoughts.

@granteagon sure, the focus is on formatting. That's what I was pursuing putting the ">" symbol in the E. But if the public doesn't see it, I missed it. Still, being two big white cap letters leading to a black small case one... I don't think the 'f' is easily dismissed.
Furthermore, interchanging the "knockout colors" would make the whole thing too dark, wouldn't it?

@nmaxcom Why don't you bold ES and just stroke the f with no background color?  It will make it much easier to use it in different places if you don't have contrasting colors on the logo.

@granteagon I'm open to adjust the design for sure, I don't quite understand what do you want me to test though: the logo itself (blue square etc) or the letters of the title? IIRC in the former they are already bold.

@millermedeiros What do you say? I think it matches both the field and your project in particular. Let me know, it's dying buried in here :\


enable maven profile activation with idk version

Hi Christian,
I updated the pom.xml a bit to make the maven select the right profile (java-6 or java-8) automatically. Hope it simplifies the project building.
Best regards,
William

Hi William.
I am not sure if I am merging that pull request. I have the following problem: If the pom contains the activation, I can no longer select the profile using mvn -Pjava-6 or mvn -Pjava-8. However, I still like to run the Java 6 builds, even if I am on a Java 8 JDK.
But maybe it is better to run the builds on their target JDKs, in which case your change is perfect. Or is there any way to alter the activation?
Best
Christian

Hi Christian,
http://stackoverflow.com/questions/25201430/de-activate-a-maven-profile-from-command-line
I am sorry the trouble it may cause. To force java6 build with a jdk8, we
may use the option like -P!java-8 -Pjava-6. The '!' helps to turn off a
profile with force. Hope it helps.
Best regards,
William
On Thu, 4 Feb 2016 at 4:43 PM, Christian Fries<EMAIL_ADDRESS>wrote:

Hi William.
I am not sure if I am merging that pull request. I have the following
problem: If the pom contains the activation, I can no longer select the
profile using mvn -Pjava-6 or mvn -Pjava-8. However, I still like to run
the Java 6 builds, even if I am on a Java 8 JDK.
But maybe it is better to run the builds on their target JDKs, in which
case your change is perfect. Or is there any way to alter the activation?
Best
Christian
—
Reply to this email directly or view it on GitHub
https://github.com/finmath/finmath-lib/pull/7#issuecomment-179711525.

Thank you William. Sorry for the late merge.


Overriding TAG option in command not work when run more features

Current behavior
Currently if I have project with more feature files and I want to run all feature files and once but ONLY test cases that have specific tag, it just ignore it.
I am using scripts command to run:
"cy:pipeline": "branch=${CI_COMMIT_REF_SLUG:-$(git rev-parse --abbrev-ref HEAD)}; cypress run --project ./apps/my-app --browser=electron --e2e --config-file cypress/configs/deployed.config.js --env branchPath=$branch",
This script is called from pipeline  or manually(command from makefile):
npm run cy:pipeline -- --config '{"specPattern":"**/API/user-ms.feature"}' --env '{"TAGS":"@manually", "branchPath":"$$CI_COMMIT_REF_SLUG"}'
Result is that all tests are run.

Desired behavior
Desired behavior is to run only test cases that have tag @manually

Test code to reproduce

Versions

Cypress version: 11.2
Preprocessor version: 15.0.0
Node version: 16.17.0

Checklist

[x] I've read the FAQ.
[X] I've read Instructions for logging issues.
[x] I'm not using<EMAIL_ADDRESS>(package name has changed and it is no longer the most recent version, see #689).

Closing due to lack of reproducible example. Feel free to open up another issue if anything changes in this regard.