Added example DNS & SSL configuration

Hi Team! First time doing a pull request! Working with Joe Mirabal who has a customer looking to use the CFT and SSL/TLS and Route 53. Ed Randall may create some additional documentation providing customers some guidance. In the meantime, David Rosenblum asked me to take a look.
So, here's an example of creating an SSL cert, using it on the listeners, and creating a DNS record within Route 53. I tested using our neo4j-field hosted zone within Route 53. I tested deploying only a single Neo4j instance. Not a cluster. But I did not change anything within the script for deploying Neo4j. The certs are applied to the NLB while the Neo4j ports remain as the default ports.
Hit me up on slack if any questions.

@jshair thanks for raising the PR.
can you put the entire code under custom templates directory ?
https://github.com/neo4j-partners/amazon-cloud-formation-neo4j/tree/main/custom-templates
We would not want to merge this in the main template which is used in the marketplace listing. Hence , we have a directory called "Custom Templates" where we push all the R&D type templates

Hi Harshit and Ed. I finally got around to moving files and polishing up the associated README. Take a gander when you get a chance.


Add SD XL documentation

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Improve element comparison; add per-character clipping strategy

Copy font, padding and margin styles to hidden test element, since once it changes CSS scope it may not look the same, making the comparison logic invalid and potentially leading to an unwanted loop of text clipping if the test element's font is larger.
Add a fallback per-character clipping strategy for use with, for example, Chinese characters where the space character is not used to separate words.

You couldn't add per character clipping strategy into this algorithm, because you will append ellipsis after space chars. See #11.


Add hologram Converter API

Adds the HologramConverter interface for creating multiple converter implementations.

e.g. a builtin DecentHologramsConverter that converts lines and optionally attempts to convert icons to item holograms that align with the text

Adds the FHConversionRegistry to store and procure all HologramConverter.
Adds the /fancyholograms convert <converterId> <target> [args...] command to invoke the converters.
Adds the ConverterTarget class which is essentially a regex to target holograms individually or as groups.
An example of API usage:
ConverterTarget target = ConverterTarget.all();

// The constructor can also take in a CommandSender sender  and String[] args for logging results/errors and processing additional arguments.
HologramConversionSession session = new HologramConversionSession(target);

FHConversionRegistry.getConverterById("DecentHolograms")
  .ifPresent((converter) -> {
    List<HologramData> data = converter.convert(session);

    // Handle the data yourself e.g. add it to manager and save.
  });

This additionally allows players to control translation of holograms through the command /holo edit <hologram> translation <x> <y> <z>

I'll have a look at the exception and finish the TODOs, I think it's just for handling errors.

@OliverSchlueter Should have fixed the thrown exception, also filters out any converters deemed not usable from tab completion.


Icons in buttons need accessible names

Update website button group examples by adding title to button groups that have only icons.

Adding a reminder for Developers to add a title to icons when the button doesn't have human-readable text

Use only Core Icons inside the Buttons & Buttons Group examples. No need to load other icons sets.

Make clrIcon shape attribute case-insensitive - HOME and home must equal the same icon.

TODO:
Backport it to V1

I'm hijacking one of @hippee-lee clrIcons test for the case-insensitivity change. I don't think that I need one more test just for that.


Testsuite attachments links are broken

when try to click on this file, result in "Not Found"

Verified
Now attachment links are working


xkeyboardconfig: Depends on intltool for build

Fix error:
Your intltool is too old.  You need intltool 0.30 or later.
Noticed during #238's Travis build https://travis-ci.org/Linuxbrew/homebrew-xorg/builds/187235708#L2939

also (from personal build)
checking for perl >= 5.8.1... 5.24.0
checking for XML::Parser... configure: error: XML::Parser perl module is required for intltool

XML::Parser perl module is required for intltool

I've opened https://github.com/Linuxbrew/homebrew-core/pull/1440 to deal with that.

I've reinstalled perl on my local machine, added intltool as a dependency and still get:
You must have XML::Parser installed to run [linuxbrew]/bin/intltool-merge

Merging translations into base.xml.
make[2]: *** [base.xml] Error 2
make[2]: *** Waiting for unfinished jobs....

Hmm, looks like intltool-merge forces the use of /usr/bin/perl.
That can be fixed, but for now I guess you'll have to either install XML::Parser using your system package manager or manually change the shebang line :frowning_man:

oh, right! I remember that.

Either way, IMO it doesn't block the merge of this PR. Agree?
Agree

https://github.com/Homebrew/homebrew-core/pull/8360

Homebrew's PR got closed.
https://github.com/Linuxbrew/homebrew-core/pull/1443


[POAE7-2640] CIDER-VELOX to support batchProcessor

What changes were proposed in this pull request?

add PlantTranslator to support batchProcessor
Why are the changes needed?

enable batchProcessor for cider-velox
Does this PR introduce any user-facing change?

No
How was this patch tested?

existing test
Which label does this PR belong to?

veloxIntegration

Once this merged, should we turn on a test profile for E-2-E test (from Presto -> Cider) on nightly test?


feat: export protobuf separately, avoid loading gRPC unless needed

This PR contains a set of small fixes and new exports that will allow client libraries load just the REST version of google-gax, without auto-loading gRPC. The first library that will immediately benefit from this is Firestore.

@alexander-fenster This seems like an interesting addition, but as a result, I'm no longer able to bundle @google-cloud/logging-min, which depends on this package, using esbuild. The reason is that build/protos/protos.js contains:
require("google-gax/build/src/protobuf")

which makes the latest version of esbuild crash with:
Could not resolve "google-gax/build/src/protobuf"

and indeed, node_modules/google-gax/build/src/protobuf.js isn't there.


puppet server cannot load library when calling function

I think I am hitting this issue. https://tickets.puppetlabs.com/browse/SERVER-973
Using PE 3.8 with puppet server.

We should distribute this as a gem as well to get around some of these issues.

https://github.com/logicminds/node_encrypt_gem
I created this to see if this would fix my problem.  If it works I think this should be available on ruby gems as well. I don't want to maintain it though.  So just fork my repo and publish it with your name.

I am actually unable to replicate this. The function works properly in every environment I've tried, and the type works properly except for the autobefore problem on 3.x.
PE 2015:
root@master:~ # puppet --version
4.3.2
root@master:~ # puppet resource package pe-puppetserver
package { 'pe-puppetserver':
  ensure => '2.2.40-1.el7',
}

PE 3.8:
root@master:~ # puppet --version
3.8.1 (Puppet Enterprise 3.8.1)
root@master:~ # puppet resource package pe-puppetserver
package { 'pe-puppetserver':
  ensure => '1.1.1-1.el6',
}

If it does turn out to be something I need to fix, I will probably take the route of https://github.com/nanliu/puppet-archive/blob/766062a3465053ca8a326ea0b3c31648a49474a4/lib/puppet/provider/archive/default.rb#L1-L10
I don't like the idea of switching to a gem to work around something intended to be delivered in a module.

@binford2k
If you created the following code for an agent
file{'/tmp/test.txt':
   ensure => present,
   content => node_encrypt('supersecret')
}

Then on the agent ran puppet agent --test you are saying the puppetserver is able to load the function and library code properly?
I believe you could also reproduce this using puppetserver irb then try loading require 'puppet_x/binford2k/node_encrypt'
Can you explain exactly how you are testing?

root@master:~ # tail -n 12 /etc/puppetlabs/code/environments/production/manifests/site.pp
node default {
  # This is where you can declare classes for all nodes.
  # Example:
  #   class { 'my_class': }

  node_encrypt::file { '/tmp/foo':
    owner   => 'root',
    group   => 'root',
    content => 'This string will never appear in the catalog.',
  }
}

root@master:~ # rm -f /tmp/foo
root@master:~ # puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for master.puppetlabs.vm
Info: Applying configuration version '1458216062'
Notice: /Stage[main]/Main/Node[default]/Node_encrypt::File[/tmp/foo]/Node_encrypted_file[/tmp/foo]/ensure: created
Notice: Applied catalog in 25.59 seconds
root@master:~ # cat /tmp/foo
This string will never appear in the catalog.

root@master:~ # puppet --version
4.3.2
root@master:~ # puppet resource package pe-puppetserver
package { 'pe-puppetserver':
  ensure => '2.2.40-1.el7',
}

Please try this instead.  I believe the type/ provider loads the code correctly but I am specifically complaining about functions which get loaded differently.
node default {
  # This is where you can declare classes for all nodes.
  # Example:
  #   class { 'my_class': }

 file { '/tmp/foo':
    owner   => 'root',
    group   => 'root',
    content => node_encrypt('This string will never appear in the catalog.'),
  }
}

It is a defined type that uses the function internally. That's how I force it to execute on the master during compilation. https://github.com/binford2k/binford2k-node_encrypt/blob/master/manifests/file.pp#L63

I think what might be happening is that because you are using the custom type in the defined type which loads the puppet_x library properly.  Then function works correctly because node_encrypt is already in the load path since the provider is loaded before the function. I still think there is a problem when you use the function by itself without the custom type involved.

root@master:~ # tail -n 12 /etc/puppetlabs/code/environments/production/manifests/site.pp
node default {
  # This is where you can declare classes for all nodes.
  # Example:
  #   class { 'my_class': }

  file { '/tmp/foo':
    owner   => 'root',
    group   => 'root',
    content => node_encrypt('This string will never appear in the catalog.'),
  }
}

root@master:~ # rm -rf /tmp/foo
root@master:~ # puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for master.puppetlabs.vm
Info: Applying configuration version '1458269220'
Notice: /Stage[main]/Main/Node[default]/File[/tmp/foo]/ensure: defined content as '{md5}318ff8cb125e33c0bae13a836f08c2df'
Notice: Applied catalog in 11.05 seconds
root@master:~ # cat /tmp/foo
-----BEGIN PKCS7-----
MIILlQYJKoZIhvcNAQcDoIILhjCCC4ICAQAxggJJMIICRQIBADAvMCoxKDAmBgNV
BAMMH1B1cHBldCBDQTogbWFzdGVyLnB1cHBldGxhYnMudm0CAQIwCwYJKoZIhvcN
AQEBBIICAA7AycoOOk4gVLaPCFWatER4rpt6UGUW4p5Kt6lqSLBllADCOztA3TV5
...
root@master:~ # puppet --version
4.3.2
root@master:~ # puppet resource package pe-puppetserver
package { 'pe-puppetserver':
  ensure => '2.2.40-1.el7',
}

@logicminds heyo. Circling back to this, is this related to #14 you think? Or was that just the lack of pluginsync that I suggested?

It is related to #14 and very well could be the cause.  But if others are using this without having to install the gem I created than I guess it is just my environment.  I am no longer on 3.8 having just deployed 2016.04.2.  But I still install the gem because it was just automatic (puppet code).
When you say lack of pluginsync?  Are you saying the puppetserver was not able to sync code to itself?
I should also mention that I am in a super locked down environment where the umask is 077 by default which might be my issue.

I was guessing that the problem of not being able to load the library code is because the master didn't pluginsync yet. I don't actually know for sure, it was conjecture.

I just submitted a PR which fixes this, and explains the underlying reason.


Issue #118 Fix identifier quoting

Use PgJDBC Utils.escapeIdentifier() function to do the quoting. Fixes #118.
This changes the functionality of the quoteIdentifier() function so that it doesn't treat identifiers starting and ending with a double quote as already quoted.

Good job! I will need a little bit of time for the release, because I didn’t configure my current machine yet. So I will leave this open until I have set up my environment, so I won’t forget about it.

Just a friendly reminder, it would be nice to get this merged and then get a new version released :)

I will request a new PGP signing key for the packages first. 🫣

@krisse7 Released to Central Maven Repositories as 8.1.0. I think it will be available soon.

@krisse7 Thanks for your patience and pinging me again, so I get my Java setup right again. 👍

@bytefish Thanks a lot for the new release!


Carbon language support

Adds support for the Carbon language. Carbon is an experimental language developed by Google.

Source code repository (carbon-language/carbon-lang)

Checklist

[X] I am adding a new language.

[X] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

.carbon: https://github.com/search?q=path%3A*.carbon&type=Code&ref=advsearch&l=&l=

[X] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

.carbon: https://github.com/github-linguist/linguist/pull/7011/commits/6193d8ef20e9600309315c5512022932ad02fefd#diff-e2449d8cdec8d56e7a85d9ef16521ab0192a58afe147dbe907d3cac76d3b0fab

[ ] I have included a syntax highlighting grammar

[X] I have added a color

Hex value: #222222
Rationale: Carbon uses a black circle with a C in it. This is not #000000, but they are similar.

[X] I have updated the heuristics to distinguish my language from others using the same extension.

A basic sample in /samples/Carbon, and .carbon and .cb extensions have been split into seperate search results.

Do you really want to add support without syntax highlighting? Normally the only reason people add support for a language is to get syntax highlighting on GitHub.

There is no syntax highlighter for it avaliable, although I may try to add one in the future.

@btdw Usually when we add support for a language that doesn't have a syntax highlighting grammar (or one released under a permissive license), we sometimes use another language's grammar as a fallback that happens to produce "good enough" highlighting. For example, here's one of your Carbon samples highlighted using Rust:
(Click to toggle)
package Shapes api;
import Math;

// Circle

class Circle {
    var Radius: f32 = 1;
    const var Diameter: f32 = self.Radius * 2;

    const var Pi: f32 = Math.Pi;

    fn Area() -> self;
    fn Circumference() -> self;
}

fn Circle.Area() -> self {
    return Math.Pi * .Radius ^ 2
}

fn Circle.Circumference() -> self {
    return 2 * Math.Pi * .Radius
}

// Rectangle

class Rectangle {
    var Width: f32 = 3;
    var Height: f32 = 1;

    fn Area() -> self;
}

fn Rectangle.Area() -> self {
    return .Width * .Height;
}

// Square (Note: Provides same functions as "Rectangle" class.)

class Square {
    var Width: f32 = 3;
    var Height: f32 = 1;

    fn Area() -> self;
}

fn Square.Area() -> self {
    return .Width * .Height;
}

// Triangle

class Triangle {
    var Width: f32 = 3;
    var Height: f32 = 3;

    fn Area() -> self;
}

fn Triangle.Area() -> self {
    return (.Width * .Height) / 2;
}

// Hexagon

class Hexagon {
    var Side: f32 = 5;

    fn Area() -> self;
}

fn Hexagon.Area() -> self {
    return ((3 * 1.732) / 2) * .Side ^ 2
}

@btdw Usually when we add support for a language that doesn't have a syntax highlighting grammar (or one released under a permissive license), we sometimes use another language's grammar as a fallback that happens to produce "good enough" highlighting. For example, here's one of your Carbon samples highlighted using Rust:

I've experimented with a couple and found the syntax for V works the best:
package Shapes api;
import Math;

// Circle

class Circle {
    var Radius: f32 = 1;
    const var Diameter: f32 = self.Radius * 2;

    const var Pi: f32 = Math.Pi;

    fn Area() -> self;
    fn Circumference() -> self;
}

fn Circle.Area() -> self {
    return Math.Pi * .Radius ^ 2
}

fn Circle.Circumference() -> self {
    return 2 * Math.Pi * .Radius
}

// Rectangle

class Rectangle {
    var Width: f32 = 3;
    var Height: f32 = 1;

    fn Area() -> self;
}

fn Rectangle.Area() -> self {
    return .Width * .Height;
}

// Square (Note: Provides same functions as "Rectangle" class.)

class Square {
    var Width: f32 = 3;
    var Height: f32 = 1;

    fn Area() -> self;
}

fn Square.Area() -> self {
    return .Width * .Height;
}

// Triangle

class Triangle {
    var Width: f32 = 3;
    var Height: f32 = 3;

    fn Area() -> self;
}

fn Triangle.Area() -> self {
    return (.Width * .Height) / 2;
}

// Hexagon

class Hexagon {
    var Side: f32 = 5;

    fn Area() -> self;
}

fn Hexagon.Area() -> self {
    return ((3 * 1.732) / 2) * .Side ^ 2
}

I've experimented with a couple and found the syntax for V works the best:

https://github.com/github-linguist/linguist/pull/7011/commits/9bdc91cf76fafacf81c515def9c4aac1214d7321 adds V syntax highlighting to Carbon files

Thanks for the suggestion, it was committed

@btdw You'll need to fix the failed test reported here. It simply involves updating vendor/README.md to include Carbon in the list. Just add this to the file on line 75:
--- expected
+++ actual
@@ -83,6 +83,7 @@
 - **Cairo:** [xshitaka/atom-language-cairo](https://github.com/xshitaka/atom-language-cairo)
 - **CameLIGO:** [pewulfman/Ligo-grammar](https://github.com/pewulfman/Ligo-grammar)
 - **Cap'n Proto:** [textmate/capnproto.tmbundle](https://github.com/textmate/capnproto.tmbundle)
+- **Carbon:** [0x9ef/vscode-vlang](https://github.com/0x9ef/vscode-vlang)


[fix]  component does not have "X" to clear

ReactUSWDS Version & USWDS Version:
"@trussworks/react-uswds": "^6.2.0",
"@uswds/uswds": "3.4.1",

Describe the bug
By default the USWDS Search component has the "X" to clear input functionality.
In Trussworks' implementation of the Search component, there is no "X" to clear input functionality. That seems to be exclusively available to items that utilize the <ComboBox />.
To Reproduce
Steps to reproduce the behavior:

Go to the Search component
https://trussworks.github.io/react-uswds/?path=/story/components-search-search--default-search
Attempt to clear via "X" to clear
There is none

Screenshots
USWDS Search input:

Trussworks Search input:

I think I found the issue, since that "X" is appearing as a native HTML element due to type="search" being an attribute on the <input> field, the issue is that the <form> that's wrapping it also has role="search". If you remove that, the "X" re-appears!

Demo of the "fix":
https://github.com/trussworks/react-uswds/assets/516877/2acaa705-6ca5-41a5-93c9-3193f695aa98

Noting that there is no 'x' even on the USWDS Search component if I'm using Firefox, but on Chrome it does appear.


Manifest dependency cycle does not generate a clear error.

Is this a bug report or feature request? (choose one):
BUG

Python Version (output of python --version):
Development or Deployment Environment?:
Release Tag or Master:
Expected Behavior:
What Actually Happened:
How to Reproduce the Issue (as minimally as possible):
Any Additional Comments:

could you provide the error you are getting?

This can be easily reproduced by having a chart definition depend on itself.  If you don't want to implement your own cycle detection, you may want to consider using https://networkx.github.io/  for that.
This is exposed by buggy configuration referred to in att-comdev/promenade#47


Update installing.rst

Thanks for the contribution! If you're interested in using AutoPyBind11 feel free to reach out for assistance/advice/new features!


Desperately needs at least 1 level of undo

To edit something in your DAW workflow you (1) start Harp (2) hit "load model" (3) wait 10 seconds (4) listen to the output....and then if you don't like what you did, you can't just turn a dial a bit and try again, because the audio is already altered. Instead, you have to quit Harp and restart the whole process. This is pretty awkward.   If we had even 1 level of 'undo', it would help a ton.

It would also be nice to add a "restore" option to revert back to the original file.

I just checked Logic Pro, Audacity and Audition. None of them have this "restore" option.  Could the user just re-load the file to get "restore" to happen?

Yes they can just reload (unless they overwrite the original). Just figured it could be a nice feature to have.

We now have undo!


Add missing cancellation token

Description
Adds missing default value for cancellation token.
Issue reference
This PR will close: #577
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Extended the documentation

Tests seem to fail due to #573

Awesome! Thanks. I'll try rerunning the tests for you.


[SF3] Doors not closing?

I've frequently had the doors to the counters and fridge get 'stuck' in the open position until I broke it and replaced it. Frequently happened when I tried to 'float' some counters in the air as cabinets. (Had to take them down anyway since they were not registering their inventories).

Did you shift-right click them maybe? Shift-right-clicking the doors will open/close the door without someone actually accessing the block.


Question on sections and accumulating errors

Hello,
I have somewhere in my program:
    let mut errs = Vec::new();
    while let Some(msg) = rx.recv().await {
        if let Err(err) = msg {
            errs.push(err);
        }
    }
    if errs.is_empty() {
        Ok(())
    } else {
        Err(errs
            .into_iter()
            .fold(eyre!("Build Failed"), |acc, err| acc.error(err)))
    }

Where the definition of the error I'm accumulating is:
#[derive(Debug, Error)]
#[error("{name}: {kind}")]
pub struct ParserError {
    name: String,
    kind: ParserOp,
    #[source]
    source: color_eyre::eyre::Error,
}

The field source will have an errors generated with sections like this (basically taken from your example):
            Err(msg
                .with_section(move || stdout.trim().to_string().header("Stdout:"))
                .with_section(move || stderr.trim().to_string().header("Stderr:")))

But when the error is printed, all sections are lost.
I'm trying to look at the docs and the code, but I'm either missing something, or it's expected and I'm not understanding how the lib works.
Is there a way to achieve what I'm expecting, maybe differently?

I believe the problem is that when you treat an eyre::Report as a source error it uses the Display impl instead of the Debug impl to get the error message. The debug impl is where the color_eyre::EyreHandler prints the full error report including sources and additional context, the Display impl will only print the error message from that specific error with the expectation that some other higher level reporter will then iterate over its sources and format a full and cohesive error report.
Depending on exactly you'd like the report to look there are probably a few ways you can achieve this, though nothing built into the library as is. Off of the top of my head you can either manually iterate over those sources and print them via debug instead of folding them all into another eyre::Report, or you could integrate such logic into your own custom https://docs.rs/eyre/latest/eyre/trait.EyreHandler.html, though this would unfortunately require duplicating a lot of code from color-eyre to preserve the rest of the functionality.


On Mac, uw_load is wrong when there are multiple volumes mounted

On a Mac, with an external disk or a dmg mounted, the columns in the output of the iostat command get shifted to the right (each disk adds 3 columns). This causes the result of uw_load to be very wrong.w
Reproduction steps:
Mount a dmg to add a new volume.
Usagewatch.uw_load
# => 11.0

The command used to get the current CPU load is iostat -w1 -c 2 | awk '{print $7}'.
That's happening because, with a mounted volume, the output of iostat -w1 -c 2 contains 3 more columns to the left of the load average columns, which messes up the result of the awk command.
# With an external volume:
$ iostat -w1 -c 2
              disk0               disk2       cpu    load average
    KB/t  tps  MB/s     KB/t  tps  MB/s  us sy id   1m   5m   15m
   18.83   29  0.53   352.03    0  0.00  15 13 72  1.97 2.44 2.99
    4.00   14  0.05     0.00    0  0.00   6  9 85  1.97 2.44 2.99

# Without an external volume:
$ iostat -w1 -c 2
              disk0       cpu    load average
    KB/t  tps  MB/s  us sy id   1m   5m   15m
   18.83   29  0.53  15 13 72  2.54 2.53 3.01
    6.13   30  0.18  32 24 44  2.90 2.60 3.03

Cc @Lyriaaw

Potential fix: use echo $x | awk '{print $(NF-2)}'. This would take the 3rd to last column (ie 3rd starting from the rightmost column) instead of the 7th (starting from the left). Let me know if you can see any good reason not to do this, otherwise I'm happy to submit a PR!


Remove clearRows, clear, addRow,

These methods unnecessarily abstract table data. Table data is just an array of arrays. A single method along the lines of https://github.com/sorensen/ascii-table#instanceaddrowmatrixrows is sufficient to instantiate table data.
Having data in an array enables developer to append rows, remove selected rows, etc. using regular array functions.

@gajus so then are you suggesting that the table always use a reference to the input array?

I agree with other requests to reduce the API complexity, but this is another issue in itself.  What I prefer in building APIs or utilities is to never alter the user input. Because of this, the library can only hold a copy of the user input as to not alter it, and must have some methods of altering the internally stored data.
I would be in favor of simplifying this, but removing these methods does not solve anything. Marking this as closed as it will not be implemented, though it may be included in an API redesign.


Introduce new status standardized

This adds a new status standardized. Already released models can be transitioned into the standardized status. It is not possible to delete a standardized model.

question: Is it possible to move a model in status standardize to status deprecate?

question: Is it possible to move a model in status standardize to status deprecate?

Yes


Adding linux VM support for packer build task

Also tested that this task run properly on linux agent

@bishalpd,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


added riken to school list

Request to add RIKEN, one of the largest research institutes in Japan, to the school list

@Chibee First stage of verification passed, official domain is riken.jp as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Chibee Given that the address in the domain can be given to people who were enrolled or even were staff of the Institute a long ago, we cannot accept this domain to this repository.
Also, the Institute is a research facility, not a university. Thus, I have to reject the request.
Please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
I have to close the request without merging.
Thank you for the understanding!


Ansible role issue

HI I have created a ansible role and, copied the task and variabels , created a yaml file to execute the role but its giving me an error.
ERROR! failed to combine variables, expected dicts but got a 'dict' and a 'AnsibleSequence':
{}
[{"vars": {"nagios_password": "p@55w0rd", "nagios_group": "nagcmd", "nagiosadmin_password": "p@55w0rd", "nagios_user": "nagios"}}]

thanks ans solved the issue.


Issue #3: Impossible to set empty prefix.

Context
Please have a look at issue #3.
Proposed solution.
Solution proposed is to not automatically set prefix option when listing content. This option is only set when a prefix exists.

@jkuma I think this should be sent to https://github.com/thephpleague/flysystem as this is a subsplit of the main repo

Thanks @mmachatschek, issue & PR have been moved to https://github.com/thephpleague/flysystem.
=> https://github.com/thephpleague/flysystem/issues/1358


SHA1 still used

Not sure if it was left on purpose or by accident but while inspecting Release 2.6.2 I could find a place where SHA1 is still being used. Please have a look at Adyen_Payment_Model_Process::processCashResponse(), line 61 to be specific. Shouldn't this be changed as it was changed in e.g. Adyen_Payment_Model_Authenticate::_signAuthenticate() (line 80)?
Additionally I'd advocate having a helper method that computes the hash from the secret word and signing data instead of duplicating the code in arbitrary places as this would make future changes easier.

Hi @troggybrains,
Thanks for letting us know. This is legacy code the cash payment method is now using API integration so this is not needed anymore. I removed it from the code.
Regards,
Rik
Adyen


Visualizations: create legend title with overlay variable's name for all plots

Currently any viz using an overlay variable can end up with a mysterious "yes, no" legend, as below.
Even the more self-explanatory variables, such as country, should have a title above the legend.

An example with XYPlot component at web-component is now approved and merged. Thus, other plot components and corresponding vizs would be applied with the approach.

Hi @moontrip thank you for this.
I have moved your implementation into the new tidied/refactored PlotlyPlot so I will mark this issue as being solved by the refactoring PR.

Thanks Bob for your information 👍 I glanced at your commits regarding this but it seems like this part is not pushed to the PR yet: will take a look at it later.
I have also thought of the case to move this legend title part to Plotlyplot component. However, I was reluctant to do that because I did not want to send additional prop to Plotlyplot beyond key props like data, config, and layout. I thought it is better to handle such a prop (e.g., legendTitle prop) at each plot component level, not Plotlyplot. :)

Hi DK,
It's here in PlotlyPlot
https://github.com/VEuPathDB/web-components/blob/83784fa1cdf1aacc39d9a3b2385ee42dad43b2b1/src/plots/PlotlyPlot.tsx#L124
and used in a story here
https://github.com/VEuPathDB/web-components/blob/83784fa1cdf1aacc39d9a3b2385ee42dad43b2b1/src/stories/plots/XYPlot.stories.tsx#L38
I worked out (with some help from Dave) how to send non-Plotly props to
PlotlyPlot, so now all the general things like title,
displayLibraryControls, displayLegend, etc are all handled by
PlotlyPlot.
On Fri, Jun 18, 2021 at 3:41 PM DK @.***> wrote:

Thanks Bob for your information 👍 I glanced at your commits regarding
this but it seems like this part is not pushed to the PR yet: will take a
look at it later.
I have also thought of the case to move this legend title part to
Plotlyplot component. However, I was reluctant to do that because I did
not want to send additional prop to Plotlyplot beyond key props like data,
config, and layout. I thought it is better to handle such a prop (e.g.,
legendTitle prop) at each plot component level, not Plotlyplot. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/VEuPathDB/web-eda/issues/148#issuecomment-864088520,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLLH6DFC2QDNZOW56A65LTTNLLFANCNFSM46IAFRUQ
.

@bobular thank you for sharing the info 👍
Actually I am thinking of handling the date string for scatter plot viz for my next task (after refactoring boxplot viz), so some of your changes would be helpful - I was thinking that we might not need to use Date type though: perhaps string type is sufficient for plotly purpose but I will revisit it in the near future.
Just for a note, from my understanding and simple tests with plotly examples, setting type: date or linear (even with range) seems not to be a must-have: so perhaps no need to have corresponding props like independentValueType and dependentValueType. I think plotly automatically recognize the format if it is given as `'yyyy-mm-dd' string format - you can test this via https://plotly.com/javascript/time-series/ and play one of example having type: date/liner at CodePen (Try it at CodePen button)
In addition, it would be great if you can change the names, ScatterplotData and ScatterplotProps to XYPlotData and XYPlotProps for consistency - sorry that I missed the changes.

HI DK - I've already done a scatterplot story with dates and have adjusted
the props to use string instead of Date to be consistent with what we
decided for Histogram.
Plotly does detect dates but can't detect that "2001" as a string is a
date, so I added (in)dependentValueType props (similar to Histogram's
valueType, which I'll probably rename independentValueType).
Good idea - I will rename ScatterplotData and ScatterplotProps to XYPlotData
and XYPlotProps as suggested - I had been wondering about that.
On Fri, Jun 18, 2021 at 5:11 PM DK @.***> wrote:

@bobular https://github.com/bobular thank you for sharing the info 👍
Actually I am thinking of handling the date string for scatter plot viz
for my next task (after refactoring boxplot viz), so some of your changes
would be helpful - I was thinking that we might not need to use Date type
though: perhaps string type is sufficient for plotly purpose but I will
revisit it in the near future.
Just for a note, from my understanding and simple tests with plotly
examples, setting type: date or linear (even with range) seems not to be
a must-have: so perhaps no need to have corresponding props like
independentValueType and dependentValueType. I think plotly automatically
recognize the format if it is given as `'yyyy-mm-dd' string format - you
can test this via https://plotly.com/javascript/time-series/ and play one
of example having type: date/liner at CodePen (Try it at CodePen button)
In addition, it would be great if you can change the names,
ScatterplotData and ScatterplotProps to XYPlotData and XYPlotProps for
consistency - sorry that I missed the changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/VEuPathDB/web-eda/issues/148#issuecomment-864143209,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLLH6JBSQIV7W5KNAVET3TTNV43ANCNFSM46IAFRUQ
.


Update requirements to allow pyspark 3.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Apache Sedona is meant to support Spark 3.2 since Sedona 1.1.1. This PR updates the feedstock to allow Pyspark > 3.1 to be used.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

hi @dsangillo @mxr-conda sorry for the bump, can we merge this please?

@rluria14 @oblute @ndmaxar @JennaLipscomb @d-cunningham Hi, sorry for the ping again, just hoping to get this merged since it's blocking a project I'm working on.


Add metrics for initial peer network protocol versions

Motivation
As part of ticket #2797, we want to check the network protocol versions of the peers supplied by the Zcash DNS seeders.
Designs
Zebra already has this information, we just need to add it to the logs and metrics.
Solution
Seed Peer DNS Resolution:

log the initial peers resolved from each seed
add metrics for initial peer resolution, including the seed and remote peer IP
add a grafana dashboard for seed peer resolution
add a per-seed filter to the peer dashboard

Network Protocol Versions

add tracing and metrics for peer network protocol versions
add network protocol versions to  peers dashboard
show peer network protocol versions for each seeder in the peer dashboard

Review
Anyone can review this PR, but I think @conradoplg or @upbqdn have set up a Grafana instance already?
Merging this PR isn't urgent.
Reviewer Checklist

[ ] Code records metrics and logs correctly
[ ] Dashboards work

Follow Up Work

#2137

#2797

There doesn't seem to be any way to test a newly launched ZFND seeder from Zebra.
We'd need to specify its IP address, and the canonical ZFND seeder DNS name, like:
dig @<IP_ADDRESS> testnet.seeder.zfnd.org

Maybe we want to add dev.testnet.seeder.zfnd.org and dev.mainnet.seeder.zfnd.org DNS names, so we can test development versions of the seeders before deployment?

This is what the mainnet dashboards look like (for seed peers and all peers)

:

This is what the testnet dashboards look like

:

This is what the mainnet dashboards look like for me for the first four minutes of running Zebra:

Here are the first few minutes of running on Testnet:

Adding dev.testnet and dev.mainnet also seems to be a good idea.


[android] Fix signed apk anroid docs

The docs weren't in sync with the code. This is really just a small fix.

cc @martinbigio
I believe --bundle-output is the new version.

I closed this PR because I'm using 0.13.0 and it seems to be completely different on master anyways ;)
Though if anyone's using 0.13.0, the docs don't align :/

yes, the pr for the doc is correct. We're planning to update the docs next week. cc @frantic

@martinbigio wait, so the final version is --bundle-output or --out? If it's the latter I'm going to need to update the gradle integration.

master seems to go for --bundle-output https://github.com/facebook/react-native/blob/c1faabcdf6f4fd15643743d23ebda556c4f49045/private-cli/src/bundle/bundleCommandLineArgs.js#L32

@foghina it's --bundle-output, we're good. I didn't remember I have already updated that docs :)


Remove eslint plugin from dependencies

It appears that this may have accidentally been added as a dependency in ddc26f0e3428
Resolves gh-263

Thanks for the merge, @pmcnr-hx !


Use cosign V2 in Zarf

Details
We use zarf as a lib in our project and we also have an automatic dependency update system running daily on our side. The dependency update broke because Zarf relies on the<EMAIL_ADDRESS>which depends on<EMAIL_ADDRESS>The latest version for go-securesystemslib is v0.7.0. The latest version of github.com/sigstore/cosign that is v2.2.0, depend on the<EMAIL_ADDRESS>Expected result
I wat from Zarf to upgrade cosign from v1.13.1 to v.2.2.0.

Thanks for the issue - we are tracking this but haven't completed the migration (yet) - there are still some examples and docs that need to be updated (despite sget being deprecated for a few Zarf versions now).  I'll keep this issue open though as we work toward its full removal.


Remove mutex to resolve hang with logstream spawning a git pull

Resolves #516, #442, #518

The failed test is unrelated. Failed to pull an image from Docker Hub. Possibly related to an AWS outage reported today.

I see that pdugas has approved.  Merging.


request "Aborted" - timeout

I am using pjax for a while and did not have to many issues. But today we are trying to implement it for other links and it seems to be impossible somehow.
The application has the possibility to open a popup window (no modal) where users can find customer specific function (as in buttons / links / forms). Clicking a link (to eg tabular data view) should open the page in the application main browser window. We rewrote the working functions to following code to implement pjax
var target = $(window.opener.document).find('[data-pjax-container="true"]');
window.opener.$.pjax.click(e, {container:target});

The above is wrapped in .on('click') handler.
The page starts loading in the main browser but it immediatly recieves a timeout and the pjax fallback kicks in and does the full refresh. It can't be the timeout setting because it works when triggered from inside the main browser window.
(I asked a question on stackoverflow earlier which has a little more details:
http://stackoverflow.com/questions/32095230/pjax-click-from-in-a-pop-up-requests-timeout)
The request logs show 2 requests to the same page
bestellingen/toevoegen?tokenId=[sometoken]&_pjax=...    Aborted     0 B
bestellingen/toevoegen?tokenId=[sameAsAbove]            200 OK      62,1 KB

No idea why the first pjax request returns 0 bytes

Tricky. You seem to be doing things right, but then again the first pjax request gets immediately aborted for some reason. Unless your global timeout setting is really short (default is around 600ms), I don't think it's the timeout. Rather, is it possible that there is some other code in the main window that aborts ajax requests; e.g. cancels pjax:beforeSend event?
Please note that pjax wasn't designed for this kind of cross-frame scenario. Ultimately, I think it will be you who has the responsibility to debug this situation and make a call whether you want to insist on using pjax for this or just have the main window do a normal refresh as a workaround.

Thanks for the insights.. I'll have a look at the functions if somehow pjax:beforeSend gets cancelled.
It was just an attempt to only load a part of the page of the main window so all resources did not need to load again and we have this fancy 'loading indicator' during pjax events which we like too much.
I'll post my future findings here for others who would like to use this.


e2e.container.push.branch1.default.slsa3: Remote branch null not found in upstream origin

https://github.com/slsa-framework/example-package/actions/runs/5239090125
gh: API rate limit exceeded for installation ID 17536452. (HTTP 403)
gh: API rate limit exceeded for installation ID 17536452. (HTTP 403)
Cloning into 'example-package'...
fatal: Remote branch null not found in upstream origin
failed to run git: exit status [12](https://github.com/slsa-framework/example-package/actions/runs/5239090125/jobs/9458600349#step:3:13)8

This is due to rate limiting.
#214


Enable partition keys to be separate from payload keys

Currently, Phobos only uses message/payload keys. It automatically sets the partition key to be the same as the payload key.
There are use cases where these should be separate. For example, say there is a comment on a post. The Comments topic would want the comment ID to be the payload key (since it indicates that all updates to that individual comment should be compacted) while the partition key would likely be the post (so all actions related to the same post are put in the same partition).
This PR adds this functionality into Phobos.

I am still on vacation 🌴 but will have a look 👀 asap!
fre 10 aug. 2018 kl. 17:21 skrev Daniel Orner<EMAIL_ADDRESS>
@klippx https://github.com/klippx any update on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/klarna/phobos/pull/86#issuecomment-412115723, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACqATzWdpKUKuADgrTCABOjOuiRbcDlNks5uPaT0gaJpZM4VdIqF
.

I'm not sure whether this change is a good move, though the separation of key/partition_key might stem from ruby-kafka.
Reason:

if the kafka consumer needs to publish the message to another topic (ex: pipelining/splitting), how could the downstream consumer knows the partition_key (only the key/value is passed around, and partition_key is only used by ruby-kafka to compute the partition number)?

Therefore, the key used for kafka publishing has special meaning for partitioning.
For pure payload keys, better include it in the value field of the message, rather than the key field.

@ziru the main reason to separate them is because the key is used for more than partitioning. It's essentially a way to uniquely identify a record. E.g. when compacting records, the key is used to determine which records are the "same" and can be easily deleted.
The partition is different from this - it's used to group messages together that should be consumed together. E.g. you might want to process all posts related to the same user together, but you wouldn't want to blow away all posts whenever any post is updated.

@dorner Kafka log compaction only retains latest value per key per partition.   Thus, the separation might cause values for the same key not compacted across partitions, right?

@ziru you're correct - that would be up to the user to make sure that they pick the right partition key such that you should never have the same key associated with different partition keys. You can think of it as a key being a "unique ID" and a partition being a "group ID" - if a post always belongs to a user, you can safely partition by user because a post would never be in any partition for a different user.
Most of the time, using the key as the partition key is fine, which is why it's still the default.


getYForTooTip does not handle CENTER_VERTICAL gravity

I think the getYForTooTip method should look something like this:
private int getYForTooTip(int gravity, int toolTipMeasuredHeight, int targetViewY, float adjustment){
    int y;
    if ((gravity & Gravity.TOP) == Gravity.TOP) {

        if (((gravity & Gravity.LEFT) == Gravity.LEFT) || ((gravity & Gravity.RIGHT) == Gravity.RIGHT)) {
            y =  targetViewY - toolTipMeasuredHeight + (int)adjustment;
        } else {
            y =  targetViewY - toolTipMeasuredHeight - (int)adjustment;
        }
    } else if ((gravity & Gravity.BOTTOM) == Gravity.BOTTOM) {
        if (((gravity & Gravity.LEFT) == Gravity.LEFT) || ((gravity & Gravity.RIGHT) == Gravity.RIGHT)) {
            y =  targetViewY + mHighlightedView.getHeight() - (int) adjustment;
        } else {
            y =  targetViewY + mHighlightedView.getHeight() + (int) adjustment;
        }
    } else { // this is center
        if (((gravity & Gravity.LEFT) == Gravity.LEFT) || ((gravity & Gravity.RIGHT) == Gravity.RIGHT)) {
            y =  targetViewY + mHighlightedView.getHeight() / 2 - (int) adjustment;
        } else {
            y =  targetViewY + mHighlightedView.getHeight() / 2 + (int) adjustment;
        }
    }
    return y;
}

Hi @peterosterlund2
Your code actually looks good, that should fix Gravity.BOTTOM, can you make a pull request?
I will then test and merge it.


Long running queries make migrations likely to deadlock, due to inhview recreation

In three different clients:

select (count(X), sys::_sleep(3));
alter type X { create property foo -> str; };
select X;

The migration will fail with a deadlock.
The problem is that the DDL recreates the inhview for X, which requires an exclusive lock on the view.
The most obvious fix here is to not use inhviews. This would be nice, because then nobody would ever have to think about inhviews again. The downside is it will make the compiler slower and the SQL output harder to read.
Setting EDGEDB_DEBUG_EDGEQL_EXPAND_INHVIEWS=1 does fix this
A band-aid fix that could avoid a lot of view related deadlocks is to adjust the DDL we generate to make some change to the inhview before changing the real table. This helps because most queries access the inhview before accessing the real table (since the inhview is how they get to the table).

import asyncio

import edb.testbase.connection as edgedb

conn_args = dict(port=5656, database='edgedb', tls_security='insecure')

DROP = '''
    alter type X drop property foo;
'''
CREATE = '''
    alter type X create property foo -> str;
'''

async def run():
    cons = []
    for _ in range(3):
        con = await edgedb.async_connect_test_client(**conn_args)
        await con.query('select 1')
        cons.append(con)

    con1, con2, con3 = cons

    cleanup, ddl = DROP, CREATE
    # cleanup, ddl = CREATE, DROP

    try:
        await con1.query(cleanup)
    except Exception:
        print("couldn't cleanup; np")

    long_call = asyncio.create_task(con1.query('''
        select (count(X), sys::_sleep(3));
    '''))
    await asyncio.sleep(1)
    ddl = asyncio.create_task(con2.query(ddl))
    short_call = con3.query('''
        select X
    ''')

    res = await asyncio.gather(long_call, ddl, short_call)
    print(res)

asyncio.run(run())

is a script I used to reproduce the bug easily


fixes #108 add clear button in search box

add 'clearable' v-combobox prop
enhance search box visibility toggle to really hide/show searchbox with CSS display style

Closes #108


UXPin

Please add UXPin Systems https://www.uxpin.com

This seems more of a platform/tool to help build a design system, as opposed to being an actual design system.


Exact name match returns two identical results

Fed Version: 0.6.0
What were you trying to do?
Conduct an exact match name search for either FedACH or Fedwire.
What did you expect to see?
One result for each participant that matches.
What did you see?
Duplicated results for each participant that matches.
How can we reproduce the problem?
Use the following FedACH data file:
{
    "fedACHParticipants" : {
      "response" : {
        "code" : 100
      },
      "fedACHParticipants" : [
        {
          "routingNumber": "073905527",
          "officeCode": "O",
          "servicingFRBNumber": "071000301",
          "recordTypeCode": "1",
          "changeDate": "012908",
          "newRoutingNumber": "000000000",
          "customerName": "LINCOLN SAVINGS BANK",
          "customerAddress": "P O BOX E",
          "customerCity": "REINBECK",
          "customerState": "IA",
          "customerZip": "50669",
          "customerZipExt": "0159",
          "customerAreaCode" : "319",
          "customerPhonePrefix" : "788",
          "customerPhoneSuffix" : "6441",
          "institutionStatusCode": "1",
          "dataViewCode": "1"
        }
      ]
    }
  }

Run curl "localhost:8086/fed/ach/search?name=LINCOLN+SAVINGS+BANK", output below:
{"achParticipants":[{"routingNumber":"073905527","officeCode":"O","servicingFRBNumber":"071000301","recordTypeCode":"1","revised":"012908","newRoutingNumber":"000000000","customerName":"LINCOLN SAVINGS BANK","achLocation":{"address":"P O BOX E","city":"REINBECK","state":"IA","postalCode":"50669","postalCodeExtension":"0159"},"phoneNumber":"3197886441","statusCode":"1","viewCode":"1"},{"routingNumber":"073905527","officeCode":"O","servicingFRBNumber":"071000301","recordTypeCode":"1","revised":"012908","newRoutingNumber":"000000000","customerName":"LINCOLN SAVINGS BANK","achLocation":{"address":"P O BOX E","city":"REINBECK","state":"IA","postalCode":"50669","postalCodeExtension":"0159"},"phoneNumber":"3197886441","statusCode":"1","viewCode":"1"}],"wireParticipants":null}

Notice that a partial match does not return duplicate results:
Run curl "localhost:8086/fed/ach/search?name=LINCOLN", output below:
{"achParticipants":[{"routingNumber":"073905527","officeCode":"O","servicingFRBNumber":"071000301","recordTypeCode":"1","revised":"012908","newRoutingNumber":"000000000","customerName":"LINCOLN SAVINGS BANK","achLocation":{"address":"P O BOX E","city":"REINBECK","state":"IA","postalCode":"50669","postalCodeExtension":"0159"},"phoneNumber":"3197886441","statusCode":"1","viewCode":"1"}],"wireParticipants":null}

What file did you use when searching? Did you download one?

@adamdecaf I used https://github.com/moov-io/fed/blob/master/data/fedachdir.json

I've fixed these issues and improved the search in https://github.com/moov-io/fed/pull/129. Results are now ordered by their match percentages and duplication removed.


Move Providers to their own Repositories

Eventbrite

[x] Find a maintainer
[x] Link in the README
[x] Remove from league/oauth2-client

Facebook

[x] Make a new GitHub repo
[x] Link in the README
[x] Remove from league/oauth2-client
[x] Document any custom params

Github

[ ] Make a new GitHub repo
[ ] Link in the README
[ ] Remove from league/oauth2-client
[ ] Document any custom params

Google

[x] Make a new GitHub repo
[x] Link in the README
[x] Remove from league/oauth2-client
[x] Document any custom params

Instagram

[x] Make a new GitHub repo
[x] Link in the README
[x] Remove from league/oauth2-client
[x] Document any custom params

LinkedIn

[x] Make a new GitHub repo
[x] Link in the README
[x] Remove from league/oauth2-client
[x] Document any custom params

Microsoft

[x] Find a maintainer
[x] Link in the README
[x] Remove from league/oauth2-client

Vkontakte

[x] Find a maintainer
[x] Remove from league/oauth2-client
[x] Link in the README

You might notice Eventbrite, Microsoft and Vkontakte have been bumped off to their own repos. That's just some advice, but maybe @ramsey you want them to stick around and be official.

If #214 gets approved, this we might want to add, "Create a custom certificate bundle for peer verification," to all the providers in this list. :)

Forgot Vkontakte is already done: https://packagist.org/packages/j4k/oauth2-vkontakte

Boom! Facebook Provider ready. Not sure how you want to transition removing it from this repo.

@SammyK nice! Just whip it out of the 1.0 branch and link it in the README.

I whipped it out...

I volunteer for Google, but would want it to be under the League's account.

If #242 is merged, we can cross Eventbrite off this punch list.

If #243  is merged, we can cross Microsoft off this punch list.

@shadowhand I've made https://github.com/thephpleague/oauth2-google and you've got admin access for that along with @ramsey of course.
Consider yourself the maintainer for Google.
If you want to take up any others then let me know!

@philsturgeon :joy_cat:

@shadowhand would you take Github, Instagram and LinkedIn? I know LI isn't the most exciting thing in the world but it would be great to get these last ones moved out.
I'll make any repos for providers you claim.

I am happy to help.

Lay claim!

I will take LinkedIn, since it isn't as exciting. If @shadowhand does not take the others, I don't mind. These projects are not highly complicated to maintain.
Will LinkedIn need a League repo? If so, please set it up and let me know. I will happily take care of this.

@stevenmaguire here you go! https://github.com/thephpleague/oauth2-linkedin

keep the others as third party, but linked in can be an official one.

Sweet. I am on it.

LinkedIn custom params documentation should be taken care of now.
https://github.com/thephpleague/oauth2-linkedin
I only focused on the scopes param, as they are definitely a corner case for typical usage. The fields param is accessible, but appears to only support hydrating the generic user object, so encouraging usage that is different from the default may not be needed in the documentation right now.

@stevenmaguire thanks for taking Instagram and LinkedIn... I wasn't keen on taking ownership of providers that I don't actively use.

I haven't taken Instagram; only LinkedIn. I accept your nomination however, intentional or not ;)
@philsturgeon could you create a repo for Instagram and set me up as an admin? I will maintain that package as well.

@stevenmaguire oops, I thought I could create it for you, but I don't have permissions to set up the team properly. https://github.com/thephpleague/oauth2-instagram @philsturgeon can you fix the permissions please?

@stevenmaguire you have access now.

@shadowhand @stevenmaguire could you two look into updating the oauth2-client documentation to match what Omnipay has done?
http://omnipay.thephpleague.com/gateways/official/
http://omnipay.thephpleague.com/gateways/third-party/
http://omnipay.thephpleague.com/gateways/build-your-own/

I still only have read access to https://github.com/thephpleague/oauth2-instagram

@philsturgeon can you update the task description so that we know where we're at?

@philsturgeon where would I update the documentation for oauth2-client? I did a quick search and couldn't find any matching repos...

@shadowhand PR #248 includes some updates to the documentation that includes the tabular format for official and third party providers. This PR will merge into the 1.0 branch. It was discovered that the oauth2-client does not have a website on the League website. There is now an issue for that.

@shadowhand I don't know what you lot have done so let me or @ramsey know what to update.
Documentation will go in a gh-pages branch when @ramsey gets around to it, as part of 1.0.

@philsturgeon
LinkedIn -> Document any custom params is complete.
Instagram -> Code is ready to commit to new repo then Remove from league/oauth2-client can be done. I need admin/write access to repo.

@stevenmaguire can you PR instagram removal from oauth2-client?

@philsturgeon I sure can. I'd like to be sure that the code exists in its new home also.

#251 is in!

@philsturgeon could you please promote me to an admin for the oauth2-instagram repository? I have code for that project; it's currently empty!

Done!

Moved!

Would you like me to take care of Github to close out the punch list?

@stevenmaguire That would be great!

It appears to be a League sanctioned repo. Can you create the repo and set me up with permissions?

@stevenmaguire I think @philsturgeon will need to create the repo.

Done! https://github.com/thephpleague/oauth2-github

PR is in for Github #261

There are no longer any third-party providers in the 1.0 branch. Woooo!


Request to make hide from icon tray

I like to keep my icon tray empty as I have a minimalistic setup.
Thanks in advance.

@GheorgheGeorgescu  Do you want to hide the PowerToys icon or do you want a feature which can hide other icons?
Please explain your request better to me.

Tracked in #9526


Update client3:async-http-client-backend-zio, ... to 3.5.0

Updates

com.softwaremill.sttp.client3:async-http-client-backend-zio
com.softwaremill.sttp.client3:circe
com.softwaremill.sttp.client3:core
com.softwaremill.sttp.client3:httpclient-backend-zio
com.softwaremill.sttp.client3:slf4j-backend
com.softwaremill.sttp.client3:zio

from 3.3.18 to 3.5.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #326.


[YUNIKORN-1988] Check additional victims and the satisfaction of guaranteed resource at a parent queue level

…n of guaranteed resource at a parent queue level
What is this PR for?
We noticed Preemption happened when a queue lower than its guaranteed capacity, caused issue in production.
This pr including changes:

The calculation for extraVictims and appending it to victims is now within a condition that checks if needsAdditionalVictims is true. extraVictims are only calculated and appended when there's a need for additional victims based on the tryNodes function result.
p.calculateAdditionalVictims(victims, nodeID) now takes in nodeID as a parameter, showing that this function may now consider the nodeID in its calculation for extra victims.

What type of PR is it?

[x] - Bug Fix
[ ] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1988
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Closing this pr, I will create a new one soon.


Nightly not updated for ~2 weeks

We're waiting for a wabt.js update to resolve https://github.com/GoogleChromeLabs/wasm-feature-detect/issues/22.
Upstream WABT has already updated to include SIMD renumbering, but it appears that wabt.js buildbot has not published any new nightlies since (for 2 weeks now).
Not sure if related, but latest CI run appears to have had errors as well: https://travis-ci.org/github/AssemblyScript/wabt.js

There are new latest and nightly releases now. Was a problem with the fixtures used for testing that needed to be updated.

Thanks!


update to 14.0.6

The Windows build seems to fail 6by missing installation of AtlBase in VS2019 context.  At least it looks that way by reading threads on llvm on Windows with same error. The DIA-sdk is found.
I will ask DK on the installation settings of VS2019.  Not sure, but maybe VS2017 would be worth a try instead. It could just be that other components in llvm might be no longer compatible to it. And it is not clear if ATL-Base is installed at all for it

I could built it successful on Windows using concourse, so it is a prefect-builder issue on Windows.  See https://concourse.build.corp.continuum.io/teams/main/pipelines/ktietz_t1

Due to the way LLVM implements support for DIA SDK, the win-64 llvmdev package here still contains a hard-coded, machine-specific path to the SDK, and this will cause llvmlite to fail to build with this package on Prefect, because DIA is located in a different subdir.  INTERFACE_LINK_LIBRARIES ideally should not contain this sort of path (see the generated LLVMExports.cmake). The patch I'm testing (for 11.1) should fix this here as well.

thank you all for your suggestion.  I address them all


Wails crash and display problems

While experimenting with AlbyHub on a few different platforms, I encountered some issues which are apparently known Wails problems.

On Ubuntu-22.04, albyhub crashes on startup unless you first do "sudo apt-get install libwebkit2gtk-4.0-37"

With graphics acceleration, doing that install allows albyhub to run, but it presents only a blank white screen. This can be fixed by preceding the albyhub launch with the command "export WEBKIT_DISABLE_DMABUF_RENDERER=1"

@hans-schmidt I have not seen these particular issues reported so far, especially I would have expected Ubuntu to have the least problems. But maybe we could add a troubleshooting section to the Linux section at  https://guides.getalby.com/user-guide/alby-account-and-browser-extension/alby-hub/alby-hub-flavors/desktop CC @jpl-btc
Also, if users do have issues I think we should recommend them to run the server version. It has no GUI so is much less likely to have issues.

Added to our guides 👍


update langchain version to fix ImportError issue (https://github.com…

With version 0.1.0 of LangChain I am getting
cannot import name '_is_openai_v1' from 'langchain_community.embeddings.openai' (~/.pyenv/versions/3.11.0/lib/python3.11/site-packages/langchain_community/embeddings/openai.py)
It is a outstanding issue with LangChain as per this
Fix
Update LangChain to 0.1.0

Please merge this


add label flag for build

Signed-off-by: ye.sijun<EMAIL_ADDRESS>

Can we support labels in compose up --build too ?

Yes, I will support it in the next PR.


Another NoClassDefFoundError

Sorry.  I know that other tickets exist for this issue, and I promise I read them all. :)

[12:20:35 ERROR]: Error occurred while enabling ChestShopStats v1.0 (Is it up to
 date?)
java.lang.NoClassDefFoundError: com/zaxxer/hikari/HikariConfig
...

I'm using eclipse, and I'm not using mvn, and I'm on Windows 8.1 x64.
I am using the latest HikariCP-2.4.4-SNAPSHOT.jar from the dev branch, compiled with mvn.
My Java Version is jre1.8.0_51.
I compiled HikariCP using Apache Maven 3.3.3.
I'm linking in the HikariCP jar by adding it as a Library in the Project Properties build path via "Add External JARs...".
Eclipse sees the library, and the class names resolve in the code, but at runtime, I get the NoClassDefFoundError for HikariConfig.
Any ideas?  Any additional information I can give you?
Thanks again.

@morfie78 Are you running the application under Eclipse?  If you you need to add the library to the launch configuration's "Classpath" tab.

No. I'm not running it in Eclipse.  I'm running it in a Spigot server. https://www.spigotmc.org/


Buttons with Insufficiently Descriptive Accessible Names

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.92.2
OS Version: 14.6.1 (23G93)

Description: Certain buttons, such as the "More actions" gear icon, have insufficiently descriptive accessible names, making it difficult for screen reader users to understand their purpose.
Steps to Reproduce:

Navigate to the "More actions" button (gear icon) in VSCode.
Use a screen reader to interact with the button and notice that the accessible name is not descriptive enough.

User Impact: Screen reader users are unable to determine the purpose of these buttons due to the lack of descriptive accessible names.
Expected Behavior: Buttons should have clear and descriptive accessible names, using internal text, aria-label, or aria-labelledby. For example, the "More actions" button could be labeled as "More Actions for Inline Code Suggestions (Shift+F9)."
Actual Behavior: The button has a generic name that does not provide enough context, limiting its accessibility.
Recommendation: Ensure all buttons have descriptive and concise accessible names that provide clear context. Avoid including the word "button" in the name, as the role is already indicated by the button element.

I'm on the fence here, as the user knows the context in which their button exists since they've navigated to that area. Thoughts @isidorn ?

Agreed with you @meganrogge, I would expect the user to know the context.
Having longer names will make the experience more verbose (which users always dislike).
I suggest to keep this open as a feature request to gather more user feedback.


[BUG] Frequent console errors whenever I click anywhere in the editor

Description

Whenever I clicked anywhere in the note editor or use up/down arrows, I observe the following error messages in the console:
Uncaught RangeError: A selection needs at least one range
    at e.create (app.js:1:323375)
    at TabstopGroup.toEditorSelection (plugin:obsidian-latex-suite:7371:42)
    at isInsideATabstop (plugin:obsidian-latex-suite:7504:77)
    at handleUpdate (plugin:obsidian-latex-suite:8914:12)
    at e.update (app.js:1:487705)
    at e._dispatch (app.js:1:483944)
    at e.dispatch (app.js:1:485722)
    at app.js:1:1437617

Also, the cursor jumps up and down, making it not possible to navigate correctly in the note editor.
To Reproduce

Click anywhere in the editor or use up/down arrows.
Expected Behavior

No errors in the console, and one can navigate normally in the note editor.
Platform

macOS 13.6; Obsidian 1.4.14; LaTeX Suite 1.8.3

I cannot reproduce this. Does the issue occur in all notes? Does it only occur after you trigger a certain snippet?

Does the issue occur in all notes? Does it only occur after you trigger a certain snippet?

It is strange that I do not see this issue now. But I will report back if it happens again. Thanks!


don't inject -std=c++11 into EXTRA_ENV_COMPILE_ARGS

These get added to CFLAGS, which are used when compiling C source
code. The gcc compiler accepts and ignores this, while clang
fails because c++11 is not a valid standard for compiling C source.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @lifanov isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

Can you provide some context on how you are encountering a problem with the current setup.py? I'm aware of potential problems on macos where the default compiler is clang, but we already special-case that to explicitly call out to make in a subprocess instead, ignoring this variable from setup.py entirely.

I'm encountering a problem on FreeBSD when installing it with pip.
This can be worked around by using gcc.
However, when installing dependencies for a larger project that includes a module that uses c++ (e.g. pandas), there is a conflict between libc++ and libstdc++, so it would be useful to not have to use gcc to build this.

Could you help me understand why c++ std flag is needed since the extension uses only C source? For "linux" sys.platform, compiler gets both -std=c++11 and -std=gnu99, which should be invalid.

Give me a bit of time. I know why Linux build is broken, but I want to test if there is a better fix.

@lifanov Thanks for working on this. I previously spent (too much) time on a related task: getting rid of our workaround for clang on mac by patching distutil's compile to similarly check if the file is C or C++. I abandoned this for a few reasons, both that it was unknown this was causing problems for other non-macosx systems and that we are already monkey-patching compile to allow builds to run in parallel: https://github.com/grpc/grpc/blob/master/src/python/grpcio/_parallel_compile_patch.py
But the approach you're taking here (wrapping self._compiler.compile on the instance, which I think can be consider distinct from another layer of monkey-patching) seems more promising.

Thanks! Let's see if the tests pass.

Could you help me understand one of the failures please?
Link: https://source.cloud.google.com/results/invocations/e2579ea9-d048-4e99-af90-9767f90cb3b6/targets/grpc%2Fcore%2Fpull_request%2Fmacos%2Fgrpc_basictests_opt/log
From this log, it looks like the linker can't find the static grpc libs, but if I look at this block, it's not supposed to use prebuilt versions: https://github.com/lifanov/grpc/blob/1d9a18407a539f02a45400b4a0b9cb839f69fc1f/setup.py#L268-L272

The last commit should fix "Artifact Build MacOS (internal CI)" test failure.
The test targets OS X 10.7 where clang isn't built to target libc++ by default.
I verified that there was no regression with the aded flag on macOS 10.11.

The "Basic Tests Windows [opt] (internal CI)" is flaky. I'm not sure what's happening there.

@lifanov Thank you again for contributing this part. This issue has been troubling us for 2 years, what you did significantly simplified our build tools in macOS.


vendetta manager says "Loading..." on install button

Is this still relevant with Manager 1.1.11?

Is this still relevant with Manager 1.1.11?

Unfortunately, it is.


Link to supported countries

Can we please include a link to supported countries in the document - "Modular applications will be provisioned only in supported countries or regions."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43e145b6-a02f-49e3-3fc0-7d80a0e85303
Version Independent ID: e4652c2f-8125-d6a2-f288-f172c7e629f6
Content: Provisioning for the Dynamics 365 for Talent modular apps - Talent | Dynamics 365
Content Source: articles/talent/modular-app-tech-faq.md
Service: dynamics-ax-applications
GitHub Login: @andreabichsel
Microsoft Alias: anbichse

@karleesm, thanks for providing this feedback!
@andreabichsel, can you please review and update the topic as needed.

Thank you @karleesm, I added the link!


Set "binary" as default kind

It's really not a problem. But, I would be happy if binary is set as default kind. When I start a project, I need to specify kind as
target("executable")
    set_kind("binary")

If set_kind is not set, it's default to static I think.
Describe the solution you'd like
I just want Xmake to set "binary" as default kind. To tried to look up the source code and try to modify. But since I don't much familiar with Lua and project structure, I failed.
Please help me with this, or please tell me how to. So that, I can fork and build for myself.
Thanks. But sorry for bad English.

I have supported it on dev.


Use Relavant Path for Files Location

As per #6, config file is now use relevant path.
But extra components (ffmpeg, gifski) & project folder are still absolute path.
Is there any specific reason for this?

You can use relative paths with those settings. Just type a period (.) and the fields will be treated as relative.

Related #295 and #6

Sorry for my delay on this:
Yes, you can change the path by adding a period after downloaded. But I mean it shall be displayed as set as relative expression by default.

It would be nice once you choose to install ffmpeg and Gifsi that it will re-route to the relative path.
And the settings file appears to be absolute also out of the box.

@Riajyuu Maybe if the user saves Gifski/FFmpeg in a path that is inside the same path as the App, the path could be set as relative by default. If the user saves it to elsewhere, it will be displayed the full path.

@stephen147 Yes, the settings file is absolute when inside the AppData, but it is relative when inside the local folder.


Hotstar URL redirection

[x] I've verified and I assure that I'm running youtube-dl 2018.09.18

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
python -m youtube_dl -f best -v https://www.hotstar.com/tv/kasthooriman/s-1347/kavya-reconciles-with-jeeva/1100009804 --no-geo-bypass
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', 'best', '-v', 'https://www.hotstar.com/tv/kasthooriman/s-1347/kavya-reconciles-with-jeeva/1100009804', '--no-geo-bypass']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2018.09.18
[debug] Git HEAD: 4ac73fc17
[debug] Python version 3.7.0 (CPython) - Windows-10-10.0.17134-SP0
[debug] exe versions: ffmpeg N-91930-g0caa33c60b, ffprobe N-91930-g0caa33c60b
[debug] Proxy map: {}
[HotStar]<PHONE_NUMBER>: Downloading JSON metadata
[HotStar]<PHONE_NUMBER>: Downloading JIO JSON metadata
[HotStar]<PHONE_NUMBER>: Downloading m3u8 information
[debug] Invoking downloader on 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8.m3u8'
[download] Destination: Update your app-1100009804.mp4
[debug] ffmpeg command line: ffmpeg -y -loglevel verbose -headers "User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Encoding: gzip, deflate
Accept-Language: en-us,en;q=0.5
" -i "https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8.m3u8" -c copy -f mp4 "-bsf:a" aac_adtstoasc "file:Update your app-1100009804.mp4.part"
ffmpeg version N-91930-g0caa33c60b Copyright (c) 2000-2018 the FFmpeg developers
  built with gcc 8.2.1 (GCC) 20180813
  configuration: --enable-gpl --enable-version3 --enable-sdl2 --enable-fontconfig --enable-gnutls --enable-iconv --enable-libass --enable-libbluray --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libopus --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libtheora --enable-libtwolame --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libzimg --enable-lzma --enable-zlib --enable-gmp --enable-libvidstab --enable-libvorbis --enable-libvo-amrwbenc --enable-libmysofa --enable-libspeex --enable-libxvid --enable-libaom --enable-libmfx --enable-amf --enable-ffnvcodec --enable-cuvid --enable-d3d11va --enable-nvenc --enable-nvdec --enable-dxva2 --enable-avisynth
  libavutil      56. 19.101 / 56. 19.101
  libavcodec     58. 30.100 / 58. 30.100
  libavformat    58. 18.100 / 58. 18.100
  libavdevice    58.  4.103 / 58.  4.103
  libavfilter     7. 29.100 /  7. 29.100
  libswscale      5.  2.100 /  5.  2.100
  libswresample   3.  2.100 /  3.  2.100
  libpostproc    55.  2.100 / 55.  2.100
[tcp @ 000001f71718df00] Starting connection attempt to <IP_ADDRESS> port 443
[tcp @ 000001f71718df00] Successfully connected to <IP_ADDRESS> port 443
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00001.ts', offset 0, playlist 0
[hls,applehttp @ 000001f71718ab40] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00001.ts' for reading
[tcp @ 000001f717699140] Starting connection attempt to <IP_ADDRESS> port 443
[tcp @ 000001f717699140] Successfully connected to <IP_ADDRESS> port 443
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00002.ts', offset 0, playlist 0
[hls,applehttp @ 000001f71718ab40] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00002.ts' for reading
[tcp @ 000001f7176eb400] Starting connection attempt to <IP_ADDRESS> port 443
[tcp @ 000001f7176eb400] Successfully connected to <IP_ADDRESS> port 443
[h264 @ 000001f7177987c0] Reinit context to 1920x1088, pix_fmt: yuv420p
Input #0, hls,applehttp, from 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8.m3u8':
  Duration: 00:00:59.96, start: 2.160222, bitrate: 0 kb/s
  Program 0
    Metadata:
      variant_bitrate : 0
    Stream #0:0: Video: h264 (Main), 1 reference frame ([27][0][0][0] / 0x001B), yuv420p(left), 1920x1080 (1920x1088) [SAR 1:1 DAR 16:9], 25 fps, 25 tbr, 90k tbn, 50 tbc
    Metadata:
      variant_bitrate : 0
    Stream #0:1: Audio: aac (LC) ([15][0][0][0] / 0x000F), 48000 Hz, stereo, fltp
    Metadata:
      variant_bitrate : 0
Output #0, mp4, to 'file:Update your app-1100009804.mp4.part':
  Metadata:
    encoder         : Lavf58.18.100
    Stream #0:0: Video: h264 (Main), 1 reference frame (avc1 / 0x31637661), yuv420p(left), 1920x1080 (0x0) [SAR 1:1 DAR 16:9], q=2-31, 25 fps, 25 tbr, 90k tbn, 90k tbc
    Metadata:
      variant_bitrate : 0
    Stream #0:1: Audio: aac (LC) (mp4a / 0x6134706D), 48000 Hz, stereo, fltp
    Metadata:
      variant_bitrate : 0
Stream mapping:
  Stream #0:0 -> #0:0 (copy)
  Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00003.ts', offset 0, playlist 0
[https @ 000001f717697840] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00003.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00004.ts', offset 0, playlist 0
[https @ 000001f717790f00] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00004.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00005.ts', offset 0, playlist 0
[https @ 000001f717697840] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00005.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00006.ts', offset 0, playlist 0
[https @ 000001f717790f00] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00006.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00007.ts', offset 0, playlist 0
[https @ 000001f717697840] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00007.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00008.ts', offset 0, playlist 0
[https @ 000001f717790f00] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00008.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00009.ts', offset 0, playlist 0
[https @ 000001f717697840] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00009.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00010.ts', offset 0, playlist 0
[https @ 000001f717790f00] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00010.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00011.ts', offset 0, playlist 0
[https @ 000001f717697840] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00011.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00012.ts', offset 0, playlist 0
[https @ 000001f717790f00] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00012.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00013.ts', offset 0, playlist 0
[https @ 000001f717697840] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00013.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00014.ts', offset 0, playlist 0
[https @ 000001f717790f00] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00014.ts' for reading
[hls,applehttp @ 000001f71718ab40] HLS request for url 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00015.ts', offset 0, playlist 0
[https @ 000001f717697840] Opening 'https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8_00015.ts' for reading
No more output streams to write to, finishing.e=00:00:58.63 bitrate=4363.6kbits/s speed=12.3x
frame= 1499 fps=303 q=-1.0 Lsize=   33311kB time=00:00:59.95 bitrate=4551.6kbits/s speed=12.1x
video:32827kB audio:450kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.103386%
Input file #0 (https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8.m3u8):
  Input stream #0:0 (video): 1499 packets read (33614765 bytes);
  Input stream #0:1 (audio): 2810 packets read (480056 bytes);
  Total: 4309 packets (34094821 bytes) demuxed
Output file #0 (file:Update your app-1100009804.mp4.part):
  Output stream #0:0 (video): 1499 packets muxed (33614765 bytes);
  Output stream #0:1 (audio): 2810 packets muxed (460386 bytes);
  Total: 4309 packets (34075151 bytes) muxed
[AVIOContext @ 000001f717646d00] Statistics: 2 seeks, 133 writeouts
[AVIOContext @ 000001f717738d40] Statistics: 18653360 bytes read, 0 seeks
[AVIOContext @ 000001f7178715c0] Statistics: 16442480 bytes read, 0 seeks
[AVIOContext @ 000001f717256540] Statistics: 683 bytes read, 0 seeks
[ffmpeg] Downloaded 34110380 bytes
[download] 100% of 32.53MiB in 00:06

Description of your issue, suggested solution and other information
Any video trying to download via hotstar.com, seems to be redirecting to a particular URL, which results in downloading an "Update your app.mp4" file. The videos are playable via browser.
The sample video url: https://www.hotstar.com/tv/kasthooriman/s-1347/kavya-reconciles-with-jeeva/1100009804
For the above video, instead of picking up this m3u8 (https://hsdesinova.akamaized.net/video/asianet_hd/kasthooriman/240/master_Layer5_.m3u8), it is picking up (https://hssportsprepack.akamaized.net/videos/cricket/asiacup2018/18_09_2018/2001618252/master_Layer8.m3u8)

I can repro this. It's downloading an "update your app" video instead of the requested video.

problem seems to persist.

@jakop345 Nope. Working fine now, mate.
@remitamine Thanks 👍

The below command is still downloading "Update your app-1100009842.mp4"
youtube-dl -f 'bestvideo[height<=480]+bestaudio/best[height<=480]'
https://www.hotstar.com/tv/neeya-naana/s-80/all-for-the-new-beginnings/1100009842
Regards,
Krishna Sundar
-- Sent from OnePlus 5
On Wed 26 Sep, 2018, 22:02 theincognito-inc<EMAIL_ADDRESS>wrote:

@jakop345 https://github.com/jakop345 Nope. Working fine now, mate.
@remitamine https://github.com/remitamine Thanks 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rg3/youtube-dl/issues/17637#issuecomment-424782760,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUCSBXnYry3KCesXtOzpfiPY9WAbixOks5ue6v_gaJpZM4W1k1v
.


Remove actionmailer version

because refinerycms-core already set which rails version we want to use.
This will fix #39

Hi @parndt, it looks like  TravisCI is not active on this repo and i don't have the rights on it. Could you fix the problem?

I've asked it to activate and build


ytt silently skips yaml merge key

What steps did you take:
merge key is described here, however ytt silently ignores those special syntax.
What happened:
I have a yaml like belowfoo.yaml:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: clustertasks.tekton.dev
  labels:
    app.kubernetes.io/instance: default
    app.kubernetes.io/part-of: tekton-pipelines
    pipeline.tekton.dev/release: "v0.22.0"
    version: "v0.22.0"
spec:
  group: tekton.dev
  preserveUnknownFields: false
  versions:
    - &version
      name: v1alpha1
      served: true
      storage: false
      schema:
        openAPIV3Schema:
          type: object
          x-kubernetes-preserve-unknown-fields: true
      subresources:
        status: {}
    - !!merge <<: *version
      name: v1beta1
      storage: true
  names:
    kind: ClusterTask
    plural: clustertasks
    categories:
      - tekton
      - tekton-pipelines
  scope: Cluster
  conversion:
    strategy: Webhook
    webhook:
      conversionReviewVersions: ["v1beta1"]
      clientConfig:
        service:
          name: tekton-pipelines-webhook
          namespace: tekton-pipelines

You can see &version and !!merge <<: *version. Then I run ytt -f foo.yaml, and no error reported, but the result YAML is incorrect:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: clustertasks.tekton.dev
  labels:
    app.kubernetes.io/instance: default
    app.kubernetes.io/part-of: tekton-pipelines
    pipeline.tekton.dev/release: v0.22.0
    version: v0.22.0
spec:
  group: tekton.dev
  preserveUnknownFields: false
  versions:
  - name: v1alpha1
    served: true
    storage: false
    schema:
      openAPIV3Schema:
        type: object
        x-kubernetes-preserve-unknown-fields: true
    subresources:
      status: {}
  - name: v1beta1
    storage: true
  names:
    kind: ClusterTask
    plural: clustertasks
    categories:
    - tekton
    - tekton-pipelines
  scope: Cluster
  conversion:
    strategy: Webhook
    webhook:
      conversionReviewVersions:
      - v1beta1
      clientConfig:
        service:
          name: tekton-pipelines-webhook
          namespace: tekton-pipelines

What did you expect:
I'd expect those merge key tags are preserved or expanded like below:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: clustertasks.tekton.dev
  labels:
    app.kubernetes.io/instance: default
    app.kubernetes.io/part-of: tekton-pipelines
    pipeline.tekton.dev/release: v0.22.0
    version: v0.22.0
spec:
  group: tekton.dev
  preserveUnknownFields: false
  versions:
  - name: v1alpha1
    served: true
    storage: false
    schema:
      openAPIV3Schema:
        type: object
        x-kubernetes-preserve-unknown-fields: true
    subresources:
      status: {}
  - name: v1beta1
    served: true
    storage: true
    schema:
      openAPIV3Schema:
        type: object
        x-kubernetes-preserve-unknown-fields: true
    subresources:
      status: {}
  names:
    kind: ClusterTask
    plural: clustertasks
    categories:
    - tekton
    - tekton-pipelines
  scope: Cluster
  conversion:
    strategy: Webhook
    webhook:
      conversionReviewVersions:
      - v1beta1
      clientConfig:
        service:
          name: tekton-pipelines-webhook
          namespace: tekton-pipelines

Anything else you would like to add:
None.
Environment:

ytt version (use ytt --version): ytt version 0.30.0
OS (e.g. from /etc/os-release): osx

See https://github.com/tektoncd/pipeline/issues/3794 as well.

Hi @zhouhaibing089,
I see that the version of ytt that you are using is v0.30.0. If you take a peek at the v0.31.0 release notes, you should see in that version we now support the merge operator.
With your example, I made some slight canges to foo.yml:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: clustertasks.tekton.dev
  labels:
    app.kubernetes.io/instance: default
    app.kubernetes.io/part-of: tekton-pipelines
    pipeline.tekton.dev/release: "v0.22.0"
    version: "v0.22.0"
spec:
  group: tekton.dev
  preserveUnknownFields: false
  versions:
    - &version
      name: v1alpha1
      served: true
      storage: false
      schema:
        openAPIV3Schema:
          type: object
          x-kubernetes-preserve-unknown-fields: true
      subresources:
        status: {}
    -
      <<: *version
      #@yaml/map-key-override
      name: v1beta1
      #@yaml/map-key-override
      storage: true
(removed end of file for brevity...)

then running ytt -f foo.yml:
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: clustertasks.tekton.dev
  labels:
    app.kubernetes.io/instance: default
    app.kubernetes.io/part-of: tekton-pipelines
    pipeline.tekton.dev/release: v0.22.0
    version: v0.22.0
spec:
  group: tekton.dev
  preserveUnknownFields: false
  versions:
  - name: v1alpha1
    served: true
    storage: false
    schema:
      openAPIV3Schema:
        type: object
        x-kubernetes-preserve-unknown-fields: true
    subresources:
      status: {}
  - served: true
    schema:
      openAPIV3Schema:
        type: object
        x-kubernetes-preserve-unknown-fields: true
    subresources:
      status: {}
    name: v1beta1
    storage: true
(removed end of file for brevity...)

Let me know if this helps, and please feel free to reach out/respond if you have any further questions.

Hey @zhouhaibing089, did @gcheadle-vmware's comment above help?

Thanks @gcheadle-vmware.
Without the modifications:
$ ytt-new -f ./foo.yaml                                                                                [10:50:16]
ytt: Error:
- __ytt_tpl2_start_node: expected key 'name' to not be specified again (unless 'yaml/map-key-override' annotation is added)
    in <toplevel>
      foo.yaml:25 |       name: v1beta1

In my opinion, foo.yaml should stay as is(This is a publichsed file which as client, we don't have control with), and ytt should be able to parse this YAML without issues.

i would agree with @zhouhaibing089 for the case of plain yaml files. we recently, on develop branch, added feature to interpret certain yml files as regular yaml files so for those files i would imagine we should also relax duplicate key check.

we recently, on develop branch, added feature to interpret certain yml files as regular yaml files

Yes: #324

so for those files i would imagine we should also relax duplicate key check.

A given YAML input is:

parsed from a stream of bytes into as YAML object model;
(if is a template) compiled and evaluated as a template.

It's during that second step that ytt explicitly checks for duplicate keys.
With #324, files like the subject of this issue would not be evaluated as templates and this would "just work."
p.s. when generating output, ytt does not check map keys:
https://github.com/vmware-tanzu/carvel-ytt/blob/01e2421ff04a2fa22c634b7cb3eedf04e054d7aa/pkg/yamlmeta/convert.go#L30-L38


Handle multiple cookie values sent in a request

First of all, thank you for making this lib.
I noticed that when multiple cookies sent in a request, it's not parsed correctly. For example with this cookie
first=asdf; axum.sid=1234

currently the name() of the cookie is first, and the value is asdf; axum.sid=1234, thus it fails to identify the session_layer.cookie_name is actually present.
The relevant part of the code is:
 let cookie_value = request
            .headers()
            .get(COOKIE)
            .and_then(|cookie| Cookie::parse_encoded(cookie.to_str().unwrap()).ok())
            .filter(|cookie| cookie.name() == session_layer.cookie_name)
            .and_then(|cookie| session_layer.verify_signature(cookie.value()).ok());

I think something like this should work (please check, I haven't tested this very thoroughly).
        let cookie_values = request
            .headers()
            .get(COOKIE)
            .map(|cookies| cookies.to_str());

        let cookie_value = if let Some(Ok(cookies)) = cookie_values {
            cookies
                .split(";")
                .map(|cookie| cookie.trim())
                .filter_map(|cookie| Cookie::parse_encoded(cookie).ok())
                .filter(|cookie| cookie.name() == session_layer.cookie_name)
                .find_map(|cookie| self.layer.verify_signature(cookie.value()).ok())
        } else {
            None
        };

Let me know what do you think about it.

Thanks for pointing this out. I'd be happy to fix this. Would you be interested in submitting a PR?

Version 0.1.1 is now available and includes this change.


Could you give me a howto on changing the destination directory

Thanks for this handy plugin.  We need to change the destination directory of the generated classes (to somewhere in the src folder), could you give us a hand?  Can you write a small gradle script?

For example, to have your compileJava task (the one that compiles the main source set) generate sources into src/main/generated, you'd use something like:
sourceSets {
  main {
    output {
      generatedSourcesDir = 'src/main/generated'
    }
  }
}

// or the more compact equivalent:
// sourceSets.main.output.generatedSourcesDir = 'src/main/generated'
// or any intermediary variant

Or you could simply reconfigure the compileJava task (but you could theoretically have other tasks that default to the source set output generatedSourcesDir, so they wouldn't see the change; hence the above, configuring the source set output, is preferred):
compileJava {
  generatedSourcesDestinationDir = 'src/main/generated'
}

// or the more compact equivalent:
// compileJava.generatedSourcesDestinationDir = 'src/main/generated'

To redirect all source sets' generated sources to `src//generated', you could write:
sourceSets.all { sourceSet ->
  sourceSet.output.generatedSourcesDir = "src/${sourceSet.name}/generated"
}

See https://github.com/tbroyer/gradle-apt-plugin#configuration

For anyone coming here trying to get this working, for some reason this didn't work for me (Gradle complained main was not found):
sourceSets {
  main {
    output {
      generatedSourcesDir = 'src/main/generated'
    }
  }
}

But this did:
sourceSets {
  main {
    output.generatedSourcesDir = 'src/main/generated'
  }
}