ContainerInterface name

So far, we have chosen to call the main interface ReadableContainerInterface.
The rational behind it is that "ContainerInterface" might be too generic.
We thought about "SimpleContainerInterface" but deemed it was too generic.
This thread is open to add new suggestions.
So far, I have just started looking at other languages.
Spring (in the Java world) has a "BeanFactory" interface, with a "getBean" method.
Add other suggestions (or what other frameworks do below)

Edit:

summary of options: https://github.com/container-interop/container-interop/wiki/ContainerInterface-name
vote: https://github.com/container-interop/container-interop/wiki/%231-interface-name:-Vote

Why is this still being called a container?

@J7mbo https://github.com/container-interop/container-interop/wiki/%231-interface-name:-Vote
Let's not reopen that discussion as it has already been a lengthy one finished a year ago. You can re-read the whole thread if you want to understand people's opinions.
See also the meta-document: https://github.com/container-interop/container-interop/blob/master/docs/ContainerInterface-meta.md#interface-name

@J7mbo This issue has been closed for 1 year now. Regarding container-interop, the ContainerInterface name is settled, as a stable release has been made. The choice of the name has been extensively documented in this thread and in the meta document.
Now, we are trying to move container-interop to the PHP-FIG (https://groups.google.com/forum/#!forum/php-fig), so of course, we can discuss naming of the interface of the soon-to-come PSR. I would prefer if you ask this question on the PHP-FIG mailing list rather than in this thread that should remain closed.
Of course, the ContainerInterface name is the result of several months of discussion and I think the name that was chosen has been done wisely, through a lot of discussion and a vote, so I'm ready to defend it.

@moufmouf Actually I'd prefer to be in a discussion: Please don't assume that I'm out for an aggressive attack that you have to 'defend' against. I think ContainerInterface goes well with Symfony devs, and their style of coding, because they love putting "Interface" at the end of everything. But I wholeheartedly disagree with "Container".
The reasons for that are that a container implies something that holds objects - if you place objects in this box, you're already advocating the service locator pattern and creating a god object. Let's not even get onto how Laravel names things. Call it a container and we're really not progressing in teaching best practice to the PHP community - which is what FIG is supposed to be standing up for.
It should be Injector imho, however the decision has already been made.

think ContainerInterface goes well with Symfony devs, and their style of coding, because they love putting "Interface" at the end of everything.

To be honest, most of the people that discussed in this thread have little to do with Symfony anyway.

you're already advocating the service locator pattern and creating a god object

Yes, we are. The fact is that the only possible interface for an Injector or a DIC or a Container is indeed a locator. Even in "higher level" libraries having a single location where the injector is used, SL is how this is achieved (see, for example, $app = $injector->get('app'), and no other usage of $injector - yes, that's SL, get over it).

we're really not progressing in teaching best practice to the PHP community

I actually agree with that, but a vote has already been set for the name, even if I disagree with it. From now on it's either accept or reject the proposal for it, and we may reconsider naming if the voting fails, I'd say.

which is what FIG is supposed to be standing up for

No, you are confusing http://www.phptherightway.com/ with FIG. FIG is about Framework-Interoperability, which (in other words) means "let's stop stepping on each other work and let's work together", where the we in the scope of the sentence is "frameworks" or "libraries", and has nothing to do with end-users. The fact that end-users get shiny things such as psr-0 is a side-effect.

It should be Injector imho

Injector does not apply, mainly because then we'd design an interface for a factory, and tbh, callable is already enough for that. Also, factories vary too much between frameworks to actually standardize right now.
If you want to explore the injector concept more, then feel free to write down a new proposal that deals with DI configuration/setup and all the details that can be commonly adopted by all frameworks.
A discussion was already started in #27.
I personally disagree with it, but it takes a lot of exploration to actually define how an injector works, and you also have to remember that defining an interface means also that you cannot dictate any implementation details, just the consumer API.
You'll see for yourself that it drills down to a locator again, regardless how perfect your injector prototype actually becomes. If that's not the case, then I'd like to see such an interface, as I've also been looking into it for a while.

@Ocramius Ah yes, I was confusing FIG and phptherightway ;D Thansk for your response.

Hi! Sorry to bother 12 participants, but this seemed like the most appropriate place to ask this.
Nowhere in the inline or otherwise docs have I managed to find whether methods implementing ContainerInterface#get() return singletons, i.e. always the same instance, only initializing it on the first call. Or does this standard intentionally omit this? If so, I think this information should be included in the docs.

@XedinUnknown Could you please open a new issue? It's a different discussion, and people involved in this one might not be interested in this new one (especially since it involves a lot of people)


Crashes in 19w38b

Just forgot to tell you, noticed you haven't updated it. Sorry, I can't provide the crash report, it happens when you try to open the mod menu screen.

Should be fixed now


add-max-retry-property-support

RetrySettings contain property maxAttempt which is not used by Publisher.
Added support for maxAttempt, which gives developer control a bit more over retries.

Changes Unknown when pulling 779f5262a937cb686bed305dae2bbac371cc2229 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling 779f5262a937cb686bed305dae2bbac371cc2229 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling 00582b8c62959f8c028c0c20a12a94de2ac072e4 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling 49b4e321b95fa1f4c63510804ce77afb401c28b1 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling 49b4e321b95fa1f4c63510804ce77afb401c28b1 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.


Detailed Backward Gradient Documentation

Hello,
Thanks for creating documentation. Are there plans to add derivations for jacobians?

Hi, yes we are planning to release detailed derivations soon!

Thanks. May I know approximately when? A week?
On Sat, Oct 14, 2023 at 10:42 PM Vickie Ye @.***> wrote:

Hi, yes we are planning to release detailed derivations soon!
—
Reply to this email directly, view it on GitHub
https://github.com/nerfstudio-project/gsplat/issues/50#issuecomment-1763245146,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDI25Z6EYGGL4EZWBIQUDWDX7NEQVAVCNFSM6AAAAAA6AVS5K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGI2DKMJUGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Yes we are planning to release within the week.

I would very much appreciate it if you could provide some documents on how to derive proj_mat...
Feel a bit confused about how to set it if I have camera intrinsic parameters.

@ljjTYJR for real cams you can try something like this: https://github.com/nerfstudio-project/nerfstudio/blob/40c05be7a60bde25adc28cd281bb9d742c2a77e9/nerfstudio/models/gaussian_splatting.py#L66 this is OpenGL convention using NDC.

@ljjTYJR for real cams you can try something like this: https://github.com/nerfstudio-project/nerfstudio/blob/40c05be7a60bde25adc28cd281bb9d742c2a77e9/nerfstudio/models/gaussian_splatting.py#L66 this is OpenGL convention using NDC.

Thanks! it helps me.
One minor question: BTW, it seems the coordination used in the gsplat and original Gaussian Splatting, they do not utilize the OpenGL coordination (with z and y axis are opposite), right?
In addition, for the Projection matrix, why the element at [2,3] is
$-1.0 * f * n / (f - n)$
instead of
$-2.0 * f * n / (f - n)$


France.tv 503 error

[X] I'm reporting a broken site support
[X] I've verified that I'm running youtube-dl version 2021.12.17
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones

##Verbose log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.france.tv/enfants/trois-cinq-ans/pip-et-posy/saison-1/3226036-remets-toi-vite-pip.html']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.22610
[debug] exe versions: ffmpeg 2022-05-02-git-40f2ea971f-full_build-www.gyan.dev, ffprobe 2022-05-02-git-40f2ea971f-full_build-www.gyan.dev
[debug] Proxy map: {}
[FranceTVSite] 3226036-remets-toi-vite-pip: Downloading webpage
[FranceTV] 6ba01afc-5d67-42f5-9174-9e465f0fe849: Downloading video JSON
ERROR: Unable to download JSON metadata: HTTP Error 503: Service Unavailable (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpupik7c6w\build\youtube_dl\YoutubeDL.py", line 2288, in urlopen
File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default
##Description
When attempting to download from france.tv, Youtube-DL is unable to download video JSON properly due to HTTP 503 error. This log is from a device that is able to access the video via the website.

Duplicate of #29956.


Open drive rendering

Can you rearrange the imports and definitions so that this script runs even if carla isn't installed? It seems like the script doesn't actually use anything imported from carla.

Can you rearrange the imports and definitions so that this script runs even if carla isn't installed? It seems like the script doesn't actually use anything imported from carla.

Done.

Cool. Is it possible to control the resolution of the produced gif?

o

Cool. Is it possible to control the resolution of the produced gif?

Done.

Traceback (most recent call last):
  File "/home/ascibior/repos/invertedai/examples/carla/demo_open_drive.py", line 68, in <module>
    scene_plotter = iai.utils.ScenePlotter(
TypeError: ScenePlotter.__init__() got an unexpected keyword argument 'dpi'

incomplete commit?

Traceback (most recent call last):
  File "/home/ascibior/repos/invertedai/examples/carla/demo_open_drive.py", line 68, in <module>
    scene_plotter = iai.utils.ScenePlotter(
TypeError: ScenePlotter.__init__() got an unexpected keyword argument 'dpi'

incomplete commit?

I had to change the utils.py in the package to update the sceneplotter. I assume the installed invertedai from pypi is being accessed which does not have dpi and resolution in the sceneplotter.


[chore] Use nyuki-token for backport

The backport to release failed:
The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release release
# Navigate to the new working tree
cd .worktrees/backport-release
# Create a new branch
git switch --create backport-189-to-release
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 58b851f2c7e9ef107c9f5ab748b953d86bac0852
# Push it to GitHub
git push --set-upstream origin backport-189-to-release
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release

Then, create a pull request where the base branch is release and the compare/head branch is backport-189-to-release.


Refactor usage of Modals

This PR changes the way we can use the modals. Instead of wrapping the content supplied by the user in predetermined block of dom and styles and exposing configuration options (evergrowing), we export several "lego" components that let the modal be used in any way possible, without the need of overwrite anything.
There are many advantages to this approach, but the immediate one is to be able to easily storyboarding modals without going trough the formalities of always setting up the whole thing, using the same block inside and outside a modal without changes, building the modal from a single component (instead of three different props that result in the eventual component), explicitly defining the modal and full control.
Anything else about the usage of the modals is not changed. Some trivial changes need to be made to the existing modal usage in the dashboard.
Examples:
Text
<ModalWrapper>Text modal</ModalWrapper>

Text with title
<ModalWrapper>
  <ModalHeader title="A title" />
  Hello world!
</ModalWrapper>

Text with title and close
<ModalWrapper>
  <ModalHeader title="A modal" onClose={...} />
  Some text in the modal body.
</ModalWrapper>

Some basic composition on top
<ModalBasic title="Modal Default" onClose={action('...')}>
  Default modal text
</ModalBasic>

Btw. here is the article I recently read regarding the ModalProvider approach: https://medium.com/@BogdanSoare/how-to-use-reacts-new-context-api-to-easily-manage-modals-2ae45c7def81

@fernandofleury

Dropped ModalBasic. I didn't want to put it there anyway, so @felixjung nudge was enough for me.
This is now waiting for a PR in the dashboard repo, before it is merged.

Sorry, I didn't comment on this before you merged. I agree with Felix about the exports, and left two small comments which are both minor.


Support BEFORE and AFTER clauses in createColumnConstraint()

Issue:
Currently when you add a column, it will always be added to the end of the table. However, you often want to group related columns together to ensure that select * queries are more readable and that the column order matches the property order in your application data model.
Solution:

Add support for MySQL's BEFORE and AFTER clauses to createColumnConstraint() method by adding before: column and after: column properties to the column spec.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Hi @tohagan !
I create a PR with these features. You can check it out here

Excellent!  Thank you

Because we needed features like this, I eventually opted for a SQL only migration solution so I'm now using this one ...
http://mybatis.org/migrations/


Make JsonAdapter an Interface

It occurs to me that JsonAdapter doesn't need to be an abstract class. Maybe we should put this in 2.0 since anybody creating their own custom adapters(but why??) would get a compilation error.

JsonAdapter doesn't need to be an abstract class

Nice spotting that. I did a double take myself - nice !!

Maybe we should put this in 2.0 since anybody creating their own custom adapters(but why??) would get a compilation error.

Hmmm. Well it's not ideal to merge it in for 1.5 of course but then again it also feels very unlikely at this point in time in terms of adoption (not many adopters pushing the boundaries hard with their own JsonAdpaters - it's hard to see people doing that, if they were would they not be watching the project and being more active in it?).
My gut says we should merge this in for version 1.5 rather than 2.0.

My gut says we should merge this in for version 1.5 rather than 2.0.

sure ok

Apologies in advance for folks on 1.x that are not expecting this [breaking] change in 1.5.  I think this is probably the last time we can "get away" with such a breaking change without bumping the major version.
Cheers, Rob.


Mostly green texture breaks other textures

Terrain3D version
v0.9.1
System information
Godot v4.2.1.stable.official [b09f793f5]
Is the issue reproducable in the demo?
Not applicable
Issue description
I was adding some coloured square textures with basic hsv noise, they were the exact same settings in GIMP just using using the Colorize tool to change the hue for each before exporting.
I was dragging these into the albedo texture area but if the image was mostly green it caused the terrain itself to display plain white (regardless of which texture slot I added the green albedo to) and threw this error twice:
core/variant/variant_utility.cpp:1091 - Terrain3DTextureList::_update_texture_data: Texture ID 5 albedo format: 19 doesn't match first texture: 17
This doesn't happen if I change the texture to include another colour such as a red stripe. But as long as the colour is green on the whole texture it throws the error.
5 successfully assigned non green textures

After uploading neongreen.png

Undoing that, and uploading seafoam.png

Undoing that, uploading newseafoam.png (which has a red stripe through it)

disclaimer: I tried using the demo to test but it had issues where I couldn't even enable the terrain3D plugin. The advice I could find to resolve said that "I hadn't installed it properly" but since it was the demo project I downloaded from the main files I couldn't be bothered to try and debug that too.
Also of note, the 'Setting up textures' link at the top of this issue form gives me a 404

Logs
No response

core/variant/variant_utility.cpp:1091 - Terrain3DTextureList::_update_texture_data: Texture ID 5 albedo format: 19 doesn't match first texture: 17

The message is quite explicit: The first texture you have in the list is format 17. The texture you just added as ID 5 is format 19. They don't match. Either use the old format or the new format, or any other format, as long as they are all identical. These specifications are documented.

This doesn't happen if I change the texture to include another colour such as a red stripe. But as long as the colour is green on the whole texture it throws the error.

The problem lies entirely in how you're creating the texture. We can't control that. We only use what you give us. If you are using PNGs (which are image files, not textures files), then you are instructing Godot to create the textures on your behalf using its texture creation library using the settings you specified on the Import panel. You can adjust those settings. Or you can make DDS files and take Godot's texture library out of the picture. Godot doesn't convert DDS textures.
Godot's texture creation library sucks, tbh. It makes automated decisions that are poor choices in some instances. Most likely you've selected a color combination that is triggering one of these odd cases in the compression library and Godot has chosen a different texture format than all of the others, for you. Since green is perceived differently than other colors, I vaguely recall seeing something about Godot changing formats based on it/green/perceptual values??
In any case, you're responsible for knowing what texture files you have and give us. You can double-click any image file and godot will tell you the format and size of any image in the inspector. We require them to all be the identical format and size (because Godot requires it for what we're doing with those files).

I tried using the demo to test but it had issues where I couldn't even enable the terrain3D plugin.
I couldn't be bothered to try

We're here to help when you are willing. We have thousands of users at this point, so yes if you can't enable the demo on your system, you didn't work through the installation instructions properly. The console reports specific error messages that we can use to help you troubleshoot.

I'm pretty new to Godot and game dev in general. Things that seem "pretty explicit" to you are completely opaque to me. I was just trying to help mate, no need to be condescending. In the future I'll just assume I'm being a dummy and not bother I guess.
re: demo I followed your guide to a T, and got my tutor to double check. idk what to tell you but opening your demo project it says that there are missing dependencies. The advice I can find specifically about that issue, being that the files are in the wrong location, wasn't the case, and even hooking them back up to the right files did nothing. The project couldn't enable the plugin because there were "errors in the script", but the only errors in the script were that it couldn't find the Terrain3D node because I couldn't enable the plugin because there were errors in the script.
Anyway, thanks for the info.

re: demo. idk what to tell you but opening your demo project it says that there are missing dependencies.

The project couldn't enable the plugin because there were "errors in the script", but the only errors in the script were that it couldn't find the Terrain3D node because I couldn't enable the plugin because there were errors in the script.

I offered to help. When you run Godot with the console executable, and open our demo it will show logs and error messages. We need those exact messages from the beginning of the run. I can then properly interpret the messages. There aren't errors in the script. It doesn't recognize the compiled library, possibly because it's not in the correct folder, or not on your system at all.

Why the hell am I getting emails like this?
În lun., 10 iun. 2024 la 05:05, Cory Petkovsek @.***> a
scris:

re: demo. idk what to tell you but opening your demo project it says that
there are missing dependencies.
The project couldn't enable the plugin because there were "errors in the
script", but the only errors in the script were that it couldn't find the
Terrain3D node because I couldn't enable the plugin because there were
errors in the script.
I offered to help. When you run Godot with the console executable, and
open our demo it will show logs and error messages. We need those exact
messages from the beginning of the run. I can then properly interpret the
messages. There aren't errors in the script. It doesn't recognize the
compiled library, possibly because it's not in the correct folder, or not
on your system at all.
—
Reply to this email directly, view it on GitHub
https://github.com/TokisanGames/Terrain3D/issues/399#issuecomment-2157049792,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7VIHXOHSS5XA2QATEDZTZTZGUCWHAVCNFSM6AAAAABJAUVUJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJXGA2DSNZZGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@novac07 No one tagged you in this thread. If you want Github to stop sending you emails click the unsub link in the email you just responded to or click the unsub button on the webpage.


fix(book): fix banner image 2nd itr

2nd iteration of pr #824
Add full url of image source assets/reth.jpg

still figuring out how to add the right reviewers , that will be done for next time @mattsse


use the networkX library

https://networkx.org/documentation/stable/reference/algorithms/shortest_paths.html

Directed Graph: https://networkx.org/documentation/stable/reference/classes/digraph.html
A* algorithm: https://networkx.org/documentation/stable/reference/algorithms/shortest_paths.html#module-networkx.algorithms.shortest_paths.astar

implemented in v2.4.0


Add isolatedModules error for ambiguous imports referenced in decorator metadata

Fixes #42281
Teeeechnically maybe a breaking change since there’s a new error, but it should only be an error when a transpiler would produce code that errors at runtime.

If I understand correctly, the issue is that we keep in a static import for the interface:
import { X, B } from "./other";

class C extends B {
  @dec x: X;
}

We try to emit X as a value using a "fallback" expression:
import { X, B } from "./other";
class C extends B {
}
__decorate([
    dec,
    __metadata("design:type", typeof (_a = typeof X !== "undefined" && X) === "function" ? _a : Object)
], C.prototype, "x", void 0);

However, that leaves in a static import for X, which may not actually be exported from "./other". What we should do is replace the static import binding with a namespace import:
import { B } from "./other";
import * as other_1 from "./other"; // replace `import { X }` with namespace import...
class C extends B {
}
__decorate([
    dec,
    __metadata("design:type", typeof (_a = typeof other_1.X !== "undefined" && other_1.X) === "function" ? _a : Object)
], C.prototype, "x", void 0);

This doesn't occur in CJS, AMD, or System emit because we always end up with a "namespace" import in those cases:
const other_1 = require("./other");
class C {
}
__decorate([
    dec,
    __metadata("design:type", typeof (_a = typeof other_1.X !== "undefined" && other_1.X) === "function" ? _a : Object)
], C.prototype, "x", void 0);

I’m not sure where the design meeting notes are where we discussed this, but I believe the compromise we came up with was

only error in es2015+ (done)
add codefixes that suggest both import type and import * as whatever as workarounds

I think to be safe, this shouldn’t go in post-beta, so will plan to target for 4.5.


Active Active Cluster Share stick table and rate limits

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
When deploying Traefik in a highly available (active-active) cluster, have the traefik instances share stick table (sticky sessions), rate limits and max concurrency data.
Keeping the traefik instances in sync with each other about these counters (key/values) will ensure that consistency is kept. A client IP could end up on any of the traefik instances (via aws load balancer or DNS round robin) then it is important to sync the state/counters among all the traefik instances (if client is limited to 5 requests per second, it should be across the cluster, and not per traefik instance).
If a client has sticky sessions for backend, it should be propagated across the traefik cluster.

Hello,
This enhancement is linked to a feature that no longer exists in the supported versions of Traefik.
Closing accordingly.
Please feel free to re-open it if necessary.


Support for on-demand or lazy loading of child nodes

First, thank you for this great component!
I wanted to ask your thoughts on support for lazy-loading child nodes - whether this can already be done, or any hints or directions if I found the time to implement it.

Hey @arikkfir, unfortunately this is not supported at the moment, it's been in the roadmap for a while now so I'll try to find the time to implement this in one of the next releases.
As always, PRs are welcome of course :)

+1 this is essential

+1


Update testing and CI

[x] Update Jest
[x] Fix Jest Snapshots
[ ] Update Eslint and Airbnb rules
[ ] Update Example project to the latest version of React Native
[x] Update node version in CircleCI
[ ] Configure parallelism to test with LTS and latest node version.
[x] Add yarn
[ ] Use yarn instead of npm in CI
[ ] Build Android example project on CircleCI

Any help is welcome. :rocket:

I already have a PR. And, I updated react packages to fix Jest Snapshots.
Could you review my PR #1406 ?

Task list has been updated.
@MechanicKim Jest Snapshots has been fixed, but I'll review your PR.

About Update Eslint and Airbnb rules,
Dose this work include fixing style of all source codes or just updating the package?

Update dependencies and fix errors as you did in #1425, thank you btw.

My PR #1451 got an error
ENOENT: no such file or directory, stat '/home/ubuntu/react-native-router-flux/Example/node_modules/react-native/jest/setup.js'
Any idea? @charpeni

@Swordsman-Inaction
If you use react-native < 0.38, jest version should be 17.0.3.
Maybe you should fix jest preset.
"jest-react-native" ---> "react-native"

@MechanicKim
The Example's pakcage.json file https://github.com/aksonov/react-native-router-flux/blob/master/Example/package.json
It does use "react-native": "0.30.0" and "jest-react-native": "^17.0.3"
Should I just delete "jest-react-native": "^17.0.3"?
And my PR doesn't change the Example, does it mean that the Example's pakcage.json is just wrong at beginning.


integrate consensus cache into hare3 and legacy oracle

follow up for https://github.com/spacemeshos/go-spacemesh/pull/5013
hare is the most sensitive to the latency workload. hitting slow disk on validating messages will make propagation speed unpredictable.
oracle
nonce, weight, height, base height, malicious bit will be available without access to the database.
integer for total active set weight should remain cached in the oracle.
hare3
proposals selection should use cache to get its own atx (height, base height) and malicious bit

To not waste time it will be done after hare1 is disabled, or together with graded oracle


updated i18n

We're working on updating one of our apps to Rails 5, but Faker and Turnout conflict over gem i18n.  Updated gem to fix conflict.

I'm going to hold off on this for now.


MapStack not loading

The map stop loading when you add a second layer. We are using five layers for a class assignment with about 20 people using it at once. Two students were able to export their image before it stopped working.

Thanks, it seems to be working again. I haven't seen this problem happen before, but maybe we've never had 20 people all trying to make a similar map at the same time.
If it's still happening, or if it happens again, could you paste the URL into this issue so we can just to see exactly which layers are failing?
You can paste either the "edit" link that's in your browser window<EMAIL_ADDRESS>...or you can right-click in the map area and select "copy image address" which will give you the url of that map tile, like this: http://c.sm.mapstack.stamen.com/(watercolor,(mapbox-water,$ff6600[hsl-color]))/11/327/791.png

Awesome, Thanks Alan.,


Anisotropic Texture filtering

There should be a way to set the maximum required level of anistropic filtering.
Currently:

opengl uses the maximum available level for anisotropic filtering.
d3d9 D3DSAMP_MAXANISOTROPY is not set, so default 1 is used.
http://msdn.microsoft.com/en-us/library/windows/desktop/bb172602(v=vs.85).aspx
d3d11 sets maxaniso to 1.
https://github.com/bkaradzic/bgfx/blob/master/src/renderer_d3d11.cpp#L1691

I would like to set the maximum aniso level required by our app.
This could be a global setting, and the real value could be the minimum of the supported aniso level and the user required level.
Something like in Horde3D:
https://github.com/horde3d/Horde3D/blob/master/Horde3D/Bindings/C%2B%2B/Horde3D.h#L72

I didn't test with FL9* resource limits yet:
https://msdn.microsoft.com/en-us/library/windows/desktop/ff819065(v=vs.85).aspx
Does make sense to add granularity 1, 2, 4, 8? I would expect on/off would be sufficient?

Per-sampler(texture) I would say on/off is sufficient.
A Global setting that sets the max aniso level could be useful for an app to set graphics detail level. Eg, : on low detail aniso can be set to lower level/turned off for better performance.

Added flag BGFX_RESET_MAXANISOTROPY.

thanks


Template rendering error

It seems like https://github.com/cloud-bulldozer/kube-burner/commit/203ca0621229cb3a346853829dbbfea93f17889a introduced an issue with templating
04-12-2020T22:00:19 Benchmark in progress
time="2020-12-04 22:00:17" level=info msg="Deleting namespaces with label kube-burner-job=cluster-density"
time="2020-12-04 22:00:17" level=info msg="📈 Creating measurement factory"
time="2020-12-04 22:00:17" level=info msg="Registered measurement: podLatency"
time="2020-12-04 22:00:17" level=info msg="Triggering job: cluster-density"
time="2020-12-04 22:00:17" level=info msg="Using in-cluster configuration"
time="2020-12-04 22:00:17" level=info msg="Creating Pod latency informer for cluster-density"
time="2020-12-04 22:00:17" level=info msg="QPS: 5"
time="2020-12-04 22:00:17" level=info msg="Burst: 10"
time="2020-12-04 22:00:17" level=info msg="Creating namespace cluster-density-dfbbf614-493c-4aff-8a03-cf56ca7cd33b-1"
time="2020-12-04 22:00:17" level=fatal msg="Error rendering template: template: :7:6: executing \"\" at <.image>: map has no entry for key \"image\""
04-12-2020T22:00:40 Benchmark finished, waiting for benchmark/kube-burner-cluster-density-dfbbf614-493c-4aff-8a03-cf56ca7cd33b object to be updated
NAME                         READY   STATUS   RESTARTS   AGE
kube-burner-dfbbf614-l4hkd   0/1     Error    0          82s
04-12-2020T22:00:40 Benchmark kube-burner-cluster-density-dfbbf614-493c-4aff-8a03-cf56ca7cd33b finished with status: Failed

It should be fixed by https://github.com/cloud-bulldozer/benchmark-operator/pull/478


Automated cherry pick of #6185: 修复谷歌监控无法获取的问题

Cherry pick of #6185 on release/3.2.
#6185: 修复谷歌监控无法获取的问题

Codecov Report

Merging #6189 into release/3.2 will increase coverage by 0.02%.
The diff coverage is 9.02%.

@@               Coverage Diff               @@
##           release/3.2    #6189      +/-   ##
===============================================
+ Coverage         7.02%    7.04%   +0.02%
===============================================
  Files              644      646       +2
  Lines           110421   110870     +449
===============================================
+ Hits              7756     7815      +59
- Misses          102066   102454     +388
- Partials           599      601       +2

Flag
Coverage Δ

#aFlag
7.04% <9.02%> (+0.02%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/cronman/cronman.go
53.95% <0.00%> (+3.07%)
:arrow_up:

pkg/cloudcommon/db/caller.go
25.43% <0.00%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/fetch.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/infraresource.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/opslog.go
1.50% <0.00%> (-0.16%)
:arrow_down:

pkg/cloudcommon/db/owner.go
7.40% <0.00%> (-2.60%)
:arrow_down:

pkg/cloudcommon/db/sharablebase.go
7.20% <0.00%> (-0.13%)
:arrow_down:

pkg/cloudcommon/db/sharablevirtual.go
0.00% <0.00%> (ø)

pkg/cloudcommon/db/standalone.go
1.68% <0.00%> (-0.03%)
:arrow_down:

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9bddf...1a800c9. Read the comment docs.


Check the nodes we are rebroadcasting votes to inside of broadcastPreviousRoundNextVotesBundle

Right now inside of broadcastPreviousRoundNextVotesBundle we are sending votes only to nodes with the same period. I think we should send it to nodes that are a little bit out of sync and which would accept this votes. Check ExtVotesPacketHandler::validateStandardVote and kVoteAcceptingPeriods, kVoteAcceptingRounds, kVoteAcceptingSteps

This is fixed in this PR https://github.com/Taraxa-project/taraxa-node/pull/2273 - we dont check for peer period anymore, we just check if vote is known for the peer as filter


Unique names for the two email supervisor actors

This PR was successfully deployed to production by CircleCI build 351 at 2018-07-11 10:44 BST.


Lag on tilemap when camera move

I have same lag on camera move like this one http://examples.phaser.io/_site/view_full.html?d=tilemaps&f=sci fly.js&t=sci fly&phaser_version=dev&

I've had a simlar problem when running it in android (lollipop). I don't know why, but with tiledmap the camera totally stops working (I was using camera follow). If it's continues like this, there's no way to make my project with phaser (but I'm really loving work with).

I'm having the same issue. My map is 92x92 and ran at ~60fps on 2.2.2. In 2.4.4, the fps drops to 5-15 when the map is scrolling. I'm using 2 layers on my tilemap, Arcade physics and auto render on Chrome.

We've made a number of optimisations to the way TIlemaps render and are updated in 2.4.9 (currently in the dev branch), and a lot of fixes to how Sprites are followed by the Camera.
We're also working on a new WebGL shader for rendering Tilemaps, which you can find in its own branch on the main repo. I'll leave this one open for now, until the new WebGL renderer lands, but it should be a lot better than before with 2.4.9.

Ok I'm closing this one off (finally, yay!) as the new WebGL Tilemap renderer is now included in Phaser 2.7.0 in the dev branch, and I would like that build to be tested against this.


Support backup destination to STATIC_ROOT on permissions error

If static_templates are delivered with a package downloaded from pypi into a repo, render_static might not have permissions to render those files into the app's static directories. Default behavior should be to use STATIC_ROOT as a backup in the case of permissions error.
Current workaround is to just provide a destination.

Closing in favor of #64


Vulkan Clustered: SpotLight3D clustering artifacts with no fog or other effects

Godot version
4.0.beta10.official [d0398f62f]
System information
Windows 10, Vulkan, NVIDIA GeForce RTX 2060m (<IP_ADDRESS>98)
Issue description
I'm getting some kind of clustering/blocky artifact when using spotlights, with no fog or any fancy rendering stuff whatsoever.
I've looked through a bunch of similar issues, but the only ones I could find were related to volumetric fog or other environment effects that I am not using.
Not sure if I'm just missing something, but I think I've played with every option in the spotlight and every option in a WorldEnvironment and nothing makes it go away.
The only lead I have is that the intensity of the artifact seems to be affected by the spot angle. It cycles in a sawtooth pattern every ~0.07 degrees.

Lmk if you need more info or need me to try anything.
Steps to reproduce

New Project (Forward+)
Put down some MeshInstance3Ds as a backdrop
Put a SpotLight3D
Raise spotlight intensity, lower spot angle, and increase range to see it better
Slowly increase spot angle to see cycling effect

Minimal reproduction project
testspotlight.zip

Haven't confirmed it, looks normal to me.
But I do see a similar effect when I look along a spotlight on this particular omnilight attached to a navigation agent. Doesn't happen with the other ones, might investigate.

@solek1312 Which operating system and graphics card model are you using?

Related to #59262 and #45469.
@solek1312 Which operating system and graphics card model are you using?

Intel i5-1135g7 integrated card, Linux Mint 21

I can confirm this on 4.0.beta 621e32971 (Linux, GeForce RTX 4090 with NVIDIA 525.60.11).


Add warning about changed default for changelog

Related to packit/packit#2253
Merge after packit/packit.dev#854
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

@nforro +1, I was also thinking about this. I created a class for this, PTAL.


Segfault with data or voting parallel operation over sockets

Environment info
Operating System: Ubuntu 16.04.2 LTS
CPU: Amazon EC2 m3.2xlarge instance
C++/Python/R version: gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)
Error Message:
From rank 0 machine:
[LightGBM] [Info] Finished loading parameters
[LightGBM] [Warning] Set TCP_NODELAY failed.
[LightGBM] [Info] Trying to bind port 12400...
[LightGBM] [Info] Binding port 12400 succeeded
[LightGBM] [Warning] Set TCP_NODELAY failed.
[LightGBM] [Info] Listening...
[LightGBM] [Warning] Set TCP_NODELAY failed.
[LightGBM] [Info] Connected to rank 1
[LightGBM] [Info] Local rank: 0, total number of machines: 2
[LightGBM] [Info] Finished initializing network
Segmentation fault (core dumped)

From rank 1 machine:
[LightGBM] [Info] Finished loading parameters
[LightGBM] [Warning] Set TCP_NODELAY failed.
[LightGBM] [Info] Trying to bind port 12400...
[LightGBM] [Info] Binding port 12400 succeeded
[LightGBM] [Info] Listening...
[LightGBM] [Warning] Set TCP_NODELAY failed.
[LightGBM] [Warning] Set TCP_NODELAY failed.
[LightGBM] [Info] Connected to rank 0
[LightGBM] [Info] Local rank: 1, total number of machines: 2
[LightGBM] [Info] Finished initializing network
Segmentation fault (core dumped)

Reproducible examples
Using example from LightGBM/examples/parallel_learning/
Steps to reproduce

Clone master branch of LightGBM repository
Build using standard installation instructions from https://github.com/Microsoft/LightGBM/wiki/Installation-Guide
Set mlist.txt in LightGBM/examples/parallel_examples/ to available machine IPs
Change existing train.conf to data parallel (voting parallel produces similar results)

tree_learner = data

Run LightGBM command per instructions in README.md

lightgbm config=train.conf

This also occurs with MPI-based parallel operation.
Segmentation fault occurs here:  https://github.com/Microsoft/LightGBM/blob/master/src/io/dataset_loader.cpp#L744

@coulls  can you try the latest code ?

This appears to work now.  Thank you!


Use triple-equals for comparison

snapshot.size will be a number, so use === to compare it with 0.

@googlebot I signed it!

@evancharlton thanks for the fix!


panel-bar setup in footer

Not quite sure, if this is an issue.
The setup instruction on github doesn't work for me with this line of code.
<?php snippet('plugin.panelBar') ?>
But it does work with the following line included in the readme file.
<?php echo panelBar::show() ?>
(Latest Kirby version and tested on localhost by the way.)

Could you try it with the most current version from the develop branch? It should work just like <?php snippet('plugin.panelBar') ?>


[A11y] Make announcers read the version history table data correctly.

Added tabindex to every td tag on the version history table so that the value can be announced using NVDA or other announcers.
Addresses https://github.com/NuGet/NuGetGallery/issues/8491

Do we need to add tabindex on all our tables? For example, all our statistics tables here: https://www.nuget.org/stats

Do we need to add tabindex on all our tables? For example, all our statistics tables here: https://www.nuget.org/stats

They already have the tabindex=0,
@ryuyu tabindex allows us to traverse the table cell by cell, before we could only traverse the Version and Status column because the values from those rows are links.


Handel the Databricks Operator failure with proper error message

Handled the failure case properly as per in sync version

In the Jobs API 2.1, we can't call get_run_output on the top-level Run ID because it's
not supported by API - we need to call this function on a specific sub-run of the job, even
if it consists of the single task

Got the code unrelated to my changes in this PR, So closing this PR raising another PR for my changes


Unknown CA trying to use API?

Greetings,
I get
Get https://my-host/api/v1/ping: x509: certificate signed by unknown authority
but the CA is InCommon RSA Server CA and is recognized by all of my browsers. Any ideas on telling it to ignore? Or somehow updating known CAs?

Set this and still the same error error:
strict certificate checking for https
strict: false

Solved by finding and installing the intermediate CA-Bundle for InCommon


Set up Android for emission

This is a complete redo of https://github.com/artsy/emission/pull/225 and my hackathon project. In orders to minimize the initial diff (although this is still really big) and make it easier for other to understand the entire change, I focused on just setting up the project rather than going all the way to implement integration with existing stuff. In summary, I have made these changes:

ran react-native init android and moved the entire project up to the root directory
updated compileSdkVersion, buildToolsVersion, targetSdkVersion, and the support libraries to 25, which is compatible with the latest React Native version

Android O (latest version as of writing) is not supported: https://github.com/facebook/react-native/pull/15601

updated the android gradle plugin to 2.3.3 that has Instant Run capability

Right now, it still uses the default component generated by the react-native init command. Naturally, the next step will be to have it integrate with Emission's existing components.

Cool, looks fairly straightforward! Looking forward to the blog post :)

looks like the build is broken now. I'll look into it.

@yuki24 Emission works off local branches, not forks

It seems like I shouldn't have forked emission. I'll re-send this PR so the build will get proper ENV variables.


ECDSA staker rewards adjustments for ETH-only delegation

As currently implemented, ECDSA staker reward contracts support only one ECDSA keep factory. To fully implement ETH-only delegations for ECDSA operators we need to find a way to include ETH-only keeps in staker rewards. One option is updating reward contracts to support two factories. Another option - if math would make sense - could be to deploy another rewards contract for ETH-only stakers.

We decided to not implement this natively in the protocol but instead introduce a KEEP-only pool. At the same time, there are efforts in Keep community to implement community staking pools.


Parking Lot

Post any questions you may have here during the training.

Test

pls share any good documentation on integrating Github with sharepoint development


mod failed to load 1.18.2

Getting mod failed to load: Caused by 0: java.lang.reflect.InvocationTargetException
when using:
trofers-1.18.1-2.6.0
forge-1.18.2-40.0.19
crash-2022-03-19_12.16.14-fml.txt

debug.log
latest.log

Thanks for the report! This is caused by a breaking change Forge made in 40.0.18. I've uploaded a patch that fixes the issue, which should be available for download soon.


Paused VMIs should remain paused after migration

What this PR does / why we need it:
Currently, VMIs in a paused state are being unpaused after migration.
This PR simply adds a flag to indicate that these VMIs shouldn't be unpaused on destination.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Release note:
NONE

/cc @xpivarc

/hold

/hold cancel

/cc @davidvossel

/test pull-kubevirt-unit-test

/lgtm
Can we link https://bugzilla.redhat.com/show_bug.cgi?id=1939987 to PR description?

Can we link https://bugzilla.redhat.com/show_bug.cgi?id=1939987 to PR description?

Absolutely :)

/approve

/hold
put on hold so vladik can fix a couple things he wanted to address before this is merged.

/hold cancel

/retest

/retest

/lgtm

/retest


Linter does not understand namespaces

For this:
param p1 string = concat('a', 'b')

the linter suggests using interpolation instead of concat
But it gives no warning for this, which is equivalent:
param p1 string = sys.concat('a', 'b')

See comments from Marcin: https://github.com/Azure/bicep/pull/2341#discussion_r636473019

Recommend post-0.4 because:

Seems to be an issue of false negatives, not false positives
There are currently no overlaps between namespaces

Also affects checks against "newguid"

This is done correctly in some rules but needs to be made consistent and have better re-usable code.


Missing Font Awesome icon(s)

Steps

Attempt to use the user-md icon

Expected Result
<Icon name='user-md' /> renders this icon: user-md
Actual Result
<Icon name='user-md' /> renders a blank Icon element
Version
0.73.1
Testcase
https://codepen.io/jonsibley/pen/OxMbxr
Comments
It's possible this isn't a bug, but rather a misunderstanding on how Font Awesome icons are grouped, or what Sematnic-UI-React makes available out of the box. However, the following comment from the docs leads me to believe that the user-md icon (and likely more) are unintentionally missing:

Semantic includes a complete port of Font Awesome 4.7.0 designed by Dave Gandy for its standard icon set.

Semantic UI uses own icon names for FontAwesome icons, i.e. fa-user-md is doctor. So, you should use <Icon name='doctor' />.
See Semantic-Org/Semantic-UI#2952.


fix(sveltekit): Load environment variables from process.env

I can't find the actual part of the SvelteKit code that causes the import of "$env/dynamic/private" inside a node_module to fail, but I fixed our example so the problem surfaced.
I also discovered https://github.com/sveltejs/kit/issues/12028 which states that a warning should be added that third-party libraries should not use this import. And https://github.com/nextauthjs/next-auth/issues/9809 + https://github.com/nextauthjs/next-auth/pull/10117 which highlight problems when it is used.
Perhaps we'll need to explore something like https://github.com/nextauthjs/next-auth/discussions/6247 but it seems that process.env is populated in SvelteKit so we can use it for now.
Fixes #982

Also tested with bun run dev and it works since Bun supports process.env


refactor!: remove deprecated items

Removals are noted in JIRA ticket.
NODE-2317
Some of the deprecations are not to be removed (e.g, Collection#insert) but a warning should still be emitted I wrote a small wrapper around process.emitWarning that we should also port to 3.6. This allows us to drop the deprecate calls that come after the class definition (e.g, deprecate(Collection.prototype.insert, ...)) and move a emitWarningOnce call into the method itself.

@addaleax These are the deprecations in 3.6 that are slated for removal in 4.0, there are failures with the mongosh tests. If you (or a colleague) get the chance, could you take a look and give us some insight into what is expected/unexpected here.

If you (or a colleague) get the chance, could you take a look and give us some insight into what is expected/unexpected here.

It's failing during typescript compilation in both cases (I know the test logs can be a bit messy -- it's generally helpful to grep around for the first npm ERR! if you're looking at them to find the source of the problem(s)):
 [2021/02/19 18:27:59.938] TSError: ⨯ Unable to compile TypeScript:
 [2021/02/19 18:27:59.938] src/cli-service-provider.spec.ts(295,22): error TS2339: Property 'findAndModify' does not exist on type 'StubbedInstance<Collection>'.
 [2021/02/19 18:27:59.938] src/cli-service-provider.spec.ts(308,29): error TS2339: Property 'findAndModify' does not exist on type 'StubbedInstance<Collection>'.

and for #2741
 [2021/02/19 18:42:58.456] src/shell-internal-state.ts(223,29): error TS2749: 'TopologyType' refers to a value, but is being used as a type here. Did you mean 'typeof TopologyType'?

The latter is probably not hard to address, you can merge it and we'll probably really just have to add typeof in a places where we're referring to the type of what-was-once-an-enum.
For the findAndModify one, I don't think we were aware that it was deprecated. It's exposed as a shell method, so we'll need to find a way of implementing it in terms of the methods that replace it, which doesn't seem hard to me, but I haven't tried it yet so I'm not sure.
And thanks for the ping! :)

For the findAndModify one, I don't think we were aware that it was deprecated. It's exposed as a shell method, so we'll need to find a way of implementing it in terms of the methods that replace it, which doesn't seem hard to me, but I haven't tried it yet so I'm not sure.

Thanks for going through the logs! Sounds like we're good to go, of course let us know if we can advise/help out with the findAndModify patch. There are three options that can be passed to findAndModify:

update?: boolean;
remove?: boolean;
upsert?: boolean;

and that's what makes it do the same thing as findOneAndUpdate, findOneAndDelete, findOneAndReplace.


Support for native serialization format

It appears the native serialization format from CRoaring currently is not supported, i.e. serialization using the functions roaring_bitmap_serialize, roaring_bitmap_deserialize_safe and roaring_bitmap_size_in_bytes.
I'd be happy to give it a try with adding support for that, if there's interest in such a change? If so, would you prefer just adding more functions, or perhaps consolidating (de-)serialization functions with a "format" parameter?

Thanks for your contribution @andreas. This was resolved in https://github.com/RoaringBitmap/croaring-rs/pull/106.


Add optional queue parameter to Reactive providers

Hello, i implemented callback queue propagation for reactive providers(which address https://github.com/Moya/Moya/issues/1032 https://github.com/Moya/Moya/issues/1048 https://github.com/Moya/Moya/pull/762). I have same complains, that should be resolved before merge.
Queue vs Scheduler
I saw several suggestions to use Schedulers instead of queue for RxSwift(and whatever abstraction ReactiveSwift has), but I’m still believe this queue is not what rx provider responsible for, this is Alamofire threading stuff, users may be confused why they should pass scheduler instead of subscribe/observe on(and maybe this moment should be reflected at method comment).
We can’t use SchedulerType, case we need DispatchQueue, which unnecessary for abstract scheduler, so we have to constraint which scheduler type user can pass(so, instead of reuse his scheduler, user may be forced to create new just to pass queue).
RxSwift do several optimizations for Schedulers(and i’m believe ReactiveSwift too), for example it “converts” Concurrent queue to serial(creating new serial queue with old queue as target), which queue should we use in this case(and even, can we still access concurrent queue)? Not sure we can rely on internal queue in future "optimizations" 😄
Everything previously said was my own thoughts, but the fact Schedulers configuration is internal(which means we can’t access it outside of module and 3 paragraphs above has no sense) indicates that Krunoslav Zaher don’t want us to use internal queue :)
Comments
Maybe we should add reacher comments to method, explicitly indicating that we nor observe, nor subscribe on this queue, we just pass it to Alamofire as a callback queue. If user really want subscription(request method call) to run on queue - he should subscribe on caller side.
User may create provider with queue and forget about it, which leads to unexpected element generation queue. In current implementation there is no way to pass nil queue to Alamofire, if provider has default queue, and I don’t know is it okay.
Other stuff
As far as I understand, I should update Readme(as at this PR). Maybe I shouldn't use ?? operator? Seems it can affect compilation time, so maybe we should sacrifice readability in favour of compilation speed?

          1 Error

:no_entry_sign:
Any changes to library code need a summary in the Changelog.

          1 Warning

:warning:
Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

SwiftLint found issues
Warnings

File
Line
Reason

ReactiveSwiftMoyaProvider.swift
10
Lines should not have trailing whitespace.

ReactiveSwiftMoyaProvider.swift
13
Lines should not have trailing whitespace.

ReactiveSwiftMoyaProvider.swift
35
Lines should not have trailing whitespace.

ReactiveSwiftMoyaProvider.swift
82
Lines should not have trailing whitespace.

RxMoyaProvider.swift
25
Limit vertical whitespace to a single empty line. Currently 2.

RxMoyaProvider.swift
9
Lines should not have trailing whitespace.

RxMoyaProvider.swift
12
Lines should not have trailing whitespace.

RxMoyaProvider.swift
25
Lines should not have trailing whitespace.

RxMoyaProvider.swift
34
Lines should not have trailing whitespace.

RxMoyaProvider.swift
57
Lines should not have trailing whitespace.

RxMoyaProvider.swift
15
Function parameters should be aligned vertically if they're in multiple lines in a declaration.

RxMoyaProvider.swift
16
Function parameters should be aligned vertically if they're in multiple lines in a declaration.

RxMoyaProvider.swift
17
Function parameters should be aligned vertically if they're in multiple lines in a declaration.

RxMoyaProvider.swift
18
Function parameters should be aligned vertically if they're in multiple lines in a declaration.

RxMoyaProvider.swift
19
Function parameters should be aligned vertically if they're in multiple lines in a declaration.

RxMoyaProvider.swift
20
Function parameters should be aligned vertically if they're in multiple lines in a declaration.

  Generated by :no_entry_sign: danger

I'll fix lint issues later, when there will be no other reason to reject PR(case code can change during PR :))

Let's get the linting issues fixed, maybe write some tests.
Then we can merge this into optional-response-thread-param, and continue the discussion on which queue/scheduler primitive to use in #762

I think it would be smart to implement some more tests as well though. Are you familiar with testing in ReactiveSwift/RxSwift?

Yep, for some degree, but only with RxTest/RxBlocking(that means I can't write ReactiveSwift tests w/o future investigation). I'll cover this commit functionality(check callback queue) within the next few days

Cool, it would be awesome to get those RxSwift tests then! Maybe someone else can add them for ReactiveSwift later.
Things pending before we merge to optional-response-thread-param

[ ] write tests for RxSwift
[ ] fix the overriding initializer and change the MoyaProvider initializer to take a queue as well

So I'm trying to understand... this is the queue that will be used by Alamofire for callbacks as a hook back into Moya, whereas the remaining Scheduler property is in place for delivery of whatever reactive abstraction you use?

That's correct @justinmakaila. So then if you're using the vanilla MoyaProvider, you pass a thread. But if you're using an RxMoyaProvider, you'd pass in the Rx abstraction of a thread - a scheduler, and whatever the equivalent is for ReactiveSwift as well.
For rationale and example usage, check out #762

As far as I remember, you can't get queue from a scheduler. In addition, you can't pass any Scheduler as a callback queue provider for Alamofire

Let's re-examine that assumption: that you can't get a queue from a scheduler.
Schedulers internally use DispatchQueues to do their work (here's how the MainScheduler uses a queue).
Let's make an issue on RxSwift's repo asking if theres any way to grab it, since right now, it is private

It's not private, it's internal. You can implement scheduler in whatever way you want: you should just adopt one protocol, which has nothing common with GCD. So, for instance, we need scheduler which stick with one thread, we can't get it's queue 'case it doesn't use any. There is sync and async versions for main scheduler(and again, we are talking about Schedulers, provided out of the box), but Alamofire wouldn't respect this distinction.
As I said earlier: we don't use this queue for any Rx-related work, we just pass to non-rx world. We don't even guarantee, that each element will be emitted on this scheduler(because we has dependency on Alamofire implementation). If user really want to use scheduler - he can just observeOn it any rx-chain he want, but he can't avoid dispatching to main queue for now.
Anyway, I remember about tests and moving queue to MoyaProvider :)

Yeah I agree. The queue passed to Alamofire doesn't necessarily have to be the same one as our Reactive Scheduler, all that really matters is that we provide this init option so people can move their request building/handling off of the main queue and into a dedicated background queue (if desired).

Codecov Report

Merging #1055 into optional-response-thread-param will decrease coverage by 0.25%.
The diff coverage is 55.55%.

@@                        Coverage Diff                         @@
##           optional-response-thread-param    #1055      +/-   ##
==================================================================
- Coverage                           73.65%   73.39%   -0.26%
==================================================================
  Files                                  22       22
  Lines                                 725      733       +8
==================================================================
+ Hits                                  534      538       +4
- Misses                                191      195       +4

Impacted Files
Coverage Δ

Sources/RxMoya/RxMoyaProvider.swift
42.85% <55.55%> (+0.75%)
:arrow_up:

...urces/ReactiveMoya/ReactiveSwiftMoyaProvider.swift
52.38% <55.55%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c33fe0...6413b8d. Read the comment docs.

Hmm, any clue why tests failed? I can't even open log. By the way, i added tests for MoyaProvider RxMoyaProvider and moved queue to MoyaProvider. Deprecate approach doesn't work as i expected(swift can't choose proper overload)

@haritowa: yeah, CI failed because there's no changelog for this. We're working on making that more clear to contributors.
For now, can you just add an entry to the changelog, and then we can see how the tests do?

@AndrewSB Oh i see, i was afraid you just give up on this PR :) Ok, i'll update changelog

I got really busy with work, sorry about that @haritowa!

@AndrewSB It's ok, I'm busy on weekdays too :)

@AndrewSB Aaaaand... it's done :)

I'm wondering if the parameter name queue isn't too vague and e.g. callbackQueue wouldn't help with recognizing for what exactly is this queue used. Thoughts?

@sunshinejr I took this name from original request method, but I'm agree, callbackQueue would be much better(I believe "queue" parameter name misleading even in request method)

Cool! What do you guys think @AndrewSB, @justinmakaila?

Yes, I think callbackQueue is a better name. It takes away any ambiguity.
@haritowa, do you think we can improve the queue parameter in the request method as well?

@BasThomas Yep, I think so. In method context queue is less confusing, but still does not provide any clue about its mission

What do you think is a better option?

I prefer slightly more verbose callbackQueue

The CI failure is legit, seems like RxSwiftMoyaProviderTestsneeds a second review 😄

that was broken by me -- I'll fix it now. Sorry!

Seems like @AndrewSB fixed the build! Things to do before the merge:

Fix the Chanelog.md conflicts (basically add the new line to Next column instead of 8.0.4, because 8.0.4 was released)
Change the name of queue to callbackQueue (wherever we can)

Does that seem right? 😄

yup, that does! Then we can figure out docs and usage instructions in #762

@haritowa Are these two points, I wrote above, something you have time to do in the near future? If not, I might try to help :)

@sunshinejr @AndrewSB @haritowa I fixed the conflict in the changelog (used Github web interface to do it, that's why the commit message is bad 😕 )
Does it make sense to merge this PR into optional-response-thread-param and take the queue renaming (and docs) in #762? 🤔

I think so 👍 Probably in another PR tho, that would point to optional-response-thread-param. But I'm in.

Yeah, lets merge this into optional-response-thread-param, and then do another PR also targeted to optional-response-thread-param that handles the renaming and docs 👌

Thanks a lot for contributing to Moya! I've invited you to join the Moya GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.


args don't need to be their own modle

Got to go through and clear it all up!
Yeay - code tidy.
It'll make life easier when saving / updating drafts / claims

Drafts reference for reasons - they can be either claims or draftClaims.
Maybe introduce a 'reason' modle as a placeholder?  Then on publish, server side reasons can be replaced with any published claims that match...
Drafts don't need a reason ref model then - just the placeholder content.  Means it won't update status automatically when loaded - will have to do that manually, use the reference data to go ask the db for a list of stats then update.  Either on a timer, or with an update button.
Tricky one!


This module appears to be failing tests due to missing MONKEY-SEE-NO-EVAL

% zef install YAML
===> Searching for: YAML
===> Testing: YAML
=== Test Dumping Perl 6 Data Objects to YAML ===
===SORRY!=== Error while compiling /Users/cal/.zef/store/yaml-pm6.git/69c454f2f0c95cabf2f18df8759a2c8b29d1cdb3/t/Bridge.pm (t::Bridge)
EVAL is a very dangerous function!!! (use the MONKEY-SEE-NO-EVAL pragma to override this error,
but only if you're VERY sure your data contains no injection attacks)
at /Users/cal/.zef/store/yaml-pm6.git/69c454f2f0c95cabf2f18df8759a2c8b29d1cdb3/t/Bridge.pm (t::Bridge):8
------>     return EVAL $this.value⏏;

  in method _transform_modules at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 225
  in method transform_modules at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 87
  in method get_transform_function at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 201
  in method evaluate_expression at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 167
  in block  at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 105
  in method run at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 100
  in block <unit> at t/dump.t line 5

t/dump.t ..... All 13 subtests passed
=== Failing Tests For People to Hack On ===
===SORRY!=== Error while compiling /Users/cal/.zef/store/yaml-pm6.git/69c454f2f0c95cabf2f18df8759a2c8b29d1cdb3/t/Bridge.pm (t::Bridge)
EVAL is a very dangerous function!!! (use the MONKEY-SEE-NO-EVAL pragma to override this error,
but only if you're VERY sure your data contains no injection attacks)
at /Users/cal/.zef/store/yaml-pm6.git/69c454f2f0c95cabf2f18df8759a2c8b29d1cdb3/t/Bridge.pm (t::Bridge):8
------>     return EVAL $this.value⏏;

  in method _transform_modules at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 225
  in method transform_modules at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 87
  in method get_transform_function at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 201
  in method evaluate_expression at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 167
  in block  at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 105
  in method run at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 100
  in block <unit> at t/fail.t line 5

t/fail.t ..... All 1 subtests passed
=== Various String Quoting ===
===SORRY!=== Error while compiling /Users/cal/.zef/store/yaml-pm6.git/69c454f2f0c95cabf2f18df8759a2c8b29d1cdb3/t/Bridge.pm (t::Bridge)
EVAL is a very dangerous function!!! (use the MONKEY-SEE-NO-EVAL pragma to override this error,
but only if you're VERY sure your data contains no injection attacks)
at /Users/cal/.zef/store/yaml-pm6.git/69c454f2f0c95cabf2f18df8759a2c8b29d1cdb3/t/Bridge.pm (t::Bridge):8
------>     return EVAL $this.value⏏;

  in method _transform_modules at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 225
  in method transform_modules at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 87
  in method get_transform_function at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 201
  in method evaluate_expression at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 167
  in block  at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 105
  in method run at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A182E9F733D1C685F9F4F998B3332FE5B493FEBB (TestML::Runner) line 100
  in block <unit> at t/strings.t line 5

t/strings.t .. All 3 subtests passed
All tests successful.

Test Summary Report
-------------------
t/dump.t  (Wstat: 0 Tests: 0 Failed: 0)
  Parse errors: Bad plan.  You planned 13 tests but ran 0.
t/fail.t  (Wstat: 0 Tests: 0 Failed: 0)
  Parse errors: Bad plan.  You planned 1 tests but ran 0.
t/strings.t (Wstat: 0 Tests: 0 Failed: 0)
  Parse errors: Bad plan.  You planned 3 tests but ran 0.
Files=3, Tests=0,  3 wallclock secs
Result: FAILED
===> Testing [FAIL]: YAML
Aborting due to test failure: YAML (use --force to override)
  in code  at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/1DC0BAA246D0774E7EB4F5119C6168E0D8266EFA (Zef::Client) line 306
  in method test at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/1DC0BAA246D0774E7EB4F5119C6168E0D8266EFA (Zef::Client) line 285
  in code  at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/1DC0BAA246D0774E7EB4F5119C6168E0D8266EFA (Zef::Client) line 457
  in sub  at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/1DC0BAA246D0774E7EB4F5119C6168E0D8266EFA (Zef::Client) line 454
  in method install at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/1DC0BAA246D0774E7EB4F5119C6168E0D8266EFA (Zef::Client) line 560
  in sub MAIN at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/sources/A9948E7371E0EB9AFDF1EEEB07B52A1B75537C31 (Zef::CLI) line 123
  in block <unit> at /usr/local/Cellar/rakudo-star/2017.01/share/perl6/site/resources/3DD33EF601FD300095284AE7C24B770BAADAF32E line 1

zef install YAML  14.73s user 0.85s system 100% cpu 15.516 total
% perl6 --version
This is Rakudo version 2017.01 built on MoarVM version 2017.01
implementing Perl 6.c.
%

Fixed this one. Thanks.


amplify init "type of app" doesn't actually allow selection Windows 10

Do you want to request a feature or report a bug? Bug
What is the current behavior?
When I do amplify init, it asks the first question about editor and I am able to select an editor. The next question about type of app I don't have a chance to answer. Note below that it looks like I picked javascript, but actually I just got my os prompt back
PS C:\Users\bradt\Documents\cs\react\my-amplify-app> amplify init
Note: It is recommended to run this command from the root of your app directory
? Choose your default editor: Visual Studio Code
? Choose the type of app that you're building (Use arrow keys)
  android
  ios
> javascript
PS C:\Users\bradt\Documents\cs\react\my-amplify-app>

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

Run amplify init
Select editor
Notice no change to select type of app

What is the expected behavior?
Should be able to select app type
Which versions of Amplify CLI, and which  OS are affected by this issue? Did this work in previous versions?
Windows 10, latest version of Amplify CLI that gets installed (0.1.14)

Can confirm that this isn't just on init.  Any time there is a prompt, the choice fails out and kicks you back to the shell without letting you continue selecting choices.  I believe something is silently failing.

Hey guys, so I tried using the CLI with the Windows Linux subsystem(WSL) on windows and it works great. We have updated our main README as well with the following. Highly encourage using the WSL for your Amplify development.

If you're using Windows, the CLI currently supports [Windows Subsystem for Linux](https://docs.microsoft.com/en-us/windows/wsl/install-win10).

In the meanwhile, we're trying to figure out the root cause of the erroneous behavior of the CLI with the windows filesystem.

For reference, the option selection works for me in Powershell. Might be worth a try as an alternative to CMD?

@mwarger No, I haven't had any issues with the actual interactions. What key are you pressing for selection? Spacebar?

@wstidolph  checkout @mwarger  post on using Windows Linux Subsystem(WSL) on native windows power shell out here - https://github.com/aws-amplify/amplify-cli/issues/13. I think it’s a great workaround and would highly recommend using WSL for the Amplify CLI.

@kaustavghosh06  - I believe this has been resolved with a recent release.

@mwarger @kaustavghosh06 @wstidolph This is possible that my recent changes to gluegun fixed it on Windows. I would be interested to know if that's not the case. I'm pretty sure I can fix that issue.

I think it did. I was able to install on a new machine a couple days ago and was able to make selections without any issues.

I just tried with latest amplify-cli and init exits at frontend plugin selection.
I patched the sources to remove the frontend step and the issue is the same, it sliently exits.
So the issue is that the 2nd option is always exits. I tried to put the latest gluegun into the cli's node_modules dir, that did not help either.

@stevegula  @attilah Are you using windows without WSL?

@kaustavghosh06 yes, I tried in "windows windows", in WSL on the same machine, everything works...WSL is "not windows".

@attilah We have an issue open with our dependent CLI framework for making it work on windows natively and are actively working with them to get the fix out. Until then we recommend using WSL.

@kaustavghosh06 I tried the @next from that cli library where the "path fix" was included and still had the same problem, but ok, let's wait. The problem is that working with WSL and Windows is not going back and forth, since some generated files are including the absolute path on the host machine /home/xyz/....... which does not map to the same location under Windows...
But sure working purely in WSL could do the trick.

Same!
amplify -v
0.1.28
node -v
v10.10.0
PS C:\Projetos> amplify init
Note: It is recommended to run this command from the root of your app directory
? Choose your default editor: Visual Studio Code
? Choose the type of app that you're building (Use arrow keys)
android
ios

javascript
PS C:\Projetos>

@stevegula @attilah Are you using windows without WSL?

Correct, I'm not using the Linux subsystem.

We published a new version of the CLI to npm, version -> 0.1.32 with fixes for windows. Feel free to re-open the issue if the problem still persists.

@kaustavghosh06 This has not fixed the issue. I have clean installed these and am still not able to run the commands.

@bghtbb can do run ‘amplify -v’ and check which version of the CLI you’re using?

@kaustavghosh06 0.1.32

I still get this exact same issue on Node v11.6.0, Amplify 0.1.38 and Widows 10. It doesn't make a difference if amplify is used from the local node_modules or global installation.

I don't think this problem is something in regards to Amplify CLI itself but maybe to do with inquirer dependency which leverages the prompt.
https://github.com/aws-amplify/amplify-cli/blob/b12d20b9d85f7fc6abf7e2f7fbe11e1a108911b9/packages/amplify-cli/src/lib/init-steps/s1-initFrontendHandler.js#L35
Just as a friendly road sign, I'd recommend if you can on Windows 10 to leverage the Ubuntu subsystem as a workaround for now. I'm still running into the issue in PowerShell but had success utilizing the subsystem without any issue.
Going to be digging into that dependency package and see if I can figure out the why? to the uh?
Best wishes everyone!

I finally got it working, just leaving this here in case it helps anyone else.
Using WSL did not make a difference. I also tried using several different command windows and shells (Powershell, cmd, cmder, Consolez, bash) and none if it made a difference. I also tried running a linux terminal using docker (docker -it) and running amplify init in there, and still I would have the exact same issue.
How I eventually got it working is that I switched from using yarn to npm. Using npm with a global install of @aws-amplify/cli works now, and I can choose the app type on the second step of amplify init.


Remove CodeStaturn worlkflow from release

related to the removing the openstack option

:+1:  even

closed with #468 (why github isn't autoclosing these: is it because we're merging to the release branch instead of the master?

Probably


[FEATURE]: restart cancel event

Scope
Developer API
Feature Description
we now can cancel the restart time or put custom restart time but most scripts used a restart timer for closing and saving when someone does that and then cancel that script goes into problems because there is no way to find the restart time that got canceledscripts
Use Case
No response
Proposed Solution
You can give restarts if like a number or random string then pass that to txAdmin:events:scheduledRestart in eventData so we store now current restart id as something like id 3 so then user cancel restart another event get trigger like txAdmin:events:cancelScheduledRestart and pass canceled restart id so the script can handle to don't do closing or saving prosses
Additional Info
No response

Done https://github.com/tabarra/txAdmin/commit/dd87516c527bcf01f14fe5420d450f9689150771


Icon coloring conflicts

When embedding multiple SVGs using react-inline svg, their are color conflicts because of the style class names contained within the <svg> tag:
Example of issue:

As you can see, the bottom icon colors are being applied to the top icons, and vice versa.
The correct colors should look like this:

What I believe is happening is that the styles from one SVG are the same as another.

Is there a way for react-inlinesvg to parse out the SVG styles and apply a unique key to them to they do not conflict?

I think I'm encountering similar issues with gradients. Have you tried exporting in SVG format with no style classes? (Not user if you can do this, but some of the AI  style formats seem to work better at least for me.

@axertion I imagine that we could have a classPrefix prop, but this kind of parsing is usually error-prone.

My issue was diffrent, probably caused by non-unique ID's in svg files repeated several times. using key= fixed it somehow.

@axertion have you tried exporting CSS differently:

spring cleaning


Suggestion: add something about SharePoint

Like
CVE-2020-0932
CVE-2019-1257
CVE-2019-0604
When you pwned the SharePoint, you get more domain accounts
ref https://www.zerodayinitiative.com/blog?tag=SharePoint

Thanks for the suggestions, i will add it asap :)


Help, i can't run your code

Dear @Chanzhaoyu,
I changed my API but not run, nomarl port also port 3002. Localhots the same, please help me :)

![1](https://user-images.git

Many Thanks
BR,

well, you can comment out unused nodes, here is an example
      # 二选一
      OPENAI_API_KEY: sk-rx
      # 二选一
      #OPENAI_ACCESS_TOKEN: xxx
      # API接口地址，可选，设置 OPENAI_API_KEY 时可用
      #OPENAI_API_BASE_URL: xxx
      # API模型，可选，设置 OPENAI_API_KEY 时可用
      OPENAI_API_MODEL: gpt4
      # 反向代理，可选
      #API_REVERSE_PROXY: xxx
      # 访问权限密钥，可选
      AUTH_SECRET_KEY: YourSecretKey
      # 每小时最大请求次数，可选，默认无限
      MAX_REQUEST_PER_HOUR: 2000
      # 超时，单位毫秒，可选
      TIMEOUT_MS: 60000
      # Socks代理，可选，和 SOCKS_PROXY_PORT 一起时生效
      #SOCKS_PROXY_HOST: xxx
      # Socks代理端口，可选，和 SOCKS_PROXY_HOST 一起时生效
      #SOCKS_PROXY_PORT: xxx
      # HTTPS 代理，可选，支持 http，https，socks5
      #HTTPS_PROXY: http://xxx:7890

You exposed your key, so I deleted the picture.
Is this GitHub Pages?
Have you tried to run locally?

GitHub Pages is not applicable to this project.

whose key?

You exposed your key, so I deleted the picture.
Is this GitHub Pages?
Have you tried to run locally?

I also can't run locally. Maybe i unclear about Vue, i'm newcomer, please Admin, thanks :)

根目录 pnpm bootstrap
service 目录 pnpm install
service/.env.example 修改为 service/.env
填入你的 key
根目录运行 pnpm dev
service 运行 pnpm start
打开 http://loclhost:1002

你试试本地是否可行？

root directory run pnpm bootstrap

service directory run pnpm install

service/.env.example modified to service/.env

enter your key

root directory run pnpm dev

service directory run pnpm start

open http://loclhost:1002/

Do you want to try it locally?

If you really can't, you can try Railway.

Changing the network, I have the same problem as you. Mobile phone access is OK, computer end is always not good, finally my computer closed agent access immediately normal.

If you really can't, you can try Railway.
openai会ban railway部署的号了，要不支持一下别的平台比如cloudflare的或者aws的apprunner

i alos cant run it locally ,

But my account Github and Railway not verifed, please help me solutions, many thanks :)

But my account Github and Railway not verifed, please help me solutions, many thanks :)

please help me

what's your server system version. have you tried docker-compose?


Fix typo in agentchat_MathChat.ipynb

Why are these changes needed?
requries -> requires
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report

Merging #191 (3116fe1) into main (fa6e2a5) will decrease coverage by 2.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   43.75%   41.33%   -2.43%
==========================================
  Files          17       17
  Lines        2105     2105
  Branches      470      470
==========================================
- Hits          921      870      -51
- Misses       1103     1149      +46
- Partials       81       86       +5

Flag
Coverage Δ

unittests
41.33% <ø> (-2.33%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


fix uart

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.14 out of 15 committers have signed the CLA.:white_check_mark: lqq96:white_check_mark: wosayttn:white_check_mark: wanghf16:white_check_mark: Cheng-SG:white_check_mark: hellozwj:white_check_mark: librae8226:white_check_mark: shaoguoji:white_check_mark: fredchenams:white_check_mark: LizhenADI:white_check_mark: xiaowenxia1:white_check_mark: zejiangfish:white_check_mark: xinhuiding:white_check_mark: NashZhangMCHP:white_check_mark: xuhongv:x: magao.xwjmagao.xwj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@kyliuxing  please check what you want to push,this patch seems include many commits from others, please double confirm


chore(main): release 1.3.1

:robot: I have created a release beep boop
1.3.1 (2024-07-04)
Performance Improvements

build working (450d6a1)
create a gh pages with assets (48b383d)
remove favicon (cba225d)
remove favicon (3a4b7f1)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.3.1
:sunflower:


Uninline double and float values

This PR uninlines commonly used values, such as mutations of pi and e. This greatly improves code readability in the decompiled output.

How about half multiples of pi, and other fractions, for common angles? 30 degrees = pi/6, 45 degrees = pi/4, 60 degrees = pi/3, 90 degrees = pi/2, 270 degrees = pi*3/2, etc

Yeah, I think it'd be worthwhile to add all the common ones from the unit circle


HBASE-26160: Configurable disallowlist for live editing of loglevels

Backports https://github.com/apache/hbase/pull/3549 to branch-2.4

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

-0 :warning:
yetus
0m  8s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
branch-2.4 passed

+1 :green_heart:
compile
0m 21s
branch-2.4 passed

+1 :green_heart:
shadedjars
6m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
0m 22s
the patch passed

+1 :green_heart:
javac
0m 22s
the patch passed

+1 :green_heart:
shadedjars
6m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 53s
hbase-http in the patch passed.

24m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3558

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 490f0b1e6c08 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 13b3d93750

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/testReport/

Max. process+thread count
547 (vs. ulimit of 12500)

modules
C: hbase-http U: hbase-http

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
4m 37s
branch-2.4 passed

+1 :green_heart:
compile
0m 23s
branch-2.4 passed

+1 :green_heart:
shadedjars
6m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  7s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 59s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 43s
hbase-http in the patch passed.

26m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3558

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5bbfe2970ffa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 13b3d93750

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/testReport/

Max. process+thread count
524 (vs. ulimit of 12500)

modules
C: hbase-http U: hbase-http

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
3m 50s
branch-2.4 passed

+1 :green_heart:
compile
0m 34s
branch-2.4 passed

+1 :green_heart:
checkstyle
0m 15s
branch-2.4 passed

+1 :green_heart:
spotbugs
0m 40s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
0m 32s
the patch passed

+1 :green_heart:
javac
0m 32s
the patch passed

-0 :warning:
checkstyle
0m 14s
hbase-http: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 38s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

37m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3558

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 5fb32e62320f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 13b3d93750

Default Java
AdoptOpenJDK-1.8.0_282-b08

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt

Max. process+thread count
96 (vs. ulimit of 12500)

modules
C: hbase-http U: hbase-http

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3558/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Fix a bug where a request is sent with an empty :path pseudo-header.

Motivation:
When a request is sent with absolute URI that does not contrains path,
var client = WebClient.of();
client.get("https://google.com").aggregate();

then the request is failed with:
Caused by: com.linecorp.armeria.common.stream.ClosedStreamException: received a RST_STREAM frame: PROTOCOL_ERROR

The request is rejected by remote peers because it has an empty :path pseudo-header.
From the HTTP/2 spec,

This pseudo-header field MUST NOT be empty for "http" or "https"
URIs; "http" or "https" URIs that do not contain a path component
MUST include a value of '/'.

Modifications:

Set path to / if it is empty

Results:
Armeria client sets the default path(/) properly if it is empty.

/cc @techno (who reported this issue)


transparently streaming log to file

also implement a filesize limit, since we cannot 'delete' the start of a file, maybe have two files, when the first grows to the limit, rename it, and delete any existing file with the destination name.
Open question: do we want a new thread to do this?

New proposal:

no filesize limit
no 'new logfile' every day
no history depth
no differences per logfile/ per view

Instead offer one option:  File->Stream to disk
Just transparently stream message to files, start a new file every n-lines (say 20.000) like:
logfilename_timestamp_block_1.dblog
logfilename_timestamp_block_2.dblog
logfilename_timestamp_block_3.dblog
this way memory consumption will be limited to indexes for the views only.
the files would be written continuously until the N-line limit is reached.
If the view want to 'scroll back', it can just open de correct file by looking it up:
block = (linenr / 20.000) + 1
problem: sometimes debugview will need to read+write from the same file, and sometimes, it read from one file and writes to another.
(suppose you're viewing line 20,010 which is logfilename_timestamp_block_2.dblog and writing new incoming messages to logfilename_timestamp_block_3.dblog


upload addon missing from download options

https://caddyserver.com/docs/upload says, "To get it, select this feature when you download Caddy."
But https://caddyserver.com/download doesn't offer "upload" as a choice of directives.

Yeah, we're working on it - will probably be there when the next release of Caddy is out. We've had a few issues but they don't appear to manifest on Linux which is what the build server runs, so... I guess I can just hope it works without testing it locally... 😛


[TASK] Build a CI pipeline to mirror all CSI dependence images to longhornio DockerHub repo

What's the task? Please describe.
When we update CSI dependent components to newer versions, we want to retag and publish those upstream images to longhornio DockerHub repo.
Since we might need to do this every time we raise the version for those components, we want to build a Drone pipeline for this process.
Note: The CSI dependent images are multi-arch so we need to make sure the retag images are also multi-arch including amd64, arm64 and s390x

@meldafrawi Please try to leverage this script if possible. https://github.com/rancher/image-mirror/blob/master/image-mirror.sh

We need to clone s390x CSI images from upstream as well to support #3425

Do we want to watch this longhorn-images.txt file inside longhorn/longhorn-manager repo instead because it will be updated first before the file with the same name is updated inside longhorn/longhorn repo?

Do we want to watch this longhorn-images.txt file inside longhorn/longhorn-manager repo instead because it will be updated first before the file with the same name is updated inside longhorn/longhorn repo?

Good idea :+1:
@yangchiu Let's enhance this later, but create another ticket to track. Thank you.

Do we want to watch this longhorn-images.txt file inside longhorn/longhorn-manager repo instead because it will be updated first before the file with the same name is updated inside longhorn/longhorn repo?

Good idea +1
@yangchiu Let's enhance this later, but create another ticket to track. Thank you.

#3914 has been created for this.

The jenkins pipeline has been implemented: https://ci.longhorn.io/job/private/job/mirror-csi-images/


GMU-41: json-path 2.9.0, guava 33.0.0-jre fixing vulns

Upgrade json-path from 2.8.0 to 2.9.0 fixing Buffer Overflow: https://nvd.nist.gov/vuln/detail/CVE-2023-51074 generate-marc-utils' code doesn't use the affected method.
Upgrade guava from 30.1-jre to 33.0.0-jre fixing Information Disclosure: https://nvd.nist.gov/vuln/detail/CVE-2020-8908 , https://nvd.nist.gov/vuln/detail/CVE-2023-2976 generate-marc-utils' code doesn't use the affected method.

Looks like unit tests aren't passing


feat(charts): Add optional syslog endpoint setting to fluentd

PR https://github.com/deis/fluentd/pull/72

related: #630
Depending on what's merged first, we'll have to update the documentation as well.

I'll let someone else merge it if someone else feels my comment is invalid/bikeshedding at this point. :)


docs changes

Deployed pages change
UG updates + clean up
UI.png updated

Pull Request Test Coverage Report for Build 366

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.906%

Totals

Change from base Build 365:
0.0%

Covered Lines:
1632

Relevant Lines:
3337

💛  - Coveralls


Add version indicator

Without a version indicator or hash it is hard to determine which version of the application is being run.

Fixed in #47 .


Implememting Kakao maps

Coming from google maps, I have to ask, any example of implementing the kakao maps api?
I have a use case where I have coordinates of two places, I want to create a polyline of these two places.
Is this even possible with this SDK?

@ericel That is not possible with this SDK. Can you look into https://pub.dev/packages/flutter_kakao_map?
This SDK aims to handle only Kakao API and necessary functionalities (OAuth) to use the API. Map SDK requires native libraries and this is not something that this SDK wants to maintain.
If this answer satisfies your question, please close this issue :)

@ericel That is not possible with this SDK. Can you look into https://pub.dev/packages/flutter_kakao_map?
This SDK aims to handle only Kakao API and necessary functionalities (OAuth) to use the API. Map SDK requires native libraries and this is not something that this SDK wants to maintain.
If this answer satisfies your question, please close this issue :)


Email addresses are logged in clear text by default

For many applications, client-identifying information can be sensitive, and should not be exposed in log files.
Describe the bug
Email addresses are logged at the "info" level and visible in clear text.
To Reproduce
Set log level to "info" and send an email with lettre.
Expected behavior
Email addresses are private and should not be shown in logs by default, regardless of global log settings.

Indeed, we should make logging configurable and disable address logging by default