need improvements

osm api as documentation create nodes and add ref to way to create. is  it posible single request for way with nested nodes to create with lat lngs. so it create nodes and way create at once so that using way id later request full to get all node ids. and also include nd ref to pass already exist node.

...
        //existing node

...
   // new node to create

...

in id editer provide id number on select any node or way exist. provide edit mode and insert mode to stop mistakenly modify existing. because any node created at intersection drag or delete can cause change old exit way or node

I do not understand what that issue is about.

I'm afraid I don't understand your issue either. I can read your words, but nothing more. So this is a wild guess at the first part of your text:
You can upload new nodes and ways (which referece those new nodes) via the API 0.6 changeset upload endpoint. This is what iD is already doing. The API also provides an endpoint to fetch a way including all nodes: https://api.openstreetmap.org/api/0.6/way/4972913/full - this is however out of scope for iD.

Hi @prasadrajuv. I'm also not exactly sure what you're asking, but I'll try to answer.
You've asked before about seeing node IDs in #7546.
You can ask about the OSM API at https://github.com/openstreetmap/openstreetmap-website.
We don't plan to add advanced functionality like inserting nodes with specific IDs or manually managing modification histories.


outlier_detection: add optional random jitter to ejection time

Signed-off-by: asheryer<EMAIL_ADDRESS>
Commit Message: This commit adds a configuration that allows you to add a random jitter to the ejection time of outliers
Additional Description: This feature is aimed at preventing connection storms where thousands of hosts are unejected
at the same time. Specifically, we have seen this issue in AWS where thousands of Envoys are connected to a Redis node and are all unejected at the same time. This creates a 'connection storm' and overwhelms the redis-server. The default value of the jitter is zero. This makes it backward compatible and will not break
existing deployments. The configuration allows you to define a maximum jitter value. For example, if you set the
maximum jitter value to 10s, a random value between 0s and 10s will be added to the ejection time of every host,
thus preventing them from possibly all being unejected at the same time.
Risk Level: Low
Testing: Has been tested with a redis cluster with several dozen envoys connected to it. Coverage tests performed
as well. Has also been tested with Envoy running on Docker. We also tested the default behaviour where the configuration is not present, in this scenario the max_jitter defaults to 0, and everything behaves exactly as it did before.
Docs Changes:
Inline documentation in api/envoy/config/cluster/v3/outlier_detection.proto
Documentation added to docs/root/configuration/upstream/cluster_manager/cluster_runtime.rst
Release Notes:
Listed the change in docs/root/version_history/current.rst
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/lgtm api
/retest

LGTM changes.
We'll run the tests again, but maybe you'll need to merge main to get this solved.
/retest

CI verify-examples seems to be flaky (not related to this PR)
/retest

Thanks for your patience!
Merging per Matt's comment.


Train Image Clasification Model in Azure: Iteration Timeout

System Information (please complete the following information):

Model Builder Version: <IP_ADDRESS>7905
Visual Studio Version: 4.8.04161

Describe the bug

On which step of the process did you run into an issue:
When the Image Recognition Scenario is training on Azure
Clear description of the problem:
After +90 minutes of training the IDE shows the error below. I'm also attaching the full log.
77341910-1b12-40ce-a75b-ba4802ee1a37.txt

To Reproduce
Steps to reproduce the behavior:

Create a new Image Clasification scenario
Select an Azure Environment
Uses local images to train the model. ~1GB of images from the Distracted Driver Detection Challenge from Kaggle. https://www.kaggle.com/c/state-farm-distracted-driver-detection
See error

Completed a training run
Downloading best model to C:\Users\bruno\AppData\Local\Temp\MLVSTools\MLNet ModelBuilderML\MLNet ModelBuilderML.Model\bestModel.onnx..
Object reference not set to an instance of an object.
at AzureML.AutoMLRunnerImages.d__27.MoveNext() in //src/Microsoft.ML.ModelBuilder.AutoMLService/RemoteAutoML/AutoMLRunnerImages.cs:line 237
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.ML.ModelBuilder.AutoMLService.Experiments.AzureImageClassificationExperiment.d__13.MoveNext() in //src/Microsoft.ML.ModelBuilder.AutoMLService/Experiments/AzureImageClassificationExperiment.cs:line 69
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.ML.ModelBuilder.AutoMLEngine.d__26.MoveNext() in /_/src/Microsoft.ML.ModelBuilder.AutoMLService/AutoMLEngineService/AutoMLEngine.cs:line 134
Screenshots
On the Azure Portal the run shows the following iteration timeout error

Reference Id: AutoML_0affc79b-87bd-421b-a213-73e46f9a02f7
Additional context
Add any other context about the problem here.

Is there a new update on this? It's pretty common and reproducable with all data sets above 2k images.


Missing Support for ForwardConfig in AWS::ElasticLoadBalancingV2::ListenerRule

cfn-lint version: (cfn-lint 0.26.0)
Description of issue.
Receive a rule failure when using a ForwardConfig in a Listener Rule to configure weighted target group traffic routing. I believe the spec file is missing the ForwardConfig option.
E3002 Invalid Property Resources/ListenerRule1/Properties/Actions/0/ForwardConfig
Please provide as much information as possible:

Template linting issues:

Please provide a CloudFormation sample that generated the issue.

AWSTemplateFormatVersion: '2010-09-09'
Parameters:
  TargetGroup1:
    Type: String
  TargetGroup2:
    Type: String
  Listener:
    Type: String
Resources:
  ListenerRule1:
    Type: AWS::ElasticLoadBalancingV2::ListenerRule
    Properties:
      Actions:
        - Type: forward
          ForwardConfig:
            TargetGroups:
              - TargetGroupArn: !Ref 'TargetGroup1'
                Weight: 1
              - TargetGroupArn: !Ref 'TargetGroup2'
                Weight: 1
      Conditions:
        - Field: path-pattern
          Values:
            - foo
      ListenerArn: !Ref 'Listener'
      Priority: 99

If present, please add links to the (official) documentation for clarification.

https://aws.amazon.com/blogs/aws/new-application-load-balancer-simplifies-deployment-with-weighted-target-groups/

Validate if the issue still exists with the latest version of cfn-lint and/or the latest Spec files

Exists in version 0.26.0 and after updating specfile with cfn-lint -u

Confirmed.  @PatMyron should we patch this in or do you want to check if it will be fixed soon.  I'm submitting a pull request with the version 10.1.0 and it is also not in that one.

Actually don't even see that property documented yet
@MattGirolami did that template successfully deploy?
Looks like there was some CloudFormation work involving ForwardConfig recently, so it might be another case of https://github.com/aws-cloudformation/cfn-python-lint/issues/1219

@PatMyron - Yes, the example template deploys successfully. I'm actively using  ForwardConfig in production to weight traffic between multiple target groups

cfn-lint --update-specs should fix this now


sonic-pi: 2.9.0 -> 3.0.1

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

What else do I need to test this? Currently it is outputting this error message:
Sonic Pi Boot Error Report
System Information

Sonic Pi version: 3.0.1
OS: NixOS 18.03.git.5ed6372 (Impala)

GUI Log
/home/joerg/.sonic-pi/log/gui.log
[GUI] - Detecting port numbers...
[GUI] - GUI OSC listen port 4558
[GUI] -    port: 4558 [OK]
[GUI] - Server OSC listen port 4557
[GUI] -    port: 4557 [OK]
[GUI] - Server incoming OSC cues port 4559
[GUI] -    port: 4559 [OK]
[GUI] - Scsynth port 4556
[GUI] -    port: 4556 [OK]
[GUI] - Server OSC out port 4558
[GUI] - GUI OSC out port 4557
[GUI] - Scsynth send port 4556
[GUI] - Erlang router port 4560
[GUI] -    port: 4560 [OK]
[GUI] - OSC MIDI out port 4561
[GUI] -    port: 4561 [OK]
[GUI] - OSC MIDI in port 4562
[GUI] -    port: 4562 [OK]
[GUI] - Init script completed
[GUI] - using default editor colours
[GUI] - launching Sonic Pi Server:
[GUI] - starting UDP OSC Server on port 4558...
[GUI] - UDP OSC Server ready and listening
[GUI] - Ruby server pid registered: 19298
[GUI] - waiting for Sonic Pi Server to boot...
............................................................
[GUI] - Critical error! Could not boot Sonic Pi Server.
[GUI] - stopping UDP OSC Server...
[GUI] - UDP OSC Server no longer listening

Server Errors
/home/joerg/.sonic-pi/log/server-errors.log
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
terminate called without an active exception

Server Output
/home/joerg/.sonic-pi/log/server-output.log
Sonic Pi server booting...
Using protocol: udp
Detecting port numbers...
Send port: 4558
Listen port: 4557
  - OK
Scsynth port: 4556
  - OK
Scsynth send port: 4556
  - OK
OSC cues port: 4559
  - OK
Erlang port: 4560
  - OK
OSC MIDI out port: 4561
  - OK
OSC MIDI in port: 4562
  - OK
Booting server...

Booting Sonic Pi
----------------

Booting on Linux
Jackd not running on system. Starting...
Boot - Starting the SuperCollider server...
Boot - scsynth -u 4556 -m 131072 -a 1024 -D 0 -R 0 -l 1 -i 16 -o 16 -b 4096
Started [19334] [-] scsynth -u 4556 -m 131072 -a 1024 -D 0 -R 0 -l 1 -i 16 -o 16 -b 4096 [-] /run/user/1000/sonic-pi-pids/19334
Failed to start server: SIGTERM
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/util.rb:553:in `wait'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/util.rb:553:in `kill_and_deregister_process'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/scsynthexternal.rb:224:in `rescue in boot_and_wait'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/scsynthexternal.rb:221:in `boot_and_wait'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/scsynthexternal.rb:382:in `boot_server_linux'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/scsynthexternal.rb:151:in `boot'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/scsynthexternal.rb:37:in `initialize'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/server.rb:77:in `new'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/server.rb:77:in `initialize'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/studio.rb:183:in `new'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/studio.rb:183:in `init_scsynth'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/studio.rb:56:in `initialize'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/lang/sound.rb:125:in `new'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/server/sonicpi/lib/sonicpi/lang/sound.rb:125:in `block (2 levels) in included'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/gui/qt/../../../app/server/bin/sonic-pi-server.rb:177:in `new'
/nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/gui/qt/../../../app/server/bin/sonic-pi-server.rb:177:in `<main>'
Server is exiting.
Shutting down GUI...
Goodbye :-)

Scsynth Output
/home/joerg/.sonic-pi/log/scsynth.log
# Starting SuperCollider 2017-10-06 09:18:33
could not initialize audio.

Process Log
/home/joerg/.sonic-pi/log/processes.log

Clearing pids: []
No pids to clear :-)
Started [19298] [-] ruby -E utf-8 /nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/gui/qt/../../../app/server/bin/sonic-pi-server.rb -u 4557 4558 4556 4556 4559 4560 4561 4562 [-] /run/user/1000/sonic-pi-pids/19298
Started [19334] [-] scsynth -u 4556 -m 131072 -a 1024 -D 0 -R 0 -l 1 -i 16 -o 16 -b 4096 [-] /run/user/1000/sonic-pi-pids/19334

Clearing pids: ["19334", "19298"]

Clearing [19334]
  -- command scsynth -u 4556 -m 131072 -a 1024 -D 0 -R 0 -l 1 -i 16 -o 16 -b 4096
  -- removing /run/user/1000/sonic-pi-pids/19334

Clearing [19298]
  -- command ruby -E utf-8 /nix/store/m9pgl3ayjfdfiqia68dvd8c61hjkrfv2-sonic-pi-3.0.1/app/gui/qt/../../../app/server/bin/sonic-pi-server.rb -u 4557 4558 4556 4556 4559 4560 4561 4562
  -- removing /run/user/1000/sonic-pi-pids/19298
  -- politely killing 19298

sonic-pi needs jackd started. You can do it by running pasuspender -- jackd -R -d alsa. See https://github.com/samaaron/sonic-pi/blob/master/INSTALL-LINUX.md#running

Maybe adding jackd to the PATH of sonic-pi would help.
Does jackd need something other privileges to start?
**[nix-shell:/tmp/nox-review-je2_gdlp]$ pasuspender -- jackd -R -d alsa
jackdmp 1.9.11-RC1
Copyright 2001-2005 Paul Davis and others.
Copyright 2004-2016 Grame.
Copyright 2016-2017 Filipe Coelho.
jackdmp comes with ABSOLUTELY NO WARRANTY
This is free software, and you are welcome to redistribute it
under certain conditions; see the file COPYING for details
Cannot create RT messagebuffer thread: Operation not permitted (1)
Retrying messagebuffer thread without RT scheduling
Messagebuffer not realtime; consider enabling RT scheduling for user
no message buffer overruns
Cannot create RT messagebuffer thread: Operation not permitted (1)
Retrying messagebuffer thread without RT scheduling
Messagebuffer not realtime; consider enabling RT scheduling for user
no message buffer overruns
Cannot create RT messagebuffer thread: Operation not permitted (1)
Retrying messagebuffer thread without RT scheduling
Messagebuffer not realtime; consider enabling RT scheduling for user
no message buffer overruns
JACK server starting in realtime mode with priority 10
self-connect-mode is "Don't restrict self connect requests"
Cannot lock down 82280346 byte memory area (Cannot allocate memory)
audio_reservation_init
Acquire audio card Audio0
creating alsa driver ... hw:0|hw:0|1024|2|48000|0|0|nomon|swmeter|-|32bit
ALSA: Cannot open PCM device alsa_pcm for playback. Falling back to capture-only
mode
Released audio card Audio0
audio_reservation_finish
Cannot initialize driver
JackServer::Open failed with -1
Failed to open server

jackd is added to PATH in https://github.com/NixOS/nixpkgs/pull/30131/files#diff-45e93847b5b5683d70e6655296434353R86
What I suspect from sonic-pi running instruction is that if you run pulseaudio you need to allow jackd to use a soundcard with pasuspender.


As a user, I want to be able to interact with a census tract region of the map and see a pop-up display (in simple HTML text) showing the data based on the filters I have applied.

Definition of Done

[x] When you click on shapefile pop-up displays
[ ] Pop-up displays relevant data based on year and variable chosen by user (see comment below for sample)
[ ] When mouse hovers over file, the shapefile highlights itself

Proposal to delete When mouse hovers, shapefile has popup.
Add visual example of popup

Refer to this for highlighting
https://leafletjs.com/examples/choropleth/


[core-http] reduce memory usage of proxy policy cache

Currently we cache the result of whether a request to a url should bypass proxy
using url as the cache key. In some scenarios the number of unique request urls
can be very large, for example, when iterating through thousands of Azure
Storage blob items and retrieving their properties.
This PR changes the cache key to host names. Code is simplified a bit and
updated to allow more reliable testing.  The fix is also ported to Core v2.
Addresses #13277.

@chradek Can you take a look at this as well?


Could I get localStorage data in swift ?

I need to read dynamic data from webview in swift before the vpn start connection. So I wonder know is there any ways to read data from localstorage.

Sorry but I have no idea how to do with these, could you please show me a simple sample if could? Thank you very much.
I need to read localstorage data in OutlineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift or OutlineAppleLib/Sources/OutlineTunnel/OutlineTunnel.swift

What's your goal?

I need to call some api(dynamic url which I saved in localstorage) to get different settings info while setup vpn every time before connect.

What's your goal?

I need to get different settings info by user while setup vpn every time before connect.

But what are the settings for? Can you not do it in the web view?

Well, I want to set includedRoutes and excludedRoutes or dns for different users, so I think maybe I could only get the info dynamically and set it up while every time we setup vpn.


Tag support in Grafana API

Hello, I am still on version 5.0.13 and plan to stay on it due to our support contract. I see in the API that Tag Filtering is available, however using your newest Grafana Plugin, I dont see that option. The zabbix version that I am on supports Application and Tags as well, so it would be great to see an additional filter there, in the Grafana API GUI, for Tag filtering.

Hi! I think since I introduced tags support in last version and Zabbix 5.0 supports tags as well, it makes sense to add support for tags.

Hi! I think since I introduced tags support in last version and Zabbix 5.0 supports tags as well, it makes sense to add support for tags.

So, does that mean you will add "Tags" to the existing Grafana API for
older versions of Zabbix? If so, do you know when it will be available for
download?
Thank you so much for your help with this!
Note: just sending this again, because I am not sure you got ,y last response.

Also, would it be possible to add "inventory" fields as separate option as well? But "Tag" is the most important.


[CTM-1130] implement workflow to create a GH release

see https://github.com/SoftwareAG/cumulocity-clients-kotlin/releases/tag/v10.18.0-263
@joerghartmann
-- pls check the different file names: I think they should be the same for both variants
-- should we also add the version info to the .aar file?
-- should we also add the cumulocity-clients-kotlin-debug.aar?

Not an expert in the use of workflow_call, but seems about right to me.

finally it is working:

https://github.com/SoftwareAG/cumulocity-clients-kotlin/actions/runs/8828033917/job/24236335622
https://github.com/SoftwareAG/cumulocity-clients-kotlin/releases/tag/v10.18.0-269
@joerghartmann @MarkJMReynolds-SAG pls review

finally it is working:

Looks mostly reasonable to me, but I suspect something is still not right - looking at the archived assets in the workflow -

aar = 552k
jar = 593k

Then in the release itself for build 269 -

jar = 593k 🆗
aar = 779 Bytes 😕

Maybe you really do mean this, in which case I'll approve, but I can't see intent for anything other than "pass the files along exactly as-created", in which case L62 in release.yml seems to be pointing at the wrong file, doesn't seem to match the change on L47 of build.yml IMO.


Updating to latest dependencies to address reported CVEs

There were a number of old dependencies being used which contained Common Vulnerabilities and Exposures (CVEs) as reported by tools like Snyk
This pull request is to update as many of these dependencies as possible to bring them up to the latest compatible version so that most of the CVEs are resolved.

@IvanGoncharov @RomanHotsiy - do you think you'd be able to take a look into this PR when convenient?

@FluorescentHallucinogen - are you able to take a look over this PR at your convenience

@setchy I'm not a maintainer of this project and I have no rights to merge pull requests here, I'm just a contributor like you, have created a few pull requests, and they are not merged too, see e.g. #157. ¯_(ツ)_/¯

Ah, my apologies @FluorescentHallucinogen - odd indeed

@IvanGoncharov @RomanHotsiy ?

There are git conflicts now. Can you resolve those so that the maintainers have an easier time merging?

Looking at the latest updates on master it seems this PR is now redundant.  Closing

I believe all that is needed is a new release of this codebase

Hello, Still having issues with this dependency. Any idea what the problem might be? https://github.com/APIs-guru/graphql-voyager/blob/master/package.json#L74 Material ui still looks like on version 3 and from this PR looks like was being updated to 4.x
I still get a vulnerability report for materal ui core.

Re-opening .... updated to latest minor and patch versions of all dependencies

@klausi - done 👍

@RomanHotsiy @IvanGoncharov - would you mind having a look over this PR please.

@RomanHotsiy @IvanGoncharov - would you mind having a look over this PR please.

Hm, any reason you closed this? I think the update still needs to be done?


Use power of two for underlying storage of CircularBuffer

Motivation:
We should use power of two for the underlying storage to allow us to make use of bitmasking which is faster then modulo operations.
Modifications:
Use power of two and replace module with bitmasking.
Result:
Faster implementation of CircularBuffer.

@weissi I see no differences with our network benchmarks (which is not really unexpected atm). But I think we all know that modulo is considered slow compared to bit masking.

@normanmaurer sure, I thought a micro benchmark but it's unlikely to be worse so maybe it's fine

@Lukasa @weissi PTAL again... I also did a few more changes to make the whole data structure a bit smaller.

Will add more tests tomorrow

@weissi @Lukasa I enhanced the tests a bit and addressed comments. Can you let me know what kind of other tests you would like to see (if any)?

@weissi @Lukasa PTAL again


[ENHANCEMENT] Expose AWS enabled properties for Operate, Tasklist, Optimize

Describe the use case:
We need to fix bugs with Operate/Tasklist/Optimize around authentication with AWS Opensearch. This requires us to expose new configuration properties (see below) that must be configurable through the Helm chart. The fix needs to be implemented on main/8.6 and backported to 8.5.

Support case: https://jira.camunda.com/browse/SUPPORT-23119
Incident channel: https://app.slack.com/client/T0PM0P1SA/C07FZMBJ03G

Describe the enhancement/feature:

Map the Helm chart configuration global.opensearch.aws.enabled to:

camunda.operate.opensearch.awsEnabled application property of Operate (ticket that introduces this: https://github.com/camunda/camunda/issues/20939)
camunda.tasklist.opensearch.awsEnabled application property of Tasklist (ticket that introduces this: https://github.com/camunda/camunda/issues/21070)
CAMUNDA_OPTIMIZE_OPENSEARCH_AWS_ENABLED environment variable for Optimize (ticket that introduces this: https://github.com/camunda/camunda-optimize/issues/14030)

Desired outcome and acceptance tests:

@ralfpuchert
Just to confirm, if the user set global.opensearch.aws.enabled to true then there is no need for basic auth because AWS IRSA will be used instead for auth correct?

@ThorbenLindhauer
It is still possible to use AWS IRSA with operate and tasklist without the need to setup a username and password. Only optimize is not officially supported with AWS IRSA.

Hey @hamza-m-masood,

Just to confirm, if the user set global.opensearch.aws.enabled to true then there is no need for basic auth because AWS IRSA will be used instead for auth correct?

Correct

Also is this true across the board for all apps, including tasklist, and optimize?

Yes

It is still possible to use AWS IRSA with operate and tasklist without the need to setup a username and password. Only optimize is not officially supported with AWS IRSA.

Thanks, wasn't aware of the Optimize detail. I wonder now a little why the Optimize medic create a ticket, but I assume it makes sense and otherwise they'll figure it out during implementation.

@ThorbenLindhauer thanks for the reply 👍
I will still add this option to all listed apps. It is good to have. I hope the app logs clear up a little bit with this option enabled. I am assuming these configs don't currently exist since the issues are still open. In that case, I will not merge my PR until all the above issues are closed, and I can comfortably test the changes.

I am assuming these configs don't currently exist since the issues are still open.

Correct, once the issues are closed (and the CI has run), you will be able to use the 8.6 and 8.5 snapshots to test. Note that a proper patch release will only be available as part of the regular release train that targets the second Tuesday of September.

@matthewBearCamunda
I have a few questions for Optimize:

Currently, Optimize does not support migration through the initContainer when OpenSearch is enabled with basic auth. Is this still the case?
As I said, we currently do not officially support Optimize with IRSA enabled. Will Optimize support IRSA when the above issue you created is closed?
Will migration through the initContainer be supported for IRSA as well?

I have completed the PR. I will pause this issue. I will resume when I can begin testing and get more clarity from the Optimize team.

@hamza-m-masood

This I'm unsure about. Our resident OpenSearch expert @grlimacan is on FTO and he'd be the one to answer this. I can dive into this more if this is a blocking question

IRSA is supported by Optimize. It was added here: https://github.com/camunda/camunda-optimize/issues/12696

What migration are you talking about here? Are you referring to a DB migration when Optimize changes versions, when DB schema changes could be happening?

I will have to make a change in the official docs that IRSA is supported for Optimize now that it is confirmed by you. I will wait for @grlimacan for further info on this topic.
In regards to the migration I am referring to the script called upgrade/upgrade.sh through this initContainer: https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform-alpha/templates/optimize/deployment.yaml#L39
I am not sure if this script is related to DB schema change.

I will have to make a change in the official docs that IRSA is supported for Optimize now that it is confirmed by you. I will wait for @grlimacan for further info on this topic.
In regards to the migration I am referring to the script called upgrade/upgrade.sh through this initContainer: https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform-alpha/templates/optimize/deployment.yaml#L39 I am not sure if this script is related to DB schema change.

Hey @hamza-m-masood , we implemented the ticket mentioned above by @matthewBearCamunda but we have still not been able to validate that in a real IRSA environment, since we don't have the means to create and configure one. Are you able to confirm if the fix works properly?
As for the actual changes concerning the disabling of the AWS config, I have just implemented the fix and am awaiting review. I will let you know as soon as it's reviewed

@grlimacan
Thanks for replying.
I think this thread in our ask-distro channel will be useful to you for testing with IRSA: https://camunda.slack.com/archives/C03UR0V2R2M/p1721729195556469
If not, I can test for you. No problem. 👍

Hi @hamza-m-masood , https://github.com/camunda/camunda-optimize/issues/14030 is already implemented and will be present in the upcoming alpha and also on 3.13.5

I am currently trying to test with the snapshot images of tasklist, operate, and optimize

I can confirm the following when testing with basic auth:

Optimize snapshot image is working with basic auth.
Operate pod is not in a healthy state. The logs do not show an error but the readinessProb fails.
Tasklist does not build the correct URL for OpenSearch. I get the following error:

io.camunda.tasklist.zeebe.PartitionHolder - Error occurred when requesting partition ids from Zeebe client: io exception
....
Caused by: io.netty.channel.AbstractChannel$AnnotatedConnectException: finishConnect(..) failed: Connection refused: localhost/<IP_ADDRESS>:26500

Seems like tasklist is using localhost as it's way to connect to zeebe gateway. I'm relatively sure that zeebe gateway is configured correctly because Operate would also be complaining if there was a problem with zeebe gateway.

Operate and Tasklist are not able to connect to zeebe but I do see the data present on the OpenSearch database. For that reason I am happy to go ahead and merge this PR after review. I have tested with basic auth.


Scan journal for references when using pull and renameall

fwt pull work great for the database files but don't pick up media references in journal entries.
For example, we start with an element that looks like this:

fwt pull --from assets/srd5e/img --to worlds/myworld

The assets referenced in the journal are not moved, nor are the links updated. As an aside, I think that other commands like fwt renameall also do not affect journal media references but I'm not sure if that is because its not being scanned or its not meeting some condition to be renamed.

It's been a minute since I've worked with the logic of the pull command. I'll do some testing to see what the issue may be. Off the top of my head I suspect that it may be due to the strings in the biography key being escaped and / or URL encoded.
If you have time can you check the actor.db file that has the problem and see if the src attributes have been URL encoded?

OP means the journal entries in journal.db.  The images are referenced inside html <img and <a tags.  These are part of the JSON content variable.

Ooops. My bad. Although, the URL encoding issue may still apply since the journal.db entries content attribute is also formatted HTML.
Regarding the renaming of assets, I was able to rename images within journal entries on my development server. If you have time please look in your db files to see if there may be additional encoding characters in the paths for the files that are not being renamed.
Regarding the pull command, currently it is only analyzing paths contained within json img keys. I see the need to also find paths contained throughout the db files so I'll start working on a more generic algorithm to detect and copy assets from other projects. No ETA but I expect to have a new version in the next few days.
Thanks for you feedback.

The .db file looks like this within a JSON string:

The double quotes are escaped because its in a JSON string but there is no URL encoding going on otherwise. Foundry seems to handle that on the client side and stores the raw HTML.
Also, much appreciated for fwt as always.

I've pushed a new version that should allow pull of assets referenced anywhere in the database. Please test.
@EternalDeiwos, RE the rewrite of assets in the journal.db, is the path assets/srd5e/img/adventure/myworld/My Asset.jpg outside of the project being modified? If so, fwt will ignore remote assets as renaming them could result in breaking changes for those remote projects. Assuming that is the case pull should be able to make those assets local which would allow them to be renamed.
Let me know if all is working.

Regarding Pull, it worked for the world I was working on.  It pulled journal links that it didn't do before, from a source external to the world, and placed it inside the world.  Great Stuff.

Will test as well ASAP but glad to hear confirmation from electronicum.
Also, I had another occasion to try out fwt renameall on journal content and found that it was in fact working as expected so false alarm there. With fwt pull getting the files into the world path everything should work from there.


⚠ Bofrost.de has degraded performance

In 8e77146, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 953 ms

Resolved: Bofrost.de performance has improved in 500a6be.


[Bug]: Button group widget and Menu widget accepts duplicate options

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
It is observed that the button group widget accepts duplicates button and the menu button widgets also accept duplicate menu button

Steps To Reproduce

Launch appsmith app in release/Production environment
Drag and drop Button group widget and menu button widget
Open property pane and new buttons or sub-menu button
Rename the newly added button or submenu button to any existing button names and see duplicate button name are accepted and no error message is displayed.

Environment
Production
Version
Cloud

@YogeshJayaseelan the screenshot wasn't uploaded can you upload it again?

@dilippitchika Added screenshot

@vasanth-appsmith how to indicate errors like this in this component?
Please take a look at the current behavior in the table widget for duplicates. I believe we could improve the error feedback here.

This is how it looks for the table widget

@dilippitchika Why is this a problem?

Extracted the below technical solution through ChatGPT. Hope this gives some direction
Technical Solutions: (ChatGPT)
Front-End Code (React):
ButtonGroup Component Update:
Update the ButtonGroup component to handle the validation logic for unique button names:import React, { useState } from 'react';
const ButtonGroup = () => {  const [buttons, setButtons] = useState([{ name: 'Favorite' }, { name: 'Add' }]);  const [error, setError] = useState('');
const addButton = (name) => {    if (buttons.some(button => button.name === name)) {      setError('Button name must be unique');    } else {      setButtons([...buttons, { name }]);      setError('');    }  };
return (          {buttons.map((button, index) => (        {button.name}      ))}      <input        type="text"        onBlur={(e) => addButton(e.target.value)}        placeholder="Add button"      />      {error && {error}}      );};
export default ButtonGroup;
Menu Component Update:
Update the Menu component to handle the validation logic for unique menu item names:import React, { useState } from 'react';
const Menu = () => {  const [menuItems, setMenuItems] = useState([{ name: 'Item1' }, { name: 'Item2' }]);  const [error, setError] = useState('');
const addMenuItem = (name) => {    if (menuItems.some(item => item.name === name)) {      setError('Menu item name must be unique');    } else {      setMenuItems([...menuItems, { name }]);      setError('');    }  };
return (          {menuItems.map((item, index) => (        {item.name}      ))}      <input        type="text"        onBlur={(e) => addMenuItem(e.target.value)}        placeholder="Add menu item"      />      {error && {error}}      );};
export default Menu;
CSS for Error Message:
Ensure you have appropriate styling for the error message:
.error {
color: red;
font-size: 12px;
}
Back-End Code (Spring Boot):
Controller Update:
Update the controller to handle the validation logic if any backend validation is necessary:@RestController@RequestMapping("/api/widgets")public class WidgetController {
private Set buttonNames = new HashSet<>();
private Set menuItemNames = new HashSet<>();
@PostMapping("/addButton")
public ResponseEntity addButton(@RequestParam String name) {
if (buttonNames.contains(name)) {
return ResponseEntity.badRequest().body("Button name must be unique");
}
buttonNames.add(name);
return ResponseEntity.ok("Button added successfully");
}
@PostMapping("/addMenuItem")
public ResponseEntity addMenuItem(@RequestParam String name) {
if (menuItemNames.contains(name)) {
return ResponseEntity.badRequest().body("Menu item name must be unique");
}
menuItemNames.add(name);
return ResponseEntity.ok("Menu item added successfully");
}
}

Hello @Nikhil-Nandagopal @dilippitchika @YogeshJayaseelan , is this issue still open. can I try to solve this issue?

@saicharan-zemoso I don't think this is a valid issue so I'm going to close it

@Nikhil-Nandagopal , Even I had the same thought that this might not be a valid issue, but the UI and logic is already in place, therefore, we internally worked on this issue and will present pull request in few days,
Request you to consider it once.
So it show Red border along the duplicate menu item, or duplicate button label, only logic piece was missing which will be there in the pull request.
@saicharan-zemoso  you can create the draft pr, and explain the solution

@akshayvijayjain would you be open to a quick chat next week? Here's my calendly
https://calendly.com/appsmith-nikhil/30min

@akshayvijayjain would you be open to a quick chat next week? Here's my calendly https://calendly.com/appsmith-nikhil/30min

sure, booked a slot!


ported to 1.120.x

Hey, bumping up the version in these 2 files is sufficient to make the mod work in 1.20.x Feel free to merge it!

Thanks, but already done in #7.


view from two devices at the same time

Hello @moritzmhmk
when I am trying to view the camera from two devices, the second device always reports that the device no response. If I view the camera one by one, both devices are OK. Is this normal? Or view from more than one devise at the same time possible?
thx

This is normal.
I will keep this issue open as an requested enhancement.

Hi,
Does this mean i can run the homebridge server on one raspberry pi with this plugin and the actual camera on another raspberry pi?
Thanks!

No that is not the purpose of this plugin. Why would you consider this kind of setup anyway?

Offloading homebridge from several pi zero ws and reusing an already existing homebridge server where every other plugin is installed. This is the use case. Makes sense?

Like, for every other plugin I have, it looks for devices (e.g.: shelly, harmony hub) in the local network and interfaces with them. In this case, the devices would be the raspberry pis with cameras.

Homebridge needs to be paired for every camera since they can not be bridged (a device is created for every camera).
Performancewise it might improve but I havent tested that yet (i.e. how many cameras a Pi 3 or 4 can handle). Currently I consider switching to Pi 3A+ for my cameras...
This plugin is using the hardware encoding of the Pi to improve performance. You would need to find a way to stream that encoded video and then use the default ffmpeg based homebridge plugin on your central homebridge pi.

I see, so it’s a technical limitation in which cameras cannot be bridged. Got it, thanks! I’ve been trying your plugin and works great. Excellent job!


show 7 days per week in docs, fixes #12

Now you can’t hide anymore that you don’t commit on Sundays ;)

Lol. We at @frappe use the Heatmap to check daily attendance of entities within our product github.com/frappe/erpnext
Maybe that's why we never thought of Sundays! 😛
Just add in a Screenshot to your PR (This is our fault, we'll be working on contribution guidelines) and we'll have it merged!
Thanks!

@jakob-stoeck
Test then whether Sundays appear. Would be awesome if you post before and after screenshots :)

If you are updating these files, here's what I'm doing for my test project to show dummy data:
	let heatmap_data = {};
	let current_date = new Date();
	let timestamp = current_date.getTime()/1000;
	timestamp = Math.floor(timestamp - (timestamp % 86400)).toFixed(1); // convert to midnight
	for (var i = 0; i< 375; i++) {
		heatmap_data[timestamp] = Math.floor(Math.random() * 6) + 1;
		timestamp = Math.floor(timestamp - 86400).toFixed(1);
	}

Which gives me a nice randomised set of data on reload:

@iDemonix Send in a PR!

I'm looking forward to seeing your contribution docs and so on :) I've only recently picked up Javascript and have not much knowledge around compiling/minifying/testing etc. Once your doc is out I'll give it a read and hopefully I can submit some of my first PRs!


I don't know what this is.

I followed the instructions to install it but I don't see anything happening. I'm afraid. Pls hlp.

WTF!

Instructions unclear.


Updated EKS-D versions

Issue #, if available:
Description of changes:

Bumped all EKS-D versions for all releases
Changed 1.22 Kubernetes version from 1.22.4 to 1.22.6

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold
This is good to go. Unhold whenever you're ready to merge it

/retest

/unhold

/hold

/retest


fix: configurable ttl for test runners

Allow jobs to specify TTL for instances to prevent jobs from being cancelled by machines shutting down.

#6629  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on  Graphite

Actually I still want this I think - but to go the other way! these limits are way too high.


Fine-grained profiling

Is your feature request related to a problem? Please describe.
There should be a way to limit the scope of the profiling done (eg. do not collect column statistics, only collect sample data).
Describe the solution you'd like
In the ingestion job creation form in the UI there should be checkboxes for different types of profiling where you can disable/enable them as you like.
Describe alternatives you've considered
Additional context

this is shipped

You can disable profiler and or sampling


WebUI gets an index out of bounds error for large directories

Alluxio Version:
2.0.0-preview
Describe the bug
When trying to access a directory with over 1 thousand files, the browse REST endpoint throws an error. It is not 100% known that the error is due to the number of files.
To Reproduce
Create a directory with 1000 files, try to access it through the browse page on the UI.
Expected behavior
The UI displays the files in the directory.
Urgency
Urgent, this prevents users from using the WebUI.
Additional context
Master side error:
RestUtils - Unexpected error invoking rest endpoint: Index: 0, Size: 0

Attempted to recreate the bug in both 2.0.0-preview and master and was not able to reproduce. I made a new directory and created copies from a single file until there were over 1000 files. I was able to browse the directory in the WebUI with no errors.


Expand

http://reactivex.io/documentation/operators/flatmap.html
Treat like a transpose for streams

Existing transpose tool works with streams, so use that.


Compatibility with different Python versions

I just learned how to set up virtual environments to test my code in. But I'm not sure which virtual environments to make sure my code is compatible with. I have Python 2.7.6; I could perhaps ensure that it's compatible with 2.7.5 (which HW has) but beyond that I'm not sure how many (and which) versions would be appropriate to test. @davidwhogg , your feedback here would be very helpful!

I can't imagine any possible reason that if you are compatible with 2.7.6 you wouldn't be compatible with 2.7.5.  If there is any such thing, I would love to see the error message!

Oh, I see. Then I think it's a compatibility issue between different versions of Scipy rather than different versions of Python. So then the testing to be done is between different Scipy (and probably Numpy, too) packages...

I see two options:
-- state what the version requirements are; and ask the user to get with it (I would suspect it
is mostly scipy and numpy)
-- or write it that its works with an earlier version of scipy & numpy, as I presume there is far more forward compatibility


Dashboard bookmarks tab.

Added /dashboard page to house the dashboard.
Added migration for bookmarks in user, and last_edited in document
Added queries to add/remove bookmarks, and edited document query to include last_edited
Finished functionality for users to add/remove bookmarks on document pages.
Mostly completed the bookmarks tab for the dashboard. Missing routing, number of contributions, and last_edited since they aren't implemented yet.

Trying to merge this before starting to add code for routing because all of this wants to use the routing changes too.

Replaced by

https://github.com/NEU-DSG/dailp-encoding/pull/358
https://github.com/NEU-DSG/dailp-encoding/pull/356


Change between releases

Now when more and more people are using Rasa as botengine/backend and then also more and more people start using Webchat as chat frontend, should the documentation be improved too? First I looked version to to see changelog, but could not find it, then I compared versions directly and could see the changes there, but not reason, why there was change? For example why script was changed in version 1.0.0? Previous was very easy to understand, the new more cryptic? Could I help you on this documenation/changelog matter?

Hi, the changes will make more sense once we release the new version of Botfront, we're working on documenting all those new features at the moment. It's true though that the changelogs could be improved


IndexError with computing fingerprint

Describe the bug
With the given smiles (in the next section), rdkit throws an error when trying to compute a fingerprint.
To Reproduce
from rdkit import Chem
from rdkit.Chem import rdMolDescriptors
mol = Chem.MolFromSmiles('CC1C(B(C)C)S1(C)(C)=O')
rdMolDescriptors.GetMorganFingerprint(mol, 2)

the following error occurs:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
IndexError: -1

Expected behavior
An object of type UIntSparseIntVect to be returned with no errors.
Configuration (please complete the following information):

RDKit version: 2023.09.3
OS: Ubuntu 20.04
Python version (if relevant): 3.10.14
Are you using conda?
If you are using conda, which channel did you install the rdkit from?
If you are not using conda: how did you install the RDKit?

Additional context
The modern code rdFingerprintGenerator.GetMorganGenerator(radius=2).GetCountFingerprint(mol) seems to work, which makes this more mysterious. (But this is still annoying as I'm using library code which uses the rdMolDescriptors.GetMorganFingerprint method)

Confirmed.

Please do note that this function is deprecated and will be removed in a future release


Feature: Allow modify border radius of digitBlock

Hi! Thanks for this amazing component. I wonder if you could add some new CSS vars to customize the digit blocks border radius (top and bottom).
I have many webs, which different styles and I want to customize in some of them to be squared, not rounded.
Regarding to #10, you can make all UI elements full customizable so it could be integrated with specific themes in any website. I think it could be cool and give much power to the component.
What do you think @sLeeNguyen ?

Hello. We have some properties that allow you to customize the component's styles like: digitBlockStyle, labelStyle, ... Have you tried them?

btw I will try to update the component to make it more customizable. Thank you for your suggestion.

Hello. We have some properties that allow you to customize the component's styles like: digitBlockStyle, labelStyle, ... Have you tried them?

Yeah I tried but I cannot change the border radius for example with that options. As I see in here
https://github.com/sLeeNguyen/react-flip-clock-countdown/blob/00fb2503100f184cfa44159780bc4f86cf3a8142/src/styles.module.css#L76-L88
And here
https://github.com/sLeeNguyen/react-flip-clock-countdown/blob/00fb2503100f184cfa44159780bc4f86cf3a8142/src/styles.module.css#L117-L129
border properties are hardcoded to 4px. It would be nice if we can override those properties too or maybe make the whole component more customizable.

btw I will try to update the component to make it more customizable. Thank you for your suggestion.

Thank you so much !

I've just add new commit to fix this issue. Could you try the latest version?

Hey @sLeeNguyen I try it with borderRadius: 0 and it looks good. Thanks!


AddQuestions.jsp in the admin part

we need to make every answer in a different text and get the questions with it's three answers in one string in the backend part

ha3mlha belel

discarded


docs: ✏ add chinese readme

Thanks for the pull request, but we don't have any plans to localize the docs.


No id creation

closes #4
closes #13
closes #23
It also picks up some tasks from other tickets. Mainly with regards to the "remove to_unqualified...".
Might have to do some clean up (most String can be converted to &str).
There are two major TODOs which I need some help with.
Right now we have some presentation filter, like: schema issuer, schema name, etc. Before we could derive this from the schema id, but not anymore. How will we deal with this? As the schema id has no guarantee of being "qualified" we can not use it.
I believe we can do these from the filters without changing anything:
    Ok(Filter {
        schema_id,         // YES
        schema_name,       // NO
        schema_issuer_did, // NO
        schema_version,    // NO
        cred_def_id,       // YES
        issuer_did,        // NO
    })

We can allow for more data to be passed in which can be gotten from an object resolution on the ledger or whatever.
The second one is the wrappers. I did not update them, but updating them would be trivial as they are just FFI-wrappers without complex logic build atop. I can create an issue for that if there is none.

@dkulic this is probably also relevant to you, as it touches some things you were also working I think

@andrewwhitehead -- can you take a look, per @TimoGlastra request?

Just as a note, I will create a follow up PR doing some cleanup for the codebase.

@whalelephant feel free to also leave a review if you have time

Wow, great work. Thanks.
I was busy with some other stuff, will try to get involved more.

I used quite a bit of impl Into<SchemaId> but it might be better to do impl TryInto<SchemaId> so we can validate when we call into. This almost automatically adds validation. Can do this in a follow up PR to keep this one smaller.


feat: add Tensor 3.0.5, mongodb 1.17.3 releases

update Tensor with release 3.0.5
update mongodb with release 1.17.3

:tada: This PR is included in version 1.305.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add Enum type for python < 3.4 by using backported enum34 package

One possible way to fix #1768

Thanks for this @mojeto !


Large file sizes when using import to bring in specific JS components

Using ES6 and Webpack, if I try to bring in specific Bootstrap JS components, my file size grows tremendously.
import 'bootstrap-sass/assets/javascripts/bootstrap/collapse';
import 'bootstrap-sass/assets/javascripts/bootstrap/tab';
import 'bootstrap-sass/assets/javascripts/bootstrap/transition';

Including the above imports produces a file with a size of 700+ kb un-minified and 90+ kb minified. When these lines are removed, I get 10kb un-minified and 1.59 kb minified. The baseline sizes include some minimal js I have.
Does this make sense?

Since this doesn't sound Sass-specific, please file your bug upstream at https://github.com/twbs/bootstrap
Thanks.

https://github.com/twbs/bootstrap/issues/20634


Add reference

Add reference for auth usage in backend, they are from https://www.django-rest-framework.org/api-guide/authentication/#setting-the-authentication-scheme

finished


Support for M3U with reverse proxy and https

When downloading M3U files, if the reverse proxy exposes https, the generated URL is exporting the wrong protocol.
This change checks for x-forwarded-proto in the original request and creates the M3U list with the proxy reported protocol.
To allow for this to work with NGINX it sufficent to add the following lines:
            proxy_set_header Host $http_host;
            proxy_set_header X-Forwarded-Proto https;

The first line let peerflix know the original exposed FQDN:PORT name the client used to reach the proxy, the second header let peerflix know that request was https and not http.

I've checked out the docs: https://expressjs.com/en/guide/behind-proxies.html
It would be better to set trust proxy option in this case, Maybe we should introduce some kind of CLI option or env variable that would enable this?

Just curious, does the host actually work or should we check for X-Forwarded-Host as well?

Host works since the proxy is configured to pass it unchanged:
    proxy_set_header Host $http_host;

I've checked out the docs: https://expressjs.com/en/guide/behind-proxies.html
It would be better to set trust proxy option in this case, Maybe we should introduce some kind of CLI option or env variable that would enable this?

This would be ok as well as my patch, but it requires, in case of NGINX reverse proxy, to add the following:
    proxy_set_header X-Forwarded-Host $http_host;

I'd rather use req.protocol and req.hostname to keep the code simple.
You'll have to pass host one way or another: either as Host header or as X-Forwarded-Host. I think both should be supported, i.e. if X-Forwarded-Host is not supplied Host will be used.

I'd rather use req.protocol and req.hostname to keep the code simple.
You'll have to pass host one way or another: either as Host header or as X-Forwarded-Host. I think both should be supported, i.e. if X-Forwarded-Host is not supplied Host will be used.

If it fails back transparently I think it should be ok.
I did not know about the "trust proxy" option, but it should be the right way to go.

Could you please try it out and see if it works for you?

Could you please try it out and see if it works for you?

I'm not sure how to set the "trust proxy" option. Do you have a quick solution for your original code for me to check?

It seems to work.
I just added the config
proxy_set_header X-Forwarded-Host $http_host;

Just to make sure the X-Forwarded-Host was correctly set and it worked flawlessly as per my patch.
If you just put a switch on CLI or an ENV var to set it up, it will work with your code (besides of the change req.get('host') to req.host).
The ENV solution is better suited also for the docker case (it just requires to set the var on docker run), that is the one I'm using.

Ops..
wait.. I did a mistake. It's not working. I just changed bin.js and not the actual index.js.
Your code is not taking into account the port in the Host or X-Forwarded-Host tag.
Let me check a little more.

It seems that:
req.get('host') will get you the header Host with the full FQDN:PORT syntax, while req.host will get either the X-Forwarded-Host or Host header, depending on trust proxy settings, but without the port#.
So we're back to square one..
At this point I think that my patch is easier to deal with.

OK, then I would change it to:
var proto = req.get('X-Forwarded-Proto') || req.protocol;
var host = req.get('X-Forwarded-Host') || req.get('host');
...

Correct, but please make sure to use all lowecase chars in X-Forwarded-*, since node.js treats all headers as lowercase.
My first mistake was exactly using some uppercase letters. After debug it was clear you need to lower all cases.

That's strange, because they are using it like this:
https://github.com/expressjs/express/blob/cb59086305367d9fcd7d63b53cfca1a3e4ef77d7/lib/request.js#L367
https://github.com/expressjs/express/blob/cb59086305367d9fcd7d63b53cfca1a3e4ef77d7/lib/request.js#L492

I don't know about the expressjs code, but my trial-and-error patch used the partially uppercase header name and it did not work.
I used debug to dump the requests and the header names in the json logs were lowercase. I then switched to lowercase the code and it worked.

They are converting it to lower-case inside the get() method: https://github.com/expressjs/express/blob/cb59086305367d9fcd7d63b53cfca1a3e4ef77d7/lib/request.js#L52, so I think it should work regardless of the case.

Would you like to update the PR so that I could merge it, or would you prefer me to make the change myself?

Thanks!

Thanks to you. Nice job!
As soon as docker image is ready I'll upgrade.


In app manual / documentation

Currently there is no manual (apart from the markdown syntax guide) in the app.
Adding a manual available via the "three dot" menu on the navbar.
The manual should be include at least a "User" and an "Admin" Section. The "Markdown Guide" should be part of it, too.

done in commit f35f4ce


Opt for lower_thread_allreduce.cc

can use warp shuffle reduce for accelerate ?
https://github.com/apache/incubator-tvm/blob/main/src/tir/transforms/lower_thread_allreduce.cc#L420

Thanks for bringing up this good topic, please open a new thread under development category in https://discuss.tvm.apache.org/


Automatically call setup_datastore() on the first HTTP access to the newly created application instance #140

The main issue here is that the setup_datastore function is outside PF visibility when it is run in its virtual environment by GAE. However, setup_datastore is called only in some server_tests and changing the location of the module that contains this function does not affect them, so I think it is safe to move the whole module under app folder and let PF calls setup_datastore at the first HTML request when the Repos are empty.
Let me know what do you think about this solution.
Best regards

As I said in #158:
To implement it, we need to be careful about mutual exclusion. It's quite likely that multiple HTTP requests are made in parallel. We need some kind of mutual exclusion, or maybe just show a [initialize] button when not initialized, and let user manually click the button to initialize.
In your current code, it looks it runs setup_datastore() twice when multiple HTTP requests are made in parallel, which I believe is problematic.

Right @gimite, I'll fix that

Hi @gimite,
please review the last change. I added a critical area around the call to setup_datastore.
Thank you

AppEngine app can run in multiple processes in multiple machines. So threading.RLock doesn't work. Maybe it's hard to perform a global lock in AppEngine. If you find a solution, it would be great, but you can instead show an [initialize] button, and require human to perform mutual exclusion, which is awkward but would be easy to implement.

Ok, I will try with the "button" solution then
On Tue, 15 Sep 2015 at 09:53 Hiroshi Ichikawa<EMAIL_ADDRESS>wrote:

AppEngine app can run in multiple processes in multiple machines. So
threading.RLock doesn't work. Maybe it's hard to perform a global lock in
AppEngine. If you find a solution, it would be great, but you can instead
show an [initialize] button, and require human to perform mutual exclusion,
which is awkward but would be easy to implement.
—
Reply to this email directly or view it on GitHub
https://github.com/google/personfinder/pull/158#issuecomment-140312227.

Hi @gimite,
could you please review this change?

Oops sorry somehow I didn't notice that you pushed a new change.
Somehow https://github.com/google/personfinder/pull/158/files contains 1623 files which are unrelated to your change. Can you look into it? How about pulling and merging master branch again? Or maybe recreate a pull request?

Sorry, I didn't check the diff, before pushing that. I'll check which
solution is faster.
On Tue, 13 Oct 2015 at 08:02 Hiroshi Ichikawa<EMAIL_ADDRESS>wrote:

Oops sorry somehow I didn't notice that you pushed a new change.
Somehow https://github.com/google/personfinder/pull/158/files contains
1623 files which are unrelated to your change. Can you look into it? How
about pulling and merging master branch again? Or maybe recreate a pull
request?
—
Reply to this email directly or view it on GitHub
https://github.com/google/personfinder/pull/158#issuecomment-147614498.

Hi @gimite,
I opted to create another pull request

Thanks! Closing this one.


chore(modeler): add / update package-lock

add app package lock
update builder package lock

(ensures we don't accidentally pull in malicious dependencies).

Bumped dependencies so that we don't add vulnerable event-stream.


Custom Handler Concept not documented right

Does not work with 2.0.0 ebay-sdk

Thank you for taking the time to make a pull request. The guide was never meant to show a complete working example as I just wanted to show enough to get the concept of the configuration option across. I assumed that people would fill in the blanks. I'm sorry but in this instance I won't be accepting this pull request.


Accidental duplicate created when I thought I was editing an existing issue.

Renamed because I don't want it to show up should I ever search for the general discussion issue.


module cannot import other modules if it in node_modules

Describe the bug
I write a lib
if it in project it`s work
but if i publish to npm and install it
it cannot import other modules
Reproduction
https://github.com/scx567888/error-example1
System Info
windows 10                 19044.1645
node                       16.14.2
vite                       2.9.5
@vitejs/plugin-vue         2.3.1
edge                       100

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

https://github.com/scx567888/error-example1
1, run project it`s work
2, copy _node_modules/my-lib to node_modules (simulated npm i mylib)
3, In src/main.js  comment out 6 line and uncommenting 10 line
4, run peoject you will see error

i try add optimizeDeps.include to vite.config.js it work bug why?

I'm assuming you add spark-md5 to optimizeDeps.include, which made it work. The reason it doesn't work out-of-the-box is because Vite doesn't handle Vue files in third-party libraries currently, similar to https://github.com/vitejs/vite/issues/3910. A workaround for now is to have my-lib pre-compile Vue files to JS so that everything can be bundled.
Until Vite or plugin-vue supports Vue files in libraries (which is possible with https://github.com/vitejs/vite/pull/6801 though experimental), the workaround is actually the expected behaviour. I'll close this at the meantime so we can track in #3910 instead.


Parser use LoggerInterface

Change type hint for $logger argument of Parser::__construct() to use Psr\Log\LoggerInterface instead of CodeIgniter\Log\Logger which will allow alternative PSR-3 loggers to be used in Parser.
This brings Parser in line with the other core classes that have a "logger" dependency.

Good one!


Windows support

Closes #22
Adds a compilation workflow for Windows Python versions 3.8, 3.9, 3.10, 3.11.
Adds support for building on Windows using existing setup.py

@devm18426 please feel free to add a CREDITS file in the main repo folder and list your contributions. Really want to give you credit for these changes. Thanks again!

@devm18426 please feel free to add a CREDITS file in the main repo folder and list your contributions. Really want to give you credit for these changes. Thanks again!

I'll take credit for the commit log spam I'm trying to merge... I'm just happy to get this working for people on Windows after all this time. Up to you if you want to add a CREDITS file. Appreciate it.

@devm18426 please feel free to add a CREDITS file in the main repo folder and list your contributions. Really want to give you credit for these changes. Thanks again!

I'll take credit for the commit log spam I'm trying to merge... I'm just happy to get this working for people on Windows after all this time. Up to you if you want to add a CREDITS file. Appreciate it.

I am really glad to do that but don't know how you would like to be credited (real name? github handle?) so please feel free to add the file to the PR by yourself and I will just approve it. Thanks!


Guide how to make it work in Eclipse

Hi, I really like the idea but I couldn't make it work with a maven-based project in eclipse. If I build with maven and immediately start, it works. But as soon as I change the source code, the eclipse compiler kicks in and it doesn't work anymore.
Furthermore somehow after the modifications no decompiler is able to decompile the method with an interpolated string anymore.
Any way to fix this?

Hi, @mojo2012
Thanks for your feedback!
As I know, the Eclipse javac is a pretty specific compiler, and I think that to make AST modifications with eclipse compiler we need to patch compiler (as it made by Lombok to do something like this)
I'll try to research this subject, maybe exists some workarounds.


TreeBASE no longer accessible

Bug description
All data with only TreeBASE entries must be removed as the data is now gone - the repository appears to be 'dead'.
Additional context
No response

No response from authors...


Live Quiz

Erase existing environment (screen capture)
Setup our working environment (git clone)

Erase environment

Clone Repo

6.

0.9
0.9
1.8/2


[WIP] Use webpack for everything (main process + renderer process)

Coverage increased (+0.3%) to 42.032% when pulling c5e001ae267a1624a0c9aaa209b5761f3718d14b on victorporof:webpack-app into ed3641c54125ce4c3af8c5646fe1635d74645b6a on mozilla:master.

Coverage increased (+0.3%) to 42.032% when pulling c5b5926603588cfc8c14c5d78601aa0d579eecf0 on victorporof:webpack-app into ed3641c54125ce4c3af8c5646fe1635d74645b6a on mozilla:master.


No broken use when overriding abstract method from transitive supertype

When removing or adding a method from a transitive supertype, the JDT compiler reports the issue in the overridden method and not in the declaration of the subtype. The Maven compiler does the opposite. Missing broken use.
Related compiler messages:
Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/interfaceRemoved/InterfaceRemovedExtAbs.java
Line: 7
Message: method does not override or implement a method from a supertype

Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/interfaceRemoved/InterfaceRemovedImp.java
Line: 7
Message: method does not override or implement a method from a supertype

Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/classNoLongerPublic/ClassNoLongerPublicImp.java
Line: 7
Message: method does not override or implement a method from a supertype

Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/interfaceRemoved/InterfaceRemovedImpMulti.java
Line: 12
Message: method does not override or implement a method from a supertype

Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/methodRemovedInSuperclass/SMethodRemovedInSuperclassExt.java
Line: 7
Message: method does not override or implement a method from a supertype

Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/methodAddedToInterface/MethodAddedToInterfaceTransImp.java
Line: 3
Message: mainclient.methodAddedToInterface.MethodAddedToInterfaceTransImp is not abstract and does not override abstract method newMethod() in main.methodAddedToInterface.IMethodAddedToInterface

Path: path-to/maracas/test-data/comp-changes/client/src/mainclient/interfaceAdded/InterfaceAddedImpMulti.java
Line: 5
Message: mainclient.interfaceAdded.InterfaceAddedImpMulti is not abstract and does not override abstract method methodAbs() in main.interfaceAdded.IInterfaceAdded

When looking for the overriding method, this one is searched in the superclass hierarchy (and not in the super-interfaces) (check documentation of the getOverridingExecutable() method). Label these cases as false negatives.


#415 Added isCloseToPercentage to numbers

This PR contains changes so that numbers (incl. BigDecimals) can be checked by closeTo using a percentage value. Internally an offset value is calculated from expected and percentage and is then use the same way as isCloseTo with offset.
In order to integrate this PR as best as possible i had to refactor some things:

Deleted BigDecimals.abs, uses now Jdk7 Method
Pulled assertCloseTo to Numbers (was only in Doubles and Floats)

Fixed your mentioned points.
Thank you for your time/comments. It looks now more cleaner.

Thanks for your hard work, will review that this we and integrate it for the 2.1.0 release that I'm planning to do this next week.

I almost integrated the PR but I realized that expressing percentage with the same number type as numbers compared is weird, I should be able to write
assertThat(5.0).isCloseTo(6.0, withinPercentage(20));

IMO, a percentage should only be constructed with an int or a double, it does not have to follow the compared number types, I should be able to write:
assertThat(101).isCloseTo(100, withinPercentage(0.5));
assertThat(20f).isCloseTo(25f, withinPercentage(10));

I also changed the Percentage.toString to return directly values%.
I will add this changes this week end unless you strongly disagree - with good arguments ;-).
Last point, it would be nice if you could follow the code formatting convention (I know you are using Idea and it's not easy to use eclipse formatting preferences) but it would be easier for code review and integration as I would not have to reformat all the submitted code.
You might give a shot to : https://plugins.jetbrains.com/plugin/6546

I also stumbled upon this problem but did not followed it further because within has the same problem. Maybe isCloseTo(A expected, Percentage<? extends Number> percentage) could be a solution for both.
I'll spend some time for that formatting issue.

Finally get the formatting problem solved. I had thought the plugin is already installed but Lesson learned: Eclipse Integration != Eclipse Code Formatter

Awesome if you have fixed the formatting issue, it does not have to be perfect, most important thing  is getting the spacing right.
isCloseTo and within let you express a difference, in that case I think it's ok to express the difference with the same number type, it would not make sense to express a difference of 0.1 when comparing integers.
Percentage are best expressed with integer or double, I don't think we need anything else.

Integrated ... with additional refactoring :)


[WIP] Utilize negative tests in QCheck

This is a WIP PR to try out the negative testing primitive Test.make_neg from c-cube/qcheck#244.
It is intended to fix #29
Overall

this allows negative tests to be marked as such with neg_agree_test_par directly in the source code
the clunky check_error_count can be eliminated entirely
magical constants denoting 1, 2, and 4 errors in dune files are eliminated, and
dune files are generally simplified

As an added bonus, it opens up for switching to an alcotest runner as suggested in #15.
I would therefore argue that this is a clear win!  \o/

Rebased to latest main

Test.make_neg is now merged into QCheck master, so this can be picked up again.

Rebased after merging #90

Rebased on latest main, having QCheck 0.19 with Test.make_neg as a dependency.

I just annotated the new DSL-ported tests with suitable neg_ suffixes.
Planning to merge this assuming the CI doesn't complain too much.

(Hopefully) last rebasing on main


cue: Creating a required key within an optional struct

What version of CUE are you using (cue version)?

$ cue version v0.4.3 windows/amd64

Does this issue reproduce with the latest stable release?
Yes
What did you do?

cVal := cueCtx.CompileString("")
optionalPathSelector := cue.ParsePath("A").Optional().Selectors()
requiredPathSelector := cue.ParsePath("B").Selectors()

selectors := make([]cue.Selector, 0)
selectors = append(selectors, optionalPathSelector...)
selectors = append(selectors, requiredPathSelector...)

cVal = cVal.FillPath(cue.MakePath(selectors...), cueCtx.CompileString("int"))
cVal = cVal.Eval()
out, _ := format.Node(cVal.Syntax(cue.Optional(true)))
fmt.Printf("%v", string(out))

What did you expect to see?

{
  	A?: {
		B: int
	}
}

What did you see instead?

{
  	A?: {
		B?: int
	}
}

Probably a duplicate of #2127. I've asked @rogpeppe to fill out the repo in that issue to be sure.
@darshanraju - just of of interest, is there a reason you construct cVal manually, instead of just doing?
cVal := cueCtx.CompileString("A?: B: int")

Will leave this open for now, but should be investigated/fixed along with #2127.


[BUG] DNS resolution only works on the node hosting coredns in a three-nodes K3S cluster with flannel CNI

Describe the bug
On a three-nodes K3S AKS EE cluster, DNS resolution seems only work on the master node (the node hosting the coredns pod).
To Reproduce
Steps to reproduce the behavior:

Deploy a K3S cluster with 3 nodes and use Flannel as CNI
Deploy a ReplicatSet and a Service
Deploy a debug-1 pod (Busybox) on master node and execute 'nslookup .default.svc.cluster.local' (it works)
Deploy a debug-2 pod (Busybox) on a worker node and execute 'nslookup .default.svc.cluster.local' (failed)

Expected behavior
The nslookup command should work on a pod running either the master or worker node.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

AKS Edge Essentials Version: <IP_ADDRESS>
Kubernetes version: 1.24.6
Nested virtualization environment:

L0 Host OS: Windows Server 2022 Standard Evaluation running bare-metal (2 x CPU 10 cores Intel E5-2650v3, 224 Go RAM)
L1 3 VMs : Windows Server 2022 Standard Evaluation (5 vCPUs, 24 Go RAM)
L2 1 Linux nested VM running on each L1 VM (4 vCPUs, 16 Go RAM)
Internal virtual switch on the L0 host

Flannel as CNI

Additional context

in attachment, the aks ee config files for the 3 nodes and the Kubernetes objects deployed for debugging aks_ee_config_files.zip.
ping works between all the virtual machines (L1 and L2) through the virtual switch network
ping DOES NOT work between the L2 virtual machines via the flannel interfaces

❯ kubectl get nodes -A -o wide
NAME                STATUS   ROLES                       AGE     VERSION        INTERNAL-IP   EXTERNAL-IP   OS-IMAGE            KERNEL-VERSION    CONTAINER-RUNTIME
aks-ee-vm-1-ledge   Ready    control-plane,etcd,master   6h39m   v1.24.6+k3s-   <IP_ADDRESS>    <none>        CBL-Mariner/Linux   <IP_ADDRESS>-1.cm2   containerd://1.6.8-k3s1
aks-ee-vm-2-ledge   Ready    control-plane,etcd,master   3h38m   v1.24.6+k3s-   <IP_ADDRESS>    <none>        CBL-Mariner/Linux   <IP_ADDRESS>-1.cm2   containerd://1.6.8-k3s1
aks-ee-vm-3-ledge   Ready    control-plane,etcd,master   3h32m   v1.24.6+k3s-   <IP_ADDRESS>    <none>        CBL-Mariner/Linux   <IP_ADDRESS>-1.cm2   containerd://1.6.8-k3s1

❯ kubectl get pods -A -o wide
NAMESPACE     NAME                                              READY   STATUS      RESTARTS       AGE     IP           NODE                NOMINATED NODE   READINESS GATES
default       debug-node1                                       1/1     Running     1 (82m ago)    89m     <IP_ADDRESS>   aks-ee-vm-1-ledge   <none>           <none>
default       debug-node2                                       1/1     Running     1 (79m ago)    89m     <IP_ADDRESS>    aks-ee-vm-2-ledge   <none>           <none>
default       nginx-rs-ffl6p                                    1/1     Running     1 (151m ago)   3h28m   <IP_ADDRESS>   aks-ee-vm-1-ledge   <none>           <none>
default       nginx-rs-hgtzx                                    1/1     Running     0              3h28m   <IP_ADDRESS>    aks-ee-vm-3-ledge   <none>           <none>
default       nginx-rs-zt2hm                                    1/1     Running     0              3h28m   <IP_ADDRESS>    aks-ee-vm-2-ledge   <none>           <none>
kube-system   coredns-574fccb484-t9zqx                          1/1     Running     1 (151m ago)   6h39m   <IP_ADDRESS>   aks-ee-vm-1-ledge   <none>           <none>
kube-system   kube-vip-cloud-provider-0                         1/1     Running     1 (151m ago)   6h39m   <IP_ADDRESS>    aks-ee-vm-1-ledge   <none>           <none>
kube-system   kube-vip-ds-8q97c                                 1/1     Running     1 (151m ago)   6h39m   <IP_ADDRESS>   aks-ee-vm-1-ledge   <none>           <none>
kube-system   kube-vip-ds-nqz2n                                 1/1     Running     0              3h38m   <IP_ADDRESS>   aks-ee-vm-2-ledge   <none>           <none>
kube-system   kube-vip-ds-v6lr2                                 1/1     Running     0              3h32m   <IP_ADDRESS>   aks-ee-vm-3-ledge   <none>           <none>
kube-system   local-path-provisioner-5c64749b78-zct5s           1/1     Running     1 (151m ago)   6h39m   <IP_ADDRESS>   aks-ee-vm-1-ledge   <none>           <none>

❯ kubectl get svc -A -o wide
NAMESPACE     NAME          TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)                  AGE     SELECTOR
default       kubernetes    ClusterIP   <IP_ADDRESS>       <none>        443/TCP                  6h40m   <none>
default       web-service   ClusterIP   <IP_ADDRESS>   <none>        8080/TCP                 102m    app.kubernetes.io/name=nginx-rs
kube-system   kube-dns      ClusterIP   <IP_ADDRESS>      <none>        53/UDP,53/TCP,9153/TCP   6h40m   k8s-app=kube-dns

Hi @qclemence,
Thanks for the detailed information.  We will try to reproduce it and get back to you. In the meantime, the AKS Linux VM will drop the ICMP ping traffic by default, so you wont be able to ping between those L2 VMs. However, you can enable the ICMP traffic using the following command:
Invoke-AksEdgeNodeCommand -NodeType Linux -command "sudo iptables -A INPUT -p ICMP -j ACCEPT"
Thanks,
Francisco

Hi @fcabrera23 ,
I forgot to mention that I enabled ICMP traffic with the command you provided.
With this I can ping the L2 VMs through the "external" network (<IP_ADDRESS>/24) but not through the flannel interfaces (<IP_ADDRESS>/24, <IP_ADDRESS>/24, <IP_ADDRESS>/24)
Thanks,
Quentin

Hi @qclemence,
Could you please try running the following commands in the 3 nodes? We've encountered a firewall issue that will be fixed in our next release.
Invoke-AksEdgeNodeCommand -NodeType Linux "sudo iptables -A INPUT -p udp --dport 8472 -j ACCEPT
Invoke-AksEdgeNodeCommand -NodeType LInux "sudo iptables-save | sudo tee /etc/systemd/scripts/ip4save"

Thanks,
Francisco

Hi @fcabrera23,
After running the commands you provide in the 3 nodes, the DNS resolution works fine from all pods.
Thanks for your prompt response,
Quentin


None of this works...

Type of issue
Other (describe below)
Feedback
None of the instructions on this page work. If there are prerequisites, they are not listed. Hard stop at first paragraph (any key mappings available?). I'm on Windows 10.
Page URL
https://learn.microsoft.com/en-us/windows/terminal/panes
Content source URL
https://github.com/MicrosoftDocs/terminal/blob/main/TerminalDocs/panes.md
Author
@cinnamon-msft
Document Id
f27e9635-b4a3-3b7f-f7e7-bd0aca099014

@davidmpatterson Are you using the Windows Terminal or the vintage windows console?
There shouldn't be any pre-requisites for using any of those keybindings. Everything on that page is the defaults for the Terminal.

@davidmpatterson - Closing this as it seems to be a specific support issue and not tied to a required documentation update, but please feel welcome to re-open if you find this is not the case or have additional information to share.


Only Core Clarity Icons Available (Other Sets Not Working)

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior

Include clarity-icons.min.css CSS file.
Include custom-elements.min.js JavaScript file.
Include clarity-icons.min.js JavaScript file.

[...] clarity-icons.min.js loads not only the Clarity Icons Api, but also all icons sets.

Actual behavior
Icons in sets other than "Core" are not available, and the error-standard icon is displayed instead.
Reproduction of behavior
See pen.
Environment details

Angular version: N.A.

Clarity version<EMAIL_ADDRESS>

OS and version: macOS 10.13.2

Browser: Chrome 62, Firefox 57, Safari 11.0.2

@sathomas that's very odd. In Plunkr, all shapes are loading just fine. https://plnkr.co/edit/HpjUYCMngZntYZwMKkfD?p=preview
I will investigate further...

It's only reproducible in codepen for some reason. Also, in codepen, I can retrieve the shape, pencil, from the Api. https://codepen.io/anon/pen/aVezXq?editors=1111

@sathomas okay figured out what's going on after trying it out in other online editors such as jsfiddle, jsbin, and plunkr. The reason that all shapes were not loading was that codepen loads 3rd party libraries at the end of body tag, not in the head. It should be easily fixable.

@Shijir
Any update on this?

@mathisscott I am still working on it. The issue turned out to require a more substantial work. I am about to push an update to the PR that addresses this issue.


feat: add generics to filter, transaction, and pub_sub.

Motivation
In order to be able to use several structs and types from this repository for the Optimism port, they should take generics that can be replaced/used with the optimism types.
Solution
Add generics to the necessary structs and types.
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

In favor of making the code reusable by other networks. At what point is this PR done? do we have a list of types we need to update?

At what point is this PR done?

this process will take a few iterations because when adding new network specific types we'll discover more things that could be reused.
I think we will run into a few issues with types that have multiple network specific fields, like Transactions,Logs,Block,Header, for which we either need to add a bunch of generics or also do some kind of network trait with associated types...
perhaps, at some point it's just easier to simply duplicate the types but not sure if we want to

The block struct also needs to take a generic for example but that means many other dependent structs will need the same thing later. Making Transaction a trait here would solve such issue for example.
So far for optimism rpc types everything needed to take a generic, takes it with this pr (except block as that depends on the trait discussion)

these are reasonable,
I think we could also restrict this to : Transaction

Just updated that. We can add the log generic later when needed probably

Can we merge this? @mattsse @prestwich


Also log on button down during test

Only because it caught me out having forked your module for some other IO ( https://github.com/peternewman/VECFootpedal ) and assuming my code was broken when I didn't get the down too...

Thanks @peternewman. I'll pull this in.


Fixed a bug in CSV export (#3)

Fixed a bug in CSV export. This solves issue #3. Previously, the export would accidentaly leave out newlines, resulting in all csv content being in one long string. Also removed the output of the internal _id row identifier field from the content being exported. Also changed from the Windows newline character \r\n to \n.

Thanks for the contribution!


Node 6.10.x incorrectly triggers legacy debug mode

VSCode Version: 1.11.2
OS Version: Windows 10

Steps to Reproduce:

Install Node 6.10.x (I installed current LTS 6.10.2)
Debug any Node JS application
Debug Console reports Debugging with legacy protocol because Node v6.10.2 was detected.

My assumption is that the version parsing thinks 6.10.2 is earlier than 6.3 due to lexical comparison?

VS Code's automatic protocol switching uses the "inspector" protocol only for node.js >= 8.0 (although this protocol is already supported since node.js >= 6.3).
You can force VS Code to use the "inspector" protocol by adding a "protocol": "inspector" to your launch config.
See https://code.visualstudio.com/updates/v1_11#_transitioning-to-the-inspector-protocol and https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_supported-nodelike-runtimes

I've had a similar issue with a google api demo, I tried using Yarn instead of node start, so install yarn globally first, then run yarn start after npm install.. it may resolve the issue.

using Yarn cannot affect what debug protocol is being used.
My comment from above explains this.


Consider an onDidStopChangingActivePaneItem

Similar to the motivation behind TextEditor::onDidStopChanging,  clients of onDidStopChangingActivePaneItem should nearly always wait for a small time period before acting on the new pane item. If the user is quickly switching through tabs or closing several tabs in quick succession, work done on Workspace::onDidChangeActivePaneItem is likely wasted and can become a bottleneck for giving feedback to the user if they are switching/closing tabs quickly.
There's at least one candidate in core that could defer its actions until the active item has stopped changing: FileInfoView in the status bar https://github.com/atom/status-bar/blob/master/lib/file-info-view.coffee#L71.
Nuclide wrapped onDidChangeActivePaneItem to get this effect: https://github.com/facebook/nuclide/blob/master/pkg/nuclide/atom-helpers/lib/atom-event-debounce.js#L29
I think a DidStopChangingActivePaneItem should be recommended similar to the one in TextEditor if it's created.

GitView in the status bar is another candidate: https://github.com/atom/status-bar/blob/master/lib/git-view.coffee#L11

ImageView: https://github.com/atom/image-view/blob/master/lib/image-editor-status-view.coffee#L15
All of the synchronous updates can be seen by looking at the chart in a debugger profile.

Yeah, I think this would be a good change. I'd be glad to merge a PR adding this feature.

@maxbrunsfeld Awesome, I'm happy to add this. I'll send a PR in the next couple days.


Fan connector rating

What are the 3 case fan connectors rated for? Thanks!

for heat dissipation of course.

@yoyojacky sorry, I mean for wat wattage / current

Oh, sorry, I misunderstand your meaning,  the fan is 5V / 0.1A


Removing a school, then typing in "other" box does not save properly.

Steps to reproduce:

On account settings, enter a school, save it
Go back to account settings, remove the school, enter something in the other box, save it.

Already in api issue 53


One example to cripple the frontend

As @xieningning points out, the following example should be a valid program:
let rec
  map A B (f:A->B) (n:Int): Bool =
    if(n<0)
    then True
    else map A B f (n-1)
and
  f(x:Int):Int = x+1
in
  map Int Int f 6

However, I am confirmed that in develop branch, the above program crashed somewhere in the frontend, resulting the notorious segmentation fault.

 The branch is "develop". Please try. A drawback is that this approach is not efficient, but should be OK for now.

Link to commit a07e7f01b7397acf67c6307dacd880a213d72625

A temporary solution is working. @hy-zhang is implementing a better one.

@hy-zhang Is there a better one in plan, or we stick to the current one?


content security policy header will lose When status code is 304

Versions

nuxt: v2.14.7
node: v12.16.3

Reproduction

Additional Details

Steps to reproduce
What is Expected?
What is actually happening?
I have a website built with nuxt.js, when I first visit, it has the correct csp header which I set in nuxt.config.js. When I visit this website again, it will lose csp header. And I found that when status code is 304, csp header will lose.

@pi0 @danielroe Would you please have a look on this issue ?  Do you think it is a bug when http status code is 304, the CSP header will lose, if not, is there a configuration can make CSP header work as expected, if it is bug, do you have a plan to publish a patch because this can cause security problem because of the miss of CSP header. Thanks

This should be fixed in v2.14.8. Please reopen if not.

This should be fixed in v2.14.8. Please reopen if not.

Thanks. I have confirmed it was solved from v2.14.8


Glorious Segfault

Reproduction is fairly straightforward. I already took the liberty of finding the cause which I ended up doing with the Ghidra debugger. Having 3 separate debuggers for each language didn't suffice because it ended up being due to an exception from an exception being sent to python that was detected and causing a JPypeException to be thrown before going back to python and late enough in c++ to not know where it came from.
To reproduce simply create an interface such as the following and then attempt to import it in python.
public interface BadInterface {
    public void __del__();
}

Here is what happens when it the type is created.
https://github.com/jpype-project/jpype/blob/0bacb9e57003f74aec05029caf58e1c707882b9c/native/python/pyjp_class.cpp#L1191-L1193
The PyJPClass_Type->tp_new there ends up calling PyJPClass_new which then gets up to this point which sets the Python exception and returns NULL.
https://github.com/jpype-project/jpype/blob/0bacb9e57003f74aec05029caf58e1c707882b9c/native/python/pyjp_class.cpp#L102-L107
This then get's detected in the JP_PY_CHECK macro in JPPyObject::call which causes the JPypeException to be thrown. What happens from there I have no idea and probably shouldn't jump in without the necessary kevlar.
Hopefully this makes enough sense to hit the ground running at least.

This may have aleeady been addressed. ( Looks familiar.)  Did you try with master?

This may have aleeady been addressed. ( Looks familiar.)  Did you try with master?

Yes

Can you give some additional information on replication of this error?   I tried
import jpype
jpype.startJVM(classpath=".")
jpype.JClass("BadInterface")

and it gave me
Traceback (most recent call last):
  File "test5.py", line 4, in <module>
    jpype.JClass("BadInterface")
  File "/mnt/c/Users/nelson85/Documents/devel/open/jpype/jpype/_jclass.py", line 99, in __new__
    return _jpype._getClass(jc)
TypeError: finalizer conflict

which didn't match the reported symptoms because it wasn't a segfault.  My guess is that it did leave something in a bad state which lets to a later segfault, but not something replicable in my simple example.  I will try to identify what went wrong earlier in the process, but it would be good to be able to replicate the full bug to make sure it is addressed.  Will report when I make some progress.

Can you give some additional information on replication of this error?   I tried
import jpype
jpype.startJVM(classpath=".")
jpype.JClass("BadInterface")

and it gave me
Traceback (most recent call last):
  File "test5.py", line 4, in <module>
    jpype.JClass("BadInterface")
  File "/mnt/c/Users/nelson85/Documents/devel/open/jpype/jpype/_jclass.py", line 99, in __new__
    return _jpype._getClass(jc)
TypeError: finalizer conflict

which didn't match the reported symptoms because it wasn't a segfault.  My guess is that it did leave something in a bad state which lets to a later segfault, but not something replicable in my simple example.  I will try to identify what went wrong earlier in the process, but it would be good to be able to replicate the full bug to make sure it is addressed.  Will report when I make some progress.

from package packagename import BadInterface

Here is a full example to reproduce.
tmp.zip

(Thanks for the code and sorry for the slow response,  Been stuck doing 65 to 80 hour works for a work demo, so no time for fun projects.)
I modified the example to
import jpype
import jpype.imports

try:
    if __name__ == '__main__':
        jpype.startJVM(classpath=['tmp.jar'])
        from tmp import BadInterface
except Exception as ex:
    print("exception")

print("not segfault")

Version 1.3.0 windows:  exception, not segfault
Version 1.3.1 windows:  exception, not segfault
Version 1.3.0 linux:  exception, not segfault
Version 1.3.1 linux:  exception, not segfault
Thus all of the versions gave the same behavior.   Perhaps it is a different architecture?
There is no pattern which is producing a seg fault at least in this example when I tried each of the versions.   However, given that in all of them it is issuing an exception the issue is that it should have imported the bad class by ignoring the bad method name.    I will try to address that, but unless I can successfully replicate the segfault aspect I can't really address it.

I am sorry but I have tried for hours and I can't replicate what you are seeing.   No path I have tried results in a segfault and I have other work that I have to attend to.   I am going forward with the release which this issue is holding up.  If you can replicate the issue again after the release please reopen the ticket as applying the dunder fix will close this.

No problem. I'll try as hard as I can to break it again after the patch just to be sure and if I can't get it to crash it should be good enough for me.
It should have segfaulted immediately on import. If it doesn't for you then I'm wondering if it is jdk specific as I've replicated it on multiple machines. I'm using the latest eclipse temurin jdk 11


Support diff syntax highlighting in commit buffer

When I use -v switch in git, diff section have syntax highlighting, but in neogit it commented out.
Also can I change default switches? For example I'd like -v to be enabled by default.

When I use -v switch in git, diff section have syntax highlighting, but in neogit it commented out.

Basically you would like to have syntax highlighting for the diff output in the commit buffer?

Also can I change default switches? For example I'd like -v to be enabled by default.

https://github.com/TimUntersberger/neogit/issues/80

Basically you would like to have syntax highlighting for the diff output in the commit buffer?
Yes. Usually I'm using -v when commiting (or cvc in fugitive), and I'd like to verify that I commit exactly what I wanted. With syntax highlighting it's easier.

Did anything changed recently that would make highlighting in commit window working? I was just committing something and got surprised by highlights in there. @ten3roberts perhaps some of your recent work (thanks!)?

I guess.
The commit now uses git for calling neovim to edit the commit, rather than neogit calling git commit with the full commit message which was entered by the user.

In which case I think that issue can be closed.


stm32_eth: Lock the scheduler when reseting the MAC.

Summary
Following the discussion here, this PR ensures that the Ethernet error handling will be scheduled after the network has been unlocked.
Impact
Fix potential lock of the network.
Testing
Tested on custom target based on STM32F427.
I induced an artificial error with my debugger, and indeed the system recovers without any problem.
No scheduling problems were observed.

@davids5 please have a look.
I opted for locking of the scheduler instead of a critical section. I think it does the job correctly, with less impact on the real-time performance of the system.

Hmm, thinking of it again, I don't think that this PR is actually needed:

The work is queued (no network unlock yet).
This task is scheduled out, and eventually another worker starts the scheduled job (stm32_txtimeout_work).
It finds that the network is locked, and it is preempted.
Execution returns to stm32_interrupt_work(), it unlocks the network and exits.
Execution can now return to stm32_txtimeout_work() with the network unlocked.

So nothing wrong can happen. No dead-locks or similar issues.
Maybe leave it as is, and not introduce uneccesary code?
In fact the exact same condition is true for stm32_txavail(). It schedules a job with the network locked.
It can easily be preempted before it has the chance to unlock the network.
I think that no problems were ever observed with stm32_txavail(), but if this fix is actually needed, then both functions need to be fixed.
@davids5 once again your insight would be very helpful.

Maybe leave it as is, and not introduce uneccesary code?

If you have determined it is not an issue. Then yes. Just close this PR

Indeed, the sequence is exactly as stated above.
I added a delay in stm32_eth.c line 2058 (and several prints). This causes the worker (stm32_txtimeout_work) to start execution before the unlocking of the network.
There was no issue at all. The worker will wait, execution will return to stm32_interrupt_work which will properly unlock the network and return.
It could be considered a perfomance issue (as one worker will be blocked for a few microseconds),  but I don't think it is of any importance in any real-life scenario. This code will execute only in exceptional cases, and being interrupted by the new work job is very very unlikely, if not impossible.
I'll just close this.


Map boolean values to 0 or 1 if dialect is SqlServerDialect.

Closes #908

We discussed this internally and decided not to go with this approach.
Instead we'll allow dialects to register conversions and apply conversions on the parameter.