Remove unnecessary anonymous functions in defer statements

Summary
Throughout the codebase I've noticed several defer statements that are wrapped in an anonymous function, e.g. this one
	defer func() {
		telemetry.IncrCounter(1, "ibc", "connection", "open-try")
	}()

can be changed to
defer telemetry.IncrCounter(1, "ibc", "connection", "open-try")

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Hi sir @chatton, Can I take this issue?

Hi sir @chatton, Can I take this issue?

Yes, that would be lovely. Thank you!


Update GH Actions Buildkite Plugin

The current GH Actions plugin for triggering Builkite jobs uses deprecated commands https://github.com/Zegocover/buildkite-pipeline-action/blob/master/main.py#L122-L127 that:

Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error.

Instead of fixing it in original repository or creating a fork with fix this Pull Request switches to new and official plugin which in effect will resolve all issues.
Article here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Skipping this update - Main branch will be used only as a placeholder for selecting branch on which the proper/updated version of GH workflow is placed on.


Feature/rtodling/v10 17 3 br

Guys,
This is a fold (rather than a merge in the proper sense of the word) for GMAO_Shared where I (think I) have the stuff that is in 5.27 combined w/ what is in the develop/main branch of GMAO_Shared as used by the model group.
I tried bringing this version back into 5.27 to give it a try, but aside from triviality in the CMakeLists related to MAPL vs MAPL_base, I am finding that the changes in @GMAO_Shared/GEOS_Share   are a lot more involved bring back into the DAS - it will require editing back the MAPLmod - MAPL changes in the source code ... not sure that's worth for me to make sure the changes I made a still consistent and work within the DAS. I might still try doing that, but I should not hold you back in trying to bring this in sync w/ your placing merge of DAS and MAPL 2+other.
Let me know what you think.
Ricardo

One thing that we may want to contemplate to simplify updating ADAS to the latest versions of the infrastructure is to split GMAO_Shared into its separate repos for each directory.    At least then, ADAS could probably get to the latest of almost everything and we could focus on just the pieces that are problematic.
Of course it would have been more useful to do this a year ago.   But still worth considering.

I think splitting might be okay - but I'd suggest getting this to work as they are for the moment.

Any update on this? Do you need me to fix the small glitches?

Any update on this? Do you need me to fix the small glitches?

Whoops. This got lost on my radar. Let me try and fix the build issue.

@sdrabenh As far as I can see, this is a zero-diff update to GMAO_Shared in so far as the GEOSgcm cares. I did C48 and all was zero-diff.

This PR looks okay to me and passes all my tests. Before I approve and merge, I want to ping @biljanaorescanin and @yvikhlya to make sure this doesn't inadvertently create issues with ldas or the coupled model, respectively.

This PR looks okay to me and passes all my tests. Before I approve and merge, I want to ping @biljanaorescanin and @yvikhlya to make sure this doesn't inadvertently create issues with ldas or the coupled model, respectively.

None of these updates affects the coupled model as I see it.

This PR looks okay to me and passes all my tests. Before I approve and merge, I want to ping @biljanaorescanin and @yvikhlya to make sure this doesn't inadvertently create issues with ldas or the coupled model, respectively.

I think we are good as well.

Wow. I approved this PR for a lot of teams. 😄


BTN_WEST and BTN_NORTH are switched in Linux

I'm using a gamepad for input to a program on Windows and Linux and I've found that BTN_WEST and BTN_NORTH are swapped in Linux.

Update: I've noticed that the switching of the two buttons only happens if I run the script when not using root (sudo). If I use root, then it's fine.


[DO NOT MERGE] Implement ValueEnumerable

This is the corresponding implementation for apple/swift-evolution#114 "Deriving collections of enum cases".
Prior Discussion
swift-evolution discussion thread (other related threads are linked in the proposal).
Proposal Text
Rendered Markdown.

恭賀新年！ Happy New Year.
Poor swift-ci, never gets a break though.
@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - a726f8f9fd574258701ca5fb89df8c0532c1987a

Build failed
Swift Test OS X Platform
Git Sha - a726f8f9fd574258701ca5fb89df8c0532c1987a

@swift-ci please smoke test

@swift-ci please smoke test

I've addressed what you've reviewed so far.  I'll cast off the [DO NOT MERGE] and squash the patch when I'm less sleep-deprived.

Sounds great!

With the acceptance I’m going to merge this through and file SRs to investigate the following outstanding issues:

A generalized implementation of synthesis that accounts for availability attributes and maintains the source-order invariant.
Potentially changing the Collection we default to from an Array.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test source compatibility

@swift-ci please test source compatibility

⛵

Awesome! @CodaFi , can you update the ChangeLog?

@CodaFi @DougGregor Is there a default implementation of CaseIterable for Hashable enums? For instance, could we add the following extension to Swift?
extension CaseIterable where Self: Hashable {
    static var allCases: [Self] {
        return [Self](AnySequence { () -> AnyIterator<Self> in
            var raw = 0
            return AnyIterator {
                let current = withUnsafeBytes(of: &raw) { $0.load(as: Self.self) }
                guard current.hashValue == raw else {
                    return nil
                }
                raw += 1
                return current
            }
        })
    }
}

Or is it not needed, and CaseIterable will already work by itself for Hashable enums?
What about enum that conforms to String?

@Coeur Any enumeration without associated values gets its allCases requirement synthesized without any extra work, even when it has a raw value type like String:
enum Suit: String, CaseIterable {
  case spades, hearts, clubs, diamonds
}
Suit.allCases
// [Suit.spades, Suit.hearts, Suit.clubs, Suit.diamonds]
Suit.allCases.map({ $0.rawValue })
// ["spades", "hearts", "clubs", "diamonds"]

This is the implementation of SE-0194.


(1.19.2) Enchanted books don't show up

(1.19.2)
I attempted to add enchanted books to the "user_added_traded" (specifically mending) and the wandering traders spawned only once with it. All other 20-ish traders spawned (with an egg) didn't have it. Adding normal items to the array still works. I based the identifier of the mending book off of the syntax of the /give command, so maybe there is a syntax for enchanted books that I don't know about or it just doesn't work.
I just want to know which is true :)

I don't think you're using the correct identifier. Also, I'm planning on overhauling the codebase for this mod to make it easier for people to use since it's currently quite confusing to try and add new trades. It might be worth waiting for the refactored version of Better Wandering Traders before you add custom trades.

Thanks for the reply <3


[Bug] 404 Not Found on routes with parameters

The links with parameters are throwing 404 errors when the page loads. For example, one of my route is
 <Route exact path="/article/:id" component={Article} />
The article ids are coming from the backend. So when I load the page I get 404 on
http://localhost:3002/__react-static__/routeInfo/article/1
http://localhost:3002/__react-static__/routeInfo/article/2
http://localhost:3002/__react-static__/routeInfo/article/3
How can we resolve this issue?

Have you tried coupling one of the dynamic routing guides (https://github.com/nozzle/react-static/tree/master/docs/guides) with https://github.com/nozzle/react-static/blob/master/docs/api.md#addprefetchexcludes in your App.js?

Yes. I did.


API docs: copyedits in followup to #124

Post-review edits to address comments made in #124
cc @kwalrath

Ok, thanks.


Audit out the various ways of having transcripts of Soundcloud embeds

Whilst looking at #10182, we uncovered a few more uses of transcripts that were done differently (not using the discussion slice). As we'd like it to be aligned across, I'll create a doc listing all 55 Soundcloud embed usages and how they will require modifications.
See Slack conversation.

https://docs.google.com/spreadsheets/d/1985WBE-9oXyV3qrYliShlaATpiUA68nEn8kDxqVIMU8/edit#gid=0

Done with the audit; as determined with editorial, Audio Player AND Embed will get a new transcript field, so I don't think Discussion needs to be replaced by a Text slice anywhere. Once the new field is added, I'll just be able to move the Discussion slice content to the new Transcript field and then delete Discussion slice.
See Slack recap