Fix warnings caused by non-idiomatic returns

This PR enables Clippy's let_and_return and needless_return lints, and fixes related warnings.
P.S. I also noticed something strange, which is not related to this PR, but I think it's worth mentioning. Some blocks of code are marked with #[cfg(debug)] attributes (for example). The intent is clear - to have additional functionality in debug builds, which must not present in the release ones. The problem is that there's no such configuration in Rust. So, currently, all code that is marked with such attribute is completely ignored. The closest value of this attribute with the desired behavior is debug_assertions. Is there really something wrong, or there's a way to make #[cfg(debug)] working?

Coverage decreased (-0.003%) to 81.169% when pulling 2387d343c3f8afb89f385da9d38f1c4577973254 on vladimir-kazakov:fix-clippy-non-idiomatic-returns into ff5bd0b6141f8e37c88cda6af752c400184d0760 on xiph:master.


Upgrade Azure.ResourceManager.EventHubs to 2023-01-preview

Fixes https://github.com/Azure/azure-sdk-for-net/issues/43750

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.EventHubs


Public Comment

Check Div sizes in all pages.  There is a slight scroll for several pages that do not require a scroll for the content.It looks like it relates to the Height of the Nav Bar at the top of the page.

Let's try to have this work completed by this Friday if possible.


Added dataCube API for getting dimensions from row key

This datacube api is helpful to retrieve dimensions from
row key while performing scan of datacube hbase table.
Change-Id: I5644f8680a3ede793e10696ea2efe6d78fc4568c

@hackersOfhackers just wanted to let you know that review of this PR is on our todo lists, but it's a bit hectic over here.


New version: Loom.Loom version 0.249.0

Created by 🥟 Dumplings in workflow run #7502.

Log
Updated: 0.248.3 → 0.249.0
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

/azp run

This package installs and launches normally on a Windows 10 VM.


Add sink fetch to fetch everything

title

Yup, I was thinking about doing this yesterday after having to fetch for primary-22.


[zh-cn] Remove redundant comments and punctuation

Remove redundant comments and punctuation
https://kubernetes.io/zh-cn/docs/contribute/localization/#localize-the-community-code-of-conduct

Preview page: https://deploy-preview-36920--kubernetes-io-main-staging.netlify.app/zh-cn/docs/contribute/localization/

/lgtm
/approve


Small improvements to the error-handling wording

Sidenote. I feel this sentence:

All errors originating from Node.js core are marked with err.type = 'system', and in addition contain an err.code and an err.errno for error handling. These are aliases for error codes thrown by Node.js core.

Could be a little more clear on the distinction between code and errno, or at least link to the relevant Node documentation. I'd add it myself but I'm not clear on the distinction myself 😅 .
Thanks for a great lib!

Codecov Report

Merging #269 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #269   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines         388    388
  Branches      118    118
=====================================
  Hits          388    388

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5ff203...1797181. Read the comment docs.

LGTM. I must have been sleeping the last time I edited these docs 😟, so thanks a lot!
The relevant Node.js documentation should be found here: https://nodejs.org/api/errors.html#errors_system_errors. Let me know if that's what you are looking for.

LGTM, so I merged it. Thx for the check!

@TimothyGu No problem 😄 . Been there.
Ah, those core Error properties are quite easy to find.
Cheers!


rsquare metric

This PR contains a script for adding R-Square metric.
Sample colab: https://colab.research.google.com/drive/1Qh3zYhpoB_Ln6O2d6YSBqviYsuw0W9VS

I have MAC and facing issue in building addons. So, I tested code in colab.
Please let me know what will be my next steps. To do as far as I know will be to add test for the same.

Thanks @Squadrick
Will update soon

@Squadrick
Updated changes. I will work on test cases.

Added test cases

@SSaishruthi Could you include the tests in the PR? Also, you need to add this to run the test cases in graph and eager mode.

@Squadrick I have added test files in PR. Do you mean to add this line?

Hi @Squadrick
Updated scripts. Please let me know for any changes.
Colab: https://colab.research.google.com/drive/1Qh3zYhpoB_Ln6O2d6YSBqviYsuw0W9VS

@SSaishruthi I'm gonna trigger the pre-submit tests, you might have to make a few more changes after that.

Hi @Squadrick
Updated code as per the comments.

@SSaishruthi Your BUILD file formatting is incorrect, once you fix that the tests should pass.

@Squadrick
I think I have missed , in BUILD. Updated now. Can you please trigger the test?

@Squadrick Thanks for the review and helping me through this.


Issue when importing or when i run task

It seems as if the feedme plugin only creates an entry for the first item on the rss/xml feed. I do see all the feed items on the craft_entryversions table but not the backend in craft or the front end using twig.
The logs shows all the items but they all seem to have the entry_id
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
12/30/2016 12:11 PM
The Fresh Pita: Entry successfully added: 966
This happens when i try to run the task or when i go through the process of setting up the feed and then importing.

Can you submit a Help request? Its likely the Primary Element is mis-configured, or the unique identifier.

Closed due to inactivity.


add gcp regions module

closes #8

Let me see if I can add that now. Otherwise, I can add in a separate PR.


Move Fhp\DataTypes\Bin to Fhp\Syntax\Bin

See commit message.

After this PR is probably a good time to snapshot the current state into a v1 branch in case anyone wants bug fixes for that in the future. My next PR will delete the old implementation, to then replace it with the new one.

Done :blush:


Update README.md

For some reason the parenthesis are needed which is consistent to the syntax in the vending machine example.

Thanks! I'll merge this. Just FYI, I'm currently working on developing a simpler, less ad-hoc version of this library. If you know what might be useful, in terms of features etc., please let me know!


Support for Chainer 2.0

There are issues running the current build, due to code-breaking changes introduced in Chainer version 2.0.  We should specify the chainer version during the installtion process as 1.24.0 or make changes to the existing code to support v2.
@aonotas, Let me know if you need me to send a pull request.

hi @harsha-surukam and @aonotas, I have edited deep-crf for chainer v2 support last week.
so I make the pull request.
please tell me if there are something wrong... (I am newbie to chainer.

@himkt I guess, you have commented out the problematic parts. This definitely works, but, the better solution imho would be to upgrade from v1 to v2 according to the [guide].(http://docs.chainer.org/en/stable/upgrade.html).

@harsha-surukam thanks for reply 😃
I understand that it needs to follow the upgrade guide, I close the pull request.

@harsha-surukam Thank you for your comments!
If you have edited v2 support, please send me PR.

I think we need fix deep-crf code following points:

train argument in dropout
volatile  argument in Variable
use_cudnn  argument in L.NStepBiLSTM

Should we switch code according to chainer.__version__?

Yes, I think that should help identify the installed version of chainer. But, I'm not sure if it's a good idea to have two branches in the code, based on the version of a library. Is it the best practice?
Or, should we just enforce people to upgrade chainer? Because, currently the default chainer version installed is 2.0.

I asked Chainer developer just now.
He told me that we need to branch code based on chainer.__version__.

Cool. Let me send you a PR in a bit.

Thank you for your help!!

Hi @harsha-surukam
Now deep-crf can run on v2.0 and v1.24.0!


As an master of event I want to create the list of inventory so event's participants will be able to assign them

Changed to card Epic 1


Fix link to keybindings tab in help menu on Windows

This one wasn't too bad to solve once I got my windows machine running a Tauri dev build.
The problem had something to do with how relative URI paths are processed by react-router's navigate() function, specifically how it processes the current pathname. In this HelpMenu component, we used a relative path because it needs to work on the Home route and in the File route. We can circumvent the issue by navigating with absolute file paths, like we do for the links to the settings panes in the popover menus.

Confirmed that this works running on MacOS in a tauri dev build, and in the browser

we will want tauri tests / playwrightt tests / whatever for this eventually


Build all packages requiring Python additionally with Python 3.8 and 3.9

@mithro (https://github.com/litex-hub/litex-conda-eda/pull/68#issuecomment-767706800):

All packages which require Python should build for Python 3.7, Python 3.8, Python 3.9
The reason I was suggesting everything is there is some subtle complexity around the dependencies of Python itself can conflict with dependencies of the other packages.

This can be done in the same way as in the surelog, yosys and symbiyosys recipes from #68.

@ajelinski - We should figure out how to do this automatically? We should always be supporting the latest 3 versions of Python.

@ajelinski - We should figure out how to do this automatically? We should always be supporting the latest 3 versions of Python.


Invalid argument(s): Cannot find executable for E:\software\Android\flutter_windows_1.22.2-stable\flutter\bin\cache\artifacts\engine\android-arm64-release\windows-x64\gen_snapshot."

Steps to Reproduce

Download project from https://github.com/zhaopingfu/FlutterReleaseCrash.
Open project flutter_crash_module,  open terminal and exec command flutter pub get.
Open project FlutterReleaseCrash,  open terminal and exec command ./gradlew clean && ./gradlew assembleRelease --stacktrace.

Expected results:
Build successful.
Actual results:
Invalid argument(s): Cannot find executable for E:\software\Android\flutter_windows_1.22.2-stable\flutter\bin\cache\artifacts\engine\android-arm64-release\windows-x64\gen_snapshot."

Logs
Flutter crash report.
Please report a bug at https://github.com/flutter/flutter/issues.

## command

flutter --quiet assemble --depfile C:\Users\13081\Desktop\FlutterReleaseCrash\flutter_crash_module\.android\Flutter\build\intermediates\flutter\release/flutter_build.d --output C:\Users\13081\Desktop\FlutterReleaseCrash\flutter_crash_module\.android\Flutter\build\intermediates\flutter\release -dTargetFile=lib/main.dart -dTargetPlatform=android -dBuildMode=release -dTrackWidgetCreation=true android_aot_bundle_release_android-arm android_aot_bundle_release_android-arm64 android_aot_bundle_release_android-x64

## exception

ArgumentError: Invalid argument(s): Cannot find executable for E:\software\Android\flutter_windows_1.22.2-stable\flutter\bin\cache\artifacts\engine\android-arm64-release\windows-x64\gen_snapshot.

#0      _getExecutable (package:process/src/interface/local_process_manager.dart:125:5)
#1      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:41:30)
#2      ErrorHandlingProcessManager.start. (package:flutter_tools/src/base/error_handling_io.dart:462:33)
#3      _run (package:flutter_tools/src/base/error_handling_io.dart:356:20)
#4      ErrorHandlingProcessManager.start (package:flutter_tools/src/base/error_handling_io.dart:462:12)
#5      _DefaultProcessUtils.start (package:flutter_tools/src/base/process.dart:477:28)
#6      _DefaultProcessUtils.stream (package:flutter_tools/src/base/process.dart:496:35)
#7      GenSnapshot.run (package:flutter_tools/src/base/build.dart:74:26)
#8      AOTSnapshotter.build (package:flutter_tools/src/base/build.dart:198:56)
#9      AndroidAot.build (package:flutter_tools/src/build_system/targets/android.dart:248:52)
#10     _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:801:27)

#11     _BuildInstance.invokeTarget. (package:flutter_tools/src/build_system/build_system.dart:744:35)
#12     new Future.sync (dart:async/future.dart:223:31)
#13     AsyncMemoizer.runOnce (package:async/src/async_memoizer.dart:43:45)
#14     _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:744:21)

#15     MappedListIterable.elementAt (dart:_internal/iterable.dart:417:31)
#16     ListIterator.moveNext (dart:_internal/iterable.dart:343:26)
#17     Future.wait (dart:async/future.dart:406:26)
#18     _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:739:45)
#19     FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:566:36)
#20     AssembleCommand.runCommand (package:flutter_tools/src/commands/assemble.dart:221:58)
#21     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:977:18)
#22     _rootRunUnary (dart:async/zone.dart:1198:47)
#23     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#24     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#25     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#26     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#27     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#28     Future._asyncCompleteWithValue. (dart:async/future_impl.dart:567:7)
#29     _rootRun (dart:async/zone.dart:1190:13)
#30     _CustomZone.run (dart:async/zone.dart:1093:19)
#31     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#32     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:1037:23)
#33     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#34     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#35     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#36     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)

## flutter doctor

[✓] Flutter (Channel stable, 1.22.2, on Microsoft Windows [Version 10.0.18362.959], locale zh-CN)
• Flutter version 1.22.2 at E:\software\Android\flutter_windows_1.22.2-stable\flutter
• Framework revision 84f3d28555 (3 days ago), 2020-10-15 16:26:19 -0700
• Engine revision b8752bbfff
• Dart version 2.10.2
• Pub download mirror https://pub.flutter-io.cn
• Flutter download mirror https://storage.flutter-io.cn
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at E:\software\Android\android_sdk
• Platform android-30, build-tools 30.0.2
• ANDROID_HOME = E:\software\Android\android_sdk
• Java binary at: E:\software\Android\AndroidStudio4.1\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[✓] Android Studio (version 4.0)
• Android Studio at E:\software\Android\AndroidStudio4.0
• Flutter plugin version 50.0.1
• Dart plugin version 193.7547
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[!] Android Studio (version 4.1.0)
• Android Studio at E:\software\Android\AndroidStudio4.1
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[✓] Connected device (1 available)
• SM G9730 (mobile) • R28M31LGZFJ • android-arm64 • Android 9 (API 28)
! Doctor found issues in 1 category.
</details>

Similar to https://github.com/flutter/flutter/issues/68120 however this one happens on the latest stable version.
Not sure if we should consider it as a duplicate.
Cc @jonahwilliams.

flutter  pub global activate webdev
seems to help a little bit

You need to run at least one flutter Android-related command (like flutter build apk) to cache the Android artifacts before you run gradlew directly.  flutter pub get doesn't try to download and install them because it's platform agnostic.

In case if you are creating the release apk, make sure ..flutter/bin/cache/artifacts/engine/android-arm-release/darwin-x64 has gen_snapshot.exe file


[rtl] Implement mvendorid/marchid/mimpid CSRs

I'd be interested in adding a bit more guidance to users of Ibex what they should and should not do with those IDs

Given what these are for is part of the RISC-V specification I was trying to avoid saying too much about them in the documentation as we don't just want to repeat the specification. I could add something saying look at the specific for further details.

And if we want to encourage changing the IDs, maybe putting them in a place that requires less RTL modifications (such as a package) or even a top-level parameter?

I can move them to the top-level package. Trying to avoid drowning Ibex in too many top-level parameters and these aren't things you're likely to want to change on an instantiation by instantiation basis.

Given what these are for is part of the RISC-V specification I was trying to avoid saying too much about them in the documentation as we don't just want to repeat the specification.

Yes, but nobody ever reads the spec :smile:  So if we can give people a hint in the "how to use ibex for your project" section of the docs (https://ibex-core.readthedocs.io/en/latest/02_user/getting_started.html) that they should maybe change mimpid if they make small changes to Ibex, and mvendorid/marchid when they make massive changes to it, but leave the identifiers as they are if they take ibex as-is?

@imphil I've added a paragraph to the docs in getting started

Hey @GregAC ,
it has been a while since the last activity in this PR. But it's already approved and if I understand correctly, the changes are absolutely uncontroversial. We could just rebase and merge this PR. Or is there is there still something missing?

Ah well spotted, think I simply forgot to hit the merge button! There's a potential add-on in using mimpid to differentiate different Ibex configs but can deal with that in a follow up if desired.

Ah, great. Thanks for the quick feedback Greg.


Stack Traceback when running with -onastick

Hi,
I'm seeing a problem with starting the lwaftr when -onastick is used.
service lwaftr start
Starting lwaftr: root@bn831-dcdev-10a-lab:/opt/snabb/conf# /opt/snabb/conf/lwaftr-315-onastick.conf: loading compiled configuration from /opt/snabb/conf/lwaftr-315-onastick.o
/opt/snabb/conf/lwaftr-315-onastick.conf: compiled configuration is up to date.
Bound main process to NUMA node: 	0
Bound data plane to CPU:	6
apps/lwaftr/ipv6_apps.lua:145: Could not resolve IPv6 address: 2003:1b0b:fffd:831::1
stack traceback:
core/main.lua:149: in function <core/main.lua:147>
[C]: in function 'error'
apps/lwaftr/ipv6_apps.lua:145: in function 'maybe_send_ns_request'
apps/lwaftr/ipv6_apps.lua:167: in function 'method'
core/app.lua:89: in function 'with_restart'
core/app.lua:463: in function 'thunk'
core/histogram.lua:98: in function 'breathe'
core/app.lua:410: in function 'main'
program/lwaftr/setup.lua:507: in function 'run_worker'
[string "require('program.lwaftr.setup').run_worker({[..."]:1: in function 'f'
core/main.lua:58: in function <core/main.lua:43>
[C]: in function 'xpcall'
core/main.lua:211: in main chunk
[C]: at 0x00452d30
[C]: in function 'pcall'
core/startup.lua:3: in main chunk
[C]: in function 'require'
[string "require "core.startup""]:1: in main chunk
Here's the config of the attached router interface (Cisco ASR9k - works fine using same config params(other interface) when not onastick):
RP/0/RSP0/CPU0:bn831x1-r2-29-1a-lab#show run int te 0/2/0/0.125
Thu Jan 12 11:25:10.056 UTC
interface TenGigE0/2/0/0.125
ipv6 nd suppress-ra
ipv6 address 2003:1b0b:fffd:831::1/64
ipv6 enable
encapsulation dot1q 125
!
And the relevant part of the .conf file for the lwaftr
And interfaces part of the .conf file:
external-interface {
error-rate-limiting {
packets 600000;
}
ip <IP_ADDRESS>;
mac 52:52:00:00:00:01;
mtu 1500;
next-hop {
ip <IP_ADDRESS>;
}
reassembly {
max-fragments-per-packet 40;
}
vlan-tag 164;
}
internal-interface {
error-rate-limiting {
packets 6000;
period 4;
}
ip 2003:1b0b:fffd:831::4000;
mac 52:52:00:00:00:02;
mtu 9220;
next-hop {
ip 2003:1b0b:fffd:831::1;
}
reassembly {
max-fragments-per-packet 40;
}
vlan-tag 125;
}
I also tried replacing the next-hop ipv6 address with a MAC address:
internal-interface {
error-rate-limiting {
packets 6000;
period 4;
}
ip 2003:1b0b:fffd:831::4000;
mac 52:52:00:00:00:02;
mtu 9220;
next-hop {
mac 04:6c:9d:59:e8:e8;
}
reassembly {
max-fragments-per-packet 40;
}
vlan-tag 125;
}
This results in:
./lwaftr-onastick.sh
/opt/snabb/conf/lwaftr-315-onastick.conf: loading compiled configuration from /opt/snabb/conf/lwaftr-315-onastick.o
/opt/snabb/conf/lwaftr-315-onastick.conf: compiled configuration is out of date; recompiling.
/opt/snabb/conf/lwaftr-315-onastick.conf: loading source configuration
/opt/snabb/conf/lwaftr-315-onastick.conf: wrote compiled configuration /opt/snabb/conf/lwaftr-315-onastick.o
Bound main process to NUMA node: 	0
apps/config/channel.lua:54: error opening file "/var/run/snabb/4162/config-follower-channel": No such file or directory
stack traceback:
core/main.lua:149: in function <core/main.lua:147>
[C]: in function 'error'
apps/config/channel.lua:54: in function 'open_ring_buffer'
apps/config/channel.lua:103: in function 'open'
apps/config/leader.lua:659: in function 'send_messages_to_followers'
apps/config/leader.lua:680: in function 'method'
core/app.lua:89: in function 'with_restart'
core/app.lua:454: in function 'thunk'
core/histogram.lua:98: in function 'breathe'
core/app.lua:410: in function 'main'
program/lwaftr/run/run.lua:221: in function 'run'
program/lwaftr/lwaftr.lua:17: in function 'run'
core/main.lua:67: in function <core/main.lua:43>
[C]: in function 'xpcall'
core/main.lua:211: in main chunk
[C]: at 0x00452d30
[C]: in function 'pcall'
core/startup.lua:3: in main chunk
[C]: in function 'require'
[string "require "core.startup""]:1: in main chunk
Thanks,
Ian

Hi Ian,
Could we have lwaftr-onastick.sh and/or a copy of the exact command line you're using?
My colleague Diego was trying to reproduce this, and has confirmed that a case we typically use works, but it's somewhat different to yours:
I tested on-a-stick and apparently it works, for instance: $ sudo ./snabb lwaftr run --reconfigurable --name lwaftr --conf lwaftr-migrated.conf --on-a-stick 83:00.0Options
13:43and then: $ sudo ./snabb lwaftr loadtest -D 1 -b 5e9 -s 0.2e9 from-inet-0550.pcap "NIC 0" "NIC 0" 03:00.0

Hi,
Here it is:
#!/bin/bash
SNABBPATH=/opt/snabb/src
SNABBCONFPATH=/opt/snabb/conf
Set CPU Frequency
for CPUFREQ in /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor; do
[ -f $CPUFREQ ] || continue;
echo -n performance > $CPUFREQ;
done
sudo $SNABBPATH/snabb lwaftr run --cpu 6 --ring-buffer-size 1024
--conf $SNABBCONFPATH/lwaftr-315-onastick.conf --reconfigurable
--on-a-stick 0000:04:00.0


Added armory kb documents

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: _Uploading rest of Armory kb docs from servicenow
Jira/GitHub Issue numbers (if any): ASSMT-305
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67104019a963f3230a84a6f7--harness-developer.netlify.app


Speed up tests

Subsample test datasets even further

Tests passed 4 times on my PC (and on CI) so seem to be stable


avoid negative value for lanes

https://www.openstreetmap.org/way/579904092
https://taginfo.openstreetmap.org/tags/lanes=-1
It would be nice if the "-" button avoid negative value

Hmm yeah this is a good suggestion.. We need it for layer=* but probably not for most tags.


Make graphql_object macro supports deriving object field resolvers

This PR enhance the graphql_object macro to optionally derive field resolvers for fields defined in the object type struct.
#[derive(GraphQLObjectInfo)]
#[graphql(scalar = DefaultScalarValue)]
struct Obj {
    regular_field: bool,
}

#[juniper::graphql_object(derive_fields)]
impl Obj {
    fn custom_field_resolve() -> bool {
        true
    }
}

I am pretty new to rust, please let me know if I have done anything incorrect. And I am not a native speaker of english, feel free to correct the wording of my comments. Cheers!

Related: #553

Not sure how to add reviewers, would be great if anyone can help. Thanks!
^^ @LegNeato @jmpunkt @Victor-Savu

While I was working on the PR, I also noticed a few potential issues. But I am not sure who to talk to or maybe they are actually intended or work-in-progress features:

Looks like its a typo?
https://github.com/graphql-rust/juniper/blob/d13305f2029c12b11844b2fdf941f081e835a366/juniper_codegen/src/util/mod.rs#L649

Derive GraphQLObject macro for struct with lifetime doesn't work. The following struct found in a test suite, which can reproduce the issue, but seems its not been used in any test case.
https://github.com/graphql-rust/juniper/blob/d13305f2029c12b11844b2fdf941f081e835a366/integration_tests/juniper_tests/src/codegen/derive_object.rs#L63-L66

Derive GraphQLObject macro requires scalar attribute, otherwise generic __S will be used instead of the default DefaultScalarValue. For instance

#[derive(GraphQLObject)]
struct Object {
    value: i32,
}

should be the same as
#[derive(GraphQLObject)]
#[graphql(scalar = juniper::DefaultScalarValue)] // <---- here
struct Object {
    value: i32,
}

You can fix the typo.
Do you know why this does not work? Is the lifetime parameter missing at the generics definition?
There is an issue related to this (https://github.com/graphql-rust/juniper/issues/580). Not sure how to deal with this, I would ignore it for now. A workaround for this is to specify #[graphql(Scalar = juniper::DefaultScalarValue)]

Thanks @jmpunkt !
Re 2:
Given the following code:
mod test {
    #[derive(juniper::GraphQLObject)]
    #[graphql(scalar = juniper::DefaultScalarValue)]
    struct WithLifetime<'a> {
        value: &'a str,
    }

    struct Query;

    #[juniper::graphql_object(scalar = juniper::DefaultScalarValue)]
    impl<'a> Query {
        fn with_lifetime(&self) -> WithLifetime<'a> {
            WithLifetime { value: "blub" }
        }
    }
}

Here is the compile error, which I think it is related to the async resolver (but can be wrong):
error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements
  --> integration_tests/juniper_tests/src/lib.rs:20:5
   |
20 |     #[juniper::graphql_object(scalar = juniper::DefaultScalarValue)]
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: first, the lifetime cannot outlive the lifetime `'a` as defined on the impl at 21:10...
  --> integration_tests/juniper_tests/src/lib.rs:21:10
   |
21 |     impl<'a> Query {
   |          ^^
note: ...so that the expression is assignable
  --> integration_tests/juniper_tests/src/lib.rs:20:5
   |
20 |     #[juniper::graphql_object(scalar = juniper::DefaultScalarValue)]
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: expected  `foo::WithLifetime<'_>`
              found  `foo::WithLifetime<'a>`
note: but, the lifetime must be valid for the lifetime `'b` as defined on the method body at 20:5...
  --> integration_tests/juniper_tests/src/lib.rs:20:5
   |
20 |     #[juniper::graphql_object(scalar = juniper::DefaultScalarValue)]
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...so that the expression is assignable
  --> integration_tests/juniper_tests/src/lib.rs:20:5
   |
20 |     #[juniper::graphql_object(scalar = juniper::DefaultScalarValue)]
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = note: expected  `std::pin::Pin<std::boxed::Box<(dyn core::future::future::Future<Output = std::result::Result<juniper::value::Value, juniper::executor::FieldError>> + std::marker::Send + 'b)>>`
              found  `std::pin::Pin<std::boxed::Box<dyn core::future::future::Future<Output = std::result::Result<juniper::value::Value, juniper::executor::FieldError>> + std::marker::Send>>`

Here is the generated GraphQLTypeAsync for Query:
    impl<'a> juniper::GraphQLTypeAsync<juniper::DefaultScalarValue> for Query
    where
        juniper::DefaultScalarValue: Send + Sync,
        Self: Send + Sync,
    {
        fn resolve_field_async<'b>(
            &'b self,
            info: &'b Self::TypeInfo,
            field: &'b str,
            args: &'b juniper::Arguments<juniper::DefaultScalarValue>,
            executor: &'b juniper::Executor<Self::Context, juniper::DefaultScalarValue>,
        ) -> juniper::BoxFuture<'b, juniper::ExecutionResult<juniper::DefaultScalarValue>>
        where
            juniper::DefaultScalarValue: Send + Sync,
        {
            use futures::future;
            use juniper::GraphQLType;
            match field {
                "withLifetime" => {
                    let res: WithLifetime<'a> = (|| WithLifetime { value: "blub" })();
                    let res2 = juniper::IntoResolvable::into(res, executor.context());
                    let f = async move {
                        match res2 {
                            Ok(Some((ctx, r))) => {
                                let sub = executor.replaced_context(ctx);
                                sub.resolve_with_ctx_async(&(), &r).await
                            }
                            Ok(None) => Ok(juniper::Value::null()),
                            Err(e) => Err(e),
                        }
                    };
                    use futures::future;
                    future::FutureExt::boxed(f)
                }
                _ => {
                    {
                        ::std::rt::begin_panic_fmt(&::core::fmt::Arguments::new_v1(
                            &["Field ", " not found on type "],
                            &match (
                                &field,
                                &<Self as juniper::GraphQLType<juniper::DefaultScalarValue>>::name(
                                    info,
                                ),
                            ) {
                                (arg0, arg1) => [
                                    ::core::fmt::ArgumentV1::new(arg0, ::core::fmt::Display::fmt),
                                    ::core::fmt::ArgumentV1::new(arg1, ::core::fmt::Debug::fmt),
                                ],
                            },
                        ))
                    };
                }
            }
        }
    }

While I like the idea of this in general, I think it massively complicates the UX for folks to save on some typing. This reminds me a lot of Rust accessors and transparent newtypes. Rust itself requires boilerplate (self.0) but people who mind the repetition build a layer on top with proc macros and there are multiple libraries that do it based on various tradeoffs. I always assumed people would just use the proc macro with a bit of boilerplate and use juniper_codegen to make their own macros with their preferred tradeoffs if this was an issue.
Personally, I like how simple and explicit the UX is right now. Either it graphql projection is trivial and the derive suffices or it is complex and everything is right there in the impl.
I'm happy to entertain a patch if we can keep this simple and explicit. I'm not sure we can get there with rust proc macros as-is though 🤷

@LegNeato Thanks for your reply, I understand your concern and agree that Juniper should not be opinionated.
However, since juniper_codegen already achieved a great effort on collecting necessary information to build GraphQL schema (such as fields for object / input types, field resolvers, etc), is it possible to expose these collected information to the user instead of generating the GraphQLType directly, so that user can use these information in their own macro to generate GraphQLType.
For example juniper can generate GraphQLTypeInfo that holds such information, similar to what this PR does. Then I can build my own graphql_object macro with the functionalities I need very easily.
Let me know what you think. Thanks!

can we have multiple derive_fields? it would be awesome if we can.
file1:
#[derive(GraphQLObjectInfo)]
#[graphql(scalar = DefaultScalarValue)]
struct Obj {
    regular_field: bool,
}

#[juniper::graphql_object(derive_fields)]
impl Obj {
    fn custom_field_resolve() -> bool {
        true
    }
}

file2:
#[juniper::graphql_object(derive_fields)]
impl Obj {
    fn other_field_resolve() -> bool {
        true
    }
}


Question regarding the motivation.

Hi, @ethliup  thanks for your great work. I have a little question regarding the paper's motivation. In this paper, it states that "recover the neural radiance fields (NeRF) from a single blurry image and its corresponding event stream." and "reach same performance as E2NeRF [43], which targets for the same problem, but with multi-view images and longer event data.".
But I don't know what is your efforts on achieving this target while the framework remains largely the same as the previous E2NeRF. Thx a lot.

@ethliup , thanks for your detailed response! I figure it out.

If you have more questions, feel free to contact us!
This issue will be closed within three days.


[DROOLS-1392] fix parsing of boolean cells with poi 3.15 - extra hand…

…ling for boolean cell type

jenkins retest this


In Praos VRF, use useAsCStringLen.

As per security audit:

useAsCString appends a NUL byte; this isn't harmful per se, but completely unnecessary; also, we can perform an additional length check to make sure we can never overrun the input buffer.
genSeed isn't needed, since generating keys via the VRF typeclass pulls entropy from a seed passed in by the caller, but because our Seed bypasses the GHC heap, which can be interesting in some situations, we will keep exposing it, but add documentation here to clarify the situation.
We also expose our PraosVRF-specific Seed type in order to make genSeed practically usable

bors merge

bors retry


startup-command parameter is ignored

We're using this GitHub action to deploy an app to Azure App Services.
The workflows seems to works (and the deployment occurs) but the startup-command is ignored, and GitHub raises an error:

This message contradicts the yaml action definition file.
Here is our yaml action file:
name: REDACTED
on:
  push:
    branches:
      - production
jobs:
  build-and-deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@master
      - name: Set up Node.js version
        uses: actions/setup-node@v1
        with:
          node-version: "10.x"
      - name: npm install, build, and test
        run: |
          npm install
          npm run build --if-present
          npm run test --if-present
      - name: "Deploy to Azure Web App"
        uses: azure/webapps-deploy@v1
        with:
          app-name: "REDACTED"
          startup-command: "npm run api-prd"
          slot-name: "production"
          publish-profile: REDACTED
          package: .

Am I missing something or is it a known issue?

startup-command input is not supported in v1. It is supported in v2.
Please refer the inputs for v1 - https://github.com/Azure/webapps-deploy/blob/v1/action.yml

Thanks @aksm-ms . I just upgraded to v2 and it works.
As a feedback, it's quite easy from this repo to find docs about v2 without realizing it (or maybe it's just me ;-) ).
For instance from this page, you have to notice then switch the tag:

Maybe including the version number as a comment directly in the action.yml would be helpful.
Also, what is the status of v2? Is it considered as production ready? Again, having this info from the README page would be great.

Rectification, I now have this issue:

We're running on Linux container, so I think this issue is related to how we're managing publish-profile...
Is it useful to try with v2.1? Any documentation that would describe the differences?

Same problem with v2.1

+1 on this issue with v2
The line
 if (!!startupCommand) {
        throw new Error("startup-command is not a valid input for Windows web app or with publish-profile auth scheme.");
    }

This will always cause an exception to be thrown if startupcommand is present since this will evaluate to true with a non empty string

As a feedback, it's quite easy from this repo to find docs about v2 without realizing it (or maybe it's just me ;-) ).
For instance from this page, you have to notice then switch the tag:

Maybe including the version number as a comment directly in the action.yml would be helpful.

Can you please explain more here? I am unable to understand the exact problem.

Also, what is the status of v2? Is it considered as production ready? Again, having this info from the README page would be great.

v2 is production ready and released to marketplace.

Rectification, I now have this issue:

We're running on Linux container, so I think this issue is related to how we're managing publish-profile...
Is it useful to try with v2.1? Any documentation that would describe the differences?

Please share the workflow for debugging.

name: REDACTED
on:
  push:
    branches:
      - production
jobs:
  build-and-deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@master
      - name: Set up Node.js version
        uses: actions/setup-node@v1
        with:
          node-version: "10.x"
      - name: npm install, build, and test
        run: |
          npm install
          npm run build --if-present
          npm run test --if-present
      - name: "Deploy to Azure Web App"
        uses: azure/webapps-deploy@v2
        with:
          app-name: "REDACTED"
          startup-command: "npm run api-prd"
          slot-name: "production"
          publish-profile: REDACTED
          package: .

currently startup-command is not supported for windows web apps and if publish profile auth scheme is used.
Please use Azure login before webapps-deploy action to use startup command with linux container.
Refer Sample workflow

The line in validation.js
 if (!!startupCommand) {
        throw new Error("startup-command is not a valid input for Windows web app or with publish-profile auth scheme.");
    }

This will always cause an exception to be thrown if startupcommand is present since this will evaluate to true with a non empty string

This check is used only for validating windows apps and publish profile auth scheme.

currently startup-command is not supported for windows web apps and if publish profile auth scheme is used.
Please use Azure login before webapps-deploy action to use startup command with linux container.
Refer Sample workflow

OK I'm gonna try this

@guillaumemeyer any update?

Quite busy these days, gonna try this next week

Hi, Is this error fixed?
I am getting the same error for my Angular web app which is deploying to Azure App Service on Linux.
Here is my sample actions.yml:
name: REDACTED
on:
  push:
    branches:
      - main
jobs:
  build-and-deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - name: Set up Node.js version
        uses: actions/setup-node@v4
        with:
          node-version: "20.x"
      - name: npm install, build, and test
        run: |
          npm install
          npm run build --if-present
          # npm run test --if-present
      - name: "Deploy to Azure Web App"
        uses: azure/webapps-deploy@v3
        with:
          app-name: "REDACTED"
          slot-name: "production"
          publish-profile: REDACTED
          package: .
          startup-command: "pm2 serve /home/site/wwwroot --no-daemon --spa"

Same problem here, I'm hosting on linux the action seems to think I'm deploying to Windows


Added st2-rbac-backend and st2-auth-ldap pip requirements for LDAP an…

…d RBAC support to st2 core.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.hanancha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Cleaning up. Will submit one to merge in dev


Nested tables

Currently, nested tables cannot be downloaded, only the outer table.

This is proving to be a more common structure than I'd initially guessed. This needs a solution, I'm guessing the html will need to be changed more significantly.

Some test pages for nesting:
This one needs both the outer and inner tables to be work
google premier league table
It might be solved by simply removing the inner table tags when getting the table.
This one uses tables to structure the page, so outer tables need to be ignored.
pathfinder character creation
This might be solved having an "ignore" table button - removing the "onclick" event listener and the css.

The second case, where tables are used to structure the page, has been fixed as suggested in the previous comment: a close x has been added to remove the overlay and the event listener.


Update changelog for empty body fix

https://github.com/kevin1024/vcrpy/pull/423

Triggering Building the docs from my phone is easy.
https://vcrpy.readthedocs.io/en/latest/changelog.html
Will need to plan a release soon so this gets into the wild.


BaseWidget - add test: changing props in container with baseWidget shouldn't throw exception (T1072778)

not actual


Try not to hit the pipes by pressing w and get a high score
file=https://raw.githubusercontent.com/hackclub/sprig/main/games/gravity_fun.js))
How to play your game?
Press W to fly/ flap
Code
Check off the items that are true.

[X] The game was made using the Sprig editor.
[X] The game is placed in the in the /games directory.
[X] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[X] The game runs without errors.
[X] The name of the file/game contains only alphanumeric characters, -s, or _s.
[X] The game name is not the same as the others from gallery

Image (If an image is used)

[X] The image is in the /games/img directory.
[X] The name of the image matches the name of your file. Example: sokoban_plus.js -> sokoban_plus.png.

Thanks for PR!

Great game! are we just going to make the Sprites more creative?


Wrong info in gem description

Hey just to let you know, that there is a misleading information in the gem description.
It says:
" add_foreign_key(from_table, to_table, options)
remove_foreign_key(from_table, options)"

But It should say:
" add_foreign_key(from_table, to_table, options)

remove_foreign_key(from_table, to_table, options)" (with the to_table option)

BTW. thanks for a great gem!

It's actually remove_foreign_key(from_table, to_table_or_options). You cannot pass a third parameter.
Should I add documentation in the README about remove_foreign_key?

Closing due to no feedback. Foreigner uses the same removal syntax as remove_index in Rails, so hopefully it should make sense to everyone.


Build inventory python failed

The build process for inventory python is failing to try to apply a required library.
#10 29.33 Collecting cryptography<=3.4.7,>=3.2.1 (from oci->-r requirements.txt (line 5))
#10 30.48   Downloading https://files.pythonhosted.org/packages/9b/77/461087a514d2e8ece1c975d8216bc03f7048e6090c5166bc34115afdaa53/cryptography-3.4.7.tar.gz (546kB)
#10 31.17     Complete output from command python setup.py egg_info:
#10 31.17
#10 31.17             =============================DEBUG ASSISTANCE==========================
#10 31.17             If you are seeing an error here please try the following to
#10 31.17             successfully install cryptography:
#10 31.17
#10 31.17             Upgrade to the latest pip and try again. This will fix errors for most
#10 31.17             users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip
#10 31.17             =============================DEBUG ASSISTANCE==========================
#10 31.17
#10 31.17     Traceback (most recent call last):
#10 31.17       File "<string>", line 1, in <module>
#10 31.17       File "/tmp/pip-build-3_wb8ir0/cryptography/setup.py", line 14, in <module>
#10 31.17         from setuptools_rust import RustExtension
#10 31.17     ModuleNotFoundError: No module named 'setuptools_rust'
#10 31.17
#10 31.17     ----------------------------------------
#10 31.51 Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-3_wb8ir0/cryptography/
------
executor failed running [/bin/sh -c yum install -y python36 &&      yum install -y tar &&      rm -rf /var/cache/yum &&      python3.6 -m pip install -r requirements.txt]: exit code: 1

build-inventory-python.log

inventory-python Dockerfile updated to include py setuptools. PR submitted.


Feature request: Opt-out of region role

On my server, we can @message regions like @na. Unfortunately Discord doesn't allow people to mute role pings which can be annoying for some people.
Right now there's already an option to 'Opt-Out of Tier Roles' on the web interface. We should also have an option to 'Opt-Out of Region Roles'.

Would you still be interested in this now that role conditions have been reworked?


⚠ Bofrost.lu has degraded performance

In 43a4dd7, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1119 ms

Resolved: Bofrost.lu performance has improved in 736f3c5 after 53 minutes.


Make insert mode word-based keybindings (alt+f, alt+b, etc.) assume small words by default

Not a bug, but a suggestion.
Currently, Alt+f and Alt+b keybindings correspond to edit:move-dot-left-word and edit:move-dot-right-word, which respectively move the cursor left and right by a WORD, which is a contiguous sequence of non-whitespace characters.  Instead, I propose mapping those keys to edit:move-dot-left-small-word and edit:move-dot-right-small-word by default, which move the cursor relative to a word, which is a contiguous sequence of alphanumeric characters, or a contiguous sequence of non-alphanumeric characters, separated by whitespace.
This would be a desirable default because it would essentially match the default behavior of readline bindings in other popular shells (i.e. bash and zsh), and also approximately match word-movement behavior in vim and emacs.
Furthermore, in most situations I have come by, I have found it generally preferable to edit and move by small-word rather than by WORD.  As an example, if I want to manipulate a long file path, or a long URL, it would be more convenient to be able to use Alt-b to hop my cursor to the middle of the path/URL, where current behavior only allows me to move to either the beginning or the very end of the string, from which I would need to navigate by-character (i.e. arrow keys, or equivalent) to the middle of the string.

I'll second this. I have the following in my startup script to get the best of both worlds - fine-grained by default with opt-in to coarse-grained using the shifted variants.
{
  var bind~ = {|k f| set edit:insert:binding[$k] = $f }

  bind Alt-b $edit:move-dot-left-small-word~
  bind Alt-B $edit:move-dot-left-word~
  bind Alt-f $edit:move-dot-right-small-word~
  bind Alt-F $edit:move-dot-right-word~
  bind Alt-d $edit:kill-small-word-right~
  bind Alt-D $edit:kill-word-right~
}


Update smart contarct comments

Updated the comments for the smart contracts for https://github.com/edakturk14/fuel-starter-kit/issues/3

hey @carletex!
Made a few edits. For the testnet deployments the forc-wallet command has changed to I've changed that as we discussed yesterday. Lmk if you have any q or comments on the following edits.


Remove delay before storing updated selection

We started using ProseMirror in a collaborative environment and found quite a major issue with cursor re-positioning when receiving changes from peers.
Here is a little video showing two windows, the latter which programatically types in text at a realistic pace. Pay attention to the uppermost window, where the only thing done is pressing the ➡  key, first a couple times per second during a few seconds, then holding it non-stop for a few more seconds.

You can see the cursor is often moved back to its previous position, and when the ➡  key is held down it feels really buggish. The following explains the cause and solution to this problem.
Upon receiving a peer transform, ProseMirror applies the transform (which re-maps selection) based on the last stored selection. This is OK. The problem is when the selection is actually stored into the state. Key and mouse events call the SelectionReader#fastPoll function instantaneously on each event, which then calls startPolling. However startPolling currently delays storing the selection by 50ms every time it is called.
This can be clearly illustrated by logging selection-type actions received by onAction:
 var view = window.view = new EditorView(document.querySelector(".full"), {
   state: state,
   onAction: function(action) {
+    if (action.type == "selection") {
+      console.log("selection change")
+    }
     view.updateState(view.state.applyAction(action))
   },
 })

When I hold the ➡  key, every call to startPolling clears the previous timeout and starts a new one with a 50ms delay, thus never storing the selection until I release the key for at least 50ms.
I changed the 50ms delay to 0ms, which ensures an updated selection is stored after every keystroke. This eliminates any cursor re-mapping issue during collaborative editing (if you see some lag, it’s a .gif lag):

This is the code I used to have a window that programatically types text:
Start typing
-
Stop typing

let typingTimeout
  , lastTypedCharacterIndex = 0
  , dummyText = 'Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean massa. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Donec quam felis, ultricies nec, pellentesque eu, pretium quis, sem. '

document.querySelector('.start-typing').onclick = () => {
  let type = () => {
    view.updateState(
      view.state.applyAction(
        view.state.tr.insertText(dummyText[lastTypedCharacterIndex]).action()
      )
    )
    lastTypedCharacterIndex += 1
    if (lastTypedCharacterIndex > dummyText.length - 1) {
      lastTypedCharacterIndex = 0
    }
    typingTimeout = setTimeout(type, 100)
  }
  type()
}

document.querySelector('.stop-typing').onclick = () => {
  clearTimeout(typingTimeout)
}

This is probably a good idea. I've merged it, if there's any fallout, we'll see later. Ideally we'd want to not cancel the timeout at all, to avoid having it pushed back by subsequent events, but arranging for that while preserving the distinction between fast and slow polling would be somewhat more cumbersome, and if this simple change does the trick I prefer it.


Revert "Add temporary Money to Prisoners survey to request send page"

This reverts commit cd1f067acc51499bd45d33141d0897f6826f6218.
It removes the MTP survey from Prison Visits.

Looks fine to me.


Setting for workspace directory in the UI

What problem or use case are you trying to solve?
We removed the ability to choose your directory from the UI due to bugs
Describe the UX of the solution you'd like
In the settings modal, a dropdown of all directories inside the WORKSPACE_BASE folder. Also an option to add a new directory.
Do you have thoughts on the technical implementation?

A REST API that returns a list of all directories available in the WORKSPACE_BASE folder

probably shouldn't be recursive, or shouldn't recurse past anything that has a .git subdirectory, otherwise it will be too crowded

We will need to pass up the directory through initialize, and plumb it into a few places:

the sandbox
the file operations in ./opendevin/actions/...
probably somewhere else I'm forgetting

i think this and #1146  can be processed together. the setting modal deserves to be improved.

Github bot doesn't see a PR was added just 5 days ago. For the bot: there we go, this is a comment. 😅

If anyone happens to pick this up, the requirements are:

The Settings page allows you to choose the workspace
The folders being shown are the WORKSPACE_BASE set initially by the user and the folders available in the WORKSPACE_BASE folder. This list is static and does not change.


Fix for Dedicated Networking

Allow IP Allow List to work with Dedicated Networking
Creating 2 more hostname if Dedicated Networking is enabled (1 if DN enabled, 1 if Standby is enabled) to not disrupt the original one

I think we have some flaky tests in the tembo-operator functional tests. I have seen this one failing in my branches as well: test::functional_test_restart_and_update_replicas


Worker WIP

POC of moving queries off to threads, solves https://github.com/looker-open-source/malloy/issues/670. Still lots of cleanup:

[ ] Restart worker on crash
[ ] Downloads
[ ] Proper Logging
[ ] Debugger support
[ ] Refactor some now duplicated code
[ ] Multiple simultaneous queries.

This is going to be amazing.  Seems to run queries so much faster.


EAGLE-39 Policy State Management

executor state management mainly for policy state durability for failover

basic implementation of state snapshot, delta event persistence, snapshot recover, delta event recovery
by default it is disabled
need improve: batch insert delta events to kafka, and batch ack storm
need performance test further.

It has conflict with master branch now, should we merge this part of code into master firstly?

This ticket need more discussion before we merge

Ok, thanks.


Secure the In-Transit encryption for gRPC between Dapr instances

How do you plan to distribute certificates for this purpose?

Dupe of #1293


is it possible to link python 3.7.1(anaconda) to  opencv-3.4.5-vc14_vc15

i have installed anaconda python of 3.7.1 on my system.
can i install  opencv-3.4.5-vc14_vc15 in my system?
if it is possible, then tell me the way i should  install open cv opencv-3.4.5-vc14_vc15.
so that an error should not come.like import cv2 error.

I don't understand what you mean, opencv-3.4.5-vc14_vc15 has nothing to do with this repository. Please follow the instructions in the README or ask your question at http://answers.opencv.org/questions/.


svg thumbor issue

Issue from @ManonGros
one of our publisher wondering why their logo is so dark on their publisher page
this is the publisher page: https://www.gbif.org/publisher/867a53f4-2f2d-4932-be6a-f46566255371
this is their logo: http://botaanikaaed.ee/wp-content/themes/botaanikaaed/assets/dist/gfx/botaanikaaed_logo.svg
It's a vector logo (which is good), but the portal feeds it through Thumbor. Thumbor probably isn't great with vector graphics.
we can detect images with an svg ending and not feed them through thumbor

@MattBlissett let me know if the issue cannot be fixed in thumbor. Caching is useful if possible.

Their logo URL has changed, but at least https://botaanikaaed.ee/wp-content/uploads/2022/02/Botaanika-Aed-Logo.svg when put through the newer Thumbor is more acceptable. I think the SVG library is still affecting the background, maybe it doesn't deal well with transparency.


webdav (bearer-)token time out / possible to send custom token

Bug Report
webdav (bearer-)token time out
Running dvc push ( with a webdav server as remote) results in a timeout error, when authorizing via (bearer-)token.
Here the traceback:
Traceback (most recent call last):
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_exceptions.py", line 8, in map_exceptions
    yield
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/backends/sync.py", line 26, in read
    return self._sock.recv(max_bytes)
  File "/home/storkc/programms/miniconda3/lib/python3.9/ssl.py", line 1227, in recv
    return self.read(buflen)
  File "/home/storkc/programms/miniconda3/lib/python3.9/ssl.py", line 1102, in read
    return self._sslobj.read(len)
socket.timeout: The read operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_transports/default.py", line 60, in map_httpcore_exceptions
    yield
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_transports/default.py", line 218, in handle_request
    resp = self._pool.handle_request(req)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_sync/connection_pool.py", line 253, in handle_request
    raise exc
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_sync/connection_pool.py", line 237, in handle_request
    response = connection.handle_request(request)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_sync/connection.py", line 90, in handle_request
    return self._connection.handle_request(request)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_sync/http11.py", line 105, in handle_request
    raise exc
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_sync/http11.py", line 84, in handle_request
    ) = self._receive_response_headers(**kwargs)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_sync/http11.py", line 148, in _receive_response_headers
    event = self._receive_event(timeout=timeout)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_sync/http11.py", line 177, in _receive_event
    data = self._network_stream.read(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/backends/sync.py", line 26, in read
    return self._sock.recv(max_bytes)
  File "/home/storkc/programms/miniconda3/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpcore/_exceptions.py", line 12, in map_exceptions
    raise to_exc(exc)
httpcore.ReadTimeout: The read operation timed out

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/generic.py", line 310, in transfer
    _try_links(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/generic.py", line 249, in _try_links
    return copy(from_fs, from_path, to_fs, to_path, callback=callback)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/generic.py", line 86, in copy
    return _put(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/generic.py", line 146, in _put
    return _put_one(from_paths[0], to_paths[0])
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/generic.py", line 138, in _put_one
    return put_file(from_path, to_path, callback=callback)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/callbacks.py", line 69, in func
    return wrapped(path1, path2, **kw)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/callbacks.py", line 41, in wrapped
    res = fn(*args, **kwargs)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/dvc_objects/fs/base.py", line 534, in put_file
    self.fs.put_file(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/webdav4/fsspec.py", line 374, in put_file
    return self.upload_fileobj(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/webdav4/fsspec.py", line 348, in upload_fileobj
    return self.client.upload_fileobj(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/webdav4/client.py", line 691, in upload_fileobj
    http_resp = self.request(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/webdav4/client.py", line 383, in request
    http_resp = self._request(method, path, **kwargs)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/webdav4/client.py", line 362, in _request
    http_resp = self.http.request(method, url, **kwargs)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_client.py", line 815, in request
    return self.send(request, auth=auth, follow_redirects=follow_redirects)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_client.py", line 902, in send
    response = self._send_handling_auth(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_client.py", line 930, in _send_handling_auth
    response = self._send_handling_redirects(
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_client.py", line 967, in _send_handling_redirects
    response = self._send_single_request(request)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_client.py", line 1003, in _send_single_request
    response = transport.handle_request(request)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_transports/default.py", line 218, in handle_request
    resp = self._pool.handle_request(req)
  File "/home/storkc/programms/miniconda3/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/home/storkc/programms/miniconda3/lib/python3.9/site-packages/httpx/_transports/default.py", line 77, in map_httpcore_exceptions
    raise mapped_exc(message) from exc
httpx.ReadTimeout: The read operation timed out

On Server side, we see that requests are coming in, but a PUT statement times out. We are running dvc version 2.43.1. Running the same setup without Auth or with Basic Auth does work.
Note that we are requiring the token for https authentication (via an nginx secured location). The basic auth was directly securing the webdav server.
Further it would be very interesting for us to send also custom headers within a webdav request to our server (we saw that this should be quiet easy to implement here) and we were wondering if there is a reason why this is not possible?
Reproduce
We have the following setup: Ningx as reverse proxy (which also does authentication) which does a proxy pass to a webdav server (running in an Apache docker container). The Setup is working completely fine when webdav does a simple BasicAuth. Now we have a use case where we want to advance our Auth because more users are using the setup. We want to handle this with custom authorization headers (e.g. bearer authentication) sending with the dvc push requests. This is possible for http already but not for webdav. Other than that we just define our remote and push.
Expected
It would be nice to have the possibility to send custom headers with webdav requests. Further a timeout using the (bearer-)token should not happen.
Environment information
DVC version: 2.43.1 (pip)
---------------------------------
Platform: Python 3.9.13 on Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31
Subprojects:
        dvc_data = 0.35.1
        dvc_objects = 0.19.0
        dvc_render = 0.0.17
        dvc_task = 0.1.11
        dvclive = 1.3.3
        scmrepo = 0.1.6
Supports:
        http (aiohttp = 3.8.1, aiohttp-retry = 2.7.0),
        https (aiohttp = 3.8.1, aiohttp-retry = 2.7.0),
        webdav (webdav4 = 0.9.7),
        webdavs (webdav4 = 0.9.7)
Cache types: hardlink, symlink
Cache directory: ext4 on /dev/sdb
Caches: local
Remotes: webdavs
Workspace directory: ext4 on /dev/sdb
Repo: dvc, git

Hi @conrad-stork, are you able to do PUT with curl with the header set?

Hi @skshetry, thanks for the quick reply, I had some issues to test it, but now I made it and I can also not doe the PUT method via curl. So it might be a server configuration problem? Any ideas what could go wrong especially for the PUT method? GET method is working...

Hi @skshetry again, we now managed to make it work! We had some trouble on the server side. Sorry for bothering you! However could you also comment to the feature request, or should we open a new issue for that? Thanks in advance and Best!

@conrad-stork, the feature request makes sense. If you can create a PR to dvc-webdav adding support (and, extending config schema in dvc), I'd be happy to review.

@skshetry I created pull requests for dvc-webdav, dvc and dvc.org. Hope this will be integrated. Thanks a lot for your support!

Closed by #20.


add descriptive error message on activate

This PR adds a more detailed error message if activation fails.
From https://www.tcpdump.org/manpages/pcap_activate.3pcap.txt:
PCAP_ERROR
       Another error occurred.  pcap_geterr() or pcap_perror()  may  be
       called  with  p  as  an  argument  to fetch or display a message
       describing the error.

This happened when using bettercap with the https://github.com/aircrack-ng/rtl8812au driver (see here https://github.com/bettercap/bettercap/issues/614).
Without the patch:
[err] error while activating handle: unknown activated error: -1

After the patch:
[err] error while activating handle: Error: wlan0: SIOCGIWPRIV: Argument list too long

Thanks for the contribution


Allow running atlantis with github app instead of a user token

Is your request related to a problem? Please describe.

Since we want to use atlantis in a GitHub organization, I want to have this environment variables and secrets in my atlantis container without any github user tokens.:
  custom_environment_variables = [
    {
      name  = "ATLANTIS_GH_APP_ID"
      value = local.github_app_id
    },
    {
      "name" : "ATLANTIS_WRITE_GIT_CREDS",
      "value" : "true",
    }
  ]

  custom_environment_secrets = [
    {
      name      = "ATLANTIS_GH_APP_KEY"
      valueFrom = local.atlantis_github_app_key_ssm_parameter_name
    }
  ]

The module currently depends on the presence of var.atlantis_github_user_token, which is used as a conditional in the creation of some resources and that brings a problem:

Without the atlantis_github_user_token, although there may be other secrets in the environment(webhook_secret. github app key secret etc.), the tasks can not get their value.
https://github.com/terraform-aws-modules/terraform-aws-atlantis/blob/fab764c06444a0e72deb6c3cf92bdb4fbc31ba4b/main.tf#L567

I worked around this issue by modifying the module by adding some custom variables.
Describe the solution you'd like.

I would like to create the atlantis module with a simple parameter like use_github_bot = true which will take care of setting up all the necessary environment variables/parameter store secrets for me.

Hey, I know this is a recent issue, however I want to add myself to the list of interested parties ! 😋

This issue has been resolved in version 3.23.0 :tada:


Errors importing from Stride (not Hipchat) using the Stride export tool

Trying out Zulip for the first time and the experience has been really nice and smooth so far.
One issue when giving the Stride import a try (obviously not exactly hipchat but should be similar)
Decrypted with the following command (this varies slightly from the official way to decrypt the hipchat export):
openssl enc -md md5 -aes-256-cbc -salt -d -in stride-abcdefg.tar.gz.aes  -out stride.tar.gz -k secret
Then imported:
./manage.py convert_hipchat_data ~/stride.tar.gz --output converted_hipchat_data
Traceback follows:
Converting Data ...
2018-11-09 20:37:20.805 INFO [] input data was untarred to /home/zulip/stride
Traceback (most recent call last):
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/fields/related_descriptors.py", line 880, in get_queryset
    return self.instance._prefetched_objects_cache[self.prefetch_cache_name]
AttributeError: 'UserProfile' object has no attribute '_prefetched_objects_cache'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./manage.py", line 46, in <module>
    execute_from_command_line(sys.argv)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
    utility.execute()
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 356, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zerver/management/commands/convert_hipchat_data.py", line 77, in handle
    masking_content=options.get('masking_content', False),
  File "/home/zulip/deployments/2018-11-09-14-14-01/zerver/data_import/hipchat.py", line 696, in do_convert_data
    realm_id=realm_id,
  File "/home/zulip/deployments/2018-11-09-14-14-01/zerver/data_import/hipchat.py", line 151, in convert_user_data
    user = process(raw_item)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zerver/data_import/hipchat.py", line 147, in process
    timezone=timezone,
  File "/home/zulip/deployments/2018-11-09-14-14-01/zerver/data_import/import_util.py", line 60, in build_user_profile
    dct = model_to_dict(obj)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/forms/models.py", line 97, in model_to_dict
    data[f.name] = f.value_from_object(instance)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/fields/related.py", line 1683, in value_from_object
    return getattr(obj, self.attname).all()
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/manager.py", line 160, in all
    return self.get_queryset()
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/fields/related_descriptors.py", line 883, in get_queryset
    return self._apply_rel_filters(queryset)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/fields/related_descriptors.py", line 870, in _apply_rel_filters
    return queryset._next_is_sticky().filter(**self.core_filters)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/query.py", line 787, in filter
    return self._filter_or_exclude(False, *args, **kwargs)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/query.py", line 805, in _filter_or_exclude
    clone.query.add_q(Q(*args, **kwargs))
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/sql/query.py", line 1250, in add_q
    clause, _ = self._add_q(q_object, self.used_aliases)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/sql/query.py", line 1276, in _add_q
    allow_joins=allow_joins, split_subq=split_subq,
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/sql/query.py", line 1210, in build_filter
    condition = self.build_lookup(lookups, col, value)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/sql/query.py", line 1104, in build_lookup
    return final_lookup(lhs, rhs)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/lookups.py", line 24, in __init__
    self.rhs = self.get_prep_lookup()
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/lookups.py", line 74, in get_prep_lookup
    return self.lhs.output_field.get_prep_value(self.rhs)
  File "/home/zulip/deployments/2018-11-09-14-14-01/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/fields/__init__.py", line 966, in get_prep_value
    return int(value)
ValueError: invalid literal for int() with base 10: '557058:975d0e3c-f10d-42e9-9578-abcdef1234'

As I understand it, Stride was a complete rewrite from HipChat (just from the same company) and its data exports are likely in a completely different format.
If you can share a Stride export file with<EMAIL_ADDRESS>we can do a quick look at how different the format is and thus whether it's easy to add support for it.  As I understand it, Stride never had a large userbase, so if it's a totally different format, it may not be worth it for the Zulip core team to implement a migration tool (though we'd likely review work from someone contributing such a feature in any case).

@timabbott thanks Tim! Sent! Hopefully it looks simple but definitely understand how priorities need to be set. Thanks for having a look!!

Awesome, thanks @jamiesonbecker!

Update: It appears they use a similar export format, just with UUID-format user IDs, see https://github.com/zulip/zulip/pull/10826 which may cover everything needed to support this.

Much further! This is using https://github.com/zulip/zulip/pull/10826
zulip@chat:~/deployments/current$ ./manage.py convert_stride_data ~/stride.tar --output converted_stride_data
Unknown command: 'convert_stride_data'
Type 'manage.py help' for usage.
zulip@chat:~/deployments/current$ ./manage.py convert_hipchat_data ~/stride.tar --output converted_hipchat_data
Converting Data ...
2018-11-15 00:48:52.352 INFO [] input data was already untarred to /home/zulip/stride, we will use it
2018-11-15 00:48:52.419 INFO [] Starting to process emoticons
2018-11-15 00:48:52.420 INFO [] Done processing emoticons
2018-11-15 00:48:52.420 INFO [] Start importing message data
skipping attachment with missing path: image.png
skipping attachment with missing path: IMG_20180918_191239.jpg
skipping attachment with missing path: IMG_20180918_134434.jpg
skipping attachment with missing path: IMG_20180918_133932.jpg
skipping attachment with missing path: image.png
skipping attachment with missing path: image.png
skipping attachment with missing path: usergroup.gif
skipping attachment with missing path: happy-taco.gif
2018-11-15 00:48:53.235 INFO [] Start importing avatar data
2018-11-15 00:48:53.235 INFO [] Start processing attachment files
2018-11-15 00:48:53.236 INFO [] Done processing attachment files
2018-11-15 00:48:53.236 INFO [] Start making tarball
2018-11-15 00:48:53.322 INFO [] Done making tarball
zulip@chat:~/deployments/current$ ./manage.py import '' converted_hipchat_data
Traceback (most recent call last):
  File "./manage.py", line 46, in <module>
    execute_from_command_line(sys.argv)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
    utility.execute()
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 356, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/management/commands/import.py", line 56, in handle
    check_subdomain_available(subdomain, from_management_command=True)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/forms.py", line 71, in check_subdomain_available
    raise ValidationError(error_strings['unavailable'])
django.core.exceptions.ValidationError: ['Subdomain unavailable. Please choose a different one.']

The error message doesn't specify the exact subdomain that's unavailable -- perhaps stride.com? or our userify.com subdomain?

@jamiesonbecker that error means that you've already created a Zulip organization on that server at the root domain.  Probably, if this is a new server, the fix is to delete the organization you created.  I just extended https://zulip.readthedocs.io/en/latest/production/export-and-import.html#import-into-a-new-zulip-server with f1c65975ad44c7d666270b1eea7ec8a5316f7dcc to help clarify this aspect of the process (that you should skip creating an organization).

BTW for these warnings:
skipping attachment with missing path: IMG_20180918_191239.jpg
skipping attachment with missing path: IMG_20180918_134434.jpg
skipping attachment with missing path: IMG_20180918_133932.jpg
skipping attachment with missing path: image.png
skipping attachment with missing path: image.png
skipping attachment with missing path: usergroup.gif
skipping attachment with missing path: happy-taco.gif

Does the export you got from Stride contain copies of those files?

@timabbott Not that I can see.
For example, the hello-taco.gif is probably the photo of the taco puppy from Atlassian Trello; it's name in the media directory is binary?client=f917b86a-24c0-43c2-910b-39ca19359d8d&token=eyJhbGciOiJI[......]
I wonder if it doesn't bother exporting images that are part of Stride or other Atlassian products.

@timabbott Sorry, just getting started on this. This org is empty anyway - how do I delete it? I deactivated it, but cannot find anything in manage.py related to deleting; would it be easier to wipe and reinstall?

scripts/setup/postgres-init-db && scripts/setup/initialize-database will do it.  We should probably add explicit docs for that as well.

@timabbott Thank you!! That almost worked perfectly (see other issue, didn't want to bog down this one). That's a handy snippet.

zulip@chat:~/deployments/current$ ./manage.py import '' converted_hipchat_data
Traceback (most recent call last):
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/lib/db.py", line 33, in execute
    return wrapper_execute(self, super().execute, query, vars)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/lib/db.py", line 20, in wrapper_execute
    return action(sql, params)
psycopg2.ProgrammingError: relation "zerver_realm" does not exist
LINE 1: ...rsion", "zerver_realm"."has_seat_based_plan" FROM "zerver_re...
                                                             ^

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "./manage.py", line 46, in <module>
    execute_from_command_line(sys.argv)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 364, in execute_from_command_line
    utility.execute()
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/__init__.py", line 356, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/management/commands/import.py", line 56, in handle
    check_subdomain_available(subdomain, from_management_command=True)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/forms.py", line 69, in check_subdomain_available
    if is_root_domain_available():
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/lib/subdomains.py", line 52, in is_root_domain_available
    return get_realm(Realm.SUBDOMAIN_FOR_ROOT_DOMAIN) is None
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/models.py", line 411, in get_realm
    return Realm.objects.filter(string_id=string_id).first()
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/query.py", line 567, in first
    objects = list((self if self.ordered else self.order_by('pk'))[:1])
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/query.py", line 250, in __iter__
    self._fetch_all()
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/query.py", line 1121, in _fetch_all
    self._result_cache = list(self._iterable_class(self))
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/query.py", line 53, in __iter__
    results = compiler.execute_sql(chunked_fetch=self.chunked_fetch)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/sql/compiler.py", line 899, in execute_sql
    raise original_exception
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/models/sql/compiler.py", line 889, in execute_sql
    cursor.execute(sql, params)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/utils/six.py", line 685, in reraise
    raise value.with_traceback(tb)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zulip-py3-venv/lib/python3.6/site-packages/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/lib/db.py", line 33, in execute
    return wrapper_execute(self, super().execute, query, vars)
  File "/home/zulip/deployments/2018-11-14-18-37-32/zerver/lib/db.py", line 20, in wrapper_execute
    return action(sql, params)
django.db.utils.ProgrammingError: relation "zerver_realm" does not exist
LINE 1: ...rsion", "zerver_realm"."has_seat_based_plan" FROM "zerver_re...

I think you lost the scripts/setup/initialize-database part in my above instructions :).  Run that and then try again.

Success!!  It looks like the only thing that might not have been imported was the private one-to-one chats. Huge thank you @timabbott, awesome save from an orphaned product!!!

@jamiesonbecker great!  Are the one-on-one chats included in the Stride export?  We definitely import them for HipChat, so we should look at whether the format is different.
(@showell FYI)

Yes, it does look like they're there. Here's a sample, in a filename with the format users/[uuid]/history.json:
[
  {
    "PrivateUserMessage": {
      "attachment": {},
      "id": "abf67c24-89e8-11e8-9896-02420aff0003",
      "mentions": [],
      "message": "Okay No problem. Have a good day. Bye",
      "message_attachment": null,
      "receiver": {
        "id": "557058:2d6c88ea-a7ef-4438-ad97-cc7f2e8dad2f"
      },
      "sender": {
        "id": "5b2937d447afa959b147a4a6"
      },
      "timestamp": "2018-07-17T17:41:44.527568Z",
      "type": "private"
    }
  },
]

Yes, here's a sample from filename with the format users/557058:[uuid]/history.json
[
  {
    "PrivateUserMessage": {
      "attachment": {},
      "id": "3b0b1432-71b9-11e8-8b98-02420aff0003",
      "mentions": [],
      "message": "hi",
      "message_attachment": null,
      "receiver": {
        "id": "557058:[rcvuuid]"
      },
      "sender": {
        "id": "557058:[snduuid]"
      },
      "timestamp": "2018-06-16T23:01:40.827038Z",
      "type": "private"
    }
  }
]

OK, I bet Steve can figure out what's going on here and fix it.

Awesome! Should I open a new ticket for the private chat imports or just leave it here, or should we leave it closed WONTFIX? :)

Go ahead and open a new issue.


Ember Data decorators do not appear to work with ES6 classes

import DS from 'ember-data';
import { attr } from 'ember-computed-decorators/ember-data';

export default class extends DS.Model {
  @attr title;
};

Using Babel 6 with this EmberApp config:
    babel: {
      plugins: [
        'transform-decorators-legacy',
        "transform-class-properties"
      ]
    }

I think this is blocked by some pending changes in Ember Data
cc @runspired

decorators currently don't work at all with ember-cli-babel 6.
see:
https://github.com/rwjblue/ember-computed-decorators/issues/96
https://github.com/rwjblue/ember-computed-decorators/issues/93
https://github.com/rwjblue/ember-computed-decorators/issues/94
https://github.com/loganfsmyth/babel-plugin-transform-decorators-legacy/issues/65
and kinda: https://github.com/babel/ember-cli-babel/issues/69
People seem to be content with adding : null to all their decorators. :-1:
I've tried babel-plugin-transform-decorators -- also doesn't work.
I have yet to find a way to get decorators working without adding 130 : null's

The null fix is for the standard Ember object model, when you are using extend. When used in ES6 classes null isn't needed, and it works generally, but not for DS.Model yet.

does this only work with components?
I tried:
export default class CurrentUserService extends Ember.Service { ...
``
and I get a Broccoli error

Not sure why you got a syntax error, but it does work generally speaking...

@rwjblue do you have an opensource project that I can take a gander at dependencies and configs and see if I can find what I'm missing?

found out I needed babel-plugin-transform-class-properties. everything is working okish, and everything is more modern now :-)

I don't have to use : null to use decorators.. likely a config issue here

With babel 6 and the transform-decorators-legacy plugin, properties must have a value when using decorators on an object:
export default Ember.Object.extend({
  @alias('foo') bar, // invalid
  @alias('foo') baz: null, // valid

  @computed
  foo() {
    // valid, because the function is the value
  }
});

This isn't an issue with ES6 classes and class properties, and hopefully won't be when the actual transform-decorators plugin is finished

hm. I'm running in to a thing, where my ES6 decorated properties don't show up at all.

and then in chrome inspector:

Which version of Ember and computed decorators are you using? This should be fixed on master if it is what I think it is

from package.json:
ember-computed-decorators: 0.3.0,
ember-source: 2.13.0

Hmm, interesting. There was a bug where the actual constructor of the class would never actually run due to the double extend uses for injection of previous versions of Ember, but that shouldn't be an issue on 2.13.
Can you try it against master and if it's still an problem open up another issue for it?

setting my version of ember-computed-decorators to rwjblue/ember-computed-decorators fixed it! woo!
thanks, @pzuraq !

I've upgraded to ember-decorators, and am trying using an es6 class:
import Ember from 'ember';
import DS from 'ember-data';

import { computed, readOnly } from 'ember-decorators/object';
import { hasMany, attr } from 'ember-decorators/data';

import { userIsMemberOf } from 'aeonvera/helpers/user/is-member-of';
import { userLatestRenewalFor } from 'aeonvera/helpers/user/latest-renewal-for';

export default class extends DS.Model {
  @hasMany('membership-renewal') membershipRenewals
}

I get the error (with and without the specified model name in hasMany):
TypeError: Cannot read property 'modelName' of undefined
    at Function._findInverseFor (model.js:662)
    at Function.inverseFor (model.js:629)
    at createRelationshipFor (create.js:45)
    at Relationships.get (create.js:88)
    at store.js:299
    at model.js:882
    at cb (ember.debug.js:21393)
    at OrderedSet.forEach (ember.debug.js:21194)
    at Map.forEach (ember.debug.js:21397)
    at Function.eachRelationship (model.js:881)

Using the non es6 class / extend method works.

Yeah, this issue is dependent on work in Ember Data. Hopefully it'll come through in the next few releases.

I think we might be able to work around the issue, but a failing test PR would be super helpful.

@rwjblue I 'think' I made a failing test -- messed up my local env, though. Looks like this repo could use some continuous testing.

v2.0.0-beta.1 has been released and should fix these issues! Let me know if you have any problems, I'll close this issue once we get to v2.0.0 stable


[Profiles] Editing profiles

It says under functionality; Multiple profiles. Does this mean multiple profiles by Netflix or by Kodi? Yes, I do see multiple profiles in Netflix but I can't edit them individually, like for instance, language or subtitles. I found a way around this by using the Kodi profiles (adding an new one and using it) and edit the prefered language in settings. Unfortunately loading Netflix in the new profile stopped working in the latest version of Kodi Leia (experimental amlogic s905x), therefore I was looking if it was possible in the addon itself.

@gregoir3
You can edit the individual settings for the profiles in the Netflix Settings section of the website, they should have an effect in the plugin as well.
Unfortunately loading Netflix in the new profile stopped working in the latest version of Kodi Leia (experimental amlogic s905x), therefore I was looking if it was possible in the addon itself.

Can you send a debug.log? I´d like to investigate this, but I´m not able to reproduce the problem.
Btw.: There is an issue about editing Netflix profiles from within Kodi, but that is far future stuff: https://github.com/asciidisco/plugin.video.netflix/issues/51

With the latest alpha version this kodi profile swapping install problem was solved.

@gregoir3 Glad to hear that :)


magic-pod 0.99.24

Updated dependencies to resolve a known vulnerability.
What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Hello, this pull request was submitted 2 weeks ago and got no comments.
If there is anything I should do, could you please let me know?
I think https://github.com/bitrise-io/bitrise-steplib/pull/3765#issuecomment-1449253198 is just an automatic alert and this change has no problem in the viewpoint of semantic versioning.

Thank you so much!


https://ocr-d.de/en/workflows

Denoising example before/after does not look different (ok, not much noise before...)
Deskewing example before/after almost identical, but still skewed after
Link to tesseract model data https://ub-backup.bib.uni-mannheim.de/~stweil/ocrd-train/data/GT4HistOCR_50 "NOT FOUND"

thx for your remarks, they should be solved now


Update to client interactions to support wallet api with bitcoind

Several updates here:

@caravan/clients

Adds new bitcoind client for making requests to named wallets (which have a different url they make calls to)
Adds new methods to blockchain client for importing descriptors (private client type only)

Caravan Coordinator:

Typescript-ify some files
New optional field in private client config for a wallet name
Can import descriptors to bitcoind for syncing addresses
Other misc cleanup to how the blockchain client is accessed and passed around the app

TODO:

[x] Review code for any additional cleanup
[x] Add tests for client update

Fixes #75

Looks good, nice work!


WIP: re-enable windows tests

This PR is used to experiment with why the tests are failing on Windows.

This is blocked on issue #795


<IP_ADDRESS> fails to build on arm with gcc6 (i.e. C++14)

<IP_ADDRESS> fails to build on armv7hl with gcc 6 development version on Fedora 24 as https://kojipkgs.fedoraproject.org//work/tasks/6081/12886081/build.log
In file included from unf/normalizer.hh:10:0,
                 from unf.cc:1:
unf/table.hh:13539:25: error: narrowing conversion of '-27' from 'int' to 'char' inside { } [-Wnarrowing]
  -77, -39,-124, -39,-123};
                         ^
unf/table.hh:13539:25: error: narrowing conversion of '-113' from 'int' to 'char' inside { } [-Wnarrowing]
unf/table.hh:13539:25: error: narrowing conversion of '-81' from 'int' to 'char' inside { } [-Wnarrowing]
unf/table.hh:13539:25: error: narrowing conversion of '-27' from 'int' to 'char' inside { } [-Wnarrowing]
(and many others)

Note that gcc6 faults to -std=gnu++14, and "char" on arm is "unsigned" by default. So converting -113 (for example) to char on arm is narrowing conversion and C++11 prohibits this on initializer.

Same here with Arch Linux ARM (armv7hl, too). gcc got updated to 6.1.1 and this error-messages occurred.

https://build.opensuse.org/package/live_build_log/OBS:Server:Unstable/rubygem-unf_ext/openSUSE_Factory_ARM/aarch64
https://build.opensuse.org/package/live_build_log/OBS:Server:Unstable/rubygem-unf_ext/openSUSE_Factory_PPC/ppc64le
https://build.opensuse.org/package/live_build_log/OBS:Server:Unstable/rubygem-unf_ext/openSUSE_Factory_zSystems/s390x

Seems like there are multiple fixes for this issue, but the bug is still there. Any news?

Bump. Same here on Raspberry Pi running Arch ARM.

Nevermind. Turns out the fix is just not in the official release on rubygems yet, so the version you install through gem install doesn't have the fix. You have to build it from git.

Same problem on ARMv8, I'll try the install from git.

What will it take to get this change pushed into the official rubygems?
This comes up in the context of https://github.com/tootsuite/mastodon/issues/802 (port of Mastodon to ARM).

I'll look into this later today.

For now Fedora (me) has applied the following patch:
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-unf_ext.git/tree/unf_ext-<IP_ADDRESS>-char-signness.patch

Thanks @knu @mtasaka . My target for this is a Packet 2A ARMv8 server running Docker, Alpine 3.5,  and Ruby for Mastodon.

This also affects building gitlab ce on armhf.

@ss89 - is there an upstream issue for the gitlab build problem?
There was a report from the Mastodon project that this can be worked around by pulling the gem from git as a temporary measure pending a new release. I don't have the precise invocation necessary but it should be a simple and compatible one-liner.

@vielmetti i couldn't find any issue about it in their gitlab instance which they use for hosting the gitlab ce repo.

I have a strange problem that might or might not be related to this one.
If you see this gist:
https://gist.github.com/ss89/14d1e90663dbac285b84cabaf60efeab
you will see that unf_ext was successfully built, but later when build crack it fails with the same error seen in the issue creators first post.
Should i create a new Issue for this?

@knu (/cc @vielmetti)
I was trying today to build that on arm64, but I got somehow the same build problems that used to be there before fee5abd7cb28237ccabc12bd5d273bfa9be11979 was merged because d0947baba183c83ad9194c7041034c91eaa35944 reintroduced the old typing, which is as far as I can see also in v<IP_ADDRESS>.
Or did I get something wrong?

It looks like the const signed char STRINGS[] in table.hh reverted to const char STRINGS[].

I think #30 should be all that's necessary to fix it. @marcust are you able to test it via git?


Fix lang select being too long

Added tab support on the dropdown component and limited it to 50vh of max-height, fixed scrollbar color and added css scrollbar properties (only work with Firefox).
Also added some decorations and an alignment option on it

You want me to fix a browser problem :sob:, I will see what I can do

Browsers suck, let's go back to TVs and phones