Expand personal message textarea to match content in the invite members flow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create workspace
Go to workspace menu, select Manage members
Select Invite
Enter custom text in the Add a personal message (optional) text box to the point that text runs off the screen.

Expected Result:
The textarea should expand so that all of the content is visible up to a certain point, similar to the chat input.
Actual Result:
The textarea does not expand, and text runs is not visible in the screen
Platform:

Web
iOS
Android
Desktop App
Mobile Web

Notes/Photos/Videos:

View all open jobs on GitHub

@Expensify/design @shawnborton @trjExpensify curious what you think here. This feels a bit off to me, though I see the case for showing the optional message persistently. On OldDot we show this outside of the field to begin with, but that isn't consistent with the Newdot design...

@kevinksullivan That is the label of the field. The placeholder gets hidden when you type anything into it.

I think the floating label should stay there to be consistent with other inputs. That being said, perhaps the textarea itself can grow to match the size of the content like the compose box does on chats, up to a certain max-height.

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Info looks all there, will probably assign as External in a moment but want to take a moment to look at the issue myself

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

making external so a contributor can pick this up

@shawnborton please how long do you want the textarea to be?

?

This issue has not been updated in over 15 days.  eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!


 We shouldn't allow that. (This might be even against the constitution :-)

What if you want the RAM and no longer care for that particular monster?

The contract says that you agreed to care for the monster until it dies.
John Williamson<EMAIL_ADDRESS>schrieb am Fr., 22. Juni 2018,
10:45:

What if you want the RAM and no longer care for that particular monster?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/leordev/monstereos/issues/29#issuecomment-399369460,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYcWdG0j_VO4TuhiXrnWJfjdG5_h7ohks5t_K6ZgaJpZM4UzVGl
.

I think it's critical in case the person does not want to be playing the game right away and needs the RAM for other dapp... We should change the Ricardian Contract and allow it (even in the ui)

For the story of the game it makes more sense to never kill a living
monster. Now with the market you can transfer the monster.
Leo Ribeiro<EMAIL_ADDRESS>schrieb am So., 30. Sep. 2018, 04:03:

I think it's critical in case the person does not want to be playing the
game right away and needs the RAM for other dapp... We should change the
Ricardian Contract and allow it (even in the ui)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MonsterEOS/monstereos/issues/29#issuecomment-425687886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYcWeke898qG22N6HPJdU74iMRPSWqXks5ugCZtgaJpZM4UzVGl
.


Spaces in font-family name breaks SVG fonts

This is probably more of an issue with the docs than the code itself, but the example for Font Face uses 'Source Sans Pro' for a font family name. Since this has spaces in it, the SVG font will not get loaded because the font-source-declaration code is using that name as an id selector (see https://github.com/thoughtbot/bourbon/blob/86d2147511265db9cdb35b497e195b8c4649ee98/app/assets/stylesheets/helpers/_font-source-declaration.scss#L26).
Maybe SVG selectors work differently than CSS selectors? If so, then please ignore this issue. Otherwise, I think the docs should be updated to not have spaces in the name (e.g. @include font-face("SourceSansPro", "/fonts/source-sans-pro/source-sans-pro-regular");).
Furthermore, if you want to be extra helpful you might have the docs explain to people that they should examine the actual SVG font file to determine what the actual ID is of the <font> element and make sure they are using that for the font-family name.

Thanks for the heads up! All fixed.


Growing: Removed paid books from reading list

Growing: Removed paid books from reading list
Problem
We are not allowed to endorse paid books, thus we would like to remove them from this list
Solution
Removed paid books and kept free books.

Verify "Open Source for Business: A Practical Guide to Open Source Software Licensing, 2nd Edition" with Remy


change review status name

Change won't fix label to intentional.

Some test files seemingly haven't been updated:
01:31:59 ======================================================================
01:31:59 ERROR: Filter by review status.
01:31:59 ----------------------------------------------------------------------
01:31:59 Traceback (most recent call last):
01:31:59   File "/home/checker/jenkins-workspace/master-64bit/codechecker-github/tests/functional/report_viewer_api/test_report_filter.py", line 220, in test_filter_review_status
01:31:59     status = get_status(review_status)
01:31:59   File "/home/checker/jenkins-workspace/master-64bit/codechecker-github/tests/functional/report_viewer_api/test_report_filter.py", line 26, in get_status
01:31:59     return shared.ttypes.ReviewStatus._NAMES_TO_VALUES[name]
01:31:59 KeyError: u'WONT_FIX'

I've updated the internal tests too.


Supporting CakePHP 2.7

refs #101

We should keep BC with CakePHP < 2.7
Could you use a custom validation rule instead?
Thank you!

Done.

@steinkel  I update this PR to support custom validation.

@steinkel ping

Thank you @okinaka


.PullRequestHandler is recognized as a project

I've encountered an issue where .PullRequestHandler is recognized as a project. Because there was a change in the .AL-Go/settings.json
https://github.com/microsoft/AL-Go/blob/06e91ef90e7ca0f7a82e3cfbad6487849a6fc067/Actions/ReadSettings/ReadSettings.ps1#L181
This line could be the offender. Maybe the .PullRequestFolder should just be removed after the changes were safely applied.

Guess this was already fixed.
@freddydk
But this opens another question to me.  "updateGitHubGoSystemFilesSchedule":  "0 0 * * 5",
Shouldn't this update the system files automaticly?


Sandbox fails with optional function parameter

Describe the bug
When submitting an optional value from the sandbox the transaction is rejected before broadcast.
So far I've seen this in two contract functions on testnet:

register-user in miamicoin-core-v2
transfer in miamicoin-token-v2

The behavior of the empty field makes me suspect these are not being wrapped in some/none.
To Reproduce
Steps to reproduce the behavior:

Go to the Explorer sandbox
Enter a contract name to pull up the functions
Select a function that accepts an optional value
Try to submit TX and see the error

Expected behavior
The transaction would succeed with either (none) or (some xyz) as the value.
Screenshots

I have noticed this too. Testing for ALEX.
The workaround I used was to deploy a contract instead with the contract call in it.

Yeah +1
Putting this on the backlog. The explorer currently encodes optional(string) as string regardless of if the string is empty or has value (maybe if it's empty it should default to optional-none

I don't think it's a stacks.js / wallet bug -- this example app using https://stacks.new seems to work: https://codesandbox.io/p/sandbox/cool-paper-fesyxn?welcome=true

This is fixed, thanks @friedger 🙏


legalIdentifier should be registryCode

In ORG.JSON terminology, there could be confustion between legalIdentifier and identifier (as of now these two peacefully coexist in the standard). registryCode is a better name for legalIdentifier. Other possibilities:

registry
localRegistryCode
localBusinessRegistryCode

implemented in version 0.4.3


Implement Event polling

Implements some way to poll events from a ConsoleEngine, allowing event handling
Addressing #10

If anybody wants this PR to be merged please comment below 🙂


How to use the HTTP website?

I am using typing behind a proxy, and the proxy will refuse the https connection of typings. I could not access the website even if I use a browser.
But I can access the http website.
Then how can I config the typings to use a http url like:
http://api.typings.org/search?query=jquery
Thanks

The docs are here: https://github.com/typings/typings/blob/master/docs/faq.md#configuration.

Example: https://github.com/typings/typings/issues/422#issuecomment-207648066.

Wow, my issue is exactly the same, thank you guys!


Update version to 24.45.31740

@mckees

I rebased the Debian patches onto 24.45.31740.11 since the upstream branch does not merge cleanly at any point after 24.39. Then I cherry-picked your patch on top


please make it available for safari.

Confirmed. I will work on it after finishing my exams. Meanwhile, if you have some dev knowledge, you can follow this guide to convert it yourself.

I wanted to make something like this extension on safari after finding this issue but I just realised, you don't need any extension on safari.
You can easily change user agent in safari. First, go to Settings -> Advanced -> Enable "Show Develop menu in menu bar". That would enable develop menu. Go to bing and tap on Develop -> User Agent -> Select "Microsoft Edge - Macos" and you are good to go.

I wanted to make something like this extension on safari after finding this issue but I just realised, you don't need any extension on safari.
You can easily change user agent in safari. First, go to Settings -> Advanced -> Enable "Show Develop menu in menu bar". That would enable develop menu. Go to bing and tap on Develop -> User Agent -> Select "Microsoft Edge - Macos" and you are good to go.

This did not work for me ?
I changed the Agent ti Edge, but I still get the "Download Microsoft Edge" message:

I wanted to make something like this extension on safari after finding this issue but I just realised, you don't need any extension on safari.
You can easily change user agent in safari. First, go to Settings -> Advanced -> Enable "Show Develop menu in menu bar". That would enable develop menu. Go to bing and tap on Develop -> User Agent -> Select "Microsoft Edge - Macos" and you are good to go.

This did not work for me ? I changed the Agent ti Edge, but I still get the "Download Microsoft Edge" message:

I wanted to make something like this extension on safari after finding this issue but I just realised, you don't need any extension on safari.
You can easily change user agent in safari. First, go to Settings -> Advanced -> Enable "Show Develop menu in menu bar". That would enable develop menu. Go to bing and tap on Develop -> User Agent -> Select "Microsoft Edge - Macos" and you are good to go.

This did not work for me ? I changed the Agent ti Edge, but I still get the "Download Microsoft Edge" message:

This works when you use bing as your search engine and put Safari into "edge development mode", it does not work for actual downloading the extension, only the web app its self.
I hope this makes sense ☺

it is not working after converting, I enabled it and it stil prohibits me from using bing.


ADA rewards need special handling

ADA isn't a token on the chain, but the coin. If the user has an ADA reward greater than the withdrawal + selected tokens, we should be able to withdraw without a send. Also, the calculated amount doesn't appear to be correct for this case. I had 1 token + 3.6 ADA as rewards.

@aryelciu001
Just have to have some logic, if user selected ada token, and if token is more than deposit amount required, have a button that says withdraw using ADA rewards instead of displaying people the amount of ada to send and the address, since it's not applicable. Withdrawing using ADA rewards should just be an API call.
However, what i do not like, is the ability of somebody to abuse it and waste people's transaction fees from their ada balance. Maybe should be required to have connected wallet and "Authenticate" the user by making them sign a transaction with their wallet, but not a Cardano transaction but just singing with their private key to authenticate it is indeed them doing this.
There, i finally found a use case for the wallet authentication @wolf31o2  ;-)  Yes i realize that users can just go to VM and do this already without authentication, but i'm saying maybe this should not be allowed at VM side either? Not sure. Just throwing some ideas around.
This will also require some modifications to the Transaction details as well, where it starts with ADA rewards ( maybe show amount with green font? ), remove the "You Send" field, and at end keep "you will get back" estimation.

sounds like too much work for little to no benefit

This is how VM works. TosiDrop is not correctly representing how the backend works to users. This is the oldest bug in TosiDrop.

The Original Bug. Soon to be 1 years old lol


Use CasbinAuthorize attribute on ApiController

I'm trying to use Casbin to control access to an api implemented using ApiController. The API uses Jwt bearer tokens.
Will this work with the CasbinAuthorize attribute?
Replacing the standard Authorize(Policy="...) attribute with CasbinAuthorize() does not seem to work. Checking the ClaimsIdentity inside a RequestTransformer shows that the User is not authenticated, and the claims array is empty.
Furthermore I'm redirected to login and gets a 404, instead of the expected 401 error.
So I'm wondering if the CasbinAuthorize attribute is supposed to work for thins kind of use-case?
If not, are there plans to cover use cases with bearer tokens?

@Sagilio

The redirect is because of config issues in my Startup.cs
But it would be good to know whether you believe the Middleware and CasbinAuthorize attribute should work OK when using bearer token authentication.

Seems to be working with bearer token , but I have to use both standard and casbin attribute:
[Authorize]
[CasbinAuthorize]
public IActionResult MyAction(...)

Is this intended?

Is this code work? :
[CasbinAuthorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme)]
public IActionResult MyAction(...)

Seems to be working with bearer token , but I have to use both standard and casbin attribute:
[Authorize]
[CasbinAuthorize]
public IActionResult MyAction(...)

Is this intended?

No.
Now, casbin middleware does not read the default policy or fallback policy in AuthorizationOptions, So it will not use the AuthenticationSchemes in the default policy.
But, I think we should not read those policies, we will provide AuthenticationSchemes options for this case.

I tried [CasbinAuthorize(AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme)]
And it works. I don't need the extra [Authorize] attribute, and I get 401 when token is missing as expected.
Then I removed AuthenticationSchemes = JwtBearerDefaults.AuthenticationScheme And it still works. Now I'm not able reprodue the issue.


ci: update docker image to v0.24.9

Move docker image to latest version: v0.24.9.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

Closing this since main was broken at the time when the v0.24.9 was tagged and the release is broken.
Something seems to have changed with how Docker buildx works and that seems to have broken the image build process. I will look into this and release/update the CI to use a new Docker image release.


Make terminal split by default in a new window

I'd like to be able to have all new VSCode windows open with the terminal and splitted by default. Right now I have Split the terminal every time I open a new window.
Configure which folders of a workspace the terminals open in would be amazing.

I'm almost always using 2 splitted terminals and it would be nice to have option to split them by default.

Duplicate https://github.com/Microsoft/vscode/issues/44302
@Floriferous @driamend you can try the terminal.integrated.experimentalRestore setting which does this on a very basic level. The thinking is to defer this to extensions in the future, but your feedback on #44302 will be very useful in determining that 😃


Re-run ext adv after completion (IDFGH-9373)

Both extended and normal advertising should be reran when complete in this Nimble example. Without this, only a single BLE client is able to connect when CONFIG_EXAMPLE_EXTENDED_ADV=1

sha=35926387738ba28c0c84d29c6e803ed15c5a8ae7

Hi @kevinhikaruevans ,
I found some issue with the patch. If connection was success , for extended adv , adv complete event is posted by stack. If we restart the ext adv here, then when the connection is disconnected, it will again try to restart ext_adv as it will invoke ext_bleprph_advertise in original code. . This results in crash since the previous instance of ext adv was already started by the new function call introduced in this patch. This may need more handling , i can check later. Have you not observed any issue in your testing ?
`I (595) NimBLE_BLE_PRPH: BLE Host Task Started
I (605) NimBLE: Device Address:
I (605) NimBLE: 60:55:f9:f6:05:4a
I (615) NimBLE:
I (625) uart: queue free spaces: 8
I (635) main_task: Returned from app_main()
I (5075) NimBLE: connection established; status=0
I (5075) NimBLE: handle=1 our_ota_addr_type=0 our_ota_addr=
I (5085) NimBLE: 60:55:f9:f6:05:4a
I (5085) NimBLE:  our_id_addr_type=0 our_id_addr=
I (5095) NimBLE: 60:55:f9:f6:05:4a
I (5095) NimBLE:  peer_ota_addr_type=1 peer_ota_addr=
I (5105) NimBLE: 45:40:e1:10:0f:73
I (5105) NimBLE:  peer_id_addr_type=1 peer_id_addr=
I (5115) NimBLE: 45:40:e1:10:0f:73
I (5115) NimBLE:  conn_itvl=36 conn_latency=0 supervision_timeout=500 encrypted=0 authenticated=0 bonded=0
I (5125) NimBLE:
I (5135) NimBLE: advertise complete; reason=0
I (7035) NimBLE: encryption change event; status=1292
I (7035) NimBLE: handle=1 our_ota_addr_type=0 our_ota_addr=
I (7045) NimBLE: 60:55:f9:f6:05:4a
I (7045) NimBLE:  our_id_addr_type=0 our_id_addr=
I (7045) NimBLE: 60:55:f9:f6:05:4a
I (7055) NimBLE:  peer_ota_addr_type=1 peer_ota_addr=
I (7055) NimBLE: 45:40:e1:10:0f:73
I (7065) NimBLE:  peer_id_addr_type=1 peer_id_addr=
I (7065) NimBLE: 45:40:e1:10:0f:73
I (7075) NimBLE:  conn_itvl=36 conn_latency=0 supervision_timeout=500 encrypted=0 authenticated=0 bonded=0
I (7085) NimBLE:
I (10055) NimBLE: disconnect; reason=531
I (10055) NimBLE: handle=1 our_ota_addr_type=0 our_ota_addr=
I (10055) NimBLE: 60:55:f9:f6:05:4a
I (10055) NimBLE:  our_id_addr_type=0 our_id_addr=
I (10065) NimBLE: 60:55:f9:f6:05:4a
I (10065) NimBLE:  peer_ota_addr_type=1 peer_ota_addr=
I (10075) NimBLE: 45:40:e1:10:0f:73
I (10075) NimBLE:  peer_id_addr_type=1 peer_id_addr=
I (10085) NimBLE: 45:40:e1:10:0f:73
I (10085) NimBLE:  conn_itvl=36 conn_latency=0 supervision_timeout=500 encrypted=0 authenticated=0 bonded=0
I (10095) NimBLE:
assert failed: ext_bleprph_advertise main.c:116 (rc == 0)
Stack dump detected
Core  0 register dump:
MEPC    : 0x408005fa  RA      : 0x4080919a  SP      : 0x4081b6c0  GP      : 0x4080edf0
0x408005fa: panic_abort at /esp-idf/components/esp_system/panic.c:452
0x4080919a: __ubsan_include at /esp-idf/components/esp_system/ubsan.c:313
TP      : 0x40804eec  T0      : 0x37363534  T1      : 0x7271706f  T2      : 0x33323130
0x40804eec: ble_lll_sched_insert_after at ??:?

MHARTID : 0x00000000
Backtrace:
panic_abort (details=details@entry=0x4081b6fc "assert failed: ext_bleprph_advertise main.c:116 (rc == 0)") at /esp-idf/components/esp_system/panic.c:452
452	    *((volatile int *) 0) = 0; // NOLINT(clang-analyzer-core.NullDereference) should be an invalid operation on targets
#0  panic_abort (details=details@entry=0x4081b6fc "assert failed: ext_bleprph_advertise main.c:116 (rc == 0)") at /esp-idf/components/esp_system/panic.c:452
#1  0x4080919a in esp_system_abort (details=details@entry=0x4081b6fc "assert failed: ext_bleprph_advertise main.c:116 (rc == 0)") at /esp-idf/components/esp_system/port/esp_system_chip.c:77
#2  0x4080d4e6 in __assert_func (file=file@entry=0x420635ed "", line=line@entry=116, func=, func@entry=0x42063be4 <func.2> "", expr=expr@entry=0x420635dc "") at /esp-idf/components/newlib/assert.c:81
#3  0x42006cb4 in ext_bleprph_advertise () at ../main/main.c:116
#4  0x42006f10 in bleprph_gap_event (event=0x4081b8a0, event@entry=, arg=) at ../main/main.c:308
`

Hi @rahult-github, I see the crash now. I was previously checking if the device was busy in ext_bleprph_advertise, but this is probably not a good way to handle this.
Just wondering, are you able to run multiple ble clients with ext adv without the patch?

Hi @kevinhikaruevans ,
Please help check if attached patch works for you
0001-Nimble-Updated-bleprph-example-to-enable-ext-adv-aft.txt

@rahult-github Thank you! Yes, that patch worked for me. I've updated the PR with that patch.

sha=0b921fda149c69510258ba879e34cbeb1829cce0

Hi @kevinhikaruevans  ,
I have below suggestions:

Can you please merge the two commits and make one. You can have the commit in your name as contributor.
Please rebase to latest master

Hi @rahult-github

I've squashed the two commits
I've rebased the branch with master

Changes part of master tree   . Thanks for your contribution.


Add option to enable data stream in the AdministrationSettingsAPI

Description
Every vManage we onboard, we automatically configure the data stream settings. Ask is to add ability to enable data stream similar how we enable other options in AdministrationSettingsAPI.

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/issues/461


example with learning resources reorganized + github actions rendering

[1]
The main update is splitting learning resources into:

science
tools
frameworks

[2]
Also made .github/workflows/publish.yml to automatically render/update site when the main branch is updated.
*** I DO NOT RECOMMEND MERGING WITHOUT MORE DISCUSSION ***

Sticking with the quarto publish gh-pages route for now.


⚠ Bofrost.lu has degraded performance

In 7197da8, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 899 ms

Resolved: Bofrost.lu performance has improved in 61a3344.


Terminal F11 is missing (F10 twice)

Hello,
The F11 Button is missing and the F10 Button is there twice.

What version of CB are you using?  I'm using 1.9.2 and it counts F9, F10, F11, F12 correctly.

#617 + #614


FluentLoggerFactory#getLogger() potentially returns null

entry.getKey() returns null when key is GCed.

@todesking  thanks for your contribution. LGTM, merged.


Mixpanel Integration - Add more events to track

I have created a list of events that we should start monitoring.
As a start, Boon would you be able to review the events and share your thinking?
https://docs.google.com/spreadsheets/d/1CqhJYMidzEKqlgDCpGpRu5X6ke8h4qhvE3DG8ZjWCZc/edit#gid=0

@AW-STJ
I'd comment on each individual row, but would you check out what I wrote for BC a while back and see if you can refine the list, then I'll check again? You might have already thought about this and more, but hopefully it still helps. (dumping it below and wrapping it with a bit more detail).

I find it especially helpful to think in terms of flow, and in our case how we make use of Mixpanel Flows and from there, derive the events to log.
I still suggest we refrain from blanket logging too many events at one go, but instead to focus on specific flows/process and key indicators, to collect data and refine them. But separating events into UI shown (I would say navigation but it's easy to say navigation is an action) and actions allow some flexibility and reduce confusion in the longer run.
Categorise events into 2 types:
A. An action (or the result) performed
B. A screen or piece of UI being shown
Name (A) like this:
"Terms Accepted"
"Wallet Created"
"Wallet Imported"
"Seed Phrase Verified"
"Seed Phrase is Invalid"
"JSON Backed up"
"Seed Phrase Backed up"
"Key Security Upgraded"
"Token Sent"
"Wallet Switched"
with the format: " "
Name (B) like this:
"tab: Wallet"
"screen: Transaction Info"
"alert: failure to send"
With the format: "<tab/screen/alert/whatever>:
An example of the start of a flow when the user taps on a backup button button and the backup screen is shown to illustrate difference between action and screen. We can end up logging any of these flows:

"Backup Button Tapped"

"screen: Backup seed phrase"

"Backup Button Tapped"

"screen: Backup Keystore"

"Prompt to Backup Button Tapped"

"screen: Backup seed phrase"

Notice the different permutations of 2 screen and 2 buttons.

As for items like "Number of times Tokens added", consider both an event (or more than 1 event, with the last storing the number of tokens added) as well as the total number of tokens manually added as a user profile property. Similary for "Number of times 'Reload' clicked"; while "Reload" might be a possible event, the count is only trackable or meaningful as a user profile property.
I don't think those 2 above are the best examples, but "Number of transactions posted" might be a good user profile property,

A bit more on thinking about flow: For example, say we want the send experience to be the best. How do we track that? Maybe with these events (I haven't thought deeply about this, so it can be very much improved):

Wallet tab's Token card tapped (native crypto, ERC20 or ERC721, 875)
Token screen's Send Tap
Send screen's Send button tapped
Send screen's Cancel button tapped (or Send cancelled)
Gas settings tapped (etc)
Confirmation screen's Send button tapped (or Sent)
Confirmation screen's Back button tapped (or Send cancelled)

We can also track how many transactions has been sent via a user profile property (potentially even breaking it down into native crypto, ERC20, ERC721, etc).
Then we can run these events through Mixpanel Flows and optimize it [1]
[1] Again taking care to note the bias presented by the install base..

I will iterate the list based on your comments and assign this back to you when ready.

I have created an additoinal sheet, to track 3 flows for now as a start:

Onboarding
Back-up
Import

Let me know whether the format makes sense and shows how we are would like to track the flows. Will add more flows based on that.
https://docs.google.com/spreadsheets/d/1CqhJYMidzEKqlgDCpGpRu5X6ke8h4qhvE3DG8ZjWCZc/edit#gid=820349020
cc: @colourfreak for your reference. All feedback welcome

Looks great.
I suggest we remove the word "button" from events like "'Back-up this wallet' button tapped" to make it a bit shorter and use abbreviations when it's readable. I can only think of the Transaction > Txn/txn for now. Long names get truncated in the Mixpanel dashboard.
Shall we use title case unless that's how the text looks in the app? ie.

"'Back-up this wallet' button tapped"

becomes:

"'Back up this Wallet' Tapped"

Bit more consistent when looking at the dashboards
We can't log a "Session drop off" drop-off event explicitly unless there's another event like (making it up) like "Create Address Cancel Tapped" that we can capture.
I missed out one thing though since we are talking about flows. We can tag each event with the name mentioned in the "Flow" column (eg. "Import Flow". But probably "Import Wallet"?) as a property to be able to disambiguate event names. (Refer to screenshot, the "Brand" is a property and we would use "Flow" instead)

Shall we tightened up the Onboarding one first and see if it works out well before we finalize the rest?


Write the log channel hierarchy after execution of a top level executable

Whenever a job of transformation finished we have access to the complete execution lineage.
We should write this lineage information to Neo4j.
We can use LoggingRegistry.getInstance().dumpItems() to get the complete parent-child hierarchy.

Obviously also save logging text, results, result rows, files, variables set, ... anything that could be useful


Version/Meta table switch changes

Changed the legacy switch as discussed with @csmoore.
Added the legacy standard setting as well.

@Dbarnes1 , please verify that using this change, together with the latest JMSML commits here https://github.com/Esri/joint-military-symbology-xml/pull/277, will result in a legacy stylx that works with our standard test datasets.  The LegacyEntities you and @BobBooth created will be in the LegacyMappingOriginalIcons table and the meta table in the stylx now contains the two legacy related switches that @csmoore specified.


version: Create a VERSION file

Since we want to start tagging and branching this repo,
create a VERSION file starting with the last version released.
Fixes #246
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

@jcvenegas @chavafg PTAL.
Once this is merged, I will tag this as 1.11.0-alpha1. This should be sufficient for https://github.com/kata-containers/packaging/pull/1008 to pass I think.

/test

/test-ubuntu

@amshinde @jodh-intel @chavafg because in the past we did not branched stable branches and still may be need this for old branches releases I created stable-1.9 and stable-1.10 using tip on master, we will want to add a VERSION file  for other branches to help our release scripts have an env as they expect.

@jcvenegas Thanks. I'll create the VERSION files for the stable branches.


BUG - get_method/property uses "base" rather than "most derived"

If you register the same function name in a derived class and in a base class
and call the function via a derived instance
C++ calls the derived method
RTTR calls the base method
RTTR searches from the "base class" to the derived class for the matching name.
The linear search of prop/meth vecs must use reverse iterator
staring from the most derived class registered.

Coverage increased (+0.09%) to 93.149% when pulling cd5dcaba382193caec9e150f19067457943ac0f6 on dand-oss:search-order-bug into 3e1dbc2b1a88cd4134a6374118caf4c824c939a5 on rttrorg:master.

Can you please add a unit test for both scenarios?

@dand-oss
any updates here? I would also change something in this PR...

@acki-m
My understanding at this point

all questions answered
all requests implemented
all unit test pass
rebased to latest upstream

Comment thread nesting is a bit confusing
If there is anything else you'd like me to do, let me know

@dand-oss
Did you read my latest comment in the modified code sections?
The biggest issue is this the usage of RTTR_ENABLE_OVERRIDE
You need to tell me how I can get this warning myself.

I need at least the info to reproduce the warning, otherwise I cannot fix the source of the issue.

@dand-oss
Please give me an update here.

I need at least the info to reproduce the warning, otherwise I cannot fix the source of the issue.
Please give me an update here.

I created a branch to demonstrate the clang problem.
Clang override error
https://github.com/rttrorg/rttr/pull/189
struct compile_base
{
RTTR_ENABLE()
};
struct compile_derived : compile_base
{
// Clang options want "override" on virtuals inherited from base
RTTR_ENABLE(compile_base)
};
/home/travis/build/rttrorg/rttr/src/unit_tests/misc/test_misc.cpp:57:5: error: 'get_derived_info' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
/home/travis/build/rttrorg/rttr/src/unit_tests/misc/test_misc.cpp:57:5: error: 'get_ptr' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
/home/travis/build/rttrorg/rttr/src/unit_tests/misc/test_misc.cpp:57:5: error: 'get_type' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

@dand-oss
Please update your PR with the newest changes from master, remove your workaround and then we can finally merge. 👍

rebased, squashed, and test passes

@dand-oss
no need to squash the commit, I can do this too.
However, there is still a RTTR_ENABLE_OVERRIDE in the sources. Can you please remove it?
Then I can merge it.


lib3mf v2.0.0 alpha: extra blend method in multiproperties

The 3MF materials extension says that the number of blendmethods in a multiproperties element must be one less than the number of layers in it.
lib3mf v2.0.0 asks to supply a blendmethod for each layer, (PMultiPropertyGroup::AddLayer) and also writes each of them in the 3mf model file.
In the following example there are 5 layers in the multiproperties element and blend methods are specified for each of them.
<m:multiproperties id="14" pids="2 7 9 11 13" blendmethods="mix mix mix mix mix">
Is this correct? Or should there be 4 blendmethods?

You are right, there should be 4 blendmethods.
https://github.com/3MFConsortium/lib3mf/pull/148 took care of this now.
Cheers!

@martinweismann Looking at the code changes it seems the blendmethod supplied with first layer is ignored? So we are supposed pass the correct blendmethods for the subsequent layers?
I was shifting the blendmethods to left by 1 so far. Seems I do not need to do that anymore?

This is correct, the blendmethod of the first layer is ignored. Thus there is no need to shift methods to the left. I hope that works for you.
I think the current API regarding layers of multiproperties is minimalist but clear and it does capture the gist of what is defined in the materials-specification https://github.com/3MFConsortium/spec_materials/blob/master/3MF Materials Extension.md#chapter-5-multiproperties.


Fix DHODH Reactions

Main improvements in this PR:
As proposed in #609:

Creates a new metabolite MAM20019c to represent cytosolic FMNH2
Replaces MAM03103m with MAM01828c and MAM03102m with MAM20019c in MAR04575
Creates a new reaction to represent redox of FMN(H2) and ubiquinone/ubiquinol catalyzed by DHODH: MAR20167: MAM20019c + MAM03103m <-> MAM01828c + MAM03102m, GPR: ENSG00000102967, references: PMID:34428349

I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected develop as a target branch
[X] Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

looks fine - suggest to add Rhea id: 30187

I feel a bit weird about that, cuz after these changes, MAR04575 would be redox between (dihydro)orotate and FMN(H2), and MAR20167 would be redox between FMN(H2) and ubiquinone/ol, and that RHEA ID is for redox between (dihydroorotate) and ubiquinone/ol. There doesn't appear to be a RHEA ID that exactly matches either of these reactions, but I suppose I could add 31087 as the RHEA ID for both MAR04575 and MAR20167 if that's what you were suggesting

sorry my comments was not clear, what I was suggested is to add this Rhea id to MAR20167. And it doesn't appear to be an exactly match though.
Hmmm...


Error when reducing

The training went well. I am using Python 3.6 and TF 1.7.0. However when reducing the model I get the following:
2018-04-25 19:31:50.717783: W T:\src\github\tensorflow\tensorflow\core\framework\op_kernel.cc:1273] OP_REQUIRES failed at save_restore_v2_ops.cc:184 : Not found: Key generator/decoder_1/deconv/filter not found in checkpoint
Traceback (most recent call last):
File "D:\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1327, in _do_call
return fn(*args)
File "D:\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1312, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "D:\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1420, in _call_tf_sessionrun
status, run_metadata)
File "D:\Python36\lib\site-packages\tensorflow\python\framework\errors_impl.py", line 516, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: Key generator/decoder_1/deconv/filter not found in checkpoint
[[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]
[[Node: save/RestoreV2/_79 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device="/job:localhost/replica:0/task:0/device:CPU:0", send_device_incarnation=1, tensor_name="edge_84_save/RestoreV2", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:GPU:0"]]
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "reduce_model.py", line 215, in
saver.restore(sess, checkpoint)
File "D:\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 1775, in restore
{self.saver_def.filename_tensor_name: save_path})
File "D:\Python36\lib\site-packages\tensorflow\python\client\session.py", line 905, in run
run_metadata_ptr)
File "D:\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1140, in _run
feed_dict_tensor, options, run_metadata)
File "D:\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1321, in _do_run
run_metadata)
File "D:\Python36\lib\site-packages\tensorflow\python\client\session.py", line 1340, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.NotFoundError: Key generator/decoder_1/deconv/filter not found in checkpoint
[[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]
[[Node: save/RestoreV2/_79 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device="/job:localhost/replica:0/task:0/device:CPU:0", send_device_incarnation=1, tensor_name="edge_84_save/RestoreV2", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:GPU:0"]]
Caused by op 'save/RestoreV2', defined at:
File "reduce_model.py", line 213, in
saver = tf.train.Saver()
File "D:\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 1311, in init
self.build()
File "D:\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 1320, in build
self._build(self._filename, build_save=True, build_restore=True)
File "D:\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 1357, in _build
build_save=build_save, build_restore=build_restore)
File "D:\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 809, in _build_internal
restore_sequentially, reshape)
File "D:\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 448, in _AddRestoreOps
restore_sequentially)
File "D:\Python36\lib\site-packages\tensorflow\python\training\saver.py", line 860, in bulk_restore
return io_ops.restore_v2(filename_tensor, names, slices, dtypes)
File "D:\Python36\lib\site-packages\tensorflow\python\ops\gen_io_ops.py", line 1541, in restore_v2
shape_and_slices=shape_and_slices, dtypes=dtypes, name=name)
File "D:\Python36\lib\site-packages\tensorflow\python\framework\op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "D:\Python36\lib\site-packages\tensorflow\python\framework\ops.py", line 3290, in create_op
op_def=op_def)
File "D:\Python36\lib\site-packages\tensorflow\python\framework\ops.py", line 1654, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
NotFoundError (see above for traceback): Key generator/decoder_1/deconv/filter not found in checkpoint
[[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]
[[Node: save/RestoreV2/_79 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device="/job:localhost/replica:0/task:0/device:CPU:0", send_device_incarnation=1, tensor_name="edge_84_save/RestoreV2", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:GPU:0"]]

@dsanjit Download the pix2pix version before updated to tf 1.4 . I had the same issue and it was fixed training the model with the previous version of pix2pix since they changed the model so both models are not equal.
Hope this helps you

Same issue for me what @tryzombie501 says...


Braces behavior using sl_SI (Slovenian) layout on Linux PC

Type: Bug
Typing the sequence: abc[123] shows as: ab[12]3c in code editor.
Same thing: abc{123} becomes ab{12}3c and abc<123> becomes ab<12>3c, only the round braces are OK.
For better illustration:
typing [1 works as [1  but only at start of line,
typing 1] brings ]1,
typing 1[ brings [1. same goes for the {} and <>
When I try the same thing in a terminal all is OK. Doing the same thing in Windows works OK too.
Braces (except the round ones) on Slovenian keyboards ar two key combinations:
AltGR+ F : [
AltGR+ G: ]
AltGR+ B: {
AltGR+ N: }
AltGR+ Comma: <
AltGR+ Dot : >
Evidently these are not handled in VSCode the same way on Linux as on Windows.
The same issue you can excpect with Croatian an Serbian(Latin) layouts too.
This I noticed about 6 years ago, but as I do most of my work on Windows I took no action about it. Because this is very annoying bug, I also expected it'll be fixed fast. But ...
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Linux arm64 6.6.62+rpt-rpi-2712
Modes:

System Info

Item
Value

CPUs
Cortex-A76 (4 x 2800)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: disabled_offwebnn: unavailable_software

Load (avg)
0, 1, 1

Memory (System)
7.86GB (5.62GB free)

Process Argv
--crash-reporter-id ad87f234-1214-4142-a8cb-58d922f732fb

Screen Reader
no

VM
0%

DESKTOP_SESSION
xfce

XDG_CURRENT_DESKTOP
XFCE

XDG_SESSION_DESKTOP
undefined

XDG_SESSION_TYPE
x11

Extensions (5)

Extension
Author (truncated)
Version

black-formatter
ms-
2024.4.0

debugpy
ms-
2024.12.0

python
ms-
2024.20.0

vscode-pylance
ms-
2024.12.1

reload
nat
0.0.7

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
vscaac:30438847
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupyter:31046869
nativerepl1:31139838
pythonrstrctxt:31112756
nativeloc2:31192216
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530

Hi, I've been using vsc for 4 years now and I'm programming on Serbian Latin and didn't have any problems.
AltGR+ F : [
AltGR+ G: ]
AltGR+ B: {
AltGR+ N: }
AltGR+ Comma: <
AltGR+ Dot : >
I'm using this as well and never had a problem. Maybe something else is causing it, not the language...

Hi, yanedev,
it is always possible that the problem lays somewhere else.
But I always have this same problem with VS Code out of the box on every single Linux distribution I tried (and there were quite some) and on x86, x64 , armhf, aarch64  platforms. Also, I tried with Atom editor on x64 Debian 11 a while ago, it did not show any such behavior but it did not favorably compare to VS Code, so I ditched it.
So I have to ask you:

did the things worked for you out of the box or did you have to tweak some settings?
which Linux distribution are you using?
exactly which keyboard type and keyboard locale are you using?

BTW: I totally forgot to mention that any other character which require pressing AltGR on Slovenian standard keyboard are not working too: , |, ~, ˇ, ^, ˚ e.t.c. Mostly backslash and pipe characters are badly missing. All that works on Windows platforms!

I was thinking about the most probable differences between my and yanedv's setup. Serbian Latin uses the same character set as the Slovenian language, so he could use Slovenian keyboard too.
I decided to install fresh MX Linux on my test machine. This time I installed it with the Slovenian as the OS's language. I hate that some folder names are translated into Slovenian (breaking the standard naming). To fix that, I used dpkg-reconfigure locales to switch back to en_US.UTF-8. After the reboot, I checked VS Code's behavior.
It worked OK
Now I must figure out if I can achieve the same thing on some Mint, Armbian and Debian machines preferably without reinstalling.
With that, I'll close the issue. Thanks to yandev, his reply pointed me in the right direction.

Glad I could help. Check the shortcuts, maybe one acts like as left arrow should...Good luck


Iterate on dataset/iterator when using @tf.function

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Archlinux
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.0.0-dev20190312
Python version: 3.6
CUDA/cuDNN version: 10
GPU model and memory: 1080 Ti

Describe the current behavior
Can't convert the dataset/iterator to its graph representation: I'm forced to loop in eager mode, but I want to have a graph representation of the loop too (since I need to export a SavedModel that contains the loop itself).
Describe the expected behavior
The iterator / the dataset should be converted in its graph representation.
Code to reproduce the issue
A code that loops using Tensorflow primitives (like for i in tf.range(10)) can be converted into its graph representation without any problem, while a code that creates a python iterator from a dataset object (using iter(dataset)) can't.
Moreover, maybe because we are in the early stage of the development, I'm unable to convert a loop that loops over a dataset to its graph representation.
import tensorflow as tf

def real_gen():
    for i in range(10):
        yield i

dataset = tf.data.Dataset.from_generator(real_gen, (tf.float32))

@tf.function
def itertest():
    tf.print(next(iter(dataset)))
itertest()

@tf.function
def loopiter():
    for real in dataset:
        tf.print(real)
loopiter()

The itertest() call fails because RuntimeError: dataset.__iter__() is only supported when eager execution is enabled.
While the loopiter() call fails because tensorflow.python.framework.errors_impl.NotFoundError: Function __inference_Dataset_flat_map_flat_map_fn_22 is not defined.          [[{{node ReduceDataset}}]] [Op:__inference_loopiter_35]

I am closing this issue as this should now be supported as for TF 1.14 and TF 2.0-beta. Please verify and if you encounter a problem re-open this issue with up-to-date information.


Rewritten schema editor

splited schema editor to two pages
resized table to 100% width
resized editor to 100% width and 80% viewport height

merged


Rustfmt adds new indentation every time it formats let else in macro declaration

Example code:
// The indentation stays the same, as expected
fn foobar() {
    let x = y else {
        panic!();
    };
}

// The indentation is increased every time you run `cargo fmt`
macro_rules! foobar {
    () => {
        let pat = expr else {
                    panic!();
                };
    };
}

Thanks for reaching out. I think the underlying issue is that rustfmt doesn't currently format let else expressions because the rules for formatting them have not yet been finalized via an RFC in fmt-rfcs repo.
Related issues are #5489, #5044, and #4609 which also deal with cases where extra indentation is added in macro definitions when rustfmt fails to format the macro body.

This is a precise dupe of #5213 , which got closed as dupe of the issues linked above.

It's quite interesting that this is the second time that this specific let else case was hit. Maybe many people wrote macros in that fashion and now want to replace them with let else?

I don't know about the other bug, but I was writing assert_let

Going to close this as a duplicate of https://github.com/rust-lang/rustfmt/issues/5213
As mentioned above, the underlying issue here is that rustfmt doesn't currently format let else. Rules need to be added to the Rust Style Guide before an implementation can be added to rustfmt. If you want to stay informed about the style discussion you can subscribe to https://github.com/rust-dev-tools/fmt-rfcs/pull/165, and to keep up with implementation progress you can subscribe to #4914.
If the macro indentation behavior continues after let else formatting is implemented, then we can reopen this issue and investigate further.


Automated cherry pick of #5054: fix: createdAt should not be synced when update

Cherry pick of #5054 on release/3.1.
#5054: fix: createdAt should not be synced when update

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.1@8857a62). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/3.1   #5055   +/-   ##
=============================================
  Coverage               ?   6.75%
=============================================
  Files                  ?     544
  Lines                  ?   95156
  Branches               ?       0
=============================================
  Hits                   ?    6431
  Misses                 ?   88186
  Partials               ?     539

Flag
Coverage Δ

#aFlag
6.75% <ø> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guests.go
0.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8857a62...d912e29. Read the comment docs.

/lgtm
/approve


Separate LPC for specific frames

Figure out a way to identify which frames would benefit from coding the subframes separately

if the subframes are different enough then code them separately
the number of additional coefficient bytes must be smaller than the difference in the residual length

TODO:

[ ] Modify the Straw format to accept separate LPC coefficients for subframes

Format support implemented in:
https://github.com/KLZ-0/straw/commit/a80193a5d092ffde2aef32659643e630ba0c3829

Possible after #36 though not feasible

Storing the additional LPC coefficients proved to a lot more inefficient than just storing one set and using decorrelation


RBF is not disabled by default anymore

But it's not enabled by default either: the developer is forced to
make a decision if he wants to avoid the compile-time warnings.
This way we avoid the potential problems that could have been caused
by simply switching the default to be RFB-enabled, as discussed
originally here: https://github.com/MetacoSA/NBitcoin/pull/355

Wait I don't understand why there is both OptInRBF and RBF. What is the rational @lontivero ?
If RBF is set to true we have RBF, else we don't....
https://github.com/MetacoSA/NBitcoin/pull/683

Nicolas: Lucas didn't introduce two flags. After Lucas' PR, there was only OptinRBF. However, after this PR, calling it with the prefix "Optin" wouldn't make much sense, so I renamed it to "RBF". However, I left the old property with an [Obsolete] attribute in order not to break API.

Ah ok.
Well I think we can rename fine in this case the change is 5 days ago we will not break too much...

I don't really like bothering users with a question they don't care or are unlikely to understand. (what the hell is RBF??)

Well I think we can rename fine in this case the change is 5 days ago we will not break too much...

I can rename the parameter to replaceByFeeEnabled?

No it should be named RBF, but most users don't care about it and asking them a question if they don't care about it is not a good solution I think.
I am mixed... ping @lontivero what do  you think?

asking them a question if they don't care about it is not a good solution I think.

Well, I can use XML documentation for that API, where we recommend to enable it unless they need to care about backwards compatibility.

That make sense.

That make sense.

Done, and rebased (and fixed build).

Concept ACK.

Well I think we can rename fine in this case the change is 5 days ago we will not break too much...

Agree, renaming is fine, probably nobody using it yet.

nobody using it yet.

Then let's merge it asap and bump?

No it should be named RBF, but most users don't care about it and asking them a question if they don't care about it is not a good solution I think.
I am mixed... ping @lontivero what do you think?

It is okay for me but let me be honest here: the name RBF sucks bad because the semantic is unclear, for example: what does it means IsRBF? Does it means that the tx is replaceable? It is confusing.  Bitcoin core calls it OptInRBF (what also sucks) but its semantic is at least a bit more clear. I would call it ExplicitlySignalReplaceability or something like that in a no library component.
I think the high level wording are:

replaceable transactions to those signaling (iimplicitly/explicitly) replaceability,
replacement transactions to those that spend the same inputs that and unconfirmed tx signaling replaceability.

So, in the library it is okay to call it RBF but in higher level software should be called with a more meaningful name.

@knocte have you fixed all the warnings?

@knocte have you fixed all the warnings?

Oh well... I started doing this, and found out that Transaction.Sign() calls CreateTransactionBuilder()... Which means that we should add overloads on Sign() (or Transaction ctor) with RBF flag too.
I went for the latter, and oh my, the rabbit hole is very deep. I need help.

(I pushed my warnings-fixage WIP work as a 2nd commit)

@knocte I think that you just have to call with RBF=false on existing stuff.

@knocte I think that you just have to call with RBF=false on existing stuff.

Sorry for late reply, but I never understood the statement above. If I mark RBF=false on existing stuff, it would defeat the point of this PR.
Anyway I've been thinking about this lately, and as you Nicolas seem to always recommend TransactionBuilder API over Transaction API, would you accept marking Transaction type as Obsolete? This way I can live with it being RBF=false by default while TransactionBuilder has RBF enabled by default.


Throw exception if variable name is invalid

Throw exception if variable name does not start with _ or upper-case letter (this is mainly to notice errors in unit tests!)

This PR might need some more explanation. In what way does a check like this help?
Currently, we sometimes create internal variables and have them named such that their name is invalid with respect to the ASP core standard, as this guarantees that they cannot come into conflict with any variables of the input program. This check now restricts variable names but still allows that variables are named _foo, which is against the standard. Why this restriction and not another?

The motivation for this PR was that I accidentally used VariableTerm.getInstance("x") instead of ConstantTerm.getInstance("x"), which led to confusing results.
On second thought, I have realised that variable names starting with upper-case letters are that way purely because of convention, and there is no technical reason for such a restriction inside the solver. Therefore, I´m closing this PR.


Implementing a language model

Does anyone have any recommendations on how one would go about training the trained model with a language model to move the output closer to the ground truth?

Any  light on this issue @buriburisuri

Baidu's DeepSpeech paper trained a simple n-gram language model and used a weighted sum of the log probabilities and word count to combine the two models. The two were trained separately but the n-gram is much simpler and could be trained on many more utterances than the neural net.

@MorganGellert  Thank you!


Have last cache configuration changes go through WAL

Currently, when last caches are created/deleted, there is no WAL entry for this configuration change, so these actions force persistence of the catalog before returning a success response to the caller, vs., creating a WAL entry and waiting for that to be flushed.
The purpose of this issue is to see if we can have these configuration changes, i.e., last cache create/delete be entered in the WAL.

This is done now.


Kf/fix pytorch warnings

Two warnings are triggered in the Multi2OIE code:
/home/au479461/PycharmProjects/conspiracies/src/conspiracies/docprocessing/relationextraction/multi2oie/other/bio.py:209: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at  ../torch/csrc/utils/tensor_new.cpp:210.)
  return [torch.Tensor(pred_tags) for pred_tags in total_pred_tags]
/home/au479461/PycharmProjects/conspiracies/src/conspiracies/docprocessing/relationextraction/multi2oie/other/bio.py:38: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
  return torch.tensor(res, dtype=torch.bool, device=tensor.device)

This PR addresses those two warnings.

vstacks numpy arrays instead of lists in a loop and creates a tensor from the resulting array, as the warning suggests.
Uses tensor.bool() to convert the original tensor straight into a boolean tensor that gets modified based on the contents of the original tensor, thereby skipping one tensor construction and avoiding the warning from the constructor.

Love these changes Kasper!


Tweak default gradle options

If I look at the gradlew file I see:

DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'

To me, this looks like the exercises by default run with 64MB of memory. If that is correct, we should probaby update to a more reasonable amount.

AFAIK this are the options to run grade itself.
Gradle forks a new JVM to run the tests.


Add validation for NAME=VALUE tags

The name and value pairs for a key tag must only contain alpha-numeric and hyphen characters.

Tags are used both for JWTs and for AWS instances (during encryption/updates). The syntax check is enforced only for JWT tags.

👍


Selecting an item in menu to scroll to a specified viewController  will block pageViewController scroll animation。

Parchment version: 3.0.1
xcode: 13.0
device：iPhone 12 iOS 15.0
There are some viewControllers have auto-scroll infinite loop scrollView。 If I scroll pageViewController to left or right by swipe that will be fine.But if I select an item in menu to scroll to a specified viewController ,  that will block view。If I stop timer schedule of infinite loop scrollView before selecting an item， the scroll animation will be fine。

Hi @MrKang. Sorry for the late response. I hope you managed to find a solution for this. If you still think it's a bug with Parchment, let make know and I can re-open. If you have any ways of reproducing this it would be great.


use ci/deploy.sh in sync with upstream

should make it harder to get out of sync

We are going to converge !
./ci/deploy.sh: line 4: encrypted_c6b45058ffe8_key: unbound variable


Add abi-check-plugin to all modules using @PublicApi

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Unrelated failure.


ValueError: 'llava' is already used by a Transformers config, pick another name.

Hi Yaffa16,
The issue arises from the introduction of 'llava' in the recent transformer versions, leading to a name conflict. Following the README's advice to create a new environment should resolve this problem. If it persists, consider installing transformers version 4.31.0.


The enable flag should be aligned with ensure.

ensure shouldn't bring master up if $enable is set to false.

I would love to see this gets merged soon. This could master started running on unspecific node.

Looks good to me. There's one case I can think of, that we won't be able to handle. If someone wants to install the service (enable => true) but doesn't want Puppet to ensure state of the service (e.g. ensure => undef).

thanks for merging this

No problem, release tagged as v0.6.3.


Kite keeps running in the backgournd

I found that Kite is running in the background and consuming lots of my computer's resources. I could not find why, and googling doesn't help either. Although Kite's copilot feature is awesome to use (I'm using Atom BTW), but keep running in the background does not seem to be a good thing for me. (It seemed to me that it is running some deep learning model on its own, without my knowing, and my laptop fan runs like crazy.)
I wonder if someone could at least explain to me what happened here?

@mark-fangzhou-xie if this happens again, can you run the terminal command wget "http://localhost:46624/debug/pprof/profile" and send us the CPU profile? You can email it to<EMAIL_ADDRESS>This behavior may be due to TensorFlow executing in the background.

It happened just now, and this time it only lasted for a short period of time.
I have run the command in the terminal and attach the CPU profile to that address.
Thank you so much!

Hi @mark-fangzhou-xie
I believe there are two separate issues at play here, and that the original CPU spike you were seeing has a different cause then the second one that you profiled.
Today we released a couple of limited fixes for the first issue (to do with running TensorFlow models in the background, as you had guessed):

stop models from running when you're not actively coding with Kite.
reduce the number of threads used by the models to constrain the total CPU usage.

A fix for the other issue should be available early next week. Please let us know if you see any improvement. I'll leave this issue open, and then close it next week when the other fix ships.

Closing this due to inactivity.


small improvements

fix your serverâ€™s current time output on /metrics page
gofmt
DRY up test code

thanks!


$$uuid seems not to work

Hi, I am trying to follow the sync tutorial/documentation, if I use put with taskID filled it works, but if I don't provide the taskID it gives me the error:

DataError: Failed to execute 'put' on 'IDBObjectStore': Evaluating the object store's key path did not yield a value.

By using $$, shouldn't be automatically generated a UUID ?
import Dexie from "dexie";

import "dexie-observable";
import "dexie-syncable";

const db = new Dexie("taskroulette");

db.version(1).stores({
	tasks: "$$taskID,createdAt,updatedAt,description,tags,deleted,done",
	// sprints: "createdAt,dueDate,tags",
	//	todo: "taskID,filterTags"
});

async function test() {
	try {

		const id = await db.tasks.put({
			createdAt: Date.now(),
			updatedAt: new Date().toISOString(),
			description: "TODO!!",
			tags: ["1", "2"],
			done: 0
		});

		console.log("Got id " + id);

		const tasks = await db.tasks.where("done").equals(0).toArray();

		console.log(tasks);
	}
	catch (e) {
		console.log(e.toString());
	}

}

test();

export default db;

Thanks.

I noticed this issues too. For now I am using Dexie.Observable.createUUID() as suggested also here: https://www.bountysource.com/issues/60515733-transactioninactiveerror-if-uuid-is-used-in-angular
Tested with<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Still not working?

I've got the same error.
When you put to the db here, you dont provide a taskId and it shouldnt (I guess) since you want it automatically filled. but you provide a keyPath: tasks: "$$taskID,... which - if I understand the docs correctly - would mean that taskID must be present in the object.
I tried with '$$,...' but this unfortunately gives me the same error.
Please correct me if I am wrong.


Import std module

These changes optionally all the library to be built and consumed using import std; rather than classic old style #include <meow>. This currently works for Visual Studio and Clang using libc++. It required the latest CMake 3.30 and Clang versions.
This is not an attempt to create a module from the library, which would be nice to have, only to use the std module.
In CMake everything is guarded by a STRONG_TYPE_IMPORT_STD_LIBRARY variable. In code stuff is guarded by a macro of the same name. By default STRONG_TYPE_IMPORT_STD_LIBRARY is OFF is CMake so by default everything works exactly as now.
Many of the code changes are of the form
#if defined(STRONG_TYPE_IMPORT_STD_LIBRARY)
    import std;
#else
    #include <type_traits>
    #include <initializer_list>
    #include <utility>
#endif

Note both MSVC and clang can do an old style #include before an import std; but both give error when you do the reverse. For this reason in the tests the #include <catch2.hpp> had to be moved to be the first include as it does unguarded #include <meow>.
So as as user I can now #include strong_type.hpp with STRONG_TYPE_IMPORT_STD_LIBRARY defined and use import std;
One advantage of doing this is that the std module doesn't leak macros and global namespace things like uint32_t so you now know that you don't rely on things like that. I did fix a couple of cases where the library used ptrdiff_t from the global namespace.
Note MSVC does have a bug where it does leak stuff into the GMF, see https://github.com/microsoft/STL/issues/1694 for details.
Anyway hope this is of interest, let me know if you want changes or documentation.

Oh i did change on other thing. You had
option(STRONG_TYPE_UNIT_TEST off "Decide whether to build unit tests or not")

I believe that the ordering is wrong here, see https://cmake.org/cmake/help/latest/command/option.html#option so I changed it to
option(STRONG_TYPE_UNIT_TEST "Decide whether to build unit tests or not" OFF)

Note the default is OFF so you could omit that but I like it being explicit

Wow. Thanks. I've been wanting to do this for some time.
It's a large change, so it'll take a bit of time for me to go through all the details. However, there are two issues that I see at a short glance:
No change to the CI build scripts, so none of your changes are tested. Please fix that.
You changed the include order in the tests so that Catch2 is included before the feature being tested. That is, IMO, totally wrong. Don't do that. You always want to include the functionality being tested first, to ensure you don't rely on any accidentally included dependency.
A related, but different thing. I want to make this library itself a module, but I lack the knowledge and time to do so. Do you have the time (you appear to have the knowledge)? It'd be awesome if you could assist with that. (as a separate PR).

1) Change to CI build scripts
This was mainly because I have zero experience in these sort of scripts. Is this a separate appveyor.yml file or should it be added to the current one? I'm also not sure how to test them, can I run them on my branch?
I can have a go if you like but it might need someone who knows what there doing to review it.
2) Reorder of <catch2.h>
I completely agree with you that this is the wrong thing to do. However it was necessary to get the tests to build. Catch2 does not have a similar mechanism to build optionally with import std;. I did try, see https://github.com/catchorg/Catch2/issues/2575, but they rejected it because there view is that random mixtures of import and #include should be fine.
Therefore is you include it second you get the sequence
import std;
#include <string>

This fails on both MSVC and clang. Note that the reverse works on both. According to the standard this should work.
I have seen comments from MSVC that this ordering will be very hard to get to work, in fact they didn't seem to even have a good idea of how to do it.I suspect clang has run into the same issue. I believe this is because in the ordering
#include <string>
import std;

The machinery that does the import can check to see if there is a definition already present and ignore it if there is one.
The other ordering is just the preprocessor, which is dumb, and things clash with stuff already bought in by the import.
Note I completely disagree with allowing random mixtures of import and #include. I think it was the worst decision in the whole standardization of modules. I think it was pushed in by various mega corps who think it will make it easier to migrate to modules. Personally I think it will do the opposite and slow thing down, for instance the rejection of my PR to catch2.
Anyway the upshot is that I could do some macro thing like
#if defined(STRONG_TYPE_IMPORT_STD_LIBRARY)
#include "catch2.hpp"
#endif
#include <strong_type/affine_point.hpp>
#if !defined(STRONG_TYPE_IMPORT_STD_LIBRARY)
#include "catch2.hpp"
#endif

Although I think this is ugly
Another possibility is to have file equivalent to empty.cpp to check the idempotence of the headers so affine_point.cpp would be
#include <strong_type/affine_point.hpp>

So there would be one of these cpp files per header.
Note these cpp files could be in the test directory of the source directory. In the source directory they would only get built if tests were being build.
3) Making a module of strong_type
I have done much less of this. In fact a year or so ago I immediately ran into the issue of including other libraries hence my quest to "fix" them. However I'm willing to have a go. I had a couple of comments/questions
a) There is no such thing as a "interface" or header only module I'm assuming you are OK with this
b) I assume you are fine with only one module
c) I would follow a method similar to STL, see https://github.com/microsoft/STL/blob/main/stl/modules/std.ixx
One sad thing is that I believe MSVC, Clang and GCC all use different file extensions :-(
I have only created modules on MSVC but I am assuming the magic of CMake hides all these things for me. I would probably try to get MSVC work first mainly because I'm mostly a Visual Studio developer.
BTW are you going to CPPCon this year, in a week in fact, if so hope to see you there.

1 & 2. Hmm. I see. I'll try to do something. A separate .cpp file for each header is a bit of an abomination, but maybe it's OK to have as something that is only used by CI.

No. I've limited myself to "only" four conferences this year, and none of them are in North America. Heading for NDC TechTown in Norway next week, and then a one day conference "C++ under the Sea" in the Netherlands in October.

Note there is an ugly way to work around the ordering issue of the catch header. The problem is that no compiler currently supports
import std;
#include <vector>

and they probably won't for a while. The work arounds I know of are

Every standard library header file has macro guards. So create a header file that defines all these macro guards, that way when you #include <vector> the preprocessor macros out all the contents. I attached my version of this which is how I've been using strong_type up to now.
MacroGuards.txt
Create an empty file for every standard library header, so an empty <vector> and change you build so these are included before the real ones.

Both of these mechanisms were discussed here https://github.com/microsoft/STL/issues/3195
Note MS are still doing a lot of work on modules in fact https://github.com/microsoft/STL/pull/4375 was got me looking at strong_type again. It removed another bunch of ugliness

Hmm, odd. I handled this manually because I wanted to ensure the CI was running with support for "import std;" before merging, and apparently github lost track of where the change came from. Anyway, the support just landed in main. Huge thank you for your contribution, and apologies for taking so long.


I have not found the error code

I was desperately look for all windows update error but found most of them
But missing error code 0x80070020

@rabbanisyed Can you please tell us to which article(s) your question applies? This will help us route this issue to the correct writer/team.

@rabbanisyed We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if you see an improvement is required in the specific area of this documentation. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Update google-cloud-pubsub to 1.114.1

Updates com.google.cloud:google-cloud-pubsub from 1.107.0 to 1.114.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-pubsub" } ]

labels: library-update, semver-minor

Superseded by #256.


Accessibility issues with HTML publishing of "Backlinks" and "Children"

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[x] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
The headings for "Backlinks" and "Children" in the HTML output are rendered as "<strong>", but for accessibility reasons, they should use headings. This is important for things like screen readers, where the headings are used for quick navigation on a page.
To Reproduce
Steps to reproduce the behavior:

Go to any documentation page that have backlinks and/or children.

Expected behavior
There should be headings instead of plain <strong>.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information)

OS: Windows 11
Browser: Chrome
Versions (all that apply to bug):

Dendron Extension: 0.106.0
VS Code version: 1.69.2
Dendron CLI: 0.106.0

Additional context
Add any other context about the problem here.
Dendron Log file
Please attach the output of > Dendron:Dev: Open Logs here
dendron.log

Thank you for the report. We'll keep track of this and let you know when this gets resolved.

This was a breaking change introduced in Dendron v0.76: https://wiki.dendron.so/notes/MQpi87qLnzKK5iK3FlxUp/#breaking-changes

Do we have a papertrail to the source of that change made in v0.76. It seems the idea behind that change was to remove it from the toc section. So maybe this issue is about replacing back to headings but not getting shown inside the toc section.

If headings aren't a good fit, then you might use ARIA's "role=heading". See: https://www.w3.org/TR/WCAG20-TECHS/ARIA12.html


A few small fixes

closes #1838
closes #1824
closes #1841
Each issue is more or less contained in it's own commit, to help with reviewing. No huge changes, just a few little adjustments. This also updates our webpack config to use dart sass (and updates sass-loader and node-sass to not error on macOS 11)

Maybe just fix that one test :)


Announcing Template 10 Template Pack v1.19

Can you believe it, I finally updated the thing.

HI Jerry, when will the template pack be available for VS 2017 RC?

Is it possible to get a 2017 RC build while we are waiting for RTM?


chore: convert active Preview features list into a table

This PR improves the aesthetic presentation of the active Preview features. We intend to add an external link icon for external links in the near future. Some spacing between the external links, in list of active Preview features, helps in making it less overwhelming (with the external link + icons)
Related PR:https://github.com/prisma/docs/pull/4611
Current:

New:

I've updated "preview" to "Preview" on that page.


Added Azure Log Analytics scaler documentation

Signed-off-by: Sergiy Poplavskyi<EMAIL_ADDRESS>Relates to https://github.com/kedacore/keda/issues/1061

LGTM, but want your input on some topics @zroubalik @ahmelsayed .

@spoplavskiy feel free to add a note to https://github.com/kedacore/keda-docs/blob/master/content/blog/keda-2.0-beta.md.draft with your new scaler under - **Making scaling more powerful**. Thanks!

@spoplavskiy feel free to add a note to https://github.com/kedacore/keda-docs/blob/master/content/blog/keda-2.0-beta.md.draft#L15 with your new scaler please? Thanks!

@tomkerkhove , thanks for pointing. Added in last commit.

@spoplavskiy one last thing, DCO please :)

And this great suggestion: https://github.com/kedacore/keda-docs/pull/244/files#r486117830

And this great suggestion: https://github.com/kedacore/keda-docs/pull/244/files#r486117830

Changed query to multiline in last commit

@tomkerkhove, @zroubalik It looks like command, suggested by DCO tool to sign-off all my commits produced unexpected result :) It it now hard to revert and find in git log all my commits, as many of them was just applying inline suggections.
What if we finish reviewing this PR, and I will close this and open a new one by forking last version and applying my changes in single signed commit? Is that OK?

That's certainly ok for me @spoplavskiy, sorry for only noticing now!

That's certainly ok for me @spoplavskiy, sorry for only noticing now!

@tomkerkhove , I have created a new PR: https://github.com/kedacore/keda-docs/pull/250


re-export this public struct for documentation purposes.

https://github.com/rfdzan/jippigy/blob/45b156ef3109325ced1f20e5a0e7c32d88073002/src/bulk.rs#L207-L209
Re-export this with the intention of not letting users use it directly.
don't forget documentations.

closed by #49


add development workflow to CONTRIBUTING.md

Adds information on the nuts and bolts of how to develop on Houston utilizing docker-compose.
Also, I know my markdown is lousy, feel free to be mean!

@karenc @hwindsor I think I've made all the changes you requested.

/rebase


United Kingdom: optimizations

Coverage remained the same at 100.0% when pulling 61ac15b15823e23ce882f7f41526044fac77d018 on KJhellico:optim-united-kingdom into 4b83875321cff0778b58a9eada462d94ce46b3cd on dr-prodigy:beta.

Thank you 👍


Add tribal affiliation to patient data

We should add a tribal affiliation field to capture if someone is affiliated with a tribe. This is an optional field.
There are over 500 tribes, and the data hub has already added support for them and a mapping.

[ ] Design where to add it
[ ] Add it to SimpleReport
[ ] Send it to the data hub

Will this question be exposed for all organizations, or will it be state-by-state?
Also, when we say that Data Hub has a mapping, does that imply we have to pick from a 500-element list of allowed values?

Given that people can move around, this should be shown in all states (and definitely be optional.)
And yeah, that is what is implied by data hub has a mapping. @hmyers-cms had an idea about at USWD components that is a searchable dropdown.

We have a design (below) but are checking with Data Hub to see if they can support multiple tribal affiliations. If not, we might need to remove "+add another" until they can.

We have a design (below) but are checking with Data Hub to see if they can support multiple tribal affiliations. If not, we might need to remove "+add another" until they can.

Blocked for the time being while we determine how states would like us to pass tribal information to them when a person belongs to more than one tribe. We need to know whether state data intake systems care, and if sending multiple tribal affiliation names would "break" the systems. Data hub will do this research and let us know. See this slack thread for reference.

Blocked for the time being while we determine how states would like us to pass tribal information to them when a person belongs to more than one tribe. We need to know whether state data intake systems care, and if sending multiple tribal affiliation names would "break" the systems. Data hub will do this research and let us know. See this slack thread for reference.

Splitting this into 2 tickets while we wait for data hub research findings. This ticket will allow user to select one tribal affiliation. New ticket #770 will allow user to add an additional tribal affiliation (pending data hub research findings).

There's probably a meeting/handshake that needs to happen with @jimduff-usds on how the tribal affiliation is sent to data hub.

@nullflux I grabbed #1196, which will also need a combo box. Are you making a custom combo box component?

Yes @nickscialli-usds that was exactly my plan! I can have the component tested & wrapped today, and can split it out into a separate PR. Will ping you off-thread to coordinate

Usually we no longer have to synchronize exactly on these kinds of changes -- generally you can just add a new field/column to your data, and we'll ignore it, until we make the corresponding schema change on our side.


Control the number of rest API calls with securesocial

Is there a way to control the number of rest API calls with securesocial per memeber?
For example, I need to assign a user with 500 times of one specific API call.
How can i do that with securesocial?

There's not support for this in the module. You could combine a SecuredAction with a rate limiting one.


css not showing

hello,
thanks for setting up this theme. I am new to jekyll and github and pretty much coding in general!
I forked your theme, and tried to tweak it to setup a blog for myself, but I don't know why the CSS doesn't show up: http://d.pr/i/1kvV5/37q9O12B
What am i missing?
i read somewhere that it's probably something wrong with the config.yml file, so I've screenshot that as well. http://d.pr/i/iuKP/2Ru0CL1j
Thanks
Sam

I am having the same problem. I just downloaded the zip and fired up index.html. CSS doesn't show.


Add fixes and improvements from Micropython

An earlier version of this Wiznet driver has been in use in micropython (primarily on the stm32 port) since 2014, with a few additions being made to it since.
As part of my work in https://github.com/micropython/micropython/pull/8540 I'm updating the driver to use the current version from here, preferably as a submodule to make future updates easier to maintain. For this to happen smoothly though, I'm hoping to submit a clean version of the micropython patches here.
There are a couple of commits here that as-is will present no change, but instead allow third part projects like micropython to integrate the library more smoothly.
A couple of other commits add features / bug fixes found previously. Hopefully the commit descriptions provide enough context for these changes.

Sorry. We can't merge micropython related code here.
This repository is a library for C language.
For that code, it seems that you need to create a separate library for MicroPython.

Hi @irinakim12 this PR does not include any micropython specific code, it was carefully cleaned up to only include C changes that should be relevant to any users of this library. I listed micropython in the title simply because these were commits / changes originally done by other's under the micropython project.

Hi @irinakim12 I'm from the MicroPython project. We're currently using @andrewleech's fork of this repo but would prefer to point our submodule to the official repo instead.
As Andrew said, this PR doesn't include anything MicroPython-specific, rather it's just general improvements that make it easy for a project (such as MicroPython) to embed this library. (In particular, avoiding name collisions with other functions).

@andrewleech  Could I ask you for an answer ? :)

Sure?

Sure, what's the question?

I write the review about your Pull request last week.
I ask you for an answer and code fix for this.

I write the review about your Pull request last week. I ask you for an answer and code fix for this.

Sorry I can't see any review comments on this PR?
Do you mean a discussion on one/some of the "Change MICROPY_PY_LWIP setting" PR's in micropython?

I write the review about your Pull request last week. I ask you for an answer and code fix for this.

Sorry I can't see any review comments on this PR? Do you mean a discussion on one/some of the "Change MICROPY_PY_LWIP setting" PR's in micropython?

sorry. Review of this PR has been put on hold. Now you can check out my comments.


[Housekeeping] Formatting all code with black

Hi all,
Cosimo and me would like to format all code with https://github.com/psf/black to unify style and automate the boring tasks of fitting your code into the surrounding style. This would also include a CI lint check to make sure the black style is adhered to for any incoming code.
Two known difficulties:

Existing PRs may need to be rebased on top of the newly formatted code.
Making git blame work as before requires an extra step: https://github.com/psf/black#migrating-your-code-style-without-ruining-git-blame

Thoughts?

Making git blame work as before requires an extra step: https://github.com/psf/black#migrating-your-code-style-without-ruining-git-blame

There I read: "The one caveat is that GitHub and GitLab do not yet support ignoring revisions using their native UI of blame"
Which is literally the only way I ever use blame, so I'm not super excited at this moment.

even in github blame UI one can always click through past commits when exploring the git blame history, so I don't think this is such a problem. We have a lot of noisy commits where we do "minor" (whatever that means) or apply formatting changes

Ok, fair enough. And as a side effect we'll lose all tabs, yes? That'd be worth a party.

My philosophy on this is that the sooner code styling gets normalized the sooner you get to the end of the long tail of disruption caused.

Existing PR's should be easy to fix one of two ways depending on complexity:
a) If they can be automatically rebased on master now, they can be rebased automatically after the change by running the reformatter on each of the commits in the PR first, then rebasing on the new master.
b) If the PR cannot currently be rebased anyway but it could be merged (for example git rerere artifacts have already been developed for it) then merge the old master pre-rewite into the PR branch to resolve conflicts, then run the formatter in the branch, merge again from the new master, then squash the two merges and format commit to get a clean merge from the new format.

Is web UI blame usage frequent enough that the extra click/level of blame history would really be a bother?

Sgtm.

One thing I really hate about code formatters, is that they sometimes make more noise than reducing it. Contributor A sends a PR with lots of commits, CI fails because of code format, contributors A runs black after their last commit (because rebasing and editing every commit to reformat it is likely to cause merge conflicts and will require a lot of effort) and push the results, CI happy, reviewers happy and we now have an unnecessary noise commit that wouldn’t have been there.

(because rebasing and editing every commit to reformat it is likely to cause merge conflicts and will require a lot of effort)

Once the master branch is formatted automatically requiring it of PR's will not make merge conflicts more likely. It will require a little bit more effort, but it's also possible to put together a one-liner that fixes it automatically (by applying a filter to a rebase that works backwards through each commit applying the formatting until the branch point). That can even be made into a CI job that fixes PRs, although that tends to be finicky and intrusive. Sure most people don't have the knowledge to do that kind of rebase off the top of their head, but pointing them to a one-liner that fixes their PR for when they couldn't be bothered to follow the guidelines in the first place isn't too much to ask.

Sure, but that is not what I see in some other projects, hence why I’m raising this point.

Mh. Yes, that may happen, but I'm not particularly worried. As Cosimo pointed out, fT's commit log is pretty noisy already. It is also possible to run black in tox, so people remembering to do that may not hit the problem :)

As far as I know, none of the projects I contribute to that require to run tox -e lint document it.

Run black in pre-commit hook :D.
Do we realistically see this happening? Maybe we do if we do a concerted effort to close all outstanding PRs first.

I can see it happening, I'd just need to do it and hook up formatting checker :)
I mean, PRs will keep coming forever I suppose and there are very old ones.

I mean, PRs will keep coming forever I suppose and there are very old ones.

I'm going through the old ones and clearing them up is also a very important housekeeping task. They're mostly stale already :(.

I'm going through the old ones and clearing them up is also a very important housekeeping task.

thanks for this!

GitHub can (now?) use a file listing commits to hide in the blame view: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view


replace fetchWithRetries with fetch

fetchWithRetries is not available in react-native. By replacing fetchWithRetries with fetch it works.

I haven't seen any issues with fetchWithRetries at all.


ex16.38

Exercise 16.38:
When we call make_shared (§ 12.1.1, p. 451), we have to provide an
explicit template argument. Explain why that argument is needed and
how it is used.
Question or Bug
I think the answer is wrong. Look the following code
template<typename T> void * fun(T x)
{
    T* p = new T(x) ;
    return p ;
}
fun(11) ;
fun(string("123")) ;

fun(T) can be called without explicit template argument.
From cppreference, the make_shared is decalred as
template< class T, class... Args >
shared_ptr<T> make_shared( Args&&... args );

So I think the answer should be compiler couldn't deduce template parameter "T" from the parameter  provided. As a result of failed deduction, make_shared has no possibility to to determine how big the size it should allocate, but compile process has been interrupted before that.

Fixed by https://github.com/pezy/CppPrimer/commit/062d4c54545280b5313ec8f83d3ed9bec7c4502b#diff-062f693961b4160c20cff7761aaf2865R344


Latest DIGITS Master cannot find Caffe .....

I just grabbed a download of latest digit master. I tried running it on a system that have a fully functional version of digits I download about 2015-04-01. I got and unexpected error and did not seem want to correct itself even after I typed in SYS.  This "/usr/local/caffe/bin" is the correct location for caffe..
~/DIGITS-master> ./digits-devserver

|   _ / | | / |
| |) | | ( || |  | | _
|/_|| || |__/
Invalid config option for "caffe_root": ldd: ./caffe: No such file or directory
Welcome to the DIGITS config module.
Guessed "/usr/local/caffe/bin" from CAFFE_HOME
ERROR: Does not contain the caffe binary
Where is caffe installed?
(enter "SYS" if installed system-wide)
[default is SYS]
(q to quit) >>> SYS
ERROR: ldd: ./caffe: No such file or directory
(q to quit) >>>
@lukeyeager : My complements on your code... very clean and easy to understand... it show your experience in being a clear communicator :)
Hopefully I can be helpful....

Oh, are you trying to install caffe in weird places? DIGITS is pretty rigid about the caffe installation paths right now. It's looking for the binary at $CAFFE_HOME/**build/tools/**caffe, not $CAFFE_HOME/caffe. You've got to satisfy this validation function.
So, you probably want to go down this path:

Add /usr/local/caffe/bin to your PATH
Add /usr/local/caffe/python (or wherever the caffe python module is) to your PYTHONPATH
Set the caffe_root in DIGITS to "SYS"

I don't think this is a closed issue.
I started from scratch in a brand new environment and followed the instruction exactly found at this URL https://github.com/NVIDIA/DIGITS and still getting the same problem.
In my $HOME directory I have caffe and digits
export CAFFE_HOME=${HOME}/caffe
cd digits
:~> cd digits
:~/digits> ./digits-devserver

|   _ / | | / |
| |) | | ( || |  | | _
|/_|| || |__/
Welcome to the DIGITS config module.
Guessed "/home/XMan/caffe" from CAFFE_HOME
ERROR: Does not contain the caffe binary
Where is caffe installed?
(enter "SYS" if installed system-wide)
[default is SYS]
(q to quit) >>> q

Oh, sorry. Then what did you mean by this:

This "/usr/local/caffe/bin" is the correct location for caffe..

Did you install caffe like this?
% cd $HOME
% git clone --branch v0.11.0 https://github.com/NVIDIA/caffe.git

Cloning caffe there and building it there should give you the caffe binary at
$HOME/caffe/build/tools/caffe

Is it there?

ON my machine
$HOME/caffe/build/tools/caffe
/home/XMan/caffe/build/tools/caffe: error while loading shared libraries: libcaffe.so: cannot open shared object file: No such file or directory
So the binary is there

As you can see even after I set the LD_LIBRARY_PATH and the PATH directly to the binary
I am still having issues running the latest master ---do you have any recommendation on how fix this....
XMan@earth:~> export LD_LIBRARY_PATH=/home/XMan/caffe/build/lib
XMan@earth:~> $HOME/caffe/build/tools/caffe
caffe: command line brew
usage: caffe
commands:
train           train or finetune a model
test            score a model
device_query    show GPU diagnostic information
time            benchmark model execution time
Flags from /home/XMan/Documents/caffe/tools/caffe.cpp:
-gpu (Run in GPU mode on given device ID.) type: int32 default: -1
-iterations (The number of iterations to run.) type: int32 default: 50
-model (The model definition protocol buffer text file..) type: string
default: ""
-snapshot (Optional; the snapshot solver state to resume training.)
type: string default: ""
-solver (The solver definition protocol buffer text file.) type: string
default: ""
-weights (Optional; the pretrained weights to initialize finetuning. Cannot
be set simultaneously with snapshot.) type: string default: ""
XMan@earth:~> cd digits
XMan@earth:~/digits> ./digits-devserver

|   _ / | | / |
| |) | | ( || |  | | _
|/_|| || |__/
Welcome to the DIGITS config module.
Guessed "/home/XMan/caffe" from CAFFE_HOME
ERROR: Does not contain the caffe binary
Where is caffe installed?
(enter "SYS" if installed system-wide)
[default is SYS]
(q to quit) >>> SYS
ERROR: caffe binary not found
(q to quit) >>> q
XMan@earth:~/digits> export PATH=/home/XMan/caffe/build/tools/
caffe                     compute_image_mean        extract_features          net_speed_benchmark       upgrade_net_proto_binary
CMakeFiles/               convert_imageset          finetune_net              test_net                  upgrade_net_proto_text
cmake_install.cmake       device_query              Makefile                  train_net
XMan@earth:~/digits> export PATH=/home/XMan/caffe/build/tools:$PATH
XMan@earth:~/digits> ./digits-devserver

|   _ / | | / |
| |) | | ( || |  | | _
|/_|| || |__/
Welcome to the DIGITS config module.
Guessed "/home/XMan/caffe" from CAFFE_HOME
ERROR: Does not contain the caffe binary
Where is caffe installed?
(enter "SYS" if installed system-wide)
[default is SYS]
(q to quit) >>> SYS
ERROR: ldd: ./caffe: No such file or directory
(q to quit) >>> q
XMan@earth:~/digits> ca
caffe               caller              cameratopam         case                catchsegv
cal                 callgrind_annotate  cancel              caspol              catman
call-browser        callgrind_control   captoinfo           cat
XMan@earth:~/digits> ca
caffe               caller              cameratopam         case                catchsegv
cal                 callgrind_annotate  cancel              caspol              catman
call-browser        callgrind_control   captoinfo           cat
XMan@earth:~/digits> caffe
caffe: command line brew
usage: caffe
commands:
train           train or finetune a model
test            score a model
device_query    show GPU diagnostic information
time            benchmark model execution time
Flags from /home/XMan/Documents/caffe/tools/caffe.cpp:
-gpu (Run in GPU mode on given device ID.) type: int32 default: -1
-iterations (The number of iterations to run.) type: int32 default: 50
-model (The model definition protocol buffer text file..) type: string
default: ""
-snapshot (Optional; the snapshot solver state to resume training.)
type: string default: ""
-solver (The solver definition protocol buffer text file.) type: string
default: ""
-weights (Optional; the pretrained weights to initialize finetuning. Cannot
be set simultaneously with snapshot.) type: string default: ""
XMan@earth:~/digits> whereis caffe
caffe: /home/XMan/caffe/build/tools/caffe

Sorry, this is devolving a bit from the intended purpose of a GitHub issue. Would you mind reposting in the digits-users google group with a clear, concise explanation of your issue?
https://groups.google.com/d/forum/digits-users
(We'll get to the bottom of  this, I'm just trying to keep this issue list clean and related to bugs or feature requests)


Built-in list methods

Already implemented

append
extend
length
remove
slice

To do:

find
find_last
copy
sorted
sort_in_place
reversed
reverse_in_place


CSS: position should work within <mr-container>

this would require:

origin at top left
conversion between top left and center coordinate systems
conversion between pixel values and THREE.js unit system.
?

Resolved in latest PR.