Task abbreviation behavior changes based on JDK used

Expected Behavior
Task abbreviation behavior should not depend on JDK version. It should either always fail or always select the same task.
Current Behavior
When Gradle runs on Java 8-14, task is selected unambiguously.
When Gradle runes on Java 15+, the build fails due to an ambiguous task selection.
Steps to Reproduce
Given this build.gradle:
task publishReleaseBundlePublicationToTempPublishRepository
task publishReleaseObfuscatedBundlePublicationToTempPublishRepository

Running gradle publishReleaseBundle will succeed (and select publishReleaseBundlePublicationToTempPublishRepository) when Gradle runs with Java 8-14.
On Java 15+, the build will fail with:
Task 'publishReleaseBundle' is ambiguous in root project 'task-abbreviation'. Candidates are: 'publishReleaseBundlePublicationToTempPublishRepository', 'publishReleaseObfuscatedBundlePublicationToTempPublishRepository'.

I suspect this was caused by a change in the JDK.  Our NameMatcher uses the case-insensitive regex mode when doing task selection.
If you change the name of publishReleaseObfuscatedBundlePublicationToTempPublishRepository to publishReleaseobfuscatedBundlePublicationToTempPublishRepository (lowercase 'O'), you can get this to fail on all versions of Java.
Your Environment
This happens on all supported hosts.

camelCasePattern.pattern() is \Qpublish\E[\p{javaLowerCase}\p{Digit}]*\QRelease\E[\p{javaLowerCase}\p{Digit}]*\QBundle\E[\p{javaLowerCase}\p{Digit}]*\Q\E
Pattern normalisedCamelCasePattern = Pattern.compile(camelCasePattern.pattern(), Pattern.CASE_INSENSITIVE);
for match value publishReleaseObfuscatedBundlePublicationToTempPublishRepository
jdk 11, the second [\p{javaLowerCase}\p{Digit}]* does not match the value Obfuscated, because the pattern ignore the flag Pattern.CASE_INSENSITIVE.
jdk 17, the second [\p{javaLowerCase}\p{Digit}]* matches the value of Obfuscated, which I think is correct

https://bugs.openjdk.org/browse/JDK-8305733?jql=text ~ "Pattern.CASE_INSENSITIVE"

@ljacomet Can you review my PR？ I generated a pattern that ignore first letter case to replace Pattern.CASE_INSENSITIVE.

Thanks for your PR, will take a look. Hopefully this can make it into Gradle 8.3

Do we have java version access in core module ? I am not able to find one. If we don't, we might have to stick to explicit character selection in regex in all java versions as in above PR.


localize font awesome

Deploy preview for recalc ready!
✅ Preview
https://recalc-g49b0f7tt-tervay.vercel.app
Built with commit 45be770720849f6af5f41146a512ae93a8eb965b.
This pull request is being automatically deployed with vercel-action


Fix clippy::implicit_clone

Enabled clippy::implicit_clone checkes and fixed all warnings

Thanks!
for other curious like me
https://rust-lang.github.io/rust-clippy/master/#/implicit_clone

Oh, sorry!
Will add the link next time :)

oh, don't be sorry :)

Thanks for your PR!


get ec.message() variable from another class

Hello,
I follow the http over ssh examples.
But, for my app, I have to get the value returned by the fail function.
So I change a little the code, I add fail into request class (public), and a std::string variable.
The std string get the error message.
When I call the string into another class:
request* req;
printf(req->mystringvalue);

, there are no values.
So can I get the error message from another class ?
Thanks !

I'm going to need a little more information than that, do you have an example program which I can run that exhibits the behavior you are describing?

Yes sorry .
request cpp
void request::fail(boost::system::error_code ec, char const* what)
{
    std::cerr << what << ": " << ec.message() << "\n";
    std::cout<<ec.message()<<std::endl;
    respond = ec.message() ;
}

void request::start_request(char const* host, char const* port, char const* target, int version, std::tring method, std::string body)
{
    boost::asio::io_context ioc;
    ssl::context ctx{ssl::context::sslv23_client};
    std::make_shared<request>(ioc, ctx)->run(host, port, target, version, method, body);
    ioc.run();
}

request .h
public:
std::string respond;
void fail(boost::system::error_code ec, char const* what);

my class which call respond
void connection::server_connect(std::tring host, std::string port, std::string target, int version, std::string method, std::string body)
{
http->start_request(host, port, target, version, method, body);
}
std::string connection::getHttpResponseBody()
{
std::cout<<"test : "<respond<<std::endl;
return (http->respond);
}

.h

private:
request *http;

If I initialize my string var into constructor, i can get his values.
But no ec.message() values

Are you linking dynamically to Boost.System? Perhaps this is a problem with a mismatch between the shared library version and the header file version. Try linking everything statically.


Local variable shadowing import from outer scope

Describe the bug
In case something is being renamed by a codemodder in the current file, and if a local variable shadows this name from the outer scope, the shadowed variable gets renamed as well.
The code to change should avoid these kind of shadowing, but ideally we should not be tricked by it.
To Reproduce
from django.conf.urls import url
from django.urls import reverse_lazy

class MyModelAdmin(admin.ModelAdmin):
    def get_urls(self):
        return [
            url(r'^some-route/$', some_view, name=self.store_value_view_name),
        ] + super().get_urls()

    def get_result_url(self):
        url = reverse_lazy('some-url-name')
        return url

When running URLTransformer on this code, the variable url inside get_result_url gets incorrectly renamed to re_path.
Additional context
Add any other context about the problem here.

More problematic, the file also conatined a form class with an attribute called url:
class MyFilter(BaseFilter):
    url = reverse_lazy('some-url-name')

The BaseFilter class is expecting this url attribute to be set in its subclasses, this name isn't shadowing the import.

More problematic, the file also conatined a form class with an attribute called url:
class MyFilter(BaseFilter):
    url = reverse_lazy('some-url-name')

The BaseFilter class is expecting this url attribute to be set in its subclasses, this name isn't shadowing the import.


Fixed typos

Description

Fixed some typos I found.
Checklist

[X] Read Contribution guidelines
[ ] Added tests for new features or bugfixes

Related Issue

Hey @NinjaCoderDev, re-spacing sentences or capitalizing github org names are unnecessary changes (and even disruptive like the spacing changes). I will not be accepting this pull request. If you'd like to contribute to this project, please look through the open issues list and pick one of the open issues to try your hand at a contribution.


Find packages is now case-insensitive #93

I am F# virgin so I'm not sure if the code is "optimal", but it seems to work. I've created a unit test to poke our private nuget server and with my fix it does return all packages that contain the words, case insensitive.

The changes look the same like in the other pr?

Sorry, I messed up the PR (I don't do that often so I wasn't sure how to do it). I'll create another branch and do another PR on that branch with only the good changes.
Originally I only had the right change for the case-sensitive, but since I did the PR on my master branch and I changed other stuff since then I guess those changes are also included in the PR even if they are done after the original PR... ?

Yes. Always use a new branch for PRs. You should never use master (that
breaks things when you have more than one).
On Jan 18, 2016 21:04, "dcorriveau-omniscient"<EMAIL_ADDRESS>wrote:

Sorry, I messed up the PR (I don't do that often so I wasn't sure how to
do it). I'll create another branch and do another PR on that branch with
only the good changes.
Originally I only had the right change for the case-sensitive, but since I
did the PR on my master branch and I changed other stuff since then I guess
those changes are also included in the PR even if they are done after the
original PR... ?
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/pull/1407#issuecomment-172639083.

And thanks for contributing!
On Jan 18, 2016 21:05<EMAIL_ADDRESS>wrote:
Yes. Always use a new branch for PRs. You should never use master (that
breaks things when you have more than one).
On Jan 18, 2016 21:04, "dcorriveau-omniscient"<EMAIL_ADDRESS>wrote:
Sorry, I messed up the PR (I don't do that often so I wasn't sure how to do
it). I'll create another branch and do another PR on that branch with only
the good changes.
Originally I only had the right change for the case-sensitive, but since I
did the PR on my master branch and I changed other stuff since then I guess
those changes are also included in the PR even if they are done after the
original PR... ?
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/pull/1407#issuecomment-172639083.

Looks like you were able to pick partial commits anyway ? So I won't have to make another pull request using another branch (for this time) ?

I am not sure what happened. I merged the other pr.
Please send new pr with the actual fix


[IDEA]: Implement grid based statistics

Description

Perception R&D proposal
Implement grid-based statistics as a database based (bottom-up) approach for use-case fulfillment assessment.
The grid-based perception statistics is called "perception field analysis".
Purpose
Expand current perception evaluation to process statistics on grid.
Possible approaches
Use existing DataFrame parser. Extend perception_nanlyzer3d.py for grid statistics
Definition of done
Process a sample dataset and create plots by this analysis approach.

@technolojin Thanks for sharing your idea! I created PR related to this topic that an update to plot the number of objects as heatmap. https://github.com/tier4/autoware_perception_evaluation/pull/104
Please any comments or suggestion if you have. I suppose to it's OK you add updates after merging this PR.

@ktro2828 Thank you. I missed your comment for a while.
Your implementation is as my intention. But I generalized the histogram analysis to be extended to have

various axis (not only x and y positions, distance, angles, and more)
custom intervals
statistics of detection ratio, error and uncertainty, mean and standard deviations

I would like to create a PR soon.


Create the Install file for the Equella OS Release

[ ]  Create the Installer for Equella - including any required handling for non-OS dependencies

[ ] Update the Aperero website with a link to the Install File(s)

[ ] Update the GitHub documentation with Install File Links and Info

Is this something Chris can tackle?

I would think so, but it'll be blocked until we have a working build via SBT.

@cbeach47 -- Do we now have a working SBT build?  Can we consider this one un-blocked?
In either case, I'm going to move this one to the 'publication' milestone.


Pass use_cudnn on spatial_pyramid_pooling_2d

Small fix for SPP.

Oops, I had noticed it. Thank you very much!


APIGateway returns lambda response object instead of body of the response

My code:
export function handler(event: APIGatewayEvent, context: Context) {
  try {
    const app: Application = getExpressApp();
    const server = awsServerlessExpress.createServer(app);
    return awsServerlessExpress.proxy(server, event, context);
  } catch (err) {
    context.fail('Failed to start server on lambda');
  }
}

The response if a make a request through api gateway:

But i was expecting to just get the json body:
{
  "message": "hello from backend"
}

Am i doing something wrong or is this expected behavior?

You should just be getting the body... I've never seen this happen before. This is actually going through API Gateway and not a local environment during Dev/test?
A quick aside comment: you should see performance improvements if you hoist app and server outside the handler scope.

+1

I found my problem on the response which is the wrong configuration of the API Gateway. It should be configured as Lambda Proxy Integration, otherwise all headers will be visible on the response.
I propose to close this ticket as it is a configuration issue on the API Gateway.

@emrahayanoglu  You're right. Thank you for the reply.
For anyone else hitting this issue, here are the steps to resolve it:

Glad you figured it out. Thanks for the screenshots. Check out our example which I recommend using as a baseline and modifying from there. It uses SAM a d is a one-command deploy


Fixed various typos in the readme

Fixes: #29757
In an effort to help fix the multitude of typos referenced in #29757, I have started with a few in this pr. I am glad to fix more, but didn't want to do too many in one pr, as suggested in the comments on 29757. Let me know if anything should be changed.
Signed-off-by: Brian Payne<EMAIL_ADDRESS>

@payneInTheBrian Thanks for the contribution, please take a look at other commits to properly assemble your Signed-off-by trailer.

When you have a moment, can you squash your commits into one, and add the prefix docs:  to your commit message? Thank you!

Sorry, I'm still learning how to use Github and I think I messed something
up trying to squash the commits. Should I just submit another pr?
On Mon, Feb 26, 2024 at 12:29 PM Ryan Drew @.***> wrote:

When you have a moment, can you squash your commits into one, and add the
prefix docs: to your commit message? Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/cilium/cilium/pull/30924#issuecomment-1964856512, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWOI5KU4I3GQATIRTJK3GYDYVTIB5AVCNFSM6AAAAABDV44KUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRUHA2TMNJRGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

No worries @payneInTheBrian! If opening a PR is easiest then please feel free.

Superseded by https://github.com/cilium/cilium/pull/31072


[INFINITY-3396] Add service TLD top level override

This PR accomplishes a single goal: Make it possible for a SDK user to inject a custom TLD for their service.
This supports the use case of exposing the service outside the cluster with custom DNS (a lot of custom DNS setup is required on the operator's part).
Changes:

Route SchedulerConfig to the right places
Add an accessor to SchedulerConfig for a custom service tld
Make EndpointUtils use the custom TLD
Add an integration test in HWorld for the behavior

WIP:
I accidentally left in some misc Kafka changes. Need to remove those.

I used the SchedulerConfig as I believe at present a sneaky Envvar is the correct interface for this.
If we decide to make it more "official" we'd probably move it into the yaml. Maybe.

@nickbp @elezar Review feedback incorporated


Update iree for nanobind 2

What happened?
IREE doesn't build with nanobind 2.0, released today.
Steps to reproduce your issue

Go to '...'
Click on '....'
Scroll down to '....'
See error

What component(s) does this issue relate to?
No response
Version information
No response
Additional context
No response

Yeah, we just discovered that and pinned to the prior version this morning. I took a todo to upgrade it but it isn't going to happen today. Also a long weekend starts now.

https://github.com/wjakob/nanobind/issues/597

If CI passes with the 2.0 bump, I'll go ahead and land tonight.

Note that folks are still having some issues depending on where they are sync'd to. If on a branch that does not include #17497, then downgrade via:
pip install --force-reinstall 'nanobind<2'

If after and having issues, upgrade (HEAD should work with older versions but CI doesn't test that / I only verified lightly):
pip uninstall nanobind
pip install -r runtime/bindings/python/iree/runtime/build_requirements.txt


Visual Studio and Jetbarins IDE like avtivity bar with smaller icon and vertical tool tip.

Current activity bar is too wide for low resolution screen especially when vertical split edit. A narrower activity bar like Visual Studio and Jetbrains IDE can be helpful.
Example:
Visual Studio sidebar toggle (Icons come form Visual Studio Iconizer)

Jetbrains IDE:

Marking this as duplicate of https://github.com/microsoft/vscode/issues/128376 please upvote that issue


Call Script("JavaScript") as an Action in a Button

I did not see a way to do this?
I wanted to to call a JavaScript using the Script element like so...
First I define a simple JavaScript AJAX function.
        Script("function loadDoc() {
                        const xhttp = new XMLHttpRequest();
                        xhttp.onload = function() {
                           document.getElementById("demo").innerHTML = this.responseText;
                         }
                        xhttp.open("GET", "ajax_info.txt", true);
                        xhttp.send();"
         }

Then try to call the JavaScript AJAX function using an Ignite Button.
        Text {
            Button("Call") {
                Script("loadDoc()")  // I get an error... Argument type 'Script' does not conform to expected type 'Action'
            }
                .role(.default)

Yes, that code won't do what you expect. Right now this could be done with a CustomAction – something like `CustomAction(code: "loadDoc()") is likely to work. It's not a particularly great name for it, though!


Technical Committee notes from 2021.04.30 meeting

As drafted by O. Coleman and J. Stine

Reviewed the minutes from the 4/30/2021 Technical Committee meeting.  No additions or corrections.


DatePicker only options also applied to TimePicker

Not all options DatePicker props are valid on the TimePicker component and vice-versa.
However this component's options props gets applied to both components indiscriminately.
This causes errors in the console.
For example DatePicker's minDate prop is not valid for TimePicker thus setting it as an option  causes an error.

Hello! Thanks for the issue. Do you want the "options" props to be divided into two parts: timePickerOpts and datePickerOpts? Or we can add optionsTime and pass it to TimePicker such as label and labelTime. And what do you think?

Hi! Thanks for the quick reply!
I feel like your first suggestion of having to option props (one for the
time picker and one for the date picker) would probably be the easiest way
to go since then you wouldn't need to maintain a list of possible props.
But either way works for me. Thanks for a great module btw!
On Fri, 9 Feb 2018, 16:11 iamsimakov<EMAIL_ADDRESS>wrote:

Hello! Thanks for the issue. Do you want the "options" props to be divided
into two parts: timePickerOpts and datePickerOpts? Or we can add
optionsTime and pass it to TimePicker such as label and labelTime. And
what do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/iamsimakov/aor-datetime-input/issues/11#issuecomment-364399178,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlQ4OxdbqTmU-BNUwGy22j4o_ALA04Hks5tTCDxgaJpZM4R_e4w
.

Is it possible to export both DatePicker and TimePicker separately and the default export could check for children props and accept those instead if they're passed? Our usage would be something like..
import DatetimeInput, { DatePicker, TimePicker } from 'aor-datetime-input';

const example = props => (
  <Create {...props}>
    <SimpleForm>
      <DatetimeInput label="Published Date" source="published">
        <DatePicker options={{}} />
        <TimePicker options={{}} />
      </Datetimeinput>
    </SimpleForm>
  </Create>
);

I realize this might seem a little odd, but the default behavior of this package could behave as it currently does and I feel like this approach would benefit in a couple of way:

This opens the ability to put the Time Picker first, if that's ever a need.
Personally, I'd rather not have to import both DateInput (from AOR) and DatetimeInput if I have one date that just needs the date, and another that also needs time. Getting both of those from this package would be preferred.

ok, @loremipson @mcwebb thank you, I'll try to implement that.

I didn't have much time today, but I might tomorrow. I'm happy to put in a pull request for what I'm thinking.

@mc

@mcwebb hello, new feature in the master branch and new release is published

@loremipson hello, I tried to do it. You can see my code in related branch 11-... Do you can watch it, try it and some test it, please? In my project it works fine. But we can not forget that one line using also must work. Thank you.

Thanks @iamsimakov! Looks like this will resolve the issue for me 👍

ok, thank you @mcwebb
You can also try to use this version component https://github.com/iamsimakov/aor-datetime-input/commit/ea367c250abe3cc80674af41d3816a2b923bc03a

@loremipson hello, can you try it please https://github.com/iamsimakov/aor-datetime-input/tree/11-use-children-elements ?

component was updated to https://www.npmjs.com/package/ra-datetime-input @ashim-k-saha  @activist


linux:mainloop:log: Fix multiple initializations

There is problem when sol_log_impl_init()/sol_log_impl_shutdown() is
called more than once. The global mutex _mutex is statically initialized
but soletta is destroying it on shutdown(). So, all further functions
that use this mutex (for lock() and unlock())will fail because the init
is not initializing it.
This commit remove the destroy() from the shutdown(). Because there is
no reason to init/destroy the mutex instead of let it available.
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

lgtm

+0
maybe another option is to always init it... but what you did is okay, does valgrind bitch?

@barbieri i was in doubt about always init or never destroy, as the second one is simpler i proceed with that. I didn't run valgrind, I'll do it now and if no problem appears I'll commit this.


fix: custom urlPath for extensibility

Description
Changes proposed in this pull request:

fix: custom urlPath for extensibility
fix: isNodeSelected

Related issue(s)

/hold


Ansible query docs have incorrect documentation links

Expected Behavior
Documentation links are version pinned
Actual Behavior
Documentation links go to the latest release
Steps to Reproduce the Problem

Browse to https://github.com/Checkmarx/kics/blob/master/docs/queries/ansible-queries.md
Click a documentation link
See that the rego for that finding does not match the naming in the linked Ansible documentation

@JonZeolla Hi, first of all I hope you're doing.
About the issue you described, I could not reproduce this bug... Could you provide more details, please?

Due lack of information and the fact we couldn't reproduce, this issue will be closed. If any new information is added, this can be reopened.


chore(main): release 1.244.0

When this PR is merged, a new tagged release will be created with the notes below.
1.244.0 (2023-10-10)
Features

Add Session Replay configurations to collect inline assets (#763) (cef08dd)
Bump rrweb to <IP_ADDRESS> and make constant dynamic at build time (#770) (9ea84cf)
Ensure 15 second minimum error buffer when possible (#759) (8506803)

Bug Fixes

Fix invalid timestamps (#771) (bc5a57c)
Isolate browser interaction node (#758) (b9e8277)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/newrelic/newrelic-browser-agent/releases/tag/v1.244.0 :sunflower:

https://github.com/newrelic/newrelic-browser-agent/actions/runs/6488543380

https://github.com/newrelic/newrelic-browser-agent/actions/runs/6488512362


Add Gemma2-27b-q8 benchmark result to leaderboard

Adding Gemma2-27b-q8 result to leaderboard for local LLM enthusiasts.

Tested with Ollama 0.2.1
gemma2:27b-instruct-q8_0 model with hash dab5dca674db

This LLM model struggles with diff formatting; whole format works better.
The quality is not as good as rumored, at least for coding with Aider.
Those with high expectations might be disappointed.

Thanks for running and submitting this!

Thanks!


Repo is unlicensed

Pretty much what the title says; the repo has no LICENSE or COPYING file and the README doesn't say anything about it either, from a quick skim.

We don't publish the root of the repo.  The LICENSE is in the https://github.com/Microsoft/tsdoc/tree/master/tsdoc folder which we do publish.
I suppose we could also add some files at the repo root to make GitHub's heuristics happy. :-)

Resolved.


MT Bug at startUrlRequest call back in Importer::applySceneImports(std::shared_ptr platform)

When the map is loaded in iPhone 5s with iOS 10.3 in my custom app, I experienced quite often crashes. It happened at line 73, importer.cpp:
        condition.notify_all();

I found the condition variable does not notify without a mutex protection.
So I fetched the code by moving the mutex lock out of else clause as follows:

--- a/core/src/scene/importer.cpp
+++ b/core/src/scene/importer.cpp
@@ -63,10 +63,10 @@ Node Importer::applySceneImports(std::shared_ptr platform) {

         activeDownloads++;
         m_scene->startUrlRequest(platform, nextUrlToImport, [&, nextUrlToImport](UrlResponse response) {
+            std::unique_lock lock(sceneMutex);
             if (response.error) {
                 LOGE("Unable to retrieve '%s': %s", nextUrlToImport.string().c_str(), response.error);
             } else {
-                std::unique_lock lock(sceneMutex);
                 addSceneData(nextUrlToImport, response.content);
             }
             activeDownloads--;

And, I never experienced the crash again.
I hope it helps.

#1772

Hi @cheolgi, thanks for the crash report and the suggestion!
Do you have any more information from the crashes you're describing? A stack trace would be great.
I don't quite follow the logic of your edit. According to the documentation for std::condition_variable::notify_all:

The notifying thread does not need to hold the lock on the same mutex as the one held by the waiting thread(s); in fact doing so is a pessimization, since the notified thread would immediately block again, waiting for the notifying thread to release the lock.

(http://en.cppreference.com/w/cpp/thread/condition_variable/notify_all)
It may be true that adding a lock here prevents your crash, but I don't believe it addresses the underlying issue (whatever the issue is).

Hello @matteblair, thank you for the reply.
As you mentioned, <notify_all> need not share the same mutex as the waiting threads.
However, if there is a possibility that multiple threads notify the same condition variable simultaneously, each notifying block must be protected by the same mutex. In this case, the mutex for <notify_all> need not be the same as the one for the waiting threads.
For the reason above, <pthread_cond_signal> is always protected by <pthread_mutex_lock> and <pthread_mutex_unlock> when multiple sources may signal the same condition variable. I am not very familiar with the C++ <condition_variable> but <pthread_cond_t>.
<importer.cpp> is the case that multiple threads can call <notify_all> simultaneously. Hence, I think the code must be protected by a mutex.
If I can, I will attach the screenshot of the crash.

And, I would like to thank you for the efforts on Tangram project. It is superb! We are about to release an app using tangram. I feel sorry for the Mapzen's decision. We were one of the potential customers :(.

I just wrote a comment saying that notify_all must be protected by a mutex, but erased it immediately, because C++ reference says notify_all is designed to be MT-safe. In pthread, it must be protected by a mutex.
My problem could be iOS 10 bugs, because iOS 11 does not produce the same crash.

This is the screen capture for the crash:

If we don't guarantee in every platform code that startUrlRequest will run an async url request in the same thread for two subsequent calls of startUrlRequest then I think that @cheolgi's fix would be valid (as the notifying thread may be different and condition  accessed concurrently).

My guess is that there is no concurrent access to the condition_variable but that the condition_variable may be gone when calling on it. Say activeDownloads-- is executed and then condition.wait(lock) does a 'spurious wakeup' - if the queue is empty and activeDownloads 0 the loop ends and the function may return before condition.notify_all() started. This sounds extremely unlikely though..
In any case @cheolgi patch should fix this. Thank you!
@cheolgi could you expand the other threads? I'm wondering what the importer and main thread is doing.

Unfortunately, the crash happened again after the patch. I attached the stack trace image.
One weird thing is that no thread was at the while loop of , which can mean the local variable  had been popped out before <condition.notify_all()> is finished.
As <activeDownloads--;> is called before <condition.notify_all();>, the loop of  can be escaped in advance, possibly. Should the variable condition be a member variable?
Since it happens in our app (although it looks VERY RARE now), it bugs me a lot.


CV not working for v2

-10vref was reading- 6.7V. LM4040 footprint is inverted. Fixing this did not fix the CV issue yet

I think I found it. I was using the MCP6001U instead of MCP6001. Will close this once confirmed


Add Nix development environment for the Nix users out there

This PR adds a Nix development environment that will allow Nix users to easily build and work on valence without having to write their own.

If you could wait before merging, just realized the rustfmt config requires the unstable tool chain

Should be good to merge at this point.


Cookie path match possible RFC incompatibilities

As per RFC 6265 I noticed the following incompatibilities in path matching:

Nothing indicates that the matching should be case-insensitive. In fact many sources suggest it is case-sensitive, even if the RFC does not say anything about this specifically. It makes perfect sense as *nix OSes are case-sensitive by default.

The matching part is wrong as it would give false result for the following paths:

Cookie path: /path/to/somewhere
Request path: /path/to/somewhereelse

According to the RFC it must be checked that the first character in the request path which is not in the cookie path is "/".

In fact many sources suggest it is case-sensitive, even if the RFC does not say anything about this specifically.

Can you provide a source for that? I'm happy to change it, but I'd like to document the motivation.

The matching part is wrong as it would give false result for the following paths:

Yep, that looks like a bug then.

Can you provide a source for that?

Well, none of them can be taken as an official source. My particular opinion is that most webservers running *nix OS are case-sensitive by default.
Also, from the RFC:

The most common form of Request-URI is that used to identify a  resource on an origin server or gateway

Hence the case-sensitivity on *nix servers same URIs with different cases point to different resources.

I think you're right. Let's make them case sensitive.

I've fixed both problems raised in this issue.


Can I restrict adduser access?

I'm trying to restrict npm adduser access. I want to put this on a publicly available webserver (we have devs in multiple locations), but prevent unauthorised people from adding themselves onto the system.
Is there a way of doing this?

I am afraid the answer is no, as the endpoint for npm adduser is registering any new user by default, if I read the code correctly.
A possible workaround for now could be to keep your server local to your LAN and give the devs a VPN access.

If I were to come up with a proposition of adding this, would this be something people would like to be added?

In the config full.yaml, there's an option that has "to disable registration" as description: https://github.com/verdaccio/verdaccio/blob/master/conf/full.yaml#L31. Did you try that?

Aaaaaaah, that's perfect. Thanks @jachstet-sea


Order of comments

The order of comments should be chronologically (created_at asc).
Our frontend appends the comment to the bottom of the page which is correct, see my 🐻 comment:

The result set returned by the backend is ordered created_at desc though, so on refresh it looks like this:

Fixed in https://github.com/ayrton/remotestories/commit/fadb44516da7b984cb9879bc3b0af0167ffc5010


main-beta <- epic/popup

:tada: This PR is included in version 3.13.0-beta.3 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[ToolTip] Add tooltip content

Add all Task's info into ToolTip content

:tada: This issue has been resolved in version 1.19.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Needs update CSS :placeholder-shown  pseudo selector

I think its needs an update

Seems to be supported in current Chrome and Safari.

@cvrebert  Yes  and Opera

Fixed!


nginxModules.njs: 0.7.8 -> 0.7.9

Description of changes

New upstream releases. Mostly bugfixes.
https://hg.nginx.org/njs/rev/0.7.9
https://hg.nginx.org/njs/rev/0.7.10
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 206368 run on x86_64-linux 1

@ofborg test nginx-njs

@ofborg test nginx-njs


Merge forces for a project-manager / project-plus v3

👋  @danielbrodin
I've been considering deprecating project-plus but I hesitate to when this repository doesn't seem to be actively maintained. Large issues do get taken care of but it's got some decent enhancements as PRs that haven't even had a comment. I totally get it. It's a lot of work to maintain a large, actively used project.
It's also a bit sad that we aren't at the level of VSCode's project manager.
Which is why I'm suggesting that we make an atom-project-manager (or some other name) organization on github and we both develop and maintain a successor to project-manager and project-plus.
This organization would have at least:

project-service — In charge of handling the concept of projects.
project-manager — Anything else. Switching. The finder dialog, etc.

Some features that I think we should have (that we don't):

Detection (service)

VCS — Any Git, SVN, and Mercurial projects in your Project Home
"Projects" — Any folders with a project.cson file should be considered a project
History — Any projects you've opened that fall within your Project Home

Access History — The ability to remember the last time a project was opened. This would allow tabbing through projects as well as sorting them in the finder.

Thoughts @danielbrodin ?
Thinking more about it.. it could make sense to have each thing as its own package (that would make it easy to scope config):

project-plus-service
project-plus-service-git
project-plus-service-atom
project-plus-service-session
project-plus-finder
project-plus-tab
project-plus

Hey,
Yeah, I have had a lot of other things lately so haven't had that much time working on it. Did a rewrite like a year (or more) ago to make it easier for others to help do fixes, but as usual with OS that doesn't happen a lot.
So a merge could probably help out. I think we should keep the project-manager(atom-project-manager) name though and try keep the package since a lot of people are already using the it. Do you know if the package can be kept as it is if I move it to an organization? I mean if it's just to publish an update and everyone gets it?
I really like the idea with different packages. I kinda started this with moving the settings part out to it's own file, but maybe it would be even better to move it to it's own package that the project-manager would use, to make it easier to expand it and actually make it project specific settings without atom messing it up.

project-settings - In charge of project specific settings.

@danielbrodin Wanted to drop by to answer your question about publishing under an organisation: I've done the same for php-integrator-base around version 1.2.6 (moved it to the php-integrator organization). The only thing I did was update the repository URL in the package.json file and publish a patch release. I don't recall the need for any special steps.
Also, great to see that you're thinking about merging forces! I'd like to sneak in a reminder to the posts I wrote regarding managing project settings via an interface and creating new projects based on types/templates, possibly specified by plugin packages.
It's not something that's very high priority, but something I think should land in the long term if Atom is ever to integrate projects in a user-friendly way like most IDE's do. I believe it will also remain relevant when language servers become mainstream, as this is something that is handled mostly client-side.

@danielbrodin Let's do it. I agree to keeping the project-manager name. Here are some more thoughts.
Packages

project — Strictly the concept of projects and a few services to support that. This defines a service consumer to provide project definitions and a service provider of the collected total of project configurations. Furthermore this package would provide project metadata. Packages could be built off of such metadata such as a package like atom-build using it to access launch configurations.

project-manager — Defines the concept and structure of project.cson files. Provides projects with these to the base project service. Contains a project finder.

project-settings — Defines a consumer for project and is solely in charge of taking the settings key of the project metadata and applying the config when a project is loaded.

project-discover-git (better name?) — Defines a provider for project with all git projects it can find.

project-recent-history (beter name?) — Defines a provider for project with any project that has been opened by Atom.

Many other packages could be built off of such an ecosystem.

As for the organization.. any decent ideas on a name?

atom-project – Taken
AtomProject – Taken
atom-project-manager – Taken
project-atom – Available

I snatched the atom-project-manager organization name in case we agreed on using project manager as a name :) You have an invite to it

@danielbrodin Accepted. 🎉

The only thing I did was update the repository URL in the package.json file and publish a patch release

Ok, so I guess that means that I can keep the repository where it is for now, and once we have a updated repository I can just do a new release pointing to the new repository and then everyone should receive another update to download the new package? @Gert-dev

@danielbrodin You on Atom's slack?

@mehcode I am, but rarely having it open. Going on vacation today so will be away a fair bit the coming weeks, but can probably have a look here at github now and then at least.

@mehcode @danielbrodin There’s also project-ring, so it might be worth reaching out to @vellerefond as well. Also project-sidebar by @bripkens… and probably others!
Hopefully some consolidation can happen in this space, and once there is a definitive repo, I have a bunch of ideas to contribute.


Rename case_ to unit_ for HUnit

seems to fit better also with spec_ for hspec

In order not to break things, I'll add it as well as case_.

What about a version bump, not deprecating case_, but adding a generator which produces a compile time error?

I wouldn't go to great lengths to make this nicer. Keep it simple and just let it fail is the best here I think.
But just removing the prefix is not a good idea as you made clear :)
It is always a bit of a problem for me with tasty-discover, that I don't know which functions were used and which were not or if auto discovery for some reason missed some functions. But I have no idea howto handle that. Maybe we could add a command line option which just prints the discovered functions?

What about a version bump, not deprecating case_, but adding a generator which produces a compile time error?

Can you check https://github.com/lwm/tasty-discover/pull/97/commits/8bcc05ad37ce3eedee6b69a5e495f8de5d790979 and see https://github.com/lwm/tasty-discover/pull/97#issuecomment-293902571. I think that covers it?


(f"User {user_id} does not exist")

Hi! I try to set up bot, but i always give the same error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/telegram/ext/_application.py", line 945, in process_update
    await coroutine
  File "/usr/local/lib/python3.8/site-packages/telegram/ext/_handler.py", line 135, in handle_update
    return await self.callback(update, context)
  File "bot/bot.py", line 137, in new_dialog_handle
    db.set_user_attribute(user_id, "last_interaction", datetime.now())
  File "/code/bot/database.py", line 90, in set_user_attribute
    self.check_if_user_exists(user_id, raise_exception=True)
  File "/code/bot/database.py", line 23, in check_if_user_exists
    raise ValueError(f"User {user_id} does not exist")
ValueError: User 300300302 does not exist

My config.yml :
allowed_telegram_usernames: [Username]  # if empty, the bot is available to anyone
I also try:
allowed_telegram_usernames: [300300302]  # if empty, the bot is available to anyone
allowed_telegram_usernames: ["Username"]  # if empty, the bot is available to anyone
allowed_telegram_usernames: []  # if empty, the bot is available to anyone
But this no effect

Hmm.
Try to run command /start in bot to register user.

Thanks!

BTW, the latest commit (1681b4bd1c6dcd644c25d35473bee91b64c81c25) solves your initial problem. Now user can be registered from any handler.

OpenAI can't be used on free plan. You need to pay for it.


Update swc_core

Related:

https://github.com/swc-project/swc/pull/7069
https://github.com/swc-project/plugins/pull/158

Can you publish a new version?

yeah gimme a sec

Released in 0.1.8!

Thank you!


Add attributions

This PR adds missing Attributions and Change Log updates.

Pull Request Test Coverage Report for Build 29

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 27:
0.0%

Covered Lines:
31

Relevant Lines:
31

💛  - Coveralls


Please invite me to the GitHub Community Organization

Please invite me to the GitHub Community Organisation.

Please invite me

Name: Sky
Discord Username(if exists):

SkyWolf#8872
Additional Context:

Nick

Open Source is yes and I wanna join a community of open source people

Invitation sent for the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see, you can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/EddieJaoudeCommunity/people
Tips for practising:
Customise your GitHub profile, here is a live stream on it https://www.youtube.com/watch?v=cT6GXCuS0Zo
Practice repo, instructions on how to add your name to the README in the README https://github.com/EddieJaoudeCommunity/hacktoberfest-practice
Remember contributing to open source is not just about code, its about collaboration, communication and adding value
I hope that helps


Support for mkv?

Does this api support mkv files?

The API itself does not support any format/codec/device. It's just an interface to call ffmpeg. It all depends on the version of ffmpeg you're using.

I'm new to video codecs in general so please excuse my cluelessness. So if I understood you correctly, does that mean that if my version of fluent does support mkv, I should be able to use it?

Your version of ffmpeg. Fluent-ffmpeg is just an interface library. And yes, if your ffmpeg version supports mkv, you should be good to go :)


Use connector to direct traces to logs

Implement adapter connector which converts traces to logs. Use this
adapter in pipeline instead of loopback hack.
Description of change
Checklist

[x] Tested in playground or other setup
[ ] Screenshot (Grafana) from playground added to PR for 15+ minute run
[ ] Documentation is changed or added
[ ] Tests and/or benchmarks are included
[ ] Breaking changes

Summary by OpenAI
New Feature:

Added adapter connector to convert traces to logs, replacing loopback hack
Removed tracestologsprocessor factory and introduced adapterconnector factory
Removed filelog receiver and fake log pipeline
Updated OTelConfig struct with new fields and methods

🎉 A new dawn for trace conversion,
Adapter connector brings a revolution.
Farewell to the loopback hack,
With this update, we're on the right track! 🚀


Failed to parse NetParameter file: Yolov3/yolov3.weights in function 'readNetFromDarknet'

I'm try to build the  ""!python3 predict_video.py --input_video_path=VideoInput/video_input3.mp4 --output_video_path=VideoOutput/video_output.mp4 --minimap=0 --bounce=0"" on collab , but I don't see this paths  "yolo_weights = 'Yolov3/yolov3.weights'"  on the repository.
Can , you help me to regenerate this weights value please.

thanks


Open file hyperlinks starting with ~

Added a small check for hyperlinks that start with tildes to substitute them with $HOME on <Leader>oo.

Looks good, thanks :+1:


Update connectors-dev-dashboard.md

We have removed the option to select the platform where the connector can be published. The developers will now submit the connector for all platforms and the admin can take the call on the platforms where the connector will be enabled. Changing the documentation to reflect the same.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/connectors-dev-dashboard.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Create a new study by copying an existing one

As a user, who is in the process of building a new study, but that wants to start from an existing one
I want to create a new simulation by copying an existing study (with all the same values and all the txt files) without the output
in order to later start modifying the parameters of the study and eventually launch the calculation
Acceptance Criteria

[x] the request of the creation should accept the name of new simulation and the "origin" simulation from which everything should be copied.
[ ] A new study is created with the new name becoming the directory name of the new study
[x] the name should be written in the study.antares file as the value of the field caption
[x] the Unix Timestamp of the action should be written int field lastsave of study.antares
[x] an error should be returned if a simulation with the same name exists already in the workspace
[x] an error should be returned if the origin reference (the presumably existing study) does not exist

The api should be able to handle different studies with same name. A uid generation system should be implemented. (see #105 and #106 ).

The api should be able to handle different studies with same name. A uid generation system should be implemented. (see #105 and #106 ).

A discuter en daily et/ou review de backlog. C'est pas réellement iso-fonctionnel avec Antares. Cette implémentation demandrait l'installation d'un cache ou d'une base de donnée.

@qdesmedt les issues sont deja créé (les références sont dans mon commentaire)


Mini map hero icons dont resize

When heroes on the mini map get close together their icons don't rezise. this causes lots of overlap and you cant tell much from the mini map when heroes bunch up.

They don't resize in Hero Icon mode (because of valve reasons). They only resize in colored arrow mode.
Press ALT or TILDE or whatever you use when some heroes are bunched up and you'll see it work.
I wish it could be implemented for items too.

dat sucks T_T


Better Font Collection

Description
The website can certainly use a better font collection to amp up the UI!
Add the necessary labels too.

Please assign me for this work.

Already Assigned in features issue


Use proper rate limit headers and add success checking to ExecuteRequest

This moves the responsibility to pace requests from the library to the user. However, it provides much more accurate management of the request rate limit: seems like OAuth'd applications are actually limited to 600 requests / 10 minutes instead of a 60 requests per minute as stated by their documentation.
Also added auto-retry on failed requests. This was often leading the subsequent JSON parsing to start parsing the HTML/XML error responses.
Also includes everything in #73.

Sorry I haven't had time to get back to this yet, I haven't forgotten though!

Fixed the mentioned issues and cleaned up the timing logic. PTAL.

PTAL. Made the changes requested.

I'm going to merge this in, I'd like to get some test cases written for this, especially with a lot of requests all at once.
Still haven't figured out a build system, may have to switch to appveyor or something since MyGet hasn't updated build system for the new .netcore .csproj from what I saw last.


CMake file bug: libdmlhl.a gets installed in the wrong place

libdmlhl.a gets intalled into /usr/lib instead of /usr/lib64 (for system where libdir is lib64)

Hi @fenrus75,
Thanks for raising an issue, I will take a look onto install rules and make a proper change.

See the fix in pull request #8


⚠ Samsung has degraded performance

In 8b11bba, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2704 ms

Resolved: Samsung performance has improved in acb0d1c.


HashSyntax: autocorrect Under Ruby 2.2 produces code that no longer works on Ruby 2.0

Is this by design? Many projects build on all kinds of rubies, so this behavior is undesirable.
On https://github.com/intridea/hashie
git checkout acc3d48b91bb318d91be63f116a1f252dbfae636

$ ((acc3d48...))$ git status
HEAD detached at acc3d48
nothing to commit, working directory clean

$ ((acc3d48...))$ bundle
Using rubocop 0.34.2 (was 0.27.1)
...

$ ((acc3d48...))$ rubocop -a
Inspecting 59 files
...........................................................

59 files inspected, no offenses detected

$ ((acc3d48...))$ rvm list
...
=* ruby-2.0.0-p598 [ x86_64 ]

$ ((acc3d48...))$ rvm use 2.2
Using /Users/dblock/.rvm/gems/ruby-2.2.0

$ ((acc3d48...))$ bundle
...

$ ((acc3d48...))$ rubocop -a
warning: parser/current is loading parser/ruby22, which recognizes
warning: 2.2.3-compliant syntax, but you are running 2.2.0.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Inspecting 59 files
...................................................C.......

Offenses:

spec/hashie/hash_spec.rb:44:35: C: [Corrected] Use the new Ruby 1.9 hash syntax.
    expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3])
                                  ^^^^^
spec/hashie/hash_spec.rb:44:48: C: [Corrected] Use the new Ruby 1.9 hash syntax.
    expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3])
                                               ^^^^^^^^^
spec/hashie/hash_spec.rb:44:65: C: [Corrected] Use the new Ruby 1.9 hash syntax.
    expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3])
                                                                ^^^^^^^^^
spec/hashie/hash_spec.rb:81:37: C: [Corrected] Use the new Ruby 1.9 hash syntax.
      expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3], subhash: { :a => 'hey', :b => 'bar', :'123' => 'bob', :array => [1, 2, 3] })
                                    ^^^^^
spec/hashie/hash_spec.rb:81:50: C: [Corrected] Use the new Ruby 1.9 hash syntax.
      expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3], subhash: { :a => 'hey', :b => 'bar', :'123' => 'bob', :array => [1, 2, 3] })
                                                 ^^^^^^^^^
spec/hashie/hash_spec.rb:81:67: C: [Corrected] Use the new Ruby 1.9 hash syntax.
      expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3], subhash: { :a => 'hey', :b => 'bar', :'123' => 'bob', :array => [1, 2, 3] })
                                                                  ^^^^^^^^^
spec/hashie/hash_spec.rb:81:99: C: [Corrected] Use the new Ruby 1.9 hash syntax.
      expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3], subhash: { :a => 'hey', :b => 'bar', :'123' => 'bob', :array => [1, 2, 3] })
                                                                                ^^^^^
spec/hashie/hash_spec.rb:81:112: C: [Corrected] Use the new Ruby 1.9 hash syntax.
      expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3], subhash: { :a => 'hey', :b => 'bar', :'123' => 'bob', :array => [1, 2, 3] })
                                                                                ^^^^^
spec/hashie/hash_spec.rb:81:125: C: [Corrected] Use the new Ruby 1.9 hash syntax.
      expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3], subhash: { :a => 'hey', :b => 'bar', :'123' => 'bob', :array => [1, 2, 3] })
                                                                                ^^^^^^^^^
spec/hashie/hash_spec.rb:81:142: C: [Corrected] Use the new Ruby 1.9 hash syntax.
      expect(symbolized_hash).to eq(:a => 'hey', :"123" => 'bob', :array => [1, 2, 3], subhash: { :a => 'hey', :b => 'bar', :'123' => 'bob', :array => [1, 2, 3] })
                                                                                ^^^^^^^^^

59 files inspected, 10 offenses detected, 10 offenses corrected

This produces code that no longer works on 2.0.
$ ((acc3d48...))$ rvm use 2.0
Using .../ruby-2.0.0-p598
rspec spec
$ ((acc3d48...))$ rspec spec
.../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `load': /Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:44: syntax error, unexpected ':', expecting => (SyntaxError)
...ed_hash).to eq(a: 'hey', "123": 'bob', array: [1, 2, 3])
...                               ^
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:44: syntax error, unexpected ',', expecting keyword_end
...).to eq(a: 'hey', "123": 'bob', array: [1, 2, 3])
...                               ^
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:44: syntax error, unexpected ')', expecting keyword_end
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:81: syntax error, unexpected ':', expecting =>
...ed_hash).to eq(a: 'hey', "123": 'bob', array: [1, 2, 3], sub...
...                               ^
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:81: syntax error, unexpected ',', expecting keyword_end
...).to eq(a: 'hey', "123": 'bob', array: [1, 2, 3], subhash: {...
...                               ^
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:81: syntax error, unexpected ',', expecting keyword_end
..."123": 'bob', array: [1, 2, 3], subhash: { a: 'hey', b: 'bar...
...                               ^
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:81: syntax error, unexpected ':', expecting =>
...h: { a: 'hey', b: 'bar', '123': 'bob', array: [1, 2, 3] })
...                               ^
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:81: syntax error, unexpected ',', expecting keyword_end
... 'hey', b: 'bar', '123': 'bob', array: [1, 2, 3] })
...                               ^
/Users/dblock/source/hashie/dblock/spec/hashie/hash_spec.rb:81: syntax error, unexpected '}', expecting keyword_end
...123': 'bob', array: [1, 2, 3] })
...                               ^
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `block in load_spec_files'
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `each'
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `load_spec_files'
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:96:in `setup'
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:84:in `run'
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:69:in `run'
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:37:in `invoke'
  from .../ruby-2.0.0-p598/gems/rspec-core-3.1.7/exe/rspec:4:in `<top (required)>'
  from .../ruby-2.0.0-p598/bin/rspec:23:in `load'
  from .../ruby-2.0.0-p598/bin/rspec:23:in `<main>'
  from .../ruby-2.0.0-p598/bin/ruby_executable_hooks:15:in `eval'
  from .../ruby-2.0.0-p598/bin/ruby_executable_hooks:15:in `<main>'

When correcting hash syntax, RuboCop does a check like this to make sure it doesn't break the code:
RuboCop::ProcessedSource.new("{ #{sym_name}: :foo }").valid_syntax?

In other words, it parses that snippet and makes sure the syntax is valid. But, here is the problem: whatever version of the Ruby interpreter you are running RuboCop on, determines the parser which it uses to check that code.
This is obviously problematic for libraries which aim to run on more than one version of Ruby (which is to say, all of them).
I suggest that RuboCop should have a global config setting which represents the Ruby versions (1.9, 2.0, 2.1, and so on) which the code is expected to run on. When parsing sample code, it should try with all of the listed versions (using Parser::Ruby19, Parser::Ruby20, and so on).
How does this sound to the maintainers?

It sounds reasonable.
The behaviour in question was implemented as it is because doing it with regular expressions was kind of problematic. I definitely think it makes sense to be able to force the version of the parser used by RuboCop.

The behaviour in question was implemented as it is because doing it with regular expressions was kind of problematic.

Absolutely. Since we have a Ruby parser available, nothing is wrong with reusing it to check if autocorrection is valid or not. That is good design.
The problem is just the dependency on the current Ruby version.
After more thought, I don't think it will be necessary to test the corrected code on multiple Ruby versions... just the oldest Ruby version which the user wants to support.


Shadow Priest basic rotation doesn't use mindflay

Describe the bug
When selecting the "basic" rotation type it doesn't use mindflay at all. It also ends up using SWD regardless if you have it selected it or not
To Reproduce
Steps to reproduce the behavior:

Go to 'Setting" then select "Basic" for rotation type
Select "Basic" for rotation type

Expected behavior
Use mind flay and not clip it. As well as toggle SWD on and off

basic rotation was removed


Remove 'x-ms-client-flatten' in typespec-azure-resource-manager templates and make it conditional in autorest

Closes #709

All changed packages have been documented.

:white_check_mark: @azure-tools/typespec-autorest
:white_check_mark: @azure-tools/typespec-azure-resource-manager

Show changes
@azure-tools/typespec-autorest - breaking ✏

x-ms-client-flatten extension on some of resource properties property is now configurable to be emitted by autorest emitter. Default is false which will skip emission of that extension.

@azure-tools/typespec-azure-resource-manager - breaking ✏

x-ms-client-flatten extension on some of resource properties property is now configurable to be emitted by autorest emitter. Default is false which will skip emission of that extension.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1105/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1105/


Supabase CLI: Logout Does Not Restrict Access to Previously Linked Projects

Describe the bug
A clear and concise description of what the bug is.
After logging out from a Supabase CLI account and logging in with a different account, it is still possible to affect the projects linked by the previous account.
To Reproduce
Steps to reproduce the behavior:

Run supabase login with Account A.
Use supabase link to link a project.
Execute supabase logout to log out.
Run supabase login with Account B.
Try to perform operations on the project linked by Account A.
See the issue where operations on the project linked by Account A are still possible.

Expected behavior
When logging in with Account B after logging out from Account A, operations on projects linked by Account A should be restricted.
System information

Version of OS: macOS Sonoma 14.5
Version of CLI: 1.187.10
Version of Node.js: v18.19.1
Chip: Apple M2
Model: MacBook Pro (Model Identifier: Mac14,7)
Docker:

Version: 4.30.0 (149282)
Engine: 26.1.1
Compose: v2.27.0-desktop.2
Credential Helper: v0.8.1
Kubernetes: v1.29.2

Additional context
If applicable, add any other context about the problem here.

Browser: N/A
Version of supabase-js: N/A

I will work on this.


Adds PORT variable to gmailClient.py

TL;DR -> Proposing adding PORT_URI as a variable (set as port 8080 as a default) so that users can properly define the authorized redirect URI in OAuth 2.0 Client Ids.
#TODO -> Update READEME file with instructions to place the proper port in authorized URI.
When trying to add authorized redirect URI in OAuth 2.0 Client Ids, the connection fails when trying to authenticate because the port number is not defined (or in the code it was just 0). So the authentication throws a 400 error because we have an incorrect redirect URI. As the code was defined before, the port would just switch through random ports, so I am proposing adding a global variable PORT_URI set to 8080 as default that a user can define so that he or she may know what port to use in Google Cloud OAuth 2.0 authorized redirect URIs. This should be added to the README instructions as well. Thank you.

Thanks for the work, but I currently do not plan to merge pull requests.


mingw gcc on Windows does not include UINT8_MAX in stdint.h

On windows some people were facing issues when building with mingw as stdint.h did not contain the pound define for UINT8_MAX
Link to github issue going into more detail about this: https://github.com/nvim-treesitter/nvim-treesitter/issues/1876

I think the header that should be included is ‘limits.h’. If you add an include for that, does it work on mingw?

No it does not work and still returns an error saying that UINT8_MAX is not defined, I could only make it work by adding the code to scanner.cc which is in the pr.

I agree with the folks on the linked neovim issue that we should solve the underlying mystery — why aren’t you seeing UINT8_MAX in stdint.h? Looking at the source, it should be there.  If you try putting the #include <stdint.h> line before the others, does it work?

No, I have tried to put #include <stdint.h> first, however it did not work

After doing some research, I found out that you have to define __STDC_LIMIT_MACROS  before you include stdint.h  (link to github issue where I found this: https://github.com/miguelbalboa/rfid/issues/292) , I have tried this and this solved the issue, I will change the pr.

After doing some research, I found out that you have to define __STDC_LIMIT_MACROS   before you include stdint.h  (link to github issue where I found this: https://github.com/miguelbalboa/rfid/issues/292) , I have tried this and this solved the issue, I make a new pr with the new changes.


Improve hash testing

Currently there are several ignored tests:
panic!("Add check with expected class hash generated from sierra")
panic!("Transaction hash computation should be checked")

resolved in #122


Wallet fiat total don't get refreshed after enabling/disabling chain until app is restarted #3738

Closes #3738

There is a lot of jumping from the custom dispatch queue back to the main queue and back again. It's very hard to follow. Is there a diagram or something to help understand the code?

nope, we don't have such kind of diagram, i will recheck this issue later


[Bug]:

Minecraft Version
1.19.2
Fabric Version
Quilt 0.17.4
Mod Version
4.2.2
Details
The issue is not happening with 1.18.2 version of the mod (Prefab 3.1.5).
The issue is happened spesifically only on (to reproduce the issue) :

Iris (Tried on 1.2.8 and 1.3.1) with all its dependency.
Minecraft 1.19.2.
Prefab 4.2.2
Quilt 0.17.4

Latest Log
https://aofpaste.com/sifaqutuje.sql
I also have asked on Iris discord and I got some information :

@Brian-Wuest
Thank you very much not hurry, just take your time! :)

There are a lot of errors there and we don't support quilt.
Please provide the specific error in that log which is specific to Prefab as I could not see it right away.
It looks like It's is a shader mod. We don't support those mods with preview. This is similar to not supporting Optifine.


Implementing Email verification for another auth

I have created another auth and I want to implement email verification but I am not using the default registration controller and I implement mine. How do I call the must verify email for this custom auth. How do I also call the "verified" middleware for the routes? I have gone through some of the issues but not getting the solution

Okay, I will check.
Please provide laravel version you are using

I am using Laravel 7

fixed with latest version 4.1.0


Language Translator

Hey @SSHSRN   , I would like to open this issue under JWOC.

User can translate the text into any language with just one click.
user can select the preferred language from all the possible languages (100+ including hindi) available on Google
after selecting a specific language, user will be able to :

again translate the page by choosing new language
showing the original language
turn off the translation for that site

Kindly assign

Sure, you can work on it! @ritika728


Registry kafka streams example

Simple Kafka streams application using RHOSAK and RHOSR. It allows users to publish orders and it processed and creates events from those orders.

Hey, this is a different one. The one in main is an application using plain Kafka whereas this one is a Kafka Streams application, so different examples.


Unable to delete Amplify backend environment

** Please describe which feature you have a question about? **
Deleting unused backend environment
** Provide additional details**
I'm trying to remove a deprecated amplify backend environment, but I am getting a "The specified bucket does not exist." error whenever I try to use amplify pull to pull the environment so I can delete it. I don't have any resources related to this environment (all deleted) but it doesn't seem like I can delete the environment itself. What's the best way to get around this?

Can you share your appId/region?
Are you able to delete the baackend environment through the console?:

Sure. App ID is d25h3g71gr2w1w region is us-west-2 . So I was able to delete the environment using the solution outlined here but I am now trying to reprovision an environment with the same name (start new) but the deleted environment (prod) is still showing up as an existing environment when trying to link a branch:

Where do the options from this dropdown come from?

Looking at the network requests it appears that they should be coming from a request to https://us-west-2.console.aws.amazon.com/amplify/api/amplify with an operation value of listBackendEnvironemnts. The response from this request is correct and only contains the two backend environments that still exist (dev and master). Perhaps this is some sort of caching bug? @ganipcanot

I got the same issue:

I've created a BE for testing, but can't delete it via UI

Having the same issue, and there is no useful error message at all.
The backend environment in question was automatically created by a PR Review. The PR was closed and deleted and now the backend is stuff and won't go away.

Having the same issue, and there is no useful error message at all.
The backend environment in question was automatically created by a PR Review. The PR was closed and deleted and now the backend is stuff and won't go away.

I am also facing the same issue on Amplify Console. I am not able to delete the whole app or the backend environment on the following configuration:-

Region: us-east-1
App ID: dpjxh4jhr63k2

I have the same problem.
Is there any progress?

I have the same problem.
Is there any progress?

Have you tried the suggestion here: https://github.com/aws-amplify/amplify-console/issues/1330
Specifically: aws amplify delete-backend-environment --app-id <YOUR_APP_ID> --environment-name <THE_BACKEND_ENVIRONMENT_NAME>

@ganipcanot - this fixes it for me, but the AWS console should also do this

@apiel51 @marlonmarcello @sharmaaditya570191 @gilvaju @cnbrkkaya @PabloLION
Could any of you please confirm if you attempted to delete the backends via CloudFormation first before attempting a delete via the AWS Console? Also, have you tried the workaround suggested here: #1330 (comment) and did that resolve your issue?
We are currently unable to reproduce the issue correctly. I would really appreciate if any of you could provide detailed reproduction steps, so I can investigate this properly.

@Narrator - yes, this is what happened to mine. Using the aws cli seems to fix it.

Having the same problem for almost 2 months,  so annoying.

Having the same problem for almost 2 months, there is no trace left of any resource that backs the Amplify projects anymore, no CloudFormation, no nothing, how it is possible that no one can fix this... so annoying.

Same

no progress? same problem here!

Have you tried the suggestion here: #1330 (comment)
Specifically: aws amplify delete-backend-environment --app-id <YOUR_APP_ID> --environment-name <THE_BACKEND_ENVIRONMENT_NAME>

Thanks Ganipcanot, you're a true hero.

This is what worked for me.

open AWS CloudShell and run cmd: aws amplify delete-app --app-id <your_app-id>
you can find amplify app id at amplify app detail

Credit due:
https://stackoverflow.com/a/70894285/11705601

We have since fixed this issue. Resolving.


alias usage

looking at the readme and don't seem to understand how to use the alias arg. what is it? does it go in kion.yml? tried using the AWS account alias, and other names in Kion and that didn't work. thanks!

Hi @juweeks, I need to get an update into the readme, but alias support is only available in Kion 3.9.9 or 3.10.2 and up. If you're on one of those versions or later let me know and we can dig in. Also alias support is only available via flags at the moment.

ah ok. good to know. thanks @codybuell


@InjectPresenter(type=PresenterType.GLOBAL) requires tag value

Is it possible to not set the tag value (leave it "" as default) but have a single global Presenter? @InjectPresenter(type=PresenterType.GLOBAL) vs @InjectPresenter(type=PresenterType.GLOBAL,tag="tag") if I actually need single Presenter of such type around the application.

If you want to use single presenter around the application, you should set not empty tag to field.

Yes I see that now the tag should be set anyway. But less code is better right? It's probably possible to remove TextUtils.isEmpty check and allow to create a global presenter with no tag specified by default.

The problem is this. If not specified, we do not know the user wants presenter was one of the specified class or one presenter with the name of this variable.
I.e. one user will assume that in this case there will be one presenter, but other users will think that there will be two different presenter:
public class OneActivity extends MvpActivity
{
    @InjectPresenter(type=PresenterType.GLOBAL)
    GlobalPresenter mOneGlobalPresenter;
...

public SecondActivity extends MvpActivity
{
    @InjectPresenter(type=PresenterType.GLOBAL)
    GlobalPresenter mSecondGlobalPresenter;
...

Alright it's a matter of taste. It is not a big deal to write @InjectPresenter(type = PresenterType.GLOBAL, tag = "global") always and show the presenter's oneness explicitly.


backends auto-discovery

A quick module parsing for the backend activations.
@stavros11 please let me know if you agree.

@stavros11 thanks, I have refactor the code.


[v3.4.beta2] GPU particles not emitted when direction is zero

Godot version
v3.4.beta2
System information
Windows 10, GLES3, Geforce 1070
Issue description
Animated texture on Spacial material for particle system does not work. It worked fine in Godot v3.3.
Steps to reproduce
Open the provided 3.4 project, it should display the animated particle system working, but it doesn’t.
It works fine on the provided Godot 3.3 project.
Minimal reproduction project
AnimatedParticleNotWorking.zip

I can confirm the issue in latest 3.x (bab9c02f472044415845ce284c55c961402c9c7c).
The problem seems to be that the particles material uses a zero direction. That doesn't seem to be a problem in 3.3 but in 3.4 that makes everything invisible.
That's probably a regression from #47310, CC @mortarroad.

Up to you to decide if this is a bug.
According to https://docs.godotengine.org/en/stable/classes/class_particlesmaterial.html#class-particlesmaterial-property-direction, direction it is a "Unit vector specifying the particles' emission direction."
And (0, 0, 0) is not a unit vector.
Fixing this would go in the shader, and I would really like to keep the shader short. (Although we got several special cases already, one more might not hurt.)
But at least for 4.x, I wouldn't fix this.

I agree this should be fixed in 3.x at least. Particles could be emitted upwards in this case.

Shouldn't it be possible to emit particles in no specific direction? In which case a zero vector makes sense for this IMO, otherwise it would have to be a boolean toggle of some sort?

Shouldn't it be possible to emit particles in no specific direction?

I think this is done by setting any direction and setting the initial velocity to 0.

Up to you to decide if this is a bug.
According to https://docs.godotengine.org/en/stable/classes/class_particlesmaterial.html#class-particlesmaterial-property-direction, direction it is a "Unit vector specifying the particles' emission direction."
And (0, 0, 0) is not a unit vector.
Fixing this would go in the shader, and I would really like to keep the shader short. (Although we got several special cases already, one more might not hurt.)
But at least for 4.x, I wouldn't fix this.

If the parameter expects values different than zero, the editor should reinforce it somehow, or do it internally, otherwise, on the user side, it looks like a bug.

I think zero should be special cased as it doesn't make sense as a value for a direction vector. IMO it should behave the same (no velocity, no direction) if either velocity or direction are zero.

I think zero should be special cased as it doesn't make sense as a value for a direction vector. IMO it should behave the same (no velocity, no direction) if either velocity or direction are zero.

That would still be a regression, since we handled the zero vector differently in 3.3. (Although spread was a broken mess in 3.3 anyway.)
Anyway, this line is causing the issue:
https://github.com/godotengine/godot/blob/41cf7f27607d29946575877eb8bebdc2d892e78d/scene/resources/particles_material.cpp#L348
Apparently, normalizing a zero-vector causes a division by zero.
Could be changed to something like
vec3 direction_nrm = length(direction) > 0.0 ? normalize(direction) : vec3(1.0, 0.0, 0.0);

Fixed by #51553.


net/context: No need to set pkt family as the allocator did already

net_context uses net_pkt_alloc_with_buffer(), which sets the family and
protocol (according to parameters) so no need to set the family again.
Signed-off-by: Tomasz Bursztyka<EMAIL_ADDRESS>

Codecov Report

Merging #13252 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13252      +/-   ##
==========================================
- Coverage   48.75%   48.74%   -0.01%
==========================================
  Files         319      319
  Lines       46871    46871
  Branches    10835    10835
==========================================
- Hits        22850    22849       -1
  Misses      19394    19394
- Partials     4627     4628       +1

Impacted Files
Coverage Δ

subsys/net/ip/net_context.c
59.03% <ø> (ø)
:arrow_up:

arch/posix/core/posix_core.c
90.9% <0%> (-1.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acaae57...9df0c4a. Read the comment docs.


api development

Here I did the following requirments;
Develop the backend API to handle data for items, reservations, and user-related activities.
Set up the server and database connections.

I will correct the rubocop in another branch


Deprecate pc.inherits

Inheritance. We're doing it wrong.
This PR does away with pc.inherits. The reasons for this are as follows:

When looking at the PlayCanvas codebase for the first time, it's not obvious what pc.inherits does. You have to look at the source to fully understand it. And when you do, pc.inherits is quite hard to understand.
pc.inherits does a number of unhelpful things which hamper debugging. It nukes the expected argument list, replacing it with arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8. It nukes the constructor's name property, universally replacing it with the string "Func" (instead of "Entity" for example). It sets the constructor's 'length' property to 8 instead of the actual number of arguments taken. This PR replaces the following in Dev Tools:

With this:

Try single stepping through a subclass constructor and you'll initially step into pc.inherits. This is unexpected for the uneducated. Ideally, if you single step into new pc.Entity(), you'd step to the first line of the pc.Entity constructor.
It introduces a property called _super, that is only understood when you look at the code for pc.inherits. Subclass._super.someFunc.call(this) is more obscure than Superclass.prototype.someFunc.call(this).
The subclass prototype's constructor property is nuked by pc.inherits. This is not fixed in the previous PR aimed at restoring the constructor property of PlayCanvas objects - that only worked for non-subclassed objects.
pc.inherits requires you to have the same constructor arguments up the inheritance chain.
Why provide a function to do something (worse) than what vanilla JS can do? We can happily deprecate pc.inherits and banish it to the backwards compatibility module (and hopefully get rid of it one day).

All of the above are addressed by this PR. I suspect this PR is marginally better performance-wise also (fewer function calls).
This PR replaces this:
function Subclass() {
}
Subclass = pc.inherits(Subclass, Superclass);

With this:
function Subclass() {
    Superclass.call(this);
}
Subclass.prototype = Object.create(Superclass.prototype);
Subclass.prototype.constructor = Subclass;

A little more verbose, but it's completely readable/understandable by anybody with JS expertise.
NOTE: This PR also no longer has component data classes subclass pc.ComponentData. It's an empty class so this is completely redundant. I've stopped short of deleting pc.ComponentData altogether, but we probably should.
I confirm I have signed the Contributor License Agreement.

Nice PR. 👍
Vanilla JS way is way simpler to understand, as pc.inherits required to learn the abstraction as well as vanilla prototyping.
Reason why there was arg1..8 was the initially I think there was use of arguments object, which then was deconstructed every time constructor was called, which lead to looping through arguments which leads to allocations within browser and making array of arguments to pass through lead to more allocations. So we replaced it with hacky arg1..8, very similar to what is used in events library still, but proves to be better way than using arguments object.

Thanks @Maksims! 😄


[Event Hubs Function Bindings] Live Test Failures

Summary
A set of  end-to-end tests is consistently failing in the nightly runs, following the merge of #16645.   The impacted tests are:

EventHub_MultipleDispatch
EventHub_PartitionKey
EventHub_PocoBinding
EventHub_SingleDispatch
EventHub_StringBinding

Each failure appears to have the same underlying cause:
Required test connection string 'AzureWebJobsTestHubConnection' is missing.

Scope of Work

Update the identified tests such that they pass deterministically and consistently.

Mark the test as enabled rather than skipped.

Success Criteria

The tests identified in the summary have been updated to pass consistently across all platforms.

The tests identified in the summary have been enabled and is executed as part of the nightly runs.

The existing test suite continues to produce deterministic results and pass reliably.

References

Example run with failures

//fyi:  @pakrym


API token

Hi Nicolas
In the Jira Flowvis instructions, you referred to generating an API token, but I'm unclear about where to use it when connecting PowerBI to Jira. It's possible that there's a permissions issue, as I'm encountering a (400): Bad Request error while trying to set up the template. Could you possibly know why this is happening? I've completed all the prerequisites, except for understanding the application of the API token after its creation.
Regards
Tom

Manage to figure out how to use the API token, might be worth adding this to the instructions:
Create an API Token in Jira:
Log into your Atlassian account.
Navigate to the API token section (usually under Account settings or Security settings).
Create a new API token. Once it's created, make sure to copy it and store it securely.
Use the API Token in Power BI:
Open Power BI and go to the section where you are setting up the data source connection to Jira.
When prompted for authentication, select "Basic" as the authentication method.
In the username field, enter the email address associated with your Atlassian account.
In the password field, use the API token you generated in Jira. (Do not use your Atlassian account password).
Complete the Connection:
After entering your email and API token, proceed to connect.
Power BI should now authenticate using these credentials and fetch data from Jira.

Hi @tomramsay
Thanks for sharing. Out of interest, what were you using as your setup instructions? Only because I believe all this info/detail is documented already in the readme for the repo? 😅


[tsp-client] Add tsp-client tutorial docs

Add a tutorial on how to use tsp-client in a local spec repo for folks just starting out writing their TypeSpec project and havent checked anything in to the specs repo.
Add to package docs + typespec-azure site

Docs added here: https://azure.github.io/typespec-azure/docs/howtos/generate-with-tsp-client/local_spec_quickstart/


Rename constants prefixed SDK_ to CRAWLEE_

Which package is the feature request for? If unsure which one to select, leave blank
None
Feature
It would be great to have this updated.
Motivation

Ideal solution or implementation, and any additional constraints
rename
Alternative solutions or implementations
No response
Other context
No response

Do you think it's safe to do it in a non-major release? I know those are internals, but I can imagine people reading those files manually too. Thoughts @metalwarrior665?

I think it would be safer to wait for a major release. It's not critical.


Update system-requirements.md

adding "Stretched Cluster in AKSHCI and Aks on Windows Server" per request from @EkeleAsonye

Docs Build status updates of commit ef708b7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-stack/aks-hci/system-requirements.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 16dd101:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-stack/aks-hci/system-requirements.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@sethmanheim,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Docs Build status updates of commit 79cb8be:
:warning: Validation status: warnings

File
Status
Preview URL
Details

azure-stack/aks-hci/system-requirements.md
:warning:Warning

Details

azure-stack/aks-hci/system-requirements.md

Line 190, Column 18: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure-stack/hci/concepts/stretched-clusters' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 190, Column 340: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure-stack/aks-hci/backup-workload-cluster' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @leslielin-5 I am closing this PR, as it's in the public repo. Since you're internal, can you please open a new one in the private repo? Thanks! #please-close


fix: added parameter to rename aliases of aggregated columns used in GROUP BY statments

SUMMARY

Follow up PR after #28444.
The only notable change after that PR is that I shortened the parameter names to properly reflect the usage and to fit within the 30 character limit. This name change also inverts the meaning of the parameter and thus the usage has also been inverted everywhere.
Fixes issue #28443
Renamed db_engine_specs parameter allows_alias_to_source_column to order_by_require_unique_alias and added the new parameter group_by_require_unique_alias. This new name also inverts the meaning of the parameter, but properly reflects its function.
The previous parameter is used to tell the SQLA generator to rename aliases used in ORDER BY statements with aggregations, to ensure that the source column is referenced. Some engines (e.g. Drill) needs to be able to do the same thing for aliases in GROUP BY statements.
The new parameter is used to tell the SQLA generator to rename any alias of a source column that is used in an aggregation in a GROUP BY statement, to ensure that the source column is referenced.
For example this query
SELECT length(n_name) AS n_name
...
GROUP BY length(n_name)

becomes
SELECT length(n_name) AS n_name__
...
GROUP BY length(n_name)

This ensures that the source column n_name is used in the length(n_name) statement.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

The documentation of the new group_by_require_unique_alias parameter has been added, and errors in the documentation of order_by_require_unique_alias/(previously)allows_alias_to_source_column has been fixed.
TESTING INSTRUCTIONS

Start Superset
Navigate to the Superset web application and login
Connect to a Drill database
Create a dataset of the Drill database
Create a chart from that dataset
Select visualization type Table with query mode Aggregate
Add two columns in the dimensions
Aggregate the data of one of the columns (e.g. length(column_a))
Press "view query"
The query should now contain a GROUP BY statement of an aggregation, and the alias of that aggregation should have "__" at the end of the name.
Example:

SELECT length(n_name) AS n_name__
...
GROUP BY length(n_name)

ADDITIONAL INFORMATION

[X] Has associated issue: Fixes #28443
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Thanks for this! Running CI 🤞

Just the comment that this works perfectly after merging to our branch (we have Apache Drill setup to call our proprietary db that can interface in Mongo syntax).
I know there are pending 340 PR, want to add some plus points on merging this.

Edit:
* [ ]  Heatmap is not working

SELECT
  NEARESTDATE(`Timestamp`, 'DAY') AS `Timestamp__`,
  `DB User Name` AS `DB User Name`,
  count(DISTINCT `Timestamp`) AS `COUNT_DISTINCT(Timestamp)`
FROM `mongo`.`sonar_log`.`audit_log`
GROUP BY
  NEARESTDATE(`Timestamp`, 'DAY'),
  `DB User Name`
ORDER BY
  `Timestamp` ASC,
  `DB User Name` ASC
LIMIT 10000;

Hi @joeyJsonar, can you clarify what you mean by "Heatmap is not working" in this example?
The query does not seem to use any aliases that would break it.
GROUP BY NEARESTDATE('Timestamp', 'DAY') instead of GROUP BY 'Timestamp__' is a bit silly but should not be a problem, and it is not an issue this PR intended to fix (nor cause).
Thanks!


Using props (react hook) doesn't have the expected behavior

Hi !
I'm really really really new learning Styled-components (and programming) and I'm trying passing props like the exemple. But even if I'm not passing props to one of the  component, the style is applied on both.
I'm using React Hooks.
Thank you for helping
Environment
System:

OS: macOS 10.15.7
CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
Memory: 3.18 GB / 16.00 GB
Shell: 5.7.1 - /bin/zsh

Binaries:

Node: 12.18.1 - /usr/local/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.5 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman

npmPackages:

styled-components: ^5.2.0 => 5.2.0

Expected Behavior

Actual Behavior

My code
import React from 'react';
import './App.css';
import styled from "styled-components"

function App() {

let primary=true;

  const Title = styled.h1`
  font-size: 1.5em;
  text-align: center;
  color: palevioletred;
`;

const Wrapper = styled.section`
  padding: 4em;
  background: papayawhip;
`;

const Button = styled.button`
  background: ${primary ? "palevioletred" : "white"};
  color: ${primary ? "white" : "palevioletred"};

  font-size: 1em;
  margin: 1em;
  padding: 0.25em 1em;
  border: 2px solid palevioletred;
  border-radius: 3px;
`;

  return (
    <Wrapper>
    <Title>
      Hello World!
    </Title>

    <Button>Normal</Button>
    <Button primary>Primary</Button>

  </Wrapper>
  );
}

export default App;

This is happening because you are not using the props passed to Button.
Both ${primary ? "palevioletred" : "white"} and ${primary ? "white" : "palevioletred"} are using the primary variable declaration above, not the prop being passed.
In order to use the prop primary, you must access it within the styled declaration using a function.
So instead on ${primary ? "palevioletred" : "white"} you need to use ${props => props.primary ? "palevioletred" : "white"}.
Also, you are applying the prop to the Button incorrectly. Using <Button primary>Primary</Button> will always return true. If you want to send a specific value you would need to use <Button primary={value}>Primary</Button>
Using all of this your code should look like:
import React from 'react';
import './App.css';
import styled from "styled-components"

function App() {

let primary=true;

  const Title = styled.h1`
  font-size: 1.5em;
  text-align: center;
  color: palevioletred;
`;

const Wrapper = styled.section`
  padding: 4em;
  background: papayawhip;
`;

const Button = styled.button`
  background: ${props => props.primary ? "palevioletred" : "white"};
  color: ${props => props.primary ? "white" : "palevioletred"};

  font-size: 1em;
  margin: 1em;
  padding: 0.25em 1em;
  border: 2px solid palevioletred;
  border-radius: 3px;
`;

  return (
    <Wrapper>
    <Title>
      Hello World!
    </Title>

    <Button>Normal</Button>
    <Button primary={primary}>Primary</Button>

  </Wrapper>
  );
}

export default App;

I hope this helps!

Closing due to inactivity.
Please don't forget to be a good netizen on GitHub and revisit issues, especially ones that have been resolved and need to be closed, or ones that have received replies ❤
Please refer with usage questions to Stack Overflow, as you're more likely to get quicker and helpful answers there ❤ Repository issues on GitHub are great for that, issues, things that need to be resolved in the library itself, or can't be resolved by anyone but the maintainers. While I (and many others on other repos) are happy to eventually answer usage questions, styled-components is a busy repo and mostly stable and slow moving towards new releases, so you're not likely to get fast responses here


simplify date change

Roni:

I need a way to change the date more directly than by pulling down the calendar. Can you let me grab any of the red vertical bars on the small multiples and move it right or left? And/or by clicking anywhere on the time line in one of the small multiple?   Also use the left-right arrows?

User story

Additional context

I believe this use-case has been presently addressed, and we will make sure that it remains easy to change context dates in the redesign.


execution of module a failed without setting an exception error when using function as function's default args

Although that I know you should not write code like this, but the follow code will cause execution of module a failed without setting an exception with the 3.x beta version (commit id 758aaad041dddef318f7eb476612d66eb8f7d082), while the 0.29.13 version works fine.
# This is the python file to cythonize, called a.py
import datetime

def func(x=datetime.datetime.now()):
    print(x)

# This is the code to use the compiled module
import a

a.func()

Thanks for the report. Seems worth adding this as a test to this test file.

Needs further investigation by looking at the generated C code to see where the error originates from.

I had a quick look at this and couldn't reproduce this bug under either Python 3.7 or Python 2.7


Notification Badge Icon not rendering correctly

Issue Description
When a user logs in and has the messages are populated for the first time the number of unread messages will be 10 (or however many messages they have received if less than 10).
Steps to Reproduce / Code Snippets
Install a new build from the deep-linking branch.
Log in
Send a  few notifications to your account if it does not have any
Do not navigate to the notification tab otherwise the badge icon will reset
Expected Results
Expect the notification badge to remain consistent throughout the entire user process.
User should be able to log in on a different device and see the same number of unread messages across all devices.
Additional Information
In order to do this we need to store a variable in profile which holds the last time stamp for when the notification tab was opened.
This timestamp needs to be updated only if we are view new messages.
One thing to be aware of is that when we modify the local profile it causes a profileSync to happen which also reloads the messages again.
We want to avoid the extra reloading of messages because it causes rendering issue with the FlatList that displays the notifications.

Platform(s) (iOS, Android, or both?): Both

completed: 9e31be3f85abfd978dfed4691f16edcee8bc798e