Update pydantic models to v2.9

There is no functional change in this PR.

Update Pydantic to v2.9.
Simplify definition dsgrid data models in conformance with latest pydantic. Mostly, remove verbose uses of Annotated.
Replace uses of typing.List and typing.Dict with list and dict.
Remove use of Optional when there is a default value - those cases should not need to support a value of None.

LGTM. I like the streamlined interface. If I'm recalling correctly, this is more like an earlier version? (I seem to remember a previous PR changing all the "Field"s to "Annotated"s ...)

Yes, that's true. I switched to Annotated when I upgraded from pydantic 1.x to 2. Type hinting didn't work correctly. I'm not sure if that was my fault or some incompatibility with the initial version. Anyway, everything works well now. I did have to convert a few things to new pydantic 2.9 formats.


Possible to enter invalid dates in firefox bringing the datepicker out of sync.

Could it be possible that the issue, described in filipe's latest comment in this issue: https://github.com/eternicode/bootstrap-datepicker/issues/1130 is'nt fixed ?
This is the issue I am facing:
I have a datepicker set to format: dd/mm/yyyy.
Currently, the datepicker allows me to type 17/06/1, but it modifies the date visual in the textbox and the date sent to the ChangeDate event to 20/10/1 (= todays day and month, but not the todays year). The picker popup however shows the date as 20/10/2015 (= today). So the textbox keeps displaying 20/10/1 which is incorrect since this is not a valid date considering the yyyy format.
If, however, I type 17/06/71 the textbox will show "17/06/1971" being a valid date for firefox.
The referenced commit solves the displaying of NaN/NaN/NaN, however I don't think the issue is fully solved since the datepicker allows me to select an invalid date, doesn't change the year to a correct year and displays another date compared to the one send to the chanegDate event:
How to reproduce at this fiddle: http://jsfiddle.net/tuG6C/1010/

Enter 17/06/1 in the textbox and press tab or enter
Textbox is changed to 20/10/1
Value passed to the ChangeDate event is 20/10/1 (see console)
Value displayed by the datepicker popup: 20/10/2015

In my opinion there are three possible solutions for this example:

Firefox doesn't allow years to be lower then 70 (as mentioned by filipe in the referenced issue). So don't allow this as an input value.
This would mean the years are modified to the current year in the textbox, the value passed to changedate and the datepicker popup setting it to a value of 17/06/2015.

Firefox doesn't allow years to be lower then 70 (as mentioned by filipe in the referenced issue). So don't allow this.
This would mean the date is modified to the current datein the textbox, the value passed to changedate and the datepicker popup setting it to a value of 20/10/2015 (= today).
The difference between the first solution and this one is that this one denies an entire valid date, wheras the previous solution detects that it is only the year which is in valid and only modifies the year to make the date valid.

Allow years to be lower than 70 and make sure the textbox' year, changeDate event's year and the datepicker popup year is changed to 1901. Making it the date: "17/06/1901". See Filipe's comment in the reference issue.

PS: The issue exists in the sample page aswell (see second attached
screenshot). However I've used a fiddle to be able to log to the console for you.
Thanks !

Afaik, Firefox does handle date before years 70 or 1970, it does handle any correct date.
The main problem you're coming across here is the Y2K problem.
When Brendan Eich invented javascript, he put the greatest feature of all, all years from 1 to 99 will be converted to 19xx. Short story long, You tend to get unexpected values when using the default setter for years, and not the same values across different browser. While Chrome took a while ago to simply remove this bug from JS core, Firefox and IE are keeping it, so old scripts from the 90's still work.
Now, back to this plugin, there is some place in the code where we set the date using the default setters.  We are aware of this issue, which have been reported many times now, but this need some work to fully resolve, and if I'm remember right, this was planned for a more major future update.

I did debug the plugin and came to  the same conclusion as you, there is some weird shit going on on this piece of code:
var _date, s;
for (i=0; i < setters_order.length; i++){
	s = setters_order[i];
	if (s in parsed && !isNaN(parsed[s])){
		_date = new Date(date);
		setters_map[s](_date, parsed[s]);
		if (!isNaN(_date))
			date = _date;
	}
}

The issue I discovered is on the line:
_date = new Date(date);

_date is set to an invalid date because the date value contains a year lower then 70.
An overview of the Date constructor result in firefox:
var date = new Date(10,9,20);
console.log(date); // Logs 20 / 10 / 1910
date = new Date("Wed Oct 20 0010 02:00:00 GMT+0200 (Romance Standard Time)");
console.log(date); // Logs invalid date
date = new Date("Wed Oct 20 0070 02:00:00 GMT+0200 (Romance Standard Time)");
console.log(date); // 20 / 10 / 1970
date = new Date("Wed Oct 20 2015 02:00:00 GMT+0200 (Romance Standard Time)");
console.log(date); // 20 / 10 / 2015

Situation 2 is what is happening in the datepicker plugin.
I do understand this isn't fixed pretty easy. I didn't report this to be fixed asap. However, do you have any workaround which does not involve modifiying the code ?
The following workaround does solve the issue:
yyyy: function (d, v) {
    // turning_point = 100;
    if (v < turning_point) {
        return d.setUTCFullYear(2000 + v);
    } else {
        return d.setUTCFullYear(v);
    }
},

But this involves modifying the source code, which ofcourse is something we prefere to keep our hands of.

Well, your work around only solve a part of the issue.
As you experience, the constructor does have the bug, so the main issue would be to not use the constructor in order to set date:

But a quick look into the code and you will see that there is new Date() everywhere.
My advise would be to use a custom Date object to wrap around the core Date object, so we could have only one place to handle this issue (and others related to Date). But as I said, it's everywhere, and not as easy to update the code so we can be sure it's all gone.
Hopefully this will be saved for the 2.0
In the meantime, maybe #1556 will be pushed in 1.5.1, which is quite similar to your workaround, be it won't fix everything.

So long story short: No workaround or quick fix from your side ?
Coz this srsly is blocking our application :(

As I see a fix being made for https://github.com/eternicode/bootstrap-datepicker/issues/445 , any idea on how to solve my issue ?
Any plans on pulling in momentjs for handling dates ? This might come in handy for things like this imho.

I am seeing this issue outside Firefox as well using the 1.6.0 version. I opened an isuse: https://github.com/eternicode/bootstrap-datepicker/issues/1857


Overseerr - requested by user is null.

Describe the bug
When using rules that look at the overseer requested by user, it will return null for any requests that are not mine (owner). This looks to be an old closed issue, #995 that was suggested fixed in #1070. Hoping not user error.
To Reproduce
Steps to reproduce the behavior:

Create Rule that looks for a specific user.

mediaType: MOVIES
rules:
  - "0":
      - firstValue: Overseerr.addUser
        action: EQUALS
        customValue:
          type: text
          value: OWNER

This will return results of any of my requests in the collection
Change to any other user, collection will be empty.
Doing test media shows null for all media not requested by owner but, however populated if requested by owner.

Broken:
- plexId: 47296
  result: false
  sectionResults:
    - id: 0
      result: false
      ruleResults:
        - operator: OR
          action: equals
          firstValueName: Overseerr - Requested by user (Plex or local username)
          firstValue:
            - null
          secondValueName: text
          secondValue: OWNER
          result: false

Working:
- plexId: 47315
  result: true
  sectionResults:
    - id: 0
      result: true
      ruleResults:
        - operator: OR
          action: equals
          firstValueName: Overseerr - Requested by user (Plex or local username)
          firstValue:
            - OWNER
          secondValueName: text
          secondValue: OWNER
          result: true

Expected behavior
Media would show the user who requested it for comparison.
Device (please complete the following information):

OS: Docker
Version 2.0.4
Overseerr Version: 1.33.2

Additional context
Even using the community rules, like the "Seen by Overseer requester & older than 30 days OR not watched by requester and older than 90 days" will populate only with movies requested by myself and none others (can guarantee there are 'eligible' ones)

Enabled debug on the container and only new information that was visible when executing the rule was.
[maintainerr] | 10/07/2024 07:04:06  [DEBUG] [RulesService] Cannot read properties of undefined (reading 'props')

Not sure if relevant.

Hmm, this is an odd one, especially since it works for your own user. Just to be sure, Maintainerr is authenticated with the account that also owns the Plex server, right?
What kind of users are you using within Plex? Normal users, or local users?
And how are your users setup within Overseerr? Are they also using Plex oauth, or are you utilizing local sign in?

Hmm, this is an odd one, especially since it works for your own user. Just to be sure, Maintainerr is authenticated with the account that also owns the Plex server, right?

Correct.

What kind of users are you using within Plex? Normal users, or local users?

While I do have a handful of family members, it is a mixture of both local and true Plex users. The ones that I am concerned about are added Plex users.

And how are your users setup within Overseerr? Are they also using Plex oauth, or are you utilizing local sign in?

Overseer users are setup as part of Plex.

They are using Plex oauth for authentication.
As a side note in answering these questions and maybe you can answer this. These users are NOT friends in Plex. I had simply added them to have access to my Plex server. I had originally had them as friends but removed that. Would that have any impact on this? I am not sure how but could be one caveat that may not be immediately visible. They clearly have access to make requests on overseerr, be visible to overseerr as to who made the request and Plex showing the watch activity, not sure the disconnect otherwise. Thanks.

You don't need to be friends with someone for Maintainerr to fetch them. All users known by the server should be fetchable. Additionally, it shouldn't matter if a user is locally added.
Could you try running the image with the tag 'ghcr.io/jorenn92/maintainerr:main' and enable debug logging? This will, hopefully, provide some extra helpful logs.

You don't need to be friends with someone for Maintainerr to fetch them. All users known by the server should be fetchable.
It does matter for stuff like watchlists. You'll only be able to fetch the list if you've got access to it. So if the user has this set to 'friends only', you can't fetch it.

Makes sense, was just a thought but wasn't convinced.

Could you try running the image with the tag 'ghcr.io/jorenn92/maintainerr:main' and enable debug logging? This will, hopefully, provide some extra helpful logs.

[maintainerr] | 23/07/2024 18:38:07  [INFO] [RuleExecutorService] Executing rules for 'Test'
[maintainerr] | 23/07/2024 18:38:07  [WARN] [RulesService] Couldn't determine if rulegroup with id 4 requires a cache reset
[maintainerr] | 23/07/2024 18:38:07  [DEBUG] [RulesService] Cannot read properties of undefined (reading 'props')
[maintainerr] | 23/07/2024 18:38:07  [INFO] [RuleExecutorService] Execution of rules for 'Test' done.

Seems to make no difference. I am testing a movie that I know has been watched and I know the person who watched it was the requester on overseer.
  sectionResults:
    - id: 0
      result: false
      ruleResults:
        - operator: OR
          action: contains
          firstValueName: Plex - [list] Viewed by (username)
          firstValue:
            - ri*********30
          secondValueName: Overseerr - Requested by user (Plex or local username)
          secondValue:
            - null
          result: false

Overseerr:

Not sure where to go from here but appreciate the help.

Hello, I have the same issues, as per my comment in another open issue:
https://github.com/jorenn92/Maintainerr/issues/1188#issuecomment-2295870706

For what it's worth, I'm seeing the same issue as well.

using version 2.1.2 (docker) and overseer user reuqester is null for all items (it used to work before...)
- plexId: 19195   result: false   sectionResults:     - id: 0       result: false       ruleResults:         - operator: OR           action: contains_partial           firstValueName: Plex - [list] Users that watch the show/season/episode           firstValue:             - <the correct user from plex>           secondValueName: Overseerr - Requested by user (Plex or local username)           secondValue: null           result: false


Advising FAQs

Updating FAQ with a list of typical advising questions with links to UGS resources.
@bhc24 can we make links show up as a different color so there's more contrast on the page? I touched the haml, but wasn't brave enough to dive into CSS (you're welcome).
Also if anyone thinks of any questions that should be added, let me know.

Coverage remained the same at 81.51% when pulling 2eab1bde3f8ee728fbc2f3745a0c79fb3fd53228 on steph-test into e1799f6449170711afeb277b99479b036716f384 on master.

:+1:


Revise privacy policy to talk about "default delta chat onboarding"

The upcoming delta chat 1.46 "create chat profile" view links to the privacy policy of this repository which suddenly talks about "nine.testrun.org" without giving a direct hint why (because it's the default onboarding server for Delta Chat) and which alternatives exist (link to https://delta.chat/en/chatmail".   Other chatmail servers have adapted the start page anyway, so we can just change things here in the repo or make a particular "nine.testrun.org" intro blurb in the jinja templatee.

Fixed by https://github.com/deltachat/chatmail/pull/307


Regular user "skeleto" and he can't run any of yum install or any root privileges
So, I install "zsh" and "oh-my-zsh" as root and setup all. All work fine as root.
Then i run next

[skeleto@olimp ~]$ chsh -s /bin/zsh
Changing shell for skeleto.
Password:
Shell changed.

and when i relog to be sure for apply all, i got this
/home/skeleto/.zshrc:source:68: permission denied: /root/.oh-my-zsh/oh-my-zsh.sh
Any words of wisdom ?

Make sure you have read permissions set for others

Looks to me like $ZSH is being set to /root/ instead of /home/skeleto
Does this persist logout / reboot?

skeleto user .zshrc file look's like this:   export ZSH="/root/.oh-my-zsh"
however skeleto user don't have .oh-my-zsh folder. he only hawe .zshrc file that point as is say in export

Make sure you have read permissions set for others

as root i set:
chmod -R 755 /root/.oh-my-zsh/
i try 777 but no help at all

I think the /root folder doesn't have read permissions by default.

I think the /root folder doesn't have read permissions by default.

worked =)
Thing is that I have done a few changes in the kernel and not sure what exactly caused this if that change was the source of problems.
thanks...

I think the /root folder doesn't have read permissions by default.

worked =)
Thing is that I have done a few changes in the kernel and not sure what exactly caused this if that change was the source of problems.
thanks...

I have the same problem that I cant deal with, would you like to give me some direction?

Look at /root permissions (ls -d /root), the read permissions are probably disabled. You would have to enable them (chmod +r /root), but I recommend instead that, if you want to follow @dmatija's setup, that you install OMZ someplace other than /root (some users choose /usr/share, /opt would also work).


Kanban board set up

https://github.com/HenaryKhuraijam/kanbanBoard/projects/1
There are 2 people in our team.

Hi @Team ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To Highlight 💯

Cards should be assigned to team members in a fair way ✔
All cards with group task in the title should be assigned to someone ✔
Students' board should be a copy of this template boardStudents' board should be a copy of this template board ✔

[x]  Please check the comments under the review.

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me on( @Adebowale ) in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Thank you


Update SDK nuget to 10453

Pick up logging changes to use host name.

Looks straightforward. Go ahead. :shipit:

Creating a new branch to handle the merge conflicts.


Account>Send to Contact>Watermark text truncated on "Amount" field

On Android devices, Watermark text: "Enter amount..." looks truncated when clears amount field on "Send to Contact" screen

-Verified this issue on dev app v1.7.5(295)


C++ / CLI compatibility

Hi,
Thanks a lot for your Dark UI Components library.
I try to use it within a C++ / CLI project in Visual Studio.
I Try to use DockPanel with DockToolWindows
I have created a Form inherited from DarkToolWindow :
public ref class TFrmToolTest : public DarkToolWindow
	{
	public:
		TFrmToolTest(void)
		{
			this->InitializeComponent();
			//
			//TODO: ajoutez ici le code du constructeur
			//
		}
[...]
};

It works fine, In the VS designer, I see my ToolWindow and I can edit it.
My problem :
In my main class (main form), I have created a DarkToolWindow List :
List<DarkToolWindow^>^ ToolWindows;
this->ToolWindows = gcnew List<DarkToolWindow^>();

After that I add a TFrmToolWindow in the list :
this->ToolWindows->Add(gcnew TFrmToolTest());

The runtime error occurs when I try to itterate the list in a for loop to add the ToolWindow to the DarkPanel Components list :
for each (DarkToolWindow ^ toolWindow in this->ToolWindows)
	this->DockPanel->AddContent(toolWindow);   // <- Runtime error

The error is :
System.Collections.Generic.KeyNotFoundException :

I never had this kind of error before and I can't find a solution.
Do you have an idea of the problem ?
Thanks a lot

KeyNotFoundException is raised when you attempt to reference a dictionary entry by a key which does not exist.
The first line of code to reference a dictionary in AddContent() is:
https://github.com/RobinPerris/DarkUI/blob/31603ae561d38898c61c8ee9eefb68916de90a54/DarkUI/Docking/DarkDockPanel.cs#L153
DarkDockPanel automatically generates the following regions when it is instantiated: Document, Left, Right, and Bottom, so I would assume that your TFrmToolTest class does not have a valid DefaultDockArea property set. (A form's initial DockArea value is set by DefaultDockArea)
I'm not sure how this works in C++, but in the C# example the DefaultDockArea is set through the visual designer. The generated code looks like this:
https://github.com/RobinPerris/DarkUI/blob/31603ae561d38898c61c8ee9eefb68916de90a54/Example/Forms/Docking/DockProperties.Designer.cs#L180
Try setting this through the designer or manually in your code. If this does not fix the problem, can you please attach your call stack so I can look in more detail?

Thanks a lot for your help !
Le jeu. 15 août 2019 à 15:05, Robin<EMAIL_ADDRESS>a écrit :

KeyNotFoundException is raised when you attempt to reference a dictionary
entry by a key which does not exist.
The first line of code to reference a dictionary in AddContent() is:
https://github.com/RobinPerris/DarkUI/blob/31603ae561d38898c61c8ee9eefb68916de90a54/DarkUI/Docking/DarkDockPanel.cs#L153
DarkDockPanel automatically generates the following regions when it is
instantiated: Document, Left, Right, and Bottom, so I would assume that
your TFrmToolTest class does not have a valid DefaultDockArea property
set. (A form's initial DockArea value is set by DefaultDockArea)
I'm not sure how this works in C++, but in the C# example the
DefaultDockArea is set through the visual designer. The generated code
looks like this:
https://github.com/RobinPerris/DarkUI/blob/31603ae561d38898c61c8ee9eefb68916de90a54/Example/Forms/Docking/DockProperties.Designer.cs#L180
Try setting this through the designer or manually in your code. If this
does not fix the problem, can you please attach your call stack so I can
look in more detail?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RobinPerris/DarkUI/issues/10?email_source=notifications&email_token=AMLBMPOBRBQNCHAA42EMAUDQEVIBXA5CNFSM4HXXBNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4LX5SQ#issuecomment-521633482,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMLBMPKHKCKIV5AAMZVEUWTQEVIBXANCNFSM4HXXBNRQ
.


Addition of Machine Learning & AI Roadmap

@rishicds Kindly review my PR and assign me this issue...Thanks :)

Assigned


[Bug] Invoice discounts aren't included as line items in the general ledger

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the issue
Missing invoice amounts cause an incorrect profit and loss report, as the profit is inflated by the discounted amount.
Quickbooks supports a percentage-based discount on invoices. This discount is present as a line item in stg_quickbooks__invoice_line, but it is filtered out in the int_quickbooks__general_ledger_balances calculation.
The discount line is filtered out because it has a discount_account_id instead of a sales_*_id or account_id.
WHERE coalesce(invoice_lines.account_id, invoice_lines.sales_item_account_id, invoice_lines.sales_item_item_id, invoice_lines.item_id) is not null

discount_invoice_example.csv
Relevant error log or model output
No response
Expected behavior
I expect the invoice discount to be included in the invoice calculations so that the resulting P&L and balance sheet show the correct values.
dbt Project configurations
using_address: true
using_bill: true
using_credit_memo: true
using_department: true
using_deposit: true
using_estimate: true
using_invoice: true
using_invoice_bundle: true
using_journal_entry: true
using_payment: true
using_refund_receipt: true
using_transfer: true
using_vendor_credit: true
using_sales_receipt: true

Package versions
packages:

package: fivetran/quickbooks_source
version: [">=0.5.0", "<0.6.0"]

What database are you using dbt with?
databricks
dbt Version
Unsure. I tested directly in Fivetran.
Additional Context
I will prepare a PR with a potential fix. It resolves the issue, but I'd like to review it with the team to determine if it's sufficiently generalized.
Edit: PR https://github.com/fivetran/dbt_quickbooks/pull/60
Are you willing to open a PR to help address this issue?

[ ] Yes.
[X] Yes, but I will need assistance and will schedule time during our office hours for guidance
[ ] No.

Hi @SellJamHere 👋 Thanks so much for opening this informative issue.
We had not encountered invoices with discounts before which is why I can see you are currently running into that issue on your end. I also really appreciate your taking the first go at opening the PR to address this issue. You are actually opening this at a great time as @fivetran-avinash is currently working on addressing a number of the open FRs for QuickBooks and this could be a great issue to address in these updates.
I have a feeling we will have more questions and clarifications when reviewing the PR linked above. Thanks again for helping keep our package up to date and you should hear from us in the coming week within your PR!

Thanks @fivetran-joemarkiewicz !

hi, I am having the same problem do you have any timeline to fix this?

Hi @toppare thanks for bumping this issue. We will likely be picking this up in our upcoming sprint (starting mid next week). We will post back here with more details as we work on addressing the invoice discounts.

Thanks for carrying this though, @fivetran-joemarkiewicz ! I'm excited to get back on main 🎉


In QueryInterface::scalar() result no different between value false and no results

Can't differentiate false as "nothing" from false as value.

We can mention in the documentation do not use the method for bool results.

Should be added to phpdoc, yes.


Make internal Google build of manifest2proto rely upon the manifest2proto version in GitHub.

Due to build issues, we're going to rely upon a version of manifest2proto internal to Google while in Google's internal repo. This isn't ideal; we'd like Raksha to depend only on the external version of manifest2proto. This issue tracks getting Raksha always using the external manifest2proto, even when in Google's internal repo.

This enhancement relates to the classic Arcs manifests, which we are deprecating support for.


Unmod

Vector and unlifted array based queues use mod a lot. That seems pricier than you need. Why not just test to see if you're past the end and subtract if so?
Quite separately: what do your benchmark results say?

Good ideas, thanks!


how can  list the  logic Volume of  pvc   in host node ?

Describe the problem/challenge you have
[A description of the current limitation/problem/challenge that you are experiencing.]
[root@node1 ~]# ls /dev/datavg/ -lh
total 0
lrwxrwxrwx 1 root root 7 Dec 27 17:23 pvc-0b6c8388-c194-463d-85f8-188e63697023 -> ../dm-0
lrwxrwxrwx 1 root root 7 Dec 27 17:41 pvc-e72ea418-0890-4cba-83bb-3f419b67da0d -> ../dm-1
[root@node1 ~]# vgdisplay
--- Volume group ---
VG Name               datavg
System ID
Format                lvm2
Metadata Areas        1
Metadata Sequence No  1
VG Access             read/write
VG Status             resizable
MAX LV                0
Cur LV                0
Open LV               0
Max PV                0
Cur PV                1
Act PV                1
VG Size               <1.40 TiB
PE Size               4.00 MiB
Total PE              367001
Alloc PE / Size       0 / 0
Free  PE / Size       367001 / <1.40 TiB
VG UUID               VDNyXE-MqwB-Wt5A-DNhM-fzH4-hdOH-AEy2FZ
[root@node1 ~]# lvdisplay
[root@node1 ~]#
lvdisplay
Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

LVM Driver version
Kubernetes version (use kubectl version):
Kubernetes installer & version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):

@tanguofu can you run pvscan --cache on node to update the cache and then do the lvdisplay.

pvscan --cache

many thanks !

thanks for confirming @tanguofu. Would you like to mention your use case in our adopters(openebs/openebs#2719) file.

Please pay attention to whether this is a better solution @pawanpraka1.


"--shimgen-usetargetworkingdirectory" as default argument

It would be very useful to create executables with --shimgen-usetargetworkingdirectory as default argument. Cause many so-called portable apps expecting the config file in the current working directory. E.g. the executable for Regshot in $env:ChocolateyInstall\bin\Regshot-x64-Unicode.exe can't find the regshot.ini if not executed in $env:ChocolateyInstall\lib\regshot\tools\. So you always have to run $env:ChocolateyInstall\bin\Regshot-x64-Unicode.exe --shimgen-usetargetworkingdirectory to start Regshot. The WOX launcher is another example which creates an image directory in the current working directory. It would be great to have these applications in the $PATH.

Based on some changes happening to the Chocolatey repositories, this issue has been moved from the chocolatey/shimgen repository to the chocolatey/home repository.


mysqli::real_connect() expects parameter 5 to be integer, string given

The configuration for database use to work just fine. suddenly i am seeing this error being thrown under E_WARNING without changing any configuration in the db config file.
I am using codeigniter 3
 mysqli::real_connect() expects parameter 5 to be integer, string given - /var/www/html/project/system/database/drivers/mysqli/mysqli_driver.php:305
Kindly help

@narfbg  Could you help here.

Just remove the quotes around the port in your database config.

@aanbar , as per the /application/config/database, its already an integer and not a string. Not sure why this error.

@aanbar , you are correct, the config file doesn't define a port so i am wondering if the port config is part of the framework definition, should i be getting this error.
The db config is the standard one and yes i do use DNS.
$db['default'] = array(
'dsn'	=> '',
'hostname' => 'hostnameChangeMe',
'username' => 'usernameChangeMe',
'password' => 'passwordChangeMe',
'database' => 'dbChangeMe',
'dbdriver' => 'mysqli',
'dbprefix' => '',
'pconnect' => FALSE,
'db_debug' => FALSE,
'cache_on' => FALSE,
'cachedir' => '',
'char_set' => 'utf8',
'dbcollat' => 'utf8_general_ci',
'swap_pre' => '',
'encrypt' => FALSE,
'compress' => FALSE,
'stricton' => FALSE,
'failover' => array(),
'save_queries' => TRUE
);

I am using CI 3.1.13 and PHP 8.1, the connection works fine but suddenly it shows me this error,
Type: TypeError
Message: mysqli::real_connect(): Argument #5 ($port) must be of type ?int, string given
Filename: /var/www/vhost/unidad.sax.center/system/database/drivers/mysqli/mysqli_driver.php 315
the strange thing is that it is shown in the next part
protected function _execute($sql)
return $this->conn_id->query($this->_prep_query($sql));
}

@joncmc
I was also having the same issue. I ended up hardcoding port number in mysqli_driver.php on line 205

$port = 3306;
		if ($this->_mysqli->real_connect($hostname, $this->username, $this->password, $this->database, $port, $socket, $client_flags))


Actors: decode Pathfinder 1st edition HL portfolio

Based on the PF1 character sheet tabs:
Summary - nothing specific to do on this tab.
Attributes - some of the lower section still to be done.
Combat - all attacks need to be listed.
Inventory - complete (for items available in the PF1 compendium)
Features - complete
Skills - complete
Buffs - nothing to be done here?
Spells - complete (for items available in the PF1 compendium)
Biography - complete
Notes - the statblock
Settings - the correct selection of spellbooks needs to be set.
Feat Changes:
"Simple Weapon Proficiency - All" needs to link to just "Simple Weapon Proficiency"
"Martial Weapon Proficiency - All" needs to link to just "Martial Weapon Proficiency"
"Armor Proficiency (Light)" => "Armor Proficiency, Light"
"Armor Proficiency (Medium)" => "Armor Proficiency, Medium"
"Armor Proficiency (Heavy)" => "Armor Proficiency, Heavy"
"Skill Focus (Bluff)" => "Skill Focus" + adjustment added for the identified skill
"Combat Expertise +/-2" => "Combat Expertise"

Considered complete as of 0.5.0


add storage functions, use phonenumbers

Hey,
because the current implementation of storage.read() or storage.save() do not work well when they run simultaneously i added the storage.smembers() and storage.sadd() capabilities from redis to the RedisStorage and InMemoryStorage classes.
the later is untested, though.
smembers - list the set of stored data
sadd - add item to the end of the existing data
i have a command that fetches content from an website. this takes time.
to make sure a user never receives the same post twice i used to:

storage.read()
do stuff
storage_result.append(new_id)
storage.save()

if the user runs the same command twice in a row it might happen that both coroutines read the same data and only the last one is actually saved.
now smembers and sadd will handle the "append" and this eliminates the race condition.
i also quickly implemented phonenumbers (#29)
EDIT: typo

oh.
and storage.delete() is now a thing.

squashed

smembers() does now return a list instead of a set.
i think this will be more generic.

i donno if this is an antipattern or okay to do it this way.
WDYT?

i decided that the set should be returned as such. :)

Thank you for the PR! Always nice to see contributions from others :)
I understand the need for smembers and sadd in your case but I don't like that the implementation kind of forces other storage technologies to implement those methods now as well. The motivation behind bot.storage is to provide a quick and easy way for the user to store stuff without worrying too much about file handlers, connections, etc. Anything more complicated should be hidden. But it is kind of limited I admit.
What do you think about the following approach: The storage class also provides the public attributes bot.storage.redis and bot.storage.inmemory (as well as any other technology in the future?) so anything more "complicated" can be accessed that way. Depending on the bot configuration, bot.storage.redis will be either None or the Redis instance.

Hey,
Yeah, i was not sure if this would fit the style.
Your approach might be more feasible and would provide the necessary functionality anyway.
i'll update this PR to accommodate this.

this works like this:
seen_posts = c.bot.storage.redis.smembers(storage_key)

c.bot.storage.redis.sadd(storage_key, item["id"])

WDYT?

i have rebased the codebase and updated the deps. :)

see #60


spock 2.1 @Stepwise not work (junit5 issue?)

After transition from spock1 to spock2 @Stepwise functionality is lost (suspect junit4 to junit5 transition)
See spock.lang.StepwiseExtensionSpec.
Try to execute 'step 3'. No 'step 1' and 'step 2' executed at all.
Checked on 1b0b6764 and 5398f5eb

This is not different from Spock 1 though, is it?
Afair @Stepwise always only affected the order, not which tests are executed.

Yes Spock is not different.
But Spock-2xx has moved to junit5 from junit4
I think it is integration problem with junit5.
But @Stepwise is do affect which tests are executed, not the order see javadoc.
" Also notice that if you run a single step (e.g. from the IDE's context menu), all prior steps will also be run."

this is exactly my case

/**

Demonstrates how {@code @Stepwise} causes a spec to be run in incremental steps.
Change a step's condition from {@literal true} to {@literal false}, and observe
how the remaining steps will be skipped automatically on the next run.
Also notice that if you run a single step (e.g. from the IDE's context menu),
all prior steps will also be run.

{@code @Stepwise} is particularly useful for higher-level specs whose

methods have logical dependencies.

@since 0.4
*/
@Stepwise
class StepwiseExtensionSpec extends Specification {

Well, seems that comment is wrong.
If you checkout the spock-1.x branch which is the last commit before switching to Spock 2.x you see that it behaves exactly the same, just as I said. :-)
If this ever worked like mentioned in the comment, then this changed even longer ago.

It's not a Spock 1 vs. Spock 2 issue.
The behavior is identical between spock-1.x branch and master.
If you delegate the test execution in IntelliJ to Gradle, only step 3 is executed.
If you do not delegate test execution in IntelliJ to Gradle, all three steps are executed.
I did a little bisect, this broke with commit https://github.com/spockframework/spock-example/commit/3d454b933453871549d47c8eab383f64d52d6c84 which changed Gradle version from 2.8 to 3.2.1.
So something in Gradle changed that makes this not work any longer.
I narrowed it down further, with Gradle 2.11 it still worked, with Gradle 2.12 it does not work anymore.
I'm transferring this issue to the main spock repository where it belongs.


Feat: Improve the key event functioning for Login

Describe the feature
Currently, if you have enterend an email in the email field and left the password field empty and press the enter key then too the login operation directly executes instead of checking whether the password field is filled or not.......I want to fix this so that proper field validation takes place before going for execution
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@mdazfar2 please assign me this issue

@Asymtode712 you are assigned.


Delete Math.ceil and Math.floor for __ scissorRect.

In cases where the browser scaling ratio is very large, using Math.floor or Math.ceil will result in significant pixel errors, so it needs to be removed.

Old:

New:

@rainyt Can you provide a simple project that reproduces the issue? Thanks!

@rainyt Can you provide a simple project that reproduces the issue? Thanks!

scissor_rect.zip
Yes,sure!
It needs to trigger a problem when the browser zooms in by 500%.

Error render on 500%

Perfect! I can reproduce at 500% zoom in Chrome. Thank you.

Note: I am planning to merge this. I simply haven't had much time to test PRs recently.

Great, I have already used it in the project and tested it on Android, iOS, HTML5, everything is normal.


Obsolete anaconda channel vs conda-forge channel

I’m the main developer of a this package which is on conda-forge since a few years now.
However, years ago, before using the conda-forge channel, some package versions have been uploaded on the anaconda channel (not conda-forge).
The issue is that some new users, who do not pay attention to the installation instructions, are installing the package via conda install XXX instead of conda install -c conda-forge XXX, and are installing obsolete versions...
Is there any way to suppress the packages on the anaconda channel so that we have only the conda-forge channel?

Bumping Anaconda staff for help! (sorry!) @marcoesters @SC426  @mingwandroid @jezdez

@jhillairet Thanks for opening the ticket, I've pinged the internal packaging team at Anaconda about it.

Dear @jezdez , any news from your colleagues ?

@jhillairet I know that @cbouss has added it to the backlog to update, we don't really have a policy to remove packages as-is sadly.


Add uninstall cli command

Co-authored-by: Tim Hardeck<EMAIL_ADDRESS>

I was wondering if uninstalling Carrier should also delete the workloads (the "Jumanji" style undo, everything that happened as a result of Carrier being installed gets reverted). Maybe a "soft" uninstall makes sense, let's see if anyone ever asks for it.

I was wondering if uninstalling Carrier should also delete the workloads (the "Jumanji" style undo, everything that happened as a result of Carrier being installed gets reverted). Maybe a "soft" uninstall makes sense, let's see if anyone ever asks for it.

Heh. and I was wondering if it would the full uninstall (i.e. apps as well) a moment ago, when plotting my test steps, and if I should add an app push to them before doing the uninstall.
The basic plan is, at the moment:

k3s up
scripts/kdump.sh pre-install # dump cluster contents, all resources
carrier install
dump again - post-install
(push app ?)
(dump - post-push ?)
carrier uninstall
dump - post-uninstall
compare the resource lists pre-install vs post-uninstall. Should be same. Except if we do leave apps running.

Heh. and I was wondering if it would the full uninstall (i.e. apps as well) a moment ago, when plotting my test steps, and if I should add an app push to them before doing the uninstall.
The basic plan is, at the moment:

k3s up
scripts/kdump.sh pre-install # dump cluster contents, all resources
carrier install
dump again - post-install
(push app ?)
(dump - post-push ?)
carrier uninstall
dump - post-uninstall
compare the resource lists pre-install vs post-uninstall. Should be same. Except if we do leave apps running.

Note to myself: When this is ready, we should add the uninstall step to the CI pipeline.

Note to myself: When this is ready, we should add the uninstall step to the CI pipeline.

Right now we took the following decisions:

We remove everything from apps to CRDs as if we owned the whole cluster. This may not be what we want, especially when it comes to CRDs (read this to understand why: https://github.com/helm/community/blob/f9e06c16d89ccea1bea77c01a6a96ae3b309f823/architecture/crds.md)
We don't wait until resources are actually deleted. That means an installation can't immediately follow then uninstall step because things are still being deleted even though success is reported from the uninstall command.

Let's see if any of these decisions should be changed based on how Carrier will be used.

Right now we took the following decisions:

We remove everything from apps to CRDs as if we owned the whole cluster. This may not be what we want, especially when it comes to CRDs (read this to understand why: https://github.com/helm/community/blob/f9e06c16d89ccea1bea77c01a6a96ae3b309f823/architecture/crds.md)
We don't wait until resources are actually deleted. That means an installation can't immediately follow then uninstall step because things are still being deleted even though success is reported from the uninstall command.

Let's see if any of these decisions should be changed based on how Carrier will be used.


Retrieve user who deleted message(s)

Add new action:
This features can be include in the GuildAuditLogs:
const Actions = {
  MESSAGE_DELETED: someNumber,
 //other actions that already exists
};

Further details:

discord.js version: v7.10.0 (unrelated)
node.js version: 4.6.1 (unrelated)
Operating system: Linux 4.11.2-1-ARCH (unrelated)
Priority : Feature request
File : https://github.com/hydrabolt/discord.js/blob/stable/src/structures/GuildAuditLogs.js#L94

Already a thing on 11.1-dev: https://github.com/hydrabolt/discord.js/blob/11.1-dev/src/structures/GuildAuditLogs.js#L116

Will this be push to stable anytime soon?

Whenever 11.2 lands on stable. We usually don't give estimates.

@iCrawl that site gives me a 404, any alternatives now?

Yea like mentioned, its already implemented.


Restore log coverage along with misc niceties

Problem
https://github.com/anza-xyz/agave/pull/1260 temporarily disabled coverage for logging
Summary of Changes
Restore it along with some other (opinionated) niceties while we're at the file.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.8%. Comparing base (af6930d) to head (d91332e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1328     +/-   ##
=========================================
+ Coverage    81.6%    82.8%   +1.2%
=========================================
  Files         867      867
  Lines      368900   368900
=========================================
+ Hits       301052   305592   +4540
+ Misses      67848    63308   -4540

@@            Coverage Diff            @@
##           master    #1328     +/-   ##
=========================================
+ Coverage    81.6%    82.8%   +1.2%
=========================================
  Files         867      867
  Lines      368900   368900
=========================================
+ Hits       301052   305592   +4540
+ Misses      67848    63308   -4540

hehe, coverage increased +1.2% treewide. :)

I'm still a little bit confused that why we need trace level log for CI env but I'm neutral about this one.

Happy to elaborate a bit. :)
Firstly, this improves coverage like this:

In this way, it's convenient for human to spot any red lines in prs by eyes thanks to fewer redlines both when developing and code-reviewing.
Also, as we uncovered #1290, logging code isn't generally well tested. so, it's desirable for our ci to run the logging code as much as possible (currently indirectly; admittedly this is overloading the coverage step, like the nightly-only frozen-abi tests). In this way, we can avoid finding these painful panics when debugging urgent issue in production with RUST_LOG=trace.
Lastly, to be explicit, i made trace log output not to be uploaded to buildkite, unlike the previous behavior.

thank you!


perf: use NatPow Int instead of HPow Int Nat Int

This modification improves the performance of the example in issue #4861. It no longer times out but is still expensive.
Here is the analysis of the performance issue: Given (x : Int), to elaborate x ^ 1, a few default instances have to be tried.
First, the homogeneous instance is tried and fails since Int does not implement Pow Int. Then, the NatPow instance is tried, and it also fails. The same process is performed for each term of the form p ^ 1. There are seveal of them at #4861. After all of these fail, the lower priority default instance for numerals is tried, and x ^ 1 becomes x ^ (1 : Nat). Then, HPow Int Nat Int can be applied, and the elaboration succeeds. However, this process has to be repeated for every single term of the form p ^ 1. The elaborator tries all homogeneous HPow and NatPow instances for all p ^ 1 terms before trying the lower priority default instance OfNat.
This commit ensures Int has a NatPow instance instead of HPow Int Nat Int. This change shortcuts the process, but it still first tries the homogeneous HPow instance, fails, and then tries NatPow. The elaboration can be made much more efficient by writing p ^ (1 : Nat).

This seems to have been an oversight in #2778, and it should have become a NatPow Int instance then.
Mathlib adds a default Pow instance for monoids, which is used instead of this HPow Int Nat Int instance. I suppose that hid the performance issue?


CLI command to visualize raw data with spikes

For example, phy traces myfile.dat --n-channels=120 --spike-samples=myspikes.txt
(other formats like .npy or .kwik can also be supported for the spikes)
Requires #458 and #427.

And as a really useful extension, could it try to perform spike detection on just the segment you're looking at and highlight the spikes? It could be a smaller/simpler version of detection, since you just need the masks really.
As an extension on that, snippets to change the detection parameters, with immediate re-detection of the viewed segment?
Ideally it would incorporate a way to jump around the file, e.g. with a snippet.


2FA: Document the 2FA work before merging to main

There should be a separate README for 2FA before moving this work to main and publishing it.

For reference: Initial work on 2FA was done in this PR: #81


Misplaced computer [Cheyenne System, Washakie planet]

There is a floating computer on Whashakie, Cheyenne system.
Details

Game Version
<IP_ADDRESS>
New Game
Yes
Reproduction Steps
Go to Washakie planet in heyenne system. Computer is upstair, near the landing pad of an Ore processing plant.
Position : -800 / 900 / 11

This terminal belongs to a robot pod, which can sometimes go invisible along with other surface objects. This requires an engine fix.


[chaotic-good] Chaotic-good connection setup (connector and listener).

This PR contains the new client connector and server listener of Chaotic-good transport. Design at doc.

I've made some fixes in #35607, specifically addressing the metadata issue I pointed out, ensuring multiple types are refcounted using only one of RefCountedPtr or shared_ptr (these cannot be mixed on the same type), implementing the listener API so that the server code can manage listener lifetime, and attempting to remove asserts on read paths from the network as these always constitute a security vulnerability, and addressing some memory leaks by moving code over from chttp2, oh and ensuring event engine shuts down to avoid dangling objects beyond test lifetime.
There's still significant flakiness in that pr due to some more memory lifetime issues that need to be addressed before it's in a state that it can be considered for submission. I will try to look today, but should anyone have any insights prior I'd be happy to take patches against #35607.

Thanks Craig for the fixes! I discussed the flakiness issue with Vignesh, and push a fix of the connector memory leak at: https://github.com/grpc/grpc/pull/35448/commits/d5dbee98b89d4fbf2bd23047d66155c40ffd5bb0, which mainly add methods to destroy connect_activity_ if it's pending. Hope this could also fix the flakiness issue in your pr.
In the meanwhile, I could continue on the ChaoticGoodCredential setup part, what do you think?


[Optimize] lazy init GetMessageResult only when find message.

Avoid unnecessary object allocation when getMessage.
GetMessageResult will create double ArrayList with 100 initialCapacity.
the pullBatchSize in consumer is 32 which means in default config. the 100 initialCapacity is unnecessary.
And when message is not found. the allocation is also can be avoided.
see
https://github.com/apache/rocketmq/blob/538b6b7ffd5ec0f98dc902a376d65d957143dcf8/store/src/main/java/org/apache/rocketmq/store/GetMessageResult.java#L24-L35
https://github.com/apache/rocketmq/blob/538b6b7ffd5ec0f98dc902a376d65d957143dcf8/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java#L539-L565

pr #3374 submitted.


remove redundant group labels and group size

we currently show the group name and size in the label column.

as this is redundant (mentioned by @alexsb multiple times), we can remove it in the label column and only show a few representatives.
the only problem is that the overview at the moment does not show group labels for stratified columns. however, this will be fixed in #472 and/or #473.

It might be good to have a separate Group size column. This would allow to sort the groups by size and maybe even to filter out groups (e.g., only keep groups of at least 10 entities).

Looks great! Also the possibility to sort it by group size is very useful.

We can now remove the group size from the stratifying categorical attribute.

This is so much better now!

Yes, it looks much better. I suggest to have a small padding left for categorical boxes.

@thinkh, I agree. Can you please go ahead and take care of this?
Btw, in the future we could the font color depending on the background (switch between black and white).


Enable "strictNullChecks": true everywhere

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[ ] Chrome version XX
[ ] Firefox version XX
[ ] IE version XX
[ ] Edge version XX
[ ] Safari version XX

Library version

Library version: 1.2.0-beta.3

Current behavior
I discovered a bug where UserAgentApplication.buildIDTokenRequest was receiving an undefined AuthenticationParameters object and failing at runtime. On further investigation I could not comprehend how the calling code could compile because in the scope of the calling code the request parameter is optional. I then realised strictNullChecks was not enabled on the codebase. After enabling strictNullChecks the codebase is littered with compiler errors too numerous to be listed here.
Expected behavior
The code should compile with strictNullChecks enabled.
Minimal reproduction of the problem with instructions
Enable strictNullChecks in the base tsconfig.base.json, open the project in VSCode and see the red wiggly lines all over the place.

@freshtonic Thanks for the issue, didn't realize that was disabled, I'll definitely take a look.

Is there any update on this bug? Will it be fixed? Thanks.

@ab0nent We haven't had a chance to get to this, but we will at some point soon.

We are working on this in the background, since some of the code needs to be rewritten or needs additional checks, we are taking an incremental approach. This will be updated once we have everything in place. FYI for future libraries, we are enabling this from the start.

Closing as this will no longer be picked up for version 1.x. This work will be done in 2.x, the first part of which has been started in #2602


Ctrl+Z & Ctrl+Y don't work

Describe the Bug
Ctrl+Z & Ctrl+Y don't work. The toolbar buttons do work.
Steps to Reproduce
Steps to reproduce the behavior:

Model something
Try to und with Ctrl+Z
Undo with toolbar button
try to redo with Ctrl+Y
Redo with toolbar button

Expected Behavior
All keyboard shortcuts work as advertised in the menu.
Environment
Please complete the following information:

OS: Ubuntu 18.04.2 LTS
Zeeber Modeler Version: zeebe-modeler-0.6.2-linux-x64

Upstream bug https://github.com/camunda/camunda-modeler/issues/1218 got fixed with the latest Camunda Modeler beta release.

Perfect, thank you!

Should be fixed in next nightly.


Add Kotlin utility functions for Spring RowMapper SAM conversions

Coverage remained the same at 100.0% when pulling 37e8e8cacb510b8f9d741ae8e79c1a0fc9fdcef7 on jeffgbutler:kotlin-improvements into 04dd80f0cedb8dcbb333727995f93538af6f81ff on mybatis:master.


Clarify that mstatus.FS is still visible when writable misa.F bit is cleared

Clearing misa.F does not cause mstatus/sstatus.FS to disappear.  The state bits are still visible.  Needs to be added to spec.

Interesting - do you know if the SAIL model  models that?
And... why?
This goes back to an earlier discussion about WARL bits : if the condition
for legality of a WARL field is dependent on the state of some other CSR
bit, and that state bit changes to make it illegal - and then legal again -
must the old state be retained?
Is this true for all WARL fields that are conditional, or is it

implementation defined, or is it
case by case or is it
implementation defined case by case?

In this example the "appearance" of the bits  is dependent on
(RW(misa.F)) | misa.F=1)  && ~Zfinx, rather than
(misa.F=1)  && ~Zfinx. (where ~appearance
means RdOnly 0)
This is a general issue that the formal model would much rather handle
uniformly...
I'm also trying to figure out if this simplifies or complicates the config
YAML description.
On Fri, Jul 3, 2020 at 2:23 AM Krste Asanovic<EMAIL_ADDRESS>wrote:

Clearing misa.F does not cause mstatus/sstatus.FS to disappear. The state
bits are still visible. Needs to be added to spec.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/534, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJSRVKESVWDDH4RK2PTRZWPQDANCNFSM4OPUOZEA
.

The manual says that FS is WARL.  It seems inconsistent with the spirit of WARL to allow it to be non-zero when misa.F=0.
Because misa.F is controllable only by M mode and FS is visible to S mode via sstatus.FS, is there a virtualization problem when M mode tries to present the SEE as a non-F implementation?
Does this new requirement provide value to the overall architecture or is it to accommodate an existing implementation that behaved in this way?

This "FS" case seems analogous to the situation with the H extension.
Before the H extension comes along, certain CSR bits and fields are defined
as WPRI, WARL, or 0's.  Then the H extension gives functional meanings to
these bits.  But when misa.H=0, all those bits are supposed to appear as if
the H extension was not implemented (i.e. as 0's and not as whatever last
values they held when misa.H=1).
Treating FS differently when misa.F=0 would be inconsistent, but obviously
the arch spec could choose to officially and clearly make this exception
and define FS accordingly.
Greg
On Fri, Jul 3, 2020 at 12:07 PM Paul Donahue<EMAIL_ADDRESS>wrote:

The manual says that FS is WARL. It seems inconsistent with the spirit of
WARL to allow it to be non-zero when misa.F=0.
Because misa.F is controllable only by M mode and FS is visible to S mode
via sstatus.FS, is there a virtualization problem when M mode tries to
present the SEE as a non-F implementation?
Does this new requirement provide value to the overall architecture or is
it to accommodate an existing implementation that behaved in this way?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/534#issuecomment-653653178,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALLX6GQJKNRZA6J3PNNMWBDRZYT55ANCNFSM4OPUOZEA
.

I think the cleanest way to think of mstatus.FS bits when misa.F is 0
is as an extension (Zffs??) that supports FP emulation.  This
extension is implied with F extension, so is always present when
misa.F is 1.
This new extension does not (currently) have a standard way of being
turned off if supported.
Krste

On Fri, 03 Jul 2020 13:10:58 -0700, gfavor<EMAIL_ADDRESS>said:

| This "FS" case seems analogous to the situation with the H extension.
| Before the H extension comes along, certain CSR bits and fields are defined
| as WPRI, WARL, or 0's. Then the H extension gives functional meanings to
| these bits. But when misa.H=0, all those bits are supposed to appear as if
| the H extension was not implemented (i.e. as 0's and not as whatever last
| values they held when misa.H=1).
| Treating FS differently when misa.F=0 would be inconsistent, but obviously
| the arch spec could choose to officially and clearly make this exception
| and define FS accordingly.
| Greg
| On Fri, Jul 3, 2020 at 12:07 PM Paul Donahue<EMAIL_ADDRESS>| wrote:
|| The manual says that FS is WARL. It seems inconsistent with the spirit of
|| WARL to allow it to be non-zero when misa.F=0.
||
|| Because misa.F is controllable only by M mode and FS is visible to S mode
|| via sstatus.FS, is there a virtualization problem when M mode tries to
|| present the SEE as a non-F implementation?
||
|| Does this new requirement provide value to the overall architecture or is
|| it to accommodate an existing implementation that behaved in this way?
||
|| —
|| You are receiving this because you are subscribed to this thread.
|| Reply to this email directly, view it on GitHub
|| https://github.com/riscv/riscv-isa-manual/issues/534#issuecomment-653653178,
|| or unsubscribe
|| https://github.com/notifications/unsubscribe-auth/ALLX6GQJKNRZA6J3PNNMWBDRZYT55ANCNFSM4OPUOZEA
|| .
||
| —
| You are receiving this because you authored the thread.
| Reply to this email directly, view it on GitHub, or unsubscribe.*

That is part of my question.
Is the state

retained (so it will read as zero, but when MISA.F is set again the previous state reappears?
(And what happens if it is written? Does it overwrite the hidden state or just ignore the write)
-or retained and visible (same question as above - what happens with writes)

-Allen

On Jul 3, 2020, at 1:10 PM, gfavor<EMAIL_ADDRESS>wrote:
This "FS" case seems analogous to the situation with the H extension.
Before the H extension comes along, certain CSR bits and fields are defined
as WPRI, WARL, or 0's. Then the H extension gives functional meanings to
these bits. But when misa.H=0, all those bits are supposed to appear as if
the H extension was not implemented (i.e. as 0's and not as whatever last
values they held when misa.H=1).
Treating FS differently when misa.F=0 would be inconsistent, but obviously
the arch spec could choose to officially and clearly make this exception
and define FS accordingly.
Greg
On Fri, Jul 3, 2020 at 12:07 PM Paul Donahue<EMAIL_ADDRESS>wrote:

The manual says that FS is WARL. It seems inconsistent with the spirit of
WARL to allow it to be non-zero when misa.F=0.
Because misa.F is controllable only by M mode and FS is visible to S mode
via sstatus.FS, is there a virtualization problem when M mode tries to
present the SEE as a non-F implementation?
Does this new requirement provide value to the overall architecture or is
it to accommodate an existing implementation that behaved in this way?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/534#issuecomment-653653178,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALLX6GQJKNRZA6J3PNNMWBDRZYT55ANCNFSM4OPUOZEA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

FS is orthogonal to the F extension. Hence, misa.F doesn’t govern whether it’s readable or writable.
There is already precedent for FS existing even when the F extension isn’t implemented. The spec mandates that FS be implemented if S-mode is implemented, irrespective of the F extension.
Inversely, there is also already a proposal for FS to be hardwired to zero even when the F extension is implemented (Zfinx).
I suppose I agree with Krste that FS could be formalized as a separate extension.

Wouldn't emulating FP (whether an extension or part of the base architecture) also require instructions such as FADD.S to trap?
If misa.F=0, accesses to fcsr/frm/fflags must trap per section 2.1 of the privileged spec but the behavior of reserved instructions is very explicitly UNSPECIFIED in section 2.2 of the unprivileged architecture.  Nowhere is that latter statement amended by the privileged architecture.
I considered that perhaps FADD.S is an unimplemented "standard" instruction rather than a section 2.2 "reserved" instruction but two things argue that it is still not required to trap.  One is that the privileged architecture seems to reenforce the notion that instructions in unimplemented extensions don't have to trap:

SRET must be provided if supervisor mode is supported, and should raise an illegal instruction exception otherwise.

The use of the word "should" must be taken as a suggestion, especially when it is obvious that this word was carefully chosen over the word "must" that appears earlier in the same sentence.
The other, more compelling argument is that the general philosophy of RISC-V is that anything that is unstated is unconstrained and nowhere is the behavior of unimplemented standard or custom instruction encodings constrained.

It is a obvious that, if FP is not in HW and it’s emulation is required, then all FP opcodes must trap.
There was a long discussion about how a profile must separately specify whether FP  is required, and whether FP HW is required. If HW is not required, then it implies that

Mmode code must never use/rely on FP ops and
an implementation would be considered compliant to that profile if either MISA.F is 1, or all FP ops trapped properly.

Note that compliance has no current way to make that differentiation, the formal model has not been updated to allow traps of specific undefined opcodes, and profile descriptions are few and far between and also don’t make that differentiation.
-Allen

On Jul 4, 2020, at 9:34 AM, Paul Donahue<EMAIL_ADDRESS>wrote:
Wouldn't emulating FP (whether an extension or part of the base architecture) also require instructions such as FADD.S to trap?
If misa.F=0, accesses to fcsr/frm/fflags must trap per section 2.1 of the privileged spec but the behavior of reserved instructions is very explicitly UNSPECIFIED in section 2.2 of the unprivileged architecture. Nowhere is that latter statement amended by the privileged architecture.
I considered that perhaps FADD.S is an unimplemented "standard" instruction rather than a section 2.2 "reserved" instruction but two things argue that it is still not required to trap. One is that the privileged architecture seems to reenforce the notion that instructions in unimplemented extensions don't have to trap:
SRET must be provided if supervisor mode is supported, and should raise an illegal instruction exception otherwise.
The use of the word "should" must be taken as a suggestion, especially when it is obvious that this word was carefully chosen over the word "must" that appears earlier in the same sentence.
The other, more compelling argument is that the general philosophy of RISC-V is that anything that is unstated is unconstrained and nowhere is the behavior of unimplemented standard or custom instruction encodings constrained.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

'It is a obvious that, if FP is not in HW and it’s emulation is required, then all FP opcodes must trap."
It is also related to vector-extension FP instructions.
If there is an RV64IMACV core, any vector FP instructions should trap no matter what FS is

Ah: if the vector-scalar opcodes are not optional in the base V-extension
spec, and ZFinx is not imnplemented (which would then require the presence
of FP-regs) then that would be the case. If neither of those conditions
hold, or if it is a requirement than the F or D extensions are required,
then the above core type isn't even legal.
On Fri, Jul 10, 2020 at 9:43 AM Rolfy360<EMAIL_ADDRESS>wrote:

'It is a obvious that, if FP is not in HW and it’s emulation is required,
then all FP opcodes must trap."
It is also related to vector-extension FP instructions.
If there is an RV64IMACV core, any vector FP instructions should trap no
matter what FS is
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/534#issuecomment-656772796,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJXLW4BJPEDP7GFPC3TR25AJ5ANCNFSM4OPUOZEA
.

The spec mandates that FS be implemented if S-mode is implemented, irrespective of the F extension.

Is this a sufficient resolution, or is the scope here that FS should have a way to exist in non-S-mode-supporting implementations?  If the latter, then the proposal here is not that a "clarification" is required, but that an extension is needed?

I'm not sure what it means for FS (as subfield of mstatus) to be
implemented without F extension.
Does that mean it won't trap if accessed (the usual meaning of
"implemented" for an entire CSR)?
(that's a rhetorical question)
Does it mean that it must be RW, and not RdOnly0?
Is it expected that any other extension might cause the value of mstatus.FS
to change without F-extension being implemented?
On Tue, Aug 10, 2021 at 11:39 AM Joshua Scheid @.***>
wrote:

The spec mandates that FS be implemented if S-mode is implemented,
irrespective of the F extension.
Is this a sufficient resolution, or is the scope here that FS should have
a way to exist in non-S-mode-supporting implementations? If the latter,
then the proposal here is not that a "clarification" is required, but that
an extension is needed?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-isa-manual/issues/534#issuecomment-896224936,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPXVJXX2JR33XLVZPV4HN3T4FW6NANCNFSM4OPUOZEA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@allenjbaum In this context, "implemented" means "not hardwired to 0".


Added symbol node kind. [phab:D1733]

Created by craigbarber at 2017-06-23 18:16:42:
Modified the schema definition to include a new node kind "symbol".
Also modified the java analyzers shared enums to include the new kind.

danielmoy-google commented inline (context lost during migration) at 2017-06-23 18:23:58:
is there one extra newline in here?  (idk if we even care about that sort of thing)

zarko commented inline (context lost during migration) at 2017-06-23 18:24:16:
Brief description::
  A *symbol* is a common name used by tools to refer to a set of objects.
  The rules for binding a symbol to a particular object from this set may depend on
  external configuration (such as the list of libraries being linked together to produce
  an executable).
Naming convention::
  Language:::
    No special rules (though see below).
  Path:::
    *empty*
  Root:::
    *empty*
  Corpus:::
    *empty*
  Signature:::
    No special rules.

The languages `ia64` and `jvm` are reserved.

fromberger commented inline (context lost during migration) at 2017-06-23 18:26:13:
We don't care too much as long as asciidoc still works. :) But I try to keep the format consistent so that kythe/go/util/tools/extractschema will continue to work (though we can also fix the tool if we change conventions).

craigbarber wrote at 2017-06-23 18:30:43:

incorporated review feedback

fromberger commented inline (context lost during migration) at 2017-06-23 18:45:21:
zarko: Do we want to reserve these here, or as top-level language labels? I think the latter, but maybe you have something else in mind?

zarko wrote at 2017-06-23 20:46:07:
Good point--let's strike the "The languages ia64 and jvm are reserved." line and deal with those languages in a different diff.

zarko wrote at 2017-06-23 20:47:28:
(accepted modulo removing the line)

zarko accepted this revision at 2017-06-23 20:47:28

craigbarber wrote at 2017-06-23 20:51:36:

incorporated review feedback

craigbarber closed via commit 880c03d4425bed357cbc7642bcab0b2125754cfc at 2017-06-23 20:52:52


Estimated delivery date fix

Estimated delivery date labels now display the proper estimated delivery date.

also, if you keep the force unwrap, you're going to have to disable linting there!

@theginbin @stephencelis  g2g?


Fix compilation error when HWY_COMPILER_GCC_ACTUAL < 1300

This issue is caused by hwy::ConvertScalarTo called in EmbeddingScaling. The comment on EmbeddingScaling said that it's for rounding the float to bf16 to match Gemma's Embedder. It calls this version of the template function:
template <typename TTo, typename TFrom, HWY_IF_BF16(TFrom),
          HWY_IF_NOT_SPECIAL_FLOAT(TTo)>
HWY_API HWY_BF16_CONSTEXPR TTo ConvertScalarTo(TFrom in) {
  return static_cast<TTo>(F32FromBF16(in));
}

When HWY_COMPILER_GCC_ACTUAL < 1300 and there is no built-in function __builtin_bit_cast, It will not be constexpr. However, constexpr attribute of EmbeddingScaling only follows Sqrt, which may cause compilation errors. So I open this PR to fix it.

Thanks, maybe related -
https://github.com/google/gemma.cpp/pull/119#discussion_r1541089132


Sign in credentials appearing in Chrome

They will not leave if clicked on or ignored. This is happening in student view.
I had Schweta clear her cache, and try resigning into Moodle. The issue persisted. IT does not seem to happen to her in Firefox.

Did anybody solve this issue? 🤔

I think we did resolve this, so it may be a configuration issue for your setup -- can you describe how you're deploying either the CTS or the cmi5 Player @bekiomonov ?

@vbhayden Here's my config for cmi5 Player:
HOST_PORT=63398
CONTENT_URL=http://<IP_ADDRESS>:63398/content
API_KEY=dae668d8f916a6223fe0257c30a8303f9552729fb625b998fc779565aa089396
API_SECRET=67a0e2e2f54858f7fe04ef9e85fc8c34d359011738b738ef58c4ef36cec6cbbc
TOKEN_SECRET="some random string"
LRS_ENDPOINT="http://host.docker.internal:80/my-lrs/xapi"
LRS_USERNAME="username"
LRS_PASSWORD="password"

CTS:
HOST_PORT=63399
PLAYER_HOST_PORT=63398
PLAYER_CONTENT_URL=http://<IP_ADDRESS>:3398/content
PLAYER_KEY=dae668d8f916a6223fe0257c30a8303f9552729fb625b998fc779565aa089396
PLAYER_SECRET=67a0e2e2f54858f7fe04ef9e85fc8c34d359011738b738ef58c4ef36cec6cbbc
PLAYER_TOKEN_SECRET="some random string"
LRS_ENDPOINT="http://host.docker.internal:80/my-lrs/xapi"
LRS_USERNAME="bekiomonov"
LRS_PASSWORD="bekthebest"

However, I'm testing my own course generated in Articulate. For LRS I'm using "LRS Lite" from Veracity Learning.
Description of the issue: As soon as I refresh launched course (on a separate tab) it asks me to Sign in:

I have no idea what username and password to put. I try to sign in with account created for CTS, but it gives me an error:

Thanks!)


Filter out spam messages

Currently all messages received from any routing tag are output in the message window tagged with the nickname of the person you think you are chatting with. This means someone other than the person you are chatting to can send you a message which will look like it's from the person you think you're chatting to.

Fixed by ensuring that packets received from unexpected routing tags are dropped.


Need a way to manage deps per mapping

Many users will likely not want to install every single dependency if they want only one specific mapper.  Not sure if there is an easy solution regarding automatic dependency installation via setup tools.

http://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies


Unable to create non-existent notes successfully with 'jottem edit'

Using jottem edit {path/to/note/that/doesnt/exist} returns various errors (depending on first run or subsequent runs)

However it looks like the note is still created, but is inaccessible by Jottem

Deleting .cache/jottem appeared to make no difference, and I could still re-produce the above:

This was done on WSL2 Ubuntu 20.04

I suspect this is due to utils::get_note() calling utils::create_note(), both of which call Index::open(), resulting in an IO lock error.

Hotfix pushed to main.
Keeping this open until a "proper" fix is in place.

Closing this as solved with the hotfix. Refactor incoming before the next release to make testing easier and more robust.


Create a Rust project managed with cargo

Added a single file to print out "Hello, GRN world!".

I started a new pull request that incorporates the changes you requested


Cannot get directory listing

Kodi 18.4, plugin.video.netflix 0.13.23, Windows 10.
ERROR: Unable to find plugin
ERROR: XFILE::CDirectory::GetDirectory - Error getting plugin://
ERROR: CGUIMediaWindow::GetDirectory(plugin://) failed

Nevermind, I went to https://github.com/CastagnaIT/plugin.video.netflix and fixed it.


Bump symfony translation to 4

Hey,
Is it possible to bump the translation version to 4?

+1 for this, can't use with Laravel 5.6

Done!

Thank you very much!

Thank you.


Update SECURITY.md with a process

Add SECURITY text inspired by @elsehow
Much of this was originally in https://github.com/CosmWasm/cw-plus/pull/581
Happy if @alpe and/or @webmaster128 can double check the process defined.

I think I addressed all concerns. Please let me know if there is more to do.
And we can release SECURITY.md in other repos that refer to this.

@webmaster128 can I get another review here?


Customize the logout screen

Previously, logging out of a CAS service would show a logout screen with a link to log back in. The login link would have knowledge of the originating service. In other words, users would be able to log back in to the service they just logged out of.
Currently, the logout screen does not allow you to log back in to the original service:
https://login.bloomington.in.gov/cas/logout

We should customize the logout screen.  The one that's displayed, currently, is the default.


Bootstrap won't work when loaded in Head visited from non-bootstrap page

Go to https://bootstraperror-ijijmtupiv.now.sh/
Click link
Now the dropdown doesn't work.
Press F5 and it will.
Source:
https://zeit.co/hrronnie/bootstraperror/ijijmtupiv/source
PS: If anyone has jQuery and Bootstrap working by using import, I would very much like to see how.

Try https://github.com/reactstrap/reactstrap
It's Bootstrap 4 for React and

The library does not depend on jQuery or Bootstrap javascript

If you open the console you'll also see an error: Uncaught Error: Bootstrap's JavaScript requires jQuery

I also load jQuery in Head and it works after f5.

@timneutkens The problem is that jQuery should be loaded (and will be if you press f5) as it is in the Head as well

Actually, when navigating from a other page head is loading asynchronously. In this case, try to use jQuery and Bootstrap globally on all pages.
Otherwise use a better pure JS/React alternative.

@arunoda Thanks - I don't want to bloat the starting page with those libraries. I will try reactstrap
I think this is worth mentioning somewhere. (perhaps it is and I missed it :-/ ) because bootstrap is used by many..


[BUG] Setup JIT-Less Cert doesn't work even with SideStore install

Describe the bug
When installing via Sidestore it doesn't work with JITless
Instructions to reproduce
When I installed Sidestore then installed Livecontainer via sidestore I receive the error upon enabling JIT-less certificate install
"Failed to find certificate data. Refresh app in Sidestore/AltStore and try again" I have tried refreshing and reinstalling and installing via Altstore with no avail.
What version of LiveContainer are you using?
https://github.com/khanhduytran0/LiveContainer/actions/runs/11026742908 this version.
Other info
No response

IOS 18 on iPhone 12 if that matters.

I will try that thank you

This works thank you.


Expand parameter explanations

Is it possible to add explanations what each parameter means?
What is blur?
What is minOpacity?
What is intencity?

What is blur?
What is minOpacity?
What is intencity?
can you tell me?


Lint: unused declatations

Lint marks every single field injected with butterknife as unused
@Bind(R.id.requestlist) ListView list;

and every method with @OnClick annotation
@OnClick({ R.id.btn_deny, R.id.btn_confirm }) public void myClick(View v) {
    switch (v.getId()) {

      case R.id.btn_deny: {

      }
      break;
      case R.id.btn_confirm: {

      }
      break;
    }
  }

I did include androit-apt plugins as suggested here https://github.com/JakeWharton/butterknife/issues/356

This is fixed in the forthcoming next version where the runtime and compiler are separate and the generated code will be visible to the static analysis.


ChangeTracker.AcceptAllChanges not called

Hi,
I have implemented a ChangeTracker (derived from the standard one) that does auditing on entities, but ChangeTracker.AcceptAllChanges never gets called. I suspect that its StateManager instance gets called directly bypassing ChangeTracker...
Bert
Further technical details
EF Core version: 2.1.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: VS Enterprise latest

@amoorthaemer ChangeTracker is a facade class that just provides an API over the services that implement the operations.
Note for triage: We can look into routing the internal call through the ChangeTracker for this and maybe also for DetectChanges, which would allow people to override these. However, the state manager already knows which entries to AcceptChanges on, so it would add work to call the public method and calculate again. Also, IChangeTrackerFactory is internal, so there is currently no public way for an overridden ChangeTracker to be used.

@ajcvickers .... IChangeTrackerFactory is public... therefore I was able to implement my own version which in turn instantiates my own version of ChangeTracker. It works without any issues, except for the ChangeTracker’s overridden methods

@ajcvickers .. Just to inform you ... I'm using overrides for SaveChanges(Async) to circumvent this issue and that will do the job well... Anyway thanks for looking into this
Bert

@amoorthaemer IChangeTrackerFactory is internal in the sense that it is in an Internal namespace and documented as internal. We do this so that people can, at their own risk, work with the internals of EF without having to resort to Reflection, etc. However, API documented as internal may change in a breaking way in any release, so it should only be used in situations where such a break is considered acceptable.

Triage: we decided for now not to make any changes in this area.


When javascript is disabled, most survey sections are inaccessible

Include in the UI review / re-design at later stage.


Would it be possible to provide T4Toolbox as a Nuget package for solutions?

Currently it seems only available as Visual Studio Extension
Note: I am on VS2015

This may be possible. What part of T4 Toolbox would you want to consume as a NuGet package - VS editor extension or code generation extension?

Enough so that the solution will build even if T4Toolbox is not pre-installed I guess this means minimum  code generation extension
It was my impression that making t4 transformation part of the build process was also part of T4Toolbox but I can't find any documentation on that

Today, T4Toolbox works in the built-in T4 host implemented as a file generator. It gets invoked whenever you save a template file in the Visual Studio editor. Historically, this was the first T4 host provided by Visual Studio and it requires a VSIX extension.
Later, Visual Studio added another host, implemented as a MSBuild task. It is possible to use NuGet packages to extend code-generation capabilities provided by this host. However, the two T4 hosts are significantly different and the T4 Toolbox does not support this one.
I also think that NuGet-based distribution would be better, but it requires build-based code generation and a significant modification of the T4Toolbox.dll. Some features, like automatic modification of the project files, is not applicable during build. What features of T4 Toolbox would you want to move to the build-based host?

My concern was using T4Toolbox requiering other developers to need to manual install T4Toolbox on their machines to build the project (and also on buildserver). But in the meantime the project where I planned to use T4Toolbox.dll has been cancelled.


Examples of Https mocking. Whether through java or configured json

Does anyone know where I can get an docs or examples on mocking services via https. There doesnt seem to be any examples on the net?
Would appreciate any feedback.

What about in json ? I faced same problem as @ladams81


Allow overridable method delegation in downstream CompilerOpts implementations

This adds an interposer which allows a CompilerOpts to be implemented as a wrapper around an existing CompilerOpts object and allows the user simultaneously to provide individual method overrides only where desired.  This allows the interface for CompilerOpts to grow and change without imposing as much on downstream implementations.  CompilerOpts provides file reading (and writing and file dates in the module system pr) which are used to delegate these functions in uncommon scenarios such as when we want to test how the compiler reacts to the presence or absence of files, or collect multiple outputs without writing to disk.  The HasCompilerOptsDelegation trait has methods which provide default implementations for every method of CompilerOpts, but which the user can replace when they implement HasCompilerOptsDelegation.  Having HasCompilerOptsDelegation automatically gives one a trait implementation for CompilerOpts which uses those overrides.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

104 of 171 (60.82%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 82.814%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/compiler/comptypes.rs
104
171
60.82%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
15044

Relevant Lines:
18166

💛  - Coveralls


generalizedGroupBy with reflection

the release 0.4.0 breaks following template because "where" returns now a generic interface{} and "groupBy" expects []*RuntimeContainer
{{ $containers := where $ "Env.Filter" "true" }}
{{ range $host, $containers := groupByMulti $containers "Env.VIRTUAL_HOST" "," }}

This PR changes the groupBy arguments also to interface{}

Nice work! :+1:
Sorry for the breakage, but it's good to see both the where* functions and the group* functions generalized.

Thanks @webner @md5 !

I opened a new PR with the fixes #101

:+1:


Allow it and pending to be used without blocks

Both it and pending can be used in RSpec without a block. Calling it without a block is a way of specifying that it is pending. I was caught off guard when writing a spec and it failed in both instances because I lacked a block.

pending without a block, yes. it without a block, no.

Is the it overload really required? Why not just use pending everywhere? It's essentially an alias...

it is an alias

@straight-shoota, @RX14 the documented way to mark tests as incomplete in RSpec is to write it "should do something" without the block. I imagine I'm not the only one who'd try to write out a bunch of pending tests via it … and no block and be surprised at a failure.

Yes, but this is not RSpec and Crystal tries to avoid aliases. I guess anyone will be surprised to find out there's no let, before each, etc.

In fairness, @asterite – when I came across no it as pending, the first thing I tried was rewriting it to pending, so I guess most folk's figure it out. 😄
I'll remove the new it signature and push up the changes. Hopefully it'll run this time. Not sure what's up with those failed tests. Looks like they timed out.


Release Google.Analytics.Data.V1Beta version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Analytics.Data.V1Beta-1.0.0-beta01


 missing

Proposal: Add support for Pressable
Summary
It isn't clear that <Pressable /> is missing from react-native-macos.
From node_modules/react-native:

From node_modules/react-native-macos:

From node_modules/react-native-windows:

Motivation
Given RN's push to use this component over Touchable* it seems relevant to include it, perhaps even supporting the hover style functionality. E.g. it would be neat if you could do: <Pressable style={({ hovering }) => styles.hover } />
Basic example
<Pressable><Text>Hello world</Text></Pressable>

and for hover support:
<Pressable style={({ hovering }) => styles.hover }>
<Text>Hello world</Text>
</Pressable>

The Pressable component lives here in react-native-macos, but there hasn't been specific work to cater this control to macOS (e.g. adding hover effects). It's a great point though that having desktop functionality could come in handy.
Can you post the repro steps for how you're generating the node_modules folder in the screenshots for your react-native-macOS project above? It sounds like there are two issues you mention here- one is you're not seeing any Pressable component at all for react-native-macOS when you make a new project and two is you'd like more desktop support built into the component. Does that summarize it or did I misunderstand something?

I followed the exact steps from the "getting started" guide for macOS. I haven't modified my node modules manually. I did add typescript support but i don't see how it relates.
Other yes, that summarizes it. I was really most interested in the Pressable component missing.


Consult China regional market cooperation

Hi, we really hope to introduce your video enhancement technology to the Chinese market, and we look forward to your reply.
<EMAIL_ADDRESS>

Eh, no thanks.


CASMPET-6004: Add validation for checking the user input against etcd

This adds the ability for encryption.sh --enable/disable --aesgcm ... to validate the user input makes logical sense against what is found in the etcd database.
What this means is essentially if a user tries to setup encryption with a key that isn't found in etcd, the script will reject the update as being logically invalid.
This is to ensure that kubernetes secrets can always be read given a specific encryptionn configuration.
Also added switches --status to display the status of encryption.
And added a --restart switch to make restarting the daemonset easier to force updates.
Description
Adds a layer of validation to prevent a user from setting up an encryption configuration that would be invalid or result in existing encrypted secrets from being readable by the kube api server.
Checklist Before Merging

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

Found a race condition if a secret is written when removing encryptino but not all nodes have been updated yet, will update the pr with a fix for this condition.
ncn-m003:~ # encryption.sh --disable --aescbc sutsutsutsutsutssutsutsutsutss
encryption.sh                                                                                100%   24KB  14.0MB/s   00:00
fatal: requested goal conflicts with existing etcd encryption
etcd: aescbc-be59cdb38ed61f468deecaf865643be643201906504dc8f3e85e432d5463d525 identity
requested: identity aescbc-be59cdb38ed61f468deecaf865643be643201906504dc8f3e85e432d5463d525
To fix add the keys that correspond with that encryption secret to the end of this command. Failure to do so would mean k8s cannot read existing secrets.

This should be allowed but my logic is a bit perhaps too strict in my set operations.


Rename Wade Hampton to Kusilvak

trying to solve issue #4

Thanks a lot for the contrib @fatahnuram.
Close issue https://github.com/kelvins/US-Cities-Database/issues/4.


fix: 🐛 Stepper state loop with onChange

The Stepper got stuck in a infinite loop when changing state in parent
component in the onChange prop.

Closes #559

👋 Thanks for creating a pull request! 🚀 Checkout the storybook we've created for it: react


[Technical] [SVS-53] Update packages.config to target net46

Do not merge this yet, until after SL v2.2.

LGTM

This PR has been superseded by PR #85


New icon

The old icon looked way better and, most importantly the current one doesn't support material you themed icons andbjust displays in black/white despite themed icons enabled in the launcher.

Hi,
I had to remake the icon because the old one had pretty bad quality.
I wanted to use vector graphics now so I had to create my own icon.
Forgive me, I'm studying IT Security, I'm not a designer.
I most likely just forgot to add the themed icon again, coming back soon.

Themed icon added back in in Version 1.3.7


avoid Meteor error when createDeepstream

avoid “cannot set timers inside of simulations” which blocks the rest of the watch_page.onRendered function.

@dwanderton mainPlayer wan't getting activate when a new Deepstream was created because Meteor was hitting an error in the onRendered function of watch_page. Effectively, if there are any errors in the console, you can't trust that any subsequent code is actually getting run, so all bets are off on functionality.
![screen shot 2016-05-23 at 3 17 58 pm]
(https://cloud.githubusercontent.com/assets/2604712/15482414/7dc1419c-20fd-11e6-9f0d-6c8e609e9c85.png)
The error in question is a weird one, and it stems from this line. This is here so that when a user clicks Create, they get to the curate page immediately, without waiting for the server to actually create the deepstream. It's a bit of a hack, but I don't know a better way to achieve that (but there might be one!). Since the navigation is taking place within Meteor's client-side simulation, Meteor tries to prevent any side-effects that it can't undo if the server code fails. Hence, the cannot set timers inside of simulations error. We can get around it by just using setInterval instead of Meteor.setInterval. An alternative would be to do the navigation inside of the callback for 'createDeepstream', but then there would be an awkward delay while the roundtrip to the server happens.

Thanks for the excellent review. Have implemented and will test!

Great -- so the error has gone, but mainplayer is still not defined on the window :(

@dwanderton hmmm, on my end, window.mainPlayer is defined when I type it in the console, both when creating a new deepstream and visiting a published deepstream I'm curating. Maybe I don't understand the situation in which it is undefined. Can you provide steps to repro what you're seeing?

Hi Joe,
Pushed the latest changes to timed cards -- still cant get the new elapsed time from the newly instantiate youtube player. onYouTubeIframeAPIReady() only seems to get called once. I've tried to init the window.mainPlayer again when create is clicked -- however there didn't seem to be a way to re-trigger the jsapi for the newly added video. Any thoughts?
Best,
David

I'll take a look. Latest changes were 13 days ago, yes?

btw, onYouTubeAPIReady() only gets called when the script initially loads. No need to reload it just for creating a new deepstream.
https://developers.google.com/youtube/iframe_api_reference
When the api is activated for an individual player, onMainPlayerReady is called because of this block
              var youTubePlayer = new YT.Player(that.mainStreamIFrameId, {
                events: {
                  'onReady': onMainPlayerReady,
                  'onStateChange': onMainPlayerStateChange
                }
              });

on the latest timedcards commit up on github right now, 79fd060fcd2c1c3e94bcd1ac85e5b0bd982f78e3 , I can get elaspedTime just fine. That's right after we applied the fix.
on http://deepstaging-timecards.herokuapp.com/ I cannot. does that have any commits that aren't pushed to github?

Hi Joe,
Please check github now

seems like its working 👍


Hopefully fixed the problem with the weird names by using a id

Proof:

@Wissididom Can you go into more details about this fix?

What is the issue this is fixing?
Is catch <pokemon_id> optional or a hard replacement for names? Can you still guess names?
Is this meant to be a optional game mode (guess id instead of name)?

This fixes the problem, that pokemon[0].split('-').toLowerCase(); didn't work for some pokemon because i use the id at getting the names
This is optional because i just added the id as an additional language, you can still guess in english and other languages:

Thanks @Wissididom and one more question. In the scenario where the Pokemon name doesn't work due to the dash issue, do you have to then guess using the id, or is the issue fixed now so you can guess the Pokemon name normally? I can see in your screenshot that this works with Lugia, but I am wondering about those specific problem Pokemon whose name splits incorrectly. Can you guess those using English or another language, or do you have to use the ID in that case?

I have just tested it with the problematic tapu koko. I replaced let pokemonNames = [pokemon.url.replace(/.+\/(\d+)\//g, '$1')]; with let pokemonNames = ['785'/*pokemon.url.replace(/.+\/(\d+)\//g, '$1')*/]; to test it so the sprite and artwork is wrong but the names worked:

Beautiful, wonderful job!
I just wanted to make sure this all works, I'll merge this in.


The latest v1.13.5 has security vulnerabilities because of alpine version

Hello,
The new released version of Ekuiper 1.13.5 uses aline version 3.20.0 which still has few security vulnerabilities that were already fixed in the next patched version - 3.20.1.

Could you please change this base image in your Dockerfile to alpine:3.20 or alpine 3.20.1 (instead of alpine:3.20.0)?
Thanks a lot

Thanks!


Consider supporting caches relative to home dir

Thanks!
First, thanks for all the hard work and for a very useful action!
Intro
My tests run on macOS, Ubuntu, and Windows GitHub runners, so I was excited to explore the enableCrossOsArchive feature.
I'm finding it great except for one thing.
The natural location of my project's downloaded dependencies is relative to the home dir and includes, for example, an .m2 repository.
Cross-OS caching files relative to the home dir turns out to be awkward.
Details
As far as I understand it, the current cache action always saves and restores relative to the workspace dir.
I did some poking around on a GitHub Ubuntu runner.
My workspace dir is /home/runner/work/my-repo-name/my-repo-name,
and my home dir is /home/runner.
So if I am creating my cache with a path of ~/.m2 on Ubuntu, files will get archived as, for an example, ../../../.m2/repository/com/jcraft/jsch.agentproxy.usocket-jna/0.0.9/jsch.agentproxy.usocket-jna-0.0.9.pom.
This is all fine and dandy on Ubuntu and macOS because they share the same basic directory structure. But on Windows, the directory layout is different.
I did some poking around on a GitHub Windows runner.
My workspace dir is D:\a\my-repo-name\my-repo-name,
and my home dir is C:\Users\runneradmin.
So if I restore a Ubuntu runner created cache on a Windows runner, my cache will be restored to ../../.. which is D:\, but I really want to restore to my Windows home dir.
My Current Hack
I can run a step after restoring the cache to fix things up, but this is brittle and awkward:
    - name: Cache fixup for Windows
      if: ${{ matrix.os == 'windows' }}
      run: |
        mv ../../../.m2 ${USERPROFILE}
      shell: bash

Other Alternatives
I could figure out how to have my project dependencies downloaded to my workspace dir.
But this is also awkward, unnatural, and prone to human error.
Your Current Docs...
Do warn:

Avoid using directory pointers such as ${{ github.workspace }} or ~ (home) which eventually evaluate to an absolute path that does not match across OSs.

But I think it would be great to be able to cross-OS cache relative to ~.
What I'd Really Like
Is a way to save and restore a cache relative to the home dir.
One way to do this might be to introduce a new base-path input which would act as an optional override for the hard-coded workspace dir.

Yeah, this would be great! I encounter the same issues when sharing caches between containerized and non-containerized workflow jobs, given that the cache paths in containers could be arbitrary paths in the container file system. My current work around is to also include a similar cache dancing step to move restored cache back into the same relative position. However, this can still be problematic for non-containerized jobs, as the caches could be resorted to paths external to the current workspace, and thus bleed over into the host runner's OS. That can of course cause idempotent issues when the same runner is re-used for multiple jobs.
Even having the cache paths respect the relative working directory set for the job would be great ergonomic improvement:

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#defaultsrunworking-directory


Unable to build the example

npm run build-example

><EMAIL_ADDRESS>build-example /Users/dan/p/react-visibility-sensor
> browserify -t reactify -o example/dist/bundle.js example/main.js

events.js:141
      throw er; // Unhandled 'error' event
            ^
Error: ENOENT: no such file or directory, open 'example/dist/bundle.js'

My bad - forgot to include something in that script to create the directory. Please let me know if you spot any other issues.


Historical and merged metadata flows

Add declarative style historicalBlockMetaData() and merged metadataFlow() for the historical fetch, and the historical+live fetch.
Add NetAdapter to allow non-okhttp client implementations.

@jphorec The only change was some renaming and reorg for the flow style functions into their own flows package to keep them out of the way for the time being.