Some Instagram reels giving an HTTPError()

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.instagram.com/reel/CTckaQvFNsT/']
[debug] Encodings: locale cp1254, fs mbcs, out cp857, pref cp1254
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 3.4.1
[debug] Proxy map: {}
[Instagram] CTckaQvFNsT: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 634, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 2288, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 502, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 685, in http_error_302
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

Description

Certain instagram reels seem to be giving the above error. It happens on videos from various public channels and on URLs with no special characters. It doesn't seem to be channel-specific either as some reels from the same channel can download fine.
Edit: I should point out that I'm using the youtube-dl.exe for Windows on the command prompt.

Url you posted i dead see:

Try passing a cookies with --cookies cookies.txt

Try passing a cookies with --cookies cookies.txt

Like youtube-dl --cookies cookies.txt URL ? That gives the same  " HTTP Error 404: Not Found (caused by HTTPError()) " error.

Try opening the page in your browser, if you can stomach Instagram:

Sorry, this page isn't available.
The link you followed may be broken, or the page may have been removed. Go back to Instagram.

So that would explain why yt-dl can't load the page.

Wait, it doesn't open for you? That's odd because the link works fine in my browser (Firefox)... Alright, I tried on Opera (and later on Firefox after logging out) and it doesn't load for some reason when I'm not logged in. Even though the account and the thumbnail of the video are perfectly visible.
So, Instagram apparently works in mysterious ways and the bug is not at the youtube-dl end. I might try doing a logged in download then.

@Esoppant i'm still getting the error from instagram (for this video) even when doing a logged-in download 🤷🏽♂
if you've attempted it yet, were able to get your vid to download?

if you've attempted it yet, were able to get your vid to download?

Nope, this time it's giving an "HTTP 506" error.
But for some reason, another video with the same error I had tried before now works normally (and is visible without logging in). Maybe Instagram is moving around servers or something.

http error 405 while trying to download reels from instragram (already logged using cookies) latest version
verbose log below

arthur@blackpower ~ % yt-dlp "https://www.instagram.com/marvelskies.fc/reel/CWqAgUZgCku/" --cookies "~/instagram.com_cookies.txt" --verbose
[debug] Command-line config: ['https://www.instagram.com/marvelskies.fc/reel/CWqAgUZgCku/', '--cookies', '~/instagram.com_cookies.txt', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2021.12.01 [91f071af6]
[debug] Python version 3.10.0 (CPython 64bit) - macOS-11.3-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1, rtmpdump 2.4
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
[debug] [generic] Extracting URL: https://www.instagram.com/marvelskies.fc/reel/CWqAgUZgCku/
[generic] CWqAgUZgCku: Requesting header
WARNING: [generic] Could not send HEAD request to https://www.instagram.com/marvelskies.fc/reel/CWqAgUZgCku/: HTTP Error 405: Method Not Allowed
[generic] CWqAgUZgCku: Downloading webpage
WARNING: [generic] Falling back on generic information extractor.
[generic] CWqAgUZgCku: Extracting information
[debug] Looking for video embeds
[debug] Identified a JW Player JS loader
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 259945183_634763724195677_1967405584202529129_n.mp4?_nc_ht=instagram.fgyn3-1.fna.fbcdn: Downloading 1 format(s): 0
[debug] Invoking downloader on "https://instagram.fgyn3-1.fna.fbcdn.net/v/t50.2886-16/259945183_634763724195677_1967405584202529129_n.mp4?_nc_ht=instagram.fgyn3-1.fna.fbcdn.net\u0026_nc_cat=105\u0026_nc_ohc=pIfmkouO64cAX-mzjZh\u0026edm=APfKNqwBAAAA\u0026ccb=7-4\u0026oe=61B1C916\u0026oh=9c99e1bc5cbb455c9b5a2ac528d429de\u0026_nc_sid=74f7ba"
ERROR: unable to download video data: HTTP Error 403: Forbidden
Traceback (most recent call last):
  File "/usr/local/Cellar/yt-dlp/2021.12.1/libexec/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 2933, in process_info
    success, real_download = self.dl(temp_filename, info_dict)
  File "/usr/local/Cellar/yt-dlp/2021.12.1/libexec/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 2654, in dl
    return fd.download(name, new_info, subtitle)
  File "/usr/local/Cellar/yt-dlp/2021.12.1/libexec/lib/python3.10/site-packages/yt_dlp/downloader/common.py", line 421, in download
    ret = self.real_download(filename, info_dict)
  File "/usr/local/Cellar/yt-dlp/2021.12.1/libexec/lib/python3.10/site-packages/yt_dlp/downloader/http.py", line 372, in real_download
    establish_connection()
  File "/usr/local/Cellar/yt-dlp/2021.12.1/libexec/lib/python3.10/site-packages/yt_dlp/downloader/http.py", line 120, in establish_connection
    raise err
  File "/usr/local/Cellar/yt-dlp/2021.12.1/libexec/lib/python3.10/site-packages/yt_dlp/downloader/http.py", line 114, in establish_connection
    ctx.data = self.ydl.urlopen(request)
  File "/usr/local/Cellar/yt-dlp/2021.12.1/libexec/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 3385, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File<EMAIL_ADDRESS>line 525, in open
    response = meth(req, response)
  File<EMAIL_ADDRESS>line 634, in http_response
    response = self.parent.error(
  File<EMAIL_ADDRESS>line 557, in error
    result = self._call_chain(*args)
  File<EMAIL_ADDRESS>line 496, in _call_chain
    result = func(*args)
  File<EMAIL_ADDRESS>line 749, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File<EMAIL_ADDRESS>line 525, in open
    response = meth(req, response)
  File<EMAIL_ADDRESS>line 634, in http_response
    response = self.parent.error(
  File<EMAIL_ADDRESS>line 563, in error
    return self._call_chain(*args)
  File<EMAIL_ADDRESS>line 496, in _call_chain
    result = func(*args)
  File<EMAIL_ADDRESS>line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden

This isnt YT-DLP.

This isnt YT-DLP.

LOL sorry

but the same error occurs on youtube-dl too

@tucomel if you're going to post YT-DLP code dumps, you should do that on the YT-DLP issue tracker. If you're going to post YouTube-DL code dumps, then you should do it here. Please respect that fact that you cant just post whatever you want to any issue tracker, and expect to get a helpful response.

https://github.com/yt-dlp/yt-dlp/issues/1925

I have an alternate tool that works:
PS C:\> instagram CT9rvsbpdgY
GET https://www.instagram.com/p/CT9rvsbpdgY/?__a=1
GET https://scontent-dfw5-2.cdninstagram.com/v/t50.2886-16/242060123_653076735630384_3990965360577827920_n.mp4?_nc_ht=scontent-dfw5-2.cdninstagram.com&_nc_cat=100&_nc_ohc=OdEVdBO_tw0AX9JNJKC&edm=AABBvjUBAAAA&ccb=7-4&oe=61BCAACB&oh=00_AT8e3Bby4kXKK4ngkTTY4URHzQ3Ap3mdi8sMm2k1f82R5A&_nc_sid=83d603

https://github.com/89z/mech

@tucomel
Please do not post irrelevant log here.
I have updated PR #29751 to accept this type of URL https://www.instagram.com/marvelskies.fc/reel/CWqAgUZgCku/ as Instagram URL. Unfortunately, you won't be able to get new youtube-dl release any time soon, so you have to modify the code by yourself if you need this.


Create strings.xml for Farsi/Persian

#120

Looks good @yamin8000! I just notice some phrases are still in English and not translated. Are you going to translate them too? :)

I edited using my browser so editing parametric ones was a little difficult especially since Farsi is right to left I feared I may mess them up so I just left them for now to edit them later using a proper editor or even build it using AS to test it.

Looks good @yamin8000! I just notice some phrases are still in English and not translated. Are you going to translate them too? :)

I fixed the remaining ones.


SyntaxError: Unexpected token '?'

Hi
I have just installed cli but I cannot start it. It fails with
file:///usr/local/lib/node_modules/soulseek-cli/src/modules/Search.js:14
  this.timeout = options.timeout ?? 2000;
                                  ^

SyntaxError: Unexpected token '?'
    at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)```

Any idea how to solve this ? Thanks

This was a dependency issue. I had Node.js v12.22.9. Soved after updating it to latest (v20.2.0)


#2262 Fix notifications on linux in default configuration

Summary
Change default configuration on Linux to not flash the window on new messages.
With the option enabled, when using Linux, the first notification would render without message content and just say "Mattermost desktop app is ready". Disabling this option by default under Linux makes the desktop app work fine out of the box.
Also under Linux the flash window feature doesn't work anyway. See linked ticket for more details.
Ticket Link
Fixes https://github.com/mattermost/desktop/issues/2262
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[x] read and understood our [Contributing Guidelines]
[x] completed [Mattermost Contributor Agreement]
[x] executed npm run lint:js for proper code formatting

Device Information
This PR was tested on: Ubuntu 22.04
Release Note
Changed default for config setting notifications.flashWindow to 0 under Linux (fixes notifications for Linux users)

Hello @edlerd,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@edlerd Thanks for the PR! So as a heads-up, the window flash DOES work on some distributions, including Linux Mint if I recall correctly. I believe you're right that it doesn't work on GNOME, it varies from window manager to window manager.
I think it's okay to turn off the flashing by default if it's causing headaches for Ubuntu users though, since that is our primary supported distribution.

Building app in separate branch.

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/23029
https://circleci.com/gh/mattermost/desktop/23028
https://circleci.com/gh/mattermost/desktop/23027

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/desktop/23029
https://circleci.com/gh/mattermost/desktop/23028
https://circleci.com/gh/mattermost/desktop/23027

Artifact links:
https://output.circle-artifacts.com/output/job/e934589f-7e5c-4eab-8b5c-05b47b280487/artifacts/0/tmp/artifacts/mattermost-desktop-5.2.0-develop.1-linux-x64.tar.gz
https://output.circle-artifacts.com/output/job/5765bfe9-e856-431c-8c98-e7d239be439a/artifacts/0/tmp/artifacts/mattermost-desktop-5.2.0-develop.1-win-ia32.zip
https://output.circle-artifacts.com/output/job/5765bfe9-e856-431c-8c98-e7d239be439a/artifacts/0/tmp/artifacts/mattermost-desktop-5.2.0-develop.1-win-x64.zip
https://output.circle-artifacts.com/output/job/2760c990-0ea3-4173-b805-1632be540fff/artifacts/0/tmp/artifacts/mattermost-desktop-5.2.0-develop.1-mac-m1.dmg
https://output.circle-artifacts.com/output/job/2760c990-0ea3-4173-b805-1632be540fff/artifacts/0/tmp/artifacts/mattermost-desktop-5.2.0-develop.1-mac-x64.dmg

@devinbinnie can you please help merge - Thanks 🙂


Responsiveness

After updating to 3.1 we have several messages that the responsiveness doesn't work like it should. What we know so far is that in the default Xerte Online Toolkits theme the top bar gets higher then normal and it doesn't matter if you use or use not the checkbox responsive text. The top bar off the other themes respond ok on the responsive checkbox as far as I can see.
The other thing is that there is a different behaviour in the different browsers in the height of the text on a page. Below a few examples.
IE11 looks ok

Chrome not

Any ideas?

Not sure about the top bar issue but different text sizes are possibly two or three different things:

If there are any font sizes applied in the editor these will override the theme styles. So if for instance text is selected and set to 14pt by the author then that will remain 14pt even when other text is responsive.

The responsive styles only work on html so if an existing LO is used which hasn't been edited with the new editor then some text may not be responsive until a basic edit is applied which then adds  tags etc so that the responsiveness works.

Finally different browsers do display vmin sizes differently so for instance body text in IE might be smaller than displayed in Chrome or Firefox but that's the case with other size values too.

One of the issues is, that responsivetext is always switched on for the default template. I don't think that's desirabe. It's probably a bug, We didn't want to do this correct? By default responsive text should have been turned off
It is caused by the lack of checking for the value of the responsiveness paramater in xenith,js near line 451:
if (param == "theme") {
		if (x_params.theme != undefined && x_params.theme != "default") {
			$.getScript(x_themePath + x_params.theme + '/' + x_params.theme +  '.js'); // most themes won't have this js file
			x_insertCSS(x_themePath + x_params.theme + '/' + x_params.theme +  '.css', function() {x_cssSetUp("theme2")});
		} else {
---->		if (x_params.responsive == "true") {
				if (x_params.displayMode == "default" || $.isArray(x_params.displayMode)) { // immediately disable responsivetext.css after loaded
					x_insertCSS(x_templateLocation + "common_html5/css/responsivetext.css", function() {x_cssSetUp("stylesheet")}, true);
				} else {
					x_insertCSS(x_templateLocation + "common_html5/css/responsivetext.css", function() {x_cssSetUp("stylesheet")});
				}
			}
		}
	}

Hmm. That is not the solution. If I do that, the whole object doesn't display anymore!!. Without so much as an indictaion why. Apparently responsitext.css is NEEDED by the default theme.

Closed


Could not load Newtonsoft.Json V<IP_ADDRESS> on latest Google.Apis.YouTube.v3 <IP_ADDRESS>2

When using the latest YouTube v3 client library (Google.Apis.YouTube.v3) in a .NET 4.6.1 project.json app I get the following exception on runtime:

Exception Details
System.IO.FileLoadException occurred
  FileName=Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed
  FusionLog==== Pre-bind state information ===
LOG: DisplayName = Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed
 (Fully-specified)
LOG: Appbase = file:///C:/Dev/Repositories/YouCast/Source/YouCast/bin/Debug/
LOG: Initial PrivatePath = NULL
Calling assembly : Google.Apis.YouTube.v3, Version=<IP_ADDRESS>2, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab.
===
LOG: This bind starts in default load context.
LOG: Using application configuration file: C:\Dev\Repositories\YouCast\Source\YouCast\bin\Debug\YouCast.vshost.exe.config
LOG: Using host configuration file:
LOG: Using machine configuration file from C:\Windows\Microsoft.NET\Framework\v4.0.30319\config\machine.config.
LOG: Post-policy reference: Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed
LOG: Attempting download of new URL file:///C:/Dev/Repositories/YouCast/Source/YouCast/bin/Debug/Newtonsoft.Json.DLL.
WRN: Comparing the assembly name resulted in the mismatch: Major Version
ERR: Failed to complete setup of assembly (hr = 0x80131040). Probing terminated.
HResult=-2146234304
Message=Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
Source=mscorlib
StackTrace:
at System.ModuleHandle.ResolveType(RuntimeModule module, Int32 typeToken, IntPtr* typeInstArgs, Int32 typeInstCount, IntPtr* methodInstArgs, Int32 methodInstCount, ObjectHandleOnStack type)
at System.ModuleHandle.ResolveTypeHandleInternal(RuntimeModule module, Int32 typeToken, RuntimeTypeHandle[] typeInstantiationContext, RuntimeTypeHandle[] methodInstantiationContext)
at System.Reflection.RuntimeModule.ResolveType(Int32 metadataToken, Type[] genericTypeArguments, Type[] genericMethodArguments)
at System.Reflection.CustomAttribute.FilterCustomAttributeRecord(CustomAttributeRecord caRecord, MetadataImport scope, Assembly& lastAptcaOkAssembly, RuntimeModule decoratedModule, MetadataToken decoratedToken, RuntimeType attributeFilterType, Boolean mustBeInheritable, Object[] attributes, IList derivedAttributes, RuntimeType& attributeType, IRuntimeMethodInfo& ctor, Boolean& ctorHasParameters, Boolean& isVarArg)
at System.Reflection.CustomAttribute.IsCustomAttributeDefined(RuntimeModule decoratedModule, Int32 decoratedMetadataToken, RuntimeType attributeFilterType, Int32 attributeCtorToken, Boolean mustBeInheritable)
at System.Reflection.CustomAttribute.IsDefined(RuntimePropertyInfo property, RuntimeType caType)
at System.Reflection.RuntimePropertyInfo.IsDefined(Type attributeType, Boolean inherit)
at Newtonsoft.Json.Serialization.DefaultContractResolver.GetSerializableMembers(Type objectType)
at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateProperties(Type type, MemberSerialization memberSerialization)
at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateObjectContract(Type objectType)
at Newtonsoft.Json.Serialization.DefaultContractResolver.CreateContract(Type objectType)
at Newtonsoft.Json.Serialization.DefaultContractResolver.ResolveContract(Type type)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
at Google.Apis.Json.NewtonsoftJsonSerializer.Deserialize[T](String input) in C:\Users\cloudsharp\Documents\GitHub\google-api-dotnet-client\Src\Support\GoogleApis.Core\Apis\Json\NewtonsoftJsonSerializer.cs:line 124
at Google.Apis.Services.BaseClientService.d__331.MoveNext() in C:\Users\cloudsharp\Documents\GitHub\google-api-dotnet-client\Src\Support\GoogleApis\Apis\Services\BaseClientService.cs:line 265     --- End of stack trace from previous location where exception was thrown ---        at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)        at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)        at Google.Apis.Requests.ClientServiceRequest1.d__27.MoveNext() in C:\Users\cloudsharp\Documents\GitHub\google-api-dotnet-client\Src\Support\GoogleApis\Apis\Requests\ClientServiceRequest.cs:line 0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Google.Apis.Requests.ClientServiceRequest1.<ExecuteAsync>d__23.MoveNext() in C:\Users\cloudsharp\Documents\GitHub\google-api-dotnet-client\Src\Support\GoogleApis\Apis\Requests\ClientServiceRequest.cs:line 0     --- End of stack trace from previous location where exception was thrown ---        at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)        at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)        at Google.Apis.Requests.ClientServiceRequest1.d__22.MoveNext() in C:\Users\cloudsharp\Documents\GitHub\google-api-dotnet-client\Src\Support\GoogleApis\Apis\Requests\ClientServiceRequest.cs:line 0
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at Service.YoutubeFeed.d__5.MoveNext() in C:\Dev\Repositories\YouCast\Source\Service\YoutubeFeed.cs:line 60
InnerException:

The lowest call is Google.Apis.Json.NewtonsoftJsonSerializer.Deserialize in the Google.Apis.Core package.
By looking at the nuspec I see that .NET Standard gets v9 but the rest get v7 so I assume I get the package requiring v7 but the assemblies inside it actually require v9.

Is this linked to #829?

It seems related, but not the same issue.
They want to advance to a newer version to get the latest and greatest while my usage of the library as it is breaks on runtime.

Please could you give details on how to reproduce this? I'd expect assembly binding to just "do the right thing". Can you reproduce it in a simple console app?

Thanks - will have a look when I get a moment. (I'm currently travelling, so it may well be next week.)

verified his project doesn't work.
verified that running it with out the Async does work.

I have a little time and I know the YouTube API although i don't think this is an issue with the API at this time.  Going to see what i can figure out between now and when @jskeet  has time next week.

Same problem while running smaple code from documentation:
https://developers.google.com/sheets/quickstart/dotnet
P.S. There is another trouble in sample:
String range = "Class Data!A2:E";
cause exception
String range = "A2:E";
works fine

Hmm... just had a look. The current code doesn't even build for me with dotnet cli, with "The type 'Object' is defined in an assembly that is not referenced." errors. It all works when you change to use net45 instead. So that's one oddity.
Next, when I build with msbuild (in detailed), it appears to be using the netstandard1.3 dependency - it says:
Could not resolve this reference. Could not locate the assembly "Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.
...
Required by "C:\Users\skeet\.nuget\packages\Google.Apis.YouTube.v3\<IP_ADDRESS>2\lib\netstandard1.3\Google.Apis.YouTube.v3.dll".

Now we only explicitly have dependencies for net40 and net45 - see the nuspec file. I'd expect net461 to pick up on the net45 one though.
@chrisdunelm have you seen anything like this before? It looks like net461 is basically borked...

This is really unfortunate.
Using the "Get Nearest Framework" tool it appears that netstandard1.3 is the preferred choice given the targets contained in our packages.
I suspect we may need to add an "net45" (or possibly "net46") target, both of which I've just verified is then used when targeting net46[1].
So yes, net461 is currently borked.
I'll start work now on a new release with a fix.

Being addressed in #848. I expect to get this released to nuget tomorrow.

This should now be fixed by v1.17 of the libraries, which are now available on nuget.

Works great. Thanks :)


Add benchmark for batch gen/eval

Description
We've already got some benchmarks but we're missing one for batch gen/eval. This PR adds that.
Affected Dependencies
.
How has this been tested?
Running benchmarks locally.
Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

@tholop - attending your comments, I've grouped the benchmarks with ranges of n_values and n_threads. I'm not sure how this will play out in the GitHub Actions runners (see info here) but hopefully this is closer to what will be useful for us. Let me know if there's anything missing.

Looks perfect, thanks @arturomf94! I realized that the speed was the same regardless of the value of n_threads -- not because of the benchmark code. The reason is that if a Rayon thread pool already exists, Sycret will not initialize a new one: https://github.com/OpenMined/sycret/blob/fc776e1a9c517aebdd7a705d448eb1865cda6479/src/lib.rs#L84
Most of the time, the user will not provide any value for n_threads anyway, so Sycret will directly use the right number of threads, but this is not very clean. We don't want to pay the Rayon pool initialization overhead at every call, but I think that we can respawn the pool only when n_threads is different than rayon::current_num_threads. What do you think?
I'm happy to push a commit for this change.

We don't want to pay the Rayon pool initialization overhead at every call, but I think that we can respawn the pool only when n_threads is different than rayon::current_num_threads

Yes - I think this sounds optimal.


test(fuzz): add more positive fuzz tests to the test suite

closes: https://github.com/foundry-rs/foundry/issues/971

Motivation
I copied over solmate to run the FixedPointMathLib.t.sol test
https://github.com/foundry-rs/foundry/blob/1f5d8de06ffd1aeff73880893b2b6196975f728e/testdata/fuzz/FuzzFixedPointMathLib.t.sol#L8-L12
Solmate: https://github.com/Rari-Capital/solmate/tree/main/src/test
Please let me know if I'm on the right track or if I'm completely off

Add solmate contracts to testdata/lib/solmate/: https://github.com/foundry-rs/foundry/tree/1f5d8de06ffd1aeff73880893b2b6196975f728e/testdata/lib/solmate/src
Continue adding solmate tests to foundry test suite: https://github.com/foundry-rs/foundry/tree/1f5d8de06ffd1aeff73880893b2b6196975f728e/testdata/fuzz
Fix positive test matching here instead of manually listing additional tests like testMulWadDown()
https://github.com/foundry-rs/foundry/blob/1f5d8de06ffd1aeff73880893b2b6196975f728e/forge/src/multi_runner.rs#L1040-L1056

Solution

I don't think we should run tests like these in our base test suite (these are already run in the integration test part). This test suite is more intended to show that the basic functionality works as expected in Forge itself

apologies but I've been having trouble adding tests and checking that they are run
Question

Having a brainfart with thetest_fuzz matching for tests passing
https://github.com/foundry-rs/foundry/blob/1f5e4b6fc2bbc9a83455daf821edd9ee0eeeb993/forge/src/multi_runner.rs#L1040-L1055

I changed `testPositive(uint256) to fail and it still seems to pass

using cargo test -p forge locally and also saw that ci worked too after pushing it

Will reopen new pr after I understand it better


[path_provider_linux] Using TMPDIR env as a primary temporary path

TMPDIR is a standard variable on UNIX/Linux systems, and is often used in containers such as Flatpak to redirect to a temporary folder inside a sandbox. This allows not to make hard bindings to the /tmp directory
Implements https://github.com/flutter/flutter/issues/87742
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks for the submission! This will need the remaining items in the checklist addressed before it moves forward with review. If you have any questions about completing those steps that aren’t addressed in the linked documentation, please let me know.

@stuartmorgan
I have questions about this:
I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
I updated CHANGELOG.md to add a description of the change.

Do I have to make a version bump in this case?

@stuartmorgan
About tests: the problem is that the Platform class from the dart:io library is not mockable, so I can't insert the required environment variable value inside the test (Platform.environment). The solution would be to use the mockable version of Platform, some plugins use this https://pub.dev/packages/platform

I have questions about this:
I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
I updated CHANGELOG.md to add a description of the change.

Do I have to make a version bump in this case?

The section you are quoting links to an explanation of the versioning policy for flutter/plugins. Could you elaborate on what your are seeing there that suggests you would not need to so that I can clarify it?

About tests: the problem is that the Platform class from the dart:io library is not mockable, so I can't insert the required environment variable value inside the test (Platform.environment). The solution would be to use the mockable version of Platform, some plugins use this https://pub.dev/packages/platform

Since all you need in the environment, a much simpler solution at this point would just be to make PathProviderLinux take an injectable-by-tests environment map that would replace the call to Platform.environment. We generally try to minimize package dependencies in the plugins here.

@stuartmorgan
I added tests and also bumped the plugin version to 2.1.0 as I believe the API changes are backwards compatible and are not just a patch.

@stuartmorgan
All comments have been resolved.

@stuartmorgan
Can you review my changes again?

Oops, this got caught by the Windows bot change so it was never auto-landed. Landing manually, since this can't affect Windows.


Exit conditions

Clean up exit conditions for a graceful shutdown. Make sure that all go routines are properly shutdown.

Codecov Report

Merging #198 into master will decrease coverage by 0.23%.
The diff coverage is 21.27%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   49.35%   49.12%   -0.24%
==========================================
  Files          33       33
  Lines        4194     4208      +14
==========================================
- Hits         2070     2067       -3
- Misses       1928     1945      +17
  Partials      196      196

Impacted Files
Coverage Δ

cmd/remoteenforcer/remoteenforcer_linux.go
0% <0%> (ø)
:arrow_up:

supervisor/iptablesctrl/iptables.go
51.89% <0%> (+0.36%)
:arrow_up:

supervisor/iptablesctrl/acls.go
67.83% <25%> (-2.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdf834...de2b2dd. Read the comment docs.


view_controller_msgs: 0.2.0-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository view_controller_msgs to 0.2.0-1:

upstream repository: https://github.com/ros-visualization/view_controller_msgs.git
release repository: https://github.com/ros-gbp/view_controller_msgs-release.git
distro file: noetic/distribution.yaml
bloom version: 0.10.7
previous version for package: 0.1.3-1

view_controller_msgs
* add new status badge
* remove ci badge for now
* add gh actions for noetic and melodic
* major version bump since added new msgs
* Merge pull request #8 <https://github.com/ros-visualization/view_controller_msgs/issues/8> from Razlaw/camera_trajectories
  add messages to support moving view camera along trajectory
* add CameraMovement and CameraTrajectory messages to support moving view camera along trajectory
* take over maintenance from orphaned package group (#7 <https://github.com/ros-visualization/view_controller_msgs/issues/7>)
* Contributors: Evan Flynn, razlaw

Holding for Noetic sync


Graphic for "Securing your Dashboard"

Related Issue
No response
Description
Considerations:

In a blog post that accompanies a video

Inspirations:

https://flowfuse.com/img/db-notebook-tile-E_jQBPxMM8-560.avif with a "secure" shield or padlock (in FF colours) infering secure access

what do you think?

Really really good. Thank you.

https://www.youtube.com/watch?v=pCYzJGVkG8s


2D MPR crashes on some CTs with RangeError: Array buffer allocation failed.

We have the CTs with the following details,
Dimensions: 512 x 512
Number of slices: 2500 to 3500
OS: Windows
Browsers: Google Chrome and Firefox
System RAM: 16GB
This problem is for both Local and Cloud environment(AWS) as well.

Please provide details about the CT data that fails, like the slice dimensions, number of slices, and what clinical procedure this comes from.  Also describe your environment, like what OS, browser, how much memory your machine has, etc.

Please provide details about the CT data that fails, like the slice dimensions, number of slices, and what clinical procedure this comes from.  Also describe your environment, like what OS, browser, how much memory your machine has, etc.

We have the CTs with the following details,
Dimensions: 512 x 512
Number of slices: 2500 to 3500
OS: Windows
Browsers: Google Chrome and Firefox
System RAM: 16GB
This problem is for both Local and Cloud environment(AWS) as well.

Thanks for the extra details.  I have also seen array buffer allocation fail for a scan with 2000 slices.  I'm not sure there's a planned work around.  @sedghi has may be able to comment.

Thanks for the extra details.  I have also seen array buffer allocation fail for a scan with 2000 slices.  I'm not sure there's a planned work around.  @sedghi has may be able to comment.

Appreciate for the response and help.
Looking for the @sedghi response.

There are some plans for this. @Ouwen has written a POC for how to split the slices into different sections and let the user see the first sectoin, until it scrolls to the bottom and it automatically triggers going to next section, maybe he can talk about that. In addition to these kinds of tricks, we are working on the INT_16 texture size which reduces the memory in half, but seems like it has some bugs in Chromium and Safari, more on that here

https://bugs.chromium.org/p/chromium/issues/detail?id=1408247

Hi @muddasar-de for desktop use you can increase the memory limit from 1GB to 2GB and it should work with this PR into cornerstone3D-beta:
https://github.com/cornerstonejs/cornerstone3D-beta/pull/420
There is also a partial load PR I am working on which is based on invalidating the displaySetUID

@muddasar-de see this PR: https://github.com/OHIF/Viewers/pull/3235

Hi we are facing a similar issue. Wondering if there was any progress on this issue.
Issue description
Clicking the 2D MPR button will consume the entire machine's RAM, temporarily crash the browser and then render blank images on the DICOM Viewer.
Our image:

Foot CT
533 slices
950 x 950
35D x 20H

Browser: Chrome
Machine:

Dell XPS
RAM: 32GB
GPU: NVIDIA RTX 3050 Ti GPU

Mysteriously we have been able to successfully use the 2D MPR feature for the same scan with several different machines (Macbook Air with 8GB RAM, Macbook Pro with 16GB Pro, and Lenovo Legion with 32GB RAM and RTX 3060 GPU).
Screenshot

Browser console
macro.js:64 Error compiling shader '#version 300 es
#define attribute in
#define textureCube texture
#define texture2D texture
#define textureCubeLod textureLod
#define texture2DLod textureLod

#ifdef GL_FRAGMENT_PRECISION_HIGH
precision highp float;
precision highp int;
#else
precision mediump float;
precision mediump int;
#endif

/*=========================================================================

  Program:   Visualization Toolkit
  Module:    vtkPolyDataVS.glsl

  Copyright (c) Ken Martin, Will Schroeder, Bill Lorensen
  All rights reserved.
  See Copyright.txt or http://www.kitware.com/Copyright.htm for details.

     This software is distributed WITHOUT ANY WARRANTY; without even
     the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
     PURPOSE.  See the above copyright notice for more information.

=========================================================================*/

attribute vec4 vertexDC;

out vec3 vertexVCVSOutput;
uniform mat4 DCVCMatrix;

uniform float dcxmin;
uniform float dcxmax;
uniform float dcymin;
uniform float dcymax;

void main()
{
  // dcsmall is the device coords reduced to the
  // x y area covered by the volume
  vec4 dcsmall = vec4(
    dcxmin + 0.5 * (vertexDC.x + 1.0) * (dcxmax - dcxmin),
    dcymin + 0.5 * (vertexDC.y + 1.0) * (dcymax - dcymin),
    vertexDC.z,
    vertexDC.w);
  vec4 vcpos = DCVCMatrix * dcsmall;
  vertexVCVSOutput = [vcpos.xyz/vcpos.w](http://vcpos.xyz/vcpos.w);
  gl_Position = dcsmall;
}
':
h @ macro.js:64
macro.js:64

0: #version 300 es
1: #define attribute in
2: #define textureCube texture
3: #define texture2D texture
4: #define textureCubeLod textureLod
5: #define texture2DLod textureLod
6:
7:
8: #ifdef GL_FRAGMENT_PRECISION_HIGH
9: precision highp float;
10: precision highp int;
11: #else
12: precision mediump float;
13: precision mediump int;
14: #endif
15:
16: /*=========================================================================
17:
18:   Program:   Visualization Toolkit
19:   Module:    vtkPolyDataVS.glsl
20:
21:   Copyright (c) Ken Martin, Will Schroeder, Bill Lorensen
22:   All rights reserved.
23:   See Copyright.txt or http://www.kitware.com/Copyright.htm for details.
24:
25:      This software is distributed WITHOUT ANY WARRANTY; without even
26:      the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
27:      PURPOSE.  See the above copyright notice for more information.
28:
29: =========================================================================*/
30:
31: attribute vec4 vertexDC;
32:
33: out vec3 vertexVCVSOutput;
34: uniform mat4 DCVCMatrix;
35:
36: uniform float dcxmin;
37: uniform float dcxmax;
38: uniform float dcymin;
39: uniform float dcymax;
40:
41: void main()
42: {
43:   // dcsmall is the device coords reduced to the
44:   // x y area covered by the volume
45:   vec4 dcsmall = vec4(
46:     dcxmin + 0.5 * (vertexDC.x + 1.0) * (dcxmax - dcxmin),
47:     dcymin + 0.5 * (vertexDC.y + 1.0) * (dcymax - dcymin),
48:     vertexDC.z,
49:     vertexDC.w);
50:   vec4 vcpos = DCVCMatrix * dcsmall;
51:   vertexVCVSOutput = [vcpos.xyz/vcpos.w](http://vcpos.xyz/vcpos.w);
52:   gl_Position = dcsmall;
53: }
54:

react-dom.production.min.js:196 TypeError: Cannot read properties of null (reading 'isAttributeUsed')
    at Yt.e.setMapperShaderParameters (index.js:383:19)
    at Yt.e.updateShaders (index.js:367:15)
    at Yt.e.renderPieceDraw (index.js:918:15)
    at Yt.e.renderPiece (index.js:1037:15)
    at Yt.e.volumePass (index.js:74:17)
    at e.apply (index.js:44:7)
    at e.traverse (index.js:32:15)
    at Ot.e.traverseVolumePass (index.js:49:23)
    at e.traverse (index.js:27:7)
    at e.traverse (index.js:35:29)

also for some systems the notes here is helpful https://github.com/cornerstonejs/cornerstone3D-beta/issues/453

also for some systems the notes here is helpful cornerstonejs/cornerstone3D-beta#453

Thank you, this helped

Please review the latest code in the master branch. I am confident that this issue has been resolved. If it persists, kindly reopen the issue with updated details.
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


Issues with using Scrapy Scrapy-playwright

I am sorry if this is an issue that has already been solved;I am new to using scrapy, but I keep on getting this error when I run Scrapy crawl pwdemo
[asyncio] ERROR: Task exception was never retrieved
future: <Task finished name='Task-3' coro=<Connection.run() done, defined at C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_connection.py:240> exception=NotImplementedError()>
Traceback (most recent call last):
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_connection.py", line 247, in run
    await self._transport.connect()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_transport.py", line 132, in connect
    raise exc
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_transport.py", line 120, in connect
    self._proc = await asyncio.create_subprocess_exec(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\subprocess.py", line 218, in create_subprocess_exec
    transport, protocol = await loop.subprocess_exec(
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 1680, in subprocess_exec
    transport = await self._make_subprocess_transport(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 502, in _make_subprocess_transport
    raise NotImplementedError
NotImplementedError
2023-01-12 14:08:47 [asyncio] ERROR: Task exception was never retrieved
future: <Task finished name='Task-4' coro=<Connection.run() done, defined at C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_connection.py:240> exception=NotImplementedError()>
Traceback (most recent call last):
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_connection.py", line 247, in run
    await self._transport.connect()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_transport.py", line 132, in connect
    raise exc
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_transport.py", line 120, in connect
    self._proc = await asyncio.create_subprocess_exec(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\subprocess.py", line 218, in create_subprocess_exec
    transport, protocol = await loop.subprocess_exec(
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 1680, in subprocess_exec
    transport = await self._make_subprocess_transport(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 502, in _make_subprocess_transport
    raise NotImplementedError
NotImplementedError
2023-01-12 14:08:47 [scrapy.utils.signal] ERROR: Error caught on signal handler: <bound method ScrapyPlaywrightDownloadHandler._engine_started of <scrapy_playwright.handler.ScrapyPlaywrightDownloadHandler object at 0x0000014CD25C7710>>
Traceback (most recent call last):
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\internet\defer.py", line 1065, in adapt
    extracted = result.result()
                ^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 116, in _launch
    self.playwright = await self.playwright_context_manager.start()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\async_api\_context_manager.py", line 51, in start
    return await self.__aenter__()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\async_api\_context_manager.py", line 46, in __aenter__
    playwright = AsyncPlaywright(next(iter(done)).result())
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_transport.py", line 120, in connect
    self._proc = await asyncio.create_subprocess_exec(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\subprocess.py", line 218, in create_subprocess_exec
    transport, protocol = await loop.subprocess_exec(
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 1680, in subprocess_exec
    transport = await self._make_subprocess_transport(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 502, in _make_subprocess_transport
    raise NotImplementedError
NotImplementedError
2023-01-12 14:08:47 [scrapy.utils.signal] ERROR: Error caught on signal handler: <bound method ScrapyPlaywrightDownloadHandler._engine_started of <scrapy_playwright.handler.ScrapyPlaywrightDownloadHandler object at 0x0000014CD2870AD0>>
Traceback (most recent call last):
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\internet\defer.py", line 1065, in adapt
    extracted = result.result()
                ^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 116, in _launch
    self.playwright = await self.playwright_context_manager.start()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\async_api\_context_manager.py", line 51, in start
    return await self.__aenter__()
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\async_api\_context_manager.py", line 46, in __aenter__
    playwright = AsyncPlaywright(next(iter(done)).result())
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_transport.py", line 120, in connect
    self._proc = await asyncio.create_subprocess_exec(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\subprocess.py", line 218, in create_subprocess_exec
    transport, protocol = await loop.subprocess_exec(
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 1680, in subprocess_exec
    transport = await self._make_subprocess_transport(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 502, in _make_subprocess_transport
    raise NotImplementedError
NotImplementedError
2023-01-12 14:09:05 [scrapy.downloadermiddlewares.retry] DEBUG: Retrying <GET https://shoppable-campaign-demo.netlify.app/robots.txt> (failed 1 times): [<twisted.python.failure.Failure twisted.internet.error.ConnectionLost: Connection to the other side was lost in a non-clean fashion: Connection lost.>]
ERROR: Error downloading <GET https://shoppable-campaign-demo.netlify.app/#/>
Traceback (most recent call last):
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\internet\defer.py", line 1693, in _inlineCallbacks
    result = context.run(
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\python\failure.py", line 518, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy\core\downloader\middleware.py", line 49, in process_request
    return (yield download_func(request=request, spider=spider))
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\internet\defer.py", line 1065, in adapt
    extracted = result.result()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 248, in _download_request
    page = await self._create_page(request)
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 174, in _create_page
    context = await self._create_browser_context(
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 149, in _create_browser_context
    await self._maybe_launch_browser()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 133, in _maybe_launch_browser
    logger.info("Launching browser %s", self.browser_type.name)
AttributeError: 'ScrapyPlaywrightDownloadHandler' object has no attribute 'browser_type'
2023-01-12 14:09:06 [scrapy.core.engine] INFO: Closing spider (finished)
2023-01-12 14:09:06 [scrapy.statscollectors] INFO: Dumping Scrapy stats:

2023-01-12 14:09:06 [scrapy-playwright] INFO: Closing download handler
2023-01-12 14:09:06 [scrapy.utils.signal] ERROR: Error caught on signal handler: <bound method DownloadHandlers._close of <scrapy.core.downloader.handlers.DownloadHandlers object at 0x0000014CD255AED0>>
Traceback (most recent call last):
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\internet\defer.py", line 1693, in _inlineCallbacks
    result = context.run(
             ^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\python\failure.py", line 518, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy\core\downloader\handlers\__init__.py", line 81, in _close
    yield dh.close()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\internet\defer.py", line 1693, in _inlineCallbacks
    result = context.run(
             ^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\python\failure.py", line 518, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 230, in close
    yield deferred_from_coro(self._close())
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\twisted\internet\defer.py", line 1065, in adapt
    extracted = result.result()
                ^^^^^^^^^^^^^^^
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\scrapy_playwright\handler.py", line 238, in _close
    await self.playwright_context_manager.__aexit__()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\async_api\_context_manager.py", line 54, in __aexit__
    await self._connection.stop_async()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_connection.py", line 258, in stop_async
    self._transport.request_stop()
  File "C:\Users\kolad\Desktop\last\last\Lib\site-packages\playwright\_impl\_transport.py", line 101, in request_stop
    assert self._output
           ^^^^^^^^^^^^
AttributeError: 'PipeTransport' object has no attribute '_output'

I expected for it to run the website and return my selected items, but instead I get the error above, I have all dependencies installed in my venv, and I have also ran playwright.install  thus I have the browsers
Help would be appreciated

scrapy-playwright does not run natively on Windows, see the notes in the readme: https://github.com/scrapy-plugins/scrapy-playwright#lack-of-native-support-for-windows

Oh, thanks

Oh, thanks


Make quantiles configurable

@wodity This is looking pretty good, but can you please add some tests for the config changes as well as an integration test for a custom quantile? Thanks.

Thanks!


fix(github): adds validation on reponame

adds validation on reponame

Tracks: https://github.com/openshiftio/openshift.io/issues/3022

@jyasveer @arunkumars08 thanks, have handled the comments pls take a look


Calculate Hash of Basic Blocks

Having an issue with calculating a hash for each basic block in a given function. I've got a function to get all of the basic blocks in a given function address range, and another function to print the disassembly of each of the basic blocks. I'm now trying to get a hash of each basic block using HashStore.
For reference, my reason for using this function is to hash a set of basic blocks for a particular function in two different binary files and then eliminate blocks which have no changes, I believe that HashStore is designed to do exactly this, based on the description...
from ghidra.program.model.correlate import HashStore
from ghidra.program.model.correlate import HashCalculator

def blockDisasm(bb):
	listing = currentProgram.getListing()
	ins_iter = listing.getInstructions(bb, True)

	while ins_iter.hasNext():
		ins = ins_iter.next()
		hashCalc = HashCalculator.calcHash(1337, ins)
		print("{} {}".format(ins.getAddressString(False, True), ins))
		return hashCalc

def getBasicBlocks(funcManager):
    [...]

    hashStore = HashStore(func, monitor)
    [...]
    while(blocks.hasNext()):
	bb = blocks.next()
	hashCalc = blockDisasm(bb)
	dest = bb.getDestinations(monitor)
	while(dest.hasNext()):
		dbb = dest.next()
		if not getFunctionAt(dbb.getDestinationAddress()):
			counter = counter + 1
			print("\t[*] Count: {} Block: {}".format(counter, dbb))

	print("[*] Total Blocks: {}".format(counter))
	hashes = hashStore.calcHashes(0, 0, True, True, hashCalc)
	print(hashes)

However, I am getting this error...
    hashCalc = HashCalculator.calcHash(1337, ins)
TypeError: calcHash(): expected 3 args; got 2

Which suggests something isn't instantiated...? But it should work as far as I can see... Admittedly, Java would probably work better for this.

HashCalculator is an interface that a class would implement, and the method you are trying to call would be valid on an instance of one of those classes... ie. a MnemonicHashCalculator or AllBytesHashCalculator.  Instead you are calling calcHash() it as if it were a static method, which it is not.
Other than that general java advice, I'm out of my depth with func diff stuff.


Support WoodpeckerCI

Support WoodpeckerCI
Documentation: https://woodpecker-ci.org/docs/usage/environment#built-in-environment-variables
Environment variables:

service detection: CI=woodpecker
Branch: CI_COMMIT_SOURCE_BRANCH
Commit sha: CI_COMMIT_SHA
Is Pull request: CI_COMMIT_PULL_REQUEST != ""
Pull request: CI_COMMIT_PULL_REQUEST
Build number: CI_BUILD_NUMBER

We welcome PRs to contribute new services like this one


Sorry for this off topic issue.

Hi @Icecovery
Sorry for this issue that is not related to your project, just that I like the pointer that appears in the gif images and I wanted to know if you can share it. Also, can you tell me that app you used to show the red circles every time you click?
It's just those two things. I await your answer 🙂

Hi @Dhyfer1 , the cursor is from Material Design Cursors Dark by jepriCreations.
The red circle is a feature in HoneyCam, the software I used to record the GIF. There is a similar feature in PowerToys if you want to have it outside recordings.

Wow. Thank you very much for the cursors and for honeycam, 🙂 I didn't know about this program, it seems very interesting.
I use Powertoys but the click effect is not the same. When the "Mouse highlighter" feature in Powertoys is on, it only shows a colored circle, and not a ring as can be seen in your gif.
I haven't had the problem you show in the gif on Windows 11, but I have starred your repo if I need to in the future.
Thank you, and have a nice day. 👍

The red circle is a feature in HoneyCam, the software I used to record the GIF.

Hi. i downloaded honeycam, but change the color of the click effect it's only for paid users 😢. You bought honeycam or did you activate it with a crack?

Hi @Dhyfer1 , I did purchase a permanent license for HoneyCam so I was unaware that the particular feature was only available for paid users.
I suggest you raise this as a feature request over at the PowerToys repository.


WIP: Add ability to modify matched router parameters in middleware

Currently, there is no way to modify the matched parameter values on the router in the middleware.
Part of the problem is that the router is called potentially multiple times in the same request. This PR does not attempt to fix that problem. But, instead it tries to allow both the getting and setting of matched parameter values using the existing request.match_info.

Oh boy this is awesome! :sunglasses:

I like it. Let's get it in to 19.03

Using your branch of sanic (latest commit 4d22b6c3680d1a7d357e031fd4276c9b5c2e8e00).
Example app.
#!/usr/bin/env python3
# -*- coding: utf-8 -*-

from sanic import Sanic

from sanic.response import text

app = Sanic()

@app.middleware
def add_underscore(request):
    if request.match_info and 'username' in request.match_info:
        request.match_info['username'] = "_" + request.match_info['username']

@app.route("/test/<username>")
def http_test(request, username):
    return text(username + "\n")

app.run( host = "<IP_ADDRESS>", port = 8080 )

Assuming /test/hey will always return _hey, but:
$ curl http://vm1:8080/test/hey
_hey
$ curl http://vm1:8080/test/hey
__hey
$ curl http://vm1:8080/test/hey
___hey
$ curl http://vm1:8080/test/hey
____hey
$ curl http://vm1:8080/test/hey
_____hey
$ curl http://vm1:8080/test/hey
______hey
$ curl http://vm1:8080/test/hey
_______hey

Disabling routing cache bug above, but it does not seem to be appliable solution:
diff --git a/sanic/router.py b/sanic/router.py
index 6110a55..a9bf94c 100644
--- a/sanic/router.py
+++ b/sanic/router.py
@@ -416,7 +416,7 @@ class Router:
         # if methods are None then this logic will prevent an error
         return getattr(route, "methods", None) or frozenset()

-    @lru_cache(maxsize=ROUTER_CACHE_SIZE)
     def _get(self, url, method, host):
         """Get a request handler based on the URL of the request, or raises an
         error.  Internal method for caching.

Thanks for catching this. We certainly do not want to bypass the route cache.
TODO

[ ] Add test that hits the endpoint multiple times without unintended consequences from caching the value of match_info

I really have a small hunch that the cache may not be the real issue here (although disabling it seems to fix the problem). I'll take a closer look.

The problem here seems to be that the Router.get method is called twice in this request lifecycle, since match_info is a property on the Request object (that calls the router again). I kind of described this request workflow problem on #1317. IMO, the match_info should be a object (dict, list of namedtuple, immutables, Idk, to be discussed) inside the request instance - but that would require a lot of work on the protocol, router, request and I don't know what else (described in the referenced issue) ...

@vltr I agree. This is something that belongs on the Request. So, while this is a worthwhile and needed feature, the hacky hoops to jump thru are probably not worth it right now.
We need to spend some effort as a community thinking thru the router. I am putting this on hold until we decide.

Moving to 19.6

I think we can bump this one over to 19.9.
I have some ideas that I want to tackle regarding the router and have been playing around with some implementation ideas. I think I found a better way to accomplish this and solve some of the repetitive calls to the router in Sanic.
Regardless, I am closing this PR now because I do not think this is the right approach.


Resource locks

Does the FAQ entry on resource locks refer to locking the RG containing the VM, or the RG containing the vault?
If the former, that's a HUGE problem, since using Azure Backup then precludes the use of resource locks to prevent accidental VM deletes.
If the latter, then keeping the vault and the VMs in separate RGs should be listed as a best practice, to allow locks to be used to protect VMs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88beaa58-adf5-28ef-5510-01ace6923eef
Version Independent ID: 02b2de6f-ba0a-d9dc-fd4f-c0c4d3a46107
Content: Azure VM Backup FAQ
Content Source: articles/backup/backup-azure-vm-backup-faq.md
Service: backup
GitHub Login: @trinadhk
Microsoft Alias: trinadhk

Previously the Azure Backup service used to use the Resource Group where the VM resides to create the Restore point collection and if the group was locked the service couldn’t clean up. We have changed this design in the recent service deployment. Backup service creates a separate resource group than the resource group of the VM to store restore point collection. Customers are advised not to lock the resource group created for use by the Backup service.

Thanks. Where is this new resource group documented? I'm keen to see the documentation around the name of the group and any other advice (e.g. not locking or deleting it)
Thanks again!

https://docs.microsoft.com/en-us/azure/backup/backup-azure-vms-first-look-arm

Thank you!

This seems to have been answered.
#please-close

#close

@jtuliani We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


I got a TypeError here

The TypeError: Blockly.Generator is not a constructor .
I don't understand why, please help.

In fact , I want to shim generator javascript file, and I followed steps of #1033, but it displays an error

@gengshenghong


SG group lookup fails in add_rules_to_sg example

Seeing the following when running with examples/add_rules_to_sg with ocp 4.15
╷
│ Error: [ERROR] No Security Group found with name kube-r010-c3421cd0-e1bc-4c52-847d-c7769ad1220d
│
│   with data.ibm_is_security_group.kube_vpc_sg,
│   on main.tf line 61, in data "ibm_is_security_group" "kube_vpc_sg":
│   61: data "ibm_is_security_group" "kube_vpc_sg" {
│
╵

Looking into issue. Attempting to recreate error first.

PR merged. Closing issue.


Screenreader issue for read-only text fields

When using a screenreader for read-only text fields, the screenreader reads a bullet point to seperate label from textfield instead of the usual asterisk '*'. These bullet points are also read to users which have no meaning to them.
To mark the read-only attribute, vaadin uses an additional HTML5-Attribute '' which is never set to true. Therefore the attribute cannot be interpreted correctly by the screenreader.

These bullet points are also read to users which have no meaning to them.

See also #221

Is this about required fields (hence the bullet), or about readonly fields as described?

Yes, I meant the required fields for example in the Login Dialog. Sorry, if my initial description caused some confusion here.

Ok, so did I understand correctly that you're saying that the problem is twofold as follows?

the bullet is read as "bullet" by the screenreader (as described in #221) AND
the required attribute set on the vaadin-text-field is insufficient for the screenreader to interpret it as required (contrary to the comments in #221)?

Yes, number 1. is true.
For number 2. there is no problem as of now - after checking it again, I realised that the issue was on my end

Closing as duplicate of #221


Install odo completion fails on MacOS using bash

/kind bug

What versions of the software are you using?
Operating System:

System Info

System Version:	macOS 10.14.6 (18G2022)
Kernel Version:	Darwin 18.7.0

Hardware

Mac model id: MacBookPro15,1
Memory: 32 GB
Hard drive capacity: 500 GB
Hard drive used: 102 GB

Output of odo version:

OpenShift version: 4.2.8 (embedded in binary)
crc version: 1.2.0+c2e3c0f
oc Client Version: v4.4.0 / Kubernetes Version: v1.14.6+dea7fb9
odo v1.0.2 (HEAD)

How did you run odo exactly?

Open Bash Terminal
crc start -p pull-secret.txt
eval $(crc oc-env)
oc login -u ... -p ...
odo --complete

Actual behavior
The following error message:

$ odo --complete
Install completion for odo? y
Installing...
Install failed! Did not find any shells to install

Expected behavior

$ odo --complete
Install completion for odo? y
Installing...
Done!

Any logs, error output, etc?
n/a

/area MacOS

I have MacOS 10.14.6 (18G1012)
Install odo completed successfully

odo --complete
Install completion for odo? y
Installing...
Done!

@hanvitha,
I understand that it is working for you, yet it still not working for me. I removed ~/.crc and going to download the new CRC 4.2.10 and see if that works for me.

I have MacOS 10.14.6 (18G1012)
Install odo completed successfully

odo --complete
Install completion for odo? y
Installing...
Done!

I understand that it is working for you, yet it still not working for me. I removed ~/.crc and going to download the new CRC 4.2.10 and see if that works for me.

It shouldn't be related to CRC.
The "Install failed! Did not find any shells to install"  error is coming from https://github.com/posener/complete/blob/05b68ffc813dd10c420993cb1cf927b346c057b8/cmd/install/install.go#L24 inside github.com/posener/complete  library that we use for handling and generating autocompletion for shells.
@GrooveCS What shell do you use? You can run the following command to get name of the currently used shell.
echo $0

closing this issue as it seems to be resolved, if it isn't then please feel free to reopen it.


Change Logout to end Starchart session, but not do SLO

When I login on staging, and then click Logout, I'm logged out of Seneca's SSO.  This is literally never what I want.  Let's fix it so that a logout removes your session only.

I can remove createLogoutRequest everywhere and the logout callback file and just make a post action on the Logout page to destroy session and redirect.


Fix tests for stats.

I might miss the context, but the tests for stats seem strange?
They should be as this PR?

cc @nitlev @HyukjinKwon

Codecov Report

Merging #601 into master will decrease coverage by 2.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   93.25%   90.96%   -2.29%
==========================================
  Files          31       31
  Lines        4804     4804
==========================================
- Hits         4480     4370     -110
- Misses        324      434     +110

Impacted Files
Coverage Δ

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
73.68% <0%> (-10.53%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/frame.py
93.93% <0%> (-0.81%)
:arrow_down:

databricks/koalas/plot.py
93.7% <0%> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65435fd...095f94b. Read the comment docs.


AnimationPlayer playhead Step to scale with zoom level

EDIT: this issue has pivoted to instead suggest that the Step parameter of an animation track to automatically scale with the zoom level of the track, at least as an option.
In order to put a key on an animation track at a time value between a tenth of a second, you appear to have to manually type the value into the individual key editor.
You cannot drag the playhead there or even manually type in a playhead time, no matter how zoomed in the track is:

Perhaps the precision of dragging the playhead should be determined by the zoom level of the track? No matter how far zoomed out the track is, however, I think that the user should be able to manually type in a specific playhead time, without it auto-rounding.
PS: I know that there's currently an AnimationPlayer UX general discussion, but I felt that subdividing these into separate issues makes them easier to close individually.

thats determined by the step parameter

@djrm So it is! Thanks for pointing that out.
It would still be kind of nice to have the Steps parameter automatically scale with the zoom scale on the track. I think that some non-linear video editors do this naturally.

In Godot 3.1, you can manually specify the snap size, so this issue probably isn't relevant anymore:

PS: I know that there's currently an AnimationPlayer UX general discussion, but I felt that subdividing these into separate issues makes them easier to close individually.

Still, could you link the parent issue then?

I think a more intuitive way to handle this would be to add keyboard shortcuts to quickly halve or double the animation editor's step size. We already have similar shortcuts in the 2D editor – in fact, we could reuse the same shortcuts as long as the focus is currently on the animation editor.

Given the low interest for this issue, it's fine to close it already.


bigint support

It is not supported by JSON. Should I look into something like Superjson but for Rust?

Support for bigint would be nice, especially when paired with https://github.com/Brendonovich/prisma-client-rust which has a need for i64 due to Prisma's BigInt type.

@beeb sorry completely missed your comment.
I think that would be the way to go but doing it in an automated fashion is a bit challenging with all the ideas I have had so far.
You can manually encode to string and decode to BigInt and that's what we are doing for Spacedrive.


Chart not refreshing

It only happens to me or there is a bug in the repo?
I tried to cloning the git project and also tried with the library.
I don't think is a problem with my pc, since I can see the demo without any problem

Could you provide full info about your setup?  OS, Browser, node version.
Couldn't reproduce on my side.

using Arch Linux(Manjaro).
executing with  npm run dev
with version 0.3.3 works perfect :-)

Arch Linux(Manjaro).
That's pretty exotic :) I have only ubuntu, will try on it.

If it's not a problem, could find out which version introduced the bug? Is it 0.3.3 -> 0.3.4 ?

Yeah, couldn't catch on ubuntu either.

Above 0.3.3 the library crashes.
I saw that you added some support for retina display on version 0.3.4, maybe that could be the reason of the issue.
But if you don't think is a real problem that needs to be solved, I'm fine using the 0.3.3 :blush:

Thanks! This problem needs to be solved, but without the proper setup it's near to impossible.
I've spent a hell lot of time on retina support, for some reason this was the trickiest part of the development.
Using 0.3.3, you will miss out on many great features! :)

Ok, closing until someone hits this again, need more data.

Hi. I've bumped into same issue on OSX running the example from https://github.com/C451/trading-vue-js#how-to-use added in Nuxt.js boilerplate code.
This happens in Brave browser ( Version 0.68.131 Chromium: 76.0.3809.100 (Official Build) ) and in Chrome ( Version 77.0.3865.90 (Official Build) (64-bit) ) it's all ok. I'll just use Chrome, not a problem for me, just sharing info.

@1am Hi, that's interesting, couldn't catch this in Brave with npm run test, maybe it's because of Nuxt.js? The glitch looks dope tho.

Actually I had the same behaviour in Brave with npm run test. I guess it's some combination of hardware and OS + specific browser since standard Chrome or Safari work fine on OSX.
Repeated similar thing on Ubuntu Mate Linux - Brave not ok / Chrome ok.
Indeed looks interesting

I guess it caused by the retina code, without this block https://github.com/C451/trading-vue-js/blob/master/src/mixins/canvas.js#L12 should work fine.
The lazy solution is to add the retinaSupport flag.


get zig working well on windows

[ ] fix having to use workaround of specifying --target options in order to make tests work
[x] implement ___chkstk_ms
[x] more than some number of output lines is cut off becase os.cpp has a bad implementation of spawning child process on windows
[ ] .\bin\zig.exe --build-file ..\build.zig test all passing
[ ] tests passing on linux running cross compiled behavior tests with wine
[x] pub main or export fn main causes -mconsole, export fn WinMain causes -mwindows.
[ ] cross compiling tetris using zig build system
[ ] native building of tetris
[x] (bonus) don't depend on libc on windows
[ ] set up appveyor to run tests when commits pushed to master
[ ] #463 standard library search path
[ ] get zig building statically
[ ] set up appveyor to provide build artifacts
[ ] fix compile error coloring in the terminal
[ ] exes generated with environment msvc should make pdb files and be debuggable with msvc

There seems to be an issue with LLVM when using the native target features for my laptop. I sent an email  to the llvm-dev mailing list. For now I will check for Windows OS and skip using the target native features as a workaround.

@marler8997 I'm doing a lot of windows work this weekend. Are you around?

I believe the remaining behavior test failure is an LLVM bug: http://lists.llvm.org/pipermail/llvm-dev/2017-September/117864.html
I think I can work around this by specifying extra alignment for packed structs.


OpenAI realtime webRTC implementation

A new way to connect directly the customer to the servers to reduce latency was released recently
https://platform.openai.com/docs/guides/realtime-webrtc
This is not an option due to how livekit works right?

this API is designed for clients to connect to directly. Since Agents is a backend orchestration framework, it wouldn't fit within it very well.
Re latency: Agents already benefit from LiveKit's global network, so it's already optimized quite a bit for that. I think the benefit this over the existing WebSocket API as it applies to Agents, would be limited.


A http based discovery service

Hi,
Would you like to include a http based discovery service where we send straightforward requests to a external service at regular intervals to get the targets info.
This would make it easier to implement custom SD mechanism (my feeling) and would be decoupling the prometheus instance from the SD mechanism allowing for all prometheus servers to use only one service for SD. It will be trivial to deploy this service in a HA configuration compared to a daemon on the same server as prometheus.

The file_sd mechanism covers this via files on disk. In such a setup running one per Prometheus server would be preferable to some form of HA setup, as it has similar failure characteristics but is much simpler.

Hmm.
But then again, take the case of the EC2 tags API. We need to access a throttled resource. We are going to run module based monitoring system with each team more or less having a prometheus server monitoring it.
We will have too many requests to the API, so we cache the tags at one service and then the file_sd based service will be requesting from the service and updating the files. I was hoping to write a generic http_sd service which would make the daemon redundant. I also think its easier to write http endpoints than managing files :).
But any general reservations against the http_sd idea (architecture wise)?

It requires a daemon, whereas files don't. We already support this functionality so I don't see a need for another one of these, especially as curl in a cronjob converts from one to the other.

+1 to curl in a cronjob!
Thanks


Adding FetchSpecRunner component of pipeline

Codecov Report

Merging #66 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   94.94%   95.07%   +0.12%
==========================================
  Files          88       89       +1
  Lines         692      710      +18
==========================================
+ Hits          657      675      +18
  Misses         35       35

Impacted Files
Coverage Δ

config/files.js
100% <ø> (ø)
:arrow_up:

lib/org/chromium/webidl/FetchSpecRunner.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca74dd...ad36549. Read the comment docs.


Lag On Resource Pack Change

Putting Or Removing resource packs somehow laggy with latest 2 release, is this possible to fix?

Whenever you change resource packs, MiEx needs to parse them. Some things, like connected textures can take a bit of time to parse. I can't really do much about it, but I can see if I can push that work onto a different thread so that the UI remains responsive.


Added acceptance test for absolute twitter/og fields in API output

refs https://github.com/TryGhost/Ghost/pull/11975

adds a posts_meta object with relative twitter and facebook image values to one of our post model test fixtures
adds assertions to our Admin API posts acceptance test to show that relative URLs for twitter/facebook images are transformed to absolute
updates the insertPosts and insertPostsAndTags test utils to add the necessary post_id relationship for posts_meta
updates tests that are manually truncating the posts related tables to also truncate the posts_meta table

TODO:

[ ] fix failing tests

This set of changes might benefit from fixes to the data generator introduced with https://github.com/TryGhost/Ghost/commit/d177852d1f4b3d0eb4b28299bfd635d047f505d0 (and few commits around it)


Check context file without blocking GUI thread

I noticed some time ago that a large part of what makes starting the GUI slow is waiting for the context file check, which usually involves starting a subprocess with a different Python, and often also doing some fairly heavy imports in the context file.
This pushes these operations into a separate thread, so we can start using the GUI before the context file check finishes. It also means saving the context file doesn't block the GUI.
Naturally, more async makes the tests a bit more complicated, but I think it's manageable.

LGTM

Oops, I missed the LGTM. Thanks!


Test windows build

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (486cb35) 16.34% compared to head (ff1cb2b) 16.39%.

:exclamation: Current head ff1cb2b differs from pull request most recent head 5d22974. Consider uploading reports for the commit 5d22974 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1109      +/-   ##
===========================================
+ Coverage    16.34%   16.39%   +0.05%
===========================================
  Files           51       51
  Lines         6846     6849       +3
===========================================
+ Hits          1119     1123       +4
+ Misses        5727     5726       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(Refactor) Limit the use of root

At the present moment, it is possible to grant ssh access to root user, even though it doesn't seem to be necessary for the playbook to run. Some cloud hostings like amazon or azure by default prevent user from connecting as root.
I suggest to

don't explicitly grant ssh access for root user
where possible, don't run tasks under root

Can be closed now due to referenced PRs


Update service-fabric-reliable-actors-timers-reminders.md

Fixed link to C# Sample code

@Expecho,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@vturecek Please review these proposed contributions. Thanks.

@Expecho Thanks!

#sign-off


Passwords recorded in firewall_logs database table.

A suggestion to remove the passwords used by users from the firewall_logs table.
Currently both the username and the attempted password are stored in clear text in the log in the request field. This is considered extremely bad security practice. The suggestion is that you remove or obfuscate the password at a minimum.
For example
_token=cbgHF2wMw2loK6nNAuEPkhyUod75roFfmjzkZGFp&email=greg@gmail.com&password=SL8dNS)@j!

Should be stored something like this:
<EMAIL_ADDRESS>
Or
<EMAIL_ADDRESS>

Fixed in latest version.

This ist still a problem when used with Livewire / Filament where the password is within the components array of the request:
&components[0][updates][data.password]=FooBar123


[SPARK-8567] [SQL] [DO NOT MERGE] Debugging flaky HiveSparkSubmitSuite

Using similar approach used in HiveThriftServer2Suite to print stdout/stderr of the spawned process instead of logging them to see what happens on Jenkins. (This test suite only fails on Jenkins and doesn't spill out any log...)
cc @yhuai

Merged build triggered.

Merged build started.

@yhuai Somehow I can partly reproduce this issue locally: no log in unit-tests.log, but didn't observed the timeout. After resorting to println rather than logInfo, I found out that one test case is trying to download Hive dependencies via Ivy. Opening this PR to see whether we can figure out what happens on Jenkins.

Test build #35657 has started for   PR 6978 at commit b031647.

Test build #35657 has finished for   PR 6978 at commit b031647.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #35661 has started for   PR 6978 at commit b031647.

Test build #35661 has finished for   PR 6978 at commit b031647.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

I am merging it to master. So, we will see the logs from these tests and start to debug why they can be slow.


Fix: Multiple adapters with bnb layers

Resolves #1239
Description
Fixes a bug that led to an error when loading multiple adapters into a
peft model that uses bnb layers.
Notes
I tested this locally on GPU and tests pass for me.
Implementation
While working on this, I thought we could make a simplification to our
layer code. Right now, we have code like this inside of
_create_and_replace:
    if isinstance(target, conv2d):
        target.update_layer_conv2d(...)
    elif isinstance(target, embedding):
        target.update_layer_embedding(...)
    elif ...

If we move the update_layer* methods from LoraLayer to the subclasses,
i.e. Linear, Embedding, etc., and give them all the same name (i.e.
update_layer_embedding => update_layer), we could simplify the code
above to:
    if isinstance(target, LoraLayer):
        target.update_layer(...)

Additionally, it makes more sense to me that the code for
update_layer_embedding lives inside of Embedding, not the parent class.
If you agree, I could work on that in a separate PR.

while I tried to use this solution to load multiple lora in peft model, it appear a error.
245     parent, target, target_name = _get_submodules(model, key)
247     optional_kwargs = {
248         "loaded_in_8bit": getattr(model, "is_loaded_in_8bit", False),
249         "loaded_in_4bit": getattr(model, "is_loaded_in_4bit", False),
250         "current_key": key,
...
1672     buffers[name] = value
1673 else:
-> 1674     super().setattr(name, value)
AttributeError: can't set attribute 'weight'
and it seems to work if I modify the code in _create_new_module this way:
elif AutoGPTQQuantLinear is not None and isinstance(target_base_layer, AutoGPTQQuantLinear):
new_module = QuantLinear(target, adapter_name, **kwargs)
###xlc
if target == None:
target.weight = target_base_layer.qweight
else:
target = target_base_layer
target.weight = target_base_layer.qweight

@ChrisXULC Thanks for reporting. Do you have some code to reproduce the error?

@ChrisXULC Thanks for reporting. Do you have some code to reproduce the error?

@BenjaminBossan it could be reproduce while trying to load multiple loras into Qwen 7b int 4 model. before loading loras, I have modified the anaconda3/envs/lib/python3.10/site-packages/peft/tuners/lora/model.py like you did.
model = AutoModelForCausalLM.from_pretrained(
"/home/models/qwen/Qwen-7B-Chat-Int4",
device_map="auto",
trust_remote_code=True
# use_cache_quantization=True,
#  use_cache_kernel=True,
# use_flash_attn=False
).eval()
model = PeftModel.from_pretrained(model,'/home//models/quantized_model_lora', adapter_name="23",device_map="cuda", load_in_4bit=True)
model.load_adapter('/home/lora_all/quantized_model_vul',adapter_name = '22')

@ChrisXULC Thanks a lot. The issue should be fixed with the latest commit. I omitted the if target == None: guard in from your suggestion, I don't think that can happen, but LMK if I'm wrong.

@BenjaminBossan I have changed it to target.qweight=target_base_layer.qweight，I think it should be ok

@ChrisXULC Thanks for checking. If you also have time to check PEFT from this branch, that would be fantastic.

@BenjaminBossan cool!

Tests are green now after merging #1252, I'll merge this one too.


Trigger major release

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: # (issue, if applicable)
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[x] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Remove color attributes from label configurations in the GitHub settings file to simplify label management.
Enhancements:

Remove color specifications from label configurations in the GitHub settings file.

:tada: This PR is included in version 3.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


The "composite" tsconfig option is not explicitly documented anywhere

A tsconfig.json generated by tsc --init contains an entry "composite": true under compilerOptions, with the comment that this "enables project compilation". The option itself is not mentioned in either https://www.typescriptlang.org/docs/handbook/compiler-options.html or https://www.typescriptlang.org/docs/handbook/tsconfig-json.html and the website itself appears to lack any search function. Whilst I've no doubt the explanation is obvious to people familiar with TS terminology, I'm a little clueless about what "project" is referring to.
Could somebody possibly elaborate on what this setting is doing?

Documentation for this new setting (introduced in 3.0) can be found in Project References:

Referenced projects must have the new composite setting enabled. This setting is needed to ensure TypeScript can quickly determine where to find the outputs of the referenced project. Enabling the composite flag changes a few things:

The rootDir setting, if not explicitly set, defaults to the directory containing thetsconfig file
All implementation files must be matched by an include pattern or listed in the files array. If this constraint is violated, tsc will inform you which files weren’t specified
declaration must be turned on

But I agree we should provide info (or at least point to the link above) in the documentation for tsconfig / Compiler Options

Thanks @chrissantos1995 that's a great help for now; and agreed a reference would be very useful

I've created PR updating documentation
https://github.com/Microsoft/TypeScript-Handbook/pull/858

But what is "Referenced project" 🤔


Ungroup items in solution explorer

How can I ungroup items in solution explorer. Right now all my .ts and .css files are grouped beneath .html files which is default behaviour. But I do not want this.

This is a Visual Studio / aspnet tooling issue actually, it's still open here : https://github.com/aspnet/Tooling/issues/347 but I agree If anything i would prefer the TS file to be the main one.
Try VSCode for now, it has better TypeScript support as well currently.

Agreed with @MarkPieszak's answer.


ST-131 fix "null" being appended

Fixes https://github.com/RetailMeNot/TestRailSDK/issues/29

looks good, silly nulls


how to customize chart labels

i am making use of prefix and suffix but i still present the percentage.
is there a way to present another value (i have the absolute value, would like to present it instead of the percentage) in lables?
using VueUiSparkbar.
this library is awesome.
thanks for any guidance.

Ok i got a workaround:

const receitaDespesaTotalPeriodo = computed(() => {
  const total = dashboardState.store.dashboard.receitaDespesaTotalPeriodo
    .reduce((acc, e) => {
      acc += e.value
      return acc
    }, 0)
  return dashboardState.store.dashboard.receitaDespesaTotalPeriodo.map(r => ({
    ...r,
    name: `${r.label} ${prepareMoney(r.value)}`,
    value: 100 * r.value / total,
  }))
})

and styles.labels.value.show=false in config.

Hey:)
There are currently  no "prefix" and "suffix" config options for this component.
I'm going to fix that, as your use case clearly shows it's missing.
If I understand your use case correctly, you would ideally need to pass only the value in the dataset, which would be used as percentages for the bars, but with custom prefix | suffix.
Currently, using style.layout.percentage: false, and setting style.layout.target to the total  should allow you to pass only values, and draw bars as value / total automatically. The missing config option for prefix and suffix would remain, but when added, this combo should allow you to remove this additional computation.
I'll keep you posted here after I take a deeper look.
Cheers

Hey, thanks a lot for that, will use that way, it simplifies many of my dashboard computed values!

And id got gorgeous! Thanks again for the guidance!
const receitaDespesaBarConfig = computed(() => {
  const total = dashboardState.store.dashboard.receitaDespesaTotalPeriodo
    .reduce((acc, e) => {
      acc += e.value
      return acc
    }, 0)
  return {
    style: {
      ...sparkBarConfig.style,
      layout: {
        ...sparkBarConfig.style.layout,
        independant: true,
        percentage: false,
        target: total
      }
    }
  }
})

const receitaDespesaTotalPeriodo = computed(() => {
  return dashboardState.store.dashboard.receitaDespesaTotalPeriodo.map(r => ({
    ...r,
    name: r.label,
    prefix: "R$ "
  }))
})

You're welcome !
That's neat indeed.
The docs should probably have examples of such use cases, as it is not intuitive to toggle these config options to achieve this kind of result.
Thanks for using the lib, and for reaching out:)


Add parameter for saving all TimePoints

New Feature Summary
Add a parameter for saving all TimePoints with their classifications, something like
metadata.add_parameter(
    name='saveAllTimePoints', type='boolean', default=False,
    description='Also save TimePoint instances outside of TimeFrames')

Related
No response
Alternatives
No response
Additional context
No response

fixed via #83.


Forgot password is not working

Forgot password is not working properly even when i am trying forgot password on your web url getting error over there also..

sometimes there are issues in the demos that don't work, try setting up one (it fixed my issue with logging in with github)


Responsivity of Tracks page

It should support the break points
(min-width:320px) { /* smartphones, iPhone, portrait 480x320 phones / }
(min-width:481px) { / portrait e-readers (Nook/Kindle), smaller tablets @ 600 or @ 640 wide. / }
( min-width:641px) { / portrait tablets, portrait iPad, landscape e-readers, landscape 800x480 or 854x480 phones / }
(min-width:961px) { / tablet, landscape iPad, lo-res laptops ands desktops *
(min-width:1025px) { /* big landscape tablets, laptops, and desktops */

Solved here #312.

Done.