FRP interface reactiveOf

This patch allows users to create interactions by defining a FRP
program, based on the reflex library. The dependency on reflex is
optional, and enabled with -freflex.
This is a result of some hacking with the reflex people at the Compose
Unconference (but all the code in this patch is mine).
A mode where even reactive collaborations are supported depends on some
fancy new feature in reflex, which would allow stats to be reset.
This might be of interest to @ryantrinkle and the other reflex guys.

@ali-abrar

If it's the additional dependency, I don't have any concerns about it. I'm happy to just depend on reflex without the flag.

That was my worry. But if that is not a problem, I can remove it.
Caveat: I have built reflex from github. I guess I should test if this actually works with reflex from hackage…
I think the interface is pretty much the only sensible (the other option would be a Behaviour Time, but Ryan advised against it).
I am also less worried about polluting the API, it is the “advanced” API anyways.

I'll get the new version of Reflex up on hackage ASAP.  I'd recommend holding off on upstreaming this until then, as there have been some breaking changes.

I'd recommend holding off on upstreaming this until then, as there have been some breaking changes.
Ok, will do . I changed the version range to require 0.5.

Ryan, f93f42c has a sketch of the simple interface I would like to see. The downside is that it hard-codes the number of events and behaviors, and I am temped to pull out heterogeneous lists to fix that … but then it would not longer be simple…

Given that events can be merged and fanned out, maybe you can get away with just one event for the simple host example.

I was wondering: Is there a performance penalty of merging and fanning out?
Also, this eventTriggerRef can contain a Maybe. If this is Nothing, does this mean that nobody is listening to this event? If CodeWorld could see that the time event is not used, it could avoid looping  (it already does that in the other drivers, by some tricks involving comparing StableNames).
But that would break if the two events were merged and fanned out, right?

There's not much of a penalty for fanning out - about the same as
traversing any other event.  The fan primitive is designed to be lazy, so
even if you have an infinite number of keys in the potential input, you can
still deliver them efficiently.  The overhead is something like
O(log(number of distinct keys that have been subscribed to)).
On Mon, May 22, 2017 at 11:00 AM, Joachim Breitner<EMAIL_ADDRESS>
wrote:

I was wondering: Is there a performance penalty of merging and fanning out?
Also, this eventTriggerRef can contain a Maybe. If this is Nothing, does
this mean that nobody is listening to this event? If CodeWorld could see
that the time event is not used, it could avoid looping (it already does
that in the other drivers, by some tricks involving comparing StableNames
).
But that would break if the two events were merged and fanned out, right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/codeworld/pull/486#issuecomment-303126038, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABGlYJE7qOunf3EbGEQa5K3X5ZOrBPbSks5r8aMCgaJpZM4Nh0DV
.

@nomeata @ryantrinkle Is there a fundamental reason why making time a Behavior is a bad idea?  It seems like the obvious choice to me.  Is this just a matter of the implementation being awkward, or is there something wrong with the abstraction?

Defining time as a Behavior has strange semantics in some subtle ways.  The most important of these is that many of the things you'd like to define won't work if time is a Behavior - in particular, you can't do something like "Fire an Event when this Behavior crosses 0" and then invoke it on now - myDeadlineBehavior, because Behaviors are pull-driven, and thus can't spontaneously push things.
It would also require (much) more information about the function the Behavior represents than we actually have.  Discontinuous functions would be quite challenging to deal with.
Now, you could certainly accumulate an Event t DiffTime (or similar) to create a Behavior t Time, but this Behavior would move stepwise, which might not be expected.  Also, the natural way in Reflex would be to have the Behavior represent the last frame's time, not the current frame's time, which might be confusing for some users.  It would be possible to update the Behavior in one frame, and then fire the delta time Event in another frame - Reflex guarantees that Behavior updates like that aren't observable by the program, so I think the semantics would work out.  This would probably be the way to go if you wanted to provide now :: Behavior t Time.  The Event t DiffTime would still need to be provided, so that local state can be updated and things like that (Behavior changes can't cause that in Reflex).

Okay, I see.  Yeah, I guess if you had a Behavior for time, then you'd also need an oftenEnough :: Event t () that fires every frame, so you could start from that and filter down to an Event that captures important time thresholds.  And now by trying to simply one of the two components, we've ended up with three components instead...

@cdsmith Yep!  Eventually, if we did a whole lot of work on continuous-time FRP (which Reflex is designed to be consistent with, as an extension), we might be able to provide something cleaner.  However, I think making continuous time FRP nice to work with is still an open problem, and Reflex's approach of "time is just a totally-ordered set" seems to be great for most kinds of applications.

@nomeata Do you prefer to merge this, or wait for Reflex changes?  If the former, I'd prefer not to define a module in the Reflex hierarchy here.  If that's just interim and you don't want to merge this, that's fine.  Just checking.

Oh, yeah, let's get Reflex.SimpleHost into Reflex.  I'm getting close to having 0.5 ready for release, and I think I could stick that in quite easily.  @nomeata Thoughts?

There is no reason to hurry with this PR, so moving this module (or something similar) to reflex first, and then adjusting this branch to build on the release 0.5, makes sense.

@nomeata @ryantrinkle
I have a renewed interest in merging something like this now.  I'm interested in turning http://code.world/haskell into a more general-purpose UI for building Haskell code with commonly used APIs.  The first three on my list are gloss, reflex, and diagrams.
Any thoughts on the right path forward here?  There was some discussion about making changes to reflex to make this easier, and of this not working correctly with reflex.  I'm happy to poke around a bit myself, but I may as well ask first.

I think the question was just whether simpleReflexHost ought to live in reflex, but I don’t think you should be held up by this.

I have a renewed interest in merging something like this now. I'm interested in turning http://code.world/haskell into a more general-purpose UI for building Haskell code with commonly used APIs. The first three on my list are gloss, reflex, and diagrams.

@cdsmith  I had already been doing some hacking on the gloss front: https://github.com/hpacheco/codeworld-api-gloss


features field on generated manifest file should be an object instead of an array.

Describe the bug
On generated manifest file from neo3-boa, features should be an object instead of an array.
How to Reproduce
Contract code
from boa3.builtin import NeoMetadata, metadata, public
from boa3.builtin.interop.storage import put

@public
def Main():
    put('hello', 'world')

@metadata
def manifest() -> NeoMetadata:
    meta = NeoMetadata()
    meta.author = "COZ in partnership with Simpli"
    meta.email =<EMAIL_ADDRESS>    meta.description = 'This is a contract example'
    return meta

Compiled Manifest File
{
    "name": "hello-contract",
    "groups": [],
    "abi": {
        "methods": [
            {
                "name": "Main",
                "offset": 0,
                "parameters": [],
                "returntype": "Void",
                "safe": false
            }
        ],
        "events": []
    },
    "permissions": [
        {
            "contract": "*",
            "methods": "*"
        }
    ],
    "trusts": [],
    "features": [],
    "supportedstandards": [],
    "extra": {
        "Author": "COZ in partnership with Simpli",
        "Email"<EMAIL_ADDRESS>        "Description": "This is a contract example"
    }
}

Expected behavior
Should the features field be an object, instead of an array?
Compiled Manifest File
{
    "name": "hello-contract",
    "groups": [],
    "abi": {
        "methods": [
            {
                "name": "Main",
                "offset": 0,
                "parameters": [],
                "returntype": "Void",
                "safe": false
            }
        ],
        "events": []
    },
    "permissions": [
        {
            "contract": "*",
            "methods": "*"
        }
    ],
    "trusts": [],
    "features": {},
    "supportedstandards": [],
    "extra": {
        "Author": "COZ in partnership with Simpli",
        "Email"<EMAIL_ADDRESS>        "Description": "This is a contract example"
    }
}

Platform:

OS: Linux
Version: neo3-boa v0.8.3
Python version: Python 3.8.5

(Optional) Additional context
Manifest files generated from dot-net and neow3j (java) libraries output the features as an object. I am not entirely sure what that field does. This is mostly a parsing issue.
I am using this piece of code  in https://github.com/intellij-neo/intellij-neo and neow3j expects a HashMap, hence this throws an error.

According to NEP-15 The features field will be used for future expansion and should always be an empty object for now.


fix missing initialization_delay parameter in update function

TrackedObject is expecting its 4th argument to be initialization_delay, but tracker.update was forgetting to pass it.
The issue was that detection_threshold was initialized with the value of period (1 by default), which lead to incorrect tracking.

initialization_delay should also not be None because we compare its value bellow
if initialization_delay < 0
and this fail if initialization_delay is None.

Hey thanks a lot for finding this bug! I ended up fixing it in https://github.com/tryolabs/norfair/commit/a2633c9e974da38f3681d8c196682fd925fe0aaf .
Removed all defaults from TrackedObject so this sort of bug doesn't slip by again, and added some logic to handle None correctly. We actually need to use None because we want to initialize initialization_delay using two of the function's arguments, so we can't just set a default in the signature, and need to run some code in __init__ for this.
Thanks again!


Watcher fails with 410 "GONE"

If one particular event type is been watched (e.g. Namespace changes) and no new events happen for a long time, but other events, that are not being watched happen, the other, non-watched events, cause the RV to increase.
Eventually the RV that is stored in the watcher is too old to be used, and the watcher fails returning a  410 response code.
If an original RV was passed to the watcher, the supervisor restarts the watcher with the same init parameters, and it fails again.
Possible solutions:

Parse the message that comes back to extract a later RV

Send a message to the caller to inform it that it can no longer watch and it should start again

Somehow obtain the latest RV from K8S without potentially missing events

Logs below:
FunctionClauseError) no function clause matching in Kazan.Watcher.extract_rv/1
    (kazan) lib/kazan/watcher.ex:235: Kazan.Watcher.extract_rv(%{"apiVersion" => "v1", "code" => 410, "kind" => "Status", "message" => "too old resource version: 20293058 (20295457)", "metadata" => %{}, "reason" => "Gone", "status" => "Failure"})
    (kazan) lib/kazan/watcher.ex:219: anonymous fn/4 in Kazan.Watcher.process_lines/2
    (elixir) lib/enum.ex:1899: Enum."-reduce/3-lists^foldl/2-0-"/3
    (kazan) lib/kazan/watcher.ex:158: Kazan.Watcher.handle_info/2
    (stdlib) gen_server.erl:616: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:686: :gen_server.handle_msg/6
    (stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
Last message: %HTTPoison.AsyncChunk{chunk: "{\"type\":\"ERROR\",\"object\":{\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\"too old resource version: 20293058 (20295457)\",\"reason\":\"Gone\",\"code\":410}}\n", id: #Reference<0.4253789252.1463549953.187567>}

@obmarg any further ideas on how to solve this?  My current preference is option (2) above.

@chazsconi do you have any code that can reproduce this situation?  I'd like to investigate a little before deciding on a solution.

@chazsconi Yeah, I agree it seems like a normal thing to happen.  Definitely something Kazan should do something about.  Since it seems to happen in response to other things changing in the database, I was hoping there'd be a simple way to induce the issue by just changing tons of un-watched resources.  Though I guess it depends precisely what changes need to be made in order to induce the issue.
I did come across this PR that updates kubectl to handle something similar.  Seems like (though I've not yet tested) if you specify a resourceVersion of "0" you'll get sent the latest resource, and then any updates to that resource.  Was wondering if we could utilize this for the issue you're experiencing, though wanted to play around with the issue to see whether it made sense before suggesting...

@obmarg I tried to reproduce the problem by creating a watch for pod changes in a namespace and then making changes to a config map, but even after 75000 changes to the config map the problem did not occur on the watch.
However, as you say, specifying a resource version of "0" appears to send only new events.  So a simple solution is to fix the code to revert to resource version "0" when the "too old resource version" problem occurs.
However there is a possibility of events being missed between the original watch failing and restarting it with resource version "0" - if this is critical, then the consumer can be informed and it can refetch everything again.
Therefore maybe providing both options in the library would be best and allow the consumer of the library to choose which they prefer:

Inform the consumer and terminate the watch
Restart from resource version "0"

@chazsconi Yeah, maybe we'll end up having to do that.  Though I don't know if I'm too happy with an option that forces people to pick between handling a semi-rare event (that we can't explain enough about to say when it'll happen) and potentially losing events.  Though since this seems to happen when the event hasn't been updated for days, it seems like the chances of it changing in the second or so where we're restarting the watch is unlikely.
I definitely want to do a bit more investigation around this before settling on a fix, though if you're blocked I'd be happy to release a temporary fix.

@obmarg I actually the saw the problem occur again today.  An event had been received on the watched resource around 1 hour before, so it's certainly not days before this happens.
We are currently using K8S v1.8.8.  We are planning to upgrade to v1.9.7 next week, and I'd be interested to see if the problem still occurs after the upgrade.

@obmarg I'm currently running against my fork in production with this fix:
https://github.com/chazsconi/kazan/commit/42b297dd89ca30d1d714f9400c0f47cae8d2a067
As I cannot reproduce this in tests I'm waiting for the scenario to re-occur to check that this fixes the problem.  After that I can create this as a PR.

Unfortunately this does not work.  Setting the resource version to "0" causes some previous changes to be resent, as done not setting a resource version at all.
After checking the K8S docs, I found that the correct way to do it, is to refetch the resources.
(https://kubernetes.io/docs/reference/api-concepts/)

When the requested watch operations fail because the historical version of that resource is not available, clients must handle the case by recognizing the status code 410 Gone, clearing their local cache, performing a list operation, and starting the watch from the resourceVersion returned by that new list operation.

Therefore, I believe that option (1) that I listed above is the solution. i.e. inform the consumer, and let the consumer decide how to deal with it.

No problem.  We're currently running with with a fork using this commit in production:
https://github.com/chazsconi/kazan/commit/a201af75f9e945c57c0b48485a493295d66d2edf for the last couple of weeks and it appears to solve the problem, although, of course, we need to handle the 410 in the consumer.
This is a breaking change as the messages now sent to the consumer are a different struct so the from can be included.

Ok, so I'd ideally like a way for kazan to handle this automatically.  However, it's not clear the best way to do that, and forcing users to handle it is at least a step in the right direction (since it's currently un-handleable).  If you want to make a PR with that branch I'd be happy to accept after a bit of review.

@obmarg Sorry for the delay - PR now created.

No problem, thanks for the PR 👍. I’m without access to a laptop for the
next couple of weeks. Will give it a look once I’m back.
On Fri, 15 Jun 2018 at 18:29, chazsconi<EMAIL_ADDRESS>wrote:

@obmarg https://github.com/obmarg Sorry for the delay - PR now created.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/obmarg/kazan/issues/45#issuecomment-397657933, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAh9ymDmMTmyXmsYY3p1eA4ChGj1tMqiks5t89LngaJpZM4T0vSh
.

Fixed in #47


generate docs

We can use travis to generate the docs and push to the gh-pages branch (or use master directly) or use Read The Docs.
In any case, the docs should be live somewhere.

The docs for the most basic version of the tutorial are now live on RTD. It follows the version made for BioXFEL in summer 2016, which was in turn adapted from the  AdKTutorial from  PHY 598 – Simulation approaches to Bio- and Nanophysics.
There are now two things left to do:

update the files and directories to ensure consistency with the actual documentation
create an "advanced" version of the tutorial that has bash scripts, multi-step equilibration, and documentation specific to members of the lab (e.g., module load gromacs/5.1.3/..., etc.)

I'll create separate issues to deal with these tasks.


Barba.js with yandex metrica webvisor

Hi, I encountered such a problem, yandex webvisor does not display transitions based on this documentation https://yandex.ru/support/metrika/code/ajax-flash.html I got this code
Barba.Dispatcher.on('newPageReady', function(currentStatus, prevStatus) {
  yaCounterXXXXXX.hit(currentStatus.url, {
    title: document.title,
    referer: prevStatus.url,
  });
});

but the problem is that in main.js I can not put it because the object yaCounterXXXXXX is not defined and linter does not miss, if I put it into the script tag then the object Barba becomes undefined ...
How to solve this problem???

Hello, is it just a problem with the linter?
make sure that yaCounterXXXX exists before calling it


Added option to insert username and password for SMTP authentication.…

… Login is attempted if username is not empty.

Closes #2


Fold by level same problem as issue 489

https://github.com/bonecode/TBCEditor/issues/489

by the way do reading comments in closed issues ?
github.com/bonecode/TBCEditor/issues/493
github.com/bonecode/TBCEditor/issues/496

Fixed this issue.
Sure, I get notifications via e-mail. I will reopen issues, if needed.


Saving to parquet with partition_on results in loss of divisions when reading it back to dataframe.

TLDR
When I save a Dask dataframe to parquet using partition on a certain collumn and then I read those parquet files into a dataframe the divisions are lost. This doesn't happen with every dataframe, for example if the collumn I'm using for the partitioning (let's call it 'Categoricals') is ordered then this problem won't happen. Below I'll leave an example where the problem happens and one where it doesn't.
Imports
import numpy as np
import pandas as pd
import dask.dataframe as dd
from fastparquet import ParquetFile

/usr/lib/python3.5/importlib/_bootstrap.py:222: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
  return f(*args, **kwds)
/usr/lib/python3.5/importlib/_bootstrap.py:222: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility. Expected 96, got 88
  return f(*args, **kwds)

Example where divisions are known
Here I created a dummy dataframe where the column by which we partition ('Categoricals') is ordered, as can be seen the divisions are known after loading the parquet file.
def generate_df(size):
    df = pd.Series(np.arange(0, size), name='unique').to_frame()

    df['dates'] = pd.date_range('2015-01-01', periods=size, freq='1min', name='dates')
    df['ints'] = np.linspace(0, 100, size, endpoint=False, dtype=int)
    df['floats'] = df['ints'].astype(float)
    df['constants'] = 42
    df['uniques'] = df['unique'].astype(str)

    # nanints is ints with first 10% entries set to nan
    df['nanints'] = df['ints']
    df.loc[df.index < int(size / 10), 'nanints'] = np.nan

    # generate categorical column with 4 distinct values
    categoricals = []
    for value in ['a', 'b', 'c', 'd']:
        categoricals += [value] * int(size / 4)
    df['categoricals'] = categoricals
    df['nancategoricals'] = df['categoricals'].replace('d', np.nan)

    return df

df = generate_df(16)

df = df.set_index('dates')
df = dd.from_pandas(df, npartitions=3)

df.head(16, npartitions=-1)

unique
ints
floats
constants
uniques
nanints
categoricals
nancategoricals

dates

2015-01-01 00:00:00
0
0
0.0
42
0
NaN
a
a

2015-01-01 00:01:00
1
6
6.0
42
1
6.0
a
a

2015-01-01 00:02:00
2
12
12.0
42
2
12.0
a
a

2015-01-01 00:03:00
3
18
18.0
42
3
18.0
a
a

2015-01-01 00:04:00
4
25
25.0
42
4
25.0
b
b

2015-01-01 00:05:00
5
31
31.0
42
5
31.0
b
b

2015-01-01 00:06:00
6
37
37.0
42
6
37.0
b
b

2015-01-01 00:07:00
7
43
43.0
42
7
43.0
b
b

2015-01-01 00:08:00
8
50
50.0
42
8
50.0
c
c

2015-01-01 00:09:00
9
56
56.0
42
9
56.0
c
c

2015-01-01 00:10:00
10
62
62.0
42
10
62.0
c
c

2015-01-01 00:11:00
11
68
68.0
42
11
68.0
c
c

2015-01-01 00:12:00
12
75
75.0
42
12
75.0
d
NaN

2015-01-01 00:13:00
13
81
81.0
42
13
81.0
d
NaN

2015-01-01 00:14:00
14
87
87.0
42
14
87.0
d
NaN

2015-01-01 00:15:00
15
93
93.0
42
15
93.0
d
NaN

df.divisions

(Timestamp('2015-01-01 00:00:00'),
 Timestamp('2015-01-01 00:06:00'),
 Timestamp('2015-01-01 00:12:00'),
 Timestamp('2015-01-01 00:15:00'))

df.to_parquet('./data_new', engine='fastparquet', partition_on=['categoricals'])

/home/felgueira/.local/lib/python3.5/site-packages/fastparquet/writer.py:407: FutureWarning: Method .valid will be removed in a future version. Use .dropna instead.
  out = data.valid()  # better, data[data.notnull()], from above ?

pq_f = ParquetFile('./data_new')

df = dd.read_parquet(pq_f)

df.divisions

(Timestamp('2015-01-01 00:00:00'),
 Timestamp('2015-01-01 00:04:00'),
 Timestamp('2015-01-01 00:06:00'),
 Timestamp('2015-01-01 00:08:00'),
 Timestamp('2015-01-01 00:12:00'),
 Timestamp('2015-01-01 00:15:00'))

Example where divisions are not known
Here I created a dummy dataframe where the column by which we partition ('Categoricals') is not ordered because of an "outlier", as can be seen the divisions are not known after loading the parquet file.
def generate_df(size):
    df = pd.Series(np.arange(0, size), name='unique').to_frame()

    df['dates'] = pd.date_range('2015-01-01', periods=size, freq='1min', name='dates')
    df['ints'] = np.linspace(0, 100, size, endpoint=False, dtype=int)
    df['floats'] = df['ints'].astype(float)
    df['constants'] = 42
    df['uniques'] = df['unique'].astype(str)

    # nanints is ints with first 10% entries set to nan
    df['nanints'] = df['ints']
    df.loc[df.index < int(size / 10), 'nanints'] = np.nan

    # generate categorical column with 4 distinct values
    categoricals = []
    for value in ['a', 'b', 'c', 'd']:
        categoricals += [value] * int(size / 4)
    categoricals[10] = 'b'
    df['categoricals'] = categoricals
    df['nancategoricals'] = df['categoricals'].replace('d', np.nan)

    return df

df = generate_df(16)

df = df.set_index('dates')
df = dd.from_pandas(df, npartitions=3)

df.head(16, npartitions=-1)

unique
ints
floats
constants
uniques
nanints
categoricals
nancategoricals

dates

2015-01-01 00:00:00
0
0
0.0
42
0
NaN
a
a

2015-01-01 00:01:00
1
6
6.0
42
1
6.0
a
a

2015-01-01 00:02:00
2
12
12.0
42
2
12.0
a
a

2015-01-01 00:03:00
3
18
18.0
42
3
18.0
a
a

2015-01-01 00:04:00
4
25
25.0
42
4
25.0
b
b

2015-01-01 00:05:00
5
31
31.0
42
5
31.0
b
b

2015-01-01 00:06:00
6
37
37.0
42
6
37.0
b
b

2015-01-01 00:07:00
7
43
43.0
42
7
43.0
b
b

2015-01-01 00:08:00
8
50
50.0
42
8
50.0
c
c

2015-01-01 00:09:00
9
56
56.0
42
9
56.0
c
c

2015-01-01 00:10:00
10
62
62.0
42
10
62.0
b
b

2015-01-01 00:11:00
11
68
68.0
42
11
68.0
c
c

2015-01-01 00:12:00
12
75
75.0
42
12
75.0
d
NaN

2015-01-01 00:13:00
13
81
81.0
42
13
81.0
d
NaN

2015-01-01 00:14:00
14
87
87.0
42
14
87.0
d
NaN

2015-01-01 00:15:00
15
93
93.0
42
15
93.0
d
NaN

df.divisions

(Timestamp('2015-01-01 00:00:00'),
 Timestamp('2015-01-01 00:06:00'),
 Timestamp('2015-01-01 00:12:00'),
 Timestamp('2015-01-01 00:15:00'))

df.to_parquet('./data_new', engine='fastparquet', partition_on=['categoricals'])

/home/felgueira/.local/lib/python3.5/site-packages/fastparquet/writer.py:407: FutureWarning: Method .valid will be removed in a future version. Use .dropna instead.
  out = data.valid()  # better, data[data.notnull()], from above ?

pq_f = ParquetFile('./data_new')

df = dd.read_parquet(pq_f)

df.divisions

(None, None, None, None, None, None)

(Also this issue probably belongs in fastparquet repo?)

Also this issue probably belongs in fastparquet repo?

@martindurant does the fastparquet repo seem like the appropriate place for this issue?

This is not a fastparquet issue, no, but a fundamental limitation of partitioning in dask. I can imagine having better parquet-statistics-based optimisation down the line, but not immediately. This specific issue could be closed with docs clarification.


Added github.sha to DockerHub push

Resolves https://github.com/summerwind/actions-runner-controller/issues/285.
Adds a reference to GITHUB_RUN_NUMBER so that tags are generated dynamically. https://docs.github.com/en/actions/reference/environment-variables#default-environment-variables

There - the resultant docker tags would look like this:
summerwind/actions-runner:v2.275.1-104
summerwind/actions-runner-dind:v2.275.1-104
@mumoshu You still would need to modify 2.275.1 to the file, but what do you think...?

Would it not be better to suffix the tag with the git hash at that point in time so there is a relation between the code running and the continer itself? It's relation to the workflow run version isn't super revealing no?

Good shout - I did think about that, though the difference there is that github.run_number will create ordered output, as opposed to the hash.

Alright- I've taken your comments onboard @callum-tait-pbx @mumoshu and made the two updates. In retrospect, ordering on dockerhub is by means of timestamp anyway so I don't see that as being a problem; ive switched to the SHA for the immutable tag.
Output is...
summerwind/actions-runner:v2.276.1-70a717086ae2686df369d0dc091ec0acb9e89012
summerwind/actions-runner:latest```

cool?

Probably best to use the the git short SHA instead?

@ap0phi5 Thanks for your efforts! This looks perfect now. Did you accidentally mark this PR as draft, of is there any remaining task to be done before merging?

@ap0phi5 Thanks for your efforts! This looks perfect now. Did you accidentally mark this PR as draft, of is there any remaining task to be done before merging?

Hi @mumoshu - I'm just sorting the short form of the SHA - using :: notation seems not to work.

Alright, looks sound.
Tag outputs will look like:
summerwind/actions-runner:v2.276.1
summerwind/actions-runner:v2.276.1-1ed3238
summerwind/actions-runner:latest


Mtproto Warning - Type not Found

I am using a Mtproto Telegram Lib, which is in python.
I have justed updated its layer to 129 and getting  Mtproto Warnings
Trace back is Pasted Here - https://del.dog/raw/inefuttupi
It's there something missed while updating Layer? Or am I at wrong place asking for this?
Can any pls guide me, where should I go and ask for this?

@levlam , sorry for mentioning, but can u check please

I can't help with a third-party MTProto library.

I have asked it's owner too, he replied - "Telegram is sending something unexpected"
And I am getting this log on layer 129, maybe I am bit sure, it's something related to updates with Voice Call

There is no layer 129 yet. It isn't released.


Fix path to aspnetcoreca.dll for signed output

File wasn't being signed before.

@natemcmaster make sure https://github.com/aspnet/AspNetCore/pull/3639 gets this change?

Done. This commit is part of aspnet/AspNetCore now


Update golangci-lint and remove unsupported linters

What this PR does / why we need it:
Pull in changes from https://github.com/kubevirt/kubevirt/pull/9962
Release note:

None

/approve
/lgtm


Updated test:visual:ci so that it starts and stops storybook automatically

Description
Updated test:ci so that storybook is started on a local server automatically and stopped when needed.
📋 Acceptance Criteria

[ ] test:ci can be run successfully even when no other script is running

Checked off by the PR assignee(s)

👩🔬 Test Instructions

Pull down branch
Run npm run test:ci
Ensure it runs successfully

🔎 Review Checklist

[ ] Merge destination is correct
[ ] Code is correct as understood and conforms to quality standards
[ ] Tests have been added where appropriate (unit, visual, end-to-end)
[ ] Acceptance Criteria have been met

Checked off by the PR reviewers

Codecov Report

Merging #25 into develop will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           develop    #25   +/-   ##
======================================
  Coverage      100%   100%
======================================
  Files            3      3
  Lines            5      5
======================================
  Hits             5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941a7e2...751468c. Read the comment docs.


Clarify licensing?

Hi! I can't find any licensing information in the repository so far. Are you planning to license these crates under an MIT license, as tokio itself has? If so, it'd be awesome if one were added ASAP with the sign-off of existing contributors so that new contributions are appropriately licensed.

Thanks for pointing that out --- the intention is to license these crates under the same license as the rest of tokio. This repo was originally created as a clone of the prototype repo, so I forgot to add a license (and a README), my bad.

@davidbarsky, @LucioFranco, @kanishkarj, @kleimkuhler, and @jxs, you've all committed code to this repository. I'm guessing you're all comfortable licensing your contributions under the same license as the rest of tokio, but I want to double check to make sure.

👍 from me

yes ofc 🙂

@hawkw I'm okay with that!

@hawkw Yes I am okay with that as well!

Great I figured as much --- just wanted to make sure for "legal reasons" :)

Yay! I’d open a PR to add the license file but I’m not sure whether my employment agreement allows it (I’m normally restricted from contributing to repos which have approved licenses, kinda hilarious bigco chicken and egg situation). Any chance one of y’all have a sec to throw one up? I have a couple of things I’d love to contribute :D.

Done! https://github.com/tokio-rs/tokio-trace-nursery/commit/3be08a81939384af033ce275771f3eec17e6f120


Update README.md

as per current code base targetDoorState/:state should be setTargetDoorState

I can confirm that this readme update is correct. It should be setTargetDoorState.

Hi there, thanks for making this pull request. I apologise for only just seeing it, I must have forgotten to address it at the time.
Apologies as well for making the mistake in the API documentation, I can only imagine how many people that has confused/frustrated.
Now that I've merged the PR, I'll push to npm. Thanks again!


Fix typo in conf.yaml.example

What does this PR do?

Fix typo in conf.yaml.example
Motivation

The referred parameter is collect_hardware_status and not collect_bfd_session_status
Additional Notes

This was introduced in PR #26134
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Add stage-2 support for linting

Introduction
Currently, ES7 stage 2 features are enabled in .babelrc. However, they cannot be used with linting because basic ESLint cannot handle them.
This patch enable ESLint to recognise them using babel-eslint parser.

https://github.com/babel/babel-eslint

Reproduction

Init with linting (standard or airbnb)
Add async-await or object spread operator in any source file (I tested with main.js)
Try building or launching dev server

Demo

Issue reproduction

Resolved after applying this patch

If there is anywhere unclear, please feel free to let me know. I will fix it up asap.

@noraesae thank! this help me out of issue#173

Thanks @noraesae. This looks like a great PR! The detail, demo, and links you provided are very helpful. I'll try to take a closer look later today so that we can get it merged in.


[FLINK-18545] Introduce pipeline.name to allow users to specify job name by configuration

What is the purpose of the change
Users can't specify job name for sql job when using new apis introduced in FLIP-84. As discussion in FLINK-18545, we should introduce pipeline.name in  PipelineOptions to support it, which could work for both DataStream jobs and SQL jobs.
Brief change log

Introduce pipeline.name to allow users to specify job name by configuration
Specify job name by pipeline.name for flink-python
Specify job name by pipeline.name for sql job

Verifying this change
This change added tests and can be verified as follows:

Extended StreamExecutionEnvironmentTest & PythonConfigUtilTest to verify the job name specified by pipeline.name

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc @twalthr @dawidwys

Hi all, I am not sure if allowing the users to specify a global name for the whole application is the application's config file would work for multi-execute applications. This is the same argument as in a related discussion here https://issues.apache.org/jira/browse/FLINK-19358?focusedCommentId=17204556&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17204556.

Hi @kl0u , I don't think the job name configuration conflicts with application mode. I think multi-execute applications may al so have same job name, e.g. use the default job name when submitting using env.execute().
With the job name configuration, users can still change the job name before submitting, for example:
Configuration conf = new Configuration();
conf.setString("pipeline.name", "job1");
env.configure(conf, Thread.currentThread().getContextClassLoader);
env.execute(); // submit job1

conf.setString("pipeline.name", "job2");
env.configure(conf, Thread.currentThread().getContextClassLoader);
env.execute(); // submit job2

@kl0u, different from job id, job name is not the key info of a StreamGraph, and pipeline.name is just used for overwriting the default job name. Just as @wuchong mentioned, we can also change the value of pipeline.name before submitting a job. And it's a very useful feature which could let sql client specify job name. cc @dawidwys @twalthr

I agree with @jark and @godfreyhe. The name is just used for logging and easier identification in UIs. The user can always change it before the next execution.

I see. If everyone agrees then feel free to go ahead.

@twalthr @dawidwys could you take a look at this pr, thanks so much

I will merge this pr


fix(api-spec): fix schema and example of request body of create suggestions

opportunityId is already specified in the path of the operation /sites/{siteId}/opportunities/{opportunityId}/suggestions, so there's no need to repeat it in the request body, hence removing it from the schema/example
Please ensure your pull request adheres to the following guidelines:

[x] make sure to link the related issues in this description. Or if there's no issue created, make sure you
describe here the problem you're solving.
[x] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

[x] make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
[x] make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

[x] make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

[ ] make sure you update the API specification with the type, schema of the audit result and an example

Related Issues
Thanks for contributing!

:tada: This PR is included in version 1.79.8 :tada:
The release is available on:

v1.79.8
GitHub release

Your semantic-release bot :package::rocket:


Enable go linter suite

Upgrade to golangci-lint v1.18
Enable gochecknoglobals, nolen and dupl
Disallow naked returns
Resolve warnings

Noted TODOs to review global usage.
Closes: #205
Closes: #216
Signed-off-by: Troy Ronda<EMAIL_ADDRESS>

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f8b21...1097633. Read the comment docs.


Iphone X hide home indicator when playing in fullscreen

Current behavior
The home indicator (the on screen iPhone X home button) stays when the video is playing in fullscreen. This blocks a part of the video. The home button should fade out when there is no activity. This way it doesn't block the content. The best would be to disable it when playing in fullscreen or with a props to control it yourself:
disableIosHomeIndicator={true}

Platform
iOS 12, iPhoneX

It‘s not work for me.

disableIosHomeIndicator={true}

@cobarx I might be willing to draft a PR for this. You say it should be simple. Was there any basis for that? I vaguely remember the API for this on the iOS side isn't exactly declarative, but perhaps there's something unique for video playing.
I know this is pretty old so no worries if you don't remember...surprised there haven't been much chatter on this.


Add logs to automations

Each time that an automation is triggered log: automation id, account id, trigger id, trigger type
Each time that a step is executed log: automation id, account id, step id, step type.
Come up with a format that is consistent between all logs, and can easily query ie Automation: #101, Account#102, Step: #103, Type: ActionStep. See also Campaign::log() for inspiration.

I don't think that there is any value logging the subscriber.
If you wish you can also omit account_id. I'm not sure about if we need this. Usually we care about a specific automation.
It's not going to be too many logs. Timekeeper (which will be removed) produces more. Let's check with SRE after a few days

Linear created an issue https://github.com/mailerlite/mailerlite-python/issues/41 . No no no!


Improve nextflow implementation

This commit improves the nextflow implementation in several aspects:

use path instead of file in input/output declaration
properly declares inputs instead of using params
use publishDir to generate expected pipeline output files
declare pipeline params at the top of the script
remove help custom function to make uniform with other implementations

If you are happy with these changes, I can modify the script to make it DSL2 complaint.
Also, consider including in this repo the test dataset and the Dockerfile for the required tool dependency.

Nice, I'd to merge this PR and I'll create a new one for DSL2 syntax. 👍

Thanks again! Please create a new pull request for DSL2, that would be great!


feat: check that the compiled class hash matches the supplied class

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#246  👈
#234 : 1 other dependent PR (#235 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.15%. Comparing base (af43060) to head (3ac61e8).

Files
Patch %
Lines

crates/gateway/src/gateway.rs
0.00%
13 Missing :warning:

Additional details and impacted files
@@                         Coverage Diff                         @@
##           arni/declare/compile_in_gateway     #246      +/-   ##
===================================================================
- Coverage                            69.10%   68.15%   -0.96%
===================================================================
  Files                                   23       23
  Lines                                  997     1011      +14
  Branches                               997     1011      +14
===================================================================
  Hits                                   689      689
- Misses                                 262      276      +14
  Partials                                46       46

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update service-bus-dotnet-how-to-use-topics-subscriptions.md

The helper method is CreateMessages. It had GetMessages.

@gauranitai : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Implement CodeRange and complete DiagnosticCollection

@codingpotato I simplified the class structure of the position classes and the range classes. Please take another look. Thanks,


want to add CODE_OF_CONDUCT.md,

I want to add code_of_conduct.md and adding contributors profiles in main readme.md

please do it in a proper way if you want to add this


Support for t3a, m5ad and r5ad instance types is missing

What would you like to be added:
Support for t3a, m5ad and r5ad instance types.
Why is this needed:
AWS had added new instance types, and the AMI does not currently support them.

Partially related to https://github.com/awslabs/amazon-eks-ami/issues/254

What happens currently if the CNI is used on one of these instances?

It is not able to allocate IP addresses to all the pods on the instance (I'll have to get the exact error message).
I thought it was because it does not know what the pod limit should be for these instance types, but curiously, I get the same problem with this PR.

It is not able to allocate IP addresses to all the pods

But some will run? Or none?

It is not able to allocate IP addresses to all the pods

But some will run? Or none?

i ran into this problem yesterday; i was able to start three pods on a t3a.small, and then no additional pods could be scheduled b/c CNI was unable to give them network interfaces.  switching back to t3.small enabled me to work around the issue.

It is not able to allocate IP addresses to all the pods

But some will run? Or none?

Sorry for the late response. Same as reported by @hakamadare: It runs a few pods, but then no more, without actually hitting the ENI limit.

I think the CNI version just needs to be updated to v1.5. See my comment here: https://github.com/aws/amazon-vpc-cni-k8s/issues/59#issuecomment-504972238

We're hitting the CNI errors when trying to schedule more pods on t3a.small instance too.
I think the number of maxPods t3a.small 11 (see eni-max-pods.txt) doesn't correspond to this table:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-eni.html#AvailableIpPerENI
I think the number of --max-pods on t3a.small instance should be less then 11.
Can anyone confirm?

According the chart @VojtechVitek references, a t3a.small only supports 2 x ENIs, for a total of 8 IP addresses. At that ratio, --max-pods needs to be 7 or less, as far as I can discern.

cc @mogren

Thanks for reporting, I've created a PR for the CNI, will fix for the AMI build as well.


musl target in releases?

Hi,
just built smug under AlpineLinux  and works pretty well.
Wonder if you'd add musl target to the builder.
Thanks.

Hey. I'm not sure what it means. To which builder do you want to add this target?

$ docker run -v (pwd)/smug:/smug -it alpine
/ # ./smug
Smug - tmux session manager. Version v0.3.3

i mean on releases page, there are builds for Linux_arm64, Linux_x86_64 etc.
but not for Linux_musl
so have to download sources and lot of MB to build it.
would be nice to have a build for Alpine Linux as well.
thanks.

wait a minute, just tried Linux_x86_64 and works perfect under Alpine!

sorry, my bad :) had to check before,
thanks for smug, it's great!
finally got rid rid of ruby, for years was was installing it for just tmuxinator

Np :) Thanks for your feedback. I will close the issue for now


May I help in maintaining and releasing this doc?

Hi @tangwz !
It seems this repo has no releases from the few months later, while there are still several inflight blogs(rename to PolarDB database monthly). I'm willing to help in maintaining and releasing this doc. Do you have some suggestions how we can collaborate in this direction?

Why not submit a PR? I'll merge the PR if necessary.

Seems that the posts these months is submit. Next time maybe I'll submit a pr for this. Thanks!


vmm: support pod sysctl configuration

This PR adds support for configuring pod sysctl settings in the VMM (Virtual Machine Manager) component of our Kubernetes runtime project.
With this change, users can now specify custom sysctl settings for their pods, allowing for more fine-grained control over the runtime environment. This feature is particularly useful for workloads that require specific kernel parameter settings.
The implementation includes the necessary changes to the VMM codebase to parse and apply sysctl settings from the pod's configuration.

@Burning1020 already rebase


Eliminate special-cases for multiplication by zero

This is already handled just fine as part of the substitution process, and doesn't seem like a particularly worthwhile case to optimize.
If we do care care about optimizing it, the optimization would be more effective inside update_and_substitute anyway.

Coverage change stats don't make much sense to me, hhard to see how this could possibly decrease coverage in a different file by 6%


Exporting Ollama to WebAssembly

This PR exports ollama as a WebAssembly Host Module.

✋ may I ask more about this PR, like your motivation and, most important thing, why close it?


add sample profile to helm/kustomize Cognito-rds-s3

Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Keep parity with Terraform deployment. Adds a sample user-profile configured with s3-bucket access to helm/kustomize cognito-rds-s3 deployments
Testing:

[ ] Unit tests pass
[ ] e2e tests pass
Details about new tests (If this PR adds a new feature)
Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Drafting doc changes in separate pr


Fix WebAssembly

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: elgransan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Multiblock Plotting/Animation/Simple Lineout Support

Changes to Postgkyl
This PR supports the implementation of plotting, animation, and basic lineouts for Multiblock simulation files in Postgkyl
Plot Function

Added multiblock (or mb) parameter
This parameter automatically plots all loaded data objects onto the same figure and sets an appropriate scale. It does so using the ‘figure’ and ‘globalrange’ kwargs.
Added cutoffglobalrange (cogr) parameter
This allows the user to adjust the limits of the scale by choosing the middle percentile of values to keep inside the scale. It does this by creating an array containing all the extrema from each block and setting the y/z limits to the edges of the middle percentile chosen by the user.

Small Fix:
I found that there was no way to toggle OFF the colorbar of a 2D plot due to a conditional error in the plot function in the output directory. This caused lag in multiblock animations due to colorbar stacking. I also fixed this.
Example code:
pgkyl <blocks to be loaded> plot --multiblock (or -mb)

Loaded blocks should belong to one frame

Command Util

Added set_frame function
This function uses the file names of all the loaded blocks to find the relative frame for each block, then sets the ‘frame’ value in each block’s ctx dictionary to that frame. This function is used in both animate and select in order to organize and group blocks for animations and lineout animations

Animate Function
For the animate function to work with multiblock data, I had to readjust its framework. The function creates a list of lists, where each interior list contains all the block data objects which correspond to a specific frame. So, each interior list will contain however many blocks there are per frame, or just 1 block per frame if you are animating a non-multiblock case. The new multiblock parameter uses the util set_frame function to sort all the loaded data objects, then plot all the blocks per frame and animate it using matplotlib’s FuncAnimation and an altered version of the previous _update function. The new _update function iterates through every frame list rather than every offset.
Example code:
pgkyl <blocks from all frames to be loaded> animate --multiblock
Other small fixes

Only the first block per frame load in the colorbar. This is to prevent colorbar stacking and improve efficiency for animations with large amounts of blocks.
I fixed the grouptags parameter so that when called, animate creates separate animations for each loaded tag. It did not seem to be doing this before, so revert this if I messed it up.
I created a globalrange helper function. This function allowed the float parameter to work for normal, grouptags, and multiblock applications with reduced redundancy.

GData

_neighbors attribute
This attribute is a dictionary which contains information on what blocks are next to (neighbor) a specific block. Each key in this dictionary represents a direction. The keys are tuples where the first value is an index which represents the dimension (0 or 1) and the second value is a boolean which represents the direction in that dimension (True=up/right and False=down/left). So the 4 keys in the _neighbors attribute are (0, True) for east, (0,False) for west, (1,True) for north, and (1,False) for south. The value at each key is the block object in that direction, if there is no block (an edge) then the value is None. The _neighbors attribute starts with None in every direction, but the subsequent set_neighbors method I will discuss is used to populate the attribute. The applications I have been testing this on do not need neighbors in more than 2 dimensions, but more may be added to the dictionary if needed.
set_neighbors method
This method uses the loaded block objects’ grid boundaries to identify which blocks are next to a specified block and what direction they are in, then it updates the information in that block’s _neighbors attribute. This method will most likely be redone when the multiblock topology files are finished and implemented since this method is not robust enough for applications that include multiple types of coordinate systems or blocks overlapping each other.

The addition of this attribute and method to GData is to support mutliblock lineouts. By recursively calling the set_neighbors method until the _neighbors value in a certain direction becomes None, one can find all the blocks which are included in a lineout and plot/stitch them together.
Select
The way that select works normally has not changed. For multiblock cases, I added a multiblock parameter flag. My algorithm for multiblock lineouts is to first identify the bottom left point in order to find the minimum common edge in the z0 and z1 directions. Then it uses this information to find the starting block on the corresponding edge which starts the lineout. Then the _neighbors attribute and set_neighbors method are used to identify all the blocks in the lineout’s direction. The internal select function is run on all of these blocks and the resulting grids and value lists are stitched together and assigned to a new data object which is outputted. The previously loaded block objects are deactivated and the new data object is pushed into the data context. This means that when plotting the lineout the multiblock parameter is not needed.
Example code:
pgkyl <blocks in frame to load> sel  --z(#) <coordinate> --multiblock (or -mb) plot
(#) is the dimension you want to perform the lineout in (0 or 1)
In order to support animation for these types of lineouts, I implemented a new structure into select similar to the one I used in animate. Before performing a lineout, each loaded block object is assigned its frame using the set_frame function and organized into a list of lists where each interior list contains the blocks associated with a frame. A multiblock lineout is then applied onto each frame and the new data objects are outputted. The default for mutliblock select is to assume that all loaded data objects are blocks belonging to the same frame, so to specify that there are multiple frames being loaded, a multiframe parameter is needed. This parameter is necessary when doing multiblock lineout animations or plotting multiple multiblock lineouts at the same time. Like the aforementioned single frame multiblock lineout plotting, the multiblock parameter is not needed since all outputs are singleblock 1D lineouts.
Small fix:
I noticed that when calling the select, I could create and plot a lineout for a coordinate well outside of the data’s grid boundaries. So, in the select function in the data directory, I created a conditional which does not let it continue if the selected coordinate is outside of grid boundaries by a factor of 25% of the boundary range.
Example code:
pgkyl <blocks in all frames to load> sel --z# <coordinate> --multiblock (or -mb) --multiframe (or -mf) animate
This link contains a slideshow with some examples of plots, animations, lineouts, and some test code: link

@lucaa-g I did forget one thing in my review! You and @JonathanGorard need to be added to AUTHORS.md :-)

Hi @pcagas, thank you for the review! I have fixed the formatting issues (snake case, loop-ending comments, etc.), deleted the binary files, and added documentation to set_frame(). I have also changed the key/value makeup for the _neighbors attribute. Instead of using a tuple (dim: int, direction: boolean) as the key for the neighboring blocks, I have changed it so that the key is the dim (int) and the value is a list of the neighboring data objects in both directions [lower_neighbor, upper_neighbor]. Is this what you had in mind in your comment? I have also changed select so that it incorporates this different format. I have requested another review so please take a look at my changes and let me know if there are any fixes I should make. Thanks again.


wrong dpi for back arrow mouse cursor

VSCode Version: 1.13.1
OS Version: Windows 10x64 Home

Steps to Reproduce:

take tablet with high dpi resolution (pipo w1pro)
connect it to external monitor
setup tablet display dpi = 200%, but external monitor dpi = 100%
setup multi display setting to "Screen 2 only"
open any document in VSCode
move mouse pointer to document line numbers

Expected: mouse pointer in dpi = 100%
Actual: mouse pointer in dpi = 200%
In attachment you can see it. Steps recorder main window also has wrong dpi, as many other programs in this mode. But VSCode work almost excellent in this configuration => you can fix it or send request to Windows authors ;) I already sent similar report to Edge support and Screen driver support.
vscode_cursor_wrong_dpi.zip

@SailorMax still an issue?

@bpasero Cursor now looks good, but titles for buttons not. I mean titles, which shows when mouse cursor hover on Commit-button or any else.
thank you.

about cursor: possible I wrongly checked it. Will recheck it later.

reconfirm: cursor is ok now. buttons hints - not.

Still happens?

Yes.
Yesterday steps:

start tablet with connected HDMI cable to monitor

on external monitor all was fine

disconnect HDMI cable

on internal monitor all VSCode hints start to be very small

update VSCode (1.16.0 -> 1.18.0)

problem is still here


TabView Icon

I Want to add Icon only in tabview not in scrollable list if we set showIconOnList=false then Icon from horizontal tabview also disabled.

Thanks for opening this issue. The new release 0.1.6 should fix it. I am going to close the issue, but feel free to reopen if it didn't solve the issue.


[SUGGESTION] Cleaned up search index

Description
Since i commented about this I decided to take a look and cleanup the file a bit.
This should be taken with a grain of salt bcz its purelly based on my opinion.
Also implemented all the changes in #1901 and the suggestion i commented about, keyof any to PropertyKey

Checklist

[x] Does npm test pass with this change (including linting)?
[x] Is the new or changed code fully tested?
[x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

I also thought about changing some of the if statements to &&


lean: correctly parse expressions nested within attributes

This mirrors the syntax fix made in https://github.com/leanprover/vscode-lean/pull/265

CI failure is unrelated to this change.

Sorry, I totally forgot about this. I've resolved conflicts with the latest master.


Crash after driver update

Hello, i have a Nvidia gpu. I recently updated my drivers from version 525 to 545.29.06. The app worked perfectly before but after the update it crashes on startup.
Log:
libEGL warning: DRI3: Screen seems not DRI3 capable
libEGL warning: DRI2: failed to authenticate
libEGL warning: DRI3: Screen seems not DRI3 capable
libEGL warning: DRI3: Screen seems not DRI3 capable
libEGL warning: DRI2: failed to authenticate
libEGL warning: DRI3: Screen seems not DRI3 capable
[AURA] Listening to commands.

(org.nickvision.cavalier:2): Gdk-WARNING **: 15:40:57.449: The program 'org.nickvision.cavalier' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadMatch (invalid parameter attributes)'.
  (Details: serial 883 error_code 8 request_code 149 (unknown) minor_code 4)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

I also created a system report.
report.json

I just checked and most flatpak apps seem to work. Except for yuzu and flatseal.
Yuzu log:
$ flatpak run org.yuzu_emu.yuzu
qt.glx: qglx_findConfig: Failed to finding matching FBConfig for QSurfaceFormat(version 2.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize -1, redBufferSize 1, greenBufferSize 1, blueBufferSize 1, alphaBufferSize -1, stencilBufferSize -1, samples -1, swapBehavior QSurfaceFormat::SingleBuffer, swapInterval 1, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::NoProfile)
qt.glx: qglx_findConfig: Failed to finding matching FBConfig for QSurfaceFormat(version 2.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize -1, redBufferSize 1, greenBufferSize 1, blueBufferSize 1, alphaBufferSize -1, stencilBufferSize -1, samples -1, swapBehavior QSurfaceFormat::SingleBuffer, swapInterval 1, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::NoProfile)
Could not initialize GLX
/app/bin/yuzu-launcher: line 24:    13 Aborted                 (core dumped) prlimit --nofile=8192 yuzu "$@"
Gtk-Message: 15:59:38.637: Failed to load module "canberra-gtk-module"
Gtk-Message: 15:59:38.638: Failed to load module "canberra-gtk-module"

Flatseal log:
$ flatpak run com.github.tchx84.Flatseal
libEGL warning: DRI3: Screen seems not DRI3 capable
libEGL warning: DRI2: failed to authenticate
libEGL warning: DRI3: Screen seems not DRI3 capable
libEGL warning: DRI3: Screen seems not DRI3 capable
libEGL warning: DRI2: failed to authenticate
libEGL warning: DRI3: Screen seems not DRI3 capable

(com.github.tchx84.Flatseal:2): Gdk-WARNING **: 16:05:34.813: The program 'com.github.tchx84.Flatseal' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadMatch (invalid parameter attributes)'.
  (Details: serial 1551 error_code 8 request_code 149 (unknown) minor_code 4)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the GDK_SYNCHRONIZE environment
   variable to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

If Flatseal and Yuzu are experiencing the same issue, seems like your graphics driver update broke something...
nothing on Cavalier's end.


JavaDoc for public methods in library

Hello, how about JavaDoc for public methods in library :-)
Thank you for you work, it's a cool library/framework

Sources jar contains .class files, but should contains .java files. @senneco change please sources packaging folder

Fixed bug of build script. But this will being applied only with new release.
PS: currently new sources and javadoc jars published, but my Android Studio doesn't seeing this. But local maven show that this fix working.

@senneco remove maven cash to reload artifact

@xanderblinov I'd remove local cache, but after sync, there are again old jars.

Published in Moxy v1.4.4


Disable editing for test and solution tabs

I don't see a reason why test and solution tabs have to be editable. So this commit will make both test and solution editors read only.
Note: Also I changed the parameter nocursor value to false from true. Because nocursor=true will block the copy functionality also.

When we developed the Dart Future codelab, I did use the editable test code to debug the exercises. It'd be convenient that codelab authors and collaborators can play with test code in some ways.
The read-only solution code makes sense to me if the code in the current solution tab is not executable.

Thanks for checking with us -- my sense is that leaving test/solutions as
editable makes developing codelabs a lot easier.
What are the considerations on the flip side?
On Mon, Oct 14, 2019, 1:14 PM Gale Yang<EMAIL_ADDRESS>wrote:

When we developed the Dart Future codelab, I did use the editable test
code to debug the exercises. It'd be convenient that codelab authors and
collaborators can play with test code in some ways.
The read-only solution code makes sense to me if the code in the current
solution tab is not executable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/dart-pad/pull/1321?email_source=notifications&email_token=ABKLAX4LNNYRLGKMNHZYS6LQOSSI3A5CNFSM4I7QH4JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBFUJGA#issuecomment-541803672,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKLAX53RGUQHIE2NFUQZCDQOSSI3ANCNFSM4I7QH4JA
.

I think we can solve this in a way that makes the experience better for typical users and still leaves the door open for folks working on codelabs.
@jawahars16, how about this:

Make the test and solution editors readonly by default, as you have done.
Add a new checkbox to the dropdown menu called "Editable test/solution".
If the user checks that checkbox, set readonly to false for those editors.

There's a previous PR from @johnpryan that shows a menu choice being added, which might serve as a useful guide:
https://github.com/dart-lang/dart-pad/pull/1137

That's a great recommendation, thanks Andrew.
On Tue, Oct 15, 2019, 1:00 PM Andrew Brogdon<EMAIL_ADDRESS>wrote:

I think we can solve this in a way that makes the experience better for
typical users and still leaves the door open for folks working on codelabs.
@jawahars16 https://github.com/jawahars16, how about this:

Make the test and solution editors readonly by default, as you have
done.
Add a new checkbox to the dropdown menu called "Editable
test/solution".
If the user checks that checkbox, set readonly to false for those
editors.

There's a previous PR from @johnpryan https://github.com/johnpryan that
shows a menu choice being added, which might serve as a useful guide:
#1137 https://github.com/dart-lang/dart-pad/pull/1137
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/dart-pad/pull/1321?email_source=notifications&email_token=ABKLAX5L2RIIMEPASUIWICDQOXZKRA5CNFSM4I7QH4JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJP5EA#issuecomment-542310032,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKLAX7CRIXQ7WWGBJQGBFLQOXZKRANCNFSM4I7QH4JA
.

Manually tested the change on new_embeddings_demo.html, and everything looks like it's working as intended. Once the style issues @johnpryan pointed out are addressed, this is ready to land.
Thanks for another solid contribution, @jawahars16!


Draft frontend mockup

I quickly built a frontend using bootstrap:

Looks great, thanks! :)
Could you add the logo we now have?
It would be great if you provide the various templates as part of /templates? Especially index.html, account and co.
Thanks for the great work! :100:

Where is the logo?

:+1:

So what's left to do:

[ ] Revert CS fixes (will be done later, globally)
[ ] Put the templates in /templates
[ ] Split the templates
[ ] Add the logo to the home page
[ ] Add the logo in the header for all other pages

@pierrejoye I updated the PR, chck out the screenshots in the initial description ;)
ping @Hywan the logo (SVG) is here ;)

Go ahead :) looks great!
Is it possible to use logos for bitbucket, github or other?

@pierrejoye Of course ;)

:+1:

is that good to merge now?


information not present in the landroid card

https://github.com/Barma-lej/landroid-card/assets/31271212/406e6510-588a-4e3d-919a-18c346e51c0e
Describe the issue
All information is incorrect, see also picture.
For example: WLAN, Timestamp, PartyMode,
Edgecut, mowing and the battery informations are seems right.
I don't know if the errors are due to the card.
The cloud data seems to be correct.
What version of Home Assistant Core has the issue?
2023.11.2
What was the last working version of Home Assistant Core?
No response
What version of the Landroid Cloud integration do you have installed
v4.0.0b3
What type of installation are you running?
Home Assistant Supervised
Which make and model is the mower used for this integration?
WR141E
Diagnostics information (NOT log entries!)

Either version 0.3.2 nor version 1.0.0b1 of the Landroid Card doesn't support Landroid Cloud v4.0.0b3

What should I do now? Waiting for an update?

Waiting on update or downgrading Landroid Cloud

Waiting on update or downgrading Landroid Cloud

Which version of Landroid Cloud version works with 1.0.0b1

4.0.0b1

4.0.0b1
@MTrab Thx
This means that a Landroid Card update should be available for Landroid Cloud v4.0.0b3.

Remember that you are on a bleeding edge when using the beta version - LOTS of changes are coming, not near done yet.
So the issues you see by using beta versions are expected - as we are 2 individuals developing landroid_cloud and landroid card, DO NOT expect them to be released at the same time, especially not when on the beta channel.

Wenn ich Zeit habe, Markus. Und wenn ein Release von Landroid Cloud verröfentlicht wird

@Barma-lej Dann warte ich auf das Update.
@MTrab Thank you for your tireless efforts.

There is a new beta version 1.0.0b2 here


AUR package (FYI)

Love the project! ♥
I took the liberty:
https://aur.archlinux.org/packages/git-backdate-git

haha thanks! I was planning on adding it to rixx/pkgbuilds at an undetermined point in the future, but this is even less work for me <3


Allow configuring files to ignore on sync

We have a fairly large .git directory and a potentially large logs directory that it would make sense to exclude. Would be nice if the excludes were configurable so that we could set that up.

This appears to be by design (see https://github.com/mitchellh/vagrant-aws/issues/304) but it does cause a fair amount of confusion to use a different key than the Vagrant docs.
The PR that implemented rsync excludes probably should have closed this issue, but it's probably safe to say that it can be closed now.


Removes HTML Space after ! Exclamation Mark

Using the processString method, it always strips out the space after an exclamation mark in HTML.  For example, "Good news!  You were accepted" is always outputted as "Good news!You were accepted" no matter how I compile it or what HTML entities I use.

Update:
This happens for any white space after a closing tag.
Also, I'm finding that it removes the % sign too in html?

Uglifycss is supposed to be used with css, not html


Load extensions with Sqlite3 ??

Exqlite.Basic has functions enable_load_extension and load_extension.
Exqlite.Sqlite3 only has function enable_load_extension.
Is it possible to load extensions with Sqlite3 ??

Yes using the Connection configuration you can:
config :exqlite, load_extensions: [ "./priv/sqlite/\#{arch_dir}/rotate" ]

Here is a ton of information about the configurations that can be passed to exqlite. Sorry that the information is buried in there. https://hexdocs.pm/exqlite/Exqlite.Connection.html#connect/1
Just be aware, when you load extensions that they need to be compiled for that machine and must be compatible with the sqlite version.

Thanks very much!  Would you like a PR for a small update to README with this docco?

@andyl definitely, an example section in the README would be fine.

Done.


Can't seem to open vault directory.

🐛 Describe the bug
when I run ObsidianOpen from my vault directory I get [Obsidian] couldn't find an Obsidian vault
I tried to debug it, and from what I can see it only check for .obsidian folder in all the parents of the dir option, but on in the dir itself. see client.valut at https://github.com/epwalsh/obsidian.nvim/blob/38ba031ca19cdbe296ae18a401ace5a82e770b1c/lua/obsidian/init.lua#L115
so I tried to enter one of the subdirectories, and it indeed worked.
this is clearly not optimal ;).
Versions
NVIM v0.8.0-dev-1112-g6d557e324
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -O2 -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/Users/runner/work/neovim/neovim/build/cmake.config -I/Users/runner/work/neovim/neovim/src -I/Users/runner/work/neovim/neovim/.deps/usr/include -I/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/usr/include -I/Library/Frameworks/Mono.framework/Headers -I/Users/runner/work/neovim/neovim/build/src/nvim/auto -I/Users/runner/work/neovim/neovim/build/include
Compiled by<EMAIL_ADDRESS>Features: +acl +iconv +tui
See ":help feature-compile"
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/share/nvim"
Run :checkhealth for more info
1.3.0%

Oops, this should fix: https://github.com/epwalsh/obsidian.nvim/pull/20

unfortunately this doesn't solve it. in fact, the commit doesn't really change anything ;). see the review: https://github.com/epwalsh/obsidian.nvim/pull/20#pullrequestreview-1131254292


distinct() on ReferenceField is returning list of DBRef

If you call distinct() for a ReferenceField, it returns a list of DBRef rather than dereferencing the objects.
class Foo(Document):
    bar = ReferenceField("Bar")

class Bar(Document):
    text = StringField()

bar = Bar(text="hi")
bar.save()

foo = Foo(bar=bar)
foo.save()

print Foo.objects.distinct("bar")  # -> [DBRef(u'bar', ObjectId('4ebd8d8477adbf4bfb000002'))]

thanks @joeshaw for the test case!  This has been fixed on dev


[release-v1.78] Automated cherry pick of #8532: Add more versioned tool binaries for (go build) gardener tools to gardenertools image

/kind enhancement
/area dev-productivity
Cherry pick of #8532 on release-v1.78.
#8532: Add more versioned tool binaries for (go build) gardener tools to gardenertools image
Release Notes:
NONE

/lgtm
/approve


Add rx packet queing to TCP2

If we receive TCP data where sequence numbers are out-of-order, then queue them until we have received all the data or a timeout happens. Add also unit tests to test this.
Fixes #30364

ping @mniestroj

ping @mniestroj

Updated according to comments.

Updated according to comments.


feature/GH-1985: add breadcrumb section into layout

close #1985

I'm not sure why we're doing this. In general I think it's a bad practice to have specific slots for components, similar to how we have a SearchBox slot for the SearchBoxComponent.
What's the reasoning behind this change?

Hi @tobi-or-not-tobi: The "breadcrumb" component cannot be recognized by smartedit. So, https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/1985 was created. To me, I agree with you. But, I don't know the reason why this happens. So, I made this workaround. I can ask smartedit team to investigate more.


added support for ruby properties

I've added support for the ruby-align, ruby-merge, and ruby-position properties as per the HTML5 spec and the CSS Ruby layout module 1 specs.
Note that the layout module is in the working draft stage.

css-ruby is part of css-3; if you base this on the 0.3.x branch and add test cases I'll merge it

Closing stale PR. If this is still needed, please reopen a PR.


feat: add support for p2p keystore

Overview
Closes https://github.com/celestiaorg/orchestrator-relayer/issues/64
A subsequent PR will make the orchestrator and relayer use this p2p store.

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #278 (29e806f) into main (f8b2d0d) will increase coverage by 0.33%.
 Consider uploading reports for the commit 262a886 to get more accurate results

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   48.94%   49.28%   +0.33%
==========================================
  Files          24       24
  Lines        1665     1678      +13
==========================================
+ Hits          815      827      +12
- Misses        739      740       +1
  Partials      111      111

Impacted Files
Coverage Δ

store/store.go
63.38% <76.47%> (+6.48%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Automatic code formatting / linting

Task: configure automatic code formatting with black, ruff or suitable tool.
Also document instructions for users to run formatters via pre-commit hooks.
Tasks:

[ ] Decide on a linter
[ ] Add to git hooks

[ ]  On push? (needs to ensure tests pass post auto-reformat)

I vote for Ruff for both linting and formatting.
pre-commit hooks and CI could be set up following replace_landsurface's pre-commit-config and CI.


[Fix] Show header on scroll

A merge took this away and I think it should be implemented again.

Show to header on scroll up.

I would like to work on this . Please do assign

Hi brittneypostma, I am also interested working on it? Please assign it to me if no one is working on it.

this issue is looking interesting ? can I work on this ? could you assign me with this issue?

Can I work on this?


Add destination to redirect validation errors

It's usually not obvious when you're looking at one of these 422 unacceptable entity validation messages in Sentry or Kibana what the payload was, so an error message that just says "internal redirects cannot end with /" can be hard to diagnose.
Adding the destination in these cases should make it much more obvious what the validator is upset about.
We already include the destination in error messages in the reject_query_parameters_and_fragment method, so I don't see any reason why it would be a problem to include them here too.

Yeah, some of the tests don't check the error messages by the looks of it - https://github.com/alphagov/publishing-api/blob/main/spec/support/routes_and_redirects_validator.rb#L161
I'm okay with that, as having to update the tests whenever you update the messages is a bit annoying.


minor text fix

Thank you @Kraftwurm, nice catch!
May I ask how you stumbled across this repo and what made you decide to invest the work to contribute?


use textwidth to measure the length of a unicode strings?

Hi! Thanks for developing the Term.jl I'm very excited and looking forward to the official release 😃
https://github.com/FedeClaudi/Term.jl/blob/083b6e66dce6840a9e38412cdc10046335e8f874/src/measure.jl#L27
If we use length we will get a wrong number of columns needed to print a unicode string
julia> using Term
julia> s1 = "나랏말싸미 듕귁에 달아"
julia> s2 = "こんにちは(わ)"

But with textwidth we get the correct number of columns for most of times

Thanks for spotting that! I've added that in, it seems to work correctly now: e72282c71fac50bc37e1920939171722d2cdc971
Let me know what else you come across, I appreciate you testing Term.jl before its official release!


remoteJWKS needs a caCert option

Description:
When setting up JWT authentication we need to be able to set custom CA-certificate to allow Envoy to trust our internal HTTPS JWKS server.
Snippet from SecurityPolicy:
  jwt:
    providers:
    - name: poc-oidc
      remoteJWKS:
        uri: https://poc-oidc.internal.domain.com/keys

Relevant debug logs:
[2024-06-04 13:15:36.191][1][debug][connection] [source/extensions/transport_sockets/tls/cert_validator/default_validator.cc:325] verify cert failed: X509_verify_cert: certificate verification error at depth 1: unable to get local issuer certificate 2024-06-04T15:15:36.191711347+02:00 [2024-06-04 13:15:36.191][1][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:241] [Tags: "ConnectionId":"8"] remote address:10.X.X.254:443,TLS_error:|268435581:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED:TLS_error_end
[optional Relevant Links:]

Any extra documentation required to understand the issue.
https://gateway.envoyproxy.io/latest/tasks/security/jwt-authentication/
https://gateway.envoyproxy.io/contributions/design/security-policy/

I'd vote for adding a caCertificateRefs` field in here to solve this

/assign

I'd vote for adding a caCertificateRefs field in here to solve this

is caCertificateRef field ok？
is there a scenario where users might need multiple CAs?

I'd vote for adding a caCertificateRefs field in here to solve this

is caCertificateRef field ok？ is there a scenario where users might need multiple CAs?

@phantooom lets follow the BackendTLSPolicy spec https://gateway-api.sigs.k8s.io/api-types/backendtlspolicy/ and use caCertificateRefs and append them into one internally

I'd vote for adding a caCertificateRefs field in here to solve this

is caCertificateRef field ok？ is there a scenario where users might need multiple CAs?

@phantooom lets follow the BackendTLSPolicy spec https://gateway-api.sigs.k8s.io/api-types/backendtlspolicy/ as a guide and use caCertificateRefs and append them into one internally

ok

hey @phantooom this was discussed in the the community meeting a few weeks ago and the decision is to represent the remote jwks endpoint as a backendCluster. similar to what's done in ext auth https://github.com/envoyproxy/gateway/blob/262e0466f14dace834f1b0d712c2492c27e9bb03/api/v1alpha1/ext_auth_types.go#L54
This would be an additional field in the existing struct allowing the user to define custom cluster level properties like custom caCert

+1
Is there any progress on this feat?

hey @phantooom do you any cycles to address the above comments ?
this is similar to https://github.com/envoyproxy/gateway/pull/4227

hey @phantooom do you any cycles to address the above comments ?嘿，你有空处理上面的评论吗？ this is similar to #4227这与 #4227 类似

sorry. my work has recently changed, and I am no longer able to continue following up on this pull request.

/unassign

Hi, we also need remoteJWKS to support extra CA, do we have any process for this issue ?

hey @wengyao04 to implement this, we'd need to add and implement the backendRefs field similar to what was done for OIDC https://github.com/envoyproxy/gateway/pull/4227, which would allow the user to specify a Backend/ Service resource as a backendRef + a BackendTLSPolicy as a policy to specify the custom CA

As far as I understand the comments there is currently no way to use an internal JWKS server. Is that correct?
To give some context here is my situation: I have a local Kubernetes cluster with Keycloak, Envoy Gateway and a self-signing cert-manager instance. A backend service is exposed via the Envoy Gateway and I want to add JWT authentication based on JWTs issued by my Keycloak instance.
When I curl the endpoint with authentication enabled I get this error: Jwks remote fetch is failed. When using the verbose switch I see this in the response:
curl -kv --header "Authorization: Bearer $BEARER" https://api.dev.example.com/service/resource
...
* Server certificate:
*  subject: CN=Example
*  start date: Nov 21 14:14:43 2024 GMT
*  expire date: Feb 19 14:14:43 2025 GMT
*  issuer: CN=Example
*  SSL certificate verify result: self-signed certificate (18), continuing anyway.
*   Certificate level 0: Public key type RSA (2048/112 Bits/secBits), signed using sha256WithRSAEncryption
...
< HTTP/2 401
< www-authenticate: Bearer realm="https://api.dev.example.com/service/resource", error="invalid_token"
...
Jwks remote fetch is failed

I would really like to move on with configuring authentication (and later authorization) in my development cluster but this is stopping me in my tracks. Is there a workaround or is this simply not supported until this issue is resolved?

Lucas yes there is. We do so in our prod. and test setup. Keycloak being
the JWK broker and enovy the entrance gateway to authenticate through. I'm
not at the work computer right now. But, if interested I can try to fetch
some detail.s
On Sun, Dec 8, 2024 at 11:18 AM Lucas Resch @.***>
wrote:

As far as I understand the comments there is currently no way to use an
internal JWKS server. Is that correct?
To give some context here is my situation: I have a local Kubernetes
cluster with Keycloak, Envoy Gateway and a self-signing cert-manager
instance. A backend service is exposed via the Envoy Gateway and I want to
add JWT authentication based on JWTs issued by my Keycloak instance.
When I curl the endpoint with authentication enabled I get this error: Jwks
remote fetch is failed. When using the verbose switch I see this in the
response:
curl -kv --header "Authorization: Bearer $BEARER" https://api.dev.example.com/service/resource
...

Server certificate:
subject: CN=Example
start date: Nov 21 14:14:43 2024 GMT
expire date: Feb 19 14:14:43 2025 GMT
issuer: CN=Example
SSL certificate verify result: self-signed certificate (18), continuing anyway.
Certificate level 0: Public key type RSA (2048/112 Bits/secBits), signed using sha256WithRSAEncryption
...
< HTTP/2 401
< www-authenticate: Bearer realm="https://api.dev.example.com/service/resource", error="invalid_token"
...
Jwks remote fetch is failed

I would really like to move on with configuring authentication (and later
authorization) in my development cluster but this is stopping me in my
tracks. Is there a workaround or is this simply not supported until this
issue is resolved?
—
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/gateway/issues/3536#issuecomment-2525575748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIERWXMSFMV57EGMP4ILRD2EQMGXAVCNFSM6AAAAABIY7UK5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGU3TKNZUHA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Mvh. / Kind regards
Lars Bengtsson

Health is wealth, movement is medicine -

My DevOps blog https://bengtssondd.it
My poetry website https://skakmatdigte.dk

Lucas yes there is. We do so in our prod. and test setup. Keycloak being the JWK broker and enovy the entrance gateway to authenticate through. I'm not at the work computer right now. But, if interested I can try to fetch some detail.s

I'm certainly interested. Any kind of guidance is much appreciated! From the docs alone I can't seem to make it work.

I was able to resolve my issue. First I enabled signing of my certificates via Let's Encrypt. Then I resolved the Jwks remote fetch is failed error by pointing the jwksURL to the cluster internal URL of my Keycloak instance instead of the URL exposed by the Envoy gateway. I guess that URL is not resolvable by Envoy itself.


Add Privy / email, marketing automation

website: https://www.privy.com/pricing?#
examples:
https://shop.vikings.com/
https://www.gtsimulators.com/
https://store.vetfriends.com/
https://www.yesware.com/

@nurbek91 looks like you took care of this https://github.com/AliasIO/wappalyzer/issues/4259


fixed NgControlStatus and Subject error

Issue 1

I had some advances today, I will finish the example before a new pull request...

Hi @felipealbuquerq
I just browsed code and noticed things i did not watched when merged

we shouldn’t push /dist content, it is generated on build

why did u commit ads lib with advertisements urls ? what’s that feature?

also commited .js files built from .ts sources. That shouldn’t be commited

Thanks


CLOCK_WATCHDOG_TIMEOUT on Windows 10 Insider Preview (14352)

Hello,
I get CLOCK_WATCHDOG_TIMEOUT while starting the driver.
OS: Windows 10 Insider Preview 14352
CPU: i7-2600
I thought that might be because of patterns or offsets from Tests does not match and commented out TestStart, TestPrintResults, TestStop however same thing happens.
I have bad network conditions, so couldn't test it with RTM version of Windows 10. However, I can get SimpleVisor https://github.com/ionescu007/SimpleVisor (I think they share a common here) work on my system.
Please tell me if you need a memory dump and the kind of the memory dump.

Any BSOD memory dump will be good, full or minidump. Also try disabling EPT initialization by setting _Data->Features.EPT and g_Data->Features.VPID to false in VmxCheckFeatures.

I had the same issue on Windows 8.1 build 9600 (DPC_WATCHDOG_TIMEOUT, 0x133)
Disabling EPT solved the issue. The BSOD showed all CPUs were stalled in the MmAllocateContiguousMemorySpecifyCache call from EptpAllocatePage (tracing back from VmxSubvertCPU->EptBuildIdentityMap->EptpFillTable->EptUpdateTableRecursive).
From my understanding, allocating a single page is guaranteed to be contiguous in physical address space anyway? I'm not sure, but using ExAllocatePoolWithTag solved the DPC timeout. I added a call to KeInvalidateAllCaches() at the end of PHHook() since it's no longer noncached memory, but my TestPageHook() still fails. Any ideas why?
I also made sure to change the MmFreeContiguousMemory to ExFreePoolWithTag when freeing the ept pages in EptFreeIdentityMap, but the system just hangs with no bsod when trying to unload. Not sure why that would be?

Nevermind, TestPageHook() actually works. The compiler was evaluating the result of TestFn() at compile-time and not making any call.
Still unsure about the hang on unload.


OpenStack: allow target_image without client

This allows you to build a target_image without having the keystone and/or
glance clients installed. Pushing an image to a provider still requires them to
be present.

Many thanks for this.  I'll try adding similarly graceful handling to a few of the other plugins.  Still need to sort out a sensible/encouraged way to work this into the RPM deps (i.e. is this a good use of weak deps?)


Release 1.1.0

Tag and release 1.1.0

let's get #9 and #10 in first if possible

Changelog:
- add option to output yaml
- Support dereferencing symlinks
- Add support for symbolic links
- filetranspile: Support v2 and v3 specs for files
- README.md: Minor tweaks
- Support not specifying "base" Ignition file
- De-indent code
- Add '}' to make a sane README.md example

https://github.com/ashcrow/filetranspiler/releases/tag/1.1.0


Create Nuget Package that installs both Core and Editor

Same as how Umbraco has a package that installs the Core, Web and other packages.

This is what the Editor package does. A derp on my part.


No save dialog opens with latest Zenity (3.91.0).  (No longer implements "--confirm-overwrite")

OpenSuse Tumbleweed now has this version of Zenity as default.
When launching file save dialog from VCVRack, nothing happens - except a message on the console.
This option is not available. Please see --help for all possible usages.
As a workaround I have tried to comment out addition of this command parameter, and this seems to work - though not a permanent solution.
https://github.com/AndrewBelt/osdialog/blob/1c9aaab9aae8df296439d46bd83acbf326522ea7/osdialog_zenity.c#L183
Not sure if this is an upstream issue.

--confirm-overwrite was probably accidentally removed in a merge in https://gitlab.gnome.org/GNOME/zenity/-/commit/f17a8bfc875fada1a79e42f6f07119e91a6955f4. I'll report to the Zenity repo, but unfortunately I'll have to remove --confirm-overwrite in osdialog for several years, since Zenity's bug is out in the wild.
Removed flag in e2921e9

Filed bug report at https://gitlab.gnome.org/GNOME/zenity/-/issues/55
Added workaround in 9d46d8bb91e53c2f201333e058d8cbd7916949a6 that checks if --confirm-overwrite is available.


The counters are not showing up

after a song or two the counters dissapeared after i moved the miss counter to not interfere with the hud

Hi, this seems to be a problem I've yet to encounter on my own.
If you haven't upgraded to the new Counters+ 1.5.6 update, please do so via your Mod Manager of choice (Or manually via BeatMods.), and check back with whether or not the issue persists in 1.5.6.
However, if you've already updated, here's some things I would like from you:
Config (CountersPlus.ini)
Located in the UserData folder of your Beat Saber directory, it would help me test your setup, as well as figure any potential issues from there.
Recent Log (2019.05.03.something.log.gz)
Located in the Logs/Counters+ folder, this contains all the console output generated by Counters+, even if its an error that needs my attention.
Thanks!

Hopefully this is what you need. I’ve also added the _latest.log.gz just in case and I am on 1.5.6 of counters+ using beat saber mod manager. The problem specifically started when I moved the misses counter because it was interfering with the score numbers on the new UI and later I moved it back to the default settings although I might have missed something.
Sent from Mail for Windows 10
From: Caeden117
Sent: Friday, May 3, 2019 4:47 PM
To: Caeden117/CountersPlus
Cc: fruitbat99; Author
Subject: Re: [Caeden117/CountersPlus] The counters are not showing up (#16)
Hi, this seems to be a problem I've yet to encounter on my own.
If you haven't upgraded to the new Counters+ 1.5.6 update, please do so via your Mod Manager of choice (Or manually via BeatMods.), and check back with whether or not the issue persists in 1.5.6.
However, if you've already updated, here's some things I would like from you:
Config (CountersPlus.ini)
Located in the UserData folder of your Beat Saber directory, it would help me test your setup, as well as figure any potential issues from there.
Recent Log (2019.05.03.something.log.gz)
Located in the Logs/Counters+ folder, this contains all the console output generated by Counters+, even if its an error that needs my attention.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

So I'm having the exact same issue, but it happened out of the blue. I loaded up BS after updating mods and Counters+ broke, thought nothing of it. Recently installed CT so thought removing that would work, clearly it didn't. I even clean installed before I realized this was a documented issue.
Here's the log file after my clean install / /
2<IP_ADDRESS>.46.log.gz

The log file isn't giving me anything (Damnit, DaNike). If you ever get a chance to play Beat Saber, do you mind starting with --verbose as a launch argument (via Steam or Shortcut) and take a screenshot of that window when Counters+ breaks? (Should be highlighted in purple)

Went into a song, You can see exactly when I searched and played it. The error occurs after the song ends, weirdly.

This was also in the log after I entered the "Failed" screen where I can restart or continue

Ah shit, a null reference exception
It's getting really, really late so I'm going to head off for the night, I should fix it by the morning (hopefully).
In the time being, try regenerating the config file (simply moving the current one out of UserData would work) and see if that fixes stuff (probably not but worth a shot)

Yeah, nothing moves it from what I know, and as I said I clean installed and wiped everything and still having this issue. But good luck trying to fix this o/

I'm still going to need more than this.
How about you upload the last dated log in the base Logs folder, instead of the specific Counters+ one? The logs in the base Logs folder should have everything from every mod, so I can go through and see if there's any exceptions happening

2<IP_ADDRESS>.17.log.gz
_latest.log.gz
[2<IP_ADDRESS>.03.log.gz] (https://github.com/Caeden117/CountersPlus/files/3144644/2<IP_ADDRESS>.03.log.gz) one from an earlier date so you can check from that i belive this one still had counters+ working

It looks like the issue might be from when Counters+ is attempting to hide the Combo and Multiplier
counters.
Try this build out, and see if it solves anything.

That Fixed it! Thanks!

Alright, I'll go ahead and post a Hotfix build for this, then.


Cherry pick: #73 update base image and apply workaround

Cherry-picking #73 to release branch for JIRA: https://issues.jboss.org/browse/RHMAP-20547

@pb82 We are using 1.8-14, you probably looked only on one commit :)