Setting auth to false in Nuxt page is not working

Versions

nuxt: v2.14.6
node: v14.15.4

Reproduction

Additional Details

Steps to reproduce
// nuxt.config.js
export default {
  srcDir: 'src',
  head: {
    title: 'dashboard',
    meta: [
      { charset: 'utf-8' },
      { name: 'viewport', content: 'width=device-width, initial-scale=1' },
      { hid: 'description', name: 'description', content: '' },
    ],
    link: [{ rel: 'icon', type: 'image/x-icon', href: '/favicon.ico' }],
  },

  css: ['~/assets/style/variables', '~/assets/style/global'],

  publicRuntimeConfig: {
    baseURL: process.env.BASE_URL,
  },
  privateRuntimeConfig: {},

  plugins: [
    '@/plugins/antd-ui',
    '@/plugins/repository',
    '@/plugins/filters',
    '@/plugins/currency-input',
  ],

  components: false,

  ssr: false,

  buildModules: [
    '@nuxt/typescript-build',
    '@nuxtjs/stylelint-module',
  ],

  modules: [
    '@nuxtjs/axios',
    '@nuxtjs/auth-next',
  ],

  axios: {
    baseURL: process.env.BASE_URL,
    headers: {
      common: {
        'Access-Control-Allow-Origin': '*',
      },
    },
  },

  loading: {
    color: '#db6889',
  },

  build: {
    loaders: {
      less: {
        lessOptions: {
          javascriptEnabled: true,
        },
      },
    },
    extend(config, ctx) {
      config.devtool = ctx.isClient ? 'eval-source-map' : 'inline-source-map'
    },
  },

  router: {
    middleware: ['auth'],
  },

  auth: {
    redirect: {
      home: '/',
      login: '/auth/signin',
      logout: '/auth/signin',
    },
    strategies: {
      local: {
        token: {
          property: 'authToken',
        },
        endpoints: {
          login: { url: '/auth/dash-login', method: 'post' },
          logout: { url: '/auth/logout', method: 'put' },
          user: { url: '/auth/self', method: 'get' },
        },
      },
    },
  },
}

// pages/signup/index.js
<template>

</template>

What is Expected?
Once signup page configured auth: false, accessing /signup route should not call user endpoint through auth settings
What is actually happening?
/signup route is calling user endpoint through auth settings even with auth: false causing this error
xhr.js?b50d:177 GET https://redacted/auth/self 401 (Unauthorized)
index.js?6fc5:378 Uncaught (in promise) Error: ERR_ACTION_ACCESS_UNDEFINED: Are you trying to access this.someMutation() or this.someGetter inside an @Action?
That works only in dynamic modules.
If not dynamic use this.context.commit("mutationName", payload) and this.context.getters["getterName"]
Error: Could not perform action fetchCategories
    at Store.eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:392:37)
    at step (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:137:23)
    at Object.eval [as throw] (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:118:53)
    at rejected (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:109:65)
Error: ERR_ACTION_ACCESS_UNDEFINED: Are you trying to access this.someMutation() or this.someGetter inside an @Action?
That works only in dynamic modules.
If not dynamic use this.context.commit("mutationName", payload) and this.context.getters["getterName"]
Error: Could not perform action performRequest
    at Store.eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:392:37)
    at step (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:137:23)
    at Object.eval [as throw] (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:118:53)
    at rejected (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:109:65)
Error: ERR_ACTION_ACCESS_UNDEFINED: Are you trying to access this.someMutation() or this.someGetter inside an @Action?
That works only in dynamic modules.
If not dynamic use this.context.commit("mutationName", payload) and this.context.getters["getterName"]
Error: Could not perform action getCompanyId
    at Store.eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:392:37)
    at step (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:137:23)
    at Object.eval [as next] (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:118:53)
    at eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:111:71)
    at new Promise (<anonymous>)
    at __awaiter (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:107:12)
    at Store.action (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:352:20)
    at Array.wrappedActionHandler (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:860:23)
    at Store.dispatch (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:525:15)
    at Store.boundDispatch [as dispatch] (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:415:21)
TypeError: Cannot read property 'company' of null
    at Object.getCompanyId (webpack-internal:///./src/store/categories-store.ts:250:28)
    at Store.eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:365:65)
    at step (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:137:23)
    at Object.eval [as next] (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:118:53)
    at eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:111:71)
    at new Promise (<anonymous>)
    at __awaiter (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:107:12)
    at Store.action (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:352:20)
    at Array.wrappedActionHandler (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:860:23)
    at Store.dispatch (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:525:15)
    at Store.eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:386:35)
    at step (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:137:23)
    at Object.eval [as next] (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:118:53)
    at eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:111:71)
    at new Promise (<anonymous>)
    at __awaiter (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:107:12)
    at Store.action (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:352:20)
    at Array.wrappedActionHandler (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:860:23)
    at Store.dispatch (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:525:15)
    at Store.boundDispatch [as dispatch] (webpack-internal:///./node_modules/vuex/dist/vuex.esm.js:415:21)
    at Store.eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:386:35)
    at step (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:137:23)
    at Object.eval [as throw] (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:118:53)
    at rejected (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:109:65)
    at Store.eval (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:386:35)
    at step (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:137:23)
    at Object.eval [as throw] (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:118:53)
    at rejected (webpack-internal:///./node_modules/vuex-module-decorators/dist/esm/index.js:109:65)```

    This error breaks my vuex store and prevents my signup page to load correctly.
    I tried to ask this question in discord channel but with no answers yet.

https://github.com/nuxt-community/auth-module/issues/1192


Globe selectable in form page

Globe visualisation is still draggable and selectable in the form page, while it shouldn't.

fixed in new release


test: improve ApiService_CountTest test case

improve ApiService_CountTest test case

📚  View the storybook of this branch here

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of the Element Zero team's environment.

Has been reporter manually on source branch.
I close this PR.


fix: do not ignore invalid second signature field

Your pull request doesn't follow our contribution guidelines. Please review and correct it.


Fix for issue with ToDecimal operator

Fix for issue #37 ... Also added workaround for HL7DataProvider error caused by invalid Appointment resources in Hapi's DSTU2 test server.

Actually, now that I look again, I see that the commit I approved did have a fatal error.  The new test Power2DToNeg2DEquivalence added to CqlArithmeticFunctionsTest.xml was formatted wrong, with the "output" node being in the wrong place, which caused the test to fail citing no expected output given.  Next time, please actually run the tests (in IntelliJ) before committing, as it would have told you the test you added was failing.  I will make a commit which fixes this test, and removes the other TODO flag.


[Suggest] Should write How to delete files outside dist in README.md

I think you should write How to delete files outside dist in README.md
not only in https://github.com/johnagan/clean-webpack-plugin/issues/106.
It's a bit difficult to find it.

oh, sorry, I found you had written in README.md ...


Support listing the current options

Print the current merged settings in yaml format and exit.
Useful for troubleshooting on production environments.

It might be worth checking with support if the output contains the info they expect?


Add base support for converting catalogs that include multiple languages

Bug/issue #, if applicable: rdar://84169407
Summary
Adds base support for converting DocC Catalogs that include multiple languages by expanding symbol semantic models to hold language-specific variants.
This builds on previous work landed in:

#11
#16
#21
#25

Dependencies
None.
Testing
Build documentation for the included test bundle at Tests/SwiftDocCTests/Test\ Bundles/MixedLanguageFramework.docc and confirm that output is expected.
Steps:

export DOCC_HTML_DIR=/path/to/recent/swift-docc-render-artifact
From the root of this repository:swift run docc preview Tests/SwiftDocCTests/Test\ Bundles/MixedLanguageFramework.docc \
    --enable-experimental-objective-c-support \
    --index

Confirm that mixed-language content renders as expected.

Swift
Objective-C

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[x] Updated documentation if necessary

@swift-ci please test

@swift-ci please test

We were initially seeing a significant performance regression in this PR but @franklinsch and I have found some other ares of the codebase that could be optimized to negate the regression.
We're now seeing a significant performance improvement of around 20%.
TestFramework-5.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Compiled output size (MB)                | no change  | 57.37                | 57.37                |
| Duration for 'bundle-registration' (sec) | -21.40%    | 3.89                 | 3.06                 |
| Duration for 'convert-action' (sec)      | -17.24%    | 4.96                 | 4.11                 |
| Peak memory footprint (MB)               | -8.39%     | 221.56               | 202.97               |
| Topic Anchor Checksum                    | no change  | 65d4ff3050cd1106a21b | 65d4ff3050cd1106a21b |
| Topic Graph Checksum                     | no change  | 0a64c740a2ed5a246836 | 0a64c740a2ed5a246836 |
+------------------------------------------------------------------------------------------

TestFramework-10.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Compiled output size (MB)                | no change  | 114.71               | 114.71               |
| Duration for 'bundle-registration' (sec) | -21.25%    | 7.81                 | 6.15                 |
| Duration for 'convert-action' (sec)      | -16.63%    | 9.96                 | 8.30                 |
| Peak memory footprint (MB)               | -8.02%     | 385.14               | 354.24               |
| Topic Anchor Checksum                    | no change  | c8f03d4e81da8e3b6d7f | c8f03d4e81da8e3b6d7f |
| Topic Graph Checksum                     | no change  | edce22bce4f8de475a5e | edce22bce4f8de475a5e |
+-----------------------------------------------------------------------------------------------------+

TestFramework-25.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Compiled output size (MB)                | no change  | 287.64               | 287.64               |
| Duration for 'bundle-registration' (sec) | -20.37%    | 19.81                | 15.77                |
| Duration for 'convert-action' (sec)      | -17.11%    | 25.92                | 21.48                |
| Peak memory footprint (MB)               | -4.52%     | 880.44               | 840.62               |
| Topic Anchor Checksum                    | no change  | 9a675b9ad6d69f8b7f0c | 9a675b9ad6d69f8b7f0c |
| Topic Graph Checksum                     | no change  |<PHONE_NUMBER>84b5131a37 |<PHONE_NUMBER>84b5131a37 |
+-----------------------------------------------------------------------------------------------------+

TestFramework-50.json
+-----------------------------------------------------------------------------------------------------+
| Metric                                   | Change     | Before               | After                |
+-----------------------------------------------------------------------------------------------------+
| Compiled output size (MB)                | no change  | 579.70               | 579.70               |
| Duration for 'bundle-registration' (sec) | -21.23%    | 39.75                | 31.31                |
| Duration for 'convert-action' (sec)      | -16.78%    | 51.46                | 42.82                |
| Peak memory footprint (MB)               | -7.88%     | 1678.05              | 1545.80              |
| Topic Anchor Checksum                    | no change  | 08d0a84bec913460905f | 08d0a84bec913460905f |
| Topic Graph Checksum                     | no change  | 74d25c4f1ee185ad5676 | 74d25c4f1ee185ad5676 |
+-----------------------------------------------------------------------------------------------------+

The majority of this benefit comes from implementing copy-on-write semantics for the ResolvedTopicReference type: 9d4106b.
Lazy initialization of the expensive URL property within ResolvedTopicReference added another slight performance gain: 3f1b105

@swift-ci please test

@swift-ci please test


old pod deleter

basic logic we need ... seems to work ...
TODO:

config reading
reuse methods
tests

@aksgithub

what's the use case for this ?

"make kube-remediator cleanup old console pods"
these pods need to die if they do not get cleaned up .. also could be good for apps that have memory leaks :D

"make kube-remediator cleanup old console pods"
these pods need to die if they do not get cleaned up .. also could be good for apps that have memory leaks :D

For memory leaks, we should just let it OOMkilled and taken care of by Crashloop so it does not go under the radar.

the console pods are supposed to auto-kill after 24h so that's not a
problem ... we can do varian amounts of age with an annotation, but so far
we only have 1 usecase, so 24h can be the default :)
On Wed, Dec 11, 2019 at 3:37 PM Ankit Shah<EMAIL_ADDRESS>wrote:

@aksgithub commented on this pull request.
In pkg/remediator/oldpoddeleter.go
https://github.com/aksgithub/kube_remediator/pull/35#discussion_r356892670
:

+}

+func (p *OldPodDeleter) deleteOldPods() {

p.logger.Info("Running")

// get all pods that opted in to deletion
pods, err := p.client.GetPods("", metav1.ListOptions{

LabelSelector: "kube-remediator/OldPodDeleter=true",

})
if err != nil {

p.logger.Error("Error getting pod list: ", zap.Error(err))

return

}

// deleteOldPods those that are too old
cutoff := time.Now().Add(-24 * time.Hour)

what if definition of "old" varies among applications? Debugging session
more than 24 hours might be unrealistic but just a thought.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aksgithub/kube_remediator/pull/35?email_source=notifications&email_token=AAACYZZ7PQWZUEGIP57DONLQYF2VJA5CNFSM4JZUNO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCO4VVPQ#pullrequestreview-330914494,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACYZ5ZQCEKTST7BSLLM43QYF2VJANCNFSM4JZUNO5Q
.

for now as simple as possible, the only things I want to get done is the
reuse/testing ... rest can wait :)
... we can pair on that tomorrow
On Wed, Dec 11, 2019 at 3:44 PM Ankit Shah<EMAIL_ADDRESS>wrote:

@aksgithub approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aksgithub/kube_remediator/pull/35?email_source=notifications&email_token=AAACYZ6LTGS7FGICWJTKD4LQYF3NRA5CNFSM4JZUNO52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCO4WGVI#pullrequestreview-330916693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACYZYO3ICOQUIB6R3NHIDQYF3NRANCNFSM4JZUNO5Q
.


Error in test.py

nice work, but I find there is no folder named "filter" in test.py

Also I find load the pre-trained ckpt failed due to the mismatch of ckpt and model .

I encountered the same problem, and then I checked the Google link of the pretrained model provided in this repository. The provided link is the pretrained model link of TransMVSNet, so the code cannot run. It seems that the author forgot to make changes.

Thank you for point it out, you are right @Gwencong, I forgot to point to the new pre-trained model, it's been fixed now.
Hope this helps.

nice work, but I find there is no folder named "filter" in test.py

The 'filter' part is not needed for GC-MVSNet, you can comment that out if you find it anywhere. I have removed it from test.py. That was for next set of experiments that I was doing and is not relevant to GC-MVSNet.
Hope it helps!

Thanks

Thank you for point it out, you are right @Gwencong, I forgot to point to the new pre-trained model, it's been fixed now.
Hope this helps.

I noticed that there is only a checkpoint trained on DTU. Have you uploaded model fine-tuning on BlendedMVS ?


Joining a session using a link doesnt work when using a WSL connected vscode instance

Issue Type: Bug
Steps:

Load any project within a WSL context on Windows.
Try to join someone elses shared session
Starting the IDE fails with an error and the session can not be connected to

Expectation:

The IDE would correctly connect to the sessions

Notes:

Connecting to session from a project that is not hosted on WSL seems to work just fine

Extension version: 1.0.2427
VS Code version: Code 1.47.1 (485c41f9460bdb830c4da12c102daff275415b53, 2020-07-13T22:42:53.386Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.19.104-microsoft-standard

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.86GB (12.20GB free)

Process Argv
--open-url -- vscode://ms-vsliveshare.vsliveshare/join?vslsLink=https%3A%2F%2Fprod.liveshare.vsengsaas.visualstudio.com%2Fjoin%3F4307A35274A64609A93D2549DF01AB2E8AEC&correlationId=null

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu

OS
Linux x64 4.19.104-microsoft-standard

CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (3 x 2807)

Memory (System)
5.80GB (0.17GB free)

VM
0%

Hi @addshore - Thank you for reporting this issue. Can you make sure you are using 'Auto' or 'Relay' for the Connection Mode setting? Settings->Extensions-Visual Studio Live Share->Connection Mode.

Hi @addshore - Thank you for reporting this issue. Can you make sure you are using 'Auto' or 'Relay' for the Connection Mode setting? Settings->Extensions-Visual Studio Live Share->Connection Mode.
It was on "auto" when trying this last, I'll try to set it to "relay" on my next attempt!

I don't appear to be able to reproduce this now


Fix whitespace

I fixed the whitespace of the README in micro-boot.
There were some leading spaces before some headings, which prevented the headings from rendering correctly. While I was at it, I fixed the whole file.

Excellent - thanks!


Issue 4 assertion error

The files created by infer_schema contained a row number zero which was
created by the dqc_utils._adjust_ws which was iterating starting row zero,
while excel row indexing start generally at 1
This row zero was then raising an assertion error when opening the file with xlrd

sorry I realized my pull requests are not independant from each other - I made cumulative changes. I will correct that and create a new pull request with each change separately.


Add full-fledged Poseidon and use it everywhere (Marlin and Schnorr)

Motivation
Let me apologize to @raychu86 first, as this PR might still have a few conflicts with the Schnorr signature you are working on.
This PR adds the latest implementation from ark-sponge of Poseidon and matches the official Poseidon reference implementation (which implies that ours is also a reference implementation). This part is captured by snarkvm-sponge.
Then, it replaces the existing sponge in Marlin constraint gadgets, as well as replaces the Blake2s hash function used in the Schnorr signature (this is where I came across Raymond's PR #242 since we are both removing Blake2s).
Test Plan
The code passes a number of existing tests in the repo.
Related PRs
This is based on #231 and subsumes #242.
Followup
As Pratyush pointed out, sometimes the sponge is used in more than one proof system, and one may want an optimized set of parameters that is not too bad for Groth16, not too bad for Marlin. This will be surely in a separate PR, and it also involves research on the detailed performance gap between Groth16 and Marlin, so that we can weigh the optimization goal properly.

This PR also has overlapped with #245, but #245 fixes other issues and should also be merged into the master soon.

one moment fixing dependencies... it seems to be more complicated than I think so I will start my VM...


[SERVER] Deduplicate functions in Game and SP code

Nearly every function is server/game.coffee is duplicated in server/single_player.coffee:
dnsHealthCheck = () ->
server = http.createServer (req, res) ->
server.listen config.get('game_port'), () ->
savePlayerCount = (playerCount) ->
saveGameCount = (gameCount) ->
getConnectedSpectatorsDataForGamePlayer = (gameId,playerId)->
onGamePlayerJoin = (requestData) ->
onGameSpectatorJoin = (requestData) ->
onGameLeave = (requestData) ->
onGameEvent = (eventData) ->
onGameDisconnect = () ->
playerLeaveGameIfNeeded = (socket, silent=false) ->
spectatorLeaveGameIfNeeded = (socket) ->
destroyGameSessionIfNoConnectionsLeft = (gameId,persist=false)->
tearDownSpectateSystemsIfNoSpectatorsLeft = (gameId)->
clearDisconnectedPlayerTimeout = (gameId) ->
startDisconnectedPlayerTimeout = (gameId,playerId) ->
onDisconnectedPlayerTimeout = (gameId,playerId) ->
restartTurnTimer = (gameId) ->
stopTurnTimer = (gameId) ->
onGameTimeTick = (gameId) ->
restartSpectatorDelayedGameInterval = (gameId) ->
stopSpectatorDelayedGameInterval = (gameId) ->
onSpectatorDelayedGameTick = (gameId) ->
flushSpectatorNetworkEventBuffer = (gameId) ->
_logSpectatorTickInfo = _.debounce((gameId)->
emitGameEvent = (fromSocket,gameId,eventData)->
initGameSession = (gameId,onComplete) ->
initSpectatorGameSession = (gameId)->
onBeforeRollbackToSnapshot = (event) ->
onStep = (event) ->
onInvalidAction = (event) ->
subscribeToGameSessionEvents = (gameId)->
unsubscribeFromGameSessionEvents = (gameId)->
afterGameOver = (gameId, gameSession, mouseAndUIEvents) ->
shutdown = () ->

We should deduplicate as much of this as possible to make maintenance easier.

A lot of the code here is indeed duplicated but there may be subtle differences. I believe the initial implementation of the single player server was an experiment and we had just copy-pasted the code but would make sense to convert into a shared library.

Definitely! I'll diff each of these one at a time and see what we can do.

I wrote a Python script to diff these automatically:
from typing import Dict, List

# Identifies CoffeeScript functions through signature and indentation.
def find_functions(filename: str) -> Dict[str, List[str]]:
    start_index = -1
    functions: Dict[str, List[str]] = dict()

    with open(filename, 'r') as f:
        lines = f.readlines()

    for i in range(0, len(lines)):
        line = lines[i]

        # Ignore comments and lines starting with whitespace.
        if line[0] in ('#', '\t', ' '): continue

        # Save the starting line for function declarations.
        if '->' in line and ' = (' in line:
            start_index = i
            continue

        # Don't try to find the end of a function before one begins.
        if start_index == -1: continue

        # Something new has started at the top level; save and reset.
        functions[lines[start_index].rstrip('\n')] = lines[start_index:i]
        start_index = -1

    return functions

# Returns True if the provided lists have identical contents.
def diff_function(a: List[str], b: List[str]) -> bool:
    if len(a) != len(b):
        return False
    for i in range(len(a)):
        if a[i] != b[i]:
            return False
    return True

if __name__ == '__main__':
    game = find_functions('game.coffee')
    sp = find_functions('single_player.coffee')
    for f in game.keys() & sp.keys():
        if diff_function(game[f], sp[f]):
            print('Function with declaration {} is duplicated!'.format(f))

The results are:
Function with declaration restartTurnTimer = (gameId) -> is duplicated!
Function with declaration onInvalidAction = (event) -> is duplicated!
Function with declaration destroyGameSessionIfNoConnectionsLeft = (gameId,persist=false)-> is duplicated!
Function with declaration shutdown = () -> is duplicated!
Function with declaration onGameEvent = (eventData) -> is duplicated!
Function with declaration dnsHealthCheck = () -> is duplicated!
Function with declaration stopSpectatorDelayedGameInterval = (gameId) -> is duplicated!
Function with declaration spectatorLeaveGameIfNeeded = (socket) -> is duplicated!
Function with declaration playerLeaveGameIfNeeded = (socket, silent=false) -> is duplicated!
Function with declaration onStep = (event) -> is duplicated!
Function with declaration onGamePlayerJoin = (requestData) -> is duplicated!
Function with declaration tearDownSpectateSystemsIfNoSpectatorsLeft = (gameId)-> is duplicated!
Function with declaration saveGameCount = (gameCount) -> is duplicated!
Function with declaration flushSpectatorNetworkEventBuffer = (gameId) -> is duplicated!
Function with declaration initSpectatorGameSession = (gameId)-> is duplicated!
Function with declaration stopTurnTimer = (gameId) -> is duplicated!
Function with declaration restartSpectatorDelayedGameInterval = (gameId) -> is duplicated!
Function with declaration onGameSpectatorJoin = (requestData) -> is duplicated!
Function with declaration savePlayerCount = (playerCount) -> is duplicated!
Function with declaration onGameTimeTick = (gameId) -> is duplicated!
Function with declaration onSpectatorDelayedGameTick = (gameId) -> is duplicated!
Function with declaration afterGameOver = (gameId, gameSession, mouseAndUIEvents) -> is duplicated!
Function with declaration initGameSession = (gameId,onComplete) -> is duplicated!
Function with declaration getConnectedSpectatorsDataForGamePlayer = (gameId,playerId)-> is duplicated!

Another challenge is the reliance on global vars, specifically these two:

io object: https://github.com/open-duelyst/duelyst/blob/fa4184f/server/single_player.coffee#L73
games object: https://github.com/open-duelyst/duelyst/blob/fa4184f/server/single_player.coffee#L95

Functions accessing these (nearly all of the above) would need to be refactored or remain duplicated.


Improved: tooltip content on the registration form

Improved the tooltip content for the screen name in the registration form

Hi,
As I am looking around the roller, found that when using struts2 tags the tooltip attribute does not support HTML, so Should we remove HTML from the tooltip text?
Text passed as tooltip content: https://github.com/apache/roller/blob/master/app/src/main/resources/ApplicationResources.properties#L1451**
UI:

the bootstrap ui does still support html in tooltips, its just disabled by default.
see https://getbootstrap.com/docs/3.4/javascript/#tooltips-options
I am not sure what would be the best way to enable it. Doesn't look like struts lets you set a data attribute.

Hi @ymaheshwari1 @mbien,
For the current case, I think we can consider removing the HTML as there are security concerns enabling the HTML mode.
WDYT?

I think, yes we can do that, as the HTML is used only in some tooltips.

Hi @ymaheshwari1 @mbien,
For the current case, I think we can consider removing the HTML as there are security concerns enabling the HTML mode.
WDYT?

yeah sure, there are not that many anyway. I was checking if we could maybe enable some selectively for strings which are known to be static. But yeah lets just remove them.
are those properties also tooltips or are they used somwhere else?
https://github.com/apache/roller/blob/743f1d246deab7d90221cc864093f00c4f672ecd/app/src/main/resources/ApplicationResources.properties#L1474-L1476
since they contain links.

OpenID

Hi, These are displayed when the authMethod != 'LDAP'. Also, they are not tooltips.
https://github.com/apache/roller/blob/master/app/src/main/webapp/WEB-INF/jsps/core/Register.jsp#L73
But, as they are used in s:text, it only considers string in it.
https://struts.apache.org/tag-developers/text-tag.html

thanks for the fix looks good.


Add support for use in fixtures

Implements the changes I suggested in https://github.com/ktosiek/pytest-vcr/pull/5#issuecomment-312238773.

vcr_cassette_path has been replaced with vcr_cassette_dir, which is used to initialize the VCR object. This makes it possible to use the following pattern:

def test_something(vcr):
    with vcr.use_cassette('test_something', ...kwargs...):
        ...

Extend fixtures' scope to 'module' so they can be used in fixtures with a wider scope. 'session' would be preferred, but the test directory path can not be obtained at that scope. This means that the VCR object is instantiated once per module rather than for every test, which is preferable anyway, I think. The only downside is that overriding fixtures becomes slightly more verbose: you have to include the scope='module' bit.

Coverage increased (+0.6%) to 98.305% when pulling c596a2453a64255f142e78b8b0bdcda086a6d04e on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling c596a2453a64255f142e78b8b0bdcda086a6d04e on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling c596a2453a64255f142e78b8b0bdcda086a6d04e on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling c596a2453a64255f142e78b8b0bdcda086a6d04e on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling 74e1534d9750feab362ee32d68303317865f40ba on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling 74e1534d9750feab362ee32d68303317865f40ba on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling 74e1534d9750feab362ee32d68303317865f40ba on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling 74e1534d9750feab362ee32d68303317865f40ba on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling 74e1534d9750feab362ee32d68303317865f40ba on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Coverage increased (+0.6%) to 98.305% when pulling 74e1534d9750feab362ee32d68303317865f40ba on valgur:use-in-fixtures into 5e0ed7ca3c71446ea57c54e600b52a0c03b151cc on ktosiek:master.

Sorry for not getting back to you sooner. I was a bit swamped with work in the past week as well.
I'm glad you liked the changes.
I'm afraid I can't help much with the docs right now, though, since I'll be offline and on a vacation for the next two weeks. You can work on them in the mean time, if you feel like it. Either way, I'll gladly take care of this once I'm back.


Single-select autocomplete doesn't open on click after selecting option

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
I am using Autocomplete component with single-choice that closes on option select. When an option has been selected, it closes, but stays in focus which prevents it from opening when the user clicks on the input again.
Expected Behavior 🤔
After an option has been selected, autocomplete closes but reacts on click by showing the list of options again.
Steps to Reproduce 🕹
Can be reproduced on all examples of single-choice autocomplete without disableCloseOnSelect set to true. See https://material-ui.com/components/autocomplete/.
Steps:

Open an autocomplete by clicking on it
Select an option (autocomplete closes)
Click on the input field of the autocomplete
The list of options doesn't appear

Context 🔦
I have tried setting my own open state and trying to control it myself, but got issues with input focus and the component getting open and closed multiple times in a row.
Your Environment 🌎

Tech
Version

Material-UI
v4.9.3

Material-UI lab
v4.0.0-alpha.47

React
v16.9.0

Browser
all

etc.

The autocomplete component is perfect for our application at work, unfortunately this issue is considered to be rather crucial, so I really appreciate any help on this!
Thanks in advance! 🙂

It's expected, why should it behave differently?

I thought I saw a comment here, but can't see it anymore. Have I missed something?

I can work on it @oliviertassinari

@MargaretKrutikova Yeah, sorry, we have had a regression since the first version of the component.

@oliviertassinari no worry! thanks a lot for looking into this 🙂

I really appreciate such a quick fix! However I have noticed that when there is an option selected and the list is open, you can't click on the input field to toggle open/close on it. Just received this comment from our testers. Any way this could be fixed?
Thanks! 🙂

@MargaretKrutikova I'm not sure we would want to address this in the core of the library, did you try to customize the behavior?

Awesome. Let us know if there is something preventing to implement the behavior. My main concern against moving this logic in the core is about what happen with text selection? I have recently learned about getSelection().isCollapsed, so maybe it could be something to bring into the core after all but to be careful.

I have tried the idea I was suggesting above:
diff --git a/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js b/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js
index b22099b2a..6eb66a7ae 100644
--- a/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js
+++ b/packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js
@@ -861,7 +861,7 @@ export default function useAutocomplete(props) {
   };

   const handleInputMouseDown = (event) => {
-    if (inputValue === '' || !open) {
+    if (getSelection().isCollapsed) {
       handlePopupIndicator(event);
     }
   };

It doesn't feel like something we would want to push further. It feels off when the user tries to change the position of the caret or when he double click to select all. I don't know how we could handle these cases.


Escapi library not showing any output

Hi, I am using the escapi binaries for my project....... I have created a Windows Desktop wizard empty application using visual studio 16 and added the escapi.h, escapi.cpp, and escapi.dll to my project but when I run my project it does not show anything and it does not even detect my camera....where should I add the escapi.dll or do I need to do anything else to make it work .

Take a look at the sample code included with this project. Your Windows Desktop project has to use the functions in escapi.h to open a camera, capture a frame, and then you will have to write code to display that frame using the WinForms API.
If this is your first time doing something like this, I would recommend cloning this repository and modifying one of the sample projects - ogl and multicap are good starting points.

Take a look at the sample code included with this project. Your Windows Desktop project has to use the functions in escapi.h to open a camera, capture a frame, and then you will have to write code to display that frame using the WinForms API.
If this is your first time doing something like this, I would recommend cloning this repository and modifying one of the sample projects - ogl and multicap are good starting points.


CAMEL-19783: Added reconnection, even if a message has not yet been r…

Backport of https://github.com/apache/camel/pull/11285 to camel-4.0.x branch

Thank you.

You're welcome. :)


pandas agent not working with langgraph

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangGraph/LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangGraph/LangChain rather than my code.
[X] I am sure this is better as an issue rather than a GitHub discussion, since this is a LangGraph bug and not a design question.

Example Code
pandas_agent = create_pandas_dataframe_agent(
    llm,
    df,
    verbose=True,
    agent_type=AgentType.OPENAI_FUNCTIONS,
    # agent_type="openai-tools",
    allow_dangerous_code=True
)
pandas_node = functools.partial(agent_node, agent=pandas_agent, name="Analyst")

workflow = StateGraph(AgentState)
workflow.add_node("Analyst", pandas_node)

for member in members:
    # We want our workers to ALWAYS "report back" to the supervisor when done
    workflow.add_edge(member, "supervisor")
# The supervisor populates the "next" field in the graph state
# which routes to a node or finishes
conditional_map = {k: k for k in members}
conditional_map["FINISH"] = END
workflow.add_conditional_edges("supervisor", lambda x: x["next"], conditional_map)
# Finally, add entrypoint
workflow.set_entry_point("supervisor")

graph = workflow.compile()

for s in graph.stream(
    {
        "messages": [
            HumanMessage(content="summarize the columns in the dataframe provided to you")
        ]
    }
):
    if "__end__" not in s:
        print(s)
        print("----")

Error Message and Stack Trace (if applicable)
ValueError                                Traceback (most recent call last)
Cell In[63], line 1
----> 1 for s in graph.stream(
      2     {
      3         "messages": [
      4             HumanMessage(content="summarize the columns in the dataframe provided to you")
      5         ]
      6     }
      7 ):
      8     if "__end__" not in s:
      9         print(s)

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langgraph\pregel\__init__.py:1073, in Pregel.stream(self, input, config, stream_mode, output_keys, input_keys, interrupt_before, interrupt_after, debug)
   1070         del fut, task
   1072 # panic on failure or timeout
-> 1073 _panic_or_proceed(done, inflight, step)
   1074 # don't keep futures around in memory longer than needed
   1075 del done, inflight, futures

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langgraph\pregel\__init__.py:1643, in _panic_or_proceed(done, inflight, step)
   1641             inflight.pop().cancel()
   1642         # raise the exception
-> 1643         raise exc
   1645 if inflight:
   1646     # if we got here means we timed out
   1647     while inflight:
   1648         # cancel all pending tasks

File ~\.pyenv\pyenv-win\versions\3.11.2\Lib\concurrent\futures\thread.py:58, in _WorkItem.run(self)
     55     return
     57 try:
---> 58     result = self.fn(*self.args, **self.kwargs)
     59 except BaseException as exc:
     60     self.future.set_exception(exc)

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langgraph\pregel\retry.py:72, in run_with_retry(task, retry_policy)
     70 task.writes.clear()
     71 # run the task
---> 72 task.proc.invoke(task.input, task.config)
     73 # if successful, end
     74 break

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langchain_core\runnables\base.py:2499, in invoke(self, input, config)
   2497 # invoke all steps in sequence
   2498 try:
-> 2499     for i, step in enumerate(self.steps):
   2500         # mark each step as a child run
   2501         config = patch_config(
   2502             config, callbacks=run_manager.get_child(f"seq:step:{i+1}")
   2503         )
   2504         if i == 0:

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langgraph\utils.py:95, in RunnableCallable.invoke(self, input, config, **kwargs)
     93     if accepts_config(self.func):
     94         kwargs["config"] = config
---> 95     ret = context.run(self.func, input, **kwargs)
     96 if isinstance(ret, Runnable) and self.recurse:
     97     return ret.invoke(input, config)

Cell In[24], line 2
      1 def agent_node(state, agent, name):
----> 2     result = agent.invoke(state)
      3     return {"messages": [HumanMessage(content=result["output"], name=name)]}

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langchain\chains\base.py:163, in invoke(self, input, config, **kwargs)
    154     self._validate_inputs(inputs)
    155     outputs = (
    156         self._call(inputs, run_manager=run_manager)
    157         if new_arg_supported
    158         else self._call(inputs)
    159     )
    161     final_outputs: Dict[str, Any] = self.prep_outputs(
    162         inputs, outputs, return_only_outputs
--> 163     )
    164 except BaseException as e:
    165     run_manager.on_chain_error(e)

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langchain\chains\base.py:151, in invoke(self, input, config, **kwargs)
    136 callback_manager = CallbackManager.configure(
    137     callbacks,
    138     self.callbacks,
   (...)
    143     self.metadata,
    144 )
    145 new_arg_supported = inspect.signature(self._call).parameters.get("run_manager")
    147 run_manager = callback_manager.on_chain_start(
    148     dumpd(self),
    149     inputs,
    150     run_id,
--> 151     name=run_name,
    152 )
    153 try:
    154     self._validate_inputs(inputs)

File c:\Users\AzharMajeed\Documents\.venv\Lib\site-packages\langchain\chains\base.py:279, in _validate_inputs(self, inputs)
    273         _input_keys = _input_keys.difference(self.memory.memory_variables)
    274     if len(_input_keys) != 1:
    275         raise ValueError(
    276             f"A single string input was passed in, but this chain expects "
    277             f"multiple inputs ({_input_keys}). When a chain expects "
    278             f"multiple inputs, please call it by passing in a dictionary, "
--> 279             "eg `chain({'foo': 1, 'bar': 2})`"
    280         )
    282 missing_keys = set(self.input_keys).difference(inputs)
    283 if missing_keys:

ValueError: Missing some input keys: {'input'}

Description
I am trying to add a pandas agent in a mutli agent setup, similar to how it is shown in this notebook. https://github.com/langchainai/langgraph/blob/main/examples/multi_agent/agent_supervisor.ipynb
I imported the pandas agent: from langchain_experimental.agents import create_pandas_dataframe_agent. Please let me know if this is the right way to add the pandas agent as a node in the graph. When I run the pandas agent separately it works fine, but when I add it do the graph I am getting this ValueError saying "Missing some input keys: {'input'}".
Please let me know if I need to provide any further details.
System Info
System Information

OS:  Windows
OS Version:  10.0.22631
Python Version:  3.11.2 (tags/v3.11.2:878ead1, Feb  7 2023, 16:38:35) [MSC v.1934 64 bit (AMD64)]

Package Information

langchain_core: 0.2.10
langchain: 0.2.6
langchain_community: 0.2.6
langsmith: 0.1.82
langchain_experimental: 0.0.62
langchain_openai: 0.1.7
langchain_text_splitters: 0.2.2
langchainhub: 0.1.14
langgraph: 0.1.5

hi @azharmajeed-cml
The issue is likely because you're trying to pass graph state to the pandas dataframe agent, but it expects the inputs key which is not in the graph state. you would need to wrap it in a separate helper in the following way:
def pandas_node(state):
    # or whichever message in the state you need
    result = pandas_agent.invoke(state["messages"][-1].content)
    return {"messages": [HumanMessage(content=result["output"], name=name)]}

we'll also update these guides as for tool-calling agents we now recommend using langgraph prebuilt implementation (like from langgraph.prebuilt import create_react_agent

Hi @vbarda your solution above fixes the issue I had. Thanks for the suggestion to use prebuilt react agents from langgraph, will try it out.

@azharmajeed-cml Can you show the example code of how you create a LangGraph to handle pandas agent ? , i got a bunch of errors , and i dont find any docs or examples about it


Cannot read this morphology

While trying to load an SWC morphology using MorphIO, I get this error:
  File "/home/abdellah/blender/bluebrain-blender-3.1/blender-neuromorphovis/3.1/scripts/addons/neuromorphovis/nmv/file/readers/morphology/morphio_reader.py", line 184, in read_data_from_file
    morphio_morphology = Morphology(self.morphology_file)
morphio._morphio.SomaError:
/abdellah1/diadem-challenge-reconstructions/104198-F-000000_seg001_linesetTransformRelease.swc:2:error
Found a soma point with a neurite as parent

The morphology is attached.
104198-F-000000_seg001_linesetTransformRelease.zip

@eleftherioszisis I just found it here http://www.flycircuit.tw/modules.php?name=browsing&parent=browsing&op=list_gene and was trying to build it. So I don't really know.

Does it work if you replace 6 -> 1 in the first line? Sometimes the file formats are not standardized, and for swc the first rows should represent the soma.

first rows should represent the soma.

I can't remember if we're picky about the soma being the first rows (we are internally; they should be standardized); however, what don't allow is soma point with a neurite as parent, because that breaks all the iteration invariants: the soma is considered the root node.

Hey @mgeplf I have just noticed over the last few days that there are several morphologies that identify the soma with an id that is not 1 in the SWC file. This makes me wonder whether we have to make MorphIO aware of such morphologies and load them anyways!
These morphologies, while being readable by other SWC neuron readers cannot be processed neither by Brayns nor by NMV becuase we use MorphIO to load these morphologies.
I am attaching one of these morphologies downloaded from the BigNeuron project.
1_1_Live_2-2-2010_9-52-24_AM_med_Red.tif_uint8.v3dpbd.zip
CC: @jplanasc

One more morphology with a branch ID of 18 !!!
# generated by Vaa3D Plugin sort_neuron_swc
# source file(s): /local1/home/Hanbo/Hanchuan_curated/checked3_fruitfly_taiwan_flycircuit/uint8_ChaMARCM-F000106_seg001.lsm_c_3.tif/uint8_ChaMARCM-F000106_seg001.lsm_c_3.tif.v3dpbd.swc
# id,type,x,y,z,r,pid
1 18 230 609 19 8 -1
2 18 230 608 19 8 1
3 18 230 607 19 7 2
4 18 230 606 19 6 3
5 18 230 605 20 5 4
6 18 230 604 20 5 5
7 18 230 603 20 4 6
8 18 230 602 20 4 7
9 18 230 601 21 3 8
10 18 230 600 21 3 9
11 18 230 599 21 3 10
12 18 230 598 21 3 11
13 18 230 597 21 3 12
14 18 230 596 21 3 13
15 18 230 595 21 3 14
16 18 230 594 22 3 15
17 18 230 593 22 3 16
18 18 230 592 22 3 17
19 18 230 591 22 3 18
20 18 230 590 22 3 19
....

Can't we just handle and branch with any id and consider it a basal dendrite just for the sake of loading it?
uint8_ChaMARCM-F000106_seg001.lsm_c_3.tif.v3dpbd.zip

Hey @mgeplf I have just noticed over the last few days that there are several morphologies that identify the soma with an id that is not 1 in the SWC file.

According to the "spec", 1 is the soma.  I don't think it's wise to start trying to detect what is a soma, vs what is not a soma for files that are non-compliant.

Can't we just handle and branch with any id and consider it a basal dendrite just for the sake of loading it?

Arbitrarily assuming something is a basal dendrite also seems dangerous.  We can add more "custom" types here:
https://github.com/BlueBrain/MorphIO/blob/master/include/morphio/enums.h#L81
but we're up to 10 already, and there is some amount of consensus that above 10 should be invalid.

@mgeplf I agree with you. Nonetheless, it is really interesting that several morphologies that are even used in certain cases for validation are really not following the standard format! This is really really bad. I would therefore close the ticket.

@mgeplf This paper concludes that 166 datasets were given as gold standard for validation.

Interesting.  I see that Ascoli is an author, and there are many Allen people.  There appears to be efforts to make the SWC specification more clear, and Ascoli is part of that, as are Allen people:
https://swc-specification.readthedocs.io/en/latest/governance.html
This includes the specification:
https://swc-specification.readthedocs.io/en/latest/swc.html
which says:
The first point in the file must have a ParentID equal to -1, which represents the root point.

and that the soma is labeled as type 1 (the table doesn't display well, see this PR for the fix: https://github.com/INCF/swc-specification/pull/7)


Add a CLI option to stream table

Sometimes when I run many processes, I want to see table updated when they are actually started. This PR updates the console each time table is updated.

Coverage decreased (-0.7%) to 72.662% when pulling ca4a04048cb627593db70c4c7246cd776b2c166f on add-option-to-stream-table into 0de93e1e8bd09462beae53b0b3b2d57402957777 on master.


Feature/loggroup incremental search

fix #3

Codecov Report

Merging #14 (277d023) into master (cb9dd3b) will decrease coverage by 1.38%.
The diff coverage is 73.43%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   83.62%   82.23%   -1.39%
==========================================
  Files          18       18
  Lines         464      501      +37
  Branches       97      105       +8
==========================================
+ Hits          388      412      +24
- Misses         11       19       +8
- Partials       65       70       +5

Impacted Files
Coverage Δ

src/app.rs
81.18% <ø> (ø)

src/ui/side_menu.rs
64.70% <60.00%> (-4.35%)
:arrow_down:

src/state/loggroups_state.rs
82.35% <75.55%> (-9.96%)
:arrow_down:

src/loggroups.rs
100.00% <100.00%> (+3.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9dd3b...277d023. Read the comment docs.


kelbyone.com Kelby Training Videos

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.12.10. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2017.12.10

Before submitting an issue make sure you have:

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://members.kelbyone.com/lesson/getting-started-20/
Single video: https://members.kelbyone.com/lesson/planning-the-session/
Playlist: https://members.kelbyone.com/course/skelby-beginners-start-here/

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Duplicate of #7733.

The example videos delivered when not logged in are available through the generic extractor (with nightly 2024.04.06).
If the member videos aren't available by passing logged-in browser cookies, possibly also passing the UA of the browser, please open a new issue and arrange to provide credentials for development.


WRKLDS-1016: Bump kube dependencies to 1.29.0

This PR bumps k8s dependencies to 1.29.0 for OCP 4.16.

/hold
until rodoo 1.1.0 is released

4.15 release upstream sources pined to release-4.15 branch
/hold cancel
/lgtm


Mast: Watch court[\W_]+case[\W_]+spells

Mast requests the watch of the watch_keyword court[\W_]*+case[\W_]*+spells. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

court[\W_]*+case[\W_]*+spells has been seen in 3 true positives, 0 false positives, and 0 NAAs.

Approved by Daniil in Charcoal HQ


Faster attestation processor

In attestation processor

Remove slow committee computation
Remove special-case genesis state fetching

unit tests failed


Working fluentd stopped following tail for one file

Describe the bug
We're using fluentd in k8s to fetch all the tailing logs and send it to a mongo database. Generally, it works as expected.
After long time, it happens randomly that fluentd stops tailing a file, so we lost important log data for more than 1 day. Other fluentd apps (on other nodes) worked as expected, and given node worked as expected for everything except for that tailing file. This is not the first time it happened (last time we noticed it on May 6th).
That tailed file is a log file of a pod that has huge amount of logs. Prior to the issue pod was running 3-4 days without stop without any issues with logging. Last log that passed through from that file was at "2022-06-25T19:17:35.751Z". Before that moment, each time that rotation of that file happened, there was a pair of logs: detected rotation + following tail. Later, each time that rotation happened, it logger only: detected rotation.
Before (last, and each before):
2022-06-25T19:13:05.741980613Z stdout F 2022-06-25 19:13:05 +0000 [info]: #0 [in_tail_container_logs] detected rotation of /var/log/containers/api-6d756f4555-jt7zz_default_api-c7e8458c243f365986db0861cb3f73de09d1d4b61a045f52276465c6c3559290.log; waiting 5 seconds
2022-06-25T19:13:05.743587912Z stdout F 2022-06-25 19:13:05 +0000 [info]: #0 [in_tail_container_logs] following tail of /var/log/containers/api-6d756f4555-jt7zz_default_api-c7e8458c243f365986db0861cb3f73de09d1d4b61a045f52276465c6c3559290.log

After (first, and every next):
2022-06-25T19:17:36.744586203Z stdout F 2022-06-25 19:17:36 +0000 [info]: #0 [in_tail_container_logs] detected rotation of /var/log/containers/api-6d756f4555-jt7zz_default_api-c7e8458c243f365986db0861cb3f73de09d1d4b61a045f52276465c6c3559290.log; waiting 5 seconds

To note file at /var/log/containers/api-6d756f4555-jt7zz_default_api-c7e8458c243f365986db0861cb3f73de09d1d4b61a045f52276465c6c3559290.log looked healthy and ok, and was constantly outputting healthy logs (it was rotated once each ~12 minutes). We mitigated by just restarting that api pod - it changed name and that changed file name, which fluentd followed fine later. Problem existed since that problematic point in time until we did mitigation, for only that file. There was no need to restart fluentd.
To Reproduce
Can't repro.
Expected behavior
Not to stop tailing.
Your Environment
- Fluentd version: fluentd 1.13.3
- TD Agent version: /
- Operating system:
NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.13.5
PRETTY_NAME="Alpine Linux v3.13"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://bugs.alpinelinux.org/"

- Kernel version: 4.19.0-17-cloud-amd64

(Using docker image fluent/fluentd:v1.13-1)

Your Configuration
Cannot repro, so I'm putting whole config in (db config is replaced when deploying).
# Inputs from container logs
<source>
  @type tail
  @id in_tail_container_logs
  path /var/log/containers/*.log
  pos_file /var/log/fluentd.log.pos
  read_from_head
  tag kubernetes.*
  <parse>
    @type cri
  </parse>
</source>

# Merge logs split into multiple lines
<filter kubernetes.**>
  @type concat
  key message
  use_partial_cri_logtag true
  partial_cri_logtag_key logtag
  partial_cri_stream_key stream
  separator ""
</filter>

# Enriches records with Kubernetes metadata
<filter kubernetes.**>
  @type kubernetes_metadata
</filter>

# Prettify kubernetes metadata
<filter kubernetes.**>
  @type record_transformer
  enable_ruby
  <record>
    nodeName ${record.dig("kubernetes", "host")}
    namespaceName ${record.dig("kubernetes", "namespace_name")}
    podName ${record.dig("kubernetes", "pod_name")}
    containerName ${record.dig("kubernetes", "container_name")}
    containerImage ${record.dig("kubernetes", "container_image")}
  </record>
  remove_keys docker,kubernetes
</filter>

# Expands inner json
<filter kubernetes.**>
  @type parser
  format json
  key_name message
  reserve_data true
  remove_key_name_field true
  emit_invalid_record_to_error false
  time_format %Y-%m-%dT%H:%M:%S.%NZ
  time_key time
  keep_time_key
</filter>

# Mongodb keys should not have dollar or a dot inside
<filter kubernetes.**>
  @type rename_key
  replace_rule1 \$ [dollar]
</filter>

# Mongodb keys should not have dollar or a dot inside
<filter kubernetes.**>
  @type rename_key
  replace_rule1 \. [dot]
</filter>

# Outputs to log db
<match kubernetes.**>
  @type mongo

  connection_string "#{ENV['MONGO_ANALYTICS_DB_HOST']}"
  collection logs

  <buffer>
    flush_thread_count 8
    flush_interval 1s
  </buffer>
</match>

Your Error Log
Not sure how you mean all - we have a ton of logs, most of them lost. The best logs I could find were noted in the 'Describe the bug' part, you can ask for some specifics if needed.
Additional context
Running docker image fluent/fluentd:v1.13-1 in k8s 1.21 on Digital Ocean as a daemon set.

Ping, any advice on this one? It happens unexpectedly from time to time and is very very painful, it takes a lot of our logs and messes up our analytics...

It seems same issue with #3661 or #3614 or #3586, let's continue to discuss at there.


add support for cgo-openssl

Issues associated with this PR
more information see issue #1034
UT result
all unit test have been passed
Code Style
golint shows that all cgo_* file is clean
More Information
commit1 : add alpn and cert chain verify test case
commit2: core implementation if cgo with openssl
commit3: need not code review, just openssl head file and static library
commit4: need not code review, just open CGO_ENABLED tag

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f6a1b4d). Click here to learn what that means.
The diff coverage is 10.48%.

@@            Coverage Diff            @@
##             master    #1041   +/-   ##
=========================================
  Coverage          ?   46.82%
=========================================
  Files             ?      252
  Lines             ?    24050
  Branches          ?        0
=========================================
  Hits              ?    11262
  Misses            ?    11804
  Partials          ?      984

Impacted Files
Coverage Δ

pkg/mtls/crypto/tls/transfer_tls.go
0% <ø> (ø)

pkg/mtls/crypto/tls/cipher_suites.go
11.42% <ø> (ø)

pkg/mtls/crypto/tls/common.go
49.32% <ø> (ø)

pkg/mtls/crypto/tls/tls.go
19.76% <ø> (ø)

pkg/mtls/crypto/tls/cgo_err.go
0% <0%> (ø)

pkg/mtls/crypto/tls/cgo_ciphersuites.go
0% <0%> (ø)

pkg/mtls/crypto/tls/cgo_prehanashakecb.go
0% <0%> (ø)

pkg/mtls/crypto/tls/cgo_alpn.go
0% <0%> (ø)

pkg/mtls/crypto/tls/cgo_certificate.go
0% <0%> (ø)

pkg/mtls/crypto/tls/cgo_ssl.go
17.8% <17.8%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a1b4d...84252e1. Read the comment docs.


Dynamic File Name

I am using the library with angularjs
For Example I have below query:
alasql('SELECT * INTO XLSX("john.xlsx",{headers:true}) FROM ?',[$scope.items]);
I want to read the file-name from the scope, and not any hard coded name("john.xlsx").
I tried to search how this can be achieved but no luck.

how about this:
var my_filename = ""john.xlsx"";
var my_query = 'SELECT * INTO XLSX(' + my_filename + ',{headers:true}) FROM
?',[scope.items]);
(also be careful w/sql injection).
On Wed, Feb 11, 2015 at 4:01 PM, charul2007<EMAIL_ADDRESS>wrote:

I am using the library with angularjs
For Example I have below query:
alasql('SELECT * INTO XLSX("john.xlsx",{headers:true}) FROM
?',[$scope.items]);
I want to read the file-name from the scope, and not any hard coded
name("john.xlsx").
I tried to search how this can be achieved but no luck.
—
Reply to this email directly or view it on GitHub
https://github.com/agershun/alasql/issues/59.

simpler:
var my_filename = 'john.xlsx';
alasql('SELECT * INTO XLSX("' + my_filename + '",{headers:true}) FROM
?',[scope.items]);
On Wed, Feb 11, 2015 at 6:43 PM, Mark Rostron<EMAIL_ADDRESS>wrote:

how about this:
var my_filename = ""john.xlsx"";
var my_query = 'SELECT * INTO XLSX(' + my_filename + ',{headers:true})
FROM ?',[scope.items]);
(also be careful w/sql injection).
On Wed, Feb 11, 2015 at 4:01 PM, charul2007<EMAIL_ADDRESS>wrote:

I am using the library with angularjs
For Example I have below query:
alasql('SELECT * INTO XLSX("john.xlsx",{headers:true}) FROM
?',[$scope.items]);
I want to read the file-name from the scope, and not any hard coded
name("john.xlsx").
I tried to search how this can be achieved but no luck.
—
Reply to this email directly or view it on GitHub
https://github.com/agershun/alasql/issues/59.

Thank you so much for the answer. I have one more question should I ask here or open a question.

either way works .... pls let's know
On Thu, Feb 12, 2015 at 12:06 PM, charul2007<EMAIL_ADDRESS>wrote:

Thank you so much for the answer. I have one more question should I ask
here or open a question.
—
Reply to this email directly or view it on GitHub
https://github.com/agershun/alasql/issues/59#issuecomment-74120530.

I want to export multiple table into single excel file. Please find the below image:

I have created objects as below:
var allFiles = {
path: "app folder  > app  > js > All Files"
}
var fileDetails = {
FileName: "app.js",
FileSize: "10kb",
FileType: "js"
}
Then I concated the above two objects because I want two different tales:
var allData = allFiles.concat(fileDetails);
Now when I am trying to export it exports only the first Object:
alasql('SELECT * INTO XLSX("details.xlsx",{headers:true}) FROM ?', [allData]);
Also for the "allFiles" object I want to only display the "value" and not the "key" as shown in the Image.
Any help is much appreciated. Thank you in advance.

Current version of XLSX export function does not support colors (this is because [xlsx.js library](https://github.com/SheetJS/js-xlsx, unfortunately, still does not support colors)).

I have some plans to add new INTO-function with coloring (I will add the issue to the development plan)

I slightly modified your code, it exports two or more lines (see http://jsfiddle.net/p2yfqdub/5/).
Could you add more details to your question?

Now AlaSQL can save files to Excel and LibreOffice formats with colors and other
Excel formatting functions. This function also work in IE9. This is a code sample:
    var mystyle = {
      headers:true,
      column: {style:{Font:{Bold:"1"}}},
      rows: {1:{style:{Font:{Color:"#FF0077"}}}},
      cells: {1:{1:{
        style: {Font:{Color:"#00FFFF"}}
      }}}
    };
    alasql('SELECT * INTO XLSXML("restest280b.xls",?) FROM ?',[mystyle,data]);

See the working example in jsFiddle

Hi, I am using this method to create xlsx but I am not able to open the generated sheet in excel. Is there new js for this?

It shuld be ok.
What data are you putting in and what is excel telling you?

It says not able to open the file because the file format of the file extension is not valid

Can you provide an example?

cf.cancelstyle = {
headers: true,
column: { style: { Font: { Bold: "1" } } },
columns: [{ columnid: 'hid', title: 'Hedge Refrence ID', width: 100 },
{ columnid: '', title: 'Comments', width: 100 },
]};
alasql('SELECT hid as [Hedge Refrence ID], Comments INTO XLSX("test.xlsx",?) FROM ?', [cf.cancelstyle, cf.chkselect]);

cf.cancelstyle = {
headers: true,
column: { style: { Font: { Bold: "1" } } },
columns: [{ columnid: 'hid', title: 'Hedge Refrence ID', width: 100 },
{ columnid: '', title: 'Comments', width: 100 },
]};
alasql('SELECT hid as [Hedge Refrence ID], Comments INTO XLSXML("test.xlsx",?) FROM ?', [cf.cancelstyle, cf.chkselect]);

Can you also provide an example for the content in cf.chkselect ?

I want to export table into excel file with images is it possible through alasql

Sounds like a crazy plan.
Have a look at https://github.com/SheetJS/js-xlsx


Source params reordering with docs and samples updates

Changes

🎁 Source's Spec RabbitMQ related parameters have been grouped in the RabbitMQResourcesConfig Spec
🎁 Source's Spec Delivery related parameters have been grouped in the Delivery Spec
🎁 Added support for ClusterReference ConnectionSecret option to the Source
🧹 Updating Source's docs and samples to reflect this changes

/kind api-change documentation

Fixes #

Release Note

- BREAKING: 🎁 Source's Spec RabbitMQ related parameters have been grouped in the RabbitMQResourcesConfig Spec, Source's Spec Delivery related parameters have been grouped in the Delivery Spec
- 🎁 Added support for ClusterReference ConnectionSecret option to the Source

/hold

/hold cancel

another nit regarding the release notes: We can just have a single line or a few lines regarding the Source API changing. With a BREAKING: prefix. With the release notes in the last few PRs, they highlight individual things the PRs are doing and that's too detailed for release notes.

/hold cancel


Feat/revamp adapters

Add revamped adapters.

Please  @parth-15 move deployment scripts to src/script folder


Some DNS seeders and block explorers don't show Zebra nodes

Motivation
In #1844, we deployed a few zcashd instances on testnet, to make Zebra's testnet tests more reliable. But those nodes aren't showing up in the ECC's or the Foundation's DNS seeders.
As far as we can tell, the nodes are configured correctly, they are synced to tip, their listener ports are open, and they are advertising their external IPv4 addresses. But they don't show up in the DNS of either seeder implementation.
Also, Zebra nodes don't show up in some other DNS seeders or blockchain explorers.
Known Zebra Issues
zcashd seems to ignore peers from zebrad:
https://github.com/zcash/zcash/issues/3881#issuecomment-1140146874
Other Protocol Mismatches:

[ ] version.addr_from is typically dummy bytes, but Zebra sends the actual details: https://en.bitcoin.it/wiki/Protocol_documentation#version

List of Block Explorers
Some block explorers show up to 250 nodes.
There are about 150-200 nodes on mainnet that Zebra instances will connect to.
(Recent Zebra versions are limited to 75 outbound and 50 inbound connections, but this is configurable.)
Zebra might connect to fewer nodes because it has strict latency limits.
Zebra Nodes
This block explorer shows about 65 nodes, but it includes Zebra:

https://explorer.zecmate.com/network

No Zebra Nodes
This block explorer shows about 250 nodes:

https://blockchair.com/zcash/nodes (click "Load More" to see all user agents)

These block explorers show connected nodes only:

https://zcashblockexplorer.com/nodes

Currently down:

https://explorer.testnet.z.cash/

Completed
Make Zebra have long-term connections to peers:

#3120

DNS seeder bugs:

[x] work out why some DNS seeders return peers with outdated network protocol versions

this is a bug in the Foundation's DNS seeder: https://github.com/ZcashFoundation/dnsseeder/issues/10

Metrics:

[x] #2871

Optional
We could investigate why DNS seeders ignore zebrad nodes:

Infrastructure:

[ ] try running zcashd on a different network, to see if Google is blocking cryptocurrency traffic
[ ] try to run a Zebra node with the initial testnet addresses set to some of those zcashd nodes, to make sure they respond to requests correctly

Code Review:

[ ] check the zcashd version of our nodes, and the versions accepted by the DNS seeders

This is the list of conditions enforced by zcash-seeder on peers in order for their IPs to be given out:

The peer's port must be 8233 on mainnet or 18233 on testnet (DNS only gives out IPs, so the port needs to be predictable).
The NODE_NETWORK service bit must be set.
The peer's IP must be routable.
The peer's client version must be at least REQUIRE_VERSION (currently 170015 in the repo, 170014 on my own seeder).
The peer's block height must be at least 0 (we could bump this to require peers to be closer to the tip, but don't currently do so).
The peer must be reliably reachable (this is implemented by tracking the success or failure of each connection attempt, with an exponential decay of each attempt's weight).

However, before we get to the above checks, the seeder needs to be able to connect to the peer and perform a very minimal handshake and protocol query:

version / verack
getaddr / addr

#2380 might help us diagnose this one

I spoke to someone who runs a Zebra mainnet node with high uptime.
It looks like their setup should work on DNS seeders and block explorers.
According to the rules posted above: https://github.com/ZcashFoundation/zebra/issues/1904#issuecomment-938212260
So it seems likely that Zebra is implementing some undocumented part of the network protocol differently.
And that's enough to get it rejected from seeders and block explorers.
We might have to do low-level network diagnostics, or look at the detailed logs from a DNS seeder.

Zecmate is showing Zebra nodes: https://explorer.zecmate.com/network

Updated Blockchair/Blockchair.Support#527 to reference zebra nodes seen in zecmate

This is blocked by an investigation of how block explorers handle the Zcash network protocol.

In https://github.com/zcash/zcash/issues/3881#issuecomment-1140146874 , we found out that zcashd seems to ignore peers from zebrad.
We should try to find out why.

In https://github.com/zcash/zcash/issues/3881#issuecomment-1140146874 , we found out that zcashd seems to ignore peers from zebrad.

To clarify, this was not from zebrad, this was from https://github.com/superbaud/zcash-cotyledon/blob/main/src/main.rs; which only answers Peers requests.
@str4d said here that

zcashd does not anticipate the existence of network peers that only respond to getaddr messages, because that is not how the seeders interact with the network. If such a peer type were desired, it would need a corresponding service bit (to indicate to peers that it does not serve as a regular peer).

so I don't think this necessarily reflects a problem with zebrad.

https://github.com/eqlabs/ziggurat/blob/main/src/tests/conformance/peering.rs#L20-L48 might also be related/helpful

In zcash/zcash#3881 (comment) , we found out that zcashd seems to ignore peers from zebrad.

To clarify, this was not from zebrad, this was from https://github.com/superbaud/zcash-cotyledon/blob/main/src/main.rs; which only answers Peers requests.

It's still using a zebra-network stack, which is one possible cause of the DNS seeder issues.
Thanks for letting us know that zebrad's Peers requests work for zcashd.

This seems to be fixed for now, if we find issues with a specific block explorer or seeder, we can open another ticket with those details.


Move to electron-builder

Would you like to move it to electron-builder repo, under directory examples?

But... separate repo is better because in this case it can be easily cloned.

@iffy I suggest to transfer repo to electron-userland org, so, it will be easily discoverable and under the same org for consistency and "official" status.
@stefanjudis please allow  transfer request when will be requested (I am member of org and not owner and have to ask you). @malept please do not block as always ;)

I'm not going to block it as long as it's clear that there's a maintainer for the repo. The Electron Userland org is not meant to be a dumping ground for related repositories.

@develar would you be maintaining it?  I'm happy to have you maintain it and happy to have it live in the userland org.

@iffy it will be part of docs and, so, somehow maintained.

@develar k, here it comes! :)

@develar I don't have permission to send it, so do you need to request it?

@stefanjudis I cannot invite @iffy to electron-builder org as a member, because I am not owner. Could you please invite?

You mean electron-userland org?

@stefanjudis Yes, I mean electron-userland.

by the way can we ask for proper rights for you at some point?

Yeah... I am the only member who doesn't have owner rights :)

Haha, ja let's try to change that. :D
@malept would it be alright, when I'd give @develar owner rights?
I mean, I'm not actively developing electron-builder anymore (and have owner rights) and @develar does an amazing job with the project. The flow right now is, that he always has to ask me to add/configure/... something, which is not really comfortable for us.
What do you think of that?

@malept Friendly ping :)

I'll write a reply this weekend.

@develar btw, I'm fine if you want to create a new repo electron-userland/electron-updater-example that's not a GitHub copy of this repo, but just a git copy (i.e. clone this repo, create electron-userland/electron-updater-example, push).

@stefanjudis I think you can give owner rights. In any case right now I can push to any repo. If someone will be against — team can be created to restrict my access level. Since all members currently are owners — I don't see any security risks or policy violation.

@develar Sorry about not writing the response this weekend, I was busy.
I have been hesitant to give admin rights for a couple of reasons:

Adding org-level permissions to services - in the case of the most recent ask, I have no idea what the implications of adding OpenCollective is, what permissions they're looking for, or what they can access. I looked for a couple minutes on their website and didn't find anything. I would expect that an ask for this includes exactly what data it's trying to read/use.
Lately, I've been wondering what the point of having electron-builder be in the electron-userland org is these days. Just yesterday I was helping someone out and they were confused that electron-builder does not use Electron Packager at all, and that "the same people" were not working on it. I just took a look at builder's package.json and there are currently zero Electron tool dependencies that come from upstream - they are all forked. This is obviously your right to do so - this is open source, after all - but if you're asking to have elevated permissions in the org, I feel like you should figure out how to work with the community to unfork, or at least provide a list of differences between upstream and your fork so users can make informed decisions about the tools that they use and their dependencies.

@malept The only useful electron tools for electron-builder are electron-osx-sign and electron-download. And tools are used (and I am contributing to both projects, e.g. https://github.com/electron-userland/electron-download/pull/40 and see my name in the https://github.com/electron-userland/electron-osx-sign#collaborators). Other modules (except electron-packager) are not related to build electron app. So, I don't understand your question.
Also, Electron Userland is not only for you and electron-packager — this org for "Third party community maintained electron modules". And electron-builder currently has 70 contributors vs 50 (electron-packager). So, you cannot blame me that electron-builder maintained only by me.

Adding org-level permissions to services

As far I see it was clear in the request (read-only access was requested to usernames).

@develar I never said anything about number of contributors. Nor did I say that the org is only for Electron Packager. Please do not put words in my mouth.
You might be sometimes contributing to upstream, but the pattern that I and several other Electron community members have been seeing is the following:

You contribute a PR to a module. Sometimes it gets merged, sometimes it doesn't.

In some cases, you decide to completely rewrite the feature for electron-builder and drop the forked module.

As I've stated earlier, this is absolutely fine from a technical perspective, because this is open source. However, from a community perspective, it causes animosity. It would make me and other contributors more comfortable if you explained why you're using forks and/or deciding that community modules aren't the right fit for builder.

why you're using forks and/or deciding that community modules aren't the right fit for builder.

that community modules aren't the right fit for builder.

The only not used tool is electron-packager. Not "modules", but "module". And is not used because electron-builder version has a lot of features. Implementing it as part of electron-packager will be not easy because it will be total rewrite. It will took a lot of time to argue you to use promise/babel or typescript. Wasting time. Since in any case I don't need to fix something, but implement it from a scratch, it was much more easy just implement it as part of electron-builder. Because it doesn't matter for end user. User just want to build electron app.

I care less about Packager and more about the forks of asar, electron-osx-sign, and electron-download. This is not about ego, this is about maintaining a healthy community ecosystem.
Is this really just about the code architecture of all of these modules?

You might be sometimes contributing to upstream, but the pattern that I and several other Electron community members have been seeing is the following:

To be honest, this resonates with me quite strongly as the Squirrel.Windows maintainer. Thanks for writing this up @malept and I appreciate your professionalism in this Hard Conversation

electron-osx-sign

https://github.com/electron-userland/electron-osx-sign/issues/125#issuecomment-273500629
All changes were merged currently (except one internal option specially for electron-builder). I often contribute to electron-osx-sign and is not easy to change module id. Also, I need to test my PR on beta users (next tag) and CI servers.

asar

Nothing changed except removing deprecated dependency (https://github.com/electron/asar/pull/61). Again — sometimes I need to change something urgently and is not easy to change module id — e.g. https://github.com/electron/asar/issues/78.

electron-download

was forked as result of https://github.com/electron-userland/electron-download/pull/40 Again — don't want to change module id since I soon will send PR to download temp files to a cache directory instead of temp.
As of electron-winstaller — @paulcbetts is aware why (PR was rejected and discussed) and also aware that all common fixes were merged into Squirrel.Windows https://github.com/Squirrel/Squirrel.Windows/pulls?utf8=✓&q=is%3Apr is%3Aclosed author%3Adevelar

@paulcbetts I am not aware of any bugs that was caused due to my fork. If you mean semver issue — it was not a bug in my fork, it is was result of rcedit call (file version, not in the Squirrel.Windows code).

Later, after a back-and-forth, they finally casually mention, "Oh, I'm using electron-builder". If the fork wasn't there, we would be working together on fixing bugs instead of doing 2x the work.

All bugs, as far I know, in the runtime. And runtime is the same. if you have examples — please provide.

@malept Ping.

@stefanjudis Could you please just add @iffy as a member to electron-userland org?

@develar I have a proposal:
The electron-userland org was never meant as a dumping ground for Electron-related projects. Originally it was just a bunch of self-contained tools/modules for Electron projects maintained by a couple of people. Now it's gotten to be a bit more than that. Electron Forge is moving out of the electron-userland org and into its own, partly because there's too much resource contention, particularly with Travis CI workers. (Each open source org/user gets 5 (or less depending on availability) workers in parallel.) This is particularly problematic when there are multiple Electron Packager PRs being worked on. (I'm trying to speed up the tests but this is offtopic.) Additionally, there are currently three repositories for Forge and a fourth on the way, so it makes a whole lot more sense. This also allows us to split up our -templates monorepo so we can better release and manage issues.
This is a long-winded way to say that my suggestion is to create an electron-builder org and move the repos there.

@malept Thanks for info. BTW, we have managed to run all electron-builder tests in 8 minutes using CircleCI (run across all 4 workers, Travis runs only macOS tests (10 minutes)).

Then let's do this? @develar

Then let's do this

Move to electron-builder org? I don't like it and prefer to stay in the electorn-userland org.

electron-builder uses monorepo, as babel, packages will be not converted to repositories.
electron-updater is not tight to electron-builder and can be used standalone.
Org description "Third party community maintained electron modules" doesn't contradicts to current situation.

electron-osx-sign is also part of electron-buider (and in the same time part of any other build tool for electron). Don't like the idea to create org per tool.

@develar I'd like to reiterate what @malept said I definitely feel it's better for everyone to separate concerns.  The -builder and -forge ecosystems have both outgrown the CI limits imposed on -userland, regardless of how fast everyone's CI runs it is normally in the range of 10+ minutes on each agent, with the limits imposed on us this means that if everyone wants the agents you can be waiting hours or sometimes even till the next day for builds (depending on branches / third party PR's and everything).  This is especially bad on the macOS travis queue.
The best move for everyone is to make -userland a collection of smaller projects once again (prebuilt, download, spellchecker, remote, etc.) and it should remain the original home of -packager (let's be real everything was built around it).  And to move -forge to it's own organization and -builder to it's own organization as well.
This will show separation of concerns, stop -userland being a dumping ground for everything.  Remove the need for mono-repoing on both fronts (forge and builder) and allow us all to make our own administrative decisions regarding what should and shouldn't be in or enabled for our given organization.
At the moment we are each trying to act as an independent group inside the -userland group and I think that's a strong indicator that we both have to take our concerns to our own org where we each have control.  E.g. You work on the -builder things and we work on -packager/-forge/-download/-prebuilt things.
As a further point although the description of the org "third party community maintained modules" still fits -builder and everything else in this org it doesn't mean all third party maintained modules should live here.
The main points here are separation of concerns, CI agent consumption and ensuring that -userland doesn't become a "dumping ground".
I hope this makes sense :D

the CI limits imposed on -userland

I don't think that this Travis limitation should be the main reason to create org per tool :) Maybe you can contact CircleCi to run macOS tests.

Remove the need for mono-repoing on both fronts

I like monorepo and not going to split electron-builder to repo-hell. I don't like idea to create org for 2 repositories (electron-updater can be used standalone).

E.g. You work on the -builder things and we work on -packager/-forge/-download/-prebuilt things.

I contribute not only to electron-builder, https://github.com/electron-userland/electron-download/pull/47

doesn't become a "dumping ground".

Yes, if you are not going to use monorepo for -forge, it makes sense to create separate org. But if electron-builder in any case uses monorepo and electron-updater can be used standalone — no need to move it to a separate org. Also, electron-builder in any case related to forge and can build forge projects or electron-builder targets can be reused in the electron-forge (not yet released). We are all build tools for electron and current repo is not a "dumping ground" (we discuss moving this simple and related repo 45 days :)).

I don't think that this Travis limitation should be the main reason to create org per tool :)

It would be exactly the same problem with AppVeyor, except you already use a different account there. There's clearly already precedent for electron-builder to have its own separate account.
My point is that you currently have two repos in userland (one of which is a git repo full of binaries...) and you want to add a third - that's a good point to start considering moving the project to its own org.
I don't actually care if you want to keep a monorepo for -builder, it was just a suggestion.

you want to add a third - that's a good point to start considering moving the project to its own org

electron-updater can be used standalone (the same about electron-publish / electron-publisher-s3). That's the point why I don't want to move to a separate org. Will be no packages designed only for electron-builder — in this case it will be in the electron-builder repo.

As long as electron-updater is in the same repo as electron-builder, people will assume that it requires -builder to run, no matter how many times you assert otherwise.

@develar @malept @paulcbetts @MarshallOfSound
Hello everybody, I know this is a tough discussion here, but I really would love to find a solution for my own problem which is related to the discussion.
I started electron-builder initially and I was part of moving it into electron-userland. That's the reason why I have admin rights. I'm not active part of any development in one of the repos under electron-userland and don't plan to be in near future.
The situation is that every time @develar wants to change/add something, it proxies through me. Usually I'm not aware of changes or impact of the given request. I don't want to do this anymore. I think it makes sense to revoke my rights for that reason, now.
Right now we're stuck on

I have been hesitant to give admin rights  (to @develar) for a couple of reasons:

and the discussion around moving electron-builder out of the org.
Maybe it makes sense to move the discussion to a hangout or anything?

@malept you didn't answer to my answers to your "for a couple of reasons", probably it was some kind of answer :) actually, I don't need admin rights — you can just allow access for requested app (https://github.com/electron-userland/electron-builder/issues/1433#issuecomment-291829988). For record, it is the second request for past year and I don't see that we need different org to be able to have another set of allowed apps (read public data only).


AWS Batch create-compute-environment fails with Could not find IAM role in moto_server

Environment
Moto version: 5.0.3
Executable: moto_server -p3000
Env vars:
export AWS_SECRET_ACCESS_KEY='testing'
export AWS_SECURITY_TOKEN='testing'
export AWS_SESSION_TOKEN='testing'
export AWS_DEFAULT_REGION='us-east-1'
export MOTO_IAM_LOAD_MANAGED_POLICIES=true

Issue:
When I try to create a compute environment with the AWS CLI for the batch service I get an error of the form:
aws --endpoint-url=http://localhost:3000 batch create-compute-environment --compute-environment-name test --type UNMANAGED

An error occurred (InvalidParameterValue) when calling the CreateComputeEnvironment operation: Could not find IAM role None

If I instead try to set the --service-role arg to AWSBatchServiceRole or even a fully qualified arn:... string from the managed policies does not seem to work either:
aws --endpoint-url=http://localhost:3000 batch create-compute-environment --compute-environment-name test --type UNMANAGED --service-role=AWSBatchServiceRole

An error occurred (InvalidParameterValue) when calling the CreateComputeEnvironment operation: Could not find IAM role None

I think the issue is that for some reason the standalone server mode is not correctly loading the managed / default policies even when this environment variable is set but I am not sure. I have also tried POSTing updates to the config endpoint (/moto-api/config) to set “iam”: {“load_aws_managed_policies”: True} but that did not seems to help either.
Perhaps I am missing something obvious, but any help would be much appreciated!

Hi @msumner91 👋
moto does not create any IAM roles by default, but it will create IAM policies if MOTO_IAM_LOAD_MANAGED_POLICIES=true. I cannot reproduce your subsequent error for
aws --endpoint-url=http://localhost:3000 batch create-compute-environment --compute-environment-name test --type UNMANAGED --service-role=AWSBatchServiceRole

On a vanilla ubuntu 22.04, python 3.10.12, moto 5.0.3 that call results in an expected error:
An error occurred (InvalidParameterValue) when calling the CreateComputeEnvironment operation: Could not find IAM role AWSBatchServiceRole

To get moving, you will have to create a dummy IAM role and reference its ARN when calling create-compute-environment:
$ aws iam create-role --role-name batchRole --assume-role-policy-document "foo" --endpoint-url=http://localhost:3000
<IP_ADDRESS> - - [21/Mar/2024 16:46:33] "POST / HTTP/1.1" 200 -
{
    "Role": {
        "Path": "/",
        "RoleName": "batchRole",
        "RoleId": "AROARZPUZDIKKONVWVZL7",
        "Arn": "arn:aws:iam::123456789012:role/batchRole",
        "CreateDate": "2024-03-21T15:46:33.558000+00:00",
        "AssumeRolePolicyDocument": "foo",
        "MaxSessionDuration": 3600,
        "RoleLastUsed": {}
    }
}
$ aws --endpoint-url=http://localhost:3000 batch create-compute-environment --compute-environment-name test --type UNMANAGED --service-role='arn:aws:iam::123456789012:role/batchRole'
<IP_ADDRESS> - - [21/Mar/2024 16:47:13] "POST /v1/createcomputeenvironment HTTP/1.1" 200 -
{
    "computeEnvironmentName": "test",
    "computeEnvironmentArn": "arn:aws:batch:us-east-1:123456789012:compute-environment/test"
}

On moto side, it should validate presence of service-role parameter, as real AWS would throw error:
$ aws batch create-compute-environment --compute-environment-name test --type UNMANAGED
An error occurred (ClientException) when calling the CreateComputeEnvironment operation: Error executing request, Exception : ServiceRole is required., RequestId: b09833bb-68e1-4ad1-aa44-257acab447aa

I will create a PR for that validation.

@bblommers I added a PR


Do some load testing

We got some load testing for free as part of people trying to use the tool! We did discover an issue with SQLite connections not being closed properly (see https://til.alexwlchan.net/sqlite3-context-manager-doesnt-close-connections/) but I fixed that and it's held up fine since, so I'm going to close this as done.


Allow interacted field of matStep in the stepper control to be editable via property binding

Please describe the feature you would like to request.
The interacted field of the matStep (https://material.angular.io/components/stepper/api) is currently not decorated with @Input() therefore it is not possible to use property binding to modify it.
What is the use-case or motivation for this proposal?
Calling the Stepper Previous() or Next() method ends up calling "CdkStepper.prototype._anyControlsInvalidOrPending" where there is a check for "!step.interacted". I have a use case where I populate the steps and then set a particular step as the selected step.  At that point when I call next or previous since the steps interacted field is false by default I'm not able to go backward or forward through the stepper.
At the moment my only way to solve this issue is to iterate the stepper's "_steps" and set the "interacted" field to true.  This is not an ideal solution.
Is there anything else we should know?
Version: 7.2.0

This is potentially a solution for #14067

Any update on this?


Drop cmap format 4 subtable if length > 65535

Use format 12 instead and build a dummy one.
I have such a font (temporary otd created by otfcc-ttcize).
cmap4-too-long.otd.xz.zip

Make sure that for most cases, CMAP format 4 and 12 is generated properly. Various platform requires a CMAP format 4 subtable to be present, even if they are incomplete.

ps. I've added you as Collaborator so you can merge at your own.


Update README.md

Small typo :) but thanks for this module ! can open new idea on my side... 👍

thanks @julienanquetil :)


Exposes cache

Is this pull request associated with an issue(s)?
No
Description
While a cache prototype has been available for awhile, there has been no way for users to actually set it. This PR fixes that.
TODOs
None. R2g.

🚀 [bumpr] Bumped! New version:v1.0.37 Changes:v1.0.36...v1.0.37


what combine script must do

add ids
already move things to root
drop Refs

It seems like there should be a simple fix for getting a single schema file working on jsonschema.net (if so, I would also not have to extract a subschema in my code as I do now; I expect the same to be true for other languages).
Then the entire need for splitting files is gone and I would not need an extra step in my code that extracts a subschema (which I should have recognized earlier).
Here is an example of four sub schemas in a single file https://json.schemastore.org/jsbeautifyrc.json; I think we would need an oneOf at the top level instead of allOf.
Note all schemas are in a single file in all of the examples at https://json.schemastore.org/ and jsonschema.net, even the complex ones with references.

I guess if it works in jsonschema.net then it would probably work in editors like Visual Studio Code.  That said I would rather have separate schemas anyway.  The schema is the "type of" declaration, and to declare a response is a "info" is more precise than saying it is "something a HAPI server responds with".

Closing b/c should be a part of issue #3, not new issue.