[Bug][AMS]: The optimize task property doesn't persist in MySQL after set 'max-execute-time'

What happened?
The optimize task property adds the key named 'max-execute-time' that doesn't persist in MySQL.
So if the AMS restarts,  the task will lose the property 'max-execute-time' value
Affects Versions
0.3.0
What engines are you seeing the problem on?
AMS
How to reproduce

create an arctic table
write the data into the table, and confirm optimizing task execution time over 30min
set the self-optimizing.execute.timeout as 3600000
restart the AMS when the optimizer executes the task
the task will always be failed because the execution expired

Relevant log output
No response
Anything else
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@hzluting Can you add more information about the impact of the bug, like what will happen if the task lost it's max-execute-time property.

We assume that we set the self-optimizing.execute.timeout value as 3600000(1 hour)
If the task lost the max-execute-time property, the AMS will use the default execution timeout(30 min) to check the task whether execution timeout.
This will cause the user's configuration can't be effective and the task can't be finished once it needs over 30 min.

Closed as not updated for a long time.


Wrong MD5 hash for SQS Message Attributes.

The issue is described in

localstack https://github.com/localstack/localstack/issues/2976
moto pull request https://github.com/spulec/moto/pull/3346#pullrequestreview-501657555

I've fixed this issue according to aws documentation https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-message-metadata.html#sqs-message-attributes
But I do not have rights to push new branch  to moto repo. Could anybody help me with that please?

@bblommers May be you could help me with that?

Hi @artemtere, if you fork Moto and create a branch in your own repository, you can create a PR to merge your (remote) branch into Moto's master.

This is now fixed as part of moto >= 1.3.16.dev76. Thanks for providing the PR @artemtere!


Release v1.19.5+suite.1

Release Notes
All notable changes to this project will be documented in this file.
[1.19.5+suite.1] - 2023-06-28
Table of Contents

Components
Installation Instructions for the Suite Release Version of Conjur
Upgrade Instructions
Changes

Components
These are the components that combine to create this Conjur OSS Suite release and links
to their releases:
Conjur Server

cyberark/conjur v1.19.5 (2023-06-29)
cyberark/conjur-openapi-spec v5.3.0 (2021-12-22)
cyberark/conjur-oss-helm-chart v2.0.6 (2023-03-09)

Conjur SDK

cyberark/conjur-cli-go v8.0.10 (2023-06-29)
cyberark/conjur-api-dotnet v2.1.1 (2022-03-14)
cyberark/conjur-api-go v0.11.1 ()
cyberark/conjur-api-java v3.0.5 (2023-06-08)
cyberark/conjur-api-python v0.1.0 (2023-02-14)
cyberark/conjur-api-ruby v5.4.1 (2023-06-14)

Platform Integrations

cyberark/cloudfoundry-conjur-buildpack v2.2.8 (2023-06-21)
cyberark/conjur-service-broker v1.2.10 (2023-06-21)
cyberark/conjur-authn-k8s-client v0.25.1 (2023-06-12)
cyberark/secrets-provider-for-k8s v1.5.1 (2023-05-26)

DevOps Tools

cyberark/ansible-conjur-collection v1.2.0 (2020-09-01)
cyberark/ansible-conjur-host-identity v0.3.2 (2020-12-29)
cyberark/conjur-puppet v3.1.0 (2020-10-08)
cyberark/terraform-provider-conjur v0.6.6 (2023-06-21)

Secretless Broker

cyberark/secretless-broker v1.7.17 (2023-04-17)

Summon

cyberark/summon v0.9.6 (2023-06-14)
cyberark/summon-conjur v0.7.1 (2023-06-14)

Installation Instructions for the Suite Release Version of Conjur
Installing the Suite Release Version of Conjur requires setting the container image tag. Below are more specific instructions depending on environment.

Docker or docker-compose
Set the container image tag to cyberark/conjur:1.19.5.
For example, make the following update to the conjur service in the quickstart docker-compose.yml
image: cyberark/conjur:1.19.5

Conjur Open Source Helm chart
Update the image.tag value and use the appropriate release of the helm chart:
helm install ... \
  --set image.tag="1.19.5" \
  ...
  https://github.com/cyberark/conjur-oss-helm-chart/releases/download/v2.0.6/conjur-oss-2.0.6.tgz

Upgrade Instructions
Upgrade instructions are available for the following components:

cyberark/conjur
cyberark/conjur-oss-helm-chart

Changes
The following are changes to the constituent components since the last Conjur
OSS Suite release:

cyberark/conjur
cyberark/conjur-cli-go
cyberark/conjur-api-java
cyberark/conjur-api-ruby
cyberark/cloudfoundry-conjur-buildpack
cyberark/conjur-service-broker
cyberark/conjur-authn-k8s-client
cyberark/secrets-provider-for-k8s
cyberark/terraform-provider-conjur
cyberark/summon
cyberark/summon-conjur

cyberark/conjur
v1.19.5 (2023-06-29)

Changed

OIDC tokens will now have a default ttl of 60 mins
cyberark/conjur#2800

Fixed

AuthnJWT now supports claims that include hyphens and inline namespaces.
cyberark/conjur#2792
Authn-IAM now uses the host in the signed headers to determine which STS endpoint
(global or regional) to use for validation.

Security

Update bundler to 2.2.33 to remove CVE-2021-43809
cyberark/conjur#2804

cyberark/conjur-cli-go
v8.0.10 (2023-06-29)

Fixed

Fixed missing example commands in help output
cyberark/conjur-cli-go#134

Security

Upgrade golang.org/x/net to v0.10.0
cyberark/conjur-cli-go#139
Upgrade golang.org/x/net to v0.10.0, golang.org/x/crypto to v0.9.0,
golang.org/x/sys to v0.8.0, golang.org/x/text to v0.9.0, and Go to 1.20
cyberark/conjur-cli-go#138

cyberark/conjur-api-java
v3.0.5 (2023-06-08)

Changed

Migrate JAX-RS to latest Jakarta version
cyberark/conjur-api-java#119
Avoid calling login for host
cyberark/conjur-api-java#117

Fixed

Fix dependency information stripped from non-shaded jar
cyberark/conjur-api-java#119

Security

Update nginx to 1.24 in Dockerfile.nginx
cyberark/conjur-api-java#118

cyberark/conjur-api-ruby
v5.4.1 (2023-06-14)

Added

Added authenticate wrapper to access unparsed response object (including headers).
cyberark/conjur-api-ruby#213
Support Ruby v3.1 and v3.2.
cyberark/conjur-api-ruby#220

cyberark/cloudfoundry-conjur-buildpack
v2.2.8 (2023-06-21)

Security

Upgrade golang.org/x/net to v0.10.0, golang.org/x/text to v0.9.0, golang.org/x/sys to v0.8.0, rack to 3.0.1,
spring-boot to 3.0.6, and java to 17
cyberark/cloudfoundry-conjur-buildpack#172
Update ruby in ci/parse-changelog.sh from 2.5 to 3.1
cyberark/cloudfoundry-conjur-buildpack#170

cyberark/conjur-service-broker
v1.2.10 (2023-06-21)

Security

Upgrade ruby to 3.2, Go image to 1.20-alpine, and golang.org/x/sys to v0.8.0
cyberark/conjur-service-broker#331
Update nokogiri to 1.14.3 to address https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-pxvg-2qj5-37jq
cyberark/conjur-service-broker#326

cyberark/conjur-authn-k8s-client
v0.25.1 (2023-06-12)

Security

Upgrade Dockerfile base images to golang:1.20 and golang.org/x/sys dependency to 0.8.0
cyberark/conjur-authn-k8s-client#516
Update ruby fom 2.5 to 3.1 in bin/parse-changelog.sh
cyberark/conjur-authn-k8s-client#514
Upgrade container security settings
cyberark/conjur-authn-k8s-client#518

cyberark/secrets-provider-for-k8s
v1.5.1 (2023-05-26)

Security

Forced github.com/emicklei/go-restful/v3 to use v3.10.2 to remove PRISMA-2022-0227 (found in Twistlock scan)
and updated versions of gotelemetry.io/otel (to 1.16.0), github.com/stretchr/testify (to 1.8.3), and
the k8s.io libraries (to 0.27.2)
cyberark/secrets-provider-for-k8s#526

cyberark/terraform-provider-conjur
v0.6.6 (2023-06-21)

Security

Updated golang.org/x/sys to v0.8.0 and golang.org/x/text to v0.9.0
cyberark/terraform-provider-conjur#123
Updated golang.org/x/net to v0.7.0 for CVE-2022-41721 and CVE-2022-41723, and
golang.org/x/text to v0.3.8 for CVE_2022-32149
cyberark/terraform-provider-conjur#117

cyberark/summon
v0.9.6 (2023-06-14)

Security

Upgrade golang.org/x/net to v0.10.0, golang.org/x/crypto to v0.9.0,
golang.org/x/sys to v0.8.0, and Go to 1.20
cyberark/summon#247
Upgrade golang.org/x/net to v0.7.0 for CVE-2022-41721 and CVE-2022-41722 (not vulnerable)
cyberark/summon#245

cyberark/summon-conjur
v0.7.1 (2023-06-14)

Security

Update golang.org/x/sys to v0.8.0, gopkg.in/yaml.v3 to v3.0.1, and Go to 1.20
in Dockerfile.text
cyberark/summon-conjur#112

What's New
This suite release aligned with Conjur Server version 1.19.5.
AWS IAM Authenticator Regional STS Support
The IAM authenticator will now validate use a regional STS endpoint matching the host from the signed headers provided as input. This behavior more closely matches AWS recommendations for STS token validation.
Bug Fixes and Security Patches
Conjur and several other projects in the OSS Suite have been updated with bug fixes and security patches. See the release notes for details.


Collectd & influxdb syslog errors due to errounous HowTo

when following the HowTo:
https://docs.storj.io/docs/setting-up-storj-share-on-a-raspberry-pi
the collectd throws errors like:
Sep 25 18:31:45 storj collectd[1861]: -1 1 Type `contracts' isn't defined.
Sep 25 18:31:45 storj collectd[1861]: -1 1 Type `delta' isn't defined.
Sep 25 18:31:45 storj collectd[1861]: -1 1 Type `percentused' isn't defined.

adding this 3 lines to /usr/share/collectd/types.db
contracts               value:GAUGE:0:U
delta                   value:GAUGE:0:U
percentused             value:GAUGE:0:100

like the owner has stated (https://github.com/bobey/storj-collectd-plugin), resolves this issue and brings up another one:
Sep 25 18:36:24 storj influxd[1745]: 2017/09/25 18:36:24 unable to find "contracts" in TypesDB
Sep 25 18:36:24 storj influxd[1745]: 2017/09/25 18:36:24 unable to find "delta" in TypesDB
Sep 25 18:36:24 storj influxd[1745]: 2017/09/25 18:36:24 unable to find "percentused" in TypesDB

This is due to the typesdb definition in /etc/influxdb/influxdb.conf
the correct entry should look like:
[[collectd]]
  enabled = true
  bind-address = ":25826"
  database = "collectd_db"
  typesdb = "/usr/share/collectd/"

Please correct the HowTo

@chymian Hope you able to get your issue solved. This is the repo for the website, so not the correct place for that type of issue.


400 Bad Request

Hi !
Thanks for your project !
Everithing is working until "Add the skill to your Alexa".
The error is (CloudWatch) :
2022/09/01 19:42:53 &{400 Bad Request 400 HTTP/1.1 1 1 map[Cache-Control:[no-cache, no-store, must-revalidate] Connection:[keep-alive] Content-Length:[97] Content-Type:[application/json;charset=UTF-8] Date:[Thu, 01 Sep 2022 19:42:53 GMT] Permissions-Policy:[interest-cohort=()] Pragma:[no-cache] Server:[Server] Strict-Transport-Security:[max-age=47474747; includeSubDomains; preload] Vary:[Content-Type,Accept-Encoding,X-Amzn-CDN-Cache,X-Amzn-AX-Treatment,User-Agent] X-Amz-Date:[Thu, 01 Sep 2022 19:42:53 GMT] X-Amz-Rid:[JX8J4ZBFDB0BHHAEFEJM] X-Amzn-Errortype:[OA2InvalidGrantException:http://internal.amazon.com/coral/com.amazon.panda/] X-Amzn-Requestid:[e7175a65-ef49-4310-9150-069851c0455e]] 0xc00007edc0 97 [] false false map[] 0xc0004f0000 0xc000306630}
I have seen in your code at "authorization_code", I have :
2022/09/01 19:42:53 map[client_id:[amzn1.application-oa2-client.cfb224dddddddddddddddd] client_secret:[e46453556727bddddddddddddddddddddd] code:[ANqTMeGcRlAIJLsdsss] grant_type:[authorization_code]]
But in the aws website I see that we need "code_verifier" and "redirect_uri".
Do you have the same problem ?

Hmm.  I wonder if you got one of the (many!) magic numbers wrong.
Obviously I haven't had to add this skill to my Alexa for 18 months; it's possible something has changed on the Amazon side of things.
If I get time this weekend I'll try and remove the skill from my Alexa, and re-add it (which should! cause it to generate a new token).
Typically "authorization_code" is used for automated workflows so should be the right thing here; redirect_uri flows are used for humans.  This is the workflow the code should be following; https://developer.amazon.com/en-US/docs/alexa/account-linking/configure-authorization-code-grant.html
Could you provide the log messages from before the failed call, so I can verify the path?
Early in my logs I see this:

START RequestId: 05719cb3-8243-4456-963c-3d61bbf710b5 Version: $LATEST
--
2021/04/21 01:12:14 Handler started
2021/04/21 01:12:14 Alexa call
2021/04/21 01:12:14
{
     "directive": {
         "header": {
             "namespace": "Alexa.Authorization",
             "name": "AcceptGrant",
             "messageId": "cb0edc91-3583-4848-8863-513772c47115",
             "payloadVersion": "3"
         },
         "payload": {
             "grant": {
                 "type": "OAuth2.AuthorizationCode",
                 "code": "XXXXX"
             },
             "grantee": {
                 "type": "BearerToken",
                 "token": "YYY"
             }
         }
     }
 }
2021/04/21 01:12:14 NameSpace: Alexa.Authorization, Name: AcceptGrant

We can see that's Alexa calling us and using the AuthorizanCode path (as expected).
We then continue:
2021/04/21 01:12:14 Attempting to get tokens for code: XXXXX
2021/04/21 01:12:14 200
2021/04/21 01:12:14 Body response: {     "access_token": "ZZZZ",     "token_type": "bearer",     "expires_in": 3600 }
2021/04/21 01:12:14 Result of Handler: {     "event": {         "header": {             "namespace": "Alexa.Authorization",             "name": "AcceptGrant.Response",             "messageId": "91432a95-a041-4e78-8cf8-dbaebb0f0478",             "payloadVersion": "3"         },         "payload": {}     } }
2021/04/21 01:12:14 Handler ended: {     "event": {         "header": {             "namespace": "Alexa.Authorization",             "name": "AcceptGrant.Response",             "messageId": "91432a95-a041-4e78-8cf8-dbaebb0f0478",             "payloadVersion": "3"         },         "payload": {}     } }
END RequestId: 05719cb3-8243-4456-963c-3d61bbf710b5

Which shows we succeeded.

Hi, I have :
2022/09/01 19:42:52 {{{Alexa.Authorization AcceptGrant 50244e45-4c37-XXXXXXXXXX 3 } {{OAuth2.AuthorizationCode XXXXXXXXXXXXXXXXXXXX} {BearerToken Atza|IwEBIFib_vw6WOQZ57nxiDj3qjmuuLSsEaxhF5aHAOwXtTfoVOcfiF6DT6xWdbpcbFVQmOySJJF0nYUiHKhBLeb_ieNyXyI6M94U0u4mMNSMb8Nn7iYq_a7JXGtJ2GAPMgN8g_zHO2hawLNiwKZpce06e6gfkuilVWZH4dDqqc3DZMfSHDhF6qt64lSMbovXlsvnYqaVjIeuxyck6pOggXc3LQ6wV5TbRiBCnOEVMEHaSd858TuYPbwIVyuN1JmPANvE9b3TKlVbKlh57Lbl8rQ1eqlE6mhq5Ngt4uLACzf12b5qH7mTpCO1mWCwy_eC7KOrwpKOQiiuMUINkl-403POT1_pw76ohIew-jGRSlReKFSKbWyiVNgeTnKcLOWCJcH6KsThN42g9asvGdH_DmKYbsul}}}}
2022/09/01 19:42:53 map[client_id:[amzn1.application-oa2-client.cfb2243b2XXXXXXXXXX] client_secret:[e46453556727b54f89df22XXXXXXXXXXXXXXXXXXXX] code:[XXXXXXXXXX] grant_type:[authorization_code]]
2022/09/01 19:42:53 &{400 Bad Request 400 HTTP/1.1 1 1 map[Cache-Control:[no-cache, no-store, must-revalidate] Connection:[keep-alive] Content-Length:[97] Content-Type:[application/json;charset=UTF-8] Date:[Thu, 01 Sep 2022 19:42:53 GMT] Permissions-Policy:[interest-cohort=()] Pragma:[no-cache] Server:[Server] Strict-Transport-Security:[max-age=47474747; includeSubDomains; preload] Vary:[Content-Type,Accept-Encoding,X-Amzn-CDN-Cache,X-Amzn-AX-Treatment,User-Agent] X-Amz-Date:[Thu, 01 Sep 2022 19:42:53 GMT] X-Amz-Rid:[JX8J4ZBFDB0BHHAEFEJM] X-Amzn-Errortype:[OA2InvalidGrantException:http://internal.amazon.com/coral/com.amazon.panda/] X-Amzn-Requestid:[e7175a65-ef49-4310-9150-069851c0455e]] 0xc00007edc0 97 [] false false map[] 0xc0004f0000 0xc000306630}
2022/09/01 19:42:53 Result of Handler: {     "event": {         "header": {             "namespace": "Alexa.Authorization",             "name": "ErrorResponse",             "messageId": "a437efe3-c68f-4b78-97a3-aa5331a68d3a",             "payloadVersion": "3"         },         "payload": {             "type": "ACCEPT_GRANT_FAILED",             "message": "We failed to get a token"         }     } }

Hmm, it looks like the skill is sending the right message, and you have the client_id and client_secret set, which is good.
What region did you deploy in?  I only tested in us-east-1 but I don't think this should make any difference.
I'll see if I have time this weekend to remove the skill from my Alexa and then re-add it, just in case the process has changed (but it doesn't look like it).   (unfortunately I got my 2nd shingles vaccine yesterday and I'm feeling a little brain-dead today; they say the side effects should pass in a day or two!).
However you should definitely check you followed all the install steps; there's a lot of them and it might be easy to miss one.  For example, if the "account linking" wasn't completed properly or if the "redirect urls" weren't set on the LWA profile then the request to convert the authorization code into a token would fail, similar to what you're seeing.

Your Access Token URI : https://api.amazon.com/auth/o2/token
On https://stackoverflow.com/questions/48667128/what-is-the-correct-access-token-uri-for-aws-cognito-and-alexa-account-linking I find : Access Token URI: https://[your-cognito-domain].auth.us-east-1.amazoncognito.com/oauth2/token?state=[same-string-as-the-one-in-auth-url]
I thing I can put :
https://aws.auth.ue-west-1.amazoncognito.com/oauth2/token

Cognito is if you wanted to do your own authentication service; we're using LWA (login with amazon), so the URI I use is the right one.
FWIW, if you want to know the documentation I followed...

The "basic" setup follows the official Alexa tutorial at https://github.com/alexa/alexa-smarthome/wiki/Build-a-Working-Smart-Home-Skill-in-15-Minutes which refers to https://developer.amazon.com/en-US/docs/alexa/smarthome/steps-to-build-a-smart-home-skill.html
The account linking details are at https://developer.amazon.com/en-US/docs/alexa/smarthome/set-up-account-linking-tutorial.html

OK... so I just created a brand new amazon test account and a brand new aws account and on a test phone added alexa to it with this.  So this is a clean from scratch setup.  And I followed my instructions.   Hmm, Amazon have changed the GUI somewhat, and it's now easier to setup a URL ("add a function URL" rather than setting up an API gateway.  I might rewrite the instructions to match these changes).
But it still works.  In particular, https://api.amazon.com/auth/o2/token is the correct URL.
2022/09/05 23:58:29 Alexa call
--
2022/09/05 23:58:29
{
     "directive": {
         "header": {
             "namespace": "Alexa.Authorization",
             "name": "AcceptGrant",
             "messageId": "9a1a1516-708f-4e7f-bab5-5e0aa658322e",
             "payloadVersion": "3"
         },
         "payload": {
             "grant": {
                 "type": "OAuth2.AuthorizationCode",
                 "code": "XXX"
             },
             "grantee": {
                 "type": "BearerToken",
                 "token": "YYYY"
             }
         }
     }
 }
2022/09/05 23:58:29 NameSpace: Alexa.Authorization, Name: AcceptGrant
2022/09/05 23:58:30 Attempting to get tokens for code:XXXX
2022/09/05 23:58:30 200
2022/09/05 23:58:30 Body response: {     "access_token": "ZZZZ",     "refresh_token": "Z2",     "token_type": "bearer",     "expires_in": 3600 }
2022/09/05 23:58:30 Result of Handler: {     "event": {         "header": {             "namespace": "Alexa.Authorization",             "name": "AcceptGrant.Response",             "messageId": "64b711ef-c997-4516-a23c-99a7e8054bc9",             "payloadVersion": "3"         },         "payload": {}     } }
2022/09/05 23:58:30 Handler ended: {     "event": {         "header": {             "namespace": "Alexa.Authorization",             "name": "AcceptGrant.Response",             "messageId": "64b711ef-c997-4516-a23c-99a7e8054bc9",             "payloadVersion": "3"         },         "payload": {}     } }
END RequestId: 62d39187-a87b-427c-a469-c8a90456012e
REPORT RequestId: 62d39187-a87b-427c-a469-c8a90456012e	Duration: 1412.00 ms	Billed Duration: 1412 ms	Memory Size: 128 MB	Max Memory Used: 46 MB	Init Duration: 130.97 ms

So I think the code and instructions are correct.
What region did you deploy this in?  I've only tested in us-east-2 but it should work elsewhere.
Did you verify you have all your magic numbers correct?  I'm wondering if your LWA profile doesn't have the correct 3 redirect URLs.
Amazon don't make it easy; there's so many moving parts (Alexa, Lambda, LWA) that it's hard to do it right first time!  When I was building this it took me multiple attempts.

Hi, I put the following region : ue-west-1.
I don't put the French region because I have seen that the French version blocks somes functions.
If I put my region, when I put the "Default endpoint" I have :
The Lambda ARN arn:aws:lambda:eu-west-3:6045XXXX6:function:Smart_Home_Virtual_Buttons is not valid for any of the supported region

Sorry to dig up the old post again, but I have exactly the same problem as sebcbien37.
What surprises me is that in your instructions you write that the secret is 64 characters long (4x<PHONE_NUMBER>abcdef) but the actual secret is longer and starts with "amzn1.oa2-cs.v1.". I have tried both variants but have had no success. I also went through your instructions several times to make sure I hadn't forgotten anything. As you have noticed yourself, the UI has changed in the meantime, so I sometimes had to guess which setting might be meant. Has anyone found out what the problem is in the meantime?

I tested it recently, everything worked. I couldn't go to the end because my installation was in http and not https.

@Thundras OK, I just created a new setup.  Yes, it looks like all the secrets now have amzn1.oa2-cs.v1. in front of them.  This IS part of the secret and needs to be included in the value.
Heh, I skipped my own instructions and forgot to create buttons 100002 and 100003 but the cloudwatch log told me!

2023/11/09 00:37:35 Lambda started
--
START RequestId: 870e1c0b-7750-4cec-b87c-0fcc52e4f0ec Version: $LATEST
2023/11/09 00:37:35 Handler started
2023/11/09 00:37:35 Incoming data:  {     "directive": {         "header": {             "namespace": "Alexa.Authorization",             "name": "AcceptGrant",             "messageId": "XXX",             "payloadVersion": "3"         },         "payload": {             "grant": {                 "type": "OAuth2.AuthorizationCode",                 "code": "XXX"             },             "grantee": {                 "type": "BearerToken",                 "token": "XXX"             }         }     } }
2023/11/09 00:37:35 Alexa call
2023/11/09 00:37:35 NameSpace: Alexa.Authorization, Name: AcceptGrant
2023/11/09 00:37:36 Ensure you have setclientid and setclientsecret before enabling skill
2023/11/09 00:37:36 Result of Handler: {     "event": {         "header": {             "namespace": "Alexa.Authorization",             "name": "ErrorResponse",             "messageId": "XXX",             "payloadVersion": "3"         },         "payload": {             "type": "ACCEPT_GRANT_FAILED",             "message": "We failed to get a token"         }     } }

Once I set up those values then the skill was successfully loaded onto my test phone's alexa app

2023/11/09 00:43:15 Alexa call
--
2023/11/09 00:43:15 NameSpace: Alexa.Authorization, Name: AcceptGrant
2023/11/09 00:43:15 Attempting to get tokens for code: XXX
2023/11/09 00:43:15 200
2023/11/09 00:43:15 Body response: {     "access_token": "XXX",     "refresh_token": "XXX",     "token_type": "bearer",     "expires_in": 3600 }
2023/11/09 00:43:15 Result of Handler: {     "event": {         "header": {             "namespace": "Alexa.Authorization",             "name": "AcceptGrant.Response",             "messageId": "XXX",             "payloadVersion": "3"         },         "payload": {}     } }

And once I defined a test button then Alexa was able to discover it correctly.

Hi @sweharris and @sebcbien37,
Thank you for your feedback. I have had a look at the code. And it looks like I'm getting the error in the "do_user_auth" function at this point:
resp, err := http.PostForm("https://api.amazon.com/auth/o2/token", request)

	if err != nil {
		log.Println("Error getting code: " + err.Error())
		return "", false
	}

	if resp.StatusCode != http.StatusOK {
		return "", false
	}

	log.Println(resp.StatusCode)

If I read the log correctly, it should jump out at "if resp.StatusCode != http.StatusOK". Unfortunately, the StatusCode is only logged afterwards. I am a programmer myself and can read the code, but I am not a Go programmer and have no idea how to compile it myself.

You're right, it's in the wrong place.  I've updated the git repo, if you want to deploy the latest zip file.
If you're on Unix (and maybe MacOS) then you just need to install GoLang for your distribution and there's a Makefile that does the build.  Essentially it runs the comand
CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -trimpath -o bootstrap alexa.go handler.go api.go command_mode.go main.go alexa_structs.go dynamo.go alexa_auth.go
If you're on windows then install GoLang, set those variables and  run the build command.
Then (optionally) strip bootstrap to make it smaller (probably will only work on Linux), then put bootstrap into a file lamba.zip.  (make lambda.zip on Unix).
Annoyingly we don't get a lot of useful information when errors happen; when I was first building this it took a lot of banging my head on the wall whenever there was an error, but with all the magic numbers exactly correct it does work.

@sweharris many thanks for the information and I will try it out straight away. I'll let you know as soon as I know something about the status code

I get the error 401, which means something like "There was an error authenticating the sender account". Based on the structure of the request structure, this should be the Alexa Client Id and the Alexa Client Secret, right? This information is loaded from the database, buttonid 100002 and 100003. Then I have no idea what the problem is.

So definitely check there's no hidden whitespace in the button definitions.  It's always possible to get that when cut'n'pasting.   Also validate the "Allowed Return URLs" are correct and that you didn't set an allowed origin (that  must be empty) in the LWA web profile.

 There really was a blank at the end of the secret. I have re-entered it 1000 times and not noticed it. Now it works as it should. I can't thank you enough for your help. You have done a brilliant job with this project.

Nice!
Maybe I should add code to strip out leading/trailing spaces from id/secret (strings.TrimSpace() does it, probably in get_buttons()) because this might be catching out other people.  But I'll close this now since both of you appear to have got this working.


feat: serialization docs

Codecov Report

Merging #26 (f2003d6) into main (1651d1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   80.86%   80.86%
=======================================
  Files          18       18
  Lines        1139     1139
=======================================
  Hits          921      921
  Misses        218      218

Impacted Files
Coverage Δ

src/lib.rs
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


test(package): lock pica to v2.0.8

Brief description of the changes
Pica very recently released v3.0.0, and appear to have renamed pica.resizeCanvas to something else. This breaks the test suite, but not the build.
This commit locks pica to the last working version, 2.0.8 in order to make the test suite pass again.
What browsers and operating systems have you tested these changes on?
Verified that the test suite now passes on Windows 8.1
Have you written unit tests? If not, explain why.
No, this is to make existing tests work again.

Good deal, thanks!


questdb: init at 7.1.3

Description of changes
QuestDB is an open source time-series database. The database is column-oriented and optimized for high-speed ingest and blazingly fast SQL analytics.
https://questdb.io/

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2307

I have made requested changes, can you take another look @SuperSandro2000, please?

I get a notification when you force push but due to the amount of notifications I receive the usual wait time is a few days.

I get a notification when you force push but due to the amount of notifications I receive the usual wait time is a few days.

No worries, thanks for the review


Use correct version of wave in package.json

What:
Fixes the version of the library in package.json

Why:
I don't know why but the version in package.json is out of sync. It probably happened when we moved it from the internal repo.
Checklist:

[x] Ready to be merged

I tend to feel this should be done like this. When going to https://semantic-release.gitbook.io/semantic-release/support/faq#why-is-the-package-jsons-version-not-updated-in-my-repository you can see that

@semantic-release/git plugin can be used to push the updated package.json as well as other files to the Git repository

Maybe that's the actual change we want to do.

I think we should close this pull request and wait for a more thoughtful implementation using semantic release.
Has this hasn't been merge yet I guess we are agree. @nlopin

I've created a separate issue #119 to address this separately


Silent push not displaying in killed mode Android

Hi, im usin fcm + notifee with data only messages. Its works on iOS with all situtuaions. In android works well but just killed mode.
Here's my fcm request.

{
    "registration_ids": [ ...device tokens],
    "content_available": true,
    "priority": "high",
    "data": {
        "type": "some shit",
        "link": "some link",
        "title": "title of notification",
        "body": "body of notification"
    }
}

Here is my notification starter.
export const initNotifications = async () => {
  Platform.OS == 'android' && (await setAndroidChannel())
  await requestPushNotificatioins()
  await setForegroundMessageHandler()
  await setBackgroundMessageHandler()
}

Here the functions.
export const setForegroundMessageHandler = () => {
  messaging().onMessage(async (message) => {
    await displayNotification(message)
  })
}

export const setBackgroundMessageHandler = async () => {
  messaging().setBackgroundMessageHandler(async (message) => {
    console.log(message) // DOESNT WORKS ON KILLED MODE
    await displayNotification(message)
  })
}

notifee.onForegroundEvent(async (event) => {
  await logEvent('Foreground', event)
})

notifee.onBackgroundEvent(async (event) => {
  await logEvent('Background', event)
})

const defaultAndroidNotificationSettings: NotificationAndroid = {
//SOME PREDEFINED SETTINGS
}

const defaultIOSNotificationSettings: NotificationIOS = {
//SOME PREDEFINED SETTINGS
}

export const displayNotification = async (message: FirebaseMessagingTypes.RemoteMessage) => {
  const { messageId, data } = message
  const { title, body, android, ios } = data
  const androidNotificationData: NotificationAndroid = android
    ? {
        ...JSON.parse(android),
        ...defaultAndroidNotificationSettings,
      }
    : {
        ...defaultAndroidNotificationSettings,
      }
  const iosNotificationData = ios
    ? { ...JSON.parse(ios), ...defaultIOSNotificationSettings }
    : defaultIOSNotificationSettings

  await notifee.displayNotification({
    id: messageId,
    title,
    body,
    android: androidNotificationData,
    ios: iosNotificationData,
    data,
  })
}

"@react-native-firebase/app": "^14.11.0",
"@react-native-firebase/messaging": "^14.11.0",
"@notifee/react-native": "^7.4.0",

I looked https://notifee.app/react-native/docs/android/background-restrictions and there https://dontkillmyapp.com/ i did them all tried to restart all devices i tried. I couldnt find any solution i hope im missing so little thing.

Please try to reproduce with up to date react-native-firebase
Please watch adb logcat while attempting to reproduce, the system frequently will spit out messages that are important to see, with regard to why a message is delivered to an app or not.
Please include the device manufacturer / model / android version number of devices that fail

ty for reply, but already solved i was calling setBackgroundMessageHandler in main component, where im missing that function must be over the main component. In docs write
To setup a background handler, call the setBackgroundMessageHandler outside of your application logic as early as possible:
Then it solved by
setBackgroundMessageHandler() // that must be init before root commponent

registerRootComponent(App)


Unable to update qraphQL schema

currently onusing window with WSL
using amplify version 1.12.0
I created a graphQL schema with amplify add api
I now want to update the schema and I have tried with amplify update api and amplify api gql-compile. It doesn't update the schema in ./build despite saying the schema has compiled correctly (it will say this even if it's a completely invalid schema).
Once a hit amplify push it will override my schema changes (these changes have been made in the correct location i.e. api/.schema.graphql).
This was working for me previously before changing amplify versions - I can't remember which version to revert to however.
At this stage I will have to delete the API and add other along with rewriting some cloud-formation templates.

@Mknight492 if you want to work on the GraphQL schema, you just have to edit the .graphql file in <projectdir>/amplify/backend/api/<api name>/schema.graphql file and then amplify push.
amplify api gql-compile will actually apply the transforms and builds the .graphql file and the resolver files into the <projectdir>/amplify/backend/api/<api name>/build folder.
I'm closing this issue, but if something new comes up, feel free to reopen it. I would suggest to follow the tutorials to get more information about how commands are working.

@attilah Thanks for you quick response.
I think you've misunderstood my problem.
I defined a schema with amplify add api.
I'm then am unable to update it.
I have tried using amplify push, amplify api gql-compile and amplify update api.
I tried to make it clear that It was the /amplify/backend/api//schema.graph file that gets overridden with amplify push.
I believe this is a bug and the amplify cli is not working as intended

@Mknight492 please provide exact repro steps, because the CLI is never touching customer provided files, the CLI creates its own files if needed, in case of GraphQL compilation we create the one in the build folder.

Nevermind I was making edits in the   #current-cloud-backend directory. Sorry about that.

facing the exact same issue. when I do "amplify status" it detects the changes in API, but when I do 'amplify push' the changes are overridden with the previous state i.e. before edit and message say no changes.


Pending reviews are tied to indivudual so can not be shared among teachers before being submitted

When grading assignments the comments made by me as a teacher in a pending review are hidden from any other teachers that are involved in the course, meaning that it is hard to share workloads and collaborate on correction.
it would be great if reviews are public to teachers, and can be submitted by anyone

Hi
I think its even before that.
it appears that model that the classroom works on now is that its one
teacher per class. We had several. What happens then is that each
instructor starts their own review, which means you can not look at the
suggestions other instructors have made.
/* Johan */
Den tis 26 sep. 2023 kl 15:24 skrev Shane K. Panter <
@.***>:

Hi @jelmstrom https://github.com/jelmstrom I know this is issue is a
bit old but can you be more specific? Are you talking about the pull
requests that classrooms creates for you?
—
Reply to this email directly, view it on GitHub
https://github.com/github/gh-classroom/issues/11#issuecomment-1735537533,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH7I6JKVRQGRXG64KVISYDX4LJQPANCNFSM6AAAAAAZWWMZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, thats what we discussed as well, but that approach was not so easy
either, as we'd have to switch logged in accounts frequently to work on
personal contributions to other repositories.
If a pending review would be accessible to a team or a group of people, it
would make life easier for teachers that are part of a group.
Regards
Johan.
Den tis 26 sep. 2023 kl 16:50 skrev Shane K. Panter <
@.***>:

Hi @jelmstrom https://github.com/jelmstrom if I am understanding you
correctly regarding the feature you are using then yes, that is by design
and how GitHub works. You have to submit your review for them to be visible
to anyone else. From the docs
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request
step 9 :
Before you submit your review, your line comments are pending and only
visible to you. You can edit pending comments anytime before you submit
your review. To cancel a pending review, including all of its pending
comments, click Review changes above the changed code, then click Cancel
review.
One way around this limitation is to create a new account on GitHub that
all teachers share to get around the limitation. That way everyone logs
into the same account and everyone can see the pending reviews and you can
divide up the workload offline.
Hopefully I understood your issue correctly and this helps your out:)
—
Reply to this email directly, view it on GitHub
https://github.com/github/gh-classroom/issues/11#issuecomment-1735702318,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH7I6LGPM2YIXOZVCR4RR3X4LTSPANCNFSM6AAAAAAZWWMZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @jelmstrom, you are not alone regarding this feature :)  You can read about the discussion regarding how reviews in the pending state can't be seen by anyone else or shared until they are submitted.
Unfortunately this feature is not a part of classrooms.github.com but of github itself.
-Shane


Replace "image pyramid" language with "multiscale image"

Problem
The documentation has a lot of language referring to "image pyramids", including mention of an is_pyramid keyword argument.
Solution
This language should be replaced with "multiscale image" instead, and the correct keyword argument to refer to is multiscale (this was changed some time ago in the main napari repository, so we need to update the docs to match).
Where to apply the fix
Affects line 92 - 113 of the documentation at https://github.com/napari/tutorials/blob/master/fundamentals/image.md

I think this can be closed following #4202 @GenevieveBuckley @sofroniewn?


Megaissue - planned upgrade work

Problems

Gathering the issues here as we will likely try and solve this in a way that is more holistic rather than patching existing broken behaviours

[ ] Person Profile needed for email - issue ticket ticket ticket
[ ] Anonymous user IDs - ticket

[ ] Way to specify what property to use as the ID and whether to ignore it if not found
[ ] Maybe we should only ever send identified users?

[ ] Group support -  issue
[ ] Event filtering - issue issue

[ ] Could ideally be done with the new Action filtering UI rather than in code

Proposed solution

Haven't  figured out the details of this ticket, but just to make sure we won't forget https://posthoghelp.zendesk.com/agent/tickets/13230

https://customer7760.zendesk.com/agent/tickets/106906

@benjackwhite @tiina303 Does this include filtering events from users that have specific properties? We don’t want to send free users to customer.io, but we do want to send premium users. This is a field on the user in PostHog.

Does this include filtering events from users that have specific properties? We don’t want to send free users to customer.io, but we do want to send premium users. This is a field on the user in PostHog.

That's the idea of what we are doing. We are hoping to have this out in feature preview this week. Our new delivery system supersedes the plugin concept and has a bunch of nice features such as generic filtering, input template strings and in the end the ability to just modify the underlying code which gives ultimate flexibility (at the cost of having to write some code).
Sneak preview of what it looks like here:

@benjackwhite Amazing, would love to try it ASAP as we have a lot of customers we're adding to Customer.io now that we will have to manually delete :D
Great work guys

Any updates on this?

Is this new system ready to go @benjackwhite? Would love to give implement it.


Add a locale switcher to the site

this pr adds a button switcher similar to: https://digitalpublicservices.gov.wales/
https://user-images.githubusercontent.com/25906/183063484-48d0fd1b-d0f1-46f0-b161-fed38006cc61.mov

start with FEATURE_FLAG_LOCALE_SWITCHER_BUTTONS=true rails s


terraform-providers: Terraform 0.13 compatibility

Motivation for this change
Terraform 0.13 introduces a new filesystem layout to store providers which is incompatible with Terraform 0.12. The new filesystem layout is informed by the Terraform Registry, a repository of providers and modules.
The objectives of this work are:

Make existing terraform providers available to Terraform 0.13 where possible
Change the update script to use the Terraform Registry

Modified

Added a provider-source-address attribute to providers to enable the creation of the filesystem layout.
The update provider script

Script uses Terraform Registry to fetch latest version
Script accepts and updates one provider at a time

Providers stored in providers.json instead of data.nix to use jq only instead of nix + jq combination

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Fixed #98652

Result of nixpkgs-review pr 99198 1

2 packages built:

terraform-providers.acme
terraform_plugins_test

thanks!

specifically cd1b59476793278191c37572c8081b856512eec4 broke it

Sorry for the inconvenience. I will have a fix ready in 3h.

Please look into it again.
shell.nix:
let
  pkgs = import (builtins.fetchTarball "https://api.github.com/repos/nixos/nixpkgs/tarball/master") { };
in
pkgs.mkShell {
  buildInputs = [
    (pkgs.terraform_0_13.withPlugins (p: [
      p.null
      p.helm
      p.vultr
      p.digitalocean
      p.kubernetes
    ]))
  ];
}

nix-shell --run "terraform init"

produces:
Initializing the backend...

Initializing provider plugins...
- Using previously-installed hashicorp/null v2.1.2
- Using previously-installed hashicorp/helm v1.2.2
- Finding latest version of hashicorp/kubernetes...
- Finding latest version of hashicorp/digitalocean...
- Finding latest version of hashicorp/vultr...

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider
hashicorp/kubernetes: provider registry.terraform.io/hashicorp/kubernetes was
not found in any of the search locations

- /nix/store/6bgi4zxw3xvpni361hs8l7xf9d33cy3d-terraform-0.13.5/plugins

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider
hashicorp/digitalocean: provider registry.terraform.io/hashicorp/digitalocean
was not found in any of the search locations

- /nix/store/6bgi4zxw3xvpni361hs8l7xf9d33cy3d-terraform-0.13.5/plugins

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider
hashicorp/vultr: provider registry.terraform.io/hashicorp/vultr was not found
in any of the search locations

- /nix/store/6bgi4zxw3xvpni361hs8l7xf9d33cy3d-terraform-0.13.5/plugins

looking at plugins/registry.terraform.io, we find 2 dirs - hashicorp and nixpkgs.
ls /nix/store/6bgi4zxw3xvpni361hs8l7xf9d33cy3d-terraform-0.13.5/plugins/registry.terraform.io/
# dr-xr-xr-x 3 root 3 Jan  1  1970 helm/
# dr-xr-xr-x 3 root 3 Jan  1  1970 null/

Not found plugins ended up in plugins/registry.terraform.io/nixpkgs:
ls /nix/store/6bgi4zxw3xvpni361hs8l7xf9d33cy3d-terraform-0.13.5/plugins/registry.terraform.io/nixpkgs
# dr-xr-xr-x 3 root 3 Jan  1  1970 digitalocean/
# dr-xr-xr-x 3 root 3 Jan  1  1970 kubernetes/
# dr-xr-xr-x 3 root 3 Jan  1  1970 vultr/

Currently you need something like...
terraform.required_providers = mapAttrs (name: plugin: {
  version = plugin.version;
  source = plugin.provider-source-address or "nixpkgs/${name};
}) pkgs.terraform.plugins;

for providers without the source address set, or just:
terraform {
  required_providers {
    helm = {
      source = "nixpkgs/helm"
    }
  }
}

attribute 'required_providers' missing, can you please supply a full example?

@voobscout the snippet below, to execute in the nix repl, will output the provider definition in nix and will have to be adapted to HCL in your main.tf
$ nix repl
:l https://api.github.com/repos/nixos/nixpkgs/tarball/master

providers = (lib.getAttrs
  ["null" "helm" "vultr" "digitalocean" "kubernetes"]
  pkgs.terraform-providers)

required_providers = lib.mapAttrs (name: plugin: {
  version = plugin.version;
  source = plugin.provider-source-address or "nixpkgs/${name}";
}) providers

:p { terraform = { inherit required_providers; }; }

This is highlighting an improvement I have been meaning to make, to include the provider declaration snippet in the package description (much like on the Terraform registry - screenshot below).

That makes a lot of sense now, thank you @timstott!

guys, maybe you can point me what i'm missing here:
- Using previously-installed nixpkgs/kubernetes v1.11.3
- Using previously-installed hashicorp/local v2.0.0
- Finding hashicorp/kubernetes versions matching "~> 1.10, >= 1.11.1"...

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider
hashicorp/kubernetes: provider registry.terraform.io/hashicorp/kubernetes was
not found in any of the search locations

- /nix/store/cfldgk8hx5zfc3nzij52h149q6l1bnns-terraform-0.13.5/plugins

[terragrunt] 2020/11/22 18:25:40 Hit multiple errors:
exit status 1

❯ cat versions.tf
terraform {
  required_providers {
    helm = {
      source = "nixpkgs/kubernetes"
    }
  }
}

sorry for posting in merged pull request.

guys, maybe you can point me what i'm missing here:

    helm = {
      source = "nixpkgs/kubernetes"
    }

I'm pretty sure you want that to be kubernetes = {

sorry to confuse, I had correct versions.tf, was just copy pasting from your comment before posting my comment:
- Finding hashicorp/kubernetes versions matching ">= 1.11.1"...

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider
hashicorp/kubernetes: provider registry.terraform.io/hashicorp/kubernetes was
not found in any of the search locations

- /nix/store/cfldgk8hx5zfc3nzij52h149q6l1bnns-terraform-0.13.5/plugins

[terragrunt] 2020/11/22 19:58:44 Hit multiple errors:
exit status 1

❯ cat versions.tf
terraform {
  required_providers {
    kubernetes = {
      source = "nixpkgs/kubernetes"
    }
  }
}

so i did edit also eks module:
❯ cat .terraform/modules/eks/versions.tf
terraform {
  required_providers {
    kubernetes = {
      source = "nixpkgs/kubernetes"
    }
  }
}

and did this trick:
terragrunt state replace-provider registry.terraform.io/hashicorp/kubernetes nixpkgs/kubernetes

which is incredibly ugly.

I had a pretty hard time with this, and want to call out the replace-provider of the previous comment.
I had this in my .tf files:
terraform {
  required_providers {
    aws = {
      source = "hashicorp/aws"
    }

    local = {
      source = "hashicorp/local"
    }

    null = {
      source = "hashicorp/null"
    }
  }
}

I'd then run terraform init and it'd look fine:
$ terraform init ./terraform
Initializing modules...
- xxx in xxx/terraform/xxx

Initializing the backend...

Initializing provider plugins...
- Finding latest version of hashicorp/local...
- Finding latest version of hashicorp/null...
- Finding latest version of hashicorp/aws...
- Installing hashicorp/local v1.4.0...
- Installed hashicorp/local v1.4.0 (unauthenticated)
- Installing hashicorp/null v2.1.2...
- Installed hashicorp/null v2.1.2 (unauthenticated)
- Installing hashicorp/aws v2.65.0...
- Installed hashicorp/aws v2.65.0 (unauthenticated)

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, we recommend adding version constraints in a required_providers block
in your configuration, with the constraint strings suggested below.

* hashicorp/aws: version = "~> 2.65.0"
* hashicorp/local: version = "~> 1.4.0"
* hashicorp/null: version = "~> 2.1.2"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.

and then I'd go to do an apply, and it fails:
$ terraform apply \
	-state="./xxx/terraform.tfstate" \
	-input=false \
	-var-file="./xxx/terraform.tfvars.json" \
	./terraform

Error: Could not load plugin

Plugin reinitialization required. Please run "terraform init".

Plugins are external binaries that Terraform uses to access and manipulate
resources. The configuration provided requires plugins which can't be located,
don't satisfy the version constraints, or are otherwise incompatible.

Terraform automatically discovers provider requirements from your
configuration, including providers used in child modules. To see the
requirements and constraints, run "terraform providers".

2 problems:

- Failed to instantiate provider "registry.terraform.io/-/aws" to obtain
schema: unknown provider "registry.terraform.io/-/aws"
- Failed to instantiate provider "registry.terraform.io/-/local" to obtain
schema: unknown provider "registry.terraform.io/-/local"

My shell.nix looked like this:
{ pkgs ? import <nixpkgs> { } }:
pkgs.mkShell {
  buildInputs = [
    (pkgs.terraform_0_13.withPlugins
      (p: [ p.aws p.template p.external p.null p.local ]))
  ];
}

The issue is actually a problem with the 0.12 to 0.13 migration, NOT a problem with this PR.
Our providers were considered "in-house" before, and have less information than terraform wants for the automatic upgrade. This means we need to follow this: https://www.terraform.io/upgrade-guides/0-13.html#in-house-providers
I needed to run:
$ terraform state replace-provider -state="./xxx/terraform.tfstate" 'registry.terraform.io/-/aws' 'hashicorp/aws'

$ terraform state replace-provider -state="./xxx/terraform.tfstate" 'registry.terraform.io/-/local' 'hashicorp/local'

and that fixed the issue with:
- Failed to instantiate provider "registry.terraform.io/-/aws" to obtain
schema: unknown provider "registry.terraform.io/-/aws"

Note if you see an error like:
$ terraform init

Initializing the backend...

Initializing provider plugins...
- Finding latest version of hashicorp/aws...

Error: Failed to query available provider packages

Could not retrieve the list of available versions for provider hashicorp/aws:
provider registry.terraform.io/hashicorp/aws was not found in any of the
search locations

- /nix/store/fam6azhh0wlpaxa27rbxkjyqzrla50xn-tf-plugin-env/bin

it might be because you're on 20.09 and 20.09 doesn't have this PR applied.

sorry to bring it here, if you have something to say from your experience please share your thoughts here:  https://discourse.nixos.org/t/public-cloud-infrastructure-people-whats-you-workflow-with-terraform-terragrunt-providers/11669/4
for a couple of months trying to use nixos provided terraform and providers i faced multiple issues contributing to many people infra projects, like:

figuring out how to configure tf in nixos to install only needed providers and not to install all of them
issues mentioned in this pr
figuring out how to pin the tf version (i tried to overlay 0.14.4 and it failed to build, i did not look into it too deeply)
nixos built providers, which might be not always up to date

also tf 0.14 introduced a lock file to keep providers hashes consistent for all contributors in repo, in case of nixos providers these hashes would be different, meaning we can't use this lock file.
again, i might using it all wrong, please share your workflow if my attitude towards nixos tf and providers are rather wrong.
and yeah, just wondering what is the use case to manage/build providers in nixos, rather than using hashicorp ones? (that might be due to nixos source model, if that's the case I could not agree more).
but for me, it brings much more inconvenience (maybe due to my workflow).

I'm seeing this in nixpkgs v21.05. In my case, I'm building my TF modules from source, and they are being dropped into the /nix/store/qz2ahhd4g3nsrjlykwgs54ssb42lz8ck-terraform-0.15.4/plugins. I can see the compiled providers there, but I am still receiving an error.
$ terraform  init

Initializing the backend...

Initializing provider plugins...
- Finding cloudflare/cloudflare versions matching "2.23.0"...
╷
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider cloudflare/cloudflare: provider registry.terraform.io/cloudflare/cloudflare was not found in any of
│ the search locations
│
│   - /nix/store/qz2ahhd4g3nsrjlykwgs54ssb42lz8ck-terraform-0.15.4/plugins
╵

The suggested fix to run terraform state replace-provider does not apply to my case since this is a new codebase and there is no .tfstate file at this stage. Has anyone else encountered this issue before?

@anandsuresh Have you been able to fix the issue? I've bumped into just now and defining terraform required_providers in my config.tf did the trick for me, e.g.:
terraform {
    required_providers {
      cloudflare {
        source = "cloudflare/cloudflare"
      }
    }
  }


Maps multiple column on the same property object with existing typeHandler

I'm having problems during the data retrieving of an entity (called Person) and an "identifier" attribute of type Identifier nested in it; the goal is to associate two attributes of a table row to the identifier object attributes but, at the same time, a  typeHandler (IdentifierTypeHandler) is defined for the Identifier class.
MyBatis version
3.3.1
Database vendor and version
PostgreSQL 9.6
Test case or example project
The Identifier class is defined as follow and it is contained in the Person class.
public class Identifier {
  private  String id;
  private  String text;
}

Person Class:
public class Person {
  private  String name;
  private  String surname;
  private  Identifier identifier;
}

The implemented result map:
<resultMap id="personResultMap" type="Person">
   <result column="name" property="name"/>
   <result column="surname" property="surname" />
      <association property="identifier" javaType="Identifier">
         <result column="identifier_value" property="id"/>
         <result column="identifier_text" property="text"/>
      </association>
</resultMap>

The problem is that, implementing the above solution, debugging by a JUnit test, the code flows into the IdentifierTypeHandler applying its logic.
Is there a way, by xml, to disable the TypeHandler for a particular association (or any other way)?
Thanks in advance,
Matteo

If you register a type handler globally in the config, there is no way to disable it in a particular mapper.
Instead of registering it globally, you may have to specify it when you need it (e.g. <result .... typeHandler="xxx" /> or #{param,typeHandler=xxx}).
But, a TypeHandler cannot map two column, so the IdentityTypeHandler does not seem to be useful.
Can't you just remove it from the project?
Then the association may work as you expect.
I'm closing this issue because we use GitHub Issues only to track bugs and feature requests.
Please post your question to the mailing list.
Thank you!


New Sample: Read Geopackage.

@dg0yal See how this works for you… Popover in Phone or iPad.

Nice.


Fixed ‘textView.font’ and ‘self.placeholderLabel.font’ fonts with dif…

The initial value of 'textView.text' is not empty. Then edit 'textView.text' to empty, the code for setting the font cannot be executed when updating the placeholders. This results in inconsistencies between 'textView.font' and 'self.placeholderLabel.font'.

Can you share the example situation to check inconsistencies ?


No "Load Data" in the Tokens area

Describe the issue here.
Documentation describes "In the navigation menu on the left, select Data (Load Data) > Tokens." This does not exist in the 2.0.1OSS UI.
Relevant URLs
https://docs.influxdata.com/influxdb/v2.0/security/tokens/update-tokens/
What products and version are you using?

@davidgs Are you not seeing this in your UI? This is from my InfluxDB 2.0.1 running locally for me:

[davidgs@whm ~]$ which influxd
/usr/bin/influxd
[davidgs@whm ~]$ /usr/bin/influxd version
InfluxDB 2.0.1 (git: 37cc047133) build_date: 2020-11-11T03:53:31Z

So that looks right.
The UI only reports 2.0.0 but I saw elsewhere that this was a reported issue.
This is what my UI looks like in the Load Data tab.

So with the left nav condensed, you won't see the lists of sections under each main nav item, but these just correspond to the tabs available in each section. You have a "Tokens" tab on the far right of your top nav. The challenge we tried to solve with the phrasing, Load Data > Tokens , is accurately describing UI structure for both states of the left nav (expanded vs collapsed).

A) How do I 'expand' the nav? and b) the 'Tokens' tab still does not have a 'load' ability.

A) there's a button at the very bottom of the nav to expand/collapse it
B) I don't think tokens are editable in 2.0. Maybe they were in an earlier alpha or beta, but I'm pretty sure they're not currently.

So there's no way to import a token, which means that not only did the data storage change mean all my old data is gone, but now all the configuration of every device/remote telegraf instance has to be updated with new token data. Massive amount of work.

@davidgs The alpha/beta to GA upgrade guide covers how to move all that over:
https://docs.influxdata.com/influxdb/v2.0/upgrade/v2-beta-to-v2/

Yeah, I've tried that doc. Doesn't actually work. :-(

@davidgs Where are you running into issues?

Upgrading from a pre-RC 2.0 to a post-RC 2.0 is a separate issue from this.
Can this one be closed or does the doc still need to be changed for clarity?

token import not supported in ui - closing this issue - if migration doc has also been updated


3D Tiles - Changed numberReady to numberContentReady

Changed numberReady to numberContentReady and now excluding tiles without content from the count. This makes the statistics more clear as to how many tiles actually have content loaded.
I decided not to change numberProcessing to numberContentProcessing because it would have no effect.

Thanks @lilleyse!


Include standard library header

Include standard library header  to build with clang 13.0.1 .

LGTM


Fix useForm initialValues issue

Test me! 'MASTER'
Link to FIX-ANTD-FORM-INITIAL-VALUES
Hey, I'm client! Test me! 'MASTER'
Link to FIX-ANTD-FORM-INITIAL-VALUES
Test me! 'MASTER'
Link to FIX-ANTD-FORM-INITIAL-VALUES
Please provide enough information so that others can review your pull request:
Ant Design Form's setFieldsValue method was making all fields touched. it's better to use initialValues instead
Closing issues

Hello,
Since this fix, I have an issue on useModalForm hook.
const {             show,             modalProps,             formProps,         } = useModalForm<Project>({             resource: "applicationProjects",             action: "edit",             redirect: false,         });
formProps.initialValues are always empty.
I don't know if my issue is related to this fix but for my case I have to go back to<EMAIL_ADDRESS>to have a working modal form.

Hey @clebeaupin ,
Thanks you for contacting us. Probably related to this release. We will release a fix tomorrow.  Thank you for your understanding 🚀Could you create an issue?

We've created https://github.com/pankod/refine/pull/1827 . We will release it today 🎉


[Bug] nested denops request was broken one time with Vim8

Repro step

Install denops.vim and denops-helloworld.vim.
replace denops-helloworld.vim/denops/helloworld/main.ts to below code.

import { Denops } from<EMAIL_ADDRESS>import { execute } from<EMAIL_ADDRESS>import * as vars from<EMAIL_ADDRESS>import * as autocmd from<EMAIL_ADDRESS>import { ensureString } from<EMAIL_ADDRESS>
// Export `main` function which is executed from denops.vim
export async function main(denops: Denops) {
  denops.dispatcher = {
    async say(): Promise<void> {
      await denops.eval("input('test')");
    },
    async ho(): Promise<string> {
      return "hoge";
    }
  };

  // Use 'execute()' to execute multiline Vim script
  await execute(
    denops,
    `
    command! Test call denops#request("${denops.name}", "say", [])
    cnoremap <expr> Q denops#request("${denops.name}", "ho", [])
    `,
  );
}

Run Vim and execute :Test command.
Repeat press Q

Problem

Temporalily freeze and inserted 0 to buffer.
Then an below error occurs at escape from input.

Error detected while processing function denops#request[1]..denops#server#channel#request[4]..<SNR>103_request[3]..function denops#request[1]..denops#server#channel#request[4]..<SNR>103_request:
line    3:
E605: Exception not caught: Error: Failed to call 'say' with []: Error: Failed to call 'call' with ["denops#api#eval","input('test')",{}]: Error: Failed to call 'denops#api#eval(input('test'), [object Object])': dispatch^@    at Vim.callForDebug (file:///tmp/dein/cache/vim/.cache/vimrc/.dein/denops/@denops-private/service/host/vim.ts:49:13)^@    at async Vim.call (file:///tmp/dein/cache/vim/.cache/vimrc/.dein/denops/@denops-private/service/host/vim.ts:70:8)^@    at async Service.call (file:///tmp/dein/cache/vim/.cache/vimrc/.dein/denops/@denops-private/service/service.ts:86:65)^@    at async Session.call (file:///tmp/dein/cache/vim/.cache/vimrc/.dein/denops/@denops-private/service/service.ts:60:25)^@    at async Session.dispatch (https://deno.land/x/msgpack_rpc@v3.1.0/session.ts:98:6)^@    at async https://deno.land/x/msgpack_rpc@v3.1.0/session.ts:108:15^@    at async Session.handleRequest (https://deno.land/x/msgpack_rpc@v3.1.0/session.ts:104:25)^@    at Session.call<EMAIL_ADDRESS>

Environment
Vim 8.2.3206
denops.vim https://github.com/vim-denops/denops.vim/commit/89195f3f8dc91226766dcaf54c748200ac6e31d4

Not sure but maybe a bug on https://github.com/vim-denops/deno-vim-channel-command


[SPARK-13626] [core] Revert change to SparkConf's constructor.

It shouldn't be private.

Test build #53205 has started for PR 11734 at commit 7b9a92b.

BTW it's a little worrying that MiMA didn't catch this in the original change.

LGtm

Test build #53205 has finished for PR 11734 at commit 7b9a92b.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53205/
Test FAILed.

unrelated test failure. merging to master.

Oh, @vanzin .
Sorry for writing comments at the closed PR.
I've read your concern and investigate some. The root cause was GenerateMIMAIgnore.scala makes .generated-mima-class-excludes from the current code having private class. As a result, it ignores the case : visibility goes from public into private. Do you think should I make a Jira issue for this?

Do you think should I make a Jira issue for this?

Please do; this means that APIs that are being changed from public to private might not trigger MiMA failures, when they should. Maybe @JoshRosen could also chime in.

Oh, thank you for fast response. I'll do right now.

I think this problem relates to the fact that the SparkConf companion object is private[spark] and our exclusion generator inappropriately handles cases where classes and their companion objects have different visibility.
I have a good idea of how to fix this, so I'll open a PR in a little bit to address it.

Oh, that's great, @JoshRosen .
I made a Jira issue, but could you change that appropriately with yours?
https://issues.apache.org/jira/browse/SPARK-13948

I don't think that MiMa is necessarily capable of detecting this problem for things which are evolved to become private[spark] because Scala package-private methods become public from Java's point of view and MiMa uses a Java-centric type of binary compatibility; see https://github.com/typesafehub/migration-manager/issues/34. My understanding is that private[spark] is a source compatibility issue from Scala's POV and thus is out-of-scope for what MiMa currently detects.
However, I think it's true that we will fail to detect a class which becomes straight-up private, so we should definitely fix that.


Feature: Simplify e2e build

Coverage remained the same at 100.0% when pulling e90f851542fc69b6a625f65cbedce32162d2f219 on feature/simplify-e2e-build into bb3e5e4a9a1b59e0cf0e0f5b1c7ba4bc07a66ba7 on develop.


Very poor documentation. If i said what I really think I'd probably get banned, this is not documentation

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f55e9a-cd3f-83a0-f142-969dc10d3ceb
Version Independent ID: f6845f70-1ac6-2036-f213-a3b665b3d8bf
Content: Bundle and minify static assets in ASP.NET Core
Content Source: aspnetcore/client-side/bundling-and-minification.md
Product: aspnet-core
Technology: aspnetcore-clientside
GitHub Login: @Rick-Anderson
Microsoft Alias: scaddie

Hello @AndyF1ynn22 ... There's no built-in bundling and minification tooling for the framework. Therefore, there's nothing much to document. Devs are welcome to use any of dozens of products and services for it, but MS doesn't pick a winner by recommending any specific tool. It's up to you to research and determine what's best for your workflow and feature spec.
If you're using Mad's bits™ ... the "BundlerMinifier" that he maintains ... see the docs available (the README at least) via his repo at ...
https://github.com/madskristensen/BundlerMinifier

... and take a look at ...
https://github.com/dotnet/aspnetcore/issues/3023
The PU is thinking it over, and there might be a direction ... a future plan ... for it described there.


Needs information on how to open a specific page

What is the recommended way to open a specific ContentPage (using PushAsync or PushModalAsync) after tapping the notification and launching the activity?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78e442e3-b387-f538-5430-e4538cf60cb9
Version Independent ID: 44dc930e-09e2-56e8-e693-18a69af0a747
Content: Local Notifications on Android - Xamarin
Content Source: docs/android/app-fundamentals/notifications/local-notifications.md
Product: xamarin
Technology: xamarin-android
GitHub Login: @conceptdev
Microsoft Alias: crdun

To clarify, are you asking about a Xamarin.Forms app (receiving a notification on the Android platform)?

Yes.


feat(tests): Enable supabase integration tests

This PR will enable supabase integration tests

failures:
    services_supabase::write_test_create_dir
    services_supabase::write_test_create_dir_existing
    services_supabase::write_test_delete
    services_supabase::write_test_delete_empty_dir
    services_supabase::write_test_delete_not_existing
    services_supabase::write_test_delete_stream
    services_supabase::write_test_delete_with_special_chars
    services_supabase::write_test_fuzz_offset_reader
    services_supabase::write_test_fuzz_part_reader
    services_supabase::write_test_fuzz_range_reader
    services_supabase::write_test_read_full
    services_supabase::write_test_read_large_range
    services_supabase::write_test_read_not_exist
    services_supabase::write_test_read_range
    services_supabase::write_test_read_with_dir_path
    services_supabase::write_test_read_with_special_chars
    services_supabase::write_test_reader_from
    services_supabase::write_test_reader_range
    services_supabase::write_test_reader_tail
    services_supabase::write_test_stat
    services_supabase::write_test_stat_dir
    services_supabase::write_test_stat_not_cleaned_path
    services_supabase::write_test_stat_not_exist
    services_supabase::write_test_stat_with_special_chars
    services_supabase::write_test_write
    services_supabase::write_test_write_with_special_chars

test result: FAILED. 101 passed; 26 failed; 0 ignored; 0 measured; 1651 filtered out; finished in 17.56s

Hi, @Ji-Xinyou, many write related tests failed, would like to take a look?

Hi, @Ji-Xinyou, many write related tests failed, would like to take a look?

Sure, I will have a look at it.

Seems supabase does not support special characters
In test_delete_with_special_chars
thread 'services_supabase::write_test_delete_with_special_chars' panicked at
'write must succeed: Unexpected (permanent) at Writer::write =>
SupabaseError { status_code: "400", error: "Invalid Input", message: "The object name contains invalid characters" }

Any ideas on this test?

Seems supabase does not support special characters

Supabase said:

File, Folder, and Bucket names must follow AWS object key naming guidelines and avoid use of any other characters.

Maybe we just need to make sure the path has been percent encoded?

Maybe we just need to make sure the path has been percent encoded?

Following the first line is what we are using in our behavior tests. As I tested, the third line which removed '#', '%' and '^' works out fine.
let path = format!("{} !@#$%^&()_+-=;',.txt", uuid::Uuid::new_v4());
// remove # % and ^
let path = format!("{} !@$&()_+-=;',.txt", uuid::Uuid::new_v4());

In the Characters to avoid section from the this, we can see Caret ("^"), Percent character ("%") and 'Pound' character ("#") should be avoided.
Maybe we should remove these three characters, at least from the amazon's spec we should avoid these three.

More like a bug: https://github.com/supabase/storage-api/issues/133

Hi, @suyanhanx, I think we can merge this PR first and create a tracking issue for supabase's not passed test cases.

Hi, @suyanhanx, I think we can merge this PR first and create a tracking issue for supabase's not passed test cases.

It‘s ok to me. Just merge after the conflict is resolved.

Hi, @suyanhanx, I think we can merge this PR first and create a tracking issue for supabase's not passed test cases.

Tracked at https://github.com/apache/incubator-opendal/issues/2199


Unsupported operation: Platform._operatingSystem

Invoking storage.write() produces this error:
Unsupported operation: Platform._operatingSystem
Environment:
Windows 10
Chrome
flutter run -d web-server

Full error log:
errors.dart:164 Uncaught (in promise) Error: Unsupported operation: Platform._operatingSystem
    at Object.throw_ [as throw] (errors.dart:213)
    at Function._operatingSystem (io_patch.dart:244)
    at Function.get operatingSystem [as operatingSystem] (platform_impl.dart:58)
    at get _operatingSystem (platform.dart:71)
    at Function.desc.get [as _operatingSystem] (operations.dart:796)
    at get isIOS (platform.dart:139)
    at Function.desc.get [as isIOS] (operations.dart:796)
    at flutter_secure_storage.FlutterSecureStorage.new.[_selectOptions] (flutter_secure_storage.dart:63)
    at flutter_secure_storage.FlutterSecureStorage.new.write (flutter_secure_storage.dart:21)
    at write.next (<anonymous>)
    at runBody (async_patch.dart:84)
    at Object._async [as async] (async_patch.dart:123)
    at flutter_secure_storage.FlutterSecureStorage.new.write (flutter_secure_storage.dart:20)
    at AuthService.AuthService.new.<anonymous> (AuthService.dart:25)
    at Generator.next (<anonymous>)
    at runBody (async_patch.dart:84)
    at Object._async [as async] (async_patch.dart:123)
    at AuthService.dart:20
    at _RootZone.runUnary (zone.dart:1450)
    at _FutureListener.then.handleValue (future_impl.dart:143)
    at handleValueCallback (future_impl.dart:696)
    at Function._propagateToListeners (future_impl.dart:725)
    at _Future.new.[_completeWithValue] (future_impl.dart:529)
    at async._AsyncCallbackEntry.new.callback (future_impl.dart:567)
    at Object._microtaskLoop (schedule_microtask.dart:41)
    at _startMicrotaskLoop (schedule_microtask.dart:50)
    at async_patch.dart:166

Web is not supported. Please check the discussion #96


No warning for no annotations when training

This should now be fixed the latest version 0.1.1, but please reopen this issue if you're still having problems.


Add UI test of SetCompanyActivity

What does this PR do? Please write it down in detail.

What was the previous problem ?
There's no UI test in SetCompanyActivity.

How did you solve it?
Add UI test below.
-testOkBtn
-testCancleBtn
-testTextViewNum
-testTextViewName
-testTextViewLoc
-testEditTextNum
-testEditTextName

Link to the related issue
Is there anything you have tried to improve but failed?
I wanted to test spinner, but I failed.

Good job on the simple UI test!
Did you have any difficulty testing it? Thank you for your effort!

I felt difficulty because I was not used to UI test.
Thanks for your comment!


Switch to Apache License 2.0

@Confusingboat Thanks for sharing this. I would like to use it as part of BurmillaOS (successor of RancherOS) but currently I'm not allowed to because you have shared this under AGPL-3.0 License which is not compatible with Apache License 2.0 which is used by RancherOS:

However, GPLv3 software cannot be included in Apache projects. The licenses are incompatible in one direction only, and it is a result of ASF's licensing philosophy and the GPLv3 authors' interpretation of copyright law.
-- http://www.apache.org/licenses/GPL-compatibility.html

but as project owner you are allowed to change license to what ever you want so I would be very happy to see which to Apache License 2.0.
Link to BurmillaOS UEFI issue: https://github.com/burmilla/os/issues/8

Sure thing, updated in #5


unable to install

I am unable to install this package using npm i -g thor
it's throwing ssh publicKey err

Duplicate of issue 55 which seems to be solved

这是来自QQ邮箱的假期自动回复邮件。

您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。

Duplicate of issue 55 which seems to be solved

This issue is not solved.
The problem is that /3rd-Eden/ws no longer exists, it has moved to websockets/ws. We should update the package lock to point to the right repository

@Adityapanther Use this
npm install -g https://github.com/observing/thor


#424: DNSPolicy basic definition

What

Closes #424

Add document describing how to define a basic DNSPolicy

See document here

Think is good for a quick setup to take DNSPolicy for a spin, with https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/docs/dns-policy.md delves into more of the details with advanced usage. It sort of occurred to me that maybe the two could be merged - not sure.

@jasonmadigan Yes I was struggling to come up with an approach for this that is not made redundant by the DNSPolicy reference, but I guess there might be some value in having a separate page just for the essential, and referencing the other one for advanced usage

Thanks @maleck13, I just pushed the changes with your suggestions

/lgtm


Update link for graphql

Resolves https://github.com/amplication/amplication/issues/7449
This Pr changes the link in the section https://github.com/amplication/docs/blob/main/docs/welcome.md#key-features-of-amplication
The link of the GraphQL (https://github.com/amplication/docs/blob/main/api/#graphql-api) should be (https://github.com/amplication/docs/blob/main/api/#graphql-apis)

@overbit Can you please review this PR Thank You :)

It looks good to me, @Atharva1723 @overbit. Thanks!

Will this PR be reviewed ?

Will this PR be reviewed ?

@PazYanoverr, this one looks good to me. What are your thoughts?

@dericksozo - Perfect. Thanks @Atharva1723


Add markdown flag to TemplateField

Allows overriding single/multi line check to enabe/disable markdown processing for a given field.

Let's do it. 👍


Improve security-related documentation

This is an umbrella issue

What would you like to be added
Review and possibly revise the existing pages on the topic of Kubernetes security.
Why is this needed
It's important to help readers understand how to make sure a Kubernetes cluster has appropriate security controls.
Comments
Look at the overall body of topics related to security context and policy. Do we have the right set of topics? Have we covered all the important points?. Is there overlap that could be reduced? Here are some of the existing topics:

Security
Controlling Access To The Kubernetes API
TLS and tasks in that section
Pod Security Policies
Securing a Cluster
Using RBAC Authorization
Using Admission Controllers
Network Policies
Configure a Security Context for a Pod or Container
After choosing a set of topics, apply the appropriate template: Concept or Task. Edit the topics to comply with our style guide. Check for accuracy and also fit against the CNCF cloud native security white paper

/sig security

The docs security overview concept page contains a table of links as well as more links (Secrets, encryption at rest, ...) at the bottom of the page.

I reckon it'd be handy if we could find a way to link to https://www.microsoft.com/security/blog/2020/04/02/attack-matrix-kubernetes/

I reckon it'd be handy if we could find a way to link to https://www.microsoft.com/security/blog/2020/04/02/attack-matrix-kubernetes/

/priority important-longterm

/priority important-longterm

/remove-lifecycle stale

Also see issue #27515

/remove-lifecycle rotten

https://github.com/kubernetes/website/issues/27370#issuecomment-900397304 feels relevant too

/remove-lifecycle rotten

/lifecycle frozen

Is this issue still needed? It might be too broad.

Might be too broad yes. I think there are useful asks in it though. Some have been improved on since this was opened. Maybe this could morph into a collection of the various umbrella issues like ServiceAccount, Secrets, etc? Or we can just close this

One point on this is that I think "securing a cluster" would be replaced by a combination of the hardening guide that's in progress and the security checklist.

Also see https://github.com/kubernetes/website/issues/44169

Also see https://github.com/kubernetes/website/issues/44430

Will it be good to add more content to the Security Tutorials on topics that complement Kubernetes security by using 3rd party tools? I'm thinking of step-by-step guides that people can follow along on their local K8S clusters (minikube?).
Topic examples could be implementing policies using OPA Gatekeeper, Runtime sandboxes like gvisor, trivy for vulnerability scanning etc.
The basic commands and tutorials can be explained with reference to the official documentation of the 3rd party tools if people want to get into the details.

Yes, @adityasamant25 I'm agree with you that we can add more content like this above!!

Topic examples could be implementing policies using OPA Gatekeeper, Runtime sandboxes like gvisor, trivy for vulnerability scanning etc. I know these topics are discussed in older blog posts or the community forums, but could be good to have them listed in the official tutorials.

Those might be better handled as newer blog posts. We try not to document too much about 3rd party software, as it is harder to maintain. If the original blog article's author supports it, we could also link a new article to the previous article and vice versa.

Yes @sftim, how are we achieving that?

Also see https://github.com/kubernetes/website/issues/48546


FcmJava with PoolingHttpClientConnectionManager Usage

Hi:
I'm wanting to confirm if FcmJava can be used with PoolingHttpClientConnectionManager in multithread environment for higher performance.
I have code roughly as follows that uses the new FcmJava DefaultHttpClient with a new HttpClientBuilder that uses an existing pooling connection manager on each request. It seems to be working but I'm not sure if FcmJava is really re-using the connection from the pools or closing it each time. Here is roughly the code:
    // Created once
    PoolingHttpClientConnectionManager cm = new PoolingHttpClientConnectionManager()
                                    .setMaxTotal(10)
                                    .setDefaultMaxPerRoute(5);

    // Done per thread request
    // Setting shared was important for keeping the connection manager from shutting down
    HttpClientBuilder clientBuilder = HttpClients.custom()
                                        .setConnectionManager(cm)
                                        .setConnectionManagerShared(true);
    FcmClient client = new FcmClient(fcmSettings, new DefaultHttpClient(fcmSettings, clientBuilder));

    client.send(....)

With house FcmJava is implemented, does this give me the expected higher throughput using the connection pool as compared to  creating a FcmClient as:
 FcmClient client = new FcmClient(fmcSettings);
 client.send(....)

In looking at some of the FcmClient code and class DefaultHttpClient.java and the methods of 'internalPost' were making the request to FCM but closing the connection.
Thanks.

Yes, when I rewrote the DefaultHttpClient I also thought about using a Connection Pool and not shutting down the connection for each request. But I didn't have the time to implement it in a way, that I am safe to release. And I didn't find a lot of resources for best practices with a CloseableHttpClient.
I don't know when I will have the time to verify or evaluate your questions. Please do not expect a fast reply.

Thanks for your response. I'll try to spend some time to see if it works currently as expected as in the above code, if not, then I'll fallback to the basic usage without connection pool. And await for any future updates or conclusions you may have. Thanks.

I have added an initial version for reusing the CloseableHttpClient instead of creating one for each request. I am quite sure the CloseableHttpClient has some kind of Connection Pooling inside, so it should have a good throughput.
Maybe you can try the current implementation in the master branch and let me know about the performance.

Hi:
I was doing some testing with the code from master and for my testing, it seems to work.  I was using the 'master' with those changes, with code example as I put in the original issue. I'm definitely seeing better performance (under the right PoolingHttpClientConnectionManager() settings relative to the work load being sent to it).
I saw your diff changes and they made sense than the version I was using before.
In my preliminary findings, if the number of threads attempting to send message through were
equal or less than than max total and or max per route, of course got better performance compared to using "FcmClient(fmcSettings)" constructor.
.setMaxTotal(10)
.setDefaultMaxPerRoute(5);
If you were to eventually get more validation of these changes and any other checks to confirm these changes are good, it would be nice to get it in regular release officially and then we make use of it.
Thanks for the the quick changes to allow me to check and looking forward to these enhancements getting in an official release.

I have released Version 2.1 to the Maven repository. The IFcmClient now implements an AutoClosable as well, so all implementations of the interface have to release their resources.

Thank you so much for making this in a new release. I appreciate the great support and will work on integrating it.


how to change input image size

I change input image size to 800,800 in configs/CornerNet_Saccade.json,but it is wrong.

You need change attention tasks


feat(file upload): add file upload component

closes #2624

PatternFly-Next preview: https://patternfly-next-pr-2681.surge.sh

@lboehling I just spoke with @christiemolloy and we agreed that the styling in your design is preferable to the disabled button styling for the control button so she will make that update after confirming that this does not present a risk elsewhere.

:tada: This PR is included in version 2.65.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Awesome work @christiemolloy ! This came out great.

@christiemolloy @mcoker @mcarrano @mattnolting I realized something about this design while implementing the React version, and I have a question:
There is an example showing an error icon in the filename field (aria-invalid="true"), which looks like it is for errors in the file upload process itself. Two things:

The filename input field in this example is not readonly, and making it readonly hides that error icon even if the field has aria-invalid="true".
If a consumer wants to display a form field validation message about the file's body itself (e.g. what they pasted in was invalid in some way, or too long, or is required but was left empty, etc) should we put the invalid styles on the textarea? I can imagine a scenario in which the field is required, and there is an error in the upload, so the "required" validation is failing and we have error icons in both the filename input field and the textarea.

I think we either need to change the CSS so the error icon can be displayed in a readonly text field, or we should change the examples and place the error icon in the textarea instead of the input for any invalid states of this component. What do you guys think?
If we did the latter, instead of this:

we'd have this:

Thanks for bringing this up @mturley we definitely didn't catch this in the Core implementation. I would be in favor of the second example where the error icon is on the text area because that is the "editable" section, so it makes sense to tell the user where the error is and where it can be fixed. I think putting the error icon within a disabled input would be misleading as to where the error is and how to fix it. Thoughts @mcarrano @mcoker @mattnolting

Thanks for bringing this up @mturley we definitely didn't catch this in the Core implementation. I would be in favor of the second example where the error icon is on the text area because that is the "editable" section, so it makes sense to tell the user where the error is and where it can be fixed. I think putting the error icon within a disabled input would be misleading as to where the error is and how to fix it. Thoughts @mcarrano @mcoker @mattnolting

Thanks for bringing this up @mturley we definitely didn't catch this in the Core implementation. I would be in favor of the second example where the error icon is on the text area because that is the "editable" section, so it makes sense to tell the user where the error is and where it can be fixed. I think putting the error icon within a disabled input would be misleading as to where the error is and how to fix it. Thoughts @mcarrano @mcoker @mattnolting

The filename input field in this example is not readonly, and making it readonly hides that error icon even if the field has aria-invalid="true".

From what I can tell, if a field is readonly and is either in the invalid or success state, the invalid/success state overrides the readonly styles. So you keep the error/success icon, but lose the readonly state background.

I'm pretty sure we can consider that a bug and fix it. And in testing the fix, it looks like allowing a form control component to support error/success and readonly states at the same time will result in a breaking change because of the way we assign background properties. https://github.com/patternfly/patternfly-next/pull/2753/files
Assuming we want to implement this fix, we can also patch the file upload component now, which wouldn't be a breaking change, and update the form control component later. Also curious what @mcarrano and @lboehling think about that or if maybe there is another design we should consider for indicating error(s) in this component?

I can imagine a scenario in which the field is required, and there is an error in the upload, so the "required" validation is failing and we have error icons in both the filename input field and the textarea.

Agree, and am curious what @mcarrano and @lboehling think.

@christiemolloy @mcoker I think that associating the error with the text area makes the most sense as shown in the second example above.

In that case, in the "Upload complete non editable" state, do we still want to support the error/success icon being added to that read-only textarea? Seems we would still need a patch/fix there.


Improve Documentation of Installation Process

It appears that the documentation on installation needs clarification. It can lead to having wrong pandas version such as in #288

There was nothing wrong with the installation instruction, instead, the file environment.yml did not specify the right pandas version.


Segmentation fault (core dumped)

Hi, Thanks for your code!
When I used your code to run experiments on the COCO dataset. We used the 8  v100 32g  card. Although I set the bs=4,
When infer, eval cam and PPMG, I had met the following error,
THCudaCheck FAIL file=/pytorch/aten/src/THC/THCCachingHostAllocator.cpp line=296 error=2 : out of memory
Segmentation fault (core dumped)
Could you please give me some advice?
Best wishes to you!

Thanks for your advice.
Now, I run normally!

Hi, nice work!
When I read your code in the " infer_multi_crop.py"
line 80-82
cam_dict = {}
for i in range(args.num_cls-1):
if label[i] > 1e-5:
cam_dict[i] = norm_cam[i].astype(np.float16)
Did this mean that you use the image level information for the pseudo segmentation label？Did you follow other paper？
Thank you very much!

In mask generation of train_sug set, image-level tags are needed.
I follow SEAM, and many papers do like this.


KAFKA-5928: Avoid redundant requests to zookeeper when reassign topic partition

We mistakenly request topic level information according to partitions config in the assignment json file. For example https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala#L550:
val validPartitions = proposedPartitionAssignment.filter { case (p, _) => validatePartition(zkUtils, p.topic, p.partition) }

If reassign 1000 partitions (in 10 topics), we need to request zookeeper 1000 times here. But actually we only need to request just 10 (topics) times. We test a large-scale assignment, about 10K partitions. It takes tens of minutes. After optimization, it will reduce to less than 1minute.

cc @lindong28

What a pity

@uncleGen I understand it is frustrating not to get your patch reviewed and committed. Recently I am on vacation in China and I am busy with addressing reviewed for KAFKA-5163. And I am sure Guozhang is busy with the 1.0 release currently and there is a lot of ongoing work for 1.0 release.
FYI, Kafka community is short of people reviewing open source patches. I myself has a number of patches that do not get reviewed for more than one month, as you can see in my pull request. I understand it is frustrating but we all have to live with it. My KIP patches typically wait for more than 1 month before it gets any review.

@lindong28 okay

FAILURE
8067 tests run, 5 skipped, 2 failed.
--none--

FAILURE
7959 tests run, 5 skipped, 1 failed.
--none--

FAILURE
8067 tests run, 5 skipped, 2 failed.
--none--

Looks like unrelated failures.
retest this please.

@lindong28 Could you please take a review?

FAILURE
8067 tests run, 5 skipped, 2 failed.
--none--

FAILURE
7959 tests run, 5 skipped, 1 failed.
--none--

FAILURE
8067 tests run, 5 skipped, 2 failed.
--none--

also cc @ijuma

@uncleGen I apologize for all the delay and comments. Not sure if it is still a problem. If you can update and rebase the patch, I will definitely review it properly in time. Thanks!

@lindong28 Sorry for delay, I will check if it is still a problem.

retest this please

retest this please

Take a review please cc @lindong28

Thanks much for the update @uncleGen. LGTM. Will merge the patch if there is no further comment from Ismael :)

If you're happy with it, please go ahead. I only took a quick look, but there's no need to block on me.

Thanks @uncleGen @ijuma. The patch is merged to trunk.


Implementing custom tracer using OTel SDK as envoy filter

Title: Implement custom OTel tracer as an envoy filter and configure the filter to HttpConnectionManager
Description:
Based off my understanding of envoy's code here, the OTel tracing implementation does not seem to be relying on the C++ SDK.
I have a use-case where I was planning to write a custom OTel Tracer based off the OTel C++ SDK as an envoy filter, like the HTTP Filter example
and then configure that as one of the filters to the HttpConnectionManager, exactly the existing tracer as per the documentation
Would the above approach work? Or do I have to make the code changes by forking envoy's codebase?

cc @alexanderellis @htuch

You should be able to add another Otel tracer extension that uses Otel SDK. Is there a reason to use HTTP filter extension point?

The tradeoff here is mainly forking away from envoy codebase v/s writing a filter extension and compiling that with envoy. And then using that with the HTTP Connection Manager. We are anyways building and maintaining a host of HTTP filter extensions on our side. Is that a best practice or an approach that works though?

The main concern is that tracing has cross-cutting concerns (sampling, span tags) that could benefit from shared Envoy infra used for all tracers rather than making new config for HTTP filters.

The extension model is the same for tracers and the filters and other components. It's very easy to add or not consume extensions from upstream. In the future, it might be possible to add it to contrib or core extension in Envoy, depending on its adoption.

Awesome! Thats great to know. Thanks for clarifying and providing pointers. I will proceed that way.

@joaopgrassi

Hi @htuch #28929 is about extending the existing OpenTelemetry tracer and add the notion of resource detectors to it, which is a feature of OTel and is also present in the OTel C++ SDK. In a nutshell, we are "replicating" the behavior of the OTel C++ SDK in Envoy since we don't use the SDK in here.
IIUC @vigchan is trying to do is add a new Tracer that is then using the OTel C++ SDK internally . I did some investigation on how feasible to the same and I hit so many road bumps that I'm not sure it's so easy.  I'm just a noob in Envoy at this point so maybe it's just that, but from my limited time working on the codebase and debugging the trace-related part I feel this comment summarizes it well:

The main concern is that tracing has cross-cutting concerns (sampling, span tags) that could benefit from shared Envoy infra used for all tracers rather than making new config for HTTP filters.

Even if we have a "extension tracer" that is using the OTel SDK internally, other parts of the Envoy would still not use it, sampling is completely different. My sentiment is that to fully get all the benefits of having the OTel SDK in, would be to completely change how tracing is done in Envoy and only have OTel spans/propagation .Then you can benefit from the multiple propagators OTel offers, Sampling, exporters, span processors and etc.
I'm not sure I helped with anything but that's my view.

Yep, thanks, that makes sense, just noticed a superficial similarity on SDK integration. OK, I'm not sure why we would want to do this then, can we just get the OTel tracer that you are working on to support whatever @vigchan needs?

With the changes I'm working, we will be able to export via HTTP #29207. #28929 will bring support for custom resource detectors, similar as we have in the OTel collector
The next thing I think I will work on is defining also custom sampler for the OTel Tracer. I think I will use the same idea of the resource detector and use the extension framework in Envoy to allow users to configure a custom sampler, that is then used by the OTel tracer in Envoy. I will create an issue for it today or tomorrow.


Typo "Azure storage emulator"→"Azure Storage Emulator"

https://docs.microsoft.com/en-us/visualstudio/azure/vs-azure-tools-configuring-an-azure-project?view=vs-2019

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.