FE-937 Feature/bundle struct station chips

Why?
Integrate the new bundle object which replaces DeviceProfile and introduce the new "bundle" chip as we separate the bundle icon with the status chip.
How?

Integrate the new Bundle object with its fields
Create an enum class BundleName in UIModels which we use for if...else reasons in the UI and gets created by the bundle.name field.
Replace all the checks we used before with DeviceProfile with the Bundle ones.
Created the new bundle chip and the respective extension function Chip.setBundleChip()
Increased the version number of the database in order for Room to perform migration
Replaced the wrong WiFi icon

Testing
Run localMock flavor and ensure everything is OK in the following screens:

Devices List
Device Details
Device Info
Cell Devices
Network Search
Widget's Devices List (the list when clicking to add a widget)

Looks good! Let's wait until the API is ready


feat: Reintroduce LaxRedirectStrategy in HttpClient 5.3.x

This commit adds a new implementation of the LaxRedirectStrategy, bringing back functionality similar to that found in HttpClient 4.x. The LaxRedirectStrategy automatically redirects all HEAD, GET, POST, and DELETE requests, relaxing the restrictions imposed by the HTTP specification on automatic redirection of POST methods.
Key Features:

Supported Methods: Redirects HEAD, GET, POST, and DELETE methods.
Location Resolution: Automatically resolves relative redirect URIs against the request URI.
Compatibility: Ensures compatibility with existing 4.x applications by providing a familiar API and redirect behavior.
Normalization: Normalizes and converts the host part of the redirect URI to lowercase, maintaining consistent behavior.

Benefits:

Simplifies migration from HttpClient 4.x to 5.x by providing a drop-in replacement for LaxRedirectStrategy.
Supports applications that rely on flexible redirect behavior for non-idempotent HTTP methods.

Usage:
CloseableHttpClient httpClient = HttpClients.custom()
    .setRedirectStrategy(LaxRedirectStrategy.INSTANCE)
    .build();

@otavioprado Few minor things

Generally we do not add new features (and this is technically a new feature) to stable branches. Would you mind changing the target branch to master (5.4)?
Please change @since tag to 5.4
Test methods should have package visibility for consistency with existing test cases

Hi @ok2c,
I've addressed your comments and reopened the pull request with the necessary changes. The new PR is targeting the master branch as requested, and you can find it here: #565.
Thank you for your feedback, and please let me know if there are any additional adjustments needed!


Updated openapi.yaml with the allocations from the main branch and the logs endpoint + regenerated client

Would you mind signing off on the DCO?
https://github.com/fermyon/nomad-dotnet/pull/2/checks?check_run_id=6411278336


Count function

Hi,
We have implemented logging using LiteDb. So I need to collect data, filter by username, action, and date, and show that data to the user.
And next code has strange behavior
var count = LiteDB.Query.Or(LiteDB.Query.Contains("Action", "admin"), LiteDB.Query.Contains("UserName", "admin"));
            var btw = LiteDB.Query.Between("Stamp", new BsonValue(DateTime.Now),
                new BsonValue(DateTime.Now - TimeSpan.FromDays(30)));
            var c1=DB.Count(count);
            var c2=DB.Count(btw);
            var c3= DB.Count(LiteDB.Query.And(btw,count));

c1 works fast
c2 works fast
c3 evaluates about 10-15 mins, and locks db for that time.

Size of DB is 13Gb with 34324 items.
Seems like DB is doing a full scan for this request.
Do u have any ideas why it has so much lower performance, and how to improve it?
Version is 4.1.4
Thanks for your support.

@thelloworldt You could try running db.Shrink() to reduce the file size.

@thelloworldt You could try running db.Shrink() to reduce the file size.

nope, that's not a solution. Shrink removes deleted items and reduces the size. But in our case, it is a log file, so there are no removed items.
Thanks.

@thelloworldt Do you have any performance improvement if you change the order of the operations? (And(count,btw) instead of And(btw,count))

Count() will load all data into memory.


Update net to fix various CVEs

Update generated by go get -u golang.org/x/net/go mod tidy.
These were flagged by Grype on the release-0.14 branch for net v0.8.0.
GHSA-2wrh-6pvc-2jm9 was fixed in v0.13.0.
GHSA-4374-p667-p6c8 was fixed in v0.17.0.
GHSA-qppj-fm5r-hxr3 was fixed in v0.17.0.

It seems the names of the required jobs for this branch need to be updated.


Allow untranslated queries to work with databases other than MySQL

Backticks only work in MySQL; luckily Laravel has a solution in the form of query joins!
Should work for at least 5.2 and above.

Thanks!


Release the new version to nuget

The feature that allows me to change the dialogs button names, update to microsoft nuget.

Hi @Ayley, the pre-release version already includes this functionality.


Hot reload / Hot restart don't work in Android Studio 3.6.3 - Windows 10

Given the most simple app, seen below, when i change the text, and hot reload - nothing changes.
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      title: 'Test App',
      home: Scaffold(
        body: Center(child: Text("Test1")),
      ),
    ),
  );
}

Alot of people seem to be complaining of the same at the bottom of this issue
On my normal sized app, the issue is slightly different, when i hot reload, the file change doesn't seem to be detected as i get the following output:
Performing hot reload...
Syncing files to device Moto G 5S Plus...
Reloaded 0 of 866 libraries in 547ms.

Also, when i hot restart, the app restarts but changes don't appear:
Performing hot restart...
Syncing files to device Moto G 5S Plus...
Restarted application in 4,114ms.

Flutter doctor
C:\Users\olly_>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.17.1, on Microsoft Windows [Version 10.0.18363.836], locale en-GB)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[√] Android Studio (version 3.6)
[!] IntelliJ IDEA Community Edition (version 2019.3)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] VS Code (version 1.45.1)
[√] Connected device (1 available)

! Doctor found issues in 1 category.

I was on beta channel, but switched back to stable to see if that fixed anything, which it didn't.
Possibly related
I did notice that flutter doctor was failing to get android licenses statuses as Android Studio seems to have deprecated the old 'build' folder in favor of 'cmdline-tools' - see my comment on this SO Answer - So i had to install the 'Android SDK Tools (Obsolete)' from Android Studio Sdk Manager.
Apologies if there's a duplicate ticket somewhere in issues already, I had a quick scan but couldn't find anything that seemed to be the same thing.

duplicate of https://github.com/flutter/flutter/issues/57796


prefs not correctly handled as experimentaloptions

Currently I'm having some problems setting the experimental options. In Python, everything works fine (through the Create Webdriver keyword). When I try and do the same for the Java variant, I'm not getting the same results. I am setting the same prefs.
I put both the Python version and the Java version here for reference. What I do is, I cal leither of these to open a Chrome browser. Then I browse to a URL containing a PDF document. With the Python settings, the PDF is downloaded directly, to the folder I set in prefs. With the Java variant, the download popup shows using the default download folder.
I already tweaked the BrowserManagement class in the library to convert the prefs JSONObject to a Java Map. This didn't fix the issue. It looks like only the one prefs property is honered through Java for some reason.
Start Chrome For Python
    [Arguments]    ${URL}
    ${chrome options}=    Evaluate    sys.modules['selenium.webdriver'].ChromeOptions()    sys, selenium.webdriver
    ${prefs}    Create Dictionary    prompt_for_download=false  download.default_directory=${OUTPUT_DIR}${/}${download}    plugins.always_open_pdf_externally=${TRUE}
    Call Method    ${chrome options}    add_experimental_option    prefs    ${prefs}
    Create Webdriver    Chrome    chrome_options=${chrome options}
    Go To   ${URL}

Start Chrome For Java
    [Arguments]    ${URL}
    ${downloadDir}    Replace String    ${OUTPUT_DIR}${/}${download}    \\    /
    ${browserOptions}=    Catenate
    ...    {
    ...        "args": [  ],
    ...        "extensions": [  ],
    ...        "prefs":
    ...            {
    ...                "prompt_for_download": false,
    ...                "download.default_directory": "${downloadDir}",
    ...                "plugins.always_open_pdf_externally": true
    ...            }
    ...    }
    Log    ${browserOptions}
    Open Browser    ${URL}    Chrome    browserOptions=${browserOptions}

I think it works fine for me, expect the default download dir, which might relate to SeleniumHQ/selenium#5292

Now I got this to work with Windows. I think it's matter of escaping things, and because of that some more logic is needed if tests are running with both Linux and Windows.
Working Chrome part is:
Download automatically
    WebDriver Manager Setup    Chrome
    ${downloadDir}    Replace String    ${OUTPUT_DIR}${/}${download}    \\    \\\\
    Log    ${downloadDir}
    ${browserOptions}=    Catenate
    ...    {
    ...        "args": [  ],
    ...        "extensions": [  ],
    ...        "prefs":
    ...            {
    ...                "plugins.always_open_pdf_externally": true
    ...                "download": {
    ...                    "default_directory": "${downloadDir}",
    ...                    "prompt_for_download": false
    ...                }
    ...            }
    ...    }
    Log    ${browserOptions}
    Open Browser    ${URL}    Chrome    browserOptions=${browserOptions}
    Capture Page Screenshot    #Needed because otherwise incomplete download is made. Basically any browser command probably would be OK.

So no changes needed to the library itself I think.


Merge Release/2.1 into dev

Conflicts

Can't merge via UI as we updated deps.props. Going to push change to dev directly.


Couldn't access findings page

Slack us first!
This issue has already posted in slack
Bug description
We often see 502 errors when opening findings related pages (e.g /finding/27394, /product/358/finding/*)
Steps to reproduce

Go to related finding pages
Page will loading in a few minutes
Error page "Error: Server Error. The server encountered a temporary error and could not complete your request. Please try again in 30 seconds" occurred

Expected behavior
Page will opened as usual (REST API call works like a charm: /api/v2/findings/27394 (173ms 2.85ms))
Deployment method (select with an X)
Kubernetes with helm chart
Environment information
DefectDojo v2.13.1
PostgreSQL 13
Google Kubernetes Engine
celery:
  beat:
    replicas: 3
    resources:
      requests:
        cpu: 256m
        memory: 128Mi
      limits:
        cpu: 2000m
        memory: 256Mi
  worker:
    replicas: 3
    resources:
      requests:
        cpu: 256m
        memory: 128Mi
      limits:
        cpu: 2000m
        memory: 512Mi
django:
  nginx:
    resources:
      requests:
        cpu: 200m
        memory: 256Mi
      limits:
        cpu: 2000m
        memory: 256Mi
  replicas: 4
  uwsgi:
    resources:
      requests:
        cpu: 2000m
        memory: 8G
      limits:
        cpu: 2000m
        memory: 8G
    app_settings:
      processes: 2
      threads: 2
extraConfigs:
  DD_UWSGI_BUFFER_SIZE: '1048576' # 1MB

Logs
Error from GCP Cloud logging:
nginx: GET /finding/27394 HTTP/1.1" 499
uwsgi: uwsgi_response_writev_headers_and_body_do(): Broken pipe [core/writer.c line 306] during GET /finding/27394
Sample scan files
Screenshots
https://files.slack.com/files-pri/T04T40NHX-F047CAZMA73/502-server-error.png
Additional context (optional)
Total rows in our dojo_finding table 133630, dojo_engagement 5634, dojo_test 71158

We often began to face 502 errors on different pages and different API requests as well.
Mon Feb 20 18:29:45 2023 - uwsgi_response_write_body_do(): Broken pipe [core/writer.c line 341] during GET /simple_search?query=%5BCE%5D-project-web (<IP_ADDRESS>)
OSError: write error

Probably, it's performance issue
We host on t2.large EC2 instance type

We're facing the same issue.

I guess you need performance tuning. This can probably be closed as it is ops related @mtesauro


MatchError when using select_merge in subquery

Environment

Elixir version: 1.9.0 (compiled with Erlang/OTP 22)
Database and version: PostgreSQL 11.3
Ecto version: 3.1.7 (ecto_sql 3.1.6)
Database adapter and version: postgrex 0.14.3
Operating system: macOS Mojave 10.14.5

Current behavior
See the following query:
query =
  MySchema
  |> select_merge([m], %{m | name: "some name"})
  |> subquery()

MyRepo.all(query)

This leads to the following error at runtime:
** (exit) an exception was raised:
    ** (Ecto.SubQueryError) the following exception happened when compiling a subquery.

    ** (MatchError) no match of right hand side value: {MySchema, [id: {{:., [], [{:&, [], [0]}, :id]}, [], []}, name: {{:., [], [{:&, [], [0]}, :name]}, [], []}, inserted_at: {{:., [], [{:&, [], [0]}, :inserted_at]}, [], []}, updated_at: {{:., [], [{:&, [], [0]}, :updated_at]}, [], []}, name: "some name"]}

The subquery originated from the following query:

from m0 in subquery(from m0 in MySchema,
  select: merge(m0, %{m0 | name: "some name"})),
  select: m0

        (ecto) lib/ecto/repo/queryable.ex:138: Ecto.Repo.Queryable.execute/4
        (ecto) lib/ecto/repo/queryable.ex:18: Ecto.Repo.Queryable.all/3
        (my_app) ...

Actual Use-Case
My real query is obviously far more complex but I was able to reproduce it with the simple setup seen above.
In our application it's a rather complex query joining over multiple tables and excluding certain records. For this query I would like to set a certain field to a certain value.
As a workaround I'm currently specifying this value in each select clauses of the queries used in the "exclude".
Expected behavior
Using select_merge in a subquery does not raise a MatchError at runtime. Or at least raises a more descriptive error if this turns out to be impossible.

Thanks @sascha-wolf. Can you please try master quickly and let us know if the issue is still there?

@josevalim I was able to reproduce the issue with the current ecto_sql and ecto master versions. So yes, the problem persists.

Btw, wouldn't this achieve the result that you want?
query =
  MySchema
  |> select_merge([m], %{name: "some name"})
  |> subquery()

In any case, we would have to at least improve the error message.


Moving JS code from index.html to separate .js file in assets

Description of the change
Separate files makes maintenance easier. The separate code makes it easier for web browsers to cache.
Screenshots

please assign this to me so that i can make the changes.

Is this issue required to be worked over now, or is it resolved?

Is this issue required to be worked over now, or is it resolved?

@sameersrivastava13 is doing it now

Ok

Already completed.


More intelligent jumplist trimming

Give each entry a weight based upon number of items. Sort list. Then remove least used items.

Done for 4.4.0


unable to sync shadow service of service name bigger then 63 char

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
invalid: metadata.name: Invalid value: "traefik-pushprox-kube-controller-manager-proxy-6d61657368-monitoring": must be no more than 63 characters"
What did you see instead?
no workaround
What version of Traefik are you using?
2.5
What is your environment & configuration?
# (paste your configuration here)

Add more configuration information here.
If applicable, please paste the log output in DEBUG level
k8s

Hello @korenlev and thanks for your interest in Traefik mesh,
The issue you are facing is a duplicate of #746 which has been addressed by #772. As this is a breaking change the fix is only available on master. In the meantime, you may want to use the ignoreNamespaces or watchNamespaces configuration options to exclude namespaces containing services which should not be meshed.
According to this, we will close this issue as a duplicate.


file-loader ouputting corrupted images

Am using the latest file-loader. It's outputting the files to images/css-urls like specified but they're corrupted images.
The config is searching through the sass files and replacing urls with new files that file-loader outputs. That part works, but the files are corrupted.
const ExtractTextPlugin = require("extract-text-webpack-plugin");
const extractSass = new ExtractTextPlugin("./bundle.css");

var mainConfig = {
  entry: {
    "app": [
      "./app/main.ts",
      "./static/scss/main.scss",
    ],
    "vendor": "./app/vendor.ts",
    "polyfills": "./app/polyfills.ts",
  },
  output: {
    path: path.resolve(__dirname, "static"),
    filename: "[name].js"
  },
  resolve: {
    extensions: [".ts", ".js"],
  },
  devtool: "source-map",
  module: {
    rules: [{
      test: /.*\.(gif|png|jpe?g|svg)$/i,
      use: [
        {
          loader: 'file-loader',
          options: {
            name: '[name].[hash].[ext]',
            outputPath: 'images/css-urls/',
          }
        },
      ]
    }, {
      test: /\.(scss|css)$/,
      use: extractSass.extract({
        use: [{
          loader: "css-loader",
        }, {
          loader: "sass-loader",
        }],
        // use style-loader in development
        fallback: "style-loader"
      })
    }, {
      test: /\.(png|jpg|gif|svg|eot|ttf|woff|woff2)$/,
      loader: "url-loader",
    }, {
      test: /\.ts$/,
      loaders: [
        {
          loader: "awesome-typescript-loader",
          options: { configFileName: root("./", "tsconfig.json") }
        } , "angular2-template-loader"
      ]
    }, {
      test: /\.html$/,
      loader: "html-loader"
    }]
  },
  plugins: [
    extractSass,

    new webpack.ContextReplacementPlugin(
      // The (\\|\/) piece accounts for path separators in *nix and Windows
      /angular(\\|\/)core(\\|\/)@angular/,
      root("./app"), // location of your src
      {} // a map of your routes
    ),

    new webpack.optimize.CommonsChunkPlugin({
      name: ["app", "vendor", "polyfills"]
    }),

  ]
}

@avoliva file-loader do not anything with original content of file. You have invalid configuration test: /.*\.(gif|png|jpe?g|svg)$/i, and test: /\.(png|jpg|gif|svg|eot|ttf|woff|woff2)$/,, i.e. two loader handle same types. url-loader use file-loader as fallback when file size bigger than urlLimit.

That worked, thanks.


can that NoVNC in Browser dispaly the "vm hostname"?

can that NoVNC in Browser dispaly t
he "vm hostname"? When we using zstack management UI.
current show out the states please refer to attached picture 001. Thanks

Tracked in https://github.com/zstackorg/zstack-dashboard/issues/58 . So close this issue.


docs, normalize, more tests

hm.. okey, but whats the difference between this and template-helpers - only the name?
It seems that you like to duplicate libs, lol.
you can use this lib in same way
template.helper('isArguments', utils.lang.isArguments);

hm.. okey, but whats the difference between this and template-helpers - only the name?

no, big difference. In templates, you generally want to return a string, regardless of the type.

you can use this lib in same way

yeah, there might be opportunities to use some of these in template-helpers, but... I don't want to force that "just to do it". they both have a different purpose.

can you update so I can merge? thx!

what to update? I seems I miss something in discussion?

sorry, I meant to just pull down the latest and merge it in, then push back up

hmm.. I'll try, dont like merging so much lol

@jonschlinkert doh that's it? lol
for me merging is bad thing and I avoid to use it.
most used daily, lol
gac 'commit message' // git add && git commit
gp // git push
...
gb // git back && git push -f

closed by https://github.com/jonschlinkert/utils/commit/ec298962761c8e4521ed296b75f6aa145416eb1a


smart-contract event decode

Current behavior
smart-contract.py
Event on calling Storage.Put
get:
Could not persist block 'str' object has no attribute 'decode'
for the command line:
logger.info("- payload part 1: %s", event.event_payload[0].decode("utf-8"))
content of event.event_payload[0] is b'\x01 -> bytearray(b'Tim')

Your environment

OS: Ubuntu
neo-python version: 0.6.6
Python version: 3.6

Can you provide code and steps to reproduce?

actually looking closer at your screenshot I now realise that event_payload[0] does not hold
b'\x01 -> bytearray(b'Tim') but it holds "b'\\x01 -> bytearray(b'Tim')". Notice the quotes around the bytearray, that means it's a string and then yes the error makes sense. string does not have a decode() method


Limit the number of paths returned from local assembly

It is not very helpful/useful if the number of paths we return from local assembly is massive. Ideally, we only want a handful of paths.
There are a couple of options:

Set a hard threshold on the number of paths we allow local assembly to generate. One downside to this is the paths you end up with are essentially in a random order. i.e not the necessarily the most "likely" paths.
Set a threshold for the number of paths (as above) and if a slice hits this threshold, rerun local assembly but have a harder requirement on coverage on each kmer (i.e increase g_covg_scaling_factor)

Another option is set a hard limit and if you hit it, abort and ignore that slice. Which I quote like as a first step


Warning doesn't make sense

/home/ionel/.cache/pre-commit/repo4uc6wwmz/py_env-python3.8/lib/python3.8/site-packages/isort/settings.py:312: UserWarning: `known_thirdparty` setting is defined, but not THIRDPARTY is not included in `sections` config option: ('FUTURE', 'STDLIB', 'THIRDPARTY', 'FIRSTPARTY', 'LOCALFOLDER').
  warn(

I don't get what's with the double negation over there. Can this be rephrased in plain English?

I agree the warning makes no sense! I'll work on fixing the wording before the next release, in the meantime the issue is that the setting is known_third_party not known_thirdparty as noted in the documentation here: https://github.com/timothycrosley/isort/#custom-sections-and-ordering. known_thirdparty has never been a setting, so if categorization is working as intended, likely it just needs to be removed from your config.


Clean up window code

setting text input for example must not have multiple implementations lol, perhaps related to #109?

merged into #109


[FEATURE] Add a node to a remote cluster

Is your feature request related to a problem or a Pull Request
N/A
Scope of your request
To mirror the capabilities exposed by k3s, I'd like to be able to run k3d as an "agent only" configuration.
In my situation, I have a Linux machine running the k3s server natively, and I'd like to be able to run k3d to run an agent which can be added to the k3s server running elsewhere.
Additional context
To explain this a little more, I've got the following setup:

Raspberry Pi 4B running the k3s server
Macbook I'd like to run as a k3d agent

The reason for this is I'm trying to reduce the overall number of pods running on my Macbook (as Docker for Mac is making my dev experience incredibly painful due to heavy CPU usage). As such, I've started running k3s on a Raspberry Pi to shift those workloads off my dev machine. Some workloads don't have arm64 images so I still need to run some workloads on AMD64 arch (hence the desire to run k3d as an agent only).
For what it's worth, this works perfectly if I run k3d as the server on my Macbook, and k3s as an agent on the Raspberry Pi. Everything connects up and all is great, but I'd prefer to avoid running the k8s control plane in k3d to keep the pods running in k3d as low as possible.
Describe the solution you'd like
Given a k3s server running elsewhere (either via k3d or k3s natively) I'd like to be able to run k3d to create another agent to connect to that remote k3s server.
Something like
k3s create node newk3dnode --cluster=<remote-k3s-cluster>
Obviously, this doesn't work yet as if I have a k3s server running elsewhere my local k3d environment knows nothing about it.
Describe alternatives you've considered
As described above, I can run k3d as a server and run a native k3s agent elsewhere to connect to this cluster. But I'd like to do the reverse: run a k3s server elsewhere and run k3d to connect as a node to that cluster.

Hi @cjheppell , thanks for opening this issue and sorry for not getting a reply in that long time.
The feature is implemented in #734 and will be released in the upcoming major v5.0.0 release (and also in the next alpha/beta release before that). :+1:


I am providing my own CNI network configuration plugin. For test purposes, I forced it to fail when setting up a network, causing rkt to fail to start pods. I then ran `sudo rkt gc --grace-period=0s" expecting the network to be cleaned up.
What did you expect to see?
I expected the plugin to be invoked with CNI_COMMAND=DEL and for the network namespace created for the pod by rkt to be destroyed.
What did you see instead?
The plugin is not invoked at all. After running the container, ip netns still shows a couple cni- namespaces, previously created by rkt.
This causes rkt to leak network namespaces, and what's worse, means some cleanup steps that normally run in my plugin's delete command don't get to run.

@tgeoghegan This should be fixed with later rkt version. Have you tried the latest (1.13.0) ?

Reference: https://github.com/coreos/rkt/pull/2696

I tried this with rkt 1.13.0 (from the tar.gz at https://github.com/coreos/rkt/releases/tag/v1.13.0) and it still reproduces. Besides using a newer rkt and stage1-coreos.aci, my environment is otherwise unchanged from the original issue.
core@localhost ~ $ rkt-v1.13.0/rkt version
rkt Version: 1.13.0
appc Version: 0.8.6
Go Version: go1.6.3
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL
core@localhost ~ $ sudo rkt-v1.13.0/rkt --dir /home/core/rktdir list
UUID	APP	IMAGE NAME	STATE	CREATED	STARTED	NETWORKS
core@localhost ~ $ ip netns
core@localhost ~ $

For this experiment, I'm using a temporary rkt dir to avoid tainting my "real" one at /var/lib/rkt. To start out with, no pods running and no network namespaces. Now, start a pod that is doomed to fail: /etc/rkt/net.d/broken-net.conf has "type": "nosuchnetwork", and /etc/rkt/net.d/nosuchnetwork is hard-coded to fail in its add command.
core@localhost ~ $ sudo rkt-v1.13.0/rkt run --insecure-options=image --dir /home/core/rktdir --stage1-path=/home/core/rkt-v1.13.0/stage1-coreos.aci --net=broken-net nc.aci
image: using image from file /home/core/rkt-v1.13.0/stage1-coreos.aci
image: using image from file nc.aci
networking: loading networks from /etc/rkt/net.d
networking: loading network broken-net with type nosuchnetwork
stage1: failed to setup network: artificial failure
core@localhost ~ $ sudo rkt-v1.13.0/rkt --dir /home/core/rktdir list
UUID		APP	IMAGE NAME	STATE	CREATED		STARTED	NETWORKS
8a7daa2d	nc	nc		exited	7 seconds ago
core@localhost ~ $ ip netns
cni-51e96fae-dd01-d5e4-c7f9-d44cc9b80699

Starting the pod failed (as expected), leaving us with a pod in the exited state and the network namespace rkt created for it. So far, so good. Let's run gc.
core@localhost ~ $ sudo rkt-v1.13.0/rkt --dir /home/core/rktdir gc --grace-period=0s
gc: moving pod "8a7daa2d-4bc0-4cfd-be57-3f5b97589e33" to garbage
Garbage collecting pod "8a7daa2d-4bc0-4cfd-be57-3f5b97589e33"
stage1 gc: error cleaning up cgroups: open subcgroup: no such file or directory
core@localhost ~ $ sudo rkt-v1.13.0/rkt --dir /home/core/rktdir list
UUID	APP	IMAGE NAME	STATE	CREATED	STARTED	NETWORKS
core@localhost ~ $ ip netns
cni-51e96fae-dd01-d5e4-c7f9-d44cc9b80699

When running gc, we see no attempt to invoke the nosuchnetwork plugin. Further, while gc succeeds and removes the exited pod, the network namespace is still there.
Am I doing it wrong? Perhaps my experimental setup is a bit janky. Is there something besides the rkt binary and stage1.aci I need to update?

@tgeoghegan This seems like a different issue from before. I am trying to see if I can reproduce it on my machine, thank you for reporting!

Right, I can observe this on 1.13.0 too. @squeed can you have a look at what's going on here?
I also see the "no subcgroup file/dir" which I think is benign here, but no "networking: teardown" at all.
/cc @steveeJ

@squeed do you think you can tackle this in the next release? I am bumping for now.

Does this relate to #2804?

Does this relate to #2804?

Yes, they seem like the same issue.

@squeed do you think you can tackle this for the next release? Bumping until then.

Taking a look at this. Related discussion is in containernetworking/cni#309 - the DELETE CNI command should probably never error.

Nevermind, not a CNI problem. Just needed better checkpoint logic.

Bumping to 1.19 - the code is done, but it needs review.


Can't connect to pufferpanel via FileZilla

I'm trying to add a modpack to my server but when i try to connect via FileZilla it displays this:
Status:	Connecting to localhost:5657...
Status:	Using username "(The username in the SFTP Information tab in pufferpanel)"
Status:	Access denied
Error:	Authentication failed.
Error:	Critical error: Could not connect to server
I used the correct password and used the username displayed in SFTP Information.

Send the FileZilla inputs you used @Neonyyy


USDp rounding numbers

When paying an invoice, the USD value of the invoice when switching to USDP balance is rounded up, thus it can be confusing
Example here
I think this could be fixed by displaying the digits after the decimal point when using dollar value invoice amount.

I think this could be fixed by displaying the digits after the decimal point when using dollar value invoice amount.
Not sure if this will fix it.

I think we should show the in big bold letters the sats amount you are paying and in smaller letters the estimated USD amount.

This will get better once we have fractional dollar amounts which will be introduced with #1729


Phone number input component with masking & text-field validations

Closes #20 & #29

Also includes some refactoring to make email and phone number extend the TextField component

There are merge conflicts you need to resolve, otherwise this looks good. You could probably refactor handleEvent() but that's minor. Also this probably stomps all over #48 but I'll deal with that once this is merged.

LGTM 👍


Integrate cvat infrastructure into Weed-AI docker compose

Clone from my forked version https://github.com/Weed-AI/cvat/tree/usyd
Build cvat-ui using docker-compose build --no-cache cvat_ui
Run COMPOSE_HTTP_TIMEOUT=500 docker-compose -f docker-compose-dev.yml up to start Weed-AI
Go to localhost/cvat-annotation to use cvat

Please check if the readme needs updating

Okay. I wonder if the CVAT build stuff should be up the top

Yeah that is much better for quick setup and testing.
Do we have to include cvat as a sub dir instead of a sub module to achieve that?

Do we have to include cvat as a sub dir instead of a sub module to achieve that?

I'm not sure why we'd need to?

Now working on branch with git submodule


MinPathSum.cpp

Related Issue
#686
Proposed Changes

Change 1
Chnage 2

Checklist

[x] ✅ My code follows the code style of this project.

[ ] 📝 My change requires a change to the README.

[ ] 🎀 I have updated the README accordingly.

[x] 👀 I have read the CONTRIBUTING document.

[x] ✨ I have added tests to cover my changes.

[x] 🚩 All new and existing tests passed.

[x] 🌟 ed the repo
       It is dynamic progamming problem which calcultes min sum path from given grid.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Output Screenshots
| Screenshot #1      | Screenshot #2  |

Make sure your Pull Request is descriptive and complete the checklist .
I would recommend you to go through this tutorial video of the project here ,thanks.
///------------------Description -----------------------///
For contribution and more guidelines i would recommend you to go through this
tutorial video of the project here, thanks.
///------------------Description -----------------------///
Let me show you how to check the check list , there should be no space inside brackets like [x]
[x]

[x] Checklist
[ ] Or you can just check them from outside without doing any of these
[x] ✨ I have added tests to cover my changes.
[x] 🚩 All new and existing tests passed.
[ ] 🌟 ed the repo

Starr the repo if you haven't !
Have you watched this video ?

@Lakhankumawat  i have updated the readme in the pull request number (# 836)
kindly do check

@Lakhankumawat i have updated the readme in the pull request number (# 836) kindly do check

Try to do it in the same pr


have bst-track be able to update tar sources

See original issue on GitLab
In GitLab by [Gitlab user @christopherphang] on May 26, 2020, 21:32
Background
Currently bst-track is most useful for git and git_tag sources, which allows implementation of updaters such as https://gitlab.com/BuildStream/infrastructure/gitlab-merge-request-generator
In libreML and freedesktop-sdk there are a number of elements that have tarball sources, that bst-track does not currently work on. It would be good to be able to update those sources.

In GitLab by [Gitlab user @nanonyme] on May 26, 2020, 21:42
I think this fundamentally boils down to what is bst track supposed to do for tarball sources. Currently

You have single URL and upstream replaces it with new versions every time. In this case calling track will update to a newer version (same as with git source) but reproducible builds is a no-go
Every build has different URL. In this case track will update the checksum but it will never update to a newer version so there's completely different semantics as with git sources.

In GitLab by [Gitlab user @nanonyme] on May 26, 2020, 21:47
If there's desire to have actual tracking of new versions for tarball sources, there's some catches like that there's no single obvious way to figure out new versions. Eg Flathub has implemented as part of https://github.com/flathub/flatpak-external-data-checker separately support for the previously mentioned URL types. (if URL is not rotating, some mechanism of web crawling needs to be done to discover further tarballs) In addition to this version information must be somehow extractable from the URL so version comparisons can be done.

In GitLab by [Gitlab user @christopherphang] on May 26, 2020, 21:48
Some documentation on how debian/watch do things: https://wiki.debian.org/debian/watch

In GitLab by [Gitlab user @cs-shadow] on May 26, 2020, 22:17
[Gitlab user @christopherphang] can you please clarify what you mean by bst-track being able to update tar sources?
bst track should definitely be able to track URLs in its current implementation. If that's not working for some reason, that would be a bug. (The current implementation is supposed to update the ref in case the URL returns a new file.)
Or, are you saying that it should "find" new versions of tarballs somehow? If so, I think that should be a different plugin. Especially since it's difficult to solve this in a generic way that'll work for everyone in a deterministic way.

In GitLab by [Gitlab user @nanonyme] on May 26, 2020, 22:27
[Gitlab user @cs-shadow] would you suggest that consumers who expect bst track will update to newer releases of things would then migrate away from tarball plugin to a separate source plugin that would do the desired thing when using using track (similar to how git has now diverged to git_tag)?

In GitLab by [Gitlab user @cs-shadow] on May 26, 2020, 22:56
I was trying to first understand whether this was a bug for existing track functionality, or a new feature request. I suppose it's the latter based on your last comment. Given that, I think redirecting this discussion to the mailing list will be more appropriate.
I'll leave my 2 cents below.
In my opinion, there's nothing special about tar here. The new releases may as well be zips, debs, single files etc. So, regardless of how this is implemented, I don't think there should be anything special for tar in particular. This should probably be implemented at the level of DownloadableFileSource, which is the base class for all these base plugins.
Regarding whether there should be a separate plugin, or we should expand the functionality of the current plugin, I'm leaning towards the former. All the reasons for git_tag being separate still apply here. If anything, dealing with URLs is probably harder compared to git tags, since there is even less defined structure there.

In GitLab by [Gitlab user @nanonyme] on May 27, 2020, 06:40
[Gitlab user @cs-shadow] yes, it's definitely a harder use case thn git and consumer almost certainly needs to be able to pass additional metadata on how tracking should work. That said, this metadata would likely be common for all DownloadableFileSource items.

In GitLab by [Gitlab user @jjardon] on Jun 5, 2020, 12:12
marked this issue as related to freedesktop-sdk/freedesktop-sdk#1052

In GitLab by [Gitlab user @tristanvb] on Nov 6, 2020, 09:07
This was brought up years ago too, from what I recall the main issue here is that we need different tracking strategies depending on how the tarball is hosted. Some servers, e.g. historically sourceforge, have different APIs for discovering new releases or performing directory listings.
This might lead to different tar plugins for different hostings, or wrapping up all implementations into one tar source - another interesting question is what happens when we throw mirrors into play, which might be hosted differently.


Level 16: Should we check the grid-column-end property more precise?

The grid-column-end property is matching for all values which are greater than 5. Should we define only one matching value?

Hey @duyphanz, I see your point that it should be more precise, but this is how CSS grid works if you try it for yourself.

It's great to hear that. Thanks @thomaspark


Migrating from MODS to Linked Data RDF

Migrating from MODS to Linked Data RDF
Suggested by: Steven Anderson
Presenter: Members of the MODS and RDF Descriptive Metadata Subgroup
Format: Presentation
Audience: Developers and Metadata folks

Or lightning talk? + breakout?  Yes


Feature Request: Plugin support for onConversionDataReceived

Thank you for providing this valuable plugin. Would it be possible to add support for onConversionDataReceived?
We'd like to be able to track this campaign information for installs in our own system as well.
It appears some support is enabled in the AppsFlyerPlugin.m, but not in the plugin's js. I tried to add it on my own but I was running into a lot of native errors on a Main.m file after that.

@gylippus hi, please take a look on example: https://github.com/AppsFlyerSDK/cordova-plugin-appsflyer-sdk/blob/master/examples/demoA/www/js/AppsFlyer/AfController.js#L98.
You can provide onInstallConversionDataListener: true and you will get onGetConversionDataReceived callback as 2nd parameter of initSdk.
See: https://github.com/AppsFlyerSDK/cordova-plugin-appsflyer-sdk/blob/master/examples/demoA/www/js/AppsFlyer/AfController.js#L108-L124


no type named 'ExternalAsciiStringResource' in 'v8::String'

I can't install term2 on my new mac,
Atom v0.177.0
OS X 10.10.2
XCode 6.1.1(6A2008a)
><EMAIL_ADDRESS>install /private/var/folders/05/lbfncb6x4_s1gxryqnr6yyn80000gn/T/apm-install-dir-115110-700-poea8n/node_modules/term2/node_modules/pty.js
> node-gyp rebuild

  CXX(target) Release/obj.target/pty/src/unix/pty.o

In file included from ../src/unix/pty.cc:16:
../node_modules/nan/nan.h:67:21: error: no type named 'ExternalAsciiStringResource' in 'v8::String'; did you mean 'ExternalStringResource'?
typedef v8::String::ExternalAsciiStringResource
        ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
                    ExternalStringResource
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1936:19: note: 'ExternalStringResource' declared here
  class V8_EXPORT ExternalStringResource
                  ^
In file included from ../src/unix/pty.cc:16:
In file included from ../node_modules/nan/nan.h:74:
../node_modules/nan/nan_new.h:164:26: error: class member cannot be redeclared
  static inline return_t New(NanExternalOneByteStringResource * value);
                         ^
../node_modules/nan/nan_new.h:163:26: note: previous declaration is here
  static inline return_t New(v8::String::ExternalStringResource * value);
                         ^
In file included from ../src/unix/pty.cc:16:
In file included from ../node_modules/nan/nan.h:74:
In file included from ../node_modules/nan/nan_new.h:190:
../node_modules/nan/nan_implementation_12_inl.h:222:22: error: redefinition of 'New'
Factory<v8::String>::New(NanExternalOneByteStringResource * value) {
                     ^
../node_modules/nan/nan_implementation_12_inl.h:217:22: note: previous definition is here
Factory<v8::String>::New(v8::String::ExternalStringResource * value) {
                     ^
In file included from ../src/unix/pty.cc:16:
In file included from ../node_modules/nan/nan.h:74:
../node_modules/nan/nan_new.h:319:1: error: redefinition of 'NanNew'
NanNew(NanExternalOneByteStringResource * value) {
^
../node_modules/nan/nan_new.h:313:1: note: previous definition is here
NanNew(v8::String::ExternalStringResource * value) {
^
In file included from ../src/unix/pty.cc:16:
../node_modules/nan/nan.h:1790:17: error: no member named 'GetExternalAsciiStringResource' in 'v8::String'; did you mean 'GetExternalOneByteStringResource'?
    return str->GetExternalAsciiStringResource();
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                GetExternalOneByteStringResource
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:2003:40: note: 'GetExternalOneByteStringResource' declared here
  const ExternalOneByteStringResource* GetExternalOneByteStringResource() const;
                                       ^
In file included from ../src/unix/pty.cc:16:
../node_modules/nan/nan.h:1790:12: error: cannot initialize return object of type 'const NanExternalOneByteStringResource *' (aka 'const v8::String::ExternalStringResource *') with an rvalue of type 'const v8::String::ExternalOneByteStringResource *'
    return str->GetExternalAsciiStringResource();
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../node_modules/nan/nan.h:1800:17: error: no member named 'IsExternalAscii' in 'v8::String'; did you mean 'IsExternal'?
    return str->IsExternalAscii();
                ^~~~~~~~~~~~~~~
                IsExternal
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1900:8: note: 'IsExternal' declared here
  bool IsExternal() const;
       ^
In file included from ../src/unix/pty.cc:16:
../node_modules/nan/nan.h:1825:11: error: assigning to 'const char *' from incompatible type 'const uint16_t *' (aka 'const unsigned short *')
    *data = ext->data();
          ^ ~~~~~~~~~~~
../node_modules/nan/nan.h:1868:10: error: no matching function for call to 'Encode'
  return node::Encode(
         ^~~~~~~~~~~~
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/src/node.h:272:34: note: candidate function not viable: cannot convert argument of incomplete type 'const void *' to 'const char *'
NODE_EXTERN v8::Local<v8::Value> Encode(v8::Isolate* isolate,
                                 ^
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/src/node.h:278:34: note: candidate function not viable: requires 3 arguments, but 4 were provided
NODE_EXTERN v8::Local<v8::Value> Encode(v8::Isolate* isolate,
                                 ^
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/src/node.h:283:45: note: candidate function not viable: requires at most 3 arguments, but 4 were provided
                inline v8::Local<v8::Value> Encode(
                                            ^
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/src/node.h:64:53: note: expanded from macro 'NODE_DEPRECATED'
#define NODE_DEPRECATED(msg, fn) V8_DEPRECATED(msg, fn)
                                                    ^
/Users/Learning/.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8config.h:329:45: note: expanded from macro 'V8_DEPRECATED'
# define V8_DEPRECATED(message, declarator) declarator
                                            ^
9 errors generated.
make: *** [Release/obj.target/pty/src/unix/pty.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.1.0
gyp ERR! command "node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /private/var/folders/05/lbfncb6x4_s1gxryqnr6yyn80000gn/T/apm-install-dir-115110-700-poea8n/node_modules/term2/node_modules/pty.js
gyp ERR! node -v v0.10.35
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok
npm ERR! Darwin 14.1.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Applications/Atom.app/Contents/Resources/app/apm/.apmrc" "--userconfig" "/Users/Learning/.atom/.apmrc" "install" "/private/var/folders/05/lbfncb6x4_s1gxryqnr6yyn80000gn/T/d-115110-700-kxmpt1/package.tgz" "--target=0.21.0" "--arch=x64"
npm ERR! node v0.10.35
npm ERR! npm  v2.3.0
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the pty.js package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls pty.js
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/05/lbfncb6x4_s1gxryqnr6yyn80000gn/T/apm-install-dir-115110-700-poea8n/npm-debug.log

Same here.

+1 same issue

Also getting this.

+1 Same issue.

For the rest of us :+1:ing this issue, there is a far more robust conversation regarding the same issue in #90. Can someone with access close this issue in favour of that one?

👍


Write the README

Replace the template information with the website's related informations.

Closed with https://github.com/ToniMaunde/miltondavid-with-astro/commit/be1bb0867a3bdb63e2254d0eb6031415805eb00d.


Refactor Telemetry tests "IsKindCluster" function

Please provide a description of this PR:
Follow up for https://github.com/istio/istio/pull/54392 and https://github.com/istio/istio/pull/54488
Focusing on the following suggestion: https://github.com/istio/istio/pull/54392#discussion_r1890491152
The "isKindCluster" function used to detect if the cluster during the test is of "Kind" type or any other cluster type - vanilla Kubernetes or Openshift.
Move the "isKindCluster" function under the
"(resource.Context).Clusters()" to be available as "(resource.Context).Clusters().IsKindCluster()"

Hi @MaxBab. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Allow 'Copy Selected Topic' button when action is Action.CREATE

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
"Copy selected topic" is enabled without Action.CREATE, So I disabled the button when user's action is not in Action.CREATE

Changed Button to ActionCanButton
Add Permission on button action

Is there anything you'd like reviewers to focus on?
No
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[x] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

It is a bug that user cannot delete but can copy with same Action Permission

Hi, thanks for the contribution!
I've been digging for a few minutes why don't we have this setup already, it turns out (#3563):

/clone endpoint has never been used on the frontend
params are not copied once you copy the topic

Basically, the clone topic should require both VIEW and CREATE permissions, but we can keep it as is for now, until we're at #3653.
@Mgrdich fyi


[LAB3] 111550065

Description

test calculator class functions full coverage
test with parameterization and throwing errors

https://github.com/SQLab/112-spring-software-testing/pull/2

[ ] A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
[ ] A meaningful message for PR, as well as its commits
[ ] From your specific branch (not main or other's branch) merging to your branch
[ ] Excluding any irrelevant files, such as binaries, text files, or dot files
[ ] Passing all CI (You should check it first to pass one of the validations in CI. However, you need to make sure your PR passes all CI after you submit it.)

wrong branch out from my fork -_-


Memory Leaks on IE/Edge

I don't know why but running this I encountered serious memory leaks in IE and Edge.
Please fix this

Please try in Opera, it's working fine for me

I can't .. I need to support IE, because my clients are using it.


Update ultimate.py

fix unfollow everyone except friends job

Job8 works the exact same if you have a whitelist in the folder. All you have to do is put the whitelist in ultimate_schedule folder.

job6 and job8 is diffrent.if changes revert to back script work very good.


Stuck on box chat

hellow.. I've tried using your script. but the chat column does not appear perfect. so I can't try writing in the chat column.

please check.. thanks

It seems like you have a bottom navigation bar that block the chatbox. You need to add bottom padding.


The Corpus of Oz Early English (COOEE)

Description: Focuses on early Australian English, including recordings of speech.
Access: Available through academic and research institutions.

Thank @Xinyu990511 for transforming them into JSON files and data cleaning 😊
All JSON files have been transformed into CSV files and cleaned. The combined CSV file is only uploaded on Hugging Face.
The repo is now set to inactive. Will reopen if it has any further demands.

Start to working on COOEE

Finished cleaning. Uploading to Hugging Face.

Uploaded to Hugging Face. Now change it to inactive,


Bug: BezierCurve and Polygon classes move to 0,0 when position set

Summary
If the position property of BezierCurve or Polygon are set after creation, they will "teleport" toward 0,0
Steps to replicate

Have a pyglet 2.0 version installed (master branch used as reference)
Download this visualization utility from gists
Run it
Click and hold inside the window
Drag the origin to be visible by moving the cursor toward the upper right
Release
Observe: BezierCurve and Polygon have teleported toward the origin

Before movement
After Movement

Root Cause

Most shapes use the _x and _y attributes set by the position setter inside _update_vertices
BezierCurve and Polygon use their internal first point as the offset instead

This is fixed in master and development by https://github.com/pyglet/pyglet/commit/9ee50f8df83ef8b770db1314fb32495490b8e146. We can close the issue on 2.0.10's release.

Closing this since 2.0.10 is released.


Add logOutput option

Initial POC for #232.
Also added editorconfig for easier work from contributors.

Coverage decreased (-0.3%) to 79.581% when pulling 31d8d073e93c6e85f4a96395dee8e94fa5f53118 on avrelaun:master into deac91e80087b44bf70a3b651ed22a2d242c932a on glenjamin:master.

Coverage decreased (-0.3%) to 79.581% when pulling 31d8d073e93c6e85f4a96395dee8e94fa5f53118 on avrelaun:master into deac91e80087b44bf70a3b651ed22a2d242c932a on glenjamin:master.

Apparently this was useless, since passing quiet=true to the client parameters disable the output on the devtools console, while keeping it on the server...


Alert words: Fix content overflow out of alert item box

The Delete icon on alert word list overflows out of the alert word card.
So fix it with appropriate height property.

fixes: #14910

@YashRE42 can you help review this?

@sumukhah what happens if the word goes longer than 2 lines? Say 4 or even 5 lines lontg. Could you check it out please?

@sumukhah what happens if the word goes longer than 2 lines? Say 4 or even 5 lines long. Could you check it out please?

I think at present alertword having length more than 100 words will not be allowed.

@sumukhah what happens if the word goes longer than 2 lines? Say 4 or even 5 lines long. Could you check it out, please?

Should I increase the alert word list width for the mobile view?

I think you should go ahead with this although a confirmation on the chat will always be better because this is an outlier case and the current fix doesn't look that bad.

Final styling looks like

for smaller devices,

for normal screen

This PR needs a rebase; sorry we missed this when doing reviews last summer @sumukhah!
I imagine someone currently active will pick this up (posted in #frontend to try to arrange that) so that we can close this out.

The original issue here was fixed in https://github.com/zulip/zulip/pull/17203/files.


Bump minidump<EMAIL_ADDRESS>

Description of the change
Resolves the mindump issues on MacOS and Linux for Electron 9 in https://github.com/atom/atom/pull/21777
Verification
I fixed minidump's building for MacOS and Linux in my fork:

The submodules were not being instantiated and built correctly.
MacOS files were not included in the build script

My fork: https://github.com/aminya/node-minidump
I have made a PR to the original package, but it may take some time until they merge it, so I have registered it with my name temporarily.
https://github.com/electron/node-minidump/pull/40
Release Notes
N/A

MacOS executable is not found. I don't have a Mac machine to test build and test this.
Can someone on Mac run npm install in my fork and see what is the name of the executable under build/src/tools/mac/dump_syms/
https://github.com/aminya/node-minidump/tree/%40aminya/minidump

Did an npm install  on Mac.
        └── mac
            └── dump_syms
                └── .deps
                    └── src_tools_mac_dump_syms_dump_syms_mac-dump_syms_tool.Po

Thanks! Does it actually build the executable? Is this file readable or it is an executable file?

The file is readable and not an executable file.
-rw-r--r--  src_tools_mac_dump_syms_dump_syms_mac-dump_syms_tool.Po

Contents
# dummy

I am setting up a virtual machine to troubleshoot the issue.

I didn't realize that is so hard to set up a Mac virtual machine. I'm afraid I cannot troubleshoot the build script. The original developers at Electron also have not responded.
Should we just disable minidump for Mac instead?

@sadick254 MacOS error is fixed now. If you want you can merge my fork now, or wait until my PR merges into node-minidump.

@aminya Thank you for looking into this.

Very brief summary of this comment: This PR changes the build requirements for Atom. Is there a benefit to using newer minidump? If not, can we please strongly consider reverting this? Thank you.

Hi folks. I should have raised this here earlier, but this PR changes the build requirements of Atom on macOS.
This changes the requirement from "either the command line tools OR XCode", to strictly requiring XCode. So at minimum it will require changes to the docs at Hacking Atom Core in the Flight Manual.
I was hoping this would be resolved upstream, but it wasn't.
I personally prefer to use the lighter "command line tools", so I was personally hoping this would not be merged to master of Atom, and reverted in the Electron 9 PR.
I notice this updated minidump package makes smaller package-name.node symbol dumps. Are they better-quality somehow? Or does it impact debugging performance in some way? (Is there a technical benefit to using the newer minidump package?) As I recall this ended up having no impact on the error we were trying to get rid of in the Electron 9 PR.
Does this have a benefit that outweighs the downside (increasing build requirements on macOS, and requiring a follow-up PR for documentation?

Very brief summary of this comment: This PR changes the build requirements for Atom. Is there a benefit to using newer minidump? If not, can we please strongly consider reverting this? Thank you.

Hi folks. I should have raised this here earlier, but this PR changes the build requirements of Atom on macOS.
This changes the requirement from "either the command line tools OR XCode", to strictly requiring XCode. So at minimum it will require changes to the docs at Hacking Atom Core in the Flight Manual.
I was hoping this would be resolved upstream, but it wasn't.
I personally prefer to use the lighter "command line tools", so I was personally hoping this would not be merged to master of Atom, and reverted in the Electron 9 PR.
I notice this updated minidump package makes smaller package-name.node symbol dumps. Are they better-quality somehow? Or does it impact debugging performance in some way? (Is there a technical benefit to using the newer minidump package?) As I recall this ended up having no impact on the error we were trying to get rid of in the Electron 9 PR.
Does this have a benefit that outweighs the downside (increasing build requirements on macOS, and requiring a follow-up PR for documentation?

As mentioned above, this PR gives me an error when bootstrapping:
Error message (click to expand):
% script/bootstrap
Node:	v12.20.1
Npm:	v6.14.8
Python:	v2.7.16
Installing script dependencies
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `node build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/[user]/.npm/_logs/2021-02-01T19_01_47_483Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/[user]/.npm/_logs/2021-02-01T19_01_49_169Z-debug.log
child_process.js:656
    throw err;
    ^

Error: Command failed: /Users/[user]/atom/script/node_modules/.bin/npm --loglevel=error install
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: `node build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/[user]/.npm/_logs/2021-02-01T19_01_47_483Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>postinstall: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!       Or can someone provide a strong reason why this PR is actually needed? (One that makes this PR worth the downside of changing the build requirements of Atom? Again, properly documenting this change would require a PR over at the Flight Manual repo. I'd rather not have the build requirements change and update the docs if it's not providing a substantial and well-understood benefit.)

Instead of removing features, we can rebuild minidump. Setting up a CI for building the executable is not that hard.

My suggestion is toward using an older version of this package (0.9.0), which used to work on macOS just fine, but with the benefit of having easier-to-meet build requirements.
It also used an older version of Google's breakpad, but I'm not clear on the difference or benefit there, if there is any benefit to newer breakpad. My suggestion is arguably a "sidegrade" toward an equivalent solution, rather than a meaningful downgrade. Without being able to describe the benefit of the newer minidump version, I am inclined to focus on its downside.

I already made a PR for prebuilding minidump:
https://github.com/electron/node-minidump/pull/42
Without my prebuild PR, the downside only affects a small demographics. The developers who want to build Atom locally and are on macOS and do not want to install XCode.

So I want to at least attempt to look at the pros and cons here.
This main Atom repo only uses the minidump package in script/lib/dump-symbols.js.
This file is in turn only used by script/build to dump some symbols in out/symbols.
And finally the only obvious place I see these being "used" is compressing them and uploading them as an artifact in CI/for releases. atom-mac-symbols.zip. What are these artifacts used for? Does anyone need these files? What is the use case/ how many people are using these?
If no-one is using this zipped symbol dump archive, then having newer minidump in this repo is pointless. If it's almost nobody, then it's almost pointless. And so on. I'd like to know what the atom-mac-symbols.zip is actually used for, if anything.

Symbol dumping was added without any apparent explanation in the (enormous) CI refactoring PR. (That giant 212-commit PR that moved the build scripts away from Grunt to using plain JS scripts.)
https://github.com/atom/atom/commit/ce8c86362f434ce2bb21115860f48d176477506b --> https://github.com/atom/atom/pull/12410
I checked the flight manual, and these symbols are not mentioned anywhere. So their use and purpose is undocumented and unless someone surprises me I am willing to bet no-one knows what they are for.
In my opinion, it would be for the best to delete this feature from the build scripts if no-one knows what it's for. I am scratching my head thinking about this and I have no idea why these are published with every release. (To remove this feature, simply revert this commit:  https://github.com/atom/atom/commit/ce8c86362f434ce2bb21115860f48d176477506b).

Okay, so symbol dumping was actually added here: https://github.com/atom/atom/pull/1618
Supposedly it is useful for debugging some crashes. Per the author who added the feature, writing in a follow-up issue that never got resolved:

zcbenz commented on Sep 8, 2014
As with https://github.com/atom/atom/pull/1618, we need to implement it for Windows so we can have more information of some crashes on Windows.

In statically compiled languages (in contrast to interpreted and JIT languages), the stack traces and error messages require symbols to be included with the binaries, so in case of an error or crash, the error message points to the original code location. Without symbols debugging any binaries is impossible.

Thanks. That's useful context. I already vaguely understood this, but it's confusing to me because they're not actually included in any of the binaries. They're just a separate release artifact. I think users would have to download the debug symbols and put them in the right place, or manually load them in their debugger.

Reading this, I think the built-in dev tools can debug the renderer process, an Chrome can now natively debug the main process: https://www.electronjs.org/docs/tutorial/application-debugging
Since this feature of Atom's build scripts is so old (2014) I believe this feature is from before Electron was separate from Atom. And before Chromium and Electron authors collaborated to make debugging easier.

#21916 fixes this.


No Retrieval on https://rom1504.github.io/clip-retrieval/

For several days the website doesn't seem to function at all. It won't load indexes, and by extension images. It's just empty black boxes for the indexes. Searching and waiting, no matter how patiently, doesn't result in it loading the indexes or any images.

yes, see https://github.com/rom1504/clip-retrieval/issues/324

Ah okay thank you, I hadn't seen that.


[Feature][Http] Http paramter support custom encryption

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
In http requests, users can customize encryption strings based on request parameters
Usage Scenario
Custom implementation signatures in http requests
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

please assign to me.

please assign to me.

Already assigned to you.

please assign to me.

Already assigned to you.

Has it started yet? When will it be available

It has started. I am currently working on the thesis, so my work is lagging behind.

#5727 I understand when configuration file encryption, I want http components can customize parameter encryption for oauth auth

Our understanding is a little bit wrong, I thought it was the encryption function similar to client. Let me rewrite that.

For example, https://open.taobao.com/doc.htm?docId=101617&docType=1, each request need according to the parameters, build a sign to complete validation request type, etc

Sorry, it seems that there is a big deviation in our understanding. How about I continue to do it according to my idea first, and you are looking for someone else to do it.


Implement semantic support for generic functions (was Generic function type arguments should be reified)

void test<T>() {
  print(T);
}

void main() {
  test<double>(); // prints "dynamic", should print "double".
}

This is a known limitation of the current VM.
See notes in our announcement: http://news.dartlang.org/2016/12/dart-121-generic-method-syntax.html

Is there another bug tracking this? Or are you saying this will never be fixed?
We have a customer that just ran into this problem, and it was highly confusing behavior which took a while to track down.

Hrm...well. It's a v2 issue. Can put it there. Sorry...

I just verified that the analyzer does not report a compile-time error for print(T), which is a bug. In contrast, the vm is allowed to run it and use the value dynamic, because this is a compile-time error, and hence the runtime behavior is in principle unrestricted. You could say that this program shouldn't be executed anyway. With the compile-time error from the analyzer the potential for confusion should be significantly lower.
The relevant sentence in the informal spec of this feature is the following (where X as a formal type parameter of an enclosing generic method): 'It is a compile-time error if X is used as a type literal (e.g., foo(X)), or in an expression on the form e is X or e is! X.'
I think we should change this to have area-analyzer because it is currently a bug in the analyzer, whereas the vm is actually behaving in a way which is explicitly allowed in the spec.
Come Dart 2.0 it is true that the vm will change, but that's yet another semantics: It will then have full support for generic methods, which means that the actual type arguments will be verified and should be printed, as described in the original issue.
I'll change the label to area-analyzer. @kevmoo, please speak up if you think we should handle it differently.

It would be good to have this warning in the analyzer, but I think the point of this issue (correct me if I'm wrong) is that we do, in fact, need to fix the fact that generic method arguments are not reified.  Do we have a separate tracking bug for that?

To follow the bug intent, I believe this should stay a v2 VM bug.
We should open a separate bug for the desired spec-compliant behavior on analyzer.

I created a separate issue (#28543) for the analyzer.

We will use this issue to track implementation of generic functions semantics in the VM

Reification of generic functions is controlled by the VM flag --reify-generic-functions.
The list of changes below implemented the feature, so I am considering this done and closing this issue.
Note however that Kernel running with the VM backend is not yet able to reify generic functions. As part of the CLs below, I have started supporting proper generation of the flow graph from the Kernel IR for reified generic functions and left many TODOs in Kernel sources. I'll help the Kernel folks to complete this work.
For documentation purpose, here are the relevant change lists:
commit db15f5d73b75b36df96ba9896813d63943b74149
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Sep 27 17:57:41 2017 +0000
Dart Core Lib change to support generic functions in class NoSuchMethodError.

Change-Id: If7d1a8c07e4bee7ec68fede80a9d17cae0044d31
Reviewed-on: https://dart-review.googlesource.com/5329
Reviewed-by: Florian Loitsch<EMAIL_ADDRESS>
commit 6614090f44931922aeeb7025e9d7c6f6dab32384
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Tue Sep 12 16:31:23 2017 +0000
[VM generic functions reification] Emit code checking that the correct number of
type arguments are passed to generic functions, when this could not be checked
as part of the function resolution.
The error message printed from a thrown noSuchMethodError does not yet properly
reflect this kind of mismatch. It will be improved in a later cl.
The Invocation class has previously been updated so that noSuchMethod is already
able to process such mismatch.

Change-Id: I81a2966195593dc0d158a322f2a2a2219d225e78
Reviewed-on: https://dart-review.googlesource.com/5080
Reviewed-by: Siva Annamalai<EMAIL_ADDRESS>Reviewed-by: Zach Anderson<EMAIL_ADDRESS>
commit e0300086d1e4a437c949777ecf5aa1087b94a50d
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Sep 6 14:39:00 2017 -0700
[VM precompiler generic functions] Fix previous bad commit.
Generic functions cannot be called via monomorphic checked entries, because
the argument descriptor is lost. This limitation was removed by error and not
properly tested. It is reintroduced in runtime_entry.cc.
Changes in other sources are merely clean up and non-critical.

Change-Id: I7967950c1ad008b50e8691d59f4a9d5cd1c9f885
Reviewed-on: https://dart-review.googlesource.com/3761
Reviewed-by: Ryan Macnak<EMAIL_ADDRESS>
commit beedd2e1039775ae7b490e887778305afcab4f99
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Tue Sep 5 14:40:19 2017 -0700
[VM generic function reification] Fix megamorphic cache lookup when calling
reified generic function.
Clean up code to avoid similar issue in the future, i.e. make it clear whether
the passed type argument vector is counted or not by using better names.

Change-Id: I60fd6f6acb302235d8c1ae4f2bc4bf459724421e
Reviewed-on: https://dart-review.googlesource.com/3400
Reviewed-by: Ryan Macnak<EMAIL_ADDRESS>
commit df70bd64ae81510455efb7fe5aa18d138426ec77
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Aug 30 09:19:44 2017 -0700
[VM generic functions reification] Support generic async* and sync* functions.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/3004033002 .

commit b3a7dd6e9dfab327a2ef4bb3ef729b4ba8661471
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Mon Aug 28 17:00:35 2017 -0700
[VM generic function reification] Support generic functions in Invocation class.
Make VM object TypeArguments a Dart instance.
Add a test verifying that noSuchMethod works with generic functions.

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/3007603002 .

commit b8bce019b3e4a344d22ac3c0f805b619565a1f8e
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Fri Aug 18 15:25:16 2017 -0700
[VM generic functions] Support generic async calls.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/3001213002 .

commit 1829af87e9328dab203ed0a95c25ae6ae1bc59ae
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Thu Aug 17 11:11:01 2017 -0700
[VM mirrors and reified generic functions] Mirrors do not (and will probably
never) support reification of generic functions. However, instead of crashing
with an UNIMPLEMENTED, reify function type parameters to dynamic.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2997083002 .

commit c29f5dd4f538fb1005f193d012028229a523de4c
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Aug 16 10:48:02 2017 -0700
[VM DBC compiler and simulator] Support reified generic functions.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2987323003 .

commit 434f2e186c4ca85bda22dc27a99d883045f8c7bb
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Jul 26 13:37:38 2017 -0700
[VM aot compiler] Support reified generic functions in aot optimizer.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2991673003 .

commit cc81f38519b530f8dba6e46d82bc3c9554f5ce3d
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Fri Jul 21 15:07:56 2017 -0700
[VM generic functions] Disallow generic function types as type arguments or bounds.
Adjust existing test and status file.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2989513002 .

commit c98989f0d7cc8c1d1520b3202e18476cc33b5691
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Jul 19 13:32:21 2017 -0700
[VM generic function types] Properly set the scope function after parsing a
result type that may contain a generic function type.
Add a regression test demonstrating the fixed problem.
Rename ResolveType to ResolveTypeParameters in the parser to clarify that only
type parameters get resolved.
Rename ResolveSignature to ResolveSignatureTypeParameters for the same reason.
Correctly propagate the finalization mode when finalizing signatures.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2979763002 .

commit ec8a6cec72757f6faf6c8221873a33faefe38461
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Fri Jul 7 09:58:30 2017 -0700
[VM inliner for generic functions] Address a review comment suggesting some
refactoring of https://codereview.chromium.org/2894953002/

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2968083003 .

commit b5170a8b250a367e15f4903638eb87cdbc208273
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Thu Jul 6 12:13:16 2017 -0700
Support inlining of calls where type arguments are passed to generic functions.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2894953002 .

commit 2252d0dcc5cdb446116049634c3e9e0c48b4270a
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Fri Jun 30 15:04:13 2017 -0700
[VM, generic functions reification, work in progress]
Do not consider a generic function type as uninstantiated if all the function
type parameters appearing in its signature are declared by the type itself.
The generic function type is uninstantiated if it refers to function type
parameters of parent generic functions, or to class type parameters.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2965743002 .

commit 9a65805689a249ef5fe8c913ce04a8b3f3ff8163
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Fri Jun 30 13:18:12 2017 -0700
[VM, generic functions reification, work in progress]
Support passing type arguments in a generic instance call.
Note that kernel is always used for compiling InvokeFieldDispatcher functions.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2969723002 .

commit 164a602a809d53cea75a8899f7ed861ec6e684d7
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Thu Jun 29 14:33:32 2017 -0700
[VM parser] Mark class as typedef class before parsing its function type when
using the new function type syntax.
This issue prevents committing of https://codereview.chromium.org/2893893002

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2966583002 .

commit d9cc3b0e67c907f5ab4f08b8c1da84288f06e1a8
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Tue Jun 27 15:19:34 2017 -0700
Allocate local variable holding type arguments in generic functions in Kernel.
Capture instantiators when calling generic functions with uninstantiated type
arguments.
Add VM flag to generic functions tests that do not expect reification.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2958833003 .

commit bb527cb89e554388ae986fa754705c5b7710a561
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Fri Jun 23 14:18:10 2017 -0700
Avoid an assert fault in snapshot writer by making sure that the parent of a
signature function is also a signature function (fixes #29994).

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2949383003 .

commit 1f5f3ed79f4c152a7ba7f3f68367196763da15de
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Jun 21 13:16:20 2017 -0700
Set and keep parent function of signature functions.
Fix function type parameter comparison in type tests.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2951803005 .

commit a62107cfaf8442a54ca7a87b096244cff992965f
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Jun 21 09:02:12 2017 -0700
Check for a passed-in type argument vector in the prolog of generic functions.
Do this in unoptimized code only, when --reify-generic-functions is specified.
This is still work in progress, and support in optimizer, in inliner, in DBC,
in kernel to ir, and other areas, will follow.
Many small fixes and added todos.

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2941643002 .

commit 9aafded095a820faa99df451e8e1ae0ab6f85f29
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Thu May 18 14:03:43 2017 -0700
Pass type argument vector to generic functions (if --reify-generic-functions is
true, still false per default).
Work in progress, not functional yet (passed vector is still ignored in callee).

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2859673002 .

commit e4ff8df6e6875d1788c7e0e20fef61c17a26a7fb
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Tue Apr 25 13:35:16 2017 -0700
Properly handle implicit closure function when a generic function.
The parent function of an implicit closure function is not the enclosing
function, but the function being closurised. This requires special handling in a
few places.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2835363002 .

commit 1b68c0d0a1546313b2aebc9f833222838a3a94c2
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Thu Apr 20 14:20:14 2017 -0700
Process generic function type arguments in more places (function type tests,
function cloning for mixins, signature building, etc...).
Rename --generic-method-semantics flag to --reify-generic-functions (still not
working and disabled by default).

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2835513002 .

commit f0622c0567bc194b874675ea8b91e415cc73edaf
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Wed Apr 19 10:10:41 2017 -0700
Allow signature functions to be allocated in new space.
Types generated via instantiation during run time type tests are allocated in
new space and it makes sense (in the case of function types) to also allocate
instantiated signatures in new space.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2821233005 .

commit fd5089c9e81f865b1151ae3184421845f5635a86
Author: Régis Crelier<EMAIL_ADDRESS>Date:   Mon Apr 17 08:58:20 2017 -0700
Remove parent_level field of function type parameters.
Add function_type_arguments field in closure instances.
Lots of other smaller changes, also related to generic function semantics.
This is still work in progress, with a change of direction in the design:
The type argument vector of a generic function will be prepended with the type
arguments of enclosing generic functions. The re-allocation and concatenation
will be done in nested generic function's prolog. This will greatly simplify
instantiation of types at run time without having to search the context for
parent function's type arguments. However, a closure instance now requires an
additional field. On the other hand, type parameters do not require a
parent_level field anymore.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2818273002 .

commit d0a7bad1210b79a32d96c2d5954430da24bdd741
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Mon Apr 10 21:25:28 2017 -0700
Pass a second type argument vector to all type instantiation calls in the VM.
With generic methods, uninstantiated types will require 2 instantiators, one
reflecting the class type arguments (as of today) and one reflecting the
function type arguments (new).
This is work in progress and the second instantiator is always null for now.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2799373002 .

commit b87f7ece723644c136c94ba32b1a089aa1150792
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Thu Apr 6 18:04:08 2017 -0700
Mark 2 tests as crashing in dartk debug mode.

Review-Url: https://codereview.chromium.org/2800043002 .

commit 5f5a698100be7b145168490dfb81cd436ce1b8ff
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Thu Apr 6 12:28:48 2017 -0700
Keep types in signatures of function types properly instantiated as the function
type itself gets instantiated.
Until now, the signature was kept unchanged and the instantiation was reflected
by the type arguments of the function type only. This delayed instantiation
would complicate the implementation of generic functions.
This cl actually removes type arguments for (non-typedef) function types. The
function type is now fully represented by the signature. When the function type
is instantiated, a new signature is allocated (instead of a new type argument
vector) to hold instantiated result type and formal parameter types.
The same applies in the case of typedef function types, however, the type
arguments of the typedef are kept as before. This allows for better printing
of typedef function types and for finalization of recursive type involving
typedefs as type arguments.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2793033005 .

commit 9c9a14a29ae6b458022aa4ce69790cddd0ab502d
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Tue Mar 21 10:20:05 2017 -0700
Add Genericity enum in VM to distinguish how a type is uninstantiated.
Make flow graph builder aware of function type arguments.
This is work in progress toward supporting generic method semantics in the VM.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2761933002 .

commit 09b5d6f619c415fcf885bffd868c1f09c1cd9989
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Wed Mar 8 08:55:30 2017 -0800
Manage and capture class and function instantiators in the parser.
This is work in progress towards supporting generic function semantics.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2736733005 .

commit 269aaf03054d4e3fcd722a2b4912130e70ad0f79
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Mon Feb 27 14:51:27 2017 -0800
Properly handle instantiator when allocating or cloning closure instance.
This should fix the vm-kernel bots.

Review-Url: https://codereview.chromium.org/2723643002 .

commit 3633c5bd5ec0b6b876433b204d6c94bbfa118351
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Mon Feb 27 11:14:04 2017 -0800
Rename Closure instance field type_arguments_ to instantiator_.
Simplify handling of closures as deferred objects.
The name "type_arguments_" is confusing, because class Closure is not generic.
Class Closure was forcefully made (kinda) generic by setting its
type_arguments_field_offset_in_words_ field to a valid value, so that the
type_arguments_ field in closure instances could be accessed similarly as in
generic instances. With generic functions, closures will potentially have more
than one instantiator and the name type_arguments_ becomes nonsensical.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2719603002 .

commit 339d16fbc5d611fbbcf46235c290c615589ecc87
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Tue Feb 14 01:54:58 2017 -0800
Only capture function instantiator when compiling local function (fixes #28757).
Note that this code has no effect yet, because generic functions are not yet
fully supported (no regression test added).

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2690923004 .

commit 2037e7e88468ceb286f184b469a7781061c4e4f5
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Tue Feb 14 01:50:02 2017 -0800
Properly resolve upper bounds of generic function's type parameters.
Various minor cleanup related to generic functions.
Add flag in preparation of future work to fully support generic methods.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2696783002 .

commit f3080b8803d683d374b97b1b23a9ba42332bdc7b
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Fri Feb 3 12:38:31 2017 -0800
Refactor type finalization in VM so that the parser only resolves type
parameters, whereas the class finalizer resolves all other type names and
performs finalization and canonicalization. This allows to remove a lot of
duplicated code between parser and class finalizer.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2673093003 .

commit 97f968de1c54db99b5f567d3fd6379756e2416f7
Author: Regis Crelier<EMAIL_ADDRESS>Date:   Fri Jan 27 08:45:03 2017 -0800
Implement generic function type syntax in the VM (fixes #27966).
The new function type syntax is allowed everywhere and not just in typedef.

<EMAIL_ADDRESS>
Review-Url: https://codereview.chromium.org/2643523002 .

Can this be turned on by default? Or should we turn it on manually? We've generally found that having to turn things on manually leads to annoying bugs for us to track down (where different parts of our system have different flags set, etc).

As far as I know, this is a Dart 2.0 feature that cannot be turned on by default at this time.
The existing test suite does not expect this flag to be turned on either.
But feel free to try it on your side and report problems.

Apparently this isn't going to be turned on by default for now because the fix here is only a partial fix, it doesn't yet implement reification in the case where the type is going to be inferred.
e.g.:
void printTypeOf<T>(T foo) {
  print(T);
}

void main() {
  printTypeOf<bool>(null); // prints "bool" with this turned on, "dynamic" with it turned off
  printTypeOf(true); // always prints "dynamic", not "bool", even with this turned on
}

...and this is considered more unfriendly than the current behaviour (where the type is never reified).

I think implementing type inference for the VM might be tracked separately?

There is no current plan to implement type inference in the VM (with its own front-end). Type inference will be provided by the common front-end.

Sorry, meant that @Hixie obviously doesn't care about the differentiation - he just might not want to enable reified generic method types until the VM runtime has inference (whether provided by the frontend or not, implementation detail for Flutter).