Running the RoBERTa model shows errors on GLUE with adapters.

Environment info

adapter-transformers version: 3.1.0
Platform: ubuntu 20.04
Python version: 3.8.13
Huggingface_hub version: 0.7.0
PyTorch version (GPU?): 1.12.0 (True)
Using GPU in script?: yes
Using distributed or parallel set-up in script?: no

Information
Model I am using (Bert, XLNet ...): RoBERTa
Language I am using the model on (English, Chinese ...): English
Adapter setup I am using (if any): pfeiffer
The problem arises when using:

[x] the official example scripts: (give details below)
[ ] my own modified scripts: (give details below)
export TASK_NAME=mrpc

python run_glue.py
--model_name_or_path roberta-base
--task_name $TASK_NAME
--do_train
--do_eval
--max_seq_length 128
--per_device_train_batch_size 32
--learning_rate 1e-4
--num_train_epochs 10.0
--output_dir /tmp/$TASK_NAME
--overwrite_output_dir
--train_adapter
--adapter_config pfeiffer
The tasks I am working on is:

[x] an official GLUE/SQUaD task: (GLUE)
[ ] my own task or dataset: (give details below)

To reproduce
Steps to reproduce the behavior:

Install adapter-transformers 3.1.0

Install requirements for text classification

Run the above script for roberta-base on GLUE with the Pfeiffer adapter.
Traceback (most recent call last):
File "run_glue.py", line 677, in
main()
File "run_glue.py", line 589, in main
train_result = trainer.train(resume_from_checkpoint=checkpoint)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/trainer.py", line 1498, in train
return inner_training_loop(
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/trainer.py", line 1740, in _inner_training_loop
tr_loss_step = self.training_step(model, inputs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/trainer.py", line 2470, in training_step
loss = self.compute_loss(model, inputs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/trainer.py", line 2502, in compute_loss
outputs = model(**inputs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/adapters/models/roberta/adapter_model.py", line 68, in forward
outputs = self.roberta(
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/adapters/context.py", line 108, in wrapper_func
results = f(self, *args, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/models/roberta/modeling_roberta.py", line 879, in forward
encoder_outputs = self.encoder(
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/models/roberta/modeling_roberta.py", line 548, in forward
layer_outputs = layer_module(
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/models/roberta/modeling_roberta.py", line 433, in forward
self_attention_outputs = self.attention(
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/models/roberta/modeling_roberta.py", line 357, in forward
self_outputs = self.self(
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/models/roberta/modeling_roberta.py", line 212, in forward
mixed_query_layer = self.query(hidden_states)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
return forward_call(*input, **kwargs)
File "/home/anaconda3/envs/adapter/lib/python3.8/site-packages/transformers/adapters/lora.py", line 251, in forward
return F.linear(x, T(self.weight), bias=self.bias)
RuntimeError: CUDA error: CUBLAS_STATUS_NOT_INITIALIZED when calling cublasCreate(handle)

Expected behavior
BERT, mBERT, BERT-large works well in the settings. However, RoBERTa and XLM-R have this error that I cannot fix it.
Thanks a lot for your help.

Hey, unfortunately, I was unable to reproduce this error (see this colab notebook). So I am not sure what the problem is you're facing. Things you could check are:

Does your cuda version work with your pytorch version?
You can try a smaller batch size to rule out that a memory problem causes this.

I hope this helps.


Import from pastebin broken

Every build i try to import from pastebin throws this error:

You need to use the Community Fork in order for most of the pastbins that are going around right now

I was having this same issue, but like @Kyuzik said, you need the Community Fork.
https://github.com/PathOfBuildingCommunity/PathOfBuilding

hi , i downloaded the community fork but still it has the same bug i just cant use PoB.


"recursive" Dependency Causes "section too large" Error When Compiling for wasm

Describe the bug
I am encountering a problem when trying to compile wasmtest with the following command:
RUSTFLAGS="-C link-arg=--max-memory=4294967296" cargo build --release --target wasm32-unknown-unknown
The build fails with the following error:
error: failed to build archive at `.../target/wasm32-unknown-unknown/release/deps/libpsm-cc498cff4b514c30.rlib`: LLVM error: section too large

The following warnings were emitted during compilation:

warning<EMAIL_ADDRESS>warning: ...

I suspect the issue is related to the psm dependency, and it is coming with recursive crate, which was introduced in #13310. I am unsure if this error can be resolved without removing or replacing this dependency.
To Reproduce
Go in datafusion/wasmtest and run cargo build --target wasm32-unknown-unknown
Expected behavior
It needs to compile
Additional context
I tried again after removing recursive dep, and it works successfully

I have try to reproduce the bug by either build wasmtest or build stacker with wasm32-unknown-unknown, but was unable to reproduce the issue.
Can you provide more information? (cargo and rustc version...)

This obviously doesn't resolve the issue, but https://github.com/rustwasm/wasm-pack/issues/1381#issuecomment-2153142927 fixed it for me

I have applied the @blaginin suggestion:
berkaysahin@Berkays-MacBook-Pro wasmtest % clang --version
Homebrew clang version 19.1.4
Target: arm64-apple-darwin23.4.0
Thread model: posix
InstalledDir: /opt/homebrew/Cellar/llvm/19.1.4/bin
Configuration file: /opt/homebrew/etc/clang/arm64-apple-darwin23.cfg

@Eason0729 these are my cargo and rust versions
berkaysahin@Berkays-MacBook-Pro wasmtest % cargo --version
cargo 1.82.0 (8f40fc59f 2024-08-21)
berkaysahin@Berkays-MacBook-Pro wasmtest % rustc --version
rustc 1.82.0 (f6e511eec 2024-10-15)

When I build with:  cargo build --target wasm32-unknown-unknown ,
it successfully compiles and generates the binary.
However, in the release mode: cargo build --release --target wasm32-unknown-unknown,
Compiling psm v0.1.24
   Compiling arrow-ipc v53.3.0
   Compiling arrow-json v53.3.0
   Compiling arrow-csv v53.3.0
   Compiling stacker v0.1.17
   Compiling recursive v0.1.1
error: failed to build archive at `/Users/berkaysahin/Desktop/datafusion-upstream/target/wasm32-unknown-unknown/release/deps/libpsm-cc498cff4b514c30.rlib`: LLVM error: section too large

The following warnings were emitted during compilation:

warning<EMAIL_ADDRESS>warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: archive library: /Users/berkaysahin/Desktop/datafusion-upstream/target/wasm32-unknown-unknown/release/build/psm-d273ebae732f9287/out/libpsm_s.a the table of contents is empty (no object file members in the library define global symbols)

error: could not compile `psm` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

I don't know why this still refers to Xcode path.
Since wasm-pack build goes with release flag, we need to solve this (assuming I am not the only one)

It compiles under 1.82.0 and 1.83.0(didn't use LLVM 15), I think it's LLVM version related.
In addition, I may need some help on how to use specific version of LLVM?
root@73b0a356b106:/stacker/psm# echo $PATH
/usr/lib/llvm-15/bin:/root/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

root@73b0a356b106:/stacker/psm# clang --version
Debian clang version 15.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-15/bin

root@73b0a356b106:/stacker/psm# rustc --version --verbose
rustc 1.83.0 (90b35a623 2024-11-26)
binary: rustc
commit-hash: 90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf
commit-date: 2024-11-26
host: x86_64-unknown-linux-gnu
release: 1.83.0
LLVM version: 19.1.1

@berkaysynnada, is this sill an issue? https://github.com/rustwasm/wasm-pack/issues/1381#issuecomment-2153142927 seems to work for me too.
% export PATH=/opt/homebrew/Cellar/llvm/19.1.4/bin/:$PATH

% clang --version
Homebrew clang version 19.1.4
Target: arm64-apple-darwin23.6.0
Thread model: posix
InstalledDir: /opt/homebrew/Cellar/llvm/19.1.4/bin
Configuration file: /opt/homebrew/etc/clang/arm64-apple-darwin23.cfg

% rustc --version --verbose
rustc 1.83.0 (90b35a623 2024-11-26)
binary: rustc
commit-hash: 90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf
commit-date: 2024-11-26
host: aarch64-apple-darwin
release: 1.83.0
LLVM version: 19.1.1

% cargo clean
...

% cargo build --release --target wasm32-unknown-unknown
...
   Compiling datafusion-wasmtest v43.0.0 (/Users/ptoth/git/apache/datafusion/datafusion/wasmtest)
    Finished `release` profile [optimized] target(s) in 1m 36s

That worked for me now (and passed the tests). Perhaps I should have tried with cargo clean 😞


3rd Party Testing on Ubuntu 20.04

Need 3rd party to confirm that the modified v5.5 kernel version works on another person's vanilla Ubuntu 20.04 install, and fixes the S3 wake issues with the trackpad

@Kabbone Can you test the v5.5 kernel?

sorry, for reaching out so late. I can only test on Archlinux with v5.7.2


Reach out to ESG reporting companies

ESG reporting companies have a lot of insight they can share with us about how industry currently reports and how that will change in the near future.
Acceptance Criteria:

[x] Review list of potential companies below
[x] Write outreach email
[x] Send outreach email to identified ESG reporting companies

Notes:
The project team can reach out to the following companies:
PlanA (Europe)
Planetly (Europe)
Emitwise (Europe)
Watershed (US)

Persefoni (US)
Novisto (https://novisto.com/solutions/by-industry/)
Doconomy (https://doconomy.com/)

Thank you @jaimiebutton!


Fix all includes in headers

Clang-tidy does not seem to update includes in headers automatically. This may be a bug or perhaps it can simply not update them in fear of breaking code that depends on the headers.
Let's give it a hand and do it ourselves once for all headers that need it.

Related issue in LLVM https://github.com/llvm/llvm-project/issues/67140


HPA tests only on k8s versions w/ working implementation

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

HPA tests only on k8s versions w/ working implementation

this is no longer needed since the upstream fix went in.


RCTVoice.startSpeech got 3 arguments, expected 2

I get an error as RCTVoice.startSpeech got 3 arguments, expected 2
This error occurs even when using the code from the example.
Going to be doing an investigation into this, any advice would be appreciated.

u just give it two arguments instead of 3 will solved it

@NikitaVr Did you solve your problem?


NPM Log Format

I was a little disappointed when I realized the nginx proxy manager (https://nginxproxymanager.com/) does not use a standard nginx logging format.  I tried a few alternations but now I‘m stuck with:
Token 'https' doesn't match specifier '%H'
This is my log format:
log_format [%d:%t %^] - %s %^ - %m %H %v "%U" [Client %h] [Length %b] [Gzip %^] [Send-to ~h] "%u" "%R"
And this is the log line:
[03/Mar/2022:20:07:48 +0000] - 200 200 - POST https domain.de "/folder/stuff/git-receive-pack" [Client <IP_ADDRESS>] [Length 0] [Gzip -] [Sent-to <IP_ADDRESS>] "AppleWebKit" "-"
What am I missing?

Please try:
goaccess access.log --log-format='[%d:%t %^] - %s %^ - %m %^ %v "%U" [Client %h] [Length %b] %^"%u" "%R"' --date-format=%d/%b/%Y --time-format=%T

This works like a charm! Thank you!


Fix: Require tilt, if Tilt module is defined

This Fixes #14.
Testing.

Start a project that has both slack-ruby-client and sidekiq-scheduler as dependencies in the GemFile
Start puma bundle exec puma -p 4000
Browse to localhost:4000 and verify that you do not receive an error caused by Tilt module missing methods.

Notes
There might be a cleaner way to detect whether Tilt has been loaded in the tilt? method on lib/rack/server_pages.rb:193, which would not necessitate using Tilt, unless the user has explicitly required it. My ruby wizardry is shamefully lacking, and I do not know how to do this; I'm open to suggestions.

Tagging @dblock, because I encountered this situation using his library slack-ruby-bot-server, and he is probably the best person to opine on whether: this is a good solution, or there even needs to be a solution.

Generally I don't think it's the job of the implementation to require.
I do think this project needs to move from Travis-CI to GHA, replacing https://github.com/migrs/rack-server-pages/blob/master/.travis.yml, before making any more changes :)

Fixed CI in https://github.com/migrs/rack-server-pages/pull/17, maybe you want to pick this one up again @aberkowitz?


unnecessary use getattr

Hello @gitworkflows, this seems like an automated change. Are you a bot? I would prefer you not to do automated PRs. In particular without description, explanation about why you suggest the change, breaking the tests and coverage, etc.

Hello @gitworkflows, this seems like an automated change. Are you a bot? I would prefer you not to do automated PRs. In particular without description, explanation about why you suggest the change, breaking the tests and coverage, etc.

Hello @tiangolo,thanks for your feedback. I know it might look like a bot made this change, but I'm a real person who made it manually.
I changed the code to use Any so the function can work with different types of sequences. This makes the code more flexible and helps prevent errors.
If you want to know more about why I made this change, just ask. I'm happy to explain it in more detail. Thanks for reviewing my pull request!"

You wrote the same comment as in here :sweat_smile: https://github.com/fastapi/fastapi/pull/12155#issuecomment-2347304676
And you forgot again to remove the final double quote... I'm closing this one. :coffee:


Coveralls fix

This requests reports logical branch names rather than physical id refs.
The fix requires a change on the sbt-coveralls plugin, which has been forked and modified accordingly on the coral-streaming repo https://github.com/coral-streaming/sbt-coveralls and added for build from sources in the current project.
Because of the multi-project build, in order to work properly, the sbt-coveralls requires a minimum of two sub-projects to be tested. Hence the placeholder for coral-core.

Maybe we should avoid names like "thing.scala". Could you suggest a more meaningful one?


Semantic Hub Release 23.12 Compliance Acceptance Criteria

Release Compliance 23.12
Source in Catena-X Confluence + Expert Contacts here. (Source only accessible for Catena-X Consortia members in current transition phase)

[x] Gaia-X compliance confirmed by dedicated expert.

Obtain approval from CX Gaia-X expert(s), prior to Gate review.
Provide info as early as possible; expect optimization loops based on feedback
=> check linked PDF summary for requirements (Source only accessible for Catena-X Consortia members in current transition phase).

Contact:

Release Mangement

[x] GDPR compliance confirmed
(personal data; Data Protection & Privacy DPP)

assessment must be completed via Catena-X GDPR questionnaire (Source only accessible for Catena-X Consortia members in current transition phase.)
either the product/service doesn`t process any relevant data,
or - in case the assessment reveals potential issues - a more severe "Data Privacy Impact Assessment" shall be conducted (if applicable: robust mitigation actions must be completed)
Provide evidence for GDPR compliance prior to Gate review. Previous assessments remain valid, as long as approach to handling of personal data was not changed.

Contact:

Release Mangement

[x] Interoperability Check
Acceptance criteria are fulfilled as described in in the following area on confluence: Interoperability Quality Gate Requirements (Source only accessible for Catena-X Consortia members in current transition phase.)

Approval will be documented centrally by Expert(s)

Obtain approval from Interoperability experts prior to Gate review.

Therefore consult the regular office hours as early as possible; expect optimization loops based on feedback. (Source only accessible for Catena-X Consortia members in current transition phase.)
Contact:

SYSTEM ARCHITECT2

[x] Data Sovereignty Check
Acceptance criteria are fulfilled as described in in the following area on confluence:

Data Sovereignty Guardrails for Release 3.2 (Source only accessible for Catena-X Consortia members in current transition phase.)
Approval will be documented centrally by Expert(s)
Obtain approval from Data Sovereignty experts prior to Gate review: Experts will schedule a review with your team.

Expect optimization loops based on feedback.
Contact:

SYSTEM ARCHITECT3,
SYSTEM ARCHITECT4

[x] Confirmation of published CX Standards
Product Owner confirms:

The FOSS product under review is compliant to all relevant Catena-X Standards which are already published on the Association website.
Failure to do so may ultimately make the reference implementation useless, as the mandatory CX Certification cannot be accomplished.

[x] Verification of foreseen CX Standards
Product Owner confirms:

The content of upcoming CX Standardization Requests (STAN) has been reviewed and feedback was provided to the responsible PCA/BDA. As per current status, the FOSS product under review will be compliant as soon as the CX Standard is published. (Info here) (Source only accessible for Catena-X Consortia members in current transition phase.)
Minimum: PCA/BDA have finalized all release-relevant Standardization Requests (STAN). Those have passed the CX Association`s technical committee (TC4S) and are pre-published on the website. Opt-out period in progress.
Best case: Association Board approval available and CX Standard is published on website.

Gaia-X compliance confirmed by dedicated expert:
@ Werner Jost: Since no changes with respect to Gaia-X compliance to former version 3.0.0, please approve.

GDPR compliance confirmed:
Release Mangement:  : As discussed and approved with release v3.1 and release [v3.2.]
Catena-X GDPR Declaration and Requirements_V23.12_SemHub.xlsx

Interoperability Check:
Approval is documented centrally by PCAs at https://confluence.catena-x.net/x/dHZHAw (no changes needed by 17.04.2023)
Furthermore, see standardization candidat SC-011 at List of standardization candidates and their dimensions

Markus Hauser Christopher Winter
Data Sovereignty Check:
Ownership of the data
Data is public in Catena-X operator network with respect to copyright ownership.
Access control
All users within operator network with respect to Business Partner Number can access the data.
Users can migrate their data to a different service and/or service provider.
Transferability to a different application or service provider ensured. There is no lock-in.
-> in last QG 4/5 this was marked as "not relevant"

Confirmation of published CX Standards
This application supports the standard CX-0003 for the Semantic Aspect Meta Models
Remark: There has no standard on, e.g. APIs on Semantic Hub in Catena-X to be compatible to.

Verification of foreseen CX Standards
The content of upcoming CX Standardization Requests (STAN) has been reviewed and feedback was provided to the responsible PCA/BDA.

Hi @kelaja,
for the points:

Interoperability Check
Data Sovereignty Check
Confirmation of published CX Standards
Verification of foreseen CX Standards

The Expert is not defined / Expert Github account is not known, pls forward to expert. Many thanks!

@hiHenrik kindly check on "Interoperability"

@thomas-henn @kelaja @bosserf hello, in my understanding the semantic hub is not relevant for interop check in this release as stated above, only the content semantics, please confirm, thank you henrik
https://confluence.catena-x.net/pages/viewpage.action?spaceKey=CXSTAN&title=R23.12+Semantics

@kelaja @bosserf @HiHenrik : Yes, I confirm, Semantic Hub is not relevant for interoperability check.

For Data Sovereignty POs can do a self-declaration if products have not undergone any significant changes.
See Links (available to Consortia Members only)
2023-11-20 Stay informed & Release 23.12 & 24.03

@kelaja
Data Sovereignty Check has been updated.


This won't open unless the script tags are closed properly.

The app wouldn't open for me because the script tags aren't self closing, so just adding  fixes it

This is more consistent and will work across a wider array of browsers. Although KitchenSinkDesktop does work for me, this is safe and the proper way to clone the script tags.


chore(meta): manifest maintenance

Somewhat related string of commands to clean up Cargo manifests. See each commit's description for how it was done.

Nope https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml


wasmedge performance data

ENV
Ubuntu
VERSION="20.04 LTS (Focal Fossa)"
I want to collect the following Wasmedge Runtime performance data when yomo-wasmedge-tensorflow is running, such as CPU, Mem, etc. How can I do it

To collect performance data when yomo-wasmedge-tensorflow is running, you can do the following:

Install a system monitoring tool like the "top" command or "htop". These tools can show you real-time CPU, memory, and network usage information.
Run the "top" or "htop" command while yomo-wasmedge-tensorflow is running. You will be able to see the CPU% and MEM% being used by the tensorflow process.
Alternatively, you can install a monitoring agent like Prometheus to collect metrics. You can write an exporter to expose metrics from yomo-wasmedge-tensorflow like:

CPU usage
Memory usage
Number of requests served
Latency of requests
Prometheus will then scrape these metrics periodically and you can visualize them using Grafana.

You can also log the performance data programmatically from within yomo-wasmedge-tensorflow using the psutil library. Call psutil functions periodically to get the CPU% and memory usage, and log the values to a file.
Finally, you can write a small script to profile yomo-wasmedge-tensorflow using cProfile. Run the script while it's running to collect performance data like:

Number of function calls
Total runtime
Function-wise times

Thank you, I solved this problem using htop and psutil


updating wercker to use correct opam repo

I thought you'd previously said opam update was a no-op as it was done by the imandra installer?

Nah, I meant it's a no-op because the opam repository was set to a local git repository, which never changes.
The Imandra installer does do an opam update as well, but here we're installing opam packages before calling the installer.


option: turn off notifications

please provide an option to turn off desktop for notifications for wallet events.

Added a pull request for this.
https://github.com/feather-wallet/feather/pull/70


[Feature request] Send custom commands

The only thing this project is missing is the ability to send custom commands. Currently, the controls are limited to what has been baked into the app. But if there was a way to send custom commands, you could do almost anything that you can do on the desktop, through your phone.
My idea would be to have a menu in the app that has a list of defined commands, for example:
- add brightness 1
- add brightness -1
- add gamma 1
- add gamma -1
- screenshot

- script_message bookmarker-menu
- script_message crop

If I remember well, someone already mentioned something similar to this functionality. It's probably possible to implement it to the REST API.
I don't have an idea, how I should implement this on the frontend, I'm not a UI/UX designer (as you can see from my app design 😁). If you have any idea about how this functionality should look in the app, please let me know.

One idea is to add a new button in the Player tab that opens a menu with a list of your defined commands and a "+" button that lets you add new commands.
Another idea would be to make a new tab for custom commands. For example:
Player
Playlist
Custom commands
Settings
About

The UI would be the same as the "Media collections" UI, but for commands. But I'm personally happy with any frontend implementation.

https://github.com/husudosu/mpv-remote-node/commit/1c0fb354ccc1a2b2c9eb69ab8c08da31f5c99e9f
Just some update: I've implemented the desired function on the API. Still needs implementation on the app though.


Esbuild support for CSS property?

Hi, I was wondering if there is any plan to add support for an alternative to the Babel Plugin Macro in order to be able to use the CSS property with Esbuild?

I think a possible alternative could be to provide a custom jsx pragma like Emotion does.

@kitten may I know why this was moved to the Babel plugin repository? My issue is about esbuild, not Babel. If a solution is going to be found, it will not involve Babel.

Did anyone fund a solution to support the css prop on a ViteJS/ESBuild application?

For now 'babel-plugin-styled-components' babel transformation needs to be called during esbuild.build(…)
Almost doubles the build time of esbuild project, but works
// build.mjs
import * as esbuild from 'esbuild';
import esbuildPluginBabel from 'esbuild-plugin-babel'; // small utility plugin making a bit easier to run babel transformation
//…
await esbuild.build({
  logLevel: 'info',
  outdir: './build',
  entryPoints: ['./src/index.tsx'],
  entryNames: 'static/[name]-[hash]',
  metafile: true,
  bundle: true,
  minify: true,
  sourcemap: true,
  platform: 'browser',
  target: 'chrome117',
  tsconfig: './tsconfig-src.json',
  define: {
    global: 'globalThis',
  },
  plugins: [
    // run as the first plugin
    esbuildPluginBabel({
      filter: /\.(jsx|tsx)$/u, // only process .jsx and .tsx files
      config: {
        plugins: [['babel-plugin-styled-components', { pure: true }]],
      },
    }),
    //… other plugins you have
  ],
});

cc @probablyup as the major contributor to the https://github.com/styled-components/babel-plugin-styled-components repo maybe you would know if styled-components team has plans to port the babel-plugin-styled-components to esbuild-native plugin? esbuild provides way to write a plugin on JS and Go lang, https://esbuild.github.io/plugins/#example-plugins

I really have no time for that unfortunately. Maybe when one of the AI tools gets good enough we can generate one unless someone wants to take a stab at it

The tricky thing with esbuild is it just gives you raw content and you have to provide your own AST parser. So you end up with something babel-like anyway.


services .zinio.com: no such host

I get this error on Windows 7:
failed to authenticate user<EMAIL_ADDRESS>Post https://services.zinio.com/newsstandServices/authenticateUser: dial tcp: lookup services.zinio.com: no such host

I couldn't reproduce this. Zinio servers are often unreliable -- did you try to wait and retry later?

Yes, I'm still getting the same error. Tried on Ubuntu 17.04 and I'm getting:
INFO[0000] logging in<EMAIL_ADDRESS>FATA[0060] failed to authenticate user<EMAIL_ADDRESS>Post https://services.zinio.com/newsstandServices/authenticateUser: dial tcp: lookup services.zinio.com on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:39111-><IP_ADDRESS>:53: read: connection refused

Looks like some kind of DNS issue. Can you open https://services.zinio.com/ from your browser and tell me what happens? Can you also run the command dig services.zinio.com in the terminal and send me the output?


How am I supposed to set it up on Ubuntu 18.04 with Docker installed?

I am unable to understand how I have to set it up on a VPS. I have installed Docker. Do I have to clone the repo in a container or something??
Thanks!

How did you install docker on Ubuntu 18.04? If you installed via apt-get or aptitude the version is horribly out-of-date and you should remove it using the following command:
$ sudo apt-get remove docker docker-engine docker.io containerd runc docker-compose

Then follow the instructions here to install the docker engine:
https://docs.docker.com/engine/install/ubuntu/
Finally, install an up-to-date version of docker-compose by following the instructions for Linux here:
https://docs.docker.com/compose/install/
Once you've done that just clone the repo and run the docker-compose commands from inside the root of the project, e.g:
$ git clone https://github.com/alphagov/e-petitions.git
$ cd e-petitions
$ docker-compose run --rm web rake db:setup

This will give you a working development environment. However, if you're after a production environment then I wouldn't recommend using docker - the easiest solution would be to use Heroku but you won't be able to run it for free.
Can you give a bit more context on what you're trying to do? If you're trying to host your own petition website there maybe other projects more suited to your requirements as this is pretty specific to the UK's parliament and government and would require lots of customisation to remove branding etc.

Cool. Thanks a ton!

Cool. Thanks a ton!
I am trying to host my own petition site. How do you suggest I go about this.

Cool. Thanks a ton!
I am trying to host my own petition site. How do you suggest I go about this.

Who are the site's users? i.e. who is the petitioner, who are the supporters and who are they petitioning? Is it a single petition or is it a petitioning platform like change.org? What programming languages do you have most experience with?
The code here is designed for members of the public to petition a national government/parliament with set thresholds that trigger actions such as official responses, debates in parliament, etc. We've adapted it a couple of times but they've both been parliaments of some kind - the States of Jersey and the Welsh Parliament.

It is a petitioning platform like change.org.
I have most experience with Python3/Flask, but have worked with PHP and HTML(with both NGINX and Apache).

In that case I'd suggest focussing on Pytition, which I can see you've found - it's Django and not Flask but at least it's not Ruby on Rails like this repo is.


my code isnt working

code:
import MeowerBot
import os

client = MeowerBot.Client('Redstone1080', os.environ['pswd'])

def on_raw_msg(msg: dict, listener: dict):
    print(f'msg: {msg["u"]}: {msg["p"]}')

client.callback(on_raw_msg)

client.start()

(hosted on replit)
what i want it to do is print a line in the console when there's a new message, with the message author and content
that does not happen
what do you mean, i used code from the example

whats the error displayed in the console?

whats the error displayed in the console?

there is none

turn debug mode on
also, upgrade your bot to the new version of meowerbot

@redstone-scratch

Stale


Introduce stream support

Status
IN PROGRESS
Migrations
NO
Description
This allows to pipe traces to any standard FILE* stream.
NOTE: This should not break existing API's or behaviours.
This allows to do this:
FILE *fh = fopen("./debug.log", "a");
mbed_trace_set_pipe(fh);
tr_debug("debugging to file");

Todo

[ ] Tests
[ ] Doc
[x] Examples

This PR changes default "printer" function from puts to fputs, which behaviours slightly differently (eg buffers/flushing point of view). When using custom printer there is wrapper function which provides fputs -kind of API and calls that custom printer which are backward compatible. Haven't analyse more deeply does this affects to performance and how much if. Opinions about this ?

Feels a little bit unnecessary.
I've always been quite happy to provide a print function that does fputs(X, line); fputc('\n', X);. Doesn't seem like this is really easier.
I guess a general config option to include a newline in the output call would streamline it a bit.

BTW, puts shouldn't be different from fputs(stdout), except for the fact it includes a newline.
In POSIX puts being a single call means it's effectively equivalent to
flockfile(stdout);
fputs(line, stdout);
fputc('\n', stdout);
funlockfile(stdout);

On non-POSIX systems, the atomicity of a single library call isn't guaranteed, and we're relying on our mutex anyway.
But having an option to make the formatting core stick on a \n along with all the other headers/trailers makes perfect sense to streamline this generally - whether or not the friendly "stream" thing is added.

Feels a little bit unnecessary.
I've always been quite happy to provide a print function that does fputs(X, line); fputc('\n', X);. Doesn't seem like this is really easier.

True, basically same thing can be achieved already with a bit more code. Idea was to "simplify" output a bit so that output is always standard FILE stream so that output can be something else than stdout easily.. Do you see some (other negative) side-effects with this PR ?

I guess a general config option to include a newline in the output call would streamline it a bit.

I think about it also. Would be easy task.

In POSIX puts being a single call means it's effectively equivalent to
flockfile(stdout);

Maybe our mutex API calls could have stream argument so it could be flockfile by default in POSIX..

I've always thought part of the concept was that there was no assumption anywhere that the output actually be a stream - it could be an insertion into a circular buffer, or transmission as a network packet.
Hence the entry being delivered as a simple single "unit".
I'd kind of like that purity preserved in the core, but I guess a helper that does set_stream_output(FILE *) makes sense. But it can just be equivalent to
remember_stream
set_output(internal_helper_fputs_function)
turn on line endings


[IMP] Standardize English flavor

... Or should I say flavour? 🤡
Recently this subject arose in https://github.com/OCA/sale-workflow/pull/2243#discussion_r1009251042.
In general terms, Odoo core is written in en_US and that's the base language for all translations. Since it has some differences with other locales, it's good to have a guideline on what's the correct standard.
I'm not saying we all have to go and change all words in non-American English out there. It's probably too late and it's impractical to do so. However, for new stuff coming, I think it's good to have a standard.

OK, but shouldn't you propose this to the main branch?


Updated deprecated links in applications.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

coverage: 98.827%. remained the same
when pulling 71c087deb248697a9f4f347791c5c44ca352c71d on Spacha:patch-1
into b49e72e6b3c6be7130c86236340d1b62a31496d2 on uber:master.


operator hive-operator (1.2.3996-500a742)

Update Hive community operator channel(s) [['alpha']] to 1.2.3996-500a742

/merge possible

/test 4.10-deploy-operator-on-openshift

/merge possible


Update Swagger and Postman for the new callback property in POST/GET notifications

User Story - Business Need
As part of the VA's Zero Silent Failure Initiative (see epic), we need to update the OpenAPI spec and Postman collections to add in a new property to POST v2/notifications/<email|sms>payloads for a callback URL and the GET v2/notifications/:notification_id response so that our clients can be aware of this property.

[x] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a   business line
I want to have documentation as to the new callback payload
So that I can make use of it to have zero silent failures.
Additional Info and Resources

Callback property name TBD.
It could be nice to include in swagger a description if a callback URL added to the POST payload, it overrides any service level callback.

Acceptance Criteria

[x] OpenAPI is updated for POST v2/notifications/email to include the new callback property in and that it is an optional string in the schema, examples, and responses.
[x] OpenAPI is updated for POST v2/notifications/sms to include the new callback property in and that it is an optional string in the schema, examples, and responses.
[x] The two Postman collections (for internal developers and clients) are updated to include the new callback property in the POST v2/notifications/email and v2/notifications/sms payloads
[ ] This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

[ ] QA to review and approve swagger changes
[ ] QA to use Postman to exercise the routes to ensure they work as expected

Potential Dependencies

This work has dependencies on other tickets that have not been created at the time of this writing. Tickets will be linked as blockers at that time.

Hey team! Please add your planning poker estimate with Zenhub @coreycarvalho @cris-oddball @EvanParish @k-macmillan @kalbfled @MackHalliday @mchlwellman

PR is up and in draft mode.

This PR is code complete. Waiting for #2104 and #2012 to open the PR.

Decided to open the PR now for review. It can be sent up the pipeline later.

PR approved and merged.


Fetch tags in GitAlg.syncFork

I think we also need to fetch tags in GitAlg.syncFork because some repos require tags to be present in order for the build to load successfully. See for example https://github.com/almond-sh/almond/pull/483.

Hello there, i can give this a go. Do we want this behind a configuration ? And to be clear, what we need to do is both:

git fetch
git fetch --tags
is that right ?

Or do we need to use git fetch --tags instead of git fetch ? And which git version do we use?

No, this shouldn't be behind a configuration. It should just be the default behaviour. And we don't know which Git version is used, we're just using the git command that is provided in the environment Scala Steward is running in.
With regard to the right git command(s): I assume that adding --tags would be enough.


Contact | Security Issues

Dear helpy contributors,
I've tried to contact you through the email provided in the security policy, but got no response.
Please get back to me at<EMAIL_ADDRESS>It's about security issues found in your project.
Thanks,
Miriam

Hi Miriam, thanks for reaching out via our email.  Our disclosure policy is outlined here: https://github.com/helpyio/helpy/blob/master/SECURITY.md


Could change App startup white splash screen?

Thank you so much for such an effective tool!
As we all know, some apps’ cold startup activitys have very disgusting ad splash screens,
so I used some other tools to replace the startup splash activity of these Apps as It's main activity, but a white splash screen appeared when it started. This looks very dazzling in the dark theme.

It already should. Depending on the app it might not be applied quick enough however, but what it's doing currently is the best it can do.


HttpClientTest.TestRandomURLMultiThreaded test failure on Ubuntu 18.04 LTS

Confirm by changing [ ] to [x] below:

[x] I've gone though Developer Guide and API reference
[x] I've searched for previous similar issues and didn't find any solution

Platform/OS/Hardware/Device
What are you running the sdk on?
Linux Ubuntu bionic 18.04 LTS
Describe the question
I am using AWS_SDK_VERSION_STRING "1.8.62". I was having problem in making http request while i am using sns client publish method. The crash occurs after random number of successful publish call but it occurs certainly. I was suggested that i should recompile c++ aws sdk. SDK got compiled successfully but i get error in tests. 2 tests are failed
/home/{localuser}/Desktop/github/aws-sdk-cpp/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:696: Failure
[build] Value of: *cipherDe
[build]   Actual: true
[build] Expected: false
[build] [  FAILED  ] HttpClientTest.TestRandomURLMultiThreaded (40081 ms)
[build] [ RUN      ] HttpClientTest.TestRandomURL
[build] [       OK ] HttpClientTest.TestRandomURL (20020 ms)
[build] [----------] 2 tests from HttpClientTest (60101 ms total)
suggest me possible fixes for these test failures. I have gone through the developers document and i have installed essential binaries. I have curl of version 7.72.0 19-08-2020 and openSSL 1.1.1h 22-09-2020, GCC 9.3.0
Logs/output
If applicable, add logs or error output.
[build] [==========] 377 tests from 67 test cases ran. (67391 ms total)
[build] [  PASSED  ] 375 tests.
[build] [  FAILED  ] 2 tests, listed below:
[build] [  FAILED  ] HttpClientTest.TestRandomURLMultiThreaded
[build] [  FAILED  ] AES_GCM_TEST.AES_GCM_256_KAT_1
[build]
[build]  2 FAILED TESTS
[build] aws-cpp-sdk-core-tests/CMakeFiles/aws-cpp-sdk-core-tests.dir/build.make:814: recipe for target 'aws-cpp-sdk-core-tests/aws-cpp-sdk-core-tests' failed
[build] CMakeFiles/Makefile2:822: recipe for target 'aws-cpp-sdk-core-tests/CMakeFiles/aws-cpp-sdk-core-tests.dir/all' failed
[build] Makefile:148: recipe for target 'all' failed
[build] make[2]: *** [aws-cpp-sdk-core-tests/aws-cpp-sdk-core-tests] Error 1
[build] make[2]: *** Deleting file 'aws-cpp-sdk-core-tests/aws-cpp-sdk-core-tests'
[build] make[1]: *** [aws-cpp-sdk-core-tests/CMakeFiles/aws-cpp-sdk-core-tests.dir/all] Error 2
[build] make: *** [all] Error 2
To enable logging, set the following system properties:
REMEMBER TO SANITIZE YOUR PERSONAL INFO
options.loggingOptions.logLevel = Aws::Utils::Logging::LogLevel::Trace;
Aws::InitAPI(options)

I also see this with 1.8.63
[ RUN      ] HttpClientTest.TestRandomURLMultiThreaded
/aws-sdk-cpp-1.8.63/aws-cpp-sdk-core-tests/http/HttpClientTest.cpp:81: Failure
Value of: hasPendingTasks
  Actual: true
Expected: false
[  FAILED  ] HttpClientTest.TestRandomURLMultiThreaded (6463 ms)

It started failing with 1.8.53

hi @lalit-g-deepr and
hmm I have a feeling I've seen this issue before, I'll look into it today.
In the mean time and just in case, is there any chance that you've got some sort of firewall blocking the sdk or bad internet connection? It seems like the test is reaching some timeout.
@Ri0n , just to discard this, what versions are you running this on? (Gcc and curl).
Lastly, and for both of you, It'd help me to know what was the cmake command you used.

@KaibaLopez, I can't reach that PC right now to check all the versions, but it was on Ubuntu 20.04. And I compiled just transcribestream component.
Bad internet connection? If a unit test anyhow depends on the internet connection has to be removed because it's not a unit test more.

@Ri0n , yea I am not able to reproduce this on my side so shooting in the dark until I can, but you're right, we might have remove it depending on what the root cause is, I was hoping for the firewall being the problem though.

@KaibaLopez, if you want me to add some debug output and restart the tests, just send me a patch.

@KaibaLopez sorry for late reply there was medical emergency so i was unable to reach my work PC and i can't get access to github from local. I also think this is some networking issue can you tell which ports needs to be opened and give me your test machine iptables if possible. Thanks

Once again. A unit test should not depend on any network conditions. If this is the case the unit test has to be removed/rewritten.
@lalit-g-deepr I suggest to just disable unit tests via cmake parameter till it's fixed.

@Ri0n It is ok but how would be able to use some functionality which would depend upon that unit test. At that time we might not have clear idea why that one is failing.
@KaibaLopez I have one more error apart from multithread please look into that one also. this one /home/{localuser}/Desktop/github/aws-sdk-cpp/aws-cpp-sdk-core-tests/utils/crypto/SymmetricCiphersTest.cpp:696: Failure

@lalit-g-deepr it didn't fail before because the test was added just recently. nothing was tested before.

@Ri0n I agree but  I have gone through the test and it seems very normal test case. AWS should pass this test with flying colors, and it is passing on @KaibaLopez machine but for lot of other people it is not passing. through Investigation is required. @KaibaLopez what was the purpose of adding this test and which services would be affected if this test is not passed.

Same problem here.

@KaibaLopez try it using docke, and probably you will can reproduce:
docker run --rm -it -v $(pwd):/home/app -w /home/app fedora
sudo dnf install libcurl-devel openssl-devel libuuid-devel cmake zlib-devel git g++
mkdir build
cd build
sudo cmake .. -D CMAKE_BUILD_TYPE=[Debug | Release] -D BUILD_ONLY="s3"
make

Is the issue resolved? I have the same issue on centos 7.

Is the issue resolved? I have the same issue on centos 7.

some of my other teammates are not having this issue so it might be some issue from user side. I dont know the exact cause but hopefully support should be able to help with necessary setting for this.

some of my other teammates are not having this issue so it might be some issue from user side. I dont know the exact cause but hopefully support should be able to help with necessary setting for this.

I have the same issue (building with ubuntu 20:04 on wls2:
#46 174.2 [----------] Global test environment tear-down #46 174.2 [==========] 378 tests from 67 test cases ran. (40464 ms total) #46 174.2 [  PASSED  ] 377 tests. #46 174.2 [  FAILED  ] 1 test, listed below: #46 174.2 [  FAILED  ] HttpClientTest.TestRandomURLMultiThreaded #46 174.2  #46 174.2  1 FAILED TEST #46 174.2 make[2]: *** [aws-cpp-sdk-core-tests/CMakeFiles/aws-cpp-sdk-core-tests.dir/build.make:823: aws-cpp-sdk-core-tests/aws-cpp-sdk-core-tests] Error 1 #46 174.2 make[2]: *** Deleting file 'aws-cpp-sdk-core-tests/aws-cpp-sdk-core-tests' #46 174.2 make[1]: *** [CMakeFiles/Makefile2:336: aws-cpp-sdk-core-tests/CMakeFiles/aws-cpp-sdk-core-tests.dir/all] Error 2 #46 174.2 make: *** [Makefile:149: all] Error 2

Same problem here, also on WSL2:
Commands:
sudo apt-get install libcurl4-openssl-dev libssl-dev uuid-dev zlib1g-dev libpulse-dev
cd ~/install
git clone https://github.com/aws/aws-sdk-cpp.git
sudo mkdir sdk_build
cd sdk_build
sudo cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_ONLY="sesv2"
sudo make

Error:
[----------] Global test environment tear-down
[==========] 378 tests from 67 test cases ran. (38279 ms total)
[  PASSED  ] 377 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] HttpClientTest.TestRandomURLMultiThreaded

This has been pretty hard to reproduce, it seems like it is an error on the user side configuration but it's hard to say from just the error messages displayed, can someone who is still seeing this error verify :

gcc and g++ version being used (make sure cmake is using the correct one in case you have multiple versions installed, remember it has to be 4.9 or higher).
Slow internet should not be a problem but a firewall blocking the connection would be, for reference this is not a unit test but a services integrations test, and yea we assume you'll have internet connection for them. If you want to simply build then set -DENABLE_TESTING=OFF on your cmake command.

My gcc and g++ are at version 8.3.0 in my WSL2 and at 6.3.0. on my remote Linux box where I have tried this too. The Linux box succeeds the build and the WSL2 stubbornly keeps failing.
What can I do to help you investigate the problem? Are you also trying the build on a WSL2 ?

I have just gone through the following process to replicate the problem from scratch:

Reinstalled "Debian" from Microsoft Store on my Windows 10 machine.
Pre-installing some libraries

sudo apt install aptitude g++ gcc make git wget autoconf automake
# (I also need a fresh version of cmake so installing like this)
cd ~/install
wget https://cmake.org/files/v3.16/cmake-3.16.0.tar.gz
tar -xzvf cmake-3.16.0.tar.gz
cd cmake-3.16.0
./bootstrap
make -j$(nproc)
sudo make install
# (end of cmake)

Installing the AWS C++ SDK
sudo apt-get install libcurl4-openssl-dev libssl-dev uuid-dev zlib1g-dev libpulse-dev
cd ~/install
git clone https://github.com/aws/aws-sdk-cpp.git
cd aws-sdk-cpp/
mkdir sdk_build
cd sdk_build
cmake .. -DCMAKE_BUILD_TYPE=Debug -DBUILD_ONLY="sesv2"
make

.... and that ends up with the mentioned error.

I don't think there anything too specific in our corporate network, I have never had a problem with any Internet access from inside the company.

I'm hitting this same error on CentOS 7.9.
Host is a VM on ESXi.

GCC / G++: 9.3.0, built from source
cmake: 3.18.4, built from source
aws-cpp-sdk: 1.8.99

I am behind a corporate firewall.
cmake command:
/opt/cmake/bin/cmake ../ -DCMAKE_CXX_COMPILER=/opt/gcc/bin/g++ -DCMAKE_BUILD_TYPE=Release -DBUILD_ONLY="s3"

Test failures:
/home/username/aws-sdk-cpp/aws-cpp-sdk-core-tests/http/HttpClientTest.cpp:81: Failure
Value of: hasPendingTasks
  Actual: true
Expected: false
[  FAILED  ] HttpClientTest.TestRandomURLMultiThreaded (35925 ms)

A workaround for me was to add
-DAUTORUN_UNIT_TESTS=OFF

same issue on NixOS:
gcc: 10.3.0 (compiled)
cmake: 3.19.7 (compiled)
aws-cpp-sdk: 1.8.121
Not behind firewall

Hi, I believe this problem should be fixed as of version 1.9.35 ,
If that is not the case feel free to comment, otherwise I'll be marking this issue for closure (If you don't make it to post here before it closes please open a new issue).

Still reproducable on 1.9.294 as seen in https://github.com/cachix/devenv/issues/302


Pre-configured MSO configurations/ t shirt sizes of nodes

Background: https://airtable.com/tblD3oZPLJgGhCmch/viwchkdQkRUw6hZ3z/recoU3unp8O0VJ9vU?blocks=hide
PM: @kannanlakshmi

Addressed in https://github.com/cockroachdb/docs/pull/5680


typescript defs for Texture &   RenderTarget APIs

been bugging you guys a lot 😬 so here's my tiny little contribution
thanks for sharing your great work. hopefully will be able to help out more once I get more familiar with filament

Thank you!


Validate duplicates on user creation

sqlalchemy.exc.IntegrityError
sqlalchemy.exc.IntegrityError: (sqlite3.IntegrityError) UNIQUE constraint failed: user.username

it's an admin feature. rolled out for one user. lower prio.


Redesign local nav for GDT

Why these changes are being introduced:
The Geodata app requires links to GIS resources at MIT in the local nav. It also no longer requires the app name in the local nav, as GDT-125 moved this to the main header.
Relevant ticket(s):

https://mitlibraries.atlassian.net/browse/GDT-125
https://mitlibraries.atlassian.net/browse/GDT-124

How this addresses that need:
This updates the local nav as specified.
Side effects of this change:
We will likely want to remove the app name from the local nav in all our applications and use the new method provided by the theme gem instead. However, it is out of scope of this ticket (and project) to make that decision, so I've left it in for now.
Developer

[x] All new ENV is documented in README
[x] All new ENV has been added to Heroku Pipeline, Staging and Prod
[x] ANDI or Wave has been run in accordance to
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

[ ] The commit message is clear and follows our guidelines
(not just this pull request message)
[ ] There are appropriate tests covering any new functionality
[ ] The documentation has been updated or is unnecessary
[ ] The changes have been verified
[ ] New dependencies are appropriate or there were no changes

Requires database migrations?
NO
Includes new or updated dependencies?
NO

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.432%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
350

Relevant Lines:
352

💛  - Coveralls

@jazairi Just confirming this is still good with the latest change and can merge whenever you are ready along with the related PR

Thanks @JPrevost! Just waiting on QA before merging.

@JPrevost Just pushed a couple of small changes from QA. I also added the nav title back in (conditionally) to stay consistent with how we plan to manage that for the time being.


run go postgres queries in transaction

Would someone with permissions merge this? I can't :disappointed:

You can now.


ExcelReader: Assume en-us locale when parsing row.height so fractiona…

…l part is properly recognized

Closing this because it neglects the dozens of other places which need fixing too.

Closing this because it neglects the dozens of other places which need fixing too.


refactor: Incorporate RewriteDisjunctivePredicate rule into SimplifyExpressions

Which issue does this PR close?
Closes #13031
Rationale for this change
The rational  for moving the logic in to the SimplifyExpression is that is allows the rule to better interact with other simplifications and also be applied to all logical nodes, not just filters as the current rule is.
The reason for changing the logic is to only only rewrite the Expr when the rule acutally applies. The current code will always change the current structure of the expression which makes our optimizer harded to predict and more sensitive to changes in the order the rules are applied.
The new code is also significantly shorter and at least to me easier to follow.

What changes are included in this PR?
Adding a rule in SimplifyExpressions that will extract common conjuntive predicates in disjuntive predicates and removal of the existing rule RewriteDisjuntivePredicate.

Are these changes tested?
Yes, existing and new tests.

Are there any user-facing changes?
Yes, the rule RewriteDisjuntivePredicate no longer exists.

Looks like a nice refactor. The changed plan looks slightly less optimal (one expression repeated where it was executed only a single time before).

(thank you @eejbyfeldt and @Dandandan )

🚀  -- thank you @eejbyfeldt @Dandandan  and @peter-toth


Reproducibility Issue

I have ran your codes 5 times in the below environment.
Two V100 GPUs
Python 3.6.7
PyTorch 1.0.0
Cuda 9.0

The command I used is this :
python train.py \
--net_type pyramidnet \
--dataset cifar100 \
--depth 200 \
--alpha 240 \
--batch_size 64 \
--lr 0.25 \
--expname PyraNet200 \
--epochs 300 \
--beta 1.0 \
--cutmix_prob 0.5 \
--no-verbose

For the baseline, I set cutmix_prob=0.0 not to use cutmix.
| Model & Augmentations | try1 | try2 | try3 | try4 | try5 | Average
-- | -- | -- | -- | -- | -- | -- | --
cutmix p=0.0 | Pyramid200(Converged) | 17.14 | 16.32 | 16.15 | 16.29 | 16.61 | 16.502
  | Pyramid200(Best) | 17.01 | 16.02 | 16.01 | 16.17 | 16.35 | 16.312
cutmix p=0.5 | CutMix(Converged) | 16.27 | 15.55 | 16.18 | 16.19 | 15.38 | 15.914
  | CutMix(Best) | 15.29 | 14.66 | 15.28 | 15.04 | 14.52 | 14.958
The baseline has a similar top-1 accuracy as your paper said (16.45), but with cutmix(p=0.5), the result is somewhat poor compared to the reported value(14.23).
Also, I conducted an experiments with shakedrop (after codes for shakedrop regularization has been brought from 'https://github.com/owruby/shake-drop_pytorch').
|   | try1 | try2 | try3 | try4 | try5 | Average
-- | -- | -- | -- | -- | -- | -- | --
cutmix p=0.5 | ShakeDrop+CutMix(Converged) | 14.06 | 14 | 14.16 | 13.86 | 14 | 14.016
  | ShakeDrop+CutMix(Best) | 13.67 | 13.81 | 13.8 | 13.69 | 13.62 | 13.718
Here you can see, top-1 accuracy you claimed on the paper can be achieved only by using 'maximum top-1 validation accuracy' during training, not by using 'converged top-1 validation accuracy' after training.
So, here is my questions.

How can I reproduce your result? Especially with your provided codes and sample commands, I should reproduce 14.23% of Top1 Accuracy with PyramidNet+Cutmix. It will be great if you can provide the specific environment and command to reproduce the result or this helps you to find some problems on this repo.

Did you use 'last validation accuracy' after training or 'best validation accuracy(peak accuracy)' while training? I saw some codes tracking the best validation accuracy while training and print out the value before terminating, so I assume that you used 'best(peak) validation accuracy'.

Thanks. I look forward to hearing from you.

@ildoonet

How can I reproduce your result? Especially with your provided codes and sample commands, I should reproduce 14.23% of Top1 Accuracy with PyramidNet+Cutmix. It will be great if you can provide the specific environment and command to reproduce the result or this helps you to find some problems on this repo.

We use pytorch 1.0.0, Tesla P40 GPUs. The paper's experiments were conducted on our cloud system (NSML).
So I recently tested again our code on local machine for CIFAR100 and ImageNet using this repo, and I got slightly lower performance on CIFAR100 (top-1 error 14.5~14.6 as similar to your report) but got better performance on ImageNet (top-1 error 21.4). One possible reason would be the difference between the cloud system and the local machines.
We note that the results (top-1 error 14.5 on CIFAR100) still much better than the important baselines (cutout, mixup, etc). In the camera-ready version of our paper, we might update the performance to 14.5 on CIFAR100 21.4 on ImageNet for better reproducibility using local machines.

Did you use 'last validation accuracy' after training or 'best validation accuracy(peak accuracy)' while training? I saw some codes tracking the best validation accuracy while training and print out the value before terminating, so I assume that you used 'best(peak) validation accuracy'.

As you can see in the code, we choose the best validation accuracy.
Thanks!

@hellbell Thanks, I guess that this reproducibility issue is not from the environment.
I wonder if it is right to use the best validation accuracy. As you can see, the converged model's accuracy is slightly lower than the best one and it is hard to be sure that the best accuracy presents the model's true performance. When I worked on Fast AutoAugment, I used the converged value instead of the instantly peaked high value.
Anyway, thanks for the clarification.

@ildoonet
I agree with your reply at some points and it is worth to see the final performance (or, converged performance) comparisons. But our paper also reports the best performance of other algorithms for fair-comparison by re-implementing. Only a few methods which we cannot reproduce were reported by their original paper's scores.
Anyway, thank you for the constructive comments!

@ildoonet
For your clarification and further discussion, So I re-open this issue.

The baseline has a similar top-1 accuracy as your paper said (16.45), but with cutmix(p=0.5), the result is somewhat poor compared to the reported value(14.23).

I newly ran our code on CIFAR100 three times, and we got
| at 300 epoch | best acc
-- | -- | --
try1 | 14.78 | 14.23
try2 | 15.44 | 14.5
try3 | 15 | 14.68
average | 15.07 | 14.47
Also, for ImageNet-1K, we got
| at 300 epoch | best
-- | -- | --
try1 | 21.20 | 21.19
try2 | 21.61 | 21.61
try3 | 21.40 | 21.40
average | 21.403 | 21.400
Interestingly, we got the best performance near the last epoch of the training.

I wonder if it is right to use the best validation accuracy. As you can see, the converged model's accuracy is slightly lower than the best one and it is hard to be sure that the best accuracy presents the model's true performance.

For ImageNet-1K task, many methods report their best validation accuracy during training because they cannot approach the 'test dataset'. Of course, we will add the statement to our final paper We report the best performance during training. for the clarification.
We evaluated on CIFAR datasets using the same evaluation strategy. And we try our best to reproduce the baselines (mixup, cutout, and so on) and report their best performance for fair-comparison.
But I have a question about what is the true performance as you said.
I'm not sure the only way to represent the true performance of the model is to report the last epoch's performance because the model could fluctuate at the end of the training and we cannot guarantee the model was converged at the last epoch. Therefore, researchers usually train models and pick their best models by validating on the validation set.
In short, we choose the best model to represent the performance of the model and I think two approaches, selecting best model or last model, are both making sense to evaluate the trained models.
But your comments about the best and last models are very worth to consider for future work.

When I worked on Fast AutoAugment, I used the converged value instead of the instantly peaked high value, and as far as I know, AutoAugment measure the performance in a same way.

First, it is a nice work for the Fast AutoAugment!
In my guess, Fast AutoAugment and AutoAugment may use cosine learning rate decaying, so they are less fluctuating at the end of training, so the best performance and last performance would be similar.
I recently found CutMix + cosine learning rate works well with CIFAR dataset, so we will report both the best and last performance when using cosine learning rate. I hope the gap between the best and the last models would be smaller than current training scheme.

@ildoonet
For your clarification and further discussion, So I re-open this issue.

The baseline has a similar top-1 accuracy as your paper said (16.45), but with cutmix(p=0.5), the result is somewhat poor compared to the reported value(14.23).

I newly ran our code on CIFAR100 three times, and we got
at 300 epoch	best acc
try1	14.78	14.23
try2	15.44	14.5
try3	15.00	14.68
average	15.07 14.47
Also, for ImageNet-1K, we got
at 300 epoch	best
try1	21.20	21.19
try2	21.61	21.61
try3	21.40	21.40
average	21.403 21.400
Interestingly, we got the best performance near the last epoch of the training.

I wonder if it is right to use the best validation accuracy. As you can see, the converged model's accuracy is slightly lower than the best one and it is hard to be sure that the best accuracy presents the model's true performance.

For ImageNet-1K task, many methods report their best validation accuracy during training because they cannot approach the 'test dataset'. Of course, we will add the statement to our final paper We report the best performance during training. for the clarification.
We evaluated on CIFAR datasets using the same evaluation strategy. And we try our best to reproduce the baselines (mixup, cutout, and so on) and report their best performance for fair-comparison.
But I have a question about what is the true performance as you said.
I'm not sure the only way to represent the true performance of the model is to report the last epoch's performance because the model could fluctuate at the end of the training and we cannot guarantee the model was converged at the last epoch. Therefore, researchers usually train models and pick their best models by validating on the validation set.
In short, we choose the best model to represent the performance of the model and I think two approaches, selecting best model or last model, are both making sense to evaluate the trained models.
But your comments about the best and last models are very worth to consider for future work.

When I worked on Fast AutoAugment, I used the converged value instead of the instantly peaked high value, and as far as I know, AutoAugment measure the performance in a same way.

First, it is a nice work for the Fast AutoAugment!
In my guess, Fast AutoAugment and AutoAugment may use cosine learning rate decaying, so they are less fluctuating at the end of training, so the best performance and last performance would be similar.
I recently found CutMix + cosine learning rate works well with CIFAR dataset, so we will report both the best and last performance when using cosine learning rate. I hope the gap between the best and the last models would be smaller than current training scheme.

I guess that if you mention the best & converged accuracy, it will be okay. Mentioning only instantly peaked high value is somewhat considered as cheating or validation over-fitting.
But as you can say, true performance of the model is hard to measure even if we have a held-out set only for testing.
Also, I trained with cosine learning rate for many models but there are similar gaps also.
Anyway Thanks for your consideration and long explanations. This is very helpful for me to think lot of things.

@ildoonet
Thank you for your reply.
I do understand your concerns but I don't agree that mentioning the best performance is cheating. As I said, the best model surely can be treated to represent the performance of the method. The difference between the best and the last model is coming from the step decaying learning rate. In our case of using cosine learning rate on CIFAR100, the best and last model is almost the same (within +- 0.1% acc).
All the experiments we re-implemented are conducted in the same experiment setting, the best model is selected for every other method, so there is no cheating and fair-comparison issues.
Our best model's performance is not instantly peaked high value because we conducted several times and report the mean of the best performances.

I guess that if you mention the best & converged accuracy, it will be okay. Mentioning only instantly peaked high value is somewhat considered as cheating or validation over-fitting.
But as you can say, true performance of the model is hard to measure even if we have a held-out set only for testing.
Also, I trained with cosine learning rate for many models but there are similar gaps also.
Anyway Thanks for your consideration and long explanations. This is very helpful for me to think lot of things.

If choosing the best performance is cheating, then many people are cheating. So I don't agree with your point. Rather, @hellbell is fairly correct. Thanks for the interesting work

'Cheating' is a rather harsh word. However, comparing the peak value indeed benefits oscillating and risky methods.

I deeply apologize for the misrepresentation of poor English and poor word choice. CutMix inspired me a lot and helped me a lot in my research.


rename args: is_multiclass -> multiclass

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
fix unclear argument...
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

why do we want to deal with that topic again

what do you mean?

what about backwards compatibility?

@SkafteNicki mind re-check :]


Separating the 'validation' contracts logic from crowdsale contracts

🎉 Description
Whitelists and other access/validation functionalities should be standalone contracts, independent of crowdsale contracts. The rationale is that other types of contracts (e.g. gouvernement, exchanges, +18y/o games) might want to implement some sort of access control logic gates. I would suggest rewriting some of contracts along these lines. For instance, WhitelistedCrowdsale.sol could be rewritten as Whitelisted.sol, like this. A Whistelisted contract could then be set to WhitelistedCrowdsale is Whitelisted, Crowdsale, Ownable { ... }.

[ ] 🐛 This is a bug report.
[x] 📈 This is a feature request.

This has been as proposed for a while now, closing.


Using Multiple traits results in unexpected results

Hi -
Thanks for creating and maintaining this, it is fantastic!
I'm using the below code to snapshot a tableview cell.  It works great except for the fact that all four snapshots are identical on iPhone.  This is not what I would expect.
assertSnapshot(matching: gasCell!.contentView, as: .image(traits: .init(horizontalSizeClass: .regular)), named: "gasCell-horizontal-regular")

assertSnapshot(matching: gasCell!.contentView, as: .image(traits: .init(horizontalSizeClass: .compact)), named: "gasCell-horizontal-compact")

assertSnapshot(matching: gasCell!.contentView, as: .image(traits: .init(verticalSizeClass: .regular)), named: "gasCell-vertical-regular")

assertSnapshot(matching: gasCell!.contentView, as: .image(traits: .init(verticalSizeClass: .compact)), named: "gasCell-vertical-compact")

My gut says I'm misunderstanding something but after researching most of evening I'm still expecting different results than I'm seeing.

After reviewing the docs (https://developer.apple.com/documentation/uikit/uitraitcollection)
It looks like iPhone results in these valid combinations:

Portrait:  Vertical is Regular, Horizontal is Compact
Landscape:  Vertical is Compact, Horizontal is Compact

And iPad results in these valid combinations (our app is universal and we run in full screen only)

Portrait:  Vertical is Regular, Horizontal is Regular
Landscape:  Vertical is Regular, Horizontal is Regular

I have two questions:
Why doesn't my code produce different snapshots for the verticalSizeClass: .regular and verticalSizeClass: .compact traits when run on iPhone?
I expect to see differently sized images for vertical compact vs. regular.
I assume horizontal-regular isn't valid, so assume iOS is just ignoring my error and using .compact.
Why do I get different image sizes when run on iPad vs. iPhone?
This prevents me from running the test case on both iPhone and iPad simulators.

It feels like I'm doing something wrong or don't fully understand how the images are generated.  Any suggestions or clarification you can offer would be greatly appreciated.
Thanks!
Adam Wolf

I have the same issue. Screenshots generated on an iPhone but with regular width size class do not use the proper storyboard constraints and do not reflect the actual UI that shows up on an iPad.


CSV Output

Exporting the staking balances to a .csv would be handy...

Added this capability to parser.rb in commit 27ff8ae
Should be straightforward to add to eur_parser and usd_parser as well, will close this once I get around to that


Update DataConnector.md

Hi Syed!
I changed URL link. Please check it!

Hi @srajamohamed
Please check my PR!


Revert "Hand Gesture Vehicle Control"

Reverts UTSAVS26/PyVerse#78
@aviralgarg05 please check the image path too that you have given in the code they are not matching.

So should I create a separate PR to update the Readme.md?

So should I create a separate PR to update the Readme.md?

You need to rename the files again don't used double inverted in the names, use only understand and also update the code based on the update file names.

@aviralgarg05 and do this on urgent basis

I will do it asap

All the best 👍


displaying error when org has more than 1000 sobjects

In #1223 it was found that launching the new wizard when they are more than 1000 sObjects in the org will through an error due to a limit in VF collection sizes. As a stop gap, this displays an error instructing the user to use the legacy page.
Critical Changes
Changes
Issues Closed

Personally, I love that you added a custom label as it is best practice. From a consistency perspective on this project, it's a first, though: So far no custom labels were used, all Error Messages are hard coded Strings. I think we should keep it that way unless otherwise decided.

Definitely feels weird removing a custom label to hard code it, but it makes sense for this project! Just made the changes


replace 'flutter pub' with 'dart pub'

Description
Hi!
Since flutter pub has been deprecated, I have updated the Useful Commands in the README by replacing the command with dart pub.

Hello @yamawo, you sure flutter pub is deprecated? I would be surprised 🤔
AFAIK dart pub and flutter pub they are not the same, related yes, but not the same. Every Flutter project is a Dart project but not every Dart project is a Flutter project, therefor you would use dart pub for pure dart projects and flutter pub for Flutter projects.
Check out Dart command line tools https://dart.dev/tools/dart-tool
Check out Flutter command line tools https://docs.flutter.dev/reference/flutter-cli
Quote from dart pub specific command explanation https://dart.dev/tools/pub/cmd:

This site uses dart pub  for its examples, but if your current directory holds a Flutter app or other Flutter-specific code, use flutter pub  instead. For more information, see Using packages on the Flutter website.

Closing due to lack of response.


Jupyter dataframe column names is inconsistent

Get a csv with a couple of columns
Create a dataframe from them
Run the cells
Run df. and see if the column names appear.

Expected results:
They always do
Actual result:
They sometimes do.

@rchiodo has a fix.


[PLUGIN-440] Increment bytes read/written counter in Bigtable source/…

…sink

I have verified that bytes in/out show up in the spark UI.

/gcbrun


Fail to setup T265 fisheye frame at rs2_pipeline_start_with_config (using C API)

.

@RealSenseSupport Could you please look at this?


OSX "Look Up" is misaligned

Operating System:

[x ] macOS

Clear steps to reproduce the issue:

"Force Touch" on any word in a chat or right click and select "Look Up"

The pop-up displays the correct definition, but the text is weirdly offset and selections get all sorts of out-of-whack

Relevant error messages and/or screenshots:

@strob can you reproduce this in chrome or in some other app?

Chrome and other apps (including other Electron apps) work fine; it seems like there's a known issue with Electron, but some Electron projects seem to get it working.

but some Electron projects seem to get it working.

@strob can you name a few?

Well, Slack for instance...

This is how it looks on my macOS -

Looks like it’s working for you!
I can confirm that Zulip 2.3.82 on macOS 10.14.3 still exhibits “Look Up” offset issues for me.

On Mar 19, 2019, at 12:03 PM, Akash Nimare<EMAIL_ADDRESS>wrote:
This is how it looks on my macOS -
https://user-images.githubusercontent.com/2263909/54634139-8f8eb900-4aa7-11e9-905b-11bee020a2a5.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/zulip/zulip-electron/issues/597#issuecomment-474528140, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMupx_cyhztnn31auxmpLiDde1KsBEYks5vYTSJgaJpZM4YphPc.

@strob can you please try to update to the beta version which is v2.5.0-beta and see if this works as expected? Follow the steps -

Turn on get beta updates option from setting
Restart the app
You'll get an update popup - choose install later and restart.
Check if the problem still exists.

The issue is addressed for me in v2.5.0-beta!
I will say that upgrading to beta was anything but smooth. It took >5 restarts and >10 dialogs. This was the scariest one I saw:

Good to know this worked. Yeah, the updater thing broke in last stable release which we fixed in the current beta version :)


Slice performance

Testing this code:
    DATA:
      BEGIN OF ls_record,
        records TYPE stringtab,
      END OF ls_record.

    TYPES:
      ty_packed TYPE p LENGTH 16 DECIMALS 6.

    DATA(index) = 0.

    DO 5000 TIMES.
      index = index + 1.
      INSERT |Line{ index }| INTO TABLE ls_record-records.
    ENDDO.

    DATA(ajson) = zcl_ajson=>create_empty( ).

    ajson->set( iv_path = `/` iv_val = ls_record ).

    GET RUN TIME FIELD DATA(l_start).

    DO 5000 TIMES.
      ajson->slice( `records` ).
    ENDDO.

    GET RUN TIME FIELD DATA(l_end).

    out->write( |{ l_start } -> { l_end }| ).
    out->write( |Runtime: { CONV ty_packed( ( l_end - l_start ) / 1000000 ) NUMBER = USER } seconds| ).

Runtime before: 57,843338 seconds
Runtime after: 33,875135 seconds

Tests success

nice improvement!

Good optimization, thanks ! I added a benchmark - #157 - for the slice (a bit trickier - to have several root nodes to select from). And results are as good.
Before

After

Merging


⚠ Jenkins Plugins Artifactory has degraded performance

In 9767dba, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1184 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 74fb6b9 after 12 minutes.


Remove version: IurieNistor.GeonkickPlugin version 3.0.1

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Geonkick-Synthesizer/geonkick/releases/download/v3.0.1/GeonkickInstaller.msi
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 897)


Security audit based on rfc6819

rfc6819 contains OAuth 2.0 Threat Model and Security Considerations.
Review thread model

[ ] 4.1 Clients
[ ] 4.2 Authorization Endpoint
[ ] 4.3 Token Endpoint
[ ] 4.4 Obtaining Authorization
[ ] 4.5 Refreshing an Access Token

Review security considerations

[ ] 5.1. General
[ ] 5.2. Authorization Server
[ ] 5.3. Client App Security
[x] 5.4. Resource Servers
[x] 5.5. A Word on User Interaction and User-Installed Apps

A note on section 5.4
Certificate based HTTP authentication as proposed by section 5.4.2 is out of most resource provider's scope. RESTful APIs are meant to work well with public clients and user agents. Certificate based authentication is thus unfortunately not realistic.

A note on section 5.3
Section 5.3 deals with client app security and is therefore out of hydra's scope. For transparency reasons and good practices, it has been added to the readme.


MudNavGroup should not be adding aria-expanded to div class="mud-collapse-container mud-collapse-entered mud-navgroup-collapse"

Things to check

[X] I have searched the existing issues for this bug
[X] To rule out a caching problem I made sure the bug also happens in an incognito tab

Bug type
Component
Component name
MudNavGroup
What happened?
MudNavGroup appears to be adding an extra aria-expanded to it's first div (mud-collapse-container):

          ...

Accessibility Insights is flagging the use of aria-expanded on the div. Based on Mozilla's docs it looks like aria-expanded should only be appears on the button element, which it is, alongside aria-controls.
I still find WCAG difficult after many years, but hopefully this is correct. For what it's worth if I remove aria-expanded from the div it makes Accessibility Insights's browser extension happy.
Expected behavior
aria-expanded is only added to the outer nav alongside aria-controls.
Reproduction link
https://try.mudblazor.com/snippet/wEGSYCmUByiuTfKV
Reproduction steps

Load https://try.mudblazor.com/snippet/wEGSYCmUByiuTfKV
Inspect the output's markup
aria-expanded is present on the first div (mud-collapse-container)
...

Relevant log output
No response
Version (bug)
7.6.0
Version (working)
No response
What browsers are you seeing the problem on?
Chrome, Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Interesting. It's because the internal MudCollapse binds to aria-expanded but it should really be on the button that controls it like you said.


perf: use @react-navigation/native-stack and @react-navigation/native v6

Description
Moves to @react-navigation/native-stack from @react-navigation/stack for increased performance. Initial testing shows a ~28% memory usage reduction from 350MB to 250MB; however, loading a large amount of transaction in the transaction feed will increase memory usage both on main and in this branch.
Some types errors are ignored when using<EMAIL_ADDRESS>and navigators with 5.x.x versions such as @react-navigation/drawer and @react-navigation/material-top-tabs: mixing Navigators versions is ok until all v5 packages can be upgraded: docs.
Code changes

Removed src/onboarding/UseBackToWelcomeScreen.tsx and replaced the functionality with popToScreen function in  src/navigator/NavigationService.ts which is now called in the PincodeSet.tsx instead.
import/saga.ts no longer calls NavigateClearingStack. Instead after navigating to the verification education screen the device back is disabled. This was due to issues with the navigation state after restoring on initial app load.

UI changes

On iOS the pincode entry is no longer a modal. This matches the behavior on Android.
Some animation between screens might be different than expected - we can adjust this with the animation prop.

Dependency Changes
Removed Packages
@react-navigation/compat
@react-navigation/core
@react-navigation/stack
Added Packages
@react-navigation/native-stack
@react-navigation/elements
Upgraded Packages
@react-navigation/native - 5.9.8 -> 6.0.13
Tested
Tested locally on iOS iPhone 11 15.5 and Android SDK 21, 29 & 31.
How others should test
Devs

Run the app in profile mode on Android and check the memory usage yarn dev:android -e mainnet -r -t.
Follow the steps in the profile section of the WALLET.md.
Check for misaligned buttons, incorrect background colors, or text in headers.
Check for screens not properly dispatched / pincode entry not dispalyed.

QA

Navigate through onboarding screens and ensure that the proper header is displayed.
Navigate through the Add & Withdraw flows and ensure the proper header is displayed.
Navigate through setting items and ensure that the proper header is displayed.
Navigate through the send and receive flows and ensure that the proper header is displayed.
Check the QR code scanner header is displayed correctly.
Check for screens not shown in proper order or pincode entry not displayed.

Related issues
RET-361
Backwards compatibility
Yes

A list of small items to fix
please feel free to add more as a comment if not already mentioned.

[ ] Back button on swapReviewScreen.tsx header
[ ] Invites Header alignment

@Jean I was able to fix the send confirmation screens seen in Bidali; however, I was unable to reproduce any of the other 3 screens issues on iOS. Is it possible the podfile was not updated when you tested?

i wasn't able to repro the first 2 observations @jeanregisser had, the header on the welcome screen was transparent and the header on the recovery screen was not overlapping the status bar for me. I did run into this weird issue where if i skip phone verification, the "are you sure you want to skip" dialog doesn't get dismissed and the app becomes stuck. this happens to me on the create and the restore flow. are you able to repro?
https://user-images.githubusercontent.com/20150449/200870363-25526cc0-fb16-4d5c-8788-883d5551cfbe.mp4
i also see there is too much horizontal padding on the headers for screens like the onboarding screens, webview, bidali etc. - i didn't dig into where these changes are coming from but i think they are new. on the screenshot below the close button has too much left padding and on screens where there is a right element (e.g. the first welcome screen) the right padding is also too big?

@kathaypacific it's really strange I am unable to reproduce the header errors any of the listed screens:
Welcome, Language, Settings, Add funds, or Edit Profile. I am also unable to reproduce the app freeze seen from the  VerificationEducation. @jeanregisser are you able to reproduce these issues?

One last question, do we need to restore dispatch(cancelCreateOrRestoreAccount(...) that used to be handled by UseBackToWelcomeScreen @MuckT?

I just checked and if we don't dispatch(cancelCreateOrRestoreAccount(...), and the user kills the app before importing their account but after having entered their PIN, the next time the app is started it will show the Import screen. Which is somewhat of a problem because the PIN isn't persisted.
https://github.com/valora-inc/wallet/blob/66f8169e107b3bbc1667fc559a0327d77eb44204/src/account/reducer.ts#L129-L135
So I restored that behavior: https://github.com/valora-inc/wallet/pull/3004/commits/518f51623b908232b1eec9745a05e1eb7299039c
There are probably more edge cases to fix though, which were already broken prior to this PR.


WIP: centosci-tasks-29jlk: Check for NPM dependency updates

Check for any outstanding update of point version of any outstanding NPM package dependency

[ ] npm-update

npm-update in progress on centosci-tasks-29jlk.
Log: http://fedorapeople.org/groups/cockpit/logs/npm-update-570-20190304-071010/


[Bug] Problem with database.

Current Behavior
I have exported my old database and then exported just the proxy's list to a csv.
I then recreated my docker fully and started from scratch and tried to just import my proxy's list.
Everything looks the same between the old and the new database proxy's tables.
After logging in, I go to proxy's and I see this error: Cannot read properties of null (reading 'name')

I might be doing something wrong but I am not sure what.
Another question that kind of goes along with this is how do I change it from using sqlite database to using my mariadb database in unraid? I tried changing the database location from the default path to the ip and port of my mariadb and on mariadb I had created the npm database and npm user with the npm password that is shows on the webpage
Expected Behavior
I thought I should just be able to import a csv file into the database into the table I want to restore of all my previously exported table data.
Steps To Reproduce
Inside Unraid install the Nginx Proxy Manager (NPM).
Create proxies.
Stop Container.
Export the database file and open with some database reader. (I used: DBrowser (SQLite))

Export Proxy table to csv file.
Back in Unraid  install the Nginx Proxy Manager (NPM) again fresh (delete all old folders and data)
Get logged in first time and change default user.
Stop container.
Export the database file and open.
Import the csv file into database.
Save and put database back on unraid.
Start NPM again and log in.
Check Proxy's
Environment

OS: Unraid
OS version: Version: 6.11.5
CPU: Intel® Core™ i5-3470 CPU @ 3.20GHz
Docker version: Docker version 20.10.21, build baeda1f
Device model:
Browser/OS: Chrome

Container creation
Not sure what this is since I don't see this in unraid until I build it or edit it again.
Side note I change the 'DB back to the file so that is what I am using right now'
docker run
-d
--name='Nginx-Proxy-Manager-Official'
--net='back_bridge_network'
-e TZ="America/Los_Angeles"
-e HOST_OS="Unraid"
-e HOST_HOSTNAME="Tower"
-e HOST_CONTAINERNAME="Nginx-Proxy-Manager-Official"
-e 'DB_SQLITE_FILE'='/data/database.sqlite'
-l net.unraid.docker.managed=dockerman
-l net.unraid.docker.webui='http://[IP]:[PORT:81]'
-l net.unraid.docker.icon='https://nginxproxymanager.com/icon.png'
-p '81:81/tcp'
-p '80:80/tcp'
-p '443:443/tcp'
-p '3000:3000/tcp'
-v '/mnt/user/appdata/Nginx-Proxy-Manager-Official/data':'/data':'rw'
-v '/mnt/user/appdata/Nginx-Proxy-Manager-Official/letsencrypt':'/etc/letsencrypt':'rw'
-v '/tmp/Nginx-Proxy-Manager-Official/var/log':'/var/log':'rw'
--memory=1G
--no-healthcheck 'jc21/nginx-proxy-manager'
Container log
root@Tower:~# docker logs Nginx-Proxy-Manager-Official
❯ Configuring npm user ...
❯ Configuring npm group ...
❯ Checking paths ...
❯ Setting ownership ...
❯ Dynamic resolvers ...
❯ IPv6 ...
Enabling IPV6 in hosts in: /etc/nginx/conf.d
- /etc/nginx/conf.d/default.conf
- /etc/nginx/conf.d/include/assets.conf
- /etc/nginx/conf.d/include/block-exploits.conf
- /etc/nginx/conf.d/include/force-ssl.conf
- /etc/nginx/conf.d/include/ip_ranges.conf
- /etc/nginx/conf.d/include/letsencrypt-acme-challenge.conf
- /etc/nginx/conf.d/include/proxy.conf
- /etc/nginx/conf.d/include/ssl-ciphers.conf
- /etc/nginx/conf.d/include/resolvers.conf
- /etc/nginx/conf.d/production.conf
Enabling IPV6 in hosts in: /data/nginx
- /data/nginx/proxy_host/1.conf
- /data/nginx/proxy_host/3.conf
- /data/nginx/proxy_host/2.conf
- /data/nginx/proxy_host/4.conf
❯ Docker secrets ...

-------------------------------------
 _   _ ____  __  __
| \ | |  _ \|  \/  |
|  \| | |_) | |\/| |
| |\  |  __/| |  | |
|_| \_|_|   |_|  |_|
-------------------------------------
User:  npm PUID:0 ID:0 GROUP:0
Group: npm PGID:0 ID:0
-------------------------------------

❯ Starting backend ...

❯ Configuring npm user ...
0
usermod: no changes
❯ Configuring npm group ...
❯ Checking paths ...
❯ Setting ownership ...
❯ Dynamic resolvers ...
❯ IPv6 ...
Enabling IPV6 in hosts in: /etc/nginx/conf.d
- /etc/nginx/conf.d/include/assets.conf
- /etc/nginx/conf.d/include/block-exploits.conf
- /etc/nginx/conf.d/include/force-ssl.conf
- /etc/nginx/conf.d/include/ip_ranges.conf
- /etc/nginx/conf.d/include/letsencrypt-acme-challenge.conf
- /etc/nginx/conf.d/include/proxy.conf
- /etc/nginx/conf.d/include/ssl-ciphers.conf
- /etc/nginx/conf.d/include/resolvers.conf
- /etc/nginx/conf.d/default.conf
- /etc/nginx/conf.d/production.conf
Enabling IPV6 in hosts in: /data/nginx
- /data/nginx/proxy_host/1.conf
- /data/nginx/proxy_host/3.conf
- /data/nginx/proxy_host/2.conf
- /data/nginx/proxy_host/4.conf
❯ Docker secrets ...

-------------------------------------
 _   _ ____  __  __
| \ | |  _ \|  \/  |
|  \| | |_) | |\/| |
| |\  |  __/| |  | |
|_| \_|_|   |_|  |_|
-------------------------------------
User:  npm PUID:0 ID:0 GROUP:0
Group: npm PGID:0 ID:0
-------------------------------------

❯ Starting nginx ...

No response

I think you opened this issue at the wrong place.  The project for the container image you are using is there: https://github.com/NginxProxyManager/nginx-proxy-manager


⚠ Processors has degraded performance

In 37da5a8, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 140 ms

Resolved: Processors performance has improved in 7ee36f4.


[UI] Quote / Blockquote

+1

+1

+1

+1.  Wow, this would be so helpful! 👍

+1

+1

Also deeply interested!  Will try tackling this soon.

+1

+1

We need this feature!

I don't think stalebot should mark things as stale when they've got a label with a priority


Refactor CSS

Is your feature request related to a problem?
Currently, we have tons of CSS which I think is either obsolete or already covered in Bulma Helpers.
Moreover, some styles are fighting against each other, so there is inconsistency.
Describe the solution you would like
Have global CSS config for base styles?
Describe alternatives you have considered
UnCSS can be your friend
Screeenshots
KodaDot CSS cat

In some components the css is defined globally, we have strange behavior on other pages because it overwrite rules.
We will need to move css outside component into a file (styles/global.scss) or make it scoped.

@vikiival, I think it is high time there is some sort of instructions on how things should be done. You may add it to CONTRIBUTING.md or even README.md. It will really help guard against how changes affect already existing implementation while the full refactoring is implemented. I suggest all styles should be scoped till then.

@vikiival and @roiLeo, what are plans on setting rules for this. Is any one working on it yet?

Game rules are pretty simple:

prefer bulma css over custom css
move duplicate css into separate  scss files
for component which have css use scoped.

@roiLeo have I missed anything?

I added the "global" comment in some files where the css was duplicated.
There are also many unused css rules that can be removed.

Still open as the CSS is not refactored yet 😅

@vikiival i can take up this refactor

What is the priority for this?

I would give it p3 I think we have more imporant tasks to tackle

👀

I can start working on this now, just to confirm, our focus is

[ ] prefer bulma css over custom css
[ ] move duplicate css into separate scss files
[ ] for component which have css use scoped

CC @roiLeo @vikiival

Yeah,
but be aware that many components have changed (are rewritten via Composition API by @preschian )

is now a good time to start working on this? I dont want to get conflicts with the refactors and stuff? @roiLeo @vikiival @preschian

is now a good time to start working on this?

I don't think so since major part will be done when refactoring component, refer to #3710
But feel free to help on rewritting component vue3 way and/or with new design (#3844)

is now a good time to start working on this?

I don't think so since major part will be done when refactoring component, refer to #3710 But feel free to help on rewritting component vue3 way and/or with new design (#3844)

@roiLeo where are we doing the vue3 rewrite?

@roiLeo where are we doing the vue3 rewrite?

We'll need to rewrite every components, some of them have already been done (#3825, #3771, #3718)

#4584

@roiLeo can we close this one now?


Prepend configuration name with haste-map

Summary
During debugging some FS problem on my machine I found that one of the files created looked a bit ugly with no sensible name. After some more debugging I found out that this was the haste-map generated by jest.
Test plan
Run jest and check if the generated file in the cache has been changed to a filename with haste-map prepended.

Current coverage is 88.01% (diff: 100%)

Merging #2014 into master will not change coverage

@@             master      #2014   diff @@
==========================================
  Files            38         38
  Lines          1252       1252
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1102       1102
  Misses          150        150
  Partials          0          0

Powered by Codecov. Last update e0e714d...aec9e0d

I can live with this.

Thanks for the contribution!


Improve support for .sql files

The output of mdls on my system is as follows:
kMDItemContentType     = "com.sequelpro.sequelpro.sql"
kMDItemContentTypeTree = (
    "com.sequelpro.sequelpro.sql",
    "public.plain-text",
    "public.text",
    "public.data",
    "public.item",
    "public.content"
)

Would it be possible to support this?

Sure! I found a few more UTIs in Sequel Pro's repository. Besides com.sequelpro.SequelPro.sql, two others implement public.plain-text, so it should be possible to generate previews for them:

com.sequelpro.SequelPro.spf
com.sequelpro.SequelPro.spTheme

Would you be able to find out what kind of data is stored these files so we can apply syntax highlighting to them?

I would be happy to help! Just not quite sure what you are referring to with "kind of data". These .sql-files are just regular SQL dumps in my case, so probably just plaintext?
It's just my OS associates these files with Sequel Pro.

I'm wondering what kind of information is stored in spf and spTheme files, so I can specify the correct language for syntax highlighting. spTheme seems to be XML. I couldn't find an example for spf yet, would you mind trying to generate one and seeing what's in it?

Aha! I was able to export a .spf-file, just like spTheme it's XML. Hope this helps :)

Added, thanks!

Awesome! Thank you too!


Enforce retention policies

This is work-in-progress, as I have some questions about this untested implementation, and also need to add unit-testing.

To summarize the implementation follows.
Each data node runs the "retention policy enforcement" loop, and looks for shard groups within each Retention Policy, which have an "end time" earlier than now. For all matching shard groups, a command is sent to the Raft cluster, requesting deletion of this shard group. Each data node, upon receipt of this command, deletes any shards it has associated with this shard group, and updates its local copy of the metastore.
Because all data nodes will run the loop, it does mean that multiple deletion commands may be generated for a given shard group -- the data nodes account for this by simply ignoring requests to delete non-existent shard groups.

Unit tests added, green build.
Still need to perform some system testing.

One small comment, but other than that LGTM

I performed a system test this morning, using an actual influxd process. Code looks good. I created a long (1 hour) and short (1 minute) retention policy, and wrote data to each. Within a couple of minutes (system had a retention check interval of 30 seconds) the short policy's shard groups were deleted. Log follows.
[srvr] 2015/02/11 10:18:04 broker enforcing retention policies with check interval of 30s
...
[srvr] 2015/02/11 10:18:34 retention policy enforcement check commencing
[srvr] 2015/02/11 10:19:04 retention policy enforcement check commencing
[srvr] 2015/02/11 10:19:34 retention policy enforcement check commencing
[srvr] 2015/02/11 10:20:04 retention policy enforcement check commencing
[srvr] 2015/02/11 10:20:04 shard group 1, retention policy short, database foo due for deletion
[srvr] 2015/02/11 10:20:34 retention policy enforcement check commencing

Queries of data in short returned no results, but queries of data in long did.

This appears to be an integration test failure, I haven't seen it before. The integration tests may still be racy.
I'll kick Travis and try again.

Green build, we appear to have some racy tests. This is currently captured by issue #1556.


enhancementshow user friendly error msg when window function contains order by expression

pick from master https://github.com/apache/doris/pull/40937
Proposed changes
Issue Number: close #xxx

run buildall

run buildall