Naming of the classes Room and Storey in the Building module

In the Building module, the Room class is simply named Room, whereas in the Bridge module the class is named BridgeRoom. Should we change the name to BuildingRoom, to be consistent in naming? Also, all other classes like Installation, Furniture, etc. have the prefix Building.
In addition, the name of the class Storey should then be changed to BuildingStorey as well.

+1 for consistent naming, but I am not sure whether prefixing of class names in addition to the module namespace prefixes is necessary.

Agree with @hlg that the module namespaces should be sufficient. So I think we should use Room in all modules rather than BuildingRoom and BridgeRoom. If possible, common concepts could even be drawn to the Construction base module.

I am closing this issue with the resolution that the classes should have the name "Room" and that the module namespace is adequate to disambiguate the use of the similar (same?) concept in different contexts.

Reopening since the proposal has not been considered in the latest editor‘s draft.

We discussed different scenarios in the modelling sub-group. There was agreement that a consistent naming scheme should be applied to all modules.
Using the same class names like Room or Installation in different modules is technically possible since the classes live in different namespaces. However, it also causes confusion when referencing the concepts and might impede implementations. Drawing classes with identical meaning to a common base module is also a valid option. But in this case, ADE extensions could only be applied on the level of the base module. For instance, it would not be possible anymore to inject specific ADE attributes only to building rooms but not to bridge rooms. This was considered a major drawback, not only because it is possible in CityGML 2.0.
The consensus in the group was therefore that class names should not be identical over modules. To fix the issue, it is proposed to use the module name as prefix wherever required. So, in answer to the initial post, the classes Room, Installation, Furniture etc. in the building module should be renamed to BuildingRoom, BuildingInstallation and so on.

The original issue also mentioned Storey, which only exists in the building module, as far as I could see. Should the prefix convention also extend to all class names that appear only in one module or be restricted to those that appear in more than one module?

My opinion is that the principle is "identical names for different concepts should not be used within (obvious) or across modules".  This is in addition to the possibility of using namespace names to disambiguate.
So if a name only appears in one module, it need not be prefixed. If a new module is created or existing module is changed, then all existing modules should be examined to identify possible name clashes. Prefix(es) or name changes should be used to eliminate the conflict(s).
If the names are truly identifying the same concept, then an effort should be made to define the concept once in a core module.

Agree with @3DXScape that prefixing should not be required if a name only occurs in a single module.
Defining an overarching concept in a base/core module makes sense. Still we need an instance (with prefixed name) in every submodule to enable ADE attribute injections.

This is, what I was assuming too. Just wanted to clarify because the summary was not clear about this aspect of the original isuue.

This issue will be closed, as in the webconference on 21 February 2019 it was decided to rename Room to BuildingRoom, but to keep the name Storey as it is, based on above discussion that prefixes are only to be used when the name appears in more than one module.


dryrun

a dry run will interact with the data-server from the api-server direct w/o storing the object.
todo:

align api with data-server
map the result to the CR status

results in a diff of the running config
merge an intent (candidate); validate against schema; generating what you would send to the device.


VM is not available for ssh connection on operation complete

Environment details

OS: Mac 10.14.5
Node.js version: 12.6.0
npm version: 6.9.0
@google-cloud/compute version: 1.1.1

Steps to reproduce

create a VM using the compute client
on operation complete, spawn a bash child process to ssh into the created vm using the gcloud compute ssh command.
process fails with ssh: connect to host <external-ip> port 22: Connection refused

However if the gcloud command is run not immidiately after operation.on('complete', ...) is triggered, but rather with a slight delay, the ssh connection is made successfully.

The operation that is returned from an "instances.create" operation is an "insert" operation. When that operation finishes, the state can be any of the ones listed here: https://cloud.google.com/compute/docs/instances/instance-life-cycle.
To wait for the RUNNING event, we actually have a method called "vm.waitFor()"! https://googleapis.dev/nodejs/compute/latest/VM.html#waitFor
Let me know if there are any issues with this solution.

Thank you @stephenplusplus for your reply.
As stated in the life cycle documentation:

RUNNING - The instance is booting up or running. You can connect to the instance shortly after it enters this state.

Seems to me there is no state that guarantees the instance has been booted up fully and is available for ssh connection. I've tried vm.waitFor('RUNNING') and operation.on('complete') and they both seem to have the same issue as described in the original post.

If it's at all any help - we have an example of polling / retrying a connection after bootup here:
https://github.com/googleapis/nodejs-compute/blob/master/samples/startupScript.js
This could probably be adapted to attempt creating a network connection to 22, just to know when the socket is accepting connections.

That's helpful, thank you @JustinBeckwith :)


[BrokenLinksH2] Fixed the link path

Fixing the links

Docs Build status updates of commit cd7498d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml
:warning:Warning
View
Details

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/TokenizingTextBox.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/Carousel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/CarouselItem.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/DropShadowPanel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/GridSplitter.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/BladeView.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/EyedropperToolButton.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/Menu.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/ImageCropper.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/InfiniteCanvas.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGauge.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/MenuItem.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGaugeAutomationPeer.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls.TextToolbarButtons/DefaultButton.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapPanel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapLayout.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBoxStyleSelector.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TabbedCommandBarItemTemplateSelector.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/UniformGrid.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBox.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredPanel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredLayout.xml
:warning:Warning
View
Details

This comment lists only the first 25 files in the pull request.

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.User'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Person'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Data.IValueConverter'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Data.IValueConverter'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).

dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.GetContainerForItemOverride'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.IsItemItsOwnContainerOverride(System.Object)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.OnApplyTemplate'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.PrepareContainerForItemOverride(Windows.UI.Xaml.DependencyObject,System.Object)'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5c2799e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml
:warning:Warning
View
Details

dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/TokenizingTextBox.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/CarouselItem.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/DropShadowPanel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/EyedropperToolButton.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/BladeView.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/ImageCropper.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/GridSplitter.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/InfiniteCanvas.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGauge.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/Carousel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredPanel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/MenuItem.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/DockPanel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/UniformGrid.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TabbedCommandBarItemTemplateSelector.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGaugeAutomationPeer.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBox.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapPanel.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapLayout.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls.TextToolbarButtons/DefaultButton.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBoxStyleSelector.xml
:warning:Warning
View
Details

dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredLayout.xml
:warning:Warning
View
Details

This comment lists only the first 25 files in the pull request.

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Data.IValueConverter'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.User'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Graph.Person'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.UserToPersonConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Data.IValueConverter'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.Convert(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.Object.ConvertBack(System.Object,System.Type,System.Object,System.String)'.
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Convert(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.Convert(System.Object,System.Type,System.Object,System.String).
Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ConvertBack(System.Object,System.Type,System.Object,System.String) for uid: CommunityToolkit.Graph.Uwp.Converters.ObjectToStringConverter.ConvertBack(System.Object,System.Type,System.Object,System.String).

dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml

Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.GetContainerForItemOverride'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.IsItemItsOwnContainerOverride(System.Object)'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.OnApplyTemplate'.
Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Windows.UI.Xaml.Controls.ListViewBase.PrepareContainerForItemOverride(Windows.UI.Xaml.DependencyObject,System.Object)'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix broken links
@nmetulev
The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This source page contains several broken links related to HamburgerMenu. And we couldn't find the articles it should link to. However, it might be an archived content. Pease review within five business days and let us know how to proceed further or comment in the PR with any changes you'd like to see. Thanks!

@michael-hawker should take a look at this

@v-sidlama  I see only one typo fix in your PR, but many other link issues are flagged...

Global effort to fix broken links
@michael-hawker
The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This source page contains several broken links related to HamburgerMenu. And we couldn't find the articles it should link to. However, it might be an archived content. Pease review within five business days and let us know how to proceed further or comment in the PR with any changes you'd like to see. Thanks!

@v-sidlama all the validation warnings are from the generated docs, there may be something going on with the linkages there to the API browser. I'm not sure. Shouldn't be an issue towards the change made itself.
However, everything in the archive directory is just old documentation we moved there for legacy purposes. Is there some metadata item we can add to the top of the file to better indicate this?

@v-sidlama all the validation warnings are from the generated docs, there may be something going on with the linkages there to the API browser. I'm not sure. Shouldn't be an issue towards the change made itself.
However, everything in the archive directory is just old documentation we moved there for legacy purposes. Is there some metadata item we can add to the top of the file to better indicate this?

Metadata is out of our scope. Please let us know how to check this off on our end. Thank you!

@v-sidlama I'm not asking about validating metadata, I'm asking if there's a flag we can add on these archival documents to get them ignored by the link checking tool. Or is there another process we should follow to mark docs as deprecated/out-dated?

@tfosmark yeah, this repo is going to not exist in about 3-6 months. We're in the process of splitting out our auto-generated content to a separate repo and moving content to a different repo as well. We're also hoping to audit all our current docs that we generate for consistency as we refactor our codebase.


Feature/download variant import

What

Added ImportVariant endpont: POST /images/{id}/downloads/{variant}/import

Transitions (or self-transitions) image to importing state
Transitions download variant to importing state

Added new enpoint to swagger spec

MongoDB document-level locking in functions which need atomic read-write to MongoDB for an image to prevent race conditions. The locking has been added to the following handlers:

UpdateImage
UploadImage
PublishImage
ImportVariant
Note that locking depends on the lock client added to MongoDB : https://github.com/ONSdigital/dp-mongodb/pull/7

How to review

Make sure code changes make sense
Make sure unit tests pass
I manually tried to run concurrent locking operations with Sleep after acquiring the lock, using Postman, and the locks work as expected.

Who can review
Anyone

https://github.com/ONSdigital/dp-image-api/pull/27


fig1 "flow"

i kinda fixed it in lucidchart, but in the paper it is now shaped wrong.
in any case, it should be no problem to just do that in latex, so the fonts/formatting is right.
please use the words i used verbatim.

I think you meant to use the Tikz package in tex to draw box / write words, rather than lucidchart?
If so, I will get on it later today, once I fix project description in two hours.

that is what i meant.
i recommend not working on the paper until the grant is due.
there are lots of improvements to make in the summary and PD.
we can work on the paper this weekend...
On Thu, Nov 3, 2016 at 10:35 AM, cshen6<EMAIL_ADDRESS>wrote:

I think you meant to use the Tikz package in tex to draw box / write
words, rather than lucidchart?
If so, I will get on it later today, once I fix project description in two
hours.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/MGC/issues/142#issuecomment-258159707, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjckDRA5pj8EZpKrDr2JyV1Y4ZomfXks5q6fEdgaJpZM4KnQr2
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York

formatting done on overleaf. any more to adjust?

well, line stuff up?
On Tue, Nov 8, 2016 at 1:38 PM, cshen6<EMAIL_ADDRESS>wrote:

formatting done on overleaf. any more to adjust?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/MGC/issues/142#issuecomment-259221067, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjcmjAh5F3Shy1xTgMTM7yirh_pR_Mks5q8MGLgaJpZM4KnQr2
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York

looks pretty lined up to me? because box (2) will always exceed the corresponding plot unless we reduce text there?

maybe add colorbar to column B, and bring col A & B closer together?
i simplified the text for 2.
can you remove the boundary line for each box,
and make the green color the same color as matlab uses?
On Tue, Nov 8, 2016 at 9:25 PM, cshen6<EMAIL_ADDRESS>wrote:

looks pretty lined up to me? because box (2) will always exceed the
corresponding plot unless we reduce text there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/MGC/issues/142#issuecomment-259319461, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjcrpZ3Zb64GeK-lym2BrB8t3cxDnNks5q8S8CgaJpZM4KnQr2
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York

i think maybe center the x-label and y-label now?
On Tue, Nov 8, 2016 at 10:54 PM, joshua vogelstein<EMAIL_ADDRESS>wrote:

maybe add colorbar to column B, and bring col A & B closer together?
i simplified the text for 2.
can you remove the boundary line for each box,
and make the green color the same color as matlab uses?
On Tue, Nov 8, 2016 at 9:25 PM, cshen6<EMAIL_ADDRESS>wrote:

looks pretty lined up to me? because box (2) will always exceed the
corresponding plot unless we reduce text there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neurodata/MGC/issues/142#issuecomment-259319461, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACjcrpZ3Zb64GeK-lym2BrB8t3cxDnNks5q8S8CgaJpZM4KnQr2
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York

moved this to the other fig 1 thread.


Making an await call in layout file's OnInitAsync causes hang/deadlock

I'm new to async/await and Blazor so keep that in mind.
If, in my designated layout file (in my case, MainLayout.cshtml), I override the OnInitAsync() method and include inside it the call:
await Task.Delay(1000); // (for example)
..when I run the web application, it will appear to hang, i.e. blank screen in the browser with nothing in the console.  If instead I make the same call in a normal page like Index.cshtml, everything works as expected.

I can't reproduce this.  There may have been a different cause.  I'll reopen if I discover it.  In general, I'd like a better way to diagnose odd hangs like that.  It may just be a matter of education.

Frustratingly, I'm getting this again.  This time with this method inside my Index.cshtml file which is child content of my main layout file (names have been changed):
 protected override async Task OnInitAsync()
 {
        this.myDtos = await Http.GetJsonAsync<MyDto[]>("api/mydtos");

}

I see nothing but a blank screen and no console output in the browser dev tools.

It is defined as a private IEnumerable in Index.cshtml.  I iterate through these values to populate a dropdown list (HTML select element) in the page.  I'm admittedly second-guessing myself now because my code has changed since then, so I changed it back to try to reproduce the issue, and naturally I can't.
I really don't want to waste your time, so the next time I encounter this issue, I'll make a distilled snapshot so that I can provide an accurate repro when I reopen.  Thank you for your response.


About Us page

Updated JS animations and CSS styling for text and exec member bubbles

I believe this was the old PR, so closing.


KeyError: <customtkinter.windows.ctk_toplevel.CTkToplevel object .!ctktoplevel>

hello,when i open python main.py --api,he LLM did not give any responses back even when an example audio was playing for it to respond to - when hitting the "Suggest Response Now",Here's an error message I encountered. Did I do something wrong? Please help me.
Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Users\86187\AppData\Local\Programs\Python\Python311\Lib\tkinter_init_.py", line 1948, in call
return self.func(*args)
^^^^^^^^^^^^^^^^
File "C:\Users\86187\AppData\Local\Programs\Python\Python311\Lib\tkinter_init_.py", line 861, in callit
func(*args)
File "C:\Users\86187\transcribe\app\transcribe\venv\Lib\site-packages\customtkinter\windows\widgets\scaling\scaling_tracker.py", line 180, in check_dpi_scaling
if current_dpi_scaling_value != cls.window_dpi_scaling_dict[window]:
~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
KeyError: <customtkinter.windows.ctk_toplevel.CTkToplevel object .!ctktoplevel>
Exception in thread Summarize:
Traceback (most recent call last):
File "C:\Users\86187\AppData\Local\Programs\Python\Python311\Lib\threading.py", line 1038, in _bootstrap_inner
self.run()
File "C:\Users\86187\AppData\Local\Programs\Python\Python311\Lib\threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "C:\Users\86187\transcribe\app\transcribe\ui.py", line 119, in summarize_threaded
summary = self.global_vars.responder.summarize()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\86187\transcribe\app\transcribe\gpt_responder.py", line 60, in summarize
summary_response = self.llm_client.chat.completions.create(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\86187\transcribe\app\transcribe\venv\Lib\site-packages\openai_utils_utils.py", line 275, in wrapper
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\86187\transcribe\app\transcribe\venv\Lib\site-packages\openai\resources\chat\completions.py", line 663, in create
return self._post(
^^^^^^^^^^^
File "C:\Users\86187\transcribe\app\transcribe\venv\Lib\site-packages\openai_base_client.py", line 1200, in post
return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\86187\transcribe\app\transcribe\venv\Lib\site-packages\openai_base_client.py", line 889, in request
return self._request(
^^^^^^^^^^^^^^
File "C:\Users\86187\transcribe\app\transcribe\venv\Lib\site-packages\openai_base_client.py", line 980, in _request
raise self._make_status_error_from_response(err.response) from None
openai.NotFoundError: Error code: 404 - {'error': {'message': 'The model gpt-4 does not exist or you do not have access to it. Learn more: https://help.openai.com/en/articles/7102672-how-can-i-access-gpt-4.', 'type': 'invalid_request_error', 'param': None, 'code': 'model_not_found'}}

Seems like you do not have access to the gpt4 model.
Read the details of possible reasons for it.
https://help.openai.com/en/articles/7102672-how-can-i-access-gpt-4
To resolve it
Change the model from gpt-4 to an earlier model. To do that add the following section to override.yaml file
    OpenAI:        api_key: 'API_KEY'        ai_model: 'gpt-3.5-turbo-0301'

Complete output from the command line including the command line used to execute the program is very helpful in diagnosing issues.
Let us know if you continue to encounter any issues.

i solve my problem!!!!!thank you so much !!!!!

Let us know what steps lead to resolution of the problem for the benefit of the community.


Where is the data of Generation-related Instructions in Section 3.3?

Thank you for your great work!
Could you clarify where the data about Generation-related Instructions in Section 3.3 is located?

Hi, please find them here https://huggingface.co/datasets/YanweiLi/Mini-Gemini-Instruction

Thank you for your great work! Could you clarify where the data about Generation-related Instructions in Section 3.3 is located?

Hi, one simple way to filter out all Generation-related data is to find the trigger tag  in the first round of conversation in the full instruction dataset.

Thank you for your great work! Could you clarify where the data about Generation-related Instructions in Section 3.3 is located?

@jiashenggu Hi, one simple way to filter out all Generation-related data is to find the trigger tag <GEN> in the first round of conversation in the full instruction dataset.

It's not filtered out to contain  label's data

Thank you for your great work! Could you clarify where the data about Generation-related Instructions in Section 3.3 is located?

@jiashenggu Hi, one simple way to filter out all Generation-related data is to find the trigger tag <GEN> in the first round of conversation in the full instruction dataset.

It's not filtered out to contain label's data

Sorry for the misunderstanding. You may refer to https://huggingface.co/datasets/YanweiLi/MGM-Instruction/blob/main/mgm_generation_pure_text.json for the generation subset we used. The original instruction data is the full set.

Thank you for your great work! Could you clarify where the data about Generation-related Instructions in Section 3.3 is located?

@jiashenggu Hi, one simple way to filter out all Generation-related data is to find the trigger tag <GEN> in the first round of conversation in the full instruction dataset.

It's not filtered out to contain label's data

Sorry for the misunderstanding. You may refer to https://huggingface.co/datasets/YanweiLi/MGM-Instruction/blob/main/mgm_generation_pure_text.json for the generation subset we used. The original instruction data is the full set.

Get it! thanks for your reply!!


PointNormal in other registration algorithms to speed up compilation

Further additions to speed up compilation time. Related to https://github.com/SMRT-AIST/fast_gicp/pull/95

Thanks! I merge it :+1:


login to Xiaomi Miio Cloud

I'm failing at the first step installing this package, trying to login the Miio Cloud.
Anyway to debug this?  Can I manual go to this server and login?
I'm in Australia so using the sg server.
I've tried my user name/email address/account id in the username field, all fail.
I've reset my password a few times in the app, so I'm sure it is correct.
Cheers,
Mark

yes, different hah!

I have tried swapping to the Xiaomi Home app.  I had all the maps I created in the Dreamehome App, so was much of a problem.
It also pickup a couple of Yeelight I have, so I can also drop the Yeelight app.
Now the problem, it is failing the token. I successful used https://github.com/Maxmudjon/Get_MiHome_devices_token/releases to get my token.  I did discover my devices are on both the sg and tw servers with the same token.

I had already switched apps, but I swapped back (lost my maps) and the install with dev went without a problem.  No tokens requested.  I have one device with 93 entities..  thanks.


REQUEST Add progress bar

A progress bar would be very helpful when handling large lists of serial numbers, as each serial number creates a call to AirWatch to get the device ID.

Implemented progress bar in commit e2a72aa


Add clarifying copy to the "Validate your account" modal in certain scenarios

Background
The current "Validate your account" modal is vague and confusing. It just says "This feature requires you to validate your account." and nothing else. Example here:
https://github.com/user-attachments/assets/69bdff4c-0868-4a84-84d7-212503a961f1
We can't expect members to know the next step(s) of how to validate their account. So let's tell them.
Details

[ ] Let's add a couple more lines in a new paragraph below the existing copy: Please enter the magic code sent to [email/phone]. It should arrive within a minute or two.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Improvement
What is the root cause of that problem?
improvement
What changes do you think we should make in order to solve the problem?

update the featureRequiresValidate text to the above text in both en.ts and es.ts files

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?

In a few places such as:
https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/pages/ReimbursementAccount/BankAccountStep.tsx#L230
https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L166
https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/pages/settings/Wallet/VerifyAccountPage.tsx#L77

we only have a description: "This feature requires you to validate your account.".
What changes do you think we should make in order to solve the problem?

We mentioned, we need to add a couple more lines in a new paragraph below the existing copy: Please enter the magic code sent to [email/phone]. It should arrive within a minute or two. Steps to do it:

Add new param subDescription to:

https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/components/ValidateCodeActionModal/index.tsx#L16

Add:

                    {subDescription && <Text style={[themeStyles.mb3]}>{subDescription}</Text>}

below:
https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/components/ValidateCodeActionModal/index.tsx#L73

For each page I mentioned in RCA sections:

https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/pages/ReimbursementAccount/BankAccountStep.tsx#L230
https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L166
https://github.com/Expensify/App/blob/3023d6016ef59d3fc8f0190f48597c41e95d3a55/src/pages/settings/Wallet/VerifyAccountPage.tsx#L77
we can pass subDescription={subDescription} when using ValidateCodeForm with the subDescription value is:
    const [account] = useOnyx(ONYXKEYS.ACCOUNT);
    const contactMethod = account?.primaryLogin ?? '';
    const subDescription = useMemo(() => {
        return `Please enter the magic code sent to ${contactMethod}. It should arrive within a minute or two`;
    }, [contactMethod]);

We can skip the translation in the proposal phase because it is easy and can be done in PR phase.
What alternative solutions did you explore? (Optional)

Sorry @RachCHopkins - this one's a quick update I'm doing with James. No Action needed here!

Ooh actually @RachCHopkins can I re-assign you to handle payment for @akinwale for reviewing https://github.com/Expensify/App/pull/52442? 🙇

Payment Summary:

Contributor+: @akinwale to be paid $250 via NewDot Manual Request.

No associated Upwork job.
Please go ahead with the request @akinwale ! Thanks for your help here!

Thanks. Requested for payment on ND.

$250 approved for @akinwale


Error Handling when a Port is physically removed

Serial ports are not always attached to a device, they can be Barcode Scanners, or USB to Serial port adapters, which can be removed in operation.
Overview

Increase the error handling when a port is physically removed.
Make it more obvious to the user that a port has been removed.

Improvements

Currently the Drop Down box only shows the connected ports, if one is removed it defaults to the next in the list which is misleading.
Currently the removed port is left 'Opened' and reading continues without a error especially running under Linux

User Interface Prompts

Logging Example


useQueries with current setup

Hi there!
https://github.com/connectrpc/connect-query-es/issues/67 has previously mentioned using createQueryOptions to allow useQueries to work, however that was an issue prior to v1 being released.
With the current version of the connect library, what would be the best example to follow to apply useQueries?
I imagine useQueries types within @connectrpc/connect-query would have to match with @tanstack/react-query. Is there any other blocker from the architecture perspective that might not allow useQueries, for example using more than 1 transport?

I'm also blocked on this, I just began an upgrade from 0.6.0 to 1.2.0 and realised there wasn't an easy way to do useQueries

I was eventually able to get my previous behaviour by porting the createQueryOptions helper back:
import { Message, PartialMessage } from '@bufbuild/protobuf'
import { CallOptions, ConnectError, Transport } from '@connectrpc/connect'
import {
	ConnectQueryKey,
	DisableQuery,
	MethodUnaryDescriptor,
	callUnaryMethod,
	createConnectQueryKey,
} from '@connectrpc/connect-query'
import { QueryFunctionContext } from '@tanstack/react-query'

export function createQueryOptions<I extends Message<I>, O extends Message<O>>(
	methodDescriptor: Pick<MethodUnaryDescriptor<I, O>, 'I' | 'O' | 'kind' | 'name' | 'service'>,
	input: DisableQuery | PartialMessage<I> | undefined,
	{
		callOptions,
		transport,
	}: {
		transport: Transport
		callOptions?: CallOptions | undefined
	}
): {
	enabled: boolean
	queryKey: ConnectQueryKey<I>
	queryFn: (context?: QueryFunctionContext<ConnectQueryKey<I>>) => Promise<O>
	// placeholderData?: () => O | undefined;
	/**
	 * We never actually return a throwOnError, we just use this to allow
	 * @tanstack/query to infer the error types we CAN throw.
	 */
	throwOnError?: (error: ConnectError) => boolean
} {
	return {
		enabled: true,
		queryKey: createConnectQueryKey(methodDescriptor, input),
		queryFn: () => callUnaryMethod(methodDescriptor, input as PartialMessage<I>, { callOptions, transport }),
	}
}


Change wssu namespace to wsu

According to this document, the legal namespace should be wsu instead of wssu.

You're f**** right ! Where did I get this from?!! :sweat_smile:
To be retro compatible, it would be great to keep the original constants with a @deprecated annotation with the new value. Would you mind update your PR ?

@mikaelcom  Do you mean this?
    /**
     * @deprecated
     */
    public const NS_WSSU = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd';

    public const NS_WSU = 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd';

    /**
     * @deprecated
     */
    public const NS_WSSU_NAME = 'wssu';

    public const NS_WSU_NAME = 'wsu';


net: shell: Adding network DHCP shell commands: start, stop and restart

Hello
I've added some features that I think it would be nice to have in the shell environment like to start, stop and restart the DHCP client in the operating system.
If you enable the DHCP and autoconfiguration in the Kconfig but the DHCP client doesn't start automatically.
This feature enables to control manually the DHCPv4 client by issuing some commands to the network shell.
Syntax:
net dhcp4 start [index]
net dhcp4 stop [index]
net dhcp4 restart [index]
Where [index] is the network interface index. When no interface is supplied in the command line arguments, the shell choose the default network interface and try to start/stop or restart the dhcp to that interface.
Currently there is no support to DHCP for IPv6, so no command were added to accomplish with this use case, maybe in the future we could control the client on both protocols.
Best regards
Arthur Farias

This needs fixing to remove your merge, you need to rebase main onto your changed not merge.

Hello Mr. @jukkar, I wonder if there is some local checking tool I could use before sending any code to the server.
Best regards
Arthur Farias

You can use twister, https://docs.zephyrproject.org/latest/contribute/guidelines.html#twister
Perform a run with the networking tests and if it fails, it needs fixing. If there are any warnings emitted, they too need fixing.


[Feature Request] support  grok-beta API

🥰 需求描述
I have seen grok-beta exist on the model list.  However, I can't find any document to demo how to configure it. Could you confirm whether we already support it or not. If yes, how can I configure to use grok-beta API.  any example?
🧐 解决方案
Give a clear instruction how to configure  to support grok-beta
📝 补充信息
No response

https://github.com/search?q=repo%3AChatGPTNextWeb/ChatGPT-Next-Web XAI_API_KEY&type=code

Thanks a lot. it works when I configure it like -e XAI_API_KEY=xai-xxxx


Add workflow to run small experiment

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.


feat: MGDCTRS-1887 remove service preview label

This change removes the service preview label from the Connectors service card.
from:

to:

BTW is this tagged right to trigger a release?

BTW is this tagged right to trigger a release?

with the chore tag it would have not triggered a release. I made this a feat and called it a day

:tada: This PR is included in version 2.20.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

with the chore tag it would have not triggered a release. I made this a feat and called it a day

Ok, awesome thanks!


ColorPicker's eyedrop takes ages to pick a color

Godot version:
1253b9c
OS/device including version:
Manjaro GNU/Linux - Intel i5, Haswell
Issue description:
Both in-game and in the editor, when trying to pick a color via the eyedrop, everything will start to freeze until much later, when the color will finally be picked.

Confirmed in baefda668.

@avencherus it's definitely not meant to be used in real-time, but it should not be super slow

Are you all testing in debug builds? I think it's just the texture_get_data() method is slow, and it's even slower on debug builds. I tested on the official release beta8 and it's slow but not that bad, in my custom debug build of the same commit it's much slower.
We could either find a way to speed up texture_get_data() or change the color picker so it takes samples every 0.25 seconds or something similar.

It was not particularly slow in 3.0 as far as I remember.

@akien-mga It's just a little laggy, but I get the same amount of lag between a release build of 3.0 and 3.1, so I don't think anything changed there.

Ok, then this sounds like a good compromise:

change the color picker so it takes samples every 0.25 seconds or something similar.

change the color picker so it takes samples every 0.25 seconds or something similar.

Not sure what this means, but in my editor, the color picker takes 7 seconds to pick a color.
So if this processing is done every 7 seconds, this is going to freeze my computer. Unless I misunderstood the proposal.

@groud Right now texture_get_data gets called on every mouse movement event. My idea is to change the current behaviour so the texture is sampled in a constant but solwer rate, and maybe one last sample on the click event.
This way we would give te CPU more time to complete the get texture call before calling it another time.

@groud Right now texture_get_data gets called on every mouse movement event.

Oh, so the problem is that it calls this function too often. Because it seems like I have a freeze only when I click in the end. The calls are probably stacking up, which lead to a longer freeze.
Maybe a workaround would be not to add a repetitive call, but to add a delay to the call to texture_get_data. So that the engine would wait for something like 0.2 seconds for the mouse standing still before actually calling the function. You would reset the same timer every time the mouse moves, and call the function when it it timeouts.

Can we simply query a 1x1 part of the viewport instead of downloading the entire thing?

@Zylann I've precisely thought about that, but I have no idea how this could be achieved.

@Calinou I guess it needs to be implemented. I once needed the opposite (set_data_partial).

I checked the current implementation of texture_get_data and it does a draw call to render the textre and retrieve its data. I'm pretty sure the newer versions of OpenGL have ways to get individual pixels from textures, but it was implemented this way to have more compatibility.
Vulkan will most likely also allow us to get partial data, but we will still need to support GLES2, so I would just add a timer like @groud suggested.

I'm adding the "junior job" label. The task is to modify ColorPicker so instead of sampling the screen on every mouse movement it's only done when the mouse sits still in a position for a set amount of time.
What needs to be done:

Add a timer to ColorPicker.
Reset the timer on every mouse movement input.
When the timer times out perform the same screen sampling that is now done on every mouse movement.

You can at editor/code_editor.cpp for a similar usage of timers in code_complete_timer.

Moving to 4.0 milestone, not a blocking issue. The fix should be cherrypicked back to 3.2

Just to update on my part, the freezing doesn't happen anymore in my end. Neither with GLES3 nor GLES2.

Hi! May I take this task and start looking into it? Thanks!

@buefux It appears nobody is currently working on it, so go ahead :slightly_smiling_face:

Fixed by #61997.


DXT Dimension Restrictions

One of the requirements for the DXTImageDecoder is that the image for it have a width and height that are both powers of two.
Admittedly, I'm not all that familiar with the internals of the DXT image format, but as far as I can tell (and please correct me if I'm wrong), the only technical restriction is that the dimensions be a multiple of four.
For another program, I was using the libsquish library to do DXT decompression, and it has no such restriction.
If it's okay with everyone here, I'd like to make a pull request removing the restriction (if it's possible, anyway).
Thanks

I can't remember why I put that check in there when I wrote the base DXT implementation. IIRC .dds files are limited to power-of-two widths and heights for DXT formats but the format indeed doesn't have any restrictions except for requiring multiples of 4x4 pixel chunks.
Feel free to remove it.

May I suggest my libsquish port in place of said code? It's a pretty 1:1 RIIR of the original code, handles NPOT images and implements all 3 color compression schemes present in the original lib. /shameless plug
FWIW I've cleaned up the API a bit since the last time I uploaded it to crates.io. Will upload a new version once I get the documentation up to speed as well.

@jansol interesting code. When I wrote the DXT implementation for image there were still legal concerns around DXT compression licensing, so it's a simple clean room implementation.
Due to this the encoder is a bit simpler than what could be (it's a brute force search with some special cases). Originally I did consider principle component analysis (looking at your code that's one of the strategies it uses) but due to it requiring significant amounts of floating point math which would in the end be about as fast as just brute forcing it I went for the simpler approach.
I wonder which implementation is faster / more accurate. The core brute force search I used should scale pretty well as it's completely operating in fixed point and the inner loops get optimized to SIMD quite well. Might be fun to benchmark.

@jansol If your implementation has advantages over the current one, then that could be a possibility. For now the NPOT problem is fixed but feel free to open a new issue.

I'm thinking of adding an approach like the one here to my crate, could do some benchmarking then. One advantage even now would be that my implementation lets the user decide the quality/speed tradeoff.


Add wiki to tell how to run AAD integration test in localhost.

Add wiki to tell how to run AAD integration test in localhost.

Hi, @yiliuTo , please help to review this PR.


Mangling: wire up the new mangling in various places in the compiler,…

… but still use the old mangling.
The purpose of this change is to test if the new mangling is equivalent to the old mangling.
Both mangling strings are created, de-mangled and checked if the de-mangle trees are equivalent.

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 25b5e44e4afe71b40750b097e90e8015f1b99fb8
Test requested by - @eeckstein

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 25b5e44e4afe71b40750b097e90e8015f1b99fb8
Test requested by - @eeckstein

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 25b5e44e4afe71b40750b097e90e8015f1b99fb8
Test requested by - @eeckstein

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 371c1d65209b95be8baa6d197d034665f29056e4
Test requested by - @eeckstein

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 371c1d65209b95be8baa6d197d034665f29056e4
Test requested by - @eeckstein

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 7457f4827e8d27bc34215f733b351c2dd53891a2
Test requested by - @eeckstein

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 7457f4827e8d27bc34215f733b351c2dd53891a2
Test requested by - @eeckstein

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci please test macOS

@swift-ci please test macOS

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 5ac0c5b9b79c4dc2a00dc8caa20b76f0b3a468db
Test requested by - @shahmishal


Ix 4.0: Add shared state/concurrency tests

The PR adds concurrency tests for System.Linq.Async (see https://github.com/dotnet/corefx/issues/32640). Currently there are only tests for SequenceEqual and Zip; more will follow.

I think right now there's a back-and-fourth about what the default behavior could/should be. There may need to be an additional overload that allows specifying concurrency.
In the end, I think it needs a discussion.

The two test cases test if there is any overlapping/non-sequential access to the shared state. This happens for example with the use of Task.WhenAny/Task.WhenAll. The Zip implemenation uses Task.WhenAll so it will await both tasks, but in parallel.
As I understand the discussion, the problem comes with shared state manipulating enumerators. For example on every MoveNextAsync() an element is popped from a (shared) stack. If you now zip such a sequence with itself the Pop method needs to be thread-safe or the calls to it needs to be serialized. With a Zip operator that does await the Tasks sequentially, the calls to Pop are already in sequence. I'm not sure, though, if I hit the nail with the example.
I'm also not sure if I really like shared state manipulating enumerators, as I learned that a query should be sideeffect free, but I can imagine they can come in handy.

It should be similar to how Rx expects things: don't share state and use external synchronization if needed. Otherwise, you'd enforce single source interaction in operators, which at best adds more latency to operators like Zip (limiting utilization) or makes them practically impossible like Timeout with another async sequence.

I added some more concurrency tests, currently Zip, Except and Intersect fail. Basically all operators that use Task.WhenAll. So not really a suprise.

@bartdesmet thoughts?

@bartdesmet, good point. In my initial tries the shared state was private, so there was no other opportunity than to throw. But now it can also be done with a testable property.


On the notification page, No record found message should be shown in Grey color in the Dark theme

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
On the notification page, No record found message should be shown in Grey color in the Dark theme because it is not visible in the dark theme.
Preconditions

Admin should be logged in.
Admin needs to enable the dark theme.

Steps to reproduce

Go to 'Admin panel'
Click on 'View all' inside the notification button
Go to the pending/processing/complete/closed/refund tab which is blank
See the error

Expected Result
The test should be shown in Grey color in the dark theme.
Actual Result
The text is in a Grey color so it is not visible properly.
Screenshots
https://prnt.sc/6Us9cVprvH9L
Additional context
No response

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.


[SPARK-45487] [WIP] Fix SQLSTATEs and temp errors

What changes were proposed in this pull request?
This PR replaces TEMP error message 3007 and fills in many missing SQLSTATEs.
Why are the changes needed?
This is part of the ongoing effort to switch to the new error framework.
Does this PR introduce any user-facing change?
yes, error docs will now show more SQLSTATEs
How was this patch tested?
Existing QA suite was run.
Was this patch authored or co-authored using generative AI tooling?
No

@MaxGekk Can you review? I will follow up with a couple more to get through all the SQLSTATEs.
Once that is done I think we should add the SQLSTATE to the pretty message format.

Thanks, merging to master


The maximum shear strain profile estimated in MaxStrainProfile is returning Array of strain values for a layer

Dear sir,
While running a site response analysis, I came across the following problem.
Error:
The maximum shear strain profile estimated in MaxStrainProfile class for a layer is returning Array of strain values.
Possible reason:
Line 437, output.py:
values = [0] + [l.strain for l in calc.profile[:-1]]
The above line can be modified as
values = [0] + [l.strain_max for l in calc.profile[:-1]]
to obtain correct results..
Kindly confirm whether the above fix is ok...

Thanks @anismhd for finding this issue. This has been corrected in v0.4.1, which will be sent to pypi after Github Webhooks are resolved (see https://twitter.com/githubstatus/status/1131255005909049345).


Add documentation for how codegen works in the sdk

We use codegen a lot in chip.
This document starts describing the current status of things and I plan to update it as we develop the code generation logic.

Fast-tracking documentation-only change. We can update documentation async afterwards and this does not affect SDK functionality.


Incorrect type names given with type.FullName.

Dot Net Fiddle
Bridge Fiddle
Expected
System.Int32
System.Single
System.Double
System.Decimal
Actual
Bridge.Int32
Bridge.Single
Bridge.Double
Bridge.Decimal
Steps To Reproduce
public class App
{
    [Ready]
    public static void Main()
    {
        int v = 0;
        float v2 = 1;
        double v3 = 2;
        decimal v4 = 3;
        Console.WriteLine(v.GetType().FullName);
        Console.WriteLine(v2.GetType().FullName);
        Console.WriteLine(v3.GetType().FullName);
        Console.WriteLine(v4.GetType().FullName);
    }
}

Related to #1248, #1292 and #1184.

This particular case has been fixed by #1337


Fix issue with releases containing retained versions (#20997)

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
This PR aims to resolve #20997
Description
When a release in the Google Play Store contains a retained version, update_rollout is failing to complete the rollout as it is sending the retained version to the Google Publisher API.
Updated the code to always pick the biggest version code as that will always correspond with the latest release
Testing Steps
1- Release a new version to the Google Play Store retaining the previous version

2- Complete the rollout for that version
supply(
          track: options[:track],
          rollout: options: 1.0,
          skip_upload_apk: true,
          skip_upload_metadata: true,
          skip_upload_images: true,
          skip_upload_screenshots: true,
          skip_upload_changelogs: true,
          skip_upload_aab: true,
          package_name: options[:package]
        )

@bmcadams, this PR should fix the issue (#16362) you reported a while back and was closed due to inactivity.
In the meantime, you can fork the repo, cherry-pick this fix and install the gem from your forked repository as a workaround.
gem "fastlane", :git => 'https://github.com/<username>/fastlane'

We've had to use a forked repo since January to work around this issue with @mmiani fix. Would be lovely to be back on main repo.
@getaaron could you give this a quick review?


Terminal abnormal  display

System version: Ubuntu 20.04.3 LTS
VSCode info:
Version: 1.68.0
Commit: 4af164ea3a06f701fe3e89a2bcbb421d2026b68f
Date: 2022-06-08T11:49:57.055Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 [5.13.0-48-generic]

I enter command is: pwd

did this just start happening recently?
does changing terminal.integrated.gpuAcceleration help?

"terminal.integrated.gpuAcceleration": "off"  is useful


sanic exception handler

first of all, I want to thank you and all your team for the excellent work.
I have started a project that uses sanic
I want to log any exceptions that happen in the project
exception handler:
@application.exception(ServerError)
def log_any_exception(request, exception):
    ...
    logger.error(exception)
    ...

a test handler:
@application.get('/')
async def index(request):
    result = 10 / 0 # division error
    return await file('/'.join([application.config.TEMPLATES_DIR, 'index.html']))

after division error, log_any_exception Will not be called
but, below handler works like a charm:
@application.get('/')
async def index(request):
    raise ServerError("Something bad happened", status_code=500)
    return await file('/'.join([application.config.TEMPLATES_DIR, 'index.html']))

thanks

Hello,
Have you taken a look into the Exception docs?

You can pass SanicException to catch them all!

Does it help?
Else have you tried registering an exception handler for the ZeroDivisionError exception?

hi @arnulfojr, Many thanks for the prompt reply
Yes, I read the documentation carefully

You can pass SanicException to catch them all!

But did not work
And finally I solved this issue with BaseException:
@application.exception(BaseException)
def log_any_exception(request, exception):
    ...
    logger.error(exception)
    ...

I understand the case you want to implement, I have sandboxed the thing you're talking about, and I have some ideas I would like to suggest you.
I would recommend you to take a look into Python's Exception Hierarchy.
Now, the SanicException is extending from the Exception class.
In sanic the isinstance is used, and according to the python docs we can see that it only returns True if the exception "is an instance of the classinfo argument, or of a (direct, indirect or virtual) subclass..." which in this case the ZeroValueError is not an instance of SanicException, and therefore registering an Exception for ZeroValueError is required.
In this manner this SanicException only takes in consideration all the Sanic relevant Exceptions and subclasses of it. So a more proper way around this would be to register the exception handler to Exception instead of BaseException.
Moreover my advice would be for you to wrap your exceptions basing them from one Exception, as for example is said in this post "Defining your exceptions..." and then registering a default Exception handler for your exceptions (look below).

BaseException

Exception

MyAppException
SanicException
ArithmeticError

ZeroDivisionError

@app.get('/error')
async def some_error(request):
    try:
        number = 3 / 0
   except ZeroDivisionError as e:
        raise MyAppException(e)  # or a subclass of it
   return json(DATA, status=200)

# So then you'd register the handler
@app.exception(MyAppException)
async def handle_my_app(request, exception):
    logger.error('...')

# or the "default" handler
@app.exception(Exception)
async def default_handle_exception(request, exception):
    # this will catch ZeroDivisionError if no handler would be registered and no
    # MyAppException would be raised
    logger.error('... default handle ...')

I hope it helps :)

In this manner this SanicException only takes in consideration all the Sanic relevant Exceptions and subclasses of it. So a more proper way around this would be to register the exception handler to Exception instead of BaseException.

Thanks for your suggestion

I can't catch any exception in my handler.
I change sanic.error logger to:
        "sanic.error": {
            "level": "ERROR",
            "handlers": ["main_error"],
            "propagate": True,
            "qualname": "sanic.error"
        },

main_error is:
        "main_error": {
            'level': 'ERROR',
            "class": "logger.MainHandler",
        },

logger.MainHandler is:
class MainHandler(logging.Handler):
    def emit(self, record):
        trace = ''

        if record.exc_info:
            trace = traceback.format_exc()
        ...

I use @app.exception(Exception) on view but can't catch exception. On the other hand the root logger works fine.
What do you think about it?


Will local video be supported in the future?

Will local video be supported in the future?

Have you tried this?

It also works to do this:
[[MyVideo.mp4#t=8]]
However, one point that is not supported is opening local files, is opening the local file with the command palette Open Medie from Link  (unless you use file:/// but then it is absolute, which we don't want).

Hey all, I'm also having a hard time working with local videos. I am on Windows (not my choice!) and I am looking for the "insert timestamp" functionality. It works for Youtube videos that I've opened from link, but I can't find a way to open local files from link (maybe there's a magical file:/// incantation that works with Windows file paths but I've tried everything I can think of).
Also, using ![](../../attachments/My-video.mp4) doesn't work, and the [[My-video.mp4#t=8]] syntax opens the video but not to the timestamp.

Hello Been!
Relative paths are not possible, this is why the first one doesn't work.
Regarding the second one: Have you tried it on read mode? In edit mode it
doesn't work .
Regarding Windows: lol 😂
I found it funny how you are saying it is not your choice :D
Ben A Kushigian @.***> schrieb am Mi., 30. Nov. 2022,
20:28:

Hey all, I'm also having a hard time working with local videos. I am on
Windows (not my choice!) and I am looking for the "insert timestamp"
functionality. It works for Youtube videos that I've opened from link, but
I can't find a way to open local files from link (maybe there's a magical
file:/// incantation that works with Windows file paths but I've tried
everything I can think of).
Also, using  doesn't work, and the
[[My-video.mp4#t=8]] syntax opens the video but not to the timestamp.
—
Reply to this email directly, view it on GitHub
https://github.com/aidenlx/media-extended/issues/169#issuecomment-1332632686,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVM2ARGZ36WHQXP6XBP6T3WK6TGFANCNFSM6AAAAAASFJHLVU
.
You are receiving this because you commented.Message ID:
@.***>

Oh, too bad. I was hoping I could use this with local media files....

You can. But today it only supports mp4. But if you change the file main.js, you can add more formats. I added mkv:
change ["video", ["mp4", "ogv"]] to ["video", ["mp4", "ogv","mkv"]]

Put [[your funny video.mp4#t=1]] on a obsidian note and change to reading view and click the link.

If you do what I said above to mkv, you can do the same to this format.

You can. But today it only supports mp4. But if you change the file main.js on your local .obsidian (dot obsidian) folder, you can add more formats. I added mkv: change ["video", ["mp4", "ogv"]] to ["video", ["mp4", "ogv","mkv"]]

Huge thanks, this solution definitely solved the problem I was having

Apologies for the long period of inactivity on this project. I wanted to inform you that the plugin has been fully rewritten for the v3 release. I'm currently preparing for the beta release. Once it's available, if you encounter similar issues, please don't hesitate to open a new issue. Thank you for your understanding.


added lcs code in python

🛠 Issue (Number)
Issue no #1475
👨💻 Changes proposed

Written code in python,along with it printed the entire matrix so that one can easily understand.The lcs string along with the length is printed.
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

rename the file as "Longest_Common_Subsequence.py"

Done Sir👍

@Arun9739 and @072arushi please review


append date time stamp to data export filename?

see posm/posm#316

closing this as ability to transfer issues means https://github.com/posm/OpenMapKitServer/issues/125 is now tracking this


How to create topics during startup?

Could you please let us know how to create topics during startup of the kafka/zookeeper containers?

You can define a configmap and job that creates your topics for you:
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: cbp-confluent-configmap
data:
  topics: topic1,topic2,topic3
---
apiVersion: batch/v1
kind: Job
metadata:
  generateName: cbp-confluent-topics
spec:
  backoffLimit: 4
  template:
    spec:
      restartPolicy: Never
      containers:
      - name: topics
        image: confluentinc/cp-kafka:5.0.0
        imagePullPolicy: IfNotPresent
        env:
        - name: ZOOKEEPERS
          value: cbp-confluent-cp-zookeeper:2181
        - name: TOPICS
          valueFrom:
            configMapKeyRef:
              name: cbp-confluent-configmap
              key: topics
        command:
        - bash
        - -c
        - |
          IFS=',' read -ra topics <<< "$TOPICS"
          for topic in ${topics[@]}
          do
            echo "Creating topic $topic..."
            kafka-topics --zookeeper $ZOOKEEPERS --create --topic $topic --partitions 3 --replication-factor 3 --if-not-exists
          done

Thanks for solution. Is there a plan to add this feature to the repo?

Well, this "feature" is already there... Just requires more YAML

I would recommend handling Kafka internal operation separately from a setup helm chart.(a parent chart of setup+ topic creation, or an extra step in pipeline after installation)

@qshao-pivotal
I have a solution using configmap and job for topics creation. Can I submit PR?


API exposing entry and collection data

The problem I'm encountering ATM is an entry is not erroring when it has the same identifier field as another entry in the same collection. https://github.com/netlify/netlify-cms/issues/2829
As a potential workaround to this problem I see there exists the ability to "hook" into prepublish events with CMS.registerEventListener.
What I'd like to try is on pre-publish, fetch for all the identifier values in the same collection and match that against the currently published entry's identifier value. If there exists a match, somehow throw an error and prevent the publish.
But to do this - I need to know:

the identifier value of the entry
the identifier values of all entries in the same collection

Are there any API's that CMS exposes that can allow me to get this info?
Is there an API that allows me to throw toast notification errors similar to what field validation errors throw?

HI @vai0,
since netlify CMS does not has its own persistancy you can use the API of the repository where the data is stored (e.g. GitHub). OR you get the API through other tools you maybe use anyways for buildign your website - e.g. gridsome, which loads the netlfiy CMS data (by parsing the files) and exposes a GraphQL to browse the data.
BR
Sascha

Closing as stale and/or outdated.


Support for category fields with multiple values

Description
Is there a functionality to incorporate many- to-many (multi-label) categorical feature in GLuonTS? It would be helpful to have a feature like that. Currently it just supports one to one mapping. FOr example, a product may belong to multiple categories and not just one

@miteshyadav for the models that support the feat_static_cat feature (eg DeepAR) that's already the case: you just need to put there an array of length > 1.
I'm moving this into the discussions, if you don't mind, so that others can find this answer.


Fix sysread sig

Documentation says:

If the optional outbuf argument is present, it must reference a

so make the 2nd outbuf param optional
Motivation

Existing code that does some_file.sysread(8) is failing typecheck
Test plan

Only change is to rbi

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IhSmr9XgjEukLD
→ https://go/builds/bui_IhSmbm1ALBLK27

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IhSmr9XgjEukLD
→ https://go/builds/bui_IhSmbm1ALBLK27


Stop using password to ssh into VMs (libvirt provider)

Unlike other Terraform providers, we are using the user/password
authentication in libvirt. This is not needed as the cloud-init step
will eventually configure the keys correctly and Terraform will be able
to ssh into the VM. Besides, it avoids a problem we are seeing between
ssh-agent and terraform:
https://github.com/hashicorp/terraform/issues/23662
Signed-off-by: Manuel Buil<EMAIL_ADDRESS>Why is this PR needed?
Yes, please read commit message
What does this PR do?
Yes, please read commit message
Anything else a reviewer needs to know?
This PR replaces the old one https://github.com/SUSE/skuba/pull/892
Info for QA
This PR fixes a bug which appears from time to time when deploying terraform + libvirt and aligns the way to do ssh with other providers (e.g. openstack)
Related info
This patch is related to https://github.com/hashicorp/terraform/issues/23662
Status BEFORE applying the patch
Deploying skuba with terraform + libvirt as provider. It sometimes fail in the cloud_init step with a ssh problem
Status AFTER applying the patch
The deployment never fails in the cloud_init step
Docs
No docs needed
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

This is incomplete. When I validate this I get this error:
$ terraform validate

Error: resource 'data.template_file.master-cloud-init' config: unknown variable referenced: 'password'; define it with a 'variable' block

Error: resource 'data.template_file.lb_cloud_init_userdata' config: unknown variable referenced: 'password'; define it with a 'variable' block

Error: resource 'data.template_file.worker-cloud-init' config: unknown variable referenced: 'password'; define it with a 'variable' block

With the password param removed from the terraform files, applying it still fails:
$ terraform apply -parallelism=1
...
Error: Error refreshing state: 3 errors occurred:
        * data.template_file.worker-cloud-init: 1 error occurred:
        * data.template_file.worker-cloud-init: data.template_file.worker-cloud-init: failed to render : <template_file>:13,19-27: Unknown variable; There is no variable named "password".

        * data.template_file.master-cloud-init: 1 error occurred:
        * data.template_file.master-cloud-init: data.template_file.master-cloud-init: failed to render : <template_file>:13,19-27: Unknown variable; There is no variable named "password".

        * data.template_file.lb_cloud_init_userdata: 1 error occurred:
        * data.template_file.lb_cloud_init_userdata: data.template_file.lb_cloud_init_userdata: failed to render : <template_file>:13,19-27: Unknown variable; There is no variable named "password".

so it needs to be removed from the cloud-init files too. It's also still in the example tfvars file:
https://github.com/SUSE/skuba/blob/2512306029fcb636a4f8f4b5a39957e91ac8e164/ci/infra/libvirt/terraform.tfvars.json.ci.example#L11

Thanks for pointing that out! I am confused now, how could it work last time I tried? Anyway, I will update the PR

CI complains about formatting. Please check make lint locally and fix it.

Thanks for the hint. I ran the command in the branch I am trying to merge and it worked locally. I have just checked and other PRs are also having a problem in that line:
make: *** [Makefile:98: lint] Error 3
Maybe it was a problem in CI? I'd try to rerun the tests

I see you removed the setting of a root password. Are there possibly any other reasons to set a password or, more importantly, an unexpired password on the root account? No chance of root being in a locked state by default? No future tests validating sudo using the root password?
As long as the image we use to deploy in our nodes is correctly built, there should not be a problem about unexpired password or locked state by default. Using ssh keys instead of password is a common practice in cloud CI

I haven't looked at the other providers for parity; if that's what they're doing too, then ok. We should be consistent. :)

Yes, that is what the other providers are doing:
https://github.com/SUSE/skuba/blob/master/ci/infra/openstack/worker-instance.tf#L103-L107
https://github.com/SUSE/skuba/blob/master/ci/infra/vmware/worker-instance.tf#L96-L101
https://github.com/SUSE/skuba/blob/master/ci/infra/aws/worker-instance.tf#L6

Hi!
New code has been merged in master regarding terraform 0.12. Please rebase your branch to take this changes in.
Happy hacking

Is this old PR still active or abandoned?  Is there anything preventing it from being merged once the conflicts are resolved and CI passes (I presume the CI failures were CI flakiness and not bad code)?

Is this old PR still active or abandoned? Is there anything preventing it from being merged once the conflicts are resolved and CI passes (I presume the CI failures were CI flakiness and not bad code)?

Active but forgotten! Thanks for bringing it up :). Let me rebase

Since this potentially impacts the CI system as well, maybe we can get @pablochacin or @jordimassaguerpla to also quickly look at it before finally merging?

Since this potentially impacts the CI system as well, maybe we can get @pablochacin or @jordimassaguerpla to also quickly look at it before finally merging?

Thanks!

@jordimassaguerpla: @davidcassany has positively review the PR, can we merge it?

@jordimassaguerpla: @davidcassany has positively review the PR, can we merge it?

Just dismissed the @jordimassaguerpla review as we was just asking for a review from someone in Z squad. Given that the Z Squad review already happened and given that jordi is on vacation I just took the freedom to move on.


ESP32S3/S2 USB FIFO size inconsistency (tinyusb dcd driver) (IDFGH-9890)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
The overall USB FIFO size is defined as 1024 in dcd_esp32sx.c, however it says 4KB in the technical reference manual for both esp32s3 and esp32s2. Note that the register definition section is missing currently in the manual (v1.2).
Later in the code it says in a comment that the size is either 1280 or 4096.

I have already requested for the missing register section to be added to the manual via the web form.
Can you clarify what the actual FIFO size is
If the size is 4096, can you adjust the driver accordingly.

This is relevant to achieve high throughputs, for example when sending lots of data as cdc device, see also #11161 / comment

Hello @jrahlf , thank you for the issue. The docs and code comments are not clear, indeed.
USB shared FIFO RAM for all endpoints is 256 words -> 1024 bytes. (The technical reference manual mentions 4KB in memory map, but only 1KB is implemented. This is misleading, I'll forward this to docs team).
More details:

USB-OTG implementation in both S2 and S3 has 6 endpoints (including endpoint 0), out of which max 5 can be IN endpoints.
All OUT endpoints share one FIFO. Every IN endpoint (including INOUT endpoint 0) must have their own dedicated FIFO.
OUT FIFO size is 52 words -> 208 bytes
EP0 FIFO size is 16 words -> 64 bytes
The rest (188 words -> 752bytes) is evenly distributed among the remaining IN endpoints 188/4 = 47 words -> 188 bytes per IN FIFO

In case you don't use all 4 remaining IN endpoints, you don't utilize the FIFO RAM to its maximum (some portion of the FIFO RAM is reserved for endpoints you don't use).


CI: debug mutate test.

Codecov Report
Patch coverage: 2.32% and project coverage change: -0.74 :warning:

Comparison is base (bbe89e2) 56.18% compared to head (c23e45b) 55.44%.

:exclamation: Current head c23e45b differs from pull request most recent head 26a8017. Consider uploading reports for the commit 26a8017 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   56.18%   55.44%   -0.74%
==========================================
  Files         149      117      -32
  Lines       36762    29006    -7756
==========================================
- Hits        20653    16083    -4570
+ Misses      13844    11054    -2790
+ Partials     2265     1869     -396

Impacted Files
Coverage Δ

pkg/meta/interface.go
48.33% <ø> (-6.67%)
:arrow_down:

pkg/sync/config.go
0.00% <0.00%> (ø)

pkg/sync/sync.go
42.97% <0.00%> (-0.56%)
:arrow_down:

pkg/vfs/vfs.go
73.10% <11.11%> (-3.14%)
:arrow_down:

... and 67 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Do not merge - testing webhook

Need a dummy PR to test a webhook.  Do not merge.

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

recheck

recheck

recheck

recheck

recheck


Local strategy keeps making backend request without any data

I've set up my local strategy with the correct backend URL and method, but it keeps getting a 400 error while no data was even sent. In the network tab it shows no payload. I've been playing around with this for some time now and can't figure out why this 400 error keeps persisting even though I've passing the username and password using the loginWith function.

Are you passing the payload correctly?
Your method call should look like this:
    await auth.loginWith('myStrategy', {
      body: {
        email<EMAIL_ADDRESS>        password: 'hunter2',
      },
    });


Interactive electrodes

Re-enable interactivity for ElectrodesTable to diagnose ongoing issues with on large tables.
If you want to avoid the deferred table rendering, simply comment out the following line in the GuidedMetadata.js file:
if (name === "Electrodes") metadata.deferLoading = true

Dang, yeah. It's stalling out


Approval count should show on failure status too

Description
Noticed this on https://gitea.com/gitea/act/pulls:

Both PRs have 1 approval, but only the first one shows "1 approval" in the list. Presumably because the second one failed the checks.
Gitea Version
1.21
Can you reproduce the bug on the Gitea demo site?
Not tested but I assume it would.

It is not relevant to action, but it's indeed a bug about official field in review table. See(https://gitea.com/gitea/go-sdk/pulls/631)


#45 Update dependencies for Python 3.10+, add TensorFlow for Windows/Mac

#45 Update dependencies for Python 3.10+, add TensorFlow for Windows/Mac

Updated dependencies to support Python 3.10 and later versions, addressing the requirements of #45.
Dropped support for Python 3.6 and 3.7 due to the constraints of the updated dependencies.
Added TensorFlow for Windows and Mac to ensure compatibility. Linux will continue to use tensorflow-lite.
As confirmed in the TensorFlow forum (https://discuss.tensorflow.org/t/how-to-install-tflite-runtime-in-windows-machine/11427), tensorflow-lite runtime is not available for platforms other than Linux.

@TheSeriousProgrammer
Hi !
I've updated this pull request to change the install condition from checking the OS to checking for ARM CPU architecture.
This should make the installation process more efficient.
Could you please review this when you have a chance?
Thank you!

Sorry for taking some time. We will get back to you.

Hi @kiri-i can you kindly resolve the merge conflicts that way I could merge your code

Any updates?

Any updates?


Add WR background from a blog post

Summary
Added condensed info from https://blog.cloudflare.com/how-waiting-room-queues

replaced by #16104


[Service Connector]: support auto install for serviceconnector-passwordless extension

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Service Connector


Register

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/15964
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.1 -m "<description of version>" 7061dcfc01b479ed7d500f9f09c3069e3dc64b97
git push origin v0.1.1

Also, note the warning: This looks like a new registration that registers version 0.1.1.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.


create Attestation in js_service_encointer

a meetup participant will scan another one's clam as QR code, decode it and then

verify contents of claim: are the following fields correct (equal to own claim)? currency_identifier, ceremony_index, meetup_index, location, timestamp (this check does not necessarily need to be done in js, could be in dart too. )
sign claim and generate Attestation

This will in turn be encoded into a QR code for the claimant to be scanned
We therefore need a js function attestClaim consuming a SCALE encoded ClaimOfAttendance returning a SCALE encoded Attestaion in service/encointer.js
open questions:

where do we verify? in js or in dart? Probably dart is easier for decent error handling than a hidden webview with js.

@clangenb do you have an opinion on where to verify the others' claim?

Even though I don't like it, I would go for js as all the crypto primitives are defined there. A very quick google search didn't yield anything in dart.

The signature should be verified in js, yes. But I wonder where to verify the fields of the struct. Both js and dart are stateful, so we could just cache our own claim and compare against that. If we want to tell the user why a claim was rejected that may be easier in dart....

Ah I see. In that case I would stay with dart then.

For test data, see https://github.com/encointer/polkawallet-flutter/issues/11#issuecomment-646955177

Added parseClaimOfAttendance that accepts hex of claim and returns all claim field converted to JSON.
NB: decoded location will no be exactly same as encoded one due to float number rounding in JS.

yes, the rounding could be an issue, but we should only check ranges for locations and not bit-by-bit

We were able to create attestations that could be decoded in the runtime. Thus, I mark this as resolved.


Distinguish between unit test compilation and "normal" compilation

Feature Request
via https://github.com/ianfixes/arduino_ci/issues/150#issuecomment-689887131

I find that I'd like a way to distinguish between when code is compiled from the Arduino IDE and when code is compiled from arduino_ci. Ideal would be something like #define ARDUINO_CI but the closest I've come is MOCK_PINS_COUNT

Initial thoughts
There is some ability to do this already, as a per-project workaround, by copying platform definitions from default.yml and adding to the defines section of a platform:
# copied from default.yml in september 2020
platforms:
  uno:
    board: arduino:avr:uno
    package: arduino:avr
    gcc:
      features:
      defines:
        - __AVR_ATmega328P__

        # This is the workaround described above
        - ARDUINO_CI
      warnings:
      flags:

Since the platform definitions' gcc section applies only to unit testing (i.e. it's not AVR compilation), this is safe.  But possibly not ideal.
Discussion points
What are best practices for injecting "evidence" of test platforms into compilation?  For example, should we copy the pattern used by the ARDUINO constant, and if so, what would the numbers represent?

My main concern is how likely it might be that someone else has defined ARDUINO_CI (something close enough to the name of the platform itself that I'd be worried about having it defined by the core project in the future).  Given #150 and the fact that multiple libraries using arduino_ci might exist in the wild (all with their own different versions), they will only work properly together if they all respond to the same constants.

Follow the same precedent Arduino uses by prefixing global macro names with the organization name. This creates a "namespace" of sorts for your macros to avoid collisions: IANFIXES_ARDUINO_CI

I guess that keeps me safe if the project gets forked or adopted elsewhere 😅
Is using my github name appropriate enough for an Arduino project?  I feel like it would be a bad mnemonic to have the constant be "the author's github name, underscore arduino, underscore CI".
I'm wondering if I should be exploring names more indicative of the idea that "this is not real hardware, this is a unit test".

I'm wondering if I should be exploring names more indicative of the idea that "this is not real hardware, this is a unit test".

That also sounds like a good idea to me, though it would (maybe) not allow code to distinguish whether they're running under arduino_ci, or maybe some alternative non-hardware Arduino core that uses the same non-hardware define.
Also, I've been thinking about this same thing for a while (partially for such a define, and partially for finding a name for such a virtual arduino core), and I'm not sure what terminology would be appropriate here. Things I considered are "Running on host" (but that's vague), "Running on x86" (but it might also be amd64 or arm/rpi), "Running on PC" (but  how about Macs?). Writing this, maybe "Virtual" is a useful concept here, since all of these are somewhat emulating a virtual Arduino (in the sense that e.g. digitalWrite() does not write to actual hardware pins, but virtual ones. This would even allow distinguishing from proper Arduino cores that run on e.g. a Rpi (not sure if they exist, but they could exist and also compile to a regular Linux executable, where digitalWrite() controls actual Rpi pins), which would not be virtual.

My best idea so far is ARDUINO_CI_UNITTEST_ENVIRONMENT which is long enough that it probably won't cause a collision, & is descriptive as to its purpose and meaning.  I'll also probably assign it some number value, and come up with a vague notion of what that number means & more importantly when it should be incremented.

I'm still using MOCK_PINS_COUNT as my flag and find that somewhat ugly.

Follow the same precedent Arduino uses by prefixing global macro names with the organization name.

Can we just go with our organization name, ARDUINO_CI?

This issue is old enough that it predates the move from my ianfixes namespace to Arduino-CI 😅
After re-reading this thread, I think I see what was bothering me about this earlier: ARDUINO_CI is/was generic, yes, but the real problem is that it didn't convey the idea that "hey, this is not the real Arduino compiler nor the real Arduino system libraries".
So, in order of preference, here's how I'd like to name the constant such that it signals to the environment that (1) the "Arduino CI" system is running things, and (2) compilation mocks are in effect.  In order of preference:

ARDUINO_CI_COMPILATION_MOCKS
ARDUINO_CI_UNITTEST_MOCKS
ARDUINO_CI_MOCKS
ARDUINO_CI_MOCKED_LIBRARIES

Any objections to these, and/or is there a better way to convey "Arduino" + "Arduino-CI" + "stuff is mocked" + "this is only for unit test compilation" to the user?

For me, ARDUINO_CI adequately communicates the mocked/testing situation. See here for a sample usage. But I can live with any of your proposals.

locally added ARDUINO_CI_COMPILATION_MOCKS and ARDUINO_CI_GODMODE in their respective header files. Those will go up to the PR branch soon.


Fix phase and amplitud reselection

When the phase field is reselected it remains the same

Fixed by adding an auxiliary function to define the custom mask with the order