fix(cheatcodes): Correct expectRevert behavior

** This is a big breaking change**
Motivation
Closes #3723 , Closes #3437 , Closes #4832 .
expectRevert currently has incorrect behavior: it matches reverts at the test level, not at the next call level. This means that reverting cheatcodes were being incorrectly catched by expectRevert (we're supposed to bypass checks for cheatcode calls) and also let users use the cheatcode incorrectly as illustrated in #3723.
Solution and Behavior
expectRevert now only works on the next CALL. Cheatcode calls are now ignored properly, even if those cheatcode calls revert. To illustrate, these are examples of now legal/illegal behavior:
// OK
function testExpectRevertString() public {
    Reverter reverter = new Reverter();
    cheats.expectRevert("revert");
    reverter.revertWithMessage("revert");
}

// FAIL
function testFailRevertNotOnImmediateNextCall() public {
    Reverter reverter = new Reverter();
    // expectRevert should only work for the next call. However,
    // we do not inmediately revert, so,
    // we fail.
    cheats.expectRevert("revert");
    reverter.doNotRevert();
    reverter.revertWithMessage("revert");
}

// FAIL
function testFailCheatcodeRevert() public {
  // This expectRevert is hanging, as the next cheatcode call is ignored.
  vm.expectRevert();
  vm.fsMetadata(fakePath) // try to go to some non-existent path to cause a revert
}

On tests marked as "not working properly"
As you can see, the diff is extremely minimal in terms of the change itself. This has uncovered a few tests which are not working as expected anymore—mainly because they were relying on the broken expectRevert behavior. Some of them seem to be bugs—mainly the fs/parsing related ones.

Working on the forge-std tests—the behavior change also breaks some tests there


Make MySQL hash_method use string instead of enum

This PR arose as a replacement for #1141.
The enum is unnecessary and uneasy to customize.
All it does is map to string anyway.
The PostgreSQL backend uses salt by default.
Using a string right away makes it trivial to do the same with MySQL.

Yes, we shouldn't use strings instead of enums. I do think we should investigate using salts, so let's keep the other PR open for now.


color property build error/weird behavior

NPM version (npm -v): 5.10.0
Node version (node -v): v8.9.1
Node Process (node -p process.versions):

{ http_parser: '2.7.0',
  node: '8.9.1',
  v8: '6.1.534.47',
  uv: '1.15.0',
  zlib: '1.2.11',
  ares: '1.10.1-DEV',
  modules: '57',
  nghttp2: '1.25.0',
  openssl: '1.0.2m',
  icu: '59.1',
  unicode: '9.0',
  cldr: '31.0.1',
  tz: '2017b' }

Node Platform (node -p process.platform): win32

Node architecture (node -p process.arch): x64

node-sass version (node -p "require('node-sass').info"):
node-sass       4.9.0   (Wrapper)       [JavaScript]
libsass         3.5.4   (Sass Compiler) [C/C++]```

npm node-sass versions (npm ls node-sass):

<EMAIL_ADDRESS>E:\laragon\www\test\assets\sass
`--<EMAIL_ADDRESS>
I got an error whenever I tried to compile my sass file.
Already tried running the syntax at https://www.sassmeister.com/ and it seems no problem.

My build command is:
node-sass --output-style expanded --source-map true style.sass ../css/style.css
The compile error is:
{
  "status": 1,
  "file": "E:/laragon/www/test/assets/sass/sass/extensions/style.sass",
  "line": 14,
  "column": 34,
  "message": "Invalid CSS after \"...255,255,0.3); }\": expected 1 selector or at-rule, was \"{\"",
  "formatted": "Error: Invalid CSS after \"...255,255,0.3); }\": expected 1 selector or at-rule, was \"{\"\n        on line 14 of sass/extensions/style.sass\n        from line 4 of sass/extensions/_all.sass\n        from line 10 of style.sass\n>>   color: rgba(255,255,255,0.3); } {\n\n   ---------------------------------^\n"
}

The .sass file syntax is this:
.foot-copyrights
        color: rgba(255,255,255,0.3)
	background-color: rgba(0, 0, 0, 0.2)
	padding: 1.5rem 0
	font-size: 1rem
	line-height: 1.8

So if I place the color in another line, for example:
.foot-copyrights
	background-color: rgba(0, 0, 0, 0.2)
	padding: 1.5rem 0
        color: rgba(255,255,255,0.3)
	font-size: 1rem
	line-height: 1.8

The compile not encountered error, but the result is weird, so in style.css file is like this:
.foot-copyrights {
  background-color: rgba(0, 0, 0, 0.2);
  padding: 1.5rem 0;
  padding-color: rgba(255,255,255,0.3);
  font-size: 1rem;
  line-height: 1.8;
}

That's what I'm reporting in. What is the problem and the solution?
I'm sorry if this case is solved somewhere or I just missing something.
Thanks in advance.

You have mixed tabs and spaces in your selector. The color: rgba(255,255,255,0.3) is indented with 8 spaces so the indented syntax thinks it's a malformed nested class. There are benefits to using the SCSS syntax 😉


Claim conversion: interface{} gets converted to map

Hi,
first off: great library!
I am setting a claim like this:
var user interface{}
claims jwt.MapClaims = make(jwt.MapClaims)

claims["user"] = user
token = jwt.NewWithClaims(j.SigningMethod, claims)

I now parse the token and retrieve the claims
token, err := jwt.Parse(key, func(token *jwt.Token) (interface{}, error) {
	return secret, nil
})
fmt.Println(token.Claims.(jwt.MapClaims)["user"])

Output:
setting claim: map[user:{{false totp secret<EMAIL_ADDRESS>Test Test}]
retrieving claim: map[user:map[Password:Test Username:Test twofa_method:totp uses_twofa:false]]

The saved interface (user) did get converted to a map. Is there any possiblity to keep the value of the the claim an interface{}?

A JWT simply stores JSON-formatted values. That var user interface{} ends up getting marshaled to JSON. When marshaling back from JSON to a jwt.Claims type (jwt.MapClaims, in this case), the unmarshaler doesn't know anything about the original golang type, only the type it's unmarshaling into. In this case, a map.
If you want different behavior, use a different jwt.Claims type instead of jwt.MapClaims. That may be as simple as something like:
type UserClaims sturct {
    jwt.StandardClaims
   User User `json:"u,omitempty"`
}

Then you would do (or example from docs):
claims  := UserClaims{
    User: user,
}

token = jwt.NewWithClaims(j.SigningMethod, claims)

And (or example from docs):
token, err := jwt.ParseWithClaims(key, UserClaims{}, func(token *jwt.Token) (interface{}, error) {
	return secret, nil
})
fmt.Println(token.Claims.(UserClaims).User)

Keep in mind that data you put into a JWT token is basically plain text (you can create one and put it here to see its decoded format). So, take care with what you put into one.
Related to that, the more you put in the claims, the larger the resulting token it will be. That may be important depending on how you expect the token to be used.

Okay thank you.

A JWT simply stores JSON-formatted values. That var user interface{} ends up getting marshaled to JSON.

I did eventually get behind that fact, after writing this issue (duh). I will look into your suggestion and give you feedback.

So I eventually settled with coverting my interface{} to an map aswell. Just made things easier.
For context: I am writing a simple and plugable authenticator and my interface{} was the user struct users are able to pass to my authenticator. So I wanted the most freedom and chose an interface.
Im closing this. Thank you for your help @dcormier


New package: PlantUML.PlantUML version v1.2023.9

I've made a manifest for PlantUML, which at this time does not work. I need some assistance fixing an issue.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/110767&drop=dogfoodAlpha

I need some help with this one:

there is an issue where the standalone .jar file is renamed to .exe.
I'd like to add a dependancy to the openjdk or java runtime if possible.

##[warning] Validation concluded that this task needs to go to manual review.

Manual Validation failed with:

1:55:31 PM: C:\Users\User\AppData\Local\Microsoft\WinGet\Links\plantuml.jar.exe
start-process : This command cannot be run due to the error: The specified executable is not a valid application for this OS platform..

This appears to be a portable JAR file.

Should Orcale.JavaRuntimeEdition or similar be a dependency?
The portable InstallerType appears to be appending a .exe to the file name. Another InstallerType might be needed, though I'm unsure of a better type.

Thanks, yeah I'd have to bounce it back to the original author in that case. Is there a downside adding support for .jar in winget-cli, I have read through the code, it doesn't appear to be particularly complicated. There is a renaming function that performs a rename operation on the filenames that appear in the URL, it assumes anything standalone is .exe, remove that assumption and I believe it may work. I got the code building, but for some reason it ran the unmodified version lol, so I'll have to look at it again tonight.

Ok so I've put this PR up.
https://github.com/microsoft/winget-cli/pull/3385
I think that might resolve the renaming issue.

As raised in:

https://github.com/microsoft/winget-cli/issues/3386

I think the best thing to do here is raise a more explicit error when the portable package doesn't have the .exe extension.
We're going to have more work to do around reasoning how WinGet should handle a Java Archive as a "portable" package.

https://github.com/microsoft/winget-cli/issues/3387

We've got the issues open that would be required to approve a PR for a portable-jar. I'm going to go ahead and close this PR. Be sure to upvote/follow the two issues mentioned above.


BUG: Error when brainvision data contains channels with units different to V or uV

what version are you using?
can you test with current master? bug about this was fixed recently

Hi Alexandre,
I am using 0.13.dev0, I cloned it yesterday.
I have a temporal fix:
mne/io/brainvision/brainvision.py line 353:
change
ranges[n] = _unit_dict.get(unit, unit) * scale
for:
ranges[n] = _unit_dict.get(unit, 1) * scale
In our setup we have an extra channel with units "N" (Newtons), I am unsure if I would break something with my temporal fix. Should I try a pull request?

@jscastanoc can you share one file with me and @jaeilepp
@jaeilepp can certainly do the fix on monday.

@agramfort just send you a piece of the data. Could you please forward it to @jaeilepp ?
Thanks!


Provide a hook for RazorPage.ExecuteAsync()

Feature request:
I can define a base class for the views, but there is no hook to execute some code before the view is executed. There is a method ExecuteAsync but it's not called on the base class.
My suggestion is to either call the base class ExecuteAsync() if there is one which is not abstract, or provide a new method that can be implemented by base view classes.

What is this for?

execute some code before the view is executed

For instance initialize some properties on the base, that require a call to async services


Fix css selector in get_vapp

Fix for issue #44

@johntopley I've just released a v1.4.0, sorry it took me so long.


Show entrypoint list with unique files list

Right now we duplicate an entrypoint file in the selection list for each type we have detected. Ideally we would show the file one time so users can select it, then select the type they would like to use to make it a bit easier to make the initial selection.

We also don't want to duplicate the open files in #2045 in this list


Prototype of CG manifest generator

Description
Prototype of a Python script to generate a cgmanifest.json file for the plugin dependencies used by a Maven project.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Add ILoggerFactory.MinimumLevel()

This should be set to Verbose by default, anything logged at a level below MinimumLevel will not be sent to any registered logger.

How exactly is this method used? Note that the logger factory implementation is not generally something that is customized. How would an app tweak the minimum level?

@lodejard  described this behavior in a comment on one of my previous pull requests

The second step is to add an ILoggerFactory.MinimumLevel property which defaults to Verbose. The Logger instances at that point will check the level against the _factory.MinimumLevel in IsEnabled and WriteCore, and won't pass the call along to the providers' ILogger instances if the argument is lower than the property.

So, all sensitive information is logger at Debug, and to see it the app must set loggerFactory.MinimumLevel = LogLevel.Debug in code before it will flow.

Got it, thanks!

It's not a method

Fixed in #114


ISPN-15211 Listeners have no way to ignore a previous old value

https://issues.redhat.com/browse/ISPN-15211

The first failure was due to GraalVM compiling our CLI which failed and the second was due to hibernate 2LC failing :( Both appear unrelated, I am restarting the build again.

Updated, tests pass with the change as well.

This is causing some failures, looking closer.

The problem is https://github.com/infinispan/infinispan/blob/main/server/hotrod/src/main/java/org/infinispan/server/hotrod/ClientListenerRegistry.java#L415 which I need to look into further, I was never a fan of having this in the first place tbh.

I think there are still some related, non-flaky failures

The two tests should be fixed now.

I don't think we want this in 14.0 after all, I will a sentence to the upgrading guide to notify users who are using 15.

Thanks @wburns


Internal Server Error Firebase hosting

With Firebase Hosting Example
Hi guys, when i deploy with-firebase-hosting example to firebase hosting, it has error "Internal Server Error"
Error Log:

Can anyone help me?
Thanks in advance!

Try this https://github.com/zeit/next.js/tree/canary/examples/with-firebase-hosting#_appjs
If you could provide a minimal reproduction repo that would be good.

The issue is building on Windows and deploying on Linux, i’ve Talked about this before in another issue and i guess node on Windows would support forward slash requires. Will have to try that out.

Try this https://github.com/zeit/next.js/tree/canary/examples/with-firebase-hosting#_appjs
If you could provide a minimal reproduction repo that would be good.

I tried to install @babel/runtime but it still does not work.
package.json
"scripts": {
    "dev": "next \"src/app/\"",
    "preserve": "npm run build-public && npm run build-funcs && npm run build-app && npm run copy-deps && npm run install-deps",
    "serve": "SET NODE_ENV=production firebase serve",
    "predeploy": "npm run build-public && npm run build-funcs && npm run build-app && npm run copy-deps",
    "deploy": "firebase deploy",
    "clean": "rimraf \"dist/functions/**\" && rimraf \"dist/public\"",
    "build-public": "cpx \"src/public/**/*.*\" \"dist/public\" -C",
    "build-funcs": "babel \"src/functions\" --out-dir \"dist/functions\"",
    "build-app": "next build \"src/app/\"",
    "copy-deps": "cpx \"*{package.json,package-lock.json,yarn.lock}\" \"dist/functions\" -C",
    "install-deps": "cd \"dist/functions\" && npm i"
  },
  "dependencies": {
    "firebase-admin": "^6.0.0",
    "firebase-functions": "^2.0.5",
    "next": "^6.0.3",
    "react": "^16.3.2",
    "react-dom": "^16.3.2"
  },
  "devDependencies": {
    "@babel/cli": "^7.0.0",
    "@babel/core": "^7.0.0",
    "@babel/runtime": "^7.0.0",
    "cpx": "^1.5.0",
    "firebase-tools": "^4.2.1",
    "prettier": "^1.14.2",
    "rimraf": "^2.6.2"
  }

The issue is building on Windows and deploying on Linux, i’ve Talked about this before in another issue and i guess node on Windows would support forward slash requires. Will have to try that out.

Hi @timneutkens,
Can you guide me specifically?

It's something we have to fix in Next.js.

I hope it will be fixed soon

i got the same error when deploying a build ( on Windows 10) to google app engine. Hope you can fix it asap. Thanks

Ah, I see, this is the cause:

\pages\_error.js should be /pages/_error.js.
Thanks @timneutkens

Is yet there a solution for this issue?
Having the same problem...

@do-n-khanh if you are in a hurry, you should be using Mac or Linux to deploy your app to Google App Engine.

@pvhieuit Thanks. Yeah, I actually had to use Windows Subsystem for Linux to deploy my app to gae.

Duplicate of https://github.com/zeit/next.js/issues/5132

#5132 is a duplicate of #5132?


I suggest adding props trStyle

<BootstrapTable data={ data } trClassName={ this.trClassFormat } trStyle={ this.trStyleFormat } >
// ........
</BootstrapTable>

How do you like this idea?

I'll support it in the future, thanks

@kozlikov fixed on v3.4.6, check this for example,
You can assign a style object to trStyle or a function, which will be more customizable.
Thanks

thanks a lot


Add ability to search by project number and development plan id

Added ability to search by projectid, devplanid, alias and former name


feat: add scale transform

In this PR, we suggest adding the scale transform [1] to the existing shift and rotate transforms.
[1] https://arxiv.org/abs/2312.11232
Checks to be done before submitting your PR

[ ] python3 -m pytest tests/ runs successfully.
[x] black . runs successfully.
[ ] make html runs successfully (in the docs/ directory).
[ ] Updated docstrings related to the changes (as applicable).
[x] Added an entry to the CHANGELOG.rst.

Thanks for reviewing the PR! It should be good now.


add k8s service and namespace

Added ability to generate following k8s manifests as single output

namespaces
service (nb: assumed port 8080!)

@matthewgardner is there an issue we can link this PR to?

@matthewgardner is there an issue we can link this PR to?

https://github.com/finos-labs/architecture-as-code/issues/32
Sorry how should I have linked these?

@Budlee are you able to review this PR, only @matthewgardner and yourself are code owners in the translator service

@Budlee one change i didnt make is to the controller - are we going to provide a separate endpoint or converge them?


Allow Include on a DTO

Steps to reproduce
Query over objects with subitems using a DTO
Note that Subitems is a many-to-many collection in my environment. I'm not sure if that makes a difference.
var results = Context.Items
  .Select(x => new ItemDto {
    Id = x.id,
    SubItems = x.items.Select(y => new ItemDto {
      Id =y.Id
    }
  })
  .Include(x => x.SubItems)
  .ToList();

This gives me a warning:
Microsoft.EntityFrameworkCore.Query:Warning: The Include operation for navigation '…Removed…' is unnecessary and was ignored because the navigation is not reachable in the final query results. See https://go.microsoft.com/fwlink/?linkid=850303 for more information.
With or without it, it's sending individual queries to the server to fetch for each item in the results list.
Is there a better way to write this query so I don't have to send the queries each time to get the Subitems for each row in results?
Further technical details
EF Core version: 2.2.6
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2019 16.1.6

@bradlis7 I tested this with the current nightly builds for 3.0 (without the Include) and got correct results--i.e. the SubItems were populated. The SQL generated was:
      SELECT [i].[id], [s].[Id], [s].[Itemid]
      FROM [Items] AS [i]
      LEFT JOIN [SubItem] AS [s] ON [i].[id] = [s].[Itemid]
      ORDER BY [i].[id], [s].[Id]

My test code:
public class Item
{
    public int id { get; set; }
    public ICollection<SubItem> items {  get; set; }
}

public class SubItem
{
    public int Id { get; set; }
}

public class ItemDto
{
    public int Id { get; set; }
    public IEnumerable<ItemDto> SubItems { get; set; }
}

public class BloggingContext : DbContext
{
    private readonly ILoggerFactory logger = LoggerFactory.Create(c => c.AddConsole());

    public DbSet<Item> Items { get; set; }

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseLoggerFactory(logger)
            .UseSqlServer(@"Server=(localdb)\mssqllocaldb;Database=Test;ConnectRetryCount=0");
}

public class Program
{
    public static async Task Main()
    {
        using (var context = new BloggingContext())
        {
            context.Database.EnsureDeleted();
            context.Database.EnsureCreated();

            context.Add(new Item {  items = new List<SubItem> { new SubItem(), new SubItem() } });

            context.SaveChanges();
        }

        using (var context = new BloggingContext())
        {
            var results = context.Items
              .Select(x => new ItemDto
              {
                  Id = x.id,
                  SubItems = x.items.Select(y => new ItemDto
                  {
                      Id = y.Id
                  })

              })
              //.Include(x => x.SubItems)
              .ToList();
        }
    }
}

Thanks for checking. It must be a 3 feature, as I ran a modified version of your code on 2 just to make sure and got this warning:
warn: Microsoft.EntityFrameworkCore.Query[10106]
      The Include operation for navigation 'new ItemDto() {Id = [x].Id, SubItems = {from SubItem y in value(Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable`1[EfTestDto.SubItem]) where  ?= (Convert(Property([x], "Id"), Nullable`1) == Property([y], "ItemId")) =? select new ItemDto() {Id = [x].Id}}}.SubItems' is unnecessary and was ignored because the navigation is not reachable in the final query results. See https://go.microsoft.com/fwlink/?linkid=850303 for more information.
info: Microsoft.EntityFrameworkCore.Database.Command[20101]
      Executed DbCommand (25ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
      SELECT [x].[Id]
      FROM [Items] AS [x]
info: Microsoft.EntityFrameworkCore.Database.Command[20101]
      Executed DbCommand (8ms) [Parameters=[@_outer_Id1='?' (DbType = Int32), @_outer_Id='?' (DbType = Int32)], CommandType='Text', CommandTimeout='30']
      SELECT @_outer_Id1 AS [Id]
      FROM [SubItem] AS [y]
      WHERE @_outer_Id = [y].[ItemId]

yay! N+1 query moved to single query.


It is a change to stopify and not stopify-continuations, so I think it won't affect your work.


Bulk Client or Client with Bulk methods?

The doc  shows BulkForceClient, but that class doesn't exist in the source code. Please update the same.

Just realized the same issue when trying to work with the BulkForceClient per docs.

Per the source code comments: Consolidated the bulk client into the ForceClient
The bulk methods should be available with ForceClient.

Yo salesforce people, the documentation is still referencing BulkForceClient which has not been around for awhile. Please update!

This issue is still relevant. Documentation needs to be updated regarding the (non-existent) BulkForceClient.


Discrepancies with roles available in Microsoft 365 admin center

Contrary to what is said on this page, some roles can't be found in the admin center, should it be with the new experience(https://admin.microsoft.com/AdminPortal/Home#/roles) or the old one (https://admin.microsoft.com/AdminPortal/Home#/users):

Password Admin
Security Admin

There's also a new role missing:

Power BI Administrator

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b4e45a4-3d00-c650-c40f-3a10b457cf46
Version Independent ID: fefa373f-f380-8988-e58a-73e9255134bb
Content: About admin roles in the Microsoft 365 admin center
Content Source: Office365-Admin/add-users/about-admin-roles.md
Service: o365-administration
GitHub Login: @adefowler
Microsoft Alias: anfowler

@officedocsbot assign @mypil

@Stephan-vNext  - Thank you for submitting feedback.
I will get this issue over to the O365ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@Stephan-vNext - I'm investigating and will get back to you with an answer.

@Stephan-vNext: I found out what happened.
PowerBI admin role is in the admin center. You might not be able to find it because by default we first show a subset of the roles, those that are most commonly used by organizations. If you scroll down the bottom of the page and select "Show all roles", the Power BI role should magically appear.
As for the other two roles Password admin and Security admin, you accidentally got a preview of roles we haven't released yet.
Per your comment, I've updated the article to add an FAQ question about why the role might be missing and removed the 2 roles that I shouldn't have written about. :-)
Thank you so much for taking the time to let me know! It's greatly appreciated.

Thanks for the answer!
I wasn't clear about Power BI admin, I did find the role in the admin center but didn't find it in the documentation :)


Gradle Kotli-Dsl example

hi,
in my project, I use kotlin-dsl for gradle and I want to release in maven central.
Your plugin looks great but I can't manage to translate the groovy style in the kotlin-dsl style.
It could be great if in the doc, there is also a kotlin-dsl style example.
Could someone do it ?
Thanks.
Hervé

I am not actively developing the plugin anymore. If you would like to get assistance for this plugin then it has to come from the community. Just wanted to mention that this plugin uses the "old" publishing API which will go away in Gradle 6.0 I believe so you might want to look for better alternatives.

@bmuschko Thanks for replying  ... indeed, Gradle 6.0 is not far away so I will try to find an other alternative. Your plugin is in everywhere tutorial to release to maven central ! Thanks for the great job you have done ... It's a shame I arrive to late ;)
Best.

I am going to close this issue. Cheers!


Create a debug symbols-only package

Option to create debug symbols in a different archive than within the JDK one.
We can either create the JDK archive with or without the debug symbols but there isn't an option to create them separately.

@milderhc - it looks like you have made great progress on this (with #2043 merged), thanks!
Are the next steps to:

update the build pipeline scripts, so that these artifacts are produced and pushed to the releases repo
served up via the API
visible on the website for download

Will you be taking that on?  Do you need any support to move this forward?

Sure. I can take those.
Could you tell me where the pipeline scripts are? And also, the idea in the API would be a new method that serves the debug symbols exclusively, as well as in the website?
I'm not familiar with any of those repos, it would take a while.

Thanks @milderhc!  Pipeline scripts are in this repo.  Though, as I look at one of the PRs that added support for debugimages for OpenJ9, I think a bunch of the work may already be in place... but defer to build team to give guidance.
@andrew-m-leonard @sxa  - Would one of you be able to assist @milderhc ?
Is all that is needed to actually update the pipeline config to build the debug images?
API work: (work is done) https://github.com/AdoptOpenJDK/openjdk-api-v3/pull/130
Website work: (still outstanding?) https://github.com/AdoptOpenJDK/openjdk-website/issues/696

Sure I can help. @smlambert @milderhc I wanted to check if the following bug I helped integrate into OpenJDK for jdk-16 is also relevant here? https://bugs.openjdk.java.net/browse/JDK-8252233

I would guess it is relevant @andrew-m-leonard - can you outline what, if any further changes are needed to produce these artifacts at the project (for hotspot builds)?

So the change https://bugs.openjdk.java.net/browse/JDK-8252233 enabled the production of a pure debug symbols image via the target:
make symbols-image

Which will result in a "build/*/images/symbols" image
The default "make product-images" which the Adopt builds use includes "symbols-image", so you should find we already have a symbols image folder being produced, we just need to zip it up... and archive.

@andrew-m-leonard - is that make target only for jdk16+ or for all versions (is it possible for all versions, or what is the debuginfo artifact that should be produced for pre-jdk16)?  perhaps you can point to the place in the code where one would make the change to enable this given https://github.com/AdoptOpenJDK/openjdk-build/issues/2042#issuecomment-742898474

@milderhc hi Milder, i've been having a look at what upstream openjdk supports and currently they vary by version:
jdk16+ : With support in https://bugs.openjdk.java.net/browse/JDK-8252233 you can now simply issue "make symbols-image". The "symbols-image" is part of the "product-images" make target, and for jdk8+ Adopt already builds that target: https://github.com/AdoptOpenJDK/openjdk-build/blob/87f799024a58d392255eead1cd83d93515410b2e/configureBuild.sh#L206 . This means for jdk16+ we already build the "build/*/symbols/.." image, we just need to archive it at the end of the build, so this line needs to be moving the "symbols" folder: https://github.com/AdoptOpenJDK/openjdk-build/blob/88c0d77255264cc92423d534de9c3563d4fb0903/sbin/build.sh#L632 ie."${BUILD_CONFIG[DEBUG_IMAGE_PATH]}" for jdk16+ needs to be "symbols".
jdk11u & jdk8u: So both of these support make "symbols-image", however they do not have JDK-8252233, and so it does not produce an image bundle, but just places the symbols in the jdk image "lib" folder. This means we have two options here:

Get JDK-8252233 backported and use the same method as jdk16+. This is probably ideal, but will take time...
Add logic to sbin/build.sh to move the symbols from lib to a new location, it looks like you have already done this? https://github.com/AdoptOpenJDK/openjdk-build/blob/88c0d77255264cc92423d534de9c3563d4fb0903/sbin/build.sh#L651  Does this work for jdk16+ ? if so then maybe ignore JDK-8252233 for the moment.

I see now you added a new build arg: --create-debug-symbols-package, so I think the question to ask is when do we want this set to true? always? if so it's just a matter of setting it in: https://github.com/AdoptOpenJDK/openjdk-build/blob/master/build-farm/make-adopt-build-farm.sh
If it only wants setting on specific platforms or versions then in here: https://github.com/AdoptOpenJDK/openjdk-build/tree/master/build-farm/platform-specific-configurations

@milderhc hi Milder, i've been having a look at what upstream openjdk supports and currently they vary by version:
jdk16+ : With support in https://bugs.openjdk.java.net/browse/JDK-8252233 you can now simply issue "make symbols-image". The "symbols-image" is part of the "product-images" make target, and for jdk8+ Adopt already builds that target: https://github.com/AdoptOpenJDK/openjdk-build/blob/87f799024a58d392255eead1cd83d93515410b2e/configureBuild.sh#L206 . This means for jdk16+ we already build the "build/*/symbols/.." image, we just need to archive it at the end of the build, so this line needs to be moving the "symbols" folder: https://github.com/AdoptOpenJDK/openjdk-build/blob/88c0d77255264cc92423d534de9c3563d4fb0903/sbin/build.sh#L632 ie."${BUILD_CONFIG[DEBUG_IMAGE_PATH]}" for jdk16+ needs to be "symbols".
jdk11u & jdk8u: So both of these support make "symbols-image", however they do not have JDK-8252233, and so it does not produce an image bundle, but just places the symbols in the jdk image "lib" folder. This means we have two options here:

Get JDK-8252233 backported and use the same method as jdk16+. This is probably ideal, but will take time...
Add logic to sbin/build.sh to move the symbols from lib to a new location, it looks like you have already done this? https://github.com/AdoptOpenJDK/openjdk-build/blob/88c0d77255264cc92423d534de9c3563d4fb0903/sbin/build.sh#L651  Does this work for jdk16+ ? if so then maybe ignore JDK-8252233 for the moment.

I see now you added a new build arg: --create-debug-symbols-package, so I think the question to ask is when do we want this set to true? always? if so it's just a matter of setting it in: https://github.com/AdoptOpenJDK/openjdk-build/blob/master/build-farm/make-adopt-build-farm.sh
If it only wants setting on specific platforms or versions then in here: https://github.com/AdoptOpenJDK/openjdk-build/tree/master/build-farm/platform-specific-configurations

@milderhc another important fact that needs evaluating before we enable --create-debug-symbols-package, is how much more space is the symbols archive going to add to our builds, for capacity planning? As this is going to add xMB per osbuild x variant x version... ?
@sxa fyi

@milderhc another important fact that needs evaluating before we enable --create-debug-symbols-package, is how much more space is the symbols archive going to add to our builds, for capacity planning? As this is going to add xMB per osbuild x variant x version... ?
@sxa fyi

Hi @andrew-m-leonard, thanks for looking into this and for the detailed explanation.
The --create-debug-symbols-package option works in jdk8u, jdk11u, and jdk16+.  We can include it directly in make-adopt-build-farm.sh which I believe is called by the build pipeline?
The space in MB for jdk11u in Linux is around 230MB and around 40MB for macOS and Windows. In jdk8u is around 100MB for LInux and 5MB for Windows. Sizes for jdk16 are pretty similar to jdk11u.

Hi @andrew-m-leonard, thanks for looking into this and for the detailed explanation.
The --create-debug-symbols-package option works in jdk8u, jdk11u, and jdk16+.  We can include it directly in make-adopt-build-farm.sh which I believe is called by the build pipeline?
The space in MB for jdk11u in Linux is around 230MB and around 40MB for macOS and Windows. In jdk8u is around 100MB for LInux and 5MB for Windows. Sizes for jdk16 are pretty similar to jdk11u.

@milderhc hi, one quick question, what is the difference between the current openj9 "-debug-image" and the new "-debug-symbols" ?

@milderhc hi, one quick question, what is the difference between the current openj9 "-debug-image" and the new "-debug-symbols" ?

isn't openj9 "debug-image" the same thing? https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/cf49ddabb9e46e90af63e85f03e3e1e71338f6a2/closed/DebugImage.gmk

isn't openj9 "debug-image" the same thing? https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/cf49ddabb9e46e90af63e85f03e3e1e71338f6a2/closed/DebugImage.gmk

it would make sense to call Hotspot one "debug-image" as well?

it would make sense to call Hotspot one "debug-image" as well?

So some rough calculations on size:
jdk8:

11 Linux = 1100MB
5 mac & win = 25MB
jdk11:
9 Linux = 2160MB
4 mac & win = 160MB
jdk15:
7 Linux = 1680MB
3 mac & win = 120MB
jdk16:
7 Linux =1680MB
4 mac & win = 160MB
jdk17:
7 Linux = 1680MB
4 mac & win = 160MB

So adding all that up = 8.9Gb increase in size of each Jenkins node workspace: /home/jenkins/workspace/build-scripts/jobs
And also 8.9Gb increase in every pipeline release cached on master.
@sxa fyi, this would currently break numerous nodes

So some rough calculations on size:
jdk8:

11 Linux = 1100MB
5 mac & win = 25MB
jdk11:
9 Linux = 2160MB
4 mac & win = 160MB
jdk15:
7 Linux = 1680MB
3 mac & win = 120MB
jdk16:
7 Linux =1680MB
4 mac & win = 160MB
jdk17:
7 Linux = 1680MB
4 mac & win = 160MB

So adding all that up = 8.9Gb increase in size of each Jenkins node workspace: /home/jenkins/workspace/build-scripts/jobs
And also 8.9Gb increase in every pipeline release cached on master.
@sxa fyi, this would currently break numerous nodes

I was asking the same myself. I think they are the same. In fact, if we call the script for openj9 along with --with-debug-symbols-package we might get two packages. It makes sense to rename debug-symbols to debug-image as well.

I was asking the same myself. I think they are the same. In fact, if we call the script for openj9 along with --with-debug-symbols-package we might get two packages. It makes sense to rename debug-symbols to debug-image as well.

I was asking the same myself. I think they are the same. In fact, if we call the script for openj9 along with --with-debug-symbols-package we might get two packages. It makes sense to rename debug-symbols to debug-image as well.

yes, agree

I was asking the same myself. I think they are the same. In fact, if we call the script for openj9 along with --with-debug-symbols-package we might get two packages. It makes sense to rename debug-symbols to debug-image as well.

yes, agree

I was asking the same myself. I think they are the same. In fact, if we call the script for openj9 along with --with-debug-symbols-package we might get two packages. It makes sense to rename debug-symbols to debug-image as well.
So I think we need to update the logic so for openj9 it uses the current "debug-image" make target as it currently does, and for the other variants uses the new logic you have added to create their "debug-image".

I was asking the same myself. I think they are the same. In fact, if we call the script for openj9 along with --with-debug-symbols-package we might get two packages. It makes sense to rename debug-symbols to debug-image as well.
So I think we need to update the logic so for openj9 it uses the current "debug-image" make target as it currently does, and for the other variants uses the new logic you have added to create their "debug-image".

Ok, I will update that first.

Ok, I will update that first.

@milderhc hi Milder, how is it going?

@milderhc hi Milder, how is it going?

@andrew-m-leonard hi, sorry for the late answer. I created the pull request: https://github.com/AdoptOpenJDK/openjdk-build/pull/2393

@andrew-m-leonard hi, sorry for the late answer. I created the pull request: https://github.com/AdoptOpenJDK/openjdk-build/pull/2393

@milderhc thanks, that PR looks good. Once that is merged it's just a matter of:

Perform Jenkins infrastructure capacity evaluation/impact: https://github.com/AdoptOpenJDK/openjdk-build/issues/2042#issuecomment-756665091
Having completed (1), adding --create-debug-image if variant != "openj9" somewhere around here: https://github.com/AdoptOpenJDK/openjdk-build/blob/102237341c7f0737f0dd4dc57fcc7e9e3ffe3bd5/build-farm/make-adopt-build-farm.sh#L164

@milderhc thanks, that PR looks good. Once that is merged it's just a matter of:

Perform Jenkins infrastructure capacity evaluation/impact: https://github.com/AdoptOpenJDK/openjdk-build/issues/2042#issuecomment-756665091
Having completed (1), adding --create-debug-image if variant != "openj9" somewhere around here: https://github.com/AdoptOpenJDK/openjdk-build/blob/102237341c7f0737f0dd4dc57fcc7e9e3ffe3bd5/build-farm/make-adopt-build-farm.sh#L164

The build output cleaning PR is now merged, and needs to propagate across the build nodes to take affect. Currently the build nodes with the most marginal space are the 2 arm nodes, with spare space of 3Gb, 4Gb respectively as of now. Introducing at this at the moment would marginalize this 2 machines by about another 1.2Gb.
I will examine each to check for any dedundent usage and monitor nodes once the clean build output has propagated across them.
@sxa fyi

Submitted build pipelines for arm on jdk8/11/16/17
New arm node space:

build-scaleway-ubuntu1604-armv7-1 :
build-scaleway-ubuntu1604-armv7-2 :

@milderhc Would you like to propose a PR to enable -create-debug-image ?
https://github.com/AdoptOpenJDK/openjdk-build/blob/ecb4ce1182b079fb88cc77ce871e3ad1216e4612/build-farm/make-adopt-build-farm.sh#L163

Thanks, @andrew-m-leonard, would that be enough for the debug-images to be downloadable?

Here it is: https://github.com/AdoptOpenJDK/openjdk-build/pull/2443

Nightly builds for hotspot with debug-image's are now available from the website: https://adoptopenjdk.net/nightly.html?variant=openjdk8&jvmVariant=hotspot

Also via the API eg.: https://api.adoptopenjdk.net/v3/assets/feature_releases/8/ea?architecture=x64&heap_size=normal&image_type=debugimage&jvm_impl=hotspot&os=linux&page=0&page_size=10&project=jdk&sort_method=DEFAULT&sort_order=DESC&vendor=adoptopenjdk

Things remaining:

Upstream mac debug jdk8 patch
Upstream win debug jdk8 fix

AIX debug symbol contributions now merged into all upstream versions, just awaiting official build levels

@andrew-m-leonard Is this now present in the July versions?

@sxa yes, complete


App crashes after merging APK

Not all apps work when they are merged. The following apps immediately crashes after merging APK. These apps used to work before XAPK is enforced
I'm using Windows 11 with java version "19.0.1" 2022-10-18
App: https://apkcombo.com/bitlife/com.candywriter.bitlife/download/apk
PS E:\APKEditor> java -jar "E:\APKEditor\APKEditor-1.1.1.jar" m -i "E:\BitLife\xapk" -o "E:\BitLife\xapk.apk"
00.000 I: [MERGE] Merging ...
   Input: E:\BitLife\xapk
 Output: E:\BitLife\xapk.apk
 ----------------------------
00.057 I: [MERGE] Searching apk files ...
00.061 I: [MERGE] Found apk files: 3
00.859 [MERGE] oading: config.armeabi_v7a.apk
00.861 I: [MERGE] Found modules: 3
00.936 I: [MERGE] Merging: com.candywriter.bitlife
00.942 I: [MERGE] Added [com.candywriter.bitlife] classes.dex -> classes.dex
00.942 I: [MERGE] Added [com.candywriter.bitlife] classes2.dex -> classes2.dex
00.942 I: [MERGE] Added [com.candywriter.bitlife] classes3.dex -> classes3.dex
00.943 I: [MERGE] Added [com.candywriter.bitlife] classes4.dex -> classes4.dex
00.943 I: [MERGE] Added [com.candywriter.bitlife] classes5.dex -> classes5.dex
00.943 I: [MERGE] Added [com.candywriter.bitlife] classes6.dex -> classes6.dex
00.943 I: [MERGE] Added [com.candywriter.bitlife] classes7.dex -> classes7.dex
00.943 I: [MERGE] Merging resource table: com.candywriter.bitlife
02.780 [MERGE] 4/notification_bg_normal.9.png
02.781 I: [MERGE] Merging: config.arm64_v8a
02.794 [MERGE] v8a/libFirebaseCppApp-9_4_0.so
02.795 I: [MERGE] Merging: config.armeabi_v7a
02.808 [MERGE] ed: lib/armeabi-v7a/libmain.so
02.855 I: [MERGE] Sanitizing manifest ...
02.857 I: [MERGE] Removed: extractNativeLibs
02.858 I: [MERGE] Removed: isSplitRequired
02.859 I: [MERGE] Removed: <meta-data android:name(@0x01010003)="com.android.vending.splits.required" android:value(@0x01010024)="true"/>
02.859 I: [MERGE] Removed: <meta-data android:name(@0x01010003)="com.android.stamp.source" android:value(@0x01010024)="https://play.google.com/store"/>
02.859 I: [MERGE] Removed: <meta-data android:name(@0x01010003)="com.android.stamp.type" android:value(@0x01010024)="STAMP_TYPE_DISTRIBUTION_APK"/>
02.861 I: [MERGE] Removed from table: res/xml/splits0.xml
02.867 I: [MERGE] Removed: <meta-data android:name(@0x01010003)="com.android.vending.splits" android:value(@0x01010025)="[REFERENCE]<PHONE_NUMBER>"/>
02.867 I: [MERGE] Removed: <meta-data android:name(@0x01010003)="com.android.vending.derived.apk.id" android:value(@0x01010024)="[INT_DEC] 2"/>
02.868 I: [MERGE] Writing apk ...
17.181 [MERGE] Writing: total=334349632 bytes : -messaging-platform.properties
17.407 I: [MERGE] Zip align ...
17.658 I: [MERGE] Saved to: E:\BitLife\xapk.apk
17.658 I: [MERGE] Done

App: https://apkcombo.com/dead-ahead-zombie-warfare/com.mobirate.DeadAheadTactics/
PS E:\APKEditor> java -jar "E:\APKEditor\APKEditor-1.1.1.jar" m -i "E:\Dead Ahead Zombie Warfare\xapk" -o "E:\Dead Ahead Zombie Warfare\xapk.apk"
00.000 I: [MERGE] Merging ...

The merging process for this bundle is perfect.
You will have to break some protection to make it functional.
This issue has nothing to do with this project.

The merge isnt the issue, this game you need to bypass the license check from pairipcore


Heroku Deployment

A Kitto dashboard should require minimal or no changes to be deployed to Heroku.
Instructions featuring the steps required to be up and running on Heroku must be added in the wiki.
The demo dashboard may then have a

button in the README.

Some work in progress can be found in https://github.com/kittoframework/demo/commits/heroku
which is succesfully deployed at: http://kitto.herokuapp.com

An actual heroku button in the readme is not really required since one would want to tweak even a little a template dashboard before deploying it.

Can we add it to the dashboard template that’s created when someone runs
mix kitto.new?
On November 17, 2016 at 2:53:55 PM, Dimitrios Zorbas (
<EMAIL_ADDRESS>wrote:
An actual heroku button in the readme is not really required since one
would want to tweak even a little a template dashboard before deploying it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kittoframework/kitto/issues/5#issuecomment-261351211,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKs1cVbYutUJBpkD0rkyWf3poO0Sdq0ks5q_LDQgaJpZM4KssvV
.

We can add Heroku deployment instructions in the generated README or at least a link to the wiki page.
But not the deploy button. It only mostly makes sense for open-source projects like rauchg/slackin. We can add it to kittoframework/demo though, for someone who wishes to evaluate Kitto Heroku deployment.


Use constexpr to simplify HPACK parser

This is a bit of a trial balloon: in C++11, generate at load time a
table that used to be hard coded. In C++14, generate that same table at
compile time, but eliminate the code generator.
Should this work out, I'd like to expand the technique so that we can
eliminate some of the confusing tables in this file by keeping the code
that generates them in the same place as the code that consumes them.

I'll defer to @veblush for the compiler issues and to @yashykt for the chttp2 code.


ADD A GLOWING BUTTON IN BUTTONS SECTION

Prerequisites

[X] I am an Open Source Contributor
[X] I checked to make sure that this issue has not already been filed

Description
Right now there are only two types of buttons.
I can add a glow button.
Please assign it to me under SWOC'24
Screenshots

Code of Conduct

[X] I follow Contributing Guidelines of this project.

Go ahead @rishicds


feat: Improved items list in invoice generator

Improved items list in invoice generator
Description

Added delete button for all items. If there is only one item, the delete button is disabled.
All items have a title, which is the index of the item in the list of items. This helps to distinguish items from each other.
Changed amount and unit to be on the same row in each item.

Before submitting the PR, please make sure you do the following

[x] If your PR is related to a previously discussed issue, please link to it here.
[x] Prefix your PR title with feat:, fix:, chore:, or docs:.
[x] This message body should clearly illustrate what problems it solves.
[x] Make sure the commit history is linear, up-to-date with main branch and does not contain any erroneous changes

Formatting and linting

[x] Format code with pnpm format and lint the project with pnpm lint

Sidenote: if you only have one-line commit messages, it's good to keep it on one line. I think the discussion on Monday might have been a bit confusing.
The first line of a commit is the "title", which summarizes the commit, and if needed for additional context you can add a body text separated by two newlines.


Reduce TerminalTab and TabBase to just Tab

This is a code hygiene item that we missed from the non-Terminal Pane work.

I started this in: https://github.com/microsoft/terminal/compare/dev/migrie/f/sui-panes...dev/migrie/b/remove-terminaltab
though, I think i deleted the SUI pane branch so that delta doesn't work anymore.
https://github.com/microsoft/terminal/compare/dev/migrie/f/992-redux-redux...dev/migrie/b/remove-terminaltab may be a closer diff


adds a live-reloading dev server to the rollup watch build

This PR:

cleans up the watch cmds in package.json
the rollup watch build will now also launch a dev server. The dev server serves the examples, which will auto-reload whenever the watch rebuilds
the rollup watch build skips the terser plugin, for easier debugging

Starting up the server during the rollup build doesn't take long, so I just ended up combining the rollup watch and rollup dev server commands. They could instead be separate watch:rollup and start:dev cmds. @texodus What are your thoughts?

The only thing I haven't figured out is how to incorporate the .less sources into the watch build:

watch src/less/material.less and rebuild dist/css/material.css on changes
watch src/less/container.less and rebuild the regular-table umd bundle on changes

but that can wait for a later PR

I figured out how to incorporate the .less files into rollup. It appears that rollup can't "just"
transpile the single material.less file, so it also outputs a dist/css/material.js file. This .js file is basically empty, and I set up the files paths in package.json to exclude it from the tarball, so this doesn't seem like a real negative to me. On the plus side:

entire build now in single workflow/command
rollup watch will rebuild correctly on changes to the .less sources
optional source maps pointing back to original .less sources
regular-table.js bundle is sliiiightly smaller (to the tune of 20 bytes)

@texodus As requested, this PR now completely removes http-server in favor of the rollup dev server. This means that the jest-puppeteer tests now also run using the rollup dev build/server.
I ran into an issue on the CI (which annoyingly didn't show up locally) where jest was trying to run tests before the rollup dev server had finished its build/start-up cycle. I was able to resolve this by having jest wait on the resources in dist to show up before starting

Picked up in #50


ZaxJsonParser.h   header issue

Issues:
What I am trying to including this ZaxjsonParser.h & .cpp files included in my library. While compiling my library I have observed few issues. If any patch exist or available please share us.
ZaxJsonParser.h:885:55: error: ‘object_to_convert’ was not declared in this scope
885 | #define JSON_PROPERTY_(member) json_property(#member, object_to_convert.member)
ZaxJsonParser.h:893:45: error: no match for ‘operator+’ (operand types are ‘std::ostream’ {aka ‘std::basic_ostream’} and ‘txapi_Input_var’)
893 |     const char* _json_buffer_end = arg_json + a_json_buffer_length; \
ZaxJsonParser.h:894:17: error: no matching function for call to ‘zax_to_json_(std::ostream&, const char*&, int&, std::tuple<>, bool, int)’
894 |     zax_to_json_(arg_json, _json_buffer_end, _result, std::make_tuple(VA_ARGS), insert_trails, a_deep);\
/../src/ZaxJsonParser.h:620:82: error: expected primary-expression before ‘)’ token
620 |     zax_to_json_(arg_json, _json_buffer_end, _result, std::make_tuple(VA_ARGS), insert_trails, a_deep);\
You want any additional information I can provide it. Could please check this issues.

Hi,
Before including ZaxJsonParser.h, please also include
#include <climits>
#include <stdlib.h>
#include <cstring>
#include <string>
#include <cstdio>
#include <map>
#include <vector>
#include <limits>

I can't provide more without having more info. Please send me exactly what you wanted to compile.
You can also take a look on the examples on the main page:
https://github.com/tamask1s/zax-parser
and check the documentation:
https://tamask1s.github.io/zax-parser/index.html


Documentation for CSS helpers / utilities classes

Are you guys planning documenting the helper / utility classes you have?
Looking at the examples, I sometimes come across some of them, like .margin-top for example. They are very useful and I know there are many more I haven't seen. Those are the kind of added values that help us do things faster but it's a waste of your effort because they aren't documented.

apparently bootstrap 4 also introduces margin/padding helper classes: http://v4-alpha.getbootstrap.com/components/utilities/#spacing, so in the new back-filling-bootstrap-4 branch we renamed our helper classes to stay in line with bootstrap 4's class names

The latest documentation site now has detailed information about utility classes
For example: http://daemonite.github.io/material/gh-pages/utilities/borders/index.html


Run a prediction

I am using Pytorch for the first time. I am not able to understand how to run a prediction on an image to get the table. Please guide.

We are using mmdetection 1.2, which provide ready to use api for inference
# Load model
config_file = './model_config.py'
checkpoint_file = './model.pth'
model = init_detector(config_file, checkpoint_file, device='cuda:0')

# Test a single image
img = "demo.jpg"

# Run Inference, "result" contains the Bounding boxes, segmentation mask and confidence
result = inference_detector(model, img)

# Visualization results
show_result_pyplot(img, result, model.CLASSES)

# or save the visualization results to image files
model.show_result(img, result, out_file='result.jpg')

You can refer this Notebook.

Any changes required in the config file provided here before predicting?

A similar unsolved issue has been mentioned here. It is unsolved.

I was unable to reproduce the error you are getting,
Please take a look at demo notebook :
Do tell us if you are still getting that error or not

the code is wrong in mmcv.utils.config.py for create the tempfile，I change it like following
def _file2dict(filename):
filename = osp.abspath(osp.expanduser(filename))
check_file_exist(filename)
if filename.endswith('.py'):
with tempfile.TemporaryDirectory() as temp_config_dir:
temp_config_file = tempfile.NamedTemporaryFile(
dir=temp_config_dir, suffix='.py')
# close temp file
temp_config_file.close()
            temp_config_name = osp.basename(temp_config_file.name)
            shutil.copyfile(filename,
                            osp.join(temp_config_dir, temp_config_name))
            temp_module_name = osp.splitext(temp_config_name)[0]
            sys.path.insert(0, temp_config_dir)
            mod = import_module(temp_module_name)
            sys.path.pop(0)
            cfg_dict = {
                name: value
                for name, value in mod.__dict__.items()
                if not name.startswith('__')
            }
            # delete imported module
            del sys.modules[temp_module_name]

Any changes required in the config file provided here before predicting? From the model zoo part I have picked the checkpoint corresponding to ICDAR 19 (Track A Modern) table detection but the above inference method fails on the last line :
from mmdet.apis import init_detector, inference_detector, show_result_pyplot
import mmcv
config_file = "cascade_mask_rcnn_hrnetv2p_w32_20e.py"
checkpoint_file = 'epoch_14.pth'
model = init_detector(config_file, checkpoint_file, device='cuda:0')

with the following error:
Exception ignored in: <bound method _TemporaryFileCloser.__del__ of <tempfile._TemporaryFileCloser object at 0x7f6aaed08710>>
Traceback (most recent call last):
  File "/usr/lib/python3.6/tempfile.py", line 591, in __del__
    self.close()
  File "/usr/lib/python3.6/tempfile.py", line 587, in close
    unlink(self.name)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpv3b8_1bi/tmp_ggj0sgp.py'
Exception ignored in: <bound method _TemporaryFileCloser.__del__ of <tempfile._TemporaryFileCloser object at 0x7f6aaed08d30>>
Traceback (most recent call last):
  File "/usr/lib/python3.6/tempfile.py", line 591, in __del__
    self.close()
  File "/usr/lib/python3.6/tempfile.py", line 587, in close
    unlink(self.name)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpdqwfqynw/tmpu40_ids3.py'

I think this is what this issue is also asking.

have you solved this problem?


teslajsonpy: fix tests

teslajsonpy has some dependencies between tests, which were masked upstream but
caused failures in nixpkgs because all the asyncio tests were skipped.  Tests
pass as they do upstream with pytest-asyncio added.
Test isolation issue is being dealt with here:
https://github.com/zabuldon/teslajsonpy/issues/121.

Motivation for this change
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113736 at eb53531b run on aarch64-linux 1

2 packages built:

python37Packages.teslajsonpy
python38Packages.teslajsonpy

1 suggestion:

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/python-modules/teslajsonpy/default.nix:25:5:
   |
25 |     (fetchpatch {
   |     ^

Oh, GitHub loaded the above commit after I merged..

Oops yes sorry about the commit message, didn't get to it in time before merge.
More recent versions have new dependencies, working on that but likely better for the upgrade to be a separate change anyway. Will send a new PR.

Could you please update to 0.13.0 in an additional commit of this PR?
0.13.0 was release a couple of hours after this PR.

I've started looking at this, first part is here: https://github.com/NixOS/nixpkgs/pull/113855.  However I haven't actually managed to get 0.13.0 working successfully in my Home Assistant installation yet, so will resolve that before opening a PR for the upgrade.

Looks like the upgraded teslajsonpy is a fairly big change and is still a WIP to integrate with Home Assistant: https://github.com/home-assistant/core/pull/46558.


fix maxmind redirection on getRemoteLastModified

In the first calls after startup, follow the MaxMind redirection in Curl

Thanks for the PR!
Looking into why a redirect error is now happening, I see that at some stage in February Maxmind have made breaking changes to how authentication works for direct download. I'll merge this and follow up with the additional auth and download url changes.


Package not downloading

Hi! I'm trying to download the package via npm and it gets this error:
Unexpected token } in JSON at position 438154 while parsing near '...k3DGag==" npm ERR!     } npm ERR!   } npm ERR! }
Thanks!

Really? Let me check it locally

Really... this is my screenshot from my MAC cmd:
[image: Screenshot 2021-08-16 at 15.56.05.png]
Thanks for your quick response.
[image: Starshot Logo]
Anna Juni
Developer at Starshot Software
https://starshotsoftware.com/?utm_source=emailsignature&utm_medium=banner&utm_campaign=emailsignature
Phone: (+34) 973 829 058
[image: Linkedin]
https://www.linkedin.com/company/starshot-software/   [image:
Facebook] https://www.facebook.com/starshotsoftware   [image: Twitter]
https://twitter.com/starshotsoft   [image: Instagram]
https://www.instagram.com/lifeatstarshot/
El lun, 16 ago 2021 a las 15:54, David Bumbeishvili (<
@.***>) escribió:

Really? Let me check it locally
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bumbeishvili/d3-v6-tip/issues/11#issuecomment-899530232,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFYZHZSPE4LKTCWI2QJDZY3T5EKATANCNFSM5CHYZVAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

--
INFORMATION ON DATA PROTECTION; Starshot Solutions SL.We inform you that
your identifying data and the contents in the emails and attachments can be
incorporated into our databases in order to maintain professional and/or
business relations and that they will be retained while the relationship is
active. If you wish, you can exercise your right to access, rectify and
delete your data and other recognised regulations by contacting the issuing
email. This message and any attached document, if any, may be confidential
and intended solely for the person or entity to whom it have been sent.

I thought the issue was opened into my other project (which I was testing minutes before), that why I had such a reaction.
Thank you for reporting this, will check it once I will find a time frame

Sounds good, thanks! I will wait for your fix. 😊
[image: Starshot Logo]
Anna Juni
Developer at Starshot Software
https://starshotsoftware.com/?utm_source=emailsignature&utm_medium=banner&utm_campaign=emailsignature
Phone: (+34) 973 829 058
[image: Linkedin]
https://www.linkedin.com/company/starshot-software/   [image:
Facebook] https://www.facebook.com/starshotsoftware   [image: Twitter]
https://twitter.com/starshotsoft   [image: Instagram]
https://www.instagram.com/lifeatstarshot/
El lun, 16 ago 2021 a las 16:00, David Bumbeishvili (<
@.***>) escribió:

I thought the issue was opened into my other project (which I was testing
minutes before), that why I had such a reaction.
Thank you for reporting this, will check it once I will find a time frame
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bumbeishvili/d3-v6-tip/issues/11#issuecomment-899534824,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFYZHZUMBQLPSS3VRV7GDG3T5EKYVANCNFSM5CHYZVAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

--
INFORMATION ON DATA PROTECTION; Starshot Solutions SL.We inform you that
your identifying data and the contents in the emails and attachments can be
incorporated into our databases in order to maintain professional and/or
business relations and that they will be retained while the relationship is
active. If you wish, you can exercise your right to access, rectify and
delete your data and other recognised regulations by contacting the issuing
email. This message and any attached document, if any, may be confidential
and intended solely for the person or entity to whom it have been sent.


(chocolatey-core.extension) add helper to set install location

Sometimes, it may be desirable to set the installation directory manually in an install script. This can be done by setting $env:ChocolateyPackageInstallLocation, however, it would be good to have a helper that abstracts the functionality. It should not set the variable if it is already set, unless force is passed.
This is so the install directory can be set for installers that do not set an explicit install directory in the registry, and for packages that have a complex install script that requires manual install directory setting. See https://github.com/orgs/chocolatey-community/discussions/2254

My thoughts around this is to introduce two new cmdlets with a similar name to the Get-AppInstallLocation that is already implemented.

Add the cmdlet Set-AppInstallLocation, which should have the responsibilities of:

Should have the parameters -LiteralPath and -Force. Literal Path should be mandatory (could potentially have -Path as an alternative that allows globbing, but not sure how useful that is)
It should verify whether the environment variable is already set or not, and only override the environment variable if it isn't set (both null, and an empty value) unless -Force is also used.
It should verify that the path specified exists, if it doesn't exist, it should throw an exception.
It should have an output value of the path that was set.

Add the cmdlet Update-AppInstallLocation, which should have the responsibilities of:

Should have the parameters -AppNamePattern and -Force where AppNamePattern is mandatory.
It should call Get-AppInstallLocation to get the correct install location.
It should throw an exception if the installation path could not be found.
It should verify whether the environment variable is already set or not, and only override the environment variable if it isn't set (both null, and an empty value) unless -Force is also used.
It should have an output value of the path that was set.

Alternatively to the second cmdlet, we could also just have the first one but make LiteralPath/Path and AppNamePattern be mandatory in different sets.


Filter before HTTPS on Full framework seems to break kestrel

ASP.NET 1.1.1
https://github.com/Drawaes/FullFrameBrokenVsCore/tree/master
In that project you can see a "pass through" stream (this is not the actual use case but is simplified to show the issue at hand).
If you use the flag in the project (UseHttps) and run with netcoreapp1.1 it works fine. If you turn off Https using that flag it works in 461 and Netcoreapp1.1.
However if that flag is on in 461 you never get the last "chunk" of the request.
Any ideas why this would be this is causing issues in prod.
Cheers

I know there are tests for logging connection filter before/after https. This isn't a known issue for the full framework is it?

cc @halter73

This scenario works on full framework given the right pass through Stream. We test it here. I think you're running into an issue because BackToBackStream doesn't implement the APM methods that LogginStream does.

Bingo, that works thanks a bunch!


Add o11y integration

Duplicate? https://github.com/canonical/zookeeper-operator/pull/50

Duplicate? #50 Abuelodelanada#1

@sed-i @Abuelodelanada Sorry for that. I didn't see yours. I would keep this one, as it clears some leftovers from when we had node-exporter, removes unused libs and whatnot.


fix(tests): vm_... extracted from proc are not reliable

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Some data extracted from proc are not so reliable like vm_rss vm_size vm_swap, the CI is failing for this reason. Instead of using the expected values we can use GREATER_EQUAL than 0
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

/cc @gnosek

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Handle namespace change of aggregate root in SQL Identity Map

Currently the SQL based Identity Map uses the FullName of the aggregate root type to link to the serialized representation of the natural key. If this were to occur in an existing system then the identity map would fail to return the correct identifier.
We need to come up with some mechanism whereby the developer can configure the type forwarding for the SQL identity map. Maybe this can piggyback off the existing .NET type forwarding implementation?

Need to decide whether to attempt to support this in the default SQL Identity Map (which is fairly basic) or to provide another independent solution preferably in a different repository.

There is no plan to support this functionality.


CmiDeliverSpecificMsg() should sleep on idle if CmiDeliverMsgs(1) would

Original issue: https://charm.cs.illinois.edu/redmine/issues/645

NAMD startup phase 1 using CmiDeliverMsgs(0) doesn't allow the thread to sleep when oversubscribed.  This seems correct.  CmiDeliverMsgs(1) does allow the thread do sleep, so it seems CmiDeliverSpecificMsg() should as well.

Original date: 2015-01-21 14:35:17

What was the initial reason behind changing from CmiDeliverMsgs(0) to CmiDeliverMsgs(1) ? CmiDeliverSpecificMsg(..) looks like a blocking call unlike CmiDeliverMsgs(1), I'm not sure if it make much sense to allow the thread to go to sleep for that function.

Original date: 2015-01-22 01:18:18

The use case is busy-waiting:  "while ( !  ) { CmiDeliverMsgs(0); }".  If you do this with oversubscribed cores progress degrades severely because none of the threads ever sleep.  It's not an important use case but the fix seemed easy.

Original date: 2015-01-22 21:19:56

According to Jim, performance degrade happens in the startup in smp mode when each worker thread in the node assigned a comm thread. As Namd should not run this way, we have decided, this change is not worthwhile to implement. Instead Charm++ smp mode could provide a more strict default case for ppn.


i can not pull a image from  https://registry-1.docker.io/

Expected behavior
Actual behavior
i can not pull a image from  https://registry-1.docker.io/
Information about the Issue
HTTP code is 500 which indicates error: server error - {"message":"Get https://registry-1.docker.io/v2/library/mysql/manifests/latest: Get https://auth.docker.io/token?account=*******\u0026scope=repository%3Alibrary%2Fmysql%3Apull\u0026service=registry.docker.io: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)"}

Looks like your timeout was too big when pulling - Please try this again from a solid connection.


Dealing white spaces is not enough in goog.string

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=249

This has been fixed


Add Zig to Programming Languages

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Zig is a cool programming language!

Sure! 😃

Slightly off-topic, but do you think https://github.com/HaxeFoundation/haxe would be another good addition?

Sure. Go for it!


Build on Travis

Merged in https://github.com/embed-rs/stm32f7-discovery/commit/00a827ef361caec4ff7d5c8cba0417cdf50ab221


Run tests against insiders

Duh, CI hence close and reopen..

@IanMatthewHuff @rchiodo I'll remove the commented code from the redux logger. it was just adding too much stuff for me ..
Will remove once PR is approved. looks like all tests are going smoothly, functional tests and others as well.

Codecov Report

:exclamation: No coverage uploaded for pull request base (ds/custom_editor@7ff3ed6). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             ds/custom_editor    #9872   +/-   ##
===================================================
  Coverage                    ?   60.64%
===================================================
  Files                       ?      555
  Lines                       ?    29726
  Branches                    ?     4479
===================================================
  Hits                        ?    18028
  Misses                      ?    10697
  Partials                    ?     1001

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff3ed6...642b733. Read the comment docs.


consider adding support to official marlin

Hi,
I see you have done a great work, why wouldn't you add the support for this printer directly into Marlin ?
You would have less maintenance to do.

Hello atsju,
thanks for the credit. You are right and I thought about this when I created this repo last year.
The main reason why I haven't done this is because I am not realy a programmer and I don't know how to contribute in Github to other projects. As I haven't changed just the configuration and configuration_adv I am not sure how to give this examples to the great contributers of marlin.
The second reason is, that the interest from others into these configs is realy small. I have only 42 views from 7 visitors, so I thought the effort isn't worth it.
And the third reason is, that I for myself don't print that much, so I don't follow every new marlin change. I just make upgrades for fun and when I have the time. With "official" marlin support I thought I would have to give the community more maintanance.
Anyhow, if you are interessted into merging my configurations into official marlin and can help me with that. I would do it. I like marlin and this would be my thank you to these great people.

@Alexoko12 Do you happen to have access to the DGUS / DWIN_SET source files? I would love to be able to edit the screen menus.

Hey,
sorry I haven't. I got the lootmax_pic and font folder only once when Lotmaxx Support themselves send me a software update, because I had an issue I can't even remember anymore. ^^
Maybe you can ask them in the facebook group or via email.

Thank you for responding!
I will add a link to your repo from my sc-10 shark V2 project.
Just in case someone is looking for this one.


wrong renamed the tag

Vue - Official extension or vue-tsc version
v2.1.4
VSCode version
1.92.2 (Universal)
Vue version
3.4.29
TypeScript version
5.4.5
System Info
No response
package.json dependencies
No response
Steps to reproduce

=>

<Form.Item v-if="formData.courseObjectiveList.length" class="curseTargetList">
  <Tag
    v-for="(item, index) in formData.courseObjectiveList"
    :key="index"
    class="h-32px flex items-center b-none"
    closable
    @close="removeCourseTarget(index)"
  >
    {{ item.title }}
  </Tag>
</Form.Item>

delete the line of </Tag>
the <Tag will auto rename to <

What is expected?
Expected:
add a config to the extention, and close the function of auto rename
or
when delete the close tag of the html block, and not auto rename the start tag
What is actually happening?
the start html tag was deleted
Link to minimal reproduction
No response
Any additional comments?
No response

I cannot reproduce, and Vue - Official does not have the renaming feature you described. Could you disable all other extensions and try again?

@KazariEX

I used extension bisect to identify that the issue was with our plugin, but then I found out that the problem only occurred when the vim plugin was enabled, so the issue must be with vim itself. sorry

editor.linkedEditing, the problem is produced by this config.

You can report it to vscode.

link this issue https://github.com/microsoft/vscode/issues/216626


[BUG] Asterisk and intersecting fragments not working as expected

HI, all!
I got the following code:
package main

import (
	"log"

	"github.com/gobwas/glob"
)

func main() {
	pattern := "start*art"
	gl := glob.MustCompile(pattern)

	s := "start"
	log.Printf("Result: %v", gl.Match(s))
}

Which results in:
$ ./main
2023/08/01 16:20:08 Result: true

I expect it to be false. Is this a bug?

I checked it against filepath.Match function:
package main

import (
	"log"
	"path/filepath"

	"github.com/gobwas/glob"
)

func main() {
	pattern := "start*art"
	gl := glob.MustCompile(pattern)

	s := "start"
	log.Printf("glob result: %v", gl.Match(s))

	matched, err := filepath.Match(pattern, s)
	if err != nil {
		log.Fatalf("failed to match: %v", err)
	}

	log.Printf("filepath.Match result: %v", matched)
}

Result:
$ ./main
2023/08/01 16:58:00 glob result: true
2023/08/01 16:58:00 filepath.Match result: false

It seems like a bug...


Sprig console

Delay in the movement of the sprig console

could you give more details?

Hey Lucas, the Sprig console in Home page is an moveable item, and the movement of it is slightly delayed, it probably could be because of delay in page loading in general but that is an issue.

I cannot reproduce this issue, there is no delay for me?
We recently updated the UI for Sprig, can you check again if this is still an issue on your side? @Shrey-Mehra

Hey Sam,
i checked the sprig it working fine

closed as no repro

—the 3d model needs time to load in, can't really magically solve this


increase min-height to for longer starred items in feed

fixes https://github.com/sindresorhus/refined-github/issues/109

Thanks @axelav :)

my pleasure @sindresorhus :)


Why sounddevice has status flag in callback function?

sounddeivce.get_status() gets info about over-/underflows in play()/rec()/playrec(), returns CallbackFlags – A CallbackFlags object that holds information about the last invocation of play(), rec() or playrec().

[x] what is over-/underflows?
[ ] which flags do status have?
[ ] why callback function needs this flag?

The flags are used to tolerate errors.


Color Training

When i try to train the Color Branch,there is a error occurred.Could you give me a suggestion when you have time.
The error message is as follows:
Traceback (most recent call last):
File "create_beautygan_uv.py", line 51, in
uv_texture, uv_seg = generator.get_texture(image, seg)
File "/data/run01/scv0004/CPM-main/Color/texture_generator.py", line 23, in get_texture
pos[:, :, :2].astype(np.float32),
TypeError: 'NoneType' object is not subscriptable

Hello there, I guess there's something wrong with that image.
Could you change the line here  to this:
try: 	uv_texture, uv_seg = generator.get_texture(image, seg) except: 	print('Something wrong with: ', list_imgs[i])
And we'll look at that image later.
I've faced that issues before, it turned out that there's no faces in the images; Or dlib couldn't detect any faces.

Hi again,
If there's something wrong with the images (no face, degraded, corrupted images, etc.), then I can't help.
Else, dlib couldn't detect any faces (very few cases)
Please handle these images by passing face's bounding boxes manually (Find more information here)
I'm closing this issue and hope you can run the code smoothly!


Digger apply fails to download artifact (plan file) from GitHub

In our setup we specify 'github' as destination for the tfplan files. So when I run digger plan, the plan file is successfully attached to the PR with 'plan-$PRNUMBER.zip' name format. All good so far.
However, when running digger apply, another plan is executed as part of the digger run, and this produced only local tfplan file, which is not uploaded to GitHub. When the apply step finally happens, it fails with the following errors:
Failed to run digger apply command. error retrieving plan: error downloading plan: failed to download artifact, status code: 400
Failed to run commands. error while running command: Failed to run digger apply command. <nil>
Error: Process completed with exit code 8.

When I remove the  upload-plan-destination: 'github' attribute from the workflow, digger apply is successful, likely because it is using the locally generated tfplan.
Additional helpful information

In the version I previously used (v0.2.0), digger apply successfully fetched the tfplan file from GitHub.
Here's the workflow file I use:

name: Digger
run-name: Digger on a Fargate hosted Github Actions Runner
on:
  pull_request:
    branches: [ "main" ]
    types: [ closed, opened, synchronize, reopened ]
  issue_comment:
    types: [created]
    if: contains(github.event.comment.body, 'digger')
  workflow_dispatch:

jobs:
  build:
    if: contains(github.event.comment.body, 'digger')
    runs-on:
      labels: default
    permissions:
      contents: write      # required to merge PRs
      id-token: write      # required for workload-identity-federation
      pull-requests: write # required to post PR comments
      statuses: write      # required to validate combined PR status
      actions: write       # required for artifact (plan) upload

    steps:
      - name: install-aws-cli
        uses: unfor19/install-aws-cli-action@v1
      - name: digger run
        uses<EMAIL_ADDRESS>        with:
          setup-aws: false
          setup-terraform: true
          upload-plan-destination: 'github'
          no-backend: true
        env:
          GITHUB_CONTEXT: ${{ toJson(github) }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GITHUB_WORKSPACE: ${{ github.workspace }}

I'm happy to provide more info if necessary.

Thanks for reporting - this is super helpful! We are looking into it

Some context from trying to fix it (also asked on Reddit):
The plan storage logic is fairly straightforward:

DownloadLatestFiles() function uses the ListArtifacts() method of the Github API client to list all artifacts for a repo

getLatestArtifactWithName() function picks the latest one for the PR matching plans-{prNumber} pattern

DownloadArtifact() method of the Github client is used to get the download URL of the artifact (NOT download the file). It returns 302 redirect (docs)

downloadArtifactIntoFile() function uses that URL to actually download the artifact into plans-{prNumber}.zip file

But for some reason, step 4 fails with a 400 error:
<?xml version="1.0" encoding="utf-8"?><Error>InvalidAuthenticationInfo<Message>Authentication information is not given in the correct format. Check the value of Authorization header.
RequestId:27a833fd-001e-00df-1052-4dd7c7000000
Time:2024-01-22T16:43:14.6875514Z</Message></Error>

The url expires in 1 minute so it’s supposed to be public. But just to be sure, I tried setting Authorization: token <GITHUB_TOKEN> in the request anyways; that didn’t help, still the same error (UPD neither did bearer format)
The URL in the redirect looks like this, presumably using Azure Blob Storage:
https://productionresultssa9.blob.core.windows.net/actions-results/<guid>/workflow-job-run-<guid>/artifacts/plans-11.zip?se=2024-01-22T17%3A18%3A40Z&sig=<signature>%3D&sp=r&spr=https&sr=b&st=2024-01-22T17%3A08%3A40Z&sv=2021-12-02

A similar error from blob storage like in this question on SO suggest using auth via SharedKey, but then it doesn’t really make sense in the context of Github Actions; it seems unlikely that GitHub API would return a URL that requires Azure-specific auth.

Should be fixed in #1081


Question: Atom packages on WSL

Hey guys, Sorry for taking up a issue but I wanted to ask this question.
If you install node via the WSL, Can atom use that version of node or not?
If not, then I'll just continue as normal.
Thanks :)

Atom actually comes bundled with Electron which has a very specific version of node already included. You can't mix an match even without WSL as part of the equation.


funny lines to right of (cell) phenotype section

Which browser is that?  I haven't seen that before.

chrome.
I can see when it happens now.
go to cdc2, scroll down to phenotypes. Looks normal.
Then  resize your browser to make the page narrower... then scroll right....

I get some display oddness when I do that but not like your screenshot.  I'll work on that.

oddly I only see it for cdc2 cellular phenotype.
I was just looking at ral3 and that was fine?

duplicate

https://github.com/pombase/website/issues/227


OOMs on new application package deployments

Describe the bug
I was doing experiments where I included enough ML models to increase the application package size from 1.5MB to 40MB. The deployment of the 40MB package failed but it seemed that the update still got picked up because I observed the generation number bumped in the config server logs. The call to the activate application endpoint failed because the config server OOM'd and it took a long time to propagate the update so it timed out. Since then, we've reverted the change (not including the ML models anymore), but we're still getting OOMs on every deploy causing massive heap dumps (up to 2GB in size) eventually causing the file system to run out of disk space and us having to delete the heapdumps. We've deployed the config server with a max heap size of 2GB.
To Reproduce
Perhaps deploy a large application package over and over again for 115 generations (probably less generations should do it) with a configured max 2GB heap size.
Expected behavior
I expect memory usage of the config server not to increase over each deploy especially when the newer package sizes are smaller.
Screenshots
java_pid274_Leak_Suspects.zip
I've ran Eclipse's MAT tool against the heap profile and attached the generated report in case it helps.
Environment (please complete the following information):

OS: Linux
Infrastructure: AWS / self-hosted
Versions: 7.329.19

Vespa version
7.329.19
Additional context
Based on the leak suspects I see mentions of zookeeper which potentially indicates that zookeeper is keeping the full history of all application packages (in this case we're on generation 115) - is this expected behavior? And if so is the solution here to just bump up the max heap size or is there a way to discard old generations if we have no intention of going back to old versions?

2G heap is a bit small for config servers, yes, we run with larger, and as you observed more important with larger packages. I am assigning to @hmusum the config server expert for details, and we will update https://docs.vespa.ai/en/operations/configuration-server.html accordingly. thanks for reporting!

@kkraune Thank you for the confirmation. To my other question - is there a way to delete / garbage collect some of the older generations?


pam: fix spelling mistake in configuration

Motivation for this change
Just a small spelling mistake that needs to be corrected.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks!


Upgrade to SQLite 3.24.0

Are there any plans to upgrade to SQLite 3.24.0? I'm aware this version was very recently released however there is a feature I'm keen to use: Support for additional custom columns in Rtree tables. This makes it significantly easier to deal with Rtrees for geospatial applications.
https://sqlite.org/rtree.html

With cocoapods you can easily use any recent version of SQLite3 together with SQLite.swift. Or do you specifically mean Swift support/wrapping of these new features?

Is there a way to specify this version of SQLite w/o Cocoapods? I imported the project manually. I dont expect thered be any changes on the SQLite.swift front to support this (and if there were I'd simply make sure of its ability to execute raw SQL- at least in the mean time). The changes simply allow you to insert more columns when creating the table. Cheers and thanks for a great lib!

If you integrate SQLite directly you can specify the version yourself, however there are currently no instructions for that.

I'm having some issues trying to directly integrate sqlite3 (and spatialite) with SQLite.swift.  @jberkel do you know of any resources anywhere that document this process?
Side note:  looks like iOS 12 ships with sqlite3 v3.24.0.

fixed, closing


Fix data race in test

This change fixes 2 small data races on TestAddWhileRunningWithDelay and TestJobWithZeroTimeDoesNotRun in cron_test.go.

Just noticed the v3 branch, and it's already fixed there. It's master stale or unmaintained?
Thanks!


Is it possible to import normalized counts or UMAP from seurat?

I like using seurat (R) for sc data normalization, visualization and analysis, but I am interested in the scirpy package to analyze the TCR data, as it is very complete and has some advantages respect other similar R packages. I will use 10x genomics in my experiment. I was wondering if it is possible to represent clonotype data from scirpy in UMAPs  from seurat.
I think that seurat normalized counts can be merged easily with TCR data using the merge function of scirpy. But probably the UMAP representation from scanpy is going to be distributed different in space, so I don't know if it is possible to add the UMAP coordinates from the seurat object to the scirpy object, or maybe there is another solution.

Hi @algarji,
scanpy stores the umap coordinates in adata.obsm["X_umap"].
You can manually set those to the coordinates computed by seurat. Then plotting with clonotypes should work.
Or you can export adata.obs after running scirpy and add it back to the Seurat object in R and make the plots there.
Cheers,
Gregor

Hi @algarji,
scanpy stores the umap coordinates in adata.obsm["X_umap"].
You can manually set those to the coordinates computed by seurat. Then plotting with clonotypes should work.
Or you can export adata.obs after running scirpy and add it back to the Seurat object in R and make the plots there.
Cheers,
Gregor

Thanks @grst for the quick response. Yes, I will try what you propose on some training data, it seems affordable.

Thanks @grst for the quick response. Yes, I will try what you propose on some training data, it seems affordable.

Hi @algarji,
scanpy stores the umap coordinates in adata.obsm["X_umap"]. You can manually set those to the coordinates computed by seurat. Then plotting with clonotypes should work.
Or you can export adata.obs after running scirpy and add it back to the Seurat object in R and make the plots there.
Cheers, Gregor

HI@grst
I am also interested in using seurat for scRNAseq, but using scirpy for scTCR.
After combining the data of transcriptome and TCR in scirpy, I want to back to seurat for data merge with multiple samples, do Umap and other analysis. But I met problem when I convert h5ad to seurat. I am not sure is this the problem because I add TCR information or not.
Do you know how to solve the switchover from scirpy to seurat?
Thanks.

Hi @GouQiao,
how are you importing the h5ad object into seurat? There are several ways of doing that and neither way worked flawlessly for me in the past :/
Since all information you need is usually just some annotations in adata.obs, a way that should definitely work is to export adata.obs to a csv file, and manually load the columns you need into your Seurat object.
Cheers,
Gregor

Hi @GouQiao,
how are you importing the h5ad object into seurat? There are several ways of doing that and neither way worked flawlessly for me in the past :/
Since all information you need is usually just some annotations in adata.obs, a way that should definitely work is to export adata.obs to a csv file, and manually load the columns you need into your Seurat object.
Cheers, Gregor

Hi,
Thanks for your quick reply.
You mean after extracting adata.obs by adata.obs.to_csv, then add obs information by AddMetadata in seurat?
Gou

I like using seurat (R) for sc data normalization, visualization and analysis, but I am interested in the scirpy package to analyze the TCR data, as it is very complete and has some advantages respect other similar R packages. I will use 10x genomics in my experiment. I was wondering if it is possible to represent clonotype data from scirpy in UMAPs from seurat.
I think that seurat normalized counts can be merged easily with TCR data using the merge function of scirpy. But probably the UMAP representation from scanpy is going to be distributed different in space, so I don't know if it is possible to add the UMAP coordinates from the seurat object to the scirpy object, or maybe there is another solution.

HI.
Have you solved the problem?

You mean after extracting adata.obs by adata.obs.to_csv, then add obs information by AddMetadata in seurat?

exactely!

Thanks for reply.
I tried this way, but I could not do PCA or Umap for seurat after this...

Are you trying to plot PCA and UMAP in Seurat or in Scanpy?
I'm a bit confused, because adding an additional Metadata variable in
seurat shouldn't affect the UMAP or PCA plots at all.
On Mon, 20 Dec 2021 at 09:04, Qiao @.***> wrote:

Thanks for reply.
I tried this way, but I could not do PCA or Umap for seurat after this...
—
Reply to this email directly, view it on GitHub
https://github.com/icbi-lab/scirpy/issues/231#issuecomment-997685358,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVZRV3UE7Q74WWP7UYYOZ3UR3PQHANCNFSM4WAYSGMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Maybe I did something wrong. I used addmeta funtion, but I found the characters become NA value.
If you dont mind, could you share the codes for add scirpy TCR into seurat object?
Thank you!
adata.obs.to_csv("Thy_scTCR.csv")
Thy_obs<-read.csv("Thy_scTCR.csv")
Thyctl<-AddMetaData(Thyctl,Thy_obs)
               orig.ident nCount_RNA nFeature_RNA    X is_cell high_confidence multi_chain extra_chains IR_VJ_1_c_call IR_VJ_2_c_call

AAACCTGAGAAACCAT-1     Thymus       5332         2279
AAACCTGAGACTTGAA-1     Thymus       1628          984
AAACCTGAGATGCCAG-1     Thymus       4978         1996
AAACCTGAGCTAGTCT-1     Thymus       1031          678
AAACCTGAGGATATAC-1     Thymus        709          504
AAACCTGAGTGTTAGA-1     Thymus       1776         1042
AAACCTGCAAACCCAT-1     Thymus       2977         1576
AAACCTGCAAATACAG-1     Thymus       2384         1435
AAACCTGCAAGGTTCT-1     Thymus       1027          756
AAACCTGCACCAGGCT-1     Thymus        998          697

If you dont mind, could you share the codes for add scirpy TCR into seurat object?
I have never done that myself, as I practically never work with Seurat.

I used addmeta funtion, but I found the characters become NA value.
I would suspect that the cell-barcodes don't match between your csv file and the Seurat object and this is causing the NAs. So maybe you can investigate that


[v1] Add delete vector functionality to new client

Problem
The node client does not currently support deleting vectors via /vectors/delete.
Solution

Add a new delete.ts file within /src/data/.
Implement deleteVector to allow HTTPS calls to delete a single vector or a batch of vectors.
Add a new delete.test.ts file to support unit tests. Covers validating request parameters, and error cases.
[Bonus] Rename /src/control/__tests__/deleteCollection.index.ts -> /src/control/__tests__/deleteCollection.test.ts. The test runner may not have been picking this one up.

Type of Change

[X] New feature (non-breaking change which adds functionality)

Test Plan

Added a new unit test file to cover the new module. Run with npm run test:unit.
Use npm run repl to test manually.

To test you'll want to upsert vectors and then call delete:
npm run repl

// generate the client and legacy instances
await init()

// grab an index from client
const index = client.index('test-upsert-delete')

// upsert vector(s)
const vectors = [
  {
    id: 'test-vector-1',
    values: [1, 2, 3, 4, 5],
  },
  {
    id: 'test-vector-2',
    values: [1, 2, 3, 4, 5],
  },
];

await index.upsert(vectors);

// delete via id
await index.delete({ ids: ['test-vector-1'] })

// validate the delete
await index.fetch(['test-vector-1'])
// empty vector response: { vectors: {}, namespace: '' }

// test deleteAll
await index.delete({ deleteAll: true })

// validate the delete
await index.fetch(['test-vector-2'])

After testing I think this is good to merge. I think we should follow up by splitting this into deleteOne, deleteMany, and deleteAll just to simplify the overall usage.

Sounds good, I like the idea of splitting that functionality into explicit functions rather than the primary one being a bit overloaded.


add derived fields to cluster pgen

This adds various derived fields to the cluster pgen:

cell radius
entropy
sonic Mach number
plasma beta
temperature
cooling time

@par-hermes format

@par-hermes format

@par-hermes format

@par-hermes format

I think I've fixed the cooling time bug. It looks good from vim-inspection of 1D profile data given by Ascent

CI passed (though still not reported yet). I'm merging now.


SupportShouldProcess Design

Both user facing and base functions/cmdlets that do dangerous operations (set,update,remove,etc) should use the Cmdlet Option of SupportShouldProcess.
When the top level code makes a call to the base code it can then use the -confirm:$false flag to bypass its ShouldProcessing logic.
This way no matter if you are scripting using the base functions or simply using the cli stuff you will always be prompted.

Added this functionality to these functions:
Update-KeePassEntry
Update-KeePassGroup
Set-KPEntry
Set-KPGroup
Remove-KeePassGroup
Remove-KeePassEntry
Remove-KPGroup
Remove-KPEntry


add support to hide tooltips, key => seriesKey to avoid React prop clash.

this PR makes the following improvements 🚀

[shared][tooltip] don't render a tooltip if the output of renderTooltip is falsy
breaking [xy-chart] use seriesKey instead of key in onMouseMove event signature (relevant to StackedBarSeries and GroupedBarSeries only)

cc @alecklandgraf

what do you think about duplicating key with seriesKey (or stackedKey)? it would make this backward compatible.

Coverage increased (+0.03%) to 83.212% when pulling 74464449da9671c60f5f7f53d4b00608e0351885 on chris--falsy-tooltip into 49733e90607944e2a9018737cdf438b2aaf592e8 on master.

thanks for the comments.
I'd rather not always pass key around since it's reserved in React, we haven't been avoiding breaking changes in vx or data-ui until we hit a major version just so we can land on better apis. I think that seriesKey is slightly better because it can be used by stacked + grouped bar series.

Coverage increased (+0.02%) to 83.206% when pulling f88831a37da9f49a5cf7aefdf86aeb866d5de70f on chris--falsy-tooltip into 49733e90607944e2a9018737cdf438b2aaf592e8 on master.