Impossible to configure cilium via helm values

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
It impossible to configure some cilium options like set enable-k8s-networkpolicy to false in cilium helm chart
As per documentation enable-k8s-networkpolicy is true by default, so in case one wants to disable it, nothing happens because helm template allows only to enable it.
This allows only setting to true (which is true by default).
I am pretty sure it is not the only option which might have similar issue.
Cilium Version
1.14.x, 1.15.x
Kernel Version
N/A
Kubernetes Version
N/A
Sysdump
not relevant
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello, thanks for opening the GH issue, please provide steps to reproduce the issue and a cilium sysdump otherwise the issue can't be fixed. Thank you.

as a workaround I've used extraConfig

@aanm Thanks for looking in to this,
steps to reproduce are pretty simple:

install cilium using chart configured to disable native k8s netpolicies support.

expectations:

ability to turn off k8s native net policies support via helm chart values, as there is already k8sNetworkPolicy option available.

reality:

k8sNetworkPolicy can be used only to set enable-k8s-networkpolicy to true due to the way how templating is done, and this doesn't make any sense because enable-k8s-networkpolicy is true by default.

However I was able to workaround it by doing this:
    extraConfig:
      enable-k8s-networkpolicy: "false"

So the bug fix here would be correct up the linked entry:
https://github.com/cilium/cilium/blob/v1.14.1/install/kubernetes/cilium/templates/cilium-configmap.yaml#L766-L768
To use something like
{{- if hasKey .Values.k8sNetworkPolicy "enabled" }}
  enable-k8s-networkpolicy: {{ .Values.k8sNetworkPolicy.enabled | quote }}
{{- end }}

That way, it can be set to false. I'll mark this as a good-first-issue

This seems to work for me.
$ cat values.yaml
k8sNetworkPolicy:
    enabled: "false"

$ helm template cilium cilium/cilium -f values.yaml | grep 'enable-k8s-networkpolicy'
enable-k8s-networkpolicy: "false"

ohh... maybe I was doing
k8sNetworkPolicy:
    enabled: false

I might've missed quotes... which makes sense.
@aanm Feel free to close the issue.

This seems to work for me.
$ cat values.yaml
k8sNetworkPolicy:
    enabled: "false"

$ helm template cilium cilium/cilium -f values.yaml | grep 'enable-k8s-networkpolicy'
enable-k8s-networkpolicy: "false"

In my opinion, requiring a "string" for something that is supposed to be a boolean value is a bug. It also yields a worse user experience, as --set k8sNetworkPolicy.enabled="false" will not work on the command-line (one has to use --set-string).  Let's not close this and instead fix our templates.

Hi, if this issue still there i want to work on this can you assign me?

It seems like this is working for me in the latest version( 1.16.0-dev.) of Cilium "
I cloned main branch.
helm install cilium --set enable-k8s-networkpolicy=false

@gandro ,There is one pr raised against this issue as mentioned. but is not yet merged and closed .do i need to raise another pr request for this issue to close ?


[Release] KIC version 2.8

Signed-off-by: Diana<EMAIL_ADDRESS>Summary

Bumping the version for the KIC 2.8 release.
TODO

[ ] Go through all the merged/open KIC 2.8 PRs and make sure that any new/changed files are also added to the 2.8 nav (because as far as I know, they were only changed in 2.7 or earlier)
[ ] Verify that new/changed files render correctly.
[ ] After this PR is merged, run Algolia
[ ] Run the broken link checker for the full site

Reason

Upcoming KIC 2.8 release
Testing

TBD (I'll add links for the new/heavily revised pages that should be tested)

I have one more PR before we merge this: https://github.com/Kong/docs.konghq.com/pull/4944

2.8 has now released, this should be all set to go once the validation steps in the OP are complete.


[xy-chart] add withTheme HOC

This PR adds a withTheme HOC for easier theme customizability. example usage:
const XYChartWithTheme = withTheme(theme)(XYChart);

Tested in demo page + with jest.
note it also adds a sanity width/height check to <XYChart /> for positive values.

Coverage decreased (-4.4%) to 73.347% when pulling 483e64ee002268b5ac40ac357b7919b27c408275 on chris--withTheme into 1be14331f171744b9dc552072f4fa7aecdd95158 on master.

Coverage increased (+0.6%) to 78.306% when pulling 6cbe50f79f809068a8fa41d7235891d019aaca51 on chris--withTheme into 1be14331f171744b9dc552072f4fa7aecdd95158 on master.


New read name hashes have collisions.

The hash algorithm being used to generate the new ZMWs in the read names seems to have collision.  This causes critical issues in downstream processing.

Fixed by #115


The auto assign role command is not running.

He does not have automatic role assignment even though he has all the authority

version 1.1.0-beta

Give your bot administrator permissions. Make sure you're editing the right role. Move bot's role to the top. I tested it, and it works. You're missing some permission.


sidebar is not fixed

whan I can see django message after changing notes

@Fahreeve Not sure what you mean by "django message", we are using Flask.

@levlaz I mean orange box with message in the header of the page

Sorry, I am still not understanding your question. :(

sory, my english is bad(

I created new note
I updated this note and I see this message

"The note has been updated" without indentation
I scrolled down the page and see this

see lower left corner

No problem at all, you can ask in Russian too, Я говорю по русски ;)
This makes perfect sense.
Yes I am aware that this is broken. The flashing message should be a popover instead of pushing everything down. This was broken after the third iteration of the UI came out. I am mostly happy with the way things look now so this is something that needs to be fixed with the current state.


fix($swipe): add pointer support

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
NgSwipe does not work on microsoft surface IE11 when used with ng-swipe-disable-mouse.
This is due to the fact that IE11 does not use touch events but pointer events.
https://github.com/angular/angular.js/issues/14061
What is the new behavior (if this is a feature change)?
Add the support of pointer events in $swipe
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

Other information:
add pointer events to $swipe to support IE11 on touch devices
Closes #14061

LGTM :+1:

Although it feels more like a feature, than a bug fix.

Hello @gkalpak,
As you can see in https://github.com/angular/angular.js/issues/14061, this ticket has been classified as a bug. That is why I have pushed as a fix.

LGTM2 - let's call it a feature :-)
Merging


Delays and Errors (codes 13 and 14), usually from <IP_ADDRESS>

Expected Behavior
Reliable, repeatable responses from calls to dash platform.
Current Behavior
I have some very basic code testing dash 3.0.2.  Typically it takes 3 to 4 seconds for dash.isReady() and then 0.3 - 0.4 seconds for dash.platform.identities.get(aValidId) to resolve.
Every now and then (sometimes back to back, sometimes after 10 successful calls) it takes 20 to 30 seconds to resolve either or both of the above, after which it usually (but not always) results in an error.  The errors are usually code: 13 or code: 14, and might (always?) be (solely?) related to <IP_ADDRESS>.
Sample Errors
ETIMEDOUT Error:
error: Failed to perform standard injectionsconnect ETIMEDOUT <IP_ADDRESS>:3000 { Error: connect ETIMEDOUT <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1107:14)
  errno: 'ETIMEDOUT',
  code: 'ETIMEDOUT',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000,
  config:
   { url: 'http://<IP_ADDRESS>:3000',
     method: 'post',
     data:
      '{"jsonrpc":"2.0","method":"getBestBlockHash","params":{},"id":1}',
     headers:
      { Accept: 'application/json, text/plain, */*',
        'Content-Type': 'application/json;charset=utf-8',
        'User-Agent': 'axios/0.19.2',
        'Content-Length': 64 },
     transformRequest: [ [Function: transformRequest] ],
     transformResponse: [ [Function: transformResponse] ],
     timeout: 20000,
     adapter: [Function: httpAdapter],
     xsrfCookieName: 'XSRF-TOKEN',
     xsrfHeaderName: 'X-XSRF-TOKEN',
     maxContentLength: -1,
     validateStatus: [Function: validateStatus] },

Error 13:
{ Error: 13 INTERNAL: Internal error
    at Object.exports.createStatusError (/sandbox/node_modules/grpc/src/common.js:91:15)
    at Object.onReceiveStatus (/sandbox/node_modules/grpc/src/client_interceptors.js:1209:28)
    at InterceptingListener._callNext (/sandbox/node_modules/grpc/src/client_interceptors.js:568:42)
    at InterceptingListener.onReceiveStatus (/sandbox/node_modules/grpc/src/client_interceptors.js:618:8)
    at InterceptingListener._callNext (/sandbox/node_modules/grpc/src/client_interceptors.js:574:12)
    at InterceptingListener.onReceiveStatus (/sandbox/node_modules/grpc/src/client_interceptors.js:618:8)
    at callback (/sandbox/node_modules/grpc/src/client_interceptors.js:847:24)
  code: 13,
  metadata:
   Metadata {
     _internal_repr:
      { server: [Array], date: [Array], 'content-length': [Array] },
     flags: 0 },
  details: 'Internal error' }

Error 14:
{ Error: 14 UNAVAILABLE: failed to connect to all addresses
    at Object.exports.createStatusError (/sandbox/node_modules/grpc/src/common.js:91:15)
    at Object.onReceiveStatus (/sandbox/node_modules/grpc/src/client_interceptors.js:1209:28)
    at InterceptingListener._callNext (/sandbox/node_modules/grpc/src/client_interceptors.js:568:42)
    at InterceptingListener.onReceiveStatus (/sandbox/node_modules/grpc/src/client_interceptors.js:618:8)
    at InterceptingListener._callNext (/sandbox/node_modules/grpc/src/client_interceptors.js:574:12)
    at InterceptingListener.onReceiveStatus (/sandbox/node_modules/grpc/src/client_interceptors.js:618:8)
    at callback (/sandbox/node_modules/grpc/src/client_interceptors.js:847:24)
  code: 14,
  metadata: Metadata { _internal_repr: {}, flags: 0 },
  details: 'failed to connect to all addresses' }

Context
This happens on my local setup as well as the codesandbox I set up (see below).
Steps to Reproduce & logs

Visit https://codesandbox.io/s/dash-test-y0b7n?file=/src/index.ts
Drag the "Terminal" pane up to the top for better viewing (don't need the browser pane).
Make a trivial edit (like adding a space after "Done" in the main().then() callback.
Do cmd + s to save file and trigger the sandbox to re-run.
Repeat step 3 and 4 until you see errors.

I think this might be a known issue related to a rouge masternode but I didn't see an issue here, and maybe there's more to it than the bad masternode, so I figured I'd post it.

Just tried to reproduce again and ran into the odd case where the call worked but took 23 seconds:
[INFO] 01:17:09 Restarting: /sandbox/src/index.ts has been modified
Using ts-node version 8.10.1, typescript version 3.8.3
warn: Running on a NodeJS env without any specified adapter. Data will not persist.
Loading
Done loading: 23.611 s.
Getting data
Done getting data: 0.362 s.
9983954
Done

Well, this is what happens when we have offline nodes on the network. I've mentioned yesterday on discord that the solution would be is to have a ban-and-retry policy in the client. This is in our backlog for the current/next week

I've been doing some pretty heavy development on the Platform and I would say that these errors occur on well over 50% of the calls I make to the network, in essence rendering it unusable in any practical sense. There is no way I would currently introduce anyone not already familiar with all the hard work and effort going into this project to working with it at this stage: they would simply find it to be broken. For my 2 cents, addressing this should be an absolute top priority, and if there's any useful contribution that can be made I would be very willing to do so.

@riongull @cloudwheels I've enable DKG and PoSe bans on evonet, and all rogue nodes are gone now

Nice work @antouhou.  As far as I’m concerned we can close this. I haven’t seen any errors since the fix.

Thank you @riongull for this issue.
I'm closing this issue, do not hesitate to reopen it if you find it not fixed.


Added support for data reader's GetValues method.

The current driver throws an unimplemented exception when GetValues is called on a datareader. A new implementation has been added.

Approved.


Maybe nice to have hexdoc

Currently nerves_livebook is not published as a Hex package; thus the Hexdocs links are broken. In a way, it is expected but I am wondering if we can possibly publish a package for the sake of the documentation.

That's a good idea!
Let me try it out in a bit...

Fixed in v0.8.3. If you try that again with v0.8.3, you'll be taken to https://hexdocs.pm/nerves_livebook/0.8.3/NervesLivebook.html#check_internet!/0.
Thanks for the suggestion!


[SPARK-11745][SQL] Enable more JSON parsing options

This patch adds the following options to the JSON data source, for dealing with non-standard JSON files:

allowComments (default false): ignores Java/C++ style comment in JSON records
allowUnquotedFieldNames (default false): allows unquoted JSON field names
allowSingleQuotes (default true): allows single quotes in addition to double quotes
allowNumericLeadingZeros (default false): allows leading zeros in numbers (e.g. 00012)

To avoid passing a lot of options throughout the json package, I introduced a new JSONOptions case class to define all JSON config options.
Also updated documentation to explain these options.
Scala

Python

Test build #45972 has started for PR 9724 at commit 00cfc19.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45971/
Test FAILed.

Test build #2061 has started for PR 9724 at commit 00cfc19.

Test build #2061 has finished for PR 9724 at commit 00cfc19.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #45972 has finished for PR 9724 at commit 00cfc19.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45972/
Test PASSed.

Alright I've updated it.

Test build #45981 has started for PR 9724 at commit d8ca56d.

LGTM pending jenkins.

Test build #45981 has finished for PR 9724 at commit d8ca56d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * case class JSONOptions(\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45981/
Test PASSed.

Thanks - I'm merging this in.


Support multiple Auths

Signed-off-by: Davide Salerno<EMAIL_ADDRESS>What this PR does / why we need it:
This change will let you define multiple authentication methods as described in the specifications and highlighted in this issue
Special notes for reviewers:
In order to avoid to have different authentication methods with the same name, a new custom validator is added into the auth package
Additional information (if needed):
Se the specifications https://github.com/serverlessworkflow/specification/blob/main/specification.md#auth-definition

Closes #55

@davidesalerno, I believe I fixed the lint issue, can you please rebase so we can try it again?


IE text is not vertically centered

Not sure it matters, but:

I've tried working on this before. I had zero success. See https://github.com/USGS-VIZLAB/water-use-15/pull/248#discussion_r184226293.


fix: updated DAs versions + add use existing resources test

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

https://github.com/terraform-ibm-modules/dev-rag/issues/5

/run pipeline

:tada: This issue has been resolved in version 0.2.1 :tada:
The release is available on:

GitHub release
v0.2.1

Your semantic-release bot :package::rocket:


Classification versus Recommendation

I followed your tutorial and wanted to apply dsstne to a different project.  It seems that the only output of the predict method is one that generates recommendations with the trained net and I want classification output.
I tried training a feedforward network with the output layer being classification data to all my training instances, but the output it generated doesn't seem right.  I am hoping there is a predict method call for this situation.

Is there a way to produce classification output from a trained network?

Is there a max number of features for a training instance? (I tried 20,000 initially but got a 'std::bad_alloc' error. 10,000 produced no error)

Can you share the input and output of your call to predict?
Cesar
On Fri, Jul 8, 2016 at 11:52 AM, skilgall<EMAIL_ADDRESS>wrote:

I followed your tutorial and wanted to apply dsstne to a different
project. It seems that the only output of the predict method is one that
generates recommendations with the trained net and I want classification
output.
I tried training a feedforward network with the output layer being
classification data to all my training instances, but the output it
generated doesn't seem right. I am hoping there is a predict method call
for this situation.

Is there a way to produce classification output from a trained network?
2.
Is there a max number of features for a training instance? (I tried
20,000 initially but got a 'std::bad_alloc' error. 10,000 produced no error)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/amznlabs/amazon-dsstne/issues/47, or mute the thread
https://github.com/notifications/unsubscribe/AAcM6IPi_mWuQisnkNuPPGrK5OIltt11ks5qTpx3gaJpZM4JITM5
.

Input file look like this:
Document1 1:1:0:0:0...
Document2 1:0:1:0:0...
Output file looks like this:
Document1 1
Document2 0
I use the generateNetCDF method the same way as the tutorial only using the output file in the output call.
I've tried two different versions of the predict call:
predict -b 1024 -d gl -i features_input -o features_output -k 10 -n gl.nc -s recs -r input_file -f input_file
predict -b 1024 -d gl -i features_input -o features_output -n gl.nc -s recs -r input_file -f input_file -l Output
Either way I get an output in the recs file that looks like this for all documents:
Document1 1,0.000:0,0.000:
Document2 1,0.000:0,0.000:

Do you have any suggestions to get non zero output from the net?
Is there anything wrong with my call to predict?
Thanks in advance

I think there is an issue with that way you have been training. Since it is Optimized for Sparse kernel. You just need to pass the label of the index which is 1. You dont need pass the label which is zero. From the above example you have given it is assumed that the label 1 and label 0 is active all the time. Instead can you pass the only the indexes which are 1.

I took your advice and following the example input data I used in my first post converted it to:
Document1 1,1:2,1:...
Document2 1,1:3,1:...
I've tried multiple output formats, this output is the only one that returns a non 1 or 0 output
Document1 1,1 <- Class Value 1
Document2 2,1 <- Class Value 2
(I've also tried these formats with no success:
Document1 1,1:2,0 Document2 1,0:2,1
Document1 1,0  Document2 1,1)
This gives output 1,0.788:2,0.992: for every single instance. (The other config formats give 1,1.000:2,1.000 for all instances or 1,1.0000 for every instance)  The number of epochs affects the output in the wrong way, error goes up when epochs increase from 10 to 100.
Can you see anything wrong with my methods?  I don't understand how the output should be formatted in a classification example and especially that I am getting the same prediction for each instance.

Can you try Using the following as Input
Document1 1:2
Document2 t1:3
And Output as
Document1 1
Document2 2
Ensure that the separator between Document and the features is a tab. Also can you send us the command you tried and attach your sample document

I tried that exact input and output file details and received this for every instance:
1,0.000:2,0.000:
These are the commands that I have been using:
generateNetCDF -d gl_input -i inputfile -o gl_input.nc -f features_input -s samples_input -c
generateNetCDF -d gl_output -i outputfile -o gl_output.nc -f features_output -s samples_input -c
train -c config.json -i gl_input.nc -o gl_output.nc -n gl.nc -b 256 -e 10
predict -b 1024 -d gl -i features_input -o features_output -k 10 -n gl.nc -s recs -r inputfile -f inputfile
Attached are my input and output files
Archive.zip

You have an interesting case here.  You have 1000 input features, of which an average of 256 are on for a given datapoint.  I am guessing the sparse kernels here will not behave efficiently, but I do believe I can detect this situation and still keep storage efficient.  I am working on a simple program to build your data set correctly.

So since I don't have write access to the github repo, I'm attaching a short program to create DSSTNE-compatible data.
Observations:

DSSTNE was designed for data density of 1% or less.  Your input example is just under 26%.  What this means is that you may have run into a performance blackhole for DSSTNE.  I can fix that, the Movielens 20M example (which is 0.4% dense) accidentally works itself around the problem by exploiting sparse storage efficiency but not the sparse training code.

I am going to build a CSV importer for DSSTNE.  I'm going to base it on the CSV file used in the TensorFlow example "wide and deep" https://research.googleblog.com/2016/06/wide-deep-learning-better-together-with.html.  Is there any other format for which you'd like import capability?

Any code changes I make will most likely end up in my fork of the code at https://github.com/scottlegrand/amazon-dsstne-1 because the Amazon DSSTNE guys are too busy to process push requests ATM.

dparse.cpp and a slightly modified config_1000.json attached here.  To build dparse, type:
g++ -o dparse dparse.cpp -lnetcdf_c++4 -lnetcdf -lm -std=c++0x -L
config_1000.json has been changed to use "input" and "output" as the dataset names.
issue47.zip


Add @remove_entity on workflow-actions doc reference

Thank you for your pull request.
It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/
If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.
Once you've signed the CLA, please allow for about an hour for the submission to be processed.

Signed,
Will this accelerate the acceptation process on these pull requests? To be honest waiting for days/month with no feedback is very disappointing to all contributors

Thanks, @rodolfobandeira
we'll do our best to accelerate PRs processing.


refine customization code in cosmosdb

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Unbound: 1.8.3 -> 1.9.0

Motivation for this change
Version bump.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build unbound

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/12


Why does binding for vairant not implement Clone trait?

the wasmtime rust bind-gen for import wit file does not implement Clone trait for variant. Why is that? It caused a compile error for the following wit file
variant my-result {
    error(string),
    some(string)
}
record my-record {
    result: my-result
}

echo: function(r: my-record) -> my-record

The compile error is
the trait bound `MyResultParam<'_>: Clone` is not satisfied
the trait `Clone` is not implemented for `MyResultParam<'_>`

I took a look at the generated file by running wit-bindgen wasmtime --import repro.wit and the enum MyResult does not derive from the Clone trait but MyRecord derives from the Clone trait.

I just ran into the same issue with similar code and I believe it is caused by this check:
https://github.com/bytecodealliance/wit-bindgen/blob/01231ec85703fdc18b82b47d2a60f23138c61b1d/crates/gen-rust/src/lib.rs#L539-L541
What would be the best way to resolve this issue? We could try to be smart and only add the #[derive(Clone)] when each field is also Clone, but that could make the codegen more complicated.
@alexcrichton do you remember why we don't want to implement Clone when a record owns its data?


University to student feedback

Create a model and a view that let the university make a feedback report for the student.
the endpoints for this are:

api/reports/uni-stu-feedback/
api/reports/uni-stu-feedback/int:pk/

Also please resolve the conflicts before tonight


WIP: BPF veth MASQ and ip-masq-agent

TODO:

[ ] Cleanup integration test (last commit)
[ ] Write description

This change is

test-me-please

test-me-please


Composite resource page reload not working - hotfix

When user sets a file type, on successful setting of file type the page should reload automatically. It is not happening in the current release candidate 1.12. This needs to be a hot fix.

Will close this as soon I can test this hotfix on beta.

Did test beta and seems to have fixed this issue. So closing.


Improve article section

Fixes #34134
@hakenr ... See what you think of these "improvements" ... "improvements" in quotes because I might be making it worse! 😆

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/security/server/index.md
aspnetcore/blazor/security/server/index

@guardrex This doesn't align with my understanding of how scoped services work in Blazor. Give me a few minutes to run some tests.

Sure thing. This came from the PU, so we'll get one of them on here. I may have misinterpreted their supplied remarks/content. I'll also go find the original source of this and cross-link it here. I'll do that after I finish the 9.0 movie tutorial updates. 🏃♂

Looking better.
Do you still have a concern about the overall approach? I'd rather not ping an engineer unless you have a general concern because they're still super busy with post-9.0 release work. This guidance came from them, so I assume that the overall approach/scenario is valid.


Rename project to serverless-graphql-boilerplate

We've renamed the project several times (and discussed this extensively) but I think that the "boilerplate" is missing in the name.
Recently I've recommended this project to another developer and he was like "Ah that's a boilerplate! At first I thought that this is a kind of extension or plugin so that GraphQL works with Serverless".
Heard similar comments about it a few times.
So I would propose to go with "serverless-graphql-boilerplate". It's a small change but I think that this makes it more accessible for starters / people who are searching for Serverless boilerplates.

I also agree with that proposal. It would continue the naming scheme as it is used with the plugins today, e.g. serverless-XXXX-plugin.
In general all packages that extend the use or serve a certain purpose should follow the same generic naming scheme:
serverless-{name of package}-{type of package}

@HyperBrain Good point! That makes identifying the purpose of the package way easier!

There was a really good issue in the main project asking for plugin naming
conventions to change to serverless-plugin-[name].  I think the same
ordering convention would be valuable here, allowing searches for
serverless-boilerplate in order to increase discoverability whether using a
flexible search solution or not.  It definitely supplies a better
auto-complete-style identification of the one you're looking for.
On Apr 22, 2016 1:39 AM, "Philipp Muens"<EMAIL_ADDRESS>wrote:

@HyperBrain https://github.com/HyperBrain Good point! That makes
identifying the purpose of the package way easier!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/serverless/serverless-graphql/issues/34#issuecomment-213327890

Maybe changing the names from the already established naming scheme with plugins would be wide-breaking! All the repositories are named serverless-[name]-pluginso far and all users' package.json also contain the current scheme (not to speak of NPM).
My opinion is that adapting the current plugin naming scheme would cause the least efforts for everyone

Yep. serverless-boilerplate-[name] would be a good convention! Haven#t thought about the auto completion but love it.

I agree Frank, it would be a bit of a pain.  That said, its only a
convention so it can be changed slowly, at will, over time for plugins.
Maybe in conjunction with the next round of breaking changes when
modifications have to happen regardless.
On Apr 22, 2016 7:09 AM, "Frank Schmid"<EMAIL_ADDRESS>wrote:

Maybe changing the names from the already established naming scheme with
plugins would be wide-breaking! All the repositories are named
serverless-[name]-pluginso far and all users' package.json also contain
the current scheme (not to speak of NPM).
My opinion is that adapting the current plugin naming scheme would cause
the least efforts for everyone
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/serverless/serverless-graphql/issues/34#issuecomment-213442763

Yes, that might work and the auto-completion might weight here if you even think of bash-completion etc.

Renamed it serverless-graphql-apollo and also opened up a Relay version :)


Fix FVSAND_GPU_KERNEL_LAUNCH macro

Summary
This PR fixes the compilation issues with FVSAND_GPU_KERNEL_LAUNCH macro, introduced in 65d704d967db21a1d200569da255eebb08070521. Moreover, changes the LocalMesh::CreateGridMetrics routine to use the FVSAND_GPU_KERNEL_LAUNCH macro instead.

Thanks George. On the first call the number of threads N=(ncells+nthreads)*3, since I was trying to do the x, y- and z- coords of cell center all together.  I see that  the argument to the function is still (ncells+nthreads). It's a bit confusing. I will fix that. Otherwise LGTM

On the first call the number of threads N=(ncells+nthreads)*3, since I was trying to do the x, y- and z- coords of cell center all together. I see that the argument to the function is still (ncells+nthreads). It's a bit confusing. I will fix that. Otherwise LGTM

I see. Thanks for clarifying -- I thought the iteration loop was looping over the interval [0, ncells+nhalo)...

@jsitaraman -- if you are OK with it, can we merge this?


No unicode update

Seems that -> does not work. I have let =>.
I have added in equivalent to ∈.
We have:

julia> @def o begin
               z in R, variable
               t in [ 0, 1 ], time
               x in R^2, state
               u in R, control
               r = x1
               v = x2
               0 <= r(0) - z <= 1,            (1)
               0 <= v(1)^2 <= 1,              (2)
               [ 0, 0 ] <= x(0) <= [ 1, 1 ],  (♡)
               z >= 0,                        (3)
               derivative(x)(t) == [ v(t), r(t)^2 + z ]
               integral( u(t)^2 + z * x1(t) ) => min
           end
ERROR: ParsingError:
Line 8: (0 ≤ v(1) ^ 2 ≤ 1, 2)
bad constraint declaration

because of v = x2. Do we accept this kind of aliases? It means that we need x1, x2, ..., automatically.

It seems that we have x[1], x[2] available instead of x1, x2...

This works now:
    @def o begin
        z in R^2, variable
        t in [ 0, 1 ], time
        x in R^2, state
        u in R^2, control
        r = x1
        v = x2
        0 <= r(0) - z1 <= 1,            (1)
        0 <= v(1)^2 <= 1,               (2)
        [ 0, 0 ] <= x(0) <= [ 1, 1 ],   (♡)
        z1 >= 0,                        (3)
        z2 == 1
        u2(t) == 0
        derivative(x)(t) == [ v(t), r(t)^2 + z1 ]
        integral( u1(t)^2 + z1 * x1(t) ) => min
    end

@jbcaillau Please review and merge.

@jbcaillau Please review and merge.

thanks:

yes, x[i]'s are automatic aliases (up to any dim)
=> was already in merged main (and in doc), checking there are no conflicts 🤞🏾
nice for in (missed it)

@jbcaillau Please review and merge.

thanks:

yes, x[i]'s are automatic aliases (up to any dim)

Yes I figured it out. I have added xi. Ok?

=> was already in merged main (and in doc), checking there are no conflicts 🤞🏾

It seems ok. Too bad that -> is not working.

nice for in (missed it)

👍

yes, x[i]'s are automatic aliases (up to any dim)

Yes I figured it out. I have added xi. Ok?

nice for in (missed it)

👍

Good. Check https://github.com/control-toolbox/OptimalControl.jl/pull/299


test creating a database in a temp directory

Teaching a disk DB commands fails because the cache is not initialized properly. Add a test that teaches a disk-backed DB commands.


Unable to build plutus pab

Summary
I have installed the repo using nix-shell and tried running cabal build plutus-pab.
I'm getting the below error.
Warning: Requested index-state 2021-10-20T00:00:00Z is newer than
'hackage.haskell.org'! Falling back to older state (2021-10-19T23:39:06Z).
Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] next goal: cardano-crypto-class (user goal)
[__0] rejecting: cardano-crypto-class-2.0.0 (conflict: pkg-config package
libsodium-any, not found in the pkg-config database)
[__0] fail (backjumping, conflict set: cardano-crypto-class)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: cardano-crypto-class

Steps to reproduce

Clone the repo
nix-shell
`cabal update
cabal build plutus-pab

Expected behavior
Expected to start the Plutus PAB server.
System info (please complete the following information):

OS: macOS BigSur
Version 11.6
404af7ac3e27ebcb218c05f79d9a70ca966407c9

Screenshots and attachments

What's your nix config? (cat ~/.config/nix/nix.conf) Is sandbox enabled? Can you please try with sandbox=false? Or check that which cabal is actually from /nix/store/....

The issue was with the pkg-config and the libsodium.
I have added the libsodium path to PKG_CONFIG_PATH variable, then the build went through successfully.
Closing this issue.


Weather not syncing to server

1.18.2 Geyser-Fabric; Bedrock client isn't syncing weather after Clear -> Rain, it stays stuck raining until a reconnect to the server.
Server modlist:
Geyser-Fabric-2.0.3-SNAPSHOT.jar
c2me-fabric-mc1.18.2-0.2.0+alpha.7.0-all.jar
fabric-api-0.51.1+1.18.2.jar
fabrictailor-1.8.1.jar
ferritecore-4.2.1-fabric.jar
graves-2.0.0+1.18.2.jar
krypton-0.1.9.jar
lazydfu-0.1.2.jar
lithium-fabric-mc1.18.2-0.7.9.jar
servercore-1.2.9-1.18.2.jar
starlight-1.0.2+fabric.89b8d9f.jar
vmp-fabric-mc1.18.2-0.2.0+beta.3.17-all.jar

Duplicate of https://github.com/GeyserMC/Geyser/issues/2499 and/or https://github.com/GeyserMC/Geyser/issues/2588


When I return to the page of the root controller from a page, pull down to refresh and report an error

======== Exception caught by gesture ===============================================================
The following assertion was thrown while handling a gesture:
'package:flutter/src/widgets/scrollable.dart': Failed assertion: line 701 pos 12: '_drag == null': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=2_bug.md

When the exception was thrown, this was the stack:
#2      ScrollableState._handleDragDown (package:flutter/src/widgets/scrollable.dart:701:12)
#3      DragGestureRecognizer._checkDown.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:450:51)
#4      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:253:24)
#5      DragGestureRecognizer._checkDown (package:flutter/src/gestures/monodrag.dart:450:7)
#6      DragGestureRecognizer._addPointer (package:flutter/src/gestures/monodrag.dart:277:7)
#7      DragGestureRecognizer.addAllowedPointer (package:flutter/src/gestures/monodrag.dart:289:5)
#8      GestureRecognizer.addPointer (package:flutter/src/gestures/recognizer.dart:160:7)
#9      RawGestureDetectorState._handlePointerDown (package:flutter/src/widgets/gesture_detector.dart:1498:18)
#10     RenderPointerListener.handleEvent (package:flutter/src/rendering/proxy_box.dart:3168:29)
#11     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:440:22)
#12     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:336:11)
#13     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:395:7)
#14     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:357:5)
#15     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:314:7)
#16     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:295:7)
#17     _invoke1 (dart:ui/hooks.dart:164:13)
#18     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:361:7)
#19     _dispatchPointerDataPacket (dart:ui/hooks.dart:91:31)
(elided 2 frames from class _AssertionError)
Handler: "onDown"
Recognizer: VerticalDragGestureRecognizer#042dd
  start behavior: start
====================================================================================================

@shengbin1998
Can you provide us a runnable but minimal reproducible code sample along with flutter doctor -v that throws the reported error ?

Sorry, I checked for a long time and found that although an error was reported in the refresh component, it was actually caused by the destruction of my child controller due to Get


Update CouplerPulse

Update CouplerPulse to include qubits detuning parameter

Seems somewhat restrictive to only have a single detuning parameter. Would you ever want to detune the qubits by different amounts?

I don't think there is a need for that, at least in the foreseeable future. We've been detuning the qubits from their center frequency an equal amount for the purpose of making cphase gates and have made good use of that

We've been detuning the qubits from their center frequency an equal amount for the purpose of making cphase gates and have made good use of that

This may be true of current experiments, but it seems like an artificial restriction given that the point of this gate is to give arbitrary control over the detuning on qubit and coupler control channels. I'd suggest adding separate parameters for each qubit's detuning and you can always set them to the same value if desired in any particular experiment.

We've been detuning the qubits from their center frequency an equal amount for the purpose of making cphase gates and have made good use of that

This may be true of current experiments, but it seems like an artificial restriction given that the point of this gate is to give arbitrary control over the detuning on qubit and coupler control channels. I'd suggest adding separate parameters for each qubit's detuning and you can always set them to the same value if desired in any particular experiment.

Thanks, that is probably a good thing to go ahead and do. I've made these changes now


Remote storage onboarding section improvements

[ ] If storage of a specific type is detected we should activate the relevant tab automatically (e.g. Azure one)
[ ] Should we collapse the whole section if the storage is set already? similar to the way we do with the DVC section
[ ] Modify action. I should always see and have a way to get to the config file. Similar to how let's say Jest config page works - it has a link to the settings.json. The reason there is that we don't cover all the needed fields to manage it.

Can we combine this with the remaining items in #3867?

Yes, absolutely, I forgot that it was still open tbh.


Update updater: Update in-memory items in #update

Addresses https://github.com/solidusio/solidus/pull/1389#discussion_r74974354
So that any already-loaded line item or shipment objects will be
updated.  This is to make it more likely that code like this:
order.update!
order.line_items.each { ... }

will have the correct data without having to issue an order.reload
after the order.update!.

:+1:


feat: cleanup repository before starting up IPFS

If api file exists and it is the same as the api address defined in the config file, it is removed.
If api file exists and it is different from the one in the config file, the user will be asked if he wants to remove it or not.
Nothing os this will happen if there is a repo.lock.
closes #713.
License: MIT
Signed-off-by: Henrique Dias<EMAIL_ADDRESS>

@lidel Do we have to prompt the user if we can tell it's from an unclean shutdown? I guess it's safer at this point to draw attention to it rather than hide it.

@olizilla I think prompt with two options (ipfs repo fsck or quit) is both safe and removes surprises.
It creates an opportunity to backup $IPFS_PATH  before running ipfs repo fsck or quitting without doing anything and figuring out what went wrong with <insert super custom setup user created to own demise>  :)

I can do the dialog as @lidel mentioned, it won't require many changes. It would be nice if js-ipfs-api supported that command. I'll need to run it directly.

@olizilla done: https://github.com/ipfs/js-ipfs-http-client/issues/901

Keep in mind we are talking about cleaning up lockfiles BEFORE go-ipfs starts, so http API can't be used anyway and running CLI command directly (with env $IPFS_PATH) is the only way to do it :)

@olizilla @lidel so... the coded solution works, but I don't like it though. But it works. Could you try?

@lidel I'm aware. I've a commit I didn't push yet, waiting for more feedback so we can close this soon.

Thanks @Stebalien. We're going to keep it simple for this pass. If ipfsd-ctl tries to connect to an existing api and fails, and there is an api file present, then we'll offer the user something like:

on the assumption that users who are setting api files directly will have a clue as to what is going on, while users that just have an unclean repo state have an option to fsck it, which is a command they may not have been aware of, and it may fix it for them.


ENH: stats: Integrate library UNU.RAN in scipy.stats [GSoC 2021]

Reference issues/PRs
gh-8293 - Ratio of Uniforms method. Maybe replace it with UNU.RAN implementation.
gh-13319 - HINV method. Needs to be replaced by UNU.RAN implementation.
gh-10106 - UNU.RAN might help speed up a lot of these slow RVS methods. Need to write benchmarks to verify.
gh-11094 - Small values of c work with UNU.RAN's methods.
gh-11954 - We may be able to speed this up using UNU.RAN. Haven't tried it yet.
gh-13051 - Works with UNU.RAN methods. A test case added in tests.
What does this implement/fix?
This PR integrates methods for sampling from univariate continuous and discrete distributions from library UNU.RAN in scipy.stats submodule. The methods that I propose to add and details regarding them can be found in this excel sheet. Currently, I have added two methods, TransformedDensityRejection for continuous distributions and DiscreteAliasUrn for discrete distributions. It builds and tests pass on the PR on my fork tirthasheshpatel#6. I have also added a few tests and docs for both methods. More tests still need to be added.
TODO:

[x] Add stronger tests
[x] Add more informative docs

Changes in the UNU.RAN source tree
Deprecated files and Makefiles have been removed from the source tree. I have also removed the uniform directory which contains URNG we aren't allowed to use. .ch files have been renamed to .h header files and the source has been edited to use these .h files instead. The URNG API was edited to not use the removed default URNG and instead allow NumPy BitGenerator to become the default on import. The commits have been ordered accordingly:

Add UNU.RAN source tree with uniform directory removed and Makefiles removed.
Remove deprecated files and their declarations from unuran.h.
.ch -> .h
Small changes in URNG API to stop using default UNU.RAN URNG and allow using NumPy BitGenerator instead
Add the wrapper, tests, docs, and setup files. (This builds)

We also might not be using the String API that UNU.RAN provides. But it is ingrained in the source code and difficult to remove. Also, it can serve as a nice high-level feature if the user wants to extend by manual linking against the compiled library. Hence, it hasn't been removed.
Callbacks
To handle Python callbacks, I have written a bit of C code in unuran_callback.h. It contains thunks for Python callbacks and an error handler to capture and pass the errors occurring in UNU.RAN to Python.
Testing and Documentation
UNU.RAN is well tested so we probably won't need a lot of tests for the correctness of the algorithms. Most of the tests will be driven towards the UI and error handling. I think we are allowed to use the UNU.RAN Manual for documentation (and maybe also the Runuran Manual).
Additional information
More details about the internal design of the API can be found here. I and @chrisb83 have tried to write a license.txt file. Can you please verify it and suggest changes @rgommers?
I am also planning to do the following things in this PR or follow up PRs:

[x] Add benchmarks.
[ ] ~Add remaining methods~. (follow-up)
[ ] ~MVTDR and VNROU for multivariate distributions~. (follow-up)
[ ] A higher level function to directly create a generator for common distributions. @chrisb83
[x] Add a tutorial.

That is a lot of code to review :) I added a few observations...

Thanks for the review, @chrisb83! This is very helpful. I will push all the changes you have asked for in the next commit.

General question: would there be a way to not include the sources of UNU.RAN here? Like using a git submodule (like for Boost) and removing the files we cannot use? This could be done during setup.

I am not sure which option is better. On one hand, SciPy already has a lot of third-party C/C++ code without submodules (e.g. Highs). But on the other hand, large codebases are kept as submodules (e.g. boost). As this is a 100,000+ LOC codebase, I guess it makes sense to maintain this in a separate submodule. What do you say, @rgommers, @chrisb83, @mckib2?

But on the other hand, large codebases are kept as submodules (e.g. boost). As this is a 100,000+ LOC codebase, I guess it makes sense to maintain this in a separate submodule.

I thought you just needed a small part of it? Can it just be stripped out and vendored?

I thought you just needed a small part of it? Can it just be stripped out and vendored?

I have already removed most/all of the unwanted files. I am not sure if it can be easily be stripped more.

Hmm, then a submodule may be the way to go. We know how to do it now at least.

Thanks Tirth, this looks very good! I marked most of my initial comments as resolved, I still need to review in more detail.

Thanks Tirth, this looks very good! I marked most of my initial comments as resolved, I still need to review in more detail.

Thanks for the feedback. I will clear out the documentation and add a tutorial after which this should be ready for more thorough and detailed reviews.

One of the tests on 32-bit Ubuntu with NumPy 1.16.6 and Python 3.7 fails with the randint distribution giving a "unknown error" in UNU.RAN. I am not sure why that is happening (tried with Python 3.8 and NumPy 1.16.6 locally but it passes there). Would it be OK to put randint in fail_dist until 1.16 is dropped?

Thanks for taking a look at the tutorial, @chrisb83!

Should we create separate files for the individual methods? I fear that there will be too much information if we keep adding methods to a single page

I agree. I have separated all the methods in their own file now.

We also should emphasize that these methods often work in a black-box fashion (or say that they are universal methods). I will try to find a reference

I have added a line about this. Let me know if you want me to add a reference. I didn't do that because it is quite apparent from the name of the tutorial that these methods are universal :)

@mdhaber @WarrenWeckesser It would be very helpful if you could review the API, docs, and tests and add your opinions and thoughts on it!

Turns out the way I handle errors raises tons of memory leaks. See https://github.com/tirthasheshpatel/unuran/pull/1#issuecomment-870376023 and https://github.com/tirthasheshpatel/unuran/pull/1#issuecomment-870405470. Marking this draft again until I figure those out. Sorry for all the mess!

Turns out the way I handle errors raises tons of memory leaks. See tirthasheshpatel/unuran#1 (comment) and tirthasheshpatel/unuran#1 (comment). Sorry for all the mess!

No worries, you're doing a great job. Checking your code for memory leaks is very nice, thanks for being so thorough.

I have submitted tirthasheshpatel#9 refactoring some of the code here to address the problem of memory leaks. If anyone is familiar with Cython and can spare some time, reviews are very welcome!

I just tested the speed of TDR to generate 1mn standard normal rvs and the results look very good:
TDR (this PR): 23ms
numpy default_rng: 11ms
norm in rv_continuous: 23ms
NumericalInverseHermite (Python implementation): 159ms
(times for the setup in NIH / TDR are excluded, I used the default options, e.g. I just provided the dist object defined by the following class:
class MyNorm:
    def pdf(self, x):
        return stats.norm._pdf(x)
    def dpdf(self, x):
        return -x * stats.norm._pdf(x)
    def cdf(self, x):
        return stats.norm._cdf(x)
    def ppf(self, q):
        return stats.norm._ppf(q)

)

@chrisb83 @mckib2 I have rebased the PR with master and applied the patch in tirthasheshpatel#9 with some minor changes. let's see if the tests pass with the new changes.

I am not sure why the lints keep failing. Seems like noqa and noqa: F821 aren't working. Locally, it passes without errors with the same version of pycodestyle.
scipy/stats/tests/test_sampling.py:47:16 undefined name 'foo'
scipy/stats/tests/test_sampling.py:71:16 undefined name 'foo'
scipy/stats/tests/test_sampling.py:86:16 undefined name 'foo'
scipy/stats/tests/test_sampling.py:512:20 undefined name 'foo'

Is there any other way to silent these?

@pv Do you have time to review the C and Cython code in this PR?
We need help to verify the infrastructure for error reporting so no need to learn specifics about UNU.RAN other than these: UNU.RAN has thread-unsafe global file streams to report errors and we can't use non-local return as it causes memory leaks. As this approach heavily uses MessageStream API, I would appreciate it if you could take a look at this and suggest if we should be wary of something or if there is some other approach we could use.
More discussions on tirthasheshpatel/scipy#9 and tirthasheshpatel/unuran#1.

Probably raise lambda x: foo up to its own def function so you can put the # noqa right next to the foo.
def raises_NameError(x):
    foo  # noqa

Probably raise lambda x: foo up to its own def function so you can put the # noqa right next to the foo.

Hi @rkern. Thanks for replying. I tried this but it still fails.

Apparently the pycodestyle diff and exclude options don't mesh well together.
I previously managed to fix similar issue being excluding the files from the diff altogether: https://github.com/numpy/numpy/commit/e377d071ea502f396a7da299633bad74922c04eb.

Apparently the pycodestyle diff and exclude options don't mesh well together.
I previously managed to fix similar issue being excluding the files from the diff altogether: numpy/numpy@e377d07.

This sounds useful, thanks! I have pushed a similar commit here. Let's see if this works.

In general, maybe we could have a general section talking about sampling: QMC, UNU.RAN, NumericalInverseHermite and normal inversion when supported. Thus sampling.rst would point to the relevant pages.

Should we do that here, though? I think that's a good idea for a follow-up. For now, I will emphasize that the documentation focuses more on UNU.RAN as you suggest.

Another general question. I am wondering why we went for QMCEngine.random although here we go for rvs.

I wanted to be more consistent with the distributions API. Do you think that random is a more appropriate name? I am open to change it to that if there is a consensus to go that way.

Thanks for the reviews, @tupui! I will try to address all of these by the end of this week.

Should we do that here, though? I think that's a good idea for a follow-up. For now, I will emphasize that the documentation focuses more on UNU.RAN as you suggest.

In a follow up it's better. We should just keep this in mind to have an easier task afterwards.

I wanted to be more consistent with the distributions API. Do you think that random is a more appropriate name? I am open to change it to that if there is a consensus to go that way.

I don't know here, we need more discussion from everyone. I personally was never a fan of rvs from the distributions. As NumPy and the standard library now propose random I think we could discuss the possibility to use this instead here (would mean less depreciation work for later if we do change it in general).

I don't know here, we need more discussion from everyone. I personally was never a fan of rvs from the distributions. As NumPy and the standard library now propose random I think we could discuss the possibility to use this instead here (would mean less depreciation work for later if we do change it in general).

hm, i am fine with both names. I think NumericalInverseHermite already uses rvs, so that might mean more work to change it.

LGTM for me too as a first version provided my last comments are addressed.

@tupui thanks for your feedback! Could you mark all conversations as resolved if no follow-up is required please? Just to get a clear picture what is still open. Thanks!

LGTM for me too as a first version provided my last comments are addressed.

@tupui thanks for your feedback! Could you mark all conversations as resolved if no follow-up is required please? Just to get a clear picture what is still open. Thanks!

I think I cleaned my conversations. It should no mostly be follow up, seed, plot and 2 questions. Apart from the seed in examples, nothing blocking on my side as I approved.

@mckib2 I have added support for pickling UNU.RAN generators in the last commit. Can you please take a look at that whenever you have got some time?

@mckib2 I have added support for pickling UNU.RAN generators in the last commit. Can you please take a look at that whenever you have got some time?

Yes, I will have some time to look this evening

Pulled, built, and played around with the pickling and it seems to work as advertised.  I traced through the code and didn't find anything modifying data members in a non-repeatable fashion, so as long as this is always the case, then I think this a good solution

I have marked all my comments as resolved. Thanks Tirth!
@mdhaber I think most of your comments were taken into account, too. if you have time, could you take a look if you can also resolve the comments. Thanks

Thanks for all the reviews, @mdhaber! I have tried to address all the remaining ones now. If you want, feel free to look at the tests and tutorials and add your suggestions on them too!

I hope everyone is ok with the latest change that re-introduces the name random_state, at least I understood that it was the best compromise we could find. I think all other comments have been addressed and I would like to merge the PR tomorrow to continue with the follow-up work. All tests pass.
Thanks a lot for all the valuable feedback!

Looks like pv is still showing up for DiscreteAliasUrn. Maybe take another pass comparing the signatures against the more detailed documentation; check the position of the * (where keyword-only) args begin.

All valid points @mdhaber! I have tried to address them. Let me know if I missed anything. Thanks!

Tirth and I did another review of the documentation / tutorials and the remaining points should have been addressed. The test failure is unrelated.
I will merge (squash) this a bit later today after I have written a brief summary of the PR for the commit message.

Finally merged... This is a great addition to SciPy! Thanks a lot, Tirth, for your hard work on this! And great to see that so many developers supported the project.

Thanks to all the reviewers and especially my mentors @chrisb83 and @mckib2 for helping throughout this GSoC project! I am very happy to have this merged! Will start working on the follow-ups right away.

I just noticed this needs an entry to the release notes. I will add it by tomorrow.

Great work @tirthasheshpatel 🎉 !
Can you also follow up on the issues you linked in the description?
Also seems like it broke gitpod's deployment with UNU.RAN module not initialized: https://github.com/scipy/scipy/runs/3356195586

Also seems like it broke gitpod's deployment with UNU.RAN module not initialized: https://github.com/scipy/scipy/runs/3356195586

Odd. I have added unuran to .gitmodules but it seems like gitpod just clones boost.
#11 [build 4/6] RUN git submodule update --init --depth=1 -- scipy/_lib/boost

@rgommers Any idea how to resolve this? Looking into .gitpod.yml it seems it runs git submodule update --init which should also clone scipy/unuran:

I think you found the issue @tirthasheshpatel. It's coming from the file tools/docker_dev/gitpod.Dockerfile. It is only looking for boost and not UNU.RAN.

I let you do it or you want me to?

I let you do it or you want me to?

I will submit a PR.


OIDC logout documentation should be updated for tenant flow

[1] Should contain following details.
If SignJWTWithSPKey property is set to true in identity.xml, JWT will be signed with the application tenant key.
If the property is set to false, tenant would be decided by the subject of the id token. subject would not contain tenant domain by default. Therefore need to enable, Use tenant domain in local subject identifier in Service Provider configuration.
[1] https://docs.wso2.com/display/IS570/OpenID+Connect+Logout+URL+Redirection

Fixed.
https://docs.wso2.com/display/IS570/OpenID+Connect+Logout+URL+Redirection


Improve Desktop connection experience and UI

Consider:

how states (connected, disconnected, revoked) are articulated
how revoking is done across states and tabs/browsers
how users use it and figure out their priorities

We added Revoke button to mobile side. When the user Revokes during a "disconnected state" the desktop version is not aware its access was revoked and behaves as if it has not been. This should be adjusted as part of the improvements above.


ListBoxItem selectable

Can I make a specific ListBoxItem not selectable?
In WPF, it seemed to help to set Focusable to false - it did not help
And the IsEnable item blocks the all element in ListBoxItem .
It might be worth adding a property for this

It's kind of expected to have SelectionMode=None, but in case of Avalonia it's problematic, because our SelectionMode is flags, where "0x0" value is "Single" and wasn't reserved for "None".
WPF has same behavior though:
https://docs.microsoft.com/en-us/dotnet/api/system.windows.controls.selectionmode?view=net-5.0
Unlike UWP:
https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewselectionmode?view=winrt-19041

It's kind of expected to have SelectionMode=None, but in case of Avalonia it's problematic, because our SelectionMode is flags, where "0x0" value is "Single" and wasn't reserved for "None".
WPF has same behavior though:
https://docs.microsoft.com/en-us/dotnet/api/system.windows.controls.selectionmode?view=net-5.0
Unlike UWP:
https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.listviewselectionmode?view=winrt-19041

@RomanSoloweow although you can use ScrollViewer+ItemsControl instead.

@RomanSoloweow although you can use ScrollViewer+ItemsControl instead.

I need to make not selectable a specific ListBoxItem , not the whole ListBox

I need to make not selectable a specific ListBoxItem , not the whole ListBox

Try to set IsHitTestVisible and Focusable to false

Try to set IsHitTestVisible and Focusable to false

I set IsHitTestVisible and Focusable to false but it doesn't work. ListBoxItem is still selectable

I set IsHitTestVisible and Focusable to false but it doesn't work. ListBoxItem is still selectable

@RomanSoloweow it works for me with simple style:
<Style Selector="ListBox ListBoxItem">
    <Setter Property="IsHitTestVisible" Value="False" />
    <Setter Property="Focusable" Value="False" />
</Style>

But it also disables interaction with item content, so probably it doesn't suits your requirements.

@RomanSoloweow it works for me with simple style:
<Style Selector="ListBox ListBoxItem">
    <Setter Property="IsHitTestVisible" Value="False" />
    <Setter Property="Focusable" Value="False" />
</Style>

But it also disables interaction with item content, so probably it doesn't suits your requirements.

I would say the easiest way (although a bit hacky) is to intercept PointerPressed event on the item.
I tried this, and it seems to work (pointer over styles are still applied, but that is easy to disable):
XAML
<ListBox>
    <ListBoxItem>A</ListBoxItem>
    <ListBoxItem>B</ListBoxItem>
    <ListBoxItem x:Name="c">C</ListBoxItem>
    <ListBoxItem>D</ListBoxItem>
</ListBox>

C#
// For example after InitializeComponent(); :

var c = this.Find<ListBoxItem>("c");
c.PointerPressed += (sender, e) => e.Handled = true;

I would say the easiest way (although a bit hacky) is to intercept PointerPressed event on the item.
I tried this, and it seems to work (pointer over styles are still applied, but that is easy to disable):
XAML
<ListBox>
    <ListBoxItem>A</ListBoxItem>
    <ListBoxItem>B</ListBoxItem>
    <ListBoxItem x:Name="c">C</ListBoxItem>
    <ListBoxItem>D</ListBoxItem>
</ListBox>

C#
// For example after InitializeComponent(); :

var c = this.Find<ListBoxItem>("c");
c.PointerPressed += (sender, e) => e.Handled = true;

@jp2masa ' solution is almost suitable, but there is a problem: we may need to make different elements unavailable for selection, depending on a certain condition. (it would be nice to be able to bind for this)
But since my Control completely overlaps the ListBoxItem, all clicks of the ListBoxItem go through my Control. After subscribing to PointerPressed on the control, set e.Handled = true and you're done.
protected virtual void OnPointerPressed(PointerPressedEventArgs e)
{
    if (this.ViewModel.Name.IsNullOrEmpty())
    {
        e.Handled = true;
    }
}

While I still don't think this is a good solution, it works.

@jp2masa ' solution is almost suitable, but there is a problem: we may need to make different elements unavailable for selection, depending on a certain condition. (it would be nice to be able to bind for this)
But since my Control completely overlaps the ListBoxItem, all clicks of the ListBoxItem go through my Control. After subscribing to PointerPressed on the control, set e.Handled = true and you're done.
protected virtual void OnPointerPressed(PointerPressedEventArgs e)
{
    if (this.ViewModel.Name.IsNullOrEmpty())
    {
        e.Handled = true;
    }
}

While I still don't think this is a good solution, it works.

There is another problem with keyboard selection, but I believe setting Focusable to false should be enough

There is another problem with keyboard selection, but I believe setting Focusable to false should be enough

To be able to bind, you would have to create an attached property, something like this (includes fix for keyboard selection as suggested by @maxkatz6):
C#
public static class BlockSelection
{
    public static readonly AttachedProperty<bool> IsSelectionBlockedProperty =
        AvaloniaProperty.RegisterAttached<ListBoxItem, bool>("IsSelectionBlocked", typeof(BlockSelection));

    static BlockSelection()
    {
        IsSelectionBlockedProperty.Changed.AddClassHandler<ListBoxItem>(IsSelectionBlockedChanged);
    }

    public static bool GetIsSelectionBlocked(ListBoxItem item) => item.GetValue(IsSelectionBlockedProperty);

    public static void SetIsSelectionBlocked(ListBoxItem item, bool value) => item.SetValue(IsSelectionBlockedProperty, value);

    private static void IsSelectionBlockedChanged(ListBoxItem item, AvaloniaPropertyChangedEventArgs e)
    {
        if (!(e.OldValue is bool oldValue) || !(e.NewValue is bool newValue) || oldValue == newValue)
        {
            return;
        }

        if (newValue == true)
        {
            item.PointerPressed += OnItemPointerPressed;
            item.SetValue(ListBoxItem.IsSelectedProperty, false, BindingPriority.LocalValue);
        }
        else
        {
            item.PointerPressed -= OnItemPointerPressed;
        }

        item.SetValue(ListBoxItem.FocusableProperty, !newValue, BindingPriority.Style);
    }

    private static void OnItemPointerPressed(object sender, PointerPressedEventArgs e) => e.Handled = true;
}

XAML
<StackPanel Spacing="8">
    <CheckBox x:Name="c" Content="Block selection" />
    <ListBox>
        <ListBoxItem>A</ListBoxItem>
        <ListBoxItem>B</ListBoxItem>
        <ListBoxItem local:BlockSelection.IsSelectionBlocked="{Binding #c.IsChecked}">C</ListBoxItem>
        <ListBoxItem>D</ListBoxItem>
    </ListBox>
</StackPanel>

To be able to bind, you would have to create an attached property, something like this (includes fix for keyboard selection as suggested by @maxkatz6):
C#
public static class BlockSelection
{
    public static readonly AttachedProperty<bool> IsSelectionBlockedProperty =
        AvaloniaProperty.RegisterAttached<ListBoxItem, bool>("IsSelectionBlocked", typeof(BlockSelection));

    static BlockSelection()
    {
        IsSelectionBlockedProperty.Changed.AddClassHandler<ListBoxItem>(IsSelectionBlockedChanged);
    }

    public static bool GetIsSelectionBlocked(ListBoxItem item) => item.GetValue(IsSelectionBlockedProperty);

    public static void SetIsSelectionBlocked(ListBoxItem item, bool value) => item.SetValue(IsSelectionBlockedProperty, value);

    private static void IsSelectionBlockedChanged(ListBoxItem item, AvaloniaPropertyChangedEventArgs e)
    {
        if (!(e.OldValue is bool oldValue) || !(e.NewValue is bool newValue) || oldValue == newValue)
        {
            return;
        }

        if (newValue == true)
        {
            item.PointerPressed += OnItemPointerPressed;
            item.SetValue(ListBoxItem.IsSelectedProperty, false, BindingPriority.LocalValue);
        }
        else
        {
            item.PointerPressed -= OnItemPointerPressed;
        }

        item.SetValue(ListBoxItem.FocusableProperty, !newValue, BindingPriority.Style);
    }

    private static void OnItemPointerPressed(object sender, PointerPressedEventArgs e) => e.Handled = true;
}

XAML
<StackPanel Spacing="8">
    <CheckBox x:Name="c" Content="Block selection" />
    <ListBox>
        <ListBoxItem>A</ListBoxItem>
        <ListBoxItem>B</ListBoxItem>
        <ListBoxItem local:BlockSelection.IsSelectionBlocked="{Binding #c.IsChecked}">C</ListBoxItem>
        <ListBoxItem>D</ListBoxItem>
    </ListBox>
</StackPanel>


Node.innerText supported since Firefox 45

[FIXED] Issue #264412 https://bugzilla.mozilla.org/show_bug.cgi?id=264412
Test with document.body.textContent

Relevant discussion on implementation status: https://github.com/whatwg/compat/issues/5#issuecomment-153297411

Went ahead and added this one manually already. Thanks!


Adding a German translation

I translated the "i-default.json" file to german. Hopefully you have any use for that.
My first pull request ever, hopefully I did all things right ^^
Greetings
Daniel

looks good to me!


Project doesn't compile when a subdirectory flag is enabled

Hi! I have been trying to implement this template for a subdirectory of mine, but unfortunately I have encountered a problem.
The project doesn't build when deploying to a subdirectory with a path prefix.
11ty] Problem writing Eleventy templates: (more in DEBUG output)
[11ty] 1. Having trouble writing to "_site/about/index.html" from "./content/pages/about.md" (via EleventyTemplateError)
[11ty] 2. Transform `imageConversion` encountered an error when transforming ./content/pages/about.md. (via EleventyTransformError)
[11ty] 3. ENOENT: no such file or directory, open '/Users/Repos/eleventy-template-bliss/assets/test/images/kitty.jpg' (via Error)
[11ty]
[11ty] Original error stack trace: Error: ENOENT: no such file or directory, open '/Users/Repos/eleventy-template-bliss/assets/test/images/kitty.jpg'
[11ty]     at Object.openSync (node:fs:581:18)
[11ty]     at readFileSync (node:fs:457:35)
[11ty]     at processImage (/Users/Repos/eleventy-template-bliss/_11ty/plugins/srcset.js:107:20)
[11ty]     at /Users/Repos/eleventy-template-bliss/_11ty/plugins/srcset.js:154:43
[11ty]     at Array.map (<anonymous>)
[11ty]     at Object.convert (/Users/Repos/eleventy-template-bliss/_11ty/plugins/srcset.js:154:32)
[11ty]     at Object.<anonymous> (/Users/Repos/eleventy-template-bliss/node_modules/@11ty/eleventy/src/BenchmarkGroup.js:32:26)
[11ty]     at Template.runTransforms (/Users/Repos/eleventy-template-bliss/node_modules/@11ty/eleventy/src/Template.js:514:30)
[11ty]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[11ty]     at async Template.renderPageEntry (/Users/Repos/eleventy-template-bliss/node_modules/@11ty/eleventy/src/Template.js:799:15)
[11ty] Benchmark    266ms  13%    69× (Configuration) "imageConversion" Transform

To test simply add a pathPrefix value to the return object in eleventy.js
For example:
  return {
    dir: {
      input: constants.CONTENT_FOLDER,
    },
    templateFormats: ['md', 'njk'],
    htmlTemplateEngine: 'njk',
    markdownTemplateEngine: 'njk',
+   pathPrefix: "/test/"
  };

It seems to be related to some of the post build process, as eleventy builds by default without this problem in an empty project.

Hi @Bullrich! Thanks for letting me know, I'll have a look at it soon.

Fixed in v2.4.1.
If you want to cherry-pick a fix to your project, copy-paste the entire contents of _11ty/plugins/srcset.js.
Let me know if you need anything else!


React UI: allow for second timestamp

In the new ui the timestamp selector is rounded to the minute.
Being able to select the second is a must.

Hi, I'll take a look at this

@juliusv @roidelapluie in the classic UI inc/dec time input threshold is 10s but in the React UI, there is a range input with predefined values which can be either switched by inc/dec buttons or to directly type into it. Regarding this, two questions appear.

Should the old behavior remain in terms of the 10s threshold? It would work the same way except if the chosen range is < 10s

Since we can type into the input shouldn't be better to remove the predefined values and to leave the user to enter whatever he wants. Of course, some validation needs to be done, something like whether it starts with number and ends with {sec, hours, day/s}

Also in the current inc/dec implementation, the time is formed by the formula
basetime + (range * 1000) / 2
which seems to not work as (at least I) expected.
https://github.com/prometheus/prometheus/blob/0a0a228db380c3d68decd720016ba568af8b4b6d/web/ui/react-app/src/TimeInput.tsx#L42-L50
The (incorrect) behavior is most noticeable when the range is in second
So removing the division is the fix but I guess there is a reason to be done this way.

@boyskila To answer your questions, I like the way it is implemented in your PR!


Android - Attachment-Unable to load protected PDF error appears when wrong password is entered

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/22565
Action Performed:

Launch New Expensify app
Go to any chat and open protected PDF attachment
Tap introduce la contraseña (Enter the password)
Disconnect network
Enter incorrect password

Expected Result:
Error message about incorrect password shows up
Actual Result:
Error message 'Hubo un error al intentar cargar el pdf' (There was an error trying to load the pdf) about unable to load PDF shows up
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.410
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/ab42cb97-af52-4742-81a3-d89782ba461a
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Same, I am unable to reproduce. What version did you try @hungvu193 ?

Thank you!

Closing until this has solid reproduction steps


manifest.json is not loading

This file not found:
<link rel="manifest" href="/manifest.json">
I can help you :wink:

This issue is close, the error is only in development and the problem is missing run the command yarn run build


Error "UNC paths are not supported.  Defaulting to Windows directory."

This is is the same error as #17 but in WSL 1, therefore I'\m opening as a new error:
anodynos@Dellino:~$ wttab
'\\wsl$\Ubuntu-22.04\home\anodynos'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
file:///home/anodynos/.asdf/installs/nodejs/16.18.0/lib/node_modules/wttab/index.js:145
    return profile.source.split(".").pop().decapitalize();
                          ^

TypeError: Cannot read properties of undefined (reading 'split')
    at getProfileCommand (file:///home/anodynos/.asdf/installs/nodejs/16.18.0/lib/node_modules/wttab/index.js:145:27)
    at file:///home/anodynos/.asdf/installs/nodejs/16.18.0/lib/node_modules/wttab/index.js:150:58
    at Array.map (<anonymous>)
    at availableProfiles (file:///home/anodynos/.asdf/installs/nodejs/16.18.0/lib/node_modules/wttab/index.js:150:33)
    at file:///home/anodynos/.asdf/installs/nodejs/16.18.0/lib/node_modules/wttab/index.js:178:33
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:526:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)

Details:

Ubuntu-22.04 on WSL 1
Windows 10 Pro 22H2 OS Build 19045.2673

I've tried the main version that isn't published, and it works, although I'm still getting the error (twice) on the origin terminal:
anodynos@Dellino:~/projects$ wttab --profile wsl --window --title "Foobar" ls
'\\wsl$\Ubuntu-22.04\home\anodynos\projects'
CMD.EXE was started with the above path as the current directory.
UNC paths are not supported.  Defaulting to Windows directory.
stderr: '\\wsl$\Ubuntu-22.04\home\anodynos\projects'
CMD.EXE was started with the above path as the current directory.

It seems the problem is with cmd.exe it self, and there's no solution arround: https://social.technet.microsoft.com/Forums/ie/en-US/2c44083d-86d0-450d-b24e-955cfc473872/unc-paths-are-not-supported-error-message-comes-up-is-it-ok-to-ignore?forum=ITCG
Running wt.exe -w -1  --title "Foobar" -p "Ubuntu-20.04" bash -c "cd /home/anodynos/projects && echo ls && ls\; exec bash 2>&1" works just fine, why do you need to call cmd.exe at all?


Add donation link to homepage

openstreetmap-website has a “Make a Donation” link in the lower-right corner of the map on the homepage. OpenStreetMap U.S. now provides a donation page for OpenHistoricalMap that should be linked there.
Currently, the three OHM styles have just “OHM” as attribution:
https://github.com/OpenHistoricalMap/ohm-website/blob/1ad88efdc5ebc38c0e3a0811765da16abaa84337/app/assets/javascripts/leaflet.map.js#L29
By comparison, the Standard layer has a “Make a Donation” link as part of its attribution:
https://github.com/OpenHistoricalMap/ohm-website/blob/1ad88efdc5ebc38c0e3a0811765da16abaa84337/app/assets/javascripts/leaflet.map.js#L72

This link should ideally be localized, but localization is currently broken for attribution: #565.

Looks like we need to update this JS to add variables for OHM to add the OHM donation option without overwriting the OSM option:
https://github.com/OpenHistoricalMap/ohm-website/blob/1ad88efdc5ebc38c0e3a0811765da16abaa84337/app/assets/javascripts/leaflet.map.js#L18-L24
In the process we could resolve 565 and get localization working here

This went out and is live in production.


[BACKLOG-22651] As an ETL developer, I want to select files using the…

… VFS browser in the TextFileInput/Output, so that I can easily get VFS URLs

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/trans/steps/fileinput/text/TextFileInputDialog.java
  ui/src/main/java/org/pentaho/di/ui/trans/steps/textfileoutput/TextFileOutputDialog.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

@ddiroma Please Sir!


Remove unnecessary make call

Seems the second make call appeared due to copy-paste new flags from https://github.com/docker-library/python/issues/784

It is definitely on purpose to call make twice so that we can build just the python binary with the different LDFAGS and not apply the rpath changes to the libraries in /usr/local/lib/python*/lib-dynload/

#785
#790
#794


Update (Par)TransferMap to support data on GPU by copying it to CPU

This fixes issues when running ex34, ex34p, ex35p with device backends.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3829
@v-dobrev
@pazner
@pazner + @jandrej
8/15/23
⌛due 8/29/23
⌛due 9/5/23

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

@pazner, I see you decided to merge this directly into master. We want to have this PR also merged in next -- either directly or by merging the latest master into next.

@pazner, I see you decided to merge this directly into master. We want to have this PR also merged in next -- either directly or by merging the latest master into next.

That was by mistake, sorry. Merged this PR into next in 452141c49993933411de68ec467bfb979eb32a22.


is this for real?

I just wanted the internal fx pages to be in dark mode. A simple cocoa window with checkboxes would suffice. wtf archaic thing is this.  By default it opens in textedit with some garbled text. I don't know what I'm supposed to do with it. Thanks.

I feel like I have to learn css programming.

There's no need to learn any css to install ShadowFox.

A simple cocoa window with checkboxes would suffice

This installer provides a cross platform solution with exactly what you are asking for (window with checkboxes).

 By default it opens in textedit with some garbled text. I don't know what I'm supposed to do with it.

Please read the README.md file.

wtf archaic thing is this..

In the future, please be respectful to the individuals who are contributing to the open-source community and spending their own time creating things others, like yourself, can use.

I didn't realize I had to type shadowfox in the terminal... sorry, brain fart I guess but the instructions could be clearer.

From the readme:

On MacOS, you can install using Homebrew via brew install srkomodo/tap/shadowfox-updater and then running the program with shadowfox

yes, I got that... it didn't click in my head initially that running meant typing it in terminal. I'm not used to that. I own a mac afterrall. Anyways, it worked. It's unbelievable.  No flickering when I open fx for the first time either. Thanks.

Also, do you have any idea about how other issues like when I use .tabbrowser-tab:not([pinned]) {max-width: 325px !important;} the tabs get buggy when I close and reopen new ones. I have a high rez display and need wider tabs, can't find any solution to this anywhere. Thanks again.

I'm just going to close this issue, given that the issues discussed in here at this point belong to the main shadowfox repository and not the shadowfox-updater repo


Unable to use KTAP Agent Memory Metrics with AWS Compute Optimizer

For AWS Compute Optimizer optimizer to be able to evaluate the Available MBytes metric it must be published to CWAgent namespace and the InstanceId dimension.  I tried to configure the KTAP agent config to only publish to the InstanceId dimension but it always does the the InstanceId & Category dimension.
https://docs.aws.amazon.com/compute-optimizer/latest/ug/metrics.html?icmpid=docs_co_help_panel#cw-agent
Here is my KTAP agent config:
{
  "Sources": [
    {
      "Categories": [
        {
          "Counters": [
            {
              "Unit": "Megabytes",
              "Counter": "Available MBytes"
            }
          ],
          "Category": "Memory"
        }
      ],
      "Id": "PerformanceCounter",
      "SourceType": "WindowsPerformanceCounterSource"
    }
  ],
  "Sinks": [
    {
      "Id": "CloudWatchSink",
      "Interval": "60",
      "Namespace": "CWAgent",
      "SinkType": "CloudWatch",
      "Dimensions": "InstanceId={instance_id}",
      "Region": "US-WEST-2"
    }
  ],
  "Pipes": [
    {
      "SourceRef": "PerformanceCounter",
      "Id": "PerformanceCounterToCloudWatch",
      "SinkRef": "CloudWatchSink"
    }
  ],
  "SelfUpdate": 0
}

Looking into this further, it look to be the agent is publishing the Category name to the dimension.  Is there a way to prevent this?

@girvenj ,
The Id and Category dimensions are added by default and there's currently no way to remove them
https://github.com/awslabs/kinesis-agent-windows/blob/ac0ee50c9118a2b02f7c790ea9f8867d57e53729/Amazon.KinesisTap.AWS/CloudWatchSink.cs#L490
The reason is that metrics with different dimensions are technically different metrics so we don't want to merge them together when we send them to CloudWatch. The Id maps to the perfmon's Instance, while the category maps to perfmon Category or Counter Set. If we remove them then 2 different metrics coming from 2 different counter instances might get merged together by CloudWatch.
We have not considered the AWS Compute Optimizer use case. We'll take this as a feature request.

It is only needed for the memory metrics.  Maybe just allow an exclusion for that metric category. Compute Optimizer does not seem to care about any other metrics uploaded from the agent.


[Bug] ioutil is deprecated

Describe the Bug
ioutil is deprecated. Replace all occurrences of ioutil with io or os w.r.t. the functions in use.
To Reproduce
NA
Additional Context
NA
Ownership of Contribution
If the triage is approved,

[ ] I wish to submit the PR myself.
[x] I wish to submit the PR. But if someone is willing to do it, go ahead.
[ ] I don't know how to fix this or make these changes. I wish others to pick this up for me.

@assign


generic casting between Dist* and Vector{DistBool}

For some of this functionality, as well as a generic implementation of ifelse it seems like it would be useful to have a generic way of casting from/to Dist* to Vector{DistBool} so that other operations can just work in the space of Vector{DistBool}?
Originally posted by @guyvdbroeck in https://github.com/Juice-jl/Dice.jl/issues/13#issuecomment-1113453359

@guyvdbroeck Were you thinking of an interface like this?
# Gathers all DistBools of dist and records structure
# Structure contains the type and a representation of "how to put it back together"
# For DistString, it could include how many bools correspond to chars vs length
function deflate(dist::Dist)
    # ...
    return distbools, structure
end

# Recreates the original dist; inflate(deflate(dist)) = dist
function inflate(distbools::Vector{DistBool}, structure)
    # ...
    return dist
end

# Restructures actual bools into what they represent
# inflate([false, true, true], {type:DistInt}) = 6
function inflate_instance(bools::Vector{Boolean}, structure)
    # ...
    return dist
end

Then generic implementations of ifelse and infer could look like:
function ifelse(cond::DistBool, then::Dist, elze::Dist)
    then_bools, then_structure = deflate(then)
    elze_bools, elze_structure = deflate(elze)
    @assert then_structure == elze_structure
    return inflate(ifelse(cond, then_bools, elze_bools), then_structure)
end

function infer(dist::Dist)
    distbools, structure = deflate(dist)
    return Dict([
        (inflate_instance(bools, structure), p)
        for bools, p in infer_on_distbool_vector(distbools)
    ])
end

For both ifelse and infer, I think it's more useful to work with the Dist directly, rather than a Vector{DistBool}, even if it requires a some more function overloading:

If we want to allow ifelse between Dists with different numbers of bools, then we might need to enforce some notion of "right padding with 0s does not change the semantics".
Writing customized infers for each Dist type can save some computation (and shouldn't be too much work using group_infer). For example, DistString infers on length first then doesn't care about characters that extend beyond it.

Yeah that looks like what I had in mind.
Image a user who wants to add their own Dist* data type. It would be great if all they needed to provide is inflate and deflate. Of course if useful for performance one can still specialize other methods.


[BUG Build] Recent merges broke backend build

I merged some minor versions bump as well as users features but backend doesnt seem to build anymore 😢  !
I also have got issues with npm on node:lts-alpine with IPV6 resolution (https://github.com/npm/cli/issues/4163). This might be solved with https://unix.stackexchange.com/a/655051 (force the use of node on debian, ie node:latest and force IPV4 resolution).

Can you add logs there please ? I think I already faced this issue but not sure it is the same issue

TL;DR my fault : https://github.com/npm/cli/issues/4163


Error after Google Services authorization.

After success google services authorization Picker is closed with such error:
'Error: FileStack didFinishPickingMediaCallback', { [Error: 0] framesToPop: 1, code: 'E_NO_IMAGE_DATA_FOUND' }

And currently every time when I select google services (drive, photos, gmail) Picker is Immediately close and above error occurs.
Not sure what is the reason.
Maybe your google services integration instruction is not full ? Maybe I missed something in configuration that is important but is not written in your docs.
Please check if u have the same issue, and let me know.

It sounds like you have possibly not setup Google API access. Have you followed the instructions in the README under "Enabling APIs for Google Services"?


Nature fang combat style

Is it intended that nature fang archetype don't qualify for combat styles feats on 6 and 10 levels?

I don't think it's intended, I believe it's a bug due to the Combat Style Feat prerequisites not being extended in the Nature Fang archetype file (https://github.com/Vek17/TabletopTweaks-Base/blob/master/TabletopTweaks-Base/NewContent/Archetypes/NatureFang.cs), we can see in the file that uncanny dodge has its prerequisites modified to accomodate Nature Fang but the Combat Style feat doesn't.
UncannyDodgeTalent.AddPrerequisite<PrerequisiteArchetypeLevel>(p => {
    p.m_CharacterClass = DruidClass.ToReference<BlueprintCharacterClassReference>();
    p.m_Archetype = NatureFangArcehtype.ToReference<BlueprintArchetypeReference>();
    p.Level = 4;
    p.Group = Prerequisite.GroupType.Any;
});
ImprovedUncannyDodgeTalent.AddPrerequisite<PrerequisiteArchetypeLevel>(p => {
    p.m_CharacterClass = DruidClass.ToReference<BlueprintCharacterClassReference>();
    p.m_Archetype = NatureFangArcehtype.ToReference<BlueprintArchetypeReference>();
    p.Level = 12;
    p.Group = Prerequisite.GroupType.Any;
});

In game we can see both of those talents have "Nature Fang" as an optional prerequisites but the combat style feat don't.


[Feature]:  add node's memory stats on client's mem_stat.log

Is your feature request related to a problem? Please describe.
In some scenarios, the client is killed, and dmesg cannot find useful information. I want to check the memory status of the node at that time to see if it was killed by the system due to oom.
Describe the solution you'd like
add client node's mem stat info in client/mem_stat.log to help locate problem. eg:
              total        used        free      shared  buff/cache   available
Mem:           8.0G        1.6G        1.2G          0B        5.2G        6.4G

it's useful for this problem

I am interested in this issue.


Allow other users to read the /opt/teku dir when using docker

PR Description
The problem is that if we try to run the teku container with any other user that has a differen uid than 1000, we won't be able to execute the teku binary due to the permissions of the working dir ( /opt/teku ) being too strict 0770. I'm changing the permissions to 0775 so that other users can also read the directory and execute the teku binary.
Example on how this fails currently with other users than 1000
$ docker pull consensys/teku
$ docker run --rm -it --entrypoint ls --user=1000 consensys/teku
LICENSE  bin  lib  licenses  teku.autocomplete.sh
$ docker run --rm -it --entrypoint ls --user=1003 consensys/teku
ls: cannot open directory '.': Permission denied

Fixed Issue(s)

Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[ ] I thought about adding a changelog entry, and added one if I deemed necessary.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Recreated at https://github.com/ConsenSys/teku/pull/6743


indicate clearly that URL safe base64 encoding is preferred

the different base64 alphabets might be confusing

All mentions of base 64 in the specification are explicit about using the URL-safe base 64 version.
I think the issue might not be the spec itself, but implementations that don't provide base 64 encoding directly and let users handle it themselves.