feat: folding acir programs

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

protocol_circuit_witness_generation_time_in_ms (private-kernel-reset-small): 1,984 (-18%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256
5,696
1,548
710
757
778

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,476
9,476

l1_rollup_execution_gas
616,105
616,117
616,117

l2_block_processing_time_in_ms
1,290
4,808
9,570

l2_block_building_time_in_ms
46,836
185,722 (+1%)
371,267

l2_block_rollup_simulation_time_in_ms
46,666
185,095 (+1%)
370,007

l2_block_public_tx_process_time_in_ms
24,926
104,241 (+1%)
211,784

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
9,531
14,470

node_database_size_in_bytes
14,520,400
21,389,392

pxe_database_size_in_bytes
18,071
29,868

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.4
17.0
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.604
0.521
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
49.1 (+1%)
76.0
246
477 (+1%)
930
1,845
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.502 (+1%)
0.469
0.446
0.445
0.440
0.440
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
58.4
113
356
701
1,386
2,763
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.505
0.506
0.482
0.482
0.478
0.479
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
62.5

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
107

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.554

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
83,794
665,117

Transaction size based on fee payment method
| Metric |  |
| - |  |


Storing reducer with custom key

Since we have a constant const ROUTER_REDUCER_MAP_KEY = 'router' storing reducer with key 'navigator' like in example doesn't work:
const rootReducer = combineReducers({ navigator: createRouterReducer(history) })

This constant is only used in the built-in selector.
You need to use the routerSelector: <ReduxRouter history={history} routerSelector={state => state.navigator}/>

I've tried to use action creators, didn't even use selector, copied that combineReducers line with 'navigator' and have a bunch of errors from inside a bundle, not my code. Than renamed key to 'router' and everything works like a charm. Let me double check in more simple example a bit later :)


Fix dependency issues

While working on KubeVirt extension of OpenShift Console, I've found some dependency issues.

1) symptoms observed in kubevirt-web-ui-components library
$ git log -1 --format="%h %s"
bc2770f Add Templates Wizard and integration with Create Vm Wizard (#123)

$ rm -rf ./node_modules && yarn install
..
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>..

Above two warnings come from @patternfly/react-console package which has peer deps on patternfly and react-bootstrap (react-console package.json).
However:
$ cd /path/to/patternfly-react/packages/patternfly-3/react-console
$ grep -r "from 'patternfly" src # shows only imports from "patternfly-react"
$ grep -r "from 'react" src      # shows only imports from "react"

To me, it seems that patternfly and react-bootstrap shouldn't be defined as peer deps of @patternfly/react-console package. This package already has peer dep on patternfly-react, which in turn depends on patternfly and react-bootstrap via normal deps (patternfly-react package.json).
In other words, patternfly-react doesn't treat patternfly and react-bootstrap as peer deps, but as normal deps. Any package depending on patternfly-react shouldn't complicate existing peer dep requirements as it causes warnings in target applications.
Proposed fix: remove patternfly and react-bootstrap peer deps in @patternfly/react-console package.

2) symptoms observed in openshift/console target application
With KubeVirt extension PoC PR applied:
$ git log -1 --format="%h %s"
9575c7b0b KubeVirt extension PoC

$ cd frontend
$ rm -rf ./node_modules && yarn install
..
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning "patternfly-react ><EMAIL_ADDRESS>has unmet peer dependency "lodash@>= 4.0.0 < 5.0.0".
warning "patternfly-react ><EMAIL_ADDRESS>has unmet peer dependency "lodash@>= 4.0.0 < 5.0.0".
warning "patternfly-react ><EMAIL_ADDRESS>has unmet peer dependency "lodash@>= 3.0.0 < 5.0.0".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "lodash@>= 4.0.0 < 5.0.0".
..

There are two types of warnings listed above:

libraries having too "strict" peer deps:

kubevirt-web-ui-components needs<EMAIL_ADDRESS>patternfly-react-extensions needs<EMAIL_ADDRESS>

unmet lodash peer dep

openshift/console uses lodash-es instead to allow efficient webpack tree shaking

The openshift/console project currently uses React 16.6:
$ yarn why react
..
=> Found<EMAIL_ADDRESS>..

Proposed fixes:

in kubevirt-web-ui-components package, update all React related peer deps (and corresponding dev deps) to 16.x
in openshift/console project, add alias for lodash dep ("lodash": "npm:lodash-es"), see this tweet for details

Finally, there's one more issue to cover - adding reactabular-dnd dep when using kubevirt-web-ui-components in the target application.
Taking above mentioned PR and removing reactabular-dnd from its dependencies:
diff --git a/frontend/package.json b/frontend/package.json
index 8326ad314..2621aece7 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -86,7 +86,6 @@
     "react-tagsinput": "3.19.x",
     "react-transition-group": "2.3.x",
     "react-virtualized": "9.x",
-    "reactabular-dnd": "8.x",
     "redux": "3.x",
     "redux-form": "7.x",
     "redux-thunk": "2.x",

$ cd frontend
$ rm -rf ./node_modules && yarn install
..

$ yarn dev # do a development build
..
ERROR in ./node_modules/kubevirt-web-ui-components/dist/js/components/Table/EditableDraggableTable.js
Module not found: Error: Can't resolve 'reactabular-dnd' in '/home/vszocs/go/src/github.com/openshift/console/frontend/node_modules/kubevirt-web-ui-components/dist/js/components/Table'

Above error indicates a problem with kubevirt-web-ui-components library - it relies on reactabular-dnd package but doesn't explicitly declare it as its dependency. Just adding reactabular-dnd to the library's peer deps would work, but then, openshift/console would still need to add it explicitly alongside kubevirt-web-ui-components, which is something we want to avoid (see Sam's comment).
In this case, I'd suggest to make reactabular-dnd a normal dep of kubevirt-web-ui-components package. This is similar to patternfly-react defining patternfly, react-bootstrap and reactabular-table (:exclamation:) as normal deps, not peer deps.
In general, peer deps should only be used if there's a compelling reason to use a different (but compatible) version of the given package in the target application, like react or react-dom. Having too many peer deps (coming from multiple packages) can snowball into tons of warnings.
Proposed fixes:

in kubevirt-web-ui-components package:

add reactabular-dnd to normal deps (not a peer dep)
add @patternfly/react-console to normal deps (not a peer dep)

@jelkosz this issue covers Sam's comment on KubeVirt extension PoC
@mareklibra @priley86 @rawagner please let me know if proposed fixes make sense to you, if so - I'll open PRs on the relevant projects.

@vojtechszocs sounds good to me.

@vojtechszocs , makes sense to me, thanks for the detailed analysis.

@vojtechszocs wow, great analysis! Thank you, sounds good.

Thanks guys! I'll follow-up and open PRs on patternfly-react and kubevirt-web-ui-components projects.

PRs that cover proposed fixes:

patternfly-react PR 1021
kubevirt-web-ui-components PR 139

All related PRs got merged, closing.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: arijitd2 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Width of tabIndicator is not working.

💬 Question
My question is that the indicatorStyle supplied to TabView component is not properly working.
As I passed width to indicatorStyle, it's not changing the width of indicator no matter the value is a number or a percentage. Other style properties are working fine (height, backgroundColor, borderRadius, etc.).
Screenshots:

I know the percentage is too small, but I just wanna demonstrate its not changing the width.
Expected something like this:

Runnable code
If something wrong with my styling please let me know.
Thanks a lot!
UI Kitten and Eva version

Package
Version

@eva-design/eva
1.2.0

@ui-kitten/components
5.0.0

Seems to be the same issue as #1237

I'm having the same problem still. @shawnzheng99 did you end up finding a solution?


Refactor of consul service checks

This refactor has the following goals:

start the process of categorizing test
types by putting service checks into
their own directory.
simplify service checks to do either
process,tcp, or http validation.

It does the following:

ensures that service checks do not rely
on *-manage calls (this ensures that service
checks do not wind up having external dependencies).
These checks are modified to instead use process
checks.
ensures all changed service checks still exist as validation
checks.
moves service checks to their own directory
sets 0 as default port for consul services
adds explicit http service checks for glance

WIP

please test this

please test this

please test this

please test this

since I added that additional commit, I'm going to manually kill the job you started...

please test this

please test this

this was also in a passing state when I checked on it. I will re-run and monitor more closely.

please test this

please test this

please test this

please test this

this just keeps on getting spurious failures. The last one was the error where the vrouter never responds and prints lots of "....." to stdout. Did we ever root cause that?

please test this


RISC-V builds for Linux

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
This would enable Homebrew to host Linux builds for RISC-V systems in addition to x86_64 ones. If Homebrew needs real hardware to help build these packages, I have a way of providing it.
What is the motivation for the feature?
RISC-V is exploding onto the scene and growing in popularity very fast, and a lot of us using RISC-V Linux are suffering from outdated/missing packages, which Homebrew often doesn't suffer from. So, offering RISC-V support would be a huge boon both right now and in the future when more people are actually using it for their PCs.
How will the feature be relevant to at least 90% of Homebrew users?
Linux users are right now a fraction of Homebrew users, and RISC-V even more so. However, in the long term, it's certain that x86_64 and ARM are going to become legacy platforms, so adding support right now hedges Homebrew's compatibility bet.
What alternatives to the feature have been considered?
There is of course waiting until more RISC-V users exist, or adding ARM support to Homebrew right now, or using a different package manager like cargo (yuck!) instead.  Also check out https://github.com/flathub/flathub/issues/4378, but Flathub is almost all GUI software

PRs to add build-from-source support may be accepted if lightweight (we support x86_64, arm, arm64, and various PPC archs) but would need to come from someone who uses it and we don't have any maintainer which does.
Full support including pre-built bottles is unlikely for the foreseeable future given the lack of CI.

adding ARM support to Homebrew right now

This is significantly more likely, and is something we'll evaluate in early 2025 when GitHub Actions support it.

Full support including pre-built bottles is unlikely for the foreseeable future given the lack of CI.

I may be able to provide hardware just for this (like with Flathub), would that help?

Probably not as there would be security questions (we can't just trust random machines), maintainability questions (who will port every Homebrew/core package to work and continue to maintain that going forward) and as well as long-term sustainability questions (we'd be relying on one person for CI, and the known user base is right now only you).
In any case, the first step of any support would be making it work when building packages from source (no bottles). This is how Linuxbrew started, it is how the PowerPC fork started, and is how the ARM support for Linux is currently going. If this is non-trivial, it can start in a fork but if it only requires tweaking a few lines then I'm happy to review a pull request adding support for it.


Write cd-info identification to batch manifest

This way we can check if value is consistent with carrierType (which is set manually). Actual check can be done in omSipCreator, see: https://github.com/KBNLresearch/omSipCreator/issues/19

Done (audio/data flags only; don't think we need more): https://github.com/KBNLresearch/iromlab/commit/36ef8af921a5491fac09165957ba9b9ab15c877b


feat(SLP.Utils.hydrateUtxos): Added hydrateUtxos to match new bch-api…

… endpoint

:tada: This PR is included in version 3.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Bot acts up due to TypeError

What went wrong?
Bot does something like this and goes offline until manually restarted. Happend a few times already
SystemD log after crash:
lines 1-21/21 (END)...skipping...
● dc_mus.service - discord music bot
     Loaded: loaded (/etc/systemd/system/dc_mus.service; enabled; vendor preset: enabled)
     Active: active (running) since Sun 2022-12-04 15:11:29 CET; 5h 16min ago
   Main PID: 852080 (bash)
      Tasks: 9 (limit: 1890)
        CPU: 7min 41.182s
     CGroup: /system.slice/dc_mus.service
             ├─852080 bash run.sh
             ├─852096 python run.py
             └─853866 ffmpeg -nostdin -i audio_cache/youtube-JThz8-nYYHs-Nightcore_-_Warriors.webm -f s16le -ar 48000 -ac 2 -loglevel warning -vn pipe:1

Dec 04 18:11:01 lowpower bash[852096]:   File "/mnt/btrfsMirror/discordbots/music/MusicBot/musicbot/bot.py", line 103, in __init__
Dec 04 18:11:01 lowpower bash[852096]:     self.downloader = downloader.Downloader(download_folder="audio_cache")
Dec 04 18:11:01 lowpower bash[852096]:   File "/mnt/btrfsMirror/discordbots/music/MusicBot/musicbot/downloader.py", line 46, in __init__
Dec 04 18:11:01 lowpower bash[852096]:     ytdl_format_options["outtmpl"] = os.path.join(download_folder, otmpl)
Dec 04 18:11:01 lowpower bash[852096]:   File "/usr/lib/python3.9/posixpath.py", line 90, in join
Dec 04 18:11:01 lowpower bash[852096]:     genericpath._check_arg_types('join', a, *p)
Dec 04 18:11:01 lowpower bash[852096]:   File "/usr/lib/python3.9/genericpath.py", line 152, in _check_arg_types
Dec 04 18:11:01 lowpower bash[852096]:     raise TypeError(f'{funcname}() argument must be str, bytes, or '
Dec 04 18:11:01 lowpower bash[852096]: TypeError: join() argument must be str, bytes, or os.PathLike object, not 'dict'
Dec 04 18:11:01 lowpower bash[852096]: [INFO] launcher: All done.

How do we reproduce this?
I'm not sure what exactly causes it, happens randomly while playback, but i think the current playing video was ID JThz8-nYYHs
Am not sure because my friends experienced this
Which version of the bot are you using?
release-151221
Which operating system are you using?
Other
Just checking...

[X] I have confirmed that my issue has not already been reported.
[X] I am using Python 3.8 or higher.
[X] I have updated my Python dependencies.

I haven't ran into this but I'm on windows, please try updating the bot and see if the issue persist after that.

Running into this issue now as well.

I debugged the issue a bit. The otmpl variable does indeed change from this string '%(extractor)s-%(id)s-%(title)s.%(ext)s' at startup to this dict {'chapter': '%(title)s-%(section_number)03d-%(section_title)s-[%(id)s].%(ext)s', 'default': 'audio_cache/%(extractor)s-%(id)s-%(title)s.%(ext)s'} when trying to shut down.
Looked a bit further and the value of the outtmpl key in the ytdl_format_options dict seems to change from a string to a dictionary somehow


Update the Swift PM sample so that Gradle creates fewer directories in the root directory

The Swift PM sample is configured so that Gradle creates a directory in the root directory for each project. Update the sample so that Gradle creates a single directory in the root directory to contain the outputs.

This is done for build directories, but should also be done for the Xcode files.


Defining "Zowe Core" to be consistent in commercial Zowe Support Offerings

Broadcom and IBM both now have commercial support offerings for Zowe. For users to have clarity and avoid vendor lock-in, there should be consistency in what is called "Zowe Core" in these support offerings.
We need to define what is part of "Zowe Core" with respect to commercial support offerings.

@solsu01 correct me if I'm wrong but wasn't Broadcom's initial announcement about supporting what then was "all" of zowe? IBM's support I think is defined by what you can download from them?
So, at the moment it seems the de-facto "core" is somewhere between what you can download on zowe.org, and what you can download from IBM.
To me, this means that it excludes the repositories that we have but do not package, or package elsewhere such as npm.
What do you think?

Just something I mentioned on the ZLC call: if we go repo-by-repo, can we identify who strongly "owns"/knows the code in it? If we don't, is it "core"?

IBM distribution is determined by a few factors:

what we make available for download,
what we anticipate can be supported in partnership with the open community
what can be supported in partnership with others (3rd parties, IBM product teams, etc.)  and
what "front line" support resources we have to assist customers.
The IBM Z Distribution for Zowe is on a continuous delivery model and therefore will likely expand as the factors above expand/change.

Scope initially likely to be defined to be

All Zowe z/OS components including: ZSS, API ML, App Framework with "out of the box" apps (3270, VT, JES, USS, ...)
Zowe "core" CLI meaning the commands using z/OSMF plus the Secure Credential Store plug in.
Zowe Explorer

IBM will continue to advocate for Zowe integrations by products teams in the open community. Support will be through the open community until such time as they are covered under IBM Support.
In addition to "defined code" there needs to be a way for that core set of binaries to be "trusted" (my word) by set of Support Providers - support vendors need a way to know each other distributions of Zowe core are unaltered.

Would this be linked to https://github.com/zowe/zlc/issues/182?

John - short answer is yes this is linked (there is also work going on to provide a way to test a given distribution of Zowe is "genuine" that is also related (that is in a different repo).
We are beginning to try to use Zenhub to link and organize issues into Epics....there is a free zenhub plug in I am beginning to try to use (and will try to link cross repos).

The TSC will work the "what is core" question in this issue https://app.zenhub.com/workspaces/community-5c93e02fa70b456d35b8f0ed/issues/zowe/community/1207 ZLC will provide opinion for TSC consideration - I will summarize the ZLC discussion today in this issue. Core definition is part of the Support Conformance criteria and included in LTS scope description.


[BUG] spacy_ann create_index failed

Describe the bug
I tried to run Tutorial from here, but
spacy_ann create_index en_core_web_md kb_dir/ models_dir/ failed with the following error.   File "/opt/conda/lib/python3.7/site-packages/spacy_ann/candidate_generator.py", line 336, in <lambda>     p.with_suffix(".json"), self.short_aliases   File "/opt/conda/lib/python3.7/site-packages/srsly/_json_api.py", line 74, in write_json     json_data = json_dumps(data, indent=indent)   File "/opt/conda/lib/python3.7/site-packages/srsly/_json_api.py", line 26, in json_dumps     result = ujson.dumps(data, indent=indent, escape_forward_slashes=False) TypeError: {'NLP', 'OS', 'ML'} is not JSON serializable
Tracing the code, it passes a list toe json_dumps()
To Reproduce
Follow steps in Tutorial from here,

pip install spacy-ann-linker
spacy_ann example_data ./kb_dir
spacy download en_core_web_md
spacy_ann create_index en_core_web_md kb_dir/ models_dir/ failed with the following error.

It outputs:
================================= Load Model =================================
⠙ Loading model en_core_web_md✔ Done.
============================ Apply EntityEncoder ============================
⠙ Applying EntityEncoder to descriptions✔ Finished, embeddings created
✔ Done adding entities and aliases to kb
============================== Create ANN Index ==============================
0%   10   20   30   40   50   60   70   80   90   100%
|----|----|----|----|----|----|----|----|----|----|

Traceback (most recent call last):
File "/opt/conda/bin/spacy_ann", line 8, in
sys.exit(main())
File "/opt/conda/lib/python3.7/site-packages/spacy_ann/cli/init.py", line 24, in main
typer.run(commands[command])
File "/opt/conda/lib/python3.7/site-packages/typer/main.py", line 855, in run
app()
File "/opt/conda/lib/python3.7/site-packages/typer/main.py", line 214, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 829, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.7/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/opt/conda/lib/python3.7/site-packages/typer/main.py", line 497, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.7/site-packages/spacy_ann/cli/create_index.py", line 113, in create_index
nlp.to_disk(output_dir)
File "/opt/conda/lib/python3.7/site-packages/spacy/language.py", line 927, in to_disk
util.to_disk(path, serializers, exclude)
File "/opt/conda/lib/python3.7/site-packages/spacy/util.py", line 681, in to_disk
writer(path / key)
File "/opt/conda/lib/python3.7/site-packages/spacy/language.py", line 925, in
serializers[name] = lambda p, proc=proc: proc.to_disk(p, exclude=["vocab"])
File "/opt/conda/lib/python3.7/site-packages/spacy_ann/ann_linker.py", line 199, in to_disk
self.cg.to_disk(path)
File "/opt/conda/lib/python3.7/site-packages/spacy_ann/candidate_generator.py", line 347, in to_disk
to_disk(path, serializers, {})
File "/opt/conda/lib/python3.7/site-packages/spacy/util.py", line 681, in to_disk
writer(path / key)
File "/opt/conda/lib/python3.7/site-packages/spacy_ann/candidate_generator.py", line 336, in
p.with_suffix(".json"), self.short_aliases
File "/opt/conda/lib/python3.7/site-packages/srsly/_json_api.py", line 74, in write_json
json_data = json_dumps(data, indent=indent)
File "/opt/conda/lib/python3.7/site-packages/srsly/_json_api.py", line 26, in json_dumps
result = ujson.dumps(data, indent=indent, escape_forward_slashes=False)
TypeError: {'NLP', 'OS', 'ML'} is not JSON serializable

But I expected it to output:
...
Fitting ann index took xxx seconds

Environment

OS: [e.g. Linux / Windows / macOS]
Amazon Linux AMI 2018.03

Python version

Python 3.7.10
Additional context
spacy-ann-linker==0.3.3
spacy==2.3.7
nmslib==2.0.5
scikit-learn==0.21.3
srsly==1.0.5

This seems to be resolvable by running pip install srsly==2.0.0 as per this comment in Issue #6


feat: add link to image forensics tools directly

Add links to image forensics tools in the html_report:

[include] fotoforensics.com works from url: https://fotoforensics.com/?url=https://www.iol.pt/multimedia/oratvi/multimedia/imagem/id/62a37a1f0cf2ea4f0a4f34ff/1024.jpg
[exclude] 29a.ch/photo-forensics does not seem to work from url: https://29a.ch/photo-forensics/
[exclude] https://www.imageforensic.org/ only works via a post request with the file not the url

other options that accept URLs are welcome!

https://mever.iti.gr/forensics/ can be included with ?image=URL


Reorder default login ID keys

The order of login ID keys are now important because the first one is the default one in Auth UI.
The order should be email, phone and username.
So in default settings, the user will sign up with email instead of a username.

@carmenlau @kiootic Any objections?

LGTM:)

I agree!


malware Domain list seems to be down

Hi Team,
it seems like Malware Domain List is down, is there some kind of technical maintenance?

It's still down.

down and.. out-dated?
Are they still updating the list?
Last timestamp (afair) was Feb 2018?

I think you're right Laicurè @Laicure.

Relates to #1044

they web is up and running again


Checkout preferences not launching

dispatch_async(dispatch_get_main_queue(), ^{
        [SumupSDK presentCheckoutPreferencesFromViewController: controller
                                                      animated:NO
                                                    completion:^(BOOL success, NSError *error) {
            NSLog(@"Error", [error localizedDescription]);
        }];
    });

Does not work and neither shows a modal. However, the presentLoginFromViewController with the same arguments does work as expected..

Hello @MarvinOS,
just to be sure: is the user logged in when you call presentCheckoutPreferencesFromViewController?  Is anything printed to the console log?
Kind regards,
Felix

Hi Felix,
Yes, user is logged in, and nothing is printed to the console. However, when calling the same window again the completion block is executed.

Have you checked that the controller is not nil when the block is executed on the main thread?


[Bug] Can't get build for iOS and android build doesn't work

[REQUIRED] Please fill in the following fields:

Unity editor version: 2020.3.20f1
Firebase Unity SDK version: 8.9.0
Source you installed the SDK: unitypackage (.unitypackage or Unity Package Manager)
Problematic Firebase Component: Analytics, Crashlytics, Config, Installation (Auth, Database, etc.)
Other Firebase Components in use: _____ (Auth, Database, etc.)
Additional SDKs you are using: Admob, Appsflyer (Facebook, AdMob, etc.)
Platform you are using the Unity editor on: Mac (Mac, Windows, or Linux)
Platform you are targeting: iOS, Android (iOS, Android, and/or desktop)
Scripting Runtime: IL2CPP (Mono, and/or IL2CPP)

[REQUIRED] Please describe the issue here:
We are updating from 8.8.0 to 8.9.0
We use packages Analytics, Config, Crashlitics, Installation
After I import all these packages into new project - I saw this compile error

I tried to ignore it and try to build for iOS. But I couldn't do it, because of this errors

After this I tried to build for Android, and I could do it. But when I stated an app - it says error connecting to the server. But Wifi is working and also the previous version(8.8.0) works fine

If you saw Unable to resolve reference 'Google.VersionHandlerImpl', that means the entire EDM4U is not workin properly in your project.  And EDM4U is actually the main component to add iOS and Android dependencies used by Firebase.
However, Unable to resolve reference 'Google.VersionHandlerImpl' is pretty common when you upgrade Firebase, which includes newer version of EDM4U, since those libraries will be disabled for a couple of frames before being re-enable again.
Let's see if EDM4U is really not working.

Please take a look of menu item Assets > External Dependency Manager and see if this menu item exist.
Click on Assets > External Dependency Manager > Version Handler > Settings.  See if you can find the version on the top.  It should look like Version Handler (version x.x.x).  Firebase 8.9.0 includes EDM4U 1.2.170. Therefore, you should see 1.2.170 here.
See if you can find the following files under Assets folderAssets/ExternalDependencyManager/Editor/1.2.170/Google.IOSResolver.dll
Assets/ExternalDependencyManager/Editor/1.2.170/Google.JarResolver.dll
Assets/ExternalDependencyManager/Editor/1.2.170/Google.VersionHandlerImpl.dll

If so, click on it and see they are enabled for Editor platform.
If either one of the steps above is not true, it is possible that the EDM4U in your project is messed up.
A quick way to resolve this is to remove Assets/ExternalDependencyManager folder and reinstall it.
You can download the latest version here.
Let me know if this helps.

hi there, is there any solution for iOS?

?

@equizo
Try the latest version, it works well for me


Implement TCP Extensions for High Performance [RFC 7323]

RFC 7323
This includes the following options:

Window Scale Option
Timestamp Option

And a lot of other stuff... It's dependent on timers and clock-functionality (#174) (I think..)

Window scaling added in 40777f1.

Timestamp together with PAWS and RTT measurement added with #1207


Fix indent

This change applies a tabulation for indentation everywhere.

Thanks @dereckson , just saw the earlier too :smile:

No idea why Travis fails all the time. Merged. Thanks again :)


Finder enhancements

Adds

Shutdown button  - fixes #17
SSH Port Config - fixes #20
WebIDE install checkbox - fixes #13
Changes default grunt task so changes to the node.js app don't require rebuilding during development
Adds a sanity check to deploy script to make sure it is working with a copy of the repo
Copy the latest versions of finder.sh & install.sh to /var/packages on deploy

Testing
Download the v1.1-beta release to test
Screenshot

@brennen this is dependent on your occi webide config stuff, so just let me know when you've deployed it and I'll merge and publish the release.

Cool - it's deployable in its current state but I'd like to make it better
behaved in the case of webide=no and test a couple of things before we call
it another release.
Got some social obligations to go meet just now, but I'll wrap that up this
evening.

@brennen it can wait until tomorrow. i just wanted you to know where it stands in case you tried to run it or merge it

@toddtreece let's go ahead and go with this occi 0.4.0.  It'll change some over the course of the day, but this oughta work for the WebIDE checkbox to start.

(Deployed to repo.)


inconsistent behaviour of nextInt and nextLong

Describe the bug
Methods nextInt and nextLong have inconsistent behaviour. The "max" parameter is exclusive for most of them, but inclusive for one of them.

nextInt(3): [0, 1, 2]  - exclusive
nextInt(2, 4): [2, 3, 4] - INCLUSIVE
nextLong(3): [0, 1, 2]  - exclusive
nextLong(2, 4): [2, 3]  - exclusive
nextDouble(2, 3)  - exclusive

To Reproduce
    @RepeatedTest(100)
    void exclusive() {
        assertThat(randomService.nextInt(3)).isLessThan(3); // ok
        assertThat(randomService.nextInt(1, 3)).isLessThan(3); // fails because 3==3
        assertThat(randomService.nextLong(3)).isLessThan(3); //ok
        assertThat(randomService.nextLong(1, 3)).isLessThan(3); // ok
        assertThat(randomService.nextDouble(2, 3)).isLessThan(3); // ok
    }

Expected behavior
All these methods should have the same behaviour: either inclusive or exclusive.
I assume exclusive is better because

most of them are already exclusive
Standard java methods java.lang.Random.nextInt(n), java.lang.Random.nextLong(n) are exclusive.

@bodiam @kingthorin What do you choose: inclusive or exclusive?
Versions:

Faker Version: 1.0 ... 2.4.0

My vote is for exclusive.

Exclusive, mostly because Random does the same.

My vote is to keep it whatever it is right now. It will break things all over if we start changing it. If it needs to be more clear, which I'm not sure if it should be, we could make an nextIntInclusive() or so, but if nextInt() is not inclusive, then something like nextInt(2,2) will not even be valid. Who knows what this will break, especially when you do nextInt(x,y).

@bodiam I agree that it should be communicated first. And maybe it's not worth it. It's enough just to describe the current behaviour in javadoc (I already did it).
P.S. If we decide for "exclusive" behaviour, then nextInt(2,2) should throw IllgalArgumentException.

@asolntsev I'm a big fan of consistency, and I also have to check the source code every time for what it's doing, since I never really know if the documentation, if any, is correct. So, I do agree with you, consistency would be better, and also agree on the IllegalArugmentException. If we'd make the offending methods deprecated now, with a small note on it, we could communicate it. The only downside is that a lot of code would be considered deprecated, even our own code, without a clear deadline when we're really going to pull the plug.
Thoughts?

Current state is quite ok, I would say. Method nextLong is documented, meaning of "min" and "max" is explained.
If we want to improve it, then I suggest to

Leave methods nextLong(min, max) and nextInt(min, max) as is, at least until the next major release.
Create new methods nextLong(range) and nextInt(range).
Where Range is the class that explicitly defines "inclusive" or "exclusive" for both ends".

The usage would look like this:
randomService.nextLong(Range.inclusive(2, 4)) // 2, 3, 4
randomService.nextInt(Range.inclusiveExclusive(2, 5)) // 2, 3, 4
randomService.nextInt(Range.exclusiveInclusive(2, 5)) // 3, 4, 5
randomService.nextLong(Range.exclusive(2, 5))  // 3, 4

Class Range already exists in libraries like Guava and commons-lang, so we could create a similar class in DF as well.

I like it. Seems pretty expressive. There's also Kotlin Range: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.ranges/, which could be used as inspiration.

I like that idea too.
Do we want to remove the others or just decide on a default and have them use the new code internally for the next major?

have them use the new code internally for the next major?

I vote for "have them use the new code internally for the next major".


backend为hbase时，有分区吗

backend为hbase，load vertex时，发现对hbase的write操作全部集中在一个region上，导致经常报RegionTooBusyException，而经常retry。

@minilop hugegraph使用的是hbase的默认分区策略。
请参考下面的方法（https://community.hortonworks.com/questions/37196/im-getting-regiontoobusyexception-when-trying-to-i.html）：

Two major reasons for RegionTooBusyException
Failure to acquire region lock (look for " failed to get a lock in " in map task log)
Region memstore is above limit and flushes can not keep up with load (look for "Above memstore limit")
To mitigate 1. you can increase maximum busy wait timeout hbase.ipc.client.call.purge.timeout in ms (default is 120000) directly but do not forget to increase hbase.rpc.timeout accordingly (set it to the same value)
To mitigate 2. you can increase hbase.hregion.memstore.block.multiplier from default(4) to some higher value.

也可以根据数据的分布特点对 hbase 做更加均衡的预分区。


Fix showing empty rating at some points in time in rating chart

Closes #2548

The only X point that will not display the rating is 0.

This as implemented changes the date that the points on the graph are associated with which is not desirable.

I have not changed the code associated with the date. In the picture that you showed, I don't see any deviations. Everything is displayed correctly.

I checked the chart of the other 5 players. It's all right.

I will double check but in the picture it shows the same date with different rating values. It might have been an overlap but I thought it wasn't. But will check again.

This is the expected behavior. This means that the player played several games that day. Please look at the chart for the last month (not all the time) for any player.

@Sheikah45  Could you review the PR?

Yes I wanted to do another indepth check to make sure the data points don't change but haven't gotten around to it yet


static compiling rust for aarch64-unknown-linux-musl results in undefined reference to `getauxval'

Describe the bug
I'm trying to cross-compile a static build of nix-index from an x86_64-linux host for aarch64-unknown-linux-musl, but it fails with:
  cpu_model.c:(.text.startup.init_cpu_features+0x20): undefined reference to `getauxval'
       >           /nix/store/qmasr7xm8lp9kfjz3z8jsz8xqqnaya6j-aarch64-unknown-linux-musl-binutils-2.40/bin/aarch64-unknown-linux-musl-ld: cpu_model.c:(.text.startup.init_cpu_features+0x2c): undefined reference to `getauxval'
       >           collect2: error: ld returned 1 exit status

Steps To Reproduce
Steps to reproduce the behavior:

Clone the nix-index repo
cargo update to generate Cargo.lock
I've tried to simplify the flake to the one below to minimize confounders:

{
  description = "A files database for nixpkgs";

  inputs.nixpkgs.url = "github:nixos/nixpkgs/nixpkgs-unstable";

  outputs = {
    self,
    nixpkgs,
  }: let
    inherit (nixpkgs) lib;
    system = "x86_64-linux";
    pkgs = import nixpkgs {
      inherit system;
      config.allowUnsupportedSystem = true;
      crossSystem = {
        system = "aarch64-unknown-linux-musl";
        rustc.config = "aarch64-unknown-linux-musl";
        isStatic = true;
      };
    };
  in {
    packages.${system}.default = pkgs.rustPlatform.buildRustPackage {
      pname = "nix-index";
      inherit ((lib.importTOML ./Cargo.toml).package) version;

      src = lib.sourceByRegex self [
        "(examples|src)(/.*)?"
        ''Cargo\.(toml|lock)''
        ''command-not-found\.sh''
      ];

      cargoLock.lockFile = ./Cargo.lock;

      nativeBuildInputs = [pkgs.pkg-config];
      buildInputs = with pkgs;
        [
          openssl
          openssl.dev
          curl
          sqlite
        ]
        ++ lib.optionals stdenv.isDarwin [darwin.apple_sdk.frameworks.Security];

      # NIX_CFLAGS_COMPILE = "-mno-outline-atomics";
      # RUSTFLAGS = "-C -mno-outline-atomics";

      meta = with lib; {
        description = "A files database for nixpkgs";
        homepage = "https://github.com/nix-community/nix-index";
        license = with licenses; [bsd3];
        maintainers = [maintainers.bennofs];
      };
    };
  };
}

Expected behavior
I'm hoping for a successful cross compilation that looks like a static build when I file the output.
Additional context
I have been able to cross-compile a hello world (example), so I'm not sure if this is a problem with a dependency? I've tried scattering pkgsStatic and pkgsMusl around various places like buildInputs without a solution.
There is an existing rustup issue that recommends using CFLAGS=-mno-outline-atomics: https://github.com/rust-lang/rustup/issues/3324
In the flake above, I've commented out my attempts to add this to both NIX_CFLAGS_COMPILE, which gives the same error, as well as RUSTFLAGS = "-C -mno-outline-atomics";, which leads to >   error: unknown codegen option: -mno-outline-atomics
Notify maintainers
teams.rust.members:
@figsoda
@Mic92
@tjni
@Winter
@zowoq
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.59-1-lts, Arch Linux, noversion, rolling`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `""`
 - channels(n8henrie): `"nixpkgs-22.11"`
 - nixpkgs: `/home/n8henrie/.nix-defexpr/channels/nixpkgs`

Perhaps also related: https://github.com/rust-lang/rust/issues/89626

I made an example repo to hopefully make it easier to reproduce: https://github.com/n8henrie/nixpkgs-issue-264687
It seems that depending on / using hyper_proxy is sufficient to reproduce the issue (I presume because of its downstream use of openssl -> openssl-sys).

For future readers that are just hoping to make a statically linked aarch64-linux rust-based executable that depends on openssl, after a bunch of trial and error I got the following flake to successfully build; the keys were:

don't include isStatic
do include RUSTFLAGS = ["-Ctarget-feature=+crt-static"];
do include glibc.static and pkgsStatic.openssl in your buildInputs

I found the asymmetry here very confusing -- why not pkgsStatic.glibc or openssl.static?

{
  description = "https://github.com/NixOS/nixpkgs/issues/264687";
  inputs.nixpkgs.url = "github:nixos/nixpkgs/59e7944d2a7d49264525dd6d9a91a3d86b0f0526";
  outputs = {
    self,
    nixpkgs,
  }: let
    pkgs = import nixpkgs {
      system = "x86_64-linux";
      crossSystem = {
        config = "aarch64-linux";
        rustc.config = "aarch64-unknown-linux-gnu";
      };
    };
  in {
    packages.x86_64-linux.default = pkgs.rustPlatform.buildRustPackage {
      name = "nixpkgs-issue-264687-example";
      version = "0.0";
      src = ./.;
      cargoLock.lockFile = ./Cargo.lock;
      RUSTFLAGS = ["-Ctarget-feature=+crt-static"];
      nativeBuildInputs = [pkgs.pkg-config];
      buildInputs = with pkgs; [
        glibc.static
        pkgsStatic.openssl
      ];
    };
  };
}

Aside from the above, the only other change required to get nix-index to statically compile for aarch64-linux was to depend on pkgsStatic.sqlite instead of sqlite.
However, this is all for aarch64-unknown-linux-gnu; I would still like to be able to compile for musl as well if possible, so I'll leave this issue open for the time being.

Yes, same issue


[BZLMOD] add platforms dep

Description
Addressing some issues that prevented baseline usage with bazel mod

LGTM. Thanks!


Unable to set keybinding for ctrl+p

VSCode Version: 1.26.0
4e9361845dc28659923a300945f84731393e210d
x64

OS Version: Ubuntu 16.04

Steps to Reproduce:

Open keyboard shortcuts
Attempt to set 'Show All Commands' to Ctrl+P
Ctrl shows but p combo does not get added

Does this issue occur when all extensions are disabled?: Yes

@illegalnumbers Can you please provide a screenshot or gif of what you see

I just see the keyboard shortcut screen which has ctrl placed in it but not p.
Ubuntu doesn't lend itself very easily to doing screenshots while the change key hotkey menu item is up so I can't really do it without triggering another key combination or moving the menu off the screen.

It doesn't detect anything. When I use ctrl it detects that but then when I hit the p button nothing comes up. When I use 'p' in other keystroke combinations it's fine. If I set that command to pp or something that seems to work as well.

@alexandrudima Do you know why the p key is not detected when it is typed after ctrl?

@illegalnumbers @sandy081 The fact that we don't get the entire keybinding means that the OS or some other application is stealing it or that the keyboard is broken.
@illegalnumbers Can you use ctrl+p successfully in other applications?


Gitea orgs not listed as orgs

Stumbled across this when I wanted to test https://github.com/woodpecker-ci/woodpecker/pull/2338.
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-479ced3b25"}

Looking at the DB:
 id |    name    | is_user | private
----+------------+---------+---------
  1 | woodpecker | t       | f
  2 | testorg    | t       | f
(2 rows)

But it's an org in Gitea :thinking:

Same result with a fresh Gitea org and repo. Can enable it but WP but still not shown in the orgs view and is_user=true in the DB...
  3 | testorg2   | t       | f

Makes sense, in that case the Gitea integration has an issue.

Mhm, now it's getting interesting...

After, I have dropped the DB of the local dev system a few weeks ago. Even a fresh org and repo created today while running the build from 479ced3b25 ends up with is_user=t in the DB.


all tests for common.py

tests for common.py

Thanks for this new pull request, @varunpatro1! However, the main tests are still failing due to some small errors.

I think you have to replace '' with '/' here.
'svd_inv_sqrt' is not defined here.  You'd have to add this function to the import statement at the beginning of the file.
Same here for 'svd_inv'.

Other than that, it looks great!


Documentation for Zeta Marketing Platform destination

Added:

a new file zetamarketingplatform.md for our integration with Adobe Experience Platform
supporting screenshots
@adobe-documentation-team, please review.

Adobe CLA signed

@vfalon I have made all the above requested changes. Thank you!


[BUG] MacOS pkg installer skip step destination select

General information
Tested on MacOS 10.14, with self built pkg installer:
make NO_CODESIGN=1 BUNDLE_DIR=~/jenkins/bundles out/macos-amd64/crc-macos-amd64.pkg

CRC version
Pre release 1.25.0
Steps to reproduce

Double click on pkg
Installer start
Tab Introduction. Click Continue
Tab License. Click Continue
Pop up on License Agreement. Click Agree
Installer jumps to Tab Installation Type, skipping Destination Select tab. Click Go Back
Go back to Tab License. Click Continue
Here goes to step 5..so destination can not be selected

Expected
Select destination folder for installation
Actual
Occasionally the full flow is honored and the destination folder can be selected... but most of the times ends up on a wrong flow.

Isn't the macOS install path hardcoded in the crc binary anyway?

I mean I can install it, it uses the default path, but the problem is the flow with the installer is not consistent on every run

Yeah, Guillaume mentioned this inconsistency in the past, he was not sure why this is happening.

Thanks for this!
We should disable it at least for now. The path /Applications/CodeReady Containers.app is set in stone in crc binary. Moving the app would certainly break crc.


CreationFailure in resubmission, not in original wf

https://cmsweb.cern.ch/reqmgr/view/details/cerminar_Run2016B-v2-ZeroBias-23Sep2016_8020_160923_164656_6571
has no creation failures, while
https://cmsweb.cern.ch/reqmgr/view/details/prozober_recovery-6-cerminar_Run2016B-v2-ZeroBias-23Sep2016_8020__161001_123455_2546
does.
CreationFailure (Exit code: 99305)
File /store/data/Run2016B/ZeroBias/RAW/v2/000/274/954/00000/E0204A58-B82F-E611-98C0-02163E014405.root has too many events (56396) in 1 lumi(s)
The two tasks have the same splitting.
Is this an averaging effect in how the 56396 is estimated ?

https://cms-logbook.cern.ch/elog/Workflow+processing/25675

Resubmission workflows use the ACDCServer as source of information, for most of the cases.
So what happened here is that this file was registered into WMBS as having 56396 events and only 1 lumi section instead of the original 11 (though this is the expected behavior). From vocms0303:
SQL> select lfn, events from wmbs_file_details where lfn='/store/data/Run2016B/ZeroBias/RAW/v2/000/274/954/00000/E0204A58-B82F-E611-98C0-02163E014405.root';
LFN																 EVENTS
----------------------------------------------------------------------------------------
/store/data/Run2016B/ZeroBias/RAW/v2/000/274/954/00000/E0204A58-B82F-E611-98C0-02163E014405.root									56396

SQL> select * from wmbs_file_runlumi_map where fileid=(select id from wmbs_file_details where lfn='/store/data/Run2016B/ZeroBias/RAW/v2/000/274/954/00000/E0204A58-B82F-E611-98C0-02163E014405.root');
    FILEID	  RUN	    LUMI
---------- ---------- ----------
   4947236     274954	       4

This is yet another ACDC issue that has to be sorted out, though it's not going to be simple.
Can I suggest you guys to give max_events_per_lumi a try for this recovery? Set it to 60k or so please.

What we could do in a short term would be to skip this limit for ACDC requests, though I don't think that's going to buy us much.

the file /store/data/Run2016B/ZeroBias/RAW/v2/000/274/954/00000/E0204A58-B82F-E611-98C0-02163E014405.root has 56396 and 11 lumi sections -period-
the fact that the ACDC might need to read only 1 lumisection out of it, does not change anything.
Will do the increase max_events_per_lumi trick next round, inducing delays.
Thx for looking into fixing that issue at the source

 CreationFailure in resubmission, not in original wf

Just for the record, the issue is still out there as of wmagent 1.1.15.patch2:
Job Name: 86852ea1-5970-4d19-8319-fe4aeaf149af-0
WMBS job id: 8
Workflow: amaltaro_ACDC_ReDigi_cmsRun3_Agent1115_Validation_180822_085133_2259
Task: /amaltaro_ACDC_ReDigi_cmsRun3_Agent1115_Validation_180822_085133_2259/StepThreeProc
Status: jobfailed
Input dataset: /Chib2PToUpsilon2SGamma_TuneCP5_13TeV-pythia8-evtgen/RunIIFall17GS-93X_mc2017_realistic_v3-v1/GEN-SIM
Site: N/A
Agent: vocms0261.cern.ch
ACDC URL: https://cmsweb-testbed.cern.ch/couchdb/acdcserver
State Transition
Exit code: 99305
Retry count: 0
Errors:

    CreationFailure
        CreationFailure (Exit Code: 99305)

            File /store/backfill/1/Integ_Test/Chib2PToUpsilon2SGamma_TuneCP5_13TeV-pythia8-evtgen/AODSIM/ReDigi_cmsRun3_Agent1115_Validation_TEST_Alan_v11-v11/00000/3C65D42B-349F-E811-B169-0CC47A4D765E.root has a single lumi 1048, in run 1 with too many events 6824 and it woud take 180836 sec to run


Implement EncodeHTML function

We already have a way to encode URL data with the EncodeUrl function, this adds the capability to do the same with HTML data.

✅ No public API change.

What exactly are we breaking with this new function?

What exactly are we breaking with this new function?

Nothing. But we need to have it implemented in Power Apps before we can complete this PR, as the function is being added to the list of core functions.

✅ No public API change.


Add cleanup job for events

Exact implementation undecided
Events have an expiry time associated with them. It is expected that events can (but dont have to be) cleaned up after this expiry period.
This time can be customised per event but defaults to 90 days.
There should be a method to trigger a cleanup where all events are deleted that fall outside their expiry time window. It would be worth having this method optionally receive a specific event type to just cleanup the specified event.
This could be a protected endpoint (I dont like this one) or a cli command which will start up a seperate instance to perform the job. Then this can be called by cron on a linux subsystem for whatever schedule and arguments (like event type specification).
This is low priority as performance will take a very long time to become an issue. A new realtime event is created every minute 24/7, this will become 2 per min once vehicle locations are added.

https://github.com/ANIALLATOR114/SimplyTransport/pull/91


Add subcommand to print change log entry

I did a release with dune-release but found that the change log in the PR was empty to my surprise. I want an easy offline way to check the tag and change log entries pulled from the change log file.

I agree with you point that this would be more useful as part of dune-project tag. I'll close this PR and open a new PR that adds that behaviour.


[Enhancement] : Video widget reskinning

https://www.notion.so/appsmith/Video-d617e6f7ba3548dcbb386f0d51527da4

@dilippitchika, YouTube maintains the aspect ratio of the video no matter the size of the container by adding a black background. Our video widget on the other hand has a background property, but it is set to transparent/none by default. Adding a black background color by default solves the border-radius issue, just like YouTube. Shall we move ahead in this direction?

Hey @dhruvikn yes we can proceed in this direction


feat(connector-fabric): identity json signing credentials #1130

Introduces a new, optional (for now) parameter on the run tx
endpoint's request object called gatewayOptions which is capable
of including everything that one needs to instantiate a gateway
object of the underlying Fabric Node SDK.
This change makes it possible to not need the keychain plugin
at all when someone does not need/want it.
Fixes #1130
Depends on #1124
Signed-off-by: Peter Somogyvari<EMAIL_ADDRESS>

Codecov Report

Merging #1132 (a4f2bc2) into main (6d1de27) will decrease coverage by 0.05%.
 Consider uploading reports for the commit da94065 to get more accurate results

@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
- Coverage   73.14%   73.09%   -0.06%
==========================================
  Files         246      247       +1
  Lines        8617     8664      +47
  Branches      996     1008      +12
==========================================
+ Hits         6303     6333      +30
- Misses       1783     1790       +7
- Partials      531      541      +10

Impacted Files
Coverage Δ

...pescript/generated/openapi/typescript-axios/api.ts
86.13% <ø> (ø)

...abric/src/main/typescript/common/create-gateway.ts
64.86% <64.86%> (ø)

.../main/typescript/plugin-ledger-connector-fabric.ts
82.64% <68.96%> (-0.17%)
:arrow_down:

...rc/main/typescript/fabric/fabric-test-ledger-v1.ts
83.59% <100.00%> (+0.17%)
:arrow_up:

...t-tooling/src/main/typescript/common/containers.ts
74.48% <0.00%> (-0.83%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1de27...da94065. Read the comment docs.


Do not traverse through git repositories

This makes git list a lot faster (10 minutes to under 2 minutes in one test) and displays more useful information (at least to me).
Example of git list from before this change demonstrating that git list was hiding the information about the main repository in favour of showing information about a composer dependency:
├── iguana-extras
│   └── vendor
│       └── dxw
│           └── iguana HEAD ok
│                      master ok

Example from after this change:
├── iguana-extras master  [ 1 untracked ]
│                 feature/readme no upstream
│                 feature/update-iguana no upstream
│                 fix/php-cs-fixer no upstream

This would be really useful. When I ran it, I had to kill the process when it didn't complete after 4 hours, probably due to some very wide and deep node_modules folders.

Thanks @mallorydxw, that's a good idea. Could you use filepath.Join(path, ".git") instead of string concat? This way it will work also on Windows.
Or check the "Allow edits from maintainers" box so I can update the PR myself.

@grdl Absolutely. I updated the branch.

Cheers! I just released it as v0.2.0.


Use Debian for both AMD and ARM docker images

We currently use Debian (debian:stretch-slim) as the base image for our AMD64 images, and Ubuntu (ubuntu:16.04) for our ARM64 images.
This difference has been in place since ARM support was added. The difference has been questioned before (#635), but no definitive answer seems available. We should raise this question again as it would be good to use the same OS (Debian) for both to avoid possible differences in behaviour and help with maintenance of our image builds.

Would be nice to simplify things; but not a requirement.
Closing this for now; doing some grooming on the issue list in general and closing things if either:

they weren't been reported by the community
don't have a genuine need to get done

The reason for this is that we tended to use the issue list as a backlog of very minor or wish-list type items which we wish to clear out for now.


fix: disable input if search function is disabled

1. Why is this change necessary?
If you disable the search function in the sw-single-select component you won't expect to see an annoying cursor waiting for your input.
2. What does this change do, exactly?
Sets the existing input field according to the value of "disableSearchFunction"
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23742
Please use this issue to track the state of your pull request.

Thanks again for your contribution, your PR got merged! :tada: :blue_heart:


fix: fixate tslib version to 1.11.2 to avoid typeorm issue

It’s good but missing the fix for the Dockerfile in migrations/canary
There is a fixed version 0.2.22 now so it requires the installation of this particular tslib


Adding tags while creating an index

https://github.com/pinecone-io/pinecone-python-client/blob/463c30d36b3c593b70ce81cd3cad1ae1fb7cc8f4/pinecone/control/pinecone.py#L288
There is no parameter to add tags while creating an index. Is this intentional? What are the alternatives to add tags? My use case is to keep track of what model was used for creating embeddings that are already in the index using tags to ensure that same model is being used for all vectors in a given index. Is this the best way to go about it?

Also, it appears that tag values can't contain any special characters. So something like:
{'embedding_model_name': 'text-embedding-3-large', 'embedding_model_source': 'openai'}

would fail. Is there any workaround for this?

Hey @rajkirankv , thanks for filing this. We're working on getting this into the next release of the Python client. Should be ready by the end of the year at latest!


Pr 17

Andreas' pull request merged into this repo on a new branch. Please verify merge was done correctly.

I had checked that no option is changed, I didn't check if all comments itself are correct.


Updates from John

These are all the sections that had only my name on them. There are a couple of other sections that have me and/or others; I'll try and look at them, but probably not today.


Not working hyper link on campaign (404 not found page on external website)

Which area(s) of Podkrepi.bg are affected?
Desktop layout
Describe the Bug

Not working link under "257 podcast"
To Reproduce

Open https://podkrepi.bg/campaigns/uchilishe-za-rabota-v-pomosh-na-mladezhi-lisheni-ot-roditelska-grizha
Try to click on "257 podcast"
Open 404 error page on external webpage.

Expected Behavior
Open website
Which browser are you using? (if relevant)
Vivaldi Firefox Brave

Good catch! Closing the issue here as a responsibility of the Campaigns team.
We can list the issues regarding campaign texts and ping Campains team for them.

It's working


Fixed error in grad_chooser (for e.g., max) when dtype is not numpy float64

Grads of e.g., sum(anp.max(x, 1)) fail when x is of dtype float32. The issue is that numpy implicitly casts to float64 when dividing a float32 array by an int64 array, which happens in grad_chooser. This fixes the issue by casting appropriately in grad_chooser.

FYI, I have taken some autograd gradients for a side project, and found float64 casting performance bugs scattered around.

@alexbw is this when you're using float32 arrays?
It should be straightforward to add float32 tests. I think adding something to check_fun_and_grads/check_grads should cover almost everything.

Yes, when using float32s. Sorry I don't anything more specific than that, I
no longer depend on autograd grads, so am not spending more bandwidth on
testing them right now. But, if you're interested, there's a possible 2x
speed gain by avoiding the casts. Sorry to be unhelpful, but I figured
having the info out there would be more useful than silence.
On Mon, Mar 20, 2017 at 6:00 PM Jamie Townsend<EMAIL_ADDRESS>wrote:

@alexbw https://github.com/alexbw is this when you're using float32
arrays?
It should be straightforward to add float32 tests. I think adding
something to check_fun_and_grads/check_grads should cover almost
everything.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HIPS/autograd/pull/199#issuecomment-287911678, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJ4j29e-4XUqnGZeAMQzxjHxa-gFO4mks5rnvb-gaJpZM4MdhXB
.

Yeah it's even better than 2x for some things. I made this pr a little while ago but I'll make another one to add testing for float32 dtype support accross all the primitives.


Don't default to live trading

Following the README instructions getting started it is not clear that running docker-compose up will fire up the bot in live trading mode and could be a real surprise to new users starting things up for the first time.
This PR defaults it to start in paper mode.

Valid point, people don't really read before they start. It might make sense, in this case, to add a pretty fat warning (i.e. around here https://github.com/carlos8f/zenbot/blob/master/commands/trade.js#L54) that we are running in paper mode and that the bot is not actually trading unless a user is to remove the --paper (after running a bunch of sims, of course...)

@DeviaVir Isn't that what this does?  https://github.com/carlos8f/zenbot/blob/master/commands/trade.js#L105
If you think it still warrants adding an additional log line after that explaining paper mode lemme know and I can add one in 👍

@Crim it is, but trying to prevent "my bot is not trading" issues; problem with my suggestion is that there is too much happening there already for a new user to spot those log lines (log lines > importing trades > starting)
It might make sense to add an additional log line at the location you pointed out (https://github.com/carlos8f/zenbot/blob/master/commands/trade.js#L105) if we're in paper mode, something along the lines of: paper mode enabled, no real trades are made until you remove --paper from the startup command
or.. thoughts?

I bet you're right regarding users submitting issues on that.  I'll add an additional log line :)

Updated PR with an additional log when paper is enabled.  Log looks like below:
server_1        | ---------------------------- STARTING PAPER TRADING ----------------------------
server_1        | !!! Paper mode enabled. No real trades are performed until you remove --paper from the startup command.


2.2 Updates to Admin

I updated the icons to use Font Awesome as they weren't appearing. I also updated the classes to work with Spree 2.2's line_items.js.coffee and removed the spree-product-assembly version to not overlap with triggers.

@huoxito any news on a pull for this?

hey @tesserakt nope, I'll try to double check if this patch is ok later today but ultimately this project needs someone to take over and help out on issues and maintenance in general. I might still do a bit of it myself (started trying to run it on 2-4-stable last night) but I wouldn't advise anyone to wait sorry.

Closing as stale


entries order not sorted

https://github.com/kodedninja/orkl/blob/7b3f225c687c417c599a9ada6dd9d674805c3057/src/orkl.js#L85
Once I have more than 10 entries, the entries order starts misbehaving. I don't know anything about javascript, but I modified the sort function to be a little bit more explicit, and it works fine again. So I guess there's a bug there?
      state.orkl.content.sort((a, b) => {

        if (b.date == a.date) {

          if (b.ctime - a.ctime) {
            return 1
          } else{
            return -1
          }
          } else {
            if (b.date > a.date) {
              return 1
            } else {
              return -1
            }
        }
      })

Thanks for the bug report! The problem was with return b.date > a.date, because it returned 0 and not minus something when the date was smaller. The corrent form is return b.date - a.date.
I ended up not using your code, because it's simpler and shorter to write it this way.


Re-enable kubernetes adapter validation

Validation for kuberneteses adapter CRDs are temporarily disabled. Mixer validation has some issues (see here) which prevents dependent rules from being created. Re-enable this resource in galley's validatingwebhookconfiguration.yaml once mixer validation is fixed for this type.

CRD per adapter model is going away. Keeping the bug around for posterity.

@ozevren I'm going to just close the bug instead of keeping it around. With 1.2, the old adapter config model will no longer be the default. I think it is OK to no longer track this work.


feat(contributor): Added a new contributor to the slide show

A new issue will be created because the contributor 'dsantos', alias @Dougniel, does not have his style sheet linked in the root 'index.html'.

Thanks a lot @spencer-forrest-opt

@spencer-forrest-opt : you do not appear on the slideshow : when on the last slide (@Dougniel ), we're back on the first slide

@spencer-forrest-opt : you do not appear on the slideshow : when on the last slide (@Dougniel ), we're back on the first slide

It works for me at https://adriens.github.io/livre-or-collaborateurs-glia-slideshow/#/8/1

'dsantos' style sheet issue:
https://github.com/adriens/livre-or-collaborateurs-glia-slideshow/issues/67


SMTP_FROM possibly ignored

Describe the bug
Using the Docker simple instructions a Corteza server instance with SMTP env variables set and carried into the image do not result in working mailing. When signing up I get

Error: could not send email authentication notification: gomail: could not send email 1: gomail: invalid address "": mail: no address

To Reproduce
download example .env file.
set SMTP settings
use docker-compose up -d
sign up for new account
Expected behavior
A new account email should be sent.
Additional context
SMTP variables appear to be present in the server environment when I check inside of them.
Not sure if SMTP_FROM is being ignored or if when signing up the mailto is not being read properly.

@rroseselavy42 hi, thank you for your interest.
Actually, with SMTP_FROM you set default from value.
Auth (reg.) emails are generated in system/internal/service/auth_notification.go -- looks like your setup did not automatically set the value for email.
Reg. email sender should pick up the value from auth.mail.from-address (see auto-discovery code for that).
So, 2 problems:

why was auth.mail.from-address not set on the initial run
should add the fallback to SMTP_FROM (internal/mail.defaultFrom)

In the meanwhile, you can set the auth.mail.from-address manually:
docker-compose exec server /bin/corteza-server system settings set auth.mail.from-address<EMAIL_ADDRESS>
(not sure what your setup is, please adapt first part (before settings) to your environment)

I tried to set the aut.mail.from-address and it seems to still be giving me
Error: could not send password reset notification: gomail: could not send email 1: gomail: invalid address "": mail: no address

logs from the command I use to set auth.mail.from-address
{"level":"info","ts":1565096083.3525136,"logger":"compose.database","caller":"db/connector.go:76","msg":"connected to the database","name":"compose","dsn":"c****a:R****O@tcp(db:3306)/corteza?collation=utf8mb4_general_ci"}
{"level":"info","ts":1565096083.3553052,"logger":"messaging.database","caller":"db/connector.go:76","msg":"connected to the database","name":"messaging","dsn":"c****a:R****O@tcp(db:3306)/corteza?collation=utf8mb4_general_ci"}
{"level":"info","ts":1565096083.3587437,"logger":"system.database","caller":"db/connector.go:76","msg":"connected to the database","name":"system","dsn":"c****a:R****O@tcp(db:3306)/corteza?collation=utf8mb4_general_ci"}
{"level":"info","ts":1565096083.358835,"logger":"compose","caller":"service/service.go:42","msg":"initializing store","path":"/data/compose"}
{"level":"info","ts":1565096083.3596082,"logger":"compose","caller":"service/service.go:45","msg":"initializing store","path":"/data/messaging"}

looking at the server logs when I try a password reset.
server_1  | 2019/08/06 12:54:30 Returned error cause is not a MySQLError, invalid username/password combination
server_1  | 2019/08/06 12:55:34 Returned error cause is not a MySQLError, invalid username/password combination
server_1  | 2019/08/06 13:01:04 Returned error cause is not a MySQLError, invalid username/password combination

hmm, looking at this more I'm wondering if what's not being set is the user email to send TO

NOPE! my bad, just needed to stop and start the server my bad should have tried that first.

:+1:

Fixed with 0dceabc5, restart after first run is no longer needed

Hello Team,
I have the same issue with corteza version version 2021.3.12 , My corteza App is running on ubuntu 20.04 so  I installed corteza and when i first create an account for the admin user, the email is never sent, even though I setup my SMTP on .ENV file  I have the error .
I need a helping Hand

could not send email: gomail: could not send email 1: 550 Verification failed for<EMAIL_ADDRESS>The mail server does not recognize<EMAIL_ADDRESS>as a valid sender. Sender verify failed``


[Coverity CID: 183062] Error handling issues in /samples/net/sockets/big_http_download/src/big_http_download.c

Static code scan issues seen in File: /samples/net/sockets/big_http_download/src/big_http_download.c
Category: Error handling issues
Function: download
Component: Samples
CID: 183062
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

this is now fixed in #7517


Yahoo CTA Bug with pulling JSON from gist

Once upon a time not long ago...
We implemented the Yahoo CTA functionality to pull JSON with CTA data from rawgit.com. So that if data changed we didn't have to do a code deploy each time the data updated. In order to further accommodate changes in the data, we use the dev/testing url rawgit provides to pull the JSON because the prod url they provide is cached permanently and changes to the JSON wouldn't be reflected.
What happened next :question: :exclamation:
Rawgit be maaadddddd.
Happily ever after..
Going to go back to hosting the file ourselves so we don't have to deal with this. Changes to the data are not expected anymore and if it does, we will just have to do a code deploy.

:100: Nice issue documentation!


Convert basic futures combinators to futures-core 0.3

This commit includes the introduction of a FutureResult trait along the lines of the RFC (with some slight revisions).
It tackles all the "basic" combinators, but leaves off shared, select, and join for the moment.

LGTM aside from FutureResult and the Result-y versions of flatten.

I'm going to go ahead and merge this, then open a follow-up PR that tracks the new RFC proposal.

This PR was removing future::loop_fn, and it seems it was not added back in one way or another since then. Are there any fundamental reasons why it can't possibly implemented (seems similar enough to stream::unfold) or was it just forgotten?
If it was just forgotten I could send a PR for adding it back in the next days.

@sdroege It certainly can be implemented, but it's pretty redundant with loop + async/await.

@sdroege It certainly can be implemented, but it's pretty redundant with loop + async/await.

Sure, but the same could be said about many of the existing combinators too :) Would you consider adding it back if I created a PR?

This PR was removing future::loop_fn, and it seems it was not added back in one way or another since then

I just hit this while converting a medium size crate from 0.1 to 0.3. I'm doing so since the futures library parts are being stabilised, but I want to avoid async/await until that is stable (I'm assuming this migration will make the later one easier).
Anyway, I think it would be good for to make some equivalent of loop_fn/Loop (and any other removed things) available in some form to make the transition from 0.1 to 1.0 as easy as possible. For large crates that is already a huge task. There is no documentation about what to do here, so even though it is easy if you know what you are doing, it is fairly difficult to find that out.

I'd be happy to accept things like this under a separate feature (e.g. migration or something like that). There are a number of combinators whose new versions will be similarly impossible to use if you're trying to do a conversion to 0.3 without using async/await, such as most of the methods on AsyncReadExt, AsyncWriteExt, and Sink, since they take a borrowed self rather than an owned one like the previous versions. I attempted to make a combinator that would allow using borrowed futures types using combinator-only code, but that fell afoul of about a million HTRB-related compiler bugs (see https://github.com/rust-lang-nursery/futures-rs/pull/1023).
I'd prefer not to include these types in the default feature set or in the normal locations as those namespaces are already quite crowded, and I'd like to avoid suggesting combinators to users which are essentially useless post-async/await.

That sounds good to me. I agree we don't want to recommend such combinators given async/await but purely for migrating code they seem pretty useful

Yup! Sounds good.

I just hit this while converting a medium size crate from 0.1 to 0.3.

My workaround so far was to build something around stream::unfold and for_each btw


Use #F0FFFF instead of azure in 1faa9.svg

Fixes https://github.com/twitter/twemoji/issues/537

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

great catch, thank you!

No problem!


ciao-image: client and datastore changes

This PR changes the client API so that GetImagePath() is a client method.
It also separates the datastore and cache logic. The datastore interface is now a lower level one that gets called by the cache implementation.

Coverage decreased (-0.08%) to 65.565% when pulling 0a799ea6d3a26b46354193c2f131d8711e3d15a4 on sameo/topic/storage into 3d7c10234f08c5dc4792c785c01f6782118f5c2f on kaccardi/topic/storage.


[BUG] The app crashes when you go to Checklist indicators >Trend,Pathways, or Origin

Location of the bug
Checklist indicators>Trend, Pathways, or Origin
Describe the bug
The app crashes whenever you want to go to another subtab than taxa (i.e., Trend, Pathways, or Origin) under Checklist indicators.
Reproduce bug
Steps to reproduce the behavior:

Go to 'Checklist indicators'
Click on 'Trend', 'Pathways', or 'Origin'
See that the app crashes

Screenshots

On a side note: I forced in data 'indicators' the variables 'first_observed' and 'last_observed' to be numeric. Fix already implemented here: https://github.com/inbo/alien-species-portal/blob/fix_v1.1.0/alienSpecies/R/data_create.R#L467-L468


Change hardcoded image PullPolicy

Parameterizing the PullPolicy for init containers will enable users to specify whether they want to cache images or pull from image repository on init inject.

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
N/A Slack

License
Apache 2.0

What's in this PR?
This PR allows for passing in either through CLI args or environment the desired PullPolicy for init containers.
Why?
Some have voiced security concerns at caching docker images locally. Additionally, some organizations have enforced policies that don’t allow for locally cached images.
Checklist

[x] Error handling code meets the guideline
[x] Logging code meets the guideline (TODO)
[ ] User guide and development docs updated (if needed)
[x] Related Helm chart(s) updated (if needed)

To Do

[ ] Update Docs to reflect the new parameter

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Can we get this in a 0.5.x release?

Yeah, of course, let me open a PR.

https://github.com/banzaicloud/bank-vaults/releases/tag/0.5.3 has been released @wombat , please wait for a while for DockerHub to build the images.

@bonifaido Thats super awesome - thank you!

@bonifaido Is it normal that only vault-env 0.5.3 docker image was published? From my understanding it should be in the webhook image.

Hi, just checked and the webhook build hung up, thanks for coming back with this (and Dockerhub haven't sent me any notifications)! Just restarted it.

Released! :)


[Fix-5825][BUG][WEB] the resource tree in the process definition of latest dev branch can't display correctly

Purpose of the pull request
Fix #5825
Close #5825
Brief change log

enhance the if condition
in the latest dev branch, mr.vue#L229 else if (element.children != null)   changes to else if (element.children !== null)
According to the doc in MDN：https://developer.mozilla.org/zh-CN/docs/Web/JavaScript/Equality_comparisons_and_sameness

// this would be true
console.log(undefined !== null)

undefind can run into the else if statement, it would cause the code to throw an excpetion. so I change else if (element.children !== null) to else if (element.children)

Since the code for loading resource lists in flink task, mapreduce task, etc are exactly the same,  I try to refactor the js by extracting the common code to a seperate js so the common part can be updated only one time.

Verify this pull request
Manually verified the change by testing locally.

Codecov Report

Merging #5826 (186d3d7) into dev (16986c3) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #5826      +/-   ##
============================================
- Coverage     45.42%   45.01%   -0.42%
+ Complexity     3694     3656      -38
============================================
  Files           607      607
  Lines         24872    24888      +16
  Branches       2834     2835       +1
============================================
- Hits          11299    11204      -95
- Misses        12484    12612     +128
+ Partials       1089     1072      -17

Impacted Files
Coverage Δ

...he/dolphinscheduler/common/enums/SqoopJobType.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...phinscheduler/service/registry/RegistryClient.java
0.00% <0.00%> (-47.19%)
:arrow_down:

...phinscheduler/service/registry/RegistryCenter.java
0.00% <0.00%> (-24.14%)
:arrow_down:

...uler/server/master/registry/ServerNodeManager.java
0.00% <0.00%> (-7.02%)
:arrow_down:

...olphinscheduler/server/registry/HeartBeatTask.java
18.00% <0.00%> (-0.87%)
:arrow_down:

...r/server/worker/processor/TaskCallbackService.java
3.12% <0.00%> (-0.05%)
:arrow_down:

...hinscheduler/server/worker/task/http/HttpTask.java
2.58% <0.00%> (-0.05%)
:arrow_down:

...he/dolphinscheduler/server/utils/RemoveZKNode.java
0.00% <0.00%> (ø)

...lphinscheduler/spi/plugin/DolphinPluginLoader.java
0.00% <0.00%> (ø)

...inscheduler/common/task/sqoop/SqoopParameters.java
74.00% <0.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16986c3...186d3d7. Read the comment docs.

@zhuangchong  can you have a look when you have time ? thanks.


Bump slimmer and explicitly set slimmer template

The new version of slimmer changes the default template that gets used.
Bump slimmer to the newest version and ensure that the wrapper template
is still used.

Did you consider adding a test to assert that we're using the "wrapper" template, and describe why we're using it?

Was the upgrade of slimmer required for any other reason, or are you upgrading it now to avoid someone else doing it in future without realising that they also needed to make the other changes you've made in this commit?

Yes this was just preventative to ensure someone didn't miss it if they updated it.
I can try adding a test if you would like me to, though the vector for a developer to change this without realising is fairly small as the page does look quite broken.

I can try adding a test if you would like me to, though the vector for a developer to change this without realising is fairly small as the page does look quite broken.

Nah, I don't think you need to add a test. If it's obviously broken without that line then I think that's good enough for now.

Ok, let's merge this :shipit:


Bug: Some application errors ( C4d / redshift) are not bubbled up to logs making triage hard.

Expected Behaviour
If possible, the actual failure from the application should be echoed in the logs if possible, so that the cause of the issue can be determined more quickly.
If this error is reported, by the time escalation happens to IT, the fleet might have been scaled down and the underlying application logs living on the instance lost.
Current Behaviour
Currently we are presented with just an openjd_fail:
openjd_ fail: Error encountered while running adaptor: Cinema4D exited early and did not nder successfully, please check render logs. Exit code XXXXXXX
Reproduction Steps
We suspect this happen with a resource starvation issue - will update once we can reproduce and get the logs off the spot instance before it shuts down.
Code Snippet
N?A

Hmm, interesting. Ideally the render logs should contain the errors before this line gets printed. For example, in this issue we had a few errors after which openjd_ fail: Error encountered while running adaptor: Cinema4D ... line is printed.
Is it possible to share the worker/session logs to understand the root cause?


aspnet-WebApp1 database doesn't exist on my local database.

Should we have built aspnet-WebApp1 database with earlier code?  Are there instructions for setting this up?  Your instructions jump right into it assuming its already there.
Right now my appsetting.json has
"ConnectionStrings": {
"DefaultConnection": "DataSource=app.db"
},
and app.db is a generated file on the root

Hello @BrettPrime ... Would you mind re-opening this issue from the Content feedback button at the bottom of the topic that you're referring to? It will tag your issue with info from the topic that helps us track the issue.

Hi Luke
I can’t find that option except to reply to one of the already existing issues
https://docs.microsoft.com/en-us/aspnet/core/security/authentication/identity?view=aspnetcore-2.1&tabs=visual-studio
<EMAIL_ADDRESS>From: Luke Latham<EMAIL_ADDRESS>Sent: Thursday, December 20, 2018 2:53 PM
To: aspnet/Docs<EMAIL_ADDRESS>Cc: Brett Little (PHS<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [aspnet/Docs] aspnet-WebApp1 database doesn't exist on my local database. (#10076)
WARNING: This email originated outside the Prime Healthcare email system! Do Not Click links if this user is unknown.
Hello @BrettPrimehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_BrettPrime&d=DwMCaQ&c=uJDInsUI975ObH1pw6atlCu6k9_P2kimr_XZeMjqt08&r=sa3JEJYRWc9krC9srEU95A&m=qvRZTkRzsvhiVo5rczcE4DiHSpVNvZzfn00IkBkx440&s=Ym67a1_q2PU2JrINMPr1KINrHUTJWPEWw9Tc7XVgi0s&e= ... Would you mind re-opening this issue from the Content feedback button at the bottom of the topic that you're referring to? It will tag your issue with info from the topic that helps us track the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_aspnet_Docs_issues_10076-23issuecomment-2D449161687&d=DwMCaQ&c=uJDInsUI975ObH1pw6atlCu6k9_P2kimr_XZeMjqt08&r=sa3JEJYRWc9krC9srEU95A&m=qvRZTkRzsvhiVo5rczcE4DiHSpVNvZzfn00IkBkx440&s=lH66o4-i8Ytb26OdphC90tKgcSCszSihlwMhW1PvnlA&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AZfNhbyk-2DL2-2D-2DAuD3jDRZegTbxyWTS0Iks5u7BTjgaJpZM4ZdBrt&d=DwMCaQ&c=uJDInsUI975ObH1pw6atlCu6k9_P2kimr_XZeMjqt08&r=sa3JEJYRWc9krC9srEU95A&m=qvRZTkRzsvhiVo5rczcE4DiHSpVNvZzfn00IkBkx440&s=P7O_FR4VZvqCvlNdIv1uDaWybaKCmzhyqqX83Yp2Eew&e=.

Ok ... that's cool. It should have been at the bottom of the topic. :smile: There might be some platform/browser-specific requirement for that button and form to show up.

When you create a Web app with authentication, the templates create all the code to create the DB.

I got it to work by creating it in .Net core 2.0.  2.1 did not work.
From: Rick Anderson<EMAIL_ADDRESS>Sent: Thursday, January 3, 2019 9:12 PM
To: aspnet/Docs<EMAIL_ADDRESS>Cc: Brett Little (PHS<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [aspnet/Docs] aspnet-WebApp1 database doesn't exist on my local database. (#10076)
WARNING: This email originated outside the Prime Healthcare email system! Do Not Click links if this user is unknown.
When you create a Web app with authentication, the templates create all the code to create the DB.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_aspnet_Docs_issues_10076-23issuecomment-2D451354929&d=DwMCaQ&c=uJDInsUI975ObH1pw6atlCu6k9_P2kimr_XZeMjqt08&r=sa3JEJYRWc9krC9srEU95A&m=ln-AQp0iAhY0RaiSruWRInn0-2PhqHJTH_QbjrKJb6w&s=Dt0ahBcQaMz9ZTCsIbAs1efC8gJK7-VORA-ytNkv3fw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AZfNhcMW4Wh-5Fub8gEOPYZ34muUylnsbnks5u-5FuK4gaJpZM4ZdBrt&d=DwMCaQ&c=uJDInsUI975ObH1pw6atlCu6k9_P2kimr_XZeMjqt08&r=sa3JEJYRWc9krC9srEU95A&m=ln-AQp0iAhY0RaiSruWRInn0-2PhqHJTH_QbjrKJb6w&s=XVnhwOXzyWS79rei1jR8UQCbzccC7KwYAqRbxRhTFVc&e=.


Language to query understanding is not always working

Hi Voxel51 team. Congratulations on the release.
I just tested  it for a query show me top 10 most bright images but it looks like it is doing a query of view.sort_by(F("brightness").mean(),reverse=True).limit(10) which is not right.

Looks like it is related to the other issue where it is remembering my earlier query show me top 10 most dark images

Hi @nahidalam , thanks for identifying this, and apologies for the delayed response! VoxelGPT is definitely far from perfect, as is to be expected with an LLM-based (especially GPT-3.5 and before OpenAI function calling was introduced) querying application. I hope it still served as a useful tool for you in your dataset exploration and learning of the FiftyOne query language :)
Seeing as this is stale, I'm going to close the issue for now, but please reach out if you're still interested in improvements like this.


Nullpointer on test run (loading of truststore fails)

Test run fails, same applies for building docker container.
Build and run with -DskipTests works.
Details:
pathes to keystore and truststore are provided as URIs, e.g. "@id" : "file:///conf/keystore-localhost.p12"
KeyStoreManager extracts path but does not remove leading / as expected by classLoader.getResourceAsStream(...)
Stacktrace:
Caused by: java.lang.NullPointerException
	at de.fraunhofer.isst.ids.framework.configuration.KeyStoreManager.loadKeyStore(KeyStoreManager.java:105)
	at de.fraunhofer.isst.ids.framework.configuration.KeyStoreManager.<init>(KeyStoreManager.java:65)
	at de.fraunhofer.isst.ids.framework.spring.starter.ConfigProducer.<init>(ConfigProducer.java:52)

 Moritz Keppler<EMAIL_ADDRESS>Daimler TSS GmbH, legal info/Impressum

The error can be reproduced on other Windows systems, but not on Linux. An issue to correct the file path handling was passed on to the framework developers. It will be fixed with an update of the framework version.

It happens on my Linux machine as well, on a fresh checkout followed by mvn install

@MoritzKeppler @hylkevds The error should now be fixed in the dev branch with Pull Request #31


[Bugfix][Frontend] Enable tools

This PR enables sending Tool messages, assistant messages with tool calls, and other message types, as part of the messages list in ChatCompletionRequest.
Looking at protocol.py, this was actually already available. The problem was that when the messages were parsed to send them to apply_chat_template, all fields apart from role and content were ignored. For example, an assistant message with tool calls has an extra tool_calls field which is very important and was ignored.
The fix has 2 parts:

Re-implementing OpenAI's ChatCompletionAssistantMessageParam because of a bug in pydantic: https://github.com/pydantic/pydantic/issues/9467 - this was actually a problem even with accepting tool_calls and has nothing to do with parsing it to send to apply_chat_template.
In the simple case where content is not a list (which is allowed only for User messages that don't have tool_calls anyway), use the original message instead of parsing it into TextConversationMessage which has only role and content.

The message parsing logic was missing tests, which are also added in this PR:

tests/entrypoints/test_chat_utils.py with tests for parse_chat_messages - all tests that check messages that have more than role and content fail on main branch.
Added test_tool_calls_message_is_parsed_correctly_in_chat_completion_request to tests/entrypoints/openai/test_serving_chat.py that makes sure the pydantic bug mentioned above doesn't affect tool_calls sent as part of assistant messages in ChatCompletionRequest - this test also fails on main branch

/ready

I isolated the failed entrypoints-test and run them manually, and they pass. I'm pretty sure they failed in the CI because of different reasons.. I saw a log about connection timeouts with HF hub

fwiw this should be contained in #5649, along with a bunch of other functionality

Closed as this is irrelevant after https://github.com/vllm-project/vllm/pull/5649 was merged :)


Question about UMAP plot

Hi, is it possible to share the source code to plot UMAP. Thank you.

Thank you for your response. Where should I add this file? Should I add this to clup/cli/commoads?
Actually, I couldn't run that. Could you please explain me how to run it?


Cover photo

This app is great. Besides the profile image, is it possible to add a users cover photo in the navigation drawer?

With the current code structure, not really. However I am considering adding OAuth login to allow more features to be added and cover photos would be trivial with access to the Facebook API.

Understandable. Great app nonetheless!

Implemented in 10e4a1533cde12d93f191b6b5670e16a53cd8360


/etc/fstab vhdx disk fails to mount at boot randomly

Windows Version
Microsoft Windows [22631.3447) 23H2
WSL Version
2.1.5
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
5.15.146
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps
As mentioned #11281 this is a random error (or it seems so) that I was able to reproduce in my machine, but it affects other developers in my company with slighly different versions of WSL2 and Windows.
I have some issues to get the logs because the script got blocked by the EDR in the company.

External vhdx disk.
To mount it automatically, the disk has a label called "workspace" with tune2fs -L "workspace" /dev/sdd
Modified fstab like this
LABEL=workspace /home/ubuntu/workspace ext4 defaults 0 2
Created launch config in Windows Terminal for Ubuntu 22 with the following:
powershell.exe -Command "wsl.exe -d Ubuntu-22.04-abc--mount --vhd C:\vhd\workspace\workspace.vhdx --bare | Out-Null; wsl.exe ~ -d Ubuntu-22.04-abc"
Start distro.

Expected Behavior
Disk is automatically mounted always.
Actual Behavior
Start distro shows ~50-60% of times this error.
Processing fstab mount -a with failed

[Fri Mar  8 14:38:46 2024] mount:
[Fri Mar  8 14:38:46 2024] /home/ubuntu/workspace: can't find LABEL=workspace.
[Fri Mar  8 14:38:46 2024] WSL (1) ERROR: UtilCreateProcessAndWait:687: /bin/mount failed with status 0x2000
Diagnostic Logs
Here the logs meanwhile WslLogs-2024-04-30_12-01-59.zip

Issue showing up and happening 3-4 fresh new opened terminals.
Shutdown wsl.
Start again distro & in this case it did not fail the mount.

@borjamunozf: wsl --mount will only be able to mount the disk when running WSL as admininistrator.
Could it be that the failures are when WSL is not started as admin ?

But how is possible that sometimes it works? My test (and from other devs)
is runnings always WSL as normal user, non-admin.
Indeed I remember that the wsl --mount --attach only worked as admin from
documentation and other issues reported here, but after seeing that it
worked (sometimes) with the config I wrote associated to the Distro in
Windows Terminal, I don't get what's going on.
El mar, 30 abr 2024 a las 23:11, Blue @.***>) escribió:

@borjamunozf https://github.com/borjamunozf: wsl --mount will only be
able to mount the disk when running WSL as admininistrator.
Could it be that the failures are when WSL is not started as admin ?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/WSL/issues/11539#issuecomment-2087334003,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGFV5D7S2Z2GFDITLY27WKDZAACG3AVCNFSM6AAAAABG76TX5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXGMZTIMBQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Does the mount work if let's say you run wsl --shutdown, and then start WSL as admin ?

Same behaviour:

sometimes it works, sometimes not. As it was executed in a normal terminal

Interesting. Could you collect logs of a working and a non working repro when running WSL as administrator (in separate files if possible)?
/logs

I will try to run again, it's a bit annoying because the EDR of my company blocks it and we have to request specific and temporary approval of the script.
And also as it's a bit random could take a while to get both samples.
Updating this just to avoid the issue to be closed again

i'm having the same issue


Suggested solution for automatically calculating formulas

I would like to add some formulas to my generated spreadsheet, like SUM(B4:B34), however it does not work as one would expect. When opened in a spreadsheet application the value is not calculated automatically, and is shown as empty or whatever was put into the v-value.
However, when looking into the problem of recalculating formulas I found and article on http://stackoverflow.com/questions/18355691/set-xlsx-to-recalculate-formulae-on-open, which suggests simply adding a  tag <calcPr fullCalcOnLoad="1"/> would resolve the whole issue when opening the document in MS Office, OpenOffice, Google spreadsheet etc.
Anyone who understands the inner workings of js-xlsx might be able to test this. This might be an significantly easier way of solving the issue discussed #105, and maybe some other issues around formulas as well.

you might want to look at this issue
https://github.com/SheetJS/js-xlsx/issues/152#issuecomment-145090110
There is a fork that has added support for formulas.

Thanks @mdumouchel! I do, however, believe that #152 does not solve the issue at hand. My issue being that when I have generated a spreadsheet with formulas the resulting values are not calculated when opened in editor of choice. The formulas are present, but not calculated.

Would you mind posting some sample code of the problem?

We updated the write test with an example


It doesn't work unless a link has http(s):// in it

I believe this could easily be fixed by simply adding http to the arg if it's missing, or some other change to the code, however I do not know python well nor do I know this project well.

It should be up the user to add the http(s):// to URL's before passing it to unshortenit. I don't see the need to implement this in the module.

Alright, just thought it would be convenient, since I often paste it in directly without http(s):// before, but I made a bash wrapper that does this for me any way.


Can't start basic Echo bot

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Versions
What package version of the SDK are you using<EMAIL_ADDRESS>What nodejs version are you using : v19.4.0
What browser version are you using: None
What os are you using : OSX 12.2.1
Describe the bug
Same as described in https://github.com/microsoft/botbuilder-js/issues/4520
To Reproduce
Steps to reproduce the behavior:

Follow the instructions from the official documentation
yo botbuilder, Select the Echo bot, in Javascript
npm start
See error

# ...
node_modules/restify/lib/request.js:848
    Request.prototype.closed = function closed() {
# ...

See error

Expected behavior
It should run as follows:

><EMAIL_ADDRESS>start
> node ./index.js

restify listening to http://[::]:3978

Get Bot Framework Emulator: https://aka.ms/botframework-emulator

To talk to your bot, open the emulator select "Open Bot"

Additional context
Restify is outdated:
npm list restify
# => ~v8

This solves the issue:
npm install<EMAIL_ADDRESS>
This is surprising, since this seemed to be solved by PR merged related to https://github.com/microsoft/botbuilder-js/issues/4520

@matthieudelaro - I was able to repro the issue you experienced tested using both Node v18.9.0 and v19.4.0. It seems the generator is installing<EMAIL_ADDRESS>when it should be installing v4.20.0, at a minimum. If you upgrade the botbuilder package, leaving restify at v11.1.0, the echo bot performs, as expected.
We will look into this and correct the issue. Thank you for the notification.

Pushed updated JS generators which use SDK 4.20.0.


[Android ] [Error] Min version error

Hello,
When running exemple code on android with sdk version 30
I take following error :
Android permission are ok
Error: Feature not available in the current version of the Google Play services
Have you an idea or suggestion ?

Try to update Google Play services to the latest version.