cmd/compile: register allocation unnecessarily leaves reload in loop containing conditional call

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.10devel
What operating system and processor architecture are you using (go env)?
amd64
What did you do?
Compiled various simple loops that include "if flag { call(); }" (and that is the only call in the loop)
What did you expect to see?
All spills and reloads grouped around the call and not in the common code path of the loop.
What did you see instead?
Half-right -- the reload occurs under the conditional, but it is not properly hoisted out of the loop so there is also a reload in the common code path
Sample code and compiled assembly follow:
package foo

var flag bool = true

//go:noinline
func k() {
	flag = false
}

func f1(p []byte) bool {
	i := 0
	l := len(p)
	if i < l {
		for {
			if p[i] != 0 {
				return true
			}
			i++
			if i >= l {
				break
			}
			if flag {
				k()
			}
		}
	}
	return false
}

func f2(p []byte) bool {
	i := 0
	l := len(p)
	if i < l {
		for {
			if p[i] != 0 {
				return true
			}
			i++
			if flag {
				k()
			}
			if i >= l {
				break
			}
		}
	}
	return false
}

func f3(p []byte) bool {
	for _, x := range p {
		if x != 0 {
			return true
		}
		if flag {
			k()
		}
	}
	return false
}

// This one has no call and the loads are done right.
func f0(p []byte) bool {
	i := 0
	l := len(p)
	if i < l {
		for {
			if p[i] != 0 {
				return true
			}
			i++
			if i >= l {
				break
			}
		}
	}
	return false
}

genssa f1
   	00000 (.../spillsink.go:10)	TEXT	"".f1(SB)
   	00001 (.../spillsink.go:10)	FUNCDATA	$0, gclocals·...(SB)
   	00002 (.../spillsink.go:10)	FUNCDATA	$1, gclocals·...(SB)
v8	00003 (.../spillsink.go:10)	MOVQ	"".p+8(SP), AX
v30	00004 (.../spillsink.go:13)	TESTQ	AX, AX
b1	00005 (.../spillsink.go:13)	JLE	26
v43	00006 (.../spillsink.go:13)	MOVL	$0, CX

v33	00007 (.../spillsink.go:15)	CMPQ	CX, AX
b5	00008 (.../spillsink.go:15)	JCC	30
v22	00009 (.../spillsink.go:15)	MOVQ	"".p(SP), DX     <-- this load should occur before the loop
v20	00010 (.../spillsink.go:15)	MOVBLZX	(DX)(CX*1), BX
v9	00011 (.../spillsink.go:15)	TESTB	BX, BX
b10	00012 (.../spillsink.go:15)	JNE	28
v29	00013 (.../spillsink.go:18)	INCQ	CX
v6	00014 (.../spillsink.go:19)	CMPQ	CX, AX
b9	00015 (.../spillsink.go:19)	JGE	26
v34	00016 (.../spillsink.go:22)	MOVBLZX	"".flag(SB), BX
v19	00017 (.../spillsink.go:22)	TESTB	BX, BX
b13	00018 (.../spillsink.go:22)	JEQ	7

v18	00019 (.../spillsink.go:22)	MOVQ	CX, "".i-8(SP)
v36	00020 (.../spillsink.go:23)	PCDATA	$0, $0
v36	00021 (.../spillsink.go:23)	CALL	"".k(SB)
v31	00022 (.../spillsink.go:23)	MOVQ	"".p+8(SP), AX
v23	00023 (.../spillsink.go:23)	MOVQ	"".i-8(SP), CX
v35	00024 (.../spillsink.go:23)	MOVQ	"".p(SP), DX     <-- this reload is good.
b14	00025 (.../spillsink.go:23)	JMP	7

v39	00026 (.../spillsink.go:27)	MOVB	$0, "".~r1+24(SP)
b3	00027 (.../spillsink.go:27)	RET
v26	00028 (.../spillsink.go:16)	MOVB	$1, "".~r1+24(SP)
b8	00029 (.../spillsink.go:16)	RET
v16	00030 (.../spillsink.go:15)	PCDATA	$0, $1
v16	00031 (.../spillsink.go:15)	CALL	runtime.panicindex(SB)
b11	00032 (.../spillsink.go:15)	UNDEF
   	00033 (<unknown line number>)	END

genssa f2
   	00000 (.../spillsink.go:30)	TEXT	"".f2(SB)
   	00001 (.../spillsink.go:30)	FUNCDATA	$0, gclocals·...(SB)
   	00002 (.../spillsink.go:30)	FUNCDATA	$1, gclocals·...(SB)
v8	00003 (.../spillsink.go:30)	MOVQ	"".p+8(SP), AX
v27	00004 (.../spillsink.go:33)	TESTQ	AX, AX
b1	00005 (.../spillsink.go:33)	JLE	19
v22	00006 (.../spillsink.go:33)	MOVL	$0, CX

v15	00007 (.../spillsink.go:35)	CMPQ	CX, AX
b5	00008 (.../spillsink.go:35)	JCC	30
v37	00009 (.../spillsink.go:35)	MOVQ	"".p(SP), DX     <-- this load should occur before the loop
v20	00010 (.../spillsink.go:35)	MOVBLZX	(DX)(CX*1), BX
v17	00011 (.../spillsink.go:35)	TESTB	BX, BX
b10	00012 (.../spillsink.go:35)	JNE	28
v32	00013 (.../spillsink.go:39)	MOVBLZX	"".flag(SB), BX
v35	00014 (.../spillsink.go:39)	TESTB	BX, BX
b9	00015 (.../spillsink.go:39)	JNE	21
v29	00016 (.../spillsink.go:38)	INCQ	CX
v31	00017 (.../spillsink.go:42)	CMPQ	CX, AX
b13	00018 (.../spillsink.go:42)	JLT	7

v40	00019 (.../spillsink.go:47)	MOVB	$0, "".~r1+24(SP)
b3	00020 (.../spillsink.go:47)	RET
v6	00021 (.../spillsink.go:47)	MOVQ	CX, "".i-8(SP)
v34	00022 (.../spillsink.go:40)	PCDATA	$0, $0
v34	00023 (.../spillsink.go:40)	CALL	"".k(SB)
v18	00024 (.../spillsink.go:40)	MOVQ	"".p+8(SP), AX
v23	00025 (.../spillsink.go:40)	MOVQ	"".i-8(SP), CX
v33	00026 (.../spillsink.go:40)	MOVQ	"".p(SP), DX    <-- this reload is good.
b12	00027 (.../spillsink.go:40)	JMP	16

v26	00028 (.../spillsink.go:36)	MOVB	$1, "".~r1+24(SP)
b8	00029 (.../spillsink.go:36)	RET
v16	00030 (.../spillsink.go:35)	PCDATA	$0, $1
v16	00031 (.../spillsink.go:35)	CALL	runtime.panicindex(SB)
b11	00032 (.../spillsink.go:35)	UNDEF
   	00033 (<unknown line number>)	END

genssa f3
   	00000 (.../spillsink.go:50)	TEXT	"".f3(SB)
   	00001 (.../spillsink.go:50)	FUNCDATA	$0, gclocals·...(SB)
   	00002 (.../spillsink.go:50)	FUNCDATA	$1, gclocals·...(SB)
v22	00003 (.../spillsink.go:50)	MOVL	$0, AX
v43	00004 (.../spillsink.go:50)	MOVQ	"".p(SP), CX
b1	00005 (.../spillsink.go:51)	JMP	8

v34	00006 (.../spillsink.go:51)	INCQ	CX
v37	00007 (.../spillsink.go:51)	INCQ	AX
v23	00008 (.../spillsink.go:51)	MOVQ	"".p+8(SP), DX     <-- this load should occur before the loop
v6	00009 (.../spillsink.go:51)	CMPQ	AX, DX
b2	00010 (.../spillsink.go:51)	JGE	27
v19	00011 (.../spillsink.go:51)	MOVBLZX	(CX), BX
v9	00012 (.../spillsink.go:52)	TESTB	BX, BX
b3	00013 (.../spillsink.go:52)	JNE	25
v29	00014 (.../spillsink.go:55)	MOVBLZX	"".flag(SB), BX
v28	00015 (.../spillsink.go:55)	TESTB	BX, BX
b7	00016 (.../spillsink.go:55)	JEQ	6

v7	00017 (.../spillsink.go:55)	MOVQ	AX, ""..autotmp_8-16(SP)
v11	00018 (.../spillsink.go:55)	MOVQ	CX, ""..autotmp_9-8(SP)
v31	00019 (.../spillsink.go:56)	PCDATA	$0, $1
v31	00020 (.../spillsink.go:56)	CALL	"".k(SB)
v15	00021 (.../spillsink.go:56)	MOVQ	""..autotmp_8-16(SP), AX
v36	00022 (.../spillsink.go:56)	MOVQ	""..autotmp_9-8(SP), CX
v33	00023 (.../spillsink.go:56)	MOVQ	"".p+8(SP), DX    <-- this reload is good.
b8	00024 (.../spillsink.go:56)	JMP	6

v26	00025 (.../spillsink.go:53)	MOVB	$1, "".~r1+24(SP)
b6	00026 (.../spillsink.go:53)	RET
v40	00027 (.../spillsink.go:59)	MOVB	$0, "".~r1+24(SP)
b5	00028 (.../spillsink.go:59)	RET
   	00029 (<unknown line number>)	END

genssa f0
    00000 (.../spillsink.go:62) TEXT  "".f0(SB)
    00001 (.../spillsink.go:62) FUNCDATA  $0, gclocals·...(SB)
    00002 (.../spillsink.go:62) FUNCDATA  $1, gclocals·...(SB)
v8  00003 (.../spillsink.go:62) MOVQ  "".p+8(SP), AX
v11 00004 (.../spillsink.go:65) TESTQ AX, AX
b1  00005 (.../spillsink.go:65) JLE 16
v22 00006 (.../spillsink.go:65) MOVQ  "".p(SP), CX
v18 00007 (.../spillsink.go:65) MOVL  $0, DX

v24 00008 (.../spillsink.go:67) CMPQ  DX, AX
b5  00009 (.../spillsink.go:67) JCC 20
v20 00010 (.../spillsink.go:67) MOVBLZX (CX)(DX*1), BX
v9  00011 (.../spillsink.go:67) TESTB BX, BX
b10 00012 (.../spillsink.go:67) JNE 18
v29 00013 (.../spillsink.go:70) INCQ  DX
v6  00014 (.../spillsink.go:71) CMPQ  DX, AX
b9  00015 (.../spillsink.go:71) JLT 8

v34 00016 (.../spillsink.go:76) MOVB  $0, "".~r1+24(SP)
b3  00017 (.../spillsink.go:76) RET
v26 00018 (.../spillsink.go:68) MOVB  $1, "".~r1+24(SP)
b8  00019 (.../spillsink.go:68) RET
v16 00020 (.../spillsink.go:67) PCDATA  $0, $1
v16 00021 (.../spillsink.go:67) CALL  runtime.panicindex(SB)
b11 00022 (.../spillsink.go:67) UNDEF
    00023 (<unknown line number>) END

This issue affects adding preemption checks to loops; the conditional call models the preemption check, which suffers the same extra load in the loop, and if the loop is tight it matters.
@randall77 @aclements

On f3 at least, I see what is going on.
When there is a call in the loop, we don't preload values into registers before jumping into the loop.  p.len is such a value.
see cmd/compile/internal/ssa/regalloc.go:1433-1443
		// If we are approaching a merge point and we are the primary
		// predecessor of it, find live values that we use soon after
		// the merge point and promote them to registers now.
		if len(b.Succs) == 1 {
			// For this to be worthwhile, the loop must have no calls in it.
			top := b.Succs[0].b
			loop := s.loopnest.b2l[top.ID]
			if loop == nil || loop.header != top || loop.containsCall {
				goto badloop
			}

The logic there is if there's a call in the loop, we're going to have to load the value inside the loop anyway.  No point in loading it before the loop starts as well.
This logic kinda falls down when the call is inside an if.  Maybe we should keep this optimization if there is a call-free path around the loop?
This isn't a problem for the pointer value, because it is modified during the loop.  It has a phi at the top of the loop that causes it to be allocated to a register.

I'm pretty sure that there's code (or there was code in some CL) that computed whether a loop contained a call-free path.  I could see if I could find that somewhere.

That would be great if that code existed somewhere.  I think just replacing containsCall with containsUnavoidableCall will do it.
Some branch hint information might be useful as well, maybe we ignore known unlikely paths when looking for a call, but likely (or unknown) paths count.  Then it isn't just a possible call-free path, but no non-unlikely call-full path.

Do we need to know the blocks that are in the call-free paths?  I couldn't find the code, but I'm pretty sure I can reconstitute it.

Nope.  We only need the info on block entry.  It would be enough to modify the semantics of the containsCall boolean.  I don't think it is used anywhere else.

Changed milestone because this was motivated by the preemptible loop changes, which are not appearing in 1.10.

@dr2chase  are you working on containsCall changes?
I've made a quick and dirty prototype to fix #22698 and I'd like to avoid effort duplication.

I am not working on that right now, I attempted something general and
didn't get it working.
Works for innermost loops is probably all we really need to get most of the
benefit.
On Thu, Nov 30, 2017 at 3:28 PM, Ilya Tocar<EMAIL_ADDRESS>wrote:

@dr2chase https://github.com/dr2chase are you working on containsCall
changes?
I've made a quick and dirty prototype to fix #22698
https://github.com/golang/go/issues/22698 and I'd like to avoid effort
duplication.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/22234#issuecomment-348311014, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB1vJ_SCSHX9S7u2ewlwKH2nlPlYUGyrks5s7w_zgaJpZM4P3STC
.

@dr2chase David, did you ever try to reconstitute your code?
@TocarIP  Ilya, do you think your CL is still the way forward?

I think Ilya's CL is the way forward. It is mostly there.  If he doesn't have time to get to it, I am happy to look into it in a few weeks if that delay is okay.  Right now I am working on debugging stuff.

No hurry, just want to make sure that something makes it into 1.11.  We've seen enough incarnations of this issue that we should fix it.

I was planing to work on it last week, however I'm currently having problems[1] with my google account, once they are resolved I will push updated version.
1<EMAIL_ADDRESS>has already been registered under a different account accessible by:
<EMAIL_ADDRESS>

@andybons, can you look into Ilya's Gerrit account problems?

I think my account was deleted and now I have new account with the same email. Now I see 2<EMAIL_ADDRESS>accounts at https://go-review.googlesource.com old one with all CL that I can't login into and new one that can login into, but can't +2/change my old CLs

On it. Filed internal bug.

@TocarIP OK you should be able to log in now.

@andybons  Thanks, it works now!

@TocarIP @randall77 should this still be a release blocker for 1.11?

This is fixed by Ilya's CL of March 20.


Pipify [do not merge: experiment]

Issue
In tandem with:

https://github.com/canonical/prometheus-k8s-operator/pull/444
https://github.com/canonical/avalanche-k8s-operator/pull/22

Solution

Context

Testing Instructions

Release Notes

JujuTopology seems to be implemented in __init__.py and juju_topology.py. It should be only in juju_topology.py and imported in __init__.py

This one is not a deal breaker by any means but I thought I would mention it anyway. I tend to not be a fan of names that have numbers in them like jo11y because they are annoying to type.

What is this empty file py.typed?
cfr

We should probably try to use a standard python library layout with the lib name as the source dir. So it would be something like
- README.md
- pyproject.toml
...
- jo11y
  - __init__.py
  - juju_topology.py
  ...

Also, this is on it's own branch so I would just put the files in placeholder where they properly belong so we can look at the resulting repo as it would look.

JujuTopology seems to be implemented in __init__.py and juju_topology.py. It should be only in juju_topology.py and imported in __init__.py

Not sure what you mean @dstathis

JujuTopology is implemented in juju_topology.py and __init__.py is an empty file, as prescribed.
As a result, the import statement is from jo11y.juju_topology import JujuTopology. What would you like to have?

I tend to not be a fan of names that have numbers in them like jo11y because they are annoying to type.

Yes, jo11y is annoying to type but it seems to me that the jolly + o11y reference is worth it. Wdyt?

We should probably try to use a standard python library layout

Agreed. I followed an official tutorial. I guess that's the recommended layout with hatchling.

CI is green and I think the experiment is complete.
After using our utils as a pypi pkg I agree it's more ergonomic for users and devs than fetch-lib charms.observability_libs.v0.jolly and from charms.observability_libs.v0.jolly import JujuTopology, CosTool.
Regarding polluting pypi with tightly coupled to ops, I'd be happy if we name it ops_jo11y or ops[jo11y].

Any idea @rbarry82 what could have changed between 639821e (which passed CI) and now?
(I'm having trouble with running the itests on the mac.)

I also can't run them on Linux because Lightkube expects to find a token that isn't there on this repo for some reason. No real changes that pop out at me, but I loosened the requirement checking (so at least it gets python-libjuju 3.0.4 instead of 3.0.0). When I'm on the other side of the Atlantic, I'll have more time to investigate.


Enable lto for rust

Please enable link time optimization in rust's Cargo.toml
[profile.release]
lto = true

Done! Got a nice little boost in all the stats, thanks for the suggestion!
The compile times weren't affected too much for me, so I imagine this is something most projects would leave on, at least initially, and only turn off once they got to a certain size? It seems "fair" or "realistic" to me to enable it here, and it's not just something for juicing the stats.

Yeah totally, I keep lto on (release profile only) for all my rust project, it also helps reduce the binary size.


Change WARNING: Image is flipped. Regenerate it using PVRTexTool

Since 3.1 you have to use flipped PVR textures (Took me quite a while to figure out...),
but when you use them you get a warning that's confusing:
CCTexturePVR.m:
if( flipped )
CCLOGWARN(@"cocos2d: WARNING: Image is flipped. Regenerate it using PVRTexTool");
This needs to be changed into the opposite:
if( !flipped )
CCLOGWARN(@"cocos2d: WARNING: Image is NOT flipped. Regenerate it using PVRTexTool");
This way I would have found the issue way earlier. So please think of other developers which will run into the same "strange" issues ;)

Edited warning in 3.5


About deprecating vszimg

Now vapoursynth(git) uses zimg(lib) as resized instead off swscale
then the vszimg is now deprecated?
greetings

Yes, vszimg ownership has been transferred to Myrsloik. The subresizing extension may remain in-tree, but it has not been decided.

deleted


undocumented net.Socket readable event and read method?

Hi,
Great work here!
And I'm just curious when read somewhere in your src that like:
	socket.on('readable', function () {
		that.doRead()
	})
...
Connection.prototype.doRead = function () {
	var buffer, temp

	// Fetches the data
	buffer = this.socket.read()
...

But I digged NodeJS api docs up to 0.10, there's no such event as readable and method as read documented. I'm curious whether they are legacies or just undocumented artifacts.
Don't know if its proper to ask the question as an issue, you're free to close it.
Regards & thanks,
Compl

Hi @complyue
It's arguably hard to find in the docs, but net.Socket extends stream.Duplex, that extends both stream.Writable and stream.Readable. Both 'readable' event and read() method are defined (and document) in the readable stream.

This object is an abstraction of a TCP or local socket. net.Socket instances implement a duplex Stream interface.
https://nodejs.org/api/net.html#net_class_net_socket

That's more of a Node.js question, help forums (like https://github.com/nodejs/help) are more suitable for this kind of issue ;)

@sitegui Thanks very much for the direction.


fix(orchestrator): make the port config optional

https://issues.redhat.com/browse/KOGITO-9966

The default value in the comment should be 80 not 8080. I've updated the comment. Please take a final look @masayag

The default value in the comment should be no port not 8080. I've updated the comment (here as well).

Now it is good to go 😄


add unix socket support on server side

Coverage remained the same at ?% when pulling 5b2ee506424d8c5ca3d277f16a7cd26a78e10238 on maskedeken:master into 9f2ff06ec8707550d3eaf33e33de2f796b95458d on xtaci:master.

Coverage remained the same at ?% when pulling 5b2ee506424d8c5ca3d277f16a7cd26a78e10238 on maskedeken:master into 9f2ff06ec8707550d3eaf33e33de2f796b95458d on xtaci:master.

Coverage remained the same at ?% when pulling 5b2ee506424d8c5ca3d277f16a7cd26a78e10238 on maskedeken:master into 9f2ff06ec8707550d3eaf33e33de2f796b95458d on xtaci:master.

Could you tell me under what circumstances this might be used?

Could you tell me under what circumstances this might be used?

Some services like v2ray could serve as a unix socket, which is hiding the listening port on a censored system like AliCloud

why not just listen on <IP_ADDRESS>?

why not just listen on <IP_ADDRESS>?

besides, unix socket is faster than tcp socket.
UNIX domain sockets know that they’re executing on the same system, so they can avoid some checks and operations (like routing); which makes them faster and lighter than IP sockets. So if you plan to communicate with processes on the same host, this is a better option than IP sockets.

how about re-try scheme? like:
var c conn
if c, err := net.Dial("tcp", xxx) err ==nil{
} else if c, err := net.Dial("unix", xxx);err==nil{
}

then we dont' have to specify unix://

any comment?

any comment?

I don't think that's a good idea. using try/catch as if/else is a bad practice.

https://github.com/xtaci/kcptun/blob/master/server/main.go#L57-L66

or, we can just try parse target to IP address and Port

or, we can just try parse target to IP address and Port

if you don't like the unix:// prefix, error checking is the only way to dial the right conn

	// check if target is unix domain socket
	var isUnix bool
	if _, _, err := net.SplitHostPort(config.Target); err != nil {
		isUnix = true
	}

a simple check, though not strict

	// check if target is unix domain socket
	var isUnix bool
	if _, _, err := net.SplitHostPort(config.Target); err != nil {
		isUnix = true
	}

a simple check, though not strict

Great


move error handler out of index

This is so it doesn't break browser builds and React Native due to the path module. This will be a breaking change and the tests need to be updated still.

Let's also not forget to update the generator.

And feathers-memory. We should probably update all the other modules that depend on this but I'm hoping greenkeeper will help us out there.

We'll need to release as a major version and we also need to update the docs. I've got the doc changes local ready to be pushed.

We should also add a middleware.js file in the root level that re-exports the handler so that you can do require('feathers-errors/middleware').

@daffl you can just do require('feathers-errors/handler'). I didn't want to just call it middleware in case we end up adding some other middleware in here for some reason in the future.

Ah I got what you were after. Good catch. This is why we do peer reviews :wink:


Task : Make a nav bar at home page

nav Bar should be sticky
logout option should be in nav bar
left sike there should be logo (add dummy for now)
and at right there should be 3 option (  1-home, 2- preview, 3-custumize )

Hey, I would like to work on this.

Yep you can start working on it !
For issue you can connect here : https://discord.gg/6Gtd7sheEe

@KaranSinghBisht are you working ? how much you done ?
@kritiag20  If @KaranSinghBisht Do no respond till yesterday I will assign it to you !

@kritiag20 you Can start working

can you assign it to me ? @kunal-umap


More prominent featured section at top of homepage

Idea from the marketing team:
even a more prominent way to feature content on homepage, especially when not signed in.
When signed in - we need to decide if this should still happen below following (may look out of place).
The data would come from homepages - probably a separate category with just pinned content claim ids
this could also potentially be used to feature prominent livestreams automatically (i.e. categorized outside of news + x viewers) - will file a separate issue for this also.

This will happen with the portals implementation, and also allow homepage customization for everyone.
Since we'll be putting this front and center, make it really easy for someone to hide this section when we roll out.


Expand $aDemoSuite and revise code that launches demo functions

See #155

@mlipok Please review these changes

I was trying to add code to yours mod
https://github.com/Danp2/WebDriver/pull/158
But something went wrong.
I was not intended to do separate PR but submit to this particular one.


Failed to install cross-compiler

Failed to install cross-compiler
I have tried multiple versions of the installation, and I get similar errors when I execute make all-target-libgcc . Desperately hoping to get some help
Operating environment:
operating system: ubuntu 20.04
binutils version: binutils-2.38
gcc version: gcc-11.2.0
gcc version installed by ubuntu: gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04)

Error message when executing make all-target-libgcc
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/***/Downloads/tmp/src/gcc-build/fixincludes'
make[1]: Entering directory '/home/***/Downloads/tmp/src/gcc-build/gcc'
make[1]: Leaving directory '/home/***/Downloads/tmp/src/gcc-build/gcc'
Checking multilib configuration for libgcc...
Configuring in i386-elf/libgcc
configure: loading cache ./config.cache
checking build system type... x86_64-pc-linux-gnu
checking host system type... i386-pc-elf
checking for --enable-version-specific-runtime-libs... no
checking for a BSD-compatible install... /usr/bin/install -c
checking for gawk... gawk
checking for i386-elf-ar... i386-elf-ar
checking for i386-elf-lipo... i386-elf-lipo
checking for i386-elf-nm... /home/***/Downloads/tmp/src/gcc-build/./gcc/nm
checking for i386-elf-ranlib... i386-elf-ranlib
checking for i386-elf-strip... i386-elf-strip
checking whether ln -s works... yes
checking for i386-elf-gcc...  /home/***/Downloads/tmp/src/gcc-build/./gcc/xgcc -B/home/***/Downloads/tmp/src/gcc-build/./gcc/ -B/usr/local/i386elfgcc/i386-elf/bin/ -B/usr/local/i386elfgcc/i386-elf/lib/ -isystem /usr/local/i386elfgcc/i386-elf/include -isystem /usr/local/i386elfgcc/i386-elf/sys-include
checking for suffix of object files... configure: error: in `/home/***/Downloads/tmp/src/gcc-build/i386-elf/libgcc':
configure: error: cannot compute suffix of object files: cannot compile
See `config.log' for more details
make: *** [Makefile:13958: configure-target-libgcc] Error 1

config.log
xgcc: error: unrecognized command-line option '-qversion'; did you mean '--version'?
xgcc: fatal error: no input files
compilation terminated.
configure:3546: $? = 1
configure:3562:  /home/***/Downloads/tmp/src/gcc-build/./gcc/xgcc -B/home/***/Downloads/tmp/src/gcc-build/./gcc/ -B/usr/local/i386elfgcc/i386-elf/bin/ -B/usr/local/i386elfgcc/i386-elf/lib/ -isystem /usr/local/i386elfgcc/i386-elf/include -isystem /usr/local/i386elfgcc/i386-elf/sys-include    -o conftest -g -O2   conftest.c  >&5
conftest.c:9:10: fatal error: stdio.h: No such file or directory
    9 | #include <stdio.h>
      |          ^~~~~~~~~
compilation terminated.
configure:3565: $? = 1
configure:3778: checking for suffix of object files
configure:3800:  /home/***/Downloads/tmp/src/gcc-build/./gcc/xgcc -B/home/***/Downloads/tmp/src/gcc-build/./gcc/ -B/usr/local/i386elfgcc/i386-elf/bin/ -B/usr/local/i386elfgcc/i386-elf/lib/ -isystem /usr/local/i386elfgcc/i386-elf/include -isystem /usr/local/i386elfgcc/i386-elf/sys-include    -c -g -O2  conftest.c >&5
/home/***/Downloads/tmp/src/gcc-build/./gcc/as: 106: exec: -o: not found
configure:3804: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "GNU C Runtime Library"
| #define PACKAGE_TARNAME "libgcc"
| #define PACKAGE_VERSION "1.0"
| #define PACKAGE_STRING "GNU C Runtime Library 1.0"
| #define PACKAGE_BUGREPORT ""

I am also getting this same error

I see you're trying to compile GCC 11.2.0 wit GCC 9. Have you tried installing a newer version on Ubuntu or compiling an older version?

I see you're trying to compile GCC 11.2.0 wit GCC 9. Have you tried installing a newer version on Ubuntu or compiling an older version?

binutils

I initially tried the old version of gcc, but I failed to install the gcc dependencies (./contrib/download_prerequisites), then I tried the latest version of gcc, and the following problems occurred.
I tried to install the cross compiler on another host with the same environment, and I succeeded. Perhaps my previous failed installation process caused some unknown impact on the system environment

Operating environment

I haven't found the reason why my installation failed. But I successfully installed it on another host, and now I can be sure that this operating environment can be installed successfully.

I haven't found the reason why my installation failed. But I successfully installed it on another host, and now I can be sure that this operating environment can be installed successfully.

I haven't found the reason why my installation failed. But I successfully installed it on another host, and now I can be sure that this operating environment can be installed successfully.


Support remove using directive actions inside namespace block

Related issue
Some developers choose to write using directives inside the namespace block, and we are not applying our remove actions for those situations.
Closes: #ISSUE_NUMBER_HERE
Description

We need to handle removing using directive actions in both CompilationUnit and inside Namespace.
Regarding add using directives, we are only adding them inside CompilationUnit as our convention.

Supplemental testing
Added unit tests to cover the changes in this PR.
Adjusted the build error count based on below changes by updating our BuidableWebApi project at https://github.com/marknfawaz/TestProjects for the test case:
namespace BuildableWebApi.Controllers {     using System.Web.Http;     using System.Web.Http.OData; }
And this project is covered in our test cases.
Additional context
Please provide any additional information related to this PR

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can we add a tests to verify these actions work as intended? It would also highlight the cons referenced on src/CTA.Rules.RuleFiles/RulesFileParser.cs, line 463

@jonlouie, thanks for catching those comments. I have updated it so they are not confusing. Basically I am only supporting Remove using directives inside the namespace block, so there is no Cons with this approach any more.
Regarding the test cases, it's added with the PR here: https://github.com/marknfawaz/TestProjects/pull/71

@jonlouie The test cases were added, please let me know if anything else is needed.


Make VersionSet readable in the logs.

Make VersionSet readable in the logs.
Move the formatting logic to ServerUtils.

Pull Request Test Coverage Report for Build 6170

7 of 8 (87.5%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.02%) to 44.781%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

azkaban-exec-server/src/main/java/azkaban/container/FlowContainer.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

azkaban-common/src/main/java/azkaban/executor/ExecutableFlowBase.java
1
87.64%

azkaban-exec-server/src/main/java/azkaban/execapp/event/FlowWatcher.java
1
93.75%

Totals

Change from base Build 6169:
0.02%

Covered Lines:
17250

Relevant Lines:
38521

💛  - Coveralls


Add sqlServerSchema command in data migration

The PR is to add new CLI commands "az datamigration sql-server-schema". The same command for Powershell has been published. The new CLI commands has passed local tests.
The local test commands:
az datamigration sql-server-schema --action "MigrateSchema" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password="
az datamigration sql-server-schema --action "GenerateScript" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --output-folder "C:\OutputFolder"
az datamigration sql-server-schema --action "GenerateScript" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --input-script-file-path "C:\OutputFolder\script.sql"
az datamigration sql-server-schema --config-file-path "C:\configfile.json"
I am from the service team.

Thank you for your contribution! We will review the pull request and get back to you soon.

Please add tests for new command

Thanks for reviewing @evelyn-ys , Is my local test good enough?
I did local CLI test for the new command. Below are test results ( I removed the actual value of user name and password)
Test 1: az datamigration sql-server-schema --action "MigrateSchema" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password="
Result :
Starting schema migration...
Total number of object collected: 35
Total elapsed time: 00:00:06.9587061
DDL triggers: 4
Full text catalogs: 2
Plan guides: 2
Roles: 1
Schemas: 5
Stored procedures: 5
Tables: 10
User defined functions: 4
Users: 2
The number of scripted objects: 55
Progress: 100%
Total elapsed time: 00:00:39.5761905
The number of deployed script batches: 110/110
Progress: 100%
Total elapsed time: 00:00:06.0982252
The event and error logs folder path: C:\Users\XXX\AppData\Local\Microsoft\SqlSchemaMigration
Finishing schema migration.
Test 2: az datamigration sql-server-schema --action "GenerateScript" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --output-folder "C:\OutputFolder"
The generated TSQL schema script folder path: C:\OutputFolder\SchemaScript-20230606.sql
The event and error logs folder path: C:\Users\XXX\AppData\Local\Microsoft\SqlSchemaMigration
Finishing schema script generation.
Test 3: az datamigration sql-server-schema --action "DeploySchema" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --input-script-file-path "C:\OutputFolder\script.sql"
Result:
Starting schema deployment...
The number of deployed script batches: 110/110
Progress: 100%
Total elapsed time: 00:00:05.6998954
The event and error logs folder path: C:\Users\XXX\AppData\Local\Microsoft\SqlSchemaMigration
Finishing schema deployment.
Test 4: az datamigration sql-server-schema --config-file-path "C:\configfile.json"
Result:
Run through the provided config file:
Starting schema script generation...
Total number of object collected: 35
Total elapsed time: 00:00:07.3111221
DDL triggers: 4
Full text catalogs: 2
Plan guides: 2
Roles: 1
Schemas: 5
Stored procedures: 5
Tables: 10
User defined functions: 4
Users: 2
The number of scripted objects: 55
Progress: 100%
Total elapsed time: 00:00:38.2304043
The generated TSQL schema script folder path: C:\Users\yaly.REDMOND\AppData\Local\Microsoft\SqlSchemaMigration\SchemaScript-20230606.sql
The event and error logs folder path: C:\Users\XXX\AppData\Local\Microsoft\SqlSchemaMigration
Finishing schema script generation.
Test 5: az datamigration sql-server-schema --action "D2eploySchema" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --output-folder "C:\OutputFolder"
Result:
az datamigration sql-server-schema: 'D2eploySchema' is not a valid value for '--action'. Allowed values: MigrateSchema, GenerateScript, DeploySchema.
Did you mean 'DeploySchema' ?
Examples from AI knowledge base:
az datamigration sql-server-schema --action "GenerateScript" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --input-script-file-path "C:\OutputFolder\script.sql"
Run Deploy TSQL script to the target Azure SQL Database using Parameters.
az datamigration sql-server-schema --action "MigrateSchema" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password="
Run Migrate database objects from the source SQL Server to the target Azure SQL Database using Parameters.
az datamigration sql-server-schema --action "GenerateScript" --src-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --tgt-sql-connection-str "Server=;Initial Catalog=;User ID=;Password=" --output-folder "C:\OutputFolder"
Run Generate TSQL schema script from the source SQL Server using Parameters.
https://aka.ms/cli_ref
Read more about the command in reference docs

Why don't you add your local test in azext_datamigration/manual/tests/latest/test_datamigration_scenario.py or azext_datamigration/tests/latest/test_datamigration_scenario.py?

I do not see previous customized commands added the test there.
For this new command, in my local test, my local machine needs to have connections to a source sql server and a target sql server. With the connection strings to both source and target, the command can do the migration work.
In this case, I think it will be hard to add the integration tests in pipeline?


Allow multiple services to be stopped with the same command

Background & motivation
Currently I can not stop more than one service at a time:
kurtosis service stop pristine-bay testnet-verifier prelaunch-data-generator-cl-genesis-data
Error:  accepts between 2 and 2 arg(s), received 3

Desired behaviour
I should be able to stop as many services as I want with the same command.
Also autocomplete the different services (that are not yet stopped).
How important is this to you?
Nice to have; this feature would make using Kurtosis more enjoyable.

I would like to work on this

Thanks @ericobi ! It should be a very small change - just making the arg greedy

Hey @ericobi , just wanted to follow up if you had a chance to look at this!

@ericobi - hi did you have a chance to take a look at this?


replace port 8000 to the default one and add gossip and stream ports

Replacing the 8000 to use the default port for Mattermost, with that we don't need to change the configuration and make it more standard with other apps
this was a question from Christopher and I already thought on that, and it makes sense to use the default one because in the host you can select any port.
cc
@pichouk @crspeller @jwilander

LGTM but as we discussed with @jasonblais the last time we introduced a breaking change, we need to also inform users in the Mattermost official changelog (see the previous example).
@cpanato are you able to push a message to the Mattermost 5.4 changelog or is it too late ?

we can merge it for 5.5 and make the announcement on 5.5

Ok, I'll upgrade the repository to 5.4.0 in few minutes.
I keep this PR for 5.5 and we will make all announcement we need prior the 5.5 release :)

sure @pichouk i will post in the docker channel as well

ok @pichouk updated the readme for 5.5.0
@jasonblais can we include a note in the release notes for the docker image? similar to this one? https://github.com/mattermost/docs/pull/1945/files

We can add a note for 5.5.
Why are we making the breaking change? Could we have timed it with a major version release (e.g. v6.0)

Discussed with @jasonblais in pre-release.
We will hold this change until we release version 6.0.0

Going to close this because we have no idea when 6.0 will happen. @cpanato Can you make sure there is a 6.0 ticket that links to this PR?

Created a ticket here with a note on v6.0 release https://mattermost.atlassian.net/browse/MM-13614


add a Java 8 lamdba interface for chaining assertions easier?

so imagine you've some generated assertion classes which are deeply nested like discussed here so you have some assertions like...
assertThat(foo).bar().whatnot().cheese().isNotNull();
assertThat(foo).bar().whatnot().beer().isEqualTo("Stella");
assertThat(foo).bar().whatnot().wine().isEqualTo("Shiraz");

there's some duplication. Now our IDEs can refactor those expressions to variables...
WhatnotAssert whatnot = assertThat(foo).bar().whatnot();
whatnot.cheese().isNotNull();
whatnot.beer().isEqualTo("Stella");
whatnot.wine().isEqualTo("Shiraz");

but I wonder if Java 8 lambdas could be used to make an XPath like variable/predicate chain via a single new method on AbstractAssert?
assertThat(foo).bar().whatnot().with(whatnot -> {
  whatnot.cheese().isNotNull();
  whatnot.beer().isEqualTo("Stella");
  whatnot.wine().isEqualTo("Shiraz");
});

The nice thing is the type inference to avoid the noise of the actual types of the assert classes; so the code feels cleaner yet is nice and DRY.
Not 100% sure on the name of the function; used with could be assert or something? Basically it just invokes the lamda with the current assertion object really ;).
Thoughts? Happy to submit a PR you think its a good idea

Actually a corollary to that is it might be handy to add a foreach method to NavigationListAssert to be able to add assertions to all elements in a list:
assertThat(foo).bar().vehicles().foreach(vehicle -> vehicle.brand().isNotNull());

We have something alike to verify multiple assertions for  Optional values, to be consistent I would use:
assertThat(whatnot).satisfies(whatnot -> {
  whatnot.cheese().isNotNull();
  whatnot.beer().isEqualTo("Stella");
  whatnot.wine().isEqualTo("Shiraz");
});


A bit of coding

Describe your problem here.
I need help because when I put more than one of the same thing (I don't know the name for it) they cancel each other out, even when I use different functions for each of them, and I don't know how to make all four note tweens work at the same time currently only one works and that is the last one I put in.
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Not in the source files, only lua.

Show us the code

Show us the code

It's a thing that has happened to me multiple times where you put something like "noteTweenY(move, 0, 300, 0.5, linear)" and
"noteTweenY(move, 1, 300, 0.5, linear)" and it just breaks and only does one tween, it could e because of the tag, but I don't know as I am still inexperienced in coding.

Calling this function will cancel another tween that is using the same tag!

It's stated on the wiki, multiple times

It's stated on the wiki, multiple times

Where, I don't really check anywhere but the pages with actual functions and variables, so I probably missed it.

Then again I haven't really messed with tweens ever so

It's stated on the wiki, multiple times

I tried changing the tags to different ones, but it didn't work

I should say, I'm using 0.6.2.

send the script

send the script

It's just more than one of this function noteTweenY(tag:String, note:Int, value:Dynamic, duration:Float, ease:String) being used when the opponent hits a certain note


How to run a UDF on vector cube to access geometry?

We're trying to support/implement a use case that depends heavily on vector cube manipulation, in particular running some custom (Python) UDF on the geometry data.
For example some (GeoJSON) feature collection manipulation use cases that are straightforward to implement the classic way, outside the openEO framework:

filter out features, based on geometry (area, location) and/or properties
add properties (in GeoJSON sense) to the features, based on geometry and or existing properties, using third party library, tool or service (e.g. lookup of population for a geometry or country code property)

How should these be implemented with openEO processes?
Note that with vector cubes, a lot of the relevant data to work with is in the labels (geometry data), which is quite different compared to how we typically work with raster data  cubes

I don't quite get the question @jdries:

For x,y the labels are the x/y part respecively of the coordinate
For t the labels are (usually) the RFC3339 timestamps
For the bands the labels are the band names
For the geometries we agreed on WKT of the geometry

See https://openeo.org/documentation/1.0/datacubes.html#dimensions for details/examples.

Yes, but the question is how to get to those labels from within a callback passed to apply_dimension:

apply_dimension(cube,dimension='bands',process=my_callback)

This passes on a labeled array to my process, where the labels of the array will be band names, but what if I in addition need to know the single geometry label? (So the WKT string, for that labeled array.)

You could get all WKT strings for each array element using array_labels: https://processes.openeo.org/#array_labels

What single label of a geometry dimension? I don't get what you are looking for... Could you explain the use case a bit more?


APA PDF weird render

Hello, the figure caption for an image is rendering like this by default and I'm not sure why

Can also provide an example if needed

Just following up on this one in case it was missed. It's still cutting off half the caption when using the following markdown syntax for the apaquarto-pdf output option

Sure, can you send the code that produces this error? Email is fine if you don't want to post it here<EMAIL_ADDRESS>

Can do! I've sent you an email. Thanks!

Also, if you run the files I sent over but change the output to apaquarto-typst,you get the other issue I've been having where the cross referenced tables end up all in bold rather than just the header row

This, I think, is the same problem as in #83
For now, the workaround solution to set the after-caption-space option to 0pt. For example:
#| label: "tbl-descriptive-statistics"
#| echo: false
#| tbl-cap: "Summary Statistics"
#| after-caption-space: 0pt

library(tinytable)
tt(head(iris))

Let me know if this works for you.

Hi Joel,That might fix the issue if I can render the table that I’m inserting as an image with the traditional way. Is there a way to force the output to move that page to landscape so it’ll fit? Right now only half my table shows if I try to just print it as a table (it’s too wide)Best,Brier Gallihugh, M.SHe/Him/HisPsych Doctoral Candidate Eastern Michigan UniversityOn Oct 6, 2024, at 1:12 PM, W. Joel Schneider @.***> wrote:
This, I think, is the same problem as in #83
For now, the workaround solution to set the after-caption-space option to 0pt. For example:
#| label: "tbl-descriptive-statistics"
#| echo: false
#| tbl-cap: "Summary Statistics"
#| after-caption-space: 0pt
library(tinytable)
tt(head(iris))
Let me know if this works for you.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

If you install Quarto 1.6 (pre-release), you can have landscape pages:
https://prerelease.quarto.org/docs/authoring/article-layout.html#landscape-mode


Respect --cache-dir and other flags when auditing project directories

Fixes #299.

Confirmed locally that pip-audit --cache-dir=/tmp/test . now works as expected.

Yep. I realized that the only place it was being used was in the CI and that it wasn’t much better of a UX than directly running the command from within the virtual environment. But I can revert that, if you were using it locally!
Sent from mobile. Please excuse my brevity.

On Jun 14, 2022, at 6:16 PM, Alex Cameron @.***> wrote:

@tetsuo-cpp approved this pull request.
LGTM!
In Makefile:

.PHONY: all
all:
@echo "Run my targets individually!"

-.PHONY: run
What's happening here? I see make run is getting removed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.

Yep. I realized that the only place it was being used was in the CI and that it wasn’t much better of a UX than directly running the command from within the virtual environment. But I can revert that, if you were using it locally! Sent from mobile. Please excuse my brevity.
…
On Jun 14, 2022, at 6:16 PM, Alex Cameron @.***> wrote:  @tetsuo-cpp approved this pull request. LGTM! In Makefile: > .PHONY: all all: @echo "Run my targets individually!" -.PHONY: run What's happening here? I see make run is getting removed. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.

All good! I wasn't using it, just curious.


Please create a new release

Can we get a new release please? The current version of this gem on RubyGems.org is over 3 years old. A lot of new stuff has been added in that time, including the #remove_tag_from_subscriber method which I'd like to use.

@pelargir because I plan to host it on GitHub packages going forward.

Why would you opt to do that? Publishing on RubyGems which would enable anyone with the gem command installed to do a simple gem install convertkit-ruby to get your latest version.
Publishing to GitHub Packages requires everyone to do extra config just to install the gem, increasing the barrier to entry and making it less likely they actually use this gem.
You should at least update the README with guidance on how to pull the gem down from GitHub Packages. Currently, the README has conflicting information because it describes newer features like the #remove_tag_from_subscriber method but still instructs us to gem install convertkit-ruby which will pull down the version from 2016 that doesn't have this method yet.
Publishing to RubyGems is very easy. Why not do both?


Change TabBar and its BarButtonItems colors.

Might be very useful to be able to change the TabBar and all its BarButtonColors, to make the Picker in line with the app overall style.
Thank you 🤗

Hello, i did it easily on YPMenuItem.swift
Just change your colors on functions: selectedColor() and unselectedColor()

The colors struct in the config file now enables you to customize the colours :)


Fixing docs build due to a spring cloud stream modules reference

Build with -Pfull fails due to a reference to spring cloud stream modules docs zip file.
Resolves #104

already fixed via 75749eff36dfd38cea87d01f087ea3d23ba1eaa9
CI for docker is green.


TypeError: Cannot read property 'mapping' of null

Hello, this is the first issue that I do, first of all I would like to thank the amazing and brilliant work that has been done for the development of this library. It is a very powerful library and it has somehow saved me.
Description of the bug
I am currently using the prosemirror editor together with Yjs in an application made in React. In this application I have developed my own component that creates a tiptap editor (uses prosemirror, I was guided by the examples recommended in the documentation), this since I need to be able to add and remove editors dynamically. The error occurs on line 127 of the file "cursors-plugin.js" of the library "y-prosemirror" located in "[...]/node_modules/y-prosemirror/src/plugins/cursor-plugin.js: 127". And it happens when a user adds a new editor (input) while another user is editing in another editor (input).
To reproduce
Due to the context, it is a case that is perhaps difficult to reproduce, however broadly the steps to reproduce the behavior are:

Create a project in React.
Create a context that stores the y-document and provider.
Create a component that instantiates a new TipTap editor in the document.
Generate for each element of an array (it can be an array with numbers) a component (the one that was created previously).
Create a button to add a new element to the array.
Open two tabs in the browser.
In a tab, leave the cursor inside one of the editors already created according to the array.
In the other tab, press the button that adds a new element to the array.
See the error in the console.

Expected behavior
The desired behavior is that if a user is editing a field and another user adds a new element to an array (thus a new editor is generated), the application does not break and that user who was editing a field can continue editing it.
Screenshots

Environment Information

Browser: Chrome.
Back-end: Node.js v12.18.3
The dependencies used in this project are:
"dependencies": {
"@material-ui/core": "^4.11.3",
"@material-ui/icons": "^4.11.2",
"@material-ui/lab": "^4.0.0-alpha.57",
"@testing-library/jest-dom": "^5.11.9",
"@testing-library/react": "^11.2.3",
"@testing-library/user-event": "^12.6.2",
"@tiptap/core": "^2.0.0-beta.5",
"@tiptap/extension-character-count": "^2.0.0-beta.1",
"@tiptap/extension-collaboration": "^2.0.0-beta.4",
"@tiptap/extension-collaboration-cursor": "^2.0.0-beta.4",
"@tiptap/extension-document": "^2.0.0-beta.1",
"@tiptap/extension-paragraph": "^2.0.0-beta.1",
"@tiptap/extension-text": "^2.0.0-beta.1",
"@tiptap/react": "^2.0.0-beta.4",
"@tiptap/starter-kit": "^2.0.0-beta.4",
"chart.js": "^2.9.4",
"query-string": "^6.14.0",
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-indiana-drag-scroll": "^1.8.0",
"react-query": "^3.6.0",
"react-router-dom": "^5.2.0",
"react-scripts": "4.0.1",
"socket.io-client": "^3.1.1",
"web-vitals": "^0.2.4",
"y-websocket": "^1.3.11",
"yjs": "^13.5.3"
},

Proposed Solution
The solution that worked for me has been to change line 127 of the file "[...]/node_modules/y-prosemirror/src/plugins/cursor-plugin.js" which was like this:
} else if (current.cursor != null && relativePositionToAbsolutePosition (ystate.doc, ystate.type, Y.createRelativePositionFromJSON (current.cursor.anchor), ystate.binding.mapping) !== null) {
Adding the validation "ystate.binding!= Null":
} else if (current.cursor != null && ystate.binding != null && relativePositionToAbsolutePosition (ystate.doc, ystate.type, Y.createRelativePositionFromJSON (current.cursor.anchor), ystate.binding.mapping) !== null) {
However, I would like to have an answer or opinion as to whether what I just did is okay or not. Thank you very much in advance for your time.

Has anyone got a fix for this?


Is it appropriate to use FAST.Farm version 3.2.0 for conducting fatigue analysis?

Dear @jjonkman,
I am using FAST.Farm version 3.2.0 to conduct many simulations with turbulent wind profiles generated by TurbSim, followed by MLife to compare the fatigue loads among different wake conditions for a downstream turbine: fully waked, partially waked, and non-waked. Today, I noticed that in the abstract of your newly published paper, "Development and Verification of an Improved Wake-Added Turbulence Model in FAST.Farm," you mentioned, "Previous studies hypothesized that the lack of WAT modeling was the source of underprediction of fatigue loads, in particular for cases at low turbulence intensities and/or stable atmospheric boundary layers."
I am wondering if it is still appropriate to use FAST.Farm version 3.2.0 for conducting fatigue analysis. What if I only care about the relative differences? If not, has this new model been implemented in the most recent FAST.Farm version 3.5.3?
Best wishes,
Yue

Dear @niuyue321,
As stated in that paper, we've noted that FAST.Farm underpredicts fatigue damage of waked wind turbines for cases with low turbulence intensity and/or stable atmospheric boundary layers due to a lack of wake-added turbulence.  To put a number on that, I would say that we've seen FAST.Farm underpredict fatigue damage of waked turbines without wake-added turbulence when the ambient turbulence intensity is less than 10%.  For ambient turbulence intensity higher than 10%, wake-added turbulence is negligible.  So, whether older versions of FAST.Farm are "appropriate", depends on the conditions simulated.
Wake-added turbulence has been added to FAST.Farm through the following PR: https://github.com/OpenFAST/openfast/pull/2202, which will be first released in OpenFAST v4.0.
Best regards,

Dear @jjonkman,
I see. Thank you very much for your help; I really appreciate it!
Best regards,
Yue


[BUG] Megabyte sized log lines

Describe the bug
There are some very large log lines in propeller that look like this
{"json":{"exec_id":"mj9w6zkj55","ns":"asdf-development","res_ver":"300754394","routine":"worker-409","src":"executor.go:146","wf":"asdf:development:workflows.raw_data_wf.asdfWorkflow"},"level":"info","msg":"Workflow has failed. Error [code:\"USER:Unknown\" message:\"Traceback (most recent call last):\\n\\n      File \\\"/srv/service/venv/lib/python3.6/site-packages/flytekit/common/exceptions/scopes.py\\\", line 206, in user_entry_point\\n        return wrapped(*args, **kwargs)\\n      File \\\"/srv/service/current/workflows/......

which seems to be a repeat of another log line
Workflow has failed. Error [code:"USER:Unknown" message:"Traceback (most recent call last):\n\n      File \"/srv/service/venv/lib/python3.6/site-packages/flytekit/common/exceptions/scopes.py\", .......

These two log lines can get very big.  I think they both come from pkg/controller/workflow/executor.go:146.  I don't know why Kibana is repeating them but fixing this line will probably fix both.
Expected behavior
Human readable logs.
Should we add a limit to the logger itself?
Flyte component

[ ] Overall
[ ] Flyte Setup and Installation scripts
[ ] Flyte Documentation
[ ] Flyte communication (slack/email etc)
[x] FlytePropeller
[ ] FlyteIDL (Flyte specification language)
[ ] Flytekit (Python SDK)
[ ] FlyteAdmin (Control Plane service)
[ ] FlytePlugins
[ ] DataCatalog
[ ] FlyteStdlib (common libraries)
[ ] FlyteConsole (UI)
[ ] Other

To Reproduce
Steps to reproduce the behavior:

Use Spark
When you inevitably make a mistake, look at the logs.

Screenshots
Internal data - no screenshot.
Environment
Flyte component

[ ] Sandbox (local or on one machine)
[ ] Cloud hosted

[ ] AWS
[ ] GCP
[ ] Azure

[ ] Baremetal
[ ] Other

Additional context
NA

Adding the limit in the logger actually make sense... should it limit and fail the logger call? or truncate? truncate from the end or from the end or from the start?

truncate from the middle i think.  what should the limit be?  128KB?

128KB sounds so generous already... but yeah, let's go with that..

we should also remove the print statement

we should also remove the print statement

Triage: Won't fix


cea install-toolbox creates a folder instead of a file for "City Energy Analyst.pyt"

Somehow on all computers tested except mine, the cea install-toolbox command creates a folder and copies the file there. I need to figure out how to avoid that. See #571 for a user story that ran into this problem and how we solved it on his machine.

fixed in master.


[Enhancement] Optimize the performance of finding upper_bound and lower_bound of iceberg position delete

Fixes #issue
use set::lower_bound instead of std::lower_bound.
https://quick-bench.com/q/us41ChOFo0vT7WjjWl-w72eBb60
A user case can be shortened from 6 minutes to 5 seconds using this pr.
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

https://github.com/Mergifyio backport branch-3.1


active class is set twice, although it should just be set once

Problem is if I have 2 routes, where one route has the same route like another one just with some letters more and when I navigate to that one, both routes get the active class set.
Here in code:
First the place I define the routes
React.render((
  <Router history={history}>
      ...
      <Route path="portfolio/product" component={ Product } />
      <Route path="portfolio/productname" component={ Productname } />
      ...
  </Router>
), document.getElementById('app-container'));

and next the place I have a navigation, made with the Link Component
<Link to="portfolio/product">Product</Link>
<Link to="portfolio/productname">Productname</Link>

Since this are product names, I cant change the names there. Currently when I click on product only product gets the active class, but when I click on productname I get product and productname set as active

This is fixed in beta4.


Configure s3 in the containerized environment for file upload e2e tests

What this PR does / why we need it:
Adds S3 remote storage option using a bucket hosted on AWS.
Initially, I evaluated using localstack as in js-dataverse to avoid using AWS and to keep everything containerized. After encountering issues and limitations, I decided to use a remote S3 storage.
Which issue(s) this PR closes:

Closes #456

Special notes for your reviewer:
Now we need to create a .env under dev-env folder, by copying the .env.example file, and paste there the credentials for AWS. I will be happy to share them, just ping me on Slack. @ekraffmiller @ErykKul @GermanSaracca
The AWS secrets are already added to the repository for the GitHub actions to operate.
Suggestions on how to test this:
Run docker containers locally and verify you can create a dataverse on JSF using s3 storage.
You should be able to see s3 as a storage option for the new collection

Then, create a dataset in the new dataverse and verify that direct upload works on JSF.

coverage: 97.592%. remained the same
when pulling 9cfffff1c33824df67dc7386e27df29338192ddd on 456-localstack-s3-env
into 393e9269ebcd8ceb04504b2a389291df1bc46186 on develop.

@GermanSaracca @ErykKul @ekraffmiller
Thanks to Eryk's help, I've managed to set S3 as the default and unique storage option, so there's no need for the intermediate step of creating a dataverse with S3 storage. 🎉


#158580405 Adds default limit to menu controller

What does this PR do?
-Adds the default limit to menu controller
Description of Task to be completed?

modifies menu response

How should this be manually tested?
N/A
What are the relevant pivotal tracker stories?
#158580405
Any background context you want to add?
Screenshots

Pull Request Test Coverage Report for Build 121

2 of 3 (66.67%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.864%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/controller/menu.js
0
1
0.0%

Totals

Change from base Build 119:
0.0%

Covered Lines:
249

Relevant Lines:
271

💛  - Coveralls


fixed export issues for all project

fixed export for all the bible #719
@vipinpaul,
the problem I faced was getting a string in getSchema(), so I read the document and found that compile function takes an object.
video link: https://www.loom.com/share/e1fa84d4467a4277aee21e312c92f493

This PR doesn't have fix for the issue so closing the PR.


Can somebody teach me how to hack?!

i want to learn how to hack Instagram/Google/Facebook account! Did i come to the right place?!

I can teach you how to program, but not how to hack. If you’re talking
about real hacking and not script kiddie hacking, then it’s a skill that is
developed through programming.
On Thu, Feb 22, 2018 at 4:57 PM ZoroKissama<EMAIL_ADDRESS>wrote:

i want to learn how to hack Instagram/Google/Facebook account! Did i come
to the right place?!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Ethical-H4CK3R/Instagram/issues/26, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ATFT11h78XpikcWl45vKkAuXmkrVcqUiks5tXeK0gaJpZM4SQDUs
.

well, can u hack certain account for me please?
2018-02-22 23:07 GMT+01:00 Mohamed<EMAIL_ADDRESS>
I can teach you how to program, but not how to hack. If you’re talking
about real hacking and not script kiddie hacking, then it’s a skill that is
developed through programming.
On Thu, Feb 22, 2018 at 4:57 PM ZoroKissama<EMAIL_ADDRESS>wrote:

i want to learn how to hack Instagram/Google/Facebook account! Did i come
to the right place?!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Ethical-H4CK3R/Instagram/issues/26, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/
ATFT11h78XpikcWl45vKkAuXmkrVcqUiks5tXeK0gaJpZM4SQDUs>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Ethical-H4CK3R/Instagram/issues/26#issuecomment-367838933,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjC3oSb5wkpef5tZ6HFERoCoIMjeyovQks5tXeUsgaJpZM4SQDUs
.

Hacking is not cool if you're doing it illegally, you can end up in jail. If you're going to hack, hack only when the person gives the permission, other than that just hack yourself.

well i know that "Akhi" all i want is learn how to hack it's not like i'm
going to hack an agency or something, just random account and it's not like
i'm going to sell these accounts or something
... x)
2018-02-22 23:31 GMT+01:00 Mohamed<EMAIL_ADDRESS>
Hacking is not cool if you're doing it illegally, you can end up in jail.
If you're going to hack, hack only when the person gives the permission,
other than that just hack yourself.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Ethical-H4CK3R/Instagram/issues/26#issuecomment-367845149,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjC3oYfBxngO-lciSzxwLf5AaVboBVedks5tXeqngaJpZM4SQDUs
.

@ZoroKissama Learn how to code lmao. Ethical-H4CK3R is not your personal army

How can i start
2018-02-25 8:51 GMT+01:00 Defalt<EMAIL_ADDRESS>
@ZoroKissama https://github.com/zorokissama Learn how to code lmao.
Ethical-H4CK3R is not your personal army
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ethical-H4CK3R/Instagram/issues/26#issuecomment-368290434,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjC3oYZoTh32Oj3DMwkPb6URJsRGBWA_ks5tYRD_gaJpZM4SQDUs
.

How can i start
Google, SoloLearn, Codeacademy, etc.

I recommend watching videos on sites like YouTube/Udemy, then writing a simple program that uses something you’ve learned from the video. Don’t do videos that says things like learn something in an hour or long videos, those never work. Instead watch videos that are broken into few minutes because the human can stay focused for more than ten minutes. Don’t do sites Codeacademy and Sololearn, they don’t work. When you start learning to are your own code start simple, don’t try to do something advanced or intermediate when you’re a beginner. Don’t do front end dev, it’s going to get extremely boring extremely fast, just do back end for now. And Finally never pay to learn to code; the payed content producers try too hard to make their content perfect and it becomes like normal school  - a failure. Free content producers teach better because they communicate with the student as a friend instead of a moron. Good luck, and  tell me every time you create a program, I want to see it.


[SPARK-22335][SQL] Clarify union behavior on Dataset of typed objects in the document

What changes were proposed in this pull request?
Seems that end users can be confused by the union's behavior on Dataset of typed objects. We can clarity it more in the document of union function.
How was this patch tested?
Only document change.

Test build #83029 has started for PR 19570 at commit eab627a.

Test build #83029 has finished for PR 19570 at commit eab627a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
   *   case class Test(a : String, b : String)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83029/
Test PASSed.

@HyukjinKwon Thanks for reviewing.

LGTM

Test build #83083 has started for PR 19570 at commit 2d0b8ae.

Test build #83083 has finished for PR 19570 at commit 2d0b8ae.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
   *   case class Test(a: String, b: String)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83083/
Test PASSed.

Test build #83143 has started for PR 19570 at commit 977c78e.

Test build #83143 has finished for PR 19570 at commit 977c78e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
   * this Scala example shows (using Scala case class for example, it is also applicable

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83143/
Test PASSed.

Merged build finished. Test PASSed.

Test build #83151 has started for PR 19570 at commit 1de4e13.

Test build #83151 has finished for PR 19570 at commit 1de4e13.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83151/
Test FAILed.

retest this please.

Test build #83157 has started for PR 19570 at commit 1de4e13.

Test build #83157 has finished for PR 19570 at commit 1de4e13.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83157/
Test FAILed.

retest this please.

Test build #83162 has started for PR 19570 at commit 1de4e13.

Test build #83162 has finished for PR 19570 at commit 1de4e13.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83162/
Test PASSed.

Merged to master.

Thanks @HyukjinKwon @gatorsmile


timeout_decorator.py use of signals not supported with windows

`Message: module 'signal' has no attribute 'SIGALRM'
https://stackoverflow.com/questions/52779920/why-is-signal-sigalrm-not-working-in-python-on-windows
Tried substituting wrapt_timeout_decorator fork but it doesn't support TimeoutError.

Bummer.  For the moment I suppose the workaround is to use the previous release in which timeout-decorator was not implemented.

@manalive  Would you be willing to try out this updated version of libbyfetch.py that attempts to fix this issue with timeout-decorator?  I created a branch in the repo for this issue.  As described in e061a6288867428e6fc3fdccd8ddf4b3cc5be428 I'm discarding the timeout-decorator approach and instead check for browser installation using shutil which is cross-platform.

@jdalbey Thank you for your quick reply! I tried it and shutil.which() keeps returning false. Things I tried:

changing the reference to chrome.exe / firefox.exe
explicitly adding the browser application folder to the system and user paths
explicitly adding the browser executables to the system and user paths
running the script as admin

I also used the following simplified script to see if it was just the libbyfetch.py script and got the same results:
`import shutil
def is_browser_installed_with_shutil(browser_name):
"""
Checks if the specified browser (Chrome or Firefox) is installed using shutil.which().
"""
# Define executable names for browsers
executable_name = None
if browser_name.lower() == "chrome":
executable_name = "chrome.exe"
elif browser_name.lower() == "firefox":
executable_name = "firefox.exe"
else:
raise ValueError("Unsupported browser name. Use 'chrome' or 'firefox'.")
# Use shutil.which to check if the executable is in the PATH
return shutil.which(executable_name) is not None

if name == "main":
# Check for Chrome
chrome_installed = is_browser_installed_with_shutil("chrome")
print(f"Chrome installed: {chrome_installed}")
# Check for Firefox
firefox_installed = is_browser_installed_with_shutil("firefox")
print(f"Firefox installed: {firefox_installed}")

`
I'm not a programmer, but I confirmed this sample an LLM spit out for me works:
`import os
import shutil
def is_browser_installed(browser_name):
"""
Checks if the specified browser (Chrome or Firefox) is installed.
First checks the PATH using shutil.which(), then checks default installation paths.
"""
# Define executable names for browsers
executable_name = None
if browser_name.lower() == "chrome":
executable_name = "chrome.exe"
elif browser_name.lower() == "firefox":
executable_name = "firefox.exe"
else:
raise ValueError("Unsupported browser name. Use 'chrome' or 'firefox'.")
# 1. Check if the executable is in the system's PATH
if shutil.which(executable_name):
    return True

# 2. Check default installation paths
default_paths = {
    "chrome": [
        os.path.expandvars(r"%ProgramFiles%\Google\Chrome\Application\chrome.exe"),
        os.path.expandvars(r"%ProgramFiles(x86)%\Google\Chrome\Application\chrome.exe")
    ],
    "firefox": [
        os.path.expandvars(r"%ProgramFiles%\Mozilla Firefox\firefox.exe"),
        os.path.expandvars(r"%ProgramFiles(x86)%\Mozilla Firefox\firefox.exe")
    ]
}

for path in default_paths.get(browser_name.lower(), []):
    if os.path.exists(path):
        return True

# If not found in PATH or default locations, return False
return False

if name == "main":
# Check for Chrome
chrome_installed = is_browser_installed("chrome")
print(f"Chrome installed: {chrome_installed}")
# Check for Firefox
firefox_installed = is_browser_installed("firefox")
print(f"Firefox installed: {firefox_installed}")

`
You could throw a patch check in for windows users.

@manalive Thanks for testing this out and the suggested code revisions.  I spent a little time playing with it and agree that this could work.  My big reservation is that I'm very reluctant to write custom code for different OSes.  In my experience it just leads to headaches down the road trying to maintain separate code for each platform.  So for now I'm just going to scrap the whole idea of fixing #18.  The prerequisites state that Chrome must be installed.  I was taught that if a prerequisite isn't met that the outcome is indeterminate; thus having the application hang is technically expected behavior.  :)   I'll just make a note in the FAQ about it.  Pragmatically most people will either have Chrome or be able to install it easily.  Logistically I have more important priority issues to focus on.

Fixed in 191a5642fb8ffb3eec1099d83088cd7f7324218f.  Removed timeout-decorator and reverted to omit check for installed browser.

The prerequisites state that Chrome must be installed. I was taught that if a prerequisite isn't met that the outcome is indeterminate; thus having the application hang is technically expected behavior. :)

Fair. Thanks!


display image in a template ejs

Hello !
I've got a problem to render a png in a email:
-image is in : public/img/picture.png
-my middleware express is ok with :
app.use(express.static(__dirname + '/public'));
-i'm using the ejs engine :
html.ejs

....some style and text
The email received is ok, exept the image which is doesn't inside...
any idea ?
thanks

and you should pass juice options to convert the image you pass using web inline resources options for juice CTRL/CMD+F (search) for juiceOptions mentioned in the Readme here https://github.com/crocodilejs/node-email-templates to see how you can pass options to juice.  you'll probably want to pass options that we do in CrocodileJS at https://github.com/crocodilejs/crocodile-node-mvc-framework/blob/development/src/jobs/index.js#L137-L142 - I actually don't use this package anymore, I use a similar setup to the link I just gave.  It's a bit easier to work with.  You should join us in Slack at http://slack.crocodilejs.com and we can help more


Ceedling does not recognize "/" in paths in Windows

I am running Ceedling in windows, sometimes. I have the GNU toolchain installed via MSYS2/MINGW64 and Ceedling installed using Ruby. I can run all of my unit tests in Ceedling with no problems if I define all of the source file dependencies using TEST_FILE() or if the header file is included for any source file dependencies with no forward slashes. However, if an absolute or relative path is used (i.e. #include "../someFolder/myHeader.h"), then Ceedling will not compile the source file associated with the header. When running in Linux it works fine in this case.

I have exactly the same problem. On Windows files included with path are not compiled.
They are also missing in the build/test/preprocess/includes files.

i found a workaround for me:
replacing these lines:
https://github.com/ThrowTheSwitch/Ceedling/blob/75698bdf4ffd26d9a3a84c18ea81d8f2bc7174ad/lib/ceedling/preprocessinator_includes_handler.rb#L365-L370
with:
    _nested.each_key do |filepath|
      filepath1 = filepath.dup
      filepath1.slice! "./"
      if _shallow.has_key?( filepath1 )
        common << filepath1         # Copy to common
        _shallow.delete(filepath1)  # Remove matching filepath from _shallow list
      end
    end

Because the path in the filepath variable have "./" as prefix and therefore don't match with _shallow where the path don't have "./" as prefix


[testonly] Reload data when user login, user logout, change language and change currency

When user login, user logout, change language and change currency, most of data should be reloaded. We create metaReducers in reducer/index.ts to listen to these kinds of actions. For examples, in ProductModule, we have this:
export function clearProductsState(
  reducer: ActionReducer<any>
): ActionReducer<any> {
  return function(state, action) {
    if (action.type === CURRENCY_CHANGE || action.type === LANGUAGE_CHANGE) {
      state = undefined;
    }
    return reducer(state, action);
  };
}

So, when context change or user login/logout, we clear state to its initial state. In the components, we have something like this:
    this.countries$ = this.userService.allDeliveryCountries$.pipe(
      tap(countries => {
        if (Object.keys(countries).length === 0) {
          this.userService.loadDeliveryCountries();
        }
      })
    );

In this example, if countries object is empty, then we will load countries data again. So, each time, we change language from address-form page, countries data is cleared from ngrx store, then data will be reloaded.
In this ticket, we will get to know:

When user login/logout, what data need to be cleared or reloaded (e.g. cms data need to be reloaded; user data need to be cleared when logout)
when change language/currency, what data need to be reloaded
for data which will be reloaded, how we will handle the reloading (clear data from ngrx store, then reload them from component? Or use some other ways to do this? we need discussion)

For point 3. "how we will handle the reloading" : I think we need another mechanism than to check is the data is empty because some data may legitimately be empty, even after loading it from the backend.  Therefore we need to find something else, like a "loaded" flag perhaps.

let's do a qa of this scenario and make sure everything is ok
talk to wei about what to look for

Found a case where the data wasn't reloaded:
https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/2202
Other than this, it looks ok. The only problem is that localization is missing in most places.


Done Button In Keyboard

Hi guys,
I am trying to look for a solution that is similar to this screenshot I have posted. I need a done button on top of the keyboard. The problem is that on a Multiline textfield I can't find a way to close the keyboard and access, for example, the TabBar.
I was wondering if there were some solutions to this or if the only way is to have a look at the native code.
I was also thinking that I could try to implement something that closes the keyboard when the textinput is tapped the second time, so if it's focused and you are tapping it again, the keyboard disappears.

Duplicate #641

Hi
We can do the focus on next textinput when user click on keyboard next button using refs property
Here is the demo
<TextInput
placeholder='Password'
ref='Password'
placeholderTextColor={'#e68a00'}
returnKeyType={ "next" }
style={{height: 40, borderColor: '#e68a00', borderWidth: 1,padding:10,marginTop:10,borderWidth:1,borderRadius:3}}
onSubmitEditing={(event) => {
this.refs.CPassword.focus();}}
onChangeText={(text) => this.setState({tv_name_placeHolderText1 : text})}
/>
<TextInput
placeholder='Confirm Password'
ref='CPassword'
onSubmitEditing={(event) => {
this.refs.PNumber.focus();}}
placeholderTextColor={'#e68a00'}
returnKeyType={ "next" }
style={{height: 40, borderColor: '#e68a00', borderWidth: 1,padding:10,marginTop:10,borderWidth:1,borderRadius:3}}
onChangeText={(text) => this.setState({tv_name_placeHolderText1 : text})}
/>


iOS 10 FCM code doesn't work (xCode 8.0 GM)

The code at the bottom of the FCMSwift/AppDelegate.swift for Messaging handling on iOS10 doesn't work. If i try to build or run my app I get a Swift Compiler Error:

Command failed due to signal: Segmentation fault: 11

If i remove that code i don't get that error.

I got the same error.

Yea I got the same. When I remove all ios10 code from demo, it works fine...

I've upgraded to Cocoa pod 1.0.1 and all seems to work.

I'm using Cocoa pod 1.0.1, XCode Version 8.0 (8A218a) and having this error Ambiguous reference to member 'subscript' on line print("Message ID: \(userInfo["gcm.message_id"]!)")

I'm not seeing that error in xcode 8.1, so the linting may be fixed in the latest version.

same here

This is solution.
To be able to receive notification when the app in background. You must implement this method in your AppDelegate
**- (void)userNotificationCenter:(UNUserNotificationCenter )center didReceiveNotificationResponse:(UNNotificationResponse )response withCompletionHandler:(nonnull void (^)())completionHandler
This is my code snippet that works:

(void)userNotificationCenter:(UNUserNotificationCenter *)center didReceiveNotificationResponse:(UNNotificationResponse *)response withCompletionHandler:(nonnull void (^)())completionHandler
{
// Print message ID.
NSDictionary *userInfo = response.notification.request.content.userInfo;
NSLog(@"Message ID: %@", userInfo[@"gcm.message_id"]);
NSString* strURL = userInfo[@"URL"];
NSString* strMessageTitle = [[[userInfo valueForKey:@"aps"] valueForKey:@"alert"] valueForKey:@"title"];
NSString* strMessage = [[[userInfo valueForKey:@"aps"] valueForKey:@"alert"] valueForKey:@"body"];
// Print full message.
NSLog(@"%@", userInfo);
}

Thanks @vinamelody ! It's work for me !

Updating Cocoapods to 1.0.1 doesn't fix this for me. Also the 8.1 beta doesn't fix the issue.

Still getting segfaults in XCode 8.1

Closing  on the basis of use_frameworks! and updated cocoapods. If people are still getting an issue, probably easiest to file a new one with explicit error you're seeing at this point.


skipping video download also skips non-video post-processing actions

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.04.01. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.04.01

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v --skip-download --write-sub --convert-subs srt --all-subs https://www.youtube.com/watch?v=sLEdi49XEhA
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'--skip-download', u'--write-sub', u'--convert-subs', u'srt', u'--all-subs', u'https://www.youtube.com/watch?v=sLEdi49XEhA']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.04.01
[debug] Python version 2.7.6 - Linux-3.13.0-83-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] sLEdi49XEhA: Downloading webpage
[youtube] sLEdi49XEhA: Downloading video info webpage
[youtube] sLEdi49XEhA: Extracting video information
[youtube] sLEdi49XEhA: Downloading MPD manifest
[info] Writing video subtitles to: The Beauty of the Dinner Scene-sLEdi49XEhA.en-US.vtt
[info] Writing video subtitles to: The Beauty of the Dinner Scene-sLEdi49XEhA.en.vtt

Description of your issue, suggested solution and other information
Using the --skip-download option seems to skip post-processing options, or at least the --convert-subs option.  The other post-processing options are related to the video, so it makes sense that they'd be skipped, but --skip-download is a handy feature for downloading subtitles but not the video (particularly for really large videos that you've already downloaded and don't want to download again), and post-processing options for the subtitles should be processed.
Either that, or for the sake of internal consistency, --skip-download should also skip downloading subtitles.  Perhaps the ability to download subtitles but not the video was an accidental feature?  Maybe --skip-download was always intended as a dry-run feature, to not download anything?  Personally though, I would prefer there be some way to download just the subtitles and post-process them.
In the example command above, the video has subtitles in vtt format.  Without the --skip-download option, the vtt subtitles are eventually converted to srt.  However with the --skip-download option, they're left as vtt.

Just following this because I have a bot that depends on the ability to have srt subtitles, but I have no use for the video (and I don't want to waste the bandwidth downloading the video). I would love to see this get fixed.

For now you can just call ffmpeg manually:
ffmpeg -i foo.vtt foo.srt

On 21 May 2016 07:06:28 CEST, Michael Hancock<EMAIL_ADDRESS>wrote:

Just following this because I have a bot that depends on the ability to
have srt subtitles, but I have no use for the video (and I don't want
to waste the bandwidth downloading the video). I would love to see this
get fixed.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rg3/youtube-dl/issues/9073#issuecomment-220758958

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

This bug is still a bug:
youtube-dl --ignore-config --write-sub --all-subs --sub-format "srt" --convert-subs "srt" --restrict-filenames --skip-download https://www.youtube.com/watch?v=uieM18rZdHY
It spits out the sub files in VTT, but doesn't convert them to SRT.

Is it possible to call the post-processing through an API call instead of running the command line?

A hacky approach is to create a file with the same name as the file to download and not specifying skip_download.

I have created a PR at #9738. Please help test it.

nyuszika7h mentioned "ffmpeg -i foo.vtt foo.srt"
Interestingly I discovered:

youtube-dl.exe --convert-subs srt --all-subs http://www.tg4.ie/en/player/home/?pid=5270396083001
[generic] ?pid=5270396083001: Requesting header
WARNING: Falling back on generic information extractor.
[generic] ?pid=5270396083001: Downloading webpage
[generic] ?pid=5270396083001: Extracting information
[download] Downloading playlist: EIPIC | Baile | Seinnteoir | TG4
[generic] playlist EIPIC | Baile | Seinnteoir | TG4: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[brightcove:new]<PHONE_NUMBER>001: Downloading webpage
[brightcove:new]<PHONE_NUMBER>001: Downloading JSON metadata
[brightcove:new]<PHONE_NUMBER>001: Downloading m3u8 information
[info] Writing video subtitles to: EIPIC - 4 Bea-5270396083001.en.vtt
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 198
[download] Destination: EIPIC - 4 Bea-5270396083001.mp4
[download] 100% of 513.23MiB in 01:43:02
WARNING:<PHONE_NUMBER>001: malformated aac bitstream. Install ffmpeg or avconv to fix this automatically.
[ffmpeg] Converting subtitles
ERROR: ffmpeg or avconv not found. Please install one.
So without an external program ffmpeg also installed, getting it to save something other than VTT doesn't work.
I have K-Lite Codec pack and Media Player Classic which has ffmpeg as a DLL file but it can't be run by any youtube-dl or any other external video downloader I've tried.

@NothingCanPlayVTT Cygwin and ffmpeg perhaps?

You don't need to use Cygwin. Just download Zeranoe's FFmpeg builds and put it in your PATH environment variable.

As of version 2<IP_ADDRESS>, this still happens:
$ youtube-dl --write-auto-sub --convert-subs=lrc --sub-lang=pt --skip-download -- xxxxxxxxxxx

[youtube] xxxxxxxxxxx: Downloading webpage
[youtube] xxxxxxxxxxx: Downloading video info webpage
[youtube] xxxxxxxxxxx: Extracting video information
[youtube] xxxxxxxxxxx: Looking for automatic captions
[youtube] xxxxxxxxxxx: Downloading MPD manifest
[youtube] xxxxxxxxxxx: Downloading MPD manifest
[info] Writing video subtitles to: video-title-xxxxxxxxxxx.pt.vtt

Subtitles are downloaded as vtt instead of lrc.

$ youtube-dl --version
2<IP_ADDRESS>


[Select one - other] Selecting different value doesn't hide/disable "Other" text

@justinkimtang FYI
@vittorino What is the correct behavior here when selecting / deselecting "other" radio button or entering "other" text?


Feat: Expose Architecture for Auth and Router on Aws

The sst.aws.Router and sst.aws.Auth do not expose the ability to specify the architecture as x86_64 or the arm64 like the option that is avaliable under sst.aws.Function. It would be nice if this were possible or if it could be set at the provider level versus on the individual construct.
Link for Function reference

For Auth, authenticator takes full function args:
{
  authenticator: {
    architecture: "arm64"
  }
}

Can u clarify for you are looking to set for sst.aws.Router? Lambda is not involved.

Ah, I was one key above for the authenticator architecture.
For the sst.aws.Router, I missed that CloudFront was being used to add routes. I assumed that Router will have a javascript implementation to allow it to function on AWS and Cloudflare versus just AWS.
In the future, will it be possible to set the architecture: at a provider level with the option to override for specific functions?

In the future, will it be possible to set the architecture: at a provider level with the option to override for specific functions?
like a way to set ie. architecture, timeout for all functions in the app?

Yes, exactly this.

Gotcha. It is on the roadmap. Let's track it here https://github.com/sst/ion/issues/103
Close this


fix create site if it doesn't exist

Please check if the PR fulfills these requirements

[ ] Followed the Contributing guidelines.
[ ] Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@christianllv or @cialese can you fix the linting error?

@jaredwray fixed.


PhysicalBone3D: expose sleeping state

It seems like PhysicalBone3D nodes support sleeping, but it wasn't possible to access this state unless going through the PhysicsServer3D directly, and even then it would miss the convenient "sleeping_state_changed" signal.
This commit exposes the sleeping state and adds the "sleeping_state_changed" by copying what's done for RigidBody3D.
Example project using the new APIs: ragdoll-sleep.zip (hit spacebar to reset the bones)

It is indeed strange that PhysicalBone3D can_sleep is true but there is no sleeping property. However, I am not sure if I should add a separate sleeping property.
Is there a reason not to add a sleeping property to PhysicsBody3D? Or maybe we should add an intermediate class like RigidableBody3D between RigidBody3D and PhysicsBody3D and add the sleeping property there.
So the decision requires the opinion of the physics team. cc @rburing

@TokageItLab I hear you as I also wondered if a refactoring was due.
But here's why I think this PR is fine as is:

This is my very first contribution to Godot, but also to a C++ project
I am not confident enough to carry on a refactor of Node classes
I submitted this contribution as it is something I need for my own projects
The refactoring can be deferred for when someone with more experience wants to tackle it

This change doesn't add much more debt for when the refactoring will happen: currently is just means there's a little code duplication, and it may actually help direct the effort when refactoring by showing where things need to be shared.

Yes, refactoring can be done later. However, I cannot judge the reasonableness of can_sleep being true and the safety of implementing sleeping, so the decision must be made by the physics team.

I'd be happy to hear from the physics team to see if my understanding is correct:
PhysicalBone3D nodes are regular PhysicsBody3D that are either static or kinematic while following animations, and become rigid when simulating. Something I haven't considered is what happens to the sleeping state when in either static or kinematic mode? I can look into this.
However, when in rigid mode there's most definitely value in having access to the sleeping state: the simulation will eventually settle and we don't want to waste physics resources on non-moving bodies (the physical bones). Once the bones are sleeping I can stop doing whatever processing I was doing on them and only resume once waken up.


build: accept the latest minor version of go

actions/setup-go doesn't pull the latest patch version if an older version in the same minor family has been cached. Consequently, this PR does not work as intended and I am closing it without merging.


method "getByteThumbnail" Unit8List is not a type, Flutter 2.10.0

when i use this pub and start the project, this exception comes out

android
pub version3.1.2


[DON'T MERGE] Allow users to swap a small amount of ETH with 0 gas price

Add whitelist system, which allows 0 gas price to interact with certain contracts

Codecov Report

Merging #385 (01d09a3) into develop (55034e9) will increase coverage by 15.56%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           develop     #385       +/-   ##
============================================
+ Coverage    71.15%   86.72%   +15.56%
============================================
  Files           68       35       -33
  Lines         2330     1122     -1208
  Branches       351      160      -191
============================================
- Hits          1658      973      -685
+ Misses         672      149      -523

Flag
Coverage Δ

batch-submitter
?

contracts
86.72% <0.00%> (-0.47%)
:arrow_down:

core-utils
?

data-transport-layer
?

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ontracts/contracts/L2/predeploys/BobaWhitelist.sol
0.00% <0.00%> (ø)

packages/core-utils/src/coders/index.ts

packages/core-utils/src/common/index.ts

packages/core-utils/src/common/hex-strings.ts

.../l1-ingestion/handlers/sequencer-batch-appended.ts

...ices/l1-ingestion/handlers/state-batch-appended.ts

packages/core-utils/src/alias.ts

packages/core-utils/src/index.ts

packages/core-utils/src/fees.ts

packages/core-utils/src/provider.ts

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55034e9...01d09a3. Read the comment docs.

It's hard to prevent DDOS attacks. Close PR for now.


README is incorrect for print prop

There are some remaining inconsistencies in README file about the print prop:

[ ] The section "Don't wait" is now incorrect, since print value has not been changed from false to true. This one is quite easy to fix.
[ ] The two sentences about print default values are also incorrect, since it's stated that print default value is The two sentences about print default values are also incorrect, since it's stated that print default value is false (which is correct) and that it means that the LoadingIndicator isn't displayed (which is wrong). I'm not sure if we should change this section of the documentation to add { print: true } or if we should change the HOC default behaviour to make print true by default (which may not be as simple as it seems).

Any idea on the second point ?

Not an easy one.
Idea
I like the idea that the default parameters means something (ie: that the default parameters means "we call load function and print the wrapped component").
If the default behaviour is "we call load function and hide wrapped component" this is a nonsens.
Before 4.0.0 we could use hoc-react-loader to hide the use of componentWillMount by simply doing :
export default loader(WrappedComponent, { load: (...args) => console.debug(args) })
And I think this is cool.
Code

We have to delete the default value here : https://github.com/Zenika/hoc-react-loader/blob/master/src/core.jsx#L25
And here check if print is undefined, if this is undefined we try to check this.props.loaded props, and if this last one is undefined we fallback to the current behaviour.

I would like to make sure I got it, so here is what I think I understood:

if print is defined, the current (v4) behavior  remains the same
if print is undefined and this.props.loaded is defined, we use the value of this.props.loaded (converted to Boolean) to decide wether or not we should display the component
if both print and this.props.loaded are undefined, we display the component

Is that correct ?

Yeah this is what I have in mind.
I think a third point of view would be great.
I SUMMON @frinyvonnick !

I agree 👍 !


Support maven properties for Liberty configuration

From Alasdair:

maven properties that start liberty.bootstrap.{var} should end up in bootstrap.properties as {var}
maven properties that start liberty.env.{var} should end up in server.env as {var}
maven properties that start liberty.jvm.{var} should end up in jvm.options as {var} (maybe liberty.java might be better?)
maven properties that start liberty.var.{var} should end up in a config dropins as {var}
Should we allow default variables to be set? Feels reasonable at which point liberty.defaultVar.{var} would end up in a config dropins with the value being in defaultValue rather than value.

For jvm.options and bootstrap.properties, we already support inlined configuration (jvmOptions and bootstrapProperties) in the pom.xml. If a maven property is specified that is a duplicate of a jvmOptions/bootstrapProperties property, the jvmOptions/bootstrapProperties property takes precedence.
The order of precedence from highest to lowest is:

inlined configuration (jvmOptions, bootstrapProperties)
maven property
specific file parameter (jvmOptionsFile, bootstrapPropertiesFile, serverEnvFile)
file from configDirectory

Properties specified via options 1 and 2 will be merged. No other merging will be done.

So the part about liberty.jvm.{var} doesn't make sense because jvm.options is just a list of jvm arguments. They are not properties with name=value.  I am going on the presumption that only the value should be included in the generated jvm.options file. So if someone specified liberty.jvm.maxHeapSize=-Xmx4g then a line is written to the jvm.options file containing -Xmx4g.
Also, the code will not be able to detect duplicate jvm settings in the jvmOptions parameter and the liberty.jvm.{var} maven properties when merging them into a single jvm.options file. Since the jvmOptions are to take precedence, they will get written to the jvm.options file after the maven properties. Documentation for various jdks indicate that the last argument/setting takes precedence.

@NottyCode I already merged this, but I want to make sure I made the right decision for the liberty.var.{var} and liberty.defaultVar.{var} properties. I generated them into a file in configDropins/overrides/liberty-plugin-variable-config.xml. Does that sound like the right place to put them?


New Block.Newclonedblock( blockid to clone, new block id);

To reproduce water

Or to reproduce portal blocks

Just use define block with the same texture as water or portal

But the block diesen has the water ai. E.g It wont flow

Try setting the renderType

Please guys this isn`t an issue, report an issue and suggest a feature on @zhuowei 's twitter