Does not work for default console application

Step to reproduce:
1 VS File->New->Project->Console application
2.  Select Solution/Project/File, Clang Power Tools->Compile
Bug:
Start Clang Compile
C:\Users\Mariusz\AppData\Local\Microsoft\VisualStudio\15.0_a46b25cb\Extensions\jdeqctnp.s5e\clang-build.ps1 : Cannot
bind argument to parameter 'aDirectory' because it is an empty string.
At line:1 char:537
+ ... e') -Verbose -parallel -vs-ver 2017 -vs-sku Community -dir '' -litera ...
+                                                                ~~
    + CategoryInfo          : InvalidData: (:) [clang-build.ps1], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorEmptyStringNotAllowed,clang-build.ps1

Done Clang Compile

Comments:

According to https://github.com/Caphyon/clang-power-tools/issues/104. I do not see command line for calling clang-build.ps1
I have seen command line for my other project:

VERBOSE: clang-build.ps1 invocation args:
  aVcxprojToCompile = G:\test\LibWin10.vcxproj
  aCppToCompile = AdmobHelper.cpp
  aVcxprojConfigPlatform = Release|x64
  aClangCompileFlags = -Werror -std=c++14 -Wall -fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft
-Wno-invalid-token-paste -Wno-unknown-pragmas -Wno-unused-variable -Wno-unused-value
  Verbose = True
  aUseParallelCompile = True
  aVisualStudioVersion = 2017
  aVisualStudioSku = Community
  aDirectory = G:\test
  aDisableNameRegexMatching = True

But I do not know how to use it. I would like to just copy clang-build.ps1 command line from Visual Studio output and use it...
I would like to see something like below visual studio output:
====Call clang-build.ps1:
C:\Users\Mariusz\AppData\Local\Microsoft\VisualStudio\15.0_a46b25cb\Extensions\jdeqctnp.s5e\clang-build.ps1 param1 param2 param2
.......

===== Call clang.exe
C:\path\clang.exe params

Hello,
Our extension uses the Visual Studio Project DTE APIs to retrieve the current project and solution file paths. These two paths are intersected and passed to clang-build as the aDirectory parameter. This parameter is used by the script to discover projects and solution files.
We added the solution discovery process in v2.0 because some projects we received from users weren't unable to compile with v1.7 because the $(SolutionDir) property was empty.
I reproduced your problem with a new C++ Console Project, albeit not always, sometimes it works just fine.
It appears that occasionally these APIs return an empty string right after creating a new project.
We are investigating to see what we can do about this.

Can you please confirm this workaround works?
-Gabriel

Regarding your question about the script command line:
clang-build.ps1 doesn't have access to the command line used to invoke it.
It does however have access to the received parameter values (arguments).
These are of great debugging value and are the ones you see printed in the verbose log right now.
We'll look into having the VS extension itself to print the clang-build.ps1 invocation command line. This would allow you to directly copy&paste into Powershell.

The clang++.exe/clang-tidy.exe command line is printed right now, for the first file to be compiled.
You can find it by looking for Clang job args[0] in the verbose log.

After save/reload:

I have error "fatal error: UTF-16 (LE) byte order mark detected"
I still do not see "Clang job args[0]"

Start Clang Compile

VERBOSE: clang-build.ps1 invocation args:
  aVcxprojToCompile = C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.vcxproj
  aCppToCompile = ConsoleApplication3.cpp
  aVcxprojConfigPlatform = Debug|Win32
  aClangCompileFlags = -Werror -std=c++14 -Wall -fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft
-Wno-invalid-token-paste -Wno-unknown-pragmas -Wno-unused-variable -Wno-unused-value
  Verbose = True
  aUseParallelCompile = True
  aVisualStudioVersion = 2017
  aVisualStudioSku = Community
  aDirectory = C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3
  aDisableNameRegexMatching = True
VERBOSE: CPU logical core count: 12
VERBOSE: LLVM location: C:\Program Files\LLVM\bin
VERBOSE: Scanning for solution files
VERBOSE: Solution file paths:
VERBOSE:   C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3\ConsoleApplication3.sln
VERBOSE: Source directory: C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3
VERBOSE: Scanning for project files
VERBOSE: Found 1 projects
[ INFO ] WILL PROCESS PROJECTS:
	ConsoleApplication3.vcxproj
[ INFO ] 1.
VERBOSE: PCH creation args: "C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\stdafx.h" -emit-pch -o "C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.clang.pch" -std=c++14 -Wall
-fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft -Wno-invalid-token-paste -Wno-unknown-pragmas
-Wno-unused-variable -Wno-unused-value -Wno-unused-command-line-argument -DWIN32 -D_DEBUG -D_CONSOLE -DUNICODE
-D_UNICODE
clang++.exe: warning: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated [-Wdeprecated]
fatal error: UTF-16 (LE) byte order mark detected in 'C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3\ConsoleApplication3\stdafx.h', but encoding is not supported
1 error generated.
VERBOSE: Cleaning up PCH temporaries:
VERBOSE:   C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.clang.pch
Errors encountered during PCH creation

Done Clang Compile

OK . When I save files as UTF-8 it works:

Is it known issue with UTF-16 (LE)
I see right now "Clang job tool:" in output but why there is no this line in previous output?
Could you display clang command line in the following format so I can just copy paste it?
C:\full_path\clang.exe all parameters

output
Start Clang Compile

VERBOSE: clang-build.ps1 invocation args:
  aVcxprojToCompile = C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.vcxproj
  aCppToCompile = ConsoleApplication3.cpp
  aVcxprojConfigPlatform = Debug|Win32
  aClangCompileFlags = -Werror -std=c++14 -Wall -fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft
-Wno-invalid-token-paste -Wno-unknown-pragmas -Wno-unused-variable -Wno-unused-value
  Verbose = True
  aUseParallelCompile = True
  aVisualStudioVersion = 2017
  aVisualStudioSku = Community
  aDirectory = C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3
  aDisableNameRegexMatching = True
VERBOSE: CPU logical core count: 12
VERBOSE: LLVM location: C:\Program Files\LLVM\bin
VERBOSE: Scanning for solution files
VERBOSE: Solution file paths:
VERBOSE:   C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3\ConsoleApplication3.sln
VERBOSE: Source directory: C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3
VERBOSE: Scanning for project files
VERBOSE: Found 1 projects
[ INFO ] WILL PROCESS PROJECTS:
	ConsoleApplication3.vcxproj
[ INFO ] 1.
VERBOSE: PCH creation args: "C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\stdafx.h" -emit-pch -o "C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.clang.pch" -std=c++14 -Wall
-fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft -Wno-invalid-token-paste -Wno-unknown-pragmas
-Wno-unused-variable -Wno-unused-value -Wno-unused-command-line-argument -DWIN32 -D_DEBUG -D_CONSOLE -DUNICODE
-D_UNICODE
clang++.exe: warning: treating 'c-header' input as 'c++-header' when in C++ mode, this behavior is deprecated [-Wdeprecated]
VERBOSE: Generated C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.clang.pch
VERBOSE: Clang job tool: clang++.exe
VERBOSE: Clang job args[0]: -include-pch "C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.clang.pch" -x c++
"C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.cpp" -Werror -std=c++14 -Wall
-fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft -Wno-invalid-token-paste -Wno-unknown-pragmas
-Wno-unused-variable -Wno-unused-value -fsyntax-only -DWIN32 -D_DEBUG -D_CONSOLE -DUNICODE -D_UNICODE
1: C:\Users\Mariusz\documents\visual studio 2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.cpp
VERBOSE: Deleting project specific variables:
VERBOSE:   MSBuildProjectFullPath
VERBOSE:   ProjectDir
VERBOSE:   MSBuildProjectExtension
VERBOSE:   MSBuildProjectName
VERBOSE:   MSBuildProjectDirectory
VERBOSE:   MSBuildProgramFiles32
VERBOSE:   VisualStudioVersion
VERBOSE:   SolutionDir
VERBOSE:   MSBuildThisFileFullPath
VERBOSE:   MSBuildThisFileExtension
VERBOSE:   MSBuildThisFile
VERBOSE:   MSBuildThisFileName
VERBOSE:   MSBuildThisFileDirectory
VERBOSE:   Configuration
VERBOSE:   Platform
VERBOSE:   VCProjectVersion
VERBOSE:   ProjectGuid
VERBOSE:   Keyword
VERBOSE:   RootNamespace
VERBOSE:   WindowsTargetPlatformVersion
VERBOSE:   ConfigurationType
VERBOSE:   UseDebugLibraries
VERBOSE:   PlatformToolset
VERBOSE:   CharacterSet
VERBOSE:   LinkIncremental
VERBOSE: Cleaning up PCH temporaries:
VERBOSE:   C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.clang.pch

Done Clang Compile

Yes. It think that VS extension itself should print the clang-build.ps1. Only in that place we really know what we are calling.

Clang doesn't like UTF-16 LE source files and VS creates such a stdafx.h file as a template now for new projects :(
https://developercommunity.visualstudio.com/content/problem/140257/c-cannot-compile-the-standard-template-project-wit.html

Could you display clang command line in the following format so I can just copy paste it?
C:\full_path\clang.exe all parameters

VERBOSE mode does print all the arguments for clang++:
From your example:
VERBOSE: Clang job args[0]: -include-pch "C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.clang.pch" -x c++
"C:\Users\Mariusz\documents\visual studio
2017\Projects\ConsoleApplication3\ConsoleApplication3\ConsoleApplication3.cpp" -Werror -std=c++14 -Wall
-fms-compatibility-version=19.10 -fms-compatibility -Wmicrosoft -Wno-invalid-token-paste -Wno-unknown-pragmas
-Wno-unused-variable -Wno-unused-value -fsyntax-only -DWIN32 -D_DEBUG -D_CONSOLE -DUNICODE -D_UNICODE

Yes. But why not just simply display what is called from ps script. I would like to just copy/paste command line. Even if I have separate arguments I have to find/guess which clang.exe was used (I have few clnag.exe on my computer).

I see right now "Clang job tool:" in output but why there is no this line in previous output?

The PS script didn't reach the point where it would print that command-line because it failed to create the PCH file, due to the UTF-16 stdafx.h file.

The PS script didn't reach the point where it would print that command-line because it failed to create the PCH file, due to the UTF-16 stdafx.h file.
I think that command line should be displayed to output before is called.
And in case compiling PCH and cpp it will be nice do display both command lines

Even if I have separate arguments I have to find/guess which clang.exe was used (I have few clnag.exe on my computer).

Oh, I see now :)
You need to see which clang++.exe is picked up by the PS script.
I guess normal Windows rules apply with regards to locating EXEs from %PATH% environment variable.

In terms of printing the full path of the clang++.exe that would be imposible, because the PS script doesn't know it; it just invokes it using normal EXE lookup mechanism via %PATH%  environment variable.
If you have multiple LLVM versions installed, they shouldn't all be listed in %PATH% , just the one you want to use regularly.

I do not have clang.exe in %PATH%
C:\Users\Mariusz>clang.exe
'clang.exe' is not recognized as an internal or external command,
operable program or batch file.

It seems like ps script resolves clang++.exe path. It would be nice to have this full path to clang  with all parameters in one place cor copy/paste.

I think that command line should be displayed to output before is called.
And in case compiling PCH and cpp it will be nice do display both command lines.

I completely agree with this. Will do.

I stand corrected:

Clang Power Tools will automatically load clang from the default installation path C:\Program Files\LLVM. If you prefer to use a different location you must manually add the bin folder to PATH.

It appears this is the accurate description from our README.md
So, I guess that would be the only location for clang++.exe we look at.
Only if we don't find anything there, we fallback on %PATH% lookup.

May I close this issue, now ?
As it started about default console application, there is nothing we can do about the fact that Clang doesn't like UTF-16 stdafx.h that VS generates for new projects.
https://developercommunity.visualstudio.com/content/problem/140257/c-cannot-compile-the-standard-template-project-wit.html
Hope MSFT will fix this.

If you want, you can open a new issue(s) regarding the clang++.exe path lookup and printing the command-line for PCH generation.

OK. Thank you for help.
It seems like there is problem is with VS "lightweight" project loading.
When it is enabled for i.e. bigger project (or for just created ConsoleApplication) from time to time I see:

cannot bind argument to parameter 'aDirectory' because it is an empty string.
Dialog box "The path is not of legal form"

Lightweight solution load (LSL) is going to be removed from VS.
Starting with the 15.5 release, all users will load solutions in the regular mode (including users who had previously selected LSL mode). VS will no longer provide options to enable LSL for the solutions.
Apparently, there were A LOT of VS extensions broken by the LSL feature :(


Avoid re-writing the cached value when more requests come for the same url or socket

Currently in the web_connectivity test helper if two requests come at the same time for a given URL and it's not cached we will have MISS in the and we will try to obtain the value from the network twice and the one that returns the latest will overwrite the cache.
Probably what we want to be doing is acquire the lock on the cache as soon as we begin doing any resource lookup so that the following requests will be waiting on the lock for the cache lookup and will get the cached value as soon as the lock is released (the resource has been cached)
As suggested by @bassosimone suggested in https://github.com/TheTorProject/ooni-backend/pull/63#issuecomment-222305811

I am going to assume the Ngnix cache is implemented properly and we don't need to worry about this topic.


Fix to support dot in image names

One more fix, to support dot in image names. Just as #12

@jc21 I've just hit this. Any chance to have a new DockerHub image built with this?

Umm good question. I'll try to get CI back tomorrow

It took longer than a day but it's done. New version is available at latest.

@jc21 Great stuff! Cheers for the work, pulling now.


Raspberry Pi TV HAT does not work with DVB-T2 Signals

Hi!
TSDuck is really great tool and love to use it. Thx for all the work done!
I want to use it to monitor the TS tables and specially there the AIT and hbbTV signalling reading the http link.
In my region there are only DVB-T2 transmitters anymore. I have signals on various channels like UHF 24, 34, and so on.
Bug description:
When I do a scan with following commands I can get no output of the scan tool:
tsscan -g --uhf-band
knowing that there is a signal on C 24:
tsscan --hf-band-region europe --use-offsets --delivery-system DVB-T2 --first-channel 22 --last-channel 26 -u
tsscan --hf-band-region europe --use-offsets --delivery-system DVB-T2 -u
I then compiled t2scan: https://github.com/mighty-p/t2scan
With this tool I can get all the expected scan results:
t2scan -t2
498000 (CH24): (time: 00:06.607)
plp id -1:   signal ok:	QAM_AUTO f = 498000 kHz I999B8C999D999T999G999Y0P-1 (0:0:0)
QAM_AUTO f = 498000 kHz I999B8C999D0T32G16Y0P1 (8232:13101:101) : scanning for services
service = ORF1 HD (ORF)
service = ORF2 W HD (ORF)
service = ORF2 N HD (ORF)
service = ORF2 B HD (ORF)
service = ORF III HD (ORF)
service = ORF Sport+ HD (ORF)
service = ORF1 (ORF)
service = ORF2 W (ORF)
service = Radio Österreich 1 (ORF)
service = Radio Wien (ORF)
service = Radio Niederösterreich (ORF)
service = Radio Burgenland (ORF)
service = Hitradio Ö3 (ORF)
service = radio FM4 (ORF)
service = Ö3-Visual-Radio (ORF)
service = SRT8506 OTA (ORS)
ORF1 HD;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1010=27:0;1011,1012:1015:69C:14101:8232:101:0
ORF2 W HD;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1000=27:0;1001,1002:1005:69C:14102:8232:101:0
ORF2 N HD;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1000=27:0;1001,1002:1005:69C:14103:8232:101:0
ORF2 B HD;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1000=27:0;1001,1002:1005:69C:14104:8232:101:0
ORF III HD;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1050=27:0;1051,1052:1055:69C:14105:8232:101:0
ORF Sport+ HD;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1060=27:0;1061,1062:1065:69C:14106:8232:101:0
ORF1;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1070=27:0;1071:1015:0:14107:8232:101:0
ORF2 W;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1080=27:0;1081:1005:0:14108:8232:101:0
Radio Österreich 1;ORF:498000:B8D0G16S1T32Y0P1:T:27500:0:0;1091:0:0:14109:8232:101:0
Radio Wien;ORF:498000:B8D0G16S1T32Y0P1:T:27500:0:0;1100:0:0:14110:8232:101:0
Radio Niederösterreich;ORF:498000:B8D0G16S1T32Y0P1:T:27500:0:0;1110:0:0:14111:8232:101:0
Radio Burgenland;ORF:498000:B8D0G16S1T32Y0P1:T:27500:0:0;1120:0:0:14112:8232:101:0
Hitradio Ö3;ORF:498000:B8D0G16S1T32Y0P1:T:27500:0:0;1131:0:0:14113:8232:101:0
radio FM4;ORF:498000:B8D0G16S1T32Y0P1:T:27500:0:0;1141:0:0:14114:8232:101:0
Ö3-Visual-Radio;ORF:498000:B8D0G16S1T32Y0P1:T:27500:1150=27:0;1131:0:0:14115:8232:101:0
How to reproduce:
use commands above
Expected behavior:
should give scan results of received channels
Errors and logs:
uname -a
Linux raspilora 6.6.31+rpt-rpi-v8 #1 SMP PREEMPT Debian 1:6.6.31-1+rpt1 (2024-05-29) aarch64 GNU/Linux
cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"
tslsdvb
0: /dev/dvb/adapter0 ("Sony CXD2880", DVB-T, DVB-T2)
Device: /dev/dvb/adapter0/frontend0
Environment:

OS: latest RaspiOS 64bit bookworm
OS version: see above
TSDuck full version: 3.38-3822
Installation type: manually installed from website https://github.com/tsduck/tsduck/releases/download/v3.38-3822/tsduck_3.38-3822.debian12_arm64.deb
installed libsrt1.5-openssl and librist4 manually

Any help would be much appreciated!
Can you recommend a USB Dongle which defintely works with DVB-T2 on the raspberry or linux??
Thx
Rainer

Hi @rainerfritz
Please use tsscan --delivery-system dvb-t2. Let us know if it works.
As documented with tsscan --help, it uses the "default delivery system" for the tuner, which is DVB-T in that case: DVB-T comes first in "Sony CXD2880, DVB-T, DVB-T2". If you want to scan another delivery system, you have to specify it.
There is recent issue #1505 about the fact that tsscan could find DVB-T streams only because tsscan only uses one delivery system. Originally, this was done to save time. Scanning two delivery systems doubles the scan time because you have to try each of them, one by one, on each frequency. As a solution, I added the possibility to specify --delivery-system several times to list all systems to try, at the expense of the scan time of course.
With the general switch to DVB-T2, it may make sense to use DVB-T2 as default on all tuners which support T and T2. But it would break existing scripts which scan networks all over the place.

Just to be sure, since you also mention --delivery-system DVB-T2, does it work or not?
Could you try this:
tsp -v -I dvb --delivery-system DVB-T2 --frequency 498,000,000 -P dump -O drop

Hi Thierry!
Thanks for that really fast reply, much appreciated!
I don't know what the problem was, maybe a typo or whatever, but it works now. Thanks a lot for the fast help!!
May I ask you one more question. I am currently recording the TS and then analysing it with tstables to get a JSON output. I want to do that on the fly and send the tables in JSON format via localhost to another application. Think that it is possible, as we can send the TS from tsp to tstables directly via a pipe?
As mentioned I want to monitor the AIT tables specially.

I don't know what the problem was, maybe a typo or whatever, but it works now.

Glad to read that it works.

I am currently recording the TS and then analysing it with tstables to get a JSON output. I want to do that on the fly and send the tables in JSON format via localhost to another application. Think that it is possible, as we can send the TS from tsp to tstables directly via a pipe?

First, there is no need to pipe tsp into tstables. The plugin tables is identical to tstables (same options, same code) and works inside the tsp pipeline.
Then, the plugin tables (and tstables) can send the extracted sections over UDP. See the reference documentation for plugin tables, especially the section "UDP/IP logging options".
Currently, the sections are sent in binary format over UDP. If you want to convert them into JSON (or XML) on reception, I would suggest a shell script with nc (netcat) for reception, piped into tstabdump. Don't forget to use --no-encapsulation with -P tables --ip-udp to send the raw sections, without encapsulation.

If all works well and the project gets accepted on my side, I will ask for permission to promote our broadcasting station on tsduck page.

Of course, you are welcome, this is mutual publicity. There is a references page here.

And because it can be useful and it is easy to implement, I just added an option --udp-format to tstables and plugin tables. To send tables in JSON format over UDP, use:
tsp .... -P tables --ip-udp address:port --udp-format json ...

Great! Thats a really useful option! Thx a lot for that!


Prometheus service test fails

Issue description
$ cd nixos/tests
$ nix-build nixos/tests/prometheus.nix
error: The option `services.prometheus.scrapeConfigs.[definition 1-entry 1].target_groups' defined in `<unknown-file>' does not exist.
(use ‘--show-trace’ to show detailed location information)

There must be something wrong with the "target_groups" option.
Background: I was trying to setup a Prometheus instance. I struggled a bit with the Nix options (just wanted to paste some Yaml from a tutorial...), then got the Nix syntax mostly working but struggled with the missing "target_group" option. Then I found there was even a test for this service, and that test fails :-)
Technical details

System: NixOS 17.03pre
Nix version: 1.11.4
Nixpkgs version: 5ed1aee3af6ce80c63e534fc26d7ee611d4ca50d (master as of today)

Doh, apparently target_groups got renamed to static_configs in d4599165010f1541219cf32278e21a18ef8db8f7.

Fixed in 3fb785b0ad6902d765601e489e5f695411d2752f.


Bump jackson-databind from 2.13.4 to <IP_ADDRESS> in /prime-router

This PR updates jackson-databind from 2.13.4 to <IP_ADDRESS> to remediate a "High" vulnerability.
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:

Include steps to test these changes

Changes

Version Diff

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #issue

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

This has a dependency conflict with the overall jackson module:
+--- com.fasterxml.jackson.module:jackson-module-kotlin:2.12.7
When that's updated, this can also be updated.

@TurkeyFried I realize that this looks like a conflicting version, but I believe this is a hot fix specifically to address the vulnerability and there will not be an across the board update.

@dependabot rebase

That was my only issue, since tests did pass


Question: Is It Possible To De-Google And Only Use OSM Tiles?

Firstly, thank you for maintaining this project, your dedication is greatly appreciated!
I was playing around with OSM tiles using the code sample from TilesPage.xaml.cs and it made me wonder:
Is it possible to load the Onion.Maui.GoogleMaps package without a Google API key and just use the map functionality with OSM tiles?

No. What is the problem to use a key though? iOS and Android mobile sdks are non chargeable by Google

Yes, I was just thinking worst case scenario such as they start charging for the mobile sdks like they did with the javascript ones some years back


fix: Create py.typed

Hi, just a small fix: without this, mypy doesn't consider langfuse's typing.
Given the following test file
from langfuse.decorators import observe

@observe()
def test(x: int) -> str:
    return str(x)

y = test(5)
reveal_type(y)

with this change, mypy looks like this:
test.py:9: error: Argument 1 to "test" has incompatible type "str"; expected "int"  [arg-type]
test.py:10: note: Revealed type is "builtins.str"

without this change (with the latest langfuse version), it looks like this:
test.py:10: note: Revealed type is "Any"
Success: no issues found in 1 source file

I see there is some discussion already in https://github.com/langfuse/langfuse/issues/2169, but it got stalled.
It is true that if I just run mypy on this repository, there are many complaints:
main $ mypy . | wc -l                                                                                [10:55:22]
     517

So it would require a big effort to fix the whole library for mypy, but on the other hand, it's a shame that currently, any project that uses @observe is losing type safety, which can be fixed by this change.
As a hot fix, without this change, having this wrapper in our code repository around the langfuse's observer seems like a way to go, but it's not a great solution:
from langfuse.decorators.langfuse_decorator import (
    langfuse_context,
    observe as original_observe,
)
from typing import TypeVar, ParamSpec, Optional, Literal, Callable, Iterable, Any

P = ParamSpec("P")
R = TypeVar("R")

def observe(
    name: Optional[str] = None,
    as_type: Optional[Literal["generation"]] = None,
    capture_input: bool = True,
    capture_output: bool = True,
    transform_to_string: Optional[Callable[[Iterable[Any]], str]] = None,
) -> Callable[[Callable[P, R]], Callable[P, R]]:
    casted: Callable[[Callable[P, R]], Callable[P, R]] = original_observe(
        name=name,
        as_type=as_type,
        capture_input=capture_input,
        capture_output=capture_output,
        transform_to_string=transform_to_string,
    )
    return casted

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Hugo c

Sorry, I'm closing this as this repo isn't really maintained anymore, and I have no idea why this PR was introduced.


Update gms location dependency

The current dependency com.google.android.gms:play-services-location:16.0.0 is quite old, we should update this dependency.
I tried this, but somehow it did not work. Not sure where this comes from 'com.google.android.gms:play-services-location:{strictly 16.0.0}' because of the following reason: debugRuntimeClasspath uses version 16.0.0, when you change 16.0.0 to 21.0.1 there is no v16 defined in the project anymore.
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':libandroid-navigation:generateDebugRFile'.
> Could not resolve all files for configuration ':libandroid-navigation:debugCompileClasspath'.
   > Could not resolve com.google.android.gms:play-services-location:21.0.1.
     Required by:
         project :libandroid-navigation
      > Cannot find a version of 'com.google.android.gms:play-services-location' that satisfies the version constraints:
           Dependency path 'com.mapbox.mapboxsdk:libandroid-navigation:1.0.3' --> 'com.google.android.gms:play-services-location:21.0.1'
           Constraint path 'com.mapbox.mapboxsdk:libandroid-navigation:1.0.3' --> 'com.google.android.gms:play-services-location:{strictly 16.0.0}' because of the following reason: debugRuntimeClasspath uses version 16.0.0

After some more investigation, it seems that we get v16 from the upstream maplibre-sdk, we should probably update the version upstream.

This has been fixed upstream, once there is a new release, we can update this lib here as well.
Ref: https://github.com/maplibre/maplibre-gl-native/pull/627


Update packer to 0.8.1

Thank you for the contribution. It was merged directly as 2697561b1623ab21c287d6831495000999a67329 to keep commit history cleaner. Your contribution is still credited to you.

@vitorgalvao Thanks!


Fix OPENXLSX_LIBRARY_TYPE checks

CMake's if() statement works a bit strangely for historical reasons. In particular, variable evaluation can be somewhat unintuitive, which can lead to strange behavior.
In particular, the docs state^0:
Note that normal variable evaluation with ${} applies before the if
command even receives the arguments. Therefore code like

    set(var1 OFF)
    set(var2 "var1")
    if(${var2})

appears to the if command as

    if(var1)

and is evaluated according to the if(<variable>) case documented
above. The result is OFF which is false. However, if we remove the
${} from the example then the command sees

    if(var2)

which is true because var2 is defined to var1 which is not a false
constant.

OpenXLSX checks OPENXLSX_LIBRARY_TYPE by using a bare ${} in an if statement. I believe this would work when OpenXLSX is used on its own, but it can result in very confusing errors if one is unlucky.
In particular, if "STATIC" or "SHARED" exist as CMake variables (and are not set to the strings "STATIC" or "SHARED"), the checks involving OPENXLSX_LIBRARY_TYPE will break. This is because OPENXLSX_LIBRARY_TYPE is first evaluated to STATIC/SHARED, then the if() statement checks to see if that is a variable. Since it is in this case, the value of that variable is used instead of the string "STATIC" or "SHARED", and the value of that variable is probably not what OpenXLSX expects.
The fix is to either remove the bare ${} when checking variables in if() statements or to quote it (i.e., ${} becomes "${}"). I chose the latter in this case because I feel it's a bit more obvious what is going on.
Chances are most CMake projects don't have STATIC or SHARED as variables floating around, but seems I happen to be the unlucky one.

implemented manually today (was already in a local branch but forgotten in a merge)


ctrl + c on create flow throws stack trace with Error: User force closed the prompt with 0 null

Environment information
System:
    OS: macOS 14.3
    CPU: (8) arm64 Apple M1
    Memory: 260.28 MB / 16.00 GB
    Shell: 3.6.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 21.6.1 - ~/.local/share/nvm/v21.6.1/bin/node
    Yarn: Not Found
    npm: 10.2.4 - ~/.local/share/nvm/v21.6.1/bin/npm
    pnpm: 7.26.2 - /opt/homebrew/bin/pnpm
    bun: Not Found
    Watchman: Not Found
  npmPackages:
    @aws-amplify/backend: ^0.11.0 => 0.11.0
    @aws-amplify/backend-cli: ^0.11.0 => 0.11.0
    aws-amplify: ^6.0.15 => 6.0.15
    aws-cdk: ^2.126.0 => 2.126.0
    aws-cdk-lib: ^2.126.0 => 2.126.0
    typescript: ^5.3.3 => 5.3.3

Description

marking as a bug

Closing as a duplicate of https://github.com/aws-amplify/amplify-backend/issues/825


Financial/analysis PR

PR request to analyze financial data and print to console.

The PR  is raised for an analysis of a financial record.  I am merging it to main


Support dashOffset on canvas layer

the PathOption dashOffset is currently ignored on canvas layers.

Any news on that one?


GSAP Text Animations on Homepage

Objective: I propose enhancing the homepage with text animations using GSAP (GreenSock Animation Platform) to improve user engagement and make the interface more dynamic.
Details:

Animate heading and subheading text on page load.
Include subtle fade-in or slide-in animations for improved visual appeal.
Ensure animations are responsive and do not affect performance on lower-end devices.
Will add comments to code to ensure clarity for future contributors.

Please assign this issue to me, as I would love to work on it. I am also a contributor in GGSOCExt 24 , hacktoberfest.
Looking forward to your feedback!

@priyashuu, share your potential design solution. what will your inspiration for the design be before implementation?
What does the design of the page look like?
If you want to design, then you can design your solution in the Figma link here👇
https://www.figma.com/design/Gpp9lztaz36xu9nuGt7FBE/Frontend-Mentor?node-id=0-1&t=vJh3LEbs3Fw4ZmwL-1
for further discussion or any doubt, Join the discord server here:
https://discord.gg/eXrQqgRX

@priyashuu, if you want to work on this issue, then go for it.
If you have any doubts, then feel free to ask here in our discord server.
https://discord.gg/4rMUncEV

ok sir


[Feature Request] Integrate RAG-based Language Model for Interactive Q&A 🤖

Integrate the RAG-based Language Model for interactive question and answer functionality. Users can utilize any text input to query their preferred language model. The model will respond with answers derived from the specified document, enhancing user engagement and interactivity. 🤖
Github: Autollm: Ship RAG based LLM ⚙

@kadirnar Can I work on this issue?

@kadirnar Can I work on this issue?
Yes🚀 It would be great if you could use the Autollm library. You can also add other libraries.

Thank you @kadirnar

Hi @StatKumar, the autollm library can be difficult. Do you want me to help you? You can ask all your questions. We can send a pull reqest for testing and develop it together.

@kadirnar Sure. Please guide me through it.

@kadirnar should we create a roadmap for this task? With smaller milestones

@kadirnar Also I was trying out the app and I was getting the following:
RuntimeError: Input type (torch.FloatTensor) and weight type (torch.HalfTensor) should be the same or input should be a MKLDNN tensor and weight is a dense tensor
It happens when the device is not switched - cpu to gpu or vice versa
Meanwhile, do you want to create slack channel? so we can discuss it on there.

Do you use discord app? Can you text me?
username: kadirnar

@kadirnar sent you a friend's request on discord.


add ode

[x] euler
[x] midpoint
[x] heun
[x] runge-kutta

RK method test case are from :

https://en.wikipedia.org/wiki/Runge–Kutta_methods
Numerical Methods for Engineers 7th ed. by Raymond P. Canale and Steven C. Chapra


need to change self.async variable name to not clash with python 3.7 …

Proposed Changes
Rename the LibevConnection class's async member because it now (as of python >3.7) conflicts with the async language keyword.

Looks good


Outdated files in the dev-1.13-ko.2 branch

This is a...

[ ] Feature Request
[ ] Bug Report

Problem:
147 files in content/en are changed
5 files in content/ko are outdated

[ ]  docs/concepts/overview/kubernetes-api.md
[ ]  docs/home/_index.md
[ ]  docs/setup/independent/troubleshooting-kubeadm.md
[ ]  docs/setup/multiple-zones.md
[ ]  docs/setup/pick-right-solution.md

This outdated file list is generated by the script based on the result of comparison c321a098fb55dcb78a000eeac91ba48a03d3db8e to ecef1e755fdf71627d4b5e980084255f4359251e.
Proposed Solution:
Use git diff to check what is changed in the upstream. And apply the upstream changes manually to the content/ko of dev-1.13-ko.2 branch.
For example:
# checkout `k/website:dev-1.13-ko.2`
...
# check what is updated in the upstream
git diff c321a098f ecef1e75 -- content/en/docs/concepts/overview/kubernetes-api.md
# apply changes to content/ko
vi content/ko/docs/concepts/overview/kubernetes-api.md
...
# commit and push
...
# make PR to `k/website:dev-1.13-ko.2`

Page to Update:
https://kubernetes.io/...

/assign


Estimating the gradient of the optimal assignment

Hi @Yang7879 , thx for your released code. The paper is easy understanding, but I don't find any reinforcement learning algorithms in the code as Appendix D wrote. I'm not familiar with DPG actually. Do I miss something? Is it necessary to propagate gradient along the assignment path?

Hi @zhuyijie88, thanks for your interests in our paper. Here's a more detailed discussion about the gradient propagation of Hungarian assignment. Hope it's helpful for your research.
https://github.com/Yang7879/3D-BoNet/blob/master/figs/fig_gradient_Hungarian.png

Hi @Yang7879 ，I‘m wondering is the gredient of Hungarian assignment really necessary? Can we train the network without this gradient?


Losing funds for no obvious reason at all.

Expected behavior
Stacking Sats
Actual behavior
Losing/"misplacing" Sats like the Pentagon
Steps to reproduce the problem
probably hard to reproduce - see "additional context"
Specifications

Version: latest from Umbrel app store
Platform: Umbrel OS 1.3 on Umbrel Home
Browser:matter not, that does

Additional context
I am aware that sometimes the overall wallet balance is temporarily lower thanks to stuck/slow transactions, but this time my balance went down 600K Sats and there are no unconfirmed or otherwise suspicious transactions in any of the jars, I did not initiate any transactions myself, and from what I can see there were no outgoing transactions that could have caused this.
In the past, balance inconsistencies resolved after a blockchain re-scan or just after a couple days - this time it did not.
Slightly concerning that an app that so far has earned around 3K Sats manages to vanish several hundred k Sats...
I updated my Umbrel to latest 1.3 Umbrel OS last week, but did not change the config in any way, so this should not really mess with my wallet balance...

Expected behavior
Stacking Sats
Actual behavior
Losing/"misplacing" Sats like the Pentagon
Steps to reproduce the problem
probably hard to reproduce - see "additional context"
Specifications

Version: latest from Umbrel app store
Platform: Umbrel OS 1.3 on Umbrel Home
Browser:matter not, that does

Additional context
I am aware that sometimes the overall wallet balance is temporarily lower thanks to stuck/slow transactions, but this time my balance went down 600K Sats and there are no unconfirmed or otherwise suspicious transactions in any of the jars, I did not initiate any transactions myself, and from what I can see there were no outgoing transactions that could have caused this.
In the past, balance inconsistencies resolved after a blockchain re-scan or just after a couple days - this time it did not. Slightly concerning that an app that so far has earned around 3K Sats manages to vanish several hundred k Sats...
I updated my Umbrel to latest 1.3 Umbrel OS last week, but did not change the config in any way, so this should not really mess with my wallet balance...

Hello @TheShaman
Thanks for posting the issue.
And apologize for any inconvenience this may have caused
You are experiencing the transcript error on the Umbrel Node ,
It sounds like your query would be best dealt with by the support team.
I’ll have to refer you to the official support live chat with the ticket ID SAT#8731
Please see the link below to our dedicated support line:
Sats Network Dapps Support.
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent.

I deleted that comments as it was a scam.

Expected behavior
Stacking Sats
Actual behavior
Losing/"misplacing" Sats like the Pentagon
Steps to reproduce the problem
probably hard to reproduce - see "additional context"
Specifications

Version: latest from Umbrel app store
Platform: Umbrel OS 1.3 on Umbrel Home
Browser:matter not, that does

Additional context
I am aware that sometimes the overall wallet balance is temporarily lower thanks to stuck/slow transactions, but this time my balance went down 600K Sats and there are no unconfirmed or otherwise suspicious transactions in any of the jars, I did not initiate any transactions myself, and from what I can see there were no outgoing transactions that could have caused this.
In the past, balance inconsistencies resolved after a blockchain re-scan or just after a couple days - this time it did not. Slightly concerning that an app that so far has earned around 3K Sats manages to vanish several hundred k Sats...
I updated my Umbrel to latest 1.3 Umbrel OS last week, but did not change the config in any way, so this should not really mess with my wallet balance...

Hi there,
I attempted to reproduce your issue and was unable to do so.
We use GitHub issues as a place to track bugs and other development-related issues. If your issue persists, please write us back using our “Chat Support” icon located on our Joinmarket Help Center
You can include a link to this issue in the message content.
Alternatively, you can also search for an answer in our help documentation or get help from other users on our community forums.
The issue here will be closed.
Thanks!

closing the issue, as it was "fixed" on Telegram.

@MarnixCroes I am not sure, has it actually been "solved"?
@TheShaman What was the reason?
For the record: Most cases turn out to be user "errors", e.g. not remembering a transaction, not in sync with timechain, transaction not in local mempool, etc.

No, it has not been solved. But it probably can not be solved, so it is solved in a way, LOL
Since I "only" have my memory and a handwritten record of the total wallet balance last week, I can not "proof" that funds went missing.
I imported the seed into Sparrow (easier to check transaction histories there) and the transactions over the past few days look ok. So there is no real reason why the balance should have went down. Maybe a glitch in the web interface showing unreliable numbers (the displayed total wallet balance, upper right corner,  went down after an update of Umbrel OS to 1.3), maybe aliens or the CIA... xD
Unsolved mysteries of the blockchain.
I will take screenshots from now on and watch for further anomalies...

Sorry if I closed too soon.
I thought it was solved. Will double check next time.
My bad, please reopen if you think so


Test image cleanup

Every CI run will build a couple container images. We need to clean up process to get rid of unused images, e.g. with https://github.com/GoogleCloudPlatform/gcr-cleaner

This was fixed with https://github.com/abcxyz/lumberjack/pull/249


Fix v6.0.1

fix typo in RFQ contract
fix handling logic for makerToken as ETH in RFQ contract
add two parameter to Swap event in GS contract

fix handling logic for makerToken as ETH in RFQ contract

This does not feel like a "fix". This is changing how we treat WETH as maker token:

before this PR: ETH == WETH

No ETH as maker token allowed; WETH as maker token means ETH as maker token, we converts it to ETH and send it to recipient

after this PR: ETH != WETH

WETH as maker token is the same as other ERC20 tokens, we will not convert it to ETH anymore; ETH as maker token means we will convert WETH to ETH and send it to recipient

Please add a readme or a natspec/comment for how we handle different maker tokens, to help others better understand how it works.
In RFQ,
- if maker token is ETH, ...
- if maker token is WETH, ...
- if maker token is normal ERC20, ...


Blog post about issues doing local debug on WinPhone (and others?) using IIS Express.  - Still working with customer

Published blog to wiki.
https://github.com/Azure/azure-mobile-apps-net-server/wiki/Local-development-and-debugging-the-Mobile-App-.NET-server-backend


Executing Windows programs sometimes does not work in new PID namespace

Your Windows build number:  (Type ver at a Windows Command Prompt)
10.0.17134.228

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)

$ sudo unshare --pid --fork sh -c '/mnt/c/Windows/System32/notepad.exe && true'
/mnt/c/Windows/System32/notepad.exe: Invalid argument

What's wrong / what should be happening instead:
Notepad should be running

Strace of the failing command, if applicable:
https://gist.github.com/marc-groundctl/7f213a00909aa72a1ff42123efbf0505

This appears to be because getpid returns the PID in the new PID namespace, but the IOCTL _IOC(0, 0, 0x97, 0x22) wants a pid in the original namespace.  If I attach a debugger and manually change the pid passed to that IOCTL, notepad executes correctly.

/init is kind of our grab-bag binary that handles lots of things (including the binfmt interpreter for launching Windows binaries).  When run as pid=1 it thinks it is running as the init daemon, so it tries to connect back the LxssManager service.
I suppose we should treat the binfmt interpreter the same way we do wslpath and make it a symlink to /init.
Is this blocking something in particular or just something you noticed while poking around?  Thanks!

I found it when setting up an Arch chroot.  The script works fine without unsharing the pid namespace, so it's not blocking anything.

should treat the binfmt interpreter the same way we do wslpath and make it a symlink to /init

Or.... .
Inevitably (when the sad day comes), Ken Thompson's ghost is going haunt all of you in your sleep. And who wants to risk that?


Stable version tag for npm is no longer available

Summary
The npm stable version tag no longer exists.
Steps To Reproduce:

npm i -g sfdx-cli@stable

Expected result
The current stable version of sfdx is installed.
Actual result
No matching version found for sfdx-cli@stable.
System Information
not relevant

The npm tags for sfdx-cli are latest and latest-rc.  The installer tags are stable and stable-rc.

The npm tags for sfdx-cli are latest and latest-rc. The installer tags are stable and stable-rc.

Ah, ok. I guess that changed recently. Is it safe to assume latest is stable?

latest == stable
latest-rc == stable-rc
Afaik, it's been this way since we starting doing release candidates.

@shetzel  -- something is not right -- the docs for downloading the tarballs use the "stable" and "stable-rc"
https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_install_cli.htm
However, https://developer.salesforce.com/media/salesforce-cli/sfdx/channels/stable-rc/sfdx-linux-x64.tar.xz currently points to CLI 7.140.x (several weeks old) so there's likely something not updating the tarball URLs

@daveespo - yeah, something is off there.  1478 is definitely a bug.
I wasn't aware of this, but it seems that there used to be a stable tag for sfdx-cli npm.  That was a mistake long ago and pointed to a very old version (it wasn't being updated) and has been removed.  @Kevmo92 - apologies for my inaccurate response.


Masthead-l1 title and Masthead-l0 platform are different

Detailed description
The masthead-l1 has a title property:

The masthead-l0 has an optional platform property:

This is more like a question: they're not the same thing? They have pretty much the same behavior, which is to redirect the user to the l0 page of the title/platform.

Is this issue related to a specific component?

Masthead-l0 with platform and Masthead-l1 with title.

What would you like to see changed?

The title property appears at the hamburger menu (MastheadLeftNav).

What version of the IBM.com Library are you using?

Canary, updated last week.
Additional information
This question came up after Praveen opened a bug at the Services page board. The current title from L1 doesn't appear in the hamburger menu for the md breakpoint and bellow, as we would like to happen.

@guilhermelMoraes The original design specs did not treat these the same. The platform name exists only in the L0, whereas Services & Consulting in your example is the top-level page for that section, which is not the same as platform.
@oliviaflory @wonilsuhibm is this correct, unless something has changed?

I am honestly not sure @kennylam, the L1 was switch to what Gui is showing from what Lara originally designed (the dark L1)
I didn't get a chance to look into how the two relate before it was implemented, but I believe the idea is if there is an L1 there will not be any links in the L0.

Eventually, they may become the same thing, but for now, we should treat them as two separate things.

Closing because this is working as designed.


Fix typos and markdowns

Found via these commands:
codespell . -L crate,ser,mot
markdownlint *.md --disable md013 md033 md041

Perfect, thanks!

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


Need A Studio or Library for HTMLified Projects?

Hi! SheepMaker!
Its SparkScratch-P
I saw TurboWarp has a  Studio, that has projects that work best on TurboWarp!
TurboWarp makes projects faster only! But HTMLifier modifies a lot, and has features that make many impossible things possible!
So, Would You Accept if I create an HTMLifier Studio, by forking this repo? It will have projects, whose majority of features are possible only with HTML.
Some basic Examples from my Experience that makes HTMLifier the most Special one:

 EvalJS
SyncPixee
ArchieBulid

And I am sure...there are far more over the Web!
I will create everything; collapse, a bit of CSS (though if u want to maintain these as one of the mail HTMLifier, u need to add the basic CSS), contribution guidelines, and some more!
Hope You like my idea!
Will be happy to work on it!
Thank You
Pls visit my page, https://sparkscratch-p.github.io/ React, Rate and Comment!

TurboWarp makes projects faster only!

This is far from true; TurboWarp's feature set encompasses the HTMLifier's (except for unprotected eval, for reasonable reasons) and more

So, Would You Accept if I create an HTMLifier Studio, by forking this repo? It will have projects, whose majority of features are possible only with HTML.

GitHub's TOS permits you to fork any repository without having to ask. "The HTMLifier" isn't trademarked or anything so you're free to use it in the name of whatever you make

This is far from true; TurboWarp's feature set encompasses the HTMLifier's (except for unprotected eval, for reasonable reasons) and more

Hmmm maybe.. from the very beginning I went on for exporting and publishing scratch projects, the first thing i got is HTMLifier, Hence, I don't know much bout TurboWarp. And about the studio, TurboWarps studio has projects tht are made only faster, I mean works faster with it than Scratch!

GitHub's TOS permits you to fork any repository without having to ask. "The HTMLifier" isn't trademarked or anything so you're free to use it in the name of whatever you make

Ofc! but the thing is that I won't do anything that no one needs! Like, if u want a studio, I will do, but not waste over something unacceptable. So, if u like my idea, pls tell me, brother.. I will do it.

Ofc! but the thing is that I won't do anything that no one needs! Like, if u want a studio, I will do,

Ah, I don't think a studio for projects that work better with the HTMLifier is needed right now

Om Bro, and if ever u need any, pls notify me... I will surely like to help😊 👨💻


The maven repository does not have the protobuf-0.13.0.jar file.

Only the protobuf-0.12 jar file was available, and the protobuf-0.13 jar file was not uploaded.

@darnaut @david-leifker
Hi, When will this be updated?
https://repo1.maven.org/maven2/io/acryl/datahub-protobuf/


Edited polygons emit new paths array

This has been requested many times. I'm not sure this is the optimal approach but it's working great for me and I hope it will be useful for others. FYI this is my first pull request to an open library, so bear with me if I'm being a noob.
Special thanks to @chromacoma for the basics to get this working.
I reverted the last commit because I'm not sure it provides value and find that it might be better handled in the code that consumes the library.

Thx @Methodician I will review this in a few days! If anyone wants to review this also: feel free!

Hey thanks :) Were you able to get the same changes in for polylines as well as polygons? If not, I can generate a pull request off of my repo

I figured for a pull request I'd keep it to just one.
I know on my own app projects, I kind of throw up my arms when I get a large, multi-part pull request and I'm all busy and I'm expected to sift through all the changes, and this is my first pull request on a public repo.
If this makes it in, either you or I should follow it up with the polyline updates. There might be a change request to incorporate into that pattern too.

Hi @Methodician! Thanks for your contribution. To merge this PR, you need to combine your commits in one single commit (look for git rebase). :+1:

@Methodician please address the changes @timhovius proposed.

Sure I'll give it a shot some time in the next few days.

Hi @Methodician , can you explain how I can get this working ? any working code example as well

Yeah. Sorry I haven't had the chance to fix up my pull request. I'll try to do that today since I'll be out for the holidays.
In the mean time @alamgirqazi here's the gist of the functionality:
<agm-map [latitude]="lat" [longitude]="lng">
  <agm-polygon [paths]="paths" [editable]="true" [polyDraggable]="true"
 (polyPathChange)="polyPathChange($event)"></agm-polygon>
</agm-map>

  polyPathChange($event) {
    // try logging the $event to the console. It's funky.
    // It contains an array of lat/lng objects with methods that return the lat and lng...
    this.getPathFromChange($event).then(path => console.log(path));
  }

  getPathFromChange(pathChangeEvent) {
    return pathChangeEvent.then(e => {
      return e.map((item, index) => {
        return {
          lat: item.lat(),
          lng: item.lng()
        }
      });
    });
  }

I found it easier to just re-fork and create a new branch and PR rather than cleaning up all the formatting changes my editor made in the last PR plus trying to figure out how to squash my commits using rebase...
Still learning, still my first official contribution to a major public package.
Other PR: https://github.com/SebastianM/angular-google-maps/pull/1269

So is anyone going to merge my replacement PR?

We close this in favor of #1269


alt-ergo: fix src URL

Description of changes
Use fetchzip instead of fetchFromGitHub.
Is it a bug of GitHub? or of fetchFromGitHub? or just the perversion of upstream dev who gave the same name to a branch and to a tag?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Related: https://github.com/OCamlPro/alt-ergo/issues/547

Or we can set rev = "refs/tags/${version}";.

Is the second commit of this PR unrelated?

Typo fixed.
It’s not completely unrelated as the psmt2-frontend library is a dependency of alt-ergo.

@ofborg build ocamlPackages.psmt2-frontend


Setup skeleton module for chat SDK

As we make progress in the android codegen, it will be helpful to have a place-holder in azure-sdk-for-android-pr to host the in-progress generated code. This enables devs and partners to try-out the produced SDK.

Create the SDK place holder module named communicationserviceswip.
Include build.gradle and AndroidManifest.xml to the module.
Have the top-level settings.gradle aware of this module
Have .gitignore to avoid accidental pushing of partial/non-compilable files to the module.

When partners want to try out a in-progress version of codegen then:

clone the azure-sdk-for-android-pr
cd sdk/communicationserviceswip/swagger
autorest  --android --use=<path_to_inprogress_autorest_java>

This will result in all generated files to be available under the module sdk/communicationserviceswip/azure-communicationserviceswip-chat. Now the entire project can be opened from android-studio, and we'll be able to see the module, its file, integration with azure-core etc..

The module is here: https://github.com/Azure/azure-sdk-for-android-pr/tree/chat-mvp/sdk/communicationserviceswip


script:mkdir doesn't work when mkdir is aliased in Powershell

In Powershell, mkdir is not actually an alias. Remove-Item alias:/mkdir fails on my system.
Having Set-Alias mkdir mkdir.ps1 in my profile works such that I can use the busybox mkdir command instead of the system command. This overrides the system mkdir command, and apparently the script:mkdir function as well.

I changed my alias to be locally scoped and this fixes the issue with scoop. However this isn't a solution that everyone is going to know.
Set-Alias mkdir mkdir.ps1 -scope local -option private

So any user-defined alias will override the corresponding functions you added in core.ps1?

That's possibly the case, although I'd need to do some more investigating. Unfortunately I won't have time this week.


Add Capabilities to Sat

@jagger27 has this been tested? What's stopping it from coming out of draft?


endpoint/policy: bug fix when updating identity

Signed-off-by: André Martins<EMAIL_ADDRESS>

With commit 3be13e1 it's necessary to clean the KVStore since the data store there is corrupted.

Is it documented somewhere how to do that?


fix(ui): ensure content size same across platforms

We set titleBarStyle: hidden which causes the title bar to be hidden on the mac so that we can better integrate it with our designs. On windows this has no effect and the titlebar is still rendered. This causes the actual display area to be different on mac vs windows.
Set the useContentSize to ensure that the rendered content is the same size on all platforms.
See https://github.com/electron/electron/blob/master/docs/api/browser-window.md#new-browserwindowoptions
Fix #666

Pull Request Test Coverage Report for Build 3843

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 14.964%

Totals

Change from base Build 3837:
0.0%

Covered Lines:
571

Relevant Lines:
3417

💛  - Coveralls


Cannot index string with string "head"

Hi!
I started using your actions two weeks ago and all works fine.
I modified some code for my PR and the actions doesn't work with this error :
Enter host password for user 'ALefaux':
jq: error (at <stdin>:4): Cannot index string with string "head"

Could you please share the "code you modified for your PR" and enough to reproduce your error?

name: Open pull request after push

on:
  push:
    branches:
      - '*/*'

jobs:
  open-pull-request:
    name: Open the pull request
    runs-on: ubuntu-latest

    steps:
      - name: open-pull-request-action
        uses<EMAIL_ADDRESS>        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          PULL_REQUEST_BRANCH: "master"
          PULL_REQUEST_ASSIGNEES: "ALefaux"

Thank you! Could you please link me to the action, where it ran, so I can take a look?

Maybe it's my repo the problem ...
https://github.com/ALefaux/AND_Pollochon/actions/runs/112728233

I'm seeing a lot of random errors (500 and otherwise) from GitHub today, and also problems with my own actions, so if it's okay with you I think we should wait for the dust to settle.

You are right. It works today. Sorry to have disturbed you.

Oh gosh, it's really no worries! If there is a bug, it's the right thing to do to report it. I'm glad that you were proactive in doing this, it's not your fault that GitHub was having issues.


made navbar responsive and added effects

Hey @abhay-raj19
I have completed the issue #1 kindly review it and if there are any changes do let me know I'll do them
If everything is fine then kindly accept the request
Thank you

LGTM @ani-netizen


fix(solid): add missing dependencies to solid-start template

The solid template was missing the Panda CSS and Park UI dependencies and would not start.

@Curetix thanks mate


Fix/pagination

Docling paginates documents starting from 1. spacy-layout is adding one to page_no attribute of the document layout, which potentially results in mismatched pagination between document layout and span layouts.
In the case of one page pdfs this would lead to a run time Key Error as the the spans are being assigned to page_no 1, while the document would only have page_no 2.

Thanks, I think this might have actually been a regression I introduced in a recent PR switching from where the page numbers where sourced from.


RecordEncryptionST should execute tests against AWS (LocalStack) too

Is your feature request related to a problem? Please describe.
Once the AWS KMS integration is landed, we should adapt the RecordEncryptionST to test against AWS LocalStack.
It appears that there is a Helm Chart for Localstack so hopefully the pattern established for Vault should apply nicely.
RecordEncryptionST current hard-wires the Vault KMS provider.  That hard wiring need to be broken.  It should probably use @TemplateTests like RecordEncyrptionIT and KmsIT and let the KMS be plugged into the test.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Note: try to reach an already implemented solution for AWS cloud instead of LocalStack

We might want a system test that can run against either localstack or real AWS.


Group Chat - Unable to create group chat, app crashed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in app
Click on the green plus button Untested
Click on Create Group
Search for at least 4 users and add them to the group.
Click created group

Expected Result:
Able to create group chat
Actual Result:
Unable to create group chat, app crashed
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.60
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/168347419-fcf42722-0b6d-4d90-8cc4-aac0fb8e08fc.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Going to look into this

This is already fixed on main by https://github.com/Expensify/App/pull/8998. Going to CP it to staging

This is fixed now


Upcoming Beta

New discussion is up for the upcoming Beta -> https://github.com/vitebook/vitebook/discussions/99.

The work here is not applicable to Vitebook anymore and is being moved to Vessel. Sorry for the confusion.


try to fix sweepcut on graph with self loop

Thanks @MengLiuPurdue I'm incorporating these with a few other changes in my latest commit -- along with a regression test for this issue.


[7.x] Artisan db:create command

this PR adds php artisan db:create command to create new database .
i found with each new project i had to manually create DB and after that any new interaction with DB is done through migrations or models .
so by introducing db:create this will make the process from creating DB to the interaction with DB is done through the code.
also this command makes it convenient for other developers that are coming from Rails  or Symfony background . as both frameworks has rake db:create & doctrine:database:create

for technicality. i thought about multiple approaches but only two has stood out
first i thought about using doctrine/dbal but i found it a little bit frustrating to install the package for only creating DB
second one is using PDO . so by removing dbname= from PDO object configuration we can then execute SQL statement like creating DB without exception thrown that DB not found

IMO, this feels like such a trivial thing to do, I don't feel we need a whole command for it.
Is there a use case where it's difficult to create databases?

@browner12 i didn't face a case where it's difficult to create a database . but i found it convenient to have such a command without the small headache of creating DB manually

Can you add collation/charset information and a "exists" check:
CREATE DATABASE IF NOT EXISTS db_name DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

I found this while searching for db:create. Thank you @amaelftah for this PR! Disappointed to see it was not merged.
@taylorotwell Any way we could improve this PR to reconsider the decision? As @amaelftah mentioned, an equivalent command is often found in other frameworks and it is really convenient to have, especially for dynamic CI/CD environments.


[bug]: If number of images > 1, generated images are not saved to the gallery

Is there an existing issue for this?

[X] I have searched the existing issues

OS
macOS
GPU
amd
VRAM
32GB
What version did you experience this issue on?
3.0.1rc3
What happened?
Using SDXL 1.0 and the web interface. For both txt2img and img2img if the number of images in the 'General' tab is greater than 1, the image is not saved to the gallery after generation. After sampling completes the Invoke button's progress indicator switches to the scanning behavior (this is VAE invocation?) and then immediately we jump to the start of a new image generation and nothing appears in the gallery. No PNG file is written anywhere under output/. This doesn't always reproduce with txt2img but always happens for me for img2img.
Screenshots
No response
Additional context
No response
Contact Details
No response

GPU should be "mps" of course, not sure what happened there.

Thanks for the report. If I understand the issue correctly, this is a duplicate of #3932.
I expect the images to appear in the gallery only at the very end of processing. Please set images to 2 and let it finish to confirm.

Please set images to 2 and let it finish to confirm.

Got it. The images did appear when the batch completed.

Absolute dealbreaker. I need to be able to see the images as they're being generated, so I can cancel it and not waste time.


Line counter isn't working when lines wrap due to narrow screen sizes

⚠ Please verify that this bug has NOT been reported before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description

When a line wraps, the line counter doesn't skip, so down the bottom, they don't align
👟 Reproduction steps
Look at a line wrap
👀 Expected behavior
Skip numbering lines that wrap
😓 Actual Behavior
Just counts the number of lines regardless of if they wrap.
Dockge Version
1.3.4
💻 Operating System and Arch
Ubuntu 22.04
🌐 Browser
Safari
🐋 Docker Version
No response
🟩 NodeJS Version
No response
📝 Relevant log output
No response

#105


[For Discussion] Example generated LRO

Example to illustrate what a generated LRO might look like, to illustrate this for the Azure Load Testing service.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Template


Confluence wiki for StreamPipes

Ask infra to setup the new Confluence wiki for StreamPipes targeted at contributors.
Imported from Jira STREAMPIPES-21. Original Jira may contain additional context.
Reported by: riemer.

Closing the issue as it is inadvertently in open status due to migration from JIRA.


Implement OPCODE for opResereved, opReserved1 and opReserved2

Working on Implement the opcode for opResereved, opReserved1 and opReserved2

@mubarak23 how are things going?

@tdelabro am currently working on it,
but i need PR: #32 TO GET merged,
it has the opReserved  OPCODE implementation, which is something i need on this


翻译有误

原文：

number is a data type including everything from unitless numbers to lengths, durations, frequencies, angles and so on.

翻译成“等等无单位数字类型”明显失误嘛。

I guess, thank you! :)

LGTM


Implement on click event for all widget

Hello,
I am android developer and learning developing application in flutter.
I want to make on click listener for all the widget, Can you develop this feature in Flutter sdk ?
In android we can set on click listener for any view, but in Flutter right now only button widget have supported method onPress().
Thanks.

You can use GestureDetector or InkWell

Can you please post the code here how can I set onTap method for Icon or Text ?

See sample code in https://docs.flutter.io/flutter/widgets/GestureDetector-class.html.
Flutter uses the composition pattern instead of letting each widget have all types of features by inheritance.
The GestureDetector's child can be anything.


No reference for rtppd

Hello, I have a problem with the pp displayer and its telling me an error in the cmd when I start to play a map

Update https://github.com/OsuSync/OsuRTDataProvider this plugin


Common Contracts

Given contract interaction something like this:
web3 contract deploy token.sol
web3 contract list HASH # list functions
web3 contract call HASH FUNC INPUT1 INPUT2

Could pre-programed information about common contracts (e.g. ERC/GO-20) be used in a helpful way? Like for access without having the ABI files? Or to output a profile for a token:
web3 contract call -erc 20 0x37C93A80b5702A820CbC3050f0e9eC48a1D5e738
Name: TurboWallet Token
Token: TURBO
Total Supply: 100000000
Decimals: 18

@jmank88 what if we put abi files for the most popular contract types?(ie go20.abi)

Can we embed them directly?

We could store them in this repo and they could be used for this tool, explorer, etc. Similar to the networks list.

Can we embed them in the code so that the user doesn't have to bother with the abi file at all? They could use an alternate flag to indicate the interface, or even just a namespace the function e.g. -function GO20.totalSupply

They also can just download a release and not check out the source

I wasn't thinking the user would download them, would be transparent to the user, just keeping a repository of common abis so multiple tools can fetch them as needed.

What if we put in the repo the most popular abis (go20 and so on) and use file embedding to put them into binary (ie go-rice or vfsgen) - that would be transparent for both users (who checkouts the code and who uses precompiled binaries),  the only downside - size of the binary would be bigger.
Thoughts?

I'm not familiar with those tools specifically, but could we set up a simple command to essentially just parse the JSON via go:generate? Might be a little more light weight

We can use abigen to generate type safe go code to call instead of doing everything dynamically.


Add contacts summary

Generate 'contacts' summary file consistent with output for the SITREP toolkit.
Output fields to include:
locationId,
admin_2_name,
UNDER_FOLLOWUP,
PAST_7_DAYS,
PAST_14_DAYS

@adm-gis I did the testing and the output was correct.:)


About the best model parameters

Hello, I reproduced your experimental results and found that the effect was somewhat different from the results in the paper, can you share the pth file that has been trained in your paper?

Can you please illustrate how much different?
Because somewhat different gives me an impression of not being a significant difference. And in this case, this could be due to the different train/test splits or the Pytorch/hardware versions. You can train for than once and take the average.

Okay, thanks for the suggestion, my environment configuration is the same as yours, but there is a 2% error in the result, I will try to run it again and take the average of the results. best regardsOkay, thanks for the suggestion, my environment configuration is the same as yours, but there is a 2% error in the result, I will try to run it again and take the average of the results. best regards

Okay, thanks for the suggestion, my environment configuration is the same as yours, but there is a 2% error in the result, I will try to run it again and take the average of the results. best regards


make gapPollingInterval and gapThreshold configurable

no need for this anymore. It can be done on top of shaka player implementation of gap_polling.

no need for this anymore. It can be done on top of shaka player implementation of gap_polling.


Fix IE11 lacking support for template literals.

Fixes #245 by removing template literal strings and replacing with single quotes.

Thanks for this PR :+1:


No update available ?

Hello Sir,
I just found your repo and tried to use your script. I download it configured but the script seems that it needs a little update.
My workers doesnt seems working on my grass dashboard .. ??
I'm would like to know if there isnt any update regarding this repo ? Thanks

Just copy the repo link

Yes I did. But the bot dosent seem working.

https://github.com/Rambeboy/GRASS.git


No error message on invalid TSV

i.e. when any value in 4093-9999 is entered. They aren't dumped in the flair, but there's no reason given why.

Good call.

Fixed, we now get an error. (not deployed yet, will do it before I go to bed)


What does it mean gyro data unit

What is gyro measure unit 'g'  stands for

Have you found the answer?

I guess I did. That was long ago.


Remove deploy-specific configuration from repo

The settings in .env.production are specific to a particular deploy of the app. All production builds should not necessarily use these same settings.

Where is this configuration going to be stored now?

For the https://gui.dandiarchive.org/ deployment, it's stored in the Netlify configuration (and injected via environment variables). We want to provide more documentation about how dandiarchive.org is provisioned, but that's a separate ongoing task.
However, it's a somewhat open question to me whether:

the dandiarchive codebase is intended to exclusively power (and be tightly coupled to) the *.dandiarchive.org deployment
the *.dandiarchive.org deployments are just one canonical deployment of a more general dandiarchive codebase


Ministry Restricted - Protections and Audit Trails

As a Ministry User
I want all the same restrictions and customizations that IAO has for their restricted requests
so that I can be confident the request has not been inappropriately accessed.

Assumptions & Scope
This story will essentially duplicate all IAO restricted request restrictions/features, for Ministry restricted FOI requests.
Note: Requests that are restricted on the Ministry side, should NOT have the same restrictions on the IAO side of things. Only if it is restricted on BOTH the IAO and Ministry side, should the restrictions align across
What is IN scope?
Ministry restricted requests
What is NOT in scope?
IAO restricted requests
Acceptance Criteria
Scenario 1: Watcher Assigned

GIVEN a user has been selected as a watcher to a restricted request
WHEN the action is completed and the assignments updated
THEN a system generated comment will be posted in the request history saying "[USER] has made [USER] a watcher"

Scenario 2: Watcher Removed

GIVEN a user has been removed as a watcher to a restricted request
WHEN the action is completed and the assignments updated
THEN a system generated comment will be posted in the request history saying "[USER] has removed [USER] as a watcher"

Scenario 3: Assign Request - Ministry Manager

GIVEN a Restricted Request is in any state
WHEN the Ministry manager clicks on the primary assignment
THEN the names that will populate will be all Ministry users

Scenario 4: Assign Request - Complete Action

GIVEN a Restricted Request is in any state
WHEN a user is selected from the assignment list
THEN a modal will pop out with the options to continue or cancel
https://jacklyn808742.invisionapp.com/console/share/3W2O64AP5C/978958615

Scenario 5: Assign Request - Continue

GIVEN the Ministry manager is on the restricted assignment modal
WHEN the manager selects continue
THEN the modal will close, and the user assignment will update

Scenario 6: Assign Request - Cancel

GIVEN a user is on the restricted assignment modal
WHEN the user selects Cancel
THEN the modal will close, and the user assignment will remain as it was

Scenario 7: Assign Watcher

GIVEN a Restricted Request is in any state
WHEN the Intake manager clicks on the watcher assignment drop down
THEN they will see all active IAO users

Scenario 8: Assign Watcher - Complete Action

GIVEN a Restricted Request is in any state
WHEN the user is selected from the watcher list
THEN a modal will pop out with the options to continue or cancel
https://jacklyn808742.invisionapp.com/console/share/3W2O64AP5C/978958614

Scenario 9: Assign Watcher - Continue

GIVEN the Intake manager is on the restricted watcher modal
WHEN the user selects continue
THEN the modal will close, and the watcher assignment will update

Scenario 10: Assign Watcher - Cancel

GIVEN a user is on the restricted watcher modal
WHEN the user selects Cancel
THEN the modal will close, and the watcher assignment will remain as it was

Scenario 11: Un-Assign Watcher

GIVEN the Intake Manager is on a restricted request with the watcher drop down activated
AND a user is already assigned as a watcher
WHEN the user removes the assigned watcher as such
THEN the user shall be removed as a watcher, and be unable to interact with the request.

Scenario 12: Can't Assign to Team Queue

GIVEN a user is on a restricted request
WHEN they activate the assignment drop down
THEN any IAO team names will be greyed out an unselectable

Scenario 13: User other than Intake Manager Unable to Assign

GIVEN a user is on a restricted request
AND they are NOT the Intake manager
THEN the assignment and watching functions will be disabled
AND the user will be unable to change the assignment or watcher

Scenario 14: Tagging user

GIVEN a user is on the comment tab and is entering a comment in the RT Editor
WHEN they write an @ and the tag list populates
THEN the only names that shall appear and can be tagged are users assigned to the request as watchers or primary assignees and the IAO users

Scenario 15: Tagging user - Notification

GIVEN a user is tagging another assigned user in the comment
WHEN they select an assigned user and save the comment
THEN the user will receive a notification that they were tagged in the comment

Scenario 16: Attempting to tag other user

GIVEN a user is on the comment tab and is entering a comment in the RT Editor
WHEN they write an @ and they manually write out a name that is not in the tag list
THEN the text will not trigger a notification to that user, and no tag will be embedded in the comment

Scenario 17: View restricted requests on assignee 'My Requests' queue

GIVEN an assignee of a restricted request (ministry coordinator, IAO analyst, processing team manager)
WHEN they are on their 'My Requests' queue
THEN they will see only restricted requests that they are the assignee
AND each restricted requests will have an 'R' icon in the row
AND the applicant name will not appear; instead it was say restricted

Scenario 18: Restricted request 'Watching Requests' queue

GIVEN an assignee of a restricted request (ministry coordinator, IAO analyst, processing team manager)
WHEN they are on their 'Watching Requests' queue
THEN they will see only restricted requests that they are a watcher
AND each restricted requests will have an 'R' icon in the row
AND the applicant name will not appear; instead it was say restricted

Scenario 19: Search restricted requests on 'My Requests' queue

GIVEN an assignee of a restricted request (ministry coordinator, IAO analyst, processing team manager) is on their 'My Requests' queue
WHEN they enter 'restricted' in the search bar
THEN the queue will filter to show only assigned restricted requests
AND each restricted requests will have an 'R' icon in the row
AND the applicant name will not appear; instead it was say restricted

Scenario 20: Search restricted requests on 'Watching Requests' queue

GIVEN a watcher of a restricted request (ministry coordinator, IAO analyst, processing team manager) is on their 'Watching Requests' queue
WHEN they enter 'restricted' in the search bar
THEN the queue will filter to show only watched restricted requests
AND each restricted requests will have an 'R' icon in the row
AND the applicant name will not appear; instead it was say restricted

Scenario 21: No restricted requests on assignee 'My Requests' queue

GIVEN a user is not an assignee of any restricted requests (ministry coordinator, IAO analyst, processing team manager)
WHEN they are on their 'My Requests' queue
THEN they will NOT see any restricted requests

Scenario 22: No restricted requests on 'Watching Requests' queue

GIVEN a user is not an watcher of any restricted requests (ministry coordinator, IAO analyst, processing team manager)
WHEN they are on their 'Watching Requests' queue
THEN they will NOT see any restricted requests

Scenario 24: Not assigned or watching - no restricted requests on 'My Team' queue

GIVEN a user is NOT an assignee or watcher of a restricted request (ministry coordinator, IAO analyst, processing team manager)
WHEN they are on their 'My Team' queue
THEN they will NOT see any restricted requests

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

From sprint planning this morning - this is the amalgamated ticket of all remaining features needed for the Ministry restricted stories.
cc: @aparna-aot @richard-aot @lmullane

From sprint planning - devs asked we amalgamate all the AC's from the missing stories for Minisry side restrictions

Discussed with @aparna-aot around issue where potentially Ministry can tag IAO users if a request is restricted on the Ministry side - not realizing that its also restricted on the IAO side.
Decision: as long as the user that gets tagged can not access the request because they aren't assigned to it - it should be ok. Can revisit in a future user story if this is causing confusing or disruptive behaviour when in production.
cc: @lmullane

Note for testing - make sure cases where other users are inadvertently tagged by the other side, that they can't access the file itself if it ends up being a restricted file on their side. (ie: IAO is on a Ministry restricted request - attempt to tag a Ministry user thats not assigned to the request. Login as that Min user and confirm you are not able to access it)

QA'd, but just a couple things I need to confirm on Monday I didn't have time to dig into.

@aparna-aot - I'm not sure tagging is working correctly on ministry restricted requests (scenario 14).
For example, see EDU-2022-39869 or EDU-2022-00319.
When the request is restricted on the ministry side, I can only tag the following individuals when entering '@':

However, I can search for the following users when doing a targeted search (in this case, for those starting with the letter 'F'). No other users come up from other targeted searching, even those that came up when entering '@':

These users appear to be constant across all ministry restricted requests, and are the only ones that can be tagged in comments. These requests are not restricted on the IAO side, and I believe the ministry coordinator should be able to tag any IAO user in the request comments - which they currently are unable to. In addition, I cannot tag the user(s) in the 'IAO Assigned To' or 'Watchers' fields either.
Any thoughts? Happy to show you to clarify.
Otherwise, no issues for the other scenarios.

@KyEggleston Shall we connect quickly over call?

Outstanding issues resolved, closing ticket.


Create docker files for deploy

We will be using docker for running the application on the server.
docker-compose.yml will be used for convenience. Container for .NET have to be made with support for external modules

We will use traefik for reverse proxy.
2 containers for Christofel will be needed: C# bot, frontend static file serving.
Confiugration of Christofel will be in a volume. That means folders Embeds, Plugins, files config.json and config.production.json


Add rk-echo dependency

Codecov Report

Merging #17 (383139e) into master (4bf81cf) will decrease coverage by 6.53%.
The diff coverage is 0.00%.

:exclamation: Current head 383139e differs from pull request most recent head 0318e86. Consider uploading reports for the commit 0318e86 to get more accurate results

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   88.88%   82.35%   -6.54%
==========================================
  Files           1        1
  Lines          63       68       +5
==========================================
  Hits           56       56
- Misses          4        9       +5
  Partials        3        3

Impacted Files
Coverage Δ

boot.go
82.35% <0.00%> (-6.54%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad668ef...0318e86. Read the comment docs.


Is This Technique rely on real time ray-tracing

https://github.com/GPUOpen-LibrariesAndSDKs/Capsaicin/blob/7e3beea447e396ca97cc6a49e766c04b25d602e3/src/core/src/render_techniques/gi10/gi10.comp#L991

Hi,
This technique indeed relies on hardware-accelerated ray tracing.
You can find more details in our technical report as well as GDC presentation.

Hi,
This technique indeed relies on hardware-accelerated ray tracing.
You can find more details in our technical report as well as GDC presentation.

That disappointing. I was thinking this runs without the RT cores.

Hi,
This technique indeed relies on hardware-accelerated ray tracing.
You can find more details in our technical report as well as GDC presentation.

All right. thanks for your reply

Hi,
This technique indeed relies on hardware-accelerated ray tracing.
You can find more details in our technical report as well as GDC presentation.

That disappointing. I was thinking this runs without the RT cores.

maybe we can use SDF. While the name may also needs to be changed as "SDFGI", which may same as GoDot's stuff