fix: concurrent unmount when app is offline

Details
Fixes concurrent unmount (when deleting an expense report from self dm in offline mode).
Initially I thought that we are trying to update and unmount a view simultaneously, and the first idea was to postpone updates of some props and I added hook like:
const useScheduledUpdate = (v) => {
  const [value, setValue] = useState(v);

  useEffect(() => {
    setTimeout(() => setValue(v), 5000);
  }, [v]);

  return value;
}

But I just discovered that I'm postponing a crash for 5 seconds 😅
The second thing that I wanted to try is to cancel unmount operation if view is already unmounted - I added necessary code and discovered, that it breaks the app in some cases (for example when you open a "track expense" screen, then the spinner never disappears).
So I started to look closer and I discovered, that as soon as we adding { opacity: 0.5 } style - the app crashes immediately. So I tried to add { opacity: 0.99 } as initial value and the crash disappears (when I add { opacity: 1 } then crash appear again).
So I think as a temporary workaround it can be added to the codebase. And in a meantime I'll discover what's exactly causing the problem and provide a proper solution later.
Fixed Issues

$ https://github.com/Expensify/App/issues/48197
PROPOSAL: N/A
Tests

Open the app and log in
Navigate to self-DM
Tap + > Track expense > Manual
Create an expense
Disable the internet connection
Long tap the expense > Delete expense
Be sure that app is not crashing

Offline tests

Open the app and log in
Navigate to self-DM
Tap + > Track expense > Manual
Create an expense
Disable the internet connection
Long tap the expense > Delete expense
Be sure that app is not crashing

QA Steps

Open the app and log in
Navigate to self-DM
Tap + > Track expense > Manual
Create an expense
Disable the internet connection
Long tap the expense > Delete expense
Be sure that app is not crashing

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/412670fc-63d3-4d05-aa68-e370667bff7c

Android: mWeb Chrome
https://github.com/user-attachments/assets/547032c1-fb40-49fd-bca6-dfa2821f0846

iOS: Native
https://github.com/user-attachments/assets/d7c7c509-bc30-4dc3-9d5a-5c288dd58b27

iOS: mWeb Safari
https://github.com/user-attachments/assets/86a3b010-f180-4663-863d-c9e3d87f0a16

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/a42d6cec-0718-4b84-bdf5-99d8b2394310

MacOS: Desktop
https://github.com/user-attachments/assets/0b7769db-dc4e-494a-abd0-7432bce52bad

@suneox Do you want to do the review here?

@suneox Do you want to do the review here?

I’ve unassigned myself from the issue, so you can review this PR. Thank you!

Looks like setting the opacity to 0.99 is causing some display issues whilst online:
https://github.com/user-attachments/assets/cbc4976d-8b28-4350-a3a5-02d5e5f9f82d
Compare without the changes:
https://github.com/user-attachments/assets/d1ce321d-5f5f-4719-81cc-f07a6bf52dfc

@kirillzyusko Any thoughts on this?

@jjcoffee checking it now 👀

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Found another display glitch that doesn't happen on main (visible when hovering over a manual expense):

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.33-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


python311Packages.pyatv: 0.12.0 -> 0.12.1

Diff: https://github.com/postlund/pyatv/compare/refs/tags/v0.12.0...v0.12.1
Changelog: https://github.com/postlund/pyatv/blob/v0.12.1/CHANGES.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 237009 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.apple_tv
python310Packages.pyatv
python310Packages.pyatv.dist
python311Packages.pyatv
python311Packages.pyatv.dist


Parse error near `__inshellisense

Describe the bug
The app fails with .inshellisense/key-bindings.zsh:10: parse error near `__inshellisense' when I open terminal after the installation.
To Reproduce
Steps to reproduce the behavior:

Install the app on Mac M2 Pro
Open new terminal
Get the message.
Inshellisense does not work.

Expected behavior
Everything works fine
Environment

OS: macOS 14.0
Output of inshellisense --version: 0.0.1-rc.1
Nodejs Version: 16.0.0

Additional context
is -s zsh

  ERROR  pagedSuggestions.at is not a function

 file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/build/ui/sugges
 tions.js:48:48

 -Suggestion (file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/bu
            ild/ui/suggestions.js:48:48)
 -renderWithHo (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_mo
  ks          dules/react-reconciler/cjs/react-reconciler.development.js:7478:1
              8)
 -mountIndeterminateCo (/opt/homebrew/lib/node_modules/@microsoft/inshellisense
  ponent              /node_modules/react-reconciler/cjs/react-reconciler.devel
                      opment.js:11247:13)
 -beginWor (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_module
          s/react-reconciler/cjs/react-reconciler.development.js:12760:16)
 -beginWork$ (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_modu
            les/react-reconciler/cjs/react-reconciler.development.js:19569:14)

 -performUnitOfW (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_
  rk            modules/react-reconciler/cjs/react-reconciler.development.js:18
                703:12)
 -workLoopSy (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_modu
  c         les/react-reconciler/cjs/react-reconciler.development.js:18609:5)
 -renderRootSy (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_mo
  c           dules/react-reconciler/cjs/react-reconciler.development.js:18577:
              7)
 -performSyncWorkO (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/nod
  Root            e_modules/react-reconciler/cjs/react-reconciler.development.j
                  s:18193:20)
 -flushSyncCallb (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_
  cks           modules/react-reconciler/cjs/react-reconciler.development.js:29
                36:22)

  ERROR  pagedSuggestions.at is not a function

 file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/build/ui/sugges
 tions.js:48:48

 -Suggestion (file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/bu
            ild/ui/suggestions.js:48:48)
 -renderWithHo (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_mo
  ks          dules/react-reconciler/cjs/react-reconciler.development.js:7478:1
              8)
 -mountIndeterminateCo (/opt/homebrew/lib/node_modules/@microsoft/inshellisense
  ponent              /node_modules/react-reconciler/cjs/react-reconciler.devel
                      opment.js:11247:13)
 -beginWor (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_module
          s/react-reconciler/cjs/react-reconciler.development.js:12760:16)
 -beginWork$ (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_modu
            les/react-reconciler/cjs/react-reconciler.development.js:19569:14)

 -performUnitOfW (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_
  rk            modules/react-reconciler/cjs/react-reconciler.development.js:18
                703:12)
 -workLoopSy (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_modu
  c         les/react-reconciler/cjs/react-reconciler.development.js:18609:5)
 -renderRootSy (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_mo
  c           dules/react-reconciler/cjs/react-reconciler.development.js:18577:
              7)
 -performSyncWorkO (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/nod
  Root            e_modules/react-reconciler/cjs/react-reconciler.development.j
                  s:18193:20)
 -flushSyncCallb (/opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_
  cks           modules/react-reconciler/cjs/react-reconciler.development.js:29
                36:22)
The above error occurred in the <Suggestions> component:

    at Suggestions (file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/build/ui/suggestions.js:42:39)
    at ink-box
    at file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_modules/ink/build/components/Box.js:5:27
    at UI (file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/build/ui/ui-root.js:11:15)
    at App (file:///opt/homebrew/lib/node_modules/@microsoft/inshellisense/node_modules/ink/build/components/App.js:19:9)

React will try to recreate this component tree from scratch using the error boundary you provided, InternalApp.

This might be a combination of both node version && CRLF issues. See #16 for the parsing error as this is a duplicate of that. Which node version are you using @zhelenskiy?

@cpendery mentioned it in the description: 16.0.0.

@zhelenskiy, can you try again with 0.0.1-rc.3 once it gets published to npm?

The same

The same

@zhelenskiy you try running the is uninstall command to clear the key bindings and then create a fresh binding for zsh via is bind. It may still have left over CRLFs from the first time you created the binding

Ok, now it doesn't show anything in the new terminal, but it also does nothing at all. I use iTerm by the way.

Great, so you can start a new inshellisense session by running ^A or via running is -s zsh. It won't start one for you automatically on shell start

You'll need at least node 16.6.0 & higher based on Mozilla's docs for the .at function. This is the same issue as #14.


The path visualised at the end is not the shortest path.

AFAIK, A* is supposed to find the shortest path to the goal, but the final path display is clearly not that.
Am I miss-understanding something or is there a bug?
Is your heuristic admissible?

@Rizhiy A* does not guarantee the shortest path, it finds a path if there is one but the quality of it depends on the heuristic. I think this is a dupe of https://github.com/Tyriar/pathfinding-visualiser/issues/31
Apparently I wasn't watching this repo which is the reason for the response delay 😕

Ok, thanks


libuvc_ros: 0.0.8-0 in 'lunar/distribution.yaml' [bloom]

Increasing version of package(s) in repository libuvc_ros to 0.0.8-0:

upstream repository: https://github.com/ros-drivers/libuvc_ros.git
release repository: https://github.com/ros-drivers-gbp/libuvc_ros-release.git
distro file: lunar/distribution.yaml
bloom version: 0.5.26
previous version for package: null

libuvc_camera
* add ROS Orphaned Package Maintainers to maintainer tag (#40 <https://github.com/ros-drivers/libuvc_ros/issues/40>)
* Implement missing index select behavior (#27 <https://github.com/ros-drivers/libuvc_ros/issues/27>)
* Enable mjpeg support despite uvs_any2bgr shortcoming (#26 <https://github.com/ros-drivers/libuvc_ros/issues/26>)
* [libuvc_camera/src/camera_driver.cpp] use frame's capture time for   timestamp of ros message instead of callback time (#24 <https://github.com/ros-drivers/libuvc_ros/issues/24>)
* [libuvc_camera] support multiple video mode (#22 <https://github.com/ros-drivers/libuvc_ros/issues/22>)
  * [libuvc_camera] add detail error message if no image format support
  * [libuvc_camera] support multiple video_mode
* add new parameters in cfg (#21 <https://github.com/ros-drivers/libuvc_ros/issues/21>)
* Changed defaults: auto_exposure=True, auto_focus=aperture_priority
* Implemented AE priority, abs exposure/focus, autofocus, pantilt controls
* Contributors: Yuki Furuta, Josh Villbrandt, Kei Okada, Ken Tossell

libuvc_ros
* add ROS Orphaned Package Maintainers to maintainer tag
* Contributors: Kei Okada

@k-okada This fails on lunar for all platforms: X, Y, Z, Stretch

this should be fixed too -> https://github.com/ros/rosdistro/pull/15246


pytest-operator 0.17.0 breaks integration tests

It seems that the the pytest-operator version 0.17.0 breaks integration tests on teardown.
Failing job without pytest-operator being constrained: https://github.com/claudiubelu/waltz-integration-juju/runs/6065841857?check_suite_focus=true
Job passing after constraining pytest-operator<0.17.0: https://github.com/claudiubelu/waltz-integration-juju/runs/6073143526?check_suite_focus=true

0.18.0 is released -- and resolves this issue


[test/plugin] immigrate test lettuce scenario.

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues
https://github.com/apache/skywalking/issues/3583#issuecomment-567320256

Codecov Report

Merging #4113 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4113   +/-   ##
=======================================
  Coverage   27.31%   27.31%
=======================================
  Files        1140     1140
  Lines       25027    25027
  Branches     3619     3619
=======================================
  Hits         6835     6835
  Misses      17587    17587
  Partials      605      605

Impacted Files
Coverage Δ

.../core/remote/ServiceAndEndpointRegisterClient.java
44.94% <0%> (-2.25%)
:arrow_down:

...king/apm/agent/core/remote/GRPCChannelManager.java
66.66% <0%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed21e1...b568052. Read the comment docs.

LGTM


Search Feature Not Working: Empty Screen Displayed Regardless of Input

The current search feature in our application appears to be malfunctioning. Despite entering text into the search field, the result is always an empty screen.
Description
When users attempt to search by entering text, the expected search results are not displayed. Instead, an empty screen appears every time, making the search feature unusable.
Reference images and links

Can I take this issue?

Thanks for taking this!


please help me out with reactnative 0.67.1

I created an jsi example from scratch followed your blog . But it failed at compile stage (android ) , I cannot figure out what's the missing step cause I followed the steps from blog strictly. Maybe something changed from rn0.67.1 to rn0.63.4 of this template project.
I'd be graceful if you are able to provide an newer version example . thanks a lot 🙏.

@yaaliuzhipeng The code examples are older on the blog. But this template is updated and works on latest android. What you can do to build successfully is use build.gradle and CMakeLists.txt from this repo and your app should build successfully.
Also it would be good if you can share what error are you facing so I know exactly what to fix..

@yaaliuzhipeng The code examples are older on the blog. But this template is updated and works on latest android. What you can do to build successfully is use build.gradle and CMakeLists.txt from this repo and your app should build successfully.
Also it would be good if you can share what error are you facing so I know exactly what to fix..

thanks again. I'd like to try it again from scratch with your suggestion . I'll come back later no matter it works or not . if not , I'll post my issues here .😘

Well , my example app was initialized from react-native newest template which version is 0.67.1 . So I simplified some gradle code . Basically , the problem is now about the libjsi.so . Gradle Build error came out like below
Please set them or make sure they are set and tested correctly in the CMake files:
JSI_LIB

I thought the error might be the LIBRN_DIR which is "${BUILD_DIR}/react-native-0*/jni/${ANDROID_ABI}"
and yet I haven't found some dirs start with react-native-0* from the specified location .So I tried to find out something from the mmkv repository. And I did found the  jsi prebuilt directory inside ReactAndroid . Still got the same error .
it would be great if you can take a look at my example below ... thanks anyway
https://github.com/yaaliuzhipeng/react-native-awesome-jsi

I have the undefined reference to 'facebook::jsi::Value::~Value() error while making an android project on react native 0.67.1
I tried searching in the issues of react-native-mmkv and here but nothing helped :(
Do you have any clue how to fix this? @ammarahm-ed
I have only the 21.4.7075529 ndk and 3.10.2 cmake versions installed

Hello, React-Native documentation says JSI is available on versions on or after 0.68.0.
Could it be reason for this problem?
I wanted know, if JSI can be implemented on versions lesser than 0.68.0?
Thank you.


fix: browser incompatible sec258k1 dependency

Use browser compatible secp256k1 dependency

Issue being fixed or feature implemented

fixes #228
What was done?

Added browser compatible secp256k1 lib, updated ecdh derivation method to work with new lib, rename method from encryptSharedKey to deriveSharedSecret to more accurately reflect the methods intent.
How Has This Been Tested?

Using this lib and method successfully from DashpayJS to Android Wallet contactRequests and DIP15 Dashpay L1 Transactions. Tested unit test vector successfully.
Breaking Changes

Name change of the method, nothing is broken yet since the Dashpay plugin is not yet merged into monorepo.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[ ] I have assigned this pull request to a milestone

@markin-io I guess it's not actual anymore?


Support building image from jib.yaml in Maven plugin

It would be useful if the Maven plugin (and probably also Gradle plugin) supports building an image from a jib.yaml specification like the CLI's build command.

Unfortunately this project is primarily focused on critical bug fixes and platform evolution to ensure it continues to work for its supported use cases.  We are not accepting feature requests at this time.  Please see contributing.md


Updates us/nh/statewide source

Previous URL is no longer available

Any thoughts on what the conform error is caused by?
2020-01-09 03:43:10,363  WARNING: Error doing conform; skipping
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/openaddr/__init__.py", line 173, in conform
    csv_path, addr_count = task4.convert(data_source, decompressed_paths, workdir)
  File "/usr/local/lib/python3.5/dist-packages/openaddr/conform.py", line 606, in convert
    rc = conform_cli(source_definition, source_path, dest_path)
  File "/usr/local/lib/python3.5/dist-packages/openaddr/conform.py", line 1328, in conform_cli
    transform_to_out_csv(source_definition, extract_path, dest_path)
  File "/usr/local/lib/python3.5/dist-packages/openaddr/conform.py", line 1305, in transform_to_out_csv
    out_row = row_transform_and_convert(source_definition, extract_row)
  File "/usr/local/lib/python3.5/dist-packages/openaddr/conform.py", line 995, in row_transform_and_convert
    row = row_function(sd, row, k, v)
  File "/usr/local/lib/python3.5/dist-packages/openaddr/conform.py", line 955, in row_function
    row = row_fxn_regexp(sd, row, key, fxn)
  File "/usr/local/lib/python3.5/dist-packages/openaddr/conform.py", line 1069, in row_fxn_regexp
    pattern = re.compile(fxn.get("pattern", False))
  File "/usr/lib/python3.5/re.py", line 224, in compile
    return _compile(pattern, flags)
  File "/usr/lib/python3.5/re.py", line 293, in _compile
    p = sre_compile.compile(pattern, flags)
  File "/usr/lib/python3.5/sre_compile.py", line 536, in compile
    p = sre_parse.parse(p, flags)
  File "/usr/lib/python3.5/sre_parse.py", line 834, in parse
    raise source.error("unbalanced parenthesis")
sre_constants.error: unbalanced parenthesis at position 20
2020-01-09 03:43:10,485  WARNING: Nothing processed

Looks like the regex in street is broken.

Ah great! Thanks for catching that.

Beautiful! 😍
Just checked the data output. Looks good.


Android Implementation of authenticationValidityDurationSeconds

Should resolve Android issues mentioned in https://github.com/authpass/biometric_storage/issues/15

I've now implemented this slightly differently (catch exception, instead of manually keeping track of time). Should work now in 3.0.0-dev.1.


Deprecate activateAllRules

The activateAllRules flag seems more a like a debug feature than a proper features. Enable all the rules by default is not a good call in general. We have a lot of controversial rules and we even have rules than do exactly the opposite: UseDataClass and ForbiddenPublicDataClass.
Because of this flag we also have really strange configurations on some rules (excludes: ['**'] #4940).
I still understand that some people want to start enabling ALL our rules and then disable the ones that they don't like. But I think that #5089 helps for that use case way better.
Also, once we remove this we will simplify our configuration code a bit more (#4926)

Just my two cents.
I (and I'm sure others too) do not want to list all the rules Detekt has, it's just noise in the configuration. It's much simpler to opt in to allRules, and disable whatever is not necessary. It's a lot of maintenance burden to add every new rule on every update rather than getting them "for free" on the cost of updating a number.
Compare default (as an example of a config that lists "almost" everything) vs my opt out configs.
This might change if https://github.com/detekt/detekt/issues/4925 is possible... because then creating the new config is not tedious (except if there are comments for the configured rules... then it's still hell to add new ones.)
Other analysis tools:

Android lint has the same config and it survived many majors, because it's a good config option.
See also an example lint config which opts out of some that checkAllWarnings turns on automatically.
Java also has -Xlint:all.
Kotlin also turns on warnings by default (and there's no cherry-picking, except suppressWarnings=true.)

Just some historical context: activateAllRules or failFast as it was called (all rules + all defaults) was one of the first and most wanted feature back in 2016/2017.
Basically with the same argument as @TWiStErRob stated. Get all rules + defaults and only deactivate ones you disagree with a custom config.
It is also the reason why we allow to specify more than one yaml config and layer them.

Both points have sense. Thanks for the feedback. Closing :)


chore: Rename eth to evm

Renames Eth prefix to EVM across the QGB module

Codecov Report

Merging #922 (0645e4e) into main (943dc2e) will increase coverage by 0.02%.
The diff coverage is 51.80%.

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   26.09%   26.11%   +0.02%
==========================================
  Files          77       77
  Lines        9344     9347       +3
==========================================
+ Hits         2438     2441       +3
  Misses       6677     6677
  Partials      229      229

Impacted Files
Coverage Δ

x/qgb/keeper/keeper.go
57.69% <ø> (ø)

x/qgb/types/abi_consts.go
69.23% <ø> (ø)

x/qgb/types/data_commitment_confirm.go
0.00% <0.00%> (ø)

x/qgb/types/msgs.pb.go
0.63% <0.00%> (ø)

x/qgb/types/types.pb.go
0.78% <0.00%> (ø)

x/qgb/types/valset.go
0.00% <0.00%> (ø)

x/qgb/types/valset_confirm.go
0.00% <0.00%> (ø)

x/qgb/keeper/keeper_valset.go
27.11% <50.00%> (ø)

x/qgb/types/validator.go
39.79% <60.00%> (ø)

x/payment/types/payfordata.go
69.60% <95.23%> (+0.30%)
:arrow_up:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Time Window CompactionStrategy

What type of enhancement is this?
Performance
What does the enhancement do?
Now we've built a table compaction framework, and we should proceed with more compaction strategies, like time window compaction strategy in cassandra/scylladb.
Implementation challenges
TBD

@v0y4g3r I'd like to give it a try if you don't mind~

@v0y4g3r I'd like to give it a try if you don't mind~

Go ahead please. But you may have to write an RFC for that before coding.

It seems that the TWCS has been implemented at #930 . So, what's the difference between this one and that one?


Reformat the frontend to follow the design of the mockup

[x] Move results down to a separate part of the page (Not overlapping on the background trail.  Reference video for visual explanation)
[x] Implement a scroll feature after a search is entered to take the user down to the results
[x] Change existing format and frontend features inside style.css to match the mock up (Background colors, Trail detail legibility, and more general changes)
[x] Make room for filters and tags on the left hand side as well sort by drop down button above the results. (Look to mock video for reference)

Wasn't able to get trail detail looking like mockup but homepage and search follow mockup


build: Update use of set-output in workflows

Fixes #?
Context

Checklist

[ ] Review Contribution Guidelines.
[ ] Make sure all contributed code can be distributed under the terms of the
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Update documentation when applicable.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please squash your commits once once you've finished your changes.
Don't forget to read & sign the CL as well.


sw-cli doesn't map /index.html => /

Library Affected:
sw-cli
Browser & Platform:
Node v7.7.2
Issue or Feature Request Description:
The manifest generation caches "/index.html", but doesn't cache "/". So reloading the top-level URL/domain/etc 404's because that resource doesn't exist.
Perhaps we could have a 'for-free' rewriting rule (e.g., if we see a request for "/" and we have "/index.html", then serve that).
When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

@jeffposnick I believe we discussed this briefly earlier today. Imo, this is going to be a common expectation and exploring some level of baked in rerouting might make sense.

Equivalent logic in sw-precache: https://github.com/GoogleChrome/sw-precache/blob/776b05952bbdeebf9f35125e4f1b2a95f6e02d54/service-worker.tmpl#L141 (directoryIndex is configurable, and defaults to index.html).

Untested, but one option for implementation could be modifying the logic in RequestWrapper.match() to pass in some additional parameters to cacheWillMatch, along the lines of:
if (this.plugins.has('cacheWillMatch')) {
  const plugin = this.plugins.get('cacheWillMatch')[0];
  cachedResponse = await plugin.cacheWillMatch(
    {request, cache, cachedResponse, matchOptions: this.matchOptions});
}

And then you could implement the desired behavior by passing in a plugin to the RequestWrapper used by the precached URL handler in sw-lib:
const indexFallback = async ({request, cache, cachedResponse, matchOptions}) => {
  // If we already have a cache hit, then just return that.
  if (cachedResponse) {
    return cachedResponse;
  }

  // Otherwise, try again with the indexHtmlString value.
  if request.url.endsWith('/') {
    const urlWithIndex = request.url + indexHtmlString;
    return cache.match(urlWithIndex, matchOptions);
  }
};

const cacheFirstHandler = this.strategies.cacheFirst({
  cacheName: this._revisionedCacheManager.getCacheName(),
  plugins: [{cacheWillMatch: indexFallback}],
});

I like that approach because it extends the existing cacheWillMatch lifecycle callback inside of RequestWrapper to make it more useful, and then it lets you inject that new fallback behavior only at the place within sw-lib where it would need to live.


Add Sankey Support - #232

Changes

Added filterable Sankey diagram page. Filters are passed to the Sankey page using query string. Sankey page can be accessed from the Datasets page.
Fixed minor UI issues with the Data Tables and Visualization Modal.

Aligned Visualization, Data Table header, and Data Table on the Datasets and Upload pages
Aligned Select a data column buttons in Visualization Modal

I increased the vertical padding between Sankey nodes. This should address the text crowding when there's a lot of data.


get_image script doesn't work properly when dependent upon remote etcd

Using this architecture: https://coreos.com/docs/cluster-management/setup/cluster-architectures/#production-cluster-with-central-services
I'm having difficulty getting units for Deis components like deis-logspoout or deis-router to resolve a custom image using get_image.  Note that deisctl works just fine (and gets the right values) when invoked manually, so it seems the problem is contextual-- missing environment variables when the unit is started.
I have made numerous attempts to set the ETCDCTL_PEERS env variable ahead of get_image in the unit files (which I believe should make get_image work just fine), but somehow those attempts have all proven fruitless, which I am a little confused by right now.

This approach might work for me, but may not be seamless enough to work for everyone:
https://github.com/coreos/etcdctl/issues/115

Ok... so this turns out to be one component of a larger problem-- that Deis doesn't work out-of-the-box with the cluster architecture that CoreOS recommends for large-scale deployments.  I'm going to close this issue and open a new one that outlines the few challenges to overcome to remediate that and a proposal for how to do so.

This issue is now tracked as part of #3635


Claim BNT does not move over once countdown is done #632

Fixed #632

Fixed current wrong implementation. After locking period, it should show off button to claim.

@pingustar please review.

@pingustar please review.

@sirius651 just tested it and it does not move over automatically.
The claim button appears on the "Locked" side instead of moving over to the "Available to claim"

@pingustar yes, previously, it did not switch into claimable button after locking period, because still remain timer. so, I fixed it and It seemed clearer that the button changed at that location. do you think moving over to 'Available to Claim' would be more straightforward?

@sirius651 just tested it and it does not move over automatically.
The claim button appears on the "Locked" side instead of moving over to the "Available to claim"

@pingustar yes, previously, it did not switch into claimable button after locking period, because still remain timer. so, I fixed it and It seemed clearer that the button changed at that location. do you think moving over to 'Available to Claim' would be more straightforward?

@Velua do you know if thats okay to stay in the locked section? I remember something about claiming multiple locked BNT positions get merged and claimed at once.
Eg:
If you have 5 pending locked positions on the right side, they will get merged into one claimable action on the left side once the timer ended.

@Velua do you know if thats okay to stay in the locked section? I remember something about claiming multiple locked BNT positions get merged and claimed at once.
Eg:
If you have 5 pending locked positions on the right side, they will get merged into one claimable action on the left side once the timer ended.

@Velua do you know if thats okay to stay in the locked section? I remember something about claiming multiple locked BNT positions get merged and claimed at once.
Eg:
If you have 5 pending locked positions on the right side, they will get merged into one claimable action on the left side once the timer ended.

Correct, they should get consolidated, that way the user doesn't have to attempt to press it several times.

@Velua do you know if thats okay to stay in the locked section? I remember something about claiming multiple locked BNT positions get merged and claimed at once.
Eg:
If you have 5 pending locked positions on the right side, they will get merged into one claimable action on the left side once the timer ended.

Correct, they should get consolidated, that way the user doesn't have to attempt to press it several times.

@sirius651 is this still a draft?
using the preview link I dont see any positions on locked nor on claimable.

@pingustar  : once time over, the balance function was modified to recall. how can I reveal locked balance in Closed Positions? I can't see it from my side from some point on.


pull request for e2e test at 12/08/2016 12:15:02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


implemented smooth scroll

Fixed Issues

Smooth scrolling to top of the page on selection of category

Files Changed
File1.cs - Reason for change/add
Checks

[x] Naming Conventions
[ ] Server side code comments (proper English, grammar and no spelling mistakes)
[ ] Client side code comments (proper English, grammar and no spelling mistakes)
[ ] Unused variables, methods, blank spaces and name spaces.
[ ] Optimal Code and code formatting
[x] Commit History is proper, no merge is done.
[x] Commit/pull request messages should be proper to justify your feature
[x] All test cases are executed provided by tester.

Known Issues
Comments

This change is

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 systemjs.config.js#L5: Remove the unused function parameter "global".


Radio component toggleable property not following repository guidelines

What should be done
The Radio component uses the toggleable property to know whether the radio is disabled or not. This does not seem to follow the repository guidelines as we mainly use disabled everywhere in this repository.
In my opinion this should be changed.
Technical recommandation
This work will have to be done in the components-api repository too.

The toggleable property is not acting the same way as a disabled property so i'm closing this issue.
See https://api.flutter.dev/flutter/material/Radio/toggleable.html


Refactor code for all experiments

All experiment code (data wrangling, modeling, and plotting) should be able to run on Python 3 using the provided environment config file.
Also see https://github.com/cksteven/generating_categories_cbb/pull/1

Note: new code should reproduce all figures in the paper.


change scroll to top icon

Related Issue or bug
Fixes: #46
Describe the changes you've made
I mostly edited scrollToTop.js and style.scss, specifically added a new class scroll-icon to style.scss and removed your previous svg to use a new good-looking arrow icon
Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist:

[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generate no new warnings.
[X] New and existing unit tests pass locally with my changes.
[X] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original
Updated

@tuanthanh2067  Please reduce the height and width of the bottom to the top button.


FE/yarn start:prod throws an error

Problem description
Error:
ROR Error: NG0100: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'false'. Current value: 'true'.. Find more at https://angular.io/errors/NG0100
    at throwErrorIfNoChangesMode (core.js:6792:1)
    at bindingUpdated (core.js:12954:1)
    at bindingUpdated2 (core.js:12969:1)
    at pureFunction2Internal (core.js:25665:1)
    at Module.ɵɵpureFunction2 (core.js:25459:1)
    at AdminSidebarComponent_nav_0_Template (admin-sidebar.component.html:1:22)
    at executeTemplate (core.js:9614:1)
    at refreshView (core.js:9480:1)
    at refreshEmbeddedViews (core.js:10605:1)
    at refreshView (core.js:9504:1)

We already run DSpace on production for TUL and it is OK.


Curly Brackets (Bash on Windows) Windows 10 - Spanish Keyboard

I've installed terminus on Windows 10 and I use it with Linux Subsystem (Bash - Ubuntu), My keyboard distribution is Spanish (Spain) but I'm not able to write { or } in the shell. Instance it's writing other characters that are not the ones of the key that I'm typing; It's like if the program wasn't getting the characters that are been input in the system or has a problem with Spanish distribution because when I've tried with a English (US) keyboard it works properly.

Duplicate of #17


Errors & incorrect results

roles = {role: Champion(id=id_, region="NA") for role, id_ in roles.items()}
This line crashes because roles.items are already Champion objects.
This is my code:
champion_roles = get_data()
match = cass.get_match(2805226856, region="NA")
roles_winning_team = get_team_roles(match.blue_team, champion_roles)
roles_losing_team = get_team_roles(match.red_team, champion_roles)

Even then the roles dictionary looks questionable:
Role.top<PHONE_NUMBER>) = {Champion} Champion(name='Ezreal', id=81, region='NA') Role.jungle<PHONE_NUMBER>) = {Champion} Champion(name='Renekton', id=58, region='NA') Role.middle<PHONE_NUMBER>) = {Champion} Champion(name='Viktor', id=112, region='NA') Role.adc<PHONE_NUMBER>) = {Champion} Champion(name='Evelynn', id=28, region='NA') Role.support<PHONE_NUMBER>) = {Champion} Champion(name='Soraka', id=16, region='NA')
Clearly this is incorrect

Using your same code (or a slight variation on it) I get results that look correct:
Code:
champion_roles = get_data()
match = cass.get_match(2805226856, region="NA")
roles_winning_team = get_team_roles(match.blue_team, champion_roles)
roles_losing_team = get_team_roles(match.red_team, champion_roles)
for role, champion in roles_winning_team.items():
    print(role.name, champion.name)
print()
for role, champion in roles_losing_team.items():
    print(role.name, champion.name)

Results:
top Renekton
jungle Evelynn
middle Viktor
adc Ezreal
support Soraka

top Darius
jungle Rengar
middle Twisted Fate
adc Draven
support Karma```

How are you inspecting the dictionaries? Or can you give me more information to reproduce your results?


@Parameter and @Dataprovider conflict

The function below never gets called, causing all tests that use this dataprovider on it to skip.
@Parameters({ "successFile" })
@DataProvider(name = "Success Results")
public Object[][] successData(String successData) throws IOException {

    List<Object[]> destList = getValuesCsv(successData);
    return destList.toArray(new Object[destList.size()][]);
}

I was able to workaround by removing the @Parameters decoration and setting successData in the @BeforeClass method.

Even though this issue predates when compared to https://github.com/cbeust/testng/issues/906 I am closing out this one since there are some discussions and also work arounds posted in https://github.com/cbeust/testng/issues/906


No retry on "Invalid NAI Key" error?

Hi again, any chance it could be possible to auto-retry whenever hit with an "Invalid NAI Key" error, like when you get other error messages (such as numbered ones like error 500, etc) instead of interrupting whatever you were trying to do completely?
To elaborate it says invalid NAI key however just retrying manually without changing my key works...

Easy enough, also disabled a redundant account status check before gen.


Sensu2: allow using internal repo for real

Pull Request Checklist
please allow to use manage_repo set to false
Description
I have set in hiera:
 sensu::manag_repo: false

but it fails, since sensu::repo has several require dependency set in the manifests.
Related Issue
Fixes #1069
Motivation and Context
Cannot use my internal repository
How Has This Been Tested?
it should be trivial enough :)
General
skips repo if any2bool($manage_repo) is not true

please note, that now I have also tested the code.
The commit that I did earlier it was like the saying on the t-shirt: "I only test in production" :)

Thanks! Replaced by https://github.com/sensu/sensu-puppet/pull/1070


Support tailwind for routes and islands from plugins

Currently the tailwind plugin doesn't styles routes and islands provided by plugins.

This was mainly a note to myself and for the ability to link this issue when someone else reports the problem.
I'm well aware it styles routes/islands if listed, but the issue is that routes and islands provided by plugins. By their very nature they don't exist on the filesystem.
So I've started exploring a few options. Two workarounds that unblock people right now:

Vendoring the dependencies provides a workaround, in that the plugin source files then exist within the project. This is obviously a horrible user experience.
Plugin authors (or motivated users) can provide a safelist containing all the classes.

So as an example I have fresh.config.ts
import { defineConfig } from "$fresh/server.ts";
import tailwind from "$fresh/plugins/tailwind.ts";

import { blogPlugin } from "../../src/plugin/blog.ts";
import localConfig from "./local.config.ts";

export default defineConfig({
  plugins: [tailwind(), blogPlugin(localConfig)],
});

and tailwind.config.ts
import { type Config } from "tailwindcss";

export default {
  content: [
    "{routes,islands,components}/**/*.{ts,tsx}",
  ],
  safelist: [
    "max-w-screen-md",
    "px-4",
    "etc etc"
  ],
} satisfies Config;

This would require some utility for plugin authors to easily scan their classes and generate the list. (Generating it by hand is error prone and annoying, as I've recently discovered.) Then users can just copy and paste the safelist into their config and the styles will get created (or more accurately: not removed).
And what to do moving forward? The only viable option I see is to enhance the plugin API and the existing tailwind plugin. I suspect we would need to do something like the following:

Allow plugins to declare files that have tailwind classes.
Enhance Fresh's tailwind plugin to do something with that list of files.

Because tailwind's content configuration does not support URL paths, it's not as simple as just merging the list of files from plugins with those the user has provided. Perhaps the simplest is to generate our own safelist and merge it with whatever the user has provided. (Hopefully the user has provided nothing, since the tailwind docs say: Safelisting is a last-resort, and should only be used in situations where it’s impossible to scan certain content for class names.) The Fresh tailwind plugin would then basically be doing an automatic version of my second workaround mentioned previously.
The above is valid for devmode, where we have no build step. But if we're building something for deployment, then we could consider pulling in the list of files into _fresh and then referencing them there from the content array. This would simplify things, at least for this case.
I'll continue thinking about the problem, but I'm happy to receive feedback on the above or any other ideas.

i am seeing this issue. We use a set of atomic controls that are in sub libraries. These are not all islands, but rather are just reusable components in many cases (for layouts and common controls).
Right now, we've lost all styling on any of our subcomponents.
I tried adding something like this to the tailwind config
  content: [
    "{routes,islands,components}/**/*.{ts,tsx}",
    "https://raw.githubusercontent.com/fathym-deno/atomic-iot/integration/src/molecules/IoTDisplay.tsx",
  ],

But no luck with that. I'm working on creating a safelist for our packages for now, wondering what it might take to get this more plugged in.

I also just tried this:
  content: [
    "{routes,islands,components}/**/*.{ts,tsx}",
    // "C:\\Users\\{micha_8ygdgy8}\\AppData\\Local\\deno\\deps\\https\\deno.land\\**\\*",
    // "https://raw.githubusercontent.com/fathym-deno/atomic-iot/integration/src/molecules/IoTDisplay.tsx",
    "%LOCALAPPDATA%/deno/deps/https/deno.land/**/*",
  ],

Thinking that if i pointed it where everything is downloaded that might work, but no luck

@mcgear, is vendoring an option for you? That will put the plugin source files in your project directory, allowing tailwind to scan them.

Vendoring is a new concept to me, but i actually ended up taking a slightly different approach that is sort of a hybrid (i think) between vendoring and safelisting. I ended up creating a few helper methods that allow me to generate a file in each of the libraries that contains the meta.url and all of the tsx files. For instances where libraries export out the other libraries, the new helpers generate a config with all the components. Finally, in the fresh application, the exported components are combined into a .config (text) file and the tailwind config is updated to look into that file.
This way i don't have to safelist the tailwind classes (that was quite the endeavor), and the components being exported can be automated. Its a large file, but since tailwind setup is only incurred at startup, it seems to be working for me.
Source for the helpers can be found here:
https://github.com/fathym-deno/reference-architecture/blob/integration/src/utils/tailwind.helpers.ts
The dev pattern is as follows...
In the library that has tailwind classes that need to be added:
Updates to the deno.json (https://github.com/fathym-deno/atomic/blob/integration/deno.jsonc):
{
  "tasks": {
    "build:tailwind": "deno run -A tailwind-components.config.ts",
  },
  "imports": {
    "$std/"<EMAIL_ADDRESS>  },
}

And then in my src.deps.ts file (https://github.com/fathym-deno/atomic/blob/integration/src/src.deps.ts):
export * from<EMAIL_ADDRESS>
Then we add a tailwind-components.config.ts file (https://github.com/fathym-deno/atomic/blob/integration/tailwind-components.config.ts):
import { constructTailwindComponentsConfig } from "./src/src.deps.ts";

await constructTailwindComponentsConfig(
  import.meta,
  [
    {
      Directory: "./src",
      Extensions: [".tsx"],
    },
  ],
);

Once this is done, we execute the following command as part of our build task (or on its own):
deno task build:tailwind

After that is run, a new tailwind.components.ts file is generated:
export default [
	{
		Root: import.meta.resolve("./"),
		Components: [
			"./src/atoms/Action.tsx",
			"./src/atoms/forms/Input.tsx",
			"./src/atoms/forms/SlideToggle.tsx",
			"./src/molecules/ActionGroup.tsx",
			"./src/molecules/Display.tsx",
			"./src/molecules/LineItem.tsx",
			"./src/molecules/MenuButton.tsx",
			"./src/molecules/ResponsiveSet.tsx",
			"./src/molecules/Tabs.tsx",
			"./src/organisms/Features.tsx",
			"./src/organisms/Footer.tsx",
			"./src/organisms/Header.tsx",
			"./src/organisms/Hero.tsx",
			"./src/organisms/SignIn.tsx",
			"./src/organisms/SignUp.tsx",
			"./src/organisms/StepsFeatures.tsx",
			"./src/templates/BasicLayout.tsx",
		],
	},
];

In the case where there is a library that combines sub libraries there are a couple of additional changes...
In the src.deps.ts file, we import and export the tailwind-components.ts file from the child library (https://github.com/fathym-deno/fathym-atomic/blob/integration/src/src.deps.ts):
import FATC from<EMAIL_ADDRESS>export const FathymAtomicTailwindComponents = FATC;

And then an update to the tailwind-components.config.ts file (https://github.com/fathym-deno/fathym-atomic/blob/integration/tailwind-components.config.ts):
import {
  constructTailwindComponentsConfig,
  FathymAtomicTailwindComponents,
} from "./src/src.deps.ts";

await constructTailwindComponentsConfig(
  import.meta,
  [
    {
      Directory: "./src",
      Extensions: [".tsx"],
    },
  ],
  [
    ...FathymAtomicTailwindComponents,
  ],
);

Then, when the build:tailwind task is run, the tailwind.components.ts file is generated with the child library too:
export default [
	{
		Root: import.meta.resolve("./"),
		Components: [
			"./src/atoms/Logo.tsx",
			"./src/molecules/azure/connect.form.tsx",
			"./src/molecules/azure/existing.form.tsx",
			"./src/molecules/eac/calz.form.tsx",
			"./src/molecules/eac/connect.form.tsx",
			"./src/molecules/eac/create.form.tsx",
			"./src/organisms/FathymHeader.tsx",
			"./src/organisms/feed/BuildFeedCard.tsx",
		],
	},
	{
		Root<EMAIL_ADDRESS>		Components: [
			"./src/atoms/Action.tsx",
			"./src/atoms/forms/Input.tsx",
			"./src/atoms/forms/SlideToggle.tsx",
			"./src/molecules/ActionGroup.tsx",
			"./src/molecules/Display.tsx",
			"./src/molecules/LineItem.tsx",
			"./src/molecules/MenuButton.tsx",
			"./src/molecules/ResponsiveSet.tsx",
			"./src/molecules/Tabs.tsx",
			"./src/organisms/Features.tsx",
			"./src/organisms/Footer.tsx",
			"./src/organisms/Header.tsx",
			"./src/organisms/Hero.tsx",
			"./src/organisms/SignIn.tsx",
			"./src/organisms/SignUp.tsx",
			"./src/organisms/StepsFeatures.tsx",
			"./src/templates/BasicLayout.tsx",
		],
	},
];

Finally, in the application that needs the tailwind styles, there are a few updates in the deno.json imports to make the tailwind-components.ts file importable (https://github.com/o-biotech/biotech-manager-web/blob/integration/deno.jsonc):
"@fathym/atomic/": <EMAIL_ADDRESS>
Then in the tailwind.config.ts file you leverage another helper to generate the compound components file (./build/tailwind-components.config) in a build directory (https://github.com/o-biotech/biotech-manager-web/blob/integration/tailwind.config.ts):
import { buildTailwindComponentsConfigs } from "@fathym/common";
import BiotechAtomicTailwindComponents from<EMAIL_ADDRESS>
const tailwindComponents = [
  ...BiotechAtomicTailwindComponents,
];

await buildTailwindComponentsConfigs(tailwindComponents);

export default {
  content: [
    "{routes,islands,components}/**/*.{ts,tsx}",
    "build/tailwind-components.config",
  ],
} satisfies Config;

With all this in place, tailwind is correctly generating what we need to see things working.
We have several libraries that needed this, so wanted something that would work for us in the short term.
Working on an issue with our docker container build (https://github.com/o-biotech/biotech-manager-web/actions/runs/7458873509/job/20293710568), but it is working locally.

I did try vendoring, but with one of the octokit libraries it fails:
deno vendor --unstable main.ts
error: Module not found "https://esm.sh/v135/<EMAIL_ADDRESS>    at https://esm.sh/v135/@octokit/webhooks@12.0.8/dist-types/types.d.ts:4:40

We can use deno_graph to extract dependencies of plugins (i.e. all the .tsx files a plugin uses).  Then I'm sure there's some "easy" way to get the content of the file.
How does this help? I spent a few hours looking into modifying tailwind to support "remote content". But during my investigation, I stumbled upon this jewel:
    content: [
      {
        raw: html` <div class="md:w-full"></div> `,
      },
    ],

So this is a way of putting raw file content directly into tailwind -- it doesn't matter whether this content is local or not. Once I saw this, I realized I can just close the tailwind project (at least for now) and no longer make changes there. Instead we can simply modify compiler.ts here (or right after that block...) to inject the raw content of the plugin dependencies. Then all of this "remote content" will get scanned by tailwind, as if it were local.
I have bits and pieces of this working right now. I'll wire everything up later today and create a PR. Let's see what @marvinhagemeister has to say about the approach.


[bug 1213340] Add fields to querystring in hb data view

Gregg said it helps to be able to restrict the hb data list to just
fields he's interested in. This helps him debug his
problem-of-the-moment.
I wanted to implement this quickly, so I added a fields param to the
querystring as well as some minor stuff to make sure it's persisted via
links. I also added a list of all the fields at the bottom of the page
so Gregg can concoct his urls by hand.
If this turns out to be much used, we'll want to add a form to make it
easier to select and deselect fields.
r?

@mythmon Does this look good enough?

^^^ Fixes the unfinished comment.

This looks good. The only thought I have is that the UI code you wrote looks like the kind of thing Django Forms are supposed to "fix", specifically the widget system. Though I don't actually have much experience with Django Forms, so I'm not sure if it is actually similar.
r+

Yeah... Mostly I'm dragging my feet because I don't want a big form on the page and don't know of a better way to do it. I did think about doing it as a text-box, but ... that's kind of like fiddling with the querystring.
Anyhow, I think it's worth pushing off that work until I have a better feel for how Gregg will use this.

Thank you!


missing sort icons

Without extra work, the icons for sorting from fontawewsome do not show up.

If you check my demo, you can see that the font awesome icons are listed as a resource.
You will have to import them by yourself.
See https://jsfiddle.net/arnedesmedt/7my8L42q and open the resources panel on the left.
I can't include all those icons in the library because it will increase the size of the package and their can be cases where you don't use the icons, for example use your own icons, or don't use any icons if you use the table as a basic table.

Yes, they're in the demo. Which is where I found out about them.
I just thought it would be nice to mention it in the readme.

I'll reopen this issue to mention it in the readme.

It is mentioned in the readme.


Session.swift Alamofire 5.4.3 - Session.deinit

The below crash has occurred only when we update 5.4.2 and 5.4.3 and we don’t get any crashes regarding session in below 5.4.1 version. I have updated the version details and code below:
Session create:
func sessionManager() -> Session {
  	//SSL pining
        instantiateTrustKit()
        if let manage = self.manager {
            return manage
        }
        else {
            let configuration = URLSessionConfiguration.default
            configuration.timeoutIntervalForRequest = 30
            self.manager = Session(configuration: configuration, delegate: CustomSessionDelegate())
            guard let sessionManager = manager else {
                return Session.default
            }
            return sessionManager
        }
    }

Cancel ongoing request:
func cancelAllActiveRequests() {
        sessionManager().session.getTasksWithCompletionHandler { dataTasks, uploadTasks, downloadTasks in
            dataTasks.forEach {
                $0.cancel() }
            uploadTasks.forEach {
                $0.cancel() }
            downloadTasks.forEach {
                $0.cancel() }
        }
}

Crash Stack trace:
Crashed: com.apple.root.background-qos
0  libobjc.A.dylib                0x25dd0 objc_release + 16
1  Alamofire                      0xb4b90 Session.deinit + 204 (Session.swift:204)
2  Alamofire                      0xb4c2c Session.__deallocating_deinit + 202 (Session.swift:202)
3  libswiftCore.dylib             0x383c98 _swift_release_dealloc + 40
4  libswiftCore.dylib             0x384b90 bool swift::HeapObjectSideTableEntry::decrementStrong<(swift::PerformDeinit)1>(unsigned int) + 288
5  SampleApp                       0x115648 sessionManager() + 46

Alamofire version: Alamofire 5.4.3
Xcode version: Version 12.5
Swift version: 5.4
Crash occured device OS: iPhone14.5 above
Crash Title: Session.swift line
Crashed: com.apple.root.background-qos
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000000431c70a0

While sending requests we called the sessionManager function to get the current session.
When the user opens the app for the first time and the user navigates to the main screen the cancel request function will be called.

Could anyone know the above issue?
NOTE: Can't able to reproduce this issue.

Thanks for your information. I have implemented point 2&3 in my code. And also I write the code based on your feedback could you check this below:
Existing code:
func sessionManager() -> Session {
//SSL pining
instantiateTrustKit()
if let manage = self.manager {
return manage
}
else {
let configuration = URLSessionConfiguration.default
configuration.timeoutIntervalForRequest = 30
self.manager = Session(configuration: configuration, delegate: CustomSessionDelegate())
guard let sessionManager = manager else {
return Session.default
}
return sessionManager
}
}

New code:
    public static let customSession: Session = {
        let configuration = URLSessionConfiguration.af.default
        configuration.timeoutIntervalForRequest = 90
        return Session(configuration: configuration)
    }()

   Let me know your feedback on the new code.

That looks good, though isn't quite the same as your original code, since you're not using the custom delegate anymore. Additionally, timeoutIntervalForRequest probably isn't what you want. That value determines the timeout between bits of data in a response. What you probably want is URLRequest.timeoutInterval, which is the timeout of the initial connection.


Update virtual-machines-linux-azure-dns.md to fix broken link

#sign-off

Hi @RicksterCDN, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (rclaus). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


integration: Fix missing taiga test action.

Previously testing webhook from taiga site would result in error.
This adds missing 'test' action to taiga webhooks.
Fixes #13317
Testing Plan:
Tested with ./tools/test-all

Merged as 12bd3c04c044c9a1d7d67ce6a2b9a3c4510ad127 after a bit of rewording, thanks @kostekIV!
If you're interested in helping with other issues in the integrations area, let me know and I can make some suggestions.


Remove shellcheck comment

Signed-off-by: Arnaud Meukam<EMAIL_ADDRESS>

Aka I want to test the binding for auto-deployment in https://github.com/kubernetes/k8s.io/pull/3663

@ameukam, this change prevents splitting of the array into items and makes the a single iteration of " us-central1 us-west1".
I've made a PR to revert it
https://github.com/kubernetes-sigs/oci-proxy/pull/59


Wrong format on srt

if I send in
1
00:00:13,960 --> 00:00:18,416
I cannot believe it.

It throws an error, Isn't the correct format on srt with a " , " at millisecond?

Yep, you are right. I've just found the same. A valid .srt file fails to parse because of that.
Guessing it's a result of the regex checking for a WebVTT-style time (so not allowing a comma):
https://github.com/goatandsheep/node-srt/blob/master/lib/parser.js#L14

@niklasnilsson87 @gregmsanderson I just replaced all ,s to .s to work around this issue on my fork, waktaplay/node-srt-ts.
Can you try in this way?
(https://github.com/waktaplay/node-srt-ts/blob/v3.0.3/src/lib/parser.ts#L132,
https://github.com/waktaplay/node-srt-ts/blob/v3.0.3/src/lib/parser.ts#L144,
https://github.com/waktaplay/node-srt-ts/blob/v3.0.3/src/lib/parser.ts#L149)


Failed to extract shortcode: template for shortcode "icon" not found

When building the site I get the following error:
 hugo
Start building sites …
hugo v0.140.1+extended+withdeploy darwin/arm64 BuildDate=2024-12-23T16:26:35Z VendorInfo=brew

Total in 13 ms
Error: error building site: process: readAndProcessContent: "/Users/atael/Documents/GitHub/something.md:16:164": failed to extract shortcode: template for shortcode "icon" not found

The markdown referenced above is:
using the "hamburger" icon ( {{% icon icon="fa-solid fa-bars" %}} )  in the top left corner

I have tried hugo mod clean but with no success.

Without seeing your project I can only guess: There is something wrong with your theme installation.
https://mcshelby.github.io/hugo-theme-relearn/introduction/quickstart/index.html


[QA] No Reward Given After Completing Mini-Games in 100Avatars Garden

Explorer Alpha build versions:

v0.27.0

Issue Description:
In the 100Avatars Garden scene, completing the mini-games does not grant the expected reward. Tested with two different accounts on two different games (Hammercide and Sticky Business).
STR:

Launch the Explorer.
/goto -55,-121 (100Avatars Garden scene).
Complete the available mini-game (Hammercide or Sticky Business).
Check for the reward.

Expected behavior:

Players should receive the reward upon completion of the mini-game.

https://github.com/user-attachments/assets/83d84b3e-19b3-401a-9f52-61d20663add7
Current behavior:

No reward is given after completing the mini-game.

https://github.com/user-attachments/assets/f92a826e-eb10-47ac-9456-edf524c00aa9
Additional Notes:
Windows 11. 12th Gen Intel(R) Core(TM) i7-12650H 2.30 GHz. nvidia geforce RTX
Macbook M1 Pro Sonoma 14.5

100 Avatars appears to no longer be working.


XCode 12 Ipad IOS 14.4 Swift 5.2.1 compile problems.

I'm going up the AudioKitSynthOne learning ramp, and so far I have managed to build it on XCode 11.3.1, and deploy on an IPad 8th generation under IOS 14.4. I had to patch the XCode devices Developer/Platforms/IPhoneOS.patform/DeviceSupport /14.4 by copying in the same from XCode12, and it does upload to the device and run, but I am unable to debug.
When I switch to XCode 12 and build I get the following errors:
module compiled with Swift 5.1.1 cannot be imported by the Swift 5.3.2 compiler: /Users/simontuffs/github/AudioKit/AudioKitSynthOne/Pods/AudioKit/iOS/AudioKit.framework/Modules/AudioKit.swiftmodule/x86_64-apple-ios-simulator.swiftmodule
Adding 5.1.1. to the XCode toolchain gets me this error:
The Swift standard library from the toolchain cannot be used on devices.

Select a macOS or simulator run destination instead, or use a different toolchain that only provides the compiler.''

I am stuck. The build process for AudioKitSynthOne is very complex, I have been peeling away at the onion for three days now, and with the success on deployment I am encouraged to continue, the overall software synthesizer is superb, and I am looking forward to getting into development and doing fun things with it.
But the XCode chain, Swift incompatibilities are awful: granted this my first time on Xcode+Swift, but there appear to be systemic problems with version compatibilities that somebody must know how to overcome, but I can't figure them out.
Any suggestions appreciated.
BTW: to deploy on the Ipad I had to use the automatic certificate generation trick, and delete the duplicate certificate that expires in 2023 and replace it with the 2030 cert. This took some figuring out. Also, it's important to make sure you use the same bundle identifier for the OpenSignal and AudioKitSynthOne targets otherwise Xcode goes into a mode of ping-pong reverting the certificates between the two, and does not stabilize.
I'm happy to write up the whole process to get running at this point on XCode 11.3.1/IPad8/IOS14.4, if I can get the code running on XCode 12, otherwise it seems I will have to wait for somebody else to figure it out.

Hi Simon –
Yes, you are correct. There are a lot of dependencies and Synth One might not be a good intro project for AudioKit. A better entry point maybe the Cookbook https://github.com/AudioKit/Cookbook or for a complete app example that's in the app store: https://github.com/AudioKit/AUv3-Example-App

hey thanks Matt: I understand that I'm taking the hard path, but I really do want to bootstrap the synth into hardware, then contribute back to the project. I'm good to go with the Xcode 11 build on ipad, and debug using simulators, since the simulators work really well except for the multi-touch keyboard, and I was able to plug in a midi keyboard and map it to the synth using the audio-midi controller.  I will probably continue to barge down this path, because I'm stubborn and it happens to be a good way to learn the technology stack. We learn more from failure, as it were.


Theme generator

Bug, feature request, or proposal:
feature request
Just stumbled over https://cimdalli.github.io/mui-theme-generator/ and something like this would be a great asset!

This is something we've wanted to do for a long time, but we have so many things that are higher priority that there are still no plans to do it any time soon.


Add hostname-override flag to root command to support overriding SNI hostname

@jwineinger 👋🏻 would you mind signing the CLA for your contribution?

I have read the CLA Document and I hereby sign the CLA


Detox doesn't work with React-Native 0.59 + React-Navigation

Describe the bug
After updating our project to React-Native 0.59, I'm facing issues running Detox.
The build works correctly but the application crashes as you open it with Detox.
TypeError: param is not an Object. (evaluating ''__isNative' in param')
It looks like it might be an issue by be correlated to react-navigation / react-native-gesture-handler. I use react-navigation 3.3.2
The application runs fine without Detox.
As Detox adds this cursor effect to know where it taps, I think it might be the reason why it breaks only when the app runs with Detox.
I've created a project on my github that reproduces the bug:
https://github.com/alexmngn/DetoxBug
Screenshots

Environment (please complete the following information):

Detox: 11.0.0
React Native: 0.59.1
React Navigation: 3.3.2
Node: 11.10.0
Device: iOS Simulator
Xcode: 10
iOS: 12.1
macOS: 10.14.3

I can confirm this issue in my project with iOS, also using Detox 11.0.0, RN 0.59, and react-navigation 3.3.2

I can also confirm this issue. Using the same specs as the above ^.
CC @brentvatne maybe you have an idea here?
It seems like https://github.com/react-navigation/react-navigation-stack/blob/master/src/views/StackView/StackViewLayout.js#L110 is null when using detox, but is not when not using detox. Which is why I'm pinging you here, since I can't figure out why that would be null in some cases, and not in others. I couldn't figure out what was necessarily different about running detox test vs just running react-native run-ios that would cause one to be null and the other to not.
When it is null, it passes it here https://github.com/react-navigation/react-navigation-stack/blob/master/src/views/StackView/StackViewLayout.js#L303 to a PanGestureHandler which then dies at this check https://github.com/kmagiera/react-native-gesture-handler/blob/c9f7c46b42966c0ec9c7f97df3d5a119ce789ae6/createHandler.js#L42.
All of the above plays nicely together when not running Detox.
I also made a mvce https://github.com/zibs/mvce-detox-gesture-handler if the above one doesn't work. You can test it by running yarn, and then react-native run-ios to see it work, and then detox test to see it fail.

@zibs - thanks for doing that! can you try to repro this without using react-navigation at all, just react-native-gesture-handler?

@brentvatne good call. I've updated the repo https://github.com/zibs/mvce-detox-gesture-handler to use only a PanGestureHandler, and commented out all of the react-navigation code, and am getting the same result after running detox test (it works fine if built normally still). So it looks like it's isolated between Detox and rn-gesture-handler. Something still to do with onGestureEvent={this._onGestureEvent} being null I assume.

@zibs So basically commenting like this:

Will allow for detox to run:

But the issue remains the same, and from my understanding(I am not familiar with internals of both Detox and RNGH), this is likely because Detox adds something that is failing to pass this check(most likely cursor effect mentioned by @alexmngn), but I can't pinpoint where it is within Detox to check it out.

OK, modifying this check:
return (
   param !== undefined &&
   typeof param !== 'function' &&
   (typeof param !== 'object || !('__isNative' in param)) &&
   name !== 'onHandlerStateChange' &&
   name !== 'onGestureEvent'
);

into:
function isObject(obj) {
  return obj === Object(obj);
}

return (
    param !== undefined &&
    typeof param !== 'function' &&
    (!isObject(param) || !('__isNative' in param)) &&
    name !== 'onHandlerStateChange' &&
    name !== 'onGestureEvent'
  );

Solves this issue, because Detox is passing something that is a false positive or a false negative and it effectively breaks this check. Still can't actually figure out was is Detox putting in there exactly

Hi guys,
I am not sure what is going on here. We do not use React Navigation.
Gut feeling tells me this isn't Detox related, but if you can assist tracking down what you think is causing this from Detox, I'd be happy to investigate and assist.
Thanks

Hi guys,
I am not sure what is going on here. We do not use React Navigation.
Gut feeling tells me this isn't Detox related, but if you can assist tracking down what you think is causing this from Detox, I'd be happy to investigate and assist.
Thanks

You are partially right, Detox is not entirely at fault, and React Navigation is out of this scope completely. Issue comes from React Native Gesture Handler(I am submitting a PR to fix that, since it is really small) that receives even that has "null" as a param, this event comes from Detox.
So, what I am actually interested in(and I hope you or anyone working on Detox could help me out) is where and how Detox adds gesture events, since this events are what were breaking RNGH and maybe, theoretically, we can prevent that by adding fix within Detox itself.

Detox simulates events from the native, like all events. It uses the same API Apple uses to send events. That's why the issue seems strange to me.

As far as I understand, this triggers events:
https://github.com/wix/Detox/blob/e7cbb696d7f8a1beff3ac50e319dbcca1aa2b60e/detox/ios/Detox/DetoxUserActivityDispatcher.swift#L67
But what bothers me is that even having such test:
it('App loaded', async () => {     await expect(element(by.id('RootView'))).toBeVisible()   })
Passes some gesture event(I am assuming it is coming from Detox, still I might be wrong) and I can't find the source of this event.
I'll be able to dig into this further later this week, so I'll do updates as soon as I investigate further into this.

@ddzirt Your fix seems to make it play nicer with rngh, but still did not solve my problem when using react-navigation, and it seems to be because:
This ternary: https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/Animated.js#L15 seems to be called with Platform.isTesting being true, and so Animated.event returns null: https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/AnimatedMock.js#L122 as seen there. I assume this is why we see Animated.Event being null is certain cases with gesture-handler and react-navigation.
To make my detox tests work fully, I have to comment out the ternary in first link so that my app runs with AnimatedImplementation and not AnimatedMock.

@ddzirt I don't understand what the line you quoted has anything to do with this thread. That is our internal triggering mechanism for mocked NSUserActivity.

@LeoNatan Any thoughts on why I need to use AnimatedImplementation vs AnimatedMock? Detox seems to default to using AnimatedMock, which causes Animated.event's to be null, as shown by my links in the above comment. This makes react-navigation no longer work (and causes that rngh crash).

Sorry, I have no idea what those are. I don’t think Detox has any relation to those.

Np - just curious if you have any ideas on your end on how something internally may have affected how Animated works.

No. Detox operates natively only. RN decisions, especially in JS, should be oblivious to Detox.

@ddzirt Your fix seems to make it play nicer with rngh, but still did not solve my problem when using react-navigation, and it seems to be because:
This ternary: https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/Animated.js#L15 seems to be called with Platform.isTesting being true, and so Animated.event returns null: https://github.com/facebook/react-native/blob/master/Libraries/Animated/src/AnimatedMock.js#L122 as seen there. I assume this is why we see Animated.Event being null is certain cases with gesture-handler and react-navigation.
To make my detox tests work fully, I have to comment out the ternary in first link so that my app runs with AnimatedImplementation and not AnimatedMock.

I forked RNGH(posting actual RNGH version), made a fix and tested it on my actual project that has such setup:
`"react": "^16.8.3",
"react-native": "0.59.1",

"react-native-gesture-handler": "^1.1.0",

"react-native-reanimated": "^1.0.0-alpha.12",

"react-navigation": "^3.3.2",

`

@zibs So, I took your project and tested my solution on it:

It works. If you wish to try it yourself I can push this.

Guys, now that https://github.com/kmagiera/react-native-gesture-handler/pull/525 has been merged, can I close this issue?

Guys, now that kmagiera/react-native-gesture-handler#525 has been merged, can I close this issue?

In my opinion we can close this one, since the issue is not directly connected to Detox itself(or at least I could not reproduce issue after applying a fix to RNGH). Maybe anyone has specific project setup that can showcase the issue and I'll look into it?

Let's close it. If something comes up that Detox doesn't do correctly, please open a new issue. Thanks

@ddzirt I have tried your changes, it looks like it doesn't throw that error anymore, though react-navigation doesn't seem to work at all. Not sure if it's related though.
Tapping on a button to navigate to a screen (in a stack navigator) doesn't do anything.

Hi @LeoNatan  this a big blocker , if we are trying the new changes then navigation stops working and if we wont then there is an error as mentioned in trail. It is very important to upgrade now on RN 59 as from August 1, 2019 Google Play will not accept apps with 32 bit only .so files. So from 59 64 bit support is added . Please can we really take care of this it will be blocker for detox growth even.

I don't understand what I am supposed to do. I believe Detox works as expected. I believe the issue should be directed at React Navigation.

@alexmngn try using this:
await device.disableSynchronization();

Wait. If synchronization is a cause of issues, please try running the test with the --debug-synchronization 200 argument and see where it is stuck. This will help understand where in React Navigation there is an issue.

Tried both none is working seems to be an issue with navigation
Yogesh Thanvi
QA Team Lead
Punchh Tech India Pvt Ltd
On Tue, Mar 26, 2019 at 6:28 PM Leo Natan<EMAIL_ADDRESS>wrote:

Wait. If synchronization is a cause of issues, please try running the test
with the --debug-synchronization 200 argument and see where it is stuck.
This will help understand where in React Navigation there is an issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/wix/Detox/issues/1207#issuecomment-476616071, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AX8BluId3hUkylZpXGXqyFvKVYNpZpyXks5vahl5gaJpZM4bz9Nr
.

Guys, when investigating #1234, we found that in RN59, If Detox is attached, RN thinks its in testing mode and disables some functionality. I wonder if that is not a cause of some of the issues here. I'll release 12.1 soon with the fix for #1234. Please test if it helps with other issues discussed here.


merge branch and clean up old "core"

dependent on the decision in #3176
Reminder to merge branch and clean up old "core"

I think this is done now:

cloak has been merged into main as of a few days ago
#3418 was merged yesterday


Document new CLI debug command

See PR https://github.com/prisma/prisma/pull/21626
Example output

Note that the command output changed slightly with https://github.com/prisma/prisma/pull/21760


Improve documentation

In process of improving documentation to be worded better in spots and include more examples.

A) Missing LIDAR and IMU packages
B) Enable IMU and LIDAR
C) Setup the UDEV rules for the LIDAR and IMU
D) Update the LIDAR and IMU ports in the configuration file
E) Change the orientation of RPLIDAR in URDF
F) Change the Wheel Radius and Robot Length for the Rover-PRO
G) Disable TF Parameter in Rover-PRO configuration file

#23 Implements


Issue with aws-fog

I am trying to bundle the gem and I keep receiving this error.
Bundler::GemspecError: Could not read gem at /Users/Zoe/.rvm/gems/ruby-2.2.1/cache/fog-aws-0.7.3.gem. It may be corrupted.
An error occurred while installing fog-aws (0.7.3), and Bundler cannot continue.
Make sure that gem install fog-aws -v '0.7.3' succeeds before bundling.
Does this have something to do with shoppe? Because its the only time im receiving the error is with this gem.

Nope it shouldn't be. It looks like the gem that was downloaded is corrupted. Just delete that cached gem and try again


rtc driver may interrupt in a short time for large timeouts on cc13x2/cc26x2

Describe the bug
In cc13x2_cc26x2_rtc_timer.c, depending on the setting for CONFIG_SYS_CLOCK_TICKS_PER_SEC and on the timing, z_clock_set_timeout may round up the timeout to the next tick, resulting in setThreshold() being called with a value greater than (0x80000000 + current counter value). In this case, setThreshold() would set the comparator to a value very close to the current count, thinking that the timeout had already expired.
Expected behavior
Large timeouts should result in the comparator being set to a value corresponding to MAX_TICKS.
Impact
This results in more RTC interrupts than is necessary, potentially wasting cycles and power.
Environment (please complete the following information):

OS: Ubuntu 18.04
Toolchain (e.g Zephyr SDK, ...): Zephyr SDK 0.10.3
Commit SHA or Version used: 86461ac559a6c9a45e39ecff2beaecf785994e8a

fixed by #21017


#139456277 implement emoji feature during game chat

What does this PR do?
Implement emoji during game chat
Description of Task to be completed?
Users should be able to use emojis in the chat window
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#139456277 Users should be able to use emojis in the chat window
Screenshots (if appropriate)
N/A
Questions
N/A

Coverage remained the same at 100.0% when pulling b683056f4260118518122f3a0f8435dfe5fe31a9 on feature/139456277/add_chat_emoji into e9cafdd6579a1e02c5e0d3711b34841247708417 on develop.

Coverage remained the same at 100.0% when pulling 51d7dfba82ee1806de1a6f34204c6906f468a2cf on feature/139456277/add_chat_emoji into e9cafdd6579a1e02c5e0d3711b34841247708417 on develop.

Coverage remained the same at 100.0% when pulling 51d7dfba82ee1806de1a6f34204c6906f468a2cf on feature/139456277/add_chat_emoji into e9cafdd6579a1e02c5e0d3711b34841247708417 on develop.

Coverage remained the same at 100.0% when pulling 9c6936b51a0d197f39ff2a1ee4a33fdb40e32d51 on feature/139456277/add_chat_emoji into 0300416b3fcc3a365f60ca383feb278d2dac3b2d on develop.

Coverage remained the same at 100.0% when pulling e2f106a230e6e79ff3dfe1a6c49eb9d3580c0ef6 on feature/139456277/add_chat_emoji into 0462a51e1dbe7222de75618ef04b869403cf86b7 on develop.


fixed alignment issue

Fixed it, Kindly merge it

why you removed whitespaces from the code

Also inline CSS should not be added you should add  CSS in the stylesheet

It Happened because of prettier vscode extention

Check now


fix: added git token at pipeline

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"Fit cab" always on, remove from UI.

It's a minor speed hit for Colab, but well worth it for better-sounding models and to simplify the UX.

Roll up to #8


Create an initial list of datasets to put in object-store

AS to send AI the email with the details of the request.

Copy of requirements
Variables:

copy of spreadsheet

Experiments:

For starters, having those variables for following experiments would be great.
Experiment ID:- picontrol, Historical, rcp26,rcp45,rcp60,rcp85


Inquiry about image data

Hi, could I access the raw image data (such as jpg or png) instead of extracted visual features?
I think only feature data (npy file) is available for now.
Thank you.

I saw that the image source is Visual Genome and extracted images from there, by using simple code.


Add ability to update all channels

At the moment we only support juliaup update to update the current default channel. It would be nice if one could also do juliaup update <channelname> to update some other channels. This is now implemented.
We could also support juliaup update --all to update all channels. That would require us to keep a list of "installed" channels, though, which is a concept we don't have at the moment.

juliaup update now updates all channels, whereas juliaup update <channel name> updates a specific channel.


fix(Critical Section): rewrite critical section

The main goal of this change is to fix critical section implementation. There are 3 major problems with the existing implementation:

There is a time of check to time of use bug in the acquire code. When we first read GINTENR then disable interrupt, that causes a potential race condition where you can be interrupted between the two operations, potentially call the acquire function again. This would break the current critical section implementation.

The qingke::register::gintenr::write is incorrect, the old implementation was actually bit wise ORing the value with the register content atomically.

As a result of fixing the critical section, it actually breaks the whole functionality of the embassy_executor, as their riscv implementation expects the wfi instruction can be executed in a critical section environment. While this is not the most ideal solution we have temproarly forced the WFItoWFE bit to be on so that the critical section behaves semantically correct. (As in critical section really should not imply interrupt disabled) I think a better fix can be followed up later where this bit is check and stored upon entry of the critical section and set / restored upon exit.

Version is bumped to 0.3 and unified between qingke / qingke-rt / qingke-macro because this is a significant breaking change:
- Semantic meaning of wfi is now wfe
- critical_section actually masks interrupt

This addresses #3


JSON.stringify reactive object cause Error on IOS: json.stringify cannot serialize cyclic structures

Version
3.0.0-rc.6
Reproduction link
https://codesandbox.io/s/nifty-morse-hce62?file=/src/index.js
Steps to reproduce
It works fine on other  IOS device, but throw error on IOS 12.0, safari
What is expected?
Not throw error when stringify
What is actually happening?
Throw error

Screenshot url: https://ibb.co/qj1YDyk

@luvsic3 You can solve it as follows, I verified it on iOS 12 iPhone 8 Plus simulator.
var seen = [];
const res = JSON.stringify(s, function (key, val) {
  if (val != null && typeof val === "object") {
    if (seen.indexOf(val) >= 0) {
      return;
    }
    seen.push(val);
  }
  return val;
});

Root cause speculation:
JSON.stringify() will trigger the call of Reflect.ownKeys(). The return of ownKeys will not be directly used as the key array of the result of JSON.stringify(), Enumerable of the attribute will be verified here. But this verification does not seem to be performed on iOS 12.
For this kind of problem, I think if Vue3 tries to solve it, it may cause more problems. So I suggest users to be compatible.
Reference: ECMAScript - JSON.stringify