migrate to useOnyx

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49104
PROPOSAL: https://github.com/Expensify/App/issues/49104#issuecomment-2346858365
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I think we can mark this PR No QA, could you modify the title of the PR? let's add the component name as well

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Looking for a way to test this

We may have a way to test the page https://github.com/Expensify/App/pull/19125

index 047d4dc823f..321d1e631f3 100644
--- a/src/CONFIG.ts
+++ b/src/CONFIG.ts
@@ -10,7 +10,7 @@ import * as Url from './libs/Url';
 const get = (config: NativeConfig, key: string, defaultValue: string): string => (config?.[key] ?? defaultValue).trim();

 // Set default values to contributor friendly values to make development work out of the box without an .env file
-const ENVIRONMENT = get(Config, 'ENVIRONMENT', CONST.ENVIRONMENT.DEV);
+const ENVIRONMENT = get(Config, 'ENVIRONMENT', CONST.ENVIRONMENT.STAGING);
 const newExpensifyURL = Url.addTrailingForwardSlash(get(Config, 'NEW_EXPENSIFY_URL', 'https://new.expensify.com/'));
 const expensifyURL = Url.addTrailingForwardSlash(get(Config, 'EXPENSIFY_URL', 'https://www.expensify.com/'));
 const stagingExpensifyURL = Url.addTrailingForwardSlash(get(Config, 'STAGING_EXPENSIFY_URL', 'https://staging.expensify.com/'));

Sign in via google from web
Press the google sign in option from the desktop app
Change the url to the local host

here is how to access the page, but i agree the changes aren't significant enough to QA this PR.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


C++: Downgrade ExprHasNoEffect to medium precision

We keep adding special cases to this query, but a quick glance over its results on lgtm.com shows that we have many more special cases to cover.
The fundamental problem with this query is that it doesn't know where the encapsulation barriers are. As a consequence, the query will flag calls like destroy_my_object(&my_object); when the destroy_my_object function has no effect in the particular version and configuration we've extracted.
It pains me to suggest hiding this query on LGTM after we've put so much time into improving its results. I hope we can revive it some day when our user interface has evolved to better tolerate imperfect queries.
Fixes #2298 (see https://github.slack.com/archives/CP0MHKV6E/p1574086207203400 for a diagnosis). If we agree to merge this change, I'll add a 1.24 change note.

It's frustrating because there are some really good results in there as well - but I think I'm in agreement.  It might be good to briefly discuss this with the rest of the team as well.
Some of the best results of this query actually overlap with what ReturnValueIgnored.ql is or should be reporting.  Perhaps we could strengthen that query (i.e. look for function calls where the return value is ignored + the expression has no effect) and promote that onto LGTM in this query's place?

Looking over all the good results again, I'm having second thoughts about hiding this query. How about instead excluding all template code?

I'm proposing #2399 in favour of this.


add text editor window for paycoin.conf via help menu

Add an option in help menu to invoke a text editor that opens paycoin.conf for easy editing.

I'll take a look at this one. I've been wanting to do it for a while.

This feature was implemented. Closing issue.


Type Support: Properties with conditional types

Description
Some components work with different modelValue values based on another property.
For example, the modelValue property of the dropdown component can be a single value, or if the multiple property is true, the modelValue property will be an array of values.
These type distinctions could be solved by using conditional types for such use cases.

Help wanted:
But I don't know how to implement conditional types with the composition api. A similar question can be found here: stackoverflow.
Any suggestions for implementation are welcome.
Why Oruga need this feature
Improve component TypeScript support.

My first thought was to do something along these lines:
diff --git a/packages/oruga/src/components/dropdown/Dropdown.vue b/packages/oruga/src/components/dropdown/Dropdown.vue
index 589d4e3f..0ea6ed52 100644
--- a/packages/oruga/src/components/dropdown/Dropdown.vue
+++ b/packages/oruga/src/components/dropdown/Dropdown.vue
@@ -1,5 +1,12 @@
 <script setup lang="ts">
-import { computed, nextTick, ref, watch, type PropType } from "vue";
+import {
+    computed,
+    nextTick,
+    ref,
+    watch,
+    type PropType,
+    type ComponentObjectPropsOptions,
+} from "vue";

 import PositionWrapper from "../utils/PositionWrapper.vue";

@@ -35,11 +42,6 @@ defineOptions({
 const props = defineProps({
     /** Override existing theme classes completely */
     override: { type: Boolean, default: undefined },
-    /** @model */
-    modelValue: {
-        type: [String, Number, Boolean, Object, Array],
-        default: undefined,
-    },
     /** The active state of the dropdown, use v-model:active to make it two-way binding. */
     active: { type: Boolean, default: false },
     /** Trigger label, unnecessary when trgger slot is used */
@@ -85,8 +87,6 @@ const props = defineProps({
         type: String,
         default: () => getOption("dropdown.animation", "fade"),
     },
-    /** Allows multiple selections */
-    multiple: { type: Boolean, default: false },
     /** Trap focus inside the dropdown. */
     trapFocus: {
         type: Boolean,
@@ -237,6 +237,27 @@ const props = defineProps({
         type: [String, Array, Function] as PropType<ComponentClass>,
         default: undefined,
     },
+    ...({
+        /** @model */
+        modelValue: {
+            type: [String, Number, Boolean, Object, Array],
+            default: undefined,
+        },
+        /** Allows multiple selections */
+        multiple: { type: Boolean, default: false },
+    } satisfies ComponentObjectPropsOptions as
+        | {
+              modelValue: {
+                  type: PropType<string | number | boolean | object>;
+              };
+              multiple: { type: PropType<false> };
+          }
+        | {
+              modelValue: {
+                  type: PropType<(string | number | boolean | object)[]>;
+              };
+              multiple: { type: PropType<true> };
+          }),
 });

 const emits = defineEmits<{

I'm not sure that this will actually play nicely with the defineProps macro, though, and based on some rough testing I was doing, I don't think the type inference quite cooperates as desired.

I maybe found a solution explained in this quide: https://medium.com/@ademyalcin27/crafting-type-safe-components-in-vue-js-with-typescript-3724276c6155
I created an example PR for the input component #884.

Based on a quick glance at the PR, it seems like a pretty reasonable approach. I'd be tempted to use T as the generic argument instead of TNumber, although I don't know if that would play well with TypeScript's type inference.

Hmm, I don't like that it is not possible to define the conditional type with the runtime declaration approach and we have to use the type-based declaration approach with the withDefaults compile macro...

I have it!!

It works with the runtime declaration approach, by casting the type as unkown before declaring it properly with PropType.

My example is not working anymore :/ I think this is not the right solution...


Starting Masternode not possible

I try to host a MN at ihostmn.com. The Dashboard from there schows, that the MN started but at the wallet is the MN-Status shown with "missing".
I opend a tiket at ihostmn.com: tiketnumber there is 18294. The support wrote: "our advice is to delete existing SFD--Masternode--1 and create new one with new collateral transaction (not exsisting one). " I created a new MN but nothing changed.
My adresses:
Masternode: SaLangHWsabzRT3rhYegqFTDHdxU1tFnqR with 3000SFD
Default: SfBZHNeeV1ezk1WDj56v2fNMFkvqVzopGZ with rd. 17SFD
I downloaded the wallet from GitHub:
Client VErsion: v<IP_ADDRESS>-ge8aaa67b8ca24093823cd1ad337f2078b36c8805
could you check please and advise what to do?
With best regardds,
André

What the solution was? It seems is closed already. I had the same issue and turned back to pool shared masternode.


Update to-now.md

toNow() actually returns distance from time with suffix ago

seems the docs are correct, you can test the code result in https://npm.runkit.com/dayjs


Can the BG/BB fitter be used to predict at the individual level?

Following the original paper and the API for the BetaGeoBetaBinomFitter, it looks like (unlike the other fitters such as the BetaGeoFitter) this one requires aggregate data as input. As a result, the calculated probabilities and conditional values are for a combination of R and F, not the individual customer. (Also, there does not seem to be a predict method).
Is there a way to use this fitter at the individual level?

Further, this section seems to suggest that you're generating customer level data anyway?
https://github.com/CamDavidsonPilon/lifetimes/blob/feb6a1669520f33597d0d13b6df2069914c6d159/lifetimes/fitters/beta_geo_beta_binom_fitter.py#L163

@amenegola I think yours is a different issue (my question was around not using aggregated but user level data).
I'm guessing your error is maybe related to your first two columns (frequency and recency) being doubles and not integers?
I aggregated my data in pandas, but the original values for my frequency and recency columns were already integers from the source data.
agg_data = data.groupby(['frequency', 'recency', 'T'])['user_id'].count().reset_index()
agg_data.columns = ['frequency', 'recency', 'n', 'n_custs']

The original issue will be fixed in #220


RL4J - Changed to use Nd4j Random instead of java.util.Random

What changes were proposed in this pull request?
Several places in RL4J uses java.util.Random and does not use the seed. This makes it impossible to have identical results with identical runs. Plus java.util.Random makes it very difficult to unit test components that uses random.
How was this patch tested?
Unit tests and manual tests
Quick checklist
The following checklist helps ensure your PR is complete:

[X] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
[X] Reviewed the Contributing Guidelines and followed the steps within.
[X] Created tests for any significant new code additions.
[X] Relevant tests for your changes are passing.

@AlexDBlack Should we be using Nd4j.getRandomFactory().getNewRandomInstance() for that? I don't see it being used a lot in ND4J or DL4J...

Nd4j.getRandom() put and/or get the instance from a ThreadLocal storage. I was afraid that if Nd4j.getRandom().setSeed(...) is called multiple times, a user might think he is setting the seed on different Random instances but in fact is re-setting the seed on the same instance. This might cause unwanted patterns in the random sequences. This can be solved easily if we just create a new Random with every instance.
On the other hand, I could make sure the seed is only set once and use Nd4j.getRandom(0 everywhere.

I see, that sounds like a prudent thing to do. I'm wondering if we should be using that factory like that though. I'll let Alex decide.

Throughout DL4J and SameDiff, we have tended to use the thread local random (Nd4j.getRandom()) pretty much everywhere, which works well enough most of the time.
The downside of course is that the seed/state is attached to the thread, not to the model. Which may or may not matter.
The problem with using getNewRandomInstance is that anything internally to the network won't be using it that random instance.
So, if you have say a model with dropout, that will continue to use the thread local random. Which means that your model training won't be made deterministic. I'm not 100% following what's the intended behavior here when setting the seed...

I decided to use Nd4j.getRandom() because it does the job just as well as using the factory and I feel the use of Random in RL4J needs to be similar to the rest of DeepLearning4j. As for my earlier concern that a user calling Nd4j.getRandom().setSeed(mySeed) might unknowingly cause side effects, it's nothing that reading the docs can't clear up.
So these are the specs I implemented:

If no seed is set, the learning is completely non-deterministic (i.e. setSeed() should never called)
If the seed is set, the learning should be completely deterministic (i.e. every run should always give the same results for a given seed value)
The classes that need Random should carry an internal reference. This is easier in the unit tests when we can inject every instance with different mocks that each contains precise 'random' values. (Not all ctors presently support injection of Random but I will add them when required)

@AlexDBlack The thing is, RL4J "uses" DL4J so whatever happens in DL4J w.r.t to seeding comes in too late, and not all threads interact with DL4J either. How do you think we should handle this?


API framework?

http://loopback.io
https://nestjs.com

@sbcgua yes, I also ended up just doing it in raw code, but it would be nice with OpenAPI specifications and such

yeah openapi could be nice indeed
I checked some material on loopback and nextjs.
Seems like the later one is more trendy.
https://www.npmtrends.com/@nestjs/core-vs-loopback-vs-sails
But ... yohoho ! :)))
https://www.npmtrends.com/@nestjs/core-vs-loopback-vs-sails-vs-express
Anyway could be worth checking. It supports validation in the package and typescipt friendly... The syntax from docs looks a bit cluttered to me. But maybe we can try :)

yea, one step at a time

Looking through the docs of nextjs and becoming less excited. Looks quite bloated and less readable. Probably very good for bigger apps. But for a small one - light-weight express is just perfect. Just an opinion.


Make week more clear (BirdNET Analyzers are based on 48 'weeks' in a year)

Context: The BirdNET analyzers use a week value that's ranged 1-48.
Week of the year when the recording was made. Values in [1, 48] (4 weeks per month). Set -1 for year-round species list. ref
Some users find this ambiguous (is there a preferred python function for converting a date to week-48 format?).
Also, since it's a non-standard interpretation of "weeks", I'd like to standardize with an eye towards the API staying the same for future-proofing. I'd hate to lock in a 48 week standard that has to be reversed if another analyzer ever becomes available.
Options are:

Change week to accept a 52 weeks value, and convert to BirdNET's required 48-week based value  in the background
Add a date argument, and use that to convert to BirdNET's required 48-week based value  in the background
Above options, but still accept a week_48 parameter as well to provide consistency to BirdNET users

I'm leaning on option 2 with option 3 implemented as a fallback for users that adhere to the legacy BirdNET usage.

Conversion of day of year to week_48:
ceil((day_of_year/365) × 48)
Notes for determining leap year:
import datetime as dt
import calendar
date=dt.datetime.strptime('2020-03-30', '%Y-%m-%d')
year=date.year
days=366 if calendar.isleap(year) else 365

The plan is to add a date argument, and use that to convert to BirdNET's required 48-week based value in the background AND still accept a week_48 parameter provide consistency to BirdNET users. By default, the date and week_48 are both optional.


bpf_sock: Implements a new way to detect host netns on Kind.

This commit follows the suggestion made by @borkmann, @brb and @aditighag with little modifications.
I really appreciate any suggestions.
Fixes: #14956

@aditighag, I changed the code a little bit. I appreciate any suggestion ;)

Let's convert to draft until the kernel side has been resolved.

Preceded by #17018.


Add vulnerable dependency for demo

Minder Vulnerability Report ⚠

	Minder found vulnerable dependencies in this PR. Either push an updated
	version or accept the proposed changes. Note that accepting the changes will
	include Minder as a co-author of this PR.

Vulnerability scan of 775198cc:

🐞 vulnerable packages: 1
🛠 fixes available for: 1

Package
Version
#Vulnerabilities
#Fixes
Patch

github.com/swaggo/http-swagger
v1.2.5
3
3
v1.2.6

Summary of vulnerabilities found
Minder found the following vulnerabilities in this PR:

Ecosystem
Name
Version
Vulnerability ID
Summary
Introduced
Fixed

Go
github.com/swaggo/http-swagger
v1.2.5
GHSA-49w7-5r33-jm9m
http-swagger XSS via PUT requests
0
1.2.6

Go
github.com/swaggo/http-swagger
v1.2.5
GHSA-xg75-q3q5-cqmv
Denial of Service in http-swagger
0
1.2.6

Go
github.com/swaggo/http-swagger
v1.2.5
GO-2022-0427
Unprotected file upload in github.com/swaggo/http-swagger
0
1.2.6

Minder analyzed this PR with Trusty and found no dependencies scored lower than your profile threshold.


question about emb sum in model_fine

Hi, I have a question about the fine model.
When to predict the i-th quantizer codebook（pred_idx == i-1），the vall-e sum up embedding of stage 1 to i-1 as input to the model.
But in model_fine.py,
https://github.com/suno-ai/bark/blob/599fed040e52c89e0b3580e02e2684b2c9100701/bark/model_fine.py#L123
It seems to add up 1 to i ?
For example,  when pred_idx == 2 (to pred 3-th quantizer codebook), idx 0 to 2 (i == 1 to 3)  will be summed up?

HI @HallidayReadyOne , I don't have great intuition here as well -- but I tried to change the pred_idx +1 to pred_idx, and the generated voice is much noisier.

But I can argue that the fine model is trained in this weird way and changing the forward now will only affect how it predicts things. I think this could be a potential bug -- let's ask @gkucsko .

Hm ya could totally be a bug thanks but ya given how it was trained it probably doesn’t help to change it. We’ve since deprecated the fine model so the next version won’t have that anyways

But I can argue that the fine model is trained in this weird way and changing the forward now will only affect how it predicts things. I think this could be a potential bug -- let's ask @gkucsko .

Hi tongbao. I think so. Cause changing from pred_idx+1 to pred_idx leads to worse results.

Hm ya could totally be a bug thanks but ya given how it was trained it probably doesn’t help to change it. We’ve since deprecated the fine model so the next version won’t have that anyways

Hi Georg. One thing may needs to be confirmed, is the training also carried out in this mode? Thx

yup training was done with the same logic

yup training was done with the same logic

Thanks for your reply, this issue will be closed.


Cannot configure 1.8 on MacOSX Mavericks (10.9.4)

Hi. Here's what I get when I follow the MacPorts-only path at https://github.com/dogecoin/dogecoin/blob/master/doc/build-osx.md and trying ./configure --enable-debug
...
checking for Berkeley DB C++ headers... /opt/local/include/db51/
checking for main in -ldb_cxx-5.1... no
checking for main in -ldb_cxx... no
configure: error: libdb_cxx missing

Pretty much lost here. It doesn't make any difference if I install QT4, as per the guideline, does it?
Please advice.

Can we close this now?


Add a section rating and reviews

we can add a section for ratings and reviews so that more customers will attract to our food website.

Please assign me this issue so that I can resolve it under GSSOC-23


Update dependency glob to v10

Fixes #1046

It could be interesting to add the compilation and test execution of the vscode-testexecution project to the ci build, in order to avoid updating npm dependencies with breaking changes.


Modify Ultra Quality preset?

Cant seem to find the option on the config, just DLAA + all the other options, but not Ultra Quality

The 0.200.7 beta ver should include settings for UQ presets: https://github.com/emoose/DLSSTweaks/issues/88#issuecomment-1684184758
Not totally sure how well that works though since I don't have any games that show the UQ option atm.

Thats fine, I can test, do you know where this beta is located? Can't find it here or in nexusmods


[About Page] Mobile Formatting Issues

The following issues appeared after the redesign of the page:

Two issues with the formatting due to horizontal orientation of the device (the "Developers & Contributors" is cut in half and the formatting of the names is incorrect) and one issue with the formatting of the names due to vertical orientation.
The color of the names with the light theme is unreadable (I do not have a screenshot with it).

Light mode was corrected

Another small issue which I had noticed on both the desktop and mobile version (on the press information section):

I have no idea what you think the problems here are. It's very unclear and thus probably unactionable.

I have no idea what you think the problems here are. It's very unclear and thus probably unactionable.

The body of the text goes up while it should be like the one on the right.

@razzeee The original issues are fixed, thanks for working on them however the end result have another small issue with horizontal orientation:

The font should be smaller in my opinion. On vertical orientation everything looks as expected.

I can't reproduce this in firefox or chrome

I can't reproduce this in firefox or chrome

My bad, I was using 150% scaling, reverting to 100% fixed it.


Load command causes read amplification

Alluxio Version:
2.9.x
Describe the bug
use fs load to warm up the dataset, we found that fs load displayed bandwidth is significantly lower than the k8s monitoring bandwidth.

4 worker pod , network receive: sum(rate(container_network_receive_bytes_total{container_label_io_kubernetes_pod_namespace="xx", container_label_io_kubernetes_pod_name=~"alluxio-worker-.*"}[1m])) by (container_label_io_kubernetes_pod_name, instance)

Expected behavior
the network consumption monitored by k8s is slightly larger than the loaded data.
Additional context

this is a large file dataset (1100+ files, 650GB) case, and there is no such problem with warming up image small file datasets.
alluxio.worker.block.store.type= FILE

update
I captured packets in one of the workers and found that the cut-off range of the range request is abnormal .
alluxio.user.block.size.bytes.default=4194304.
without considering the boundary case, the range request should be Range: bytes=4MB*n - 4MB*(n+1)-1, this is exactly one block size.
in fact, one of the range request/response is as follows:
GET /prefix/target HTTP/1.1
Range: bytes=113246208-9223372036854775806
.....

HTTP/1.1 206 Partial Content
Content-Length:<PHONE_NUMBER>
Content-Range: bytes 113246208-1264885728/1264885729
....

It can be clearly found that the size of the response is much larger than the size of a block;

Hi @wwq2333 Could you clarify what your k8s monitor graph shows? Is that network upload+download for each worker pod? Or just upload?

@jja725 @jiacheliu3 2.x Is it feasible to refer to the implementation of pr #16637  in version 2.x ?

@jja725 @jiacheliu3 2.x Is it feasible to refer to the implementation of pr #16637 in 2.x ?

@LuQQiu Can you provide some advice?

@Haoning-Sun Yes, we would welcome some contributions from the community to help us cherry-pick some of the code changes from #16637 and apply them to UfsIOManager(which would be used by Load). Last time I discussed with @wwq2333 that he would like to contribute.


Update plugin configuration cache compatibility table

OK, I've already triggered the following builds for you:

BuildDistributions build

configuration_cache.html

I wonder if we should also mention the change of status of these plugins in the release notes. Even though no plugins besides maybe build-init actually became compatible in 8.0, I don't think we announced some of the support status transitions before.

Good point, @mlopatkin. We should announce when plugins become compatible with the configuration cache in the release notes 👍

@bot-gradle test BD

OK, I've already triggered the following builds for you:

BuildDistributions build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


[BlockSparseArrays] Fix eachindex(::BlockSparseArray) with dual axes

This is a temporary hack to fix eachindex(a::BlockSparseArray) when a has a mixture of dual and non-dual axes.
This will be fixed in a better way once GradedAxes is rewritten using BlockArrays v1 but for now I'm implementing some temporary fixes for issues like this and other ones being tracked in #1336.
@ogauthe

I think this isn't a good fix since it is too hacky, I'll try overloading eachindex(::BlockSparseArray) directly instead.

@ogauthe in the latest commit I added a temporary fix for printing BlockSparseArray with mixed dual and non-dual axes.


Add LordIcon Library

Adding an awesome icon library

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not have more than 100 characters
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

@marekdano Hi, I've resolved the conflict, Can you pls merge this, I'm working for Hacktoberfest, This will help me....

Thanks for the support @marekdano !!


How to configure timeouts for postgres

What version of Flyway are you using?
3.2.1
What database are you using (type & version)?
Postgres 9.5
What operating system are you using?
Arch linux / Ubuntu (problem manifests itself on both)
What did you do?
Run a long migration sequence, that in total takes around 40 seconds.
What did you expect to see?
Migration succeeds
What did you see instead?
Migration fails with:
ERROR: Unable to rollback transaction
org.postgresql.util.PSQLException: This connection has been closed.
        at org.postgresql.jdbc2.AbstractJdbc2Connection.checkClosed(AbstractJdbc2Connection.java:843)
        at org.postgresql.jdbc2.AbstractJdbc2Connection.rollback(AbstractJdbc2Connection.java:860)
        at org.flywaydb.core.internal.util.jdbc.TransactionTemplate.execute(TransactionTemplate.java:81)
        at org.flywaydb.core.internal.command.DbMigrate.applyMigration(DbMigrate.java:282)
        at org.flywaydb.core.internal.command.DbMigrate.access$800(DbMigrate.java:46)
        at org.flywaydb.core.internal.command.DbMigrate$2.doInTransaction(DbMigrate.java:207)
        at org.flywaydb.core.internal.command.DbMigrate$2.doInTransaction(DbMigrate.java:156)
        at org.flywaydb.core.internal.util.jdbc.TransactionTemplate.execute(TransactionTemplate.java:72)
        at org.flywaydb.core.internal.command.DbMigrate.migrate(DbMigrate.java:156)
        at org.flywaydb.core.Flyway$1.execute(Flyway.java:1059)
        at org.flywaydb.core.Flyway$1.execute(Flyway.java:1006)
        at org.flywaydb.core.Flyway.execute(Flyway.java:1418)
        at org.flywaydb.core.Flyway.migrate(Flyway.java:1006)
        at org.flywaydb.commandline.Main.executeOperation(Main.java:122)
        at org.flywaydb.commandline.Main.main(Main.java:91)
org.postgresql.util.PSQLException: This connection has been closed.

I've tried to increase all the timeout values:
Database: jdbc:postgresql://localhost:5432/testdb?connectTimeout=0&cancelSignalTimeout=0&socketTimeout=0&tcpKeepAlive=true

(Zero means unlimited timeout) to no effect.
If I run flyway again, it finishes properly, so it's not a problem on the SQL.
Also, since this is being run as localhost, it is not likely that it is a firewall problem, I think

Flyway does not influence timeouts. This is an issue with either your driver, db server or network infrastructure in between.

But how can I know if the timeout parameters are being passed / handled by the JDBC driver (used by flyway)?

Flyway passes the connection string as is to the driver.


Request | Make DES the default finder for Aladin Lite for objects from the Southern telescopes

This is a feature request rather than a bug report.
Would it be possible to make the DES-DR1 catalogue the default finder for the Aladin Lite widget on the web pages for ATLAS objects discovered by the Southern Telescopes? Right now the DSS catalogue appears to be the default.
E.g.: https://star.pst.qub.ac.uk/sne/atlas4/candidate/1032009240521038800/

Will think about it. DES DR1 coverage is far less complete than DSS in the south, but some simple calculations using the "tank" coverage map should allow me to automatically switch.

No problem. Yes, the less coverage is annoying, but if the DES catalogue has coverage over the target area we should use it since it's a more detailed sky map.
I was thinking of this feature as "something that would be nice have" as opposed to "something we need to have" as it only takes a few seconds to manually swap the sky maps in the widget.


Protected App Signals Engagement Plans

Fwends, I am very excited to be getting more into the Protected App Signals proposal, I see lots of good ideas I look forward to iterating on as a group.
Off the bat I'm realizing I have a few meta questions:

It looks like PappAPI (?) is currently only documented in the blog space rather than in Github. Will this be the case going forward, or is the intention to engage with the community in Github similarly to the other PS proposals? I definitely see pluses and minuses to Github (Microsoft obviously being a plus) but if it won't be I wonder how we'll open issues, PRs, upvote, track changes, etc.
Will there be a weekly/bi-weekly/some-cadence meeting?
Will this also be done under the auspices of W3C, PATCG, etc? Is the idea to try to develop a standard that other devices would hopefully use? (B) Related and in particular, will there be an attempt to converge PaapAPI and PAAPI?
Am I right that there is not yet a timeline? To the extent that there is, will be there be similar "adoption/transition" features as Protected Audience has, i.e. event level reporting, BYOS KV/Creative-Selection server, etc? Or is the idea to go cold turkey?
I am 99.99% but just to triple confirm, there will be no on-device Android auctions?
EDIT ADDITION: I'm also a bit unclear on the relationship between the BA Team and the Chrome/Android teams...I had generally understood that on the web side the Chrome team would be in charge of making decisions about how a Chrome User's data can flow, and BA would work on server side implementation(s) of that, with back and forth over whether something like the new Inference Service is "allowed for their users". Is that right? Is Android the same model, and if so is there an Android team focusing on this?

I think 3B and (5) together are interesting, b/c even though there wouldn't necessarily be client side compatibility issues, server side compatibility issues are still possible...they wouldn't necessarily be a deal breaker, but if there's significant divergence in the flows, topology, etc, it will add a lot of challenge.

Since Protected App Signals is an Android API, most of the on-device documentation will live on developers.google.com, as is the norm for Android proposals. Since there is a server-side component (i.e. Ad Retrieval), that will live on GitHub with the rest of the services documentation and code. We are always evaluating where we are hosting this information, so changes in the future may occur.
(As you may have figured out by now) There are no engagements similar to the regularly occurring meetings that appear for Chrome APIs. However, the team is interested in feedback so please feel free to raise issues on GitHub.
Not at the moment. For 3b, answer is in the next line.
Protected App Signals is a new proposal that aims to support a use case for mobile advertising that wasn't quite covered by Protected Audience. For Android, these APIs will both co-exist and have their own support for event reporting, ad retrieval, etc.
Protected App Signals is only supported in a B&A auction.

Marking this as resolved, but please feel free to re-open or raise a new issue if you have further questions


site(footer): add netlify logo

[x] Others (Update, fix, translation, etc...)

to fulfill netlify open source plan policy.

Preview:

There are other colors to choose from.

IMHO, margin-bottom: -14px; should be applied to the Netlify Logo to make it vertical centered.

Added


InsertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces must be exposed in protocol.d.ts so VS Code can use it

TypeScript Version:  2.0.3
The formatting setting InsertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces seems to be part of TS 2.0.3 but is NOT exposed in the tsserver in the protocol.d.ts. To allow VS Code to make use of it it needs to be exposed there as well.

@mhegazy please consider for 2.0.5


Add custom docbook-xsl directory option to fopdf.bat

Add the custom docbook-xsl directory option to fopdf.bat to align with #13.

Is there some other way to use custom XSL in Windows, or is the only way to edit the contents of the docbook-xsl folder?

Not really. This issue needs to be resolved. Otherwise, the information is not passed to the processor and it won't know to use another directory.
In addition to the commandline option, we could also consider adding an environment variable for the location of the dockbook-xsl folder.
Of course, you can always feel free to hack the contents of the docbook-xsl folder yourself. However, you'd need to manage those changes so that they don't get overridden accidentally if you update fopub. It's not the recommended way, but it is a way.

One simple change is to change the following line in fopub.bat
set DOCBOOK_XSL_DIR=%FOPUB_DIR%\docbook-xsl
to
if not defined DOCBOOK_XSL_DIR set DOCBOOK_XSL_DIR=%FOPUB_DIR%\docbook-xsl
Then define DOCBOOK_XSL_DIR in the environment before invoking fopub

:+1: Would you like to propose that change?

Sure but first I'll try to make the fopub.bat closer to fopub in functionality. Though this Windows batch file language is giving me a headache...

OK, I've submitted a pull request with the changes. fopub.bat should now have the same interface as the Unix version.

Awesome! Thank you! I'll review asap.


Notification-Admin-App - Sprint 5

Description:

Build the Screen using the style guide.
Integrate Screen with the Backend

I'm picking this up too


[Task]: Update duckdb dependency to 0.10.2

What needs to happen?
Update duckdb dependency to 0.10.2
Issue Priority
Priority: 3
Issue Component
Component: Database

solved by #3919


Missing keys and unexpected keys

Traceback (most recent call last):
File "run_classifier_TABSA.py", line 456, in
main()
File "run_classifier_TABSA.py", line 346, in main
model.bert.load_state_dict(torch.load(args.init_checkpoint, map_location='cpu'))
File "/home/tmuser/anaconda2/envs/virtualEnvAbhra/lib/python3.6/site-packages/torch/nn/modules/module.py", line 777, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for BertModel:
Missing key(s) in state_dict: "embeddings.word_embeddings.weight", "embeddings.position_embeddings.weight", "embeddings.token_type_embeddings.weight", "embeddings.LayerNorm.gamma", "embeddings.LayerNorm.beta", "encoder.layer.0.attention.self.query.weight", "encoder.layer.0.attention.self.query.bias"....
Unexpected key(s) in state_dict: "bert.embeddings.word_embeddings.weight", "bert.embeddings.position_embeddings.weight", "bert.embeddings.token_type_embeddings.weight", "bert.embeddings.LayerNorm.weight", "bert.embeddings.LayerNorm.bias", "bert.encoder.layer.0.attention.self.query.weight", "bert.encoder.layer.0.attention.self.query.bias", "bert.encoder.layer.0.attention.self.key.weight", "bert.encoder.layer.0.attention.self.key.bias", "bert.encoder.layer.0.attention.self.value.weight", "bert.encoder.layer.0.attention.self.value.bias", "bert.encoder.layer.0.attention.output.dense.weight"....
What shoould I do for this?

Make sure that you have used convert_tf_checkpoint_to_pytorch.py given by us to convert the model.

I used the provided python script to convert the model only, but still getting this error.
Can you tell me which files I should use for --tf_checkpoint_path and --bert_config_file ?

Use the command given in README.md. The file name is the same as that in the command, and you just need to change the path to yours.

How do I use the semEval2014 data? The link you gave is not working.


[THORN-2116] Adding a link to the Community page

See
https://wildfly-swarm.gitbooks.io/wildfly-swarm-users-guide/getting_involved.html
Now there is a link to the Community page with all the relevant information.

Thanks for the approval :-), I'll wait for Sheldon to give this and other PRs his writer review during the next few days (in case he'd like to change some phrases or formatting)

Absolutely!

Thanks Sheldon :-)

retest this please

Merging this now, given that Ladislav has approved and Sheldon's changes have been applied


DateInput component should implement required prop

It appears the DateInput component doesn't correctly implement the required prop.
Note: also the input fields within DateInput are of type 'tel'. Check this!

@warrensearle is this still needed?


Don't reset status to loading when refetching query that has never succeeded

Fixes #2673

This PR is very likely incomplete, but the two changes I made in this PR fixes the issue I see https://github.com/tannerlinsley/react-query/issues/2673
I think there are more locations where similar logic should be updated, I'll need some help to make a more robust PR.
The src/react/tests/QueryResetErrorBoundary.test.tsx testcase fails with my changes, but I'm not sure why.


sync with existing resources

As a developer, when I export typealized interfaces, I want to sync keys and values with existing files (instead of overwriting them), to not loose any customizations done in them.

The most significant "problem" currently is, that I do not have a synch-mechanism in place. Currently, The CLI just generates the resource, fast forwarding, overwriting stuff that maybe already has been translated. As code-first is still in a kind of POC phase, atm, so that´s OK for now. But this is definetley a pain point to avoid in the future at all costs.
Diffing those representations is probably not that hard. But the code-first-approach also implies that devs may just rename a property or method, which then would result in a changed key, with little to no chance of accurately being able to diff those with existing resources.


[SPIKE] Prevent components being initialised more than once

Quick spike to discuss adding data-module-init to components when they're initialised
This can be used to prevent components being initialised more than once
Closes: https://github.com/alphagov/govuk-frontend/issues/1127
Checking if previously initialised
I've added a new checkInitialised($module) method on the base class
When the data attribute data-module-init is already set we can throw an error
  constructor($module) {
    this.checkSupport()
+   this.checkInitialised($module)
+
+   // Mark component as initialised in HTML
+   $module?.setAttribute('data-module-init', 'true')
  }

Closing for housekeeping reasons, as this spike seems unlikely to be resolved at this time.
Fixing the multiple initialisation issue is still on our radar and is something we would like to resolve in future.

https://github.com/alphagov/govuk-frontend/issues/1127


[Feature Request] Support cancellation on runaway apis.

Is your feature request related to a problem? Please describe
Today, some APIs support only top-level timeouts, where a request is cancelled if it doesn't receive a response within the default 30-second timeout. However, the problem arises when these APIs internally make transport calls to master or other data nodes within the cluster even after the timeout expires. These internal/child calls, which are spawned by the API, are never timed out or cancelled, even though the top-level request was cancelled. As a result, the cluster continues to perform unnecessary work, consuming resources, as the customer is not waiting for or expecting a response.
Describe the solution you'd like
We are introducing a new timeout on the coordinator node to prevent timeouts from expiring before making transport calls to master/data nodes. To achieve this, we need to wrap the API's listener with a cancellation listener, where we schedule a task using a thread that allows us to cancel the task after a specified delay.. Once the listener is wrapped, we will pass it to the async call, where we make transport calls to master/data nodes. Before making any transport call, we will ensure that the task is not cancelled, and if it is, we will fail the API immediately.
Related component
Cluster Manager
Describe alternatives you've considered
No response
Additional context
No response

[Triage - attendees 1 2 3 4 5 6 7]
@aasom143 thanks for creating this issue and a pull request.


[AzureMonitorExporter] fix eventsource name spam in debug console

This is to fix the issue where the Debug Console is spammed with messages like:
Payload = System.Diagnostics.Tracing.EventPayload]
Microsoft-AspNetCore-Server-Kestrel - EventId: [-1], EventName: [EventCounters], Message: [EventCounters
Payload = System.Diagnostics.Tracing.EventPayload]
Microsoft-AspNetCore-Server-Kestrel - EventId: [-1], EventName: [EventCounters], Message: [EventCounters
Payload = System.Diagnostics.Tracing.EventPayload]

API change check
API changes are not detected in this pull request.


[1.12.2]Crash When Added To ModPack

When added to modpcak and launch minecraft, the game crash immediately, the crash report are as follows:
crash-2024-11-03_01.37.59-client.txt
Grateful for your assistance with my question!  :)

It is a problem with RandomPatches. I will mention you when I release the new version with it fixed.

@ElinM-Challenge Fixed in 1.12.2-1.0.1

Deeply grateful for your help!  :)


Add EntityExhaustionEvent

Adds the on <entity> exhausts event, which fire's when an entity (player or npc) exhausts.
Context tags:

<context.entity> returns the entity.
<context.exhaustion> returns the amount of exhaustion added to the entity.
<context.reason> returns the reason of exhaustion.

Determine:

ElementTag(Decimal) to change the amount of exhaustion.

Turned it into a player event called player exhaustion level increases.

Made tal5's suggested changes.


added onCreateUser and onDropUser  and OnGrant and onQueryEvent

added more query event

[x] onCreateUser  for CREATE USER 'xx'@'%' IDENTIFIED BY 'xx@****';
[x] onDropUser   for DROP USER 'xx'@'%';
[x]  OnGrant for GRANT SELECT, INSERT, UPDATE, DELETE ON xx.xx TO 'xx'@'%';
[x] onQueryEvent  for all other query event

the rest methods of this interface are related to binlog event type, not DDL type

sorry, The type QUERY_EVENT in the binlog log in mysq contains not only DDL operations, but also changes to the database,     such as：Create User
In our github.com/go-mysql-org/go-mysql, only DDL Type is parsed in the Canal package，and now some event parsing has been added

add comment to describe the callback order of OnDDL and these newly added methods

Sorry, I had a problem with my previous implementation, they have no dependencies, they all belong to the subtypes of QUERY_EVENT  and changed to a more understanding case mode

func (c *Canal) runSyncBinlog() error {
   //.....
   for {
   //.....
         switch e := ev.Event.(type) {
		//.....
                case *replication.QueryEvent:
			stmts, _, err := c.parser.Parse(string(e.Query), "", "")
			if err != nil {
				c.cfg.Logger.Errorf("parse query(%s) err %v, will skip this event", e.Query, err)
				continue
			}
			for _, stmt := range stmts {
				err := c.handleQueryEvent(ev, e, stmt, pos, &savePos, &force)
				if err != nil {
					c.cfg.Logger.Errorf("handle query event(%s) err %v", e.Query, err)
				}
			}
               //.......
      }
   //.....

// handleQueryEvent is handle some common query events (e.g., DDL,CREATE or DROP USER,GRANT),
// others use UnknownQueryEvent unified callbacks to expose to users
func (c *Canal) handleQueryEvent(ev *replication.BinlogEvent, e *replication.QueryEvent,
	stmt ast.StmtNode, pos mysql.Position, savePos, force *bool) error {
	switch t := stmt.(type) {
	case *ast.RenameTableStmt, *ast.AlterTableStmt, *ast.DropTableStmt, *ast.CreateTableStmt, *ast.TruncateTableStmt:
		return c.handleDDLEvent(ev, e, t, pos, savePos, force)
	case *ast.CreateUserStmt:
		return c.handleCreateUserEvent(ev, e, t, pos, savePos, force)
	case *ast.DropUserStmt:
		return c.handleDropUserEvent(ev, e, t, pos, savePos, force)
	case *ast.GrantStmt:
		return c.handleGrantEvent(ev, e, t, pos, savePos, force)
	default:
		return c.handleUnknownQueryEvent(ev, e, t, pos, savePos, force)
	}
}


How to get aperture value?

Hello,
I wanna know that is there way to get exact aperture value from camera?
Thank you so much in advance.

Hello, this is not relevant to the Python API. Please open a support ticket through our website or your camera distributor, if applicable. Make sure to include the serial number and camera model in the support request, as there are only selected models, that would support Iris control.
https://www.alliedvision.com/en/about-us/contact-us/technical-support-repair-/-rma/


Update nuspec to reflect repo changes

as per title those lines needs to be updated to point to this repo.

Hello @ilmax ,
All url from the NuGet package has been updated at the end of last year.
Best Regards,
Jonathan


Add unit tests for Python/Ruby/NodeJS CommentFixer

While fixing #716, we found that there are no comprehensive unit test that are written for the following classes:
CommentPatterns.java
RDocCommentFixer.java
PythonSphinxCommentFixer.java
JSDocCommentFixer.java
While #716 PR provides unit tests for the above classes for its specific issues, these classes should have more comprehensive unit tests.

This should now be the CommentReformatters.

Ack. Specifically, if I recall correctly, the context was that the regexes were quite complicated and some test cases would have helped, so that would mean testing CommentPatterns.

Obsolete since we are migrating to microgenerators


Transient "Sample is empty" runtime error.

Let me start with the terminal output:
% ./CriterionRight.hs
benchmarking const
time                 57.80 ns   (57.02 ns .. 58.37 ns)
                     0.999 R²   (0.999 R² .. 1.000 R²)
mean                 NaN s      (NaN s .. NaN s)
std dev              0.0 s      (0.0 s .. 0.0 s)
variance introduced by outliers: -9223372036854775808% (severely inflated)

CriterionRight.hs: Statistics.Quantile.weightedAvg: Sample is empty
CallStack (from HasCallStack):
  error, called at ./Statistics/Quantile.hs:190:16 in statistics-<IP_ADDRESS>-FhOftJvY6wWEPvUcnpp3zH:Statistics.Quantile

This issue is transient: I launched my script about 10 times tonight and 3 out of the attempts ended like this.
The code I use can be reviewed here: github.com/kindaro/criterion-wut.

I suspect this might have a symptom in common in https://github.com/bos/criterion/issues/160, but again, it's hard for me to tell since I can't reproduce this on my machine (answers to the questions in https://github.com/bos/criterion/issues/160#issuecomment-334626163 would be helpful).
One hunch is that there's NaNs in the result, and it only happens sporadically. There's a known issue where some computations can trigger a bug in statistics' linear regression sampling and return NaN. However, these are long-running computations that only return a few data points (all of which are identical) per run, so the fact that it would show up here (where the program finishes in a matter of nanoseconds) would be rather unusual.

@kapralVV I really don't think it should be possible for this to happen with HEAD. There are checks in place that should make everything run smoothly (though not 100% correctly).
I took a glance at your Travis logs (like this most recent failure) and I am worried that your script somehow isn't using the downloaded Criterion. Perhaps you are running into this?
You might be able to check by adding cabal install criterion like the author of that issue did. If it fails then you are still using the old version. I'm not super experienced with sandboxes though, so it could certainly be working correctly. If it is using the new version, then this is a new issue.
I tried running your benchmarks locally, but got:
hs3bench: QuickCheck.oneof used with empty list

@patrickdoc
I've added the code to show that criterion is from git HEAD .
See the last commit.

changing criterion version on-fly in the fetched git repo to <IP_ADDRESS>
listing all packages installed in sandbox.

So you may see that criterion-<IP_ADDRESS> is installed, it shows us that it IS the version from git HEAD
The issue is still there

@patrickdoc
Last 44 build showed the following issues:
hs3bench: ./Data/Vector/Generic.hs:245 ((!)): index out of bounds (-9223372036854775808,1000)
hs3bench: thread blocked indefinitely in an MVar operation

hs3bench: Statistics.Quantile.weightedAvg: Sample is empty
CallStack (from HasCallStack):
  error, called at ./Statistics/Quantile.hs:190:16 in statistics-<IP_ADDRESS>-KNbAiGxqUXS3OrLnbRkS6L:Statistics.Quantile

@kapralVV
Aha, I was able to reproduce it on my machine. It turns out the check I was referring to is actually slightly different than I had thought. Thank you for the report, it also turned up another bug!
@RyanGlScott
I can submit a band-aid patch for this, but I also have bigger changes that will cover this coming down the pike. If you would like one now though, let me know.

I can submit a band-aid patch for this, but I also have bigger changes that will cover this coming down the pike. If you would like one now though, let me know.

I'd be fine with whatever is more convenient. I'm not in a rush to put out a new release, given the multitude of other bugs you've found :)


[objective-c]false-positive -dataWithBytesNoCopy-freeWhenDone:YES

(instancetype)dataWithBytesNoCopy:(void *)bytes
length:(NSUInteger)length
freeWhenDone:(BOOL)freeWhenDone
NSData *imgData = [NSData dataWithBytesNoCopy:buffer length:dataLength freeWhenDone:YES];
"u know, if yes, the returned object takes ownership of the bytes pointer and frees it on deallocation."
&& I am using ARC.. memory leak here? no, i do not think so..but tool gives me the waring...
how can I do for this? thx buddy~

Duplicate of #52. Please, take a look at the explanation there. This is a real bug.


Async snapshot may take long time if replica read is used with hibernate region

Bug Report

What version of TiKV are you using?

v5.0-rc release
What operating system and CPU are you using?

Using the i3.4xl on aws, a tikv-server on a single machine.
Steps to reproduce

Simple read/write requests like:

Read. Table range scan using prefix clustered index.
Write. Simple update serveral keys per transaction.

Enable the hibernate region feature(which is default enabled on master or v5.0-rc).
Using the follower-read in the client for each session.
What did you expect?
The latency and qps are expected.
What did happened?
Sometimes latency are very high, especially for the async-snapshot duration, while other metrics look good, there are just a few regions and load is not high.

@BusyJay has helped to analyze this phenomenon.
I believe it’s related to follower read and hibernate regions. According to the logs, one of the timeout requests is trying to request a peer of region 3848 (you can find such logs by searching error-response and looking around the context). The peer happens to be leader just before the error log. And it’s the first time it becomes leader, so the timeout request has to be accepted when it’s still follower. So TiDB should be using follower/replica read. A replica can execute read when when it has applied to the index returned by leader. I notice that hibernate region is enabled in configuration file, which can prevent leader from broadcasting its commit logs, and possibly lead to this problem. There is only a few regions in the cluster, I suggest to disable hibernate regions instead. And TiDB may also need to investigate if it’s expected to send a follower read request to a TiKV instance. As far as I known, only tiflash should accept follower read and it will keep polling unfinished requests.

Make these two features work well together.
Record the wait duration applying to the expected index.

There should be three metrics can be collected:

how many replica reads are served
how many reads/proposals waiting in queue
how long do reads/proposals waiting in queue after they are committed before they are applied, aka apply wait time of read requests

We need a release plan for generic replica read.

After disabling the hibernate region, the async snapshot duration could still be very high, leading to the high wait duration of coprocessor requests.
After disabling the replica-read too, this phenomenon seems disppeared. It's still needed to trace the root cause and add related metrics, and as @BusyJay has said, we may need a release plan for generic replica read.

@coocood has taked a look at this, it's possible not related to the 1pc usage and related memory lock checks refactored for replica read in https://github.com/tikv/tikv/pull/8926. The user does use 1pc to commit the transactions.


Internal error

Environment data

Language Server version: 2021.8.3
OS and version: Windows 10 20H2
Python version (& distribution if applicable, e.g. Anaconda): Pyhton 3.9.6

Expected behaviour
No errors
Actual behaviour
A lot of code was marked unreachable, and an internal error occured
Logs

An internal error occurred while binding file "c:\Users\Admin\ywt\2.py": TypeError: Cannot read property 'lookUpSymbol' of undefined
    at b._bindNameToScope (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\binder.ts:2928:32)
    at b.visitAssignmentExpression (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\binder.ts:842:18)
    at b.visitNode (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\parseTreeWalker.ts:136:26)
    at b.walk (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\parseTreeWalker.ts:96:37)
    at callback (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\binder.ts:1805:22)
    at b._setTrueFalseTargets (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\binder.ts:2432:9)
    at b._disableTrueFalseTargets (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\binder.ts:2419:14)
    at b.visitBinaryOperation (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\binder.ts:1804:18)
    at b.visitNode (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\parseTreeWalker.ts:154:26)
    at b.walk (c:\Users\Admin\.vscode\extensions\ms-python.vscode-pylance-2021.8.3\dist\pyright-internal\src\analyzer\parseTreeWalker.ts:96:37)

Code Snippet / Additional information

This issue occured when I was trying to reproduce an issue.
from typing import Any, Callable

def my_decorator(arg: list):
    def _inside(func: Callable[..., Any]) -> Callable[..., Any]:
        return func
    return _inside

@my_decorator([triple_i for i in range(10) if (triple_i := i * 3) & 1])
def foo():
    pass

When I changed [triple_i for i in range(10) if (triple_i := i * 3) & 1] into [], all the errors were gone.

Is this #1745?

Oh yes, these issues are similar.

Oh sorry, I didn't look at it carefully. 😅 Feel free to mark this issue as duplicate and close it.


Add option to disable sessionState in Accordion

Adds a new configuration option to the Accordion component, allowing users to explicitly disable (or enable) the session storage and restoration functionality.
Some developers have expressed a desire to disable this function, which currently can only be done by separately clearing sessionStorage or randomising the id of accordions, as described in #3182.
Option naming
My understanding of good naming is that boolean options, like checkboxes, should always be labelled using affirmative, opt-in kind of language: yes, remember my password; yes, allow analytics cookies; yes, I want disposable cutlery; and so forth.
As such, the parameter is named affirmatively—rememberExpanded in JS and Nunjucks APIs and data-remember-expanded in the HTML API.
I opted for this name as it's shorter and more self-explanatory (or maybe, less technical-sounding) than others I thought of (e.g. rememberExpandedSections, rememberSectionState, enableStateRemembering), but I'm not tied to it and am open to suggestions. It also feels more congruent with the existing expanded option available to each section.
However, this means that the default value for this setting is true (enabled) with the typical use case being developers setting it to false (disabled), which might be a bit unintuitive.
Usage
Like internationalisation options, the configuration can be provided via JavaScript initialisation, in HTML using a data-* attribute, or via a parameter on the govukAccordion Nunjucks macro.
JavaScript example:
new window.GOVUKFrontend.Accordion(document.getElementById('accordion'), {
  rememberExpanded: false
}).init()

Nunjucks example:
{{ govukAccordion({
  id: "accordion",
  rememberExpanded: false,
  items: […]
)} }}

HTML example:
<div class="govuk-accordion" data-module="govuk-accordion" id="accordion" data-remember-expanded="false">
 […]
</div>

Changes

The Accordion's default configuration has a new default: rememberExpanded: true.
The setInitialState and storeState methods of the Accordion's JS now check that rememberExpanded is true in addition to ensuring that sessionState is available.
The Accordion template now looks for and uses rememberExpanded if it's provided.
Added documentation for the rememberExpanded Nunjucks parameter. Also tweaked the id parameter documentation.
Added example and tests for the existence of the data-* attribute in the template and for the functionality itself.

There doesn't seem to be any strong opinions regarding the parameter name, so I'm going to keep it as-is for now. We still have a little bit of leeway before release to change it if we want to.

I'm now having second thoughts on the parameter naming. Having noticed that many other options in Frontend don't follow the 'affirmative language' guideline—like the Button'spreventDoubleClick and Error Summary's disableAutoFocus—it may be more consistent to reverse the logic of this one too.


Arria 10 PAC won't update due to SPI flash timeout

I'm trying to apply the 1.2.1 update, but it is timing out for me:
(python) # fpgaotsu /usr/share/opae/a10-gx-pac/fpgaotsu/base/otsu-09C4.json
[2020-06-15 12:59:13,298] [INFO    ] [MainThread] Intel PAC with Intel Arria 10 GX FPGA 0000:01:00.0 is not secure.
[2020-06-15 12:59:13,307] [WARNING ] [MainThread] Update starting. Please do not interrupt.
[2020-06-15 12:59:13,307] [INFO    ] [0000:01:00.0] Updating Intel PAC with Intel Arria 10 GX FPGA : 0000:01:00.0
[2020-06-15 12:59:13,307] [INFO    ] [0000:01:00.0] Erasing flash@0x7fd0000 for 196608 bytes
[2020-06-15 12:59:33,313] [ERROR   ] [0000:01:00.0] [Errno 110] Connection timed out
Traceback (most recent call last):
  File "/home/ddcc/opae-sdk/python/opae.admin/opae/admin/tools/fpgaotsu.py", line 511, in process_flash_item
    self.erase(flash, mtd_dev)
  File "/home/ddcc/opae-sdk/python/opae.admin/opae/admin/tools/fpgaotsu.py", line 317, in erase
    mtd_dev.erase(erase_start,
  File "/home/ddcc/opae-sdk/python/opae.admin/opae/admin/utils/mtd.py", line150, in erase
    fcntl.ioctl(fp.fileno(), self.IOCTL_MTD_MEMERASE, iodata)
TimeoutError: [Errno 110] Connection timed out
[2020-06-15 12:59:33,314] [INFO    ] [MainThread] Total time: 0:00:10.006953
[2020-06-15 12:59:33,314] [ERROR   ] [MainThread] Intel PAC with Intel Arria 10 GX FPGA 0000:01:00.0: [Errno 110] Connection timed out
[2020-06-15 12:59:33,314] [ERROR   ] [MainThread] One-Time Secure Update failed

When I examine the kernel log, it appears the SPI flash driver is timing out:
[ 3696.799549] altr-asmip2 altr-asmip2.1.auto: altera_asmip2_read_reg timeout
[ 3696.799551] error -110 reading SR

I did come across some comments from Matthew Gerlach that this SPI flash driver has a 10 sec timeout to prevent the system from hanging: https://patchwork.kernel.org/patch/9962009/#21027297

From the output of fpgaotsu and the kernel message, it looks like fpgaotsu is trying to erase a sector of flash.  Erasing flash involves sending a "flash erase" command to the flash chip and then polling on the SR register in the flash looking for the Work In Progress bit to clear.  It looks like the flash chip is not responding to the SR register request.
This could be a temperature problem or flash problem.

Hmm, ok. Do the following temperatures look normal?
Board Management Controller, microcontroller FW version: 26889
Last Power down cause:POK_CORE
Last Reset cause: None
//****** TEMP ******//
Object Id                        : 0xF000000
PCIe s:b:d.f                     : 0000:01:00.0
Device Id                        : 0x09C4
Socket Id                        : 0x00
Ports Num                        : 01
Bitstream Id                     : 0x123000200000185
Bitstream Version                : 1.2.3
Pr Interface Id                  : 69528db6-eb31-577a-8c36-68f9faa081f6
Boot Page                        : user
( 1) FPGA Core TEMP              : 62.00 Centigrade
( 2) Board TEMP                  : 52.00 Centigrade
( 3) QSFP TEMP                   : N/A
( 4) Core Supply Temp            : 68.84 Centigrade

Hi all - we have this same problem on at least one of our two lcaol Arria10 PAC cards.
Card 1 - fails during the initial fgaotsu update:
[]$ sudo fpgaotsu /usr/share/opae/a10-gx-pac/fpgaotsu/base/otsu-09C4.json
[2020-09-02 21:12:14,385] [INFO    ] [MainThread] Intel PAC with Intel Arria 10 GX FPGA 0000:01:00.0 is not secure.
[2020-09-02 21:12:14,393] [WARNING ] [MainThread] Update starting. Please do not interrupt.
[2020-09-02 21:12:14,394] [INFO    ] [0000:01:00.0] Updating Intel PAC with Intel Arria 10 GX FPGA : 0000:01:00.0
[2020-09-02 21:12:14,396] [INFO    ] [0000:01:00.0] Erasing flash@0x7fd0000 for 196608 bytes
[2020-09-02 21:12:14,591] [INFO    ] [0000:01:00.0] Writing flash@0x7ff0000 for 104 bytes (RushCreek_Release_key_blk2)
(100%) [████████████████████] [104/104 bytes][Time:0:00:00.000068]
[2020-09-02 21:12:14,593] [INFO    ] [0000:01:00.0] Reading flash@0x7ff0000 for 104 bytes for verification
(100%) [████████████████████] [104/104 bytes][Time:0:00:00.006021]
[2020-09-02 21:12:14,600] [INFO    ] [0000:01:00.0] Verified flash@0x7ff0000 for 104 bytes (RushCreek_Release_key_blk2)
[2020-09-02 21:12:14,600] [INFO    ] [0000:01:00.0] Erasing flash@0x1800000 for 41943040 bytes
[2020-09-02 21:12:54,742] [INFO    ] [0000:01:00.0] Writing flash@0x1800000 for 41943040 bytes (dcp_1_2_1_rot_reversed.rpd)
(100%) [████████████████████] [41943040/41943040 bytes][Time:0:01:06.238681]
[2020-09-02 21:14:01,045] [INFO    ] [0000:01:00.0] Reading flash@0x1800000 for 41943040 bytes for verification
(100%) [████████████████████] [41943040/41943040 bytes][Time:0:00:58.330970]
[2020-09-02 21:14:59,404] [INFO    ] [MainThread] Total time: 0:02:45.010901
[2020-09-02 21:14:59,405] [ERROR   ] [MainThread] Intel PAC with Intel Arria 10 GX FPGA 0000:01:00.0: Verification of dcp_1_2_1_rot_reversed.rpd @0x25165824 failed
[2020-09-02 21:14:59,405] [ERROR   ] [MainThread] One-Time Secure Update failed

Card 1 temps:
fpgainfo temp
Board Management Controller, microcontroller FW version 26889
Last Power Down Cause: POK_CORE
Last Reset Cause: None
//****** TEMP ******//
Object Id                     : 0xEE00000
PCIe s:b:d:f                  : 0000:01:00:0
Device Id                     : 0x09C4
Socket Id                     : 0x00
Ports Num                     : 01
Bitstream Id                  : 0x123000200000185
Bitstream Version             : 1.2.3
Pr Interface Id               : 69528db6-eb31-577a-8c36-68f9faa081f6
Boot Page                     : user
(11) FPGA Core TEMP           : 38.00 °C
(12) Board TEMP               : 32.00 °C
(14) QSFP TEMP                : No reading (reading state unavailable)
(15) Core Supply Temp         : 43.92 °C


System.MissingMethodException: Method 'ViewTreeObserver.RemoveOnGlobalLayoutListener' not found.

When I use Toasts.Forms.Plugin V <IP_ADDRESS> on my Xamarin Forms Android App and I compile it with Android level 15 (4.0.3) and run it in a emulator running Android 4.0.3, I get this exception...
It is strange, should not
       if (Build.VERSION.SdkInt < Build.VERSION_CODES.JellyBean)
            {
                croutonView.ViewTreeObserver.RemoveGlobalOnLayoutListener(layoutListener);
            }
            else
            {
                croutonView.ViewTreeObserver.RemoveOnGlobalLayoutListener(layoutListener);
            }

prevent such errors?

@tobiasschittkowski - I can't replicate the error when I have the minimum version set to API 15 and the compile set to API 23. This allows you to continue to run on API 15 devices. We will continue to support that configuration for the time being (even though as it stands, API 15 is on less than 3% of Android devices).
But I can't support setting the Compile against 4.0.3.


Feature/prf to zn

Changes:

Add LongAesPrf that uses k keys for a PRF n*kn->kn
Add HashThenPrfToZn for retrieving Zn elements from a PRF
Bugfix of ByteArrayImplementation.append

My commit broke the tests, but I don't see how anything should have changed semantically. I guess previously, your copyOfRange appended zeros to keys?! Not sure what's going on :)

Yes, I guess the copyOfRange function breaks it. It was more of a appendBytes :)

Added proposals A and B for hashThenPrfToZnVector:
A adds a counter prefix to the hash input.
B runs hashThenPrfToZnVector with the input and then uses the output ZnElement as the next input.
Some timings are below

I guess B would not formally be considered a PRF anymore, since querying (y_1, y_2, ...)  = F(x) and then querying F(y_1) will yield (y_2, ...), which makes it easily distinguishable from a random function.
It may be that your version A is just slower right now because you're hashing twice. Once via the SHAHashAccumulator and then within the hashThenPrfToZn() call. If you replace the SHAHashAccumulator with just a normal ByteArrayAccumulator (or whatever it's called), I think most of the performance difference should vanish.
Also note that version A is easily parallelizeable, so that would certainly be my go-to.
Version A is secure. However, currently, it's iffy to use both hashThenPrfToZn and hashThenPrfToZnVectorA because their results will correlate. Maybe prepend something to the input of the hash function - like the number of elements you're deriving from this call (vectorSize or 1) to unentangle this.

I guess B would not formally be considered a PRF anymore, since querying (y_1, y_2, ...) = F(x) and then querying F(y_1) will yield (y_2, ...), which makes it easily distinguishable from a random function.
It may be that your version A is just slower right now because you're hashing twice. Once via the SHAHashAccumulator and then within the hashThenPrfToZn() call. If you replace the SHAHashAccumulator with just a normal ByteArrayAccumulator (or whatever it's called), I think most of the performance difference should vanish.
Also note that version A is easily parallelizeable, so that would certainly be my go-to.
Version A is secure. However, currently, it's iffy to use both hashThenPrfToZn and hashThenPrfToZnVectorA because their results will correlate. Maybe prepend something to the input of the hash function - like the number of elements you're deriving from this call (vectorSize or 1) to untangle this.

Good point, I just realized that the SHAHashAccumulator does not prepare using SHA, but actually uses SHA to generate the byte[]. I will adapt that and then use version A

Updated the describtion and changed some wrapper signatures for more flexibility


can we use jdk 1.8?

Hi @hargathor  / @cdanger,
Can we use JDK 1.8 ?  Mostly for convenience on Collection manipulation (of which there is a lot :smile: ) and use of Lambda functions

I'm actually surprised we're still at java 1.7 on this project. Most other authzforce projects have upgraded. So yes, please do :-)


App does not give options for places with same name or postal code

Open Weather
Go to Change Location
Enter a name that has 2 cities in different places

Expected Result: The app should give options to select desired city
Actual Result: The App chooses 1 location without giving options
Haiku-2018-01-04T03-55-59-392554000Z.webm.zip

So I tested with 2 french cities of same name
Bordeaux, France, Aquitaine (the well known city)
Bordeaux, France, Ile de France (another one I even didn't know of before going to Yahoo page)
Note that about two years ago french regions were rearranged, some were grouped & renamed; API seems to use old names for now.
If you put Bordeaux, France only, API picks weather for Bordeaux, France, Aquitaine probably because it is first in alphabetic order.
If you enter full infos, you obtain indeed different weathers but location is shown both times as
"Bordeaux, France" so it's difficult then to distinguish which one is where. Since there are also other cities named Bordeaux around the world, if possible, it would be nice to be able to chose to display: City, country or City, region.

Fixed in 1cb655c05b0c1662f78b25214fa15735536757e8


Clicking NavLink triggers a complete rerender

components: NavLink
reactstrap version #8.4.1
import method es
react version #16.13.1
bootstrap version none

What is happening?
When clicking on the NavLink the whole application gets rerendered , as if a window.location is being done.
What should be happening?
To behave like  from react-router-dom, which does not rerender.
Also if I put a  inside the NavItem it behaves correctly.
Also if I put a tag={Link} inside NavLink, which probably is the same as above, it behaves correctly.
Steps to reproduce issue
see code below.
Error message in console
None
Code
import React from 'react';
import ReactDOM from 'react-dom';
import {BrowserRouter} from "react-router-dom";
import {Nav, NavItem, NavLink} from "reactstrap";

ReactDOM.render(
    <BrowserRouter>
        <div>
            <Nav className="mr-auto" navbar>
                <NavItem>
                    <NavLink href="/home">Home via NavLink</NavLink>
                </NavItem>
            </Nav>
        </div>

    </BrowserRouter>,
    document.getElementById('root')
);

Am I doing something wrong while using NavLink ? Thank you for any help !

reactstrap is not concerned about navigation. Please before opening a issue, first search if a issue already exists.
https://github.com/reactstrap/reactstrap/issues/298#issuecomment-273733613

Ok, thanks.
Although I think it would be interesting to understand why the whole app is being reloaded when clicking on a link.

why the whole app is being reloaded when clicking on a link.

Because it is a link :slightly_smiling_face:


chore(main): release sdk 5.1.0

:robot: I have created a release beep boop
5.1.0 (2024-04-13)
Features

sdk: Add MultiLocation override feature ⛓ (eb6cdbe)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/paraspell/xcm-tools/releases/tag/sdk-v5.1.0 :sunflower:


Maybe let repetition of letters when using buffer_picker?

Hey, I love your plugin, it gives us so much freedom and customizability! Thanks so much for this. 🙏
I just opened a PR about multibyte characters on buffer picker, but I also have a question about this functionality.
If we open and close buffers, the letters for buffer picker don't repeat, which is very clearly working as intended by looking at the code and the comments in the code, but wouldn't it be more intuitive if they did repeat? :thinking: For instance, if I set letters to be my homerow asdfghjkl, I think it would make sense for the first buffer to always be a, the second always be s etc.
What do you think? Maybe this could be configurable, have an option to recycle letters or not? Or maybe it would just be too much work? :sweat_smile:
I thought that maybe getting the letter using buffer.index could do it, but I don't really know all the implications, I didn't really dove that deep in the code, but it seems you put a lot of effort into not allowing exactly that, so it may be more complicated.

I like the idea of having that option! I believe Buffer.index should work consistently to get the pick character. I didn't write the pick file code so I can't speak to the original intentions, but I'll look into implementing this soon.

All done! I realized that that's how it should be by default. The current code is very much geared towards people using the filename to pick the char, so when picking sequentially from the list it could act a bit strange. #132 uses an index tracking mechanism instead of modifying the string, so that the picked characters will always appear in the same order.

Hey, I just updated here, it works great! The only thing is what happens when we have more buffers than letters configured? I know this is probably never gonna happen, but before it would show a ? and now apparently it just shows nothing. I mean, it is just a silly edge case that seems very unlinkely, and maybe showing nothing/empty string is actually better, but I just wanted to let you know about it haha
Thanks again! I feel very confortable using this now, and it was so fast as well for your responses. 👏

Of course! Glad it works well. Not sure why it's not showing anything for you, I just tested and it's still showing a ? for me.

Well, now that is very weird. My code is literally just this (it tries to get the first letter or the pick_letter):
text = function(buffer)
  if is_picking_focus() or is_picking_close() then
    return buffer.pick_letter
  end
  return vim.fn.strcharpart(buffer.unique_prefix .. buffer.filename, 0, 1)
end,

Well, I'm on neovim 0.9.1 if it matters.
Anyways, I just put a simple check like this and all's well
if buffer.pick_letter == '' then
  return '?'
end

But I decided to make weird decisions on my config to test more edge cases and realized that when using filenames, if we have more buffers than letters configured, it starts showing weird things instead of the first letter of the filename. I'm really trying to find kinda bizarre edge cases though! Haha
Something like this:
require('cokeline').setup({
  pick = {
    use_filename = true,
    letters = 'a',
  },
-- ...

Now if I open two files with names, say, apples.lua and oranges.lua and start picker, it shows a on both (happens if first file is orange and second is apple as well). But if I open two files with names bananas.lua and oranges.lua and start the picker, it shows a on bananas and ? on oranges. And if I open like 3 or more files sometimes the a gets repeated. Anyways, it looks really weird when I don't have enough letters and use filenames, which is not the case in real life, but it is weird nonetheless.
But since the ? issue happens here but not with you, I don't know if I trust myself! 😅
Anyways, thanks a bunch. ^^

I'm actually gonna reopen this for now since there are a few issues, definitely would like to work out those edge cases before considering this complete.

Fixed


docs: update project maintainers list

What is the purpose of this PR?
Primarily, this PR seeks to update the MAINTAINERS list, such that it is an accurate representation of active maintainers for the OpenEBS project.  In part, it is a response to a request for the same from the CNCF ToC, as part of our ongoing efforts to raise OpenEBS to incubation status.
Secondary to this it aims to:

simplify the formatting and hence improve readability of the overall document
remove unnecessary information, including the requirement for reviewers to declare a company affiliation
adds information considered important, including email contact details for active maintainers

Why have I been requested as a reviewer?
If you have been asked to review this PR, it is because you are currently listed in the MAINTAINERS file as an active maintainer of the project.  Therefore, in accordance with good project governance, you are being asked to:

signify your consent, or otherwise, to the changes herein proposed
in doing so, signify specifically whether you wish to remain an active maintainer, with associated responsibilities, or otherwise

If you do not submit a review within the review period (ending 31st Oct 2022), this will be taken to signify your consent to all of the changes to maintainer status proposed in this PR.  If you do not agree, you must respond with either comments or a review to that effect on or before that date
Is the published OpenEBS governance policy being followed?
The policy as it currently stands is incomplete, in that it makes no explicit provision for the removal / transition to emeritus status of maintainers who are no longer contactable and thus cannot be contacted to request a self-review of their active status.  Once the active membership of the maintainers group has been established via the route proposed by this PR, those persons will be asked to develop and vote on an enhanced policy document which allows the maintainers to keep this information updated more readily.  That will include establishing the requirement to hold correct contact details for active maintainers.
What happens next?
This PR will enter a reviewing state.  Comments and changes may be requested, up until the 31st October 2022.  After that time, it will be merged in such state as it is, such changes as have been requested and agreed by its reviewers having been incorporated.
Other changes
This PR also seeks to update the status of previously listed reviewers.  In this, the criteria for remaining an active reviewer are to a) already be listed as a reviewer in the current version of this file and b) having made at least one PR review for the project in the last 12 months.
Reviewers who have not met these criteria it is being proposed herein to transition to the status of "emeritus reviewer", from where they may be restored to active reviewer status on either their request, or that of another active maintainer or reviewer.  In either case, evidence of continuing active participation in that role will be required.
Signed-off-by: GlennBullingham<EMAIL_ADDRESS>

There is the need for updating maintainers list. Thanks for taking it up. I would request to make sure that we have mail id and get approvals from the active maintainers list as per the change before we merge this PR.

Hi @vishnuitta, good to hear from you.  Thanks for making contact, and for contributing your review to this PR.  Indeed, one of its objectives is to obtain and hold valid email contact details for the project's active maintainers.  For everyone proposed in that role in going forwards (via the changes on this PR), we hold the details included, which are currently considered to be valid.  If someone wishes to use details different to those currently shown, they should of course feel free to request the appropriate change at any time.
I hope to receive reviews from all those of whom they have been requested, namely, the current maintainer list this repo.  Any accurate and valid changes requested in those reviews, which do not attract majority overrule of the eligible reviewers, will be incorporated prior to it being merged.  However, the default action remains to merge the PR such as it stands at midnight on the 30th Oct.  There cannot be an indefinite period of review, awaiting positive release by all eligible parties.  The current status of maintainers is largely unknown and has been for some time now.  Good governance requires that we remedy this with reasonable haste.

@GlennBullingham - Inline with @vishnuitta - let us use the guidance provided here:
https://github.com/openebs/openebs/blob/main/GOVERNANCE.md#stepping-down-policy
As a step forward:

Can you please first update the governance to reflect the new policy? What changes need to be done?
Use the data captured in the devstats and probably responses in the community slack or meetings to add or remove the folks from the owners file.

I see that there are already 3 folks that have approved on this - probably - restrict the changes in this PR only to those three folks and open a new PR once the governance is updated.

Firstly, thank you everyone who has taken the time to either contribute a review and/or engage with me on this topic over other channels.
The need to formally establish a clearly defined membership of active maintainers is, in my opinion, the most pressing matter as it is essential to the health and future growth prospects of the project.
I take the suggestion above from @kmova as "a way to move forwards" with this necessary task, whilst taking into due consideration the changes requested by its reviewers.  Namely:

Changes on this PR will be restricted only to changes in the status of current project Maintainers.  The reviewer list will remain unchanged, subject to review in a later stage of this broader topic of governance updates/refreshes.
Three current maintainers have approved this PR without requesting changes.  Those persons will be considered to have thus given their active consent to have their status changed from Maintainer to Emeritus Maintainer
Those persons who have neither contributed a review, nor whom have I been able to elicit contact with via other channels are @ksatchit and @muratkars.  Since I believe it to be reasonable that recognition as an active Maintainer requires as a minimum for such persons to monitor for, and respond in a timely fashion to governance issues, and that for this purpose the project should hold valid contact details, the PR will move them to Emeritus Maintainer status.  As we have discussed above, the intention is that those persons holding such a status can be restored to full Maintainer status at any time, at their request by raising a PR here to that effect.  Emeritus status should be "for life", and I'll proposing that such concepts and procedures are incorporated into the formal governance policy.  I think that makes this extraordinary policy decision fair to all concerned.
I have spoken with @gila directly and he has indicated that it is his wish to remain listed an active maintainer at this time.  I will include valid email details for him accordingly.
Anyone who has contributed a request for changes will remain listed as an active maintainer at this time.  Subsequent PRs will seek to address review comments (i.e. updates to governance policy), and to call for a definitive yes/no from those persons as to whether they wish to remain active maintainers of the project.

https://github.com/openebs/openebs/pull/3580#issuecomment-1297549757
Sounds good @GlennBullingham as you mentioned in this comment. I would like to look at the changes to make sure that I understood correct :)

Use the data captured in the devstats and probably responses in the community slack or meetings to add or remove the folks from the owners file.

@GlennBullingham .. as @kmova suggested, it would be better to look at devstats and community responses as well to add or remove the people from the list. If you think that some XYZ person would be an active member in the future but not now, its always possible to come and update the list accordingly. It gives more data driven points for your proposal and the required recognition for those who are actively working on this project. (This need not be the only way but a good way to say that the proposed list is really active).

#3580 (comment) Sounds good @GlennBullingham as you mentioned in this comment. I would like to look at the changes to make sure that I understood correct :)

Hi @vishnuitta I've committed the changes discussed for review: https://github.com/openebs/openebs/pull/3580/commits/9ea42b5cf240f70a1cb79d6c22bc7aa18b82f67a

The scope of the changes effected by this PR now having been limited, as per the request of its reviewers, to just changes of status of specific (in)active maintainers (with either their explicit approval herein, or by merit of having being "timed out" unresponsive on available communications channels), and the proposed commit now having been available for review for the past 6 days, I give fair warning that I will merge as-is on Friday 11th November after 5pm UK time, unless further comment requesting otherwise is made here before that time.

Thanks @kmova and @pawanpraka1.  Merging as described.


Country Request: Mauritius

Hi,
I'd like to request RapiD data for Mauritius.

Thanks for the request @sjdvda!
Added to the list

Mauritius is now available.
Happy mapping!


Add upsert method to dialogs list

It will be nice to add the note in documentation too!

@mtangoo yes indeed. Here is the PR: https://github.com/stfalcon-studio/ChatKit/pull/208.


set up api and fetch one random exercise

Create a apiSdk class in the frontend to put all our api call here.
Set up the two api call to fetch allExercises and get oneRandomExercise.
Implement an example on how to use the api in the play page

LGTM, just needs some conflict resolution