Hey Thank you

It is not clear what should we do to activate it. I run the bash script.
Now `~/.config/nvims/exists and it has 2 files;
.rw-r--r-- 1.2k mac 20 Dec 14:01  neovim_distros
.rw-r--r--   35 mac 20 Dec 14:08  nvim_appnames
So what is the next?

@pwnwriter is correct.
Check out this video:  https://www.youtube.com/watch?v=xyJX55Zf99k&t=6s
Keep the following in mind:

install nvims
After nvims, should be in  your path, so run nvims, if not you need to adjust your path.
Select the distro.  It will bootstrap itself.
After  installing a distro, you need a new shell that has sourced ~/.config/nvims/nvim_appnames
nvim-traap should now work.

I ran , nvims is on my path and executed fairly,  but there is nothing to
choose , my options is empty,  I wonder whether,  Myself should clone those
nice repos , or it would do automatically,  and how I should feed my
opinion list? Thanks in advance
On Wed, 20 Dec 2023, 19:21 Gary Allan Howard, @.***>
wrote:

@pwnwriter https://github.com/pwnwriter is correct.
Check out this video: https://www.youtube.com/watch?v=xyJX55Zf99k&t=6s
Keep the following in mind:

install nvims
After nvims, should be in your path, so run nvims, if not you need
to adjust your path.
Select the distro. It will bootstrap itself.
After installing a distro, you need a new shell that has sourced
~/.config/nvims/nvim_appnames
nvim-traap should now work.

—
Reply to this email directly, view it on GitHub
https://github.com/Traap/nvims/issues/3#issuecomment-1864721401, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFBG25G2DKUN5CYOVPTUKGTYKMCOLAVCNFSM6AAAAABA4TQU4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUG4ZDCNBQGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Do you have fzf installed or not?

Nothing to choose

Please show screenshot.

This is my original nvim ,

What's up with your neovim_distros file?
Do cat
cat ~/.config/nvims/neovim_distros

if the file doesn't have any content put contents from the repos neovim_distros file.
AFAIK, traap haven't used anything that does care for specifically Linux. It should work around unix. The piping and all the stuffs.

cat ~/.config/nvims/neovim_distros                                                                                took 6s   22:37 ❯
#!/bin/bash
# Define Neovim applications you want to experiment with.

# The repository cloned must bootstrap itself.  In otherwords, clone and nvim
# is all tha tis needed.
#
# alias      | Github repository       | default or branch name
readonly neovim_distros=(
  "astro     | AstroNvim/AstroNvim     | default"
  "asyncedd  | asyncedd/dots.nvim      | default"
  "barebones | Traap/barebones         | default"
  "baretmux  | Traap/barebones         | tmux"
  "default   | none                    | none"
  "exos      | exosyphon/nvim          | none"
  "kickstart | nvim-lua/kickstart.nvim | default"
  "lervag    | lervag/dotnvim          | default"
  "nvchad    | NvChad/NvChad           | default"
  "nvconf    | TechnicalDC/NvConf      | default"
  "prime     | Traap/init.lua          | default"
  "starter   | LazyVim/starter         | default"
  "traap     | Traap/nvim              | default"
  "vapour    | Traap/VapourNvim        | default"
  "void      | nvoid-lua/nvoid         | default"
  "xray      | Traap/nvim              | v0.9.5-lazyvim"
  "zero      | Traap/lazy.zero         | default"
  "zulu      | Traap/nvim              | v0.6.8-packer"
  "OVIwrite  | MiragianCycle/OVIWrite  | default"
)

@mbaneshi  I do not have a MacOSX machine.  We might be running into difference in bash interperters.
Code change for debugging

Sample Output

Post an image.

yes , alias output not works , my default Shell is fish , I clone repo with git clone , and did the rest , and also change mentioned line for debug , at the end there is no output.
I did same for bash , yet no out put .
bash-5.2$ bash --version
GNU bash, version 5.2.21(1)-release (x86_64-apple-darwin20.6.0)
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Interesting.  I'm not sure how to help you get bash setup on the max.  I did check the code for any non-standard compatibility issues with GNU Bash and found nothing.  I did updated line 1 to use the system default interpreter for bash.
#!/usr/bin/env bash

I do not expect this to correct your issue.

@Traap Thank you for time, and effort. ❤


hh:mm:ss does not change

Using the moment utility I cannot change the hours, minutes and seconds.

[x] The issue is present in the latest release.
[ ] I have searched the issues of this repository and believe that this is not a duplicate.

I try to change the hours, minutes and seconds and it always goes on 00:00:00
https://codesandbox.io/s/rough-rain-nesho?file=/src/index.tsx
Happens in latest alpha version: https://codesandbox.io/s/friendly-knuth-i4jsy?file=/src/App.js

Tech
Version

@material-ui/core
v4.11.0

@material-ui/pickers
v3.2.10

React
v16.13.1

Check your use of format & inputFormat
Old: format="DD/MM/yyyy HH:mm:ss"

New: format="DD/MM/YYYY HH:mm:ss"


Restarted monotonic step size

Codecov Report
Base: 87.28% // Head: 86.39% // Decreases project coverage by -0.88% :warning:

Coverage data is based on head (fe24503) compared to base (989d18b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   87.28%   86.39%   -0.89%
==========================================
  Files          17       17
  Lines        2052     2073      +21
==========================================
  Hits         1791     1791
- Misses        261      282      +21

Impacted Files
Coverage Δ

src/linesearch.jl
80.87% <0.00%> (-9.93%)
:arrow_down:

src/pairwise.jl
87.58% <ø> (ø)

src/utils.jl
79.39% <0.00%> (-0.49%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


⚠ Bofrost.de has degraded performance

In e097382, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1715 ms

Resolved: Bofrost.de performance has improved in d88062d after 6 minutes.


Thank you very much for this great app. Tried to pull gguf form HF but failed to do that.

I tried to download this gguf: https://huggingface.co/NikolayKozloff/SambaLingo-Serbian-Chat-GGUF Unfortunately, Open Local UI can't do that for some reason. It displays this dialog for eternity:

What am i doing wrong? How can i fix that? Help me, please.

Oh, just read that it requires ollama. Closing the issue.

Hello @JohnClaw! Nice to get your feedback.
In the future Ollama will be automatically installed by the setup wizard, for now you'll have to do that manually.
However I did a quick search in the Ollama models library listing available models to pull and the one you mentioned is not on the list. If you want to add a model from a GUFF file you should refer to this page. You can still do that from inside the app (never tested), I think you'd need to place the GUFF in the app directory omit the base model in the create dialog and reference the the download one in the modelfile (FROM ./NikolayKozloff/SambaLingo-Serbian-Chat-GGUF).
Taking note of that. I'll open a new issue to add the feature

Hello, @JohnClaw! I've added the feature #38 you needed, hope this will make the process easier :)

Hello, @JohnClaw! I've added the feature #38 you needed, hope this makes the process easier :)

Thanks. Please, compile the binary for Windows.

It's a matter of a pair of days or less. We just wanted to fix the remaining bugs


improve code quality

https://app.codacy.com/manual/rpotter12/whatsapp-play/dashboard?bid=13271659
According to this code quality is C. It should be improve.
How to improve code quality:

open https://app.codacy.com/manual/rpotter12/whatsapp-play/files?bid=13271659
solve errors written in each files.

I'm working in a branch to refactor it!


Does it support the .net client to get messages from kafka, and these messages are canal written to kafka?

Canal supports protobuf3.0, is there sample code? I'm a newbie, thanks!

Of course, CanalSharp is just a client of canal.
After CanalSharp receives the message, you can write to Kafka, rabbitmq and redis etc.
sample


Questions about reccommended workflow

Hello!
I would like some advice on the reccommended workflow from Zotero to Notion.

I have 4 main folders in Zotero: Projects, Areas, Resources, and Archive. I would like to add all of these to Notion in the same database. It would be amazing if there was a new column for each level of subfolder that you can use to categorise things, where the column would contain the name of that subfolder
I am not sure what to do with tags. Am I able to add tags to Notion and have it back-sync?
Can I change the Status column to have other options?
I want to use notion to sort projects through my process of reviewing them. This process will sometimes eliminate a paper from a project. Is there an easy way to then take these "eliminations" and then move them in Zotero?

A lot of these questions are in general related to how well the two databases relate. Whether it goes back and forth or not.
Any help would be greatly appreciated. Also looking for tips on how you organise all this.
Best regards
Victor

Hi Victor, thanks for your questions!

Notero syncs all items into the same database in Notion. In the Notero preferences within Zotero, you can select the folders (called "collections" in Zotero) that you want to sync—including any subfolders. Notero will sync the name of collections that your items are in as long as your Notion database contains a multi-select property named Collections. (The example databases linked from the readme have this property already.)
Unfortunately, the sync process only works from Zotero to Notion—not the other way around. See the How to sync from Notion back into Zotero section in the FAQ for more info.
You can absolutely change the Status column however you please. It's not used by Notero itself, so it doesn't have any specific requirements.
Since we can't sync from Notion back to Zotero, there's not a way to automate this process. The best suggestion I have is to create some sort of filtered database view in Notion that can give you an easy way to reference the items you need to update in Zotero.

Truth be told, I personally don't handle research references, so I don't actually use Zotero myself. 😅 There are some guides made by other folks listed in the Usage Guides section of the readme. You can also find other resources if you do a web search for "notion and zotero."
I hope this helps!


parameter(name=value) not being parsed

Hello,
I'm working on a legacy code and it seems that the following syntax for parameters isn't being considered:
parameter(name=value)

I would be happy to contribute to the project and fix this bug if you give me some hints.
Best regards

Hi @ehermann apologies for taking a while to get back to you. I will have a look at this now and see how easy it is to fix.

So we have no support for this type of AST node, we currently support the PARAMETER attribute

I will need to implement the PARAMETER statement see 8.6.11 in Fortran Standard 2018 draft


Added arrowline annotation tool

Implementation
This pull request adds the arrow line annotation tool to the viewer app. To implement this functionality, I used the SVG line shape and added an arrowhead to the end of this line. This was done using the marker-end attribute that can be added to the <line /> SVG shape. In the marker-end attribute the URL of an SVG marker definition needs to be given. So, we create an SVG marker definition for the arrowhead, add it to the SVG definitions - defs tag for the corresponding annotation SVG and reference the URL of the definition in the line's attribute.
Changes

Created arrowline.js to add the functionality of the new tool.
mview.html: Loading the arrowline.js script
base.js: Made changes to handle the marker-end attribute. It needs to be added only for the arrow line annotation type.
annotation-svg.js: Added the code to add marker definition to the annotation SVG, changing the colour of the arrowhead on stroke change, parsing the saved arrow line annotations correctly and creating the corresponding marker SVG definitions for matching the stroke colours of the loaded arrow lines.
annotation-group.js: Added the arrow line annotation type case.
annotation-tool.js: HTML code changes to render the arrow line option in the tool and other arrow line case changes.

Implementation Updates

Changed the way marker defs get added. Instead of the svg element, the marker definition now gets added to the g group tag for each group.
Previously, marker definitions would not get exported and saved along with the annotation SVG. That is now changed, the marker definitions get exported and saved. The SVGs should now work with other viewers if needed.
Changes are made to the way the saved annotations get loaded and the SVG nodes get parsed.

For now, disabled the code that shows different arrow styles. Only the solid arrow style should be visible. The PR does contain the multiple arrowhead style line code. The different arrowhead styles are disabled at the rendering level, for now, the HTML code is commented for now in annotation-tool.js.
Updated Code Changes

annotation-svg.js: Changed the parsing of SVG nodes to handle the def tag. Also, changes in the switch case while handling the parsing of SVG nodes when the element is a line with the data-subtype signifies an arrow line.
annotation-group.js: Added the arrow line annotation type case. Handled the adding of marker definition to the annotation group. Also, changes to handle the changing of the arrowhead colour on drawing stroke colour change.
annotation-tool.js: HTML code changes to render the arrow line option in the tool and other arrow line case changes.
Created arrowline.js to add the functionality of the new tool.
mview.html: Loading the arrowline.js script
base.js: Made changes to handle the marker-end attribute. It needs to be added only for the arrow line annotation type. Also, changes to the exporting of the SVG to handle exporting the required arrowhead marker definitions.

Please remove any code paths and commented code that will not be used. I didn't dig into your code, but I see some buggy behavior, and removing unused code could make debugging easier.
The weird behaviors that I saw:

Drawing line is throwing an error. The error happens in addMarkerDef where it's getting called without any subtype value. I'm assuming this function is supposed to be only for arrows, and that's why it's throwing an error.
I'm not sure how exactly to replicate this, but after drawing and saving. The second annotation started using the color of the previous drawing for the arrowhead. Changing the color didn't fix this and the arrowhead continued to be a different color from the rest of the group.

Fixed the issues described above. The bug was that SVG definitions get added to the same namespace as the document, so we needed unique marker ids for the marker definitions. Now, we are creating unique marker definitions for arrow line annotations.
The second issue regarding the marker definition function getting called was resolved by removing marker-end and data-markerid attributes from the default attribute list in the base.js file which added the attributes to all the annotations and which in turn resulted in the add marker def function getting called while saving the SVG.


Consider moving this repository to the https://github.com/dafny-lang organisation

I think it'll make it easier to manage permissions and find this repository. Also, this repository serves as the reference client for https://github.com/dafny-lang/dafny/tree/master/Source/DafnyLanguageServer so I think it makes since if they're somehow grouped together.
Some documentation for moving a repository: https://docs.github.com/en/github/administering-a-repository/managing-repository-settings/transferring-a-repository#transferring-a-repository-owned-by-your-organization

I'm sorry for the late reply. I'm currently on vacation and, therefore, slow to respond.
That sounds good to me, and I'll happily move it to the dafny-lang organization.

I'm sorry for the late reply.

No worries.
Btw, I really like the code quality of the DafnyLanguageServer package. Thanks a lot of for that big contribution!

Thank you very much. I'm glad that you're happy with the code quality. You might have noticed that I've but several TODOs for cleanup. They're usually because my goal was to have the least possible influence on the compiler's code. But since they're now in the same repository, it makes sense to clean these up.
I'll now proceed with the transfer to the dafny-lang organization.


Add ability to save input action from command line

Hi wanted to make an attempt at 12857.  This still needs work but I think the initial version is ready to be reviewed.
Summary of the Pull Request
Mostly copied from: https://github.com/microsoft/terminal/compare/6f5b9fb...1cde67ac466e19394eea1eb3a41405513d160a6f

Save to disk
If command line is empty use selection
Show toast
No UI.  Trying out the different options now.

References and Relevant Issues
https://github.com/microsoft/terminal/issues/12857
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
PR Checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[ ] Schema updated (if necessary)

More drive-by comments. We discussed possibly holding this from 1.20 (which is gonna be a smaller, more stablization-focused release), and then merge it in for 1.21.
Sorry that we've been slow here. Hopefully in a few weeks, we'll be able to better start moving code again 😄

Sounds good! No rush on my end.

Notes for team discussion later this week:

Overall, I think I'm fine with the ideas in this PR. Namely:

the wt save subcommand to save a commandline as a sendInput action (aka, a "task")
the saveTask action
the toasts

There are some annoying things that I think probably need to get done before we can ship this, and I'm volunteering to finish them in post. Namely:

[ ] wt save should default to the current window. I kinda did something similar here: https://github.com/microsoft/terminal/commit/a13e81d00be046c2ac5f6ae60c6c73b5780c0801#diff-dfd6c47961e6a1b340dcf4fcb82921004045b3269597521aeba822af41eb6e21R557-R561
[ ] The toast should use x:Uid's and resources for localizable strings. I can handle that.
[ ] The toast probably shouldn't display params that weren't filled. e.g. wt save foo shouldn only display

Task saved
commandline: Foo

But, this also lines up well with other work that's in progress (https://github.com/microsoft/terminal/issues/13445#issuecomment-1949389353), so I'd like to get this in and keep iterating.

Discussion feedback:

[ ] Stick behind velocity
[ ] change subcommand to x-save, ala MIME types to indicate "this subcommand is experimental"

I think the key chord parsing got broken with the upstream merge.   I think I can take a look tonight.

I think the key chord parsing got broken with the upstream merge. I think I can take a look tonight.

It looks like I had broken that here.  Should be fixed now.

Notes for team discussion later this week:

Overall, I think I'm fine with the ideas in this PR. Namely:

the wt save subcommand to save a commandline as a sendInput action (aka, a "task")
the saveTask action
the toasts

There are some annoying things that I think probably need to get done before we can ship this, and I'm volunteering to finish them in post. Namely:

[ ]  wt save should default to the current window. I kinda did something similar here: a13e81d#diff-dfd6c47961e6a1b340dcf4fcb82921004045b3269597521aeba822af41eb6e21R557-R561
[ ]  The toast should use x:Uid's and resources for localizable strings. I can handle that.
[ ]  The toast probably shouldn't display params that weren't filled. e.g. wt save foo shouldn only display

Task saved
commandline: Foo

But, this also lines up well with other work that's in progress (#13445 (comment)), so I'd like to get this in and keep iterating.

Is this along the line of what you were thinking for not displaying unfilled display params?  https://github.com/microsoft/terminal/pull/16513/commits/d4eaec37f01c6b0d483ff813b614d51f50e8a7ef
Wanted to try to address this one but wasn't sure what behavior was.  Is there a way that I can reproduce it?  "should default to _the current window"

Discussion feedback:

[ ]  Stick behind velocity
[ ]  change subcommand to x-save, ala MIME types to indicate "this subcommand is experimental"

for x-save.  is this along the lines of what you were thinking?  https://github.com/microsoft/terminal/pull/16513/commits/50baa7b48a7c320b032b475967f6574b07fcb03f
For #1,  what does velocity mean in this context?

Hey sorry about not replying earlier. I was... delayed... getting ready for Build.
BUT THAT'S DONE NOW. NOW IT'S TIME FOR FUN.
I'm just gonna quick leave this link here: dev/migrie/save-input-patches so that I don't lose it.
I was prototyping some other fixes that would make the XAML binding less painful. Admittedly, that branched off probably two or three months ago, so I'm sure it's stale.

for x-save. is this along the lines of what you were thinking? 50baa7b

Exactly that! That's perfect.

For the first, what does velocity mean in this context?

"Velocity" is our hodgepodge'd way of controlling which features go into which branches. It's pretty much all in features.xml. (you already figured this out in https://github.com/e82eric/terminal/commit/89a4e14661c747bafafaf40f98caf656634c2610). We just call it that still since that's what it's called in Windows internally.

I'm gonna start looping back on this now, cause this is a pretty important part of the story I think we can tell with #17329. Thanks for all the patience!

No worries!  I think I have the velocity flag added now and incorporated the changes from dev/migrie/save-input-patches.
I wasn't exactly sure how to handle the GenerateName so I just had it return blank when not enabled.


Escape button keeps the selected date

Pressing the escape button when the calendar is open should perhaps not act as if the user actually has selected a date, but instead leave the date empty?

It's not acting as if the user selected a date when I tried it. For me, pressing escape is cancelling the selection and keeping the previous value whether it was null or a date.
Can you reproduce the issue on the demo site, and provide steps to reproduce?


Fix: Your location button button is displayed on distance request thumbnail

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/43330
PROPOSAL: https://github.com/Expensify/App/issues/43330#issuecomment-2159490288
Tests

[x] Verify that no errors appear in the JS console

Navigate to a workspace chat
Make a distance request
Open the IOU report
Verify there shouldn't be 'Your location' button on the thumbnail

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/170341821/0eea532b-0b40-4ae2-a22b-a66f29eb96f0

Android: mWeb Chrome

https://github.com/Expensify/App/assets/170341821/d3e75ddc-74ea-4f00-99d6-ed2340f50b3a

iOS: Native

https://github.com/Expensify/App/assets/170341821/146b3b3b-96df-4780-b709-747bb31f6ab1

iOS: mWeb Safari

https://github.com/Expensify/App/assets/170341821/a9549f0f-e76e-460e-9890-47a4f76af76b

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/170341821/42648a7f-ef08-4989-a47e-ca53ce1cb074

MacOS: Desktop

https://github.com/Expensify/App/assets/170341821/915b5e97-59a3-4369-ae61-3cc763902c57

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/16502320/9bcf3b25-9347-4355-84c5-9bad42d1b154

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/16502320/fd5aad3b-5407-4ebb-88fe-984ba1c1a0df

iOS: mWeb Safari

https://github.com/Expensify/App/assets/16502320/b66fca41-bf0e-4cef-a75b-0479e42a5174

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16502320/80152d1d-3fc5-4e73-a62a-e85549dc218d

MacOS: Desktop

https://github.com/Expensify/App/assets/16502320/3ce8f45d-8641-4ec0-b801-7dc156d4c4c7

@truph01 We have conflicts here

Should be ready for your final review @mountiny

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.1-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[BUG] background-image property does not work with remote images

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
When using the background-image property on a box, it can render local files, but it does not render remote files. Does not work with either http or https. #719 has already reported this, however it got closed as "not planned" and it looks like it does not work for me as well. I noticed that when i select any remote file, the gtk+ style property is just url("data:image/png;base64,").
Reproducing the issue
(defwidget testwidget []
    (box :class "test"))

.test {
    background-image: url("https://i.scdn.co/image/ab67616d0000b273015c484a7aca592df1a77828");
    background-size: cover;
    min-height: 24px;
    min-width: 24px;
}

Expected behaviour
Should render the image like it does with local files

While this is being fixed, I thought I'd share my (probably obvious) hack to get this to work.
Note: I use the fish-shell and fish-scripts, but it should be trivial to translate them to bash and the likes:
~/config/scripts/audio-control.fish
set -l command $argv[1]
# other 'subcommands', etc.
if [ "$command" = "art" ]
  set -l art_thumb_cache "$HOME/.cache/music-thumbs"
  if not [ -d "$art_thumb_cache" ]
    mkdir -p "$art_thumb_cache"
  end
  set -l art_url (playerctl metadata mpris:artUrl)
  if string match -q "https://*" "$art_url"
    set -l art_name (basename "$art_url")
    set -l art_path "$art_thumb_cache/$art_name"
    if not [ -f "$art_path" ]
      curl -fLo "$art_path" "$art_url"
    end
    echo "$art_path"
  else
    echo "$art_url"
  end
end

and then:
~/config/eww/eww.yuck
(defpoll music_cover_art :interval "1s" "~/config/scripts/audio-control.fish art")

;; within the widget, where you want to use it:
(box :class "music-song-cover-art"
  :style "background-image: url(\"${music_cover_art}\");")

As I said this is a hack and it'd be great if this were supported out-of-the-box, but this hack comes with the additional benefit that you have manual control over the cache.
A smart scripter may be able to implement an LFU-cache )), I guess something along the lines of:
function cleanup
  set dir_path "$HOME/.cache/music-thumbs/"
  set file_list (find $dir_path -type f -printf "%A@ %p\n" | sort -rn | cut -d " " -f2-)
  set num_files_to_remove (math (count $file_list) - 64)

  if test $num_files_to_remove -gt 0
    for file in (seq $num_files_to_remove)
      set file_to_remove (echo $file_list[$file])
      rm $file_to_remove
    end
  end
end

Is this won't fix or are there any news?

Hi Chooms! I have the same problem. To solve it, I programmed this script in bash. In my case, I just want to get the image from Spotify, but you can modify it according to your needs.
What the script does is to get the URL of the image and cache it to display it as a local image. Also, to make sure that the image is always up to date, every time the script runs, it will delete all cached images, ensuring that no unnecessary images are saved.
#!/bin/bash

# Get the album art URL using playerctl
art_url=$(playerctl metadata --format '{{ (mpris:artUrl) }}' --player=spotify)

# Check if the art URL exists
if [ -n "$art_url" ]; then
    # Get the cache directory location
    cache_dir="$HOME/.album_art_cache"

    # Create the cache directory if it doesn't exist
    mkdir -p "$cache_dir"

    # Delete all images in the cache
    rm -f "$cache_dir"/*

    # Get the file name from the URL (last part of the URL)
    filename=$(basename "$art_url")

    # Create the full file path in the cache
    cache_path="$cache_dir/$filename"

    # Download the image
    wget -O "$cache_path" "$art_url" > /dev/null 2>&1

    # Display the path to the cached image
    echo "$cache_path"
else
    echo "Failed to get the album art URL."
fi

eww variable
(defpoll imgSong :interval "1s" "widgets/scripts/getImage.sh")

I reworked the scripts above a bit and created a better one. This uses XDG_RUNTIME_DIR to save on disk-writes, doesn't have any dependency on wget, checks if an image is actually a link and returns an already-downloaded image instead of downloading it again.
But most importantly it uses listening now instead of interval-based polling.
To add this, add the deflisten variable to your window and create a file containing the script. You can change the initial image to whatever you want, I left it blank.
(deflisten music-image :initial "" "bash ./location-to/your-script")

#!/usr/bin/env bash

playerctl metadata --format "{{mpris:artUrl}}" --follow | while IFS= read -r line; do
    if [[ $line == *"http"* ]]; then
        cache_dir="$XDG_RUNTIME_DIR/album_art_cache"
        mkdir -p "$cache_dir"
        file_name=$(basename "$line")
        file_path="$cache_dir/$file_name"

        # Check if file exists
        if [ -e "$file_path" ]; then
            # File exists, return path immediately
            echo "file://$file_path"
        else
            curl --output "$file_path" "$line" > /dev/null 2>&1
            echo "file://$file_path"
        fi
    else
        # artUrl doesn't have a link, nothing to do
        echo "$line"
    fi
done

I have discovered on my machine,  installing gnome in its entirety fixes it, installing gtk 2,3,4 on their own don't though. It'll be interesting to see if installing gnome fixes it for anyone else and hopefully someone can isolate what specifically does it, so you don't have to have gnome.

Please check if you have installed gdk-pixbuf2 and webkit2gtk

@githubber6800 Currently these are the shared libraries that eww uses, check that you have them installed using dpkg -l | grep -i <package-name>
libgdk-3.so.0
libpango-1.0.so.0
libgdk_pixbuf-2.0.so.0
libcairo-gobject.so.2
libcairo.so.2
libgobject-2.0.so.0
libglib-2.0.so.0
libdbusmenu-gtk3.so.4
libgtk-3.so.0
libgio-2.0.so.0
libgtk-layer-shell.so.0
libgcc_s.so.1
libm.so.6
libc.so.6
ld-linux-x86-64.so.2
Checked with readelf -d ./target/release/eww

install gvfs for remote urls in gtk css


linting fix for lt i18n file

This pull request includes a

[ x ] Bug fix

The following changes were made

just linting fixing of the lt translation file... now the grunt test finishes without problems.

Thanks!


Unable to map subdomain to SWA

I'm unable to map a subdomain to my SWA instance.
I'm trying to map forecasts.vladiliescu.net to my SWA, and as you can see below the Azure portal insists I map a CNAME to www (and not forecasts like one might expect). Adding a CNAME entry for forecasts will not work, and results in the following error: CNAME Record is invalid. Please ensure the CNAME record has been created.
The expected behavior is to be able to map any subdomain to a SWA, not just WWW.

Hi @vladiliescu,
Thanks for calling this out. The Portal UX is incorrect here. To add your custom domain, you want to create a CNAME like forecasts.vladiliescu.net -> delightful-coast-....azurestaticapps.net
We will work on fixing this experience.

Hi @miwebst, exactly, that's what I had expected. However, adding a CNAME entry for forecasts doesn't work, I'm assuming it's because it still checks for www.

It shouldn't check for www. The validation is checking the existence of the CNAME. From what I see here, it appears that the CNAME has not been set?
https://www.digwebinterface.com/?hostnames=forecasts.vladiliescu.net&type=&ns=resolver&useresolver=<IP_ADDRESS>&nameservers=

Not sure how to interpret the output of digwebinterface, however looking at the output, I see what appears to be Azure IPs right? I'm using Cloudflare for DNS, and I get the same IPs whether I choose to have the entry proxied by CF or not.

If I remove my CNAME from Cloudflare I get a different output, as seen below.

All this, coupled with the error message I'm getting for https://forecasts.vladiliescu.net makes it look like Azure is not correctly configured.

Ah, they're not Azure IPs right, they're Cloudflare IPs I guess.
Then, I guess this means I can't use custom domains for SWA unless I don't proxy traffic through CF? Feels weird, to be honest.
Note that with CF proxying disabled, at every two refreshes of digwebinterface I get this output.

This is all about proving domain ownership. You can switch back to CF once you've proved ownership and added the custom domain on our side.
We are also working on adding TXT record validation which would be another avenue for verifying domain ownership when using a CDN in front of a SWA. @anthonychu as fyi

Thanks, I'll wait for TXT record validation to be added then.

I can confirm that validation doesn't allow anything except www for me as well...

Same Problem ...

Hi. That's interesting, as now I was able to add non-www subdomain through portal. I can say that I had completely different UI the last time I've checked. Feels like there is some kind of A/B testing going on. Good to know that things are moving forward.

Hi. That's interesting, as now I was able to add non-www subdomain through portal. I can say that I had completely different UI the last time I've checked. Feels like there is some kind of A/B testing going on. Good to know that things are moving forward.

So that means I am another deployment ring or B 🥲 still the same ui ... can only setup www, which I dont want to do, as it is used by a produvtion website

There's currently a bug in the portal UI that we're going to fix. It says the subdomain must be www, but in fact it can be any subdomain. We do not block non-www subdomains. There's no A/B testing going on here.

Both types of domains are now supported: https://docs.microsoft.com/en-us/azure/static-web-apps/custom-domain?tabs=azure-dns

This is also currently happening to me as per the post above, however, unlike the post above this one, it still is not working for me. I am going to go ahead and sleep on it. I hope its just some type of DNS propagation issues happening.


DL+ occupies too much space

When you use the program in full screen mode

and you open the arrow in order to show the DL+ information, this occupies too much (empty) space - in my opinion - and the SLS picture gets much smaller than necessary.

closed due to new layout


[5.4] Revert breaking change

https://github.com/laravel/framework/pull/20321 silently breaks packages that extend the BelongsToMany relationship class in a minor release!
Like laravel-mongodb:
https://github.com/jenssegers/laravel-mongodb/blob/master/src/Jenssegers/Mongodb/Relations/BelongsToMany.php#L94
Or the couchbase driver:
https://github.com/ORT-Interactive-GmbH/laravel-couchbase/blob/42a2fd6fcaa53a614900945ecf7895e1ac67ee23/src/Mpociot/Couchbase/Relations/BelongsToMany.php#L117

Original breaking change report from @mpociot in https://github.com/laravel/framework/pull/20321#issuecomment-319918377

Can we re-do this on master maybe?

@taylorotwell yes on it

So glad someone else found this before me :)


Add Dynamic Song Additons

Allow for the user to add a song to the config after Amplitude has been initialized.

Amplitude.playNow doesn't solve this problem?


Too strict assumption on body schema location

This code in open-api3.js
  const requestPath = `paths[${currentPath}][${currentMethod}].requestBody.content[${contentType}].schema`;
  const dereferencedBodySchema = get(dereferenced, requestPath);
  const referencedBodySchema = get(referenced, requestPath);

assumes that request body content definition is always given inline within Operation Object's requestBody field (since it is expected to be found in referenced schema), while by OpenAPI 3 definition there can be a reference as well.
For example:
/path:
  post:
    requestBody:
      $ref: '#/components/requestBodies/Body'

components:
  requestBodies:
    Body:
      required: true
      content:
        'application/json':
          schema:
            $ref: '#/components/schemas/BodySchema'

For such schema body validation set is empty. Please correct this.

Thanks, version 1.2.2 fixes this.
(I checked with response body validation only, but since the code is same I assume it would also work in the above mentioned request body case as well)

@sergburn , can we close this?

Yes, thanks again for fixing it!


Symlinks are writeable

Issue description
Seeing a weird problem on my machine.
Looks like the symlinks are writeable by my user however the actual store contents is only readable.
 ls -l ~/.zshrc
lrwxrwxrwx 1 fmzakari primarygroup 69 Jun  6 15:23 /home/fmzakari/.zshrc -> /nix/store/mqn789lgj79fvhdahgabshs2093qi5b5-home-manager-files/.zshrc

ls -l /nix/store/mqn789lgj79fvhdahgabshs2093qi5b5-home-manager-files/.zshrc
lrwxrwxrwx 1 fmzakari primarygroup 53 Dec 31  1969 /nix/store/mqn789lgj79fvhdahgabshs2093qi5b5-home-manager-files/.zshrc -> /nix/store/sdx1f2sxvdy5nbc9s22a3nmpa8aryf8q-hm_.zshrc

ls -l /nix/store/sdx1f2sxvdy5nbc9s22a3nmpa8aryf8q-hm_.zshrc
-r--r--r-- 1 fmzakari primarygroup 2998 Dec 31  1969 /nix/store/sdx1f2sxvdy5nbc9s22a3nmpa8aryf8q-hm_.zshrc

I'm also told that the owned user shouldn't be my user.

My home-manager setup is at https://github.com/fzakaria/nix-home
My workflow is:

Git clone the directory (anywhere)
home-manager switch --file ./home.nix

Machine
Debian based distro
(#1 SMP Debian 5.5.17-1rodete4 (2020-05-08 > 2018))
PS: I find that much simpler than putting it in ~/.config/nix

That's how symlinks work:
$ ls -la
total 8
drwxr-xr-x  1 peter users   20 Jun  7 13:22 .
drwx------+ 1 peter users 2004 Jun  7 13:22 ..
lrwxrwxrwx  1 peter users    7 Jun  7 13:22 foo -> woot.md
-rw-------  1 peter users   29 Jun  7 13:22 woot.md


fix activitybar icon focus style

This PR fixes #18587
Notebook and Connections view container are contributed with sql theme icon which are not actually codicons, as a result the focus highlighting does work for them.
just like the other css styles in these 2 files, I am adding a special selector for them to handle it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 42.202%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
27754

Relevant Lines:
61529

💛  - Coveralls

added before and after gifs.


Do not fail in update.py if a product cannot be loaded

Such errors prevent the script to run.

Example of such error: https://github.com/endoflife-date/release-data/actions/runs/10012716505


fix: AvaloniaUI/Avalonia#12974 - Preview not showed when using using statment

Current behavior
SreTypeSystem find only public types
Expected behavior
SreTypeSystem find only public and internal types
part of https://github.com/AvaloniaUI/Avalonia/issues/12974

Do I need to make other changes?


Optimization of hex_format_byte

Optimization of hex_format_byte based on measurements https://play.rust-lang.org/?version=stable&mode=release&edition=2021&gist=41af1f10ac071c3a434eb8aaa6e8a546

#53

@bugsweeper can you run Run cargo +nightly fmt --all?
https://github.com/TheBestTvarynka/crypto-helper/actions/runs/8221629462/job/22484036145?pr=62#step:5:1


Unexpected behavior with ending symbols

Hi again,
I found that count-occurrences have an unexpected behavior if you  want to count last symbols in sequence. Here are the examples:

sequence "aaabbb", query "b": expect 3, but output is Number of times present: 2
another one is when sequence "aaabbb", query "bb": expected 2, but actual output is Number of times present: 0

Can you fix this? Thanks!

Thanks for catching this. It should be good now with 0008e616acfb1cdee33d036cf426642050b9a74d, I had previously unintentionally ignored the last N bytes for a file of length for queries of length N. This was a bug in the old code (it should have only ignored the last N-1 bytes) but now as part of the fix for #14 I don't need any length cap.

I think you forgot to fix same workaround upper in line 286. When I patched it, all started to work well.


FAQ switzerland

TODO
Ensure alignment of the FAQ to the Privacy notice section 7. "How does the transnational warning system work?"
"In order to also enable warnings between users of the Swiss coronavirus app and the Corona-Warn-App, the RKI also operates another exchange server together with Switzerland (Federal Office of Public Health of the Swiss Confederation)."

Link back to https://github.com/corona-warn-app/cwa-website/issues/1060.


Index for getAccountTransactions

Just adding support for firstIndex/lastIndex on getAccountTransactions.

Already merged on another PR.


Hook in to droppable options

Hey, thanks for this great library!
Is it possible to add my own configuration to the droppable plugin? I would like to specify my own callback to the drop options for example to handle some transformations to my data model. (Im using Angular) I saw in 3.0 there is a possibility to exchange the dnd library used, does this also provide custom callbacks?
Kind Regards Frank

Hey Frank! Are you just looking to pass in certain options, or are you also trying to use a different plugin? There's options for both, but let me know and I will do my best to assist you.

Hey, im looking to pass in my own callbacks for over and drop! Really appreciate your help!

@frankadrian I think we could consider triggering events that you could hook into. I'll keep you posted.

@frankadrian Now that added is emitted when a widget is moved from one grid to another, is your problem solved?

Closing because the enhancement added hopefully voids this request. Please reopen if I'm incorrect. Thanks!


Fix for new Machine, update documentation

https://github.com/sillsdev/serval/issues/356

This change is

src/Serval.Translation/Services/PretranslationService.cs line 73 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I think we want to consider turning off strictComparison when we update the target book. This will allow us to update non-Scripture segments even if the structure doesn't match exactly.

Done.

We did - check out the production swagger and see if you like it.

@johnml1135  You never committed fixes for my requested changes.


Use stubs from Opal GEMs when MRI requires/Rail/Bundler is used

Also try and make Bundler detection more reliable with RUBYOPT

Implements https://github.com/cj/opal-webpack/issues/24 - @cj  - want to have a look?

@wied03 not to sure about this webpack is run with the RAILS_ENV environment variable set all our apps and people that don't use rails use RACK_ENV.

@cj - That's not new with this PR. Logic was already there for that and was moved from getLoadPaths and it only kicks in if RAILS_ENV is set (which is not mandatory of course).

@cj - Also, if someone is using RACK_ENV, there is no special behavior needed by the loader here. The loader only uses RAILS_ENV as a way to see if someone is using Rails and get asset paths from Sprockets (e.g. app/assets/javascripts, not just Opal).
If someone had a Rack based app like Sinatra, they would still get the benefit of Bundler integration by running all of this with bundle, in which case the else in the code below would fire:
if (useBundler) {
    if (env.RAILS_ENV) {
      // using rails runner to try and take advantage of spring
      return bundlerExecute(`rails runner "${rubyCode}"`)
    }
    else {
      return bundlerExecute(`ruby -e "Bundler.require; ${rubyCode}"`)
    }
  }

The only thing that's missing related to this that I know of is Sprockets based paths for someone not using Rails. In that case, like Sinatra, this would only fetch load paths that GEMs have added using Opal.append_path. I can't imagine many people would use Sprockets but not Rails.
As discussed above though, this isn't new with this PR.

Yes, this makes perfect sense.  Feel free to update the package.json version and merge it in.


Update specs2-core, specs2-junit to 4.8.2

Updates

org.specs2:specs2-core
org.specs2:specs2-junit

from 4.8.1 to 4.8.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2" } ]

labels: test-library-update, semver-patch

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          57     57
  Branches        3      2    -1
=====================================
  Hits           57     57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed292d5...5015517. Read the comment docs.


Add Documentation - How to use

How is this used? I tried the following:

I cloned the git repo and then filled in all example files.
I then copied them to remove the example- part. I then ran ./wp-ms-init.sh.
That did bring up the containers but if I visit the site I only get a redirect to this:

http://dev.example.com/wp-signup.php?new=dev.example.com:8080

but the browser is unable to connect.
Thank you.

Sorry, I created this for projects I personally manage, so didn't put in time in documenting.
Will do in the coming days.
As to the issue, It seems you set the URL envvar to http://dev.example.com while the actual URL you are accessing is http://dev.example.com:8080, I am used to routing these thing via a local nginx, so I didn't think about it, will try to fix this.
As a workaround for now, you can run this: docker-compose --rm run cli wp option set siteurl http://dev.example.com:8080.


fix Dockerfile to actually start server

If you run the docker image built with current Dockerfile, container simply outputs the output of flowise command to its log and exit. This is due to CMD in Dockerfile just points flowise instead of flowise start which actually starts the server. Simple update on Dockerfile to make it actually start the server.

make sure you have the bin/dev and bin/run files to have LF and not CRLF:


Fix appengine deployment

This fixes the compatiblity with GAE's 2nd-gen runtime, in which special
libraries are no longer required.
This was a 3-step change:

update app.yaml to use a 2nd-gen runtime
adopt go modules
update server code to use the standard-library instead of
appengine-specialized library (this is actually optional, but doing that
makes it easier to run the service locally)

Thanks for the PR. I made two simple additional fixes to app.yaml, but I had to abandon the deploy when I got this message:
Beginning deployment of service [default]...
╔════════════════════════════════════════════════════════════╗
╠═ Uploading 1 file to Google Cloud Storage                 ═╣
╚════════════════════════════════════════════════════════════╝
File upload done.
Updating service [default]...failed.
ERROR: (gcloud.app.deploy) Error Response: [7] Access Not Configured.
Cloud Build has not been used in project runefinder2018 before or it is disabled.
Enable it by visiting https://console.developers.google.com/apis/api/cloudbuild.googleapis.com/overview?project=runefinder2018 then retry.
If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

And then I found that to enable Cloud Build I had to create a link a billing account... right now I don't have time to investigate what I could be billed for. So sorry, no deploy until I can come back here, hopefully in early 2021.
Merry Christmas and a Happy New Year!

@ramalho ugh I didn't realize they make it so bureaucratic now lol I'll continue to use the command  line version! :D


How to use SVGs URIs as symbols?

I would like to to about 20 different SVGs as symbols. How can this be done?

Hi Kevin,
Officially Mapbox doesn't accept SVG's as Images for Markers. See here and here.
The workaround is to convert the SVG image to ImageData which can be used in WebGL.
I included this conversion in the latest update, so you don't have to do it.
Here an example on how to use it.
If the SVG is small you can see jagged edges when its rasterised/converted.
A workaround for this is to create a larger SVG and then scale it down in the Layer component with:
style={{ 'icon-size': 0.5 }}
Let me know if this fixed your issue.

Thank you so much for the quick reply. It means a lot to me. Understood. Let me go and digest your example and see if I can put it to use!

This seems to work! Fantastic.
Now how can I access the item's properties from the Layer so that I can pass a type in that will help lookup a specific Image to be used?

In the example you can see in the beginning I assign a feature property image of the random points which determine what image to use for the symbol (img_0 - img_9).
Later I load all the SVG's assignig them the same id's (img_0 - img_9).
In the layer style -> layout section I assign the icon image to the feature property image .using the get expression.
I hope that clears it up.

Is there any way to get the value dynamically and pass it to something in the Layout section?

Hi Kevin,
As far a I know, you can't access feature properties in the rendering process. It has to be defined before via the layout and paint properties. Dynamic rendering is done via style expressions.
If you find a different way in the Mapbox API, I'm happy to include it.

@KaiHuebner I see, darn!


FEAT: Document Groups for Enhanced Access Control

Is your feature request related to a problem? Please describe.
Our chat tool is used by various clients, and currently, there is no way to restrict access to confidential documents between different clients. However, documents within a company should be accessible to all employees of that company. This lack of access control can lead to potential security issues and unauthorized access to sensitive information.
Describe the solution you’d like
I propose the implementation of “Document Groups” within the Workspace area. This would involve adding a new tab for Document Groups, where each group can have a list of documents and collections, as well as a list of users assigned to it. This feature should function similarly to the existing “Models” feature. If a user with the “User” role is not assigned to any Document Group, they should not be able to select any documents in the chat. A user can also be assigned to multiple Document Groups, in which case they would have access to the union of all documents within those groups.
Describe alternatives you’ve considered
An alternative solution could be to implement individual document permissions, where each document’s access is controlled on a per-user basis. However, this approach could become cumbersome to manage, especially for larger teams or companies with a significant number of documents.
I am willing to implement this feature and would like to gather feedback from the developers to ensure it aligns with the overall vision and architecture of the tool.

#2924


Document application compatability with Windows upgrade pathway

https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions

Windows XP → Window 11


Crash in flutter_windows.dll tonic

Steps to reproduce
Unable to reproduce
Expected results
Not Crash
Actual results
There was a crash once.
Code sample
no Code sample
Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
flutter_windows.dll!std::_Atomic_storage<bool,1>::load() line 755 C++
flutter_windows.dll!std::atomic<bool>::operator bool() line 2406 C++
flutter_windows.dll!tonic::DartState::IsShuttingDown() line 74 C++
flutter_windows.dll!tonic::DartWeakPersistentValue::Get() line 63 C++
flutter_windows.dll!tonic::DartWrappable::ClearDartWrapper() line 69 C++

Flutter Doctor output
Flutter (Channel [user-branch], 3.19.5, on Microsoft Windows [版本 10.0.19044.2728], locale zh-CN)
    ! Flutter version 3.19.5 on channel [user-branch] at C:\Users\y-chen\Desktop\code\flutter\flutter_sdk
      Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
      If that doesn't fix the issue, reinstall Flutter by following instructions at
      https://flutter.dev/docs/get-started/install.
    ! Upstream repository unknown source is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to unknown source to dismiss this error.
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.3)
[√] Android Studio (version 2024.1)
[√] VS Code (version 1.84.2)
[√] Connected device (4 available)

Hi @DongXuanLei, you are using an older version of the flutter framework. Please upgrade to the latest version of flutter stable to see if you still experience this issue. If you do, please provide the updated output of flutter doctor -v. We will also need to know what you were doing at the time along with a code sample so that we can properly investigate this issue.
Thank you


UI breaking in Production build

I'm submitting a...

[X] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

When I am running production build by executing the command npm run build  production build UI is breaking.
Expected behavior

Project UI should be the same as the development build in the production build.
Minimal reproduction of the problem with instructions

Environment
- generator version: 5.0.1
- node version: 10.9.0  <!-- run `node --version` -->
- npm version: 6.2.0  <!-- run `npm --version` -->
- OS: Mac

Others:
I am running a production build using http-server package.

can you post the content of your .yo-rc.json file and the result of ngx ng --version ?
I discovered an issue with latest Angular CLI version and production builds with Ionic 3, might be related :/

.yo-rc.json
{   "generator-ngx-rocket": {     "version": "5.0.1",     "props": {       "location": "path",       "appName": "appName",       "target": [         "web"       ],       "pwa": false,       "ui": "material",       "layout": "simple",       "auth": false,       "lazy": false,       "angulartics": false,       "projectName": "leaflet-map",       "packageManager": "npm",       "mobile": []     }   } }
and attached ngx ng --version

Thanks! Can you also post the error message you have during your production build?
It's often related to AOT, so seeing the message can help.

@sinedied I am not getting any error. It runs successfully.

<EMAIL_ADDRESS>build /Users/dhavalsoni/app-name
npm run env -s && ng build --prod

Date: 2018-09-07T09:11:12.615Z
Hash: b8c5a91097f34b479bd9
Time: 58035ms
chunk {0} runtime.a66f828dca56eeb90e02.js (runtime) 1.05 kB [entry] [rendered]
chunk {1} styles.859b5130a820599b6972.css (styles) 57.7 kB [initial] [rendered]
chunk {2} polyfills.250ef2a4b02c50c382fe.js (polyfills) 59.6 kB [initial] [rendered]
chunk {3} main.33dd3882d1f77e21013f.js (main) 1.22 MB [initial] [rendered]

So what's the issue actually, is it a visual issue? In that case could you post screenshot of dev/prod build that shows the difference?
If it's a runtime error, can you post the error and stacktrace shown in the dev console?

@sinedied Please check below screenshot:
Dev:

Prod:

Seems related to the preserveWhiteSpaces option of the angular compiler, you might try changing the value in src/tsconfig.app.json to:
  "angularCompilerOptions": {
    "preserveWhitespaces": true
  }

This option should behave the same in dev & prod, but these days the Angular CLI is full of bugs 😞

@sinedied It's already true :
{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/app",
    "baseUrl": "./",
    "module": "es2015",
    "types": []
  },
  "exclude": [
    "test.ts",
    "**/*.spec.ts",
    "**/*.mock.ts"
  ],
  "angularCompilerOptions": {
    "preserveWhitespaces": true
  }
}

@sinedied  Yes it's working pretty good and some of the UI issue fixed, however, there were still some CSS issues and I overwrite it.

@dhavalsoni2001 I'm assuming we can close the issue then?

@bursauxa Yes. As @sinedied  mentioned that it's angular-CLI issue.


List and dictionary dependencies not properly tracked on tensorflow backend

On the tensorflow backend our Layer is a tf AutoTrackable, which allows tf.save_model and tf.train.Checkpoint to work by tracking all sublayers, variables, etc.
However keras-core Tracker and AutoTrackable conflict for dictionaries and lists. Our Tracker creates specialized list and dict subclasses, which tensorflow refuses to track with AutoTrackable. AutoTrackable will only track children if type(child) == list or type(child) == dict.
The net effect is tf.save_model and tf.train.Checkpoint will not work for layers with list/dictionary sublayers or weights. Here's a repro.
https://colab.research.google.com/gist/mattdangerw/be42f510562906925985e2954db9c8e8/tf-saving-bug.ipynb

Hot take on this, having two systems for tracking seems like a recipe for annoying bugs and edge cases.
There is a lot of strangeness going on. For example, we turn off Keras auto tracking for functional tracing, which happens to turn off our list wrapping, which is the only reason functional models are traced properly with tf today (lucky!). But if you inspect a tf checkpoint, our variables show up named like root._operations.5.kernel because we are tracking with tf the part we did not want to track with Keras.
If we could instead use the keras-core Tracker to explicitly track the things we care about with tensorflow that seems a lot less fragile. We would have one tracking mechanism across all our backends, no surprising behavior when hopping around. Tried poking around a bit, and this seems possible, though it might be a bit of work.


winget update --all does not automatically update packages

Brief description of your issue
Until recently, running winget update --all or winget upgrade --all would (barring a couple of exceptions), download any relevant packages and update them automatically. However, recently (maybe for a couple of weeks), it just displays the available updates and just exits.
Steps to reproduce
Run: winget update --all
Expected behavior
Except to see a list of available candidates followed by downloading the installers and updating the relevant applications.
Actual behavior
Only printing out the list of available updates and does nothing after.
Environment
Windows: Windows.Desktop v10.0.22631.3155
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.22.10582.0

Try using the pre-release version v1.7.10661. This is a known issue in v1.7.10582. If you still run into problems, you can report in the tracking issue here https://github.com/microsoft/winget-cli/issues/4219
Duplicate of https://github.com/microsoft/winget-cli/issues/4219


Update Release Team for 1.7

After the Release Team being officially formed (see #kubeflow/community/issues/571). We need to update the acls with the new members and new roles.
Tagging all members in case I missed something:
@anencore94 @annajung @bradleykcardwell @chalesa101 @DnPlas @jbottum @kimwnasptd @shivaylamba @surajkota @Rishit-dagli @yubozhao

@chensun @james-jwu
This PR has been open for quite some time, it is failing due to these PRs not being merged yet:
#579 #578
Can we address this? We will need some of these permissions to cut the 1.7 release.

@chensun @james-jwu
This PR has been open for quite some time, it is failing due to these PRs not being merged yet: #579 #578
Can we address this? We will need some of these permissions to cut the 1.7 release.

I see neither PR follows the guideline documented here: https://github.com/kubeflow/internal-acls#joining-kubeflow-github-organization
Did they ever contributed to Kubeflow before? If not, what qualifies them to join the release team, and who sponsors them?

@chensun @james-jwu
This PR has been open for quite some time, it is failing due to these PRs not being merged yet: #579 #578
Can we address this? We will need some of these permissions to cut the 1.7 release.

I see neither PR follows the guideline documented here: https://github.com/kubeflow/internal-acls#joining-kubeflow-github-organization Did they ever contributed to Kubeflow before? If not, what qualifies them to join the release team, and who sponsors them?

Thanks for clarifying @chensun I can vouch for @yubozhao (#579). He is part of the BentoML team who are contributing an integration with Kubeflow and their product (see this pr). He has also been very active in the Release Team joining all the meetings.

@chensun I have removed the members who are still not in the org as we need to start cutting the release in 2 days. Can this be reviewed now?

Hey, @chensun it seems like I still don't have permission. Are there any further steps required?

Hey, @chensun it seems like I still don't have permission. Are there any further steps required?

Sync is broken, I'll try investigating the issue today.

Thank you @chensun for looking into this!

@chensun Could you create a v1.7-branch in the kubeflow/kubeflow repository? Not being able to creat this branch is currently blocking us.

@DomFleischmann Created https://github.com/kubeflow/kubeflow/tree/v1.7-branch
I looked into the sync issue yesterday, but haven't found a solution yet. I'll post details in the issue and keep digging into it.

@theadactyl @james-jwu @chensun is there an update on this issue.   We are trying to move the 1.7 RC forward and I understand this is a blocking issue.

@jbottum I created the branch requested, and I think release team should have been temporarily unblocked? Let me know if there's any other action you may help due to permission issues.
Meanwhile, I'm still looking into the broken sync issue, I'll update progress on #587.

@chensun thank you @DomFleischmann are you unblocked ?


Limited the number of connections records to 1 per display per day

@olegrise please review.
This is to limit cost impact (as Byron wants to see a 1-year charts instead of 60-day charts).

:+1:


Github action "oxide_fmax_fresh_build" is failing

https://github.com/google/CFU-Playground/actions/workflows/fmax-trials-fresh-build.yml
Error is
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/n/nvidia-settings/libxnvctrl0_470.57.01-0ubuntu<IP_ADDRESS>_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]

This error has repeated multiple times so it doesn't seem to be a transient error.

In the last couple of days, the GHA VMs must have been updated so that the issue no longer occurs.    We should still merge #482 to prevent transient issues like this in the future.


Can't resolve account.cmore.se

I can't resolve the hostname from my desktop either.
2020-08-17 17:52:49.550 T:2354295664   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'requests.exceptions.ConnectionError'>
Error Contents: HTTPSConnectionPool(host='account.cmore.se', port=443): Max retries exceeded with url: /session?client=cmore-android&legacy=true (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x99518a70>: Failed to establish a new connection: [Errno -2] Name or service not known',))
Traceback (most recent call last):
File "/storage/.kodi/addons/plugin.video.cmore/default.py", line 5, in
addon.run()
File "/storage/.kodi/addons/plugin.video.cmore/addon.py", line 14, in run
router(sys.argv[2][1:])  # trim the leading '?' from the plugin call paramstring
File "/storage/.kodi/addons/plugin.video.cmore/addon.py", line 398, in router
if helper.check_for_prerequisites():
File "/storage/.kodi/addons/plugin.video.cmore/resources/lib/kodihelper.py", line 88, in check_for_prerequisites
if self.set_locale(self.get_setting('locale')) and self.set_login_credentials() and self.check_for_credentials():
File "/storage/.kodi/addons/plugin.video.cmore/resources/lib/kodihelper.py", line 118, in check_for_credentials
self.login_process()
File "/storage/.kodi/addons/plugin.video.cmore/resources/lib/kodihelper.py", line 125, in login_process
self.c.login(username, password, operator)
File "/storage/.kodi/addons/plugin.video.cmore/resources/lib/cmore.py", line 182, in login
credentials = self.make_request(url, method, params=params, payload=payload)
File "/storage/.kodi/addons/plugin.video.cmore/resources/lib/cmore.py", line 70, in make_request
req = self.http_session.post(url, params=params, data=payload, headers=headers)
File "/storage/.kodi/addons/script.module.requests/lib/requests/sessions.py", line 581, in post
return self.request('POST', url, data=data, json=json, **kwargs)
File "/storage/.kodi/addons/script.module.requests/lib/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/storage/.kodi/addons/script.module.requests/lib/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/storage/.kodi/addons/script.module.requests/lib/requests/adapters.py", line 516, in send
raise ConnectionError(e, request=request)
ConnectionError: HTTPSConnectionPool(host='account.cmore.se', port=443): Max retries exceeded with url: /session?client=cmore-android&legacy=true (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x99518a70>: Failed to establish a new connection: [Errno -2] Name or service not known',))
-->End of Python script error report<--
2020-08-17 17:52:49.657 T:2300552048   ERROR: GetDirectory - Error getting plugin://plugin.video.cmore/
2020-08-17 17:52:49.663 T:3011272720   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.cmore/) failed

i also have the same issue

I do believe this has been fixed in the latest version on git. The Kodi repository version is not up to date and I can't push out a new version until python3 support has been sorted.
Try installing https://github.com/emilsvennesson/kodi-cmore/archive/master.zip.

Instal link didn't work, should it be still valid?


Add builds for macOS and Linux (ubuntu package?)

Hi. I am not sure if this is what you are asking for, but we have automated TeamCity builds for Windows, Linux, and macOS. No .deb packages or repository for Ubuntu though.

Would be good to include those builds in the release page https://github.com/avast-tl/retdec/releases

also i need login to access this teamcity thing, is there any public place to download the mac/linux builds?

Would be good to include those builds in the release page https://github.com/avast-tl/retdec/releases

@PeterMatula What do you think about this? Could we download and add stable builds (e.g. for v3.3) there?

also i need login to access this teamcity thing, is there any public place to download the mac/linux builds?

You can just click on Log in as guest. Nevertheless, in commit 0d4f9a01439860ba2fd9c008599f4d7a2bfcb646, I have added ?guest=1 at the end of the URLs in README, so it should allow you to download them directly, without a need of logging in. So, just open this page now and you should be good to go ;-).

thanks!
On Fri, 22 Mar 2019 at 12:13, Petr Zemek<EMAIL_ADDRESS>wrote:

Would be good to include those builds in the release page
https://github.com/avast-tl/retdec/releases
@PeterMatula https://github.com/PeterMatula What do you think about
this? Could we download and add stable builds (e.g. for v3.3) there?
also i need login to access this teamcity thing, is there any public place
to download the mac/linux builds?
You can just click on Log in as guest. Nevertheless, in commit 0d4f9a0
https://github.com/avast-tl/retdec/commit/0d4f9a01439860ba2fd9c008599f4d7a2bfcb646,
I have added ?guest=1 at the end of the URLs in README, so it should
allow you to download them directly, without a need of logging in. So, just
open this page
https://github.com/avast-tl/retdec#automated-teamcity-builds now and
you should be good to go ;-).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/avast-tl/retdec/issues/526#issuecomment-475580993,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3-lt9IsQocpWGC_OAB9RDEChkIwqppks5vZLrCgaJpZM4cDSRZ
.

--
--pancake

@s3rvac There already are 2 builds win32-release and win64-release that could be used in this way. In fact, when creating a release, I just took artifact from these builds and added them to the release. It would be no problem to create the same build configs for Linux/macOS, but we need to discuss it further - there are reasons we did not do it so far.

We will add a macOS release package.
We will explore a possibility to build various Linux packages in our TeamCity via docker. We are not to keen on officially releasing the current CentOS build as an all-Linux package - it could cause a storm of incompatibility-related issues.

thanks!

On 25 Mar 2019, at 14:47, Peter Matula<EMAIL_ADDRESS>wrote:
We will add a macOS release package.
We will explore a possibility to build various Linux packages in our TeamCity via docker. We are not to keen on officially releasing the current CentOS build as an all-Linux package - it could cause a storm of incompatibility-related issues.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/avast-tl/retdec/issues/526#issuecomment-476204424, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lvj-32e_u00SrsiAKy4zLe3spUlHks5vaNOKgaJpZM4cDSRZ.

Added builds for macOS and Ubuntu, Debian, and Fedora - always for the latest stable distro release at the time of building RetDec.

Awesome thanks!! I will finish the r2pm package as soon as i can

On 30 Apr 2019, at 16:39, Peter Matula<EMAIL_ADDRESS>wrote:
Added builds for macOS and Ubuntu, Debian, and Fedora - always for the latest stable distro release at the time of building RetDec.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


New version: Google.AndroidStudio version 2<IP_ADDRESS>

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Will pass validation after index publish of:

#171632

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


fixes the bug that shifted recent projects to the right on a member page

fixes #670

Just tested on my local dev but I don't have sufficient number of projects loaded up to truly test, so I'm going to accept the PR (which will auto-deploy code to makeabilitylab-test). We can evaluate there.
In the future, when working on something that affects the visual design, can you show before and after shots on both laptop and mobile?
Thanks @htadeusiak!


Set 'B' of Beginner Skills reference topics

Initial set of reference topics to the beginner "Skills" reference set.

[x] Relocate skills reference to a new "skills" folder to preserve the sanctity of the reference tree.
[x] Add a 'Customizing dialogs" topic
[x] Add a 'Countdown timer' topic
[x] Add a 'Keeping score' topic
[x] Add a 'Using text' topic

@kiki-lee - Not sure if this is the style your looking for but I have an initial 4 topics proposed here.


add support for FILE_SET HEADERS

to support new CMake feature for interface-libraries
this would fix #32

The use case is that a header only project may check that every header is self contented and compiles.
see https://discourse.cmake.org/t/verifying-header-sets-not-supported-for-header-only-interface-libraries/6139/8

So if I understand correctly from the docs, the advantage is that we don't need to specify the include destination explicitly but can now use the BASE_DIRS flag in the library definition? How about adding a test that relies on this feature?

So if I understand correctly from the docs, the advantage is that we don't need to specify the include destination explicitly but can now use the BASE_DIRS flag in the library definition? How about adding a test that relies on this feature?

No, the main advantages are

for an interface library you may check, that every header is self-contained
you may also check them with run-clang-tidy without writing tests.

see too https://github.com/aminya/project_options/issues/143

I still don't really understand the feature then, do you think you could add an independent test case that would fail with the current version, but pass using the suggested changes?

I still don't really understand the feature then, do you think you could add an independent test case that would fail with the current version, but pass using the suggested changes?

I push a version with is not usable with CMake v3.24.2 (pip install cmake)

@TheLartians my you think about this MR again?

@TheLartians Q: Is the project not maintained anymore?

Hey @ClausKlein I apologise for not being able to respond so far. I'm still planning to maintain this project, however I don't have any experience with FILE_SET HEADERS and don't yet understand what problem it solves. From a quick look at the readme it allows omitting the target_include_directories?
As before it would be great if you could avoid changing the test behaviour based on the CMake version. You can assume that tests will be performed with CMake > 3.23.0, but I still want to keep the existing test. Perhaps you instead create another dependency test/file_set_dependency/CMakeLists.txt using the new file set feature instead?

FYI: from import-cmake-c20-modules
Once you have built a compiler that supports p1689 and a version of CMake that supports C++20 modules and have run the tests to make sure things are set up correctly. To use modules in CMake you need to use target_sources and FILE_SETS. https://cmake.org/cmake/help/latest/command/target_sources.html

I see, so the files sets are required to support modules? In that case how about adding a separate test case that demonstrates this functionality by using modules instead of modifying the existing tests?

I can not longer use this cmake module because it has no support for moderern CMake file sets!


Valid assignment to a local variable in a lock statement that accesses a protected variable is disallowed

Description:
$title.
Steps to reproduce:

isolated class Foo {
    private map<int> m = {};

    isolated function baz() returns map<int>[] {
        map<int>[] y = [];
        map<int> z;
        lock {
            map<int>[] y2 = [self.m]; // OK

            // Error, but should be allowed.
            y2[0] = self.m;

            // Should be an error only because LHS is an invalid transfer in.
            y[0] = self.m;

            // Already an error due to invalid attempt to copy out.
            z = self.m;

            // Already an error due to invalid attempt to copy out.
            return y2;
        }
    }
}

Affected Versions:
slbeta1-rc2

Fixed in https://github.com/ballerina-platform/ballerina-lang/pull/30727.


[gtest] add tests for tracing functions (#146)

Closes #146. Codecov report here. Reached 100% coverage just with unit tests, but we may need more extensive testing.

Anyway, please rebase your changes on the top of the master branch. The build failures we're seeing here should be gone.


WorkflowImplementationOptions.FailWorkflowExceptionTypes ignored for service failures

Expected Behavior
When WorkflowImplementationOptions.FailWorkflowExceptionTypes is set to Throwable any workflow task failure leads to workflow failure.
Actual Behavior
The service rejecting workflow task completion doesn't fail the workflow.
Steps to Reproduce the Problem

Set an invalid retry policy. For example, use a smaller maximumInterval than InitialInterval.
Set FailWorkflowExceptionTypes to Throwable.
Observe that workflow is stuck in workflow task failure retry loop.

Reproduction:
package io.temporal.samples.hello;

import io.temporal.activity.ActivityInterface;
import io.temporal.activity.ActivityMethod;
import io.temporal.activity.ActivityOptions;
import io.temporal.client.WorkflowClient;
import io.temporal.client.WorkflowOptions;
import io.temporal.common.RetryOptions;
import io.temporal.serviceclient.WorkflowServiceStubs;
import io.temporal.worker.Worker;
import io.temporal.worker.WorkerFactory;
import io.temporal.worker.WorkflowImplementationOptions;
import io.temporal.workflow.Workflow;
import io.temporal.workflow.WorkflowInterface;
import io.temporal.workflow.WorkflowMethod;
import java.time.Duration;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/** Sample Temporal Workflow Definition that executes a single Activity. */
public class HelloActivity {

  // Define the task queue name
  static final String TASK_QUEUE = "HelloActivityTaskQueue";

  // Define our workflow unique id
  static final String WORKFLOW_ID = "HelloActivityWorkflow";

  /**
   * The Workflow Definition's Interface must contain one method annotated with @WorkflowMethod.
   *
   *
Workflow Definitions should not contain any heavyweight computations, non-deterministic
   * code, network calls, database operations, etc. Those things should be handled by the
   * Activities.
   *
   * @see io.temporal.workflow.WorkflowInterface
   * @see io.temporal.workflow.WorkflowMethod
   */
  @WorkflowInterface
  public interface GreetingWorkflow {

    /**
     * This is the method that is executed when the Workflow Execution is started. The Workflow
     * Execution completes when this method finishes execution.
     */
    @WorkflowMethod
    String getGreeting(String name);
  }

  /**
   * This is the Activity Definition's Interface. Activities are building blocks of any Temporal
   * Workflow and contain any business logic that could perform long running computation, network
   * calls, etc.
   *
   *
Annotating Activity Definition methods with @ActivityMethod is optional.
   *
   * @see io.temporal.activity.ActivityInterface
   * @see io.temporal.activity.ActivityMethod
   */
  @ActivityInterface
  public interface GreetingActivities {

    // Define your activity method which can be called during workflow execution
    @ActivityMethod(name = "greet")
    String composeGreeting(String greeting, String name);
  }

  // Define the workflow implementation which implements our getGreeting workflow method.
  public static class GreetingWorkflowImpl implements GreetingWorkflow {

    /**
     * Define the GreetingActivities stub. Activity stubs are proxies for activity invocations that
     * are executed outside of the workflow thread on the activity worker, that can be on a
     * different host. Temporal is going to dispatch the activity results back to the workflow and
     * unblock the stub as soon as activity is completed on the activity worker.
     *
     *
In the {@link ActivityOptions} definition the "setStartToCloseTimeout" option sets the
     * overall timeout that our workflow is willing to wait for activity to complete. For this
     * example it is set to 2 seconds.
     */
    private final GreetingActivities activities =
        Workflow.newActivityStub(
            GreetingActivities.class,
            ActivityOptions.newBuilder()
                .setStartToCloseTimeout(Duration.ofSeconds(2))
                .setRetryOptions(
                    RetryOptions.newBuilder()
                        .setInitialInterval(Duration.ofSeconds(10))
                        .setMaximumInterval(Duration.ofSeconds(5))
                        .build())
                .build());

    @Override
    public String getGreeting(String name) {
      // This is a blocking call that returns only after the activity has completed.
      return activities.composeGreeting("Hello", name);
    }
  }

  /** Simple activity implementation, that concatenates two strings. */
  static class GreetingActivitiesImpl implements GreetingActivities {
    private static final Logger log = LoggerFactory.getLogger(GreetingActivitiesImpl.class);

    @Override
    public String composeGreeting(String greeting, String name) {
      log.info("Composing greeting...");
      return greeting + " " + name + "!";
    }
  }

  /**
   * With our Workflow and Activities defined, we can now start execution. The main method starts
   * the worker and then the workflow.
   */
  public static void main(String[] args) {

    // Get a Workflow service stub.
    WorkflowServiceStubs service = WorkflowServiceStubs.newLocalServiceStubs();

    /*
     * Get a Workflow service client which can be used to start, Signal, and Query Workflow Executions.
     */
    WorkflowClient client = WorkflowClient.newInstance(service);

    /*
     * Define the workflow factory. It is used to create workflow workers for a specific task queue.
     */
    WorkerFactory factory = WorkerFactory.newInstance(client);

    /*
     * Define the workflow worker. Workflow workers listen to a defined task queue and process
     * workflows and activities.
     */
    Worker worker = factory.newWorker(TASK_QUEUE);

    /*
     * Register our workflow implementation with the worker.
     * Workflow implementations must be known to the worker at runtime in
     * order to dispatch workflow tasks.
     */
    worker.registerWorkflowImplementationTypes(
        WorkflowImplementationOptions.newBuilder()
            .setFailWorkflowExceptionTypes(Throwable.class)
            .build(),
        GreetingWorkflowImpl.class);

    /**
     * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
     * the Activity Type is a shared instance.
     */
    worker.registerActivitiesImplementations(new GreetingActivitiesImpl());

    /*
     * Start all the workers registered for a specific task queue.
     * The started workers then start polling for workflows and activities.
     */
    factory.start();

    // Create the workflow client stub. It is used to start our workflow execution.
    GreetingWorkflow workflow =
        client.newWorkflowStub(
            GreetingWorkflow.class,
            WorkflowOptions.newBuilder()
                .setWorkflowId(WORKFLOW_ID)
                .setTaskQueue(TASK_QUEUE)
                .build());

    /*
     * Execute our workflow and wait for it to complete. The call to our getGreeting method is
     * synchronous.
     *
     * See {@link io.temporal.samples.hello.HelloSignal} for an example of starting workflow
     * without waiting synchronously for its result.
     */
    String greeting = workflow.getGreeting("World");

    // Display workflow execution results
    System.out.println(greeting);
    System.exit(0);
  }
}

This filter/rule is not applied for Service errors. The same way for other SDKs.

Also, Server is failing the workflow task in this situation, not an SDK. When the workflow task is already failed by the Server, there is no way for SDK to fail the execution.

SDK can fail the execution by emitting FailWorkflowExecution command.


feat: Support build arguments for docker build

Support for --build-arg during docker build.
Introduces the dockerfileBuildArguments parameter that contains a space-separated list of "key=value".
Closes #8 and #51.

@FabianMeul please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@cormacpayne
Any feedback regarding this one? :-)

Thx for looking into this and the feedback.
Agreed on making this more specific.
I had a few days off, but I'll see to updating the PR tomorrow. 😄

Hey @cormacpayne
I've moved on to another solution, but I would gladly return to use this GA once this gets merged. ;-)

i really need this feature

@cormacpayne
Any chance of getting this approved?...