Change the administrator binding label to something more appropriate

Description
We would need to use something better suited than the type=admin label on the administrator Role Binding that we use right now.
We could potentially use:

reconciler.kyma-project.io/managed-by=reconciler that is implemented right now and blocks any editing in Busola
provisioner.kyma-project.io/managed-by=provisioner to mimic the approach we have in reconciler

With the Cluster Operator in mind, the first option makes sense and it could be considered - at some point Provisioner will be migrated to the reconciler scheme.
Also, we could potentially think about reconciler.kyma-project.io/managed-by=provisioner if Busola is somehow configured to only block resources based on the label key.
Reasons
We want to have clear labels that indicate which resources are managed by the Control Plane.
Acceptance Criteria

Label changed to something that indicates the Binding is managed by the Provisioner.
Provisioner should remove bindings with both type=admin and the new reconciler.kyma-project.io/managed-by=reconciler labels during the upgrade (and then apply the desired ones), this is to avoid name conflicts with existing bindings that use the old label. Later on, the Cluster Operator should use only the new label.

Deletion of labelled bindings: https://github.com/kyma-project/control-plane/blob/fc5da85e9872f49a5e73910733503ee549112029/components/provisioner/internal/operations/stages/provisioning/create_operators_bindings.go#L139
and the creation: https://github.com/kyma-project/control-plane/blob/fc5da85e9872f49a5e73910733503ee549112029/components/provisioner/internal/operations/stages/provisioning/create_operators_bindings.go#L131

More details for developers:
During Kyma cluster creation process provisioner creates some Kubernetes clusterroles and clusterrolebindings on newly provisioner Gardener cluster (gardener shoot). Those objects are required later on for correct setup of the cluster. As described in the original issue description labeling of one of the bindings should be changed.
More source code context:
The step of creating those  clusterroles and clusterrolebindings is part of the provisioning queue executed immediately after fresh Kubernetes cluster becomes active as the third operation (should be read from the bottom).
The provisioning queues are built in the file
components/provisioner/internal/operations/queue/queues_constructor.go
For Kyma 1.x
waitForAgentToConnectStep := provisioning.NewWaitForAgentToConnectStep(ccClientConstructor, configurator, model.FinishedStage, timeouts.AgentConnection, directorClient)
configureAgentStep := provisioning.NewConnectAgentStep(configurator, waitForAgentToConnectStep.Name(), timeouts.AgentConfiguration)
waitForInstallStep := provisioning.NewWaitForInstallationStep(installationClient, configureAgentStep.Name(), timeouts.Installation, factory.NewWriteSession())
installStep := provisioning.NewInstallKymaStep(installationClient, waitForInstallStep.Name(), timeouts.InstallationTriggering)
createBindingsForOperatorsStep := provisioning.NewCreateBindingsForOperatorsStep(k8sClientProvider, operatorRoleBindingConfig, installStep.Name(), timeouts.BindingsCreation)
waitForClusterCreationStep := provisioning.NewWaitForClusterCreationStep(shootClient, factory.NewReadWriteSession(), gardener.NewKubeconfigProvider(secretsClient), createBindingsForOperatorsStep.Name(), timeouts.ClusterCreation)
waitForClusterDomainStep := provisioning.NewWaitForClusterDomainStep(shootClient, directorClient, waitForClusterCreationStep.Name(), timeouts.ClusterDomains)

For Kyma 2.x
configureAgentStep := provisioning.NewConnectAgentStep(configurator, model.FinishedStage, timeouts.AgentConfiguration)
createBindingsForOperatorsStep := provisioning.NewCreateBindingsForOperatorsStep(k8sClientProvider, operatorRoleBindingConfig, configureAgentStep.Name(), timeouts.BindingsCreation)
waitForClusterCreationStep := provisioning.NewWaitForClusterCreationStep(shootClient, factory.NewReadWriteSession(), gardener.NewKubeconfigProvider(secretsClient), createBindingsForOperatorsStep.Name(), timeouts.ClusterCreation)
waitForClusterDomainStep := provisioning.NewWaitForClusterDomainStep(shootClient, directorClient, waitForClusterCreationStep.Name(), timeouts.ClusterDomains)

The  code executed to create cluster roles and custerrolebindings is executed in the Run method of the step
 func (s *CreateBindingsForOperatorsStep) Run(cluster model.Cluster, _ model.Operation, log logrus.FieldLogger)
To verify if this code works and its result - we can take any provisioned Kyma runtime and after logging with  kubecoinfig execute:
k get clusterroles --show-labels
l2-operator    2022-10-12T09:23:30Z   app=kyma
l2-operator-rules  2022-10-12T09:23:30Z   app=kyma,rbac.authorization.k8s.io/aggregate-to-l2-operator=true

To find clusterrolebing to fix:
k get clusterrolebindings --show-labels | grep type=admin
administrator0                  ClusterRole/cluster-admin             6h20m   app=kyma,type=admin
Which is effect of the following code:
clusterRoleBindings = append(clusterRoleBindings,
   buildClusterRoleBinding(
      fmt.Sprintf("%s%d", administratorOperatorClusterRoleBindingName, i),
      administrator,
      ownerClusterRoleBindingRoleRefName,
      userKindSubject,
      map[string]string{"app": "kyma", "type": "admin"}))

Hey, @kyma-project/framefrog, I believe this issue should not be closed, this still would bring value for the Kyma users.
Do you have other opinions on that? Is there a reason to skip the implementation?

Currently new label is added, but old (type=admin) is still present.  We currently remove by type=admin. The only part missing is changing the remove filter, and not adding type=admin

@VOID404 any plans to continue/finalize the implementation from this issue?

@lautoma We will work on it in the next sprint starting 12th of June.

@akgalwas I see that you moved this issue to Done, however it's still open. When (in which release) will this implementation be available?

This issue was fixed by https://github.com/kyma-project/control-plane/pull/2866.

@lautoma The update was delivered to Kyma Control Plane not for any particular Kyma release. It was deployed to production about 3 weeks ago so it can be correlated with Kyma 2.15


BN - Bengali Translation

I am translating this game to Bengali (BN). Started on 26/08/2019.

19/09/2019
Finished upto line 1108 in the index.html file.
There are some problems with the text alignment and size in the web page.


Add option to limit tests to specific files

This adds an option to limit the tests to specific files.  This will allow us to create new workflows that

Test just the files that were added in a pull request.
Automatically comment on a pull request to raise potential issues in the new files.

These will hopefully make it easier for us to catch and address issues earlier upon submission rather than later.  The submitter may have more insight about the data than someone examining the data afterwards.
A future direction of improvement can be to run the tests on modified files as well, but that will require a bit more work.

See here for an example of the automatic commenting.  @dwillis, let me know if you think this is unnecessary.  We can limit the scope to just the new workflow without the automatic comments if that's preferred.  I sometimes find the workflow logs difficult to navigate, which is what led me to this approach.

I'll need to investigate why the tests are failing.  They run fine for me locally.  I'll mark this as a draft and reopen when it's ready.

I think this is a great approach, @warwickmm

For some reason, some of the unit tests fail with Python 3.11.  For now, I've frozen the version to 3.10 until I can debug this more easily (I don't have 3.11 available on my machine).  I created #27 to keep track of this.

I was able to fix the unit tests.  @dwillis, this is ready for review.


training efficiency of GLA

Hi, great work!! I am comparing the GLA and the attention (from pytorch) in diffusion model training. The GLA seems quite slower than the attention, even worse in the first epoch. Would love to know why and any solution we can take.

@pengzhangzhi Hello, may I know your training settings: did you train GLA with bf16/fp16?
What's the accurate training throughput (toks/gpu/s) of the both?

FYI, below is the training throughput tested on a single H100

Thanks for the context!! I don't have the exact throughput but the settings are: sequence length is 128, batch size is 32, and the model is ~22M. I replaced the transformer block in the baseline with the GLA block and it results in 25% of param overhead. I use the full precision.

@pengzhangzhi I see, I believe the model is too small, so the additional params are not ignorable compared to models >340M.
Also, fla may not show its superiority with the input sequence length of 128. As you can see from the figure,  the overall throughput of fla can not outperform attn for small lengths cuz of addtional FLOPs.

Yes, the advantage I observed is during the training, the FLA-based model consumes less GPU memories thus enabling a larger batch size on the same hardware. But it's a ich that the inference of FLA model is quite slow. It might be disadvantageous for the downstream applications without even efficiency degradation. If I understand correctly.

But it's a ich that the inference of FLA model is quite slow. It might be disadvantageous for the downstream applications without even efficiency degradation.

Could you give me precise comparisons, e.g., prefix length, model size. It would be better to provide runnable code.

Yes, I would like to set up the comparison as follows:
bs: 32
seq_len: 128, 512, 1024
model_size: ~20M, 40M~ (by adjusting the num of blocks)
Comparing the inference speed of the GLA and Attention-based models in the above configs. I don't have the results but my exps are GLA takes a bit of time weirdly. Maybe bootstrapping something in the beginning everything you call it? This algins with the training where I sense that the first epoch takes way longer than the subsequent epochs.

@pengzhangzhi

Maybe bootstrapping something in the beginning everything you call it? This algins with the training where I sense that the first epoch takes way longer than the subsequent epochs.

not sure if its cuz triton needs some warmups first to auto tune the args to achieve better speed.
What about the hidden size? Maybe you can compare single attn layers only.
Is the time you examined prefix-filling only, or including 1-by-1 decoding steps?

FYI, I am using it as a BERT. Only forward pass.

@pengzhangzhi Can you try this script https://github.com/sustcsonglin/flash-linear-attention/blob/main/benchmarks/ops/benchmark_gla.py, slightly revising the batch & hidden & seqlen to values you want

Yes, I would like to set up the comparison as follows: bs: 32 seq_len: 128, 512, 1024 model_size: ~ 20M, ~ 40M (by adjusting the num of blocks like 10 and 20)
Comparing the inference speed of the GLA and Attention-based models in the above configs. I don't have the results but my exps are GLA takes a bit of time weirdly. Maybe bootstrapping something in the beginning everything you call it? This algins with the training where I sense that the first epoch takes way longer than the subsequent epochs.

The sequence length is too small and thus in this case the I/O cost will dominate. Flashattention reads sequence only once while the chunkwise kernel for GLA requires multiple times of reading the sequence. It looks normal to me that GLA kernels is twice slower than FlashAttention due to higher I/O cost. I would expect fused_chunk mode to be faster under this setting


Can support monitor yarn link module modifications?

ts-node-dev is an Amazing project, Thanks.
I has a project grouped with two local TypeScript sub-projects.
(1) my-utils
(2) my-backend  (a Koa project)
Before development in a new PC, I will:
in my-utils folder execute yarn link
in my-backend folder execute yarn link my-utils
So when I modified source files of my-utils, I do not need to "publish my-utils to some repo server and then yarn add or yarn update in my-backend", the modifications of my-utils can be used by my-backend directly.
With ts-node-dev, How can respawn  my-backend service when I modified some source files of my-utils?
Thanks for your reply :)

Yes, I found the solution:
in my-backend sub-project's tsconfig, inner "include" append two lines as below
"include": [
"src//*.ts",
"src//.tsx",
"node_modules/my-utils/src/**/.ts",
"node_modules/my-utils/src/**/*.tsx",
]

So I believe may close it? Instead of yarn link use (yalc)[https://github.com/whitecolor/yalc] )


Fixed library name in examples

On the programmatically examples (in the README.md), jisho-api was imported with the name of jisho and that doesn't work, the real name is jisho_api.
Also removed some empty lines from the README.md.

Hey thank you so much for the contribution!

Hey thank you so much for the contribution!


Boolean return value should result in JSON response

Currently only dicts and lists are converted to JSON responses. However, it is also quite common for APIs to return a boolean scalar. For now this will result in an exception and if one wants to do this, they have to use jsonify.
I think allowing boolean return value to be converted into JSON responses is therefore a nice QoL improvement. And because it is currently prohibited, there is no backwards incompatible change.
@app.get("/test-registration-state")
def registration_state():
    return quart.json.jsonify(some_check()) # old
    return some_check() # new

I don't want to add shortcuts for the primitive types. Return a JSON object or list of objects is common in APIs. But automatically handling bools and ints seems easy to hide programming errors unintentionally. It's easy enough to either return jsonify(True) or {"done": True} instead.


Why is the users context replaced while tags/extra get merged

Is there a reason why the tags and extra keys are actually merged ...
>>> client.context
{}
>>> client.context.merge({'tags': {'foo': 'bar'}})
>>> client.context
{'tags': {'foo': 'bar'}}
>>> client.context.merge({'tags': {'foobar': 42}})
>>> client.context
{'tags': {'foo': 'bar', 'foobar': 42}}

... while the also special key user is instead replaced?
>>> client.context.merge({'users': {'foo': 'bar'}})
>>> client.context
{'tags': {'foo': 'bar', 'foobar': 42}, 'users': {'foo': 'bar'}}
>>> client.context.merge({'users': {'foobar': 42}})
>>> client.context
{'tags': {'foo': 'bar', 'foobar': 42}, 'users': {'foobar': 42}}

Based on the docs I would have assumed that all those special 3 context keys are treated in the same way when using the merge method.
Docs: https://docs.sentry.io/learn/context/
Code: https://github.com/getsentry/raven-python/blob/master/raven/context.py#L111

@behrtam originally this was done because when you're binding the user information, you generally have all of the context, and there's always the tradeoff of you not expecting it to merge (which could be true for the others as well). I dont have a strong opinion at this point on what is the better way, but we should definitely provide the option to merge on all of them.


Cannot start app

getting an Error: : Cannot find module '/Users/user/stripeMockServer/stripe-stateful-mock'
Steps:

Created new directory and cd' in
npm init -y
npm add stripe-stateful-mock --save
npm install
node stripe-stateful-mock  --> gives error

Hmm yeah it should have a bin file to be easy to start.  In the meantime start it with node ./node_modules/stripe-stateful-mock as a workaround.

Fixed in https://github.com/Giftbit/stripe-stateful-mock/releases/tag/v0.0.12 with new instructions.


Use vector images for CPU Manager blog article

Problem: Blog article Kubernetes v1.31: New Kubernetes CPUManager Static Policy: Distribute CPUs Across Cores uses raster images. These don't render clearly and are hard to localize.
Proposed Solution:
Find the images used in content/en/blog/_posts/2024-08-22-cpumanager-static-policy-distributed-cpu-across-cores/ and redraw them as SVG.
Page to Update:
https://kubernetes.io/blog/2024/08/22/cpumanager-static-policy-distributed-cpu-across-cores/ (not yet published)
Additional Information:
/area blog
/priority backlog

This would be good to have.
/triage accepted

/assign


Fix speedtest, again

Description:
This should be the last of the speedtest fixes for the week :wink:   I removed the Throttle as it's not necessary.  The problem was that I wasn't giving a second argument to the track_time_change function and it was executing 11 tests in a row at seconds 0-10.
Checklist:
If code communicates with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

…ack_time_change

💃 💃 💃 💃 💃 💃 💃 💃  🐬


Release the GIL when we don't need it anymore

@pbrunet Travis is almost finished, this one should be ok.

travis is ok :-)

Looks nice. I just wonder if we should run test twices: once with one threads, once with 2 or 4 and check we are faster?

On Tue, Dec 20, 2016 at 12:15:42AM -0800, pbrunet wrote:

Looks nice. I just wonder if we should run test twices: once with one threads, once with 2 or 4 and check we are faster?

We could do this with a call to sleep because it does no consume CPU. We
can't do this otherwise because we have no control over the number of
available threads. I'll add this test case.

@pbrunet turns out setting up the test will be quite complicated. I did it manually and it's ok, don't wanant to bother more, you can merge if that's ok with you too.


Tip Tap with initial content duplicated

Hi!
I’ve been trying to integrate the TipTap-Yjs example into a Vue project. I set the initial content of the editor using the content prop (i.e.: new Editor({ extensions: […], content: 'some html' })), and everything works smoothly. However, as soon as a second client connects to the YDoc via WebRTC, the content duplicates, and i get some html some html as the content of the editor on both clients.
I figure this must be a common mistake, but I couldn’t find anything about duplicated content on any Issue Boards.
Any help is much appreciated and thank you so much for your work!

Hey @arnold-graf ,
yeah, this is a common mistake. We discussed this several times in the chat, but not yet in the forum or the GitHub issues.
As soon as you bind Yjs to an editor, it will overwrite the editor content with the value in the Yjs type. In TipTap the initial value is apparently written after the y-prosemirror initialization step, so the content is written in the empty Yjs document. So your "initial" TipTap content is again synced to the other peers.
My recommendation is to store and retrieve the Yjs document on your servers, instead of the TipTap data model. Of course, you can also store the TipTap data format alongside the Yjs document. But if you use the Yjs document to restore the document state, you won't have any sync conflicts / duplicated content with other peers.
This section explains how you get and restore document updates in Yjs https://github.com/yjs/yjs#Document-Updates
// encode the Yjs document to a Uint8Array:
const savedDoc = Y.encodeStateAsUpdate(ydoc1)
// send savedDoc to your server

// in order to populate the initial Yjs document, retrieve doc from the server and apply it to a Yjs document:
const doc = new Y.Doc()
Y.applyUpdate(doc, savedDoc)

Note: If possible, send the binary data directly to your server. If you must send it as a JSON object, you can use Base64 encoding to transform savedDoc to a string (you'll find many Base64 encoder/decoder on the internet). Do not send it as an array of integers to the server, that would be horribly inefficient ;)
Hope this helps.

Kevin

Hello,
I was facing the same problem (more the fact that tables was removed), and this solution works indeed. I've added a get/set content in the Realtime plugin :
get content() {
    return Buffer.from(Y.encodeStateAsUpdate(ydoc)).toString('base64');
  }
set content(c) {
    const content = Buffer.from(c, 'base64').toString('ascii');
    Y.applyUpdate(ydoc, content);
  }

Fine. But I also need the html version to use it in another app. Do I really need to save both yjs document and the html, or is there a 'easy' way to convert the yjs document to html, without creating the same prosemirror view, with an 'editor.getHtml()' in it ? thanks


add og:image

The puzzle 2-3557174c from #2 has to be resolved:
https://github.com/codeforthailand/parliament-listening/blob/2c074e734c9f2e12c63a3726015f5efd6415dd73/src/components/seo.js#L70-L70
The puzzle was created by heytitle on 09-Aug-19.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 2-3557174c has disappeared from the source code, that's why I closed this issue.


kernels/ihaskell: add kernel.js for syntax highlighting in classic notebook interface

This is very useful, thank you!

My pleasure! IHaskell also now provides a prebuilt extension for syntax highlighting in JupyterLab here, would it be helpful for me to open a PR for that as well?

My pleasure! IHaskell also now provides a prebuilt extension for syntax highlighting in JupyterLab here, would it be helpful for me to open a PR for that as well?

We currently have lots of diffuse advices on the main README of how to use the extension (impure building, code mirror, local version, etc...), do you think we can do something out-of-the box? If we can, that would be very useful!

Yes, this is automatic, you can see how I implemented support here. I'll open a PR later today.


ValueError: zero-size array to reduction operation minimum which has no identity

Hi,
Thanks a lot for the amazing tool. I was running the version 0.0.8 on the example spectra from the repo. However, I get the following error. I presume the error is coming from one of the matplotlib function (?). It would be great if you can suggest a fix
command
signatureanalyzer example_luad_spectra_1.tsv --type spectra --nruns 2 --max_iter 100 --outdir ./test_luad/

Error:
---------------------------------------------------------
---------- S I G N A T U R E  A N A L Y Z E R  ----------
---------------------------------------------------------
   * Creating output dir at ./test_luad/
   * Using cosmic3 signatures
   * Saving ARD-NMF outputs to ./test_luad/nmf_output.h5
   * Running ARD-NMF...
Traceback (most recent call last):
  File "/b06x/cluster/42.2/x86_64/easybuild/software/SignatureAnalyzer/0.0.8-foss-2020a-Python-3.8.2/bin/signatureanalyzer", line 8, in <module>
    sys.exit(main())
  File "/b06x/cluster/42.2/x86_64/easybuild/software/SignatureAnalyzer/0.0.8-foss-2020a-Python-3.8.2/lib/python3.8/site-packages/signatureanalyzer/__main__.py", line 200, in main
    run_spectra(
  File "/b06x/cluster/42.2/x86_64/easybuild/software/SignatureAnalyzer/0.0.8-foss-2020a-Python-3.8.2/lib/python3.8/site-packages/signatureanalyzer/signatureanalyzer.py", line 231, in run_spectra
    res = ardnmf(
  File "/b06x/cluster/42.2/x86_64/easybuild/software/SignatureAnalyzer/0.0.8-foss-2020a-Python-3.8.2/lib/python3.8/site-packages/signatureanalyzer/bnmf.py", line 86, in ardnmf
    data = ARD_NMF(X, objective, verbose=verbose)
  File "/b06x/cluster/42.2/x86_64/easybuild/software/SignatureAnalyzer/0.0.8-foss-2020a-Python-3.8.2/lib/python3.8/site-packages/signatureanalyzer/signatureanalyzer_gpu/ARD_NMF.py", line 26, in __init__
    self.V = self.V0 - np.min(self.V0) + 1.e-30
  File "<__array_function__ internals>", line 5, in amin
  File "/b06x/cluster/42.2/x86_64/easybuild/software/SciPy-bundle/2020.03-foss-2020a-Python-3.8.2/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 2792, in amin
    return _wrapreduction(a, np.minimum, 'min', axis, None, out,
  File "/b06x/cluster/42.2/x86_64/easybuild/software/SciPy-bundle/2020.03-foss-2020a-Python-3.8.2/lib/python3.8/site-packages/numpy/core/fromnumeric.py", line 90, in _wrapreduction
    return ufunc.reduce(obj, axis, dtype, out, **passkwargs)
ValueError: zero-size array to reduction operation minimum which has no identity
Closing remaining open files:./test_luad/nmf_output.h5...done

Thank you & stay safe!

Thanks for bringing this to our attention. This isn't an error that I've ever seen with signatureanalyzer. How was the spectra generated? Are all values non-negative?

Hi @yoakiyama thanks for the response. The spectra is actually from this repo example_luad_spectra_1.tsv
I was unable to figure out where exactly this error is coming from. Would really appreciate any help fixing it.
Thank you!

@itsvenu I ran your exact shell script on my end with the latest version of signatureanalyzer and did not run into any issues. How did you install SignatureAnalyzer to your machine? Sorry for the slow response
Best regards,
Yo


Set a minimum evictionHard and kubeReserved

Issue #, if available: https://github.com/awslabs/amazon-eks-ami/issues/318 (partial fix)
Description of changes: Add a minimal eviction-hard and kube-reserved configuration to help prevent kubelets becoming unresponsive.
These numbers are hardcoded and do not take into account instance type. EKS needs to support instance types down to t2.nano. In the near future, we'll want to determine optimal numbers per instance type and set these numbers according to that, as described in #318.
Also, note I've omitted system-reserved.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @wongma7


Save full resolution

Hi,
Can i save image with original size? As an example, the camera takes pictures at a resolution of 3264x2448. After editing the image, it is saved is the same as when the screen resolution.
I'm used load photo to editor:
void loadPhotoEditor(String filePath) {
        mPhotoEditor.clearAllViews();
        Bitmap photo = BitmapFactory.decodeFile(filePath );
        photoEditorView.getSource().setImageBitmap(photo);
 }

and save function
@SuppressLint("MissingPermission")
    @OnClick(R.id.btnSave)
    public void onbtnEditSaveClicked() {
        progress = ProgressDialog.show(this, "İşleminiz Yapılıyor....",
                "Görsel kayıt ediliyor", true);
        mPhotoEditor.saveImage(mCurrentPhotoPath, new PhotoEditor.OnSaveListener() {
            @Override
            public void onSuccess(@NonNull String imagePath) {
                if (progress != null) {
                    progress.dismiss();
                }
                Toast.makeText(InspectionDetail_PhotoActivity.this,
                        "Değişiklikler kayıt edildi.", Toast.LENGTH_SHORT).show();
                editMode(false);
                fileAdapter.notifyDataSetChanged();
            }
            @Override
            public void onFailure(@NonNull Exception exception) {
                if (progress != null) {
                    progress.dismiss();
                }
                Toast.makeText(InspectionDetail_PhotoActivity.this,
                        "Değişiklikler kayıt edilemedi: " + exception.getMessage(), Toast.LENGTH_SHORT).show();
                editMode(false);
            }
        });
    }

duplicate to #10

To this could a method be implemented where when setImageURI or setImageBitmap is called the passed value is stored in mPhotoEditorView and when saveImage() is called instead of using parentView.getDrawingCache(); simply the edited layers are scaled to the original image passed when setting the PhotoEditorView?

@Alessi42 Yes I agree with approach you mentioned. Do you have any reference or sample code which helps us to get idea of how to implement it correctly.


Fix imports for RN26

@fov42550564 can we get this pull request merged please? thanks @pgmemk

@fov42550564 hope this PR can be merged soon.


Change command from o365 to m365

I was trying to use the sample and noticed that o365 commands have been used in the sample but now m365 now works hence the suggested change

Change command from o365 to m365

#2063

Closes # 2063

Thank you! Good catch! We'll process it shortly

Thank you! Good catch! We'll process it shortly

Merged manually. Thank you and great to have you with us! 👏

Merged manually. Thank you and great to have you with us! 👏


feat: [pipe-20916]: add active/resolved state

NOTE: im passing a usemutation call rn but will be refactored when i refactor provider code and components related to pr pages
add active/resolved state

s


Add VkPhysicalDevicePortabilitySubsetFeaturesKHR:: depthClampDeltaOneBiasClampNegative capability

Some CTS tests fail when using depth clamp with a large negative bias.
This might be fixable with effort within the implementations.
In the meantime, these use cases can be disabled in CTS and reported as Not Supported, by adding a VkPhysicalDevicePortabilitySubsetFeaturesKHR:: depthClampDeltaOneBiasClampNegative capability.
This affects 1 CTS tests:
dEQP-VK.draw.renderpass.inverted_depth_ranges.depthclamp_deltaone_bias_clamp_neg
  Fail (Result images are incorrect)

How do you define "large" for the purpose of this flag?
Or is it meant to forbid any negative bias for the depth?

This looks like another depth accuracy issue. The result and reference images are completely indistinguishable even to my discerning eyes. The error mask shows a faint line toward the end of the triangle where the result depth isn't quite close enough to the reference. I recommend we ask for a threshold widening or a waiver for this one.

Filed https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/5079

Filed https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/5079

Thanks!

F J XROn 13 Apr 2024, at 2:56 AM, Alyssa Rosenzweig @.***> wrote:
Filed https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/5079
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Fix merged into CTS, this can be closed

Fix merged into CTS, this can be closed

Thank you!


[Event Hubs] Test failures - receiver.spec.ts

Following tests in receiver.spec.ts are failing (under section with EventPosition specified as) -

'from end of stream' should receive messages correctly
'after a particular offset' should receive messages correctly
'from a particular enqueued time' should receive messages correctly

The Node tests were failing as well in some of the runs, and this seemed like it has to do with entity setup.
Expected behavior: Both Node and browser tests to pass consistently.
Steps to reproduce: Checkout latest commit from https://github.com/Azure/azure-sdk-for-js/pull/3445 if not already available on master.

Took a closer look at the tests, the test failures in Node are unrelated and fixed with changes proposed in #3484  (as verified on local).
These tests involve multiple receive() calls as well and are the reason why messages are getting received before the main receive() call gets executed.
Fix for this will likely be same as #3471, unless something more gets uncovered.
cc @ramya-rao-a @AlexGhiondea

@ramya0820 Closing this issue for the same reason as https://github.com/Azure/azure-sdk-for-js/issues/3471#issuecomment-506084336.
The failing tests in receive.spec.ts have been refactored to avoid multiple receive calls on the batching receiver and thus avoiding the drain scenario


🪲 Bug Report - Configure DDOS Protection on Azure Firewall VNET generates false positive

Describe the bug
Check to see if firewall VNets are protected by DDOS plan is generating recommendations for change, but protection is already in place.
To Reproduce
Steps to reproduce the behaviour:

Look for the vNet name in the param1 column on the ImpactedResources sheet
Look at the DDOS plan in the portal and see that the networks exist in the list of Protected resources

Expected behaviour
If the vNet listed in the param1 section exists in the Protected resources list, they should not show up as ImpactedResources with a recommendation to do something that already has been done.
Screenshots 📷

Additional context
The firewall objects also are showing as Protected resources on the Firewall tab in DDOS
Dave Newman

Hi @Azure/aprl-networking, could you please take a look at this one?

@Azure/aprl-networking please review

Will investigate

Hi @ehaslett, any update on this one?

Working to reproduce as of Oct 9, 2024

This was something that I ran into while delivering a WARA and have not seen it again since. It could have been a one-off glitch with the way this customer had things configured.  - I think it is ok to close


break out cancel-task from delete-task

Added a command cancel-task to cancel task.
Modified delete-task command to delete only completed task.
Following are scenarios handled :-

delete-task can only delete task if task is COMPLETED.
delete-task will return if task does not exist or if task name is null.
cancel-task will try to cancel task and  will return error if receptor return error while cancelling task.
if task is already COMPLETED , cancel-task will return success but will not go for task cancellation.
cancel-task will return error if task does not exist or if task name is null.
[#95422348]

Coverage increased (+0.01%) to 98.4% when pulling 6011cc55457aef556987cbc5e2731d55980cf60b on HuaweiTech:hwcf-issue-14 into 8788f88fc98020f807d71351145867e79cb4dd50 on cloudfoundry-incubator:develop.

Thanks!  We made some changes:

Cancelling a completed task returns an error now
task_runner_test injects a fake task_examiner

David

Tiny note: it's 'canceling' not 'cancelling'


zapier_app: Add API features required by the Zapier app.

@timabbott: FYI :) This closes #11562

I merged 2 commits ending with 9252c432253d23ce74a15bedd4abe133052eed1a, see above.
We may want to re-add the auth stuff in whatever version of Zulip contains full backend support for the Zapier app (which I suppose could be this version, but I'm not sure as we haven't resolved this string-encoding question.  Which I still feel 90% confident is a misdiagnosed bug in zulip-js).

@timabbott: Hey Tim! I just responded to all of your comments. Will rebase this now to resolve conflicts. Thanks! :)

@timabbott: Okay, I think I found a solution to our "accepting IDs as strings" problem. So, I'm closing this PR! :) Thanks!


Fix typo in Readme.

:)

Current coverage is 33.60% (diff: 100%)

Merging #274 into master will not change coverage

@@             master       #274   diff @@
==========================================
  Files            86         86
  Lines          4142       4142
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1392       1392
  Misses         2633       2633
  Partials        117        117

Powered by Codecov. Last update 8555716...fe60a43


Fixed Login Page to be Responsive

Fixes Issue #207

Thank you for your contribution, @0x00zer0day!


onNavigationRequest not working Reactjs

onNavigationRequest & onPageStarted isn't working on  the listener is not detecting Reactjs navigate(/product/${productId}); is there something wrong I am doing.
Reactjs side:
const navigate = useNavigate()
navigate(/product/${productId});
flutter side:
onNavigationRequest: (request) {
print(request.url);//not printing on all listeners
}

@Baker-Koussa
When you open an issue, please try to use new issue template and fill out requested details so that we'll have enough info to work with. Simply saying is there something wrong I am doing indicates this issue is better suited for support channels like StackOverflow, so I suggest you to ask this question there.
If you think there's a genuine bug,  please provide all requested details using the template so that we can make the issue actionable.
Closing for now.


Atom stuck on 1.34.0-nightly9

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When I try to update Atom to 1.34.0-nightly12 it won't update and stays on 1.34.0-nightly9
Steps to Reproduce

Go to the about page
Click on check for updates
OR
Download a fresh installer for 1.34.0-nightly12
Run it
Go to the about page, version is stuck at 1.34.0-nightly9

Expected behavior: For the upgrade to happen a
Actual behavior: 100%
Reproduces how often: [What percentage of the time does it reproduce?]
Versions
$ atom --version

Atom    : 1.34.0-nightly9
Electron: 2.0.12
Chrome  : 61.0.3163.100
Node    : 8.9.3

$ apm --version
apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.34.0-nightly9
python 2.7.15
git 2.19.1.windows.1
visual studio 2015

Thanks for the report - I believe this is a known issue with the nightlies on Windows though i couldn't find an issue for it so I'll leave it open for now /cc @daviwil

No progress, @daviwil is still OoO.  Nightly releases aren't yet officially announced and the work to be done before announcing is being tracked  in https://github.com/atom/atom/issues/17884.  I'll reference this issue there.

TL;DR: the problem is in how Squirrel.Windows sorts prerelease version numbers, making -nightly9 seem like a newer version number than -nightly1*, hence Atom Nightly on Windows never updates correctly past -nightly9.
Here's the details:
Squirrel.Windows is built upon NuGet 2.0 which uses the SemVer 1.0 versioning scheme for packages, especially when it comes to prerelease versions.  This is why Atom Beta and Nightly version numbers look like 1.37.0-beta0.
When NuGet originally implemented their SemVer 1.0 support, they didn't sort prerelease version numbers past 9 correctly like 1.37.0-nightly10, etc.  Instead of doing a numerical comparison of the digits of a prerelease version, they did a lexicographical sorting which would put -nightly10 before -nightly9 in the sort order.
NuGet's codebase was forked to integrate it into Squirrel.Windows so I was able to send a PR there to add support for double-digit prerelease version sorting.  Unfortunately, that wasn't enough as there's a second SemVer 1.0 implementation used in Squirrel.Windows in the app launcher shim, written in C++.  @Ben3eee started a change to fix this behavior but neither of us have had time to complete it.

We've fixed this issue by cherry-picking the PR from @Ben3eeE to create a custom build of electron-winstaller.
With this, current Atom nightlies don't experience this issue, so I'm going to close it 😃


extra_host not work in stack

First I thought it's compose file problem, I asked an issue in docker/compose repo. But let me ask here. It's a weird problem that extra_host not work in stack compose-file. Details can be found in up that issue.

Do you get an error message when doing this?

@jamescarppe Stack is started normally and container is running normally. I clicked Inspect on my container and found that ExtraHosts was recorded at Config:HostConfig:Extrahosts. But if I cat /etc/hosts in the container, there's no extra_hosts appended.

Still valid

extra_hosts does what is expected in my testing.

Are you using the below
version: "3.7"
services:
  app:
    image: some-image
    volumes:
      - "/etc/hosts:/etc/hosts"
    extra_hosts:
      - "some-host:ip"
    logging:
      driver: "json-file"
      options:
        max-size: "100m"
    restart: always

Looks like you are mounting /etc/hosts from your docker hosts which negates the use of extra_hosts directive

@samdulam Thanks. I use the second method. But I think 'extra' means  appending extra_hosts to /etc/hosts, whether hosts are mounted or not. I will try your first method.

@se7enXF
I wanted to follow up on this request.  Were you able to move forward?  Can this be closed?
Thanks!

@tamarahenson It is still not work for me.


Update AES256.py ERRORHANDLING

Adding key value errrors
Type of change

[ ] New features
[ ] Enhanced documentation

Changes proposed in this pull request

Project name :AES-256 encryption and decryption

Short description : This Python script demonstrates AES-256 encryption and decryption using the pycryptodome library. AES (Advanced Encryption Standard) is a symmetric encryption algorithm widely used to secure sensitive data. The script performs encryption and decryption using the AES-GCM (Galois/Counter Mode) mode of operation.

Checklist

[ ] The code is Python 3 compatible
[ ] I have added relevant comments in my file to make code understandable

[自动回复]已读


Add OR condition

Would be nice to have something like:
apply_filters(resource, { or: { title: "Ruby", content: "Rails" })

What do you think?

Yes it's on my list for version 2.0 which will also be JSON API compliant. I am not sure how the API for #or will look like (maybe like you suggest) but it will exploit rails 5 AR #OR method. Probably it will land around December unless you want to send a pull request :)

Great Lib! Thnx!
I've been trying to implement or-filters, here is my result so far:
In the column filters I added the or_filters function (down below), and at each null_filters I added a call to or_filters:
module ActiveHashRelation::ColumnFilters
  def filter_primary(resource, column, param)
    resource = resource.where(id: param)
  end

  def filter_integer(resource, column, table_name, param)
    if param.is_a? Array
      n_param = param.to_s.gsub("\"","'").gsub("[","").gsub("]","") #fix this!
      return resource.where("#{table_name}.#{column} IN (#{n_param})")
    elsif param.is_a? Hash
      if !param[:null].nil?
        return null_filters(resource, table_name, column, param)
      elsif param[:or]
        return or_filters(resource, table_name, column, param, __method__)
      else
        return apply_leq_geq_le_ge_filters(resource, table_name, column, param)
      end
    else
      return resource.where("#{table_name}.#{column} = ?", param)
    end
  end

  def filter_float(resource, column, table_name, param)
    filter_integer(resource, column, table_name, param)
  end

  def filter_decimal(resource, column, table_name, param)
    filter_integer(resource, column, table_name, param)
  end

  def filter_string(resource, column, table_name, param)
    if param.is_a? Array
      n_param = param.to_s.gsub("\"","'").gsub("[","").gsub("]","") #fix this!
      return resource.where("#{table_name}.#{column} IN (#{n_param})")
    elsif param.is_a? Hash
      if !param[:null].nil?
        return null_filters(resource, table_name, column, param)
      elsif param[:or]
        return or_filters(resource, table_name, column, param, __method__)
      else
        return apply_like_filters(resource, table_name, column, param)
      end
    else
      return resource.where("#{table_name}.#{column} = ?", param)
    end
  end

  def filter_text(resource, column, param)
    return filter_string(resource, column, param)
  end

  def filter_date(resource, column, table_name, param)
    if param.is_a? Array
      n_param = param.to_s.gsub("\"","'").gsub("[","").gsub("]","") #fix this!
      return resource.where("#{table_name}.#{column} IN (#{n_param})")
    elsif param.is_a? Hash
      if !param[:null].nil?
        return null_filters(resource, table_name, column, param)
      elsif param[:or]
        return or_filters(resource, table_name, column, param, __method__)
      else
        return apply_leq_geq_le_ge_filters(resource, table_name, column, param)
      end
    else
      resource = resource.where(column => param)
    end

    return resource
  end

  def filter_datetime(resource, column, table_name, param)
    if param.is_a? Array
      n_param = param.to_s.gsub("\"","'").gsub("[","").gsub("]","") #fix this!
      return resource = resource.where("#{table_name}.#{column} IN (#{n_param})")
    elsif param.is_a? Hash
      if !param[:null].nil?
        return null_filters(resource, table_name, column, param)
      elsif param[:or]
        return or_filters(resource, table_name, column, param, __method__)
      else
        return apply_leq_geq_le_ge_filters(resource, table_name, column, param)
      end
    else
      resource = resource.where(column => param)
    end

    return resource
  end

  def filter_boolean(resource, column, param)
    b_param = ActiveRecord::Type::Boolean.new.type_cast_from_database(param)

    resource = resource.where(column => b_param)
  end

  private

  def apply_leq_geq_le_ge_filters(resource, table_name, column, param)
    if !param[:leq].blank?
      resource = resource.where("#{table_name}.#{column} <= ?", param[:leq])
    elsif !param[:le].blank?
      resource = resource.where("#{table_name}.#{column} < ?", param[:le])
    end

    if !param[:geq].blank?
      resource = resource.where("#{table_name}.#{column} >= ?", param[:geq])
    elsif !param[:ge].blank?
      resource = resource.where("#{table_name}.#{column} > ?", param[:ge])
    end

    return resource
  end

  def apply_like_filters(resource, table_name, column, param)
    like_method = "LIKE"
    like_method = "ILIKE" if param[:with_ilike]

    if !param[:starts_with].blank?
      resource = resource.where("#{table_name}.#{column} #{like_method} ?", "#{param[:starts_with]}%")
    end

    if !param[:ends_with].blank?
      resource = resource.where("#{table_name}.#{column} #{like_method} ?", "%#{param[:ends_with]}")
    end

    if !param[:like].blank?
      resource = resource.where("#{table_name}.#{column} #{like_method} ?", "%#{param[:like]}%")
    end

    if !param[:eq].blank?
      resource = resource.where("#{table_name}.#{column} = ?", param[:eq])
    end

    return resource
  end

  def null_filters(resource, table_name, column, param)
    if param[:null] == true
      resource = resource.where("#{table_name}.#{column} IS NULL")
    end

    if param[:null] == false
      resource = resource.where("#{table_name}.#{column} IS NOT NULL")
    end

    return resource
  end

  def or_filters(resource, table_name, column, param, filter_method)
    base_resource = resource  # Save base, so to make each or_filter work on the same base-set
    param[:or] = param[:or].map { |k, v| {k => v} } # Convert to array
    param[:or].each_with_index { |p, i|
      or_filter = send(filter_method, base_resource, column, table_name, p)
      if i == 0
        resource = or_filter  # Nothing to 'or' on for the first or filter
      else
        resource = resource.or(or_filter)
      end
    }
    return resource
  end
end

It is to be called as suggested: apply_filters(resource, { or: { title: "Ruby", content: "Rails" })
It also works with null filters.
One thing I don't understand is why I have to overwrite the param[:or] =  in my function. If I assign the (to array converted param) to a local variable it doesn't work. Any ideas?
Didn't test well yet, but it might be a good start.

Thanks for the feedback @KRaymundus. As I said, I am adding tests at the moment in order to move faster without breaking anything and include features such as this one. I will probably finish adding tests end of this week and I will ping you then so we can take a look on your feedback and merge to master.

@RafaelMCarvalho @KRaymundus thank you for your input. The OR filter has implemented on master. Check the documentation ;). Closing here.


[html] VSCode doesn't automatically close HTML tags

in html file-type
vscode version 0.10.6
My User Settings config says:
"editor.autoClosingBrackets": true,
but it still doesn't work.
For example, when you type in "<script" the IntelliSense suggestions pops up and you press enter on "script" it doesn't close the tag like this:
<script>
</script>

but it stays like this:
<script>

any update on it?

@cindoum Sorry, no, we currently have no plans adding this.
I recommend you using the emmet expansion
enter script, press tab. This expand to <script></script>

You can use the "Auto Close Tag" extension to replace this behaviour. IMO this is better so that VSCode can stay light and people can "enable" features with the extension of choice.
https://marketplace.visualstudio.com/items?itemName=formulahendry.auto-close-tag

It is so essential that it should be part of the HTML language service.

Duplicate of #502 (?).

Yes, #502 is the same. I'll close #502 as dup.

+1 This makes coding faster.

Perhaps this is better as a separate feature request, but it would be useful to integrate auto tag renaming. It's currently available as a popular extension. Thanks.

You may want to use Auto Close Tag extension, and it supports for both Visual Studio mode and Sublime Text mode.

Visual Studio mode:  <script> --> <script></script>

Sublime Text mode:  <script></ --> <script></script>

Can't you use the https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributeslanguages ?
autoClosingPairs - Defines the open and close symbols for the auto-close functionality. When an open symbol is entered, the editor will insert the close symbol automatically. Auto closing pairs optionally take a notIn parameter to deactivate a pair inside strings or comments.

Feature makes it slightly annoying to add HTML to existing tags as it prefers to close the parent tag, instead of creating a new opening tag (I'll have to untrain hitting enter when writing HTML). Esp common occurence with div soup.

I added auto-close to the built-in HTML language support:

typing the > of <sometag> will add the closing tag </sometag>.
typing / of </ will also close the tag.
this behaviour is enabled by default and can be turned off with setting html.autoClosingTags

Thanks @formulahendry for leading the way with his extension. Note that the auto-close extension has more features, in particular, configurable support for more languages.
Jun, if you can add a check for the new setting that would be great, the auto-close extension can co-exist with the new support.

Thanks @aeschli , that's cool! I will take a look.

Does it work also with JSX/TSX?

@rosieks No, this is only for html, handlebars and razor files.

Thx, @aeschli , you rock!

@formulahendry , how is @aeschli 's solution different from the Auto Close Tag extension?

@johnyradio
@aeschli 's solution is leveraging the VSCode built-in HTML extension. It could distinguish HTML and embedded languages well. So when you write embedded languages inside HTML, there will not be improper auto-close if you write generic like https://github.com/formulahendry/vscode-auto-close-tag/issues/17. While the limitation is that it only works on html, handlebars and razor files.
For Auto Close Tag extension, it is based on regular expression. So it works for any languages, while the limitation is that it could not distinguish HTML and embedded languages.


failure to destroy associated models

in my tenant I have put the following line:
has_many :monthly_order_summaries, dependent: :destroy
When I destroy the tenant I see this in my logs:
MonthlyOrderSummary Load (0.2ms)  SELECT `monthly_order_summaries`.* FROM `monthly_order_summaries`  WHERE (monthly_order_summaries.tenant_id = NULL) AND `monthly_order_summaries`.`tenant_id` = 16
Obviously this will not work - it is ANDing on two tenant_id selects.
The model looks like this:
  acts_as_tenant
end```

This happens if I do:

Tenant.last.destroy

thanks for reporting. I also need to see your model setup for Class Tenant.
On Wed, Apr 15, 2015 at 1:00 AM Phil Smy<EMAIL_ADDRESS>wrote:

in my tenant I have put the following line:
has_many :monthly_order_summaries, dependent: :destroy
When I destroy the tenant I see this in my logs:
MonthlyOrderSummary Load (0.2ms) SELECT monthly_order_summaries.* FROM
monthly_order_summaries WHERE (monthly_order_summaries.tenant_id = NULL)
AND monthly_order_summaries.tenant_id = 16
Obviously this will not work - it is ANDing on two tenant_id selects.
The model looks like this:
class MonthlyOrderSummary < ActiveRecord::Base
acts_as_tenant
end
—
Reply to this email directly or view it on GitHub
https://github.com/dsaronin/milia/issues/57.

This happens if I do NOT first set a Tenant (using
Tenant.set_current_tenant). If I set a tenant then the first where
(previously NULL) will be the id of the set tenant.
Of course, if I set a random tenant and then try to delete the last tenant
that doesn't work because the current tenant and last tenant id's are not
the same.
On 16 April 2015 at 04:14, Daudi Amani<EMAIL_ADDRESS>wrote:

thanks for reporting. I also need to see your model setup for Class Tenant.
On Wed, Apr 15, 2015 at 1:00 AM Phil Smy<EMAIL_ADDRESS>wrote:

in my tenant I have put the following line:
has_many :monthly_order_summaries, dependent: :destroy
When I destroy the tenant I see this in my logs:
MonthlyOrderSummary Load (0.2ms) SELECT monthly_order_summaries.* FROM
monthly_order_summaries WHERE (monthly_order_summaries.tenant_id =
NULL)
AND monthly_order_summaries.tenant_id = 16
Obviously this will not work - it is ANDing on two tenant_id selects.
The model looks like this:
class MonthlyOrderSummary < ActiveRecord::Base
acts_as_tenant
end
—
Reply to this email directly or view it on GitHub
https://github.com/dsaronin/milia/issues/57.

—
Reply to this email directly or view it on GitHub
https://github.com/dsaronin/milia/issues/57#issuecomment-93536412.

--
Phil Smy - "http://www.philsmy.com"
filmsite: http://philsfilmlinks.com
twitter: http://twitter.com/psmy
facebook: http://facebook.com/philsmy

well of course it won't work; this is a multi-tenanting system; if
authorization is not established then it should NOT be possible to destroy
tenanted records. So to delete a tenant and have the dependent: destroy
work, you must first establish a current_tenant, then destroy the tenant,
then change the current_tenant.
On Wed, Apr 15, 2015 at 9:15 PM Phil Smy<EMAIL_ADDRESS>wrote:

This happens if I do NOT first set a Tenant (using
Tenant.set_current_tenant). If I set a tenant then the first where
(previously NULL) will be the id of the set tenant.
Of course, if I set a random tenant and then try to delete the last tenant
that doesn't work because the current tenant and last tenant id's are not
the same.
On 16 April 2015 at 04:14, Daudi Amani<EMAIL_ADDRESS>wrote:

thanks for reporting. I also need to see your model setup for Class
Tenant.
On Wed, Apr 15, 2015 at 1:00 AM Phil Smy<EMAIL_ADDRESS>wrote:

in my tenant I have put the following line:
has_many :monthly_order_summaries, dependent: :destroy
When I destroy the tenant I see this in my logs:
MonthlyOrderSummary Load (0.2ms) SELECT monthly_order_summaries.*
FROM
monthly_order_summaries WHERE (monthly_order_summaries.tenant_id =
NULL)
AND monthly_order_summaries.tenant_id = 16
Obviously this will not work - it is ANDing on two tenant_id selects.
The model looks like this:
class MonthlyOrderSummary < ActiveRecord::Base
acts_as_tenant
end
—
Reply to this email directly or view it on GitHub
https://github.com/dsaronin/milia/issues/57.

—
Reply to this email directly or view it on GitHub
https://github.com/dsaronin/milia/issues/57#issuecomment-93536412.

--
Phil Smy - "http://www.philsmy.com"
filmsite: http://philsfilmlinks.com
twitter: http://twitter.com/psmy
facebook: http://facebook.com/philsmy
—
Reply to this email directly or view it on GitHub
https://github.com/dsaronin/milia/issues/57#issuecomment-93635318.


Does upload and download maintain permissions

Hi,
I'm uploading some artifacts and I want to know whether the file permissions will be maintained when I download the same artifacts on a later step. From what I've noticed file permissions are not maintained.
Version: artifacts 1.2.0
OS of agent: Linux ubuntu

Hi @ipinak I’m afraid that’s true, artifacts are stored in S3 or the storage system of your choosing when configuring the Buildkite Agent. The best way to maintain UNIX file system permissions across artifact upload/download is to create a tar archive which supports this metadata, and upload as your artifact instead :bow:

Thanks for update I will consider that.
👍


Newer kernel support

Hi, are there any plans about supporting newer, 6.1.43 kernel? And what steps need to be done to boot from it?
Also I've tried to add it by myself, but none of my attempts were successfull. Could you please suggest what I did wrong or what else I should do for it to work? Here is what I did:
Armbian kernel
Got kernel from https://github.com/armbian/linux-rockchip/archive/refs/tags/linux-6.1-stan-rkr1.zip and defcofig from https://github.com/armbian/build/blob/main/config/kernel/linux-rk35xx-vendor.config. Then I've copied this config to linux-6.1-stan-rkr1/arch/arm64/configs/opi_defconfig, executed make ARCH=arm64 opi_defconfig and copied .config file to nixos-rk3588/pkgs/kernel/rk35xx_legacy_config and ofc replacing all source urls, versions and hashes in legacy.nix
Then I've run nix build .#rawEfiImage-opi5plus --show-trace -L --verbose (and changed pkgsKernel to pkgsNative as kernel builds for 2 or 3 hours via qemu) and created boot image without any errors.
On boot it shows nixos logo, but it doesn't go any further. It's output is the same as in working 5.10 image, but last line shows just Exiting boot services... instead of Exiting boot services and installing virtual address map
Ubuntu-rockchip kernel
ubuntu-rockchip have their own kernel, build scripts for every system and they will use 6.1.43 in 24.04 release, so I've tried their kernel too. Just as in their scripts, I've used rockchip_defconfig to generate .config, but nix-build fails with:
       Failed assertions:
       - CONFIG_AUTOFS_FS is not enabled!

I've tried to enable this option, and I've got compilation error after few minutes. However, on ubuntu system installed on my orange pi, same kernel builds without any errors with same config
I also tried plenty of other configurations, collabora kernels, but all of them couldnt boot beyond nixos logo in uefi.
I don't know what else needs to be done. Device tree is inside kernel sources, kernel config seems to be configured as in documentation. What I have missed?

couldnt boot beyond nixos logo in uefi.

Have you ever tried uboot?
work with uboot, but not with UEFI (EDKII-RK3588)?

I tried kernel 6.1 and confirmed the problem exists, temporarily reverted to the legacy kernel.
https://github.com/ryan4yin/nixos-rk3588/commit/546196524f4985fbb830b33daf8dd6022b0856f7

The problem comes from edk2-rk3588, related issues:

https://github.com/edk2-porting/edk2-rk3588/issues/122
https://github.com/edk2-porting/edk2-rk3588/issues/120

Solution has been added to the document: https://github.com/ryan4yin/nixos-rk3588/blob/main/UEFI.md


Text icon card QA (WIP)

PR: https://github.com/TBD54566975/developer.tbd.website/pull/1513/files
Figma: https://www.figma.com/design/vzQz0IgCT37UxdEbgn1nPw/🌕-tbd-web---reviews?node-id=5983-75049&t=NFD8dZ7oBt20OalL-1

change border width to 1px
https://github.com/TBD54566975/developer.tbd.website/blob/edca22ee0754f8fd0ece8c63e0d3acd278b2abf9/site-new/src/components/TextIconCard.tsx#L44
current: border-2
expected: border-1

the purple theme of the text icon card should use tbd-purple-tint-2 instead of tbd-purple. it's a little confusing bc the yellow and teal themes don't use tints, but purple does.
https://github.com/TBD54566975/developer.tbd.website/blob/edca22ee0754f8fd0ece8c63e0d3acd278b2abf9/site-new/src/components/TextIconCard.tsx#L21

Hey @tallneil, just FYI there is not border-1 class so I need to do this instead: border-[1px]

https://github.com/TBD54566975/developer.tbd.website/pull/1562


Add six to requirements

The OpenstackSDK requires six, but does not explicitly install this causing a failure at runtime

Codecov Report
Patch and project coverage have no change.

Comparison is base (4648cea) 91.18% compared to head (58dcb42) 91.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   91.18%   91.18%
=======================================
  Files          15       15
  Lines         851      851
=======================================
  Hits          776      776
  Misses         75       75

Flag
Coverage Δ

rabbit_consumer
91.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[SPARK-35959][BUILD][test-maven][test-hadoop3.2][test-java11] Add a new Maven profile "no-shaded-hadoop-client" for Hadoop versions older than 3.2.2/3.3.1

What changes were proposed in this pull request?

Add a new Maven profile no-shaded-hadoop-client that, when activated, switches to non-shaded Hadoop client (e.g., hadoop-client, hadoop-yarn-client, etc).
Why are the changes needed?

Currently Spark uses Hadoop shaded client by default. However, if Spark users want to build Spark with older version of Hadoop, such as 3.1.x, the shaded client cannot be used as it currently it only support Hadoop 3.2.2+ and 3.3.1+). Therefore, this proposes to offer a new Maven profile "no-shaded-hadoop-client" for this use case.
Does this PR introduce any user-facing change?

Yes, now users can choose to build Apache Spark with non-shaded Hadoop client, e.g.:
build/mvn package -DskipTests -Dhadoop.version=3.1.1 -Pno-shaded-hadoop-client

How was this patch tested?

Existing tests.

Test build #140469 has started for PR 33160 at commit 0bf197b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44983/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44983/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44983/

Test build #140469 has finished for PR 33160 at commit 0bf197b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140469/

Test build #140487 has started for PR 33160 at commit 37130a9.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44999/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44999/

Test build #140487 has finished for PR 33160 at commit 37130a9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140487/

FYI, if you enable it by default, the dependency files are required to be updated accordingly.

To verify via CI, could you make the profile active by default? After testing, we should remove it.

Thanks @dongjoon-hyun . Will do.

Test build #140531 has started for PR 33160 at commit bf51f50.

Test build #140531 has finished for PR 33160 at commit bf51f50.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140531/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45044/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45044/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45044/

Test build #140537 has started for PR 33160 at commit 13932bf.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45049/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45049/

For Hadoop 2 build, I noticed that GitHub Action job used sbt directly. So, I verified that combination compilation manually.
$ ./build/sbt -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Phadoop-2.7 -Pno-shaded-hadoop-client compile test:compile
...
[info] compiling 18 Scala sources to /Users/dongjoon/APACHE/spark-merge/sql/hive-thriftserver/target/scala-2.12/test-classes ...
[success] Total time: 142 s (02:22), completed Jul 1, 2021 1:48:49 PM

For the other part, it looks good to me. After one hour, if GitHub Action passed, let's revert dev/run-tests.py and merge this PR.

Test build #140537 has finished for PR 33160 at commit 13932bf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140537/

Cause: java.lang.NoSuchMethodError: org.eclipse.jetty.server.session.SessionHandler.setHttpOnly(Z)V
[info]   at org.apache.hadoop.http.HttpServer2.initializeWebServer(HttpServer2.java:707)
[info]   at org.apache.hadoop.http.HttpServer2.<init>(HttpServer2.java:687)

Hmm for some reason it is still using Hadoop 3.3.1 classes which is only compatible with jetty 9.4+. Let me check why it happens.

Let me check the PR builder.

So, SBT with the following conf still fails?
-Phadoop-3.2 -Dhadoop.version=3.1.1 -Pno-shaded-hadoop-client -Phive-2.3
-Pmesos -Pspark-ganglia-lgpl -Pyarn -Pdocker-integration-tests -Pkubernetes
-Phive-thriftserver -Pkinesis-asl -Phive -Phadoop-cloud test:package streaming-kinesis-asl-assembly/assembly

Yeah, but somehow it references Hadoop 3.3.1 class like org.apache.hadoop.http.HttpServer2 according to the line number.

It seems to be a Spark bug which works only at maven and not on sbt.
$ build/mvn dependency:tree -Phadoop-3.2 -Dhadoop.version=3.1.1 -pl core | grep hadoop.client
exec: curl --silent --show-error -L https://downloads.lightbend.com/scala/2.12.14/scala-2.12.14.tgz
Using `mvn` from path: /opt/homebrew/bin/mvn
[INFO] +- org.apache.hadoop:hadoop-client-api:jar:3.1.1:compile
[INFO] +- org.apache.hadoop:hadoop-client-runtime:jar:3.1.1:compile

$ build/sbt "core/dependencyTree" -Phadoop-3.2 | grep hadoop.client
[info]   +-org.apache.hadoop:hadoop-client-api:3.3.1
[info]   +-org.apache.hadoop:hadoop-client-runtime:3.3.1
[info]   | +-org.apache.hadoop:hadoop-client-api:3.3.1

In this case, we used to use [test-hadoop3.2][test-java11] combination which is still working in Jenkins. However, Jenkins PR Builder seems to be broken for [test-java11] for a while. Only the backend Jenkins job is working.

Let me try.

Retest this please

@dongjoon-hyun ahh I think you are right! seems sbt doesn't parse the -Dhadoop.version parameter:
build/sbt "core/dependencyTree" -Phadoop-3.2 -Dhadoop.version=3.1.1 | grep hadoop.client

[info]   +-org.apache.hadoop:hadoop-client-api:3.3.1
[info]   +-org.apache.hadoop:hadoop-client-runtime:3.3.1
[info]   | +-org.apache.hadoop:hadoop-client-api:3.3.1

does jenkins use maven by default? do we need to specify [test-maven]?

Oh, right. Jenkins PR Builder use SBT by default. I forgot it.

Test build #140549 has started for PR 33160 at commit 13932bf.

It started to build correctly. The next step is to run the test with Java 11 correctly.
[info] Building Spark using Maven with these arguments:  -Phadoop-3.2 -Dhadoop.version=3.1.1 -Pno-shaded-hadoop-client -Phive-2.3 -Phadoop-cloud -Pdocker-integration-tests -Pkinesis-asl -Pmesos -Phive -Pspark-ganglia-lgpl -Pkubernetes -Pyarn -Phive-thriftserver clean package -DskipTests

Test build #140549 has finished for PR 33160 at commit 13932bf.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45062/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140549/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45062/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45062/

Ya, Jenkins PR Builder environment is still broken for Java 11.
NB: JAVA_HOME should point to a JDK not a JRE
[error] running /home/jenkins/workspace/SparkPullRequestBuilder/build/mvn -Phadoop-3.2 -Dhadoop.version=3.1.1 -Pno-shaded-hadoop-client -Phive-2.3 -Phadoop-cloud -Pdocker-integration-tests -Pkinesis-asl -Pmesos -Phive -Pspark-ganglia-lgpl -Pkubernetes -Pyarn -Phive-thriftserver -Dtest.exclude.tags=org.apache.spark.tags.ExtendedHiveTest,org.apache.spark.tags.DockerTest -Djava.version=11 test --fail-at-end ; received return code 1
Attempting to post to GitHub...

That's unfortunate... maybe for testing purpose I'll just change Hadoop version directly in the pom.xml to work around the sbt + maven property issue.

Test build #140560 has started for PR 33160 at commit b1e0583.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45072/

Test build #140560 has finished for PR 33160 at commit b1e0583.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45072/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45072/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140560/

Test build #140714 has started for PR 33160 at commit a22c1e7.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45225/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45225/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45225/

Test build #140714 has finished for PR 33160 at commit a22c1e7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140714/

Test build #140721 has started for PR 33160 at commit 3ffecf8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45232/

Test build #140721 has finished for PR 33160 at commit 3ffecf8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45232/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45232/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140721/

It seems Spark can't use non-shaded Hadoop 3.3.1 client as it is because of jetty-server incompatibility issue: Hadoop 3.3.1 uses Jetty 9.4.40 while Spark master uses 9.4.42 (upgraded via this #33053). The method SessionHandler.setHttpOnly was removed in 9.4.42 and therefore we'll get exception if trying to use the non-shaded Hadoop client:
sbt.ForkMain$ForkError: org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NoSuchMethodError: org.eclipse.jetty.server.session.SessionHandler.setHttpOnly(Z)V
	at org.apache.hadoop.yarn.server.MiniYARNCluster.startResourceManager(MiniYARNCluster.java:384)
	at org.apache.hadoop.yarn.server.MiniYARNCluster.access$300(MiniYARNCluster.java:129)
	at org.apache.hadoop.yarn.server.MiniYARNCluster$ResourceManagerWrapper.serviceStart(MiniYARNCluster.java:500)
	at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)
	at org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:122)
	at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceStart(MiniYARNCluster.java:333)
	at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194)

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46877/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46877/

Test build #142369 has finished for PR 33160 at commit 4bf4533.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142369/

Jetty 9.4.40 while Spark master uses 9.4.42

could move hadoop 3.3.2 to the same jetty version; if we get that out then things will briefly be in sync

@steveloughran yes we can, this is only an issue when Spark uses the non-shaded client though so I think it's OK, since it's better to just use the shaded client.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47538/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47538/

you got any plans to update that hadoop jetty version alongside this?

@steveloughran you mean upgrade jetty version in Hadoop? yea I can check, but anyways Spark is not blocked by the jetty thing.


RPCServer 'upgradeAborted' event can fire after websocket upgrade is successful

As per title, the RPCServer's 'upgradeAborted' event can fire after websocket upgrade was successful.

Hello,
I'm not sure if it is related to this bug but when I connect to the RPC Server with a subprotocol that is not allowed, the event 'client' is fired and some of my server logic is executed. Should it not be 'upgradeAborted' directly instead ?
Also, the server answers with a HTTP response that has no Sec-WebSocket-Protocol header but there is a Sec-WebSocket-Accept.


Inconsistent capitalization of buttons

Most action buttons are capitalized, but not all.

the above mentioned issue has been addressed and currently only Reply is capitalized on our theme for consistency.


[OTHER] Weird cron time

What would you like to share?
Hello:)
While reviewing the code i thought that is is weird that the cron job runs everyday at 08:10 AM.
I think it will be better to round it up to 00:00 Am
Additional information
No response

It is not clear when GitHub refreshes the Trending page, just in case it is PDT which is UTC-7, I thought it would be best to only collect the data at 8am. Otherwise we could end up with incorrect data.


Support NULL-able values on pg operator's download_file option

io.digdag.standards.operator.jdbc.AbstractJdbcResultSet#getObjects wrapped result values with com.google.common.collect.ImmutableList, but it doesn't accept null values. So this change uses just ArrayList instead of ImmutableList.
This pull request is to fix https://github.com/treasure-data/digdag/issues/628.

@frsyuki Can you take a look at this change?

Thanks!


[ORM 2.9] Add new set for migration of annotations to Attributes

Package doctrine/orm 2.9 stable now supports PHP 8.0 attribute alternatives for Doctrine annotations.
See https://www.doctrine-project.org/2021/05/24/orm2.9.html
There is place for a first-time, who would like to chip-in little work to upgrade of every Doctrine  project in the world.

7 Steps to Contribute Doctrine ORM 2.9 Migration Set

look at existing sets https://github.com/rectorphp/rector-doctrine/tree/main/config/sets
add a new set, e.g. doctrine-orm-29.php
register AnnotationToAttributeRector rule - https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#annotationtoattributerector
configure it with all Doctrine annotations that have attribute alternatives
first value is annotation class, second is attribute class - in this case they're always the same
e.g. for ORM\Entity, it would look like this

 $services->set(AnnotationToAttributeRector::class)
        ->call('configure', [[
            AnnotationToAttributeRector::ANNOTATION_TO_ATTRIBUTE => ValueObjectInliner::inline([
                new AnnotationToAttribute(
                    'Doctrine\ORM\Mapping\Entity',
                    'Doctrine\ORM\Mapping\Entity'
                ),
            ]),
        ]]);

send PR
party and share it to help your Doctrine friends :tada: :birthday: :balloon:

Bonus Level
Would be nice, but is not needed.
Write a test so we have this behavior verified.

copy this test
configure rector.php with import('...-doctrine-orm-29.php') set
add single fixture file to /Fixtures directory to verify
:+1:

I created a starting PR for it at https://github.com/rectorphp/rector-doctrine/pull/5 . If anyone want have more fixture examples of Doctrine annotation from there, feel free to cherry-pick commits and continue.


Add crate: ngt

Bindings for NGT: Nearest Neighbor Search with Neighborhood Graph and Tree for High-dimensional Data

Apologies for the delay - the CI for building and publishing has been broken for many months, but it is resolved now. Will merge this momentarily assuming the new CI checks pass. Thanks.


Travis build matrix

run tests against rails 4 and 5

All builds are passing besides the RBX/Rails 5..

https://github.com/globalize/globalize/pull/512#issuecomment-227184463
Similar issue on globalize. It appears that the the older version of RBX available on travis fails. But newer versions pass..

@ksykulev Thanks for getting this in place!
I've decided to just disable the rbx build for now on Rails 5 - there doesn't seem to be an easy workaround. Using the Ubuntu Trusty VM on Travis gets us rbx-44 (anything higher segfaults) but sadly that still gives the same error.
In any case, since I don't particularly care about Rubinius, if we test it somehow with Rails 4.2 thats good enough. If Travis and/or Rubinius can sort out the Rails 5 problem then we can just update and enable it again.
Appreciate your contributions & if you ever have thoughts on the checks that dblint itself does - let me know!


Confuser.Runtime.dll not found when using ConfuserEx MSBuild target

I'm trying to use the current ConfuserEx v1.4.1 NuGet package in my project. Running from the GUI and from the CLI works fine, but the MSBuild target throws an error. This is the command I use to run the ConfuserEx target:
msbuild -r -m -v:d -target:ConfuserEx -p:Configuration="<configuration>" <projectname>.sln

And this is the (verbose) output from MSBuild:
... snip ...
       Task "Confuser.MSBuild.Tasks.CreateProjectTask"
       Done executing task "Confuser.MSBuild.Tasks.CreateProjectTask".
   2:7>Done building target "CreateConfuserProject" in project "<projectname>.csproj".
       Target "CreateConfuserProject" skipped. Previously built successfully.
   2:7>Target "ConfuseAssembly" in file "<projectpath>/Projects/packages/Confuser.MSBuild.1.4.1/build/Confuser.MSBuild.targets" from project "<projectpath>/Projects/<projectname>/<projectname>.csproj" (target "ConfuserEx" depends on it):
       Building target "ConfuseAssembly" completely.
       Output file "obj/<configuration>/confused/<projectname>.exe" does not exist.
       Using "Confuser.MSBuild.Tasks.ConfuseTask" task from assembly "/<projectpath>/Projects/packages/Confuser.MSBuild.1.4.1/build/../netstandard/Confuser.MSBuild.Tasks.dll".
       Task "Confuser.MSBuild.Tasks.ConfuseTask"
         Confuser.Core 1.4.1+5d92e25e43 Copyright © 2014 Ki, 2018 Martin Karing
         Running on Unix <IP_ADDRESS>, 6.10.0 (makepkg/5d03a6fe116 Wed 15 Jul 2020 03:01:56 PM -03), 64 bits
         [DEBUG] Discovering plugins...
         Discovered 12 protections, 1 packers.
         [DEBUG] Resolving component dependency...
         Loading input modules...
         Loading '<projectname>.exe'...
         Initializing...
         [DEBUG] Building pipeline...
         Resolving dependencies...
         [DEBUG] Checking Strong Name...
         [DEBUG] Creating global .cctors...
         [DEBUG] Executing 'Name analysis' phase...
         [DEBUG] Building VTables & identifier list...
         [DEBUG] Analyzing...
         [DEBUG] WinForms found, enabling compatibility.
         Processing module '<projectname>.exe'...
         [DEBUG] Executing 'Invalid metadata addition' phase...
         [DEBUG] Executing 'Renaming' phase...
         [DEBUG] Renaming...
         [DEBUG] Executing 'Anti-debug injection' phase...
   2:7><projectpath>/Projects/packages/Confuser.MSBuild.1.4.1/build/Confuser.MSBuild.targets(66,5): error : An IO error occurred, check if all input/output locations are readable/writable. [<projectpath>/Projects/<projectname>/<projectname>.csproj]
   2:7><projectpath>/Projects/packages/Confuser.MSBuild.1.4.1/build/Confuser.MSBuild.targets(66,5): error : Could not open file <projectpath>/Projects/<projectname>/Confuser.Runtime.dll for reading. Error: -1 [<projectpath>/Projects/<projectname>/<projectname>.csproj]
       Done executing task "Confuser.MSBuild.Tasks.ConfuseTask".

Apparently, ConfuserEx tries to search the Confuser.Runtime.dll next to my project file, even though it is in the Nuget directory. Concrete example:
<projectpath>/Projects/<projectname>/Confuser.Runtime.dll instead of <projectpath>/Projects/packages/Confuser.MSBuild.1.4.1/netstandard/Confuser.Runtime.dll
This is my crproj file:
<project outputDir="bin\<configuration>\Confused" baseDir="../packages/Confuser.MSBuild.1.4.1/netframework" xmlns="http://confuser.codeplex.com">
  <module path="<projectname>.exe">
    <rule pattern="true" preset="maximum" />
  </module>
</project>

I tried various things, foremost playing with baseDir and probePath, but nothing seemed to help.
By looking through the code I discovered the RuntimeService class which is responsible for loading this dll. I suspect it's either a misconfiguration on my end or a bug somewhere in this loading code. Can somebody point me to the right direction?
Apologies for the redacted paths (<projectpath>, <configuration> and <projectname>).

Okay. So the problem here is, that the MSBuild package is using the netstandard version of the package, instead of the netframework one. This has the side effect, that all protections that use the runtime assembly do not work.
This means that msbuild is not identifying itself as the Full-version.
Can you tell me the exact version of msbuild you are using? Ideally the output of msbuild -version.
That would help to identify this issue.

I may have a solution for this. But without a way to reproduce the issue, I can't validate the fix.
The new version containing the fix is on this nuget server: https://ci.appveyor.com/nuget/confuserex-r4olq7m3uysu
The version for the msbuild package is: 1.5.0-alpha-gcfe7a5e514
@mnme: Can you verify if that changes anything for you?

Thank you already for your effort!
Concerning your first question, the output of msbuild -version:
Microsoft (R) Build Engine version 16.8.0-ci-20621-01 for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

<IP_ADDRESS>101

I'm using the mono-msbuild package for Arch Linux.
Regarding your new version, I'm currently on vacation and didn't have access to the exact same setup but I tried to reproduce it as close as possible. I was able to reproduce the error I had with 1.4.1. With 1.5.0-alpha-gcfe7a5e514 I now get a different error, but this could be unrelated to the issue I had before:
Task "Confuser.MSBuild.Tasks.ConfuseTask"
         Confuser.Core 1.5.0-alpha+cfe7a5e514 Copyright © 2014 Ki, 2018 Martin Karing
         Running on Unix <IP_ADDRESS>, 6.10.0 (makepkg/5d03a6fe116 Wed 15 Jul 2020 03:01:56 PM -03), 64 bits
         [DEBUG] Discovering plugins...
         Discovered 1 protections, 0 packers.
         [DEBUG] Resolving component dependency...
         Loading input modules...
         Loading '<projectname>.exe'...
   2:7><projectpath>/Projects/packages/Confuser.MSBuild.1.5.0-alpha-gcfe7a5e514/build/Confuser.MSBuild.targets(66,5): error : Unknown error occurred. [<projectpath>/Projects/everTouch/everTouch.csproj]
   2:7><projectpath>/Projects/packages/Confuser.MSBuild.1.5.0-alpha-gcfe7a5e514/build/Confuser.MSBuild.targets(66,5): error : Cannot find protection with id 'rename'. [<projectpath>/Projects/<projectname>/<projectname>.csproj]

This is a major problem. The mono msbuild will not load the .NET 4.6.1 Version of ConfuserEx. The .NET Standard version works fine,  but it does not support any obfuscation that requires the runtime assembly, because that one does not build for .NET Standard.
The change in the pull-request will not be merged into the next release, because it works even less then the original version.
The following protections are not supported when building with mono:

anti debug
anti dump
anti tamper
compressor (packer)
constants
ref proxy (strong mode)
resources


asc: remove/hide instruction-set specific code

https://github.com/Intel-Media-SDK/MediaSDK/blob/99712bd1c86ea8201dcf533bfb79c694dd6a4e3c/_studio/shared/asc/include/asc_common_impl.h#L56
We need to check whether this code is actually used and if it is used need to hide it inside instuction-set specific library.

This particular function is used on both AVX2 and SSE4.1 optimized code, I will work on it

I wish we had all intrinsic functions grouped in .cpp files rather than .h files. Since this completely eliminates a risk that the header file will be included in the generic code path (which is not built with required instruction set) and function accidentally used. If that's not possible, I wish we will refactor the source code placement in the folders making sure that headers with intrinsics are grouped in a dedicated folder, This would allow easier catching of problems.

I believe we fixed that in #2107.


add rhmi_check_rhsso.py tiered access command

Implements the first of several new tired access commands for RHMI clusters.  This one is the more complex than most, but should serve as a good reference for the other commands to be added.
I've done as much testing as I can with the script directly, via the devaccess wrapper, etc. on my local machine and one of the rhmi-dev1 masters (with help from @mwoodson).
Sample outputs from testing via devaccess_wrapper:
With only one master oauth secret set correctly:
$ DEVACCESS_CONFIG=/home/jsarnovs/repos/openshift-tools/scripts/devaccess/test_devaccess_config.yaml ./devaccess_wrap.py rhmi_check_rhsso.py
MASTER_NODE          RHSSO      SECRET
<IP_ADDRESS>         found      mismatch
<IP_ADDRESS>          found      mismatch
<IP_ADDRESS>         found      ok
overall result: fail

Intentionally ran while master was restarting:
$ DEVACCESS_CONFIG=/home/jsarnovs/repos/openshift-tools/scripts/devaccess/test_devaccess_config.yaml ./devaccess_wrap.py rhmi_check_rhsso.py
MASTER_NODE          RHSSO      SECRET
<IP_ADDRESS>         found      mismatch
<IP_ADDRESS>          fail       fail
<IP_ADDRESS>         found      ok
overall result: fail

With all 3 masters set correctly:
$ DEVACCESS_CONFIG=/home/jsarnovs/repos/openshift-tools/scripts/devaccess/test_devaccess_config.yaml ./devaccess_wrap.py rhmi_check_rhsso.py
MASTER_NODE          RHSSO      SECRET
<IP_ADDRESS>         found      ok
<IP_ADDRESS>          found      ok
<IP_ADDRESS>         found      ok
overall result: ok

I rewrote this based on what I learned while working on the rhmi_3scale_dump.sh tiered access command.  Its less complex and has actually been tested thru devaccess vs. only passing it thru the wrapper on local machine.
Sample output via full devaccess setup (I intentionally put the 3 masters into different states to demonstrate the 3 most likely scenarios):
$ ssh -J <bastion_host> devaccess@<master_public_ip> rhmi_check_rhsso.py
MASTER_NODE          RHSSO      SECRET
<IP_ADDRESS>         missing    n/a
<IP_ADDRESS>          found      mismatch
<IP_ADDRESS>         found      ok
overall result: fail

This script was created in response to request for new tiered access command for RHMI clusters:
https://issues.redhat.com/browse/INTLY-4960

Closing in a favor of a replacement PR to stg.


Thin out user profile

This is a step towards normalizing user profile data. Currently the user profile gets updated in the dialog engine, persisted in dynamo, and attached to each event. Scadmin then looks for user profile diffs on events to find updates.
I previously merged a pr #60 which puts user_profile_updates on the event. The naming is kind of confusing here, but I'm not too concerned about it

im less confident in this approach. the current state isnt necessarily broken, and this isnt necessarily better


Trouble linking crossplatform library 🙏

Full reproduction: https://github.com/developer239/test_cpm
Repository that I can't link: https://github.com/smasherprog/screen_capture_lite
# CMAkeList.txt

cmake_minimum_required(VERSION 3.19)
project(test_cpm)

set(CMAKE_CXX_STANDARD 14)

# CPM
set(CPM_DOWNLOAD_VERSION 0.27.2)
set(CPM_DOWNLOAD_LOCATION "${CMAKE_BINARY_DIR}/cmake/CPM_${CPM_DOWNLOAD_VERSION}.cmake")

if(NOT (EXISTS ${CPM_DOWNLOAD_LOCATION}))
    message(STATUS "Downloading CPM.cmake")
    file(DOWNLOAD https://github.com/TheLartians/CPM.cmake/releases/download/v${CPM_DOWNLOAD_VERSION}/CPM.cmake ${CPM_DOWNLOAD_LOCATION})
endif()

include(${CPM_DOWNLOAD_LOCATION})

# EXECUTABLES

add_executable(test_cpm main.cpp)

# DEPENDENCIES

CPMAddPackage(NAME spdlog GITHUB_REPOSITORY gabime/spdlog VERSION 1.7.0)

CPMAddPackage(
        NAME Screen_Capture
        GITHUB_REPOSITORY smasherprog/screen_capture_lite
        GIT_TAG 17.0.3
)

target_link_libraries(test_cpm spdlog Screen_Capture)

# main.cpp

#include <spdlog/spdlog.h>
#include <Screen_Capture.h>

int main() {
    spdlog::info("Hello world!");
    return 0;
}

Log:
Maybe I misunderstood how does the linking work? 🤔  I had very similar problem with opencv.
fatal error: 'Screen_Capture.h' file not found
#include <Screen_Capture.h>

Change this code line:
target_link_libraries(test_cpm spdlog Screen_Capture)

to
target_link_libraries(test_cpm spdlog screen_capture_lite)

@Andres6936 I already tried most of the combinations but none of them worked. 🙁
Here is the commit: https://github.com/developer239/test_cpm/commit/7bb41f9816d52688f5354c6517d1264a5a480c7e

One of the problems you have is trying to use a repository with a bad CMake support, that is the root of the problem you have, with the previous comment you have already solved the problem of the undefined references, now you have the problem of locating the headers that your project needs.
I also had the same problem with libgit2, the way to solve it is to include the path where those headers are located, how, I explain with the example:
Look at the CMake of this repository, and the structure of the libgit2 project.
As I mentioned in the Wiki of this project, the correct project structure is not followed to the letter by libgit2, hence I must maneuver the problem with CMake, how? Simple, telling CMake and therefore CLion where to locate the headers (in this particular case is the main header, but applies to any other case).

Para tu caso, el CMake de tu proyecto debe de verse así:
cmake_minimum_required(VERSION 3.19)
project(test_cpm)

set(CMAKE_CXX_STANDARD 14)

# CPM
set(CPM_DOWNLOAD_VERSION 0.27.2)
set(CPM_DOWNLOAD_LOCATION "${CMAKE_BINARY_DIR}/cmake/CPM_${CPM_DOWNLOAD_VERSION}.cmake")

if(NOT (EXISTS ${CPM_DOWNLOAD_LOCATION}))
    message(STATUS "Downloading CPM.cmake")
    file(DOWNLOAD https://github.com/TheLartians/CPM.cmake/releases/download/v${CPM_DOWNLOAD_VERSION}/CPM.cmake ${CPM_DOWNLOAD_LOCATION})
endif()

include(${CPM_DOWNLOAD_LOCATION})

# EXECUTABLES

add_executable(test_cpm main.cpp)

# DEPENDENCIES

CPMAddPackage(NAME spdlog GITHUB_REPOSITORY gabime/spdlog VERSION 1.7.0)

CPMAddPackage(
        NAME SCREEN_CAPTURE
        GITHUB_REPOSITORY smasherprog/screen_capture_lite
        GIT_TAG 17.0.3
)

target_include_directories(test_cpm ${SCREEN_CAPTURE_SOURCE_DIR}/include/)
target_link_libraries(test_cpm spdlog screen_capture_lite)

@TheLartians I consider it prudent to close the incident, based on the inactivity of @developer239

@Andres6936 I appreciate the time you took to answer my question and I will take a look at it again later this week. Changes you proposed didn't fix the problem but I guess we can close this issue because it is not related to CPM directly.

Thanks to you, we are here to help you.

You are right, brew can simplify a lot the dependency process with OpenCV, you don't need CPM in this case, on the other hand, a good starting point is to structure your project, I had already written it in the Wiki, and there is even a basic template with the necessary structure, once you complete this step we will continue with the other one.


Multiple msgs

@ronish31 please review.
@shalper could you do a quick review of the readme changes?
Thanks

@shalper eventually we made changes in the cloudformation automation section that should be applied to the  docs as well


FIX: Try to unpin mpich after new version available.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Trying to unpin after work done for https://github.com/conda-forge/mpich-feedstock/issues/56

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Rebased to pick up the latest release info.

Rebased to pick up the latest release info.

The mpich fix is in, let's give it a shot
@conda-forge-admin, please restart ci

@leofang it looks like it did it! Thanks for restarting CI here.

Cool! Perhaps you'd like to clean up the workarounds you added (fake-bin etc)?

I will try to remove the fake-bin one but it was related to osx issue with cc1 that was not found somehow.

Ah I see, I thought it was for fixing the OS X build. nvm then.

@leofang for reference, the cc1 issue comes from here: https://github.com/conda-forge/gfortran_osx-64-feedstock/issues/11 and the workaround from here https://github.com/awvwgk/staged-recipes/tree/dftd4/recipes/dftd4


chore: upgrade rusty_v8 to 0.93.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.47%. Comparing base (0c7f83e) to head (121871f).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   81.43%   81.47%   +0.04%
==========================================
  Files          97       97
  Lines       23877    23951      +74
==========================================
+ Hits        19445    19515      +70
- Misses       4432     4436       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Change in behavior of tab-completion

System Details

posh-git version/path: 1.1.0
PowerShell version: 7.4.5
git version 2.46.0.windows.1
OS: Microsoft Windows NT 10.0.22631.0

Issue Description
I am not sure this is a posh-git issue but I could replicate it on both pwsh (with oh-my-posh) and powershell (clean)
The issue is simple: autocompletion used to be smart about files.
e.g.
$ git status
On branch yarp-entrypoint
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   tools/AppHost/AppHost.csproj
        deleted:    tools/AppHost/Extensions/YarpResourceExtensions.cs
        modified:   tools/AppHost/Program.cs

no changes added to commit (use "git add" and/or "git commit -a")

If I start typing git add <tab> I used to be able to cycle through the dirty files and pick which one I wanted to add. Now instead it cycles through all files and directories, even .git/
This behavior has changed recently and I am trying to understand what caused it and how to revert it because it seriously affects my workflow.

I had the same issue while using oh-my-posh. Changing the source property from cli to pwsh for the git segment helped.

Hi! @KlemensE , could you specify what do you mean by "source"?

See https://ohmyposh.dev/docs/segments/scm/git under Properties you can find source wich should have the value pwsh to make it work again.
This is because the autocompletion evaluates based on the global variable $GitStatus. This value comes from the Get-GitStatus function. This variable is probably not set correctly.

oh-my-posh checks a global variable, if posh-git is enabled.
See https://github.com/JanDeDobbeleer/oh-my-posh/blob/main/src/shell/scripts/omp.ps1#L189
For my workaround, I simply added the following to my PowerShell profile:
# ... load oh-my-posh
# ... load posh-git
$Global:_ompPoshGit = $true

I'll be honest, I don't understand how omp is involved with the tab suggestion issue.

As I understand, it's because posh-git uses the structure that is stored in the global variable $GitStatus, as mentioned above.
The value of $GitStatus is updated as part of "rendering" the prompt, whenever you change directory.
You can run the command Get-GitStatus from any git repository, to see what that data looks like.
When you also use oh-my-posh at the same time, oh-my-posh is taking over the prompt rendering, and as such, it needs to update the $GitStatus variable for you. posh-git's prompt function is no longer being invoked.

$Global:_ompPoshGit = $true

This is what worked for me.

@KlemensE's solution worked for me. Thanks a lot. I also cannot understand why is oh-my-posh involved in git completions, but changing that property solved my problem.