Enable remote signing service

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "enable-remote-signer" git@github.com:RichardScothern/notary.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Richard is #winning :-)
LGTM

p.s. merge at your own discretion


demo/demo doesn't work ... redirects to /login/

When I try accessing the :16649 Iris login, it just redirects me back to login every time.  Disable in production
  local_api_url: http://localhost:16649

The reason you see this is because we use cookies for auth, and you're likely currently hosting Iris via http. We set secure=True on the cookie, so it is only passed on https requests unless explicitly enabled with allow_http.

Hello there, we're trying the solution with the docker-compose option and we can't seem to log in to the demo. The frontend is up, but any user/password combination gives a 404 error.
I'm using the exact same settings dwan159 posted. The documentation on this is scarse at best... should I be using a user from an integrated LDAP or the admin tool to log in?

You can use either. The admin tool is likely easier to set up than LDAP. We suggest demo/demo since the dummy data includes the demo user by default. Check the user table in the DB, and use any username that appears there.

I hit the same issue. The problem I had was revealed by the nginx and uwsgi logs in the iris container. If you look at cat var/log/{nginx,uwsgi}/*.log during the login you'll see the problem. In my case it was uwsgi workers silently segfaulting (and nginx returning a 404 since a uwsgi worker prematurely closed the connection), which was caused by a dependency mismatch: bumping greenlet to a compatible version fixed the issue for me.


chore(ci): check GitHub Action workflow files via actionlint

https://github.com/rhysd/actionlint

Going to close this one, it's something very trivial.


Web demo stops repainting after clicking

Describe the bug

On the web demo, the UI stops repainting after you click anywhere, and only starts again when you move the mouse. Also, when you press Ctrl+C, it pauses for a fraction of a second. This does not affect the native desktop demo.
To Reproduce
Steps to reproduce the behavior:

 Open the web demo

 Select continuous mode or open something that is animated, like plot demo or the fractal clock

 Click anywhere on the screen and leave the mouse completely still

 The UI stops repainting until you move the mouse

Expected behavior

The UI should continue to repaint as normal after clicking or pressing Ctrl+C.
Screenshots

https://github.com/emilk/egui/assets/43298013/1a65462c-9c13-4d17-b797-5d5bd6ee3bd6
Desktop (please complete the following information):

OS:  Fedora 38, Windows 11
Browser  Firefox
Version  120

Smartphone (please complete the following information):
(not tested)
Additional context

This seems to have been caused by #3623.

I believe this is the same as another phenomenon I just observed: collapsing header need the mouse to move around to complete animation:
https://github.com/emilk/egui/assets/49431240/59230598-78d3-4e14-a5ef-30506646d302

Yes, one effect of that is that all animations freeze when you click. My guess is that the click event resets the "needs_repaint" flag somehow, no matter how many widgets called request_repaint on that frame. And so it doesn't repaint again until it gets an input event. There are a lot of changes in that PR related to that, but I don't understand it well enough to see where the problem is.
Note that this bug is not in the 0.24 release AFAICT, as it was introduced yesterday just after the release.


Update trigger-travis.sh for Ubuntu 20.04

Summary
Add release to travis for latest Ubuntu LTS 20.04

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I close this as we have moved to Github Actions and do not use Travis anymore. @ducksecops, please let me know if this was a wrong thing to do, or anyone else, perhaps @hutchic, and please ask for reopining.


feat: add custom jsonrpc client based on surf

https://github.com/nervosnetwork/lumos/issues/6
A simple jsonrpc client implementation based on surf client.
status: WIP, need to fix the BlockView 's Deserialize issue, and move forward to replace the old jsonrpc-http-client.

@quake Please ignore this PR, this is a communication issue, the code is never intended to be submitted here.


improvementSupport drop cached stats.

Support drop cached stats. Usage:
drop cached stats table_name

run buildall

run performance

run cloud_p1


Override root directory used by FastCGI

The FastCGI module uses the vhost root directory here, here, and here*. This creates issues when the FastCGI server is on another host and/or within a container where the directory structure may be different. Ideally, we'd offer a way to override the root directory used by FastCGI, with it defaulting to the vhost root directory.
root /usr/htdocs
fastcgi / otherserver:9000 php {
  root /var/www
}

* - It also uses it here, but that's not contributing to this issue.

I'll guess you can overwrite it ?
env sets an environment variable named key with the given value; the env property can be used multiple times and values may use request placeholders.

env DOCUMENT_ROOT /path/to/root/
env PATH_TRANSLATED {file}

I banged my head against that wall for a while without any luck. PATH_TRANSLATED is tricky because you don't have access to the post-split-processed filename. Perhaps I was doing something wrong, I'll give it another try...

Reading the link inside the source
 Instead of using the PATH_TRANSLATED environment variable, you can use a combination of PATH_INFO and DOCUMENT_ROOT, which contains the physical path to the document root directory. The variable PATH_TRANSLATED is equal to the following statement:

$path_translated = join ("/", $ENV{'DOCUMENT_ROOT'}, $ENV{'PATH_INFO'};

However, the DOCUMENT_ROOT variable is not set by all servers, and so it is much safer and easier to use PATH_TRANSLATED.

so PATH_TRANSLATED is root+path after file?
{path} - The path portion of the URL (does not include query string or fragment) ?

You're asking me? 😆 The problem is that:

You can't (easily) set PATH_TRANSLATED because you don't have access to the post-split-processed pathInfo.
You might think, "Oh, I'll just set DOCUMENT_ROOT and PATH_INFO and let the FastCGI server figure it out," but if PATH_INFO is set, Caddy will use the "wrong" root directory, and send a bad PATH_TRANSLATED to the FastCGI server anyway.
We also still have to set SCRIPT_FILENAME...

Sure, then lets implement a correct fix for that. :+1:

Sounds good. 😄 Would you please take a look at my PR (#1337) and let me know your thoughts?

Implemented in #1337. Thank you!


fix: universal compaction condition

close https://github.com/skyzh/mini-lsm/issues/96
the original condition was not very correct and would produce larger write amplification, so we make it exactly the same as RocksDB in this PR. TODO: fix doc and tests.

I have another question. In Reduce Sorted Runs parts, RocksDB will compact at most max_merge_width tiers into one tier (docs and example). This also seems to reduce write amplification significantly.
cargo run --bin compaction-simulator tiered --dump-real-id --num-tiers 8 --iterations 200 (parameters same as RocksDB):
this PR
=== Iteration 199 ===
--- After Compaction ---
L1716 (42): [...]
L808 (6): [808, 809, 810, 811, 812, 813]
L787 (10): [787, 788, 789, 790, 791, 792, 793, 794, 795, 796]
L753 (15): [...]
L703 (21): [...]
L634 (28): [...]
L501 (78): [...]
--- Statistics ---
Write Amplification: 1757/200=8.785x
Maximum Space Usage: 242/200=1.210x
Read Amplification: 7x

Full Output: pr.txt
my impl similar to RocksDB:
=== Iteration 199 ===
--- After Flush ---
L753 (1): [753]
L748 (5): [748, 749, 750, 751, 752]
L722 (21): [...]
L653 (28): [...]
L453 (145): [...]
--- Statistics ---
Write Amplification: 753/200=3.765x
Maximum Space Usage: 290/200=1.450x
Read Amplification: 5x

Full Output: self.txt

The reason I didn't merge this patch is that I don't fully understand why RocksDB produces that sequence -- I think we got the first few lines correct, but looking at the example,
https://github.com/facebook/rocksdb/wiki/Universal-Style-Compaction-Example
it allows > 8 tiers
1 2 3 4 5 6 7 55   (after flush)
1 1 2 3 4 5 6 7 55   (after flush)
29 55   (after compaction)
1 29 55   (after flush)

before doing the compaction, which gives 29; while in my implementation, it gives 28
Looking at https://github.com/facebook/rocksdb/wiki/universal-compaction,
1 16  (no compaction triggered)
1 1 16  (no compaction triggered)
1 1 1 16  (no compaction triggered)
1 1 1 1 16  => 4 16
1 4 16  (no compaction triggered)
1 1 4 16  (no compaction triggered)
1 1 1 4 16 => 3 4 16
1 3 4 16  (no compaction triggered)
1 1 3 4 16 => 2 3 4 16
1 2 3 4 16  (no compaction triggered)
1 1 2 3 4 16 => 11 16

it also indicates the same -- even if it triggers at tier == 5, the number of tiers can stay at 5 in some conditions.
so I'd like to reproduce their algorithm and check if it reduces write amplification (my intuition is yes b/c they do fewer compactions).

after looking at it for a while, I assume it's a typo, though I suppose their example should be generated with some tools, but I couldn't figure out a reasonable logic for that 🤪

I've updated my implementation to take max_merge_with for reducing sorted runs and I'll merge the patch; meanwhile, I'll update the docs in another patch. Thanks for the suggestion anyways :)

The reason I didn't merge this patch is that I don't fully understand why RocksDB produces that sequence -- I think we got the first few lines correct, but looking at the example,

I also guess it's a typo. I asked it at mail channel, but no response.


Export RouterResolve type?

From this example:
<router-link :to="(resolve) => resolve('home')">Go somewhere</router-link>

If the function body passed to :to is long (like when we need to pass a long option), it is better to move to a TS code like:
const homeUrl = (resolve) => resolve('home', ...)

But the issue that I don't know to  type-annotate resolve, because the RouterResolve is not exposed.

Found the solution, that is, if I define the routes in routes.ts:
const routes = []

export const router = createRouter(routes)

I need to add one line at the end of file:
export type RouterResolve = typeof router.resolve

@hongquan yep that definitely works!
Another suggestion would be to just use the router's resolve itself for the to prop value if you're defining it in a component context.
const router = useRouter()

cont to = computed(() => router.resolve(...))

Since router ultimately just wants a string. The callback is just a convenience for type safety.

Yes. It is shorter.

Glad you were able to figure it out. And thanks for opening an issue! Please let us know if you have any feedback in general, we'd love to hear your thoughts

@pleek91 I have just tried the computed approach. It is denied by <RouterLink />  because the return typed of router.resolve is string, which doesn't match to expectation (Url or callback).


how can I debug a Dreamview demo in vscode?

I can run a Dreamview demo <demo_3.5.record>, but I can't enable SimControl, so I can't find the planning process.how can I debug a Dreamview demo in vscode?

What do you mean you can't enable SimControl? Any error messages shown?
In addition, playing back demo record doesn't need to enable SimControl or planning module. May we know what you are trying to achieve?

reference to https://github.com/ApolloAuto/apollo/blob/master/docs/howto/how_to_build_and_debug_using_vscode.md
I want to debug a demo remotely using vscode. According to the above link, I need to find the planning process in the process list, which is the binary file I need to debug. But I cannot find him. So I doubt if I cannot enable SimControl, like this:

Sim Control might be enabled if you try shifting Lock Task Panel to the other side?

It does not respond. I want to know whether it must be running on the hardware platform to debug, or any demo would do？

Hi @rimu123

SimControl is part of the Dreamview feature that simulates a SDC's control module, and moves the car based on planning result. This is a convenient way to visualize and test planning module. However, since this is part of the Dreamview feature, turning on sim control won't help finding planning process.

As explained in the document you pointed out, to find the planning process id, we need to toggle the "Planning" option from "Module Controller". Only after the planning module is on, you will be able to find its process.

The document is about debugging planning module which publishes planning/control/etc data in realtime; while playing the 3.5 demo bag publishes recored planning/control data in the demo bag. You might not want to do both at the same time.

Hi @rimu123
1. SimControl is part of the Dreamview feature that simulates a SDC's control module, and moves the car based on planning result. This is a convenient way to visualize and test planning module. However, since this is part of the Dreamview feature, turning on sim control won't help finding planning process.

2. As explained in the [document](https://github.com/ApolloAuto/apollo/blob/d669dd84e626e97e45efca8b73dd0caeb8423cc1/docs/howto/how_to_build_and_debug_using_vscode.md) you pointed out, to find the planning process id, we need to toggle the "Planning" option from "Module Controller". Only after the planning module is on, you will be able to find its process.
   ![Screen Shot 2020-06-22 at 1 12 09 PM](https://user-images.githubusercontent.com/2775888/85330859-fc061e00-b489-11ea-9464-63f70d04e7a4.png)

3. The document is about debugging planning module which publishes planning/control/etc data in realtime; while playing the 3.5 demo bag publishes recored planning/control data in the demo bag. You might not want to do both at the same time.

Hi vlin17,
Did you try the VSCode debugging method that was mentioned in this doc to debug the PLANNING module?
I did and I ran into the following error : https://youtu.be/d9vcRATc3M0(Youtube video) and opened the following issue :
https://github.com/ApolloAuto/apollo/issues/11107.
I would like to know if you are facing a similiar problem ?

The control button can break the point, while the other buttons can not be paused, because I have an error when running, so I can not determine whether it can not break the point.


COMPRESS-497 Handle missing endheader offset

Detect incomplete header (all zero bytes)
Try to guess end header by trying to parse the file at the end

Coverage increased (+0.02%) to 86.774% when pulling b1276999239851be5337708210c69df73de92434 on Skyr:master into 205876d6f9eb60ac31f3ec848b23d025f32995ab on apache:master.


Exposes several parameters from the somatic LLR filter

This enables tuning the pipeline to be appropriate for low-purity tumors
The somatic pipeline test runs successfully, with or without these params specified.

Update with whitespace fix


Created PagerIndicator

TO-DO
Table of Contents

[x] Identify the component the PR relates to in brackets in the title.
PagerIndicator
[x] Sign the CLA bot. You can do this once the pull request is opened.

Contributing
has more information and tips for a great pull request.

@zeobot set lc to pass


Gftools builder cleanup

Fixes https://github.com/googlefonts/gftools/issues/290

[x] Add log message to say "All done!"
[x] Add --no-clean-up argument and clean up instance_ufos/  by default

Thanks!

Thanks!


mergeData in 2.19.0 overwriting brain roles set by HUBOT_AUTH_ROLES

Roles set by HUBOT_AUTH_ROLES is being overwritten by robot.brain.mergeData.
Possibly same issue as #846
Using
hubot 2.19.0
hubot-auth 1.3.0
hubot-redis-brain 0.0.3

I have my ID in the environment variable
HUBOT_AUTH_ROLES="admin=xxxxxxxx staging=xxxxxxxx"
In hubot-auth/src/auth.coffee after line 56 I added lines to show my roles.
          user.roles.push roleName unless roleName in user.roles
          user2 = robot.brain.userForName('toddwells')
          robot.logger.info "ROLES-AUTH: #{JSON.stringify(user2.roles)}"

in hubot-redis-brain/src/redis-brain.coffee at line 48 I added the same before and after the redis merge
        user2 = robot.brain.userForName('toddwells')
        robot.logger.info "ROLES-REDIS-PRE: #{JSON.stringify(user2.roles)}"

        robot.logger.info "hubot-redis-brain: Data for #{prefix} brain retrieved from Redis"
        robot.brain.mergeData JSON.parse(reply.toString())

        user2 = robot.brain.userForName('toddwells')
        robot.logger.info "ROLES-REDIS-POST: #{JSON.stringify(user2.roles)}"

The results show that I have the expected roles before the merge but not after
[Fri Jul 29 2016 15:37:46 GMT+0000 (UTC)] INFO Connecting...
[Fri Jul 29 2016 15:37:47 GMT+0000 (UTC)] INFO Logged in as xxxxx of xxxxxxxx, but not yet connected
[Fri Jul 29 2016 15:37:47 GMT+0000 (UTC)] INFO Slack client now connected
[Fri Jul 29 2016 15:37:48 GMT+0000 (UTC)] WARNING Loading scripts from hubot-scripts.json is deprecated and will be removed in 3.0 (https://github.com/github/hubot-scripts/issues/1113) in favor of packages for each script.

Your hubot-scripts.json is empty, so you just need to remove it.
[Fri Jul 29 2016 15:37:48 GMT+0000 (UTC)] INFO ROLES-AUTH: ["admin","staging"]
[Fri Jul 29 2016 15:37:48 GMT+0000 (UTC)] INFO hubot-redis-brain: Using default redis on localhost:6379
[Fri Jul 29 2016 15:37:48 GMT+0000 (UTC)] INFO ROLES-REDIS-PRE: ["admin","staging"]
[Fri Jul 29 2016 15:37:48 GMT+0000 (UTC)] INFO hubot-redis-brain: Data for hubot brain retrieved from Redis
[Fri Jul 29 2016 15:37:48 GMT+0000 (UTC)] INFO ROLES-REDIS-POST: undefined

@twellspring may be use here lodash.merge package ?
https://www.npmjs.com/package/lodash.merge


Embedded mode update

Panels:

Spectra
Information
Peaks
Processings
Integrals
Ranges
Assignments
Chemical structures
Summary

Side panel (default):

Should be open: True
Width: 180px

Float structure:

If a molecule is present, float it by default

we can not float the molecule by default from the workspace, it is a different story that we control from the view object, I will see how I can do it.

This is now moved to nmrxiv workspace

Additional configuration

Disable Peaks/Integral tools
Disable Peaks/Integral panels

Hide all options except full screen


feat(AuditLogChangeData): Add communication_disabled_until

Please describe the changes this PR makes and why it should be merged:
Adds communication_disabled_until to the audit logs.
Reference Discord API Docs PRs or commits:
N/A

Can it be null too?

Not that I can see. Disabling a guild member's communication gives this:
{
  key: 'communication_disabled_until',
  old: undefined,
  new: '2021-12-27T16:08:10.740000+00:00'
}

Whilst removing it manually yields:
{
  key: 'communication_disabled_until',
  old: '2021-12-27T16:08:10.740000+00:00',
  new: undefined
}

Right.....the quirk I documented


How to keep wallet connection persistent when refreshing with MeshJS

Hello Eveyone
Do you know How to keep wallet connection persistent when refreshing with MeshJS?
Please guide us

many ways to do that, one way to use localstorage to remember which wallet to re-connect after refreshing https://www.w3schools.com/jsref/prop_win_localstorage.asp.


新增rpc接口，智能合约开发详解

新增rpc接口，智能合约开发详解

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: qizheng09:x: KenianShiYou have signed the CLA already but the status is still pending? Let us recheck it.


feat(api): set up google cloud profiler

https://github.com/google/osv.dev/issues/2793
This PR attempts to set up Google Cloud Profiler following this guide.

Related https://github.com/google/osv.dev/pull/1305 . I've added google cloud profiler in that PR before, it didn't work that well when used with appengine, though maybe now that it is running in cloud run it will work better.
Looking at the commit history, it looks like you should use the wheel version: https://github.com/google/osv.dev/pull/1305/commits/5ef22aaab708df7fc91f0472c603caf3c7ea1018

since we are with Cloud Run instead of App Engine now, maybe let's try with the default version first?


Add sb-sidenav-primary style

We want to have a style that uses the primary color (blue, in this case) as the background color for the sidenav.
To use, just add sb-sidenav-primary to existing sidenav.
New Style:

Original:

just a thought about handling branches: perhaps the changes that bring back the sb-admin-2 theme styles could be kept here in this branch, without creating a PR against the master branch. This would allow us to create a PR against the upstream repo, so that if anyone else using the sb-admin theme/template finds it handy, it would be our contribution to the community?
Or we could do both, create a PR against the upstream repo, but also pull into the master branch here and do any further development that is specifically for the LitCal project in the master branch after the general "community" fixes are in place. Thoughts?


Cannot Run imogene Vignette (Tutorial)

@Bozorgui There were two problems here with the vignette:
https://github.com/korkutlab/imogene/blob/master/vignettes/imogene-vignette.Rmd
the first I fixed and committed back.

The vignette need to have r in curly braces (see below) to actually work as a functional notebook. I committed this change.

#```{r}
#  cat("HELLO")
#```

The code within the vignette does not work. When I run the vignette code, I get this error:

Error in im_syng_tcga(onco_gene = my_onco, icp_gene = my_icp, cohort = my_cohort,  :
  argument 6 matches multiple formal arguments

N_iteration maps to multiple parameters

@Bozorgui the vignette runs, but the boxplot example confuses me. Why do you switch to TGFB1 and CD27 when the earlier analysis was done on other genes?
im_boxplot_tcga(onco_gene = "TGFB1", icp_gene = "CD27", cohort = "luad", Immune_phenotype = "IFNGscore")

@cannin The vignette focuses on all pairs of  c("TGFB1","TGFB2","TGFB3") and icp_gene_list in "luad".  CD27 is one of the icp_gene_list and TGFB1 one of the three oncogenes.  Maybe you mean the analysis done in the paper? Could you please point me to the  analysis you mean?

Your tutorial never shows the icp_genes or mentions that CD27 is in the list. Or maybe it's there, but was not obvious.
For simplicity, why not just boxplot with inputs "TGFBR1" and "TGFBR2"?


Update README.md to indicate that lambda layer collector can also work with natively compiled lambdas

Description:
Update wording on the different lambda layer collectors, to indicate that the general collector layer will also work with natively compiled lambdas that have preexisting instrumentation.
Link to tracking Issue:
Testing:
Documentation:
Update wording on the different lambda layer collectors, to indicate that the general collector layer will also work with natively compiled lambdas that have preexisting instrumentation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for the PR, can you please resolve the conflicts?

Thanks for the PR, can you please resolve the conflicts?

The conflicts are resolved now.

Second this, would prevent alot of confusion


[Question] Parameters used by VSCode to call alc.exe

Describe the bug
We've a project with 4500+ objects, that is compiled quite fast via VS Code on our buildserver, with all codeAnalyzers enabled. Even with the appSourceCop.json containing a the "version" parameter, referencing a previous app file (approx. 30 Mb size) in .alpackages, all compiles with 1 - 1'30 minutes.
Making use of ALOps for our CI/CD, for the compile step, they issue a similar statement to the alc.exe to achieve the same: compiling a /project with the /al_analyzers, referencing a /package cache path, .... However, this takes either 10+ minutes or just simply fails if the 'AppSourceCop' analyzer is enabled (almost everytime an error is show that the app with version X referenced by AppSourceCop.json could not be found in the .alpackages folder, altough it is located in that location).
Possibly because we're referring to the previous app file by including it in the /alpackagecache folder.... Although it's a guess. Apparently, there might be some 'hidden' parameters on the alc.exe to reference the previous app file. Or we might not make full use of the parallel or  maxdegreeofparallelism parameters.
Expected behavior
Our questions are, to ease the troubleshooting when working directly via alc.exe:

Is there an (easy) way to verify the parameters that are passed by VSCode to alc.exe upon packaging?
Is there a log file where we can trace the actual alc.exe statement that is raised by VSCode for AL: Package?

VSCode does not call alc.exe when packaging. It completes the background compilation and generates a package. Which version of the alc.exe are you using in your pipeline? Is it the one from the VSIX?

I've used vsix version 5.3 (BC 16.3), 6.1 (BC 17) and 7.0 (insider), all resulting in the same issues.
I might have been wrong in linking 'Package' with alc.exe (in my case in VS Code, the background compilation was disabled).
Waldo is facing the same and trying to find out what's wrong in the meanwhile. Nevertheless, it would be interesting if we could see which parameters the 'background compiler' receives.

We've identified an issue in AppSourceCop and we will be releasing an update later this month where the performance will be improved significantly. If you could show me what switches you are using for alc, I could tell you if anything stands out, but I don't think the difference in perceived performance comes from there. The background compilation caches a lot of artifacts and when you press "build" it only completes the compilation and creates the output package.

Some background (#https://github.com/HodorNV/ALOps/issues/248)
Alc switches used, with packagecachepath containing the previous app version and AppSourceCop refering to it with the 'version' parameter.
C:\bcartifacts.cache\onprem\16.3.14085.14238\VSIX\extension\bin\

& alc.exe /packagecachepath:"C:\Temp\x\App\.alpackages" /project:"C:\Temp\x\App" /out:"C:\Temp\a\xNavitrans_Core_<IP_ADDRESS>39_OnPrem_16.3_w1.app" /fullpaths /analyzer:"C:\bcartifacts.cache\onprem\16.3.14085.14238\VSIX\extension\bin\Analyzers\Microsoft.Dynamics.Nav.CodeCop.dll","C:\bcartifacts.cache\onprem\16.3.14085.14238\VSIX\extension\bin\Analyzers\Microsoft.Dynamics.Nav.UICop.dll","C:\bcartifacts.cache\onprem\16.3.14085.14238\VSIX\extension\bin\Analyzers\Microsoft.Dynamics.Nav.AppSourceCop.dll" /ruleset:"C:\Temp\x\App\.vscode\nvt.ruleset.json" /errorlog:"C:\Temp\x\App\error.log"

cd "C:\Users\fvet\.vscode\extensions\ms-dynamics-smb.al-6.1.359074\bin"

& alc.exe /packagecachepath:"C:\Temp\x\App\.alpackages" /project:"C:\Temp\x\App" /out:"C:\Temp\x\xNavitrans_Core_<IP_ADDRESS>39_OnPrem_16.3_w1.app" /fullpaths /analyzer:"C:\Users\fvet\.vscode\extensions\ms-dynamics-smb.al-6.1.359074\bin\Analyzers\Microsoft.Dynamics.Nav.CodeCop.dll","C:\Users\fvet\.vscode\extensions\ms-dynamics-smb.al-6.1.359074\bin\Analyzers\Microsoft.Dynamics.Nav.UICop.dll","C:\Users\fvet\.vscode\extensions\ms-dynamics-smb.al-6.1.359074\bin\Analyzers\Microsoft.Dynamics.Nav.AppSourceCop.dll" /ruleset:"C:\Temp\x\App\.vscode\nvt.ruleset.json" /errorlog:"C:\Temp\x\App\error.log"

There is nothing wrong with the switches. I think the root cause was a lack of caching in AppSourceCop. The fix should be released within 2 weeks to the insider preview.

@atoader Any plans to backport this to marketplace soon?
When running the alc from the insider vsix, seems like something has been fixed, at least it works for one of our smaller projects.

First tests using vsix <IP_ADDRESS>790 on our larger Base app seem promising too. Got the compiler time down to +- 3 minutes.


page navigations for tools training

looks like though the links work locally, they are broken with this build. Anyone has an idea why?

Yay, the links work!


Box folder clean up

Objectives
This epic is to look at how we are using Box folders and clean up, merge, and set up for 2021.
The three folders
We have three Box folders that we have accumulated.

Carbon for IBM.com
IBM Digital Design
IBM Digital Design squad

And we are using these three folders in an inconsistent way. Let's take a look at whether we need all three, and if we do, let's try to define what each folder does and does not.
Layout components
Since the restructuring of the UI components and layout components, we have the layout components stored separately. Also within layout components folder, we have block, section, and subpattern folder structures. Let's look at how we can merge or restructure these.
One thought from Wonil: I still think that there is a great value in separating UI components from layout components.
Each component folder structure
We agreed on a subfolder structure for each component to be one way, but it seems that we identified additional needs and the need to update our model.
Anything else?

I'd suggest a parent folder of Components with separate folders for UI components and Layout components

Agreed with @oliviaflory, especially the list of the Components are getting longer and longer.

@shixiedesign FYI on this Epic.


Error "ReferenceError: can't access lexical declaration `XXX' before initialization" when loading a webpack-ed app

Bug report
What is the current behavior?
When loading the home page, we get this error in the browser's console:
ReferenceError: can't access lexical declaration `reportTrackThreadHeight' before initialization app.js:1
    js app.js:1
    js TrackThread.js:243

This happens both in Firefox and Chrome (the error message is slightly different in Chrome).
This also happens in a dev server, or when building and loading the built app, both in dev and prod mode.
If the current behavior is a bug, please provide the steps to reproduce.
STR:

clone https://github.com/julienw/perf.html.git
switch to branch webpack-bug
run yarn install
run yarn start
open http://localhost:4242

=> notice the error in the console log
Steps 1 to 4 in a few commands:
git clone https://github.com/julienw/perf.html.git
cd perf.html
git checkout webpack-bug
yarn install
yarn start

Sorry this isn't quite a minimal testcase, but I believe the problem comes from some form of dependency mismanagement and the problem might not happen with a smaller testcase.
My initial theory is that the problem comes from ModuleConcatenationPlugin hoisting  this function where it shouldn't, but the problem happens in dev mode as well, where ModuleConcatenationPlugin shouldn't be configured by default. So I'm a bit confused here.
Other useful commands are:

yarn build => builds a development bundle to dist/
yarn build-prod => builds a production bundle to dist/

What is the expected behavior?
There's no error in the generated bundle and we should be able to load the homepage without an error.
Other relevant information:
webpack version:  4.32.1
Node.js version:  v10.15.1
Operating System: Linux
Additional tools: --

I had the same error today. I managed to work around it by adding plugin to .babelrc:
 "@babel/plugin-transform-block-scoping"

I think the reason for the error is that webpack generates code which tries to access const before it is declared:
/* harmony export (binding) */ __webpack_require__.d(__webpack_exports__, "CLEAR_STATE", function() { return CLEAR_STATE; });

const CLEAR_STATE = 'CLEAR_STATE';

As plugin-transform-block-scoping transforms const to var, it works around the problem.

That's what I don't get: this would be an problem if this CLEAR_STATE export was required before the const, but in our case I don't see that in the bundle. Yes, the "require function" is before the const, but the code that actually uses it is after.

This usually occurs in case of a circular dependency.
Here is a simplified example:
// app.js
import "./something";

export const VALUE = 42;

// something.js
import { VALUE } from "./app";

console.log(VALUE);

Note that this is not a webpack bug, but correct behavior according to the ESM spec.

Using @babel/plugin-transform-block-scoping won't fix the root problem. By using var instead of const you will receive undefined instead of the TDZ error. This probably lead to other issues.

Solution: Refactor your application. Try to do one of these things:

Get rid of the circular dependency, or
don't access circular exports in module evaluation

Example:
You can get rid of the circular dependency in my example by moving the constants to a new module:
// app.js
import "./something";

// constants.js
export const VALUE = 42;

// something.js
import { VALUE } from "./constants";

console.log(VALUE);

Thanks for the insight!
What's surprising in our case is that the problem appeared after removing some dependencies. So we couldn't add new  circular dependencies. But of course this  could have exposed existing ones by rearranging some order ?

For anybody coming here, the webpack plugin circular dependency could be useful.
I wonder if such a functionality couldn't be added to webpack core, if the possible outcomes are so dramatic.

/cc @sokra what do you think to add this plugin as part of core? It is not first issue about this problem?

The problem is that circular dependencies are not wrong. They only lead to problems in some cases. Adding warnings for all circular dependencies is too much.
I can look into detecting cases where we are sure that a TDZ error will be thrown, but not sure if this is possible in a safe way.

bump

Should this bug stay open ? Not sure :)

I think it can be closed

This usually occurs in case of a circular dependency.
Here is a simplified example:
// app.js
import "./something";

export const VALUE = 42;

// something.js
import { VALUE } from "./app";

console.log(VALUE);

Note that this is not a webpack bug, but correct behavior according to the ESM spec.
Using @babel/plugin-transform-block-scoping won't fix the root problem. By using var instead of const you will receive undefined instead of the TDZ error. This probably lead to other issues.
Solution: Refactor your application. Try to do one of these things:
* Get rid of the circular dependency, or

* don't access circular exports in module evaluation

Example:
You can get rid of the circular dependency in my example by moving the constants to a new module:
// app.js
import "./something";

// constants.js
export const VALUE = 42;

// something.js
import { VALUE } from "./constants";

console.log(VALUE);

I think it can be closed

thank you for your help


Record should have an isLeaf property

When using a tree grid, sometimes you might want to, for example, only show a detail popup if the user has clicked on a leaf row, and not an aggregate row. One way to do this is to check if the record has any children. The wrinkle being, if you are using a Cube and you do not query for the leaves (includeLeaves: true) you can get a row that has no children but is still an aggregate (ie it's a leaf in the store but not in the cube).
Not sure how feasible this is but would be nice to have.

This is a bit tricky, because I think don means specifically here a "Cube" leaf, but not all records come from a cube, and the term leaf has perhaps different connotations on a Store Records.
(E.g. Just a record with no children, could be anywhere in the hierarchy, depending on source data, and filtering)
I discussed with him and the cleanest way to identify an actual cubeLeaf would be something like
data.cubeDimension == null,  cubeDimension is a field  (like cubeLabel) that you can get for free on Store records created by the cube.


tf.experimental.numpy fails with plt.hist

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): using example from TF docs
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.4.0-rc4-71-g582c8d236cb 2.4.0
Python version: 3.8.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 11.0 / 8.0.4
GPU model and memory: GTX 1660 Ti, 6 GB

Describe the current behavior
Just trying to plot a histogram from a random standard normal distribution array made with tf.experimental.numpy
The code is copied from here: https://www.tensorflow.org/guide/tf_numpy
What I get is a bunch of random lines in the histogram.
The values in the random matrices AFAICT seem fine - look like a normal distribution.

Describe the expected behavior
I should get the normal distribution bell curve in the histogram image.

Standalone code to reproduce the issue
import matplotlib.pyplot as plt
import numpy as np
import tensorflow as tf
import tensorflow.experimental.numpy as tnp

# bad image - see above
labels1 = 15 + 2 * tnp.random.randn(1000)
_ = plt.hist(labels1)

# good image - see above
labels2 = 15 + 2 * np.random.randn(1000)
_ = plt.hist(labels2)

I run everything in Jupyter Notebook in Chrome.
Tensorflow is actually running on the GPU.

@FlorinAndrei,
On running the code with TF v2.4, I got the expected behavior. Please find the gist of it here.
Could you please try running the code in a new virtual environment and check if you are facing the same issue. Thanks!

@FlorinAndrei,
On running the code with TF v2.4, I got the expected behavior. Please find the gist of it here.
Could you please try running the code in a new virtual environment and check if you are facing the same issue. Thanks!

@amahendrakar  I was able to reproduce the issue(bad results) with tensorflow versions 2.3.0 and 2.4.0 in windows 10 . But the same versions produces the expected/good results when used in colab. I think this is a os specific issue. I want to contribute/help in this. Can you please giude me?

@amahendrakar  I was able to reproduce the issue(bad results) with tensorflow versions 2.3.0 and 2.4.0 in windows 10 . But the same versions produces the expected/good results when used in colab. I think this is a os specific issue. I want to contribute/help in this. Can you please giude me?

Python, CUDA, and the Python modules - are all a fresh install. I've completely uninstalled the old Anaconda and Python bits and started from scratch with the latest versions. This was literally the TF test drive I did - and it failed.
If you need me to run it with various options, capture debug logs, etc - let me know.

Python, CUDA, and the Python modules - are all a fresh install. I've completely uninstalled the old Anaconda and Python bits and started from scratch with the latest versions. This was literally the TF test drive I did - and it failed.
If you need me to run it with various options, capture debug logs, etc - let me know.

BTW, your own documentation page is now broken, it's showing the bad output:
https://www.tensorflow.org/guide/tf_numpy#numpy_interoperability

BTW, your own documentation page is now broken, it's showing the bad output:
https://www.tensorflow.org/guide/tf_numpy#numpy_interoperability

@FlorinAndrei May be this was an issue with some 2.4rc3 version but not anymore with later versions like tf-nightly or TF2.4. I have checked it with colab but will check on Windows 10 system later.
Here is a gist with tf-nightly.
I agree with you that TF website shows similar histogram as you noticed. But, when you run the code in that colab, it will show as a expected histogram. Here is the gist.
Can you please run the code with tf-nightly and TF2.4 and let us know whether the issue persists with recent versions. Thanks!

@FlorinAndrei May be this was an issue with some 2.4rc3 version but not anymore with later versions like tf-nightly or TF2.4. I have checked it with colab but will check on Windows 10 system later.
Here is a gist with tf-nightly.
I agree with you that TF website shows similar histogram as you noticed. But, when you run the code in that colab, it will show as a expected histogram. Here is the gist.
Can you please run the code with tf-nightly and TF2.4 and let us know whether the issue persists with recent versions. Thanks!

@jvishnuvardhan There's no need to speculate. Like I said at the very beginning in this discussion (please refer to the top comment), I'm using 2.4.0:
>python
Python 3.8.7 (tags/v3.8.7:6503f05, Dec 21 2020, 17:59:51) [MSC v.1928 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
2021-01-20 18:35:42.219325: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
>>> tf.__version__
'2.4.0'
>>> print(tf.version.GIT_VERSION, tf.version.VERSION)
v2.4.0-rc4-71-g582c8d236cb 2.4.0

There is no more recent version of TF available with pip:
pip install --user --upgrade tensorflow
Requirement already up-to-date: tensorflow in c:\users\flori\appdata\roaming\python\python38\site-packages (2.4.0)

I will not try tf-nightly, I don't have time for that.

@jvishnuvardhan There's no need to speculate. Like I said at the very beginning in this discussion (please refer to the top comment), I'm using 2.4.0:
>python
Python 3.8.7 (tags/v3.8.7:6503f05, Dec 21 2020, 17:59:51) [MSC v.1928 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
2021-01-20 18:35:42.219325: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library cudart64_110.dll
>>> tf.__version__
'2.4.0'
>>> print(tf.version.GIT_VERSION, tf.version.VERSION)
v2.4.0-rc4-71-g582c8d236cb 2.4.0

There is no more recent version of TF available with pip:
pip install --user --upgrade tensorflow
Requirement already up-to-date: tensorflow in c:\users\flori\appdata\roaming\python\python38\site-packages (2.4.0)

I will not try tf-nightly, I don't have time for that.

This may be a NumPy version issue. @FlorinAndrei can you tell me the NumPy version when you ran into the bad image?

The issue still occurs with the versions currently installed. I just checked moments ago. The versions are:
np.__version__
'1.19.5'

matplotlib.__version__
'3.3.4'

tf.__version__
'2.4.1'

I don't know if this will help, but I've captured the console output from Jupyter while running the failed code. Here is the output:
https://gist.github.com/FlorinAndrei/ef90e68bcb75d2d3cd64b12acb14667b

Given that this is hard to reproduce, it might help to figure out if this is a matplotlib related issue or an issue with the TF kernel. @FlorinAndrei can you print the values in labels1 and inspect the distribution to see if this is producing a reasonable set of 1000 float values. The histogram seems to show a handful of values with a count of 1 which looks broken. Also check if the dtype looks correct.
Note also that a recent change requires calling numpy.experimental_enable_numpy_behavior() to enable numpy style type promotion.

 If you're using other versions, you can keep using tnp in the old way.

Found the culprit: matplotlib 3.3.4 gives the bad image, while 3.2.2 gives the good image.

Opened a bug report with Matplotlib:
https://github.com/matplotlib/matplotlib/issues/19574

Matplotlib closed the bug report, basically saying "your output is wrong, please fix it".

FWIW (I am not a matplotlib dev) the claim isn't that the TF output format is wrong, just that the TF output format isn't numpy, which is all they claim to support.
In debugging this I did notice one difference between the numpy objects and the TF emulation, which is part of why this doesn't work as expected in matplotlib (which thinks the 1D input it gets from TF is a collection of vectors):
from collections.abc import Iterable
print(isinstance(labels1[0], Iterable))
print(isinstance(labels2[0], Iterable))

I don't know how tight of an emulation of numpy TF is aiming for, but I thought I'd mention it.
BTW it works fine with seaborn
import seaborn as sns
sns.histplot(labels1)

The problem isn't any deep incompatibility with matplotlib, just a quirk of how they detect the nested dataset format that plt.hist can accept.

The root cause is that _reshape_2D in matplotlib used to do an np.asarray on the input first but https://github.com/matplotlib/matplotlib/commit/ac018af76cae81054dd27c2d4039dfd5467a1366 removed that. Currently it still recognizes an object with a to_numpy method as numpy array, but not those with __array__, which is TF's way to emulate numpy array.


Add Open Another Pack button

Instead of having to go back to the open packs page add a button that will open the next pack a user owns

I don't think this is necessary right now.


Incompatibility with CUB

hello, when installing CUB (Combat Utility Belt), the macros stop working. Is there a solution?

CUB is changing effect name's when the option "Remove Default Status Effects".
It does not only  break macros, it breaks the effects being removed at the end of rounds too.
As a solution I recommend to disable this option on the CUB config menu while a compatibility update is baked.

Should be fixed on https://github.com/NeV3rKilL/alien-actions/releases/tag/1.5.2


Dockerized

Quick 'n' Dirty:tm: but easy to run, and can be orchestrated.
Heyo!

Hey,
I am not sure if the dockerfile should be part of this project.
But it makes sense to add something to the README.
I would add a link to your docker image (https://hub.docker.com/r/strictlyskyler/meteor-apm-server/).
And it would be great to add an example with the mongo environment vars.

Closed because of inactivity


Update cdnjs

See: https://github.com/cdnjs/cdnjs
Currently we have 0.9.0 on there.

Robin Williams<EMAIL_ADDRESS>5:45 PM (4 hours ago)
Hi James
Firstly thank you so much for the work you have done on jsPDF – I imagine there are many out there who are also grateful for what you have done (and continue to do).
Secondly, I noticed that the version on the cdnjs site is relatively out of date.
The latest version seems to be http://cdnjs.cloudflare.com/ajax/libs/jspdf/0.9.0rc1/jspdf.min.js
Is updating the cdn site something that got missed or is it intended that it should not be updated?
Thanks very much
Kind regards

This looks to be sorted :)


Empty Options must be passed

I get the following error when I call randomColor()  :
[...]/node_modules/randomcolor/randomColor.js:36
if (options.seed && !seed) seed = options.seed;
^
TypeError: Cannot read property 'seed' of undefined
The simple fix:  randomColor({})

I believe this issue was fixed with this commit.
Where did you get the copy of randomColor.js which still has this bug present? The latest version on GitHub should work

npm install randomcolor
Installed today.

(thanks for your work, btw!)

npm now has the latest, working version. I dread to think how many people have downloaded the broken one :(

Thanks for letting me know!


Integration ISSUE

Experiencing this issue have no idea of what it might be? Screenshot below:

Do you see anything in the logs?
Have you tried to remove, restart and readd it?

Closing this, see #19.


refactor: Moved lisav2 functions to a separate file

Partially addresses issue:
https://github.com/LIS/LISAv2/issues/441

This PR refactors the code so that all the methods go into their corresponding relevant file names.
Remove Libraries/Framework-Hyperv.psm1 (move the code to other files, more info below)
Remove Libraries/Framework-Azure.psm1 (move the code to other files, more info below)
Create a Libraries/LISAv2-Framework.psm1 file.
All the code from Libraries/Framework-Azure.psm1 should go into LISAV2-Framework.psm1
In Libraries/LISAv2-Framework.psm1 we should add the following methods:
Get-SecretParams (from Libraries/Framework-Hyperv.psm1)
Parse-TestParameters (from Libraries/Framework-Hyperv.psm1)
Run-SetupScript (from Libraries/Framework-Hyperv.psm1)
Create-ConstantsFile (from Libraries/Framework-Hyperv.psm1)
Run-TestScript (from Libraries/Framework-Hyperv.psm1)
Collect-TestLogs (from Libraries/Framework-Hyperv.psm1)
Run-Test (from Libraries/Framework-Hyperv.psm1)
The following methods from Libraries/Framework-Hyperv.psm1:
Enable-RootUser should go to CommonFunctions.psm1
Create-HyperVCheckpoint should go to HyperV.psm1
Create-HyperVCheckpoint should go to HyperV.psm1
Check-IP should go to HyperV.psm1

@ader1990 This PR shows files renaming and parts are moving to another file. What is your purpose for this change?


replace perl based c_rehash with compatible bash alternative

when openssl is packaged in popular distributions, it depends on perl, only because c_rehash has a dependency on it.
While keeping perl required for building is fine - it shouldn't be a dependency once openssl has been installed by the user. This PR fixes that by rewriting c_rehash in bash

We already have a C based rehash, available via the OpenSSL app without any perl dependency:
https://github.com/openssl/openssl/blob/master/apps/rehash.c
https://www.openssl.org/docs/man1.1.1/man1/openssl-rehash.html

okay, somehow I missed that.
I'm fine with rejecting this PR, I'll look into poking a few distros to use that instead
Thanks

Thanks for taking the time to look at this.

Maybe it could be replaced by a tiny /bin/sh script that just calls openssl rehash, thus removing code duplication between the perl script and the C version. :)

No. Just use openssl rehash then and don't cripple the fallback for those platforms that don't have sh or derivatives thereof.
(although, it may be that we can throw away c_rehash completely. I plan on checking that)

Dropping it might be another solution. I was thinking that if it was being kept for compatibility with programs that expected the c_rehash command name, then reimplementing it as a shim might be useful to both get rid of perl at runtime, and keep the old command name.
Platforms without /bin/sh, I assume you mean exclusively Windows? I don't think Windows has perl either... you can of course install either perl or an sh implementation as a thirdparty application on Windows, but /bin/sh is kind of... ubiquitous on POSIX operating systems?
...
One other interesting approach, again, iff you need to keep compatibility with command names but feel comfortable assuming openssl rehash works everywhere, would be to teach the openssl tool to recognize when it is called via the name "c_rehash", and automatically invoke the rehash subcommand. Busybox does the same sort of thing for invoking its applets, for example.

The platform I'm thinking of is VMS. And you must install perl there as well, but that's a much more accessible scripting language than any sh derivative.

The platform I'm thinking of is VMS. And you must install perl there as well, but that's a much more accessible scripting language than any sh derivative.

I disagree - I've buid a lot of light virtual machines and pulling 150+ Mib of packages to get perl is a definitely not accessible given that some shell is always already installed.
Especially since c_rehash is no longer needed, I'm a fan of making it a shim, or removing it entirely

I said VMS, not VMs...

@levitte Hmm, VMS -- not something that usually comes to mind, point taken. :D
One possible alternative is to have an sh implementation and a perl one, and prefer to install the sh implementation if sh is available (or on platforms other than VMS). Of course if it could be dropped entirely that would be interesting as well.
(I still think the idea of a multi-call binary that can be invoked as either openssl rehash or c_rehash would be a nifty one.)


Feat: Provide simple API that sets only Access-Control-Allow-Origin (codemonger-io/cdk-cors-utils#4)

Issue:

fixes #4

Changes:

Add simple APIs makeIntegrationResponsesAllowOrigin and makeMethodResponsesAllowOrigin that only configure Access-Control-Allow-Origin headers
Bump version to 0.3.0

I forgot to update main.


Update terraform get-started-cloud-shell.md to include the SP settings

When users follow the document, they will run az login --service-principal and use the newly created service principle to create and apply plan. But it won't work unless they setup the required changes in this PR.

#hold-off

@tonytangau Do you work at Microsoft? If so, let's talk offline to better understand this issue. Thanks.

@tonytangau I'm closing this PR as this repo is for public contributions. I've updated the article. If you wish to discuss further, let's do so via email. Thanks!


Issue while accessing llmsherpa api url

Hi team,
While trying to access the llmsherpa_api_url = "https://readers.llmsherpa.com/api/document/developer/parseDocument?renderFormat=all", I am getting this error
""message": "HTTPSConnectionPool(host='readers.llmsherpa.com', port=443): Max retries exceeded with url: /api/document/developer/parseDocument?renderFormat=all (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x0000028C4516F590>, 'Connection to readers.llmsherpa.com timed out. (connect timeout=None)')"
Has the URL changed? I tried to run the code through Colab link provided, still I am getting the same issue there.
Also not able to visit in the browser also.
Kindly look into and suggest me some ways.
Thanks!

The server is no longer supported as communicated a few months ago. Please use the nlm-ingestor to self host.
Here is the repo with instructions on how setup nlm-ingestor locally:
https://github.com/nlmatics/nlm-ingestor


resend recipient unavailable

if the recipient is unavailable resend the message...

to resend them in mod_smacks the body must be added in line ~245. no idea how difficult this is :/


[Queues] Migrate existing Samples to samples/ folder

[x] Got completely rid of test framework dependency

[x] Remove assert Statements (if any)
[x] Rename test_* to *
[x] Get rid of setup and teardown

[x] All the samples are inside the samples/ folder and not anywhere else
[x] Update the literal includes
[x] Updated the links in the README
[x] Added samples to MANIFEST
[ ] Verified Docs in sphinx are generated properly

Can one of the admins verify this patch?

/azp run python - storage - ci


Tweaks and fixes to the scroll creation process

This fixes the scroll description (closes #2181), which completely ignored "description.value" due to how mergeObject works.
Added missing localization in the scroll description.
Added a hook (dnd5e.createScrollFromSpell) for those who want to tweak the scroll creation process further (the process cannot be cancelled).
Add concentration tag as a piece of descriptive text under the spell name (closes #1241), only for concentration spells.

@krbz999 Could you split the bug fix off into a separate PR from the other changes? The rest of the changes are nice, but I don't want them to hold up the bug fix from getting into 2.2.

@krbz999 Could you split the bug fix off into a separate PR from the other changes? The rest of the changes are nice, but I don't want them to hold up the bug fix from getting into 2.2.

Wasn't that added to 2.1.5?

Wasn't that added to 2.1.5?

So it was, ancient history :)


chore: add engines to root package.json

Specify node, pnpm, yarn versions in prep for pnpm migration

I think we have to update the node version in our actions to 18 too to make the CI pass

there are also a couple .nvmrc files in the repo, we should probably update ( or remove?) those too


fix(SerovalChunk): incorrect buffer length on special chars

node.js returns incorrect string length on occuring of special charaters. Use encoded data length instead.
fixing #1408
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

data.length in createChunk is less than the (new TextEncoder().encode(data)).length
What is the new behavior?
not use data.length for buffer process
Other information

@hardywu do you have an example data that I can check and test?

@lxsmnsyc
> const str = 'à\u0301';
undefined
> str.length
2
> (new TextEncoder().encode(str)).length
4
>
···

@hardywu Thanks! This makes sense.

Only part that needs fix is when we consume a piece of chunk from the stream: https://github.com/solidjs/solid-start/blob/5c34ca7fedd040d6a133b0991bbb65667acd1e1a/packages/start/src/runtime/server-runtime.ts#L73
The commit for bufferSize doesn't correctly reflect the change when we consume from the buffer, we might want to resize bufferSize.
Other than that, the rest looks good to me.

Only part that needs fix is when we consume a piece of chunk from the stream:
https://github.com/solidjs/solid-start/blob/5c34ca7fedd040d6a133b0991bbb65667acd1e1a/packages/start/src/runtime/server-runtime.ts#L73
The commit for bufferSize doesn't correctly reflect the change when we consume from the buffer, we might want to resize bufferSize.
Other than that, the rest looks good to me.

How about keeping the buffer of type Unit8Array? Less worries about the length difference.

@hardywu whichever works 😄

LGTM, thanks!


update ymls

Are you a current Fivetran customer?

What change(s) does this PR introduce?

Did you update the CHANGELOG?

[ ] Yes

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[ ] No  (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[ ] Yes

Is this PR in response to a previously created Bug or Feature Request

[ ] Yes, Issue/Feature [link bug/feature number here]
[ ] No

How did you test the PR changes?

[ ] Buildkite
[ ] Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[ ] BigQuery
[ ] Redshift
[ ] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

Provide an emoji that best describes your current mood

:dancer:
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

good to merge once databricks passes!


Updating candidate withdrawal reasons

We have some upcoming work to update the reasons providers can select when rejecting an application.
This PR is to update the prototype to reflect the current journey on live, as it was quite different.
Before

After

Live

 Update prototype to reflect current live journey rejection reasons journeys

@PeteWilliams, looking at the success banner in your after screenshots, typically in BAT, the banner is full width as the content within is automatically two-thirds width.

@PeteWilliams, looking at the success banner in your after screenshots, typically in BAT, the banner is full width as the content within is automatically two-thirds width.

Thanks, that's now updated.


0.6.23 bundles too much in express

0.6.23 has the following modules in express/node_modules which are not in 0.6.22: basic-auth, crc, depd, escape-html, media-typer, merge-descriptors, parseurl, proxy-addr, and vary. This causes a screenful of error messages of the form
npm WARN unmet dependency .../testem/node_modules/express/node_modules/connect/node_modules/cookie-parser requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency .../testem/node_modules/express/node_modules/cookie,
npm WARN unmet dependency which is version 0.0.5

:+1:

This fixes it https://github.com/airportyh/testem/commit/13951c27dde11dbff3be718fe7641c73c28bbfca
@MoOx yes, I need and would love some help. And if you need help helping, please ask.


fix: use directVersionPublish for LUIS to avoid 404 in bot response

Description
Update bf/lu package.
Set directVersionPublish to true when call luis publish API.
Task Item
fixes #5622
Screenshots

On hold this till the latest bf-lu package goes into npm.

On hold this till the latest bf-lu package goes into npm.

Coverage remained the same at 55.097% when pulling cc5dfe6394ab98d1a77f4fb606876c7d6676f005 on alanlong9278:julong/bf-lu-update into fa6078463cbf214b5a39b6ad02790f32dbc93e73 on microsoft:main.

Coverage remained the same at 55.097% when pulling cc5dfe6394ab98d1a77f4fb606876c7d6676f005 on alanlong9278:julong/bf-lu-update into fa6078463cbf214b5a39b6ad02790f32dbc93e73 on microsoft:main.


Update Features of Overview

What this PR does / why we need it
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

None

/kind cleanup
/lgtm
/approve

/triage acdepted

/triage accepted


Fw FP should only look for MDPS part number

It is noticed that the Fw FP can get out of proportion as vehicle ECUs can have multiple part number depending on variants. There is no need for looking and capturing ECU part numbers other than MDPS. MDPS alone should give us unique part number per vehicle model. This reduces work load in adding multiple FwFP for each variant of a vehicle model

MDPS fw version doesn’t uniquely identify a vehicle. The Optima and Santa Fe have the same MDPS fw version.


No match for GET request

I have been searching up and down for documentation to point me in the right direction of what the issue may be.  I am getting a no match error when the URL I am mocking with nock is exactly the same.  Here is the code:
it('should be able to get all accounts', (done) => {
    nock(URL.API)
        .get('twitter_accounts/1/user_lookup')
        .query({
            twitter_ids: [ 2 ]
        })
        .reply(200, {});

    const assertion = (action, expectedAction) => {
        return assert.deepEqual(action, expectedAction);
    };
    const expectedActions = [
        { accounts: { 2: 1 }, type: ACCOUNTS.RECEIVE_TWITTER_ACCOUNTS },
        { accounts: { 1: { id: 1, twitter_id: 2 } }, type: ACCOUNTS.RECEIVE_ALL_ACCOUNTS },
        { id: 1, type: ACCOUNTS.SET_CURRENT_ACCOUNT_ID },
        { type: ACCOUNTS.REQUEST_TWITTER_DATA }
    ];
    const store = mockStore({
        assertion,
        done,
        expectedActions,
        state: {
            userReducer: {
                organizations: [
                    {
                        twitter_accounts: [
                            { id: 1, twitter_id: 2 }
                        ]
                    }
                ]
            }
        }
    });

    store.dispatch(AccountsServices.getAllAccounts());
});

Assume the URL.API is https://api/v1/...
And when running my tests I receive and check the request, I get:
{ [Error: Nock: No match for request get https://api/v1/twitter_accounts/1/user_lookup?twitter_ids=2 ] status: 404, statusCode: 404 }

So, what's the issue here?  Is this a bug of some sort?  I am not sure why this isn't working as intended.

Since you specified an array for the value of twitter_ids, it's expecting the query parameter to be twitter_ids[]=.

Also not sure if it's valid to have a path in the scope. It maybe should just be protocol + host.

Even if I changed it to be query({ twitter_ids: '2,3,4,5' }), I get the same result.

I am going to close this... After messing with the test a little longer the issue seemed to resolve itself.  I will chalk this one up to a malformed request on my end.

For googlers with this issue. I noticed that the service protocol + host (passed in the constructor) ended with a trailing slash and the path (passed in get() in my case) began with a slash when the requests matched. If they are written to join without a double slash, it won't match. When the path is deconstructed this is not obvious to those of us who are assuming how it may work under the hood (incorrectly in my case I guess). Hope this helps someone...


"RSPV" button doesn't do anything

Whoops, never migrated the database on production after adding some helper methods to replace generating sign up urls within the templates, this is now fixed and pushed to production, thanks


build: updating adoption guide

Replacing the way we create demos inside the adoption guide - Now the templates for Stackblitz are based on top of node.
Providing this type of templates (at the moment)

Core - Angular app with Core components only
Angular - Angular app with Angular components only (@clr/angular)
Hybrid -  Angular app with Angular component and Core components into a single app (@clr/angular & @cds/angular & @cds/core)

Fully reworking how Stackblitz service is working (need some more polishing but with the next PR)
Adding basic demo apps building links on the "Getting Started" page for quick testing.
DEMO: https://60c8a88362fef5fff180a92f--vmware-clarity.netlify.app/adoption/getting-started

We need to discuss this @gnomeontherun  and I think that this is not part of the scope of the changes above or at least for now.
We could talk more about that next week when we discuss what and how the adoption guide will be promoted and publicly available


Errors when building

I have error when building from sources:
Scanning dependencies of target lemonbuddy
[ 87%] Building CXX object bin/CMakeFiles/lemonbuddy.dir/main.cpp.o
In file included from /mnt/vd1/projects/git/i3wm/lemonbuddy/include/common.hpp:8:0,
                 from /mnt/vd1/projects/git/i3wm/lemonbuddy/src/main.cpp:4:
/mnt/vd1/projects/git/i3wm/lemonbuddy/lib/boost/include/boost/di.hpp:9:2: error: #error "Boost.DI requi
res C++14 support (Clang-3.4+, GCC-5.1+, MSVC-2015+)"
 #error "Boost.DI requires C++14 support (Clang-3.4+, GCC-5.1+, MSVC-2015+)"
  ^
In file included from /mnt/vd1/projects/git/i3wm/lemonbuddy/src/main.cpp:4:0:
/mnt/vd1/projects/git/i3wm/lemonbuddy/include/common.hpp:44:23: error: ‘di’ is not a namespace-name
 namespace di = boost::di;
                       ^

You need a compiler with support for c++14
Install clang and you should be good to go.  You might need define it when running cmake:
$ cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER=clang++ ..

GCC: cmake -DCMAKE_CXX_COMPILER=g++ ..
Clang: cmake -DCMAKE_CXX_COMPILER=clang++ ..


Added example to use null-ls with lsp-zero

I don't know if you want to have it within the readme or maybe better to create a wiki page for it? If the case is a wiki example, I can move it.

Currently it is only possible to have a standalone null-ls and it does not use the formatters installed via lsp-zero/mason. I currently playing around with the mason-null-ls package to use Mason installed formatters in null-ls via lsp-zero.

I would prefer to have this information in advance-usage.md.

Updated the docs and moved it to advance-usage


Fix #250: Move color palette definitions in if-block for old base16_gruvbox_dark_hard

https://github.com/vim-airline/vim-airline-themes/issues/250

The old airline palette was outside the 'old' block
The not-in-conditional palette definitions overwrote what was configured in the 'old' block

thanks!


aiotnb - Bank API - Milestone 2 (Payout Request)

Link to milestone and objective list
thenewboston-developers/Projects Milestone 230
I believe this is the most intensive milestone, due to the boilerplate that needs to be written. Ideally, the other API milestones can mostly build off this one.
Milestone proof of work
Accounts

GET /accounts

PATCH /accounts/<account_number>

Account class

Bank Transactions

GET /bank_transactions

BankTransaction class

Banks

GET /banks

PATCH /banks/<node_identifier>

Bank class

BankDetails class for incomplete data

Blocks

GET /blocks

POST /blocks
This method is not public. A more ergonomic user-facing method will be added once the Validator API is operational.

Block class

Clean
These methods return a 2-tuple in the form (Optional[str], Optional[datetime.datetime]) containing the clean status and last run time.

GET /clean

POST /clean

Config

GET /config

Confirmation Blocks

GET /confirmation_blocks

POST /confirmation_blocks

This endpoint has been delayed until milestone 3, as it is deeply connected with the Validator API and I do not yet know how the two need to interact in aiotnb.

ConfirmationBlock class

Crawl
These methods return a 2-tuple in the form (Optional[str], Optional[datetime.datetime]) containing the crawl status and last run time.

GET /crawl

POST /crawl

Invalid Blocks

GET /invalid_blocks

POST /invalid_blocks

This endpoint has been delayed until milestone 3, as it is deeply connected with the Validator API and I do not yet know how the two need to interact in aiotnb.

InvalidBlock class

Connection Requests

POST /connection_requests

Confirmation Services

GET /validator_confirmation_services

POST /validator_confirmation_services

ConfirmationService class

Upgrade Notice

POST /upgrade_notice

Validators

GET /validators

GET /validators/<node_identifier>

PATCH /validators/<node_identifier>

Validator class (TODO in milestone 3)

ValidatorDetails class for incomplete data

Documentation

Docstrings can be viewed directly in the source code. (They are the triple-quoted strings)

Sphinx documentation can be viewed in the docs directory, and can be built locally using the sphinx tools.

Testing
The Bank API tests can be found here.
Below are the most recent test results from my machine.

Performance Benchmark
With more endpoints added, I was able to more completely demonstrate the advantages of coroutine functions. Below are two benchmark results, each requesting a paginated endpoint with 10 results per page.

GET /accounts
  [tnb]    Gathered 59 accounts (10-per-page) in 1105.2920ms
  [aiotnb] Gathered 59 accounts (10-per-page) in 763.9069ms
  [aiotnb] Faster by 45%

GET /bank_transactions
  [tnb]    Gathered 2480 transactions (10-per-page) in 46557.3603ms
  [aiotnb] Gathered 2480 transactions (10-per-page) in 26076.7197ms
  [aiotnb] Faster by 79%

Feel free to edit the benchmark to use different parameters or different endpoints and run it for yourself.
Source code
How to run
$ git clone https://github.com/AnonymousDapper/aiotnb.git
$ cd aiotnb
$ git clone https://github.com/thenewboston-developers/thenewboston-python-client.git

$ pip install virtualenv
$ virtualenv .demo
$ . .demo/bin/activate

$ pip install thenewboston-python-client
$ pip install .

$ python examples/speed_demo.py

Project Logo
I commissioned a logo and banner for this project, as requested by the Projects team. The artist was @denistsoi (wakawaka#9513 on Discord).
I am requesting an additional remittance of 12 hours worth of work at the core team's rate, as per his invoice.
See the issue here
Final Note
Due to some schedule changes, this has taken me much longer than I anticipated, as I do not have as much free time as before. I expect to get the next milestone proposal submitted the weekend of the 8th, but due to some family circumstances I cannot promise that.
Project Wallet
16c9d5010701093e4427b12d3674024346a6ac90f7cc3cbebc6d3d041d435fdd

Hey @AnonymousDapper we approved this milestone. But regarding the logo, the marketing team is going to pay it separately.


Notebooks (Iteration 1)

Small batch of issues from early access internal users to be fixed

@drdelambre @Asalem1 @alexpaxton this is a mini-epic of small fixes from internal testing for before the holiday break (CC @kristinarobinson)


Channel is closing even if no gas has been paid

Thanks for filing a bug report :-)
Steps to Reproduce

Navigate to channels
Close channel
Sign messages
Click on "Deny" if MetaMask requests to pay gas/ETH

Expected Result

Channel is still in the status "Open"

Actual Result

Channel is "Closing"

This is expected: there're several events which should trigger a channel to go into the Closing state, even if the ChannelClosed event didn't or even isn't going to show up on-chain soon. The only thing the user should be able to do then is try to Close again until it's Closed.
One of these events is the user showing the intention of closing the channel, even if rejecting the signature prompt. Closing channels are effectively still Open on-chain, but not considered suitable anymore for transfers. This prevents the channel from being used again for transfers and some other actions, which could concurr with events that require the channel to be invalidated even though it's still open on-chain (e.g. handling a closing signature to a 3rd-party).
IMO, this works as expected, and it's a safety feature.

@andrevmatos Ok, cool, thanks :) Closing


Error: ENOENT: no such file or directory

[flutter-assets-gen.generate] Error: ENOENT: no such file or directory, chdir 'D:\Software\Microsoft VS Code' -> '/d:/Code/Flutter/flutter_sxtapp'

@cv0cv0 ok, cause i didn't specifically debug win system, i will deal with it tomorrow

please upgrade<EMAIL_ADDRESS>


REST API User signatures

The API for user's signatures management.
I've made the documentation a bit in advance so we need to wait until the API is released.
I'm not sure if I had to update the postman specs or it is supposed to be generated automatically from the OpenAPI specs.

@alexeevit you updated postman spec manually ? AFAICT it's made automatically by release process. Do you confirm @CoCraig ?

@alexeevit you updated postman spec manually ? AFAICT it's made automatically by release process. Do you confirm @CoCraig ?

yup, I wasn't sure so I just did it manually.

Yes, the Postman spec is auto-generated from the swagger spec. We don't have it running on a schedule, but something that is manually triggered and then generated.

Yes, the Postman spec is auto-generated from the swagger spec. We don't have it running on a schedule, but something that is manually triggered and then generated.

Oh ok cool, I reverted it

The Postman spec is currently created manually using the instructions here:
specs/README.md

FTR I merged this PR in another PR (could not update this one as it's from another repo), I updated the postman spec at the same time with new process.


Slim kitfile spec

Description
Trim down the kitfile spec for simplicity (removed fields can be re-added later if we find a need for them):

Remove license field from model, dataset, and code, leaving only the top-level package license
Remove dataset references from model; since we only have one model now, datasets are assumed to apply to it
Remove processing field from datasets
Minor renames of internal fields to match their names in the Kitfile (e.g. TrainedModel -> Model)

This PR also changes how Kitfiles are parsed to print an error if an unknown field is present:
❯ kit pack -t test .
[ERROR] Failed to pack model kit: yaml: unmarshal errors:
  line 2: field manfiestVersion not found in type artifact.KitFile

(This could be cleaned up but the yaml package does not give us many easy options to do so right now)
Linked issues
Closes https://github.com/jozu-ai/kitops/issues/239

Turns out I had some copy-paste typos in the integration tests and this caught them, so we're already ahead :D

@amisevsk We have been discussing this with @bmicklea and he made the point that it is actually the top level license that is creating ambiguity and we should keep the licenses for code, model and datasets and deprecate the package level license.

I was kind of heading the other direction, I was considering turning the package-level license field into a list, so you could have
package:
  license: ["MIT", "CC BY-SA 4.0"]

or similar. At the end of the day, unpacking any of the layers should unpack a LICENSE file as well.
I'll update it to revert the license change (and then re-update https://github.com/jozu-ai/kitops/pull/395 to match)

Alright all license changes are reverted. We want licenses on models/datasets/code sections, and have to keep the package-level license field too since most existing modelkits use it.

Docs changes are in https://github.com/jozu-ai/kitops/pull/395


Sample config file that sets one or multiple roles

From the doc, it is very ambiguous how I can set the client roles. It just states set the fabric settings with name, admin, user and value fields. But how and where in the config file exactly?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 95cd782f-1035-e3af-7696-d26850dec04d
Version Independent ID: 6f3e7017-fbbe-84af-4b4f-2ddd3b08edee
Content: Service Fabric cluster security: client roles
Content Source: articles/service-fabric/service-fabric-cluster-security-roles.md
Service: service-fabric
GitHub Login: @mani-ramaswamy
Microsoft Alias: subramar

Thanks for the question. We are currently investigating and will update you shortly.

You can set the Administrator and User client roles when you create the cluster. Assign roles by providing separate identities (for example, by using certificates or Azure AD) for each role type. You can assign these roles by using the Azure portal as well.
I can understand that this doc can elaborate on the how part.
I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks for the response. I need this for standalone cluster, so can't use Azure Portal.

#reassign @dekapur

dekapur is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign @dkkapur

There is a section in the cluster config called "security" that is used to specify these properties (see
Security for more info on this. Here are some examples of cluster configs that may help as well:

https://github.com/Azure-Samples/service-fabric-dotnet-standalone-cluster-configuration/blob/master/Samples/ClusterConfig.gMSA.Windows.MultiMachine.json
https://github.com/Azure-Samples/service-fabric-dotnet-standalone-cluster-configuration/blob/master/Samples/ClusterConfig.Windows.MultiMachine.json

We will go ahead and close this as Deep has provided additional details. If more info is needed just let us know and we can always reopen and continue the discussion.


Replace background asset with webp

@xylodrone will put webp which could be used to put there as a background asset to cut on initial loading times for users. as now it takes time to show up.
Ref

#1129
https://github.com/kodadot/nft-gallery/issues/1202

Let's downgrade it to this jpeg, we will figure out later new background pic:D

closing this since we don't use background on landing page anymore


Feature/dataclass schema defaults

Change Summary

Make use of default_factory lambda when creating pydantic fields
Add separate test for this kind of default
Add field for this kind of default in test_schema

Related issue number
Fixes #968
If fine and complete, lets discuss docs
Checklist

[X] Unit tests for the changes exist
[X] Tests pass on CI and coverage remains
[X] Documentation reflects the changes where applicable
[X] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

great, thank you very much.


Example in documentation for #[async] and await! fails to build with nightly

Hey, I want to test the bits in the futures crate, but I can't event get the hello world to build. What I am missing?
Cargo.toml:
...
[dependencies]
futures = { version = "0.2.0-beta", features = ["nightly"] }

src/main.rs:
#![feature(proc_macro, generators)]

#[macro_use]
extern crate futures;

use futures::prelude::*;

#[async]
fn foo() -> Result<i32, i32> {
    Ok(1 + await!(bar())?)
}

#[async]
fn bar() -> Result<i32, i32> {
    Ok(2)
}

fn main() {
    assert_eq!(foo().wait(), Ok(3));
}

Rust version (rustup show):
Default host: x86_64-unknown-linux-gnu

installed toolchains
--------------------

stable-x86_64-unknown-linux-gnu
nightly-x86_64-unknown-linux-gnu (default)

active toolchain
----------------

nightly-x86_64-unknown-linux-gnu (default)
rustc 1.26.0-nightly (80785a547 2018-03-30)

Compile output (cargo +nightly build):
error: cannot find attribute macro `async` in this scope
 --> src/main.rs:8:3
  |
8 | #[async]
  |   ^^^^^

error: cannot find attribute macro `async` in this scope
  --> src/main.rs:13:3
   |
13 | #[async]
   |   ^^^^^

error[E0425]: cannot find function `foo` in this scope
  --> src/main.rs:19:16
   |
19 |     assert_eq!(foo().wait(), Ok(3));
   |                ^^^ not found in this scope

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0425`.

Two things,

futures v0.2.0-beta doesn't include the async/await macros, you'll need to depend on futures = { git = "https://github.com/rust-lang-nursery/futures-rs" } until the next release is published
That example is a bit out of date, here's a working example:

#![feature(proc_macro, generators, pin)]

extern crate futures;

use futures::prelude::*;
use futures::stable::block_on_stable;

#[async]
fn foo() -> Result<i32, i32> {
    Ok(1 + await!(bar())?)
}

#[async]
fn bar() -> Result<i32, i32> {
    Ok(2)
}

fn main() {
    assert_eq!(block_on_stable(foo()), Ok(3));
}

That's weird, I had tried clonning rust-lang-nursery/futures-rs and setting dependency as futures = { git = "../futures/futures-rs" }, but the error persisted.
Anyway, it's working now, thanks!


🐛 [firebase_auth] userChanges() doesn't trigger with the verifyBeforeUpdateEmail() method

Bug report
Describe the bug
When I listen to changes via the userChanges() stream, I do not get an update, if I change the user's email via the verifyBeforeUpdateEmail(newEmail) method.
I do, however, get an update when I use the standard updateEmail(newEmail) method.
To be fair, it doesn't mention the verifyBeforeUpdateEmail(newEmail) method in the documentation to be reflected in the userChanges() stream, but it is nevertheless also an update to the user's email and should most certainly be reflected in the user changes.
Steps to reproduce
Steps to reproduce the behavior:

create a StreamBuilder<User?> with the FirebaseAuth.instance.userChanges() stream
update the user's email via verifyBeforeUpdateEmail(newEmail)
click the verification link in the new email account's verification mail sent by firebase
observe, that there are no changes to be seen

Expected behavior
I would expect the FirebaseAuth.instance.userChanges() to be triggered, when the email updates successfully.
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[√] Flutter (Channel stable, 3.10.2, on Microsoft Windows [Version 10.0.19045.2965], locale de-DE)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.3.6)
[√] Android Studio (version 2022.1)
[√] Android Studio (version 2022.2)
[√] VS Code (version 1.74.2)
[√] Connected device (4 available)
[√] Network resources

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 3.0.2
Flutter SDK 3.10.2
mwe 1.0.0+1

dependencies:
- background_downloader 7.2.0 [flutter logging http path_provider path async mime collection]
- chewie 1.5.0 [cupertino_icons flutter provider video_player wakelock]
- cupertino_icons 1.0.5
- firebase_auth 4.6.2 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutt
er meta]
- firebase_core 2.13.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_database 10.2.2 [firebase_core firebase_core_platform_interface firebase_database_platform_interface firebase_datab
ase_web flutter]
- firebase_ui_auth 1.4.2 [email_validator firebase_auth firebase_core firebase_dynamic_links firebase_ui_localizations firebas
e_ui_oauth firebase_ui_shared flutter flutter_localizations]
- firebase_ui_database 1.3.2 [collection firebase_database firebase_ui_localizations flutter]
- firebase_ui_localizations 1.5.0 [flutter flutter_localizations path]
- firebase_ui_oauth_apple 1.2.2 [firebase_auth firebase_ui_oauth flutter]
- firebase_ui_oauth_google 1.2.2 [firebase_auth firebase_ui_oauth flutter google_sign_in]
- flex_color_scheme 7.1.2 [flex_seed_scheme flutter meta]
- flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine]
- flutter_localizations 0.0.0 [flutter intl characters clock collection js material_color_utilities meta path vector_math]
- flutter_markdown 0.6.15 [flutter markdown meta path]
- flutter_native_splash 2.3.0 [args flutter flutter_web_plugins js html image meta path universal_io xml yaml]
- flutter_platform_widgets 3.3.5 [flutter cupertino_icons]
- flutter_svg 2.0.6 [flutter vector_graphics vector_graphics_codec vector_graphics_compiler]
- fluttertoast 8.2.2 [flutter flutter_web_plugins]
- http 0.13.6 [async http_parser meta]
- internet_connection_checker 1.0.0+1
- intl 0.18.0 [clock meta path]
- native_device_orientation 1.1.4 [flutter meta]
- package_info_plus 3.1.2 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32]
- path_provider 2.0.15 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_inte
rface path_provider_windows]
- provider 6.0.5 [collection flutter nested]
- shared_preferences 2.1.1 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_p
references_platform_interface shared_preferences_web shared_preferences_windows]
- sqflite 2.2.8+4 [flutter sqflite_common path]
- video_player 2.6.1 [flutter html video_player_android video_player_avfoundation video_player_platform_interface video_player
_web]

dev dependencies:
- flutter_launcher_icons 0.13.1 [args checked_yaml cli_util image json_annotation path yaml]
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collect
ion js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:
- _flutterfire_internals 1.3.2 [collection firebase_core firebase_core_platform_interface flutter meta]
- archive 3.3.7 [crypto path pointycastle]
- args 2.4.1
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- characters 1.3.0
- checked_yaml 2.0.3 [json_annotation source_span yaml]
- cli_util 0.4.0 [meta path]
- clock 1.1.1
- collection 1.17.1
- convert 3.1.1 [typed_data]
- crypto 3.0.3 [typed_data]
- csslib 0.17.3 [source_span]
- desktop_webview_auth 0.0.12 [crypto flutter http flutter_web_plugins plugin_platform_interface]
- email_validator 2.1.17
- fake_async 1.3.1 [clock collection]
- ffi 2.0.2
- file 6.1.4 [meta path]
- firebase_auth_platform_interface 6.15.2 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interf
ace]
- firebase_auth_web 5.5.2 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_p
arser js meta]
- firebase_core_platform_interface 4.8.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.5.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_database_platform_interface 0.2.5+2 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_i
nterface]
- firebase_database_web 0.2.3+2 [firebase_core firebase_core_web firebase_database_platform_interface flutter flutter_web_plug
ins js]
- firebase_dynamic_links 5.3.2 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutt
er meta plugin_platform_interface]
- firebase_dynamic_links_platform_interface 0.2.6+2 [_flutterfire_internals firebase_core flutter meta plugin_platform_interfa
ce]
- firebase_ui_oauth 1.4.2 [desktop_webview_auth firebase_auth firebase_ui_auth firebase_ui_shared flutter_svg flutter]
- firebase_ui_shared 1.3.0 [flutter]
- flex_seed_scheme 1.3.0 [collection flutter meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- google_identity_services_web 0.2.1 [js meta]
- google_sign_in 6.1.3 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web
]
- google_sign_in_android 6.1.14 [flutter google_sign_in_platform_interface]
- google_sign_in_ios 5.6.2 [flutter google_sign_in_platform_interface]
- google_sign_in_platform_interface 2.4.1 [flutter plugin_platform_interface quiver]
- google_sign_in_web 0.12.0+1 [flutter flutter_web_plugins google_identity_services_web google_sign_in_platform_interface http
 js]
- html 0.15.3 [csslib source_span]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 4.0.17 [archive meta xml]
- js 0.6.7 [meta]
- json_annotation 4.8.1 [meta]
- lints 2.1.0
- logging 1.2.0
- markdown 7.1.0 [args meta]
- matcher 0.12.15 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.2.0
- meta 1.9.1
- mime 1.0.4
- nested 1.0.0 [flutter]
- package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- path 1.8.3
- path_parsing 1.0.1 [vector_math meta]
- path_provider_android 2.0.27 [flutter path_provider_platform_interface]
- path_provider_foundation 2.2.3 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.11 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.0.6 [flutter platform plugin_platform_interface]
- path_provider_windows 2.1.6 [ffi flutter path path_provider_platform_interface win32]
- petitparser 5.4.0 [meta]
- platform 3.1.0
- plugin_platform_interface 2.1.4 [meta]
- pointycastle 3.7.3 [collection convert js]
- process 4.2.4 [file path platform]
- quiver 3.2.1 [matcher]
- shared_preferences_android 2.1.4 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.2.2 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.2.0 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_pl
atform_interface]
- shared_preferences_platform_interface 2.2.0 [flutter plugin_platform_interface]
- shared_preferences_web 2.1.0 [flutter flutter_web_plugins shared_preferences_platform_interface]
- shared_preferences_windows 2.2.0 [file flutter path path_provider_platform_interface path_provider_windows shared_preference
s_platform_interface]
- sky_engine 0.0.99
- source_span 1.9.1 [collection path term_glyph]
- sqflite_common 2.4.5 [synchronized path meta]
- stack_trace 1.11.0 [path]
- stream_channel 2.1.1 [async]
- string_scanner 1.2.0 [source_span]
- synchronized 3.1.0
- term_glyph 1.2.1
- test_api 0.5.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matc
her]
- typed_data 1.3.2 [collection]
- universal_io 2.2.0 [collection meta typed_data]
- wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface]
- wakelock_windows 0.2.1 [flutter wakelock_platform_interface win32]
- win32 3.1.4 [ffi]
- xdg_directories 1.0.0 [meta path process]
- xml 6.3.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]

Thanks for the report @flying-wizzy
After you update user's email, you need to get the current User. Access the current User by FirebaseAuth.instance.currentUser and see if it works in your case ?
If not, then can you provide us complete runnable code sample that we can use to verify the reported behavior ?

Hi @darshankawar yes I am using a stream of the currentUser like you recommended. All the other methods work fine, updateDisplayName etc. Only verifyBeforeUpdateEmail isn't showing any updates.
I made a minimal reproducible example from your firebase_auth example right here , in this repo. I just stripped the profile page down to the very necessities and it's not pretty code, but it get's the job done and shows the problem. Updating the display name is reflected in the currentUser right away. But after verifying and updating the email, the currentUser stays the same.
Steps to reproduce with the example repo I posted:

clone example repo
build and run project in master/packages/firebase_auth/firebase_auth/example
create a user with e.g. email and password and login
on the profile page click the "Update Display Name" Text Button
watch the display name change from "no display name" to "Hello Firebase Team"
next, type a new email adress in the TextFormField offered
then, click the "Verify and Update Email" button
verify the email by clicking the link sent by firebase in that email-account
observe, that the currentUser's mail does NOT change unless you sign out and login again with the new mail adress

Maybe I'm missing something, but I looking forward to your answer! :)

Thanks for the update. Can you try force reload using  FirebaseAuth.instance.currentUser.reload() to retrieve the latest user profile and see if it helps ?

I just tried it in 2 variants:

I called FirebaseAuth.instance.currentUser.reload() after actually updating to the new email via the confirmation link in the email from firebase. It gives me "Unhandled Exception: [firebase_auth/user-token-expired] The user's credential is no longer valid. The user must sign in again." as a result.
I also tried triggering the reload after calling verifyBeforeUpdateEmail(newEmail) but before clicking the confirmation link in the email sent by firebase. In that case, too, it didn't update the user's mail after clicking the email link.

Even if it did work with variant 1, though, periodically firing a user reload wouldn't be a desirable way of approaching this issue in my opinion. If I had two seperate devices with the same app installed by the same user and wanted to reflect the change in the user's email, I would have to constantly periodically trigger FirebaseAuth.instance.currentUser.reload(), wherever I want access to the user's email, am I right?
FirebaseAuth.instance.userChanges() should also cover this case, without any user reloads, as it successfully does for updateDisplayName or updateEmail

Thanks for the update. Using the steps to replicate as mentioned here, I see the same behavior as reported.

The verifyBeforeUpdateEmail() method still does not work a year after opening the ticket. Using updateEmail(), the modification works but the method is deprecated. Until when can we use this deprecated method and when to verifyBeforeUpdateEmail() will work correctly?
@flying-wizzy did you find a solution please?

I did not find a solution for the bug unfortunately. I am somewhat using a workaround currently: After triggering the verifyBeforeUpdateEmail() method, I force log out the user and inform them, that they need to click the verification link in their email account before logging back in.

thank you @flying-wizzy for your quick reply.
The problem is that I don't receive any verification emails. no email is sent (I checked the email logs).
while using updateEmail(), I receive an e-mail on the old address asking me if I do not want to go back and the change of address takes place correctly.

No worries @Bylinkk. Unfortunately I don't know what's going wrong in your app. I am receiving the notification mails everytime.

Ok thanks @flying-wizzy for the information, I'll look at what's wrong on my side

I just tried again this morning and after updating flutter and the packages. everything works correctly on my side

same here

Hi @flying-wizzy - I'm afraid there isn't anything to fix on FlutterFire, see this stack overflow response to the problem.
Important bit:

Update (2024): since people keep commenting that this doesn't work: note that by default the token is refreshed once an hour (or when the user signs in). Since the actual verification happens in another (the mail client), the Firebase client does not know when it happens and it can't auto-refresh the token. So without doing more work, you'll have to wait for that auto-refresh to happen.

If that's not acceptable for your use-case, you can force a refresh of the token/profile at any time by calling user.reload(). Common ways/moments to trigger that reload are:

When the app regains focus, as that may indicate that the user is coming back to your app after clicking the email link.
Add a button/tap area and reload when the user clicks that.
Periodically after sending the verification email, say every 30s or so.

You need to design your app with these considerations in mind.


Time outs [+question]

Hi there. Recently we started seeing a lot of timeouts when performing queries against a BIG set (over 200 Million filters). Timeouts for us, means that the query to bloomd is taking longer than 250ms (we even increased it to 500ms and still times out).
Is there any best practices regarding the size of the filters? Is it better to split them into multiple small ones and perform multiple queries? Are there any optimizations we can do regarding the query to it?

@renatojf Apologies for the very long delay. My best guess is you exhausted system memory and the OS was paging out to disk. That is the only reasonable guess given the data here. The actual in-memory access times should never be that long, but if random pages were on disk and you were triggering a lot of disk reads, that could explain the timeouts.


Improve comments on gen/test

(I transitively merged #661 but endorse @belisarius222's request for better doc on it)

Closing this one as we need better comments just about everywhere. 😄

Requesting reopen as the suggested replacement "better comments just about everywhere" ticket is a bit too broad to be useful as stated.


Ensure that fitting plots are in the correct order and not doubled

In the order of the fitting plots was ensured by the file names. Also some doubling of plots was stopped by the filename by creating the file multiple times, but with the same file name and consequently it was overwritten.
Now we use Amazon S3 and have altered the file names. Consequently, the correct order of the plots has to be ensured explicictly.
The correct order is:

Variable 1:

Variable 1 shape plots
Variable 1 location plots
Variable 1 scale plot

Variable 2:

...

In case the some parameters depend on the same variable and consequently are based on the same fit, the fit should be plotted only once.

@topape I think you are working on this. I assign it to you.


project.pbxproj: Update to recommended settings.

A warning is emitted when this flag doesn't appear.

Thanks 💯


Updated README

Need to install python-dotenv along with convogym.
@af1tang : Thanks for such great work

Thanks! Let me actually add this to requirements.txt and setup.sh

Added python-dotenv to setup and requirements.txt. Running setup or pip install should auto install python-dotenv with rest of dependencies -- closing this PR.
Thanks for the great catch and please let me know if you find other issues :)