Pushing the build image to a Docker image repository

By pushing the build image to a repo and docker pull-ing it, developers no longer need to build it locally. This patch also modifies the Makefile to push and use the new build image.
See https://quay.io/repository/kubernetes-service-catalog/build-image for the build image's location.
Fixes https://github.com/kubernetes-incubator/service-catalog/issues/778

LGTM if CI is happy

Failing in Jenkins because of this line:
[Build & Unit/Integration Tests] docker pull gcr.io/service-catalog-jenkins-jobs/catalog/build-image:canary

I see a potential problem here...
If the build image is mutable, then we can really quite easily find ourselves in a scenario where we're trying to compile an old version of the code or a specific branch of this repo and the build image isn't suitable for doing so.
This is at least somewhat related to my previous question about this.

@krancour I'm not sure I understand the problem here. the .init target can pull down a new image if necessary, and developers can change the build image they intend to use. We can .init to also build the image if that addresses the issue?

Is there an escape hatch if I want to build the image myself, or not pull the upstream image?

I'm not opposed, I just don't want to pull this over the network.
scbuildimage                                             latest                        5c4a06fb5527        2 weeks ago          731.4 MB

@MHBauer if you put BUILD_IMAGE_MUTABLE=scbuildimage in your env, then run make build-image, you can execute any other make command without pulling from the network

@arschles

the .init target can pull down a new image if necessary

By default, it will always pull down quay.io/kubernetes-service-catalog/build-image:canary, which is built from the head of master.
Suppose I am trying to build "master - n"? The build image from the head of master may not be suitable for that.
I recognize that I could elect to build the build image myself. But I might not always know that there's a need to do so. Before this PR, even if it was a bit slow, I knew I could reliably make clean and start fresh with confidence that the correct build image would be built for me as a pre-requisite for everything else. Now, unless I am missing something, I would have to know I needed a custom build of the build image and I'd have to manually execute some steps to accommodate that.
If I'm reading this all wrong, then perhaps this PR can benefit from some docs that explain the workflow for the average case and for the cases where you're building something other than the head of master.

To be clear, I simply want to avoid:

Having to think about this.
Creating any confusion for new contributors.

As long as it exists, I'll probably end up leaving that var set.
What problem are we trying to avoid with this?

@krancour not sure what exactly the average case is, so I'll assume it's building from the HEAD of master. In that case, nobody has to think about this and there won't be any confusion. In other cases like building from master - n, we suffer from not versioning the build image.
If we did that, then we could default the build image name to quay.io/kubernetes-service-catalog/build-image:${VERSION} and the builds would "just work" from this point onward.
However, builds from points before this version would require the developer to manually specify the build image as canary because versioned images for those SHAs wouldn't exist.
Thoughts?

Marking this as in progress, because I need to think through some longer term implications of this change

documenting the escape hatch usage of BUILD_IMAGE_MUTABLE= needs to be done.

if it possible to make a master build of travis (or jekins) update the official quay build image if things are successful?  Then we wouldn't need to worry about what @krancour said here: https://github.com/kubernetes-incubator/service-catalog/issues/778#issuecomment-298362543

There are still problems with this implementation and open questions on the issue itself, so I am closing this PR w/o merge. Please see https://github.com/kubernetes-incubator/service-catalog/issues/778#issuecomment-299333218 for more detail


removed  REG_SZ  added  REG_DWORD

as per user report #8526 , i  removed REG_SZ   and added   REG_DWORD
https://user-images.githubusercontent.com/3296790/97083291-8a530200-162c-11eb-83e6-a4cc001a18d5.JPG

Sorry for the late change request. The last couple of weeks have been rough, so I have not always performed as well as I hoped. We may also want to have an additional phrasing check by JohanFreelancer9, if possible.

Metadata section from the GH doc page:
---
title: Manage connections from Windows 10 operating system components to Microsoft services
description: Learn how to minimize connections from Windows to Microsoft services, and configure particular privacy settings related to these connections.
ms.assetid: ACCEB0DD-BC6F-41B1-B359-140B242183D9
ms.reviewer:
keywords: privacy, manage connections to Microsoft, Windows 10, Windows Server 2016
ms.prod: w10
ms.mktglfcycl: manage
ms.sitesec: library
ms.localizationpriority: high
audience: ITPro
author: linque1
ms.author: obezeajo
manager: robsize
ms.collection: M365-security-compliance
ms.topic: article
ms.date: 7/7/2020
---

Not sure if there are other useful reviewers to be picked from that list.


Default users with default passwords are a security hazard

Every time a new database is created the default users are added to the database. This is a security hazard people will often forget to change the passwords and leave the defaults there. We should either use random default passwords, force user to create passwords for reader writers or not create the users automatically.

I agree 1) o 2) could be good. OrientDB can be used not only behind the server, but also directly though "plocal" protocol and any JVM languages. For this reason at least "admin" database user it's needed. But I agree the create database should ask for the password. On console, if not provided, a password is asked. WDYT?

While you're addressing this, what are the access controls on non-admin users related to user listing, etc.  Only a user in the admin role should be able to list users.
Another item is the "guest/guest" user that is used by the Studio.  This should be system/system, or something other than guest and the guest user is able to login via the console and list databases.  This user should be somehow buried in your system in a manner that removes it from the attack surface.

@compensator In 2.2 accessing even in READ mode to OUSer and ORole classes/clusters is forbidden. Only "admin" can do that on fresh databases.
About guest user, it's there only for /listDatabase command executed in Studio (you can still disable it in orientdb-server-config.xml).

That's the mitigation we suggested to the customer during our evaluation.  I haven't tested it yet, so I don't know what appears on the login page when guest is disabled.

Moved to 3.0 because of big effort is need to fix it.

:+1: the server guest with the listing permissions on the studio really creeps me out.


Round out CLI for the generate subcommand

This is more of a hodge-podge of related issues, but the generate subcommand of the CLI is still half-baked.  The following should be done across the CLI and maybe the interface of the modules:

Stabilize error-handling situation, right now it's a landmine-field of panics.
Add some output types, including outputting to a directory, outputting YAML from the result, and outputting the raw result.
Add either better hooks or result handling so that modules can provide additional information to end users.

The points listed above have been addressed.  Things may change as the CLI utility develops, but this issue as it stands can be considered done.


errors met when Using sparkstreaming with token to consume

when I consume topic by sparkstreming with token ,it meet errors. The code and error is as follows:
val pulsarReceiver = new SparkStreamingPulsarReceiver(serviceUrl,pulsarConf,AuthenticationFactory.token(pulsarToken))
https://static.dingtalk.com/media/lALPGojJ7356Q-jNAo7NCmo_2666_654.png_720x720q90g.jpg?bizType=im
Does pulsar support Using sparkstreaming with token to consume? What should I do?
I need help,thanks!

I don't recommend using it this way because it can cause serialization problems
please init client :
val confData = new ClientConfigurationData()
    confData.setAuthPluginClassName("org.apache.pulsar.client.impl.auth.AuthenticationToken")
    confData.setAuthParams("token:" + <please set token>)

    val src: SourceFunction[String] =
      PulsarSourceBuilder
        .builder(new SimpleStringSchema())
        .pulsarAllClientConf(confData)
        .serviceUrl(SERVICE_URL)
        .topic(INPUT_TOPIC)
        .subscriptionName(SUBSCRIPTION_NAME)
        .build()

Yes, I think Token Authentication Provider is not serializable. Use configuration to pass the auth plugins and params are the recommended way.


Add or Edit page on SRS for passwords

password must be:
min length: 8
max length: 16
1 lower case
1 upper case
1 number
1 special char (!@#$%^&*()_+-=)

Edited pages:
Registration https://github.com/ita-social-projects/what-front/wiki/SRS-Registration
Change Password https://github.com/ita-social-projects/what-front/wiki/SRS-Change-Password
Reset Password https://github.com/ita-social-projects/what-front/wiki/SRS-Reset-Password


information on how to force an orange pi to display to the vive hmd?

Hi, cool project you have here! Im currently trying to use a mini computer ( orange/raspberry pi etc) to do wireless vr streaming from steam using riftcat/moonlight/ALVR or similar) i see that you are able to display to the vive from an orange pi and wondering if you can share with me what custom resolution you had yo do to acheive that, and some steps on how to do that myself. I can get my way around rasbian mainly due to the huge amount of info there is on the platform, but finding it hard to get info on the orange pi debian jessie. I have an orange pi lite2. Thank you! Edit: not a libsurvive issue therefore not suitable for github.

Hey! Just FYI - I found out you can use the newest Raspberry Pi 3 B+ to do it!

See description at the bottom of this gist:
https://gist.github.com/cnlohr/152d4b7f35a7a76e0688ee4305d81a0b
https://gist.github.com/cnlohr/152d4b7f35a7a76e0688ee4305d81a0b#gistcomment-2621874
and the comment immediately above.


Vlc telnet

Description:
Trying to resolve this issue referenced in the vlc component doc I developed a component to control any instance of VLC running its built in telnet interface.
Alongside with this component, I've put together an add-on for the hassio platform to run a VLC instance locally.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9558
Example entry for configuration.yaml (if applicable):
# Example configuration.yaml entry
media_player:
  - platform: vlc-telnet
    name: speaker_1
    host: "<IP_ADDRESS>"
    port: 4321
    password: "secure_password"

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @rodripf,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Didn't the missing docstrings, I'll fix them and do the PR again.


Get rid of shared surface of DX 9

I see that now you create a shared surface handle to render from 11 dx to 9 (in which WPF is hosted), but shared surfaces has limitations such as only A8R8G8B8 format instaead of A10R10G10B10 or even A16R16G16B16. So, to fix this you need to get rid of sharing surface and create native DX 11 surface.

You are aware that these limitations are there for performance, right? Considering how much you pointed at performance in your other comment you should be aware of that.
If you interop with WPF and mix your D3D content with WPF content then the formats must obviously be compatible, otherwise you have to pay for an expensive copy including a format conversion for every frame, I doubt thats what you want.


Add validation for username, firstname, lastname, and password fields

Pull Request Template
Title: Add validation for username, firstname, lastname, and password fields
Description
This PR adds validation to the registration form to ensure proper input for the username, firstname, lastname, and password fields. Previously, users could register with just one character in these fields, and there was no password strength validation.
Changes Made

Added validation to ensure the username, firstname, and lastname fields have a minimum of 2 characters and do not allow digits.
Implemented password validation requiring a minimum of 8 characters, with at least one digit and one special character.

##Related Issue
Fixes #64
Checklist

[x] I have tested my code and it works as expected.
[ ] I have added/updated documentation where necessary.
[ ] I have included tests for new features.
[x] I have followed the project's coding standards.

Screenshots (if applicable)
https://github.com/user-attachments/assets/7662df49-5b2c-4678-a3e7-79d05be22e75

@prakrutipathak resolve conflicts.

@saurabhbakolia Done can you check it?


T82544 : "Remove duplicate vertices" becomes very slow if glTF object is imported with vertices already merged

See https://developer.blender.org/T82544

Regarding Blender ticket, this is not related to glTF importer. Closing this ticket


Non-owner can add voters to form of other user

While a non-owner cannot manage other aspects of a form (opening, closing, deleting, ...), they can add voters to the form. Following the logic of not giving them the right to manage the form, they should also not be able to add voters.
@dragonleman @multiscan : unless this is explicitely desired behaviour?

For a form :

the owner can manage and add voters
a non-owner cannot access the management of the form and therefore cannot add voters

For a form :
* the owner can manage and add voters

* a non-owner cannot access the management of the form and therefore cannot add voters

OK, thanks for confirming, we will fix this then


Help user to spot their desired VS code instance quickly!

You know, VS code is really powerful. And people are doing everything with it, one for editing repo for personal blog, one for code develop work like nodejs, python, java and etc, and another one to just open a temporary file.
The problem to the users is, from the OS Taskbar (Such as win11 taskbar), they all look same. And need an additional check to find the one that needed.
So, this feature request is to make it easier for user to find the target VS code instance.
One option I can think of is offering customizable icon, and if taskbar don't stack same app together, user can spot their desired VS code instance quickly!

Duplicate of #164157
You can use [Peacock extension] (https://marketplace.visualstudio.com/items?itemName=johnpapa.vscode-peacock) to easily color UI which will allow you to find them by preview.


fix(test) : fix failing label test

Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"
Mandatory

[x] What does this PR do?
This PR fixes the failing label test

[ ] What issue/task does this PR references?

[ ] Are the tests Included?

Optional

[ ] Is the documentation Included?

[ ] Are the Release Notes included?

[ ] @mention(s) to expected reviewer(s) included

[test]

[test]

@Raunak1203 Your image is available in the registry. Run docker pull quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2741 && docker run -it -p 5000:8080 quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2741 and visit http://localhost:5000 to access it.


Added extensive unit tests

Please merge this extensive battery of unit tests cover all aspects.

Suggestion:


typo

sodoco.als should be named sidoku.als

link to wikipedia page

Thank you for reminding me of this mistake

'sell' should be named 'cell'


openssl built for windows builds but is not enabled

I was trying to use openssl for a windows build and I see that it's built successfully in the docker containers however this line is preventing openssl from being enabled in the ffmpeg configuration:
https://github.com/BtbN/FFmpeg-Builds/blob/afcd9939cfaa1bec3a64044dc1f9d33481c3da42/scripts.d/25-openssl.sh#L97
I removed it locally and it appears to be working correctly.  Is there a reason it's not enabled or was this an oversight?

Windows uses schannel, not openssl.

More specifically, openssl is only built at all because other things depend on it.
Using an OS provided tls library which gets regular updates is largely preferable over a forever frozen in time version of openssl.

the schannel implementation is still quite buggy and we ran into some serious issues with it hanging in production.  Nevertheless is this was intentional that's fine, I can patch it locally

will do, thanks

I should clarify it's not schannel proper, rather the ffmpeg schannel shim that's buggy.  I will be following up with ffmpeg but for the short term openssl solves the issue.
Btw, this is a fantastic project, thank you for all you do!

Yeah, that's what I mean as well.
The only issues with hangs related to schannel was in the hls code and that got fixed years ago.
So even just an issue with "doing XYZ when using the schannel backend causes this and that." would be valuable.

im familiar with the hls issue, this particular issue is with rtmps


Appstudio update test-component-pac-rrje

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-rrje-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
22 seconds
init

✅ Succeeded
43 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
37 seconds
inspect-image

✅ Succeeded
35 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
38 seconds
sbom-json-check

✅ Succeeded
16 seconds
label-check

✅ Succeeded
10 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary

Pipelines as Code CI/test-component-pac-rrje-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
22 seconds
init

✅ Succeeded
43 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
37 seconds
inspect-image

✅ Succeeded
35 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
38 seconds
sbom-json-check

✅ Succeeded
16 seconds
label-check

✅ Succeeded
9 seconds
show-summary

✅ Succeeded
10 seconds
show-sbom

Pipelines as Code CI/test-component-pac-rrje-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
31 seconds
init

✅ Succeeded
29 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
21 seconds
inspect-image

✅ Succeeded
20 seconds
deprecated-base-image-check

✅ Succeeded
2 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
14 seconds
label-check

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
15 seconds
show-summary


Issue with Sanitizing Function - Error Details Unclear

Hello,
I'm currently experiencing an issue with the sanitizing function within the sd-scripts. When attempting to sanitize inputs, I encounter an error that I can't seem to decipher.
Issue Description:
I am trying to sanitize user inputs before processing, but the function throws an error every time I attempt to do so. The error message is not clear to me, and I've made sure to follow the documentation provided for the sanitizing process.
Error Message:
Invalid user config / ユーザ設定の形式が正しくないようです
Traceback (most recent call last):
  File "/mnt/my_raid/github/sd-scripts/sdxl_train.py", line 755, in <module>
    train(args)
  File "/mnt/my_raid/github/sd-scripts/sdxl_train.py", line 170, in train
    blueprint = blueprint_generator.generate(user_config, args, tokenizer=[tokenizer1, tokenizer2])
  File "/mnt/my_raid/github/sd-scripts/library/config_util.py", line 354, in generate
    sanitized_user_config = self.sanitizer.sanitize_user_config(user_config)
  File "/mnt/my_raid/github/sd-scripts/library/config_util.py", line 318, in sanitize_user_config
    return self.user_config_validator(user_config)
  File "/mnt/my_raid/github/sd-scripts/venv/lib/python3.9/site-packages/voluptuous/schema_builder.py", line 272, in __call__
    return self._compiled([], data)
  File "/mnt/my_raid/github/sd-scripts/venv/lib/python3.9/site-packages/voluptuous/schema_builder.py", line 595, in validate_dict
    return base_validate(path, iteritems(data), out)
  File "/mnt/my_raid/github/sd-scripts/venv/lib/python3.9/site-packages/voluptuous/schema_builder.py", line 433, in validate_mapping
    raise er.MultipleInvalid(errors)
voluptuous.error.MultipleInvalid: extra keys not allowed @ data['/mnt/NVM/images/data_sub/00_SrW1feA9iVyHm.jpg']

Steps to Reproduce:

python finetune/merge_captions_to_metadata.py --full_path '/mnt/NVM/images/data_sub' detailed_images.json

{
  "/mnt/NVM/images/data_sub/00_SrW1feA9iVyHm.jpg": {
    "caption": "The image features a woman with purple hair, wearing a black shirt and a green scarf. She is holding her shirt open, revealing her large breasts. The woman appears to be smiling and is the main focus of the scene.In the background, there are two trees, one on the left side and the other on the right side. The trees are not prominent in the image, but they do add some depth to the scene."
  },
....
}

accelerate launch --num_cpu_threads_per_process 1 sdxl_train.py --pretrained_model_name_or_path='/mnt/NVM/emix.safetensors' --output_dir='/mnt/NVM/emix' --output_name=emix-0-2 --dataset_config=detailed_images.json --save_model_as=safetensors --learning_rate=2e-6 --max_train_epoch=2 --use_8bit_adam --xformers --gradient_checkpointing --mixed_precision=bf16 --full_bf16 --min_bucket_reso=512 --max_bucket_reso=2048

Expected Behavior:
I would expect the function to sanitize the inputs without any issues.
Actual Behavior:
The function fails and returns the above error message.
Environment:
OS: Ubuntu 20.04
Language/Runtime Version: python 3.9
I've reviewed the existing issues and pull requests but didn't find anything that seems to match this problem. Any insights or hints on what could be causing this error would be greatly appreciated.
Thank you for your assistance.
Best regards,
Alfredplpl

Sorry. I just have found a command error.
dataset_config=detailed_images.json is NOT correct.
dataset_config=detailed_images.toml is  correct.
Thanks.


mail relay configuration

creates deploy_mailrelay that forces outbound email to go through the server defined at the "mailrelay" group (if defined at all)
also sets django mail server to localhost for ICDS (since we're taking care of thing at the MTA level)

@javierwilson do we want to add this to the full stack deploy?

@sravfeyn  i'm actually moving this variable to the inventory and calling it "parent_mailrelay" which makes more sense since this variable is dependant and affects only the mailrelay host i've modified the dev inventory to test this in my dev environment.
@calellowitz not just yet... however, since it only affects deployment if it has the [mailrelay] group defined, it shouldn't be a problem. we'll test this soon in icds and come back to you on this one.

What happens when we get throttled by NIC?

Postfix has its own way to deal with this, it actually depends on how NIC does it, if they send temp fails, they postfix will retry later, which should be the right way.
Also, postfix is pretty flexible, we could configure how/when to retry, how often, etc, but the defaults I think are the polite way.


Add E/A1 Frames

We're building big models here at TRI for our open source work and we need to fit frames for the largest standard sheet sizes.

Added E frame.  Will wait for YAML interface to support international sizes


False positive updates on table fields

What happened?
Snowflake will automatically convert fields to its internal representation, STRINGs are saved as "VARCHAR(16777216)", TIMESTAMP_NTZs are saved as "TIMESTAMP_NTZ(9)", if you do not use the exact names as represented in the Database, the table creation will work, but every subsequent update will try to update it again to "correct" the types to what is in the pulumi program.
Example
Example: Create a table with column types STRING and TIMESTAMP_NTZ, and when you update after table creation, you'll see it tries to update it again:

The operation is harmless but it shows up as an update each time even though nothing is happening
Output of pulumi about
CLI
Version      3.111.1
Go Version   go1.22.1
Go Compiler  gc
Plugins
NAME       VERSION
aws        5.32.0
awsx       1.0.2
docker     3.6.1
nodejs     unknown
random     4.12.0
snowflake  0.18.1
Host
OS       darwin
Version  14.4.1
Arch     arm64
This project is written in nodejs: executable='/Users/pabloseibelt/.nvm/versions/node/v18.6.0/bin/node' version='v18.6.0'
Current Stack: pulumi/dwh-workflows-loader-cdcbuckets/production
[Truncated resources]
Found no pending operations associated with pulumi/production
Backend
Name           pulumi.com
URL            https://app.pulumi.com/v-pablo-pulumi-corp
User           v-pablo-pulumi-corp
Organizations  v-pablo-pulumi-corp, pulumi
Token type     personal
Dependencies:
NAME               VERSION
@pulumi/random     4.12.0
@pulumi/snowflake  0.18.1
@types/node        16.18.18
@pulumi/aws        5.32.0
@pulumi/awsx       1.0.2
@pulumi/pulumi     3.58.0
Pulumi locates its logs in /var/folders/0g/n3hrlpn56jb72cnjwggcy3kh0000gn/T/ by default
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

I opened a bug upstream with a full repro in terraform: https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2733

The upstream issue has been closed, so I'm closing this one too


Updated Cloud Services reference in table

Table for cloud services referred to Batch - updated to reflect Cloud Services.

@ciphertxt : Thanks for your contribution! The author, @kydeeds, has been notified to review your proposed change.

Merging this PR. @ciphertxt , Thank you so much for your contribution!


cirq.read_json() fails to read a json containing a QasmUGate

Description of the issue
The function cirq.read_json() fails to read a json containing a QasmUGate. Even if the json was created by cirq.to_json().
How to reproduce the issue
import cirq.contrib.qasm_import
qasm = """OPENQASM 2.0;
include "qelib1.inc";
qreg q[1];
u3(3,1,2) q[0];
"""
circuit = cirq.contrib.qasm_import.circuit_from_qasm(qasm)
cirq.read_json(json_text=cirq.to_json(circuit))

This will produce the following error:

ValueError                                Traceback (most recent call last)
 in
6 """
7 circuit = cirq.contrib.qasm_import.circuit_from_qasm(qasm)
----> 8 cirq.read_json(json_text=cirq.to_json(circuit))
~/.pyenv/versions/3.8.5/lib/python3.8/site-packages/cirq/protocols/json_serialization.py in read_json(file_or_fn, json_text, resolvers)
628
629     if json_text is not None:
--> 630         return json.loads(json_text, object_hook=obj_hook)
631
632     if isinstance(file_or_fn, (str, pathlib.Path)):
~/.pyenv/versions/3.8.5/lib/python3.8/json/init.py in loads(s, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, **kw)
368     if parse_constant is not None:
369         kw['parse_constant'] = parse_constant
--> 370     return cls(**kw).decode(s)
~/.pyenv/versions/3.8.5/lib/python3.8/json/decoder.py in decode(self, s, _w)
335
336         """
--> 337         obj, end = self.raw_decode(s, idx=_w(s, 0).end())
338         end = _w(s, end).end()
339         if end != len(s):
~/.pyenv/versions/3.8.5/lib/python3.8/json/decoder.py in raw_decode(self, s, idx)
351         """
352         try:
--> 353             obj, end = self.scan_once(s, idx)
354         except StopIteration as err:
355             raise JSONDecodeError("Expecting value", s, err.value) from None
~/.pyenv/versions/3.8.5/lib/python3.8/site-packages/cirq/protocols/json_serialization.py in obj_hook(x)
625
626     def obj_hook(x):
--> 627         return _cirq_object_hook(x, resolvers, context_map)
628
629     if json_text is not None:
~/.pyenv/versions/3.8.5/lib/python3.8/site-packages/cirq/protocols/json_serialization.py in _cirq_object_hook(d, resolvers, context_map)
352             break
353     else:
--> 354         raise ValueError(f"Could not resolve type '{d['cirq_type']}' during deserialization")
355
356     from_json_dict = getattr(cls, 'from_json_dict', None)
ValueError: Could not resolve type 'QasmUGate' during deserialization

Cirq version
0.13.1

The bug is caused because QasmUGate does not follow the JSON serialization rules defined by serialization.md. An object is serialized to JSON with the help of a _json_dict_ method and restored by a _from_json_dict_ method. QasmUGate does not provide either of them. The above circuit example can be serialized because QasmUGate inherits Gate, which has a _json_dict_ method. The generated JSON string is
{
  "cirq_type": "Circuit",
  "moments": [
    {
      "cirq_type": "Moment",
      "operations": [
        {
          "cirq_type": "GateOperation",
          "gate": {
            "cirq_type": "QasmUGate"
          },
          "qubits": [
            {
              "cirq_type": "NamedQubit",
              "name": "q_0"
            }
          ]
        }
      ]
    }
  ],
  "device": {
    "cirq_type": "_UnconstrainedDevice"
  }
}

It contains only the type of gate (QasmUGate) but lacks angle parameters. The datatype QasmUGate is not included in the file json_resolver_cache.py, so that the unserializing process has no idea what class to translate JSON type QasmUGate to.
I have added _json_dict_ and _from_json_dict_ methods to QasmUGate and the bug is resolved. If no one is working on this, I can create a PR. The PR should also add the serialization feature to other QASM-related classes, such as  QasmTwoQubitGate (are there more?).

It seems there is no need to serialize QasmTwoQubitGate. I will first create a PR only for QasmUGate and wait for feedbacks.

Thank you @yjt98765 !
Can you please explain why is there no need to serialize QasmTwoQubitGate?

QasmTwoQubitGate is based on linalg.KakDecomposition, but the latter one cannot be serialized (yet). spec.py lists the classes that are not serializable yet, including KakDecomposition. In theory, we should add serialization support to all of these classes, but maybe some of them are not commonly used and the project has other priorities.
https://github.com/quantumlib/Cirq/blob/876bad4f4f204d6015816885d52c2a8aa535f328/cirq-core/cirq/circuits/qasm_output.py#L154-L158
I guess it is safer to defer the support for the serialization until the QASM part is mature, to avoid wasted efforts. But if it is somehow needed, I am also willing to implement it!


[RFC] How do we tackle concepts with unrecognised identifiers?

The MARC tags we read for identifiers on genre/subject either come from a couple of prefilled headings, or a freeform text field in a different subfield:

Second Indicator
0 - Library of Congress Subject Headings
1 - LC subject headings for children's literature
2 - Medical Subject Headings
3 - National Agricultural Library subject authority file
4 - Source not specified
5 - Canadian Subject Headings
6 - Répertoire de vedettes-matière
7 - Source specified in subfield $2
https://www.loc.gov/marc/bibliographic/bd651.html

It's that 7 which is causing us issues.
The current code rejects anything that's not "0" or "2", and so we have ~250k records on the DLQ. Some of these have second indicator "4", which is a small patch.
The remaining genres/subjects come from all over the shop. This is a brief tally from the first 4000 records:
Counter({'aiatsiss': 2,
         'bidex': 5,
         'bisacsh': 57,
         'blmlsh': 6,
         'cct': 22,
         'dcs': 2,
         'eclas': 88,
         'eflch': 1,
         'embne': 4,
         'fast': 8107,
         'fssh': 3,
         'gmgpc': 392,
         'gmgpc ': 4,
         'gnd': 2,
         'gsafd': 1,
         'idszbz': 10,
         'idszbzes': 3,
         'inriac': 4,
         'jhpk': 3,
         'jlabsh/4': 1,
         'larpcal': 139,
         'lcgft': 27,
         'local': 198,
         'ram': 174,
         'rasuqam': 22,
         'rbgenr': 444,
         'renib': 16,
         'rero': 8,
         'retrosciences': 1,
         'sao': 1,
         'sigle': 7,
         'unbist': 6})

I think we have a couple of options:

Ignore all of them
Add enumerations for the most common identifier schemes, and ignore the rest
This list seems to be (partially) populated from the MARC site https://www.loc.gov/standards/sourcelist/genre-form.html – we could get rid of the enumeration, and load this list as a resource (a la Miro contributors). If we go down this approach, we might need to think about getting rid of the snake-case-strings and replace them with proper sentences (which we might want to do anyway!)

If we go down the route of lc-subjects, lc-childrens-subjects, and so on, I’d like to push for having a human-readable label. Some of the names are quite opaque, and not especially searchable.

Passing to Jonathan as part of a more general “what do identifiers look like” question.

So chatting to Jonathan just now:

As a temporary fix, I’ll modify the transformer to drop any identifiers which aren’t LCSH, MESH or (no ID), which empties the DLQs.

We want to think about moving to a new model for identifiers, maybe something like:
{
    "scheme": "lc-subjects",
    "description": "Library of Congress Subject Headings",
    "value": "lcsh-123",
    "type": "Identifier"
}

with the details to be fleshed out while chatting to Silver.

Don't index the description field (or similar) in Elasticsearch.

Proposed change to identifier model:
"identifiers": [
{
"indentifierType":
{
"id" : "lc-subjects" ,
"label" : "Library of Congress Subject Headings" ,
"type" : "IdentfierType"
} ,
"value": "lcsh-123",
"type": "Identifier"
}
]

If we are happy with new model this has implications for id model across the transforms. For example contributor, production event..

Blocked on #2190.


Addressing some comments from Jon

Addressing a batch of naming/nit/conventional comments from #7.

Two more bits, then I think this is good to go. After that, I'll probably do another pass over the actual processor code to make sure it's all coherent

Sounds good but I planned at least 2 more PRs to address #7, so I'm not sure if it's better to wait for those or to do it before I roll those?

Vote state enum & state machine
Multiple governance configs

Ah ok, perfect, I'll wait for those then


change core to core_deku; format codes

The folder core has the same name with the library Core of JaneStreet. It will conflict when using the core_bench for benchmarking.
Format codes by adding space between functions, make it easier to read codes.

The thing is, some of us have a pretty strong opinion on what line should be blank or not. I don't (but I wish this would be enforced by ocamlformat), but I have to ask for other persons' opinion here.

Yes, I agree on the ocamlformat. If we get opinion to favor it, then I can split this work in ocamlformat and the changing of core -> deku_core into 2 PRs.


VectorstoreIndexCreator cannot load data from WebBaseLoader

Hello,
I am trying to use webbaseloader to ingest content from a list of urls.
from langchain.indexes import VectorstoreIndexCreator
from langchain.document_loaders import WebBaseLoader

loader = WebBaseLoader(urls)
index = VectorstoreIndexCreator().from_loaders([loader])

But I got an error like ,
ValueError: Expected metadata value to be a str, int, or float, got None

I have the same error while trying to load from a list of urls with WebBaseLoader, but didnt get the error when adding
index = VectorstoreIndexCreator().from_loaders([loader]).**vectorstore**

Hello, I am trying to use webbaseloader to ingest content from a list of urls.
from langchain.indexes import VectorstoreIndexCreator
from langchain.document_loaders import WebBaseLoader

loader = WebBaseLoader(urls)
index = VectorstoreIndexCreator().from_loaders([loader])

But I got an error like , ValueError: Expected metadata value to be a str, int, or float, got None

Hi [youshikyou], were you able to solve the problem?

whoever ends up here. I didn't solve this issue. But I use
loader = WebBaseLoader(urls)
docs = loader.load()
for doc in docs:
  doc.page_content = doc.page_content
  doc.metadata = {"url": doc.metadata["source"]}
text_splitter = RecursiveCharacterTextSplitter(chunk_size=1000, chunk_overlap=0)
texts = text_splitter.split_documents(docs)
....

When I replied this message, I haven't tried usai's solution.

I have the same error while trying to load from a list of urls with WebBaseLoader, but didnt get the error when adding
index = VectorstoreIndexCreator().from_loaders([loader]).**vectorstore**

Hi, I'm still fighting with this issue.    Can you share a bit more of the code where you used this to fix the error?
I'm not sure where I would fit this into my code snippet below:
for can_url in canopy_url_list:
loader = WebBaseLoader(can_url)
# print(can_url)
scrape_data = loader.load()
#scrape_data.metadata = fix_metadata(scrape_data.metadata)
#scrape_data.metadata = {"url": scrape_data.metadata["source"]}
documents.extend(scrape_data)

whoever ends up here. I didn't solve this issue. But I use
loader = WebBaseLoader(urls)
docs = loader.load()
for doc in docs:
  doc.page_content = doc.page_content
  doc.metadata = {"url": doc.metadata["source"]}
text_splitter = RecursiveCharacterTextSplitter(chunk_size=1000, chunk_overlap=0)
texts = text_splitter.split_documents(docs)
....

When I replied this message, I haven't tried usai's solution.

doc.page_content = doc.page_content
doc.metadata = {"url": doc.metadata["source"]}
Solved it for me

Fixed in #8175 - can close now.

@baskaryan Would you mind closing this issue per the above? I don't have triage perms :)

The error occurs because a Key in the metadata has a value set to None.
To fix the error, set the key-value to an empty string or int.
for doc in docs:
for key, value in doc.metadata.items():
if value is None:
print('Metadata key and Value: ', key, value)
doc.metadata[key]= ''

from langchain.document_loaders import WebBaseLoader
from langchain.indexes import VectorstoreIndexCreator
url = 'https://lilianweng.github.io/posts/2023-06-23-agent/'
loader = WebBaseLoader(URL)
This made me crazy.
loader.load not working. Please fix it.


No option to select firmware version

Hi,
Thanks for all your hard work (in the 5th issue or what?),
Perhaps you could keep old firmwares available for download, in case of an issue?
Thanks!

part of the problem is that there is some dependence between the script and firmware.  With the most recent firmware update, I added a feature to the script to re-introduce software write protect, but that required reworking the firmware layout, so it can't be used with older firmware builds.  So I'd have to detect when flashing an older version and disable that feature, which just adds complexity on top of managing multiple firmware versions.  There's several similar issues like this (such as changing from md5 to sha1 checksums) which would require significant effort to offer older builds.

Or you could just keep hosting old builds, and I can just clone this repo
and run manually...?
On Thu, 11 Oct 2018, 22:49 MrChromebox<EMAIL_ADDRESS>wrote:

part of the problem is that there is some dependence between the script
and firmware. With the most recent firmware update, I added a feature to
the script to re-introduce software write protect, but that required
reworking the firmware layout, so it can't be used with older firmware
builds. So I'd have to detect when flashing an older version and disable
that feature, which just adds complexity on top of managing multiple
firmware versions. There's several similar issues like this (such as
changing from md5 to sha1 checksums) which would require significant effort
to offer older builds.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MrChromebox/scripts/issues/73#issuecomment-429130829,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFV2wt0554QQIficpajNyw14kZweHn9Jks5uj7zZgaJpZM4XYIkQ
.

I'd need to rework the directory structure, since hosting multiple versions for 50+ devices in a single directory isn't the best (it's not even the best for a single version at this point).  I'd also need to filter out the older versions which were problematic and wouldn't want people to be able to flash.  It's no small order


aws_cloudformation_stack indefinitely reapplies changes in NoEcho parameters

I just ran into this issue using terraform to manage our Buildkite CloudFormation stacks:
https://github.com/terraform-providers/terraform-provider-aws/issues/55
This diff shows up indefinitely:
Terraform will perform the following actions:
  ~ module.buildkite.aws_cloudformation_stack.buildkite
      parameters.BuildkiteAgentToken: "****" => "<redacted>"

My naive fix was to add this to my terraform config:
lifecycle {
  ignore_changes = [
    "parameters.BuildkiteAgentToken",
  ]
}

but that results in writting **** as the token value during stack updates, which prevents the agents from booting successfully given the invalid token.
I know Buildkite uses Terraform internally. Have you been able to work around this problem?
Thanks!

This is a tricky one! Looks to be a gnarly Terraform bug. I'm not sure what to suggest, I think removing NoEcho would be a pretty bad decrease in practical security for non-terraform users.

@dblandin we are using the naive fix, and we haven't found issues with it. We are using Terraform v0.11.7.

@arturopie How do you handle terraform diffs that trigger a stack update vs create/destroy?
I've found that with the lifecycle, ignore_changes approach, I need to mark the resource as tainted after any paramater update in order to trigger the recreation of the stack so that the right token value is threaded through.

@dblandin I see. We try to avoid stack updates, since we have ran into other issues with cloudformation stack updates. We treat it as an immutable resource. We destroy it and create it when we change it.

I actually got the chance to talk to the engineers that maintain the aws integration for terraform. I mentioned this to them, they said it should be fixable and they will see what they can do.

Also, parameter values being sent to a NoEcho parameter should be marked as sensitive by the aws provider so they are not output in the terminal.

Yeah, this is a terraform issue.

FYI. PR #601 should resolve this once it is been tagged/released. You will need to change to using an SSM parameter instead so that the value isn't included in the template and instead the template refers to an SSM parameter path

I know Buildkite uses Terraform internally. Have you been able to work around this problem?

We use terraform internally, but note with our elastic stacks. Until today, when we ran into this issue as well.
Our short term workaround was a variation of the one proposed here:
lifecycle {
  ignore_changes = [
    parameters["BuildkiteAgentToken"],
  ]
}

.. but we agree that's not ideal. We'd like to move to BuildkiteAgentTokenParameterStorePath described in https://github.com/buildkite/elastic-ci-stack-for-aws/pull/601

Hi team, any idea if/when the next release might be tagged to get this going?

This would be great to have available, the output for this constantly updating resource in the latest version of Terraform is very verbose (1200+ lines 😱)

Since v5.0.0 has been released, we started using BuildkiteAgentTokenParameterStorePath instead of the BuildkiteAgentToken to get around this.

We've also "fixed" this by using BuildkiteAgentTokenParameterStorePath instead of BuildkiteAgentToken on our v5.0.0 stacks that are managed by terraform.
I think that's our recommended workaround now, so I'll close this. If there's a reason that workaround isn't viable in all situations, give a shout and we can re-open :heart:

Can confirm it's a far better solution! Thanks team!


strange error

I have a strange error when trying to export a container:
Exported variable 'ThemeProvider' has or is using name 'ContainerProviderProps' from external module
import { useState } from 'react';
import { createContainer } from 'unstated-next';

function useTheme() {
  const [settings, setTheme] = useState<string>('default');

  return { settings, setTheme };
}

const { Provider: ThemeProvider, useContainer } = createContainer(useTheme);

export { ThemeProvider, useContainer };

maybe it is not due to this lib

fixed by removing the line "declaration": true from my tsconfig.json

Should be fixed by https://github.com/jamiebuilds/unstated-next/pull/7


Add Contributing guidelines

Is your feature request related to a problem? Please describe.
I would like to know how I can correctly contribute to this repo. E.g. do I need to write commits in a certain way (keeping in mind automated changelogs perhaps) and all that good stuff.
Describe the solution you'd like
A CONTRIBUTE.md on how to correctly contribute to RNV. You can look at Github's docs on this here; https://help.github.com/en/github/building-a-strong-community/setting-guidelines-for-repository-contributors
Additional context
Examples of contributing documentation;

https://github.com/angular/angular/blob/master/CONTRIBUTING.md
https://github.com/angular/angular.js/blob/master/DEVELOPERS.md

@sanderlooijenga good point. will put proper contribution guidelines together soon.


Floating window not displaying

I tried adding this plugin to my configuration for neovim (0.5.1) with ddc, but it doesnt seem to work. When I try to complete a call to a c++ stl function (such as vector.push_back()), there is nothing displayed besides the completion suggestions window
Here is my full config: http://paste.awesom.eu/bNiJ

Hi.  Have you read the documentation??
https://github.com/matsui54/ddc-nvim-lsp-doc#ddc-nvim-lsp-doc

If you use Vim or pum.vim, use denops-popup-preview.vim instead.

Pum.vim is not supported and you have used pum.vim in your vimrc.
So it is intended behavior.  You should close the issue.

Yes. You can use both signature help and completion documentation feature with this configuration.
  let g:ddc_nvim_lsp_doc_config = {
        \ 'documentation': {
        \   'enable': v:false,
        \ },
        \ }
  call popup_preview#enable()
  call ddc_nvim_lsp_doc#enable()


Support overridden setters

Me again, from the very-similar #62 :stuck_out_tongue: .
We've been using v2.1.3 in prod for a while, but recently noticed some odd issues, and finally traced it back to the fact that this validator actually overrides the model setter.
Backing up to provide some history: this is the same codebase as in #62. Not only does it override the Rails-provided getters to lookup references and return Ruby objects, it inversely overrides the Rails-provided setters: accept an object and turn it into a rich reference.
A fair amount of our code actually hands it pre-formed rich references anyway so we didn't notice the issue until we actually tried to hand it a model, and it didn't work the way we expect where we have this validator configured because the actual setter that is called isn't ours, it's yours.
The comment you have there is helpful: I believe you are redefining the setter so that you can catch invalid json before the validation runs, but I'm not entirely clear why you don't just lean on the validation for that. It would catch invalid json, right? Could it be enhanced to write the #{attribute}_invalid_json attribute? i.e. is this setter even necessary? If it is, perhaps it should be done in a module added to the ancestry instead of patching the class itself.

Unfortunately, the fix in #71 breaks the following code (prepending the injected setter bypasses our setter before the input can be coerced):
validates :foo, json: { schema: SCHEMA }

def foo=(value)
  super(value.is_a?(String) ? YAML.safe_load(value) : value)
end

Ideally there might be a solution that doesn't inject accessors into the model. ActiveModel::Validations doesn't actually require accessors to even be defined, so for example this code will never invoke the injected setter:
class User
  include ActiveModel::Validations

  validates :profile, json: { schema: PROFILE_JSON_SCHEMA }

  def initialize(data)
    @data = data
  end

  # override method for passing attributes to the validator
  # https://github.com/rails/rails/blob/main/activemodel/lib/active_model/validations.rb#L415
  def read_attribute_for_validation(key)
    @data[key]
  end
end

Unfortunately, the fix in https://github.com/mirego/activerecord_json_validator/pull/71 breaks the following code (prepending the injected setter bypasses our setter before the input can be coerced):

Oh no! Sorry for the breakage. How did this work for you in the past? The validator completely overwrote your foo= setter, no?

@kyrofa with activerecord_json_validator 2.1.1, it looks like our code was overwriting the injected setter because our setter was declared later than the call to validates:
validates :foo, json: { schema: SCHEMA }

def foo=(value)
  puts "our code"
  super(value.is_a?(String) ? YAML.safe_load(value) : value)
end

if the order is reversed, I can confirm that the validator does completely overwrite our code:
def foo=(value)
  puts "our code" # never gets called
  super(value.is_a?(String) ? YAML.safe_load(value) : value)
end

validates :foo, json: { schema: SCHEMA }

with the change in #71, the injected setter always gets called first, then calls super which is our setter, but by then the injected setter has already modified the input.

So it really sounds like this is broken either way. This will require some thought.


Simplify Wallet Tools EOSIO Blockchain Detection for End Users

Follow-up to thread: https://github.com/EOSIO/eos/pull/5438
A simple addition of core_symbol to get_info results will go a long way in making it easier for users to interact with all EOSIO chains, by simply entering an endpoint. The get_info results from this endpoint should return not only the chain info as is today, but also the CORE_SYMBOL, making EOSIO extremely easy to interact with/configure for multi-chain use from an end user's perspective. Both eosjs and eosjs-ecc supports different prefixes for public keys (e.g EOSxxx, TLOSxxx, etc), so core support for returning the core symbol can help make multichain support faster and out of the box!

Both eosjs and eosjs-ecc supports different prefixes for public keys (e.g EOSxxx, TLOSxxx, etc), so core support for returning the core symbol can help make multichain support faster and out of the box!

Returning CORE_SYMBOL information in get_info is a nice improvement. It doesn't, however, solve the key prefix problem. e.g. most test chains have a system token of either SYS or EOS, and keep the key prefix as is.
Chains modifying the key prefix is a bug. It creates a gratuitous incompatibility to support a "brand". See #5467 for how we plan to address that bug.

#5467 will never be adopted for users. How keys are handled internally in the EOSIO system is irrelevant to the average user. Every one of us have been issued an "EOSxxx" public key - most will not go through the hassle of replacing this with a PUBxxx key. As a result, the user-facing method of key support must always be supported for backwards compatibility purposes. Most new chains are also maintaining this pattern (PREFIXxxx) public key, so this is a welcoming addition that'll make things simpler for users.
I've been writing software for 20 years - guess what? I personally won't go through the hassle of changing my EOSxxx public keys simply because it pleases developers. Will I be forced to convert to a PUBxxx format or be at risk of losing my EOS?
If it ain't broke, don't fix it.

No conversion necessary for chains which didn’t mess with the prefix. It will always accept the EOSxxx format as input. On output it will use PUB_K1_xxxx. 1 key, 1 binary format, 2 currently-existing ascii formats.

Please test with different combinations of versions of cleos and nodeos.

Have tested with 1.2.1. Will test with previous minor revisions. Thanks

Specifically test with different versions of cleos and nodeos. old nodeos & new cleos. new nodeos & old cleos.

I'm going to have to apologize on this one. We recognize that wallets and apps need a reliable way to retrieve core symbol info, and this appeared to be the right way to do it. Unfortunately having the API expose these fields creates a problem for a couple of our long-term development thrusts. We want future API versions to not depend on certain contracts being on the chain, such as the system contract or the token contract. We see the need for apps and wallets to conveniently access contract-specific information, for example the core token symbol, so we intend to address this in a future version of the API, but in a more general way. In the mean time, we don't want to continue adding contract-specific information to the existing API.
We're going to have to undo this PR. For the near term, there is a workaround, though it's not ideal. If you call get_account on a well-known account that's likely to have a balance, e.g. eosio or eosio.stake, then core_liquid_balance will have the correct symbol. We're striving for a much better solution for this long term.


Make generated models that don't need to be visible in the public API internal

Per @m-nash:
Another thing to consider here is with MPG we found quite a few models that are defined in the swagger that don't need to be public in the SDK.  Typically this was handled by the input/output/model usages however this didn't always get things correct.  We added an extra step in post processing to auto mark anything not needed to be public as internal.
[Description TBD]

@ArcturusZhang , with your work of internalizer and remover, I believe this problem should be resolved.
Could you help to summerize the design and put it in https://github.com/Azure/autorest.csharp/tree/feature/v3/docs
Thanks


Wildebijen.nl

https://www.wildebijen.nl/determinatiegids.html

Individual keys will be added in the upcoming checklist feature.


Is it possible to serialize a sequence of maps/sequences without knowing maps/sequences upfront?

I want to make a proxy serializer, that serializes enums as arrays (this is needed for compatibility with another language/library). E.g. I want to serialize Enum::Struct { a, b } as ["Struct", {"a": a, "b": b}]. But I've got a problem:

To serialize ["Struct", ..] in serialize_struct_variant I need to call .serialize_seq() on the inner serializer
Then I need to return something implementing SerializeStructVariant
SerializeStructVariant requires serializing field-by-field, so I can't just call .serialize_element(map) on the inner serializer's SerializeSeq (I don't have the map upfront)
SerializeStructVariant::serialize_field takes a &T where both the lifetime and the type are generic which means that I can't save the value into a map

Is there any way to get around these limitations?
Also, it seems that the problem is equivalent to unflattening sequence, i.e. serializing [a, b, c, d, e] as e.g. [[a, b], [c, d], [e]].

That isn't a hard requirement, but it would be a lot more convenient since I wouldn't need to think about every occurrence of an enum.

Previous work on this topic: #768. It ended up not being reasonably implementable at the time.
I think I would recommend directly using format-specific APIs when this style of serialization is a requirement. For example in the case of JSON, serializing a sequence of maps/sequences without knowing the maps/sequences up front is possible by directly interacting with serde_json::ser::Formatter.


Make a copy for input when calling FFT on CUDA 10.1+

#3763 adds a warning that inputs may be modified (because cuFFT performs in-place operation), but it's better to make a copy for input before calling cuFFT.

Make a copy by default.
Provide an option to avoid copy, e.g., cupy.fft(..., *, overwrite_x=False) for users needing performance. (using keyword argument as this is not numpy-compatible)

This feature is not to be backported to v7.

Make a copy by default.

I think we only need to do this for certain kinds of FFT (like C2R). I am digging into the docs.

If cuFFT aims to be interchangable with FFTW, then we only need to worry about C2R transforms (i.e., irfft, irfft2, irfftn). See https://github.com/cupy/cupy/issues/3736#issuecomment-672073361 and the cuFFT documentation:

Note that in-place complex-to-real FFTs may overwrite arbitrary imaginary input point values when non-unit input and output strides are chosen. Out-of-place complex-to-real FFT will overwrite input buffer if custom strides are set by the user.


Javalin 'Hello world!' application

Hello world application for the Javalin framework (solves https://github.com/networknt/microservices-framework-benchmark/issues/58).

@JindrichPilar Thanks a lot for your contribution. We recently switched from HTTP to HTTPS for all the tests. Would you be able to enable the HTTPS for the Javalin?

@stevehu HTTP(S)/2 support added. Ports 8080 and 8443.

@JindrichPilar for some reason, the https doesn't work.
steve@freedom:~/networknt/microservices-framework-benchmark$ wrk -t4 -c128 -d30s https://localhost:8443 -s pipeline.lua --latency -- / 16
Running 30s test @ https://localhost:8443
  4 threads and 128 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     0.00us    0.00us   0.00us    -nan%
    Req/Sec     0.00      0.00     0.00      -nan%
  Latency Distribution
     50%    0.00us
     75%    0.00us
     90%    0.00us
     99%    0.00us
  0 requests in 30.01s, 0.00B read
  Socket errors: connect 0, read 210183, write 0, timeout 0
Requests/sec:      0.00
Transfer/sec:       0.00B
steve@freedom:~/networknt/microservices-framework-benchmark$ wrk -t4 -c128 -d30s http://localhost:8080 -s pipeline.lua --latency -- / 16
Running 30s test @ http://localhost:8080
  4 threads and 128 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency    38.98ms   52.73ms 564.62ms   86.07%
    Req/Sec   111.61k    55.02k  222.63k    63.22%
  Latency Distribution
     50%   16.47ms
     75%   54.36ms
     90%  114.21ms
     99%  227.66ms
  13047542 requests in 30.06s, 1.59GB read
Requests/sec: 434065.06
Transfer/sec:     54.23MB

@JindrichPilar There is an issue with HTTPS under high load. I am wondering if you could take a look at it. I also record a video here

I will take a look, I think I have time tomorrow.
On Tue, 17 Mar 2020, 22:18 Steve Hu<EMAIL_ADDRESS>wrote:

@JindrichPilar https://github.com/JindrichPilar There is an issue with
HTTPS under high load. I am wondering if you could take a look at it. I
also record a video here
https://www.youtube.com/watch?v=VGMuoWfn4jc&list=PL6icvRU_5ZOVKD9slJTArx74O_CVQf8La
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/networknt/microservices-framework-benchmark/pull/65#issuecomment-600306182,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWYTT3ARWISANULL5BAU2LRH7SKFANCNFSM4LMG5JMQ
.

It seems there was a problem with protocol negotiation in my Jetty configuration. Wrk wasn't able to automatically fallback to HTTP 1.1 + TLS. Curl with explicit --http1.1 or  --http2 was able to  switch protocols.
While it seems wrk doesn't support HTTP/2, I was able to measure noticeable difference in throughput between 8443 and 9443 ports.
I updated the configuration and added another port, so now:
8080 - plain HTTP
8443 - HTTP1.1 + TLS
9443 - HTTP/2 with fallback to HTTP1.1 + TLS


Collaborate with vscode-pegjs

See repo
@tamuratak do you have any interest in collaborating?  We're re-invigorating Peg.js as Peggy, and in my opinion it would be great if we had one VSCode plugin that was a superset of the options the Peg.js world had.

I'm sorry, but I'm not interested at this time.
I do respect the development of Peggy. I hope it will be a success.


Make GTM ID a config option

Fixes #24
Fixes #25

@rokkie can you also provide a documentation on how we are planning to use these changes, that closes #25 ?

I've updated the readme.
It fixes #24 by not injecting the GTM script tag when enabled is false.
It fixed #25 by allowing an additional id option.

@mib200 can you cut a release now that this has been merged?

@evan-coygo release as version 2 on NPM. 👍


Toggle comment (ctrl+1) does not always preserve indentation with 2 spaces

In the editor. Toggling comments works with indent=0 or 4 (spaces) but not with indent=2. Going back an forth, ie comment/uncomment using twice ctrl+1 results in an additional space (3), breaking python indentation.
Current spyder master.
My preferred indentation is set to 2 spaces.

Thanks for the fix but actually I don't think it should be related to user preference.
Supposed you read someone else code (with different preferences) and you want to test different things by comment/uncomment. The comment/uncomment should leave the code as is without paying attention to conflicting reader/writer's preferences.
AFAIU for commenting either one puts '#' before or after the indentation. Personally I prefer after to keep seeing code's structure. For uncommenting just remove this '#'. The only small difficulty being to know if with a single shortcut, one wants to comment or uncomment (case of several '##' or inconsistent lines...). Maybe the decision can simply be taken on the 1st line by the presence of a '#'. Just my 2c.
Thanks anyway.
With the fix, it still does not work if the code is indented differently than my preferences.


Basic Authentication Support

A client uses basic authentication for the map tiles. The problem is that usernames and passwords are no longer supported in web site adresses. So the map tiles won't load in internet explorer using that method. For example<EMAIL_ADDRESS>I'll need a workaround without using a proxy. Is it possible to add such a feature to Leaflet?

This is a browser related issue: https://gis.stackexchange.com/questions/294321/basic-authentication-in-leaflet/359840#359840


ERROR in running 'run_scripts/pope_eval.py'

Thanks for your good work! But I got confused when I ran evaluation of POPE.
At first, I run:
python run_scripts/pope_eval.py --model llava-1.5 --data_path /home/duyuetian/COCO/val2014 -d vcd --pope_type random --num_images 100 --seed 0 --gpu_id 0 --output_dir ./generated_captions/ --noise_step 100
but it didn't work because of the error below:
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:3! (when checking argument for argument mat1 in method wrapper_CUDA_addmm)
So I roughly solved it by adding the "CUDA_VISIBLE_DEVICES" param:
CUDA_VISIBLE_DEVICES=0 python run_scripts/pope_eval.py --model llava-1.5 --data_path /home/duyuetian/COCO/val2014 -d vcd --pope_type random --num_images 100 --seed 0 --gpu_id 0 --output_dir ./generated_captions/ --noise_step 100
But it is not useful for more universal scenarios, so I wonder if there is a way to solve the problem at the root？Appreciate it.

Thanks for your question! I also encounter the problem with LLaVA-1.5 on two devices. It might be due to some of the intermediate variables being accidentally cast to the other device when we develop the code base. However, there is no such issue for other three VLMs, and you can try to run them as well. I will check the code and let you know the updates. Thank!

Thanks for your question! I also encounter the problem with LLaVA-1.5 on two devices. It might be due to some of the intermediate variables being accidentally cast to the other device when we develop the code base. However, there is no such issue for other three VLMs, and you can try to run them as well. I will check the code and let you know the updates. Thank!

Thanks a lot!

Hello! I have the same problem, is there a solution that will allow me to run LLaVA-1.5 normally?

I encountered the same issue. When I use the LLaVA-1.5 model and specify the GPU with CUDA_VISIBLE_DEVICES=0, I get a memory error: torch.cuda.OutOfMemoryError: CUDA out of memory. However, when I don't specify the GPU, I get the following error: RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:1! (when checking argument for argument mat1 in method wrapper_CUDA_addmm).

Hi, the OOM error is probably just because there is not enough memory. I will try to fix the cuda device issue this week.

Thanks! :)


TypeError: com.google.android.gms.ads.AdView is not a function

Hi,
Sorry, me again. I'm still trying to make this work. I can successfully build and run the demo admob app and I can see the ad but in my app I guess I'm missing something. I keep getting this error:
JS: Error in admob.createBanner: TypeError: com.google.android.gms.ads.AdView is not a function JS: admob createBanner error: TypeError: com.google.android.gms.ads.AdView is not a function
Any idea is welcome.

Can you share your project?

Here is the relevant piece of my project:
view js:
`var admob = require("nativescript-admob");
exports.loaded = function(args) {
page = args.object;
page.bindingContext = pageData;
googleAnalytics.logView("tabs");
pageData.city = cache.get(config._CACHE_KEY_CITY);
pageData.country = cache.get(config._CACHE_KEY_COUNTRY);
createAdmobAd();
};
function createAdmobAd() {
admob.createBanner({
// if this 'view' property is not set, the banner is overlayed on the current top most view
// view: ..,
testing: true, // set to false to get actual banners
size: admob.AD_SIZE.SMART_BANNER, // anything in admob.AD_SIZE
iosBannerId: "ca-app-pub-9517346003011652/3985369721", // add your own
androidBannerId: "ca-app-pub-9517346003011652/7749101329", // add your own
// Android automatically adds the connected device as test device with testing:true, iOS does not
iosTestDeviceIds: ["yourTestDeviceUDIDs", "canBeAddedHere"],
margins: {
// if both are set, top wins
//top: 10
bottom: 50
}
}).then(
function() {
console.log("admob createBanner done");
},
function(error) {
console.log("admob createBanner error: " + error);
}
);
}
`
xml:
<Page xmlns="http://www.nativescript.org/tns.xsd" loaded="loaded">
... and some tabView
I can not really find a big difference between demo and my project. I guess only difference is that you have an additional level of abstraction main-page.js and main-view-model.js. Do you think that kind of structure would solve my problem?
Thanks.

friendly ping?

If you're on plugin version 1.1.4 or higher you should be able to load an ad from the loaded event, so that's ok.
Just sounds like the native libraries are missing. Can you remove and add the android folder and update your Android libraries (by running android in a terminal)?
And if you need anything else: post the project (not small bits) so I can easily reproduce the error.

Had the same error but a little different as I am using Angular 2
JS: Error in admob.createBanner: TypeError: com.google.android.gms.ads.AdView is not a function JS: admob createBanner error: TypeError: com.google.android.gms.ads.AdView is not a Constructor
I had this happen to me for a while.
Turns out that running livesync right after adding AdMob gives this error.
What I did was:
After adding AdMob plugin and the relevant code to the project, I build and installed the project using tns run andorid
That showed the ad.
After which running livesynce gives no errors.
@hakanu Can you build the project again. Have seen a lot of issues go away doing so. If that does not work try removing and adding the platform again then building your app.

Hello, noobie in NativeScript here. Just to save some time to someone else who stumbles upon the same topic.
Running in the terminal the following commands solved the issue for me:
tns platform remove android
tns platform add android
(it's the advice of Eddy from above. with more detail)
Building the app first for safety
tns build android
and then
tns run android
for livesync.
Another note, if you are trying to create a banner on loaded trying using setTimeout for calling the createBanner to avoid issues.
var loaded = function() {   setTimeout(function() {     admob.createBanner({ ..... });   }, 1000); }
I know these steps may seems obvious to most people after reading the advices above, but they may help save time to a novice in NativeScript like me. Cheers.


UI - treemap charts

Rel: #624
Ref: https://github.com/webpack-contrib/webpack-bundle-analyzer/issues/187

I think this should be rather trivial since we're already generating the stats files, simply generate the HTML file along with it and link to it

I think this should be rather trivial since we're already generating the stats files, simply generate the HTML file along with it and link to it

Which webpack file(s) need to be updated to add webpack-bundle-analyzer and then where would we need to generate the html file to the host server so we can generate a link on the corresponding relative-ci page?

Which webpack file(s) need to be updated to add webpack-bundle-analyzer and then where would we need to generate the html file to the host server so we can generate a link on the corresponding relative-ci page?

@jflayhart the webpack-bundle-analyzer is a great tool and I believe they are doing their own parsing of the sources. Will be really complicated if not impossible to pack it in bundle-stats.
bundle-stats is already extracting and normalising the modules data from the webpack stats, so this issue is more about taking that data and displaying it in a tree map chart. The user can switch between the table and the chart view. It will display only the stat size, but from my experience that's a good enough metric to identify the biggest parts of a chunk.
The tree map library has been the main blocker for me, since the idea was to have the bundle-stats.html as light as possible (all the assets are inlined). The ones depending on D3 are great but they can be quite large. I think there are 2 options to unblock this:

load the charting lib from a cdn
look for lighter treemap option - for example bundlephobia is using something custom

@jflayhart the webpack-bundle-analyzer is a great tool and I believe they are doing their own parsing of the sources. Will be really complicated if not impossible to pack it in bundle-stats.
bundle-stats is already extracting and normalising the modules data from the webpack stats, so this issue is more about taking that data and displaying it in a tree map chart. The user can switch between the table and the chart view. It will display only the stat size, but from my experience that's a good enough metric to identify the biggest parts of a chunk.
The tree map library has been the main blocker for me, since the idea was to have the bundle-stats.html as light as possible (all the assets are inlined). The ones depending on D3 are great but they can be quite large. I think there are 2 options to unblock this:

load the charting lib from a cdn
look for lighter treemap option - for example bundlephobia is using something custom

Here is a quick wireframe of the way i see this feature - https://excalidraw.com/#json=6277084896821248,1i-vE6IxVrVGQH8bt8Et-A. Let me know what do you think ;)

Here is a quick wireframe of the way i see this feature - https://excalidraw.com/#json=6277084896821248,1i-vE6IxVrVGQH8bt8Et-A. Let me know what do you think ;)

the webpack-bundle-analyzer is a great tool and I believe they are doing their own parsing of the sources. Will be really complicated if not impossible to pack it in bundle-stats.

I dont know how your tool works per se, but all these analyzer tools need one thing: the webpack stats.json output file. You should already be generating that with your tool but webpack-bundle-analyser could have an orthogonal relationship with what YOUR tool spits out and simply be used to generate the separate module tree map. The rest is automatically generated into an HTML file that you host and link to somewhere. Which part are you saying is not possible?
I like the dedicated modules tab that's good.
Also, I get you want a lighter lib so that's fair, but webpack-bundle-analyzer is the OFFICIAL one for webpack and should use all the same inputs you should already be generating as the output. Have you tried this and found that's not the case?

the webpack-bundle-analyzer is a great tool and I believe they are doing their own parsing of the sources. Will be really complicated if not impossible to pack it in bundle-stats.

I dont know how your tool works per se, but all these analyzer tools need one thing: the webpack stats.json output file. You should already be generating that with your tool but webpack-bundle-analyser could have an orthogonal relationship with what YOUR tool spits out and simply be used to generate the separate module tree map. The rest is automatically generated into an HTML file that you host and link to somewhere. Which part are you saying is not possible?
I like the dedicated modules tab that's good.
Also, I get you want a lighter lib so that's fair, but webpack-bundle-analyzer is the OFFICIAL one for webpack and should use all the same inputs you should already be generating as the output. Have you tried this and found that's not the case?

P.S. I guess what I am saying for this UI bit you don't to necessarily pack WBA into bundle-stats for consumers like me, you just want it as a means to an end to generate the module graph on RelativeCI, so bundle-stats shouldn't be affected by this.

P.S. I guess what I am saying for this UI bit you don't to necessarily pack WBA into bundle-stats for consumers like me, you just want it as a means to an end to generate the module graph on RelativeCI, so bundle-stats shouldn't be affected by this.

@jflayhart both of the packages are working in a similary way:

extract data (webpack-plugin, stats.json file)
manipulate
report

What i was trying to convey is that bundle-stats is already having the modules data available, it only needs the chart visualisation. We might not need to bring another full reporting tool just for that(not very knowledgeable of the visualisation lib they are using, at a quick glance is looking like it is not open source).
Here is a high level diagram on how everything is working together:

@jflayhart both of the packages are working in a similary way:

extract data (webpack-plugin, stats.json file)
manipulate
report

What i was trying to convey is that bundle-stats is already having the modules data available, it only needs the chart visualisation. We might not need to bring another full reporting tool just for that(not very knowledgeable of the visualisation lib they are using, at a quick glance is looking like it is not open source).
Here is a high level diagram on how everything is working together:

Available for testing and for feedback on v4.13.0-beta.2:
https://github.com/relative-ci/bundle-stats/assets/13300/5ca9726e-8762-4aa6-9fb4-49c26b2e2226
Related tasks:

https://github.com/relative-ci/bundle-stats/issues/4316
https://github.com/relative-ci/bundle-stats/issues/4317

<EMAIL_ADDRESS>
grouped assets/modules/packages by folder

https://github.com/relative-ci/bundle-stats/assets/13300/278218ac-3ba8-4cc7-a7ed-4c7501b2ee17

Released on v4.13.0. Feel free to open a new issue if you encounter any problems or have any feedback to share.
https://github.com/relative-ci/bundle-stats/assets/13300/9ab0d11e-4412-4a79-a2b5-1126d32cd9f9


Value for minHeight can not be greater than maxHeight

Describe the bug
minHeight and maxHeight not setting properly. I am getting error: Value for minHeight can not be greater than maxHeight for following code:
To Reproduce
Steps to reproduce the behavior:
          el.addEventListener('load', () => iframeResizer({
                  checkOrigin: false,
                  minHeight: '99px',
                  maxHeight: '888px',
                  warningTimeout: 5000,
                  scrolling: true,
                }, el))

Expected behavior
It should properly parse integer before checking min and max height.

It expects a number, not a string.


Webhook should update K8s service info for various callback configurations

Expected Behavior
Context: https://github.com/knative/serving/pull/6566#discussion_r374769140
Currently the webhook only updates the CA cert bundle & the webhook path. But it's aware of the fronting service.
Actual Behavior
The webhook should update the K8s service config for Mutating/ValidatingWebhookConfigurations & CRD conversion webhook config

/remove-lifecycle stale

/lifecycle frozen

/lifecycle frozen


[WebView] WebView on android can`t execute javascript

              <WebView
                style={[styles.webview, {
                    height: this.state.height || 400
                }]}
                javaScriptEnabled={true}
                bounces={false}
                onNavigationStateChange={this._onNavigationStateChange}
                html={this._getHTML(content)}
            />

javascript inside WebView page do not execute.
On iOS it works fine.

You need to enable JavaScript via a a prop - http://facebook.github.io/react-native/docs/webview.html#javascriptenabled

@satya164
I have tried that.
Didnt work. Tried to use injectedJavaScript  didnt work either

I tried to use react-native-webview-android
Javscript inside page didn`t execute.
But javascript through injectedJavaScript worked

Can you give a minimal reproducable example of the code that's not working?
cc @mkonicek

We don't provide supports third party plugins Have you tried the one included in React Native?

@satya164
yes.
after I tried everything in React Native.it didn`t work out,then I tried the third party plugin.

/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 */
'use strict';

var React = require('react-native');
var {
  AppRegistry,
  StyleSheet,
  Text,
  View,
  WebView
} = React;

let html =  `
<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta name="format-detection" content="telephone=no" />
    <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no" />

test

test

test

test

test

test

test

test

test

test

test

test

test

test

test

test

test

test

test

`;

var marry = React.createClass({

  render: function() {
    return (
      <View style={styles.container}>
        <WebView
                style={[{
                    height: 400,
                    width: 320
                }]}
                javaScriptEnabled={true}
                bounces={false}
                onNavigationStateChange={this._onNavigationStateChange}
                html={html}
            />
      </View>
    );
  }
});

var styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#F5FCFF',
  },
  welcome: {
    fontSize: 20,
    textAlign: 'center',
    margin: 10,
  },
  instructions: {
    textAlign: 'center',
    color: '#333333',
    marginBottom: 5,
  },
});

AppRegistry.registerComponent('marry', () => marry);

same code.
different result.

closed
The attribute should be javaScriptEnabledAndroid instead of javaScriptEnabled as document said.

javaScriptEnabledAndroid is only used on 0.17.0
0.18.0 javaScriptEnabled  works fine

Is there a resolution for this problem?  As of 0.20 I still can't get Javascript to work on Android.

Also can't get it to work... Here's my render:
render() {
    let html = '
This is my name
';
    let jsCode = 'document.querySelector("#myContent").style.backgroundColor = "red"';

    return (
      <View>
        <WebView
          source={{html: html}}
          injectedJavascript={jsCode}
          javaScriptEnabled={true}
          style={this.props.style}
        />
      </View>
    );
  }

And the result:

The div background should be red.

It seems to work if I include the javascript as a script in html like this:
render() {
  let html = `

This is my name

  `;

  return (
    <View>
      <WebView
        source={{html: html}}
        javaScriptEnabled={true}
        style={{ width: 100, height: 100}}
      />
    </View>
  );
}

Nothing is working is there is any other method to do it

Worked for me by adding baseUrl like this:
<WebView
javaScriptEnabled={true}
source={{html: myHtml, baseUrl: "/"}}
/>

Set true both javaScriptEnabled and domStorageEnabled
javaScriptEnabled={true}
domStorageEnabled={true}

on android I got it finally to work after I've put semicolon ";" at the end of every command, for example;
this works:
let jsCode = `
      document.body.style.backgroundColor = \'#6DAF45\';

      var menuButton = document.getElementById("responsive-menu-button");
      menuButton.parentNode.removeChild(menuButton);

      var header = document.getElementById("header");
      header.style.visibility = \'hidden\';
      header.style.height = 0;

      var innerBannerArea = document.getElementById("inner-banner-area");
      innerBannerArea.style.height = 1;
      innerBannerArea.style.opacity = 0.0;

      var footer = document.getElementById("footer");
      footer.style.visibility = \'hidden\';
    `

and this breaks the whole javascript, check line 2 in "jsCode" in the variable:
let jsCode = `
      document.body.style.backgroundColor = \'#6DAF45\';

      var menuButton = document.getElementById("responsive-menu-button");
      menuButton.parentNode.removeChild(menuButton)

      var header = document.getElementById("header");
      header.style.visibility = \'hidden\';
      header.style.height = 0;

      var innerBannerArea = document.getElementById("inner-banner-area");
      innerBannerArea.style.height = 1;
      innerBannerArea.style.opacity = 0.0;

      var footer = document.getElementById("footer");
      footer.style.visibility = \'hidden\';
    `

The issue seems to depend on the android SDK version.
using 23 fails and it works using version 24 and 25 .
this might require more testing on real device like samsung to see if it works on 23 on some real devices.

@iineva You saved me. I searched whole day. My opencart checkout page is not working in android webview. But by adding setDomStorageEnabled(true) it's worked like charm. Thank you so much.

@Goran1708 Thanks. Solved my problem.

I've figured out Android WebView bug.
Even in Android API >= 23 and react-native 0.52.
=> If your JavaScript code contain any comment => javascript will not run

I have to remove every comments in order for JavaScript to run.

I can confirm that WebView Javascript code is not executed on android 4.4.2 device (API 19) and maybe some higher versions of android. Neither inside  blocks in html, neither inside injectedJavaScript prop. Tried everything described here. I use RN 0.50.0.
Have someone faced with this issue and solved it somehow?

In my case, I was using let instead of var and webview was not able to execute my javascript. Which makes sense. Please double check that you are using plain javascript not ES6 syntax. This is just one of the possibilities.

It’s working on real device but not on emulator


DMS store  sgin session

Motivations

ervery operation in DMS need sgin, it is back user experience

Would you like to implement this feature? [y]

Solution
store session temporary

Alternatives

Additional context

@cherry-yl-sh
All write operations must be signed because the data ownership will be determined by the signature in the decentralized data network.


Uncommenting spec in java test file

What is the purpose of this change? What does it change?

Uncommenting java test as it seems to be fixed in pr #1740
Was the change discussed in an issue?
How to test changes?

make test-java-e2e

Java test went fine in first run. Running it for second time
/test integration

[odo]  ✗  Unable to connect to OpenShift cluster, is it down?

/test integration
However java component test passed. Its ready for review cc_ @kadel

/refresh

/approve
/lgtm

/approve
/lgtm

Sorry @dharmit
Just uncommented few more java component test.
You need to review it again as new changes removed approve and lgtm labels

Sorry @dharmit
Just uncommented few more java component test.
You need to review it again as new changes removed approve and lgtm labels

No issues. But it didn't remove "approved" label. Only "lgtm" was removed. Shouldn't that be removed as well? :thinking:
/lgtm

/hold

/hold cancel

/lgtm


Multiline emptyStateDetailMessage

Hi there!
I'm playing with your UIEmptyState framework and try to output a multiline emptyStateDetailMessage. But for some reason, UIEmptyState displays only the first line.
How to fix this?

Could you provide me a sample project so that I can test this out?


ci: remove box download timeout in upstream tests

This timeout can be too small when the host has to download all boxes due to not having any of the boxes required for the SHA to be tested.
In particular this is prone to happen on backport PRs, since it's more likely for the job to be scheduled on a node that primarily run master pipelines up to that point.

The other Jenkinsfiles do not have a timeout and we never hit an issue with that. In the worst case it'll hit the global job timeout, but I don't think this ever happened because of the download times, so I think we should be good 😄

It appears we've made a mistake in #18741 and this PR was actually not backported to v1.9. I am resetting backport status.
@joestringer This PR was mentioned in the releae notes for v1.9.13, but was actually not backported properly and will be instead added to the next round of backports. Just mentioning it in passing, but it's not actually very important since it has no user-facing consequences.

CC @joamaki in case you do backports in future, please make sure to update the PR description (both the text and the command for updating the labels) if you remove any PRs. We use that as the source of truth for marking PRs as backported, and for generating release notes.

Just in case: I don't think this was intended and the PR was removed intentionally. I had acked the backport changes myself on the PR, so either I got confused and acked the wrong PR or we mistakenly removed the PR afterwards in a later push.


Media-type checking sometimes fails in changeserver

If the client does not include an Accept header, changeserver should respond with JSON. However, it sometimes responds with protobuf. This happens despite tests for just this situation inside the goscaffold project, so clearly some tests are missing ;-)

I am able to replicate this issue too. However, only with curl. This is explained by the fact that curl, by default, sends all requests with the request header Accept: */*. This is what appears to be confusing things for curl at least.
A simple way to fix this is to add a simple conditional statement before we call goscaffold.SelectMediaType which removes the Accept request header if it's value is not one of the accepted types.
if (req.Header.Get("Accept") != "application/transicator+protobuf") && (req.Header.Get("Accept") != "application/json") {
  req.Header.Del("Accept")
}

Of course the if statement could also just cater for curl with:
if req.Header.Get("Accept") == "*/*" {

However, we are only accepting 1 of 2 possible Mime-types we should probably validate input explicitly using logic similar to the first example.

Let me dig in to the goscaffold package so that we can fix this in an
elegant way.
On Tue, Nov 22, 2016 at 5:13 AM, davent<EMAIL_ADDRESS>wrote:

I am able to replicate this issue too. However, only with curl. This is
explained by the fact that curl, by default, sends all requests with the
request header Accept: /. This is what appears to be confusing things
for curl at least.
A simple way to fix this is to add a simple conditional statement before
we call goscaffold.SelectMediaType which removes the Accept request
header if it's value is not one of the accepted types.
if (req.Header.Get("Accept") != "application/transicator+protobuf") && (req.Header.Get("Accept") != "application/json") {
req.Header.Del("Accept")
}
Of course the if statement could also just cater for curl with:
if req.Header.Get("Accept") == "/" {
However, we are only accepting 1 of 2 possible Mime-types we should
probably validate input explicitly using logic similar to the first example.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apigee-labs/transicator/issues/14#issuecomment-262237007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAf0azeL6nibaF3yB7iH1x57mTSQyCIiks5rAup7gaJpZM4Kp7QN
.

Thanks for shedding light on how to reproduce it. Fixed it in goscaffold.


[top_darjeeling,lint,sim] Add lint and sim cfg for Darjeeling

This PR adds the block level lint and sim configuration for the Darjeeling top. It only adds the IPs that are used in Darjeeling, ignoring other IPs that are used in Earlgrey.
The PR enables the DMA, MBX, KeymgrDPE, soc_proxy IP.

I see that those are not yet part of CI - should we already enable the configs for the other IP?

About the CI question: yes, probably :-) At the moment, the CI version of the lint flow runs through ci/scripts/verible-lint.sh, which just knows about Earlgrey. I think the way to do it properly would be to add an extra "toplevel" argument to the script and then use that when constructing the hjson paths. At the moment, we run the script three times (RTL, DV, FPV) in slow-lint.sh. Splitting it out like that, we'd have to bump that up to three times for each top-level.

Oh, actually it looks like something has gone slightly wrong with the includes here:

@rswarbrick I'm not sure if nested configs are supported by the flow (nested in the sense of more than one child config)

Oh, that's a pity. But the change in the latest version (doing the expansion manually) looks like a reasonable approach for now, at least. Thanks.

Yep. Wanted to get the lint in, to unblock the other PRs.

@rswarbrick CI is green - can we get that merged?


New package: ov version 0.33.1

[ ] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

This package installed and launched normally on a Windows 10 VM. At first, exiting the application seems difficult. After trying some advanced exit commands, I found that simply pressing q returns to PowerShell.

@wingetbot waivers Add Validation-Executable-Error


iox-#1736 use clang format 15 in ci

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
[x] Assign PR to reviewer

Notes for Reviewer

Ported from #1656 in the hope to also fix #1731. Locally I could not reproduce the pre-flight-check failure with clang-format-15.
Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[x] Code according to our coding style and naming conventions
[x] Unit tests have been written for new behavior
[x] Public API changes are documented via doxygen
[x] Copyright owner are updated in the changed files
[x] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[x] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #1736

@elBoberido Your last commit message is not signed. Otherwise it looks fine.

 I NEVER sign my commits. It isn't required by eclipse anymore and therefore I skip this. Maybe we should also remove this from our commit template.

 I NEVER sign my commits. It isn't required by eclipse anymore and therefore I skip this. Maybe we should also remove this from our PR template.

I wasn't aware of this. Then we definitely should remove this item from our template.

@FerdinandSpitzschnueffler I'll do that in my next PR


Refactor Test Analytics collector environment variables docs

This moves the test collector environment variable coverage out of the Ruby Collectors page, into a standalone reference about what kind of information test collectors read from the environment and upload to Buildkite.
In this framing, the Buildkite collectors do ✨magic✨ and this doc discloses what is or is not magical, but not how the magic works (to transform certain environment variables into URLs, for instance).
This approach raises new and troubling questions; I'll self review to highlight some interesting issues.

@meiqimichelle we're looking at this approach to fix Environment Variables and CI Environments in one fell swoop.

This is looking so good @ddbeck and @plaindocs ! I left comments but also -- perhaps address the more straightforward comments, ship, and then have another go at the others in a separate PR. All good!

Nice work @olyism - we're all cowboys and cowgirls this week.

This all looks amazing, y'all! 😍😍😍
@ddbeck -- you were asking about how folks can confirm that env vars are coming through.  One give-away is the metadata displayed throughout the Test Analytics UI, and the easiest place to see this all in one screenshot is at the top of individual run pages:

When env vars aren't set correctly, folks will only see the pass/fail chiclet, timestamp directly next to it, and a UUID for the run name (instead of the human-readable title for the run name you see above). The build name/link, branch, and commit sha will not display at all.
I'm not sure how/if this should be incorporated into docs -- but sharing in case it's helpful.

Any opinions on this as a table format?