Issue with registering method parameter hints

Initially reported in https://github.com/spring-cloud/spring-cloud-openfeign/issues/860#issuecomment-1548713643.
Calling client generated with the sample:  https://github.com/CodeQualIT/CQITFunctions, causes feign.codec.EncodeException: Could not write request: no suitable HttpMessageConverter found for request type [nl.cqit.function.poc.java.helloworld.api.model.Person] and content type [application/json].
Possibly related to class generation.
CC @CC007

This should actually work already as per https://github.com/spring-cloud/spring-cloud-openfeign/commit/06192a575cac356c2e6c826f4995976c24a337fb. Will need to verify why it doesn't work in the sample.

Given that we can reasonably assume that any method defined in either a @FeignClient interface or a supertype interface is supposed to be part of the API, we should register all such methods for reflection and not only the ones declared for the annotated interface.


Rename repo to cosmos-hub

Cosmos now refers to the entire ecosystem, not just the hub.

yes, this repo / repo name is very confusing.

[ ] confirm with jae
[ ] cleanup repo, put files in legacy folder
[ ] speak to peng about dead links / moving files to s3
[ ] rename to cosmos-hub, add note in readme about being "future home of cosmos-hub"

I think website content (including all markdown documents that we want to publish) should be moved to tendermint/aib-data. I've been working on this effort already. Which dead links are you thinking of?

@nylira awesome. we thought there may be some files here that are still being linked to form elsewhere. like the whitepaper? if not, that's great!!!

I've just moved the last document (VALIDATOR_FAQ) that I was linking to from here to aib-data, so moving the documents off of this repo should be no problem from the website end. It would be great to know which of these remaining docs we want to publish on the website. Like @sunnya97's Cosmos Token Model pdf?

Hi
This case is OK :

It's possible to close this issue ?
Best regards


move to java 17, use Gradle 7.3

PR description
Move to Java 17 with the latest Gradle, upgrade dependencies and build to match.
Fixed Issue(s)

Merry Christmas! I can revert that part snd make sure we build with 11, indeed.


x/crypto/openpgp: Support signing of pre-computed hashes

This is a perhaps unusual feature request: the autograph service provides an API that clients can use to request signatures. Most of the time, clients call /sign/data with a raw message to sign, and that works fine with openpgp. But in some cases, we want to just accept a pre-computed hash to reduce the bandwidth usage between a client and the autograph service.
Trying to implement this with the openpgp package seems rather challenging. From what I can tell, the packet#Signature.Sign() function takes an initialized hash, appends a suffix and finishes the computation of the digest, then signs. There's no obvious way to provide the function with a hash that's already computed. I'm also failing to think of a way to hack around this without touching the openpgp/packet package directly.
Would it be possible to implement a SignHash function in the packet package that takes a pre-computed hash? It might also be useful to export buildHashSuffix for client to assemble the hash themselves.

Per the accepted #44226 proposal and due to lack of maintenance, the golang.org/x/crypto/openpgp package is now frozen and deprecated. No new changes will be accepted except for security fixes. The package will not be removed.
If this is a security issue, please email<EMAIL_ADDRESS>and we will assess it and provide a fix.
If you're looking for alternatives, consider the crypto/ed25519 package for simple signatures, golang.org/x/mod/sumdb/note for inline signatures, or filippo.io/age for encryption. You can read a summary of OpenPGP issues and alternatives here.
If you are required to interoperate with OpenPGP systems and need a maintained package, we suggest considering one of multiple community forks of golang.org/x/crypto/openpgp. We don't endorse any specific one.


Fixes #28

@AntonioMeireles care to review?

afaict fix unrelated to #29 core issue.  By default, Vagrant 1.7+ automatically inserts a different insecure keypair for each new VM created. The easiest way to use the same keypair for all the machines is to disable this feature and rely on the legacy insecure key e.g. config.ssh.insert_key = false. anyway this is an issue for some - working on it :-)


Question about the paper

Hello,
I read your paper Beyond neural scaling laws: Beyond neural scaling laws and found it super interesting.
I have a question about the way you compute N (the number of parameters in a model). Do you compute the entire number of trainable parameters, including the backbone? I ask this question because I currently have a small network (~6M trainable params) on which I would like to apply your "training guidelines" as in using an alpha~3, meaning that I would need 3 times the number of examples versus the number of model parameters. Does that mean I would need 18M images, or is there something wrong with the way I compute the number of params?
Best,
Vincent

Hi @VGrondin thanks for your interest in the paper!
I assume your question refers to the CIFAR-10 experiments; thus I'm tagging my co-authors @sshkhr and @bsorsch here, would you mind taking a look?

Hi @VGrondin thanks for your interest in the paper! I assume your question refers to the CIFAR-10 experiments; thus I'm tagging my co-authors @sshkhr and @bsorsch here, would you mind taking a look?

Thank you, I am curious what the answer will be:)

Closing due to inactivity. Sorry that you haven't been able to get an answer here, please feel free to reach out to them via email instead, they might not be checking github as frequently.


Debug adaptor crash

VSCode Version: 1.19.1
OS Version: macOS 10.12.6

Steps to Reproduce:

Set up the mock debug example so that you can debug.
Export a variable test from extension.ts like: export let test = "blah";
Import that var in mockDebug.ts by: `import { test } from "./extension";
In launchRequest add this assignment right after the logger setup: let t = test;.
Start debugging again and: BOOM. (error: "Debug adapter process has terminated unexpectedly").

What's especially worse here is that you neither can debug your debug adaptor (the debug session), nor do you get any info what actually happens (no further info in the error message, nor in the developer tools.
Note: you can import that variable successfully from any other ts file without any problem.

The debug adapter (DA) runs as an independent process outside of the extension host. It is completely independent from VS Code and cannot access any VS Code extension API.
That means you cannot import anything from the extension host code in a debug adapter.
If you try to import extension.ts into the DA, this will fail because extension.ts expects to run in the extension host.
If you need to access something in the extension from the DA,

you can pass it from the extension to the DA on debug session start via the launch config (see DebugConfigurationProvider.resolveDebugConfiguration), or
you can send a custom event from the DA and have an event handler (debug.onDidReceiveDebugSessionCustomEvent) in the extension that sends the data back to the DA via a custom request (DebugSession.customRequest).

Great, thanks, you addressed my actual problem :-) Still, I think the DA shouldn't just crash. Also, it's not clear how to debug your DA code. Sending messages around? That's like last century debugging...
A word about the debug configuration provider. This is what I tried first, however that works only for simple values (numbers, strings), not for class instances. Now that I know the DA is a separate process, I understand why. You'd need a marshalling strategy for complex objects to make them available in the DA. How's that supposed to work? How can I, for example, create my debugger instance in the DA? The extension is required to do that. But since I cannot pass it to the DA, how can I actually create that object?

 VS Code cannot do that.
You debug a DA by running the DA in VS Code. See https://code.visualstudio.com/docs/extensions/example-debuggers#_development-setup-for-mock-debug.
As you can see in this screenshot both the debug extension and the DA are running in debug mode:

I mentioned sending custom events from the DA to the extension to solve the problem of sharing data between the extension and the DA, not for debugging anything.
Why do you have to create the debugger instance in the extension and not in the DA? Of the ~ 40 VS Code debug extensions I'm not aware of any that does this.
With this debugger API you are using is it really possible to create a debugger instance in one process (extension host) and pass that instance to another process (DA). I have not yet seen an debugger API that supports that.

 Thanks for pointing that out.
About the backend debugger: actually I don't care so much where it is created, but the problem is that it needs data from the backend, which drives the extension. This backend holds important data without which the debugger wouldn't work. So I have to let the backend create the debugger, no way around that. However that means I either have to pass in my backend to the DA or the created debugger. Neither is possible, from what I see. And I believe this is not a very unusual approach, since the extension is what does the actual job. The adaptor is just a communicator, translating between the vscode debugging UI and the debuggee. So I find it pretty obvious that it needs something to talk to the debuggee. In my case the debuggee is not a separate process that communicates via sockets, but something that runs directly in my extension (actually in the backend, driving the extension).

Multisession debugging: you only need this if you have code both in the extension and in the DA. Most debuggers have only a DA, so they have no need to debug the extension (Historical fact: DAs predate VS Code extensions; early versions of VS Code had pluggable debuggers via DAs but no extensions).
Your "backend debugger":
It sounds to me that your backend could just implement the Debug Adapter Protocol (DAP) and you would not need a DA (that is a separate process) at all.
The Java Extension does something similar: they have a single Java backend process (written in Java) that implements the Language Server Protocol (LSP) and the Debug Adapter Protocol (DAP). Instead of using a standalone DA process, they tell the VS Code debugger UI to connect to a specific port of their backend server that implements the DAP.
By using this approach you could even implement the DAP in your extension (again not as a separate process).

Please note: if you do not have an explicit DA it will not be possible to run your debug extension in other frontend clients e.g. Visual Studio or Visual Studio for Mac.

Another note: you could try to use the npm module that implements the DAP (vscode-debugadapter-node) directly from your extension - basically as an "embedded DA".

Thanks a lot for your suggestions. I much appreciate the time you spend trying to help me. Unfortunately, the ideas you mention are rather abstract, so I will have to find examples first, to understand what we are talking about here. Having the backend implement the DAP sounds like a good path to follow. Do you have some code that does this, which I could use to learn?

Moin Moin! :-)
The only example for a backend implementing the DAP is the Java extension which lives here: https://github.com/Microsoft/vscode-java-debug
But the repo doesn't contain the DA because that lives in the backend (and I don't know whether that's available in open source). I'll investigate...
On the other hand I've planned to create a branch of mock-debug that runs the DA embedded in the extension.ts (i.e. not as a separate process). This is not a lot of work and would be a nice proof of concept for the "abstract ideas" from above. Since I'm on vacation right now I don't know how if I find enough time to work on this. But I'll try...
No, use of the vscode-debugadapter-node module is not mandatory. It is only meant as a convenience for adapters that are implement in JS or TS.
The DAP is the "real beef". It is specified as a JSON schema and client libraries for different languages are generated from this automatically. The Java team generates a Java library from this, and I'm aware of a .net/C# generator.

Woah, you shouldn't answer here, when you are on vacation :-D - the more I appreciate your help. I'll wait for your new branch to see how to use an embedded DA.

@mike-lischke with this small change the extension runs DAs inside the extension host.
See branch embedded-DA.

@weinand This is just awesome. I'm so excited. Not only is the debug session now created as part of the extension, it also supports debugging out of the box and I can use my normal backend to create the actual debugger. Atm, everything is fine now. Thank you so much!


Add Spanish (Mexico) es-mx translation

Along with Pablo Piovano (@ppiova) we submit a PR that includes a translation to Spanish (Mexico) of the following elements:

Initial README
Module 0
Module 1

This PR references #83 and is submitted for your consideration and review. Thank you.

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

¡Gracias @abrilurena por tu comentario! Cada semana tratamos de traducir uno o dos módulos, iré actualizando el comentario principal cuando tengamos listos los siguientes (estoy en proceso de terminar el 7).
Quedamos atentos de cómo quedan las asignaciones para que todos los interesados podamos contribuir en este esfuerzo conjunto :)

@abrilurena or @icebeam7 can you please look into these conflicts?

@koreyspace thanks for your comment, the issue has just been resolved. I removed the conflicting files from my local repo and sent a PR here. The files were no longer needed from my side as their corresponding translations were pushed in the main repo a few weeks ago. Thank you!


Share proxy as link

I think is will be good idea to set proxy in client app with a link ,just like what can we do in telegram
Most of users have issue for set proxy manually,like my mother!

Unfortunately this has nothing to do with the proxy itself and is a client-functionality that you've requested. I think that idea is circulating internally however, but I'm going to close the issue here since it's not related to the proxy itself. Please feel free to open a ticket to WhatsApp to suggest this though!


Project Support in the VS Code Extension

Project Support for the Language Service
This PR adds multi-file projects to the language service. Closes #796
Overview
qsc_project defines a project system that sits on top of a given file system-like interface. This PR is an implementation of that interface for the language service. This is a non-trivial implementation, as it has cascading effects. The most prominent of these effects is the asyncification of the language service, both in WASM and in TS.
Async Information
There is some key behavior related to the asynchronous functions that needs to be highlighted.

We only trigger one compilation at a time, storing an optional "next" compilation to catch up to the editor state. This prevents race conditions when we fire off a compile event every keystroke.
The WASM now uses async/await in Rust. It is important to know that these Rust Futures are equivalent to Javscript Promises. They share the same event loop scheduler. wasm_bindgen handles the sharing of the async runtime between v8 and Rust, and it is indeed magical.
tokio was added to the workspace dependencies. This is a bummer, but it is only used for running the unit tests in the language service. We do not use tokio's runtime anywhere in our non-test code.
I've done my best to architect this in such a way that it is easy to debug. That being said, there are some rough edges. I will schedule some time to go over those rough edges.

Debugger
This PR does not introduce debugger support for projects. We will add debugger support in a future PR. For now, this PR disallows running the debugger if the current context is a Q# project. See #797.

Follow-On Tasks
Below are the follow-on tasks that will come in future PRs:

Using VS Code's FS watcher API to notify us of file updates, and caching files.
Redesigning the manifest format and excludeFiles/excludeRegexes
Adding project support to the Python API (#861)

Do we ever unload a project when you close the last document?

@minestarks

Do we ever unload a project when you close the last document?

No. Do you think we should?

I think we should, but it's a design decision we can defer. My concerns are:

User annoyance: they can't make errors go away from the problems view no matter how many documents they close.
Perf: Memory usage and unnecessary file watcher activity (once we have file watchers) for a project that's not being used.

I don't think these are real concerns for now, so okay to defer (maybe track with an issue).


Is the Wings website off-line?

Tried to point a colleague to http://www.wings-workflows.org/ this morning and it appeared broken...

Yes, it seems to be down. Also, the repo of workflows is down as well, and opmw.org. Varun could you please have a look?

Thanks, guys!!
On Wed, Dec 9, 2015 at 11:26 AM, Daniel Garijo<EMAIL_ADDRESS>wrote:

Yes, it seems to be down. Also, the repo of workflows is down as well, and
opmw.org. Varun could you please have a look?
—
Reply to this email directly or view it on GitHub
https://github.com/IKCAP/wings/issues/24#issuecomment-163314340.

--
John S. Erickson, Ph.D.
Director of Operations, The Rensselaer IDEA
Deputy Director, Web Science Research Center (RPI)
http://tw.rpi.edu<EMAIL_ADDRESS>Twitter & Skype: olyerickson

Yes ! The servers are being physically moved to a new location. Most of our sites will be down today I’m afraid.

On 9 Dec 2015, at 16:33, John S. Erickson, Ph.D<EMAIL_ADDRESS>wrote:
Thanks, guys!!
On Wed, Dec 9, 2015 at 11:26 AM, Daniel Garijo<EMAIL_ADDRESS>wrote:

Yes, it seems to be down. Also, the repo of workflows is down as well, and
opmw.org. Varun could you please have a look?
—
Reply to this email directly or view it on GitHub
https://github.com/IKCAP/wings/issues/24#issuecomment-163314340.

--
John S. Erickson, Ph.D.
Director of Operations, The Rensselaer IDEA
Deputy Director, Web Science Research Center (RPI)
http://tw.rpi.edu<EMAIL_ADDRESS>Twitter & Skype: olyerickson
—
Reply to this email directly or view it on GitHub https://github.com/IKCAP/wings/issues/24#issuecomment-163316543.

Thanks for the heads up!

Hi John,
The servers should be back up now.
Cheers,
Varun

On 9 Dec 2015, at 16:33, John S. Erickson, Ph.D<EMAIL_ADDRESS>wrote:
Thanks, guys!!
On Wed, Dec 9, 2015 at 11:26 AM, Daniel Garijo<EMAIL_ADDRESS>wrote:

Yes, it seems to be down. Also, the repo of workflows is down as well, and
opmw.org. Varun could you please have a look?
—
Reply to this email directly or view it on GitHub
https://github.com/IKCAP/wings/issues/24#issuecomment-163314340.

--
John S. Erickson, Ph.D.
Director of Operations, The Rensselaer IDEA
Deputy Director, Web Science Research Center (RPI)
http://tw.rpi.edu<EMAIL_ADDRESS>Twitter & Skype: olyerickson
—
Reply to this email directly or view it on GitHub https://github.com/IKCAP/wings/issues/24#issuecomment-163316543.

The issue can be closed, since the servers are up. It can be reopened if they are down again


Broken Doc Links

Some links in the original documentation are not being parsed and updated correctly for the site https://github.com/atom/electron/issues/4500.

All the links to APIs on the http://electron.atom.io/docs/v0.36.7/tutorial/desktop-environment-integration/ page are broken. (e.g., app.addRecentDocument, Tray API, etc.)

For instance "Tray API" leads to http://electron.atom.io/docs/v0.36.7/tutorial/api/tray.md#traydisplayballoonoptions-windows when it should lead to http://electron.atom.io/docs/v0.36.7/api/tray#traydisplayballoonoptions-windows

Fixed in https://github.com/atom/electron.atom.io/pull/174 :sparkles:


addToQuery() tableName is empty #10936

Affected Version
4.13
5.0.22
Description
The change #10936 is broken. The tableName property is not populated.
Steps to Reproduce
Create a custom DBField with addToQuery function.
<?php

use SilverStripe\ORM\FieldType\DBField;

class MyDBField extends DBField
{
    /**
     * @param SQLSelect $query
     */
    public function addToQuery(&$query)
    {
        $query->addSelect([
            $this->name => '"' . $this->tableName . '"."' . $this->name . '"'
        ]);
    }
}

Will lead to SELECT ""."MyColumn" FROM "MyTable"
PR

https://github.com/silverstripe/silverstripe-framework/pull/10946

Thank you for raising this. I've created a pull request to fix it.

Linked PR was merged


PauseControl

Tasks

[ ] Complete #28.
[ ] Design, build and test the PauseControl component.

Notes
Slots

default: Used to pass in a styled element to give the component form.

CSS Parts
Forward all Control parts.
Events

vds-user-pause-request: UI event emitted when the component is pressed and to pause playback.

References

https://github.snooguts.net/david-furfero/reddit-media-player/blob/main/src/ui/PauseButton/index.ts
https://github.com/vime-js/vime/tree/master/core/src/components/ui/controls/playback-control

Little difficult to manage ARIA and have this as a separate component. In addition, this component standalone most likely doesn't make sense because playback changes should always be two-way (play/pause). Need solid use-case to consider splitting.


Implement "outputs" specification for tasks

Use Case
Tasks exist as an alternative to scripts which provide the benefit of concrete, typed parameters for input, and optionally, structured output. All of this is in service to making them easy to auto-document, understand, and use as building blocks in plans.
While it's easy today to know what kind of data you need to input to tasks, it's still kind of a crapshoot what data that task will output, and to understand that you either have to human-read the README or maybe even RTFS.
Describe the Solution You Would Like
To make tasks easier to consume off-the-shelf in plans, we should add an outputs key to the task.json spec, a peer to the existing parameters key. This should define required or optional outputs to tasks, and their types.
If a task specifies a required output and does not provide it, that should be considered an error, and we should raise it as an appropriate type. Same thing if a task specifies a type for an output and that output is returned with a non-matching type. The error in this case should include the actual output in its details.
Output entries should support a description to be used for auto-documentation of tasks.
A special accommodation should be made for Sensitive type outputs. If an output is sensitive, the user should be able to indicate as such (e.g. "outputs": {"name": "password", "type": "String", "sensitive": true}) and the task should wrap the value in Sensitive() when returning it.

Comments from Slack

Lucy Wyman Jul 7th at 5:14 PM
For the tasks issue, why wouldn't the task author just check all of that in the task itself? Are metadata authors and task script authors really different often enough to justify specifying output keys? It also seems a bit heavy-handed for, like, trying to catch typos in the keys kind of thing.
Reid Vandewiele Jul 7th
It’s more about consuming tasks you didn’t write yourself. For example: I’m working with a customer who has two teams, three modules.
The Linux team owns a low-level utility module which provides tasks that return data from a 3rd party service. This team maintains these low-level tasks both for their own use, and also for use by the Windows team.
The Windows team and the Linux team both own their own team-specific workflows modules. The workflows module contains plans which call/consume tasks from the low-level utility module.
Members of the Windows team did not write any tasks in the utility module, nor do they have any idea how they work. But to consume those tasks correctly, in their team’s workflows module, they need to know what data the low-level utility tasks produce.
Some members of the Linux team have no expertise with the low-level utility tasks, but do contribute to the Linux team’s own workflow plans. Similarly, they need to know how to use the utility tasks, without necessarily knowing anything about the code or implementation.
That’s the main value in defining clear outputs. Letting teams consume content they did not write. (edited)

It would be cool to be able to define error types as structured output. Something like
"outputs": { "..." }
"errors": {
    "someRecoverable": {
        "description": "I'm a recoverable error, and my Enum tells the caller what to try",
        "type": "Enum['bloop', 'blorp']"
    }
    "someFatal": {
        "description": "Fatal error. Returns an [error code, message] tuple.",
        "type": "Tuple[Integar, String]",
        "default": "Tuple[-1, 'unknown error']"
    }
    "_": {
        "description": "Maybe we have some underscore handler with default behavior? Spitballing..."
    }
}

Perhaps, in Bolt plans, the "errors" block (if returned) gets marshaled into an object with a field that has an Enum['someRecoverable', 'someFatal'], then you can get the underlying error with a method.
The inspiration here is Rust's Result<T, E> types, where - very often - the E (error) variant is itself an enum.


Expansion of related targets and diseases

Need to show table with intermediate diseases linking two related targets (and vice versa). Expand on row click, for example. Table should contain disease and association scores to the two targets.
Eventually, we should add also link to the batch search (not yet implemented).

Done.


Reproduce breakage in another PR

Just trying to see whether this effectively no-op PR faces the same failure as #2687 on 1.9.
Supersedes https://github.com/mesosphere/dcos-commons/pull/2689 where TC seems to have become confused, retrying with a different branch name.

Sigh it thinks it's being smart.


cert-manager-acmesolver v0.14.0 runs as root which leads to failure in restricted namespaces

Describe the bug:
cert-manager-acmesolver in version 0.14 runs as user root and when it tries to run cm-acme-http-solver pod in restricted, production namespaces where running container as root is forbidden it fails:
cm-acme-http-solver-lqlxj                               0/1     CreateContainerConfigError   0          36m

  containerStatuses:
  - image: quay.io/jetstack/cert-manager-acmesolver:v0.14.0
    imageID: ""
    lastState: {}
    name: acmesolver
    ready: false
    restartCount: 0
    state:
      waiting:
        message: container has runAsNonRoot and image will run as root
        reason: CreateContainerConfigError

Previous version of cert-manager (eg. v0.13.0) was working fine in this scenario.
There is possibility to set securityContext for cert-manager-controller, cert-manager-cainjector, cert-manager-webhook workloads but I cannot find how to set securityContext for other cert-manager workload like cert-manager-acmesolver
Expected behaviour:
Run cert-manager-acmesolver as non root user or provide option to set securityContext for cm-acme-http-solver workload.
Steps to reproduce the bug:

Create restricted namespace with PSP:

apiVersion: policy/v1beta1
kind: PodSecurityPolicy
metadata:
  name: restricted
  annotations:
    seccomp.security.alpha.kubernetes.io/allowedProfileNames: 'docker/default,runtime/default'
    apparmor.security.beta.kubernetes.io/allowedProfileNames: 'runtime/default'
    seccomp.security.alpha.kubernetes.io/defaultProfileName:  'runtime/default'
    apparmor.security.beta.kubernetes.io/defaultProfileName:  'runtime/default'
spec:
  privileged: false
  allowPrivilegeEscalation: false
  requiredDropCapabilities:
  - ALL
  volumes:
  - 'configMap'
  - 'emptyDir'
  - 'projected'
  - 'secret'
  - 'downwardAPI'
  - 'persistentVolumeClaim'
  hostNetwork: false
  hostIPC: false
  hostPID: false
  runAsUser:
    rule: 'MustRunAsNonRoot'
  seLinux:
    rule: 'RunAsAny'
  supplementalGroups:
    rule: 'MustRunAs'
    ranges:
    - min: 1
      max: 65535
  fsGroup:
    rule: 'MustRunAs'
    ranges:
    - min: 1
      max: 65535
  readOnlyRootFilesystem: false

Try to get ACME certificate with http01 solver for workload in this namespace.

Anything else we need to know?:
Environment details::

Kubernetes version (e.g. v1.10.2): v1.15.9-gke.9
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): GKE
cert-manager version (e.g. v0.4.0): v0.14.0
Install method (e.g. helm or static manifests): static manifests

/kind bug

This is a known issue in 0.14, fixed in https://github.com/jetstack/cert-manager/pull/2720
We will soon release 0.14.1 with this patch included! Sorry for this.

@meyskens I see the same behaviour in 0.14.1:
docker inspect quay.io/jetstack/cert-manager-controller:v0.14.1
[...]
        "Config": {
            "Hostname": "",
            "Domainname": "",
            "User": "",

in comparison 0.13:
docker inspect quay.io/jetstack/cert-manager-controller:v0.13.0
[...]
        "Config": {
            "Hostname": "",
            "Domainname": "",
            "User": "1000",

Is it really fixed in 0.14.1?

Im facing the same isuse with v0.14.1 release.
image: quay.io/jetstack/cert-manager-acmesolver:v0.14.1
    imagePullPolicy: Always
    name: acmesolver
    ports:
    - containerPort: 8089
      name: http
      protocol: TCP
    resources:
      limits:
        cpu: 100m
        memory: 64Mi
      requests:
        cpu: 10m
        memory: 64Mi
    securityContext:
      allowPrivilegeEscalation: false
      capabilities:
        drop:
        - NET_RAW
      runAsNonRoot: true

error:
  containerStatuses:
  - image: quay.io/jetstack/cert-manager-acmesolver:v0.14.1
    imageID: ""
    lastState: {}
    name: acmesolver
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: container has runAsNonRoot and image will run as root
        reason: CreateContainerConfigError

Regarding setting security context for the http solver containers, was this ever resolved? I can't find any documentation covering it...

Hi! Since cert-manager v1.4.0 (https://github.com/jetstack/cert-manager/pull/4036/commits/d26caf578df0f0e99f3b9158f4139496b5892922), the HTTP01 solver pod is created with runAsNonRoot: true by default.

Hi, is there a way to set securityContext for acmesolver?

Unfortunately, there is no way to set a custom securityContext for the solver pods on cert-manager 1.3 and below. I would recommend upgrading to 1.4 which uses runAsNonRoot: true by default.

Hey, thanks for a reply, yes, we do use 1.4 and runAsNonRoot is defined for pod securityContext (it seems), but open policy engine (in azure aks) is evaluating rule(s) for container securityContext only, thus, policy rule is triggered.
It would be lovely if there is a way to set custom securityContext for pod and container, exposed through helm chart perhaps or some other way, like its here for example: https://github.com/bitnami/charts/blob/master/bitnami/redis/templates/master/statefulset.yaml#L53
Regards

To bump this thread.
With the v1.8.0 version it still seems we are unable to set custom SecurityContext for the solver pods. This is quite important as we have very specific requirements for the pods.
https://github.com/cert-manager/cert-manager/blob/00938dfa4cc96d2390ae9a63ab158618a1d60437/pkg/issuer/acme/http/pod.go#L176
It would be great if this line could be changed to accept configuration instead of just this single RunAsNonRoot parameter.

Pretty much anything that is in the current SecurityContext spec
https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
For me personally would be to configure.
runAsUser
runAsGroup
faGroup
supplementalGroups
secCompProfile
etc.
Ideally we could do this through a security context config in the original yaml. Or some how through config maps.
Happy to review and push a PR if need be.

How is cert-manager even usable without ability to set SecurityContext for solvers? Without it, solver's pods cannot initialize and entire workflow breaks down. Images installed via Helm are trying to start as root, but spawned pods are marked with "runAsNonRoot" and thus nothing works without manually editing security contextes.

It works with DNS solvers, but not HTTP solvers. I think this is why this bug is closed and low on priority list.
Still the issue with 1.9.1.
I think it either should be parameterised, or just added as default values. At this point in the cluster with PSS enabled HTTP solvers are unusable.
@maelvls would be nice to get some guidance how do you prefer this to be fixed? Should we pass Security context all together from Helm or we try to put PSS compatible config into POD spec? I don't know fully all the possible deployment permutations to understand if this could break something if we just add it as per @Nico-VanHaaster  comment above


Setup coverage

This PR sets up coverage reporting and fixes some test issues.
npm test

HTML Coverage Report

👻


Requirements Parsing and Unit Tests

Updates requirements parsing to merge requirements from skill.json, manifest.yml, and requirements.txt in priority order
Updates existing unit tests and adds more SkillEntry tests
Closes #25
TODO:

[ ] Test and handle conflicting dependency versions
[ ] Test commented lines in requirements
[ ] Format git spec'd dependencies with auth_key (Maybe this is installer scope and not SkillEntry)
[ ] Update existing references to test case where possible

i assume #10 will be incorporated in this PR ?

i assume #10 will be incorporated in this PR ?

Should that be merged first so this one just adds it to automation, or should I just integrate those changes here?

i assume #10 will be incorporated in this PR ?

Should that be merged first so this one just adds it to automation, or should I just integrate those changes here?

feels cleaner to do it in a single PR i think, but feel free to push the merge button on #10 if it makes your life easier!

i assume #10 will be incorporated in this PR ?

Should that be merged first so this one just adds it to automation, or should I just integrate those changes here?

feels cleaner to do it in a single PR i think, but feel free to push the merge button on #10 if it makes your life easier!

I'll pull those commits in here then, easier to test with automation that way

Closes #24

Should I increment version in this PR?


"No data" error as of late

After updating from php-coveralls v1 to v2, I notice that the uploads from that are not accepted by Coveralls as a "real" build. The "latest from main branch" landing page and badges, remain based on the results from the last commit that used php-coveralls 1.x.
The clover.xml file and upload seem to be fine:
https://travis-ci.com/github/cssjanus/php-cssjanus/jobs/504357689
Load coverage clover log:
  - /home/travis/build/cssjanus/php-cssjanus/clover.xml
Found 1 source file:
  - 100.00% src/CSSJanus.php
Coverage: 100.00% (182/182)
Collect git info
Read environment variables
Dump submitting json file: /home/travis/build/cssjanus/php-cssjanus/coveralls-upload.json
File size: 23.45 kB
Submitting to https://coveralls.io/api/v1/jobs
Finish submitting. status: 200 OK
Accepted Job #58.3
You can see the build on https://coveralls.io/jobs/79896383
elapsed time: 0.874 sec memory: 6.00 MB

But the build page at https://coveralls.io/jobs/79896383 has a grey result with ?% (question mark) coverage.
What's strange though is that the detailed data appears to be all fine. E.g. Source file shows the source code, and varied numbers for how frequently each branch was covered. All good.
But, the overall build is classified as ?% coverage at https://coveralls.io/builds/39536352.

The example is having actual coverage level, another example could be https://github.com/FriendsOfPHP/PHP-CS-Fixer/runs/4060408598?check_suite_focus=true#step:12:493 / https://coveralls.io/jobs/89270356 . Maybe this was a hiccup on Coveralls side, maybe just got solved on your side over time.
Closing for now.


withdraw funds

Description
This command allows a user to withdraw funds from their lnd wallet to a wallet at an address specified.
Related PRs
https://github.com/sparkswap/lnd-engine/pull/92
Todos

[x] Tests
[x] Documentation
[x] Link to Trello

 withdraw to address [ccxt]

@martineehrlich changes look good.


Burning bootloader with Arduino gives me Device signature error

I ordered these boards from JLCPCB pre-soldered with the 328p. I am trying to burn the bootloader with an arduino and have all the pins wired directly from the UNO iscp pins to the reflow ISCP pins.
Has anyone else got this issue?
here is an image:

Yes Got the same issue but don't know how tho solve it

I think you need a crystal oscillator if you are burning it for the first
time. Check out the video link in the main page.
On Fri, 23 Dec 2022, 03:33 JoeLutz11, @.***> wrote:

Yes Got the same issue but don't know how tho solve it
—
Reply to this email directly, view it on GitHub
https://github.com/AfterEarthLTD/Solder-Reflow-Plate/issues/48#issuecomment-1363271865,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY7YPGR2WFFVJRLRZ342FC3WOSUKJANCNFSM6AAAAAASP3CVKU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I actually found a fix by making sure to wire properly. I did blow up a chip trying to give it a clock signal. I ordered 5 and successfully programmed the next 4 after I figured out the wiring


Improve flexibility of tooltips

Tooltips will now support opt-out classes for padding, auto resize, and auto positioning, which can be applied to individual tooltips to override the global settings. The classes are as folllows:
tooltip-nopadding
tooltip-noautosize
tooltip-noautopos

Completed.


MINOR: Use generated InitProducerId RPC

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks @hachikuji .
It might be nice to add a comment in the JSON schema that TransactionTimeoutMs is ignored if TransactionalId == null

LGTM after comments are addressed.  Thanks, @hachikuji


Add compatible conda

@jdesanto closing this should happen when it's merged. You need to fix the review comments, then mark them as resolved along with the updated files. Then I can merge, once you've completed the OCA requirements that Ming shared.


Saber请求微信接口 无法获取值

Saber::GM获取微信token以后 使用getBody()->getContents()获取值为空
但是单独获取getBody能获取到对象 对象里面是有返回值的

This happens because the swlib implementation of PSR-7 was incorrect. You can fix the problem by replacing the swlib Response object by guzzlehttp implementation (NOTE: you'll still be using Saber to make the requests, with all its benefits), wich is correctly implemented, so getContents() works as expected.
First, you need to install the GuzzleHttp library:
composer require guzzlehttp/guzzle

Then you should replace SaberGM::get('https://api.ipify.org') by:
$request = \Swlib\Saber\Request('GET', 'https://api.ipify.org');
$brokenResponse = $request->exec()->recv();
$swlibImplementation = $brokenResponse->getBody();
$guzzleImplementation = \GuzzleHttp\Psr7\stream_for($swlibImplementation->getMetadata('hwm'));
$fixedResponse = $brokenResponse->withBody($guzzleImplementation);
echo($fixedResponse->getBody()->getContents()); // works as expected ;)

getBody() 是 Request上的方法吧？你要对Swlib\SaberGM::psr()返回的对象执行recv()，再获取其中的body成员

This happens because the swlib implementation of PSR-7 was incorrect. You can fix the problem by replacing the swlib Response object by guzzlehttp implementation (NOTE: you'll still be using Saber to make the requests, with all its benefits), wich is correctly implemented, so getContents() works as expected.
First, you need to install the GuzzleHttp library:
composer require guzzlehttp/guzzle

Then you should replace SaberGM::get('https://api.ipify.org') by:
$request = \Swlib\Saber\Request('GET', 'https://api.ipify.org');
$brokenResponse = $request->exec()->recv();
$swlibImplementation = $brokenResponse->getBody();
$guzzleImplementation = \GuzzleHttp\Psr7\stream_for($swlibImplementation->getMetadata('hwm'));
$fixedResponse = $brokenResponse->withBody($guzzleImplementation);
echo($fixedResponse->getBody()->getContents()); // works as expected ;)

I'm going to use the guzzle, so why don't I just guzzle it

@cxjhk 用master代码可以试下有没有问题，之前可能buffer有问题


Support for extended FRU data for memory modules

Decode some DIMM SPD fields according to JEDEC format to write
detailed info into an IMPI FRU message:

Manufacturer field contains real orgainsation name instead of ID.
Module name contains type, capacity, speed and other attributes.

Resolves #132
Signed-off-by: Artem Senichev<EMAIL_ADDRESS>Signed-off-by: Maxim Polyakov<EMAIL_ADDRESS>

@dcrowell77, what do you think about this?

@wghoffa - take a look

@artemsen -- Thanks I didn't catch that. I'll try a P8 system, though may also apply to P9 and see how it goes. I don't think things in this area have really changed at all.

@dcrowell77 / @artemsen -- Looks good! AMI output worked well too (ran from a habanero):
FRU Device Description : DIMM8 (ID 11)
Product Manufacturer  : Kingston
Product Name          : DDR3-1600 8GiB 64-bit ECC RDIMM
Product Part Number   : 9965433-153.A00LF
Product Version       : 0000
Product Serial        : f61094d6

Merged here: https://github.com/open-power/hostboot/commit/30b88edd16abf46481dbab0a46809dbefed40225
Thanks for the submission!

@wghoffa, could you please also backport this to master-p8? Our system is P8-based and we currently carry this patch in our op-build fork. It would be great if this was a part of upstream branch.

@AlexanderAmelkin -- It should be in for master-p8 (I did not yet port it to master, but am hoping to). I see it here? https://github.com/open-power/hostboot/commits/master-p8
I think the update to op-build will come shortly. We have an automated process that runs daily to do those updates, it has not triggered yet today but should trigger in the next few hours or so.

@AlexanderAmelkin -- Looks like the update came with a bunch of P9 stuff that appears to have an issue that is being sorted out (https://github.com/open-power/op-build/pull/2381).
I pulled the P8 stuff to the side -- just waiting on CI: https://github.com/open-power/op-build/pull/2382
Also -- I gave it a go for p9 and all seems well. I'll push that up soon as well.


increase tolerance pareto test

test_distributions/test_mle fails too often for Pareto. This seems to be a limitation of the MLE estimation for this distribution (and we basically use SciPy for this). So, as a workaround, this PR increases the tolerance.

Codecov Report

Merging #149 (1353350) into main (a500512) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   77.23%   77.26%   +0.03%
==========================================
  Files          18       18
  Lines        2170     2173       +3
==========================================
+ Hits         1676     1679       +3
  Misses        494      494

Impacted Files
Coverage Δ

preliz/tests/test_distributions.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Click on open transaction box should not close box

Use javascript "stopPropagation" should fix it I think.

https://github.com/yzernik/squeaknode/pull/1502


build: add GHES 3.14

Resolves #ISSUE_NUMBER

Before the change?

After the change?

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[ ] No

The test failures are unrelated to this PR.
This PR unblocks the updates which contain a fix for these JSON syntax errors


Update Install instructions for Ronin

When installing ronin $ npm install --global ronin, yeoman and the ronin generator are not installed automatically. This can confuse some users ...
Please update the getting starting guide doc and install section on github.
Yeoman + Ronin generator:
$ npm install -g yo generator-ronin

Ronin:
$ npm install -g ronin

See https://github.com/vdemedes/ronin/issues/35#issuecomment-213918853


Datetimepicker IE8 Issue

I'm focusing IE8 version so the datetimepicker doesn't show up there, finally I fixed the issue with "[ES5 shim] (https://cdnjs.cloudflare.com/ajax/libs/es5-shim/4.1.1/es5-shim.min.js)" and change "debug: true"..now it's working..but click function is not working when click on the out side of the widget in all Browsers..I tried to fix that from the "[link] (http://eonasdan.github.io/bootstrap-datetimepicker/Extras/#ie-7)"...but nothing happend... could you please fiddle it .
thanks in advance.

As I mentioned in your other, duplicate, issue, IE != latest is not supported. I just don't have time to troubleshoot.


[Feature Request] Set default time period on Dashboard between All time and current year in settings

Hello, I would love to have a option to change default time period on dashboard in settings.
Right now it's all time, which I don't use since I want to primary look at the current year.
When I change it to 2024 in my browser, it stays set, even after logout, but it's not viable since iOS Safari doesn't remember this setting and it's not comfortable even for new browser session/new users.
Thank you

Just tested this on iOS Safari and the year dropdown persists. The only reason it would clear itself out would be because you click into another vehicle that doesn't have any data for that year selection.


~500ms spent in the Flutter UI thread before rendering the first Dream frame

Mirror issue for this internal bug. Conversation should occur there.
cc @cbracken, to whom the issue is currently assigned.

This may be a duplicate of https://github.com/flutter/flutter/issues/19350

This has been resolved.


How do I get it mecrisp-stellaris installed on an nRF52832 in the first place?

It looks as though your libraries assume that mecrisp-stellaris is already running on an nRF52832.   Is there a published .hex file somewhere for that.  If not, how is it done?

There's a nRF52832 port of mecrisp under review by Matthias:
https://github.com/juju2013/mecrisp-stellaris/tree/nrf52

I'm doing a massive rewrite in converting this to iomodule (kind of wordlist) but I've still some wired issue... hopefully I can publish the new code in a few days/weeks.


Deal with rating missing in XMP sidecars

Avoid getting Rating of 0 when rating metadata is not included in a sidecar.

I found the reverse bug in the embedded metadata handling. Here a rating of zero will be ignored. I have a fix for it, but it will be some days before it's ready because it's bundled with some other minor improvements of metadataloader and I'm not able to finish it in the next few days.

@martyone looking at this again, and your corrections to the code.
With this code, if rating is defined, but zero, it is not mapped it into pigallery's metadata. Is this the intention?
I ask because both the jpg and the xmp-file has a rating of 0, but your test is altered to expect no mapped rating:
https://github.com/bpatrik/pigallery2/pull/860/commits/8517430a1b48b3570e0383409dc5c28fa61f8797#diff-c05a31981597794f928cda5f1343aadd8c148f455efbab3d572210c6801d90eeL14
But rating is defined to be zero:
https://github.com/martyone/pigallery2/blob/xmp-no-rating/test/backend/assets/sidecar/metadata_v2.xmp#L8
(also in the JPG):
$ exiftool -Rating* test/backend/assets/sidecar/metadata_v2.jpg
Rating Percent                  : 0
Rating                          : 0

If you look at no_metadata_v3.xmp on the other hand, there is no rating defined at all. In such a case, I think no rating should be expected, but with this merge, rating = 0 is effectively ignored.

I'm working on my own fork, pulling in these changes. My work is about consolidating all this metadata mapping. Currently there are 3 copies of roughly the same logic:
embedded metadata, video-sidecar and photo-sidecar
I want to make them into the same logic, taking all old and new changes and functionality into account of course. I'm a bit troubled by this one, though. Hence the question above. Is it intentional to ignore rating 0 and if so, why? :)
kind regards :)

@grasdk yes, it was intentional to ignore rating = 0. I decided based on my experience with Digikam. When you set rating and later unset it, Digikam stores rating = 0 in metadata instead of clearing the property. So Digikam makes no distinction between no rating and rating = 0 AFAICT. In PG2 I originally got a mix of rating= and rating=0 in that case, which just cluttered the filter.

Love to Digikam :) I use it aswell. Pigallery2 is a perfect fit to "share" your metadata work in digikam in a useful (and fast) way :)


Should not need to call terraform get

Fixes https://github.com/gruntwork-io/terratest/issues/877
We should not have to make a call to GetE, as InitE should be sufficient to handle all the necessary initialization procedures.

Thanks for review! Merging this in now!


Uncaught Error: ENOENT: no such file or directory, open '/tmp/plantuml-preview/test.svg'

[Enter steps to reproduce below:]

...
...

Atom Version: 1.3.3
System: Ubuntu 15.10
Thrown From: plantuml-preview package, v0.11.0
Stack Trace
Uncaught Error: ENOENT: no such file or directory, open '/tmp/plantuml-preview/test.svg'
At fs.js:549

Error: ENOENT: no such file or directory, open '/tmp/plantuml-preview/test.svg'
    at Error (native)
    at Object.fs.openSync (fs.js:549:18)
    at Object.module.(anonymous function) [as openSync] (ATOM_SHELL_ASAR.js:137:20)
    at Object.fs.readFileSync (fs.js:397:15)
    at Object.fs.readFileSync (ATOM_SHELL_ASAR.js:385:29)
    at /home/arjen/.atom/packages/plantuml-preview/lib/plantuml-preview-view.coffee:449:27
    at exit (/home/arjen/.atom/packages/plantuml-preview/lib/plantuml-preview-view.coffee:478:16)
    at triggerExitCallback (/usr/share/atom/resources/app.asar/src/buffered-process.js:213:47)
    at /usr/share/atom/resources/app.asar/src/buffered-process.js:220:18
    at Socket.<anonymous> (/usr/share/atom/resources/app.asar/src/buffered-process.js:98:18)
    at emitOne (events.js:82:20)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:469:12)

Commands
     -0:01.4.0 plantuml-preview:toggle (atom-text-editor.editor.is-focused)

Config
{
  "core": {}
}

Installed Packages
# User
plantuml-preview, v0.11.0

# Dev
No dev packages

Going to need a bit more information. Are the paths to java and plantuml jar configured?

Believe this is a duplicate of #8.

I didn't configure any paths. Just installed plantuml out of the Ubuntu repository and was hopeful it would just work out of the box. Perhaps that's my fault :smile:

Early on, and maybe still, Atom had some issues with picking up the system path on OS X. I made the decision to go with configuration values. The README should probably be updated to list the required configuration.
With 0.11.1 the error messages should be informative and help resolve configuration issues.


*: add ceo image key to render it in MCO template

This will serve as a feature gate. An empty image field will mean
cluster-etcd-operator is not enabled and the cluster is
bootstrapping 4.2 style. A lot left to do for making etcd-member
manifest file boot without 4.2 but this is a start.

depends hexfusion/machine-config-operator#8

rebased, @hexfusion PTAL

@hexfusion addressed the comments, PTAL


Add a SQL file example changing authentication as SHA-2 to native (#1392)

I completed the 3 steps below:

[x] I've read the Contribution Guide.
[x] I've updated the documentation. (refer to this for how to do so).
[x] I enjoyed my time contributing and making developer's life easier :)

Haha, I created the PR in my local environment several minutes ago, but found your PR when I wanted to push the commit..

I think there are 2 ways to fix auth issue of mysql 8:

your patch: apply for locally each new user, still keep new auth mechanism of mysql8
configure to change default auth of mysql 8 to the old one (globally). When starting container mysql, use this command to start:

mysql:
    image: mysql
    command: mysqld --default-authentication-plugin=mysql_native_password

Would you please add additional second method into this PR too?
It's great if you can help to add some more comments into documentation.
Thanks.

Fixed in https://github.com/laradock/laradock/pull/2510


saSubmitting blog posts and case studies

asasa

/triage needs-information
This issue doesn't report a bug nor does it request an improvement. Please add those details (or close it if posted in error).


Theme preview palette is black or white when minimum-contrast > 1

Contents of $XDG_CONFIG_HOME/ghostty/config:
minimum-contrast = 1.1

Run ghostty +list-themes and notice that the palette colors on the top right are all black or white.
I can reproduce this on macOS (latest) and Linux (Arch).

Example screenshots

Duplicate of #3074

Ah, I missed that, thanks.


Save etymological data

As I can tell for now, everything from wiktionary's "etymology" section is being ignored.
I couldn't find it anywhere in the db, neither could I find any indications in papers from readme of this data being stored.
Could you please add feature for saving etymological data or if it is already stored, point me where I can find it?

To my regret, the etymology section at this moment do not parsed at all :(
Sorry, now I have no plans to parse the Etymology section in Russian Wiktionary.
You are welcome to fork this project :)

I think I'll do, if there're no other alternatives.
Anyway, thanks for answer :)


Unable to set recurrence rule for Nth of every month

Proof (Unable to set a new rule for the Nth of every month):

However, I can set the 'On the first X' with no problems:

JS error message:

Running breakpoints show that some attribute from recurrence called 'langauge_code' was supposed to be called over, but it doesn't exist:

Seeing something similar.
Python 3.6
Django==2.2.10
django-recurrence==1.10.1

Trying to set a recurrence for the 1st and 15th of the month through the Django Admin.

The POST request inspected using DevTools (data isn't being passed correctly):

The result

I can modify it using a Django Rest Framework API endpoint by setting the payload as:
'recurrences': 'RRULE:FREQ=MONTHLY;BYMONTHDAY=1,15\nRDATE:20200315T050000Z'

which makes it look like it is a javascript issue, but I'm not able to debug that.

My weak attempt to debug some javascript :)
In my example, it makes it to this line:
https://github.com/django-recurrence/django-recurrence/blob/master/recurrence/static/recurrence/js/recurrence.js#L158
but doesn't get to assign it to items
https://github.com/django-recurrence/django-recurrence/blob/master/recurrence/static/recurrence/js/recurrence.js#L161

Traced the bug to where @SteveHere originally identified it in: https://github.com/django-recurrence/django-recurrence/blob/master/recurrence/static/recurrence/js/recurrence.js#L448
French language logic was added by @ollb in PR https://github.com/django-recurrence/django-recurrence/pull/32
Release was 1.2.0

This was fixed in https://github.com/jazzband/django-recurrence/commit/7190d6ca1f20fb248d516f1b405d0d9ff4b84e18


Add CI stages for linting and testing

We need to be checking linting and testing in the pipeline, I just checked out main and realized our linting is failing w/ lots of failures 🙁

This has been completed


Hint for secret key says 12 words instead of 12 or 24 words

Hint for secret key says 12 words instead of 12 or 24 words

Suggestion: "Enter your 12 or 24-word Secret Key"

LGTM

LGTM


when overwriting existing template, Resource Template tab doesn't show new label and doesn't link to new version

on DEV, there is an existing Resource Template with id testing:literal_and_resource.
its label is a required literal and a required resource
attaching this existing template here
testing_literal_and_resource_revised.json.txt
i made a new version of the Resource Template file, changing the label to this is a revised version of... and changing the name of the first field to I fixed this field

here is the edited version
testing_literal_and_resource_revised.json.txt
I upload the edited version and as expected, am asked if I want to overwrite existing

now I'm still on the Resource Templates tab, but the old label is still showing for the newly uploaded version (it should say this is a revised version...

and when I click on the template to open it, the first field still has the original field name (it should say I fixed this)

I click back to the Resource Templates tab and now the revised label shows up as expected:

but when I open the template, it still shows the old field name, until I do a hard refresh
only after the hard refresh do I see the revised field name reflected

this is in Firefox on Mac and this is all in a single session

To address this, upon saving a new RT, if that RT is also already in state, it should be updated (or a new load should be triggered, which would force an update).


Fix hostname logic

What
Fix template logic for setting custom hostnames:
if_p only checks if property exists (is set). Which is always true for
use_bosh_hostname as we give it default of false in the spec.
This means that template would always render as if use_bosh_hostname was
true, regardless of actual value. Change it to real if to fix logic. We
don't need to test if the property is set at all, because we give it default
value.
Testing
Deploy. Note that bosh hostname (e.g. router.0) is used for hostname value when you set use_bosh_hostname to true and not used otherwise.
Who
not @mtekel

LGTM


[RFR] Replace iteritems to items

With ansible 2.2 and python 3.6 I have this error :
"AnsibleUndefinedVariable: 'dict object' has no attribute 'iteritems'"
This PR fix this.

Does does also work for python 2? And I'm not sure that Ansible even supports python 3 (yet).

Looks like it should work:
https://stackoverflow.com/questions/10458437/what-is-the-difference-between-dict-items-and-dict-iteritems


Persistent Scrollable Header

Hi. Thanks a lot for your lib!
Question: is it possible to add header that will be persistent, i.e. independent of main data updates?
I need a scrollable header containing MapFragment, so I'm adding it after every updateDataSet(). The problem is that header is resource expensive and it blinks when data is refreshing.

@alex-marochko, can you check properties in RV like: not recyclable and stable ids?
Are you using updateDataSet() with animation or without?

@davideas , thanks! It works (changed stable IDs to true).

@alex-marochko, be sure you have unique ids everywhere for the items.


Add support for iRobot Braava m6

Hi, can you add Support for :

Roomba Model: iRobot Braava m6
Roomba Software Version: 3.10.8

Connection is ok, but States are empty.

greets

Support for Braava Jet M6 would also be great for me. Thumbs up!

the adapter support the M6 there is a "feature" on the password detection.
to detect the correct connection settings use the "getpassword" command from
https://github.com/koalazak/dorita980#readme
and paste it to the adapter settings.
it works on my machine... ;-)

use the https://github.com/koalazak/dorita980#readme to get username and password and it works.


[Fix #6519] Allow Style/BlockComments with apiDoc documentation

apiDoc is a nice and very popular library to write documentation and it handles ruby project
in a clean way.
However, the library force us to use the block comments to define the documentation until
they handle regular comments.
Removing offense for this particular case will avoid disabling completely the cop which would
prevent the code to another unwanted =begin / =end comments.
=begin
@api {get} / my endpoint description
=end

=begin
@apiDefine MySharedDocumentation
=end

I'll think about this. Haven't seen anyone use this library, so I wonder if it makes sense to add an exception for it.


Remove deprecated exists

Description of the change
Remove deprecated Async.exists, see #48.

Checklist:

[x] Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
[x] Linked any existing issues or proposals that this pull request should close
[] Updated or added relevant documentation
[x] Added a test for the contribution (if applicable)

Looks like you need to drop an import.

Thanks!


Fixed misspelling in overlapping bars example

The original overlapping bars example spelled the month of May as "Mai".

Haha thanks! :-)


Aspnet core support

Support asp.net core. Requires splitting Halcyon into separate projects.

Pre-release for #10


Update MacGIContext

I used NSLookupAndBindSymbol based on the Documentation from Apple:
https://developer.apple.com/library/archive/documentation/GraphicsImaging/Conceptual/OpenGL-MacProgGuide/opengl_entrypts/opengl_entrypts.html#//apple_ref/doc/uid/TP40001987-CH402-SW6
The address was gotten:

I also changed the file that it looks for when building based on how Brew installs raylib:

Running:

More context from opengl Wiki
https://www.khronos.org/opengl/wiki/Load_OpenGL_Functions#MacOSX


RePoE update massively changed structure

RePoE's gem data, https://raw.githubusercontent.com/brather1ng/RePoE/master/RePoE/data/gems.min.json
is structured completely differently and will require quite a bit of work to update to new format.
Can use legacy source 'https://raw.githubusercontent.com/brather1ng/RePoE/a40af396ecd2b9391a3a14aead7987298c62b799/RePoE/data/gem_tooltips.json'
until update to allow continued function with old values (mainly Vitality changed + alt quality potential)

This app has been updated to work with the new data structure.


[Windows] Move .NET 7.0 to the toolset due to the new Visual Studio version

Description
Move .NET 7.0 to the toolset due to the new Visual Studio version
Related issue:
https://github.com/actions/runner-images/issues/8797
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022

If the change is specific to VS 17.8, shouldn't it only be for the windows20222 image?
My understanding (as per https://github.com/actions/runner-images/issues/7612#issuecomment-1552723883) is that windows2019 doesn't have VS2022? 🤔


Negative LIST /PRECISION not interpreted correctly

Listing with a negative precision does not work "as advertised" in the documentation (the number of digits after the decimal point).
LIST /PREC=6 COS(_X[X=0.0:3.2:0.2])
             VARIABLE : COS(_X[X=0.0:3.2:0.2])
             SUBSET   : 17 points (X)
 0    /  1:  1.00000
 0.2  /  2:  0.98007
 0.4  /  3:  0.92106
 0.6  /  4:  0.82534
 0.8  /  5:  0.69671
 1    /  6:  0.54030
 1.2  /  7:  0.36236
 1.4  /  8:  0.16997
 1.6  /  9: -0.02920
 1.8  / 10: -0.22720
 2    / 11: -0.41615
 2.2  / 12: -0.58850
 2.4  / 13: -0.73739
 2.6  / 14: -0.85689
 2.8  / 15: -0.94222
 3    / 16: -0.98999
 3.2  / 17: -0.99829

LIST /PREC=-6 COS(_X[X=0.0:3.2:0.2])
             VARIABLE : COS(_X[X=0.0:3.2:0.2])
             SUBSET   : 17 points (X)
 0    /  1:  1.
 0.2  /  2:  1.
 0.4  /  3:  1.
 0.6  /  4:  1.
 0.8  /  5:  1.
 1    /  6:  1.
 1.2  /  7:  0.
 1.4  /  8:  0.
 1.6  /  9: -0.
 1.8  / 10: -0.
 2    / 11: -0.
 2.2  / 12: -1.
 2.4  / 13: -1.
 2.6  / 14: -1.
 2.8  / 15: -1.
 3    / 16: -1.
 3.2  / 17: -1.

The negative value was being "ignored" in that is was turned into 1 for the listing.
If LIST /PREC=-6 was used, then the listing in a separate command, the negative value was used, but code was getting called that was not expecting a negative number.
But this is now fixed and a bench test added as of https://github.com/NOAA-PMEL/Ferret/commit/b2a80c300ff415119a0de235f1a6ba561ed81995


Support for tailwind and word wrap

Fixes Issue
Closes #issue_number

Changes proposed

Screenshots

Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers

@Spyware007  Have a look

Can you explain what you have done?


Open the todos example via double-click on MacOS

This PR allows to open the todos example produced by the build action via double-click on MacOS
Thanks in advance for your review! :)

I believe this won't completely work because the upload-artifact action does not properly preserve permissions: https://github.com/actions/upload-artifact/issues/38
However, the changes here are correct! 😄 Hopefully, GitHub eventually fixes their action.

I believe this won't completely work because the upload-artifact action does not properly preserve file permissions: actions/upload-artifact#38

Oh, I didn't know that, it seems the current workaround for that problem consists of creating a GitHub release https://github.com/hecrj/iced/pull/956#pullrequestreview-711514805

However, the changes here are correct! smile Hopefully, GitHub eventually fixes their action.
Thank you! partying_face

Thanks to you for merging my PR! :smile:


allow empty json reports instead of failing

Fixes #47
Specifically check for empty json and not ignoring all invalid json, because in some cases, you just want to see something is wrong.

Coverage increased (+0.01%) to 98.667% when pulling bb3556a780c4d2a2442707269b93ac1dd428813d on lenntt:47_emptyjson into 8e20dda57b6e040d7c4fe9532c42fdf7abe17db3 on wswebcreation:master.

Good job man, tnx. Will make a new version


Search content items by title and base_path

If searching for a field that is not supported, that field is ignored
and it doesn't change the behaviour of the rest of the query
https://trello.com/c/9rpo1V2u/683-search-functionality-on-get-content-collection-endpoint-searching-documents-by-slug-and-title-in-sp

I don't think this quite supports the use case of specialist-publisher, which is to search for a single string and match against both title and slug.

@danielroseman ah I see, I thought they needed some level of granularity. In the case for a single string, they could just call the API with q_title=SEARCH&q_base_path=SEARCH which will match SEARCH in title AND base_path, or do they need an interface that just does q=SEARCH and match against title OR base_path?

If an item previously had a title of foo and it changed to bar and was published, what would happen if you search for q_title=foo? Would it be an empty set of results or would it include the superseded item?

@dougdroper the latter, it needs to be OR.

@tuzz If the latest content_item has a title of foo, then searching for bar would return an empty set. This is just reducing the scope of the existing query, ie, it still gets passed to GetLatest

@danielroseman updated, let me know if that supports the specialist-publishers needs.

Looks good, one minor comment and there is a linting issue.

That's not quite what I asked. I'm not sure what will happen if you search for a title that is no longer the title of the latest content item. Could we possibly write a test to check this?
I'm not sure what the behaviour of this should be, either. Whether we should return the superseded item or whether it should be scoped to only the latest (draft/published) versions.

Docs for that endpoint are here:
https://github.com/alphagov/publishing-api/blob/master/doc/publishing-api-syntactic-usage.md#get-v2content
We might also want to consider adding a pact to gds-api-adapters:
https://github.com/alphagov/gds-api-adapters/blob/master/test/publishing_api_v2_test.rb#L906


How do we send an amount to be paid?

There's no doc (or method I see in the code) to actually submit the payment amount. Am I missing something?

Ignore me... i had it backwards


fix should be sticky not working due to topOffset change

Hey... Could you explain the behavior you were seeing that motivated your changes?

The problem was that after the change the sticky bar would always be sticky even when scroll top is 0.


LCFS - Edit a draft transfer

Description:
Creating the ability to edit a draft transfer. Once a new transfer is saved as a draft, the user is returned to the main transactions table. If a user then clicks on the draft transfer in the transaction table:

they are taken to the edit transfer screen, which is the same as the new transfer screen but with the user inputted details of the transfer already pre-populated in the different input fields.
The user is able to change these input values and save as a draft, which will overwrite the previously saved input data
The user is able to sign and send the transfer if they have the right role (Signing Authority); note the sign and send functionality will be developed in card #220; this bullet here is simply to note that the button should be visible on this page
The transfer ID (e.g., transaction ID) is visible at the top of the page
Only users with the Transfers role can edit the details of a transfer; other BCeID users can view draft transfer but are not able to edit the details.

Wireframe: https://preview.uxpin.com/59145260c7d8cc48969ac79401cc03d84843c3d9#/pages/164927056/simulate/no-panels
Purpose and benefit to user:
Users can change the details of their draft transfers prior to executing them.
Acceptance Criteria:

[x] Given I am a BCeID user, and I'm on transfer role then I should be able to edit the Draft transfer.
[ ] Given I am a BCeID user but not on transfer role, then shouldn't be able to edit but still be able to access and view the transfer in read only mode.

Development Checklist:

[ ] Role based implementation is required.

Notes:

Hey team! Please add your planning poker estimate with Zenhub @prv-proton @jig-patel

The transfer ID (e.g., transaction ID) is not visible at the top of the page.
What the current edit transfer page shows:

Example for how the transfer ID # should be showing on the edit transfer page:

Acceptance criteria not met:
Given I am a BCeID user but not on transfer role, then shouldn't be able to edit but still be able to access and view the transfer in read only mode.
As a BCeID user, I am still able to edit and save a transfer without being assigned the 'transfer' role to my user profile.

As a BCeID user with the 'signing authority' only role, I can correctly only save it or sign and send it. But when I select 'Save draft', the green validation message I receive is incorrect. It should say 'Draft transfer successfully saved'. See screenshot for current incorrect validation message:

As a BCeID user with the 'transfer' only role, I can edit a draft transfer, but when I select 'Save draft', I received a Failed 500 error:

Still getting an error when I select "save draft". The new input for compliance units field is not persisting after I hit 'save draft'. It continues to revert back to the previously saved input and I get the following error (please see screenshot):

Still getting an error when I select "save draft". The new input for compliance units field is not persisting after I hit 'save draft'. It continues to revert back to the previously saved input and I get the following error (please see screenshot):

@Grulin, This was related to issue with user role, it had the government role attached to it. Have removed it from DB now it should work.


Error when using Vue2.7 + Webpack5

Describe the bug
There are 2 export errors when using Vue2.7 + Webpack5
export 'render' (imported as 'render') was not found in src/comp/Index.vue
export 'staticRenderFns' (imported as 'staticRenderFns') was not found in src/comp/Index.vue

In webpack.config.js, 2 options are included
Components({
  dir: ['src/comp']
  transformer: 'vue2',
})

These are the versions of the 3 dependencies
"dependencies": {
  "webpack": "^5.74.0",
  "vue": "^2.7.7",
  "unplugin-vue-components": "^0.22.4",
}

Reproduction
After installing the packages with the above versions and adding "dir" will cause the error
System Info
Node: 14.17.3
npm: 6.14.13

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

https://antfu.me/posts/why-reproductions-are-required


add missing option types

@Guichaguri Hey!
I checked:
alwaysPauseOnInterruption supported on Android for both branches: dev / v2, let's merge it and cherry-pick this commit in v2 branch
Thanks

Released in 1.2.4


JSON Serialiser: Handle container end scenario using end-marker

JSON array container parsing logic is end-up with a infinite loop when the parsing completed and there is no enough space to keep end marker in the stream (i.e, loaded reached to the max length). In such case this has to be marked and handle in the consequent iteration.

https://jenkins.code.rdkcentral.com/job/github-triggered/1186/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1394/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1447/ started


Automatically triggered Replace mode using vim in OpenSSH on cmd / powershell though Windows Terminal

Replace input mode will triggered automatically when using vim though OpenSSH Client in cmd.
Environment
Windows build number: [Version 10.0.18362.175]
Windows Terminal version (if applicable): 0.2.1715.0

Remote Linux PC: Ubuntu LTS 1604

OpenSSH Client: Stock version in Windows 10 1903 Build 18362.175

Steps to reproduce

Open Windows Terminal
Open new tab running cmd / powershell / powershell 6
ssh to a Ubuntu 1604 LTS PC
Open any document using vim

Expected behavior

Not trigger any input mode, the status bar at the bottom displays the path of the file that vim opened.
Actual behavior

Triggered Replace input mode.

None of us can reproduce this. Is there anything else unusual about your machine, about your vim configuration, or about your keyboard layout?

Also, does it still happen if you use wsl ssh?

Also, does it still happen if you use wsl ssh?

No, it would not happened when I use wsl ssh

None of us can reproduce this. Is there anything else unusual about your machine, about your vim configuration, or about your keyboard layout?

Keyboard Layout is simple Standard US Layout

[Un]Fortunately I don't think this is a Windows Terminal issue. I see the same behavior using ConEmu on my work machine (not updated to W10 1903 so can't install Windows Terminal there), but not in either Windows Terminal or ConEmu on my home machine (W10 1903). Both machines have Standard US Layout and both English US and English US International input languages. I see no change in this behavior on either machine based on selected input langauge.

If it doesn't happen in wsl ssh, but it does in win32-openssh, I'd go to their repository and complain there. Thanks!

Seems to be an issue with utf-8 ambiguous characters and Windows cmd console. Flag t_u7 is set by default and so vim will request cursor position and get a bad reply from the ssh client.
Workaround: Adding set t_u7= or set ambw=double to your vimrc should fix the problem. set t_u7= will disable requesting cursor position and ambw=double will set the ambiguous characters mode to double.
For more info see vim reference manual: https://vimhelp.org/term.txt.html
Credits: https://superuser.com/a/1525060
set ambw=double appears to have conflict with airline/powerline characters. I see extra spaces after the <| arrows. set t_u7= works though! – David Woods Jul 9 at 17:12

Windows build number: 10.0.19041.0
Windows Terminal version: 1.2.2022.0 (Preview Build)
WSL2 distribution: Ubuntu 18.04.4 LTS and Debian 10 (both affected)

This bug happens in WSL for local sessions as well as remote SSH sessions when running the Terminal Preview build v1.2.2022.0. The latest non-preview release of Terminal v1.1.2021.0 does not inflict this bug on WSL sessions. A note on reproducibility - this happens at random, around 1 in 5 times I open vim it opens in Replace mode.
This comment fixed the issue for me, but is needed in my local .vimrc as well as any remote servers I'm working on. Another fix is to install and use Neovim which is unaffected by this, presumably because it uses utf-8 internally for everything.

Windows 10.
Windows Terminal Preview
Version: 1.2.2022.0
Remote SSH (using windows ssh) -> vim -> starting in Replace mode :(

Yes, this is a well-known issue with Win32-OpenSSH 7.7.

@DHowett I know this is closed as a Win32-OpenSSH bug but I think it was closed prematurely. I'm seeing this in all local non-SSH WSL sessions, as well as all WSL SSH sessions. See my previous comment for details.

Yes, I am also seeing it for local WSL sessions. This is not a SSH bug.

Also having this bug with Windows Terminal v1.2.2381.0 and Preview v1.3.2382.0
It's fine when using 1.1.2233.0

Also having this bug with Windows Terminal since I updated to Version: 1.2.2381.0 on win10

Thanks for the reports, all.

https://github.com/vim/vim/issues/6365

As reported at https://github.com/vim/vim/issues/6365#issuecomment-652583382, conhost seems to return a broken response to two running CPR (cursor position report) requests.
executed command
$ echo -ne "\e[2J\e[2;2H\e[6n\e[3;3H"; echo -ne "\e[6n"; hd

expected result
  ^[[2;2R^[[3;3R
00000000  1b 5b 32 3b 32 52 1b 5b  33 3b 33 52 0a           |.[2;2R.[3;3R.|
0000000d

actual result
  ^[^[[3;3R[2;2R
00000000  1b 1b 5b 33 3b 33 52 5b  32 3b 32 52 0a           |..[3;3R[2;2R.|
0000000d

Thanks. We now have the grim task of determining exactly how this escaped the global console lock that gates every action in conhost :)

This does not happen with THE conventional Windows CMD terminal, nor the built-in Ubuntu CMD Terminal, nor Cmder, nor ConEmu, it only happens with Windows Terminal.

This does not happen with THE conventional Windows CMD terminal, nor the built-in Ubuntu CMD Terminal, nor Cmder, nor ConEmu, it only happens with Windows Terminal.

I have this problem when I go to wsl from everywhere. Does the installation of Windows Terminal replace conhost.exe globally?

replace conhost

No, but this bug has also existed in conhost for at least the past two Windows releases.

@FremdSprach the reports in the linked thread on the Vim repository indicate that it does happen in the traditional console host, so we have to treat this bug like it does happen in the traditional console host.

@DHowett So it is quite a strange one.
Here is my environment, and I tested it many times with different terminals, only the WT fails, weird thing:
C:>ver
Microsoft Windows [Version 10.0.19041.264]
C:>ubuntu
cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.1 LTS"

C:>ver
Microsoft Windows [Version 10.0.19041.264]
@FremdSprach Maybe not so weird. I'm on 10.0.20206.1000 (Insider Preview).

Today I came to notice that the issue was opened on Jun 26, 2019? Well, that's quite a long journey.
What is the biggest obstacle now? Trivial modification and low priority? Or even not debugged?

@FremdSprach https://github.com/microsoft/terminal/issues/1637#issuecomment-687705482
This bug was only reopened a few days ago, after it was initially closed thanks to (what appeared to be) Win32-OpenSSH having a similar issue.
Since then, it’s been a weekend followed by a US holiday, which has occupied most of our US-based team’s time :smile:

Now, that might seem like a weird diagnosis. Until recently, win32-openssh implemented its own terminal emulator! It also implemented its own VT input generator.

Ah, Labor Day, that makes it. It must be a sound and good break without labor~~
Suppose God the savior himself take a same holiday, people across the world would get nobody to pray to. You guys are Savior to the WT-addicted die-hard fans. Hope God's got no holidays and wish you be blessed Thor's hammer :hammer: and hammer it hard :grin:

Just surprised this issue has reopened after a year ago.
Since was told it was an issue in Win32-OpenSSH, then just ignored this issue when it happens.
Hum.

Historical bug awakening the first dragon-rider @SuzunaeHoumi 😀

Okay, here's what's happening.
When we receive a DSR(CPR), the console host attempts to prepend the CPR to the input buffer here:
https://github.com/microsoft/terminal/blob/230b86c9905e0f91f07741664b0814cf43c3a483/src/terminal/adapter/adaptDispatch.cpp#L818-L819
https://github.com/microsoft/terminal/blob/230b86c9905e0f91f07741664b0814cf43c3a483/src/terminal/adapter/adaptDispatch.cpp#L857-L859
Because of the design of the input queue and how it has to remain compatible with (ReadConsoleInput)[https://docs.microsoft.com/en-us/windows/console/readconsoleinput], the CPR is transformed into a series of KEY_EVENT_RECORDs -- one down and one up each for the entire sequence. Just like a user had pressed each of those keys.
Now, this poses a problem for two CPRs being received back-to-back: the second CPR will cause the later position to be prepended to the input queue before the earlier position.
If an application has read input between the two CPRs -- even a single keypress, it will certainly encounter this issue.
In my testing, I saw that the input queue at the time of the second prepend contained...
ESC up
[ DOWN
[ UP
2 DOWN
2 UP
...

indicating that only the first keypress (esc down) had been read and popped out of the queue.
I'll need to wait for my team to be back from vacation/leave to figure out why we went with a prepend, as that decision predates me. :smile:

Reader's notes:
Prepend seems like it was an intentional choice -- we do it in a number of places (every DSR, DA, DA2, DA3, VT52 Identify, DSR-OS, CPR) -- but I do not believe that it is ever correct.
It was introduced on 2017-10-17 in a pull request (!997738) that introduced support for window manipulation sequences over the pty, which we've never documented and quickly replaced with the signal channel. (This will be of particular interest to the folks having the purity discussion about sending an ED down the input handle :grin:).
commit [REDACTED]
Author: @zadjii-msft
Date:   Thu Oct 12 13:03:30 2017 -0700

    We need seperate Append and Perpend WriteInputs

      The InteractDispatch wants to append to the buffer,
      but the adapter needs to prepend to the buffer.

      Tests still don't build.

This comment suggests that we had to add a separate prepend so that InteractDispatch could append. Because this pull request mainly dealt with InteractDispatch, the implication is that the "adapter" was already prepending and we needed to add Prepend...Buffer to disentangle the prepending behavior that "adapter" was using.
However, the code change is fairly obvious in the "adapter". It explicitly goes from appending to prepending with this diff:
diff --git a/src/terminal/adapter/adaptDispatch.cpp b/src/terminal/adapter/adaptDispatch.cpp
index 1089747e5..92ffa5ada 100644
--- a/src/terminal/adapter/adaptDispatch.cpp
+++ b/src/terminal/adapter/adaptDispatch.cpp
@@ -932,7 +932,7 @@ bool AdaptDispatch::_WriteResponse(_In_reads_(cReply) PCWSTR pwszReply, _In_ siz
     if (cInputBuffer > 0)
     {
         DWORD dwWritten = 0;
-        fSuccess = !!_pConApi->WriteConsoleInputW(rgInput, (DWORD)cInputBuffer, &dwWritten);
+        fSuccess = !!_pConApi->PrivatePrependConsoleInput(rgInput, (DWORD)cInputBuffer, &dwWritten);
     }

Mike's on paternity leave (yay!), so I can't exactly ask :smile:

This fix has also been ingested into Windows for a future release.

🎉This issue was addressed in #7583, which has now been successfully released as Windows Terminal v1.3.2651.0.🎉
Handy links:
* [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.3.2651.0)

* [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)

The "Handy links" here takes you to the Preview app, not to the non-preview app.

http://aka.ms/terminal-preview enjoy it

(sorry, I flippantly gave you the preview link anyway ;P)

@DHowett Great work! Finally, and Wonderfully! Thanks so much!
Clouds fade away upon the sky and sunshine shines on earth again!

Thanks!

This still sometimes happens where VIM reports being in replace mode over SSH. Othertimes it correctly goes into Insert Mode.

@wsluser please file a separate bug following the bug template and note the versions of all software involved.


Resolve security issues

Go to security tab
Investigate security issues
Change requirements.txt according to that

Resolved with: PR #63 and #62


High Sierra support ("out of date")

I just tried the initial release on a MBP 14,1 running 10.13.1, and got all three items listed as "out of date". I am guessing this because your backend does not yet handle 10.13, but perhaps a different message would be in order?
BTW: I'd be really curious if MBP141.0167.B00 is the expected System ROM for this machine. Over at https://github.com/Dunedan/mbp-2016-linux/issues/25 we're trying to figure out why the Fedora Live-CD image works for some, and not for others, so your findings that users tend to run vastly different versions of the EFI firmware is potentially relevant to figuring out what's going on. Thanks!

They added High Sierra support but maybe this app needs an update? Doesn't seem to be working for me either

It doesn't work right on Sierra either.  It says my EFI firmware and OS build are out of date, but the tool tips show identical values for "expected" and "actual".

I see the reason for the problem.  In the methods checkFirmwareVersions, checkHighestBuild, and checkOSUpToDate, they are comparing NSString* values using == instead of isEqualToString:.

Hi @gohai, @swrobel, and @jwwalker.
Sorry for the delay! The bug was fixed here, but we haven't released a new build yet.
I will update this issue once the new build is ready, but for now if you're able to build in Xcode yourselves you should see the correct results.
Thanks!


Improve buttons

I want to improve the buttons by using some hover or such effects on it.

Open a PR, we would be happy to merge it :) @ARYAN-CODES-STAR

Please assign me this issue so that I can resolve it under GSSOC-23


Initialize Go Modules and Tag v1.0.0 release

I realize alice had a v1.0.0 release which was removed. Now that modules support for Go is stable and adoption is growing, would it be possible to add back the v1.0.0 release tag and initialize modules for alice? Thanks for your consideration!
Dan

ping @justinas

Thanks for the ping. Are we possibly better off tagging it v2.0.0 in order not to break any configurations that might still rely on the now-deleted v1.0.0 tag?

Note that if you are adopting modules for the first time for a pre-existing repository or set of packages that have already been tagged v2.0.0 or higher before adopting modules, then the recommended best practice is to increment the major version when first adopting modules. For example, if you are the author of foo, and the latest tag for the foo repository is v2.2.2, and foo has not yet adopted modules, then the best practice would be to use v3.0.0 for the first release of foo to adopt modules

https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

ok, v1 without go module and v2 with go module ?

On the other hand:

Why are major versions v0, v1 omitted from import paths?
v1 is omitted from import paths for two reasons. First, many developers will create packages that never make a breaking change once they reach v1, which is something we've encouraged from the start. We don't believe all those developers should be forced to have an explicit v1 when they may have no intention of ever releasing v2. The v1 becomes just noise.
https://github.com/golang/go/issues/24301#issuecomment-371228664

Alice is certainly one of these projects that aims to "never make a breaking change" / "[has] no intention of ever releasing v2". Maybe we could get away with v1.1.0 for the current master and v1.2.0 after adding a go.mod.

indeed

"Alice is certainly one of these projects that aims to "never make a breaking change" / "[has] no intention of ever releasing v2". Maybe we could get away with v1.1.0 for the current master and v1.2.0 after adding a go.mod" - I think this is a great solution and wholly appropriate. I definitely don't think you need a v2 as there's been no breaking changes!

Thanks You @justinas ❤

Woohoo!  Thanks @justinas !


add CommitMarkedOffsets when using a custom onRevoked and AutoCommitMarks

Hello,
When using a goroutine per partition with autocommit marks like in the provided example, the committed offsets are not the ones marked but the ones polled. This is because we issue a commit of uncommitted offsets on revoke here, uncommitted being Uncommitted offsets are always updated on calls to PollFetches..
Since we are consuming multiple polls (thanks to the bufferred channel) and marking them asynchronously, if processing fails or is stopped, the uncommitted offsets are already updated by the different polls and we will skip messages.
The default on revoke callback is not impacted by this.
This PR adds a CommitMarkedOffsets method in order to reduce the boilerplate of using CommitOffsetsSync(ctx, cl.MarkedOffsets(), etc..) when using AutoCommitMarks.
I hope that I am not missing something here.

I tweaked the documentation, tell me if that looks good to you.

lgtm, I'm going to wait on merging this until more features become a candidate for a v1.12 release.


Ensuring that PropelDateTime::getMicrotime() includes the fractional part

See https://github.com/propelorm/Propel2/pull/1258

Already ported

Indeed 🙌


Review and test of PlaceDetail and PlaceUpgrade components

Contracts were re-deployed on Mumbai to test, in addition to the deploy contract transaction(1), I found that now it sends 1 Matic on another transaction(2) into this address.
Change the contract name and references from YourContract to PunkCities
Contracts re-deploy as PunkCities contract, same issue about the second transaction

UI review TODO on new contracts

[ ] Create account
[ ] Create place
[ ] Place detail
[ ] Update place

Having issues with the json file from PunkCities contract

All issues solved, ready to merge to main


Catch rates are all 0%

Just realized too late that the PokeAPI data had 0 for all these fields. :( Need to patch the database.

Common data-wise,  it might be better if you use PokeAPI v1, it has catch-rate value without having to go into /pokemon-species

@shelune In the docs for PokeAPI v1, there is catch_rate. However, the data shows catch_rate: 0 for all of the pokemon.
https://pokeapi.co/docsv1/

Oh sorry I was looking at the example on that page and thought the API was working. Tried in Postman and saw the problem.
Well in v2 they solved that but you actually need to go in /pokemon-species/${id} so...


Adding a project to the list?

Would you accept a matrix utility project into your listing?
https://github.com/vbrusca/ZigMatrixUtils

sure! please send a PR

Will do. Thank you.


Microsoft azure deployment documentation

Hi!
I see you have documentation for azure, GC and Digital ocean. Can you please list documentation for azure as well.
I know there is a generalised one too, but it would be nice if there was one for azure as well
Thanks

We can definitely add a guide for Azure!

Here's an implementation in Azure that uses Azure Container Instances (ACI) to run code-server in a docker container on Azure. It also persists the project and data directories to volumes that are in Azure Storage for persistence of plugins/projects etc.
This is a much more elegant way to run code-server in the cloud than having to provision a VM.
https://github.com/benc-uk/azure-arm/tree/master/container-instances/code-server


"Failed to execute 'decodeAudioData' on 'BaseAudioContext': Unable to decode audio data"

Hi :-) Happening in latest version of Chrome.
Uncaught (in promise) ReferenceError: Mp3LameEncoder is not defined
at mp3cutter.computeData (cutter.js:63:17)
at cutter.js:42:72

install the Mp3LameEncoder library. If it does not work, edit the source in cutter.js


Fix typo

Github -> GitHub

@changeworld : Thanks for your contribution! The author, @Jann-Skotdal, has been notified to review your proposed change.

Merging typo fix


pathfinder_gpu::FilesystemResourceLoader, packaging, and location search strategies

I have a minimal test put together. When creating the FilesystemResourceLoader, this panic occurs:
thread 'main' panicked at 'No suitable `resources/` directory found!', C:\Users\adamn\.cargo\git\checkouts\pathfinder-f0bd20e7aa700f92\f89ed90\gpu\src\resources.rs:54:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Based on the code for locate, this looks  in the current directory and all of its parents for a resources directory from which to load shaders, textures, etc. This clearly works well in-tree, but it will be problematic to run all of my tests from within a vendored pathfinder directory as I'd prefer to use upstream git revisions in Cargo.toml instead of a local checkout. I suspect that this search strategy will present an obstacle to publishing to crates.io. Not trying to throw stones, y'all are definitely aware of limitations here 😸 .
Do you have a plan for handling this in the future, especially w.r.t. packaging apps which use pathfinder? If the resources are small and used by most pathfinder dependents, I'd perhaps be interested in an option to include_bytes the resources. Not sure whether that's feasible.
EDIT: On a re-read, it occurs to me that I forgot to phrase the follow-up question: or should I just implement the trait myself?

I build a small resource loader that compiles everything into pathfinder… maybe it is useful?
(code + build script). It could possibly benefit from some compression

It's very useful! Thank you.
I did a search and it looks like https://crates.io/crates/include-flate was recently published. If I make this work for my needs I'm thinking it's worth sending a PR here behind a feature gate. What do you think?
I'm also curious whether you have thoughts about buildscript vs. proc macro. A proc macro is perhaps a little sketchy, but it would avoid adding a build.rs pass for users who have different resource loaders.

I think what could work, is to turn pathfinder/resources into a crate. Ideally it would have a bunch of data that can be combined with the Add operator to allow something like: resources::SHADERS + resources::FONTS. For the lazy ones there would be resources::ALL.

The main reason for this is that I don't want to have to trigger recompiles when I modify shaders. WebRender did something similar. But I realize it can be inconvenient, so I'm open to ideas for better things to do here.

I like Rust Embed https://crates.io/crates/rust-embed. It leaves the resources in the filesystem for debug builds, but embeds them for release builds.

@Slyklaw seems like a good idea.

I tried to use it from crates.io but I've got the same message: thread 'main' panicked at 'No suitable resources/ directory found!', /Users/florian.blasius/.cargo/registry/src/github.com-1ecc6299db9ec823/pathfinder_resources-0.5.0/src/fs.rs:47:9. How can I bring it to work?

The main reason for this is that I don't want to have to trigger recompiles when I modify shaders.
I actually didn't find that it makes a big impact (assuming incremental compilation).

I'm also trying this out from crates.io and stumble upon this issue. This should definitely be fixes as it makes it hard to include pathfinder in external apps as a crate. I would not care having to recompile when shaders change, user crates won't probably change shaders that often, right?

This is what the EmbeddedResourceLoader is for. Does it work for you?

@pcwalton thanks for mentioning EmbeddedResourceLoader, i didn't realize it existed. the project i started on was cargo culted from one of the things in examples/. would you be open to switching to EmbeddedResourceLoader in the examples so others don't hit this? i can make that change if so

@frewsxcv Sure, works for me.

Opened a pull request here: https://github.com/servo/pathfinder/pull/330